Timeline



Aug 10, 2011:

11:57 PM Changeset in webkit [92825] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip tests added by r92769 on WebKit2 because TestRunner doesn't support
drag and drop by eventSender yet.

  • platform/wk2/Skipped:
11:40 PM Changeset in webkit [92824] by morrita@google.com
  • 4 edits in trunk/LayoutTests

Unreviewed pixel expectations update. New expectations now have
bad grammar markers. (The settings has been enabled since r82159.)

  • platform/mac/editing/pasteboard/paste-text-016-expected.png:
  • platform/mac/editing/selection/move-by-character-005-expected.png:
  • platform/mac/editing/spelling/inline_spelling_markers-expected.png:
11:29 PM Changeset in webkit [92823] by rniwa@webkit.org
  • 16 edits
    4 deletes in trunk

Copying can result in span around block elements on the clipboard
​https://bugs.webkit.org/show_bug.cgi?id=34564

Reviewed by Tony Chang.

Source/WebCore:

Completely overhauled the way WebKit preserves style in copy and paste. Instead of wrapping the entire
serialized contents by a Apple style span, WebKit now adds inline style to the top level elements,
wrap top level text nodes by a style span.

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::collapseTextDecorationProperties): Remove text-decoration property when the value
of -webkit-text-decorations-in-effect is none.
(WebCore::EditingStyle::removeStyleFromRulesAndContext): Since display: inline and float: none are now
added on copy, remove these properties on paste.
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle): Takes Element* instead of StyledElement*.
(WebCore::EditingStyle::forceInline): Added.
(WebCore::getPropertiesNotIn): Remove properties only when the base style has them.

  • editing/EditingStyle.h:
  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::shouldApplyWrappingStyle): Added.
(WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): Takes highestNodeToBeSerialized.
(WebCore::StyledMarkupAccumulator::wrapWithStyleNode): Calls appendStyleNodeOpenTag and styleNodeCloseTag.
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): Extracted from wrapWithStyleNode.
(WebCore::StyledMarkupAccumulator::styleNodeCloseTag): Ditto.
(WebCore::StyledMarkupAccumulator::appendText): Wraps text node with a style span if needed.
Set display: inline and float: none so that it won't be converted to a block on paste side.
(WebCore::StyledMarkupAccumulator::appendElement): Add wrapping style if appropriate; Remove any properties
that are overridden by default style and any style that may conflict with the computed style of node to
avoid modifying the appearance of the serialized nodes.
(WebCore::StyledMarkupAccumulator::serializeNodes): Compute wrapping style; copies of this style are
modified as needed when serializing top-level elements or text nodes. We call traverseNodesForSerialization
with NodeTraversalMode set to DoNotEmitString first to compute the highest node to be serialized. The second
call to the function actually serialize the nodes.
(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization): Extracted from serializeNodes.
Outputs string only if NodeTraversalMode is set to EmitString.
(WebCore::createMarkup): No longer adds wrapping spans.

LayoutTests:

This patch overhauled the way we preserve styles when copying and pasting HTML contents. Many tests progressed
and lost wrapping spans while others are observing different markup on the clipboard as expected.

  • editing/deleting/deleting-line-break-preserves-underline-color-expected.txt: span's style attribute now has

a trailing space.

  • editing/execCommand/insert-list-with-noneditable-content-expected.txt: LightGray is now rgb(211, 211, 211).
  • editing/pasteboard/data-transfer-items-expected.txt: Different serialization.
  • editing/pasteboard/onpaste-text-html-expected.txt: Ditto.
  • editing/pasteboard/paste-4039777-fix-expected.txt: No longer nests ul erroneously or aligns the inner list

to the right.

  • editing/pasteboard/paste-code-in-pre-expected.txt: No longer produces erroneous wrapping span.
  • editing/pasteboard/paste-pre-001-expected.txt: Ditto.
  • editing/pasteboard/paste-pre-002-expected.txt: Ditto.
  • editing/pasteboard/paste-text-012-expected.txt: Ditto.
  • editing/pasteboard/paste-text-with-style-4-expected.txt: Ditto.
  • fast/events/ondrop-text-html-expected.txt: Different serialization.
  • platform/chromium-win/editing/pasteboard/paste-code-in-pre-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt: Removed.
  • platform/qt-mac/editing/pasteboard/paste-code-in-pre-expected.txt: Removed.
11:16 PM Changeset in webkit [92822] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip a test added by r92769 on Windows port since drag and drop won't work well on Windows port.

  • platform/win/Skipped:
11:00 PM Changeset in webkit [92821] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

GTK and Qt rebaselines after r92792.

  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
10:15 PM Changeset in webkit [92820] by rniwa@webkit.org
  • 2 edits in trunk/Tools

r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
10:01 PM Changeset in webkit [92819] by tkent@chromium.org
  • 13 edits
    14 copies
    6 moves
    1 add
    3 deletes in trunk/LayoutTests

Move <input type=date> tests to fast/forms/date/
​https://bugs.webkit.org/show_bug.cgi?id=66029

Reviewed by Hajime Morita.

  • fast/forms/ValidityState-rangeOverflow-expected.txt: Removed "date" part.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto.
  • fast/forms/ValidityState-stepMismatch-expected.txt: ditto.
  • fast/forms/ValidityState-typeMismatch-date.html: Removed.
  • fast/forms/date: Added.
  • fast/forms/date-input-visible-strings-expected.txt: Removed.
  • fast/forms/date-input-visible-strings.html: Removed.
  • fast/forms/date/ValidityState-rangeOverflow-date-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
  • fast/forms/date/ValidityState-rangeOverflow-date.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
  • fast/forms/date/ValidityState-rangeUnderflow-date.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/date/ValidityState-stepMismatch-date-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
  • fast/forms/date/ValidityState-stepMismatch-date.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/date/ValidityState-typeMismatch-date-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-date-expected.txt.
  • fast/forms/date/ValidityState-typeMismatch-date.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-date.js.
  • fast/forms/date/date-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt.
  • fast/forms/date/date-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
  • fast/forms/date/date-input-visible-strings-expected.txt: Copied from LayoutTests/fast/forms/date-input-visible-strings-expected.txt.
  • fast/forms/date/date-input-visible-strings.html: Copied from LayoutTests/fast/forms/date-input-visible-strings.html.
  • fast/forms/date/date-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
  • fast/forms/date/date-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
  • fast/forms/date/date-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/date/date-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
  • fast/forms/date/input-valueasdate-date-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-date-expected.txt.
  • fast/forms/date/input-valueasdate-date.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-date.js.
  • fast/forms/date/input-valueasnumber-date-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-date-expected.txt.
  • fast/forms/date/input-valueasnumber-date.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-date.js.
  • fast/forms/input-stepup-stepdown-expected.txt: Removed "date" part.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
  • fast/forms/input-type-change3-expected.txt: ditto.
  • fast/forms/input-valueasdate-date-expected.txt: Removed.
  • fast/forms/input-valueasdate-date.html: Removed.
  • fast/forms/input-valueasnumber-date-expected.txt: Removed.
  • fast/forms/input-valueasnumber-date.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed "date" part.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: ditto.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: ditto.
  • fast/forms/script-tests/input-stepup-stepdown.js: ditto.
  • fast/forms/script-tests/input-type-change3.js: ditto.
  • fast/forms/script-tests/input-valueasdate-date.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-date.js: Removed.
9:02 PM Changeset in webkit [92818] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

Test how TouchList behaves with too few arguments
​https://bugs.webkit.org/show_bug.cgi?id=65815

Reviewed by Sam Weinig.

This API is very new and the compatibility cost of making this API
match the specification is minimal. We should align with the
specification and (future) implementations in other browsers by making
this argument required.

  • fast/events/touch/document-create-touch-list-expected.txt:
  • fast/events/touch/script-tests/document-create-touch-list.js:
9:00 PM Changeset in webkit [92817] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

Test how AudioBufferSourceNode reacts when given too few arguments
​https://bugs.webkit.org/show_bug.cgi?id=65816

Reviewed by Sam Weinig.

The WebAudio API is extremely new. It has only been available as an
experimental API in a single browser. The compatibility cost of
tightening up these APIs is tiny and these APIs make very little sense
to call with too-few arguments.

  • webaudio/audionode-expected.txt:
  • webaudio/audionode.html:
8:58 PM Changeset in webkit [92816] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

Add tests of optional arguments for Geolocation
​https://bugs.webkit.org/show_bug.cgi?id=65810

Reviewed by Sam Weinig.

Source/WebCore:

Geolocation's treatment of not-enough-arguments almost matches the
spec. getCurrentPosition and watchPosition work properly, but, because
they are custom, we should use the prettier form of the [Optional]
attribute.

Before this series of patches, clearWatch argument was optional, but
that doesn't match the spec or other browsers. Calling this function
with zero arguments is pretty non-sensical, so there shouldn't be much
compat risk to tightening up our behavior here. Matching other
browsers and the spec seems like the bigger win. If we run into compat
problems, we can re-evaluate this decision.

Test: fast/dom/Geolocation/not-enough-arguments.html

  • page/Geolocation.idl:

LayoutTests:

Test what happens when calling geolocation APIs with too few arguments.

  • fast/dom/Geolocation/not-enough-arguments-expected.txt: Added.
  • fast/dom/Geolocation/not-enough-arguments.html: Added.
7:27 PM Changeset in webkit [92815] by jchaffraix@webkit.org
  • 2 edits in branches/chromium/782/Source/WebCore

2011-08-10 Julien Chaffraix <​jchaffraix@webkit.org>

Unreviewed (4 liners - Chromium only).

Hack to remove the crash from: (properly solved on trunk)
​https://bugs.webkit.org/show_bug.cgi?id=62884

This is one of Chromium's top most crashers and merging the fix from the bug (r89445)
did not help as it relies on other SVG changes being in. This change just
mitigates the crash until it naturely gets resolved when we roll WebKit revision
in Chromium.

  • rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont): Added 2 null-checks here.
6:56 PM Changeset in webkit [92814] by barraclough@apple.com
  • 100 edits in branches/safari-534.51-branch/Source

Merged JavaScriptCore & JavaScriptGlue from 92405 to 92804.

Reviewed by nobody.

../JavaScriptCore:

EXCEPT, Did not merge patches:

92437, 92523.

../JavaScriptGlue:

EXCEPT, Did not merge patches:

92437, 92523.

6:54 PM Changeset in webkit [92813] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Skip some more tests on Lion.

  • platform/mac-lion/Skipped:
6:29 PM Changeset in webkit [92812] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

SVGAElement check for internal non-view anchors is inside ENABLE(SVG_ANIMATION)
​https://bugs.webkit.org/show_bug.cgi?id=66026

Reviewed by Rob Buis.

Move only the SMIL-related code inside the ENABLE(SVG_ANIMATION) block.

No new tests, as it depends on the enabled features.

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

6:17 PM Changeset in webkit [92811] by jam@chromium.org
  • 10 edits
    2 adds in trunk/Source/WebKit/chromium

[chromium] Update WebScrollbar so that it works with overlay scrollbars on Lion
​https://bugs.webkit.org/show_bug.cgi?id=66008

Reviewed by James Robinson.

  • WebKit.gyp:
  • public/WebScrollbar.h:
  • public/WebScrollbarClient.h:
  • src/ScrollbarGroup.cpp: Added.

(WebKit::ScrollbarGroup::ScrollbarGroup):
(WebKit::ScrollbarGroup::~ScrollbarGroup):
(WebKit::ScrollbarGroup::scrollbarCreated):
(WebKit::ScrollbarGroup::scrollbarDestroyed):
(WebKit::ScrollbarGroup::setLastMousePosition):
(WebKit::ScrollbarGroup::scrollSize):
(WebKit::ScrollbarGroup::scrollPosition):
(WebKit::ScrollbarGroup::setScrollOffset):
(WebKit::ScrollbarGroup::invalidateScrollbarRect):
(WebKit::ScrollbarGroup::invalidateScrollCornerRect):
(WebKit::ScrollbarGroup::isActive):
(WebKit::ScrollbarGroup::enclosingScrollableArea):
(WebKit::ScrollbarGroup::isScrollCornerVisible):
(WebKit::ScrollbarGroup::getTickmarks):
(WebKit::ScrollbarGroup::convertFromContainingViewToScrollbar):
(WebKit::ScrollbarGroup::horizontalScrollbar):
(WebKit::ScrollbarGroup::verticalScrollbar):
(WebKit::ScrollbarGroup::minimumScrollPosition):
(WebKit::ScrollbarGroup::maximumScrollPosition):
(WebKit::ScrollbarGroup::visibleHeight):
(WebKit::ScrollbarGroup::visibleWidth):
(WebKit::ScrollbarGroup::contentsSize):
(WebKit::ScrollbarGroup::overhangAmount):
(WebKit::ScrollbarGroup::currentMousePosition):
(WebKit::ScrollbarGroup::shouldSuspendScrollAnimations):
(WebKit::ScrollbarGroup::scrollbarStyleChanged):
(WebKit::ScrollbarGroup::isOnActivePage):
(WebKit::ScrollbarGroup::disconnectFromPage):

  • src/ScrollbarGroup.h: Added.

(WebKit::ScrollbarGroup::scrollCornerRect):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::paint):
(WebKit::WebPluginContainerImpl::reportGeometry):
(WebKit::WebPluginContainerImpl::scrollbarGroup):
(WebKit::WebPluginContainerImpl::willStartLiveResize):
(WebKit::WebPluginContainerImpl::willEndLiveResize):
(WebKit::WebPluginContainerImpl::handleMouseEvent):

  • src/WebPluginContainerImpl.h:
  • src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbar::createForPlugin):
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::~WebScrollbarImpl):
(WebKit::WebScrollbarImpl::setScrollOffset):
(WebKit::WebScrollbarImpl::invalidateScrollbarRect):
(WebKit::WebScrollbarImpl::getTickmarks):
(WebKit::WebScrollbarImpl::convertFromContainingViewToScrollbar):
(WebKit::WebScrollbarImpl::scrollbarStyleChanged):
(WebKit::WebScrollbarImpl::isOverlay):
(WebKit::WebScrollbarImpl::setValue):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseMove):
(WebKit::WebScrollbarImpl::onMouseLeave):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):

  • src/WebScrollbarImpl.h:

(WebKit::WebScrollbarImpl::scrollOffset):
(WebKit::WebScrollbarImpl::scrollbar):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::willStartLiveResize):
(WebKit::WebViewImpl::willEndLiveResize):

6:08 PM Changeset in webkit [92810] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Removed some incorrect code that was dead.

Reviewed by Oliver Hunt.

clearSingleTransition() wasn't resetting m_data. Luckily,
no one cares, because its caller was unused. Removed both.

  • runtime/Structure.cpp:
  • runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTable::~StructureTransitionTable):

6:02 PM Changeset in webkit [92809] by timothy_horton@apple.com
  • 3 edits
    2 adds in trunk

Crash when clicking an SVG <a> link to the local document
​https://bugs.webkit.org/show_bug.cgi?id=66019
<rdar://problem/9933311>

Reviewed by Rob Buis.

Source/WebCore:

Check if the target element of an internal link is valid before
making use of it.

Test: svg/custom/click-internal-anchor-with-use-crash.xhtml

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

LayoutTests:

Add a test which programmatically clicks a link referring to "#",
and should crash between r89745 and this commit.

  • svg/custom/click-internal-anchor-with-use-crash-expected.txt: Added.
  • svg/custom/click-internal-anchor-with-use-crash.xhtml: Added.
5:54 PM Changeset in webkit [92808] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Return from _ewk_view_smart_add if smart data can not be allocated
​https://bugs.webkit.org/show_bug.cgi?id=65853

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.

It prevents the crash while allocating a memory for view's smart data.
Others checking are needed for support single and tiled backing store.
As a result an empty window will be displayed.

  • ewk/ewk_view.cpp:

(_ewk_view_smart_add):
(_ewk_view_smart_resize):
(_ewk_view_smart_move):
(_ewk_view_smart_show):
(_ewk_view_smart_hide):

  • ewk/ewk_view_single.c:

(_ewk_view_single_smart_add):
(_ewk_view_single_smart_resize):

  • ewk/ewk_view_tiled.c:

(_ewk_view_tiled_smart_add):

5:50 PM Changeset in webkit [92807] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

JSC should always throw when function arg list is too long
​https://bugs.webkit.org/show_bug.cgi?id=65869

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-08-10
Reviewed by Oliver Hunt.

Previous change forgot to update some of the tests in fast/js/function-apply.html so we're doing it now.

  • fast/js/function-apply-expected.txt:
  • fast/js/script-tests/function-apply.js:
5:43 PM Changeset in webkit [92806] by commit-queue@webkit.org
  • 2 edits in trunk

WebViewImpl::selectionRange should return false if there is no selection
​https://bugs.webkit.org/show_bug.cgi?id=66012

Patch by Varun Jain <​varunjain@google.com> on 2011-08-10
Reviewed by Darin Fisher.

  • Source/WebKit/chromium/src/WebViewImpl.cpp:
5:27 PM Changeset in webkit [92805] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Enable WebGL by default for QtWebKit
​https://bugs.webkit.org/show_bug.cgi?id=65998

Reviewed by Benjamin Poulain.

Make ENABLE_WEBGL true by default when Qt is configured with OpenGL.

No new tests. Build change only.

  • features.pri:
5:17 PM Changeset in webkit [92804] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r92670-r92744): WebKit crashes when opening Gmail
​https://bugs.webkit.org/show_bug.cgi?id=66010

Reviewed by Oliver Hunt.

Made sure that Construct calls use() on the this argument.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

5:00 PM Changeset in webkit [92803] by eric@webkit.org
  • 3 edits in trunk/Tools

new-run-webkit-test's WinPort has no fallback logic
​https://bugs.webkit.org/show_bug.cgi?id=64486

Unreviewed.

Turns out that we've long had a subtle bug whereby if you didn't
already have DumpRenderTree built, we might end up running unsupported tests
because the DumpRenderTree --print-supported-features check would silently fail.

When I moved the call from using popen to using Executive.run_command, this silent
failure became noisy. (Breaking some bots.)

This re-orders our steps so that we always build DRT before collecting expectations,
as well as adds a warning message when DumpRenderTree can't be found.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4:51 PM Changeset in webkit [92802] by dslomov@google.com
  • 7 edits in trunk/Source/WebKit/chromium

[Chromium] Decouple implementation of allowFileSystem, openFileSystem and allowDatabase from WebWorkerBase.
​https://bugs.webkit.org/show_bug.cgi?id=65997.

This patch moves implementation of allowFileSystem, openFileSystem and allowDatabase from
WebWorkerBase to respectively LocalFileSystemChromium and DatabaseObserver,
parameterizing them with relevant data from WebWorker.

Reviewed by Jian Li.

  • src/DatabaseObserver.cpp: Move allowDatabase from WebWorkerBase and update the caller.

(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::cancel):
(WebKit::AllowDatabaseMainThreadBridge::result):
(WebKit::AllowDatabaseMainThreadBridge::signalCompleted):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::AllowDatabaseMainThreadBridge::didComplete):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):

  • src/LocalFileSystemChromium.cpp: Move allowFileSystem and openFileSystem from WebWorkerBase and update the caller.

(WebCore::openFileSystemHelper):

  • src/WebWorkerBase.cpp: Move allowFileSystem, openFileSystem and allowDatabase to LocalFileSystemChromium and DatabaseObserver resp.
  • src/WebWorkerBase.h:

(WebKit::WebWorkerBase::webView):

  • src/WorkerFileSystemCallbacksBridge.cpp: Generalized WorkerFileSystemCallbacksBridge to work on WorkerLoaderProxy, not on WebWorkerBase.

(WebKit::WorkerFileSystemCallbacksBridge::stop):
(WebKit::WorkerFileSystemCallbacksBridge::WorkerFileSystemCallbacksBridge):
(WebKit::WorkerFileSystemCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::mayPostTaskToWorker):

  • src/WorkerFileSystemCallbacksBridge.h:

(WebKit::WorkerFileSystemCallbacksBridge::create):

4:19 PM Changeset in webkit [92801] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed build fix. Do not build LocaleToScriptMappingICU.cpp for now as ICU on Leopard is too old to build this.

4:16 PM Changeset in webkit [92800] by eric@webkit.org
  • 4 edits in trunk/Tools

new-run-webkit-test's WinPort has no fallback logic
​https://bugs.webkit.org/show_bug.cgi?id=64486

Unreviewed. Fix test-webkitpy under Python 2.5.

  • Scripts/webkitpy/layout_tests/port/win.py:
2:51 PM Changeset in webkit [92799] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
​https://bugs.webkit.org/show_bug.cgi?id=65875

Patch by Benjamin Poulain <​benjamin@webkit.org> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.

For some reason, QWidget send fake mouse event on some platform, under certains conditions.

This causes mouse events to be sent twice in some cases. We work around the problem
by defining the first touch point to be a primary touch point (case which hit some
weird condition in QWidget, skipping the generation of fake mouse events).

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):

2:48 PM Changeset in webkit [92798] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Check that we do not need layout before trying to dirty
m_originatingLine for our floats.
​https://bugs.webkit.org/show_bug.cgi?id=65938

Reviewed by Dave Hyatt.

Test: fast/block/float/float-originating-line-deleted-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::clearFloats):

LayoutTests: Tests that we do not crash when trying to access a removed
m_originatingLine for a float.
​https://bugs.webkit.org/show_bug.cgi?id=65938

Reviewed by Dave Hyatt.

  • fast/block/float/float-originating-line-deleted-crash-expected.txt: Added.
  • fast/block/float/float-originating-line-deleted-crash.html: Added.
2:42 PM Changeset in webkit [92797] by commit-queue@webkit.org
  • 6 edits in trunk

JSC should always throw when function arg list is too long
​https://bugs.webkit.org/show_bug.cgi?id=65869

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-08-10
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Changed the behavior of the interpreter and JIT to throw an exception
when too many arguments are passed rather than truncating the list. Added
a new method to create a "Too many arguments." exception used by this
new functionality.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ExceptionHelpers.cpp:

(JSC::createTooManyParamsError):

  • runtime/ExceptionHelpers.h:

LayoutTests:

Changed the tests to make sure passing too many function arguments throws an exception
rather than truncating the arguments.

  • fast/js/function-apply-many-args-expected.txt:
  • fast/js/script-tests/function-apply-many-args.js:
2:03 PM Changeset in webkit [92796] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Add missing regions/exclusions-related files to EFL.

  • CMakeLists.txt:
1:59 PM Changeset in webkit [92795] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Add missing regions/exclusions-related files to Chromium.

  • WebCore.gypi:
1:54 PM Changeset in webkit [92794] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Qt build bustage. Add missing regions/exclusions-related files to their project.

  • WebCore.pro:
1:39 PM Changeset in webkit [92793] by jamesr@google.com
  • 25 edits in trunk/LayoutTests

Update chromium gpu baselines for r92255

  • platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium/test_expectations.txt:
1:36 PM Changeset in webkit [92792] by hyatt@apple.com
  • 43 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=66004

Source/WebCore:

Remove ifdefs for CSS Exclusions (since the feature doesn't exist any longer and has morphed into positioned
floats instead). Go ahead and yank the ifdefs for CSS Regions also and just turn them on.

Reviewed by Adam Roben.

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseWrapShape):
(WebCore::CSSParser::parseFromFlowContent):

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::cssText):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::getShapeValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator RegionOverflow):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • css/CSSWrapShapes.cpp:
  • css/CSSWrapShapes.h:
  • css/SVGCSSValueKeywords.in:
  • dom/Node.cpp:

(WebCore::Node::diff):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::setStyle):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • dom/NodeRenderingContext.h:
  • rendering/RenderFlowThread.cpp:
  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectLayers):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderRegion):
(WebCore::RenderObject::isRenderFlowThread):

  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::renderFlowThreadWithName):

  • rendering/RenderView.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::regionOverflow):
(WebCore::InheritedFlags::setRegionOverflow):
(WebCore::InheritedFlags::initialWrapShape):
(WebCore::InheritedFlags::initialRegionOverflow):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/mac:

Removing the CSS Regions and Exclusions ifdefs.

Reviewed by Adam Roben.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Removing the CSS Regions and CSS Exclusions ifdefs.

Reviewed by Adam Roben.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
the code on by default.

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • Scripts/build-webkit:

LayoutTests:

Removing ifdefs for CSS Exclusions and CSS Regions. The code is now on by default, so the new CSS
properties are showing up in the computed style results.

Reviewed by Adam Roben.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
1:12 PM Changeset in webkit [92791] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Don't create html renderer for SVG <glyphRef>
​https://bugs.webkit.org/show_bug.cgi?id=66000

Reviewed by David Hyatt.

Test: svg/text/glyphref-renderer-create-crash.html

  • svg/SVGGlyphRefElement.h:

LayoutTests: ASSERTION FAILED: curr->isRenderInline()
​https://bugs.webkit.org/show_bug.cgi?id=66000

Reviewed by David Hyatt.

  • svg/text/glyphref-renderer-create-crash-expected.txt: Added.
  • svg/text/glyphref-renderer-create-crash.html: Added.
12:57 PM Changeset in webkit [92790] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk/LayoutTests

[Chromium] plugins/mouse-events-fixedpos.html should pass on win/mac/linux
​https://bugs.webkit.org/show_bug.cgi?id=65841

Patch by Noel Gordon <​noel.gordon@gmail.com> on 2011-08-10
Reviewed by Tony Chang.

Add attribute windowPlugin="false" to the <embed> in this test to force the Chromium
Windows and Linux ports to load the test plugin in windowless mode. The plugin will
then receive events and can log them to the console as required by this test.

Also note, the Apple Mac/Win ports report 0 as the line number for all console.log()
messages, whereas, the Chromium ports report the actual line numbers, hence the need
for separate test results for Chromium.

  • platform/chromium-linux/plugins/mouse-events-fixedpos-expected.txt:
  • platform/chromium-mac/plugins/mouse-events-fixedpos-expected.txt:
  • platform/chromium-win/plugins/mouse-events-fixedpos-expected.txt:
  • platform/chromium/test_expectations.txt: New expectations.
  • plugins/mouse-events-fixedpos.html: Add <embed> attribute windowPlugin="false".
12:53 PM Changeset in webkit [92789] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

OpenTypeSanitizer in chromium gyp files is linked twice
​https://bugs.webkit.org/show_bug.cgi?id=65927

Patch by Scott Graham <​scottmg@google.com> on 2011-08-10
Reviewed by Adam Barth.

No new tests, should just build and link properly on all platforms.

  • WebCore.gyp/WebCore.gyp:
12:52 PM Changeset in webkit [92788] by oliver@apple.com
  • 12 edits in trunk/Source

Make GC checks more aggressive in release builds
​https://bugs.webkit.org/show_bug.cgi?id=66001

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

  • heap/HandleHeap.cpp:

(JSC::HandleHeap::visitStrongHandles):
(JSC::HandleHeap::visitWeakHandles):
(JSC::HandleHeap::finalizeWeakHandles):
(JSC::HandleHeap::writeBarrier):
(JSC::HandleHeap::isLiveNode):
(JSC::HandleHeap::isValidWeakNode):

Increase handle heap validation logic, and make some of
the crashes trigger in release builds as well as debug.

  • heap/HandleHeap.h:

(JSC::HandleHeap::allocate):
(JSC::HandleHeap::makeWeak):

Ditto

  • runtime/JSGlobalData.cpp:

(WTF::Recompiler::operator()):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildren):

Fix GC bugs found while testing this patch

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Fix GC bugs found while testing increased validation logic

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::JSDOMWindowShell):

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createWindowShell):

  • bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::create):

  • bridge/objc/ObjCRuntimeObject.mm:

(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):

  • bridge/objc/objc_instance.mm:
12:47 PM Changeset in webkit [92787] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[skia] Move calls to makeGrContextCurrent into clipPathAntiAliased from callers
​https://bugs.webkit.org/show_bug.cgi?id=65733

This protects against callers of clipPathAntiAliased forgetting to call makeGrContextCurrent.

Patch by Ben Wells <​benwells@chromium.org> on 2011-08-10
Reviewed by James Robinson.

No change in functionality, no new tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clip):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):

12:45 PM Changeset in webkit [92786] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

MarkupAccumulator: make resolution of URLs implicit to appendQuotedURLAttributeValue()
​https://bugs.webkit.org/show_bug.cgi?id=65990

Patch by Benjamin Poulain <​ikipou@gmail.com> on 2011-08-10
Reviewed by Ryosuke Niwa.

Instead of resolving the URLs in the call site of appendQuotedURLAttributeValue(),
the URL is now resolved if necessary in appendQuotedURLAttributeValue().

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
(WebCore::MarkupAccumulator::appendAttribute):

  • editing/MarkupAccumulator.h:
12:42 PM Changeset in webkit [92785] by oliver@apple.com
  • 4 edits in trunk

JSEvaluteScript does not return the correct object when given JSONP data
​https://bugs.webkit.org/show_bug.cgi?id=66003

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Make sure we propagate the result of the function call rather than the
argument.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

Tools:

Add a test case.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(testStringByEvaluatingJavaScriptFromString):

12:35 PM Changeset in webkit [92784] by eric@webkit.org
  • 3 edits in trunk/Tools

WIN: NRWT runs compositing tests on configurations that don't support compositing
​https://bugs.webkit.org/show_bug.cgi?id=64472

Reviewed by Adam Barth.

I think the code was just wrong. It was never splitting the string
into list pieces before.
I've now tested the supported_features code and theoretically it
should now work with Windows DRT.

I also made the list-lookup functions always return lists, to make
it possible to clean up the list-transform code in the future
(I opted not to do that cleanup in this patch, but at least now
both types of feature lookup functions match return types.)

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12:24 PM Changeset in webkit [92783] by bashi@chromium.org
  • 9 edits
    5 adds in trunk

[Chromium] Implement text shaping with font-feature-settings on Linux
​https://bugs.webkit.org/show_bug.cgi?id=65903

Source/WebCore:

  • Modifies Font::codePath() to return Complex when there is font feature settings CSS property.
  • Implements OpenType advanced typography feature using Harfbuzz on Chromium Linux port.

Reviewed by Adam Barth.

Test: css3/font-feature-settings-rendering.html

  • platform/graphics/Font.cpp:

(WebCore::Font::codePath): Returns Complex when fontFeatureSettings exists.

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp:

(WebCore::setupFontFeatures): Added.
(WebCore::ComplexTextController::setupFontForScriptRun): Calls setupFontFeatures().

LayoutTests:

Adds a rendering test for -webkit-font-feature-settings.
This tests disabled for now expect for chromium-linux port.
FeatureTest.ttf is created from scratch by using FontForge.

Reviewed by Adam Barth.

  • css3/font-feature-settings-rendering.html: Added.
  • css3/resources/FeatureTest.ttf: Added.
  • platform/chromium-linux/css3/font-feature-settings-rendering-expected.png: Added.
  • platform/chromium-linux/css3/font-feature-settings-rendering-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Skips css3/font-feature-settings-rendering.html.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
12:13 PM Changeset in webkit [92782] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Notify MemoryCache of decoded data access
​https://bugs.webkit.org/show_bug.cgi?id=65859

Reviewed by James Robinson.

This causes us to call CachedImage::didDraw() which calls CachedResource::didAccessDecodedData()
which updates the LRU for decoded image data and potentially prunes the cache. This is already done
by almost all of the other ports.

The decoded bitmaps obviously use quite a bit of memory, so pruning them when necessary is important.
In my tests, this saves several MB on many popular web pages.

No new tests because no observable difference in functionality.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

11:45 AM Changeset in webkit [92781] by vsevik@chromium.org
  • 17 edits
    6 adds in trunk

Web Inspector: Remove Network.initialContentSet from protocol, store workers content on backend.
​https://bugs.webkit.org/show_bug.cgi?id=65929

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: http/tests/inspector/network/network-shared-worker.html

http/tests/inspector/network/network-worker.html

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didReceiveScriptResponseImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didReceiveScriptResponse):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::didReceiveScriptResponse):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js:
  • inspector/front-end/Resource.js:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::didReceiveResponse):

  • workers/Worker.cpp:

(WebCore::Worker::didReceiveResponse):

  • workers/Worker.h:
  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::didReceiveResponse):

  • workers/WorkerScriptLoaderClient.h:

(WebCore::WorkerScriptLoaderClient::didReceiveResponse):

Source/WebKit/chromium:

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::didReceiveResponse):

LayoutTests:

  • http/tests/inspector/network/network-shared-worker-expected.txt: Added.
  • http/tests/inspector/network/network-shared-worker.html: Added.
  • http/tests/inspector/network/network-worker-expected.txt: Added.
  • http/tests/inspector/network/network-worker.html: Added.
  • http/tests/inspector/network/resources/shared-worker.js: Added.

(onconnect):

  • http/tests/inspector/network/resources/worker.js: Added.
  • platform/chromium/test_expectations.txt:
11:41 AM Changeset in webkit [92780] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Filtering by stylesheet does not update the # reqs, filesizes.
​https://bugs.webkit.org/show_bug.cgi?id=65515

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkLogView.prototype._updateFilter):

11:37 AM Changeset in webkit [92779] by eric@webkit.org
  • 2 edits in trunk/Tools

Clean up ChromiumDriver a little
​https://bugs.webkit.org/show_bug.cgi?id=65995

Unreviewed.

Fix NRWT for chromium. Silly python.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
11:30 AM Changeset in webkit [92778] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Accidentally commented out an assertion in BackingStore::incorporateUpdate
​https://bugs.webkit.org/show_bug.cgi?id=65989

Reviewed by Anders Carlsson.

I couldn't get this assertion to fire in quick testing, let's bring it back.

  • UIProcess/BackingStore.cpp: (WebKit::BackingStore::incorporateUpdate):
10:58 AM Changeset in webkit [92777] by eric@webkit.org
  • 2 edits in trunk/Tools

Clean up ChromiumDriver a little
​https://bugs.webkit.org/show_bug.cgi?id=65995

Reviewed by Adam Barth.

  • We no longer support threading, so remove threading specific code.
  • Add FIXMEs about using ServerProcess instead.
  • Condense option-mapping if-cascade into a for loop.
  • Unindent long if blocks by using early return.
  • Unwrap lines which are needlessly wrapped.

There should be no functional changes here, just code cleanup/dead-code removal.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
10:56 AM Changeset in webkit [92776] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: console messages markers are lost in Resources panel after page reload
​https://bugs.webkit.org/show_bug.cgi?id=60701

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/resource-tree-errors-reload.html

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
(WebInspector.ResourceTreeModel.prototype._addPendingConsoleMessage):
(WebInspector.ResourceTreeModel.prototype._addPendingConsoleMessagesToResource):
(WebInspector.ResourceTreeModel.prototype._addConsoleMessageToResource):
(WebInspector.ResourceTreeModel.prototype._consoleCleared):
(WebInspector.ResourceTreeModel.prototype._bindResourceURL):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-errors-reload-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-errors-reload.html: Added.
10:08 AM Changeset in webkit [92775] by Dimitri Glazkov
  • 6 edits in trunk/Tools

Unmuddle construction options for TestConfiguration.
​https://bugs.webkit.org/show_bug.cgi?id=65988

The TestConfiguration instance is now constructed only using actual values.
Port-based construction is split into a "from_port" class method.

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/base.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
9:35 AM Changeset in webkit [92774] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update expectations for this test. It's just a minor flake.

  • platform/chromium/test_expectations.txt:
9:27 AM Changeset in webkit [92773] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Add device specific settings to support viewport computing
​https://bugs.webkit.org/show_bug.cgi?id=65984

Patch by Lars Knudsen <​lars.knudsen@nokia.com> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Based on patch by Zalan Bujtas.

Added settings for device size, dpi and layout fallback width
to support viewport computing.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setLayoutFallbackWidth):
(WebCore::Settings::layoutFallbackWidth):
(WebCore::Settings::setDeviceWidth):
(WebCore::Settings::deviceWidth):
(WebCore::Settings::setDeviceHeight):
(WebCore::Settings::deviceHeight):
(WebCore::Settings::setDeviceDPI):
(WebCore::Settings::deviceDPI):

Source/WebKit2:

Expose new viewport related WebCore settings to WebKit2.

  • Shared/WebPreferencesStore.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

8:49 AM Changeset in webkit [92772] by eric@webkit.org
  • 3 edits
    1 add in trunk/Tools

Leaks bot shows python logging prefixes as part of summary display
​https://bugs.webkit.org/show_bug.cgi?id=65931

Reviewed by Adam Barth.

The big part of this change is adding a unittesting system for
master.cfg, so mere-mortals can make changes to build.webkit.org
with greatly-reduced risk of breaking the world.

Turns out that in typing up my trival logging fix I made 2 typos,
so hopefully the hour spent getting master.cfg to load was worth it. :)

I also tried to make mastercfg_unittest run as part of test-webkitpy
but right now test-webkitpy requires that unittest files be located in
a module-name-compatible directory. 'build.webkit.org-config' is not
a valid module name.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
    • Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix by using a new _strip_python_logging_prefix function.
    • Also fixed this function to file to work with a more modern simplejson version (which returns unicode objects instead of str objects) and filed a related bug with buildbot.net due to their handling of unicode builder names.
  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
    • BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
    • The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
  • Scripts/webkitpy/thirdparty/init.py:
    • Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
8:43 AM Changeset in webkit [92771] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] wrong annotation for the return value of webkit_web_view_get_hit_test_results()
​https://bugs.webkit.org/show_bug.cgi?id=65985

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2011-08-10
Reviewed by Xan Lopez.

  • webkit/webkitwebview.cpp:
8:34 AM Changeset in webkit [92770] by Dimitri Glazkov
  • 5 edits in trunk/Tools

garden-o-matic should extrapolate failures given a set of known results
​https://bugs.webkit.org/show_bug.cgi?id=65882

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
  • Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,

adjusted all call sites.

  • Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that

makes wider net for specific failures.

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
8:27 AM Changeset in webkit [92769] by commit-queue@webkit.org
  • 17 edits
    6 adds in trunk

Unify the way we generate HTML for an image in the Clipboard
​https://bugs.webkit.org/show_bug.cgi?id=58043

Patch by Benjamin Poulain <​benjamin@webkit.org> on 2011-08-10
Reviewed by Ryosuke Niwa.

Source/WebCore:

Unify the way we generate the markup when dragging and image.

Previously, the code was using the special function imageToMarkup() that was
spread from the Chromium port.
That function ignores some edge cases so this patch replace it by the
more generic MarkupAccumulator (which is also used by the other pasteboard
actions).

The MarkupAccumulator was modified because following r61178, the local filepath
are treated differently (the enum was changed to make this behavior
explicit).

Tests: fast/drag-and-drop/drag-and-drop-image-contenteditable.html

fast/drag-and-drop/drag-and-drop-inputimage-contenteditable.html
fast/drag-and-drop/drag-and-drop-objectimage-contenteditable.html

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::MarkupAccumulator):
(WebCore::MarkupAccumulator::resolveURLIfNeeded):
(WebCore::MarkupAccumulator::appendAttribute):

  • editing/MarkupAccumulator.h:
  • editing/markup.cpp:
  • editing/markup.h:
  • page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::declareAndWriteDragImage):
(WebCore::ClipboardChromium::writeRange):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::declareAndWriteDragImage):
(WebCore::ClipboardGtk::writeRange):

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::markup):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeImage):

  • platform/haiku/PasteboardHaiku.cpp:

(WebCore::Pasteboard::writeSelection):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::declareAndWriteDragImage):
(WebCore::ClipboardQt::writeRange):

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeSelection):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::declareAndWriteDragImage):

LayoutTests:

Add 3 tests for dragging an image-like element to an editable area.

  • editing/pasteboard/drag-and-drop-image-contenteditable-expected.txt: Added.
  • editing/pasteboard/drag-and-drop-image-contenteditable.html: Added.
  • editing/pasteboard/drag-and-drop-inputimage-contenteditable-expected.txt: Added.
  • editing/pasteboard/drag-and-drop-inputimage-contenteditable.html: Added.
  • editing/pasteboard/drag-and-drop-objectimage-contenteditable-expected.txt: Added.
  • editing/pasteboard/drag-and-drop-objectimage-contenteditable.html: Added.
  • platform/qt/Skipped: Qt does not have support for testing drag and drop.
7:37 AM Changeset in webkit [92768] by pfeldman@chromium.org
  • 15 edits in trunk

Web Inspector: auto-completion for string literals doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=65701

Patch by Pavel Feldman <​pfeldman@google.com> on 2011-08-10
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluateOnCallFrame):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):
():

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNamesFromEval):
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.PresenationCallFrame.prototype.evaluate):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

  • inspector/debugger/debugger-completions-on-call-frame-expected.txt:
  • inspector/debugger/debugger-completions-on-call-frame.html:
7:06 AM Changeset in webkit [92767] by caseq@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-08-10 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Rolled DEPS 95813:96009 to pick data url timing fix.

  • DEPS:
7:01 AM Changeset in webkit [92766] by pfeldman@chromium.org
  • 4 edits
    2 deletes in trunk

Web Inspector: CSS editing file containing tabs leads to the whole file change in revision history.
​https://bugs.webkit.org/show_bug.cgi?id=65959

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.prototype._innerSetText):

LayoutTests:

  • inspector/editor/text-editor-model-replace-tabs-expected.txt: Removed.
  • inspector/editor/text-editor-model-replace-tabs.html: Removed.
6:41 AM Changeset in webkit [92765] by pfeldman@chromium.org
  • 15 edits
    1 delete in trunk

Web Inspector: there should be a way to tell what properties are non-enumerable when expanding objects.
​https://bugs.webkit.org/show_bug.cgi?id=65518

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getProperties):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObjectProperty):

  • inspector/front-end/inspector.css:

(.section .properties .dimmed):

LayoutTests:

  • inspector/debugger/debugger-expand-scope-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-getProperties-expected.txt:
  • inspector/runtime/runtime-getProperties.html:
  • platform/chromium/inspector/runtime/runtime-getProperties-expected.txt: Removed.
6:36 AM Changeset in webkit [92764] by apavlov@chromium.org
  • 4 edits in trunk

Web Inspector: [REGRESSION] Editor lost after committing a CSS property value for inline style
​https://bugs.webkit.org/show_bug.cgi?id=65918

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._innerUpdate.stylesCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.parentPane):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):

LayoutTests:

  • inspector/styles/styles-commit-editing.html:
4:53 AM Changeset in webkit [92763] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] API methods check NULL and return proper value.
​https://bugs.webkit.org/show_bug.cgi?id=65844

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.

Check NULL before access to the smart and private data of the view object
and return the proper value if error occurred.

  • ewk/ewk_view.cpp:

(ewk_view_zoom_range_set):
(ewk_view_zoom_range_min_get):
(ewk_view_zoom_range_max_get):
(ewk_view_user_scalable_set):
(ewk_view_user_scalable_get):
(ewk_view_device_pixel_ratio_get):

  • ewk/ewk_view.h:
3:24 AM Changeset in webkit [92762] by tkent@chromium.org
  • 15 edits
    14 copies
    6 moves
    1 add
    3 deletes in trunk/LayoutTests

Move <input type=datetime> tests to fast/forms/datetime/
​https://bugs.webkit.org/show_bug.cgi?id=65970

Reviewed by Hajime Morita.

  • fast/forms/ValidityState-rangeOverflow-expected.txt: Removed "datetime" part.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto.
  • fast/forms/ValidityState-stepMismatch-expected.txt: ditto.
  • fast/forms/ValidityState-typeMismatch-datetime-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-datetime.html: Removed.
  • fast/forms/date-input-visible-strings-expected.txt: Removed "datetime" part.
  • fast/forms/date-input-visible-strings.html: ditto.
  • fast/forms/datetime: Added.
  • fast/forms/datetime/ValidityState-rangeOverflow-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
  • fast/forms/datetime/ValidityState-rangeOverflow-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/datetime/ValidityState-rangeUnderflow-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
  • fast/forms/datetime/ValidityState-rangeUnderflow-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/datetime/ValidityState-stepMismatch-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
  • fast/forms/datetime/ValidityState-stepMismatch-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/datetime/ValidityState-typeMismatch-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-datetime-expected.txt.
  • fast/forms/datetime/ValidityState-typeMismatch-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-datetime.js.
  • fast/forms/datetime/datetime-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt.
  • fast/forms/datetime/datetime-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
  • fast/forms/datetime/datetime-input-visible-string-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-visible-string-expected.txt.
  • fast/forms/datetime/datetime-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html.
  • fast/forms/datetime/datetime-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
  • fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
  • fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/datetime/datetime-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
  • fast/forms/datetime/input-valueasdate-datetime-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-datetime-expected.txt.
  • fast/forms/datetime/input-valueasdate-datetime.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-datetime.js.
  • fast/forms/datetime/input-valueasnumber-datetime-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-datetime-expected.txt.
  • fast/forms/datetime/input-valueasnumber-datetime.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-datetime.js.
  • fast/forms/input-stepup-stepdown-expected.txt: Removed "datetime" part.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
  • fast/forms/input-type-change3-expected.txt: ditto.
  • fast/forms/input-valueasdate-datetime-expected.txt: Removed.
  • fast/forms/input-valueasdate-datetime.html: Removed.
  • fast/forms/input-valueasnumber-datetime-expected.txt: Removed.
  • fast/forms/input-valueasnumber-datetime.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed "datetime" part.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: ditto.
  • fast/forms/script-tests/ValidityState-typeMismatch-datetime.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed "datetime" part.
  • fast/forms/script-tests/input-stepup-stepdown.js: ditto.
  • fast/forms/script-tests/input-type-change3.js: ditto.
  • fast/forms/script-tests/input-valueasdate-datetime.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-datetime.js: Removed.
2:59 AM Changeset in webkit [92761] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

[Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
​https://bugs.webkit.org/show_bug.cgi?id=65969

Unreviewed gardening.

  • platform/qt-4.8/Skipped: Remove http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm, because it isn't Qt 4.8 specific bug.
  • platform/qt/Skipped: Skip http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Update to the correct results.
  • platform/qt/test_expectations.txt: Remove http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm.
2:23 AM Changeset in webkit [92760] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-08-10 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed test fix.

  • inspector/network-status-non-http-expected.txt:
  • inspector/network-status-non-http.html:
2:19 AM Changeset in webkit [92759] by yutak@chromium.org
  • 5 edits
    4 adds in trunk

WebSocket: Add binaryType attribute
​https://bugs.webkit.org/show_bug.cgi?id=65967

Reviewed by Kent Tamura.

Source/WebCore:

Add a new attribute "binaryType" to WebSocket. It controls the data type of MessageEvent
for WebSocket's binary frames.

Tests: http/tests/websocket/tests/hixie76/undefined-attributes.html

http/tests/websocket/tests/hybi/binary-type.html

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::binaryType):
(WebCore::WebSocket::setBinaryType):

  • websockets/WebSocket.h:
  • websockets/WebSocket.idl:

LayoutTests:

  • http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt: Added.
  • http/tests/websocket/tests/hixie76/undefined-attributes.html: Added.
  • http/tests/websocket/tests/hybi/binary-type-expected.txt: Added.
  • http/tests/websocket/tests/hybi/binary-type.html: Added.
2:09 AM Changeset in webkit [92758] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove unused local variable from _ewk_tiled_backing_store_item_process_idler_cb.
​https://bugs.webkit.org/show_bug.cgi?id=65846

As Ewk_Tiled_Backing_Store_Item *it is declared as local variable, but it's never referenced anywhere,
it is better to be removed from _ewk_tiled_backing_store_item_process_idler_cb.

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.

  • ewk/ewk_tiled_backing_store.c:

(_ewk_tiled_backing_store_item_process_idler_cb):

2:07 AM Changeset in webkit [92757] by yutak@chromium.org
  • 7 edits
    1 move
    10 adds
    1 delete in trunk

WebSocket: Accept multiple subprotocols
​https://bugs.webkit.org/show_bug.cgi?id=65247

Reviewed by Kent Tamura.

Source/WebCore:

WebSocket constructor should accept an array of subprotocols if hybi-10 protocol is chosen.

Tests: http/tests/websocket/tests/hybi/invalid-subprotocol-characters.html

http/tests/websocket/tests/hybi/invalid-subprotocols.html
http/tests/websocket/tests/hybi/multiple-subprotocols.html
http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):
If the second argument of WebSocket constructor is an array, build a Vector<String> and
pass it to WebSocket::connect().

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):
Ditto.

  • websockets/WebSocket.cpp:

(WebCore::isValidProtocolCharacter): Added.
(WebCore::isValidProtocolString): Added.
(WebCore::isValidProtocolStringHixie76): Renamed from isValidProtocolString.
(WebCore::joinStrings):
(WebCore::WebSocket::connect):
If an array is provided as a subprotocol, and if hixie-76 is used for this connection, it
must be converted to a string in the same manner as JavaScript's Array.toString() in order
to keep compatibility.

  • websockets/WebSocket.h:

Removed m_protocol because it was not used at all.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::disconnect):
WebSocketChannel may be released before connect() is called, thus m_handshake may be null.

LayoutTests:

Add tests to check whether WebSocket accepts multiple subprotocols in constructor.

  • http/tests/websocket/tests/hybi/accept-first-subprotocol_wsh.py: Added.
  • http/tests/websocket/tests/hybi/invalid-subprotocol-characters-expected.txt: Added.
  • http/tests/websocket/tests/hybi/invalid-subprotocol-characters.html: Added.
  • http/tests/websocket/tests/hybi/invalid-subprotocols-expected.txt: Added.
  • http/tests/websocket/tests/hybi/invalid-subprotocols.html: Added.
  • http/tests/websocket/tests/hybi/multiple-subprotocols-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/hybi/sub-protocol-with-space-expected.txt.
  • http/tests/websocket/tests/hybi/multiple-subprotocols.html: Added.
  • http/tests/websocket/tests/hybi/sub-protocol-with-space-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/sub-protocol-with-space.html:

Removed because hybi-10 does not allow subprotocols containing a space.

  • http/tests/websocket/tests/hybi/workers/multiple-subprotocols-expected.txt: Added.
  • http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html: Added.
  • http/tests/websocket/tests/hybi/workers/resources/multiple-subprotocols.js: Added.

(ws.onopen):
(ws.onmessage):
(ws.onclose):

  • http/tests/websocket/tests/hybi/workers/resources/protocol-test_wsh.py: Copied from http/tests/websocket/tests/hybi/protocol-test_wsh.py.
1:44 AM Changeset in webkit [92756] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Chromium] plugins/mouse-events.html should pass on the mac.
​https://bugs.webkit.org/show_bug.cgi?id=65957

Patch by Noel Gordon <​noel.gordon@gmail.com> on 2011-08-10
Reviewed by Kent Tamura.

Cocoa plugins do not generate adjustCursorEvents. Rebaseline this test result for the
chromium Mac port. Note the WebKit Mac/Win ports report 0 for the line number for all
console.log() events. The Chromium port reports the actual line number, and hence the
need for separate test results for Chromium. Following bug 61721, this test now runs,
and passes on all the Chromium ports. The test confirms user-plugin interactivity, so
we don't regress sites like youtube.com. Refer to bug 11517.

  • platform/chromium-mac/plugins/mouse-events-expected.txt:
  • platform/chromium/test_expectations.txt:
1:25 AM Changeset in webkit [92755] by caseq@chromium.org
  • 5 edits
    2 adds in trunk

2011-08-10 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: Network panel always displays ​file:// resources as "(pending)"
​https://bugs.webkit.org/show_bug.cgi?id=65784

Reviewed by Pavel Feldman.

Test: inspector/network-status-non-http.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.isHttpFamily):

2011-08-10 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: Network panel always displays ​file:// resources as "(pending)"
​https://bugs.webkit.org/show_bug.cgi?id=65784

Reviewed by Pavel Feldman.

  • inspector/network-status-non-http-expected.txt: Added.
  • inspector/network-status-non-http.html: Added.
1:06 AM Changeset in webkit [92754] by tkent@chromium.org
  • 15 edits
    14 copies
    6 moves
    1 add
    3 deletes in trunk/LayoutTests

Move <input type=datetime-local> tests to fast/forms/datetimelocal/
​https://bugs.webkit.org/show_bug.cgi?id=65958

Reviewed by Hajime Morita.

  • fast/forms/ValidityState-rangeOverflow-expected.txt: Removed datetime-local part.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto.
  • fast/forms/ValidityState-stepMismatch-expected.txt: ditto.
  • fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-datetimelocal.html: Removed.
  • fast/forms/date-input-visible-strings-expected.txt: Removed datetime-local and time parts.
  • fast/forms/date-input-visible-strings.html: ditto.
  • fast/forms/datetimelocal: Added.
  • fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
  • fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
  • fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
  • fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt.
  • fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js.
  • fast/forms/datetimelocal/datetimelocal-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt.
  • fast/forms/datetimelocal/datetimelocal-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
  • fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-visible-string-expected.txt.
  • fast/forms/datetimelocal/datetimelocal-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html.
  • fast/forms/datetimelocal/datetimelocal-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
  • fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
  • fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
  • fast/forms/datetimelocal/input-valueasdate-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-datetimelocal-expected.txt.
  • fast/forms/datetimelocal/input-valueasdate-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-datetimelocal.js.
  • fast/forms/datetimelocal/input-valueasnumber-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-datetimelocal-expected.txt.
  • fast/forms/datetimelocal/input-valueasnumber-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-datetimelocal.js.
  • fast/forms/input-stepup-stepdown-expected.txt: Removed datetime-local part.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
  • fast/forms/input-type-change3-expected.txt: ditto.
  • fast/forms/input-valueasdate-datetimelocal-expected.txt: Removed.
  • fast/forms/input-valueasdate-datetimelocal.html: Removed.
  • fast/forms/input-valueasnumber-datetimelocal-expected.txt: Removed.
  • fast/forms/input-valueasnumber-datetimelocal.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed datetime-local part.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: ditto.
  • fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed datetime-local part.
  • fast/forms/script-tests/input-stepup-stepdown.js: Removed datetime-local part.
  • fast/forms/script-tests/input-type-change3.js: Removed datetime-local part.
  • fast/forms/script-tests/input-valueasdate-datetimelocal.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-datetimelocal.js: Removed.
12:39 AM Changeset in webkit [92753] by abarth@webkit.org
  • 9 edits in trunk/LayoutTests

Updated results after ​http://trac.webkit.org/changeset/92744.

  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.png:
  • platform/chromium-mac-leopard/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/chromium-mac-leopard/fast/css-generated-content/table-table-before-after-child-add-expected.png:
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.png:
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.png:
12:36 AM Changeset in webkit [92752] by abarth@webkit.org
  • 4 edits in trunk/Tools

The URL we were computing for retrieving baselines was missing a slash
character because our mocks had an extra slash character. I've
corrected both the code and the mock.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
12:35 AM Changeset in webkit [92751] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Name an enum used in some template arguments.
​https://bugs.webkit.org/show_bug.cgi?id=65953

Patch by Peter Kasting <​pkasting@google.com> on 2011-08-10
Reviewed by Darin Fisher.

  • public/WebHTTPBody.h:
12:06 AM Changeset in webkit [92750] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT heap prediction causes regressions when combined with
aggressive integer prediction
​https://bugs.webkit.org/show_bug.cgi?id=65954

Reviewed by Gavin Barraclough.

Disabled heap prediction, but did not remove the capability.
This improves V8 crypto performance by 20%.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

Aug 9, 2011:

10:35 PM Changeset in webkit [92749] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Use setFontDescription helper to set m_fontDirty.
​https://bugs.webkit.org/show_bug.cgi?id=65956

Reviewed by Dan Bernstein.

No new tests / trivial cleanup.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

10:28 PM Changeset in webkit [92748] by abarth@webkit.org
  • 2 edits in trunk/Tools

Move the quote mark to the right place.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
9:51 PM Changeset in webkit [92747] by dominicc@chromium.org
  • 8 edits in trunk

[V8] The prototype property of DOM constructors should be read-only.
​https://bugs.webkit.org/show_bug.cgi?id=39655

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/dom/prototype-property.html

  • bindings/scripts/CodeGeneratorV8.pm: Make prototypes read-only.
  • bindings/scripts/test/V8/V8TestInterface.cpp: Update expectations.

(WebCore::ConfigureV8TestInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

LayoutTests:

  • platform/chromium/test_expectations.txt: Unskip test for prototypes.
9:43 PM Changeset in webkit [92746] by tkent@chromium.org
  • 13 edits
    14 copies
    6 moves
    1 add
    3 deletes in trunk/LayoutTests

Move <input type=time> tests to fast/forms/time/
​https://bugs.webkit.org/show_bug.cgi?id=65955

Reviewed by Hajime Morita.

  • fast/forms/ValidityState-rangeOverflow-expected.txt: Removed 'time' part.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto.
  • fast/forms/ValidityState-stepMismatch-expected.txt: ditto.
  • fast/forms/ValidityState-typeMismatch-time-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-time.html: Removed.
  • fast/forms/input-stepup-stepdown-expected.txt: Removed 'time' part.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
  • fast/forms/input-type-change3-expected.txt: ditto.
  • fast/forms/input-valueasdate-time-expected.txt: Removed.
  • fast/forms/input-valueasdate-time.html: Removed.
  • fast/forms/input-valueasnumber-time-expected.txt: Removed.
  • fast/forms/input-valueasnumber-time.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed 'time' part.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: ditto.
  • fast/forms/script-tests/ValidityState-typeMismatch-time.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed 'time' part.
  • fast/forms/script-tests/input-stepup-stepdown.js: ditto.
  • fast/forms/script-tests/input-type-change3.js: ditto.
  • fast/forms/script-tests/input-valueasdate-time.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-time.js: Removed.
  • fast/forms/time: Added.
  • fast/forms/time/ValidityState-rangeOverflow-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
  • fast/forms/time/ValidityState-rangeOverflow-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
  • fast/forms/time/ValidityState-rangeUnderflow-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/time/ValidityState-stepMismatch-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
  • fast/forms/time/ValidityState-stepMismatch-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/time/ValidityState-typeMismatch-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-time-expected.txt.
  • fast/forms/time/ValidityState-typeMismatch-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-time.js.
  • fast/forms/time/input-valueasdate-time-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-time-expected.txt.
  • fast/forms/time/input-valueasdate-time.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-time.js.
  • fast/forms/time/input-valueasnumber-time-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-time-expected.txt.
  • fast/forms/time/input-valueasnumber-time.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-time.js.
  • fast/forms/time/time-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt.
  • fast/forms/time/time-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
  • fast/forms/time/time-input-visible-string-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-visible-string-expected.txt.
  • fast/forms/time/time-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html.
  • fast/forms/time/time-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
  • fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
  • fast/forms/time/time-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/time/time-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
7:10 PM Changeset in webkit [92745] by cevans@google.com
  • 3 edits in branches/chromium/835

Merge 92744
BUG=88670
Review URL: ​http://codereview.chromium.org/7497055

7:04 PM Changeset in webkit [92744] by abarth@webkit.org
  • 5 edits in trunk

Source/WebCore: Style change not propagating for before, after content
for table parts.
​https://bugs.webkit.org/show_bug.cgi?id=51862

Fix by Chris Evans (​cevans@chromium.org).
In the table case, make sure to return the before /
after parent rather then the before / after node
itself.

Patch by Abhishek Arya <​inferno@chromium.org> on 2011-08-09
Reviewed by Simon Fraser.

  • rendering/RenderObjectChildList.cpp:

(WebCore::findBeforeAfterParent):

LayoutTests: Fix functional bug where style change was not getting propogated to before, after
content.
​https://bugs.webkit.org/show_bug.cgi?id=51862

Patch by Abhishek Arya <​inferno@chromium.org> on 2011-08-09
Reviewed by Simon Fraser.

  • platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png:
6:49 PM Changeset in webkit [92743] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic should use huerstics to narrow regression range
​https://bugs.webkit.org/show_bug.cgi?id=65948

Reviewed by Dimitri Glazkov.

When analyzing a regression range, if one of the commit messages
mentions the test in question, we now hueristically assume that
revision caused the failure. (I'm shamelessly stealing this idea from
TestFailures.)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
6:44 PM Changeset in webkit [92742] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement string based properties in CSSStyleApplyProperty.
​https://bugs.webkit.org/show_bug.cgi?id=65662

Reviewed by Darin Adler.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyString::ApplyPropertyString):
Added class to handle string based properties.
(WebCore::ApplyPropertyString::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Add initializers for CSSPropertyWebkitHighlight and CSSPropertyWebkitHyphenateCharacter.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Remove existing implementations for CSSPropertyWebkitHighlight and CSSPropertyWebkitHyphenateCharacter.

6:40 PM Changeset in webkit [92741] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Another follow-up for r92728.
​https://bugs.webkit.org/show_bug.cgi?id=65916

  • fast/forms/month/ValidityState-stepMismatch-month-expected.txt: Updated.
6:40 PM Changeset in webkit [92740] by kerz@chromium.org
  • 2 edits in branches/chromium/835/Source/WebCore

Merge 92678 - Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening inspector
​https://bugs.webkit.org/show_bug.cgi?id=65912

Reviewed by Pavel Feldman.

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):

TBR=​caseq@chromium.org
Review URL: ​http://codereview.chromium.org/7552031

6:35 PM Changeset in webkit [92739] by cevans@google.com
  • 10 edits in branches/chromium/835/Source

Merge 92347
BUG=91093
Review URL: ​http://codereview.chromium.org/7497054

6:34 PM Changeset in webkit [92738] by kerz@chromium.org
  • 4 edits
    2 copies in branches/chromium/835

Merge 92672 - Web Inspector: Resources panel does not show main resource cookies.
​https://bugs.webkit.org/show_bug.cgi?id=65770

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-main-cookies.php

  • inspector/InspectorPageAgent.cpp:

(WebCore::allResourcesURLsForFrame):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):

LayoutTests:

  • http/tests/inspector/resource-main-cookies-expected.txt: Added.
  • http/tests/inspector/resource-main-cookies.php: Added.
  • platform/chromium/test_expectations.txt:

TBR=​vsevik@chromium.org
Review URL: ​http://codereview.chromium.org/7608014

6:15 PM Changeset in webkit [92737] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/835

Merge 92692
BUG=91801
Review URL: ​http://codereview.chromium.org/7608013

6:12 PM Changeset in webkit [92736] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT does not speculative integers as aggressively as it should
​https://bugs.webkit.org/show_bug.cgi?id=65949

Reviewed by Gavin Barraclough.

Added a tree walk to propagate integer predictions through arithmetic
expressions.

This is a 71% speed-up on Kraken's imaging-gaussian-blur, which
translates to a 19% speed-up on Kraken overall. It's neutral on
other benchmarks.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::predictInt32):

5:59 PM Changeset in webkit [92735] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Sort signal comments by alphabetical order.
​http://bugs.webkit.org/show_bug.cgi?id=65520

Reviewed by Kent Tamura.

Signals caused by ewk still are listed without any specific rule.
It sure isn't a nice thing to understand the signal list. So, this patch
lists signals by alphabetical order.

  • ewk/ewk_contextmenu.h:
  • ewk/ewk_frame.h:
  • ewk/ewk_view.h:
5:51 PM Changeset in webkit [92734] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG JIT has no way of propagating predictions to loads and calls
​https://bugs.webkit.org/show_bug.cgi?id=65883

Reviewed by Gavin Barraclough.

This introduces the capability to store predictions on graph
nodes. To save space while being somewhat consistent, the
prediction is always stored in the second OpInfo slot (since
a GetById will use the first one for the identifier). This
change is a natural extension of r92593 (global variable
prediction).

This is a 1.5% win on V8 in the arithmetic mean, and a 0.6%
win on V8 in the geometric mean. It is neutral on SunSpider
and Kraken. Interestingly, on V8 it regresses crypto by 3%
while progressing deltablue and richards by 2.6% and 4.3%,
respectively.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::isCellPrediction):
(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isNumberPrediction):
(JSC::DFG::predictionToString):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasPrediction):
(JSC::DFG::Node::getPrediction):
(JSC::DFG::Node::predict):

5:36 PM Changeset in webkit [92733] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Add a missing </script> for r92728.

  • fast/forms/month/ValidityState-stepMismatch-month.html:
5:30 PM Changeset in webkit [92732] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT passes the this argument to constructors even though
it's not necessary
​https://bugs.webkit.org/show_bug.cgi?id=65943

Reviewed by Gavin Barraclough.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitCall):

5:28 PM Changeset in webkit [92731] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix one MIPS instruction to call JITStubThunked_##op
​https://bugs.webkit.org/show_bug.cgi?id=65942

Patch by Chao-ying Fu <​fu@mips.com> on 2011-08-09
Reviewed by Gavin Barraclough.

Changed "bal" to "jalr" for a possible processor mode change from
MIPS32 to MIPS16.

  • jit/JITStubs.cpp:
5:28 PM Changeset in webkit [92730] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark 2 webaudio tests as failed on chromium win.

  • platform/chromium/test_expectations.txt:
5:09 PM Changeset in webkit [92729] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

WKPageCopyPendingAPIRequestURL returns stale result if policy decision set to Ignore
​https://bugs.webkit.org/show_bug.cgi?id=65950
<rdar://problem/9925931>

Reviewed by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
Call clearPendingAPIRequestURL() if the policy decision is PolicyIgnore.

5:05 PM Changeset in webkit [92728] by tkent@chromium.org
  • 15 edits
    7 copies
    8 moves
    8 adds
    4 deletes in trunk/LayoutTests

Move <input type=month> tests to fast/forms/month/
​https://bugs.webkit.org/show_bug.cgi?id=65916

Reviewed by Tony Chang.

  • fast/forms/ValidityState-rangeOverflow-expected.txt: Removed month part.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: Removed month part.
  • fast/forms/ValidityState-stepMismatch-expected.txt: Removed month part.
  • fast/forms/ValidityState-typeMismatch-month-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-month.html: Removed.
  • fast/forms/date-input-visible-strings-expected.txt: Removed month part.
  • fast/forms/date-input-visible-strings.html: Removed month part.
  • fast/forms/input-stepup-stepdown-expected.txt: Removed month part.
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Removed month part.
  • fast/forms/input-type-change3-expected.txt: Removed month part.
  • fast/forms/input-valueasdate-expected.txt: Removed.
  • fast/forms/input-valueasdate-month-expected.txt: Removed.
  • fast/forms/input-valueasdate-month.html: Removed.
  • fast/forms/input-valueasdate.html: Removed.
  • fast/forms/input-valueasnumber-month-expected.txt: Removed.
  • fast/forms/input-valueasnumber-month.html: Removed.
  • fast/forms/month: Added.
  • fast/forms/month/ValidityState-rangeOverflow-month-expected.txt: Added.
  • fast/forms/month/ValidityState-rangeOverflow-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt: Added.
  • fast/forms/month/ValidityState-rangeUnderflow-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/month/ValidityState-stepMismatch-month-expected.txt: Added.
  • fast/forms/month/ValidityState-stepMismatch-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/month/ValidityState-typeMismatch-month-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-month-expected.txt.
  • fast/forms/month/ValidityState-typeMismatch-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-month.js.
  • fast/forms/month/input-valueasdate-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-expected.txt.
  • fast/forms/month/input-valueasdate-month-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-month-expected.txt.
  • fast/forms/month/input-valueasdate-month.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-month.js.
  • fast/forms/month/input-valueasdate.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate.js.
  • fast/forms/month/input-valueasnumber-month-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-month-expected.txt.
  • fast/forms/month/input-valueasnumber-month.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-month.js.
  • fast/forms/month/month-input-type-expected.txt: Added.
  • fast/forms/month/month-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
  • fast/forms/month/month-input-visible-string-expected.txt: Added.
  • fast/forms/month/month-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html.
  • fast/forms/month/month-stepup-stepdown-expected.txt: Added.
  • fast/forms/month/month-stepup-stepdown-from-renderer-expected.txt: Added.
  • fast/forms/month/month-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/month/month-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed month part.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: Removed month part.
  • fast/forms/script-tests/ValidityState-stepMismatch.js: Removed month part.
  • fast/forms/script-tests/ValidityState-typeMismatch-month.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed month part.
  • fast/forms/script-tests/input-stepup-stepdown.js: Removed month part.
  • fast/forms/script-tests/input-type-change3.js: Removed month part.
  • fast/forms/script-tests/input-valueasdate-month.js: Removed.
  • fast/forms/script-tests/input-valueasdate.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-month.js: Removed.
4:54 PM Changeset in webkit [92727] by vangelis@chromium.org
  • 3 edits in branches/chromium/835/Source

Merge 92639 - Scroll animator changes to nail the framerate
​https://bugs.webkit.org/show_bug.cgi?id=65645

Patch by Scott Byer <​scottbyer@chromium.org> on 2011-08-08
Reviewed by James Robinson.

Source/WebCore:

Partial test in ScrollAnimatorNoneTest::Enabled.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::PerAxisData::PerAxisData):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::PerAxisData::animateScroll):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::~ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):

  • platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

  • tests/ScrollAnimatorNoneTest.cpp:

(TEST):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/7604015

4:39 PM Changeset in webkit [92726] by vangelis@chromium.org
  • 3 edits in branches/chromium/835/Source

Merge 92002 - Scroll animation refinements.
​https://bugs.webkit.org/show_bug.cgi?id=65154

Patch by Scott Byer <​scottbyer@chromium.org> on 2011-07-29
Reviewed by Adam Barth.

Fix scroll animation bugs when scrolling to the ends of a document. Smooth over slow event repeat rates
better. Fix tests to allow for unit testing of scrolling up and not just down.

Source/WebCore:

Additional unit tests added to ScrollAnimatorNoneTest:
ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::Parameters::Parameters):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::scroll):

  • platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

Additional unit tests added to ScrollAnimatorNoneTest:
ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper

  • tests/ScrollAnimatorNoneTest.cpp:

(ScrollAnimatorNoneTest::reset):
(ScrollAnimatorNoneTest::updateDataFromParameters):
(ScrollAnimatorNoneTest::animateScroll):
(ScrollAnimatorNoneTest::checkDesiredPosition):
(ScrollAnimatorNoneTest::checkSoftLanding):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/7590014

4:25 PM Changeset in webkit [92725] by andersca@apple.com
  • 7 edits
    6 copies
    2 adds in trunk/LayoutTests

Add the final batch of Lion specific SVG test results.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1: Added.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
  • platform/mac-snowleopard/svg/text: Added.
  • platform/mac-snowleopard/svg/text/text-intro-05-t-expected.png: Copied from platform/mac/svg/text/text-intro-05-t-expected.png.
  • platform/mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Copied from platform/mac/svg/text/text-intro-05-t-expected.txt.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/mac/svg/text/text-intro-05-t-expected.png:
  • platform/mac/svg/text/text-intro-05-t-expected.txt:
4:18 PM Changeset in webkit [92724] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Skip a couple of SVG tests that are missing parts of the content for some odd reason.

  • platform/mac-lion/Skipped:
4:01 PM Changeset in webkit [92723] by Lucas Forschler
  • 1 copy in tags/Safari-534.51.11

New tag.

3:52 PM Changeset in webkit [92722] by andersca@apple.com
  • 16 edits
    15 copies in trunk/LayoutTests

Add Lion tests results for a couple of bidi SVG tests.

  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
3:45 PM Changeset in webkit [92721] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

Add a Radar number to a skipped test.

  • platform/mac-lion/Skipped:
3:39 PM Changeset in webkit [92720] by andersca@apple.com
  • 2 edits in trunk/Websites/webkit.org

Broken link to LICENSE on contributing code page
​https://bugs.webkit.org/show_bug.cgi?id=65947

Reviewed by Ryosuke Niwa.

  • coding/contributing.html:
3:31 PM Changeset in webkit [92719] by andersca@apple.com
  • 2 edits
    1 copy
    1 add in trunk/LayoutTests

Add an expected result for svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg and check if it's
possible to have a pixel test result in a different platform directory from a text result.

  • platform/mac-snowleopard/svg/W3C-I18N: Added.
  • platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
3:23 PM Changeset in webkit [92718] by vangelis@chromium.org
  • 12 edits in branches/chromium/835

Merge 92255 - Source/WebCore: [Chromium] Use edge-distance method for layer anti-aliasing.
​https://bugs.webkit.org/show_bug.cgi?id=64942

Patch by David Reveman <​reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.

Use an edge distance based method instead of the current linear
filtering method for producing anti-aliased edges on 3D transformed
layers. This removes the outer border handling from TilingData as
it's no longer needed for anti-aliasing.

Tests: platform/chromium/compositing/tiny-layer-rotated.html (existing)

platform/chromium/compositing/huge-layer-rotated.html (existing)
compositing/images/content-image-change.html (existing)
TilingDataTest in webkit_unit_tests

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::screenMatrix):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::setDrawViewportRect):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::windowMatrix):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::setTileSize):
(WebCore::LayerTilerChromium::tileLayerRect):
(WebCore::LayerTilerChromium::invalidateRect):
(WebCore::LayerTilerChromium::prepareToUpdate):
(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::growLayerToContain):
(WebCore::LayerTilerChromium::drawTiles):

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderTile::VertexShaderTile):
(WebCore::VertexShaderTile::init):
(WebCore::VertexShaderTile::getShaderString):
(WebCore::FragmentTexAlphaAABinding::FragmentTexAlphaAABinding):
(WebCore::FragmentTexAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexSwizzleAlphaAA::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderTile::vertexTexTransformLocation):
(WebCore::FragmentTexAlphaAABinding::alphaLocation):
(WebCore::FragmentTexAlphaAABinding::samplerLocation):
(WebCore::FragmentTexAlphaAABinding::fragmentTexTransformLocation):
(WebCore::FragmentTexAlphaAABinding::edgeLocation):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::setIsMask):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/gpu/TilingData.cpp:

(WebCore::computeNumTiles):
(WebCore::TilingData::tileXIndexFromSrcCoord):
(WebCore::TilingData::tileYIndexFromSrcCoord):
(WebCore::TilingData::tileSizeX):
(WebCore::TilingData::tileSizeY):
(WebCore::TilingData::intersectDrawQuad):
(WebCore::TilingData::textureOffset):

  • platform/graphics/gpu/TilingData.h:

Source/WebKit/chromium: [Chromium] Remove outer border from TilingData as it's no longer needed by layer compositor for anti-aliasing.
​https://bugs.webkit.org/show_bug.cgi?id=64942

Patch by David Reveman <​reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.

  • tests/TilingDataTest.cpp:

(WebCore::TEST):

LayoutTests: [Chromium] Use edge-distance method for layer anti-aliasing.
​https://bugs.webkit.org/show_bug.cgi?id=64942

Patch by David Reveman <​reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.

Update expected results.

  • platform/chromium/test_expectations.txt:

TBR=​jamesr@google.com
Review URL: ​http://codereview.chromium.org/7590009

3:12 PM Changeset in webkit [92717] by eric@webkit.org
  • 5 edits in trunk/Tools

new-run-webkit-test's WinPort has no fallback logic
​https://bugs.webkit.org/show_bug.cgi?id=64486

Reviewed by Adam Roben.

I've tried to write a patch for bug 64439 twice now, and both times
I've ended up re-writing half the port system. So I'm breaking
things up into smaller pieces, this being the first.

WinPort still does not have any port_name parsing, so when instantiated
with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.

Otherwise this should "just work" for windows. I've not been able to test the
version detection on my mac, but the unit tests show the code behaving as designed.

  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
3:10 PM Changeset in webkit [92716] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Add a WebKit prefix to the user default.

Reviewed by Dan Bernstein.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

3:09 PM Changeset in webkit [92715] by mrowe@apple.com
  • 2 edits in trunk/Source/ThirdParty

Fix gtest to compile in the release configuration with clang.

This change was made upstream in r443.

  • gtest/src/gtest.cc:
2:53 PM Changeset in webkit [92714] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Tweak an expected result.

  • platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt:
2:52 PM Changeset in webkit [92713] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Add a user default to disable the plug-in process message timeout
​https://bugs.webkit.org/show_bug.cgi?id=65945

Reviewed by Adam Roben.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add a disablePluginProcessMessageTimeout member variable.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
Initialize the disablePluginProcessMessageTimeout member variable from the
"DisablePluginProcessMessageTimeout" user default.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::defaultSyncMessageTimeout):
Return NoTimeout if WebProcess::disablePluginProcessMessageTimeout returns true.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
Initialize m_disablePluginProcessMessageTimeout.

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::disablePluginProcessMessageTimeout):
Add getter.

2:52 PM Changeset in webkit [92712] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Switch RenderBlock to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=65396

Reviewed by Eric Seidel.

No new tests, no new functionality.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::RenderBlock::isPointInOverflowControl):
(WebCore::RenderBlock::hitTestFloats):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::logicalWidthForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::setLogicalHeightForFloat):
(WebCore::RenderBlock::setLogicalWidthForFloat):

2:45 PM Changeset in webkit [92711] by barraclough@apple.com
  • 475 edits
    22 adds
    10 deletes in branches/safari-534.51-branch

Merged JavaScriptCore & JavaScriptGlue from 86722 to 92405.

Reviewed by nobody.

Source/JavaScriptCore:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

Source/JavaScriptGlue:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

Source/WebCore:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

Source/WebKit/mac:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

Source/WebKit2:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

Tools:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

LayoutTests:

EXCEPT, Did not merge patches:

86837, 89283, 90643, 92068, 92254.

ALSO, Did merge full patch (including non-JSC/JSG changes) for:

87346, 88587, 89069, 90383, 91095, 91194, 91195, 91790, 91903, 92224.

2:38 PM Changeset in webkit [92710] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG JIT failure loading web site
​https://bugs.webkit.org/show_bug.cgi?id=65930

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Put the use() call after the fpr()/gpr() calls, since doing otherwise
breaks the register allocator.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

LayoutTests:

Reviewed by Oliver Hunt.

Reproduced the failure seen in
​http://www.skinnytaste.com/2011/06/ricotta-cheese-chocolate-chip-muffins.html

  • fast/js/boxed-double-to-int-expected.txt: Added.
  • fast/js/boxed-double-to-int.html: Added.
  • fast/js/script-tests/boxed-double-to-int.js: Added.

(boxedDoubleToInt):

2:32 PM Changeset in webkit [92709] by jpfau@apple.com
  • 8 edits
    2 adds in trunk/Source/WebCore

Initial pass at a new XML tree builder
​https://bugs.webkit.org/show_bug.cgi?id=65803

Reviewed by Adam Barth.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::~NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::append):
(WebCore::NewXMLDocumentParser::finish):
(WebCore::NewXMLDocumentParser::finishWasCalled):

  • xml/parser/NewXMLDocumentParser.h:
  • xml/parser/XMLTreeBuilder.cpp: Added.

(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::processToken):
(WebCore::XMLTreeBuilder::pushCurrentNode):
(WebCore::XMLTreeBuilder::popCurrentNode):
(WebCore::XMLTreeBuilder::processProcessingInstruction):
(WebCore::XMLTreeBuilder::processXMLDeclaration):
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::processStartTag):
(WebCore::XMLTreeBuilder::processEndTag):
(WebCore::XMLTreeBuilder::processCharacter):
(WebCore::XMLTreeBuilder::processCDATA):
(WebCore::XMLTreeBuilder::processComment):
(WebCore::XMLTreeBuilder::processEntity):
(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):
(WebCore::XMLTreeBuilder::processXMLEntity):
(WebCore::XMLTreeBuilder::processHTMLEntity):
(WebCore::XMLTreeBuilder::add):
(WebCore::XMLTreeBuilder::appendToText):
(WebCore::XMLTreeBuilder::enterText):
(WebCore::XMLTreeBuilder::exitText):
(WebCore::XMLTreeBuilder::NodeStackItem::NodeStackItem):
(WebCore::XMLTreeBuilder::NodeStackItem::hasNamespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::namespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::setNamespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::namespaceForPrefix):

  • xml/parser/XMLTreeBuilder.h: Added.

(WebCore::XMLTreeBuilder::create):
(WebCore::XMLTreeBuilder::NodeStackItem::namespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::setNamespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::node):
(WebCore::XMLTreeBuilder::NodeStackItem::setNode):

2:21 PM Changeset in webkit [92708] by abarth@webkit.org
  • 6 edits in trunk/Tools

Teach build.webkit.org's garden-o-matic how to talk to the local server
​https://bugs.webkit.org/show_bug.cgi?id=65940

Reviewed by Dimitri Glazkov.

After this patch, the version of garden-o-matic on build.webkit.org is
fully functional. It can interact with the local server via CORS.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • Scripts/webkitpy/tool/commands/gardenomatic.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
2:17 PM Changeset in webkit [92707] by abarth@webkit.org
  • 3 edits in trunk/Tools

Enable CORS for garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=65936

Reviewed by Dimitri Glazkov.

This patch will allow the hosted instance of garden-o-matic to
communicate with the local server.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
1:46 PM Changeset in webkit [92706] by commit-queue@webkit.org
  • 95 edits in trunk/Source

Add ParentClass typedef in all JSC classes
​https://bugs.webkit.org/show_bug.cgi?id=65731

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-08-09
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.

  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:

(JSC::JSCallbackObject::createStructure):
(JSC::JSCallbackObject::visitChildren):

  • API/JSCallbackObjectFunctions.h:

(JSC::::asCallbackObject):
(JSC::::JSCallbackObject):
(JSC::::init):
(JSC::::className):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::getConstructData):
(JSC::::construct):
(JSC::::hasInstance):
(JSC::::getCallData):
(JSC::::call):
(JSC::::getOwnPropertyNames):
(JSC::::toNumber):
(JSC::::toString):
(JSC::::setPrivate):
(JSC::::getPrivate):
(JSC::::inherits):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

  • debugger/DebuggerActivation.h:
  • jsc.cpp:
  • runtime/Arguments.h:
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.h:
  • runtime/BooleanConstructor.h:
  • runtime/BooleanObject.h:
  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.h:
  • runtime/DateInstance.h:
  • runtime/DatePrototype.h:
  • runtime/Error.cpp:
  • runtime/ErrorConstructor.h:
  • runtime/ErrorInstance.h:
  • runtime/ErrorPrototype.h:
  • runtime/ExceptionHelpers.cpp:
  • runtime/Executable.h:
  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.h:
  • runtime/GetterSetter.h:
  • runtime/InternalFunction.h:
  • runtime/JSAPIValueWrapper.h:
  • runtime/JSActivation.h:
  • runtime/JSArray.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.h:
  • runtime/JSObject.h:
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.h:
  • runtime/JSString.h:
  • runtime/JSVariableObject.h:
  • runtime/JSWrapperObject.h:
  • runtime/MathObject.h:
  • runtime/NativeErrorConstructor.h:
  • runtime/NativeErrorPrototype.h:
  • runtime/NumberConstructor.h:
  • runtime/NumberObject.h:
  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.h:
  • runtime/RegExp.h:
  • runtime/RegExpConstructor.h:
  • runtime/RegExpMatchesArray.h:
  • runtime/RegExpObject.h:

(JSC::RegExpObject::create):

  • runtime/RegExpPrototype.h:
  • runtime/ScopeChain.h:
  • runtime/StrictEvalActivation.h:
  • runtime/StringConstructor.h:
  • runtime/StringObject.h:
  • runtime/StringObjectThatMasqueradesAsUndefined.h:
  • runtime/StringPrototype.h:
  • runtime/Structure.h:
  • runtime/StructureChain.h:

Source/JavaScriptGlue:

Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.

  • JSRun.h:
  • UserObjectImp.h:

Source/WebCore:

No new tests.

Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.

  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSOptionConstructor.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateConstructorDeclaration):

  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bridge/c/CRuntimeObject.h:
  • bridge/c/c_instance.cpp:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
  • bridge/jni/jsc/JavaRuntimeObject.h:
  • bridge/objc/ObjCRuntimeObject.h:
  • bridge/objc/objc_runtime.h:
  • bridge/qt/qt_instance.cpp:
  • bridge/qt/qt_pixmapruntime.cpp:
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_array.h:
  • bridge/runtime_method.h:
  • bridge/runtime_object.h:
  • bridge/testqtbindings.cpp:

(Global::className):

Source/WebKit/mac:

Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.

  • Plugins/Hosted/ProxyInstance.mm:
  • Plugins/Hosted/ProxyRuntimeObject.h:

Source/WebKit2:

Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.

  • WebProcess/Plugins/Netscape/JSNPMethod.h:
  • WebProcess/Plugins/Netscape/JSNPObject.h:
1:41 PM Changeset in webkit [92705] by andersca@apple.com
  • 10 edits
    10 copies
    1 add in trunk/LayoutTests

Add updated media test results for Lion.

  • platform/mac-snowleopard/media: Added.
  • platform/mac-snowleopard/media/controls-strict-expected.png: Copied from platform/mac/media/controls-strict-expected.png.
  • platform/mac-snowleopard/media/controls-strict-expected.txt: Copied from platform/mac/media/controls-strict-expected.txt.
  • platform/mac-snowleopard/media/video-controls-rendering-expected.png: Copied from platform/mac/media/video-controls-rendering-expected.png.
  • platform/mac-snowleopard/media/video-controls-rendering-expected.txt: Copied from platform/mac/media/video-controls-rendering-expected.txt.
  • platform/mac-snowleopard/media/video-display-toggle-expected.png: Copied from platform/mac/media/video-display-toggle-expected.png.
  • platform/mac-snowleopard/media/video-display-toggle-expected.txt: Copied from platform/mac/media/video-display-toggle-expected.txt.
  • platform/mac-snowleopard/media/video-layer-crash-expected.png: Copied from platform/mac/media/video-layer-crash-expected.png.
  • platform/mac-snowleopard/media/video-layer-crash-expected.txt: Copied from platform/mac/media/video-layer-crash-expected.txt.
  • platform/mac-snowleopard/media/video-no-audio-expected.png: Copied from platform/mac/media/video-no-audio-expected.png.
  • platform/mac-snowleopard/media/video-no-audio-expected.txt: Copied from platform/mac/media/video-no-audio-expected.txt.
  • platform/mac/media/controls-strict-expected.png:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-layer-crash-expected.png:
  • platform/mac/media/video-no-audio-expected.png:
  • platform/mac/media/video-no-audio-expected.txt:
1:26 PM Changeset in webkit [92704] by crogers@google.com
  • 1 edit
    11 adds in trunk/LayoutTests

Add more Web Audio layout tests
​https://bugs.webkit.org/show_bug.cgi?id=65786

Reviewed by Kenneth Russell.

  • webaudio/audiobuffersource-expected.wav: Added.
  • webaudio/audiobuffersource-playbackrate-expected.wav: Added.
  • webaudio/audiobuffersource-playbackrate.html: Added.
  • webaudio/audiobuffersource.html: Added.
  • webaudio/mixing-expected.wav: Added.
  • webaudio/mixing.html: Added.
  • webaudio/resources/hyper-reality: Added.
  • webaudio/resources/hyper-reality/br-jam-loop.wav: Added.
  • webaudio/resources/hyper-reality/laughter.wav: Added.
  • webaudio/sample-accurate-scheduling-expected.txt: Added.
  • webaudio/sample-accurate-scheduling.html: Added.
1:18 PM Changeset in webkit [92703] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

More Lion skipped list goodness.

  • platform/mac-lion/Skipped:
12:58 PM Changeset in webkit [92702] by abarth@webkit.org
  • 4 edits in trunk/Tools

Upgrade jquery in TestFailures
​https://bugs.webkit.org/show_bug.cgi?id=65935

Reviewed by Dimitri Glazkov.

Upgrade to a newer version of jQuery with better support for CORS and CSP.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
12:47 PM Changeset in webkit [92701] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

12:46 PM Changeset in webkit [92700] by Lucas Forschler
  • 1 copy in tags/Safari-534.51.10

New tag.

12:42 PM Changeset in webkit [92699] by commit-queue@webkit.org
  • 14 edits in trunk/Source

[Chromium] Enable rubber banding when scrolling.

​https://bugs.webkit.org/show_bug.cgi?id=65707

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-08-09
Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests since this is just syncing changes to chromium platform.

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebInputEvent.h:

(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
(WebKit::WebGestureEvent::WebGestureEvent):

  • public/mac/WebInputEventFactory.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebInputEventConversion.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::GestureEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::handleInputEvent):

  • src/WebViewImpl.h:
  • src/mac/WebInputEventFactory.mm:

(WebKit::gestureEventTypeForEvent):
(WebKit::phaseForNSEventPhase):
(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):

12:29 PM Changeset in webkit [92698] by vsevik@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: XHRs end up in the resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=60321

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/resource-tree-no-xhrs.html

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):

LayoutTests:

  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-no-xhrs.html: Added.
12:27 PM Changeset in webkit [92697] by enne@google.com
  • 12 edits
    3 adds in trunk

Add testing for --force-compositing-mode to windows.internal
​https://bugs.webkit.org/show_bug.cgi?id=65777

Reviewed by Adam Barth.

.:

Add exports for Document::settings().

  • Source/autotools/symbols.filter:

Source/WebCore:

Test: platform/chromium/compositing/force-compositing-mode/force-composite-empty.html

Move initial initialization to settings caching function so that RLC
picks up changes to the force compositing mode flag.

  • WebCore.exp.in:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::updateCompositingLayers):

  • testing/Internals.cpp:

(WebCore::Internals::setForceCompositingMode):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

Add exports for Document::settings().

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Add empty page to test that the root gets a graphics layer.

  • platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt: Added.
  • platform/chromium/compositing/force-compositing-mode/force-composite-empty.html: Added.
12:13 PM Changeset in webkit [92696] by hyatt@apple.com
  • 9 edits in trunk

Fixing 65868 REGRESSION(r92610) caused by 65668 - Optimize floating elements lookup
​https://bugs.webkit.org/show_bug.cgi?id=65871

PerformanceTests:

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-09
Reviewed by Dave Hyatt.

  • Layout/floats.html: Added the nested divs, so that we can test the propagation impact of the floats tree.

Source/WebCore:

Added an interval tree in the FloatingObjects structure. Also added new mechanisms to make
sure the tree is updated correctly when a float is repositioned.

Changed the PODIntervalTree to support giving a search adapter that can be implemented by the
client. I'm not adding a different bug for that because PODIntervalTree is not used anywhere else
and would be hard to test that the change is not breaking anything.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-09
Reviewed by Dave Hyatt.

No new tests, just a refactor on the floating objects data structure.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PODIntervalTree.h:

(WebCore::PODIntervalSearchAdapter::PODIntervalSearchAdapter):
(WebCore::PODIntervalSearchAdapter::lowValue):
(WebCore::PODIntervalSearchAdapter::highValue):
(WebCore::PODIntervalSearchAdapter::collectIfNeeded):
(WebCore::PODIntervalTree::PODIntervalTree):
(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::allOverlapsWithAdapter):
(WebCore::PODIntervalTree::searchForOverlapsFrom):

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree):
(WebCore::PODRedBlackTree::clear):
(WebCore::PODRedBlackTree::isInitialized):
(WebCore::PODRedBlackTree::initIfNeeded):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addPositionedFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::RenderBlock::FloatingObjects::addPlacedObject):
(WebCore::RenderBlock::FloatingObjects::removePlacedObject):
(WebCore::RenderBlock::FloatingObjects::add):
(WebCore::RenderBlock::FloatingObjects::remove):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTree):
(WebCore::::string):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
(WebCore::RenderBlock::FloatingObject::isInPlacedTree):
(WebCore::RenderBlock::FloatingObject::setIsInPlacedTree):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::setHorizontalWritingMode):
(WebCore::RenderBlock::FloatingObjects::set):
(WebCore::RenderBlock::FloatingObjects::placedFloatsTree):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTreeIfNeeded):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):

12:10 PM Changeset in webkit [92695] by rniwa@webkit.org
  • 14 edits
    6 adds
    1 delete in trunk

Source/WebCore: Repeated copy and paste result in nested font elements
​https://bugs.webkit.org/show_bug.cgi?id=65824

Reviewed by Tony Chang.

Modified isInlineNodeWithStyle to match font element. Also made the function match strictly with those nodes that
ApplyStyleCommand may add to avoid removing non-styling elements. And fixed a regression from r81887 that
ReplaceSelectionCommand may remove non-editing styles such as border in the attempt to avoid nesting styling elements.

This patch paves the way to fix the bug 34564.

Tests: editing/pasteboard/paste-text-with-style-2.html

editing/pasteboard/paste-text-with-style-3.html
editing/pasteboard/paste-text-with-style-4.html

  • editing/EditingStyle.cpp:

(WebCore::HTMLElementEquivalent::matches): Takes const Element* instead of Element*.
(WebCore::HTMLAttributeEquivalent::matches): Ditto.
(WebCore::htmlElementEquivalents): Extracted from conflictsWithImplicitStyleOfElement.
(WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Calls htmlElementEquivalents.
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent): Added; determines whether an element is style span
or a styling element (e.g. b, i, font) possibly with editing style.

  • editing/EditingStyle.h:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::isInlineNodeWithStyle): Calls EditingStyle::elementIsStyledSpanOrHTMLEquivalent.
(WebCore::ReplaceSelectionCommand::doApply): More aggressively avoid nesting styling elements.

  • editing/htmlediting.cpp:

(WebCore::highestEnclosingNodeOfType):

  • editing/htmlediting.h:

LayoutTests: Repeated copy and paste result in nested style elements such as b and font
​https://bugs.webkit.org/show_bug.cgi?id=65824

Reviewed by Tony Chang.

Added tests to ensure WebKit does not nest styling elements and does not remove elements with non-editing styles.
Also rebaselined several tests.

Because WebKit serializes all editing inheritable styles on copy, we should be able to remove all inline styles
at the insertion point on paste. And this patch removes inline style elements such as font and b more aggressively.
WebKit erroneously bolded the last words in paste-after-inline-style-element.html and paste-with-redundant-style.html
before this change set but this is no longer the case.

  • editing/pasteboard/5065605-expected.txt: Lost wrapping font and span elements.
  • editing/pasteboard/merge-end-1-expected.txt: Span is split but visually identical.
  • editing/pasteboard/merge-end-2-expected.txt: Ditto.
  • editing/pasteboard/paste-after-inline-style-element-expected.txt: No longer bolds "line 2" erroneously.
  • editing/pasteboard/paste-text-011-expected.txt: Lost wrapping font, b, and span elements.
  • editing/pasteboard/paste-text-with-style-2-expected.txt: Added.
  • editing/pasteboard/paste-text-with-style-2.html: Added.
  • editing/pasteboard/paste-text-with-style-3-expected.txt: Added.
  • editing/pasteboard/paste-text-with-style-3.html: Added.
  • editing/pasteboard/paste-text-with-style-4-expected.txt: Added.
  • editing/pasteboard/paste-text-with-style-4.html: Added.
  • editing/pasteboard/paste-with-redundant-style-expected.txt: Lost wrapping b.
  • editing/pasteboard/paste-with-redundant-style.html: Updated comments per rebaseline.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.
12:01 PM Changeset in webkit [92694] by dslomov@google.com
  • 15 edits in trunk/Source

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates.

Reviewed by Dmitry Titov.

Covered by existing tests.

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):

  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate):
(WebCore::V8BindingPerIsolateData::hiddenPropertyName):
(WebCore::V8BindingPerIsolateData::globalHandleMap):
(WebCore::AllowAllocation::AllowAllocation):Moving to V8Binding.h from V8Utilities.h to resolve header dependency.
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::AllowAllocation::current):
(WebCore::SafeAllocation::newInstance):

  • bindings/v8/V8GCController.cpp:

(WebCore::currentGlobalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::createString):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore::V8HiddenPropertyName::V8HiddenPropertyName):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::checkNewLegal):

  • bindings/v8/V8Utilities.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initIsolate):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):

Source/WebKit/chromium: ​https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates

Reviewed by Dmitry Titov.

  • src/BoundObject.cpp:
11:36 AM Changeset in webkit [92693] by steveblock@google.com
  • 9 edits
    2 deletes in trunk/Source/WebCore

JavaString is not needed by V8
​https://bugs.webkit.org/show_bug.cgi?id=65909

Removes the JavaString wrapper class, moves the JSC implementation
to JavaStringJSC.h and removes the V8 implementation.

Reviewed by Alexey Proskuryakov.

No new tests, refactoring only.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/jni/JavaString.h: Removed.
  • bridge/jni/jni_jsobject.mm:
  • bridge/jni/jsc/JavaFieldJSC.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
  • bridge/jni/jsc/JavaMethodJSC.h:
  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaString::JavaString):
(JSC::Bindings::JavaString::~JavaString):
(JSC::Bindings::JavaString::init):

  • bridge/jni/v8/JavaStringV8.h: Removed.
11:18 AM Changeset in webkit [92692] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

Source/WebCore: Regression(83075): Fix updateAlwaysCreateLineBoxes on information
about full layout which is needed when dirtying lineboxes.
​https://bugs.webkit.org/show_bug.cgi?id=65924

Reviewed by Dave Hyatt.

Test: fast/inline/update-always-create-line-boxes-full-layout-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):

  • rendering/RenderInline.h:

LayoutTests: Tests that we do not crash when trying to dirty line boxes on
a RenderInline needing full relayout.
​https://bugs.webkit.org/show_bug.cgi?id=65924

Reviewed by Dave Hyatt.

  • fast/inline/update-always-create-line-boxes-full-layout-crash-expected.txt: Added.
  • fast/inline/update-always-create-line-boxes-full-layout-crash.html: Added.
11:05 AM Changeset in webkit [92691] by Nate Chapin
  • 15 edits in trunk/Source/WebCore

2011-08-09 Nate Chapin <Nate Chapin>

Remove receivedCancellation() from SubresourceLoaderClient.

​http://bugs.webkit.org/show_bug.cgi?id=65330

Reviewed by Alexey Proskuryakov.

No new tests, no change in functionality intended.

  • loader/DocumentThreadableLoader.cpp:
  • loader/DocumentThreadableLoader.h:
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/ThreadableLoaderClient.h:
  • loader/WorkerThreadableLoader.cpp:
  • loader/WorkerThreadableLoader.h:
  • notifications/Notification.cpp:
  • notifications/Notification.h: Remove receivedCancellation() since it's

identical to didFail(), which is always called immediately after.

  • workers/WorkerScriptLoader.cpp:
  • workers/WorkerScriptLoader.h: Remove receivedCancellation() since it's

identical to didFail(), which is always called immediately after.

  • xml/XMLHttpRequest.cpp:
  • xml/XMLHttpRequest.h: Remove receivedCancellation(). All it does is

set m_response, which is cleared in didFail() before it can be used.

10:08 AM Changeset in webkit [92690] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-08-09 Pavel Feldman <​pfeldman@google.com>

Not reviewed: rebaselining inspector test.

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
10:00 AM Changeset in webkit [92689] by steveblock@google.com
  • 3 edits in trunk/Source/WebCore

Java Bridge leaks local references
​https://bugs.webkit.org/show_bug.cgi?id=64320

Reviewed by Alexey Proskuryakov.

No new tests as this is just an optimization.

  • bridge/jni/jsc/JavaFieldJSC.cpp:

(JavaField::JavaField):

  • bridge/jni/jsc/JavaMethodJSC.cpp:

(JavaMethod::JavaMethod):

9:09 AM Changeset in webkit [92688] by pfeldman@chromium.org
  • 6 edits in trunk

Web Inspector: files from different domains are mixed in the file selector in Scripts panel
​https://bugs.webkit.org/show_bug.cgi?id=65601

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):
(WebInspector.ScriptsPanel.prototype.reset):

  • inspector/front-end/inspector.css:

(select.status-bar-item):

LayoutTests:

  • inspector/debugger/scripts-panel-expected.txt:
  • platform/chromium/inspector/debugger/scripts-sorting-expected.txt:
8:22 AM Changeset in webkit [92687] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-09 Pavel Feldman <​pfeldman@google.com>

Not reviewed: fix inspector tests

  • inspector/styles/show-user-agent-styles.html:
8:01 AM Changeset in webkit [92686] by commit-queue@webkit.org
  • 9 edits in trunk

Unreviewed, rolling out r92683.
​http://trac.webkit.org/changeset/92683
​https://bugs.webkit.org/show_bug.cgi?id=65921

"Breaks Qt --minimal build. Revert pending update of the Qt

minimal configuration" (Requested by simathur on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-09

.:

  • Source/WebKit.pri:

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettings::enablePersistentStorage):

Tools:

  • QtTestBrowser/cookiejar.cpp:

(TestBrowserCookieJar::TestBrowserCookieJar):

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

  • QtTestBrowser/webpage.cpp:

(WebPage::openUrlInDefaultBrowser):

7:55 AM Changeset in webkit [92685] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix warning caused by undefined static api.
​https://bugs.webkit.org/show_bug.cgi?id=65301

Both _ewk_tiled_backing_store_item_request_add and _ewk_tiled_backing_store_item_request_del
are declared, but their bodies are not defined and they are not referenced anywhere.
Therefore, I remove both two API's declaration in order to resolve warning message caused by them.

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2011-08-09
Reviewed by Kenneth Rohde Christiansen.

  • ewk/ewk_tiled_backing_store.c:
7:29 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
7:28 AM Changeset in webkit [92684] by kenneth@webkit.org
  • 12 edits in trunk/Source/WebKit2

[Qt] Redirect didFindZoomableArea thru to the view
​https://bugs.webkit.org/show_bug.cgi?id=65913

Reviewed by Andreas Kling.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::didFindZoomableArea):

  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::didFindZoomableArea):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::didFindZoomableArea):

  • UIProcess/qt/TouchViewInterface.h:
  • UIProcess/qt/ViewInterface.h:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::timerEvent):

  • UIProcess/qt/qdesktopwebpageproxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setContentsScale):

  • UIProcess/qt/qtouchwebpageproxy.h:
7:24 AM Changeset in webkit [92683] by siddharth.mathur@nokia.com
  • 9 edits in trunk

[Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
​https://bugs.webkit.org/show_bug.cgi?id=65880

Reviewed by Andreas Kling.

.:

QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
check for their feature flags. Assume that any reasonable Qt build provides them.

  • Source/WebKit.pri:

Source/WebKit/qt:

QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
check for their feature flags. Assume that any reasonable Qt build provides them.

  • Api/qwebsettings.cpp:

(QWebSettings::enablePersistentStorage):

Tools:

QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
check for their feature flags. Assume that any reasonable Qt build provides them.

  • QtTestBrowser/cookiejar.cpp:

(TestBrowserCookieJar::TestBrowserCookieJar):

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

  • QtTestBrowser/webpage.cpp:

(WebPage::openUrlInDefaultBrowser):

7:24 AM Changeset in webkit [92682] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: provide a way to hide user agent styles
​https://bugs.webkit.org/show_bug.cgi?id=37766

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/show-user-agent-styles.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.get continue):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane):
(WebInspector.StylesSidebarPane.prototype._showUserAgentStylesSettingChanged):

LayoutTests:

  • inspector/styles/show-user-agent-styles-expected.txt: Added.
  • inspector/styles/show-user-agent-styles.html: Added.
7:18 AM Changeset in webkit [92681] by steveblock@google.com
  • 8 edits
    2 moves
    1 delete in trunk/Source/WebCore

JavaMethodJobject is no longer needed by V8
​https://bugs.webkit.org/show_bug.cgi?id=65910

Reviewed by Tony Gentilcore.

Removes the JavaMethod interface and moves the JavaMethodJobject
implementation to bridge/jni/jsc/JavaMethodJSC.[cpp|h].

No new tests, refactoring only.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/jni/JavaMethod.h: Removed.
  • bridge/jni/jsc/JavaClassJSC.cpp:

(JavaClass::JavaClass):

  • bridge/jni/jsc/JavaFieldJSC.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
  • bridge/jni/jsc/JavaMethodJSC.cpp: Renamed from Source/WebCore/bridge/jni/JavaMethodJobject.cpp.

(JavaMethod::JavaMethod):
(JavaMethod::~JavaMethod):
(appendClassName):
(JavaMethod::signature):

  • bridge/jni/jsc/JavaMethodJSC.h: Renamed from Source/WebCore/bridge/jni/JavaMethodJobject.h.

(JSC::Bindings::JavaMethod::name):
(JSC::Bindings::JavaMethod::returnTypeClassName):
(JSC::Bindings::JavaMethod::parameterAt):
(JSC::Bindings::JavaMethod::returnType):
(JSC::Bindings::JavaMethod::isStatic):
(JSC::Bindings::JavaMethod::numParameters):

  • bridge/jni/v8/JavaNPObjectV8.cpp:
7:10 AM Changeset in webkit [92680] by kenneth@webkit.org
  • 10 edits in trunk/Source/WebKit2

[Qt] Vastly improve the algorithm for finding a zoomable area when doing double-tap
​https://bugs.webkit.org/show_bug.cgi?id=65907

Reviewed by Andreas Kling.

This is upstreaming of the algorithm we are currently using on the N9 browser
and this also fixes a bug with not considering the frame positions when finding
a zoomable area.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFindZoomableArea):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::didFindZoomableArea):

  • UIProcess/qt/qdesktopwebpageproxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::didFindZoomableArea):

  • UIProcess/qt/qtouchwebpageproxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findZoomableAreaForPoint):

6:32 AM Changeset in webkit [92679] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] remove temporary #define from WebURLRequest.h
​https://bugs.webkit.org/show_bug.cgi?id=65813

Reviewed by Darin Fisher.

  • public/WebURLRequest.h:
6:24 AM Changeset in webkit [92678] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening inspector
​https://bugs.webkit.org/show_bug.cgi?id=65912

Reviewed by Pavel Feldman.

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):

6:03 AM Changeset in webkit [92677] by yurys@chromium.org
  • 13 edits
    1 copy in trunk/Source/WebCore

Web Inspector: get rid of InspectorInstrumentation::inspectorAgents() map
​https://bugs.webkit.org/show_bug.cgi?id=54678

Added two functions for retrieving InstrumentingAgents from Page and WorkerContext.

Reviewed by Pavel Feldman.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):

  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):

  • inspector/InspectorInstrumentation.h:
  • inspector/InstrumentingAgents.cpp: Copied from Source/WebCore/inspector/WorkerInspectorController.h.

(WebCore::instrumentationForPage):
(WebCore::instrumentationForWorkerContext):

  • inspector/InstrumentingAgents.h:
  • inspector/WorkerInspectorController.h:
5:26 AM Changeset in webkit [92676] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Web Inspector: REGRESSION (r92672): http/tests/inspector/resource-main-cookies.php failing on Qt Linux Release
​https://bugs.webkit.org/show_bug.cgi?id=65911

Unreviewed. Skipped test failing on qt.

  • platform/qt/Skipped:
5:17 AM Changeset in webkit [92675] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
3:39 AM Changeset in webkit [92674] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Add "Refresh" to context menu of resources panel cookies view.
​https://bugs.webkit.org/show_bug.cgi?id=65854

Reviewed by Pavel Feldman.

  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView):
(WebInspector.CookieItemsView.prototype._updateWithCookies):
(WebInspector.CookieItemsView.prototype._refreshButtonClicked):
(WebInspector.CookieItemsView.prototype._contextMenu):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype.get refreshCallback):
(WebInspector.DataGrid.prototype.set refreshCallback):
(WebInspector.DataGrid.prototype._contextMenuInDataTable):

  • inspector/front-end/ResourceCookiesView.js:

(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

3:34 AM Changeset in webkit [92673] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-08-09 Andrei Popescu <​andreip@google.com>

[Chromium] Update test expectations for fast/writing-mode/japanese-rl-text-with-broken-font.html

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
3:33 AM Changeset in webkit [92672] by vsevik@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: Resources panel does not show main resource cookies.
​https://bugs.webkit.org/show_bug.cgi?id=65770

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-main-cookies.php

  • inspector/InspectorPageAgent.cpp:

(WebCore::allResourcesURLsForFrame):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):

LayoutTests:

  • http/tests/inspector/resource-main-cookies-expected.txt: Added.
  • http/tests/inspector/resource-main-cookies.php: Added.
  • platform/chromium/test_expectations.txt:
3:26 AM Changeset in webkit [92671] by commit-queue@webkit.org
  • 14 edits
    1 add in trunk

Unreviewed, rolling out r92670.
​http://trac.webkit.org/changeset/92670
​https://bugs.webkit.org/show_bug.cgi?id=65905

It broke 3 inspector tests (Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-09

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getProperties):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObject.prototype._getProperties.remoteObjectBinder):
(WebInspector.RemoteObject.prototype._getProperties):
(WebInspector.RemoteObjectProperty):

  • inspector/front-end/inspector.css:

(.section .properties .value.dimmed):

LayoutTests:

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-getProperties-expected.txt:
  • inspector/runtime/runtime-getProperties.html:
  • platform/chromium/inspector/runtime/runtime-getProperties-expected.txt: Added.
2:05 AM Changeset in webkit [92670] by pfeldman@chromium.org
  • 14 edits
    1 delete in trunk

Web Inspector: there should be a way to tell what properties are non-enumerable when expanding objects.
​https://bugs.webkit.org/show_bug.cgi?id=65518

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getProperties):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObjectProperty):

  • inspector/front-end/inspector.css:

(.section .properties .dimmed):

LayoutTests:

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-getProperties-expected.txt:
  • inspector/runtime/runtime-getProperties.html:
1:38 AM Changeset in webkit [92669] by abarth@webkit.org
  • 3 edits in trunk/Tools

BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
​https://bugs.webkit.org/show_bug.cgi?id=65891

Reviewed by Eric Seidel.

The problem was that platform/chromium contained a bogus expectation
file that needed to be removed, but by the time we got around to
removing it, we'd already moved the correct baseline into its place.
After this patch, we copy the gold results into memory before
reshuffling things on disk (and we delete bad things before adding good
things).

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1:34 AM Changeset in webkit [92668] by Nikolas Zimmermann
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

2011-08-09 Nikolas Zimmermann <​nzimmermann@rim.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

Not reviewed. More gtk/win gardening.

  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Rebaseline, same result on both gtk 32 bit debug/release and 64bit.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Taken from Win7 bot, WinXP still seems to have a problem.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.
1:27 AM Changeset in webkit [92667] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

Accidentally added build number as revision number in r92666.

12:49 AM Changeset in webkit [92666] by reni@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION(r22030): It made one test failed.

Unreviewed gardening.

  • platform/qt-4.8/Skipped: Skip the failed test.
12:14 AM Changeset in webkit [92665] by Nikolas Zimmermann
  • 1 edit in trunk/Source/WebCore/ChangeLog

Forgot to add the ChangeLog for r92545. Fixed.

Aug 8, 2011:

9:08 PM Changeset in webkit [92664] by tkent@chromium.org
  • 7 edits in trunk/LayoutTests

[Chromium] Update baseline files for r92585.

  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [92663] by cevans@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/rendering/CounterNode.cpp

Merge 92630
BUG=88216
Review URL: ​http://codereview.chromium.org/7601020

8:58 PM Changeset in webkit [92662] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Windows] input-number-size.html is expected to fail because of no spin-button.

  • platform/win/Skipped:
8:55 PM Changeset in webkit [92661] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] Grouping spin-button related tests.
​https://bugs.webkit.org/show_bug.cgi?id=65896

  • platform/qt/Skipped:
6:26 PM Changeset in webkit [92660] by abarth@webkit.org
  • 3 edits in trunk/Tools

Chromium Windows bots can't figure out what SVN revision they're running
​https://bugs.webkit.org/show_bug.cgi?id=65893

Reviewed by Eric Seidel.

The comment in _engage_awesome_windows_hacks explains why we're making
this change. It's ugly and rediculous, but this approach seems better
than using shell=True when calling popen.

  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
5:55 PM Changeset in webkit [92659] by steveblock@google.com
  • 7 edits
    1 move
    5 deletes in trunk/Source/WebCore

Removes V8's JavaInstanceJobject, JavaClassJobject and JavaFieldJobject.
​https://bugs.webkit.org/show_bug.cgi?id=57859

Reviewed by Alexey Proskuryakov.

This effectively reverts the changes made in Bugs 55383, 57533 and

  1. These classes were only used by Android. In the future, Android

will use the Chromium WebKit API to implement the Java bridge.

Towards this goal, this patch ...

  • Simplfies the JavaInstance, JavaClass and JavaField interfaces for V8. These interfaces will be implemented in Chromium's WebKit layer.
  • Adds a JavaMethod interface for V8
  • Removes the jvalue <-> JavaValue conversion functions for V8, which are now superfluous
  • Removes the calls to JavaInstance::begin()/end() for V8, which are now superfluous

Will be covered by existing tests once the Chromium WebKit layer is complete.

  • WebCore.gypi:
  • bridge/jni/v8/JNIUtilityPrivate.cpp:
  • bridge/jni/v8/JNIUtilityPrivate.h:
  • bridge/jni/v8/JavaClassJobjectV8.cpp: Removed.
  • bridge/jni/v8/JavaFieldJobjectV8.cpp: Removed.
  • bridge/jni/v8/JavaFieldJobjectV8.h: Removed.
  • bridge/jni/v8/JavaFieldV8.h:
  • bridge/jni/v8/JavaInstanceJobjectV8.cpp: Removed.
  • bridge/jni/v8/JavaInstanceJobjectV8.h: Removed.
  • bridge/jni/v8/JavaInstanceV8.h:
  • bridge/jni/v8/JavaMethodV8.h:

(JSC::Bindings::JavaMethod::~JavaMethod):

  • bridge/jni/v8/JavaNPObjectV8.cpp:

(JSC::Bindings::JavaNPObjectHasMethod):
(JSC::Bindings::JavaNPObjectInvoke):
(JSC::Bindings::JavaNPObjectHasProperty):
(JSC::Bindings::JavaNPObjectGetProperty):

5:49 PM Changeset in webkit [92658] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

Fix thread-safety of AudioNode deletion
​https://bugs.webkit.org/show_bug.cgi?id=65888

Reviewed by Kenneth Russell

No new tests - JavaScript API is not affected.

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::uninitialize):
(WebCore::AudioContext::handlePostRenderTasks):
(WebCore::AudioContext::scheduleNodeDeletion):
(WebCore::AudioContext::deleteMarkedNodesDispatch):
(WebCore::AudioContext::deleteMarkedNodes):

  • webaudio/AudioContext.h:
5:25 PM Changeset in webkit [92657] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-08-08 Chris Marrin <​cmarrin@apple.com>

Fix build breakage caused by ​http://trac.webkit.org/changeset/92651

Unreviewed.

  • WebCore.exp.in:
5:19 PM Changeset in webkit [92656] by abarth@webkit.org
  • 1 edit
    3 deletes in trunk/Tools

Remove deduplicate-tests
​https://bugs.webkit.org/show_bug.cgi?id=65886

Reviewed by Tony Chang.

This script is redundant with "webkit-patch bulk-optimize-baselines",
which can find many more duplicates than deduplicate-tests because
bulk-optimize-baselines can move results around whereas
deduplicate-tests can only remove results.

  • Scripts/deduplicate-tests: Removed.
  • Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
  • Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
5:11 PM Changeset in webkit [92655] by abarth@webkit.org
  • 3 edits in trunk/Tools

scm.delete should delete empty parent directories as well
​https://bugs.webkit.org/show_bug.cgi?id=65878

Reviewed by Eric Seidel.

This behavior makes SVN match GIT (which has no concept of empty
directories). This bug comes up a lot when optimizing baselines, which
often create empty directories when we're able to optimize everything
out of a given folder.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
5:05 PM Changeset in webkit [92654] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This should actually be the correct fix for
fast/js/regexp-overflow.html. The bug in bulk-optimize-baselines is
​https://bugs.webkit.org/show_bug.cgi?id=65891.

  • platform/chromium/fast/js/regexp-overflow-expected.txt:
4:34 PM Changeset in webkit [92653] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add fast/js/regexp-overflow.html result back for Chromium. I'm not
sure why bulk-rebaseline-tests remove it. There's some bug in the
script I need to track down.

  • platform/chromium/fast/js/regexp-overflow-expected.txt: Added.
4:32 PM Changeset in webkit [92652] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark gradient-after-transparent-border.html as failed on chromium.

  • platform/chromium/test_expectations.txt:
4:21 PM Changeset in webkit [92651] by cmarrin@apple.com
  • 14 edits in trunk/Source

Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState
​https://bugs.webkit.org/show_bug.cgi?id=65708

Source/WebCore:

Add logic to syncCompositingState to compute the visible rect for each
layer. This can be used to synchronously render the visible tiles of a
TiledLayer and avoid the flashing that often occurs when tiles are rendered
asynchronously. A new synchronouslyDisplayTilesInRect is also added to do
the actual rendering, but the call is not currently being made.

Reviewed by Simon Fraser.

  • page/FrameView.cpp:

(WebCore::FrameView::syncCompositingStateForThisFrame):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::syncCompositingState):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::syncCompositingState):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::synchronouslyDisplayTilesInRect):

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::operator=):

  • platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::TransformState):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

Source/WebKit/mac:

Supply initial display rects for the full-screen case

Reviewed by Simon Fraser.

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullscreen:]):
(-[WebFullScreenController exitFullscreen]):

Source/WebKit2:

Supply initial display rects for the full-screen case

Reviewed by Simon Fraser.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):

4:09 PM Changeset in webkit [92650] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

4:07 PM Changeset in webkit [92649] by Lucas Forschler
  • 1 copy in tags/Safari-534.51.9

New tag.

3:55 PM Changeset in webkit [92648] by abarth@webkit.org
  • 1 edit
    58 adds
    119 deletes in trunk/LayoutTests

Optimize baselines for fast/js.
This patch was created with webkit-patch bulk-optimize-baselines.

  • fast/js/exception-linenums-in-html-3-expected.txt: Added.
  • fast/js/global-constructors-expected.txt: Removed.
  • fast/js/missing-style-end-tag-js-expected.txt: Added.
  • platform/chromium-mac/fast/js/array-every-expected.txt: Removed.
  • platform/chromium-mac/fast/js/array-foreach-expected.txt: Removed.
  • platform/chromium-mac/fast/js/array-functions-non-arrays-expected.txt: Removed.
  • platform/chromium-mac/fast/js/array-some-expected.txt: Removed.
  • platform/chromium-mac/fast/js/assign-expected.txt: Removed.
  • platform/chromium-mac/fast/js/break-ASI-expected.txt: Removed.
  • platform/chromium-mac/fast/js/const-expected.txt: Removed.
  • platform/chromium-mac/fast/js/constructor-attributes-expected.txt: Removed.
  • platform/chromium-mac/fast/js/cyclic-proto-expected.txt: Removed.
  • platform/chromium-mac/fast/js/cyclic-prototypes-expected.txt: Removed.
  • platform/chromium-mac/fast/js/date-proto-generic-invocation-expected.txt: Removed.
  • platform/chromium-mac/fast/js/date-toisostring-expected.txt: Removed.
  • platform/chromium-mac/fast/js/deep-recursion-test-expected.txt: Removed.
  • platform/chromium-mac/fast/js/delete-getters-setters-expected.txt: Removed.
  • platform/chromium-mac/fast/js/exception-codegen-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/js/exception-for-nonobject-expected.txt: Removed.
  • platform/chromium-mac/fast/js/exception-sequencing-binops2-expected.txt: Removed.
  • platform/chromium-mac/fast/js/exception-thrown-from-new-expected.txt: Removed.
  • platform/chromium-mac/fast/js/exceptions-thrown-in-callbacks-expected.txt: Removed.
  • platform/chromium-mac/fast/js/function-declaration-expected.txt: Removed.
  • platform/chromium-mac/fast/js/function-dot-arguments-and-caller-expected.txt: Removed.
  • platform/chromium-mac/fast/js/function-prototype-descriptor-expected.txt: Removed.
  • platform/chromium-mac/fast/js/function-toString-object-literals-expected.txt: Removed.
  • platform/chromium-mac/fast/js/function-toString-parentheses-expected.txt: Removed.
  • platform/chromium-mac/fast/js/function-toString-semicolon-insertion-expected.txt: Removed.
  • platform/chromium-mac/fast/js/instance-of-immediates-expected.txt: Removed.
  • platform/chromium-mac/fast/js/invalid-syntax-for-function-expected.txt: Removed.
  • platform/chromium-mac/fast/js/js-continue-break-restrictions-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/RegExp-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/StringObject-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/encode_decode_uri-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/function-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/garbage-n-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/lval-exceptions-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/parse-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/string-1-n-expected.txt: Removed.
  • platform/chromium-mac/fast/js/kde/string-2-n-expected.txt: Removed.
  • platform/chromium-mac/fast/js/modify-non-references-expected.txt: Removed.
  • platform/chromium-mac/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Removed.
  • platform/chromium-mac/fast/js/number-toString-expected.txt: Removed.
  • platform/chromium-mac/fast/js/number-tofixed-expected.txt: Removed.
  • platform/chromium-mac/fast/js/object-extra-comma-expected.txt: Removed.
  • platform/chromium-mac/fast/js/postfix-syntax-expected.txt: Removed.
  • platform/chromium-mac/fast/js/prefix-syntax-expected.txt: Removed.
  • platform/chromium-mac/fast/js/regexp-compile-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/js/regexp-compile-expected.txt: Removed.
  • platform/chromium-mac/fast/js/regexp-no-extensions-expected.txt: Removed.
  • platform/chromium-mac/fast/js/regexp-overflow-expected.txt: Removed.
  • platform/chromium-mac/fast/js/regexp-range-out-of-order-expected.txt: Removed.
  • platform/chromium-mac/fast/js/regexp-test-null-string-expected.txt: Removed.
  • platform/chromium-mac/fast/js/string-capitalization-expected.txt: Removed.
  • platform/chromium-mac/fast/js/toString-and-valueOf-override-expected.txt: Removed.
  • platform/chromium-mac/fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Removed.
  • platform/chromium-mac/fast/js/toString-stack-overflow-expected.txt: Removed.
  • platform/chromium-mac/fast/js/uncaught-exception-line-number-expected.txt: Removed.
  • platform/chromium-win/fast/js/array-every-expected.txt: Removed.
  • platform/chromium-win/fast/js/array-foreach-expected.txt: Removed.
  • platform/chromium-win/fast/js/array-functions-non-arrays-expected.txt: Removed.
  • platform/chromium-win/fast/js/array-some-expected.txt: Removed.
  • platform/chromium-win/fast/js/assign-expected.txt: Removed.
  • platform/chromium-win/fast/js/break-ASI-expected.txt: Removed.
  • platform/chromium-win/fast/js/const-expected.txt: Removed.
  • platform/chromium-win/fast/js/constructor-attributes-expected.txt: Removed.
  • platform/chromium-win/fast/js/cyclic-proto-expected.txt: Removed.
  • platform/chromium-win/fast/js/cyclic-prototypes-expected.txt: Removed.
  • platform/chromium-win/fast/js/date-proto-generic-invocation-expected.txt: Removed.
  • platform/chromium-win/fast/js/date-toisostring-expected.txt: Removed.
  • platform/chromium-win/fast/js/deep-recursion-test-expected.txt: Removed.
  • platform/chromium-win/fast/js/delete-getters-setters-expected.txt: Removed.
  • platform/chromium-win/fast/js/exception-codegen-crash-expected.txt: Removed.
  • platform/chromium-win/fast/js/exception-for-nonobject-expected.txt: Removed.
  • platform/chromium-win/fast/js/exception-sequencing-binops2-expected.txt: Removed.
  • platform/chromium-win/fast/js/exception-thrown-from-new-expected.txt: Removed.
  • platform/chromium-win/fast/js/exceptions-thrown-in-callbacks-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-declaration-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-dot-arguments-and-caller-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-prototype-descriptor-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-toString-object-literals-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-toString-parentheses-expected.txt: Removed.
  • platform/chromium-win/fast/js/function-toString-semicolon-insertion-expected.txt: Removed.
  • platform/chromium-win/fast/js/instance-of-immediates-expected.txt: Removed.
  • platform/chromium-win/fast/js/invalid-syntax-for-function-expected.txt: Removed.
  • platform/chromium-win/fast/js/js-continue-break-restrictions-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/RegExp-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/StringObject-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/encode_decode_uri-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/function-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/garbage-n-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/lval-exceptions-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/parse-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/string-1-n-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/string-2-n-expected.txt: Removed.
  • platform/chromium-win/fast/js/modify-non-references-expected.txt: Removed.
  • platform/chromium-win/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Removed.
  • platform/chromium-win/fast/js/number-toString-expected.txt: Removed.
  • platform/chromium-win/fast/js/number-tofixed-expected.txt: Removed.
  • platform/chromium-win/fast/js/object-extra-comma-expected.txt: Removed.
  • platform/chromium-win/fast/js/postfix-syntax-expected.txt: Removed.
  • platform/chromium-win/fast/js/prefix-syntax-expected.txt: Removed.
  • platform/chromium-win/fast/js/regexp-compile-crash-expected.txt: Removed.
  • platform/chromium-win/fast/js/regexp-compile-expected.txt: Removed.
  • platform/chromium-win/fast/js/regexp-no-extensions-expected.txt: Removed.
  • platform/chromium-win/fast/js/regexp-overflow-expected.txt: Removed.
  • platform/chromium-win/fast/js/regexp-range-out-of-order-expected.txt: Removed.
  • platform/chromium-win/fast/js/regexp-test-null-string-expected.txt: Removed.
  • platform/chromium-win/fast/js/string-capitalization-expected.txt: Removed.
  • platform/chromium-win/fast/js/toString-and-valueOf-override-expected.txt: Removed.
  • platform/chromium-win/fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Removed.
  • platform/chromium-win/fast/js/toString-stack-overflow-expected.txt: Removed.
  • platform/chromium-win/fast/js/uncaught-exception-line-number-expected.txt: Removed.
  • platform/chromium/fast/js/array-every-expected.txt: Added.
  • platform/chromium/fast/js/array-foreach-expected.txt: Added.
  • platform/chromium/fast/js/array-functions-non-arrays-expected.txt: Added.
  • platform/chromium/fast/js/array-some-expected.txt: Added.
  • platform/chromium/fast/js/assign-expected.txt: Added.
  • platform/chromium/fast/js/break-ASI-expected.txt: Added.
  • platform/chromium/fast/js/const-expected.txt: Added.
  • platform/chromium/fast/js/constructor-attributes-expected.txt: Added.
  • platform/chromium/fast/js/cyclic-proto-expected.txt: Added.
  • platform/chromium/fast/js/cyclic-prototypes-expected.txt: Added.
  • platform/chromium/fast/js/date-proto-generic-invocation-expected.txt: Added.
  • platform/chromium/fast/js/date-toisostring-expected.txt: Added.
  • platform/chromium/fast/js/deep-recursion-test-expected.txt: Added.
  • platform/chromium/fast/js/delete-getters-setters-expected.txt: Added.
  • platform/chromium/fast/js/exception-codegen-crash-expected.txt: Added.
  • platform/chromium/fast/js/exception-for-nonobject-expected.txt: Added.
  • platform/chromium/fast/js/exception-sequencing-binops2-expected.txt: Added.
  • platform/chromium/fast/js/exception-thrown-from-new-expected.txt: Added.
  • platform/chromium/fast/js/exceptions-thrown-in-callbacks-expected.txt: Added.
  • platform/chromium/fast/js/function-declaration-expected.txt: Added.
  • platform/chromium/fast/js/function-dot-arguments-and-caller-expected.txt: Added.
  • platform/chromium/fast/js/function-prototype-descriptor-expected.txt: Added.
  • platform/chromium/fast/js/function-toString-object-literals-expected.txt: Added.
  • platform/chromium/fast/js/function-toString-parentheses-expected.txt: Added.
  • platform/chromium/fast/js/function-toString-semicolon-insertion-expected.txt: Added.
  • platform/chromium/fast/js/instance-of-immediates-expected.txt: Added.
  • platform/chromium/fast/js/invalid-syntax-for-function-expected.txt: Added.
  • platform/chromium/fast/js/js-continue-break-restrictions-expected.txt: Added.
  • platform/chromium/fast/js/kde: Added.
  • platform/chromium/fast/js/kde/RegExp-expected.txt: Added.
  • platform/chromium/fast/js/kde/StringObject-expected.txt: Added.
  • platform/chromium/fast/js/kde/encode_decode_uri-expected.txt: Added.
  • platform/chromium/fast/js/kde/function-expected.txt: Added.
  • platform/chromium/fast/js/kde/garbage-n-expected.txt: Added.
  • platform/chromium/fast/js/kde/lval-exceptions-expected.txt: Added.
  • platform/chromium/fast/js/kde/parse-expected.txt: Added.
  • platform/chromium/fast/js/kde/string-1-n-expected.txt: Added.
  • platform/chromium/fast/js/kde/string-2-n-expected.txt: Added.
  • platform/chromium/fast/js/modify-non-references-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/11.1.5-expected.txt: Removed.
  • platform/chromium/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Added.
  • platform/chromium/fast/js/number-toString-expected.txt: Added.
  • platform/chromium/fast/js/number-tofixed-expected.txt: Added.
  • platform/chromium/fast/js/object-extra-comma-expected.txt: Added.
  • platform/chromium/fast/js/postfix-syntax-expected.txt: Added.
  • platform/chromium/fast/js/prefix-syntax-expected.txt: Added.
  • platform/chromium/fast/js/regexp-compile-crash-expected.txt: Added.
  • platform/chromium/fast/js/regexp-compile-expected.txt: Added.
  • platform/chromium/fast/js/regexp-no-extensions-expected.txt: Added.
  • platform/chromium/fast/js/regexp-overflow-expected.txt: Removed.
  • platform/chromium/fast/js/regexp-range-out-of-order-expected.txt: Added.
  • platform/chromium/fast/js/regexp-test-null-string-expected.txt: Added.
  • platform/chromium/fast/js/string-capitalization-expected.txt: Added.
  • platform/chromium/fast/js/toString-and-valueOf-override-expected.txt: Added.
  • platform/chromium/fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Added.
  • platform/chromium/fast/js/toString-stack-overflow-expected.txt: Added.
  • platform/chromium/fast/js/uncaught-exception-line-number-expected.txt: Added.
  • platform/gtk/fast/js/exception-linenums-in-html-3-expected.txt: Removed.
  • platform/gtk/fast/js/missing-style-end-tag-js-expected.txt: Removed.
  • platform/mac/fast/js/exception-linenums-in-html-3-expected.txt: Removed.
  • platform/mac/fast/js/global-constructors-expected.txt: Added.
  • platform/mac/fast/js/missing-style-end-tag-js-expected.txt: Removed.
  • platform/qt/fast/js/exception-linenums-in-html-3-expected.txt: Removed.
  • platform/qt/fast/js/missing-style-end-tag-js-expected.txt: Removed.
3:49 PM Changeset in webkit [92647] by Lucas Forschler
  • 2 edits in trunk/Tools

Add triggers for Lion WK2 test bots.

Reviewed by Stephanie Lewis.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:29 PM Changeset in webkit [92646] by abarth@webkit.org
  • 1 edit
    5 adds
    7 deletes in trunk/LayoutTests

Optimize baselines for fast/inspector-support.
This patch was created with webkit-patch bulk-optimize-baselines.

  • fast/inspector-support/style-expected.txt: Added.
  • platform/chromium-mac/fast/inspector-support: Removed.
  • platform/chromium-mac/fast/inspector-support/uncaught-dom1-exception-expected.txt: Removed.
  • platform/chromium-mac/fast/inspector-support/uncaught-dom3-exception-expected.txt: Removed.
  • platform/chromium-mac/fast/inspector-support/uncaught-dom8-exception-expected.txt: Removed.
  • platform/chromium-win/fast/inspector-support/uncaught-dom1-exception-expected.txt: Removed.
  • platform/chromium-win/fast/inspector-support/uncaught-dom3-exception-expected.txt: Removed.
  • platform/chromium-win/fast/inspector-support/uncaught-dom8-exception-expected.txt: Removed.
  • platform/chromium/fast/inspector-support: Added.
  • platform/chromium/fast/inspector-support/uncaught-dom1-exception-expected.txt: Added.
  • platform/chromium/fast/inspector-support/uncaught-dom3-exception-expected.txt: Added.
  • platform/chromium/fast/inspector-support/uncaught-dom8-exception-expected.txt: Added.
  • platform/gtk/fast/inspector-support/style-expected.txt: Removed.
  • platform/mac/fast/inspector-support/style-expected.txt: Removed.
  • platform/qt/fast/inspector-support/style-expected.txt: Removed.
3:24 PM Changeset in webkit [92645] by abarth@webkit.org
  • 1 edit
    13 adds
    23 deletes in trunk/LayoutTests

Optimize baselines for fast/dom/HTMLAnchorElement and fast/dom/Window.
This patch was created with webkit-patch bulk-optimize-baselines.
(Note: I massaged the two results that enumerate the global object to
leave the "base" results as matching mac even though the tool wanted to
push those results down into the mac directory.)

  • platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/element-constructors-on-window-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/get-set-properties-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-custom-prototype-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-postmessage-args-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-properties-device-orientation-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-properties-geolocation-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-property-shadowing-expected.txt: Removed.
  • platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Removed.
  • platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Removed.
  • platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/element-constructors-on-window-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/get-set-properties-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-custom-prototype-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-postmessage-args-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
  • platform/chromium-win/fast/dom/Window/window-properties-device-orientation-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-properties-geolocation-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-property-shadowing-expected.txt: Removed.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Added.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt: Added.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Added.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Added.
  • platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt: Added.
  • platform/chromium/fast/dom/Window/element-constructors-on-window-expected.txt: Added.
  • platform/chromium/fast/dom/Window/get-set-properties-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Removed.
  • platform/chromium/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-properties-geolocation-expected.txt: Added.
  • platform/chromium/fast/dom/Window/window-property-shadowing-expected.txt: Added.
3:18 PM Changeset in webkit [92644] by abarth@webkit.org
  • 1 edit
    5 adds
    2 deletes in trunk/LayoutTests

Optimize baselines for fast/dom/DOMException.
This patch was created with webkit-patch bulk-optimize-baselines.
(I've manually remove the README file because we don't use these sorts
of README files anymore.)

  • platform/chromium-mac/fast/dom/DOMException: Removed.
  • platform/chromium-mac/fast/dom/DOMException/EventException-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/DOMException/README: Removed.
  • platform/chromium-mac/fast/dom/DOMException/RangeException-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/DOMException/XPathException-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/DOMException/prototype-object-expected.txt: Removed.
  • platform/chromium-win/fast/dom/DOMException: Removed.
  • platform/chromium-win/fast/dom/DOMException/EventException-expected.txt: Removed.
  • platform/chromium-win/fast/dom/DOMException/README: Removed.
  • platform/chromium-win/fast/dom/DOMException/RangeException-expected.txt: Removed.
  • platform/chromium-win/fast/dom/DOMException/XPathException-expected.txt: Removed.
  • platform/chromium-win/fast/dom/DOMException/prototype-object-expected.txt: Removed.
  • platform/chromium/fast/dom/DOMException: Added.
  • platform/chromium/fast/dom/DOMException/EventException-expected.txt: Added.
  • platform/chromium/fast/dom/DOMException/RangeException-expected.txt: Added.
  • platform/chromium/fast/dom/DOMException/XPathException-expected.txt: Added.
  • platform/chromium/fast/dom/DOMException/prototype-object-expected.txt: Added.
3:17 PM Changeset in webkit [92643] by commit-queue@webkit.org
  • 14 edits in trunk/Source

Unreviewed, rolling out r92619.
​http://trac.webkit.org/changeset/92619
​https://bugs.webkit.org/show_bug.cgi?id=65881

This patch breaks chromium canary (Requested by jianli on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-08

Source/WebCore:

  • bindings/v8/V8Binding.h:
  • bindings/v8/V8GCController.cpp:

(WebCore::globalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::createString):

  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::checkNewLegal):

  • bindings/v8/V8Utilities.h:

(WebCore::AllowAllocation::AllowAllocation):
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::SafeAllocation::newInstance):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initV8):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):

Source/WebKit/chromium:

  • src/BoundObject.cpp:
3:04 PM Changeset in webkit [92642] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

3:04 PM Changeset in webkit [92641] by abarth@webkit.org
  • 2 edits in trunk/Tools

bulk-optimize-baselines should take directories on the command line
​https://bugs.webkit.org/show_bug.cgi?id=65879

Reviewed by Dimitri Glazkov.

Passing lists of tests via stdin is a pain. It's easier if the command
takes a list of tests on the command line, like run-webkit-tests.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
3:03 PM Changeset in webkit [92640] by Lucas Forschler
  • 1 copy in tags/Safari-534.51.8

New tag.

3:01 PM Changeset in webkit [92639] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Scroll animator changes to nail the framerate
​https://bugs.webkit.org/show_bug.cgi?id=65645

Patch by Scott Byer <​scottbyer@chromium.org> on 2011-08-08
Reviewed by James Robinson.

Source/WebCore:

Partial test in ScrollAnimatorNoneTest::Enabled.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::PerAxisData::PerAxisData):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::PerAxisData::animateScroll):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::~ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):

  • platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

  • tests/ScrollAnimatorNoneTest.cpp:

(TEST):

2:53 PM Changeset in webkit [92638] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Switch legacy flexbox to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=65340

Reviewed by Eric Seidel.

No new tests, no new functionality.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::calcHorizontalPrefWidths):
(WebCore::RenderDeprecatedFlexibleBox::calcVerticalPrefWidths):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::placeChild):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

  • rendering/RenderDeprecatedFlexibleBox.h:
2:37 PM Changeset in webkit [92637] by abarth@webkit.org
  • 2 edits in trunk/Tools

Deprecate rebaseline-chromium-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=65873

Reviewed by Dimitri Glazkov.

This script never worked correctly and now is redundant with more
modern infrastructure for rebaselining tests. This patch deprecates
the script in order to flush out any issues with the new tools. Once
folks are happy with the new tools, we'll delete this script.

  • Scripts/rebaseline-chromium-webkit-tests:
2:35 PM Changeset in webkit [92636] by Dimitri Glazkov
  • 5 edits in trunk/Tools

garden-o-matic should only touch expectations that need updating.
​https://bugs.webkit.org/show_bug.cgi?id=65876

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,

so that a caller could influence which lines to serialize from values.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
2:28 PM Changeset in webkit [92635] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Using mprotect to create guard pages breaks our use of madvise to release executable memory
​https://bugs.webkit.org/show_bug.cgi?id=65870

Reviewed by Gavin Barraclough.

Use mmap rather than mprotect to clear guard page permissions.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

2:28 PM Changeset in webkit [92634] by Dimitri Glazkov
  • 3 edits in trunk/Tools

TestExpectationsEditor should return a list of updated expectations.
​https://bugs.webkit.org/show_bug.cgi?id=65872

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
2:16 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
2:07 PM Changeset in webkit [92633] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark preventExtensions.html as failed on chromium.

  • platform/chromium/test_expectations.txt:
2:04 PM Changeset in webkit [92632] by abarth@webkit.org
  • 3 edits in trunk/Tools

Fix SCM webkitpy unit test failures
​https://bugs.webkit.org/show_bug.cgi?id=65823

Patch by Jochen Eisinger <​jochen@chromium.org> on 2011-08-08
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1:49 PM Changeset in webkit [92631] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

Switch RenderStyle to to new layout types
​https://bugs.webkit.org/show_bug.cgi?id=65208

Reviewed by Eric Seidel.

No new tests, no new functionality.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addShadowOverflow):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::applyTransform):
(WebCore::calcRadiiFor):
(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderFor):

  • rendering/style/RenderStyle.h:
  • rendering/style/ShadowData.cpp:

(WebCore::ShadowData::adjustRectForShadow):

1:39 PM Changeset in webkit [92630] by cdn@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove counter nodes from the tree and fix-up children when they are removed from the counter map.
​https://bugs.webkit.org/show_bug.cgi?id=65346

Reviewed by Adam Barth.

Covered by existing CSS counter tests.

  • rendering/CounterNode.cpp:

(WebCore::CounterNode::~CounterNode):

1:37 PM Changeset in webkit [92629] by eric@webkit.org
  • 2 edits in trunk/Tools

Move the --leaks bot back over to NRWT now that I'm back
from vacation and able to debug it.

Unreviewed.

  • Scripts/run-webkit-tests:

(usingWebKit2):
(useNewRunWebKitTests):

1:32 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
1:29 PM Changeset in webkit [92628] by tony@chromium.org
  • 8 edits
    4 adds in trunk

implement basic horizontal flexing
​https://bugs.webkit.org/show_bug.cgi?id=65045

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/001.html

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::FlexibleBoxIterator::FlexibleBoxIterator): flexitem iterator
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::first):
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::next):
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::reset):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::preferredFlexItemContentWidth): Returns the intrinsic size of a flex item's content.
(WebCore::RenderFlexibleBox::layoutHorizontalBlock): Runs the flex algorithm
(WebCore::preferredSizeForMarginsAndPadding):
(WebCore::RenderFlexibleBox::computePreferredSize): Calculate the preferred size of the

flex items.

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • css3/flexbox/001-expected.txt: Added.
  • css3/flexbox/001.html: Added.
  • css3/flexbox/resources/flexbox.js: Added. I plan on using this file for other tests.

(insertAfter):
(checkHorizontalBoxen):

1:18 PM Changeset in webkit [92627] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add detail to ASSERT message in IDBTransaction::enqueueEvent
​https://bugs.webkit.org/show_bug.cgi?id=65735

I've hit this a few times but haven't been able to pin it down. The
extra detail could be helpful.

Patch by David Grogan <​dgrogan@chromium.org> on 2011-08-08
Reviewed by Nate Chapin.

No new tests, just an error message.

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::enqueueEvent):

1:13 PM Changeset in webkit [92626] by commit-queue@webkit.org
  • 9 edits in trunk

Unreviewed, rolling out r92610.
​http://trac.webkit.org/changeset/92610
​https://bugs.webkit.org/show_bug.cgi?id=65868

Caused assertion failures when running fast/multicol tests
(Requested by andersca on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-08

PerformanceTests:

  • Layout/floats.html:

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PODIntervalTree.h:

(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::searchForOverlapsFrom):

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addPositionedFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::set):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):

1:11 PM Changeset in webkit [92625] by eae@chromium.org
  • 7 edits in trunk/Source/WebCore

Rename absoluteQuadsForRange and InlineTextBox::selectionRect to local*
​https://bugs.webkit.org/show_bug.cgi?id=65722

Reviewed by Simon Fraser.

No new tests, no new functionality.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::localSelectionRect):
Rename InlineTextBox::selectionRect to localSelectionRect to reflect that
it, unlike RenderObject::selectionRect returns a rect in the local
coordinate space.

  • rendering/InlineTextBox.h:
  • rendering/RenderText.cpp:

(WebCore::localQuadForTextBox):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::selectionRectForRepaint):
Rename absoluteQuadForTextBox to localQuadForTextBox to reflect that it
returns a quad in the local coordinate space.

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::localSelectionRect):

  • rendering/svg/SVGInlineTextBox.h:
12:59 PM Changeset in webkit [92624] by Dimitri Glazkov
  • 5 edits in trunk/Tools

Wire up updating expectations in garden-o-matic.
​https://bugs.webkit.org/show_bug.cgi?id=65794

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
  • Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
  • Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
12:54 PM Changeset in webkit [92623] by jochen@chromium.org
  • 6 edits in trunk/Source/WebCore

Use a raw pointer to the security origin in the ctor of FrameLoadRequest
​https://bugs.webkit.org/show_bug.cgi?id=65852

Reviewed by Alexey Proskuryakov.

  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation):

  • loader/FrameLoader.h:
  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
(WebCore::ScheduledURLNavigation::fire):
(WebCore::ScheduledRedirect::ScheduledRedirect):
(WebCore::ScheduledLocationChange::ScheduledLocationChange):
(WebCore::ScheduledRefresh::ScheduledRefresh):
(WebCore::NavigationScheduler::scheduleLocationChange):

  • loader/NavigationScheduler.h:
12:47 PM Changeset in webkit [92622] by Dimitri Glazkov
  • 5 edits
    2 deletes in branches/chromium/835

Revert r91125 for Chromium 835.

12:41 PM Changeset in webkit [92621] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit/win

WebView::performLayeredWindowUpdate() crashes with
NULL pointer when using layered window updates.
​https://bugs.webkit.org/show_bug.cgi?id=60618

Reviewed by Adam Roben.

During resize operations, the backing store will be destroyed if
the window's size (either height or width) is set to zero. The
bug was identified when a user first resized a WebView to zero
dimensions, then attempted to perform a MoveWindow. The paint
message triggered by the MoveWindow attempted to use the layered
window update logic, which encountered the nulled backing store.

  • WebView.cpp:

(WebView::performLayeredWindowUpdate): Add an early

return when there is no backing store to blend with.

12:15 PM Changeset in webkit [92620] by rniwa@webkit.org
  • 15 edits
    2 adds in trunk

Remove redundant inline styles from the pasted contents more aggressively
​https://bugs.webkit.org/show_bug.cgi?id=65833

Reviewed by Tony Chang.

Source/WebCore:

Make removeRedundantStylesAndKeepStyleSpanInline more aggressively remove redundant styles by realizing that
when an editing inheritable property in an inline style declaration of an element can be safely removed
if it is present either in style rules or in its ancestor and not overridden by style rules or default style
of the element.

Test: editing/pasteboard/paste-with-redundant-style.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Do not match author style sheets if AuthorCSSRules
is not included in the rules to include. This is used in EditingStyle::removePropertiesInElementDefaultStyle.

  • editing/ApplyStyleCommand.cpp:

(WebCore::isStyleSpanOrSpanWithOnlyStyleAttribute): Added; returns true if the element is a style span or
span possibly with a style attribute.

  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement): Takes rulesToInclude.
(WebCore::EditingStyle::mergeStyleFromRules): Calls styleFromMatchedRulesForElement with AuthorCSSRules
| CrossOriginCSSRules to keep the original behavior.
(WebCore::EditingStyle::removeStyleFromRulesAndContext): Renamed from removeStyleFromRules; removes styles that
are present in context and not overridden by matched rules.
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle): Added.

  • editing/EditingStyle.h:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): See the description above.

LayoutTests:

Added a test to paste contents with many redundant styles. WebKit should remove as much style spans as possible
(all of this in this case).

  • editing/pasteboard/4930986-2-expected.txt: style attribute now has a trailing space.
  • editing/pasteboard/interchange-newline-1-expected.txt: No longer has a wrapping span without any attributes.
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt: Ditto.
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt: Ditto.
  • editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Ditto.
  • editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Ditto.
  • editing/pasteboard/prevent-block-nesting-01-expected.txt: Ditto.
  • editing/pasteboard/paste-with-redundant-style-expected.txt: Added.
  • editing/pasteboard/paste-with-redundant-style.html: Added.
12:11 PM Changeset in webkit [92619] by dslomov@google.com
  • 14 edits in trunk/Source

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates.

Reviewed by David Levin.

Covered by existing tests.

  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate):
(WebCore::V8BindingPerIsolateData::hiddenPropertyName):
(WebCore::V8BindingPerIsolateData::globalHandleMap):
(WebCore::AllowAllocation::AllowAllocation): Moving to V8Binding.h from V8Utilities.h to resolve header dependency.
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::AllowAllocation::current):
(WebCore::SafeAllocation::newInstance):

  • bindings/v8/V8GCController.cpp:

(WebCore::currentGlobalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::createString):

  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::checkNewLegal):

  • bindings/v8/V8Utilities.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initIsolate):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):

Source/WebKit/chromium: ​https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates

Reviewed by David Levin.

  • src/BoundObject.cpp: AllowAllocation moved from V8Utilities.h to V8Binding.h
12:09 PM Changeset in webkit [92618] by oliver@apple.com
  • 5 edits in trunk

Non-extensibility does not prevent mutating Prototype
​https://bugs.webkit.org/show_bug.cgi?id=65832

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Add tests to ensure we can't assign to proto when an object
is not extensible.

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Disallow mutation of proto on objects that are not extensible.

  • runtime/JSObject.cpp:

(JSC::JSObject::put):

12:09 PM Changeset in webkit [92617] by commit-queue@webkit.org
  • 14 edits in trunk/Source

Unreviewed, rolling out r92607.
​http://trac.webkit.org/changeset/92607
​https://bugs.webkit.org/show_bug.cgi?id=65865

This patch breaks Chromium Mac Canary (Requested by jianli on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-08-08

Source/WebCore:

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebInputEvent.h:

(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):

  • public/mac/WebInputEventFactory.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):

  • src/WebInputEventConversion.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

  • src/WebViewImpl.h:
  • src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::mouseWheelEvent):

11:59 AM Changeset in webkit [92616] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark 1 test as flaky in chromium.

  • platform/chromium/test_expectations.txt:
11:42 AM Changeset in webkit [92615] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Implement WebGL antialiasing (part 3)
​https://bugs.webkit.org/show_bug.cgi?id=64879

Patch by Andrew Wason <​rectalogic@rectalogic.com> on 2011-08-08
Reviewed by Noam Rosenthal.

Existing WebGL layout tests cover this.

Implement WebGL antialiasing for Qt desktop.
Existing code in GraphicsContext3DOpenGL.cpp manages the
multisample FBO. GraphicsContext3DQt.cpp creates it and blits
it to the regular FBO when painting.
Requires adoption of Extensions3DOpenGL to be fully functional.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintToTextureMapper):
(WebCore::GraphicsContext3DInternal::paint):
(WebCore::GraphicsContext3DInternal::multisampleResolve):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):

11:39 AM Changeset in webkit [92614] by kerz@chromium.org
  • 3 edits
    3 deletes in branches/chromium/835

Reverting for crbug.com/91858
Revert 91958 - Merge 91915 - 2011-07-28 Rob Buis <​rbuis@rim.com>

REGRESSION (r91125): Google Drawings is broken
​https://bugs.webkit.org/show_bug.cgi?id=65257

Reviewed by Darin Adler.

Only consider zero-length path rendering code path when a stroke is defined.

Test: svg/custom/zero-path-square-cap-rendering2.svg

  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):

TBR=​rwlbuis@webkit.org
Review URL: ​http://codereview.chromium.org/7532014

TBR=​kerz@chromium.org
Review URL: ​http://codereview.chromium.org/7529030

11:35 AM Changeset in webkit [92613] by kerz@chromium.org
  • 1 edit
    2 deletes in branches/chromium/835/LayoutTests

Beginning revert chain to fix crbug.com/91858

Revert 91968 - Merge 91927 - [chromium] New expectations for r91915
​https://bugs.webkit.org/show_bug.cgi?id=65317

Unreviewed expections update.

  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.png: Added.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.

TBR=​tonyg@chromium.org
Review URL: ​http://codereview.chromium.org/7474011

TBR=​kerz@chromium.org
Review URL: ​http://codereview.chromium.org/7558004

11:33 AM Changeset in webkit [92612] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test_expectations.

  • platform/chromium/test_expectations.txt:
11:26 AM Changeset in webkit [92611] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::Counter::visit):

11:09 AM Changeset in webkit [92610] by commit-queue@webkit.org
  • 9 edits in trunk

Optimize floating elements lookup
​https://bugs.webkit.org/show_bug.cgi?id=65668

PerformanceTests:

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-08
Reviewed by David Hyatt.

  • Layout/floats.html: Added the nested divs, so that we can test the propagation impact of the floats tree.

Source/WebCore:

Added an interval tree in the FloatingObjects structure. Also added new mechanisms to make
sure the tree is updated correctly when a float is repositioned.

Changed the PODIntervalTree to support giving a search adapter that can be implemented by the
client. I'm not adding a different bug for that because PODIntervalTree is not used anywhere else
and would be hard to test that the change is not breaking anything.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-08
Reviewed by David Hyatt.

No new tests, just a refactor on the floating objects data structure.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PODIntervalTree.h:

(WebCore::PODIntervalSearchAdapter::PODIntervalSearchAdapter):
(WebCore::PODIntervalSearchAdapter::lowValue):
(WebCore::PODIntervalSearchAdapter::highValue):
(WebCore::PODIntervalSearchAdapter::collectIfNeeded):
(WebCore::PODIntervalTree::PODIntervalTree):
(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::allOverlapsWithAdapter):
(WebCore::PODIntervalTree::searchForOverlapsFrom):

  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree):
(WebCore::PODRedBlackTree::clear):
(WebCore::PODRedBlackTree::isInitialized):
(WebCore::PODRedBlackTree::initIfNeeded):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addPositionedFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::RenderBlock::FloatingObjects::addPlacedObject):
(WebCore::RenderBlock::FloatingObjects::removePlacedObject):
(WebCore::RenderBlock::FloatingObjects::add):
(WebCore::RenderBlock::FloatingObjects::remove):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTree):
(WebCore::::string):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
(WebCore::RenderBlock::FloatingObject::isInPlacedTree):
(WebCore::RenderBlock::FloatingObject::setIsInPlacedTree):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::setHorizontalWritingMode):
(WebCore::RenderBlock::FloatingObjects::set):
(WebCore::RenderBlock::FloatingObjects::placedFloatsTree):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTreeIfNeeded):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):

11:02 AM Changeset in webkit [92609] by jochen@chromium.org
  • 3 edits in trunk/Tools

webkit-patch doesn't get along with renamed files
​https://bugs.webkit.org/show_bug.cgi?id=48075

Possibly a bit heavy handed - I removed all instances of -C and
changed every instance of -M with '--no-renames' in git.py. This
forces git to not try to tell us about renames at all, which is
ultimately the behaviour we want. The old file is shown deleted,
then the new file is shown added, followed by any changes that
occurred. Also gets rid of the problem where deleting one file
and adding another file which has similar content would
unexpectedly show up as a rename, and fall out of a diff.

Based on a patch by Wyatt Carss.

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/git.py:
11:00 AM Changeset in webkit [92608] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark some tests as flaky on chromium.

  • platform/chromium/test_expectations.txt:
10:56 AM Changeset in webkit [92607] by commit-queue@webkit.org
  • 14 edits in trunk/Source

[Chromium] Enable rubber banding when scrolling.

​https://bugs.webkit.org/show_bug.cgi?id=65707

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-08-08
Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests since this is just syncing changes to chromium platform.

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebInputEvent.h:

(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
(WebKit::WebGestureEvent::WebGestureEvent):

  • public/mac/WebInputEventFactory.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebInputEventConversion.h:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::GestureEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::handleInputEvent):

  • src/WebViewImpl.h:
  • src/mac/WebInputEventFactory.mm:

(WebKit::gestureEventTypeForEvent):
(WebKit::phaseForNSEventPhase):
(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):

10:54 AM Changeset in webkit [92606] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS from 95576 to 95783.

  • DEPS:
10:52 AM Changeset in webkit [92605] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Cairo][Gtk] Get more of the philip suite of canvas tests passing
​https://bugs.webkit.org/show_bug.cgi?id=54458

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2011-08-08
Reviewed by Martin Robinson.

Update the list of skipped canvas tests and describe why platform-specific
failures occur.

  • platform/gtk/Skipped:
10:43 AM Changeset in webkit [92604] by andersca@apple.com
  • 6 edits
    2 copies
    5 adds in trunk/LayoutTests

More Lion specific results.

  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/editing: Added.
  • platform/mac-snowleopard/editing/input: Added.
  • platform/mac-snowleopard/editing/input/devanagari-ligature-expected.png: Copied from platform/mac/editing/input/devanagari-ligature-expected.png.
  • platform/mac-snowleopard/editing/input/devanagari-ligature-expected.txt: Copied from platform/mac/editing/input/devanagari-ligature-expected.txt.
  • platform/mac-snowleopard/fast/xsl: Added.
  • platform/mac-snowleopard/fast/xsl/sort-locale-expected.txt: Added.
  • platform/mac/editing/input/devanagari-ligature-expected.png:
  • platform/mac/editing/input/devanagari-ligature-expected.txt:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
  • platform/mac/fast/xsl/sort-locale-expected.txt: Added.
10:28 AM Changeset in webkit [92603] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/9652350> REGRESSION (r87755): WKView doesn't update when I drag files into a background Safari window
​https://bugs.webkit.org/show_bug.cgi?id=65860

Reviewed by Simon Fraser.

When layer flush scheduling is re-enabled, schedule a layer flush, just in case one was requested while
scheduling was disabled. It doesn’t seem worthwhile to track whether that in fact happened, so do so
unconditionally.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled):

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled):

10:20 AM Changeset in webkit [92602] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fix more typo in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
9:27 AM Changeset in webkit [92601] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-08-08 Pavel Podivilov <​podivilov@chromium.org>

Web Inspector: unreviewed, build fix for r92598.

  • inspector/debugger/script-formatter.html:
9:26 AM Changeset in webkit [92600] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::sizeShouldIncludeDecoration): Fixed an obvious typo.

9:13 AM Changeset in webkit [92599] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Clean up project file after r92492.

Unreviewed gardening.

No new tests needed.

  • WebCore.pro: remove nonexistent PluginHalterClient.h, PluginHalter.h, HaltablePlugin.h.
8:50 AM Changeset in webkit [92598] by podivilov@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: refactor links creation.
​https://bugs.webkit.org/show_bug.cgi?id=65612

Reviewed by Pavel Feldman.

No new tests - it is refactoring, modified code covered by script-formatter.html test.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._linkifyLocation):
(WebInspector.ConsoleMessage.prototype._linkifyCallFrame):
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor.didGetLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

  • inspector/front-end/Panel.js:
  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.createCell):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.linkifyUncopyable):
(WebInspector.StylePropertiesSection):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

  • inspector/front-end/inspector.js:

(WebInspector._showSettingsScreen):
(WebInspector.formatLinkText):
(WebInspector.linkifyResourceAsNode):

8:34 AM Changeset in webkit [92597] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-08-08 Andrei Popescu <​andreip@google.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

Unreviewed gardening.

Fix typo in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
8:29 AM Changeset in webkit [92596] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[Qt] Implement WebGL antialiasing (part 3)
​https://bugs.webkit.org/show_bug.cgi?id=64879

Patch by Andrew Wason <​rectalogic@rectalogic.com> on 2011-08-08
Reviewed by Noam Rosenthal.

Existing WebGL layout tests.

Adopt Extensions3DOpenGL for Qt desktop as a prerequisite
for implementing WebGL antialiasing.
Extensions3DQt is still used for ES2.

  • WebCore.pri:
  • WebCore.pro:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getExtensions):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::layerComposited):

8:05 AM Changeset in webkit [92595] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-08-08 Andrei Popescu <​andreip@google.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

Unreviewed gardening.

Marks the tests as failing on Chromium.

  • platform/chromium/test_expectations.txt:
7:25 AM Changeset in webkit [92594] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

Build fix after r92589, defaultSize is not used.

Reviewed by Andreas Kling.

  • html/InputType.cpp:

(WebCore::InputType::sizeShouldIncludeDecoration):

5:50 AM Changeset in webkit [92593] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG JIT does not track speculation decisions for global variables
​https://bugs.webkit.org/show_bug.cgi?id=65825

Reviewed by Gavin Barraclough.

Added the capability to track predictions for global variables, and
ensured that code can abstract over the source of prediction (local
versus global variable) wherever it is appropriate to do so. Also
cleaned up the code in SpeculativeJIT that decides how to speculate
based on recorded predictions (for example instead of using isInteger,
which makes sense for local predictions where the GetLocal would
return an integer value, we now tend to use shouldSpeculateInteger,
which checks if the value is either already an integer or should be
speculated to be an integer).

This is an 0.8% win on SunSpider, almost entirely thanks to a 25%
win on controlflow-recursive. It's also a 4.8% win on v8-crypto.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::predictArray):
(JSC::DFG::ByteCodeParser::predictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getGlobalVarPrediction):
(JSC::DFG::Graph::getPrediction):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):

5:44 AM Changeset in webkit [92592] by keishi@webkit.org
  • 15 edits
    2 adds in trunk/Source/WebCore

Implement <input type=color> UI behavior WebCore part
​https://bugs.webkit.org/show_bug.cgi?id=62619

Reviewed by Kent Tamura.

  • WebCore.exp.in: Added ZN7WebCore12ColorChooser7chooserEv and

ZNK7WebCore12ColorChooser13colorSelectedERKNS_5ColorE

  • WebCore.xcodeproj/project.pbxproj: Added ColorChooser.{h,cpp}
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::~ColorInputType): Added. Close color chooser. ex. when type attribute changes.
(WebCore::ColorInputType::valueAsColor): Added.
(WebCore::ColorInputType::setValueAsColor): Added.
(WebCore::ColorInputType::valueChanged): Update selected color in color chooser too.
(WebCore::ColorInputType::handleClickEvent): Opens color chooser.
(WebCore::ColorInputType::handleDOMActivateEvent): Called when element.click(). Open color chooser only
when it was initiated by a user interaction.
(WebCore::ColorInputType::detach): Close color chooser. Called when input element or its ancestors have "display:none"
or is removed from DOM.
(WebCore::ColorInputType::colorSelected): Callback from color chooser.
(WebCore::ColorInputType::isColorInputType): Returns true.
(WebCore::ColorInputType::closeColorChooserIfCurrentClient): Close color chooser if this input type is the current client of ColorChooser.

  • html/ColorInputType.h:
  • html/FileInputType.cpp:
  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::detach): Calls InputType::detach

  • html/InputType.cpp:

(WebCore::InputType::chrome): Added. Used in FileInputType and ColorInputType.
(WebCore::InputType::detach): ColorInputType overrides this.

  • html/InputType.h:
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::openColorChooser):
(WebCore::EmptyChromeClient::closeColorChooser):
(WebCore::EmptyChromeClient::setSelectedColorInColorChooser):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): Close color chooser when navigating away from the page. We do this here
because ColorInputType::detach() is called seconds after the page transition so it is too slow.

  • page/Chrome.cpp:

(WebCore::Chrome::openColorChooser): Added.
(WebCore::Chrome::closeColorChooser): Added.
(WebCore::Chrome::setSelectedColorInColorChooser): Added.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ColorChooser.cpp: Added.

(WebCore::ColorChooserClient::~ColorChooserClient): Disconnects itself from the ColorChooser.
(WebCore::ColorChooser::chooser): Get shared instance of ColorChooser.
(WebCore::ColorChooser::connectClient): Connects a ColorChooserClient that receives the colorSelected callbacks.
(WebCore::ColorChooser::disconnectClient): Disconnects the connectClient.
(WebCore::ColorChooser::colorSelected): Called from color chooser listener.

  • platform/ColorChooser.h: Added.

(WebCore::ColorChooserClient::isColorInputType): Added.
(WebCore::ColorChooser::client): Added. Returns the current connected client.
(WebCore::ColorChooser::ColorChooser): Added.

5:16 AM Changeset in webkit [92591] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/forms/input-number-size.html added in r92589 fails
​https://bugs.webkit.org/show_bug.cgi?id=65851

Unreviewed gardening.

  • platform/qt/Skipped: Skip the test.
3:56 AM Changeset in webkit [92590] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

Adjust test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=65847

Unreviewed.

  • platform/chromium/test_expectations.txt:
2:16 AM Changeset in webkit [92589] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Source/WebCore: The input[type=number] element should be as wide as necessary to show the widest possible value.
​https://bugs.webkit.org/show_bug.cgi?id=60673

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-08-08
Reviewed by Kent Tamura.

The size of input[type=number] is calculated from min/max/step attributes to show the widest possible value.
If min or max attribute is absent, the default size is used.
Also, if its css width is not auto, the width is used with priority.

If min/max/attribute is set dynamically, the size of the input[type=number] will be recalculated.

Test: fast/forms/input-number-size.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute):

Added stepAttributeChanged handler.

(WebCore::HTMLInputElement::sizeShouldIncludeDecoration):

Returns true if a renderer should include decoration (e.g. inner spinbox).
Also returns the preferred size of the input.

  • html/HTMLInputElement.h:
  • html/InputType.cpp:

(WebCore::InputType::sizeShouldIncludeDecoration):

Same as WebCore::HTMLInputElement::sizeShouldIncludeDecoration.

(WebCore::InputType::stepAttributeChanged):

Will be called When step attribute is changed.
Sets a flag to recalculate layout.

  • html/InputType.h:
  • html/NumberInputType.cpp:

(WebCore::lengthBeforeDecimalPoint):

Calculates the width before the decimal point.

(WebCore::NumberInputType::sizeShouldIncludeDecoration):

Same as WebCore::HTMLInputElement::sizeShouldIncludeDecoration.
However, this will calculate the preferred size from min/max/step attribute.

(WebCore::NumberInputType::minOrMaxAttributeChanged):

Sets a flag to recalculate layout.

(WebCore::NumberInputType::stepAttributeChanged): ditto.

  • html/NumberInputType.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::preferredContentWidth):

Uses preferredSize instead of size.
Also, adds innerSpinButtonElement size to width if sizeShouldIncludeDecoration returns true.

LayoutTests: Added the test to check the width of input[type=number].
​https://bugs.webkit.org/show_bug.cgi?id=60673

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-08-08
Reviewed by Kent Tamura.

  • fast/forms/input-number-size-expected.txt: Added.
  • fast/forms/input-number-size.html: Added.
1:42 AM Changeset in webkit [92588] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

Should not use C-style cast in CSSParser.cpp
​https://bugs.webkit.org/show_bug.cgi?id=65807

Remove C-style cast.

Reviewed by Kent Tamura.

No new tests because no behavior change.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationTimingFunction): Replaced a cast with clampToInteger().
(WebCore::CSSParser::parseFontFeatureTag): Ditto.
(WebCore::CSSParser::createKeyframeRule): Replaced a cast with C++-style cast.

1:12 AM Changeset in webkit [92587] by pfeldman@chromium.org
  • 23 edits in trunk/Source

Web Inspector: implement dock/undock in WebKit2 without getting into WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=65763

Source/WebCore:

InspectorFrontendClient.h can't have synchronous canAttachWindow() returning value
since in the multiprocess environment, you can't immediately get back to it from the host.

r92384 introduced an unhealthy WebKit -> WebCore -> WebKit canAttach query where embedder
was asking itself a question. This loop was fixed.

Reviewed by Yury Semikhatsky.

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/inspector.js:

(windowLoaded):

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

  • src/InspectorFrontendClientImpl.cpp:
  • src/InspectorFrontendClientImpl.h:
  • src/js/DevTools.js:

(devtools.domContentLoaded):

Source/WebKit2:

InspectorFrontendClient.h can't have synchronous canAttachWindow() returning value
since in the multiprocess environment, you can't immediately get back to it from the host.

r92384 introduced an unhealthy WebKit -> WebCore -> WebKit canAttach query where embedder
was asking itself a question. This loop was fixed.

Reviewed by Yury Semikhatsky.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::didLoadInspectorPage):
(WebKit::WebInspectorProxy::shouldOpenAttached):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/efl/WebInspectorEfl.cpp:

(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

  • UIProcess/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::didLoadInspectorPage):

  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/WebInspector.messages.in:
12:32 AM Changeset in webkit [92586] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip divergent tests
​https://bugs.webkit.org/show_bug.cgi?id=65831

  • platform/qt/Skipped:
12:25 AM Changeset in webkit [92585] by tkent@chromium.org
  • 14 edits
    2 adds in trunk

[Chromium] Make form validation bubble fit with Chrome UI style
​https://bugs.webkit.org/show_bug.cgi?id=65359

Reviewed by Hajime Morita.

Source/WebCore:

Change the appearance of validation message bubble for
Chromium. Basically it doesn't change for other ports.

  • Introduce a new element to put an icon, and enclose it and the

message text by a flexible box.

  • Repesent the message text by two elements. One for the heading,

another for the remaining.

  • Introduce themeChromium.css
  • WebCore.gyp/WebCore.gyp: Add themeChromium.css.
  • css/html.css:

(::-webkit-validation-bubble-message): Make this a flexible box container.
(::-webkit-validation-bubble-text-block): Takes flexibility.
(::-webkit-validation-bubble-heading):
Make the content bold because we removed <b></b>.

  • css/themeChromium.css: Added.

(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-arrow):
(::-webkit-validation-bubble-arrow-clipper):
(::-webkit-validation-bubble-icon):
(::-webkit-validation-bubble-heading):
(::-webkit-validation-bubble-body):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
Sets the text into m_messageHeading and m_messageBody, instead of m_bubbleMessage.
Use ASSERT_NO_EXCEPTION.
(WebCore::ValidationMessage::buildBubbleTree):
Build the new structure, and use ASSERT_NO_EXCEPTION.
(WebCore::ValidationMessage::deleteBubbleTree):
Clear m_messageHeading and m_messageBody.

  • html/ValidationMessage.h:
  • rendering/RenderThemeChromiumMac.h: Add extraDefaultStyleSheet().
  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::extraDefaultStyleSheet): Append themeChromium.css.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): Append themeChromium.css.

LayoutTests:

  • fast/forms/validation-message-appearance.html: Need to wait for a litle because of image loading.
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.png:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
12:03 AM Changeset in webkit [92584] by kerz@chromium.org
  • 2 edits in branches/chromium/835/Source/WebCore

Merge 92529 - Introduced fast path for border rendering when all visible sides are solid, same rgba color but not all visible
​https://bugs.webkit.org/show_bug.cgi?id=65762

Patch by Ben Wells <​benwells@chromium.org> on 2011-08-05
Reviewed by Simon Fraser.

No intended change in behaviour, no new tests.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::calculateSideRect):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/7585032

Aug 7, 2011:

11:38 PM Changeset in webkit [92583] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/loader/ping-error.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=65754

Unreviewed chromium test_expectations.txt update
No more failure as r92439 was rolled out by r92453

  • platform/chromium/test_expectations.txt:
11:02 PM Changeset in webkit [92582] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
9:06 PM Changeset in webkit [92581] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed test fix after r92578. I accidentally added the call to dumpAsText(true).

  • editing/pasteboard/nested-blocks-with-text-area.html:
8:46 PM Changeset in webkit [92580] by rniwa@webkit.org
  • 3 edits
    2 adds
    17 deletes in trunk/LayoutTests

Dump-as-markup conversion: paste-blockquote-into-blockquote.html and prevent-block-nesting-01.html
​https://bugs.webkit.org/show_bug.cgi?id=65837

Reviewed by Kent Tamura.

Converted the tests to dump-as-markup tests to improve the readability of the expected results.

  • editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-into-blockquote.html:
  • editing/pasteboard/prevent-block-nesting-01-expected.txt: Added.
  • editing/pasteboard/prevent-block-nesting-01.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/gtk/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
8:31 PM Changeset in webkit [92579] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/xsl/xslt-import-depth.xml is failing
​https://bugs.webkit.org/show_bug.cgi?id=65758

Test is now green on chromium and webkit build bots.

Patch by Noel Gordon <​noel.gordon@gmail.com> on 2011-08-07
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt:
7:47 PM Changeset in webkit [92578] by rniwa@webkit.org
  • 3 edits
    2 adds
    23 deletes in trunk/LayoutTests

Dump-as-markup conversion: nested-blocks-with-text-area.html and nested-blocks-with-text-field.html
​https://bugs.webkit.org/show_bug.cgi?id=65836

Reviewed by Kent Tamura.

Converted the tests to dump-as-markup tests to improve the readability of the expected results.

  • editing/pasteboard/nested-blocks-with-text-area-expected.txt: Added.
  • editing/pasteboard/nested-blocks-with-text-area.html:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt: Added.
  • editing/pasteboard/nested-blocks-with-text-field.html:
  • platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/win/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
7:28 PM Changeset in webkit [92577] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/xsl/import-after-comment.xml is failing
​https://bugs.webkit.org/show_bug.cgi?id=65757

This test and the others mentioned in the bug are now green on chromium
and webkit build bots.

Patch by Noel Gordon <​noel.gordon@gmail.com> on 2011-08-07
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt:
7:06 PM Changeset in webkit [92576] by koz@chromium.org
  • 8 edits in trunk/Source

Make the fullscreen JS API enabled at runtime.
​https://bugs.webkit.org/show_bug.cgi?id=65501

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIsFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenKeyboardInputAllowedEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCurrentFullScreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCancelFullScreenEnabled):

  • dom/Document.idl:
  • dom/Element.idl:

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableFullScreenAPI):
(WebKit::WebRuntimeFeatures::isFullScreenAPIEnabled):

3:16 PM Changeset in webkit [92575] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] svg/zoom/page/zoom-svg-through-* results diverging between bots
​https://bugs.webkit.org/show_bug.cgi?id=65831

Unreviewed Qt gardening.

  • platform/qt/Skipped:
12:42 PM Changeset in webkit [92574] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit2

[QT] Possible Leaks WKRetainPtr<> should Adopt allocated Copy
​https://bugs.webkit.org/show_bug.cgi?id=65790

Reviewed by Sam Weinig.

Fix a leak by adopting an allocation instead of retaining it.

  • UIProcess/qt/qwkhistory.cpp:

(QWKHistoryItem::title):
(QWKHistoryItem::url):

6:47 AM Changeset in webkit [92573] by Martin Robinson
  • 5 edits in trunk/Source

Distribution fix for GTK+.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Strip removed files from the source list.

Source/WebCore:

  • GNUmakefile.am: Add some files to the distribution list.
  • GNUmakefile.list.am: Strip removed files from the source list.
4:29 AM Changeset in webkit [92572] by jochen@chromium.org
  • 5 edits
    1 move in trunk/Source/WebCore

Move FrameLoadRequest to loader/
​https://bugs.webkit.org/show_bug.cgi?id=65817

Reviewed by Alexey Proskuryakov.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::isEmpty):
(WebCore::FrameLoadRequest::requester):
(WebCore::FrameLoadRequest::resourceRequest):
(WebCore::FrameLoadRequest::frameName):
(WebCore::FrameLoadRequest::setFrameName):

2:48 AM Changeset in webkit [92571] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

Source/WebCore: Add the ability to search the AccessibilityObject cache
​https://bugs.webkit.org/show_bug.cgi?id=64994

New AccessibilityObject cache search functionality and API for the mac
platform to expose it. At this point the AccessibilityObject cache can
be searched using one of the supported search keys that have been defined
in AccessibilityObject.h, or by passing search text.

Patch by Sam White <​samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

Test: platform/mac/accessibility/search-predicate.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::isAccessibilityTextSearchMatch):
(WebCore::AccessibilityObject::accessibilityObjectContainsText):
(WebCore::AccessibilityObject::accessibleObjectsWithAccessibilitySearchPredicate):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools: Add the ability to search the AccessibilityObject cache
​https://bugs.webkit.org/show_bug.cgi?id=64994

Added testing support for AccessibilityObject cache searching. Currently,
only the mac platform is full supported and has had API exposed. Other
platforms have only have this new functionality stubbed. Full implementation
is a job suited only for an accessibility expert of each respective platform.

Patch by Sam White <​samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementForSearchPredicateCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

LayoutTests: Add the ability to search the AccessibilityObject cache
​https://bugs.webkit.org/show_bug.cgi?id=64994

Tests for the new AccessibilityObject cache search API and the additional
functionality in the AccessibilityObject class that makes AccessibilityObject
cache searching possible.

Additional tests for finding frames, misspellings, and visited links will be
included in a subsequent patch.

Patch by Sam White <​samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

  • platform/mac/accessibility/bounds-for-range-expected.txt:
  • platform/mac/accessibility/search-predicate-expected.txt: Added.
  • platform/mac/accessibility/search-predicate.html: Added.
1:01 AM Changeset in webkit [92570] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Rebaseline a test on GTK+ for which r92554 checked in an
incorrect result.

  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Update results.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Ditto.

Aug 6, 2011:

8:44 PM Changeset in webkit [92569] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=65821
Don't form identifiers the first time a string is used as a property name.

Reviewed by Oliver Hunt.

This is a 1% win on SunSpider.

  • dfg/DFGOperations.cpp:
    • Use fastGetOwnProperty.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Use fastGetOwnProperty.
  • runtime/JSCell.h:
  • runtime/JSObject.h:

(JSC::JSCell::fastGetOwnProperty):

  • Fast call to get a property without creating an identifier the first time.
  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::find):
(JSC::PropertyTable::findWithString):

  • Add interface to look up by either strinsg or identifiers.
  • runtime/Structure.h:

(JSC::Structure::get):

  • Add a get() call that takes a UString, not an Identifier.
  • wtf/text/StringImpl.h:

(WTF::StringImpl::hasHash):

  • Add a call to check if the has has been set (to detect the first use as a property name).
6:09 PM Changeset in webkit [92568] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a memory leak found via code inspection.

Rubber-stamped by Dan Bernstein.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::setOriginalURLForDownload): Adopt the newly-allocated NSURL instance
so that it does not leak.

6:09 PM Changeset in webkit [92567] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a memory leak found via code inspection.

Rubber-stamped by Dan Bernstein.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): Adopt the newly-allocated WebHTMLConverter
instance so that it does not leak.

4:35 PM Changeset in webkit [92566] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.
Fix environmental differencies in the results added in r92564.
I was in the wrong chroot.

  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
3:36 PM Changeset in webkit [92565] by siddharth.mathur@nokia.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Add Siddharth Mathur to committer list. Unreviewed

3:29 PM Changeset in webkit [92564] by kbalazs@webkit.org
  • 2 edits
    27 adds in trunk/LayoutTests

Unreviewed gardening.
Add missing Qt results.

  • platform/qt/Skipped:
  • platform/qt/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
  • platform/qt/fast/writing-mode/border-styles-vertical-lr-expected.txt: Added.
  • platform/qt/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
  • platform/qt/fast/writing-mode/border-styles-vertical-rl-expected.txt: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
3:19 PM Changeset in webkit [92563] by abarth@webkit.org
  • 6 edits
    6 deletes in trunk/Tools

Remove dead code in webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=65818

Reviewed by Dimitri Glazkov.

This code was added to support the rebaseline2 command six months ago,
but the rebaseline2 command was never finished and no one else has used
this code since it was landed. This patch removes the dead code. If
we revive rebaseline2, then we can revert this patch and recover the
code. Until then, this code is just dead weight.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/testoutput.py: Removed.
  • Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
  • Scripts/webkitpy/common/net/testoutputset.py: Removed.
  • Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
  • Scripts/webkitpy/common/system/directoryfileset.py: Removed.
  • Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
3:17 PM Changeset in webkit [92562] by abarth@webkit.org
  • 3 edits in trunk/Tools

webkit-patch optimize-baselines can't handle promotions to base results directory
​https://bugs.webkit.org/show_bug.cgi?id=65819

Reviewed by Dimitri Glazkov.

This bug came up when testing the optimizer on some editing baselines.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3:04 PM Changeset in webkit [92561] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Fix baselines for cross-origin-xsl-BLOCKED.html. These results
uncovered a subtle bug in webkit-patch bulk-optimize-baselines, which
I'll fix in a follow-up patch.

  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
2:24 PM Changeset in webkit [92560] by abarth@webkit.org
  • 1 edit
    3 adds
    8 deletes in trunk/LayoutTests

Optimize expected results for editing.
This patch was created with webkit-patch bulk-optimize-baselines.

  • platform/chromium-mac/editing/pasteboard/copy-paste-float-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium-win-xp/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/copy-paste-float-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/5761530-1-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/copy-paste-float-expected.txt: Added.
  • platform/chromium/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Added.
  • platform/chromium/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Added.
2:11 PM Changeset in webkit [92559] by abarth@webkit.org
  • 1 edit
    2 adds
    3 deletes in trunk/LayoutTests

Optimize expected results for animations.
This patch was created with webkit-patch bulk-optimize-baselines.

  • platform/chromium-mac/animations/keyframes-rule-expected.txt: Removed.
  • platform/chromium-mac/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium-win/animations/keyframes-rule-expected.txt: Removed.
  • platform/chromium/animations/keyframes-rule-expected.txt: Added.
  • platform/chromium/animations/opacity-transform-animation-expected.png: Removed.
2:07 PM Changeset in webkit [92558] by abarth@webkit.org
  • 2 edits in trunk/Tools

Add a small command to optimize baselines in bulk.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
1:48 PM Changeset in webkit [92557] by abarth@webkit.org
  • 1 edit
    50 adds
    82 deletes in trunk/LayoutTests

Optimize expected results for http/tests/security.
This patch was created with webkit-patch optimize-baselines.

  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-enumeration-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-get-override-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-history-get-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-history-get-override-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-history-put-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-location-get-override-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-location-put-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/xss-eval-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-enumeration-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-get-override-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-history-get-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-history-get-override-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-history-put-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-location-get-override-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-location-put-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/xss-eval-expected.txt: Removed.
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-enumeration-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-get-override-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-history-get-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-history-get-override-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-history-put-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-location-get-override-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-location-put-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium/http/tests/security/dataURL: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/frameNavigation: Added.
  • platform/chromium/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/listener: Added.
  • platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Added.
  • platform/chromium/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
  • platform/chromium/http/tests/security/xss-eval-expected.txt: Added.
1:17 PM Changeset in webkit [92556] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Fix Timer heap implementation to work with more libraries (other versions of STL)
​https://bugs.webkit.org/show_bug.cgi?id=65782

Reviewed by Anders Carlsson.

No behavior change, so no tests needed. Existing tests pass.

  • platform/Timer.cpp: Added TimerHeapPointer and TimerHeapReference class

alongside the TimerHeapIterator class. Also added a swap function. Also
added a TimerHeapLessThanFunction class.
(WebCore::TimerBase::heapDecreaseKey): Pass pointers in to the TimerHeapIterator
since that's how the class works now. Pass a TimerHeapLessThanFunction object
instead of letting the library use the < operator directly.
(WebCore::TimerBase::heapPopMin): Ditto.

  • platform/Timer.h: Updated for above changes.
12:52 PM Changeset in webkit [92555] by commit-queue@webkit.org
  • 11 edits in trunk

Patch by Aron Rosenberg <​arosenberg@logitech.com> on 2011-08-06
Reviewed by Benjamin Poulain.

[Qt] Fix build with Intel compiler on Windows
​https://bugs.webkit.org/show_bug.cgi?id=65088

.:

Disable Intel Compiler warning 873 - function "" has no corresponding operator
delete (to be called if an exception is thrown during initialization of an
allocated object).

  • Source/WebKit.pri:

Source/JavaScriptCore:

Intel compiler needs .lib suffixes instead of .a
Intel compiler doesn't support nullptr
Intel compiler supports unsized arrays

Source/WebCore:

Intel compiler needs .lib suffixes instead of .a

  • WebCore.pri:

Source/WebKit2:

Intel compiler needs .lib suffixes instead of .a

  • WebKit2.pri:
10:09 AM Changeset in webkit [92554] by Nikolas Zimmermann
  • 6 edits
    2 deletes in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

Rebaseline some tests on Leopard/gtk/qt in order to get the bots greener.

Not reviewed.


  • platform/gtk/Skipped:
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
10:00 AM Changeset in webkit [92553] by mitz@apple.com
  • 4 edits in trunk/Source/WebCore

Move the shared LineBreakIteratorPool from ThreadGlobalData into its own ThreadSpecific
​https://bugs.webkit.org/show_bug.cgi?id=65809

Reviewed by Darin Adler and Sam Weinig.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::destroy): Removed code to clear the m_lineBreakIteratorPool member
variable, which was removed.

  • platform/ThreadGlobalData.h: Removed lineBreakIteratorPool() and associated member variable.
  • platform/text/LineBreakIteratorPoolICU.h:

(WebCore::LineBreakIteratorPool::sharedPool): Changed to return a thread-specific pool.

9:17 AM Changeset in webkit [92552] by Joseph Pecoraro
  • 5 edits in trunk/Source

Potential Leaks - RetainPtr<> over retaining Create'd objects
​https://bugs.webkit.org/show_bug.cgi?id=65806

Reviewed by Darin Adler.

Fix a possible leak by adopting an allocation instead of retaining it.

Source/WebCore:

  • platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::NetworkStateNotifier):

  • plugins/mac/PluginPackageMac.cpp:

(WebCore::stringListFromResourceId):
(WebCore::PluginPackage::fetchInfo):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView previousValidKeyView]):

8:57 AM Changeset in webkit [92551] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

REGRESSION (r91540): Favicons are not loaded
​https://bugs.webkit.org/show_bug.cgi?id=65692

Patch by Rafael Brandao <​rafael.lobo@openbossa.org> on 2011-08-06
Reviewed by Darin Adler.

The policy that evaluates whether a page can have icon or not should not
need to be reimplemented each time a new IconDatabaseBase is derived,
so it was moved to WebCore's scope.

  • loader/icon/IconController.cpp:

(WebCore::IconController::startLoader):

  • loader/icon/IconDatabase.cpp:
  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.cpp:

(WebCore::documentCanHaveIcon):

  • loader/icon/IconDatabaseBase.h:
8:23 AM Changeset in webkit [92550] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

It turns out r92545 only partly resolved flakiness on non-mac platforms (especially gtk)

  • try reentering event loop after zooming, by calling notifyDone() using a 0ms timeout.

Rubber-stamped by Antti Koivisto.

  • svg/zoom/resources/testPageZoom.js: (.setTimeout.): Reenter event loop after calling zoomPageIn/Out, before calling layoutTestController.notifyDone().
3:02 AM Changeset in webkit [92549] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

Should use C++-style cast in CSSParser.cpp
​https://bugs.webkit.org/show_bug.cgi?id=65807

Replaces C-style cast with C++style cast.

Reviewed by Shinichiro Hamaji.

No new tests because no behavior change.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseColorFromValue):
(WebCore::CSSParser::parseFontFeatureTag):

2:40 AM Changeset in webkit [92548] by Nikolas Zimmermann
  • 3 edits
    6 adds in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

More gardening: Fix mac-leopard/mac-wk2 failing SVG tests.


Not reviewed.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/mac-wk2/svg/W3C-SVG-1.1: Added.
  • platform/mac-wk2/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
2:27 AM Changeset in webkit [92547] by Nikolas Zimmermann
  • 4 edits
    2 adds in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Win gardening: Rebaseline four svg tests that only needed an update, win7/winxp svg results are clean again.

Not reviewed.

  • platform/win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
2:19 AM Changeset in webkit [92546] by Nikolas Zimmermann
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Follow-up for r92545.


Rebaseline some tests on gtk/qt and win.

  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
1:25 AM Changeset in webkit [92545] by Nikolas Zimmermann
  • 6 edits
    6 moves
    30 adds in trunk

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
​https://bugs.webkit.org/show_bug.cgi?id=64974

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

Reviewed by Zoltan Herczeg.

Rollout r89484, which disabled some svg/zoom/page tests, to see whether the flakiness is gone now.
Add several new tests in svg/as-object - covering bug 64974.

  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/mac/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html: Added.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html: Added.
  • svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
  • svg/as-object/embedded-svg-immediate-offsetWidth-query.html: Added.
  • svg/as-object/embedded-svg-size-changes-expected.txt: Added.
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers.html: Added.
  • svg/as-object/embedded-svg-size-changes.html: Added.
  • svg/as-object/nested-embedded-svg-size-changes-expected.txt: Added.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html: Added.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html: Added.
  • svg/as-object/nested-embedded-svg-size-changes.html: Added.
  • svg/as-object/resources: Added.
  • svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg: Added.
  • svg/as-object/resources/embedded-svg-size-changes.svg: Added.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html: Added.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-2.html: Added.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target.html: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Removed.

2011-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
​https://bugs.webkit.org/show_bug.cgi?id=64974

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
​https://bugs.webkit.org/show_bug.cgi?id=63186

Reviewed by Zoltan Herczeg.

Fix host <-> embedded document size negotiation race. The currently implemented solution relied on a specific
order of paint/layout calls, which is broken. Consider rendering a document containing an object/iframe/embed
referencing an external SVG file. When FrameView::layout() is called (associated with the outermost RenderView
of the host document), it lays out the whole document, and afterwards performPostLayoutTasks() is called.
This method then asks the Frames contentRenderer to update its widget positions. This triggers a call
of the embedded documents FrameView::layout() method, which now lays out the embedded SVG documents tree
through RenderSVGRoot::layout.

And here's the bug: The size of the object/iframe replaced element, which hosts the embedded document
may depend on the intrinsic size of the SVG. We tried to mark the embedded documents _ownerRenderer_ (the RenderPart)
as "needs layout and pref width recalc" right from RenderSVGRoot::layout() and hoped that this would cause the whole
document to be laid out again, now that the size of the embedded SVG document is known.

As soon as the SVG document is laid out, the host document will be painted (flush deferred repaints) and an assertion
ASSERTS(!needsLayout()) will be fired, as we modified the setNeedsLayout() state after the host document layout finished,
right before painting.

A proper fix is to only keep track in RenderSVGRoot whether it needs to negotiate the size with the host document, but
not modify the layout state of the host document in any way. Let FrameView handle the size negotiation right in
FrameView::layout().

Consider following document:
<body><iframe src="some.svg"></body>


After initial loading & parsing of the document, a FrameView exists for the main frame, and a sub-FrameView
for the <iframe>. The external SVG document, may not be loaded yet at this point. That means when RenderIFrame::layout()
tries to figure out its size (computeLogicalWidth/Height) - the RenderSVGRoot renderer of the external document hasn't
been created yet (as the external document hasn't received data yet) - so it falls back to eg. 300x150 CSS default size
(in the simplest case, where width/height are both auto).

Suppose the external document now finished loading, the RenderSVGRoot is created and a global relayout is triggered
starting from the main FrameView. As we already laid out the document once, needsLayout() is false for the main FrameView,
so _only_ the child frame view that contains the RenderSVGRoot is now laid out, for the first time.

After layout is done, the SVG document is fully laid out, though the RenderPart which embedded the SVG does NOT notice
the SVG has been laid out, so it still carries the default 300x150 size (and needsLayout=false!).

The fix is to retrigger layout of the parent frame view by marking the owner renderer of the frame view as "needs layout
and pref widths recalc" and immediatiely performing a synchronous update of the layout. It's important to do it sync,
as scripts depend on the result of the size negotiation (covered extensively with the new tests in svg/as-object).

Reenable svg/zoom/page/zoom-svg-through-object* tests to see whether the flakiness is gone.

Tests: svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html

svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html
svg/as-object/embedded-svg-immediate-offsetWidth-query.html
svg/as-object/embedded-svg-size-changes-no-layout-triggers.html
svg/as-object/embedded-svg-size-changes.html
svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html
svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html
svg/as-object/nested-embedded-svg-size-changes.html
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-auto-size.html
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-override-size.html
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml

  • page/FrameView.cpp: (WebCore::FrameView::layout): Call forceLayoutParentViewIfNeeded() after layout finished. (WebCore::FrameView::forceLayoutParentViewIfNeeded): Added helper method. (WebCore::FrameView::embeddedContentBox): Moved from RenderPart to a more central place.
  • page/FrameView.h:
  • rendering/RenderPart.cpp: (WebCore::RenderPart::embeddedContentBox): Moved to FrameView.
  • rendering/svg/RenderSVGRoot.cpp: Rename m_didNegotiateSize to m_needsSizeNegotiationWithHostDocument. (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::layout): Only figure out if we need neggotiation, don't actually do anything, let FrameView handle this.
  • rendering/svg/RenderSVGRoot.h: Remove incorrect negotiateSizeWithHostDocumentIfNeeded() logic. (WebCore::RenderSVGRoot::needsSizeNegotiationWithHostDocument): Added getter for m_needsSizeNegotiationWithHostDocument. (WebCore::RenderSVGRoot::scheduledSizeNegotiationWithHostDocument): Added safe way to clear m_needsSizeNegotiationWithHostDocument (asserts if it was false before).
Note: See TracTimeline for information about the timeline view.