Timeline
Sep 17, 2011:
- 8:47 PM Changeset in webkit [95389] by
-
- 8 edits1 delete in trunk/Source/JavaScriptCore
DFG JIT does not have full block-local CSE
https://bugs.webkit.org/show_bug.cgi?id=68316
Reviewed by Oliver Hunt.
This adds block-local CSE to the DFG. CSE runs in the propagator just after
type propagation. It is part of the propagator itself because it needs to
use the propagator's internal data structures to determine which operations
may have side effects. Because it changes the live-ranges of nodes, the
virtual register allocator had to be moved into the propagator so that it
runs after CSE. To ensure that the back-end knows to keep the inputs to
any eliminated node alive for OSR, a new node type, Phantom, was introduced.
It is a no-op but prolonges the live-range of its inputs.
This is an 80% speed-up on imaging-gaussian-blur, and a 10% speed-up on
Kraken.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAliasTracker.h: Removed.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::MethodCheckData::operator==):
(JSC::DFG::MethodCheckData::operator!=):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasVirtualRegister):
(JSC::DFG::Node::setRefCount):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::computeStartIndex):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::performBlockCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:33 PM Changeset in webkit [95388] by
-
- 5 edits in trunk/Source/JavaScriptCore
method_check should repatch itself if it finds that the new structure(s)
are the result of transitions from the old structure(s)
https://bugs.webkit.org/show_bug.cgi?id=68294
Reviewed by Gavin Barraclough.
Previously a patched method_check would slow-path to get_by_id. Now it
slow-paths to method_check_update, which attempts to correct the
method_check due to structure transitions before bailing to get_by_id.
This is a 1-2% speed-up on some benchmarks and is not a slow-down
anywhere, leading to a 0.6% speed-up on the Kraken geomean.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- runtime/Structure.h:
(JSC::Structure::transitivelyTransitionedFrom):
- 4:31 PM Changeset in webkit [95387] by
-
- 35 edits in trunk/Source
FrameLoaderClient BackForwardList-related methods are unsued
https://bugs.webkit.org/show_bug.cgi?id=68293
Reviewed by Darin Adler.
Source/WebCore:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- history/BackForwardListImpl.cpp:
(WebCore::BackForwardListImpl::addItem):
(WebCore::BackForwardListImpl::goBack):
(WebCore::BackForwardListImpl::goForward):
(WebCore::BackForwardListImpl::goToItem):
(WebCore::BackForwardListImpl::setCapacity):
- loader/EmptyClients.h:
- loader/FrameLoaderClient.h:
Source/WebKit/chromium:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- src/FrameLoaderClientImpl.cpp:
- src/FrameLoaderClientImpl.h:
Source/WebKit/efl:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
- WebCoreSupport/FrameLoaderClientEfl.h:
Source/WebKit/gtk:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.h:
Source/WebKit/haiku:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/FrameLoaderClientHaiku.cpp:
- WebCoreSupport/FrameLoaderClientHaiku.h:
Source/WebKit/mac:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebKit.order:
Source/WebKit/qt:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/FrameLoaderClientQt.cpp:
- WebCoreSupport/FrameLoaderClientQt.h:
Source/WebKit/win:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/WebFrameLoaderClient.cpp:
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit/wince:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
- WebCoreSupport/FrameLoaderClientWinCE.h:
Source/WebKit/wx:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebKitSupport/FrameLoaderClientWx.cpp:
- WebKitSupport/FrameLoaderClientWx.h:
Source/WebKit2:
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 4:12 PM Changeset in webkit [95386] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=68307
Crash in border image cssText. Make sure to null check all the components, since they're all
optional now.
Reviewed by Sam Weinig.
Source/WebCore:
Added fast/borders/border-image-slice-omission.html
- css/CSSBorderImageValue.cpp:
(WebCore::CSSBorderImageValue::cssText):
LayoutTests:
- fast/borders/border-image-slice-omission.html: Added.
- 3:47 PM Changeset in webkit [95385] by
-
- 11 edits2 adds in trunk/Source
Rework script context creation/release notifications
https://bugs.webkit.org/show_bug.cgi?id=67828
Reviewed by Adam Barth.
Source/WebCore:
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
- bindings/v8/V8IsolatedContext.h:
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
(WebCore::EmptyFrameLoaderClient::willReleaseScriptContext):
- loader/FrameLoaderClient.h:
Source/WebKit/chromium:
- public/WebFrameClient.h:
(WebKit::WebFrameClient::didCreateScriptContext):
(WebKit::WebFrameClient::didDestroyScriptContext):
(WebKit::WebFrameClient::willReleaseScriptContext):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):
- src/FrameLoaderClientImpl.h:
- 1:10 PM Changeset in webkit [95384] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] fast/events/media-element-focus-tab.html fails
https://bugs.webkit.org/show_bug.cgi?id=68315
- platform/qt-wk2/Skipped: Skip fast/events/media-element-focus-tab.html until fix.
- 10:43 AM Changeset in webkit [95383] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312
Reviewed by Pavel Feldman.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createFileSelector):
- 8:58 AM Changeset in webkit [95382] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r95372.
- dom/DOMAllInOne.cpp: #include "EventListenerMap.cpp"
- 3:57 AM Changeset in webkit [95381] by
-
- 6 edits4 adds in trunk
Override supportsFocus() for HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=67190
Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-17
Reviewed by Antonio Gomes.
Source/WebCore:
Tests: fast/events/media-element-focus-tab.html
fast/spatial-navigation/snav-media-elements.html
Return true from supportsFocus() if control's attribute is present or a tabindex is specified.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsFocus):
- html/HTMLMediaElement.h:
LayoutTests:
For media elements be able to receive focus without tabindex if
control attribute is present, hence changed
tabindex-focus-blur-all.js and tabindex-focus-blur-all-expected.txt.
- fast/events/media-element-focus-tab-expected.txt: Added.
- fast/events/media-element-focus-tab.html: Added.
- fast/events/resources/tabindex-focus-blur-all.js:
(test):
- fast/events/tabindex-focus-blur-all-expected.txt:
- fast/spatial-navigation/snav-media-elements-expected.txt: Added.
- fast/spatial-navigation/snav-media-elements.html: Added.
- 2:49 AM Changeset in webkit [95380] by
-
- 3 edits2 adds in trunk/Source/WebKit/chromium
[chromium]The focus of an input field inside an Iframe doesn't get cleared even though clearFocusedNode is called.
https://bugs.webkit.org/show_bug.cgi?id=68162
Add a unit-test to check whether the focus of node is get cleared when clearFocusNode called.
This test check for focus of input node inside a frame after clear focus get called.
Patch by chandra shekar vallala <chandra.vallala@motorola.com> on 2011-09-17
Reviewed by Adam Barth.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::clearFocusedNode):
- tests/WebFrameTest.cpp:
(WebKit::TEST_F): Added a unit test to make sure that focus of the node is get cleared.
- tests/data/autofocus_input_field_iframe.html: Added.
- tests/data/iframe_clear_focused_node_test.html: Added.
- 2:28 AM Changeset in webkit [95379] by
-
- 3 edits in trunk
[EFL] Bump minimum requirement for cairo to 1.10.
https://bugs.webkit.org/show_bug.cgi?id=68226
Reviewed by Adam Barth.
- Source/cmake/FindCairo.cmake: Check required version.
- Source/cmake/OptionsEfl.cmake:
- 2:08 AM Changeset in webkit [95378] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt: Update after r95335.
- 1:59 AM Changeset in webkit [95377] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening after r95337.
- platform/qt-wk2/Skipped: Skip one more test.
- 1:06 AM Changeset in webkit [95376] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] fast/forms/submit-to-blank-multiple-times.html fails
https://bugs.webkit.org/show_bug.cgi?id=68309
- platform/qt-wk2/Skipped: Skip fast/forms/submit-to-blank-multiple-times.html.
- 12:57 AM Changeset in webkit [95375] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening after r95335.
- platform/qt-wk2/Skipped: Skip new failing tests.
- 12:49 AM Changeset in webkit [95374] by
-
- 6 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped: Skip plugins/fullscreen-plugins-dont-reload.html, because ENABLE(FULLSCREEN_API) is disabled on Qt.
- platform/qt/fast/dom/Window/window-properties-expected.png: Updated after r95362.
- platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r95362.
- platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Updated after r95362.
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r95362.
Sep 16, 2011:
- 11:52 PM Changeset in webkit [95373] by
-
- 20 edits in trunk/Source
Rename ENABLE(LEVELDB) to USE(LEVELDB)
https://bugs.webkit.org/show_bug.cgi?id=68290
Reviewed by Darin Adler.
Source/WebCore:
LEVELDB is a library that can be used to implemented INDEXED_DATABASE,
which means it should be a USE not an ENABLE.
- CMakeLists.txt:
- WebCore.gyp/WebCore.gyp:
- platform/leveldb/LevelDBComparator.h:
- platform/leveldb/LevelDBDatabase.cpp:
- platform/leveldb/LevelDBDatabase.h:
- platform/leveldb/LevelDBIterator.h:
- platform/leveldb/LevelDBSlice.h:
- platform/leveldb/LevelDBTransaction.cpp:
- platform/leveldb/LevelDBTransaction.h:
- platform/leveldb/LevelDBWriteBatch.cpp:
- platform/leveldb/LevelDBWriteBatch.h:
- storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB):
- storage/IDBLevelDBBackingStore.cpp:
- storage/IDBLevelDBBackingStore.h:
- storage/IDBLevelDBCoding.cpp:
- storage/IDBLevelDBCoding.h:
Source/WebKit/chromium:
- features.gypi:
- tests/IDBLevelDBCodingTest.cpp:
- 11:34 PM Changeset in webkit [95372] by
-
- 13 edits2 adds in trunk/Source/WebCore
Reduce EventTarget memory usage by deferring hash map allocation
until there are listeners for more than 1 event type.
Patch by Andreas Kling <kling@webkit.org> on 2011-09-16
Reviewed by Darin Adler.
Introduce an EventListenerMap class which manages a map of event types that have
one or more listeners connected.
When there is only one event type, it's stored directly on the EventListenerMap
internally, and when more are added it moves to a hash map. It only goes back
from the hash map if all the listeners are removed at once (i.e clear() is called.)
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Adding files.
- WebCore.exp.in:
Export EventListenerMap::contains() for WebKit/mac.
- dom/EventListenerMap.cpp: Added.
(WebCore::EventListenerMap::EventListenerMap):
(WebCore::EventListenerMap::~EventListenerMap):
(WebCore::EventListenerMap::isEmpty):
(WebCore::EventListenerMap::contains):
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::eventTypes):
(WebCore::addListenerToVector):
(WebCore::EventListenerMap::add):
(WebCore::removeListenerFromVector):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::removeFirstListenerCreatedFromMarkup):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
(WebCore::EventListenerIterator::nextListener):
- dom/EventListenerMap.h: Added.
- dom/EventTarget.cpp:
(WebCore::EventTargetData::~EventTargetData):
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::getEventListeners):
(WebCore::EventTarget::removeAllEventListeners):
- dom/EventTarget.h:
(WebCore::EventTarget::visitJSEventListeners):
Use EventListenerIterator to visit listeners. (JSC specific.)
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getEventListenersForNode):
Call EventListenerMap::eventTypes() go get the list of event types
currently listened for.
- dom/Node.cpp:
(WebCore::Node::removeEventListener):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::transferEventListenersToShadowTree):
Move implementations of SVG-specific hacks into EventListenerMap and
call them from here.
- 11:07 PM Changeset in webkit [95371] by
-
- 6 edits2 adds in trunk
Don't detach elements from the render tree when entering fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=66531
Source/WebCore:
This prevents plugin instances from being destroyed and reinstantiated
when entering fullscreen mode.
Reviewed by James Robinson.
Test: plugins/fullscreen-plugins-dont-reload.html
- dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRendererFactory::createRendererIfNeeded):
- rendering/RenderFullScreen.cpp:
(createFullScreenStyle):
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
- rendering/RenderFullScreen.h:
LayoutTests:
Test that the plugin is not reloaded when entering fullscreen.
Reviewed by James Robinson.
- plugins/fullscreen-plugins-dont-reload-expected.txt: Added.
- plugins/fullscreen-plugins-dont-reload.html: Added.
- 10:53 PM Changeset in webkit [95370] by
-
- 4 edits in trunk/Tools
add non-CG Webkit-Mac builds to flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=68265
Patch by Elliot Poger <epoger@google.com> on 2011-09-16
Reviewed by Adam Barth.
As Chromium-on-Mac approaches the switchover from Core Graphics to
Skia, we need to add the Skia version to the flakiness dashboard.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- TestResultServer/static-dashboards/builders.js:
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
- 10:52 PM Changeset in webkit [95369] by
-
- 17 edits7 adds in trunk
Source/WebCore: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071
This will allow embedders to block images based on where the image is loaded from, instead of just blocking all images in a given frame.
Reviewed by Adam Barth.
- html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::appendBytes):
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::allowImage):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):
Source/WebKit/chromium: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071
Reviewed by Adam Barth.
- public/WebPermissionClient.h:
(WebKit::WebPermissionClient::allowImage):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowImage):
- src/FrameLoaderClientImpl.h:
Tools: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071
Reviewed by Adam Barth.
- DumpRenderTree/chromium/WebPermissions.cpp:
(WebPermissions::allowImage):
- DumpRenderTree/chromium/WebPermissions.h:
LayoutTests: Add tests for FrameLoaderClient::allowImage.
https://bugs.webkit.org/show_bug.cgi?id=68071
Reviewed by Adam Barth.
- http/tests/permissionclient/resources/bostin.gif:
- http/tests/permissionclient/resources/redir.php:
- platform/chromium/permissionclient/image-permissions-expected.txt:
- platform/chromium/permissionclient/image-permissions.html:
- platform/http/tests/permissionclient/image-permissions-expected.txt:
- platform/http/tests/permissionclient/image-permissions.html:
- 10:30 PM Changeset in webkit [95368] by
-
- 3 edits in trunk/Source/WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=67733
[Chromium] Separate WebKit initialization and V8 initialization in chromium port.
Reviewed by Darin Fisher.
- public/WebKit.h:
- src/WebKit.cpp:
(WebKit::initialize):
(WebKit::initializeWithoutV8):
- 10:24 PM Changeset in webkit [95367] by
-
- 2 edits1 add in trunk/Source/WebKit2
[Qt] QTouchWebView missing loadProgress tests
https://bugs.webkit.org/show_bug.cgi?id=68183
Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-16
Reviewed by Chang Shu.
Added test case to check load progress for QTouchWebView
- UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml: Added.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- 10:16 PM Changeset in webkit [95366] by
-
- 4 edits2 adds in trunk
Make XSSAuditor truncate inline snippets at a reasonable length before comparison
respecting boundaries of multiply urlencoded sequences.
https://bugs.webkit.org/show_bug.cgi?id=68092
Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-16
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/xssAuditor/property-escape-long.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::isContainedInRequest):
- html/parser/XSSAuditor.h:
LayoutTests:
- http/tests/security/xssAuditor/property-escape-long-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-long.html: Added.
- 9:39 PM Changeset in webkit [95365] by
-
- 8 edits in trunk/Source/WebCore
Remove m_contentsDirty from LayerChromium because it
is redundant with m_dirtyRect.
https://bugs.webkit.org/show_bug.cgi?id=68213
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.
Code cleanup towards unit testing.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setNeedsDisplay):
(WebCore::LayerChromium::resetNeedsDisplay):
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
- 9:28 PM Changeset in webkit [95364] by
-
- 2 edits in trunk/Source/JavaScriptCore
Touch Platform.h in the hope to fix SnowLeopard Intel Release (WebKit2 Tests).
- wtf/Platform.h:
- 9:15 PM Changeset in webkit [95363] by
-
- 2 edits in trunk/Tools
update-webkit-chromium should retry the gclient call if it fails once
https://bugs.webkit.org/show_bug.cgi?id=68252
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-16
Reviewed by Adam Barth.
- Scripts/update-webkit-chromium:
- 9:01 PM Changeset in webkit [95362] by
-
- 26 edits in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=66714
Add webkitPostMessage to allow for adding transferable support.
This adds webkitPostMessage, currently identical to postMessage, which
would later be a vehicle for adding transferable support for messaging.
Based on patch by Luke Zarko.
Reviewed by David Levin.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::webkitPostMessage):
- bindings/js/JSDedicatedWorkerContextCustom.cpp:
(WebCore::JSDedicatedWorkerContext::webkitPostMessage):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::webkitInitMessageEvent):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::webkitPostMessage):
- bindings/js/JSWorkerCustom.cpp:
(WebCore::JSWorker::postMessage):
(WebCore::JSWorker::webkitPostMessage):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
(WebCore::V8DOMWindow::postMessageCallback):
(WebCore::V8DOMWindow::webkitPostMessageCallback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventCallback):
(WebCore::V8MessageEvent::webkitInitMessageEventCallback):
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
(WebCore::V8MessagePort::postMessageCallback):
(WebCore::V8MessagePort::webkitPostMessageCallback):
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
(WebCore::V8Worker::postMessageCallback):
(WebCore::V8Worker::webkitPostMessageCallback):
- dom/MessageEvent.idl:
- dom/MessagePort.idl:
- page/DOMWindow.idl:
- workers/DedicatedWorkerContext.idl:
- workers/Worker.idl:
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=66714
Add webkitPostMessage to allow for adding transferable support.
This adds webkitPostMessage, currently identical to postMessage, which
would later be a vehicle for adding transferable support for messaging.
The tests ensure that webkitPostMessage and postMessage behave identically.
Based on patch by Luke Zarko.
Reviewed by David Levin.
- fast/dom/Window/window-postmessage-args-expected.txt:
- fast/dom/Window/window-postmessage-args.html:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/events/message-port-expected.txt:
- fast/events/message-port.html:
- fast/workers/resources/worker-call.js:
- fast/workers/worker-call-expected.txt:
- platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
- 8:47 PM Changeset in webkit [95361] by
-
- 3 edits3 adds in trunk
Chromium: Fix repaint of rubber-band overhang area under composited path
https://bugs.webkit.org/show_bug.cgi?id=68246
I accidently removed these two lines from the last patch on: https://bugs.webkit.org/show_bug.cgi?id=66969
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-16
Reviewed by James Robinson.
Test: platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change.html
Source/WebCore:
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
LayoutTests:
- platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change-expected.png: Added.
- platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change-expected.txt: Added.
- platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change.html: Added.
- 8:36 PM Changeset in webkit [95360] by
-
- 11 edits in trunk/Source/WebKit2
Removed unwanted NotImplemented.h inclusion in WebKit2 GTK port & platform independent files
https://bugs.webkit.org/show_bug.cgi?id=68249
Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-16
Reviewed by Martin Robinson.
- Shared/Plugins/NPIdentifierData.cpp: Removed NotImplemented.h inclusion.
- Shared/Plugins/NPRemoteObjectMap.cpp: Removed NotImplemented.h inclusion.
- Shared/Plugins/NPVariantData.cpp: Removed NotImplemented.h inclusion.
- UIProcess/gtk/WebContextGtk.cpp: Removed NotImplemented.h inclusion.
- WebProcess/Cookies/WebCookieManager.cpp: Removed NotImplemented.h inclusion.
- WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp: Removed NotImplemented.h inclusion.
- WebProcess/Plugins/Netscape/JSNPMethod.cpp: Removed NotImplemented.h inclusion.
- WebProcess/Plugins/Netscape/NPJSObject.cpp: Removed NotImplemented.h inclusion.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: Removed NotImplemented.h inclusion.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp: Removed NotImplemented.h inclusion.
- 8:23 PM Changeset in webkit [95359] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Add movementX/Y members to WebMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=68174
Reviewed by Dimitri Glazkov.
- public/WebInputEvent.h:
(WebKit::WebMouseEvent::WebMouseEvent):
- 7:57 PM Changeset in webkit [95358] by
-
- 4 edits in trunk/Source/JavaScriptCore
Rename APIValueWrapper type to APIValueWrapperType for consistency
https://bugs.webkit.org/show_bug.cgi?id=68306
Reviewed by Anders Carlsson.
- runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
Update name.
- runtime/JSType.h:
Update name and un-indent.
- runtime/Structure.h:
(JSC::JSCell::isAPIValueWrapper):
Update name.
- 7:47 PM Changeset in webkit [95357] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove unused isStrictModeFunction function
https://bugs.webkit.org/show_bug.cgi?id=68305
Reviewed by Anders Carlsson.
- runtime/JSObject.h:
(JSC::JSObject::isStrictModeFunction):
- 7:42 PM Changeset in webkit [95356] by
-
- 3 edits in trunk/Source/WebCore
Depend on harfbuzz for OS=Android as well
https://bugs.webkit.org/show_bug.cgi?id=68239
Like GTK, Android depends on harfbuzz as well, so reflect that in
the project file. Furthermore, fix a compile error in PopupListBox.cpp
by explicitly including ctype.h, as isspace otherwise won't be declared.
Patch by Peter Beverloo <peter@chromium.org> on 2011-09-16
Reviewed by Steve Block.
- WebCore.gyp/WebCore.gyp:
- platform/chromium/PopupListBox.cpp:
- 7:40 PM Changeset in webkit [95355] by
-
- 8 edits in trunk
Rename flex-align values to match the spec
https://bugs.webkit.org/show_bug.cgi?id=67741
Reviewed by Ojan Vafai.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):
- css/CSSValueKeywords.in:
- rendering/style/RenderStyleConstants.h:
LayoutTests:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/script-tests/css-properties.js:
- 7:31 PM Changeset in webkit [95354] by
-
- 7 edits2 deletes in trunk
[V8] REGRESSION(94783): calling the binding script during V8 context creation slows down page loads
https://bugs.webkit.org/show_bug.cgi?id=68237
Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-16
Reviewed by Kenneth Russell.
Call the binding script lazily on the first run of the set() method of
a typed array.
- ../../Source/WebCore/WebCore.gypi:
- ../../Source/WebCore/bindings/v8/V8BindingScripts.cpp: Removed.
- ../../Source/WebCore/bindings/v8/V8BindingScripts.h: Removed.
- ../../Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:
- ../../Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:
- ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
- ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
- ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js:
- 7:24 PM Changeset in webkit [95353] by
-
- 5 edits1 add1 delete in trunk/LayoutTests
Chromium pixel test rebaseline for r95335.
- platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
- platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
- platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
- platform/chromium-win-vista/editing: Removed.
- platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
- platform/chromium/test_expectations.txt:
- 7:01 PM Changeset in webkit [95352] by
-
- 9 edits2 adds in trunk
Implement an ErrorEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68148
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-16
Reviewed by Sam Weinig.
Source/WebCore:
The spec for the ErrorEvent constructor is here:
http://dev.w3.org/html5/workers/#errorevent
Test: fast/events/constructors/error-event-constructor.html
- bindings/generic/EventConstructors.h: Added a definition for the ErrorEvent constructor.
- bindings/js/JSEventConstructors.cpp: Added #includes for ErrorEvent.
- dom/ErrorEvent.cpp:
(WebCore::ErrorEventInit::ErrorEventInit):
(WebCore::ErrorEvent::ErrorEvent):
(WebCore::ErrorEvent::initErrorEvent):
(WebCore::ErrorEvent::isErrorEvent):
- dom/ErrorEvent.h: Added a definition for ErrorEventInit.
(WebCore::ErrorEvent::create):
(WebCore::ErrorEvent::message):
(WebCore::ErrorEvent::filename):
(WebCore::ErrorEvent::lineno):
- dom/ErrorEvent.idl: Makes ErrorEvent constructible.
LayoutTests:
error-event-constructor.html checks the behavior of the ErrorEvent constructor.
- fast/dom/constructed-objects-prototypes-expected.txt: Now window has ErrorEvent.
- fast/events/constructors/error-event-constructor-expected.txt: Added.
- fast/events/constructors/error-event-constructor.html: Added.
- platform/chromium/test_expectations.txt: Skipped error-event-constructor.html, since V8 does not yet have the ErrorEvent constructor.
- 6:47 PM Changeset in webkit [95351] by
-
- 1 edit3 adds in trunk/LayoutTests
CORS images viewed from different domains fail security checks
https://bugs.webkit.org/show_bug.cgi?id=68011
Reviewed by Darin Adler.
I am unable to reproduce the bug, but the test I wrote in the process
might be worth having anyway.
- http/tests/security/canvas-cors-with-two-hosts-expected.txt: Added.
- http/tests/security/canvas-cors-with-two-hosts.html: Added.
- http/tests/security/resources/canvas-cors-subtest.html: Added.
- 6:36 PM Changeset in webkit [95350] by
-
- 4 edits12 adds2 deletes in trunk
Overhangs a ruby by no more than half the width of the neighboring text.
https://bugs.webkit.org/show_bug.cgi?id=62684
Reviewed by Dan Bernstein.
Assume two rubies between which a narrow text exists, like
"<ruby>x<rt>xxxxxx</rt></ruby>l<ruby>y<rt>yyyyyy</rt></ruby>".
In order to avoid the two rubies overlapping with each other,
this patch overhangs the ruby by no more than half the ruby font
size and no more than half the width of the neighboring text.
Source/WebCore:
Tests: fast/ruby/overhang-horizontal-no-overlap1.html
fast/ruby/overhang-horizontal-no-overlap2.html
fast/ruby/overhang-vertical-no-overlap1.html
fast/ruby/overhang-vertical-no-overlap2.html
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::getOverhang): Calculates the width of ruby overhanging.
LayoutTests:
- fast/ruby/overhang-horizontal-no-overlap1-expected.png: Added.
- fast/ruby/overhang-horizontal-no-overlap1-expected.txt: Added.
- fast/ruby/overhang-horizontal-no-overlap1.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
- fast/ruby/overhang-horizontal-no-overlap2-expected.png: Added.
- fast/ruby/overhang-horizontal-no-overlap2-expected.txt: Added.
- fast/ruby/overhang-horizontal-no-overlap2.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
- fast/ruby/overhang-vertical-no-overlap1-expected.png: Added.
- fast/ruby/overhang-vertical-no-overlap1-expected.txt: Added.
- fast/ruby/overhang-vertical-no-overlap1.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
- fast/ruby/overhang-vertical-no-overlap2-expected.png: Added.
- fast/ruby/overhang-vertical-no-overlap2-expected.txt: Added.
- fast/ruby/overhang-vertical-no-overlap2.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
- platform/chromium-linux/fast/ruby/overhang-vertical-expected.png: Removed.
- platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Removed.
- platform/chromium/test_expectations.txt: Skips overhang-horizontal.html. We will update the result image as a rebase line.
- 6:32 PM Changeset in webkit [95349] by
-
- 17 edits in trunk/Source/WebCore
Unreviewed, rolling out r95304.
http://trac.webkit.org/changeset/95304
https://bugs.webkit.org/show_bug.cgi?id=68299
Broke GTK+ builds. It pulls derived headers into main.c
(Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16
- bindings/scripts/CodeGeneratorGObject.pm:
():
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
- 6:14 PM Changeset in webkit [95348] by
-
- 8 edits in trunk/Source/WebCore
Re-named isRootLayer to isNonCompositedContent because
that is what the flag actually means.
https://bugs.webkit.org/show_bug.cgi?id=68214
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.
Code cleanup towards unit testing.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setIsNonCompositedContent):
(WebCore::LayerChromium::isNonCompositedContent):
- platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setIsNonCompositedContent):
(WebCore::CCLayerImpl::isNonCompositedContent):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
- 6:12 PM Changeset in webkit [95347] by
-
- 13 edits in trunk/Source
Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
https://bugs.webkit.org/show_bug.cgi?id=68134
Source/WebCore:
Reviewed by Sam Weinig.
Add a new setting to control whether the mock scrollbar theme is used.
This is a global setting, so that it can be set without having to
access a specific Settings object.
- page/Settings.h:
(WebCore::Settings::setMockScrollbarsEnabled):
(WebCore::Settings::mockScrollbarsEnabled):
Source/WebKit/mac:
Reviewed by Sam Weinig.
Hook up a private preference that enables the mock scrollbar theme.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences mockScrollbarsEnabled]):
(-[WebPreferences setMockScrollbarsEnabled:]):
- WebView/WebPreferencesPrivate.h:
Source/WebKit2:
Reviewed by Sam Weinig.
Hook up a private preference that enables the mock scrollbar theme.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetMockScrollbarsEnabled):
(WKPreferencesGetMockScrollbarsEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 6:02 PM Changeset in webkit [95346] by
-
- 3 edits2 adds in trunk
Large canvas fills should not crash or create unnecessarily large image buffers
https://bugs.webkit.org/show_bug.cgi?id=67988
Source/WebCore:
When using source-in, destination-in, source-out, or destination-atop a temporary
buffer is created. This buffer only needs to be big enough to cover the intersection
of the path and the canvas. If the area of intersection between the fill and the
canvas is empty the canvas is completely cleared and a temporary buffer is not used.
This change also adds some null checks for failures to create contexts or buffers.
Patch by Ben Wells <benwells@chromium.org> on 2011-09-16
Reviewed by Darin Adler.
Test: fast/canvas/canvas-large-fills.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):
LayoutTests:
Patch by Ben Wells <benwells@chromium.org> on 2011-09-16
Reviewed by Darin Adler.
- fast/canvas/canvas-large-fills-expected.txt: Added.
- fast/canvas/canvas-large-fills.html: Added.
- 5:55 PM Changeset in webkit [95345] by
-
- 8 edits2 copies in branches/chromium/835
Merge 94508 - <rdar://problem/10071256> Retain retired custom fonts until the next style recalc
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/css/font-face-used-after-retired.html
During style recalc, existing renderers may reference their old style, including font data.
Allow them to do so safely by keeping retired custom font data around until after style recalc.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::retireCustomFont): Added. Calls through to CSSFontSelector, if the font
face is still part of any segmented font face. Otherwise, deletes the custom font data.
- css/CSSFontFace.h:
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::pruneTable): Changed to call retireCustomFont() instead of deleting
retired font data.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::retireCustomFont): Added. Calls through to the Document, if this is
still the active font selector for a document. Otherwise, deletes the custom font data.
- css/CSSFontSelector.h:
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::pruneTable): Changed to call retireCustomFont() instead of
deleting retired font data.
- dom/Document.cpp:
(WebCore::Document::~Document): Added a call to deleteRetiredCustomFonts(), in case the Document
is destroyed before getting a chance to recalc style after custom fonts have been retired.
(WebCore::Document::recalcStyle): Added a call to deleteRetiredCustomFonts() after style recalc.
(WebCore::Document::deleteRetiredCustomFonts): Added. Deletes all previously-retired custom font
data.
- dom/Document.h:
(WebCore::Document::retireCustomFont): Added.
LayoutTests:
- fast/css/font-face-used-after-retired-expected.txt: Added.
- fast/css/font-face-used-after-retired.html: Added.
TBR=mitz@apple.com
Review URL: http://codereview.chromium.org/7932007
- 5:50 PM Changeset in webkit [95344] by
-
- 2 edits in trunk/Source/WebCore
Remove default NULL argument in LayerChromium::create().
https://bugs.webkit.org/show_bug.cgi?id=68211
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.
Code cleanup related to creating unit testing.
- platform/graphics/chromium/LayerChromium.h:
- 5:45 PM Changeset in webkit [95343] by
-
- 2 edits2 adds in trunk/LayoutTests
[chromium] Rebaseline fix up due to r95239.
Add back in a baseline that was removed in my last change.
- platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 5:44 PM Changeset in webkit [95342] by
-
- 5 edits in trunk/LayoutTests
Fix the rebaseline in r95325 and also rebaseline for r95335.
- inspector/styles/styles-update-from-js-expected.txt:
- platform/chromium/test_expectations.txt
- platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
- platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
- 5:33 PM Changeset in webkit [95341] by
-
- 12 edits in trunk/Source/WebCore
[chromium] Move quad drawing code from LayerChromium to LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=68272
Reviewed by James Robinson.
All the OpenGL code is in LayerRendererChromium and the CCLayerImpl
tree, so move the static drawTexturedQuad/toGLMatrix functions to
LayerRendererChromium, where they really belong.
Just moving code around. Tested by existing compositor tests.
- platform/graphics/chromium/LayerChromium.cpp:
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::toGLMatrix):
(WebCore::LayerRendererChromium::drawTexturedQuad):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::drawDebugBorder):
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::drawTiles):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):
- 5:22 PM Changeset in webkit [95340] by
-
- 6 edits in trunk/Source/JavaScriptCore
Cleanup JSTypeInfo a bit
https://bugs.webkit.org/show_bug.cgi?id=68289
Reviewed by Anders Carlsson.
- dfg/DFGOperations.cpp:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
Replace direct access to flags() with predicate.
- runtime/JSObject.h:
(JSC::JSFinalObject::createStructure):
Pass FinalObjectType instead of using special IsJSFinalObject.
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
Add additional assert that you should no object should OverridesHasInstance but not have ImplementsHasInstance set.
(JSC::TypeInfo::isFinalObject):
Added.
(JSC::TypeInfo::masqueradesAsUndefined):
(JSC::TypeInfo::implementsHasInstance):
(JSC::TypeInfo::isEnvironmentRecord):
(JSC::TypeInfo::overridesHasInstance):
(JSC::TypeInfo::implementsDefaultHasInstance):
(JSC::TypeInfo::overridesGetOwnPropertySlot):
(JSC::TypeInfo::overridesVisitChildren):
(JSC::TypeInfo::overridesGetPropertyNames):
(JSC::TypeInfo::prohibitsPropertyCaching):
(JSC::TypeInfo::isSetOnFlags1):
(JSC::TypeInfo::isSetOnFlags2):
Replace direct bit twiddling with helper functions.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
Use new isFinalObject() predicate.
- 5:22 PM Changeset in webkit [95339] by
-
- 2 edits in trunk/Source/WebKit2
Stop installing source and header files in to WebKit2.framework after r95303.
- WebKit2.xcodeproj/project.pbxproj:
- 5:20 PM Changeset in webkit [95338] by
-
- 5 edits in trunk
Unsigned bit shift fails under certain conditions in 32 bit builds
https://bugs.webkit.org/show_bug.cgi?id=68166
Reviewed by Geoff Garen.
Source/JavaScriptCore:
The major bug here is that the slow case (which handles shifts of
doubles) doesn't check for negative results from an unsigned shift
(which should be unsigned, and as such can't be represented by a
signed integer immediate). The implementation is also flawed for
shifts by negative shift amounts (treats as shift by zero).
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
LayoutTests:
Added layout test.
- fast/js/floating-point-truncate-rshift-expected.txt:
- fast/js/floating-point-truncate-rshift.html:
- 5:08 PM Changeset in webkit [95337] by
-
- 2 edits2 adds in trunk/LayoutTests
Add the forgotten test, also suppress a test in Chromium as it needs a rebaseline.
- platform/chromium/test_expectations.txt:
- editing/deleting/merge-paragraph-into-blockquote-expected.txt: Added.
- editing/deleting/merge-paragraph-into-blockquote.html: Added.
- 5:07 PM Changeset in webkit [95336] by
-
- 2 edits in trunk/Source/WebCore
Fixed const correctness on accessors in LayerChromium
https://bugs.webkit.org/show_bug.cgi?id=68210
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.
Code cleanup related to creating unit testing.
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::preserves3D):
(WebCore::LayerChromium::replicaLayer):
- 5:00 PM Changeset in webkit [95335] by
-
- 7 edits15 adds in trunk
Deleting line break before h1 converts h1 to span
https://bugs.webkit.org/show_bug.cgi?id=45784
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Fixed the bug by treating h1 and other elements that retain structure like Mail blockquote.
We already had a logic to overriding styles of merged paragraphs by Mail blockquote so
just extend this logic for h1-h6, pre, etc...
Tests: editing/deleting/merge-paragraph-from-address.html
editing/deleting/merge-paragraph-from-h6-with-style.html
editing/deleting/merge-paragraph-from-h6.html
editing/deleting/merge-paragraph-from-listing.html
editing/deleting/merge-paragraph-into-h1-with-style.html
editing/deleting/merge-paragraph-into-h1.html
editing/deleting/merge-paragraph-into-pre.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
- editing/markup.cpp:
(WebCore::isBlockNodeToRetainAppearance): Extracted from ancestorToRetainStructureAndAppearance.
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::ancestorToRetainStructureAndAppearance):
- editing/markup.h:
LayoutTests:
Added a bunch of tests to ensure WebKit does not keep block elements' style when merging paragraphs.
When removing line breaks between <h1>hello</h1>world and hello<pre>world</pre> for example,
we should not be overriding and preserving styles from h1 in the merge paragraph respectively.
- editing/deleting/merge-paragraph-from-address-expected.txt: Added.
- editing/deleting/merge-paragraph-from-address.html: Added.
- editing/deleting/merge-paragraph-from-h6-expected.txt: Added.
- editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Added.
- editing/deleting/merge-paragraph-from-h6-with-style.html: Added.
- editing/deleting/merge-paragraph-from-h6.html: Added.
- editing/deleting/merge-paragraph-from-listing-expected.txt: Added.
- editing/deleting/merge-paragraph-from-listing.html: Added.
- editing/deleting/merge-paragraph-into-h1-expected.txt: Added.
- editing/deleting/merge-paragraph-into-h1-style-expected.txt: Added.
- editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Added.
- editing/deleting/merge-paragraph-into-h1-with-style.html: Added.
- editing/deleting/merge-paragraph-into-h1.html: Added.
- editing/deleting/merge-paragraph-into-pre-expected.txt: Added.
- editing/deleting/merge-paragraph-into-pre.html: Added.
- platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
- platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
- 4:33 PM Changeset in webkit [95334] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Create WebGL layer for graphics contexts on demand
https://bugs.webkit.org/show_bug.cgi?id=68288
Reviewed by James Robinson.
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):
- src/GraphicsContext3DPrivate.h:
- 4:24 PM Changeset in webkit [95333] by
-
- 3 edits in trunk/Source/WebCore
Set but not used variables cleanup (gcc 4.6)
https://bugs.webkit.org/show_bug.cgi?id=68157
Patch by Max Perepelitsyn <pph34r@gmail.com> on 2011-09-16
Reviewed by Darin Adler.
- platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::process):
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaButton):
- 4:07 PM Changeset in webkit [95332] by
-
- 6 edits16 adds in trunk/LayoutTests
[chromium] Rebaseline fix up due to r95239.
Expectation removal due to r95322 and r95325.
- platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/chromium-cg-mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/chromium-cg-mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/chromium-cg-mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/chromium-cg-mac/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/chromium-linux/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/chromium-mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/chromium-mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
- platform/chromium-win/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/chromium-win/fast/clip/overflow-border-radius-composited-expected.txt: Added.
- platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
- platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
- platform/chromium/test_expectations.txt:
- 4:02 PM Changeset in webkit [95331] by
-
- 10 edits4 deletes in trunk
Removed undetectable style.filter.
Reviewed by Sam Weinig.
This feature was added in http://trac.webkit.org/changeset/15557 to
support housingmaps.com. But housingmaps.com no longer needs this hack,
we don't know of other websites that need it, and we don't know of
any other browsers that have implemented this feature.
Source/JavaScriptCore:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSTypeInfo.h:
- runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.
Source/WebCore:
- ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.
- WebCore.order:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::nameGetter):
LayoutTests:
- fast/dom/undetectable-style-filter-expected.txt: Removed.
- fast/dom/undetectable-style-filter.html: Removed.
- 3:50 PM Changeset in webkit [95330] by
-
- 2 edits in trunk/Tools
2011-09-16 Rob Buis <rbuis@rim.com>
Add Eli's rim address and change the nick.
- Scripts/webkitpy/common/config/committers.py:
- 3:29 PM Changeset in webkit [95329] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r95317.
http://trac.webkit.org/changeset/95317
https://bugs.webkit.org/show_bug.cgi?id=68282
Remove newly added overlapping test expectations. (Requested
by dave_levin on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16
- platform/chromium/test_expectations.txt:
- 3:27 PM Changeset in webkit [95328] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] compilation failed in target 'webkit_unit_tests'.
https://bugs.webkit.org/show_bug.cgi?id=68078
Patch by chandra shekar v <chandra.vallala@motorola.com> on 2011-09-16
Reviewed by Adam Barth.
- tests/WebFrameTest.cpp:
(WebKit::TestReloadDoesntRedirectWebFrameClient::decidePolicyForNavigation):
- 3:02 PM Changeset in webkit [95327] by
-
- 5 edits in trunk/Source/WebCore
Update JSC results to account for intrinsics change.
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- 2:34 PM Changeset in webkit [95326] by
-
- 11 edits in trunk/Source/JavaScriptCore
Prepare JSTypes for more Object subtypes
https://bugs.webkit.org/show_bug.cgi?id=68200
Reviewed by Gavin Barraclough.
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::branchIfNotObject):
- jit/JITInlineMethods.h:
(JSC::JIT::emitJumpIfNotObject):
- runtime/JSGlobalObject.h:
(JSC::Structure::prototypeForLookup):
- runtime/JSObject.h:
(JSC::JSObject::finishCreation):
- runtime/JSType.h:
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::type):
(JSC::TypeInfo::isObject):
(JSC::TypeInfo::isFinal):
(JSC::TypeInfo::prohibitsPropertyCaching):
- runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::finishCreation):
- runtime/Operations.cpp:
(JSC::jsIsObjectType):
- runtime/Structure.cpp:
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
- runtime/Structure.h:
(JSC::Structure::isObject):
(JSC::JSCell::isObject):
- 2:12 PM Changeset in webkit [95325] by
-
- 2 edits in trunk/LayoutTests
Rebaseline from r95242.
- 2:05 PM Changeset in webkit [95324] by
-
- 4 edits in trunk/Source/JavaScriptCore
Rolled back in r95201 with test failure fixed.
I missed two cases of jumpSlowToHot in rshift -- these cases need to be
sure to initialize regT1 to the int tag, since it will otherwise hold
the top 32 bits of a double.
- jit/JIT.h:
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
- jit/JITInlineMethods.h:
(JSC::JIT::emitStoreAndMapInt32):
- 1:59 PM Changeset in webkit [95323] by
-
- 2 edits in trunk/LayoutTests
Replace use of access to nodeList using call, with array style notation.
- editing/pasteboard/paste-noscript.html:
- 1:43 PM Changeset in webkit [95322] by
-
- 5 edits in trunk/LayoutTests
http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=68242
Skip test on ports on which it fails. Move comment to be inside
<?php> block so that HTTP headers can be set on all platforms (there
must not be any whitespace before the <?php> block).
- http/tests/history/back-with-fragment-change.php:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- 1:42 PM Changeset in webkit [95321] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed Windows build fix after 95318.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:33 PM Changeset in webkit [95320] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r95312.
http://trac.webkit.org/changeset/95312
https://bugs.webkit.org/show_bug.cgi?id=68277
It's innocent, innocent I tell you! (Requested by jamesr_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16
Source/WebCore:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::beginCommitOnCCThread):
(WTF::TestHooks::commitCompleteOnCCThread):
(WTF::TestHooks::drawLayersOnCCThread):
(WTF::MockLayerTreeHostImpl::create):
(WTF::MockLayerTreeHostImpl::beginCommit):
(WTF::MockLayerTreeHostImpl::commitComplete):
(WTF::MockLayerTreeHostImpl::drawLayers):
(WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WTF::MockLayerTreeHost::create):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CompositorMockWebGraphicsContext3D::create):
(WTF::CompositorMockWebGraphicsContext3D::makeContextCurrent):
(WTF::CompositorMockWebGraphicsContext3D::createProgram):
(WTF::CompositorMockWebGraphicsContext3D::createShader):
(WTF::CompositorMockWebGraphicsContext3D::getShaderiv):
(WTF::CompositorMockWebGraphicsContext3D::getProgramiv):
(WTF::CompositorMockWebGraphicsContext3D::CompositorMockWebGraphicsContext3D):
(WTF::MockLayerTreeHostClient::create):
(WTF::MockLayerTreeHostClient::animateAndLayout):
(WTF::MockLayerTreeHostClient::createCompositorThread):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockLayerTreeHostClient::createRootLayerPainter):
(WTF::MockLayerTreeHostClient::didRecreateGraphicsContext):
(WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
(WTF::CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(WTF::CCLayerTreeHostTest::postSetNeedsRedrawToMainThread):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onBeginTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):
- 1:33 PM Changeset in webkit [95319] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix after r95310
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added include\private\JavaScriptCore to the
include path so DFGIntrinsic.h can be found.
- 1:32 PM Changeset in webkit [95318] by
-
- 9 edits in trunk/Source/JavaScriptCore
Rationalize JSObject::putDirect* methods
https://bugs.webkit.org/show_bug.cgi?id=68274
Reviewed by Sam Weinig.
Delete the *Function variants. These are overall inefficient,
in the way they get the name back from the function rather
than just passing it in.
- JavaScriptCore.exp:
- jsc.cpp:
(GlobalObject::finishCreation):
(GlobalObject::addFunction):
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
- runtime/JSObject.h:
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
- runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h:
(JSC::lookupPut):
- 1:22 PM Changeset in webkit [95317] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; new expectations (Skia on Mac)
This separates test failures that are specific to CG Mac from failures
for Skia on Mac (Leopard only).
- LayoutTests/platform/chromium/test_expectations.txt:
- 1:18 PM Changeset in webkit [95316] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for Windows.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 1:12 PM Changeset in webkit [95315] by
-
- 8 edits in trunk
Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
https://bugs.webkit.org/show_bug.cgi?id=68269
Reviewed by Geoffrey Garen.
Source/WebKit2:
Add back WKPageMouseDidMoveOverElementCallback last and deprecate the current callback.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::mouseDidMoveOverElement):
Tools:
Update client function signatures.
- MiniBrowser/gtk/BrowserWindow.c:
(browserWindowUIClientInit):
- MiniBrowser/mac/BrowserWindowController.m:
(mouseDidMoveOverElement):
(-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
- 1:06 PM Changeset in webkit [95314] by
-
- 4 edits1 copy in trunk/Source/WebKit2
Give local builds of WebProcess different icon to distinguish them from built-in Safariâs WebProcess
https://bugs.webkit.org/show_bug.cgi?id=68268
Reviewed by Darin Adler.
- Configurations/WebProcess.xcconfig: Add an icon in Debug and Release builds. The empty value for production resulted in WebKit not adding the key to plist at all, which is what we want (but I don't know if it's a supported feature). Also, don't copy the icon file to built framework in production builds.
- WebKit2.xcodeproj/project.pbxproj: Added WebKit.icns.
- WebProcess/Info.plist: Added a key for the icon.
- WebProcess/mac/WebKit.icns: Copied from Websites/webkit.org/images/surfin-safari.icns.
- 1:05 PM Changeset in webkit [95313] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for non-DFG builds.
- runtime/Executable.h:
(JSC::NativeExecutable::finishCreation):
- 1:05 PM Changeset in webkit [95312] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r95309.
http://trac.webkit.org/changeset/95309
https://bugs.webkit.org/show_bug.cgi?id=68271
Broke many chromium gpu tests. (Requested by dave_levin on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16
Source/WebCore:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::animateAndLayout):
(WTF::CCLayerTreeHostTest::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTest::beginCommitOnMainThread):
(WTF::CCLayerTreeHostTest::commitOnCCThread):
(WTF::CCLayerTreeHostTest::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTest::commitCompleteOnMainThread):
(WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTest::updateLayers):
(WTF::CCLayerTreeHostTest::onBeginTest):
(WTF::CCLayerTreeHostTest::doEndTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockLayerTreeHostClient::animateAndLayout):
(WTF::MockLayerTreeHostClient::updateLayers):
(WTF::MockLayerTreeHostCommitter::create):
(WTF::MockLayerTreeHostCommitter::commit):
(WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter):
(WTF::MockLayerTreeHostImpl::create):
(WTF::MockLayerTreeHostImpl::beginCommit):
(WTF::MockLayerTreeHostImpl::commitComplete):
(WTF::MockLayerTreeHostImpl::drawLayersAndPresent):
(WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WTF::MockLayerTreeHostImplProxy::create):
(WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl):
(WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::MockLayerTreeHost::createLayerTreeHostImplProxy):
(WTF::MockLayerTreeHost::updateLayers):
(WTF::MockLayerTreeHost::createLayerTreeHostCommitter):
(WTF::MockLayerTreeHost::beginCommit):
(WTF::MockLayerTreeHost::commitComplete):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread):
- 12:29 PM Changeset in webkit [95311] by
-
- 5 edits in trunk
Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
https://bugs.webkit.org/show_bug.cgi?id=68266
Reviewed by John Sullivan.
Source/WebKit2:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::mouseDidMoveOverElement):
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(mouseDidMoveOverElement):
- 11:50 AM Changeset in webkit [95310] by
-
- 26 edits1 add in trunk/Source
DFG JIT should inline Math.abs
https://bugs.webkit.org/show_bug.cgi?id=68227
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This adds the ability to track intrinsic functions throughout the
host function infrastructure, so that the DFG can easily query
whether or not a call's target is intrinsic, and if so, which
intrinsic it is.
On top of this, it adds Math.abs intrinsics to DFG. Call(Math.abs)
is transformed into ValueToNumber<-ArithAbs nodes. These nodes
then get optimized using the usual tricks.
Also had to make a completely unrelated change to
DateInstanceCache.h in order to fix a preexisting alphabetical
sorting problem in JSGlobalData.h
This results in a big win in imaging-gaussian-blur: 61% faster
than before. The net win on Kraken is around 13%.
- JavaScriptCore.xcodeproj/project.pbxproj:
- create_hash_table:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
- dfg/DFGIntrinsic.h: Added.
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::isFunctionConstant):
(JSC::DFG::JITCodeGenerator::valueOfFunctionConstant):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isFunctionConstant):
(JSC::DFG::JITCompiler::valueOfFunctionConstant):
- dfg/DFGNode.h:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
- jit/JITStubs.h:
- runtime/DateInstanceCache.h:
- runtime/Executable.cpp:
(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):
- runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
- runtime/JSGlobalData.h:
- runtime/Lookup.cpp:
(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h:
(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):
Source/WebCore:
Reviewed by Oliver Hunt.
Added JavaScriptCore/dfg to include path path. Changed the bindings
scripts to handle the presence of intrinsics.
- CMakeLists.txt:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTable):
Source/WebKit:
Reviewed by Oliver Hunt.
Added JavaScriptCore/dfg to include path path.
- CMakeLists.txt:
Source/WebKit2:
Reviewed by Oliver Hunt.
Added JavaScriptCore/dfg to include path path.
- CMakeLists.txt:
- 11:43 AM Changeset in webkit [95309] by
-
- 8 edits in trunk/Source
[chromium] Fix CCLayerTreeHostTest
https://bugs.webkit.org/show_bug.cgi?id=67418
Source/WebCore:
This is a minimal set of changes to get CCLayerTreeHostTest
compiling, running and passing with USE_THREADED_COMPOSITING
enabled.
Patch by Iain Merrick <husky@google.com> on 2011-09-16
Reviewed by James Robinson.
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
Source/WebKit/chromium:
Fixes needed to compile and link with USE_THREADED_COMPOSITING
enabled, and to pass the basic unit test.
Patch by Iain Merrick <husky@google.com> on 2011-09-16
Reviewed by James Robinson.
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):
- src/GraphicsContext3DPrivate.h:
- tests/CCLayerTreeHostTest.cpp:
(TestHooks::beginCommitOnCCThread):
(TestHooks::commitCompleteOnCCThread):
(TestHooks::drawLayersOnCCThread):
(MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(MockLayerTreeHostImpl::beginCommit):
(MockLayerTreeHostImpl::commitComplete):
(MockLayerTreeHostImpl::drawLayers):
(MockLayerTreeHost::MockLayerTreeHost):
(MockLayerTreeHost::createLayerTreeHostImpl):
(CompositorMockWebGraphicsContext3D::makeContextCurrent):
(CompositorMockWebGraphicsContext3D::createProgram):
(CompositorMockWebGraphicsContext3D::createShader):
(CompositorMockWebGraphicsContext3D::getShaderiv):
(CompositorMockWebGraphicsContext3D::getProgramiv):
(MockLayerTreeHostClient::MockLayerTreeHostClient):
(MockLayerTreeHostClient::animateAndLayout):
(MockLayerTreeHostClient::createCompositorThread):
(MockLayerTreeHostClient::createLayerTreeHostContext3D):
(MockLayerTreeHostClient::createRootLayerPainter):
(MockLayerTreeHostClient::didRecreateGraphicsContext):
(CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(CCLayerTreeHostTest::postSetNeedsRedrawToMainThread):
(CCLayerTreeHostTest::onEndTest):
(CCLayerTreeHostTest::dispatchSetNeedsCommit):
(CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(CCLayerTreeHostTest::runTest):
(CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestShortlived2::beginTest):
(CCLayerTreeHostTestShortlived3::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(CCLayerTreeHostTestSetNeedsCommit1::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::commitCompleteOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit2::commitCompleteOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(CCLayerTreeHostTestSetNeedsRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):
- 11:43 AM Changeset in webkit [95308] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION: Reproducible crash below SlotVisitor::harvestWeakReferences
using Domino's online ordering
https://bugs.webkit.org/show_bug.cgi?id=68220
Reviewed by Oliver Hunt.
Weak handle processing can result in new objects being marked, which
results in new WeakReferencesHarvesters being added. But weak
reference harvesters are only processed before weak handle processing,
so there's the risk that a weak reference harvester will persist
until the next collection, by which time it may have been deleted.
- heap/Heap.cpp:
(JSC::Heap::markRoots):
- 11:32 AM Changeset in webkit [95307] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r95227.
http://trac.webkit.org/changeset/95227
https://bugs.webkit.org/show_bug.cgi?id=68262
Broke a bunch of SVG tests (Requested by andersca on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16
- platform/ScrollView.cpp:
(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformContentsSize):
- platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformContentsSize):
- 11:26 AM Changeset in webkit [95306] by
-
- 4 edits in trunk
2011-09-16 James Simonsen <simonjam@chromium.org>
Fix HTML5 parser's adoption agency algorithm to reparent correctly
https://bugs.webkit.org/show_bug.cgi?id=68147
Reviewed by Eric Seidel.
- html5lib/resources/webkit02.dat:
2011-09-16 James Simonsen <simonjam@chromium.org>
Fix HTML5 parser's adoption agency algorithm to reparent correctly
https://bugs.webkit.org/show_bug.cgi?id=68147
Reviewed by Eric Seidel.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- 11:22 AM Changeset in webkit [95305] by
-
- 2 edits in trunk/Tools/MiniBrowser
Unreviewed commit. Fix Windows and MacOSX compilation after r95303.
- 11:06 AM Changeset in webkit [95304] by
-
- 17 edits in trunk/Source/WebCore
CodeGeneratorGObject should use C++ style comments for ENABLE guards
https://bugs.webkit.org/show_bug.cgi?id=68256
Reviewed by Darin Adler.
This patch should have not behavioral effect. It just cleans up the
GObject code generator to use C++-style comments for ENABLE guards and
to use the usual comment style for license blocks.
- bindings/scripts/CodeGeneratorGObject.pm:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
- 10:31 AM Changeset in webkit [95303] by
-
- 16 edits2 adds in trunk/Source/WebKit2
2011-09-16 Igor Oliveira <igor.oliveira@openbossa.org>
[WK2] mouseDidMoveOverElement needs to send more information about hovered element to UiProcess.
https://bugs.webkit.org/show_bug.cgi?id=68125
This patch implements support for the UiProcess to know what is the link url of a hovered element.
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- GNUmakefile.am:
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- Shared/WebHitTestResult.cpp: Added.
WebHitTestResult has hovered element information.
(WebKit::WebHitTestResult::create):
(WebKit::WebHitTestResult::Data::encode):
(WebKit::WebHitTestResult::Data::decode):
- Shared/WebHitTestResult.h: Added. (WebKit::WebHitTestResult::absoluteImageURL): (WebKit::WebHitTestResult::absoluteLinkURL): (WebKit::WebHitTestResult::absoluteMediaURL): (WebKit::WebHitTestResult::linkLabel): (WebKit::WebHitTestResult::linkTitle): (WebKit::WebHitTestResult::WebHitTestResult): (WebKit::WebHitTestResult::type):
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::mouseDidMoveOverElement):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::mouseDidMoveOverElement):
- UIProcess/WebUIClient.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::mouseDidMoveOverElement):
- win/WebKit2.vcproj:
- 10:28 AM Changeset in webkit [95302] by
-
- 19 edits3 deletes in trunk
[Qt] REGRESSION(r95091) It made many tests flakey
https://bugs.webkit.org/show_bug.cgi?id=68232
Unreviewed rolling out r95091 and followup patches.
Source/WebCore:
- English.lproj/localizedStrings.js:
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::callFunction):
- bindings/v8/V8Proxy.h:
- bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willCallFunction):
- inspector/InspectorTimelineAgent.cpp:
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp:
- inspector/TimelineRecordFactory.h:
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
LayoutTests:
- inspector/timeline/timeline-animation-frame-expected.txt: Removed.
- inspector/timeline/timeline-animation-frame.html: Removed.
- inspector/timeline/timeline-enum-stability-expected.txt:
- inspector/timeline/timeline-test.js:
- platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt: Removed.
- platform/qt/Skipped:
- platform/qt/test_expectations.txt:
- 10:23 AM Changeset in webkit [95301] by
-
- 4 edits2 adds in trunk
cachedFont not getting updated for inline SVG text.
https://bugs.webkit.org/show_bug.cgi?id=68060
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The cached scaledFont needs to be updated on every style set call. It
is not similar to m_style which can get derived from parent's style and
hence will get automatically updated on ancestor's style change. This is
required, otherwise we will maintain stale font list in cached scaledFont
when custom fonts are retired on Document::recalcStyle.
Test: svg/text/text-style-recalc-crash.html
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::styleDidChange):
(WebCore::RenderSVGInlineText::setStyle):
- rendering/svg/RenderSVGInlineText.h:
LayoutTests:
- svg/text/text-style-recalc-crash-expected.txt: Added.
- svg/text/text-style-recalc-crash.html: Added.
- 9:58 AM Changeset in webkit [95300] by
-
- 4 edits in trunk/Source/WebKit2
Add support for attributes on message parameters
Parameter attributes are specified as a space-separated list inside square brackets before
the parameter's type. WebKit2 doesn't use this, but other projects that use these scripts
would like to.
Fixes <http://webkit.org/b/68219> Would like a way to specify attributes on message
parameters
Reviewed by Sam Weinig.
- Scripts/webkit2/messages_unittest.py: Added tests for parameter attributes.
- Scripts/webkit2/model.py:
(Parameter.init): Added a new attributes parameter, which is stored in the self.attributes
property.
(Parameter.has_attribute): Added. Returns true if this parameter has the given attribute.
- Scripts/webkit2/parser.py:
(parse): Moved attributes-parsing code from here...
(parse_attributes_string): ...to here.
(parse_parameters_string): Renamed from parse_parameter_string. Now also parses parameter
attributes.
- 9:58 AM Changeset in webkit [95299] by
-
- 4 edits in trunk/Source/WebKit2
Make WebKit2's message-generation model and parser scripts accessible to other projects
We copy them into the build products directory so other projects can find them.
Fixes <http://webkit.org/b/68169> Would like to be able to use WebKit2's message-generation
scripts in other projects
Reviewed by Darin Adler.
- WebKit2.xcodeproj/project.pbxproj: Copy the scripts to PrivateHeaders.
- win/WebKit2.make: Copy the scripts from obj/WebKit2/scripts to
tools/scripts, like WebCore does.
- win/WebKit2Generated.make: Copy the scripts to obj/WebKit2/scripts, which is similar to what
WebCore does for its bindings scripts.
- 9:57 AM Changeset in webkit [95298] by
-
- 9 edits2 adds in trunk/Source/WebKit2
Split some of the message-generation code into separate modules
This is in preparation for making these modules scripts usable by other projects.
Fixes <http://webkit.org/b/68217> Model and parsing functionality for WebKit2's
message-generation scripts is trapped inside a much larger module
Reviewed by Darin Adler.
- DerivedSources.make:
- DerivedSources.pro:
- GNUmakefile.am:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.vcproj:
Added new files.
- Scripts/webkit2/messages.py: Moved some code from here...
- Scripts/webkit2/model.py: Added.
- Scripts/webkit2/parser.py: Added.
...to here. MessageReceiver.parse was split out into a function in the new parser module.
- Scripts/webkit2/messages_unittest.py: Updated for renames.
- 9:36 AM Changeset in webkit [95297] by
-
- 6 edits in trunk
Source/JavaScriptCore: REGRESSION(r95201): It made two tests fail
https://bugs.webkit.org/show_bug.cgi?id=68230
Unreviewed rolling out r95201.
- jit/JIT.h:
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
- jit/JITInlineMethods.h:
LayoutTests: Unreviewed rolling out r95277.
- platform/qt/Skipped:
- 9:26 AM Changeset in webkit [95296] by
-
- 1 edit5 adds in trunk/LayoutTests
Web Inspector: UI performance tests are required.
https://bugs.webkit.org/show_bug.cgi?id=68234
The idea is to create a set of tests which cover frequently used UI actions
and print the average time of these actions.
There are two pilot tests. The common part was extracted into performance-test helper.
Reviewed by Pavel Feldman.
- inspector/performance/resources/network-append-30-requests.html: Added.
- inspector/performance/resources/performance-test.js: Added.
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.start):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.finish):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._runTest):
- inspector/performance/resources/show-panel-network.html: Added.
- 9:25 AM Changeset in webkit [95295] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r95052): SelectorChecker identifier filter not working
https://bugs.webkit.org/show_bug.cgi?id=68244
Reviewed by Dan Bernstein.
Missing &.
- css/SelectorChecker.cpp:
(WebCore::collectDescendantSelectorIdentifierHashes):
- 9:08 AM Changeset in webkit [95294] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed typo fix after r95271.
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- 8:58 AM Changeset in webkit [95293] by
-
- 2 edits in trunk/Tools
Add Vincent Scheib to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 8:50 AM Changeset in webkit [95292] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip a flakey test.
- platform/qt/Skipped:
- 8:42 AM Changeset in webkit [95291] by
-
- 1 edit6 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Add Qt specific expexted results for new tests introduced in r95239.
- platform/qt/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/qt/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
- platform/qt/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/qt/fast/clip/overflow-border-radius-composited-expected.txt: Added.
- platform/qt/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/qt/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
- 8:24 AM Changeset in webkit [95290] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r95285.
http://trac.webkit.org/changeset/95285
https://bugs.webkit.org/show_bug.cgi?id=68247
It broke a webkitpy test (Requested by ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16
- Scripts/webkitpy/layout_tests/controllers/manager.py:
- 6:30 AM Changeset in webkit [95289] by
-
- 10 edits1 add1 delete in trunk/Source
2011-09-16 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] support extensions for remote inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=67840
Reviewed by Pavel Feldman.
- Merge ExtensionCommon.js into ExtensionAPI.js
- refactor building of extension API for better reuse
- expose interface for extension registration
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ExtensionAPI.js: (defineCommonExtensionSymbols): (buildExtensionAPIInjectedScript):
- inspector/front-end/ExtensionCommon.js:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._addExtension): (WebInspector.ExtensionServer.prototype._buildExtensionAPIScript): (WebInspector.ExtensionServer.prototype._onWindowMessage): (WebInspector.ExtensionServer.prototype._registerExtension): (WebInspector.ExtensionServer.prototype._expandResourcePath):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
2011-09-16 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] support extensions for remote inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=67840
Reviewed by Pavel Feldman.
- expose extension API as a single, standalone file for easy reuse in remote extension scripts.
- WebKit.gyp:
- scripts/generate_devtools_extension_api.py: Added.
- scripts/generate_devtools_zip.py:
- 6:19 AM Changeset in webkit [95288] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fix for r95287.
- inspector/debugger/debugger-expand-scope.html:
- 5:55 AM Changeset in webkit [95287] by
-
- 15 edits in trunk
Web Inspector: change WebInspector.currentPanel getter/setter to functions.
https://bugs.webkit.org/show_bug.cgi?id=68242
This is necessary for the panel switching performance tests.
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
(WebInspector.Drawer.prototype._animateDrawerHeight):
(WebInspector.Drawer.prototype._statusBarDragging):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showAnchorLocation):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.updateSearchMatchesCount):
(WebInspector.SearchController.prototype.updateCurrentMatchIndex):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._performSearch):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked):
(WebInspector.Toolbar.createPanelToolbarItem):
- inspector/front-end/inspector.js:
(WebInspector.currentPanel):
(WebInspector._updateFocusedNode):
(WebInspector.windowResize):
(WebInspector.documentKeyDown):
(WebInspector.documentCanCopy):
(WebInspector.documentCopy):
(WebInspector.showPanel):
(WebInspector.startUserInitiatedDebugging):
(WebInspector.inspect):
(WebInspector._showAnchorLocationInPanel):
(WebInspector._toolbarItemClicked):
(WebInspector.PanelHistory.prototype.goBack):
(WebInspector.PanelHistory.prototype.goForward):
Source/WebKit/chromium:
- src/js/Tests.js:
(.TestSuite.prototype.showPanel):
LayoutTests:
- http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
- inspector/debugger/debugger-expand-scope.html:
- inspector/debugger/debugger-proto-property.html:
- inspector/storage-panel-dom-storage.html:
- 5:42 AM Changeset in webkit [95286] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] bot lucks mobility
https://bugs.webkit.org/show_bug.cgi?id=68243
Unreviwed test skipping.
- platform/qt-wk2/Skipped:
- 5:04 AM Changeset in webkit [95285] by
-
- 2 edits in trunk/Tools
Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812
Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-16
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
- 5:00 AM Changeset in webkit [95284] by
-
- 1 edit in trunk/Source/WebCore/rendering/LayoutState.cpp
Unreviewed. Fix release compilation after r95264
- 4:43 AM Changeset in webkit [95283] by
-
- 6 edits in trunk
[GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
https://bugs.webkit.org/show_bug.cgi?id=68178
Patch by Martin Robinson <mrobinson@igalia.com> on 2011-09-16
Reviewed by Xan Lopez.
.:
- configure.ac: Do not build WebKit2 by default. Re-add pkgconfig support
for WebKit2.
Source/WebKit2:
- GNUmakefile.am: Do not build WebKit2 by default. Re-add pkgconfig support
for WebKit2.
Tools:
Add a work-around to enable WebKit2 when using build-webkit.
- Scripts/webkitdirs.pm:
(buildAutotoolsProject):
- 2:29 AM Changeset in webkit [95282] by
-
- 9 edits in trunk
Web Inspector: rename Console.clearConsoleMessages to Console.clearMessages, brush up console domain doc.
https://bugs.webkit.org/show_bug.cgi?id=68165
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::clearConsoleMessages):
- inspector/Inspector.json:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::clearMessages):
- inspector/InspectorConsoleAgent.h:
- inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleModel.prototype.requestClearMessages):
LayoutTests:
- inspector/protocol/console-agent-expected.txt:
- inspector/protocol/console-agent.html:
- 2:13 AM Changeset in webkit [95281] by
-
- 3 edits1 add in trunk/LayoutTests
[chromium] Rebaselines due to r95203 and r95207.
- platform/chromium-cg-mac-leopard/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/chromium/test_expectations.txt:
- 1:39 AM Changeset in webkit [95280] by
-
- 2 edits in trunk/Source/WebCore
2011-09-16 Alejandro G. Castro <alex@igalia.com>
Fix build after r95245.
- GNUmakefile.list.am:
- 1:35 AM Changeset in webkit [95279] by
-
- 5 edits in trunk/LayoutTests
[Qt] Update expecteds of failing tests after r95260 and r95242.
Unreviewed gardening.
- 1:26 AM Changeset in webkit [95278] by
-
- 2 edits in trunk/LayoutTests
[Qt] One test failed after r95203
https://bugs.webkit.org/show_bug.cgi?id=68233
Unreviewed gardening.
- platform/qt/Skipped: failed test is skipped.
- 1:21 AM Changeset in webkit [95277] by
-
- 2 edits in trunk/LayoutTests
[Qt] One test runs out of time after r95091
https://bugs.webkit.org/show_bug.cgi?id=68232
Unreviewed gardening.
- platform/qt/Skipped:
- 1:16 AM Changeset in webkit [95276] by
-
- 2 edits in trunk/LayoutTests
[Qt] Two tests fail after r95201
https://bugs.webkit.org/show_bug.cgi?id=68230
Unreviewed gardening.
- platform/qt/Skipped:
- 12:15 AM Changeset in webkit [95275] by
-
- 3 edits2 adds in trunk
[Qt] Crash when dragging google maps.
https://bugs.webkit.org/show_bug.cgi?id=68223
Source/WebCore:
The custom image for a cursor might not be ready when WebKit trying
to use it to construct the cursor in Qt porting. This patch is using
arrow image to substitute the unready custom image.
Reviewed by Adam Barth.
Test: fast/css/crash-on-custom-cursor-when-loading.html
- platform/qt/CursorQt.cpp:
(WebCore::createCustomCursor):
(WebCore::Cursor::ensurePlatformCursor):
LayoutTests:
Test case to use an unready custom cursor.
Reviewed by Adam Barth.
- fast/css/crash-on-custom-cursor-when-loading-expected.txt: Added.
- fast/css/crash-on-custom-cursor-when-loading.html: Added.
Sep 15, 2011:
- 11:52 PM Changeset in webkit [95274] by
-
- 2 edits in trunk/LayoutTests
[chromium] Add slow to calculate-percentage.html
- platform/chromium/test_expectations.txt:
- 11:33 PM Changeset in webkit [95273] by
-
- 20 edits in trunk/Source/JavaScriptCore
DFG JIT does not optimize method_check
https://bugs.webkit.org/show_bug.cgi?id=68215
Reviewed by Oliver Hunt.
MethodCallLinkInfo and StructureStubInfo are now searchable by
bytecodeIndex, so that DFG::ByteCodeParser can use that information
to determine how to optimize GetMethod.
A new node op has been added to DFG: CheckMethod. This is a variant
of GetMethod that has been optimized for the case that GetMethod
always takes the fast path. CheckMethod results in only a very
small amount of code (two loads and two branches in the worst case,
one load and one branch in the best case). CheckMethod behaves as
if it were a constant.
Introduced the notion that a DFG node that is not JSConstant
behaves as a constant. CheckMethod uses this functionality.
This is a 3% speed-up on Kraken, and a small speed-up on V8.
Appears to be neutral on SunSpider.
- bytecode/CodeBlock.h:
(JSC::getStructureStubInfoBytecodeIndex):
(JSC::getMethodCallLinkInfoBytecodeIndex):
- bytecode/PredictedType.cpp:
(JSC::predictionFromCell):
(JSC::predictionFromValue):
- bytecode/PredictedType.h:
- bytecode/StructureStubInfo.h:
- dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::recordGetMethod):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::getMethodCheckPrediction):
(JSC::DFG::Graph::getPrediction):
(JSC::DFG::Graph::isConstant):
(JSC::DFG::Graph::isJSConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
(JSC::DFG::Graph::valueOfJSConstantNode):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasConstant):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasMethodCheckData):
(JSC::DFG::Node::methodCheckDataIndex):
(JSC::DFG::Node::valueOfJSConstant):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
(JSC::MethodCallCompilationInfo::MethodCallCompilationInfo):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
- runtime/JSCell.h:
(JSC::JSCell::JSCell::structureAddress):
- 10:43 PM Changeset in webkit [95272] by
-
- 2 edits in trunk/Source/WebKit/chromium
Sigh. Missed this one.
- features.gypi:
- 10:41 PM Changeset in webkit [95271] by
-
- 199 edits in trunk
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
https://bugs.webkit.org/show_bug.cgi?id=68205
Reviewed by Eric Seidel.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- wtf/Platform.h:
Source/WebCore:
As discussed on webkit-dev.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- GNUmakefile.list.am:
- UseJSC.cmake:
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
- bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
- bindings/js/JSExceptionBase.cpp:
(WebCore::toExceptionBase):
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::databaseId):
- bindings/js/JSSQLResultSetRowListCustom.cpp:
- bindings/js/JSSQLTransactionCustom.cpp:
- bindings/js/JSSQLTransactionSyncCustom.cpp:
- bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
- bindings/scripts/test/CPP/WebDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/JS/JSTestCallback.cpp:
- bindings/scripts/test/JS/JSTestCallback.h:
- bindings/scripts/test/ObjC/DOMTestCallback.mm:
- bindings/scripts/test/TestCallback.idl:
- bindings/scripts/test/V8/V8TestCallback.cpp:
- bindings/scripts/test/V8/V8TestCallback.h:
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
- bindings/v8/V8Proxy.h:
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::databaseIdCallback):
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
- dom/Document.cpp:
- dom/Document.h:
- dom/ExceptionCode.cpp:
(WebCore::getExceptionCodeDescription):
- dom/ExceptionCode.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
- dom/ScriptExecutionContext.h:
- features.pri:
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
- inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
- inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::init):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::restoreInspectorStateFromCookie):
- inspector/InspectorController.h:
- inspector/InspectorDatabaseAgent.cpp:
- inspector/InspectorDatabaseInstrumentation.h:
- inspector/InspectorDatabaseResource.cpp:
- inspector/InspectorDatabaseResource.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
- inspector/InspectorInstrumentation.h:
- inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::InstrumentingAgents):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
- page/ChromeClient.h:
- page/DOMWindow.cpp:
- page/DOMWindow.h:
- page/DOMWindow.idl:
- platform/sql/SQLiteAuthorizer.cpp:
- platform/sql/SQLiteDatabase.cpp:
- platform/sql/SQLiteFileSystem.cpp:
- platform/sql/SQLiteStatement.cpp:
- platform/sql/SQLiteTransaction.cpp:
- storage/AbstractDatabase.cpp:
- storage/AbstractDatabase.h:
- storage/ChangeVersionWrapper.cpp:
- storage/ChangeVersionWrapper.h:
- storage/Database.cpp:
- storage/Database.h:
- storage/Database.idl:
- storage/DatabaseAuthorizer.cpp:
- storage/DatabaseCallback.h:
- storage/DatabaseCallback.idl:
- storage/DatabaseDetails.h:
- storage/DatabaseSync.cpp:
- storage/DatabaseSync.h:
- storage/DatabaseSync.idl:
- storage/DatabaseTask.cpp:
- storage/DatabaseTask.h:
- storage/DatabaseThread.cpp:
- storage/DatabaseThread.h:
- storage/DatabaseTracker.cpp:
- storage/DatabaseTracker.h:
- storage/DatabaseTrackerClient.h:
- storage/OriginQuotaManager.cpp:
- storage/OriginQuotaManager.h:
- storage/OriginUsageRecord.cpp:
- storage/OriginUsageRecord.h:
- storage/SQLCallbackWrapper.h:
- storage/SQLError.h:
- storage/SQLError.idl:
- storage/SQLException.h:
- storage/SQLException.idl:
- storage/SQLResultSet.cpp:
- storage/SQLResultSet.h:
- storage/SQLResultSet.idl:
- storage/SQLResultSetRowList.cpp:
- storage/SQLResultSetRowList.h:
- storage/SQLResultSetRowList.idl:
- storage/SQLStatement.cpp:
- storage/SQLStatement.h:
- storage/SQLStatementCallback.h:
- storage/SQLStatementCallback.idl:
- storage/SQLStatementErrorCallback.h:
- storage/SQLStatementErrorCallback.idl:
- storage/SQLStatementSync.cpp:
- storage/SQLStatementSync.h:
- storage/SQLTransaction.cpp:
- storage/SQLTransaction.h:
- storage/SQLTransaction.idl:
- storage/SQLTransactionCallback.h:
- storage/SQLTransactionCallback.idl:
- storage/SQLTransactionClient.cpp:
- storage/SQLTransactionClient.h:
- storage/SQLTransactionCoordinator.cpp:
- storage/SQLTransactionCoordinator.h:
- storage/SQLTransactionErrorCallback.h:
- storage/SQLTransactionErrorCallback.idl:
- storage/SQLTransactionSync.cpp:
- storage/SQLTransactionSync.h:
- storage/SQLTransactionSync.idl:
- storage/SQLTransactionSyncCallback.h:
- storage/SQLTransactionSyncCallback.idl:
- storage/chromium/DatabaseObserver.h:
- storage/chromium/DatabaseTrackerChromium.cpp:
- storage/chromium/QuotaTracker.cpp:
- storage/chromium/QuotaTracker.h:
- storage/chromium/SQLTransactionClientChromium.cpp:
- workers/WorkerContext.cpp:
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
Source/WebKit/chromium:
- src/DatabaseObserver.cpp:
- src/WebDatabase.cpp:
(WebKit::WebDatabase::updateDatabaseSize):
(WebKit::WebDatabase::updateSpaceAvailable):
(WebKit::WebDatabase::resetSpaceAvailable):
(WebKit::WebDatabase::closeDatabaseImmediately):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableDatabase):
(WebKit::WebRuntimeFeatures::isDatabaseEnabled):
Source/WebKit/efl:
- WebCoreSupport/ChromeClientEfl.cpp:
- WebCoreSupport/ChromeClientEfl.h:
- ewk/ewk_settings.cpp:
(ewk_settings_web_database_default_quota_get):
(ewk_settings_web_database_path_set):
(ewk_settings_web_database_path_get):
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ChromeClientGtk.h:
- webkit/webkitsecurityorigin.cpp:
(webkit_security_origin_get_web_database_usage):
(webkit_security_origin_get_web_database_quota):
(webkit_security_origin_set_web_database_quota):
(webkit_security_origin_get_all_web_databases):
- webkit/webkitwebdatabase.cpp:
(webkit_web_database_get_display_name):
(webkit_web_database_get_expected_size):
(webkit_web_database_get_size):
(webkit_web_database_get_filename):
(webkit_web_database_remove):
(webkit_remove_all_web_databases):
(webkit_get_web_database_directory_path):
(webkit_set_web_database_directory_path):
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
Source/WebKit/haiku:
- WebCoreSupport/ChromeClientHaiku.h:
Source/WebKit/mac:
- Storage/WebDatabaseManager.mm:
- Storage/WebDatabaseManagerInternal.h:
- Storage/WebDatabaseManagerPrivate.h:
- Storage/WebDatabaseQuotaManager.mm:
(-[WebDatabaseQuotaManager usage]):
(-[WebDatabaseQuotaManager quota]):
(-[WebDatabaseQuotaManager setQuota:]):
- Storage/WebDatabaseTrackerClient.h:
- Storage/WebDatabaseTrackerClient.mm:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
- WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin usage]):
(-[WebSecurityOrigin quota]):
(-[WebSecurityOrigin setQuota:]):
- WebView/WebFrame.mm:
(-[WebFrame _cacheabilityDictionary]):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _preferencesChanged:]):
Source/WebKit/qt:
- Api/qwebdatabase.cpp:
(QWebDatabase::displayName):
(QWebDatabase::expectedSize):
(QWebDatabase::size):
(QWebDatabase::fileName):
(QWebDatabase::removeDatabase):
(QWebDatabase::removeAllDatabases):
- Api/qwebsecurityorigin.cpp:
(QWebSecurityOrigin::databaseUsage):
(QWebSecurityOrigin::databaseQuota):
(QWebSecurityOrigin::setDatabaseQuota):
(QWebSecurityOrigin::allOrigins):
(QWebSecurityOrigin::databases):
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::setOfflineStoragePath):
(QWebSettings::offlineStoragePath):
- WebCoreSupport/ChromeClientQt.cpp:
- WebCoreSupport/ChromeClientQt.h:
Source/WebKit/win:
- ForEachCoClass.h:
- WebCoreSupport/WebChromeClient.cpp:
- WebCoreSupport/WebChromeClient.h:
- WebDatabaseManager.cpp:
- WebDatabaseManager.h:
- WebSecurityOrigin.cpp:
(WebSecurityOrigin::usage):
(WebSecurityOrigin::quota):
(WebSecurityOrigin::setQuota):
- WebView.cpp:
(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):
Source/WebKit/wince:
- WebCoreSupport/ChromeClientWinCE.cpp:
- WebCoreSupport/ChromeClientWinCE.h:
Source/WebKit/wx:
- WebKitSupport/ChromeClientWx.cpp:
- WebKitSupport/ChromeClientWx.h:
- WebView.cpp:
(wxWebView::Create):
(wxWebView::SetDatabaseDirectory):
(wxWebView::GetDatabaseDirectory):
(wxWebView::SetDatabasesEnabled):
(wxWebView::AreDatabasesEnabled):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 9:07 PM Changeset in webkit [95270] by
-
- 2 edits in trunk/LayoutTests
[chromium] add timeout to test expectation of styles-source-lines.html
- platform/chromium/test_expectations.txt:
- 9:01 PM Changeset in webkit [95269] by
-
- 2 edits in trunk/LayoutTests
[chromium] add timeout to test expectation of styles-new-API.html
- platform/chromium/test_expectations.txt:
- 8:59 PM Changeset in webkit [95268] by
-
- 3 edits in trunk/LayoutTests
[chromium] rebaseline expectations due to r95264
- platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- 8:52 PM Changeset in webkit [95267] by
-
- 2 edits in trunk/LayoutTests
[chromium] added fail expectation for back-with-fragment-change.php
- platform/chromium/test_expectations.txt:
- 8:48 PM Changeset in webkit [95266] by
-
- 2 edits in trunk/LayoutTests
[chromium] adding text_expectation for zoom-svg-through-object-with-percentage-size.xhtml
- platform/chromium/test_expectations.txt:
- 8:44 PM Changeset in webkit [95265] by
-
- 2 edits in trunk/LayoutTests
[chromium] adding fail to test_expectations due to r95188
- platform/chromium/test_expectations.txt:
- 7:56 PM Changeset in webkit [95264] by
-
- 17 edits10 adds in trunk
[CSSRegions] Regions should not slice line box rendering
https://bugs.webkit.org/show_bug.cgi?id=66198
Source/WebCore:
Created a new LayoutState constructor for the RenderFlowThread. It will
set m_isPaginated to true and force a pageHeight if 1. The actual pageHeight is
not used, because pageLogicalHeightForOffset will actually redirect the call
to RenderFlowThread.
Removed some of the duplicate code that calculated the page logical offset.
Added new methods like logicalPageOffset, pageLogicalHeightForOffset,
pageRemainingLogicalHeightForOffset.
There are still some issues related to incremental layout and different region widths.
Those issues will be addressed in different patches.
Reviewed by David Hyatt.
Tests: fast/regions/text-region-breaks.html
fast/regions/text-region-split-horizontal-bt.html
fast/regions/text-region-split-vertical-rl.html
fast/regions/text-region-split-vertical.html
fast/regions/text-region-split.html
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
- rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::isPaginated):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
(WebCore::RenderBlock::nextPageLogicalTopExcludingBoundaryPoint):
(WebCore::RenderBlock::nextPageLogicalTopIncludingBoundaryPoint):
(WebCore::inNormalFlow):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::logicalPageOffset):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
- rendering/RenderBlock.h:
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::regionLogicalHeightForLine):
(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
- rendering/RenderFlowThread.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::pushLayoutState):
- rendering/RenderView.h:
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
LayoutTests:
Also updated the results for some older tests that now work correctly.
Reviewed by David Hyatt.
- fast/regions/resources/helper.js:
(isDebugEnabled):
(assertEqualRects):
(testBoundingRects):
(assertRectContains):
(addPageLevelDebugBox):
(testContentToRegionsMapping):
- fast/regions/text-region-breaks-expected.txt: Added.
- fast/regions/text-region-breaks.html: Added.
- fast/regions/text-region-split-expected.txt: Added.
- fast/regions/text-region-split-horizontal-bt-expected.txt: Added.
- fast/regions/text-region-split-horizontal-bt.html: Added.
- fast/regions/text-region-split-vertical-expected.txt: Added.
- fast/regions/text-region-split-vertical-rl-expected.txt: Added.
- fast/regions/text-region-split-vertical-rl.html: Added.
- fast/regions/text-region-split-vertical.html: Added.
- fast/regions/text-region-split.html: Added.
- fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
- fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
- fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
- fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
- fast/repaint/japanese-rl-selection-repaint-in-regions.html:
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
- 7:53 PM Changeset in webkit [95263] by
-
- 4 edits in trunk/LayoutTests
[chromium] rebaseline expectations due to r95239
- platform/chromium-cg-mac-leopard/fast/forms/menulist-option-wrap-expected.png:
- platform/chromium-cg-mac/fast/forms/menulist-option-wrap-expected.png:
- platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:
- 7:45 PM Changeset in webkit [95262] by
-
- 8 edits2 adds in trunk
Implement a PopStateEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67977
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/events/constructors/pop-state-event-constructor.html
- bindings/generic/EventConstructors.h: Added a definition for the PopStateEvent constructor.
- bindings/js/JSEventConstructors.cpp: Added #includes for PopStateEvent.
- dom/PopStateEvent.cpp:
(WebCore::PopStateEventInit::PopStateEventInit):
(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):
- dom/PopStateEvent.h: Added a definition for PopStateEventInit.
- dom/PopStateEvent.idl: Makes PopStateEvent constructible.
LayoutTests:
pop-state-event-constructor.html checks the behavior of the PopStateEvent constructor.
- fast/events/constructors/pop-state-event-constructor-expected.txt: Added.
- fast/events/constructors/pop-state-event-constructor.html: Added.
- platform/chromium/test_expectations.txt: Skipped pop-state-event-constructor.html, since V8 does not yet have the PopStateEvent constructor.
- 7:43 PM Changeset in webkit [95261] by
-
- 2 edits in trunk/LayoutTests
[chromium] remove duplicate entries in test_expectations.txt
- platform/chromium/test_expectations.txt:
- 7:16 PM Changeset in webkit [95260] by
-
- 1 edit in branches/chromium/835/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
[chromium] Fix updateCompositorResources crash.
Reviewed by Nat Duca.
Landing directly on the branch, due to code divergence.
See: http://codereview.chromium.org/7866017/
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers)
(WebCore::LayerRendererChromium::updateCompositorResources)
(WebCore::LayerRendererChromium::drawLayer)
- 7:16 PM Changeset in webkit [95259] by
-
- 6 edits5 adds in trunk
Fragment navigations should interrupt a provisional load of a different document
https://bugs.webkit.org/show_bug.cgi?id=64556
Source/WebCore:
Reviewed by Adam Barth.
Tests: http/tests/history/back-with-fragment-change.php
http/tests/navigation/navigation-interrupted-by-fragment.html
- loader/FrameLoader.cpp: Stop provisional load if a fragment commits.
- loader/HistoryController.cpp: Don't commit the wrong provisional item.
LayoutTests:
Reviewed by Adam Barth.
Required page-dismissal-modal-dialogs-iframe.html to be updated since
the dummy <a href="#"> link was clicked after the provisional load was
kicked off, thus causing it to to be aborted.
- fast/loader/page-dismissal-modal-dialogs.html:
- fast/loader/resources/page-dismissal-modal-dialogs-iframe.html:
- http/tests/history/back-with-fragment-change-expected.txt: Added.
- http/tests/history/back-with-fragment-change.php: Added.
- http/tests/history/resources/back-with-fragment-change-target.html: Added.
- http/tests/navigation/navigation-interrupted-by-fragment-expected.txt: Added.
- http/tests/navigation/navigation-interrupted-by-fragment.html: Added.
- 7:14 PM Changeset in webkit [95258] by
-
- 2 edits in trunk/Tools
Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
- Scripts/webkitpy/common/config/committers.py:
- 7:03 PM Changeset in webkit [95257] by
-
- 4 edits in trunk/Tools
UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
https://bugs.webkit.org/show_bug.cgi?id=68003
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-15
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
- 6:54 PM Changeset in webkit [95256] by
-
- 4 edits in trunk/Source
[chromium] Add temporary diagnostics for LayerTreeHost::commitTo crash
https://bugs.webkit.org/show_bug.cgi?id=68204
Reviewed by James Robinson.
Add CRASH calls to determine which assumptions are being violated.
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::commitTo):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
- 6:32 PM Changeset in webkit [95255] by
-
- 2 edits in trunk/Source/WebKit/chromium
Remove TestWebKitAPI from the chromium build until it is made to work
with the shared component build.
- WebKit.gyp:
- 6:32 PM Changeset in webkit [95254] by
-
- 5 edits in trunk/Source
Versioning.
- 6:30 PM Changeset in webkit [95253] by
-
- 1 copy in tags/Safari-535.3
New tag.
- 6:25 PM Changeset in webkit [95252] by
-
- 4 edits in trunk
Add method to scroll current node to specific position in Chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=68192
Patch by Varun Jain <varunjain@google.com> on 2011-09-15
Reviewed by Dimitri Glazkov.
- Source/WebKit/chromium/public/WebView.h:
- Source/WebKit/chromium/src/WebViewImpl.cpp:
- Source/WebKit/chromium/src/WebViewImpl.h:
- 6:24 PM Changeset in webkit [95251] by
-
- 2 edits in trunk/LayoutTests
[chromium] skipping tests due to r95188
- platform/chromium/test_expectations.txt:
- 6:19 PM Changeset in webkit [95250] by
-
- 23 edits in trunk/Source
Unzip initialization lists and constructors in JSCell hierarchy (7/7)
https://bugs.webkit.org/show_bug.cgi?id=68122
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Completed the seventh and final level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
JSCallbackObject was missed in previous patches due to the fact that
it's non-obvious (at least to my script) that it is in the JSCell hierarchy, so
this is just a bit of retroactive cleanup.
- API/JSCallbackObject.h:
(JSC::JSCallbackObject::create):
- API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
Source/WebCore:
No new tests.
Completed the seventh and final level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
This consists of moving the finishCreation() method call into the create methods
of the sixth level of the hierarchy as was done in previous patches.
The special cases for JSAudioConstructor, JSOptionConstructor, and JSImageConstructor
were also lumped in and given finishCreation() methods that are called in their
create methods because we are at the end and want to avoid a trivial patch just
for moving their finishCreation() methods from their constructor to their create method.
- bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
(WebCore::JSAudioConstructor::finishCreation):
- bindings/js/JSAudioConstructor.h:
(WebCore::JSAudioConstructor::create):
- bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
- bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
(WebCore::JSImageConstructor::finishCreation):
- bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::create):
- bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::JSOptionConstructor):
(WebCore::JSOptionConstructor::finishCreation):
- bindings/js/JSOptionConstructor.h:
(WebCore::JSOptionConstructor::create):
- bindings/js/JSWorkerContextBase.cpp:
(WebCore::JSWorkerContextBase::JSWorkerContextBase):
The bindings generation script was also changed to move the finishCreation() call into the
create methods for descendants of JSWorkerContextBase and JSDOMWindowBase because those base
classes had it removed from their constructors.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
- bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaRuntimeMethod::create):
(JavaRuntimeMethod::JavaRuntimeMethod):
- bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::ObjCRuntimeMethod):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
- bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMetaMethod::create):
(JSC::Bindings::QtRuntimeConnectionMethod::create):
Source/WebKit/mac:
Completed the seventh and final level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
- Plugins/Hosted/ProxyRuntimeObject.h:
(WebKit::ProxyRuntimeObject::create):
- Plugins/Hosted/ProxyRuntimeObject.mm:
(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
- 6:17 PM Changeset in webkit [95249] by
-
- 18 edits2 adds in trunk
A single line must not be split into two pages.
https://bugs.webkit.org/show_bug.cgi?id=65005
Reviewed by David Hyatt.
When the document width of a page is overflowed, the last line of the page can be
split into the next page. This is the regression caused by r88737. r88737 tried to
fix rounding errors in rendering calculations by expanding and shrinking a page
using one common method, resizePageRectsKeepingRatio(), but overlooked the case where
a document width gets overflowed.
Source/WebCore:
This patch fixes the problem by also using resizePageRectsKeepingRatio() for the case
where the document width gets overflowed.
Test: printing/single-line-must-not-be-split-into-two-pages.html
- WebCore.exp.in: Updated the signature of forceLayoutForPagination().
- page/Frame.cpp:
(WebCore::Frame::setPrinting): Added a new argument |originalPageSize|, which is an original page size before being expanded or shrunk.
- page/Frame.h:
- page/FrameView.cpp:
(WebCore::FrameView::forceLayoutForPagination): Uses resizePageRectsKeepingRatio() in the case where the document width gets overflowed.
- page/FrameView.h:
- page/PrintContext.cpp:
(WebCore::PrintContext::begin): Passes an original page size to setPrinting().
(WebCore::PrintContext::end): Ditto.
Source/WebKit/mac:
Test: printing/single-line-must-not-be-split-into-two-pages.html
- WebView/WebHTMLView.mm:
(-[WebHTMLView _web_setPrintingModeRecursive]): Passes an original page size to setPrinting().
(-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Ditto.
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Ditto.
(-[WebHTMLView _endPrintMode]): Ditto.
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): Ditto.
(-[WebHTMLView _endScreenPaginationMode]): Ditto.
(-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]): Ditto.
(-[WebHTMLView layout]): Ditto.
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): Ditto.
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
(-[WebHTMLView setPageWidthForPrinting:]): Ditto.
Source/WebKit/win:
Test: printing/single-line-must-not-be-split-into-two-pages.html
- WebFrame.cpp:
(WebFrame::setPrinting): Passes an original page size to setPrinting().
(WebFrame::setInPrintingMode): Ditto.
- WebFrame.h:
LayoutTests:
The added test checks if the last line does not split across pages.
- platform/chromium/test_expectations.txt: Skipped the added test since setPrinting() is not yet implemented.
- platform/gtk/Skipped: Ditto.
- platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
- platform/qt/Skipped: Ditto.
- platform/win/Skipped: Ditto.
- platform/wk2/Skipped: Ditto.
- printing/single-line-must-not-be-split-into-two-pages.html: Added.
- 6:10 PM Changeset in webkit [95248] by
-
- 4 edits1 delete in trunk/Source/WebCore
Unreviewed, rolling out r95243 and r95246.
http://trac.webkit.org/changeset/95243
http://trac.webkit.org/changeset/95246
https://bugs.webkit.org/show_bug.cgi?id=68202
Broke the Windows build (Requested by smfr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-15
- WebCore.vcproj/WebCore.vcproj:
- platform/graphics/ca/win/LayerChangesFlusher.cpp:
(WebCore::LayerChangesFlusher::hookCallback):
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(PlatformCAAnimation::copy):
- platform/win/StructuredExceptionHandlerSupressor.h: Removed.
- 5:39 PM Changeset in webkit [95247] by
-
- 2 edits in trunk/Tools
Python version check is confusing in test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=68004
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-15
Reviewed by Adam Barth.
- Scripts/test-webkitpy:
- 5:33 PM Changeset in webkit [95246] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix Windows build after r95243.
- WebCore.vcproj/WebCore.vcproj:
- 5:18 PM Changeset in webkit [95245] by
-
- 9 edits2 adds in trunk/Source/WebCore
Make custom scrollbar theme for use in DRT, to reduce pixel differences between platforms
https://bugs.webkit.org/show_bug.cgi?id=68134
Reviewed by James Robinson.
Add new scrollbar theme, called ScrollbarThemeMock, for use in layout
tests. The mock scrollbar simply draws a light gray box in the track,
with a dark gray box for the thumb.
Add ScrollbarThemeMock files to the build on all platforms. It isn't hooked up yet.
- CMakeLists.txt:
- CMakeListsEfl.txt:
- CMakeListsWinCE.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarTheme::nativeTheme):
- platform/mock/ScrollbarThemeMock.cpp: Added.
(WebCore::ScrollbarThemeMock::trackRect):
(WebCore::ScrollbarThemeMock::scrollbarThickness):
(WebCore::ScrollbarThemeMock::paintTrackBackground):
(WebCore::ScrollbarThemeMock::paintThumb):
- platform/mock/ScrollbarThemeMock.h: Added.
(WebCore::ScrollbarThemeMock::hasButtons):
(WebCore::ScrollbarThemeMock::hasThumb):
(WebCore::ScrollbarThemeMock::backButtonRect):
(WebCore::ScrollbarThemeMock::forwardButtonRect):
- 5:17 PM Changeset in webkit [95244] by
-
- 6 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=67884
Delete button icon does not properly update when the device resolution changes
dynamically
-and corresponding-
<rdar://problem/10104632>
Reviewed by Darin Adler.
In DeleteButtonController::deviceScaleFactorChanged(), if the delete button is
currently showing, hide it and re-show it, forcing it to re-create the deletion
UI.
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::deviceScaleFactorChanged):
- editing/DeleteButtonController.h:
- editing/Editor.cpp:
(WebCore::Editor::deviceScaleFactorChanged):
- editing/Editor.h:
Iterate through all of the frames and propagate the deviceScaleFactorChange()
message to Editor.
- page/Page.cpp:
(WebCore::Page::setDeviceScaleFactor):
- 4:50 PM Changeset in webkit [95243] by
-
- 4 edits1 add in trunk/Source/WebCore
2011-09-15 Chris Marrin <cmarrin@apple.com>
Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction
https://bugs.webkit.org/show_bug.cgi?id=67510
Reviewed by Adam Roben.
Another fix to take care of one last crash when running pause-crash.html.
CACF can't deal with null valueFunctions, so avoid setting it when it doesn't
exist.
This also adds logic to the Windows Hook in LayerChangesFlusher to prevent it
from catching the null pointer exception generated by the pause-crash.html test
before this bug was fixed. Windows was ignoring the exception, so the testcase
would appear to succeed, even though it should have crashed.
- WebCore.vcproj/WebCore.vcproj:
- platform/graphics/ca/win/LayerChangesFlusher.cpp: (WebCore::LayerChangesFlusher::hookCallback):
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (PlatformCAAnimation::copy):
- platform\win\StructuredExceptionHandlerSupressor.h: New file to encapsulate the exception handling supression.
- 4:45 PM Changeset in webkit [95242] by
-
- 4 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=27579
Make sure that the border shorthand also resets border-image.
Reviewed by Beth Dakin.
Source/WebCore:
Added fast/borders/border-image-reset-by-border-shorthand.html.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
LayoutTests:
- fast/borders/border-image-reset-by-border-shorthand-expected.txt: Added.
- fast/borders/border-image-reset-by-border-shorthand.html: Added.
- fast/borders/border-image-scaled-gradient.html:
- 4:35 PM Changeset in webkit [95241] by
-
- 2 edits6 adds in trunk/LayoutTests
[chromium] Rebaselines due to r95203 and r95207.
Also misc test_expectations additions.
- platform/chromium-cg-mac/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
- platform/chromium-linux/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
- platform/chromium-mac/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
- platform/chromium-win/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
- platform/chromium/fast/dom/NodeList/nodelist-item-call-as-function-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:24 PM Changeset in webkit [95240] by
-
- 25 edits2 deletes in trunk/Source/JavaScriptCore
The DFG non-speculative JIT is no longer used and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=68177
Reviewed by Geoffrey Garen.
This removes the non-speculative JIT and everything that relied on it,
including the ability to turn on DFG but not tiered compilation the,
ability to perform speculation failure into non-speculative JIT code,
and the ability to statically terminate speculation.
- GNUmakefile.list.am:
- JavaScriptCore.pro:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoopHint):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getStrongPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGenerationInfo.h:
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
- dfg/DFGJITCodeGenerator.cpp:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):
- dfg/DFGJITCompiler.h:
- dfg/DFGNode.h:
- dfg/DFGNonSpeculativeJIT.cpp: Removed.
- dfg/DFGNonSpeculativeJIT.h: Removed.
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGPropagator.cpp:
- dfg/DFGPropagator.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::osrExits):
(JSC::DFG::SpeculativeJIT::speculationRecovery):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITCode.h:
(JSC::JITCode::bottomTierJIT):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
- runtime/JSGlobalData.h:
- wtf/Platform.h:
- 3:53 PM Changeset in webkit [95239] by
-
- 8 edits9 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=50072
Make overflow clipping to border-radius work across layers. This patch makes painting
work but does not attempt to fix hit testing. It also doesn't work when a composited
layer is clipped by a non-composited ancestor.
Add a new ClipRect class (used by ClipRects and RenderLayer) that is basically just tracking
a rect and a border radius taint. At the time we set a clip, if the rectangle is listed
as also being clipped by a radius, then we walk up the layer tree and push those inner border
rounded rect clips for any overflow areas in the containing block chain.
Reviewed by Beth Dakin.
Source/WebCore:
Added new tests in fast/clip.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::pushContentsClip):
- rendering/RenderLayer.cpp:
(WebCore::inContainingBlockChain):
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::restoreClip):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::backgroundClipRect):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::childrenClipRect):
(WebCore::RenderLayer::selfClipRect):
- rendering/RenderLayer.h:
(WebCore::ClipRect::ClipRect):
(WebCore::ClipRect::rect):
(WebCore::ClipRect::setRect):
(WebCore::ClipRect::hasRadius):
(WebCore::ClipRect::setHasRadius):
(WebCore::ClipRect::operator==):
(WebCore::ClipRect::intersect):
(WebCore::ClipRect::move):
(WebCore::ClipRect::isEmpty):
(WebCore::ClipRect::intersects):
(WebCore::intersection):
(WebCore::ClipRects::overflowClipRect):
(WebCore::ClipRects::setOverflowClipRect):
(WebCore::ClipRects::fixedClipRect):
(WebCore::ClipRects::setFixedClipRect):
(WebCore::ClipRects::posClipRect):
(WebCore::ClipRects::setPosClipRect):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::paintIntoLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::clippedByAncestor):
- rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
LayoutTests:
- fast/clip/overflow-border-radius-combinations.html: Added.
- fast/clip/overflow-border-radius-composited.html: Added.
- fast/clip/overflow-border-radius-transformed.html: Added.
- platform/mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
- platform/mac/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
- platform/mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/mac/fast/clip/overflow-border-radius-composited-expected.txt: Added.
- platform/mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
- platform/mac/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
- 3:10 PM Changeset in webkit [95238] by
-
- 4 edits2 adds in trunk/Tools
Reviewed by Adam Barth.
webkit-patch should be able to find users and add them to bugzilla groups
https://bugs.webkit.org/show_bug.cgi?id=63351
These are both very basic commands. But it's now possible to find
all users matching a regexp, as well as add all users matching a regexp
to a set of groups.
bugzilla.py already knew how to find users (for validate-committer-lists)
but now it has the ability to modify the user records.
I split some of the logic out into a new EditUsersParser class
to try and reduce the amount of code in Bugzilla/BugzillaQueries.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
- Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
- Scripts/webkitpy/tool/commands/findusers.py: Added.
- 3:06 PM Changeset in webkit [95237] by
-
- 5 edits in branches/safari-534.51-branch/Source
Versioning.
- 3:05 PM Changeset in webkit [95236] by
-
- 1 copy in tags/Safari-534.51.22
New tag.
- 2:59 PM Changeset in webkit [95235] by
-
- 3 edits3 adds in trunk
Source/WebCore: Crash in RenderBox::paintMaskImages due to a mask without an associated image
https://bugs.webkit.org/show_bug.cgi?id=50151
Reviewed by Simon Fraser.
Test: fast/css/empty-webkit-mask-crash.html
The crash stems from the fact that FillLayer::hasImage would walk over the linked list
of FillLayers and return true if one had an image. This means that hasImage() is true
does not mean that image() is non-NULL on all FillLayers.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintMaskImages): Simplify the logic by doing the hasImage() check up-front
and properly check image() for each FillLayers. This has the nice benefit of changing the complexity
from O(n2) to O(n), which was what the code expected anyway.
LayoutTests: Test for: Crash in RenderBox::paintMaskImages due to a mask without an associated image
https://bugs.webkit.org/show_bug.cgi?id=50151
Reviewed by Simon Fraser.
- fast/css/empty-webkit-mask-crash-expected.png: Added.
- fast/css/empty-webkit-mask-crash-expected.txt: Added.
- fast/css/empty-webkit-mask-crash.html: Added.
- 2:57 PM Changeset in webkit [95234] by
-
- 22 edits in trunk
Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
https://bugs.webkit.org/show_bug.cgi?id=68182
Reviewed by Adam Barth.
.:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- features.pri:
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::createImage):
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/build-webkit:
- waf/build/settings.py:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 2:53 PM Changeset in webkit [95233] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG speculative JIT sometimes asserts that a value is not a number
even when it doesn't know anything about the number
https://bugs.webkit.org/show_bug.cgi?id=68189
Reviewed by Oliver Hunt.
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::isUnknownJS):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
- 2:49 PM Changeset in webkit [95232] by
-
- 4 edits in trunk/Tools
Unreviewed. Make contributor email look-up case-insensitive.
validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
was missing from committers.py due to case sensitivity.
This also includes a test expectations update to committers_unittest.py
after my previous change.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/committers_unittest.py:
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- 2:43 PM Changeset in webkit [95231] by
-
- 2 edits in trunk/Tools
Unreviewed. Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
Add a bunch of email aliases to committers.py for regular contributors
who are committing using other email addresses than they have listed in the file.
- Scripts/webkitpy/common/config/committers.py:
- 2:41 PM Changeset in webkit [95230] by
-
- 5 edits in trunk/Source/JavaScriptCore
All of the functionality in the non-speculative JIT should be
available to the speculative JIT via helper methods
https://bugs.webkit.org/show_bug.cgi?id=68186
Reviewed by Oliver Hunt.
Stole all of the goodness from NonSpeculativeJIT and placed it
in JITCodeGenerator. Left all of the badness (i.e. subtle code
duplication with SpeculativeJIT, etc). This is in preparation
for removing the NonSpeculativeJIT entirely, but having its
goodness available for reuse in the SpeculativeJIT if necessary.
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCheckHasInstance):
(JSC::DFG::JITCodeGenerator::nonSpeculativeInstanceOf):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::nonSpeculativeAdd):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithSub):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGNonSpeculativeJIT.h:
- 2:24 PM Changeset in webkit [95229] by
-
- 10 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r95167.
http://trac.webkit.org/changeset/95167
https://bugs.webkit.org/show_bug.cgi?id=68191
Patch needs further work. (Requested by mhahnenberg on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-15
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- runtime/JSCell.cpp:
(JSC::JSCell::toBoolean):
- runtime/JSCell.h:
(JSC::JSCell::JSValue::toBoolean):
- runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::toBoolean):
- runtime/JSNotAnObject.h:
- runtime/JSObject.h:
- runtime/JSString.h:
- runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::toBoolean):
- 2:21 PM Changeset in webkit [95228] by
-
- 3 edits2 adds in trunk
Having an empty listener to beforeload events changes the behavior of other scripts
https://bugs.webkit.org/show_bug.cgi?id=45586
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/dom/beforeload/cached-image-before-load.html
When loading a cached image after a beforeload handler has been
installed on the document, ImageLoader would dispatch both the
beforeload and load events asynchronously in such a way that caused
load to fire first. Since a side effect of firing the beforeload event
is to wire up the CachedImage to its associated RenderImage object,
this work was not done by the time load fired, and scripts that queried
renderer-dependent attributes of the image in an onload handler would
get bogus values in return.
Fix this by ensuring load fires after beforeload in the cached image case.
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement): Call setClient() after
dispatching beforeload, since setClient() will dispatch the load event
if the image is cached.
LayoutTests:
- fast/dom/beforeload/cached-image-before-load-expected.txt: Added.
- fast/dom/beforeload/cached-image-before-load.html: Added.
- 2:10 PM Changeset in webkit [95227] by
-
- 5 edits in trunk/Source/WebCore
Remove ScrollView::platformContentsSize
https://bugs.webkit.org/show_bug.cgi?id=68188
Reviewed by Darin Adler.
Since ScrollView keeps track of the contents size in ScrollView::m_contentsSize, we never
have to ask the underlying platform scroll view for contents size since it should always just
be equal to m_contentsSize.
- platform/ScrollView.cpp:
(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
- platform/mac/ScrollViewMac.mm:
- platform/wx/ScrollViewWx.cpp:
- 2:04 PM Changeset in webkit [95226] by
-
- 6 edits3 adds in trunk
Submitting a form with target=_blank works only once
https://bugs.webkit.org/show_bug.cgi?id=28633
<rdar://problem/7357787>
Reviewed by Andy Estes.
Source/WebCore:
Test: fast/forms/submit-to-blank-multiple-times.html
The call to reset the multiple form submission bool is pushed down from the mouseDown handler to
handleMousePressEvent(), to include WK2 coverage, similar to keyEvent.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::keyEvent): clarified old FIXME comment. Both key events and mouse events
may submit a form multiple times, but the call to reset the handler should probably be in another
abstraction layer.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::mouseDown):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::mouseDown): Remove call to resetMultipleFormSubmissionProtection() since
it will be made in platform-independent function EventHandler::handleMousePressEvent().
LayoutTests:
New test that simulates mouse clicking submit button twice (which didn't work), as well as using the keyboard twice (which did work).
- fast/forms/resources/submit-to-blank-multiple-times-form-action.html: Added.
- fast/forms/submit-to-blank-multiple-times-expected.txt: Added.
- fast/forms/submit-to-blank-multiple-times.html: Added.
- 2:00 PM Changeset in webkit [95225] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for platforms that expect a linkable symbol
for primitive static const's.
- bytecode/CodeBlock.h:
- jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
- 1:57 PM Changeset in webkit [95224] by
-
- 2 edits in trunk/LayoutTests
[chromium] Add missing GPU-CG to one of the expectations.
- platform/chromium/test_expectations.txt:
- 1:49 PM Changeset in webkit [95223] by
-
- 30 edits in trunk
XMLDocumentParserQt.cpp incorrectly converts 0-based number into 1-based number
https://bugs.webkit.org/show_bug.cgi?id=63540
Source/WebCore:
ZeroBasedNumber/OneBasedNumber are used in more places, inconsistency
in xml parser is fixed.
Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-09-15
Reviewed by Adam Barth.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::eventHandlerLineNumber):
- dom/ScriptableDocumentParser.h:
- dom/StyleElement.cpp:
(WebCore::StyleElement::StyleElement):
- dom/ViewportArguments.cpp:
(WebCore::parserLineNumber):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::lineNumber):
- html/parser/HTMLDocumentParser.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::buildInitiatorObject):
- svg/SVGDocumentExtensions.cpp:
(WebCore::parserLineNumber):
- xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::lineNumber):
- xml/parser/NewXMLDocumentParser.h:
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::pushCurrentNode):
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::error):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::doEnd):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):
LayoutTests:
Bug is fixed, incorrect test expectations are properly fixed (line
number '0' is reported no more).
Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-09-15
Reviewed by Adam Barth.
- fast/parser/changing-attrbutes-crash-expected.txt:
- html5lib/runner-expected.txt:
- platform/chromium/html5lib/runner-expected.txt:
- svg/custom/invalid-length-units-expected.txt:
- svg/custom/poly-parsing-error-expected.txt:
- svg/custom/svg-parse-overflow-1-expected.txt:
- svg/custom/svg-parse-overflow-2-expected.txt:
- svg/custom/svg-parse-overflow-3-expected.txt:
- svg/custom/svg-parse-overflow-4-expected.txt:
- svg/custom/svg-parse-overflow-5-expected.txt:
- svg/dom/fuzz-path-parser-expected.txt:
- svg/dom/path-parser-expected.txt:
- svg/dom/points-parser-expected.txt:
- 1:43 PM Changeset in webkit [95222] by
-
- 2 edits in trunk/Source/WebCore
Fix WebCore.gypi after r95130.
Unreviewed, build fix.
- WebCore.gypi:
- 1:05 PM Changeset in webkit [95221] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for assertion on existence of alternative
CodeBlock.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
- 1:02 PM Changeset in webkit [95220] by
-
- 8 edits2 adds in branches/safari-534.51-branch
Merge r89705.
- 12:56 PM Changeset in webkit [95219] by
-
- 3 edits in trunk/Source/JavaScriptCore
Value profiles collect no information for global variables
https://bugs.webkit.org/show_bug.cgi?id=68143
Reviewed by Geoffrey Garen.
17% speed-up on string-fasta. Neutral elsewhere.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getStrongPrediction):
(JSC::DFG::ByteCodeParser::stronglyPredict):
(JSC::DFG::ByteCodeParser::parseBlock):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_global_var):
- 12:49 PM Changeset in webkit [95218] by
-
- 2 edits in trunk/LayoutTests
[chromium] Add temporary exception while bots catch up to r95203.
- platform/chromium/test_expectations.txt:
- 12:46 PM Changeset in webkit [95217] by
-
- 4 edits2 adds in branches/safari-534.51-branch
Merge r91386.
- 12:43 PM Changeset in webkit [95216] by
-
- 86 edits in trunk
Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
https://bugs.webkit.org/show_bug.cgi?id=68022
Reviewed by Ryosuke Niwa.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- features.pri:
- page/DOMWindow.idl:
- svg/svgtags.in:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/build-webkit:
- waf/build/settings.py:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 12:39 PM Changeset in webkit [95215] by
-
- 5 edits in branches/safari-534.51-branch/Source/WebCore
Merge r88139.
- 12:32 PM Changeset in webkit [95214] by
-
- 4 edits in trunk/Source/JavaScriptCore
Ooops, revert accidentally commited unreviewed changes.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
- jit/JSInterfaceJIT.h:
- runtime/JSValue.h:
- 12:29 PM Changeset in webkit [95213] by
-
- 3 edits6 adds in branches/safari-534.51-branch
Merge r90568.
- 12:24 PM Changeset in webkit [95212] by
-
- 4 edits in trunk
Unreviewed, rolling out r95163.
http://trac.webkit.org/changeset/95163
https://bugs.webkit.org/show_bug.cgi?id=68180
[Qt] The QT_GCC_X variables were removed in Qt5 by accident.
(Requested by darktears on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-15
.:
- Source/WebKit.pri:
Source/JavaScriptCore:
- JavaScriptCore.pro:
- 12:20 PM Changeset in webkit [95211] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebCore
Merge r95057.
- 12:18 PM Changeset in webkit [95210] by
-
- 3 edits2 adds in branches/safari-534.51-branch
Merge r95056.
- 12:12 PM Changeset in webkit [95209] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebKit2
Merge r94818.
- 12:05 PM Changeset in webkit [95208] by
-
- 5 edits in trunk/Source/JavaScriptCore
Windows build fix p1.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
- jit/JSInterfaceJIT.h:
- runtime/JSValue.h:
- 12:00 PM Changeset in webkit [95207] by
-
- 3 edits3 adds in trunk
REGRESSION (Safari 5.1-r95043): Incorrect box-shadow offset
https://bugs.webkit.org/show_bug.cgi?id=68041
Reviewed by Dan Bernstein.
Source/WebCore:
Test: fast/box-shadow/no-blur-multiple-offsets.html
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformShadow): Add hack back in for Lion if
context is not accelerated.
LayoutTests:
- fast/box-shadow/no-blur-multiple-offsets-expected.txt: Added.
- fast/box-shadow/no-blur-multiple-offsets.html: Added.
- platform/mac/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
- 11:54 AM Changeset in webkit [95206] by
-
- 2 edits in trunk/Source/JavaScriptCore
Tiered compilation should be enabled by default on platforms
that support the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68136
Reviewed by Sam Weinig.
Neutral on SunSpider, 4% speed-up on V8, and 19% speed-up on
Kraken. Large progressions on some benchmarks, including
3x on imaging-desaturate.
- wtf/Platform.h:
- 11:47 AM Changeset in webkit [95205] by
-
- 4 edits in trunk/Source/JavaScriptCore
devirtualize preventExtensions
https://bugs.webkit.org/show_bug.cgi?id=68176
Reviewed by Oliver Hunt.
This is virtual due to problems in JSFunction putting the prototype
property, but we can fix this problem a different way, just setting
the checkReadOnly flag to false in the put.
- runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
- runtime/JSFunction.h:
- runtime/JSObject.h:
- 11:40 AM Changeset in webkit [95204] by
-
- 6 edits2 adds in trunk
2011-09-15 James Simonsen <simonjam@chromium.org>
Ref protect HTMLObjectElement and HTMLEmbedElement while requesting plugins
https://bugs.webkit.org/show_bug.cgi?id=68014
Reviewed by Adam Barth.
- plugins/destroy-during-npp-new-object-with-fallback-content-expected.txt: Added.
- plugins/destroy-during-npp-new-object-with-fallback-content.html: Added. Derivative of destroy-during-npp-new.html.
2011-09-15 James Simonsen <simonjam@chromium.org>
Ref protect HTMLObjectElement and HTMLEmbedElement while requesting plugins
https://bugs.webkit.org/show_bug.cgi?id=68014
Reviewed by Adam Barth.
Test: plugins/destroy-during-npp-new.html under valgrind
plugins/destroy-during-npp-new-object-with-fallback-content.html under valgrind
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):
2011-09-15 James Simonsen <simonjam@chromium.org>
Ref protect HTMLObjectElement and HTMLEmbedElement while requesting plugins
https://bugs.webkit.org/show_bug.cgi?id=68014
Reviewed by Adam Barth.
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin): Moved protection up to HTMLObjectElement and HTMLEmbedElement.
- 11:27 AM Changeset in webkit [95203] by
-
- 14 edits2 deletes in trunk
Experiment with removing ability to call a collection (except document.all)
https://bugs.webkit.org/show_bug.cgi?id=67579
Reviewed by Anders Carlsson.
Source/WebCore:
At the request of the public-script-coord mailing list (specifically Brendan Eich, see
http://lists.w3.org/Archives/Public/public-script-coord/2011JulSep/0360.html), this
patch removes the ability to call a collection (either a NodeList or HTMLCollection,
but not an HTMLAllCollection) as function, a syntax that we adopted to emulate IE.
It is being landed to find out if there are any sites relying on this behavior of WebKit,
or, if it is only used in IE only paths. If we find sites are breaking, it should be rolled
out and we should inform the public-script-coord mailing list.
- bindings/js/JSHTMLAllCollectionCustom.cpp:
Update comment.
- bindings/js/JSHTMLCollectionCustom.cpp:
- bindings/js/JSNodeListCustom.cpp:
Remove custom call code.
- bindings/scripts/CodeGeneratorV8.pm:
Add support for V8CustomCall.
- dom/NodeList.idl:
- html/HTMLCollection.idl:
Remove CustomCall.
LayoutTests:
- fast/dom/Element/id-in-formcollection-expected.txt:
- fast/dom/Element/id-in-formcollection.html:
- fast/dom/HTMLOptionElement/collection-setter-getter-expected.txt:
- fast/dom/HTMLOptionElement/collection-setter-getter.html:
Don't use call syntax for tests that aren't explicitly testing it.
- fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
- fast/dom/NodeList/script-tests/nodelist-item-call-as-function.js:
Update test to show that we throw on call.
- fast/profiler/call-nodelist-as-function-expected.txt: Removed.
- fast/profiler/call-nodelist-as-function.html: Removed.
Remove test of removed feature.
- 11:17 AM Changeset in webkit [95202] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Attempt to fix the shared build after r95188.
- WebKit.gyp:
- 10:58 AM Changeset in webkit [95201] by
-
- 4 edits in trunk/Source/JavaScriptCore
Value chaining for JSValue32_64 bitops.
Reviewed by Sam Weinig.
SunSpider says 2.3% faster, v8 ~1% faster (mostly due to crypto).
- jit/JIT.h:
- jit/JITInlineMethods.h:
(JSC::JIT::emitStoreAndMapInt32): New int32 helper function for stores
that can chain their results, which is the common case.
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec): Deployed new function.
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec): Had to reorder these functions so they
computed their result values last, to make them elligible for chaining.
- 10:58 AM Changeset in webkit [95200] by
-
- 1 copy in releases/WebKitGTK/webkit-1.6
Branching WebkitGTK+ for 1.6
- 10:53 AM Changeset in webkit [95199] by
-
- 17 edits in trunk/Tools
Fix Mac build by including config.h where needed.
- TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
- TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
- TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
- TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
- TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
- TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
- TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
- TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
- TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
- TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
- TestWebKitAPI/mac/JavaScriptTestMac.mm:
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
- TestWebKitAPI/mac/PlatformWebViewMac.mm:
- TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
- TestWebKitAPI/mac/WebKitAgnosticTest.mm:
- TestWebKitAPI/mac/main.mm:
- 10:11 AM Changeset in webkit [95198] by
-
- 2 edits in trunk/Source/WebCore
CanvasRenderingContext2D::State copy ctor should use initializer list.
https://bugs.webkit.org/show_bug.cgi?id=68152
Patch by Andreas Kling <kling@webkit.org> on 2011-09-15
Reviewed by Darin Adler.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
- 9:54 AM Changeset in webkit [95197] by
-
- 14 edits in trunk/Source/WebKit2
[Qt][WK2] Make QWebError more friendly to QML.
https://bugs.webkit.org/show_bug.cgi?id=67785
Reviewed by Simon Hausmann.
Make sure that we can use the loading errors in QML. We send it via a QJSValue which
has the properties needed to get the error code, the url and the type of error.
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::loadDidFail):
(QDesktopWebViewPrivate::engine):
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qdesktopwebview_p.h:
- UIProcess/API/qt/qtouchwebpage.h:
- UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
(tst_CommonViewTests::loadNonexistentFileUrl):
- UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):
- UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
- UIProcess/API/qt/tests/testwindow.h:
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::loadDidFail):
- UIProcess/qt/QtWebPageProxy.h:
- UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::loadDidFail):
(WebKit::TouchViewInterface::engine):
- UIProcess/qt/TouchViewInterface.h:
- UIProcess/qt/ViewInterface.h:
- 9:46 AM Changeset in webkit [95196] by
-
- 2 edits in trunk/LayoutTests
[chromium] Add expectation for flaky tests.
- platform/chromium/test_expectations.txt:
- 9:43 AM Changeset in webkit [95195] by
-
- 2 edits in trunk/Source/WebKit2
Remove WebKit2-specific knowledge from the Message class
This is in preparation for making some of our message-generations scripts usable by other
projects.
Fixes <http://webkit.org/b/68170> Model classes in WebKit2's message-generation scripts know
too much about WebKit2 details
Reviewed by Anders Carlsson.
- Scripts/webkit2/messages.py: Added constants for the message attributes we support.
(MessageReceiver.parse): Instead of recognizing individual attributes, just stick the
attributes into a set and pass it to the Message constructor.
(Message.init): Changed to take a generic set of attributes instead of individual
attributes.
(Message.has_attribute): Added. Returns true if the message has an attribute.
(message_is_variadic): Renamed from parameter_type_is_variadic. Code came from
Message.init, which set the old message.is_variadic property.
(decode_type):
(message_to_struct_declaration):
(forward_declarations_and_headers):
(async_case_statement):
(sync_case_statement):
(generate_message_handler):
Updated to use Message.has_attribute and message_is_variadic.
- 9:14 AM Changeset in webkit [95194] by
-
- 2 edits in trunk/Source/JavaScriptCore
Clang build fix after r95172
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArray):
Added parentheses to make precendence clear.
- 9:09 AM Changeset in webkit [95193] by
-
- 2 edits in trunk/Source/WebCore
Don't bother calculating dirty rect for accelerated 2D canvases.
https://bugs.webkit.org/show_bug.cgi?id=68158
Patch by Andreas Kling <kling@webkit.org> on 2011-09-15
Reviewed by Kenneth Rohde Christiansen.
For accelerated CanvasRenderingContext2D, didDraw() simply calls out
to RenderLayer::contentChanged(). Move this to the top of didDraw()
so we don't waste time calculating a precise dirty rect.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::didDraw):
- 8:13 AM Changeset in webkit [95192] by
-
- 13 edits in trunk/Source
Source/WebCore: [Skia/Chrome] Cleanup unneeded code now that GrGLInterface is used to set GL ctx per GL call.
https://bugs.webkit.org/show_bug.cgi?id=68096
Patch by Brian Salomon <bsalomon@google.com> on 2011-09-15
Reviewed by Stephen White.
This change removes PlatformContextSkia::makeGrContextCurrent now that
GrGLInterface is used to set the context on every Skia GL call.
Tested by every canvas layout test.
- platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::drawGlyphs):
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForTextChecking):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::setGraphicsContext3D):
- platform/graphics/skia/PlatformContextSkia.h:
- platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::paintSkiaText):
Source/WebKit/chromium: [Skia/Chrome]
https://bugs.webkit.org/show_bug.cgi?id=68096
This change removes WebGraphicsContext3D::grGLInterface(). It has been
superceded by WebGraphicsContext3D::createGrGLInterface which sets up
the per-GL call callback used to set the correct context.
Patch by Brian Salomon <bsalomon@google.com> on 2011-09-15
Reviewed by Stephen White.
- public/WebGraphicsContext3D.h:
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::grContext):
- src/WebGraphicsContext3D.cpp:
(WebKit::WebGraphicsContext3D::createGrGLInterface):
- 7:42 AM Changeset in webkit [95191] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; new expectations (Skia on Mac)
This separates test failures that are specific to CG Mac from failures
for Skia on Mac.
- LayoutTests/platform/chromium/test_expectations.txt:
- 7:39 AM Changeset in webkit [95190] by
-
- 1 edit7 deletes in trunk/LayoutTests
Unreviewed; new baselines (Skia on Mac)
Updated reference images.
- LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
- LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Removed.
- LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-relative-expected.txt: Removed.
- LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-expected.txt: Removed.
- LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
- LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-expected.txt: Removed.
- LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Removed.
- 7:36 AM Changeset in webkit [95189] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, rolling out r95186.
http://trac.webkit.org/changeset/95186
https://bugs.webkit.org/show_bug.cgi?id=68159
Invalid rebaseline. (Requested by dave_levin on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-15
- http/tests/loading/307-after-303-after-post-expected.txt:
- http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
- http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
- 7:08 AM Changeset in webkit [95188] by
-
- 62 edits1 move1 add in trunk
Let TestWebKitAPI work for chromium
https://bugs.webkit.org/show_bug.cgi?id=67756
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-15
Reviewed by Sam Weinig.
Source/WebKit/chromium:
- WebKit.gyp:
Tools:
- Scripts/build-api-tests:
- Scripts/run-api-tests:
(isSupportedPlatform):
(runTest):
(populateTests):
- Scripts/webkitdirs.pm:
(determineBaseProductDir):
- TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
- TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
- TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
- TestWebKitAPI/InjectedBundleController.cpp:
- TestWebKitAPI/InjectedBundleMain.cpp:
- TestWebKitAPI/JavaScriptTest.cpp:
- TestWebKitAPI/PlatformUtilities.cpp:
- TestWebKitAPI/TestWebKitAPI.gypi: Added.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
- TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
- TestWebKitAPI/Tests/WTF/StringOperators.cpp:
- TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
- TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
- TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
- TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
- TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
- TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
- TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
- TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
- TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
- TestWebKitAPI/Tests/WebKit2/Find.cpp:
- TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
- TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
- TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
- TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
- TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
- TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
- TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
- TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
- TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
- TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
- TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
- TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
- TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
- TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
- TestWebKitAPI/Tests/WebKit2/WKString.cpp:
- TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
- TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
- TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
- TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
- TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
- TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
- TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
- TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
- TestWebKitAPI/TestsController.cpp:
- TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
- TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
- TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
- TestWebKitAPI/win/PlatformWebViewWin.cpp:
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- TestWebKitAPI/win/main.cpp:
- 6:47 AM Changeset in webkit [95187] by
-
- 4 edits7 adds in trunk/LayoutTests
Unreviewed; new baselines (Skia on Mac)
Updated reference images.
- LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-gradient-expected.png: Added.
- LayoutTests/platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
- LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
- LayoutTests/platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
- LayoutTests/platform/chromium-mac/fast/borders/border-image-massive-scale-expected.png: Added.
- LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Added.
- LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added.
- LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-vertical-rl-expected.png: Added.
- LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-vertical-lr-expected.png: Added.
- LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-horizontal-bt-expected.png: Added.
- 6:46 AM Changeset in webkit [95186] by
-
- 4 edits in trunk/LayoutTests
[chromium] rebaseline expectations due to r95180
- http/tests/loading/307-after-303-after-post-expected.txt:
- http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
- http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
- 5:30 AM Changeset in webkit [95185] by
-
- 10 edits1 add1 delete in trunk/LayoutTests
Unreviewed; new baselines (Skia on Mac)
Updated reference images.
- platform/chromium-mac/fast/borders/border-image-border-radius-expected.png:
- platform/chromium-mac/fast/borders/border-image-01-expected.png:
- platform/chromium-mac/fast/borders/border-image-slices-expected.png:
- platform/chromium-mac/fast/borders/border-image-scrambled-expected.png: Added.
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-mac/fast/borders/border-image-repeat-expected.png:
- platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac/fast/borders/border-image-source-expected.png:
- platform/chromium-mac/fast/borders/border-image-longhand-expected.png:
- platform/chromium-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Removed.
- 5:25 AM Changeset in webkit [95184] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Make sure that the ARM NEON files build with -marm
https://bugs.webkit.org/show_bug.cgi?id=68088
Simply adding the -marm cflag for OS=Android compiles results in it
being overridden by an -mthumb cflag later in the project generating
process. Therefore we should explicitly exclude -mthumb.
Patch by Peter Beverloo <peter@chromium.org> on 2011-09-15
Reviewed by Tony Gentilcore.
- WebCore.gyp/WebCore.gyp:
- 5:11 AM Changeset in webkit [95183] by
-
- 2 edits in trunk/LayoutTests
[Qt][ARMv5] Two timeline tests of inspector fail
https://bugs.webkit.org/show_bug.cgi?id=68151
Unreviewed gardening, adding timeout tests to skip list.
- platform/qt-arm/Skipped:
- 3:51 AM Changeset in webkit [95182] by
-
- 2 edits in trunk/LayoutTests
[chromium] Add slow to debug version of repeat-cached-vm-reentry.html and sandboxed-iframe-navigation-parent.html.
- platform/chromium/test_expectations.txt:
- 3:46 AM Changeset in webkit [95181] by
-
- 4 edits4 deletes in trunk/LayoutTests
[chromium] rebaseline expectations due to r95096, r95121, and r95129
- platform/chromium-cg-mac-leopard/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Removed.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
- platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
- platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
- platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- 2:36 AM BuildingQtOnWindows edited by
- Add pthread as dependency (diff)
- 2:10 AM Changeset in webkit [95180] by
-
- 3 edits in trunk/Tools
[chromium] extract normalization of LayoutTests URLs to a method of TestShell
https://bugs.webkit.org/show_bug.cgi?id=68145
This will allow for other classes in DumpRenderTree to reuse this functionality
Reviewed by David Levin.
- DumpRenderTree/chromium/TestShell.cpp:
(normalizeLayoutTestURLInternal):
(dumpHistoryItem):
(TestShell::normalizeLayoutTestURL):
- DumpRenderTree/chromium/TestShell.h:
- 1:37 AM Changeset in webkit [95179] by
-
- 1 edit4 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Adding new test expectations.
- platform/qt/fast/borders/border-image-massive-scale-expected.txt: Added.
- platform/qt/fast/borders/border-image-scaled-gradient-expected.txt: Added.
- platform/qt/fast/borders/border-image-scrambled-expected.txt: Added.
- platform/qt/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
- 1:09 AM Changeset in webkit [95178] by
-
- 2 edits in trunk/LayoutTests
Renaming PeerConnection to webkitPeerConnection affects all ports,
not just chromium. Updating layout test after r95151.
Unreviewed gardening.
- fast/dom/call-a-constructor-as-a-function-expected.txt:
- 12:56 AM Changeset in webkit [95177] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Build fix: Remove use of GraphicsContext::setIsAcceleratedContext
r95174 introduced GraphicsContext::setIsAcceleratedContext into Skia code and caused chromium builds to fail.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- 12:41 AM Changeset in webkit [95176] by
-
- 3 edits in trunk/Source/WebCore
ThreadableWebSocketChannelClientWrapper shouldn't have a String in it.
https://bugs.webkit.org/show_bug.cgi?id=67908
Reviewed by David Levin.
Replace a String member variable in ThreadableWebSocketChannelClientWrapper with Vector<UChar>.
ThreadableWebSocketChannelClientWrapper is derived from ThreadSafeRefCounted. It may be
destroyed on different threads, which will affect String's refcounting. Therefore, classes
derived from ThreadSafeRefCounted must not have a String member variable.
No change in functionality, thus no new tests. WebSocket worker tests
(tests under http/tests/websocket/tests/{hixie76,hybi}/workers/) should keep passing.
- websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
Create a String from Vector<UChar>. Note that String constructor taking an empty vector returns
a null string, not an empty string. We want an empty string in that case, so I had to add
special-case handling for an empty vector.
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
Copy the content of the given String into Vector.
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- 12:11 AM Changeset in webkit [95175] by
-
- 2 edits2 adds1 delete in trunk/LayoutTests
[chromium] rebaseline expectations due to r95121
- platform/chromium-cg-mac-leopard/svg/as-border-image/svg-as-border-image-expected.txt: Added.
- platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.txt: Added.
- platform/chromium-win-xp/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
Sep 14, 2011:
- 11:55 PM Changeset in webkit [95174] by
-
- 5 edits in trunk/Source/WebCore
Use isAcceleratedContext() on the GraphicsContext instead of flags in ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=68137
Reviewed by Simon Fraser.
No new tests. No change in behavior.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::isAccelerated): Have all just query the context directly.
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere): just use isAccelerated directly
- platform/graphics/ImageBuffer.h:
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer): Set isAcceleratedContext on the GraphicsContext instead of carrying the
bit around on the ImageBuffer itself.
(WebCore::ImageBuffer::copyNativeImage): Update the check. Same for all below...
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/skia/ImageBufferSkia.cpp: Set isAcceleratedContext on the GraphicsContext instead of carrying the
bit around on the ImageBuffer itself.
(WebCore::ImageBuffer::ImageBuffer): Remove m_acceleratesRendering flag and getter.
- 11:09 PM Changeset in webkit [95173] by
-
- 1 edit7 adds3 deletes in trunk/LayoutTests
[chromium] rebaseline expectations due to r95096, r95121, and r95129
- platform/chromium-cg-mac-leopard/fast/borders/block-mask-overlay-image-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/borders/border-color-inherit-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/borders/inline-mask-overlay-image-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/chromium-cg-mac-leopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/chromium-cg-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
- platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
- platform/chromium-cg-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
- 10:49 PM Changeset in webkit [95172] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG does not speculate aggressively enough on comparisons
https://bugs.webkit.org/show_bug.cgi?id=68138
Reviewed by Oliver Hunt.
This is a 75% speed-up on Kraken/ai-astar. It's a 1% win on
V8 and an 8.5% win on Kraken. Neutral on SunSpider.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArray):
(JSC::DFG::SpeculativeJIT::shouldSpeculateObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateCell):
- 10:48 PM Changeset in webkit [95171] by
-
- 2 edits in trunk/Source/WebKit/chromium
Remove some dependencies of DRT for Android.
https://bugs.webkit.org/show_bug.cgi?id=68126
Patch by Hao Zheng <zhenghao@chromium.org> on 2011-09-14
Reviewed by Tony Chang.
We don't need mesa and TestNetscapePlugIn on Android, so remove them.
As copy_TNPI depends on TNPI, adding copy_TNPI is enough.
- WebKit.gyp:
- 10:44 PM Changeset in webkit [95170] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG JIT does not leverage integer speculations on branches
https://bugs.webkit.org/show_bug.cgi?id=68140
Reviewed by Oliver Hunt.
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isStrictInt32):
- dfg/DFGJITCodeGenerator.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 10:26 PM Changeset in webkit [95169] by
-
- 3 edits3 adds in trunk
libxml2 fragment parser loses prefix namespaces
https://bugs.webkit.org/show_bug.cgi?id=66423
Source/WebCore:
This makes the loop over the elements outside of the context actually update the element it's processing.
Patch by Jeffrey Pfau <jeffrey@endrift.com> on 2011-09-14
Reviewed by Eric Seidel.
Test: fast/parser/innerhtml-with-prefixed-elements.xhtml
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
LayoutTests:
Added a test to ensure that elements inserted when the prefix is already declared are inserted properly.
Patch by Jeffrey Pfau <jeffrey@endrift.com> on 2011-09-14
Reviewed by Eric Seidel.
- fast/parser/innerhtml-with-prefixed-elements.xhtml: Added.
- platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
- platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
- 10:17 PM Changeset in webkit [95168] by
-
- 2 edits in trunk/Source/JavaScriptCore
[n]stricteq code is bogus in JSValue32_64 JIT
https://bugs.webkit.org/show_bug.cgi?id=68141
Reviewed by Sam Weinig.
The code tries to check for both ints or cells, but this check also
catches cases where values that are undefined, null, etc (probably
was incorrectly assuming cell was the 2nd highest tag?).
Also, there is no need not to handle int on the fast path.
stricteq is just a case of comparing the payloads, if we:
- handle cases of differing tags on a slow path
- handle doubles a slow path
- handle both-are-string on a slow path
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
- 10:15 PM Changeset in webkit [95167] by
-
- 10 edits in trunk/Source/JavaScriptCore
Make JSCell::toBoolean non-virtual
https://bugs.webkit.org/show_bug.cgi?id=67727
Reviewed by Sam Weinig.
JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
before it was simply virtual and would crash if its implementation was called).
Its descendants in JSObject and JSString have also been made non-virtual. JSCell now
explicitly covers all cases of toBoolean, so having a virtual implementation of
JSCell::toBoolean is no longer necessary. This is part of a larger process of un-virtualizing JSCell.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- runtime/JSCell.cpp:
- runtime/JSCell.h:
- runtime/JSNotAnObject.cpp:
- runtime/JSNotAnObject.h:
- runtime/JSObject.h:
- runtime/JSString.h:
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):
- runtime/StringObjectThatMasqueradesAsUndefined.h:
- 10:12 PM Changeset in webkit [95166] by
-
- 2 edits in trunk/Source/WebCore
[V8] Null-check the v8::Context in
V8DOMWindowShell:namedItemAdded() before using it.
Also, add some logging to figure out how we're getting
into this bad state.
https://bugs.webkit.org/show_bug.cgi?id=68099
Reviewed by Adam Barth.
No new tests, no known repro.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::namedItemAdded):
- 9:46 PM Changeset in webkit [95165] by
-
- 2 edits in trunk/Source/WebCore
Replace ENABLE_XHR_RESPONSE_BLOB preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=64960
Reviewed by Ryosuke Niwa.
- xml/XMLHttpRequest.idl:
- 9:43 PM Changeset in webkit [95164] by
-
- 2 edits in trunk/LayoutTests
[chromium] Add slow to debug version of styles-source-lines.html.
- platform/chromium/test_expectations.txt:
- 9:33 PM Changeset in webkit [95163] by
-
- 4 edits in trunk
[Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.
https://bugs.webkit.org/show_bug.cgi?id=68114
Reviewed by Kenneth Rohde Christiansen.
.:
Replace QT_GCC_X variables, they have been removed in Qt5. It was
actually wrong to use them because they tell about which GCC version
Qt has been compiled, not the current version of GCC use to build webkit.
I use gcc -dumpversion to get it.
- Source/WebKit.pri:
Source/JavaScriptCore:
Use the new GCC_X variables defined in WebKit.pri to replace
the usage of QT_GCC_X.
- JavaScriptCore.pro:
- 9:27 PM Changeset in webkit [95162] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r95145.
http://trac.webkit.org/changeset/95145
https://bugs.webkit.org/show_bug.cgi?id=68139
The GTK+ build is working now, so revert this trial build fix.
(Requested by mrobinson on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-14
- GNUmakefile.list.am:
- 9:24 PM Changeset in webkit [95161] by
-
- 61 edits in trunk/LayoutTests
Fix tests made trivial by the bugfix to 27895, by removing leading punctuation
which would cause early truncation of the page snippet.
https://bugs.webkit.org/show_bug.cgi?id=27895
Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-14
Reviewed by Adam Barth.
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char.html:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event.html:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html:
- http/tests/security/xssAuditor/anchor-url-dom-write-location.html:
- http/tests/security/xssAuditor/dom-write-URL.html:
- http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt:
- http/tests/security/xssAuditor/dom-write-innerHTML.html:
- http/tests/security/xssAuditor/dom-write-location-inline-event.html:
- http/tests/security/xssAuditor/dom-write-location-javascript-URL.html:
- http/tests/security/xssAuditor/dom-write-location.html:
- http/tests/security/xssAuditor/full-block-get-from-iframe.html:
- http/tests/security/xssAuditor/full-block-javascript-link.html:
- http/tests/security/xssAuditor/full-block-link-onclick.html:
- http/tests/security/xssAuditor/full-block-post-from-iframe.html:
- http/tests/security/xssAuditor/full-block-script-tag.html:
- http/tests/security/xssAuditor/get-from-iframe.html:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html:
- http/tests/security/xssAuditor/img-onerror-tricky.html:
- http/tests/security/xssAuditor/javascript-link-null-char.html:
- http/tests/security/xssAuditor/javascript-link-one-plus-one.html:
- http/tests/security/xssAuditor/javascript-link.html:
- http/tests/security/xssAuditor/link-onclick-ampersand.html:
- http/tests/security/xssAuditor/link-onclick-control-char.html:
- http/tests/security/xssAuditor/link-onclick-entities.html:
- http/tests/security/xssAuditor/link-onclick-null-char.html:
- http/tests/security/xssAuditor/link-onclick.html:
- http/tests/security/xssAuditor/link-opens-new-window.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header.html:
- http/tests/security/xssAuditor/open-attribute-body.html:
- http/tests/security/xssAuditor/open-event-handler-iframe.html:
- http/tests/security/xssAuditor/post-from-iframe.html:
- http/tests/security/xssAuditor/property-escape-comment.html:
- http/tests/security/xssAuditor/property-escape-entity.html:
- http/tests/security/xssAuditor/property-escape-noquotes-expected.txt:
- http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt:
- http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html:
- http/tests/security/xssAuditor/property-escape-noquotes.html:
- http/tests/security/xssAuditor/property-escape-quote.html:
- http/tests/security/xssAuditor/property-escape.html:
- http/tests/security/xssAuditor/property-inject-expected.txt:
- http/tests/security/xssAuditor/property-inject.html:
- http/tests/security/xssAuditor/script-tag-addslashes-backslash.html:
- http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html:
- http/tests/security/xssAuditor/script-tag-addslashes-null-char.html:
- http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html:
- http/tests/security/xssAuditor/script-tag-control-char.html:
- http/tests/security/xssAuditor/script-tag-entities.html:
- http/tests/security/xssAuditor/script-tag-null-char.html:
- http/tests/security/xssAuditor/script-tag-open-redirect.html:
- http/tests/security/xssAuditor/script-tag-post-control-char.html:
- http/tests/security/xssAuditor/script-tag-post-null-char.html:
- http/tests/security/xssAuditor/script-tag-post.html:
- http/tests/security/xssAuditor/script-tag-redirect.html:
- http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html:
- http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding.html:
- http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode.html:
- http/tests/security/xssAuditor/script-tag.html:
- http/tests/security/xssAuditor/xss-protection-parsing-01.html:
- 9:15 PM Changeset in webkit [95160] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Make WEB_AUDIO conditional and fix the build when disabled
https://bugs.webkit.org/show_bug.cgi?id=68107
Patch by Peter Beverloo <peter@chromium.org> on 2011-09-14
Reviewed by Kenneth Russell.
- features.gypi:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
- src/WebMediaPlayerClientImpl.h:
- 9:08 PM Changeset in webkit [95159] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
PrettyPatch should handle "delta" patch mechanism in git binary patches
https://bugs.webkit.org/show_bug.cgi?id=67628
Git patches are encoded using two mechanisms - "literal" and "delta".
For details of these mechanisms, see the function emit_binary_diff_body
in the git source file diff.c (https://github.com/git/git/blob/master/diff.c).
When determining if a binary file patch is an image or not we should accept
both literal and delta patch encodings.
When reconstructing the images from the patches, if we have a delta patch
we may download the previous revision from svn.webkit.org to get the image data.
Patch by Ben Wells <benwells@chromium.org> on 2011-09-14
Reviewed by Adam Roben.
- PrettyPatch/PrettyPatch.rb:
- PrettyPatch/PrettyPatch_test.rb:
- 9:06 PM Changeset in webkit [95158] by
-
- 9 edits25 adds in trunk
Chromium: Add a layer for rubber-band overhang painting to the hardware path.
https://bugs.webkit.org/show_bug.cgi?id=66969
Also, add layout tests for rubber-band overhang drawing for compositing path.
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-14
Reviewed by James Robinson.
- page/FrameView.cpp:
(WebCore::FrameView::layerForOverhangAreas):
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::layerForOverhangAreas):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::paintContents):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::destroyRootLayer):
- rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::layerForOverhangAreas):
- 8:28 PM Changeset in webkit [95157] by
-
- 3 edits1 add in trunk
[v8] Improve performance of typed array copy constructor taking Array
https://bugs.webkit.org/show_bug.cgi?id=68015
Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-14
Reviewed by Kenneth Russell.
Invoke the 'set' method of the constructed array instead of
copying the elements of the source array one by one.
Copy constructor tests already exist.
- ../../Source/WebCore/WebCore.gypi:
- ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Added.
- ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
- 8:04 PM Changeset in webkit [95156] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Return correct value for getContextAttributes().preserveDrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=68082
Patch by John Bauman <jbauman@chromium.org> on 2011-09-14
Reviewed by Kenneth Russell.
WebKit::WebGraphicsContext3D::Attributes doesn't save
preserveDrawingBuffer, so that has to be saving in
GraphicsContext3DPrivate.
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
- src/GraphicsContext3DPrivate.h:
- 8:01 PM Changeset in webkit [95155] by
-
- 2 edits1 copy3 moves2 adds1 delete in trunk/LayoutTests
[chromium] rebaselines due to r95096, and r95121.
- platform/chromium-cg-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-expected.txt.
- platform/chromium-cg-mac-leopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
- platform/chromium-cg-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.txt: Removed.
- platform/chromium-win-xp/svg/as-border-image/svg-as-border-image-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt.
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt:
- 7:53 PM Changeset in webkit [95154] by
-
- 3 edits in trunk/Source/WebKit2
Eliminate WebKit2 compilation warnings.
https://bugs.webkit.org/show_bug.cgi?id=65025
Warnings found with gcc on linux.
Patch by Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com> on 2011-09-14
Reviewed by Sam Weinig.
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
- 7:40 PM Changeset in webkit [95153] by
-
- 2 edits in trunk/Source/JavaScriptCore
Port MachineStackMarker to Windows ARM and MIPS
https://bugs.webkit.org/show_bug.cgi?id=68068
Reviewed by Geoffrey Garen.
Use the correct memeber of the CONTEXT struct for the stackpointer for CPU(ARM) and CPU(MIPS).
Only query CONTEXT_INTEGER and CONTEXT_CONTROL, since CONTEXT_SEGMENTS isn't defined for
CPU(ARM) and CPU(MIPS) and the stackpointer is defined in the CONTEXT_CONTROL section for
CPU(ARM), CPU(X86) and CPU(X86_64) and in the CONTEXT_INTEGER section for CPU(MIPS).
- heap/MachineStackMarker.cpp:
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
- 7:34 PM Changeset in webkit [95152] by
-
- 8 edits in trunk/Source
Remove the dependency on GraphicsLayer from CCLayerTreeHost.
Move root layer management into the NonCompositedContentHost.
Have WebViewImpl create a NonCompositedContentHost explicitly.
https://bugs.webkit.org/show_bug.cgi?id=67883
Patch by Antoine Labour <piman@chromium.org> on 2011-09-14
Reviewed by James Robinson.
Source/WebCore:
Covered by compositing/ layout tests.
- platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setRootLayer):
(WebCore::NonCompositedContentHost::setViewport):
(WebCore::NonCompositedContentHost::setVisible):
(WebCore::NonCompositedContentHost::clearRenderSurfacesRecursive):
(WebCore::NonCompositedContentHost::invalidateRect):
- platform/graphics/chromium/NonCompositedContentHost.h:
(WebCore::NonCompositedContentHost::topLevelRootLayer):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintLayerContents):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::rootLayer):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::updateLayerTreeViewport):
(WebKit::WebViewImpl::setVisibilityState):
- src/WebViewImpl.h:
- 7:26 PM Changeset in webkit [95151] by
-
- 6 edits in trunk
MediaStream API: Change PeerConnection constructor name to webkitPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=67843
Patch by Henrik Grunell <grunell@google.com> on 2011-09-14
Reviewed by Tony Gentilcore.
Tests for the MediaStream API will be provided by the bug 56587, pending enough landed code.
Source/WebCore:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitPeerConnectionEnabled):
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/call-a-constructor-as-a-function.html:
- platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
- 7:12 PM Changeset in webkit [95150] by
-
- 2 edits in trunk/Source/WebCore
Make sure to GC decoded images that are only used with WebGL
https://bugs.webkit.org/show_bug.cgi?id=67899
Patch by John Bauman <jbauman@chromium.org> on 2011-09-14
Reviewed by James Robinson.
Tell CachedImage that the WebGL image was drawn so WebGL-only
content will have decoded images collected.
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::extractImageData):
- 6:46 PM Changeset in webkit [95149] by
-
- 19 edits3 copies9 adds in trunk/LayoutTests
[chromium] rebaselines due to r95096, r95121, and r95129.
- platform/chromium-cg-mac-leopard/fast/borders/border-image-scaled-gradient-expected.png: Added.
- platform/chromium-cg-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
- platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
- platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.txt: Added.
- platform/chromium-cg-mac/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-linux/fast/borders/border-image-border-radius-expected.png:
- platform/chromium-linux/fast/borders/border-image-massive-scale-expected.png: Added.
- platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/fast/borders/border-image-01-expected.png:
- platform/chromium-win/fast/borders/border-image-border-radius-expected.png:
- platform/chromium-win/fast/borders/border-image-longhand-expected.png:
- platform/chromium-win/fast/borders/border-image-massive-scale-expected.png: Added.
- platform/chromium-win/fast/borders/border-image-massive-scale-expected.txt: Added.
- platform/chromium-win/fast/borders/border-image-repeat-expected.png:
- platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-win/fast/borders/border-image-scaled-expected.png:
- platform/chromium-win/fast/borders/border-image-scaled-gradient-expected.png: Added.
- platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-win/fast/borders/border-image-slices-expected.png:
- platform/chromium-win/fast/borders/border-image-source-expected.png:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- 6:32 PM Changeset in webkit [95148] by
-
- 19 edits in trunk/Source/WebCore
Added a pure virtual class CCLayerDelegate which helps to isolate
the chromium compositor from the rest of WebCore, and aids unit
testing by being easily mockable. The compositor layers no longer
directly see instances of GraphicsLayerChromium, instead they use
this interface.
https://bugs.webkit.org/show_bug.cgi?id=67750
Patch by Antoine Labour <piman@chromium.org> on 2011-09-14
Reviewed by James Robinson.
No new tests: changes already covered by existing compositing layout
tests.
- platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::CanvasLayerChromium):
- platform/graphics/chromium/CanvasLayerChromium.h:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerChromium::create):
(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::drawsContent):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::getDrawsContent):
(WebCore::GraphicsLayerChromium::getPreserves3D):
(WebCore::GraphicsLayerChromium::paintingGoesToWindow):
(WebCore::GraphicsLayerChromium::doPaintGraphicsLayerContents):
(WebCore::GraphicsLayerChromium::notifySyncRequired):
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::create):
(WebCore::ImageLayerChromium::ImageLayerChromium):
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::create):
(WebCore::LayerChromium::LayerChromium):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::CCLayerDelegate::~CCLayerDelegate):
(WebCore::LayerChromium::preserves3D):
(WebCore::LayerChromium::setOwner):
- platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::create):
(WebCore::PluginLayerChromium::PluginLayerChromium):
- platform/graphics/chromium/PluginLayerChromium.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::TiledLayerChromium):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::create):
(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::updateCompositorResources):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::create):
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
- platform/graphics/chromium/WebGLLayerChromium.h:
- 6:24 PM Changeset in webkit [95147] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG JIT always speculates that ValueAdd is a numeric addition
https://bugs.webkit.org/show_bug.cgi?id=67956
Reviewed by Geoffrey Garen.
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
- dfg/DFGJITCodeGenerator.h:
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateNumber):
- 6:22 PM Changeset in webkit [95146] by
-
- 7 edits1 move21 adds8 deletes in trunk/LayoutTests
[chromium] rebaselines due to r95121, r95070, and r95099.
- platform/chromium-cg-mac-leopard/fast/borders/border-image-border-radius-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-cg-mac-leopard/fast/borders/border-image-scaled-expected.png:
- platform/chromium-cg-mac-leopard/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-cg-mac/fast/borders/bidi-002-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/bidi-009a-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/bidi-012-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/block-mask-overlay-image-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/border-color-inherit-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/border-image-border-radius-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/border-image-massive-scale-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-cg-mac/fast/borders/border-image-scale-transform-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/border-image-scaled-expected.png:
- platform/chromium-cg-mac/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-cg-mac/fast/borders/inline-mask-overlay-image-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/outline-alpha-block-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/outline-alpha-inline-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/rtl-border-01-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/rtl-border-02-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/rtl-border-03-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/rtl-border-04-expected.png: Added.
- platform/chromium-cg-mac/fast/borders/rtl-border-05-expected.png: Added.
- platform/chromium-cg-mac/fast/writing-mode/border-image-horizontal-bt-expected.png: Added.
- platform/chromium-cg-mac/fast/writing-mode/border-image-vertical-lr-expected.png: Added.
- platform/chromium-cg-mac/fast/writing-mode/border-image-vertical-rl-expected.png: Added.
- platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Removed.
- platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.png: Removed.
- platform/chromium-linux/fast/borders/border-image-scrambled-expected.png: Removed.
- platform/chromium-linux/fast/borders/border-image-scrambled-expected.txt: Removed.
- platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.png: Removed.
- platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.txt: Removed.
- platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.png: Removed.
- platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.txt: Removed.
- platform/chromium-win/fast/borders/border-image-scrambled-expected.png: Added.
- platform/chromium-win/fast/borders/border-image-scrambled-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.txt.
- 5:50 PM Changeset in webkit [95145] by
-
- 2 edits in trunk/Source/JavaScriptCore
Stop building BinarySemaphore to see if that's what's breaking the GTK+ build.
- GNUmakefile.list.am:
- 5:48 PM Changeset in webkit [95144] by
-
- 2 edits in trunk/Source/JavaScriptCore
This is getting old. Yet another build fix attempt.
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- 5:39 PM Changeset in webkit [95143] by
-
- 2 edits in trunk/Source/JavaScriptCore
Yet another build fix attempt.
- JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
- 5:31 PM Changeset in webkit [95142] by
-
- 2 edits in trunk/Source/JavaScriptCore
How I "love" Visual Studio...
Try to fix build again.
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- 5:26 PM Changeset in webkit [95141] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix Windows build.
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- 5:15 PM Changeset in webkit [95140] by
-
- 6 edits3 copies in trunk/Source/JavaScriptCore
Add BinarySemaphore class from WebKit2 to WTF
https://bugs.webkit.org/show_bug.cgi?id=68132
Reviewed by Sam Weinig.
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
Update build systems.
- wtf/threads: Added.
- wtf/threads/BinarySemaphore.cpp: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.cpp.
- wtf/threads/BinarySemaphore.h: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.h.
- wtf/threads/win: Added.
- wtf/threads/win/BinarySemaphoreWin.cpp: Copied from Source/WebKit2/Platform/CoreIPC/win/BinarySemaphoreWin.cpp.
- 4:55 PM Changeset in webkit [95139] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for Interpreter.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- 4:44 PM Changeset in webkit [95138] by
-
- 2 edits in trunk/Source/WebCore
Try to fix GTK+ build.
- GNUmakefile.list.am:
- 4:27 PM Changeset in webkit [95137] by
-
- 1 edit2 adds in trunk/Source/JavaScriptCore
Add wtf/threads and wtf/threads/win, so we can be sure that the EWS
bots can correctly build the patch in https://bugs.webkit.org/show_bug.cgi?id=68132
Rubber-stamped by Sam Weinig.
- wtf/threads: Added.
- wtf/threads/win: Added.
- 4:06 PM Changeset in webkit [95136] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG JIT should not speculate integer if the value is always going to be
used as a double anyway
https://bugs.webkit.org/show_bug.cgi?id=68127
Reviewed by Oliver Hunt.
Added a ValueToDouble node, which is a variant of ValueToNumber that
hints that it will only be used as a double and never as an integer.
Thus, it turns off integer speculation even if the value profiler
told us that the value source is an int. The logic for converting a
ValueToNumber into a ValueToDouble is found in Propagator.
This appears to be a 22% speed-up in imaging-darkroom.
- dfg/DFGNode.h:
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- 4:01 PM Changeset in webkit [95135] by
-
- 18 edits in trunk/Source/WebCore
[chromium] LayerRendererChromium shouldn't be RefCounted
https://bugs.webkit.org/show_bug.cgi?id=68121
Reviewed by Kenneth Russell.
LayerRendererChromium is owned exclusively by CCLayerTreeHostImpl, so there's no reason to have it be
refcounted. Making it an OwnPtr<> makes the lifecycle for these objects much cleaner and reduces the chance of
introducing accidental reference cycles. This also removes the LayerRendererChromium pointers from CCLayerImpls
since it only needed at draw time.
Covered by compositing/ tests.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::drawLayer):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::draw):
(WebCore::CCLayerImpl::bindContentsTexture):
(WebCore::CCLayerImpl::drawDebugBorder):
- platform/graphics/chromium/cc/CCLayerImpl.h:
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
- platform/graphics/chromium/cc/CCPluginLayerImpl.h:
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::cleanupResources):
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):
- platform/graphics/chromium/cc/CCRenderSurface.h:
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::draw):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
- 4:00 PM Changeset in webkit [95134] by
-
- 17 edits1 add in trunk/Source/JavaScriptCore
Tiered compilation heuristics do not account for value profile fullness
https://bugs.webkit.org/show_bug.cgi?id=68116
Reviewed by Oliver Hunt.
Tiered compilation avoids invoking the DFG JIT if it finds that value
profiles contain insufficient information. Instead, it produces a
prediction from the current value profile, and then clears the value
profile. This allows the value profile to heat up from scratch for
some number of additional executions. The new profiles will then be
merged with the previous prediction. Once the amount of information
in predictions is enough according to heuristics in CodeBlock.cpp,
DFG optimization is allowed to proceed.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::visitWeakReferences):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):
- bytecode/CodeBlock.h:
- bytecode/PredictedType.cpp:
(JSC::predictionToString):
- bytecode/PredictedType.h:
- bytecode/ValueProfile.cpp: Added.
(JSC::ValueProfile::computeStatistics):
(JSC::ValueProfile::computeUpdatedPrediction):
- bytecode/ValueProfile.h:
(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::totalNumberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):
(JSC::getValueProfileBytecodeOffset):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::stronglyPredict):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
- jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
- jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- 3:44 PM Changeset in webkit [95133] by
-
- 9 edits in trunk/LayoutTests
Media element tests should look up controller element locations
https://bugs.webkit.org/show_bug.cgi?id=68038
Get the position of controller elements from the shadow DOM.
Reviewed by Darin Adler.
- media/audio-delete-while-slider-thumb-clicked.html:
- media/audio-delete-while-step-button-clicked.html:
- media/controls-drag-timebar.html:
- media/controls-right-click-on-timebar.html:
- media/video-controls-transformed.html:
- media/video-controls-visible-audio-only.html:
- media/video-controls-zoomed.html:
- media/video-volume-slider.html:
- 3:42 PM Changeset in webkit [95132] by
-
- 3 edits in trunk/Source/WebKit/chromium
Changed WebKit.gyp to use the new grit version of the scripts that handle
.pak files.
https://bugs.webkit.org/show_bug.cgi?id=68013
Patch by Nebojsa Ciric <cira@chromium.org> on 2011-09-14
Reviewed by Tony Chang.
- DEPS:
- WebKit.gyp:
- 3:37 PM Changeset in webkit [95131] by
-
- 2 edits13 adds in trunk/LayoutTests
[chromium] Update baselines due to r95070 and r95099.
- platform/chromium-cg-mac-leopard/fast/writing-mode/broken-ideographic-font-expected.png: Added.
- platform/chromium-cg-mac/fast/writing-mode/broken-ideographic-font-expected.png: Added.
- platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added.
- platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Added.
- platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.txt: Added.
- platform/chromium-linux/fast/borders/border-image-scrambled-expected.png: Added.
- platform/chromium-linux/fast/borders/border-image-scrambled-expected.txt: Added.
- platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.png: Added.
- platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.txt: Added.
- platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.png: Added.
- platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 3:31 PM Changeset in webkit [95130] by
-
- 10 edits4 deletes in trunk/Source
Get rid of WebCoreViewFactory and its WebViewFactory subclass
https://bugs.webkit.org/show_bug.cgi?id=68124
Reviewed by Sam Weinig.
../WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- editing/mac/FrameSelectionMac.mm:
- page/mac/FrameMac.mm:
- page/mac/WebCoreViewFactory.h: Removed.
- page/mac/WebCoreViewFactory.m: Removed.
../WebKit:
- WebKit.xcodeproj/project.pbxproj:
../WebKit/mac:
- WebCoreSupport/WebContextMenuClient.mm:
- WebCoreSupport/WebViewFactory.h: Removed.
- WebCoreSupport/WebViewFactory.mm: Removed.
- WebView/WebFrameView.mm:
(-[WebFrameView initWithFrame:]):
- 3:24 PM Changeset in webkit [95129] by
-
- 8 edits6 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=52736
Tiles were not being properly centered within border image sides for the "repeat"
keyword. This patch fixes the buggy math behind the pattern tiling to actually get
the initial phases correct.
Source/WebCore:
Reviewed by Sam Weinig.
Added new tests in fast/borders and updated broken existing tests.
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
LayoutTests:
Reviewed by Sam Weinig.
- fast/borders/border-image-massive-scale.html: Added.
- fast/borders/border-image-scaled-gradient.html: Added.
- platform/mac/fast/borders/border-image-massive-scale-expected.png: Added.
- platform/mac/fast/borders/border-image-massive-scale-expected.txt: Added.
- platform/mac/fast/borders/border-image-outset-expected.png:
- platform/mac/fast/borders/border-image-outset-in-shorthand-expected.png:
- platform/mac/fast/borders/border-image-outset-split-inline-expected.png:
- platform/mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png:
- platform/mac/fast/borders/border-image-scaled-gradient-expected.png: Added.
- platform/mac/fast/borders/border-image-scaled-gradient-expected.txt: Added.
- platform/mac/fast/borders/border-image-side-reduction-expected.png:
- 3:14 PM Changeset in webkit [95128] by
-
- 10 edits1 delete in trunk/Source/WebCore
Remove DocTypeStrings.gperf
https://bugs.webkit.org/show_bug.cgi?id=68119
Reviewed by Sam Weinig.
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/DocTypeStrings.gperf: Removed.
- make-hash-tools.pl:
- platform/HashTools.h:
- 3:04 PM Changeset in webkit [95127] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG should not speculate that the child of LogicalNot is a boolean if
predictions tell us otherwise
https://bugs.webkit.org/show_bug.cgi?id=68118
Reviewed by Geoffrey Garen.
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeLogicalNot):
- dfg/DFGJITCodeGenerator.h:
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 2:58 PM Changeset in webkit [95126] by
-
- 2 edits in trunk/LayoutTests
Change mousedown events to keydown events, since eventSender.mouseDown
wasn't firing onmousedown events on Mac.
https://bugs.webkit.org/show_bug.cgi?id=67960
Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-09-14
Reviewed by Adam Barth.
- fullscreen/full-screen-remove-ancestor-during-transition.html:
- 2:39 PM Changeset in webkit [95125] by
-
- 1 edit in branches/chromium/874/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
Merge 94982 - [chromium] Prevent a crash when tearing down an ImageBuffer that was not successfully initialized.
https://bugs.webkit.org/show_bug.cgi?id=67944
Patch by Jeff Timanus <twiz@chromium.org> on 2011-09-12
Reviewed by Stephen White.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::~ImageBuffer):
TBR=twiz@chromium.org
Review URL: http://codereview.chromium.org/7888057
- 2:39 PM Changeset in webkit [95124] by
-
- 2 edits in trunk/Source/WebCore
Address lifetime issues in OfflineAudioDestinationNode (take 2)
https://bugs.webkit.org/show_bug.cgi?id=68111
Reviewed by Kenneth Russell.
No new tests. This fixes existing layout tests.
- webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::startRendering):
(WebCore::OfflineAudioDestinationNode::render):
- 2:33 PM Changeset in webkit [95123] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix Chromium build.
- src/ResourceHandle.cpp:
- 2:29 PM Changeset in webkit [95122] by
-
- 10 edits2 adds in trunk
Source/WebKit2: Implement WKBundleFrameCopyWebArchive().
http://bugs.webkit.org/show_bug.cgi?id=67857
Reviewed by Anders Carlsson.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyWebArchive): Call WebFrame::webArchiveData() and create a WKDataRef from the returned CFDataRef.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::webArchiveData): Add WebFrame::webArchiveData().
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getWebArchiveOfFrame): Move the logic to WebFrame::webArchiveData() and call that method here.
Tools: Add test for WKBundleFrameCopyWebArchive().
https://bugs.webkit.org/show_bug.cgi?id=67857
Reviewed by Anders Carlsson.
- TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
the returned data is a valid webarchive.
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST): Load simple.html in a WebView. Wait for it to finish loading, and then ask the
injected bundle for the webarchive and check the returned webarchive.
- TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
(TestWebKitAPI::WebArchiveTest::WebArchiveTest):
(TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
the web archive.
Add files to project.
- TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
- TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 2:15 PM Changeset in webkit [95121] by
-
- 91 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=68103
Centered portions of border images don't render correctly. Make the tile scale factor have to be
explicitly passed in and modify paintNinePieceImage to compute it for all sides. The attempts to
implicitly compute the scale for the pattern based off the source and destination rects just don't
work, since the center image rects don't provide the right information to be able to infer the
scale factor.
Reviewed by Sam Weinig.
Reset all the existing fast/borders pixel results to Lion for these changes.
Source/WebCore:
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
- platform/graphics/Image.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage):
LayoutTests:
- platform/mac/fast/borders/bidi-002-expected.png:
- platform/mac/fast/borders/bidi-009a-expected.png:
- platform/mac/fast/borders/bidi-012-expected.png:
- platform/mac/fast/borders/block-mask-overlay-image-expected.png:
- platform/mac/fast/borders/border-antialiasing-expected.png:
- platform/mac/fast/borders/border-color-inherit-expected.png:
- platform/mac/fast/borders/border-fit-expected.png:
- platform/mac/fast/borders/border-image-01-expected.png:
- platform/mac/fast/borders/border-image-border-radius-expected.png:
- platform/mac/fast/borders/border-image-longhand-expected.png:
- platform/mac/fast/borders/border-image-omit-right-slice-expected.png:
- platform/mac/fast/borders/border-image-outset-expected.png:
- platform/mac/fast/borders/border-image-outset-in-shorthand-expected.png:
- platform/mac/fast/borders/border-image-repeat-expected.png:
- platform/mac/fast/borders/border-image-rotate-transform-expected.png:
- platform/mac/fast/borders/border-image-scale-transform-expected.png:
- platform/mac/fast/borders/border-image-scaled-expected.png:
- platform/mac/fast/borders/border-image-scrambled-expected.png:
- platform/mac/fast/borders/border-image-slices-expected.png:
- platform/mac/fast/borders/border-image-source-expected.png:
- platform/mac/fast/borders/border-radius-circle-expected.png:
- platform/mac/fast/borders/border-radius-constraints-expected.png:
- platform/mac/fast/borders/border-radius-different-width-001-expected.png:
- platform/mac/fast/borders/border-radius-groove-01-expected.png:
- platform/mac/fast/borders/border-radius-groove-02-expected.png:
- platform/mac/fast/borders/border-radius-groove-03-expected.png:
- platform/mac/fast/borders/border-radius-huge-assert-expected.png:
- platform/mac/fast/borders/border-radius-inline-flow-expected.png:
- platform/mac/fast/borders/border-radius-inset-outset-expected.png:
- platform/mac/fast/borders/border-radius-split-inline-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-01-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-02-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-03-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-04-expected.png:
- platform/mac/fast/borders/border-styles-split-expected.png:
- platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/mac/fast/borders/borderRadiusArcs01-expected.png:
- platform/mac/fast/borders/borderRadiusDashed01-expected.png:
- platform/mac/fast/borders/borderRadiusDashed02-expected.png:
- platform/mac/fast/borders/borderRadiusDashed03-expected.png:
- platform/mac/fast/borders/borderRadiusDashed04-expected.png:
- platform/mac/fast/borders/borderRadiusDashed05-expected.png:
- platform/mac/fast/borders/borderRadiusDashed06-expected.png:
- platform/mac/fast/borders/borderRadiusDotted01-expected.png:
- platform/mac/fast/borders/borderRadiusDotted02-expected.png:
- platform/mac/fast/borders/borderRadiusDotted03-expected.png:
- platform/mac/fast/borders/borderRadiusDotted04-expected.png:
- platform/mac/fast/borders/borderRadiusDotted05-expected.png:
- platform/mac/fast/borders/borderRadiusDotted06-expected.png:
- platform/mac/fast/borders/borderRadiusDouble01-expected.png:
- platform/mac/fast/borders/borderRadiusDouble02-expected.png:
- platform/mac/fast/borders/borderRadiusDouble03-expected.png:
- platform/mac/fast/borders/borderRadiusDouble04-expected.png:
- platform/mac/fast/borders/borderRadiusDouble05-expected.png:
- platform/mac/fast/borders/borderRadiusDouble06-expected.png:
- platform/mac/fast/borders/borderRadiusDouble07-expected.png:
- platform/mac/fast/borders/borderRadiusDouble08-expected.png:
- platform/mac/fast/borders/borderRadiusDouble09-expected.png:
- platform/mac/fast/borders/borderRadiusGroove01-expected.png:
- platform/mac/fast/borders/borderRadiusGroove02-expected.png:
- platform/mac/fast/borders/borderRadiusInset01-expected.png:
- platform/mac/fast/borders/borderRadiusInvalidColor-expected.png:
- platform/mac/fast/borders/borderRadiusOutset01-expected.png:
- platform/mac/fast/borders/borderRadiusRidge01-expected.png:
- platform/mac/fast/borders/borderRadiusSolid01-expected.png:
- platform/mac/fast/borders/borderRadiusSolid02-expected.png:
- platform/mac/fast/borders/borderRadiusSolid03-expected.png:
- platform/mac/fast/borders/borderRadiusSolid04-expected.png:
- platform/mac/fast/borders/different-color-borders-expected.png:
- platform/mac/fast/borders/fieldsetBorderRadius-expected.png:
- platform/mac/fast/borders/inline-mask-overlay-image-expected.png:
- platform/mac/fast/borders/mixed-border-styles-expected.png:
- platform/mac/fast/borders/mixed-border-styles-radius-expected.png:
- platform/mac/fast/borders/mixed-border-styles-radius2-expected.png:
- platform/mac/fast/borders/outline-alpha-block-expected.png:
- platform/mac/fast/borders/outline-alpha-inline-expected.png:
- platform/mac/fast/borders/outline-offset-min-assert-expected.png:
- platform/mac/fast/borders/rtl-border-01-expected.png:
- platform/mac/fast/borders/rtl-border-02-expected.png:
- platform/mac/fast/borders/rtl-border-03-expected.png:
- platform/mac/fast/borders/rtl-border-04-expected.png:
- platform/mac/fast/borders/rtl-border-05-expected.png:
- platform/mac/fast/borders/table-borders-expected.png:
- platform/mac/fast/borders/webkit-border-radius-expected.png:
- 2:03 PM Changeset in webkit [95120] by
-
- 9 edits in trunk/Source/WebCore
Get rid of ResourceHandle::bufferedData()
https://bugs.webkit.org/show_bug.cgi?id=68112
Reviewed by David Hyatt.
ResourceHandle::bufferedData() was only implemented on Mac, and the support in the underlying
NSURLConnection class hasn't been there for several OS releases.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::resourceData):
(WebCore::ResourceLoader::addData):
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp:
- platform/network/curl/ResourceHandleCurl.cpp:
- platform/network/mac/ResourceHandleMac.mm:
- platform/network/qt/ResourceHandleQt.cpp:
- platform/network/soup/ResourceHandleSoup.cpp:
- platform/network/win/ResourceHandleWin.cpp:
- 1:59 PM Changeset in webkit [95119] by
-
- 2 edits in trunk
[GTK] Unreviewed buildfix after r95107.
- configure.ac:
- 1:58 PM Changeset in webkit [95118] by
-
- 5 edits in trunk/Tools
committers.py should support multiple IRC nicknames
https://bugs.webkit.org/show_bug.cgi?id=68110
Reviewed by Eric Seidel.
Add multiple IRC nickname support to committers.py
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/committers_unittest.py:
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/sheriff.py:
- 1:51 PM Changeset in webkit [95117] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION: r95108 broke Qt Linux tests
https://bugs.webkit.org/show_bug.cgi?id=68104
Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-14
Reviewed by Csaba Osztrogonác.
No new tests.
Build fix for Qt tests broken in r95108.
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
- bridge/qt/qt_runtime.h:
- 1:48 PM Changeset in webkit [95116] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix. Turn off tiered compilation.
- wtf/Platform.h:
- 1:35 PM Changeset in webkit [95115] by
-
- 14 edits2 adds in trunk/Source/JavaScriptCore
Prediction tracking is not precise enough
https://bugs.webkit.org/show_bug.cgi?id=67993
Reviewed by Oliver Hunt.
Added a richer set of type predictions, including JSFinalObject, JSString,
object that is not a JSFinalObject or JSArray (ObjectOther), some object
but we don't or care know what kind (SomeObject), definitely an object,
cell that is not an object or JSString, an value that is none of the above
(so either Undefined or Null). Made the propagator and value profiler work
with the new types.
Performance is neutral, because the DFG JIT does not take advantage of this
new knowledge yet.
In the process of writing predictionToString() (which is now considerably
more complex) I decided to finally add a BoundsCheckedPointer, which
should come in handy in other places, like at least the OSR scratch buffer
and the CompactJITCodeMap. It's great for cases where you want to
do pointer arithmetic, you want to have assertions about the
pointer not going out of bounds, but you don't want to write those
assertions yourself.
This also required refactoring inherits(), since the ValueProfiler may
want to do the equivalent of inherits() but given two ClassInfo's.
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/PredictedType.cpp: Added.
(JSC::predictionToString):
(JSC::makePrediction):
(JSC::predictionFromValue):
- bytecode/PredictedType.h:
(JSC::isCellPrediction):
(JSC::isObjectPrediction):
(JSC::isFinalObjectPrediction):
(JSC::isStringPrediction):
(JSC::mergePredictions):
- bytecode/ValueProfile.h:
(JSC::ValueProfile::numberOfObjects):
(JSC::ValueProfile::numberOfFinalObjects):
(JSC::ValueProfile::numberOfStrings):
(JSC::ValueProfile::probabilityOfObject):
(JSC::ValueProfile::probabilityOfFinalObject):
(JSC::ValueProfile::probabilityOfString):
(JSC::ValueProfile::dump):
(JSC::ValueProfile::Statistics::Statistics):
(JSC::ValueProfile::computeStatistics):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::stronglyPredict):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
- dfg/DFGNode.h:
(JSC::DFG::Node::predict):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
- runtime/ClassInfo.h:
(JSC::ClassInfo::isSubClassOf):
- runtime/JSObject.h:
(JSC::JSCell::inherits):
- wtf/BoundsCheckedPointer.h: Added.
(WTF::BoundsCheckedPointer::BoundsCheckedPointer):
(WTF::BoundsCheckedPointer::operator=):
(WTF::BoundsCheckedPointer::operator+=):
(WTF::BoundsCheckedPointer::operator-=):
(WTF::BoundsCheckedPointer::operator+):
(WTF::BoundsCheckedPointer::operator-):
(WTF::BoundsCheckedPointer::operator++):
(WTF::BoundsCheckedPointer::operator--):
(WTF::BoundsCheckedPointer::operator<):
(WTF::BoundsCheckedPointer::operator<=):
(WTF::BoundsCheckedPointer::operator>):
(WTF::BoundsCheckedPointer::operator>=):
(WTF::BoundsCheckedPointer::operator==):
(WTF::BoundsCheckedPointer::operator!=):
(WTF::BoundsCheckedPointer::operator!):
(WTF::BoundsCheckedPointer::get):
(WTF::BoundsCheckedPointer::operator*):
(WTF::BoundsCheckedPointer::operator[]):
(WTF::BoundsCheckedPointer::strcat):
(WTF::BoundsCheckedPointer::validate):
- wtf/CMakeLists.txt:
- 1:12 PM Changeset in webkit [95114] by
-
- 3 edits in trunk/Source/WebCore
[skia] fast/canvas/setWidthResetAfterForcedRender is flaky
https://bugs.webkit.org/show_bug.cgi?id=67955
Reviewed by Stephen White.
When destroying an ImageBuffer due to a canvas resize, we weren't clearing the texture ID on the layer,
resulting in future compositor draw calls binding an invalid texture. This results in the test failing and
possibly drawing from a bad texture.
Covered by fast/canvas/setWidthResetAfterForcedRender.html in the GPU configuration.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::drawsContent)
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::~ImageBuffer):
- 1:05 PM Changeset in webkit [95113] by
-
- 2 edits in trunk/Source/WebKit2
Web Process doesn't need a permission to look up WebProcess service any more
https://bugs.webkit.org/show_bug.cgi?id=68101
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb:
- 1:02 PM Changeset in webkit [95112] by
-
- 7 edits in trunk
Remove ENABLE_SVG_USE as <use> is required by HTML5
https://bugs.webkit.org/show_bug.cgi?id=68019
Reviewed by Ryosuke Niwa.
I missed a couple uses of SVG_USE in my previous patch.
Source/WebCore:
- dom/DOMImplementation.cpp:
(WebCore::isSVG10Feature):
(WebCore::isSVG11Feature):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
- svg/SVGUseElement.h:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 12:25 PM Changeset in webkit [95111] by
-
- 2 edits in trunk/LayoutTests
Update media-controls.js so it can find the timeline slider
https://bugs.webkit.org/show_bug.cgi?id=68034
Don't assume that all elements in the media controller shadow DOM pseudo
elements are siblings.
Reviewed by Darin Adler.
- media/media-controls.js:
(mediaConrolsElement):
(mediaControlsButtonCoordinates):
- 12:10 PM Changeset in webkit [95110] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Qt] Win32 builds with threads turned off
https://bugs.webkit.org/show_bug.cgi?id=67864
Reviewed by Geoffrey Garen.
- JavaScriptCore.pri: Link pthread library on Windows platform.
- wtf/Platform.h: Enable multiple threads.
- 12:00 PM Changeset in webkit [95109] by
-
- 4 edits in trunk/Tools
Implement globalFlag for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=68033
<rdar://problem/10119204>
Reviewed by Sam Weinig.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
(WTR::LayoutTestController::globalFlag): simple getter
(WTR::LayoutTestController::setGlobalFlag): simple setter
- 11:55 AM Changeset in webkit [95108] by
-
- 81 edits in trunk/Source
Unzip initialization lists and constructors in JSCell hierarchy (6/7)
https://bugs.webkit.org/show_bug.cgi?id=67692
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.
- API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::JSCallbackFunction):
- API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::create):
- jsc.cpp:
(GlobalObject::create):
(GlobalObject::GlobalObject):
- runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
- runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::create):
- runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
- runtime/BooleanConstructor.h:
(JSC::BooleanConstructor::create):
- runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
- runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::create):
- runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
- runtime/DateConstructor.h:
(JSC::DateConstructor::create):
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
- runtime/DatePrototype.h:
(JSC::DatePrototype::create):
- runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
- runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
- runtime/ErrorConstructor.h:
(JSC::ErrorConstructor::create):
- runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
- runtime/FunctionConstructor.h:
(JSC::FunctionConstructor::create):
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
- runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::create):
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
- runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::create):
- runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::finishCreation):
- runtime/NativeErrorPrototype.h:
(JSC::NativeErrorPrototype::create):
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
- runtime/NumberConstructor.h:
(JSC::NumberConstructor::create):
- runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
- runtime/NumberPrototype.h:
(JSC::NumberPrototype::create):
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
- runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::create):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
- runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::create):
- runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
- runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::create):
- runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
- runtime/StringConstructor.h:
(JSC::StringConstructor::create):
- runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::create):
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
- runtime/StringPrototype.h:
(JSC::StringPrototype::create):
Source/JavaScriptGlue:
Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.
- JSRun.cpp:
(JSGlueGlobalObject::JSGlueGlobalObject):
- JSRun.h:
(JSGlueGlobalObject::create):
Source/WebCore:
No new tests.
Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.
- WebCore.exp.in:
- bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
(WebCore::DOMConstructorWithDocument::finishCreation):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSWorkerContextBase.cpp:
(WebCore::JSWorkerContextBase::JSWorkerContextBase):
(WebCore::JSWorkerContextBase::finishCreation):
- bindings/js/JSWorkerContextBase.h:
- bindings/scripts/CodeGeneratorJS.pm:
Added a finishCreation declaration and Moved the finishCreation call into the
create method for all classes except for subclasses of JSWorkerContextBase and
JSDOMWindowBase because those classes are on the next level, and it's easier
to do all of these classes in one fell swoop rather than level by level.
(GenerateHeader):
Added the implementation of the finishCreation method for the classes described above.
(GenerateImplementation):
Also added the finishCreation calls to the autogenerated DOM constructor classes.
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
(WebCore::JSTestInterfaceConstructor::finishCreation):
(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterface::finishCreation):
- bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterface::create):
(WebCore::JSTestInterfacePrototype::create):
(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListener::finishCreation):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::create):
(WebCore::JSTestMediaQueryListListenerPrototype::create):
(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::JSTestObjConstructor):
(WebCore::JSTestObjConstructor::finishCreation):
(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::finishCreation):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::create):
(WebCore::JSTestObjPrototype::create):
(WebCore::JSTestObjPrototype::JSTestObjPrototype):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::finishCreation):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::create):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::create):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
- bridge/c/CRuntimeObject.cpp:
(JSC::Bindings::CRuntimeObject::CRuntimeObject):
- bridge/c/CRuntimeObject.h:
(JSC::Bindings::CRuntimeObject::create):
- bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
(JSC::Bindings::CRuntimeMethod::finishCreation):
- bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaRuntimeMethod::JavaRuntimeMethod):
(JavaRuntimeMethod::finishCreation):
- bridge/jni/jsc/JavaRuntimeObject.cpp:
(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
- bridge/jni/jsc/JavaRuntimeObject.h:
(JSC::Bindings::JavaRuntimeObject::create):
- bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::create):
- bridge/objc/ObjCRuntimeObject.mm:
(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
- bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::ObjCRuntimeMethod):
(ObjCRuntimeMethod::finishCreation):
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::create):
(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntimeObject::create):
(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeMetaMethod::finishCreation):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::finishCreation):
- bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMetaMethod::create):
- bridge/runtime_method.cpp:
(JSC::RuntimeMethod::RuntimeMethod):
- bridge/runtime_method.h:
(JSC::RuntimeMethod::create):
Source/WebKit/mac:
Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
(WebKit::ProxyRuntimeMethod::finishCreation):
Source/WebKit2:
Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.
This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::JSNPMethod):
- WebProcess/Plugins/Netscape/JSNPMethod.h:
(WebKit::JSNPMethod::create):
- 11:49 AM Changeset in webkit [95107] by
-
- 24 edits in trunk
Remove ENABLE_SVG_USE as <use> is required by HTML5
https://bugs.webkit.org/show_bug.cgi?id=68019
Reviewed by Ryosuke Niwa.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- features.pri:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/build-webkit:
- waf/build/settings.py:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 11:47 AM Changeset in webkit [95106] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed; new baselines (Skia on Mac)
Updated reference images (missed this one on the prior land)
- platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added.
- 11:46 AM Changeset in webkit [95105] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed; new baselines (Skia on Mac)
Updated reference images.
- platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Removed.
- platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added.
- 11:41 AM Changeset in webkit [95104] by
-
- 2 edits in trunk/Source/WebCore
MediaPlayerPrivateAVFoundationObjC's "periodic time observer" is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=68056
MediaPlayerPrivateAVFoundationObjC creates a "periodic time observer" not because it wants
periodic callbacks, but because a time observer also fires whenever a seek completes. This is
no longer necessary because it now uses but AVPlayerItem's
-seekToTime:toleranceBefore:toleranceAfter:completionHandler to seek, so seek completions are
always notified.
Reviewed by Darin Adler.
No new tests, code removed is tested by existing tests.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
- 11:35 AM Changeset in webkit [95103] by
-
- 4 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=68054
Return an image scale factor as well as an Image* from CachedImage::brokenImage()
Reviewed by Darin Adler.
CachedImage::brokenImage() now returns a pair<Image*, float> where the float
represents the image's scale factor. This is important because currently, the
broken image will either be only 1x or 2x, but a deviceScaleFactor could
theoretically be something different (1.5, 3, etc). So it is not safe to assume
that the image's scale factor is equivalent to the deviceScaleFactor, and
hardcoding 2 for now is lame.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::brokenImage):
(WebCore::CachedImage::image):
- loader/cache/CachedImage.h:
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
(WebCore::RenderImage::paintReplaced):
- 11:27 AM Changeset in webkit [95102] by
-
- 2 edits in trunk/LayoutTests
video-error-abort.html shouldn't be in Mac skipped list
https://bugs.webkit.org/show_bug.cgi?id=68053
<rdar://problem/6710625> Test media/video-error-abort.html doesn't work
Reviewed by Darin Adler.
- platform/mac/Skipped: Remove http/tests/media/video-error-abort.html from the mac
skipped list.
- 11:05 AM Changeset in webkit [95101] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
Removing fast/canvas/setWidthResetAfterForcedRender.html from
test_expectations, since it has been passing on the Mesa bots
(last failure was at r94962).
- 11:02 AM Changeset in webkit [95100] by
-
- 34 edits3 adds in trunk
[chromium] Move contents texture manager from LayerRendererChromium to CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=67440
Reviewed by Kenneth Russell.
This moves the contents TextureManager over to the CCLayerTreeHost, where it belongs, and adds in a commit path
to make sure that textures are deleted even if the page is not visible. This move also removed the need for
LayerRendererChromium's CCLayerTreeHost pointer, so I removed that as well. That meant moving the
layerTreeAsText() logic over to the CCLayerImpl side, which is where it really belonged anyway.
Covered by existing compositing/ tests and
platform/chromium/compositor/lost-compositor-context-with-rendersurface.html
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::setContentsTextureMemoryUseBytes):
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):
(WebCore::TextureManager::lowLimitBytes):
- platform/graphics/chromium/TextureManager.h:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTextures):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::contentsTextureManager):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setVisible):
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
- 10:58 AM Changeset in webkit [95099] by
-
- 4 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=68040
Make sure border image sub-properties can be specified in any order.
Reviewed by Beth Dakin.
Source/WebCore:
New tests in fast/borders.
- css/CSSParser.cpp:
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::canAdvance):
(WebCore::BorderImageParseContext::setCanAdvance):
(WebCore::BorderImageParseContext::allowCommit):
(WebCore::BorderImageParseContext::allowImage):
(WebCore::BorderImageParseContext::allowImageSlice):
(WebCore::BorderImageParseContext::allowSlash):
(WebCore::BorderImageParseContext::requireWidth):
(WebCore::BorderImageParseContext::requireOutset):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):
- css/CSSParserValues.h:
(WebCore::CSSParserValueList::previous):
LayoutTests:
- fast/borders/border-image-scrambled.html: Added.
- platform/mac/fast/borders/border-image-scrambled-expected.png: Added.
- platform/mac/fast/borders/border-image-scrambled-expected.txt: Added.
- 10:16 AM Changeset in webkit [95098] by
-
- 2 edits in trunk/Tools
Remove Jan Erik Hanssen (added in my r95078) from the list for now
since I can't confirm acceptable his committership.
- Scripts/webkitpy/common/config/committers.py:
- 10:04 AM Changeset in webkit [95097] by
-
- 2 edits in trunk/Source/WebCore
query SystemParametersInfo for GDI font smoothing settings
https://bugs.webkit.org/show_bug.cgi?id=68080
Reviewed by Stephen White.
No new tests. fixes antialiasing issues based on User settings
- platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::getDefaultGDITextFlags):
(WebCore::setupPaintForFont):
- 9:45 AM Changeset in webkit [95096] by
-
- 10 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=68050
Regressions in some layout tests from making border/mask/reflection nine-piece-image
parsing match the spec, which allows any of the pieces to be omitted and to also be
specifiable in any order.
When the higher level code suddenly allowed the image slices to be omitted, the fixup
for legacy compatibility for reflections and masks in the parseBorderImageSlice function
no longer happened because that function no longer got called.
The fix is to properly set the defaults to include the "fill" keyword, so the fixup is
applied to the NinePieceImages you create before you ever map anything in from the rules.
This also has the side effect of fixing -webkit-max-box-image-slice to actually dump as
"0 fill" instead of just "0", which is the correct initial value for this property.
Reviewed by Adam Roben.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseBorderImageSlice):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
- rendering/style/StyleReflection.h:
(WebCore::StyleReflection::StyleReflection):
LayoutTests:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 9:27 AM Changeset in webkit [95095] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. timeline-animation-frame.html was marked as TEXT.
- platform/qt/test_expectations.txt:
- 8:54 AM Changeset in webkit [95094] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. timeline-animation-frame.html was marked as TIMEOUT.
- platform/qt/test_expectations.txt:
- 8:09 AM Changeset in webkit [95093] by
-
- 6 edits in trunk/Source/WebCore
2011-09-13 Pavel Feldman <pfeldman@google.com>
Web Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has been reset.
https://bugs.webkit.org/show_bug.cgi?id=67997
We should not instrument frameDestroyed event from within Frame's destructor
since frame's m_page pointer is likely to be 0 by that time and appropriate
instrumenting agent won't be found. As a result, stale frame with its id
end up in the inspector.
This change wipes out frame binding from the inspector upon detach rather
than destroy.
Reviewed by Tony Gentilcore.
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::frameDetachedImpl):
- inspector/InspectorInstrumentation.h:
- inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::frameDetached):
- inspector/InspectorPageAgent.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent):
- page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::detachFromPage):
- page/Frame.h:
- 7:59 AM Changeset in webkit [95092] by
-
- 6 edits in trunk/Source/WebCore
2011-09-14 Pavel Feldman <pfeldman@google.com>
Not reviewed: rolling out r95089.
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::frameDestroyedImpl): (WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::frameWindowDiscarded): (WebCore::InspectorInstrumentation::domContentLoadedEventFired): (WebCore::InspectorInstrumentation::loadEventFired): (WebCore::InspectorInstrumentation::didCommitLoad): (WebCore::InspectorInstrumentation::frameDestroyed):
- inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::frameDetached): (WebCore::InspectorPageAgent::frameDestroyed):
- inspector/InspectorPageAgent.h:
- page/Frame.cpp: (WebCore::Frame::~Frame):
- 7:56 AM WebKit Team edited by
- Remove "WINCE port" from my name (diff)
- 7:34 AM Changeset in webkit [95091] by
-
- 17 edits3 adds in trunk
Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=67986
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/timeline/timeline-animation-frame.html
- English.lproj/localizedStrings.js:
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::callFunctionWithoutFrame):
(WebCore::V8Proxy::instrumentedCallFunction):
- bindings/v8/V8Proxy.h:
- bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl):
(WebCore::InspectorInstrumentation::didFireAnimationFrameEventImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallback):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameCallback):
(WebCore::InspectorInstrumentation::willFireAnimationFrameEvent):
(WebCore::InspectorInstrumentation::didFireAnimationFrameEvent):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
(WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createAnimationFrameCallbackData):
- inspector/TimelineRecordFactory.h:
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
LayoutTests:
- inspector/timeline/timeline-animation-frame-expected.txt: Added.
- inspector/timeline/timeline-animation-frame.html: Added.
- inspector/timeline/timeline-enum-stability-expected.txt:
- platform/chromium/inspector/timeline/timeline-enum-stability-expected.txt:
- inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.performActions.step2):
(initialize_Timeline.InspectorTest.performActions):
(initialize_Timeline.InspectorTest.performActionsAndPrint):
- 7:20 AM Changeset in webkit [95090] by
-
- 3 edits in trunk/Source/JavaScriptCore
HashTraits.h should include template specialization for WTF::String
https://bugs.webkit.org/show_bug.cgi?id=67851
Ensure that the template specialization for HashTraits<String> is always
picked up. (Previously it was possible to include HashSet and String but
not the correct HashTraits, so you would get an inefficient template
instantiation.)
Patch by Iain Merrick <husky@google.com> on 2011-09-14
Reviewed by Darin Adler.
- wtf/HashTraits.h:
- wtf/text/StringHash.h:
- 7:14 AM Changeset in webkit [95089] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has been reset.
https://bugs.webkit.org/show_bug.cgi?id=67997
We should not instrument frameDestroyed event from within Frame's destructor
since frame's m_page pointer is likely to be 0 by that time and appropriate
instrumenting agent won't be found. As a result, stale frame with its id
end up in the inspector.
This change wipes out frame binding from the inspector upon detach rather
than destroy + adds an assertion into the inspector agents lookup with 0 page.
Reviewed by Tony Gentilcore.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameDetachedImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::frameWindowDiscarded):
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
(WebCore::InspectorInstrumentation::frameDetached):
(WebCore::InspectorInstrumentation::didCommitLoad):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameDetached):
- inspector/InspectorPageAgent.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::detachFromParent):
- page/Frame.cpp:
(WebCore::Frame::~Frame):
(WebCore::Frame::detachFromPage):
(WebCore::Frame::transferChildFrameToNewDocument):
- page/Frame.h:
- 6:52 AM Changeset in webkit [95088] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] Add NULL checks to ewk_window_features_new_from_core and ewk_view_window_create.
https://bugs.webkit.org/show_bug.cgi?id=64932
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-09-14
Reviewed by Eric Seidel.
It prevents the crash while allocating memory for the new window.
- ewk/ewk_view.cpp:
(ewk_view_window_create):
- ewk/ewk_window_features.cpp:
(ewk_window_features_new_from_core):
- 6:41 AM Changeset in webkit [95087] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium test expectations.
- platform/chromium/test_expectations.txt: fix lint-test-files error
- 3:06 AM Changeset in webkit [95086] by
-
- 1 edit1 add in trunk/LayoutTests
page-transition-event-constructor-expected.txt is missing
https://bugs.webkit.org/show_bug.cgi?id=68069
Reviewed by Hajime Morita.
- fast/events/constructors/page-transition-event-constructor-expected.txt: Added.
- 2:48 AM Changeset in webkit [95085] by
-
- 3 edits in trunk/Tools
[chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=68066
Reviewed by Adam Barth.
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
- 2:41 AM Changeset in webkit [95084] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r95080.
http://trac.webkit.org/changeset/95080
https://bugs.webkit.org/show_bug.cgi?id=68070
It caused some 2d.composite.uncovered tests fail (Requested by
rgabor on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-14
Source/WebCore:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):
LayoutTests:
- fast/canvas/canvas-large-fills-expected.txt: Removed.
- fast/canvas/canvas-large-fills.html: Removed.
- 2:29 AM Changeset in webkit [95083] by
-
- 4 edits3 adds in trunk
Web Inspector: [v8] building call frame info for location-less internal script function crashes.
https://bugs.webkit.org/show_bug.cgi?id=67991
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/debugger/debugger-pause-in-internal.html
- bindings/v8/DebuggerScript.js:
():
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::currentCallFrame):
LayoutTests:
- inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
- inspector/debugger/debugger-pause-in-internal.html: Added.
- inspector/debugger/debugger-pause-on-exception-crash-expected.txt: Added.
- platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
- 1:31 AM Changeset in webkit [95082] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium test expecations.
- 1:25 AM Changeset in webkit [95081] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed, update test expectations for
svg/custom/dynamic-svg-document-creation.svg after r95030
- platform/qt/svg/custom/dynamic-svg-document-creation-expected.png:
- platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt:
- 1:10 AM Changeset in webkit [95080] by
-
- 3 edits2 adds in trunk
Large canvas fills should not crash or create unnecessarily large image buffers
https://bugs.webkit.org/show_bug.cgi?id=67988
Source/WebCore:
When using source-in, destination-in, source-out, or destination-atop a temporary
buffer is created. This buffer only needs to be big enough to cover the intersection
of the path and the canvas.
This change also adds some null checks for failures to create contexts or buffers.
Patch by Ben Wells <benwells@chromium.org> on 2011-09-14
Reviewed by Stephen White.
Test: fast/canvas/canvas-large-fills.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):
LayoutTests:
Patch by Ben Wells <benwells@chromium.org> on 2011-09-14
Reviewed by Stephen White.
- fast/canvas/canvas-large-fills-expected.txt: Added.
- fast/canvas/canvas-large-fills.html: Added.
- 12:40 AM Changeset in webkit [95079] by
-
- 9 edits1 add in trunk
Implement a PageTransitionEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68048
Reviewed by Sam Weinig.
Source/WebCore:
The spec for the PageTransitionEvent constructor is here:
http://www.whatwg.org/specs/web-apps/current-work/#pagetransitionevent
Test: fast/events/constructors/page-transition-event-constructor.html
- bindings/generic/EventConstructors.h: Added a definition for the PageTransitionEvent constructor.
- bindings/js/JSEventConstructors.cpp: Added #includes for PageTransitionEvent.
- dom/PageTransitionEvent.cpp:
(WebCore::PageTransitionEventInit::PageTransitionEventInit):
(WebCore::PageTransitionEvent::PageTransitionEvent):
(WebCore::PageTransitionEvent::initPageTransitionEvent):
- dom/PageTransitionEvent.h: Added a definition for PageTransitionEventInit.
(WebCore::PageTransitionEvent::create):
(WebCore::PageTransitionEvent::isPageTransitionEvent):
(WebCore::PageTransitionEvent::persisted):
- dom/PageTransitionEvent.idl: Makes PageTransitionEvent constructible.
LayoutTests:
page-transition-event-constructor.html checks the behavior of the PageTransitionEvent constructor.
- fast/dom/constructed-objects-prototypes-expected.txt: Added PageTransitionEvent.
- fast/events/constructors/page-transition-event-constructor-expected.txt: Added.
- fast/events/constructors/page-transition-event-constructor.html: Added.
- platform/chromium/test_expectations.txt: Skipped page-transition-event-constructor.html, since V8 does not yet have the PageTransitionEvent constructor.
Sep 13, 2011:
- 11:58 PM Changeset in webkit [95078] by
-
- 2 edits in trunk/Tools
committers.py is missing some contributors
https://bugs.webkit.org/show_bug.cgi?id=68059
Reviewed by Adam Barth.
Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
- Scripts/webkitpy/common/config/committers.py:
- 11:46 PM Changeset in webkit [95077] by
-
- 4 edits3 deletes in trunk
Unreviewed, rolling out r95058.
http://trac.webkit.org/changeset/95058
https://bugs.webkit.org/show_bug.cgi?id=68058
It made css3/calc/regression-62276.html crash (Requested by
Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-13
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::allowBreak):
(WebCore::BorderImageParseContext::allowWidth):
(WebCore::BorderImageParseContext::allowOutset):
(WebCore::BorderImageParseContext::allowRepeat):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):
- css/CSSParserValues.h:
LayoutTests:
- fast/borders/border-image-scrambled.html: Removed.
- platform/mac/fast/borders/border-image-scrambled-expected.png: Removed.
- platform/mac/fast/borders/border-image-scrambled-expected.txt: Removed.
- 11:32 PM Changeset in webkit [95076] by
-
- 2 edits in trunk/Tools
Fix webkit python test after r95061.
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- 9:37 PM Changeset in webkit [95075] by
-
- 2 edits in trunk/Tools
Add wangxianzhu@chromium.org as a contributor.
- 9:19 PM Changeset in webkit [95074] by
-
- 3 edits2 adds in trunk
Crash in RenderScrollbarPart::imageChanged.
https://bugs.webkit.org/show_bug.cgi?id=68009
Reviewed by Simon Fraser.
Source/WebCore:
When a custom scrollbar is removed from its FrameView, its destruction
can be delayed because of RefPtr maintained in EventHandler class
(m_lastScrollbarUnderMouse). Upon removal, we delete all the scrollbar
parts so that they don't link back to scrollbar. However, because of the
delay, we can have a call to updateScrollbarPart which recreates it.
When scrollbar is getting destroyed, we just check to see if there are
remaining scrollbar parts and if yes, we destroy them.
Test: scrollbars/scrollbar-part-created-with-no-parent-crash.html
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::~RenderScrollbar):
LayoutTests:
- scrollbars/scrollbar-part-created-with-no-parent-crash-expected.txt: Added.
- scrollbars/scrollbar-part-created-with-no-parent-crash.html: Added.
- 8:36 PM Changeset in webkit [95073] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium test expectations.
- platform/chromium/test_expectations.txt: failures on GPU starting from r95058
- 7:45 PM Changeset in webkit [95072] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium test expectations.
- platform/chromium/test_expectations.txt: failures starting from r95058
- 7:09 PM Changeset in webkit [95071] by
-
- 3 edits2 adds in trunk
Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized read
https://bugs.webkit.org/show_bug.cgi?id=68021
Reviewed by Tony Chang.
Source/WebCore:
Reported by valgrind in http://crbug.com/60653.
Besides fixing the uninitialized read, add support for outputting the
list separator for counters() calls and the list-style name.
Test: fast/css/counters/counter-cssText.html
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText):
LayoutTests:
- fast/css/counters/counter-cssText-expected.txt: Added.
- fast/css/counters/counter-cssText.html: Added.
- 6:58 PM Changeset in webkit [95070] by
-
- 3 edits3 adds in trunk
WebFont followed tiny monospace text displays weird
https://bugs.webkit.org/show_bug.cgi?id=67996
Reviewed by Darin Adler.
Source/WebCore:
Always call wkSetCGFontRenderingMode() in Font::drawGlyphs() so that the rendering mode is set correctly.
Test: platform/mac/fast/text/webfont-after-tiny-monospace-text.html
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
LayoutTests:
This test ensures that webfont followed tiny monospace text is displayed correctly.
- platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.png: Added.
- platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.txt: Added.
- platform/mac/fast/text/webfont-after-tiny-monospace-text.html: Added.
- 6:24 PM Changeset in webkit [95069] by
-
- 6 edits in trunk/Tools
garden-o-matic has unfriendly error messages when the local server is not available
https://bugs.webkit.org/show_bug.cgi?id=68042
Reviewed by Dimitri Glazkov.
This patch moves us from using alert to showing the error inline in the
progress dialog.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- 6:23 PM Changeset in webkit [95068] by
-
- 5 edits in trunk/Tools
FailureGrid in garden-o-matic should link to the builder's waterfall page
https://bugs.webkit.org/show_bug.cgi?id=68036
Reviewed by Dimitri Glazkov.
One of the users in the user study thought the configurations names in
the failure grid would link to the underlying bots. That makes sense,
so this patch adds the behavior.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
- 6:21 PM Changeset in webkit [95067] by
-
- 6 edits in trunk/Tools
garden-o-matic should be able to mark failures as expected
https://bugs.webkit.org/show_bug.cgi?id=68027
Reviewed by Dimitri Glazkov.
All the back-end infrastructure exists for this operation. This patch
just adds some UI to the front-end and wires that UI up to the back
end. This exact UI will likely need some more polish, but this should
be a reasonable first cut.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- 6:20 PM Changeset in webkit [95066] by
-
- 7 edits in trunk/Tools
garden-o-matic should tell you about the progress of your rebaseline
https://bugs.webkit.org/show_bug.cgi?id=67967
Reviewed by Dimitri Glazkov.
This patch adds ui.MessageBox, which is a light wrapper around jQuery
UI's dialog widget. We then use ui.MessageBox to show status messages
about in-progress rebaselines. As each baseline is downloaded, the
MessageBox updates. This UI replaces our temporary "alert"-based UI.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
- 6:19 PM Changeset in webkit [95065] by
-
- 7 edits6 adds in trunk
Fix XSS auditor bypass when inline handlers contain comments.
https://bugs.webkit.org/show_bug.cgi?id=27895
Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-13
Reviewed by Adam Barth.
Source/WebCore:
Tests: http/tests/security/xssAuditor/property-escape-comment.html
http/tests/security/xssAuditor/property-escape-entity.html
http/tests/security/xssAuditor/property-escape-quote.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::snippetForAttribute):
LayoutTests:
- http/tests/security/xssAuditor/malformed-HTML-expected.txt:
- http/tests/security/xssAuditor/open-attribute-body-expected.txt:
- http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-comment.html: Added.
- http/tests/security/xssAuditor/property-escape-entity-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-entity.html: Added.
- http/tests/security/xssAuditor/property-escape-quote-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape-quote.html: Added.
- http/tests/security/xssAuditor/resources/echo-property.pl:
- 6:13 PM Changeset in webkit [95064] by
-
- 2 edits1 add in trunk/LayoutTests
Update chromium-mac test expectations
https://bugs.webkit.org/show_bug.cgi?id=67917
Reviewed by Darin Adler.
- platform/chromium-cg-mac-leopard/svg/custom/simple-text-double-shadow-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 6:05 PM Changeset in webkit [95063] by
-
- 5 edits in trunk
Implement a HashChangeEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67969
Reviewed by Nate Chapin.
Source/WebCore:
Test: fast/events/constructors/hash-change-event-constructor.html
- bindings/v8/custom/V8EventConstructors.cpp: Added the HashChangeEvent constructor.
- dom/HashChangeEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled hash-change-event-constructor.html, since now V8 has a HashChangeEvent constructor.
- platform/chromium/test_expectations.txt:
- 6:03 PM Changeset in webkit [95062] by
-
- 2 edits in trunk/Tools
GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
https://bugs.webkit.org/show_bug.cgi?id=68024
Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-13
Reviewed by Gustavo Noronha Silva.
Using g_list_count() and g_list_nth_data() together on a loop is
inneficient since they're both O(n). Iterate over lists in a saner
way.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(dumpHistoryItem): Reduce the scope for the 'kids' variable, and
iterate on it using g_list_next(). Free the list after done with it.
(dumpBackForwardListForWebView): Instead of appending (which is
expensive in GLists) history items and then iterating from the tail
of the itemsToPrint list, prepend items and walk forwards as usual.
(dumpBackForwardListForAllWebViews): Walk the list in a saner way,
remove the (unneeded) viewList variable.
- 6:00 PM Changeset in webkit [95061] by
-
- 2 edits in trunk/Tools
Add Eric's IRC nick.
- Scripts/webkitpy/common/config/committers.py:
- 5:37 PM Changeset in webkit [95060] by
-
- 12 edits in trunk/Source/JavaScriptCore
SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should
return false if either node can be double
https://bugs.webkit.org/show_bug.cgi?id=67985
Reviewed by Geoffrey Garen.
This is a 17% speed-up on 3d-cube.
This required allowing us to check if a constant is double but not
integer, and making the shouldSpeculateInteger() check test for
any hints of doubly-ness in its operands. This also required
changing some terminology: previously "isDouble" often meant
"isDouble or isInt32". Now "isDouble" means exactly what the name
suggests, and "isNumber" means "isDouble or isInt32".
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGenerationInfo.h:
(JSC::DFG::isJSFormat):
(JSC::DFG::isJSInteger):
(JSC::DFG::isJSDouble):
(JSC::DFG::isJSCell):
(JSC::DFG::isJSBoolean):
(JSC::DFG::GenerationInfo::isJSFormat):
(JSC::DFG::GenerationInfo::isJSInteger):
(JSC::DFG::GenerationInfo::isJSDouble):
(JSC::DFG::GenerationInfo::isJSCell):
(JSC::DFG::GenerationInfo::isJSBoolean):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::isNumberConstant):
(JSC::DFG::Graph::valueOfNumberConstant):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::isNumberConstant):
(JSC::DFG::JITCodeGenerator::valueOfNumberConstant):
(JSC::DFG::JITCodeGenerator::initConstantInfo):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillToJS):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isNumberConstant):
(JSC::DFG::JITCompiler::valueOfNumberConstant):
- dfg/DFGNode.h:
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::valueOfNumberConstant):
(JSC::DFG::Node::hasNumberResult):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):
(JSC::DFG::SpeculativeJIT::shouldNotSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
- 5:29 PM Changeset in webkit [95059] by
-
- 3 edits2 adds in trunk
Source/WebCore: Fix crash when an iframe element is removed during a transition to
fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=67960
Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-13
Reviewed by Adam Barth.
Test: fullscreen/full-screen-remove-ancestor-during-transition.html
- dom/Document.cpp:
(WebCore::Document::~Document):
Clear the list of elements to which we need to send a fullscreenchange
event.
LayoutTests: Removing an iframe from the document during a transition to fullscreen
should not crash.
https://bugs.webkit.org/show_bug.cgi?id=67960
Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-13
Reviewed by Adam Barth.
- fullscreen/full-screen-remove-ancestor-during-transition-expected.txt: Added.
- fullscreen/full-screen-remove-ancestor-during-transition.html: Added.
- 5:17 PM Changeset in webkit [95058] by
-
- 4 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=68040
Make sure border image sub-properties can be specified in any order.
Reviewed by Beth Dakin.
Source/WebCore:
New tests in fast/borders.
- css/CSSParser.cpp:
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::canAdvance):
(WebCore::BorderImageParseContext::setCanAdvance):
(WebCore::BorderImageParseContext::allowCommit):
(WebCore::BorderImageParseContext::allowImage):
(WebCore::BorderImageParseContext::allowImageSlice):
(WebCore::BorderImageParseContext::allowSlash):
(WebCore::BorderImageParseContext::requireWidth):
(WebCore::BorderImageParseContext::requireOutset):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):
- css/CSSParserValues.h:
(WebCore::CSSParserValueList::previous):
LayoutTests:
- fast/borders/border-image-scrambled.html: Added.
- platform/mac/fast/borders/border-image-scrambled-expected.png: Added.
- platform/mac/fast/borders/border-image-scrambled-expected.txt: Added.
- 5:05 PM Changeset in webkit [95057] by
-
- 2 edits in trunk/Source/WebCore
WebCore::Cursor::ensurePlatformCursor() should always set a valid platform cursor on Windows
https://bugs.webkit.org/show_bug.cgi?id=68043
Make sure we set a valid platform cursor in the Cursor::NoDrop case, and add a default
clause that uses the arrow cursor in case another cursor type is added in the future
and we forget to update ensurePlatformCursor().
Reviewed by Anders Carlsson.
- platform/win/CursorWin.cpp:
(WebCore::Cursor::ensurePlatformCursor): Always set a valid platform cursor.
- 4:32 PM Changeset in webkit [95056] by
-
- 3 edits2 adds in trunk
MSAA: WebKit reports the document state as disabled
https://bugs.webkit.org/show_bug.cgi?id=67974
<rdar://problem/10095898>
Reviewed by Brian Weinstein.
Source/WebCore:
Test: platform/win/accessibility/document-enabled-state.html
- accessibility/AccessibilityScrollView.h:
(WebCore::AccessibilityScrollView::isEnabled):
This object backs the AccessibleDocument on Windows - always return
true for its enabled state.
LayoutTests:
- platform/win/accessibility/document-enabled-state-expected.txt: Added.
- platform/win/accessibility/document-enabled-state.html: Added.
- 4:10 PM Changeset in webkit [95055] by
-
- 4 edits1 add in trunk/Source/WebKit/qt
[Qt] Fix state of stop/reload actions in QWebPage
https://bugs.webkit.org/show_bug.cgi?id=65977
FrameLoader does ask its DocumentLoader to stop loading subresources before
setting the state to FrameStateCommittedPage. But it does
not check if the the DocumentLoader actually stopped loading before
it changes the state.
Therefore a subresourceLoader can still be active, when we receive the
call to dispatchDidFinishLoad(). This leads to an inconsistent behavior
of the stop/reload actions in QWebPage.
This changeset fixes the inconsistent state by updating the action states
also when frameLoadCompleted() is called.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-09-13
Reviewed by Chang Shu.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::frameLoadCompleted):
- 3:49 PM Changeset in webkit [95054] by
-
- 4 edits2 adds in trunk
Source/WebCore: Fixes several bugs when adding CounterNodes to a tree which can cause asymetrical relationships.
https://bugs.webkit.org/show_bug.cgi?id=65996
Reviewed by Eric Seidel.
Test: fast/css/counters/counter-reparent-table-children-crash.html
- rendering/CounterNode.cpp:
(WebCore::CounterNode::insertAfter):
- rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
LayoutTests: Test for crash when reparenting table elements with associated counters outside the table.
https://bugs.webkit.org/show_bug.cgi?id=65996
Reviewed by Eric Seidel.
- fast/css/counters/counter-reparent-table-children-crash-expected.txt: Added.
- fast/css/counters/counter-reparent-table-children-crash.html: Added.
- 3:41 PM Changeset in webkit [95053] by
-
- 2 edits in trunk/Source/WebCore
Adding a comment I forgot to add before.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
- 3:38 PM Changeset in webkit [95052] by
-
- 5 edits in trunk/Source/WebCore
Move identifier filter from CSSStyleSelector to SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=68025
Reviewed by Sam Weinig.
This is a more logical place for this code. It also makes CSSStyleSelector slightly less bloated.
It will make it possible to use fastRejectSelector for querySelectorAll in the future.
- css/CSSStyleSelector.cpp:
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::RuleData::RuleData):
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
- css/SelectorChecker.cpp:
(WebCore::collectElementIdentifierHashes):
(WebCore::SelectorChecker::pushParentStackFrame):
(WebCore::SelectorChecker::popParentStackFrame):
(WebCore::SelectorChecker::pushParent):
(WebCore::SelectorChecker::popParent):
(WebCore::collectDescendantSelectorIdentifierHashes):
(WebCore::SelectorChecker::collectIdentifierHashes):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::parentStackIsConsistent):
(WebCore::SelectorChecker::ParentStackFrame::ParentStackFrame):
(WebCore::SelectorChecker::fastRejectSelector):
- 3:33 PM Changeset in webkit [95051] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Restoring a ChangeLog entry that I accidentally trampled.
- 3:31 PM Changeset in webkit [95050] by
-
- 3 edits4 adds in trunk
For compatibility, execCommand should support deprecated 'useCSS' alias for 'styleWithCSS'
https://bugs.webkit.org/show_bug.cgi?id=36683
Patch by Kiyoto Tamura <owenestea@gmail.com> on 2011-09-13
Reviewed by Ryosuke Niwa.
Source/WebCore:
In addition to supporting the deprecated 'useCSS', 'styleWithCSS' now accepts any argument other than
the boolean false or the case-insensitive string "false". This is per
http://aryeh.name/spec/editing/editing.html#the-stylewithcss-command
Tests: editing/execCommand/style-with-css.html
editing/execCommand/use-css.html
- editing/EditorCommand.cpp:
(WebCore::executeStyleWithCSS):
(WebCore::executeUseCSS):
(WebCore::createCommandMap):
LayoutTests:
Testing useCSS, the command previously unsupported by WebKit. Also, we are testing
styleWithCSS accepts anything that is not the boolean false or the string "false" as true.
Furthermore, we test that queryCommandValue/State('useCSS') return boolean false and
queryCommandValue/State('useStyleWithCSS') returns booleans (as opposed to 'true'/'false'
strings)
- editing/execCommand/style-with-css-expected.txt: Added.
- editing/execCommand/style-with-css.html: Added.
- editing/execCommand/use-css-expected.txt: Added.
- editing/execCommand/use-css.html: Added.
- 3:28 PM Changeset in webkit [95049] by
-
- 16 edits in trunk
Disable C++ exceptions when building with clang
https://bugs.webkit.org/show_bug.cgi?id=68031
<rdar://problem/9556880>
Reviewed by Mark Rowe.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
Source/JavaScriptGlue:
- Configurations/Base.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
Tools:
- MiniBrowser/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- 3:17 PM Changeset in webkit [95048] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=67885
Outline for the high-resolution broken image icon draws at 2x
-and corresponding-
<rdar://problem/10104637>
Reviewed by Dan Bernstein.
Scaled the image size to account for the deviceScaleFactor.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
- 2:54 PM Changeset in webkit [95047] by
-
- 4 edits3 adds in trunk
REGRESSION (64275): Shape pattern-image fill turns black
https://bugs.webkit.org/show_bug.cgi?id=51061
<rdar://problem/8504705>
Reviewed by Simon Fraser.
Source/WebCore:
When destroying a resource, register clients who are losing their
resource as having pending resources, so they can be resolved in the case a
resource with that id is re-registered.
Test: svg/custom/pending-resource-after-removal.xhtml
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::resourceDestroyed):
- svg/SVGStyledElement.h:
(WebCore::toSVGStyledElement): Added.
LayoutTests:
Add a test ensuring that replacing a SVG pattern without changing
the id causes the clients to be updated properly.
- svg/custom/pending-resource-after-removal-expected.png: Added.
- svg/custom/pending-resource-after-removal-expected.txt: Added.
- svg/custom/pending-resource-after-removal.xhtml: Added.
- 2:50 PM Changeset in webkit [95046] by
-
- 3 edits in trunk/Tools
[chromium] fix flakiness dashboard for chromium interactive tests
https://bugs.webkit.org/show_bug.cgi?id=68029
Reviewed by Tony Chang.
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
- 2:43 PM Changeset in webkit [95045] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] The checked state of WebPopupMenuItem isn't initialized
https://bugs.webkit.org/show_bug.cgi?id=67889
Reviewed by Darin Fisher.
It seems we're failing to initialize the checked state of
WebPopupMenuItems, potentially because Android is the first platform to
use popup menus for <select> elements.
- src/ExternalPopupMenu.cpp:
(WebKit::ExternalPopupMenu::getPopupMenuInfo):
- 2:29 PM QtWebKitRelease22 edited by
- (diff)
- 2:08 PM Changeset in webkit [95044] by
-
- 2 edits in trunk/Tools
Add Alice and Aryeh to the list of contributors.
- Scripts/webkitpy/common/config/committers.py:
- 1:59 PM Changeset in webkit [95043] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed; new baselines (Skia on Mac)
Updated reference images.
- platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
- platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.png: Added.
- 1:51 PM Changeset in webkit [95042] by
-
- 3 edits in trunk/Tools
sheriffbot whois should also tell us email addresses
https://bugs.webkit.org/show_bug.cgi?id=67975
Reviewed by Eric Seidel and David Levin.
Taught sheriffbot how to tell us contributor's email addresses.
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
- 1:35 PM Changeset in webkit [95041] by
-
- 1 edit7 adds1 delete in trunk/LayoutTests
Unreviewed; new baselines (Skia on Mac)
Updated reference images, text.
- platform/chromium-mac/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Removed.
- platform/chromium-mac/platform/chromium/fast/repaint: Added.
- platform/chromium-mac/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
- platform/chromium-mac/fast/lists/list-marker-before-content-table-expected.png: Added.
- platform/chromium-mac/fast/runin/runin-generated-before-content-expected.png: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
- platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png: Added.
- platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png: Added.
- 1:19 PM Changeset in webkit [95040] by
-
- 38 edits in trunk
Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
https://bugs.webkit.org/show_bug.cgi?id=68018
Reviewed by Ryosuke Niwa.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.exp.in:
- dom/DOMImplementation.cpp:
(WebCore::isSVG10Feature):
(WebCore::isSVG11Feature):
- dom/Text.cpp:
(WebCore::Text::createRenderer):
- features.pri:
- page/DOMWindow.idl:
- rendering/svg/RenderSVGForeignObject.cpp:
- rendering/svg/RenderSVGForeignObject.h:
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
- svg/SVGForeignObjectElement.cpp:
- svg/SVGForeignObjectElement.h:
- svg/SVGForeignObjectElement.idl:
- svg/SVGLocatable.cpp:
(WebCore::isViewportElement):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::isOutermostSVG):
- svg/SVGUseElement.cpp:
(WebCore::isDisallowedElement):
(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
- svg/svgtags.in:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/build-webkit:
- waf/build/settings.py:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 12:26 PM Changeset in webkit [95039] by
-
- 21 edits1 copy1 add in trunk
[WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
https://bugs.webkit.org/show_bug.cgi?id=57515
Source/WebKit2:
The code change in WebKit2 allows key events being sent to WebProcess from UIProcess synchronously.
Patch by Chang Shu <cshu@webkit.org> on 2011-09-13
Reviewed by Darin Adler.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetShouldSendKeyboardEventSynchronously):
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleKeyboardEvent):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::setShouldSendKeyboardEventSynchronously):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::keyEventSyncForTesting):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
TestController synchronously. The latter then sends simulated event to WebKit2 module,
which is synchronous, too.
Patch by Chang Shu <cshu@webkit.org> on 2011-09-13
Reviewed by Darin Adler.
- WebKitTestRunner/EventSenderProxy.h: Added.
(WTR::EventSenderProxy::EventSenderProxy):
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::keyDown):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
- WebKitTestRunner/PlatformWebView.h:
(WTR::PlatformWebView::platformWindow):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/mac/EventSenderProxy.mm: Added.
(WTR::buildModifierFlags):
(WTR::EventSenderProxy::keyDown):
LayoutTests:
Unskip passed tests for Mac.
Patch by Chang Shu <cshu@webkit.org> on 2011-09-13
Reviewed by Darin Adler.
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
- platform/win-wk2/Skipped:
- platform/wk2/Skipped:
- 12:24 PM Changeset in webkit [95038] by
-
- 3 edits3 adds in trunk
<http://webkit.org/b/67983> CRASH under WebCore::ArchiveResourceCollection::addAllResources loading WebArchive
Reviewed by Darin Adler.
Source/WebCore:
Null mimetypes are okay for subresources, but as previously discovered
in bug 41082 they were required for main resources. Here we ensure
that they are required for main resources, but we allow null mimetypes
for subresources.
To fix a crash for bad input we never add a null ArchiveResource to the
Archive's subresource collection. It is useless and causes crashes whenever
someone iterates the Archive's subresource collection.
Test: webarchive/loading/test-loading-archive-subresource-null-mimetype.html
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createResource):
Allow a null mimetype, just type check from the dictionary.
(WebCore::LegacyWebArchive::extract):
Require a mimetype for the main resource. Do not add null
subresources to the subresource list.
LayoutTests:
Test a WebArchive that has been constructed to have a null
mimetype for a subresource.
- webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt: Added.
- webarchive/loading/test-loading-archive-subresource-null-mimetype.html: Added.
- webarchive/loading/resources/subresource-null-mimetype.webarchive: Added.
- 12:18 PM Changeset in webkit [95037] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-09-13 James Simonsen <simonjam@chromium.org>
[Chromium] Ref protect element in FrameLoaderClientImpl::createPlugin
https://bugs.webkit.org/show_bug.cgi?id=68014
Reviewed by Nate Chapin.
Test: plugins/destroy-during-npp-new.htm under valgrind
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
- 11:33 AM Changeset in webkit [95036] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-13
- DEPS:
- 11:25 AM Changeset in webkit [95035] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Remove javascript_engine from WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=68001
Reviewed by Tony Chang.
Remove javascript_engine GYP variable (similar to the removal done on
the Chromium side with http://crrev.com/100692)
- WebCore.gyp/WebCore.gyp:
- 10:58 AM Changeset in webkit [95034] by
-
- 1 edit in branches/chromium/874/Source/WebCore/platform/graphics/Gradient.cpp
Merge 95010 - Fix out-of-bounds access in Gradient::sortStopsIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=67958
Reviewed by Darin Adler.
Reported by Valgrind in http://crbug.com/77049.
The errant code was added as an optimization in r67804.
This patch reverts that one, as all parties agree that the optimization
doesn't seem worthwhile, and there clearly aren't any tests covering
the special case.
No new tests, as existing tests should cover the remaining call to
|std::stable_sort|.
- platform/graphics/Gradient.cpp:
(WebCore::Gradient::sortStopsIfNecessary):
TBR=adamk@chromium.org
Review URL: http://codereview.chromium.org/7891013
- 10:54 AM Changeset in webkit [95033] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Do not always return the cached frame name.
https://bugs.webkit.org/show_bug.cgi?id=66856
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-13
Reviewed by Antonio Gomes.
When a frame has its parent changed (via adoptNode and appendChild,
for example), the frame name will change, so we need to account for
that case and change the cached name when needed.
This should make fast/frames/iframe-reparenting-unique-name.html pass.
- ewk/ewk_frame.cpp:
(ewk_frame_name_get):
- 10:46 AM Changeset in webkit [95032] by
-
- 2 edits in trunk/LayoutTests
Update chromium test expectation since fast/borders/border-image-omit-right-slice.html no longer hits an assertion.
- platform/chromium/test_expectations.txt:
- 10:31 AM Changeset in webkit [95031] by
-
- 2 edits in trunk/Source/WebCore
[CSS3 Backgrounds and Borders] Add unprefixed border-image shorthand.
https://bugs.webkit.org/show_bug.cgi?id=67970
Reviewed by David Hyatt.
Also update CSSStyleSelector.cpp to support border-image to suppress assertion in
fast/borders/border-image-omit-right-slice.html
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
- 9:44 AM Changeset in webkit [95030] by
-
- 3 edits2 adds in trunk
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-13
Reviewed by Darin Adler.
Source/WebCore:
Webkit wraps between hyphen-minus and numeric characters
https://bugs.webkit.org/show_bug.cgi?id=20677
Disallow wrapping between a hyphen-minus and a digit if the hyphen-minus
is not directly after a digit or a letter.
Test: fast/text/line-breaks-after-hyphen-before-number.html
- rendering/break_lines.cpp:
(WebCore::asciiLineBreakTable): Disabled line-breaking after '-' and before '.', '0'-'9'. Note: the change for '0'-'9' doesn't really matter because the case is handled hard-coded in shouldBreakAfter().
(WebCore::shouldBreakAfter): Changed line-breaking behavior after '-'.
(WebCore::nextBreakablePosition): Passes lastLastCh to shouldBreakAfter.
LayoutTests:
Webkit wraps between hyphen-minus and numeric characters
https://bugs.webkit.org/show_bug.cgi?id=20677
Disallow wrapping between a hyphen-minus and a digit if the hyphen-minus
is not directly after a digit or a letter.
- fast/text/line-breaks-after-hyphen-before-number-expected.txt: Added.
- fast/text/line-breaks-after-hyphen-before-number.html: Added.
- 9:23 AM Changeset in webkit [95029] by
-
- 2 edits in trunk/Source/WebCore
platform/graphics/gtk/FontGtk.cpp was renamed to platform/graphics/pango/FontPango.cpp . Reflect this change in WebCore.gypi to fix a Chromium build breakage.
https://bugs.webkit.org/show_bug.cgi?id=68000
Patch by Erik Wright <erikwright@chromium.org> on 2011-09-13
Reviewed by Tony Gentilcore.
No change in functionality, thus no new tests.
- WebCore.gypi:
- 9:01 AM Changeset in webkit [95028] by
-
- 3 edits3 adds in trunk
Object.getPrototypeOf should use JSValue::get()
https://bugs.webkit.org/show_bug.cgi?id=67973
Reviewed by Darin Adler.
Source/JavaScriptCore:
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
Pipe through JSValue::get() to allow overrides.
LayoutTests:
- http/tests/security/cross-frame-access-object-getPrototypeOf-expected.txt: Added.
- http/tests/security/cross-frame-access-object-getPrototypeOf.html: Added.
- http/tests/security/resources/cross-frame-iframe-for-object-getPrototypeOf-test.html: Added.
- 8:32 AM Changeset in webkit [95027] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Profiler: Fix overlapping data in function names column.
https://bugs.webkit.org/show_bug.cgi?id=67896
Reviewed by Pavel Feldman.
- inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.createCell):
- inspector/front-end/dataGrid.css:
(.data-grid table.data):
(.data-grid td):
- 8:20 AM Changeset in webkit [95026] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r95025.
http://trac.webkit.org/changeset/95025
https://bugs.webkit.org/show_bug.cgi?id=68005
Test failed on Snow Leopard bots. (Requested by yutak_home on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-13
- websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- 6:53 AM QtWebKitFeatures22 edited by
- (diff)
- 6:52 AM QtWebKitFeatures22 edited by
- (diff)
- 6:52 AM QtWebKitFeatures22 edited by
- (diff)
- 6:25 AM Changeset in webkit [95025] by
-
- 3 edits in trunk/Source/WebCore
ThreadableWebSocketChannelClientWrapper shouldn't have a String in it.
https://bugs.webkit.org/show_bug.cgi?id=67908
Reviewed by David Levin.
Replace a String member variable in ThreadableWebSocketChannelClientWrapper with Vector<UChar>.
No change in functionality, thus no new tests. WebSocket worker tests
(tests under http/tests/websocket/tests/{hixie76,hybi}/workers/) should keep passing.
- websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
Create a String from Vector<UChar>.
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
Copy the content of the given String into Vector.
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- 6:00 AM Changeset in webkit [95024] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium test expectations
- platform/chromium/test_expectations.txt: fast/borders/border-image-omit-right-slice.html fails on release
- 3:39 AM Changeset in webkit [95023] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, build fix.
CSSPropertyBorderImage was added in r94989, but not yet added in
WebCore::CSSStyleSelector::applyProperty
CSSStyleSelector.cpp:2481: warning: enumeration value 'CSSPropertyBorderImage' not handled in switch
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- 2:33 AM QtWebKitRelease22 edited by
- Add link to the waterfall of QtWebKit 2.2 buildbots (diff)
- 1:26 AM Changeset in webkit [95022] by
-
- 2 edits in trunk/LayoutTests
eventSender.keyDown is unimplemented (WKTR)
https://bugs.webkit.org/show_bug.cgi?id=57515
Unreviewed gardening.
- platform/qt-wk2/Skipped:
