Timeline



Mar 17, 2012:

10:24 PM WebKit Team edited by kubo@profusion.mobi
Update my affiliation (diff)
8:20 PM Changeset in webkit [111131] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] PlatformContextSkia::m_drawingToImageBuffer is not correctly set when using per-tile painting.
​https://bugs.webkit.org/show_bug.cgi?id=81463

Patch by David Reveman <​reveman@chromium.org> on 2012-03-17
Reviewed by James Robinson.

Call PlatformContextSkia::setDrawingToImageBuffer() from
SkPictureCanvasLayerTextureUpdater::prepareToUpdate so that sub-pixel
text rendering is not used incorrectly with per-tile painting.

No new tests.

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

6:57 PM Changeset in webkit [111130] by kubo@profusion.mobi
  • 3 edits in trunk/Tools

Unreviewed; switch to using my FreeBSD.org email address, the
other one is going to disappear soon.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
6:08 PM Changeset in webkit [111129] by barraclough@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Strength reduction, RegExp.exec -> RegExp.test
​https://bugs.webkit.org/show_bug.cgi?id=81459

Reviewed by Sam Weinig.

RegExp.prototype.exec & RegExp.prototype.test can both be used to test a regular
expression for a match against a string - however exec is more expensive, since
it allocates a matches array object. In cases where the result is consumed in a
boolean context the allocation of the matches array can be trivially elided.

For example:

function f()
{

for (i =0; i < 10000000; ++i)

if(!/a/.exec("a"))

err = true;

}

This is a 2.5x speedup on this example microbenchmark loop.

In a more advanced form of this optimization, we may be able to avoid allocating
the array where access to the array can be observed.

  • create_hash_table:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileRegExpExec):
(DFG):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jsc.cpp:

(GlobalObject::addConstructableFunction):

  • runtime/Intrinsic.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC):

  • runtime/JSFunction.h:

(JSFunction):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::exec):
(JSC::RegExpObject::match):

  • runtime/RegExpObject.h:

(RegExpObject):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):

4:57 PM Changeset in webkit [111128] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Make pixel-accurate wheel scrolling be unanimated
​https://bugs.webkit.org/show_bug.cgi?id=81457

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-17
Reviewed by James Robinson.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scroll):

3:56 PM Changeset in webkit [111127] by rwlbuis@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Implement openTemporaryFile in FileSystem
​https://bugs.webkit.org/show_bug.cgi?id=81373

Reviewed by George Staikos.

Move the Efl implementation to Posix, this way BlackBerry port can reuse it.

  • platform/blackberry/FileSystemBlackBerry.cpp:
  • platform/efl/FileSystemEfl.cpp:
  • platform/posix/FileSystemPOSIX.cpp:

(WebCore::openTemporaryFile):
(WebCore):

12:54 PM Changeset in webkit [111126] by commit-queue@webkit.org
  • 48 edits
    1 add in trunk/Source

move calc*Value functions out from Length (and platform)
​https://bugs.webkit.org/show_bug.cgi?id=80897

Moving the Length calc*Value functions out from Length structure and also from /WebCore/platform/ folder.
This helps to avoid the layering violation while length calculation. Otherwise layer violation can be avoided only by adding a virtual interface(bug 27160).

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-03-17
Reviewed by Antti Koivisto.

Source/WebCore:

  • GNUmakefile.list.am: Build system changes for adding new files.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(getAttributeSetForAccessibilityObject):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/LengthFunctions.h: Added. Moved calc*Value functions of Length.

(WebCore):
(WebCore::calculateMinimumValue):
(WebCore::calculateValue):
(WebCore::calculateFloatValue):

  • dom/Document.cpp:

(WebCore::Document::pageSizeAndMarginsInPixels):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::getRegion):

  • platform/CalculationValue.h:

(WebCore::CalcExpressionLength::evaluate):

  • platform/Length.h: Removed the calc*Value functions from Length structure.

(Length):
(WebCore::Length::getFloatValue):
(WebCore::Length::getIntValue):

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::setFilters):

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::getOutsets):

  • platform/graphics/transforms/PerspectiveTransformOperation.cpp:

(WebCore::PerspectiveTransformOperation::blend):

  • platform/graphics/transforms/PerspectiveTransformOperation.h:

(WebCore::PerspectiveTransformOperation::isIdentity):
(WebCore::PerspectiveTransformOperation::apply):

  • platform/graphics/transforms/TranslateTransformOperation.h:

(WebCore::TranslateTransformOperation::x):
(WebCore::TranslateTransformOperation::y):
(WebCore::TranslateTransformOperation::z):
(WebCore::TranslateTransformOperation::isIdentity):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::layout):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::layout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reflectionOffset):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::relativePositionOffsetY):
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layOutAxis):

  • rendering/RenderInline.cpp:

(WebCore::computeMargin):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::perspectiveTransform):
(WebCore::RenderLayer::perspectiveOrigin):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::computeTransformOrigin):
(WebCore::RenderLayerBacking::computePerspectiveOrigin):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::timerFired):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::logicalHeightForRowSizing):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

  • rendering/RenderText.h:

(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::applyTransform):
(WebCore::calcRadiiFor):

  • rendering/style/RenderStyle.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation):
(WebCore::resolveLengthAttributeForSVG):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::currentViewBoxRect):
(WebCore::SVGSVGElement::currentViewportSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::computeIntrinsicDimensions):

Source/WebKit2:

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

12:23 PM Changeset in webkit [111125] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/10263562> Crash in WebCore::Range::startPosition() when dismissing the Press and Hold panel by clicking in the menu bar
​https://bugs.webkit.org/show_bug.cgi?id=81454

Reviewed by Ada Chan.

When the Press and Hold panel is dismissed by clicking in the menu bar,
-insertText:replacementRange: is called with an NSRange whose location is NSNotFound - 1
(see <rdar://problem/11069374>). Trying to convert this bogus range to a WebCore Range
returns 0, which leads to the crash.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::insertText): Added a null check, to protect the code from bogus ranges.

11:53 AM Changeset in webkit [111124] by abarth@webkit.org
  • 1 edit in branches/chromium/1025/Source/WebCore/page/DOMWindow.cpp

Merge 106874 - postMessage leaks MemoryEvent object
​https://bugs.webkit.org/show_bug.cgi?id=77893

Patch by Greg Simon <​gregsimon@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

Changed from PassRefPtr().leakRef() to RefPtr.get() when
calling into FrameLoaderClient to stop +1 extra ref.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/9717030

11:19 AM Changeset in webkit [111123] by jamesr@google.com
  • 2 edits in branches/chromium/1025/Source/WebCore

Merge 110821 - Platforms without USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) don't need to query the page's displayID
​https://bugs.webkit.org/show_bug.cgi?id=81187

Reviewed by Simon Fraser.

  • dom/Document.cpp:

(WebCore::Document::webkitRequestAnimationFrame):

TBR=​jamesr@google.com
BUG=118331
Review URL: ​https://chromiumcodereview.appspot.com/9716016

11:12 AM Changeset in webkit [111122] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

Unreviewed; fix webkitpy unit test failures after r111116.

It turns out that cmd_line in the patch in bug 80025 had the right
signature when it was submitted, but r109242 added a few more
required parameters, and since the method (and EflDriver) did not
exist at the time we ended up committing a broken method.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflDriver.cmd_line): Add the pixel_tests' and per_test_args'
arguments.

8:45 AM Changeset in webkit [111121] by charles.wei@torchmobile.com.cn
  • 7 edits in trunk

[BlackBerry] Enable Web Timing for performance profiling and improvement.
​https://bugs.webkit.org/show_bug.cgi?id=81085

Reviewed by Rob Buis.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

Tools:

  • Scripts/build-webkit:
5:13 AM Changeset in webkit [111120] by Nikolas Zimmermann
  • 33 edits in trunk

Enable animVal support for SVGNumberOptionalNumber
​https://bugs.webkit.org/show_bug.cgi?id=81448

Reviewed by Antti Koivisto.

Source/WebCore:

Enable animVal support for SVGNumberOptionalNumber. Its a special case as two SVG DOM properties
eg. stdDeviationX/stdDeviationY are mapped to a single XML attribute: SVGNames::stdDeviationAttr.

When animating properties like this, both animVal wrappers need to reflect changes.
Generalize the current animVal code to support more than one SVGAnimatedProperty that gets
animated for a single attributeName. This allows us to remove SVGAnimatedType::variantValue/setVariantValue
which paves the way for removing SVGGenericAnimatedType from even more places.

Covered by existing tests.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::targetElementWillChange):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedLengthAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedLength.h:

(SVGAnimatedLengthAnimator):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedLengthList.h:

(SVGAnimatedLengthListAnimator):

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedNumberAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedNumber.h:

(SVGAnimatedNumberAnimator):

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedNumberList.h:

(SVGAnimatedNumberListAnimator):

  • svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedNumberOptionalNumber.h:

(WebCore):
(SVGAnimatedNumberOptionalNumberAnimator):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimatedTypeToBaseValue):
(WebCore):

  • svg/SVGAnimatedTransformList.h:

(SVGAnimatedTransformListAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal):

  • svg/SVGAnimatedType.h:

(SVGAnimatedType):

  • svg/SVGAnimatedTypeAnimator.h:

(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetAnimatedTypeToBaseValue):
(WebCore::SVGAnimatedTypeAnimator::currentBaseValueVariant):
(WebCore::SVGAnimatedTypeAnimator::constructFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetAnimatedTypeFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::constructFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetAnimatedTypeFromTwoBaseValues):

  • svg/SVGAnimationElement.cpp:

(WebCore::findMatchingAnimatedProperties):
(WebCore::SVGAnimationElement::applyAnimatedValue):
(WebCore::notifyAnimatedPropertyAboutAnimationBeginEnd):
(WebCore::SVGAnimationElement::animationStarted):
(WebCore::SVGAnimationElement::animationEnded):
(WebCore::SVGAnimationElement::animatedPropertiesForType):

  • svg/SVGAnimationElement.h:
  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(WebCore::SVGAnimatedListPropertyTearOff::currentBaseValueVariant):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):

  • svg/properties/SVGAnimatedProperty.h:

(SVGAnimatedProperty):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::currentBaseValueVariant):
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValueVariant):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationStarted):

LayoutTests:

Extend SVGNumberOptionalNumber tests to cover animVal/baseVal at the same time.

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/svgnumberoptionalnumber-animation-1-expected.txt:
  • svg/animations/svgnumberoptionalnumber-animation-2-expected.txt:
  • svg/animations/svgnumberoptionalnumber-animation-3-expected.txt:
  • svg/animations/svgnumberoptionalnumber-animation-4-expected.txt:
4:30 AM Changeset in webkit [111119] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

[GStreamer] run AudioFileReader in a nested loop
​https://bugs.webkit.org/show_bug.cgi?id=80823

Reviewed by Martin Robinson.

Use a separate main loop for the file reader, this approach is
much cleaner than polling the default GLib main context.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(AudioFileReader):
(WebCore::enteredMainLoopCallback):
(WebCore):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::handleMessage):
(WebCore::AudioFileReader::start):
(WebCore::AudioFileReader::createBus):

3:48 AM Changeset in webkit [111118] by robert@webkit.org
  • 4 edits
    6 adds in trunk

CSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015 fail
​https://bugs.webkit.org/show_bug.cgi?id=78027

Reviewed by Julien Chaffraix.

Source/WebCore:

Both of these test the (slightly implicit) rule that width set on column-groups cannot
affect the width of columns in a fixed layout table: ​http://www.w3.org/TR/CSS21/tables.html#fixed-table-layout
FF, Opera and IE all pass these two tests.

Tests: css2.1/20110323/fixed-table-layout-013.htm

css2.1/20110323/fixed-table-layout-015.htm
fast/table/fixed-table-layout-toggle-colwidth.html

  • rendering/FixedTableLayout.cpp:

(WebCore::nextCol): A helper function for finding the next column along.
(WebCore::FixedTableLayout::calcWidthArray): Ignore width specified by column groups.

  • rendering/RenderTableCol.h:

(WebCore::RenderTableCol::isTableColGroup): Convenience function for identifying column groups.

LayoutTests:

  • css2.1/20110323/fixed-table-layout-013-expected.html: Added.
  • css2.1/20110323/fixed-table-layout-013.htm: Added.
  • css2.1/20110323/fixed-table-layout-015-expected.html: Added.
  • css2.1/20110323/fixed-table-layout-015.htm: Added.
  • fast/table/fixed-table-layout-toggle-colwidth-expected.txt: Added.
  • fast/table/fixed-table-layout-toggle-colwidth.html: Added.
12:45 AM Changeset in webkit [111117] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

Add a dependencies installation step for EFL to buildbot master.cfg
​https://bugs.webkit.org/show_bug.cgi?id=81337

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(InstallEflDependencies):
(Factory.init):

12:33 AM Changeset in webkit [111116] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

[EFL] Prefixing run-webkit-tests with run-with-jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=80025

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflDriver):
(EflDriver.cmd_line):
(EflPort._driver_class):

12:30 AM Changeset in webkit [111115] by kubo@profusion.mobi
  • 2 edits
    6 adds in trunk/Tools

[EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
​https://bugs.webkit.org/show_bug.cgi?id=79904

build-webkit --efl will use jhbuild for fetching and building dependencies.

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

  • Scripts/update-webkitefl-libs: Added.
  • Scripts/webkitdirs.pm:

(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):

  • efl/common.py: Added.

(script_path):
(top_level_path):
(number_of_cpus):

  • efl/jhbuild.modules: Added.
  • efl/jhbuildrc: Added.
  • efl/run-with-jhbuild: Added.

Mar 16, 2012:

11:42 PM Changeset in webkit [111114] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add BlackBerry to NavigatorBase.cpp
​https://bugs.webkit.org/show_bug.cgi?id=81303

Reviewed by Rob Buis.

  • page/NavigatorBase.cpp:
11:39 PM Changeset in webkit [111113] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add typedef of DragDataRef for blackberry
​https://bugs.webkit.org/show_bug.cgi?id=81301

Reviewed by Rob Buis.

  • platform/DragData.h:
9:15 PM Changeset in webkit [111112] by commit-queue@webkit.org
  • 13 edits
    4 moves
    4 deletes in trunk/Source

[chromium] Unify the drawing logic for different layer types that output textures to the compositor
​https://bugs.webkit.org/show_bug.cgi?id=81286

Patch by James Robinson <​jamesr@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Currently canvas 2d, webgl, and plugin layers all export a texture to the compositor that then needs to be
drawn. There are a small set of operations that can be applied to the texture at draw time - do a Y flip,
stretch a subrect to the layer bounds, set the blend mode etc but they are fundamentally the same thing. This
collapses the nearly-redundant code into a single impl-side layer type for a texture-backed layer that can
handle the union of the bits needed for each layer type.

Canvas 2d, WebGL and plugin composited rendering are all covered by layout tests.

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawQuad):
(WebCore::TexStretchTextureProgramBinding::set):
(WebCore::TexTransformTextureProgramBinding::set):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::textureLayerProgramFlip):
(WebCore::LayerRendererChromium::textureLayerProgramStretch):
(WebCore::LayerRendererChromium::textureLayerProgramStretchFlip):
(WebCore::LayerRendererChromium::textureLayerTexRectProgram):
(WebCore::LayerRendererChromium::textureLayerTexRectProgramFlip):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::createCCLayerImpl):
(WebCore::PluginLayerChromium::setIOSurfaceProperties):
(WebCore::PluginLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/PluginLayerChromium.h:

(PluginLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/cc/CCCanvasDrawQuad.cpp: Removed.
  • platform/graphics/chromium/cc/CCCanvasDrawQuad.h: Removed.
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: Removed.
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h: Removed.
  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toTextureDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginDrawQuad.cpp.

(WebCore):
(WebCore::CCTextureDrawQuad::create):
(WebCore::CCTextureDrawQuad::CCTextureDrawQuad):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginDrawQuad.h.

(WebCore):
(CCTextureDrawQuad):
(WebCore::CCTextureDrawQuad::textureId):
(WebCore::CCTextureDrawQuad::hasAlpha):
(WebCore::CCTextureDrawQuad::premultipliedAlpha):
(WebCore::CCTextureDrawQuad::uvRect):
(WebCore::CCTextureDrawQuad::flipped):
(WebCore::CCTextureDrawQuad::ioSurfaceSize):
(WebCore::CCTextureDrawQuad::ioSurfaceTextureId):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.cpp.

(WebCore):
(WebCore::CCTextureLayerImpl::CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::~CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::willDraw):
(WebCore::CCTextureLayerImpl::appendQuads):
(WebCore::CCTextureLayerImpl::dumpLayerProperties):
(WebCore::CCTextureLayerImpl::didLoseContext):
(WebCore::CCTextureLayerImpl::setIOSurfaceProperties):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.

(WebCore):
(CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::create):
(WebCore::CCTextureLayerImpl::textureId):
(WebCore::CCTextureLayerImpl::setTextureId):
(WebCore::CCTextureLayerImpl::setHasAlpha):
(WebCore::CCTextureLayerImpl::setPremultipliedAlpha):
(WebCore::CCTextureLayerImpl::setFlipped):
(WebCore::CCTextureLayerImpl::setUVRect):
(WebCore::CCTextureLayerImpl::layerTypeAsString):

Source/WebKit/chromium:

  • tests/Canvas2DLayerChromiumTest.cpp:
8:00 PM Changeset in webkit [111111] by kubo@profusion.mobi
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening after r111110.

  • platform/efl/Skipped: Unskip fast/canvas/fillText-shadow.html

just like GTK+ did.

7:55 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
7:54 PM Changeset in webkit [111110] by Martin Robinson
  • 4 edits in trunk

[Cairo] Text extent of shadowed text is calculated incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=65035

Source/WebCore:

Reviewed by Martin Robinson.

No new tests. This is already covered by fast/canvas/fillText-shadow.html.

Correct determine the size of rendered text using x and y bearing from the font
extents.

  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::drawGlyphsShadow): Use the x and y bearing to calculate text extents.
This gives a more accurate sizing and avoids clipping the edges of the shadow.

LayoutTests:

Reviewed by Martin Robinson

  • platform/gtk/Skipped: Unskip a test that is now passing.
7:32 PM Changeset in webkit [111109] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium][Performance] Optimize innerText and outerText in Chromium/Mac
​https://bugs.webkit.org/show_bug.cgi?id=81192

Reviewed by Dimitri Glazkov.

This patch makes innerText and outerText 4 times faster on Chromium/Mac.
A similar performance improvement will be also observed in APIs that are using
TextIterator::plainText() (e.g. Editting, SpellChecker, Clipboard, Pasteboard etc).

Performance test: ​https://bugs.webkit.org/attachment.cgi?id=131989

  • AppleWebKit/JavaScriptCore/Mac:

div.innerText : 2978.4ms
div.outerText : 2944.4ms

  • Chromium/V8/Mac without the patch:

div.innerText : 10050.8ms
div.outerText : 10072.2ms

  • Chromium/V8/Mac with the patch:

div.innerText: 2536.4ms
div.outerText: 2714ms

This patch just changes the initial buffer size of a plain text buffer on Chromium/Mac.
As shown below, in my local Chromium/Mac environment the performance changes
dramatically between 1<<15 and 1<<16, and in my local Chromium/Linux environment
the performance changes between 1<<17 and 1<<18. I am not yet sure what determines
these figures, but it seems there exists a performance gap at some point
depending on a malloc mechanism.

  • div.innerText results on Chromium/V8/Mac:

WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 14 ==> 2465.6 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 15 ==> 2447.2 ms <--- after this patch
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 16 ==> 10250.8 ms <--- before this patch
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 17 ==> 10278.2 ms

  • div.innerText results on Chromium/V8/Linux:

WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 14 ==> 1569.8 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 15 ==> 1531.8 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 16 ==> 1543.2 ms <--- before/after this patch
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 17 ==> 1541.6 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 18 ==> 12540.8 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 19 ==> 12340.8 ms

  • editing/TextIterator.cpp:

(WebCore::plainTextToMallocAllocatedBuffer):

7:27 PM Changeset in webkit [111108] by dimich@chromium.org
  • 2 edits in trunk/Source/WebCore

HTMLFrameElementBase::m_remainsAliveOnRemovalFromTree can be cleared without unloading the frame.
​https://bugs.webkit.org/show_bug.cgi?id=80766

Reviewed by Adam Barth.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::insertedIntoDocument):
(WebCore::HTMLFrameElementBase::setRemainsAliveOnRemovalFromTree):
if adoptNode() is called on a detached iframe or with a detached document,
unload the iframe to avoid live iframe to hang around w/o being attached to
a document.

7:22 PM Changeset in webkit [111107] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Xcode project file is not sorted.
​https://bugs.webkit.org/show_bug.cgi?id=81439

Sorted the project file entries using sort-Xcode-project-file script.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-03-16
Reviewed by Eric Seidel.

  • WebCore.xcodeproj/project.pbxproj:
7:16 PM Changeset in webkit [111106] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r111075.
Correct the path of WebKitBlobBuilder.idl.

  • DerivedSources.pri:
7:01 PM Changeset in webkit [111105] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix for test runs for non-chromium platforms.

  • loader/cache/MemoryCache.cpp:

(WebCore::memoryCache):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationFailed):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::evict):

6:55 PM Changeset in webkit [111104] by commit-queue@webkit.org
  • 19 edits
    10 adds
    5 deletes in trunk/LayoutTests

Rebaselines for compositing tests with video
​https://bugs.webkit.org/show_bug.cgi?id=81430

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-03-16
Reviewed by James Robinson.

  • platform/chromium-linux/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-linux/compositing/visibility/visibility-simple-video-layer-expected.png:
  • platform/chromium-mac-leopard/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-mac-leopard/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium-mac-leopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-mac-leopard/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-mac-leopard/compositing/self-painting-layers-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-mac/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-mac/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-mac/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-mac/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/chromium-win/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.txt:
  • platform/chromium-win/compositing/self-painting-layers-expected.png:
  • platform/chromium-win/compositing/visibility/visibility-simple-video-layer-expected.png:
  • platform/chromium/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
  • platform/chromium/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
  • platform/chromium/compositing/self-painting-layers-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
6:29 PM Changeset in webkit [111103] by tony@chromium.org
  • 8 edits in trunk

Unreviewed, rolling out r111094.
​http://trac.webkit.org/changeset/111094
​https://bugs.webkit.org/show_bug.cgi?id=80882

broke test on chromium-win

Source/WebCore:

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/child-overflow-expected.html:
  • css3/flexbox/child-overflow.html:
  • css3/flexbox/flex-align-stretch-expected.txt:
  • css3/flexbox/flex-align-stretch.html:
6:21 PM Changeset in webkit [111102] by andersca@apple.com
  • 7 edits in trunk/Source/WebCore

REGRESSION (r110737): Height element changes on scrolled page causes failure
​https://bugs.webkit.org/show_bug.cgi?id=81381
<rdar://problem/11066006>

Reviewed by Sam Weinig.

Limit the fix made in r110737 to check if there's a rubber-band gesture in progress and only ignore the range if that is the case.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::isRubberBandInProgress):
(ScrollAnimator):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::isRubberBandInProgress):
(WebCore):

  • platform/mac/ScrollElasticityController.h:

(ScrollElasticityController):

  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::isRubberBandInProgress):
(WebCore):

5:52 PM Changeset in webkit [111101] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

GestureTapDown needs to pin in-progress flings
​https://bugs.webkit.org/show_bug.cgi?id=80875

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

  • page/EventHandler.cpp:

(WebCore):
(WebCore::EventHandler::handleGestureTapDown):

  • page/EventHandler.h:

(EventHandler):

5:49 PM Changeset in webkit [111100] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

Account for sample-rate in convolution normalization
​https://bugs.webkit.org/show_bug.cgi?id=81432

Reviewed by James Robinson.

  • platform/audio/Reverb.cpp:

(WebCore):
(WebCore::calculateNormalizationScale):

  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::setBuffer):

5:41 PM Changeset in webkit [111099] by commit-queue@webkit.org
  • 5 edits
    2 moves in trunk/Source/WebKit

[BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositorPrivate
​https://bugs.webkit.org/show_bug.cgi?id=81108
RIM PR: 136687

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This is done in anticipation of a new WebPageCompositor class in the
public API. The existing internal class will serve to d-pointerize the
new public API. In addition, it is and will be possible to create only
the private class, for cases where existing code paths require
OpenGL compositing (i.e. due to accelerated compositing layers being
added to the page).

Reviewed internally by Robin Cao.

  • Api/BackingStore.h:
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setIsAcceleratedCompositingActive):

  • Api/WebPageCompositor.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/WebPageCompositor.cpp.

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::hardwareCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
(BlackBerry::WebKit::WebPageCompositorPrivate::setBackingStoreUsesOpenGL):
(BlackBerry::WebKit::WebPageCompositorPrivate::commit):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationTimerFired):

  • Api/WebPageCompositor_p.h: Renamed from Source/WebKit/blackberry/WebKitSupport/WebPageCompositor.h.

(BlackBerry::WebKit::WebPageCompositorPrivate::layoutRectForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setLayoutRectForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::contentsSizeForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setContentsSizeForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::lastCompositingResults):
(BlackBerry::WebKit::WebPageCompositorPrivate::setLastCompositingResults):

  • Api/WebPage_p.h:
  • CMakeListsBlackBerry.txt:
5:31 PM Changeset in webkit [111098] by tsepez@chromium.org
  • 9 edits in trunk

Make V8 window.open.call(), window.open.showModalDialog() results more closely match JSC.
​https://bugs.webkit.org/show_bug.cgi?id=81260
​https://bugs.webkit.org/show_bug.cgi?id=39897

Reviewed by Adam Barth.

Source/WebCore:

Tested via http/tests/security/cross-frame-access-call.htm

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):

LayoutTests:

  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
5:29 PM Changeset in webkit [111097] by Stephanie Lewis
  • 11 edits in trunk

Source/WebKit2: ​https://bugs.webkit.org/show_bug.cgi?id=81065
<rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
Add some string function exports to Windows so the WebKitTestRunner can use them.

Reviewed by Geoff Garen.

  • win/WebKit2.def:

Tools: ​https://bugs.webkit.org/show_bug.cgi?id=81065
<rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
Fix crash preventing WebKitTestRunner from working in Release.
WebKitTestRunner used ostringstream to collect output from the test. ostringstream is incompatible with our
FastMalloc overrides. When copying strings out ostringstream a new string is allocated with FastMalloc because
the allocation is inlined. When that string is freed is uses the system malloc because that call is not inlined.

I removed ostringstream in favor of StringBuilder.

Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.

Reviewed by Geoff Garen.

Add DEBUG_DEFINES to set NDEBUG on release builds.

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Remove ostringstream member in favor of StringBuilder.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize):
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTF):
(WTR::InjectedBundle::stringBuilder):
(InjectedBundle):

Append output to StringBuilder.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::hasPrefix):
(WTR::dumpPath):
(WTR::rangeToStr):
(WTR::styleDecToStr):
(WTR::frameToStr):
(WTR::dumpFrameScrollPosition):
(WTR::dumpFrameText):
(WTR::dumpDescendantFramesText):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):
(WTR::lastFileURLPathComponent):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
(WTR::InjectedBundlePage::supportsFullScreen):
(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):
(WTR::dumpBackForwardListItem):
(WTR::InjectedBundlePage::dumpBackForwardList):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
(WTR::LayoutTestController::dumpConfigurationForViewport):

Convert between WTF::String and WKStringRef.

  • WebKitTestRunner/StringFunctions.h:

(WTR::toWTFString):
(WTR):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

5:27 PM Changeset in webkit [111096] by mlilek@apple.com
  • 2 edits in trunk/Source/WebCore

Use modern NSNumberFormatter API in LocalizedNumberMac.mm
​https://bugs.webkit.org/show_bug.cgi?id=81429

Reviewed by Dan Bernstein.

No new tests as no change in behavior.

  • platform/text/mac/LocalizedNumberMac.mm:

(WebCore::createFormatterForCurrentLocaleForDisplay):

5:19 PM Changeset in webkit [111095] by eric@webkit.org
  • 5 edits in trunk/Tools

Add a land-from-url command
​https://bugs.webkit.org/show_bug.cgi?id=81411

Reviewed by Adam Barth.

Very basic so far. The goal is to make it landing smarter
so that users don't have to bother to parse out the ids out of the urls.

  • Scripts/webkitpy/common/config/urls.py:

(parse_bug_id):
(parse_attachment_id):

  • Scripts/webkitpy/common/config/urls_unittest.py:

(URLsTest.test_parse_bug_id):
(URLsTest):
(URLsTest.test_parse_attachment_id):

  • Scripts/webkitpy/tool/commands/download.py:

(ProcessURLsMixin):
(ProcessURLsMixin._fetch_list_of_patches_to_process):
(LandFromURL):

  • Scripts/webkitpy/tool/commands/download_unittest.py:

(test_land_from_bug):
(test_land_from_url):

5:16 PM Changeset in webkit [111094] by tony@chromium.org
  • 8 edits in trunk

flex-item-align: stretch should only grow, never shrink
​https://bugs.webkit.org/show_bug.cgi?id=80882

Reviewed by Ojan Vafai.

Source/WebCore:

New test cases in css3/flexbox/flex-align-stretch.html.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren): Move stretch code into a separate function.
(WebCore::RenderFlexibleBox::alignChildStretch): Add an early return if our height is shrinking.
(WebCore):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/child-overflow-expected.html:
  • css3/flexbox/child-overflow.html: For cases that overflow the height, we now just overflow rather than reducing the height.
  • css3/flexbox/flex-align-stretch-expected.txt:
  • css3/flexbox/flex-align-stretch.html: New test cases.
5:13 PM Changeset in webkit [111093] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

build-webkit launcher instructions use wrong relative path for Qt
​https://bugs.webkit.org/show_bug.cgi?id=81357

Patch by Dave Tharp <​dtharp@codeaurora.org> on 2012-03-16
Reviewed by Eric Seidel.

Ensure we are at the proper directory before generating run-launcher
instructions.

  • Scripts/build-webkit:
5:10 PM Changeset in webkit [111092] by Lucas Forschler
  • 5 edits in branches/safari-534.56-branch/Source

Versioning.

5:10 PM Changeset in webkit [111091] by kubo@profusion.mobi
  • 2 edits in trunk/Source/WebCore

[EFL] Unreviewed, fix build after r111041.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::emitMediaButtonSignal): Rename
MediaFullscreenButton to MediaEnterFullscreenButton.
(WebCore::RenderThemeEfl::paintMediaFullscreenButton): Ditto.

4:49 PM Changeset in webkit [111090] by dcheng@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add layout tests that accidentally got left out of r111061

  • fast/events/clipboard-dataTransferItemList-expected.txt: Added.
  • fast/events/clipboard-dataTransferItemList.html: Added.
  • fast/events/drag-dataTransferItemList-expected.txt: Added.
  • fast/events/drag-dataTransferItemList.html: Added.
4:49 PM Changeset in webkit [111089] by dslomov@google.com
  • 4 edits in trunk/Source/WebCore

REGRESSION: DOMURL::revokeObjectURL accesses memoryCache on worker thread.
​https://bugs.webkit.org/show_bug.cgi?id=80889
On worker threads, post a task to main thread to evict from cache.
ASSERT that MemoryCache is only accessed from main thread.

Reviewed by David Levin.

  • html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL):

  • loader/cache/MemoryCache.cpp:

(WebCore::memoryCache):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationFailed):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::evict):
(WebCore):
(WebCore::MemoryCache::removeUrlFromCache):
(WebCore::MemoryCache::removeUrlFromCacheImpl):

  • loader/cache/MemoryCache.h:

(WebCore):
(MemoryCache):

4:47 PM Changeset in webkit [111088] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore

[BlackBerry] Upstream ScriptControllerBlackBerry.cpp
​https://bugs.webkit.org/show_bug.cgi?id=81397

Patch by Jacky Jiang <​zhajiang@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • bindings/js/ScriptControllerBlackBerry.cpp: Added.
4:46 PM Changeset in webkit [111087] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Syncing up left over bits in WebKitSupport from our local branch to upstream
​https://bugs.webkit.org/show_bug.cgi?id=81118

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This is a consolidation of various changes that are in our local dev branch
but do not appear in our upstreamed port.

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::isElementClickable):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spannableTextInRange):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::createBuffers):
(BlackBerry::WebKit::SurfacePool::releaseBuffers):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):

  • WebKitSupport/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):

  • WebKitSupport/WebPageCompositor.h:

(WebPageCompositor):

4:41 PM Changeset in webkit [111086] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

remove-body-during-body-replacement2.html is triggering crashes on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=81374

Reviewed by Eric Seidel.

When overriding disconnectFrame, we need to call the base class version
of the method so that it can clear the m_frame pointer.

Tests: This patch fixes a large number of crashes in tests.

  • notifications/DOMWindowNotifications.cpp:

(WebCore::DOMWindowNotifications::disconnectFrame):

4:27 PM Changeset in webkit [111085] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream the BlackBerry change to platform/Widget.h
​https://bugs.webkit.org/show_bug.cgi?id=81304

Reviewed by Rob Buis.

typedefs of PlatformWidget and PlatformPageClient for the BlackBerry.

  • platform/Widget.h:
4:22 PM Changeset in webkit [111084] by Lucas Forschler
  • 2 edits in branches/safari-534.56-branch/Source/JavaScriptCore

Merged r111081.

4:12 PM Changeset in webkit [111083] by commit-queue@webkit.org
  • 16 edits in trunk

MathML internals - factor code for almost anonymous blocks
​https://bugs.webkit.org/show_bug.cgi?id=81387

Patch by David Barton <Dave Barton> on 2012-03-16
Reviewed by Eric Seidel.

Source/WebCore:

MathML uses "almost anonymous" blocks to layout parts of mathematical expressions. These
will be converted to true anonymous blocks in a later patch. Here we factor out the code
to create them into RenderMathMLBlock::createAlmostAnonymousBlock().

No new tests. Some tree dump output is modified for existing tests. <munder>, <mover>,
and <munderover> renderers already used true anonymous blocks, so we change them to call
RenderBlock::createAnonymousBlock(). In the other direction, <mroot>'s almost anonymous
blocks are now made RenderMathMLBlock not just RenderBlock, in agreement with other
current MathML renderers.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::createAlmostAnonymousBlock):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):
(WebCore::RenderMathMLBlock::getBoxModelObjectWidth):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::addChild):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateFromElement):

  • improve some variable names

(WebCore::RenderMathMLFraction::addChild):
(WebCore::RenderMathMLFraction::layout):
(WebCore::RenderMathMLFraction::paint):
(WebCore::RenderMathMLFraction::baselinePosition):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::addChild):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::addChild):

  • rendering/mathml/RenderMathMLSubSup.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::addChild):

LayoutTests:

  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.txt:
4:05 PM Changeset in webkit [111082] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

Prepare RenderObject for FractionalLayoutUnits
​https://bugs.webkit.org/show_bug.cgi?id=81178

Reviewed by Eric Seidel.

This readies RenderObject to deal with FractionalLayoutUnits as a backend for the
LayoutUnit abstraction.

No new tests. No change in behavior.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::pixelSnappedAbsoluteClippedOverflowRect): Convenience method to be
used instead of absouluteClippedOverflowRect in platform code. Platform updates will come
in a separate patch.
(WebCore):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded): Borders remain ints when we move to
sub-pixel layout. This adjusts border variables for this, and adds compiler fixes when
using std::max and std::min with mixed int/LayoutUnits.
(WebCore::RenderObject::adjustRectForOutlineAndShadow): Outlines, like borders, remain
ints in the new sub-pixel world. Using variables that reflect that.

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::adjustForAbsoluteZoom): Handles FractionalLayoutUnit values. Flooring is what
JavaScript requires since this is used with values that must return ints.
(WebCore): Adding FractionalLayoutUnit.h to support the new adjusteForAbsoluteZoom method.

4:04 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
3:52 PM Changeset in webkit [111081] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Remove a bogus assert that was merged in from ToT. It is not needed on this branch.

Reviewed by Filip Pizlo.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addValueProfile):

3:29 PM Changeset in webkit [111080] by beidson@apple.com
  • 18 edits
    1 add in trunk

<rdar://problem/11027997> and ​https://bugs.webkit.org/show_bug.cgi?id=81412 REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted

Reviewed by Geoff Garen.

Source/WebCore:

WebKit API test WebViewCanPasteURL.mm added.

  • WebCore.exp.in:

Add a strategy method specifically for getting the URL:

  • platform/PasteboardStrategy.h:

Use that strategy method when creating the fragment for a URL:

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::documentFragment):

Add a platform pasteboard accessor to "do the right thing" for getting a URL:

  • platform/PlatformPasteboard.h:
  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::url):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::setInsertionPasteboard):

  • WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::url):

Source/WebKit2:

Add new message so the WebProcess can ask the UIProcesses pasteboard for the URL:

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::getPasteboardURL):

Use that new message to implement the pasteboard strategy:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::url):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
3:26 PM Changeset in webkit [111079] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/81380> clang warning unused variable when ENABLE(TEXT_CARET) is disabled

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-03-16
Reviewed by Dan Bernstein.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::recomputeCaretRect):
Put the variable inside of a guard because it is only
used inside of a guard.

3:23 PM Changeset in webkit [111078] by ojan@chromium.org
  • 9 edits
    1 add
    2 deletes in trunk/LayoutTests

Fix some tests that broke with r111042.

  • platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-linux/compositing/absolute-position-changed-with-composited-parent-layer-expected.png: Added.
  • platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
  • platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt:
3:19 PM Changeset in webkit [111077] by ojan@chromium.org
  • 3 edits in trunk/Tools

Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=81407

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.summarized_results):
(ResultSummaryTest.test_no_svn_revision):
(ResultSummaryTest.test_svn_revision):
(ResultSummaryTest):
(ResultSummaryTest.test_summarized_results_wontfix):

3:03 PM Changeset in webkit [111076] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

Shrink BorderValue.
<​http://webkit.org/b/69521>

Reviewed by Anders Carlsson.

Split BorderValue's Color member into RGBA32/bool buddies and stash the bool in
the BorderValue bitfield.

This shrinks BorderValue by 4 bytes, in turn shrinking BorderData by 16 bytes.
Altogether this yields ~800 kB in reduced memory consumption when viewing the full
HTML5 spec at <​http://whatwg.org/c>

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(BorderValue):
(WebCore::BorderValue::setColor):
(WebCore::BorderValue::color):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::operator==):

  • rendering/style/RenderStyle.cpp:

(SameSizeAsBorderValue):

  • rendering/style/RenderStyle.h:
3:00 PM Changeset in webkit [111075] by commit-queue@webkit.org
  • 10 edits
    64 moves in trunk/Source/WebCore

Moves remaining filesystem files to Modules/filesystem/
​https://bugs.webkit.org/show_bug.cgi?id=81353

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/filesystem/AsyncFileWriter.h: Copied from Source/WebCore/fileapi/AsyncFileWriter.h.
  • Modules/filesystem/AsyncFileWriterClient.h: Copied from Source/WebCore/fileapi/AsyncFileWriterClient.h.
  • Modules/filesystem/DOMFilePath.cpp: Copied from Source/WebCore/fileapi/DOMFilePath.cpp.
  • Modules/filesystem/DOMFilePath.h: Copied from Source/WebCore/fileapi/DOMFilePath.h.
  • Modules/filesystem/DOMFileSystem.cpp: Copied from Source/WebCore/fileapi/DOMFileSystem.cpp.
  • Modules/filesystem/DOMFileSystem.h: Copied from Source/WebCore/fileapi/DOMFileSystem.h.
  • Modules/filesystem/DOMFileSystem.idl: Copied from Source/WebCore/fileapi/DOMFileSystem.idl.
  • Modules/filesystem/DOMFileSystemBase.cpp: Copied from Source/WebCore/fileapi/DOMFileSystemBase.cpp.
  • Modules/filesystem/DOMFileSystemBase.h: Copied from Source/WebCore/fileapi/DOMFileSystemBase.h.
  • Modules/filesystem/DOMFileSystemSync.cpp: Copied from Source/WebCore/fileapi/DOMFileSystemSync.cpp.
  • Modules/filesystem/DOMFileSystemSync.h: Copied from Source/WebCore/fileapi/DOMFileSystemSync.h.
  • Modules/filesystem/DOMFileSystemSync.idl: Copied from Source/WebCore/fileapi/DOMFileSystemSync.idl.
  • Modules/filesystem/Entry.cpp: Copied from Source/WebCore/fileapi/Entry.cpp.
  • Modules/filesystem/Entry.h: Copied from Source/WebCore/fileapi/Entry.h.
  • Modules/filesystem/Entry.idl: Copied from Source/WebCore/fileapi/Entry.idl.
  • Modules/filesystem/EntryArray.cpp: Copied from Source/WebCore/fileapi/EntryArray.cpp.
  • Modules/filesystem/EntryArray.h: Copied from Source/WebCore/fileapi/EntryArray.h.
  • Modules/filesystem/EntryArray.idl: Copied from Source/WebCore/fileapi/EntryArray.idl.
  • Modules/filesystem/EntryArraySync.cpp: Copied from Source/WebCore/fileapi/EntryArraySync.cpp.
  • Modules/filesystem/EntryArraySync.h: Copied from Source/WebCore/fileapi/EntryArraySync.h.
  • Modules/filesystem/EntryArraySync.idl: Copied from Source/WebCore/fileapi/EntryArraySync.idl.
  • Modules/filesystem/EntryBase.cpp: Copied from Source/WebCore/fileapi/EntryBase.cpp.
  • Modules/filesystem/EntryBase.h: Copied from Source/WebCore/fileapi/EntryBase.h.
  • Modules/filesystem/EntryCallback.h: Copied from Source/WebCore/fileapi/EntryCallback.h.
  • Modules/filesystem/EntryCallback.idl: Copied from Source/WebCore/fileapi/EntryCallback.idl.
  • Modules/filesystem/EntrySync.cpp: Copied from Source/WebCore/fileapi/EntrySync.cpp.
  • Modules/filesystem/EntrySync.h: Copied from Source/WebCore/fileapi/EntrySync.h.
  • Modules/filesystem/EntrySync.idl: Copied from Source/WebCore/fileapi/EntrySync.idl.
  • Modules/filesystem/ErrorCallback.h: Copied from Source/WebCore/fileapi/ErrorCallback.h.
  • Modules/filesystem/ErrorCallback.idl: Copied from Source/WebCore/fileapi/ErrorCallback.idl.
  • Modules/filesystem/FileCallback.h: Copied from Source/WebCore/fileapi/FileCallback.h.
  • Modules/filesystem/FileCallback.idl: Copied from Source/WebCore/fileapi/FileCallback.idl.
  • Modules/filesystem/FileEntry.cpp: Copied from Source/WebCore/fileapi/FileEntry.cpp.
  • Modules/filesystem/FileEntry.h: Copied from Source/WebCore/fileapi/FileEntry.h.
  • Modules/filesystem/FileEntry.idl: Copied from Source/WebCore/fileapi/FileEntry.idl.
  • Modules/filesystem/FileEntrySync.cpp: Copied from Source/WebCore/fileapi/FileEntrySync.cpp.
  • Modules/filesystem/FileEntrySync.h: Copied from Source/WebCore/fileapi/FileEntrySync.h.
  • Modules/filesystem/FileEntrySync.idl: Copied from Source/WebCore/fileapi/FileEntrySync.idl.
  • Modules/filesystem/FileSystemCallback.h: Copied from Source/WebCore/fileapi/FileSystemCallback.h.
  • Modules/filesystem/FileSystemCallback.idl: Copied from Source/WebCore/fileapi/FileSystemCallback.idl.
  • Modules/filesystem/FileSystemCallbacks.cpp: Copied from Source/WebCore/fileapi/FileSystemCallbacks.cpp.
  • Modules/filesystem/FileSystemCallbacks.h: Copied from Source/WebCore/fileapi/FileSystemCallbacks.h.
  • Modules/filesystem/FileWriter.cpp: Copied from Source/WebCore/fileapi/FileWriter.cpp.
  • Modules/filesystem/FileWriter.h: Copied from Source/WebCore/fileapi/FileWriter.h.
  • Modules/filesystem/FileWriter.idl: Copied from Source/WebCore/fileapi/FileWriter.idl.
  • Modules/filesystem/FileWriterBase.cpp: Copied from Source/WebCore/fileapi/FileWriterBase.cpp.
  • Modules/filesystem/FileWriterBase.h: Copied from Source/WebCore/fileapi/FileWriterBase.h.
  • Modules/filesystem/FileWriterBaseCallback.h: Copied from Source/WebCore/fileapi/FileWriterBaseCallback.h.
  • Modules/filesystem/FileWriterCallback.h: Copied from Source/WebCore/fileapi/FileWriterCallback.h.
  • Modules/filesystem/FileWriterCallback.idl: Copied from Source/WebCore/fileapi/FileWriterCallback.idl.
  • Modules/filesystem/FileWriterSync.cpp: Copied from Source/WebCore/fileapi/FileWriterSync.cpp.
  • Modules/filesystem/FileWriterSync.h: Copied from Source/WebCore/fileapi/FileWriterSync.h.
  • Modules/filesystem/FileWriterSync.idl: Copied from Source/WebCore/fileapi/FileWriterSync.idl.
  • Modules/filesystem/LocalFileSystem.cpp: Copied from Source/WebCore/fileapi/LocalFileSystem.cpp.
  • Modules/filesystem/LocalFileSystem.h: Copied from Source/WebCore/fileapi/LocalFileSystem.h.
  • Modules/filesystem/Metadata.h: Copied from Source/WebCore/fileapi/Metadata.h.
  • Modules/filesystem/Metadata.idl: Copied from Source/WebCore/fileapi/Metadata.idl.
  • Modules/filesystem/MetadataCallback.h: Copied from Source/WebCore/fileapi/MetadataCallback.h.
  • Modules/filesystem/MetadataCallback.idl: Copied from Source/WebCore/fileapi/MetadataCallback.idl.
  • Modules/filesystem/SyncCallbackHelper.h: Copied from Source/WebCore/fileapi/SyncCallbackHelper.h.
  • Modules/filesystem/WebKitFlags.h: Copied from Source/WebCore/fileapi/WebKitFlags.h.
  • Modules/filesystem/WorkerContextFileSystem.cpp: Copied from Source/WebCore/fileapi/WorkerContextFileSystem.cpp.
  • Modules/filesystem/WorkerContextFileSystem.h: Copied from Source/WebCore/fileapi/WorkerContextFileSystem.h.
  • Modules/filesystem/WorkerContextFileSystem.idl: Copied from Source/WebCore/fileapi/WorkerContextFileSystem.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/AsyncFileWriter.h: Removed.
  • fileapi/AsyncFileWriterClient.h: Removed.
  • fileapi/DOMFilePath.cpp: Removed.
  • fileapi/DOMFilePath.h: Removed.
  • fileapi/DOMFileSystem.cpp: Removed.
  • fileapi/DOMFileSystem.h: Removed.
  • fileapi/DOMFileSystem.idl: Removed.
  • fileapi/DOMFileSystemBase.cpp: Removed.
  • fileapi/DOMFileSystemBase.h: Removed.
  • fileapi/DOMFileSystemSync.cpp: Removed.
  • fileapi/DOMFileSystemSync.h: Removed.
  • fileapi/DOMFileSystemSync.idl: Removed.
  • fileapi/Entry.cpp: Removed.
  • fileapi/Entry.h: Removed.
  • fileapi/Entry.idl: Removed.
  • fileapi/EntryArray.cpp: Removed.
  • fileapi/EntryArray.h: Removed.
  • fileapi/EntryArray.idl: Removed.
  • fileapi/EntryArraySync.cpp: Removed.
  • fileapi/EntryArraySync.h: Removed.
  • fileapi/EntryArraySync.idl: Removed.
  • fileapi/EntryBase.cpp: Removed.
  • fileapi/EntryBase.h: Removed.
  • fileapi/EntryCallback.h: Removed.
  • fileapi/EntryCallback.idl: Removed.
  • fileapi/EntrySync.cpp: Removed.
  • fileapi/EntrySync.h: Removed.
  • fileapi/EntrySync.idl: Removed.
  • fileapi/ErrorCallback.h: Removed.
  • fileapi/ErrorCallback.idl: Removed.
  • fileapi/FileCallback.h: Removed.
  • fileapi/FileCallback.idl: Removed.
  • fileapi/FileEntry.cpp: Removed.
  • fileapi/FileEntry.h: Removed.
  • fileapi/FileEntry.idl: Removed.
  • fileapi/FileEntrySync.cpp: Removed.
  • fileapi/FileEntrySync.h: Removed.
  • fileapi/FileEntrySync.idl: Removed.
  • fileapi/FileSystemCallback.h: Removed.
  • fileapi/FileSystemCallback.idl: Removed.
  • fileapi/FileSystemCallbacks.cpp: Removed.
  • fileapi/FileSystemCallbacks.h: Removed.
  • fileapi/FileWriter.cpp: Removed.
  • fileapi/FileWriter.h: Removed.
  • fileapi/FileWriter.idl: Removed.
  • fileapi/FileWriterBase.cpp: Removed.
  • fileapi/FileWriterBase.h: Removed.
  • fileapi/FileWriterBaseCallback.h: Removed.
  • fileapi/FileWriterCallback.h: Removed.
  • fileapi/FileWriterCallback.idl: Removed.
  • fileapi/FileWriterSync.cpp: Removed.
  • fileapi/FileWriterSync.h: Removed.
  • fileapi/FileWriterSync.idl: Removed.
  • fileapi/LocalFileSystem.cpp: Removed.
  • fileapi/LocalFileSystem.h: Removed.
  • fileapi/Metadata.h: Removed.
  • fileapi/Metadata.idl: Removed.
  • fileapi/MetadataCallback.h: Removed.
  • fileapi/MetadataCallback.idl: Removed.
  • fileapi/SyncCallbackHelper.h: Removed.
  • fileapi/WebKitFlags.h: Removed.
  • fileapi/WorkerContextFileSystem.cpp: Removed.
  • fileapi/WorkerContextFileSystem.h: Removed.
  • fileapi/WorkerContextFileSystem.idl: Removed.
2:54 PM Changeset in webkit [111074] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB) in OperationNotAllowedException.idl
​https://bugs.webkit.org/show_bug.cgi?id=81391

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • fileapi/OperationNotAllowedException.idl:
2:49 PM Changeset in webkit [111073] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

scrollbars/scrollbar-middleclick-nopaste.html times out on mac WK1
​https://bugs.webkit.org/show_bug.cgi?id=81410

Skip scrollbars/scrollbar-middleclick-nopaste.html on Mac.

  • platform/mac/Skipped:
2:47 PM Changeset in webkit [111072] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

plugins/netscape-plugin-setwindow-size-2.html and plugins/resize-from-plugin.html failing on Lion Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81405

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Added.
  • platform/mac-wk2/plugins/resize-from-plugin-expected.txt: Added.
2:47 PM Changeset in webkit [111071] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

plugins/npruntime/browser-object-identity.html failing on Lion Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81403

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/plugins/npruntime/browser-object-identity-expected.txt: Added.
2:47 PM Changeset in webkit [111070] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

plugins/refcount-leaks.html failing on Lion Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81400

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/plugins/refcount-leaks-expected.txt: Added.
2:47 PM Changeset in webkit [111069] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

plugins/crash-restoring-plugin-page-from-page-cache.html and
plugins/netscape-plugin-page-cache-works.html timing out on Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81392

Skip these tests for WK2.

  • platform/wk2/Skipped:
2:40 PM Changeset in webkit [111068] by Lucas Forschler
  • 2 edits in branches/safari-534.56-branch/Source/WebCore

Merged r107102.

2:37 PM Changeset in webkit [111067] by Lucas Forschler
  • 17 edits in branches/safari-534.56-branch/Source

Merge 106977.

2:30 PM Changeset in webkit [111066] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix rounding and usage of LayoutUnits in RenderBoxModelObject
​https://bugs.webkit.org/show_bug.cgi?id=81057

Reviewed by Julien Chaffraix.

No new tests.

(WebCore):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):
Fix implementation of pixelSnappedOffsetWidth/Height. The location
parameter will be ignored until we enable subpixel support.

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use ints for border widths.

(WebCore::resolveWidthForRatio):
(WebCore::resolveHeightForRatio):
(WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio):
(WebCore::resolveAgainstIntrinsicRatio):
Change resolve*Ratio methods to operate on IntSizes as none of the
callers need subpixel precision.

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
Pixel snap paintRect when computing image geometry.

2:19 PM Changeset in webkit [111065] by timothy_horton@apple.com
  • 1 edit
    22 adds in trunk/LayoutTests

Unreviewed new mac baselines after ​http://trac.webkit.org/changeset/108185

  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
2:15 PM Changeset in webkit [111064] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk

100% height elements to not respond to vertical browser rescaling
​https://bugs.webkit.org/show_bug.cgi?id=43022

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-03-16
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/replaced/vertical-resize-100percent-element.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

For the case where a replaced element has a percentage height,
we update the entries in RenderBlock::gPercentHeightDescendantsMap
corresponding to all ancestors of the replaced element.

LayoutTests:

  • fast/replaced/resources/vertical-resize-100percent-contents.html: Added.
  • fast/replaced/vertical-resize-100percent-element-expected.txt: Added.
  • fast/replaced/vertical-resize-100percent-element.html: Added.

Layout test to ensure that an image with 100% height is resized when
its containing iframe is vertically resized to be larger or smaller.

  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

Rebaseline for chromium. This patch causes a progression in this layout test. In the
diff, note that the viewport has height 585, which is 600 minus 15 pixels to account for
the horizontal scrollbar. In the old expected output the first image to be displayed
has height 600, which is incorrect because it should be 100% of the viewport height.
The new expected output shows the first image with the correct height of 585.

  • platform/chromium/test_expectations.txt:

WIN will need a regenerated image, and MAC will need a regenerated image+text.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

Skip the rebaselined test on all other platforms.

2:08 PM Changeset in webkit [111063] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking media/track/track-active-cues.html as flaky timeout on windows.

  • platform/chromium/test_expectations.txt:
1:53 PM Changeset in webkit [111062] by Lucas Forschler
  • 2 edits in branches/safari-534.56-branch/Source/WebKit2

Merged r103880.

1:53 PM Changeset in webkit [111061] by dcheng@chromium.org
  • 19 edits in trunk

[chromium] Refactor ClipboardChromium and DataTransferItemList/DataTransferItem to support HTML spec
​https://bugs.webkit.org/show_bug.cgi?id=76598

Reviewed by Tony Chang.

Source/WebCore:

We no longer store drag/clipboard data in named fields. We used to maintain the data store
list separately, which resulted in a lot of complicated code to try to make sure that
ChromiumDataObject and this list stayed in sync. We now just store what is essentially a
list MIME type/data pairs directly in ChromiumDataObject. This has the benefit of letting us
easily add write support during dragstart/copy operations using DataTransferItemList.

Tests: fast/events/clipboard-dataTransferItemList.html

fast/events/drag-dataTransferItemList.html

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::findItem):
(WebCore::ChromiumDataObject::createFromPasteboard):
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::copy):
(WebCore::ChromiumDataObject::items):
(WebCore::ChromiumDataObject::clearData):
(WebCore::ChromiumDataObject::clearAll):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::setData):
(WebCore::ChromiumDataObject::urlAndTitle):
(WebCore::ChromiumDataObject::setURLAndTitle):
(WebCore::ChromiumDataObject::htmlAndBaseURL):
(WebCore::ChromiumDataObject::setHTMLAndBaseURL):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore):
(WebCore::ChromiumDataObject::filenames):
(WebCore::ChromiumDataObject::addFilename):
(WebCore::ChromiumDataObject::addSharedBuffer):
(WebCore::ChromiumDataObject::ChromiumDataObject):

  • platform/chromium/ChromiumDataObject.h:

(WebCore):
(ChromiumDataObject):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::normalizeType):
(WebCore::ClipboardChromium::ClipboardChromium):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::clearAllData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::files):
(WebCore::writeImageToDataObject):
(WebCore::ClipboardChromium::declareAndWriteDragImage):
(WebCore::ClipboardChromium::writeURL):
(WebCore::ClipboardChromium::writeRange):
(WebCore::ClipboardChromium::writePlainText):
(WebCore::ClipboardChromium::hasData):
(WebCore::ClipboardChromium::items):

  • platform/chromium/ClipboardChromium.h:

(WebCore):
(ClipboardChromium):
(WebCore::ClipboardChromium::frame):

  • platform/chromium/ClipboardUtilitiesChromium.cpp:

(WebCore::convertURIListToURL):
(WebCore):

  • platform/chromium/ClipboardUtilitiesChromium.h:

(WebCore):

  • platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::createFromString):
(WebCore::DataTransferItemChromium::createFromFile):
(WebCore::DataTransferItemChromium::createFromURL):
(WebCore::DataTransferItemChromium::createFromHTML):
(WebCore):
(WebCore::DataTransferItemChromium::createFromSharedBuffer):
(WebCore::DataTransferItemChromium::createFromPasteboard):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
(WebCore::DataTransferItemChromium::internalGetAsString):
(WebCore::DataTransferItemChromium::isFilename):

  • platform/chromium/DataTransferItemChromium.h:

(WebCore):
(DataTransferItemChromium):
(WebCore::DataTransferItemChromium::kind):
(WebCore::DataTransferItemChromium::type):
(WebCore::DataTransferItemChromium::sharedBuffer):
(WebCore::DataTransferItemChromium::title):
(WebCore::DataTransferItemChromium::baseURL):

  • platform/chromium/DataTransferItemListChromium.cpp:

(WebCore::DataTransferItemListChromium::create):
(WebCore::DataTransferItemListChromium::createFromPasteboard):
(WebCore):
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
(WebCore::DataTransferItemListChromium::length):
(WebCore::DataTransferItemListChromium::item):
(WebCore::DataTransferItemListChromium::deleteItem):
(WebCore::DataTransferItemListChromium::clear):
(WebCore::DataTransferItemListChromium::add):
(WebCore::DataTransferItemListChromium::internalAddStringItem):
(WebCore::DataTransferItemListChromium::internalAddFileItem):

  • platform/chromium/DataTransferItemListChromium.h:

(WebCore):
(DataTransferItemListChromium):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asFragment):

Source/WebKit/chromium:

  • src/WebDragData.cpp:

(WebKit::WebDragData::items):
(WebKit::WebDragData::addItem):
(WebKit::WebDragData::assign):

LayoutTests:

  • fast/events/clipboard-dataTransferItemList-expected.txt: Added.
  • fast/events/clipboard-dataTransferItemList.html: Added.
  • fast/events/drag-dataTransferItemList-expected.txt: Added.
  • fast/events/drag-dataTransferItemList.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
1:49 PM Changeset in webkit [111060] by Lucas Forschler
  • 2 edits in branches/safari-534.56-branch/Source/WebKit2

Merged r103843.

1:49 PM Changeset in webkit [111059] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

ASSERTION FAILED: m_loadState == LoadStateCommitted in WebFrameProxy::didFinishLoad causing
"crashes" on Lion Intel Debug WebKit2 Tests
​https://bugs.webkit.org/show_bug.cgi?id=81184
<rdar://problem/11052462>

Rubber-stamped by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::finishedLoading): Don't leave a lingering m_pluginView after load is finished. When plug-in data was empty, we would create the plug-in here, but failed to finalize the load.
1:48 PM Changeset in webkit [111058] by mlilek@apple.com
  • 2 edits in trunk/Source/WebCore

Don't install libWebCoreTestSupport on OS X production builds
​https://bugs.webkit.org/show_bug.cgi?id=81087

Reviewed by Mark Rowe.

  • Configurations/WebCoreTestSupport.xcconfig:
1:41 PM Changeset in webkit [111057] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

Skip move-by-word-visually-wrong-left-right.html added in r110965 in wk2 since SetEditingBehavior is not supported.

  • platform/wk2/Skipped:
1:32 PM Changeset in webkit [111056] by eae@chromium.org
  • 989 edits
    159 copies
    18 deletes in branches/subpixellayout

Merge trunk changes up until r111035 into subpixel branch.

1:27 PM Changeset in webkit [111055] by arv@chromium.org
  • 3 edits in trunk/LayoutTests

Fix layout test to output the same result for V8 and JSC
​https://bugs.webkit.org/show_bug.cgi?id=81395

Reviewed by Nate Chapin.

  • fast/dom/inline-event-attributes-crash-expected.txt:
  • fast/dom/inline-event-attributes-crash.html:
1:25 PM Changeset in webkit [111054] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/rendering/RenderingAllInOne.cpp

Add RenderMultiColumnBlock.cpp to RenderingAllInOne.cpp for Windows build.

1:16 PM Changeset in webkit [111053] by tony@chromium.org
  • 5 edits in trunk

incorrectly removing scrollbar height for auto height flexbox children
​https://bugs.webkit.org/show_bug.cgi?id=81388

Reviewed by Ojan Vafai.

Source/WebCore:

In a column flexbox, when computing the preferred height of an auto
height child, we were subtracting out the horizontal scrollbar height.

New test case in css3/flexbox/columns-auto-size.html.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):

LayoutTests:

  • css3/flexbox/columns-auto-size-expected.txt:
  • css3/flexbox/columns-auto-size.html:
1:15 PM Changeset in webkit [111052] by Lucas Forschler
  • 1 move in branches/safari-534.56-branch

Branch name update.

1:08 PM Changeset in webkit [111051] by adamk@chromium.org
  • 9 edits
    2 adds in trunk

Out-of-document radio buttons should be grouped when associated with a form
​https://bugs.webkit.org/show_bug.cgi?id=81268

Reviewed by Kent Tamura.

Source/WebCore:

Per the HTML spec, and the behavior of Firefox and IE 8/9, radio buttons
with a form owner should be grouped, even if that form is not in the document.

r104668 added many inDocument() tests to radio button grouping code.
While those are necessary to avoid unattached <input type=radio>
elements being grouped together, it also kept them from being grouped
when associated with a form outside the document.

This patch changes the HTMLInputElement::checkedRadioButtons() method
to return either a pointer to the proper CheckedRadioButtons instance
(either the document's or a form's), but will return null if the
element should not be associated with any radio button group.

The main fallout of this was that the callers of checkedRadioButtons()
now have to check for null, resulting in the creation of a few helper
methods in HTMLInputElement to wrap the null checks.

This refactoring has the pleasant side-effect of exposing a cleaner API between
HTMLInputElement and RadioInputType, and making a clearer contract
between HTMLInputElement and CheckedRadioButtons (e.g., all
CheckedRadioButtons methods that take an element can now assume that
it is a radio button, where previously some checked for that and
others asserted it).

Test: fast/forms/radio/radio-group-in-detached-form.html

  • dom/CheckedRadioButtons.cpp:

(WebCore): Removed shouldMakeRadioGroup() helper function.
(WebCore::CheckedRadioButtons::addButton): Replace call to shouldMakeRadioGroup
with appropriate assert and name check.
(WebCore::CheckedRadioButtons::updateCheckedState): ditto.
(WebCore::CheckedRadioButtons::requiredAttributeChanged): ditto.
(WebCore::CheckedRadioButtons::isRequiredGroup): Renamed from isInRequiredGroup,
changed to take only a group name, not an element.
(WebCore::CheckedRadioButtons::removeButton): Replace call to shouldMakeRadioGroup.
with appropriate assert and name check.

  • dom/CheckedRadioButtons.h:

(CheckedRadioButtons):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::~HTMLInputElement): Added isRadioButton check
now that it's asserted in CheckedRadioButtons.
(WebCore::HTMLInputElement::updateType): Call helper method instead of
calling directly into CheckedRadioButtons.
(WebCore::HTMLInputElement::parseAttribute): ditto.
(WebCore::HTMLInputElement::setChecked): ditto.
(WebCore::HTMLInputElement::willChangeForm): ditto.
(WebCore::HTMLInputElement::didChangeForm): ditto.
(WebCore::HTMLInputElement::insertedIntoDocument): ditto.
(WebCore::HTMLInputElement::removedFromDocument): ditto.
(WebCore::HTMLInputElement::didMoveToNewDocument): Added isRadioButton check.
(WebCore::HTMLInputElement::requiredAttributeChanged): Check for membership in a group
before calling into CheckedRadioButtons.
(WebCore::HTMLInputElement::isInRequiredRadioButtonGroup): Added helper method for use by RadioInputType.
(WebCore):
(WebCore::HTMLInputElement::checkedRadioButtonForGroup): ditto.
(WebCore::HTMLInputElement::checkedRadioButtons): Changed to return a
pointer, only return non-null if actually a member of a group.
(WebCore::HTMLInputElement::addToRadioButtonGroup): Helper method for
use in HTMLInputElement.
(WebCore::HTMLInputElement::removeFromRadioButtonGroup): ditto.

  • html/HTMLInputElement.h:

(HTMLInputElement): Added/removed methods, removed outdated comment about visibility.

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::valueMissing): Call new HTMLInputElement methods instead
of interacting directly with CheckedRadioButtons.
(WebCore::RadioInputType::isKeyboardFocusable): ditto.
(WebCore::RadioInputType::willDispatchClick): ditto.

LayoutTests:

  • fast/forms/radio/radio-group-expected.txt:
  • fast/forms/radio/radio-group-in-detached-form-expected.txt: Added.
  • fast/forms/radio/radio-group-in-detached-form.html: Added.
  • fast/forms/radio/radio-group.html: Updated to match new behavior.
1:00 PM Changeset in webkit [111050] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Syncing up left over bits in WebCoreSupport from our local branch to upstream
​https://bugs.webkit.org/show_bug.cgi?id=81120

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This is a consolidation of various changes that are in our local dev branch
but do not appear in our upstreamed port.

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/AboutDataHaveFeatures.in:
  • WebCoreSupport/AboutDataUseFeatures.in:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::hasOpenedPopup):
(WebCore):
(WebCore::ChromeClientBlackBerry::screenToRootView):
(WebCore::ChromeClientBlackBerry::rootViewToScreen):
(WebCore::ChromeClientBlackBerry::invalidateRootView):
(WebCore::ChromeClientBlackBerry::invalidateContentsAndRootView):
(WebCore::ChromeClientBlackBerry::invalidateContentsForSlowScroll):
(WebCore::ChromeClientBlackBerry::scrollableAreasDidChange):
(WebCore::ChromeClientBlackBerry::createColorChooser):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):
(WebCore::ChromeClientBlackBerry::numTouchEventHandlersChanged):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::registerUndoStep):
(WebCore::EditorClientBlackBerry::registerRedoStep):
(WebCore::EditorClientBlackBerry::undo):
(WebCore::EditorClientBlackBerry::redo):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

  • WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::requestPermission):
(GeolocationControllerClientBlackBerry::cancelPermissionRequest):

  • WebCoreSupport/GeolocationControllerClientBlackBerry.h:
  • WebCoreSupport/InspectorClientBlackBerry.cpp:

(WebCore::InspectorClientBlackBerry::closeInspectorFrontend):
(WebCore):
(WebCore::InspectorClientBlackBerry::bringFrontendToFront):

  • WebCoreSupport/InspectorClientBlackBerry.h:

(InspectorClientBlackBerry):

  • WebCoreSupport/NotificationPresenterImpl.cpp:

(WebCore::NotificationPresenterImpl::show):

12:57 PM Changeset in webkit [111049] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/Target.pri

Missed adding new files to Targets.pri

12:55 PM Changeset in webkit [111048] by hyatt@apple.com
  • 14 edits
    2 adds in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=81366

Add RenderMultiColumnBlock subclass of RenderBlock. This new class will hold all of the multi-column
logic (as well as painting/hit testing). That way the column code can be kept out of the base class
and be more cleanly factored.

Patch Node::diff so that we detach and re-attach the renderer if column counts or widths change
from auto to non-auto (and vice versa) to ensure the right renderer gets made.

Patch RenderObject::createObject to make a RenderMultiColumnBlock if either the column count or
column width is non-auto.

Patch RenderBlock::calcColumnWidth to "turn off" the old implementation of columns if the pref to use
the new column implementation is set. This single chokepoint should be sufficient for disabling the old
columns in favor of the new.

Reviewed by Dan Bernstein.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::regionBasedColumnsEnabled):
(WebCore):
(WebCore::Document::recalcStyle):

  • dom/Document.h:

(Document):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • dom/Node.cpp:

(WebCore::Node::diff):

  • dom/Node.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::updateFirstLetterStyle):

  • rendering/RenderMultiColumnBlock.cpp: Added.

(WebCore):
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::renderName):

  • rendering/RenderMultiColumnBlock.h: Added.

(WebCore):
(RenderMultiColumnBlock):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

12:45 PM Changeset in webkit [111047] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Improve CSS3 filter blur performance.
​https://bugs.webkit.org/show_bug.cgi?id=81360

This change improves blur performance by 2-2.5X on blurred CSS
3D transforms and accelerated canvas demos by skipping an unnecessary
texture allocation and bitmap draw.

Reviewed by James Robinson.

Covered by existing layout tests in css3/filters.

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):
Call SkCanvas::drawSprite() directly instead of using
saveLayer()/restore().

12:43 PM Changeset in webkit [111046] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline GTK expected results after r111041.

  • platform/gtk/accessibility/media-element-expected.txt:
12:41 PM Changeset in webkit [111045] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

plugins/keyboard-events.html, mouse-events-fixedpos.html, and mouse-events.html failing on Lion
Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81386

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/plugins/keyboard-events-expected.txt: Added.
  • platform/mac-wk2/plugins/mouse-events-expected.txt: Added.
  • platform/mac-wk2/plugins/mouse-events-fixedpos-expected.txt: Added.
12:26 PM Changeset in webkit [111044] by jsbell@chromium.org
  • 9 edits
    2 adds in trunk

[Chromium] IndexedDB: Assertion failure when storing File objects
​https://bugs.webkit.org/show_bug.cgi?id=76746

Source/WebCore:

The blob data in Blob/File/FileList objects is serialized "by reference" (the
internal URL) rather than "by value" (the actual data); this is sufficient for
postMessage() but not for IndexedDB since the referenced data is not retained
Expose a mechanism to enumerate the URLs so that SSVs can be rejected by IDB
until blob data serialization can is implemented (outside the SSV mechanism, and
potentially asynchronously).

Also, correct issue in V8DOMWrapper::instantiateV8Object where context is assumed
to be a Worker context if it's not a Window, which is incorrect for the
Chromium utility process; this is hit if Blobs are not blocked.

Reviewed by Tony Chang.

Test: storage/indexeddb/noblobs.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update): Reject SSVs that contain blob references.

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::add): Reject SSVs that contain blob references.
(WebCore::IDBObjectStore::put): Reject SSVs that contain blob references.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):
(CloneSerializer):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):

  • bindings/js/SerializedScriptValue.h: New API to enable the clients to be picky.
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::SerializedScriptValue):

  • bindings/v8/SerializedScriptValue.h: New API to enable the clients to be picky.

(WebCore::SerializedScriptValue::blobURLs):
(SerializedScriptValue):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object): Ensure context is a worker context before treating it as such.

LayoutTests:

Ensure that Blob/File/FileList types are rejected in IDB values, to detect regressions.

Reviewed by Tony Chang.

  • storage/indexeddb/noblobs-expected.txt: Added.
  • storage/indexeddb/noblobs.html: Added.
12:23 PM Changeset in webkit [111043] by arv@chromium.org
  • 3 edits
    2 adds in trunk

[V8] Ensure that invalid syntax in inline event handlers does not cause a crash
​https://bugs.webkit.org/show_bug.cgi?id=81385

Reviewed by Nate Chapin.

Source/WebCore:

The way that V8 does its inline event handler involves concatting strings and
if the attribute value is crafted in a special way this could cause a crash.

Test: fast/dom/inline-event-attributes-crash.html

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

  • fast/dom/inline-event-attributes-crash-expected.txt: Added.
  • fast/dom/inline-event-attributes-crash.html: Added.
12:22 PM Changeset in webkit [111042] by ojan@chromium.org
  • 11 edits
    1 copy
    18 adds
    1 delete in trunk/LayoutTests

Chromium rebaselines for expected failures on garden-o-matic.

  • platform/chromium-linux-x86/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-linux/compositing/color-matching/pdf-image-match-expected.png: Added.
  • platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/cross-fade-border-image-source-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.txt: Added.
  • platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-win-vista/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Removed.
  • platform/chromium-win-xp/compositing/reflections/animation-inside-reflection-expected.txt: Added.
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Copied from LayoutTests/platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt.
  • platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png:
  • platform/chromium-win/compositing/color-matching/pdf-image-match-expected.png: Added.
  • platform/chromium-win/compositing/color-matching/pdf-image-match-expected.txt: Added.
  • platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt:
  • platform/chromium/test_expectations.txt:
12:21 PM Changeset in webkit [111041] by jer.noble@apple.com
  • 28 edits in trunk

Wrong icon to restore to windowed mode in full screen video panel
​https://bugs.webkit.org/show_bug.cgi?id=70437

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Updated platform/mac/accessibility/media-element-expected.txt.

Renamed MediaFullscreenButton to MediaEnterFullscreenButton and added MediaExitFullscreenButton:

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::controlTypeName):
(WebCore::AccessibilityMediaControl::roleValue):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • platform/ThemeTypes.h:

Added setIsFullscreen which controls the display of the enter/exit fullscreen button:

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::setIsFullscreen): Added.

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::exitedFullscreen):

Paint the enter/exit fullscreen button accordingly:

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::paintMediaFullscreenButton):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaFullscreenButton):

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::paintMediaControlsPart):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMediaFullscreenButton):

Update the localized strings for the exit and enter fullscreen buttons:

  • English.lproj/Localizable.strings:
  • platform/LocalizedStrings.cpp:

(WebCore::localizedMediaControlElementString):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

  • platform/qt/LocalizedStringsQt.cpp:

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

WebKitLibraries:

  • WebKitSystemInterface.h: Added WKMediaUIPartExitFullscreenButton.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:

LayoutTests:

  • platform/mac/accessibility/media-element-expected.txt:
12:07 PM Changeset in webkit [111040] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Update LayoutUnit usage in RenderListBox
​https://bugs.webkit.org/show_bug.cgi?id=81038

Reviewed by Julien Chaffraix.

Bringing RenderListBox in line with the rules listed in
​https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintScrollbar): Pixel snapping before handing off scrollbar
painting to the platform.
(WebCore::RenderListBox::paintItemForeground): Rounding the offset for text painting.
(WebCore::RenderListBox::paintItemBackground): Pixel snapping the background rect.
(WebCore::RenderListBox::panScroll): EventHandler::currentMousePosition is an IntPoint,
so it doesn't require additional rounding in RenderListBox.

12:02 PM Changeset in webkit [111039] by ojan@chromium.org
  • 5 edits in trunk/Tools

Have webkit-patch rebaseline-test update test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=81054

Recommit ​http://trac.webkit.org/changeset/110783 now that
​http://trac.webkit.org/changeset/111034 has landed.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.remove_configuration_from_test):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(RemoveConfigurationsTest):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._update_expectations_file):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest):
(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):

11:57 AM Changeset in webkit [111038] by jer.noble@apple.com
  • 3 edits in trunk/LayoutTests

Rebaseline window-properties-expected on GTK; add two new tests
to the GTK Skipped list associated with existing bug:
​https://bugs.webkit.org/show_bug.cgi?id=61118

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
11:39 AM Changeset in webkit [111037] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Input fields with id of e-mail and url should be styled as such.
​https://bugs.webkit.org/show_bug.cgi?id=81364

Patch by Mike Fenton <​mifenton@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Treat fields that have name/id's that match url or
email as url or email fields providing the appropriate
keyboard.

PR 137259.

Reviewed Internally by Gen Mak and Nima Ghanavatian.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::matchesReservedStringEmail):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesEmail):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesUrl):
(BlackBerry::WebKit::DOMSupport::matchesReservedStringPreventingAutocomplete):

  • WebKitSupport/DOMSupport.h:

(WebCore):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertInputType):
(BlackBerry::WebKit::inputStyle):

11:33 AM Changeset in webkit [111036] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Mark form-associated-element-crash3.html as flakily timing out, since it often passes.

  • platform/chromium/test_expectations.txt:
11:33 AM Changeset in webkit [111035] by pkasting@chromium.org
  • 3 edits
    3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r111020.
​http://trac.webkit.org/changeset/111020
​https://bugs.webkit.org/show_bug.cgi?id=81377

Broke Chromium Win compile (Requested by pkasting on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-16

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • platform/mediastream/PeerConnection00Handler.cpp: Removed.
  • platform/mediastream/PeerConnection00Handler.h: Removed.
  • platform/mediastream/PeerConnection00HandlerClient.h: Removed.
11:31 AM Changeset in webkit [111034] by ojan@chromium.org
  • 6 edits in trunk/Tools

Specifier collapsing when writing test expectations lines gets a number of cases wrong
​https://bugs.webkit.org/show_bug.cgi?id=81309

Reviewed by Dimitri Glazkov.

I've run this over all the lines in the current Chromium test_expectations.txt file,
so I'm relatively confident we now cover all the cases.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.init):
(TestConfigurationConverter.collapse_macros):
(TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
(TestConfigurationConverter):
(TestConfigurationConverter.intersect_combination):
(TestConfigurationConverter.symmetric_difference):
(TestConfigurationConverter.to_specifiers_list):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:

(make_mock_all_test_configurations_set):
(TestConfigurationConverterTest.test_symmetric_difference):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_converter_macro_collapsing):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
The android port uses "arm" as it's architecture, which is technically correct,
but considerably complicates making collapsing work. We probably should kill
the concept of architecture entirely. The benefits are not worth the code
complexity.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):

11:27 AM Changeset in webkit [111033] by jberlin@webkit.org
  • 1 edit
    16 adds in trunk/LayoutTests

6 platform/mac/editing/spelling autocorrect-related tests failing on Lion Intel Debug WebKit2
testers
​https://bugs.webkit.org/show_bug.cgi?id=81375

Add expected failing results to get the bots green.

  • platform/mac-wk2/platform/mac/editing/spelling/autocorrection-contraction-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/autocorrection-contraction-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.
11:27 AM Changeset in webkit [111032] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

platform/mac/editing/spelling/editing-word-with-marker-1.html failing on Lion Intel Debug
testers
​https://bugs.webkit.org/show_bug.cgi?id=81372

Add expected failing results to get the bots green.

  • platform/mac/editing/spelling/editing-word-with-marker-1-expected.txt:
11:27 AM Changeset in webkit [111031] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

platform/mac/editing/spelling/autocorrection-contraction.html fails on Lion Intel Debug testers.
​https://bugs.webkit.org/show_bug.cgi?id=81369

Add expected failing results to get the bots green.

  • platform/mac/editing/spelling/autocorrection-contraction-expected.png:
  • platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
11:23 AM Changeset in webkit [111030] by dmazzoni@google.com
  • 3 edits
    2 adds in trunk

File input control accessibility can cause a crash
​https://bugs.webkit.org/show_bug.cgi?id=80896

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/input-file-causes-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

LayoutTests:

  • accessibility/input-file-causes-crash-expected.txt: Added.
  • accessibility/input-file-causes-crash.html: Added.
11:21 AM Changeset in webkit [111029] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] compositing tests with videos fail in chromium DumpRenderTree, seeking doesn't appear to work
​https://bugs.webkit.org/show_bug.cgi?id=76511

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-03-16
Reviewed by Eric Carlson.

  • compositing/resources/media-testing.js:

(ensureFrameVisible.playingHandler):
(ensureFrameVisible.seekedHandler):
(ensureFrameVisible):

11:12 AM Changeset in webkit [111028] by jer.noble@apple.com
  • 18 edits
    6 adds in trunk

Support W3C Full Screen API proposal
​https://bugs.webkit.org/show_bug.cgi?id=80660

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: fullscreen/full-screen-element-stack.html

fullscreen/full-screen-enabled.html
fullscreen/full-screen-restrictions.html

The W3C proposal for taking arbitrary elements into full-screen mode is significantly
different than the Mozilla proposal. For example, the W3C has proposed a lower-case "s"
in "Fullscreen", which means the W3C and Mozilla "requestFullscreen" APIs differ only by
in that lower-case "s". Annoying as this is, it does allow us to retain the semantics for
the Mozilla case (har!).

A significant difficulty is obeying the new W3C spec rules is that we would like to apply the
fullscreen CSS rules while exiting fullscreen mode, though the W3C spec insists that the
webkitFullscreenElement returns the new value immediately. As such, we retain the m_fullScreenElement
variable (distinct from the top of the m_fullScreenElements stack) which is controlled by the
webkit{Will,Did}{Enter,Exit}FullScreen functions.

New APIs for the W3C Fullscreen spec:

  • dom/Document.h:

(WebCore::Document::webkitFullscreenElement):
(WebCore::Document::webkitFullscreenEnabled):

  • dom/Document.idl:
  • dom/Element.cpp:

(WebCore::Element::webkitRequestFullscreen):

  • dom/Element.h:
  • dom/Element.idl:
  • dom/Document.cpp:

(WebCore::Document::removedLastRef): Clear m_fullScreenElementStack.
(WebCore::Document::requestFullScreenForElement): Implement the W3C requirements.
(WebCore::Document::webkitExitFullscreen): Ditto.
(WebCore::Document::webkitCancelFullScreen): Implement in terms of webkitCancelFullscreen.
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired): Protect against items being

added to the event and error queue by swapping out empty queues before starting.

(WebCore::Document::clearFullscreenElementStack): Simple accessor.
(WebCore::Document::popFullscreenElementStack): Ditto.
(WebCore::Document::pushFullscreenElementStack): Ditto.

  • dom/Element.cpp:

(WebCore::Element::webkitRequestFullScreen):

Add new RuntimeEnabledFeatures functions for the added Document and Element functions.

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenEnabledEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitExitFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullscreenEnabled):

Source/WebKit/mac:

Allow full screen elements to access the keyboard.

  • WebView/WebView.mm:

(-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):

Source/WebKit2:

Allow full screen elements to access the keyboard.

  • UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::supportsFullScreen):

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::exitFullScreenForElement):

LayoutTests:

  • fullscreen/full-screen-element-stack-expected.txt: Added.
  • fullscreen/full-screen-element-stack.html: Added.
  • fullscreen/full-screen-enabled-expected.txt: Added.
  • fullscreen/full-screen-enabled.html: Added.
  • fullscreen/full-screen-request-rejected.html:
  • fullscreen/full-screen-request-removed.html:
  • fullscreen/full-screen-restrictions-expected.txt: Added.
  • fullscreen/full-screen-restrictions.html: Added.
  • fullscreen/full-screen-test.js:
11:00 AM Changeset in webkit [111027] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] WebKitWebResource::load-failed uses the wrong marshaller
​https://bugs.webkit.org/show_bug.cgi?id=81229

Patch by Victor Lucero <​victor.lucero@ipartner.cl> on 2012-03-16
Reviewed by Philippe Normand.

  • webkit/webkitwebresource.cpp:

(webkit_web_resource_class_init): load-failed signal in WebkitWebResource was using the wrong marshaller

10:58 AM Changeset in webkit [111026] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

Make HTMLInputElement::isRadioButton non-virtual and remove unused HTMLFormControlElement::isRadioButton method
​https://bugs.webkit.org/show_bug.cgi?id=81255

Reviewed by Kent Tamura.

No new tests, no change in behavior.

  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.h:

(HTMLInputElement):

10:43 AM Changeset in webkit [111025] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Update NetworkJob to accept batched headers
​https://bugs.webkit.org/show_bug.cgi?id=81273

Batch up the headers into a vector before they come into
webkit to increase performance, and simplify the API.

Patch by Tay Grigg <​tgrigg@rim.com> on 2012-03-16
Reviewed by George Staikos.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyHeadersReceived):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

10:17 AM Changeset in webkit [111024] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
​https://bugs.webkit.org/show_bug.cgi?id=81105

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This patches fixes up a previous sync done in this directory and adds some new bits
as well. This is accurate as of ddea1528b37b29925638fe1183318b3c3994f1f8 in our
local repo.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::webContext):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

10:14 AM Changeset in webkit [111023] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Add overdraw metrics for texture uploads
​https://bugs.webkit.org/show_bug.cgi?id=81175

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Record texture upload metrics during paint. To properly record
the amount of pixels culled, we must compute the amount of pixels we
would have uploaded for a tile. This requires knowing the dirty rect of
the tile, but the dirty rect can be changed by WebKit during a paint, so
we always store the dirtyRect in the tile's updateRect. We add an
m_updateCulled bool to the UpdatableTile structure, to identify tiles
that were not updated, and know a tile was updated if updateRect is not
empty and updateCulled is false.

Tested by all TiledLayerChromiumTests that use occlusion tracker.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

10:07 AM Changeset in webkit [111022] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

Allow AudioContext::create() to emit an ExceptionCode.
​https://bugs.webkit.org/show_bug.cgi?id=81049

Reviewed by Kentaro Hara.

No new tests; no change in functionality.

Pass through an ExceptionCode parameter to AudioContext::create(). It is currently
never modified, but exceptions will be added in the future.

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • webaudio/AudioContext.h:
9:59 AM Changeset in webkit [111021] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Remove surface damage client from occlusion tracker
​https://bugs.webkit.org/show_bug.cgi?id=81242

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Code was not used yet, so no new tests. Removing tests instead!

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):
(WebCore::::layerScissorRectInTargetSurface):
(WebCore):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(WebCore):
(CCOcclusionTrackerBase):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):

9:56 AM Changeset in webkit [111020] by tommyw@google.com
  • 3 edits
    3 adds in trunk/Source/WebCore

MediaStream API (JSEP): Introducing PeerConnection00Handler
​https://bugs.webkit.org/show_bug.cgi?id=81333

Reviewed by Adam Barth.

In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.

Not possible to test until the entire JSEP feature is commited.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • platform/mediastream/PeerConnection00Handler.cpp: Added.

(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):

  • platform/mediastream/PeerConnection00Handler.h: Added.

(WebCore):
(PeerConnection00Handler):

  • platform/mediastream/PeerConnection00HandlerClient.h: Added.

(WebCore):
(PeerConnection00HandlerClient):
(WebCore::PeerConnection00HandlerClient::~PeerConnection00HandlerClient):

9:56 AM Changeset in webkit [111019] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Input processing mode should be cancelled when processing hot keys
​https://bugs.webkit.org/show_bug.cgi?id=81348

Patch by Mike Fenton <​mifenton@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Don't suppress IMF notifications if we are handling
the event as a hotkey.

Reviewed Internally by Nima Ghanavatian.

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::handleKeyboardEvent):

9:49 AM Changeset in webkit [111018] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix exception when hovering over bound function in heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=81362

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):

9:49 AM Changeset in webkit [111017] by sfalken@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/testRegExp/testRegExpReleasePGO.vsprops

Windows build fix.

9:49 AM Changeset in webkit [111016] by xji@chromium.org
  • 3 edits in trunk/LayoutTests

Skip visual word movement tests in gtk and qt after r110965 since isWordTextBreak is not implemented.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
9:43 AM Changeset in webkit [111015] by abecsi@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Fix bounce-back behaviour for panning
​https://bugs.webkit.org/show_bug.cgi?id=81144

Reviewed by Kenneth Rohde Christiansen.

If the pan gesture recognizer receives a touch begin event
during an ongoing kinetic scroll animation of a previous
pan gesture, the animation is stopped and the content is
immediately positioned back to valid boundaries.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
(WebKit):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

9:40 AM Changeset in webkit [111014] by Martin Robinson
  • 2 edits in trunk/Source/WebKit/gtk

WebKit/gtk/resources/error.html font-size error
​https://bugs.webkit.org/show_bug.cgi?id=39232

Patch by Landry Breuil <​landry@openbsd.org> on 2012-03-14
Reviewed by Martin Robinson.

Fix font-size in the 404 error page. Apparently the % is filtered out,
so 120% becomes 120 and the error message is huge. Experienced in epiphany.

  • resources/error.html: Double the % so it doesn't get filtered
9:26 AM Changeset in webkit [111013] by msaboff@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Improve diagnostic benefit of JSGlobalData::m_isInitializingObject
​https://bugs.webkit.org/show_bug.cgi?id=81244

Rubber stamped by Filip Pizlo.

Changed type and name of JSGlobalData::m_isInitializingObject to
ClassInfo* and m_initializingObjectClass.
Changed JSGlobalData::setInitializingObject to
JSGlobalData::setInitializingObjectClass. This pointer can be used within
the debugger to determine what type of object is being initialized.

  • runtime/JSCell.h:

(JSC::JSCell::finishCreation):
(JSC::allocateCell):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):
(JSC::JSGlobalData::isInitializingObject):
(JSC::JSGlobalData::setInitializingObjectClass):

  • runtime/Structure.h:

(JSC::JSCell::finishCreation):

9:16 AM Changeset in webkit [111012] by commit-queue@webkit.org
  • 10 edits
    6 adds in trunk

[Qt][Wk2] Assertion Failure and crash on file upload
​https://bugs.webkit.org/show_bug.cgi?id=80854

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-03-16
Reviewed by Simon Hausmann.

Source/WebKit2:

Crash resulted from attempting to create QFileDialog, a QtWidget based dialog from a
QGuiApplication. Replace QFileDialog with a QML implementable component.
Added a new property 'filePicker' to WebView experimental to set the QML component for
file upload triggered by an input file element.

Co-authored with Kasthuri Nallappasoundararajan <​kasthuri.n-s@nokia.com>

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::chooseFiles):
(QQuickWebViewExperimental::filePicker):
(QQuickWebViewExperimental::setFilePicker):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_singleFileUpload.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/singlefileupload.html: Added.
  • UIProcess/qt/QtDialogRunner.cpp:

(FilePickerContextObject):
(FilePickerContextObject::FilePickerContextObject):
(FilePickerContextObject::fileList):
(FilePickerContextObject::reject):
(FilePickerContextObject::accept):
(QtDialogRunner::initForFilePicker):

  • UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner):
(QtDialogRunner::filePaths):
(QtDialogRunner::onFileSelected):

Tools:

Added filePicker to WebView using experimental API.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/icons/folder.png: Added.
  • MiniBrowser/qt/icons/titlebar.png: Added.
  • MiniBrowser/qt/icons/up.png: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/FilePicker.qml: Added.
9:04 AM Changeset in webkit [111011] by mahesh.kulkarni@nokia.com
  • 2 edits in trunk/Tools

Updating email for committer.py script.

  • Scripts/webkitpy/common/config/committers.py:
8:51 AM Changeset in webkit [111010] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[Qt][WK2] Build failure when using --no-touch-events
​https://bugs.webkit.org/show_bug.cgi?id=81241

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-03-16
Reviewed by Simon Hausmann.

Fixed inconsistency in the use of ENABLE_TOUCH_EVENTS flag that caused build
failure when using --no-touch-events option

  • UIProcess/qt/QtPageClient.h:

(QtPageClient):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handlePotentialSingleTapEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
8:01 AM Changeset in webkit [111009] by commit-queue@webkit.org
  • 13 edits in trunk

[Forms] The "progress" element should not be a form-associated element.
​https://bugs.webkit.org/show_bug.cgi?id=80240

Patch by Yoshifumi Inoue <​yosin@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes base class of HTMLProgressElement to LabelableElement from
HTMLFormControlElement for saving memory space and iteration time of
extra "progress" elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.

Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
​https://bugs.webkit.org/show_bug.cgi?id=80381

No new tests. Update existing tests to cover this change.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement): Moved the "progress" element support code from canShareStyleWithControl.
(WebCore::CSSStyleSelector::canShareStyleWithControl):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Remove isFormControlElement check for PseudoIndeterminate.

  • editing/TextIterator.cpp:

(WebCore::TextIterator::advance): Check HTMLProgressElement in addition to isFormControlElement. This change is for text dump in LayoutTests implemented by document.innerText attribute.

  • html/HTMLProgressElement.cpp: Remove unused include file.

(WebCore::HTMLProgressElement::HTMLProgressElement): Changed base class to LabelableElement.
(WebCore::HTMLProgressElement::create): Remove form paraprogress.
(WebCore::HTMLProgressElement::parseAttribute): Replace HTMLFormControlElement to LabelableElement.
(WebCore::HTMLProgressElement::attach): Replace HTMLFormControlElement to LabelableElement.

  • html/HTMLProgressElement.h:

(HTMLProgressElement):

  • html/HTMLProgressElement.idl: Remove the "form" attribute which isn't listed in the HTML5 specification.
  • html/HTMLTagNames.in: Remove "constructorNeedsFormElement" for not passing "form" parameter in HTMLElementFactory.

LayoutTests:

This patch changes tests for non-existent "form" attribute of the
"progress" element. The "form" attribute is available only for
form-associate elements. However, the "progress" element isn't.

  • fast/dom/HTMLProgressElement/progress-element-form-expected.txt: Update expectation for test output changes.
  • fast/dom/HTMLProgressElement/progress-element-form.html: Changed for the "progress" element doesn't have IDL attribute "form".
  • fast/forms/form-attribute-expected.txt: Update expectation for test output changes.
  • fast/forms/form-attribute.html: Removed lines for the "progress" element.
7:54 AM Changeset in webkit [111008] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Heap Snapshot: Unreviewed single line fix for isWindow getter.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isWindow):

7:53 AM Changeset in webkit [111007] by tommyw@google.com
  • 4 edits in trunk/Source/WebCore

MediaStream API (JSEP): Fixing a few nits
​https://bugs.webkit.org/show_bug.cgi?id=81322

Reviewed by Adam Barth.

Addressing the nits from bugs 81206 and 81207.

Nothing to test.

  • Modules/mediastream/SessionDescription.idl:
  • platform/mediastream/IceOptions.h:

(WebCore::IceOptions::IceOptions):

  • platform/mediastream/SessionDescriptionDescriptor.h:

(SessionDescriptionDescriptor):

7:48 AM Changeset in webkit [111006] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[chromium] DRT: Add support for sending gesture scrolls without a begin
​https://bugs.webkit.org/show_bug.cgi?id=81292

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureScrollFirstPoint):

  • DumpRenderTree/chromium/EventSender.h:

(EventSender):

7:44 AM Companies and Organizations that have contributed to WebKit edited by lfelipe@profusion.mobi
Adding ProFUSION to the list of companies that have contributed to WebKit (diff)
7:43 AM Changeset in webkit [111005] by yurys@chromium.org
  • 12 edits in trunk/Source/WebCore

Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
​https://bugs.webkit.org/show_bug.cgi?id=80789

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-03-16
Reviewed by Yury Semikhatsky.

OptOutput class is added for optional return parameters.

Strict mode added to Generator that makes all parameter types strict
and drop pre-set default values for return parameters.

Debugger and Page domain is switched to strict mode.

  • inspector/CodeGeneratorInspector.py:

(CommandReturnPassModel.OptOutput):
(CommandReturnPassModel.OptOutput.init):
(CommandReturnPassModel.OptOutput.get_return_var_type):
(CommandReturnPassModel.OptOutput.get_output_argument_prefix):
(CommandReturnPassModel.OptOutput.get_output_to_raw_expression):
(CommandReturnPassModel.OptOutput.get_output_parameter_type):
(CommandReturnPassModel):
(CommandReturnPassModel.OptOutput.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(OptOutput):
(Generator.process_event):
(Generator.process_command):

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:

(ContentSearchUtils):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

7:01 AM Changeset in webkit [111004] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

The IDL parser should support sequence<T> type
​https://bugs.webkit.org/show_bug.cgi?id=81345

Reviewed by Adam Barth.

This patch makes the IDL parser support sequence<T> type.
This patch just makes sequence<T> parseable, and the generated code
for sequence<T> is wrong. This issue will be soon fixed in bug 80696.
This is a preparing patch for bug 80696.

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/test/TestObj.idl: Added tests for sequence<T>.
  • bindings/scripts/IDLStructure.pm: Updated the regular expressions to support sequence<T>.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.

(WebDOMTestObj::sequenceAttr):
(WebDOMTestObj::setSequenceAttr):
(WebDOMTestObj::methodWithSequenceArg):
(WebDOMTestObj::methodReturningSequence):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_with_sequence_arg):
(webkit_dom_test_obj_method_returning_sequence):
(webkit_dom_test_obj_get_sequence_attr):
(webkit_dom_test_obj_set_sequence_attr):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjSequenceAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj sequenceAttr]):
(-[DOMTestObj setSequenceAttr:]):
(-[DOMTestObj methodWithSequenceArg:]):
(-[DOMTestObj methodReturningSequence:]):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::sequenceAttrAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::sequenceAttrAttrSetter):
(WebCore::TestObjInternal::methodWithSequenceArgCallback):
(WebCore::TestObjInternal::methodReturningSequenceCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

6:50 AM Changeset in webkit [111003] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: HeapSnapshot: merge two long operations into one.
​https://bugs.webkit.org/show_bug.cgi?id=81347

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.aggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates.forDominatedNodes):

6:45 AM Changeset in webkit [111002] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] QtWebKit documentation missing a few since 4.6 information
​https://bugs.webkit.org/show_bug.cgi?id=81328

Patch by Teemu Katajisto <​teemu.katajisto@digia.com> on 2012-03-16
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:
  • Api/qwebsettings.cpp:
6:42 AM Changeset in webkit [111001] by kenneth@webkit.org
  • 13 edits in trunk/Source/WebKit2

Merge setVisibleContentsForScaling with setVisibleContentsRectForPanning
​https://bugs.webkit.org/show_bug.cgi?id=81346

Reviewed by Simon Hausmann.

This cleans up the code path and is one step on the way to avoid
calling both methods in succession, for instance after ending pinch
zoom.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_commitScaleChange):
(QQuickWebViewPrivate::_q_commitPositionChange):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::setVisibleContentsRect):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):

  • UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::setVisibleContentsRect):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::setVisibleContentsRect):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentsRect):

  • WebProcess/WebPage/LayerTreeHost.messages.in:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::setVisibleContentsRect):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

6:35 AM Changeset in webkit [111000] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Can not open certain links from bridge applications
​https://bugs.webkit.org/show_bug.cgi?id=81197

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2012-03-16
Reviewed by Rob Buis.

Currently, the engine asks the client to handle some type of requests externally.
But WebPageClient::handleStringPattern is not yet implemented and exposed to
the client. Before that, we still need to give the client a chance to decide
how to handle requests such as 'mailto:'.

To address this problem, r108763 introduced a change that ask the client to
decide how to handle the navigation in dispatchDecidePolicyForNewWindowAction().
This is not intuitive and will bring troubles, because this navigation will
happen in the new page. So the new page client is to decide how to handle
the navigation, not the old one.

This patch reverts r108763 and skips calling WebPageClient::handleStringPattern
since it's not implemented.

This way the new window action will continue, and the logic in
dispatchDecidePolicyForNavigationAction() will handle the navigation correctly.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

6:34 AM Changeset in webkit [110999] by sergio@webkit.org
  • 17 edits
    4 adds in trunk

[GTK] WebKitIconDatabase doesn't keep icons cached
​https://bugs.webkit.org/show_bug.cgi?id=56200

Reviewed by Martin Robinson.

Source/WebKit/gtk:

  • GNUmakefile.am: Added new files to compilation.
  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::registerForIconNotification): instruct
the WebView to listen to IconDatabase's notifications.
(WebKit::FrameLoaderClient::dispatchDidReceiveIcon): ask both
WebView and IconDatabase to issue notifications for a new icon.

  • docs/webkitgtk-docs.sgml: updated docs.
  • docs/webkitgtk-sections.txt: ditto.
  • docs/webkitgtk.types: ditto.
  • tests/testicondatabase.c: Added.

(server_callback):
(deleteDatabaseFileIfExists):
(testWebkitIconDatabaseSetPath):
(iconDatabaseGetIconValidCallback):
(iconDatabaseGetIconInvalidCallback):
(iconDatabaseGetIconCancelledCallback):
(mainLoopQuitIfLoadCompleted):
(idleQuitLoopCallback):
(webkitWebViewIconLoaded):
(loadURI):
(faviconDatabaseGetFaviconValidIdle):
(faviconDatabaseGetFaviconInvalidIdle):
(faviconDatabaseGetFaviconCancelledIdle):
(testWebKitFaviconDatabaseGetFavicon):
(testWebKitFaviconDatabaseGetFaviconURI):
(testWebKitFaviconDatabaseRemoveAll):
(testWebKitFaviconDatabaseCloseDatabase):
(main):

  • webkit/webkit.h: added new API.
  • webkit/webkitdefines.h: added WebKitFaviconDatabase.
  • webkit/webkitfavicondatabase.cpp:

(IconDatabaseClientGtk): IconDatabaseClient implementation.
(IconDatabaseClientGtk::performImport):
(IconDatabaseClientGtk::didRemoveAllIcons):
(IconDatabaseClientGtk::didImportIconURLForPageURL):
(IconDatabaseClientGtk::didImportIconDataForPageURL):
(IconDatabaseClientGtk::didChangeIconForPageURL):
(IconDatabaseClientGtk::didFinishURLImport):
(PendingIconRequest): machinery for asynchronous calls.
(PendingIconRequest::PendingIconRequest):
(PendingIconRequest::~PendingIconRequest):
(PendingIconRequest::pageURI):
(PendingIconRequest::asyncResult):
(PendingIconRequest::asyncResultCancel):
(PendingIconRequest::asyncResultCompleteInIdle):
(PendingIconRequest::asyncResultComplete):
(_WebKitIconDatabasePrivate):
(webkit_favicon_database_dispose): GObject stuff.
(webkit_favicon_database_set_property): ditto.
(webkit_favicon_database_get_property): ditto.
(webkit_favicon_database_class_init): ditto.
(webkit_favicon_database_init): ditto.
(webkitFaviconDatabaseNotifyAndUpdateExpiration): notify about new
icons and update expiration times.
(webkitFaviconDatabaseDispatchDidReceiveIcon): "protected" method
called by the FrameLoaderClient to inform about new icons.
(webkit_favicon_database_get_path): retrieves database path.
(selectQueryCallback): releases expired icons to let IconDatabase
prune them.
(webkitFaviconDatabasePruneExpiredIcons): selects the icons to be
pruned by the IconDatabase.
(webkitFaviconDatabaseClose): close the database.
(createExpirationTimesDatabaseTableIfNotExists): creates the
database used to control expiration times.
(webkit_favicon_database_set_path): opens the database delaying the
cleanup of icons until the import is complete.
(webkit_favicon_database_get_favicon_uri): returns the uri of the
favicon.
(getIconPixbufSynchronously): helper function to call
IconDatabase::synchronousIconURLForPageURL().
(webkit_favicon_database_try_get_favicon_pixbuf): returns the
favicon if exists and is loaded from disk.
(webkitFaviconDatabaseGetOrCreateRequests): helper function to get
the vector of pending requests for the given uri.
(webkitfavicondatabaseDeleteRequests): helper function to remove the
vector of pending requests for the given uri.
(getIconPixbufCancelled):
(webkitFaviconDatabaseGetIconPixbufCancelled):
(webkit_favicon_database_get_favicon_pixbuf): asynchronously
retrieve icons from the database.
(webkit_favicon_database_get_favicon_pixbuf_finish): finishes an
operation started with webkit_icon_database_get_icon_pixbuf().
(webkitFaviconDatabaseProcessPendingIconsForURI): process pending
requests once the import is finished.
(webkitFaviconDatabaseImportFinished): check pending requests and
delete those that ask for icons that do not exist in the database.
(webkit_favicon_database_clear): clears the database.

  • webkit/webkitfavicondatabase.h: added.

(_WebKitFaviconDatabase):
(_WebKitFaviconDatabaseClass):

  • webkit/webkitfavicondatabaseprivate.h: Added.
  • webkit/webkitglobals.cpp:

(webkit_get_favicon_database): retrieves the new
WebKitFaviconDatabase.
(webkitExit): unref icon database on exit.

  • webkit/webkitglobals.h: added new API.
  • webkit/webkiticondatabase.cpp: added deprecation documentation.

(webkit_icon_database_class_init):

  • webkit/webkitwebview.cpp:

(webkit_web_view_try_get_icon_pixbuf): new API that uses the new
WebKitFaviconDatabase API.
(webkitWebViewIconLoaded): dispatch the icon-loaded signal when
requested by the FrameLoaderClient.
(webkitWebViewRegisterForIconNotification): starts/stops listening
to icon database notifications.

  • webkit/webkitwebview.h: added new API.
  • webkit/webkitwebviewprivate.h: added some protected methods.

Tools:

Add support for favicons in GtkLauncher.

  • GtkLauncher/main.c:

(activateUriEntryCb):
(iconLoadedCb):
(createBrowser):

6:25 AM Changeset in webkit [110998] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

Add asserts and improve logging in PageCache.
​https://bugs.webkit.org/show_bug.cgi?id=81179

Reviewed by Brady Eidson.

The early exits from logCanCacheFrameDecision had the potential to skew histogram data. Moving
the DocumentLoader check to the top, but eliminating the early exits is a compromise that keeps
the logged data mostly accurate.

  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):

6:13 AM Changeset in webkit [110997] by abarth@webkit.org
  • 7 edits in trunk/Tools

Remove sheriff-bot's last-green-revision command
​https://bugs.webkit.org/show_bug.cgi?id=81314

Reviewed by Eric Seidel.

This command is a cruel joke. WebKit doesn't really ever have a
last-green-revision.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot._find_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:

(MockBuildBot.builder_statuses):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_find_green_revision):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(IRCCommand.execute):

  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

(SheriffIRCBotTest.test_help):

  • Scripts/webkitpy/tool/commands/queries.py:

(PatchesToReview.execute):

6:05 AM Changeset in webkit [110996] by commit-queue@webkit.org
  • 10 edits in trunk

[Forms] label.form attribute doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=80499

Patch by Yoshifumi Inoue <​yosin@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes implementation of label.form of IDL attribute to
compute it to the form element specified by the "form" HTML attribute
or form ancestor when the "form" HTML attribute isn't in HTML.

This patch introduces new function FormAssociatedElement::findAssociatedForm
for sharing code among FormAssociateElement::insertedIntoTree, resetFormOwner
and HTMLLabelElement::form.

No new tests. Update existing tests.

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::findAssociatedForm): Added.
(WebCore):
(WebCore::FormAssociatedElement::insertedIntoTree):
(WebCore::FormAssociatedElement::resetFormOwner):

  • html/FormAssociatedElement.h:

(FormAssociatedElement):

  • html/HTMLLabelElement.cpp: Remove unused include files

(WebCore::HTMLLabelElement::form): Added.

LayoutTests:

This patch updates test cases and expectation for functional
"form" attribute of the "label" element.

  • fast/forms/form-attribute-expected.txt:
  • fast/forms/form-attribute-nonexistence-form-id-expected.txt:
  • fast/forms/form-attribute-nonexistence-form-id.html:
  • fast/forms/form-attribute.html:
6:00 AM Changeset in webkit [110995] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebCore

Use the normalize method of FloatPoint instead of normalizing manually
​https://bugs.webkit.org/show_bug.cgi?id=81343

Reviewed by Simon Hausmann.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::coverWithTilesIfNeeded):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):

5:54 AM UsingGitHub edited by jarred@sencha.com
(diff)
5:51 AM UsingGitHub edited by jarred@sencha.com
(diff)
5:50 AM Changeset in webkit [110994] by haraken@chromium.org
  • 13 edits
    3 adds in trunk/Source/WebCore

Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl
​https://bugs.webkit.org/show_bug.cgi?id=79636

Reviewed by Adam Barth.

For WebKit modularization, this patch moves Notifications-related APIs
from DOMWindow.idl to DOMWindowNotifications.idl.

Tests: fast/notifications/* (No change in test results)

  • CMakeLists.txt: Added DOMWindowNotifications.{h,cpp,idl}.
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.exp.in: Added mangled signatures of webkitNotifications().
  • notifications/DOMWindowNotifications.cpp: Added.

(WebCore):
(WebCore::DOMWindowNotifications::DOMWindowNotifications):
(WebCore::DOMWindowNotifications::~DOMWindowNotifications):
(WebCore::DOMWindowNotifications::from):
(WebCore::DOMWindowNotifications::webkitNotifications):
(WebCore::DOMWindowNotifications::ensureWebkitNotifications):
(WebCore::DOMWindowNotifications::disconnectFrame):

  • notifications/DOMWindowNotifications.h: Added.

(WebCore):
(DOMWindowNotifications):

  • notifications/DOMWindowNotifications.idl: Added.
  • page/DOMWindow.cpp: Removed ENABLE(NOTIFICATIONS).

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::clear):

  • page/DOMWindow.h: Ditto.

(WebCore):
(DOMWindow):

  • page/DOMWindow.idl: Ditto.
  • page/Frame.cpp: Ditto.

(WebCore::Frame::willDetachPage):
(WebCore::Frame::transferChildFrameToNewDocument):

5:49 AM UsingGitHub edited by jarred@sencha.com
(diff)
5:46 AM Changeset in webkit [110993] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Make gccdepends test aware of broken icecream deps generation

Icecream seems to build the files without passing -o to gcc with
the original destination path, which means the target name in the
dependency file is wrong.

Also, echo something to the final file instead of just touching it,
so it's not deleted on every build.

Reviewed by Simon Hausmann.

5:31 AM Changeset in webkit [110992] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[Performance] Optimize innerHTML and outerHTML
​https://bugs.webkit.org/show_bug.cgi?id=81214

Reviewed by Adam Barth.

This patch makes innerHTML and outerHTML 2.4 times faster.

Performance test: ​https://bugs.webkit.org/attachment.cgi?id=132034
The performance test measures body.innerHTML for 3000 lines of HTML,
which is copied from the HTML spec.

  • Chromium/Mac without the patch

div.innerHTML: 1658.6 ms
div.outerHTML: 4859.6 ms
body.innerHTML: 640.2 ms
body.outerHTML: 641.8 ms

  • Chromium/Mac with the patch

div.innerHTML: 751.0 ms
div.outerHTML: 2096.0 ms
body.innerHTML: 271.2 ms
body.outerHTML: 271.2 ms

  • Chromium/Linux without the patch

div.innerHTML: 950.4 ms
div.outerHTML: 2257.8 ms
body.innerHTML: 452.8 ms
body.outerHTML: 457.6 ms

  • Chromium/Linux with the patch

div.innerHTML: 582.4 ms
div.outerHTML: 1283.0 ms
body.innerHTML: 233.0 ms
body.outerHTML: 233.4 ms

  • AppleWebKit/Mac without the patch

div.innerHTML: 900.6 ms
div.outerHTML: 2245.2 ms
body.innerHTML: 462.6 ms
body.outerHTML: 468.0 ms

  • AppleWebKit/Mac with the patch

div.innerHTML: 529.8 ms
div.outerHTML: 1090.2 ms
body.innerHTML: 239.2 ms
body.outerHTML: 239.2 ms

This patch applies the following two optimizations:

(a) Remove redundant copies between Vector<String> and StringBuilders
in MarkupAccumulator::serializeNodes(), MarkupAccumulator::appendStartTag(),
and MarkupAccumulator::appendEndTag().

(Previous behavior)

  • Create a StringBuilder for each tag.
  • Append a created string in each StringBuilder to Vector<String>, parsing the DOM tree.
  • After the parsing, allocate a StringBuilder whose size is the sum of all Strings in Vector<String>.
  • Append all Strings in Vector<String> to the StringBuilder. (New behavior)
  • Allocate a StringBuilder with a default buffer size.
  • Append created strings to the StringBuilder, incrementally parsing the DOM tree.

(b) Optimize stringBuilder.append().

(b-1) Replace stringBuilder.append("A") with stringBuilder.append('A').

stringBuilder.append("A") requires to cast the characters to LChar*,
and then call strlen("A"). stringBuilder.append('A') is faster.

(b-2) Replace stringBuilder.append("AB") with stringBuilder.append('A')

and stringBuilder.append('B'). In my experiment, appending characters
one by one is faster than appending the characters at a breath if the
number of characters is less than 3.

(b-3) Hard-code a string length; i.e. replace stringBuilder.append("ABCDE")

with stringBuilder.append("ABCDE", 5). While the former requires to call
strlen("ABCDE"), the latter does not.

(a) improves performance by 170% ~ 200%. (b) improves performance by 30 ~ 40%.

Tests: fast/dom/Range/range-extract-contents.html

fast/dom/serialize-nodes.xhtml
fast/dom/XMLSerializer.html
and all other tests that use innerHTML or outerHTML.
No change in the test results.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::serializeNodes):
(WebCore::MarkupAccumulator::appendString):
(WebCore::MarkupAccumulator::appendStartTag):
(WebCore::MarkupAccumulator::appendEndTag):
(WebCore::MarkupAccumulator::concatenateMarkup):
(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendDocumentType):
(WebCore::MarkupAccumulator::appendProcessingInstruction):
(WebCore::MarkupAccumulator::appendOpenTag):
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::appendCDATASection):

  • editing/MarkupAccumulator.h:

(MarkupAccumulator):

5:23 AM Changeset in webkit [110991] by commit-queue@webkit.org
  • 23 edits
    39 adds in trunk

.: Support for Battery Status API.
​https://bugs.webkit.org/show_bug.cgi?id=62698

Enable BATTERY_STATUS for WebKit-Efl.
​http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore: Support for Battery Status API
​https://bugs.webkit.org/show_bug.cgi?id=62698

Battery Status API is implemented under the Navigator class.
Battery Status API has four types of events, and all events are operated based on a callback mechanism.

: onchargingchange, onchargingtimechange, ondischargingtimechange, onlevelchange.

The battery status can be accessed using BatteryManager(navigator.webkitBattery), and battery status is controlled by BatteryController which manages instances of BatteryManager.
When battery status event is raised, BatteryController calls all registered BatteryManager's event dispatcher.
​http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

Tests: batterystatus/add-listener-from-callback.html

batterystatus/basic-all-types-of-events.html
batterystatus/basic-operation.html
batterystatus/event-after-navigation.html
batterystatus/multiple-frames.html
batterystatus/updates.html
batterystatus/window-property.html

  • CMakeLists.txt:
  • Modules/battery/BatteryClient.h: Added.

(WebCore):
(BatteryClient):
(WebCore::BatteryClient::~BatteryClient):

  • Modules/battery/BatteryController.cpp: Added.

(WebCore):
(WebCore::BatteryController::BatteryController):
(WebCore::BatteryController::~BatteryController):
(WebCore::BatteryController::create):
(WebCore::BatteryController::addListener):
(WebCore::BatteryController::removeListener):
(WebCore::BatteryController::didChangeBatteryStatus):
(WebCore::BatteryController::supplementName):
(WebCore::BatteryController::isActive):
(WebCore::provideBatteryTo):

  • Modules/battery/BatteryController.h: Added.

(WebCore):
(BatteryController):
(WebCore::BatteryController::client):
(WebCore::BatteryController::from):

  • Modules/battery/BatteryManager.cpp: Added.

(WebCore):
(WebCore::BatteryManager::create):
(WebCore::BatteryManager::~BatteryManager):
(WebCore::BatteryManager::BatteryManager):
(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):
(WebCore::BatteryManager::didChangeBatteryStatus):
(WebCore::BatteryManager::suspend):
(WebCore::BatteryManager::resume):
(WebCore::BatteryManager::stop):

  • Modules/battery/BatteryManager.h: Added.

(WebCore):
(BatteryManager):
(WebCore::BatteryManager::interfaceName):
(WebCore::BatteryManager::scriptExecutionContext):
(WebCore::BatteryManager::batteryControllerDestroyed):
(WebCore::BatteryManager::canSuspend):
(WebCore::BatteryManager::eventTargetData):
(WebCore::BatteryManager::ensureEventTargetData):
(WebCore::BatteryManager::refEventTarget):
(WebCore::BatteryManager::derefEventTarget):

  • Modules/battery/BatteryManager.idl: Added.
  • Modules/battery/BatteryStatus.cpp: Added.

(WebCore):
(WebCore::BatteryStatus::create):
(WebCore::BatteryStatus::BatteryStatus):

  • Modules/battery/BatteryStatus.h: Added.

(WebCore):
(BatteryStatus):
(WebCore::BatteryStatus::charging):
(WebCore::BatteryStatus::chargingTime):
(WebCore::BatteryStatus::dischargingTime):
(WebCore::BatteryStatus::level):

  • Modules/battery/NavigatorBattery.cpp: Added.

(WebCore):
(WebCore::NavigatorBattery::NavigatorBattery):
(WebCore::NavigatorBattery::~NavigatorBattery):
(WebCore::NavigatorBattery::webkitBattery):
(WebCore::NavigatorBattery::from):
(WebCore::NavigatorBattery::batteryManager):

  • Modules/battery/NavigatorBattery.h: Added.

(WebCore):
(NavigatorBattery):

  • Modules/battery/NavigatorBattery.idl: Added.
  • dom/EventNames.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • testing/Internals.cpp:

(WebCore::Internals::setBatteryStatus):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit: Support for Battery Status API
​https://bugs.webkit.org/show_bug.cgi?id=62698

Add include directory and file.
​http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • PlatformEfl.cmake:

Source/WebKit/efl: Support for Battery Status API
​https://bugs.webkit.org/show_bug.cgi?id=62698

Add BatteryClientEfl class implementation for the layout tests now.
BatteryClientEfl class is not fully implemented in this patch.
(It will be completed by other patch as necessary in the Efl port.)
​http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • WebCoreSupport/BatteryClientEfl.cpp: Added.

(WebCore):
(WebCore::BatteryClientEfl::BatteryClientEfl):
(WebCore::BatteryClientEfl::setController):
(WebCore::BatteryClientEfl::startUpdating):
(WebCore::BatteryClientEfl::stopUpdating):
(WebCore::BatteryClientEfl::batteryControllerDestroyed):
(WebCore::BatteryClientEfl::setBatteryStatus):

  • WebCoreSupport/BatteryClientEfl.h: Added.

(WebCore):
(BatteryClientEfl):
(WebCore::BatteryClientEfl::~BatteryClientEfl):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Tools: Support for Battery Status API
​https://bugs.webkit.org/show_bug.cgi?id=62698

Add include directory and file.
​http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • Scripts/build-webkit:

LayoutTests: Support for Battery Status API.
​https://bugs.webkit.org/show_bug.cgi?id=62698

Add new test cases for Battery Status API.
​http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • batterystatus/add-listener-from-callback-expected.txt: Added.
  • batterystatus/add-listener-from-callback.html: Added.
  • batterystatus/basic-all-types-of-events-expected.txt: Added.
  • batterystatus/basic-all-types-of-events.html: Added.
  • batterystatus/basic-operation-expected.txt: Added.
  • batterystatus/basic-operation.html: Added.
  • batterystatus/event-after-navigation-expected.txt: Added.
  • batterystatus/event-after-navigation.html: Added.
  • batterystatus/multiple-frames-expected.txt: Added.
  • batterystatus/multiple-frames.html: Added.
  • batterystatus/resources/event-after-navigation-new.html: Added.
  • batterystatus/script-tests/add-listener-from-callback.js: Added.

(checkBatteryStatus):
(firstListener):
(secondListener):
(maybeFinishTest):

  • batterystatus/script-tests/basic-all-types-of-events.js: Added.

(checkBatteryStatus):
(battery):

  • batterystatus/script-tests/basic-operation.js: Added.
  • batterystatus/script-tests/event-after-navigation.js: Added.
  • batterystatus/script-tests/multiple-frames.js: Added.

(checkBatteryStatus):
(checkChildBatteryStatus):
(mainFrameListener):
(childFrameListener):
(maybeFinishTest):

  • batterystatus/script-tests/updates.js: Added.

(checkBatteryStatus):
(setBatteryStatus):
(firstListener):
(updateListener):

  • batterystatus/script-tests/window-property.js: Added.

(hasOnBatteryProperty):

  • batterystatus/updates-expected.txt: Added.
  • batterystatus/updates.html: Added.
  • batterystatus/window-property-expected.txt: Added.
  • batterystatus/window-property.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
5:14 AM Changeset in webkit [110990] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=81007

Patch by Kishore Bolisetty <​kbolisetty@innominds.com> on 2012-03-16
Reviewed by Adam Barth.

A dedidcated build slave is available for efl on build.webkit.org.
This change add's an entry for the elf port in list of available port builders.
This is required because test_expectations.py when triggered, looks for a valid port object for the specified port.

  • Scripts/webkitpy/layout_tests/port/builders.py:
4:55 AM Changeset in webkit [110989] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: HeapSnapshot: speedup buildReverseIndex.
​https://bugs.webkit.org/show_bug.cgi?id=81327

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
(WebInspector.HeapSnapshot.prototype._findNearestNodeIndex):
(WebInspector.HeapSnapshot.prototype._getRetainerIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype):

4:41 AM Changeset in webkit [110988] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add ProcessLauncherEfl.cpp
​https://bugs.webkit.org/show_bug.cgi?id=75464

Patch by YoungTaeck Song <​youngtaeck.song@samsung.com> on 2012-03-16
Reviewed by Hajime Morita.

Add first version of ProcessLauncherEfl.cpp including launchProcess() and terminateProcess().

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp: Added.

(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::terminateProcess):
(WebKit::ProcessLauncher::platformInvalidate):

4:37 AM Changeset in webkit [110987] by abarth@webkit.org
  • 2 edits in trunk/Tools

[webkitpy] StatusServer.next_work_item has an incorrectly named local variable
​https://bugs.webkit.org/show_bug.cgi?id=81302

Reviewed by Eric Seidel.

This is a trivial patch, but the variable name turned up in a grep of
webkitpy and looks like copy pasta.

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer.next_work_item):

4:29 AM Changeset in webkit [110986] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r110976.
​http://trac.webkit.org/changeset/110976
​https://bugs.webkit.org/show_bug.cgi?id=81330

webkit_unit_tests crashes. (Requested by morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-16

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::error):
(WebCore):

  • loader/cache/CachedCSSStyleSheet.h:

(CachedCSSStyleSheet):

  • loader/cache/CachedFont.cpp:

(WebCore):
(WebCore::CachedFont::error):

  • loader/cache/CachedFont.h:

(CachedFont):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::error):

  • loader/cache/CachedResource.h:

(CachedResource):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::error):
(WebCore):

  • loader/cache/CachedScript.h:

(CachedScript):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::error):
(WebCore):

  • loader/cache/CachedXSLStyleSheet.h:

(CachedXSLStyleSheet):

4:25 AM Changeset in webkit [110985] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement cast between CSSPrimitiveValue and LineClampValue.
​https://bugs.webkit.org/show_bug.cgi?id=76806

Reviewed by Andreas Kling.

Covered by many existing LayoutTests.

This simplifies code in CSSStyleSelector and future mapping to CSSStyleApplyProperty.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineClampValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

4:03 AM Changeset in webkit [110984] by nduca@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Bump textureUpdatesPerFrame to 32 to favor updating the screen over jank prevention
​https://bugs.webkit.org/show_bug.cgi?id=81298

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WTF):

3:52 AM Changeset in webkit [110983] by leviw@chromium.org
  • 6 edits in trunk/Source/WebCore

Update usage of LayoutUnits in RenderBlock*
​https://bugs.webkit.org/show_bug.cgi?id=80437

Reviewed by Julien Chaffraix.

Updating LayoutUnit usage in RenderBlock and RenderBlockLineLayout. This better readies trunk for
the transition to subpixel layout.

See ​https://trac.webkit.org/wiki/LayoutUnit for more details.

No new tests. No changed behavior.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Adding the paint offset rounding previously in RenderBlock::paint.

  • rendering/LayoutTypes.h:

(WebCore::floorToInt): Will floor a LayoutUnit to an integer once we switch to
FractionalLayoutUnits.
(WebCore::boundedMultiply): Method that will return the multiplied result of two LayoutUnits
or the max/min LayoutUnit if the result overflows. Only does a regular multiply while
LayoutUnits are integers instead of FractionalLayoutUnits.
(WebCore):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContents): Rounding the paintOffset here didn't work for all
inline blocks. This rounding is actually only needed for InlineTextBoxes, so the logic has
been moved there.
(WebCore::RenderBlock::newLine): Use a LayoutUnit for the y position.
(WebCore::RenderBlock::isPointInOverflowControl): Points for hit testing need to be rounded.
(WebCore::RenderBlock::layoutColumns): Using boundedMultiply for a calculation prone to overflow.
(WebCore::updatePreferredWidth): Reverting back to using ceilf. ceiledLayoutUnit was to be ultimately
converted to just a straight LayoutUnit constructor to preserve precision. This precision doesn't work
for us here as we still paint Boxes/Blocks on pixel boundaries, so we need to expand to a pixel size
that encloses the contained text.
(WebCore::RenderBlock::setPageLogicalOffset): LogicalOffset should be a LayoutUnit.
(WebCore::RenderBlock::marginValuesForChild): Margins should have subpixel resolution.
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject): Intervals for floating objects
need to use pixel snapped values to give the proper results.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine): Only moved.
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine): While we can round the left offset,
columns add an extra offset at paint that can't currently be planned for at line-layout time. To
avoid laying out lines that run off the end of columns, we floor the right offset. The resulting
lines will be up to 1 pixel shorter than they potentially could be.
(RenderBlock):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX): Using corresponding pixelSnappedX value from
LayoutRects.
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedY): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight): Ditto.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): LogicalHeight is a LayoutUnit. Also
flooring textIndentOffset to an integer to match old behavior.
(WebCore::LineWidth::fitBelowFloats): Using LayoutUnits for float logical top and bottoms.
(WebCore::LineLayoutState::endLineLogicalTop): Changing to a LayoutUnit.
(WebCore::LineLayoutState::setEndLineLogicalTop): Ditto.
(LineLayoutState): Ditto.
(WebCore::RenderBlock::linkToEndLineIfNeeded): Calculating overflow with LayoutUnits.
(WebCore::RenderBlock::layoutInlineChildren): LowestAllowedPosition should be subpixel.
(WebCore::RenderBlock::checkLinesForTextOverflow): Reverting ellipsis width calculation to integers
as this value can be seen as representing pixels on screen.

3:39 AM Changeset in webkit [110982] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash when going back from an xhtml document containing <img>
​https://bugs.webkit.org/show_bug.cgi?id=81297

Reviewed by Rob Buis.

This is manually reverting the offending internal commit which checked-in before upstreaming.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::canCachePage):

3:34 AM Changeset in webkit [110981] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebCore

Follow up to: window.innerWidth/Height should not include page scale ​https://bugs.webkit.org/show_bug.cgi?id=76555

Reviewed by Simon Hausmann.

Introduce mapping methods for converting between CSS and layout units.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):

  • page/FrameView.h:

(FrameView):
(WebCore::FrameView::mapFromLayoutToCSSUnits):
(WebCore):
(WebCore::FrameView::mapFromCSSToLayoutUnits):

3:29 AM Changeset in webkit [110980] by commit-queue@webkit.org
  • 17 edits in trunk/Source

[chromium] Threaded opacity animation jump to opacity of 0
​https://bugs.webkit.org/show_bug.cgi?id=80744

Patch by Ian Vollick <​vollick@chromium.org> on 2012-03-16
Reviewed by James Robinson.

Source/WebCore:

Tested in CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::opacityIsAnimating):
(WebCore):
(WebCore::LayerChromium::transformIsAnimating):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::drawOpacityIsAnimating):
(WebCore::LayerChromium::setDrawOpacityIsAnimating):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::drawOpacityIsAnimating):
(WebCore::RenderSurfaceChromium::setDrawOpacityIsAnimating):
(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::isAnimatingProperty):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationController):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:

(WebCore::CCLayerAnimationControllerImpl::isAnimatingProperty):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:

(CCLayerAnimationControllerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::opacityIsAnimating):
(WebCore):
(WebCore::CCLayerImpl::transformIsAnimating):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::drawOpacityIsAnimating):
(WebCore::CCLayerImpl::setDrawOpacityIsAnimating):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerShouldBeSkipped):
(WebCore::subtreeShouldBeSkipped):
(WebCore):
(WebCore::LayerChromium):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::drawOpacityIsAnimating):
(WebCore::CCRenderSurface::setDrawOpacityIsAnimating):
(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::beginTest):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::animateLayers):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::afterTest):
(WTF::TEST_F):

3:21 AM Changeset in webkit [110979] by jocelyn.turcotte@nokia.com
  • 5 edits in trunk/Source/WebCore

[TexMap] Reuse textures following the same rules as they do internally.
​https://bugs.webkit.org/show_bug.cgi?id=80843

Reviewed by Noam Rosenthal.

BitmapTextures were recently changed to be the same size as their contents.
This would obsolete the logic in acquireTextureFromPool which would
assume that a BitmapTexture has good chances of being reused if its
size is bigger or equal to the new size.

This asks the texture instead if it can be reused which now simply
check for an exact size match.

  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore::TextureMapper::acquireTextureFromPool):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::canReuseWith):
(WebCore::BitmapTexture::reset):
(WebCore::BitmapTexture::didReset):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::canReuseWith):
(WebCore):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

3:20 AM Changeset in webkit [110978] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Connect up fling event delivery to gesture curve animation framework
​https://bugs.webkit.org/show_bug.cgi?id=80858

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::fireUpAnAnimation):

3:11 AM FeatureFlags edited by tkent@chromium.org
Add a comment on Hixie76 flag of WebSocket (diff)
2:48 AM Changeset in webkit [110977] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, marking a failing test.

  • platform/chromium/test_expectations.txt:
2:40 AM Changeset in webkit [110976] by Nate Chapin
  • 11 edits in trunk/Source/WebCore

Remove duplicate error() impls in CachedResource subclasses
​https://bugs.webkit.org/show_bug.cgi?id=81161

Reviewed by Alexey Proskuryakov.

No new tests, refactor only.

  • loader/cache/CachedCSSStyleSheet.cpp:
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedResource.h: Make checkNotify()

virtual, so the right checkNotify() gets called in error().

  • loader/cache/CachedScript.cpp:
  • loader/cache/CachedScript.h:
  • loader/cache/CachedXSLStyleSheet.cpp:
  • loader/cache/CachedXSLStyleSheet.h:
2:28 AM Changeset in webkit [110975] by Philippe Normand
  • 1 edit
    17 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new tests.

  • platform/gtk/compositing/overflow/ancestor-overflow-expected.txt: Added.
  • platform/gtk/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
  • platform/gtk/fast/line-grid/line-align-left-edges-expected.txt: Added.
  • platform/gtk/fast/line-grid/line-align-right-edges-expected.txt: Added.
  • platform/gtk/fast/repaint/transform-rotate-and-remove-expected.txt: Added.
  • platform/gtk/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/gtk/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/gtk/fast/speech/speech-bidi-rendering-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
  • platform/gtk/svg/custom/use-extern-href-expected.txt: Added.
  • platform/gtk/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.
2:20 AM Changeset in webkit [110974] by Philippe Normand
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/Skipped: Skip a new failing editing test
  • platform/gtk/fast/events/resize-events-expected.txt: Added.
  • platform/gtk/test_expectations.txt: Mark

inspector/styles/svg-style.xhtml as flaky.

2:20 AM Changeset in webkit [110973] by commit-queue@webkit.org
  • 13 edits in trunk/Source

[chromium] Changes to overdraw metrics to allow upload tracking
​https://bugs.webkit.org/show_bug.cgi?id=81222

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Stick CCOverdrawMetrics into CCOcclusionTracker, so that it is available
everywhere that culling/drawing/painting is going on. Then we can stop
plumbing a metrics object through CCQuadCuller.

Rename the CCOverdrawMetrics "painting" stuff to "uploading" as this will
measure texture uploads rather than pixels painted in main memory.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::overdrawMetrics):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::didCull):
(WebCore):
(WebCore::CCOverdrawMetrics::didDraw):
(WebCore::CCOverdrawMetrics::recordMetrics):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.h:

(WebCore):
(WebCore::CCOverdrawMetrics::create):
(CCOverdrawMetrics):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCRenderPass):

Source/WebKit/chromium:

  • tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

  • tests/MockCCQuadCuller.h:

(WebCore::MockCCQuadCuller::MockCCQuadCuller):

1:56 AM Changeset in webkit [110972] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

Add TransferList IDL modifier, with support in V8 code gen.
​https://bugs.webkit.org/show_bug.cgi?id=81127

Patch by Greg Billock <​gbillock@google.com> on 2012-03-16
Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):
(GetIndexOf):
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateFunctionCallString):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::acceptTransferList):

  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_accept_transfer_list):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::getOwnPropertyDescriptor):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(JSTestSerializedScriptValueInterfacePrototype):
(WebCore):

  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:

(-[DOMTestSerializedScriptValueInterface acceptTransferList:transferList:]):

  • bindings/scripts/test/TestSerializedScriptValueInterface.idl:
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceInternal::acceptTransferListCallback):
(TestSerializedScriptValueInterfaceInternal):
(WebCore):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

1:43 AM Changeset in webkit [110971] by mrowe@apple.com
  • 4 edits in tags/Safari-536.3.1/Source

Merge r110969.

1:43 AM Changeset in webkit [110970] by mrowe@apple.com
  • 4 edits in tags/Safari-536.3.1/Source

Versioning.

1:41 AM Changeset in webkit [110969] by mrowe@apple.com
  • 4 edits in trunk/Source

Build fix. Do not preserve owner and group information when installing the WTF headers.

Source/JavaScriptCore:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
1:39 AM Changeset in webkit [110968] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Quads that become fully opaque after culling should not use blending
​https://bugs.webkit.org/show_bug.cgi?id=81235

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::needsBlending):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::BlendStateCheckLayer::appendQuads):
(WebKit::BlendStateCheckLayer::setQuadRect):
(WebKit::BlendStateCheckLayer::setQuadVisibleRect):
(WebKit::BlendStateCheckLayer::setOpaqueContents):
(WebKit::BlendStateCheckLayer::setOpaqueContentRect):
(WebKit::BlendStateCheckLayer::BlendStateCheckLayer):
(BlendStateCheckLayer):
(WebKit::TEST_F):

1:36 AM Changeset in webkit [110967] by mrowe@apple.com
  • 1 copy in tags/Safari-536.3.1

New tag.

1:33 AM Changeset in webkit [110966] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] viewportRect has changed to viewportSize
​https://bugs.webkit.org/show_bug.cgi?id=81262

Patch by Genevieve Mak <​gmak@rim.com> on 2012-03-16
Reviewed by Antonio Gomes.

Set size instead of rect in constructor.

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

1:27 AM Changeset in webkit [110965] by xji@chromium.org
  • 17 edits
    2 adds in trunk

Using ICU break iterator to simplify visual word movement implementation.
​https://bugs.webkit.org/show_bug.cgi?id=78856

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch relies on ICU word break iterator and cursor visual movement by character to get the word break
position in visual order. It reduces the complexity of old implementation.

Test: editing/selection/move-by-word-visually-wrong-left-right.html

  • editing/FrameSelection.cpp: Exclude WinCE from visual word movement since isWordTextBreak is not implemented.

(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingLeft):

  • editing/visible_units.cpp:

(WebCore):
(WebCore::previousLeafWithSameEditability): Just moving to the top without functionality change.
(WebCore::enclosingNodeWithNonInlineRenderer): ditto.
(WebCore::nextLeafWithSameEditability): ditto.
(WebCore::previousRootInlineBox): return previous RootInlineBox which is in different renderer.
(WebCore::nextRootInlineBox): return next RootInlineBox which is in different renderer.
(WebCore::boxIndexInVector):
(WebCore::previousBoxInLine): returns logically previous box in one line.
(WebCore::logicallyPreviousBox): returns logically previous box.
(WebCore::nextBoxInLine): returns logically next box in one line.
(WebCore::logicallyNextBox): returns logically next box.
(WebCore::wordBreakIteratorForMinOffsetBoundary): create word break iterator for position that is a box's min offset.
(WebCore::wordBreakIteratorForMaxOffsetBoundary): create word break iterator for position that is a box's max offset.
(WebCore::isLogicalStartOfWord): return whether a position is logically start of word.
(WebCore::islogicalEndOfWord): return whether a position is logically end of word.
(WebCore::visualWordPosition): returns the visual left or right word position.
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

  • platform/text/TextBreakIterator.h: Add isWordTextBreak().

(WebCore):

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::isWordTextBreak):
(WebCore):

  • platform/text/gtk/TextBreakIteratorGtk.cpp:

(WebCore::isWordTextBreak):
(WebCore):

  • platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::isWordTextBreak):
(WebCore):

  • platform/text/wince/TextBreakIteratorWinCE.cpp:

(WebCore::isWordTextBreak):
(WebCore):

LayoutTests:

  • editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt:
  • editing/selection/move-by-word-visually-inline-block-positioned-element.html: The word break stops at the beginning of fixed positioned element, which is correct and consistent behavior.
  • editing/selection/move-by-word-visually-multi-line-expected.txt:
  • editing/selection/move-by-word-visually-multi-line.html: The word break does not stop at the end of a text if there is next line of text available under the same editable root, which is a consistent behavior cross the board. Add more test cases, including one with non InlineTextBox.
  • editing/selection/move-by-word-visually-single-space-inline-element-expected.txt: Fixing of previously missing or extra word break positions.
  • editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
  • editing/selection/move-by-word-visually-single-space-one-element.html: Add a test case including bidi control character which renders wrong result since right-arrow could not reach a position which is the word break position. Add another test case containing non InlineTextBox.
  • editing/selection/move-by-word-visually-wrong-left-right-expected.txt: Added.
  • editing/selection/move-by-word-visually-wrong-left-right.html: Added. Add a test case which renders wrong result due to left/right-arrow returns wrong result.
  • editing/selection/resources/move-by-word-visually.js:

(moveByWordOnEveryChar): Handle a special case when left/right arrow missing certain position.

1:20 AM Changeset in webkit [110964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Don't create a quad for video layers without a frame (avoid use of uninitialized m_format)
​https://bugs.webkit.org/show_bug.cgi?id=81250

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-16
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

1:19 AM Changeset in webkit [110963] by commit-queue@webkit.org
  • 5 edits in trunk

[BlackBerry] Enable PAGE_VISIBILITY_API
​https://bugs.webkit.org/show_bug.cgi?id=81257

Source/WebKit/blackberry:

Set Page visibility state for BlackBerry port.

Patch by Andrew Lo <​anlo@rim.com> on 2012-03-16
Reviewed by Rob Buis.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
(BlackBerry::WebKit::WebPagePrivate::setVisible):
(BlackBerry::WebKit::WebPage::setVisible):
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPage::notifyAppActivationStateChange):

  • Api/WebPage_p.h:

(WebPagePrivate):

Tools:

Enable Page Visibility API for BlackBerry.

Patch by Andrew Lo <​anlo@rim.com> on 2012-03-16
Reviewed by Rob Buis.

  • Scripts/build-webkit:
1:12 AM Changeset in webkit [110962] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix Chromium windows build.

  • Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

1:11 AM Changeset in webkit [110961] by reed@google.com
  • 2 edits in trunk/LayoutTests

make test for rebaselining after skia 3398 lands
​https://bugs.webkit.org/show_bug.cgi?id=81246

Unreviewed. expectations only

  • platform/chromium/test_expectations.txt:
1:00 AM Changeset in webkit [110960] by commit-queue@webkit.org
  • 7 edits
    3 deletes in trunk

[Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
​https://bugs.webkit.org/show_bug.cgi?id=81232

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2012-03-16
Reviewed by Philippe Normand.

Source/WebKit/gtk:

Add computedStyleIncludingVisitedInfo helper method to
DumpRenderTreeSupportGtk.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::computedStyleIncludingVisitedInfo):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Use the newly-added helper method in DumpRenderTreeSupportGtk.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):

LayoutTests:

Unskip now-passing tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/history/nested-visited-test-expected.txt: Removed.
  • platform/gtk/fast/history/self-is-visited-expected.txt: Removed.
  • platform/gtk/fast/history/sibling-visited-test-expected.txt: Removed.
12:57 AM Changeset in webkit [110959] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

[Gtk] Properly set forms tests-specific settings
​https://bugs.webkit.org/show_bug.cgi?id=81237

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2012-03-16
Reviewed by Philippe Normand.

Source/WebKit/gtk:

Call Settings::setInteractiveFormValidationEnabled and
Settings::setValidationMessageTimerMagnification with
proper values when in testing mode.

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

LayoutTests:

Unskip newly-passing tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/validation-message-appearance-expected.txt: Added.
12:44 AM Changeset in webkit [110958] by morrita@google.com
  • 1 edit
    7 adds in trunk/LayoutTests

Unreviewed expectations update.

  • platform/chromium-linux/fast/events/resize-events-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/resize-events-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/events/resize-events-expected.png: Added.
  • platform/chromium-mac/fast/events/resize-events-expected.png: Added.
  • platform/chromium-mac/fast/events/resize-events-expected.txt: Added.
  • platform/chromium-win/fast/events/resize-events-expected.png: Added.
  • platform/chromium-win/fast/events/resize-events-expected.txt: Added.
12:44 AM Changeset in webkit [110957] by commit-queue@webkit.org
  • 12 edits
    3 moves in trunk/Source/WebCore

Move DOMWindowFileSystem to Modules/filesystem/
​https://bugs.webkit.org/show_bug.cgi?id=81030

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/filesystem/DOMWindowFileSystem.cpp: Copied from Source/WebCore/fileapi/DOMWindowFileSystem.cpp.
  • Modules/filesystem/DOMWindowFileSystem.h: Copied from Source/WebCore/fileapi/DOMWindowFileSystem.h.
  • Modules/filesystem/DOMWindowFileSystem.idl: Copied from Source/WebCore/fileapi/DOMWindowFileSystem.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • fileapi/DOMWindowFileSystem.cpp: Removed.
  • fileapi/DOMWindowFileSystem.h: Removed.
  • fileapi/DOMWindowFileSystem.idl: Removed.
12:34 AM Changeset in webkit [110956] by commit-queue@webkit.org
  • 8 edits in trunk

Unreviewed, rolling out r110951.
​http://trac.webkit.org/changeset/110951
​https://bugs.webkit.org/show_bug.cgi?id=81316

Does not build on apple-mac (Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-16

Source/WebCore:

  • platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):

  • webaudio/DynamicsCompressorNode.h:

(DynamicsCompressorNode):

  • webaudio/DynamicsCompressorNode.idl:

LayoutTests:

  • webaudio/dynamicscompressor-basic-expected.txt:
  • webaudio/dynamicscompressor-basic.html:
12:31 AM Changeset in webkit [110955] by reed@google.com
  • 2 edits in trunk/LayoutTests

to be rebaselined after hairline clipping fix in skia lands
​https://bugs.webkit.org/show_bug.cgi?id=81233

Unreviewed. expectations change only

  • platform/chromium/test_expectations.txt:
12:23 AM Changeset in webkit [110954] by eae@chromium.org
  • 2926 edits
    1466 copies
    439 deletes in branches/subpixellayout

Merge trunk changes up until r110884 into subpixel branch.

12:17 AM Changeset in webkit [110953] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Cleanup empty attribute list in IDLs
​https://bugs.webkit.org/show_bug.cgi?id=81228

Patch by Seo Sanghyeon <​sh4.seo@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

No tests. No change in behavior.

  • css/WebKitCSSRegionRule.idl:
12:05 AM Changeset in webkit [110952] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

onorientationchange event should have JSWindowEventListener attribute
​https://bugs.webkit.org/show_bug.cgi?id=79513

Reviewed by Kentaro Hara.

  • html/HTMLFrameSetElement.idl:

Mar 15, 2012:

11:56 PM Changeset in webkit [110951] by commit-queue@webkit.org
  • 8 edits in trunk

Expose attack, release as DynamicsCompressorNode's attributes.
​https://bugs.webkit.org/show_bug.cgi?id=81221

Patch by Gao Chun <​chun.gao@intel.com> on 2012-03-15
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/dynamicscompressor-basic.html

  • platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):

  • webaudio/DynamicsCompressorNode.h:

(WebCore::DynamicsCompressorNode::attack):
(WebCore::DynamicsCompressorNode::release):
(DynamicsCompressorNode):

  • webaudio/DynamicsCompressorNode.idl:

LayoutTests:

  • webaudio/dynamicscompressor-basic-expected.txt:
  • webaudio/dynamicscompressor-basic.html:
11:35 PM Changeset in webkit [110950] by hans@chromium.org
  • 7 edits
    3 copies
    5 adds in trunk

Speech JavaScript API: SpeechRecognition, Controller and Client
​https://bugs.webkit.org/show_bug.cgi?id=81096

Reviewed by Adam Barth.

Source/WebCore:

Add implementation stub for SpeechRecognition. Add the
SpeechRecognitionController class and SpeechRecognitionClient
interface.

Test: fast/speech/scripted/basics.html

  • Modules/speech/DOMWindowSpeech.idl:
  • Modules/speech/SpeechRecognition.cpp: Added.

(WebCore):
(WebCore::SpeechRecognition::create):
(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::stopFunction):
(WebCore::SpeechRecognition::abort):
(WebCore::SpeechRecognition::audioStartCallback):
(WebCore::SpeechRecognition::soundStartCallback):
(WebCore::SpeechRecognition::speechStartCallback):
(WebCore::SpeechRecognition::speechEndCallback):
(WebCore::SpeechRecognition::audioEndCallback):
(WebCore::SpeechRecognition::resultCallback):
(WebCore::SpeechRecognition::noMatchCallback):
(WebCore::SpeechRecognition::resultDeletedCallback):
(WebCore::SpeechRecognition::errorCallback):
(WebCore::SpeechRecognition::startCallback):
(WebCore::SpeechRecognition::endCallback):
(WebCore::SpeechRecognition::interfaceName):
(WebCore::SpeechRecognition::scriptExecutionContext):
(WebCore::SpeechRecognition::SpeechRecognition):
(WebCore::SpeechRecognition::~SpeechRecognition):

  • Modules/speech/SpeechRecognition.h: Added.

(WebCore):
(SpeechRecognition):
(WebCore::SpeechRecognition::grammars):
(WebCore::SpeechRecognition::setGrammars):
(WebCore::SpeechRecognition::lang):
(WebCore::SpeechRecognition::setLang):
(WebCore::SpeechRecognition::continuous):
(WebCore::SpeechRecognition::setContinuous):

  • Modules/speech/SpeechRecognition.idl:
  • Modules/speech/SpeechRecognitionClient.h:

(WebCore):
(SpeechRecognitionClient):
(WebCore::SpeechRecognitionClient::~SpeechRecognitionClient):

  • Modules/speech/SpeechRecognitionController.cpp:

(WebCore):
(WebCore::SpeechRecognitionController::supplementName):
(WebCore::SpeechRecognitionController::SpeechRecognitionController):
(WebCore::SpeechRecognitionController::~SpeechRecognitionController):
(WebCore::SpeechRecognitionController::create):
(WebCore::provideSpeechRecognitionTo):

  • Modules/speech/SpeechRecognitionController.h: Added.

(WebCore):
(SpeechRecognitionController):
(WebCore::SpeechRecognitionController::start):
(WebCore::SpeechRecognitionController::stop):
(WebCore::SpeechRecognitionController::abort):
(WebCore::SpeechRecognitionController::visibilityHidden):
(WebCore::SpeechRecognitionController::unregisterSpeechRecognition):
(WebCore::SpeechRecognitionController::from):

  • WebCore.gypi:
  • dom/EventTargetFactory.in:

Source/WebKit/chromium:

Provide a SpeechRecognitionController to Page, with a NULL client for
now.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

LayoutTests:

Add tests for the basics of the SpeechRecognition interface.

  • fast/speech/scripted/basics-expected.txt: Added.
  • fast/speech/scripted/basics.html: Added.
11:18 PM Changeset in webkit [110949] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix some assertions in occlusion tracker unit tests
​https://bugs.webkit.org/show_bug.cgi?id=81308

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-15
Reviewed by James Robinson.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):

11:18 PM Changeset in webkit [110948] by eric@webkit.org
  • 6 edits
    1 copy in trunk/Tools

Move parse_bug_id into config/urls in preparation for re-use elsewhere.
​https://bugs.webkit.org/show_bug.cgi?id=81313

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/changelog.py:

(parse_bug_id_from_changelog):

  • Scripts/webkitpy/common/config/urls.py:

(parse_bug_id):

  • Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.

(URLsTest):
(URLsTest.test_parse_bug_id):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(test_parse_bug_id):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(_post_error_and_check_for_bug_url):

  • Scripts/webkitpy/tool/bot/sheriff.py:

(Sheriff.post_rollout_patch):
(Sheriff.post_chromium_deps_roll):

11:09 PM Changeset in webkit [110947] by tkent@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

Update the expectation of labelable-elements.html.

The expectation in the common place should be one for platforms with
ENABLE_DATALIST, was for platform without ENABLE_DATALIST.
​https://bugs.webkit.org/show_bug.cgi?id=80985

  • fast/forms/label/labelable-elements-expected.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/forms/label/labelable-elements-expected.txt: Removed.
  • platform/qt/Skipped:
10:50 PM Changeset in webkit [110946] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Sets alpha channel for new buffers.
​https://bugs.webkit.org/show_bug.cgi?id=77101

Patch by Michal Ciepielski <​m.ciepielski@samsung.com> on 2012-03-15
Reviewed by Hajime Morita.

No new tests.

By default EFL creates buffers without alpha channel.
This causes improper rendering of HTML controls (i.e. radio buttons, checkboxes).
This commits sets alpha channel for all newly created buffers by EFL.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::cacheThemePartNew):

10:47 PM Changeset in webkit [110945] by commit-queue@webkit.org
  • 18 edits in trunk/Source

Unreviewed, rolling out r110941.
​http://trac.webkit.org/changeset/110941
​https://bugs.webkit.org/show_bug.cgi?id=81307

the revert looks innocent. (Requested by morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-15

Source/WebCore:

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore):
(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.h:

(WebCore):
(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::paintContentsIfDirty):
(WebCore::LayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
(WTF::TestLayerChromium::paintContentsIfDirty):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(TestCCOcclusionTracker):
(WTF::TestCCOcclusionTracker::TestCCOcclusionTracker):
(WTF::TestCCOcclusionTracker::setOcclusion):
(WTF::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
(WTF):
(WTF::FakeTiledLayerChromium::prepareToUpdate):
(WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):

9:20 PM Changeset in webkit [110944] by abarth@webkit.org
  • 5 edits in trunk/Tools

The commit-queue should fast-track patches that have already passed the testing EWS bots
​https://bugs.webkit.org/show_bug.cgi?id=81305

Reviewed by Eric Seidel.

If a patch has already passed the testing EWS bots (currently only the
chromium-ews bot), we should be able to land the patch without running
the tests again. This patch is somewhat risky in that the tests might
have been broken between when the EWS bots ran and when the
commit-queue is processing the patch. If that turns out to be a
problem in practice, we'll tighten up this fast-track in some way,
likely by making sure that the pass status is recent.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:

(CommitQueueTaskDelegate.did_pass_testing_ews):
(CommitQueueTask._did_pass_tests_recently):
(CommitQueueTask.run):

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(MockCommitQueue.did_pass_testing_ews):
(test_fast_success_case):

  • Scripts/webkitpy/tool/commands/queues.py:

(CommitQueue.did_pass_testing_ews):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(test_did_pass_testing_ews):

9:19 PM Changeset in webkit [110943] by tommyw@google.com
  • 5 edits
    4 copies
    1 add in trunk/Source/WebCore

MediaStream API (JSEP): Introducing SessionDescription
​https://bugs.webkit.org/show_bug.cgi?id=81206

Reviewed by Adam Barth.

Patch #3 in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.
Adding the SessionDescription JS object and its platform counterpart SessionDescriptionDescriptor.

Not possible to test until the entire JSEP feature is commited.

  • GNUmakefile.list.am:
  • Modules/mediastream/SessionDescription.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(WebCore::SessionDescription::create):
(WebCore::SessionDescription::SessionDescription):
(WebCore::SessionDescription::~SessionDescription):
(WebCore::SessionDescription::addCandidate):
(WebCore::SessionDescription::toSdp):
(WebCore::SessionDescription::descriptor):

  • Modules/mediastream/SessionDescription.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(SessionDescription):

  • Modules/mediastream/SessionDescription.idl: Added.
  • WebCore.gypi:
  • platform/mediastream/MediaStreamCenter.cpp:

(WebCore::MediaStreamCenter::constructSdp):
(WebCore):

  • platform/mediastream/MediaStreamCenter.h:

(WebCore):
(MediaStreamCenter):

  • platform/mediastream/SessionDescriptionDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(WebCore::SessionDescriptionDescriptor::create):
(WebCore::SessionDescriptionDescriptor::SessionDescriptionDescriptor):
(WebCore::SessionDescriptionDescriptor::~SessionDescriptionDescriptor):
(WebCore::SessionDescriptionDescriptor::addCandidate):
(WebCore::SessionDescriptionDescriptor::toSdp):
(WebCore::SessionDescriptionDescriptor::numberOfAddedCandidates):
(WebCore::SessionDescriptionDescriptor::candidate):
(WebCore::SessionDescriptionDescriptor::initialSdp):

  • platform/mediastream/SessionDescriptionDescriptor.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(SessionDescriptionDescriptor):

9:13 PM Changeset in webkit [110942] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

9:07 PM Changeset in webkit [110941] by commit-queue@webkit.org
  • 18 edits in trunk/Source

Unreviewed, rolling out r110929.
​http://trac.webkit.org/changeset/110929
​https://bugs.webkit.org/show_bug.cgi?id=81306

breaking webkit_unit_tests (Requested by morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-15

Source/WebCore:

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore):
(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.h:

(WebCore):
(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::paintContentsIfDirty):
(WebCore::LayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore):
(WebCore::contentToLayerTransform):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):

  • platform/graphics/chromium/TiledLayerChromium.h:

(WebCore):
(TiledLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
(WTF::TestLayerChromium::paintContentsIfDirty):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::prepareToUpdate):
(WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):

9:07 PM Changeset in webkit [110940] by Lucas Forschler
  • 1 copy in tags/Safari-536.3

New Tag.

9:05 PM Changeset in webkit [110939] by commit-queue@webkit.org
  • 11 edits in trunk/LayoutTests

Change per-script font tests to use InternalSettings
​https://bugs.webkit.org/show_bug.cgi?id=81202

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-03-15
Reviewed by Hajime Morita.

  • fast/text/international/content-language-font-selection.html:
  • fast/text/international/content-language-with-subtags.html:
  • platform/efl/Skipped: Remove tests from Skipped since that no longer rely on overridePreference.
  • platform/gtk-wk2/Skipped: Ditto.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
9:03 PM Changeset in webkit [110938] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION(r106232): The resize handler is always called after loading.
​https://bugs.webkit.org/show_bug.cgi?id=80242

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-03-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Ensure resize-events are not emitted when layout-size changes due to added
scrollbars. For fixed layout, scrollbars are never subtracted or added, so
we can compare fixedLayoutSize directly. For normal layout, use the full
visible rect size which is the same as layout size plus scrollbars.

Test: fast/events/resize-events.html

  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::performPostLayoutTasks):

  • page/FrameView.h:

(FrameView):

LayoutTests:

Tests that no resize events are emitted during page creation,
even if the page overflows and adds a scrollbar.

  • fast/events/resize-events-expected.txt: Added.
  • fast/events/resize-events.html: Added.
8:45 PM Changeset in webkit [110937] by tommyw@google.com
  • 3 edits
    4 adds in trunk/Source/WebCore

MediaStream API (JSEP): Introducing MediaHints and IceOptions
​https://bugs.webkit.org/show_bug.cgi?id=81207

Reviewed by Adam Barth.

Patch #4 in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.
Introducing the platform MediaHints and IceOptions helper classes.

Not possible to test until the entire JSEP feature is commited.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • platform/mediastream/IceOptions.cpp: Added.

(WebCore):
(WebCore::IceOptions::create):

  • platform/mediastream/IceOptions.h: Added.

(WebCore):
(IceOptions):
(WebCore::IceOptions::~IceOptions):
(WebCore::IceOptions::useCandidates):
(WebCore::IceOptions::IceOptions):

  • platform/mediastream/MediaHints.cpp: Added.

(WebCore):
(WebCore::MediaHints::create):
(WebCore::MediaHints::audio):
(WebCore::MediaHints::video):

  • platform/mediastream/MediaHints.h: Added.

(WebCore):
(MediaHints):
(WebCore::MediaHints::~MediaHints):
(WebCore::MediaHints::MediaHints):

8:39 PM Changeset in webkit [110936] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add layout tests for font selection based on lang/xml:lang
​https://bugs.webkit.org/show_bug.cgi?id=81203

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-03-15
Reviewed by Hajime Morita.

  • fast/text/international/lang-sensitive-fonts-expected.html: Added.
  • fast/text/international/lang-sensitive-fonts-xml-expected.html: Added.
  • fast/text/international/lang-sensitive-fonts-xml.xhtml: Added.
  • fast/text/international/lang-sensitive-fonts.html: Added.
8:20 PM Changeset in webkit [110935] by shinyak@chromium.org
  • 7 edits
    2 adds in trunk

[Crash] Adding <content> into a ShadowRoot causes crash.
​https://bugs.webkit.org/show_bug.cgi?id=80020

Reviewed by Hajime Morita.

Source/WebCore:

The problem is <content> tries to select host children though it is not prepared.
Since populating host children for insertion points is performed just before
attaching a shadow tree, we should recalculate whole shadow tree if <content> is
appended as a child.

However, element->appendChild() does not know the element is in a shadow tree or not.
We have to ensure reattaching whole shadow tree here.

So this patch adds some phases to HTMLContentSelector so that we can check node
distribution algorihm is begin processed or not. If not we cannot select anything,
but we have to enable a flag to reattach whole shadow tree.

Tests: fast/dom/shadow/shadow-content-crash-expected.html

fast/dom/shadow/shadow-content-crash.html

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::attach):
(WebCore::ShadowTree::insertionPointFor):

  • dom/ShadowTree.h:

(WebCore):
(ShadowTree):
(WebCore::ShadowTree::selector):

  • html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelector::HTMLContentSelector):
(WebCore::HTMLContentSelector::select):
(WebCore::HTMLContentSelector::willSelect):
(WebCore):
(WebCore::HTMLContentSelector::didSelect):
(WebCore::HTMLContentSelector::populateIfNecessary):

  • html/shadow/HTMLContentSelector.h:

(HTMLContentSelector):
(WebCore::HTMLContentSelector::isSelecting):
(WebCore):
(WebCore::HTMLContentSelector::hasPopulated):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::distributeHostChildren):
(WebCore::InsertionPoint::clearDistribution):

LayoutTests:

  • fast/dom/shadow/shadow-content-crash-expected.html: Added.
  • fast/dom/shadow/shadow-content-crash.html: Added.
8:14 PM Changeset in webkit [110934] by mikelawther@chromium.org
  • 7 edits in trunk

CSS3 calc: mixed percent/absolute expressions for gradients
​https://bugs.webkit.org/show_bug.cgi?id=81182

Reviewed by Ojan Vafai.

Source/WebCore:

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):

LayoutTests:

Add new tests for mixed percent/absolute expressions.

  • css3/calc/css3-radial-gradients-expected.html:
  • css3/calc/css3-radial-gradients.html:
  • css3/calc/gradient-color-stops-expected.html:
  • css3/calc/gradient-color-stops.html:
8:13 PM Changeset in webkit [110933] by haraken@chromium.org
  • 5 edits in trunk

[PerformanceTests] run-perf-tests should output correct units
​https://bugs.webkit.org/show_bug.cgi?id=78303

Reviewed by Ryosuke Niwa.

Previously run-perf-tests just supported "ms" for units.
Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
This patch fixes run-perf-tests so that they can support custom units.
The default unit is "ms".

The test result looks like this:

$ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s

PerformanceTests:

  • Dromaeo/resources/dromaeorunner.js:

(.):

  • resources/runner.js:

(PerfTestRunner.computeStatistics):
(PerfTestRunner.printStatistics):

Tools:

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._process_parser_test_result):

8:00 PM Changeset in webkit [110932] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Sync up MIMETypeRegistry.cpp
​https://bugs.webkit.org/show_bug.cgi?id=81191

Reviewed by Rob Buis.

Add png and jpeg to supportedImageMIMETypesForEncoding for BlackBerry.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypesForEncoding):

7:54 PM Changeset in webkit [110931] by dgrogan@chromium.org
  • 114 edits in trunk/LayoutTests

IndexedDB Tests: use self instead of window
​https://bugs.webkit.org/show_bug.cgi?id=81043

'window' is meaningless in a worker; these tests will soon be run from
a worker context.

Reviewed by Tony Chang.

  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/createObjectStore-name-argument-required.html:
  • storage/indexeddb/createObjectStore-null-name.html:
  • storage/indexeddb/cursor-continue.html:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-inconsistency.html:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-key-order.html:
  • storage/indexeddb/cursor-primary-key-order.html:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-value-argument-required.html:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/delete-closed-database-object-expected.txt:
  • storage/indexeddb/delete-closed-database-object.html:
  • storage/indexeddb/deleteObjectStore-name-argument-required.html:
  • storage/indexeddb/deleteObjectStore-null-name.html:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/factory-cmp.html:
  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
  • storage/indexeddb/factory-deletedatabase.html:
  • storage/indexeddb/index-count.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/index-get-key-argument-required.html:
  • storage/indexeddb/index-population.html:
  • storage/indexeddb/index-unique.html:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/invalid-keys.html:
  • storage/indexeddb/key-generator.html:
  • storage/indexeddb/key-sort-order-across-types.html:
  • storage/indexeddb/key-sort-order-date.html:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/key-type-array.html:
  • storage/indexeddb/key-type-infinity.html:
  • storage/indexeddb/keypath-basics.html:
  • storage/indexeddb/keypath-fetch-key.html:
  • storage/indexeddb/mozilla/add-twice-failure.html:
  • storage/indexeddb/mozilla/autoincrement-indexes.html:
  • storage/indexeddb/mozilla/bad-keypath.html:
  • storage/indexeddb/mozilla/clear.html:
  • storage/indexeddb/mozilla/create-index-unique.html:
  • storage/indexeddb/mozilla/create-index-with-integer-keys.html:
  • storage/indexeddb/mozilla/create-objectstore-basics.html:
  • storage/indexeddb/mozilla/create-objectstore-null-name.html:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
  • storage/indexeddb/mozilla/cursors.html:
  • storage/indexeddb/mozilla/delete-result.html:
  • storage/indexeddb/mozilla/event-source.html:
  • storage/indexeddb/mozilla/global-data.html:
  • storage/indexeddb/mozilla/indexes.html:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
  • storage/indexeddb/mozilla/key-requirements-put-no-key.html:
  • storage/indexeddb/mozilla/key-requirements-put-null-key.html:
  • storage/indexeddb/mozilla/key-requirements.html:
  • storage/indexeddb/mozilla/object-cursors.html:
  • storage/indexeddb/mozilla/object-identity.html:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
  • storage/indexeddb/mozilla/object-store-remove-values.html:
  • storage/indexeddb/mozilla/objectstorenames.html:
  • storage/indexeddb/mozilla/odd-result-order.html:
  • storage/indexeddb/mozilla/put-get-values.html:
  • storage/indexeddb/mozilla/readonly-transactions.html:
  • storage/indexeddb/mozilla/readwrite-transactions.html:
  • storage/indexeddb/mozilla/readyState.html:
  • storage/indexeddb/mozilla/remove-index.html:
  • storage/indexeddb/mozilla/remove-objectstore.html:
  • storage/indexeddb/mozilla/versionchange-abort.html:
  • storage/indexeddb/mozilla/versionchange.html:
  • storage/indexeddb/mutating-cursor.html:
  • storage/indexeddb/objectStore-required-arguments.html:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-count.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-close-version-expected.txt:
  • storage/indexeddb/open-close-version.html:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/prefetch-bugfix-108071.html:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/setVersion-null.html:
  • storage/indexeddb/setVersion-undefined.html:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/transaction-rollback.html:
  • storage/indexeddb/transaction-storeNames-required.html:
  • storage/indexeddb/two-version-changes-expected.txt:
  • storage/indexeddb/two-version-changes.html:
  • storage/indexeddb/value-undefined.html:
  • storage/indexeddb/values-odd-types.html:
  • storage/indexeddb/version-change-abort.html:
  • storage/indexeddb/version-change-exclusive-expected.txt:
  • storage/indexeddb/version-change-exclusive.html:
  • storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
  • storage/indexeddb/versionchangerequest-activedomobject.html:
7:50 PM Changeset in webkit [110930] by timothy_horton@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed mac rebaseline for fast/clip/{011,012}.html after ​http://trac.webkit.org/changeset/110072

There was a similar Chromium rebaseline in ​http://trac.webkit.org/changeset/110179

  • platform/mac/fast/clip/011-expected.txt:
  • platform/mac/fast/clip/012-expected.txt:
7:41 PM Changeset in webkit [110929] by commit-queue@webkit.org
  • 18 edits in trunk/Source

[chromium] Decide occlusion in paint culling with CCOcclusionTracker
​https://bugs.webkit.org/show_bug.cgi?id=81181

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-15
Reviewed by Adrienne Walker.

Source/WebCore:

Plumb a CCOcclusionTracker* around instead of a bare Region, so that it
can make a more informed decision if a tile is occluded or not during
paint.

Covered by existing tests.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore):
(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.h:

(WebCore):
(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::paintContentsIfDirty):
(WebCore::LayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
(WTF::TestLayerChromium::paintContentsIfDirty):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(TestCCOcclusionTracker):
(WTF::TestCCOcclusionTracker::TestCCOcclusionTracker):
(WTF::TestCCOcclusionTracker::setOcclusion):
(WTF::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
(WTF):
(WTF::FakeTiledLayerChromium::prepareToUpdate):
(WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):

7:36 PM Changeset in webkit [110928] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

WebKitTestRunner layoutTestController.pathToLocalResource needs to be updated to work with
NRWT
​https://bugs.webkit.org/show_bug.cgi?id=81299

Add failing expected results for mac-wk2 to get the bots green.

  • platform/mac-wk2/fast/loader/local-CSS-from-local-expected.txt: Added.
  • platform/mac-wk2/fast/loader/local-JavaScript-from-local-expected.txt: Added.
  • platform/mac-wk2/fast/loader/local-image-from-local-expected.txt: Added.
6:49 PM Changeset in webkit [110927] by commit-queue@webkit.org
  • 27 edits in trunk

[Forms] The "meter" element should not be a form-associated element.
​https://bugs.webkit.org/show_bug.cgi?id=80380

Patch by Yoshifumi Inoue <​yosin@chromium.org> on 2012-03-15
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes base class of HTMLMeterElement to LabelableElement from
HTMLFormControlElement for saving memory space and iteration time of
extra "meter" elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.

This patch renames isLabelable method to supportLabels and makes isLabelable
as predicate of an instance of LabelableElement or not.

Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
​https://bugs.webkit.org/show_bug.cgi?id=80381

No new tests. Update existing tests to cover this change.

  • editing/TextIterator.cpp:

(WebCore::TextIterator::advance): Check HTMLMeterElement in addition to isFormControlElement. This change is for text dump in LayoutTests implemented by document.innerText attribute.

  • html/HTMLButton.h:

(WebCore::HTMLButtonElement::supportLabels): Renamed from isLabelable

  • html/HTMLElement.h:

(WebCore::HTMLElement::isLabelable): Added. A predicate for an instance of LabelableElement.

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::supportLabels): Renamed from isLabelable

  • html/HTMLKeygenElement.h:

(WebCore::HTMLKeygenElement::supportLabels): Renamed from isLabelable

  • html/HTMLLabelElement.cpp:

(WebCore::nodeAsLabelableElement): Changed to return LabelableElement instead of HTMLFormControlElement.
(WebCore::HTMLLabelElement::control): Changed to return LabelableElement instead of HTMLFormControlElement.

  • html/HTMLLabelElement.h:

(HTMLLabelElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::HTMLMeterElement): Changed base class to LabelableElement.
(WebCore::HTMLMeterElement::create): Remove form parameter.
(WebCore::HTMLMeterElement::formControlType): Remove implementation of virtual method declared in HTMLFormControlElement.
(WebCore::HTMLMeterElement::parseAttribute): Replace HTMLFormControlElement to LabelableElement
(WebCore::HTMLMeterElement::attach): Replace HTMLFormControlElement to LabelableElement

  • html/HTMLMeterElement.idl: Remove the "form" attribute which isn't listed in the HTML5 specification.
  • html/HTMLMeterElement.h:

(HTMLMeterElement):
(WebCore::HTMLMeterElement::supportLabels): Renamed from isLabelable

  • html/HTMLOutputElement.h:

(WebCore::HTMLOutputElement::supportLabels): Renamed from isLabelable

  • html/HTMLProgressElement.h:

(WebCore::HTMLProgressElement::supportLabels): Renamed from isLabelable

  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::supportLabels): Renamed from isLabelable

  • html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::supportLabels): Renamed from isLabelable

  • html/HiddenInputType.h:

(WebCore::HiddenInputType::supportLabels): Renamed from isLabelable

  • html/InputType.h:

(WebCore::InputType::supportLabels): Renamed from isLabelable

  • html/HTMLTagNames.in: Remove "constructorNeedsFormElement" for not passing "form" parameter in HTMLElementFactory.
  • html/LabelableElement.cpp:

(WebCore::LabelableElement::labels): Replace isLabelable to supportLabels

  • html/LabelableElement.h:

(LabelableElement):

LayoutTests:

This patch removes tests which checks non-existent "form" attribute
of the "meter" element. The "form" attribute is available only for
form-associated elements. However, the "meter" element isn't a
form-associated element.

  • fast/dom/HTMLMeterElement/meter-element-form-expected.txt: Updated expectation for test output changes.
  • fast/dom/HTMLMeterElement/meter-element-form.html: Changed for the "meter" element doesn't have IDL attribute "form".
  • fast/forms/form-attribute-expected.txt: Updated expectation for test output changes.
  • fast/forms/form-attribute.html: Removed lines for the "meter" element.
6:39 PM Changeset in webkit [110926] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

canvas/philip/tests/2d.line.cap.round.html fails on Mac Lion WK1
​https://bugs.webkit.org/show_bug.cgi?id=81289
<rdar://problem/11059777>

Unreviewed skip of two more similarly flaky tests:

canvas/philip/tests/2d.shadow.canvas.transparent.2.html
canvas/philip/tests/2d.shadow.image.transparent.2.html

6:24 PM Changeset in webkit [110925] by adamk@chromium.org
  • 5 edits
    2 adds in trunk

REGRESSION(r103452): 100% CPU usage and 5s pause after clicking on a link in Yahoo Mail
​https://bugs.webkit.org/show_bug.cgi?id=81141

Reviewed by Ojan Vafai.

Source/WebCore:

Revert the behavior change from r103452: don't fire DOMSubtreeModified
events when an attribute value merely changes. Still fire that event
when an attribute is added or removed from an element.

Though this contradicts the DOM3 spec, it matches legacy WebKit behavior,
and given that Mutation Events are deprecated, it seems unwise to make
any additions to WebKit's implementation of them.

Test: fast/dom/subtree-modified-attributes.html

  • dom/Element.cpp:

(WebCore::Element::didAddAttribute): Renamed from didModifyAttribute.
(WebCore::Element::didModifyAttribute): Remove the call to dispatchSubtreeModifiedEvent.
(WebCore):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::addAttribute): Call didAddAttribute instead of didModifyAttribute.

LayoutTests:

  • fast/dom/subtree-modified-attributes-expected.txt: Added.
  • fast/dom/subtree-modified-attributes.html: Added.
6:08 PM Changeset in webkit [110924] by leviw@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed gardening. Fixing Chromium expectations after we began falling back to the failing
expectation checked in in r110911.

  • platform/chromium/platform/chromium/virtual: Added.
  • platform/chromium/platform/chromium/virtual/gpu: Added.
  • platform/chromium/platform/chromium/virtual/gpu/fast: Added.
  • platform/chromium/platform/chromium/virtual/gpu/fast/canvas: Added.
  • platform/chromium/platform/chromium/virtual/gpu/fast/canvas/webgl: Added.
  • platform/chromium/platform/chromium/virtual/gpu/fast/canvas/webgl/context-lost-expected.txt: Added.
5:55 PM Changeset in webkit [110923] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

[WinCairo] Unreviewed build change after wtf path changes.

  • DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include

directories to look at the private header directory to find 'wtf'.

5:52 PM Changeset in webkit [110922] by tkent@chromium.org
  • 3 edits in trunk/Tools

REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=81293

Reviewed by Adam Barth.

r110595 introduced new format of the author field of ChangeLog entry:
"Adam Barth <​abarth@webkit.org> && Benjamin Poulain <​bpoulain@apple.com>"
Updte chanelog.py to support it.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry._split_contributor_names):

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_parse_authors):

5:45 PM Changeset in webkit [110921] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk/Source

[chromium] Move overdraw metrics into a templated class for both paint and draw metrics.
​https://bugs.webkit.org/show_bug.cgi?id=81156

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-15
Reviewed by Adrienne Walker.

Source/WebCore:

Creates CCOverdrawMetrics which can be called to inform it about
draws/paints. At the end of the frame, the CCOverdrawMetrics
recordMetrics() method will put its data into histograms, a
TRACE_COUNTER for culling information, and a TRACE_EVENT for details
about the number of opaque/translucent pixels.

Covered by existing tests.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:

(TraceEvent):
(WebCore::TraceEvent::addTraceEvent):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp: Added.

(WebCore):
(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::wedgeProduct):
(WebCore::quadArea):
(WebCore::CCOverdrawMetrics::didDraw):
(WebCore::CCOverdrawMetrics::recordMetrics):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.h: Added.

(WebCore):
(CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::pixelsDrawnOpaque):
(WebCore::CCOverdrawMetrics::pixelsDrawnTranslucent):
(WebCore::CCOverdrawMetrics::pixelsCulled):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(WebCore):
(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCRenderPass):

Source/WebKit/chromium:

  • tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

5:30 PM Changeset in webkit [110920] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

fast/events/pagehide-timeout.html, pageshow-pagehide-on-back-cached-with-frames.html, and
pageshow-pagehide-on-back-cached.html flakey on Lion Intel Debug WebKit testers
​https://bugs.webkit.org/show_bug.cgi?id=81291

Skip these tests on mac-wk2 to get the bots green.

  • platform/mac-wk2/Skipped:
5:29 PM UsingGitHub edited by abarth@webkit.org
(diff)
5:28 PM Changeset in webkit [110919] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] RateLimiter should hold a reference to its context
​https://bugs.webkit.org/show_bug.cgi?id=80761

Reviewed by Stephen White.

  • platform/graphics/chromium/RateLimiter.h:

(RateLimiter):

5:27 PM UsingGitHub edited by abarth@webkit.org
(diff)
5:27 PM UsingGitHub edited by abarth@webkit.org
(diff)
5:20 PM Changeset in webkit [110918] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

Share code in FormAssociatedElement by resetting the form owner whenever insertedIntoTree is called
​https://bugs.webkit.org/show_bug.cgi?id=81160

Reviewed by Kent Tamura.

Source/WebCore:

The only difference between the previous insertedIntoTree method and
resetFormOwner was a missing element->inDocument() check in the
former. But that check is actually important, as seen by the included test case.

Test: fast/forms/form-attribute-not-in-document.html

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::insertedIntoTree):

LayoutTests:

  • fast/forms/form-attribute-not-in-document-expected.txt: Added.
  • fast/forms/form-attribute-not-in-document.html: Added.
5:17 PM Changeset in webkit [110917] by dino@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

webgl/framebuffer-object-attachment failing on lion
​https://bugs.webkit.org/show_bug.cgi?id=81290

Unreviewed. Adding the failing results to platform/mac.

  • platform/mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
  • platform/mac/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
5:16 PM Changeset in webkit [110916] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

canvas/philip/tests/2d.line.cap.round.html fails on Mac Lion WK1
​https://bugs.webkit.org/show_bug.cgi?id=81289
<rdar://problem/11059777>

Unreviewed skip of flaky test canvas/philip/tests/2d.line.cap.round.html.

  • platform/mac/Skipped:
5:13 PM UsingGitHub edited by abarth@webkit.org
(diff)
5:12 PM UsingGitHub edited by abarth@webkit.org
(diff)
5:11 PM Changeset in webkit [110915] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[Refactoring] Rename StringBuilder variables in MarkupAccumulator.{h,cpp}
​https://bugs.webkit.org/show_bug.cgi?id=81288

Reviewed by Adam Barth.

This is a refactoring for fixing bug 81214. Currently MarkupAccumulator mixes
'out' and 'result' for variable names of StringBuilder. This patch unifies them
to 'result'.

No tests. No change in behavior.

  • editing/MarkupAccumulator.cpp: Renamed 'out' to 'result'.

(WebCore::appendCharactersReplacingEntities):
(WebCore::MarkupAccumulator::serializeNodes): Renamed 'node' to 'targetNode' for clarification
(and for avoiding style check error in MarkupAccumulator.h).
(WebCore::MarkupAccumulator::concatenateMarkup):
(WebCore::MarkupAccumulator::appendNodeValue):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute):
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::MarkupAccumulator::entityMaskForText):
(WebCore::MarkupAccumulator::appendText):
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendProcessingInstruction):
(WebCore::MarkupAccumulator::appendElement):
(WebCore::MarkupAccumulator::appendOpenTag):
(WebCore::MarkupAccumulator::appendCloseTag):
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::appendCDATASection):
(WebCore::MarkupAccumulator::elementCannotHaveEndTag):

  • editing/MarkupAccumulator.h: Removed redundant variable names.

(MarkupAccumulator):
(WebCore):

5:11 PM Changeset in webkit [110914] by Lucas Forschler
  • 2 edits in branches/safari-534.55-branch/Source/JavaScriptCore

Merged r110818.

5:10 PM UsingGitHub edited by abarth@webkit.org
(diff)
5:09 PM UsingGitHub edited by abarth@webkit.org
(diff)
5:07 PM UsingGitHub edited by abarth@webkit.org
(diff)
5:06 PM UsingGitHub edited by abarth@webkit.org
(diff)
5:05 PM UsingGitHub edited by abarth@webkit.org
(diff)
4:58 PM Changeset in webkit [110913] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

Make the array pointer parameters in the Typed Array create() methods const.
​https://bugs.webkit.org/show_bug.cgi?id=81147

Patch by David Dorwin <​ddorwin@chromium.org> on 2012-03-15
Reviewed by Kenneth Russell.

This allows const arrays to be passed to these methods.
They use PassRefPtr<Subclass> create(), which already has a const parameter.

  • wtf/Int16Array.h:

(Int16Array):
(WTF::Int16Array::create):

  • wtf/Int32Array.h:

(Int32Array):
(WTF::Int32Array::create):

  • wtf/Int8Array.h:

(Int8Array):
(WTF::Int8Array::create):

  • wtf/Uint16Array.h:

(Uint16Array):
(WTF::Uint16Array::create):

  • wtf/Uint32Array.h:

(Uint32Array):
(WTF::Uint32Array::create):

  • wtf/Uint8Array.h:

(Uint8Array):
(WTF::Uint8Array::create):

  • wtf/Uint8ClampedArray.h:

(Uint8ClampedArray):
(WTF::Uint8ClampedArray::create):

4:54 PM Changeset in webkit [110912] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the Snow Leopard build.

  • UIProcess/API/mac/PDFViewController.mm:

(WebKit::PDFViewController::pdfKitBundle):

4:54 PM Changeset in webkit [110911] by dino@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

webgl/context-lost failing on Lion
​https://bugs.webkit.org/show_bug.cgi?id=81284

Unreviewed. Adding the failing results to platform/mac.

  • platform/mac-snowleopard/fast/canvas/webgl/context-lost-expected.txt: Added.
  • platform/mac/fast/canvas/webgl/context-lost-expected.txt: Added.
4:47 PM Changeset in webkit [110910] by bfulgham@webkit.org
  • 4 edits in trunk/Source/WebCore

[WinCairo] Correct <wtf/*.h> include paths.
​https://bugs.webkit.org/show_bug.cgi?id=81278

Reviewed by Eric Seidel.

Modify the #include declarations for several Cairo-related files
so that the wtf types are included using the full path.

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cairo/OwnPtrCairo.h:
  • platform/graphics/cairo/RefPtrCairo.h:
4:44 PM UsingGitHub edited by abarth@webkit.org
(diff)
4:44 PM Changeset in webkit [110909] by commit-queue@webkit.org
  • 7 edits
    1 delete in trunk

Implement LayoutTestController::setValueForUser on Windows ​https://bugs.webkit.org/show_bug.cgi?id=55834

Tools:

Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.

Patch by Lynn Neir <​lynn.neir@skype.net> on 2012-03-15
Reviewed by Jessie Berlin.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setValueForUser):

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setValueForUser):
(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

removed test, no longer needed as test passes and matches baseline expected results and also updated wk2 skipped file to no longer skip this test.

Patch by Lynn Neir <​lynn.neir@skype.net> on 2012-03-15
Reviewed by Jessie Berlin.

  • platform/win/fast/forms/onchange-setvalueforuser-expected.txt: Removed.
  • platform/wk2/Skipped:
4:42 PM UsingGitHub edited by abarth@webkit.org
(diff)
4:39 PM UsingGitHub edited by abarth@webkit.org
(diff)
4:30 PM Changeset in webkit [110908] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

only some tiles rendered when zoomed in
​https://bugs.webkit.org/show_bug.cgi?id=81282
<rdar://problem/11058898>

Reviewed by Andreas Kling.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::rectForTileIndex):
Make sure that the tile cache bounds are scaled accordingly.

4:28 PM Changeset in webkit [110907] by zeno.albisser@nokia.com
  • 3 edits in trunk/Source/WebCore

[Qt] RenderThemeQt::fileListNameForWidth should override function in base class RenderTheme. (r110560)
​https://bugs.webkit.org/show_bug.cgi?id=81107

Add "bool multipleFilesAllowed" to the parameter list of RenderThemeQt::fileListNameForWidth.
This way the base class function is properly overridden.
The need for this change became obvious after r110560 where the OVERRIDE keyword had been
added to the function signature.

Reviewed by Simon Hausmann.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::fileListNameForWidth):

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

4:27 PM UsingGitHub edited by abarth@webkit.org
(diff)
4:27 PM UsingGitHub edited by abarth@webkit.org
(diff)
4:26 PM UsingGitHub created by abarth@webkit.org
4:21 PM Changeset in webkit [110906] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Selection is not collapsed in some WK2 editing tests
​https://bugs.webkit.org/show_bug.cgi?id=69889

Add some expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/mac-wk2/editing/selection/caret-rtl-right-expected.txt: Added.
4:17 PM Changeset in webkit [110905] by yutak@chromium.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Change default WebSocket protocol to the latest one
​https://bugs.webkit.org/show_bug.cgi?id=73630

Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
Use RFC6455 WebSocket protocol by default.

4:11 PM Changeset in webkit [110904] by abarth@webkit.org
  • 2 edits in trunk/Tools

Update the start-queue.sh script to match what we're using on the bots
​https://bugs.webkit.org/show_bug.cgi?id=81277

Reviewed by Eric Seidel.

Over time we've added more magic git commands to clean up the local repo after
it has been borked in various ways. The idea behind this sequence is to clear
out any changes in the working copy and then to rebuild the master branch from
origin/master.

This patch also removes the watchdog timer that we've stopped using on the
bots.

This patch was reviewed on <​https://github.com/eseidel/webkit/pull/1>.
Note: Eric and I are experimenting with GitHub to see if it might be
useful for WebKit. If you have thoughts on this topic, please feel
free to grab Eric or me on #webkit to chat. I assume that he and I are
the only ones who care about this file so using this alternative
process for this patch shouldn't cause any trouble.

  • EWSTools/start-queue.sh:
4:07 PM Changeset in webkit [110903] by jonlee@apple.com
  • 18 edits
    1 delete in trunk/Source

Move NotificationContents into Notification
​https://bugs.webkit.org/show_bug.cgi?id=80487
<rdar://problem/10965519>

Reviewed by Jian Li.

Source/WebCore:

  • notifications/Notification.cpp: Alter signature of constructor to take the fields directly instead of

a NotificationContents instance.
(WebCore::Notification::Notification): Derive KURL from string representation of icon.
(WebCore::Notification::create):

  • notifications/Notification.h:

(Notification): Remove contents() accessor and replace with get for title and body. iconURL()
already existed, but use local variable instead of going through NotificationContents.
(WebCore::Notification::iconURL):
(WebCore::Notification::title):
(WebCore::Notification::body):

  • notifications/NotificationCenter.h:

(WebCore::NotificationCenter::createNotification): Refactor to use new constructor.

  • notifications/NotificationContents.h: Removed.

Remove NotificationContents.h from project files

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Refactor to use accessor methods on Notification.

  • src/WebNotification.cpp:

(WebKit::WebNotification::title):
(WebKit::WebNotification::body):

Source/WebKit/mac:

  • WebView/WebNotification.mm: Refactor to use accessor methods on Notification.

(-[WebNotification title]):
(-[WebNotification body]):

Source/WebKit/qt:

Refactor to use accessor methods on Notification.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationClicked):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):

Source/WebKit2:

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp: Remove extraneous include.
  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show): Refactor to use accessor methods on Notification.

4:04 PM Changeset in webkit [110902] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

CopiedSpace::tryAllocateOversize assumes system page size
​https://bugs.webkit.org/show_bug.cgi?id=80615

Patch by Myles Maxfield <​mmaxfield@google.com> on 2012-03-15
Reviewed by Geoffrey Garen.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::tryAllocateOversize):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::oversizeBlockFor):

  • wtf/BumpPointerAllocator.h:

(WTF::BumpPointerPool::create):

  • wtf/StdLibExtras.h:

(WTF::roundUpToMultipleOf):

3:50 PM Changeset in webkit [110901] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixing Windows build breakage

3:48 PM Changeset in webkit [110900] by abarth@webkit.org
  • 3 edits in trunk/Tools

The commit-queue can hang when the test_expectations.txt style check fails during commit
​https://bugs.webkit.org/show_bug.cgi?id=81251

Reviewed by Eric Seidel.

We forgot to check the --non-interactive flag, so we end up prompting
the "user" who doesn't exist on the bot. We might consider teaching
the User class about non-interactive if we have this sort of bug again.

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit.options):
(Commit._check_test_expectations):
(Commit.run):

  • Scripts/webkitpy/tool/steps/commit_unittest.py:

(CommitTest.test_check_test_expectations):

3:44 PM Changeset in webkit [110899] by jonlee@apple.com
  • 5 edits in trunk/Source

Deprecate ondisplay()
​https://bugs.webkit.org/show_bug.cgi?id=80483
<rdar://problem/10912432>

Reviewed by Jian Li.

Source/WebCore:

The appropriate event listener for notifications is onshow().

  • notifications/Notification.h: Wrap ondisplay in ENABLE(LEGACY_NOTIFICATIONS).
  • notifications/Notification.idl: Wrap ondisplay in ENABLE_LEGACY_NOTIFICATIONS.

Source/WebKit/chromium:

  • src/WebNotification.cpp:

(WebKit::WebNotification::dispatchDisplayEvent): Dispatch the show event.

3:31 PM Changeset in webkit [110898] by wjmaclean@chromium.org
  • 21 edits in trunk/Source

[chromium] Wire up PlatformGestureCurves for CC, ScrollAnimatorNone.
​https://bugs.webkit.org/show_bug.cgi?id=80607

Reviewed by James Robinson.

Source/WebCore:

Unit tests added. Layout tests to follow.

Provides implementation of PlatformGestureCurves in Chrome Compositor, and basic
support in ScrollAnimatorNone, for fling gestures.

  • GNUmakefile.list.am:
  • platform/ActivePlatformGestureAnimation.cpp:

(WebCore::ActivePlatformGestureAnimation::create):
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):
(WebCore::ActivePlatformGestureAnimation::animate):

  • platform/ActivePlatformGestureAnimation.h:

(ActivePlatformGestureAnimation):

  • platform/PlatformGestureCurveTarget.h:

(PlatformGestureCurveTarget):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::cancelAnimations):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::scrollBy):
(WebCore):

  • platform/ScrollAnimatorNone.h:

(WebCore):
(ScrollAnimatorNone):

  • platform/TouchFlingPlatformGestureCurve.cpp:

(WebCore::TouchFlingPlatformGestureCurve::apply):

  • platform/WheelFlingPlatformGestureCurve.cpp:

(WebCore::WheelFlingPlatformGestureCurve::apply):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:

(WebCore::CCActiveGestureAnimation::create):
(WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):
(WebCore::CCActiveGestureAnimation::animate):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.h:

(CCActiveGestureAnimation):

  • platform/graphics/chromium/cc/CCGestureCurve.h:

(CCGestureCurveTarget):

  • platform/graphics/chromium/cc/CCInputHandler.h:

(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::setActiveGestureAnimation):
(WebCore):
(WebCore::CCLayerTreeHostImpl::animateGestures):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(WebCore::CCLayerTreeHostImpl::activeGestureAnimation):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isScrollGestureEventType):

  • src/WebCompositorInputHandlerImpl.cpp:

(PlatformGestureToCCGestureAdapter):
(WebCore::PlatformGestureToCCGestureAdapter::create):
(WebCore::PlatformGestureToCCGestureAdapter::apply):
(WebCore::PlatformGestureToCCGestureAdapter::scrollBy):
(WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):
(WebCore):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):

  • src/WebCompositorInputHandlerImpl.h:

(WebCore):
(WebCompositorInputHandlerImpl):

  • tests/PlatformGestureCurveTest.cpp:
  • tests/WebCompositorInputHandlerImplTest.cpp:
3:22 PM Changeset in webkit [110897] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build correction. WinCairo export definitions
file was not updated when the main Apple file was changed.

  • win/WebKit2CFLite.def: Revise export declarations to match

new symbol names.

3:17 PM Changeset in webkit [110896] by Patrick Gansterer
  • 6 edits in trunk

[EFL] Make zlib a general build requirement
​https://bugs.webkit.org/show_bug.cgi?id=80153

Reviewed by Hajime Morita.

After r109538 WebSocket module needs zlib to support deflate-frame extension.

.:

  • Source/cmake/OptionsEfl.cmake:

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

  • PlatformEfl.cmake:
3:16 PM Changeset in webkit [110895] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Cleanup of outdated test expectations
​https://bugs.webkit.org/show_bug.cgi?id=81253

Unreviewed chromium expectations.

  • platform/chromium/test_expectations.txt: Adding Linux svg/text/text-tselect-02.f.svg
3:14 PM Changeset in webkit [110894] by rwlbuis@webkit.org
  • 2 edits in trunk

[BlackBerry] Remove some features that we do not have anymore
​https://bugs.webkit.org/show_bug.cgi?id=81274

Reviewed by Antonio Gomes.

Remove some features that we do not have anymore, code was removed some time ago.

  • Source/cmake/OptionsBlackBerry.cmake:
3:13 PM Changeset in webkit [110893] by commit-queue@webkit.org
  • 3 edits in trunk

REGRESSION (r110371): broke platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html
​https://bugs.webkit.org/show_bug.cgi?id=80825

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-15
Reviewed by James Robinson.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent): Corrected a typo.

3:09 PM Changeset in webkit [110892] by timothy_horton@apple.com
  • 1 edit
    5 deletes in trunk/LayoutTests

Remove mac-future results
​https://bugs.webkit.org/show_bug.cgi?id=81275

There should never be anything in LayoutTests/platform/mac-future.
Please don't put anything there in the future.

Rubber-stamped by Alexey Proskuryakov.

  • platform/mac-future/css1: Removed.
  • platform/mac-future/css1/font_properties: Removed.
  • platform/mac-future/css1/font_properties/font-expected.png: Removed.
  • platform/mac-future/css2.1: Removed.
  • platform/mac-future/css2.1/t1508-c527-font-05-b-expected.png: Removed.
  • platform/mac-future/css2.1/t1508-c527-font-10-c-expected.png: Removed.
  • platform/mac-future/fast: Removed.
  • platform/mac-future/fast/css: Removed.
  • platform/mac-future/fast/css/font-family-pictograph-expected.png: Removed.
  • platform/mac-future/fast/css/font-family-pictograph-expected.txt: Removed.
  • platform/mac-future/fast/dom: Removed.
  • platform/mac-future/fast/dom/52776-expected.txt: Removed.
  • platform/mac-future/fast/forms: Removed.
  • platform/mac-future/fast/forms/listbox-bidi-align-expected.png: Removed.
  • platform/mac-future/fast/repaint: Removed.
  • platform/mac-future/fast/repaint/canvas-putImageData-expected.txt: Removed.
  • platform/mac-future/fast/text: Removed.
  • platform/mac-future/fast/text/capitalize-boundaries-expected.png: Removed.
  • platform/mac-future/fast/writing-mode: Removed.
  • platform/mac-future/fast/writing-mode/fallback-orientation-expected.png: Removed.
  • platform/mac-future/media: Removed.
  • platform/mac-future/media/video-display-toggle-expected.txt: Removed.
  • platform/mac-future/media/video-no-audio-expected.txt: Removed.
  • platform/mac-future/svg: Removed.
  • platform/mac-future/svg/W3C-I18N: Removed.
  • platform/mac-future/svg/W3C-SVG-1.1-SE: Removed.
  • platform/mac-future/svg/batik: Removed.
  • platform/mac-future/svg/batik/masking: Removed.
  • platform/mac-future/svg/batik/text: Removed.
  • platform/mac-future/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Removed.
  • platform/mac-future/svg/carto.net: Removed.
  • platform/mac-future/svg/carto.net/scrollbar-expected.png: Removed.
  • platform/mac-future/svg/custom: Removed.
2:54 PM Changeset in webkit [110891] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

NumericStrings should be inlined
​https://bugs.webkit.org/show_bug.cgi?id=81183

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-03-15
Reviewed by Gavin Barraclough.

NumericStrings is not always inlined. When it is not, the class is not faster
than using UString::number() directly.

  • runtime/NumericStrings.h:

(JSC::NumericStrings::add):
(JSC::NumericStrings::lookupSmallString):

2:46 PM Changeset in webkit [110890] by ap@apple.com
  • 3 edits
    1 copy
    4 deletes in trunk/LayoutTests

Move test results from mac-lion to mac
​https://bugs.webkit.org/show_bug.cgi?id=81266

Reviewed by Jessie Berlin.

  • platform/mac-lion/canvas: Removed.
  • platform/mac-lion/canvas/philip: Removed.
  • platform/mac-lion/canvas/philip/tests: Removed.
  • platform/mac-lion/editing: Removed.
  • platform/mac-lion/editing/inserting: Removed.
  • platform/mac-lion/editing/inserting/break-blockquote-after-delete-expected.png: Removed.
  • platform/mac-lion/fast: Removed.
  • platform/mac-lion/fast/css: Removed.
  • platform/mac-lion/fast/css/font-family-pictograph-expected.txt: Removed.
  • platform/mac-lion/svg: Removed.
  • platform/mac-lion/svg/W3C-SVG-1.1-SE: Removed.
  • platform/mac-lion/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/mac/fast/css/font-family-pictograph-expected.txt: Copied from LayoutTests/platform/mac-lion/fast/css/font-family-pictograph-expected.txt.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
2:39 PM Changeset in webkit [110889] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Fix crbug 117957 - get settings scrolling with the wheel again.
​https://bugs.webkit.org/show_bug.cgi?id=81247

Patch by Scott Byer <​scottbyer@chromium.org> on 2012-03-15
Reviewed by James Robinson.

Tests to follow.

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

2:33 PM Changeset in webkit [110888] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r107168?): Assertion failures under pageContainsAnyHorizontalScrollbars causing multiple "crashes" on the Lion Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81162
<rdar://problem/11050423>

Reviewed by Beth Dakin and Jessie Berlin.

Downgrade the ASSERT to a simple if check since scrollableArea->isOnActivePage() can return false when layout happens during page transitions.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::pageContainsAnyHorizontalScrollbars):

2:30 PM Changeset in webkit [110887] by hyatt@apple.com
  • 13 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=81258

Add a preference for enabling the new multi-column layout code that will be based on regions.

Reviewed by Beth Dakin.

Source/WebCore:

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setRegionBasedColumnsEnabled):
(WebCore::Settings::regionBasedColumnsEnabled):
(Settings):

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setRegionBasedColumnsEnabled:]):
(-[WebPreferences regionBasedColumnsEnabled]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetRegionBasedColumnsEnabled):
(WKPreferencesGetRegionBasedColumnsEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

2:24 PM Changeset in webkit [110886] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

RenderStyle: Return Color objects by value instead of as const references.
<​http://webkit.org/b/81180>

Reviewed by Antti Koivisto.

Make RenderStyle getters return "Color" rather than "const Color&". This is preparation
for storing some color values in a more space-efficient fashion.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyColor::applyInheritValue):

  • page/animation/AnimationBase.cpp:

(PropertyWrapperColor):
(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperColor::blend):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(PropertyWrapperSVGPaint):

  • platform/graphics/Color.h:

(WebCore::Color::Color):

  • rendering/style/RenderStyle.h:
2:16 PM Changeset in webkit [110885] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Can't swipe to go back/forward when the current page is a PDF document
​https://bugs.webkit.org/show_bug.cgi?id=81194
<rdar://problem/6954125>

Reviewed by Sam Weinig.

Override -[PDFViewScrollView scrollWheel:] and have the new implementation call
-[WKPDFView forwardScrollWheelEvent:] when the PDF is pinned to either the left or right side.
WKPDFView will then call PDFController::forwardScrollWheelEvent which checks if we can go back or forward,
and passes the event along to the WKView which ends up triggering the swiping machinery in Safari.

  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm:

(-[WKPDFView forwardScrollWheelEvent:]):
(WebKit):
(WebKit::PDFViewController::forwardScrollWheelEvent):
(WebKit::findEnclosingWKPDFView):
(WebKit::PDFViewScrollView_scrollWheel):
(WebKit::PDFViewController::pdfKitBundle):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

2:07 PM Changeset in webkit [110884] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Assertion failures in WebCore::Page::goBackOrForward causing multiple "crashes" on Lion Intel
Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81159

Rubber-stamped by Brady Eidson.

It is plausible that history could change in between the time a navigation request is
scheduled and the timer is fired, so the request index could be out of the b/f list range.
Hence, the assertion is invalid and should be removed.

  • page/Page.cpp:

(WebCore::Page::goBackOrForward):

2:07 PM Changeset in webkit [110883] by jberlin@webkit.org
  • 2 edits in trunk/Tools

fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
Mac WK2 because WebAudio is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=81259

Reviewed by Dan Bernstein.

Enable WebAudio so that it appears in the window object in the tests.
The webaudio tests are all still skipped in the Mac Skipped list.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

2:07 PM Changeset in webkit [110882] by ap@apple.com
  • 3 edits in trunk/Source/WebCore

Assertion failures in checkEncodedString when running WebKit2 tests
​https://bugs.webkit.org/show_bug.cgi?id=67425
<rdar://problem/11043492>

Reviewed by Anders Carlsson.

  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::cfError):
  • platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::nsError): The failing URL is certainly not guaranteed to be valid, so it's not correct to put it back into a URL as if it's been normalized by KURL.
1:39 PM Changeset in webkit [110881] by abecsi@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix ARM build after r110792.

Unreviewed build fix.

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):
Remove superfluous curly brackets.

1:23 PM Changeset in webkit [110880] by beidson@apple.com
  • 16 edits
    2 adds in trunk

<rdar://problem/11036900> and ​https://bugs.webkit.org/show_bug.cgi?id=81079 REGRESSION(r107844): Clipboard API only remembers most recent data set on clipboard

Reviewed by Sam Weinig.

Source/WebCore:

Test: editing/pasteboard/copy-two-pasteboard-types-both-work.html

Add the non-destructive "addTypes" to supplement the destructive "setTypes"

  • platform/PasteboardStrategy.h:

(PasteboardStrategy):

  • platform/PlatformPasteboard.h:

(PlatformPasteboard):

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::addTypes):

  • WebCore.exp.in:
  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::setData): Call the non-destructive "addTypes" instead of

the destructive "setTypes"

Source/WebKit/mac:

Add the non-destructive "addTypes" to supplement the destructive "setTypes"

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::addTypes):

Source/WebKit2:

Add the non-destructive "addTypes" to supplement the destructive "setTypes"

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::addPasteboardTypes):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::addTypes):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

LayoutTests:

  • editing/pasteboard/copy-two-pasteboard-types-both-work-expected.txt: Added.
  • editing/pasteboard/copy-two-pasteboard-types-both-work.html: Added.
1:09 PM Changeset in webkit [110879] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. New flaky tests and new failure modes for old flaky tests.

  • platform/chromium/test_expectations.txt:
1:06 PM Changeset in webkit [110878] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[Chromium] REGRESSION(r110596) CCQuadCullerTest.verifyCullChildLinesUpTopLeft fails on Windows
​https://bugs.webkit.org/show_bug.cgi?id=81083

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-15
Reviewed by Adrienne Walker.

Source/WebCore:

The surface pointer on the occlusion tracker stack is uninitialized, and
can be non-null, but the layer's target surface is null, causing asserts
to fail. Fixes the TestCCOcclusionTrackerImpl to initialize the stack's
surface to be null.

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::enterTargetRenderSurface):
(WebCore::::unoccludedContentRect):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(WebCore::CCOcclusionTrackerBase::StackObject::StackObject):

Source/WebKit/chromium:

  • tests/CCQuadCullerTest.cpp:

(WebCore::TEST):

1:06 PM Changeset in webkit [110877] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARMv7: prefer vmov(gpr,gpr->double) over vmov(gpr->single)
​https://bugs.webkit.org/show_bug.cgi?id=81256

Reviewed by Oliver Hunt.

This is a 0.5% sunspider progression.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::convertInt32ToDouble):

  • switch which form of vmov we use.
12:55 PM Changeset in webkit [110876] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[EFL] Add OwnPtr specialization for Ecore_Timer.
​https://bugs.webkit.org/show_bug.cgi?id=80119

Patch by YoungTaeck Song <​youngtaeck.song@samsung.com> on 2012-03-15
Reviewed by Hajime Morita.

Add an overload for deleteOwnedPtr(Ecore_Timer*) on EFL port.

  • wtf/OwnPtrCommon.h:

(WTF):

  • wtf/efl/OwnPtrEfl.cpp:

(WTF::deleteOwnedPtr):
(WTF):

12:54 PM Changeset in webkit [110875] by levin@chromium.org
  • 12 edits in trunk

Various autoresize fixes.
​https://bugs.webkit.org/show_bug.cgi?id=81199

Reviewed by Darin Fisher.

Source/WebCore:

Tested by WebViewTest additions.

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled): Fixed a bug that caused a horizontal
scrollbar to appear when the size was width was fixed and height overflowed which
is one of the tests that was added.

Source/WebKit/chromium:

  • public/WebView.h:

(WebView): Remove a deprecated api.

  • src/WebViewImpl.cpp: Ditto.
  • src/WebViewImpl.h: Ditto.
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::registerMockedURLLoad): Added an overload with more flexibility.
The previous api didn't allow one to request a url with a search string.
(FrameTestHelpers):

  • tests/FrameTestHelpers.h:

(FrameTestHelpers): Ditto.

  • tests/WebViewTest.cpp: Fix the test because calling javascript:

was working. Make the test generic and added a lot more tests to cover
various possibilities. I avoided using a layout test because there wasn't
a way to get the scrollbar state, so I just generalized a test that was already there.

  • tests/data/specify_size.html: Allow the test to take its size from the search string.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset): Stop using the deprecated api that was removed.

12:54 PM Changeset in webkit [110874] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Linux has madvise enough to support OSAllocator::commit/decommit
​https://bugs.webkit.org/show_bug.cgi?id=80505

Patch by Hojong Han <​hojong.han@samsung.com> on 2012-03-15
Reviewed by Geoffrey Garen.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):

12:33 PM Changeset in webkit [110873] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: normalize vertical overview bars by longest bar, not by longest frame
​https://bugs.webkit.org/show_bug.cgi?id=81231

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype.accept):
(WebInspector.TimelineOverviewPane.prototype.windowEndTime):
(WebInspector.TimelineVerticalOverview.prototype.reset):
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames):
(WebInspector.TimelineVerticalOverview.prototype._aggregateRecords):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):

12:29 PM Changeset in webkit [110872] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: crash in InspectorTimelineAgent when trying to add children to cancelable records
​https://bugs.webkit.org/show_bug.cgi?id=81245

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::commitCancelableRecords):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

12:17 PM Changeset in webkit [110871] by sfalken@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Windows build fix.

12:16 PM Changeset in webkit [110870] by schenney@chromium.org
  • 3 edits in trunk/LayoutTests

Temporarily skip svg/custom/delete-text-crash.html on mac and win
​https://bugs.webkit.org/show_bug.cgi?id=81006

Unreviewed update of expectations.

Patch by Philip Rogers <​pdr@google.com> on 2012-03-15

  • platform/mac/Skipped:
  • platform/win/Skipped:
12:10 PM Changeset in webkit [110869] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Cleanup of outdated test expectations
​https://bugs.webkit.org/show_bug.cgi?id=81253

Unreviewed chromium test expectations update.

  • platform/chromium/test_expectations.txt: Updated bug numbers or removed several SVG-related expectations.
11:55 AM Changeset in webkit [110868] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: live locations could be disposed twice.
​https://bugs.webkit.org/show_bug.cgi?id=81249

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):

11:45 AM Changeset in webkit [110867] by timothy_horton@apple.com
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed rebaseline of canvas/philip/tests/2d.line.cap.round; the platform
independent results are correct for mac now, so remove the specific ones.

  • platform/mac-snowleopard/canvas/philip/tests/2d.line.cap.round-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.line.cap.round-expected.txt: Removed.
11:31 AM Changeset in webkit [110866] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Actually use --release and --debug command line options in run-gtk-test
​https://bugs.webkit.org/show_bug.cgi?id=81234

Reviewed by Philippe Normand.

Actually handle --release and --debug command line options to
create the build directory, falling back to current hack to detect
whether it's a Release or Debug build when both options are missed.

  • Scripts/run-gtk-tests:

(TestRunner.init): Receive options too.
(TestRunner._get_top_level_directory): Helper function to get the
top level directory.
(TestRunner._get_build_directory): Helper function to get the
build directory depending on --release/--debug command line
options or gessing it if both options are missing.
(TestRunner._ensure_accessibility_daemon_is_running): Use
self-options now.
(TestRunner.run): Ditto.
(TestRunner.run.run_tests): Pass options to the constructor
instead of run().

11:28 AM Changeset in webkit [110865] by Carlos Garcia Campos
  • 15 edits in trunk/Source

[GTK] Implement unicode submenu items
​https://bugs.webkit.org/show_bug.cgi?id=81117

Reviewed by Martin Robinson.

Source/WebCore:

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::shouldShowUnicodeMenu): Just return
false.

  • page/ContextMenuController.cpp:

(WebCore::insertUnicodeCharacter): Helper function to insert a
unicode character.
(WebCore::ContextMenuController::contextMenuItemSelected):
Implement unicode menu items using insertUnicodeCharacter() to
insert the apropriate unicode character.
(WebCore::ContextMenuController::createAndAppendUnicodeSubMenu):
Create the unicode submenu.
(WebCore::ContextMenuController::populate): Add unicode submenu
item for editable content.
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Add
unicode submenu items to the switch.

  • page/ContextMenuController.h:
  • page/EditorClient.h:

(EditorClient): Add shouldShowUnicodeMenu() for GTK platform.

  • platform/ContextMenuItem.h:
  • platform/LocalizedStrings.h:
  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::contextMenuItemTagUnicodeInsertLRMMark): Add localized
string for the unicode menu item.
(WebCore::contextMenuItemTagUnicodeInsertRLMMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertLREMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertRLEMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertLROMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertRLOMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertPDFMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertZWSMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertZWJMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertZWNJMark): Ditto.

Source/WebKit/gtk:

  • WebCoreSupport/ContextMenuClientGtk.cpp:

(WebKit::getUnicodeMenuItemPosition): Helper function to get the
position of the unicode menu item in the default context menu.
(WebKit::ContextMenuClient::getCustomMenuFromDefaultItems): Remove
code to build the unicode menu, since it's now built by WebCore.

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::shouldShowUnicodeMenu): Check whether
unicode menu should be shown based on gtk-show-unicode-menu GtkSetting.

  • WebCoreSupport/EditorClientGtk.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::shouldShowUnicodeMenu): Implement
shouldShowUnicodeMenu() returning always true. When ContextMenu
API is implemented for GTK+ the UI process will decide whether to
show the unicode menu or not.

11:26 AM Changeset in webkit [110864] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: MainScriptMapping should detect snippet scripts by means of sourceURL set before evaluation.
​https://bugs.webkit.org/show_bug.cgi?id=81031

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsModel):
(WebInspector.SnippetsModel.prototype._saveSettings):
(WebInspector.SnippetsModel.prototype.deleteSnippet):
(WebInspector.SnippetsModel.prototype._snippetAdded):
(WebInspector.SnippetsModel.prototype._sourceURLForSnippet):
(WebInspector.SnippetsModel.prototype.snippetIdForSourceURL):
(WebInspector.SnippetsModel.prototype.snippetForSourceURL):
(WebInspector.Snippet.prototype.evaluate):
(WebInspector.SnippetsScriptMapping):
(WebInspector.SnippetsScriptMapping.prototype.uiLocationToRawLocation.get if):
(WebInspector.SnippetsScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.SnippetsScriptMapping.prototype._releasedUISourceCodes):
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._snippetWillBeEvaluated):
(WebInspector.SnippetsScriptMapping.prototype._snippetRemoved.get this):
(WebInspector.SnippetsScriptMapping.prototype._snippetRemoved):

LayoutTests:

  • inspector/debugger/snippets-model-expected.txt:
  • inspector/debugger/snippets-model.html:
11:24 AM Changeset in webkit [110863] by sfalken@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

11:24 AM Changeset in webkit [110862] by alexis.menard@openbossa.org
  • 2 edits in trunk/PerformanceTests

Fix the test failing with run-perf-tests.

Rubber stamped by Ryosuke Niwa.

  • CSS/CSSPropertySetterGetter.html:
11:15 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
10:51 AM WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
10:37 AM Changeset in webkit [110861] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Run unit tests with --verbose in the bots
​https://bugs.webkit.org/show_bug.cgi?id=81230

Reviewed by Martin Robinson.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunGtkAPITests): Add --verbose to run-gtk-test command.

10:32 AM Changeset in webkit [110860] by caryclark@google.com
  • 2 edits in trunk/LayoutTests

migrate Yang Guo's expectations from chromium to webkit
​https://bugs.webkit.org/show_bug.cgi?id=81026

Unreviewed test_expectations.

Patch by Elliot Poger <​epoger@google.com> on 2012-03-15

  • platform/chromium/test_expectations.txt:
10:28 AM Changeset in webkit [110859] by kevino@webkit.org
  • 3 edits in trunk

Unreviewed. Fix typos in ChangeLog dates.

10:25 AM Changeset in webkit [110858] by kevino@webkit.org
  • 7 edits in trunk

Move wx port to using export macros
​https://bugs.webkit.org/show_bug.cgi?id=77279

Reviewed by Hajime Morita.

10:14 AM Changeset in webkit [110857] by kevino@webkit.org
  • 3 edits in trunk/Source/WebCore

[wx] Unreviewed. Build fixes for Mac and DOM bindings.

9:55 AM Changeset in webkit [110856] by podivilov@chromium.org
  • 15 edits
    1 add in trunk

Web Inspector: extract CompilerScriptMapping from RawSourceCode.
​https://bugs.webkit.org/show_bug.cgi?id=81088

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js: Added.

(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.get uiSourceCodeList):
(WebInspector.CompilerScriptMapping.prototype.addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.addScript):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
(WebInspector.CompilerScriptMapping.prototype.reset):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-expected.txt:
  • http/tests/inspector/compiler-source-mapping.html:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest.):
(initialize_DebuggerTest):

  • inspector/debugger/raw-source-code-expected.txt:
  • inspector/debugger/raw-source-code.html:
9:52 AM Changeset in webkit [110855] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

css3/filters/custom/custom-filter-property-computed-style.html passes in browser, fails in DRT.
​https://bugs.webkit.org/show_bug.cgi?id=81029

Land expected passing results for WKTR.

  • platform/mac-wk2/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Added.
9:44 AM Changeset in webkit [110854] by yurys@chromium.org
  • 49 edits in trunk/Source/WebCore

Web Inspector: Move all includes behind ENABLE(INSPECTOR) guards
​https://bugs.webkit.org/show_bug.cgi?id=81132

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-03-15
Reviewed by Yury Semikhatsky.

Include directives are moved several lines down in .cpp files and in
generator templates.

  • inspector/CodeGeneratorInspector.py:
  • inspector/ContentSearchUtils.cpp:
  • inspector/DOMEditor.cpp:
  • inspector/DOMNodeHighlighter.cpp:
  • inspector/DOMPatchSupport.cpp:
  • inspector/IdentifiersFactory.cpp:
  • inspector/InjectedScript.cpp:
  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptManager.cpp:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorApplicationCacheAgent.cpp:
  • inspector/InspectorBaseAgent.cpp:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorClient.cpp:
  • inspector/InspectorConsoleAgent.cpp:
  • inspector/InspectorController.cpp:
  • inspector/InspectorCounters.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMDebuggerAgent.cpp:
  • inspector/InspectorDOMStorageAgent.cpp:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDatabaseResource.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorFileSystemAgent.cpp:
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorHistory.cpp:
  • inspector/InspectorIndexedDBAgent.cpp:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorPageAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:
  • inspector/InspectorResourceAgent.cpp:
  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorState.cpp:
  • inspector/InspectorStyleSheet.cpp:
  • inspector/InspectorStyleTextEditor.cpp:
  • inspector/InspectorTimelineAgent.cpp:
  • inspector/InspectorValues.cpp:
  • inspector/InstrumentingAgents.cpp:
  • inspector/NetworkResourcesData.cpp:
  • inspector/PageConsoleAgent.cpp:
  • inspector/PageDebuggerAgent.cpp:
  • inspector/PageRuntimeAgent.cpp:
  • inspector/TimelineRecordFactory.cpp:
  • inspector/WorkerConsoleAgent.cpp:
  • inspector/WorkerDebuggerAgent.cpp:
  • inspector/WorkerRuntimeAgent.cpp:
9:39 AM Changeset in webkit [110853] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: improve HeapSnapshot._buildReversIndex performance
​https://bugs.webkit.org/show_bug.cgi?id=81224

Caching node indexes and node count in local variables instead of
calling getters each time reduces the method run time by
factor of 1.5

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildReverseIndex):

9:35 AM Changeset in webkit [110852] by leviw@chromium.org
  • 1 edit
    7 adds
    3 deletes in trunk/LayoutTests

Unreviewed gardening.

Updating slightly changed SVG animation text expectations post-110545.

  • platform/chromium-linux-x86/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/css/stars-with-shadow-expected.txt: Removed.
  • platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/chromium-win-vista/fast/repaint: Removed.
  • platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt: Replaced.
  • platform/chromium/svg/css/stars-with-shadow-expected.txt: Replaced.
9:03 AM Changeset in webkit [110851] by Nikolas Zimmermann
  • 17 edits in trunk/Source/WebCore

2012-03-15 Nikolas Zimmermann <​nzimmermann@rim.com>

SVG Animations update baseVal instead of animVal
​https://bugs.webkit.org/show_bug.cgi?id=12437

Rubber-stamped by Rob Buis.

Rename constructFromCopy to constructFromVariant, and currentBaseValue to currentBaseValueVariant, to clarify what it actually does.

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::resetToBaseValue):
  • svg/SVGAnimatedLength.cpp: (WebCore::SVGAnimatedLengthAnimator::constructFromVariant):
  • svg/SVGAnimatedLength.h: (SVGAnimatedLengthAnimator):
  • svg/SVGAnimatedLengthList.cpp: (WebCore::SVGAnimatedLengthListAnimator::constructFromVariant):
  • svg/SVGAnimatedLengthList.h: (SVGAnimatedLengthListAnimator):
  • svg/SVGAnimatedNumber.cpp: (WebCore::SVGAnimatedNumberAnimator::constructFromVariant):
  • svg/SVGAnimatedNumber.h: (SVGAnimatedNumberAnimator):
  • svg/SVGAnimatedNumberList.cpp: (WebCore::SVGAnimatedNumberListAnimator::constructFromVariant):
  • svg/SVGAnimatedNumberList.h: (SVGAnimatedNumberListAnimator):
  • svg/SVGAnimatedTransformList.cpp: (WebCore::SVGAnimatedTransformListAnimator::constructFromVariant):
  • svg/SVGAnimatedTransformList.h: (SVGAnimatedTransformListAnimator):
  • svg/SVGAnimatedTypeAnimator.h: (WebCore::SVGAnimatedTypeAnimator::constructFromVariant):
  • svg/properties/SVGAnimatedListPropertyTearOff.h: (WebCore::SVGAnimatedListPropertyTearOff::currentBaseValueVariant):
  • svg/properties/SVGAnimatedProperty.h: (SVGAnimatedProperty):
  • svg/properties/SVGAnimatedPropertyTearOff.h: (WebCore::SVGAnimatedPropertyTearOff::currentBaseValueVariant):
  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: (WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValueVariant):
8:58 AM Changeset in webkit [110850] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Fix bounce-back behaviour for panning
​https://bugs.webkit.org/show_bug.cgi?id=81144

Reviewed by Kenneth Rohde Christiansen.

Move the content back to boundaries immediately
in response to a tap gesture during the bounce-back
animation after panning.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.h:

Make the ensureContentWithinViewportBoundary function public.
(QtViewportInteractionEngine):

8:36 AM Changeset in webkit [110849] by senorblanco@chromium.org
  • 2 edits
    28 adds
    32 deletes in trunk/LayoutTests

[chromium] Unreviewed gardening.

Updated Lion baselines for css3/filters. Skipped all custom tests,
and removed all baselines, since support is not currently compiled in.

  • platform/chromium-mac-leopard/css3/filters/custom: Removed.
  • platform/chromium-mac-leopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/filters/custom/effect-custom-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/filters/custom/effect-custom-parameters-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/composited-during-transition-layertree-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/custom: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-brightness-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-invert-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-saturate-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-sepia-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/filter-repaint-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/filter-with-transform-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/nested-filter-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/nested-filters-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/regions-expanding-expected.png: Removed.
  • platform/chromium-mac/css3/filters/composited-during-transition-layertree-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-brightness-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-brightness-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-combined-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-combined-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-contrast-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-contrast-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-grayscale-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-grayscale-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-hue-rotate-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-invert-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-invert-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-invert-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-opacity-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-opacity-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-saturate-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-saturate-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-sepia-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-sepia-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-expected.png: Added.
  • platform/chromium-mac/css3/filters/filter-with-transform-expected.png: Added.
  • platform/chromium-mac/css3/filters/nested-filter-expected.png: Added.
  • platform/chromium-mac/css3/filters/nested-filters-expected.png: Added.
  • platform/chromium-mac/css3/filters/regions-expanding-expected.png: Added.
  • platform/chromium-win/css3/filters/custom: Removed.
  • platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
  • platform/chromium-win/css3/filters/custom/effect-custom-expected.png: Removed.
  • platform/chromium-win/css3/filters/custom/effect-custom-parameters-expected.png: Removed.
  • platform/chromium/css3/filters/custom: Removed.
  • platform/chromium/css3/filters/custom/effect-custom-combined-missing-expected.txt: Removed.
  • platform/chromium/css3/filters/custom/effect-custom-disabled-expected.txt: Removed.
  • platform/chromium/css3/filters/custom/effect-custom-expected.txt: Removed.
  • platform/chromium/css3/filters/custom/effect-custom-parameters-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
8:27 AM Changeset in webkit [110848] by Nikolas Zimmermann
  • 11 edits in trunk

Enable animVal support for SVGNumberList
​https://bugs.webkit.org/show_bug.cgi?id=81219

Reviewed by Rob Buis.

Source/WebCore:

Enable animVal support for SVGNumberList. Easy patch, we just need to add the missing
constructFromCopy() method to SVGAnumatedNumberListAnimator and report AnimatedNumberList
as supporting animVal.

Covered by existing tests.

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::constructFromCopy):
(WebCore):

  • svg/SVGAnimatedNumberList.h:

(WebCore):
(SVGAnimatedNumberListAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):

LayoutTests:

Extend SVGNumberList tests to cover animVal/baseVal at the same time.

  • platform/chromium/test_expectations.txt:
  • svg/animations/script-tests/svgnumberlist-animation-1.js:

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/svgnumberlist-animation-2.js:

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/svgnumberlist-animation-1-expected.txt:
  • svg/animations/svgnumberlist-animation-2-expected.txt:
  • svg/filters/feColorMatrix-invalid-animation-expected.txt: We no longer mutate the DOM, thus the dump is now correct.
8:12 AM Changeset in webkit [110847] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, GTK build fix attempt after r110845.

  • Scripts/run-gtk-tests: Added --release and --debug options.
7:58 AM Changeset in webkit [110846] by kubo@profusion.mobi
  • 3 edits
    2 copies
    1 add in trunk/Tools

Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
​https://bugs.webkit.org/show_bug.cgi?id=79673

Preparatory work for bringing jhbuild enabled build to EFL port.

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-03-15
Reviewed by Philippe Normand.

  • Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
  • Scripts/update-webkitgtk-libs:
  • gtk/run-with-jhbuild:
  • jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.

(top_level_path):
(jhbuild_installed):
(jhbuild_cloned):
(jhbuild_at_expected_revision):
(update_jhbuild):
(clone_jhbuild):
(install_jhbuild):
(update_webkit_libs_jhbuild):
(determine_platform):
(ensure_jhbuild):

7:44 AM Changeset in webkit [110845] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Add command line options to run-gtk-tests script
​https://bugs.webkit.org/show_bug.cgi?id=81218

Reviewed by Philippe Normand.

Following command line options have been added:

-v, --verbose: to run gtester with --verbose. That would be used
by the bots to make it easier to know which test case it failing.

--display: to use a different display for Xvfb

It's also possible to pass one or more tests as arguments.

  • Scripts/run-gtk-tests:

(TestRunner.init): Receive command line arguments.
(TestRunner._get_tests): Get all the tests or the ones passed by
command line arguments.
(TestRunner._ensure_accessibility_daemon_is_running): Use display
command line argument.
(TestRunner.run): Pas command line options.
(TestRunner.run.run_tests): Pass command line arguments.

7:34 AM Changeset in webkit [110844] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix cast-align GCC warnings
​https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Nikolas Zimmermann.

  • platform/graphics/WOFFFileFormat.cpp:

(WebCore::writeUInt32):
(WebCore::writeUInt16):
(WebCore::convertWOFFToSfnt):

7:17 AM Changeset in webkit [110843] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
7:15 AM Changeset in webkit [110842] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2012-03-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Forgot to preserve copyrights, per reviewer comment.

  • svg/SVGAnimatedTransformList.cpp:
7:12 AM Changeset in webkit [110841] by Nikolas Zimmermann
  • 7 edits
    3 adds in trunk

Enable animVal support for SVGNumber
​https://bugs.webkit.org/show_bug.cgi?id=81212

Reviewed by Rob Buis.

Source/WebCore:

Enable animVal support for SVGNumber. This aligns SVGAnimatedStaticPropertyTearOff,
with the other SVGListPropertyTearOff & SVGPropertyTearOff, as all support animVal now.
Converting the rest of the types can be done in small patches now.

Test: svg/animations/svgnumber-animation-4.html

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::constructFromCopy):
(WebCore):

  • svg/SVGAnimatedNumber.h:

(WebCore):
(SVGAnimatedNumberAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):

  • svg/properties/SVGAnimatedProperty.h:

(SVGAnimatedProperty):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(WebCore::SVGAnimatedStaticPropertyTearOff::animVal):
(WebCore::SVGAnimatedStaticPropertyTearOff::currentAnimatedValue):
(SVGAnimatedStaticPropertyTearOff):
(WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationValueWillChange):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationValueDidChange):
(WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):

LayoutTests:

Add new test covering animVal support for SVGNumber.

  • svg/animations/script-tests/svgnumber-animation-4.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/svgnumber-animation-4-expected.txt: Added.
  • svg/animations/svgnumber-animation-4.html: Added.
7:00 AM Changeset in webkit [110840] by Carlos Garcia Campos
  • 2 edits
    2 adds in trunk/Tools

[GTK] WebKit2APITests/TestPrinting timeout in the bots
​https://bugs.webkit.org/show_bug.cgi?id=81211

Reviewed by Philippe Normand.

Add gtk+ patch to fix timeout in the bots. A similar patch has
already landed in updatream gtk+, see
​http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f

  • gtk/jhbuild.modules:
  • gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
6:34 AM Changeset in webkit [110839] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2012-03-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix typo introduced in my last patch leading to flakiness.

  • svg/animations/script-tests/animateTransform-pattern-transform.js: (executeTest):
6:09 AM Changeset in webkit [110838] by Nikolas Zimmermann
  • 30 edits
    1 add in trunk

Enable animVal support for SVGTransformList
​https://bugs.webkit.org/show_bug.cgi?id=80758

Reviewed by Antti Koivisto.

Source/WebCore:

Enable animVal support for SVGTransformList. SVGTransformLists are only animatable
via <animateTransform>, not via <animate> directly. Still we can handle it in the
same framework as all other types used for <animate>, as we also need proper animVal
support for <animateTransform>.

This patch removes the special <animateTransform> implementation, and lets
SVGAnimateTransformElement inherit from SVGAnimateElement, just like its done
for SVGAnimateColorElement & SVGSetElement.

All existing code (calculateFromAndToValues/FromAndByValues/etc..) are moved from
SVGAnimateTransform right into the SVGAnimatedTransformListAnimator.

This doesn't change <animateTransform> behavior, it just simplies the code
and enables animVal support for SVGTransformLists - all covered by existing tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):

  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
(WebCore::SVGAnimateTransformElement::hasValidAttributeType):
(WebCore::SVGAnimateTransformElement::parseAttribute):

  • svg/SVGAnimateTransformElement.h:

(WebCore::SVGAnimateTransformElement::transformType):
(SVGAnimateTransformElement):

  • svg/SVGAnimatedTransformList.cpp: Added.

(WebCore):
(WebCore::SVGAnimatedTransformListAnimator::SVGAnimatedTransformListAnimator):
(WebCore::SVGAnimatedTransformListAnimator::constructFromString):
(WebCore::SVGAnimatedTransformListAnimator::constructFromCopy):
(WebCore::SVGAnimatedTransformListAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedTransformListAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedTransformListAnimator::calculateDistance):

  • svg/SVGAnimatedTransformList.h:

(WebCore):
(SVGAnimatedTransformListAnimator):
(WebCore::SVGAnimatedTransformListAnimator::~SVGAnimatedTransformListAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createTransformList):
(WebCore):
(WebCore::SVGAnimatedType::transformList):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):

  • svg/SVGAnimatedType.h:

(WebCore):
(SVGAnimatedType):

  • svg/SVGAnimatorFactory.h:

(WebCore::SVGAnimatorFactory::create):

  • svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::parseAttribute):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::parseAttribute):

  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::parseAttribute):

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::parseAttribute):

  • svg/SVGTransform.cpp:

(WebCore::SVGTransform::transformTypePrefixForParsing):
(WebCore):
(WebCore::SVGTransform::valueAsString):

  • svg/SVGTransform.h:

(SVGTransform):

  • svg/SVGTransformList.cpp:

(WebCore::SVGTransformList::parse):
(WebCore):

  • svg/SVGTransformList.h:

(SVGTransformList):

  • svg/SVGTransformable.cpp:

(WebCore::SVGTransformable::parseTransformType):

  • svg/SVGTransformable.h:

(WebCore):

  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::setTransform):

LayoutTests:

Rebaseline tests after enabling animVal support SVGAnimateTransformElement/SVGTransformList.

  • svg/animations/animate-gradient-transform-expected.txt:
  • svg/animations/animateTransform-pattern-transform-expected.txt:
  • svg/animations/script-tests/animate-gradient-transform.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animateTransform-pattern-transform.js:

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

5:50 AM Changeset in webkit [110837] by kov@webkit.org
  • 2 edits in trunk/Tools

sheriffbot should also be addressable with a comma in addition to colon
​https://bugs.webkit.org/show_bug.cgi?id=81101

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/net/irc/ircbot.py:

(IRCBot.on_pubmsg):

5:06 AM Changeset in webkit [110836] by ahf@0x90.dk
  • 2 edits in trunk/Tools

[Qt] MiniBrowser scroll indicators should not scroll out of view ​https://bugs.webkit.org/show_bug.cgi?id=81131

Reviewed by Kenneth Rohde Christiansen.

  • MiniBrowser/qt/qml/ScrollIndicator.qml:
5:04 AM FeatureFlags edited by tkent@chromium.org
(diff)
4:59 AM FeatureFlags edited by tkent@chromium.org
(diff)
3:00 AM Changeset in webkit [110835] by Nikolas Zimmermann
  • 29 edits in trunk

Enable animVal support for SVGLengthList
​https://bugs.webkit.org/show_bug.cgi?id=80750

Reviewed by Zoltan Herczeg.

Source/WebCore:

Introduce animVal support for generic SVGList types. This aligns SVGListProperty with SVGProperty
in terms of animVal/baseVal support. Use this to turn on animVal support for SVGLengthList.

Extend all existing SVGLengthList tests to correctly differentiate between baseVal/animVal.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateAnimatedValue):

  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::resetToBaseValue):
(WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
(WebCore::SVGAnimateTransformElement::applyResultsToTarget):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::constructFromCopy):
(WebCore):

  • svg/SVGAnimatedLengthList.h:

(WebCore):
(SVGAnimatedLengthListAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):

  • svg/SVGAnimatedType.h:
  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::applyAnimatedValue):

  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(SVGAnimatedListPropertyTearOff):
(WebCore::SVGAnimatedListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedListPropertyTearOff::animVal):
(WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList):
(WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers):
(WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedListPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded):
(WebCore::SVGAnimatedListPropertyTearOff::animationValueWillChange):
(WebCore::SVGAnimatedListPropertyTearOff::animationValueDidChange):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal):

  • svg/properties/SVGAnimatedProperty.h:

(WebCore::SVGAnimatedProperty::isAnimating):
(SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::animationValueWillChange):
(WebCore::SVGAnimatedProperty::animationValueDidChange):
(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::SVGAnimatedProperty):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(SVGAnimatedPropertyTearOff):
(WebCore::SVGAnimatedPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPropertyTearOff::animVal):
(WebCore::SVGAnimatedPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPropertyTearOff::animationValueWillChange):
(WebCore::SVGAnimatedPropertyTearOff::animationValueDidChange):
(WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff):

  • svg/properties/SVGAnimatedTransformListPropertyTearOff.h:

(WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedTransformListPropertyTearOff::animVal):

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::detachListWrappers):
(SVGListProperty):
(WebCore::SVGListProperty::setValuesAndWrappers):
(WebCore::SVGListProperty::clearValues):
(WebCore::SVGListProperty::clearValuesAndWrappers):
(WebCore::SVGListProperty::numberOfItems):
(WebCore::SVGListProperty::initializeValues):
(WebCore::SVGListProperty::initializeValuesAndWrappers):
(WebCore::SVGListProperty::canGetItem):
(WebCore::SVGListProperty::getItemValues):
(WebCore::SVGListProperty::getItemValuesAndWrappers):
(WebCore::SVGListProperty::insertItemBeforeValues):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::canReplaceItem):
(WebCore::SVGListProperty::replaceItemValues):
(WebCore::SVGListProperty::replaceItemValuesAndWrappers):
(WebCore::SVGListProperty::canRemoveItem):
(WebCore::SVGListProperty::removeItemValues):
(WebCore::SVGListProperty::removeItemValuesAndWrappers):
(WebCore::SVGListProperty::appendItemValues):
(WebCore::SVGListProperty::appendItemValuesAndWrappers):
(WebCore::SVGListProperty::values):
(WebCore::SVGListProperty::wrappers):
(WebCore::SVGListProperty::SVGListProperty):

  • svg/properties/SVGListPropertyTearOff.h:

(SVGListPropertyTearOff):
(WebCore::SVGListPropertyTearOff::create):
(WebCore::SVGListPropertyTearOff::removeItemFromList):
(WebCore::SVGListPropertyTearOff::clear):
(WebCore::SVGListPropertyTearOff::initialize):
(WebCore::SVGListPropertyTearOff::insertItemBefore):
(WebCore::SVGListPropertyTearOff::replaceItem):
(WebCore::SVGListPropertyTearOff::appendItem):
(WebCore::SVGListPropertyTearOff::SVGListPropertyTearOff):
(WebCore::SVGListPropertyTearOff::commitChange):

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::clear):
(WebCore::SVGPathSegListPropertyTearOff::getItem):
(WebCore::SVGPathSegListPropertyTearOff::removeItem):

  • svg/properties/SVGPathSegListPropertyTearOff.h:

(WebCore::SVGPathSegListPropertyTearOff::create):
(WebCore::SVGPathSegListPropertyTearOff::removeItemFromList):
(SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::initialize):
(WebCore::SVGPathSegListPropertyTearOff::insertItemBefore):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore::SVGPathSegListPropertyTearOff::appendItem):
(WebCore::SVGPathSegListPropertyTearOff::SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::commitChange):

  • svg/properties/SVGPropertyInfo.h:
  • svg/properties/SVGStaticListPropertyTearOff.h:

(SVGStaticListPropertyTearOff):
(WebCore::SVGStaticListPropertyTearOff::clear):
(WebCore::SVGStaticListPropertyTearOff::initialize):
(WebCore::SVGStaticListPropertyTearOff::getItem):
(WebCore::SVGStaticListPropertyTearOff::insertItemBefore):
(WebCore::SVGStaticListPropertyTearOff::replaceItem):
(WebCore::SVGStaticListPropertyTearOff::removeItem):
(WebCore::SVGStaticListPropertyTearOff::appendItem):
(WebCore::SVGStaticListPropertyTearOff::SVGStaticListPropertyTearOff):
(WebCore::SVGStaticListPropertyTearOff::commitChange):

  • svg/properties/SVGTransformListPropertyTearOff.h:

(WebCore::SVGTransformListPropertyTearOff::create):
(WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
(WebCore::SVGTransformListPropertyTearOff::consolidate):
(WebCore::SVGTransformListPropertyTearOff::SVGTransformListPropertyTearOff):

LayoutTests:

Update test expectations after turning on animVal support for SVGLengthList.

  • svg/animations/script-tests/svglengthlist-animation-1.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svglengthlist-animation-2.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svglengthlist-animation-3.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svglengthlist-animation-4.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svglengthlist-animation-5.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/svglengthlist-animation-1-expected.txt:
  • svg/animations/svglengthlist-animation-2-expected.txt:
  • svg/animations/svglengthlist-animation-3-expected.txt:
  • svg/animations/svglengthlist-animation-4-expected.txt:
  • svg/animations/svglengthlist-animation-5-expected.txt:
2:08 AM Changeset in webkit [110834] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[WK2] WebPageProxy::activeURL should return unreachableURL() when it's not empty
​https://bugs.webkit.org/show_bug.cgi?id=75465

Reviewed by Philippe Normand.

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::replaceContent): Return the main frame
unreachableURL if it's not empty.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::activeURL):

1:57 AM Changeset in webkit [110833] by alexis.menard@openbossa.org
  • 1 edit
    2 adds in trunk/PerformanceTests

Add a new perf test to benchmark setting and reading CSS properties from JS.
​https://bugs.webkit.org/show_bug.cgi?id=81155

Reviewed by Ryosuke Niwa.

This benchmark read and set CSS properties from JS. It contains a list
of common CSS properties.

  • CSS/CSSPropertySetterGetter.html: Added.
1:04 AM Changeset in webkit [110832] by morrita@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new fast/css test.

Patch by Philippe Normand <​pnormand@igalia.com> on 2012-03-15

  • platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt: Added.
12:44 AM Changeset in webkit [110831] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, GTK baselines for new fast/css test.

  • platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt: Added.
12:30 AM Changeset in webkit [110830] by morrita@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed expectations update.

  • platform/chromium-linux/compositing/culling/filter-occlusion-blur-expected.png: Added.
  • platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
12:04 AM Changeset in webkit [110829] by morrita@google.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed expectations update.

  • platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.txt: Removed.

Mar 14, 2012:

11:32 PM Changeset in webkit [110828] by Chris Fleizach
  • 15 edits
    2 adds in trunk

Source/WebCore: AXDescription for HTML5 footer
​https://bugs.webkit.org/show_bug.cgi?id=78967

Return a unique role description for the footer element.

Reviewed by Beth Dakin.

Test: platform/mac/accessibility/footer-roledescription.html

  • English.lproj/Localizable.strings:+
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

  • platform/LocalizedStrings.cpp:

(WebCore::AXFooterRoleDescriptionText):
(WebCore):

  • platform/LocalizedStrings.h:

(WebCore):

  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

(WebCore::AXFooterRoleDescriptionText):
(WebCore):

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::AXFooterRoleDescriptionText):
(WebCore):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::AXFooterRoleDescriptionText):
(WebCore):

Source/WebKit/chromium: AXDescription for HTML5 footer and ARIA role contentinfo incorrect
​https://bugs.webkit.org/show_bug.cgi?id=78967

Reviewed by Beth Dakin.

  • src/LocalizedStrings.cpp:

LayoutTests: AXDescription for HTML5 footer and ARIA role contentinfo incorrect
​https://bugs.webkit.org/show_bug.cgi?id=78967

Reviewed by Beth Dakin.

  • platform/mac/accessibility/footer-roledescription-expected.txt: Added.
  • platform/mac/accessibility/footer-roledescription.html: Added.
11:31 PM Changeset in webkit [110827] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed expectation update for Chrome-Lion.

  • platform/chromium/test_expectations.txt:
11:22 PM FeatureFlags edited by tkent@chromium.org
(diff)
11:19 PM Changeset in webkit [110826] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/81193> Ensure libWebCoreTestSupport.dylib's library identifier is set appropriately for all configurations.

Reviewed by Dan Bernstein.

  • Configurations/WebCoreTestSupport.xcconfig: Switch to setting DYLIB_INSTALL_NAME_BASE

rather than LD_DYLIB_INSTALL_NAME. The latter is derived from the former. Ensure that
DYLIB_INSTALL_NAME_BASE is also set for the Production configuration.

11:01 PM Changeset in webkit [110825] by Chris Fleizach
  • 6 edits in trunk

AXDescription for ARIA role contentinfo incorrect
​https://bugs.webkit.org/show_bug.cgi?id=78967

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/aria-grouping-roles.html

  • English.lproj/Localizable.strings:
  • platform/LocalizedStrings.cpp:

(WebCore::AXARIAContentGroupText):

LayoutTests:

  • platform/mac/accessibility/aria-grouping-roles-expected.txt:
  • platform/mac/accessibility/aria-grouping-roles.html:
10:43 PM FeatureFlags edited by tkent@chromium.org
(diff)
10:31 PM FeatureFlags edited by tkent@chromium.org
Move PURGEABLE_MEMORY (diff)
10:19 PM Changeset in webkit [110824] by morrita@google.com
  • 1 edit
    1 move
    2 adds
    1 delete in trunk/LayoutTests

Unreviewed expectation update.

  • platform/chromium-win-xp/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Renamed from LayoutTests/platform/chromium-win/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt.
  • platform/win/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Removed.
10:12 PM Changeset in webkit [110823] by Chris Fleizach
  • 14 edits
    2 adds in trunk

AX: ARIA tables need to support selected rows attribute/select rows changed notification
​https://bugs.webkit.org/show_bug.cgi?id=79821

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/selected-rows-table.html

  • accessibility/AccessibilityARIAGrid.h:

(WebCore::AccessibilityARIAGrid::isMultiSelectable):
(AccessibilityARIAGrid):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaSelectedRows):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::observableObject):
(WebCore):

  • accessibility/AccessibilityTableRow.h:

(AccessibilityTableRow):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

Tools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(rowAtIndexCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:

(AccessibilityUIElement::rowAtIndex):

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::rowAtIndex):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::rowAtIndex):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::rowAtIndex):

LayoutTests:

  • platform/mac/accessibility/selected-rows-table-expected.txt: Added.
  • platform/mac/accessibility/selected-rows-table.html: Added.
10:12 PM FeatureFlags edited by tkent@chromium.org
(diff)
10:10 PM Changeset in webkit [110822] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Avoid StringImpl::getData16SlowCase() when sorting array
​https://bugs.webkit.org/show_bug.cgi?id=81070

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-03-14
Reviewed by Geoffrey Garen.

The function codePointCompare() is used intensively when sorting strings.
This patch improves its performance by:
-Avoiding character conversion.
-Inlining the function.

This makes Peacekeeper's arrayCombined test 30% faster.

  • wtf/text/StringImpl.cpp:
  • wtf/text/StringImpl.h:

(WTF):
(WTF::codePointCompare):
(WTF::codePointCompare8):
(WTF::codePointCompare16):
(WTF::codePointCompare8To16):

10:07 PM Changeset in webkit [110821] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Platforms without USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) don't need to query the page's displayID
​https://bugs.webkit.org/show_bug.cgi?id=81187

Reviewed by Simon Fraser.

  • dom/Document.cpp:

(WebCore::Document::webkitRequestAnimationFrame):

9:59 PM FeatureFlags edited by tkent@chromium.org
(diff)
9:50 PM FeatureFlags edited by tkent@chromium.org
(diff)
9:44 PM FeatureFlags edited by tkent@chromium.org
Add some comments (diff)
9:39 PM Changeset in webkit [110820] by andersca@apple.com
  • 8 edits in trunk

java/java-and-plugins.html test failing
​https://bugs.webkit.org/show_bug.cgi?id=81188
<rdar://problem/11048657>

Reviewed by Sam Weinig.

Source/WebKit/mac:

When we're marshaling JSObjects that wrap plug-in objects, make sure to check that the
current plug-in instance is the same as the plug-in instance the object came from and don't
pass the unwrapped object ID if that is the case.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::getObjectID):
(WebKit::NetscapePluginInstanceProxy::addValueToArray):
(WebKit::NetscapePluginInstanceProxy::marshalValues):

  • Plugins/Hosted/ProxyInstance.h:

(ProxyInstance):
(WebKit::ProxyInstance::instanceProxy):

Source/WebKit2:

When we're marshaling NPObjects that wrap plug-in objects, make sure to check that the
current plug-in instance is the same as the plug-in instance the object came from and don't
pass the unwrapped object ID if that is the case.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::remoteNPObjectID):
(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):

LayoutTests:

Remove part of this test that tested trying to call a java method on an NPObject; on Snow Leopard
and newer the Java plug-in is also a NPAPI plug-in so the two removed tests would fail.

  • java/java-and-plugins-expected.txt:
  • java/java-and-plugins.html:
9:35 PM FeatureFlags edited by tkent@chromium.org
More JSC flags (diff)
9:28 PM FeatureFlags edited by tkent@chromium.org
categorize JSC (diff)
9:18 PM Changeset in webkit [110819] by Chris Fleizach
  • 6 edits in trunk/Source/WebCore

AX: embedded attachments do not report their parents correctly
​https://bugs.webkit.org/show_bug.cgi?id=80132

When a WebHTMLView has embedded attachments in it, the AXParent of those attachments is wrong.
It usually points to the AXScrollView of the web area. That's because there has been no way for WebCore to
communicate that this attachment view should actually make believe that it's parent is within the WebCore AX tree.

We can fix that by overriding the AXParent in overriden attributes for items that are attachments.

Reviewed by Beth Dakin.

Not able to construct a layout test because the problem only manifests itself when an AX client connects to WebKit
through the IPC mechanism.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::detachFromParent):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
(WebCore::AccessibilityObject::overrideAttachmentParent):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::updateAttachmentViewParents):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::overrideAttachmentParent):

9:11 PM FeatureFlags created by tkent@chromium.org
Just listing
8:58 PM Changeset in webkit [110818] by fpizlo@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Fix for possible problems compiling with old versions of gcc
<rdar://problem/11043680>

Rubber stamped by Mark Rowe.

  • Configurations/Base.xcconfig:
8:57 PM WikiStart edited by tkent@chromium.org
(diff)
8:51 PM Changeset in webkit [110817] by rniwa@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Improve ContainerNode's collectNodes() performance
​https://bugs.webkit.org/show_bug.cgi?id=80706

Reviewed by Antti Koivisto.

Bump up the size of stack allocated buffer from 1 to 11. According to the rough study I conducted,
this would cover 99.5% of all node collection.

Note: the actual code change was made in r110797 but I somehow mangled my patches.

  • dom/ContainerNode.cpp:

(WebCore):

8:43 PM Changeset in webkit [110816] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Cleanup semicolons in IDLs
​https://bugs.webkit.org/show_bug.cgi?id=81129

Patch by Seo Sanghyeon <​sh4.seo@samsung.com> on 2012-03-14
Reviewed by Kentaro Hara.

No tests. No change in behavior.

  • svg/SVGAnimateColorElement.idl:
  • svg/SVGAnimateElement.idl:
  • svg/SVGAnimateTransformElement.idl:
  • svg/SVGAnimatedRect.idl:
8:29 PM Changeset in webkit [110815] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Mac rebaseline after r110667.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
8:11 PM Changeset in webkit [110814] by jamesr@google.com
  • 7 edits
    8 adds in trunk/LayoutTests

[chromium] More compositing baseline updates. Unreviewed.

  • platform/chromium-mac-snowleopard/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-size-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/chromium-mac/compositing/culling/filter-occlusion-blur-expected.png:
  • platform/chromium-mac/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/chromium-mac/compositing/overflow/ancestor-overflow-expected.png:
  • platform/chromium-mac/compositing/repaint/opacity-between-absolute-expected.png:
  • platform/chromium-win/compositing/culling/filter-occlusion-blur-expected.png:
  • platform/chromium-win/compositing/culling/filter-occlusion-blur-large-expected.png:
8:08 PM Changeset in webkit [110813] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Mac Intel WebKit2 Release Tests] canvas/philip/tests/2d.text.draw.fontface.notinpage.html
failing since r83550
​https://bugs.webkit.org/show_bug.cgi?id=58332

Add expected failing results to get the bots green.

  • platform/mac-wk2/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt: Added.
8:08 PM Changeset in webkit [110812] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline some mac canvas philip expected failing results to get the bots green.

  • platform/mac/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
8:08 PM Changeset in webkit [110811] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

canvas/philip/tests/2d.gradient.interpolate.colouralpha failing on Lion Intel Debug (WK1 and WK2)
​https://bugs.webkit.org/show_bug.cgi?id=81185

Land some expected failing results to get the bots green.

  • platform/mac/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Added.
8:06 PM Changeset in webkit [110810] by hayato@chromium.org
  • 5 edits in trunk

Make ShadowRoot.activeElement return null if it does not contain a focused element.
​https://bugs.webkit.org/show_bug.cgi?id=81097

Reviewed by Dimitri Glazkov.

Source/WebCore:

  • dom/TreeScope.cpp:

(WebCore::TreeScope::activeElement):

LayoutTests:

  • fast/dom/shadow/shadow-root-activeElement-expected.txt:
  • fast/dom/shadow/shadow-root-activeElement.html:
7:49 PM Changeset in webkit [110809] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Remove nodesFromRect tests from the skip list
​https://bugs.webkit.org/show_bug.cgi?id=81116

Support for internals.nodesFromRect was recently added for the EFL
port. These tests are now fine.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-03-14
Reviewed by Kenneth Rohde Christiansen.

  • platform/efl/Skipped:
7:12 PM Changeset in webkit [110808] by commit-queue@webkit.org
  • 23 edits
    1 add
    3 deletes in trunk

Allow per-script font settings to be specified in layout tests
​https://bugs.webkit.org/show_bug.cgi?id=78184

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-03-14
Reviewed by Hajime Morita.

This adds per-script font settings to InternalSettings, so it can be used in layout tests instead of
the per-script font settings support in DumpRenderTree overridePreference, which has only been implemented
for Chromium so far.

.:

  • Source/autotools/symbols.filter: Added symbols.

Source/WebCore:

Test: changed fast/text/international/locale-sensitive-fonts.html to use InternalSettings
instead of overridePreference.

  • WebCore.exp.in: Added symbols.
  • platform/text/LocaleToScriptMapping.h: Added scriptNameToCode used by InternalSettings.

(WebCore):

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::scriptNameToCode):
(WebCore::localeToScriptCodeForFontSelection):

  • platform/text/LocaleToScriptMappingICU.cpp:

(WebCore::scriptNameToCode):
(WebCore):

  • testing/InternalSettings.cpp: Added per-script font settings.

(WebCore):
(WebCore::setFontFamily):
(WebCore::InternalSettings::setStandardFontFamily):
(WebCore::InternalSettings::setSerifFontFamily):
(WebCore::InternalSettings::setSansSerifFontFamily):
(WebCore::InternalSettings::setFixedFontFamily):
(WebCore::InternalSettings::setCursiveFontFamily):
(WebCore::InternalSettings::setFantasyFontFamily):
(WebCore::InternalSettings::setPictographFontFamily):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

  • win/WebKit2.def: Added symbols.
  • win/WebKit2CFLite.def: Added symbols.

LayoutTests:

  • fast/text/international/locale-sensitive-fonts-expected.html: Added. Changed test to a reftest.
  • fast/text/international/locale-sensitive-fonts.html: Changed to use InternalSettings.
  • platform/chromium-win/fast/text/international/locale-sensitive-fonts-expected.png: Removed.
  • platform/chromium/fast/text/international/locale-sensitive-fonts-expected.png: Removed.
  • platform/chromium/fast/text/international/locale-sensitive-fonts-expected.txt: Removed.
  • platform/efl/Skipped: Removed locale-sensitive-fonts.html since it no longer relies on overridePreference.
  • platform/gtk-wk2/Skipped: Ditto.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
7:09 PM Changeset in webkit [110807] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove obsolete constructors of CSSPrimitiveValue class.
​https://bugs.webkit.org/show_bug.cgi?id=80971

Remove constructors of CSSPrimitiveValue that can't be
reached.

Patch by Kwonjin Jeong <​gram@company100.net> on 2012-03-14
Reviewed by Andreas Kling.

  • css/CSSPrimitiveValueMappings.h:
6:48 PM Changeset in webkit [110806] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make sure WebPage and BackingStore don't crash without a Window
​https://bugs.webkit.org/show_bug.cgi?id=81099

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-03-14
Reviewed by Rob Buis.

Also rename the "compositing/blitting to main window" variables to
instead refer to OpenGL compositing. The code paths it triggers are
related to the BackingStore using OpenGL compositing, and can be useful
even when there's no window.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::isOpenGLCompositing):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::copyPreviousContentsToBackSurfaceOfWindow):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
(BlackBerry::WebKit::BackingStorePrivate::blendCompositingSurface):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
(BlackBerry::WebKit::BackingStorePrivate::checkerWindow):
(BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
(BlackBerry::WebKit::BackingStorePrivate::clearWindow):
(BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
(BlackBerry::WebKit::BackingStorePrivate::surfaceSize):
(BlackBerry::WebKit::BackingStorePrivate::buffer):

  • Api/BackingStore_p.h:
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didPluginEnterFullScreen):
(BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
(BlackBerry::WebKit::WebPagePrivate::drawSubLayers):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::windowRect):
(WebCore::ChromeClientBlackBerry::screenToWindow):
(WebCore::ChromeClientBlackBerry::windowToScreen):

  • WebKitSupport/GLES2Context.cpp:

(BlackBerry::WebKit::GLES2Context::GLES2Context):

  • WebKitSupport/TouchEventHandler.h:
  • WebKitSupport/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::setBackingStoreUsesOpenGL):
(BlackBerry::WebKit::WebPageCompositor::drawLayers):

  • WebKitSupport/WebPageCompositor.h:
6:30 PM Changeset in webkit [110805] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix memory allocation failed by fastmalloc
​https://bugs.webkit.org/show_bug.cgi?id=79614

Patch by Hojong Han <​hojong.han@samsung.com> on 2012-03-14
Reviewed by Geoffrey Garen.

Memory allocation failed even if the heap grows successfully.
It is wrong to get the span only from the large list after the heap grows,
because new span could be added in the normal list.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::New):

6:28 PM Changeset in webkit [110804] by msaboff@apple.com
  • 4 edits in trunk/Source

REGRESSION(r110383): ASSERTION failures in JSCell::finishCreation causing multiple tests to "crash" on the Lion Intel Debug Bots
​https://bugs.webkit.org/show_bug.cgi?id=80993

Reviewed by Mark Rowe.

Moved $(BUILT_PRODUCTS_DIR)/usr/local/include to the front of HEADER_SEARCH_PATH
to fix builds given the wtf move.

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig:

Source/WebKit2:

  • Configurations/BaseTarget.xcconfig:
6:20 PM Changeset in webkit [110803] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop shadowing the argument to drawRect: with a local variable.

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView drawRect:]):

6:18 PM Changeset in webkit [110802] by igor.o@sisa.samsung.com
  • 3 edits in trunk/Source/WebCore

Split the extra logic out of RenderBlock::updateFirstLetter
​https://bugs.webkit.org/show_bug.cgi?id=80772

Reviewed by Julien Chaffraix.

No change in behavior expected.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
(WebCore::RenderBlock::updateFirstLetter):
(WebCore):

  • rendering/RenderBlock.h:

(RenderBlock):

6:07 PM Changeset in webkit [110801] by Alexandru Chiculita
  • 4 edits
    11 adds
    1 delete in trunk/PerformanceTests

Layout/floats.html should be runnable by run-perf-tests
​https://bugs.webkit.org/show_bug.cgi?id=77051

Reviewed by Ryosuke Niwa.

I've split Layout/floats.html into multiple tests for each button in the original manual test.
Some tests take longer to run and I've changed the number of iterations, so that each tests finishes under 30s per run.

  • DOM/resources/dom-perf.js:
  • Layout/floats.html: Removed.
  • Layout/floats_100_100.html: Added.
  • Layout/floats_100_100_nested.html: Added.
  • Layout/floats_20_100.html: Added.
  • Layout/floats_20_100_nested.html: Added.
  • Layout/floats_2_100.html: Added.
  • Layout/floats_2_100_nested.html: Added.
  • Layout/floats_50_100.html: Added.
  • Layout/floats_50_100_nested.html: Added.
  • Layout/resources/floats.css: Added.

(.container):
(.float):
(.big):
(.float-end):

  • Layout/resources/floats.js: Added.

(.):

  • Skipped:
  • resources/runner.js:

(PerfTestRunner.resetRandomSeed):
(PerfTestRunner.random):
(Math.random):

Moved the Math.random to runner.js to be used by all tests.
Added resetRandomSeed to bring the randomizer back to initial seed.
It is useful to get the same results at every run and minimize the
differences between runs.

5:44 PM Changeset in webkit [110800] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • html/track/TextTrackList.cpp:
5:34 PM Changeset in webkit [110799] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

fullscreen/video-controls-drag.html failing on Mac
​https://bugs.webkit.org/show_bug.cgi?id=81176

Land expected failing results to get the bots green.

  • platform/mac/fullscreen/video-controls-drag-expected.txt: Added.
5:26 PM Changeset in webkit [110798] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix.

  • dom/DynamicNodeList.h:

(DynamicSubtreeNodeList):

5:10 PM Changeset in webkit [110797] by rniwa@webkit.org
  • 10 edits in trunk/Source/WebCore

(register|unregister)DynamicSubtreeNodeList should be called only for labels and regions node lists
​https://bugs.webkit.org/show_bug.cgi?id=80900

Reviewed by Antti Koivisto.

Cleaned up invalidation code for dynamic node lists. It seems like the existing code was utterly confused
about the lifetime of node lists and caches within them. First, register/unregsiterDynamicSubtreeNodeList
are called for all dynamic node lists even though it's only useful for labels and region node lists since
it's a mechanism to allow node lists to be invalidated at a node to which the node list doesn't belong.

Second, some node lists had dedicated member functions on Node to explicitly invalidate caches in
parsedAttribute. However, this is redundant because invalidateNodeListsCacheAfterAttributeChanged should be
able to invalidate caches when the attribute value changes. This patch gets rid of the last instance of such
function in HTMLLabelElement.

And finally, this patch restricts the callers of DynamicSubtreeNodeList::invalidateCache to be member
functions of NodeListsNodeData (now friends of DynamicSubtreeNodeList) to allow futher refactoring.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList): Don't register the node list since it's only
useful for labels and region node lists.
(WebCore::DynamicSubtreeNodeList::~DynamicSubtreeNodeList): Ditto.

  • dom/DynamicNodeList.h:

(DynamicSubtreeNodeList):

  • dom/Node.cpp:

(WebCore):
(WebCore::Node::registerDynamicSubtreeNodeList): The comment about now we have to invalidate caches
when there had no caches is incorrect because registerDynamicSubtreeNodeList is called when a node list
is initially created. Also, if the tree scope didn't have any caches, then this is the first node list
to be added to the list, so there's no point in calling InvalidateCaches (no-op).
(WebCore::Node::unregisterDynamicSubtreeNodeList):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Take care of "for" content attribute.
Also remove the redundant call to removeNodeListCacheIfPossible since we only invalidates node lists
and never remove entries from NodeListsNodeData in this function.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): The call to removeNodeListCacheIfPossible
is also redundant here. Also removed the invalidation of m_listsWithCaches since it's already done in
invalidateCaches via invalidateCachesThatDependOnAttributes.
(WebCore::NodeListsNodeData::invalidateCaches): Removed the invalidation of m_labelsNodeListCache. It's
done in invalidateCachesThatDependOnAttributes.
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes): Invalidate
m_listsInvalidatedAtDocument, which is renamed from m_listsWithCaches.
(WebCore::NodeListsNodeData::isEmpty):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:

(NodeListsNodeData):

  • html/HTMLLabelElement.cpp:

(WebCore): Removed parseAttribute since the invalidation labels node list is now done by
invalidateNodeListsCacheAfterAttributeChanged and invalidateNodeListsCacheAfterChildrenChanged.

  • html/HTMLLabelElement.h:

(HTMLLabelElement):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::LabelsNodeList):
(WebCore::LabelsNodeList::~LabelsNodeList):

5:10 PM Changeset in webkit [110796] by abarth@webkit.org
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

More fun with repainting-after-animation-element-removal. These
results differ by only one pixel.

  • platform/chromium-linux/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/chromium-mac-leopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Removed.
5:10 PM Changeset in webkit [110795] by timothy_horton@apple.com
  • 3 edits in trunk/Tools

NRWT should respect --additional-platform-directory's Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=81172

Reviewed by Timothy Hatcher.

Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
from said path are already used, but the Skipped file is ignored.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._skipped_file_search_paths):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_skipped_file_search_paths):

5:08 PM Changeset in webkit [110794] by jamesr@google.com
  • 4 edits in trunk/LayoutTests

[chromium] Fix a few more compositing baselines. Unreviewed.

  • platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png:
  • platform/chromium-win/compositing/culling/filter-occlusion-blur-expected.png:
  • platform/chromium-win/compositing/culling/filter-occlusion-blur-large-expected.png:
5:07 PM Changeset in webkit [110793] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add some chromium-mac-leopard overrides for tests I rebaselined earlier.

  • platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/filter-empty-element-crash-expected.png: Added.
5:06 PM Changeset in webkit [110792] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Run cacheFlush page by page to assure of flushing all the requested ranges
​https://bugs.webkit.org/show_bug.cgi?id=77712

Patch by Hojong Han <​hojong.han@samsung.com> on 2012-03-14
Reviewed by Geoffrey Garen.

Current MetaAllocator concept, always coalesces adjacent free spaces,
doesn't meet memory management of Linux kernel.
In a certain case Linux kernel doesn't regard contiguous virtual memory areas as one but two.
Therefore cacheFlush page by page guarantees a flush-requested range.

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

5:02 PM Changeset in webkit [110791] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add missing image baselines for new test added in <​http://trac.webkit.org/changeset/110769>.

  • platform/chromium-linux/fast/css/pseudo-first-line-border-width-expected.png: Added.
  • platform/chromium-mac/fast/css/pseudo-first-line-border-width-expected.png: Added.
  • platform/chromium-win/fast/css/pseudo-first-line-border-width-expected.png: Added.
  • platform/chromium/fast/css/pseudo-first-line-border-width-expected.txt: Added.
5:02 PM Changeset in webkit [110790] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r110565.
​http://trac.webkit.org/changeset/110565
​https://bugs.webkit.org/show_bug.cgi?id=81173

chromium deps are now far enough along that the original cl
should work (Requested by thakis on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-14

  • WebCore.gyp/mac/adjust_visibility.sh:
5:01 PM Changeset in webkit [110789] by ojan@chromium.org
  • 5 edits in trunk/Tools

Unreviewed, rolling out r110783.
​http://trac.webkit.org/changeset/110783
​https://bugs.webkit.org/show_bug.cgi?id=81054

Caused existing test expectation lines to expand to one for
each test configuration.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.has_warnings):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_macro_overrides):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._save_baseline):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_tests_to_update):

4:57 PM Changeset in webkit [110788] by abarth@webkit.org
  • 43 edits
    2 adds in trunk

Unreviewed, rolling out r110641.
​http://trac.webkit.org/changeset/110641
​https://bugs.webkit.org/show_bug.cgi?id=81170

Causes an ASAN failure (Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-14

Source/WebCore:

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.

(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):
(WebCore):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.

(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):
(WebCore):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • css/CSSStyleSheet.idl:
  • css/StyleSheet.idl:
  • dom/DOMStringMap.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/track/TextTrackList.cpp:
  • html/track/TextTrackList.idl:

LayoutTests:

  • platform/chromium/test_expectations.txt:
4:54 PM Changeset in webkit [110787] by jamesr@google.com
  • 36 edits
    1 move
    23 adds
    6 deletes in trunk/LayoutTests

[chromium] Unreviewed. Update many compositing baselines and expectations now that one major cause of flake is
fixed by r110741.

Filelist trimmed.

4:48 PM Changeset in webkit [110786] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

Update chromium-mac-lion expectations after <​http://trac.webkit.org/changeset/110763>.

  • platform/chromium-mac/media/audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/audio-repaint-expected.txt: Added.
  • platform/chromium-mac/media/controls-layout-direction-expected.png: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Added.
4:41 PM Changeset in webkit [110785] by leviw@chromium.org
  • 6 edits in branches/subpixellayout/Source/WebCore/rendering

Correcting flooredLayoutPoint/Size to not floor on our branch (these preserve precision instead). Rounding image sizes inline with our RenderReplaced strategy. Fixing a pixel snapping bug in RenderListBox. Shuffling code in InlineTextBox for precision.

4:41 PM Changeset in webkit [110784] by jonlee@apple.com
  • 78 edits in trunk

Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
​https://bugs.webkit.org/show_bug.cgi?id=80922
<rdar://problem/11035082>

Reviewed by Jian Li.

You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
new API. Therefore, APIs that are common between the two will have:

#if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)

This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.

Source/WebCore:

  • bindings/scripts/InFilesCompiler.pm: Update the script to handle the "|" flag in a conditional.

(preferredConditional):
(conditionalStringFromAttributeValue):
(generateInterfacesHeader):
(generateHeadersHeader):

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • WebCore.exp.in:
  • bindings/cpp/WebDOMEventTarget.cpp:

(toWebKit):

  • bindings/js/JSDesktopNotificationsCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • dom/EventTargetFactory.in:
  • notifications/Notification.cpp:
  • notifications/Notification.h:
  • notifications/Notification.idl:
  • notifications/NotificationCenter.cpp:
  • notifications/NotificationCenter.h:
  • notifications/NotificationCenter.idl:
  • notifications/NotificationContents.h:
  • notifications/NotificationController.cpp:
  • notifications/NotificationController.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:
  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):
(WebCore::Frame::transferChildFrameToNewDocument):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::~WorkerContext):
(WebCore):

  • workers/WorkerContext.h:

(WorkerContext):

  • workers/WorkerContext.idl:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::WorkerThread):

  • workers/WorkerThread.h:

(WorkerThread):

Source/WebKit/blackberry:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/NotificationPresenterImpl.cpp:
  • WebCoreSupport/NotificationPresenterImpl.h:

Source/WebKit/chromium:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • src/AssertMatchingEnums.cpp:
  • src/NotificationPresenterImpl.cpp:
  • src/NotificationPresenterImpl.h:
  • src/WebNotification.cpp:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableNotifications):
(WebKit::WebRuntimeFeatures::isNotificationsEnabled):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

Source/WebKit/efl:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

  • WebCoreSupport/NotificationPresenterClientEfl.cpp:
  • WebCoreSupport/NotificationPresenterClientEfl.h:

Source/WebKit/mac:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::cancel):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):
(WebNotificationClient::notificationControllerDestroyed):
(WebNotificationClient::requestPermission):
(WebNotificationClient::checkPermission):

  • WebView/WebNotification.mm:

(-[WebNotification title]):
(-[WebNotification body]):
(-[WebNotification replaceID]):
(-[WebNotification origin]):
(-[WebNotification notificationID]):
(-[WebNotification dispatchShowEvent]):
(-[WebNotification dispatchCloseEvent]):
(-[WebNotification dispatchClickEvent]):
(-[WebNotification dispatchErrorEvent]):

  • WebView/WebNotificationInternal.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/qt:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::~QWebPagePrivate):
(QWebPage::setFeaturePermission):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::dumpNotification):
(DumpRenderTreeSupportQt::simulateDesktopNotificationClick):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore):
(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationWrapper::close):
(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationWrapper::iconData):
(WebCore::NotificationWrapper::openerPageUrl):
(WebCore::NotificationWrapper::notificationClicked):
(WebCore::NotificationWrapper::notificationClosed):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(WebCore):

Source/WebKit/win:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::WebChromeClient):

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:

Source/WebKit/wince:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

Source/WebKit2:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):

  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit):
(WebKit::NotificationPermissionRequestManager::startRequest):
(WebKit::NotificationPermissionRequestManager::cancelRequest):
(WebKit::NotificationPermissionRequestManager::permissionLevel):
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit):
(WebKit::WebNotificationManager::initialize):
(WebKit::WebNotificationManager::didUpdateNotificationDecision):
(WebKit::WebNotificationManager::didRemoveNotificationDecisions):
(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):
(WebKit::WebNotificationManager::didShowNotification):
(WebKit::WebNotificationManager::didClickNotification):
(WebKit::WebNotificationManager::didCloseNotifications):

  • WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:
  • WebProcess/WebCoreSupport/WebNotificationClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebProcess):

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::grantDesktopNotificationPermission):
(LayoutTestController::simulateDesktopNotificationClick):

  • DumpRenderTree/chromium/NotificationPresenter.cpp:
  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetTestController):

  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:

(DRTDesktopNotificationPresenter::checkNotificationPermission):

4:36 PM Changeset in webkit [110783] by ojan@chromium.org
  • 5 edits in trunk/Tools

Have webkit-patch rebaseline-test update test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=81054

Reviewed by Dirk Pranke.

This will allow us to use the All Failures tab in garden-o-matic
to rebaseline tests without making test_expectations.txt stale.

It's conservative and only removes lines if the test is
not flaky and fails in a way the rebaseline would fix (e.g.
CRASH/TIMEOUT will not be touched).

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.remove_configuration_from_test):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(RemoveConfigurationsTest):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._is_supported_port):
(RebaselineTest):
(RebaselineTest._update_expectations_file):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file):

4:34 PM Changeset in webkit [110782] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r110744.
​http://trac.webkit.org/changeset/110744
​https://bugs.webkit.org/show_bug.cgi?id=81168

Causes many WebAudio tests to crash in debug (Requested by
abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-14

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::process):

4:29 PM Changeset in webkit [110781] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Move code common to both ProxyAuthentication and Authentication context objects into a base class
​https://bugs.webkit.org/show_bug.cgi?id=80627

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-03-14
Reviewed by Kenneth Rohde Christiansen.

No impact to QML API.

  • UIProcess/qt/QtDialogRunner.cpp:

(BaseAuthenticationContextObject):
(BaseAuthenticationContextObject::BaseAuthenticationContextObject):
(HttpAuthenticationDialogContextObject):
(HttpAuthenticationDialogContextObject::HttpAuthenticationDialogContextObject):
(HttpAuthenticationDialogContextObject::realm):
(ProxyAuthenticationDialogContextObject):
(ProxyAuthenticationDialogContextObject::ProxyAuthenticationDialogContextObject):
(QtDialogRunner::initForAuthentication):

4:27 PM Changeset in webkit [110780] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

With tiled drawing enabled, clicking a link to a PDF causes a cross-fade
​https://bugs.webkit.org/show_bug.cgi?id=79247
<rdar://problem/10910808>

Reviewed by Sam Weinig.

Instead of creating a new CALayer for the WKView when we're in tiled mode, re-use the existing layer that AppKit makes for us.
This way, we won't get any implicit animations when we change layer properties (such as sublayers in this case).

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView wantsUpdateLayer]):
(-[WKView updateLayer]):

4:25 PM Changeset in webkit [110779] by jamesr@google.com
  • 5 edits
    1 add in trunk/LayoutTests

[chromium] Unreviewed. Update a few compositing baselines for tests that were marked flaky.

  • platform/chromium-mac-snowleopard/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-mac/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-mac/compositing/reflections/masked-reflection-on-composited-expected.png:
  • platform/chromium-mac/compositing/reflections/reflection-positioning2-expected.png:
  • platform/chromium-win/compositing/masks/masked-ancestor-expected.png:
4:21 PM Changeset in webkit [110778] by abarth@webkit.org
  • 2 edits
    5 adds
    5 deletes in trunk/LayoutTests

Promote a number of chromium-mac-snowleopard results to chromium-mac.
Also, fix a wrong chromium-mac-leopard expectation. (The new
expectation show the drop shadow, like other platforms.)

  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium-mac-snowleopard/css3/filters/effect-combined-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-opacity-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/filtered-compositing-descendant-expected.png: Removed.
  • platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-opacity-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/filtered-compositing-descendant-expected.png: Added.
4:14 PM Changeset in webkit [110777] by jberlin@webkit.org
  • 2 edits in trunk/Tools

Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
​https://bugs.webkit.org/show_bug.cgi?id=81167

Reviewed by Sam Weinig.

Do not use 0 as a key in a HashMap.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

cacheLayoutTestControllerCallback uses the enum as keys for the callback map.

4:08 PM Changeset in webkit [110776] by beidson@apple.com
  • 5 edits in trunk/Source/WebCore

<rdar://problem/11045584> and ​https://bugs.webkit.org/show_bug.cgi?id=81166 Repro crash in compositing/iframes/page-cache-layer-tree.html

Reviewed by Sam Weinig.

No new tests. (Discovered from and covered by existing test)

ScriptCachedFrameData doesn't need to keep a DOMWindow:

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):

  • bindings/js/ScriptCachedFrameData.h:

(ScriptCachedFrameData):

CachedFrame should grab it off the Frame directly and store it locally:

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • history/CachedFrame.h:

(WebCore::CachedFrameBase::domWindow):
(CachedFrameBase):

4:01 PM Changeset in webkit [110775] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

I've already updated the baselines for this test.

  • platform/chromium/test_expectations.txt:
3:58 PM Changeset in webkit [110774] by abarth@webkit.org
  • 8 edits
    24 adds
    4 deletes in trunk/LayoutTests

Update baselines for a number of svg/repaint tests and for some
tables/mozilla tests. These results all appear to be correct.

  • platform/chromium-linux-x86/tables/mozilla: Removed.
  • platform/chromium-linux/svg/repaint/filter-repaint-expected.png: Added.
  • platform/chromium-linux/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-mac-leopard/svg/repaint/image-href-change-expected.png: Added.
  • platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/chromium-mac-leopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug53690-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug53690-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Added.
  • platform/chromium-mac/svg/repaint/image-href-change-expected.png: Added.
  • platform/chromium-mac/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
  • platform/chromium-mac/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/chromium-mac/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug53690-1-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs: Removed.
  • platform/chromium-win/svg/repaint/filter-repaint-expected.png: Added.
  • platform/chromium-win/svg/repaint/filter-repaint-expected.txt: Added.
  • platform/chromium-win/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/chromium-win/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
  • platform/chromium-win/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug86708-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug178855-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug178855-expected.txt: Added.
  • platform/mac-snowleopard/svg/repaint/image-href-change-expected.png: Removed.
  • platform/mac/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
  • svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Removed.
3:58 PM Changeset in webkit [110773] by jamesr@google.com
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
​https://bugs.webkit.org/show_bug.cgi?id=80523

Reviewed by Darin Fisher.

  • public/WebViewClient.h:

(WebViewClient):
(WebKit::WebViewClient::createGraphicsContext3D):

  • public/platform/WebKitPlatformSupport.h:

(WebKit):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createCompositorGraphicsContext3D):

3:56 PM Changeset in webkit [110772] by tony@chromium.org
  • 6 edits in trunk

fix negative flexing in auto sized columns
​https://bugs.webkit.org/show_bug.cgi?id=80069

Reviewed by Ojan Vafai.

Source/WebCore:

New test cases in css3/flexbox/columns-auto-size.html.

  • rendering/RenderFlexibleBox.cpp:

(WebCore):
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Properly compute this for auto sizing columns. Previously, we would always return 0.
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Drop an unnecessary check against undefined. isSpecified covers this for us.

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/columns-auto-size-expected.txt:
  • css3/flexbox/columns-auto-size.html:
3:44 PM Changeset in webkit [110771] by abarth@webkit.org
  • 5 edits
    7 adds in trunk/LayoutTests

Update baselines for these URL tests. These tests exist to document
differnces in behavior between KURL and GURL.

  • platform/chromium-linux/fast/url/file-http-base-expected.txt: Added.
  • platform/chromium-linux/fast/url/segments-expected.txt:
  • platform/chromium-linux/fast/url/segments-from-data-url-expected.txt:
  • platform/chromium-win/fast/url/file-http-base-expected.txt: Added.
  • platform/chromium-win/fast/url/segments-expected.txt:
  • platform/chromium-win/fast/url/segments-from-data-url-expected.txt:
  • platform/chromium/fast/url/anchor-expected.txt: Added.
  • platform/chromium/fast/url/file-http-base-expected.txt: Added.
  • platform/chromium/fast/url/ipv4-expected.txt: Added.
  • platform/chromium/fast/url/segments-expected.txt: Added.
  • platform/chromium/fast/url/segments-from-data-url-expected.txt: Added.
3:39 PM Changeset in webkit [110770] by abarth@webkit.org
  • 2 edits
    19 adds
    1 delete in trunk/LayoutTests

These baselines all either look very similar to their expectations or
like improvements.

  • platform/chromium-linux/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
  • platform/chromium-mac-leopard/css1/box_properties/acid_test-expected.png: Added.
  • platform/chromium-mac-leopard/css1/font_properties/font_family-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t09-c5526c-display-00-e-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t1503-c522-font-family-00-b-expected.png: Added.
  • platform/chromium-mac-leopard/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
  • platform/chromium-mac-leopard/fast/xsl/mozilla-tests-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css1/box_properties/acid_test-expected.png: Added.
  • platform/chromium-mac-snowleopard/css1/font_properties/font_family-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t09-c5526c-display-00-e-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.png:
  • platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
  • platform/chromium-mac/css1/box_properties/acid_test-expected.png: Added.
  • platform/chromium-mac/css1/font_properties/font_family-expected.png: Added.
  • platform/chromium-mac/css1/text_properties/text_transform-expected.png: Added.
  • platform/chromium-mac/css1/text_properties/text_transform-expected.txt: Added.
  • platform/chromium-mac/css2.1/t09-c5526c-display-00-e-expected.png: Added.
  • platform/chromium-mac/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
  • platform/chromium-win/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
  • platform/chromium-win/fast/xsl/transform-xhr-doc-expected.txt: Removed.
  • platform/chromium/fast/xsl/transform-xhr-doc-expected.txt: Added.
3:24 PM Changeset in webkit [110769] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Incorrect handling of sizes in "em" when first-line changes font size
​https://bugs.webkit.org/show_bug.cgi?id=79526

Patch by Grace Ku <​gracek@codeaurora.org> on 2012-03-14
Reviewed by Eric Seidel.

Source/WebCore:

When a first-line pseudo class changes the font size, the "em" unit is handled incorrectly.
It uses the paragraph's original font size (the size of the rest of the paragraph) rather than
the font-size of the first-line of the paragraph.

This was corrected by checking if the InlineFlowBox was the first line using the existing
InlineFlowBox::isFirstLineStyle() function. The corrected behaviour matches Gecko and Presto.
Trident seems to get it half-wrong in the use case we are testing, painting the correct width for
the border but leaving the wrong amount of space.

The CSS specification doc at the time of this patch specifies that ':first-line' should only support
certain properties, though UAs may choose to apply more properties. Furthermore, the spec does not
define the exact rendering of all cases of ':first-line'. It notes that a more precise definition
may appear in future revisions.

Test: fast/css/pseudo-first-line-border-width.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::borderLogicalLeft):
(WebCore::InlineFlowBox::borderLogicalRight):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::getBorderEdgeInfo):
(WebCore::RenderBoxModelObject::borderObscuresBackgroundEdge):
(WebCore::RenderBoxModelObject::borderObscuresBackground):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

LayoutTests:

Checks that the width of the left-border of the span is the desired 10px
rather than 100px. The expect file is somewhat misleading since the computed
border width is still printed as 100px. The true test is in the position of the
RenderText box beside the left-border.

  • fast/css/pseudo-first-line-border-width.html: Added.
  • fast/css/pseudo-first-line-border-width-expected.txt: Added.
3:17 PM Changeset in webkit [110768] by abarth@webkit.org
  • 5 edits
    1 add in trunk/LayoutTests

Update some compositing baselines. These look correct. They just differ in scrollbars, etc.

  • platform/chromium-mac-leopard/compositing/direct-image-compositing-expected.png:
  • platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png:
  • platform/chromium-mac/compositing/direct-image-compositing-expected.png:
  • platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png: Added.
  • platform/chromium-win/compositing/direct-image-compositing-expected.png:
3:15 PM Changeset in webkit [110767] by Lucas Forschler
  • 4 edits in branches/safari-534.55-branch

Merged r110196.

3:13 PM Changeset in webkit [110766] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.displayInvalidatedRegion

Add a test that uses it to the wk2 Skipped list.

  • platform/wk2/Skipped:
3:06 PM Changeset in webkit [110765] by abarth@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

Add results for transforms/3d/general/background-visibility-layers.html.

  • platform/chromium-mac/transforms/3d: Added.
  • platform/chromium-mac/transforms/3d/general: Added.
  • platform/chromium-mac/transforms/3d/general/background-visibility-layers-expected.png: Added.
  • platform/chromium-win/transforms/3d/general: Added.
  • platform/chromium-win/transforms/3d/general/background-visibility-layers-expected.png: Added.
  • platform/chromium/transforms: Added.
  • platform/chromium/transforms/3d: Added.
  • platform/chromium/transforms/3d/general: Added.
  • platform/chromium/transforms/3d/general/background-visibility-layers-expected.txt: Added.
3:05 PM Changeset in webkit [110764] by Martin Robinson
  • 3 edits in trunk/Source/WebCore

Fix the TextureMapper build for GTK+.

No new tests. This is just a build fix.

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapper.h:
3:05 PM Changeset in webkit [110763] by commit-queue@webkit.org
  • 42 edits
    6 deletes in trunk/LayoutTests

Display attribute for video controls changed from display:block
to display:-webkit-box. Tests need to be rebaselined.

​https://bugs.webkit.org/show_bug.cgi?id=80727

Patch by Victor Carbune <​vcarbune@adobe.com> on 2012-03-14
Reviewed by Eric Carlson.

  • platform/chromium-linux-x86/media/video-empty-source-expected.txt:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.txt:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.txt:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium/media/audio-repaint-expected.txt.
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-layout-direction-expected.png: Added.
  • platform/chromium-mac/media/controls-strict-expected.png: Added.
  • platform/chromium-mac/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/controls-strict-expected.txt.
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.png: Added.
  • platform/chromium-mac/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/controls-without-preload-expected.txt.
  • platform/chromium-mac/media/media-controls-clone-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.txt.
  • platform/chromium-mac/media/video-controls-rendering-expected.png: Added.
  • platform/chromium-mac/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.txt.
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-playing-and-pause-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.png: Added.
  • platform/chromium-mac/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/video-volume-slider-expected.txt.
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win-vista/media/video-empty-source-expected.txt:
  • platform/chromium-win-xp/media/video-empty-source-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-controls-clone-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-playing-and-pause-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/chromium/test_expectations.txt:
3:04 PM Changeset in webkit [110762] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

[GTK] Menulist buttons have separators even when the theme turns them off
​https://bugs.webkit.org/show_bug.cgi?id=80668

Reviewed by Daniel Bates.

No new tests. GTK+ theme differences are notoriously difficult
to test, because consistent results depend on having certain themes
and certain versions of themes installed.

Instead of using the GTK_TYPE_BUTTON and GTK_TYPE_SEPARATOR tags to get the
style context, use GTK_TYPE_COMBO_BOX which should provide more accurate theme settings.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::getComboBoxMetrics): Get metrics from a GTK_TYPE_COMBO_BOX style context.
(WebCore::RenderThemeGtk::paintMenuList): Get separator settings from the GTK_TYPE_COMBO_BOX style context.

3:02 PM Changeset in webkit [110761] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Implement proper sub-pixel support in RenderFileUploadControl
​https://bugs.webkit.org/show_bug.cgi?id=80881

Reviewed by Dimitri Glazkov.

Correcting improper usage of LayoutUnits when interacting with the graphics context
and platform code. Specifically:

  • pixel snapping the clip rect and paint offsets before sending values to the graphics context in paintObject.
  • using on-screen (pixel snapped) values to pass off to platform code to determine the max length of the filename to be drawn.

No new tests. No change in behavior.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::nodeWidth):
(WebCore::RenderFileUploadControl::maxFilenameWidth):
(WebCore::RenderFileUploadControl::paintObject):

2:56 PM Changeset in webkit [110760] by commit-queue@webkit.org
  • 5 edits in trunk

[JSC] Web Inspector: CRASH running $0, $1, etc before they are set
​https://bugs.webkit.org/show_bug.cgi?id=81082

Source/WebCore:

Don't return an invalid JSValue. Check if the ScriptValue
has no value and return undefined in that case.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-03-14
Reviewed by Pavel Feldman.

Updated test: inspector/console/command-line-api.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::inspectedObject):

LayoutTests:

Test for an undefined inspectedObject.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-03-14
Reviewed by Pavel Feldman.

  • inspector/console/command-line-api-expected.txt:
  • inspector/console/command-line-api.html:
2:43 PM Changeset in webkit [110759] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, mark two compositing tests as passing.
​https://bugs.webkit.org/show_bug.cgi?id=75568

  • platform/chromium/test_expectations.txt:
2:43 PM Changeset in webkit [110758] by Lucas Forschler
  • 2 edits in branches/safari-534.55-branch/Source/WebKit2

Merged r107307.

2:42 PM Changeset in webkit [110757] by jamesr@google.com
  • 5 edits in trunk/Source

[chromium] Remove canRecoverFromContextLoss attribute, it's unused
​https://bugs.webkit.org/show_bug.cgi?id=81158

Reviewed by Stephen White.

Source/WebCore:

Canvas accelerated no longer depends on the canRecoverFromContextLoss attribute after r110716.

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::Attributes::Attributes):
(Attributes):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3DImpl::get):

Source/WebKit/chromium:

Deletes the canRecoverFromContextLoss attribute from WebCore::GraphicsContext3D::Attributes. This is still left in
WebGraphicsContext3D::Attributes, since chromium-side code still references it.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::create):

2:40 PM Changeset in webkit [110756] by Lucas Forschler
  • 3 edits in branches/safari-534.55-branch/Source/WebKit2

Merged r107267.

2:35 PM Changeset in webkit [110755] by Lucas Forschler
  • 2 edits in branches/safari-534.55-branch/Source/WebCore

Merged r110480.

2:34 PM Changeset in webkit [110754] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

Opening a URL in a MediaDocument does not propagate MIME type info to media element
​https://bugs.webkit.org/show_bug.cgi?id=81148

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/media-document.html

Pass through the mime type from the DocumentLoader into the <source type=""> attribute of the
generated video element.

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

  • http/tests/media/media-document-expected.txt: Added.
  • http/tests/media/media-document.html: Added.
2:27 PM Changeset in webkit [110753] by senorblanco@chromium.org
  • 7 edits in trunk/Source

[chromium] Fix accelerated Canvas2D with threaded compositing.
​https://bugs.webkit.org/show_bug.cgi?id=80998

Reviewed by James Robinson.

Source/WebCore:

Covered by unit tests Canvas2DLayerChromiumTest and
TreeSynchronizerTest.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore):
Delay creation of the front texture for double-buffering until the
first call to paintContentsIfDirty().

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):
Remove setTextureManager() and setLayerTreeHost(), since their job
has been subsumed by paintContentsIfDirty().

  • platform/graphics/chromium/TreeSynchronizer.cpp:

(WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):
Perform an early-out if the passed-in layer is NULL.

Source/WebKit/chromium:

  • tests/Canvas2DLayerChromiumTest.cpp:

Instantiate a CCLayerTreeHost, so that Canvas2DLayerChromium can
retrieve its texture manager. Also move the test into the unnamed
namespace -- since it's already using WebCore, there's little reason for
it to also be in the namespace.

  • tests/TreeSynchronizerTest.cpp:

(WebKitTests):
(WebKitTests::TEST):
Add a new test for trying to synchronize NULL tree.

2:24 PM Changeset in webkit [110752] by Lucas Forschler
  • 3 edits in branches/safari-534.55-branch/Source/WebCore

Merged r104240.

2:21 PM Changeset in webkit [110751] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Make ARMv7 work again
​https://bugs.webkit.org/show_bug.cgi?id=81157

Reviewed by Geoffrey Garen.

We were trying to use the ARMv7 dataRegister as a scratch register in a scenario
where we the ARMv7MacroAssembler would also try to use dataRegister for its own
nefarious purposes.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::store32):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):

2:20 PM Changeset in webkit [110750] by dgrogan@chromium.org
  • 262 edits in trunk/LayoutTests

IndexedDB layout tests: factor out prefix-handling-code
​https://bugs.webkit.org/show_bug.cgi?id=80664

This makes our tests vendor neutral so that we can load them in any
browser to check what that browser does.

Also changed some instances of 'window' to 'self' so that they are more
worker friendly.

Reviewed by Tony Chang.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-shared-workers-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
  • storage/indexeddb/createObjectStore-name-argument-required.html:
  • storage/indexeddb/createObjectStore-null-name-expected.txt:
  • storage/indexeddb/createObjectStore-null-name.html:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue.html:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-inconsistency-expected.txt:
  • storage/indexeddb/cursor-inconsistency.html:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-key-order-expected.txt:
  • storage/indexeddb/cursor-key-order.html:
  • storage/indexeddb/cursor-primary-key-order-expected.txt:
  • storage/indexeddb/cursor-primary-key-order.html:
  • storage/indexeddb/cursor-reverse-bug-expected.txt:
  • storage/indexeddb/cursor-reverse-bug.html:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update-value-argument-required-expected.txt:
  • storage/indexeddb/cursor-update-value-argument-required.html:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-name-undefined-expected.txt:
  • storage/indexeddb/database-name-undefined.html:
  • storage/indexeddb/database-odd-names-expected.txt:
  • storage/indexeddb/database-odd-names.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/delete-closed-database-object-expected.txt:
  • storage/indexeddb/delete-closed-database-object.html:
  • storage/indexeddb/delete-range-expected.txt:
  • storage/indexeddb/delete-range.html:
  • storage/indexeddb/deleteIndex-expected.txt:
  • storage/indexeddb/deleteIndex.html:
  • storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
  • storage/indexeddb/deleteObjectStore-name-argument-required.html:
  • storage/indexeddb/deleteObjectStore-null-name-expected.txt:
  • storage/indexeddb/deleteObjectStore-null-name.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/factory-basics-expected.txt:
  • storage/indexeddb/factory-basics.html:
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/factory-cmp.html:
  • storage/indexeddb/factory-deletedatabase-expected.txt:
  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
  • storage/indexeddb/factory-deletedatabase.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-count.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/index-get-key-argument-required-expected.txt:
  • storage/indexeddb/index-get-key-argument-required.html:
  • storage/indexeddb/index-multientry-expected.txt:
  • storage/indexeddb/index-multientry.html:
  • storage/indexeddb/index-population-expected.txt:
  • storage/indexeddb/index-population.html:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/index-unique.html:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/invalid-keys.html:
  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/key-generator.html:
  • storage/indexeddb/key-sort-order-across-types-expected.txt:
  • storage/indexeddb/key-sort-order-across-types.html:
  • storage/indexeddb/key-sort-order-date-expected.txt:
  • storage/indexeddb/key-sort-order-date.html:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/key-type-array.html:
  • storage/indexeddb/key-type-infinity-expected.txt:
  • storage/indexeddb/key-type-infinity.html:
  • storage/indexeddb/keypath-basics-expected.txt:
  • storage/indexeddb/keypath-basics.html:
  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keypath-edges.html:
  • storage/indexeddb/keypath-fetch-key-expected.txt:
  • storage/indexeddb/keypath-fetch-key.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange-required-arguments-expected.txt:
  • storage/indexeddb/keyrange-required-arguments.html:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/list-ordering-expected.txt:
  • storage/indexeddb/list-ordering.html:
  • storage/indexeddb/mozilla/add-twice-failure-expected.txt:
  • storage/indexeddb/mozilla/add-twice-failure.html:
  • storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
  • storage/indexeddb/mozilla/autoincrement-indexes.html:
  • storage/indexeddb/mozilla/bad-keypath-expected.txt:
  • storage/indexeddb/mozilla/bad-keypath.html:
  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/clear.html:
  • storage/indexeddb/mozilla/create-index-unique-expected.txt:
  • storage/indexeddb/mozilla/create-index-unique.html:
  • storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
  • storage/indexeddb/mozilla/create-index-with-integer-keys.html:
  • storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-basics.html:
  • storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-null-name.html:
  • storage/indexeddb/mozilla/cursor-mutation-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
  • storage/indexeddb/mozilla/cursor-mutation.html:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
  • storage/indexeddb/mozilla/cursors-expected.txt:
  • storage/indexeddb/mozilla/cursors.html:
  • storage/indexeddb/mozilla/delete-result-expected.txt:
  • storage/indexeddb/mozilla/delete-result.html:
  • storage/indexeddb/mozilla/event-source-expected.txt:
  • storage/indexeddb/mozilla/event-source.html:
  • storage/indexeddb/mozilla/global-data-expected.txt:
  • storage/indexeddb/mozilla/global-data.html:
  • storage/indexeddb/mozilla/indexes-expected.txt:
  • storage/indexeddb/mozilla/indexes.html:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
  • storage/indexeddb/mozilla/key-requirements-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
  • storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-no-key.html:
  • storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-null-key.html:
  • storage/indexeddb/mozilla/key-requirements.html:
  • storage/indexeddb/mozilla/object-cursors-expected.txt:
  • storage/indexeddb/mozilla/object-cursors.html:
  • storage/indexeddb/mozilla/object-identity-expected.txt:
  • storage/indexeddb/mozilla/object-identity.html:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
  • storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
  • storage/indexeddb/mozilla/object-store-remove-values.html:
  • storage/indexeddb/mozilla/objectstorenames-expected.txt:
  • storage/indexeddb/mozilla/objectstorenames.html:
  • storage/indexeddb/mozilla/odd-result-order-expected.txt:
  • storage/indexeddb/mozilla/odd-result-order.html:
  • storage/indexeddb/mozilla/open-database-null-name-expected.txt:
  • storage/indexeddb/mozilla/open-database-null-name.html:
  • storage/indexeddb/mozilla/put-get-values-expected.txt:
  • storage/indexeddb/mozilla/put-get-values.html:
  • storage/indexeddb/mozilla/readonly-transactions-expected.txt:
  • storage/indexeddb/mozilla/readonly-transactions.html:
  • storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
  • storage/indexeddb/mozilla/readwrite-transactions.html:
  • storage/indexeddb/mozilla/readyState-expected.txt:
  • storage/indexeddb/mozilla/readyState.html:
  • storage/indexeddb/mozilla/remove-index-expected.txt:
  • storage/indexeddb/mozilla/remove-index.html:
  • storage/indexeddb/mozilla/remove-objectstore-expected.txt:
  • storage/indexeddb/mozilla/remove-objectstore.html:
  • storage/indexeddb/mozilla/versionchange-abort-expected.txt:
  • storage/indexeddb/mozilla/versionchange-abort.html:
  • storage/indexeddb/mozilla/versionchange-expected.txt:
  • storage/indexeddb/mozilla/versionchange.html:
  • storage/indexeddb/mutating-cursor-expected.txt:
  • storage/indexeddb/mutating-cursor.html:
  • storage/indexeddb/objectStore-required-arguments-expected.txt:
  • storage/indexeddb/objectStore-required-arguments.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-clear-expected.txt:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/objectstore-count.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/odd-strings-expected.txt:
  • storage/indexeddb/odd-strings.html:
  • storage/indexeddb/open-close-version-expected.txt:
  • storage/indexeddb/open-close-version.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/open-during-transaction-expected.txt:
  • storage/indexeddb/open-during-transaction.html:
  • storage/indexeddb/prefetch-bugfix-108071-expected.txt:
  • storage/indexeddb/prefetch-bugfix-108071.html:
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/readonly-properties-expected.txt:
  • storage/indexeddb/readonly-properties.html:
  • storage/indexeddb/readonly.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/resources/basics.js:

(test):
(openCallback):

  • storage/indexeddb/resources/index-basics.js:

(test):

  • storage/indexeddb/resources/objectstore-basics.js:

(test):
(setVersionSuccess):
(createIndex):
(addData):
(addAgainFailure):
(removeSuccessButNotThere):
(testPreConditions.request.onsuccess):
(testPreConditions):

  • storage/indexeddb/resources/shared.js:

(removeVendorPrefixes):

  • storage/indexeddb/resources/transaction-abort-workers.js:

(transactionAborted):
(transactionCompleted):
(timeoutTest.transaction.onabort):
(timeoutTest):
(errorTransactionAborted):

  • storage/indexeddb/setVersion-null-expected.txt:
  • storage/indexeddb/setVersion-null.html:
  • storage/indexeddb/setVersion-undefined-expected.txt:
  • storage/indexeddb/setVersion-undefined.html:
  • storage/indexeddb/set_version_blocked-expected.txt:
  • storage/indexeddb/set_version_blocked.html:
  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/set_version_queue.html:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
  • storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion.html:
  • storage/indexeddb/transaction-abort-workers-expected.txt:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only-expected.txt:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/transaction-rollback-expected.txt:
  • storage/indexeddb/transaction-rollback.html:
  • storage/indexeddb/transaction-storeNames-required-expected.txt:
  • storage/indexeddb/transaction-storeNames-required.html:
  • storage/indexeddb/two-version-changes-expected.txt:
  • storage/indexeddb/two-version-changes.html:
  • storage/indexeddb/value-undefined-expected.txt:
  • storage/indexeddb/value-undefined.html:
  • storage/indexeddb/values-odd-types-expected.txt:
  • storage/indexeddb/values-odd-types.html:
  • storage/indexeddb/version-change-abort-expected.txt:
  • storage/indexeddb/version-change-abort.html:
  • storage/indexeddb/version-change-exclusive-expected.txt:
  • storage/indexeddb/version-change-exclusive.html:
  • storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
  • storage/indexeddb/versionchangerequest-activedomobject.html:
2:20 PM Changeset in webkit [110749] by commit-queue@webkit.org
  • 9 edits
    2 moves in trunk/Source/WebCore

Move EntriesCallback to Modules/filesystem/
​https://bugs.webkit.org/show_bug.cgi?id=81032

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-03-14
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/filesystem/EntriesCallback.h: Copied from Source/WebCore/fileapi/EntriesCallback.h.
  • Modules/filesystem/EntriesCallback.idl: Copied from Source/WebCore/fileapi/EntriesCallback.idl.
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/EntriesCallback.h: Removed.
  • fileapi/EntriesCallback.idl: Removed.
2:14 PM Changeset in webkit [110748] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Heap::destroy leaks CopiedSpace
​https://bugs.webkit.org/show_bug.cgi?id=81055

Reviewed by Geoffrey Garen.

Added a destroy() function to CopiedSpace that moves all normal size
CopiedBlocks from the CopiedSpace to the Heap's list of free blocks
as well as deallocates all of the oversize blocks in the CopiedSpace.
This function is now called in Heap::destroy().

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::destroy):
(JSC):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/Heap.cpp:

(JSC::Heap::destroy):

2:10 PM Changeset in webkit [110747] by tony@chromium.org
  • 8 edits
    2 adds in trunk

multiline column flexbox with auto height wrap too much
​https://bugs.webkit.org/show_bug.cgi?id=80929

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/multiline-column-auto.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore):
(WebCore::RenderBox::computeContentLogicalHeightUsing): Pull out into a separate method.

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::lineBreakLength): Compute the value based on height & max-height for column layout.
(WebCore):
(WebCore::RenderFlexibleBox::computeNextFlexLine):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/multiline-column-auto-expected.txt: Added.
  • css3/flexbox/multiline-column-auto.html: Added.
  • css3/flexbox/multiline-shrink-to-fit-expected.html:
  • css3/flexbox/multiline-shrink-to-fit.html:
2:04 PM Changeset in webkit [110746] by commit-queue@webkit.org
  • 2 edits in trunk/PerformanceTests

Unreviewed, rolling out r110559.
​http://trac.webkit.org/changeset/110559
​https://bugs.webkit.org/show_bug.cgi?id=81142

Broke Dromaeo tests (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-14

  • Dromaeo/resources/dromaeorunner.js:

(.):

2:04 PM Changeset in webkit [110745] by jberlin@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

PeerConnection was renamed to DeprecatedPeerConnection in r110587. Update the expected
results.

The rebaseline landed for Qt in 110685 should actually have been landed for all ports.
Land it for all ports, and remove the Qt specific expected results.

  • fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/qt/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
2:01 PM Changeset in webkit [110744] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Optimize the multiply-add in Biquad.cpp::process
​https://bugs.webkit.org/show_bug.cgi?id=75528

Patch by Xingnan Wang <​xingnan.wang@intel.com> on 2012-03-14
Reviewed by Chris Rogers.

Pipeline the multiply-add with SSE2 instructions and get about 20% improvement for the function.

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::process):

1:59 PM Changeset in webkit [110743] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

WebProcess sometimes hits an assertion in SandboxExtensionTracker::didCommitProvisionalLoad after running regression tests
​https://bugs.webkit.org/show_bug.cgi?id=81150
<rdar://problem/11002254>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad): (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad): It's not great, but for now we need to handle this case. Hopefully, some day we'll make both WebKit2 processes better aware of what's going on with loading in WebCore.
1:57 PM Changeset in webkit [110742] by abarth@webkit.org
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

Clean up a few more baseline.

  • platform/chromium-mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/filter-empty-element-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/unicode-variation-selector-expected.png:
  • platform/chromium-win-xp/svg/dynamic-updates: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Removed.
1:52 PM Changeset in webkit [110741] by jamesr@google.com
  • 4 edits in trunk

[Chromium] Layout Test compositing/repaint/opacity-between-absolute.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=79823

Reviewed by Adrienne Walker.

Source/WebCore:

LayerRendererChromium was storing a weak pointer to the current render surface in m_currentRenderSurface and
using this in useRenderSurface() to avoid rebinding if we called useRenderSurface() multiple times in a row on
the same surface. This pointer was never cleared, so if any subsequent surface landed at the same address this
caching would misbehave and we'd fail to correctly initialize the new render surface. The caching wasn't
actually buying us anything anyway since we only call useRenderSurface() once per surface per frame and we
always set the viewport for the default render surface.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):

LayoutTests:

  • platform/chromium/test_expectations.txt:
1:38 PM Changeset in webkit [110740] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WKTR doesn't have an implemenation of hasSpellingMarker yet.

Add more tests that rely on it to the WK2 Skipped list.

  • platform/wk2/Skipped:
1:30 PM Changeset in webkit [110739] by ojan@chromium.org
  • 3 edits in trunk/Tools

Add the chromium lion bot to garden-o-matic and remove
the platform_move_to in builders.py since the Chromium Lion
port is now a normal port.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • Scripts/webkitpy/layout_tests/port/builders.py:
1:22 PM Changeset in webkit [110738] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Frame flattening ASSERT(!needsLayout()) in FrameView::paintContents()
​https://bugs.webkit.org/show_bug.cgi?id=80155

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2012-03-14
Reviewed by Antti Koivisto.

Source/WebCore:

This patch ensures that an iframe only schedules and calls parent's layout,
when it is going to be flattened. Non-flattened iframe does not affect
parent's layout, so normal layout flow applies. isInSubframeLayoutWithFrameFlattening()
function has been added to test whether a particular child frame is changing
parent's layout. This function also ensures that scheduleRelayout() and layout()
are in sync of checking againts frame flattening.

Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html

  • page/FrameView.cpp:

(WebCore::FrameView::avoidScrollbarCreation):
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::isInChildFrameWithFrameFlattening):
(WebCore):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderIFrame.h:

(RenderIFrame):
(WebCore::RenderIFrame::renderName):

LayoutTests:

  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout-expected.txt: Added.
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html: Added.
1:07 PM Changeset in webkit [110737] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Don't cap the scroll position if layout happens when a FrameView's overhangAmount is non-zero
​https://bugs.webkit.org/show_bug.cgi?id=81146
<rdar://problem/10850075>

Reviewed by Beth Dakin.

If layout happens when a page has a non-zero overhang amount, we shouldn't cap the scroll position
to be inside of the valid maximum/minimum scroll offsets because that will cause the page to jump back, which
can look really bad if layout happens in response to the page being scrolled.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

12:58 PM Changeset in webkit [110736] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Add Lion failures in order to green the lion bot.

  • platform/chromium/test_expectations.txt:
12:53 PM Changeset in webkit [110735] by tommyw@google.com
  • 5 edits
    4 copies
    1 add in trunk/Source/WebCore

MediaStream API (JSEP): Introducing IceCandidate
​https://bugs.webkit.org/show_bug.cgi?id=80699

Reviewed by Adam Barth.

Patch #2 in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.
Adding the JS object IceCandidate and its WebCore/platform sibling IceCandidateDescriptor.
This object will be created both from JS and the embedder.

Not possible to test until the entire JSEP feature is commited.

  • GNUmakefile.list.am:
  • Modules/mediastream/IceCandidate.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(WebCore::IceCandidate::create):
(WebCore::IceCandidate::IceCandidate):
(WebCore::IceCandidate::~IceCandidate):
(WebCore::IceCandidate::label):
(WebCore::IceCandidate::candidateLine):
(WebCore::IceCandidate::toSdp):
(WebCore::IceCandidate::descriptor):

  • Modules/mediastream/IceCandidate.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(IceCandidate):

  • Modules/mediastream/IceCandidate.idl: Added.
  • WebCore.gypi:
  • platform/mediastream/IceCandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(WebCore::IceCandidateDescriptor::create):
(WebCore::IceCandidateDescriptor::IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::~IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::toSdp):

  • platform/mediastream/IceCandidateDescriptor.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::label):
(WebCore::IceCandidateDescriptor::candidateLine):

  • platform/mediastream/MediaStreamCenter.cpp:

(WebCore::MediaStreamCenter::constructSdp):
(WebCore):

  • platform/mediastream/MediaStreamCenter.h:

(WebCore):
(MediaStreamCenter):

12:52 PM Changeset in webkit [110734] by tsepez@chromium.org
  • 2 edits in branches/chromium/1025/Source/WebCore/html/parser

Merge 108881 - XSS Auditor targeting legitimate frames as false positives.
​https://bugs.webkit.org/show_bug.cgi?id=79397

Reviewed by Adam Barth.

TBR=​tsepez@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9701035

12:51 PM Changeset in webkit [110733] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.skipped_tests):

12:50 PM Changeset in webkit [110732] by Simon Fraser
  • 6 edits
    3 adds in trunk

background-visibility:hidden should create a RenderLayer
​https://bugs.webkit.org/show_bug.cgi?id=81134

Source/WebCore:

Reviewed by Dean Jackson.

Background-visibility:hidden has to create RenderLayers, because it's implemented
via compositing and/or paint short-circuiting in RenderLayer code.

Test: transforms/3d/general/background-visibility-layers.html

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::requiresLayer):

  • rendering/RenderObject.h:

(WebCore::RenderObject::hasHiddenBackface):

  • rendering/RenderTableRow.h:

LayoutTests:

Reviewed by Dean Jackson.

Test for background-visibility: hidden making a RenderLayer.

  • transforms/3d/general/background-visibility-layers-actual.png: Added.
  • transforms/3d/general/background-visibility-layers-actual.txt: Added.
  • transforms/3d/general/background-visibility-layers.html: Added.
12:48 PM Changeset in webkit [110731] by commit-queue@webkit.org
  • 11 edits
    8 adds in trunk

[CSSRegions][CSSOM] Implement regionLayoutEvent
​https://bugs.webkit.org/show_bug.cgi?id=78882

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-03-14
Reviewed by David Hyatt.

Source/WebCore:

Adding the regionLayoutEvent that is dispatch for all regions after each flow-thread layout.

Tests: fast/regions/region-event-add-to-flow.html

fast/regions/region-event-remove-from-dom.html
fast/regions/region-event-remove-from-flow.html
fast/regions/region-event.html

  • dom/Document.cpp:

(WebCore::Document::addListenerTypeIfNeeded): Added check for regionLayoutUpdate listeners

  • dom/Document.h:
  • dom/EventNames.h:

(WebCore):

  • dom/Node.cpp:

(WebCore::Node::dispatchRegionLayoutUpdateEvent):
(WebCore):

  • dom/Node.h:

(Node):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout): Start the event dispatch timer but only if there are regionLayoutUpdate listeners and there is at least one region that had its layout updated.
(WebCore::RenderFlowThread::computeOverflowStateForRegions): Mark regions that might had a layout update
(WebCore::RenderFlowThread::regionLayoutUpdateEventTimerFired):
(WebCore):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::setDispatchRegionLayoutUpdateEvent):
(WebCore::RenderRegion::shouldDispatchRegionLayoutUpdateEvent):
(RenderRegion):

LayoutTests:

  • fast/regions/region-event-add-to-flow-expected.txt: Added.
  • fast/regions/region-event-add-to-flow.html: Added.
  • fast/regions/region-event-expected.txt: Added.
  • fast/regions/region-event-remove-from-dom-expected.txt: Added.
  • fast/regions/region-event-remove-from-dom.html: Added.
  • fast/regions/region-event-remove-from-flow-expected.txt: Added.
  • fast/regions/region-event-remove-from-flow.html: Added.
  • fast/regions/region-event.html: Added.
12:45 PM Changeset in webkit [110730] by pierre.rossi@gmail.com
  • 3 edits in trunk/Source/WebCore

[Qt] Add support for vertical sliders in mobile theme
​https://bugs.webkit.org/show_bug.cgi?id=80179

This makes sliders using the "slider-vertical" appearance more sensible.

Reviewed by Simon Hausmann.

No new tests, since the mobile theme still isn't used in layout tests.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore):
(WebCore::StylePainterMobile::drawProgress):
(WebCore::RenderThemeQtMobile::paintSliderTrack):

  • platform/qt/RenderThemeQtMobile.h:

(StylePainterMobile):

12:30 PM Changeset in webkit [110729] by ojan@chromium.org
  • 2 edits
    1 copy
    30 moves
    47 adds
    3 deletes in trunk/LayoutTests

Rebaseline chromium-lion tests that have "MISSING" results.

12:26 PM Changeset in webkit [110728] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Fix UI process crash when a plug-in process crashes with a modal dialog showing
​https://bugs.webkit.org/show_bug.cgi?id=81139
<rdar://problem/9641197>

Reviewed by Dan Bernstein.

When a plug-in process crashes, its corresponding PluginProcessProxy object is deleted immediately,
which is bad if we're currently running a nested run loop.

Fix this by making PluginProcessProxy ref-counted and protecting it before the call to -[NSApp runModalForWindow:].

  • UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::pluginProcessWithPath):
(WebKit::PluginProcessManager::getOrCreatePluginProcess):

  • UIProcess/Plugins/PluginProcessManager.h:

(PluginProcessManager):

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::create):
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):

  • UIProcess/Plugins/PluginProcessProxy.h:

(PluginProcessProxy):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::setModalWindowIsShowing):
(WebKit::PluginProcessProxy::beginModal):

12:24 PM Changeset in webkit [110727] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

WebProcess spins beneath [QTMovie movieFileTypes:]
​https://bugs.webkit.org/show_bug.cgi?id=81133

Reviewed by Eric Carlson.

No new tests; speculative fix for top WebProcess spin.

When checking to see if a given mime type is supported by QuickTime,
immediately exclude all types that do not begin with 'audio/' or 'video/'.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::supportsType):

12:12 PM Changeset in webkit [110726] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp

We cannot size blocks from the line tree using sub-pixel precision since we don't paint blocks using sub-pixels. We must always grow to contain the lines.

12:10 PM Changeset in webkit [110725] by abarth@webkit.org
  • 23 edits
    5 adds
    1 delete in trunk/LayoutTests

Update SVG baseline after work on <use> element. These results all
seem to be minor differences or progressions.

  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
  • platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
  • platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
11:55 AM Changeset in webkit [110724] by dpranke@chromium.org
  • 6 edits in trunk/Tools

Please add a way to manually skip some tests in NRWT
​https://bugs.webkit.org/show_bug.cgi?id=81019

Reviewed by Ojan Vafai.

This patch implements the -i / --ignore-tests flag from ORWT
and refactors the test_expectations.py code slightly to handle
it.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.parse_expectations):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_add_skipped_tests):
(test_add_skipped_tests_duplicate):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_ignore_tests):
(MainTest.test_ignore_tests.assert_ignored):

11:54 AM Changeset in webkit [110723] by Lucas Forschler
  • 5 edits in branches/safari-534.55-branch/Source

Versioning.

11:53 AM Changeset in webkit [110722] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
​https://bugs.webkit.org/show_bug.cgi?id=81028

Reviewed by Ojan Vafai.

The mac port had incorrect lookups for 'mac-lion' and
'mac-future' in some places. This patch fixes that and adds a
bunch of tests.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.baseline_path):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacTest.assert_skipped_file_search_paths):
(MacTest.test_skipped_file_search_paths):
(_assert_search_path):
(test_baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._skipped_file_search_paths):

11:46 AM WebKit Team edited by jberlin@webkit.org
Moving myself to the reviewers section (diff)
11:45 AM Changeset in webkit [110721] by Lucas Forschler
  • 1 copy in branches/safari-534.55-branch

New branch.

11:37 AM Changeset in webkit [110720] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

WK2: Spelling tests that rely on getting the marked range or the marked count synchronously fail
​https://bugs.webkit.org/show_bug.cgi?id=81138

Add some expected failing results for such tests to get the bots green.

  • platform/mac-wk2/editing/spelling/markers-expected.txt: Added.
  • platform/mac-wk2/editing/spelling/spelling-insert-html-expected.txt: Added.
  • platform/mac-wk2/editing/spelling/spelling-unified-emulation-expected.txt: Added.
11:33 AM Changeset in webkit [110719] by enne@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, remove expectations for non-crashing tests
​https://bugs.webkit.org/show_bug.cgi?id=78038

  • platform/chromium/test_expectations.txt:
11:29 AM Changeset in webkit [110718] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make RenderIFrame::flattenFrame() return earlier, when frame flattening is disabled.
​https://bugs.webkit.org/show_bug.cgi?id=80301

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2012-03-14
Reviewed by Antti Koivisto.

Reorganize RenderIFrame flattenFrame() code, so that it returns
earlier for the normal use case, when frame flattening is disabled.
It also removes leftover null check.

No new tests, since there's no new functionality.

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::flattenFrame):

11:16 AM Changeset in webkit [110717] by eae@chromium.org
  • 6 edits in branches/subpixellayout/Source

Pixel snapping fixes for RenderInline and RenderBoxModelObject on branch.

11:12 AM Changeset in webkit [110716] by jamesr@google.com
  • 6 edits in trunk/Source

[chromium] Provide explicit polling API to check if the platform is capable of accelerated 2d canvas
​https://bugs.webkit.org/show_bug.cgi?id=80667

Reviewed by Darin Fisher.

Source/WebCore:

Query the platform to see if we can instantiate a context suitable for accelerating 2d canvas. If we can't, for
instance if we're on a system that can't preserve a context when the screensaver comes up, then immediately fall
back to software.

Covered by canvas layout tests in the virtual-gpu mode.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::shouldAccelerate):

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::canAccelerate2dCanvas):
(WebKitPlatformSupport):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::canAccelerate2dCanvas):
(WebCore):

11:03 AM Changeset in webkit [110715] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Support drag in mouse events for WebKit2 EventSender
​https://bugs.webkit.org/show_bug.cgi?id=68552
​https://bugs.webkit.org/show_bug.cgi?id=69946

Add some tests that use eventSender.dragMode to the WK2 Skipped list.

  • platform/wk2/Skipped:
10:56 AM Changeset in webkit [110714] by Carlos Garcia Campos
  • 14 edits in trunk/Source

[GTK] Handle printing errors in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=77197

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

  • platform/gtk/ErrorsGtk.cpp:

(WebCore::printError): Create a generic print error.
(WebCore::printerNotFoundError): Create a print error to notify
that the selected printer could not be found.
(WebCore::invalidPageRangeToPrint): Create a print error when the
selected page range is invalid and there are no pages to print.

  • platform/gtk/ErrorsGtk.h:

(WebCore): Add print error doamin.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitError.cpp:

(webkit_print_error_quark): Add new error domain for print
errors.

  • UIProcess/API/gtk/WebKitError.h: Ad print errors.
  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkit_print_operation_class_init): Add
WebKitPrintOperation::failed signal.
(drawPagesForPrintingCompleted): Emit WebKitPrintOperation::failed
when the print operation failed with the given error.
(webkitPrintOperationPrintPagesForFrame): Use
PrintFinishedCallback instead of a VoidCallback.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestPrinting.cpp:

(testPrintOperationPrint):
(testPrintOperationErrors): Test different print errors are
correctly reported.
(beforeAll):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Invalidate print finished callbacks
map.
(WebKit::WebPageProxy::printFinishedCallback): Callback called
when the print operation has finished in the web process.
(WebKit::WebPageProxy::processDidCrash): Invalidate print finished
callbacks map.
(WebKit::WebPageProxy::drawPagesForPrinting): Use a
PrintFinishedCallback instead of a VoidCallback.

  • UIProcess/WebPageProxy.h:

(WebKit): Delcare PrintFinishedCallback as a generic callback.
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in: Use PrintFinishedCallback

instead of VoidCallback as callback argument of
DrawPagesForPrinting message.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Mark the data as invalid
when there are no pages to print.
(PrintPagesData): Add isValid parameter to mark the data struct as
invalid.
(WebKit::WebPrintOperationGtk::printPagesIdleDone): Call
printPagesDone() instead of printDone().
(WebKit::WebPrintOperationGtk::printPagesDone): Renamed.
(WebKit::WebPrintOperationGtk::printDone): Notify the UI process
that the print operation has finsihed.
(WebKit::WebPrintOperationGtk::print): Finish the print if the
PrintPagesData struct is not valid.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
10:32 AM Changeset in webkit [110713] by commit-queue@webkit.org
  • 5 edits
    59 adds in trunk

[EFL] Enable HTML5 Summary and Details elements
​https://bugs.webkit.org/show_bug.cgi?id=81027

Enabling Summary and Details elements by default and removing related
tests from skip list since they should pass now.

.:

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

LayoutTests:

Tests expectations from Ubuntu 11.10 using EFL from SVN. Hopefully the
same as the build bot.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
  • platform/efl/fast/html/details-add-child-1-expected.txt: Added.
  • platform/efl/fast/html/details-add-child-2-expected.txt: Added.
  • platform/efl/fast/html/details-add-details-child-1-expected.txt: Added.
  • platform/efl/fast/html/details-add-details-child-2-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-child-1-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-child-2-expected.txt: Added.
  • platform/efl/fast/html/details-nested-1-expected.txt: Added.
  • platform/efl/fast/html/details-nested-2-expected.txt: Added.
  • platform/efl/fast/html/details-no-summary1-expected.txt: Added.
  • platform/efl/fast/html/details-no-summary2-expected.txt: Added.
  • platform/efl/fast/html/details-no-summary3-expected.txt: Added.
  • platform/efl/fast/html/details-no-summary4-expected.txt: Added.
  • platform/efl/fast/html/details-open-javascript-expected.txt: Added.
  • platform/efl/fast/html/details-open1-expected.txt: Added.
  • platform/efl/fast/html/details-open2-expected.txt: Added.
  • platform/efl/fast/html/details-open3-expected.txt: Added.
  • platform/efl/fast/html/details-open4-expected.txt: Added.
  • platform/efl/fast/html/details-open5-expected.txt: Added.
  • platform/efl/fast/html/details-open6-expected.txt: Added.
  • platform/efl/fast/html/details-position-expected.txt: Added.
  • platform/efl/fast/html/details-remove-child-1-expected.txt: Added.
  • platform/efl/fast/html/details-remove-child-2-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-child-1-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-child-2-expected.txt: Added.
  • platform/efl/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/efl/fast/html/details-replace-text-expected.txt: Added.
  • platform/efl/fast/html/details-writing-mode-expected.txt: Added.
10:05 AM Changeset in webkit [110712] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
​https://bugs.webkit.org/show_bug.cgi?id=81105

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-03-14
Reviewed by Rob Buis.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStorePrivate::isActive):
(BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
(WebKit):
(BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):

  • Api/BackingStore.h:
  • Api/WebPage.cpp:

(BlackBerry::WebKit::toWebCoreMouseEventType):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::activeNodeContext):
(BlackBerry::WebKit::WebPage::activeNodeContext):
(BlackBerry::WebKit::WebPagePrivate::updateCursor):
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

9:59 AM Changeset in webkit [110711] by Nikolas Zimmermann
  • 22 edits in trunk

Make SVGUseElement respect & support externalResourcesRequired
​https://bugs.webkit.org/show_bug.cgi?id=81109

Reviewed by Rob Buis.

Source/WebCore:

Generalize the existing externalResourcesRequired support from SVGScriptElement
into SVGExternalResourcesRequired, so it can be shared with SVGUseElement, which
was lacking proper externalResourcesRequired support.

<use xlink:href="external.svg" onload="alert('hi')" externalResourcesRequired="true"/>
The onload handler now fires _after_ the external resources loaded, making it possible
to write reliable tests that switch from internal to external resources or the other
way around. Converted the new tests in svg/dynamic-updates/SVGUseElement* to listen
to SVGLoad events, to make them reliable.

We may be able to generalize this to cover SVGImageElement as well (the only other class which
is currently supporting externalResourcesRequired - but that's more involved, so I left it TODO).

Covered by existing tests and the changes to the new SVGUseElement tests.

  • svg/SVGElement.h:

(SVGElement): Make haveLoadedRequiredResources() public so SVGExternalResourcesRequired can call it.

  • svg/SVGExternalResourcesRequired.cpp: Refactored code from SVGScriptElement, 1:1 copies w/o changes.

(WebCore::SVGExternalResourcesRequired::handleAttributeChange):
(WebCore::SVGExternalResourcesRequired::dispatchLoadEvent):
(WebCore::SVGExternalResourcesRequired::insertedIntoDocument):
(WebCore::SVGExternalResourcesRequired::finishParsingChildren):
(WebCore::SVGExternalResourcesRequired::haveLoadedRequiredResources):

  • svg/SVGExternalResourcesRequired.h: Add new virtual functions, that must be available in classes that inherit from SVGExternalResourcesRequired.

(WebCore::SVGExternalResourcesRequired::setHaveFiredLoadEvent):
(WebCore::SVGExternalResourcesRequired::isParserInserted):
(WebCore::SVGExternalResourcesRequired::haveFiredLoadEvent):

  • svg/SVGScriptElement.cpp: Refactored externalResourcesRequired handling into SVGExternalResourcesRequired.

(WebCore::SVGScriptElement::svgAttributeChanged):
(WebCore::SVGScriptElement::insertedIntoDocument):
(WebCore::SVGScriptElement::finishParsingChildren):

  • svg/SVGScriptElement.h: Ditto.

(WebCore::SVGScriptElement::haveLoadedRequiredResources):
(WebCore::SVGScriptElement::dispatchLoadEvent):
(WebCore::SVGScriptElement::setHaveFiredLoadEvent):
(WebCore::SVGScriptElement::isParserInserted):
(WebCore::SVGScriptElement::haveFiredLoadEvent):

  • svg/SVGTests.cpp: Fix obvious typo, that leads to an assertion. Always return true if we know the attributeName.

(WebCore::SVGTests::handleAttributeChange):

  • svg/SVGTests.h:
  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::insertedIntoDocument): Remove ambigous call warning.

  • svg/SVGUseElement.cpp: Support externalResourcesRequired="true/false" + dynamic changes of it. Covered by existing tests.

(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::create):
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::notifyFinished):
(WebCore::SVGUseElement::finishParsingChildren):
(WebCore):

  • svg/SVGUseElement.h: Ditto.

(WebCore::SVGUseElement::haveLoadedRequiredResources):
(WebCore::SVGUseElement::setHaveFiredLoadEvent):
(WebCore::SVGUseElement::isParserInserted):
(WebCore::SVGUseElement::haveFiredLoadEvent):

  • svg/svgtags.in: Pass "bool wasInsertedByParser" to SVGUseElement constructor.

LayoutTests:

Fix flakiness of new external <use> tests introduced in r110676.

  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
  • svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.txt:
  • svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.txt:
  • svg/dynamic-updates/script-tests/SVGUseElement-dom-href1-attr.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGUseElement-dom-href2-attr.js:

(repaintTest):
(externalLoadDone):

  • svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href1-prop.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href2-prop.js:

(repaintTest):
(externalLoadDone):

9:32 AM Changeset in webkit [110710] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Mac WK2: editing/pasteboard/dataTransfer-setData-getData.html fails
​https://bugs.webkit.org/show_bug.cgi?id=81125

Add expected failing results for Mac WK2 to get the bots green.

  • platform/mac-wk2/editing/pasteboard/dataTransfer-setData-getData-expected.txt: Added.
9:23 AM Changeset in webkit [110709] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source

[BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using AnimationFrameRateController
​https://bugs.webkit.org/show_bug.cgi?id=81000

Source/JavaScriptCore:

Enable WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for BlackBerry.

Patch by Andrew Lo <​anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.

  • wtf/Platform.h:

Source/WebCore:

Add BlackBerry port for DisplayRefreshMonitor using AnimationFrameRateController.
Moved refreshDisplayOnMainThread to platform independant part of header.

Patch by Andrew Lo <​anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.

requestAnimationFrame already covered by tests in LayoutTests/fast/animation.

  • PlatformBlackBerry.cmake:
  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):

  • platform/graphics/DisplayRefreshMonitor.h:

(WebCore):
(DisplayAnimationClient):
(WebCore::DisplayAnimationClient::~DisplayAnimationClient):
(DisplayRefreshMonitor):

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: Added.

(WebCore):
(WebCore::DisplayAnimationClient::DisplayAnimationClient):
(WebCore::DisplayAnimationClient::animationFrameChanged):
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::startAnimationClient):
(WebCore::DisplayRefreshMonitor::stopAnimationClient):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):

Source/WebKit/blackberry:

Set the platform display ID, needed for DisplayRefreshMonitor.

Patch by Andrew Lo <​anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

9:21 AM Changeset in webkit [110708] by jer.noble@apple.com
  • 10 edits in trunk

Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
​https://bugs.webkit.org/show_bug.cgi?id=81056

Reviewed by Jessie Berlin.

Source/WebKit2:

Give the InjectedBundlePageFullScreenClient a first crack at beganEnterFullScreen and beganExitFullScreen:

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):

And call the client function if it exists; otherwise, continue to message the page:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:

(WebKit::InjectedBundlePageFullScreenClient::beganEnterFullScreen):
(WebKit::InjectedBundlePageFullScreenClient::beganExitFullScreen):

  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:

Add a custom APIClientTraits for InjectedBundlePageFullScreenClient to handle the API number change.

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h:

Tools:

Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):

9:20 AM Changeset in webkit [110707] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: use class name indexes instead of class names when evaluating aggregates
​https://bugs.webkit.org/show_bug.cgi?id=81100

Class name and type name indexes are now used when calculating class aggregates
in heap snapshots instead of string lookup followed by a string comparison.

Class names like "Window / www.webkit.org" are now left as is in the UI (it used
to be trimed to just "Window").

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get classNameIndex):
(WebInspector.HeapSnapshotNode.prototype.hasType):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildAggregates):

9:04 AM Changeset in webkit [110706] by caseq@chromium.org
  • 19 edits
    2 adds in trunk

Web Inspector: add didCancelFrame timeline event
​https://bugs.webkit.org/show_bug.cgi?id=80994

Reviewed by Pavel Feldman.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • add an ability to cancel certain timeline events, unless they've been followed by other events.
  • implement didCancelFrame() event, fired when a platform decides not to render frame after didBeginFrame() was called.

Test: inspector/timeline/timeline-frames.html

  • WebCore.exp.in:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCancelFrameImpl):
(WebCore):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCancelFrame):
(WebCore):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore):
(WebCore::InspectorTimelineAgent::didCancelFrame):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::pushCancelableRecord):
(WebCore::InspectorTimelineAgent::commitCancelableRecords):
(WebCore::InspectorTimelineAgent::cancelRecord):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):

  • testing/Internals.cpp:

(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore):
(WebCore::Internals::emitInspectorDidCancelFrame):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/chromium:

  • add intrumentCanceFrame(), called when renderer decides not to

render frame after instrumentBeginFrame() was called.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::instrumentCancelFrame):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::instrumentCancelFrame):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • added test for didBeginFrame()/didCancelFrame()
  • inspector/timeline/timeline-frames-expected.txt: Added.
  • inspector/timeline/timeline-frames.html: Added.
8:42 AM Changeset in webkit [110705] by ahf@0x90.dk
  • 2 edits in trunk/Tools

The width and height of the scroll indicators in the MiniBrowser does not consider the offset margins. ​https://bugs.webkit.org/show_bug.cgi?id=81112

Reviewed by Kenneth Rohde Christiansen.

This patch fixes the issue by withdrawing two times the anchor
margins.

  • MiniBrowser/qt/qml/ScrollIndicator.qml:
8:37 AM Changeset in webkit [110704] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Region can acquire an empty span by subtracting an empty Region
​https://bugs.webkit.org/show_bug.cgi?id=81074

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-14
Reviewed by Anders Carlsson.

Source/WebCore:

Subtracting an empty Region B from a Region A can cause A to end
up with an empty span. This violates the rule that two Regions
that cover the exact same area should have equal spans and segments.

Unit test: RegionTest.emptySpan

  • platform/graphics/Region.cpp:

(WebCore::Region::subtract):

Source/WebKit/chromium:

  • tests/RegionTest.cpp:

(WebCore::TEST):
(WebCore):

8:31 AM Changeset in webkit [110703] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Textmap] Disable driver based BGRA swizzling for OpenGL/ES

Reviewed by Noam Rosenthal.

The current way of detecting swizzling support (check for GL_EXT_texture_format_BGRA8888)
is unfortunately not reliable. We need a better way of detection that (filed bug 81103).
In the meantime this patch reverts back to doing the swizzling in the texture mapper to
get pixels back onto the screen.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::driverSupportsBGRASwizzling):
(WebCore::BitmapTextureGL::updateContents):

8:28 AM Changeset in webkit [110702] by vestbo@webkit.org
  • 2 edits in trunk

[Qt] Deal with multiple paths in QMAKE_EXTRA_MODULE_FORWARDS

Reviewed by Simon Hausmann.

8:24 AM Changeset in webkit [110701] by leo.yang@torchmobile.com.cn
  • 6 edits in trunk/Source

[BlackBerry] Upstream the BlackBerry change to platform/Cursor.h
​https://bugs.webkit.org/show_bug.cgi?id=81086

Reviewed by Rob Buis.

Source/WebCore:

  • platform/Cursor.h:

(WebCore):
(WebCore::Cursor::Cursor):
Add the BlackBerry specific PlatformCursor.

  • platform/blackberry/PageClientBlackBerry.h:

There was an alias named PlatformCursorHandle for PlatformCursor
in the internal version of Cursor.h. But it's not necessary so it's
not included in the upstreaming version of Cursor.h. As a result,
use PlatformCursor directly in this file.
(PageClientBlackBerry):

Source/WebKit/blackberry:

There was an alias named PlatformCursorHandle for PlatformCursor
in the internal version of Cursor.h. But it's not necessary so it's
not included in the upstreaming version of Cursor.h. As a result,
use PlatformCursor directly.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setCursor):

  • Api/WebPage_p.h:

(WebPagePrivate):

8:15 AM Changeset in webkit [110700] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Implement LayoutTestController::clearBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=80142

Tools:

Adding missing implementation clearBackForwardList to EFL's
LayoutTestController. This implementation allows us to unskip
tests connected with history.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::clearBackForwardList): Implemented.

LayoutTests:

Unskip tests connected with clearBackForwardList.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
8:02 AM Changeset in webkit [110699] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] RunLoopQt is missing reentrancy guards
​https://bugs.webkit.org/show_bug.cgi?id=80982

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-03-14
Reviewed by Tor Arne Vestbø.

Avoid recursive calls to RunLoop::performWork() with a simple
counting mechanism, to avoid out-of-order message dispatching.

  • platform/qt/RunLoopQt.cpp:

(WebCore::RunLoop::TimerObject::TimerObject):
(WebCore::RunLoop::TimerObject::performWork):
(RunLoop::TimerObject):

7:41 AM Changeset in webkit [110698] by loislo@chromium.org
  • 4 edits in trunk

Source/WebCore: Web Inspector: small improvement for HeapSnapshot performance ~12%.
​https://bugs.webkit.org/show_bug.cgi?id=81033

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.get nodeCount):
(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype._buildReverseIndex):
(WebInspector.HeapSnapshot.prototype.get nodeIndexes):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):

Source/WebKit/chromium: Unreviewed, mark verifyCullChildLinesUpTopLeft() as failed.

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-03-13

  • tests/CCQuadCullerTest.cpp:

(WebCore):
(WebCore::TEST):

LayoutTests: Return null when shouldAllowAccessToNode() fails
​https://bugs.webkit.org/show_bug.cgi?id=80205

Patch by Kentaro Hara <​haraken@chromium.org> on 2012-03-14
Reviewed by Adam Barth.

shouldAllowAccessToNode() is used for window.frameElement, HTMLFrameElement.contentDocument,
and getSVGDocument(). The spec of window.frameElement and HTMLFrameElement.contentDocument
requires that they should return null when the security check fails.
Thus this patch changes the return value from undefined to null.

​http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#navigating-nested-browsing-contexts-in-the-dom
​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-iframe-contentdocument

  • http/tests/security/cross-frame-access-frameelement-expected.txt:
  • http/tests/security/local-iFrame-from-remote.html:
  • platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
6:23 AM Changeset in webkit [110697] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build error: DNSSoup.cpp:30: fatal error: CString.h: No such file or
directory
​https://bugs.webkit.org/show_bug.cgi?id=81093

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Philippe Normand.

Fix build error introduced by r110669.

  • platform/network/soup/DNSSoup.cpp:
6:01 AM Changeset in webkit [110696] by morrita@google.com
  • 95 edits
    20 adds
    17 deletes in trunk/LayoutTests

Unreviewed rebaseline update for <use> related SVG files.

  • platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/gradientLimit-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegionA-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/longTextOnPath-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-linux/svg/batik/text/textAnchor-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-linux/svg/batik/text/textLength-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textPosition-expected.png:
  • platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.png:
  • platform/chromium-linux/svg/batik/text/textProperties2-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textStyles-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textPosition-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-win/svg/batik/text/smallFonts-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
  • platform/chromium-win/svg/batik/text/textLength-expected.png:
  • platform/chromium-win/svg/batik/text/textLength-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition-expected.png:
  • platform/chromium-win/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.png:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/svg/batik/text/verticalText-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
  • platform/mac-future/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
5:41 AM Changeset in webkit [110695] by commit-queue@webkit.org
  • 7 edits in trunk/Source

WebHTTPBody: Keep track of whether the data includes passwords.
​https://bugs.webkit.org/show_bug.cgi?id=81003

Patch by Marja Hölttä <​marja@google.com> on 2012-03-14
Reviewed by Darin Fisher.

This change enables Chrome to save HTTP bodies selectively, only
if they don't contain passwords.

Source/WebCore:

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create): Check if the data contains passwords.

  • platform/network/FormData.cpp:

(WebCore::FormData::FormData): Added containsPasswordData, setContainsPasswordData.

  • platform/network/FormData.h:

(WebCore::FormData::containsPasswordData): Added.
(WebCore::FormData::setHasPasswordData): Added.
(FormData):

Source/WebKit/chromium:

  • public/platform/WebHTTPBody.h:

(WebHTTPBody): Added containsPasswordData, setContainsPasswordData.

  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::containsPasswordData): Added.
(WebKit):
(WebKit::WebHTTPBody::setContainsPasswordData): Added.

5:23 AM Changeset in webkit [110694] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: Add snippets tab to scripts navigator.
​https://bugs.webkit.org/show_bug.cgi?id=81018

Reviewed by Pavel Feldman.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
(WebInspector.ScriptsNavigator.prototype.focus):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._createFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._getOrCreateSnippetEvaluationsFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._scriptFolderIdentifier):
(WebInspector.NavigatorTreeOutline):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):

  • inspector/front-end/SnippetsModel.js:

LayoutTests:

  • http/tests/inspector/debugger-test.js:
5:03 AM Changeset in webkit [110693] by pfeldman@chromium.org
  • 41 edits
    1 delete in trunk

Web Inspector: Copy on the Console gives a mangled result.
​https://bugs.webkit.org/show_bug.cgi?id=81091

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):

LayoutTests:

  • http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt:
  • http/tests/inspector/console-xhr-logging-async-expected.txt:
  • http/tests/inspector/console-xhr-logging-expected.txt:
  • inspector/console/console-assert-expected.txt:
  • inspector/console/console-big-array-expected.txt:
  • inspector/console/console-clear-expected.txt:
  • inspector/console/console-command-clear-expected.txt:
  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-dirxml-expected.txt:
  • inspector/console/console-external-array-expected.txt:
  • inspector/console/console-format-collections-expected.txt:
  • inspector/console/console-format-expected.txt:
  • inspector/console/console-log-before-inspector-open-expected.txt:
  • inspector/console/console-log-document-proto-expected.txt:
  • inspector/console/console-log-syntax-error-expected.txt:
  • inspector/console/console-log-toString-object-expected.txt:
  • inspector/console/console-nested-group-expected.txt:
  • inspector/console/console-object-constructor-name-expected.txt:
  • inspector/console/console-repeat-count-expected.txt:
  • inspector/console/console-tests-expected.txt:
  • inspector/console/console-trace-expected.txt:
  • inspector/extensions/extensions-console-expected.txt:
  • platform/chromium/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
  • platform/chromium/http/tests/inspector/console-resource-errors-expected.txt:
  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
  • platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt:
  • platform/chromium/inspector/console/alert-toString-exception-expected.txt:
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/chromium/inspector/console/console-format-expected.txt:
  • platform/chromium/inspector/console/console-log-document-proto-expected.txt:
  • platform/chromium/inspector/console/console-log-syntax-error-expected.txt:
  • platform/chromium/inspector/console/console-object-constructor-name-expected.txt:
  • platform/chromium/inspector/console/console-trace-in-eval-expected.txt:
  • platform/chromium/inspector/console/console-uncaught-exception-expected.txt:
  • platform/chromium/inspector/console/console-uncaught-exception-in-eval-expected.txt:
  • platform/qt/inspector/console/console-format-expected.png: Removed.
5:00 AM Changeset in webkit [110692] by Nikolas Zimmermann
  • 17 edits
    2 adds in trunk

2012-03-14 Nikolas Zimmermann <​nzimmermann@rim.com>

External <use> xlink:href references do not work
​https://bugs.webkit.org/show_bug.cgi?id=12499

Reviewed by Zoltan Herczeg.

Rebaseline tests after r110676 using Generic RGB Profile on Lion, and update them after my fixes.
Replace xml:id with id everywhere, to make the new tiny tests work.

  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.png:
  • platform/mac/svg/batik/filters/filterRegions-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg:
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg:
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg:
  • svg/custom/use-external-crash-expected.txt: Added.
  • svg/custom/use-external-crash.svg: Added.

2012-03-14 Nikolas Zimmermann <​nzimmermann@rim.com>

External <use> xlink:href references do not work
​https://bugs.webkit.org/show_bug.cgi?id=12499

Reviewed by Zoltan Herczeg.

Follow-up fix after r110676.
Assertions are firing due last minute changes in isExternalURIReference.

Fix detecting local resources properly, when the given iri contains a /complex/path.
Use document->completeURL() instead, and compare with the document->url() to decide
if its a local reference or not.

If an external document load fails with an error (eg. file missing) don't assert
in debug builds, instead handle it gracefully.

I decided to clean the code up as well, to make it more safe & obvious.

Test: svg/custom/use-external-crash.svg

  • svg/SVGURIReference.cpp: (WebCore::SVGURIReference::targetElementFromIRIString):
  • svg/SVGURIReference.h: (WebCore::SVGURIReference::isExternalURIReference):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::externalDocument): (WebCore::SVGUseElement::buildPendingResource):
4:56 AM Changeset in webkit [110691] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

3D transformed surfaces with z>0 gets cropped
​https://bugs.webkit.org/show_bug.cgi?id=81009

Patch by Lars Knudsen <​lars.knudsen@nokia.com> on 2012-03-14
Reviewed by Noam Rosenthal.

The scissor clipping in TextureMapperGL didn't take 3D transforms
into account when calculating the clipping region.
Now, it will bail out early if the transform is not affine.

No new tests. Tested by current compositing layout tests.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::beginScissorClip):

4:47 AM Changeset in webkit [110690] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Rebaseline after r110667.

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-03-14
Reviewed by Csaba Osztrogonác.

  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
4:43 AM Changeset in webkit [110689] by kkristof@inf.u-szeged.hu
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed. Add platform specific expectaions after r110593

new file: LayoutTests/platform/qt/svg/custom/delete-text-crash-expected.png
new file: LayoutTests/platform/qt/svg/custom/delete-text-crash-expected.txt

4:39 AM Changeset in webkit [110688] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed flakiness marking.

  • platform/chromium/test_expectations.txt:
4:06 AM Changeset in webkit [110687] by morrita@google.com
  • 40 edits
    26 adds in trunk/LayoutTests

Unreviewed rebaselining expectations.

  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Added.
  • platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-linux/svg/batik/paints/gradientLimit-expected.txt: Added.
  • platform/chromium-linux/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegionA-expected.txt: Added.
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-linux/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-linux/svg/batik/text/textAnchor-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textLayout-expected.png:
  • platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textLength-expected.png:
  • platform/chromium-linux/svg/batik/text/textLength-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.png:
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-linux/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-linux/svg/batik/text/textProperties2-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/verticalText-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textLength-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/verticalText-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textLength-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textPosition2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/verticalText-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
3:44 AM Changeset in webkit [110686] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] svg/animations tests are very flaky
​https://bugs.webkit.org/show_bug.cgi?id=80703

Unreviewd, skipp svg/animations/animate-elem-08-t-drt.html

3:31 AM Changeset in webkit [110685] by kkristof@inf.u-szeged.hu
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed, rebaseline after r110587.

3:11 AM Changeset in webkit [110684] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix.

  • html/track/TextTrackList.cpp:

(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::owner): Changed return type from HTMLMediaElement* to Node* and uninlined.

  • html/track/TextTrackList.h:

(TextTrackList):

3:04 AM Changeset in webkit [110683] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [InspectorIndexedDB] Remote object should be released when data view is removed/updated.
​https://bugs.webkit.org/show_bug.cgi?id=81022

Reviewed by Pavel Feldman.

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDataView):
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataView.prototype.get statusBarItems):
(WebInspector.IDBDataView.prototype.clear):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBDatabaseTreeElement.prototype._objectStoreRemoved):
(WebInspector.IDBDatabaseTreeElement.prototype.clear):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBObjectStoreTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement.prototype._indexRemoved):
(WebInspector.IDBObjectStoreTreeElement.prototype.clear):
(WebInspector.IDBIndexTreeElement.prototype.onselect):
(WebInspector.IDBIndexTreeElement.prototype.clear):

3:02 AM Changeset in webkit [110682] by kkristof@inf.u-szeged.hu
  • 23 edits in trunk/LayoutTests

[Qt] Unreviewed. Update expectaions after r110676

2:59 AM Changeset in webkit [110681] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Introduce SnippetsScriptMapping.
​https://bugs.webkit.org/show_bug.cgi?id=80890

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype._mappingForScript):

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsModel.prototype.snippetForId):
(WebInspector.SnippetsModel.prototype.snippetForSourceURL):
(WebInspector.SnippetsScriptMapping):
(WebInspector.SnippetsScriptMapping.prototype.uiSourceCodeList):
(WebInspector.SnippetsScriptMapping.prototype.addScript):
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._releaseSnippetScript.get if):
(WebInspector.SnippetsScriptMapping.prototype._releaseSnippetScript):
(WebInspector.SnippetsScriptMapping.prototype._snippetDeleted.get this):
(WebInspector.SnippetsScriptMapping.prototype._snippetDeleted):
(WebInspector.SnippetsScriptMapping.prototype.reset):
(WebInspector.SnippetContentProvider):

2:38 AM Changeset in webkit [110680] by Philippe Normand
  • 29 edits in trunk/LayoutTests

Unreviewed, GTK svg rebaseline after r110676.

  • platform/gtk/svg/batik/filters/feTile-expected.txt:
  • platform/gtk/svg/batik/filters/filterRegions-expected.txt:
  • platform/gtk/svg/batik/masking/maskRegions-expected.txt:
  • platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textAnchor-expected.txt:
  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/batik/text/textEffect-expected.txt:
  • platform/gtk/svg/batik/text/textEffect2-expected.txt:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt:
  • platform/gtk/svg/batik/text/textFeatures-expected.txt:
  • platform/gtk/svg/batik/text/textLayout-expected.txt:
  • platform/gtk/svg/batik/text/textLayout2-expected.txt:
  • platform/gtk/svg/batik/text/textLength-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/gtk/svg/batik/text/textPosition-expected.txt:
  • platform/gtk/svg/batik/text/textPosition2-expected.txt:
  • platform/gtk/svg/batik/text/textProperties-expected.txt:
  • platform/gtk/svg/batik/text/textProperties2-expected.txt:
  • platform/gtk/svg/batik/text/textStyles-expected.txt:
  • platform/gtk/svg/batik/text/verticalText-expected.txt:
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/gtk/svg/hixie/error/014-expected.txt:
  • platform/gtk/svg/hixie/use/002-expected.txt:
2:08 AM Changeset in webkit [110679] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2012-03-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Update two pixel test results on Lion, now svg/ passes with --tolerance 0 again.

  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.png:
2:01 AM Changeset in webkit [110678] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Unreviewed, rolling out r110673.
​http://trac.webkit.org/changeset/110673
​https://bugs.webkit.org/show_bug.cgi?id=81090

"Qt minimal build broken" (Requested by yurys on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-14

  • inspector/CodeGeneratorInspector.py:

(CommandReturnPassModel.ByPointer.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(Generator.process_event):
(Generator.process_command):

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:

(ContentSearchUtils):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

1:55 AM Changeset in webkit [110677] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit/qt

Last buildfix for Qt after r110595. :)

Reviewed by Benjamin Poulain.

  • Api/qwebpage.cpp:
  • WebCoreSupport/GeolocationClientQt.h:
1:52 AM Changeset in webkit [110676] by reni@webkit.org
  • 73 edits
    36 adds in trunk

External <use> xlink:href references do not work
​https://bugs.webkit.org/show_bug.cgi?id=12499

Reviewed by Nikolas Zimmermann.

Source/WebCore:

This is a follow-up patch after r108785.
In this patch we bind the previously introduced CachedSVGDocument class
into the caching mechanism of SVGUseElement. The mode how external resources
are handled is similar to the processing of internal ones. We build the instance
and shadow tree the same way but we have to keep in mind that the requested resources
maybe not loaded yet. We can check it with cachedDocumentIsStillLoading() function.

SVGURIReference::targetElementFromIRIString() also need to be extended. The baseURI
computation needs to take the referenced documents URL into account, instead of the current documents.

The patch affects a lot of tests which have external resources especially in svg/batik. Because
of the size of that test refactor they will be commited in a follow-up patch.

Tests: svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg

svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg
svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg
svg/custom/use-extern-href.svg
svg/custom/use-referencing-an-image-expected.svg
svg/custom/use-referencing-an-image.svg
svg/custom/use-referencing-indirectly-itself-expected.svg
svg/custom/use-referencing-indirectly-itself.svg
svg/custom/use-referencing-itself-expected.svg
svg/custom/use-referencing-itself.svg
svg/dynamic-updates/SVGUseElement-dom-href1-attr.html
svg/dynamic-updates/SVGUseElement-dom-href2-attr.html
svg/dynamic-updates/SVGUseElement-svgdom-href1-prop.html
svg/dynamic-updates/SVGUseElement-svgdom-href2-prop.html

  • loader/cache/CachedResourceLoader.cpp:

(WebCore):
(WebCore::CachedResourceLoader::requestSVGDocument):

  • loader/cache/CachedResourceLoader.h:

(WebCore):
(CachedResourceLoader):

  • page/ContentSecurityPolicy.h:
  • platform/KURL.cpp:

(WebCore::equalIgnoringFragmentIdentifier):

  • platform/network/chromium/ResourceRequest.h:
  • svg/SVGURIReference.cpp:

(WebCore::urlFromIRIStringWithFragmentIdentifier):
(WebCore):
(WebCore::SVGURIReference::targetElementFromIRIString):

  • svg/SVGURIReference.h:

(SVGURIReference):
(WebCore::SVGURIReference::isExternalURIReference):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::~SVGUseElement):
(WebCore):
(WebCore::SVGUseElement::referencedDocument):
(WebCore::SVGUseElement::externalDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::hasCycleUseReferencing):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
(WebCore::SVGUseElement::notifyFinished):
(WebCore::SVGUseElement::cachedDocumentIsStillLoading):
(WebCore::SVGUseElement::instanceTreeIsLoading):

  • svg/SVGUseElement.h:

(WebCore):
(SVGUseElement):

LayoutTests:

Adding tests to check the new functionality of SVGUseElement what can use
sources from external URIs too. New tests in this patch cover the corner cases
of this feature: referencing resources directly and indirectly, changing
the referenced URI from an internal to an external one, handling
security issues like self referencing, self referencing across document, etc.
Furthermore the patch infer some rebaseline in svg/batik directory because
they use external resources.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
  • platform/mac/svg/batik/filters/feTile-expected.png:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.png:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/batik/paints/gradientLimit-expected.png:
  • platform/mac/svg/batik/paints/gradientLimit-expected.txt:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegionA-expected.png:
  • platform/mac/svg/batik/paints/patternRegionA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.png:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/mac/svg/batik/text/longTextOnPath-expected.png:
  • platform/mac/svg/batik/text/longTextOnPath-expected.txt:
  • platform/mac/svg/batik/text/smallFonts-expected.png:
  • platform/mac/svg/batik/text/smallFonts-expected.txt:
  • platform/mac/svg/batik/text/textAnchor-expected.png:
  • platform/mac/svg/batik/text/textAnchor-expected.txt:
  • platform/mac/svg/batik/text/textDecoration-expected.png:
  • platform/mac/svg/batik/text/textDecoration-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.png:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.png:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textLayout-expected.png:
  • platform/mac/svg/batik/text/textLayout-expected.txt:
  • platform/mac/svg/batik/text/textLayout2-expected.png:
  • platform/mac/svg/batik/text/textLayout2-expected.txt:
  • platform/mac/svg/batik/text/textLength-expected.png:
  • platform/mac/svg/batik/text/textLength-expected.txt:
  • platform/mac/svg/batik/text/textOnPath-expected.png:
  • platform/mac/svg/batik/text/textOnPath-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/textPosition-expected.png:
  • platform/mac/svg/batik/text/textPosition-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.png:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.png:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/batik/text/textProperties2-expected.png:
  • platform/mac/svg/batik/text/textProperties2-expected.txt:
  • platform/mac/svg/batik/text/textStyles-expected.png:
  • platform/mac/svg/batik/text/textStyles-expected.txt:
  • platform/mac/svg/batik/text/verticalText-expected.png:
  • platform/mac/svg/batik/text/verticalText-expected.txt:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/mac/svg/custom/use-extern-href-expected.png: Added.
  • platform/mac/svg/custom/use-extern-href-expected.txt: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
  • platform/mac/svg/hixie/error/014-expected.txt:
  • platform/mac/svg/hixie/use/002-expected.png:
  • platform/mac/svg/hixie/use/002-expected.txt:
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg: Added.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg: Added.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg: Added.
  • svg/batik/filters/filterRegions.svg:
  • svg/batik/text/textProperties.svg:
  • svg/batik/text/textProperties2.svg:
  • svg/batik/text/textStyles.svg:
  • svg/custom/resources/rgb.svg:
  • svg/custom/use-extern-href.svg: Added.
  • svg/custom/use-referencing-an-image-expected.svg: Added.
  • svg/custom/use-referencing-an-image.svg: Added.
  • svg/custom/use-referencing-indirectly-itself-expected.svg: Added.
  • svg/custom/use-referencing-indirectly-itself.svg: Added.
  • svg/custom/use-referencing-itself-expected.svg: Added.
  • svg/custom/use-referencing-itself.svg: Added.
  • svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGUseElement-dom-href1-attr.html: Added.
  • svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGUseElement-dom-href2-attr.html: Added.
  • svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGUseElement-svgdom-href1-prop.html: Added.
  • svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGUseElement-svgdom-href2-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGUseElement-dom-href1-attr.js: Added.

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGUseElement-dom-href2-attr.js: Added.

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href1-prop.js: Added.

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href2-prop.js: Added.

(repaintTest):

1:32 AM Changeset in webkit [110675] by Philippe Normand
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed, skip a new failing inspector test in GTK and add new
baseline for a svg test.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/delete-text-crash-expected.txt: Added.
1:18 AM Changeset in webkit [110674] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-14

  • DEPS:
1:04 AM Changeset in webkit [110673] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
​https://bugs.webkit.org/show_bug.cgi?id=80789

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-03-14
Reviewed by Yury Semikhatsky.

OptOutput class is added for optional return parameters.

Strict mode added to Generator that makes all parameter types strict
and drop pre-set default values for return parameters.

Debugger and Page domain is switched to strict mode.

  • inspector/CodeGeneratorInspector.py:

(CommandReturnPassModel.ByPointer):
(CommandReturnPassModel):
(CommandReturnPassModel.OptOutput):
(CommandReturnPassModel.OptOutput.init):
(CommandReturnPassModel.OptOutput.get_return_var_type):
(CommandReturnPassModel.OptOutput.get_output_argument_prefix):
(CommandReturnPassModel.OptOutput.get_output_to_raw_expression):
(CommandReturnPassModel.OptOutput.get_output_parameter_type):
(CommandReturnPassModel.OptOutput.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(OptOutput):
(Generator.process_event):
(Generator.process_command):

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:

(ContentSearchUtils):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

1:04 AM Changeset in webkit [110672] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r110667.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
12:32 AM Changeset in webkit [110671] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Build fix for EFL after r110669.

  • PlatformEfl.cmake: added DNSSoup.cpp
12:31 AM Changeset in webkit [110670] by tkent@chromium.org
  • 1 edit
    2 copies in branches/chromium/1025

Merge 110226 - NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
​https://bugs.webkit.org/show_bug.cgi?id=80648

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/events/input-element-display-none-in-dragleave-crash.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setCanReceiveDroppedFiles): NULL-check renderer().

LayoutTests:

  • fast/events/input-element-display-none-in-dragleave-crash-expected.txt: Added.
  • fast/events/input-element-display-none-in-dragleave-crash.html: Added.
  • platform/wk2/Skipped: WebKitTestRunner doesn't support

EventSender.beginDragWithFiles().

TBR=​tkent@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9699014

12:23 AM Changeset in webkit [110669] by sergio@webkit.org
  • 11 edits
    1 copy in trunk/Source/WebCore

[GTK] Use the same DNS prefetching path than the other ports.
​https://bugs.webkit.org/show_bug.cgi?id=80997

Reviewed by Martin Robinson.

This patch basically reverts r56128. There is no need to add an
special code path for GTK+ DNS pre-fetching because the main
reason to do that (some potential changes in libsoup) is not
going to happen. It also reduces the amount of DNS queries by
adding a NULL hostname check.

No need for new tests as this just moves code around.

  • GNUmakefile.list.am:
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

  • html/HTMLLinkElement.cpp:
  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

  • page/Chrome.cpp:

(WebCore::Chrome::mouseDidMoveOverElement):

  • platform/network/DNS.h:

(WebCore):

  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:

(ResourceHandle):

  • platform/network/chromium/DNSChromium.cpp:
  • platform/network/soup/DNSSoup.cpp: restored.

(WebCore):
(WebCore::prefetchDNS):

  • platform/network/soup/ResourceHandleSoup.cpp:
12:11 AM Changeset in webkit [110668] by commit-queue@webkit.org
  • 2 edits in trunk

GTK 32-bit Linux Release build failing after r110580 (from bug 80338)
​https://bugs.webkit.org/show_bug.cgi?id=81063

Prospective build fix for GTK 32-bit Linux Release.

Patch by Max Vujovic <​mvujovic@adobe.com> on 2012-03-14
Reviewed by Martin Robinson.

  • Source/autotools/symbols.filter: Adding symbol for ClientRectList(Vector<FloatQuad>) for

GTK 32-bit.

12:06 AM Changeset in webkit [110667] by haraken@chromium.org
  • 10 edits in trunk

Return null when shouldAllowAccessToNode() fails
​https://bugs.webkit.org/show_bug.cgi?id=80205

Reviewed by Adam Barth.

shouldAllowAccessToNode() is used for window.frameElement, HTMLFrameElement.contentDocument,
and getSVGDocument(). The spec of window.frameElement and HTMLFrameElement.contentDocument
requires that they should return null when the security check fails.
Thus this patch changes the return value from undefined to null.

​http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#navigating-nested-browsing-contexts-in-the-dom
​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-iframe-contentdocument

Source/WebCore:

Tests: http/tests/security/local-iFrame-from-remote.html

http/tests/security/cross-frame-access-frameelement.html
http/tests/security/cross-frame-access-put.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp: Updated run-bindings-tests results.

(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::contentDocumentAttrGetter):
(WebCore::TestObjInternal::getSVGDocumentCallback):

LayoutTests:

  • http/tests/security/cross-frame-access-frameelement-expected.txt:
  • http/tests/security/local-iFrame-from-remote.html:
  • platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
12:02 AM Changeset in webkit [110666] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, mark verifyCullChildLinesUpTopLeft() as failed.

  • tests/CCQuadCullerTest.cpp:

(WebCore):
(WebCore::TEST):

Mar 13, 2012:

11:54 PM Changeset in webkit [110665] by commit-queue@webkit.org
  • 19 edits in trunk

Source/WebCore: [Forms] Hidden input element should not have labels.
​https://bugs.webkit.org/show_bug.cgi?id=80403

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes "labels" attribute behavior for hidden input type.
It returns null instead of NodeList of labels or empty node list.

Note: The HTML5 specification isn't clear for non-labelable element's "labels"
attribute return value. Firefox and Opera return empty node list. IE returns null.

No new tests. Existing tests are updated.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isLabelable): Added. Dispatch to InputType.

  • html/HiddenInputType.h: Added isLabelable returning false.
  • html/InputType.cpp:

(WebCore::InputType::isLabelable): Added. Returning true for all input types except for "hidden" type.
(WebCore):

  • html/InputType.h:

(InputType): Added isLabelable declaration.

LayoutTests: [Forms] Hidden input element should not have labels.
​https://bugs.webkit.org/show_bug.cgi?id=80403

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes expected text for null value of labels attribute
of hidden input type and labelable-elements to check null value for
the labels attribute of input type.

  • fast/forms/label/labelable-elements-expected.txt:
  • fast/forms/label/labelable-elements.html:
  • fast/forms/label/labels-add-htmlFor-label-expected.txt:
  • fast/forms/label/labels-add-parent-label-expected.txt:
  • fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-multiple-sibling-labels-expected.txt:
  • fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-label-expected.txt:
  • fast/forms/label/labels-remove-parent-label-expected.txt:
  • fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
  • platform/chromium/fast/forms/label/labelable-elements-expected.txt:
  • platform/mac/fast/forms/label/labelable-elements-expected.txt:
11:35 PM Changeset in webkit [110664] by commit-queue@webkit.org
  • 15 edits in trunk

[Forms] The "output" element should have labels.
​https://bugs.webkit.org/show_bug.cgi?id=80466

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

Source/WebCore:

This patch enables functionality of "labels" attribute for
HTMLOutputElement implemented in LabelableElement which use
isLabelable predicate whether an element can have label or not.

Update existing tests in fast/forms/label/ directory to cover
the "output" element with the "labels" attribute.

  • html/HTMLOutputElement.h: Implement virtual method isLabelable.

LayoutTests:

This patch updates expectation for functioning the "labels"
attribute of the "output" elements which was not working
so far.

  • fast/forms/label/labelable-elements-expected.txt:
  • fast/forms/label/labels-add-htmlFor-label-expected.txt:
  • fast/forms/label/labels-add-parent-label-expected.txt:
  • fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-multiple-sibling-labels-expected.txt:
  • fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-label-expected.txt:
  • fast/forms/label/labels-remove-parent-label-expected.txt:
  • fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
  • platform/chromium/fast/forms/label/labelable-elements-expected.txt:
  • platform/mac/fast/forms/label/labelable-elements-expected.txt
11:24 PM Changeset in webkit [110663] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking some tests flaky.

  • platform/chromium/test_expectations.txt:
8:19 PM Changeset in webkit [110662] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Move opacity clamping into RenderStyle setter.
​https://bugs.webkit.org/show_bug.cgi?id=76966

Reviewed by Eric Seidel.

Covered by existing tests.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::setOpacity):

7:54 PM Changeset in webkit [110661] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

ValueToInt32 speculation will cause OSR exits even when it does not have to
​https://bugs.webkit.org/show_bug.cgi?id=81068
<rdar://problem/11043926>

Reviewed by Anders Carlsson.

Two related changes:
1) ValueToInt32 will now always just defer to the non-speculative path, instead

of exiting, if it doesn't know what speculations to perform.

2) ValueToInt32 will speculate boolean if it sees this to be profitable.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateBoolean):
(Node):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):

7:47 PM Changeset in webkit [110660] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

More Windows build fixing

7:40 PM Changeset in webkit [110659] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix

7:28 PM Changeset in webkit [110658] by cevans@google.com
  • 3 edits
    3 copies in branches/chromium/1025

Merge 110593
BUG=112317
Review URL: ​https://chromiumcodereview.appspot.com/9703008

7:12 PM Changeset in webkit [110657] by mhahnenberg@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Type conversion of exponential part failed
​https://bugs.webkit.org/show_bug.cgi?id=80673

Reviewed by Geoffrey Garen.

  • parser/Lexer.cpp:

(JSC::::lex):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseInt):
(JSC):
(JSC::jsStrDecimalLiteral): Added another template argument that exposes whether or not
we accept trailing junk to clients of jsStrDecimalLiteral. Also added additional template
parameter for strtod to allow trailing spaces.
(JSC::toDouble):
(JSC::parseFloat): Accept trailing junk, as per the ECMA 262 spec (15.1.2.3).

  • runtime/LiteralParser.cpp:

(JSC::::Lexer::lexNumber):

  • tests/mozilla/expected.html: Update the expected page for run-javascriptcore-tests so that

we will run ecma/TypeConversion/9.3.1-3.js as a regression test now.

  • wtf/dtoa.cpp:

(WTF):
(WTF::strtod): We also needed to sometimes accept trailing spaces to pass a few other tests that were
broken by changing the default allowance of trailing junk in jsStrDecimalLiteral.

  • wtf/dtoa.h:
  • wtf/dtoa/double-conversion.cc: When the AdvanceToNonspace function was lifted out of the

Chromium codebase, the person porting it only thought to check for spaces when skipping whitespace.
A few of our JSC tests check for other types of trailing whitespace, so I've added checks for those
here to cover those cases (horizontal tab, vertical tab, carriage return, form feed, and line feed).

  • wtf/text/WTFString.cpp:

(WTF::toDoubleType): Disallow trailing spaces, as this breaks form input verification stuff.

6:38 PM Changeset in webkit [110656] by igor.o@sisa.samsung.com
  • 3 edits in trunk/Source/WebCore

Split the extra logic out of RenderObjectChildList::updateBeforeAfterContent
​https://bugs.webkit.org/show_bug.cgi?id=80856

Extra part of the generated content handling logic out of RenderObjectChildList::updateBeforeAfterContent

Reviewed by Julien Chaffraix.

No change in behavior expected.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterStyle):
(WebCore::createRenderForBeforeAfterContent):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):

  • rendering/RenderObjectChildList.h:

(WebCore):
(RenderObjectChildList):

6:37 PM Changeset in webkit [110655] by ojan@chromium.org
  • 131 edits
    112 copies
    18 moves
    54 adds
    23 deletes in trunk/LayoutTests

FREEEEEDOOM!!! Last set of bulk Chromium-Lion rebaselines.

6:26 PM Changeset in webkit [110654] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix since is_pod<> includes some header that I didn't know about.
Removing the assert for now.

  • dfg/DFGOperations.h:
  • llint/LLIntSlowPaths.h:
6:09 PM Changeset in webkit [110653] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Find bouncy doesn’t hide when a subframe is scrolled
​https://bugs.webkit.org/show_bug.cgi?id=81060
<rdar://problem/9365329>

Reviewed by Andreas Kling.

Instead of hiding the find indicator when pageDidScroll is called, add a check to FindController::drawRect and hide
the find indicator there if the find selection bounds have changed since the last call to drawRect.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::drawRect):

  • WebProcess/WebPage/FindController.h:

(FindController):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pageDidScroll):

6:07 PM Changeset in webkit [110652] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs a more-complete implementation of eventSender.
​https://bugs.webkit.org/show_bug.cgi?id=42194

Skip yet another test that uses eventSender.

  • platform/wk2/Skipped:
5:46 PM Changeset in webkit [110651] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Functions with C linkage should return POD types
​https://bugs.webkit.org/show_bug.cgi?id=81061

Reviewed by Mark Rowe.

  • dfg/DFGOperations.h:
  • llint/LLIntSlowPaths.h:

(LLInt):
(SlowPathReturnType):
(JSC::LLInt::encodeResult):

5:36 PM Changeset in webkit [110650] by arv@chromium.org
  • 14 edits in trunk/LayoutTests

Remove duplicate GC functions from layout tests
​https://bugs.webkit.org/show_bug.cgi?id=81047

Reviewed by Ojan Vafai.

  • fast/canvas/webgl/shader-deleted-by-accessor.html:
  • fast/dom/Window/customized-property-survives-gc.html:
  • fast/dom/inline-event-attributes-lookup-removed-form.html:
  • fast/dom/inline-event-attributes-lookup-removed.html:
  • fast/dom/shadow/gc-shadow.html:
  • fast/filesystem/resources/file-writer-gc-blob.js:
  • fast/forms/input-image-submit.html:
  • fast/forms/interactive-validation-remove-node-in-handler.html:
  • fast/forms/select-set-length-with-mutation-remove.html:
  • fast/js/resources/js-test-pre.js:

(gc.else.gcRec):
(gc):

  • http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html:
  • http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html:
  • webaudio/mediaelementaudiosourcenode-gc.html:
5:31 PM Changeset in webkit [110649] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.setEditingBehavior
​https://bugs.webkit.org/show_bug.cgi?id=42689

Add more tests that use setEditingBehavior to the wk2 Skipped list.

  • platform/wk2/Skipped:
5:28 PM Changeset in webkit [110648] by enne@google.com
  • 3 edits in trunk/LayoutTests

[chromium] Unreviewed, rebaseline fast/canvas/canvas-text-alignment
​https://bugs.webkit.org/show_bug.cgi?id=78529

After r110620, root layer scrollbars are drawn opaque, so they no
longer differ between debug and release due to alpha values.
Rebaselining this test.

  • platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium/test_expectations.txt:
5:27 PM Changeset in webkit [110647] by ap@apple.com
  • 2 edits in trunk/LayoutTests
  • platform/mac/fast/js/global-constructors-expected.txt: Added Selection.toString and WebKitMutationObserver.toString. Selection got exposed in <​http://trac.webkit.org/changeset/109306>, and WebKitMutationObserver was probably failing for even longer.
5:18 PM Changeset in webkit [110646] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix potential crash when loading test results
​https://bugs.webkit.org/show_bug.cgi?id=81062
<rdar://problem/11041732>

Reviewed by Dean Jackson.

If RenderLayerBacking::isSimpleContainerCompositingLayer() is called early,
before the document has a documentElement(), then it crashes. Fix with
a null check on documentElement().

No test because it's timing dependent.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

5:08 PM Changeset in webkit [110645] by timothy_horton@apple.com
  • 3 edits in trunk/LayoutTests

platform/mac/fast/forms/input-appearance-spinbutton(-up) fail on Lion
​https://bugs.webkit.org/show_bug.cgi?id=81058

Add unreviewed expected failing result (which may actually be correct) for mac.

  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
5:06 PM Changeset in webkit [110644] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

MediaStream is not enabled on Mac. Skip all related tests.

  • platform/mac/Skipped:
4:58 PM Changeset in webkit [110643] by mitz@apple.com
  • 3 edits
    1 add in trunk
<rdar://problem/11025225> Assertion failure in RenderView::computeRectForRepaint() (!repaintContainer
repaintContainer == this) at store.apple.com

​https://bugs.webkit.org/show_bug.cgi?id=81051

Reviewed by Simon Fraser.

.:

  • ManualTests/inline-repaint-container.html: Added.

Source/WebCore:

Test: ManualTests/inline-repaint-container.html.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint): This function was not handling the
case of the repaint container being a descendant of the containing block correctly, leading
to the assertion failure, but also to a correctness bug seen in the new test. If the repaint
container is a descendant of the containing block, just return the rect in the repaint
container coordinates.

4:57 PM Changeset in webkit [110642] by mitz@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/11025217> [Mac] Assertion failure in collectComplexTextRunsForCharactersCoreText
​https://bugs.webkit.org/show_bug.cgi?id=77044

Reviewed by Sam Weinig.

Source/WebCore:

Test: platform/mac/fast/text/core-text-fallback-to-unknown-font.html

Handle the case of Core Text choosing a fallback font that NSFontManager cannot find by name.

  • platform/graphics/FontCache.h:

(FontCache): Made ComplexTextController a friend class.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Removed the
failing assertion, which was not true, and added code to handle the case where a font
cannot be found by name by using the font as returned from Core Text.

LayoutTests:

  • platform/mac/fast/text/core-text-fallback-to-unknown-font-expected.txt: Added.
  • platform/mac/fast/text/core-text-fallback-to-unknown-font.html: Added.
4:56 PM Changeset in webkit [110641] by arv@chromium.org
  • 43 edits
    2 deletes in trunk

[V8] Use v8::V8::AddImplicitReferences instead of SetHiddenValue
​https://bugs.webkit.org/show_bug.cgi?id=80880

Reviewed by Adam Barth.

Source/WebCore:

We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.

To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8). Interfaces that have *IsReachable
also have a dependent life time (just like if V8DependentLifetime was present).

Second try. This time with an added include in TextTrackList.cpp.

No new tests. Covered by existing tests.

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorJS.pm:

(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
  • bindings/v8/custom/V8DOMStringMapCustom.cpp:
  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • css/CSSStyleSheet.idl:
  • css/StyleSheet.idl:
  • dom/DOMStringMap.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/track/TextTrackList.cpp:
  • html/track/TextTrackList.idl:

LayoutTests:

  • platform/chromium/test_expectations.txt:
4:45 PM Changeset in webkit [110640] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

MathML crash in WebCore::Node::previousSibling()
​https://bugs.webkit.org/show_bug.cgi?id=80773

Patch by Jacky Jiang <​zhajiang@rim.com> on 2012-03-13
Reviewed by Julien Chaffraix.

Source/WebCore:

When adding child for msub render, if the child is mtr or mtd render,
we will creat an anonymous render as the container. As the anonymous
render's node is 0, accessing it directly can cause crash.
We should do a valid check of the node before using. In addition to
that, for msub, attach the anonymous render and it's children to render
tree. For msubsup, such kind of situation should never happen based on
the current codebase.

Test: mathml/msub-anonymous-child-render-crash.html

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::addChild):

LayoutTests:

  • mathml/msub-anonymous-child-render-crash-expected.txt: Added.
  • mathml/msub-anonymous-child-render-crash.html: Added.
4:43 PM Changeset in webkit [110639] by mihnea@adobe.com
  • 17 edits
    14 deletes in trunk

[CSSRegions]NamedFlow::getRegionsByContentNode should not return a live NodeList
​https://bugs.webkit.org/show_bug.cgi?id=81021

Reviewed by Ryosuke Niwa.

Reverting the original patch as we need a better solution.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Node.cpp:

(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::isEmpty):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:

(NodeListsNodeData):

  • dom/RegionNodeList.cpp: Removed.
  • dom/RegionNodeList.h: Removed.
  • dom/WebKitNamedFlow.cpp:
  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • rendering/RenderFlowThread.cpp:
  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

  • fast/regions/get-regions-by-content-node-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-horiz-bt.html: Removed.
  • fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-horiz-tb.html: Removed.
  • fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-vert-lr.html: Removed.
  • fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-vert-rl.html: Removed.
  • fast/regions/get-regions-by-content-node.html: Removed.
  • fast/regions/get-regions-by-content-node2-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node2.html: Removed.
4:39 PM Changeset in webkit [110638] by jeffm@apple.com
  • 8 edits in trunk/Source/WebKit2

Support loading a WKPage from web archive data
​https://bugs.webkit.org/show_bug.cgi?id=81044

This code was written by Jessie Berlin.

Reviewed by Brady Eidson.

  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadWebArchiveData): Added.

  • UIProcess/API/C/WKPage.h: Added WKPageLoadWebArchiveData().


  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadWebArchiveData): Added.

  • UIProcess/WebPageProxy.h: Added loadWebArchiveData().
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadWebArchiveData): Added.

  • WebProcess/WebPage/WebPage.h: Added loadWebArchiveData().
  • WebProcess/WebPage/WebPage.messages.in: Added LoadWebArchiveData message.
4:31 PM Changeset in webkit [110637] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note that this test is flaky. The flakiness dashboard says that this
test has been flaky for a while.

  • platform/chromium/test_expectations.txt:
4:28 PM Changeset in webkit [110636] by abarth@webkit.org
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

Add a Leopard-specific baseline for
fast/forms/file/file-input-pressed-state and generalize the
chromium-win-vista baseline to include all of windows.

  • platform/chromium-mac-leopard/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-win-vista/fast/forms/file: Removed.
  • platform/chromium-win-vista/fast/forms/file/file-input-pressed-state-expected.png: Removed.
  • platform/chromium-win-xp/fast/forms/file: Removed.
  • platform/chromium-win/fast/forms/file/file-input-pressed-state-expected.png: Added.
4:28 PM Changeset in webkit [110635] by shawnsingh@chromium.org
  • 6 edits in trunk/Source

[chromium] wrong transform causing incorrect culling
​https://bugs.webkit.org/show_bug.cgi?id=80471

Reviewed by James Robinson.

Source/WebCore:

Unit test added to CCRenderSurfaceTest.cpp

In addition to using originTransform() instead of drawTransform(),
this patch shuffles a bit of code so that a unit test can be
easily added.

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCRenderSurfaceTest.cpp:

(WebCore::TEST):
(WebCore):

4:18 PM Changeset in webkit [110634] by tony@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

more multiline flexbox tests
​https://bugs.webkit.org/show_bug.cgi?id=81025

Reviewed by Ojan Vafai.

Add a test case for wrap-reverse to verify that we align with the end of the flexbox.

  • css3/flexbox/multiline-reverse-wrap-overflow-expected.txt: Added.
  • css3/flexbox/multiline-reverse-wrap-overflow.html: Added.
4:11 PM Changeset in webkit [110633] by darin@chromium.org
  • 2 edits in trunk/LayoutTests

fast/loader/form-submission-after-beforeunload-cancel.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=81024

Reviewed by Andy Estes.

  • fast/loader/form-submission-after-beforeunload-cancel.html:

Give the form post a better chance of loading before the FAIL timer.

4:00 PM Changeset in webkit [110632] by tomz@codeaurora.org
  • 4 edits
    2 adds in trunk

Alternate xml-stylesheets with no title are loaded, in violation of the CSSOM draft
​https://bugs.webkit.org/show_bug.cgi?id=77549

Patch by Dave Tharp <​dtharp@codeaurora.org> on 2012-03-13
Reviewed by David Hyatt.

Source/WebCore:

Amended code to ignore alternate stylesheets that do not have a title attribute.

Test: fast/css/xml-stylesheet-alternate-no-title.xhtml

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

LayoutTests:

Added new text test, modified existing test: added title attribute to alternate stylesheet.

  • fast/css/xml-stylesheet-alternate-no-title-expected.txt: Added.
  • fast/css/xml-stylesheet-alternate-no-title.xhtml: Added.
  • fast/css/xml-stylesheet-alternate-processing.xhtml:
3:59 PM Changeset in webkit [110631] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Loads from UInt32Arrays should not result in a double up-convert if it isn't necessary
​https://bugs.webkit.org/show_bug.cgi?id=80979
<rdar://problem/11036848>

Reviewed by Oliver Hunt.

Also improved DFG IR dumping to include type information in a somewhat more
intuitive way.

  • bytecode/PredictedType.cpp:

(JSC::predictionToAbbreviatedString):
(JSC):

  • bytecode/PredictedType.h:

(JSC):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

3:57 PM Changeset in webkit [110630] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Input focus state should unfocus the frame selection instead of the field.
​https://bugs.webkit.org/show_bug.cgi?id=81023

Patch by Mike Fenton <​mifenton@rim.com> on 2012-03-13
Reviewed by Antonio Gomes.

PR 137400.

Prevent cursor drawing by unfocusing the frame selection
when input mode is not ready.

Greatly simplify the decision to focus input fields by removing
all ties to the page load state and base it on input. Input mode
is disabled when a page load begins and enabled on any user input.

The field is focused and ready for input immediately, only the
frame selection (or cursor) is unfocused.

Reviewed Internally by Gen Mak, Antonio Gomes and Nima Ghanavatian.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

  • Api/WebPageClient.h:
  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldBeginEditing):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::enableInputMode):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::InputHandler::setComposingText):

  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

3:53 PM Changeset in webkit [110629] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

Revert RenderLayer::absoluteBoundingBox to an IntRect
​https://bugs.webkit.org/show_bug.cgi?id=81017

Reviewed by Eric Seidel.

Reverting RenderLayer::absoluteBoundingBox to an (pixel snapped) IntRect. Whenever
possible, we use integers representing for absolute coordinates. This is especially
relevant for methods, such as this one, that are exported and used in platform code.

No new tests. No change in behavior.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::absoluteBoundingBox):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition): This intersects
the absolute bounding box with the FrameView, which uses all integer values. It's
the only use of absoluteBoundingBox in WebCore.

3:51 PM Changeset in webkit [110628] by ap@apple.com
  • 1 edit
    7 adds in trunk/LayoutTests

Adding missing results.

  • platform/mac/media/audio-repaint-expected.txt: Added.
  • platform/mac/media/controls-strict-expected.txt: Added.
  • platform/mac/media/video-controls-rendering-expected.txt: Added.
  • platform/mac/media/video-no-audio-expected.txt: Added.
  • platform/mac/media/video-display-toggle-expected.txt: Added. These already had PNG results, but no text results for platform/mac.
  • platform/mac/media/controls-layout-direction-expected.png: Added.
  • platform/mac/media/video-playing-and-pause-expected.png: Added. These had text results, but no pixel ones.
3:50 PM Changeset in webkit [110627] by nduca@chromium.org
  • 4 edits in trunk/Source

[chromium] vsync ticks are needed in invisible tabs when we are still updating resources
​https://bugs.webkit.org/show_bug.cgi?id=80910

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):

Source/WebKit/chromium:

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):
(WebCore):

3:40 PM Changeset in webkit [110626] by commit-queue@webkit.org
  • 3 edits
    14 adds in trunk

Alternate stylesheets (without title attribute) are loaded on refresh
​https://bugs.webkit.org/show_bug.cgi?id=24354

Patch by Dave Tharp <​dtharp@codeaurora.org> on 2012-03-13
Reviewed by David Hyatt.

Source/WebCore:

Alternate stylesheets are now ignored in <link> tags if
they have no title attribute (per spec).

Tests: fast/css/link-alternate-stylesheet-1.html

fast/css/link-alternate-stylesheet-2.html
fast/css/link-alternate-stylesheet-3.html
fast/css/link-alternate-stylesheet-4.html
fast/css/link-alternate-stylesheet-5.html

  • dom/Document.cpp:

(WebCore::Document::collectActiveStylesheets):

LayoutTests:

Addapted alternate stylesheet tests from ​http://robballou.com/switcher/sandbox/alternate1.php

  • fast/css/link-alternate-stylesheet-1-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-1.html: Added.
  • fast/css/link-alternate-stylesheet-2-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-2.html: Added.
  • fast/css/link-alternate-stylesheet-3-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-3.html: Added.
  • fast/css/link-alternate-stylesheet-4-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-4.html: Added.
  • fast/css/link-alternate-stylesheet-5-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-5.html: Added.
  • fast/css/resources/basic.css: Added.

(body):
(code):
(#source):

  • fast/css/resources/high.css: Added.

(body):
(h1):

  • fast/css/resources/normal.css: Added.

(body):
(h1):

  • fast/css/resources/small.css: Added.

(body):

3:36 PM Changeset in webkit [110625] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WKTR needs an implementation of setAsynchronousSpellCheckingEnabled.
​https://bugs.webkit.org/show_bug.cgi?id=81042

Skip some tests on Mac WK2 that use setAsynchronousSpellCheckingEnabled.

  • platform/mac-wk2/Skipped:
3:35 PM Changeset in webkit [110624] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

Region::contains(IntPoint) is slow
​https://bugs.webkit.org/show_bug.cgi?id=81008

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-13
Reviewed by Anders Carlsson.

Source/WebCore:

Speed up Region::contains(IntPoint) by directly testing if the point
is inside the Region's shape, rather than using a temporary 1x1 Region
for the test.

Unit test: RegionTest.containsPoint

  • platform/graphics/Region.cpp:

(WebCore::Region::contains):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/RegionTest.cpp: Added.

(WebCore):
(WebCore::TEST):

3:32 PM Changeset in webkit [110623] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Copy the platform-independent result for this test to chromium-mac to
hide the failing result added to apple-mac in
​http://trac.webkit.org/changeset/110614.

  • platform/chromium/fast/forms/label: Added.
  • platform/chromium/fast/forms/label/labelable-elements-expected.txt: Added.
3:21 PM Changeset in webkit [110622] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

For some reason chromium-win and chromium-linux have a different number
of spaces in the expected results file.

  • platform/chromium-win/media/sources-fallback-codecs-expected.txt: Added.
3:13 PM Changeset in webkit [110621] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Merge expectations for
svg/as-background-image/svg-as-background-6.html. Previously, Snow
Leopard had different expectations than every other platform, but the
behavior seems to match the expectations for other platforms.

Really what's going on is that this is a bad test for the reasons
explained in the test_expectations.txt file. I'm not entirely sure how
to fix the test to have repeatable results.

This patch also notes some more compositing reflection tests as flaky,
similar to the failures in
​https://bugs.webkit.org/show_bug.cgi?id=79823. These tests have been
flaky for a while, but they seem to be failing more frequently now. I
couldn't find any recent changes to explain why that might be.

  • platform/chromium/test_expectations.txt:
3:06 PM Changeset in webkit [110620] by enne@google.com
  • 4 edits in trunk

[chromium] Mark root layer scrollbars as always opaque to disable blending
​https://bugs.webkit.org/show_bug.cgi?id=79951

Reviewed by James Robinson.

Source/WebCore:

Now that scrollbar layers exist, mark non-overlay root scrollbars as
opaque. This disables blending for correctness and performance.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::scrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTileQuad):

LayoutTests:

Mark canvas-text-alignment.html as failing on Linux in general, not
just in debug. I believe that with this change, the same image will
pass on both release and debug, but will land that change separately.

  • platform/chromium/test_expectations.txt:
2:59 PM Changeset in webkit [110619] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL][DRT] Expose window.internals object
​https://bugs.webkit.org/show_bug.cgi?id=79900

Exposes window.internals for EFL's DRT. Makes possible to
remove some tests from the skip list.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-03-13
Reviewed by Antonio Gomes.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWindowObjectCleared):

LayoutTests:

  • platform/efl/Skipped:
2:59 PM Changeset in webkit [110618] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove vestigal abortEvent from image attribute.
​https://bugs.webkit.org/show_bug.cgi?id=80795

Reviewed by Adam Barth.

It seems we installed a listener for the abort event on images,
but never ever raised them. So this patch removes it. This could
cause different behaviour if the user sends abort events directly
at an image element, although addEventListener will still work.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

2:52 PM Changeset in webkit [110617] by staikos@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

The callback is only used if SA_RESTART is defined. Compile it out
otherwise to avoid a warning.
​https://bugs.webkit.org/show_bug.cgi?id=80926

Reviewed by Alexey Proskuryakov.

  • heap/MachineStackMarker.cpp:

(JSC):

2:51 PM Changeset in webkit [110616] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add a mac-specific baseline for this new test introduced in
​http://trac.webkit.org/changeset/110593. This test is interested in
whether it crashes, not in a 1px difference in text metrics.

  • platform/chromium-mac-snowleopard/svg/custom/delete-text-crash-expected.txt: Added.
2:48 PM Changeset in webkit [110615] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove bogus expectation.

  • platform/chromium-mac/fast/dom/nodesFromRect-basic-expected.txt: Removed.
2:43 PM Changeset in webkit [110614] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

r110542: New fast/forms/label/labelable-elements.html fails.
​https://bugs.webkit.org/show_bug.cgi?id=80985

Add failing expected results for Mac to get the bots green.

  • platform/mac/fast/forms/label/labelable-elements-expected.txt: Added.
2:42 PM Changeset in webkit [110613] by abarth@webkit.org
  • 1 edit
    3 adds
    1 delete in trunk/LayoutTests

Add image baselines after ​http://trac.webkit.org/changeset/110598.
These tests show the platform-specific file chooser UI.

  • platform/chromium-linux-x86/fast/forms/file: Removed.
  • platform/chromium-linux/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-win-vista/fast/forms/file/file-input-pressed-state-expected.png: Added.
2:37 PM Changeset in webkit [110612] by timothy_horton@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

css3/filters/custom/custom-filter-property-computed-style.html passes in browser, fails in DRT
​https://bugs.webkit.org/show_bug.cgi?id=81029
<rdar://problem/11040673>

Add unreviewed expected failing result for mac.

  • platform/mac/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
2:36 PM Changeset in webkit [110611] by ojan@chromium.org
  • 279 edits
    180 copies
    32 moves
    117 adds
    1 delete in trunk/LayoutTests

Chromium-Lion rebaselines.

2:30 PM Changeset in webkit [110610] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Attempt to fix QtMinimal bot after r110595

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-03-13

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

2:22 PM Changeset in webkit [110609] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Another attempt at fixing QtMinimal bot after r110595

Blind fix, unreviewed.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-03-13

  • WebCoreSupport/GeolocationClientQt.h:
2:18 PM Changeset in webkit [110608] by Nate Chapin
  • 5 edits
    3 adds in trunk

Source/WebCore: Rework how a CachedRawResource decides if it can be reused
for a given ResourceRequest. Ensure method, body, cookie policy,
and all headers match.
​http://bugs.webkit.org/show_bug.cgi?id=79325

Reviewed by Oliver Hunt.

Test: http/tests/cache/xhr-body.html

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::canReuse):

  • loader/cache/CachedRawResource.h: Take a ResourceRequest in canReuse().
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy): Remove Range header

check, since it is now redundant.

LayoutTests: Test for ​http://bugs.webkit.org/show_bug.cgi?id=79325.

Reviewed by Oliver Hunt.

  • http/tests/cache/resources/body.php: Added.
  • http/tests/cache/xhr-body-expected.txt: Added.
  • http/tests/cache/xhr-body.html: Added.
2:15 PM Changeset in webkit [110607] by ap@apple.com
  • 6 edits
    1 delete in trunk/LayoutTests

Updating some Mac results in media directory.

  • platform/chromium-mac/media/sources-fallback-codecs-expected.txt: Removed.
  • media/sources-fallback-codecs-expected.txt: Chromium result just matched what actually happened on Mac, so merging it into cross-platform.
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/media-controls-clone-expected.txt:
  • platform/mac/media/video-playing-and-pause-expected.txt: Updated for render tree changes. I'm getting the same results locally as buildbot does.
2:12 PM Changeset in webkit [110606] by timothy_horton@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed rebaseline of fast/css/getComputedStyle/computed-style(without-renderer).html for mac, adding -webkit-grid-*

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
2:10 PM Changeset in webkit [110605] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Dump the generated code for ARM_TRADITIONAL
​https://bugs.webkit.org/show_bug.cgi?id=80975

Patch by Hojong Han <​hojong.han@samsung.com> on 2012-03-13
Reviewed by Gavin Barraclough.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::dumpCode):

2:06 PM Changeset in webkit [110604] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebKit/qt

Attempt to fix QtMinimal bot after r110595

Blind fix, unreviewed.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-03-13

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationPermissionClientQt.h:
2:03 PM Changeset in webkit [110603] by Philippe Normand
  • 6 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r110587.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
2:02 PM Changeset in webkit [110602] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix cast-align GCC warning
​https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Dan Bates.

This touches unpackOneRowOfBGRA8ToRGBA8.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore):

1:59 PM Changeset in webkit [110601] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Refactor some code that is used to check whether a layer needs backing store
​https://bugs.webkit.org/show_bug.cgi?id=80917

Reviewed by Dean Jackson.

Move some code out of isSimpleContainerCompositingLayer() in two new
methods to make the code more self-descriptive.

No behavior change, so no tests.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::paintsChildren):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

1:47 PM Changeset in webkit [110600] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Implement ApplicationCacheHost::canCacheInPageCache() for chromium.
​https://bugs.webkit.org/show_bug.cgi?id=80905

Reviewed by Eric Seidel.

This won't cause chrome to use the PageCache, but it will cause our histogram statistics
describing PageCache use to be more accurate.

  • src/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::canCacheInPageCache):

1:30 PM Changeset in webkit [110599] by jchaffraix@webkit.org
  • 8 edits in trunk/LayoutTests

Too many tests (200+ on SL, 80+ on Lion) tests are failing on Mac port
​https://bugs.webkit.org/show_bug.cgi?id=80447

Unreviewed test rebaseline after r110072.

  • platform/mac/test_expectations.txt:
  • platform/mac/Skipped:

Moved an entry from test_expectations.txt to Skipped as it was failing differently
that expected (same image, different text baseline).

  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.txt:
  • platform/mac/fast/clip/008-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/repaint/overflow-delete-line-expected.txt:

Rebaselined those tests.

1:15 PM Changeset in webkit [110598] by dbates@webkit.org
  • 4 edits
    3 adds in trunk

REGRESSION(r99369): File input button doesn't highlight when pressed
​https://bugs.webkit.org/show_bug.cgi?id=79385

Reviewed by Kent Tamura.

Source/WebCore:

Fixes an issue where the file input button doesn't highlight on mouse press.

Currently we always override the active state of the button with whether
a dragged file is being hovered over the file input control (i.e. can the control
receive a dropped file; HTMLInputElement::canReceiveDroppedFiles()).
Instead, we should only override the active state of the button when the state
changes for whether we can receive dropped files (e.g. during a drag) so that
we honor the active state of the button when it is pressed.

Test: fast/forms/file/file-input-pressed-state.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::RenderFileUploadControl):
(WebCore::RenderFileUploadControl::updateFromElement):

  • rendering/RenderFileUploadControl.h:

(RenderFileUploadControl):

LayoutTests:

Add test to ensure that the file input button visually changes when pressed.

  • fast/forms/file/file-input-pressed-state-expected.txt: Added.
  • fast/forms/file/file-input-pressed-state.html: Added.
  • platform/mac/fast/forms/file/file-input-pressed-state-expected.png: Added.
1:15 PM Changeset in webkit [110597] by thakis@chromium.org
  • 2 edits in branches/chromium/1025/Source/WebCore

Merge 110499 - [Skia] Release CGImage used to apply color space conversion to SkBitmap
​https://bugs.webkit.org/show_bug.cgi?id=80892

Patch by Brian Salomon <​bsalomon@google.com> on 2012-03-12
Reviewed by Adam Barth.

Regressions should be covered by any test that does image decode on the mac.

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::resolveColorSpace):

TBR=​abarth@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/9689079

1:14 PM Changeset in webkit [110596] by commit-queue@webkit.org
  • 34 edits
    1 add in trunk

[chromium] Use CCOcclusionTracker for draw culling
​https://bugs.webkit.org/show_bug.cgi?id=80743

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-13
Reviewed by Adrienne Walker.

Source/WebCore:

In this CL we enable the use of CCOcclusionTracker for draw-side
culling. This means moving from a per-quad culling model to a
per-layer model.

When calculating RenderPasses, we construct the set of passes,
then iterate over layers in front-to-back order. We make
CCQuadCuller instantiable, and pass it to the layer
appendQuads() methods instead of the bare list, where it can
filter quads before the end up in the list.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPass):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h:

(CCCanvasLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::appendQuads):
(WebCore::CCLayerImpl::appendGutterQuads):
(WebCore::CCLayerImpl::appendDebugBorderQuad):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(CCPluginLayerImpl):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(WebCore):
(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCQuadList):
(WebCore::CCQuadList::backToFrontBegin):
(WebCore::CCQuadList::backToFrontEnd):
(CCRenderPass):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:

(WebCore::CCSolidColorLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::BlendStateCheckLayer::appendQuads):

  • tests/CCQuadCullerTest.cpp:

(TestCCOcclusionTrackerImpl):
(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
(WebCore::TestCCOcclusionTrackerImpl::layerScissorRectInTargetSurface):
(WebCore::makeLayer):
(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):

  • tests/MockCCQuadCuller.h: Added.

(WebCore):
(MockCCQuadCuller):
(WebCore::MockCCQuadCuller::MockCCQuadCuller):
(WebCore::MockCCQuadCuller::append):
(WebCore::MockCCQuadCuller::quadList):

LayoutTests:

  • platform/chromium-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium/test_expectations.txt:
1:10 PM Changeset in webkit [110595] by benjamin@webkit.org
  • 90 edits
    4 deletes in trunk

Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
​https://bugs.webkit.org/show_bug.cgi?id=78853

Patch by Adam Barth <​abarth@webkit.org> && Benjamin Poulain <​bpoulain@apple.com> on 2012-03-13
Reviewed by Adam Barth.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/geolocation/Geolocation.cpp:

(WebCore):
(WebCore::createPositionError):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):

  • Modules/geolocation/Geolocation.h:

(WebCore):
(Geolocation):

  • Modules/geolocation/GeolocationController.cpp:
  • Modules/geolocation/GeolocationController.h:
  • Modules/geolocation/GeolocationError.h:
  • Modules/geolocation/GeolocationPosition.h:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSGeolocationCustom.cpp:
  • loader/EmptyClients.h:

(EmptyChromeClient):

  • page/ChromeClient.h:

(ChromeClient):

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(Page):

  • platform/GeolocationService.cpp: Removed.
  • platform/GeolocationService.h: Removed.
  • platform/mock/GeolocationClientMock.cpp:
  • platform/mock/GeolocationClientMock.h:
  • platform/mock/GeolocationServiceMock.cpp: Removed.
  • platform/mock/GeolocationServiceMock.h: Removed.

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:
  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(toGeolocationClientMock):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):

Source/WebKit/chromium:

  • features.gypi:
  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:

(ChromeClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit):

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::scrollRectIntoView):

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationClientGtk.cpp:

(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):

  • WebCoreSupport/GeolocationClientGtk.h:

(WebKit):

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebCoreSupport/WebGeolocationClient.mm:

(WebGeolocationClient::lastPosition):

  • WebView/WebGeolocationPosition.mm:

(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(core):
(-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):

  • WebView/WebGeolocationPositionInternal.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidChangePosition:]):
(-[WebView _geolocationDidFailWithError:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(toGeolocationClientMock):
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationClientQt.h:

(WebCore):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebCoreSupport/WebGeolocationClient.cpp:

(WebGeolocationClient::lastPosition):

  • WebGeolocationPosition.cpp:

(WebGeolocationPosition::initWithTimestamp):
(core):

  • WebGeolocationPosition.h:

(WebGeolocationPosition):
(WebGeolocationPosition::impl):

  • WebView.cpp:

(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:
  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setGeoLocationPermission):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
  • WebProcess/WebCoreSupport/WebGeolocationClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • mac/WebKit2.order:

Tools:

  • Scripts/build-webkit:
  • qmake/mkspecs/features/features.prf:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
1:05 PM Changeset in webkit [110594] by tonikitoo@webkit.org
  • 29 edits in trunk

Convert nodesFromRect tests to use Internals interface
​https://bugs.webkit.org/show_bug.cgi?id=80886

Reviewed by Ryosuke Niwa.
Patch by Antonio Gomes <​agomes@rim.com>

Source/WebCore:

Add Internals::nodesFromRect implementation to unify
the codepath for testing Document::nodesFromRect in a
cross port way.

No new tests, since we are improving here the infra-structure
for testing a specific method.

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/gtk:

Removed DRTSupportGtk::nodesFromRect support, since
it can work in the cross-port way through the
Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Removed mac specific support for nodesFromRect for testing purposes only,
since it can work in a cross-port way through the Internals interface.

  • WebKit.order:
  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

Removed DRTSupportQt::nodesFromRect support, since
it can work in the cross-port way through the
Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

This clean up allows to remove port specific bits of each
DRT implementation that supports testing Document::nodesFromRect,
in favor of making use of the 'Internals' interface to test it.

This makes its code conveniently more expansible and cleaner.

Also removed stubs from Win and EFL, Wn and BlackBerry DRTs.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

LayoutTests:

Adjust nodesFromRect tests to use Internals
instead of LayoutTestController interface.

  • fast/dom/resources/nodesFromRect.js:

(check):

12:48 PM Changeset in webkit [110593] by schenney@chromium.org
  • 5 edits
    3 adds in trunk

Fix the use of stale text fragments
​https://bugs.webkit.org/show_bug.cgi?id=80729

Patch by Philip Rogers <​pdr@google.com> on 2012-03-13
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Previously, we were allowing SVGTextFragments to get out of sync with the
actual text in RenderSVGInlineTextBox. This patch reuses the dirty line
box code in RenderText::setTextWithOffset to force
clearTextFragments() when setTextWithOffset is called, preventing the use
of stale SVGTextFragments.

Test: svg/custom/delete-text-crash.html

  • rendering/InlineBox.h:

(InlineBox):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::dirtyLineBoxes):
(WebCore):

  • rendering/svg/SVGInlineTextBox.h:

(SVGInlineTextBox):

LayoutTests:

  • svg/custom/delete-text-crash-expected.png: Added.
  • svg/custom/delete-text-crash-expected.txt: Added.
  • svg/custom/delete-text-crash.html: Added.
12:33 PM Changeset in webkit [110592] by ojan@chromium.org
  • 4 edits
    6 copies
    30 adds in trunk/LayoutTests

Fix some broken layout test rebaselines from the various chromium-lion
rebaselining patches. The bugs in the rebaseline tool that caused the breakages
are now fixed.

  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Added.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-table-cells-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/basic/014-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/basic/020-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/dynamic-unfloat-pref-width-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/044-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/045-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/054-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/pseudo-element-line-break-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/onload-re-entry-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/disabled-select-change-index-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/select-writing-direction-natural-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-writing-direction-natural-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/inline/002-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/inline/vertical-align-text-bottom-expected.png: Added.
  • platform/chromium-mac-leopard/fast/invalid/002-expected.png: Added.
  • platform/chromium-mac-leopard/fast/invalid/005-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/invalid/007-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/invalid/020-expected.png: Added.
  • platform/chromium-mac-leopard/fast/invalid/missing-end-tag-expected.png: Added.
  • platform/chromium-mac-leopard/fast/lists/006-expected.png: Added.
  • platform/chromium-mac-leopard/fast/loader/text-document-wrapping-expected.png: Added.
  • platform/chromium-mac-leopard/fast/parser/tabs-in-scripts-expected.png: Added.
  • platform/chromium-mac-leopard/fast/parser/xhtml-alternate-entities-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/three-selects-break-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/002-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/001-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/010-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/013-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/015-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/table/022-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/basic-scrollbar-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/disabled-scrollbar-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/scrollbar-buttons-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/scrollbar-orientation-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium/test_expectations.txt:
12:27 PM Changeset in webkit [110591] by Nikolas Zimmermann
  • 4 edits in trunk/Source/WebCore

SVG Animations update baseVal instead of animVal
​https://bugs.webkit.org/show_bug.cgi?id=12437

Reviewed by Dirk Schulze.

Blind fix for some GC related assertions firing on v8.

Assure that animationStarted/animationEnded calls are happening
on the same SVGAnimatedProperty. Always call animationEnded(),
even if we shouldn't do anything for the target element, as its
destructed, as we still have to reset m_isAnimating.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::targetElementWillChange):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::animationEnded):

12:19 PM Changeset in webkit [110590] by ojan@chromium.org
  • 208 edits
    137 copies
    56 moves
    97 adds
    8 deletes in trunk/LayoutTests

Chromium-Lion rebaselines.

12:12 PM Changeset in webkit [110589] by commit-queue@webkit.org
  • 12 edits
    13 moves in trunk/Source/WebCore

Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory
​https://bugs.webkit.org/show_bug.cgi?id=80625

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-03-13
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/filesystem: Added.
  • Modules/filesystem/DirectoryEntry.cpp: Copied from Source/WebCore/fileapi/DirectoryEntry.cpp.
  • Modules/filesystem/DirectoryEntry.h: Copied from Source/WebCore/fileapi/DirectoryEntry.h.
  • Modules/filesystem/DirectoryEntry.idl: Copied from Source/WebCore/fileapi/DirectoryEntry.idl.
  • Modules/filesystem/DirectoryEntrySync.cpp: Copied from Source/WebCore/fileapi/DirectoryEntrySync.cpp.
  • Modules/filesystem/DirectoryEntrySync.h: Copied from Source/WebCore/fileapi/DirectoryEntrySync.h.
  • Modules/filesystem/DirectoryEntrySync.idl: Copied from Source/WebCore/fileapi/DirectoryEntrySync.idl.
  • Modules/filesystem/DirectoryReader.cpp: Copied from Source/WebCore/fileapi/DirectoryReader.cpp.
  • Modules/filesystem/DirectoryReader.h: Copied from Source/WebCore/fileapi/DirectoryReader.h.
  • Modules/filesystem/DirectoryReader.idl: Copied from Source/WebCore/fileapi/DirectoryReader.idl.
  • Modules/filesystem/DirectoryReaderBase.h: Copied from Source/WebCore/fileapi/DirectoryReaderBase.h.
  • Modules/filesystem/DirectoryReaderSync.cpp: Copied from Source/WebCore/fileapi/DirectoryReaderSync.cpp.
  • Modules/filesystem/DirectoryReaderSync.h: Copied from Source/WebCore/fileapi/DirectoryReaderSync.h.
  • Modules/filesystem/DirectoryReaderSync.idl: Copied from Source/WebCore/fileapi/DirectoryReaderSync.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DirectoryEntry.cpp: Removed.
  • fileapi/DirectoryEntry.h: Removed.
  • fileapi/DirectoryEntry.idl: Removed.
  • fileapi/DirectoryEntrySync.cpp: Removed.
  • fileapi/DirectoryEntrySync.h: Removed.
  • fileapi/DirectoryEntrySync.idl: Removed.
  • fileapi/DirectoryReader.cpp: Removed.
  • fileapi/DirectoryReader.h: Removed.
  • fileapi/DirectoryReader.idl: Removed.
  • fileapi/DirectoryReaderBase.h: Removed.
  • fileapi/DirectoryReaderSync.cpp: Removed.
  • fileapi/DirectoryReaderSync.h: Removed.
  • fileapi/DirectoryReaderSync.idl: Removed.
12:06 PM Changeset in webkit [110588] by igor.o@sisa.samsung.com
  • 9 edits
    4 adds in trunk

animation-iteration-count does not handle floating point values correctly.
​https://bugs.webkit.org/show_bug.cgi?id=69531

Source/WebCore:

Implements support for non-integers animation-iteration-count numbers.
Non-integer numbers will cause the animation to end part-way through a cycle.

Reviewed by Dean Jackson.

Tests: animations/fill-mode-iteration-count-non-integer.html

animations/keyframes-iteration-count-non-integer.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationIterationCount):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::fractionalTime):
(WebCore::AnimationBase::progress):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::pauseAnimationAtTime):

  • platform/animation/Animation.h:

(WebCore::Animation::iterationCount):
(WebCore::Animation::setIterationCount):
(Animation):
(WebCore::Animation::initialAnimationIterationCount):

LayoutTests:

Reviewed by Dean Jackson.

  • animations/fill-mode-iteration-count-non-integer-expected.txt: Added.
  • animations/fill-mode-iteration-count-non-integer.html: Added.
  • animations/keyframes-iteration-count-non-integer-expected.txt: Added.
  • animations/keyframes-iteration-count-non-integer.html: Added.
11:51 AM Changeset in webkit [110587] by tommyw@google.com
  • 25 edits
    10 moves in trunk

MediaStream API: Rename PeerConnection to DeprecatedPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=80692

Reviewed by Adam Barth.

First patch in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.

Source/WebCore:

Patch covered by modified existing tests.

  • GNUmakefile.list.am:
  • Modules/mediastream/DOMWindowMediaStream.idl:
  • Modules/mediastream/DeprecatedPeerConnection.cpp: Renamed from Source/WebCore/Modules/mediastream/PeerConnection.cpp.

(WebCore):
(WebCore::DeprecatedPeerConnection::create):
(WebCore::DeprecatedPeerConnection::DeprecatedPeerConnection):
(WebCore::DeprecatedPeerConnection::~DeprecatedPeerConnection):
(WebCore::DeprecatedPeerConnection::processSignalingMessage):
(WebCore::DeprecatedPeerConnection::readyState):
(WebCore::DeprecatedPeerConnection::send):
(WebCore::DeprecatedPeerConnection::addStream):
(WebCore::DeprecatedPeerConnection::removeStream):
(WebCore::DeprecatedPeerConnection::localStreams):
(WebCore::DeprecatedPeerConnection::remoteStreams):
(WebCore::DeprecatedPeerConnection::close):
(WebCore::DeprecatedPeerConnection::didCompleteICEProcessing):
(WebCore::DeprecatedPeerConnection::didGenerateSDP):
(WebCore::DeprecatedPeerConnection::didReceiveDataStreamMessage):
(WebCore::DeprecatedPeerConnection::didAddRemoteStream):
(WebCore::DeprecatedPeerConnection::didRemoveRemoteStream):
(WebCore::DeprecatedPeerConnection::interfaceName):
(WebCore::DeprecatedPeerConnection::scriptExecutionContext):
(WebCore::DeprecatedPeerConnection::stop):
(WebCore::DeprecatedPeerConnection::eventTargetData):
(WebCore::DeprecatedPeerConnection::ensureEventTargetData):
(WebCore::DeprecatedPeerConnection::scheduleInitialNegotiation):
(WebCore::DeprecatedPeerConnection::initialNegotiationTimerFired):
(WebCore::DeprecatedPeerConnection::ensureStreamChangeScheduled):
(WebCore::DeprecatedPeerConnection::streamChangeTimerFired):
(WebCore::DeprecatedPeerConnection::scheduleReadyStateChange):
(WebCore::DeprecatedPeerConnection::readyStateChangeTimerFired):
(WebCore::DeprecatedPeerConnection::changeReadyState):

  • Modules/mediastream/DeprecatedPeerConnection.h: Renamed from Source/WebCore/Modules/mediastream/PeerConnection.h.

(WebCore):
(DeprecatedPeerConnection):
(WebCore::DeprecatedPeerConnection::didChangeState):
(WebCore::DeprecatedPeerConnection::refEventTarget):
(WebCore::DeprecatedPeerConnection::derefEventTarget):

  • Modules/mediastream/DeprecatedPeerConnection.idl: Renamed from Source/WebCore/Modules/mediastream/PeerConnection.idl.
  • Modules/mediastream/SignalingCallback.h:

(WebCore):
(SignalingCallback):

  • Modules/mediastream/SignalingCallback.idl:
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitDeprecatedPeerConnectionEnabled):

  • bindings/js/JSDeprecatedPeerConnectionCustom.cpp: Renamed from Source/WebCore/bindings/js/JSPeerConnectionCustom.cpp.

(WebCore):
(WebCore::JSDeprecatedPeerConnectionConstructor::constructJSDeprecatedPeerConnection):

  • dom/EventTarget.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • platform/mediastream/DeprecatedPeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/PeerConnectionHandler.h.

(WebCore):
(DeprecatedPeerConnectionHandler):

  • platform/mediastream/DeprecatedPeerConnectionHandlerClient.h: Renamed from Source/WebCore/platform/mediastream/PeerConnectionHandlerClient.h.

(WebCore):
(DeprecatedPeerConnectionHandlerClient):
(WebCore::DeprecatedPeerConnectionHandlerClient::~DeprecatedPeerConnectionHandlerClient):

  • platform/mediastream/gstreamer/DeprecatedPeerConnectionHandler.cpp: Renamed from Source/WebCore/platform/mediastream/gstreamer/PeerConnectionHandler.cpp.

(WebCore):
(WebCore::DeprecatedPeerConnectionHandler::create):
(WebCore::DeprecatedPeerConnectionHandler::DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::~DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::processSDP):
(WebCore::DeprecatedPeerConnectionHandler::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandler::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandler::stop):

Source/WebKit/chromium:

  • WebKit.gyp:
  • bridge/DeprecatedPeerConnectionHandler.cpp: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandler.cpp.

(WebCore):
(WebCore::DeprecatedPeerConnectionHandler::create):
(WebCore::DeprecatedPeerConnectionHandler::DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::~DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::processSDP):
(WebCore::DeprecatedPeerConnectionHandler::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandler::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandler::stop):

  • bridge/DeprecatedPeerConnectionHandlerInternal.cpp: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandlerInternal.cpp.

(WebCore):
(WebCore::DeprecatedPeerConnectionHandlerInternal::DeprecatedPeerConnectionHandlerInternal):
(WebCore::DeprecatedPeerConnectionHandlerInternal::~DeprecatedPeerConnectionHandlerInternal):
(WebCore::DeprecatedPeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandlerInternal::processSDP):
(WebCore::DeprecatedPeerConnectionHandlerInternal::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandlerInternal::stop):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didRemoveRemoteStream):

  • bridge/DeprecatedPeerConnectionHandlerInternal.h: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandlerInternal.h.

(WebKit):
(WebCore):
(DeprecatedPeerConnectionHandlerInternal):

LayoutTests:

  • fast/dom/call-a-constructor-as-a-function.html:
  • fast/mediastream/peerconnection-Attributes-expected.txt:
  • fast/mediastream/peerconnection-addstream-expected.txt:
  • fast/mediastream/peerconnection-argument-types-expected.txt:
  • fast/mediastream/peerconnection-eventlistener-optional-argument.html:
  • fast/mediastream/peerconnection-mediastreamlist.html:
  • fast/mediastream/peerconnection-removestream-expected.txt:
  • fast/mediastream/script-tests/Attributes.js:
  • fast/mediastream/script-tests/argument-types.js:
  • fast/mediastream/script-tests/peerconnection-addstream.js:
  • fast/mediastream/script-tests/peerconnection-removestream.js:
  • platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
11:49 AM Changeset in webkit [110586] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Remove a nonexistent WebUIDelegate method from WebUIDelegatePrivate.h
​https://bugs.webkit.org/show_bug.cgi?id=81014

Reviewed by Sam Weinig.

Remove a plug-in halter related WebUIDelegate method.

  • WebView/WebUIDelegatePrivate.h:
11:34 AM Changeset in webkit [110585] by ojan@chromium.org
  • 6 edits in trunk/Tools

Rebaselining for a new port doesn't work right with multiple fallback ports
​https://bugs.webkit.org/show_bug.cgi?id=80932

Reviewed by Adam Barth.

Since chromium-leopard also falls back to mac-leopard, we need to
copy the existing result for both chromium-leopard and chromium-snowleopard
before doing lion rebaselines.

  • Scripts/webkitpy/layout_tests/port/builders.py:

(fallback_port_names_for_new_port):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest):
(RebaselineTest._copy_existing_baseline):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.rebaseline):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(GardeningServerTest.test_rebaseline_new_port):

11:21 AM Changeset in webkit [110584] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: front-end compilation was broken while supporting large arrays.
​https://bugs.webkit.org/show_bug.cgi?id=81013

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ExtensionPanel.js:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties.buildObjectFragment):

  • inspector/front-end/RemoteObject.js:
11:17 AM Changeset in webkit [110583] by tony@chromium.org
  • 7 edits
    2 adds in trunk

flexbox's computePreferredLogicalWidth needs to take multiline into account
​https://bugs.webkit.org/show_bug.cgi?id=80931

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: css3/flexbox/multiline-shrink-to-fit-expected.html

css3/flexbox/multiline-shrink-to-fit.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidths): Set min/max preferredLogicalWidth based on always breaking or never breaking.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Add a FIXME.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Don't change the width after computePreferredWidth has been called.

LayoutTests:

  • css3/flexbox/cross-axis-scrollbar.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-shrink-to-fit-expected.html: Added.
  • css3/flexbox/multiline-shrink-to-fit.html: Added.
  • css3/flexbox/multiline.html:
11:10 AM Changeset in webkit [110582] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Remove SlotVisitor::copy() method.
​https://bugs.webkit.org/show_bug.cgi?id=80973

Patch by Kwonjin Jeong <​gram@company100.net> on 2012-03-13
Reviewed by Geoffrey Garen.

SlotVisitor::copy() method isn't called anywhere.

  • heap/MarkStack.cpp: Remove definition of SlotVisitor::copy() method.
  • heap/SlotVisitor.h: Remove declaration of SlotVisitor::copy() method.
11:05 AM Changeset in webkit [110581] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r110469.
​http://trac.webkit.org/changeset/110469
​https://bugs.webkit.org/show_bug.cgi?id=81010

This patch still appears to crash (Requested by abarth on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-13

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldRepaint):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

11:02 AM Changeset in webkit [110580] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Add a method to window.internals to enable testing of inspector highlight rects
​https://bugs.webkit.org/show_bug.cgi?id=80338

Patch by Max Vujovic <​mvujovic@adobe.com> on 2012-03-13
Reviewed by Pavel Feldman.

.:

  • Source/autotools/symbols.filter: Export symbols for GTK.

Source/WebCore:

Add window.internals.inspectorHighlightRects, a method which makes it possible to test the
positions and sizes of inspector highlight rects.

Test: inspector/elements/highlight-node.html

  • WebCore.exp.in: Export symbols.
  • testing/Internals.cpp:

(WebCore::Internals::inspectorHighlightRects): Call InspectorController::getHighlight and
return the highlight's quads as a ClientRectList.
(WebCore):

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Add inspectorHighlightRects to the window.internals interface.

Source/WebKit2:

  • win/WebKit2.def: Export symbols for win.
  • win/WebKit2CFLite.def: Same as above.

LayoutTests:

  • inspector/elements/highlight-node-expected.txt: Added.
  • inspector/elements/highlight-node.html: Added.
10:57 AM Changeset in webkit [110579] by mitz@apple.com
  • 2 edits in trunk/Websites/webkit.org

Working With Code > Installing Developer Tools needs to be updated with OS X Lion & App Store details
​https://bugs.webkit.org/show_bug.cgi?id=80429

Patch by Rebecca Hauck <​rhauck@adobe.com> on 2012-03-13
Reviewed by Dan Bernstein.

  • building/tools.html:
10:30 AM Changeset in webkit [110578] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Remove sublayers before clamping just in case the layer already exists
​https://bugs.webkit.org/show_bug.cgi?id=80989

Patch by Konrad Piascik <​kpiascik@rim.com> on 2012-03-13
Reviewed by Antonio Gomes.

Discovered when trying to add a highlight sublayer for web inspector. Since that layer
may already exist in the tree we need to see if it will be pruned before we clamp on the
size.

This was manually tested during the writing of another patch to add web inspector highlights
to accelrated compositing.

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::insertSublayer):

10:25 AM Changeset in webkit [110577] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note that fast/loader/window-properties-restored-from-page-cache.html
depends on the page cache.

  • platform/chromium/test_expectations.txt:
9:37 AM Changeset in webkit [110576] by vsevik@chromium.org
  • 9 edits
    3 adds in trunk

Web Inspector: Add snippets model.
​https://bugs.webkit.org/show_bug.cgi?id=80863

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/snippets-model.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SnippetsModel.js: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/debugger/snippets-model-expected.txt: Added.
  • inspector/debugger/snippets-model.html: Added.
9:33 AM Changeset in webkit [110575] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Tweak minibrowser UI

Add some margins to the scroll indicators, and set a dark background
color so you see the page dimensions.

Reviewed by Antonio Gomes.

9:11 AM Changeset in webkit [110574] by Nikolas Zimmermann
  • 111 edits in trunk/LayoutTests

[Qt] svg/animations tests are very flaky
​https://bugs.webkit.org/show_bug.cgi?id=80703

Reviewed by Rob Buis.

Overhaul the svg/animation frameworks, to be more stable.
Especially discrete animations were flaky on Qt, because some tests still sampled
at integral times like 2.0s, instead of 1.999s (before change), and 2.001s (after change).

Always use shouldBeCloseEnough() when comparing font-sizes/color values/, as there's
always an uncertainity about the actual sampling time (low but may lead to 40.01px values, instead of 40px).

This makes these tests also stable in Firefox/Opera, which was the ultimate goal!

  • platform/qt/Skipped: Unskip svg/animation tests.
  • svg/animations/additive-values-width-animation-expected.txt:
  • svg/animations/animate-color-calcMode-discrete-expected.txt:
  • svg/animations/animate-color-fill-currentColor-expected.txt:
  • svg/animations/animate-color-fill-from-by-expected.txt:
  • svg/animations/animate-color-rgba-calcMode-discrete-expected.txt:
  • svg/animations/animate-color-transparent-expected.txt:
  • svg/animations/animate-currentColor-expected.txt:
  • svg/animations/animate-dynamic-update-attributeName-expected.txt:
  • svg/animations/animate-elem-03-t-drt-expected.txt:
  • svg/animations/animate-end-attribute-expected.txt:
  • svg/animations/animate-from-to-keyTimes-expected.txt:
  • svg/animations/animate-inherit-css-property-expected.txt:
  • svg/animations/animate-keySplines-expected.txt:
  • svg/animations/animate-number-calcMode-discrete-expected.txt:
  • svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt:
  • svg/animations/attributeTypes-expected.txt:
  • svg/animations/resources/SVGAnimationTestCase.js:

(expectColor):
(expectFillColor):
(moveAnimationTimelineAndSample):

  • svg/animations/script-tests/additive-values-width-animation.js:

(executeTest):

  • svg/animations/script-tests/animVal-basics.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-by.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-from-by.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-from-to.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-to.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-values.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-color-calcMode-discrete.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-color-fill-currentColor.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-color-fill-from-by.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js:

(parseAlphaFromColor):
(red):

  • svg/animations/script-tests/animate-color-transparent.js:

(expectTransparent):
(expectOtherColor):

  • svg/animations/script-tests/animate-currentColor.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-dynamic-update-attributeName.js:

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/animate-elem-03-t-drt.js:

(parseFontSizeFromString):
(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-end-attribute.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-endElement-beginElement.js:

(sample1):

  • svg/animations/script-tests/animate-from-to-keyTimes.js:
  • svg/animations/script-tests/animate-gradient-transform.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-inherit-css-property.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-insert-begin.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-insert-no-begin.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animate-keySplines.js:

(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js:

(executeTest):

  • svg/animations/script-tests/animate-number-calcMode-discrete.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-Cc-Ss.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-Qq-Tt.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-to-animation.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animateTransform-pattern-transform.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/attributeTypes.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/multiple-animations-fill-freeze.js:

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):

  • svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:

(executeTest):

  • svg/animations/script-tests/svgangle-animation-deg-to-grad.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-deg-to-rad.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-grad-to-deg.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-grad-to-rad.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-rad-to-deg.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-rad-to-grad.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgboolean-animation-1.js:

(executeTest):

  • svg/animations/script-tests/svginteger-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeHeight.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeOther.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeWidth.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-invalid-value-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-invalid-value-2.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-invalid-value-3.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-number-to-number.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-cm.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-ems.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-exs.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-in.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-number.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-pc.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-percentage.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-pt.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-px.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-unitType.js:

(executeTest):

  • svg/animations/script-tests/svglength-animation-values.js:

(sample1):
(sample2):
(sample4):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-2.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-3.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-4.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-5.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumber-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumber-animation-2.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumber-animation-3.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumberlist-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberlist-animation-2.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgpath-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgpointlist-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgpointlist-animation-2.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgrect-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgrect-animation-2.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js:

(executeTest):

  • svg/animations/script-tests/svgtransform-animation-1.js:

(sample1):
(sample2):

  • svg/animations/script-tests/svgtransform-animation-discrete.js:

(sample1):
(executeTest):

  • svg/animations/svglength-animation-invalid-value-1-expected.txt:
  • svg/animations/svglength-animation-invalid-value-2-expected.txt:
  • svg/animations/svglength-animation-invalid-value-3-expected.txt:
  • svg/animations/svglength-animation-unitType-expected.txt:
  • svg/animations/svgnumber-animation-1-expected.txt:
  • svg/animations/svgnumber-animation-2-expected.txt:
  • svg/animations/svgnumber-animation-3-expected.txt:
  • svg/animations/svgtransform-animation-discrete-expected.txt:
9:08 AM Changeset in webkit [110573] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: chromium build fix.

  • history/CachedFrame.cpp:
9:03 AM Changeset in webkit [110572] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: refactor copy-paste getter methods
​https://bugs.webkit.org/show_bug.cgi?id=80923

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-03-13
Reviewed by Yury Semikhatsky.

Several methods are combined in one using C++ templates.

  • inspector/CodeGeneratorInspector.py:
9:00 AM Changeset in webkit [110571] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fix cast-align warning in QuotesData.cpp
​https://bugs.webkit.org/show_bug.cgi?id=80601

Reviewed by Nikolas Zimmermann.

Fix warning by adding variable of correct return type.

  • rendering/style/QuotesData.cpp:

(WebCore::QuotesData::create):

8:57 AM Changeset in webkit [110570] by beidson@apple.com
  • 12 edits
    2 adds in trunk

<rdar://problem/7908830> and ​https://bugs.webkit.org/show_bug.cgi?id=34679 Location and other objects are dysfunctional after a document gets restored from page cache

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/loader/window-properties-restored-from-page-cache.html

Give DOMWindowProperties the ability to reconnect to their Frame:

  • page/DOMWindowProperty.cpp:

(WebCore::DOMWindowProperty::reconnectFrame):

  • page/DOMWindowProperty.h:

(DOMWindowProperty):

Let ApplicationCache do some extra work when reconnecting:

  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::reconnectFrame):
(WebCore):

  • loader/appcache/DOMApplicationCache.h:

(DOMApplicationCache):

Let IndexDB do some extra work when reconnecting:

  • Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::disconnectFrame):
(WebCore::DOMWindowIndexedDatabase::reconnectFrame):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):

  • Modules/indexeddb/DOMWindowIndexedDatabase.h:

(DOMWindowIndexedDatabase):

Tell the DOMWindow to suspend to the page cache:

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

Tell the DOMWindow to resume from the page cache:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::~DOMWindow): Call clearDOMWindowProperties directly instead of clear()
(WebCore::DOMWindow::frameDestroyed): Ditto.
(WebCore::DOMWindow::clear): Only clear if the DOMWindow is not suspended for the page cache.
(WebCore::DOMWindow::suspendForPageCache): Disconnect properties and set the page cache flag.
(WebCore::DOMWindow::resumeFromPageCache): Reconnect properties and revert the page cache flag.
(WebCore::DOMWindow::disconnectDOMWindowProperties): Only disconnect the registered properties.
(WebCore::DOMWindow::reconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties): Disconnect the registered properties then clear them out.

For all of the following, if the DOMWindow is not displayed in a frame (i.e., it is suspended), do nothing:
(WebCore::DOMWindow::screen):
(WebCore::DOMWindow::history):
(WebCore::DOMWindow::crypto):
(WebCore::DOMWindow::locationbar):
(WebCore::DOMWindow::menubar):
(WebCore::DOMWindow::personalbar):
(WebCore::DOMWindow::scrollbars):
(WebCore::DOMWindow::statusbar):
(WebCore::DOMWindow::toolbar):
(WebCore::DOMWindow::console):
(WebCore::DOMWindow::applicationCache):
(WebCore::DOMWindow::navigator):
(WebCore::DOMWindow::performance):
(WebCore::DOMWindow::location):
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
(WebCore::DOMWindow::webkitNotifications):
(WebCore::DOMWindow::postMessageTimerFired):
(WebCore::DOMWindow::getSelection):
(WebCore::DOMWindow::styleMedia):
(WebCore::DOMWindow::webkitStorageInfo):

  • page/DOMWindow.h:

LayoutTests:

  • fast/loader/window-properties-restored-from-page-cache-expected.txt: Added.
  • fast/loader/window-properties-restored-from-page-cache.html: Added.
8:43 AM Changeset in webkit [110569] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Use projectQuad to apply inverse mapRect
​https://bugs.webkit.org/show_bug.cgi?id=80741

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-13
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCOcclusionTrackerTest3dTransform

CCOcclusionTrackerTestPerspectiveTransform
CCOcclusionTrackerTestPerspectiveTransformBehindCamera

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(CCOcclusionTrackerTest3dTransform):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransform):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransformBehindCamera):
(WebCore::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):

8:40 AM Changeset in webkit [110568] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] [DRT] Implement scheduleAsynchronousKeyDown.
​https://bugs.webkit.org/show_bug.cgi?id=79601

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-03-13
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Added a new API to deliver all mutations explicitly.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::deliverAllMutationsIfNecessary):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
and is taken over to sendKeyDown.
Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.

  • DumpRenderTree/efl/EventSender.cpp:

(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(createKeyEventInfo):
(sendKeyDown):
(keyDownCallback):
(sendAsynchronousKeyDown):
(scheduleAsynchronousKeyDownCallback):

LayoutTests:

Removed following two skipped tests.
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html

  • platform/efl/Skipped:
8:28 AM Changeset in webkit [110567] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

New PageCache histogram which counts failures ignoring Settings.
​https://bugs.webkit.org/show_bug.cgi?id=80864

Reviewed by Brady Eidson.

Chrome has a command line switch to turn on the page cache.
Currently it doesn't work, but it can cause the PageCache reasons
for failure count to read lower than it should. Add a new
histogram to report the corrected value.

  • history/PageCache.cpp:

(WebCore::logCanCachePageDecision):

8:24 AM Changeset in webkit [110566] by staikos@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix signed/unsigned mismatch compiler warnings.
​https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Alexey Proskuryakov.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousLoadDecisionForIconURL):

  • platform/network/MIMESniffing.cpp:
8:21 AM Changeset in webkit [110565] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r110510.
​http://trac.webkit.org/changeset/110510
​https://bugs.webkit.org/show_bug.cgi?id=80987

depends on chromium r 125700, which isn't rolled into webkit
yet :-/ (Requested by thakis_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-13

  • WebCore.gyp/mac/adjust_visibility.sh:
8:18 AM Changeset in webkit [110564] by gavinp@chromium.org
  • 5 edits in trunk/Source

Make ApplicationCacheHost::canCacheInPageCache() non-const.
​https://bugs.webkit.org/show_bug.cgi?id=80904

Reviewed by Alexey Proskuryakov.

A const pointer to a large object like ApplicationCacheHost is not our standard
practice; so remove this (implicit) one. See also ​https://bugs.webkit.org/show_bug.cgi?id=80898

Source/WebCore:

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::canCacheInPageCache):

  • loader/appcache/ApplicationCacheHost.h:

(ApplicationCacheHost):

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::canCacheInPageCache):

8:14 AM Changeset in webkit [110563] by schenney@chromium.org
  • 7 edits
    2 adds in trunk

Crash in WebCore::GraphicsContext::paintingDisabled
​https://bugs.webkit.org/show_bug.cgi?id=80669

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The SVGImageBufferTools::clipToImageBuffer method deletes the clip
image when it thinks it is not needed. However, there are cases when
it is in fact still needed, particularly when the clip buffer is
coming from higher up in the stack where it may be needed again.

So this patch adds a flag to only allow deletion of the image buffer
if it was created at the most recent call site.

Tests: svg/custom/circular-clip-path-references-crash-expected.svg

svg/custom/circular-clip-path-references-crash.svg

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::clipToTextMask):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

  • rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::clipToImageBuffer):

  • rendering/svg/SVGImageBufferTools.h:

(SVGImageBufferTools):

LayoutTests:

  • svg/custom/circular-clip-path-references-crash-expected.svg: Added.
  • svg/custom/circular-clip-path-references-crash.svg: Added.
8:02 AM Changeset in webkit [110562] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk/Source/WebKit/blackberry

Remove ActiveNodeContext in favour of BlackBerry::Platform::WebContext
​https://bugs.webkit.org/show_bug.cgi?id=80984

Remove ActiveNodeContext, and switch the implementation to
provide a BlackBerry::Platform::WebContext. The new object
adds an explicit IsImage flag, as well as IsAudio and IsVideo
for the HTML5 elements.

Note that for many videos both IsVideo and IsAudio will be true,
as videos typically have audio streams as well.

Patch by Mike Lattanzio <​mlattanzio@rim.com> on 2012-03-13
Reviewed by George Staikos.

  • Api/ActiveNodeContext.h: Removed.
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::webContext):

  • Api/WebPage.h:
  • Api/WebPage_p.h:
7:57 AM Changeset in webkit [110561] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix an enumeration name in ReasonsFrameCannotBeInPageCache.
​https://bugs.webkit.org/show_bug.cgi?id=80849

Reviewed by Brady Eidson.

It seems that somebody goofed, and named one of the
ReasonsFrameCannotBeInPageCache antonymically.

  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):

7:38 AM Changeset in webkit [110560] by kinuko@chromium.org
  • 10 edits in trunk/Source/WebCore

File upload control should use File.name() rather than File.path() to show chosen filenames
​https://bugs.webkit.org/show_bug.cgi?id=80970

In some rare cases (e.g. files from FileSystem API or files created
using the newly added WebKit API) File.name has different displayName
from the basename of file.path, and in the file uploader controller we
should use File.name rather than File.path.

Reviewed by Kent Tamura.

No new tests: existing tests should pass as this should not change
behavior in regular use cases. (New behavior where File.name differs
from File.path can be only tested in chromeos environment, therefore
not adding new tests for that)

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::fileListNameForWidth): Updated to handle FileList.

  • platform/gtk/RenderThemeGtk.h:
  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::fileListNameForWidth): Updated to handle FileList.

  • platform/qt/RenderThemeQt.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::fileTextValue): Changed to pass FileList rather than FileList->paths().

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::fileListNameForWidth): Updated to handle FileList and use File.name for displaying the file name.

  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::fileListNameForWidth): Updated to handle FileList.

7:09 AM Changeset in webkit [110559] by haraken@chromium.org
  • 2 edits in trunk/PerformanceTests

Dromaeo perf-tests results are wrong
​https://bugs.webkit.org/show_bug.cgi?id=80974

Reviewed by Hajime Morita.

Dromaeo perf-tests had reported the sum of runs/seconds as "ms".
This patch fixes them to report the execution time per run.

At present, they report "0.0ms" for "stdev". This is because
dromaeorunner.js can just know stdev of "runs/seconds"
and cannot calculate stdev of "ms" from that. We can fix it later.

  • Dromaeo/resources/dromaeorunner.js:

(.):

7:09 AM Changeset in webkit [110558] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip some tests until fix.

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-03-13
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
7:06 AM Changeset in webkit [110557] by kinuko@chromium.org
  • 13 edits in trunk/Source

Allow WebFileChooser to return extra file info (like displayName) in addition to mere file paths
​https://bugs.webkit.org/show_bug.cgi?id=80719

Reviewed by Kent Tamura.

Source/WebCore:

No new tests: this change itself shouldn't change existing behavior.

  • fileapi/File.cpp:

(WebCore::createBlobDataForFileWithName): Renamed from createBlobDataForFileSystemFile.

  • fileapi/File.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::saveFormControlState): Updated to handle File.name.
(WebCore::FileInputType::restoreFormControlState): Ditto.
(WebCore::FileInputType::setFileList): Changed the signature to take
FileChooserFileInfo.
(WebCore::FileInputType::filesChosen): Ditto.
(WebCore::FileInputType::receiveDroppedFiles):

  • html/FileInputType.h:

(FileInputType):

  • platform/FileChooser.cpp:

(WebCore::FileChooser::chooseFiles): Added an overloaded method that
takes FileChooserFileInfo.
(WebCore):

  • platform/FileChooser.h:

(WebCore::FileChooserFileInfo::FileChooserFileInfo): Added.

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension): Removed surrouonding ifdefs as this function is now used even if FILE_SYSTEM is not enabled.

  • platform/MIMETypeRegistry.h:

(MIMETypeRegistry):

Source/WebKit/chromium:

  • public/WebFileChooserCompletion.h:

(SelectedFileInfo): Added.
(WebFileChooserCompletion):
(WebKit::WebFileChooserCompletion::didChooseFile): Added an overloaded
method that takes SelectedFileInfo.

  • src/WebFileChooserCompletionImpl.cpp:

(WebKit::WebFileChooserCompletionImpl::didChooseFile): Ditto.
(WebKit):

  • src/WebFileChooserCompletionImpl.h:

(WebFileChooserCompletionImpl):

5:38 AM Changeset in webkit [110556] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Remove a duplicate allocation of matrix entry.
​https://bugs.webkit.org/show_bug.cgi?id=79362

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2012-03-13
Reviewed by Zoltan Herczeg.

A matrix entry is created when calling ewk_matrix_new.
Another matrix is created inside ewk_tile_matrix_zoom_level_set.
This patch is for getting rid of a duplicated creation of the matrix.

  • ewk/ewk_tiled_backing_store.cpp:

(_Ewk_Tiled_Backing_Store_Item):
(_ewk_tiled_backing_store_zoom_set_internal):

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_new):
(ewk_tile_matrix_zoom_level_set):
(ewk_tile_matrix_entry_new):
(ewk_tile_matrix_size_get):

  • ewk/ewk_tiled_matrix.h:
5:28 AM Changeset in webkit [110555] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping some more failing tests.

  • platform/chromium/test_expectations.txt:
5:25 AM Changeset in webkit [110554] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector compilation module name fix after r110550.

  • inspector/compile-front-end.py:
5:24 AM Changeset in webkit [110553] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Set correct device width and height.
​https://bugs.webkit.org/show_bug.cgi?id=80980

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-03-13
Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::computeViewportConstraints):

3:00 AM Changeset in webkit [110552] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip new failing test on GTK.

  • platform/gtk/Skipped:
2:57 AM Changeset in webkit [110551] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking a test as fail which needs reaseline.

  • platform/chromium/test_expectations.txt:
2:47 AM Changeset in webkit [110550] by vsevik@chromium.org
  • 2 edits
    1 add in trunk/Source/WebCore

Web Inspector: Changes to the list of scripts for front-end compilation should not require update of number of scripts in module.
​https://bugs.webkit.org/show_bug.cgi?id=80872

Reviewed by Pavel Feldman.

  • inspector/compile-front-end.py: Added.
  • inspector/compile-front-end.sh:
2:10 AM Changeset in webkit [110549] by podivilov@chromium.org
  • 7 edits
    1 copy in trunk/Source/WebCore

Web Inspector: move ResourceScriptMapping to a separate file.
​https://bugs.webkit.org/show_bug.cgi?id=80859

Reviewed by Vsevolod Vlasov.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ResourceScriptMapping.js: Copied from Source/WebCore/inspector/front-end/ScriptMapping.js.

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype.uiSourceCodeList):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
(WebInspector.ResourceScriptMapping.prototype.setFormatSource):
(WebInspector.ResourceScriptMapping.prototype.forceUpdateSourceMapping):
(WebInspector.ResourceScriptMapping.prototype.reset):

  • inspector/front-end/ScriptMapping.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
1:56 AM Changeset in webkit [110548] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping some failing tests.

  • platform/chromium/test_expectations.txt:
1:48 AM Changeset in webkit [110547] by haraken@chromium.org
  • 29 edits
    3 moves in trunk/Source/WebCore

Rename OptionsObject to Dictionary
​https://bugs.webkit.org/show_bug.cgi?id=80802

Reviewed by Adam Barth.

For clarification, rename OptionsObject.{h,cpp} to Dictionary.{h,cpp}.
This patch just renames and sorts alphabetically.

No tests. No change in behavior.

  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):

  • Modules/indexeddb/IDBDatabase.h:

(WebCore::IDBDatabase::createObjectStore):
(IDBDatabase):

  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBKeyRange.h:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::createIndex):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStore.idl:
  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/Dictionary.h: Renamed from Source/WebCore/bindings/js/OptionsObject.h.

(WebCore):
(Dictionary):
(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::isObject):
(WebCore::Dictionary::isUndefinedOrNull):
(WebCore::Dictionary::get):
(WebCore::Dictionary::getWithUndefinedOrNullCheck):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createDictionaryFromValue):

  • bindings/js/IDBBindingUtilities.h:

(WebCore):

  • bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateParametersCheck):
(GenerateEventConstructorCallback):
(GetNativeType):
(JSValueToNative):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::optionsObject):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_options_object):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj optionsObject:ooo:]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::fillTestEventConstructorInit):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::optionsObjectCallback):

  • bindings/v8/Dictionary.cpp: Renamed from Source/WebCore/bindings/v8/OptionsObject.cpp.

(WebCore):
(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::~Dictionary):
(WebCore::Dictionary::operator=):
(WebCore::Dictionary::isObject):
(WebCore::Dictionary::isUndefinedOrNull):
(WebCore::Dictionary::getKey):
(WebCore::Dictionary::get):
(WebCore::Dictionary::getWithUndefinedOrNullCheck):

  • bindings/v8/Dictionary.h: Renamed from Source/WebCore/bindings/v8/OptionsObject.h.

(WebCore):
(Dictionary):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

1:38 AM Changeset in webkit [110546] by shinyak@chromium.org
  • 5 edits in trunk

REGRESSION: Spellcheck tests hit assertions on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=80883

Reviewed by Ryosuke Niwa.

Source/WebKit/mac:

The bug was caused by the closure object created in requestCheckingOfString accessing
request's member variables even though the request object is not an NSObject or allocated
in stack. This resulted in the closure not being able to access those variables when invoked.

Fixed the bug by making local copies of those member variables.

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::requestCheckingOfString):

LayoutTests:

Some words used in spellcheck-paste.js are considered as correct spellings in Mac's spellchecker.
This patch changes them into 'zz' so that Mac's spellchecker can make them as misspelling.

  • editing/spelling/script-tests/spellcheck-paste.js:

(pasteAndVerify.trial):
(pasteAndVerify):
(tests):

  • editing/spelling/spellcheck-paste-expected.txt:
1:27 AM Changeset in webkit [110545] by Nikolas Zimmermann
  • 110 edits
    37 adds in trunk

SVG Animations update baseVal instead of animVal
​https://bugs.webkit.org/show_bug.cgi?id=12437

Reviewed by Dirk Schulze.

Source/WebCore:

Begin implementing the last missing core piece of the SVG DOM: proper animVal support.
Most SVG DOM interfaces exposing eg. lengths use SVGAnimatedLength. eg. from SVGRectElement:
"readonly attribute SVGAnimatedLength x;" SVGAnimatedXXX contains following methods:
"readonly attribute SVGLength baseVal; readonly attribute SVGLength animVal;"
From SVG DOM perspective, animVal and baseVal are two distinctive objects, animVal != baseVal.
Its underlying value is the same though, if no animation is running on that attribute.

As soon as a SMIL animation starts animating an SVGAnimated* target attribute, its
baseVal and animVal may begin to differ. The animVal always reflect the current animated
value (including all effects of additive/accumulated animations) which is shown on screen
when eg animating the width of a <rect>. The baseVal is is equal to the underlying XML
property value / SVG DOM value, but may be influenced through dynamic changes.
(Consider changing rect1.width.baseVal.value while 'width' is animated)

During the last year we prepared our animation code to turn on animVal support.
This patch adds the last missing pieces to turn on animVal support for the SVGLength.
SVGLengthList and all other types will follow, one after the other.

I've decided to write an exhaustive ChangeLog, as this as the base for any future
work in this area - hopefully making this more reviewable.

Tests: svg/animations/additive-from-to-width-animation.html

svg/animations/additive-values-width-animation.html
svg/animations/change-baseVal-while-animating-fill-freeze-2.html
svg/animations/change-baseVal-while-animating-fill-freeze.html
svg/animations/change-baseVal-while-animating-fill-remove-2.html
svg/animations/change-baseVal-while-animating-fill-remove.html
svg/animations/change-target-while-animating-SVG-property.html
svg/animations/multiple-animations-fill-freeze.html
svg/animations/remove-animation-element-while-animation-is-running.html
svg/repaint/repainting-after-animation-element-removal.svg

  • svg/SVGAnimateElement.cpp: Remove unnecessary std namespace inclusion.

(WebCore::SVGAnimateElement::SVGAnimateElement): Remove now-obsolete m_aboutToStopAnimation.
(WebCore::SVGAnimateElement::calculateAnimatedValue): Swap assertion order, to test hasTagName() _before_ casting.
(WebCore::SVGAnimateElement::resetToBaseValue):

Stop relying on the cached baseValue (breaking additive="sum"+values animation) for SVG DOM primitive animations.
Avoid any string roundtrips previously needed to reset the SVGAnimatedType to the base value. Just grab the
currentBaseValue() from the associated SVGAnimatedProperty, which includes all dynamic changes to the baseVal
either by SVG DOM or setAttribute() calls - this way we don't need to utilize the buggy cache in SMILTimeContainer,
which can be removed once all SVG DOM primitive types switched to the new animVal concept.

NOTE: When multiple animations of the same attribute are applied to a target element, resetToBaseValue() will be called
for the highest priority SVGSMILElement, on every animation step! Consider two <animate> elements, applied to a target
<rect> which both animate the 'x' attribute, one from 0s to 2s, the other from 4s to 6s. The last <animate> element
will reuse the SVGAnimatedType m_animatedType from the first <animate> element, and never create an own m_animatedType.
When the animation starts the first time at 0s, we update the rect.x.animVals SVGLength* pointer, to point to the
SVGAnimatedType of the first <animate> element, owning the m_animatedType. From that point on each call to rect.x.animVal
will always return the same value as the SVGAnimatedType of the first <animate> element holds. Now after 2s the first
<animate> element becomes inactive, but its m_animatedType remains alive. The bindings don't notice this change at all.
Now at 4s, the second animation element gets active. It reuses the SVGAnimatedType of the first <animate> element, and
applies its animation changes to that SVGAnimatedType, which is immediately reflected in the bindings w/o any additional
work. It's very important for the understanding when animationStarted/animationEnded need to be called.

(WebCore::SVGAnimateElement::applyResultsToTarget): Remove now-obsolete m_aboutToStopAnimation logic. No need to know it at this point.
(WebCore::SVGAnimateElement::targetElementWillChange):

Renamed from targetElementDidChange(). This method is called from SVGSMILElement for following conditions:

  • animation element is destructed
  • animation element is removed from document
  • target element of animation is destructed
  • target element of animation is removed from document
  • target element of animation changes id

Whenever any of this happens, we need to reset the animVal. Resetting the animVal involves resetting the PropertyType* pointer,
eg. SVGLength*, from the animVal property tear off, belonging to a certain SVGAnimatedProperty (eg. rect.x) to the initial
value again, which is the 'm_x' of the SVGRectElement. This is needed as the SVGAnimatedType the animVal currently points to,
if an animation is/was running, is destructed in targetElementWillChange(), to reset the SVGAnimateElement to the initial
state before it received a target. This is the only place which destructed the m_animatedType, and thus the only place that
needs to take care of resetting the animVal pointers.

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::constructFromCopy):

Add a new constructFromCopy(SVGGenericAnimatedType) function to SVGAnimatedLengthAnimator.
It takes a type-unsafe SVGGenericAnimatedType - the caller has to guarantee the type matches.
This is strictly enforced for the single caller of constructFromCopy, and guaranteed to be safe.

  • svg/SVGAnimatedLength.h: Add new constructFromCopy method, which is used to avoid string-roundtrips when resetting to base values.
  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal): Only returns true for AnimatedLength, for now.
(WebCore::SVGAnimatedType::setVariantValue): Takes a SVGGenericAnimatedType, assuming the type matches. Callers have to guarantee type-safety!

  • svg/SVGAnimatedType.h:

(SVGAnimatedType): Add new static supportsAnimVal(AnimatedPropertyType) function.
(WebCore::SVGAnimatedType::variantValue): Add a generic accessor for all animated types, called variant(). Only one place uses this.

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::constructFromCopy):

New method to construct an eg. SVGAnimatedLengthAnimator right from a SVGLength, instead of a String.
In that case the SVGAnimatedType just stores a pointer to the underlying SVGLength, no copying and or other roundtrips involved.

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::svgAttributeChanged):

Implement this instead of attributeChanged. The previous implementation reset the animation state to Inactive, causing a full
rebuild, whenever any attribute changes, even though it might not be related for the animation element, eg.
animate.setAttribute("stdDeviationX", "foobar"). Fix that by checking if we support the attribute (keyTimes/keySplines/etc..)
, if not pass it on to SVGSMILElement (which supports begin/end/etc..) to check if it can handle that.

(WebCore::SVGAnimationElement::animationAttributeChanged):

Called from our svgAttributeChanged, and/or from SVGSMILElement::svgAttributeChanged, whenever a _known_ attribute has changed.
This sledgehammer should be used with care, instead of each time attributeChanged() is called :-)

(WebCore::setTargetAttributeAnimatedCSSValue):

Remove support for removing properties from the override style sheet. I've added this optimization too early, we should reevaluate
this once more types support animVal. It currently complexifies the logic too much, requiring setAttributeAnimatedValue to know
if the animation ends (and that's not easy to figure out, at least not using started/endedActiveInterval, as I anticipated).

(WebCore::findMatchingAnimatedProperty):

Add helper functions which retrieves a SVGAnimatedProperty* for a given SVGElement* targetElement, an attributeName, and an attribute
type. eg. findMatchingAnimatedProperty(myRectElement, SVGNames::xAttr, AnimatedLength) returns the SVGAnimatedProperty which is
exposed to JS, that holds: SVGProperty* baseVal, and SVGProperty* animVal. (Lazily created if they got accessed from JS.). This is
used to update the animVal pointing to a new eg. SVGLength* value, once animation has started, to make rect->x() return that new
SVGLength* value (internally), and to reflect the current animated value in rect.x.animVal.value from JS.

(WebCore::SVGAnimationElement::applyAnimatedValue): Refactored from setTargetAttributeAnimatedValue, to simplify the code.
(WebCore::notifyAnimatedPropertyAboutAnimationBeginEnd):

Helper function to share code betweeen animationStarted/animationEnded.
It takes a SVGAnimatedProperty* and a SVGAnimatedType* which may be zero, indicating that the animation ended.
It calls animationStarted/animationEnded on the given SVGAnimatedProperty, to update the animVal state.
It also figures out all instances of the target element, and their SVGAnimatedProperties that may need updating.

(WebCore::SVGAnimationElement::animationStarted): Uses the helper above, passing on the given animatedType.
(WebCore::SVGAnimationElement::animationEnded): Uses the helper above, passing 0 as animatedType.
(WebCore::InstanceUpdateBlocker::InstanceUpdateBlocker):

Added new helper struct, doing element->setInstancesUpdatedBlock(true) on construction and setInstancesUpdatesBlocked(false) on
destruction, making it impossible to forget one. If we ever rewrite svgAttributeChanged & co to auto-update the cloned instances,
this can go away.

(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):

Now takes an SVGAnimatedType* instead of a String parameter. In order to avoid string-roundtrips for animVal support, let us
decide if we need to construct a String out of it, or not. For animations supporting animVal (only SVGLength) we don't need
to update any attribute or animVal pointer here, that happens automatically! We only need to notify the targetElement eg,
that its xAttr changed! Previously we had to call targetElement->setAttribute("x", "...") on every animation step for
SVGLength animations - that's gone now! The SVGAnimatedType pointers remains the same during the whole animation, so there's
no need to call animationStarted() at each animated step!

(WebCore::SVGAnimationElement::animatedPropertyForType):

Helper function returning a SVGAnimatedProperty* for the current target element & current target attribute, if the
current animation is running on a type supporting animVal (SVGLength), or returning 0. This is needed for SVGAnimateElement.
Reuses the existing findMatchingAnimatedProperty code.

  • svg/SVGAnimationElement.h:
  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

Add comment to clarify why caching baseValues is just wrong. For SVGLength animations the problem is now gone.
This is exercised using the new additive-from-to-width-animation.html & additive-values-width-animation.html tests.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::removedFromDocument):

Since animVal requires that the SVGAnimatedProperties are correctly reset if an animation element is removed from the document,
we have to call targetElementWillChange(0) from here. That requires to move the "m_attributeName = anyQName()" line down,
otherwise targetElementWillChange() would early exit, as no valid attributeName was specified.

This is verified using the new svg/animations/remove-animation-element-while-animation-is-running.html
and svg/repaint/repainting-after-animation-element-removal.svg tests.

(WebCore::SVGSMILElement::isSupportedAttribute): Add function like all SVG*Elements have identifying their supported attributes.
(WebCore::SVGSMILElement::svgAttributeChanged):

Implement svgAttributeChanged instead of attributeChanged. Only take action if the attribute is actually supported.
If one of the common attributes like begin/end/etc. changed, be sure to call animationAttributeChanged() so that our
ancestor-classes get notified about this and can take action as well. NOTE: This is not about animating begin/end attributes,
but about pure DOM changes. begin/end/et.. are not exposed to the SVG DOM, we still reuse the svgAttributeChanged logic
for consistency. (This does NOT make those attributes animatable, nothing this here as it came up while reviewing).

(WebCore::SVGSMILElement::targetElement): Adapt logic to targetElementDidChange -> targetElementWillChange change.
(WebCore::SVGSMILElement::targetElementWillChange):

Renamed from targetElementDidChange. Added "oldTarget" as parameter as well. Our ancestor-classes like SVGAnimateElement
use this to properly deregister the animVal in the old target, before resetting the SVGAnimatedType, otherwise we'd leave
dangling pointers around (verified manually by guard malloc runs, that none of this happens).

Also add a default implementation here in targetElementWillChange, that ancestor classes have to call.
Now we properly call endedActiveInterval() if the m_activeState is currently Active, so that animations are shut-down
just like if the animation properly ends (use the same cleanup routines, etc.). Not doing that now leads to assertions.

(WebCore::SVGSMILElement::resetTargetElement):

Instead of forcing m_activeState to be inactive, use the standard methods to end the animation.
targetElementWillChange(m_targetElement, 0) and animationAttributeChanged().

resetTargetElement() is only called by SVGDocumentExtensions::removeAllAnimationElementsFromTarget() for following conditions:

  • targetElement gets destructed
  • targetElement gets removed from the document
  • targetElement id changes

If the targetElement gets destructed or removed, no actions need to be taken, as the SVGAnimatedPropertys are teared down
as well. But if only the id changes, we still have to properly disconnect the animVals - this is all handled through
targetElementWillChange now - that's why this has to be called from here as well.
That explains why targetElementWillChange() now needs to check if the targetElement is destructing or not.

  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:

Pass the AnimatedPropertyType from the SVGPropertyInfo to the SVGAnimatedProperties.
Requires mechanic changes in all SVGAnimated* classes. We need acccess to the AnimatedPropertyType
to verify the SVGAnimatedType objects, passed to animationStarted, match our type. This is to enforce
strict type-checking, whenever SVGGenericAnimatedTypes are passed around.

(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::SVGAnimatedEnumerationPropertyTearOff):

  • svg/properties/SVGAnimatedListPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedListPropertyTearOff::create):
(WebCore::SVGAnimatedListPropertyTearOff::SVGAnimatedListPropertyTearOff):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedPathSegListPropertyTearOff::create):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):

  • svg/properties/SVGAnimatedProperty.h: Store AnimatedPropertyType, add accessors.

(WebCore::SVGAnimatedProperty::animatedPropertyType): Add accessor.
(WebCore::SVGAnimatedProperty::animationValueChanged): New animVal related functions to be implemented in the animated tear offs.
(WebCore::SVGAnimatedProperty::animationStarted): Ditto.
(WebCore::SVGAnimatedProperty::animationEnded): Ditto.
(WebCore::SVGAnimatedProperty::currentBaseValue):

Generic accessor for the baseVal: returns a SVGGenericAnimatedType.
It takes an AnimatedPropertyType as input, that's only needed to verify that the type we're returning matches
the expectation of the caller. If not, return 0 to avoid any potential casting mistakes, which would lead to crashes.

(WebCore::SVGAnimatedProperty::SVGAnimatedProperty): Store m_animatedPropertyType.

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::create): Same changes as in the other tear offs: pass around AnimatedPropertyType.
(WebCore::SVGAnimatedPropertyTearOff::currentBaseValue): Returns &m_property, if the type matches (see above).
(SVGAnimatedPropertyTearOff): Pass around AnimatedPropertyType.
(WebCore::SVGAnimatedPropertyTearOff::animationValueChanged): No-op for non list types, don't need to do anything here.
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):

Store the currently animated value in the animVal() property tear off, that's also re-used as-is for the JS bindings.
As this is important, here's an example of how this affects methods like rect->x() used in the renderers.

Setting m_isAnimating to true, redirects any rect->x() calls that previously returned rect->m_x, to
rect->xAnimated()->animVal()->propertyReference() (which returns the same SVGLength& that the SVGAnimatedElement
m_animatedType contains). Calling rect->setXBaseValue() still modifies rect->m_x, and is used by all parseAttribute()
methods in svg/ as setAttribute() calls only ever modify the "baseValue", never the current animated value.
rect.x.baseVal will return a SVGLength object corresponding to rect->m_x.
rect.x.animVal will return a SVGLength object corresponding to rect->xAnimated()->animVal()->propertyReference().

These implementation details are all hidden in the SVGAnimatedPropertyMacros. Here's an example from SVGRectElement:
DECLARE_ANIMATED_LENGTH(X, x) -> Replace PropertyType with 'SVGLength', LowerProperty with 'x', and UpperProperty with 'X'.

PropertyType& LowerProperty() const
{

if (TearOffType* wrapper = SVGAnimatedProperty::lookupWrapper<UseOwnerType, TearOffType, IsDerivedFromSVGElement<UseOwnerType>::value>(this, LowerProperty##PropertyInfo())) {

if (wrapper->isAnimating())

return wrapper->currentAnimatedValue();

}
return m_##LowerProperty.value;

}

PropertyType& LowerProperty##BaseValue() const
{

return m_##LowerProperty.value;

}

void set##UpperProperty##BaseValue(const PropertyType& type)
{

m_##LowerProperty.value = type;

}

Any code outside of svg/, eg. in rendering/svg, does not need to care about any baseVal/animVal differences.
During layout eg. RenderSVGRect calls rect->x().value(someLengthContext) to get the current 'x' as float. If an animation
is running on that rect element it will automatically retrieve the last set animated value here - all under the hood.
I hope that sheds some light in those myserious functions, they were designed with animVal in mind, but we never had that until now :-)

(WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff): Pass around AnimatedPropertyType.
(WebCore::SVGAnimatedPropertyTearOff::~SVGAnimatedPropertyTearOff): Add destructor to debug builds veryifing that m_isAnimating is false.

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedStaticPropertyTearOff::create):
(WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):

  • svg/properties/SVGAnimatedTransformListPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedTransformListPropertyTearOff::create):
(WebCore::SVGAnimatedTransformListPropertyTearOff::SVGAnimatedTransformListPropertyTearOff):

  • svg/properties/SVGPropertyInfo.h: Add SVGGenericAnimatedType definition.
  • svg/properties/SVGPropertyTearOff.h: Remove obsolete updateAnimVal method - switched to using setValue directly.

LayoutTests:

Update test expectations after turning on animVal support for SVGLength, the first primitive now support animVal.
Added several new tests, checking additive behaviour with SVGLength objects, removing animation elements
while animations are running (+ test repainting of those cases), etc.

  • platform/mac/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/mac/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.
  • svg/animations/additive-from-to-width-animation-expected.txt: Added.
  • svg/animations/additive-from-to-width-animation.html: Added.
  • svg/animations/additive-values-width-animation-expected.txt: Added.
  • svg/animations/additive-values-width-animation.html: Added.
  • svg/animations/animVal-basics-expected.txt:
  • svg/animations/animate-calcMode-spline-by-expected.txt:
  • svg/animations/animate-calcMode-spline-from-by-expected.txt:
  • svg/animations/animate-calcMode-spline-from-to-expected.txt:
  • svg/animations/animate-calcMode-spline-to-expected.txt:
  • svg/animations/animate-calcMode-spline-values-expected.txt:
  • svg/animations/animate-elem-02-t-drt-expected.txt:
  • svg/animations/animate-elem-09-t-drt-expected.txt:
  • svg/animations/animate-elem-10-t-drt-expected.txt:
  • svg/animations/animate-elem-11-t-drt-expected.txt:
  • svg/animations/animate-elem-12-t-drt-expected.txt:
  • svg/animations/animate-elem-13-t-drt-expected.txt:
  • svg/animations/animate-elem-14-t-drt-expected.txt:
  • svg/animations/animate-elem-15-t-drt-expected.txt:
  • svg/animations/animate-elem-16-t-drt-expected.txt:
  • svg/animations/animate-elem-17-t-drt-expected.txt:
  • svg/animations/animate-elem-18-t-drt-expected.txt:
  • svg/animations/animate-elem-19-t-drt-expected.txt:
  • svg/animations/animate-end-attribute-expected.txt:
  • svg/animations/animate-endElement-beginElement-expected.txt:
  • svg/animations/animate-from-to-keyTimes-expected.txt:
  • svg/animations/animate-insert-begin-expected.txt:
  • svg/animations/animate-insert-no-begin-expected.txt:
  • svg/animations/animate-keySplines-expected.txt:
  • svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt:
  • svg/animations/attributeTypes-expected.txt:
  • svg/animations/change-baseVal-while-animating-fill-freeze-2-expected.txt: Added.
  • svg/animations/change-baseVal-while-animating-fill-freeze-2.html: Added.
  • svg/animations/change-baseVal-while-animating-fill-freeze-expected.txt: Added.
  • svg/animations/change-baseVal-while-animating-fill-freeze.html: Added.
  • svg/animations/change-baseVal-while-animating-fill-remove-2-expected.txt: Added.
  • svg/animations/change-baseVal-while-animating-fill-remove-2.html: Added.
  • svg/animations/change-baseVal-while-animating-fill-remove-expected.txt: Added.
  • svg/animations/change-baseVal-while-animating-fill-remove.html: Added.
  • svg/animations/change-target-while-animating-SVG-property-expected.txt: Added.
  • svg/animations/change-target-while-animating-SVG-property.html: Added.
  • svg/animations/multiple-animations-fill-freeze-expected.txt: Added.
  • svg/animations/multiple-animations-fill-freeze.html: Added.
  • svg/animations/remove-animation-element-while-animation-is-running-expected.txt: Added.
  • svg/animations/remove-animation-element-while-animation-is-running.html: Added.
  • svg/animations/resources/additive-from-to-width-animation.svg: Added.
  • svg/animations/resources/additive-values-width-animation.svg: Added.
  • svg/animations/resources/change-baseVal-while-animating-fill-freeze.svg: Added.
  • svg/animations/resources/change-baseVal-while-animating-fill-remove.svg: Added.
  • svg/animations/resources/change-target-while-animating-SVG-property.svg: Added.
  • svg/animations/resources/multiple-animations-fill-freeze.svg: Added.
  • svg/animations/resources/remove-animation-element-while-animation-is-running.svg: Added.
  • svg/animations/script-tests/additive-from-to-width-animation.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/additive-values-width-animation.js: Added.

(sample1):
(sample2):
(sample3):
(changeBaseVal):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/animVal-basics.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-by.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-from-by.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-from-to.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-to.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-values.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-elem-02-t-drt.js:

(sampleAfterBegin):
(sampleAfterMid):
(sampleAfterBeginOfFirstRepetition):
(sampleAfterMidOfFirstRepetition):

  • svg/animations/script-tests/animate-elem-09-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-10-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-11-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-12-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-13-t-drt.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-elem-14-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-15-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-16-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-17-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-18-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-19-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-end-attribute.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-endElement-beginElement.js:

(sample1):

  • svg/animations/script-tests/animate-from-to-keyTimes.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-insert-begin.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-insert-no-begin.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-keySplines.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/attributeTypes.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/change-baseVal-while-animating-fill-freeze-2.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-baseVal-while-animating-fill-freeze.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-baseVal-while-animating-fill-remove-2.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-baseVal-while-animating-fill-remove.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-target-while-animating-SVG-property.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/multiple-animations-fill-freeze.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):
(executeTest):

  • svg/animations/script-tests/remove-animation-element-while-animation-is-running.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeHeight.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-LengthModeOther.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-LengthModeWidth.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-invalid-value-1.js:

(sample2):

  • svg/animations/script-tests/svglength-animation-invalid-value-2.js:

(sample2):

  • svg/animations/script-tests/svglength-animation-invalid-value-3.js:

(sample2):

  • svg/animations/script-tests/svglength-animation-number-to-number.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-cm.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-ems.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-exs.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-in.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-number.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-pc.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-percentage.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-pt.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-px.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-unitType.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-values.js:

(sample2):
(sample3):
(sample4):
(sample5):

  • svg/animations/svglength-animation-LengthModeHeight-expected.txt:
  • svg/animations/svglength-animation-LengthModeOther-expected.txt:
  • svg/animations/svglength-animation-LengthModeWidth-expected.txt:
  • svg/animations/svglength-animation-invalid-value-1-expected.txt:
  • svg/animations/svglength-animation-invalid-value-2-expected.txt:
  • svg/animations/svglength-animation-invalid-value-3-expected.txt:
  • svg/animations/svglength-animation-number-to-number-expected.txt:
  • svg/animations/svglength-animation-px-to-cm-expected.txt:
  • svg/animations/svglength-animation-px-to-ems-expected.txt:
  • svg/animations/svglength-animation-px-to-exs-expected.txt:
  • svg/animations/svglength-animation-px-to-in-expected.txt:
  • svg/animations/svglength-animation-px-to-number-expected.txt:
  • svg/animations/svglength-animation-px-to-pc-expected.txt:
  • svg/animations/svglength-animation-px-to-percentage-expected.txt:
  • svg/animations/svglength-animation-px-to-pt-expected.txt:
  • svg/animations/svglength-animation-px-to-px-expected.txt:
  • svg/animations/svglength-animation-unitType-expected.txt:
  • svg/animations/svglength-animation-values-expected.txt:
  • svg/repaint/repainting-after-animation-element-removal.svg: Added.
1:12 AM Changeset in webkit [110544] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSSPropertyTextOverflow in CSSStyleApplyProperty.
​https://bugs.webkit.org/show_bug.cgi?id=80934

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

12:28 AM Changeset in webkit [110543] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, inspector test rebaseline after r110532.

  • inspector/styles/svg-style-expected.txt:
12:24 AM Changeset in webkit [110542] by commit-queue@webkit.org
  • 16 edits
    7 adds in trunk/LayoutTests

[Forms] Re-factor label.for tests for extending test coverage
​https://bugs.webkit.org/show_bug.cgi?id=80574

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes label.labels attribute testing with using shared
utility functions, createFormControlDataSet for representing form
related information of HTML5 specification and setupLabelsTeset for
populating test sample dom tree and data set.

This patch extends coverage of existing label.labels test to cover
defined in the specification, labelable-elements.html, and adds
multiple label entries tests, labels-multiple-*.html.

Note: test failure of hidden input type will be fixed by
​https://bugs.webkit.org/show_bug.cgi?id=80403

Note: test failure of output element will be fixed by
​https://bugs.webkit.org/show_bug.cgi?id=80466

  • fast/forms/label/labelable-elements-expected.txt: Added.
  • fast/forms/label/labelable-elements.html: Added.
  • fast/forms/label/labels-add-htmlFor-label-expected.txt:
  • fast/forms/label/labels-add-htmlFor-label.html:
  • fast/forms/label/labels-add-parent-label-expected.txt:
  • fast/forms/label/labels-add-parent-label.html:
  • fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-change-htmlFor-attribute.html:
  • fast/forms/label/labels-multiple-sibling-labels-expected.txt: Added.
  • fast/forms/label/labels-multiple-sibling-labels.html: Added.
  • fast/forms/label/labels-parent-and-sibling-labels-expected.txt: Added.
  • fast/forms/label/labels-parent-and-sibling-labels.html: Added.
  • fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-attribute.html:
  • fast/forms/label/labels-remove-htmlFor-label-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-label.html:
  • fast/forms/label/labels-remove-parent-label-expected.txt:
  • fast/forms/label/labels-remove-parent-label.html:
  • fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-set-htmlFor-attribute.html:
  • fast/forms/resources/common.js:

(createFormControlDataSet): Returns form control data set for providing
labelable elements and supported elements information.

  • fast/forms/resources/label-test-util.js: Added.

(setupLabelsTest.return.dataSet.dataSet.getLabelableElementData):
(setupLabelsTest): Populate dom tree for unit tests.

Note: See TracTimeline for information about the timeline view.