Timeline



Mar 5, 2013:

11:59 PM Changeset in webkit [144891] by eric@webkit.org
  • 21 edits in trunk/Source/WebCore

Replace shouldLazyAttach bool with an enum for readability
​https://bugs.webkit.org/show_bug.cgi?id=111503

Reviewed by Dimitri Glazkov.

No behavioral change.

  • bindings/cpp/WebDOMNodeCustom.cpp:

(WebDOMNode::insertBefore):
(WebDOMNode::replaceChild):
(WebDOMNode::appendChild):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::insertBefore):
(WebCore::JSNode::replaceChild):
(WebCore::JSNode::appendChild):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore):
(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

  • dom/ContainerNode.cpp:

(WebCore):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::updateTreeAfterInsertion):

  • dom/ContainerNode.h:

(ContainerNode):

  • dom/Node.cpp:

(WebCore::Node::insertBefore):
(WebCore::Node::replaceChild):
(WebCore::Node::appendChild):

  • dom/Node.h:

(Node):

  • editing/AppendNodeCommand.cpp:

(WebCore::AppendNodeCommand::doApply):

  • editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doApply):

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::createControls):

  • html/shadow/MediaControlsBlackBerry.cpp:

(WebCore::MediaControlsBlackBerry::createControls):

  • html/shadow/MediaControlsChromium.cpp:

(WebCore::MediaControlsChromium::initializeControls):

  • html/shadow/MediaControlsChromiumAndroid.cpp:

(WebCore::MediaControlsChromiumAndroid::createControls):

11:57 PM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
11:54 PM Changeset in webkit [144890] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK][WK2] Add WebKitWebPage::webkit_web_page_get_uri to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=111288

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-05
Reviewed by Carlos Garcia Campos.

Add new property URI to WebKitWebPage providing a method
webkit_web_page_get_uri to get it and the signal "notify::uri" to
monitor changes in the URI.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include new method in

GTK+ doc.

  • UIProcess/API/gtk/tests/TestLoaderClient.cpp:

(testWebPageURI):
(beforeAll):
(afterAll): Add test to check that WebKitWebPage URI matches with
WebKitWebView value. The tests is listening for changes in WebKitWebPage
URI via D-Bus and checks that value is the same than WebKitWebView URI.
It also checks that the order of the URIs in a redirection is right.

  • UIProcess/API/gtk/tests/WebExtensionTest.cpp:

(uriChangedCallback):
(pageCreatedCallback): Add new D-Bus signal "URIChanged" connected to
"notify::uri" signal of WebKitWebPage.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(_WebKitWebPagePrivate): Add new URI attribute.
(webkitWebPageSetURI): Method to set the URI and emit the "notify:uri"
signal if it has changed.
(didStartProvisionalLoadForFrame): At this point it use the unreachable
URL from provisional document loader if any. Otherwise, it uses the URL
from provisional document loader.
(didReceiveServerRedirectForProvisionalLoadForFrame): In the case of
redirections it works like for didStartProvisionalLoadForFrame getting
the unreachable URL if any.
(didSameDocumentNavigationForFrame): In this case it gets the URL from
the document loader.
(webkitWebPageGetProperty): Add code related to URI property.
(webkit_web_page_class_init): Add bits related to URI property.
(webkitWebPageCreate): Implement callbacks to monitor URI changes.
(webkit_web_page_get_uri): Return URI attribute.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h: Add new method

header.

11:53 PM Changeset in webkit [144889] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

Custom Elements: CustomElementConstructor::m_name doesn't have any good use.
​https://bugs.webkit.org/show_bug.cgi?id=111523

Reviewed by Kentaro Hara.

This change removes CustomElementConstructor::m_name and renames
m_tagName to m_name. Now generated function name is same as interface name.

Originally, m_name was added to specify the generated constructor
name. An early version of custom element allows to give the name,
but it no longer says anything about that.

The rename is to align the semantics of type extension mechanism
of Custom Elements, where the name of a custom element isn't
necessarily a tag name.

No new tests. Just removing old code.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::create):
(WebCore::CustomElementConstructor::CustomElementConstructor):
(WebCore::CustomElementConstructor::createElement):

  • dom/CustomElementConstructor.h:

(CustomElementConstructor):
(WebCore::CustomElementConstructor::name):

  • dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::registerElement):

11:43 PM Changeset in webkit [144888] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Provide node context info in a popover when mouse hovers over a flame chart item.
​https://bugs.webkit.org/show_bug.cgi?id=111442

Reviewed by Yury Semikhatsky.

FlameChart is a canvas so it is not possible to attach the popover to the items on it.
It would be a bit tricky to support an offset due to complex behaviour of the popover.
The simplest solution is to create a fake anchor element and move it to the right position.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
(WebInspector.FlameChart.prototype._showPopover):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype.findNodeCallback):
(WebInspector.FlameChart.prototype._coordinatesToNode):
(WebInspector.FlameChart.prototype.onResize):

  • inspector/front-end/flameChart.css:

(.flame-chart .item-anchor):

11:37 PM Changeset in webkit [144887] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Ensure right format is used in SnapshotImageGL.
​https://bugs.webkit.org/show_bug.cgi?id=111333

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-03-05
Reviewed by Benjamin Poulain.

GL_BGRA format is not standard for glReadPixels with GLES.
This patch ensures that GL_RGBA is used in SnapshotImageGL
while using GLES.

  • UIProcess/API/efl/SnapshotImageGL.cpp:

(getImageSurfaceFromFrameBuffer):

11:32 PM Changeset in webkit [144886] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Get rid of the invert argument to SpeculativeJIT::jumpSlowForUnwantedArrayMode
​https://bugs.webkit.org/show_bug.cgi?id=105624

Reviewed by Oliver Hunt.

All callers pass invert = false, which is the default value of the argument. So, get
rid of the argument and fold away all code that checks it.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

10:59 PM Changeset in webkit [144885] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

Unreviewed buildfix after r144787. Add missing USE(GRAPHICS_SURFACE) guards.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::setLayerState):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):

10:54 PM Changeset in webkit [144884] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Autoreleased cached pages slow down the PLT by 2%
​https://bugs.webkit.org/show_bug.cgi?id=111522

Reviewed by Filip Pizlo.

Let's stop doing that.

2% PLT speedup.

  • history/PageCache.cpp:

(WebCore::PageCache::remove):

10:43 PM Changeset in webkit [144883] by Claudio Saavedra
  • 1 edit
    3 moves in trunk/LayoutTests

Make toggle-unlink.html test Mac specific behaviour
​https://bugs.webkit.org/show_bug.cgi?id=111321

Reviewed by Ryosuke Niwa.

A new test for Windows behavior will have to be added once bug
110487 is landed.

  • editing/execCommand/script-tests/toggle-unlink-mac.js: Renamed

from
LayoutTests/editing/execCommand/script-tests/toggle-unlink.js.
Also set editing behaviour to Mac.

  • editing/execCommand/toggle-unlink-mac-expected.txt: Renamed from

LayoutTests/editing/execCommand/toggle-unlink-expected.txt.

  • editing/execCommand/toggle-unlink-mac.html: Renamed from

LayoutTests/editing/execCommand/toggle-unlink.html.

10:27 PM Changeset in webkit [144882] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

Patch by Vsevolod Vlasov <​vsevik@chromium.org> on 2013-03-05

  • platform/chromium/TestExpectations:
10:09 PM Changeset in webkit [144881] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/TestExpectations:
9:48 PM Changeset in webkit [144880] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a flaky crash test expectation to editing/selection/selection-invalid-offset.html
on Mac per bug 111521.

  • platform/mac/TestExpectations:
9:32 PM Changeset in webkit [144879] by fpizlo@apple.com
  • 2 edits
    6 adds in trunk/LayoutTests

Add test coverage for DCE and type checks.

Rubber stamped by Geoffrey Garen.

  • fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-and-decrement-expected.txt: Added.
  • fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-and-decrement.html: Added.
  • fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-expected.txt: Added.
  • fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-and-decrement.js: Added.

(foo):

  • fast/js/script-tests/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null.js: Added.

(foo):

9:23 PM Changeset in webkit [144878] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations: http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html
9:16 PM Changeset in webkit [144877] by hayato@chromium.org
  • 19 edits
    2 adds in trunk

[Shadow] Implements event re-targeting for Touch Events.
​https://bugs.webkit.org/show_bug.cgi?id=107800

Reviewed by Dimitri Glazkov.

Source/WebCore:

So far, Touch Events have been intentionally disabled in shadow
tree since it allows users to access internal nodes in shadow tree
by accessing Touch Event's information.

This patch re-targets all individual touch point's target in
TouchList (touches, targetTouches and changedTouches) owned by a Touch Event
before the Touch Event is dispatched so that we won't break an
upper boundary of shadow DOM.

Touch Events re-targeting is similar to that of Mouse Events
re-targeting. The difference is that a Touch Event can have more
than one related target because of multiple touches. We must
re-target all individual touch points which can be referred from
the Touch Event.

Now, Touch Events can be fired in shadow tree. I've removed the
existing limitation.

Test: fast/dom/shadow/touch-event-retargeting.html

  • dom/EventContext.cpp:

(WebCore::EventContext::isTouchEventContext):
(WebCore):
(WebCore::TouchEventContext::TouchEventContext):
(WebCore::TouchEventContext::~TouchEventContext):
(WebCore::TouchEventContext::handleLocalEvents):
(WebCore::TouchEventContext::isTouchEventContext):
(WebCore::TouchEventContext::checkReachability): Used for assertion of reachability for each Touch point.

  • dom/EventContext.h:

(WebCore):
(EventContext):
(TouchEventContext): Introduced to hold necessary information for re-targeting Touch event.
(WebCore::TouchEventContext::touches):
(WebCore::TouchEventContext::targetTouches):
(WebCore::TouchEventContext::changedTouches):
(WebCore::EventContext::isReachable):

  • dom/EventRetargeter.cpp:

(WebCore::EventRetargeter::calculateEventPath):
(WebCore::EventRetargeter::adjustForTouchEvent):
(WebCore):
(WebCore::EventRetargeter::adjustTouchList):
(WebCore::EventRetargeter::adjustForRelatedTarget):
(WebCore::EventRetargeter::calculateAdjustedNodes): Updated so that this can be used for Touch point re-targeting.
(WebCore::EventRetargeter::buildRelatedNodeMap):

  • dom/EventRetargeter.h:

(WebCore):
(EventRetargeter):

  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):
(WebCore):
(WebCore::Node::dispatchTouchEvent):

  • dom/Node.h:

(WebCore):
(Node):

  • dom/Touch.cpp:

(WebCore::Touch::Touch):
(WebCore):
(WebCore::Touch::cloneWithNewTarget):

  • dom/Touch.h:

(Touch):

  • dom/TouchEvent.cpp:

(WebCore::TouchEventDispatchMediator::create):
(WebCore):
(WebCore::TouchEventDispatchMediator::TouchEventDispatchMediator):
(WebCore::TouchEventDispatchMediator::event):
(WebCore::TouchEventDispatchMediator::dispatchEvent):

  • dom/TouchEvent.h:

(TouchEvent):
(WebCore::TouchEvent::setTouches):
(WebCore::TouchEvent::setTargetTouches):
(WebCore::TouchEvent::setChangedTouches):
(TouchEventDispatchMediator):
(WebCore):
(WebCore::toTouchEvent):

  • dom/TouchList.cpp:

(WebCore::TouchList::item):
(WebCore):

  • dom/TouchList.h:

(TouchList):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultInFrame): Removed the limitation. Adjusting is no longer done here.
(WebCore::EventHandler::handleTouchEvent):

LayoutTests:

  • fast/dom/shadow/resources/event-dispatching.js:

(recordEvent):
(dumpTouchList):
(sortDispatchedEvent):
(showSandboxTree):

  • fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html:
  • fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt:
  • fast/dom/shadow/touch-event-retargeting-expected.txt: Added.
  • fast/dom/shadow/touch-event-retargeting.html: Added.
8:49 PM Changeset in webkit [144876] by fpizlo@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

Add test coverage for DCE and type checks.

Rubber stampted by Geoffrey Garen.

  • fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-typeof-expected.txt: Added.
  • fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-typeof.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-cfg-simplify-eliminate-set-local-type-check-then-typeof.js: Added.

(foo):

8:27 PM Changeset in webkit [144875] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. AppleWin port.

  • platform/win/TestExpectations:
8:22 PM Changeset in webkit [144874] by fpizlo@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

DFG may infer an edge to be a double-using edge and then later experience multiple-personality disorder with respect to that particular decision
​https://bugs.webkit.org/show_bug.cgi?id=109393

Rubber stamped by Geoffrey Garen.

  • fast/js/dfg-double-addition-simplify-to-int-expected.txt: Added.
  • fast/js/dfg-double-addition-simplify-to-int.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-double-addition-simplify-to-int.js: Added.

(foo):

8:17 PM Changeset in webkit [144873] by roger_fong@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed gardening. AppleWin port.

  • platform/win/cssom: Added.
  • platform/win/cssom/cssvalue-comparison-expected.txt: Added.
8:04 PM Changeset in webkit [144872] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. AppleWin port.

Patch by Roger Fong <​roger_fong@apple.com> on 2013-03-05

  • platform/win/TestExpectations:
  • platform/win/fast/forms/number: Added.
  • platform/win/fast/forms/number/number-l10n-input-expected.txt: Added.
7:59 PM Changeset in webkit [144871] by roger_fong@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed gardening. AppleWin port.

  • platform/win/TestExpectations:
  • platform/win/fast/forms/number: Added.
  • platform/win/fast/forms/number/number-l10n-input-expected.txt: Added.
7:54 PM Changeset in webkit [144870] by dpranke@chromium.org
  • 2 edits in trunk/Tools

[chromium] don't use custom freetype on linux asan for now
​https://bugs.webkit.org/show_bug.cgi?id=111516

Unreviewed, build fix.

Turns out the custom lib is getting picked up by other binaries
on our bot, which is bad.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
7:52 PM Changeset in webkit [144869] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations: plugins/plugin-clip-subframe.html
7:28 PM Changeset in webkit [144868] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations: fast/regions/region-style-in-columns.html
7:27 PM Changeset in webkit [144867] by dpranke@chromium.org
  • 2 edits in trunk/Tools

[chromium] making DumpRenderTree_resources a separate bundle breaks xcode
​https://bugs.webkit.org/show_bug.cgi?id=111509

Unreviewed, build fix.

Actually comment out the flag :(.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
7:07 PM Changeset in webkit [144866] by dpranke@chromium.org
  • 2 edits in trunk/Tools

[chromium] making DumpRenderTree_resources a separate bundle breaks xcode
​https://bugs.webkit.org/show_bug.cgi?id=111509

Unreviewed, build fix.

r144863 appears to have broken the xcode build; I'm temporarily
trying this instead, and if this doesn't work, I'll revert the
other changes.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
6:52 PM Changeset in webkit [144865] by morrita@google.com
  • 6 edits in trunk/Source/WebCore

[Custom Elements][V8] Custom Element doesn't need its own WrapperTypeInfo
​https://bugs.webkit.org/show_bug.cgi?id=111411

Reviewed by Kentaro Hara.

No new tests. No observable change yet.

This is a preparation for Bug 110436, where WebKit is going to
allow any HTML element to be a superclass of custom elements.

This change eliminates WrapperTypeInfo for custom element. Instead
of that, the wrapper of a custom element picks WrapperTypeInfo
from most descendant built-in HTML element. For example, think about
following hierarchy:

  • ... <- HTMLElement <- HTMLDivElememnt <- ExistingCustomElement <- NewCustomElement

In this case, both ExistingCustomElement and NewCustomElement has
HTMLDivElememnt's type info. This is because HTMLDivElememnt is
the most descendant (or "the nearest") built-in HTML
element. (HTMLElement isn't the most descendant.
ExistingCustomElement isn't a built-in.)

Using such WrapperTypeInfos, created custom element wrappers can
get appropriate set of method and properties regardless of its
super-elements.

This change tells the prototype object of each built-in object
which WrapperTypeInfo the native backing wants:
HTMLDivElememnt.prototype knows V8HTMLDivElement::info for
example. The pointer to the type info is stored into an internal
field. On wrapper construction, createWrapper() walks up the
prototype chain and pick the first one.

  • bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::configureTemplate):

  • bindings/v8/V8HTMLCustomElement.cpp:

(WebCore::findWrapperTypeOf):
(WebCore::V8HTMLCustomElement::createWrapper):

  • bindings/v8/V8HTMLCustomElement.h:
  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::constructorForTypeSlowCase):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):

6:51 PM Changeset in webkit [144864] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix an incorrect comment. The comment was a holdover from a work-in-progress version of this code.

  • dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::run):

6:37 PM Changeset in webkit [144863] by dpranke@chromium.org
  • 2 edits in trunk/Tools

[chromium] build a DumpRenderTree.pak even on windows
​https://bugs.webkit.org/show_bug.cgi?id=111504

Reviewed by Tony Chang.

The Chromium Aura build uses the default theme to draw
controls, and that theme requires the ui ResourceBundle
to be initialized. On every other platform, we build
a DumpRenderTree.pak that works for this, but on Windows we
still compile the resources directly into DRT. As a first step,
let's build the pak file. I will then need to land a patch
in Chromium to actually load it. Then I can go back and move
the resources over to just use the .pak file and no longer need
the .rc's.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
6:27 PM Changeset in webkit [144862] by fpizlo@apple.com
  • 33 edits
    8 adds in trunk

DFG DCE might eliminate checks unsoundly
​https://bugs.webkit.org/show_bug.cgi?id=109389

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This gets rid of all eager reference counting, and does all dead code elimination
in one phase - the DCEPhase. This phase also sets up the node reference counts,
which are then used not just for DCE but also register allocation and stack slot
allocation.

Doing this required a number of surgical changes in places that previously relied
on always having liveness information. For example, the structure check hoisting
phase must now consult whether a VariableAccessData is profitable for unboxing to
make sure that it doesn't try to do hoisting on set SetLocals. The arguments
simplification phase employs its own light-weight liveness analysis. Both phases
previously just used reference counts.

The largest change is that now, dead nodes get turned into Phantoms. Those
Phantoms will retain those child edges that are not proven. This ensures that any
type checks performed by a dead node remain even after the node is killed. On the
other hand, this Phantom conversion means that we need special handling for
SetLocal. I decided to make the four forms of SetLocal explicit:

MovHint(@a, rK): Just indicates that node @a contains the value that would have

now been placed into virtual register rK. Does not actually cause @a to be
stored into rK. This would have previously been a dead SetLocal with @a
being live. MovHints are always dead.


ZombieHint(rK): Indicates that at this point, register rK will contain a dead

value and OSR should put Undefined into it. This would have previously been
a dead SetLocal with @a being dead also. ZombieHints are always dead.


MovHintAndCheck(@a, rK): Identical to MovHint except @a is also type checked,

according to whatever UseKind the edge to @a has. The type check is always a
forward exit. MovHintAndChecks are always live, since they are
NodeMustGenerate. Previously this would have been a dead SetLocal with a
live @a, and the check would have disappeared. This is one of the bugs that
this patch solves.


SetLocal(@a, rK): This still does exactly what it does now, if the SetLocal is

live.


Basically this patch makes it so that dead SetLocals eventually decay to MovHint,
ZombieHint, or MovHintAndCheck depending on the situation. If the child @a is
also dead, then you get a ZombieHint. If the child @a is live but the SetLocal
has a type check and @a's type hasn't been proven to have that type then you get
a MovHintAndCheck. Otherwise you get a MovHint.

This is performance neutral.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::mergeStateAtTail):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):

  • dfg/DFGBasicBlock.h:

(BasicBlock):

  • dfg/DFGBasicBlockInlines.h:

(DFG):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::insertPhiNode):
(JSC::DFG::ByteCodeParser::emitFunctionChecks):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::run):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):

  • dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::addPhiSilently):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.cpp:

(WTF::printInternal):
(WTF):

  • dfg/DFGCommon.h:

(WTF):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
(JSC::DFG::ConstantFoldingPhase::paintUnreachableCode):

  • dfg/DFGDCEPhase.cpp: Added.

(DFG):
(DCEPhase):
(JSC::DFG::DCEPhase::DCEPhase):
(JSC::DFG::DCEPhase::run):
(JSC::DFG::DCEPhase::findTypeCheckRoot):
(JSC::DFG::DCEPhase::countEdge):
(JSC::DFG::DCEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::performDCE):

  • dfg/DFGDCEPhase.h: Added.

(DFG):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::truncateConstantToInt32):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):
(DFG):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::changeChild):
(JSC::DFG::Graph::changeEdge):
(JSC::DFG::Graph::compareAndSwap):
(JSC::DFG::Graph::clearAndDerefChild):
(JSC::DFG::Graph::performSubstitution):
(JSC::DFG::Graph::performSubstitutionForEdge):
(Graph):
(JSC::DFG::Graph::substitute):

  • dfg/DFGInsertionSet.h:

(InsertionSet):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::convertToConstant):
(JSC::DFG::Node::convertToGetLocalUnlinked):
(JSC::DFG::Node::containsMovHint):
(Node):
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::willHaveCodeGenOrOSR):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileMovHintAndCheck):
(DFG):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):
(JSC::DFG::StructureCheckHoistingPhase::shouldConsiderForHoisting):
(StructureCheckHoistingPhase):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/dfg-arguments-osr-exit-multiple-blocks-before-exit-expected.txt: Added.
  • fast/js/dfg-arguments-osr-exit-multiple-blocks-before-exit.html: Added.
  • fast/js/dfg-arguments-osr-exit-multiple-blocks-expected.txt: Added.
  • fast/js/dfg-arguments-osr-exit-multiple-blocks.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js: Added.

(baz):
(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js: Added.

(baz):
(foo):
(bar):

6:15 PM Changeset in webkit [144861] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations: inspector/console/command-line-api-inspect.html
6:13 PM Changeset in webkit [144860] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit2

Each web process truncates the disk cache to zero on launch
​https://bugs.webkit.org/show_bug.cgi?id=111467

Reviewed by Darin Adler.

Let's not do that.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

6:11 PM Changeset in webkit [144859] by acolwell@chromium.org
  • 6 edits
    3 adds in trunk

Heap-use-after-free in WebCore::HTMLMediaElement::~HTMLMediaElement
​https://bugs.webkit.org/show_bug.cgi?id=110623

Reviewed by Eric Seidel.

Source/WebCore:

Test: http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html

  • html/HTMLAudioElement.h:

(HTMLAudioElement):

  • html/HTMLAudioElement.idl:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::hasPendingActivity):

  • html/HTMLMediaElement.idl:

LayoutTests:

  • http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal-expected.txt: Added.
  • http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html: Added.
  • http/tests/misc/resources/delete-frame-during-readystatechange-frame-with-gc-after-video-removal.html: Added.
5:47 PM Changeset in webkit [144858] by Chris Fleizach
  • 6 edits
    2 adds in trunk

AX: Support aria-posinset/setsize
​https://bugs.webkit.org/show_bug.cgi?id=109725

Reviewed by Tim Horton.

Source/WebCore:

Expose aria-setsize and aria-posinset through accessibility.
Right now only the Mac platform exposes them.

Test: platform/mac/accessibility/aria-setsize-posinset.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsARIASetSize):
(WebCore):
(WebCore::AccessibilityObject::supportsARIAPosInset):
(WebCore::AccessibilityObject::ariaSetSize):
(WebCore::AccessibilityObject::ariaPosInset):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/HTMLAttributeNames.in:

LayoutTests:

  • platform/mac/accessibility/aria-setsize-posinset-expected.txt: Added.
  • platform/mac/accessibility/aria-setsize-posinset.html: Added.
5:41 PM Changeset in webkit [144857] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

Remove deprecated process suppression assertion SPI from WebKitSystemInterface
​https://bugs.webkit.org/show_bug.cgi?id=111501

Patch by Kiran Muppala <​cmuppala@apple.com> on 2013-03-05
Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=111387 replaced all usage of
WKNSProcessInfoProcessAssertionWithTypes() with
-[NSProcessInfo beginSuspensionOfSystemBehaviors:]. Hence, remove
the now deprecated SPI.

  • WebKitSystemInterface.h: Remove

WKNSProcessInfoProcessAssertionWithTypes and associated declarations.

5:41 PM ScalesAndZooms edited by luxtella@company100.net
(diff)
5:29 PM Changeset in webkit [144856] by aelias@chromium.org
  • 10 edits
    1 add in trunk/Source

[chromium] Scroll deltas should be floats
​https://bugs.webkit.org/show_bug.cgi?id=111465

Reviewed by James Robinson.

This converts the remaining scroll delta fields to floats so that
we no longer lose precision due to DIP conversion. The natural
type for deltas is WebFloatSize, which was missing, so I also created
that type based on the existing WebSize header.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebFloatSize.h: Added.

(WebKit):
(WebFloatSize):
(WebKit::WebFloatSize::isEmpty):
(WebKit::WebFloatSize::WebFloatSize):
(WebKit::WebFloatSize::operator=):
(WebKit::WebFloatSize::operator WebCore::FloatSize):
(WebKit::WebFloatSize::operator gfx::SizeF):
(WebKit::WebFloatSize::operator gfx::Vector2dF):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebGestureCurveTarget.h:

(WebKit::WebGestureCurveTarget::scrollBy):
(WebGestureCurveTarget):

  • chromium/public/WebInputHandlerClient.h:

(WebKit::WebInputHandlerClient::scrollByIfPossible):
(WebInputHandlerClient):

Source/WebKit/chromium:

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::touchpadFlingScroll):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scrollBy):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/WebCompositorInputHandlerImplTest.cpp:

(MockWebInputHandlerClient):
(WebKit::TEST_F):

5:19 PM Changeset in webkit [144855] by eae@chromium.org
  • 2 edits
    9 adds
    5 deletes in trunk/LayoutTests

Unreviewed apple rebaselines for r144837.

  • fast/invalid/017-expected.txt: Added.
  • fast/invalid/018-expected.txt: Added.
  • platform/chromium-mac/fast/invalid/017-expected.txt: Removed.
  • platform/chromium-mac/fast/invalid/018-expected.txt: Removed.
  • platform/mac-lion/tables/mozilla/bugs: Added.
  • platform/mac-lion/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
  • platform/mac-lion/tables/mozilla/bugs/bug9024-expected.txt: Added.
  • platform/mac-lion/tables/mozilla_expected_failures: Removed.
  • platform/mac-wk2/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
  • platform/mac-wk2/tables/mozilla/bugs/bug9024-expected.txt: Added.
  • platform/mac/fast/invalid/017-expected.txt: Removed.
  • platform/mac/fast/invalid/018-expected.txt: Removed.
  • platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug9024-expected.txt: Added.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
5:17 PM Changeset in webkit [144854] by eae@chromium.org
  • 1 edit
    13 adds
    3 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines for r144837.

  • platform/chromium-linux/fast/invalid/017-expected.txt: Added.
  • platform/chromium-linux/fast/invalid/018-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug9024-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug9024-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug9024-expected.txt: Added.
  • platform/chromium-mac/fast/invalid/017-expected.txt: Added.
  • platform/chromium-mac/fast/invalid/018-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug9024-expected.txt: Added.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
  • platform/chromium/fast/invalid/017-expected.txt: Removed.
  • platform/chromium/fast/invalid/018-expected.txt: Removed.
  • platform/chromium/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
  • platform/chromium/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Replaced.
5:12 PM Changeset in webkit [144853] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Source/WebCore: [WinCairo] Support for cookies is incomplete
​https://bugs.webkit.org/show_bug.cgi?id=110147

Expired and HttpOnly cookies no longer accessible from JavaScript.
Cookies set in JavaScript now have correct domain/path.

Patch by Peter Nelson <​peter@peterdn.com> on 2013-03-05
Reviewed by Brent Fulgham.

Test: http/tests/cookies/http-get-cookie-set-in-js.html

  • platform/network/curl/CookieJarCurl.cpp:

(WebCore):
(WebCore::addMatchingCurlCookie):
(WebCore::getNetscapeCookieFormat):
(WebCore::setCookiesFromDOM):
(WebCore::cookieRequestHeaderFieldValue):

LayoutTests: [WinCairo] Support for cookies is incomplete
​https://bugs.webkit.org/show_bug.cgi?id=110147

Patch by Peter Nelson <​peter@peterdn.com> on 2013-03-05
Reviewed by Brent Fulgham.

Re-enabled cookie tests for WinCairo.
Added test to check whether cookie set in HTTP response is accessible in JS.

  • http/tests/cookies/http-get-cookie-set-in-js-expected.txt: Added.
  • http/tests/cookies/http-get-cookie-set-in-js.html: Added.
  • http/tests/cookies/resources/cookies-test-pre.js:

(clearAllCookies): Cookies set in JS now correctly cleared.

  • platform/wincairo/TestExpectations:
5:10 PM Changeset in webkit [144852] by roger_fong@apple.com
  • 4 edits in trunk/LayoutTests

Unreviewed. AppleWin gardening.

  • platform/win/TestExpectations:
  • platform/win/css3/filters/effect-reference-expected.txt:
  • platform/win/css3/filters/effect-reference-hw-expected.txt:
5:08 PM Changeset in webkit [144851] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Reset the values if there is a quota error
​https://bugs.webkit.org/show_bug.cgi?id=111500

Reviewed by Beth Dakin.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::didSetItem):
(WebKit::StorageAreaProxy::resetValues):
(WebKit):

  • WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

4:59 PM Changeset in webkit [144850] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Keep track of pending value changes in StorageAreaProxy
​https://bugs.webkit.org/show_bug.cgi?id=111496

Reviewed by Beth Dakin.

Add a HashCountedSet to keep track of the number of pending value
changes for a given key. If we get incoming storage events from other
processes while we have pending value changes, ignore the events.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::setItem):
(WebKit::StorageAreaProxy::didSetItem):
(WebKit::StorageAreaProxy::dispatchStorageEvent):
(WebKit::StorageAreaProxy::shouldApplyChangesForKey):
(WebKit):

  • WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

4:36 PM Changeset in webkit [144849] by alecflett@chromium.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix mac clang build with long long
​https://bugs.webkit.org/show_bug.cgi?id=111495

Unreviewed fix for mac build.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::IDBBackingStore):

4:35 PM Changeset in webkit [144848] by alecflett@chromium.org
  • 2 edits in trunk/Source

Fix mac clang build with long long
​https://bugs.webkit.org/show_bug.cgi?id=111495

Unreviewed fix for mac build.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::IDBBackingStore):

4:26 PM Changeset in webkit [144847] by scherkus@chromium.org
  • 13 edits in trunk/LayoutTests

Unreviewed rebaseline of media/track/track-cue-rendering-*.html
​https://bugs.webkit.org/show_bug.cgi?id=111388

  • platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium/TestExpectations:
4:19 PM Changeset in webkit [144846] by acolwell@chromium.org
  • 3 edits in trunk/Source/WebCore

Add V8Document.h include when the V8 code generator creates a toV8(Document*) call.
​https://bugs.webkit.org/show_bug.cgi?id=111486

Reviewed by Adam Barth.

No new tests. This doesn't change user visible behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructor):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
4:18 PM Changeset in webkit [144845] by jparent@chromium.org
  • 9 edits
    1 add in trunk/Tools

Dashboard cleanup: move string utilities into their own namespace.

​https://bugs.webkit.org/show_bug.cgi?id=111485

Reviewed by Ojan Vafai.

One of many pieces to clean up dashboard_base.

Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.

  • TestResultServer/static-dashboards/aggregate_results.html:
  • TestResultServer/static-dashboards/dashboard_base.js:

(isTreeMap):
(isFlakinessDashboard):

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(determineWKPlatform):
(chromiumPlatform):
(platformAndBuildType):
(substringList):
(individualTestsForSubstringList):
(filterBugs):
(populateExpectationsData):
(processMissingTestsWithExpectations):
(processMissingAndExtraExpectations):
(htmlForSingleTestRow):
(.dummyNode.onload):
(expectationsTitle):

  • TestResultServer/static-dashboards/run-embedded-unittests.html:
  • TestResultServer/static-dashboards/run-unittests.html:
  • TestResultServer/static-dashboards/string.js: Added.
  • TestResultServer/static-dashboards/timeline_explorer.html:
  • TestResultServer/static-dashboards/treemap.html:
4:17 PM Changeset in webkit [144844] by Lucas Forschler
  • 4 edits in branches/safari-536.29-branch/Source

Versioning.

4:16 PM Changeset in webkit [144843] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Objective-C API: JSValue should implement init and return nil in exceptional cases
​https://bugs.webkit.org/show_bug.cgi?id=111487

Reviewed by Darin Adler.

  • API/JSValue.mm:

(-[JSValue init]): We return nil here because there is no way to get the instance into a coherent state
without a JSContext.
(-[JSValue initWithValue:inContext:]): Similarly, we should also return nil here if either of the arguments is 0.

4:15 PM Changeset in webkit [144842] by ryuan.choi@samsung.com
  • 14 edits in trunk

[EFL] Build break with latest EFL libraries
​https://bugs.webkit.org/show_bug.cgi?id=111028

Reviewed by Dirk Pranke.

.:

In latest EFL trunk, include path of ecore sub modules are changed from
ecore-1 to ecore-XXX-1.
So, this patch adds missing ECORE_XXX_INCLUDE_DIRS.

  • Source/cmake/FindEcore.cmake: Added additional path suffixes to find include directories of ecore-XXX
  • Source/cmake/FindElementary.cmake: Checked Ecore_Con dependency which Elementary requires.
  • Source/cmake/OptionsEfl.cmake: Made Imf and Imf_Evas mandatory.

Source/WebKit:

  • PlatformEfl.cmake: Added ECORE_X_INCLUDE_DIRS.

Source/WebKit2:

  • PlatformEfl.cmake: Added ECORE_XXX_INCLUDE_DIRS.

Source/WTF:

  • wtf/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS.

Tools:

  • MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
  • TestWebKitAPI/PlatformEfl.cmake: Ditto.
  • WebKitTestRunner/PlatformEfl.cmake: Ditto.
4:11 PM Changeset in webkit [144841] by shawnsingh@chromium.org
  • 3 edits
    1 add in trunk

Fix default background of a dragged image.
​https://bugs.webkit.org/show_bug.cgi?id=110512

Reviewed by Tony Chang.

.:

  • ManualTests/drag-background-with-padding.html: Added.

Source/WebCore:

Transparent background color (particularly visible in the padding
of an element) was not being respected. The solution is to
initially fill the drag image with transparent instead of white,
so that any color background works correctly. This patch does not
affect Apple Mac or Win platforms, given that this part of the
code is #if guarded from those platforms.

Manual test added:

ManualTests/drag-background-with-padding.html

Infrastructure for retrieving the drag image for pixel testing
does not yet exist.

  • page/Frame.cpp:

(WebCore::Frame::nodeImage):

4:10 PM Changeset in webkit [144840] by roger_fong@apple.com
  • 3 edits in trunk/Tools

Increase number of WinEWS iterations to 20.
Don't reboot after each iteration set.
Make EWS bots just build temporarily so that the queue catches up again.

  • EWSTools/start-queue-win.sh:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

4:05 PM Changeset in webkit [144839] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations: /inspector/debugger/debugger-script-preprocessor.html
4:01 PM Changeset in webkit [144838] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use a named parameter for whether a quota error ocurred or not
​https://bugs.webkit.org/show_bug.cgi?id=111490

Reviewed by Beth Dakin.

This is clearer than setItem returning true on error.
Also, actually set the item in the storage map.

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::setItem):
(WebKit::StorageManager::setItem):

3:59 PM Changeset in webkit [144837] by eae@chromium.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: i < size(), UNKNOWN in WebCore::RenderTableSection::layout
​https://bugs.webkit.org/show_bug.cgi?id=108838

Source/WebCore:

Reviewed by Levi Weintraub.

Ensure that RenderTable::recalcSections is called when moving a
TableSection by calling setNeedsSectionRecalc in addChild for
TableSections.

Test: fullscreen/full-screen-table-section.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

LayoutTests:

Reviewed by Levi Weintraub.

Add test for calling requestFullscreen on an element with a
table-section display type.

  • fullscreen/full-screen-table-section-expected.txt: Added.
  • fullscreen/full-screen-table-section.html: Added.
3:58 PM Changeset in webkit [144836] by Lucas Forschler
  • 1 copy in tags/Safari-536.29.3

New Tag.

3:57 PM Changeset in webkit [144835] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip tests on Windows to make EWS bots happier.

  • platform/win/TestExpectations:
3:50 PM Changeset in webkit [144834] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations: fullscreen/full-screen-iframe-allowed-prexied.
3:50 PM Changeset in webkit [144833] by kbr@google.com
  • 18 edits in trunk/Source

Upgrade ANGLE to r1987
​https://bugs.webkit.org/show_bug.cgi?id=111381

Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

  • include/GLSLANG/ShaderLang.h:
  • src/common/version.h:
  • src/compiler/Compiler.cpp:

(TCompiler::TCompiler):
(TCompiler::Init):
(TCompiler::compile):

  • src/compiler/ParseHelper.h:

(TParseContext):

  • src/compiler/ShHandle.h:

(TCompiler):

  • src/compiler/ShaderLang.cpp:

(ShInitBuiltInResources):

  • src/compiler/UnfoldShortCircuit.cpp:

(sh::UnfoldShortCircuit::visitSelection):

  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp:

(glslang_scan):

  • src/compiler/glslang_tab.cpp:

Updated ANGLE to r1987.

Source/WebCore:

Covered by existing tests. Ran WebGL conformance tests in Safari
to ensure correct operation of patch.

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::initializeANGLE):

Changed all ports to query for highp support in fragment
shaders and conditionally enable it in ANGLE shader translator.

3:46 PM Changeset in webkit [144832] by commit-queue@webkit.org
  • 5 edits in trunk

Use new assertion API for process suppression on Mac
​https://bugs.webkit.org/show_bug.cgi?id=111387

Patch by Kiran Muppala <​cmuppala@apple.com> on 2013-03-05
Reviewed by Alexey Proskuryakov.

Source/WebKit2:

  • Shared/ChildProcess.h:

(WebKit::ChildProcess::processSuppressionEnabled): Rename
m_processVisibleAssertion to m_processSuppressionAssertion.

  • Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::setProcessSuppressionEnabled): Ditto. And,
replace calls to WKNSProcessInfoProcessAssertionWithTypes() with call to
-[NSProcessInfo beginSuspensionOfSystemBehaviors:].

WebKitLibraries:

Add WKProcessSuppressionSystemBehaviors constant for use in WebKit2 to
take a process suppression assertion.

  • WebKitSystemInterface.h:
3:45 PM Changeset in webkit [144831] by Lucas Forschler
  • 10 edits
    2 adds in branches/safari-536.29-branch/Source/WebKit2

<rdar://problem/13345073>

3:43 PM WikiStart edited by rniwa@webkit.org
Added a link to wiki:"May 2013 Meeting" (diff)
3:42 PM May 2013 Meeting created by rniwa@webkit.org
Add 2013 contributor's meeting page
3:33 PM Changeset in webkit [144830] by alecflett@chromium.org
  • 4 edits
    1 add in trunk/Source

IndexedDB: Add IDBBackingStoreTest
​https://bugs.webkit.org/show_bug.cgi?id=111233

Reviewed by Adam Barth.

Source/WebCore:

These are tweaks to make IDBBackingStore more easily testable.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::IDBBackingStore): Allow use without a backing store.

Source/WebKit/chromium:

Add some really simple IDBBackingStore tests
as a seed for additional tests later.

  • WebKit.gypi:
  • tests/IDBBackingStoreTest.cpp: Added.
3:31 PM Changeset in webkit [144829] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Move storageType() to StorageAreaProxy
​https://bugs.webkit.org/show_bug.cgi?id=111488

Reviewed by Andreas Kling.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::StorageAreaProxy):
(WebKit::StorageAreaProxy::storageType):
(WebKit::StorageAreaProxy::disabledByPrivateBrowsingInFrame):

  • WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

  • WebProcess/Storage/StorageNamespaceProxy.cpp:
  • WebProcess/Storage/StorageNamespaceProxy.h:
3:31 PM Changeset in webkit [144828] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove old Mac test expectations for the bug 106412.

  • platform/mac/TestExpectations:
3:15 PM Changeset in webkit [144827] by jamesr@google.com
  • 14 edits in trunk

[chromium] Move check for threaded compositing from WebCompositorSupport to Platform
​https://bugs.webkit.org/show_bug.cgi?id=111386

Reviewed by Adrienne Walker.

Source/Platform:

This moves the query for if threaded compositing is enabled from WebCompositorSupport
to Platform. This is part of an effort to remove statefulness on WebCompositorSupport
and because it's much easier to override Platform functions for different tests.

  • chromium/public/Platform.h:

(WebKit::Platform::isThreadedCompositingEnabled):
(Platform):

  • chromium/public/WebCompositorSupport.h:

Source/WebCore:

This moves checks for whether threaded compositing is enabled from WebCompositorSupport
to Platform. In the case of Canvas2DLayerBridge, the check is moved completely out of
the class to make it easier for tests to specify the threaded configuration to use in the test.

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):

  • platform/graphics/chromium/Canvas2DLayerBridge.h:

(WebCore::Canvas2DLayerBridge::create):
(Canvas2DLayerBridge):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::scheduleComposite):

  • tests/Canvas2DLayerBridgeTest.cpp:

(Canvas2DLayerBridgeTest::fullLifecycleTest):

  • tests/Canvas2DLayerManagerTest.cpp:

(FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

3:13 PM WebKit Team edited by pdr@google.com
Move ​pdr@google.com to the reviewers list (diff)
3:04 PM Changeset in webkit [144826] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Split up the storage event dispatch functions further
​https://bugs.webkit.org/show_bug.cgi?id=111482

Reviewed by Beth Dakin.

Add new functions for dispatching storage events to a set of frames.

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::dispatchStorageEvent):

  • storage/StorageEventDispatcher.cpp:

(WebCore::StorageEventDispatcher::dispatchSessionStorageEvents):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvents):
(WebCore):
(WebCore::StorageEventDispatcher::dispatchSessionStorageEventsToFrames):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEventsToFrames):

  • storage/StorageEventDispatcher.h:

(WebCore):
(StorageEventDispatcher):

2:53 PM Changeset in webkit [144825] by schenney@chromium.org
  • 4 edits
    2 adds in trunk

Crash when ImageLoader deletes Element inside SVGImageElement
​https://bugs.webkit.org/show_bug.cgi?id=111085

Reviewed by Abhishek Arya.

Source/WebCore:

Elements with ImageLoader objects associated with them may have their
final reference held by the ImageLoader (to allow events to be sent
and handled). Any call on Element that causes the ImageLoader to
dispatch events might then result in the final deref of the Element
itself, thus leaving all the Element's "this" pointers up the stack
pointing to invalid memory.

This change puts the deref of the Element on a timer so that, if the
deref is called via a method on Element, the call stack will unwind
before the deref occurs.

Test: svg/custom/image-with-attr-change-after-delete-crash.html

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::ImageLoader): Initialize a timer
(WebCore::ImageLoader::updatedHasPendingEvent): Put deref of the

element on a oneShotTimer, with appropriate assertions and checks to
ensure we only ref/deref once.

(WebCore::ImageLoader::timerFired): Deref the element when the timer fires.

  • loader/ImageLoader.h:

(ImageLoader): Define a timer for controlling deref of the element.

LayoutTests:

  • svg/custom/image-with-attr-change-after-delete-crash-expected.txt: Added.
  • svg/custom/image-with-attr-change-after-delete-crash.html: Added.
2:48 PM Changeset in webkit [144824] by Antoine Quint
  • 5 edits
    2 adds in trunk

Web Inspector: identify reflection layers in LayerTreeAgent
​https://bugs.webkit.org/show_bug.cgi?id=111419

Source/WebCore:

We add a new property "isReflection" to the Layer objects returned
to the front-end to indicate whether the layer was created to host
the reflection for an element. When this new property is true, the
"nodeId" property is set to point to the reflected element's node
id, since there is no node per-se directly associated with this layer.
We also change the "bounds" property to return absolute page coordinates
such that the front-end can use this information to highlight that
region in the page since metrics would otherwise be unavailable.

Reviewed by Dean Jackson.

Test: inspector-protocol/layers/layers-reflected-content.html

  • inspector/Inspector.json:
  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):

LayoutTests:

New test for reflection layers and an updated output for the
existing layersForNode() test since we changed the coordinates
for the "bounds" property to be absolute instead of local.

Reviewed by Dean Jackson.

  • inspector-protocol/layers/layers-for-node-expected.txt:
  • inspector-protocol/layers/layers-reflected-content-expected.txt: Added.
  • inspector-protocol/layers/layers-reflected-content.html: Added.
2:47 PM Changeset in webkit [144823] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WinCairo] Compile fix after r144024.
​https://bugs.webkit.org/show_bug.cgi?id=111306

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-03-05
Reviewed by James Robinson.

  • page/scrolling/ScrollingCoordinator.cpp: Added guard for USE(ACCELERATED_COMPOSITING).
  • page/scrolling/ScrollingCoordinator.h: Added guard for USE(ACCELERATED_COMPOSITING).
2:46 PM Changeset in webkit [144822] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Copy dictionary to the external storage before running layout test on android
​https://bugs.webkit.org/show_bug.cgi?id=111480

Patch by Min Qin <​qinmin@chromium.org> on 2013-03-05
Reviewed by Adam Barth.

TestWebKitPlatformSupport now needs to read an external dictionary file.
This file does not exist on the device. We need to copy it before running layout tests.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
(ChromiumAndroidDriver._push_platform_resources):

2:44 PM Changeset in webkit [144821] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
​https://bugs.webkit.org/show_bug.cgi?id=85642

Source/WebCore:

Add missing key mappings for GDK_KP_Begin, GDK_KP_Insert, GDK_KP_Delete and GDK_ISO_Level3_Shift.

Patch by James Weatherall <​wez@chromium.org> on 2013-03-05
Reviewed by Ojan Vafai.

  • platform/chromium/KeyCodeConversionGtk.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

Source/WebKit/chromium:

Add tests to verify that the fixed keys generate the same keyCode values as their equivalents.

Patch by James Weatherall <​wez@chromium.org> on 2013-03-05
Reviewed by Ojan Vafai.

  • WebKit.gypi:
  • tests/KeyCodeConversionTestGtk.cpp: Added.

(WebCore):
(WebCore::TEST):

2:35 PM Changeset in webkit [144820] by alecflett@chromium.org
  • 37 edits
    1 copy in trunk/Source

IndexedDB: Properly refactor frontend/backend code by #includes
​https://bugs.webkit.org/show_bug.cgi?id=110653

Reviewed by Dimitri Glazkov.

Source/WebCore:

IndexedDB has a distinct backend and frontend, with well defined
*Interface / *Callbacks classes distinguishing them, respectively.

This makes sure that the frontend and backend do not include each
other and fixes build problems that occurred as a result.

Specifically this moves enums out of IDBCursor and IDBTransaction
into IndexedDB.h in a new WebCore::IndexedDB namespace.

No new tests, as this is just a refactor.

Source/WebKit/chromium:

Clean up the frontend/backend WebIDB* implementations to
match the changes to webkit.

2:30 PM Changeset in webkit [144819] by jpfau@apple.com
  • 8 edits in trunk

Clear associated cache partitions when deleting origins' cache
​https://bugs.webkit.org/show_bug.cgi?id=111383

Reviewed by Maciej Stachowiak.

Source/WebCore:

Clear the cache partitions associated with the origin being cleared.

Not possible to test with current automated test tools, must be tested manually.

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeResourcesWithOrigin):

Source/WebKit2:

Clear the cache partitions associated with the origin being cleared.

  • WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:

(WebKit):
(WebKit::partitionName):
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames):

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
2:25 PM Changeset in webkit [144818] by alokp@chromium.org
  • 11 edits
    3 copies
    2 moves
    1 add in trunk/LayoutTests

Rebaseline text output for opaque GraphicsLayers
​https://bugs.webkit.org/show_bug.cgi?id=109507

Unreviewed rebaseline.

  • compositing/contents-opaque/contents-opaque-background-color-expected.txt:
  • compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt:
  • compositing/contents-opaque/contents-opaque-layer-transform-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/contents-opaque/contents-opaque-background-color-expected.txt: Copied from LayoutTests/compositing/contents-opaque/contents-opaque-background-color-expected.txt.
  • platform/chromium/compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt: Copied from LayoutTests/compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt.
  • platform/chromium/compositing/contents-opaque/contents-opaque-layer-transform-expected.txt: Copied from LayoutTests/compositing/contents-opaque/contents-opaque-layer-transform-expected.txt.
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Renamed from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Renamed from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
  • platform/efl/TestExpectations:
  • platform/efl/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
  • platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
2:18 PM Changeset in webkit [144817] by rniwa@webkit.org
  • 4 edits
    3 adds
    35 deletes in trunk/LayoutTests

editing/pasteboard/paste-text-005.html, paste-text-006.html, and paste-text-007.html should be dump-as-markup tests
​https://bugs.webkit.org/show_bug.cgi?id=111466

Reviewed by Levi Weintraub.

  • editing/pasteboard/paste-text-005-expected.txt: Added.
  • editing/pasteboard/paste-text-005.html:
  • editing/pasteboard/paste-text-006-expected.txt: Added.
  • editing/pasteboard/paste-text-006.html:
  • editing/pasteboard/paste-text-007-expected.txt: Added.
  • editing/pasteboard/paste-text-007.html:
  • platform/chromium-linux/editing/pasteboard/paste-text-005-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-006-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-text-007-expected.png: Removed.
  • platform/chromium-mac-lion/editing/pasteboard/paste-text-005-expected.png: Removed.
  • platform/chromium-mac-lion/editing/pasteboard/paste-text-006-expected.png: Removed.
  • platform/chromium-mac-lion/editing/pasteboard/paste-text-007-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-005-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-text-005-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-text-006-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-text-007-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-005-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-005-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-006-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-006-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-007-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-007-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/paste-text-005-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/paste-text-006-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/paste-text-007-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-005-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-text-007-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-005-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-005-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-006-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-006-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-text-007-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-text-007-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-005-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-005-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-006-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-006-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-text-007-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-text-007-expected.txt: Removed.
  • platform/win/editing/pasteboard/paste-text-005-expected.txt: Removed.
2:04 PM Changeset in webkit [144816] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

Inline min/maxInstrinsicLogicalWidth functions
​https://bugs.webkit.org/show_bug.cgi?id=111399

Reviewed by Tony Chang.

Turns out these functions don't need to be public and only
have one caller. This patch is in preparation for supporting
intrinsic widths on tables, which will need to pass in the
border and padding width as an argument.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::fillAvailableMeasure):
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):

  • rendering/RenderBox.h:
2:04 PM Changeset in webkit [144815] by rniwa@webkit.org
  • 2 edits
    1 add
    13 deletes in trunk/LayoutTests

editing/pasteboard/paste-table-003.html should be a dump-as-text test
​https://bugs.webkit.org/show_bug.cgi?id=111400

Reviewed by Levi Weintraub.

Convert the test to a dump-as-text test. The output is much easier to understand now.
Also moved the test description out of the root element so that it won't be repeated
multiple times in the output.

  • editing/pasteboard/paste-table-003-expected.txt: Added.
  • editing/pasteboard/paste-table-003.html:
  • platform/chromium-linux/editing/pasteboard/paste-table-003-expected.png: Removed.
  • platform/chromium-mac-lion/editing/pasteboard/paste-table-003-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-003-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-table-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-table-003-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-table-003-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/paste-table-003-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-table-003-expected.png: Removed.
  • platform/gtk/editing/pasteboard/paste-table-003-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-table-003-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-table-003-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-table-003-expected.png: Removed.
  • platform/qt/editing/pasteboard/paste-table-003-expected.txt: Removed.
2:02 PM Changeset in webkit [144814] by vcarbune@chromium.org
  • 4 edits
    2 adds in trunk

Cue line-height property shouldn't be inherited from the video element
​https://bugs.webkit.org/show_bug.cgi?id=111262

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-cue-rendering-on-resize.html

  • css/mediaControls.css:

(video::-webkit-media-text-track-container): Set the default font size
and family using the "font" property to also reset the line-height property.

LayoutTests:

  • media/track/captions-webvtt/captions-snap-to-lines-set.vtt: Updated.
  • media/track/track-cue-rendering-on-resize-expected.txt: Added.
  • media/track/track-cue-rendering-on-resize.html: Added.
1:48 PM Changeset in webkit [144813] by jsbell@chromium.org
  • 6 edits
    1 delete in trunk/Source/WebCore

IndexedDB: Remove some unused binding code
​https://bugs.webkit.org/show_bug.cgi?id=111463

Reviewed by Adam Barth.

IDBRequest got a custom V8 getter for |request| to help diagnose an issue, but the
root cause was found/fixed (​http://wkbug.com/110916 and ​http://wkbug.com/110206) so
remove it. Also, IDBKey was marked ScriptWrappable but it is now explicitly converted
to a ScriptValue before it gets anywhere near the binding code, so remove that too.
Finally, createIDBKeyFromValue doesn't need to be exposed from IDBBindingUtilities.

No new tests - just removing dead code.

  • Modules/indexeddb/IDBKey.h: No need for ScriptWrappable.
  • Modules/indexeddb/IDBRequest.idl: Remove custom binding (root cause of bug found).
  • WebCore.gypi: Ditto.
  • bindings/js/IDBBindingUtilities.h: Don't expose internal createIDBKeyFromValue().
  • bindings/v8/IDBBindingUtilities.h: Ditto.
  • bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
1:47 PM Changeset in webkit [144812] by beidson@apple.com
  • 27 edits
    2 adds in branches/safari-534.59-branch/Source/WebKit2

534.59 branch needs to handle API clients with a non-zero version number
<rdar://problem/13348902> and ​https://bugs.webkit.org/show_bug.cgi?id=111475

Reviewed by Anders Carlsson.

This patch:
1 - Adds the APIClient and APIClientTraits versioning mechanism from ToT to the branch.
2 - Updates most APIClients to have a current version of 0.
3 - Updates the WKPageLoaderClient and WKPageUIClient to have non-zero current versions.
4 - Allows non-zero versioned clients through the calls to WKPageSetPageLoaderClient and WKPageSetPageUIClient.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient): Allow non-zero clients through.
(WKPageSetPageUIClient): Ditto.

Add the client traits mechanism and implement traits for the two clients that have a non-zero current version:

  • Shared/APIClientTraits.cpp: Added.
  • Shared/APIClientTraits.h: Added.

Allow for setting versioned clients using those client traits:

  • Shared/APIClient.h:

(WebKit::APIClient::initialize):
(WebKit::APIClient::client):

Update the APIClient templatization for all APIClients to pass their current version:

  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebCookieManagerProxyClient.h:
  • UIProcess/WebDatabaseManagerProxyClient.h:
  • UIProcess/WebDownloadClient.h:
  • UIProcess/WebFindClient.h:
  • UIProcess/WebFormClient.h:
  • UIProcess/WebGeolocationProvider.h:
  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebIconDatabaseClient.h:
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageContextMenuClient.h:
  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebResourceLoadClient.h:
  • UIProcess/WebUIClient.h:
  • WebProcess/InjectedBundle/InjectedBundleClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebKit2.xcodeproj/project.pbxproj:
1:41 PM Changeset in webkit [144811] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

Fix cast-align warning in ASCIIFastPath.h on ARM
​https://bugs.webkit.org/show_bug.cgi?id=111436

Reviewed by Benjamin Poulain.

  • wtf/text/ASCIIFastPath.h:

(WTF::charactersAreAllASCII):

1:38 PM Changeset in webkit [144810] by dpranke@chromium.org
  • 37 edits
    1 delete in trunk/Source

Unreviewed, rolling out r144798.
​http://trac.webkit.org/changeset/144798
​https://bugs.webkit.org/show_bug.cgi?id=111478

"broke chromium windows build" (Requested by dpranke on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-05

Source/WebCore:

  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::Cursor::continueFunction):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStore::openObjectStoreCursor):
(WebCore::IDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBBackingStore::openIndexKeyCursor):
(WebCore::IDBBackingStore::openIndexCursor):

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::create):
(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::deleteFunction):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::perform):

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(WebCore::IDBCursorBackendImpl::create):
(WebCore::IDBCursorBackendImpl::value):
(IDBCursorBackendImpl):

  • Modules/indexeddb/IDBCursorBackendInterface.h:

(WebCore):

  • Modules/indexeddb/IDBCursorWithValue.cpp:

(WebCore::IDBCursorWithValue::create):
(WebCore::IDBCursorWithValue::IDBCursorWithValue):

  • Modules/indexeddb/IDBCursorWithValue.h:

(IDBCursorWithValue):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::GetOperation::create):
(WebCore::GetOperation::GetOperation):
(GetOperation):
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(OpenCursorOperation):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::createIndex):
(WebCore::IDBDatabaseBackendImpl::deleteIndex):
(WebCore::IDBDatabaseBackendImpl::get):
(WebCore::GetOperation::perform):
(WebCore::IDBDatabaseBackendImpl::put):
(WebCore::PutOperation::perform):
(WebCore::IDBDatabaseBackendImpl::setIndexKeys):
(WebCore::IDBDatabaseBackendImpl::openCursor):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteRange):
(WebCore::DeleteRangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::clear):
(WebCore::IDBDatabaseBackendImpl::transactionStarted):
(WebCore::IDBDatabaseBackendImpl::transactionFinished):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndCompleteFired):
(WebCore::IDBDatabaseBackendImpl::createTransaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:
  • Modules/indexeddb/IDBFactory.h:
  • Modules/indexeddb/IDBIndex.cpp:

(WebCore):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore):
(WebCore::IDBObjectStore::openCursor):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::setCursorDetails):
(WebCore::IDBRequest::setResultCursor):
(WebCore::IDBRequest::onSuccess):

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):

  • Modules/indexeddb/IDBTransaction.h:

(WebCore::IDBTransaction::isReadOnly):
(WebCore::IDBTransaction::isVersionChange):
(IDBTransaction):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::create):
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::mode):

  • Modules/indexeddb/IDBTransactionCoordinator.cpp:

(WebCore::IDBTransactionCoordinator::processStartedTransactions):
(WebCore::IDBTransactionCoordinator::canRunTransaction):

  • Modules/indexeddb/IndexedDB.h: Removed.
  • Target.pri:
  • WebCore.gypi:

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::openCursor):

  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/WebIDBCallbacksImpl.cpp:
  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::openCursor):

  • tests/IDBAbortOnCorruptTest.cpp:
  • tests/IDBDatabaseBackendTest.cpp:
  • tests/IDBFakeBackingStore.h:
1:37 PM Changeset in webkit [144809] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/efl/TestExpectations: Unskipping the fast/workers/shared-worker-load-error.html layout test

and adding a flaky timeout expectation for it. Looking for testing data from the EFL port on this test.

  • platform/gtk-wk1/TestExpectations: Removed an expectation for a test that was removed in r144624.
  • platform/gtk/TestExpectations: Adding failure expectations for tests introduced in r144714 and r144747.
1:15 PM Changeset in webkit [144808] by tommyw@google.com
  • 7 edits in trunk

MediaStream API: Allow local and remote descriptions to be accessed after close
​https://bugs.webkit.org/show_bug.cgi?id=111437

Reviewed by Adam Barth.

Source/WebCore:

It's quite clear in the standard that the getters should still return the old value.
Also overhauling the state setters a bit to check if the new state is different.

Existing tests expanded to cover patch.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::remoteDescription):
(WebCore::RTCPeerConnection::changeSignalingState):
(WebCore::RTCPeerConnection::changeIceGatheringState):
(WebCore::RTCPeerConnection::changeIceConnectionState):

LayoutTests:

Expanding tests to check the new behaviour.

  • fast/mediastream/RTCPeerConnection-localDescription-expected.txt:
  • fast/mediastream/RTCPeerConnection-localDescription.html:
  • fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt:
  • fast/mediastream/RTCPeerConnection-remoteDescription.html:
1:14 PM Changeset in webkit [144807] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

Multiple html5lib Layout Tests are slow since r144032
​https://bugs.webkit.org/show_bug.cgi?id=110876

Reviewed by Tony Chang.

Skip the html5lib tests when in debug mode. The -data variants
almost always timeout due to v8 boot-up time:
​https://code.google.com/p/v8/issues/detail?id=2567

These timeouts sometimes manifest as failures, and we've even
seen crashes (with empty stacks!?) of these tests on Win and Mac in Debug, so
skipping them until they run in a reasonable time and can
be debugged further.

  • platform/chromium/TestExpectations:
1:12 PM Changeset in webkit [144806] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations: expectations for transitions/transitions-parsing.html
1:11 PM Changeset in webkit [144805] by creis@chromium.org
  • 11 edits in trunk/Source

Add FrameLoaderClient::didAccessInitialDocument
​https://bugs.webkit.org/show_bug.cgi?id=107963

Source/WebCore:

Notifies the FrameLoaderClient if another page accesses the
initial empty document of a main frame. In this case, it is
no longer safe to display the provisional URL.

Only takes effect for PLATFORM(CHROMIUM), since no other platforms
listen to the notification.

Reviewed by Adam Barth.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::setSecurityToken):

Use default token for initial document.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

Notify loader if initial document is accessed.

(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::didAccessInitialDocument):
(WebCore):

  • loader/FrameLoader.h:

(FrameLoader):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):
(WebCore::FrameLoaderClient::didAccessInitialDocument):

Source/WebKit/chromium:

Notifies WebFrameClient if another page accesses the initial
empty document of a main frame. In this case, it is no longer
safe to display the provisional URL.

Reviewed by Adam Barth.

  • public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::didAccessInitialDocument):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didAccessInitialDocument):
(WebKit):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

  • tests/WebFrameTest.cpp:
1:08 PM Changeset in webkit [144804] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fix assertion in CookieManager::getBackingStoreCookies
​https://bugs.webkit.org/show_bug.cgi?id=111468

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2013-03-05
Reviewed by Rob Buis.
Internally reviewed by Konrad Piascik.

The assert in getBackingStoreCookies could be giving out false positives now
that we have our fixes for cookie loading in PR 286189. The cookie store could
be half loaded if the first cookie get/set call happens before the db is fully loaded.
A full webkit sync call to reload the database will cause the assert to be hit.

Safer to flush everything out and try again.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getBackingStoreCookies):

1:07 PM Changeset in webkit [144803] by Lucas Forschler
  • 4 edits in branches/safari-536.29-branch/Source

Versioning.

12:57 PM Changeset in webkit [144802] by dpranke@chromium.org
  • 2 edits in trunk/Tools

[chromium] DRT crashes in an Aura/Win build
​https://bugs.webkit.org/show_bug.cgi?id=111394

Reviewed by Tony Chang.

When building (and running) with use_aura=1, we assume that
we're using the default theme engine, but DRT creates the
DRTWin theme engine and overwrites the default, leading to crashes
in basically every test from the mismatch.

This fix gets us down to at least "lots of crashes" :).

  • DumpRenderTree/chromium/TestShellWin.cpp:

(platformInit):

12:44 PM Changeset in webkit [144801] by tonyg@chromium.org
  • 8 edits in trunk/Source/WebCore

CompactHTMLToken does not need an XSSInfo pointer
​https://bugs.webkit.org/show_bug.cgi?id=111423

Reviewed by Eric Seidel.

The CompactHTMLToken should remain as small as possible because it is copied. This shrinks the size by one pointer
by moving a relatively uncommon attribute out to its own Vector.

No new tests because no new functionality.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::checkThatXSSInfosAreSafeToSendToAnotherThread):
(WebCore):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):

  • html/parser/BackgroundHTMLParser.h:

(BackgroundHTMLParser):

  • html/parser/CompactHTMLToken.cpp:

(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):

  • html/parser/CompactHTMLToken.h:

(WebCore):
(CompactHTMLToken):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):

  • html/parser/HTMLDocumentParser.h:

(ParsedChunk):

  • html/parser/XSSAuditorDelegate.h:

(XSSInfo):
(WebCore):

12:31 PM Changeset in webkit [144800] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Split StorageEventDispatcher::dispatch into two functions
​https://bugs.webkit.org/show_bug.cgi?id=111464

Reviewed by Beth Dakin.

Split StorageEventDispatcher::dispatch into dispatchSessionStorageEvent and
dispatchLocalStorageEvent and make StorageAreaImpl::dispatchStorageEvent call
the right function based on the storage area type.

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::dispatchStorageEvent):

  • storage/StorageEventDispatcher.cpp:

(WebCore::StorageEventDispatcher::dispatchSessionStorageEvent):
(WebCore):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvent):

  • storage/StorageEventDispatcher.h:

(StorageEventDispatcher):

12:27 PM Changeset in webkit [144799] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build fix after r144024.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea): Handle
case of not using Accelerated Compositing
(WebCore::ScrollingCoordinator::horizontalScrollbarLayerForScrollableArea):
(WebCore::ScrollingCoordinator::verticalScrollbarLayerForScrollableArea): Ditto.

12:11 PM Changeset in webkit [144798] by alecflett@chromium.org
  • 37 edits
    1 copy in trunk/Source

IndexedDB: Properly refactor frontend/backend code by #includes
​https://bugs.webkit.org/show_bug.cgi?id=110653

Reviewed by Dimitri Glazkov.

Source/WebCore:

IndexedDB has a distinct backend and frontend, with well defined
*Interface / *Callbacks classes distinguishing them, respectively.

This makes sure that the frontend and backend do not include each
other and fixes build problems that occurred as a result.

Specifically this moves enums out of IDBCursor and IDBTransaction
into IndexedDB.h in a new WebCore::IndexedDB namespace.

No new tests, as this is just a refactor.

Source/WebKit/chromium:

Clean up the frontend/backend WebIDB* implementations to
match the changes to webkit.

12:09 PM Changeset in webkit [144797] by tdanderson@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening

Unreviewed gardening

  • platform/chromium/TestExpectations:
11:57 AM Changeset in webkit [144796] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r186200. Requested by
"James Robinson" <​jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-05

  • DEPS:
11:56 AM Changeset in webkit [144795] by commit-queue@webkit.org
  • 6 edits in trunk/Source

ContainerNode::setActive should not sleep for 100ms on platforms that do not implement synchronous repaint(true) semantics
​https://bugs.webkit.org/show_bug.cgi?id=87054

Patch by James Robinson <​jamesr@chromium.org> on 2013-03-05
Reviewed by Darin Adler.

Source/WebCore:

Adds a new ChromeClient function to query if the platform supports the immediate parameter
to the invalidation APIs and guards the synchronous repaint logic in ContainerNode::setActive()
with it.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::setActive):

  • page/ChromeClient.h:

(WebCore::ChromeClient::supportsImmediateInvalidation):

Source/WebKit/mac:

The Mac WebKit1 port supports immediate invalidations.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::supportsImmediateInvalidation):

11:49 AM Changeset in webkit [144794] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] WebPageProxy::setThemePath() should check that the page is valid
​https://bugs.webkit.org/show_bug.cgi?id=109917

Reviewed by Alexey Proskuryakov.

WebPageProxy::setThemePath() should check that the page is valid before
sending IPC message.

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::setThemePath):

11:49 AM Changeset in webkit [144793] by rniwa@webkit.org
  • 1 edit
    1 move
    1 add
    13 deletes in trunk/LayoutTests

editing/pasteboard/5247341.html should be a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=111397

Reviewed by Darin Adler.

Convert the test to use dump-as-markup.js. Also rename it to preserve-line-break-at-end-of-pasted-content
to reflect the content of the test.

  • editing/pasteboard/5247341.html: Removed.
  • editing/pasteboard/preserve-line-break-at-end-of-pasted-content-expected.txt: Added.
  • editing/pasteboard/preserve-line-break-at-end-of-pasted-content.html: Copied from LayoutTests/editing/pasteboard/5247341.html.
  • platform/chromium-linux/editing/pasteboard/5247341-expected.png: Removed.
  • platform/chromium-mac-lion/editing/pasteboard/5247341-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/5247341-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/5247341-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5247341-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/5247341-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/5247341-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5247341-expected.png: Removed.
  • platform/gtk/editing/pasteboard/5247341-expected.txt: Removed.
  • platform/mac/editing/pasteboard/5247341-expected.png: Removed.
  • platform/mac/editing/pasteboard/5247341-expected.txt: Removed.
  • platform/qt/editing/pasteboard/5247341-expected.png: Removed.
  • platform/qt/editing/pasteboard/5247341-expected.txt: Removed.
11:43 AM Changeset in webkit [144792] by Lucas Forschler
  • 1 copy in tags/Safari-536.29.2

New Tag.

11:43 AM Changeset in webkit [144791] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Simplify storage event dispatch somewhat
​https://bugs.webkit.org/show_bug.cgi?id=111461

Reviewed by Beth Dakin.

Add a StorageAreaImpl::dispatchStorageEvent to avoid replicating the calls to
StorageEventDispatcher::dispatch there times. This is in preparation for changing the
interface of StorageEventDispatcher so it can be used by WebKit2.

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::setItem):
(WebCore::StorageAreaImpl::removeItem):
(WebCore::StorageAreaImpl::clear):
(WebCore::StorageAreaImpl::dispatchStorageEvent):

  • storage/StorageAreaImpl.h:

Reindent.

11:41 AM Changeset in webkit [144790] by tony@chromium.org
  • 3 edits
    2 adds in trunk

Fix some crashes in render sliders
​https://bugs.webkit.org/show_bug.cgi?id=111458

Reviewed by Ojan Vafai.

Source/WebCore:

Fix some cases where we assumed the renderer is a renderBox.

Test: fast/forms/range/slider-inline-crash.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderContainer::layout): Use renderBox() which will return 0 if the renderer is not a RenderBox.
(WebCore::SliderThumbElement::setPositionFromPoint): Bail out early if renderBox() is 0.

LayoutTests:

  • fast/forms/range/slider-inline-crash-expected.txt: Added.
  • fast/forms/range/slider-inline-crash.html: Added.
11:37 AM Changeset in webkit [144789] by scherkus@chromium.org
  • 5 edits in trunk

REGRESSION(r142191): Fix closed caption buttons for ports still using the painting path.
​https://bugs.webkit.org/show_bug.cgi?id=111109

Reviewed by Eric Carlson.

Source/WebCore:

Covered by following tests:
media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton):

LayoutTests:

  • platform/chromium/TestExpectations:
11:17 AM Changeset in webkit [144788] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13269245> Crashes creating WebKit processes in WKSandboxExtensionConsume
​https://bugs.webkit.org/show_bug.cgi?id=111456

Reviewed by Anders Carlsson.

It's too late to be draconian about this condition here, crashing doesn't help
diagnose what went wrong when creating a sandbox extension.

Other SandboxExtension functions already have null checks for WKSandboxExtensionRef,
and so should consumePermanently().

  • Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::createHandle): For now, added logging when extension creation fails. If that proves insufficiently helpful in practice, we can change to a CRASH() later. (WebKit::SandboxExtension::createHandleForTemporaryFile): Ditto. (WebKit::SandboxExtension::consumePermanently): Gracefully fail if there is no extension to consume.
11:16 AM Changeset in webkit [144787] by commit-queue@webkit.org
  • 17 edits
    1 add
    1 delete in trunk/Source

Coordinated Graphics: CoordinatedGraphicsLayer makes CoordinatedGraphicsScene perform via CoordinatedGraphicsState.
​https://bugs.webkit.org/show_bug.cgi?id=108294

Patch by Gwang Yoon Hwang <​ryumiel@company100.net> on 2013-03-05
Reviewed by Anders Carlsson.

Source/WebCore:

CoordinatedLayerTreeHostProxy has too many IPC messages (e.g. SyncCanvas and
CreateTile), and there is a long function chain from CoordinatedGraphicsLayer to
CoordinatedGraphicsScene (4 classes).
If we want to add a new message, we need to add similar functions into 4 classes.

Now CoordinatedLayerTreeHost has only one IPC message for CoordinatedGraphicsLayer:
CommitCoordinatedGraphicsState.
CoordinatedGraphicsLayer makes CoordinatedGraphicsScene run as follows:

  1. CoordinatedGraphicsLayer makes a CoordinatedGraphicsLayerState.
  2. CoordinatedLayerTreeHost stores all LayerStates.
  3. CoordinatedLayerTreeHost sends GraphicsState includes LayerStates to CoordinatedLayerTreeHostProxy

at the moment of flushing via CommitCoordinatedGraphicsState message.

  1. CoordinatedGraphicsScene applies all state changes to layers.

There is one big behavior change. All states changes (e.g.
UpdateTiles, SetLayerChildren, and etc..) are performed at the same time, when
CoordinatedGraphicsScene::commitCoordinatedGraphicsState is called.

This patch is based on Dongsung Huang, and Noam's work in
​https://bugs.webkit.org/show_bug.cgi?id=108294

No new tests, covered by existing tests.

  • Target.pri:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setPosition):
(WebCore::CoordinatedGraphicsLayer::setAnchorPoint):
(WebCore::CoordinatedGraphicsLayer::setSize):
(WebCore::CoordinatedGraphicsLayer::setTransform):
(WebCore::CoordinatedGraphicsLayer::setChildrenTransform):
(WebCore::CoordinatedGraphicsLayer::setPreserves3D):
(WebCore::CoordinatedGraphicsLayer::setMasksToBounds):
(WebCore::CoordinatedGraphicsLayer::setDrawsContent):
(WebCore::CoordinatedGraphicsLayer::setContentsVisible):
(WebCore::CoordinatedGraphicsLayer::setContentsOpaque):
(WebCore::CoordinatedGraphicsLayer::setBackfaceVisibility):
(WebCore::CoordinatedGraphicsLayer::setOpacity):
(WebCore::CoordinatedGraphicsLayer::setContentsRect):
(WebCore::CoordinatedGraphicsLayer::setFilters):
(WebCore::CoordinatedGraphicsLayer::setContentsToSolidColor):
(WebCore::CoordinatedGraphicsLayer::setShowDebugBorder):
(WebCore::CoordinatedGraphicsLayer::setShowRepaintCounter):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::setReplicatedByLayer):
(WebCore::CoordinatedGraphicsLayer::setFixedToViewport):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::syncFilters):
(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::setDebugBorder):
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::syncCanvas):
(WebCore::CoordinatedGraphicsLayer::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsLayer::createCanvasIfNeeded):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::resetLayerState):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::releaseImageBackingIfNeeded):
(WebCore::CoordinatedGraphicsLayer::setRootLayer):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):
(WebCore::CoordinatedGraphicsLayer::removeTile):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::syncCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerRepaintCountIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerChildrenIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerFiltersIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::deleteLayer):
(WebCore::CoordinatedGraphicsScene::createTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::removeTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::updateTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):
(WebCore::CoordinatedGraphicsScene::commitSceneState):
(WebCore::CoordinatedGraphicsScene::setLayerAnimationsIfNeeded):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

(WebCore):
(CoordinatedGraphicsScene):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h: Added.

(WebCore):
(TileUpdateInfo):
(TileCreationInfo):
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
(CoordinatedGraphicsLayerState):
(CoordinatedGraphicsState):

  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
  • platform/graphics/texmap/coordinated/CoordinatedLayerInfo.h: Removed.
  • platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h:

Source/WebKit2:

There are two changes in WK2.

  1. Change CoordinatedLayerTreeHostProxy to use CoordinatedGraphicsState.
  2. Add encode/decode of CoordinatedGraphicsState in CoordinatedGraphicsArgumentCoders.

This patch is based on Dongsung Huang, and Noam's work in
​https://bugs.webkit.org/show_bug.cgi?id=108294

No new tests, covered by existing tests.

  • Scripts/webkit2/messages.py:

(headers_for_type):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):

Encoding UpdateImageBacking and CreateUpdateAtlas can fail when
encoding WebCoordinatedSurface::Handle fails, but we don't
recover in the case.

(CoreIPC::::decode):
(CoreIPC):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:

(WebCore):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::commitCoordinatedGraphicsState):
(WebKit):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:

(WebCore):
(CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::coordinatedGraphicsScene):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::initializeRootCompositingLayerIfNeeded):
(WebKit::CoordinatedLayerTreeHost::syncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesIfNeeded):
(WebKit):
(WebKit::CoordinatedLayerTreeHost::updateImageBacking):
(WebKit::CoordinatedLayerTreeHost::setBackgroundColor):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(CoordinatedLayerTreeHost):

11:13 AM Changeset in webkit [144786] by roger_fong@apple.com
  • 4 edits in trunk/Source/WebCore

Unreviewed. AppleWin VS2010 build fix.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • rendering/RenderingAllInOne.cpp:
11:07 AM Changeset in webkit [144785] by eric@webkit.org
  • 4 edits
    1 move in trunk

Add html-parser-threaded perf test now that the threaded parser is enabled by default
​https://bugs.webkit.org/show_bug.cgi?id=111200

Reviewed by Ryosuke Niwa.

PerformanceTests:

The old srcdoc test no longer triggers the threaded parser due to compatibility fixes.

  • Parser/html-parser-threaded.html: Renamed from PerformanceTests/Parser/html-parser-srcdoc.html.
  • Skipped: Unfortunately this new test is still skipped too.

Tools:

Had to teach run-perf-tests to ignore one more warning.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):

11:07 AM Changeset in webkit [144784] by commit-queue@webkit.org
  • 18 edits
    1 delete in trunk

[chromium] Clean up WebWidget / WebLayerTreeView interactions
​https://bugs.webkit.org/show_bug.cgi?id=109125

Patch by James Robinson <​jamesr@chromium.org> on 2013-03-05
Reviewed by Adrienne Walker.

Source/Platform:

This deprecates most of the calls on WebLayerTreeViewClient since these interactions are handled
entirely on the embedder side of the interface now.

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

  • chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::willBeginFrame):
(WebKit::WebLayerTreeViewClient::didBeginFrame):
(WebKit::WebLayerTreeViewClient::applyScrollAndScale):
(WebKit::WebLayerTreeViewClient::layout):
(WebKit::WebLayerTreeViewClient::didRecreateOutputSurface):
(WebKit::WebLayerTreeViewClient::createInputHandler):
(WebKit::WebLayerTreeViewClient::createOutputSurface):
(WebKit::WebLayerTreeViewClient::willCommit):
(WebKit::WebLayerTreeViewClient::didCommit):
(WebKit::WebLayerTreeViewClient::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewClient::didCompleteSwapBuffers):

Source/WebKit/chromium:

This removes most of the compositing control flow logic from WebViewImpl since
it is now handled in the embedding layer (by the implementation of WebViewClient/WebWidgetClient).

  • public/WebViewClient.h:
  • public/WebWidget.h:

(WebKit):
(WebKit::WebWidget::animate):
(WebWidget):
(WebKit::WebWidget::didExitCompositingMode):
(WebKit::WebWidget::createInputHandler):
(WebKit::WebWidget::applyScrollAndScale):
(WebKit::WebWidget::instrumentBeginFrame):
(WebKit::WebWidget::instrumentWillBeginFrame):
(WebKit::WebWidget::instrumentDidCancelFrame):
(WebKit::WebWidget::instrumentDidBeginFrame):
(WebKit::WebWidget::instrumentWillComposite):

  • src/WebHelperPluginImpl.cpp:
  • src/WebHelperPluginImpl.h:

(WebHelperPluginImpl):

  • src/WebPagePopupImpl.cpp:
  • src/WebPagePopupImpl.h:

(WebPagePopupImpl):

  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::instrumentWillBeginFrame):
(WebKit::WebViewImpl::instrumentDidBeginFrame):
(WebKit::WebViewImpl::instrumentDidCancelFrame):
(WebKit::WebViewImpl::instrumentWillComposite):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::didExitCompositingMode):

  • src/WebViewImpl.h:
  • tests/WebLayerTreeViewTestCommon.h:

(MockWebLayerTreeViewClient):

11:05 AM Changeset in webkit [144783] by jochen@chromium.org
  • 2 edits in trunk/Tools

Update list of builders for test results server
​https://bugs.webkit.org/show_bug.cgi?id=111166

Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.jsonp:
10:54 AM Changeset in webkit [144782] by Lucas Forschler
  • 2 edits in tags/Safari-537.31.14/Source/WebCore

Merged r143490. <rdar://problem/13341434>

10:49 AM Changeset in webkit [144781] by Lucas Forschler
  • 15 edits in tags/Safari-537.31.14/Source

Merged r143428. <rdar://problem/13341434>

10:30 AM Changeset in webkit [144780] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Tools

[GTK] Move basic dependency installation to a script
​https://bugs.webkit.org/show_bug.cgi?id=110692

Patch by Martin Robinson <​mrobinson@igalia.com> and Tomas Popela <​tpopela@redhat.com> on 2013-03-05
Reviewed by Gustavo Noronha Silva.

  • gtk/install-dependencies: Added. A Script which installs all dependencies

necessary for building for Debian-based distributions and Fedora.

10:29 AM Changeset in webkit [144779] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Follow up to ​https://bugs.webkit.org/show_bug.cgi?id=111453, forgot to mark the files as Private.

  • WebKit2.xcodeproj/project.pbxproj:
10:28 AM Changeset in webkit [144778] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.14/Source

Versioning.

10:26 AM Changeset in webkit [144777] by weinig@apple.com
  • 9 edits
    1 copy
    2 moves in trunk/Source/WebKit2

Elevate accessors of C-SPI API variants to Objective-C SPI
​https://bugs.webkit.org/show_bug.cgi?id=111453
<rdar://problem/13340357>

Reviewed by Alexey Proskuryakov.

  • Shared/mac/ObjCObjectGraphCoders.mm:
  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:
  • UIProcess/API/mac/WKBrowsingContextGroup.mm:
  • UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Renamed from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h.
  • UIProcess/API/mac/WKProcessGroup.mm:
  • UIProcess/API/mac/WKProcessGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h.
  • UIProcess/API/mac/WKView.mm:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

(-[WKWebProcessPlugInController _bundleRef]):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h: Renamed from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h.

Add access to C-SPI WebKit types as Objective-C SPI.

10:19 AM Changeset in webkit [144776] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

[CSS Exclusions] shape-outside on floats for polygon shapes
​https://bugs.webkit.org/show_bug.cgi?id=98676

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-05
Reviewed by David Hyatt.

Source/WebCore:

Implement support for polygonal shape-outside on floats. The basic
tack taken here is to keep using the bounding box of the shape to
position the float, but to compute the offset (caused by the shape)
from the bounding box for each line when creating and positioning
other inline content.

Test: fast/exclusions/shape-outside-floats/shape-outside-floats-simple-polygon.html

  • rendering/ExclusionShapeInfo.cpp:

(WebCore):
(WebCore::::computedShape): Add new template parameter.
(WebCore::::logicalTopOffset): Add new template parameter.
(WebCore::::computeSegmentsForLine): Move here from

ExclusionShapeInsideInfo, since ExclusionShapeOutsideInfo needs it
as well. Make virtual since there is slightly different behavior
between each class even though the vast majority of the code is
common.

  • rendering/ExclusionShapeInfo.h:

(WebCore):
(WebCore::ExclusionShapeInfo::~ExclusionShapeInfo): Since

computeSegmentsForLine is virtual, the destructor must be virtual
as well.

(ExclusionShapeInfo): Add new data members to support

computeSegmentsForLine.

(WebCore::ExclusionShapeInfo::shapeLogicalRight): Fix bug, the logical

right is based off of maxX, not y. (it's a logical bounding box!)

(WebCore::ExclusionShapeInfo::logicalLineTop): Moved from

ExclusionShapeInsideInfo for use by computeSegmentsForLine and
lineOverlapsShapeBounds.

(WebCore::ExclusionShapeInfo::logicalLineBottom): Moved from

ExclusionShapeInsideInfo for use by computeSegmentsForLine and
lineOverlapsShapeBounds.

(WebCore::ExclusionShapeInfo::lineOverlapsShapeBounds): Moved from

ExclusionShapeInsideInfo for use by computeSegmentsForLine.

  • rendering/ExclusionShapeInsideInfo.cpp: Moved common code from

computeSegmentsForLine into ExclusionShapeInfo.

  • rendering/ExclusionShapeInsideInfo.h:

(WebCore): Moved some methods to ExclusionShapeInfo.
(ExclusionShapeInsideInfo): Update for new template parameter.
(WebCore::ExclusionShapeInsideInfo::compyteSegmentsForLine): Override

superclass method to clear the segment ranges. Segement ranges
aren't used by shape outside, and have some complex dependencies
that make it very hard to try and move up into ExclusionShapeInfo.

(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Update

for new template parameter.

  • rendering/ExclusionShapeOutsideInfo.cpp:

(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Add polygons as a

supported shape.

(WebCore::ExclusionShapeOutsideInfo::computeSegmentsForLine): Override

superclass method to not recompute if it isn't needed (this isn't
straightfoward for shape inside, which is why it isn't common),
and to save the left and right offsets caused by the shape
outside, since that's all that is needed to properly do layout in
the case of floats.

  • rendering/ExclusionShapeOutsideInfo.h:

(WebCore::ExclusionShapeOutsideInfo::shapeLogicalOffset): Reformat to

be on a single line, like most other methods of it's type in
WebKit headers.

(ExclusionShapeOutsideInfo): Update for new template parameter.
(WebCore::ExclusionShapeOutsideInfo::logicalLeftOffsetForLine):

Accessor method to get the left offset between the shape and the
shape's bounding box.

(WebCore::ExclusionShapeOutsideInfo::logicalRightOffsetForLine):

Accessor method to get the left offset between the shape and the
shape's bounding box.

(WebCore::ExclusionShapeOutsideInfo::ExclusionShapeOutsideInfo):

Update for new template parameter.

  • rendering/RenderBlock.cpp:

(WebCore::::collectIfNeeded): Save the last float encountered so that

the shape outside offset can be accounted for.

(WebCore::RenderBlock::logicalLeftOffsetForLine): Account for the

shape outside offset on the outermost float.

(WebCore::RenderBlock::logicalRightOffsetForLine): Account for the

shape outside offset on the outermost float.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):

Initialize the lastFloat member.

(WebCore::RenderBlock::FloatIntervalSearchAdapter::lastFloat): Get the

last float encountered.

(FloatIntervalSearchAdapter): Add a pointer to the last float

encountered. Note that the variable is mutable because
collectIfNeeded is declared as a const method even though it isn't
(it uses loopholes to update m_offset and m_heightRemaining).
Instead of trying to come up with a hack to stick with the
loopholes, I decided to be explicit about it.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Take

into account the offset from any polygonal shape outside.

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Add a FIXME

because the current code will not work properly with stacked
floats that have polygonal shape outside.

LayoutTests:

Simple test for floats with polygonal shape-outside.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-polygon-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-polygon.html: Added.
10:18 AM Changeset in webkit [144775] by jamesr@google.com
  • 2 edits in trunk/Tools

Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
​https://bugs.webkit.org/show_bug.cgi?id=111440

Reviewed by Adrienne Walker.

Remove unnecessary WebCompositorSupport::shutdown call

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

10:06 AM Changeset in webkit [144774] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.14

New Tag.

10:05 AM Changeset in webkit [144773] by hyatt@apple.com
  • 13 edits in trunk/Source/WebCore

[New Multicolumn] Autogenerate regions for columns.
​https://bugs.webkit.org/show_bug.cgi?id=111363

Reviewed by Dean Jackson.

In CSS Regions, we lay out the regions first, and then
we put the flow thread into the regions. This model doesn't
really work for multicolumn layout, which needs to be able
to auto-generate new regions lazily in response to the flow
thread asking for regions at particular offsets.

With the multi-column model, where the regions can't just occur
anywhere, its ok not to lay them out before the flow thread, as
long as we have at least given them the correct size.

This patch changes the layout algorithm for columns to:
(1) Size any existing regions (without worrying about placement).
(2) Lay out the flow thread (generating and sizing regions lazily
that need to be created).
(3) Lay out the regions (to give them correct placement and to
compute overflow correctly for the multi-column block that contains
the regions).

There are no new tests, since there are no behavioral changes. This
is just groundwork for being able to add new sets in response to
spans, balancing, and nested pagination contexts.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::layoutBlockChild):

  • rendering/RenderBlock.h:

(RenderBlock):
Since we want to be able to call determineLogicalLeftPositionForChild
to place the flow thread properly, and we don't want to apply a layout
delta (flow threads repaint themselves), we parameterize the method
here so that it can be called without applying a layout delta.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
These methods are only used by RenderMultiColumnFlowThread, since
RenderNamedFlowThread overrides them. Remove the code that invalidates
the flow threads region set as regions come and go, since that is now
going to be expected with auto-generation.

(WebCore::RenderFlowThread::validateRegions):
Refactor the code in RenderFlowThread::layout that validates the regions
into its own method, so that we can re-validate regions at any time
after generating new ones.

(WebCore::RenderFlowThread::layout):
Changed to move the region validation code into its own function that is
now called from here.

(WebCore::RenderFlowThread::updateLogicalWidth):
Don't assert if a region set needs layout.

(WebCore::RenderFlowThread::computeLogicalHeight):
Ditto. Don't assert if a region set needs layout. That's expected now.

(WebCore::RenderFlowThread::regionAtBlockOffset):
Add code to regionAtBlockOffset to auto-generate regions up to
the offset. This ensures the region that is being asked for
exists.

(WebCore::RenderFlowThread::pageLogicalTopForOffset):
(WebCore::RenderFlowThread::pageLogicalWidthForOffset):
(WebCore::RenderFlowThread::pageLogicalHeightForOffset):
(WebCore::RenderFlowThread::pageRemainingLogicalHeightForOffset):
These functions are no longer const, since the act of asking for
pagination offsets can cause us to generate new regions.

(WebCore::RenderFlowThread::mapFromFlowToRegion):
Modified to turn auto-generation off, since this is not really
a "layout-time" function.

(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
Modified to not assert if a region set needs layout, since that is
expected now.

  • rendering/RenderFlowThread.h:

Changes to remove const from the methods that can trigger region
auto-generation.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::styleDidChange):
Make sure to propagate style changes down into the regions. I don't know
of any correctness bugs around this, but I figured I'd be thorough.

(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
We no longer build a column set aggressively. We wait for the flow thread
to ask us for a region at a particular offset, and only then do we
build the set.

(WebCore::RenderMultiColumnBlock::addChild):
Now that we lay out the flow thread as a special excluded child, we don't
care about the ordering of it relative to the region children.

(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
We now lay out the flow thread as a special excluded child (like the legend
of a fieldset).

  • rendering/RenderMultiColumnBlock.h:

(RenderMultiColumnBlock):
Add new overrides like layoutSpecialExcludedChild.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::initialLogicalWidth):
Set the flow thread to the initial column width even when no regions exist
yet. This way we ensure the width is right even when we don't have any
regions yet.

(WebCore::RenderMultiColumnFlowThread::autoGenerateRegionsToBlockOffset):
This method handles autogenerating the new region for a given offset.
Right now it's simplistic, since we only have one column set. This method
will be enhanced in future patches when we start supporting multiple column
sets.

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):
Adding new method declarations like autoGenerateRegionsToBlockOffset.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::updateLogicalWidth):
Since regions lay out after flow threads, we don't need to make
setFlowThreadPortionRect virtual any longer. We can just get our column set's
width correct immediately. This is the same logic, just moved into updateLogicalWidth().

  • rendering/RenderMultiColumnSet.h:

Remove setFlowThreadPortionRect override, since the function can just be simple
and non-virtual in RenderRegion now.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::layoutBlock):
Don't ever invalidate region sets in response to our size changing during layout. Since
our size is always determined outside of layout now, we don't need to do any of
these checks.

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::setFlowThreadPortionRect):
Changed to be non-virtual now that RenderMultiColumnSet doesn't need to override.

10:05 AM Changeset in webkit [144772] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Authentication credentials lost when opening a new tab
​https://bugs.webkit.org/show_bug.cgi?id=111445

PR 286627

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2013-03-05
Reviewed by Rob Buis.
Internally Reviewed by Lianghui Chen.

Prevent changing the private mode boolean value in didChangeSettings if the value
hasn't changed.

Setting the private mode value of credentialstorage every time didChangeSettings gets
called causes the session credential mapping to be cleared on every tab change in
non-private mode.

Tested changing tabs after logging into a site using the HTTP Basic Auth protocol to see
if the credentials are cleared. Also ensured the functionality of private mode is not changed.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

9:54 AM Changeset in webkit [144771] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] FatFinger pairs the wrong element with fatfinger rect part.
​https://bugs.webkit.org/show_bug.cgi?id=111444

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-03-05
Reviewed by Rob Buis.

Internal PR 266214
Internally reviewed by Genevieve Mak.

Instead of subtracting with the element region, we should get the remaining
rect by find the intersect region of element region and fatfinger detection
region.

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::checkForClickableElement):

9:42 AM Changeset in webkit [144770] by ap@apple.com
  • 18 edits
    1 add in trunk/Source

Make AsyncFileReader work without ScriptExecutionContext
​https://bugs.webkit.org/show_bug.cgi?id=111376

Reviewed by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj: Added MainThreadTask.h.
  • dom/ScriptExecutionContext.cpp:
  • dom/ScriptExecutionContext.h: Removed fileThread(). Creating a thread for every context that acesses files appears wasteful and unnecessary.
  • fileapi/AsyncFileStream.h:
  • fileapi/AsyncFileStream.cpp: (WebCore::createFileThread): FileThread is now a singleton. (WebCore::fileThread): Ditto. (WebCore::AsyncFileStream::AsyncFileStream): (WebCore::AsyncFileStream::create): (WebCore::didStart): (WebCore::AsyncFileStream::startOnFileThread): (WebCore::AsyncFileStream::stop): (WebCore::derefProxyOnMainThread): (WebCore::AsyncFileStream::stopOnFileThread): (WebCore::didGetSize): (WebCore::AsyncFileStream::getSizeOnFileThread): (WebCore::didOpen): (WebCore::AsyncFileStream::openForReadOnFileThread): (WebCore::AsyncFileStream::openForWriteOnFileThread): (WebCore::didRead): (WebCore::AsyncFileStream::readOnFileThread): (WebCore::didWrite): (WebCore::AsyncFileStream::writeOnFileThread): (WebCore::didTruncate): (WebCore::AsyncFileStream::truncateOnFileThread): Use callOnMainThread() instead of posting messages through a context. We never used other threads, and don't plan to.
  • loader/ResourceLoader.cpp:
  • loader/ResourceLoader.h: We no longer need this pseudo-client call to create an AsyncFileStream, now that we don't need to get a ScriptExecutionContext somewhere.
  • platform/MainThreadTask.h: Added. This implements callOnMainThread with multiple strongly typed arguments. Closely based on CrossThreadTask.h.
  • platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::BlobResourceHandle): Create AsyncFileStream directly.
  • platform/network/ResourceHandleClient.h: Removed createAsyncFileStream().
9:35 AM Changeset in webkit [144769] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Update the localizable strings file.

Rubber-stamped by Anders Carlsson.

  • English.lproj/Localizable.strings:
9:32 AM Changeset in webkit [144768] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13345116> REGRESSION: Child processes get access to user cache
and temporary directories instead of private ones

Reviewed by Sam Weinig.

  • Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::initializeSandbox): Restore the correct order of calls, so sandbox parameters respect WebKit pseudo containers.
9:26 AM Changeset in webkit [144767] by commit-queue@webkit.org
  • 14 edits
    1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r144708.
​http://trac.webkit.org/changeset/144708
​https://bugs.webkit.org/show_bug.cgi?id=111447

random assertion crashes in inspector tests on qt+mac bots
(Requested by kling on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-05

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/PropertyMapHashTable.h:

(PropertyTable):
(JSC::PropertyTable::PropertyTable):
(JSC):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::copy):

  • runtime/PropertyTable.cpp: Removed.
  • runtime/Structure.cpp:

(JSC::Structure::dumpStatistics):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::visitChildren):
(JSC::Structure::checkConsistency):

  • runtime/Structure.h:

(JSC):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
(JSC::Structure::checkOffsetConsistency):
(Structure):

  • runtime/StructureInlines.h:

(JSC::Structure::get):

  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::get):

9:24 AM Changeset in webkit [144766] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: aria-label does not override text content on iOS
​https://bugs.webkit.org/show_bug.cgi?id=111222

Reviewed by David Kilzer.

Source/WebCore:

Make iOS use the same text alternative computation that Mac is using. The main difference
is that description and title need to be concatenated, because iOS doesn't have two attributes
to return those values.

Test: platform/iphone-simulator/accessibility/aria-label-with-internal-text.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
(-[WebAccessibilityObjectWrapper accessibilityHint]):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:

LayoutTests:

  • platform/iphone-simulator/accessibility/aria-label-with-internal-text-expected.txt: Added.
  • platform/iphone-simulator/accessibility/aria-label-with-internal-text.html: Added.
9:08 AM Changeset in webkit [144765] by kov@webkit.org
  • 4 edits in trunk

Unreviewed build fix.

.:

  • GNUmakefile.am: remove bad path for generate-feature-defines-files from EXTRA_DIST.

Tools:

  • GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
8:58 AM Changeset in webkit [144764] by ddkilzer@apple.com
  • 8 edits in trunk/Source

BUILD FIX (r144698): Only enable SPEECH_SYNTHESIS for Mac
<​http://webkit.org/b/106742>

Fixes the following build failures:

Undefined symbols for architecture i386:

"ZTVN7WebCore25PlatformSpeechSynthesizerE", referenced from:

ZN7WebCore25PlatformSpeechSynthesizerC2EPNS_31PlatformSpeechSynthesizerClientE in PlatformSpeechSynthesizer.o

NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
"ZN7WebCore25PlatformSpeechSynthesizer19initializeVoiceListEv", referenced from:

ZN7WebCore25PlatformSpeechSynthesizerC2EPNS_31PlatformSpeechSynthesizerClientE in PlatformSpeechSynthesizer.o

ld: symbol(s) not found for architecture i386

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • Fix definition of ENABLE_ENCRYPTED_MEDIA_V2_macosx to match other FeatureDefines.xcconfig files.
  • Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform.
8:58 AM Changeset in webkit [144763] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: registered new MIME type application/font-woff for WOFF fonts.
​https://bugs.webkit.org/show_bug.cgi?id=111418

The WOFF MIME Type was formally registered as application/font-woff (FINALLY):
​http://www.iana.org/assignments/media-types/application/font-woff

Patch by Dmitry Zvorygin <​zvorygin@chromium.org> on 2013-03-05
Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):

8:27 AM Changeset in webkit [144762] by jchaffraix@webkit.org
  • 10 edits
    2 adds in trunk

[CSS Grid Layout] Add parsing for grid-{end|after}
​https://bugs.webkit.org/show_bug.cgi?id=111372

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-end-after-get-set.html

This change adds the proper support for grid-{end|after}. It doesn't update
grid-{row|column} to be a shorthand for both grid-{before|start} and grid-{after|end}
though.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Added the new properties to our known properties. Also added
support for getComputedStyle.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Added parsing for the new properties.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):
The new properties are not inherited.

  • css/CSSPropertyNames.in:

Added the new properties.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Added code to handle applying them to our style.

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridItemData.cpp:

(WebCore::StyleGridItemData::StyleGridItemData):

  • rendering/style/StyleGridItemData.h:

(WebCore::StyleGridItemData::operator==):
(StyleGridItemData):
Updated our representation to store the new properties.

LayoutTests:

  • fast/css-grid-layout/grid-item-end-after-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-item-end-after-get-set.html: Added.

Note that some of the test fails as we don't treat grid-{row|column} as a shorthand.

8:06 AM Changeset in webkit [144761] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed follow-up to r144756, fix broken inspector-less build.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willWriteHTML):

7:54 AM Changeset in webkit [144760] by mark.lam@apple.com
  • 21 edits
    2 adds in trunk

Improve robustness of WebSQL quota management.
​https://bugs.webkit.org/show_bug.cgi?id=110600.

Reviewed by Geoffrey Garen.

Source/WebCore:

  1. Introduced the OriginLock for synchronizing write access to the database origin directory. This allows us to more accurately compute the disk usage.

The OriginLock uses a mutex to provide mutual exclusion between
threads and a file lock for mutual exclusion between processes.
The file lock part is conditional on USE(FILE_LOCK).

The mutex mutual exclusion also serves to ensure that only 1 thread
can write to a sqlite database at one time.

  1. Change the SQLTransactionCoordinator to only allow one write transaction to an origin instead of one write transaction per database. This is needed in order to accurately compute the disk usage. It is also necessary so that the OriginLock does not deadlock itself (as would be the case if concurrent write transactions to different databases in the same origin are allowed).
  1. Fix DatabaseTracker::getMaxSizeForDatabase() to check for when disk usage may exceed the quota, and ensure that we will return an appropriate max database size.

Disk usage can exceed the usage if it is already near the quota limit
but have not exceeded it yet. If a new database is opened in that
origin, it may bump the usage above the quota, but should not
continually repeat this. Subsequent attempts to open a database
will find that the quota is already exhausted and fail.

There is still a race condition pertaining to the tracker database
getting out of sync that may still enable runaway growth in the
database sizes. That issue only manifest in a multi-process
environment, and will be fixed in another changeset.

  1. Fixed a bug in SQLStatement to check if the errorCallback exists before invoking it.

No new layout tests. A quota-test.html was attached to bugzilla for manual
testing of multi-tab concurrent consumption of storage resource, and also
to test handling situations when the user deletes the database files while
the script is still using the database.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::originLockFor):
(WebCore::DatabaseTracker::deleteOriginLockFor):
(WebCore::DatabaseTracker::deleteOrigin):

  • Modules/webdatabase/DatabaseTracker.h:
  • Modules/webdatabase/OriginLock.cpp: Added.

(WebCore::OriginLock::lockFileNameForPath):
(WebCore::OriginLock::OriginLock):
(WebCore::OriginLock::~OriginLock):
(WebCore::OriginLock::lock):
(WebCore::OriginLock::unlock):

  • Modules/webdatabase/OriginLock.h: Added.
  • Modules/webdatabase/SQLStatement.cpp:

(WebCore::SQLStatement::performCallback):

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
(WebCore::SQLTransactionBackend::acquireOriginLock):
(WebCore::SQLTransactionBackend::releaseOriginLockIfNeeded):

  • Modules/webdatabase/SQLTransactionBackend.h:

(SQLTransactionBackend):

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::getDatabaseIdentifier):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • config.h:
  • platform/FileSystem.h:
  • platform/posix/FileSystemPOSIX.cpp:

(WebCore::lockFile):
(WebCore::unlockFile):

LayoutTests:

  • storage/websql/multiple-databases-garbage-collection.js:
  • This test runs 2 transactions on 2 databases (1 each). The 2 databases are named "persistent" and "forgotten". The test executes the transaction on "persistent" first, but expects the transaction on "forgotten" to finish first. This is because "forgotten"'s transaction is a smaller one. The new changes to SQLTransactionCoordinator now ensures that a write transaction must completes before another is started for databases in the same origin. Hence, the previously expected result will no longer be true.

Regardless, the purpose of the test is not to test the order of
completion but that resources are reclaimed. So, I'm changing the test
to start the "forgotten" transaction first followed by the "persistent"
transaction. This ensures that the test will yield consistent results
even when run on ports that may allow more than one write transaction
to run at the same time.

7:29 AM Changeset in webkit [144759] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: move PopoverContentHelper from TimelinePresentationModel.js to Popover.js.
​https://bugs.webkit.org/show_bug.cgi?id=111431

Reviewed by Yury Semikhatsky.

class WebInspector.TimelinePresentationModel.PopoverContentHelper was renamed to WebInspector.PopoverContentHelper.
Style names were changed accordingly.

  • inspector/front-end/Popover.js:

(WebInspector.PopoverContentHelper):
(WebInspector.PopoverContentHelper.prototype.contentTable):
(WebInspector.PopoverContentHelper.prototype._createCell):
(WebInspector.PopoverContentHelper.prototype.appendTextRow):
(WebInspector.PopoverContentHelper.prototype.appendElementRow):
(WebInspector.PopoverContentHelper.prototype.appendStackTrace):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.generateMainThreadBarPopupContent):
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.generatePopupContentForFrame):
(WebInspector.TimelinePresentationModel.generatePopupContentForFrameStatistics):

  • inspector/front-end/popover.css:

(.popover-details):
(.popover-function-name):
(.popover-stacktrace-title):
(.popover-details-row-title):
(.popover-details-row-data):
(.popover-details-title):

  • inspector/front-end/timelinePanel.css:
7:00 AM Changeset in webkit [144758] by abecsi@webkit.org
  • 3 edits in trunk/Tools

[Qt][MiniBrowser] Improve the update of touch indicators
​https://bugs.webkit.org/show_bug.cgi?id=111429

Reviewed by Jocelyn Turcotte.

MiniBrowserApplication::sendTouchEvent sends an empty list
to BrowserWindow::updateVisualMockTouchPoints if the control
button is released, in which case the touch indicators should
be hidden so that we never end up with a leftover indicator
sticking on the screen.
This patch also simplifies the lookup of the indicator items by
replacing the findChild search in the item tree with a QHash
that stores the touch ID's and the pointers to the corresponding
indicator items.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::updateVisualMockTouchPoints):

  • MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

6:54 AM Changeset in webkit [144757] by yurys@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: remove "Live native memory chart" experiment
​https://bugs.webkit.org/show_bug.cgi?id=111432

Reviewed by Alexander Pavlov.

Removed support for live native memory chart.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NativeMemorySnapshotView.js:
  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/nativeMemoryProfiler.css:
6:09 AM Changeset in webkit [144756] by caseq@chromium.org
  • 10 edits in trunk

Web Inspector: remove length parameter from Parse HTML timeline event
​https://bugs.webkit.org/show_bug.cgi?id=111421

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • remove length parameter in all instrumentation methods used to emit ParseHTML timeline event;
  • drive-by style fixes.
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willWriteHTMLImpl):
(WebCore::InspectorInstrumentation::didWriteHTMLImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willWriteHTML):
(WebCore::InspectorInstrumentation::didWriteHTML):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didWriteHTML):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createParseHTMLData):

  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

LayoutTests:

  • removed length field from ParseHTML data in expectations.
  • inspector/timeline/timeline-parse-html-expected.txt:
6:06 AM Changeset in webkit [144755] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: Add a renderer process memory size test.
​https://bugs.webkit.org/show_bug.cgi?id=111337

Patch by Alexei Filippov <​alph@chromium.org> on 2013-03-05
Reviewed by Yury Semikhatsky.

The test checks that the renderer process memory size
is obtained from the browser and reported to the inspector
frontend correctly.

  • src/js/Tests.js:

(.TestSuite.prototype.testRendererProcessNativeMemorySize.checkFuzzyValue):
(.TestSuite.prototype.testRendererProcessNativeMemorySize.step2):

5:58 AM Changeset in webkit [144754] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: allow each profiler panel to have own landing page
​https://bugs.webkit.org/show_bug.cgi?id=111298

Patch by Alexei Filippov <​alph@chromium.org> on 2013-03-05
Reviewed by Yury Semikhatsky.

Refactor profiler landing page to allow different profiler panels to have own landing pages.

  • MultiProfileLauncherView is inherited from ProfileLauncherView
  • Native memory distribution profiler has got a custom page.

No new tests: code refactoring.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype.get profile):
(WebInspector.HeapSnapshotView.prototype.get baseProfile):
(WebInspector.HeapSnapshotView.prototype._profiles):

  • inspector/front-end/NativeMemorySnapshotView.js:
  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
(WebInspector.ProfileLauncherView.prototype._controlButtonClicked):
(WebInspector.ProfileLauncherView.prototype._updateControls):
(WebInspector.ProfileLauncherView.prototype.profileStarted):
(WebInspector.ProfileLauncherView.prototype.profileFinished):
(WebInspector.MultiProfileLauncherView):
(WebInspector.MultiProfileLauncherView.prototype.addProfileType):
(WebInspector.MultiProfileLauncherView.prototype._profileTypeChanged):
(WebInspector.NativeProfileLauncherView):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._createLauncherView):
(WebInspector.CPUProfilerPanel):
(WebInspector.CSSSelectorProfilerPanel):
(WebInspector.HeapProfilerPanel):
(WebInspector.CanvasProfilerPanel):
(WebInspector.MemoryChartProfilerPanel):
(WebInspector.MemoryChartProfilerPanel.prototype._createLauncherView):
(WebInspector.NativeMemoryProfilerPanel):

  • inspector/front-end/profilesPanel.css:

(.panel-enabler-view.profile-launcher-view button:not(.status-bar-item)):

5:33 AM Changeset in webkit [144753] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Clarify some StylesSidebarPanel and CSSMetadata JSDocs.
​https://bugs.webkit.org/show_bug.cgi?id=111427

Reviewed by Alexander Pavlov.

Goal: reflect in JSDoc that non-null array is passed to completionsReady callback.

  • inspector/front-end/CSSMetadata.js:

Added JSDocs, avoided possible NPEs.

  • inspector/front-end/StylesSidebarPane.js:

Fixed JSDocs, removed unused assignment.

5:29 AM Changeset in webkit [144752] by g.czajkowski@samsung.com
  • 21 edits in trunk

[WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
​https://bugs.webkit.org/show_bug.cgi?id=81042

Reviewed by Enrica Casucci.

Source/WebKit2:

Expose WK2 setting to enable/disabled asynchronous spell checking.
It's used by WebKitTestRunner to reset the setting at the beginning
of the test.
WebKit2 ports might be interested in this setting if they are going
to enable this feature.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetAsynchronousSpellCheckingEnabled):
(WKPreferencesGetAsynchronousSpellCheckingEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetAsynchronousSpellCheckingEnabled):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setAsynchronousSpellCheckingEnabled):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Add setAsynchronousSpellCheckingEnabled implementation for
WebKitTestRunner to have the possibility to test asynchronous
spell checking implementation from bug 109577.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAsynchronousSpellCheckingEnabled):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Gardening of the asynchronous spell checking tests.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:

Some tests need to be skipped as they require features not
implemented for EFL yet (pasteboard, grammar checking, text replacement).

  • platform/gtk-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:

Skip asynchronous spell checking for GTK+, Mac, Qt unless
they implement TextChecker::requestCheckingOfText.

  • platform/wk2/TestExpectations:

Remove asynchronous spell checking tests from global wk2's
as they are passing for EFL.

5:29 AM Changeset in webkit [144751] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r144727): Change type of columnRange and rowRange to pair<unsigned, unsigned>
<​http://webkit.org/b/110050>

Fixes the following build failures:

Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:741:30: error: non-const lvalue reference to type 'pair<unsigned int, unsigned int>' cannot bind to a value of unrelated type 'pair<int, int>'

tableCell->rowIndexRange(rowRange);

~

In file included from Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:33:
Source/WebCore/accessibility/AccessibilityTableCell.h:47:58: note: passing argument to parameter 'rowRange' here

virtual void rowIndexRange(pair<unsigned, unsigned>& rowRange);


Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:742:33: error: non-const lvalue reference to type 'pair<unsigned int, unsigned int>' cannot bind to a value of unrelated type 'pair<int, int>'

tableCell->columnIndexRange(columnRange);


In file included from Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:33:
Source/WebCore/accessibility/AccessibilityTableCell.h:49:61: note: passing argument to parameter 'columnRange' here

virtual void columnIndexRange(pair<unsigned, unsigned>& columnRange);


Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:804:30: error: non-const lvalue reference to type 'pair<unsigned int, unsigned int>' cannot bind to a value of unrelated type 'pair<int, int>'

tableCell->rowIndexRange(rowRange);

~

In file included from Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:33:
Source/WebCore/accessibility/AccessibilityTableCell.h:47:58: note: passing argument to parameter 'rowRange' here

virtual void rowIndexRange(pair<unsigned, unsigned>& rowRange);


Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:818:33: error: non-const lvalue reference to type 'pair<unsigned int, unsigned int>' cannot bind to a value of unrelated type 'pair<int, int>'

tableCell->columnIndexRange(columnRange);


In file included from Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:33:
Source/WebCore/accessibility/AccessibilityTableCell.h:49:61: note: passing argument to parameter 'columnRange' here

virtual void columnIndexRange(pair<unsigned, unsigned>& columnRange);


4 errors generated.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityHeaderElements]):
(-[WebAccessibilityObjectWrapper accessibilityRowRange]):
(-[WebAccessibilityObjectWrapper accessibilityColumnRange]):

5:00 AM FeatureFlags edited by tkent@chromium.org
FONT_LOAD_EVENTS (diff)
4:53 AM Changeset in webkit [144750] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Clean up animated scroll/zoom code in WebPagePrivate
​https://bugs.webkit.org/show_bug.cgi?id=111373

Patch by Andrew Lo <​anlo@rim.com> on 2013-03-05
Reviewed by Rob Buis.

Internally reviewed by Jakob Petsovits.
Internal PR 285468.

Have WebPageClient pass the final scale and position to WebPage when a zoom/scroll
animation finishes, rather than keeping those values as instance variables in
WebPagePrivate.

Rename some functions & variables to reflect that they are used for both block zoom
and generic zoom/scroll animations.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
(BlackBerry::WebKit::WebPage::zoomAnimationFinished):
(BlackBerry::WebKit::WebPagePrivate::resetBlockZoom):
(BlackBerry::WebKit::WebPage::blockZoom):
(BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):

  • Api/WebPage.h:
  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

4:23 AM Changeset in webkit [144749] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [refactoring] set frame identifiers in timeline records early, do not keep them in event stack
​https://bugs.webkit.org/show_bug.cgi?id=111345

Reviewed by Pavel Feldman.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setFrameIdentifier):
(WebCore):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::commitFrameRecord):

  • inspector/InspectorTimelineAgent.h:

(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):
(InspectorTimelineAgent):

4:17 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
3:34 AM Changeset in webkit [144748] by tommyw@google.com
  • 16 edits in trunk

MediaStream API: Add the getStreamById method on RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=111311

Reviewed by Adam Barth.

Source/Platform:

Added an initial initialize method which doesn't take an id;
the id will be generated for you.

  • chromium/public/WebMediaStream.h:

(WebMediaStream):

Source/WebCore:

Adding the missing method on RTCPeerConnection defined here:
​http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-getStreamById-MediaStream-DOMString-streamId

Existing tests have been extended to cover patch.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getStreamById):
(WebCore):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • platform/chromium/support/WebMediaStream.cpp:

(WebKit::WebMediaStream::initialize):
(WebKit):

  • platform/mediastream/MediaStreamSource.cpp:

(WebCore::MediaStreamSource::setReadyState):

Tools:

Changing mocks to be more realistic.

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:

(WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
(WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:

(WebTestRunner::WebUserMediaClientMock::requestUserMedia):

LayoutTests:

  • fast/mediastream/MediaStream-add-remove-tracks.html:
  • fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt:
  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
3:31 AM Changeset in webkit [144747] by Antoine Quint
  • 5 edits
    3 adds in trunk

Web Inspector: allow retrieval of composited layers in a given DOM subtree
​https://bugs.webkit.org/show_bug.cgi?id=111312

Source/WebCore:

Introduce the LayerTreeAgent.layersForNode(node) method allowing the front-end
to gather all composited layers associated with nodes in the subtree of which
the provided node is the root.

In order to gather the layers in the subtree, we first traverse the node's
renderer's RenderObject hierarchy and whenever we encounter a RenderObject
that has a RenderLayer, we then traverse that renderLayer's RenderLayer
hierarchy. This allows for a quick path through the relevant objects we're
gathering.

Layers gathered will push the node to which they're associated, allowing a
nodeId for this layer to be listed in the Layer object sent to the front-end.
It is crucial to be able to provide a nodeId as well as a layerId for a Layer
object in order to be able to correctly assess mutations in the layer tree.
For instance, it is expected that a node's layer be replaced by a new layer
to represent a slightly different rendering of its content, but the front-end
should be able to represent this layer as an object for which only certain
attributes have changed (like the "paintCount" property).

Layer objects also indicate whether they're associated to a node hosted in a
shadow tree (the optional "isInShadowTree" property) in order for the front-end
to be able to only show this layer if the option to show nodes hosted in shadow
tree is enabled.

Finally, since we're only gathering composited layers, we're removing the
"isLayerComposited" property and removing the optional flag on the "paintCount",
"memory" and "compositedBounds" properties.

Reviewed by Simon Fraser.

Test: inspector-protocol/layers/layers-for-node.html

  • inspector/Inspector.json:
  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderObjectHierarchy):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderLayerHierarchy):
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
(WebCore::InspectorLayerTreeAgent::idForNode):

  • inspector/InspectorLayerTreeAgent.h:

(InspectorLayerTreeAgent):

LayoutTests:

New test for the LayerTree.layersForNode() method.

Reviewed by Simon Fraser.

  • inspector-protocol/layers/layers-for-node-expected.txt: Added.
  • inspector-protocol/layers/layers-for-node.html: Added.
2:53 AM Changeset in webkit [144746] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: use timestamps consistent with rest of Timeline in WebSocket events.
​https://bugs.webkit.org/show_bug.cgi?id=111344

  • create web socket related records in a manner consistent with the rest of timeline.

Reviewed by Pavel Feldman.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didCreateWebSocket):
(WebCore::InspectorTimelineAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorTimelineAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorTimelineAgent::didDestroyWebSocket):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

2:38 AM Changeset in webkit [144745] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Add requestCheckingOfString implementation.
​https://bugs.webkit.org/show_bug.cgi?id=108172

Reviewed by Hajime Morrita.

Provide implementation of 'requestCheckingOfString' for WK2-EFL.
It uses the unified text checker feature.

  • UIProcess/efl/TextCheckerEfl.cpp:

(WebKit::TextChecker::requestCheckingOfString):

2:27 AM Changeset in webkit [144744] by abucur@adobe.com
  • 6 edits
    2 adds in trunk

[CSS Regions] Crash when MathML used in CSS Regions
​https://bugs.webkit.org/show_bug.cgi?id=110686

Reviewed by David Hyatt.

Source/WebCore:

The MathML blocks trigger a children layout when computing the preferred widths. This happens to determine the preferred
logical heights of the children. When the layout reaches the line boxes computation the preferred width of the containing block
is requested. Because it wasn't computed, the layout of the children is started again to determine the preferred logical heights.
This causes an infinite recursion and triggers a stack overflow.

The patch introduces a new RAII utility class that disables fragmentation when the constructor is called and restores it
on the destructor. This class is used when computing the preferred height for the children of a MathML block.

Test: fast/regions/mathml-crash.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setFlowThreadStateIncludingDescendants): Do not cross RenderFlowThread boundaries when updating the flow thread
state flag. The innermost flow threads need to manage their descendants flag values.

  • rendering/RenderView.cpp:

(WebCore::FragmentationDisabler::FragmentationDisabler):
(WebCore):
(WebCore::FragmentationDisabler::~FragmentationDisabler):

  • rendering/RenderView.h:

(FragmentationDisabler):
(WebCore):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):

LayoutTests:

Add a test to verify regions and MathML do not crash.

  • fast/regions/mathml-crash-expected.txt: Added.
  • fast/regions/mathml-crash.html: Added.
2:05 AM Changeset in webkit [144743] by mkwst@chromium.org
  • 10 edits
    2 adds in trunk/Source/WebCore

Cleanup: Move HitTestLocation and HitTestResult into separate files.
​https://bugs.webkit.org/show_bug.cgi?id=111294

Reviewed by Allan Sandfeld Jensen.

HitTestLocation and HitTestResult currently both live in
HitTestResult.h. That makes things more difficult to understand than
they should be, and violates the one-class-one-file principle that
WebKit generally follows. Happily, it's fairly trivial to fix.

This should have no visible change; it's strictly an internal
refactoring. It doesn't even touch any implementation code: we're
just moving bits from one place to another.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Hey, look: a new file! Let's add it to six different build systems! :)

  • rendering/HitTestLocation.cpp: Added.

(WebCore):
(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestLocation::~HitTestLocation):
(WebCore::HitTestLocation::operator=):
(WebCore::HitTestLocation::move):
(WebCore::HitTestLocation::intersectsRect):
(WebCore::HitTestLocation::intersects):
(WebCore::HitTestLocation::rectForPoint):

  • rendering/HitTestLocation.h: Added.

(WebCore):
(HitTestLocation):
(WebCore::HitTestLocation::point):
(WebCore::HitTestLocation::roundedPoint):
(WebCore::HitTestLocation::region):
(WebCore::HitTestLocation::isRectBasedTest):
(WebCore::HitTestLocation::isRectilinear):
(WebCore::HitTestLocation::boundingBox):
(WebCore::HitTestLocation::topPadding):
(WebCore::HitTestLocation::rightPadding):
(WebCore::HitTestLocation::bottomPadding):
(WebCore::HitTestLocation::leftPadding):
(WebCore::HitTestLocation::transformedPoint):
(WebCore::HitTestLocation::transformedRect):

  • rendering/HitTestResult.cpp:
  • rendering/HitTestResult.h:

Move all this code from HitTestResult.* to HitTestLocation.*.

  • rendering/RenderBlock.cpp:

Include HitTestLocation.h.

1:30 AM Changeset in webkit [144742] by jochen@chromium.org
  • 5 edits in trunk/Source/WebCore

Refactor UserGestureIndicator::Token to be a top-level class
​https://bugs.webkit.org/show_bug.cgi?id=111412

Reviewed by Nico Weber.

This will allow for forward declaring the class in a public WebKit
API header. The goal is to enable the embedder to hold on to a
UserGestureToken.

  • dom/UserGestureIndicator.cpp:

(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::currentToken):

  • dom/UserGestureIndicator.h:

(UserGestureToken):
(WebCore::UserGestureToken::~UserGestureToken):
(WebCore):
(UserGestureIndicator):

  • page/DOMTimer.h:

(DOMTimer):

  • page/EventHandler.h:
1:15 AM Changeset in webkit [144741] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove redundant code in Document::updateHoverActiveState.
​https://bugs.webkit.org/show_bug.cgi?id=111303

Reviewed by Darin Adler.

Document::updateHoverActiveState currently looks for touchrelease events
and explictly clears out the hover state for all nodes between the
currently hovered node and the top of the hover chain. This is actually
redundant with the logic in the rest of the function; we can simplify by
setting the Element* we're working with to 0, which causes the later
loops to do the necessary work.

There should be no web-visible effect from this change; it should simply
make this function less complex.

Extracted from Allan Sandfeld Jensen's original patch to wkbug.com/98168

  • dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

Set innerElementInDocument to 0 rather than walking the hover chain
and clearing it when we see a touchrelease event. The rest of the
code in this function will have the same effect.

1:03 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:02 AM Changeset in webkit [144740] by Carlos Garcia Campos
  • 8 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r144652 - [GTK] Some WebKit2 GTK+ unit tests are failing in 32 bits bot
​https://bugs.webkit.org/show_bug.cgi?id=111346

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-03-04
Reviewed by Martin Robinson.

The problem is the use of a temporary CString object in the macro
g_assert_cmpstr. It's a common mistake because we usually forget
that g_assert_cmpstr is not a function but a macro, that expands
to multiple lines. This patch adds a new macro ASSERT_CMP_CSTRING
with the same implementation that g_assert_cmpstr, but using
CStrings instead of const char*. It fixes all the cases where a
temporary CString was used in g_assert_cmpstr, and uses the new
macro also for the cases where we were caching the CString just
for g_assert_cmpstr.

  • UIProcess/API/gtk/tests/TestDownloads.cpp:

(testDownloadRemoteFile):

  • UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(testInspectorServerPageList):

  • UIProcess/API/gtk/tests/TestLoaderClient.cpp:
  • UIProcess/API/gtk/tests/TestMain.h:
  • UIProcess/API/gtk/tests/TestResources.cpp:
  • UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:

(testGetFaviconURI):

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(assertThatUserAgentIsSentInHeaders):
(testWebKitSettingsUserAgent):

12:46 AM Changeset in webkit [144739] by jochen@chromium.org
  • 2 edits in trunk/Tools

Add content shell bots to garden-o-matic for general failurse
​https://bugs.webkit.org/show_bug.cgi?id=111168

Reviewed by Adam Barth.

All but the WebKit (Content Shell) Android bot is stable enough. While
they're not green yet, there must not be any non-layout test failures on
them.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

(.):

12:31 AM Changeset in webkit [144738] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove unused custom indexedPropertyGetter
​https://bugs.webkit.org/show_bug.cgi?id=111409

Patch by Koji Hara <​kojih@chromium.org> on 2013-03-05
Reviewed by Kentaro Hara.

Remove unused custom indexedPropertyGetter.
There are 9 custom indexedPropertyGetter, including an unused one(NamedNodeMap).
This commit assures all existing custom indexedPropertyGetter(for V8) are used.

No new tests. Simple refactoring.

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: Remove indexedPropertyGetter
12:30 AM Changeset in webkit [144737] by sudarsana.nagineni@linux.intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening.

Skip failing tests on EFL bots.

  • platform/efl/TestExpectations:
12:14 AM Changeset in webkit [144736] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; updating test expectations.

fast/regions/seamless-iframe-flowed-into-regions.html is failing not only with debug build.

  • platform/chromium/TestExpectations:
12:08 AM Changeset in webkit [144735] by morrita@google.com
  • 14 edits in trunk/Source/WebCore

ShadowRoot needs guardRef() and guardDeref()
​https://bugs.webkit.org/show_bug.cgi?id=109777

Reviewed by Dimitri Glazkov.

This change moves m_guardRefCount from Document to TreeScope,
which allows ShadowRoot to be guarded by guardRef() mechanism as
Document. After r137524, Node referes TreeScope instead of
Document. This is natural consequence of the change: It no longer
makes sense to guardRef() Document pointer from Node.

Detail:

  • Document::m_guardRefCount and related funcdtions are moved to TreeScope
  • Document::removedLastRef is factored out into TreeScope::removedLastRefToScope(), TreeScope::dispose() and Docuent::dispose(). ShadowRoot also got its own dispose() implementation.
  • Moved guardRef() and guardDeref() calls to TreeScope and Node. Note that there are two "guarded" TreeScope references. One is Node::m_treeScope and another is TreeScope::m_parentTreeScope. The guarded-ref management is now encapsulated in these two classes.

No new tests. Covered by existing tests.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::dispose): Extracted from removedLastRef()

  • dom/Document.h:

(WebCore::Node::isTreeScope):
(WebCore::Node::Node):

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::DocumentFragment): Remove ASSERT() and move it to ...
(WebCore::DocumentFragment::create): ... here, to allow NULL document from ShadowRoot.

  • dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::removedLastRef):

  • dom/Node.h:

(WebCore::Node::setTreeScope):

  • dom/Element.cpp:

(WebCore::Element::ensureAttr): This has been wrong and is fixed in this revision since the incorrectness is unveiled by this change.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot): Passed NULL document to superclass. This aligns what Document is doing.
(WebCore::ShadowRoot::dispose): Added.

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/TreeScope.cpp:

(SameSizeAsTreeScope):
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::dispose): Added.
(WebCore::TreeScope::setParentTreeScope):
(WebCore::TreeScope::deletionHasBegun):
(WebCore::TreeScope::beginDeletion):
(WebCore::TreeScope::refCount): Added.

  • dom/TreeScope.h: Turned m_rootNode to Node* from ContainerNode* for Node::isTreeScope to be inlined.

(WebCore::TreeScope::guardRef): Pulled up from Document.
(WebCore::TreeScope::guardDeref): Ditto.
(WebCore::TreeScope::hasGuardRefCount): Added to hide m_guardRefCount.
(WebCore::TreeScope::deletionHasBegun): Added.
(WebCore::TreeScope::beginDeletion): Added.
(WebCore::TreeScope::removedLastRefToScope): Pulled up from Document.

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

Mar 4, 2013:

11:59 PM Changeset in webkit [144734] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2013-03-04 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, adding crashing test to the expectations.

  • platform/chromium/TestExpectations:
11:56 PM Changeset in webkit [144733] by jochen@chromium.org
  • 2 edits in trunk/Tools

[chromium] remove deprecated WebTestRunner::setFocus API
​https://bugs.webkit.org/show_bug.cgi?id=111354

Reviewed by James Robinson.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

11:44 PM Changeset in webkit [144732] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getPropertyValue for -webkit-text-stroke returns null, should compute the shorthand value
​https://bugs.webkit.org/show_bug.cgi?id=111018

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-03-04
Reviewed by Alexander Pavlov.

Source/WebCore:

Test: fast/css/getPropertyValue-webkit-text-stroke.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

LayoutTests:

Added test for getPropertyValue("-webkit-text-stroke").

  • fast/css/getPropertyValue-webkit-text-stroke-expected.txt: Added.
  • fast/css/getPropertyValue-webkit-text-stroke.html: Added.
11:42 PM Changeset in webkit [144731] by jochen@chromium.org
  • 7 edits in trunk/Tools

Run the bindings generation tests on EWS and CQ bots
​https://bugs.webkit.org/show_bug.cgi?id=111358

Reviewed by Adam Barth.

The tests are super fast and not flaky.

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.run_bindings_tests_command):

  • Scripts/webkitpy/common/config/ports_mock.py:

(MockPort.run_webkit_tests_command):
(MockPort):
(MockPort.run_bindings_tests_command):

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_webkit_run_unit_tests):

  • Scripts/webkitpy/tool/steps/steps_unittest.py:
11:33 PM Changeset in webkit [144730] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getPropertyValue for -webkit-columns returns null, should compute the shorthand value
​https://bugs.webkit.org/show_bug.cgi?id=111011

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-03-04
Reviewed by Alexander Pavlov.

Source/WebCore:

Test: fast/css/getPropertyValue-columns.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

LayoutTests:

Added test for getPropertyValue("-webkit-columns").

  • fast/css/getPropertyValue-columns-expected.txt: Added.
  • fast/css/getPropertyValue-columns.html: Added.
11:31 PM Changeset in webkit [144729] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Do not accumulate file system files, add them to workspace immediately
​https://bugs.webkit.org/show_bug.cgi?id=111325

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate.prototype.populate.fileLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):

  • inspector/front-end/IsolatedFileSystem.js:

(WebInspector.IsolatedFileSystem.prototype.innerCallback):
(WebInspector.IsolatedFileSystem.prototype.requestFilesRecursive):

LayoutTests:

  • inspector/file-system-project.html:
11:20 PM Changeset in webkit [144728] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix attempt.

floor method is ambigious so explicitly specify the type.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):

11:13 PM Changeset in webkit [144727] by Chris Fleizach
  • 16 edits
    2 adds in trunk

AX: cellForColumnAndRow fails for tables with hidden table cells
​https://bugs.webkit.org/show_bug.cgi?id=110050

Reviewed by Tim Horton.

Source/WebCore:

If a table had hidden cells, then accessibility code was being confused in a few ways.
1) The cellForColumnAndRow method would return the wrong information since that was

using the RenderTableSection to retrieve a cell, which did not have the same data as the AXTable

2) The way we were adding children made it impossible to determine column and row range because we

would skip rows that had hidden children

3) AccessibilityARIAGrid and AccessibilityTable were using different methods for cellForColumnAndRow

The fix does a few things to make things right:
1) Always add an accessibility row, even if there are no visible cells in that row.
2) Have one method for AXTable and AXARIAGrid for cellForColumnAndRow.
3) Change cellForColumnAndRow to query the accessibility children rather than the RenderTableSection in determining the row, col info.
4) cellForColumnAndRow should use unsigned values instead of int values.

Test: accessibility/table-with-hidden-head-section.html

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::rowIndexRange):
(WebCore::AccessibilityARIAGridCell::columnIndexRange):

  • accessibility/AccessibilityARIAGridCell.h:

(AccessibilityARIAGridCell):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::cellForColumnAndRow):

  • accessibility/AccessibilityTable.h:

(WebCore):
(AccessibilityTable):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::rowIndexRange):
(WebCore::AccessibilityTableCell::columnIndexRange):

  • accessibility/AccessibilityTableCell.h:

(AccessibilityTableCell):

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetColumnAtIndex):
(webkitAccessibleTableGetRowAtIndex):
(webkitAccessibleTableGetColumnExtentAt):
(webkitAccessibleTableGetRowExtentAt):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • rendering/RenderTableSection.h:

(RenderTableSection):
(WebCore::RenderTableSection::rowRendererAt):

Source/WebKit/chromium:

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::cellColumnIndex):
(WebKit::WebAccessibilityObject::cellColumnSpan):
(WebKit::WebAccessibilityObject::cellRowIndex):
(WebKit::WebAccessibilityObject::cellRowSpan):

LayoutTests:

  • accessibility/table-with-hidden-head-section-expected.txt: Added.
  • accessibility/table-with-hidden-head-section.html: Added.
  • platform/chromium/TestExpectations:
10:57 PM Changeset in webkit [144726] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getAttribute does not behave correctly for mixed-case attributes on HTML elements
​https://bugs.webkit.org/show_bug.cgi?id=105713

Patch by Arpita Bahuguna <​a.bah@samsung.com> on 2013-03-04
Reviewed by Andreas Kling.

Source/WebCore:

getAttribute() and getAttributeNode() APIs do not convert the
passed attribute name to lowercase before comparing against the
existing attributes.
The specification however states that the passed name should
be converted to ASCII lowercase before checking for the existence
of the given attribute. [www.w3.org/TR/domcore/#dom-element-getattribute]

Test: fast/dom/Element/getAttribute-case-insensitivity.html

  • dom/Element.h:

(WebCore::ElementData::getAttributeItemIndex):
getAttributeItemIndex() accepts a bool param 'shouldIgnoreAttributeCase'
which specifies whether the attribute's case should be ignored
before comparison. But inspite of this param's value we still carry
out a case sensitive search.
Have modified the same to convert the passed attribute's name to
lowercase if 'shouldIgnoreAttributeCase' is true.

LayoutTests:

  • fast/dom/Element/getAttribute-case-insensitivity-expected.txt: Added.
  • fast/dom/Element/getAttribute-case-insensitivity.html: Added.

Layout test added for verifying that getAttribute() and getAttributeNode()
APIs convert the passed attribute name to lowercase before comparing
against the existing attributes.

10:35 PM Changeset in webkit [144725] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Chromium] Add runtime flag for font load events
​https://bugs.webkit.org/show_bug.cgi?id=111296

Patch by Kunihiko Sakamoto <​ksakamoto@chromium.org> on 2013-03-04
Reviewed by Kent Tamura.

Add a runtime feature flag for FontLoader interface (disabled by default),
and enable ENABLE_FONT_LOAD_EVENTS build flag for chromium.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setFontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableFontLoadEvents):
(WebKit):
(WebKit::WebRuntimeFeatures::isFontLoadEventsEnabled):

10:31 PM Changeset in webkit [144724] by jsbell@chromium.org
  • 5 edits in trunk/LayoutTests

[V8] Add LayoutTests for SerializedScriptValue Int32/Uint32 cases
​https://bugs.webkit.org/show_bug.cgi?id=111364

Reviewed by Kentaro Hara.

A lack of layout tests for SerializedScriptValue special cases let
crbug.com/179280 slip in and out un-noticed. Rectify the situation.

  • platform/chromium/fast/storage/serialized-script-value-expected.txt:
  • platform/chromium/fast/storage/serialized-script-value.html:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
10:14 PM Changeset in webkit [144723] by commit-queue@webkit.org
  • 15 edits
    3 copies
    3 adds in trunk

WEBGL_compressed_texture_atc implementation
​https://bugs.webkit.org/show_bug.cgi?id=110496

Patch by Brandon Jones <​bajones@google.com> on 2013-03-04
Reviewed by Kenneth Russell.

Source/WebCore:

Test: webgl/conformance/extensions/webgl-compressed-texture-atc.html

Exposes the WEBGL_compressed_texture_atc extension, but is unverified since no desktop hardware supports
the format that I am aware of. Should enable mobile ports to expose the format, however.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLCompressedTextureATC.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebCore::WebGLCompressedTextureATC::WebGLCompressedTextureATC):
(WebCore::WebGLCompressedTextureATC::~WebGLCompressedTextureATC):
(WebCore::WebGLCompressedTextureATC::getName):
(WebCore::WebGLCompressedTextureATC::create):
(WebCore::WebGLCompressedTextureATC::supported):

  • html/canvas/WebGLCompressedTextureATC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebGLCompressedTextureATC):

  • html/canvas/WebGLCompressedTextureATC.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):

  • html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

  • platform/graphics/Extensions3D.h:

LayoutTests:

  • webgl/conformance/extensions/webgl-compressed-texture-atc-expected.txt: Added.
  • webgl/conformance/extensions/webgl-compressed-texture-atc.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-atc.html: Added.
10:12 PM Changeset in webkit [144722] by eustas@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Exceptions when WebInspector run in hosted mode.
​https://bugs.webkit.org/show_bug.cgi?id=111326

Reviewed by Pavel Feldman.

Source/WebCore:

There is bug in commands code generation in InspectorBackend.js
As a consequence all protocol enums have wrong names and cause
exception when refererenced.

Currently protocol enums are referenced only from NetworkManager.

Test: inspector/inspector-backend-commands-generation.html

  • inspector/front-end/InspectorBackend.js:

(InspectorBackendClass.prototype.loadFromJSONIfNeeded):
Use static method to generate code.
(InspectorBackendClass._generateCommands):
Extracted from loadFromJSONIfNeeded. Typo fixed.

LayoutTests:

Test runtime commands code generator output.

  • inspector/inspector-backend-commands-generation-expected.txt: Added.
  • inspector/inspector-backend-commands-generation.html: Added.
10:09 PM Changeset in webkit [144721] by Lucas Forschler
  • 1 copy in tags/Safari-536.29.1

New Tag.

10:04 PM Changeset in webkit [144720] by crogers@google.com
  • 12 edits in trunk/Source

Source/Platform: Add audio hardware support for multi-channel by implementing AudioDestinationNode.maxChannelCount
​https://bugs.webkit.org/show_bug.cgi?id=111385

Reviewed by James Robinson.

  • chromium/public/Platform.h:

(WebKit::Platform::audioHardwareOutputChannels):

Source/WebCore: Add audio hardware support for multi-channel output by implementing AudioDestinationNode.maxChannelCount
​https://bugs.webkit.org/show_bug.cgi?id=111385

Reviewed by James Robinson.

See specification details for .maxChannelCount:
​https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioDestinationNode

  • Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::maxChannelCount):

  • Modules/webaudio/AudioDestinationNode.idl:
  • Modules/webaudio/AudioNode.h:

Implement .maxChannelCount attribute.

(AudioNode):

  • Modules/webaudio/DefaultAudioDestinationNode.h:
  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::initialize):
(WebCore::DefaultAudioDestinationNode::createDestination):
(WebCore::DefaultAudioDestinationNode::enableInput):
Call to createDestination() now takes no argument.
Instead we maintain a member variable for the input device ID.
(WebCore::DefaultAudioDestinationNode::maxChannelCount):
(WebCore::DefaultAudioDestinationNode::setChannelCount):
Check port-specific hardware support for maxChannelCount(),
and allow setting the channel count based on what the hardware
supports.

  • platform/audio/AudioDestination.h:

(AudioDestination):

  • platform/audio/chromium/AudioDestinationChromium.cpp:

(WebCore::AudioDestination::maxChannelCount):
(WebCore::AudioDestinationChromium::render):
Call into chromium WebKit API: audioHardwareOutputChannels().

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestination::maxChannelCount):
Add basic implementation for maxChannelCount() only supporting stereo output.

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestination::maxChannelCount):
Add basic implementation for maxChannelCount() only supporting stereo output.
Later, the mac port can support more than this with some small improvements to AudioDestinationMac.

9:55 PM Changeset in webkit [144719] by eric@webkit.org
  • 2 edits in trunk/Tools

run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
​https://bugs.webkit.org/show_bug.cgi?id=111384

Reviewed by Ryosuke Niwa.

Sometimes I want to know why various LayoutTests are slow
without having to convert them into PerformanceTests in order
to use our fancy profiling. The Driver already knows how to
do the right thing, we just need to expose the options to the user.

Handling of these options is already unittested in the perftests_unittest.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

9:31 PM Changeset in webkit [144718] by eustas@chromium.org
  • 2 edits in branches/chromium/1410/Source/WebCore

Merge 144437

Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
​https://bugs.webkit.org/show_bug.cgi?id=111077

Reviewed by Pavel Feldman.

Analysis: DataGridNode.refresh removes all cells and then recreates them.
The issue is that mandatory "corner" cell is not recreated.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGridNode.prototype.refresh):
Added "corner" cell restoration code.

TBR=​eustas@chromium.org
Review URL: ​https://codereview.chromium.org/12414004

9:27 PM Changeset in webkit [144717] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

BUILD FIX (r144662): Import JSBase.h in WebFrameLoadDelegate.h
<​http://webkit.org/b/111269>

Fixes the following build failure:

In file included from Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m:11:
In file included from Source/WebKit/mac/WebView/WebFrameLoadDelegatePrivate.h:29:
Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:41:5: error: 'JSC_OBJC_API_ENABLED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if JSC_OBJC_API_ENABLED


Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:207:5: error: 'JSC_OBJC_API_ENABLED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if JSC_OBJC_API_ENABLED


2 errors generated.

  • WebView/WebFrameLoadDelegate.h: Include JSBase.h.
9:24 PM Changeset in webkit [144716] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Tools

check-webkit-style says "Have to enable auto props in the subversion config file"
​https://bugs.webkit.org/show_bug.cgi?id=107724

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-03-04
Reviewed by Tony Chang.

Added a standard svn config file for WebKit developers to use.
Updated the style and commit queue bot build scripts to load this file.

  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
  • EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
  • svn-config: Added.
9:23 PM Changeset in webkit [144715] by kinuko@chromium.org
  • 19 edits in trunk/LayoutTests

Rebaseline 4 virtual/softwarecompositing tests.

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
8:57 PM Changeset in webkit [144714] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

Background HTML parser can rewind the tokenizer after end-of-file
​https://bugs.webkit.org/show_bug.cgi?id=111365

Reviewed by Eric Seidel.

Source/WebCore:

Prior to this patch, it was possible to call didFailSpeculation after
processing the end-of-file token because checkForSpeculationFailure
didn't zero out m_tokenizer in some control paths.

This patch renames checkForSpeculationFailure to validateSpeculations
and ensures that it always takes ownership of the main thread's
HTMLTokenizer.

This patch also adds a number of ASSERTs to make sure the parser state
machine stays in the correct configuration (e.g., that we don't have a
main thread tokenizer while we're supposed to be tokenizing on the
background thread).

Test: fast/parser/document-write-fighting-eof.html

  • html/parser/BackgroundHTMLInputStream.cpp:

(WebCore::BackgroundHTMLInputStream::rewindTo):

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::append):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::validateSpeculations):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

LayoutTests:

  • fast/parser/document-write-fighting-eof.html: Added.
8:37 PM Changeset in webkit [144713] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Make sure that clearOwnerNode also clears StyleResolver references (via didMutate).
​https://bugs.webkit.org/show_bug.cgi?id=109446

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-03-04
Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/css/stylesheet.innerHTML-calls-didmutate.html

  • css/CSSStyleSheet.h:

LayoutTests:

  • fast/css/stylesheet.innerHTML-calls-didmutate-expected.txt: Added.
  • fast/css/stylesheet.innerHTML-calls-didmutate.html: Added.
7:49 PM Changeset in webkit [144712] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r185990. Requested by
jamesr_ via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-04

  • DEPS:
7:40 PM Changeset in webkit [144711] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewd build fix after r144701.

  • platform/EventTracer.cpp:

(WebCore::EventTracer::initialize):

7:23 PM Changeset in webkit [144710] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix some style issues in RenderLayerCompositor
​https://bugs.webkit.org/show_bug.cgi?id=111369

Patch by Min Qin <​qinmin@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.

Just style fix, no test needed

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

7:17 PM Changeset in webkit [144709] by tdanderson@chromium.org
  • 3 edits in trunk/Source/WebCore

Revert changes to RenderLayer::scrollByRecursively() that were added for gesture-scrolling
​https://bugs.webkit.org/show_bug.cgi?id=111007

Reviewed by Simon Fraser.

Due to ​http://trac.webkit.org/changeset/144519 landing, the changes made to RenderLayer in
​http://trac.webkit.org/changeset/142057,
​http://trac.webkit.org/changeset/140177, and
​http://trac.webkit.org/changeset/142195
are no longer necessary (as RenderLayer::scrollByRecursively() is not used for
gesture-scrolling) and should be reverted.

No change in behavior, so no new tests needed.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollByRecursively):

  • rendering/RenderLayer.h:
7:05 PM Changeset in webkit [144708] by akling@apple.com
  • 14 edits
    1 add in trunk/Source/JavaScriptCore

Unused Structure property tables waste 14MB on Membuster.
<​http://webkit.org/b/110854>
<rdar://problem/13292104>

Reviewed by Geoffrey Garen.

Turn PropertyTable into a GC object and have Structure drop unpinned tables when marking.
14 MB progression on Membuster3.

Added PropertyTable.cpp.

  • runtime/PropertyTable.cpp: Added.

(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::destroy):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::visitChildren):

Moved marking of property table values here from Structure::visitChildren().

  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::get):

Move m_cell to a local before using it multiple times. This avoids a multiple-access race when
Structure::checkOffsetConsistency() is used in assertions on the main thread while a marking thread
zaps the property table.

  • runtime/Structure.h:

(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):

  • runtime/StructureInlines.h:

(JSC::Structure::propertyTable):

Added a getter for the Structure's PropertyTable that ASSERTs GC currently isn't active.
Because GC can zap an unpinned property table at any time, it's not entirely safe to access it.
Renamed the variable itself to m_propertyTableUnsafe to force call sites into explaining themselves.

(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):

Moved these out of Structure.h to break header dependency cycle between Structure/PropertyTable.

  • runtime/Structure.cpp:

(JSC::Structure::visitChildren):

Null out m_propertyTable if the table is unpinned. This'll cause the table to get GC'd.

  • runtime/JSGlobalData.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

Add a global propertyTableStructure.

  • runtime/PropertyMapHashTable.h:

(PropertyTable):
(JSC::PropertyTable::createStructure):
(JSC::PropertyTable::copy):

Make PropertyTable a GC object.

  • runtime/Structure.cpp:

(JSC::Structure::dumpStatistics):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::checkConsistency):

6:48 PM Changeset in webkit [144707] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r144701.

  • platform/EventTracer.cpp:

(WebCore::EventTracer::initialize):

6:46 PM Changeset in webkit [144706] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION (r143643): Buttons containing floats render differently
​https://bugs.webkit.org/show_bug.cgi?id=110933

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-03-04
Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/forms/button-with-float.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
Also include new flexbox as a renderer that needs to enclose
overhanging floats. Flex boxes establish a block formatting context,
so they need to contain floats:
​http://dev.w3.org/csswg/css3-flexbox/#flex-items

LayoutTests:

  • css3/flexbox/float-inside-flexitem-expected.html: Added.
  • css3/flexbox/float-inside-flexitem.html: Added.
  • fast/forms/button-with-float-expected.html: Added.
  • fast/forms/button-with-float.html: Added.
6:34 PM Changeset in webkit [144705] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[chromium] Switch to new webkit_support::CreateLayerTreeView interface
​https://bugs.webkit.org/show_bug.cgi?id=111285

Patch by James Robinson <​jamesr@chromium.org> on 2013-03-04
Reviewed by Adrienne Walker.

This removes the need for WebCompositorSupport::initialize and exposes
slightly fewer entry points across the repository boundary.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::webCompositorThread):
(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::initializeLayerTreeView):

5:58 PM Changeset in webkit [144704] by eric@webkit.org
  • 1 edit
    2 adds in trunk/PerformanceTests

Add PerformanceTest for document startup via iframe append/remove
​https://bugs.webkit.org/show_bug.cgi?id=111389

Reviewed by Kentaro Hara.

We'd like pages with lots of iframes to be fast.
This test shows that at least for V8/Chromium we spend
all our time booting v8.

On my 32-core linux machine I see about 70 runs/sec in
Release and 5 runs/sec in Debug.

  • DOM/iframe-append-remove.html: Added.
5:54 PM Changeset in webkit [144703] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

Support WebSpeech - Speech Synthesis
​https://bugs.webkit.org/show_bug.cgi?id=106742

Build fix.

  • Modules/speech/SpeechSynthesis.cpp:
5:45 PM Changeset in webkit [144702] by rafaelw@chromium.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r144595.
​http://trac.webkit.org/changeset/144595
​https://bugs.webkit.org/show_bug.cgi?id=90341

Causing multiple crashes in fast/dom/Element/* tests (hits
assert in Attr.cp:215)

Source/WebCore:

  • dom/Element.cpp:

(WebCore::Element::setAttributeNode):

LayoutTests:

  • fast/dom/Element/setAttributeNode-case-insensitivity-expected.txt: Removed.
  • fast/dom/Element/setAttributeNode-case-insensitivity.html: Removed.
5:42 PM Changeset in webkit [144701] by haraken@chromium.org
  • 9 edits in trunk/Source

[chromium] Implement TRACE_EVENT macros for sampling profiling
​https://bugs.webkit.org/show_bug.cgi?id=110932

Reviewed by Adam Barth.

We are implementing TRACE_EVENT macros for sampling profiling.
It works in the following mechanism:

  • Chromium defines global state variables for sampling profiling.

(i.e. g_trace_state0, g_trace_state1, g_trace_state2 in trace_event.h)

  • WebKit gets the addresses of the global state variables at the

initialization step. (i.e. EventTracer::initialize())

  • WebKit updates the global states by using TRACE_EVENT_SAMPLING_STATE()

macros every time WebKit changes its state. (e.g. DOM attribute
getters/setters/methods)

  • A sampling thread running in Chrome reads the global states

periodically and visualizes the profiling results into about://tracing.

This patch implements (1) a WebKit API to get the addresses of
the global states and (2) the TRACE_EVENT_SAMPLING_STATE() macro.

Source/Platform:

  • chromium/public/Platform.h:

(Platform):
(WebKit::Platform::getTraceSamplingState):

Source/WebCore:

No tests. The sampling profiler is not enabled in Chrome by default.
I manually inserted TRACE_EVENT_SAMPLING_STATE() macros and
confirmed that the sampling profiling is working as expected.

  • platform/EventTracer.cpp:

(WebCore::EventTracer::initialize):
(WebCore::EventTracer::getTraceCategoryEnabledFlag):
(WebCore):

  • platform/EventTracer.h:

(WebCore):
(EventTracer):

  • platform/chromium/EventTracerChromium.cpp:

(WebCore):
(WebCore::EventTracer::initialize):

  • platform/chromium/TraceEvent.h:

Source/WebKit/chromium:

  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):

5:39 PM FeatureFlags edited by jer.noble@apple.com
(diff)
5:17 PM Changeset in webkit [144700] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations: touch-gesture-noscroll-body-* are failing on mac.
5:16 PM Changeset in webkit [144699] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Get rid of some AppleWin VS2010 build warnings.

  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
5:13 PM Changeset in webkit [144698] by Chris Fleizach
  • 11 edits in trunk

Support WebSpeech - Speech Synthesis
​https://bugs.webkit.org/show_bug.cgi?id=106742

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Enable speech synthesis for the Mac.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Enable speech synthesis for the Mac.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Enable speech synthesis for the Mac.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Enable speech synthesis for the Mac.

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

Unskip speech synthesis tests.

  • fast/dom/script-tests/constructed-objects-prototypes.js:

(constructorPropertiesOnWindow):

  • platform/mac/TestExpectations:
4:55 PM Changeset in webkit [144697] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS

Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]

NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];

~

1 error generated.

  • DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import

AccessibilityCommonMac.h.

4:42 PM Changeset in webkit [144696] by commit-queue@webkit.org
  • 20 edits
    3 adds in trunk

<link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc
​https://bugs.webkit.org/show_bug.cgi?id=109061

Patch by Ruslan Abdikeev <​aruslan@chromium.org> on 2013-03-04
Reviewed by Adam Barth.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Test: fast/dom/icon-url-list-apple-touch.html

Added iconTypes parameter to Document::iconURLs().
Added Document::shortcutIconURLs() with original semantics of iconURLs().
Fixed IconController.cpp to provide iconTypesMask to iconURLs().
Renamed iconTypes to iconTypesMask to make the meaning clearer.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::shortcutIconURLs):
(WebCore):
(WebCore::Document::iconURLs):

  • dom/Document.h:

(Document):

  • loader/icon/IconController.cpp:

(WebCore::IconController::iconURL):
(WebCore::IconController::urlsForTypes):

  • testing/Internals.cpp:

(WebCore::Internals::iconURLs):
(WebCore::Internals::shortcutIconURLs):
(WebCore):
(WebCore::Internals::allIconURLs):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Added test for apple-touch-icon in allIconURLs().
Changed iconURLs() to shortcutIconURLs().

  • fast/dom/icon-url-change.html:
  • fast/dom/icon-url-list-apple-touch-expected.txt: Added.
  • fast/dom/icon-url-list-apple-touch.html: Added.
  • fast/dom/icon-url-list.html:
  • fast/dom/icon-url-property.html:
4:31 PM Changeset in webkit [144695] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

UI process storage areas should hold on to storage maps
​https://bugs.webkit.org/show_bug.cgi?id=111374

Reviewed by Beth Dakin.

Pass the session storage quota size through to the storage area constructor and
create a StorageMap with the given quota size.

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::create):
(WebKit::StorageManager::StorageArea::StorageArea):
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::createSessionStorageNamespace):
(WebKit::StorageManager::createSessionStorageNamespaceInternal):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

4:22 PM Changeset in webkit [144694] by jpfau@apple.com
  • 3 edits
    3 adds in trunk

Cache partitioning does not affect iframe MainResources
​https://bugs.webkit.org/show_bug.cgi?id=111022

Reviewed by David Kilzer.

Source/WebCore:

Set the partition of a main resource request if in a subframe.

Test: http/tests/cache/partitioned-cache-iframe.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):

LayoutTests:

These tests results are for the case in which the cache is not
partitioned, as no shipping ports have cache partitioning enabled

  • http/tests/cache/partitioned-cache-iframe-expected.txt: Added.
  • http/tests/cache/partitioned-cache-iframe.html: Added.
  • http/tests/cache/resources/random-cached-iframe.cgi: Added.
3:51 PM Changeset in webkit [144693] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r144675.

Work around picky/old C++ compilers by separating the '>>' in
nested templates with a space.

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):

3:51 PM Changeset in webkit [144692] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations: Marking all html5lib/generated/ as crashing.
3:47 PM Changeset in webkit [144691] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

More work on UI side storage
​https://bugs.webkit.org/show_bug.cgi?id=111370

Reviewed by Andreas Kling.

Add a DispatchStorageEvent message and begin hooking it up.

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::setItem):
(WebKit):
(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::findStorageArea):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/Storage/StorageManager.messages.in:
  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::setItem):
(WebKit::StorageAreaProxy::dispatchStorageEvent):
(WebKit):

  • WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

  • WebProcess/Storage/StorageAreaProxy.messages.in:
3:45 PM Changeset in webkit [144690] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: user agent shadow roots for plugins should be 'accessible'
​https://bugs.webkit.org/show_bug.cgi?id=111339

Reviewed by Tim Horton.

If a plugin element uses a user agent shadow element, we should make that shadow element
into a button with the title and subtitle put together, and use that as the label. This
will probably be the best accessibility experience.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):

3:45 PM Changeset in webkit [144689] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

CSS3 calc: identify divide by zero cases at parse time
​https://bugs.webkit.org/show_bug.cgi?id=80411

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-03-04
Reviewed by Tony Chang.

Added tests to check whether divide by 0 cases are caught.

  • css3/calc/catch-divide-by-0-expected.txt: Added.
  • css3/calc/catch-divide-by-0.html: Added.
3:36 PM Changeset in webkit [144688] by alokp@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Form controls on composited layers are not painted properly
​https://bugs.webkit.org/show_bug.cgi?id=111366

Reviewed by James Robinson.

Set PlatformContextSkia::m_drawingToImageBuffer which is used as a hint to properly blend GDI-painted bitmap.

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

3:25 PM Changeset in webkit [144687] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Give ViewportConstraints classes copy constructors
​https://bugs.webkit.org/show_bug.cgi?id=111367

Reviewed by Beth Dakin.

Downstream code requires that ViewportConstraints objects have
copy constructors, so add them.

Also clean up some redundant initialization of stack objects
in RenderLayerCompositor.

No behavior change.

  • page/scrolling/ScrollingConstraints.h:

(WebCore::ViewportConstraints::ViewportConstraints):
(ViewportConstraints):
(WebCore::FixedPositionViewportConstraints::FixedPositionViewportConstraints):
(FixedPositionViewportConstraints):
(WebCore::StickyPositionViewportConstraints::StickyPositionViewportConstraints):
(StickyPositionViewportConstraints):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints):

3:23 PM Changeset in webkit [144686] by Lucas Forschler
  • 2 edits in tags/Safari-537.31.13/Source/WebKit2

Merge r144659. <rdar://problem/13326713>

3:21 PM Changeset in webkit [144685] by beidson@apple.com
  • 2 edits in branches/safari-534.59-branch/Source/WebKit2

Merge r144114

2013-02-26 Anders Carlsson <​andersca@apple.com>

Fix a copy/paste error in WebLoaderClient::didBlockInsecurePluginVersion
​https://bugs.webkit.org/show_bug.cgi?id=110914
<rdar://problem/13297581>

Reviewed by Beth Dakin.

Pass kWKErrorCodeInsecurePlugInVersion to the pluginDidFail callback.

  • UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
3:19 PM Changeset in webkit [144684] by beidson@apple.com
  • 2 edits in branches/safari-536.29-branch/Source/WebKit2

Merge 144114

2013-02-26 Anders Carlsson <​andersca@apple.com>

Fix a copy/paste error in WebLoaderClient::didBlockInsecurePluginVersion
​https://bugs.webkit.org/show_bug.cgi?id=110914
<rdar://problem/13297581>

Reviewed by Beth Dakin.

Pass kWKErrorCodeInsecurePlugInVersion to the pluginDidFail callback.

  • UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
3:12 PM Changeset in webkit [144683] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. AppleWin build fix.

  • html/parser/XSSAuditor.cpp:

(WebCore::isSemicolonSeparatedAttribute):

3:09 PM Changeset in webkit [144682] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CSSParser: Avoid temporary String when parsing hex colors.
<​http://webkit.org/b/111341>

Reviewed by Anders Carlsson.

Templatize CSSParser::fastParseColor() so we can pass a CSSParserString as the color name.
This avoids creating a temporary WTF::String from the parser string.

  • css/CSSParser.cpp:

(WebCore::CSSParser::fastParseColor):

  • css/CSSParser.h:
  • css/CSSParserValues.h:

(CSSParserString):

3:07 PM Changeset in webkit [144681] by jchaffraix@webkit.org
  • 13 edits
    1 copy
    1 add in trunk

[CSS Grid Layout] Add parsing for grid-{start|before}
​https://bugs.webkit.org/show_bug.cgi?id=110988

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-start-before-get-set.html

Refactored how we store internally grid-{row|column} to be based on grid-{before|start}.
This is required as grid-{row|column} are shorthands for resp. grid-{before|after} and grid-{start|end}
in the specification and will also be in the code. That means a lot of methods were renamed to be more
aligned with the new design.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Added the code to parse, apply and get back the new properties. Also
some renaming after the internal naming change below.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionForChild):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridItemData.cpp:

(WebCore::StyleGridItemData::StyleGridItemData):

  • rendering/style/StyleGridItemData.h:

(WebCore::StyleGridItemData::operator==):
Updated the naming now that we manipulate grid-{before|start} instead of grid-{row|column}.

LayoutTests:

  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:

Extended the test to make sure that both grid-column (resp. grid-row) and grid-start (resp. grid-before) are
in sync.

  • fast/css-grid-layout/grid-item-start-before-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-item-start-before-get-set.html: Added

Add this test for grid-{start|before}, similar to LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html.

2:44 PM Changeset in webkit [144680] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

Unreviewed build fix: wrap references to PluginInfoStore with
guards for platforms which do not enable NETSCAPE_PLUGIN_AP.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):

  • UIProcess/WebContext.h:
2:41 PM Changeset in webkit [144679] by Chris Fleizach
  • 8 edits
    2 adds in trunk

WebSpeech: change voiceURI to voice
​https://bugs.webkit.org/show_bug.cgi?id=110773

Reviewed by Tim Horton.

Source/WebCore:

Change the voiceURI property to a voice property that takes a SpeechSynthesisVoice.
This was recently added to the errata of the WebSpeech spec.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html

  • Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore):
(WebCore::SpeechSynthesisUtterance::voice):
(WebCore::SpeechSynthesisUtterance::setVoice):

  • Modules/speech/SpeechSynthesisUtterance.h:

(SpeechSynthesisUtterance):

  • Modules/speech/SpeechSynthesisUtterance.idl:
  • Modules/speech/SpeechSynthesisVoice.h:

(WebCore::SpeechSynthesisVoice::platformVoice):
(SpeechSynthesisVoice):

  • platform/PlatformSpeechSynthesisUtterance.cpp:

(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):

  • platform/PlatformSpeechSynthesisUtterance.h:

(WebCore::PlatformSpeechSynthesisUtterance::voice):
(WebCore::PlatformSpeechSynthesisUtterance::setVoice):
(PlatformSpeechSynthesisUtterance):

  • platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):

LayoutTests:

  • platform/mac/fast/speechsynthesis/speech-synthesis-utterance-uses-voice-expected.txt: Added.
  • platform/mac/fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html: Added.
2:29 PM Changeset in webkit [144678] by beidson@apple.com
  • 2 edits in branches/safari-536.29-branch/Source/WebKit2

Merge 144659

2013-03-04 Anders Carlsson <​andersca@apple.com>

Complete the plug-in URL string before sending it to the UI process
​https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>

Reviewed by Andreas Kling.

If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked):
2:28 PM Changeset in webkit [144677] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Filename passed to FormData.append() takes precedence over filename in
File.
​https://bugs.webkit.org/show_bug.cgi?id=111255

Patch by Victor Costan <​costan@gmail.com> on 2013-03-04
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/local/formdata/send-form-data-with-filename.html

  • platform/network/FormData.cpp:

(WebCore::FormData::appendKeyValuePairItems): changed to implement the
behavior in the XMLHttpRequest W3C spec.

LayoutTests:

(runTest):

  • http/tests/local/formdata/send-form-data-with-filename-expected.txt: Added.
  • http/tests/local/formdata/send-form-data-with-filename.html: Added.
  • http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt: Updated

to reflect the behavior specified in the XMLHttpRequest W3C spec.

  • platform/wk2/TestExpectations: newly added test doesn't work in

WebKit2 because beginDragWithFiles is not implemented

2:26 PM Changeset in webkit [144676] by beidson@apple.com
  • 2 edits in branches/safari-534.59-branch/Source/WebKit2

Merge r144659

2013-03-04 Anders Carlsson <​andersca@apple.com>

Complete the plug-in URL string before sending it to the UI process
​https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>

Reviewed by Andreas Kling.

If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked):
2:25 PM Changeset in webkit [144675] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Create and destroy storage areas in the UI process
​https://bugs.webkit.org/show_bug.cgi?id=111361

Reviewed by Sam Weinig.

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
Keep track of listener connection and storage area ID pairs.

(WebKit::StorageManager::StorageArea::~StorageArea):
Assert that we don't have any listeners left.

(WebKit::StorageManager::StorageArea::addListener):
Add the pair to the set of listeners.

(WebKit::StorageManager::StorageArea::removeListener):
Remove the pair from the set of listeners.

(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
Given an origin, look up or create the storage area.

(WebKit::StorageManager::createStorageArea):
Create the storage area if it doesn't already exist.

(WebKit::StorageManager::destroyStorageArea):
Look up the storage area and destroy it.

  • UIProcess/Storage/StorageManager.h:

Add a map of open storage areas.

2:16 PM Changeset in webkit [144674] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Canvas and DOM go out of sync
​https://bugs.webkit.org/show_bug.cgi?id=107701

Patch by Alexis Hetu <​sugoi@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/canvas/canvas-overflow-hidden-animation.html

Added an update of the current compositor from the layer's stacking
container when the layer itself isn't a stacking container.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterLayout):
Added an update of the stacking container of the owning layer of the
layer backing when the owning layer isn't a stacking container itself.

LayoutTests:

Added a new layout test for moving an object (a div) within a div that
has the "overflow:hidden" property.

  • fast/canvas/canvas-overflow-hidden-animation-expected.html: Added.
  • fast/canvas/canvas-overflow-hidden-animation.html: Added.
2:15 PM Changeset in webkit [144673] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium DEPS 185662 -> 185963

Roll roll roll the deps

Gently from downstream.

Merrily merrily merrily merrily

Green bots are but a dream.

  • DEPS:
2:08 PM Changeset in webkit [144672] by jer.noble@apple.com
  • 10 edits in trunk/Source/WebKit2

Add API to allow WK2 clients to query the list of installed plug-ins.
​https://bugs.webkit.org/show_bug.cgi?id=111245

Reviewed by Alexey Proskuryakov.

Add API in WKContext, implemented by WebContext, that allows callers to register a callback
retrieve an array containing installed plugin information. This API is exposed through WebContext
because it owns the PluginInfoStore used to fulfill the request.

Bump the WKContextClient API by 1:

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKContext.h:

Add a client protocol to PluginInfoStore to notify the client when plugIn information has been
successfully loaded:

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::PluginInfoStore): Initialize m_client to 0.
(WebKit::PluginInfoStore::loadPluginsIfNecessary): If the client is present, notify after loading the plugin store.

  • UIProcess/Plugins/PluginInfoStore.h:

(WebKit::PluginInfoStoreClient::~PluginInfoStoreClient): Default destructor.
(WebKit::PluginInfoStoreClient::PluginInfoStoreClient): Default constructor.
(WebKit::PluginInfoStore::setClient): Simple setter.
(WebKit::PluginInfoStore::client): Simple getter.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Set self as the client of PluginInfoStore.
(WebKit::WebContext::~WebContext): Clear the client of PluginInfoStore.
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins): Pass the callback to own client.

  • UIProcess/WebContext.h:
  • UIProcess/WebContextClient.cpp:

(WebKit::WebContextClient::plugInInformationBecameAvailable): Pass the callback to the registered WK callback, if present.

  • UIProcess/WebContextClient.h:
2:05 PM Changeset in webkit [144671] by ap@apple.com
  • 9 edits in trunk/Source/WebCore

Small BlobResourceHandle cleanup
​https://bugs.webkit.org/show_bug.cgi?id=111352

Reviewed by Sam Weinig.

  1. Don't use PassRefPtr<BlobStorageData> when ownership is not being passed.
  2. Added OVERRIDE to some functions.
  3. Added const to ResourceHandle::firstRequest().
  • platform/network/BlobRegistryImpl.cpp:

(WebCore::loadResourceSynchronously):
(WebCore::BlobRegistryImpl::createResourceHandle):
(WebCore::BlobRegistryImpl::getBlobDataFromURL):

  • platform/network/BlobRegistryImpl.h:

(BlobRegistryImpl):

  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::createAsync):
(WebCore::BlobResourceHandle::loadResourceSynchronously):

  • platform/network/BlobResourceHandle.h:

(BlobResourceHandle):

  • platform/network/FormData.cpp:

(WebCore::appendBlobResolved):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::firstRequest):

  • platform/network/ResourceHandle.h:

(ResourceHandle):

1:54 PM Changeset in webkit [144670] by timothy_horton@apple.com
  • 17 edits in trunk/Source/WebKit2

PDFPlugin: Hook up Services
​https://bugs.webkit.org/show_bug.cgi?id=111246
<rdar://problem/13062672>

Reviewed by Alexey Proskuryakov.

Make the Application->Services menu work when the focused selection is a PDFPlugin.

  • Shared/EditorState.cpp:

(WebKit::EditorState::encode):
(WebKit::EditorState::decode):

  • Shared/EditorState.h:

(WebKit::EditorState::EditorState):
(EditorState):
Add isInPlugin property to EditorState.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validRequestorForSendType:returnType:]):
If the selection is currently in a Plugin, we only currently have the ability
to retrieve the selection as a plain-text string, so restrict sendType to NSStringPboardType.

  • WebProcess/Plugins/PDF/SimplePDFPlugin.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add getStringSelection.

  • WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:

Add pdfLayerController:didChangeSelection: delegate method.

  • WebProcess/Plugins/PDF/PDFPlugin.h:

(PDFPlugin):
Add getStringSelection and notifySelectionChanged.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFLayerControllerDelegate pdfLayerController:didChangeSelection:]):
Forward selection change notifications to our PDFPlugin.

(WebKit::PDFPlugin::notifySelectionChanged):
Forward selection change notifications to our WebPage.

(WebKit::PDFPlugin::getStringSelection):
Retrieve PDFLayerController's selection as a plain text string.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::countFindMatches):
(WebKit::PluginView::findString):
Drive-bys, check for existance and initialization of the plugin before using it.

(WebKit::PluginView::getStringSelection): Added.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):
Use didChangeSelection instead of sending the EditorStateChanged message directly.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):
If a plugin is focused and has a selection, return a EditorState that reflects that.
Since PDFs aren't editable (when editing annotations, the plugin doesn't have focus),
I'm not adding support for the editing-related properties when a plugin has focus.

(WebKit::WebPage::focusedPluginViewForFrame):
(WebKit::WebPage::pluginViewForFrame):
Make these class methods instead of static functions so we can use them from
WebPageMac too, instead of duplicating code there.

(WebKit::WebPage::didChangeSelection): Added.

  • WebProcess/WebPage/WebPage.h:

Add didChangeSelection and [focused]PluginViewForFrame.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::getStringSelectionForPasteboard):
Defer to the focused plugin (if it exists) when retrieving the plain-text selection.

1:54 PM Changeset in webkit [144669] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Introduce WebInspector.EventTarget interface for interfaces that dispatch events.
​https://bugs.webkit.org/show_bug.cgi?id=111320

Reviewed by Pavel Feldman.

  • inspector/front-end/Object.js:

(WebInspector.EventTarget):
(WebInspector.EventTarget.prototype.addEventListener):
(WebInspector.EventTarget.prototype.removeEventListener):
(WebInspector.EventTarget.prototype.removeAllListeners):
(WebInspector.EventTarget.prototype.hasEventListeners):
(WebInspector.EventTarget.prototype.dispatchEventToListeners):

  • inspector/front-end/ResourceScriptMapping.js:
  • inspector/front-end/UISourceCode.js:
  • inspector/front-end/Workspace.js:

(WebInspector.ProjectDelegate.prototype.searchInFileContent):

1:47 PM Changeset in webkit [144668] by mhahnenberg@apple.com
  • 8 edits in trunk/Source

Remove contextInternalContext from JSContextInternal.h
​https://bugs.webkit.org/show_bug.cgi?id=111356

Reviewed by Geoffrey Garen.

We don't need it any more since we have globalContextRef in JSContext.

Source/JavaScriptCore:

  • API/JSContext.mm:
  • API/JSContextInternal.h:
  • API/JSValue.mm:

(+[JSValue valueWithBool:inContext:]):
(+[JSValue valueWithDouble:inContext:]):
(+[JSValue valueWithInt32:inContext:]):
(+[JSValue valueWithUInt32:inContext:]):
(+[JSValue valueWithNewObjectInContext:]):
(+[JSValue valueWithNewArrayInContext:]):
(+[JSValue valueWithNewRegularExpressionFromPattern:flags:inContext:]):
(+[JSValue valueWithNewErrorFromMessage:inContext:]):
(+[JSValue valueWithNullInContext:]):
(+[JSValue valueWithUndefinedInContext:]):
(-[JSValue toBool]):
(-[JSValue toDouble]):
(-[JSValue toNumber]):
(-[JSValue toString]):
(-[JSValue toDate]):
(-[JSValue toArray]):
(-[JSValue toDictionary]):
(-[JSValue valueForProperty:]):
(-[JSValue setValue:forProperty:]):
(-[JSValue deleteProperty:]):
(-[JSValue hasProperty:]):
(-[JSValue valueAtIndex:]):
(-[JSValue setValue:atIndex:]):
(-[JSValue isUndefined]):
(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):
(-[JSValue isObject]):
(-[JSValue isEqualToObject:]):
(-[JSValue isEqualWithTypeCoercionToObject:]):
(-[JSValue isInstanceOf:]):
(-[JSValue callWithArguments:]):
(-[JSValue constructWithArguments:]):
(-[JSValue invokeMethod:withArguments:]):
(valueToObject):
(objectToValueWithoutCopy):
(objectToValue):
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
(-[JSValue description]):

  • API/JSWrapperMap.mm:

(createObjectWithCustomBrand):
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSWrapperMap jsWrapperForObject:]):

  • API/ObjCCallbackFunction.mm:

(ObjCCallbackFunction::call):
(objCCallbackFunctionForInvocation):

Source/WebKit/mac:

  • WebView/WebScriptWorld.mm:

(+[WebScriptWorld scriptWorldForJavaScriptContext:]):

1:44 PM Changeset in webkit [144667] by tsepez@chromium.org
  • 3 edits
    2 adds in trunk

XSSAuditor bypass with --> comment syntax.
​https://bugs.webkit.org/show_bug.cgi?id=111349

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/open-iframe-src-03.html

  • html/parser/XSSAuditor.cpp:

(WebCore::isTerminatingCharacter):
Adds ">" to the list of terminating characters, so that comments of
the form --> end the snippet we seek to match.

LayoutTests:

  • http/tests/security/xssAuditor/open-iframe-src-03-expected.txt: Added.
  • http/tests/security/xssAuditor/open-iframe-src-03.html: Added.
1:42 PM Changeset in webkit [144666] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Modal dialogs sometimes lose focus.
​https://bugs.webkit.org/show_bug.cgi?id=111317

Reviewed by Pavel Feldman.

setCurrentFocusElement doesn't give focus to an element anymore
if modal glass pane is shown and element is not inside it.

  • inspector/front-end/Dialog.js:

(WebInspector.Dialog):
(WebInspector.Dialog.prototype._hide):

  • inspector/front-end/InspectorView.js:

(WebInspector.InspectorView.prototype.defaultFocusedElement):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.defaultFocusedElement):

  • inspector/front-end/UIUtils.js:

(WebInspector.GlassPane):
(WebInspector.GlassPane.prototype.dispose):
(WebInspector.setCurrentFocusElement):

  • inspector/front-end/dialog.css:
1:39 PM Changeset in webkit [144665] by junov@google.com
  • 1 edit
    3 copies in branches/chromium/1410

Merge 144196

REGRESSION (r134631) of border-radius percentage with border pixel
​https://bugs.webkit.org/show_bug.cgi?id=110889

Reviewed by Simon Fraser.

Source/WebCore:

Fixing background color filling to handle "non renderable" rounded
rectangles.

Test: fast/borders/border-radius-percent.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests:

Adding new pixel test to verify the correct rendering of
rounded rectangle backgrounds with inner border radii that
exceed the dimensions of the inner edge of the border.

  • fast/borders/border-radius-percent-expected.txt: Added.
  • fast/borders/border-radius-percent.html: Added.
  • platform/chromium-linux/fast/borders/border-radius-percent-expected.png: Added.
  • platform/chromium/TestExpectations:

TBR=​junov@google.com
Review URL: ​https://codereview.chromium.org/12390064

1:38 PM Changeset in webkit [144664] by mikhail.pozdnyakov@intel.com
  • 12 edits
    2 adds in trunk

[WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
​https://bugs.webkit.org/show_bug.cgi?id=109828

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Providing WKViewClient with Web Process crash and Web Process relaunch
callbacks brings better design as WebView should not be aware of
EFL-specific code handling the corresponding events.

The implementation of the mentioned Web Process callbacks was also added.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewSetThemePath):

  • UIProcess/API/C/efl/WKView.h:
  • UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::webProcessCrashed):
(WebKit):
(WebKit::ViewClientEfl::webProcessDidRelaunch):
(WebKit::ViewClientEfl::ViewClientEfl):

  • UIProcess/efl/ViewClientEfl.h:

(ViewClientEfl):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::setThemePath):

Accepts WTF::String instead of WKStringRef as it is
more appropriate for C++ API implementation class.

(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):

  • UIProcess/efl/WebView.h:

(WebView):

  • UIProcess/efl/WebViewClient.cpp:

(WebKit::WebViewClient::webProcessCrashed):
(WebKit):
(WebKit::WebViewClient::webProcessDidRelaunch):

  • UIProcess/efl/WebViewClient.h:

Tools:

Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
callbacks.

  • TestWebKitAPI/CMakeLists.txt:

Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
considered.

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::webProcessCrashed):
(TestWebKitAPI::webProcessDidRelaunch):
(TestWebKitAPI::setViewClient):
(TestWebKitAPI::TEST):

1:16 PM Changeset in webkit [144663] by roger_fong@apple.com
  • 5 edits in trunk/Source

Unreviewed. AppleWin build fix.

  • WebKit.vcxproj/FeatureDefines.props:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
  • WebCore.vcxproj/WebCore.vcxproj:
1:11 PM Changeset in webkit [144662] by Laszlo Gombos
  • 4 edits in trunk/Source

JSC_OBJC_API_ENABLED should be removed from FeatureDefines.h
​https://bugs.webkit.org/show_bug.cgi?id=111269

Reviewed by Mark Hahnenberg.

Source/WebKit/mac:

Include JavaScriptCore/JSBase.h for the definition of JSC_OBJC_API_ENABLED.

  • WebView/WebDelegateImplementationCaching.h:

Source/WTF:

JSC_OBJC_API_ENABLED flag was added to FeatureDefines.h (r143637)
so that it could be used in WebCore.exp.in to determine whether
or not we should be exporting certain symbols based on whether
the WebKit-related portion of the JSC ObjC API was enabled.

It turned out conditionally including certain symbols didn't
work when building fat binaries, so it's not even necessary any more.

  • wtf/FeatureDefines.h: Remove JSC_OBJC_API_ENABLED.
1:02 PM Changeset in webkit [144661] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[v8] add isolate parameter to heap statistics calls
​https://bugs.webkit.org/show_bug.cgi?id=111308

Patch by Dan Carney <​dcarney@google.com> on 2013-03-04
Reviewed by Jochen Eisinger.

No new tests.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::ScriptGCEvent::getHeapSize):
(WebCore::ScriptGCEvent::getUsedHeapSize):

  • bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

12:42 PM Changeset in webkit [144660] by jochen@chromium.org
  • 4 edits in trunk/Source

[chromium] remove deprecated hyphenation methods from Platform
​https://bugs.webkit.org/show_bug.cgi?id=111101

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/Platform.h:

(Platform):

Source/WebCore:

  • platform/text/chromium/Hyphenation.cpp:

(WebCore::canHyphenate):
(WebCore::lastHyphenLocation):

12:33 PM Changeset in webkit [144659] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Complete the plug-in URL string before sending it to the UI process
​https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>

Reviewed by Andreas Kling.

If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::unavailablePluginButtonClicked):

12:22 PM Changeset in webkit [144658] by beidson@apple.com
  • 5 edits in branches/safari-534.59-branch

<rdar://problem/13337144> - Update 536.29 branch Loader and UI client layouts

Rubberstamped by Anders Carlsson.

Source/WebKit2:

  • UIProcess/API/C/WKPage.h:

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

12:07 PM Changeset in webkit [144657] by Chris Fleizach
  • 4 edits
    3 adds in trunk/Tools

AX: Upstream iOS Accessibility DumpRenderTree changes
​https://bugs.webkit.org/show_bug.cgi?id=111220

Reviewed by David Kilzer.

Upstream the iOS changes for accessibility in DumpRenderTree.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(headerElementAtIndexCallback):
(linkedElementCallback):
(elementsForRangeCallback):
(increaseTextSelectionCallback):
(decreaseTextSelectionCallback):
(assistiveTechnologySimulatedFocusCallback):
(stringForSelectionCallback):
(getIPhoneLabelCallback):
(getIPhoneHintCallback):
(getIPhoneValueCallback):
(getIPhoneIdentifierCallback):
(getIPhoneTraitsCallback):
(getIPhoneIsElementCallback):
(getIPhoneElementTextPositionCallback):
(getIPhoneElementTextLengthCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/ios: Added.
  • DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.

(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
(AccessibilityController::elementAtPoint):
(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):
(findAccessibleObjectById):
(AccessibilityController::accessibleElementById):
(AccessibilityController::setLogFocusEvents):
(AccessibilityController::setLogScrollingStartEvents):
(AccessibilityController::setLogValueChangeEvents):
(AccessibilityController::setLogAccessibilityEvents):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(concatenateAttributeAndValue):
(AccessibilityUIElement::iphoneLabel):
(AccessibilityUIElement::iphoneHint):
(AccessibilityUIElement::iphoneValue):
(AccessibilityUIElement::iphoneIdentifier):
(AccessibilityUIElement::iphoneTraits):
(AccessibilityUIElement::iphoneIsElement):
(AccessibilityUIElement::iphoneElementTextPosition):
(AccessibilityUIElement::iphoneElementTextLength):
(AccessibilityUIElement::url):
(AccessibilityUIElement::x):
(AccessibilityUIElement::y):
(AccessibilityUIElement::width):
(AccessibilityUIElement::height):
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):
(AccessibilityUIElement::getChildren):
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::childrenCount):
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::headerElementAtIndex):
(AccessibilityUIElement::linkedElement):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::increaseTextSelection):
(AccessibilityUIElement::decreaseTextSelection):
(AccessibilityUIElement::stringForSelection):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
(AccessibilityUIElement::elementsForRange):
(AccessibilityUIElement::getLinkedUIElements):
(AccessibilityUIElement::getDocumentLinks):
(AccessibilityUIElement::attributesOfLinkedUIElements):
(AccessibilityUIElement::attributesOfDocumentLinks):
(AccessibilityUIElement::attributesOfChildren):
(AccessibilityUIElement::allAttributes):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::isPressActionSupported):
(AccessibilityUIElement::isIncrementActionSupported):
(AccessibilityUIElement::isDecrementActionSupported):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::isAttributeSettable):
(AccessibilityUIElement::isAttributeSupported):
(AccessibilityUIElement::parameterizedAttributeNames):
(AccessibilityUIElement::role):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):
(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::insertionPointLineNumber):
(AccessibilityUIElement::isEnabled):
(AccessibilityUIElement::isRequired):
(AccessibilityUIElement::isFocused):
(AccessibilityUIElement::isSelected):
(AccessibilityUIElement::isExpanded):
(AccessibilityUIElement::isChecked):
(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::lineForIndex):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::indexInTable):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::assistiveTechnologySimulatedFocus):
(AccessibilityUIElement::setSelectedTextRange):
(AccessibilityUIElement::increment):
(AccessibilityUIElement::decrement):
(AccessibilityUIElement::showMenu):
(AccessibilityUIElement::press):
(AccessibilityUIElement::accessibilityValue):
(AccessibilityUIElement::documentEncoding):
(AccessibilityUIElement::documentURI):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::removeNotificationListener):
(AccessibilityUIElement::isFocusable):
(AccessibilityUIElement::isSelectable):
(AccessibilityUIElement::isMultiSelectable):
(AccessibilityUIElement::isSelectedOptionActive):
(AccessibilityUIElement::isVisible):
(AccessibilityUIElement::isOffScreen):
(AccessibilityUIElement::isCollapsed):
(AccessibilityUIElement::isIgnored):
(AccessibilityUIElement::hasPopup):
(AccessibilityUIElement::takeFocus):
(AccessibilityUIElement::takeSelection):
(AccessibilityUIElement::addSelection):
(AccessibilityUIElement::removeSelection):
(AccessibilityUIElement::uiElementForSearchPredicate):
(AccessibilityUIElement::numberAttributeValue):

12:06 PM Changeset in webkit [144656] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Use initialization from literal for MediaFeatureNames
​https://bugs.webkit.org/show_bug.cgi?id=111283

Reviewed by Andreas Kling.

  • css/MediaFeatureNames.cpp:

(WebCore::MediaFeatureNames::init):
Initialization from literal is faster and use less memory. The names are
defined statically in MediaFeatureNames.h.

Also use the NotNull placement new to avoid a branch on silly allocators.

11:45 AM Changeset in webkit [144655] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

(tests) flexbox/resources.css should use unprefixed properties, for firefox
​https://bugs.webkit.org/show_bug.cgi?id=111010

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-03-04
Reviewed by Tony Chang.

Search & replace to remove -moz- prefixes, as per
​https://developer.mozilla.org/en-US/docs/CSS/Using_CSS_flexible_boxes:
"Gecko implementation is unprefixed (and is no longer behind a
preference as of Firefox 20)"

  • css3/flexbox/resources/flexbox.css:

(.flexbox):
(.inline-flexbox):
(.flex-none):
(.flex-auto):
(.flex-one):
(.row):
(.row-reverse):
(.column):
(.column-reverse):
(.wrap):
(.wrap-reverse):
(.align-content-flex-start):
(.align-content-flex-end):
(.align-content-center):
(.align-content-space-between):
(.align-content-space-around):
(.align-content-stretch):
(.align-items-flex-start):
(.align-items-flex-end):
(.align-items-center):
(.align-items-baseline):
(.align-items-stretch):
(.align-self-auto):
(.align-self-flex-start):
(.align-self-flex-end):
(.align-self-center):
(.align-self-baseline):
(.align-self-stretch):
(.justify-content-flex-start):
(.justify-content-flex-end):
(.justify-content-center):
(.justify-content-space-between):
(.justify-content-space-around):

11:44 AM Changeset in webkit [144654] by skyostil@chromium.org
  • 2 edits in trunk/Source/Platform

[chromium] Add ability to wait on async upload completion
​https://bugs.webkit.org/show_bug.cgi?id=110987

Reviewed by James Robinson.

Add a graphics context entry point for waiting on asynchronous upload
completion. The wait is performed server-side so the call is
non-blocking.

See ​https://codereview.chromium.org/12210129/

  • chromium/public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::waitAsyncTexImage2DCHROMIUM):

11:42 AM Changeset in webkit [144653] by beidson@apple.com
  • 7 edits in branches/safari-536.29-branch

<rdar://problem/13337144> - Update 536.29 branch Loader and UI client layouts

Reviewed by Anders Carlsson.

Source/WebKit2:

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKPage.h:

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

11:32 AM Changeset in webkit [144652] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

[GTK] Some WebKit2 GTK+ unit tests are failing in 32 bits bot
​https://bugs.webkit.org/show_bug.cgi?id=111346

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-03-04
Reviewed by Martin Robinson.

The problem is the use of a temporary CString object in the macro
g_assert_cmpstr. It's a common mistake because we usually forget
that g_assert_cmpstr is not a function but a macro, that expands
to multiple lines. This patch adds a new macro ASSERT_CMP_CSTRING
with the same implementation that g_assert_cmpstr, but using
CStrings instead of const char*. It fixes all the cases where a
temporary CString was used in g_assert_cmpstr, and uses the new
macro also for the cases where we were caching the CString just
for g_assert_cmpstr.

  • UIProcess/API/gtk/tests/TestDownloads.cpp:

(testDownloadRemoteFile):

  • UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(testInspectorServerPageList):

  • UIProcess/API/gtk/tests/TestLoaderClient.cpp:
  • UIProcess/API/gtk/tests/TestMain.h:
  • UIProcess/API/gtk/tests/TestResources.cpp:
  • UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:

(testGetFaviconURI):

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(assertThatUserAgentIsSentInHeaders):
(testWebKitSettingsUserAgent):

11:30 AM Changeset in webkit [144651] by jsbell@chromium.org
  • 29 edits in trunk/Source/WebCore

[V8] Unreviewed. Rebaselined run-bindings-tests following r144617

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::TestActiveDOMObjectV8Internal::TestActiveDOMObjectDomainSafeFunctionSetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructorConstructor):
(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):

  • bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

11:20 AM Changeset in webkit [144650] by Lucas Forschler
  • 2 edits in tags/Safari-537.31.13/Source/WebCore

Merged r144577. <rdar://problem/13328176>

11:04 AM Changeset in webkit [144649] by tony@chromium.org
  • 4 edits
    1 delete in trunk/Source

Unreviewed, rolling out r144562.
​http://trac.webkit.org/changeset/144562
​https://bugs.webkit.org/show_bug.cgi?id=85642

Caused KeyPadInsert faluires in webkit_unittests

Source/WebCore:

  • platform/chromium/KeyCodeConversionGtk.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/KeyCodeConversionTestGtk.cpp: Removed.
11:01 AM Changeset in webkit [144648] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.13/Source

Versioning.

10:59 AM Changeset in webkit [144647] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getComputedStyle not implemented for -webkit-columns shorthand
​https://bugs.webkit.org/show_bug.cgi?id=111236

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-03-04
Reviewed by Alexis Menard.

Source/WebCore:

Implement getComputedStyle for -webkit-columns shorthand.

Test: fast/css/getComputedStyle/getComputedStyle-webkit-columns-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to check getComputedStyle for -webkit-columns.

  • fast/css/getComputedStyle/getComputedStyle-webkit-columns-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-webkit-columns-shorthand.html: Added.
10:56 AM Changeset in webkit [144646] by leviw@chromium.org
  • 5 edits in trunk/Source

Add support for 8 bit TextRuns on Chromium Linux & Mac
​https://bugs.webkit.org/show_bug.cgi?id=99393

Reviewed by Eric Seidel.

Source/WebCore:

Adding support for 8 bit TextRuns for Mac and Linux Chromium. To accomplish this,
8 bit text runs are upconverted to 16 bit in the complex text path during string
normalization, as HarfBuzz operates on UChars.

Windows has platfom assumptions that TextRuns are 16 bit that need to be addressed
before enabling this optimization.

No new tests. No change in behavior.

(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::normalizeCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):

Source/WebKit/chromium:

Enabling 8 bit text runs for Linux and Mac platforms.

  • features.gypi:
10:50 AM Changeset in webkit [144645] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.13

New Tag.

10:49 AM Changeset in webkit [144644] by alexis@webkit.org
  • 5 edits in trunk

transition-property property and transition shorthand property doesn't accept "all, all".
​https://bugs.webkit.org/show_bug.cgi?id=111201

Reviewed by Simon Fraser.

Source/WebCore:

Relax the parsing of transition-property to allow all, all as a value.
It is not very useful per say but it is possible by the spec and we
align with Firefox, IE and Opera.

Test: LayoutTests/transitions/transitions-parsing.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationProperty):

LayoutTests:

Updated the tests to cover the bug.

  • transitions/transitions-parsing-expected.txt:
  • transitions/transitions-parsing.html:
10:34 AM Changeset in webkit [144643] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Add a new dependency on jsr-305 for Android
​https://bugs.webkit.org/show_bug.cgi?id=111340

Unreviewed build fix; new Android dependency. This is
currently breaking gyp generation on the Android bots.

  • DEPS:
10:23 AM Changeset in webkit [144642] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true
​https://bugs.webkit.org/show_bug.cgi?id=111229

Patch by Min Qin <​qinmin@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.

If applyPageScaleFactorInCompositor is set to true, webcore should use css coordinates.
As a result, we shouldn't apply page scale to clipRect in RenderLayerCompositor.
Layout tests set the flag to false, so we don't have anything to test against.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

9:46 AM Changeset in webkit [144641] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add simple vector traits for JSC::Identifier.
<​http://webkit.org/b/111323>

Reviewed by Geoffrey Garen.

Identifiers are really just Strings, giving them simple vector traits makes
Vector move them with memcpy() instead of churning the refcounts.

  • runtime/Identifier.h:

(WTF):

9:41 AM Changeset in webkit [144640] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Upstream selection start animation.
​https://bugs.webkit.org/show_bug.cgi?id=111335

Patch by Iris Wu <​shuwu@rim.com> on 2013-03-04
Reviewed by Rob Buis.

PR 219960

To indicate selection starts, we draw an overlay rect larger than
the selected word at the start of selection. Then shrink it down
to the actual size.

Reviewed Internally by Genevieve Mak and Andrew Lo and Mike Fenton.

  • Api/WebAnimation.cpp:

(BlackBerry::WebKit::WebAnimation::shrinkAnimation):
(WebKit):

  • Api/WebAnimation.h:
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::selectionHighlight):
(WebKit):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebTapHighlight.h:
  • WebKitSupport/DefaultTapHighlight.cpp:

(WebKit):
(BlackBerry::WebKit::shrinkAnimationName):
(BlackBerry::WebKit::DefaultTapHighlight::draw):

  • WebKitSupport/DefaultTapHighlight.h:

(DefaultTapHighlight):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::textGranularityFromSelectionExpansionType):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::selectNodeIfFatFingersResultIsLink):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):

  • WebKitSupport/SelectionHandler.h:

(SelectionHandler):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

9:29 AM Changeset in webkit [144639] by vollick@chromium.org
  • 8 edits in trunk

ASSERTION FAILED: m_clipRectsCache->m_respectingOverflowClip[clipRectsType] == (clipRectsContext.respectOverflowClip == RespectOverflowClip) in RenderLayer.
​https://bugs.webkit.org/show_bug.cgi?id=108257

Reviewed by David Hyatt.

Source/WebCore:

With composited scrolling we paint both with and without respecting
overflow clip. To prevent collisions in the clip cache, and to prevent
throwing away cached clips unnecessarily, we keep two copies of the
clip cache -- one for when overflow clip is respected, and one for
when it isn't.

No new tests. Covered by existing tests (in debug):

compositing/overflow/automatically-opt-into-composited-scrolling.html
compositing/overflow/composited-scrolling-creates-a-stacking-container.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateClipRects):

No longer asserts that our 'respect overflow clip' status is
consistent. It also gets and sets the clip cache using the clip rect
context rather than just the clip rect type.

(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::clearClipRects):
(WebCore::ClipRectsCache::ClipRectsCache):
(WebCore::ClipRectsCache::getClipRects):
(WebCore::ClipRectsCache::setClipRects):
(WebCore::ClipRectsCache::getIndex):

Get and set the cached clip rects using the context rather than
type.

(WebCore::RenderLayer::clipRects):

We now cache twice as many clip rects.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

ShouldRespectOverflowClip was moved out of RenderLayer.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::clearClipRects):

  • rendering/RenderLayer.h:

(WebCore::ClipRectsCache::ClipRectsCache):
(WebCore::ClipRectsCache::getClipRects):
(WebCore::ClipRectsCache::setClipRects):
(ClipRectsCache):
(WebCore::ClipRectsCache::getIndex):
(WebCore::RenderLayer::clipRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

  • platform/efl-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
9:24 AM Changeset in webkit [144638] by acolwell@chromium.org
  • 7 edits in trunk/Source

Remove unused return value from SourceBufferPrivate::abort() and WebSourceBuffer::abort().
​https://bugs.webkit.org/show_bug.cgi?id=111195

Reviewed by Adam Barth.

Source/WebCore:

No new tests. No user visible behavior changed.

  • platform/graphics/SourceBufferPrivate.h:

(SourceBufferPrivate):

Source/WebKit/chromium:

  • public/WebSourceBuffer.h:

(WebSourceBuffer):

  • src/SourceBufferPrivateImpl.cpp:

(WebKit::SourceBufferPrivateImpl::abort):

  • src/SourceBufferPrivateImpl.h:

(SourceBufferPrivateImpl):

  • src/WebMediaPlayerClientImpl.cpp:

(WebSourceBufferImpl):
(WebKit::WebSourceBufferImpl::abort):

9:16 AM Changeset in webkit [144637] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

[New Multicolumn] Eliminate the unique multicolumn flow thread style creation function
​https://bugs.webkit.org/show_bug.cgi?id=111338

Reviewed by Allan Jensen.

There is nothing special about a multi-column flow thread style now, so we can just
use the existing anonymous style creation function.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore):
(WebCore::RenderMultiColumnBlock::addChild):

9:06 AM Changeset in webkit [144636] by mario@webkit.org
  • 9 edits in trunk/Source/WebCore

[GTK] WebCore::returnString is unsafe and should be removed!
​https://bugs.webkit.org/show_bug.cgi?id=110423

Reviewed by Martin Robinson.

Remove returnString() and replace it in callers with a new
function that will cache and return the values of string
properties for ATK interfaces in the private section of the
wrapper AtkObject WebKitAccessible.

  • accessibility/atk/WebKitAccessibleUtil.cpp: Remove returnString().
  • accessibility/atk/WebKitAccessibleUtil.h: Ditto.
  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(_WebKitAccessiblePrivate): New private structure to store cached
values of string property for the different ATK interfaces.
(cacheAndReturnAtkProperty): New helper function to make sure the
returned const gchar* value is previously cached in the private
section of the wrapper AtkObject.
(webkitAccessibleGetName): Use the new helper function.
(webkitAccessibleGetDescription): Ditto.
(webkitAccessibleInit): Initialize pointer to private structure.
(webkitAccessibleFinalize): Remove unneeded code.
(webkitAccessibleClassInit): Add private struct to class type/

  • accessibility/atk/WebKitAccessibleWrapperAtk.h:

(_WebKitAccessible): New member pointing to the private structure,
made the new helper function cacheAndReturnAtkProperty() available
to external callers (implementation files for ATK interfaces).
(AtkCachedProperty): New enum to allow reusing code when calling
cacheAndReturnAtkProperty() to cache and return different properties.

  • accessibility/atk/WebKitAccessibleInterfaceAction.cpp:

(webkitAccessibleActionGetKeybinding): Replace calls to returnString()
with calls to the new helper function cacheAndReturnAtkProperty().
(webkitAccessibleActionGetName): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:

(documentAttributeValue): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceImage.cpp:

(webkitAccessibleImageGetImageDescription): Ditto.

Remove returnString() from WebKitAccessibleHyperlink (which is not
an AtkObject, but a GObject) as well, replacing it in callers with
simple code that will cache and return the required values in the
private section of these kind of objects.

  • accessibility/atk/WebKitAccessibleHyperlink.cpp:

(_WebKitAccessibleHyperlinkPrivate): Added two new fields to cache
string values for the key binding and name properties from the
AtkAction interface, which is implemented by AtkHyperlink.
(webkitAccessibleHyperlinkActionGetKeybinding): Cache the string
value for the key binding before returning a const gchar* pointer.
(webkitAccessibleHyperlinkActionGetName): Ditto.
(webkitAccessibleHyperlinkGetURI): Do not cache the URI here, as
this function returns a gchar* that will be owned by the caller.

9:04 AM Changeset in webkit [144635] by jochen@chromium.org
  • 7 edits in trunk/Tools

[chromium] pass all focus handling methods through the WebTestDelegate
​https://bugs.webkit.org/show_bug.cgi?id=111328

Reviewed by Nico Weber.

In content_shell, the focus handling is asynchronous. To allow for
switching the focus synchronously between WebViews, we need to intercept
didFocus and didBlur and forward it to the WebTestDelegate.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):
(WebTestRunner::WebTestDelegate::setFocus):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner::WebTestProxy::didFocus):
(WebTestRunner::WebTestProxy::didBlur):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::setWindowIsKey):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::didFocus):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::didBlur):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didFocus):
(WebViewHost::didBlur):
(WebViewHost::setFocus):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

8:50 AM Changeset in webkit [144634] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Curl] Compile fix after r144216
​https://bugs.webkit.org/show_bug.cgi?id=111305

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-03-04
Reviewed by Brent Fulgham.

  • platform/network/curl/ResourceRequest.h:

(WebCore::ResourceRequest::cfURLRequest): Added new parameter.

8:43 AM Changeset in webkit [144633] by hyatt@apple.com
  • 5 edits
    2 adds in trunk

[New Multicolumn] Make sure region styling works for columns inside regions.
​https://bugs.webkit.org/show_bug.cgi?id=111276

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/regions/region-styling-in-columns.html

  • rendering/RenderFlowThread.cpp:

(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):

  • rendering/RenderFlowThread.h:

(CurrentRenderFlowThreadMaintainer):
Fix the CurrentRenderFlowThreadMaintainer so that it saves off the old render flow thread
and restores it when done. This effectively makes flow thread layout a push/pop stack,
since with in-flow threads, this is allowed. We assert that a nested flow thread is
in-flow to preserve the invariant that you can't nest CSS Regions flow thread.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::computeChildrenStyleInRegion):
Add isInFlowRenderFlowThread() to the anonymous check to make sure a style gets made
for the nested flow thread.

LayoutTests:

  • fast/regions/region-style-in-columns-expected.html: Added.
  • fast/regions/region-style-in-columns.html: Added.
8:36 AM Changeset in webkit [144632] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: WebInspector.AceTextEditor throws a warning
​https://bugs.webkit.org/show_bug.cgi?id=111315

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-04
Reviewed by Pavel Feldman.

Add WebInspector.AceTextEditor to externs.js to suppress closure
compilation warning.

No new tests: no change in behaviour.

  • inspector/front-end/externs.js:

(WebInspector.AceTextEditor):

8:22 AM Changeset in webkit [144631] by Antoine Quint
  • 4 edits in trunk/Source/WebCore

Fix debug build under certain configurations, cause was
​http://trac.webkit.org/changeset/144624.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):

  • inspector/InspectorLayerTreeAgent.h:

(WebCore):
(WebCore::InspectorLayerTreeAgent::create):
(InspectorLayerTreeAgent):

8:22 AM Changeset in webkit [144630] by akling@apple.com
  • 2 edits in trunk/Source/WTF

Deque: Free internal buffer in clear().
<​http://webkit.org/b/111316>
<rdar://problem/13336675>

Reviewed by Antti Koivisto.

525 kB progression on Membuster3.

  • wtf/Deque.h:

(WTF::::clear):

8:21 AM Changeset in webkit [144629] by kadam@inf.u-szeged.hu
  • 37 edits
    4 copies
    76 adds in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Updated platform specific expected files and png results.

  • platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
  • platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.png: Added.
  • platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.txt: Added.
  • platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.png:
  • platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.txt: Added.
  • platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png:
  • platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/reflection-repaint-test-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/reflection-repaint-test-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/region-painting-invalidation-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/region-painting-invalidation-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/region-painting-via-layout-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/region-painting-via-layout-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png: Added.
  • platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/position-after-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/position-after-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/custom/visibility-override-filter-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png.
  • platform/qt-5.0-wk2/svg/custom/visibility-override-filter-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/big-sized-filter-2-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/big-sized-filter-2-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/filterRes1-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png.
  • platform/qt-5.0-wk2/svg/filters/filterRes1-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/filterRes3-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png.
  • platform/qt-5.0-wk2/svg/filters/filterRes3-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/parent-children-with-same-filter-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png.
  • platform/qt-5.0-wk2/svg/filters/parent-children-with-same-filter-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/shadow-on-filter-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/shadow-on-filter-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt: Added.
8:04 AM Changeset in webkit [144628] by Claudio Saavedra
  • 2 edits in trunk/Tools

[GTK] No need to manually add system paths to jhbuildrc
​https://bugs.webkit.org/show_bug.cgi?id=110850

Reviewed by Gustavo Noronha Silva.

  • gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild

already takes care of.

7:53 AM Changeset in webkit [144627] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r141240) Crash in PluginPackage::fetchInfo
​https://bugs.webkit.org/show_bug.cgi?id=111322

Reviewed by Simon Hausmann.

Do not try to load blacklisted plugins.

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::fetchInfo):

7:09 AM Changeset in webkit [144626] by alexis@webkit.org
  • 15 edits in trunk

transition properties can't be found in CSSStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=110011

Reviewed by Antti Koivisto.

Source/WebCore:

The previous approach for handling the unprefixing was to alias the
unprefixed properties with the prefixed ones in CSSPropertyNames.in.
Unfortunately it will alias the properties in the parsing code which will just
identically parse the two versions. This means that when we populate StylePropertySet
we do not have information whether we just parsed the prefixed, the
unprefixed properties or we parsed both. The patch takes another
approach by creating two distinct sets of properties (unprefixed and
prefixed). Each properties have their own id and we now handle them in
the parsing code as disctints properties and add both versions to the
declared style. In order to avoid properties getting out of sync,
this patch adds few facilities to StylePropertySet to update the
prefixed and the unprefixed entries. Finally the style resolution
happens only for the prefixed version (to limit the size of this patch)
and the unprefixed versions are not resolved. This is to avoid creating
the animation objects twice for the resolved style.

Test : transitions/transitions-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::addPropertyWithPrefixingVariant): Always add the
prefixed and the unprefixed property even if only one is specified.
(WebCore):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransitionShorthand): Add both prefixed and
unprefixed longhands to the declarated style.
(WebCore::CSSParser::parseAnimationProperty):

  • css/CSSParser.h:

(CSSParser):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSProperty.h:

(WebCore:: prefixingVariantForPropertyId): This function takes a given
property id and returns its prefixed or unprefixed id if it exists. If
not it returns the same id.
(WebCore):

  • css/CSSPropertyNames.in:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::removeProperty): Remove
also the prefixed or unprefixed shorthand if it exists.
(WebCore):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet:: appendPrefixingVariantProperty):
(WebCore::StylePropertySet::setPrefixingVariantProperty): If it
exists a unprefixed or prefixed counterpart of the property we're
trying to set, then we update the other one.
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::mergeAndOverrideOnConflict):

  • css/StylePropertySet.h:

(StylePropertySet):

  • css/StylePropertyShorthand.cpp:

(WebCore::transitionShorthand):
(WebCore):
(WebCore::shorthandForProperty): Define the transitions unprefixed
longhands.

  • css/StylePropertyShorthand.h:

(WebCore):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty): StyleBuilder will handle the
resolution and the creation of the animations for the style. As the
declarated style now contains declarations for the prefixed and
unprefixed property we do not want to resolve two times and create duplicate animations.
Therefore when we try to resolve the unprefixed version we just bail out.

LayoutTests:

Updated layout test to cover the bug.

  • transitions/transitions-parsing-expected.txt:
  • transitions/transitions-parsing.html:
7:07 AM Changeset in webkit [144625] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: CPU Flame Chart: reveal profiler DataGrid node when user clicks on a FlameChart item.
​https://bugs.webkit.org/show_bug.cgi?id=111309

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileView.prototype._revealProfilerNode):

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onClick):

6:07 AM Changeset in webkit [144624] by Antoine Quint
  • 7 edits
    4 deletes in trunk

Web Inspector: remove existing LayerTreeAgent protocol APIs
​https://bugs.webkit.org/show_bug.cgi?id=111251

Source/WebCore:

In order to eventually provide a more useful API for the LayerTreeAgent
that will be done in followup bugs, we remove the current API exposed by
the agent providing a clean slate that will make future patches easier
to read. Additionally, we remove the "childLayers" property on the Layer
object since we will no longer be providing a hierarchy of layers, but
rather a flat list of layers attached to a node and its descendants.

No new tests since we're removing the APIs exposed by the LayerTreeAgent.
Subsequent patches will add tests as new APIs are added.

Reviewed by Timothy Hatcher.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):

  • inspector/InspectorLayerTreeAgent.h:

(InspectorLayerTreeAgent):

LayoutTests:

Remove existing tests since they're testing API that we're
removing.

Reviewed by Timothy Hatcher.

  • inspector-protocol/layer-tree-expected.txt: Removed.
  • inspector-protocol/layer-tree-generated-content-expected.txt: Removed.
  • inspector-protocol/layer-tree-generated-content.html: Removed.
  • inspector-protocol/layer-tree.html: Removed.
5:54 AM Changeset in webkit [144623] by li.yin@intel.com
  • 5 edits in trunk

MediaStream.ended must return true when it is created with ended tracks.
​https://bugs.webkit.org/show_bug.cgi?id=111293

Reviewed by Kentaro Hara.

Source/WebCore:

Spec: ​http://dev.w3.org/2011/webrtc/editor/getusermedia.html#MediaStream-ended
When a MediaStream object is created, its ended attribute must be set to false,
unless it is being created using the MediaStream() constructor whose arguments
are lists of MediaStreamTrack objects that are all ended, in which case the
MediaStream object must be created with its ended attribute set to true.

Test: fast/mediastream/MediaStreamConstructor.html

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

LayoutTests:

  • fast/mediastream/MediaStreamConstructor-expected.txt:
  • fast/mediastream/MediaStreamConstructor.html:
5:34 AM Changeset in webkit [144622] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Adding new rules broken if a <style> tag is added to document dynamically
​https://bugs.webkit.org/show_bug.cgi?id=111299

Reviewed by Pavel Feldman.

Source/WebCore:

The CSSStyleSheet instance should be retrieved directly from the HTMLStyleElement just created,
not from the document.styleSheets list.

Test: inspector/styles/add-new-rule-with-style-after-body.html

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

LayoutTests:

  • inspector/styles/add-new-rule-with-style-after-body-expected.txt: Added.
  • inspector/styles/add-new-rule-with-style-after-body.html: Added.
5:15 AM Changeset in webkit [144621] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Unreviewed. Fix for closure type annotations.

  • inspector/front-end/FlameChart.js:
5:07 AM Changeset in webkit [144620] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[EFL] Build fix when compiling with GLES2 support enabled.
​https://bugs.webkit.org/show_bug.cgi?id=111291

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-03-04
Reviewed by Kenneth Rohde Christiansen.

This patch fixes build issues when compiling with GLES2
support. As part of the fix the patch removes Evas specific
workaround of using GLX with EGL in PlatformContext as GLES2
is the main target with EGL.

  • platform/graphics/OpenGLESShims.h:
  • platform/graphics/opengl/GLPlatformContext.cpp:

(WebCore::GLCurrentContextWrapper::GLCurrentContextWrapper):

  • platform/graphics/texmap/TextureMapper.h:
5:00 AM Changeset in webkit [144619] by kinuko@chromium.org
  • 2 edits in trunk/Tools

[chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
​https://bugs.webkit.org/show_bug.cgi?id=111284

Disabling the failing two tests on Android.

Reviewed by Jochen Eisinger.

  • TestWebKitAPI/Tests/WTF/StringHasher.cpp:

(TestWebKitAPI):
(TestWebKitAPI::TEST):

4:39 AM Changeset in webkit [144618] by loislo@chromium.org
  • 9 edits
    2 adds in trunk/Source/WebCore

Web Inspector: implement Flame Chart for CPU profiler.
​https://bugs.webkit.org/show_bug.cgi?id=111162

Reviewed by Yury Semikhatsky.

It is an initial implementation. The next step is to provide
function names and other stats about the hovered item.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • inspector/compile-front-end.py:
  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):

  • inspector/front-end/FlameChart.js: Added.

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype.findNodeCallback):
(WebInspector.FlameChart.prototype._coordinatesToNode):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype._rootNodes):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._drawNode):
(WebInspector.FlameChart.prototype._forEachNode):
(WebInspector.FlameChart.prototype._drawBar):
(WebInspector.FlameChart.prototype.update):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/flameChart.css: Added.

(.flame-chart):

4:26 AM Changeset in webkit [144617] by commit-queue@webkit.org
  • 25 edits in trunk/Source/WebCore

[V8] Add a "context type" parameter to GetTemplate and ConfigureV8SomethingTemplate functions
​https://bugs.webkit.org/show_bug.cgi?id=110875

The parameter will later be used for generating specialized V8
bindings for the 3 different world types (main world, isolated
work, worker).

Patch by Marja Hölttä <​marja@chromium.org> on 2013-03-04
Reviewed by Kentaro Hara.

No new tests (no changes in behavior yet).

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateNormalAttrGetter):
(GenerateNamedConstructor):
(GenerateImplementation):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):

  • bindings/v8/DOMDataStore.h:

(DOMDataStore):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore):
(WebCore::DOMWrapperWorld::setInitializingWindow):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::contextHasCorrectPrototype):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorld):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::retrieveFrameWithGlobalObjectCheck):

  • bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):
(WebCore::V8AdaptorFunction::wrap):

  • bindings/v8/V8AdaptorFunction.h:

(V8AdaptorFunction):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMWindow):
(WebCore::toScriptExecutionContext):
(WebCore::worldType):
(WebCore):
(WebCore::worldTypeInMainThread):

  • bindings/v8/V8Binding.h:

(WebCore):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::clearForNavigation):
(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::createWrapper):

  • bindings/v8/V8Initializer.cpp:

(WebCore::findFrame):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::constructorForTypeSlowCase):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::controllerForContext):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore::WrapperTypeInfo::getTemplate):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::eventAttrGetterCustom):
(WebCore::V8DOMWindow::eventAttrSetterCustom):
(WebCore::V8DOMWindow::toStringMethodCustom):
(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::wrapInShadowObject):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::V8HTMLImageElementConstructor::GetTemplate):

  • bindings/v8/custom/V8HTMLImageElementConstructor.h:

(V8HTMLImageElementConstructor):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::createInjectedScriptHostV8Wrapper):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::initMessageEventMethodCustom):

4:13 AM Changeset in webkit [144616] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2013-03-04 Kinuko Yasuda <​kinuko@chromium.org>

[Chromium] Unreviewed, removing failure test expectations for passing tests.

  • platform/chromium/TestExpectations:
3:45 AM Changeset in webkit [144615] by commit-queue@webkit.org
  • 6 edits
    9 adds in trunk/Source

Web Inspector: add Ace editor experiment
​https://bugs.webkit.org/show_bug.cgi?id=111191

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-04
Reviewed by Pavel Feldman.

Source/WebCore:

No new tests.

Add Ace text editor experiment.

  • WebCore.gypi:
  • inspector/front-end/AceTextEditor.js: Added.
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):

  • inspector/front-end/ace/ace.js: Added.
  • inspector/front-end/ace/acedevtools.css: Added.
  • inspector/front-end/ace/mode_css.js: Added.
  • inspector/front-end/ace/mode_html.js: Added.
  • inspector/front-end/ace/mode_javascript.js: Added.
  • inspector/front-end/ace/theme_textmate.js: Added.
  • inspector/front-end/ace/LICENSE.txt: Added.

Source/WebKit/chromium:

Add target to concatenate js files for Ace Text Editor.

  • WebKit.gyp:
3:40 AM Changeset in webkit [144614] by commit-queue@webkit.org
  • 22 edits in trunk

Add build flag for FontLoader
​https://bugs.webkit.org/show_bug.cgi?id=111289

Patch by Kunihiko Sakamoto <​ksakamoto@chromium.org> on 2013-03-04
Reviewed by Benjamin Poulain.

Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
3:25 AM Changeset in webkit [144613] by mkwst@chromium.org
  • 4 edits
    2 adds in trunk

XSSAuditor should strip dangerous attributes from SMIL animation elements.
​https://bugs.webkit.org/show_bug.cgi?id=111071

Reviewed by Adam Barth.

Source/WebCore:

SMIL animation elements can, amusingly enough, animate the 'href' of a
link. This patch teaches XSSAuditor how to deal with the
semicolon-separated 'animation[values]' attribute in order to ensure
that it doesn't contain JavaScript URLs that could be animated into
place for an unsuspecting user to click on.

Test: http/tests/security/xssAuditor/svg-animate.html

  • html/parser/XSSAuditor.cpp:

(WebCore::isSemicolonSeparatedAttribute): Added.

This returns true if the given attribute is SVGNames::valuesAttr,
but makes it possible to easily extend the list with additional
attributes with this strange property.

(WebCore::semicolonSeparatedValueContainsJavaScriptURL): Added.

Given a semicolon-separated string, determine if it contains any
JavaScript URLs.

(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):

When looking for dangerousness, determine whether or not we should
be comparing against each member of a semicolon-separated list.

LayoutTests:

  • http/tests/security/xssAuditor/resources/echo-intertag.pl:

Add a new mode that dumps an element and its attributes, which is a
bit more robust than adding a new mode for each attribute type we're
interested in.

  • http/tests/security/xssAuditor/svg-animate-expected.txt: Added.
  • http/tests/security/xssAuditor/svg-animate.html: Added.
3:09 AM Changeset in webkit [144612] by anilsson@rim.com
  • 1 edit
    16 adds in trunk/Source/WebCore

[BlackBerry] New files for BlackBerry::Platform::Graphics::GraphicsContext integration
​https://bugs.webkit.org/show_bug.cgi?id=111153

Reviewed by Rob Buis.

BlackBerry PR 293208

This patch contains contributions from many members of the BlackBerry
WebKit team:

Rob Buis
Robin Cao
Eli Fidler
Mike Lattanzio
Yong Li
Maxim Mogilnitsky
Joshua Netterfield
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Artem Simonov
Filip Spacek
George Staikos

Covered by existing tests.

  • platform/graphics/blackberry/FontBlackBerry.cpp: Added.

(FSFixedToFloat):
(FloatToFSFixed):
(WebCore):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawGlyphs):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::canExpandAroundIdeographsInComplexText):

  • platform/graphics/blackberry/FontCacheBlackBerry.cpp: Added.

(WebCore):
(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::getFamilyNameStringFromFontDescriptionAndFamily):
(WebCore::fontWeightToFontconfigWeight):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/blackberry/FontCustomPlatformData.h: Added.

(WebCore):
(FontCustomPlatformData):

  • platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp: Added.

(WebCore):
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::FontCustomPlatformData::supportsFormat):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp: Added.

(WebCore):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::name):
(WebCore::FontPlatformData::applyState):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::platformIsEqual):
(WebCore::FontPlatformData::description):
(WebCore::FontPlatformData::harfbuzzFace):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::setFakeBold):
(WebCore::FontPlatformData::setFakeItalic):
(WebCore::FontPlatformData::platformFontHandle):
(WebCore::FontPlatformData::isFixedPitch):

  • platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp: Added.

(WebCore):
(WorldTypeScopedPtr):
(WebCore::WorldTypeScopedPtr::WorldTypeScopedPtr):
(WebCore::WorldTypeScopedPtr::~WorldTypeScopedPtr):
(WebCore::WorldTypeScopedPtr::get):
(WebCore::GlyphPage::fill):

  • platform/graphics/blackberry/GradientBlackBerry.cpp: Added.

(WebCore):
(WebCore::totalStopsNeeded):
(WebCore::fillStops):
(WebCore::Gradient::platformGradient):
(WebCore::Gradient::platformDestroy):
(WebCore::Gradient::fill):
(WebCore::Gradient::setPlatformGradientSpaceTransform):

  • platform/graphics/blackberry/GraphicsContextBlackBerry.cpp: Added.

(WebCore):
(GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::platformContext):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::setIsAcceleratedContext):
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clearPlatformShadow):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::clipBounds):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::GraphicsContext::setPlatformStrokeThickness):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):

  • platform/graphics/blackberry/ITypeUtils.h: Added.

(floatToITypeFixed):
(intToITypeFixed):
(iTypeFixedToFloat):

  • platform/graphics/blackberry/ImageBufferBlackBerry.cpp: Added.

(WebCore):
(WebCore::makeBufferCurrent):
(WebCore::getImageDataInternal):
(WebCore::ImageBufferData::getImageData):
(WebCore::flushAndDraw):
(WebCore::ImageBufferData::draw):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::context):
(WebCore::ImageBuffer::platformLayer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/blackberry/ImageBufferDataBlackBerry.h: Added.

(WebCore):
(ImageBufferData):

  • platform/graphics/blackberry/PathBlackBerry.cpp: Added.

(WebCore):
(WebCore::scratchContext):
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::operator=):
(WebCore::Path::currentPoint):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::platformAddPathForRoundedRect):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::hasCurrentPoint):
(WebCore::Path::apply):
(WebCore::Path::transform):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):

  • platform/graphics/blackberry/PatternBlackBerry.cpp: Added.

(WebCore):
(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):
(WebCore::Pattern::setPlatformPatternSpaceTransform):

  • platform/graphics/blackberry/PlatformSupport.cpp: Added.

(WebCore):
(WebCore::PlatformSupport::getFontFamilyForCharacters):

  • platform/graphics/blackberry/PlatformSupport.h: Added.

(WebCore):
(PlatformSupport):
(FontFamily):

  • platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp: Added.

(WebCore):
(WebCore::FSFixedToFloat):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

2:12 AM Changeset in webkit [144611] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Marking a few layout tests as flaky.
2:07 AM Changeset in webkit [144610] by adam.bergkvist@ericsson.com
  • 3 edits
    2 adds
    2 deletes in trunk

MediaStream API: local addTrack() and removeTrack() operations should not fire events.
​https://bugs.webkit.org/show_bug.cgi?id=111079

Reviewed by Adam Barth.

Source/WebCore:

Removed the scheduling of "addtrack" and "removetrack" events by
addTrack and removeTrack(). Replaced the test since the old test was
driven by the event firing removed by this patch.

Test: fast/mediastream/MediaStream-add-remove-tracks.html

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):

LayoutTests:

Replaced the test since the old test was driven by the event firing
removed by this patch.

  • fast/mediastream/MediaStream-add-remove-tracks-expected.txt: Added.
  • fast/mediastream/MediaStream-add-remove-tracks.html: Added.
  • fast/mediastream/MediaStreamTrackList-expected.txt: Removed.
  • fast/mediastream/MediaStreamTrackList.html: Removed.
1:39 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:37 AM Changeset in webkit [144609] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK][WK2] Add document-loaded signal to WebKitWebPage
​https://bugs.webkit.org/show_bug.cgi?id=110614

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-04
Reviewed by Carlos Garcia Campos.

Add a new signal document-loaded to WebKitWebPage that will be emitted
when the DOM document has been loaded.

  • UIProcess/API/gtk/tests/TestWebExtensions.cpp:

(documentLoadedCallback):
(testDocumentLoadedSignal):
(beforeAll): Add test for document-loaded signal.

  • UIProcess/API/gtk/tests/WebExtensionTest.cpp:

(documentLoadedCallback):
(pageCreatedCallback):
(methodCallCallback): Add new D-Bus signal DocumentLoaded in order to
test document-loaded signal.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkit_web_page_class_init):
(webkitWebPageCreate): Add document-loaded signal and emit it when
didFinishDocumentLoadForFrame is called.

1:36 AM Changeset in webkit [144608] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: touchmove not emulated inside iframe
​https://bugs.webkit.org/show_bug.cgi?id=111292

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Move fake touch event dispatching from mouseMoved() into handleMouseMoveEvent()
and bail out earlier from dispatchSyntheticTouchEventIfEnabled() when the event
should be dispatched on a subframe.

  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):

LayoutTests:

  • fast/events/touch/emulated-touch-iframe.html:
  • fast/events/touch/resources/emulated-touch-iframe2.html:
1:33 AM Changeset in webkit [144607] by mkwst@chromium.org
  • 15 edits in trunk/Source/WebCore

Long URLs in error messages should be shortened
​https://bugs.webkit.org/show_bug.cgi?id=111133

Reviewed by Jochen Eisinger.

When generating console messages, we're often copying the page's URL
in order to add detail about where the error occurred. Generally, this
is fine, but in edge cases (multi-meg 'data:' URLs), we're using far
more memory than we should, and impacting performance.

This patch adds an 'elidedString()' method to KURL for use in this
sort of case; when generating console messages, we should insert the
elided URL rather than the full URL.

This shouldn't change any visible behavior; we're already visually
eliding URLs in console messages for URLs above 150 characters. This
patch simply changes the underlying string to ensure that no URL is
over 1k in length to begin with.

  • platform/KURL.cpp:

(WebCore::KURL::elidedString): Added.

  • platform/KURL.h:

An exciting new method that gives you the same result as string()
for URLs less than 1k long, and elides the middle of URLs longer
than 1k by replacing everything but the first and last 0.5k with
"...".

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::fail):

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeScript):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::isSafeToLoadURL):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
(WebCore::createWindow):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFail):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::printAccessDeniedMessage):

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowScriptNonce):
(WebCore::CSPDirectiveList::allowPluginType):

Use 'KURL::elidedString()' rather than 'KURL::string()'

  • loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::logWarning):

Here, we're doing the same as above, but it enables us to throw
away the asUTF8() function entirely by switching to makeString
rather than String::format.

1:22 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:19 AM Changeset in webkit [144606] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r144070 - [WK2][GTK] REGRESSION (r143463): unit test failure in WebKit2APITests/TestContextMenu
​https://bugs.webkit.org/show_bug.cgi?id=110869

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-26
Reviewed by Martin Robinson.

Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels.

  • UIProcess/API/gtk/tests/TestContextMenu.cpp:

(testContextMenuDefaultMenu): Modified test in order to give more space
to the media controls.

1:18 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas
Add some changes on track for WK2 (diff)
12:37 AM Changeset in webkit [144605] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source

Web Inspector: add runtime flag to determine if inspector's source files were flattened.
​https://bugs.webkit.org/show_bug.cgi?id=111184

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-04
Reviewed by Pavel Feldman.

Source/WebCore:

  • Add a file "buildSystemOnly.js" which will be included into

devtools.html only by GYP build system. This script sets a single flag
which essentially means that inspector source files were run
through a build system and flattened.

  • Update "importScript" and "registerRequiredCSS" functions to correct

paths according to the "flattenImports" flag.

No new tests: no change in behaviour.

  • WebCore.gypi:
  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):

  • inspector/front-end/View.js:

(WebInspector.View.prototype.registerRequiredCSS):

  • inspector/front-end/buildSystemOnly.js: Added.
  • inspector/front-end/utilities.js:

Source/WebKit/chromium:

Included "buildSystemOnly.js" in devtools.html by generate_devtools_html.py script.

  • WebKit.gyp:
  • scripts/generate_devtools_html.py: Add script tag to include buildSystemOnly.js

(write_devtools_html):

12:36 AM Changeset in webkit [144604] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.
​https://bugs.webkit.org/show_bug.cgi?id=111290

  • platform/qt/TestExpectations: Skipped failing test after r144461.
12:06 AM Changeset in webkit [144603] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Fix front-end compilation
​https://bugs.webkit.org/show_bug.cgi?id=111286

Reviewed by Alexander Pavlov.

  • inspector/InjectedScriptSource.js:
  • inspector/front-end/FileSystemProjectDelegate.js:
  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorTreeNode.prototype.reset):
(WebInspector.NavigatorFolderTreeNode.prototype.didAddChild):

Mar 3, 2013:

11:57 PM Changeset in webkit [144602] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[EFL][WebGL] Add proper checks to enable GraphicsSurface usage on EGL without XCompositeWindow.
​https://bugs.webkit.org/show_bug.cgi?id=108034

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-03-03
Reviewed by Laszlo Gombos.

Covered by existing WebGL tests.

Currently, we set GRAPHICS_SURFACE to true if support for XCompositeWindow
is identified during compile time. This is ok, when using GLX. We might not
have support for XCompositeWindow when using EGL and GLES2.0. This patch
makes changes so that GRAPHICS_SURFACE is always enabled with EGL and adds
GLX guard to the parts of code dependent on XCompositeWindow support.

  • platform/graphics/opengl/GLPlatformSurface.cpp:
  • platform/graphics/surfaces/glx/GLXConfigSelector.h:

(WebCore::GLXConfigSelector::findMatchingConfig):

  • platform/graphics/surfaces/glx/X11Helper.cpp:

(WebCore::X11Helper::createOffScreenWindow):
(WebCore::X11Helper::isXRenderExtensionSupported):

  • platform/graphics/surfaces/glx/X11Helper.h:
11:44 PM Changeset in webkit [144601] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [PageAgent] can't find frame by security origin.
​https://bugs.webkit.org/show_bug.cgi?id=110849

Use toRawString() in order to compare Frames' SecurityOrigins for storage-related goals.

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):

11:28 PM Changeset in webkit [144600] by apavlov@chromium.org
  • 16 edits in trunk

Unreviewed, rolling out r144455.
​http://trac.webkit.org/changeset/144455
​https://bugs.webkit.org/show_bug.cgi?id=111165

A simpler solution to the SecurityOrigin -> localStorage
lookup exists

Source/WebCore:

  • inspector/front-end/DOMStorage.js:

(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):

  • inspector/front-end/ExtensionAuditCategory.js:
  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype._reset):
(WebInspector.FileSystemModel.prototype._securityOriginAdded):
(WebInspector.FileSystemModel.prototype._securityOriginRemoved):
(WebInspector.FileSystemModel.prototype._addOrigin):
(WebInspector.FileSystemModel.prototype._removeOrigin):
(WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
(WebInspector.FileSystemModel.prototype._fileSystemRootReceived):
(WebInspector.FileSystemModel.prototype._removeFileSystem):
(WebInspector.FileSystemModel.FileSystem.prototype.get name):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype._securityOriginAdded):
(WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
(WebInspector.IndexedDBModel.prototype._addOrigin):
(WebInspector.IndexedDBModel.prototype._removeOrigin):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.):
(WebInspector.IndexedDBModel.prototype._requestData):
(WebInspector.IndexedDBModel.DatabaseId.prototype.equals):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDatabaseView.prototype._refreshDatabase):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._addSecurityOrigin):
(WebInspector.ResourceTreeModel.prototype._removeSecurityOrigin):
(WebInspector.ResourceTreeModel.prototype.securityOrigins):
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
(WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
(WebInspector.IDBIndexTreeElement.prototype.get itemURL):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
(WebInspector.FileSystemTreeElement):

LayoutTests:

  • http/tests/inspector-enabled/dom-storage-open.html:
  • http/tests/inspector/filesystem/delete-entry.html:
  • http/tests/inspector/filesystem/request-filesystem-root.html:
  • http/tests/inspector/indexeddb/database-data.html:
  • http/tests/inspector/indexeddb/database-names.html:
  • http/tests/inspector/indexeddb/database-structure.html:
  • http/tests/inspector/resource-tree/resource-tree-events.html:
11:09 PM Changeset in webkit [144599] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

PDFPlugin: Rename delegate method from openWithPreview to openWithNativeApplication
​https://bugs.webkit.org/show_bug.cgi?id=111258

Reviewed by Alexey Proskuryakov.

  • WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFLayerControllerDelegate openWithNativeApplication]):
Rename from openWithPreview to openWithNativeApplication to match PDFKit.

10:53 PM Changeset in webkit [144598] by vsevik@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: Let user know when file system based uiSourceCode was changed on disk.
​https://bugs.webkit.org/show_bug.cgi?id=110133

Reviewed by Pavel Feldman.

We now check if file system based uiSourceCode content was updated externally when
UISourceCodeFrame is shown or inspector window is focused.
If there is no working copy being edited right now we replace old content with the new one silently.
Otherwise ask user if he wants to replace his working copy with the new content.

  • English.lproj/localizedStrings.js:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.editRange):

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._contentRequestFinished):
(WebInspector.FileSystemProjectDelegate.prototype.requestUpdatedFileContent):
(WebInspector.FileSystemProjectDelegate.prototype.contentCallback):
(WebInspector.FileSystemProjectDelegate.prototype.searchInFileContent):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.wasShown):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate.prototype.requestUpdatedFileContent):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.setContent):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.checkContentUpdated.updatedContentLoaded):
(WebInspector.UISourceCode.prototype.checkContentUpdated):

  • inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame.prototype.wasShown):
(WebInspector.UISourceCodeFrame.prototype.willHide):
(WebInspector.UISourceCodeFrame.prototype._windowFocused):
(WebInspector.UISourceCodeFrame.prototype._checkContentUpdated):

  • inspector/front-end/Workspace.js:

(WebInspector.ProjectDelegate.prototype.requestUpdatedFileContent):
(WebInspector.Project.prototype.requestUpdatedFileContent):

10:34 PM Changeset in webkit [144597] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening

Remove failure annotation on tests which was already fixed.

  • platform/chromium/TestExpectations:
10:28 PM Changeset in webkit [144596] by benjamin@webkit.org
  • 5 edits in trunk

[Mac] Get rid of a useless method from DOMHTMLInputElement
​https://bugs.webkit.org/show_bug.cgi?id=111279

Reviewed by Sam Weinig.

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm:
  • DOM/WebDOMOperationsPrivate.h:

setValueForUser: is already privately exposed by DOMHTMLInputElement,
no need to have it twice.

Tools:

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setValueForUser):
The method _setValueForUser: was added for testing. This feature is already
exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
in real use cases. Get rid of the method created for testing, use the real thing
instead.

9:51 PM Changeset in webkit [144595] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

createAttribute/setAttributeNode does not properly normalize case
​https://bugs.webkit.org/show_bug.cgi?id=90341

Patch by Arpita Bahuguna <​a.bah@samsung.com> on 2013-03-03
Reviewed by Darin Adler.

Source/WebCore:

setAttributeNode() verifies for existing attributes in a case sensitive
manner. Thus, it would add another attribute if specified in a case
different from the existing one. Instead, like setAttribute(), it too
should modify the existing attribute's value.

Test: fast/dom/Element/setAttributeNode-case-insensitivity.html

  • dom/Element.cpp:

(WebCore::Element::setAttributeNode):
Made changes to check for an existing attribute by converting the
specified attribute's localName to lowercase.

LayoutTests:

  • fast/dom/Element/setAttributeNode-case-insensitivity-expected.txt: Added.
  • fast/dom/Element/setAttributeNode-case-insensitivity.html: Added.

Testcase for verifying that setAttributeNode() checks against existing
attributes in a case insensitive manner. It updates the value of an
existing attribute (in lower case) with that of the one set using
setAttributeNode() (in upper case).
The test also verifies the behavior of attributes when specified with
namespace and prefix.

5:42 PM Changeset in webkit [144594] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests.

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::indexedSecurityCheck):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::namedSecurityCheck):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

5:39 PM Changeset in webkit [144593] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r144590.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSecurityCheckFunctions):

5:36 PM Changeset in webkit [144592] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix after r144587.

  • bindings/v8/V8Binding.cpp:

(WebCore::toV8Context):

  • bindings/v8/V8MutationCallback.cpp:

(WebCore::V8MutationCallback::V8MutationCallback):

4:16 PM Changeset in webkit [144591] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] HTMLDocument.all should have [Replaceable]
​https://bugs.webkit.org/show_bug.cgi?id=111230

Reviewed by Adam Barth.

(Although HTMLDocument.all is already removed from the spec,)
it is expected to behave as a [Replaceable] attribute. By adding
a [Replaceable] IDL attribute, we can remove custom implementation
of HTMLDocument.all.

I confimed that exactly the same code is generated for .all getter
and setter.

No tests. No change in behavior.

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • html/HTMLDocument.idl:
4:12 PM Changeset in webkit [144590] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] indexedSecurityCheck() and namedSecurityCheck() should be auto-generated
​https://bugs.webkit.org/show_bug.cgi?id=111225

Reviewed by Adam Barth.

indexedSecurityCheck() and namedSecurityCheck() should be auto-generated,
except for DOMWindow's ones.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateSecurityCheckFunctions):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedSecurityCheckCustom):
(WebCore::V8DOMWindow::indexedSecurityCheckCustom):

  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
4:11 PM Changeset in webkit [144589] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Shrink JSC::HashTable entries.
<​http://webkit.org/b/111275>
<rdar://problem/13333511>

Reviewed by Anders Carlsson.

Move the Intrinsic value out of the function-specific part of the union,
and store it next to m_attributes. Reduces the size of HashEntry by 8 bytes.

990 kB progression on Membuster3. (PTUS: 797 kB)

  • runtime/Lookup.h:

(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):
(HashEntry):

4:09 PM Changeset in webkit [144588] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Rename $implContentDecls to $implContentInternals in CodeGeneratorV8.pm
​https://bugs.webkit.org/show_bug.cgi?id=111214

Reviewed by Adam Barth.

$implContentDecls stores generated code that is put in a namespace 'XXXV8Internal'.
For clarification, it should be renamed to $implContentInternals.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateConstructorGetter):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateReplaceableAttrSetterCallback):
(GenerateReplaceableAttrSetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateEventConstructor):
(GenerateTypedArrayConstructor):
(GenerateImplementation):
(WriteData):

4:05 PM Changeset in webkit [144587] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

[V8] Rename getWorld() to isolatedWorld(), and getWorldForEnteredContext() to isolatedWorldForEnteredContext()
​https://bugs.webkit.org/show_bug.cgi?id=111212

Reviewed by Adam Barth.

The rename I did in r142424 was wrong. Given that getWorld() returns 0
for the main world, it should be named isolatedWorld(). Similarly,
given that getWorldForEnteredContext() returns 0 for the main world,
it should be named isolatedWorldForEnteredContext().

No tests. No change in behavior.

  • bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::isFeatureAllowed):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::makeContextWeak):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::isolatedWorld):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
(WebCore::ScriptController::currentWorldContext):

  • bindings/v8/V8Binding.h:

(WebCore::isolatedWorldForEnteredContext):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCustom):

3:56 PM Changeset in webkit [144586] by beidson@apple.com
  • 14 edits in branches/safari-534.59-branch

Merge r143988

2013-02-25 Anders Carlsson <​andersca@apple.com>

Source/WebKit2:

Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110821

Reviewed by Beth Dakin.

  • UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationPluginspageAttributeURLKey): (WKPageGetPluginInformationPluginURLKey): Add two new API key getters.


  • UIProcess/API/C/WKPage.h: Add a new callback and deprecate the old callback.


  • UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy): Make the pluginInformationDictionary a static member function of WebPageProxy so it can be called from WebUIClient as well.


  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): Pass the bundle version as well.

(WebKit::WebPageProxy::pluginInformationPluginspageAttributeURLKey):
(WebKit::WebPageProxy::pluginInformationPluginURLKey):
Add two new keys.

(WebKit::WebPageProxy::pluginInformationDictionary):
Handle more keys.

(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Get the plug-in bundle identifier and version.

  • UIProcess/WebPageProxy.messages.in: Pass along more information; the frame and page URLs.
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::unavailablePluginButtonClicked): Call the new callback if it's supported.
  • UIProcess/WebUIClient.h: (WebUIClient):
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Update for API changes.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked): Ensure that the pluginspage attribute is a valid URL.

Tools:

Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110821
<rdar://problem/13265303>

Reviewed by Beth Dakin.

Update for WebKit2 changes.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::unavailablePluginButtonClicked):
  • WebKitTestRunner/TestController.h: (TestController):
3:54 PM Changeset in webkit [144585] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[EFL][QT][WK2] Turn on ApplyDeviceScaleFactorInCompositor always.
​https://bugs.webkit.org/show_bug.cgi?id=110298

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-03-03
Reviewed by Kenneth Rohde Christiansen.

Currently, EFL and Qt turn on ApplyDeviceScaleFactorInCompositor when using
fixed layout, but ApplyDeviceScaleFactorInCompositor is not related to fixed
layout. It is confusing that a platform WebView deals with device view size or
DIP view size case by case. So this patch always turns on
ApplyDeviceScaleFactorInCompositor.

In addition, move the code that turns on ScrollingCoordinatorEnabled to
CoordinatedLayerTreeHost.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::setDeviceScaleFactor):

We should make WebPage know new DIP size.

(EwkView::setSize):

When we set ApplyDeviceScaleFactorInCompositor to true, make WebPage
know the DIP size as a view size.

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::updateViewportSize):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUseFixedLayout):

WebPage sends the DIP size to Web Process even when we don't use fixed layout.

3:52 PM Changeset in webkit [144584] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell
​https://bugs.webkit.org/show_bug.cgi?id=111223

Reviewed by Adam Barth.

HTMLDocument::getNamedProperty() is used by DOMWindowShell.
It can be a static method in DOMWindowShell.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getNamedProperty):
(WebCore):
(WebCore::getter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
3:19 PM Changeset in webkit [144583] by rniwa@webkit.org
  • 24 edits in trunk

Some perf. tests have variances that differ greatly between runs
​https://bugs.webkit.org/show_bug.cgi?id=97510

Reviewed by Benjamin Poulain.

PerformanceTests:

In order to control the number of iterations and processes to use from run-perf-tests, always use 20
iterations on all tests except Dromaeo, where even doing 5 iterations is prohibitively slow, by default.
Without this change, it'll become extremely hard for us to tweak the number of iterations and processes
to use from run-perf-tests.

  • Animation/balls.html:
  • DOM/DOMTable.html:
  • DOM/resources/dom-perf.js:

(runBenchmarkSuite.PerfTestRunner.measureTime):

  • Dromaeo/resources/dromaeorunner.js:
  • Layout/floats_100_100.html:
  • Layout/floats_100_100_nested.html:
  • Layout/floats_20_100.html:
  • Layout/floats_20_100_nested.html:
  • Layout/floats_2_100.html:
  • Layout/floats_2_100_nested.html:
  • Layout/floats_50_100.html:
  • Layout/floats_50_100_nested.html:
  • Layout/subtree-detaching.html:
  • Parser/html5-full-render.html:
  • SVG/SvgHitTesting.html:
  • resources/runner.js:
  • resources/results-template.html:

Tools:

Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
environment on test results (we run each instance after one another, not in parallel).

We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
iterations as it was done previously in single process. These values are hard-coded in perftest.py
and runner.js but they are to be configurable in the future.

Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
metric now reports an array of the length 4 with each element containing an array of 5 iteration
values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.

Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTestMetric.append_group): Renamed from append.
(PerfTestMetric.grouped_iteration_values): Added.
(PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.

(PerfTest.init): Takes the number of processes (drivers) to run tests with.
This parameter is only used by SingleProcessPerfTest.

(PerfTest.run): Repeat tests using different driver processes.
(PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
We instead use _ensure_metrics to obtain the matched metrics and store the data there.
(PerfTest._ensure_metrics): Added.

(SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
instances of DumpRenderTree/WebKitTestRunner takes too long.
(SingleProcessPerfTest.init):

(ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.

(PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect

_run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.

(TestPerfTestMetric.test_append): Updated per name and added some test cases for
grouped_iteration_values.

(TestPerfTest._assert_results_are_correct):

(TestSingleProcessPerfTest): Added.
(TestSingleProcessPerfTest.test_use_only_one_process):
(TestSingleProcessPerfTest.test_use_only_one_process.run_single):

(TestReplayPerfTest.test_run_with_driver_accumulates_results):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):

  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of

sample standard deviations since we're now running tests 4 times.
(MainTest._test_run_with_json_output.mock_upload_json):
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):

LayoutTests:

Use dromaeoIterationCount now that we no longer support iterationCount.

  • fast/harness/perftests/runs-per-second-iterations.html:
3:02 PM Changeset in webkit [144582] by beidson@apple.com
  • 13 edits in branches/safari-534.59-branch

Merge r143976

2013-02-25 Anders Carlsson <​andersca@apple.com>

Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110793
<rdar://problem/13265303>

Reviewed by Sam Weinig.

Source/WebKit2:

Add a new pluginDidFail callback that takes a WKDictionaryRef and also pass in the
frame and page URLs.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit::pluginInformationDictionary): (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy):
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailToInitializePlugin): (WebKit::WebPageProxy::didBlockInsecurePluginVersion):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::didFailToInitializePlugin):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin):

Tools:

Update for WebKit2 API changes.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions):
2:15 PM Changeset in webkit [144581] by aelias@chromium.org
  • 6 edits in trunk

[chromium] Remove WebLayerTreeView::setViewportSize call
​https://bugs.webkit.org/show_bug.cgi?id=110727

Reviewed by James Robinson.

After ​https://codereview.chromium.org/12328080 lands,
setViewportSize is called from the Chromium side. The multiplication
by deviceScaleFactor here was prone to off-by-one errors.
The layoutSize() function was only used here so delete it as well.

DumpRenderTree WebViewHost must now call this method as well.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateLayerTreeViewport):

  • src/WebViewImpl.h:

(WebViewImpl):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::initializeLayerTreeView):
(WebViewHost::setWindowRect):
(WebViewHost::setDeviceScaleFactor):
(WebViewHost::updateViewportSize):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

2:15 PM Changeset in webkit [144580] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Shared Web Workers have an incorrect visible process name
​https://bugs.webkit.org/show_bug.cgi?id=111277

Reviewed by Dan Bernstein.

  • SharedWorkerProcess/SharedWorkerProcess.cpp:

(WebKit::SharedWorkerProcess::initializeSharedWorkerProcess):

  • SharedWorkerProcess/SharedWorkerProcess.h:

(SharedWorkerProcess):

  • SharedWorkerProcess/mac/SharedWorkerProcessMac.mm:

(WebKit::SharedWorkerProcess::initializeProcessName):
The SharedWorkerProcess is not an internet plug-in!

12:43 PM Changeset in webkit [144579] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r144565. Reverted r144533.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
11:57 AM Changeset in webkit [144578] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the Qt build after r144498
​https://bugs.webkit.org/show_bug.cgi?id=111272

Reviewed by Eric Seidel.

Update the Qt version of the XML parser to call the new API.

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::resumeParsing):
(WebCore::XMLDocumentParser::appendFragmentSource):

11:36 AM Changeset in webkit [144577] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Plug-ins that are appropriately large w.r.t page size should autostart
​https://bugs.webkit.org/show_bug.cgi?id=111242

Reviewed by Brady Eidson.

A "full-page" plug-in site should never snapshot. The trick is
how to determine what is full-page. This change implements the
following algorithm.

  • The plug-in is in the main frame (not an iframe).
  • The plug-in is sized with width and height 100%.
  • The displayed area of the plug-in is more than 96% of the viewport area.

This is definitely not foolproof. For example, zombo.com has a slight
border around its plug-in. As the window size gets smaller, the body margin
takes up more than 5% of the width or height, and the plug-in doesn't pass
the tests above.

  • html/HTMLPlugInImageElement.cpp:

(WebCore): New static constant: sizingFullPageThresholdPercentage
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Implements

the rules described above.

10:27 AM Changeset in webkit [144576] by beidson@apple.com
  • 12 edits in branches/safari-534.59-branch/Source

Merge r143815

2013-02-22 Anders Carlsson <​andersca@apple.com>

pluginLoadStrategy should take a WKDictionaryRef for extensibility
​https://bugs.webkit.org/show_bug.cgi?id=110656
<rdar://problem/13265303>

Reviewed by Jessie Berlin.

../WebCore:

Export a symbol needed by WebKit2.

  • WebCore.exp.in:

../WebKit2:

Change pluginLoadStrategy to take a WKDictionaryRef instead of a number of parameters;
this lets us add more plug-in information if needed. Also add the page URL and rename documentURL to frameURL.

  • UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationBundleIdentifierKey): (WKPageGetPluginInformationBundleVersionKey): (WKPageGetPluginInformationDisplayNameKey): (WKPageGetPluginInformationFrameURLKey): (WKPageGetPluginInformationMIMETypeKey): (WKPageGetPluginInformationPageURLKey):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit): (WebKit::WebLoaderClient::pluginLoadPolicy):
  • UIProcess/WebLoaderClient.h: (WebLoaderClient):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): (WebKit::WebPageProxy::pluginInformationBundleIdentifierKey): (WebKit): (WebKit::WebPageProxy::pluginInformationBundleVersionKey): (WebKit::WebPageProxy::pluginInformationDisplayNameKey): (WebKit::WebPageProxy::pluginInformationFrameURLKey): (WebKit::WebPageProxy::pluginInformationMIMETypeKey): (WebKit::WebPageProxy::pluginInformationPageURLKey):
  • UIProcess/WebPageProxy.h: (WebPageProxy):
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
8:16 AM Changeset in webkit [144575] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

[Win] IDLParser.pm fails to parse OESTextureHalfFloat and causes a build failure
​https://bugs.webkit.org/show_bug.cgi?id=111267

Reviewed by Kentaro Hara.

Allow empty definitions.

  • bindings/scripts/IDLParser.pm:

(Parse):

7:59 AM Changeset in webkit [144574] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX: RenderLayerFilterInfo.h needs to include Element.h with ENABLE(SVG)

Fixes the following build failures:

In file included from Source/WebCore/rendering/RenderLayerFilterInfo.cpp:33:
Source/WebCore/rendering/RenderLayerFilterInfo.h:118:19: error: use of undeclared identifier 'Element'

Vector<RefPtr<Element> > m_internalSVGReferences;


Source/WebCore/rendering/RenderLayerFilterInfo.h:118:28: error: expected a type

Vector<RefPtr<Element> > m_internalSVGReferences;


Source/WebCore/rendering/RenderLayerFilterInfo.h:118:30: error: private field 'm_internalSVGReferences' is not used [-Werror,-Wunused-private-field]

Vector<RefPtr<Element> > m_internalSVGReferences;


3 errors generated.

  • rendering/RenderLayerFilterInfo.h: Include Element.h within

ENABLE(SVG). Move ENABLE(SVG) block below unconditional
headers.

4:05 AM Changeset in webkit [144573] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix attempt after r144547.

  • WebKit.vcproj/WebKitExports.def.in:
3:47 AM Changeset in webkit [144572] by commit-queue@webkit.org
  • 23 edits
    3 deletes in trunk

Unreviewed, rolling out r144567.
​http://trac.webkit.org/changeset/144567
​https://bugs.webkit.org/show_bug.cgi?id=111266

Does not compile on apple-win (Requested by abarth on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-03

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::iconURLs):

  • dom/Document.h:

(Document):

  • loader/icon/IconController.cpp:

(WebCore::IconController::iconURL):
(WebCore::IconController::urlsForTypes):

  • loader/icon/IconController.h:

(IconController):

  • testing/Internals.cpp:

(WebCore::Internals::iconURLs):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/chromium:

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::iconURLs):

  • src/WebFrameImpl.h:

(WebFrameImpl):

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

  • fast/dom/icon-url-change.html:
  • fast/dom/icon-url-list-apple-touch-expected.txt: Removed.
  • fast/dom/icon-url-list-apple-touch.html: Removed.
  • fast/dom/icon-url-list.html:
  • fast/dom/icon-url-property.html:
  • platform/chromium-android/fast/dom/icon-url-list-apple-touch-expected.txt: Removed.
3:06 AM Changeset in webkit [144571] by mkwst@chromium.org
  • 8 edits in trunk/Source

CSP 1.1: Support CSP 1.1 directives on the unprefixed header.
​https://bugs.webkit.org/show_bug.cgi?id=111254

Reviewed by Adam Barth.

Source/WebCore:

We'd like to ensure that early adopters don't get stuck on a prefixed
header; when CSP 1.1 is baked enough to be supported in multiple
browsers, everything should Just Work™.

This patch changes WebKit's behavior regarding CSP_NEXT features.
Currently, they're only exposed on the prefixed header ('X-WebKit-CSP').
This patch exposes those features on the canonical header, assuming
that the runtime flag is set. This shouldn't have any effect at all on
ports that haven't yet enabled CSP_NEXT, and will simply clear the way
for a clean deployment to a wider audience once the specification
process is further along.

This change shouldn't have any effect on the existing tests: they
should run just as they did before. The next step will be to adjust
the LayoutTests for 1.1 to prefer the canonical header, but I'll do
that in another patch to reduce churn.

Related, the enum names no longer made sense: the difference between the
canonical 'Content-Security-Policy' header and 'X-WebKit-CSP' is the
prefix, not the functionality. This patch renames them for clarity.

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

Use the new enum names.

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::CSPDirectiveList):
(WebCore::CSPDirectiveList::addDirective):

Drop the 'm_experimental' property from CSPDirectiveList; we'll
control the behavior via the runtime flag from now on.

Also, this fixes a small bug in 'addDirective()': we never threw
unrecognized directive errors for users who were sending the
prefixed header. Oops!

(WebCore::ContentSecurityPolicy::deprecatedHeaderType):

Use the new enum names.

  • page/ContentSecurityPolicy.h:

Redefine the enum for clarity: 'PrefixedReport' and 'Report'
rather than 'ReportAllDirectives' and 'ReportStableDirectives'.

Source/WebKit/chromium:

The enum names no longer made sense: the difference between the
canonical 'Content-Security-Policy' header and 'X-WebKit-CSP' is the
prefix, not the functionality. This patch renames them for clarity.

  • public/WebContentSecurityPolicy.h:
  • src/AssertMatchingEnums.cpp:

Rename the Chromium side of the enums.

2:47 AM Changeset in webkit [144570] by rniwa@webkit.org
  • 4 edits in trunk/Source

Source/WebCore: Another Windows build fix attempt after r144567.
Try touching the IDL file in a hope it'll regenerate JSInternals.cpp.

  • testing/Internals.idl:

Source/WebKit/win: That was a wrong fix. Revert r144569.

  • WebKit.vcproj/WebKitExports.def.in:
2:34 AM Changeset in webkit [144569] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix attempt after r144567.

  • WebKit.vcproj/WebKitExports.def.in:
2:12 AM Changeset in webkit [144568] by abarth@webkit.org
  • 116 edits in trunk/Source

Unreviewed attempted build fix. Adds back some includes removed in
​http://trac.webkit.org/changeset/144565.

Source/WebCore:

  • Modules/mediastream/RTCPeerConnection.cpp:
  • bindings/ScriptControllerBase.cpp:
  • bindings/objc/DOM.mm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • css/CSSFontSelector.cpp:
  • css/WebKitCSSSVGDocumentValue.cpp:
  • dom/DOMImplementation.cpp:
  • dom/PendingScript.h:
  • dom/ScriptElement.cpp:
  • dom/ScriptElement.h:
  • history/CachedFrame.cpp:
  • html/DOMURL.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAppletElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLHtmlElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/ImageDocument.cpp:
  • html/ImageInputType.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):

  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLParserOptions.cpp:
  • html/parser/XSSAuditorDelegate.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorFileSystemAgent.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorPageAgent.cpp:
  • inspector/NetworkResourcesData.cpp:
  • inspector/NetworkResourcesData.h:

(WebCore):

  • loader/CookieJar.cpp:
  • loader/CrossOriginAccessControl.cpp:
  • loader/FrameLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/MixedContentChecker.cpp:
  • loader/PingLoader.cpp:
  • loader/SubframeLoader.cpp:
  • loader/SubresourceLoader.cpp:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheHost.cpp:
  • loader/cache/CachedResource.cpp:
  • loader/icon/IconController.cpp:
  • page/DOMWindowExtension.cpp:
  • page/Frame.cpp:
  • page/PerformanceTiming.cpp:
  • page/PointerLockController.cpp:
  • page/animation/CSSPropertyAnimation.cpp:
  • platform/chromium/PasteboardChromium.cpp:
  • platform/efl/ErrorsEfl.cpp:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/gtk/ErrorsGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/gtk/PasteboardHelper.h:
  • platform/mac/ClipboardMac.mm:
  • platform/mac/HTMLConverter.mm:
  • platform/qt/PasteboardQt.cpp:
  • plugins/DOMMimeType.cpp:
  • plugins/PluginView.cpp:
  • rendering/HitTestResult.cpp:
  • rendering/RenderImage.cpp:
  • rendering/RenderImageResource.cpp:
  • rendering/RenderImageResourceStyleImage.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerBacking.cpp:
  • svg/SVGImageLoader.cpp:
  • svg/SVGUseElement.cpp:
  • testing/MockPagePopupDriver.cpp:
  • xml/XSLStyleSheet.h:

(WebCore):

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:
  • src/AssociatedURLLoader.cpp:
  • src/EditorClientImpl.cpp:
  • src/SharedWorkerRepository.cpp:
  • src/WebDataSourceImpl.cpp:
  • src/WebFrameImpl.h:

(WebCore):

  • src/WebNode.cpp:
  • src/WebSharedWorkerImpl.cpp:
  • tests/FrameLoaderClientImplTest.cpp:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • ewk/ewk_frame.cpp:

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm:
  • Misc/WebNSPasteboardExtras.mm:
  • WebCoreSupport/WebFrameNetworkingContext.mm:
  • WebView/WebRenderLayer.mm:
  • WebView/WebRenderNode.mm:

Source/WebKit/qt:

  • WebCoreSupport/NotificationPresenterClientQt.cpp:
  • WebCoreSupport/QWebPageAdapter.cpp:

Source/WebKit2:

  • Shared/WebRenderLayer.cpp:
  • Shared/WebRenderObject.cpp:
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/WebProcess.cpp:
  • WebProcess/soup/WebProcessSoup.cpp:
1:54 AM Changeset in webkit [144567] by commit-queue@webkit.org
  • 20 edits
    3 adds in trunk

<link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc
​https://bugs.webkit.org/show_bug.cgi?id=109061

Patch by Ruslan Abdikeev <​aruslan@chromium.org> on 2013-03-03
Reviewed by Adam Barth.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Test: fast/dom/icon-url-list-apple-touch.html

Added iconTypes parameter to Document::iconURLs().
Added Document::shortcutIconURLs() with original semantics of iconURLs().
Fixed IconController.cpp to provide iconTypesMask to iconURLs().
Renamed iconTypes to iconTypesMask to make the meaning clearer.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::shortcutIconURLs):
(WebCore):
(WebCore::Document::iconURLs):

  • dom/Document.h:

(Document):

  • loader/icon/IconController.cpp:

(WebCore::IconController::iconURL):
(WebCore::IconController::urlsForTypes):

  • testing/Internals.cpp:

(WebCore::Internals::iconURLs):
(WebCore::Internals::shortcutIconURLs):
(WebCore):
(WebCore::Internals::allIconURLs):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Added test for apple-touch-icon in allIconURLs().
Changed iconURLs() to shortcutIconURLs().

  • fast/dom/icon-url-change.html:
  • fast/dom/icon-url-list-apple-touch-expected.txt: Added.
  • fast/dom/icon-url-list-apple-touch.html: Added.
  • fast/dom/icon-url-list.html:
  • fast/dom/icon-url-property.html:
1:28 AM Changeset in webkit [144566] by mkwst@chromium.org
  • 4 edits
    2 adds in trunk

CSP: Throw a warning when a '*-report-only' header doesn't contain a 'report-uri' directive.
​https://bugs.webkit.org/show_bug.cgi?id=111208

Reviewed by Adam Barth.

Source/WebCore:

Developers in the wild have been observed to serve a report-only CSP
header with a policy that doesn't contain a 'report-uri' directive.
This has zero effect, of course, and we should help them understand
that by throwing a warning up on the console.

Test: http/tests/security/contentSecurityPolicy/report-only-report-uri-missing.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::isReportOnly): Added.
(WebCore::CSPDirectiveList::reportURIs): Added.
(WebCore::CSPDirectiveList::create):

After creating a CSPDirectiveList, check whether it's in
report-only mode without a report-uri. If so, warn the developer.

(WebCore::ContentSecurityPolicy::reportMissingReportURI): Added.

Write an exciting message to the console, warning the developer
about her expensive no-op machine.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/report-only-report-uri-missing-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-only-report-uri-missing.html: Added.
1:16 AM Changeset in webkit [144565] by abarth@webkit.org
  • 206 edits
    7 deletes in trunk/Source

Unreviewed rollout of ​http://trac.webkit.org/r144530
As described in ​https://bugs.webkit.org/show_bug.cgi?id=111167 and
​https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
large number of ASSERTs in chromium-win.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCPeerConnection.cpp:
  • Modules/notifications/Notification.cpp:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp:
  • bindings/js/JSNodeCustom.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptSourceCode.h:

(WebCore):

  • bindings/objc/DOM.mm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):

  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:
  • css/WebKitCSSSVGDocumentValue.cpp:
  • css/WebKitCSSSVGDocumentValue.h:

(WebCore):

  • dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard):

  • dom/ContainerNode.cpp:
  • dom/DOMImplementation.cpp:
  • dom/PendingScript.h:
  • dom/ScriptElement.cpp:
  • dom/ScriptElement.h:
  • history/CachedFrame.cpp:
  • html/DOMURL.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAppletElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLHtmlElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/ImageDocument.cpp:
  • html/ImageInputType.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):

  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLParserOptions.cpp:
  • html/parser/HTMLScriptRunner.h:
  • html/parser/XSSAuditor.cpp:
  • html/parser/XSSAuditorDelegate.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorFileSystemAgent.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorInstrumentation.h:

(WebCore):

  • inspector/InspectorPageAgent.cpp:
  • inspector/NetworkResourcesData.cpp:
  • inspector/NetworkResourcesData.h:

(WebCore):

  • loader/CookieJar.cpp:
  • loader/CrossOriginAccessControl.cpp:
  • loader/CrossOriginAccessControl.h:

(WebCore):

  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):

  • loader/FrameLoader.h:

(WebCore):
(WebCore::FrameLoader::policyChecker):

  • loader/ImageLoader.cpp:
  • loader/ImageLoader.h:
  • loader/LinkLoader.h:

(WebCore):

  • loader/MainResourceLoader.cpp:
  • loader/MainResourceLoader.h:

(WebCore):

  • loader/MixedContentChecker.cpp:
  • loader/PingLoader.cpp:
  • loader/PolicyChecker.h:

(WebCore):

  • loader/ProgressTracker.cpp:
  • loader/SubframeLoader.cpp:
  • loader/SubresourceLoader.cpp:
  • loader/TextTrackLoader.cpp:
  • loader/TextTrackLoader.h:

(WebCore):

  • loader/ThreadableLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h:

(WebCore):

  • loader/appcache/ApplicationCacheHost.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:

(CachedFontClient):
(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):
(WebCore):

  • loader/cache/CachedFontClient.h: Removed.
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedRawResource.h:

(WebCore):
(CachedRawResourceClient):
(WebCore::CachedRawResourceClient::~CachedRawResourceClient):
(WebCore::CachedRawResourceClient::expectedType):
(WebCore::CachedRawResourceClient::resourceClientType):
(WebCore::CachedRawResourceClient::dataSent):
(WebCore::CachedRawResourceClient::responseReceived):
(WebCore::CachedRawResourceClient::dataReceived):
(WebCore::CachedRawResourceClient::redirectReceived):
(WebCore::CachedRawResourceClient::dataDownloaded):

  • loader/cache/CachedRawResourceClient.h: Removed.
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceHandle.cpp:

(WebCore):

  • loader/cache/CachedResourceHandle.h:

(WebCore):
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):

  • loader/cache/CachedSVGDocument.h:

(CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
(WebCore):

  • loader/cache/CachedSVGDocumentClient.h: Removed.
  • loader/cache/CachedSVGDocumentReference.cpp: Removed.
  • loader/cache/CachedSVGDocumentReference.h:

(WebCore):
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):

  • loader/cache/CachedStyleSheetClient.h:

(WebCore):

  • loader/cache/MemoryCache.h:

(WebCore):
(MemoryCache):

  • loader/chromium/CachedRawResourceChromium.cpp:
  • loader/icon/IconController.cpp:
  • loader/icon/IconLoader.h:
  • loader/mac/ResourceLoaderMac.mm:
  • page/DOMWindowExtension.cpp:
  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore):
(WebCore::Frame::reportMemoryUsage):

  • page/Frame.h:

(WebCore):
(Frame):
(WebCore::Frame::init):
(WebCore::Frame::loader):

  • page/PerformanceNavigation.cpp:
  • page/PerformanceTiming.cpp:
  • page/PointerLockController.cpp:
  • page/Settings.cpp:
  • page/animation/CSSPropertyAnimation.cpp:
  • platform/chromium/PasteboardChromium.cpp:
  • platform/efl/ErrorsEfl.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/filters/FilterOperation.cpp:

(WebCore):

  • platform/graphics/filters/FilterOperation.h:

(WebCore):
(WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
(WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/gtk/ErrorsGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/gtk/PasteboardHelper.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/PasteboardMac.mm:
  • platform/network/AuthenticationChallengeBase.cpp:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/cf/ResourceRequestCFNet.cpp:
  • platform/network/mac/CookieStorageMac.mm:
  • platform/qt/PasteboardQt.cpp:
  • plugins/DOMMimeType.cpp:
  • plugins/PluginRequest.h: Removed.
  • plugins/PluginStream.h:

(PluginStreamClient):
(WebCore::PluginStreamClient::~PluginStreamClient):
(WebCore::PluginStreamClient::streamDidFinishLoading):
(WebCore):

  • plugins/PluginStreamClient.h: Removed.
  • plugins/PluginView.cpp:
  • plugins/PluginView.h:

(WebCore):
(PluginRequest):
(WebCore::PluginRequest::PluginRequest):
(WebCore::PluginRequest::frameLoadRequest):
(WebCore::PluginRequest::notifyData):
(WebCore::PluginRequest::sendNotification):
(WebCore::PluginRequest::shouldAllowPopups):

  • rendering/HitTestResult.cpp:
  • rendering/InlineFlowBox.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderEmbeddedObject.cpp:
  • rendering/RenderImage.cpp:
  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::RenderImageResource):
(WebCore):

  • rendering/RenderImageResource.h:

(WebCore::RenderImageResource::image):
(WebCore::RenderImageResource::errorOccurred):
(WebCore::RenderImageResource::usesImageContainerSize):
(WebCore::RenderImageResource::imageHasRelativeWidth):
(WebCore::RenderImageResource::imageHasRelativeHeight):
(WebCore::RenderImageResource::imageSize):

  • rendering/RenderImageResourceStyleImage.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerFilterInfo.h:

(WebCore):

  • rendering/RenderListItem.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderSnapshottedPlugIn.cpp:
  • rendering/RenderTableCol.cpp:
  • rendering/RenderTableRow.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/style/StyleCachedShader.h:
  • rendering/style/StyleCustomFilterProgram.cpp: Removed.
  • rendering/style/StyleCustomFilterProgram.h:

(WebCore):
(WebCore::StyleCustomFilterProgram::vertexShaderString):
(StyleCustomFilterProgram):
(WebCore::StyleCustomFilterProgram::fragmentShaderString):
(WebCore::StyleCustomFilterProgram::isLoaded):
(WebCore::StyleCustomFilterProgram::willHaveClients):
(WebCore::StyleCustomFilterProgram::didRemoveLastClient):
(WebCore::StyleCustomFilterProgram::notifyFinished):

  • svg/SVGFEImageElement.h:
  • svg/SVGFontFaceUriElement.h:

(SVGFontFaceUriElement):

  • svg/SVGImageLoader.cpp:
  • svg/SVGUseElement.cpp:
  • svg/SVGUseElement.h:
  • svg/graphics/SVGImageCache.cpp:
  • testing/MockPagePopupDriver.cpp:
  • xml/XSLStyleSheet.h:

(WebCore):

  • xml/XSLTProcessorLibxslt.cpp:
  • xml/parser/XMLDocumentParser.cpp:
  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:
  • src/AssociatedURLLoader.cpp:
  • src/EditorClientImpl.cpp:
  • src/SharedWorkerRepository.cpp:
  • src/WebDataSourceImpl.cpp:
  • src/WebFrameImpl.h:

(WebCore):

  • src/WebNode.cpp:
  • src/WebSharedWorkerImpl.cpp:
  • tests/FrameLoaderClientImplTest.cpp:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • ewk/ewk_frame.cpp:

Source/WebKit/gtk:

  • webkit/webkitwebpolicydecision.cpp:

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm:
  • Misc/WebNSPasteboardExtras.mm:
  • WebCoreSupport/WebFrameNetworkingContext.mm:
  • WebView/WebRenderLayer.mm:
  • WebView/WebRenderNode.mm:

Source/WebKit/qt:

  • WebCoreSupport/NotificationPresenterClientQt.cpp:
  • WebCoreSupport/QWebPageAdapter.cpp:

Source/WebKit2:

  • NetworkProcess/HostRecord.h:
  • NetworkProcess/NetworkResourceLoadScheduler.h:
  • NetworkProcess/NetworkResourceLoader.h:

(WebCore):

  • Shared/WebRenderLayer.cpp:
  • Shared/WebRenderObject.cpp:
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/WebProcess.cpp:
  • WebProcess/soup/WebProcessSoup.cpp:
12:56 AM Changeset in webkit [144564] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

WebKit API for enabling DOM logging for certain worlds
​https://bugs.webkit.org/show_bug.cgi?id=110779

Patch by Ankur Taly <​ataly@google.com> on 2013-03-03
Reviewed by Kentaro Hara.

  • WebKit.gyp:
12:52 AM Changeset in webkit [144563] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Remove TranslateParameter() from CodeGeneratorV8.pm
​https://bugs.webkit.org/show_bug.cgi?id=111218

Reviewed by Adam Barth.

TranslateParameter() does nothing. It tries to convert TimeoutHandler to DOMString,
but there is no non-custom method that uses TimeoutHandler.

The only place where TimeoutHandler is used in the WebKit IDL is setTimeout() and setInterval().
However, the latest spec uses 'any' instead of TimeoutHandler.
​http://dev.w3.org/html5/spec-LC/timers.html
Thus, this patch updates the IDL declarations of setTimeout() and setInterval()
according to the spec. By this change, TimeoutHandler is gone away from the WebKit IDL.
(Anyway this IDL change has no effect, because setTimeout() and setInterval() are written
in custom bindings.)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:
12:46 AM Changeset in webkit [144562] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
​https://bugs.webkit.org/show_bug.cgi?id=85642

Source/WebCore:

Add missing key mappings for GDK_KP_Begin, GDK_KP_Insert, GDK_KP_Delete and GDK_ISO_Level3_Shift.

Patch by James Weatherall <​wez@chromium.org> on 2013-03-03
Reviewed by Adam Barth.

  • platform/chromium/KeyCodeConversionGtk.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

Source/WebKit/chromium:

Add tests to verify that the fixed keys generate the same keyCode values as their equivalents.

Patch by James Weatherall <​wez@chromium.org> on 2013-03-03
Reviewed by Adam Barth.

  • WebKit.gypi:
  • tests/KeyCodeConversionTestGtk.cpp: Added.

(WebCore):
(WebCore::TEST):

12:33 AM Changeset in webkit [144561] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

REGRESSION(144520): Does not compile on chromium-win
​https://bugs.webkit.org/show_bug.cgi?id=111261

Unreviewed rollout of ​http://trac.webkit.org/changeset/144520. This
patch does not compile for chromium-win. See the bug for the compile
error.

  • rendering/ExclusionShapeInsideInfo.cpp:
  • rendering/ExclusionShapeInsideInfo.h:

(WebCore):
(LineSegmentRange):
(WebCore::LineSegmentRange::LineSegmentRange):
(WebCore::ExclusionShapeInsideInfo::isEnabledFor):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::exclusionShapeInsideInfo):
(WebCore):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):

  • rendering/RenderBlock.h:

(WebCore):
(RenderBlock):
(RenderBlockRareData):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRunsForLine):

Mar 2, 2013:

11:31 PM Changeset in webkit [144560] by beidson@apple.com
  • 10 edits in branches/safari-534.59-branch

Merge r143790

2013-02-22 Anders Carlsson <​andersca@apple.com>

Source/WebKit2:

Move pluginLoadPolicy to the page loader client
​https://bugs.webkit.org/show_bug.cgi?id=110635
<rdar://problem/13265303>


Reviewed by Sam Weinig.

Move the pluginLoadPolicy callback to the page loader client where it belongs.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebLoaderClient::pluginLoadPolicy):
  • UIProcess/WebLoaderClient.h: (WebLoaderClient):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
  • UIProcess/WebUIClient.cpp: (WebKit):
  • UIProcess/WebUIClient.h: (WebUIClient):
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools:

Move pluginLoadPolicy to the page loader client
​https://bugs.webkit.org/show_bug.cgi?id=110635

Reviewed by Sam Weinig.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
11:13 PM Changeset in webkit [144559] by zandobersek@gmail.com
  • 4 edits in trunk

REGRESSION (r144517): IndexedDB layout test failures on GTK
​https://bugs.webkit.org/show_bug.cgi?id=111243

Reviewed by Martin Robinson.

Source/WebCore:

Changes to the custom JSC bindings for IDBAny are required after r144517,
specifically the case of IDBAny object having the KeyPathType type has to be covered.
These changes are analogous to those made to the V8 bindings in the mentioned commit.

No new tests - already covered by existing tests.

  • bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS): A helper function that wraps an IDBKeyPath into a JSValue.
(WebCore): Shuffle the order inside the switch statement a bit to match the V8 custom bindings.
Cover the case where the IDBAny object has the KeyPathType, calling the new helper method.

LayoutTests:

  • platform/gtk/TestExpectations: Removing failure expectations for IDB tests that again pass.
10:59 PM Changeset in webkit [144558] by beidson@apple.com
  • 4 edits
    2 adds in branches/safari-534.59-branch

Merge r142919

2013-02-14 Anders Carlsson <​andersca@apple.com>

Add WKContextIsPlugInUpdateAvailable
​https://bugs.webkit.org/show_bug.cgi?id=109862
<rdar://problem/13173140>

Reviewed by Sam Weinig.

Source/WebKit2:

  • UIProcess/API/C/mac/WKContextPrivateMac.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.cpp. (WKContextGetProcessSuppressionEnabled): (WKContextSetProcessSuppressionEnabled): (WKContextIsPlugInUpdateAvailable):
  • WebKit2.xcodeproj/project.pbxproj:

WebKitLibraries:

Roll WebKitSystemInterface DEPS.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
10:55 PM Changeset in webkit [144557] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Another try at fixing the build.

10:33 PM Changeset in webkit [144556] by beidson@apple.com
  • 9 edits in branches/safari-534.59-branch/Source/WebKit2

Merge r142017

2013-02-06 Anders Carlsson <​andersca@apple.com>

Pass the document source URL to the pluginLoadPolicy callback
​https://bugs.webkit.org/show_bug.cgi?id=109084
<rdar://problem/13154516>

Reviewed by Andreas Kling.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
  • UIProcess/WebPageProxy.h: (WebPageProxy):
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::pluginLoadPolicy):
  • UIProcess/WebUIClient.h: (WebUIClient):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
10:31 PM Changeset in webkit [144555] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix build.

10:24 PM Changeset in webkit [144554] by beidson@apple.com
  • 5 edits in branches/safari-534.59-branch/Source/WebKit2

Merge r141923

2013-02-05 Anders Carlsson <​andersca@apple.com>

WebKit clients should be able to override loading of blocked plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=108968
<rdar://problem/13154516>

Reviewed by Sam Weinig.

Replace the shouldInstantiatePlugin callback with a new pluginLoadPolicy which is called regardless
of whether the plug-in is blocked or not. This lets clients override the plug-in load policy and
force loading of blacklisted plug-ins (and vice versa).

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
  • UIProcess/WebUIClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebUIClient::pluginLoadPolicy):
  • UIProcess/WebUIClient.h: (WebUIClient):
9:55 PM Changeset in webkit [144553] by Darin Adler
  • 16 edits in trunk/Source

Cut down the number of source files that depend on Clipboard.h
​https://bugs.webkit.org/show_bug.cgi?id=110030

Reviewed by Ryosuke Niwa.

Source/WebCore:

I am doing some work on Clipboard and it's better to recompile 50 files
each time we touch the header instead of 700. Also cut down on includes
of DragState.h.

  • WebCore.exp.in: Updated for new MouseEvent::create function.
  • dom/ClipboardEvent.cpp: Added include of Clipboard.h since we use it

here and the world no longer includes it everywhere.

  • dom/ClipboardEvent.h: Forward declared Clipboard instead of including

Clipboard.h. Also made some overrides private because they can be.

  • dom/DataTransferItem.h: Removed unneeded include of Clipboard.h.
  • dom/MouseEvent.cpp: Added include of Clipboard.h since we use it

here and the world no longer includes it everywhere.
(WebCore::MouseEvent::create): Made the create function non-inline
since we can't compile it without including Clipboard.h and we don't
want to include Clipboard.h in the header. This is not so commonly
used or so hot that this needs to be inlined.

  • dom/MouseEvent.h: Forward declared Clipboard instead of including

Clipboard.h. Made MouseEvent::create a non-inline function and also
used overloading instead of default arguments, since we can't compile
a default argument of type PassRefPtr<Clipboard> without including
Clipboard.h.

  • dom/WheelEvent.cpp: Added include of Clipboard.h since we use it

here and the world no longer includes it everywhere.

  • dom/WheelEvent.h: Forward declare PlatformWheelEvent since it is used

in this header. Previously we'd get it indirectly from including a header
that included Clipboard.h.

  • editing/Editor.cpp: Added include of Clipboard.h since we use it here

and the world no longer includes it everywhere.

  • inspector/InspectorDebuggerAgent.cpp: Added include of CachedResource.h.

We used to get this indirectly through Clipboard.h.

  • inspector/InspectorFrontendHost.cpp: Added includes of ResourceError.h

and ResourceResponse.h. We used to get these indirectly through Clipboard.h.
Also removed unneeded include of <wtf/RefPtr.h>.

  • inspector/NetworkResourcesData.cpp: Added include of CachedResource.h.

We used to get this indirectly through Clipboard.h.

  • loader/PingLoader.cpp: Added include of ResourceResponse.h.

We used to get this indirectly through Clipboard.h.

  • page/DragController.cpp: Added include of DragState.h.

We used to get this indirectly through EventHandler.h

  • page/EventHandler.h: Forward declared DragState and Element instead of

including DragState.h. Also added an include of LayoutPoint.h, which we
used to get indirectly through DragState.h.

Source/WebKit/chromium:

  • src/SharedWorkerRepository.cpp: Add include of ResourceResponse.h

here. We used to get this indirectly through Clipboard.h.

Source/WebKit/mac:

  • WebView/WebPDFView.mm: Add include of Clipboard.h since we use it

here and the world no longer includes it everywhere.

9:47 PM Changeset in webkit [144552] by Darin Adler
  • 13 edits
    1 add in trunk

StringHasher functions require alignment that call sites do not all guarantee
​https://bugs.webkit.org/show_bug.cgi?id=110171

Reviewed by Benjamin Poulain.

Source/WebCore:

  • platform/graphics/WidthCache.h:

(WebCore::WidthCache::SmallStringKey::SmallStringKey): Use the newly added
addCharactersAssumingAligned to make sure we don't slow this call site down.
It's safe since this code always adds characters two at a time.

Source/WTF:

The StringHasher class is optimized for clients who pass it two characters at
a time. However, the function named addCharacters did not make this clear to
clients, and one calculateStringHashAndLengthFromUTF8MaskingTop8Bits got it wrong.
Fix by making addCharacters work regardless of hasher alignment and adding a new
function, addCharactersAssumingAligned, for use when we want a faster path and can
guarantee we are adding characters two at a time.

  • wtf/StringHasher.h:

(WTF::StringHasher::addCharactersAssumingAligned): Renamed the addCharacters function
addCharactersAssumingAligned, since it only works if the hasher is currently aligned,
meaning it contains an even number of characters. The function already asserts
that this is true, but the calculateStringHashAndLengthFromUTF8MaskingTop8Bits
function was using it in cases where the assertion could fire. Also updated to
call addCharactersInternal by its new name. Also added some new overloads that take
data pointers and lengths so callers can always use addCharactersAssumingAligned
instead of addCharacters if they know the hasher is aligned.
(WTF::StringHasher::addCharacter): Updated to call the public
addCharactersAssumingAligned function since that's simpler and a bit cleaner.
(WTF::StringHasher::addCharacters): Added functions with this name that handle
the case where the hasher is not aligned. These will be called by existing call sites
that were formerly using the function named addCharactersAssumingAligned above.
Also add an overload that works with the default converter automatically.
(WTF::StringHasher::computeHashAndMaskTop8Bits): Changed to call
addCharactersAssumingAligned to eliminate copied and pasted code. The hasher is empty,
so definitely aligned.
(WTF::StringHasher::computeHash): Ditto.
(WTF::StringHasher::addCharactersInternal): Renamed from addCharactersToHash, since
the former name did not make clear how this differs from the public functions.
The real difference is that this is like addCharactersAssumingAligned, but without
the assertion, so addCharactersAssumingAligned is called instead, even within the
class's implementation.

Tools:

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/WTF.pro:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Added the StringHasher.cpp file.

  • TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests

for the functions in the StringHasher class.

8:05 PM Changeset in webkit [144551] by beidson@apple.com
  • 19 edits
    1 add in branches/safari-534.59-branch

Merge r141486

2013-01-31 Brian Weinstein <​bweinstein@apple.com>

Add a call to the page UI client to determine if a plug-in should load
​https://bugs.webkit.org/show_bug.cgi?id=108407
<rdar://problem/13066332>

Source/WebKit2:

Reviewed by Anders Carlsson.

This patch adds a client call to the WKPageUIClient to be called to determine
whether or not a plug-in should load.

  • UIProcess/API/C/WKPage.h: Add shouldLoadPlugin.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): Moved from WebProcessProxy, and added a call to

m_uiClient.shouldInstantiatePlugin.

  • UIProcess/WebPageProxy.h:
  • UIProcss/WebPageProxy.messages.in: Moved GetPluginPath from WebProcessProxy to WebPageProxy.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getPluginPath): Moved to WebPageProxy.
  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::shouldInstantiatePlugin): Return that we should load the plug-in if

the client function isn't defined, and call the function if it is.

  • UIProcess/WebUIClient.h:
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Add an entry for the new

client function.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Send the message to the WebPageProxy, not the WebProcessProxy. (WebKit::WebPage::canPluginHandleResponse): Made a member function, so it can call sendSync, and

send the message to the WebPageProxy, not the WebProcessProxy.

  • WebProcess/WebPage/WebPage.h:

Tools:

Add entries for the new function in the necessary structs.

Reviewed by Anders Carlsson.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
6:53 PM Changeset in webkit [144550] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

WebKit2 is missing the setShowsURLsInToolTips preference
​https://bugs.webkit.org/show_bug.cgi?id=111259
<rdar://problem/12991891>

Reviewed by Maciej Stachowiak.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetShowsURLsInToolTipsEnabled):
(WKPreferencesGetShowsURLsInToolTipsEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe it through.

5:45 PM Changeset in webkit [144549] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

XSSAuditor has a subtle race condition when used with the threaded HTML parser
​https://bugs.webkit.org/show_bug.cgi?id=111253

Reviewed by Eric Seidel.

We were refing and derefing a StringImpl for a main-thread
AtomicString. Using QualifiedNames on the background thread is very
fragile and we should figure out a more robust solution.

  • html/parser/XSSAuditor.cpp:

(WebCore::findAttributeWithName):

4:57 PM Changeset in webkit [144548] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Export a missing symbol after r144547.

Unreviewed.

  • WebKit.vcproj/WebKitExports.def.in:
4:08 PM Changeset in webkit [144547] by benjamin@webkit.org
  • 47 edits in trunk

Move computedStyleIncludingVisitedInfo from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=109772

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-03-02
Reviewed by Andreas Kling.

Source/WebCore:

The function computedStyleIncludingVisitedInfo() is purely internal to WebCore,
it is better defined on Internals than on TestRunner.

  • testing/Internals.cpp:

(WebCore::Internals::computedStyleIncludingVisitedInfo):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/blackberry:

  • WebKitSupport/DumpRenderTreeSupport.cpp:
  • WebKitSupport/DumpRenderTreeSupport.h:

(DumpRenderTreeSupport):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:
  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

Tools:

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Update the tests.

  • fast/history/multiple-classes-visited.html:
  • fast/history/nested-visited-test.html:
  • fast/history/self-is-visited.html:
  • fast/history/sibling-visited-test.html:
  • fast/loader/stateobjects/state-url-sets-links-visited.html:
  • platform/win/TestExpectations: unskip the tests.
  • platform/chromium/TestExpectations:
3:42 PM Changeset in webkit [144546] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r143637): Export ScriptController::javaScriptContext() on iOS
<​http://webkit.org/b/106059>

Fixes the following build failure:

Undefined symbols for architecture armv7:

"ZN7WebCore16ScriptController17javaScriptContextEv", referenced from:

-[WebFrame javaScriptContext] in WebFrame.o
ZN20WebFrameLoaderClient35dispatchDidClearWindowObjectInWorldEPN7WebCore15DOMWrapperWorldE in WebFrameLoaderClient.o

ld: symbol(s) not found for architecture armv7

  • WebCore.exp.in: Export ScriptController::javaScriptContext()

even more unconditionally.

3:36 PM Changeset in webkit [144545] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

BUILD FIX (r143637): Predeclare JSContext as an Objective-C class
<​http://webkit.org/b/106059>

Fixes the following build failure:

In file included from Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m:11:
In file included from Source/WebKit/mac/WebView/WebFrameLoadDelegatePrivate.h:29:
Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:215:64: error: expected a type

  • (void)webView:(WebView *)webView didCreateJavaScriptContext:(JSContext *)context forFrame:(WebFrame *)frame;


1 error generated.

  • WebView/WebFrameLoadDelegate.h: Add @class JSContext

declaration.

1:06 PM Changeset in webkit [144544] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove two unnecessary mallocs from the main-thread-parser code path
​https://bugs.webkit.org/show_bug.cgi?id=111249

Reviewed by Adam Barth.

I noticed these while fixing up our Vector -> String conversions
but never went back to fix the FIXME.

AtomicString(Vector<UChar, capacity>) is smart enough to avoid mallocing
if the represented string is already in the AtomicString table. It
also handles 8bit vs. 16bit and empty() just like nameString() does.

I also removed a 3rd caller to nameString() in the XSSAuditor which
was causing an unnecessary malloc in both the main and background
thread parser paths.

  • html/parser/AtomicHTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLToken.h:
  • html/parser/XSSAuditor.cpp:

(WebCore):
(WebCore::threadSafeMatch):
(WebCore::hasName):

10:09 AM Changeset in webkit [144543] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

constructTreeFromCompactHTMLToken should call clearExternalCharacters
​https://bugs.webkit.org/show_bug.cgi?id=111248

Reviewed by Adam Barth.

I don't know how to write a test for this. It's possible characters()
is never accessed from HTMLStackItem::token(), but it's better to be
safe than sorry here.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):

7:02 AM Changeset in webkit [144542] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

Text overflow ellipsis wrong color when using webkit-text-fill-color
​https://bugs.webkit.org/show_bug.cgi?id=54841

Reviewed by David Hyatt.

Source/WebCore:

Take -webkit-text-fill-color into account for ellipsis painting.

Test: fast/css/text-overflow-ellipsis-color.html

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):

LayoutTests:

Add reftest for using -webkit-text-fill-color in combination with text-overflow:ellipsis.

  • fast/css/text-overflow-ellipsis-color-expected.html: Added.
  • fast/css/text-overflow-ellipsis-color.html: Added.
6:39 AM Changeset in webkit [144541] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip some passing tests.

  • platform/efl/TestExpectations: Remove tests that pass after

r140006 and r139217.

4:36 AM Changeset in webkit [144540] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebKit/win

Redo r144538 (after r144530).

  • WebCoreSupport/WebFrameNetworkingContext.cpp:
  • WebCoreSupport/WebFrameNetworkingContext.h:
  • WebCoreSupport/WebPlatformStrategies.cpp:
3:59 AM Changeset in webkit [144539] by tkent@chromium.org
  • 10 edits in branches/chromium/1410

Merge 144352

REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
​https://bugs.webkit.org/show_bug.cgi?id=110974

Reviewed by Kentaro Hara.

Source/WebCore:

Input elements with the multiple fields UI require flexible box
layout.

  • If display:inline or display:inline-block is specified, we replace it with display:inline-flex.
  • If display:block is specified, we replace it with display:flex.
  • If other display value is specified, we use it as is, but it won't wrap inside an input element because we have display:inline-block for ::-webkit-calendar-pixker-indicaotor.

r144184 was incomplete. It avoided the wrapping issue, but it
didn't make spin buttons and calendar arrows right-aligned.

Tests: Update fast/forms/date/date-apparance-basic.html

  • css/html.css:

(input::-webkit-calendar-picker-indicator):
Add display:inline-block in orde to avoid line-wrapping.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::customStyleForRenderer):
Move the code to BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer.

  • html/InputType.cpp:

(WebCore::InputType::customStyleForRenderer): Added.

  • html/InputType.h:

(InputType): Add customStyleForRenderer, and remove
shouldApplyLocaleDirection.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer):
Moved the code from HTMLInputElement::customStyleForRenderer, and
add display property updatting code.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):
Add customStyleForRenderer, and remove shouldApplyLocaleDirection.

LayoutTests:

  • fast/forms/date/date-appearance-basic-expected.txt:
  • fast/forms/date/date-appearance-basic.html:
  • platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium/TestExpectations:

TBR=​tkent@chromium.org
BUG=crbug.com/178175

2:14 AM Changeset in webkit [144538] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit/win

Yet another build fix attempt after r144530.

  • WebCoreSupport/WebFrameNetworkingContext.cpp:
  • WebCoreSupport/WebPlatformStrategies.cpp:
1:54 AM Changeset in webkit [144537] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Another build fix attempt after r144530.

  • WebCoreSupport/WebFrameNetworkingContext.cpp:
1:07 AM Changeset in webkit [144536] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a typo in my previous commit (r144534).

  • platform/win/PasteboardWin.cpp:
1:02 AM Changeset in webkit [144535] by nayankk@motorola.com
  • 22 edits
    2 copies
    5 adds in trunk

[WebGL] Support for texImage2D of type HALF_FLOAT_OES with ArrayBufferView.
​https://bugs.webkit.org/show_bug.cgi?id=110818

Reviewed by Kenneth Russell.

As per OES_texture_half_float specification texImage2D and texSubImage2D entry
points taking ArrayBufferView should extended to accept null with the pixel type
HALF_FLOAT_OES.

Source/WebCore:

Tests: fast/canvas/webgl/oes-texture-half-float-not-supported.html

fast/canvas/webgl/oes-texture-half-float.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/OESTextureHalfFloat.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebCore::OESTextureHalfFloat::OESTextureHalfFloat):
(WebCore::OESTextureHalfFloat::~OESTextureHalfFloat):
(WebCore::OESTextureHalfFloat::getName):
(WebCore::OESTextureHalfFloat::create):

  • html/canvas/OESTextureHalfFloat.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(OESTextureHalfFloat):

  • html/canvas/OESTextureHalfFloat.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncData):

  • html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

  • html/canvas/WebGLRenderingContext.idl:
  • platform/graphics/Extensions3D.h:

(Extensions3D):

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsTypes3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::texImage2D):

LayoutTests:

  • fast/canvas/webgl/constants.html:
  • fast/canvas/webgl/oes-texture-half-float-expected.txt: Added.
  • fast/canvas/webgl/oes-texture-half-float-not-supported-expected.txt: Added.
  • fast/canvas/webgl/oes-texture-half-float-not-supported.html: Added.
  • fast/canvas/webgl/oes-texture-half-float.html: Added.
12:57 AM Changeset in webkit [144534] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Windows build fix attempt after r144530.

  • platform/win/PasteboardWin.cpp:

Mar 1, 2013:

11:52 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
11:51 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Update roadmap (diff)
11:46 PM Changeset in webkit [144533] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the build after r144530.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Include the header for the

base class.

11:00 PM Changeset in webkit [144532] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for IndexedDB tests

that regressed on platforms using JavaScriptCore with r144517.

10:41 PM Changeset in webkit [144531] by tdanderson@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused member variable m_useLatchedEventNode from PlatformWheelEvent.h
​https://bugs.webkit.org/show_bug.cgi?id=107314

Reviewed by Darin Adler.

EventHandler::handleGestureScrollCore() was removed in ​http://trac.webkit.org/changeset/140177,
and this was the only place where the member variable |m_useLatchedEventNode| in
PlatformWheelEvent was mutated. This variable is no longer needed and so it should be removed.

No change in behavior, so no new tests needed.

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::useLatchedEventNode):
(PlatformWheelEvent):

10:36 PM Changeset in webkit [144530] by ap@apple.com
  • 208 edits
    7 adds in trunk/Source

Reduce amount of rebuilding when touching networking headers
​https://bugs.webkit.org/show_bug.cgi?id=111035

Reviewed by Eric Seidel.

This uses a number of common unsurprising techniques. One interesting observation
is that including CachedResource related headers is very expensive. We can usually
get away with their Client counterparts, and with CachedResourceHandle.

  • page/Frame.cpp:
  • page/Frame.h: Don't include FrameLoader, greatly reducing include graph for most non-loader files. This required making Frame::init() non-inline - I'm not sure why it ever was.
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h: Even though FrameLoader is logically on loading side of WebCore, it's included in too many places. Not including PolicyChecker.h and ResourceHandle.h was among the largest wins. As a future improvement, we should probably convert other members to OwnPtrs.
  • css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a definition of a class it holds, but default construction does not.
  • loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h, not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
  • loader/cache/CachedFont.h:
  • loader/cache/CachedFontClient.h: Added.
  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedRawResourceClient.h: Added.
  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedSVGDocumentClient.h: Added. These types were defining client types in the same headers, making it impossible to avoid including networking headers through CachedResource. Moved clients into separate files.
  • plugins/PluginStream.h:
  • plugins/PluginStreamClient.h: Added. Similar situation here.
  • loader/cache/CachedResourceHandle.cpp:
  • loader/cache/CachedResourceHandle.h: Moved functions that need to know about CachedResource to .cpp file. This is another huge win. Added a destructor, so that CachedResource woudn't be needed in all files that include CachedResourceHandle.
  • loader/cache/CachedSVGDocumentReference.cpp: Added.
  • loader/cache/CachedSVGDocumentReference.h: Moved constructor and virtual function implementations to a .cpp file - they need not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
  • platform/graphics/filters/FilterOperation.cpp:
  • platform/graphics/filters/FilterOperation.h: Avoid including CachedSVGDocumentReference.h. This is not such a big win now that CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly rendering code that it seems best to cut any ties with resources and loading. Added a virtual destrutor in .cpp file, because inline destructors in polymorphic classes are generally harmful (due to code bloat).
  • plugins/PluginRequest.h: Added.
  • plugins/PluginView.h: Moved PluginRequest into a separate file, it was out of place in a view hierarchy class file.
  • rendering/RenderImageResource.cpp:
  • rendering/RenderImageResource.h: Moved definitions of virtual functions to a .cpp file. Thre is no win from having them inline, and now we don't need CachedImage.h in the header.
  • rendering/style/StyleCustomFilterProgram.cpp: Added.
  • rendering/style/StyleCustomFilterProgram.h: Ditto.
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCPeerConnection.cpp:
  • Modules/notifications/Notification.cpp:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp:
  • bindings/js/JSNodeCustom.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptSourceCode.h:
  • bindings/objc/DOM.mm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:
  • css/WebKitCSSSVGDocumentValue.cpp:
  • css/WebKitCSSSVGDocumentValue.h:
  • dom/Clipboard.cpp:
  • dom/ContainerNode.cpp:
  • dom/DOMImplementation.cpp:
  • dom/PendingScript.h:
  • dom/ScriptElement.cpp:
  • dom/ScriptElement.h:
  • history/CachedFrame.cpp:
  • html/DOMURL.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAppletElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLHtmlElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/ImageDocument.cpp:
  • html/ImageInputType.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLParserOptions.cpp:
  • html/parser/HTMLScriptRunner.h:
  • html/parser/XSSAuditor.cpp:
  • html/parser/XSSAuditorDelegate.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorFileSystemAgent.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorPageAgent.cpp:
  • inspector/NetworkResourcesData.cpp:
  • inspector/NetworkResourcesData.h:
  • loader/CookieJar.cpp:
  • loader/CrossOriginAccessControl.cpp:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentThreadableLoader.h:
  • loader/ImageLoader.cpp:
  • loader/ImageLoader.h:
  • loader/LinkLoader.h:
  • loader/MainResourceLoader.cpp:
  • loader/MainResourceLoader.h:
  • loader/MixedContentChecker.cpp:
  • loader/PingLoader.cpp:
  • loader/PolicyChecker.h:
  • loader/ProgressTracker.cpp:
  • loader/SubframeLoader.cpp:
  • loader/SubresourceLoader.cpp:
  • loader/TextTrackLoader.cpp:
  • loader/TextTrackLoader.h:
  • loader/ThreadableLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheHost.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedStyleSheetClient.h:
  • loader/cache/MemoryCache.cpp:
  • loader/cache/MemoryCache.h:
  • loader/chromium/CachedRawResourceChromium.cpp:
  • loader/icon/IconController.cpp:
  • loader/icon/IconLoader.h:
  • loader/mac/ResourceLoaderMac.mm:
  • page/DOMWindowExtension.cpp:
  • page/DragController.cpp:
  • page/PerformanceNavigation.cpp:
  • page/PerformanceTiming.cpp:
  • page/PointerLockController.cpp:
  • page/Settings.cpp:
  • page/animation/CSSPropertyAnimation.cpp:
  • platform/chromium/PasteboardChromium.cpp:
  • platform/efl/ErrorsEfl.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/gtk/ErrorsGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/gtk/PasteboardHelper.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/PasteboardMac.mm:
  • platform/network/AuthenticationChallengeBase.cpp:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/cf/ResourceRequestCFNet.cpp:
  • platform/network/mac/CookieStorageMac.mm:
  • platform/qt/PasteboardQt.cpp:
  • plugins/DOMMimeType.cpp:
  • plugins/PluginView.cpp:
  • rendering/HitTestResult.cpp:
  • rendering/InlineFlowBox.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderEmbeddedObject.cpp:
  • rendering/RenderImage.cpp:
  • rendering/RenderImageResourceStyleImage.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerFilterInfo.h:
  • rendering/RenderListItem.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderSnapshottedPlugIn.cpp:
  • rendering/RenderTableCol.cpp:
  • rendering/RenderTableRow.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/style/StyleCachedShader.h:
  • svg/SVGFEImageElement.h:
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGImageLoader.cpp:
  • svg/SVGUseElement.cpp:
  • svg/SVGUseElement.h:
  • svg/graphics/SVGImageCache.cpp:
  • testing/MockPagePopupDriver.cpp:
  • xml/XSLStyleSheet.h:
  • xml/XSLTProcessorLibxslt.cpp:
  • xml/parser/XMLDocumentParser.cpp:
  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp: Many self-evident changes - removing unnecessary header includes, adding smaller more local ones that are now necessary.
10:14 PM Changeset in webkit [144529] by hyatt@apple.com
  • 4 edits
    6 adds in trunk

[New Multicolumn] Transformed objects inside fragmented transparent objects don't render
​https://bugs.webkit.org/show_bug.cgi?id=111221.

Reviewed by Simon Fraser.

Source/WebCore:

Improve transparencyClipBox so that it understands when moving into descendants
that it does in fact have to break up the transformed clip rect across the
fragments.

Make sure when handling fragmented transforms using multiple paints that
the test that determines the extent of the transform within the fragments
uses transparencyClipBox. This gives us an accurate set of columns that the
final transformed result will paint across.

Tests: fast/multicol/mixed-opacity-fixed-test.html

fast/multicol/mixed-opacity-test.html
fast/multicol/transform-inside-opacity.html

  • rendering/RenderLayer.cpp:

(WebCore::transparencyClipBox):
(WebCore::expandClipRectForDescendantsAndReflection):
Break transformed boxes up into fragments when they are
being requested by an ancestor.

(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):

  • rendering/RenderLayer.h:

(RenderLayer):
Modify collectFragments so that we pass in the correct range
within the columns that can possibly cover the fragmented
transformed box.

LayoutTests:

  • fast/multicol/mixed-opacity-fixed-test-expected.html: Added.
  • fast/multicol/mixed-opacity-fixed-test.html: Added.
  • fast/multicol/mixed-opacity-test-expected.html: Added.
  • fast/multicol/mixed-opacity-test.html: Added.
  • fast/multicol/transform-inside-opacity-expected.html: Added.
  • fast/multicol/transform-inside-opacity.html: Added.
9:53 PM Changeset in webkit [144528] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove call to set task priority of WebKit2 processes on Mac
​https://bugs.webkit.org/show_bug.cgi?id=111239

Patch by Kiran Muppala <​cmuppala@apple.com> on 2013-03-01
Reviewed by Darin Adler.

Remove call to set task prioirty of WebKit2 processes on Mac as it
is no longer necessary.

  • Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::platformInitialize): Remove call to setpriority().

9:23 PM Changeset in webkit [144527] by loislo@chromium.org
  • 11 edits in trunk

Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
​https://bugs.webkit.org/show_bug.cgi?id=110943

Reviewed by Yury Semikhatsky.

Unfortunately in many cases raw pointer may point to an object that has been deleted.
There is no working solution to solve this problem in general.
It could be solved only on case by case basis.

Source/WebCore:

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportLeaf):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::reportMemoryUsage):

  • platform/graphics/BitmapImage.cpp:

(WebCore::FrameData::reportMemoryUsage):

  • platform/graphics/skia/MemoryInstrumentationSkia.cpp:

(reportMemoryUsage):

Source/WTF:

  • wtf/MemoryInstrumentation.h:

(WTF::MemoryInstrumentation::addObject):
(WTF::MemoryInstrumentation::MemberTypeTraits::addObject):
(WTF::MemoryClassInfo::addMember):
(WTF::MemoryInstrumentation::addObjectImpl):

  • wtf/MemoryInstrumentationString.h:

(WTF::reportMemoryUsage):

Tools:

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:

(TestWebKitAPI::TEST):

9:18 PM Changeset in webkit [144526] by haraken@chromium.org
  • 9 edits
    2 adds in trunk

Style recalculation takes too long when adding whitespace text nodes
​https://bugs.webkit.org/show_bug.cgi?id=110786

Reviewed by Darin Adler.

Source/WebCore:

This takes 216 msec.
for (var i = 0; i < 1500; ++i) {

document.body.appendChild(document.createTextNode('x'));
document.body.appendChild(document.createElement('div'));
document.body.appendChild(document.createTextNode('x'));

}

But this takes 25.3 seconds.
for (var i = 0; i < 1500; ++i) {

document.body.appendChild(document.createTextNode(' '));
document.body.appendChild(document.createElement('div'));
document.body.appendChild(document.createTextNode(' '));

}

The reason is that we do not create renderers for empty text
nodes and thus we are hitting the worst O(N2) case in Node::attach().
(See FIXME in Node::attach().)

This patch adds a logic to bail out the loop to avoid the O(N2) case.
Specifically, the patch bails out the loop if we encounter a text node
for which we again decided not to create a renderer. This bail out is
reasonable because the fact that we again decided not to create a renderer
for the text node indicates that there will be no affect of the result
of Text::textRendererIsNeeded() of the rest of the sibling nodes.

Performance test: ​https://bugs.webkit.org/attachment.cgi?id=190545
Performance result in Chromium/Linux: 25.3 sec => 48 msec !

Test: perf/append-text-nodes-without-renderers.html (for performance)

fast/dynamic/create-renderer-for-whitespace-only-text.html (for correctness)

The loop was introduced in r29054. We have to make sure that
all layout tests that were updated in r29054 pass with this patch.
See ​http://trac.webkit.org/changeset/29054.

  • dom/Node.cpp:

(WebCore::Node::attach):

LayoutTests:

  • fast/html/details-nested-2-expected.txt: Sometimes anonymous blocks are left without

being cleaned up (for some reason). With this patch, one anonymouse block is removed at
the clean-up phase (for some reason). Anyway the new behavior is an expected behavior.

  • platform/chromium-mac/fast/html/details-nested-2-expected.txt: Ditto.
  • platform/chromium-win/fast/html/details-nested-2-expected.txt: Ditto.
  • platform/efl/fast/html/details-nested-2-expected.txt: Ditto.
  • platform/mac/fast/html/details-nested-2-expected.txt: Ditto.
  • platform/qt/fast/html/details-nested-2-expected.txt: Ditto.
  • perf/append-text-nodes-without-renderers-expected.txt: Added. For performance test.
  • perf/append-text-nodes-without-renderers.html: Added. Ditto.
9:17 PM Changeset in webkit [144525] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Add a missing symbol after r144524.

Unreviewed.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-03-01

  • WebKit.vcproj/WebKitExports.def.in:
9:06 PM Changeset in webkit [144524] by commit-queue@webkit.org
  • 40 edits in trunk

Source/WebCore: Moved markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

TestRunner framework is an old way of testing webkit, it would be
better to incorporate the testing frame directly into the WebCore itself
as to make it more compatible with WK2.

  • testing/Internals.cpp:

(WebCore::Internals::markerTextForListItem):
(WebCore):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/efl: Move markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk: Move markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac: Move markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

  • DOM/WebDOMOperations.mm:
  • DOM/WebDOMOperationsPrivate.h:

Source/WebKit/qt: Move markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools: Move markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests: Move markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

  • fast/lists/resources/dump-list.js:

(dumpListItemAsHTML):
(testListItemMarkerEqualsListItemText):

  • fast/lists/w3-css3-list-styles-numeric.html:
7:44 PM Changeset in webkit [144523] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r185662. Requested by
"James Robinson" <​jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-01

  • DEPS:
6:35 PM Changeset in webkit [144522] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

Don't leak Documents when using MutationObserver from extensions
​https://bugs.webkit.org/show_bug.cgi?id=111234

Patch by Elliott Sprehn <Elliott Sprehn> on 2013-03-01
Reviewed by Adam Barth.

.:

  • ManualTests/leak-observer-nonmain-world.html: Added.

Source/WebCore:

MutationObserverCallback holds a WorldContextHandle which secretly isn't
a handle to anything when it's for the main world. When it's for a non-main
world though, like those used in extensions, it becomes a strong reference
to the v8::Context which results in leaks by creating cycles:

MutationObserver -> Callback -> World -> Document -> Node -> MutationObserver.

Instead we should keep a RefPtr to a DOMWrapperWorld in the callback and then
get the v8::Context from that inside handleEvent.

Tests: ManualTests/leak-observer-nonmain-world.html

  • bindings/v8/V8Binding.cpp:

(WebCore::toV8Context): Added overload that takes a DOMWrapperWorld.

  • bindings/v8/V8Binding.h:
  • bindings/v8/V8MutationCallback.cpp:

(WebCore::V8MutationCallback::V8MutationCallback):
(WebCore::V8MutationCallback::handleEvent):

  • bindings/v8/V8MutationCallback.h:

(V8MutationCallback):

5:31 PM Changeset in webkit [144521] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX: testapi should link to Foundation, not CoreFoundation

link to Foundation.framework instead of CoreFoundation.framework
since it uses NS types.

5:16 PM Changeset in webkit [144520] by betravis@adobe.com
  • 6 edits in trunk/Source/WebCore

[css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData
​https://bugs.webkit.org/show_bug.cgi?id=110995

Reviewed by Julien Chaffraix.

This patch moves ExclusionShapeInsideInfo into the RenderBlockRareData struct,
which enables us to move away from the global ExclusionShapeInsideInfo map.
Some additional refactoring was done to remove ExclusionShapeInsideInfo's
dependency on InlineIterator, which depended on RenderBlock. This work required
adding a new LineSegmentIterator struct.

Refactoring, no new tests.

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore):
(WebCore::LineSegmentRange::LineSegmentRange): Moving the InlineIterator
constructor to the .cpp file, as InlineIterator is now forward declared in
the .h file.
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Moving isEnabledFor to
the .cpp file, as RenderBlock is now forward declared in the .h file.

  • rendering/ExclusionShapeInsideInfo.h:

(WebCore):
(LineSegmentIterator): A simple struct for containing segment positions for
layout.
(WebCore::LineSegmentIterator::LineSegmentIterator): Constructor.
(LineSegmentRange): Transitioning to store LineSegmentIterator.
(WebCore::LineSegmentRange::LineSegmentRange): Ditto.
(ExclusionShapeInsideInfo):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed): Destroying a block will now destroy
its ExclusionShapeInsideInfo, so there is no need to remove it from the map.
(WebCore):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Use
the RenderBlockRareData struct rather than the global map.

  • rendering/RenderBlock.h:

(WebCore):
(WebCore::RenderBlock::ensureExclusionShapeInsideInfo): Ensure an info struct
is present if the shape-inside style is set.
(WebCore::RenderBlock::exclusionShapeInsideInfo): Look up the info struct for
the current block.
(WebCore::RenderBlock::setExclusionShapeInsideInfo): Update the info struct
for the current block.
(RenderBlockRareData): Add the ExclusionShapeInsideInfo member.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRunsForLine): Construct the appropriate offsets during
layout based on the stored LineSegmentIterators.

5:08 PM Changeset in webkit [144519] by tdanderson@chromium.org
  • 15 edits
    4 copies
    8 adds in trunk

EventHandler::handleGestureScrollUpdate() should invoke the user-generated scroll routines
so its behavior matches other user-initiated scrolls
​https://bugs.webkit.org/show_bug.cgi?id=109769

Reviewed by James Robinson.

Source/WebCore:

To ensure that the scrolling behavior of GestureScrollUpdate events are consistent with
the scrolling behavior of mousewheel events, use the existing user-generated scroll logic
instead of calling into RenderLayer::scrollByRecursively(). This patch fixes the bug
reported in ​https://bugs.webkit.org/show_bug.cgi?id=109316, where the example page can
be scrolled using touch but cannot be scrolled using mousewheels.

Note that this patch does not use any of the mousewheel event-handling code.

Tests: fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html

fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html
fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html
fast/events/touch/gesture/touch-gesture-noscroll-body.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollBegin):
(WebCore::EventHandler::handleGestureScrollUpdate):
(WebCore::EventHandler::sendScrollEventToView):

By calling this function at the start of handleGestureScrollUpdate() in the case
where |m_scrollGestureHandlingNode| is null, we ensure that the scroll updates
can still scroll the page itself, if possible.

(WebCore):
(WebCore::EventHandler::clearGestureScrollNodes):

  • page/EventHandler.h:

(EventHandler):

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::setHasPreciseScrollingDeltas):

Source/WebKit/chromium:

Clear the nodes corresponding to a fling scroll event when the event ends.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateAnimations):

LayoutTests:

Four new layout tests have been added and touch-gesture-scroll-page.html has been
modified to demonstrate that this patch fixes two existing bugs. See the inline
comments below for details.

Because I am now using the existing user-generated scroll logic, the delta for a single
GestureScrollUpdate event will not be propagated to the parent of the targeted node
unless the targeted node has no remaining scrollable area. So the changes to the
existing layout tests have been made to ensure that the targeted node has been fully
scrolled before subsequent GestureScrollUpdate events will scroll the parent(s) of
the targeted node.

I have also removed the function recordScroll() from the existing layout tests
because this function already exists in the included file resources/gesture-helpers.js.

  • fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
  • fast/events/touch/gesture/touch-gesture-noscroll-body.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
  • fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-div-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-div-twice-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-page-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-page.html:

I modified this layout test in order to add test coverage for another bug
which is fixed by this patch: if the hit test performed on a GestureScrollBegin
does not target a specific node, the subsequent GestureScrollUpdate events should
still attempt to scroll the page itself. This is consistent with how mousewheel
events behave.

  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.

These four new layout tests verify that a non-scrollable body will not scroll,
as reported in ​https://bugs.webkit.org/show_bug.cgi?id=109316.

5:05 PM Changeset in webkit [144518] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Revert r143827 to restore WebHelperPluginImpl's call to frameDetached()
​https://bugs.webkit.org/show_bug.cgi?id=111232

Patch by David Dorwin <​ddorwin@chromium.org> on 2013-03-01
Reviewed by Adam Barth.

This patch reverts r143827, which causes a crash in failure conditions:
​http://crbug.com/178848

  • src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::destoryPage):

5:04 PM Changeset in webkit [144517] by alecflett@chromium.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Avoid ScriptValue copies in IDBAny
​https://bugs.webkit.org/show_bug.cgi?id=111002

Reviewed by Adam Barth.

This avoids some v8 handle thrashing in the long term,
and protects us against some crashes in the short term.

The crashes will be fixed in
​https://bugs.webkit.org/show_bug.cgi?id=110206.

  • Modules/indexeddb/IDBAny.cpp:

(WebCore::IDBAny::createNull):
(WebCore::IDBAny::createString):
(WebCore::IDBAny::IDBAny):
(WebCore::IDBAny::scriptValue):

  • Modules/indexeddb/IDBAny.h:

(WebCore::IDBAny::create):
(IDBAny):
(WebCore::IDBAny::keyPath):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):
(WebCore):

5:01 PM Changeset in webkit [144516] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening of AppleWin port.

  • platform/win/TestExpectations:
5:00 PM Changeset in webkit [144515] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Upstream smart selection
​https://bugs.webkit.org/show_bug.cgi?id=111226

Patch by Iris Wu <​shuwu@rim.com> on 2013-03-01
Reviewed by Rob Buis.

  1. Extend the touch hold text selection to next paragraph.
  2. Draw and expand overlay over text as touch hold selection expands.

Select paragraph when it's entirely covered by overlay.

  1. Start scrolling at a constant rate when the end of

next pargraph is not in the viewport.

Reviewed Internally By Genevieve Mak and Mike Fenton.
PR 217897 238485 258279 279042 299779

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::selectAtDocumentPoint):
(BlackBerry::WebKit::WebPage::expandSelection):
(WebKit):
(BlackBerry::WebKit::WebPage::setOverlayExpansionPixelHeight):
(BlackBerry::WebKit::WebPagePrivate::setOverlayExpansionPixelHeight):
(BlackBerry::WebKit::WebPage::setParagraphExpansionPixelScrollMargin):

  • Api/WebPage.h:
  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::isInvalidLine):
(WebKit):
(BlackBerry::WebKit::isInvalidParagraph):
(BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
(BlackBerry::WebKit::SelectionHandler::drawOverlay):
(BlackBerry::WebKit::SelectionHandler::findNextOverlayRegion):
(BlackBerry::WebKit::SelectionHandler::expandSelection):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
(BlackBerry::WebKit::SelectionHandler::setParagraphExpansionScrollMargin):
(BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):

  • WebKitSupport/SelectionHandler.h:

(SelectionHandler):
(BlackBerry::WebKit::SelectionHandler::setOverlayExpansionHeight):

4:55 PM Changeset in webkit [144514] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening of AppleWin port.

  • platform/win/TestExpectations:
3:46 PM Changeset in webkit [144513] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening of AppleWin port.

  • platform/win/TestExpectations:
3:22 PM Changeset in webkit [144512] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark some software compositing tests as failing before landing anti-aliasing changes
​https://bugs.webkit.org/show_bug.cgi?id=111224

  • platform/chromium/TestExpectations:
3:05 PM Changeset in webkit [144511] by beidson@apple.com
  • 14 edits in branches/safari-536.29-branch

Merge 143988

2013-02-25 Anders Carlsson <​andersca@apple.com>

Source/WebKit2:

Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110821

Reviewed by Beth Dakin.

  • UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationPluginspageAttributeURLKey): (WKPageGetPluginInformationPluginURLKey): Add two new API key getters.


  • UIProcess/API/C/WKPage.h: Add a new callback and deprecate the old callback.


  • UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy): Make the pluginInformationDictionary a static member function of WebPageProxy so it can be called from WebUIClient as well.


  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): Pass the bundle version as well.

(WebKit::WebPageProxy::pluginInformationPluginspageAttributeURLKey):
(WebKit::WebPageProxy::pluginInformationPluginURLKey):
Add two new keys.

(WebKit::WebPageProxy::pluginInformationDictionary):
Handle more keys.

(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Get the plug-in bundle identifier and version.

  • UIProcess/WebPageProxy.messages.in: Pass along more information; the frame and page URLs.
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::unavailablePluginButtonClicked): Call the new callback if it's supported.
  • UIProcess/WebUIClient.h: (WebUIClient):
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Update for API changes.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked): Ensure that the pluginspage attribute is a valid URL.

Tools:

Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110821
<rdar://problem/13265303>

Reviewed by Beth Dakin.

Update for WebKit2 changes.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::unavailablePluginButtonClicked):
  • WebKitTestRunner/TestController.h: (TestController):
2:55 PM Changeset in webkit [144510] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Don't use legacy test names when returning results from PerfTest.run
​https://bugs.webkit.org/show_bug.cgi?id=111148

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTestMetric.name): Renamed from metric.
(PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
(PerfTest.run): Use metric name instead of the legacy name to store iteration values.
(ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTestMetric.test_init_set_time_metric):
(TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
(TestReplayPerfTest.test_run_with_driver_accumulates_results):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init):
(PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
to obtain the trac URL instead of hard coding it.
(PerfTestsRunner._run_tests_set):

2:53 PM Changeset in webkit [144509] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark more flaky tests related to scrollbar ordering
​https://bugs.webkit.org/show_bug.cgi?id=111199

Unreviewed gardening.

  • platform/chromium/TestExpectations:
2:42 PM Changeset in webkit [144508] by vcarbune@chromium.org
  • 4 edits
    2 adds in trunk

Support padding, margin and border for internal UA cue styling
​https://bugs.webkit.org/show_bug.cgi?id=110703

Reviewed by Eric Carlson.

Source/WebCore:

For some particular user agent styling this allows the possibility
of making the window around the cue text bigger to match some user
styles (see CaptionUserPreferencesMac::captionsStyleSheetOverride).

These properties *cannot* be set through by using the ::cue
pseudo-element and, as specified, are used only internally.

Note: This patch is identical to the previously commited one,
as it was rolled back without related tests failing.

Test: media/track/track-cue-rendering-with-padding.html

  • css/mediaControls.css:

(video::-webkit-media-text-track-display): Set the CSS box model
to include in the specified width or height the values of
padding / margin / border by using -webkit-box-sizing and avoid
overflow over 100% width because of having these properties set.

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::isOutside): To not interfere with
the regular WebVTT positioning algorithm, the check is done for
the absolute content box.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Added
an extra adjustment step to accomodate vertical padding (and not
overflow the cue container)

LayoutTests:

  • media/track/track-cue-rendering-with-padding-expected.txt: Added.
  • media/track/track-cue-rendering-with-padding.html: Added.
2:39 PM Changeset in webkit [144507] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r125809): CFStrings created via StringImpl::createCFString() might reference freed memory when Objective-C garbage collection is enabled
​https://bugs.webkit.org/show_bug.cgi?id=111219

Reviewed by Benjamin Poulain.

StringImpl::createCFString() uses CFStringCreateWithBytesNoCopy() in
order to create CFString without making an unnecessary copy. In order
to ensure that the the StringImpl's backing buffer isn't deallocated
while the CFString is still alive, we use a custom CFAllocator to
ref/deref the StringImpl at the appropriate times.

However, custom allocators aren't supported when Objective-C garbage
collection is enabled, so in this case we use the default CF allocator.
Since we can't guarantee the lifetime of the StringImpl in this case,
we should just fall back to copying the string, as we did prior to r125809.

  • platform/text/cf/StringImplCF.cpp:

(garbageCollectionEnabled): Moved the check for whether garbage
collection is enabled from StringWrapperCFAllocator::create() to here.
(WTF::StringWrapperCFAllocator::create): Call garbageCollectionEnabled().
(WTF::StringImpl::createCFString): If garbage collection is enabled,
call the variants of CFStringCreate that copy the string.

2:38 PM Changeset in webkit [144506] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/gtk

[GTK] Expose more of the configuration step to the gyp build
​https://bugs.webkit.org/show_bug.cgi?id=111213

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-03-01
Reviewed by Dirk Pranke.

Expose more of the configuration phase to the gyp build, including WebKit features
and binary paths.

  • gyp/Configuration.gypi.in: Add templatized gyp variables for the new configuration bits.
  • gyp/autogen.sh: Properly link up the WebKit features script. So we can access it

relatively as if we were at the top-level of the source directory.

  • gyp/configure.ac: Export the WebKit features.
2:26 PM Changeset in webkit [144505] by beidson@apple.com
  • 13 edits in branches/safari-536.29-branch

Merge 143976

2013-02-25 Anders Carlsson <​andersca@apple.com>

Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110793
<rdar://problem/13265303>

Reviewed by Sam Weinig.

Source/WebKit2:

Add a new pluginDidFail callback that takes a WKDictionaryRef and also pass in the
frame and page URLs.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit::pluginInformationDictionary): (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy):
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailToInitializePlugin): (WebKit::WebPageProxy::didBlockInsecurePluginVersion):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::didFailToInitializePlugin):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin):

Tools:

Update for WebKit2 API changes.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions):
2:22 PM Changeset in webkit [144504] by Chris Fleizach
  • 1 edit
    68 adds in trunk/LayoutTests

AX: Upstream iOS Accessibility layout tests
​https://bugs.webkit.org/show_bug.cgi?id=111187

Reviewed by David Kilzer.

Upstream the latest iOS Accessibility layout tests.

  • platform/iphone-simulator: Added.
  • platform/iphone-simulator/accessibility: Added.
  • platform/iphone-simulator/accessibility/accessibility-aria-table-children-expected.txt: Added.
  • platform/iphone-simulator/accessibility/accessibility-aria-table-children.html: Added.
  • platform/iphone-simulator/accessibility/accessibility-crash-in-axcontainer-expected.txt: Added.
  • platform/iphone-simulator/accessibility/accessibility-crash-in-axcontainer.html: Added.
  • platform/iphone-simulator/accessibility/accessibility-hint-expected.txt: Added.
  • platform/iphone-simulator/accessibility/accessibility-hint.html: Added.
  • platform/iphone-simulator/accessibility/aria-pressed-state-expected.txt: Added.
  • platform/iphone-simulator/accessibility/aria-pressed-state.html: Added.
  • platform/iphone-simulator/accessibility/centerpoint-expected.txt: Added.
  • platform/iphone-simulator/accessibility/centerpoint.html: Added.
  • platform/iphone-simulator/accessibility/dom-focus-fires-on-correct-element-expected.txt: Added.
  • platform/iphone-simulator/accessibility/dom-focus-fires-on-correct-element.html: Added.
  • platform/iphone-simulator/accessibility/focus-change-notifications-expected.txt: Added.
  • platform/iphone-simulator/accessibility/focus-change-notifications.html: Added.
  • platform/iphone-simulator/accessibility/header-elements-expected.txt: Added.
  • platform/iphone-simulator/accessibility/header-elements.html: Added.
  • platform/iphone-simulator/accessibility/identifier-expected.txt: Added.
  • platform/iphone-simulator/accessibility/identifier.html: Added.
  • platform/iphone-simulator/accessibility/internal-link-expected.txt: Added.
  • platform/iphone-simulator/accessibility/internal-link.html: Added.
  • platform/iphone-simulator/accessibility/link-with-images-text-expected.txt: Added.
  • platform/iphone-simulator/accessibility/link-with-images-text.html: Added.
  • platform/iphone-simulator/accessibility/link-with-only-image-expected.txt: Added.
  • platform/iphone-simulator/accessibility/link-with-only-image.html: Added.
  • platform/iphone-simulator/accessibility/math-expected.txt: Added.
  • platform/iphone-simulator/accessibility/math.html: Added.
  • platform/iphone-simulator/accessibility/mixed-checkboxes-expected.txt: Added.
  • platform/iphone-simulator/accessibility/mixed-checkboxes.html: Added.
  • platform/iphone-simulator/accessibility/no-child-link-header-expected.txt: Added.
  • platform/iphone-simulator/accessibility/no-child-link-header.html: Added.
  • platform/iphone-simulator/accessibility/non-contiguous-link-expected.txt: Added.
  • platform/iphone-simulator/accessibility/non-contiguous-link.html: Added.
  • platform/iphone-simulator/accessibility/password-value-expected.txt: Added.
  • platform/iphone-simulator/accessibility/password-value.html: Added.
  • platform/iphone-simulator/accessibility/placeholder-value-expected.txt: Added.
  • platform/iphone-simulator/accessibility/placeholder-value.html: Added.
  • platform/iphone-simulator/accessibility/popup-button-value-label-expected.txt: Added.
  • platform/iphone-simulator/accessibility/popup-button-value-label.html: Added.
  • platform/iphone-simulator/accessibility/radio-button-expected.txt: Added.
  • platform/iphone-simulator/accessibility/radio-button.html: Added.
  • platform/iphone-simulator/accessibility/secure-text-field-expected.txt: Added.
  • platform/iphone-simulator/accessibility/secure-text-field.html: Added.
  • platform/iphone-simulator/accessibility/selected-buttons-expected.txt: Added.
  • platform/iphone-simulator/accessibility/selected-buttons.html: Added.
  • platform/iphone-simulator/accessibility/selected-text-expected.txt: Added.
  • platform/iphone-simulator/accessibility/selected-text.html: Added.
  • platform/iphone-simulator/accessibility/tab-role-expected.txt: Added.
  • platform/iphone-simulator/accessibility/tab-role.html: Added.
  • platform/iphone-simulator/accessibility/table-cell-for-row-col-expected.txt: Added.
  • platform/iphone-simulator/accessibility/table-cell-for-row-col.html: Added.
  • platform/iphone-simulator/accessibility/table-cell-ranges-expected.txt: Added.
  • platform/iphone-simulator/accessibility/table-cell-ranges.html: Added.
  • platform/iphone-simulator/accessibility/tables-lists-expected.txt: Added.
  • platform/iphone-simulator/accessibility/tables-lists.html: Added.
  • platform/iphone-simulator/accessibility/text-line-no-ignored-elements-expected.txt: Added.
  • platform/iphone-simulator/accessibility/text-line-no-ignored-elements.html: Added.
  • platform/iphone-simulator/accessibility/text-marker-list-item-expected.txt: Added.
  • platform/iphone-simulator/accessibility/text-marker-list-item.html: Added.
  • platform/iphone-simulator/accessibility/text-marker-validation-expected.txt: Added.
  • platform/iphone-simulator/accessibility/text-marker-validation.html: Added.
  • platform/iphone-simulator/accessibility/text-role-expected.txt: Added.
  • platform/iphone-simulator/accessibility/text-role.html: Added.
  • platform/iphone-simulator/accessibility/textfield-in-axvalue-expected.txt: Added.
  • platform/iphone-simulator/accessibility/textfield-in-axvalue.html: Added.
  • platform/iphone-simulator/accessibility/url-test-expected.txt: Added.
  • platform/iphone-simulator/accessibility/url-test.html: Added.
2:14 PM Changeset in webkit [144503] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed AppleWin build fix.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):

2:03 PM Changeset in webkit [144502] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

[GTK] Allow sharing the WebCore include list with the Chromium build
​https://bugs.webkit.org/show_bug.cgi?id=110241

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-03-01
Reviewed by Dirk Pranke.

  • WebCore.gyp/WebCoreGTK.gyp: Added. A skeleton gyp file for WebCoreGTK+.
  • WebCore.gypi: Added shared include directories.
2:02 PM Changeset in webkit [144501] by beidson@apple.com
  • 11 edits in branches/safari-536.29-branch/Source

Merge 143815

2013-02-22 Anders Carlsson <​andersca@apple.com>

pluginLoadStrategy should take a WKDictionaryRef for extensibility
​https://bugs.webkit.org/show_bug.cgi?id=110656
<rdar://problem/13265303>

Reviewed by Jessie Berlin.

Source/WebCore:

Export a symbol needed by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

Change pluginLoadStrategy to take a WKDictionaryRef instead of a number of parameters;
this lets us add more plug-in information if needed. Also add the page URL and rename documentURL to frameURL.

  • UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationBundleIdentifierKey): (WKPageGetPluginInformationBundleVersionKey): (WKPageGetPluginInformationDisplayNameKey): (WKPageGetPluginInformationFrameURLKey): (WKPageGetPluginInformationMIMETypeKey): (WKPageGetPluginInformationPageURLKey):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit): (WebKit::WebLoaderClient::pluginLoadPolicy):
  • UIProcess/WebLoaderClient.h: (WebLoaderClient):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): (WebKit::WebPageProxy::pluginInformationBundleIdentifierKey): (WebKit): (WebKit::WebPageProxy::pluginInformationBundleVersionKey): (WebKit::WebPageProxy::pluginInformationDisplayNameKey): (WebKit::WebPageProxy::pluginInformationFrameURLKey): (WebKit::WebPageProxy::pluginInformationMIMETypeKey): (WebKit::WebPageProxy::pluginInformationPageURLKey):
  • UIProcess/WebPageProxy.h: (WebPageProxy):
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
2:02 PM Changeset in webkit [144500] by roger_fong@apple.com
  • 1 edit
    5 adds in trunk/Tools

Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
​https://bugs.webkit.org/show_bug.cgi?id=111202

This is useful for running VCExpress builds from command line because there is
no unified solution output, only per project build logs.
The project will be run as the last project in the solution.

  • win/AssembleBuildLogs: Added.
  • win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
  • win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
  • win/AssembleBuildLogs/AssembleLogs.cmd: Added.
  • win/AssembleBuildLogs/README: Added.
2:00 PM Changeset in webkit [144499] by ap@apple.com
  • 11 edits
    8 adds in trunk/Source

Make in-memory blobs work in NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=111132

Reviewed by Sam Weinig.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::registerBlobURL): (WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL): (WebKit::NetworkConnectionToWebProcess::unregisterBlobURL):
  • NetworkProcess/NetworkConnectionToWebProcess.h: Implement BlobRegistry interface by using BlobRegistryImpl (same one as used in WebProcess in non-PPT mode).
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in: Added three messages needed for BlobRegistry.
  • NetworkProcess/NetworkProcess.cpp:
  • NetworkProcess/NetworkProcessPlatformStrategies.cpp: Added.
  • NetworkProcess/NetworkProcessPlatformStrategies.h: Added. Added a mostly empty platform strategy, just for FormData to talk to BlobRegistry. Perhaps we'll find a way to avoid this WebCore code path in NetworkProcess, because we obviously know which registry implementation is in use in this process.
  • Shared/FileAPI: Added.
  • Shared/FileAPI/BlobRegistrationData.cpp: Added.
  • Shared/FileAPI/BlobRegistrationData.h: Added. Added a class for passing BlobData and extension handles over IPC. This uses a trick with mutable a member to avoid copying decoded BlobStorageData.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/FileAPI: Added.
  • WebProcess/FileAPI/BlobRegistryProxy.cpp: Added.
  • WebProcess/FileAPI/BlobRegistryProxy.h: Added. A proxy implementation of BlobRegistry that just sends requests over IPC. We only need async ones.
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::createBlobRegistry):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h: Create an appropriate BlobRegistry.
1:53 PM Changeset in webkit [144498] by eric@webkit.org
  • 19 edits in trunk/Source

Threaded HTML Parser has an extra copy of every byte from the network
​https://bugs.webkit.org/show_bug.cgi?id=111135

Reviewed by Adam Barth.

Source/WebCore:

Every LayoutTest executes this code in threaded parsing mode.

  • dom/DecodedDataDocumentParser.cpp:

(WebCore::DecodedDataDocumentParser::appendBytes):

  • Pass ownership of the decoded string to the parser.

(WebCore::DecodedDataDocumentParser::flush):

  • Same.
  • dom/DecodedDataDocumentParser.h:

(DecodedDataDocumentParser):

  • dom/Document.cpp:

(WebCore::Document::setContent):

  • dom/DocumentParser.h:

(DocumentParser):

  • dom/RawDataDocumentParser.h:

(WebCore::RawDataDocumentParser::append):

  • html/FTPDirectoryDocument.cpp:

(FTPDirectoryDocumentParser):
(WebCore::FTPDirectoryDocumentParser::append):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::append):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::append):

  • html/parser/HTMLViewSourceParser.h:

(HTMLViewSourceParser):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::append):

  • html/parser/TextDocumentParser.h:

(TextDocumentParser):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::append):

  • xml/parser/XMLDocumentParser.h:

(XMLDocumentParser):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::resumeParsing):

Source/WTF:

The threaded html parser needs to accept ownership
of a string buffer. The easiest way to do this seemed
to be to use a PassRefPtr<StringImpl>, but there was no way
to generated one from a String (easily), so I added one.

  • wtf/text/WTFString.h:

(WTF::String::releaseImpl):

1:44 PM Changeset in webkit [144497] by hyatt@apple.com
  • 21 edits
    2 adds in trunk

[New Multicolumn] Change inRenderFlowThread to follow containing block chain
​https://bugs.webkit.org/show_bug.cgi?id=111206

Reviewed by Simon Fraser.

Source/WebCore:

This patch removes inRenderFlowThread and changes enclosingRenderFlowThread()
to flowThreadContainingBlock(). flowThreadContainingBlock() now follows
the containing block chain instead of the parent chain when outside of layout.
(It already did the right thing when called during layout.)

By removing inRenderFlowThread (which was following the parent chain), all
code that is checking for flow thread containment now correctly uses the
containing block chain. This allows for content to escape in-flow flow threads
and do the right thing without asserting.

Test: fast/multicol/positioned-outside-of-columns.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::inFlowThread):
(WebCore::WebKitNamedFlow::getRegionsByContent):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::RenderBlock::collapseAnonymousBoxChild):
(WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize):
(WebCore::RenderBlock::computeRegionRangeForBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::computeLogicalLocationForFloat):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::hasNextPage):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::pageLogicalTopForOffset):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage):
(WebCore::RenderBlock::regionAtBlockOffset):
(WebCore::RenderBlock::setStaticInlinePositionForChild):
(WebCore::RenderBlock::logicalWidthChangedInRegions):
(WebCore::RenderBlock::clampToStartAndEndRegions):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::layoutExclusionShapeInsideInfo):
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::flowThread):
(WebCore::LineLayoutState::setFlowThread):
(LineLayoutState):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clearRenderBoxRegionInfo):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::objectInFlowRegion):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):

  • rendering/RenderLayer.cpp:

(WebCore::accumulateOffsetTowardsAncestor):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::canBeComposited):

  • rendering/RenderMedia.cpp:

(WebCore::RenderMedia::layout):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::locateFlowThreadContainingBlock):
(WebCore::RenderObject::containerForRepaint):
(WebCore::RenderObject::willBeRemovedFromTree):
(WebCore::RenderObject::removeFromRenderFlowThread):
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive):

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::flowThreadContainingBlock):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setObjectStyleInRegion):

  • rendering/RenderView.cpp:

(WebCore::RenderView::addChild):
(WebCore::RenderView::initializeLayoutState):
(WebCore::RenderView::setSelection):

  • rendering/RenderView.h:

(WebCore::RenderView::pushLayoutState):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::setContainingRegion):

LayoutTests:

  • fast/multicol/positioned-outside-of-columns-expected.html: Added.
  • fast/multicol/positioned-outside-of-columns.html: Added.
1:36 PM Changeset in webkit [144496] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Uncomment ENABLE_SVG guards to avoid having WebKitPluginProcess link
against libWebCoreSVG.la when SVG is disabled.

Rubber-stamped by Gustavo Noronha.

  • GNUmakefile.am:
1:32 PM Changeset in webkit [144495] by weinig@apple.com
  • 15 edits in trunk/Source

Add SPI for marking a WebView as doing things on behalf of another process
​https://bugs.webkit.org/show_bug.cgi?id=111125

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • platform/network/NetworkingContext.h:

(NetworkingContext):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
Set the sourceApplicationAuditData on the URL connection if available.

Source/WebKit/mac:

  • WebCoreSupport/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext):

  • WebCoreSupport/WebFrameNetworkingContext.mm:

(WebFrameNetworkingContext::sourceApplicationAuditData):

  • WebView/WebView.mm:

(-[WebView _setSourceApplicationAuditData:]):
(-[WebView _sourceApplicationAuditData]):

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:

(-[WebViewPrivate dealloc]):

  • WebView/WebViewPrivate.h:

Add SPI for setting a source application for a WebView.

Source/WebKit2:

  • NetworkProcess/mac/RemoteNetworkingContext.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::sourceApplicationAuditData):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::sourceApplicationAuditData):
Stub out sourceApplicationAuditData() client function.

1:31 PM Changeset in webkit [144494] by zhajiang@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Screen went black while navigating back/forward on the reddit.com page
​https://bugs.webkit.org/show_bug.cgi?id=111192

Patch by Jacky Jiang <​zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

PR: 299783
When going back to the previous reddit.com page, the actual contents
size was much less than the history contents size. However, we expanded
the actual contents size to history contents size which caused a huge
black area below the actual contents.
To fix that, don't restore the contents size from history contents size
and scroll back to the valid contents area if we are about to overscroll.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

1:26 PM Changeset in webkit [144493] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Increase number of patches processed before clean building on WinEWS bots.

  • EWSTools/start-queue-win.sh:
1:25 PM Changeset in webkit [144492] by beidson@apple.com
  • 10 edits in branches/safari-536.29-branch

Merge r143790

2013-02-22 Anders Carlsson <​andersca@apple.com>

Source/WebKit2:

Move pluginLoadPolicy to the page loader client
​https://bugs.webkit.org/show_bug.cgi?id=110635
<rdar://problem/13265303>


Reviewed by Sam Weinig.

Move the pluginLoadPolicy callback to the page loader client where it belongs.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebLoaderClient::pluginLoadPolicy):
  • UIProcess/WebLoaderClient.h: (WebLoaderClient):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
  • UIProcess/WebUIClient.cpp: (WebKit):
  • UIProcess/WebUIClient.h: (WebUIClient):
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools:

Move pluginLoadPolicy to the page loader client
​https://bugs.webkit.org/show_bug.cgi?id=110635

Reviewed by Sam Weinig.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
1:18 PM Changeset in webkit [144491] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebCore

[Windows] Unreviewed VS2010 build fix.

  • WebCore.vcxproj/WebCore.vcxproj: Add missing TimelineTraceEventProcessor files to the project.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
1:18 PM Changeset in webkit [144490] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/Source/ThirdParty/ANGLE

[GTK] Add ANGLE to the GTK+ gyp build
​https://bugs.webkit.org/show_bug.cgi?id=111128

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-03-01
Reviewed by Dirk Pranke.

Add files that build an ANGLE static library for GTK+ using gyp.

  • ANGLE.gyp/ANGLE.gyp: Added.
  • ANGLE.gypi: Added.
1:14 PM Changeset in webkit [144489] by mhahnenberg@apple.com
  • 5 edits
    2 deletes in trunk/Source/JavaScriptCore

Objective-C API: Passing JS functions to Objective-C callbacks causes JSValue to leak
​https://bugs.webkit.org/show_bug.cgi?id=107836

Reviewed by Oliver Hunt.

We've decided to remove support for this feature from the API because there's no way to automatically manage
the memory for clients in a satisfactory manner. Clients can still pass JS functions to Objective-C methods,
but the methods must accept plain JSValues instead of Objective-C blocks.

We now ignore functions that are part of a protocol that inherits from JSExport that accept blocks as arguments.

  • API/JSBlockAdaptor.h: Removed.
  • API/JSBlockAdaptor.mm: Removed.
  • API/ObjCCallbackFunction.mm:

(ArgumentTypeDelegate::typeBlock): Return nil to signal that we want to ignore this function when copying it
to the object from the protocol.

  • API/tests/testapi.mm: Added a test to make sure that we ignore methods declared as part of a JSExport-ed protocol

that have block arguments.
(-[TestObject bogusCallback:]):

1:07 PM Changeset in webkit [144488] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Improve input bounds clipping for search fields.
​https://bugs.webkit.org/show_bug.cgi?id=111204

Reviewed by Rob Buis.

PR 292673.

Use the standardized InputHandler function to get the
bounds of an input field so that search fields are
truncated smaller to account for the X.

Reviewed Internally by Gen Mak.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setCaretPosition):

1:02 PM Changeset in webkit [144487] by betravis@adobe.com
  • 7 edits
    2 adds in trunk

[css exclusions] setting shape-inside on a parent does not relayout child blocks' inline content
​https://bugs.webkit.org/show_bug.cgi?id=108128

Reviewed by David Hyatt.

Source/WebCore:

Ensure that blocks lay out when their parent's shape-inside changes.
ExclusionShapeInsideInfo now stores an additional flag indicating whether
the shape has changed and its block's children require layout. Each block
can look up the flag via LayoutState to determine whether it needs to lay
out its children.

Test: fast/exclusions/shape-inside/shape-inside-dynamic-nested.html

  • rendering/ExclusionShapeInfo.h:

(WebCore::ExclusionShapeInfo::shapeSizeDirty): Add a method to determine
if the shape has changed.
(ExclusionShapeInfo):

  • rendering/ExclusionShapeInsideInfo.h:

(WebCore::ExclusionShapeInsideInfo::setNeedsLayout): Set the flag indicating
layout is necessary.
(WebCore::ExclusionShapeInsideInfo::needsLayout): Retrieve the layout flag.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Initialize
the layout flag.

  • rendering/RenderBlock.cpp:

(WebCore::exclusionInfoRequiresRelayout): Return true if the shape info should
cause a relayout. Also update the needsLayout flag on the ExclusionShapeInsideInfo.
(WebCore):
(WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize): Return a boolean
indicating whether regions or exclusions updates should cause a relayout.
(WebCore::RenderBlock::layoutBlock): Relayout children if the shape inside has
changed.

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Changing to be a
class method.
(WebCore::LineWidth::LineWidth): Changing to use class method.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.
(WebCore::constructBidiRunsForLine): Ditto.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Ditto.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Ditto.

LayoutTests:

Test that setting and resetting shape-inside and shape-outside correctly lay out
content inside of child blocks.

  • fast/exclusions/shape-inside/shape-inside-dynamic-nested-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-dynamic-nested.html: Added.
12:57 PM Changeset in webkit [144486] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG Branch(LogicalNot) peephole should not try to optimize and work-around the case where LogicalNot may be otherwise live
​https://bugs.webkit.org/show_bug.cgi?id=111209

Reviewed by Oliver Hunt.

Even if it is then everything will work just fine. It's not necessary to check the ref count here.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

12:49 PM Changeset in webkit [144485] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getComputedStyle not implemented for -webkit-column-rule shorthand
​https://bugs.webkit.org/show_bug.cgi?id=111203

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-03-01
Reviewed by Alexis Menard.

Source/WebCore:

Implement getComputedStyle for -webkit-column-rule property.

Test: fast/css/getComputedStyle/getComputedStyle-column-rule.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to check getComputedStyle for -webkit-column-rule.

  • fast/css/getComputedStyle/getComputedStyle-column-rule-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-column-rule.html: Added.
12:46 PM Changeset in webkit [144484] by hyatt@apple.com
  • 6 edits in trunk/Source/WebCore

REGRESSION(r144318) 1-7% perf. regression on SVG/SvgHitTesting
​https://bugs.webkit.org/show_bug.cgi?id=111117

Make sure the allocated vector has a capacity of 1, since that is
far and away the most common case.

Reviewed by Andreas Kling.

  • rendering/RenderFlowThread.h:

(WebCore):

  • rendering/RenderLayer.h:

(WebCore):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::collectLayerFragments):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderRegion.h:

(WebCore):
(WebCore::RenderRegion::collectLayerFragments):

12:43 PM Changeset in webkit [144483] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Crash at WebCore::SharedBuffer::hasPlatformData writing an image to the pasteboard.
​https://bugs.webkit.org/show_bug.cgi?id=111211.
<rdar://problem/8772758>

Reviewed by Ryosuke Niwa.

This is a speculative fix since we don't have a solid repro case.
Adding null check every time we build a SharedBuffer from an NSData
we have obtained manipulating data from the pasteboard.

  • platform/mac/PasteboardMac.mm:

(WebCore::writeFileWrapperAsRTFDAttachment):
(WebCore::Pasteboard::writeImage):

12:42 PM Changeset in webkit [144482] by beidson@apple.com
  • 4 edits
    2 adds in branches/safari-536.29-branch

Merge r142919

2013-02-14 Anders Carlsson <​andersca@apple.com>

Add WKContextIsPlugInUpdateAvailable
​https://bugs.webkit.org/show_bug.cgi?id=109862
<rdar://problem/13173140>

Reviewed by Sam Weinig.

Source/WebKit2:

  • UIProcess/API/C/mac/WKContextPrivateMac.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.cpp. (WKContextGetProcessSuppressionEnabled): (WKContextSetProcessSuppressionEnabled): (WKContextIsPlugInUpdateAvailable):
  • WebKit2.xcodeproj/project.pbxproj:

WebKitLibraries:

Roll WebKitSystemInterface DEPS.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
12:40 PM Changeset in webkit [144481] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CSE phase shouldn't rely on ref count of nodes, since it doesn't have to
​https://bugs.webkit.org/show_bug.cgi?id=111205

Reviewed by Oliver Hunt.

I don't understand the intuition behind setLocalStoreElimination() validating that the SetLocal's ref count
is 1. I believe this is a hold-over from when setLocalStoreElimination() would match one SetLocal to another,
and then try to eliminate the first SetLocal. But that's not how it works now. Now, setLocalStoreElimination()
is actually Flush elimination: it eliminates any Flush that anchors a SetLocal if it proves that every path
from the SetLocal to the Flush is devoid of operations that may observe the local. It doesn't actually kill
the SetLocal itself: if the SetLocal is live because of other things (other Flushes or GetLocals in other
basic blocks), then the SetLocal will naturally still be alive because th Flush was only keeping the SetLocal
alive by one count rather than being solely responsible for its liveness.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

12:32 PM Changeset in webkit [144480] by Lucas Forschler
  • 18 edits in tags/Safari-537.31.12/Source

Merged r144397. <rdar://problem/13291412>

12:26 PM Changeset in webkit [144479] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Crash at WebCore::SharedBuffer::hasPlatformData during paste.
​https://bugs.webkit.org/show_bug.cgi?id=111207.
<rdar://problem/13024528>

Reviewed by Ryosuke Niwa.

This is a speculative fix since we don't have a solid repro case.
Adding null check every time we get a SharedBuffer from the pasteboard.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::plainText):
(WebCore::documentFragmentWithRTF):

12:04 PM Changeset in webkit [144478] by rniwa@webkit.org
  • 5 edits in trunk/Tools

Don't return statistics in PerfTest.run
​https://bugs.webkit.org/show_bug.cgi?id=111145

Reviewed by Dirk Pranke.

Simply return a list of values obtained in each iteration from PerfTest.run.
Also simplify various methods as needed.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTestMetric.init): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
as needed from PerfTestsRunner._generate_results_dict.

(PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
that we don't have to worry about the backward compatibility here.

(PerfTestMetric.iteration_values): Added.
(PerfTestMetric.unit): Added.
(PerfTestMetric.metric_to_unit):
(PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.

(PerfTest.run):
(PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTestMetric.test_init_set_missing_unit):
(TestPerfTestMetric.test_init_set_time_metric): Added.
(TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
(TestPerfTestMetric.test_append):
(TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
test cases and it's not critical to keep math right as they're not used in output JSON anymore.
(TestPerfTest._assert_results_are_correct):
(TestReplayPerfTest.test_run_with_driver_accumulates_results):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_results_dict):

  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
(SomeParserTestData): Ditto.
(MemoryTestData): Ditto.

11:51 AM Changeset in webkit [144477] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rename MovHint to MovHintEvent so I can create a NodeType called MovHint

Rubber stamped by Mark Hahnenberg.

This is similar to the SetLocal/SetLocalEvent naming scheme, where SetLocal is the
NodeType and SetLocalEvent is the VariableEventKind.

  • dfg/DFGVariableEvent.cpp:

(JSC::DFG::VariableEvent::dump):

  • dfg/DFGVariableEvent.h:

(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::id):
(JSC::DFG::VariableEvent::operand):
(VariableEvent):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

11:23 AM Changeset in webkit [144476] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark rtl-iframe-absolute-overflow-scrolled as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=111199

Unreviewed gardening.

  • platform/chromium/TestExpectations:
11:17 AM Changeset in webkit [144475] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for builds with BLOB disabled. This fixes it for me on Mac at least.

  • platform/network/BlobRegistryImpl.cpp:
11:13 AM Changeset in webkit [144474] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Curl] Session cookies should not be persistent.
​https://bugs.webkit.org/show_bug.cgi?id=111060

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-03-01
Reviewed by Brent Fulgham.

Curl saves both persistent cookies, and session cookies to the cookie file.
The session cookies should be deleted before starting a new session.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::ResourceHandleManager): Call method to initialize cookie session.
(WebCore::ResourceHandleManager::initCookieSession): Added method to initialize cookie session.

  • platform/network/curl/ResourceHandleManager.h: Added method to initialize cookie session.
11:04 AM Changeset in webkit [144473] by beidson@apple.com
  • 8 edits in branches/safari-536.29-branch/Source/WebKit2

Merge r142017

2013-02-06 Anders Carlsson <​andersca@apple.com>

Pass the document source URL to the pluginLoadPolicy callback
​https://bugs.webkit.org/show_bug.cgi?id=109084
<rdar://problem/13154516>

Reviewed by Andreas Kling.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
  • UIProcess/WebPageProxy.h: (WebPageProxy):
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::pluginLoadPolicy):
  • UIProcess/WebUIClient.h: (WebUIClient):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
10:53 AM Changeset in webkit [144472] by beidson@apple.com
  • 5 edits in branches/safari-536.29-branch/Source/WebKit2

Merge r141923

2013-02-05 Anders Carlsson <​andersca@apple.com>

WebKit clients should be able to override loading of blocked plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=108968
<rdar://problem/13154516>

Reviewed by Sam Weinig.

Replace the shouldInstantiatePlugin callback with a new pluginLoadPolicy which is called regardless
of whether the plug-in is blocked or not. This lets clients override the plug-in load policy and
force loading of blacklisted plug-ins (and vice versa).

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
  • UIProcess/WebUIClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebUIClient::pluginLoadPolicy):
  • UIProcess/WebUIClient.h: (WebUIClient):
10:32 AM Changeset in webkit [144471] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.12/Source

Versioning.

10:28 AM Changeset in webkit [144470] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.12

New Tag.

10:11 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
10:10 AM Changeset in webkit [144469] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r143973 - Build fix for gtk2-based library.

Reviewed by Martin Robinson.

  • platform/gtk/WidgetRenderingContext.cpp: move gtk2 check to after the config.h

include, which is the one that includes autotoolsconfig.h, where the gtk2 define
lives.

10:07 AM Changeset in webkit [144468] by Carlos Garcia Campos
  • 34 edits in releases/WebKitGTK/webkit-2.0

Merge r143869 - [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
​https://bugs.webkit.org/show_bug.cgi?id=110702

Reviewed by Martin Robinson.

Source/WebCore:

No tests. Build fix, no behaviour change.

  • platform/gtk/GtkVersioning.h: include the autotoolsconfig.h header,

which contains the GTK_API_VERSION_2 define now.

Source/WebKit/gtk:

  • tests/testapplicationcache.c: include autotoolsconfig.h.
  • tests/testatk.c: ditto.
  • tests/testatkroles.c: ditto.
  • tests/testcontextmenu.c: ditto.
  • tests/testcopyandpaste.c: ditto.
  • tests/testdomdocument.c: ditto.
  • tests/testdomdomwindow.c: ditto.
  • tests/testdomnode.c: ditto.
  • tests/testdownload.c: ditto.
  • tests/testfavicondatabase.c: ditto.
  • tests/testglobals.c: ditto.
  • tests/testhittestresult.c: ditto.
  • tests/testhttpbackend.c: ditto.
  • tests/testkeyevents.c: ditto.
  • tests/testloading.c: ditto.
  • tests/testmimehandling.c: ditto.
  • tests/testnetworkrequest.c: ditto.
  • tests/testnetworkresponse.c: ditto.
  • tests/testwebbackforwardlist.c: ditto.
  • tests/testwebdatasource.c: ditto.
  • tests/testwebframe.c: ditto.
  • tests/testwebhistoryitem.c: ditto.
  • tests/testwebinspector.c: ditto.
  • tests/testwebplugindatabase.c: ditto.
  • tests/testwebresource.c: ditto.
  • tests/testwebsettings.c: ditto.
  • tests/testwebview.c: ditto.
  • tests/testwindow.c: ditto.

Tools:

  • GtkLauncher/main.c: include autotoolsconfig.h.
  • Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of

the include ordering check, since it uses autotoolsconfig.h which needs to
come first.

9:57 AM Changeset in webkit [144467] by vsevik@chromium.org
  • 13 edits
    2 adds
    2 deletes in trunk

Web Inspector: Navigator should show tree element for each folder in the source path.
​https://bugs.webkit.org/show_bug.cgi?id=108943

Reviewed by Pavel Feldman.

Source/WebCore:

NavigatorView now renders tree element for each folder in uiSourceCode uri.
Merging several folders into one tree elememnt when folder has only one folder as a child is supported.
ScriptsNavigator has horizontal scroll now.
Projects are shown in ScriptsNavigator by their displayName. This allows us to show several root file system folders
with the same name in the navigator (e.g. 'Source/WebCore/inspector' and 'LayoutTests/inspector').

Test: inspector/debugger/navigator-view.html: Renamed from scripts-file-selector.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView):
(WebInspector.NavigatorView.iconClassForType):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._getProjectNode):
(WebInspector.NavigatorView.prototype._createProjectNode):
(WebInspector.NavigatorView.prototype._getOrCreateProjectNode):
(WebInspector.NavigatorView.prototype._getFolderNode):
(WebInspector.NavigatorView.prototype._createFolderNode):
(WebInspector.NavigatorView.prototype._getOrCreateFolderNode):
(WebInspector.NavigatorView.prototype._getUISourceCodeParentNode):
(WebInspector.NavigatorView.prototype._getOrCreateUISourceCodeParentNode):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorView.prototype.rename):
(WebInspector.NavigatorView.prototype.reset):
(.typeWeight):
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
(WebInspector.BaseNavigatorTreeElement):
(WebInspector.BaseNavigatorTreeElement.prototype.type):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.onpopulate):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorSourceTreeElement):
(WebInspector.NavigatorTreeNode):
(WebInspector.NavigatorTreeNode.prototype.treeElement):
(WebInspector.NavigatorTreeNode.prototype.dispose):
(WebInspector.NavigatorTreeNode.prototype.isRoot):
(WebInspector.NavigatorTreeNode.prototype.hasChildren):
(WebInspector.NavigatorTreeNode.prototype.populate):
(WebInspector.NavigatorTreeNode.prototype.wasPopulated):
(WebInspector.NavigatorTreeNode.prototype.didAddChild):
(WebInspector.NavigatorTreeNode.prototype.willRemoveChild):
(WebInspector.NavigatorTreeNode.prototype.isPopulated):
(WebInspector.NavigatorTreeNode.prototype.isEmpty):
(WebInspector.NavigatorTreeNode.prototype.child):
(WebInspector.NavigatorTreeNode.prototype.children):
(WebInspector.NavigatorTreeNode.prototype.appendChild):
(WebInspector.NavigatorTreeNode.prototype.removeChild):
(WebInspector.NavigatorTreeNode.prototype.reset):
(WebInspector.NavigatorRootTreeNode):
(WebInspector.NavigatorRootTreeNode.prototype.isRoot):
(WebInspector.NavigatorRootTreeNode.prototype.treeElement):
(WebInspector.NavigatorRootTreeNode.prototype.wasPopulated):
(WebInspector.NavigatorRootTreeNode.prototype.didAddChild):
(WebInspector.NavigatorRootTreeNode.prototype.willRemoveChild):
(WebInspector.NavigatorUISourceCodeTreeNode):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.treeElement):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.updateTitle):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.hasChildren):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.dispose):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._titleChanged):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._workingCopyChanged):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._workingCopyCommitted):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._formattedChanged):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.reveal):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.commitHandler):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.cancelHandler):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.afterEditing):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename):
(WebInspector.NavigatorFolderTreeNode):
(WebInspector.NavigatorFolderTreeNode.prototype.treeElement):
(WebInspector.NavigatorFolderTreeNode.prototype._createTreeElement):
(WebInspector.NavigatorFolderTreeNode.prototype.wasPopulated):
(WebInspector.NavigatorFolderTreeNode.prototype._addChildrenRecursive):
(WebInspector.NavigatorFolderTreeNode.prototype._shouldMerge):
(WebInspector.NavigatorFolderTreeNode.prototype.didAddChild):
(WebInspector.NavigatorFolderTreeNode.prototype.willRemoveChild):

  • inspector/front-end/ScriptsNavigator.js:
  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate.prototype.displayName):

  • inspector/front-end/navigatorView.css:

(.navigator > ol):
(.navigator .base-navigator-tree-element-title):
(.navigator-tabbed-pane .navigator-container):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest.):
(initialize_DebuggerTest):

  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.createWorkspace):

  • inspector/debugger/navigator-view-expected.txt: Added.
  • inspector/debugger/navigator-view.html: Added.
  • inspector/debugger/scripts-file-selector-expected.txt: Removed.
  • inspector/debugger/scripts-file-selector.html: Removed.
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
9:49 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
9:48 AM Changeset in webkit [144466] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.0/LayoutTests

Merge r144045 - REGRESSION (r143931): set-cookie-on-redirect.html breaks subsequent tests
​https://bugs.webkit.org/show_bug.cgi?id=110844

Patch by Sergio Villar Senin <​svillar@igalia.com> on 2013-02-26
Reviewed by Alexey Proskuryakov.

Clean up cookies at the beginning and after finishing the test in
order not to break other tests behavior.

  • http/tests/cookies/resources/set-cookie-on-redirect.php: clear cookie before returning.
  • http/tests/cookies/set-cookie-on-redirect.html: clear all cookies before starting the test.
9:43 AM Changeset in webkit [144465] by anilsson@rim.com
  • 36 edits
    5 deletes in trunk/Source/WebCore

[BlackBerry] Upstream BlackBerry::Platform::Graphics::GraphicsContext integration related changes in platform/graphics/blackberry
​https://bugs.webkit.org/show_bug.cgi?id=111072

Reviewed by Rob Buis.

BlackBerry PR 293208

This patch contains contributions from many members of the BlackBerry
WebKit team:

Rob Buis
Robin Cao
Michael Carmody
Max Feil
Eli Fidler
Antonio Gomes
Jacky Jiang
Mike Lattanzio
Yong Li
Andrew Lo
Maxim Mogilnitsky
Joshua Netterfield
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Artem Simonov
Filip Spacek
George Staikos
Cosmin Truta

Covered by existing tests.

  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(WebCore::CanvasLayerWebKitThread::deleteTextures):
(CanvasLayerCompositingThreadClient):
(WebCore::CanvasLayerCompositingThreadClient::layerCompositingThreadDestroyed):
(WebCore::CanvasLayerCompositingThreadClient::layerVisibilityChanged):
(WebCore::CanvasLayerCompositingThreadClient::uploadTexturesIfNeeded):
(WebCore::CanvasLayerCompositingThreadClient::clearBuffer):
(WebCore):
(WebCore::CanvasLayerCompositingThreadClient::CanvasLayerCompositingThreadClient):
(WebCore::CanvasLayerCompositingThreadClient::drawTextures):
(WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
(WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::clearBuffer):

  • platform/graphics/blackberry/CanvasLayerWebKitThread.h:

(WebCore):
(WebCore::CanvasLayerWebKitThread::create):
(CanvasLayerWebKitThread):

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

  • platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::platformLayer):

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:

(WebCore::EGLImageLayerCompositingThreadClient::~EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::uploadTexturesIfNeeded):
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
(WebCore::EGLImageLayerCompositingThreadClient::deleteTextures):
(WebCore::EGLImageLayerCompositingThreadClient::bindContentsTexture):
(WebCore::EGLImageLayerCompositingThreadClient::setTextureAccessor):

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h:

(Graphics):
(EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::EGLImageLayerCompositingThreadClient):

  • platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:

(WebCore::EGLImageLayerWebKitThread::EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::updateFrontBuffer):
(WebCore::EGLImageLayerWebKitThread::deleteFrontBuffer):
(WebCore::EGLImageLayerWebKitThread::commitPendingTextureUploads):
(WebCore::EGLImageLayerWebKitThread::createTextureIfNeeded):
(WebCore::EGLImageLayerWebKitThread::blitToFrontBuffer):

  • platform/graphics/blackberry/EGLImageLayerWebKitThread.h:

(Graphics):
(EGLImageLayerWebKitThread):

  • platform/graphics/blackberry/FloatRectBlackBerry.cpp:

(WebCore::FloatRect::normalized):
(WebCore):

  • platform/graphics/blackberry/FontCacheBlackberry.cpp: Removed.
  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::paintToCanvas):
(WebCore::GraphicsContext3D::getImageData):
(WebCore):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::clearBackgroundColor):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::setContentsNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
(WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::notifySyncRequired):

  • platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::ImageFrame::asNewNativeImage):
(WebCore):
(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::invalidatePlatformData):
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):

  • platform/graphics/blackberry/InstrumentedPlatformCanvas.h: Removed.
  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
(WebCore::LayerCompositingThread::contentsTexture):
(WebCore::LayerCompositingThread::commitPendingTextureUploads):
(WebCore):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(Graphics):
(LayerCompositingThread):

  • platform/graphics/blackberry/LayerCompositingThreadClient.h:

(Graphics):
(WebCore):
(LayerCompositingThreadClient):
(WebCore::LayerCompositingThreadClient::contentsTexture):
(WebCore::LayerCompositingThreadClient::commitPendingTextureUploads):

  • platform/graphics/blackberry/LayerData.h:

(WebCore::LayerData::LayerData):
(WebCore::LayerData::contentsResolutionIndependent):
(LayerData):
(WebCore::LayerData::layerProgram):
(WebCore::LayerData::isContainerForFixedPositionLayers):
(WebCore::LayerData::isFixedToTop):
(WebCore::LayerData::isFixedToLeft):
(WebCore::LayerData::frameVisibleRect):
(WebCore::LayerData::frameContentsSize):
(WebCore::LayerData::contentsScale):

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRendererAction::LayerFilterRendererAction):
(WebCore::LayerFilterRenderer::initializeSharedGLObjects):
(WebCore::LayerFilterRenderer::ping):
(WebCore::LayerFilterRenderer::pong):
(WebCore::LayerFilterRenderer::pushSnapshot):
(WebCore::LayerFilterRenderer::popSnapshot):
(WebCore::LayerFilterRenderer::applyActions):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore):
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::~LayerRenderer):
(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::useSurface):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::glRound):
(WebCore::LayerRenderer::toOpenGLWindowCoordinates):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::createProgram):
(WebCore::LayerRenderer::useProgram):
(WebCore::LayerRenderer::useLayerProgram):

  • platform/graphics/blackberry/LayerRenderer.h:

(LayerRenderer):

  • platform/graphics/blackberry/LayerRendererSurface.cpp:

(WebCore::LayerRendererSurface::ensureTexture):

  • platform/graphics/blackberry/LayerTile.cpp:

(WebCore::LayerTile::LayerTile):
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):

  • platform/graphics/blackberry/LayerTile.h:

(LayerTile):
(WebCore::LayerTile::renderState):
(WebCore::LayerTile::needsRender):
(WebCore::LayerTile::setNeedsRender):
(WebCore::LayerTile::setRenderPending):
(WebCore::LayerTile::setRenderDone):

  • platform/graphics/blackberry/LayerTileIndex.h:
  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore):
(WebCore::defaultTileSize):
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::createBuffer):
(WebCore::LayerTiler::willCommit):
(WebCore::LayerTiler::commitPendingTextureUploads):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTile):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::updateTileSize):
(WebCore::LayerTiler::setNeedsBacking):
(WebCore::LayerTiler::contentsTexture):

  • platform/graphics/blackberry/LayerTiler.h:

(WebCore::LayerTiler::tileSize):
(LayerTiler):
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):
(WebCore::LayerTiler::needsRender):
(WebCore::LayerTiler::removeUpdateContentsJobs):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::commitPendingTextureUploads):
(WebCore::LayerWebKitThread::setContents):
(WebCore::LayerWebKitThread::setNeedsCommit):
(WebCore::LayerWebKitThread::notifyAnimationsStarted):
(WebCore::LayerWebKitThread::commitOnWebKitThread):
(WebCore::LayerWebKitThread::startAnimations):
(WebCore::LayerWebKitThread::updateTextureContents):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore::LayerWebKitThread::addSublayer):
(WebCore):
(WebCore::LayerWebKitThread::addOverlay):
(WebCore::LayerWebKitThread::insert):
(WebCore::LayerWebKitThread::removeFromSuperlayer):
(WebCore::LayerWebKitThread::removeSublayerOrOverlay):
(WebCore::LayerWebKitThread::remove):
(WebCore::LayerWebKitThread::replaceSublayer):
(WebCore::LayerWebKitThread::filtersCanBeComposited):
(WebCore::LayerWebKitThread::removeAll):
(WebCore::LayerWebKitThread::setSublayers):
(WebCore::LayerWebKitThread::updateLayerHierarchy):
(WebCore::LayerWebKitThread::setIsMask):
(WebCore::LayerWebKitThread::releaseLayerResources):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(WebCore::LayerWebKitThread::insertSublayer):
(LayerWebKitThread):
(WebCore::LayerWebKitThread::isMask):
(WebCore::LayerWebKitThread::removeAllSublayers):
(WebCore::LayerWebKitThread::setFixedPosition):
(WebCore::LayerWebKitThread::setIsContainerForFixedPositionLayers):
(WebCore::LayerWebKitThread::setFixedToTop):
(WebCore::LayerWebKitThread::setFixedToLeft):
(WebCore::LayerWebKitThread::setFrameVisibleRect):
(WebCore::LayerWebKitThread::setFrameContentsSize):
(WebCore::LayerWebKitThread::setLayerProgram):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
(WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivate::prepareForRendering):
(WebCore):
(WebCore::MediaPlayerPrivate::resizeSourceDimensions):
(WebCore::MediaPlayerPrivate::percentLoaded):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
(WebCore::MediaPlayerPrivate::isProcessingUserGesture):
(WebCore::loadBufferingImageData):
(WebCore::MediaPlayerPrivate::setBuffering):
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):
(WebCore::MediaPlayerPrivate::onConditionallyEnterFullscreen):
(WebCore::MediaPlayerPrivate::onExitFullscreen):
(WebCore::MediaPlayerPrivate::onCreateHolePunchRect):
(WebCore::MediaPlayerPrivate::onDestroyHolePunchRect):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(BlackBerry):
(Platform):
(Graphics):
(MediaPlayerPrivate):

  • platform/graphics/blackberry/PluginLayerWebKitThread.cpp:

(WebCore::PluginLayerWebKitThread::setPluginView):

  • platform/graphics/blackberry/Texture.cpp:

(WebCore::Texture::Texture):
(WebCore::Texture::updateContents):
(WebCore::Texture::setContentsToColor):
(WebCore::Texture::protect):

  • platform/graphics/blackberry/Texture.h:

(Texture):
(WebCore::Texture::textureId):
(WebCore::Texture::isDirty):
(WebCore::Texture::hasTexture):
(WebCore::Texture::sizeInBytes):
(WebCore::Texture::setTextureId):
(WebCore::Texture::setSize):

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::allocateTextureId):
(WebCore::freeTextureId):
(WebCore::TextureCacheCompositingThread::collectGarbage):
(WebCore::TextureCacheCompositingThread::textureSizeInBytesChanged):
(WebCore):
(WebCore::TextureCacheCompositingThread::textureDestroyed):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::prune):
(WebCore::TextureCacheCompositingThread::clear):
(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::updateContents):

  • platform/graphics/blackberry/TextureCacheCompositingThread.h:

(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):

  • platform/graphics/blackberry/skia/ImageBufferDataSkia.h: Removed.
  • platform/graphics/blackberry/skia/PlatformSupport.cpp: Removed.
  • platform/graphics/blackberry/skia/PlatformSupport.h: Removed.
9:30 AM Changeset in webkit [144464] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Fix the Mac build with the current qtbase/dev branch
​https://bugs.webkit.org/show_bug.cgi?id=111190

Reviewed by Allan Sandfeld Jensen.

QMAKE_MACOSX_DEPLOYMENT_TARGET now influences
MAC_OS_X_VERSION_MIN_REQUIRED through -mmacosx-version-min after
changes in qtbase to support iOS.

Having only WebCore defining it to 10.5 would create a mismatch of
ENABLE_THREADING_LIBDISPATCH with WTF to cause undefined symbols
while linking both together at the end.

Fix it by removing the statement which isn't needed anymore.
qtbase/mkspecs/common/mac-minimum-version.conf already defines
10.6 as the minimum Mac version.

  • Target.pri:
9:06 AM Changeset in webkit [144463] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: [Regression] Snippets renaming is broken.
​https://bugs.webkit.org/show_bug.cgi?id=111181

Reviewed by Alexander Pavlov.

Source/WebCore:

  • inspector/front-end/NavigatorView.js:
  • inspector/front-end/ScriptSnippetModel.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.set _fileRenamed):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.rename):

LayoutTests:

  • inspector/debugger/script-snippet-model.html:
9:04 AM Changeset in webkit [144462] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a misspelled word in RenderObject.h. staticly -> statically.

Reviewed by Dean Jackson.

  • rendering/RenderObject.h:

(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::isPositioned):

8:58 AM Changeset in webkit [144461] by hyatt@apple.com
  • 9 edits in trunk/Source/WebCore

[New Multicolumn] Change flow thread containment to be a state.
​https://bugs.webkit.org/show_bug.cgi?id=111110

Change m_inRenderFlowThread from a single bit to an actual state. This
will let us track whether we're inside a multicolumn (in-flow) flow thread
or a named (out-of-flow) flow thread. In the former case, we're going to have
to do more work to maintain this state, but for now I've kept all the logic
the same just for the initial landing.

Reviewed by Andreas Kling.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
(WebCore::NodeRenderingContext::createRendererForTextIfNeeded):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clone):

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setFlowThreadStateIncludingDescendants):
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive):

  • rendering/RenderObject.h:

(WebCore::RenderObject::setParent):
(RenderObject):
(WebCore::RenderObject::inRenderFlowThread):
(WebCore::RenderObject::flowThreadState):
(WebCore::RenderObject::setFlowThreadState):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::flowThreadState):
(WebCore::RenderObject::RenderObjectBitfields::setFlowThreadState):

  • rendering/RenderView.cpp:

(WebCore::RenderView::addChild):

8:46 AM Changeset in webkit [144460] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix.

Roll out r144431 because it was a build fix for r144422, which was rolled out in r144446.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
8:28 AM Changeset in webkit [144459] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r144358): Add UNUSED_PARAM() macros to WebCore::Extensions3DOpenGL::drawBuffersEXT()
<​http://webkit.org/b/109331>

Fixes the following build failures:

Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:218:51: error: unused parameter 'n' [-Werror,-Wunused-parameter]
void Extensions3DOpenGL::drawBuffersEXT(GC3Dsizei n, const GC3Denum* bufs)


Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:218:70: error: unused parameter 'bufs' [-Werror,-Wunused-parameter]
void Extensions3DOpenGL::drawBuffersEXT(GC3Dsizei n, const GC3Denum* bufs)


2 errors generated.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::drawBuffersEXT): Add UNUSED_PARAM()
macros.

8:24 AM Changeset in webkit [144458] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[v8] ScriptValue has dangerous copy semantics
​https://bugs.webkit.org/show_bug.cgi?id=110206

Patch by Dan Carney <​dcarney@google.com> on 2013-03-01
Reviewed by Kentaro Hara.

Update ScriptValue to used a SharedPersistent,
making it impossible to return dead references.

No new tests. No change in functionality.

  • bindings/v8/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):

  • bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(ScriptValue):
(WebCore::ScriptValue::v8Value):
(WebCore::ScriptValue::v8ValueRaw):

  • bindings/v8/SharedPersistent.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::scriptValueAsNode):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAttrGetterCustom):

7:49 AM Changeset in webkit [144457] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/TestExpectations: Skipped failing test.
7:47 AM Changeset in webkit [144456] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Add FeatureObserver for marquee and reflection
​https://bugs.webkit.org/show_bug.cgi?id=111118

Reviewed by Simon Fraser.

Refactoring covered by existing tests.

  • page/FeatureObserver.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::styleChanged):
Added some instrumentation for reflection and marquee as they are both prefixed and this would help
to know their popularity on the web. Marquee was split between <marquee> (HTMLMarqueeElement) and
overflow: -webkit-marquee (CSSOverflowMarquee).

7:37 AM Changeset in webkit [144455] by apavlov@chromium.org
  • 16 edits in trunk

Web Inspector: Introduce opaque SecurityOrigin string identifiers in the frontend
​https://bugs.webkit.org/show_bug.cgi?id=111165

Reviewed by Vsevolod Vlasov.

Source/WebCore:

A plain string security origin value has been replaced by WebInspector.SecurityOrigin all over the code,
containing a URL (which holds a stringified security origin) and an identifier (which is now used
as a key in place of the stringified security origin in various maps). To avoid the ResourceTreeModel
code clutter, the security origin tracking code has been extracted into a separate type,
WebInspector.SecurityOriginTracker, which works as a helper on the ResourceTreeModel.

No new tests, as it is a refactoring.

  • inspector/front-end/DOMStorage.js:

(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.id):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):

  • inspector/front-end/ExtensionAuditCategory.js:
  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype._reset):
(WebInspector.FileSystemModel.prototype._securityOriginAdded):
(WebInspector.FileSystemModel.prototype._securityOriginRemoved):
(WebInspector.FileSystemModel.prototype._addOrigin):
(WebInspector.FileSystemModel.prototype._removeOrigin):
(WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
(WebInspector.FileSystemModel.prototype._fileSystemRootReceived):
(WebInspector.FileSystemModel.prototype._removeFileSystem):
(WebInspector.FileSystemModel.FileSystem.prototype.get name):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype._securityOriginAdded):
(WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
(WebInspector.IndexedDBModel.prototype._addOrigin):
(WebInspector.IndexedDBModel.prototype._removeOrigin):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.):
(WebInspector.IndexedDBModel.prototype._requestData):
(WebInspector.IndexedDBModel.DatabaseId.prototype.equals):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDatabaseView.prototype._refreshDatabase):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype.securityOriginForId):
(WebInspector.ResourceTreeModel.prototype.securityOrigins):
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.SecurityOriginTracker):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._addSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._removeSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._bindSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._unbindSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._detachMainFrame):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._securityOriginForId):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._securityOrigins):
(WebInspector.ResourceTreeFrame.prototype._navigate):
(WebInspector.SecurityOrigin.prototype.id):
(WebInspector.SecurityOrigin.prototype.url):
(WebInspector.SecurityOrigin.prototype.uiTitle):
(WebInspector.SecurityOrigin.prototype.toProtocol):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
(WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
(WebInspector.IDBIndexTreeElement.prototype.get itemURL):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
(WebInspector.FileSystemTreeElement):

LayoutTests:

Follow the string -> object conversion of the security origin.

  • http/tests/inspector-enabled/dom-storage-open.html:
  • http/tests/inspector/filesystem/delete-entry.html:
  • http/tests/inspector/filesystem/request-filesystem-root.html:
  • http/tests/inspector/indexeddb/database-data.html:
  • http/tests/inspector/indexeddb/database-names.html:
  • http/tests/inspector/indexeddb/database-structure.html:
  • http/tests/inspector/resource-tree/resource-tree-events.html:
7:25 AM Changeset in webkit [144454] by nghanavatian@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Reverse the base and extent of a selection when reversing its handles
​https://bugs.webkit.org/show_bug.cgi?id=111098

Reviewed by Yong Li.

PR283969
Swap the base and extent if base does not come first, and set the new selection.

Internally reviewed by Mike Fenton

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setSelection):

7:15 AM Changeset in webkit [144453] by eustas@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [Timeline] Show "curtains" when mouse is over CPU bar.
​https://bugs.webkit.org/show_bug.cgi?id=108930

Reviewed by Pavel Feldman.

This feature will help developers to focus on events
that caused CPU bar.

  • inspector/front-end/Popover.js: Added "arrowDirection" parameter.
  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid): Added "curtains".

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._mouseMove): Show/hide "curtains"
when mouse is over CPU bar.

  • inspector/front-end/timelinePanel.css: Added "curtains" style rules.
7:10 AM Changeset in webkit [144452] by rakuco@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Fix sign comparison warning/error after r144340.
​https://bugs.webkit.org/show_bug.cgi?id=111164

Reviewed by Mark Hahnenberg.

gcc (both 4.2.1 and 4.7.2) complain about comparing signed and
unsigned terms (clang accepts it just fine).

Work around that by casting the 1 to an uintptr_t as well.

  • dfg/DFGEdge.h:

(JSC::DFG::Edge::makeWord):

6:47 AM Changeset in webkit [144451] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code
Relanding fixed r144449.
​https://bugs.webkit.org/show_bug.cgi?id=105285

Reviewed by Vsevolod Vlasov.

Users can now Ctrl/Cmd-click CSS property names/values whose UI locations are found in
an external stylesheet/sass/other file. Inline stylesheets are not navigable,
since their start position is not detectable inside the surrounding HTML as of yet.

No new tests, a UI change.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSRule.prototype.isSourceNavigable): Whether the rule contains reliable source code information.
(WebInspector.CSSProperty.prototype.uiLocation): Returns a UILocation for the property name of value.

  • inspector/front-end/StylesSidebarPane.js: Add navigation code.

(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylePropertiesSection):

6:34 AM Changeset in webkit [144450] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r144449.
​http://trac.webkit.org/changeset/144449
​https://bugs.webkit.org/show_bug.cgi?id=111175

Breaks style-related inspector tests (Requested by apavlov on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-01

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSRule.prototype.get isRegular):
(WebInspector.CSSProperty.prototype.setDisabled):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylePropertiesSection):
(.event):
(.isRevert):

6:12 AM Changeset in webkit [144449] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code
​https://bugs.webkit.org/show_bug.cgi?id=105285

Reviewed by Vsevolod Vlasov.

Users can now Ctrl/Cmd-click CSS property names/values whose UI locations are found in
an external stylesheet/sass/other file. Inline stylesheets are not navigable,
since their start position is not detectable inside the surrounding HTML as of yet.

No new tests, a UI change.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSRule.prototype.isSourceNavigable): Whether the rule contains reliable source code information.
(WebInspector.CSSProperty.prototype.uiLocation): Returns a UILocation for the property name of value.

  • inspector/front-end/StylesSidebarPane.js: Add navigation code.

(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylePropertiesSection):

6:02 AM Changeset in webkit [144448] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, update image expectation again

  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
5:38 AM Changeset in webkit [144447] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r144443.
​http://trac.webkit.org/changeset/144443
​https://bugs.webkit.org/show_bug.cgi?id=111169

Caused 2 tests to crash by segv on Chromium Mac10.6 (Requested
by toyoshim on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-01

Source/WebCore:

  • css/mediaControls.css:

(video::-webkit-media-text-track-display):

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::isOutside):
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet):

LayoutTests:

  • media/track/track-cue-rendering-with-padding-expected.txt: Removed.
  • media/track/track-cue-rendering-with-padding.html: Removed.
5:30 AM Changeset in webkit [144446] by commit-queue@webkit.org
  • 208 edits
    7 deletes in trunk/Source

Unreviewed, rolling out r144422 and r144424.
​http://trac.webkit.org/changeset/144422
​http://trac.webkit.org/changeset/144424
​https://bugs.webkit.org/show_bug.cgi?id=111167

Caused over 20 tests to fail assertion on Chromium Win port as
ASSERTION FAILED: m_platformRequestUpdated (Requested by
toyoshim on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-01

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCPeerConnection.cpp:
  • Modules/notifications/Notification.cpp:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp:
  • bindings/js/JSNodeCustom.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptSourceCode.h:
  • bindings/objc/DOM.mm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):

  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:
  • css/WebKitCSSSVGDocumentValue.cpp:
  • css/WebKitCSSSVGDocumentValue.h:

(WebCore):

  • dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard):

  • dom/ContainerNode.cpp:
  • dom/DOMImplementation.cpp:
  • dom/PendingScript.h:
  • dom/ScriptElement.cpp:
  • dom/ScriptElement.h:
  • history/CachedFrame.cpp:
  • html/DOMURL.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAppletElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLHtmlElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/ImageDocument.cpp:
  • html/ImageInputType.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):

  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLParserOptions.cpp:
  • html/parser/HTMLScriptRunner.h:
  • html/parser/XSSAuditor.cpp:
  • html/parser/XSSAuditorDelegate.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorFileSystemAgent.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorInstrumentation.h:

(WebCore):

  • inspector/InspectorPageAgent.cpp:
  • inspector/NetworkResourcesData.cpp:
  • inspector/NetworkResourcesData.h:

(WebCore):

  • loader/CookieJar.cpp:
  • loader/CrossOriginAccessControl.cpp:
  • loader/CrossOriginAccessControl.h:

(WebCore):

  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):

  • loader/FrameLoader.h:

(WebCore):
(WebCore::FrameLoader::policyChecker):

  • loader/ImageLoader.cpp:
  • loader/ImageLoader.h:
  • loader/LinkLoader.h:
  • loader/MainResourceLoader.cpp:
  • loader/MainResourceLoader.h:
  • loader/MixedContentChecker.cpp:
  • loader/PingLoader.cpp:
  • loader/PolicyChecker.h:

(WebCore):

  • loader/ProgressTracker.cpp:
  • loader/SubframeLoader.cpp:
  • loader/SubresourceLoader.cpp:
  • loader/TextTrackLoader.cpp:
  • loader/TextTrackLoader.h:
  • loader/ThreadableLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h:

(WebCore):

  • loader/appcache/ApplicationCacheHost.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:

(CachedFontClient):
(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):
(WebCore):

  • loader/cache/CachedFontClient.h: Removed.
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedRawResource.h:

(WebCore):
(CachedRawResourceClient):
(WebCore::CachedRawResourceClient::~CachedRawResourceClient):
(WebCore::CachedRawResourceClient::expectedType):
(WebCore::CachedRawResourceClient::resourceClientType):
(WebCore::CachedRawResourceClient::dataSent):
(WebCore::CachedRawResourceClient::responseReceived):
(WebCore::CachedRawResourceClient::dataReceived):
(WebCore::CachedRawResourceClient::redirectReceived):
(WebCore::CachedRawResourceClient::dataDownloaded):

  • loader/cache/CachedRawResourceClient.h: Removed.
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceHandle.cpp:
  • loader/cache/CachedResourceHandle.h:

(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):

  • loader/cache/CachedSVGDocument.h:

(CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
(WebCore):

  • loader/cache/CachedSVGDocumentClient.h: Removed.
  • loader/cache/CachedSVGDocumentReference.cpp: Removed.
  • loader/cache/CachedSVGDocumentReference.h:

(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):

  • loader/cache/CachedStyleSheetClient.h:
  • loader/cache/MemoryCache.cpp:
  • loader/cache/MemoryCache.h:

(WebCore):
(MemoryCache):

  • loader/chromium/CachedRawResourceChromium.cpp:
  • loader/icon/IconController.cpp:
  • loader/icon/IconLoader.h:
  • loader/mac/ResourceLoaderMac.mm:
  • page/DOMWindowExtension.cpp:
  • page/DragController.cpp:
  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::reportMemoryUsage):

  • page/Frame.h:

(WebCore):
(Frame):
(WebCore::Frame::init):
(WebCore::Frame::loader):

  • page/PerformanceNavigation.cpp:
  • page/PerformanceTiming.cpp:
  • page/PointerLockController.cpp:
  • page/Settings.cpp:
  • page/animation/CSSPropertyAnimation.cpp:
  • platform/chromium/PasteboardChromium.cpp:
  • platform/efl/ErrorsEfl.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/filters/FilterOperation.cpp:
  • platform/graphics/filters/FilterOperation.h:

(WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
(WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/gtk/ErrorsGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/gtk/PasteboardHelper.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/PasteboardMac.mm:
  • platform/network/AuthenticationChallengeBase.cpp:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/cf/ResourceRequestCFNet.cpp:
  • platform/network/mac/CookieStorageMac.mm:
  • platform/qt/PasteboardQt.cpp:
  • plugins/DOMMimeType.cpp:
  • plugins/PluginRequest.h: Removed.
  • plugins/PluginStream.h:

(PluginStreamClient):
(WebCore::PluginStreamClient::~PluginStreamClient):
(WebCore::PluginStreamClient::streamDidFinishLoading):
(WebCore):

  • plugins/PluginStreamClient.h: Removed.
  • plugins/PluginView.cpp:
  • plugins/PluginView.h:

(WebCore):
(PluginRequest):
(WebCore::PluginRequest::PluginRequest):
(WebCore::PluginRequest::frameLoadRequest):
(WebCore::PluginRequest::notifyData):
(WebCore::PluginRequest::sendNotification):
(WebCore::PluginRequest::shouldAllowPopups):

  • rendering/HitTestResult.cpp:
  • rendering/InlineFlowBox.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderEmbeddedObject.cpp:
  • rendering/RenderImage.cpp:
  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::RenderImageResource):

  • rendering/RenderImageResource.h:

(WebCore::RenderImageResource::image):
(WebCore::RenderImageResource::errorOccurred):
(WebCore::RenderImageResource::usesImageContainerSize):
(WebCore::RenderImageResource::imageHasRelativeWidth):
(WebCore::RenderImageResource::imageHasRelativeHeight):
(WebCore::RenderImageResource::imageSize):

  • rendering/RenderImageResourceStyleImage.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerFilterInfo.h:
  • rendering/RenderListItem.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderSnapshottedPlugIn.cpp:
  • rendering/RenderTableCol.cpp:
  • rendering/RenderTableRow.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/style/StyleCachedShader.h:
  • rendering/style/StyleCustomFilterProgram.cpp: Removed.
  • rendering/style/StyleCustomFilterProgram.h:

(WebCore):
(WebCore::StyleCustomFilterProgram::vertexShaderString):
(StyleCustomFilterProgram):
(WebCore::StyleCustomFilterProgram::fragmentShaderString):
(WebCore::StyleCustomFilterProgram::isLoaded):
(WebCore::StyleCustomFilterProgram::willHaveClients):
(WebCore::StyleCustomFilterProgram::didRemoveLastClient):
(WebCore::StyleCustomFilterProgram::notifyFinished):

  • svg/SVGFEImageElement.h:
  • svg/SVGFontFaceUriElement.h:

(SVGFontFaceUriElement):

  • svg/SVGImageLoader.cpp:
  • svg/SVGUseElement.cpp:
  • svg/SVGUseElement.h:
  • svg/graphics/SVGImageCache.cpp:
  • testing/MockPagePopupDriver.cpp:
  • xml/XSLStyleSheet.h:
  • xml/XSLTProcessorLibxslt.cpp:
  • xml/parser/XMLDocumentParser.cpp:
  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:
  • src/AssociatedURLLoader.cpp:
  • src/EditorClientImpl.cpp:
  • src/SharedWorkerRepository.cpp:
  • src/WebDataSourceImpl.cpp:
  • src/WebFrameImpl.h:

(WebCore):

  • src/WebNode.cpp:
  • src/WebSharedWorkerImpl.cpp:
  • tests/FrameLoaderClientImplTest.cpp:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • ewk/ewk_frame.cpp:

Source/WebKit/gtk:

  • webkit/webkitwebpolicydecision.cpp:

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm:
  • Misc/WebNSPasteboardExtras.mm:
  • WebCoreSupport/WebFrameNetworkingContext.mm:
  • WebView/WebRenderLayer.mm:
  • WebView/WebRenderNode.mm:

Source/WebKit/qt:

  • WebCoreSupport/NotificationPresenterClientQt.cpp:
  • WebCoreSupport/QWebPageAdapter.cpp:

Source/WebKit2:

  • NetworkProcess/HostRecord.h:
  • NetworkProcess/NetworkResourceLoadScheduler.h:
  • NetworkProcess/NetworkResourceLoader.h:

(WebCore):

  • Shared/WebRenderLayer.cpp:
  • Shared/WebRenderObject.cpp:
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/WebProcess.cpp:
  • WebProcess/soup/WebProcessSoup.cpp:
4:59 AM Changeset in webkit [144445] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, cleanup lint errors #2
Remove duplicated entries.

  • platform/chromium/TestExpectations:
4:57 AM Changeset in webkit [144444] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: fix closure compiler warnings in ProfilesPanel
​https://bugs.webkit.org/show_bug.cgi?id=111163

Patch by Alexei Filippov <​alph@chromium.org> on 2013-03-01
Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView.prototype.addProfileType):

  • inspector/front-end/ProfilesPanel.js:
4:32 AM Changeset in webkit [144443] by vcarbune@chromium.org
  • 4 edits
    2 adds in trunk

Support padding, margin and border for internal UA cue styling
​https://bugs.webkit.org/show_bug.cgi?id=110703

Reviewed by Eric Carlson.

Source/WebCore:

For some particular user agent styling this allows the possibility
of making the window around the cue text bigger to match some user
styles (see CaptionUserPreferencesMac::captionsStyleSheetOverride).

These properties *cannot* be set through by using the ::cue
pseudo-element and, as specified, are used only internally.

Test: media/track/track-cue-rendering-with-padding.html

  • css/mediaControls.css:

(video::-webkit-media-text-track-display): Set the CSS box model
to include in the specified width or height the values of
padding / margin / border by using -webkit-box-sizing and avoid
overflow over 100% width because of having these properties set.

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::isOutside): To not interfere with
the regular WebVTT positioning algorithm, the check is done for
the absolute content box.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Added
an extra adjustment step to accomodate vertical padding (and not
overflow the cue container)

LayoutTests:

  • media/track/track-cue-rendering-with-padding-expected.txt: Added.
  • media/track/track-cue-rendering-with-padding.html: Added.
4:26 AM Changeset in webkit [144442] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening

  • platform/chromium/TestExpectations:
4:17 AM Changeset in webkit [144441] by allan.jensen@digia.com
  • 4 edits in trunk

[Qt] Enable LINK_PREFETCH
​https://bugs.webkit.org/show_bug.cgi?id=111158

Reviewed by Simon Hausmann.

Tools:

  • qmake/mkspecs/features/features.pri:

LayoutTests:

Unskip tests depending on LINK_PREFETCH.

  • platform/qt/TestExpectations:
4:13 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
4:05 AM Changeset in webkit [144440] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Fix failing API tests after r143935
​https://bugs.webkit.org/show_bug.cgi?id=111086

Reviewed by Jocelyn Turcotte.

Convert a leftorver resume call to the new resumeAndUpdateContent() call
in PageViewportControllerClientQt so that the notifications about zoom
animation state changes reach the API tests.

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):

4:04 AM Changeset in webkit [144439] by eustas@chromium.org
  • 7 edits in trunk

Web Inspector: Save/load timeline should preserve DOMContentLoaded and Load event markers
​https://bugs.webkit.org/show_bug.cgi?id=110819

Reviewed by Pavel Feldman.

To create event divider TimelinePresentation model checks if record
frame is main frame. With this patch check is moved to backend and
result is saved in record to avoid incoherence.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
Record "isMainFrame" flag.
(WebCore::InspectorTimelineAgent::didMarkLoadEvent): Ditto.

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createMarkData):
Added data object constructor.

  • inspector/TimelineRecordFactory.h: Ditto.
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.isEventDivider):
Use saved flag value instead of comparing with "current" main frame.

4:01 AM Changeset in webkit [144438] by allan.jensen@digia.com
  • 2 edits in trunk/Tools

[Qt] Update features.pri with new features
​https://bugs.webkit.org/show_bug.cgi?id=111157

Reviewed by Jocelyn Turcotte.

  • qmake/mkspecs/features/features.pri:
3:46 AM Changeset in webkit [144437] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
​https://bugs.webkit.org/show_bug.cgi?id=111077

Reviewed by Pavel Feldman.

Analysis: DataGridNode.refresh removes all cells and then recreates them.
The issue is that mandatory "corner" cell is not recreated.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGridNode.prototype.refresh):
Added "corner" cell restoration code.

3:39 AM Changeset in webkit [144436] by g.czajkowski@samsung.com
  • 20 edits
    2 adds in trunk/Source/WebKit2

[WK2] Asynchronous spell checking implementation
​https://bugs.webkit.org/show_bug.cgi?id=109577

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com>, Mariusz Grzegorczyk <​mariusz.g@samsung.com> on 2013-03-01
Reviewed by Enrica Casucci.

Associate the abstract 'WebCore::TextCheckingRequest' object with the unique identifier
on WebProcess side. The request data from the 'TextCheckingRequest' are retrieved and
passed to the UIProcess. The WK2 client (TextChecker{Gtk/Mac/Efl/Qt}.cpp) gets
the 'TextCheckerCompletion' object with the request data and possibility to notify
the WebProcess about the spelling results.
Finally, the WebPage object calls on the proper 'TextCheckingRequest' object
didSuccess/didCancel method to notify the WebCore about the spelling result.

  • CMakeLists.txt:
  • GNUmakefile.list.am:

Add 'TextCheckerCompletion.{h/cpp}' to the WebKit2 cmake based and
WK2-Gtk+ builds.

  • Scripts/webkit2/messages.py:

(headers_for_type):
Add exception for 'TextCheckingRequestData' class to properly find header
file for it.

  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:

Teach 'ArgumentCoder' how to encode/decode 'TextCheckingRequestData' class.

  • Target.pri:

Add 'TextCheckerCompletion.{h/cpp}' to the WK2-Qt build.

  • UIProcess/TextChecker.h:

Add 'requestCheckingOfString' method to the TextChecker's interface.

  • UIProcess/TextCheckerCompletion.cpp: Added.

(WebKit::TextCheckerCompletion::create):
(WebKit::TextCheckerCompletion::TextCheckerCompletion):

(WebKit::TextCheckerCompletion::spellDocumentTag):
Return the WebPageProxy's spellDocumentTag as the client might be
interested in from which page the request came.

(WebKit::TextCheckerCompletion::textCheckingRequestData):
Allow to retrieve 'TextCheckingRequestData' object.

(WebKit::TextCheckerCompletion::didFinishCheckingText):
(WebKit::TextCheckerCompletion::didCancelCheckingText):
Notify the 'WebPageProxy' object that the given request has been
handled or canceled.

  • UIProcess/TextCheckerCompletion.h: Added.

Introduce a new class for WK2 to retrieve the request data and
call didFinishCheckingText/didCancelCheckingText.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestCheckingOfString):
Create 'TextCheckerCompletion' object and pass it
to the 'TextChecker::requestCheckingOfString' method.

(WebKit::WebPageProxy::didFinishCheckingText):
(WebKit::WebPageProxy::didCancelCheckingText):
Send the messages to WebProcess that the given request has been
handled or canceled.

  • UIProcess/WebPageProxy.h:

(WebPageProxy):
Add public declarations for 'didFinishCheckingText', 'didCancelCheckingText'.
Add private declarations for 'requestCheckingOfString'.
Move the 'spellDocumentTag()' method to to the public section to be
accessible from 'TextCheckerCompletion' class.

  • UIProcess/WebPageProxy.messages.in:

A new entry for 'RequestCheckingOfString'.

  • UIProcess/efl/TextCheckerEfl.cpp:

(WebKit::TextChecker::requestCheckingOfString):
(WebKit):

  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::requestCheckingOfString):
(WebKit):

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::requestCheckingOfString):
(WebKit):

  • UIProcess/qt/TextCheckerQt.cpp:

(WebKit::TextChecker::requestCheckingOfString):
(WebKit):
Add dummy implementations for 'requestCheckingOfString'.

  • WebKit2.xcodeproj/project.pbxproj:

Add 'TextCheckerCompletion.{h/cpp} to Mac build.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::generateTextCheckingRequestID):
Helper function to generate the unique identifier for the abstract
'TextCheckingRequest' object.

(WebKit::WebEditorClient::requestCheckingOfString):
Associate 'TextCheckingRequest' with the unique identifier and add them
to the map object.
Get the request data and send it to the UIProcess.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::addTextCheckingRequest):
Add the identifier and the request to the map object.

(WebKit::WebPage::didFinishCheckingText):
(WebKit::WebPage::didCancelCheckingText):
Call didSucceed/didCancel on the 'TextCheckingRequest' to notify the WebCore
about spellcheking results.
Remove the request from the map object.

  • WebProcess/WebPage/WebPage.h:

Add declarations for 'addTextCheckingRequest', 'didFinishCheckingText' and
'didCancelCheckingText.'

  • WebProcess/WebPage/WebPage.messages.in:

Add a new entry for DidFinishCheckingText, DidCancelCheckingText.

3:36 AM Changeset in webkit [144435] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

Flaky test: http/tests/inspector/resource-tree/resource-request-content-while-loading.html
​https://bugs.webkit.org/show_bug.cgi?id=111123

Reviewed by Alexander Pavlov.

  • TestExpectations:
  • http/tests/inspector/resource-tree/resource-request-content-while-loading.html:
  • platform/chromium/TestExpectations:
2:33 AM Changeset in webkit [144434] by apavlov@chromium.org
  • 18 edits
    5 adds in trunk

Web Inspector: Selector's raw start position in its line is considered to be 0 when computing UILocation
​https://bugs.webkit.org/show_bug.cgi?id=110732

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/styles/selector-line.html

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::sizetExtractor): Utility for binary search.
(WebCore::ContentSearchUtils::textPositionFromOffset): Converts absolute raw text offset into line:column.
(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines): Refactor.
(WebCore::ContentSearchUtils::lineEndings): Factored out of getRegularExpressionMatchesByLines.
(WebCore::ContentSearchUtils::buildObjectForSearchMatch): Drive-by: pass String by reference.

  • inspector/ContentSearchUtils.h:
  • inspector/Inspector.json: Use line:column for SourceRange boundaries rather than raw offsets.
  • inspector/InspectorStyleSheet.cpp:

(ParsedStyleSheet::text): ASSERT(m_hasText).
(WebCore::InspectorStyle::buildObjectForStyle): Supply the lineEndings argument.
(WebCore::buildSourceRangeObject): Follow the protocol change.
(WebCore::InspectorStyle::setPropertyText): Refactor.
(WebCore::InspectorStyle::toggleProperty): Ditto.
(WebCore::InspectorStyle::styleText): Ditto.
(WebCore::InspectorStyle::populateAllProperties): Ditto.
(WebCore::InspectorStyle::styleWithProperties): Convert relative property range offsets into absolute ones.
(WebCore::InspectorStyle::extractSourceData): Factored out.
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters): Supply the lineEndings argument.
(WebCore::InspectorStyleSheet::buildObjectForSelectorList): Ditto.
(WebCore::InspectorStyleSheet::lineEndings): Compute line endings for ordinary stylesheets.
(WebCore::InspectorStyleSheetForInlineStyle::lineEndings): Ditto for bogus inline style stylesheets.

  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/AuditRules.js: Removed the byte counting for unused CSS.
  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSRule): Set selector rawLocation based on the selectorList range or sourceLine.
(WebInspector.CSSRule.prototype._setRawLocation): Added.

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping.prototype._bindUISourceCode): Fix call order when binding scss sourcecodes.

LayoutTests:

Changed tests have been rebaselined to follow the new source range structure.

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.rangeText): Fix source range dumping format.

  • inspector/audits/audits-panel-functional-expected.txt:
  • inspector/audits/audits-panel-noimages-functional-expected.txt:
  • inspector/styles/get-set-stylesheet-text-expected.txt:
  • inspector/styles/parse-stylesheet-errors-expected.txt:
  • inspector/styles/resources/selector-line.css: Added.
  • inspector/styles/resources/selector-line.css.map: Added.
  • inspector/styles/resources/selector-line.scss: Added.
  • inspector/styles/selector-line-expected.txt: Added.
  • inspector/styles/selector-line.html: Added.
  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-source-offsets-expected.txt:
  • inspector/styles/styles-source-offsets.html:
2:19 AM Changeset in webkit [144433] by jochen@chromium.org
  • 2 edits in trunk/Tools

[chromium] put WebTestProxy::scheduleComposite back in place
​https://bugs.webkit.org/show_bug.cgi?id=111146

Reviewed by Nico Weber.

The call was removed in ​http://trac.webkit.org/changeset/144398 because
DRT doesn't need it. However, content shell depends on this call.

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner::WebTestProxy::scheduleComposite):

2:13 AM Changeset in webkit [144432] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Get rid of two silly static null Strings
​https://bugs.webkit.org/show_bug.cgi?id=111151

Reviewed by Eric Seidel.

We have a global null String through nullAtom, there is no need
for local static null strings.

  • page/Page.cpp:

(WebCore::Page::groupName):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::markerText):

2:03 AM Changeset in webkit [144431] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Add a missing #include.
1:45 AM Changeset in webkit [144430] by mkwst@chromium.org
  • 5 edits
    1 add in trunk/LayoutTests

[Mac] [WK1] http/tests/xmlhttprequest/navigation-should-abort.html fails
​https://bugs.webkit.org/show_bug.cgi?id=111052

Reviewed by Alexey Proskuryakov.

Currently, this test is failing to output the textual content of the
'data:' URL to which the test navigates. Replacing this 'data:' URL
with a "real" HTML file ensures that Mac WK1 behaves the same way as
the other ports for this test.

This doesn't really address the issue raised: navigation to a 'data:'
URL should behave in the same way as a "real" URL; filed
​http://wkbug.com/111152 to track that issue.

  • http/tests/xmlhttprequest/resources/navigation-target.html: Added.

Add an actual file to which we can navigate.

  • http/tests/xmlhttprequest/navigation-should-abort-expected.txt:
  • http/tests/xmlhttprequest/navigation-should-abort.html:

Navigate to the new HTML file during the test rather than an inlined
data: URL.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:

Remove the expectations set in r144277.

1:44 AM Changeset in webkit [144429] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk-wk1/TestExpectations: Removing expectation for the fast/canvas/canvas-currentPath-crash.html test.
  • platform/gtk/media/video-playing-and-pause-expected.txt: Rebaselining.
1:37 AM Changeset in webkit [144428] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix code-mirror experiment to work in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=111064

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-01
Reviewed by Pavel Feldman.

No new tests: no change in behaviour.

Improve importScript function to try load a script from the root
directory iff its loading from the given path failed.

  • inspector/front-end/utilities.js:
1:18 AM Changeset in webkit [144427] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] capture a WebGL extension by it's name in lower case
​https://bugs.webkit.org/show_bug.cgi?id=110745

Reviewed by Pavel Feldman.

WebGL's getExtension accepts a name that is tested against an ASCII case-insensitive match.
Just force lower case for extension names.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

1:07 AM Changeset in webkit [144426] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Fix definition of DatePickerClient::setValue()
​https://bugs.webkit.org/show_bug.cgi?id=110336

Patch by Alberto Garcia <​albgarcia@rim.com> on 2013-03-01
Reviewed by Carlos Garcia Campos.

The definition of DatePickerClient::setValue() introduced in
r142987 does not match the prototype.

  • WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::setValue):

12:47 AM Changeset in webkit [144425] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

XSSAuditor should use threadSafeMatch when relevant.
​https://bugs.webkit.org/show_bug.cgi?id=111099

Reviewed by Adam Barth.

Given the work on breaking parsing out into a background thread, we
should compare QualifiedNames in a thread-safe manner. Rather than
casting the result of QualifiedName::localName to a String, we can
call out to threadSafeMatch to do the comparison.

This patch leaves one use of equalIgnoringNullity in
XSSAuditor::findAttributeWithName. That usage seems safe, since we're
creating a new string against which to compare.

  • html/parser/XSSAuditor.cpp:

(WebCore::hasName):

Replace call to equalIgnoringNullity(Vector<UChar...>, String)
with threadSafeMatch(String, QualifiedName).

12:23 AM Changeset in webkit [144424] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

REGRESSION(r144422): Broke compilation on chromium-mac
​https://bugs.webkit.org/show_bug.cgi?id=111150

Unreviewed build fix.

  • src/WebFrameImpl.h:

(WebCore):

Note: See TracTimeline for information about the timeline view.