Timeline



Jun 22, 2013:

11:24 PM Changeset in webkit [151887] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove redundant helper from RenderRegion.
​https://bugs.webkit.org/show_bug.cgi?id=117915

Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-22
Reviewed by Andreas Kling.

Minor code cleanup.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):

  • rendering/RenderRegion.h:
11:14 PM Changeset in webkit [151886] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL] Add support for MHTML save/load feature to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=106620

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-06-22
Reviewed by Christophe Dumez.

Enable CTRL + S as save page in mhtml and CTRL + L to load any page
from filesystem.

  • MiniBrowser/efl/CMakeLists.txt:
  • MiniBrowser/efl/main.c:

(page_contents_callback):
(on_key_down):
(show_file_entry_dialog): generic function to show file enrty
selector dialogue

9:57 PM Changeset in webkit [151885] by fpizlo@apple.com
  • 10 edits
    6 adds in branches/dfgFourthTier

fourthTier: DFG shouldn't exit just because a String GetByVal went out-of-bounds
​https://bugs.webkit.org/show_bug.cgi?id=117906

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

This does the obvious thing, but also makes sure that out-of-bounds accesses
don't fall off into a C call, but try to do the fast thing if the prototype
chain is sane. We ought to probably do this for other array accesses in the
future, as well, since it's so darn easy.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::objectPrototypeIsSane):
(JSC):
(JSC::JSGlobalObject::arrayPrototypeChainIsSane):
(JSC::JSGlobalObject::stringPrototypeChainIsSane):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

LayoutTests:

Reviewed by Mark Hahnenberg.

The out-of-bounds benchmark that isn't insane speeds up by 22x in this
patch.

  • fast/js/regress/script-tests/string-get-by-val-out-of-bounds-insane.js: Added.

(foo):

  • fast/js/regress/script-tests/string-get-by-val-out-of-bounds.js: Added.

(foo):

  • fast/js/regress/string-get-by-val-out-of-bounds-expected.txt: Added.
  • fast/js/regress/string-get-by-val-out-of-bounds-insane-expected.txt: Added.
  • fast/js/regress/string-get-by-val-out-of-bounds-insane.html: Added.
  • fast/js/regress/string-get-by-val-out-of-bounds.html: Added.
8:31 PM Changeset in webkit [151884] by jberlin@webkit.org
  • 5 edits in tags/Safari-537.46.5/Source

“Versioning.”

8:28 PM Changeset in webkit [151883] by jberlin@webkit.org
  • 1 copy in tags/Safari-537.46.5

New tag.

6:42 PM Changeset in webkit [151882] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: GC's put_by_id transition fixpoint should converge more quickly
​https://bugs.webkit.org/show_bug.cgi?id=117912

Reviewed by Mark Hahnenberg.

This was a rookie mistake. The GC does a classic forward data flow fixpoint. These work well so long as you
iterate the program in program order, or at least something close to program order. Because I enjoy reverse
loops ("while (n--) blah"), I ended up iterating in *reverse* of program order which ensured worst-case
pathologies every single time. And unsurprisingly, this slowed down a program, namely pdfjs.

Flipping the loops to iterate forward fixes a 90% regression in Octane/pdfjs and is otherwise neutral.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::propagateTransitions):

4:33 PM Changeset in webkit [151881] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Slightly reduce width threshold on detection of primary snapshotted Plug-In
​https://bugs.webkit.org/show_bug.cgi?id=117914
<rdar://problem/14136687>

Reviewed by Simon Fraser.

We've noticed some content that should be detected as the primary snapshotted plug-in,
but is just a bit smaller than our 450x300 minimum threshold. Reduce the width to 400.

  • WebProcess/WebPage/WebPage.cpp: Change primarySnapshottedPlugInMinimumWidth from 450 to 400.
4:16 PM Changeset in webkit [151880] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r151878.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::startLoading): Pass the new UseDefaultOriginRestrictionsForType
argument to the ResourceLoaderOptions constructor.

1:29 PM Changeset in webkit [151879] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Followup from r151877 .
Fix crash in fast/frames/iframe-access-screen-of-deleted.html by null-checking the widget.

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenForWidget):

12:56 PM Changeset in webkit [151878] by hmuller@adobe.com
  • 14 edits
    3 adds in trunk

[CSS Shapes] limit shape image values to same origin
​https://bugs.webkit.org/show_bug.cgi?id=117610

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Restrict the image URL values for shape-inside and shape-outside to
the same origin as the document. The alpha channel of image shape values
will be thresholded to produce the shape's boundaries (see bug 116643)
so normal image access rules aren't secure enough.

Added a RequestOriginPolicy ResourceLoaderOption which is used by
StyleResolver::loadPendingShapeImage() to request the additional restriction.
The change should have no other effect although it does enable one to apply
the same restriction to other resources which can currently be loaded from
any origin - see CachedResourceLoader::canRequest().

Test: http/tests/security/shape-inside-image-origin.html

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage): Add an effectively optional ResourceLoaderOptions parameter.

  • css/CSSImageValue.h:

(WebCore::CSSImageValue::cachedImage): Ditto.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingShapeImage): Load the image with the default CachedResourceLoader options plus RestrictToSameOrigin.
(WebCore::StyleResolver::loadPendingImages): Call loadPendingShapeImage().

  • css/StyleResolver.h:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource): Update the ResourceLoaderOptions static variable.

  • loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): Ditto.

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::options):

  • loader/ResourceLoaderOptions.h: Add RequestOriginPolicy enum.

(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest): Pass ResourceLoaderOptions along to revised CachedResourceLoader::canRequest().

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Update load() ResourceLoaderOptions.
(WebCore::CachedResourceLoader::canRequest): Replaced ContentSecurityPolicyCheck parameter with ResourceLoaderOptions.
(WebCore::CachedResourceLoader::requestResource): Pass ResourceLoaderOptions along to revised CachedResourceLoader::canRequest().
(WebCore::CachedResourceLoader::defaultCachedResourceOptions): Added UseDefaultOriginRestrictionsForType initializer.

  • loader/cache/CachedResourceLoader.h:
  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading): Added UseDefaultOriginRestrictionsForType intializer.

LayoutTests:

Verify that a non same-origin image URL specified for shape-inside or
shape-outside will not load and the shape property will be reset to "none".

  • http/tests/resources/square100.png: Added.
  • http/tests/security/shape-inside-image-origin-expected.txt: Added.
  • http/tests/security/shape-inside-image-origin.html: Added.
12:41 PM Changeset in webkit [151877] by Simon Fraser
  • 11 edits
    1 add in trunk/Source

screen.availWidth always returns width of primary display
​https://bugs.webkit.org/show_bug.cgi?id=117863

Source/WebCore:

Reviewed by Geoffrey Garen.

In WebKit2, Widgets have no platformWidget, so trying to get to the
NSScreen via the platform widget's window never succeeded, and we always
fell back on getting info for the main display.

However, we were already pushing the WKView's displayID down to the
WebProcess for the requestAnimationFrame infrastructure, so use that.

Add a virtual function on Widget windowDisplayID(), that is overridden
in FrameView to return the PlatformDisplayID which Page has.

Fix PlatformScreenMac to fall back to Widget::windowDisplayID() when it fails
to get an NSWindow from the Widget.

Add a utility category on NSScreen to get an NSScreen's displayID, and to
find an NSScreen given a displayID.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp:

(WebCore::FrameView::windowDisplayID):

  • page/FrameView.h:
  • platform/Widget.cpp:

(WebCore::Widget::windowDisplayID):

  • platform/Widget.h:
  • platform/mac/PlatformScreenMac.h: Added.
  • platform/mac/PlatformScreenMac.mm:

(+[NSScreen screenForDislayID:]):
(-[NSScreen displayID]):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::windowDisplayID):

Source/WebKit2:

Reviewed by Geoffrey Garen.

In WebKit2, Widgets have no platformWidget, so trying to get to the
NSScreen via the platform widget's window never succeeded, and we always
fell back on getting info for the main display.

However, we were already pushing the WKView's displayID down to the
WebProcess for the requestAnimationFrame infrastructure, so use that.

The WebProcess would not receive a displayID for a WKView until the window
was activated; fix by calling -doWindowDidChangeScreen when the view
moves to a window, rather than doing it from -_windowDidBecomeKey:.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):

Jun 21, 2013:

10:56 PM Changeset in webkit [151876] by fpizlo@apple.com
  • 4 edits
    3 adds in branches/dfgFourthTier

fourthTier: DFG should CSE MakeRope
​https://bugs.webkit.org/show_bug.cgi?id=117905

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Adds MakeRope to the CSE phase and removes the comment that says that
we could do it but aren't doing it.

Also fixed SpeculatedType dumping so that if you have a Cell type then
it just prints "Cell" and if you just have Object then it just prints
"Object", instead of printing the long list of types.

  • bytecode/SpeculatedType.cpp:

(JSC::dumpSpeculation):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

LayoutTests:

Reviewed by Geoffrey Garen.

This benchmark speeds up by 50%.

  • fast/js/regress/make-rope-cse-expected.txt: Added.
  • fast/js/regress/make-rope-cse.html: Added.
  • fast/js/regress/script-tests/make-rope-cse.js: Added.

(foo):

7:36 PM Changeset in webkit [151875] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Crashes due to NULL dereference beneath WebCore::StyleResolver::loadPendingSVGDocuments and related functions
​https://bugs.webkit.org/show_bug.cgi?id=117903

Reviewed by Darin Adler.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingSVGDocuments): Add a NULL check for
RenderStyle here...
(WebCore::StyleResolver::loadPendingResources): ...and here.

7:27 PM Changeset in webkit [151874] by fpizlo@apple.com
  • 7 edits
    3 adds in branches/dfgFourthTier

fourthTier: DFG should't exit just because it GetByVal'd a big character
​https://bugs.webkit.org/show_bug.cgi?id=117899

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Add a slow path. Also clarify handling of GetByVal in PutStructure elimination.
Previously it would fail due to canExit() but now we can also fail because
GetByVal(String) can allocate. Just make it so GetByVal is totally poisoned, in
a very explicit way.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::putStructureStoreElimination):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):

LayoutTests:

Reviewed by Mark Hahnenberg.

This benchmark speeds up by 3x.

  • fast/js/regress/script-tests/string-get-by-val-big-char.js: Added.

(foo):

  • fast/js/regress/string-get-by-val-big-char-expected.txt: Added.
  • fast/js/regress/string-get-by-val-big-char.html: Added.
6:10 PM Changeset in webkit [151873] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Occasional crash swiping between pages
​https://bugs.webkit.org/show_bug.cgi?id=117902

Reviewed by Beth Dakin.

m_scrollingStateTree->rootStateNode() can be null when quickly swiping between pages,
so check this in ScrollingCoordinatorMac::commitTreeState().

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::commitTreeState):

5:25 PM Changeset in webkit [151872] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed crash protection for DRT

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines

to avoid crashing during test runs.

5:13 PM Changeset in webkit [151871] by mark.lam@apple.com
  • 2 edits in branches/dfgFourthTier/Source/WebCore

Fixed broken build: updated to match SmallStrings changes in r151864.

Not reviewed.

No new tests.

  • bindings/js/JSDOMBinding.h:

(WebCore::jsStringWithCache):

5:08 PM Changeset in webkit [151870] by Brent Fulgham
  • 1 edit
    1 add in trunk/LayoutTests

[Windows] Unreviewed gardening.

  • platform/win/accessibility/aria-menubar-menuitems-expected.txt: Added.
4:58 PM Changeset in webkit [151869] by mark.lam@apple.com
  • 11 edits
    1 add in trunk

Source/JavaScriptCore: Introducing the VMStackBounds class.
​https://bugs.webkit.org/show_bug.cgi?id=117862.

Reviewed by Geoffrey Garen.

  • Removed Interpreter::StackPolicy.
  • The new VMStackBounds will take over choosing the appropriate stack size requirements, and invoking the underlying WTF::StackBounds to to the real bounds check.
  • VMStackBounds will now be used universally throughout JSC instead of WTF::StackBounds.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

  • interpreter/Interpreter.h:

(JSC::Interpreter::isInErrorHandlingMode):

  • parser/Parser.cpp:

(JSC::::Parser):

  • parser/Parser.h:
  • runtime/StringRecursionChecker.h:

(JSC::StringRecursionChecker::performCheck):

  • runtime/VMStackBounds.h: Added.

(JSC::VMStackBounds::VMStackBounds):
(JSC::VMStackBounds::isSafeToRecurse):
(JSC::VMStackBounds::requiredCapacity):

LayoutTests: Reverting failure expectation for fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html.
​https://bugs.webkit.org/show_bug.cgi?id=117862.

Reviewed by Geoffrey Garen.

  • platform/mac/TestExpectations:
4:39 PM Changeset in webkit [151868] by Brent Fulgham
  • 3 edits
    3 adds in trunk

AX: Title for ListItemRole should consist of concatenated child text elements.
​https://bugs.webkit.org/show_bug.cgi?id=117892

Reviewed by Chris Fleizach.

Source/WebCore:

accessibility/listitem-title.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::visibleText): Add ListItemRole to set of
elements that concatenate their children for display purposes.
(WebCore::AccessibilityNodeObject::title): Ditto.

LayoutTests:

  • accessibility/listitem-title.html: Added.
  • platform/mac/accessibility/listitem-title-expected.txt: Added.
  • platform/win/accessibility/listitem-title-expected.txt: Added.
4:28 PM Changeset in webkit [151867] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit

Merged r151847. <rdar://problem/14231905>

4:27 PM Changeset in webkit [151866] by Lucas Forschler
  • 8 edits in branches/safari-537-branch/Source

Merged r151787. <rdar://problem/14219184>

4:23 PM Changeset in webkit [151865] by Lucas Forschler
  • 6 edits
    3 deletes in branches/safari-537-branch/LayoutTests

Merged r151801.

4:05 PM Changeset in webkit [151864] by fpizlo@apple.com
  • 8 edits
    3 adds in branches/dfgFourthTier

fourthTier: Small strings shouldn't get GC'd
​https://bugs.webkit.org/show_bug.cgi?id=117897

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Kill off the code needed to allocate them lazily and finalize them.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • runtime/JSString.h:

(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring8):
(JSC::jsSubstring):
(JSC::jsOwnedString):

  • runtime/NumberPrototype.cpp:

(JSC::integerValueToString):

  • runtime/SmallStrings.cpp:

(JSC):
(JSC::SmallStrings::initializeCommonStrings):
(JSC::SmallStrings::visitStrongReferences):

  • runtime/SmallStrings.h:

(JSC::SmallStrings::singleCharacterString):
(SmallStrings):

LayoutTests:

Reviewed by Mark Hahnenberg.

This test speeds up by 5%.

  • fast/js/regress/script-tests/string-get-by-val.js: Added.

(foo):

  • fast/js/regress/string-get-by-val-expected.txt: Added.
  • fast/js/regress/string-get-by-val.html: Added.
3:50 PM Changeset in webkit [151863] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[MediaStream]: Remove >= 0 assertion from a size_t variable
​https://bugs.webkit.org/show_bug.cgi?id=117890

Patch by Sergio Correia <Sergio Correia> on 2013-06-21
Reviewed by Adam Barth.

This patch fixes a strict build by removing the >= 0 assertion from
a size_t (unsigned type) variable in RTCStatsResponse.cpp.

No new tests; build fix.

  • Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::addStatistic): Remove >=0assertion,
since the variable is unsigned and is always >= 0.

3:20 PM Changeset in webkit [151862] by Lucas Forschler
  • 5 edits in tags/Safari-537.46.4/Source

Versioning.

3:13 PM Changeset in webkit [151861] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught exception when pretty printing WebInspector.Script
​https://bugs.webkit.org/show_bug.cgi?id=117893

This was an issue with an earlier refactoring. The sourceCode is a Script,
so replace the non-existent local variable "script" with "this._sourceCode".

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-06-21
Reviewed by Timothy Hatcher.

  • UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.textEditorUpdatedFormatting):

3:13 PM Changeset in webkit [151860] by Lucas Forschler
  • 2 edits in tags/Safari-537.46.4/Source/WebKit

Merged r151847. <rdar://problem/14231905>

3:07 PM Changeset in webkit [151859] by Lucas Forschler
  • 8 edits in tags/Safari-537.46.4/Source

Merged r151787. <rdar://problem/14219184>

2:55 PM Changeset in webkit [151858] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

GraphicsContext3DNEON.h cannot be found on Windows and does not need to be found.
​https://bugs.webkit.org/show_bug.cgi?id=117894

Reviewed by Brent Fulgham.

  • platform/graphics/GraphicsContext3D.cpp:

Added #if HAVE(ARM_NEON_INTRINSICS) around #include "GraphicsContext3DNEON.h"

2:33 PM Changeset in webkit [151857] by Lucas Forschler
  • 1 copy in tags/Safari-537.46.4

New Tag.

2:27 PM Changeset in webkit [151856] by fpizlo@apple.com
  • 15 edits
    1 add in branches/dfgFourthTier/Source

fourthTier: Merge r146932 and 146933 so that we can profile from DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=117891

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Merging the JSC part of these changes required creating a fresh VM to JSONify
the profiler database, because that's the only truly safe way to do it. This
is because we don't really know when the profiler would be asked to dump JSON,
and we might be in the middle of VM shutdown. That's a bug in the ToT version
of this, but we didn't catch it because we didn't have enough assertions to
that effect.

  • jsc.cpp:

(jscmain):

  • profiler/ProfilerDatabase.cpp:

(Profiler):
(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::~Database):
(JSC::Profiler::Database::toJSON):
(JSC::Profiler::Database::registerToSaveAtExit):
(JSC::Profiler::Database::addDatabaseToAtExit):
(JSC::Profiler::Database::removeDatabaseFromAtExit):
(JSC::Profiler::Database::performAtExitSave):
(JSC::Profiler::Database::removeFirstAtExitDatabase):
(JSC::Profiler::Database::atExitCallback):

  • profiler/ProfilerDatabase.h:

(Database):
(JSC::Profiler::Database::databaseID):

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::createContextGroup):
(JSC::VM::create):
(JSC::VM::createLeaked):
(JSC::VM::sharedInstance):

  • runtime/VM.h:

(VM):

Source/WTF:

Reviewed by Mark Hahnenberg.

The WTF part of this change is a straight-up merge with nothing interesting.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::dumpProfile):

  • wtf/ProcessID.h: Added.

(WTF):
(WTF::getCurrentProcessID):

  • wtf/text/StringImpl.cpp:

(WTF::StringStats::printStats):

2:04 PM Changeset in webkit [151855] by robert@webkit.org
  • 3 edits
    2 adds in trunk

Ignoring padding-right of inline elements in containers with undefined width
​https://bugs.webkit.org/show_bug.cgi?id=76451

Reviewed by David Hyatt.

Source/WebCore:

Collapsed trailing space on a normal wrap line should not cause a line-break
if it is the difference between fitting on the line and breaking. Likewise, on a line that
has a mix of auto-wrap and no-wrap inlines we don't want a trailing space at the end of a no-wrap inline
to be the difference between that no-wrap inline fitting or breaking the line. This latter
scenario is covered already by inline-whitespace-wrapping-8.html.

Test: fast/text/whitespace/inline-whitespace-wrapping-9.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineIncludingExtraWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::currentWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/text/whitespace/inline-whitespace-wrapping-9-expected.html: Added.
  • fast/text/whitespace/inline-whitespace-wrapping-9.html: Added.
1:57 PM Changeset in webkit [151854] by achristensen@apple.com
  • 8 edits in trunk/Source/WebCore

Added WebGL source files to Windows build and made Windows build successfully with them.
​https://bugs.webkit.org/show_bug.cgi?id=117853

Reviewed by Brent Fulgham.

  • WebCore.vcxproj/WebCore.vcxproj: Added WebGL source files.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Added platform\graphics\opengl and platform\graphics\gpu filters.
  • WebCore.vcxproj/WebCorePreBuild.cmd: Copy ANGLE headers and glext.h before building WebCore (which now uses them).
  • platform/graphics/ANGLEWebKitBridge.h: Look in newly copied directory for ShaderLang.h.
  • platform/graphics/OpenGLShims.h: Include GL/glext.h.
  • platform/graphics/gpu/LoopBlinnShader.cpp:

(WebCore::LoopBlinnShader::use): Fixed parameter ordering in call to uniformMatrix4fv.

  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::createOffScreenSurface): Added notImplemented for non-EGL builds for now.

1:37 PM Changeset in webkit [151853] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

Update platform text track menu
​https://bugs.webkit.org/show_bug.cgi?id=117884

Reviewed by Jer Noble.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setSelectedTextTrack):

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::platformTextTrack):

  • platform/graphics/PlatformTextTrack.h:

(WebCore::PlatformTextTrack::create):
(WebCore::PlatformTextTrack::uniqueId):
(WebCore::PlatformTextTrack::captionMenuOffItem):
(WebCore::PlatformTextTrack::captionMenuAutomaticItem):
(WebCore::PlatformTextTrack::PlatformTextTrack):

1:21 PM Changeset in webkit [151852] by commit-queue@webkit.org
  • 5 edits in trunk

AX: audio/video playback control timers (elapsed and remaining) should be exposed as ApplicationTimerRole
​https://bugs.webkit.org/show_bug.cgi?id=117883

Patch by James Craig <​james@cookiecrook.com> on 2013-06-21
Reviewed by Chris Fleizach.

Some of the media controls were returning the wrong role. Updated existing test coverage.

Source/WebCore:

  • accessibility/AccessibilityMediaControls.h:

(WebCore::AccessibilityMediaTimeDisplay::roleValue):

LayoutTests:

  • accessibility/media-element.html:
  • platform/mac/accessibility/media-element-expected.txt:
12:59 PM Changeset in webkit [151851] by achristensen@apple.com
  • 1 edit
    2 adds in trunk/Source/WebCore

Added glext.h from ​http://www.opengl.org/registry/oldspecs/glext.h for Windows
This file does not meet WebKit style guidelines.
Part of ​https://bugs.webkit.org/show_bug.cgi?id=117853

Reviewed by Brent Fulgham.

  • platform/graphics/win/GL: Added.
  • platform/graphics/win/GL/glext.h: Added.
12:53 PM WebKitGTK/2.0.x edited by zandobersek@gmail.com
Add three more merge proposals for the 2.0.4 release. (diff)
12:46 PM Changeset in webkit [151850] by Lucas Forschler
  • 5 edits in tags/Safari-537.46.3/Source

Versioning.

12:38 PM Changeset in webkit [151849] by Lucas Forschler
  • 1 copy in tags/Safari-537.46.3

New Tag.

12:25 PM Changeset in webkit [151848] by fpizlo@apple.com
  • 7 edits in branches/dfgFourthTier

Merge trunk r146548.

Source/JavaScriptCore:

2013-03-21 Filip Pizlo <​fpizlo@apple.com>


JSC profiler should have an at-a-glance report of the success of DFG optimization
​https://bugs.webkit.org/show_bug.cgi?id=112988


Reviewed by Geoffrey Garen.


  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleCall): (JSC::DFG::ByteCodeParser::handleGetById): (JSC::DFG::ByteCodeParser::parseBlock):
  • profiler/ProfilerCompilation.cpp: (JSC::Profiler::Compilation::Compilation): (JSC::Profiler::Compilation::toJS):
  • profiler/ProfilerCompilation.h: (JSC::Profiler::Compilation::noticeInlinedGetById): (JSC::Profiler::Compilation::noticeInlinedPutById): (JSC::Profiler::Compilation::noticeInlinedCall): (Compilation):
  • runtime/CommonIdentifiers.h:

Tools:

2013-03-21 Filip Pizlo <​fpizlo@apple.com>


JSC profiler should have an at-a-glance report of the success of DFG optimization
​https://bugs.webkit.org/show_bug.cgi?id=112988


Reviewed by Geoffrey Garen.


  • Scripts/display-profiler-output:
11:47 AM Changeset in webkit [151847] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed. Fix a missing parenthesis in include directory path.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props:
11:16 AM Changeset in webkit [151846] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Stop removing and re-adding breakpoints from the backend on reload.

On reload the sourceCode for breakpoints are nulled out, which fires DisplayLocationDidChange.
Then the sourceCode is reassociated, firing DisplayLocationDidChange again. In these cases we
don't need to update the backend, since nothing really changed.

​https://bugs.webkit.org/show_bug.cgi?id=117877

Reviewed by Joseph Pecoraro.

  • UserInterface/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype._breakpointDisplayLocationDidChange): Return early when
_ignoreBreakpointDisplayLocationDidChangeEvent is true.
(WebInspector.DebuggerManager.prototype.reset): Set _ignoreBreakpointDisplayLocationDidChangeEvent.
(WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode): Ditto.

11:08 AM Changeset in webkit [151845] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix TextTrackCue::cueIndex() to handle the null case of TextTrack::cues(() properly
​https://bugs.webkit.org/show_bug.cgi?id=117815
<rdar://problem/14211041>

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-06-21
Reviewed by Ryosuke Niwa.

This patch adds assert statements to try to catch when
track()->cues() returns a null pointer.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::cueIndex):

10:52 AM Changeset in webkit [151844] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

[iOS] Hang drawing captions after pressing the home button while playing a video
​https://bugs.webkit.org/show_bug.cgi?id=117882

Reviewed by Eric Carlson.

Instead of rendering in a callback on the main thread, pre-render the captions and pass to the main
thread as a CGImage. As such, rename paintTextTrackRepresentation() to createTextTrackRepresentationImage().

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage): Renamed from

paintTextTrackRepresentation. Now returns an Image object.

  • html/shadow/MediaControlElements.h:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/TextTrackRepresentation.h:
10:42 AM Changeset in webkit [151843] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

[CSS Regions] Move overset compute code from flow thread to named flow thread
​https://bugs.webkit.org/show_bug.cgi?id=117835

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-21
Reviewed by Andreas Kling.

Moved computeOversetStateForRegions() and overset() methods from RenderFlowThread to RenderNamedFlowThread.
Added ASSERTS in RenderRegion::regionOversetState and RenderRegion::setRegionOversetState to ensure
the region was created from an element.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):

  • rendering/RenderFlowThread.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::computeOversetStateForRegions):

  • rendering/RenderNamedFlowThread.h:

(WebCore::RenderNamedFlowThread::overset):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):

9:48 AM Changeset in webkit [151842] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r151838.
​http://trac.webkit.org/changeset/151838
​https://bugs.webkit.org/show_bug.cgi?id=117880

Breaks MediaPlayerPrivateQt on Mac (Requested by carewolf on
#webkit).

  • html/HTMLMediaElement.h:
9:35 AM Changeset in webkit [151841] by Brent Fulgham
  • 6 edits
    3 adds in trunk

Source/WebCore: [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs
​https://bugs.webkit.org/show_bug.cgi?id=117837

Reviewed by Chris Fleizach.

accessibility/aria-tab-role-on-buttons.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canSetSelectedAttribute): Indicate that certain accessibility
types (such as Tabs) can be selected.

  • accessibility/AccessibilityNodeObject.h: Signature for canSelectAttribute override.

Source/WebKit/win: [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs.
​https://bugs.webkit.org/show_bug.cgi?id=117837

Reviewed by Chris Fleizach.

  • AccessibleBase.cpp:

(MSAARole): Don't expose TabRole as a radio button to satisfy buggy screen readers.

LayoutTests: [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs.
​https://bugs.webkit.org/show_bug.cgi?id=117837

Reviewed by Chris Fleizach.

  • accessibility/aria-tab-role-on-buttons.html: Added.
  • accessibility/aria-tab-role-on-buttons-expected.txt: Added.
  • platform/win/aria-tab-role-on-buttons-expected.txt: Added.
9:12 AM Changeset in webkit [151840] by allan.jensen@digia.com
  • 4 edits in trunk/Source/WebCore

Remove unused GesturePinch events
​https://bugs.webkit.org/show_bug.cgi?id=117875

Reviewed by Andreas Kling.

The gesturePinch events have not been used for some time, even Chromium
had stop using them before moving out of webkit.

  • dom/GestureEvent.cpp:

(WebCore::GestureEvent::create):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • platform/PlatformEvent.h:
9:03 AM Changeset in webkit [151839] by commit-queue@webkit.org
  • 13 edits
    3 moves
    1 add
    1 delete in trunk

Improve the reattaching process while applying the :hover style
​https://bugs.webkit.org/show_bug.cgi?id=117590

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-21
Reviewed by Andreas Kling.

Source/WebCore:

Changes made:

  • context is properly propagated to the element's children and to Shadow DOM elements.
  • context is properly set on the lazyReattach method.
  • another hit-testing is triggered when needed.
  • when a hovered element is detached, it's ancestors are also removed from the hovered state.

Tests: fast/css/hover-display-block-inline.html

fast/css/hover-display-block-none.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::attach):
(WebCore::ContainerNode::detach):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::attachChildren):
(WebCore::ContainerNode::detachChildrenIfNeeded):
(WebCore::ContainerNode::detachChildren):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):
(WebCore::Document::updateHoverActiveState):

  • dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::detach):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::detach):

  • dom/ElementShadow.h:
  • dom/Node.h:

(WebCore::Node::lazyReattach):

LayoutTests:

Moved hover-display-block-inline.html and hover-display-block-none.html from fast/regions to fast/css.
Updated hover-display-block-none.html and hover-single-flow-into-other.html to ensure the outcome won't be affected by the machine's speed.
Updated input-file-re-render.html to stop it from failing on windows and linux machines (a more detailed description can be found inside the test itself).

  • fast/css/hover-display-block-inline-expected.txt: Renamed from LayoutTests/fast/regions/hover-display-block-inline-expected.txt.
  • fast/css/hover-display-block-inline.html: Renamed from LayoutTests/fast/regions/hover-display-block-inline.html.
  • fast/css/hover-display-block-none-expected.txt: Renamed from LayoutTests/fast/regions/hover-display-block-none-expected.txt.
  • fast/css/hover-display-block-none.html: Added.
  • fast/css/hover-update-expected.txt:
  • fast/css/hover-update.html:
  • fast/forms/file/input-file-re-render.html:
  • fast/regions/hover-display-block-none.html: Removed.
  • fast/regions/hover-single-flow-into-other.html:
9:01 AM Changeset in webkit [151838] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

HTMLMediaElement should inherit from MediaPlayerClient privately
​https://bugs.webkit.org/show_bug.cgi?id=117874

Reviewed by Andreas Kling.

Fixing FIXME: HTMLMediaElement was stuck with public inheritance from
MediaPlayerClient due to the Chromium port.
This can now be fixed to a private inheritance.

  • html/HTMLMediaElement.h:
8:58 AM Changeset in webkit [151837] by allan.jensen@digia.com
  • 1 edit
    2 deletes in trunk/Source/WebCore

Remove Chromium-only TouchDisambiguation
​https://bugs.webkit.org/show_bug.cgi?id=117873

Reviewed by Andreas Kling.

  • page/TouchDisambiguation.cpp: Removed.
  • page/TouchDisambiguation.h: Removed.
8:45 AM Changeset in webkit [151836] by commit-queue@webkit.org
  • 7 edits in trunk

Rollout r150602: Restoring text-overflow vs. floating rendering behaviour.
​https://bugs.webkit.org/show_bug.cgi?id=117871

Unreviewed. Rolling out r150602.
Undesirable rendering behaviour.

Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-21

Source/WebCore:

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::checkLinesForTextOverflow):

LayoutTests:

  • fast/css/text-overflow-ellipsis-behind-floats-expected.html:
  • fast/css/text-overflow-ellipsis-behind-floats.html:
  • fast/css/text-overflow-ellipsis-full-truncate-rtl-expected.html:
  • fast/css/text-overflow-ellipsis-full-truncate-rtl.html:
7:31 AM Changeset in webkit [151835] by commit-queue@webkit.org
  • 12 edits in trunk

Web Inspector: Integrate new regionOversetChange event into inspector
​https://bugs.webkit.org/show_bug.cgi?id=117833

Source/WebCore:

Added the new regionOversetChange event to the WebInspector.

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-21
Reviewed by Joseph Pecoraro.

Tests: inspector/styles/protocol-css-regions-commands.html:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::scheduleFor):
(WebCore::ChangeRegionOversetTask::unschedule):
(WebCore::ChangeRegionOversetTask::reset):
(WebCore::ChangeRegionOversetTask::onTimer):
(WebCore::InspectorCSSAgent::resetNonPersistentData):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didChangeRegionOverset):
(WebCore::InspectorCSSAgent::regionOversetChanged):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didChangeRegionOversetImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didChangeRegionOverset):

  • inspector/front-end/CSSNamedFlowCollectionsView.js:

(WebInspector.CSSNamedFlowCollectionsView.prototype._regionOversetChanged):
(WebInspector.CSSNamedFlowCollectionsView.prototype.wasShown):
(WebInspector.CSSNamedFlowCollectionsView.prototype.willHide):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype._regionOversetChanged):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.CSSDispatcher.prototype.regionOversetChanged):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):

LayoutTests:

Tests for the new regionOversetChange event.

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-21
Reviewed by Joseph Pecoraro.

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
6:59 AM Changeset in webkit [151834] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] NetworkStateNotifierEfl: Use closeWithRetry instead of looping for EINTR on close
​https://bugs.webkit.org/show_bug.cgi?id=117872

Patch by Sergio Correia <Sergio Correia> on 2013-06-21
Reviewed by Christophe Dumez.

closeWithRetry works around the Linux behavior of closing the file descriptor
unconditionally even if the close() call is interrupted.

No new tests, no behavior change.

  • platform/network/efl/NetworkStateNotifierEfl.cpp:

(WebCore::NetworkStateNotifier::~NetworkStateNotifier): Use closeWithRetry instead of
looping for EINTR on close.

4:41 AM Changeset in webkit [151833] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Do not try to load videos in unit tests
​https://bugs.webkit.org/show_bug.cgi?id=117866

Reviewed by Philippe Normand.

It makes the tests slower, and generates and error because we use
a fake src.

  • UIProcess/API/gtk/tests/TestContextMenu.cpp:

(testContextMenuDefaultMenu): Use preload='none' in video tag.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewMouseTarget): Ditto.

3:34 AM Changeset in webkit [151832] by Christophe Dumez
  • 33 edits in trunk

REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
​https://bugs.webkit.org/show_bug.cgi?id=117825

Reviewed by Kentaro Hara.

Source/WebCore:

Partially revert r150663 so that we use Settings to enable WebAudio instead of
RuntimeEnabledFeatures.

Introduce a new [EnabledBySetting] IDL extended attribute which behaves similarly to
the existing [EnabledAtRuntime] but relies on Settings instead of RuntimeEnabledFeatures
to determine if the feature should be enabled. Make use of this new IDL attribute for
webkitAudioContext interface.

No new tests, no behavior change.

  • Modules/webaudio/AudioContext.idl:
  • WebCore.exp.in:
  • WebCore.order:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/preprocess-idls.pl:

(GenerateConstructorAttribute):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj TestSubObjEnabledBySetting]):
(-[DOMTestObj setTestSubObjEnabledBySetting:]):

  • bindings/scripts/test/TestObj.idl:
  • page/Settings.in:

Source/WebKit/efl:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setWebAudioEnabled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Source/WebKit/gtk:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/mac:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

Source/WebKit/win:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::overridePreference):

3:33 AM Changeset in webkit [151831] by commit-queue@webkit.org
  • 6 edits
    4 moves in trunk

[ATK] Added support for aria-required attribute.
​https://bugs.webkit.org/show_bug.cgi?id=117730

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-06-21
Reviewed by Chris Fleizach.

Source/WebCore:

Tests: accessibility/aria-required.html

accessibility/html5-required-attribute.html

The aria-required attribute is used to indicate that user input is required on an
element before a form can be submitted.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkStateSetFromCoreObject):

Tools:

Added support for testing aria-required attribute.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isRequired):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isRequired):

LayoutTests:

Moving specific platform accessibility tests.

  • accessibility/aria-required-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-required-expected.txt.
  • accessibility/aria-required.html: Renamed from LayoutTests/platform/mac/accessibility/aria-required.html.
  • accessibility/html5-required-attribute-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/html5-required-attribute-expected.txt.
  • accessibility/html5-required-attribute.html: Renamed from LayoutTests/platform/mac/accessibility/html5-required-attribute.html.
2:36 AM Changeset in webkit [151830] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

IndieUI: Add basic IndieUI infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=117367

Unreviewed. Update Lion expected results.

  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
1:55 AM Changeset in webkit [151829] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

IndieUI: Add basic IndieUI infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=117367

Unreviewed. Revert erroneous file that was included accidentally.

  • accessibility/AccessibilityNodeObject.h:
1:52 AM Changeset in webkit [151828] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL]: Invalidate the ProcessLauncher when the process is terminated before it has finished launching
​https://bugs.webkit.org/show_bug.cgi?id=117865

Patch by Sergio Correia <Sergio Correia> on 2013-06-21
Reviewed by Christophe Dumez.

Original patch from Carlos Garcia Campos for the Gtk port.

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::terminateProcess): If process is still
launching, just invalidate the launcher. Reset the process
identifier after killing the process.

1:51 AM Changeset in webkit [151827] by Chris Fleizach
  • 25 edits
    2 copies
    9 adds in trunk

IndieUI: Add basic IndieUI infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=117367

Reviewed by Ryosuke Niwa.

Source/WebCore:

IndieUI is a new W3C spec that aims to abstract the connection between input and action, so that
a user (possibly using assistive technologies like a screen reader) does not need a specific kind
of device (like a mouse) to interact with an object.
​http://www.w3.org/WAI/IndieUI/

This initial patch adds in the basic support for UIRequestEvent and the uiactions attribute.
It modifies the config files to enable and build this feature.

Tests: indieui/create-uirequestevent.html

indieui/uiactions.html

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • Modules/indieui: Added.
  • Modules/indieui/UIRequestEvent.cpp: Added.

(WebCore::UIRequestEventInit::UIRequestEventInit):
(WebCore::UIRequestEvent::create):
(WebCore::UIRequestEvent::UIRequestEvent):
(WebCore::UIRequestEvent::~UIRequestEvent):
(WebCore::UIRequestEvent::interfaceName):
(WebCore::UIRequestEventDispatchMediator::UIRequestEventDispatchMediator):
(WebCore::UIRequestEventDispatchMediator::event):
(WebCore::UIRequestEventDispatchMediator::dispatchEvent):

  • Modules/indieui/UIRequestEvent.h: Added.

(WebCore::UIRequestEvent::receiver):
(WebCore::UIRequestEventDispatchMediator::create):

  • Modules/indieui/UIRequestEvent.idl: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityNodeObject.h:
  • dom/Element.cpp:

(WebCore::Element::setUIActions):
(WebCore::Element::UIActions):

  • dom/Element.h:
  • dom/Element.idl:
  • dom/Event.cpp:

(WebCore::EventInit::EventInit):

  • dom/Event.h:
  • dom/EventNames.in:
  • dom/Node.cpp:

(WebCore::Node::dispatchUIRequestEvent):

  • dom/Node.h:
  • dom/UIEvent.cpp:

(WebCore::UIEventInit::UIEventInit):

  • dom/UIEvent.h:
  • html/HTMLAttributeNames.in:

LayoutTests:

  • fast/js/dom-static-property-for-in-iteration-expected.txt:
  • fast/js/global-constructors-attributes-expected.txt:
  • indieui: Added.
  • indieui/create-uirequestevent-expected.txt: Added.
  • indieui/create-uirequestevent.html: Added.
  • indieui/uiactions-expected.txt: Added.
  • indieui/uiactions.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
  • platform/win/TestExpectations:
  • platform/win/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
1:07 AM Changeset in webkit [151826] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Migrate WebKitWebResource to GTask
​https://bugs.webkit.org/show_bug.cgi?id=117152

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitWebResource.cpp:

(resourceDataCallback):
(webkit_web_resource_get_data):
(webkit_web_resource_get_data_finish):

12:08 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com
Add two proposed patches for 2.0.4. (diff)

Jun 20, 2013:

11:02 PM Changeset in webkit [151825] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source

[WK2] Looping for EINTR on close() is incorrect for Linux, at least
​https://bugs.webkit.org/show_bug.cgi?id=117266

Patch by Sergio Correia <Sergio Correia> on 2013-06-20
Reviewed by Darin Adler.

Source/WebKit2:

Call closeWithRetry() to work around a difference in how the retry needs to
be done on Linux.

  • Platform/CoreIPC/unix/AttachmentUnix.cpp:

(CoreIPC::Attachment::dispose):

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::platformInvalidate):

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::createWebProcessConnection):

  • SharedWorkerProcess/SharedWorkerProcess.cpp:

(WebKit::SharedWorkerProcess::createWebProcessConnection):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess): All these places had
close-followed-by-EINTR-handling replaced with the new closeWithRetry()
function added in this commit.

Source/WTF:

Added file UniStdExtras with a closeWithRetry() function that works around
the EINTR behavior on Linux during a close() call: it closes the descriptor
unconditionally even when the call is interrupted.

  • wtf/UniStdExtras.h: Added.

(WTF::closeWithRetry): Wrapper around POSIX close() that handles EINTR
correctly.

9:21 PM Changeset in webkit [151824] by fpizlo@apple.com
  • 7 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Structure should have a dump()
​https://bugs.webkit.org/show_bug.cgi?id=117859

Reviewed by Geoffrey Garen.

This is pretty cool. Anywhere we previously printed Structure pointers in dumps,
we now print a bunch of other info as well. For example, for an object literal
like "{f:42, g:64, h:24}", when we print the structure we'll now get:

0x107a0af80:[Object, {f:0, g:1, h:2}, NonArray, Proto:0x107a8fff0]


This also changes a bunch of places to use the dump method.

  • bytecode/StructureSet.h:

(JSC::StructureSet::dump):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGStructureAbstractValue.h:

(JSC::DFG::StructureAbstractValue::dump):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::dump):

  • runtime/Structure.cpp:

(JSC::Structure::dump):
(JSC):

  • runtime/Structure.h:

(Structure):

9:00 PM Changeset in webkit [151823] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r151808): fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html fails
​https://bugs.webkit.org/show_bug.cgi?id=117862

Add a failing test expectation.

  • platform/mac/TestExpectations:
8:52 PM Changeset in webkit [151822] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION(r145788): mouse drag on canvas shouldn't start selection
​https://bugs.webkit.org/show_bug.cgi?id=117860

Reviewed by Benjamin Poulain.

Source/WebCore:

Like HTMLImageElement, HTMLCanvasElement shouldn't start selection.

Also uninline some virtual function overrides.

Test: fast/events/mosuedrag-on-canvas-should-not-start-selection.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::areAuthorShadowsAllowed):
(WebCore::HTMLCanvasElement::canContainRangeEndPoint):
(WebCore::HTMLCanvasElement::canStartSelection):

  • html/HTMLCanvasElement.h:

LayoutTests:

Add a regression test for dragging mouse inside a canvas.
The canvas should not be selected and mouseup event should fire.

  • fast/events/mosuedrag-on-canvas-should-not-start-selection-expected.txt: Added.
  • fast/events/mosuedrag-on-canvas-should-not-start-selection.html: Added.
8:50 PM Changeset in webkit [151821] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r149652): accessing items in .children via id doesn't work when element is not rooted in DOM tree
​https://bugs.webkit.org/show_bug.cgi?id=117836

Reviewed by Benjamin Poulain.

Source/WebCore:

When the root node of a HTML collection is not in the document or in a shadow tree,
we shouldn't use its tree scope's id and name maps to find name getters.

Always use the slow path in such cases.

Test: fast/dom/htmlallcollection-detached-node-children.html

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::namedItem):

LayoutTests:

Add a regression test for named getter for a detached element.

  • fast/dom/htmlallcollection-detached-node-children-expected.txt: Added.
  • fast/dom/htmlallcollection-detached-node-children.html: Added.
7:57 PM Changeset in webkit [151820] by fpizlo@apple.com
  • 19 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: There should only be one table of SimpleJumpTables
​https://bugs.webkit.org/show_bug.cgi?id=117856

Reviewed by Geoffrey Garen.

Having multiple tables of SimpleJumpTables just means we have to duplicate a
ton of code. This patch deduplicates all of it.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfSwitchJumpTables):
(JSC::CodeBlock::addSwitchJumpTable):
(JSC::CodeBlock::switchJumpTable):
(JSC::CodeBlock::clearSwitchJumpTables):
(RareData):

  • bytecode/PreciseJumpTargets.cpp:

(JSC):
(JSC::computePreciseJumpTargets):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::shrinkToFit):
(JSC::UnlinkedCodeBlock::numberOfSwitchJumpTables):
(JSC::UnlinkedCodeBlock::addSwitchJumpTable):
(JSC::UnlinkedCodeBlock::switchJumpTable):
(RareData):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC):
(JSC::prepareJumpTableForSwitch):
(JSC::BytecodeGenerator::endSwitch):

  • dfg/DFGByteCodeParser.cpp:

(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JITCompiler):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
(DFG):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchCharStringJump):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
7:52 PM Changeset in webkit [151819] by Lucas Forschler
  • 5 edits in tags/Safari-537.46.2/Source

Versioning.

7:50 PM Changeset in webkit [151818] by Lucas Forschler
  • 1 copy in tags/Safari-537.46.2

New Tag.

7:49 PM Changeset in webkit [151817] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

Refine the StackBounds computation for Windows.
​https://bugs.webkit.org/show_bug.cgi?id=117854.

Reviewed by Brent Fulgham.

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

7:29 PM Changeset in webkit [151816] by Lucas Forschler
  • 1 delete in branches/safari-537-branch/LayoutTests/fast/replaced/width-and-height-of-positioned-replaced-elements.html

correct mismerge from 151799. <rdar://problem/14159682>

7:26 PM Changeset in webkit [151815] by ryuan.choi@samsung.com
  • 8 edits in trunk

[CMAKE][EFL] Enable DOM4 Events Constructor
​https://bugs.webkit.org/show_bug.cgi?id=117858

Reviewed by Laszlo Gombos.

.:

  • Source/cmake/OptionsEfl.cmake: Enabled ENABLE_DOM4_EVENTS_CONSTRUCTOR.
  • Source/cmake/WebKitFeatures.cmake: Added ENABLE_DOM4_EVENTS_CONSTRUCTOR.
  • Source/cmakeconfig.h.cmake: Ditto.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.

LayoutTests:

  • platform/efl/TestExpectations: Unskip the related tests.
7:24 PM Changeset in webkit [151814] by Lucas Forschler
  • 16 edits
    4 deletes in branches/safari-537-branch

Merged r151799. <rdar://problem/14159682>

7:17 PM Changeset in webkit [151813] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151762. <rdar://problem/13837412>

5:44 PM Changeset in webkit [151812] by ap@apple.com
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=116495
Fix null-pointer deref in DocumentLoader::responseReceived()

Patch by Nate Chapin, reviewed by Mike West and myself.

Test: http/tests/security/XFrameOptions/x-frame-options-deny-delete-frame-in-load-event.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::responseReceived): Added a null check.
4:43 PM Changeset in webkit [151811] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Roll out part of r150618.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
4:36 PM Changeset in webkit [151810] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

[Windows] Undoing r150621 to roll r150600 back in as the jsc test
failures have been fixed in r151808.
​https://bugs.webkit.org/show_bug.cgi?id=116661.

Reviewed by Brent Fulgham.

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

3:52 PM Changeset in webkit [151809] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Send the correct offsets for misspelled words.
​https://bugs.webkit.org/show_bug.cgi?id=117846

JIRA116916.
When the caret is placed after a word, the offsets were calculated around
the proceeding space. As such, words that end a sentence worked correctly, but
midsentence words did not. The 'startOfWord' was calculated for the space ahead
and not for the word before it. Now finding the start of the word correctly and
calculating the end from there.

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-06-20
Reviewed by Rob Buis.

Internally reviewed by Genevieve Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

3:17 PM Changeset in webkit [151808] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Change stack capacity requirement to be more reasonable.
​https://bugs.webkit.org/show_bug.cgi?id=117801.

Reviewed by Geoffrey Garen.

Previously, the requiredStack in StackPolicy::StackPolicy() was set to
to a high value like 256K to reduce the chances of encountering an
undetected stack overflow in a scenario where we have a combination of
deeply nested divs and a large amount recursive re-entries into the VM.

However, this high value of requiredStack still does not completely
ensure that we will never encounter an undetected stack overflow. It
only lessens the probability of encountering it.

Secondly, on some platforms, the total stack size can be less than 256K
to start with. Hence, this high value requiredStack renders the VM
unuseable on those platforms.

This patch will fix the requiredStack to be more reasonable based on
real world stack usage by the VM. We won't (and cannot) try to prevent
undetected stack overflows outside of JSC as well. External code that
do deep recursion (e.g. Documnet::updateLayout()) should do their own
stack checks.

From a previous experiment, we measured the following:

On a debug build on OSX:

  1. Stack usage different between recursive calls to interpreter entry: 7744 bytes

On a release build on OSX:

  1. Stack usage difference between recursive calls to interpreter entry: 6352 bytes

Using these as a guide, we'll pick the following values for the
StackPolicy:

requiredStack: 32K
errorModeRequiredStack: 16K

The requiredStack is chosen to be 4x the measured usage above. The
additional 3x is a conservative estimate to account for stack space
that may be needed by other native functions called while in the
interpreter.

The errorModeRequiredStack has to be less than the requiredStack or we
won't be able to reenter the interpreter to do error handling work when
an imminent stack overflow is detected. It is assumed that the error
handling code will only do minimal work to allocate an exception and its
stack trace, and not run any arbitrary JS code. As such, it is safe to
allow re-entry into the interpreter with only 2x the measured usage in
this case.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::StackPolicy::StackPolicy):

3:15 PM Changeset in webkit [151807] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Initial advance on the first glyph of the run is not correctly set for rtl text.
​https://bugs.webkit.org/show_bug.cgi?id=117839
<rdar://problem/13860717>

Reviewed by Sam Weinig.

Source/WebCore:

We need to set the initial advance to the glyphBuffer, using the
initial advance of the complex run that will be drawn first.
In order to choose the run correctly we must consider the text direction.

Test: fast/text/complex-first-glyph-with-initial-advance.html

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::advance):

LayoutTests:

  • fast/text/complex-first-glyph-with-initial-advance-expected.html: Added.
  • fast/text/complex-first-glyph-with-initial-advance.html: Added.
2:42 PM Changeset in webkit [151806] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should clear character switch jump tables
​https://bugs.webkit.org/show_bug.cgi?id=117852

Reviewed by Sam Weinig.

The FTL just uses LLVM's switch, which results in LLVM allocating its own switch
jump tables as needed.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::clearCharacterSwitchJumpTables):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

2:37 PM Changeset in webkit [151805] by achristensen@apple.com
  • 5 edits in trunk/Source/WebCore

Fixed WebGL compile errors on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=117805

Reviewed by Brent Fulgham.

  • html/canvas/WebGLRenderingContext.cpp: Included CString.h.

Added PLATFORM(WIN) to existing lists of platform macros.

  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap):

  • platform/graphics/OpenGLESShims.h:
2:28 PM Changeset in webkit [151804] by Simon Fraser
  • 6 edits in trunk/Source

FrameView needs to initialize paintsEntireContents on creation
​https://bugs.webkit.org/show_bug.cgi?id=117844

Source/WebCore:

Reviewed by Anders Carlsson.

In WebKit1, if the WebView is layer-backed, WebHTMLView gets a layer.
In this mode, FrameView::paintsEntireContents() is true. However,
we would only call setPaintsEntireContents(true) on the FrameView
when the view's layer-backed status changes. FrameView also needs
to fetch this state when it is initialized, because we may be creating
a new FrameView for an already layer-backed WebHTMLView.

  • page/ChromeClient.h:

(WebCore::ChromeClient::shouldPaintEntireContents):

  • page/FrameView.cpp:

(WebCore::FrameView::init):

Source/WebKit/mac:

Reviewed by Anders Carlsson.

In WebKit1, if the WebView is layer-backed, WebHTMLView gets a layer.
In this mode, FrameView::paintsEntireContents() is true. However,
we would only call setPaintsEntireContents(true) on the FrameView
when the view's layer-backed status changes. FrameView also needs
to fetch this state when it is initialized, because we may be creating
a new FrameView for an already layer-backed WebHTMLView.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::shouldPaintEntireContents):

2:28 PM Changeset in webkit [151803] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Sticky elements are missing or misplaced sometimes when reloading a page that scrolls to a named anchor
​https://bugs.webkit.org/show_bug.cgi?id=117819

Reviewed by Anders Carlsson.

At the end of FrameView::performPostLayoutTasks() we call scrollToAnchor() which attempts
to restore the scroll position to a named anchor, even when the document has been
changed by layout. This ends up in a call to ScrollView::scrollTo(), which in turn
calls repaintFixedElementsAfterScrolling(). However, repaintFixedElementsAfterScrolling()
would bail if m_nestedLayoutCount != 0, so we never updated layer positions which
depend on scroll position (but which would not be updated by layout, since their
renderers are not marked for layout when scrolling happens).

We've solved this problem once before in updateFixedElementsAfterScrolling() which
checks for m_nestedLayoutCount <= 1, so that we do work on the outermost nested layout.
Apply that same fix to repaintFixedElementsAfterScrolling().

Very timing-dependent, so hard to make a test.

  • page/FrameView.cpp:

(WebCore::FrameView::repaintFixedElementsAfterScrolling):

2:18 PM Changeset in webkit [151802] by fpizlo@apple.com
  • 17 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support SwitchChar
​https://bugs.webkit.org/show_bug.cgi?id=117849

Reviewed by Geoffrey Garen.

This adds Switch(SwitchChar) to the FTL and also implicitly does some other things.
SwitchChar requires calling a slow path to resolve ropes. Previously the FTL had no
support for calling slow paths, and we avoided adding coverage that would require
that. Well, this patch adds the ability to call slow paths and just uses that for
resolving ropes for SwitchChar. Also SwitchChar required adding awareness of strings,
so I did that, too.

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::addCodeOrigin):

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGNode.cpp:

(WTF):
(WTF::printInternal):

  • dfg/DFGNode.h:

(WTF):

  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • ftl/FTLAbbreviations.h:

(JSC::FTL::int16Type):
(JSC::FTL::constInt):

  • ftl/FTLAbstractHeapRepository.h:

(FTL):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLCommonValues.cpp:

(JSC::FTL::CommonValues::CommonValues):

  • ftl/FTLCommonValues.h:

(CommonValues):

  • ftl/FTLIntrinsicRepository.cpp:

(JSC::FTL::IntrinsicRepository::IntrinsicRepository):
(FTL):

  • ftl/FTLIntrinsicRepository.h:

(FTL):
(IntrinsicRepository):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileJump):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(JSC::FTL::LowerDFGToLLVM::buildSwitch):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lowString):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isObject):
(JSC::FTL::LowerDFGToLLVM::isNotString):
(JSC::FTL::LowerDFGToLLVM::isString):
(JSC::FTL::LowerDFGToLLVM::isNotObject):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::speculateString):
(JSC::FTL::LowerDFGToLLVM::speculateNonNullObject):
(JSC::FTL::LowerDFGToLLVM::vmCall):
(JSC::FTL::LowerDFGToLLVM::callPreflight):
(JSC::FTL::LowerDFGToLLVM::callCheck):
(JSC::FTL::LowerDFGToLLVM::lowBlock):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt8):
(JSC::FTL::Output::constInt32):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::constInt64):
(JSC::FTL::Output::load16):
(JSC::FTL::Output::isNull):
(JSC::FTL::Output::notNull):
(JSC::FTL::Output::testIsZero32):
(JSC::FTL::Output::testNonZero32):
(Output):
(JSC::FTL::Output::operation):
(JSC::FTL::Output::crash):

2:10 PM Changeset in webkit [151801] by commit-queue@webkit.org
  • 6 edits
    3 deletes in trunk/LayoutTests

Unreviewed, rolling out r151463.
​http://trac.webkit.org/changeset/151463
​https://bugs.webkit.org/show_bug.cgi?id=117850

"r151451 was rolled out" (Requested by rhogan on #webkit).

  • platform/efl/fast/forms/button-positioned-expected.txt:
  • platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/efl/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
  • platform/gtk/fast/forms/button-positioned-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/gtk/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
  • platform/win/fast/forms/onselect-textfield-expected.txt: Removed.
2:09 PM Changeset in webkit [151800] by mikhail.pozdnyakov@intel.com
  • 63 edits in trunk/Source

HashSet: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods
​https://bugs.webkit.org/show_bug.cgi?id=117830

Reviewed by Anders Carlsson.

The order of the template arguments at HashSet alternate 'find', 'contains' and
'add' methods is reversed so that callers can just pass the translator
and let the compiler deduce input argument type.

Source/JavaScriptCore:

  • runtime/Identifier.h:

(JSC::IdentifierTable::add):

Source/WebCore:

No new tests. No new functionality.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::QualifiedName):

  • platform/graphics/cg/SubimageCacheWithTimer.cpp:

(WebCore::SubimageCacheWithTimer::getSubimage):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::isSupportedAttribute):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::isSupportedAttribute):

  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::isSupportedAttribute):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::isSupportedAttribute):

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::isSupportedAttribute):

  • svg/SVGClipPathElement.cpp:

(WebCore::SVGClipPathElement::isSupportedAttribute):

  • svg/SVGComponentTransferFunctionElement.cpp:

(WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):

  • svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::isSupportedAttribute):

  • svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::isSupportedAttribute):

  • svg/SVGFEBlendElement.cpp:

(WebCore::SVGFEBlendElement::isSupportedAttribute):

  • svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::isSupportedAttribute):

  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::isSupportedAttribute):

  • svg/SVGFECompositeElement.cpp:

(WebCore::SVGFECompositeElement::isSupportedAttribute):

  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):

  • svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):

  • svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::isSupportedAttribute):

  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::isSupportedAttribute):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::isSupportedAttribute):

  • svg/SVGFEMergeNodeElement.cpp:

(WebCore::SVGFEMergeNodeElement::isSupportedAttribute):

  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::isSupportedAttribute):

  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::isSupportedAttribute):

  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::isSupportedAttribute):

  • svg/SVGFETileElement.cpp:

(WebCore::SVGFETileElement::isSupportedAttribute):

  • svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::isSupportedAttribute):

  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::isSupportedAttribute):
(WebCore::SVGFilterElement::childShouldCreateRenderer):

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::isSupportedAttribute):

  • svg/SVGGElement.cpp:

(WebCore::SVGGElement::isSupportedAttribute):

  • svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::isSupportedAttribute):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::isSupportedAttribute):

  • svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::isSupportedAttribute):

  • svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::isSupportedAttribute):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::isSupportedAttribute):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::isSupportedAttribute):

  • svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::isSupportedAttribute):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::isSupportedAttribute):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::isSupportedAttribute):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::isSupportedAttribute):

  • svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::isSupportedAttribute):

  • svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::isSupportedAttribute):

  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::isSupportedAttribute):

  • svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::isSupportedAttribute):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::isSupportedAttribute):

  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::isSupportedAttribute):

  • svg/SVGSymbolElement.cpp:

(WebCore::SVGSymbolElement::isSupportedAttribute):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::isSupportedAttribute):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::isSupportedAttribute):

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::isSupportedAttribute):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::isSupportedAttribute):

  • svg/SVGTextPositioningElement.cpp:

(WebCore::SVGTextPositioningElement::isSupportedAttribute):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::isDisallowedElement):

  • svg/SVGViewElement.cpp:

(WebCore::SVGViewElement::isSupportedAttribute):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::isSupportedAttribute):

Source/WTF:

  • wtf/HashSet.h:
  • wtf/text/AtomicString.cpp:

(WTF::addToStringTable):
(WTF::findString):

1:46 PM Changeset in webkit [151799] by commit-queue@webkit.org
  • 16 edits
    5 deletes in trunk

Unreviewed, rolling out r151451.
​http://trac.webkit.org/changeset/151451
​https://bugs.webkit.org/show_bug.cgi?id=117848

"Broke quite a lot of sites" (Requested by rhogan on #webkit).

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::intrinsicSize):

  • rendering/RenderButton.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::computeLogicalHeight):

  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderReplaced.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::computeLogicalHeight):

  • rendering/RenderTextControl.h:

LayoutTests:

  • fast/forms/onselect-textfield-expected.txt:
  • fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Removed.
  • fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
  • fast/replaced/width-and-height-of-positioned-replaced-elements.html: Removed.
  • platform/mac-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
  • platform/mac/fast/forms/button-positioned-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
  • platform/qt/fast/forms/button-positioned-expected.txt:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
1:37 PM Changeset in webkit [151798] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk

Unreviewed, rolling out r151788.
​http://trac.webkit.org/changeset/151788
​https://bugs.webkit.org/show_bug.cgi?id=117847

"This is the wrong fix" (Requested by rhogan on #webkit).

Source/WebCore:

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

  • fast/forms/onselect-textfield-expected.txt:
  • fast/replaced/height-of-positioned-text-control-expected.html: Removed.
  • fast/replaced/height-of-positioned-text-control.html: Removed.
  • fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png:
  • platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
1:19 PM Changeset in webkit [151797] by kbalazs@webkit.org
  • 5 edits in trunk

[Gstreamer] cleanup buffering and state updates
​https://bugs.webkit.org/show_bug.cgi?id=116642

Reviewed by Philippe Normand.

Source/WebCore:

Covered by existing media tests, especially the ones that have been unskipped.

Always do download buffering. It should not differ if preload is "none" because
it's about when to start buffering, not about how. Fix a bunch other subtle issues
to make this change go smoothly with the tests. As a bonus some tests that were
failing so far started to pass.
It is possible to further tweak the buffering in a way that will enable us to support
a different and appropriate behavior for preload="metadata" but it should be managed
a bit differently. I will implement it in a follow-up.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load): Don't call setDownloadBuffering
yet. Now it also responsible for starting the fill timer and it turned out that
setting the download flag before the pipeline is set to a state has negative
effect on some tests. Most probably GStreamer starts buffering too early if
we set the download flag.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): Call setDownloadBuffering now.
(WebCore::MediaPlayerPrivateGStreamer::play): Ditto, plus set m_delayingLoad to false
because otherwise setPreload will wrongly assume that the load has not been committed
yet if prepareToPlay is not called before play.
(WebCore::MediaPlayerPrivateGStreamer::pause): Make sure we don't commit a load here
if it was not committed yet by looking in the pipeline state.
(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats): No need to observe the
type of buffering.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Introduced m_downloadFinished to update
ready and network states in updateStates based on it. The previously used condition

  • (maxTimeLoaded() == duration()) - was not correct in the case when duration is not known.

(WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded): Removed a lie. If the fill timer is not active
it does not necesarily means that download has been finished. This lie was actually ensuring
a lot of tests to pass because it made the condition (maxTimeLoaded() == duration()) true.
Now that state updates has been cleaned up we don't need to lie.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Merge all the parts that takes part in updating
ready and network states. It was untrackable. Unset download buffering for for live streams early so
we don't need to restart them.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer): Removed m_startedBuffering because there is no need for it now.

LayoutTests:

Remove failure expectations from tests that started to pass.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
1:14 PM Changeset in webkit [151796] by eric.carlson@apple.com
  • 5 edits
    2 adds in trunk

ASSERT removing then adding a <track> element
​https://bugs.webkit.org/show_bug.cgi?id=117814

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/add-and-remove-track.html

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedInto): Always call ensureTrack before adding the track

to the parent <video> element.

(WebCore::HTMLTrackElement::ensureTrack): Call m_track->setTrackElement() in case the

parent was cleared after m_track was created.

  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::setTrackElement): New, set m_trackElement.

  • html/track/LoadableTextTrack.h:

LayoutTests:

  • media/track/add-and-remove-track-expected.txt: Added.
  • media/track/add-and-remove-track.html: Added.
1:12 PM Changeset in webkit [151795] by beidson@apple.com
  • 6 edits in trunk/Source/WebKit2

WebProcess hangs loading eff.org (Waiting forever on a sync XHR, NetworkProcess unable to service it).
<rdar://problem/14112329> and ​https://bugs.webkit.org/show_bug.cgi?id=117842

Reviewed by Alexey Proskuryakov.

  • NetworkProcess/HostRecord.cpp:

(WebKit::removeLoaderFromQueue): Utility to clear a Loader out of a LoaderQueue.
(WebKit::HostRecord::removeLoader): Use removeLoaderFromQueue, and also try to clear the loader from m_syncLoadersPending.
(WebKit::HostRecord::servePendingRequestsForQueue): Small refactoring/cleanup.
(WebKit::HostRecord::limitsRequests): Change so that if the number of loaders in flight is exactly equal to the limit, then

allow serving a synchronous loader to go exactly one beyond the limit.

  • NetworkProcess/HostRecord.h:

Make the static maxRequestsInFlightPerHost a member of the NetworkResourceLoadScheduler, instead:

  • NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::NetworkResourceLoadScheduler):
(WebKit::NetworkResourceLoadScheduler::hostForURL):

  • NetworkProcess/NetworkResourceLoadScheduler.h:
  • NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm:

(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost): Tell CFNetwork to allow

7 connections per host instead of 6, but tell the scheduler that 6 is still the normal limit.

1:12 PM Changeset in webkit [151794] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Build fix for Apple Windows port.

  • rendering/RenderThemeWin.cpp:

(WebCore::cssValueIdToSysColorIndex):

1:06 PM Changeset in webkit [151793] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Downloaded file name encoding is incorrect when download link opens in a new window
​https://bugs.webkit.org/show_bug.cgi?id=117818
<rdar://problem/14212635>

Reviewed by Brady Eidson.

No tests added. The machinery we have for logging downloaded file name is very
far from being able to work in a secondary window.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Made a targeted fix - don't update encoding fallback array if we already have one, there is no chance for it to be more correct. In this case, it's incorrect because it comes from a new blank window, instead of original referer. We have a lot of code in addExtraFieldsToRequest() to struggle with this, and we have a FIXME to try not calling it from policy delegate.
12:44 PM Changeset in webkit [151792] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

12:32 PM Changeset in webkit [151791] by zandobersek@gmail.com
  • 2 edits in trunk

[GTK] remove bashism from configure
​https://bugs.webkit.org/show_bug.cgi?id=117796

Reviewed by Gustavo Noronha Silva.

  • Source/autotools/FindDependencies.m4: Perform string appending by redeclaring the base string to the value

of the base string followed by the string that's being appended. This replaces the use of the '+=' operator
that works under bash but is not supported by other shells.

12:16 PM Changeset in webkit [151790] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Mark compositing/repaint/positioned-movement.html as flaky on Mountain Lion Debug

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-06-20

  • platform/mac-wk2/TestExpectations:

The test fails regularly in Debug on Mountain Lion.

12:10 PM Changeset in webkit [151789] by robert@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(r151737): fast/replaced/width100percent-image.html fails
​https://bugs.webkit.org/show_bug.cgi?id=117824

Unreviewed, rebaselining.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
  • platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.txt:
11:58 AM Changeset in webkit [151788] by robert@webkit.org
  • 10 edits
    2 adds in trunk

REGRESSION (r151451): Text not vertically centered correctly on icloud.com
​https://bugs.webkit.org/show_bug.cgi?id=117744

Reviewed by David Hyatt.

Source/WebCore:

The positioned height and width computation adds in the element's border and padding so
don't add it to the intrinsic height and preferred widths of text controls that are
absolutely positioned.

Test: fast/replaced/height-of-positioned-text-control.html

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

  • fast/forms/onselect-textfield-expected.txt:
  • fast/replaced/height-of-positioned-text-control-expected.html: Added.
  • fast/replaced/height-of-positioned-text-control.html: Added.
  • fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
  • platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
11:55 AM Changeset in webkit [151787] by roger_fong@apple.com
  • 8 edits in trunk/Source

Make Windows makefile copy build output to a different folder.
<rdar://problem/14219184>.

  • WTF.vcxproj/WTF.make:
  • JavaScriptCore.vcxproj/JavaScriptCore.make:
  • WebCore.vcxproj/WebCore.make:
  • WebKit.vcxproj/WebKit.make:
11:36 AM Changeset in webkit [151786] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Improper deallocation of JSManagedValue causes crashes during autorelease pool draining
​https://bugs.webkit.org/show_bug.cgi?id=117840

Reviewed by Geoffrey Garen.

Improperly managing a JSManagedValue can cause a crash when the JSC::Weak inside the
JSManagedValue is destroyed upon deallocation. We would rather have improperly maintained
JSManagedValues cause memory leaks than take down the whole app.

The fix is to use the callback to the JSC::Weak on the destruction of the VM so that we
can safely null it out. This will prevent ~Weak from crashing.

  • API/JSManagedValue.mm:

(-[JSManagedValue JSC::JSC::]):
(JSManagedValueHandleOwner::finalize):

  • API/tests/testapi.mm: Added a test that crashed prior to this fix due to a leaked

managed reference. Also fixed a small style nit I noticed in another test.

11:24 AM Changeset in webkit [151785] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Roll-on in-band captions are displayed bottom-to-top rather than top-to-bottom.
​https://bugs.webkit.org/show_bug.cgi?id=117811

Reviewed by Eric Carlson.

When comparing Generic cues, we should check that their type is Generic, not WebVTT.

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::isOrderedBefore):

11:07 AM Changeset in webkit [151784] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=117711

Patch by Ralph Thomas <​ralpht@gmail.com> on 2013-06-20
Reviewed by Laszlo Gombos.

No new tests, no CMake platforms currently enable this functionality.

  • CMakeLists.txt:
11:04 AM Changeset in webkit [151783] by alexis@webkit.org
  • 44 edits in trunk/Source/WebCore

Cleanup usage of CSSPropertyID and CSSValueID inside WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=117829

Reviewed by Andreas Kling.

A lot of call sites were using integers to represent them. While it's
not incorrect per se, it's not ideal for various reason such as type
safety or to remove ambiguity.

This patch eradicate the wrong usage by not letting any integer based
API for getting CSSValueIDs or CSSPropertyIDs from CSSPrimitiveValues.

Instead we use new but typed functions to construct the values as well
as getting them. Two customs and internal types were added to CSSPrimitiveValue
to handle correctly the new APIs.

It's good to note that in order to preserve compatibility on the
CSSPrimitiveValue type whenever CSSPrimitiveValue handles a CSSValueID
or a CSSPropertyID the return type for the public API will be CSS_IDENT
despite it is a separate internal type.

No new tests: refactor, existing tests should cover.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyMatches):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSGradientValue.cpp:

(WebCore::positionFromValue):
(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::customCssText):
(WebCore::CSSRadialGradientValue::createGradient):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSystemColor):
(WebCore::isFillPositionKeyword):
(WebCore::CSSParser::parse4ValuesFillPosition):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isBlendMode):
(WebCore::CSSParser::isCompositeOperator):

  • css/CSSParser.h:
  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::propertyName):
(WebCore::valueName):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isValueID):
(WebCore::CSSPrimitiveValue::createIdentifier):
(WebCore::CSSPrimitiveValue::createParserOperator):
(WebCore::CSSPrimitiveValue::getPropertyID):
(WebCore::CSSPrimitiveValue::getValueID):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CSSReflectionDirection):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):
(WebCore::CSSPrimitiveValue::operator PrintColorAdjust):
(WebCore::CSSPrimitiveValue::operator EBorderStyle):
(WebCore::CSSPrimitiveValue::operator OutlineIsAuto):
(WebCore::CSSPrimitiveValue::operator CompositeOperator):
(WebCore::CSSPrimitiveValue::operator ControlPart):
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
(WebCore::CSSPrimitiveValue::operator EFillAttachment):
(WebCore::CSSPrimitiveValue::operator EFillBox):
(WebCore::CSSPrimitiveValue::operator EFillRepeat):
(WebCore::CSSPrimitiveValue::operator EBoxPack):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):
(WebCore::CSSPrimitiveValue::operator EBoxDecorationBreak):
(WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin):
(WebCore::CSSPrimitiveValue::operator EBoxSizing):
(WebCore::CSSPrimitiveValue::operator EBoxDirection):
(WebCore::CSSPrimitiveValue::operator EBoxLines):
(WebCore::CSSPrimitiveValue::operator EBoxOrient):
(WebCore::CSSPrimitiveValue::operator ECaptionSide):
(WebCore::CSSPrimitiveValue::operator EClear):
(WebCore::CSSPrimitiveValue::operator ECursor):
(WebCore::CSSPrimitiveValue::operator CursorVisibility):
(WebCore::CSSPrimitiveValue::operator EDisplay):
(WebCore::CSSPrimitiveValue::operator EEmptyCell):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EFlexDirection):
(WebCore::CSSPrimitiveValue::operator EAlignContent):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):
(WebCore::CSSPrimitiveValue::operator EFloat):
(WebCore::CSSPrimitiveValue::operator LineBreak):
(WebCore::CSSPrimitiveValue::operator EListStylePosition):
(WebCore::CSSPrimitiveValue::operator EListStyleType):
(WebCore::CSSPrimitiveValue::operator EMarginCollapse):
(WebCore::CSSPrimitiveValue::operator EMarqueeBehavior):
(WebCore::CSSPrimitiveValue::operator RegionFragment):
(WebCore::CSSPrimitiveValue::operator EMarqueeDirection):
(WebCore::CSSPrimitiveValue::operator ENBSPMode):
(WebCore::CSSPrimitiveValue::operator EOverflow):
(WebCore::CSSPrimitiveValue::operator EPageBreak):
(WebCore::CSSPrimitiveValue::operator EPosition):
(WebCore::CSSPrimitiveValue::operator EResize):
(WebCore::CSSPrimitiveValue::operator ETableLayout):
(WebCore::CSSPrimitiveValue::operator ETextAlign):
(WebCore::CSSPrimitiveValue::operator TextAlignLast):
(WebCore::CSSPrimitiveValue::operator TextJustify):
(WebCore::CSSPrimitiveValue::operator TextDecoration):
(WebCore::CSSPrimitiveValue::operator TextDecorationStyle):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition):
(WebCore::CSSPrimitiveValue::operator ETextSecurity):
(WebCore::CSSPrimitiveValue::operator ETextTransform):
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
(WebCore::CSSPrimitiveValue::operator EUserDrag):
(WebCore::CSSPrimitiveValue::operator EUserModify):
(WebCore::CSSPrimitiveValue::operator EUserSelect):
(WebCore::CSSPrimitiveValue::operator EVerticalAlign):
(WebCore::CSSPrimitiveValue::operator EVisibility):
(WebCore::CSSPrimitiveValue::operator EWhiteSpace):
(WebCore::CSSPrimitiveValue::operator EWordBreak):
(WebCore::CSSPrimitiveValue::operator EOverflowWrap):
(WebCore::CSSPrimitiveValue::operator TextDirection):
(WebCore::CSSPrimitiveValue::operator WritingMode):
(WebCore::CSSPrimitiveValue::operator TextCombine):
(WebCore::CSSPrimitiveValue::operator RubyPosition):
(WebCore::CSSPrimitiveValue::operator TextEmphasisPosition):
(WebCore::CSSPrimitiveValue::operator TextOverflow):
(WebCore::CSSPrimitiveValue::operator TextEmphasisFill):
(WebCore::CSSPrimitiveValue::operator TextEmphasisMark):
(WebCore::CSSPrimitiveValue::operator TextOrientation):
(WebCore::CSSPrimitiveValue::operator EPointerEvents):
(WebCore::CSSPrimitiveValue::operator FontDescription::Kerning):
(WebCore::CSSPrimitiveValue::operator FontSmoothingMode):
(WebCore::CSSPrimitiveValue::operator FontWeight):
(WebCore::CSSPrimitiveValue::operator FontItalic):
(WebCore::CSSPrimitiveValue::operator FontSmallCaps):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
(WebCore::CSSPrimitiveValue::operator ColorSpace):
(WebCore::CSSPrimitiveValue::operator Hyphens):
(WebCore::CSSPrimitiveValue::operator LineSnap):
(WebCore::CSSPrimitiveValue::operator LineAlign):
(WebCore::CSSPrimitiveValue::operator Order):
(WebCore::CSSPrimitiveValue::operator ESpeak):
(WebCore::CSSPrimitiveValue::operator BlendMode):
(WebCore::CSSPrimitiveValue::operator LineCap):
(WebCore::CSSPrimitiveValue::operator LineJoin):
(WebCore::CSSPrimitiveValue::operator WindRule):
(WebCore::CSSPrimitiveValue::operator EAlignmentBaseline):
(WebCore::CSSPrimitiveValue::operator EBorderCollapse):
(WebCore::CSSPrimitiveValue::operator EBorderFit):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
(WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
(WebCore::CSSPrimitiveValue::operator ColumnAxis):
(WebCore::CSSPrimitiveValue::operator ColumnProgression):
(WebCore::CSSPrimitiveValue::operator WrapFlow):
(WebCore::CSSPrimitiveValue::operator WrapThrough):
(WebCore::CSSPrimitiveValue::operator GridAutoFlow):
(WebCore::CSSPrimitiveValue::convertToLength):
(WebCore::CSSPrimitiveValue::operator EBufferedRendering):
(WebCore::CSSPrimitiveValue::operator EColorInterpolation):
(WebCore::CSSPrimitiveValue::operator EColorRendering):
(WebCore::CSSPrimitiveValue::operator EDominantBaseline):
(WebCore::CSSPrimitiveValue::operator EShapeRendering):
(WebCore::CSSPrimitiveValue::operator ETextAnchor):
(WebCore::CSSPrimitiveValue::operator SVGWritingMode):
(WebCore::CSSPrimitiveValue::operator EVectorEffect):
(WebCore::CSSPrimitiveValue::operator EMaskType):

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):

  • css/Counter.h:

(WebCore::Counter::listStyleIdent):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::getPageSizeFromName):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):

  • css/MediaQueryEvaluator.cpp:

(WebCore::orientationMediaFeatureEval):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getLayeredShorthandValue):

  • css/StyleResolver.cpp:

(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::colorForCSSValue):
(WebCore::StyleResolver::colorFromPrimitiveValueIsDerivedFromElement):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):

  • css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::getViewportArgumentValue):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

  • editing/ApplyStyleCommand.cpp:

(WebCore::toIdentifier):

  • editing/EditingStyle.cpp:

(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::create):
(WebCore::HTMLElementEquivalent::HTMLElementEquivalent):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::HTMLTextDecorationEquivalent::create):
(WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::fontWeightIsBold):
(WebCore::legacyFontSizeFromCSSValue):
(WebCore::isTransparentColorValue):

  • editing/EditingStyle.h:
  • editing/markup.cpp:

(WebCore::propertyMissingOrEqualToNone):

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::systemFont):

  • platform/blackberry/RenderThemeBlackBerry.h:

(WebCore::RenderThemeBlackBerry::systemFont):

  • platform/blackberry/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::systemFont):

  • platform/blackberry/RenderThemeEfl.h:

(WebCore::RenderThemeEfl::systemFont):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::systemFont):

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp:

(WebCore::RenderThemeGtk::systemColor):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::systemColor):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::systemColor):

  • platform/qt/RenderThemeQt.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::systemColor):

  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemFont):
(WebCore::RenderThemeMac::systemColor):

  • rendering/RenderThemeSafari.h:

(WebCore::RenderThemeSafari::systemFont):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::systemFont):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::systemFont):
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWin::systemColor):

  • rendering/RenderThemeWin.h:
  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::systemFont):
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWinCE::systemColor):

  • rendering/RenderThemeWinCE.h:
10:57 AM Changeset in webkit [151782] by Lucas Forschler
  • 1 copy in branches/safari-537-branch

New Branch.

10:54 AM Changeset in webkit [151781] by fpizlo@apple.com
  • 22 edits
    8 adds in branches/dfgFourthTier

fourthTier: DFG should have switch_char
​https://bugs.webkit.org/show_bug.cgi?id=117710

Source/JavaScriptCore:

Reviewed by Michael Saboff.

Add op_switch_char. Most of this is fairly simple, except for the whole
LazyJSValue thing.

It's long been the case that anytime you wanted the DFG to speak of a string
that didn't appear in the constant pool, you would have a hard time since
the DFG isn't allowed to allocate in the GC heap. For example, if you know
that you want to speak of a single character string, you might find that
the one you wanted to speak of had been GC'd. Another example is if you
wanted to add constant folding for string concatenation - something we don't
have yet but will want eventually.

I solve this by finally adding the notion of LazyJSValue. In the future I
anticipate using this for a variety of string-related things. The idea here
is that the DFG can either say that it already knows what the value is, or
it can describe the value. For example, in this patch I needed to be able to
describe single-character strings.

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecode/JumpTable.h:
  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGPRInfo.h:

(JSC::DFG::JSValueRegs::payloadGPR):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpTable):
(DFG):
(JSC::DFG::JITCompiler::numberOfJumpTables):
(JSC::DFG::JITCompiler::linkSwitches):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JITCompiler):

  • dfg/DFGLazyJSValue.cpp: Added.

(DFG):
(JSC::DFG::LazyJSValue::getValue):
(JSC::DFG::equalToSingleCharacter):
(JSC::DFG::LazyJSValue::strictEqual):
(JSC::DFG::LazyJSValue::dump):

  • dfg/DFGLazyJSValue.h: Added.

(DFG):
(LazyJSValue):
(JSC::DFG::LazyJSValue::LazyJSValue):
(JSC::DFG::LazyJSValue::singleCharacterString):
(JSC::DFG::LazyJSValue::tryGetValue):
(JSC::DFG::LazyJSValue::value):
(JSC::DFG::LazyJSValue::character):
(JSC::DFG::LazyJSValue::switchLookupValue):

  • dfg/DFGNode.h:

(JSC::DFG::SwitchCase::SwitchCase):
(SwitchCase):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
(JSC::DFG::SpeculativeJIT::emitSwitchImmIntJump):
(DFG):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchCharStringJump):
(JSC::DFG::SpeculativeJIT::emitSwitchChar):
(JSC::DFG::SpeculativeJIT::emitSwitch):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

Source/WTF:

Reviewed by Michael Saboff.

I wanted to be able to say stringImpl->at(index), and now I can!

Also made it possible to convert a UChar to a utf8 CString without
allocating a StringImpl.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::utf8Impl):
(WTF):
(WTF::StringImpl::utf8ForCharacters):
(WTF::StringImpl::utf8ForRange):

  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::at):
(WTF::StringImpl::operator[]):

LayoutTests:

Rubber stamped by Mark Hahnenberg.

  • fast/js/regress/script-tests/switch-char-constant.js: Added.

(foo):
(bar):

  • fast/js/regress/script-tests/switch-char.js: Added.

(foo):
(bar):

  • fast/js/regress/switch-char-constant-expected.txt: Added.
  • fast/js/regress/switch-char-constant.html: Added.
  • fast/js/regress/switch-char-expected.txt: Added.
  • fast/js/regress/switch-char.html: Added.
10:14 AM Changeset in webkit [151780] by commit-queue@webkit.org
  • 6 edits in trunk

[BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
​https://bugs.webkit.org/show_bug.cgi?id=117827

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-06-20
Reviewed by Rob Buis.

Source/WebKit/blackberry:

Add DumpRenderTreeClient::willSendRequestForFrame() to handle
dispatchWillSendRequest() in DRT.

Fixes tests
fast/loader/onload-willSendRequest-null-for-script.html and
fast/loader/willSendRequest-null-for-preload.html.

  • Api/DumpRenderTreeClient.h:
  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):

Tools:

Reset the passed in request if willSendRequestReturnsNull() is
true or willSendRequestReturnsNullOnRedirect() is true and it's a
redirection.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):

  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
9:59 AM Changeset in webkit [151779] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Commit queue shouldn't reopen unrelated bugs because of flakiness
​https://bugs.webkit.org/show_bug.cgi?id=117503

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/tool/bot/flakytestreporter.py:

(_follow_duplicate_chain):
(_update_bug_for_flaky_test):

9:16 AM Changeset in webkit [151778] by Brent Fulgham
  • 7 edits in trunk/Source/WebCore

AX: List Items should support a default action
​https://bugs.webkit.org/show_bug.cgi?id=117812

Reviewed by Chris Fleizach.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::actionVerb): Provide a "select" verb
for use in ListItemRole objects.

  • platform/LocalizedStrings.cpp:

(WebCore::AXListItemActionVerb): Added.

  • platform/LocalizedStrings.h:
  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

(WebCore::AXListItemActionVerb):

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::AXListItemActionVerb):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::AXListItemActionVerb):

9:13 AM Changeset in webkit [151777] by commit-queue@webkit.org
  • 36 edits
    3 copies
    4 adds in trunk

[CSS Regions] Add new regionOversetChange event
​https://bugs.webkit.org/show_bug.cgi?id=117508

Source/WebCore:

Added regionOversetChange event and tests for it. The overset value of the region has been moved to the ElementRareData
object instead of the RenderRegion object. This was needed for the case when a reattach is performed (for instance by changing
the display type of the region's containing block) and the RenderRegion object is destroyed. When computing the overset again,
there would be no "previous" value to compare it to and decide whether the regionOversetChange event must be dispatched.

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-20
Reviewed by Antti Koivisto.

Tests: fast/regions/webkit-named-flow-event-add-to-flow.html:

fast/regions/webkit-named-flow-event-auto-height.html:
fast/regions/webkit-named-flow-event-crash.html:
fast/regions/webkit-named-flow-event-no-regions.html:
fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Added.
fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html: Added.
fast/regions/webkit-named-flow-event-remove-from-dom.html:
fast/regions/webkit-named-flow-event-remove-from-flow.html:
fast/regions/webkit-named-flow-event-target.html:
fast/regions/webkit-named-flow-event-to-null.html:
fast/regions/webkit-named-flow-event.html:

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.cpp:

(WebCore::Element::setRegionOversetState):
(WebCore::Element::regionOversetState):
(WebCore::Element::webkitRegionOverset):

  • dom/Element.h:
  • dom/ElementRareData.cpp:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::regionOversetState):
(WebCore::ElementRareData::setRegionOversetState):
(WebCore::ElementRareData::ElementRareData):

  • dom/EventNames.h:
  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore::WebKitNamedFlow::dispatchRegionOversetChangeEvent):

  • dom/WebKitNamedFlow.h:

(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::scheduleFor):
(WebCore::ChangeRegionOversetTask::unschedule):
(WebCore::ChangeRegionOversetTask::reset):
(WebCore::ChangeRegionOversetTask::onTimer):

  • rendering/RegionOversetState.h: Added.
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeOversetStateForRegions):

  • rendering/RenderFlowThread.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):
(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):

  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):

  • rendering/RenderRegion.h:

LayoutTests:

Changed regionLayoutUpdate tests to regionOversetChange and added new tests for regionOversetChange.

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-20
Reviewed by Antti Koivisto.

  • fast/regions/webkit-named-flow-event-add-to-flow-expected.txt:
  • fast/regions/webkit-named-flow-event-add-to-flow.html:
  • fast/regions/webkit-named-flow-event-auto-height-expected.txt:
  • fast/regions/webkit-named-flow-event-auto-height.html: Added.
  • fast/regions/webkit-named-flow-event-crash-expected.txt:
  • fast/regions/webkit-named-flow-event-crash.html:
  • fast/regions/webkit-named-flow-event-expected.txt:
  • fast/regions/webkit-named-flow-event-no-regions-expected.txt:
  • fast/regions/webkit-named-flow-event-no-regions.html:
  • fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change-expected.txt:
  • fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Added.
  • fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change-expected.txt:
  • fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html: Added.
  • fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt:
  • fast/regions/webkit-named-flow-event-remove-from-dom.html:
  • fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt:
  • fast/regions/webkit-named-flow-event-remove-from-flow.html:
  • fast/regions/webkit-named-flow-event-target-expected.txt:
  • fast/regions/webkit-named-flow-event-target.html:
  • fast/regions/webkit-named-flow-event-to-null-expected.txt:
  • fast/regions/webkit-named-flow-event-to-null.html:
  • fast/regions/webkit-named-flow-event.html:
9:08 AM Changeset in webkit [151776] by commit-queue@webkit.org
  • 9 edits in trunk

AX: aria-required is not exposed on all expected roles
​https://bugs.webkit.org/show_bug.cgi?id=115123

Patch by James Craig <​james@cookiecrook.com> on 2013-06-20
Reviewed by Chris Fleizach.

aria-required is now exposed on more roles. Updated existing test file.

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::supportsRequiredAttribute):

  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::supportsRequiredAttribute):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):

LayoutTests:

  • platform/mac/accessibility/aria-required-expected.txt:
  • platform/mac/accessibility/aria-required.html:
  • platform/mac/accessibility/radio-button-group-members-expected.txt:
7:26 AM WebKitGTK/StartHacking edited by Andres Gomez
More minor changes (diff)
7:24 AM WebKitGTK/StartHacking edited by Andres Gomez
Minor change (diff)
7:20 AM WebKitGTK/StartHacking edited by Andres Gomez
Minor styling (diff)
7:17 AM WebKitGTK/StartHacking edited by eocanha@igalia.com
(diff)
7:11 AM Changeset in webkit [151775] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Update text checker documentation.
​https://bugs.webkit.org/show_bug.cgi?id=117828

Reviewed by Christophe Dumez.

  • UIProcess/API/efl/ewk_text_checker.h:

The client is not responsible for destroying the memory.

7:09 AM WebKitGTK/StartHacking edited by Andres Gomez
Added choosing distribution section (diff)
6:21 AM Changeset in webkit [151774] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk

Web Inspector: Use console.timeStamp instead of console.markTimeline
​https://bugs.webkit.org/show_bug.cgi?id=117810

Patch by Seokju Kwon <Seokju Kwon> on 2013-06-20
Reviewed by Joseph Pecoraro.

Source/WebCore:

Webkit supports both console.timeStamp and console.markTimeline.
And they do the exact same thing.
This patch gets rid of console.markTimeline for Chrome/Firebug compatibility.

No new functionality, no new tests.

  • WebCore.order:
  • page/Console.cpp:
  • page/Console.h:
  • page/Console.idl:

LayoutTests:

Use 'console.timeStamp' instead of 'console.markTimeline' in LayoutTests.
And remove inspector/timeline/timeline-mark-timeline.html.

  • inspector/console/console-messages-stack-traces-expected.txt:
  • inspector/console/console-messages-stack-traces.html:
  • inspector/timeline/timeline-mark-timeline-expected.txt: Removed.
  • inspector/timeline/timeline-mark-timeline.html: Removed.
  • inspector/timeline/timeline-timer-fired-from-eval-call-site.html:
1:22 AM Changeset in webkit [151773] by zarvai@inf.u-szeged.hu
  • 2 edits
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

Rebselining after r151761, see bug 115372.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-child-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-parent-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-same-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/vertical-overflow-child-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/vertical-overflow-parent-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/vertical-overflow-same-expected.txt: Added.
1:04 AM WebKitGTK/2.0.x edited by agarcia@igalia.com
(diff)
12:39 AM Changeset in webkit [151772] by g.czajkowski@samsung.com
  • 4 edits
    6 adds in trunk

background-color and text-decoration are not preserved when merging paragraphs
​https://bugs.webkit.org/show_bug.cgi?id=116215

Reviewed by Ryosuke Niwa.

Source/WebCore:

In mergeInlineAndImplicitStyleOfElement(), style from matched rules are retrieved.
If they contain either background-color or text-decoration they will be removed
by removeNonEditingProperties() due to copyEditingProperties() implicit
'OnlyInheritableEditingProperties' parameter.
We have already had similar issue at ​https://bugs.webkit.org/show_bug.cgi?id=53196

Tests: editing/deleting/merge-div-from-span-with-style.html

editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html
editing/deleting/merge-paragraph-from-span-with-style.html

  • editing/EditingStyle.cpp:

(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
Add EditingStyle:: due to move EditingPropertiesToInclude to EditingStyle.h.

(WebCore::toEditingProperties):
Add a helper to easy convert PropertiesToInclude to EditingPropertiesToInclude,
needed in mergeInlineAndImplicitStyleOfElement().

(WebCore::EditingStyle::removeAllButEditingProperties):
Add a parameter to choose which editing properties should be preserved while
removing all properties (OnlyInheritableEditingProperties implicite).

(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
Call removeAllButEditingProperties with parameter.

  • editing/EditingStyle.h:

Move EditingPropertiesType to the header as it's needed by removeAllButEditingProperties().
Change EditingPropertiesType to EditingPropertiesToInclude to be consistent with
PropertiesToInclude.
Change removeNonEditingProperties() to removeAllButEditingProperties().

LayoutTests:

Added tests for verifying merge of paragraph/div from span with non-inline styles.

  • editing/deleting/merge-div-from-span-with-style-expected.txt: Added.
  • editing/deleting/merge-div-from-span-with-style.html: Added.
  • editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html: Added.
  • editing/deleting/merge-paragraph-from-span-with-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-span-with-style.html: Added.

Jun 19, 2013:

10:44 PM Changeset in webkit [151771] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

The order of the generated supplemental code is not guaranteed
​https://bugs.webkit.org/show_bug.cgi?id=117820

Reviewed by Kentaro Hara.

Sort the supplemental idl files before generating the code so that it is
generated in a consistent order.

No new tests, covered by existing bindings tests.

  • bindings/scripts/generate-bindings.pl:
10:39 PM Changeset in webkit [151770] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r151769.
​http://trac.webkit.org/changeset/151769
​https://bugs.webkit.org/show_bug.cgi?id=117821

Broke windows build due to missing GL/glext.h header.
(Requested by bfulgham on #webkit).

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
10:06 PM Changeset in webkit [151769] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Added WebGL files to Windows build without enabling them.
​https://bugs.webkit.org/show_bug.cgi?id=117809

Patch by Alex Christensen <​alex.christensen@flexsim.com> on 2013-06-19
Reviewed by Brent Fulgham.

  • WebCore.vcxproj/WebCore.vcxproj: Added WebGL source files.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Added platform\graphics\opengl and platform\graphics\gpu filters.
10:04 PM Changeset in webkit [151768] by achristensen@apple.com
  • 4 edits in trunk/Source/WebCore

Windows build should include WebGL generated files if WebGL is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=117802

Reviewed by Brent Fulgham.

Added WebGL generated files to Windows build if WebGL is enabled.

  • DerivedSources.cpp:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
9:30 PM Changeset in webkit [151767] by weinig@apple.com
  • 8 edits in trunk/Source/WebKit2

Expose plug-ins CFBundleShortVersionString in the WKPluginInformation dictionary
​https://bugs.webkit.org/show_bug.cgi?id=117816

Reviewed by Geoffrey Garen.

  • Adds a new key for the WKPluginInformation dictionary: WKPluginInformationBundleShortVersionKey().
  • Shared/API/c/WKPluginInformation.cpp:

(WKPluginInformationBundleShortVersionKey):

  • Shared/API/c/WKPluginInformation.h:
  • Shared/Plugins/Netscape/PluginInformation.cpp:

(WebKit::pluginInformationBundleShortVersionKey):

  • Shared/Plugins/Netscape/PluginInformation.h:
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::getPluginInfo):

  • Shared/Plugins/Netscape/mac/PluginInformationMac.mm:

(WebKit::getPlatformPluginModuleInformation):

  • Shared/Plugins/PluginModuleInfo.h:
9:22 PM Changeset in webkit [151766] by Beth Dakin
  • 1 edit
    1 add in trunk/LayoutTests

Adding a Mac pixel result.

  • platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
9:20 PM Changeset in webkit [151765] by Brent Fulgham
  • 1 edit
    3 adds in trunk/LayoutTests

[Windows] Unreviewed AX test expecation gardening.

  • platform/win/accessibility/aria-labelledby-on-input-expected.txt: Added.
  • platform/win/accessibility/aria-list-and-listitem-expected.txt: Added.
  • platform/win/accessibility/aria-roles-expected.txt: Added.
9:14 PM Changeset in webkit [151764] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] AX: Expand notification support.
​https://bugs.webkit.org/show_bug.cgi?id=117761

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::isPressActionSupported): Provide implementation.
(AccessibilityUIElement::press): Provide implementation.

7:35 PM Changeset in webkit [151763] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Unskip feSpecularLight-premultiplied.svg on Mountain Lion

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-06-19

  • platform/mac/TestExpectations:

The test is failing on Lion exclusively.

7:18 PM Changeset in webkit [151762] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Common crashes when playing media
​https://bugs.webkit.org/show_bug.cgi?id=117813
<rdar://problem/13837412>

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]): This method may be called from a secondary thread, but it does things that are not thread safe.
6:06 PM Changeset in webkit [151761] by commit-queue@webkit.org
  • 4 edits
    12 adds in trunk

Incomplete repaint of input elements in writing-mode overflow
​https://bugs.webkit.org/show_bug.cgi?id=110246

Patch by Yuki Sekiguchi <​yuki.sekiguchi@access-company.com> on 2013-06-19
Reviewed by Simon Fraser.

Source/WebCore:

We calculate repaint rect using unflipped rect.
However, RenderBox::applyCachedClipAndScrollOffsetForRepaint() which is called from repaint rect calculation
wants that its argument rect is flipped.
The reason is:

  • paintRect.move(-scrolledContentOffset()); cannot scroll if the rect is unflipped.
  • It cannot clip using intersect.

Passing unflipped rect to applyCachedClipAndScrollOffsetForRepaint() cause invalid clipping.
Therefore, this patch flipped the rect at the first part of the function and unflipped it at the last part of the function.

Scroll bar rect is absolute rect, so it is flipped rect.
RenderLayer::invalidateScrollbarRect() pass the rect to repaintRectangle() which expects an argument rect is unflipped.
This cause part of overlapping scroll bar doesn't fade out.
Therefore, this patch flipped the rect and pass it to repaintRectangle().

Tests: fast/repaint/horizontal-bt-overflow-child.html

fast/repaint/horizontal-bt-overflow-parent.html
fast/repaint/horizontal-bt-overflow-same.html
fast/repaint/vertical-overflow-child.html
fast/repaint/vertical-overflow-parent.html
fast/repaint/vertical-overflow-same.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::invalidateScrollbarRect):

LayoutTests:

  • fast/repaint/horizontal-bt-overflow-child-expected.txt: Added.
  • fast/repaint/horizontal-bt-overflow-child.html: Added.
  • fast/repaint/horizontal-bt-overflow-parent-expected.txt: Added.
  • fast/repaint/horizontal-bt-overflow-parent.html: Added.
  • fast/repaint/horizontal-bt-overflow-same-expected.txt: Added.
  • fast/repaint/horizontal-bt-overflow-same.html: Added.
  • fast/repaint/vertical-overflow-child-expected.txt: Added.
  • fast/repaint/vertical-overflow-child.html: Added.
  • fast/repaint/vertical-overflow-parent-expected.txt: Added.
  • fast/repaint/vertical-overflow-parent.html: Added.
  • fast/repaint/vertical-overflow-same-expected.txt: Added.
  • fast/repaint/vertical-overflow-same.html: Added.
5:10 PM Changeset in webkit [151760] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

<rdar://problem/14197983> Rename functions from Bug 117667 and add safeguards for !ENABLE(VIDEO) platforms (117765)
​https://bugs.webkit.org/show_bug.cgi?id=117765

Patch by Ruth Fong <​ruth_fong@apple.com>.
Reviewed by Brady Eidson.

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultGetMediaType): Updated to use mediaType().

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::mediaType): Updated.
Renamed getMediaType() to mediaType() and now handles !ENABLE(VIDEO) platforms.

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
4:37 PM Changeset in webkit [151759] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Unskip two canvas tests that only fail on Lion

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-06-19

  • platform/mac/TestExpectations:
4:17 PM Changeset in webkit [151758] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline 24bit-22khz-resample on Mac

The result did not match the expectation after a system update.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-06-19

  • platform/mac-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav:

Comparing the files, they have the exact same length, sample rate, bit per sample and binary size.
I cannot ear a difference in the files.

3:41 PM Changeset in webkit [151757] by benjamin@webkit.org
  • 28 edits in trunk

Use the PlatformEvent timestamp when creating a DOM Event
​https://bugs.webkit.org/show_bug.cgi?id=117179

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-06-19
Reviewed by Darin Adler.

Source/WebCore:

Previously, the platform event's timestamp was ignored by WebCore and each
new event would get a new timestamp by calling WTF::currentTime().

The problem is there can be a significant delay between the input event and
it being dispatched to JavaScript. Computing the velocity/acceleration of the cursor
is impossible since the delay vary from event to events.
On WebKit2, the delay per event typically vary between 0 and 30ms.

This patch changes the Event creation code to use the timer passed by the underlying platform event.

  • WebCore.exp.in:
  • dom/Event.cpp:

(WebCore::Event::Event):

  • dom/Event.h:
  • dom/GestureEvent.cpp:

(WebCore::GestureEvent::create):
(WebCore::GestureEvent::GestureEvent):

  • dom/GestureEvent.h:
  • dom/KeyboardEvent.cpp:

(WebCore::KeyboardEvent::KeyboardEvent):

  • dom/KeyboardEvent.h:
  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):

  • dom/MouseEvent.h:
  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

  • dom/MouseRelatedEvent.h:
  • dom/TouchEvent.cpp:

(WebCore::TouchEvent::TouchEvent):

  • dom/UIEvent.cpp:

(WebCore::UIEvent::UIEvent):

  • dom/UIEvent.h:
  • dom/UIEventWithKeyState.h:

(WebCore::UIEventWithKeyState::UIEventWithKeyState):

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):

  • dom/WheelEvent.h:

(WebCore::WheelEvent::create):

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebCore::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

Source/WebKit/mac:

  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Source/WebKit2:

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebGestureEvent):

Tools:

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::keyDown):

3:28 PM Changeset in webkit [151756] by ggaren@apple.com
  • 1 edit in trunk/Source/WTF/ChangeLog

Fixed reviewer name

3:27 PM Changeset in webkit [151755] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

Remove the SegmentedVector inline segment to shrink CodeBlock by 6X
​https://bugs.webkit.org/show_bug.cgi?id=117808

Reviewed by Geoffrey Garen.

SegmentedVector allocation isn't super hot, but we do tend to have many
live SegmentedVectors at runtime, particularly in CodeBlocks, so the
right tradeoff is to allocate segments out-of-line as needed.

This reduces startup memory usage @ google.com by about 6MB.

No regression on SunSpider.

  • wtf/SegmentedVector.h:

(WTF::SegmentedVector::SegmentedVector):
(WTF::SegmentedVector::at):
(WTF::SegmentedVector::append):
(WTF::SegmentedVector::removeLast):
(WTF::SegmentedVector::clear):
(WTF::SegmentedVector::deleteAllSegments): No more inline segment.

(WTF::SegmentedVector::ensureSegmentsFor): This code used to assume
that there was always a 0 segment, so the math would underflow if there
were no 0 segment. I udpated the math to account for having no segments.

3:16 PM BuildingGtk edited by Andres Gomez
Added links to root pages (diff)
3:12 PM WebKitGTK/StartHacking edited by Andres Gomez
(diff)
3:11 PM WebKitGTK/StartHacking edited by Andres Gomez
Added hacking guide section (diff)
3:07 PM WebKitGTK/Chroot edited by Andres Gomez
(diff)
3:07 PM Changeset in webkit [151754] by alexis@webkit.org
  • 21 edits in trunk/Source/WebCore

Make sure to use CSSValueID and CSSPropertyID rather than integers
​https://bugs.webkit.org/show_bug.cgi?id=117481

Reviewed by Benjamin Poulain.

This will ensure that types are enforced when passing arguments in various
css functions. Having a compile time check make sure that no mistakes
will be done over the type.

The parser was also patched to directly use CSSValueID over integers.
This patch also fixes various call sites abusing the usage of integers.
This is part 1 of 2.

No new tests : existing ones should cover.

  • WebCore.xcodeproj/project.pbxproj: copy CSSValueKeywords.h as it could be used in WebKit/ for example.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForRepeatRule):
(WebCore::cssIdentifierForFontSizeKeyword):
(WebCore::identifierForFamily):
(WebCore::valueForFamily):

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseLineHeight):
(WebCore::CSSParser::parseFontSize):
(WebCore::CSSParser::createFontWeightValueKeyword):
(WebCore::CSSParser::parseFontWeight):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::rewriteSpecifiers):

  • css/CSSParser.h:
  • css/CSSParserValues.h:
  • css/CSSPrimitiveValue.h:
  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createIdentifierValue):

  • css/CSSValuePool.h:
  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::setProperty):

  • css/StylePropertySet.h:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addPropertyToPresentationAttributeStyle):

  • dom/StyledElement.h:
  • editing/EditingStyle.cpp:

(WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue):
(WebCore::EditingStyle::prepareToApplyAt):

  • editing/EditorCommand.cpp:

(WebCore::executeApplyStyle):
(WebCore::executeFontSize):

  • html/HTMLElement.cpp:

(WebCore::unicodeBidiAttributeForDirAuto):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::cssValueFromFontSizeNumber):
(WebCore::HTMLFontElement::collectStyleForPresentationAttribute):

  • html/HTMLFontElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::leakBorderStyle):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::getCSSWritingDirection):
(WebCore::TextTrackCue::getCSSWritingMode):

  • html/track/TextTrackCue.h:
2:54 PM WebKitGTK/Chroot edited by Andres Gomez
Minor fix (diff)
2:53 PM WebKitGTK/Chroot edited by Andres Gomez
Added Fixes (diff)
1:54 PM Changeset in webkit [151753] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit/win

[Windows] Correct style on last patch.

Reviewed by Tim Horton.

  • WebCoreSupport/WebFrameNetworkingContext.cpp:

(WebFrameNetworkingContext::ensurePrivateBrowsingSession):

1:51 PM Changeset in webkit [151752] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit/win

[Windows] Unreviewed build correction.

  • WebCoreSupport/WebFrameNetworkingContext.cpp:

(WebFrameNetworkingContext::ensurePrivateBrowsingSession): Make sure returned generic
type is a CFStringRef before casting.

1:37 PM Changeset in webkit [151751] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit/win

Unreviewed build fix for Apple Windows port.

  • WebCoreSupport/WebFrameNetworkingContext.cpp:

(WebFrameNetworkingContext::ensurePrivateBrowsingSession):

1:11 PM Changeset in webkit [151750] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Fix a few missed renames from Exclusions -> Shapes
​https://bugs.webkit.org/show_bug.cgi?id=117803

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-19
Reviewed by David Hyatt.

In the great CSS Exclusions to CSS Shapes rename, a few instances were
missed. This fixes those instances.

No new tests, no behavior change, just renames.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateRegionsAndShapesBeforeChildLayout):
(WebCore::RenderBlock::updateRegionsAndShapesAfterChildLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

  • rendering/RenderBlock.h:
  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

1:09 PM Changeset in webkit [151749] by mhahnenberg@apple.com
  • 9 edits
    1 add in branches/dfgFourthTier/Source/JavaScriptCore

Refactor ObjCCallbackFunction to inherit directly from InternalFunction
​https://bugs.webkit.org/show_bug.cgi?id=117595

Reviewed by Geoffrey Garen.

  • API/APICallbackFunction.h: Added. New struct that allows JSCallbackFunction and

ObjCCallbackFunction to share their host call() implementation through the magic of
templates.
(JSC::APICallbackFunction::call):

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::getCallData): Changed to get the template-ized version of
the host function.

  • API/JSCallbackFunction.h:
  • API/ObjCCallbackFunction.h: Now inherits directly from InternalFunction.
  • API/ObjCCallbackFunction.mm:

(JSC::ObjCCallbackFunction::ObjCCallbackFunction):
(JSC::ObjCCallbackFunction::getCallData): Ditto.

1:05 PM Changeset in webkit [151748] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

REGRESSION: Cannot open Silverlight preferences via context menu
​https://bugs.webkit.org/show_bug.cgi?id=117806
<rdar://problem/14166644>

Reviewed by Beth Dakin.

Hook the LSOpenCFURLRef function and make the UI process open the URL if it's the URL for the
Silverlight Preferences application. This is what we do for the Flash updater.

  • PluginProcess/PluginProcess.h:
  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::openCFURLRef):
(WebKit::initializeShim):
(WebKit::PluginProcess::openURL):

  • PluginProcess/mac/PluginProcessShim.h:
  • PluginProcess/mac/PluginProcessShim.mm:

(WebKit::shimLSOpenCFURLRef):

  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.messages.in:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::isSilverlightPreferencesURL):
(WebKit::shouldOpenURL):
(WebKit::PluginProcessProxy::openURL):

12:45 PM Changeset in webkit [151747] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

Incorrect use of jsCast in a finalizer
​https://bugs.webkit.org/show_bug.cgi?id=117807

Reviewed by Geoffrey Garen.

We can't use jsCast in a finalizer as it checks an object's structure,
and the structure may already have been swept by that point. Use a
static_cast instead.

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::destroy):

11:54 AM Changeset in webkit [151746] by robert@webkit.org
  • 26 edits in trunk/LayoutTests

Rebaseline results on GTK and EFL after r151737

Unreviewed, gardening.

  • platform/efl/fast/css/word-space-extra-expected.txt:
  • platform/efl/fast/replaced/width100percent-image-expected.png:
  • platform/efl/fast/replaced/width100percent-image-expected.txt:
  • platform/efl/fast/replaced/width100percent-menulist-expected.png:
  • platform/efl/fast/replaced/width100percent-menulist-expected.txt:
  • platform/efl/fast/replaced/width100percent-searchfield-expected.png:
  • platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/efl/fast/replaced/width100percent-textarea-expected.png:
  • platform/efl/fast/replaced/width100percent-textarea-expected.txt:
  • platform/efl/fast/replaced/width100percent-textfield-expected.png:
  • platform/efl/fast/replaced/width100percent-textfield-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug57828-expected.png:
  • platform/efl/tables/mozilla/bugs/bug57828-expected.txt:
  • platform/gtk/fast/css/word-space-extra-expected.txt:
  • platform/gtk/fast/replaced/width100percent-image-expected.png:
  • platform/gtk/fast/replaced/width100percent-image-expected.txt:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.png:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.png:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/replaced/width100percent-textarea-expected.png:
  • platform/gtk/fast/replaced/width100percent-textarea-expected.txt:
  • platform/gtk/fast/replaced/width100percent-textfield-expected.png:
  • platform/gtk/fast/replaced/width100percent-textfield-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug57828-expected.txt:
11:45 AM Changeset in webkit [151745] by Brent Fulgham
  • 8 edits in trunk/Source

../WebCore: [Windows] AX: Extend notification handling
​https://bugs.webkit.org/show_bug.cgi?id=117761.

Reviewed by Anders Carlsson.

accessibility/press-works-on-control-types.html

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification): Add handlers for more event notifications.

  • accessibility/win/AccessibilityObjectWrapperWin.cpp:

(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue): Protect against null
pointer dereference found during testing.

  • dom/Document.cpp:

(WebCore::Document::implicitClose): Execute notification handler for Windows as well as Mac.

  • page/FrameView.cpp:

(WebCore::FrameView::layout): Ditto.

../WebKit/win: [Windows] AX: Extend notification support.
​https://bugs.webkit.org/show_bug.cgi?id=117761

Reviewed by Anders Carlsson.

  • AccessibleDocument.cpp:

(AccessibleDocument::state): Improve handling of focus state.

  • AccessibleDocument.h: Provide signature for new state override.
11:38 AM Changeset in webkit [151744] by msaboff@apple.com
  • 14 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Arity fixup should be done while on same stack
​https://bugs.webkit.org/show_bug.cgi?id=117102

Reviewed by Oliver Hunt.

Removed the fixup part of op_call_arityCheck() and op_construct_arityCheck() and moved it to
a thunk for the JITs and as assembly for the llint. This patch provides the plumbing needed to
move to the C stack for JS execution. The fixup thunk and llint code would need to be change to
work with a stack that grows down when we do move to the C stack.

Due to an issue with the offline assembler, I moved the const at the top of LowLevelInterpreter64.asm
and LowLevelInterpreter32_64.asm to LowLevelInterpreter.asm. The problem is that a const defined in
one file that are used in a macro doesn't resolve the const if the macro is used in another file. This
seemed like the quickest path.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::linkFunction):

  • dfg/DFGJITCompiler.h:

(JITCompiler):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • jit/ThunkGenerators.cpp:

(JSC::arityFixup):

  • jit/ThunkGenerators.h:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):

11:17 AM Changeset in webkit [151743] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk/Source/WebCore

[WinCairo] Webfont rendering is broken.
​https://bugs.webkit.org/show_bug.cgi?id=117695

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-06-19
Reviewed by Brent Fulgham.

The native font handle created from webfont data is invalid.
In much the same way it's done in WinApple, we first need to install the webfont,
create a native font handle from the new font name,
and pass the font handle to the FontPlatformData object, where it's needed to get the glyphs.

  • platform/graphics/FontPlatformData.h: Added HFONT parameter to constructor.
  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Release installed webfont.
(WebCore::FontCustomPlatformData::fontPlatformData): Create valid HFONT handle for webfont.
(WebCore::createUniqueFontName): Added method to create webfont name.
(WebCore::createFontCustomPlatformData): Install font from webfont data.

  • platform/graphics/win/FontCustomPlatformDataCairo.h: Removed.
  • platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::FontPlatformData): Added HFONT parameter to constructor.

11:05 AM Changeset in webkit [151742] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/win

[WinCairo] Does not compile.
​https://bugs.webkit.org/show_bug.cgi?id=117798

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-06-19
Reviewed by Brent Fulgham.

Add USE(CFNETWORK) guards.

  • WebCoreSupport/WebFrameNetworkingContext.cpp: Add USE(CFNETWORK) guard.

(WebFrameNetworkingContext::ensurePrivateBrowsingSession): Change USE(CF_NETWORK) to USE(CFNETWORK).

  • WebCoreSupport/WebFrameNetworkingContext.h: Add USE(CFNETWORK) guard.
10:42 AM Changeset in webkit [151741] by msaboff@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

FTL: arm build is broken in ToT
​https://bugs.webkit.org/show_bug.cgi?id=117800

Unreviewed build fixes.

  • assembler/ARMv7Assembler.h:

(ARMv7Assembler): Merge of r147941

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_mod): Moved variable declaration back inside #ifdef where used.

10:40 AM Changeset in webkit [151740] by Christophe Dumez
  • 18 edits
    1 copy
    9 adds in trunk/Source/WebCore

Implement WebIDL implements
​https://bugs.webkit.org/show_bug.cgi?id=117785

Reviewed by Kentaro Hara.

Add support for Web IDL 'implements' statements to the bindings generator:
​http://www.w3.org/TR/WebIDL/#dfn-implements-statement

Introduce ChildNode IDL interface and have Element, DocumentType and
CharacterData implement it, to match the specification:
​http://dom.spec.whatwg.org/#childnode

There is no change in behavior, merely refactoring to match the
specification by leveraging support for Web IDL implements statements.

No new tests, no behavior change.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • bindings/scripts/generate-bindings.pl:
  • bindings/scripts/preprocess-idls.pl:

(GeneratePartialInterface):
(getImplementersFromIDL):

  • bindings/scripts/test/CPP/WebDOMTestImplements.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestImplements.h: Added.
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp:

(WebDOMTestInterface::implementsStr1):
(WebDOMTestInterface::implementsStr2):
(WebDOMTestInterface::setImplementsStr2):
(WebDOMTestInterface::implementsNode):
(WebDOMTestInterface::setImplementsNode):
(WebDOMTestInterface::implementsMethod1):
(WebDOMTestInterface::implementsMethod4):

  • bindings/scripts/test/CPP/WebDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestImplements.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestImplements.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
(webkit_dom_test_interface_class_init):
(webkit_dom_test_interface_implements_method1):
(webkit_dom_test_interface_implements_method2):
(webkit_dom_test_interface_implements_method4):
(webkit_dom_test_interface_get_implements_str1):
(webkit_dom_test_interface_get_implements_str2):
(webkit_dom_test_interface_set_implements_str2):
(webkit_dom_test_interface_get_implements_node):
(webkit_dom_test_interface_set_implements_node):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/JS/JSTestImplements.cpp: Added.
  • bindings/scripts/test/JS/JSTestImplements.h: Added.
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorImplementsStaticAttr):
(WebCore::jsTestInterfaceImplementsStr1):
(WebCore::jsTestInterfaceImplementsStr2):
(WebCore::jsTestInterfaceImplementsStr3):
(WebCore::jsTestInterfaceImplementsNode):
(WebCore::setJSTestInterfaceConstructorImplementsStaticAttr):
(WebCore::setJSTestInterfaceImplementsStr2):
(WebCore::setJSTestInterfaceImplementsStr3):
(WebCore::setJSTestInterfaceImplementsNode):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod1):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod3):
(WebCore::jsTestInterfaceConstructorFunctionImplementsMethod4):
(WebCore::jsTestInterfaceIMPLEMENTSCONSTANT1):
(WebCore::jsTestInterfaceIMPLEMENTSCONSTANT2):

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/ObjC/DOMTestImplements.cpp: Added.
  • bindings/scripts/test/ObjC/DOMTestImplements.h: Added.
  • bindings/scripts/test/ObjC/DOMTestInterface.h:
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:

(-[DOMTestInterface implementsStr1]):
(-[DOMTestInterface implementsStr2]):
(-[DOMTestInterface setImplementsStr2:]):
(-[DOMTestInterface implementsStr3]):
(-[DOMTestInterface setImplementsStr3:]):
(-[DOMTestInterface implementsNode]):
(-[DOMTestInterface setImplementsNode:]):
(-[DOMTestInterface implementsMethod1]):
(-[DOMTestInterface implementsMethod2:objArg:]):
(-[DOMTestInterface implementsMethod3]):
(-[DOMTestInterface implementsMethod4]):

  • bindings/scripts/test/TestImplements.idl: Added.
  • dom/CharacterData.idl:
  • dom/ChildNode.idl: Copied from Source/WebCore/dom/DocumentType.idl.
  • dom/DocumentType.idl:
  • dom/Element.idl:
10:33 AM Changeset in webkit [151739] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

BUILD FIX (r151663): Fix build for iOS WebKit

  • wtf/text/AtomicStringTable.cpp: Include MainThread.h.

(WTF::AtomicStringTable::create): Use AtomicStringTable::destroy
instead of non-existent destroyAtomicStringTable function.

10:29 AM Changeset in webkit [151738] by Antoine Quint
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Copying array or object output does not contain values
​https://bugs.webkit.org/show_bug.cgi?id=117669

ConsoleCommandResult was overriding toClipboardString() but wasn't using the complex code
in ConsoleMessageImpl's toClipboardString() to provide a nicely formatted output for objects.
We now use a "clipboarPrefixString" property to customize the prefix used in the clipboard
and, additionally, only use that prefix if we're copying more than a single message since it's
the only situation where it's useful to have the ">" or "<" prefix shown. Console messages with
a log level always print the level and when saving the console log using Cmd+S, all messages
contain their prefix as well.

Reviewed by Timothy Hatcher.

  • UserInterface/ConsoleCommand.js:

(WebInspector.ConsoleCommand.prototype.toClipboardString):
Handle the new isPrefixOptional argument.

  • UserInterface/ConsoleCommandResult.js:

(WebInspector.ConsoleCommandResult.prototype.get clipboarPrefixString):
Provide a custom "< " prefix and set "enforcesClipboardPrefixString" to false such that
the prefix isn't printed out in situations when it may not.

  • UserInterface/ConsoleMessageImpl.js:

Set "enforcesClipboardPrefixString" to true since we always want to log the log level
prefix in all situations.

(WebInspector.ConsoleMessageImpl.prototype.get clipboarPrefixString):
Implement this new getter to return our clipboard string such that subclasses may
customize it.

(WebInspector.ConsoleMessageImpl.prototype.toClipboardString):
Take into account both isPrefixOptional and the "enforcesClipboardPrefixString" property
to only log the prefix if necessary.

  • UserInterface/LogContentView.js:

(WebInspector.LogContentView.prototype._formatMessagesAsData):
Make the logging of prefix optional when we have a single message selected and we're
not saving via Cmd+S.

10:20 AM Changeset in webkit [151737] by robert@webkit.org
  • 15 edits
    2 adds in trunk

Incorrect computation of shrink-to-fit width for block with white-space:nowrap and floating children
​https://bugs.webkit.org/show_bug.cgi?id=114879

Source/WebCore:

Reviewed by David Hyatt.
Per ​http://www.w3.org/TR/CSS21/visudet.html#Computing_widths_and_margins when width is auto then floating non-replaced,
absolute non-replaced, and inline-block non-replaced elements should use shrink-to-fit width. This trumps any no-wrap property
on the element so if we are shrinking to fit ensure our minimum width respects all possible line breaks.

Test: fast/block/shrink-to-fit-width-container-with-floating-children.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeIntrinsicLogicalWidths):

LayoutTests:

Reviewed by David Hyatt.

  • fast/block/shrink-to-fit-width-container-with-floating-children-expected.txt: Added.
  • fast/block/shrink-to-fit-width-container-with-floating-children.html: Added.
  • platform/qt/fast/css/word-space-extra-expected.txt:
  • platform/qt/fast/replaced/width100percent-image-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/qt/fast/replaced/width100percent-textfield-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug57828-expected.txt:
10:20 AM WebKitGtkLayoutTests edited by Andres Gomez
(diff)
10:19 AM WebKitGTK/Chroot created by Andres Gomez
Initial editing
10:12 AM Changeset in webkit [151736] by Christophe Dumez
  • 14 edits
    7 deletes in trunk/Source/WebCore

Do not require JS*Custom.h header if [CustomPutFunction] / [CustomNamedSetter] is used
​https://bugs.webkit.org/show_bug.cgi?id=117795

Reviewed by Kentaro Hara.

Fix the JS bindings generator so that it stops including JS*Custom.h header whenever
[CustomPutFunction] or [CustomNamedSetter] IDL extended attributes are used. We don't
really need this custom header and this forces the developer to create dummy custom
headers so that it builds.

If the developer really needs such custom header to be included, he can still use
[JSCustomHeader] IDL extended attribute to do so.

This patch also remove the dummy custom headers that were created but are no longer
required to build.

No new tests, no behavior change. Already covered by the following bindings test:
TestInterface.idl

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMStringMapCustom.h: Removed.
  • bindings/js/JSHTMLAppletElementCustom.cpp:
  • bindings/js/JSHTMLAppletElementCustom.h: Removed.
  • bindings/js/JSHTMLEmbedElementCustom.cpp:
  • bindings/js/JSHTMLEmbedElementCustom.h: Removed.
  • bindings/js/JSHTMLObjectElementCustom.cpp:
  • bindings/js/JSHTMLObjectElementCustom.h: Removed.
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/JSHistoryCustom.h: Removed.
  • bindings/js/JSLocationCustom.cpp:
  • bindings/js/JSLocationCustom.h: Removed.
  • bindings/js/JSStorageCustom.cpp:
  • bindings/js/JSStorageCustom.h: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

10:11 AM WebKitGTK/StartHacking edited by Andres Gomez
Added other section (diff)
9:27 AM WebKitGTK/StartHacking edited by Andres Gomez
Added contributin patches section (diff)
9:16 AM WebKitGTK/StartHacking edited by Andres Gomez
Added compilation issues section (diff)
9:09 AM WebKitGTK/StartHacking edited by Andres Gomez
Added continuous integration section (diff)
9:08 AM WebKitGTK/StartHacking edited by Andres Gomez
Added continuous integration section (diff)
9:01 AM WebKitGTK/Debugging edited by Andres Gomez
(diff)
9:00 AM WebKitGTK/TrackingMemoryErrors edited by Andres Gomez
(diff)
8:55 AM WebKitGTK/Debugging created by Andres Gomez
Initial editing
8:47 AM WebKitGTK/StartHacking edited by Andres Gomez
Added debugging section (diff)
8:45 AM WebKitGTK/StartHacking edited by Andres Gomez
Added rebuild and testing (diff)
8:30 AM Changeset in webkit [151735] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Prevent loss of tile buffers in BackingStorePrivate::render()
​https://bugs.webkit.org/show_bug.cgi?id=117799
​https://jira.bbqnx.net/browse/BRWSR-11712
JIRA413289

Patch by Jakob Petsovits <​jpetsovits@blackberry.com> on 2013-06-19
Reviewed by Carlos Garcia Campos.

Discovered by Xuefei Ren.

If, in rare cases, renderContents() returns false,
the for() loop in render() will take a tile buffer from
the surface pool but due to aborting the iteration early,
won't put it into the new tile map. In order to prevent
losing the buffer, we need to put it back into the
surface pool before continuing.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):

8:23 AM Changeset in webkit [151734] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Several tests crash due to an assert when creating an ImageBuffer
​https://bugs.webkit.org/show_bug.cgi?id=117793

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-06-19
Reviewed by Rob Buis.

JIRA 388741

Fixes a crash in several layout tests due to an assert when
creating an ImageBuffer with an empty size.

  • platform/graphics/blackberry/ImageBufferBlackBerry.cpp:

(WebCore::ImageBuffer::ImageBuffer): Return early if the given
size is empty.

8:03 AM Changeset in webkit [151733] by commit-queue@webkit.org
  • 4 edits in trunk

[GStreamer] [texmap] the bytesPerLine is wrong when updating the texture
​https://bugs.webkit.org/show_bug.cgi?id=117551

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2013-06-19
Reviewed by Philippe Normand.

Source/WebCore:

The bytesPerLine (or stride) is wrong when updating the texture
content. This is because the naturalSize() is not updated to the
current buffer. This patch extracts the current value of the size and
the stride.

No tests required.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):

LayoutTests:

  • platform/gtk-wk2/TestExpectations:

enabled media/video-display-aspect-ratio.html

7:23 AM Changeset in webkit [151732] by zarvai@inf.u-szeged.hu
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed rebaselining after 151705.

  • platform/qt/http/tests/cache/partitioned-cache-expected.txt: Added.
  • platform/qt/http/tests/cache/partitioned-cache-iframe-expected.txt: Added.
6:22 AM Changeset in webkit [151731] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Adjust internal size on gstreamer source element when receiving data if necessary
​https://bugs.webkit.org/show_bug.cgi?id=116534

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-06-19
Reviewed by Philippe Normand.

If the size received in didReceiveResponse is smaller than the actual size of the received data
update the internal size and the appsrc size to the proper value.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::didReceiveData):

6:10 AM Changeset in webkit [151730] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] TestExpectation sorting on Qt WK2.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-06-19
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/TestExpectations:
5:36 AM WebKitGTK/StartHacking edited by Andres Gomez
Added compiling section (diff)
5:12 AM WebKitGTK/SpeedUpBuild edited by Andres Gomez
(diff)
5:11 AM WebKitGTK/SpeedUpBuild edited by Andres Gomez
Indenting (diff)
5:05 AM WebKitGTK/SpeedUpBuild created by Andres Gomez
Initial editing
4:49 AM WebKitGTK/StartHacking edited by Andres Gomez
Added initial compiling section (diff)
4:29 AM WebKitGTK/StartHacking created by Andres Gomez
3:53 AM Changeset in webkit [151729] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Implement unit test callback: onSettingChange.
​https://bugs.webkit.org/show_bug.cgi?id=117728

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2013-06-19
Reviewed by Christophe Dumez.

It is finally possible to implement missing unit tests as WebKit2-EFL
has delivered sub menu (r150254).
Add two unit tests for checking onSettingChange callback behaviour,
when toggling "Check Spelling While Typing" in context menu.

Changed types inside callbacksExecutionStats struct from bit field to bool,
because casting from bit field to &bool is invalid (in using waitUntilTrue method).

  • UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:

(resetCallbacksExecutionStats):
(onSettingChange):
(findContextMenuItem):
Get determined option from context menu.

(checkCorrectnessOfSpellingItems):
Changed the name of onContextMenuShow method to be consistent with new methods.

(toogleCheckSpellingWhileTyping):
Select "Check Spelling While Typing" in context menu to test whether
onSettingChange is called.

3:30 AM WebKitGTK edited by Andres Gomez
Added newbies section (diff)
2:14 AM Changeset in webkit [151728] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GStreamer] Potential race condition when getting the video sink caps.
​https://bugs.webkit.org/show_bug.cgi?id=117736

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2013-06-19
Reviewed by Philippe Normand.

There is a potential race condition with the pad setting caps, as the
buffer and the caps won't match when renegotiation happens, and might
cause a crash.

This patch keeps an instance of the current caps in the video sink,
and it is accessible through a getter method. Hence the player can ask
for the current caps without running into a race condition.

No new tests. No change in behaviour.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
(WebCore::MediaPlayerPrivateGStreamerBase::currentVideoSinkCaps):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkGetProperty):
(webkitVideoSinkStop):
(webkitVideoSinkSetCaps):
(webkit_video_sink_class_init):

1:07 AM Changeset in webkit [151727] by kihong.kwon@samsung.com
  • 11 edits
    2 moves
    3 adds in trunk

Vibration can be canceled even if page visibility status is hidden
​https://bugs.webkit.org/show_bug.cgi?id=117333

Reviewed by Gyuyoung Kim.

Source/WebCore:

vibration can be canceled in the onvisibilitychange listener even if page visibility is changed to hidden status.
Therefore cancelVibration needs to work when page visibility is hidden.

Tests: vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html

  • Modules/vibration/NavigatorVibration.cpp:

(WebCore::NavigatorVibration::vibrate):

  • Modules/vibration/Vibration.h:

(WebCore::Vibration::isVibrating):

  • testing/Internals.cpp:

(WebCore::Internals::isVibrating):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Add a test case for cancel vibration after page visibility is changed to hidden status.
In addition, move navigator-vibration.html to vibration directory.

  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • vibration/cancelVibration-after-pagevisibility-changed-to-hidden-expected.txt: Added.
  • vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html: Added.
  • vibration/navigator-vibration-expected.txt: Renamed from LayoutTests/fast/dom/navigator-vibration-expected.txt.
  • vibration/navigator-vibration.html: Renamed from LayoutTests/fast/dom/navigator-vibration.html.
12:33 AM Changeset in webkit [151726] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK][SOUP] Migrate SoupRequestManager to GTask
​https://bugs.webkit.org/show_bug.cgi?id=117157

Reviewed by Gustavo Noronha Silva.

GSimpleAsyncResult has been deprecated in favour of GTask.

  • WebProcess/soup/WebKitSoupRequestGeneric.cpp:

(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):

  • WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::WebSoupRequestAsyncData::releaseTask):
(WebKit::WebSoupRequestManager::didHandleURIRequest):
(WebKit::WebSoupRequestManager::didFailURIRequest):
(WebKit::WebSoupRequestManager::send):
(WebKit::WebSoupRequestManager::finish):

  • WebProcess/soup/WebSoupRequestManager.h:
12:24 AM Changeset in webkit [151725] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Migrate WebKitFaviconDatabase to GTask
​https://bugs.webkit.org/show_bug.cgi?id=117156

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(processPendingIconsForPageURL):
(webkit_favicon_database_get_favicon):
(webkit_favicon_database_get_favicon_finish):

12:19 AM Changeset in webkit [151724] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Migrate WebKitWebView to GTask
​https://bugs.webkit.org/show_bug.cgi?id=117154

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(didValidateCommand):
(webkit_web_view_can_execute_editing_command):
(webkit_web_view_can_execute_editing_command_finish):
(webkitWebViewRunJavaScriptCallback):
(webkit_web_view_run_javascript):
(webkit_web_view_run_javascript_finish):
(resourcesStreamReadCallback):
(webkit_web_view_run_javascript_from_gresource):
(webkit_web_view_run_javascript_from_gresource_finish):
(fileReplaceContentsCallback):
(getContentsAsMHTMLDataCallback):
(webkit_web_view_save):
(webkit_web_view_save_finish):
(webkit_web_view_save_to_file):
(webkit_web_view_save_to_file_finish):
(webKitWebViewDidReceiveSnapshot):
(webkit_web_view_get_snapshot):
(webkit_web_view_get_snapshot_finish):

12:13 AM Changeset in webkit [151723] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Migrate WebKitCookieManager to GTask
​https://bugs.webkit.org/show_bug.cgi?id=117150

Reviewed by Gustavo Noronha Silva.

Don't use helper structs for async data since the cancellable is
now accessible from the GTask.

  • UIProcess/API/gtk/WebKitCookieManager.cpp:

(webkitCookieManagerGetAcceptPolicyCallback):
(webkit_cookie_manager_get_accept_policy):
(webkit_cookie_manager_get_accept_policy_finish):
(webkitCookieManagerGetDomainsWithCookiesCallback):
(webkit_cookie_manager_get_domains_with_cookies):
(webkit_cookie_manager_get_domains_with_cookies_finish):

Jun 18, 2013:

10:10 PM Changeset in webkit [151722] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

9:37 PM Changeset in webkit [151721] by gyuyoung.kim@samsung.com
  • 2 edits
    4 adds in trunk/LayoutTests

Unreviewed, EFL gardening. Added new baselines for some of editing/delete
tests after system upgrade.

  • platform/efl/TestExpectations:
  • platform/efl/editing/deleting/smart-delete-003-expected.png: Added.
  • platform/efl/editing/deleting/smart-delete-003-expected.txt: Added.
  • platform/efl/editing/deleting/smart-delete-004-expected.png: Added.
  • platform/efl/editing/deleting/smart-delete-004-expected.txt: Added.
9:31 PM Changeset in webkit [151720] by Lucas Forschler
  • 11 edits
    1 add in tags/Safari-537.46

Merge <rdar://problem/14171207>

9:11 PM Changeset in webkit [151719] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Input type range slider is not updated when min or max are changed
​https://bugs.webkit.org/show_bug.cgi?id=117778

Reviewed by Kent Tamura.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/089c7a0ba2d85b9b59632c2603fbc6472b310be1.

Test: fast/forms/range/range-change-min-max.html

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::minOrMaxAttributeChanged):

LayoutTests:

  • fast/forms/range/range-change-min-max-expected.html: Added.
  • fast/forms/range/range-change-min-max.html: Added.
8:37 PM Changeset in webkit [151718] by Lucas Forschler
  • 1 copy in tags/Safari-537.46

New Tag.

8:31 PM Changeset in webkit [151717] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove two superfluous overrides of supportsFocus
​https://bugs.webkit.org/show_bug.cgi?id=117770

Reviewed by Benjamin Poulain.

Merge ​https://chromium.googlesource.com/chromium/blink/+/4228964a63e3a889a40efce0d01866629fdcd9b9.

  • html/HTMLOptGroupElement.cpp:
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp:
  • html/HTMLOptionElement.h:
7:02 PM Changeset in webkit [151716] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] Media elements never fail to load
​https://bugs.webkit.org/show_bug.cgi?id=117767

Mark the media tests as failing for now.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-06-18

  • platform/mac-wk2/TestExpectations:
6:51 PM Changeset in webkit [151715] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Improve style of null checks in FrameView::setFrameRect
​https://bugs.webkit.org/show_bug.cgi?id=117681

Reviewed by Sam Weinig.

  • page/FrameView.cpp:

(WebCore::FrameView::setFrameRect): Used nested if statements and local variables
to tighten this code up a little.

6:45 PM Changeset in webkit [151714] by Christophe Dumez
  • 19 edits in trunk/Source/WebCore

Move IDL extended attributes to their correct location
​https://bugs.webkit.org/show_bug.cgi?id=117732

Reviewed by Kentaro Hara.

Move IDL extended attributes to their correct location according to the
latest Web IDL specification. We used to be inconsistent in the positioning
of the extended attributes. This simplifies a lot the code of the IDL parser
and makes our IDL files more standard.

Based on Blink r148345 by Kentaro Hara <​haraken@chromium.org>.

No new tests, no behavior change.

  • Modules/encryptedmedia/MediaKeyMessageEvent.idl:
  • Modules/notifications/Notification.idl:
  • Modules/speech/SpeechSynthesisVoice.idl:
  • bindings/scripts/IDLParser.pm:

(parseDefinitions):
(parseInterfaceMembers):
(parseInterfaceMember):
(parseDictionaryMembers):
(parseAttributeOrOperationOrIterator):
(parseAttribute):

  • css/CSSFontFaceLoadEvent.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLSourceElement.idl:
  • page/DOMWindow.idl:
  • svg/SVGElementInstance.idl:
  • svg/SVGScriptElement.idl:
  • testing/TypeConversions.idl:
6:32 PM Changeset in webkit [151713] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Let the script to update the Localizable.strings file do the reordering it wants to do.

Rubber-stamped by Anders Carlsson.

  • English.lproj/Localizable.strings:
6:15 PM Changeset in webkit [151712] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[Windows] Unreviewed gardening -- show missing AccessibilityNodeObject source
files in Visual Studio.

  • WebCore.vcxproj/WebCore.vcxproj: Add missing files.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
6:12 PM Changeset in webkit [151711] by achristensen@apple.com
  • 2 edits
    1 add in trunk/Tools

Working on coverage script, added xml to json data extraction script.
​https://bugs.webkit.org/show_bug.cgi?id=117648

This is part of a new test code coverage analysis tool. This compiles WebKit to generate
coverage data, runs the tests, and collects all of the data in json format.

Reviewed by Stephanie Lewis.

  • Scripts/generate-coverage-data:

(parseGcovrOutput):
(getFileHitsAndBranches):
(addLineCounts):
(createResultName):

  • Scripts/webkitpy/tool/gcovr: Added.
5:51 PM Changeset in webkit [151710] by ryuan.choi@samsung.com
  • 3 edits in trunk/Tools

Unreviewed build fix after r151699.

  • TestWebKitAPI/CMakeLists.txt:
  • WebKitTestRunner/CMakeLists.txt:

Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h

5:36 PM Changeset in webkit [151709] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Going to google.com/trends causes a crash
​https://bugs.webkit.org/show_bug.cgi?id=117602

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

When handling op_throw, etc we need to flush the variables and arguments
for the entire inline stack, not just the top frame.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flushAllArgumentsAndCapturedVariablesInInlineStack):
(JSC::DFG::ByteCodeParser::parseBlock):

LayoutTests:

Make sure we correctly initialise the appropriate argument registers,
and make sure we perform the tearoff correctly.

  • fast/js/inline-arguments-tear-off-expected.txt: Added.
  • fast/js/inline-arguments-tear-off.html: Added.
  • fast/js/script-tests/inline-arguments-tear-off.js: Added.

(g):
(f):
(doStuff):

5:12 PM Changeset in webkit [151708] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix a typo that may be causing some test failures.

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):

4:39 PM Changeset in webkit [151707] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r151513.
​http://trac.webkit.org/changeset/151513
​https://bugs.webkit.org/show_bug.cgi?id=117763

It causes assertions in debug (Requested by benjaminp on
#webkit).

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

4:16 PM Changeset in webkit [151706] by roger_fong@apple.com
  • 145 edits
    1 move in trunk

Replace tools32 folder with tools and update WebKit Windows solution accordingly.
<rdar://problem/14118143>.

Rubberstamped by Brent Fulgham.

3:50 PM Changeset in webkit [151705] by benjamin@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline after system update

Unreviewed.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-06-18

  • http/tests/cache/partitioned-cache-expected.txt:
  • http/tests/cache/partitioned-cache-iframe-expected.txt:

System fix, the tests pass.

3:44 PM Changeset in webkit [151704] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Infrequent uncaught exception with debugger popovers breaks inspector
​https://bugs.webkit.org/show_bug.cgi?id=117755

Create the ZERO_SIZE and ZERO_RECT objects after we've setup the Size
and Rect prototypes, so they get the expected methods. We then need to
handle the ZERO_RECT case better, and not attempt to draw a background
in a canvas with a 0 size, which would produce an exception.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-06-18
Reviewed by Timothy Hatcher.

  • UserInterface/Geometry.js:
  • UserInterface/Popover.js:

(WebInspector.Popover.prototype._update):

3:31 PM Changeset in webkit [151703] by zoltan@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Shapes] Remove lineOverflowsFromShapeInside boolean from RenderBlock::layoutRunsAndFloatsInRange function
​https://bugs.webkit.org/show_bug.cgi?id=117757

Reviewed by David Hyatt.

We don't need keep lineOverflowsFromShapeInside boolean in RenderBlock::layoutRunsAndFloatsInRange and in its
helpers because it's easy to decide whether we are in an shape content overflow state or not, so I got rid of
lineOverflowsFromShapeInside's occurences and updated the affected functions.

Covered by existing overflow tests in fast/exclusions/shape-inside and fast/regions/shape-inside.

  • rendering/RenderBlock.h: Update helper's definition.
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::pushShapeContentOverflowBelowTheContentBox): Add condition when overflow is already positioned.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Remove lineOverflowsFromShapeInside.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread): Remove lineOverflowsFromShapeInside.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Remove lineOverflowsFromShapeInside.

3:03 PM Changeset in webkit [151702] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

widthMediaFeatureEval ends up with null FrameView during iframe unload.
​https://bugs.webkit.org/show_bug.cgi?id=117754

Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-18
Reviewed by Geoffrey Garen.

Ensure that MediaQueryEvaluator checks against NULL FrameView.

While frames are being unloaded, the Frame object does not necessarily have valid
FrameView anymore. Layout on the main frame can end up querying media values on such child
frames, while detaching.

Source/WebCore:

Test: fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery.html

  • css/MediaQueryEvaluator.cpp:

(WebCore::orientationMediaFeatureEval):
(WebCore::aspect_ratioMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
(WebCore::MediaQueryEvaluator::eval):

LayoutTests:

  • fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery-expected.txt: Added.
  • fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery.html: Added.
  • fast/frames/resources/child-iframe-forces-parent-layout-on-unload.html: Added.
3:01 PM Changeset in webkit [151701] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Make it possible to set a minimum height for auto-layout
​https://bugs.webkit.org/show_bug.cgi?id=117758
<rdar://problem/12849080>

Reviewed by Tim Horton.

Change a bunch of minimumLayoutWidth declarations to minimumLayoutSize and add a new minimumLayoutSize property.
If minimumLayoutSize.height is greater than zero, use it to set the minimum layout size on the frame view.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _setIntrinsicContentSize:]):
(-[WKView minimumLayoutWidth]):
(-[WKView setMinimumLayoutWidth:]):
(-[WKView minimumWidthForAutoLayout]):
(-[WKView setMinimumWidthForAutoLayout:]):
(-[WKView minimumSizeForAutoLayout]):
(-[WKView setMinimumSizeForAutoLayout:]):

  • UIProcess/API/mac/WKViewPrivate.h:
  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::minimumLayoutSizeDidChange):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setMinimumLayoutSize):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::minimumLayoutSize):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::minimumLayoutSizeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
(WebKit::TiledCoreAnimationDrawingAreaProxy::intrinsicContentSizeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setMinimumLayoutSize):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::minimumLayoutSize):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):

2:53 PM Changeset in webkit [151700] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

sandbox violation when Flash runs for the first time
​https://bugs.webkit.org/show_bug.cgi?id=117753
<rdar://problem/14165466>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-18
Reviewed by Alexey Proskuryakov.

Allow flash to try and change the ownership of directories it has just created.

  • Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
2:39 PM Changeset in webkit [151699] by Beth Dakin
  • 11 edits
    1 add in trunk/Source

Expose a getMediaType method in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=117667

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-06-18
Reviewed by Brady Eidson.

Source/WebCore:

  • WebCore.exp.in: Updated to add a symbol for

HitTestResult::mediaIsVideo method
and alphabetize the list of exposed methods.

Source/WebKit2:

  • GNUmakefile.list.am:
  • Target.pri:

Updated to include the added header file InjectedBundleHitTestResultMediaType.h

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toBundleHitTestResultMediaType):
(WebKit::toAPI):
Added methods to convert between BundleHitTestResultMediaType
and WKBundleHitTestResultMediaType.

  • WebKit2.xcodeproj/project.pbxproj: Updated to include

InjectedBundleHitTestResultMediaType.h in the WebKit2 project.

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultGetMediaType): Exposes the method getMediaType and
hooks into InjectedBundleHitTestResult::getMediaType.

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::getMediaType): Added to return
what type, if any, a media element is.

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResultMediaType.h: Added

to contain new BundleHitTestResultMediaType enums.

2:34 PM Changeset in webkit [151698] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused bool argument from ReplacementFragment's constructor
​https://bugs.webkit.org/show_bug.cgi?id=117752

Reviewed by Antti Koivisto.

Merge ​https://chromium.googlesource.com/chromium/blink/+/265586d9f154a9dff657511d09926429b8e1b53d.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplaceSelectionCommand::doApply):

2:29 PM Changeset in webkit [151697] by eric.carlson@apple.com
  • 13 edits in trunk

Not all subtitle tracks are SDH
​https://bugs.webkit.org/show_bug.cgi?id=117738

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, existing tests updated.

  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::isSDH): New.

  • html/track/InbandTextTrack.h: Add isSDH override.
  • html/track/TextTrack.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::trackDisplayName): Only add "SDH" label if a track claims to be SDH.

  • platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::isSDH): New.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::isSDH): Return true if track has both "transcribes

spoken dialog for accessibility" and "describes music and sound for accessibility"
characteristics.

LayoutTests:

  • media/video-controls-captions-trackmenu-localized.html:
  • media/video-controls-captions-trackmenu-sorted.html:
  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
  • platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
2:25 PM Changeset in webkit [151696] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Simplify FormKeyGenerator::willDeleteForm
​https://bugs.webkit.org/show_bug.cgi?id=117751

Reviewed by Antti Koivisto.

Merge ​https://chromium.googlesource.com/chromium/blink/+/c6399efb9da863eb1d1fc98b17ef925998b985ac

  • html/FormController.cpp:

(WebCore::FormKeyGenerator::willDeleteForm):

2:25 PM Changeset in webkit [151695] by rniwa@webkit.org
  • 3 edits
    1 add in trunk

REGRESSION(r147602): Search text field doesn't render selection when it has some :focus rules
​https://bugs.webkit.org/show_bug.cgi?id=117747

Reviewed by Kent Tamura.

.:

  • ManualTests/search-select-all-with-focus-style.html: Added.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/7ff656c8239ce3b125246abcc8b149a603fcff28

r147612 added setNeedsLayout(true, MarkOnlyThis) for
TextControlInnerTextElement renderer. It's ok for input[type=text]
because RenderTextControlSingleLine also has needsLayout flag, and it
has only the inner text renderer as a child.

As for input[type=search], it doesn't work. Renderer structure for
input[type=search] is:

RenderTextControlSingleLine
└Renderer for TextControlInnerContainer

└Renderer for TextControlInnerElement

└Renderer for TextControlInnerTextElement

After r147612, there is a case that only RenderTextControlSingleLine
and TextControlInnerTextElement renderer have needsLayout flag, and
others don't. It won't trigger layout for
TextControlInnerTextElement renderer.

We should set needsLayout flags of TextControlInnerContainer renderer
and TextControlInnerElement renderer by MarkContainingBlockChain.

Manual Tests: search-select-all-with-focus-style.html
(I tried but couldn't make a test that works in DRT)

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::styleDidChange):

1:40 PM Changeset in webkit [151694] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted build fix for non-Mac.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::nonSyntheticItalicFontData):

1:28 PM Changeset in webkit [151693] by dino@apple.com
  • 10 edits
    5 adds in trunk

Synthesized vertical italics on rotated glyphs are transformed incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=117726

Reviewed by Enrica Casucci.

Source/WebCore:

If a font does not have italic glyphs, and is in a vertical flow, then
the synthesis of italics was skewing in the wrong direction. While here,
ensure that no CJK text will get italics in vertical layout.

This is a topic under discussion in the CSS Working Group. The resolution
at the June 2013 face-to-face was that:

  • italics in Japanese (and Chinese) text are rare in vertical layout
  • most people wanted Latin text to italicize in the direction of the line flow

The final behaviour was left undefined, but we consider the change here
to be sufficient for now. In all cases, the best solution is to avoid
synthesized italics by specifying a font that includes such forms.

Tests: fast/text/international/synthesized-italic-vertical-latin.html

fast/text/international/synthesized-italic-vertical.html

  • platform/graphics/FontGlyphs.cpp:

(WebCore::glyphDataAndPageForCJKCharacterWithoutSyntheticItalic): New function

that makes a new glyph data pair that is marked as NOT using a synthesized italic.

(WebCore::FontGlyphs::glyphDataAndPageForCharacter): If this is a CJK character and

has a synthesized oblique, then run it through the function above to make a new glyph data pair.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::nonSyntheticItalicFontData): Creates/returns a new SimpleFontData that will

not synthesize italics.

  • platform/graphics/SimpleFontData.h: New method nonSyntheticItalicFontData.
  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs): This is the actual bug fix. If you are in a vertical flow, the

skew direction should be downwards, not leftwards.

LayoutTests:

Two new tests. One ensures that CJK characters do not get italics
when vertical. The other ensures that Latin text does get italics in
a font that is not synthesized, but unfortunately has to be a pixel test.
The latter is skipped on non-Mac since they don't support
synthesized obliques in FontPlatformData.

  • fast/text/international/synthesized-italic-vertical-expected.html: Added.
  • fast/text/international/synthesized-italic-vertical-latin.html: Added.
  • fast/text/international/synthesized-italic-vertical.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Added.
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
1:28 PM Changeset in webkit [151692] by roger_fong@apple.com
  • 4 edits in trunk/Source/WebKit

Unreviewed. Build fix for Mac and Win

1:14 PM Changeset in webkit [151691] by roger_fong@apple.com
  • 3 edits
    6 adds in trunk/Source

Re-implement WebFrameNetworkingContext.
<rdar://problem/13174821>.

Reviewed by Alexey Proskuryakov.

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h: Added.

(WebKit::WebFrameNetworkingContext::create):
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: Added.

(WebKit::WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebKit::WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebKit::WebFrameNetworkingContext::sourceApplicationAuditData):
(WebKit::WebFrameNetworkingContext::blockedError):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebCoreSupport/WebFrameNetworkingContext.h: Added.

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebFrameNetworkingContext::userAgent):

  • WebCoreSupport/WebFrameNetworkingContext.mm: Added.

(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebFrameNetworkingContext::sourceApplicationAuditData):
(WebFrameNetworkingContext::blockedError):
(WebFrameNetworkingContext::storageSession):

1:05 PM Changeset in webkit [151690] by ap@apple.com
  • 3 edits
    6 deletes in trunk/Source

<rdar://problem/13174821> Remove files with an incorrect license.

Rubber-stamped by Maciej Stachowiak.

This will break the build, stay tuned for a fix coming soon.

12:58 PM Changeset in webkit [151689] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WTF

PackedIntVector: check template arguments at compile time
​https://bugs.webkit.org/show_bug.cgi?id=117737

Use 'COMPILE_ASSERT' instead of 'ASSERT' in PackedIntVector class
constructor.

Reviewed by Sam Weinig.

  • wtf/PackedIntVector.h:

(WTF::PackedIntVector::PackedIntVector):

12:38 PM Changeset in webkit [151688] by timothy@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

If the tree outline is processing a selection currently, then don't change the selection.

This is needed to allow breakpoints tree elements to be selected without jumping back to
selecting the resource tree element.

​https://bugs.webkit.org/show_bug.cgi?id=117746

Reviewed by Joseph Pecoraro.

  • UserInterface/Main.js:

(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):

  • UserInterface/TreeOutline.js:

(TreeElement.prototype.select):

11:49 AM Changeset in webkit [151687] by timothy@apple.com
  • 14 edits
    1 add in trunk/Source/WebInspectorUI

Update breakpoints to match Xcode 5.

This updates the breakpoint images, line colors, and moves breakpoints toggle button
to the Debugger sidebar navigation bar.

​https://bugs.webkit.org/show_bug.cgi?id=117723

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js: Updated.
  • UserInterface/DebuggerSidebarPanel.css: Removed custom toggle button rules.
  • UserInterface/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._breakpointsToggleButtonClicked):

  • UserInterface/Images/Breakpoint.png: Updated.
  • UserInterface/Images/Breakpoints.pdf: Added.
  • UserInterface/Images/Breakpoint@2x.png: Updated.
  • UserInterface/Images/BreakpointButton.pdf: Updated.
  • UserInterface/Images/BreakpointInactive.png: Updated.
  • UserInterface/Images/BreakpointInactive@2x.png: Updated.
  • UserInterface/Images/BreakpointInactiveButton.pdf: Updated.
  • UserInterface/Images/InstructionPointer.png: Updated.
  • UserInterface/Images/InstructionPointer@2x.png: Updated.
  • UserInterface/SourceCodeTextEditor.css:

(.source-code.text-editor > .CodeMirror .error): Updated background-color and removed box-shadow.
(.source-code.text-editor > .CodeMirror .warning): Ditto.

  • UserInterface/TextEditor.css:

(.text-editor > .CodeMirror .has-breakpoint .CodeMirror-linenumber::before): Changed left position to 0.
(.text-editor > .CodeMirror .execution-line .CodeMirror-linenumber::after): Updated position.
(.text-editor > .CodeMirror .execution-line): Updated background-color and removed box-shadow.

10:51 AM Changeset in webkit [151686] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

The page title of technical-articles.html is incorrect.
​https://bugs.webkit.org/show_bug.cgi?id=117727

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-06-18
Reviewed by Ryosuke Niwa.

Changed the page title of technical-articles.html to "WebKit Technical Articles".

  • coding/technical-articles.html:
10:38 AM Changeset in webkit [151685] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r151549.
​http://trac.webkit.org/changeset/151549
​https://bugs.webkit.org/show_bug.cgi?id=117741

broke selection in the web inspector source after scrolling
(Requested by smfr on #webkit).

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderLayerModelObject.cpp:
  • rendering/RenderLayerModelObject.h:

LayoutTests:

  • fast/repaint/change-overflow-and-display-of-relative-expected.txt: Removed.
  • fast/repaint/change-overflow-and-display-of-relative.html: Removed.
9:09 AM BuildingGtk edited by Manuel Rego Casasnovas
Add link to WebKitGTK+ main page in trac.webkit.org (diff)
8:16 AM Changeset in webkit [151684] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

<video> element delays document load event for ~ 3 seconds
​https://bugs.webkit.org/show_bug.cgi?id=90272

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-06-18
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-preload-no-delay-loadevent.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareForLoad):
No need to delay document load event here when preload="none"

LayoutTests:

  • media/media-preload-no-delay-loadevent-expected.txt: Added.
  • media/media-preload-no-delay-loadevent.html: Added.
6:16 AM Changeset in webkit [151683] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.1.2

Tagging the WebKitGTK+ 2.1.2 release

6:04 AM Changeset in webkit [151682] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Remove comment about possibility of handling ObjCPolymorphic (it's used by ObjC bindings only)
​https://bugs.webkit.org/show_bug.cgi?id=117546

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2013-06-18
Reviewed by Xan Lopez.

According to the WebKit IDL spec the modifier ObjCPolymorphic only
applies to the Objective-C bindings generator

  • bindings/scripts/CodeGeneratorGObject.pm:

(IsPolymorphic): Remove comment. Search parameter 'type' in array, instead of
concatening a series of 'or' conditionals.

5:24 AM Changeset in webkit [151681] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix after r151673
​https://bugs.webkit.org/show_bug.cgi?id=116042

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

Removed a spurious semicolon in the video sink caps definition.

No new tests, no behavior change.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
4:23 AM Changeset in webkit [151680] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WebSpeech] Speech Recognition requires convertValue support in JSDictionary
​https://bugs.webkit.org/show_bug.cgi?id=117731

Patch by Praveen R Jadhav <​praveen.j@samsung.com> on 2013-06-18
Reviewed by Christophe Dumez.

Build fails after enabling ENABLE_SCRIPTED_SPEECH feature. This patch
resolves the issue.

No new tests. No change in behaviour.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h:
3:30 AM Changeset in webkit [151679] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and Versions.m4 for 2.1.2 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 2.1.2.
2:35 AM Changeset in webkit [151678] by zarvai@inf.u-szeged.hu
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaseline and skipping some tests.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-06-18

  • platform/qt-5.0-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.png: Added.
  • platform/qt/TestExpectations:
  • platform/qt/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
2:13 AM Changeset in webkit [151677] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] only notify download client when download error
​https://bugs.webkit.org/show_bug.cgi?id=117687

Reviewed by Rob Buis.

When met network error in downloading, we notify the error to download
client through download stream, we shouldn't notify page client the error.
RIM JIRA 419985

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::shouldNotifyClientFailed):

1:35 AM Changeset in webkit [151676] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

Shader compiler not properly configured for GLES on cairo based ports
​https://bugs.webkit.org/show_bug.cgi?id=117705

Reviewed by Martin Robinson.

Configure the shader compiler with SH_ESSL_OUTPUT for GLESv2
compliant platforms, and with SH_GLSL_OUTPUT otherwise.

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

1:29 AM Changeset in webkit [151675] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

touching any idl rebuilds all derived sources
​https://bugs.webkit.org/show_bug.cgi?id=117708

Reviewed by Kentaro Hara.

Fix preprocess-idls.pl script to update the following files only
if they have changed:
DerivedSources/WebCore/supplemental_dependency.tmp
DerivedSources/WebCore/DOMWindowConstructors.idl
DerivedSources/WebCore/WorkerContextConstructors.idl

This avoids triggering uselessly bindings generation for all IDL
files whenever an IDL file is touched.

No new tests, no behavior change.

  • bindings/scripts/preprocess-idls.pl:

(WriteFileIfChanged):
(GeneratePartialInterface):

1:18 AM Changeset in webkit [151674] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK][GStreamer] Fullscreen option in video element context menu not working
​https://bugs.webkit.org/show_bug.cgi?id=105191

.:

Fullscreen with native controls is outdated and even broken in
[GTK][WK2], so they are deactivated for now.

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

  • Source/autotools/SetupAutoconfHeader.m4: Removed the use of

fullscreen native media controls.

LayoutTests:

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

  • platform/gtk-wk1/TestExpectations:

fullscreen/video-controls-drag.html does not time out anymore.

  • platform/gtk-wk2/TestExpectations:

media/video-display-aspect-ratio.html crashes sometimes.

  • platform/gtk/TestExpectations:

media/video-playing-and-pause.html was already flaky.

1:09 AM Changeset in webkit [151673] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer] [texmap] upload a video buffer into the video texture
​https://bugs.webkit.org/show_bug.cgi?id=116042

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

This patch prepares more quickly the texture when the video frame is
already in the GPU memory.

It is done using a new buffer's metadata available in GStreamer 1.2,
and its purpose is to upload buffers into a OpenGL texture.

If the decoder provides buffers with this metadata, the buffer will be
uploaded into the texture used for the video display and it will be
rendered, avoiding a expensive mem copies. This is particularly useful
for Full HD videos, where all the processing and display will be done
in the GPU.

No new tests, covered by existing tests.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkProposeAllocation):

12:20 AM Changeset in webkit [151672] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Mark two tests that are flakily timing out as slow.
12:02 AM Changeset in webkit [151671] by aestes@apple.com
  • 2 edits in trunk/Source/WTF

A static_assert() in RetainPtr.h sometimes causes the build to fail.

Wrap the first argument to a static_assert() in parentheses since it
contains a comma, which sometimes tricks the preprocessor into thinking
the macro is being passed three arguments rather than two.

Reviewed by Brian Weinstein.

  • wtf/RetainPtr.h:

(WTF::RetainPtr::RetainPtr):

12:00 AM Changeset in webkit [151670] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

REGRESSION (r149184): Build errors in RefPtr.h when building with Clang, C++98 standard
​https://bugs.webkit.org/show_bug.cgi?id=116352

Reviewed by Anders Carlsson.

Use the has_feature macro instead of the has_extension one when detecting what features the Clang compiler
that's being used is capable to provide. With the project moving onto using C++11 throughout its components,
there currently exist cases where C++11-specific functionality (for instance std::move) is used despite being
guarded by compiler-specific feature guards that still get enabled even when compiling in C++98 with Clang.
The problematic features are enabled because they're available as C++98 language extensions by Clang.

Using has_feature instead enables the feature guard only if the tested feature is actually standardized in
the currently used language standard.

  • wtf/Compiler.h:
Note: See TracTimeline for information about the timeline view.