Timeline
Jul 2, 2013:
- 10:54 PM Changeset in webkit [152340] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination/closure
https://bugs.webkit.org/show_bug.cgi?id=118280
Reviewed by Darin Adler.
Invalidate the FontCache before disabling and purging the MemoryCache in WebProcess::didClose
and WebProcess::terminate. This frees up additional references to objects that were held
by the FontCache, reducing the amount of 'LEAK: *' output when exiting MiniBrowser or
WebKitTestRunner in debug builds.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didClose):
- 10:30 PM Changeset in webkit [152339] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG::Node::m_opInfo2 should also be a uintptr_t
https://bugs.webkit.org/show_bug.cgi?id=118340
Reviewed by Sam Weinig.
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
- 10:21 PM Changeset in webkit [152338] by
-
- 6 edits in branches/dfgFourthTier/Source
Unreviewed, fix 32-bit build.
Source/JavaScriptCore:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::comparePtr):
(MacroAssembler):
- dfg/DFGBinarySwitch.cpp:
(JSC::DFG::BinarySwitch::advance):
- dfg/DFGBinarySwitch.h:
(JSC::DFG::BinarySwitch::caseValue):
Source/WTF:
- wtf/Platform.h:
- 10:07 PM Changeset in webkit [152337] by
-
- 2 edits in trunk/Source/WebCore
Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
https://bugs.webkit.org/show_bug.cgi?id=118299
Reviewed by Andreas Kling.
Did cleanups.
- dom/QualifiedName.cpp:
(WebCore::qualifiedNameCache): Added to wrap gNameCache.
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::QualifiedNameImpl::~QualifiedNameImpl):
(WebCore::QualifiedName::toString): Use early exit and StringBuilder.
(WebCore::QualifiedName::init): Use early exit.
- 8:45 PM Changeset in webkit [152336] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Have fewer Arrayify's
https://bugs.webkit.org/show_bug.cgi?id=118335
Reviewed by Mark Hahnenberg.
A lot of Arrayify's arise because some program saw Int32 arrays early on in
execution, but then they all got converted to Double arrays and the program
will never see Int32 arrays ever again. Prior to this change you would always
have an Arrayify in this case. But with this change, the first time that an
ArrayProfile is about to go polymorphic in computeUpdatedPrediction(), it
instead forcibly monomorphises itself to the latest-seen structure.
Thereafter it will never again perform this monomorphisation. This is
controlled by ArrayProfile::m_didPerformFirstRunPruning. This is a 5%
speed-up on Kraken/imaging-gaussian-blur with the FTL enabled, and it
unblocks a bunch of stuff we want to do in the future because it makes a
bunch of loops effect-free.
We will still want to implement Arrayify hoisting in the future, but this is
great anyway because it's better to not have Arrayifications than it is to
have hoisted Arrayifications.
- bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::computeUpdatedPrediction):
(JSC::ArrayProfile::briefDescription):
(JSC):
(JSC::ArrayProfile::briefDescriptionWithoutUpdating):
- bytecode/ArrayProfile.h:
(JSC::ArrayProfile::ArrayProfile):
(ArrayProfile):
- 8:19 PM Changeset in webkit [152335] by
-
- 2 edits in trunk/Source/WebCore
Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
https://bugs.webkit.org/show_bug.cgi?id=118337
Reviewed by Benjamin Poulain.
-webkit-overflow-scrolling: touch is an inherited property that, on iOS, controls
the behavior of overflow scrolling content, and causes overflow scrolling elements
to become CSS stacking contexts.
However, the code was too aggressive in setting style->setZIndex(0), doing so
for any element with overflow != hidden. Since the default for overflow is visible,
that meant almost every element.
Previously, this didn't really matter. However, since r125693, any renderer with non-auto
z-index gets a RenderLayer, and that RenderLayer will become a stacking context. The result
was too many RenderLayers and incorrect stacking context behavior.
Fix by ensuring that -webkit-overflow-scrolling: touch only affects elements which
are actually scrollable.
Also move the code that does this to below the code that adjust overflow style
for different elements.
- css/StyleResolver.cpp:
(WebCore::isScrollableOverflow):
(WebCore::StyleResolver::adjustRenderStyle):
- 7:45 PM Changeset in webkit [152334] by
-
- 2 edits in trunk/Tools
- 5:48 PM Changeset in webkit [152333] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r152318.
http://trac.webkit.org/changeset/152318
https://bugs.webkit.org/show_bug.cgi?id=118333
This patch broke media/track/track-automatic-subtitles.html on
Mac (Requested by dfarler on #webkit).
Source/WebCore:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore):
LayoutTests:
- media/track/track-legacyapi-with-automatic-mode-expected.txt: Removed.
- media/track/track-legacyapi-with-automatic-mode.html: Removed.
- 5:39 PM Changeset in webkit [152332] by
-
- 11 edits in branches/safari-537-branch/Source
Merged r152328. <rdar://problem/14320278>
- 5:32 PM Changeset in webkit [152331] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself to contributors.json.
- Scripts/webkitpy/common/config/contributors.json:
- 5:20 PM Changeset in webkit [152330] by
-
- 3 edits2 adds in trunk
Change event should not be dispatched by clicking a scrollbar of select listbox
https://bugs.webkit.org/show_bug.cgi?id=118019
<rdar://problem/14297760>
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-02
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/forms/select/listbox-click-on-scrollbar.html
Merge the following:
http://src.chromium.org/viewvc/blink?view=revision&revision=151689
https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f
Previously, a select element with the multiple attribute would dispatch
an onChanged event when the scrollbar is clicked. This patch corrects this
issue by only calling listBoxOnChange(), which fires the onChanged event,
when an actual option is clicked.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childrenChanged): Updated to clear the list
of selected items when when an <option> element is added to/deleted from its <select> element.
(Without this addition, if a option was selected, and then JavaScript was used to modify
the <select> element, and then the scrollbar was clicked, an onChanged event would fire
because it remembers the previously selected option.)
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updated to
only call listBoxOnChange() if at least one option is selected.
LayoutTests:
Merge the following:
http://src.chromium.org/viewvc/blink?view=revision&revision=151689
https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f
- fast/forms/select/listbox-click-on-scrollbar-expected.txt: Added.
- fast/forms/select/listbox-click-on-scrollbar.html: Added.
Tests that an onChange() event is not fired when the scrollbar of a
<select multiple> element is clicked.
- 5:18 PM Changeset in webkit [152329] by
-
- 3 edits in trunk/Source/WebCore
Preparing Windows WebGL build system.
https://bugs.webkit.org/show_bug.cgi?id=118325
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj: Added EGL files, removed unused GraphicsContext3DOpenGL.cpp.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added EGL filter and files, removed unused GraphicsContext3DOpenGL.cpp.
- 5:06 PM Changeset in webkit [152328] by
-
- 11 edits in trunk/Source
The callback for WKPageGetPlugInInformation needs info about whether or not there are any
non-playing instances of the plug-in on the page
https://bugs.webkit.org/show_bug.cgi?id=118330
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.exp.in:
Expose a symbol so it can be used in WebKit2.
Source/WebKit2:
Add another key value pair to the dictionary passed to the callback.
- Shared/API/c/WKPluginInformation.cpp:
(WKPlugInInformationPageContainsNonPlayingInstanceOfPlugInKey):
- Shared/API/c/WKPluginInformation.h:
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::plugInInformationPageContainsNonPlayingInstanceOfPlugInKey):
(WebKit::createPlugInInformationDictionary):
Add the information about whether or not the page contains a non-playing instance of that
plug-in to the plug-in information dictionary.
- Shared/Plugins/Netscape/PluginInformation.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::containsPlugInCallback):
Check if any of the MIME types of the plug-in instances that are present on the page but are
not playing match the instance of plug-in being searched for.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::addPlugInMimeTypesFromNodeListForNonPlayingPlugIns):
Based roughly off of addPlugInsFromNodeListMatchingPlugInOrigin in
HTMLPlugInImageElement.cpp.
(WebKit::WebPage::containsPluginViewsWithPluginProcessToken):
Based roughly off of HTMLPlugInImageElement::restartSimilarPlugIns.
- 4:04 PM Changeset in webkit [152327] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Merged r152288. <rdar://problem/14338353>
- 3:54 PM Changeset in webkit [152326] by
-
- 5 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: add option to disable OSR entry in loops
https://bugs.webkit.org/show_bug.cgi?id=118329
Reviewed by Mark Hahnenberg.
This adds that option, and also makes the OSR exit reoptimization trigger rely less on
OSR entry failing. Now even if we never attempt OSR entry but our execution counter gets
high after a small number of OSR exits, we will recompile.
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
- dfg/DFGOperations.cpp:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
- runtime/Options.h:
(JSC):
- 3:18 PM Changeset in webkit [152325] by
-
- 2 edits in trunk/Source/WebCore
Added getProcAddress implementation for Windows in OpenGLShims.
https://bugs.webkit.org/show_bug.cgi?id=118312
Reviewed by Brent Fulgham.
- platform/graphics/OpenGLShims.cpp:
(WebCore::getProcAddress): Added for Windows.
- 3:12 PM Changeset in webkit [152324] by
-
- 2 edits in trunk/Source/WebCore
media/unsupported-rtsp.html is failing
https://bugs.webkit.org/show_bug.cgi?id=118327
Reviewed by Eric Carlson.
Fixes the media/unsupported-rtsp.html test.
Set the contentType field of contentInformationRequest in order to trigger AVFoundation to
notice that loading failed and generate an error.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::notifyFinished):
- 2:58 PM Changeset in webkit [152323] by
-
- 2 edits in trunk/Source/WebCore
Fixed compile error in non-X11 platforms using EGL.
https://bugs.webkit.org/show_bug.cgi?id=118323
Reviewed by Brent Fulgham.
- platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::createPixmapContext): Put all X11-specific code into #if PLATFORM(X11).
- 2:45 PM Changeset in webkit [152322] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed rebaseline of media/video-controls-captions-trackmenu-localized after r151697.
- platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt: Removed.
"Unknown SDH" -> "Unknown".
- 2:24 PM Changeset in webkit [152321] by
-
- 2 edits in trunk/LayoutTests
Unreviewed rebaseline of Mac Lion fast/js/global-constructors-attributes after r151914.
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
WaveTable -> PeriodicWave
- 1:43 PM Changeset in webkit [152320] by
-
- 22 edits in trunk
[CSS Regions] Improve implementation of elements in region being flowed to another flow thread
https://bugs.webkit.org/show_bug.cgi?id=118300
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-02
Reviewed by David Hyatt.
Source/WebCore:
Methods that must be const have been turned back into const. Code has been better organized.
Performance is better. Tests have been added to.
- dom/Element.cpp:
(WebCore::Element::detach):
(WebCore::Element::setIsInsideRegion):
(WebCore::Element::isInsideRegion):
(WebCore::Element::shouldMoveToFlowThread):
- dom/Element.h:
- dom/ElementRareData.h:
(WebCore::ElementRareData::isInsideRegion):
(WebCore::ElementRareData::setIsInsideRegion):
(WebCore::ElementRareData::ElementRareData):
- dom/Node.cpp:
(WebCore::Node::isRegisteredWithNamedFlow):
- dom/Node.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
- dom/NodeRenderingContext.h:
- dom/PseudoElement.h:
- dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
- dom/Text.h:
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):
- rendering/FlowThreadController.h:
- rendering/RenderObject.h:
- rendering/RenderRegion.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::shouldMoveToFlowThread):
- svg/SVGElement.h:
LayoutTests:
- fast/regions/flow-body-in-html.html:
- fast/regions/region-content-flown-into-region-expected.html:
- fast/regions/region-content-flown-into-region.html:
- fast/regions/universal-selector-children-to-the-same-region.html:
- 1:30 PM Changeset in webkit [152319] by
-
- 2 edits in trunk/LayoutTests
Skip cache partitioning tests on Lion.
Rubber stamped by Jeffrey Pfau.
- platform/mac-lion/TestExpectations:
http/tests/cache/partitioned-cache.html
http/tests/cache/partitioned-cache-iframe.html
- 1:28 PM Changeset in webkit [152318] by
-
- 3 edits2 adds in trunk
[Mac] .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
https://bugs.webkit.org/show_bug.cgi?id=118319
Reviewed by Darin Adler.
Source/WebCore:
Test: media/track/track-legacyapi-with-automatic-mode.html
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Don't apply "automatic"
logic when captions were enabled with .webkitClosedCaptionsVisible.
LayoutTests:
- media/track/track-legacyapi-with-automatic-mode-expected.txt: Added.
- media/track/track-legacyapi-with-automatic-mode.html: Added.
- 1:07 PM Changeset in webkit [152317] by
-
- 2 edits in trunk/Source/WebKit2
security/block-test.html fails when NetworkProcess is enabled
https://bugs.webkit.org/show_bug.cgi?id=118320
<rdar://problem/14309423>
Reviewed by Geoff Garen.
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::wasBlocked): (WebKit::NetworkResourceLoader::cannotShowURL): Implemented missing ResourceHandleClient functions.
- 12:51 PM Changeset in webkit [152316] by
-
- 2 edits in trunk/Source/WebKit2
Fix crash when PageBanner::detachFromPage() is called from WebPage::~WebPage().
https://bugs.webkit.org/show_bug.cgi?id=118268
Reviewed by Beth Dakin.
- WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::detachFromPage): Add some null checks. m_webPage->corePage()
can be null if this method is called after the web page is closed.
- 12:50 PM Changeset in webkit [152315] by
-
- 2 edits in trunk/Source/WebCore
Always flip the coordinate system before drawing NSViews from Widget::paint
https://bugs.webkit.org/show_bug.cgi?id=118318
<rdar://problem/13895483>
Reviewed by Beth Dakin.
Undo the change that would not flip on 10.9; turns out the bug was in AppKit. Also remove the
_hasCanDrawSubviewsIntoLayerOrAncestor workaround since drawing works correctly now.
Also, pass flipped:NO when creating the NSGraphicsContext to indicate that the graphics context
is unflipped as far as AppKit knows (since we flipped it earlier).
- platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
- 12:47 PM Changeset in webkit [152314] by
-
- 2 edits in trunk/Source/JavaScriptCore
Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
https://bugs.webkit.org/show_bug.cgi?id=118316
Reviewed by Geoffrey Garen.
This is causing some crashiness in release builds. We should replace it with an ASSERT
until we track down all the places that need fixing in bug 118315.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):
- 12:30 PM Changeset in webkit [152313] by
-
- 3 edits2 adds in trunk
empty inlines should not affect line-wrapping
https://bugs.webkit.org/show_bug.cgi?id=25638
Reviewed by David Hyatt.
Source/WebCore:
Don't break on empty inlines if we're in the middle of a word. I took this opportunity to
refactor the series of checks we perform to establish if we can break at the current position.
Test: fast/text/whitespace/inline-whitespace-wrapping-11.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::textBeginsWithBreakablePosition):
(WebCore::canBreakAtThisPosition):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/text/whitespace/inline-whitespace-wrapping-11-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-11.html: Added.
- 12:30 PM Changeset in webkit [152312] by
-
- 1 copy in tags/Safari-537.48
New Tag.
- 12:29 PM Changeset in webkit [152311] by
-
- 1 delete in tags/Safari-537.48
Remove Tag.
- 12:27 PM Changeset in webkit [152310] by
-
- 6 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152199. <rdar://problem/14287209>
- 12:24 PM Changeset in webkit [152309] by
-
- 13 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152141. <rdar://problem/14283900>
- 12:21 PM Changeset in webkit [152308] by
-
- 6 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152136. <rdar://problem/13899156>
- 12:17 PM Changeset in webkit [152307] by
-
- 6 edits2 copies in trunk/Source
Implement CoordinatedSurface for Threaded Coordinated Graphics
https://bugs.webkit.org/show_bug.cgi?id=109661
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-02
Reviewed by Noam Rosenthal.
This is a preparation patch for Threaded Coordianted Graphics.
This patch implements ThreadSafeCoordinatedSurface using ImageBuffer as a
backend. Also, this patch moves common implementation to CoordinatedSurface to
prevent duplication of code.
Source/WebCore:
- platform/graphics/texmap/coordinated/CoordinatedSurface.cpp:
(WebCore::CoordinatedSurface::CoordinatedSurface):
- platform/graphics/texmap/coordinated/CoordinatedSurface.h:
(WebCore::CoordinatedSurface::size):
(WebCore::CoordinatedSurface::flags):
- platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp: Added.
(WebCore::ThreadSafeCoordinatedSurface::create):
(WebCore::ThreadSafeCoordinatedSurface::ThreadSafeCoordinatedSurface):
(WebCore::ThreadSafeCoordinatedSurface::~ThreadSafeCoordinatedSurface):
(WebCore::ThreadSafeCoordinatedSurface::paintToSurface):
(WebCore::ThreadSafeCoordinatedSurface::copyToTexture):
- platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.h: Added.
Source/WebKit2:
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::WebCoordinatedSurface):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
- 12:09 PM Changeset in webkit [152306] by
-
- 4 edits in trunk/Source
plainText() is O(N2)
https://bugs.webkit.org/show_bug.cgi?id=118282
<rdar://problem/14284360>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- editing/TextIterator.cpp:
(WebCore::plainText): Linear growth for a vector data type is O(N2).
Don't do that. Luckily, StringBuilder does the right thing automatically,
so we can just delete code.
Source/WTF:
- wtf/text/StringBuilder.cpp:
(WTF::expandCapacity): Factored out this helper function to simplify
some code that was duplicated in four places.
(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append): Use expandCapacity(). One of the cases
was not doing anything special, and so was O(N2).
Also, always call expandCapacity() it in a standard way, calling
capacity() first, so it's easy to tell at a glance that you got it right.
- 12:00 PM Changeset in webkit [152305] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: since the FTL disassembly hacks cannot distinguish between code and data, the LLVM disassembler symbol table callback should be able to deal gracefully with arbitrary garbage
https://bugs.webkit.org/show_bug.cgi?id=118313
Reviewed by Mark Hahnenberg.
Give it a mode where we can still crash on unrecognized reference types, so that we might
implement them in the future, but by default just print some stuff and keep going.
- disassembler/LLVMDisassembler.cpp:
(JSC):
(JSC::symbolLookupCallback):
- 11:15 AM Changeset in webkit [152304] by
-
- 1 copy in tags/Safari-537.48
New Tag.
- 11:14 AM Changeset in webkit [152303] by
-
- 6 edits3 adds in trunk
constrainScrollPositionForOverhang needs to handle scrollOrigin correctly
https://bugs.webkit.org/show_bug.cgi?id=118176
<rdar://problem/14301271>
Reviewed by Anders Carlsson.
Test: compositing/geometry/fixed-position-flipped-writing-mode.html
WebCore makes use of constrainScrollPositionForOverhang not only for
constraining fixed- and sticky-positioned elements to the viewport, but
also for clamping the tile cache's visible rect.
Therefore, constrainScrollPositionForOverhang needs to correctly take
the scrollOrigin into account. The easiest way I saw to do this was to
reimplement the function in terms of a pair of rect intersections
between a virtual scrollable "viewport" and the document (with a bit
of complication from headers and footers).
The first intersection is performed, then if the viewport doesn't fit,
it is pushed down and to the right, from the origin. Next, we intersect
again, this time pushing the rect up by the amount it overflowed the document
rect from the bottom right. This performs effectively the same constraint
as previously, but handles the scrollOrigin correctly and is also somewhat
easier to read and understand (with pictures).
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
Subtract the scrollOrigin out of the offset passed to scrollOffsetForFixedPosition,
it's expecting an offset without the origin included.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::constrainScrollPositionForOverhang):
Reimplement the function as described above.
Add a test that ensures that fixed position works with a scrollable document
and direction: rtl, which is one case where scrollOrigin is set.
Disable the test on Mac WebKit1 because of https://bugs.webkit.org/show_bug.cgi?id=118269.
- compositing/geometry/fixed-position-flipped-writing-mode-expected.txt: Added.
- compositing/geometry/fixed-position-flipped-writing-mode.html: Added.
- platform/mac/compositing/geometry/fixed-position-flipped-writing-mode-expected.png: Added.
- platform/mac/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 11:00 AM Changeset in webkit [152302] by
-
- 3 edits in branches/safari-537-branch/LayoutTests
Merged r152184. <rdar://problem/14304814>
- 10:54 AM Changeset in webkit [152301] by
-
- 5 edits in branches/dfgFourthTier/Source
fourthTier: FTL should use the equivalent of llvm opt -O2 by default
https://bugs.webkit.org/show_bug.cgi?id=118311
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Use a PassManagerBuilder instead of rolling our own.
This boosts our speed-up by another 5% or so.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- runtime/Options.h:
(JSC):
Source/WTF:
Reviewed by Mark Hahnenberg.
- wtf/LLVMHeaders.h:
- 10:53 AM Changeset in webkit [152300] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed build correction for 'DebugSuffix' target.
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj: Must pass the
DEBUGSUFFIX definition to the nmake instance to be available during script processing.
- 10:37 AM Changeset in webkit [152299] by
-
- 16 edits2 deletes in trunk/Source/WebCore
Remove SVGStyledLocatableElement class
https://bugs.webkit.org/show_bug.cgi?id=118283
Reviewed by Dirk Schulze.
Remove SVGStyledLocatableElement class and have SVGGraphicsElement
inherit SVGStyledElement directly instead. SVGStyledLocatableElement
is no longer needed and according to the specification, SVGGraphicsElement
should inherit SVGStyledElement (actually SVGElement once we merge
SVGStyledElement into SVGElement).
No new tests, no behavior change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
- svg/SVGAllInOne.cpp:
- svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
- svg/SVGElement.h:
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
- svg/SVGGraphicsElement.h:
- svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::getTransformToElement):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::localCoordinateSpaceTransform):
- svg/SVGStyledLocatableElement.cpp: Removed.
- svg/SVGStyledLocatableElement.h: Removed.
- 9:50 AM Changeset in webkit [152298] by
-
- 2 edits in trunk/Tools
[ATK] Leak: leaks in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118297
Fixed memory leak.
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-02
Reviewed by Christophe Dumez.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::stringValue):
- 9:26 AM Changeset in webkit [152297] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Crash after download.
https://bugs.webkit.org/show_bug.cgi?id=118303
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-02
Reviewed by Brent Fulgham.
We need to make sure that the Curl easy handle is removed from the Curl multi handle before it's freed.
- platform/network/curl/CurlDownload.cpp:
(CurlDownloadManager::updateHandleList): Use addToCurl() and removeFromCurl() methods.
(CurlDownloadManager::addToCurl): Add method to add easy handle to multi handle.
(CurlDownloadManager::removeFromCurl): Add method to remove easy handle from multi handle, and then delete the handle.
(CurlDownloadManager::downloadThread): Use removeFromCurl() method.
(CurlDownload::~CurlDownload):
- platform/network/curl/CurlDownload.h: Avoid deleting Curl easy handle in destructor.
- 9:21 AM Changeset in webkit [152296] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed gardening. Added new common expectations for test after r151665.
- accessibility/box-styled-lists-expected.txt: Added shared expectation.
- platform/efl/TestExpectations: Removed failure expectation.
- platform/gtk/TestExpectations: Ditto.
- 9:19 AM Changeset in webkit [152295] by
-
- 4 edits in trunk/Tools
Fix WebKitTestRunner crashes.
https://bugs.webkit.org/show_bug.cgi?id=117630
Reviewed by Darin Adler.
Create static function to dump for WebProcess unresponsiveness status,
and use it before calling TestController::runTest().
Accessing TestController::m_currentInvocation before calling
TestController::runTest() can make crash because the invocation
instance will be assigned at the function.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::run):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpWebProcessUnresponsiveness):
- WebKitTestRunner/TestInvocation.h:
- 9:13 AM Changeset in webkit [152294] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Unreviewed gardening. Added new baselines for GTK after revision r151841 and r151868.
- accessibility/listitem-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/listitem-title-expected.txt.
- platform/gtk/accessibility/aria-tab-role-on-buttons-expected.txt: Added.
- 8:00 AM Changeset in webkit [152293] by
-
- 4 edits in trunk/Source/WebCore
[CSSRegions] No other SVG elements except the SVGRoot must have RegionInfo objects attached
https://bugs.webkit.org/show_bug.cgi?id=118295
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-02
Reviewed by Antti Koivisto.
Only the SVGRoot element can be collected in a named flow. As such, no SVG element below the root should
be attached to a RenderBoxRegionInfo object.
A larger patch's test (https://bugs.webkit.org/show_bug.cgi?id=118300) is failing because of this.
This change will be covered by that test.
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion):
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderSVGBlock):
- rendering/svg/RenderSVGBlock.h:
- 7:32 AM Changeset in webkit [152292] by
-
- 2 edits in trunk/WebKitLibraries
Unreviewed, rolling out r152233.
http://trac.webkit.org/changeset/152233
https://bugs.webkit.org/show_bug.cgi?id=118304
hopeful attempt to restore windows buildage (Requested by
kling on #webkit).
- win/tools/vsprops/debugsuffix.props:
- 7:04 AM Changeset in webkit [152291] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Rebaseline background blend mode default test result.
- platform/mac/css3/compositing/background-blend-mode-default-value-expected.png:
- 6:48 AM Changeset in webkit [152290] by
-
- 6 edits in trunk/Source/WebCore
is/toHTMLStyleElement should use Element* for its argument
https://bugs.webkit.org/show_bug.cgi?id=118286
Reviewed by Andreas Kling.
To reduce unnecessary call of isElementNode(), this patch replaces argument
of is/toHTMLStyleElement from Node* to Element*. Plus, use Element::hasTagName
in collectActiveStyleSheets function for minor code refactoring since
its cost is cheaper than Node::hasTagName.
- css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
- dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
- html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):
- 6:36 AM Changeset in webkit [152289] by
-
- 3 edits in trunk/Source/WTF
Avoid code duplication inside String::append()
https://bugs.webkit.org/show_bug.cgi?id=118290
Reviewed by Anders Carlsson.
The implementation of 'append(UChar)' had been repeated inside 'append(LChar)',
this duplication is obviated now.
- wtf/text/WTFString.cpp:
(WTF::String::appendInternal):
(WTF::String::append):
- wtf/text/WTFString.h:
- 6:31 AM Changeset in webkit [152288] by
-
- 2 edits in trunk/LayoutTests
Skip fast/dom/timer-throttling-hidden-page.html after r152202.
<http://webkit.org/b/118301>
- 5:53 AM Changeset in webkit [152287] by
-
- 2 edits in trunk/LayoutTests
Skip 3 MathML tests that are failing after r152235.
<http://webkit.org/b/118298>
- 5:20 AM Changeset in webkit [152286] by
-
- 3 edits in trunk/Source/WebCore
Unexpose EditingPropertiesToInclude in EditingStyle.h after r151772
https://bugs.webkit.org/show_bug.cgi?id=118271
Reviewed by Andreas Kling.
Don't expose EditingPropertiesToInclude in EditingStyle.h and do other cleanups as described below.
No new tests since there should be no behavioral change.
- editing/EditingStyle.cpp:
(WebCore::copyEditingProperties): Use newly defined numAllEditingProperties and numInheritableEditingProperties
instead of a magic number of 2.
(WebCore::copyPropertiesFromComputedStyle): Renamed from editingStyleFromComputedStyle. It now takes ComputedStyleExtractor and
PropertiesToInclude instead of Node* and EditingPropertiesToInclude and handles AllProperties. Also added a helper that takes Node*.
(WebCore::EditingStyle::init): Calls copyPropertiesFromComputedStyle. Unfortunately, we need to special-case EditingPropertiesInEffect
and not set background-color and text-decoration. This is required probably due to a bug elsewhere.
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::extractEditingProperties): Renamed from EditingStyle::removeAllButEditingProperties; takes PropertiesToInclude instead of
EditingPropertiesToInclude since the only caller of this function, EditingStyle::mergeInlineAndImplicitStyleOfElement, was converting
the type.
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
- editing/EditingStyle.h:
- 4:56 AM Changeset in webkit [152285] by
-
- 7 edits in trunk/Source/WebCore
Introduce toSVGInlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=118289
Reviewed by Andreas Kling.
As a step to change static_cast with toXXX, static_cast<SVGInlineTextBox*> can
be changed with toSVGInlineTextBox().
Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153345
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::positionForPoint):
- rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paintSelectionBackground):
(WebCore::SVGInlineFlowBox::paint):
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
- rendering/svg/SVGInlineTextBox.h:
(WebCore::toSVGInlineTextBox):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGInlineTextBoxes):
- rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
- rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::collectTextBoxesInFlowBox):
- 4:50 AM Changeset in webkit [152284] by
-
- 2 edits in trunk/Source/WebCore
Simplify SVGTextContentElement::elementFromRenderer()
https://bugs.webkit.org/show_bug.cgi?id=118284
Reviewed by Andreas Kling.
Simplify SVGTextContentElement::elementFromRenderer() by leveraging
SVGElement::isTextContent() methods instead of explicitly checking
for tag names.
No new tests, no behavior change.
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::elementFromRenderer):
- 4:19 AM Changeset in webkit [152283] by
-
- 2 edits in trunk/Source/WebCore
Fix cast-align warnings in WebCore/platform/graphics/texmap/TextureMapperGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=118249
Reviewed by Allan Sandfeld Jensen.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
- 4:04 AM Changeset in webkit [152282] by
-
- 6 edits in trunk
[Qt][WK1] Support WebGL with EGL on Linux
https://bugs.webkit.org/show_bug.cgi?id=118251
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Let GraphicsContext3D work without a GraphicsSurface.
- Target.pri:
- platform/graphics/OpenGLShims.cpp:
(WebCore::getProcAddress):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
Tools:
- qmake/mkspecs/features/features.prf:
- 12:43 AM Changeset in webkit [152281] by
-
- 7 edits2 adds in trunk
[CSS-Regions] OverrideLogicalHeight used by both regions and flexbox
https://bugs.webkit.org/show_bug.cgi?id=118057
Patch by Catalin Badea <badea@adobe.com> on 2013-07-02
Reviewed by David Hyatt.
Source/WebCore:
Remove the use of overrideLogicalContentHeight() from regions and
use a local variable instead. The change was needed to avoid
overlapping with flexbox containers.
Test: fast/regions/autoheight-flexbox.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::applyBreakAfterContent):
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::updateLogicalHeight):
- rendering/RenderRegion.h:
(WebCore::RenderRegion::computedAutoHeight):
(WebCore::RenderRegion::setComputedAutoHeight):
(WebCore::RenderRegion::clearComputedAutoHeight):
(WebCore::RenderRegion::hasComputedAutoHeight):
- rendering/RenderView.cpp:
LayoutTests:
Add test for auto-height regions and flexbox containers.
- fast/regions/autoheight-flexbox-expected.html: Added.
- fast/regions/autoheight-flexbox.html: Added.
Jul 1, 2013:
- 11:03 PM Changeset in webkit [152280] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC]: Fix maybe-uninitialized gcc 4.8 warning in DFGSpeculativeJIT.cpp
https://bugs.webkit.org/show_bug.cgi?id=118278
Patch by Sergio Correia <Sergio Correia> on 2013-07-01
Reviewed by Filip Pizlo.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
Initialize valueGPR with InvalidGPRReg.
- 9:33 PM Changeset in webkit [152279] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should run LICM after AA setup
https://bugs.webkit.org/show_bug.cgi?id=118277
Reviewed by Maciej Stachowiak.
LICM queries alias analysis. Hence, just like GVN, it should run after
we have set up the alias analysis.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- 9:07 PM Changeset in webkit [152278] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should run AA passes before GVN
https://bugs.webkit.org/show_bug.cgi?id=118276
Rubber stamped by Geoffrey Garen.
These enable load elimination in GVN.
Immediately gives us a speed-up on a bunch of benchmarks I hacked to run
properly in the FTL. One example is 20% on imaging-gaussian-blur. (Fair
warning: the stock version of that benchmark won't see speed-ups -
probably slow-downs instead - because the FTL can't do OSR entry yet.)
Another example is the findGraphNode function, which now sees a 7%
speed-up, and that's without even doing LICM or other good things.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- 7:00 PM Changeset in webkit [152277] by
-
- 3 edits in trunk/Tools
[Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
https://bugs.webkit.org/show_bug.cgi?id=118267
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-07-01
Reviewed by Gyuyoung Kim.
After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
- efl/jhbuildrc:
- gtk/jhbuildrc:
- 6:01 PM Changeset in webkit [152276] by
-
- 2 edits in trunk/Source/WebCore
Windows should be included in the list of platforms that can use OpenGL ES 2.
https://bugs.webkit.org/show_bug.cgi?id=118264
Reviewed by Dean Jackson.
- platform/graphics/GraphicsContext3D.h: Added PLATFORM(WIN) to platforms using OpenGL ES 2.
- 6:00 PM Changeset in webkit [152275] by
-
- 18 edits14 deletes in trunk
[GTK] Remove unsupported AC backends
https://bugs.webkit.org/show_bug.cgi?id=117362
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-07-01
Reviewed by Martin Robinson.
.:
- Source/autotools/FindDependencies.m4: remove checks related to acceleration backend,
turn them into a check for OpenGL being available, simply.
- Source/autotools/ReadCommandLineArguments.m4: remove command line option to select
accelerated backend, it's now auto-detected.
- Source/autotools/SetupAutoconfHeader.m4: no longer defines USE_CLUTTER and
USE_TEXTURE_MAPPER_CAIRO.
- Source/autotools/SetupAutomake.m4: remove checks related to acceleration backend,
turn them into a check for OpenGL being available, simply.
- Source/autotools/Versions.m4: no longer check for clutter/clutter-gtk.
Source/WebCore:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Source/WebCore/platform/graphics/PlatformLayer.h: Removed mentions of clutter
and the texmap cairo backend.
- platform/graphics/clutter/DrawingBufferClutter.cpp: Removed.
- platform/graphics/clutter/GraphicsContext3DClutter.cpp: Removed.
- platform/graphics/clutter/GraphicsContext3DPrivate.cpp: Removed.
- platform/graphics/clutter/GraphicsContext3DPrivate.h: Removed.
- platform/graphics/clutter/GraphicsLayerActor.cpp: Removed.
- platform/graphics/clutter/GraphicsLayerActor.h: Removed.
- platform/graphics/clutter/GraphicsLayerClutter.cpp: Removed.
- platform/graphics/clutter/GraphicsLayerClutter.h: Removed.
- platform/graphics/clutter/PlatformClutterAnimation.cpp: Removed.
- platform/graphics/clutter/PlatformClutterAnimation.h: Removed.
- platform/graphics/clutter/PlatformClutterLayerClient.h: Removed.
- platform/graphics/clutter/TransformationMatrixClutter.cpp: Removed.
- Source/WebCore/platform/graphics/transforms/TransformationMatrix.h: Removed cogl
matrix type conversion.
Source/WebKit/gtk:
- GNUmakefile.am:
- WebCoreSupport/AcceleratedCompositingContext.h: removed clutter and cairo
additions.
- WebCoreSupport/AcceleratedCompositingContextCairo.cpp: Removed.
- WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Removed.
- webkit/webkitglobals.cpp:
(webkitInit): removed clutter-gtk initialization.
Tools:
- gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
and cogl, so removed.
- 5:45 PM Changeset in webkit [152274] by
-
- 7 edits in branches/safari-537-branch/Source/WebKit2
Merged r152273. <rdar://problem/13078036>
- 5:08 PM Changeset in webkit [152273] by
-
- 7 edits in trunk/Source/WebKit2
Clean up private browsing session tracking
https://bugs.webkit.org/show_bug.cgi?id=118266
<rdar://problem/13078036>
Reviewed by Brady Eidson.
Instead of counting API calls, we now watch actual WebPreferences objects.
- UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetPrivateBrowsingEnabled): Removed code that used to notify WebContext. It's now done by WebPreferences.
- UIProcess/WebContext.h:
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureNetworkProcess): Instead of counting the number of times API was called, rely on WebPreferences tracking. (WebKit::WebContext::willStartUsingPrivateBrowsing): Ditto. This function is now only called when we detect a change in private browsing state. (WebKit::WebContext::willStopUsingPrivateBrowsing): Ditto. (WebKit::WebContext::createNewWebProcess): Tell the new process to create a private browsing session if needed.
- UIProcess/WebPreferences.h:
- UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::addPageGroup): Count how many page groups use private browsing, and notify WebContext when a session is needed. Note that we don't notify WebContext about WebPreferences without any page groups, because it's likely that preferences will be updated by the client before groups are associated. (WebKit::WebPreferences::removePageGroup): Ditto. (WebKit::WebPreferences::updateBoolValueForKey): Perform special handling for private browsing mode changes. (WebKit::WebPreferences::updatePrivateBrowsingValue): Notify WebContext when it's time to create or destroy a private browsing session. (WebKit::WebPreferences::anyPageGroupsAreUsingPrivateBrowsing): A getter for WebContext to know when any page groups are in private browsing mode.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Don't create a private browsing session implicitly, UI process takes care of it.
- 4:36 PM Changeset in webkit [152272] by
-
- 6 edits2 copies in branches/safari-537-branch
Merged r152265. <rdar://problem/14301217>
- 4:33 PM Changeset in webkit [152271] by
-
- 3 edits in branches/safari-537-branch/Source/WebKit2
Merged r152266. <rdar://problem/14301166>
- 4:31 PM Changeset in webkit [152270] by
-
- 3 edits in branches/safari-537-branch/Source/WebKit2
Merged r152077. <rdar://problem/14270933>
- 4:21 PM Changeset in webkit [152269] by
-
- 4 edits in trunk/Source/WebCore
DrawingBuffer constructor and destructor were not defined for Windows.
I moved duplicate code from Cairo and Qt to DrawingBuffer.cpp to be used by Qt, Cairo, and Windows.
https://bugs.webkit.org/show_bug.cgi?id=118262
Reviewed by Dean Jackson.
- platform/graphics/cairo/DrawingBufferCairo.cpp: Removed duplicate DrawingBuffer constructor and destructor.
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer): Moved from Cairo and Qt implementation.
- platform/graphics/gpu/qt/DrawingBufferQt.cpp: Removed duplicate DrawingBuffer constructor and destructor.
- 3:44 PM Changeset in webkit [152268] by
-
- 2 edits in trunk/Source/WebCore
Fixed unreachable return when GLX or EGL are used with WebGL.
https://bugs.webkit.org/show_bug.cgi?id=118263
Reviewed by Noam Rosenthal.
- platform/graphics/opengl/GLPlatformContext.cpp:
(WebCore::createOffScreenContext): Fixed unreachable return.
- 3:23 PM Changeset in webkit [152267] by
-
- 14 edits in trunk
Link to WebInspectorUI.framework at build time instead of soft linking.
https://bugs.webkit.org/show_bug.cgi?id=118261
Reviewed by Joseph Pecoraro.
.:
- Source/Makefile: Build WebInspectorUI before WebKit and WebKit2.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
- WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):
Source/WebKit2:
- Configurations/WebKit2.xcconfig:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
Tools:
- Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
- 2:47 PM Changeset in webkit [152266] by
-
- 3 edits in trunk/Source/WebKit2
[wk2] TiledCoreAnimationDrawingArea should support scrolling its exposed rect
https://bugs.webkit.org/show_bug.cgi?id=118173
<rdar://problem/14301166>
Reviewed by Anders Carlsson.
Offset the exposed rect passed from the WKView by the main frame's current scroll position
before sending it to our TiledBackings, so that it is in the same coordinate space as their
ordinary visibleRects.
This has the side effect of making clips-to-exposed-rect testable (though useless) in Safari.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add updateScrolledExposedRect() and m_scrolledExposedRect.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
Call updateScrolledExposedRect when the main frame scrolls.
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
Remove a FIXME about this change.
Call updateScrolledExposedRect instead of passing down the unscrolled rect.
(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
Call updateScrolledExposedRect, because that method will short-circuit if
setClipsToExposedRect is false, so we need to update here for correctness
if we get a setExposedRect(), setClipsToExposedRect(true) pair.
(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
Update m_scrolledExposedRect and propagate it to our TiledBackings.
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Use the scrolled exposed rect.
- 2:35 PM Changeset in webkit [152265] by
-
- 6 edits2 adds in trunk
Maximum scroll position can be negative in some cases
https://bugs.webkit.org/show_bug.cgi?id=118175
<rdar://problem/14301217>
Reviewed by Anders Carlsson.
Test (API): WebKit2.ResizeReversePaginatedWebView
- page/FrameView.cpp:
(WebCore::FrameView::maximumScrollPosition):
- page/FrameView.h:
Override maximumScrollPosition() in FrameView and don't clamp to zero if
a reverse pagination mode is enabled, as it is possible (and common) to
have a negative maximum scroll position with reverse pagination.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
Drive-by adoption of toIntSize().
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
(TestWebKitAPI::didRunJavaScript):
(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
Add a test that loads a vertical-lr document, paginates it horizontally
from right to left, resizes the view to fit the entire document, and
verifies that the scroll position is negative, as it must be for the
document to be enclosed by the view.
- 2:19 PM Changeset in webkit [152264] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152230. <rdar://problem/14306784>
- 2:17 PM Changeset in webkit [152263] by
-
- 3 edits in branches/safari-537-branch/Source/WebCore
Merged r152204. <rdar://problem/14205335>
- 2:16 PM Changeset in webkit [152262] by
-
- 2 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152200. <rdar://problem/14308488>
- 2:13 PM Changeset in webkit [152261] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152187. <rdar://problem/14250167>
- 2:12 PM Changeset in webkit [152260] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r152185. <rdar://problem/13926528>
- 2:10 PM Changeset in webkit [152259] by
-
- 6 edits in branches/safari-537-branch/Source/WebKit2
Merged r152182. <rdar://problem/14255677>
- 2:09 PM Changeset in webkit [152258] by
-
- 4 edits2 copies in branches/safari-537-branch/Source/WebInspectorUI
Merged r152092. <rdar://problem/5847649>
- 2:07 PM Changeset in webkit [152257] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152075. <rdar://problem/14271105>
- 2:05 PM Changeset in webkit [152256] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152073. <rdar://problem/14194077>
- 2:04 PM Changeset in webkit [152255] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152072. <rdar://problem/13643935>
- 2:02 PM Changeset in webkit [152254] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152063. <rdar://problem/13888138>
- 2:00 PM Changeset in webkit [152253] by
-
- 13 edits in branches/safari-537-branch/Source
Merged r152234. <rdar://problem/14083280>
- 1:57 PM Changeset in webkit [152252] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152231. <rdar://problem/14321403>
- 1:54 PM Changeset in webkit [152251] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152207. <rdar://problem/14242032>
- 1:53 PM Changeset in webkit [152250] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152202. <rdar://problem/14247819>
- 1:45 PM Changeset in webkit [152249] by
-
- 2 edits in trunk/Source/WebKit2
Properly hide the header and footer banners if they are set to null.
https://bugs.webkit.org/show_bug.cgi?id=118219
Reviewed by Beth Dakin.
Call Page::addFooterWithHeight(0) to remove the parent layer that hosts the banner when
the footer banner is detached. Similarly for the header banner.
- WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::detachFromPage):
- 1:43 PM Changeset in webkit [152248] by
-
- 4 edits4 copies in branches/safari-537-branch
Merged r152198. <rdar://problem/13488092>
- 1:39 PM Changeset in webkit [152247] by
-
- 4 edits2 copies in branches/safari-537-branch
Merged r152196. <rdar://problem/14259249>
- 1:38 PM Changeset in webkit [152246] by
-
- 6 edits in branches/safari-537-branch/Source/WebCore
Merged r152194. <rdar://problem/14261627>
- 1:36 PM Changeset in webkit [152245] by
-
- 11 edits in branches/safari-537-branch/Source/WebKit2
Merged r152190. <rdar://problem/14301175>
- 1:34 PM Changeset in webkit [152244] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152177. <rdar://problem/14303613>
- 1:33 PM Changeset in webkit [152243] by
-
- 8 edits in branches/safari-537-branch/Source/WebCore
Merged r152117. <rdar://problem/14278960>
- 1:30 PM Changeset in webkit [152242] by
-
- 4 edits in branches/safari-537-branch
Merged r152091. <rdar://problem/12679475>
- 1:07 PM Changeset in webkit [152241] by
-
- 14 edits1 copy in branches/safari-537-branch/Source
Merged r152065. <rdar://problem/10055712>
- 12:48 PM Changeset in webkit [152240] by
-
- 8 edits in trunk/Source/WebCore
Removed all references to DrawingBuffer methods unused since the removal of Chromium:
DrawingBuffer::prepareBackBuffer,
DrawingBuffer::requiresCopyFromBackToFrontBuffer, and
DrawingBuffer::clearPlatformLayer.
https://bugs.webkit.org/show_bug.cgi?id=118257
Reviewed by Darin Adler.
- platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
(WebCore::DrawingBuffer::platformLayer):
- platform/graphics/cairo/DrawingBufferCairo.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/clutter/DrawingBufferClutter.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clear):
- platform/graphics/gpu/DrawingBuffer.h:
- platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::frontColorBuffer):
- platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- 12:33 PM Changeset in webkit [152239] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build correction.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Need to export tag for textarea element.
- 12:24 PM Changeset in webkit [152238] by
-
- 30 edits in trunk/Source
Remove support for consumable user gestures
https://bugs.webkit.org/show_bug.cgi?id=118247
Reviewed by Geoffrey Garen.
Source/WebCore:
The features was not enabled on any port, and is meanwhile broken, so we
should delete it.
No new tests, just deleting dead code.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::increment):
(WebCore::AccessibilityNodeObject::decrement):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeScript):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld):
- dom/UserGestureIndicator.cpp:
(WebCore::isDefinite):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::~UserGestureIndicator):
- dom/UserGestureIndicator.h:
(WebCore::UserGestureIndicator::processingUserGesture):
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openInNewTab):
- inspector/InspectorFrontendHost.cpp:
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::navigate):
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledURLNavigation::fire):
(WebCore::ScheduledURLNavigation::didStartTimer):
(WebCore::ScheduledRedirect::fire):
(WebCore::ScheduledRefresh::fire):
(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::fire):
(WebCore::ScheduledFormSubmission::didStartTimer):
- page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::fired):
- page/DOMTimer.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog):
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
- page/EventHandler.h:
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::toggleMediaFullscreenState):
(WebCore::HitTestResult::enterFullscreenForVideo):
Source/WebKit/blackberry:
- WebKitSupport/NotificationManager.cpp:
(BlackBerry::WebKit::NotificationManager::notificationClicked):
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::evaluate):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView sendEvent:isDrawRect:]):
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::notificationClicked):
Source/WebKit/win:
- WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
Source/WebKit2:
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::didClickNotification):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performFrameLoadURLRequest):
(WebKit::PluginView::evaluate):
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):
- 12:14 PM Changeset in webkit [152237] by
-
- 12 edits in branches/safari-537-branch/Source
Merged r151978. <rdar://problem/14102739>
- 11:54 AM Changeset in webkit [152236] by
-
- 1 edit2 adds in trunk/Websites/webkit.org
Add screenshot of the inspector color picker for the blog
- blog-files/last-week-in-webkit: Added.
- blog-files/last-week-in-webkit/Inspector_color_picker.png: Added.
- 11:41 AM Changeset in webkit [152235] by
-
- 14 edits8 adds in trunk
Add Support for mspace element
https://bugs.webkit.org/show_bug.cgi?id=115610
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-07-01
Reviewed by Chris Fleizach.
Source/WebCore:
This patch adds basic support for the MathML mspace element. This is
important to let people control spacing of mathematical formulas.
Attributes width, height and depth are implemented. For the moment,
only nonnegative width are accepted.
- CMakeLists.txt: add references to the RenderMathMLSpace files.
- GNUmakefile.list.am: ditto.
- Target.pri: ditto.
- WebCore.vcxproj/WebCore.vcxproj: ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto.
- css/mathml.css:
(mtable[columnlines="dashed"] > mtr > mtd + mtd): remove the obsolete linebreaking rule.
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createRenderer): map mspaceTag to RenderMathMLSpace.
- mathml/mathattrs.in: add width, height and depth attributes
- mathml/mathtags.in: add mspace element
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::parseMathMLLength): fix int to float conversion.
- rendering/mathml/RenderMathMLBlock.h: declare isRenderMathMLSpace.
(WebCore::RenderMathMLBlock::isRenderMathMLSpace):
- rendering/mathml/RenderMathMLSpace.cpp: Added.
(WebCore::RenderMathMLSpace::RenderMathMLSpace):
(WebCore::RenderMathMLSpace::isChildAllowed):
(WebCore::RenderMathMLSpace::computePreferredLogicalWidths):
(WebCore::RenderMathMLSpace::updateFromElement):
(WebCore::RenderMathMLSpace::updateLogicalWidth):
(WebCore::RenderMathMLSpace::updateLogicalHeight):
(WebCore::RenderMathMLSpace::layout):
(WebCore::RenderMathMLSpace::styleDidChange):
(WebCore::RenderMathMLSpace::firstLineBoxBaseline):
- rendering/mathml/RenderMathMLSpace.h: Added.
(WebCore::RenderMathMLSpace::isRenderMathMLSpace):
(WebCore::RenderMathMLSpace::renderName):
(WebCore::toRenderMathMLSpace):
LayoutTests:
Add a reftest for the mspace element (width, height and depth) and
the parsing of MathML lengths. Import a reftest from Gecko to check
positive namedspace values.
- mathml/presentation/mspace-expected.html: Added.
- mathml/presentation/mspace-units-expected.html: Added.
- mathml/presentation/mspace-units.html: Added.
- mathml/presentation/mspace.html: Added.
- mathml/presentation/positive-namedspace-expected.html: Added.
- mathml/presentation/positive-namedspace.html: Added.
- 11:40 AM Changeset in webkit [152234] by
-
- 13 edits in trunk/Source
Audio in apps which embed WebViews is corrupted.
https://bugs.webkit.org/show_bug.cgi?id=118163
Reviewed by Maciej Stachowiak.
Source/WebCore:
Add a preference, which defaults to off, which controls whether the
AudioSessionManager will switch to a large audio buffer setting for
power-savings during <video> playback.
- WebCore.exp.in:
- page/Settings.cpp:
(WebCore::Settings::setLowPowerVideoAudioBufferSizeEnabled): Added. Simple setter.
- page/Settings.h:
(WebCore::Settings::lowPowerVideoAudioBufferSizeEnabled): Added. Simple getter.
- platform/audio/mac/AudioSessionManagerMac.cpp:
(AudioSessionManager::updateSessionState): Only set the large audio buffer
size if lowPowerVideoAudioBufferSize is enabled.
Source/WebKit/mac:
Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit clients.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences lowPowerVideoAudioBufferSizeEnabled]):
(-[WebPreferences setLowPowerVideoAudioBufferSizeEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit2 clients.
- Shared/WebPreferencesStore.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 11:12 AM Changeset in webkit [152233] by
-
- 2 edits in trunk/WebKitLibraries
[Windows] Unreviewed correction to DEBUG_ALL target. Target was undefining DEBUG_ALL and DEBUG_INTERNAL,
which prevented proper build operation.
- win/tools/vsprops/debugsuffix.props: We should DEFINE (not UNDEFINE) the DEBUG_ALL and DEBUG_INTERNAL
macros when building with 'debugsuffix' target.
- 11:04 AM Changeset in webkit [152232] by
-
- 2 edits in trunk/Source/WebCore
[ATK] Leak: leaks in WebKitAccessibleInterfaceText
https://bugs.webkit.org/show_bug.cgi?id=118248
Fixed memory leaks.
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-01
Reviewed by Christophe Dumez.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getPangoLayoutForAtk):
(webkitAccessibleTextGetText):
- 10:53 AM Changeset in webkit [152231] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Make WebCore.make copy over QTMovieWin DLL's and PDB's.
<rdar://problem/14321403>
- WebCore.vcxproj/WebCore.make:
- 10:45 AM Changeset in webkit [152230] by
-
- 2 edits in trunk/Source/WebKit2
WKPageLoadDataWithUserData neglects to set the base URL that is passed in
<rdar://problem/14306784>
https://bugs.webkit.org/show_bug.cgi?id=118256
Reviewed by Anders Carlsson.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadData):
Pass the baseURL, not blankURL(), and remove an unnecessary multiplication by sizeof(uint8_t) which is always 1.
- 9:47 AM Changeset in webkit [152229] by
-
- 2 edits in trunk/Source/WebKit/win
[Curl] WebDownload init method is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=118241
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.
The WebDownload::init() method called when a normal load is changed to a download
because of a decision by the policy delegate, is not implemented for Curl.
- WebDownloadCurl.cpp:
(WebDownload::init): Implement init() method.
- 9:38 AM Changeset in webkit [152228] by
-
- 3 edits in trunk/Source/WebCore
[Win] Crash when scrolling page with images.
https://bugs.webkit.org/show_bug.cgi?id=117832
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.
Avoid access violation by returning early from method if image frame doesn't have pixel data.
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::hasPixelData): Added method to check if frame has pixel data.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow): Early return if frame doesn't have pixel data.
- 9:32 AM Changeset in webkit [152227] by
-
- 4 edits in trunk/Source/WebCore
Avoid calling RenderLayerBacking::resetContentsRect() if possible
https://bugs.webkit.org/show_bug.cgi?id=118217
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-07-01
Reviewed by Simon Fraser.
Call resetContentsRect() only if the layer has a contentsLayer.
Otherwise the contentsRect is redundant for the GraphicsLayer.
No new tests - optimization only. This is covered by plenty of existing
tests in webgl/ and compositing/.
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::hasContentsLayer):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
Added hasContentsLayer calls for TextureMapper/CoordinatedGraphics
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- 9:25 AM Changeset in webkit [152226] by
-
- 9 edits in trunk/Tools
[EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
https://bugs.webkit.org/show_bug.cgi?id=117249
Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2013-07-01
Reviewed by Brent Fulgham.
Finish converting all use cases of WEBKITOUTPUTDIR to
WEBKIT_OUTPUTDIR, which seems to be preferred these days.
- DumpRenderTree/efl/FontManagement.cpp:
(getCustomBuildDir):
(getPlatformFontsPath):
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(getOutputDir):
- Scripts/webkitdirs.pm:
(determineBaseProductDir):
(usesPerConfigurationBuildDirectory):
- Scripts/webkitpy/port/base.py:
(Port.to.setup_environ_for_server):
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver):
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::getOutputDir):
- jhbuild/jhbuildutils.py:
(get_dependencies_path):
- 8:39 AM Changeset in webkit [152225] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix cast-align warnings in JavaScriptCore/heap/HandleBlockInlines.h
https://bugs.webkit.org/show_bug.cgi?id=118242
Reviewed by Mark Hahnenberg.
- heap/HandleBlockInlines.h:
(JSC::HandleBlock::nodes):
- 8:29 AM Changeset in webkit [152224] by
-
- 2 edits in trunk/Tools
Unreviewed change of my email address.
- Scripts/webkitpy/common/config/contributors.json:
- 7:36 AM Changeset in webkit [152223] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Un-break the WebCore ChangeLog after http://trac.webkit.org/changeset/152219.
- 7:29 AM Changeset in webkit [152222] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Avoid creating a QWindow for offscreen GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=118244
Reviewed by Noam Rosenthal.
In Qt 5.0 we had to create invisible windows, but in Qt 5.1
we can now create specific offscreen surfaces.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
- 6:31 AM Changeset in webkit [152221] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping unsupported tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-01
- platform/qt/TestExpectations:
- 6:29 AM Changeset in webkit [152220] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Remove long unused Qt4 forward definitions
Unreviewed cleanu-up.
- platform/graphics/GraphicsContext3D.h:
- 6:27 AM Changeset in webkit [152219] by
-
- 5 edits in trunk/Source/WebCore
Use DeferrableOneShotTimer for deleting decoded data
https://bugs.webkit.org/show_bug.cgi?id=118150
Reviewed by Andreas Kling.
Adam Barth pointed out that the virtual function for overriding the default delay doesn't work
as expected from base class constructor.
- loader/cache/CachedResource.cpp:
(WebCore::deadDecodedDataDeletionIntervalForResourceType):
(WebCore::CachedResource::CachedResource):
Use static function instead of calling a virtual.
- loader/cache/CachedResource.h:
- loader/cache/CachedScript.cpp:
- loader/cache/CachedScript.h:
- 3:43 AM Changeset in webkit [152218] by
-
- 26 edits in trunk/Source
Adopt toHTMLTextAreaElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118226
Reviewed by Andreas Kling.
To enhance readability, this patch adopts toHTMLTextAreaElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::text):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendText):
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
- html/HTMLTextAreaElement.h:
(WebCore::toHTMLTextAreaElement):
- page/FocusController.cpp:
(WebCore::clearSelectionIfNeeded):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isContentEditable):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
(WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth):
(WebCore::RenderTextControlMultiLine::computeControlLogicalHeight):
- testing/Internals.cpp:
(WebCore::Internals::wasLastChangeUserEdit):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::inputElementText):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::elementType):
(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textDidChangeInTextArea):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
- DOMHTMLClasses.cpp:
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):
Source/WebKit2:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textDidChangeInTextArea):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormControls):
- 1:44 AM Changeset in webkit [152217] by
-
- 3 edits in trunk/Source/WebCore
Add missing string headers that are used when LOG_DISABLED is 0.
https://bugs.webkit.org/show_bug.cgi?id=118227
Patch by Kwang Yul Seo <skyul@company100.net> on 2013-07-01
Reviewed by Andreas Kling.
Build fix for LOG_DISABLED=0.
No new tests, no behavior change.
- html/track/InbandTextTrack.cpp:
- rendering/RenderLayerCompositor.cpp:
- 1:44 AM Changeset in webkit [152216] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Use PassOwnPtr for the returned value of createBackingStore
https://bugs.webkit.org/show_bug.cgi?id=118230
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-07-01
Reviewed by Andreas Kling.
It would be better that createBackingStore returns PassOwnPtr instread of OwnPtr
to keep compatibility with c++0x.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::createBackingStore):
- 1:10 AM Applications using WebKit edited by
- Wakanda server updates (diff)
- 12:11 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
Jun 30, 2013:
- 10:30 AM Changeset in webkit [152215] by
-
- 5 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining whatever can be rebaselined and adding failure expectations for other current failures.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- platform/gtk/editing/selection/user-select-all-image-with-single-click-expected.txt: Added.
- platform/gtk/editing/selection/user-select-all-with-single-click-expected.txt: Added.
- platform/gtk/fast/events/ondragenter-expected.txt: Added.
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
Jun 29, 2013:
- 1:27 PM Changeset in webkit [152214] by
-
- 5 edits in trunk/Source/WebCore
Avoid calling into Objective-C every time we get the scrollbar width
https://bugs.webkit.org/show_bug.cgi?id=118216
Reviewed by Geoffrey Garen.
Profiling shows that calling Scrollbar::isOverlayScrollbar() is somewhat
expensive, because it calls down into Objective-C. Fix by caching in
ScrollbarThemeMac whether we're using overlay scrollbars. We update this
cache on creation, and when preferences change; ScrollAnimatorMac::updateScrollerStyle()
is the function that gets called when the user changes the setting in System Preferences.
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::usesOverlayScrollbarsChanged):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::preferencesChanged):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbarsChanged):
- 1:22 PM Changeset in webkit [152213] by
-
- 3 edits in trunk/Source/WebCore
Avoid calling isSimpleContainerCompositingLayer() an extra time
https://bugs.webkit.org/show_bug.cgi?id=118218
Reviewed by Tim Horton.
containsPaintedContent() called isSimpleContainerCompositingLayer(), which
is not particularly cheap. But the caller already has this information,
so pass it in.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::containsPaintedContent):
- rendering/RenderLayerBacking.h:
- 1:19 PM Changeset in webkit [152212] by
-
- 2 edits in trunk/Source/WebCore
Avoid doing work in RenderBox::outlineBoundsForRepaint() when the repaintContainer is this
https://bugs.webkit.org/show_bug.cgi?id=118215
Reviewed by Tim Horton.
When the RenderGeometryMap code path was added, RenderBox::outlineBoundsForRepaint()
actually got slower if no coordinate mapping was needed. So avoid doing work when
we can, including avoiding the FloatQuad construction.
Speeds up scrolling overflow:scroll areas with large numbers of layer children.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::outlineBoundsForRepaint):
- 8:49 AM Changeset in webkit [152211] by
-
- 14 edits in trunk/Source
Adopt is/toHTMLOptGroupElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118213
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLOptGroupElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isEnabled):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
- html/HTMLOptGroupElement.h:
(WebCore::isHTMLOptGroupElement):
(WebCore::toHTMLOptGroupElement):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
(WebCore::HTMLOptionElement::isDisabledFormControl):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::recalcListItems):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isSelectScopeMarker):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemIsLabel):
Source/WebKit/blackberry:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):
- 8:15 AM Changeset in webkit [152210] by
-
- 2 edits in trunk/Source/WebCore
Build fix for unguarded SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118214
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-06-29
Reviewed by Christophe Dumez.
Add the SVG condition to SVGGraphicsElement.idl
No new tests required since no functionality changed.
- svg/SVGGraphicsElement.idl:
- 7:59 AM Changeset in webkit [152209] by
-
- 2 edits in trunk/Source/JavaScriptCore
Follow-up to r152206: also update HashFlags8BitBuffer in the LLInt.
- llint/LowLevelInterpreter.asm:
- 1:18 AM Changeset in webkit [152208] by
-
- 24 edits in trunk/Source
Adopt is/toHTMLOptionElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118212
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLOptionElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::setElement):
(WebCore::AccessibilityMenuListOption::isEnabled):
(WebCore::AccessibilityMenuListOption::isSelected):
(WebCore::AccessibilityMenuListOption::setSelected):
(WebCore::AccessibilityMenuListOption::stringValue):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
- html/HTMLCollection.cpp:
(WebCore::isMatchingElement):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::index):
- html/HTMLOptionElement.h:
(WebCore::isHTMLOptionElement):
(WebCore::toHTMLOptionElement):
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isSelectScopeMarker):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemIsSelected):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):
Source/WebKit/blackberry:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
(BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
(BlackBerry::WebKit::InputHandler::openSelectPopup):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
- WebKitSupport/SelectPopupClient.cpp:
(BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
- DOMHTMLClasses.cpp:
(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):
- 12:25 AM Changeset in webkit [152207] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(151586): multipart/x-mixed-replace images are broken
https://bugs.webkit.org/show_bug.cgi?id=118169
Reviewed by Alexey Proskuryakov.
When loading multipart content the resource data will change as
the next part is loaded, so we need to make a copy of the data
before sending it to the resource.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
Jun 28, 2013:
- 11:02 PM Changeset in webkit [152206] by
-
- 2 edits in trunk/Source/JavaScriptCore
Un-crashify JSC tests on debug bots after Anders had his way with StringImpl.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- 10:53 PM Changeset in webkit [152205] by
-
- 4 edits in trunk
Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
Source/WebKit2:
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::createServerAndClientIdentifiers):
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(addFontFallbackIfPresent):
(removeFontFallbackIfPresent):
- 7:55 PM Changeset in webkit [152204] by
-
- 3 edits in trunk/Source/WebCore
[Mac] adopt new AVFoundation caption API
https://bugs.webkit.org/show_bug.cgi?id=118207
Reviewed by Dean Jackson.
No new tests, I was not able to come up with a reliable layout test.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::flushCues): New, call currentTrack->resetCueValues().
(-[WebCoreAVFMovieObserver outputSequenceWasFlushed:]): New delegate method.
- 7:41 PM Changeset in webkit [152203] by
-
- 22 edits in trunk/Source
Adopt is/toHTMLImageElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118182
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLImageElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isNativeImage):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::url):
- bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM):
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::QtPixmapRuntime::toQt):
- dom/Clipboard.cpp:
(WebCore::Clipboard::setDragImage):
- dom/Node.cpp:
(WebCore::Node::enclosingLinkEventParentOrSelf):
- editing/Editor.cpp:
(WebCore::imageElementFromImageDocument):
- html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition):
- html/HTMLImageElement.h:
(WebCore::isHTMLImageElement):
(WebCore::toHTMLImageElement):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
- html/HTMLNameCollection.cpp:
(WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatches):
- page/DragController.cpp:
(WebCore::DragController::draggableElement):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode):
- platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
(BlackBerry::WebKit::WebPage::blockZoom):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
- 6:45 PM Changeset in webkit [152202] by
-
- 2 edits in trunk/Source/WebCore
PageThrottler::shouldThrottleTimers is wrong.
https://bugs.webkit.org/show_bug.cgi?id=118210
Reviewed by Anders Carlson.
m_throttleState == PageNotThrottledState
-> page NOT throttled, so should NOT throttle timers
m_throttleState != PageNotThrottledState
-> page NOT NOT throttled, so should throttle timers
This needs cleaning up, but for now, 1 character fix.
- page/PageThrottler.h:
(WebCore::PageThrottler::shouldThrottleTimers):
-> !=
- 6:39 PM Changeset in webkit [152201] by
-
- 11 edits in trunk
Remove String::deprecatedCharactersWithNullTermination() and related code
https://bugs.webkit.org/show_bug.cgi?id=118211
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- API/JSStringRef.cpp:
(JSStringCreateWithCharactersNoCopy):
Update call to StringImpl::createWithoutCopying.
Source/WTF:
Remove String::deprecatedCharactersWithNullTermination, StringImpl::createWithTerminatingNullCharacter
and the s_hashFlagHasTerminatingNullCharacter flag. We no longer care about whether strings have a
terminating null character.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::createWithoutCopying):
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::sizeInBytes):
- wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::isolatedCopy):
- wtf/text/WTFString.cpp:
- wtf/text/WTFString.h:
Tools:
Remove all hasTerminatingNullCharacter() checks.
- TestWebKitAPI/Tests/WTF/AtomicString.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::TEST):
- 6:39 PM Changeset in webkit [152200] by
-
- 2 edits in trunk/Source/WebInspectorUI
Update Apple System fonts in auto-complete
https://bugs.webkit.org/show_bug.cgi?id=118205
<rdar://problem/14308488>
Reviewed by Joseph Pecoraro.
Update for the new Apple System font names, and remove some invalid entries.
- UserInterface/CSSKeywordCompletions.js: General cleanup. Note that
"apple-system-short-caption2" looks like it was accidentally omitted. It wasn't :)
- 6:25 PM Changeset in webkit [152199] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
https://bugs.webkit.org/show_bug.cgi?id=118122
Patch by James Craig <james@cookiecrook.com> on 2013-06-28
Reviewed by Timothy Hatcher.
Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
so that screen readers will not indicate a bogus :required/:invalid state to the user.
Minor cosmetic difference blocked by http://webkit.org/b/118162
- UserInterface/FilterBar.css:
(.filter-bar > input[type="search"]:focus):
(.filter-bar > input[type="search"]:not(:placeholder-shown)):
- UserInterface/FilterBar.js:
(WebInspector.FilterBar):
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
- UserInterface/SearchBar.css:
(.search-bar > input[type="search"]:focus):
(.search-bar > input[type="search"]:not(:placeholder-shown)):
- UserInterface/SearchBar.js:
(WebInspector.SearchBar):
- 5:09 PM Changeset in webkit [152198] by
-
- 4 edits4 adds in trunk
An element with -webkit-user-select: all should be selected on single click
https://bugs.webkit.org/show_bug.cgi?id=117864
Reviewed by Darin Adler.
Source/WebCore:
Set m_mouseDownMayStartSelect true even when the node cannot start selection
if the node was inside an element with -webkit-user-select: all.
Test: editing/selection/user-select-all-with-single-click.html
- page/EventHandler.cpp:
(WebCore::canMouseDownStartSelect):
LayoutTests:
Add tests for single clicking on an element with user-select: all.
We select the entire element regardless of whether the user had clicked on text or an image
to be consistent even though Firefox requires a double click on the latter case.
- editing/selection/user-select-all-with-image-single-click-expected.txt: Added.
- editing/selection/user-select-all-with-image-single-click.html: Added.
- editing/selection/user-select-all-with-single-click-expected.txt: Added.
- editing/selection/user-select-all-with-single-click.html: Added.
- 5:01 PM Changeset in webkit [152197] by
-
- 3 edits in trunk/Source/WebCore
Remove unused attachChildrenLazily method and make attach/detachChildren private
https://bugs.webkit.org/show_bug.cgi?id=118016
Reviewed by Darin Adler.
Merge https://chromium.googlesource.com/chromium/blink/+/009520dc31c9458e0cf71cf212fa5688c4ca68b0
No one should be manually trying to attach or detach all their children so there's
no reason for these methods to be public.
In doing this I realized that attachChildrenLazily is not used and can be removed.
I also realized that we were detaching all our children before the ShadowRoots which
is sad since the InsertionPoints will call detach() on them as well, and then when we
call ContainerNode::detach at the end of Element::detach we'll go detach them again!
This patch makes it so we only go through and detach them twice instead of three times.
In the future we should figure out a way to only do this once.
- dom/ContainerNode.h:
- dom/Element.cpp:
(WebCore::Element::detach):
- 4:57 PM Changeset in webkit [152196] by
-
- 4 edits2 adds in trunk
[Mac] Crash when loading is stopped from -didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=118209
<rdar://problem/14259249>
Reviewed by Brady Eidson.
Test: TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): Added yet another check for reachedTerminalState().
- 4:40 PM Changeset in webkit [152195] by
-
- 2 edits in trunk/Tools
[Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=118208
Reviewed by Mark Rowe.
Newer versions of clang use a default template depth of 128, but this
is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
previous default.
Clang lowered the default to keep recursive template instantiation
from overflowing the stack (see <rdar://problem/13935016>), but
TestWebKitAPI's C++ files don't trigger a stack overflow even with the
higher limit. If for some reason this starts happening then we can
lower the limit back down.
- TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
- 4:11 PM Changeset in webkit [152194] by
-
- 6 edits in trunk/Source/WebCore
Cached pages don't update their backing scale factor when it changes
https://bugs.webkit.org/show_bug.cgi?id=118206
-and-
<rdar://problem/14261627>
Reviewed by Tim Horton.
It is not sufficient to mark pages in the PageCache as needing a full style
recalc. We also need to ensure that the RenderLayerCompositors for the CachesPages
get updated.
Keep track of whether device scale has been updated with
m_needsDeviceScaleChanged. If that has been marked true, then restore() will call
Frame::deviceOrPageScaleFactorChanged().
- history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
- history/CachedPage.h:
(WebCore::CachedPage::markForDeviceScaleChanged):
Propagate markForDeviceScaleChanged() to all of the CachedPages.
- history/PageCache.cpp:
(WebCore::PageCache::markPagesForDeviceScaleChanged):
- history/PageCache.h:
Call PageCache::markPagesForDeviceScaleChanged()
- page/Page.cpp:
(WebCore::Page::setDeviceScaleFactor):
- 3:48 PM Changeset in webkit [152193] by
-
- 2 edits in trunk/Source/WebCore
Added template parameters to std::min to fix compile errors in Visual Studio x64.
https://bugs.webkit.org/show_bug.cgi?id=118204
Reviewed by Geoffrey Garen.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeURLToDataObject): Added <unsigned> to std::min.
(WebCore::createGlobalImageFileDescriptor): Added <int> to std::min.
- 3:43 PM Changeset in webkit [152192] by
-
- 5 edits in trunk/Source/WebCore
Added WebGL files to Windows build.
https://bugs.webkit.org/show_bug.cgi?id=118200
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj: Added WebGL files, removed unused GraphicsContext3DOpenGLES.cpp.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added WebGL files, removed unused GraphicsContext3DOpenGLES.cpp.
- platform/graphics/cairo/GLContext.cpp: Only include GLContextEGL.h or GLContextGLX.h if they're needed.
- platform/graphics/cg/GraphicsContext3DCG.cpp: Only include GraphicsContext3DNEON.h if it's needed.
- 3:21 PM Changeset in webkit [152191] by
-
- 2 edits in trunk/Tools
[Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
https://bugs.webkit.org/show_bug.cgi?id=118195
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-06-28
Reviewed by Daniel Bates.
Currently, ports that use jhbuild fail to determine jhbuild directory
when "webKitBranchBuild" git configuration property is enabled. To reproduce
that issue in Efl port, enable that flag in .git/config, switch to a git branch
other than "master" and try to build webkit. The build will fail to
locate dependencies due to lack of pkg-config paths which should be set
by jhbuild.
For more details about "webKitBranchBuild" option, see:
https://trac.webkit.org/wiki/UsingGitWithWebKit
- Scripts/webkitdirs.pm:
(getJhbuildPath):
- 3:15 PM Changeset in webkit [152190] by
-
- 11 edits in trunk/Source/WebKit2
[wk2] WKView shouldn't force scrolling off if shouldClipToVisibleRect is set
https://bugs.webkit.org/show_bug.cgi?id=118174
<rdar://problem/14301175>
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateViewExposedRect]):
Pass whether or not clips-to-visibleRect is enabled down to the WebPageProxy.
(-[WKView setMinimumSizeForAutoLayout:]):
Disable scrolling when using autolayout instead of when using clips-to-visibleRect.
(-[WKView setShouldClipToVisibleRect:]):
Clipping to the WKView's visibleRect does not strictly require scrolling to be disabled,
and in fact there are cases (RTL/TB pagination) where we *must* scroll, even when the view
is big enough to fit the content (the case clip-to-visibleRect was added for).
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged):
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
Keep track of and forward to the drawing area whether or not clips-to-visibleRect is enabled.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setClipsToExposedRect): Added.
(WebKit::DrawingArea::didChangeScrollOffsetForAnyFrame): Added a missing space.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewExposedRectChanged):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Forward clips-to-visibleRect enabled state to the drawing area.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add storage for m_clipsToExposedRect.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::updateMainFrameClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Check m_clipsToExposedRect instead of the main-frame's isScrollable() to determine
whether we should tell our TiledBackings to clip to the exposed rect we provide.
We don't need to listen to mainFrameScrollabilityChanged anymore.
- 2:48 PM Changeset in webkit [152189] by
-
- 2 edits in branches/safari-537-branch/Tools
Merged r152188. <rdar://problem/14306452>
- 2:45 PM Changeset in webkit [152188] by
-
- 2 edits in trunk/Tools
WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
https://bugs.webkit.org/show_bug.cgi?id=118201
Reviewed by Dean Jackson.
- WebKitTestRunner/mac/main.mm:
(main):
Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
setAutomaticDashSubstitutionEnabled are not exposed on WKView.
- 1:40 PM Changeset in webkit [152187] by
-
- 2 edits in trunk/Source/WebKit2
Stale occlusion state after moving page back into window
https://bugs.webkit.org/show_bug.cgi?id=118202
Reviewed by Anders Carlsson.
We need to update the occlusion state when the page goes back into the window.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
- update occlusion state.
- 1:38 PM Changeset in webkit [152186] by
-
- 9 edits in trunk/Tools
Upstream WebKit Nightly’s WebKitLauncher
https://bugs.webkit.org/show_bug.cgi?id=117418
Reviewed by Mark Rowe.
Literal patch from Nightly's OpenSource repo.
- WebKitLauncher/Configurations/Base.xcconfig:
- WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
- WebKitLauncher/Info.plist:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncherURLProtocol.m:
(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
(-[WebKitLauncherURLProtocol resourceNotFound]):
- WebKitLauncher/WebKitNightlyEnablerSparkle.m:
(initializeSparkle):
- WebKitLauncher/main.m:
(determineExecutablePath):
(currentMacOSXVersion):
(main):
- WebKitLauncher/start.html:
- 12:59 PM Changeset in webkit [152185] by
-
- 3 edits2 adds in trunk
-webkit-line-break: after-white-space sometimes truncates DOM on copy & paste
https://bugs.webkit.org/show_bug.cgi?id=118164
Reviewed by Sam Weinig.
Source/WebCore:
We can't assume that all subsequent ancestors contain exactly one child since they could have been
added in the first if statement matching: currentNode->parentNode() != rootNode && isRemovableBlock(currentNode)
Exit early when we encounter such an ancestor since removing its ancestor (that contains multiple children
some of which aren't in nodesToRemove) can clobber more nodes than we're allowed to remove.
Test: editing/pasteboard/simplfiying-markup-should-not-strip-content.html
- editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove):
LayoutTests:
Add a regression test.
- editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt: Added.
- editing/pasteboard/simplfiying-markup-should-not-strip-content.html: Added.
- 12:55 PM Changeset in webkit [152184] by
-
- 3 edits in trunk/LayoutTests
media/video-currentTime.html flakey
https://bugs.webkit.org/show_bug.cgi?id=118198
Reviewed by Jessie Berlin.
Update video-currentTime.html so that it listens for timeupdate events, and ends the test
after the first one with a >0 currentTime. Add a 3s watchdog for the failure case.
- media/video-currentTime-expected.txt:
- media/video-currentTime.html:
- 12:09 PM Changeset in webkit [152183] by
-
- 7 edits2 adds in trunk/Source
Coordinated Graphics: Separate CoordinatedLayerTreeHost into CoordinatedLayerTreeHost and CompositingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=104360
Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-06-28
Reviewed by Noam Rosenthal.
The CoordinatedLayerTreeHost has too many responsibilities. It
implements LayerTreeHost, GraphicsLayerClient,
CoordinatedGraphicsLayerClient, CoordinatedImageBacking::Client,
UpdateAtlas::Client, GraphicsLayerFactory and
WebCustomFilterProgramProxyClient.
This refactoring reduces the responsibilities of CoordinatedLayerTreeHost.
This patch introduces a new class called CompositingCoordinator, which
takes the responsibility of managing compositing resources in
WebProcess.
CoordinatedLayerTreeHost is responsible only for the scheduling and
IPC-specific stuff, which are relevant only for WebKit2.
No new tests, covered by existing tests.
Source/WebCore:
- CMakeLists.txt:
- Target.pri:
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Added.
(WebCore::CompositingCoordinator::create):
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::setRootCompositingLayer):
(WebCore::CompositingCoordinator::sizeDidChange):
(WebCore::CompositingCoordinator::flushPendingLayerChanges):
(WebCore::CompositingCoordinator::syncDisplayState):
(WebCore::CompositingCoordinator::nextAnimationServiceTime):
(WebCore::CompositingCoordinator::clearPendingStateChanges):
(WebCore::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebCore::CompositingCoordinator::createRootLayer):
(WebCore::CompositingCoordinator::syncLayerState):
(WebCore::CompositingCoordinator::createImageBackingIfNeeded):
(WebCore::CompositingCoordinator::createImageBacking):
(WebCore::CompositingCoordinator::updateImageBacking):
(WebCore::CompositingCoordinator::clearImageBackingContents):
(WebCore::CompositingCoordinator::removeImageBacking):
(WebCore::CompositingCoordinator::flushPendingImageBackingChanges):
(WebCore::CompositingCoordinator::notifyAnimationStarted):
(WebCore::CompositingCoordinator::notifyFlushRequired):
(WebCore::CompositingCoordinator::paintContents):
(WebCore::CompositingCoordinator::createGraphicsLayer):
(WebCore::CompositingCoordinator::deviceScaleFactor):
(WebCore::CompositingCoordinator::pageScaleFactor):
(WebCore::CompositingCoordinator::createUpdateAtlas):
(WebCore::CompositingCoordinator::removeUpdateAtlas):
(WebCore::CompositingCoordinator::visibleContentsRect):
(WebCore::CompositingCoordinator::mainContentsLayer):
(WebCore::CompositingCoordinator::setVisibleContentsRect):
(WebCore::CompositingCoordinator::deviceOrPageScaleFactorChanged):
(WebCore::CompositingCoordinator::detachLayer):
(WebCore::CompositingCoordinator::commitScrollOffset):
(WebCore::CompositingCoordinator::renderNextFrame):
(WebCore::CompositingCoordinator::purgeBackingStores):
(WebCore::CompositingCoordinator::paintToSurface):
(WebCore::CompositingCoordinator::scheduleReleaseInactiveAtlases):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h: Added.
(WebCore::CompositingCoordinator::clearRootLayer):
(WebCore::CompositingCoordinator::rootLayer):
(WebCore::CompositingCoordinator::state):
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::forceRepaint):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::willSyncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesForAnimations):
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
(WebKit::CoordinatedLayerTreeHost::removeCustomFilterProgramProxy):
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::createPageOverlayLayer):
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/LayerTreeHost.h:
- 11:57 AM Changeset in webkit [152182] by
-
- 6 edits in trunk/Source/WebKit2
Make the UI process run the Java Updater
https://bugs.webkit.org/show_bug.cgi?id=118197
<rdar://problem/14255677>
Reviewed by Sam Weinig.
Patch the relevant NSWorkspace method and pipe through the request to launch the Java updater to the UI process.
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::replacedNSWorkspace_launchApplicationAtURL_options_configuration_error):
(WebKit::initializeCocoaOverrides):
(WebKit::PluginProcess::launchApplicationAtURL):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.messages.in:
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::isJavaUpdaterURL):
(WebKit::shouldLaunchApplicationAtURL):
(WebKit::PluginProcessProxy::launchApplicationAtURL):
- 11:47 AM Changeset in webkit [152181] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r152135.
http://trac.webkit.org/changeset/152135
https://bugs.webkit.org/show_bug.cgi?id=118199
Rolling out temporary patch used for debugging the test bots
(Requested by rfong on #webkit).
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):
- 11:08 AM Changeset in webkit [152180] by
-
- 4 edits in trunk/LayoutTests
Update TestExpectations so new Shapes tests are skipped where the old ones were
https://bugs.webkit.org/show_bug.cgi?id=118192
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-28
Reviewed by Brent Fulgham.
Shapes still aren't enabled on some ports, so skip the tests there.
As part of this patch, it was discovered that they work on EFL, so the
skipping has been removed from there.
- platform/efl/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 11:07 AM Changeset in webkit [152179] by
-
- 3 edits in trunk/Tools
[EFL] back/forward keyboard shortcuts are non-intuitive
https://bugs.webkit.org/show_bug.cgi?id=118193
Patch by Balazs Kelemen <b.kelemen@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.
Changed shortcuts for go-back/go-forward to alt+left and alt+right.
- EWebLauncher/main.c:
(on_key_down):
- MiniBrowser/efl/main.c:
(on_key_down):
- 11:00 AM Changeset in webkit [152178] by
-
- 3 edits2 adds in trunk
SVG relayout problem when displayed with different image box heights
https://bugs.webkit.org/show_bug.cgi?id=118140
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-28
Reviewed by Philip Rogers.
Source/WebCore:
If the root element is an SVG, its position and height are affected
by the view height.
Test: svg/as-image/same-source-different-height.html
- rendering/RenderView.cpp:
(WebCore::RenderView::layout):
LayoutTests:
- svg/as-image/same-source-different-height-expected.html: Added.
- svg/as-image/same-source-different-height.html: Added.
- 10:54 AM Changeset in webkit [152177] by
-
- 2 edits in trunk/Source/WebKit2
WARN_UNUSED_RESULT can't be used in API headers, but WKBundlePageExtendIncrementalRenderingSuppression tries to
https://bugs.webkit.org/show_bug.cgi?id=118196
<rdar://problem/14303613>
Reviewed by Anders Carlsson.
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- 10:54 AM Changeset in webkit [152176] by
-
- 3 edits in trunk/Tools
Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
https://bugs.webkit.org/show_bug.cgi?id=118194.
Reviewed by Brent Fulgham.
- DumpRenderTree/win/DumpRenderTree.cpp:
(dllLauncherEntryPoint):
- WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint):
- 10:31 AM Changeset in webkit [152175] by
-
- 12 edits3 deletes in trunk/Source/WebCore
Allow some LayoutPoint and LayoutSize conversions to be inlined
https://bugs.webkit.org/show_bug.cgi?id=118167
Reviewed by Ryosuke Niwa.
Construction of FloatSize from LayoutSize, and FloatPoint's move(const LayoutSize&)
and moveBy(const LayoutPoint&) were not inlined, and showed up on some profiles.
Make them inlined by removing the overloaded functions, and instead providing
conversion operators from LayoutSize to FloatSize, and LayoutPoint to FloatPoint.
Do the same to allow a LayoutRect to be converted to a FloatRect.
This is nice because it removes pollution of FloatRect, FloatPoint and FloatSize with
Layout* entirely.
Remove Qt-specific conversions on LayoutRect, LayoutPoint and LayoutSize. Qt can
convert via IntRect/FloatRect as necessary.
- platform/graphics/FloatPoint.cpp:
- platform/graphics/FloatPoint.h:
(WebCore::FloatPoint::move):
(WebCore::FloatPoint::moveBy):
- platform/graphics/FloatRect.cpp:
- platform/graphics/FloatRect.h:
- platform/graphics/FloatSize.cpp:
- platform/graphics/FloatSize.h:
- platform/graphics/LayoutPoint.h:
(WebCore::LayoutPoint::operator FloatPoint):
- platform/graphics/LayoutRect.cpp:
- platform/graphics/LayoutRect.h:
(WebCore::LayoutRect::operator FloatRect):
- platform/graphics/LayoutSize.h:
(WebCore::LayoutSize::operator FloatSize):
- 10:13 AM Changeset in webkit [152174] by
-
- 3 edits in trunk/Tools
Unreviewed build fix for AppleWin port. Fix some file paths.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
- 9:50 AM Changeset in webkit [152173] by
-
- 5 edits in branches/safari-537-branch/LayoutTests
Merged r151942. <rdar://problem/14299780>
- 9:39 AM Changeset in webkit [152172] by
-
- 2 edits in trunk/LayoutTests
accessibility/media-element.html does not support platforms without subroles
https://bugs.webkit.org/show_bug.cgi?id=118187
Reviewed by Chris Fleizach.
Update the test to be more friendly with platforms not supporting subroles.
- accessibility/media-element.html: Updated test.
- 9:23 AM Changeset in webkit [152171] by
-
- 4 edits2 adds in trunk/Tools
Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
https://bugs.webkit.org/show_bug.cgi?id=118160.
Reviewed by Brent Fulgham.
- WinLauncher/AccessibilityDelegate.cpp: Added.
(AccessibilityDelegate::QueryInterface):
(AccessibilityDelegate::AddRef):
(AccessibilityDelegate::Release):
(AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
(AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
- WinLauncher/AccessibilityDelegate.h: Added.
(AccessibilityDelegate::AccessibilityDelegate):
- WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint):
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
- 9:11 AM WebKitIDL edited by
- Remove ExtendsDOMGlobalObject and IsWorkerContext after r152168 (diff)
- 9:08 AM Changeset in webkit [152170] by
-
- 2 edits in trunk/Tools
Clean up temporary files created by the bindings test script
https://bugs.webkit.org/show_bug.cgi?id=118189
Reviewed by Kentaro Hara.
Remove temporary files created by preprocess-idls.pl script after
the bindings tests are executed.
Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.main):
- 9:07 AM Changeset in webkit [152169] by
-
- 3 edits in trunk/Source/WebKit/win
[WinCairo] Compilation error.
https://bugs.webkit.org/show_bug.cgi?id=118131
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-28
Reviewed by Brent Fulgham.
- Interfaces/IWebView.idl: Include needed accessibility interface.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::AXFinishFrameLoad): Accessibility methods should not be inside FULLSCREEN_API ifdef.
- 9:01 AM Changeset in webkit [152168] by
-
- 7 edits in trunk/Source/WebCore
Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes
https://bugs.webkit.org/show_bug.cgi?id=118191
Reviewed by Kentaro Hara.
Remove WebKit-specific [IsWorkerGlobalScope] and [ExtendsDOMGlobalObject] IDL
extended attributes and update the JSC bindings generator to figure this out
on its own.
No new tests, no behavior change.
- bindings/scripts/CodeGeneratorJS.pm:
(IsDOMGlobalObject):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
- bindings/scripts/IDLAttributes.txt:
- page/DOMWindow.idl:
- workers/DedicatedWorkerGlobalScope.idl:
- workers/SharedWorkerGlobalScope.idl:
- workers/WorkerGlobalScope.idl:
- 8:58 AM Changeset in webkit [152167] by
-
- 80 edits1 copy2 moves in trunk
Introduce SVGGraphicsElement IDL interface
https://bugs.webkit.org/show_bug.cgi?id=118178
Reviewed by Kentaro Hara.
Source/WebCore:
Introduce SVGGraphicsElement IDL interface as per the latest SVG
specification:
SVGGraphicsElement is a merge of SVGLocatable and SVGTransformable.
This is one step towards simplifying inheritance in SVG and matching
the latest SVG2 specification.
No new tests, already covered by existing tests.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
- rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::RenderSVGEllipse):
- rendering/svg/RenderSVGEllipse.h:
- rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::RenderSVGPath):
- rendering/svg/RenderSVGPath.h:
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
- rendering/svg/RenderSVGResourceMarker.cpp:
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::nonScalingStrokeTransform):
(WebCore::RenderSVGShape::shouldGenerateMarkerPositions):
- rendering/svg/RenderSVGShape.h:
- rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/svg/RenderSVGTransformableContainer.h:
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::SVGAElement):
(WebCore::SVGAElement::parseAttribute):
(WebCore::SVGAElement::svgAttributeChanged):
(WebCore::SVGAElement::defaultEventHandler):
(WebCore::SVGAElement::supportsFocus):
(WebCore::SVGAElement::isURLAttribute):
- svg/SVGAElement.h:
- svg/SVGAElement.idl:
- svg/SVGAllInOne.cpp:
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::SVGCircleElement):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):
- svg/SVGCircleElement.h:
- svg/SVGCircleElement.idl:
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::SVGClipPathElement):
(WebCore::SVGClipPathElement::parseAttribute):
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):
- svg/SVGClipPathElement.h:
- svg/SVGClipPathElement.idl:
- svg/SVGDefsElement.cpp:
(WebCore::SVGDefsElement::SVGDefsElement):
- svg/SVGDefsElement.h:
- svg/SVGDefsElement.idl:
- svg/SVGElement.h:
(WebCore::SVGElement::isSVGGraphicsElement):
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::SVGEllipseElement):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):
- svg/SVGEllipseElement.h:
- svg/SVGEllipseElement.idl:
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
(WebCore::SVGForeignObjectElement::rendererIsNeeded):
- svg/SVGForeignObjectElement.h:
- svg/SVGForeignObjectElement.idl:
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::SVGGElement):
(WebCore::SVGGElement::parseAttribute):
(WebCore::SVGGElement::svgAttributeChanged):
- svg/SVGGElement.h:
- svg/SVGGElement.idl:
- svg/SVGGraphicsElement.cpp: Renamed from Source/WebCore/svg/SVGStyledTransformableElement.cpp.
(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::~SVGGraphicsElement):
(WebCore::SVGGraphicsElement::getCTM):
(WebCore::SVGGraphicsElement::getScreenCTM):
(WebCore::SVGGraphicsElement::animatedLocalTransform):
(WebCore::SVGGraphicsElement::supplementalTransform):
(WebCore::SVGGraphicsElement::isSupportedAttribute):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
(WebCore::SVGGraphicsElement::nearestViewportElement):
(WebCore::SVGGraphicsElement::farthestViewportElement):
(WebCore::SVGGraphicsElement::getBBox):
(WebCore::SVGGraphicsElement::createRenderer):
(WebCore::SVGGraphicsElement::toClipPath):
- svg/SVGGraphicsElement.h: Renamed from Source/WebCore/svg/SVGStyledTransformableElement.h.
(WebCore::SVGGraphicsElement::localCoordinateSpaceTransform):
(WebCore::SVGGraphicsElement::synchronizeRequiredFeatures):
(WebCore::SVGGraphicsElement::synchronizeRequiredExtensions):
(WebCore::SVGGraphicsElement::synchronizeSystemLanguage):
(WebCore::toSVGGraphicsElement):
- svg/SVGGraphicsElement.idl: Copied from Source/WebCore/svg/SVGForeignObjectElement.idl.
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::SVGImageElement):
(WebCore::SVGImageElement::isPresentationAttribute):
(WebCore::SVGImageElement::collectStyleForPresentationAttribute):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):
(WebCore::SVGImageElement::attach):
(WebCore::SVGImageElement::insertedInto):
(WebCore::SVGImageElement::addSubresourceAttributeURLs):
(WebCore::SVGImageElement::didMoveToNewDocument):
- svg/SVGImageElement.h:
- svg/SVGImageElement.idl:
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::SVGLineElement):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):
- svg/SVGLineElement.h:
- svg/SVGLineElement.idl:
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::insertedInto):
(WebCore::SVGPathElement::removedFrom):
- svg/SVGPathElement.h:
- svg/SVGPathElement.idl:
- svg/SVGPatternElement.cpp:
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::SVGPolyElement):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGPolyElement.h:
- svg/SVGPolygonElement.idl:
- svg/SVGPolylineElement.idl:
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::SVGRectElement):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):
- svg/SVGRectElement.h:
- svg/SVGRectElement.idl:
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::didMoveToNewDocument):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):
- svg/SVGSVGElement.h:
- svg/SVGSVGElement.idl:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::localCoordinateSpaceTransform):
- svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::SVGSwitchElement):
- svg/SVGSwitchElement.h:
- svg/SVGSwitchElement.idl:
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::finishParsingChildren):
- svg/SVGUseElement.h:
- svg/SVGUseElement.idl:
LayoutTests:
Rebaseline js/global-constructors-attributes.html test case now that
SVGGraphicsElement is exposed on the global Window object.
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- 8:00 AM Changeset in webkit [152166] by
-
- 2 edits in trunk/Source/WebKit2
Don't fire process-became-responsive callback when disconnecting it.
<http://webkit.org/b/118166>
Reviewed by Anders Carlsson.
When disconnecting from a web process, call ResponsivenessTimer::invalidate() instead of
stop() to avoid firing the didBecomeResponsive() callback.
This lets the UI process react faster to actually unresponsive processes.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
- 7:52 AM WebKitIDL edited by
- Update documentation for [GlobalContext] after r152100 (diff)
- 7:49 AM Changeset in webkit [152165] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][GTK] 100% CPU usage rendering a page with animations
https://bugs.webkit.org/show_bug.cgi?id=117703
Reviewed by Martin Robinson.
Unconditionally update the value of m_lastFlushTime in
::flushAndRenderLayers. By doing that we avoid a neverending
sequence of layer flushes that happened when m_lastFlushTime==0
and flushPendingLayerChanges() was false. In that situation the
value m_lastFlushTime was never updated so a new flush was always
rescheduled.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::flushAndRenderLayers):
- 7:29 AM Changeset in webkit [152164] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping failing tests, and mathml tests because not yet supported.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-28
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- 6:31 AM Changeset in webkit [152163] by
-
- 2 edits in trunk
[Autotools] Properly quote harfbuzz-icu pkg-config check
https://bugs.webkit.org/show_bug.cgi?id=118186
Patch by Sean Bright <sean@malleable.com> on 2013-06-28
Reviewed by Carlos Garcia Campos.
A secondary test was added in r150963 to check for harfbuzz-icu
when it was split into two packages, but the test is not properly
quoted. If the test fails you get an error about missing
version "./configure.9.8" instead of the expected "0.9.8."
- Source/autotools/FindDependencies.m4:
- 5:28 AM Changeset in webkit [152162] by
-
- 9 edits in trunk
Add new schemes to content utils.
https://bugs.webkit.org/show_bug.cgi?id=118181
Reviewed by Christophe Dumez.
Source/WebCore:
According to latest content handler spec, new schemes are added to it.
Those are "geo, magnet, sip, ssh and xmpp".
http://www.w3.org/html/wg/drafts/html/master/webappapis.html#custom-handlers
Tests: fast/dom/register-protocol-handler.html
fast/dom/unregister-protocol-handler.html
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist):
LayoutTests:
Add new schemes as well as change SYNTAX_ERR, SECURITY_ERR.
- fast/dom/register-protocol-handler-expected.txt:
- fast/dom/register-protocol-handler.html:
- fast/dom/unregister-protocol-handler-expected.txt:
- fast/dom/unregister-protocol-handler.html:
- platform/efl/fast/dom/register-protocol-handler-expected.txt:
- platform/efl/fast/dom/unregister-protocol-handler-expected.txt:
- 4:14 AM Changeset in webkit [152161] by
-
- 2 edits in trunk/Source/WebCore
Avoid duplicating hostWindow() call in ScrollView.cpp
https://bugs.webkit.org/show_bug.cgi?id=118168
Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.
Remove redundant hostWindow() calls in ScrollView.cpp.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::contentsToScreen):
(WebCore::ScrollView::screenToContents):
(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::updateOverhangAreas):
(WebCore::ScrollView::addPanScrollIcon):
(WebCore::ScrollView::removePanScrollIcon):
- 4:00 AM Changeset in webkit [152160] by
-
- 3 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Unskip and reorganize tests no longer failing in GTK-WK and GTK-WK2
https://bugs.webkit.org/show_bug.cgi?id=118180
Unreviewed GTK gardening.
Patch by Simon Pena <simon.pena@samsung.com> on 2013-06-28
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 3:59 AM Changeset in webkit [152159] by
-
- 2 edits in trunk/Source/WebKit/gtk
Use gtk_widget_get_preferred_size instead of deprecated gtk_widget_get_requisition
https://bugs.webkit.org/show_bug.cgi?id=118177
Patch by Iago Toral Quiroga <itoral@igalia.com> on 2013-06-28
Reviewed by Carlos Garcia Campos.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::contentsSizeChanged):
- 3:18 AM Changeset in webkit [152158] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, EFL rebaseline.
SECURITY_ERR and SYNTAX_ERR have been changed with SecurityError and SyntaxError since r135162.
- platform/efl/fast/dom/register-protocol-handler-expected.txt:
- platform/efl/fast/dom/unregister-protocol-handler-expected.txt:
- 2:33 AM Changeset in webkit [152157] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix GTK build after r152156.
- GNUmakefile.list.am:
- 1:34 AM Changeset in webkit [152156] by
-
- 57 edits1 delete in trunk/Source/WebCore
Merge SVGLangSpace into SVGElement
https://bugs.webkit.org/show_bug.cgi?id=118170
Reviewed by Kentaro Hara.
Remove SVGLangSpace IDL interface and move its attributes to SVGElement
to match the latest specification and simplify inheritance in SVG:
No new tests, no behavior change.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- svg/SVGAElement.h:
- svg/SVGAElement.idl:
- svg/SVGCircleElement.h:
- svg/SVGCircleElement.idl:
- svg/SVGClipPathElement.h:
- svg/SVGClipPathElement.idl:
- svg/SVGDefsElement.h:
- svg/SVGDefsElement.idl:
- svg/SVGDescElement.h:
- svg/SVGDescElement.idl:
- svg/SVGElement.cpp:
(WebCore::SVGElement::parseAttribute):
- svg/SVGElement.h:
- svg/SVGElement.idl:
- svg/SVGEllipseElement.h:
- svg/SVGEllipseElement.idl:
- svg/SVGFEImageElement.h:
- svg/SVGFEImageElement.idl:
- svg/SVGFilterElement.h:
- svg/SVGFilterElement.idl:
- svg/SVGForeignObjectElement.h:
- svg/SVGForeignObjectElement.idl:
- svg/SVGGElement.h:
- svg/SVGGElement.idl:
- svg/SVGImageElement.h:
- svg/SVGImageElement.idl:
- svg/SVGLangSpace.idl: Removed.
- svg/SVGLineElement.h:
- svg/SVGLineElement.idl:
- svg/SVGMarkerElement.h:
- svg/SVGMarkerElement.idl:
- svg/SVGMaskElement.h:
- svg/SVGMaskElement.idl:
- svg/SVGPathElement.h:
- svg/SVGPathElement.idl:
- svg/SVGPatternElement.h:
- svg/SVGPatternElement.idl:
- svg/SVGPolyElement.h:
- svg/SVGPolygonElement.idl:
- svg/SVGPolylineElement.idl:
- svg/SVGRectElement.h:
- svg/SVGRectElement.idl:
- svg/SVGSVGElement.h:
- svg/SVGSVGElement.idl:
- svg/SVGStyleElement.h:
- svg/SVGStyleElement.idl:
- svg/SVGSwitchElement.h:
- svg/SVGSwitchElement.idl:
- svg/SVGSymbolElement.h:
- svg/SVGSymbolElement.idl:
- svg/SVGTextContentElement.h:
- svg/SVGTextContentElement.idl:
- svg/SVGTitleElement.h:
- svg/SVGTitleElement.idl:
- svg/SVGUseElement.h:
- svg/SVGUseElement.idl:
- 1:28 AM Changeset in webkit [152155] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] MiniBrowser doesn't solve the saving location when there are no XDG settings
https://bugs.webkit.org/show_bug.cgi?id=117538
Patch by Andres Gomez <Andres Gomez> on 2013-06-28
Reviewed by Carlos Garcia Campos.
If the XDG specification is not working for the "Downloads"
directory, let's use HOME as fallback.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkitDownloadDecideDestination):
- 1:20 AM Changeset in webkit [152154] by
-
- 4 edits in trunk/Source/WebCore
Use & instead of | in the value of [CallWith]
https://bugs.webkit.org/show_bug.cgi?id=118054
Reviewed by Kentaro Hara.
[CallWith=ScriptExecutionContext|ScriptState] meant that both the
ScriptExecutionContext AND the ScriptState would be passed as
arguments to the implementation (not one OR the other).
This patch changes the semantics for those IDL extended attributes
to make it less confusing. Proper usage is now:
[CallWith=ScriptExecutionContext&ScriptState]
No new tests, covered by existing bindings tests.
- bindings/scripts/CodeGenerator.pm:
(ExtendedAttributeContains):
- bindings/scripts/test/TestObj.idl:
- page/Console.idl:
- 12:34 AM Changeset in webkit [152153] by
-
- 2 edits1 add in trunk/Source/WebKit2
[EFL][WK2] Add spellcheck API tests in unit tests.
https://bugs.webkit.org/show_bug.cgi?id=118123
Patch by Dariusz Frankiewicz <Dariusz Frankiewicz> on 2013-06-28
Reviewed by Christophe Dumez.
According to discussion in bug https://bugs.webkit.org/show_bug.cgi?id=113742
we're moving spelling tests from layout tests to unit tests.
- UIProcess/API/efl/tests/resources/spelling_selection_tests.html: Added.
New file is needed to make tests, with and without spellcheck attribute.
File contains basic site with content editable fields and buttons which select
different parts of misspelled words.
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(countContextMenuItems):
Added method used to count number of items in context menu.
