Timeline



Nov 23, 2013:

8:20 AM Changeset in webkit [159731] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Remove lint from expected result.

Unreviewed.

  • platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
6:35 AM Changeset in webkit [159730] by calvaris@igalia.com
  • 41 edits
    3 deletes in trunk

[GStreamer] Remove 0.10 codepath
​https://bugs.webkit.org/show_bug.cgi?id=124534

Reviewed by Philippe Normand.

.:

  • Source/cmake/OptionsEfl.cmake: Removed GST_API_VERSION_1

definition.

Source/WebCore:

All GStreamer ports are using 1.0 now so we remove the 0.10
codepath.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters: Removed

GStreamerVersioning.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(onGStreamerWavparsePadAddedCallback): Removed.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Replaced webkitGstPipelineGetBus and removed 0.10 codepath.
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
Replaced webkitGstPipelineGetBus.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::copyGstreamerBuffersToAudioChannel):
(WebCore::onAppsinkPullRequiredCallback): Removed 0.10 codepath.
(WebCore::AudioFileReader::~AudioFileReader): Replaced
webkitGstPipelineGetBus and removed 0.10 codepath.
(WebCore::AudioFileReader::handleSample): Left as only codepath.
(WebCore::AudioFileReader::handleBuffer): Removed.
(WebCore::AudioFileReader::handleNewDeinterleavePad): Removed 0.10
codepath.
(WebCore::AudioFileReader::plugDeinterleave): Replaced
getGstAudioCaps.
(WebCore::AudioFileReader::decodeAudioForBusCreation): Replaced
webkitGstPipelineGetBus.
(WebCore::AudioFileReader::createBus): Removed 0.10 codepath.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(getGStreamerMonoAudioCaps):
(webKitWebAudioGStreamerChannelPosition): Removed 0.10 codepath.
(webkit_web_audio_src_class_init): Replaced
setGstElementClassMetadata.
(webkit_web_audio_src_init):
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcFinalize):
(webKitWebAudioSrcLoop): Removed 0.10 codepath.

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:

Removed checks for 1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::GstElement):
(WTF::GstPad):
(WTF::GstPadTemplate):
(WTF::GstTask):
(WTF::GstBus):
(WTF::GstElementFactory):
(WTF::adoptGRef): Replaced gstObjectIsFloating.
(WTF::refGRef): Replaced webkitGstObjectRefSink.
(WTF::GstTagList):
(WTF::GstSample): Removed checks for 1.0 as it is the only
codepath now.

  • platform/graphics/gstreamer/GRefPtrGStreamer.h: Removed checks

for 1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::webkitGstGhostPadFromStaticTemplate):
(WebCore::getVideoSizeAndFormatFromCaps):
(WebCore::createGstBuffer):
(WebCore::createGstBufferForData):
(WebCore::getGstBufferDataPointer):
(WebCore::mapGstBuffer):
(WebCore::unmapGstBuffer): Moved here from GstVersioning and added
to WebCore namespace.

  • platform/graphics/gstreamer/GStreamerUtilities.h:

(WebCore::webkitGstCheckVersion): Moved here from GstVersioning
and added to WebCore namespace.

  • platform/graphics/gstreamer/GStreamerVersioning.cpp: Removed.
  • platform/graphics/gstreamer/GStreamerVersioning.h: Removed.
  • platform/graphics/gstreamer/ImageGStreamer.h: Removed checks for

1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp:

(ImageGStreamer::ImageGStreamer): Removed 0.10 codepath.
(ImageGStreamer::~ImageGStreamer): Removed checks for 1.0 as it is
the only codepath now.

  • platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:

Removed checks for 1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::setAudioStreamPropertiesCallback): Removed 0.10 codepath.
(WebCore::mediaPlayerPrivateTextChangedCallback): Removed checks
for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::isAvailable): Replaced
gPlaybinName.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Removed checks for 1.0 and replaced webkitGstPipelineGetBus.
(WebCore::MediaPlayerPrivateGStreamer::duration): Removed 0.10
codepath.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
Removed checks for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::buffered): Replaced
gPercentMax.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Removed
0.10 codepath.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
Removed checks for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::totalBytes): Removed 0.10
codepath.
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Replaced
gPlaybinName and webkitGstPipelineGetBus and removed checks for
1.0.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Removed checks for 1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::paint): Removed 0.10
codepath.

  • platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
  • platform/graphics/gstreamer/TextCombinerGStreamer.h:
  • platform/graphics/gstreamer/TextSinkGStreamer.cpp:
  • platform/graphics/gstreamer/TextSinkGStreamer.h:
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Removed

checks for 1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkRender): Removed 0.10 codepath and added WebCore
as createGstBuffer namespace.
(webkitVideoSinkSetCaps): Removed 0.10 codepath.
(webkitVideoSinkProposeAllocation): Removed checks for 1.0 as it
is the only codepath now.
(webkitVideoSinkMarshalVoidAndMiniObject): Removed as it was 0.10.
(webkit_video_sink_class_init): Removed 0.10 codepath and replaced
setGstElementClassMetadata.

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:

Removed checks for 1.0 as it is the only codepath now.

  • platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:

(webkit_media_src_class_init): Replaced
setGstElementClassMetadata.
(webKitMediaSrcAddSrc): Added WebCore namespace to
webkitGstGhostPadFromStaticTemplate.
(MediaSourceClientGstreamer::didReceiveData): Added WebCore
namespace to createGstBufferForData.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

Removed 0.10 codepath.
(webKitWebSrcQuery): Removed as it was 0.10 only.
(void webkit_web_src_class_init): Replaced setGstElementClassMetadata.
(webkit_web_src_init): Removed haveAppSrc27 private attribute and
0.10 codepath.
(webKitWebSrcStop): Removed checks for 1.0 as it is the only
codepath now.
(webKitWebSrcSetProperty):
(webKitWebSrcUriGetType):
(webKitWebSrcGetProtocols):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri): Removed 0.10 codepath.
(StreamingClient::createReadBuffer): Removed checks for 1.0 and
replaced getGstBufferSize.
(StreamingClient::handleResponseReceived): Removed 0.10 codepath
and replaced notifyGstTagsOnPad.
(StreamingClient::handleDataReceived): Removed 0.10 codepath and
replaced setGstBufferSize and gst_buffer_get_size.

Source/WebKit:

  • PlatformEfl.cmake: Removed FullscreenVideoControllerEfl.cpp.

Source/WebKit/efl:

  • WebCoreSupport/FullscreenVideoControllerEfl.cpp: Removed.

Source/WTF:

  • wtf/Platform.h: Removed macro for GStreamer 1.0 as it is the

only codepath now.

3:05 AM Changeset in webkit [159729] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline empty-clear-blocks.html after r159575

Unreviewed, rebaselining.

  • platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:

Nov 22, 2013:

11:11 PM Changeset in webkit [159728] by beidson@apple.com
  • 7 edits
    1 copy
    1 add in trunk/Source/WebKit2

Add DatabaseProcessCreationParameters, starting with the database path.
​https://bugs.webkit.org/show_bug.cgi?id=124804

Reviewed by Dean Jackson and Benjamin Poulain.

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::initializeDatabaseProcess):

  • DatabaseProcess/DatabaseProcess.h:

(WebKit::DatabaseProcess::indexedDatabaseDirectory):

  • DatabaseProcess/DatabaseProcess.messages.in:
  • Shared/Databases/DatabaseProcessCreationParameters.cpp: Added.

(WebKit::DatabaseProcessCreationParameters::DatabaseProcessCreationParameters):
(WebKit::DatabaseProcessCreationParameters::encode):
(WebKit::DatabaseProcessCreationParameters::decode):

  • Shared/Databases/DatabaseProcessCreationParameters.h: Added.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureDatabaseProcess):

  • WebKit2.xcodeproj/project.pbxproj:
  • Scripts/webkit2/messages.py:

(struct_or_class):

10:03 PM Changeset in webkit [159727] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source/WebKit2

[EFL] Build break after r159724
​https://bugs.webkit.org/show_bug.cgi?id=124806

Reviewed by Tim Horton.

  • Platform/CoreIPC/Connection.h: Include atomic header.
  • UIProcess/CoordinatedGraphics/WebView.cpp: Rename didChangeContentsSize to didChangeContentSize.

(WebKit::WebView::didChangeContentSize):

  • UIProcess/CoordinatedGraphics/WebView.h: Ditto.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Adjust TARGET_OS_IPHONE macro.
8:50 PM Changeset in webkit [159726] by rniwa@webkit.org
  • 4 edits
    1 add
    1 delete in trunk

Layout Test editing/deleting/password-delete-performance.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=124781

Reviewed by Alexey Proskuryakov.

PerformanceTests:

Add a new performance test to replace editing/deleting/password-delete-performance.html.
We skip this test by default since it's a micro benchmark.

  • Interactive/DeletingInPasswordField.html: Added.
  • Skipped:

LayoutTests:

Removed the test that has been timing out.

7:43 PM Changeset in webkit [159725] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt build fixes for 32-bit after 159724.

There's probably a better fix, but this will work for now.

  • UIProcess/API/mac/WKView.h:
7:29 PM Changeset in webkit [159724] by enrica@apple.com
  • 101 edits
    50 adds
    2 deletes in trunk/Source/WebKit2

Upstream iOS WebKit2 to OpenSource (part 3).
​https://bugs.webkit.org/show_bug.cgi?id=124803

Reviewed by Anders Carlsson and Tim Horton.

6:54 PM Changeset in webkit [159723] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

JSC Obj-C API should have real documentation
​https://bugs.webkit.org/show_bug.cgi?id=124805

Reviewed by Geoffrey Garen.

Massaging the header comments into proper headerdocs.

  • API/JSContext.h:
  • API/JSExport.h:
  • API/JSManagedValue.h:
  • API/JSValue.h:
  • API/JSVirtualMachine.h:
6:27 PM TestExpectations edited by Andres Gomez
(diff)
4:57 PM Changeset in webkit [159722] by jer.noble@apple.com
  • 4 edits in trunk/Source

[Mac] Can't drag full-screen video to another monitor
​https://bugs.webkit.org/show_bug.cgi?id=124798

Reviewed by Geoffrey Garen.

Source/WebCore:

Make full screen windows movable by default. Previously, we wanted non-movable full screen
windows since they were in the same space and were just placed atop non-full screen windows.
Now that all our supported Mac platforms have explicit full screen support, we can remove this
non-movable restriction.

  • platform/mac/WebCoreFullScreenWindow.mm:

(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):

Source/WebKit2:

Make full screen windows resizable by default. This allows the window to be resized when
moved between monitors with different resolutions.

  • UIProcess/API/mac/WKView.mm:

(-[WKView createFullScreenWindow]):

4:36 PM Changeset in webkit [159721] by fpizlo@apple.com
  • 20 edits in trunk/Source/JavaScriptCore

CodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size needed for exit, or any other unrelated things
​https://bugs.webkit.org/show_bug.cgi?id=124793

Reviewed by Mark Hahnenberg.

Now m_numCalleeRegisters always refers to the number of locals that the attached
bytecode uses. It never means anything else.

For frame size, we now have it lazily computed from m_numCalleeRegisters for the
baseline engines and we have it stored in DFG::CommonData for the optimizing JITs.

For frame-size-needed-at-exit, we store that in DFG::CommonData, too.

The code no longer implies that there is any arithmetic relationship between
m_numCalleeRegisters and frameSize. Previously it implied that the latter is greater
than the former.

The code no longer implies that there is any arithmetic relationship between the
frame Size and the frame-size-needed-at-exit. Previously it implied that the latter
is greater that the former.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::frameRegisterCount):

  • bytecode/CodeBlock.h:
  • dfg/DFGCommonData.h:

(JSC::DFG::CommonData::CommonData):
(JSC::DFG::CommonData::requiredRegisterCountForExecutionAndExit):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::frameRegisterCount):
(JSC::DFG::Graph::requiredRegisterCountForExit):
(JSC::DFG::Graph::requiredRegisterCountForExecutionAndExit):

  • dfg/DFGGraph.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):

  • ftl/FTLOSREntry.cpp:

(JSC::FTL::prepareOSREntry):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::frameExtentInternal):

  • interpreter/JSStackInlines.h:

(JSC::JSStack::pushFrame):

  • jit/JIT.h:

(JSC::JIT::frameRegisterCountFor):

  • jit/JITOperations.cpp:
  • llint/LLIntEntrypoint.cpp:

(JSC::LLInt::frameRegisterCountFor):

  • llint/LLIntEntrypoint.h:
4:17 PM Changeset in webkit [159720] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[Win] Clean up ColorSpace handling in Windows code
​https://bugs.webkit.org/show_bug.cgi?id=124795

Reviewed by Tim Horton.

Functionality covered by existing fast/css/color test suite.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::safeRGBColorSpaceRef): Handle case of Windows CG implementation not
handling sRGB correctly.
(WebCore::sRGBColorSpaceRef): Use new helper function.

  • platform/graphics/win/FontCGWin.cpp:

(WebCore::Font::drawGlyphs): Pass correct color space to fill functions.

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::platformInit): Initialize color space to value passed
via the style to the constructor.

4:07 PM Changeset in webkit [159719] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Another build fix for NetworkProcess on iOS
​https://bugs.webkit.org/show_bug.cgi?id=124797

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.

  • NetworkProcess/NetworkResourceLoader.h:
3:47 PM Changeset in webkit [159718] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2] Fix the build of the NetworkProcess on iOS
​https://bugs.webkit.org/show_bug.cgi?id=124794

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.

  • NetworkProcess/AsynchronousNetworkLoaderClient.cpp:

(WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/SynchronousNetworkLoaderClient.cpp:

(WebKit::SynchronousNetworkLoaderClient::willSendRequest):

3:43 PM Changeset in webkit [159717] by ap@apple.com
  • 15 edits
    2 moves in trunk/Source/WebCore

WebCrypto algorithms should check that key algorithm matches
​https://bugs.webkit.org/show_bug.cgi?id=123628

Reviewed by Anders Carlsson.

No change in behavior yet, because we have one algorithm per key class.
Will be tested once more algorithms are added.

  • WebCore.xcodeproj/project.pbxproj: Updated for file renames.
  • bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::createRsaKeyParamsWithHash):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):

  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::createRSAKeyParametersWithHash):
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):

  • crypto/CryptoAlgorithmParameters.h:

(WebCore::CryptoAlgorithmParameters::ENUM_CLASS):

  • crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h: Copied from Source/WebCore/crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h.
  • crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Removed.

Renamed RsaSsaKeyParams to RsaKeyParamsWithHash, because other algorithms (like RSA-OAEP)
are in the same boat. Depending on where the spec goes, we might need to introduce
algorithm specific RSA parameter classes later, but let's reduce copy/pasted code at
least for now.

  • crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Moved to the correct directory.
  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Copied from Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp.

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign): Factored out Mac specific
code, leaving type casting to cross-platform files.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Ditto.

  • crypto/CryptoAlgorithmRegistry.h:

(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):

  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Reduce copy/pasting in registration code.

  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches): Check key type and algorithm.
(WebCore::CryptoAlgorithmAES_CBC::encrypt): Cross platform type casting code.
Maybe we'll find a way to autogenerate or eliminate it one day.
(WebCore::CryptoAlgorithmAES_CBC::decrypt): Ditto.

  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:
  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):

  • crypto/algorithms/CryptoAlgorithmHMAC.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
Same changes for all algorithms that have keys.

2:57 PM Changeset in webkit [159716] by Manuel Rego Casasnovas
  • 2 edits in trunk

[GTK] Review enabled/disabled CSS features for release builds
​https://bugs.webkit.org/show_bug.cgi?id=124791

Reviewed by Martin Robinson.

Enable and disable some CSS features according to what last versions of
Safari ship or not.

  • Source/autotools/SetupWebKitFeatures.m4: Enable ENABLE_CSS_REGIONS and

ENABLE_CSS_STICKY_POSITION. Disable ENABLE_CSS_EXCLUSIONS and
ENABLE_CSS_SHAPES.

2:52 PM Changeset in webkit [159715] by andersca@apple.com
  • 4 edits
    6 adds in trunk/Source/WebKit2

Move the remaining page loader clients out into separate files
​https://bugs.webkit.org/show_bug.cgi?id=124792

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPageContextMenuClient.h: Added.
  • UIProcess/API/C/WKPageFindClient.h: Added.
  • UIProcess/API/C/WKPageFindMatchesClient.h: Added.
  • UIProcess/API/C/WKPageFormClient.h: Added.
  • UIProcess/API/C/WKPageLoaderClient.h:
  • UIProcess/API/C/WKPagePolicyClient.h: Added.
  • UIProcess/API/C/WKPageUIClient.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
2:24 PM Changeset in webkit [159714] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Fire "change" event on TextTrackList when a TextTrack's mode changes
​https://bugs.webkit.org/show_bug.cgi?id=124789

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.

Source/WebCore:

Since AudioTrackList and VideoTrackList already have this event, the
interesting bits are in TrackListBase::scheduleChangeEvent(), and we
just need to call it for TextTrackList changes.

Test: media/track/track-change-event.html

  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::textTrackModeChanged): Call TrackListBase::scheduleChangeEvent().

  • html/track/TextTrackList.idl: Add onchange event listener.

LayoutTests:

  • media/track/track-change-event-expected.txt: Added.
  • media/track/track-change-event.html: Added.
2:03 PM Changeset in webkit [159713] by fpizlo@apple.com
  • 17 edits in trunk/Source/JavaScriptCore

Combine SymbolTable and SharedSymbolTable
​https://bugs.webkit.org/show_bug.cgi?id=124761

Reviewed by Geoffrey Garen.

SymbolTable was never used directly; we now always used SharedSymbolTable. So, this
gets rid of SymbolTable and renames SharedSymbolTable to SymbolTable.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::symbolTable):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::symbolTable):
(JSC::UnlinkedCodeBlock::symbolTable):
(JSC::UnlinkedCodeBlock::finishCreation):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::symbolTable):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::symbolTableFor):

  • runtime/Arguments.h:

(JSC::Arguments::finishCreation):

  • runtime/Executable.h:

(JSC::FunctionExecutable::symbolTable):

  • runtime/JSActivation.h:

(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::allocationSize):

  • runtime/JSSymbolTableObject.h:

(JSC::JSSymbolTableObject::symbolTable):
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::destroy):
(JSC::SymbolTable::SymbolTable):

  • runtime/SymbolTable.h:

(JSC::SymbolTable::create):
(JSC::SymbolTable::createStructure):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
1:59 PM Changeset in webkit [159712] by andersca@apple.com
  • 3 edits
    1 add in trunk/Source/WebKit2

Move WKPageLoaderClient out into a separate header
​https://bugs.webkit.org/show_bug.cgi?id=124790

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPageLoaderClient.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
1:44 PM Changeset in webkit [159711] by commit-queue@webkit.org
  • 7 edits in trunk

Add TextTrackList::getTrackById().
​https://bugs.webkit.org/show_bug.cgi?id=124785

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-id.html

  • html/track/TextTrackList.cpp: Add getTrackById()

(TextTrackList::getTrackById):

  • html/track/TextTrackList.h: Same.
  • html/track/TextTrackList.idl: Same.

LayoutTests:

Update this test to make it more interesting. It now checks that the "id"
changes when the <track> id changes, makes sure TextTrack::id is readonly,
and looks the track up by id with getTrackById().

  • media/track/track-id-expected.txt:
  • media/track/track-id.html:
1:22 PM Changeset in webkit [159710] by dino@apple.com
  • 2 edits in trunk/Tools

Speculative Mountain Lion build fix.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate openDocument:]):

1:09 PM Changeset in webkit [159709] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove residual references to "dynamicGlobalObject".
​https://bugs.webkit.org/show_bug.cgi?id=124787.

Reviewed by Filip Pizlo.

12:57 PM Changeset in webkit [159708] by andersca@apple.com
  • 2 edits in trunk/Tools

Fix Mountain Lion bug.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate openDocument:]):

12:38 PM Changeset in webkit [159707] by andersca@apple.com
  • 2 edits in trunk/Tools

MiniBrowser should use the blocks-based NSOpenPanel API
​https://bugs.webkit.org/show_bug.cgi?id=124786

Reviewed by Simon Fraser.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate frontmostBrowserWindowController]):
Account for windows that don't have a BrowserWindowController.

(-[BrowserAppDelegate openDocument:]):

12:31 PM Changeset in webkit [159706] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Ensure that arity fixups honor stack alignment requirements.
​https://bugs.webkit.org/show_bug.cgi?id=124756.

Reviewed by Geoffrey Garen.

The LLINT and all the JITs rely on CommonSlowPaths::arityCheckFor() to
compute the arg count adjustment for the arity fixup. We take advantage
of this choke point and introduce the stack alignment padding there in
the guise of additional args.

The only cost of this approach is that the padding will also be
initialized to undefined values as if they were args. Since arity fixups
are considered a slow path that is rarely taken, this cost is not a
concern.

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):

  • runtime/VM.h:

(JSC::VM::isSafeToRecurse):

12:18 PM Changeset in webkit [159705] by fpizlo@apple.com
  • 5 edits
    1 delete in trunk

BytecodeGenerator should align the stack according to native conventions
​https://bugs.webkit.org/show_bug.cgi?id=124735

Source/JavaScriptCore:

Reviewed by Mark Lam.

Rolling this back in because it actually fixed fast/dom/gc-attribute-node.html, but
our infrastructure misleads peole into thinking that fixing a test constitutes
breaking it.

  • bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):

LayoutTests:

Reviewed by Mark Lam.

  • platform/mac/fast/dom/gc-attribute-node-expected.txt: Removed.
12:06 PM Changeset in webkit [159704] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix 32-bit build.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController _initWithPageRef:]):

11:48 AM Changeset in webkit [159703] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

Debug builds unconditionally dump remote layer tree transactions to stderr.

Reviewed by Sam Weinig.

  • Platform/Logging.h: Declared RemoteLayerTree logging channel.
  • Shared/mac/RemoteLayerTreeTransaction.h: Declared description().
  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::dump): Changed to use description().
(WebKit::RemoteLayerTreeTransaction::description): Returns a CString with the description.

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit): Changed to use logging instead of calling dump().

11:35 AM Changeset in webkit [159702] by hmuller@adobe.com
  • 7 edits
    4 adds in trunk

[CSS Shapes] When the <box> value is set, derive radii from border-radius
​https://bugs.webkit.org/show_bug.cgi?id=124228

Reviewed by Dean Jackson.

Source/WebCore:

Add support for BoxShape elliptical corners.

Tests: fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html

fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html

  • platform/graphics/FloatRoundedRect.h:

(WebCore::FloatRoundedRect::bottomLeftCorner): Corrected a copy-and-pasteO.

  • rendering/shapes/BoxShape.cpp:

(WebCore::BoxShape::getExcludedIntervals): Returned interval now depends on the top and bottom of the line.

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape): Rounded rect parameters are now specified with a RoundedRect parameter.

  • rendering/shapes/Shape.h:
  • rendering/shapes/ShapeInfo.cpp:

(WebCore::::computedShape): Pass style's rounded border to createShape().

LayoutTests:

  • fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001-expected.txt: Added.
  • fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002-expected.txt: Added.
  • fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html: Added.
11:33 AM Changeset in webkit [159701] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Send out the right KVO callbacks when the page title changes
​https://bugs.webkit.org/show_bug.cgi?id=124753

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(PageLoadStateObserver::PageLoadStateObserver):
New class that sends the right KVO notifications when the load state changes.

(-[WKBrowsingContextController dealloc]):
Remove the observer.

(-[WKBrowsingContextController _initWithPageRef:]):
Allocate the observer and add it.

  • UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::~PageLoadState):
Assert that we don't have any observers left.

(WebKit::PageLoadState::addObserver):
Add the observer to the list.

(WebKit::PageLoadState::removeObserver):
Remove the observer from the list.

(WebKit::PageLoadState::reset):
Call title change callbacks.

(WebKit::PageLoadState::setTitle):
Ditto.

(WebKit::PageLoadState::callObserverCallback):
Helper function to dispatch callbacks to observers.

  • UIProcess/PageLoadState.h:

Add new members.

11:31 AM Changeset in webkit [159700] by Lucas Forschler
  • 5 edits in branches/safari-537.60-branch/Source

Versioning.

11:28 AM Changeset in webkit [159699] by Lucas Forschler
  • 1 copy in tags/Safari-537.60.7

New Tag.

11:14 AM Changeset in webkit [159698] by Brent Fulgham
  • 2 edits in branches/safari-537.60-branch/Source/WebCore

Merge r159691

2013-11-21 Brent Fulgham <Brent Fulgham>

[Win] Avoid deadlock when interacting with some AVFoundationCF content
<rdar://problem/15482977> and ​https://bugs.webkit.org/show_bug.cgi?id=124752

Prevent deadlock caused by conflict over the "mapLock" mutex. Notification handling in the file,
which modify assets and make other changes, are required to happen on the main thread. This
patch enforces this requirement.

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::NotificationCallbackData::NotificationCallbackData): Added (WebCore::AVFWrapper::processNotification): Moved logic from 'notificationCallback', which was sometimes happening on a background thread. (WebCore::AVFWrapper::notificationCallback): Dispatch calls to main thread.
10:24 AM Changeset in webkit [159697] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Get rid of CodeBlock::dumpStatistics()
​https://bugs.webkit.org/show_bug.cgi?id=124762

Reviewed by Mark Hahnenberg.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):

  • bytecode/CodeBlock.h:
9:46 AM Changeset in webkit [159696] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r159690.
​http://trac.webkit.org/changeset/159690
​https://bugs.webkit.org/show_bug.cgi?id=124782

Broke webkitpy tests (Requested by ap on #webkit).

  • Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.run):
(QueueEngine._open_work_log):
(QueueEngine._ensure_work_log_closed):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.review_patch):

9:44 AM Changeset in webkit [159695] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Several missing/incorrect guards for LOG_DISABLED=0 against Release build (Mac)
​https://bugs.webkit.org/show_bug.cgi?id=78735

Patch by Andres Gomez <Andres Gomez> on 2013-11-22
Reviewed by Mario Sanchez Prada.

In a "Debug" build the CString.h header comes from another
indirect dependency. Now, we explicitly add this missing include.

  • page/CaptionUserPreferencesMediaAF.cpp: Explicitly adding

missing include.

9:38 AM Changeset in webkit [159694] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test editing/deleting/password-delete-performance.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=124781

  • TestExpectations: Skipped it, running a test that almost always times out makes little sense.
9:34 AM Changeset in webkit [159693] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r159652.
​http://trac.webkit.org/changeset/159652
​https://bugs.webkit.org/show_bug.cgi?id=124778

broke fast/dom/gc-attribute-node.html (Requested by ap on
#webkit).

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument):

9:27 AM Changeset in webkit [159692] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[curl] Fix of SSL certificate chain storage
​https://bugs.webkit.org/show_bug.cgi?id=124768

Patch by Robert Sipka <​sipka@inf.u-szeged.hu> on 2013-11-22
Reviewed by Brent Fulgham.

Change the certificates storage type into ListHashSet
from HashSet to keep the chain order in each case.
This ensures that there is no difference between the stored
and the recieved certificate chain.

  • platform/network/curl/SSLHandle.cpp:

(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::pemData):
(WebCore::certVerifyCallback):

9:23 AM Changeset in webkit [159691] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Avoid deadlock when interacting with some AVFoundationCF content
<rdar://problem/15482977> and ​https://bugs.webkit.org/show_bug.cgi?id=124752

Prevent deadlock caused by conflict over the "mapLock" mutex. Notification handling in the file,
which modify assets and make other changes, are required to happen on the main thread. This
patch enforces this requirement.

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::NotificationCallbackData::NotificationCallbackData): Added
(WebCore::AVFWrapper::processNotification): Moved logic from 'notificationCallback', which was
sometimes happening on a background thread.
(WebCore::AVFWrapper::notificationCallback): Dispatch calls to main thread.

8:26 AM Changeset in webkit [159690] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

EWS creates 0 byte sized log files
​https://bugs.webkit.org/show_bug.cgi?id=107606

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-11-22
Reviewed by Ryosuke Niwa.

There was a modification in r138264, that tried to make less log,
because some of the messeges were duplicated. After this the EWS
created the log file (with the same name as the bugID) but doesn't
write anything into it, even if there were errors during the build.
From now only creates the log file only if there is some error.

  • Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
there is nothing to log. Open the log file only if a ScriptError was raised to
avoid to make empty log files for bugs.
(QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
because of changes in r138264. Teeing is used for locally testing purposes and
this feature is not used anymore.
(QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
teeing anymore. It is a necessary change because of QueueEngine._open_work_log
change.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
to be able to handle it in QueueEngine.run. Without this change, the existing
exception handler never run (the process_work_item method never raise ScriptError)
We can get the error message only from the ScriptError at this point.

8:07 AM Changeset in webkit [159689] by rniwa@webkit.org
  • 5 edits
    59 adds in trunk/LayoutTests

Import more W3C tests for parsing template elements
​https://bugs.webkit.org/show_bug.cgi?id=124763

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Imported more W3c tests for HTML template element at 12a1164ae919f29f6ba2d0c8a63f0eafb6b599aa
after applying fixes proposed at ​https://github.com/w3c/web-platform-tests/pull/442.

  • html-templates/definitions/template-contents-expected.txt: Added.
  • html-templates/definitions/template-contents-owner-document-type-expected.txt: Added.
  • html-templates/definitions/template-contents-owner-document-type.html: Added.
  • html-templates/definitions/template-contents-owner-test-001-expected.txt: Added.
  • html-templates/definitions/template-contents-owner-test-001.html: Added.
  • html-templates/definitions/template-contents-owner-test-002-expected.txt: Added.
  • html-templates/definitions/template-contents-owner-test-002.html: Added.
  • html-templates/definitions/template-contents.html: Added.
  • html-templates/innerhtml-on-templates/innerhtml-expected.txt: Added.
  • html-templates/innerhtml-on-templates/innerhtml.html: Added.
  • html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-a-foster-parent-element-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-a-foster-parent-element.html: Added.
  • html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-not-a-foster-parent-element-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-not-a-foster-parent-element.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-body-token-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-body-token.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-frameset-token-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-frameset-token.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-head-token-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-head-token.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-html-token-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-html-token.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-body-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-body.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-html-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-html.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-frameset-insertion-mode/end-tag-frameset-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-frameset-insertion-mode/end-tag-frameset.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one.html: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-table-insertion-mode/end-tag-table-expected.txt: Added.
  • html-templates/parsing-html-templates/additions-to-the-in-table-insertion-mode/end-tag-table.html: Added.
  • html-templates/parsing-html-templates/appending-to-a-template/template-child-nodes-expected.txt: Added.
  • html-templates/parsing-html-templates/appending-to-a-template/template-child-nodes.html: Added.
  • html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context-expected.txt: Added.
  • html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context.html: Added.
  • html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context-expected.txt: Added.
  • html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context.html: Added.
  • html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context-expected.txt: Added.
  • html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context.html: Added.
  • html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document-expected.txt: Added.
  • html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document.html: Added.

LayoutTests:

Updated the testharness.js/css to bc4639ba51b62158d94bb4fc6884b23453f3f7a1.

  • resources/testharness.css:
  • resources/testharness.js:
  • resources/testharnessreport.js: Use innerText instead of innerHTML to avoid interpreting markup inside

the status and message as HTML.

8:01 AM Changeset in webkit [159688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile error when ACCELERATED_COMPOSITING is not used.
​https://bugs.webkit.org/show_bug.cgi?id=124773

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-11-22
Reviewed by Brent Fulgham.

  • rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations): Added USE(ACCELERATED_COMPOSITING) guard.

7:12 AM Changeset in webkit [159687] by zandobersek@gmail.com
  • 6 edits
    5 adds in trunk/LayoutTests

Unreviewed GTK gardening.
Rebaselining after r159575 and r159579.

  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Added.
  • platform/gtk/editing/deleting/delete-by-word-002-expected.txt: Added.
  • platform/gtk/editing/input/option-page-up-down-expected.txt: Added.
  • platform/gtk/editing/input/scroll-viewport-page-up-down-expected.txt: Added.
  • platform/gtk/editing/undo/undo-deleteWord-expected.txt: Added.
  • platform/gtk/fast/block/float/024-expected.txt:
  • platform/gtk/fast/block/margin-collapse/025-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
7:00 AM Changeset in webkit [159686] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.
Adding failure expectations for tests that regressed with r159572.

  • platform/gtk/TestExpectations:
3:03 AM Changeset in webkit [159685] by svillar@igalia.com
  • 4 edits
    3 adds in trunk

[CSS Grid Layout] Improve content-sized track layout
​https://bugs.webkit.org/show_bug.cgi?id=124408

Reviewed by Dean Jackson.

PerformanceTests:

From Blink r156122 by <​jchaffraix@chromium.org>

New test to check the performance of layouting grids with content sized tracks.

  • Layout/auto-grid-lots-of-data.html: Added.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html

From Blink r156122 & r157633 by <​jchaffraix@chromium.org>

Added a couple of optimizations to speed up the layout of content
based tracks. The idea is to narrow down the conditions for
relayouting when the height of a grid area changes. We basically
just need to layout tracks with percentage heights as they're the
only ones that change.

A new performance test is attached to demonstrate the effect of
these optimizations. We get a ~1000% improvement on a i7 M620
going from 14.5 runs/s to 165 runs/s.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::layoutGridItems):

LayoutTests:

From Blink r157633 by <​jchaffraix@chromium.org>

New test to verify that grid items with percentage logical
{min|max}-height resolve their sizes properly.

  • fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic-expected.txt: Added.
  • fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html: Added.
1:25 AM Changeset in webkit [159684] by svillar@igalia.com
  • 9 edits
    1 add in trunk

[CSS Grid Layout] Run the content-sized tracks sizing algorithm only when required
​https://bugs.webkit.org/show_bug.cgi?id=124039

Reviewed by Dean Jackson.

PerformanceTests:

From Blink r156028 and r156168 by <​jchaffraix@chromium.org>.

New performance tests for layouts in grids with fixed size tracks.

  • Layout/fixed-grid-lots-of-data.html: Added.

Source/WebCore:

The current code runs the content sized track sizing algorithm all
the time, which forces a layout even when the track is not
content-sized. This change improves the situation by applying two
optimizations. In the first one, we bail out the algorithm if we
detect that we don't need to run it. And by the second one we
reduce the amount of recomputations by only iterating over the
content sized tracks instead of all of them. Both changes follow
the ideas introduced in Blink r156028 and r156168 by
<​jchaffraix@chromium.org>.

As we changed the way we iterate over children (we use the
GridIterator now) the way they're stored in the RenderGrid changes
too. If a item spans through several "cells" inside the grid, we
will have a reference to it on each of them.

These two changes account for a ~3200% improvement on a i7 M620 in
the test that accompanies this change (15.5 vs 520 run/s).

New perf test: PerformanceTests/Layout/fixed-grid-lots-of-data.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Keep track
of content sized tracks and only iterate over them.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Early return if there are no tracks to pass to the algorithm.

  • rendering/RenderGrid.h:
  • rendering/style/GridLength.h:

(WebCore::GridLength::isContentSized):

  • rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::isContentSized):

LayoutTests:

From Blink r156028 and r156168 by <​jchaffraix@chromium.org>.

Subtle baseline change due to grids triggering less layouts, which
changes the frame rects between 2 subsequent layouts thus changing
the repaint rectangles.

  • fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
  • fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:
1:22 AM Changeset in webkit [159683] by Manuel Rego Casasnovas
  • 2 edits in trunk/Source/WebCore

[CSS Regions] Move code after early break in RenderRegion::repaintFlowThreadContentRectangle
​https://bugs.webkit.org/show_bug.cgi?id=124743

Reviewed by Mihnea Ovidenie.

No new tests, covered by existing tests.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::repaintFlowThreadContentRectangle): Variable
flippedFlowThreadPortionRect is not used before the early break, so we
can move it after and save some unneeded operations.

12:28 AM Changeset in webkit [159682] by Manuel Rego Casasnovas
  • 2 edits in trunk/Source/WebCore

[CSS Regions] Use hasOverflowClip() in RenderRegion
​https://bugs.webkit.org/show_bug.cgi?id=124746

Reviewed by Mihnea Ovidenie.

Implement the suggested FIXME in RenderRegion using hasOverflowClip().

No new tests, covered by existing tests.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::overflowRectForFlowThreadPortion): Use
hasOverflowClip().
(WebCore::RenderRegion::rectFlowPortionForBox): Ditto.

Nov 21, 2013:

9:12 PM Changeset in webkit [159681] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk/Source

Remove ANGLEGenerated from Windows build.
​https://bugs.webkit.org/show_bug.cgi?id=124759

Patch by Alex Christensen <​achristensen@webkit.org> on 2013-11-21
Reviewed by Darin Adler.

Source/ThirdParty/ANGLE:

  • ANGLE.vcxproj/ANGLEGenerated.vcxproj: Removed.
  • ANGLE.vcxproj/ANGLEGenerated.vcxproj.filters: Removed.

Source/WebKit:

  • WebKit.vcxproj/WebKit.sln:

Remove references to ANGLEGenerated.vcxproj.

9:03 PM Changeset in webkit [159680] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Map the dir attribute to the CSS direction property.
​https://bugs.webkit.org/show_bug.cgi?id=124572.

Patch by Frédéric Wang <​fred.wang@free.fr> on 2013-11-21
Reviewed by Darin Adler.

Source/WebCore:

Test: mathml/presentation/mstyle-css-attributes.html

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isPresentationAttribute): reorder attributes
(WebCore::MathMLElement::collectStyleForPresentationAttribute): reorder tags that accept dir
(WebCore::MathMLElement::isMathMLToken): add an inline function to test that a tag corresponds to a MathML Token Element.

  • mathml/MathMLElement.h:

Follow-up work to address Darin's comments.

LayoutTests:

  • mathml/presentation/direction-overall-expected.html: test that dir does not apply to msqrt
  • mathml/presentation/direction-overall.html:
  • mathml/presentation/mstyle-css-attributes-expected.html: Added.
  • mathml/presentation/mstyle-css-attributes.html: Added.

Add more tests for presentation attributes on mstyle.

9:01 PM Changeset in webkit [159679] by commit-queue@webkit.org
  • 116 edits in trunk

Remove ENABLE_WORKERS
​https://bugs.webkit.org/show_bug.cgi?id=105784

.:

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

Source/WebKit:

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/efl:

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

  • ewk/ewk_settings.cpp:

(ewk_settings_memory_cache_clear):

Source/WebKit/win:

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

  • WebWorkersPrivate.cpp:

(WebWorkersPrivate::workerThreadCount):

Source/WTF:

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

  • wtf/FeatureDefines.h:
  • wtf/nix/FeatureDefinesNix.h:

Tools:

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

  • Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

  • win/tools/vsprops/FeatureDefines.props:
  • win/tools/vsprops/FeatureDefinesCairo.props:
8:42 PM Changeset in webkit [159678] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix after r159632.

  • platform/network/curl/SSLHandle.cpp:

(WebCore::certVerifyCallback):
Fixed template syntax.

8:24 PM Changeset in webkit [159677] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix a typo (requriements->requirements).

  • runtime/StackAlignment.h:
8:22 PM Changeset in webkit [159676] by Darin Adler
  • 2 edits in trunk/Tools

Try to fix buildbot Dashboard for people who have not hidden anything.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

Add a null check for hidden platforms.

8:17 PM Changeset in webkit [159675] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

Remove chrome/chromium related things from webkitpy.
​https://bugs.webkit.org/show_bug.cgi?id=124493

Patch by Peter Szanka <​h868064@stud.u-szeged.hu> on 2013-11-21
Reviewed by Darin Adler.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(PortTest.assert_mock_port_works):

  • Scripts/webkitpy/port/base.py:

(Port.to.setup_environ_for_server):

  • Scripts/webkitpy/port/mac_unittest.py:

(test_tests_for_other_platforms):

  • Scripts/webkitpy/port/mock_drt.py:

(MockTestShell.output_for_test):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Restart.execute):

  • Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_help):

8:05 PM Changeset in webkit [159674] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix build after r159656
​https://bugs.webkit.org/show_bug.cgi?id=124755

Patch by Sergio Correia <Sergio Correia> on 2013-11-21
Reviewed by Gyuyoung Kim.

Page title was moved to page load state.

  • UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:

(WebKit::WebInspectorServer::buildPageList):

7:56 PM Changeset in webkit [159673] by alex.christensen@flexsim.com
  • 1 edit
    1 add in trunk/Source/ThirdParty/ANGLE

Unreviewed build fix.

7:49 PM Changeset in webkit [159672] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
​https://bugs.webkit.org/show_bug.cgi?id=124717

Patch by Dániel Bátyai <​Batyai.Daniel@stud.u-szeged.hu> on 2013-11-21
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/style/filereader.py:

(TextFileReader.process_file):

  • Scripts/webkitpy/style/filereader_unittest.py:

(TextFileReaderTest.test_process_filedoes_not_exist):

7:17 PM Changeset in webkit [159671] by betravis@adobe.com
  • 13 edits in trunk

Web Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API surface
​https://bugs.webkit.org/show_bug.cgi?id=124737

Reviewed by Timothy Hatcher.

Source/WebCore:

Add a virtual method to Shapes, buildPath, that can be used to build the
path (in the Shape coordinate system) for display in the Inspector. This allows us
to remove methods such as type(), polygon(), and logicalRx/Ry() which exposed the
inner workings of the Shapes classes. Also covers the addition of the BoxShape type.

Refactoring, existing test is inspector-protocol/model/highlight-shape-outside.html.

  • inspector/InspectorOverlay.cpp:

(WebCore::appendPathCommandAndPoints): Points need to be translated from shape space
to renderer space using ShapeInfo.
(WebCore::buildObjectForShapeOutside): Add the ShapeOutsideInfo to the path info struct.

  • rendering/shapes/BoxShape.cpp:

(WebCore::BoxShape::buildPath): Build the path for a BoxShape.

  • rendering/shapes/BoxShape.h:
  • rendering/shapes/PolygonShape.cpp:

(WebCore::PolygonShape::buildPath): Build the path for a PolygonShape.

  • rendering/shapes/PolygonShape.h:
  • rendering/shapes/RasterShape.h:
  • rendering/shapes/RectangleShape.cpp:

(WebCore::RectangleShape::buildPath): Build the path for a RectangleShape.

  • rendering/shapes/RectangleShape.h:
  • rendering/shapes/Shape.h:

LayoutTests:

The shapes paths are now drawn in shape-coordinate space before being translated to
renderer space. With different writing modes, shapes may have their coordinates
translated. For example, a rectangle specified as four points [top left, top right,
bottom right, bottom left] in vertical-lr space would appear as [top left, bottom left,
bottom right, top right] in horizontal-tb space. Adjusting the previous tests, and
adding a test for the new box value.

  • inspector-protocol/model/highlight-shape-outside-expected.txt:
  • inspector-protocol/model/highlight-shape-outside.html:
7:12 PM Changeset in webkit [159670] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CodeBlock::m_numCalleeRegisters need to honor native stack alignment.
​https://bugs.webkit.org/show_bug.cgi?id=124754.

Reviewed by Filip Pizlo.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::newRegister):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

7:04 PM Changeset in webkit [159669] by mrowe@apple.com
  • 13 edits in trunk

<​https://webkit.org/b/124702> Stop overriding VALID_ARCHS.

All modern versions of Xcode set it appropriately for our needs.

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebInspectorUI:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:

Tools:

  • MiniBrowser/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
7:01 PM Changeset in webkit [159668] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Tools

webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
​https://bugs.webkit.org/show_bug.cgi?id=124676

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-11-21
Reviewed by Daniel Bates.

checkForArgumentAndRemoveFromArrayRef functions was removing wrong
elements when there were more then one occurrence of that argument.
E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
{b, a}, when it should be {b, c}.

  • Scripts/webkitdirs.pm:

(checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.

  • Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:

Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.

7:01 PM Changeset in webkit [159667] by ryumiel@company100.net
  • 4 edits in trunk/Source

[GTK] Unreviewed buildfix after r159614 and r159656.

Source/WebCore:

  • bindings/gobject/WebKitDOMCustom.cpp: Add missing header

Source/WebKit2:

  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::buildPageList): Use the page load state to get page title.

6:59 PM Changeset in webkit [159666] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix WinCairo unreachable code warnings in SimpleLineLayout.cpp
​https://bugs.webkit.org/show_bug.cgi?id=124704

Patch by Laszlo Vidacs <​lac@inf.u-szeged.hu> on 2013-11-21
Reviewed by Antti Koivisto.

Fix unreachable code warnings using conditional directives.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

6:57 PM Changeset in webkit [159665] by mrowe@apple.com
  • 12 edits in trunk/Source

<​https://webkit.org/b/124701> Fix an error in a few Xcode configuration setting files.

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:

Source/WTF:

  • Configurations/Base.xcconfig:
6:56 PM Changeset in webkit [159664] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Update build-webkit after r159550.

  • Scripts/webkitperl/FeatureList.pm:
6:55 PM Changeset in webkit [159663] by mrowe@apple.com
  • 8 edits in trunk/Source

<​https://webkit.org/b/124700> Fix some deprecation warnings.

Reviewed by Anders Carlsson.

Source/WebCore:

  • platform/mac/HTMLConverter.mm:

(fileWrapperForURL): Move off a deprecated NSFileWrapper method.

Source/WebKit/mac:

  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::startStream): Move off a deprecated NSData method.

  • WebView/WebDataSource.mm:

(-[WebDataSource _fileWrapperForURL:]): Move off a deprecated NSFileWrapper method.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(-[WKView namesOfPromisedFilesDroppedAtDestination:]): Move off a deprecated NSFileWrapper method.

6:53 PM Changeset in webkit [159662] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Layout tests with editing need to be rebaselined.
​https://bugs.webkit.org/show_bug.cgi?id=124751

Unreviewed, EFL rebaseline.

editing/input/reveal-caret-of-multiline-contenteditable.html test is rebaselined after r137239.
editing/selection/5354455-2.html test is rebaselined after r133000.
Rebaseline the expected results to suit editing-related performance in EFL.

Patch by Sun-woo Nam <​sunny.nam@samsung.com> on 2013-11-21

  • platform/efl-wk1/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
  • platform/efl/editing/selection/5354455-2-expected.txt:
6:38 PM Changeset in webkit [159661] by Lucas Forschler
  • 2 edits in trunk/Tools

Update apple builders.

6:20 PM Changeset in webkit [159660] by rniwa@webkit.org
  • 2 edits
    49 adds in trunk/LayoutTests

Import some W3C tests for HTML template element
​https://bugs.webkit.org/show_bug.cgi?id=124699

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Imported the shared resources for web-platform-tests/html-templates as well as tests under
serializing-html-templates and template-element at a274ad93ef5dc02ac042e0a5d58327d4135178ac.

  • ChangeLog: Added.
  • html-templates/resources/end-template-tag-in-body.html: Added.
  • html-templates/resources/end-template-tag-in-head.html: Added.
  • html-templates/resources/frameset-end-tag.html: Added.
  • html-templates/resources/head-template-contents-div-no-end-tag.html: Added.
  • html-templates/resources/head-template-contents-table-no-end-tag.html: Added.
  • html-templates/resources/html-start-tag.html: Added.
  • html-templates/resources/template-child-nodes-div.xhtml: Added.
  • html-templates/resources/template-child-nodes-nested.xhtml: Added.
  • html-templates/resources/template-contents-attribute.html: Added.
  • html-templates/resources/template-contents-body.html: Added.
  • html-templates/resources/template-contents-div-no-end-tag.html: Added.
  • html-templates/resources/template-contents-empty.html: Added.
  • html-templates/resources/template-contents-frameset.html: Added.
  • html-templates/resources/template-contents-head.html: Added.
  • html-templates/resources/template-contents-html.html: Added.
  • html-templates/resources/template-contents-nested.html: Added.
  • html-templates/resources/template-contents-table-no-end-tag.html: Added.
  • html-templates/resources/template-contents-text.html: Added.
  • html-templates/resources/template-contents.html: Added.
  • html-templates/resources/template-descendant-body.html: Added.
  • html-templates/resources/template-descendant-frameset.html: Added.
  • html-templates/resources/template-descendant-head.html: Added.
  • html-templates/resources/two-templates.html: Added.
  • html-templates/serializing-html-templates/outerhtml-expected.txt: Added.
  • html-templates/serializing-html-templates/outerhtml.html: Added.
  • html-templates/template-element/content-attribute-expected.txt: Added.
  • html-templates/template-element/content-attribute.html: Added.
  • html-templates/template-element/node-document-changes-expected.txt: Added.
  • html-templates/template-element/node-document-changes.html: Added.
  • html-templates/template-element/template-as-a-descendant-expected.txt: Added.
  • html-templates/template-element/template-as-a-descendant.html: Added.
  • html-templates/template-element/template-content-expected.txt: Added.
  • html-templates/template-element/template-content-node-document-expected.txt: Added.
  • html-templates/template-element/template-content-node-document.html: Added.
  • html-templates/template-element/template-content.html: Added.
  • html-templates/template-element/template-descendant-body-expected.txt: Added.
  • html-templates/template-element/template-descendant-body.html: Added.
  • html-templates/template-element/template-descendant-frameset-expected.txt: Added.
  • html-templates/template-element/template-descendant-frameset.html: Added.
  • html-templates/template-element/template-descendant-head-expected.txt: Added.
  • html-templates/template-element/template-descendant-head.html: Added.
  • html-templates/testcommon.js: Added.

LayoutTests:

  • imported/w3c/: Added.
  • platform/win/TestExpectations: Skip the imported tests since the template element is disabled on Windows.
6:12 PM Changeset in webkit [159659] by dino@apple.com
  • 3 edits in trunk/Tools

Don't fetch hidden platforms on build.webkit.org/dashboard
​https://bugs.webkit.org/show_bug.cgi?id=124750

Reviewed by Tim Horton.

If a platform is hidden, don't fetch its data. If it
becomes unhidden, try to fetch immediately (unless
you've recently fetched).

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
5:29 PM Changeset in webkit [159658] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Didn't mean to commit this.

  • UIProcess/PageLoadState.h:
5:16 PM Changeset in webkit [159657] by Brent Fulgham
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed gardening to hide annoying *.user files when.

  • ANGLE.vcxproj: Added property svn:ignore.
5:13 PM Changeset in webkit [159656] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Move page title handling to the page load state
​https://bugs.webkit.org/show_bug.cgi?id=124748

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCopyTitle):

  • UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::didCommitLoad):
(WebKit::PageLoadState::title):
(WebKit::PageLoadState::setTitle):

  • UIProcess/PageLoadState.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveTitleForFrame):

  • UIProcess/WebPageProxy.h:
5:11 PM Changeset in webkit [159655] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

ARM64: Implement push/pop equivalents in LLInt
​https://bugs.webkit.org/show_bug.cgi?id=124721

Reviewed by Filip Pizlo.

Added pushLRAndFP and popLRAndFP that push and pop the link register and frame pointer register.
These ops emit code just like what the compiler emits in the prologue and epilogue. Also changed
pushCalleeSaves and popCalleeSaves to use the same store pair and load pair instructions to do
the actually pushing and popping. Finally changed the implementation of push and pop to raise
an exception since we don't have (or need) a single register push or pop.

  • llint/LowLevelInterpreter64.asm:
  • offlineasm/arm64.rb:
  • offlineasm/instructions.rb:
4:46 PM Changeset in webkit [159654] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSC: Removed unused opcodes from offline assembler
​https://bugs.webkit.org/show_bug.cgi?id=124749

Reviewed by Mark Hahnenberg.

Removed the unused, X86 only peekq and pokeq.

  • offlineasm/instructions.rb:
  • offlineasm/x86.rb:
4:31 PM Changeset in webkit [159653] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(159395) Fix branch8(…, AbsoluteAddress, …) in ARM64 MacroAssembler
​https://bugs.webkit.org/show_bug.cgi?id=124688

Reviewed by Geoffrey Garen.

Changed handling of the address for the load8() in the branch8(AbsoluteAddress) to be like
the rest of the branchXX(AbsoluteAddress) fucntions.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::branch8):

3:55 PM Changeset in webkit [159652] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

BytecodeGenerator should align the stack according to native conventions
​https://bugs.webkit.org/show_bug.cgi?id=124735

Reviewed by Mark Lam.

  • bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):

3:24 PM Changeset in webkit [159651] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

[iOS] Build fix; export symbol for WebCore::provideDeviceOrientationTo()

Add the symbol ZN7WebCore26provideDeviceOrientationToEPNS_4PageEPNS_23DeviceOrientationClientE.

  • WebCore.exp.in:
3:21 PM Changeset in webkit [159650] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard
​https://bugs.webkit.org/show_bug.cgi?id=124741

Reviewed by Alexey Proskuryakov.

Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused
when building with feature NETWORK_CFDATA_ARRAY_CALLBACK.

Additionally, add a declaration for allocateSegment() with attribute WARN_UNUSED_RETURN
to have the compiler warn when the return value of this function is unused. Together with
warnings treated as errors this change will prevent a memory leak.

  • platform/SharedBuffer.cpp:
3:20 PM Changeset in webkit [159649] by dbates@webkit.org
  • 5 edits in trunk/Source

Remove unused functions from WebCore and WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=124739

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • editing/markup.cpp: Remove unused functions isHTMLBlockElement and

ancestorToRetainStructureAndAppearanceWithNoRenderer.

  • rendering/InlineElementBox.cpp: Append newline to the end of the file.

Source/WebKit2:

Remove unused functions autoreleased({WKURLRequestRef, WKURLResponseRef}).

  • UIProcess/API/mac/WKBrowsingContextController.mm:
3:19 PM Changeset in webkit [159648] by dbates@webkit.org
  • 16 edits
    11 adds in trunk/Source/WebCore

Only generate isObservable() when IDL specifies GenerateIsReachable
​https://bugs.webkit.org/show_bug.cgi?id=124729

Reviewed by Geoffrey Garen.

We should only generate the static inline function isObservable() when the IDL
specifies GenerateIsReachable. Otherwise, this function is unused.

Added a new test IDL TestGenerateIsReachable.idl and expected results to test that
we generate isObservable() when an IDL specifies GenerateIsReachable. Additionally,
rebased existing test results.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachablePrivate.h: Added.
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Removed unused function isObservable().
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestException.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: Added.
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h: Added.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Removed unused function isObservable().
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestTypedefs.cpp: Ditto.
  • bindings/scripts/test/JS/JSattribute.cpp: Ditto.
  • bindings/scripts/test/JS/JSreadonly.cpp: Ditto.
  • bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h: Added.
  • bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.mm: Added.
  • bindings/scripts/test/ObjC/DOMTestGenerateIsReachableInternal.h: Added.
  • bindings/scripts/test/TestGenerateIsReachable.idl: Added.
2:31 PM Changeset in webkit [159647] by Csaba Osztrogonác
  • 37 edits
    4 moves in trunk/Source/WebKit2

Rename PlatformCertificateInfo to CertificateInfo
​https://bugs.webkit.org/show_bug.cgi?id=124150

Reviewed by Darin Adler.

  • GNUmakefile.list.am:
  • NetworkProcess/AsynchronousNetworkLoaderClient.cpp:

(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkResourceLoader.cpp:
  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoCreateWithCertficateChain):
(WKCertificateInfoGetCertificateChain):

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):

  • Shared/Authentication/AuthenticationManager.h:
  • Shared/Authentication/AuthenticationManager.messages.in:
  • Shared/Authentication/mac/AuthenticationManager.mac.mm:

(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebCertificateInfo.h:

(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::certificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):

  • Shared/mac/CertificateInfo.h: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.h.

(WebKit::CertificateInfo::certificateChain):

  • Shared/mac/CertificateInfo.mm: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm.

(WebKit::CertificateInfo::CertificateInfo):
(WebKit::CertificateInfo::encode):
(WebKit::CertificateInfo::decode):
(WebKit::CertificateInfo::dump):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

  • Shared/soup/CertificateInfo.cpp: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp.

(WebKit::CertificateInfo::CertificateInfo):
(WebKit::CertificateInfo::~CertificateInfo):
(WebKit::CertificateInfo::encode):
(WebKit::CertificateInfo::decode):

  • Shared/soup/CertificateInfo.h: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.h.

(WebKit::CertificateInfo::certificate):
(WebKit::CertificateInfo::tlsErrors):

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

  • UIProcess/API/gtk/WebKitCertificateInfo.cpp:

(webkitCertificateInfoGetCertificateInfo):

  • UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_tls_info):

  • UIProcess/Authentication/AuthenticationChallengeProxy.cpp:

(WebKit::AuthenticationChallengeProxy::useCredential):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didCommitLoad):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):

  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost):

2:28 PM Changeset in webkit [159646] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebKit2

[EFL][GTK][WK2] Build fix after r159641
​https://bugs.webkit.org/show_bug.cgi?id=124742

Patch by Sergio Correia <Sergio Correia> on 2013-11-21
Reviewed by Csaba Osztrogonác.

Should fetch activeURL from page load state.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewUpdateURI):

  • UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:

(WebKit::WebInspectorServer::buildPageList):

  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::buildPageList):

2:26 PM WebKitGTK/Debugging edited by Andres Gomez
(diff)
1:57 PM Changeset in webkit [159645] by Beth Dakin
  • 9 edits in trunk/Source/WebCore

Add a new mode to extend the tile cache beyond the page
​https://bugs.webkit.org/show_bug.cgi?id=124216

Reviewed by Simon Fraser.

This patch makes it possible to give the tile cache a margin of tiles. If there is
a margin of tiles, this patch paints those tiles with the background color. Note
that this patch does not actually give the tile cache a margin at this time.

You opt into a margined tiled cache by called setTileMargins() with number of
pixels that the margin on that side should be.

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::TileController):
(WebCore::TileController::tilesWouldChangeForVisibleRect):

TileController::bounds() now computes the bounds INCLUDING the margin.
(WebCore::TileController::bounds):

adjustRectAtTileIndexForMargin() is a new function that is required to get the
rect size for tiles in the margin right. rectForTileIndex() assumes all tiles
strive to be the size of m_tileSize, but now margin tiles will be whatever the
margin sizes were set to.
(WebCore::TileController::adjustRectAtTileIndexForMargin):
(WebCore::TileController::rectForTileIndex):

This is another instance where m_tileSize is not always the right size to use.
(WebCore::TileController::getTileIndexRangeForRect):

The tile coverage rect now might include the margin tiles. Only include them in
slow-scrolling mode if the current position is within one tile of the edge.
(WebCore::TileController::computeTileCoverageRect):

tileSizeForCoverageRect() does not make sense in a world where the coverage rect
will include margin. Instead, this patch implements the current strategy more
explicitly by returning the visibleRect in the slow scrolling case, and in the
process this patch also re-names tileSizeForCoverageRect() to computeTileSize()
since it no longer takes a coverageRect.
(WebCore::TileController::computeTileSize):
(WebCore::TileController::revalidateTiles):

New setters and getters for the tile margins on each side.
(WebCore::TileController::setTileMargins):
(WebCore::TileController::hasMargins):
(WebCore::TileController::topMarginHeight):
(WebCore::TileController::bottomMarginHeight):
(WebCore::TileController::leftMarginWidth):
(WebCore::TileController::rightMarginWidth):

New function to add margin onto the composited bounds if there is one.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::tiledBackingHasMargin):
(WebCore::RenderLayerBacking::paintContents):
(WebCore::RenderLayerBacking::compositedBoundsIncludingMargin):

  • rendering/RenderLayerBacking.h:

Do not set masks to bounds if there is a margin on the root layer.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::mainFrameBackingIsTiledWithMargin):

  • rendering/RenderLayerCompositor.h:

Allow background color to paint into the margin tiles.

  • rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

1:55 PM Changeset in webkit [159644] by ap@apple.com
  • 6 edits
    4 adds in trunk

Implement WebCrypto wrapKey
​https://bugs.webkit.org/show_bug.cgi?id=124738

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html

crypto/subtle/aes-cbc-wrap-rsa.html

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::exportKey): Factored out the actual operation that can be chained with
encryption for wrapKey.
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey): Fixed a memory leak in failure code path.

  • crypto/SubtleCrypto.idl: Added wrapKey.

LayoutTests:

  • crypto/subtle/aes-cbc-wrap-rsa-expected.txt: Added.
  • crypto/subtle/aes-cbc-wrap-rsa-non-extractable-expected.txt: Added.
  • crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html: Added.
  • crypto/subtle/aes-cbc-wrap-rsa.html: Added.
  • crypto/subtle/aes-export-key-expected.txt:
  • crypto/subtle/hmac-export-key-expected.txt:

There is no longer a console message, the error is in an exception.

1:11 PM Changeset in webkit [159643] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, preemptive build fix.

  • runtime/StackAlignment.h:

(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):

1:07 PM Changeset in webkit [159642] by fpizlo@apple.com
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

JSC should know what the stack alignment conventions are
​https://bugs.webkit.org/show_bug.cgi?id=124736

Reviewed by Mark Lam.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/StackAlignment.h: Added.

(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):

12:30 PM Changeset in webkit [159641] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Fetch all page loading related URLs from the page load state
​https://bugs.webkit.org/show_bug.cgi?id=124732

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCopyActiveURL):
(WKPageCopyProvisionalURL):
(WKPageCopyCommittedURL):

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController unreachableURL]):

  • UIProcess/PageLoadState.h:

(WebKit::PageLoadState::provisionalURL):
(WebKit::PageLoadState::url):
(WebKit::PageLoadState::unreachableURL):

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
12:03 PM Changeset in webkit [159640] by stavila@adobe.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added test for :hover and javascript events on the visual overflow of a region.

[CSS Regions] Content in a region's visible overflow does not trigger :hover state, nor JavaScript events
​https://bugs.webkit.org/show_bug.cgi?id=112010

Reviewed by Antti Koivisto.

  • fast/regions/hover-and-js-in-visual-overflow-expected.html: Added.
  • fast/regions/hover-and-js-in-visual-overflow.html: Added.
12:00 PM Changeset in webkit [159639] by beidson@apple.com
  • 8 edits
    2 adds in trunk/Source/WebKit2

Hook up WebProcess-side of getOrEstablishIDBDatabaseMetadata
​https://bugs.webkit.org/show_bug.cgi?id=124698

Reviewed by Anders Carlsson.

With this change the IDB API in WebKit2 using the DatabaseProcess finally does something observable:
window.indexedDB.open() sends an error to Javascript.

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata): Continue calling back to the

WebProcess with dummy data, but include the request ID for reference.

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

Add a new class that wraps a completion callback function and gives it a unique integer identifier.
It also allows for wrapping an abort callback function (in case a connection is lost, for example).
It is templated to flexibly handle any callback function signature.

  • Shared/AsyncRequest.cpp: Added.

(WebKit::generateRequestID):
(WebKit::AsyncRequest::AsyncRequest):
(WebKit::AsyncRequest::~AsyncRequest):
(WebKit::AsyncRequest::setAbortHandler):
(WebKit::AsyncRequest::requestAborted):
(WebKit::AsyncRequest::clearAbortHandler):

  • Shared/AsyncRequest.h: Added.

(WebKit::AsyncRequest::requestID):
(WebKit::AsyncRequest::requestCompleted):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata): Wrap the completion handler in an

AsyncRequest and save off the request for later use.

(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata): Send the results to the AsyncRequest.

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
11:43 AM Changeset in webkit [159638] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Move activeURL getter to PageLoadState
​https://bugs.webkit.org/show_bug.cgi?id=124690

Reviewed by Tim Horton.

  • UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::activeURL):

  • UIProcess/PageLoadState.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::activeURL):

11:05 AM Changeset in webkit [159637] by ap@apple.com
  • 13 edits
    4 adds in trunk

Implement WebCrypto unwrapKey
​https://bugs.webkit.org/show_bug.cgi?id=124725

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-unwrap-failure.html

crypto/subtle/aes-cbc-unwrap-rsa.html

  • bindings/js/JSCryptoAlgorithmDictionary.cpp:
  • bindings/js/JSCryptoAlgorithmDictionary.h:

Removed calls for wrap/unwrap parameter parsing, these are just the same as encrypt/decrypt.

  • bindings/js/JSCryptoOperationData.cpp:

(WebCore::cryptoOperationDataFromJSValue):

  • bindings/js/JSCryptoOperationData.h:
  • crypto/CryptoKeySerialization.h:

More Vector<char> elimination.

  • bindings/js/JSDOMPromise.cpp:
  • bindings/js/JSDOMPromise.h:

Removed unneccessary copy constructor and assignment operator, they are no diffdrent
than compiler generated ones.

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::cryptoKeyUsagesFromJSValue): Minor style fixes.
(WebCore::JSSubtleCrypto::encrypt): Ditto.
(WebCore::JSSubtleCrypto::decrypt): Ditto.
(WebCore::JSSubtleCrypto::sign): Ditto.
(WebCore::JSSubtleCrypto::verify): Ditto.
(WebCore::JSSubtleCrypto::generateKey): Ditto.
(WebCore::importKey): Separated actual import operation and the parts that read
arguments from ExecState, and call the promise. Logically, this should be outside
of bindings code even, but JWK makes that quite challenging.
(WebCore::JSSubtleCrypto::importKey): This only does the more mundane arguments
and return parts now.
(WebCore::JSSubtleCrypto::exportKey): Minor style fixes.
(WebCore::JSSubtleCrypto::unwrapKey): Chain decrypt and import.

  • crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::encryptForWrapKey):
(WebCore::CryptoAlgorithm::decryptForUnwrapKey):

  • crypto/CryptoAlgorithm.h:

There are algorithms that expose wrap/unwrap, but not encrypt/decrypt. These will
override these new functions, and leave encrypt/decrypt to raise NOT_SUPPORTED_ERR.

  • crypto/SubtleCrypto.idl: Added unwrapKey.

LayoutTests:

  • crypto/subtle/aes-cbc-unwrap-failure-expected.txt: Added.
  • crypto/subtle/aes-cbc-unwrap-failure.html: Added.
  • crypto/subtle/aes-cbc-unwrap-rsa-expected.txt: Added.
  • crypto/subtle/aes-cbc-unwrap-rsa.html: Added.
11:02 AM Changeset in webkit [159636] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r159633.
​http://trac.webkit.org/changeset/159633
​https://bugs.webkit.org/show_bug.cgi?id=124726

it broke 10 webkitpy tests (Requested by dino_ on #webkit).

  • Scripts/webkitpy/style/checker.py:

(check_webkit_style_configuration):
(CheckerDispatcher.dispatch):
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.init):
(StyleProcessorConfiguration.write_style_error):

10:32 AM Changeset in webkit [159635] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[MIPS] Build fails since r159545.
​https://bugs.webkit.org/show_bug.cgi?id=124716

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2013-11-21
Reviewed by Michael Saboff.

Add missing implementations in MacroAssembler and LLInt for MIPS.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::sync):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::store8):
(JSC::MacroAssemblerMIPS::memoryFence):

  • offlineasm/mips.rb:
10:21 AM Changeset in webkit [159634] by Simon Fraser
  • 5 edits in trunk/Source/WebKit2

Clean up WebKit2 initialization
​https://bugs.webkit.org/show_bug.cgi?id=124696

Reviewed by Sam Weinig.

Call InitializeWebKit2() everywhere we need to do one-time
initialization in WebKit2, rather than having a hotch-potch
of init code.

  • Shared/APIObject.cpp:

(API::Object::Object):

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: Removed an unused #include.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::create):

9:44 AM Changeset in webkit [159633] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove the stderr_write attribute from StyleProcessorConfiguration.
​https://bugs.webkit.org/show_bug.cgi?id=124703

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-11-21
Reviewed by Brent Fulgham.

  • Scripts/webkitpy/style/checker.py:

(check_webkit_style_configuration):
(CheckerDispatcher.dispatch):
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.init):
(StyleProcessorConfiguration.write_style_error):

9:43 AM Changeset in webkit [159632] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[curl]Improve ssl certificate storage and check
​https://bugs.webkit.org/show_bug.cgi?id=124569

Patch by Robert Sipka <​sipka@inf.u-szeged.hu> on 2013-11-21
Reviewed by Brent Fulgham.

Storage and check the whole certificate chain, not just the root certificate.

  • platform/network/curl/SSLHandle.cpp:

(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::pemData):
(WebCore::certVerifyCallback):

9:41 AM Changeset in webkit [159631] by mitz@apple.com
  • 21 edits in trunk/Source/WebKit2

Reverted r159603, as it appears to have caused Safari’s Web processes to crash on launch.

Requested by Sam Weinig.

  • Scripts/webkit2/messages.py:

(struct_or_class):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • Shared/mac/ObjCObjectGraphCoders.h:
  • Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::ObjCObjectGraphEncoder::baseEncode):
(WebKit::WebContextObjCObjectGraphEncoderImpl::WebContextObjCObjectGraphEncoderImpl):
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode):
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):
(WebKit::WebContextObjCObjectGraphEncoder::WebContextObjCObjectGraphEncoder):
(WebKit::WebContextObjCObjectGraphEncoder::encode):

  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::encodeMessageBody):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveSyncMessage):

  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

  • UIProcess/WebPageGroup.cpp:
  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::postMessageToInjectedBundle):
(WebKit::WebPageProxy::initializeCreationParameters):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPageGroup):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
9:36 AM Changeset in webkit [159630] by commit-queue@webkit.org
  • 15 edits in trunk/Source

[WinCairo] Building ANGLE libraries fails.
​https://bugs.webkit.org/show_bug.cgi?id=124679

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-11-21
Reviewed by Brent Fulgham.

Source/ThirdParty/ANGLE:

Added/removed files to/from project, and re-added constants.h file.

  • ANGLE.vcxproj/libEGL.vcxproj:
  • ANGLE.vcxproj/libEGL.vcxproj.filters:
  • ANGLE.vcxproj/libGLESv2.vcxproj:
  • ANGLE.vcxproj/libGLESv2.vcxproj.filters:
  • ANGLE.vcxproj/libGLESv2Common.props:
  • ANGLE.vcxproj/translator_common.vcxproj:
  • ANGLE.vcxproj/translator_common.vcxproj.filters:
  • ANGLE.vcxproj/translator_glsl.vcxproj:
  • ANGLE.vcxproj/translator_glsl.vcxproj.filters:
  • ANGLE.vcxproj/translator_hlsl.vcxproj:
  • ANGLE.vcxproj/translator_hlsl.vcxproj.filters:
  • src/libGLESv2/libGLESv2.def:

Source/WebKit:

  • WebKit.vcxproj/WebKit/WebKitCFLite.props: Link with translator_hlsl.lib.
9:11 AM Changeset in webkit [159629] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Fix sh4 build after r159545.
​https://bugs.webkit.org/show_bug.cgi?id=124713

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-21
Reviewed by Michael Saboff.

Add missing implementations in macro assembler and LLINT for sh4.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::store8):
(JSC::MacroAssemblerSH4::memoryFence):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::synco):

  • offlineasm/sh4.rb: Handle "memfence" opcode.
8:50 AM Changeset in webkit [159628] by stavila@adobe.com
  • 1 edit
    4 adds in trunk/LayoutTests

Added test for the overflow of a region being painted across multiple tiles.
Added test for correct repainting of a region's overflow.

[CSS Regions] Overflow areas from regions do not redraw
​https://bugs.webkit.org/show_bug.cgi?id=117329

Reviewed by Antti Koivisto.

  • fast/regions/regions-overflow-tile-expected.html: Added.
  • fast/regions/regions-overflow-tile.html: Added.
  • fast/repaint/repaint-regions-overflow-expected.txt: Added.
  • fast/repaint/repaint-regions-overflow.html: Added.
8:48 AM WebKitGTK/Debugging edited by Andres Gomez
(diff)
8:45 AM WebKitGTK/Debugging edited by Andres Gomez
(diff)
8:44 AM WebKitGTK/Debugging edited by Andres Gomez
(diff)
8:13 AM BuildingGtk edited by Andres Gomez
(diff)
8:12 AM BuildingGtk edited by Andres Gomez
(diff)
8:12 AM BuildingGtk edited by Andres Gomez
(diff)
8:11 AM BuildingGtk edited by Andres Gomez
(diff)
8:00 AM WebKitGTK/StartHacking edited by Andres Gomez
(diff)
7:43 AM Changeset in webkit [159627] by stavila@adobe.com
  • 1 edit
    2 adds in trunk/LayoutTests

[CSS Regions] Float get sliced if its container has forced break and is less tall than float
​https://bugs.webkit.org/show_bug.cgi?id=124205

Added test for the case when a float is overflowing a region due to a forced break.

Reviewed by Antti Koivisto.

  • fast/regions/float-slicing-on-forced-break-expected.html: Added.
  • fast/regions/float-slicing-on-forced-break.html: Added.
7:17 AM Changeset in webkit [159626] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Fix hover area for divs with css transforms
​https://bugs.webkit.org/show_bug.cgi?id=124647

Patch by Mihai Maerean <Mihai Maerean> on 2013-11-21
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

Non transformed layers are now being hit last, not through or in-between transformed layers.
The paint order says that the divs creating stacking contexts (including transforms) are painted after the
other siblings so they should be hit tested in the reverse order. Also, a rotated div in a non-rotated parent
should be hit in its entire area, not hit its parent's background, even if the z-coordinate is negative where
the mouse is located.

Test: transforms/3d/hit-testing/hover-rotated-negative-z.html

  • rendering/RenderLayer.cpp:

(WebCore::computeZOffset):

LayoutTests:

  • transforms/3d/hit-testing/hover-rotated-negative-z.html: Added.
  • transforms/3d/hit-testing/hover-rotated-negative-z-expected.txt: Added.
6:58 AM Changeset in webkit [159625] by stavila@adobe.com
  • 1 edit
    2 adds in trunk/LayoutTests

Created test for positioned fragmented content which overflows the regions.

[CSS Regions] Fragmented content that is relatively positioned get sliced (and overflows in the next region)
​https://bugs.webkit.org/show_bug.cgi?id=117122

Reviewed by Antti Koivisto.

  • fast/regions/positioned-fragmented-content-expected.html: Added.
  • fast/regions/positioned-fragmented-content.html: Added.
6:57 AM Changeset in webkit [159624] by stavila@adobe.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added test for visual overflow with transformed content in regions.

[CSS Regions] Transform applied to content node causes overflow to be hidden
​https://bugs.webkit.org/show_bug.cgi?id=116242

Reviewed by Antti Koivisto.

  • fast/regions/region-visual-overflow-transform-expected.html: Added.
  • fast/regions/region-visual-overflow-transform.html: Added.
6:53 AM Changeset in webkit [159623] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Release compilation fails when defining "LOG_DISABLED=0"
​https://bugs.webkit.org/show_bug.cgi?id=124661

Patch by Andres Gomez <Andres Gomez> on 2013-11-21
Reviewed by Mario Sanchez Prada.

In a "Debug" build the CString.h header comes from another
indirect dependency. Now, we explicitly add this missing include.

  • html/HTMLTrackElement.cpp: Explicitly adding missing include.
6:52 AM Changeset in webkit [159622] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Fix accessibility media-element expectation
​https://bugs.webkit.org/show_bug.cgi?id=124711

Unreviewed EFL gardening.

Changing main element AXRole AXUnknown -> AXEmbedded.

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2013-11-21

  • platform/efl/accessibility/media-element-expected.txt:
6:25 AM Changeset in webkit [159621] by Michał Pakuła vel Rutka
  • 5 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Update baselines after r159575.

  • platform/efl/fast/block/float/024-expected.txt:
  • platform/efl/fast/block/margin-collapse/025-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
5:52 AM Changeset in webkit [159620] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Fix Range.insertNode when the inserted node is in the same container as the Range
​https://bugs.webkit.org/show_bug.cgi?id=123957

Reviewed by Antti Koivisto.

Source/WebCore:

Inspired by ​https://chromium.googlesource.com/chromium/blink/+/fb6ca1f488703e8d4f20ce6449cc8ea210be6edb

When a node from the same container is inserted, we can't simply adjust m_end with the offset.
Compute m_start and m_end from the inserted nodes instead.

Also, don't adjust m_start and m_end to nodes outside of the document if the inserted nodes had been
removed by mutation events.

Test: fast/dom/Range/range-insertNode-same-container.html

  • dom/Range.cpp:

(WebCore::Range::insertNode):

LayoutTests:

Merge ​https://chromium.googlesource.com/chromium/blink/+/fb6ca1f488703e8d4f20ce6449cc8ea210be6edb

Used better labels between divs, and added more evalAndLog and shouldBe so that
the expected result is self-explanatory.

  • fast/dom/Range/range-insertNode-same-container-expected.txt: Added.
  • fast/dom/Range/range-insertNode-same-container.html: Added.
5:46 AM Changeset in webkit [159619] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

nextBoundary and previousBoundary are very slow when there is a password field
​https://bugs.webkit.org/show_bug.cgi?id=123973

Reviewed by Antti Koivisto.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/57366eec5e3edea54062d4e74c0e047f8681dbad

When iterating through DOM nodes nextBoundary and previousBoundary convert the contents of nodes using
text security to a sequence of 'x' characters. The SimplifiedBackwardsTextIterator and TextIterator
may iterate past node boundaries. Before this patch, the transformation was done looking at the starting
node rather than the current node. In some situations, this replaced all boundaries with 'x' and caused
the text iterator to continue iterating and transforming until the extent of the document.

Test: editing/deleting/password-delete-performance.html

  • editing/TextIterator.h:

(WebCore::SimplifiedBackwardsTextIterator::node):

  • editing/VisibleUnits.cpp:

(WebCore::previousBoundary):
(WebCore::nextBoundary):

LayoutTests:

  • editing/deleting/password-delete-performance-expected.txt: Added.
  • editing/deleting/password-delete-performance.html: Added.
5:43 AM Changeset in webkit [159618] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

HTML parser should not associate elements inside templates with forms
​https://bugs.webkit.org/show_bug.cgi?id=117779

Reviewed by Antti Koivisto.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/45aadf7ee7ee010327eb692066cf013315ef3ed7

When parsing <form><template><input>, the previous behavior was to associate the <input> with the <form>,
even though they're not in the same tree (or even the same document).

This patch changes that by checking, prior to creating a form control element, whether the element to be
created lives in a document with a browsing context.

We don't update m_form as needed to faithfully match the HTML5 specification's form element pointer
​http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#form-element-pointer
and its algorithm for creating and inserting nodes:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#creating-and-inserting-nodes

While this leaves isindex's reference to form element pointer stale:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#isindex
The HTML5 specification matches the behaviors of Chrome and Firefox so we leave it as is.

Test: fast/dom/HTMLTemplateElement/no-form-association.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createHTMLElement):

LayoutTests:

  • fast/dom/HTMLTemplateElement/no-form-association-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/no-form-association.html: Added.
5:22 AM Changeset in webkit [159617] by rniwa@webkit.org
  • 4 edits in trunk/Tools

PerfTestRunner._generate_results_dict shouldn't depend on test objects
​https://bugs.webkit.org/show_bug.cgi?id=124623

Removed the dependency on test objects from results JSON generation.
This allows single test.run to return metrics for multiple tests

Reviewed by Antti Koivisto.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTestMetric.init): Takes the test path and test name.
(PerfTestMetric.path): Added.
(PerfTestMetric.test_file_name): Added.
(PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
(PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
The path is going to have the names of subtests at the end once we support them.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
(TestPerfTestMetric.test_init_set_time_metric): Ditto.
(TestPerfTestMetric.test_has_values): Ditto.
(TestPerfTestMetric.test_append): Ditto.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(_generate_results_dict): Only use metrics.
(_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.

4:56 AM WebKitGTK/StartHacking edited by Andres Gomez
(diff)
4:26 AM Changeset in webkit [159616] by Manuel Rego Casasnovas
  • 2 edits in trunk/Tools

REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
​https://bugs.webkit.org/show_bug.cgi?id=124697

Reviewed by Ryosuke Niwa.

  • Scripts/webkitdirs.pm:

(checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
before trying to access to the first element.

12:52 AM Changeset in webkit [159615] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Cannot scroll in option menu when it larger than the screen
​https://bugs.webkit.org/show_bug.cgi?id=124671

Reviewed by Martin Robinson.

The problem is that the popup menu is not resized to fit in the
screen, so it doesn't scroll and some of the items are offscreen
so they can't be selected either. GTK+ automatically resizes the
popup menus to fit in the work area, but only when the menu is
already positioned.

  • platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::popUp): Schedule a resize of the popup
menu right after showing it once it has a position.

12:38 AM Changeset in webkit [159614] by Carlos Garcia Campos
  • 12 edits
    3 copies in trunk

[GTK] Mark all deprecated symbols in GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=124406

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Move deprecated API from WebKitDOMCustom to a new file
WebKitDOMDeprecated leaving in WebKitDOMCustom only the
non-deprecated API that is not autogenerated. Also added the
deprecation decorations and tags in the documentation.

  • bindings/gobject/GNUmakefile.am:
  • bindings/gobject/WebKitDOMCustom.cpp:
  • bindings/gobject/WebKitDOMCustom.h:
  • bindings/gobject/WebKitDOMCustom.symbols:
  • bindings/gobject/WebKitDOMDeprecated.cpp: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp.

(webkit_dom_blob_webkit_slice):
(webkit_dom_html_element_get_id):
(webkit_dom_html_element_set_id):
(webkit_dom_html_element_get_class_name):
(webkit_dom_html_element_set_class_name):
(webkit_dom_html_element_get_class_list):
(webkit_dom_html_form_element_dispatch_form_change):
(webkit_dom_html_form_element_dispatch_form_input):
(webkit_dom_webkit_named_flow_get_overflow):
(webkit_dom_element_get_webkit_region_overflow):
(webkit_dom_webkit_named_flow_get_content_nodes):
(webkit_dom_webkit_named_flow_get_regions_by_content_node):
(webkit_dom_bar_info_get_property):
(webkit_dom_bar_info_class_init):
(webkit_dom_bar_info_init):
(webkit_dom_bar_info_get_visible):
(webkit_dom_console_get_memory):
(webkit_dom_css_style_declaration_get_property_css_value):
(webkit_dom_document_get_webkit_hidden):
(webkit_dom_document_get_webkit_visibility_state):
(webkit_dom_html_document_open):
(webkit_dom_html_element_set_item_id):
(webkit_dom_html_element_get_item_id):
(webkit_dom_html_element_get_item_ref):
(webkit_dom_html_element_get_item_prop):
(webkit_dom_html_element_set_item_scope):
(webkit_dom_html_element_get_item_scope):
(webkit_dom_html_element_get_item_type):
(webkit_dom_html_style_element_set_scoped):
(webkit_dom_html_style_element_get_scoped):
(webkit_dom_html_properties_collection_get_property):
(webkit_dom_html_properties_collection_class_init):
(webkit_dom_html_properties_collection_init):
(webkit_dom_html_properties_collection_item):
(webkit_dom_html_properties_collection_named_item):
(webkit_dom_html_properties_collection_get_length):
(webkit_dom_html_properties_collection_get_names):
(webkit_dom_node_get_attributes):
(webkit_dom_node_has_attributes):
(webkit_dom_memory_info_get_property):
(webkit_dom_memory_info_class_init):
(webkit_dom_memory_info_init):
(webkit_dom_memory_info_get_total_js_heap_size):
(webkit_dom_memory_info_get_used_js_heap_size):
(webkit_dom_memory_info_get_js_heap_size_limit):
(webkit_dom_micro_data_item_value_class_init):
(webkit_dom_micro_data_item_value_init):
(webkit_dom_performance_get_memory):
(webkit_dom_property_node_list_get_property):
(webkit_dom_property_node_list_class_init):
(webkit_dom_property_node_list_init):
(webkit_dom_property_node_list_item):
(webkit_dom_property_node_list_get_length):
(webkit_dom_html_media_element_get_start_time):
(webkit_dom_html_media_element_get_initial_time):
(webkit_dom_html_head_element_get_profile):
(webkit_dom_html_head_element_set_profile):
(webkit_dom_processing_instruction_get_data):
(webkit_dom_processing_instruction_set_data):

  • bindings/gobject/WebKitDOMDeprecated.h: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.h.
  • bindings/gobject/WebKitDOMDeprecated.symbols: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.symbols.
  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction): Do not include deprecation guards in the cpp file.

  • bindings/scripts/gobject-generate-headers.pl: Do not create

fordward declarations for non-existent classes like Custom and
Deprecated.

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(webkit_dom_test_event_target_dispatch_event):

Tools:

  • Scripts/webkitpy/style/checker.py: Add special case for

WebKitDOMDeprecated.

  • gtk/generate-gtkdoc:

(get_webkit2_options): Use the prefix of the methods as namespace,
since this is what gtkdoc expects to sort the index.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Ditto.

  • gtk/generate-webkitdom-doc-files:

(WebKitDOMDocGenerator): Add a global list of deleted objects.
(WebKitDOMDocGenerator.write_deleted_classes): New method to write
the documentation for classes that are deprecated because they
have been removed.
(WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
for deleted classes too.
(WebKitDOMDocGeneratorSections.init): Build a list of
deprecated symbols using the given symbols file.
(WebKitDOMDocGeneratorSections._deleted_class): Returns the
deleted class corresponding to the given function.
(WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
dictionary of deprecated symbols for every class.
(WebKitDOMDocGeneratorSections.write_section): Add also the
deprecated symbols in every section.
(WebKitDOMDocGeneratorSections.write_deleted_classes): Add
sections for deleted classes too.

Nov 20, 2013:

11:52 PM Changeset in webkit [159613] by jae.park@company100.net
  • 6 edits in trunk/Source/WebCore

[CoordinatedGraphics] Use std::unique_ptrs rather than OwnPtrs
​https://bugs.webkit.org/show_bug.cgi?id=124692

Reviewed by Noam Rosenthal.

No new tests, covered by existing ones.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):

  • platform/graphics/TiledBackingStore.h:
  • platform/graphics/TiledBackingStoreBackend.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::createBackingStore):

  • platform/graphics/texmap/coordinated/CoordinatedTile.h:
11:46 PM Changeset in webkit [159612] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style should support C++11 rvalue references.
​https://bugs.webkit.org/show_bug.cgi?id=123406

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-11-20
Reviewed by Brent Fulgham.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_style):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(Cpp11StyleTest):
(Cpp11StyleTest.test_rvaule_reference_at_end_of_line):

11:04 PM Changeset in webkit [159611] by beidson@apple.com
  • 15 edits
    1 copy in trunk/Source

Add more infrastructure for ServerConnection communication between Web and Database processes
​https://bugs.webkit.org/show_bug.cgi?id=124693

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in:

Source/WebKit2:

  • DatabaseProcess/DatabaseToWebProcessConnection.cpp:

(WebKit::DatabaseToWebProcessConnection::establishIDBConnection):
(WebKit::DatabaseToWebProcessConnection::removeDatabaseProcessIDBConnection): Added for WebProcess to be able

to invalidate the DatabaseProcess side of a server connection.

  • DatabaseProcess/DatabaseToWebProcessConnection.h:
  • DatabaseProcess/DatabaseToWebProcessConnection.messages.in:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::DatabaseProcessIDBConnection):
(WebKit::DatabaseProcessIDBConnection::disconnectedFromWebProcess): Added for future cleanup.
(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata): Callback to the WebProcess, even if

it is just dummy data for now.

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:

(WebKit::DatabaseProcessIDBConnection::create):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::create): Register the new object with the WebToDatabaseProcessConnection.
(WebKit::WebIDBServerConnection::~WebIDBServerConnection): Remove from the WebToDatabaseProcessConnection.
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata): Callback from the DatabaseProcess,

a no-op for now.

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in: Copied from Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.messages.in.
  • WebProcess/Databases/WebToDatabaseProcessConnection.cpp:

(WebKit::WebToDatabaseProcessConnection::didReceiveMessage):
(WebKit::WebToDatabaseProcessConnection::didClose):
(WebKit::WebToDatabaseProcessConnection::registerWebIDBServerConnection): Hold a collection of all

server connections for messaging.

(WebKit::WebToDatabaseProcessConnection::removeWebIDBServerConnection): Remove a connection from the collection,

and also message the DatabaseProcess that it’s gone away.

  • WebProcess/Databases/WebToDatabaseProcessConnection.h:

Project files, etc etc:

  • DerivedSources.make:
  • Scripts/webkit2/messages.py:

(struct_or_class):

  • WebKit2.xcodeproj/project.pbxproj:
11:00 PM Changeset in webkit [159610] by rniwa@webkit.org
  • 4 edits in trunk

Hoist <template> to head when found between </head> and <body> for consistency with <script>
​https://bugs.webkit.org/show_bug.cgi?id=123949

Reviewed by Antti Koivisto.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/835fb468fd211054a920fb7612a6dc5043662495

Move template elements between head and body elements into the head to be consistent with script elements.
The HTML5 specification was changed in ​http://html5.org/tools/web-apps-tracker?from=8217&to=8218.

Inline comments below are cited from ​https://www.w3.org/Bugs/Public/show_bug.cgi?id=23002
and ​https://codereview.chromium.org/25900003 for clarity.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTag): Add the template element to the list of elements to be hoisted into
the head element.
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):

Replace the assertion that isParsingFragment is true when item->node() == m_tree.openElements()->rootNode() since,
with this change, we can now invoke resetInsertionMode when parsing a normal document (not fragment) and there is
only the html element on the stack of open elements.

For the second change, consider: <head></head><template>

This example breaks in the old HTML parser because the template element is handled by "after head" state which
pushes the head element back on, processes the template element for "in head", then pops the head element off.
EOF is reached, which processes a fake close tag for the template element, which pops the template element off
and resets the insertion mode appropriately

The problem here is that "reset the insertion mode" is going to inspect the bottom-most element on the stack which
is now the html element and it will set the mode to "before head". Nothing good happens after this.

We fix this problem by having the reset algorithm check if the head element pointer is set, and if so, go to after
head instead of before head.

LayoutTests:

Merge ​https://chromium.googlesource.com/chromium/blink/+/835fb468fd211054a920fb7612a6dc5043662495
and added two more test cases discussed in ​https://www.w3.org/Bugs/Public/show_bug.cgi?id=23002.

  • html5lib/resources/template.dat:
10:57 PM Changeset in webkit [159609] by stavila@adobe.com
  • 51 edits
    1 copy
    18 adds
    5 deletes in trunk

[CSS Regions] Implement visual overflow for first & last regions
​https://bugs.webkit.org/show_bug.cgi?id=118665

Source/WebCore:

In order to properly propagate the visual overflow of elements flowed inside regions,
the responsiblity of painting and hit-testing content inside flow threads has been
moved to the flow thread layer's level.
Each region keeps the associated overflow with each box in the RenderBoxRegionInfo
structure, including one for the flow thread itself. This data is used during
painting and hit-testing.

Reviewed by David Hyatt.

Tests: fast/regions/overflow-first-and-last-regions-in-container-hidden.html

fast/regions/overflow-first-and-last-regions.html
fast/regions/overflow-nested-regions.html
fast/regions/overflow-region-float.html
fast/regions/overflow-region-inline.html
fast/regions/overflow-region-transform.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):

  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::estimateRegionRangeForBoxChild):
(WebCore::RenderBlock::updateRegionRangeForBoxChild):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::hasNextPage):
(WebCore::RenderBlockFlow::relayoutForPagination):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::positionNewFloatOnLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::borderBoxRectInRegion):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::isUnsplittableForPagination):
(WebCore::RenderBox::overflowRectForPaintRejection):

  • rendering/RenderBox.h:

(WebCore::RenderBox::canHaveOutsideRegionRange):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderBoxRegionInfo.h:

(WebCore::RenderBoxRegionInfo::createOverflow):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::objectShouldPaintInFlowRegion):
(WebCore::RenderFlowThread::mapFromLocalToFlowThread):
(WebCore::RenderFlowThread::mapFromFlowThreadToLocal):
(WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):
(WebCore::RenderFlowThread::flipForWritingModeLocalCoordinates):
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):
(WebCore::RenderFlowThread::addRegionsVisualOverflow):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):

  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::expandClipRectForRegionAndReflection):
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::intersectsDamageRect):
(WebCore::RenderLayer::updateDescendantsLayerListsIfNeeded):
(WebCore::RenderLayer::repaintIncludingDescendants):
(WebCore::RenderLayer::paintNamedFlowThreadInsideRegion):
(WebCore::RenderLayer::paintFlowThreadIfRegion):
(WebCore::RenderLayer::hitTestFlowThreadIfRegion):

  • rendering/RenderLayer.h:

(WebCore::ClipRect::inflateX):
(WebCore::ClipRect::inflateY):
(WebCore::ClipRect::inflate):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::addOverflowFromChildren):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::createStyle):
(WebCore::RenderNamedFlowFragment::namedFlowThread):

  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderOverflow.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::flowThreadPortionOverflowRect):
(WebCore::RenderRegion::flowThreadPortionLocation):
(WebCore::RenderRegion::regionContainerLayer):
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
(WebCore::RenderRegion::computeOverflowFromFlowThread):
(WebCore::RenderRegion::repaintFlowThreadContent):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
(WebCore::RenderRegion::insertedIntoTree):
(WebCore::RenderRegion::ensureOverflowForBox):
(WebCore::RenderRegion::rectFlowPortionForBox):
(WebCore::RenderRegion::addLayoutOverflowForBox):
(WebCore::RenderRegion::addVisualOverflowForBox):
(WebCore::RenderRegion::layoutOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):

  • rendering/RenderRegion.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paint):

LayoutTests:

Rebased some tests due to regions layers changes.
Updated some tests to increase clarity. Some of them were only passing because two
regions were close together and the fact that an element was being painted
inside the wrong region was not visible. Floats are now also unsplittable.

  • bottom-overflow-out-of-first-region
  • float-pushed-width-change-2
  • float-pushed-width-change
  • webkit-flow-float-unable-to-push

Changed top-overflow-out-of-second-region to reftest.

Added new tests for testing the visual overflow in different situations
(transformed, inline, opacity, floating).

Reviewed by David Hyatt.

  • fast/regions/bottom-overflow-out-of-first-region-expected.html:
  • fast/regions/bottom-overflow-out-of-first-region.html:
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html:
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html:
  • fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
  • fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
  • fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
  • fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
  • fast/regions/float-pushed-width-change-2-expected.html:
  • fast/regions/float-pushed-width-change-2.html:
  • fast/regions/float-pushed-width-change-expected.html:
  • fast/regions/float-pushed-width-change.html:
  • fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Added.
  • fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Added.
  • fast/regions/layers/regions-promoted-to-layers-expected.txt: Added.
  • fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Added.
  • fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Added.
  • fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Added.
  • fast/regions/outline-sides-in-region-expected.html:
  • fast/regions/outline-sides-in-region.html:
  • fast/regions/overflow-first-and-last-regions-expected.html: Added.
  • fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html: Added.
  • fast/regions/overflow-first-and-last-regions-in-container-hidden.html: Added.
  • fast/regions/overflow-first-and-last-regions.html: Added.
  • fast/regions/overflow-last-region-expected.html: Removed.
  • fast/regions/overflow-last-region.html: Removed.
  • fast/regions/overflow-nested-regions-expected.html: Added.
  • fast/regions/overflow-nested-regions.html: Added.
  • fast/regions/overflow-region-float-expected.html: Added.
  • fast/regions/overflow-region-float.html: Added.
  • fast/regions/overflow-region-inline-expected.html: Added.
  • fast/regions/overflow-region-inline.html: Added.
  • fast/regions/overflow-region-transform-expected.html: Added.
  • fast/regions/overflow-region-transform.html: Added.
  • fast/regions/overflow-scrollable-rotated-fragment-expected.html:
  • fast/regions/overflow-scrollable-rotated-fragment.html:
  • fast/regions/top-overflow-out-of-second-region-expected.html: Copied from LayoutTests/fast/regions/top-overflow-out-of-second-region.html.
  • fast/regions/top-overflow-out-of-second-region.html:
  • fast/regions/webkit-flow-float-unable-to-push-expected.html:
  • fast/regions/webkit-flow-float-unable-to-push.html:
  • platform/gtk/fast/regions/text-region-split-vertical-rl-expected.txt: Removed.
  • platform/gtk/TestExpectations: Add new test expectations for failing tests.
  • platform/efl/TestExpectations: Add new test expectations for failing tests.
  • platform/mac-wk2/TestExpectations:
  • platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
  • platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
10:22 PM Changeset in webkit [159608] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Test a template element appearing after a closing body tag in html5lib
​https://bugs.webkit.org/show_bug.cgi?id=123864

Reviewed by Antti Koivisto.

Merge ​https://chromium.googlesource.com/chromium/blink/+/019d5daa14314972ac6b3e42e9446823ad9cffd2

  • html5lib/resources/template.dat:
10:10 PM Changeset in webkit [159607] by rniwa@webkit.org
  • 4 edits in trunk

[HTML parser] reset insertion mode appropriate must check for "in select in table" mode
​https://bugs.webkit.org/show_bug.cgi?id=123850

Reviewed by Antti Koivisto.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/2cb7523df57dfb48111f6aa16b7138cd54024ba7

The HTML specification has been updated to detect encountering a template element inside of a select element,
which in turn is inside of a table element. In this case, the select element will cause the parser to be in
"InSelectInTable" mode. Thus when the template element closes, it should return to that mode.

The fix here is that resetInsertionModeAppropriately must continue looking up the stack if the first node is
select element to see whether the select element is inside of a table element.

See also: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#reset-the-insertion-mode-appropriately

Test: html5lib/resources/template.dat

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):

LayoutTests:

  • html5lib/resources/template.dat:
9:46 PM Changeset in webkit [159606] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for last commit.
​https://bugs.webkit.org/show_bug.cgi?id=124634.

Not reviewed.

No new tests.

  • bindings/js/JSCryptoAlgorithmBuilder.cpp:
9:29 PM Changeset in webkit [159605] by mark.lam@apple.com
  • 63 edits
    3 adds
    1 delete in trunk/Source

Introducing VMEntryScope to update the VM stack limit.
​https://bugs.webkit.org/show_bug.cgi?id=124634.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  1. Introduced USE(SEPARATE_C_AND_JS_STACK) (defined in Platform.h). Currently, it is hardcoded to use separate C and JS stacks. Once we switch to using the C stack for JS frames, we'll need to fix this to only be enabled when ENABLE(LLINT_C_LOOP).
  1. Stack limits are now tracked in the VM.

Logically, there are 2 stack limits:

  1. m_stackLimit for the native C stack, and
  2. m_jsStackLimit for the JS stack.

If USE(SEPARATE_C_AND_JS_STACK), then the 2 limits are the same
value, and are implemented as 2 fields in a union.

  1. The VM native stackLimit is set as follows:
    1. Initially, the VM sets it to the limit of the stack of the thread that instantiated the VM. This allows the parser and bytecode generator to run before we enter the VM to execute JS code.
  1. Upon entry into the VM to execute JS code (via one of the Interpreter::execute...() functions), we instantiate a VMEntryScope that sets the VM's stackLimit to the limit of the current thread's stack. The VMEntryScope will automatically restore the previous entryScope and stack limit upon destruction.

If USE(SEPARATE_C_AND_JS_STACK), the JSStack's methods will set the VM's
jsStackLimit whenever it grows or shrinks.

  1. The VM now provides a isSafeToRecurse() function that compares the current stack pointer against its native stackLimit. This subsumes and obsoletes the VMStackBounds class.
  1. The VMEntryScope class also subsumes DynamicGlobalObjectScope for tracking the JSGlobalObject that we last entered the VM with.
  1. Renamed dynamicGlobalObject() to vmEntryGlobalObject() since that is the value that the function retrieves.
  1. Changed JIT and LLINT code to do stack checks against the jsStackLimit in the VM class instead of the JSStack.
  • API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

  • API/JSContextRef.cpp:

(JSGlobalContextRetain):
(JSGlobalContextRelease):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):

  • debugger/Debugger.cpp:

(JSC::Debugger::detach):
(JSC::Debugger::recompileAllJSFunctions):
(JSC::Debugger::pauseIfNeeded):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::vmEntryGlobalObject):

  • debugger/DebuggerCallFrame.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGOSREntry.cpp:
  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLOSREntry.cpp:
  • heap/Heap.cpp:

(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::deleteAllCompiledCode):

  • interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::vmEntryGlobalObject):

  • interpreter/CallFrame.h:
  • interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):
(JSC::Interpreter::unwind):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::debug):

  • interpreter/JSStack.cpp:

(JSC::JSStack::JSStack):
(JSC::JSStack::growSlowCase):

  • interpreter/JSStack.h:
  • interpreter/JSStackInlines.h:

(JSC::JSStack::shrink):
(JSC::JSStack::grow):

  • Moved these inlined functions here from JSStack.h. It reduces some #include dependencies of JSSTack.h which had previously resulted in some EWS bots' unhappiness with this patch.

(JSC::JSStack::updateStackLimit):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITOperations.cpp:
  • llint/LLIntSlowPaths.cpp:
  • llint/LowLevelInterpreter.asm:
  • parser/Parser.cpp:

(JSC::::Parser):

  • parser/Parser.h:

(JSC::Parser::canRecurse):

  • runtime/CommonSlowPaths.h:
  • runtime/Completion.cpp:

(JSC::evaluate):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/StringRecursionChecker.h:

(JSC::StringRecursionChecker::performCheck):

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::releaseExecutableMemory):
(JSC::VM::throwException):

  • runtime/VM.h:

(JSC::VM::addressOfJSStackLimit):
(JSC::VM::jsStackLimit):
(JSC::VM::setJSStackLimit):
(JSC::VM::stackLimit):
(JSC::VM::setStackLimit):
(JSC::VM::isSafeToRecurse):

  • runtime/VMEntryScope.cpp: Added.

(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):
(JSC::VMEntryScope::requiredCapacity):

  • runtime/VMEntryScope.h: Added.

(JSC::VMEntryScope::globalObject):

  • runtime/VMStackBounds.h: Removed.

Source/WebCore:

No new tests.

Renamed dynamicGlobalObject() to vmEntryGlobalObject().
Replaced uses of DynamicGlobalObjectScope with VMEntryScope.

  • ForwardingHeaders/runtime/VMEntryScope.h: Added.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • bindings/js/JSCryptoAlgorithmBuilder.cpp:

(WebCore::JSCryptoAlgorithmBuilder::add):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::create):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::firstDOMWindow):

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JavaScriptCallFrame.h:

(WebCore::JavaScriptCallFrame::vmEntryGlobalObject):

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::recompileAllJSFunctions):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::evaluateBreakpointAction):
(WebCore::ScriptDebugServer::handlePause):

  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):

  • bindings/objc/WebScriptObject.mm:

(WebCore::addExceptionToConsole):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::moveGlobalExceptionToExecState):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::convertValueToObjcObject):

  • bridge/objc/objc_utility.mm:

(JSC::Bindings::convertValueToObjcValue):

Source/WebKit/mac:

  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::sourceParsed):

Source/WTF:

  • wtf/Platform.h:
  • wtf/StackBounds.h:

(WTF::StackBounds::StackBounds):

8:45 PM Changeset in webkit [159604] by gyuyoung.kim@samsung.com
  • 19 edits in trunk/Source/WebCore

Generate toHTMLFooElement() to clean up static_cast<>
​https://bugs.webkit.org/show_bug.cgi?id=124571

Reviewed by Ryosuke Niwa.

Though there are a lot of clean up commits before, there are still
use of static_cast<HTMLFooElement*>. To clean up them, we need to generate
toHTMLDetails|Meta|Summary|TableCaptionElement().

Additionally, other static_cast<> are removed as well.

No new tests, no behavior changes.

  • html/HTMLDetailsElement.h:
  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::selectNextSourceChild):

  • html/HTMLMetaElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::isDisabledFormControl):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateWidgetCallback):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::detailsElement):

  • html/HTMLSummaryElement.h:
  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption):

  • html/HTMLTagNames.in:
  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::summaryElement):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

  • page/DragController.cpp:

(WebCore::DragController::canProcessDrag):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

  • page/SpatialNavigation.cpp:

(WebCore::frameOwnerElement):

8:09 PM Changeset in webkit [159603] by weinig@apple.com
  • 21 edits in trunk/Source/WebKit2

WebPageGroup's should keep track of what processes they are being used by
​https://bugs.webkit.org/show_bug.cgi?id=124556

Reviewed by Dan Bernstein.

  • Scripts/webkit2/messages.py:

(struct_or_class):
Mark WebPageGroupData as a struct.

  • Shared/UserMessageCoders.h:
  • Shared/mac/ObjCObjectGraphCoders.h:
  • Shared/mac/ObjCObjectGraphCoders.mm:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
  • UIProcess/WebConnectionToWebProcess.cpp:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContextUserMessageCoders.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:

Pass the WebProcess/WebProcessProxy to both encode and decode.

  • Shared/WebPageCreationParameters.h:

Pass the page group by ID when creating a page, as it will have had its own
creation message sent already.

  • UIProcess/WebPageGroup.cpp:
  • UIProcess/WebPageGroup.h:

Keep track of processes.

  • UIProcess/WebProcessProxy.cpp:
  • UIProcess/WebProcessProxy.h:

Keep track of the page groups used by the process.

  • WebProcess/WebPage/WebPage.cpp:

Get the already created page group on creation.

  • WebProcess/WebProcess.cpp:
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Explicitly create page groups in the WebProcess.

6:00 PM Changeset in webkit [159602] by dino@apple.com
  • 4 edits in trunk/Tools

Allow settings to be shown/hidden on build.webkit.org/dashboard
​https://bugs.webkit.org/show_bug.cgi?id=124694

Reviewed by Tim Horton.

In preparation for more options/buttons, allow the page to
show or hide all the interactive things using a little gear icon
in the top left corner.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:

(Settings.prototype.toggleSettingsDisplay):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(div.cellButton.hide):
(div.cellButton.unhide):
(.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
(.settings):
(.settings:hover):
(.settings-visible .settings):

5:59 PM Changeset in webkit [159601] by dino@apple.com
  • 2 edits in trunk/Tools

No need to base64 SVG on build.webkit.org/dashboard
​https://bugs.webkit.org/show_bug.cgi?id=124687

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:

(.status-line.good .bubble.pictogram):

5:59 PM Changeset in webkit [159600] by dino@apple.com
  • 3 edits in trunk/Tools

Make links look more like links on build.webkit.org/dashboard
​https://bugs.webkit.org/show_bug.cgi?id=124686

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:

(.queue-view .queueLabel:hover):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:

(.status-line.linked .label:hover):

5:39 PM Changeset in webkit [159599] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
​https://bugs.webkit.org/show_bug.cgi?id=124581

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-11-20
Reviewed by Daniel Bates.

Some subroutines are replicating code from checkForArgument
functions instead of reusing them as is being done by all other functions.

  • Scripts/webkitdirs.pm:

(determineXcodeSDK): Added.
(determinePassedConfiguration): Added.
(determinePassedArchitecture): Added.
(checkForArgumentAndRemoveFromARGV): Added.
(checkForArgumentAndRemoveFromARGVGettingValue): Added.

5:28 PM Changeset in webkit [159598] by beidson@apple.com
  • 8 edits in trunk/Source/WebKit2

IDB related cleanup in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=124691

Reviewed by Enrica Casucci.

  • WebIDBServerConnection.cpp should use the WebCore namespace and get rid of "WebCore::" throughout
  • "backendIndentifier" should be renamed to "serverConnectionIdentifier" throughout
  • DatabaseProcess/DatabaseToWebProcessConnection.cpp:

(WebKit::DatabaseToWebProcessConnection::establishIDBConnection):

  • DatabaseProcess/DatabaseToWebProcessConnection.h:
  • DatabaseProcess/DatabaseToWebProcessConnection.messages.in:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::DatabaseProcessIDBConnection):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:

(WebKit::DatabaseProcessIDBConnection::create):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::generateServerConnectionIdentifier):
(WebKit::WebIDBServerConnection::WebIDBServerConnection):
(WebKit::WebIDBServerConnection::openTransaction):
(WebKit::WebIDBServerConnection::setIndexKeys):
(WebKit::WebIDBServerConnection::createObjectStore):
(WebKit::WebIDBServerConnection::createIndex):
(WebKit::WebIDBServerConnection::deleteIndex):
(WebKit::WebIDBServerConnection::get):
(WebKit::WebIDBServerConnection::put):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::count):
(WebKit::WebIDBServerConnection::deleteRange):
(WebKit::WebIDBServerConnection::clearObjectStore):
(WebKit::WebIDBServerConnection::deleteObjectStore):
(WebKit::WebIDBServerConnection::changeDatabaseVersion):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):
(WebKit::WebIDBServerConnection::cursorPrefetchIteration):
(WebKit::WebIDBServerConnection::cursorPrefetchReset):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
5:11 PM Changeset in webkit [159597] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit2

Add argument coders for IDBDatabaseMetadata classes
​https://bugs.webkit.org/show_bug.cgi?id=124689

Reviewed by Anders Carlsson.

Add coders for:

  • IDBDatabaseMetadata
  • IDBIndexMetadata
  • IDBKeyPath
  • IDBObjectStoreMetadata
  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:
5:07 PM Changeset in webkit [159596] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

Clear TemplateContentDocumentFragment::m_host when HTMLTemplateElement is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=122806

Reviewed by Antti Koivisto.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/858ed5f6341de9d900768c1f4668fcfce870c52e

The document fragment of a template element outlives the element itself.
Clear the host property on the document fragment when that happens.

Test: fast/dom/HTMLTemplateElement/content-outlives-template-crash.html

  • dom/TemplateContentDocumentFragment.h:
  • html/HTMLTemplateElement.cpp:

(WebCore::HTMLTemplateElement::~HTMLTemplateElement):

  • html/HTMLTemplateElement.h:

LayoutTests:

  • fast/dom/HTMLTemplateElement/content-outlives-template-crash-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/content-outlives-template-crash.html: Added.
4:54 PM Changeset in webkit [159595] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk/Tools

Delete baseline optimizer
​https://bugs.webkit.org/show_bug.cgi?id=122333

Patch by Jozsef Berta <​jberta@inf.u-szeged.hu> on 2013-11-20
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest.execute):
(AbstractParallelRebaselineCommand._files_to_add):
(AbstractParallelRebaselineCommand._rebaseline):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineJson.test_rebaseline_all):
(TestRebaselineJson.test_rebaseline_debug):
(TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):

4:42 PM Changeset in webkit [159594] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

4:42 PM Changeset in webkit [159593] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

[Win] JavaScript JIT crash (with DFG enabled).
​https://bugs.webkit.org/show_bug.cgi?id=124675

Reviewed by Geoffrey Garen.

Similar to the change in r159427, changed linkClosureCall to use regT0/regT1 (payload/tag) for the callee.
linkForThunkGenerator already expected the callee in regT0/regT1, but changed the comment to reflect that.

  • jit/Repatch.cpp:

(JSC::linkClosureCall):

  • jit/ThunkGenerators.cpp:

(JSC::linkForThunkGenerator):

4:41 PM Changeset in webkit [159592] by Lucas Forschler
  • 1 copy in tags/Safari-537.73.13

New Tag.

4:28 PM Changeset in webkit [159591] by Chris Fleizach
  • 16 edits
    2 adds in trunk

AX: Implement CSS -webkit-alt property (text alternative for generated content pseudo-elements ::before and ::after)
​https://bugs.webkit.org/show_bug.cgi?id=120188

Reviewed by Dean Jackson.

Source/WebCore:

Add a -webkit-alt CSS property that can be used to label Image content or Text content for accessibility clients.

To accomplish this, it sets the string in the RenderStyle. Then when the ContentData creates an anonymous renderer,
it sets that string on the TextFragment or RenderImage, which can be queried by accessibility code.

Test: platform/mac/accessibility/webkit-alt-for-css-content.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::alternativeText):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):
(WebCore::objectInclusionFromAltText):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::altTextToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAlt):

  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/RenderImage.h:

(WebCore::RenderImage::altText):
(WebCore::RenderImage::setAltText):

  • rendering/RenderTextFragment.h:
  • rendering/style/ContentData.cpp:

(WebCore::ImageContentData::createRenderer):
(WebCore::TextContentData::createRenderer):

  • rendering/style/ContentData.h:

(WebCore::ContentData::setAltText):
(WebCore::ContentData::altText):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setContent):
(WebCore::RenderStyle::setContentAltText):
(WebCore::RenderStyle::contentAltText):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • platform/mac/accessibility/webkit-alt-for-css-content-expected.txt: Added.
  • platform/mac/accessibility/webkit-alt-for-css-content.html: Added.
4:05 PM Changeset in webkit [159590] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Use compile flag SH_UNFOLD_SHORT_CIRCUIT when compiling shaders.
​https://bugs.webkit.org/show_bug.cgi?id=124684.

Reviewed by Brent Fulgham.

Existing test webgl/1.0.2/conformance/glsl/misc/shader-with-short-circuiting-operators.html

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

3:55 PM Changeset in webkit [159589] by dino@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed. Updated expected result following
​https://bugs.webkit.org/show_bug.cgi?id=124666

  • platform/mac/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/mac/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
3:36 PM Changeset in webkit [159588] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-537.73-branch

Merged r159481. <rdar://problem/15517466>

3:25 PM Changeset in webkit [159587] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source/WebCore

[curl] Improve detecting and handling of SSL related errors
​https://bugs.webkit.org/show_bug.cgi?id=119436

Patch by Robert Sipka <​sipka@inf.u-szeged.hu> on 2013-11-20
Reviewed by Brent Fulgham.

Set the exact SSL verification error on CURL
and store the enabled domain with certificate.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

  • platform/network/curl/ResourceError.h:

(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::sslErrors):
(WebCore::ResourceError::setSSLErrors):

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::initializeHandle):

  • platform/network/curl/SSLHandle.cpp: Added.

(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::sslCertificateFlag):
(WebCore::pemData):
(WebCore::certVerifyCallback):
(WebCore::sslctxfun):
(WebCore::setSSLVerifyOptions):

  • platform/network/curl/SSLHandle.h: Added.
3:22 PM Changeset in webkit [159586] by andersca@apple.com
  • 4 edits in trunk

Enable PageLoadTest assertions again
​https://bugs.webkit.org/show_bug.cgi?id=124681

Reviewed by Tim Horton.

Source/WebKit2:

Remove an overzealous assertion and re-enable assertions in PageLoadState again.

  • UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::didCommitLoad):
Remove assertion - it's fine for a page to have a null URL.

(WebKit::PageLoadState::didFinishLoad):
Ditto.

(WebKit::PageLoadState::didFailLoad):
Update the state.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.

2:55 PM Changeset in webkit [159585] by Bem Jones-Bey
  • 16 edits in trunk

[css shapes] Parse new circle shape syntax
​https://bugs.webkit.org/show_bug.cgi?id=124618

Reviewed by Antti Koivisto.

Source/WebCore:

Implement parsing of the new cicle shape syntax. The implementation of
the old syntax has been move aside as deprecated, and will be removed
once the new syntax is stable.

Updated existing parsing tests to cover this.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForCenterCoordinate): Create a CSSPrimitiveValue from a

BasicShapeCenterCoordinate.

(WebCore::valueForBasicShape): Convert new basic shape and rename old

one.

(WebCore::convertToCenterCoordinate): Create a

BasicShapeCenterCoordinate from a CSSPrimitiveValue.

(WebCore::basicShapeForValue): Convert new shape value and rename old

one.

  • css/CSSBasicShapes.cpp:

(WebCore::buildCircleString): Build a new circle string.
(WebCore::CSSBasicShapeCircle::cssText): Serialize the new circle

shape.

(WebCore::CSSBasicShapeCircle::equals): Compare new circle shapes.
(WebCore::CSSBasicShapeCircle::serializeResolvingVariables):

  • css/CSSBasicShapes.h:

(WebCore::CSSBasicShapeCircle::CSSBasicShapeCircle): Add class for new

circle shape.

(WebCore::CSSDeprecatedBasicShapeCircle::create): Renamed to move out

of the way of the new circle implementation.

(WebCore::CSSDeprecatedBasicShapeCircle::centerX): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::centerY): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::radius): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::setCenterX): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::setCenterY): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::setRadius): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::CSSDeprecatedBasicShapeCircle): Ditto.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShapeRadius): Parse the radius for the new

circle syntax. Will also be used by the new ellipse syntax.

(WebCore::CSSParser::parseBasicShapeCircle): Parse the new circle

syntax.

(WebCore::CSSParser::parseDeprecatedBasicShapeCircle): Rename to make

way for the new implementation.

(WebCore::isDeprecatedBasicShape): Check if we have a new circle or an

old circle.

(WebCore::CSSParser::parseBasicShape): Update to parse the new circle

syntax.

  • css/CSSParser.h:
  • css/CSSValueKeywords.in: Add support for the new circle keywords.
  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

  • rendering/style/BasicShapes.cpp: Deprecate old circle and add stub

for layout code.

(WebCore::DeprecatedBasicShapeCircle::path): Rename to make way for

the new implementation.

(WebCore::DeprecatedBasicShapeCircle::blend): Rename to make way for

the new implementation.

(WebCore::BasicShapeCircle::path): Create path for new circle shape.
(WebCore::BasicShapeCircle::blend): Interpolate the new circle shape.

  • rendering/style/BasicShapes.h:

(WebCore::BasicShapeCenterCoordinate::BasicShapeCenterCoordinate):

Represent an x or y coordinate for the center of a new circle,
since it can be either a keyword along with an offset that cannot
be resolved until layout time or an ordinary Length. This will
also be used by the new ellipse implementation.

(WebCore::BasicShapeCenterCoordinate::keyword):
(WebCore::BasicShapeCenterCoordinate::length):
(WebCore::BasicShapeCenterCoordinate::blend): Interpolate.
(WebCore::BasicShapeRadius::BasicShapeRadius): Represent the radius of

a new circle shape since it can either be a straightforward Length or
a keyword that cannot be resolved until layout time.

(WebCore::BasicShapeRadius::value):
(WebCore::BasicShapeRadius::type):
(WebCore::BasicShapeRadius::blend): Interpolate.
(WebCore::BasicShapeCircle::centerX):
(WebCore::BasicShapeCircle::centerY):
(WebCore::BasicShapeCircle::radius):
(WebCore::BasicShapeCircle::setCenterX):
(WebCore::BasicShapeCircle::setCenterY):
(WebCore::BasicShapeCircle::setRadius):
(WebCore::BasicShapeCircle::BasicShapeCircle): New circle class.
(WebCore::DeprecatedBasicShapeCircle::create): Rename to make room for

new circle implementation.

(WebCore::DeprecatedBasicShapeCircle::DeprecatedBasicShapeCircle): Ditto.

LayoutTests:

Test that the new circle shape syntax is properly parsed.

  • fast/shapes/parsing/parsing-shape-inside-expected.txt:
  • fast/shapes/parsing/parsing-shape-outside-expected.txt:
  • fast/shapes/parsing/parsing-test-utils.js:
  • fast/masking/parsing-clip-path-shape-expected.txt:
  • fast/masking/parsing-clip-path-shape.html:
2:22 PM Changeset in webkit [159584] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

PageLoadState should keep track of unreachable URLs
​https://bugs.webkit.org/show_bug.cgi?id=124677

Reviewed by Dan Bernstein.

  • UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::didStartProvisionalLoad):
(WebKit::PageLoadState::didFailProvisionalLoad):
(WebKit::PageLoadState::setUnreachableURL):

  • UIProcess/PageLoadState.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadAlternateHTMLString):

2:21 PM Changeset in webkit [159583] by hmuller@adobe.com
  • 7 edits
    4 adds in trunk/Source/WebCore

[CSS Shapes] Add BoxShape and FloatRoundingRect classes
​https://bugs.webkit.org/show_bug.cgi?id=124368

Reviewed by Dean Jackson.

Added the BoxShape class. It's now used to represent shape-outside box
values: [margin/border/padding/content]-box. BoxShape depends on a new
FloatRoundedRect class, which is a float analog of the existing (int)
RoundedRect class. The FloatRoundedRect class contains the same basic
methods and accessors as BorderRect and adds a set of four methods,
for example topLeftCorner(), that return a FloatRect that represents the
bounds of one elliptical corner. I also added a method, xInterceptsAtY()
that returns two X coordinates of the intersection between a horizontal
line and the rounded rectangle.

No new tests, this is just an internal refactoring.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatRoundedRect.cpp: Added.

(WebCore::FloatRoundedRect::FloatRoundedRect):
(WebCore::FloatRoundedRect::Radii::isZero):
(WebCore::FloatRoundedRect::Radii::scale):
(WebCore::FloatRoundedRect::Radii::expand):
(WebCore::cornerRectIntercept):
(WebCore::FloatRoundedRect::xInterceptsAtY):

  • platform/graphics/FloatRoundedRect.h: Added.

(WebCore::FloatRoundedRect::Radii::Radii):
(WebCore::FloatRoundedRect::Radii::setTopLeft):
(WebCore::FloatRoundedRect::Radii::setTopRight):
(WebCore::FloatRoundedRect::Radii::setBottomLeft):
(WebCore::FloatRoundedRect::Radii::setBottomRight):
(WebCore::FloatRoundedRect::Radii::topLeft):
(WebCore::FloatRoundedRect::Radii::topRight):
(WebCore::FloatRoundedRect::Radii::bottomLeft):
(WebCore::FloatRoundedRect::Radii::bottomRight):
(WebCore::FloatRoundedRect::Radii::expand):
(WebCore::FloatRoundedRect::Radii::shrink):
(WebCore::FloatRoundedRect::rect):
(WebCore::FloatRoundedRect::radii):
(WebCore::FloatRoundedRect::isRounded):
(WebCore::FloatRoundedRect::isEmpty):
(WebCore::FloatRoundedRect::setRect):
(WebCore::FloatRoundedRect::setRadii):
(WebCore::FloatRoundedRect::move):
(WebCore::FloatRoundedRect::inflate):
(WebCore::FloatRoundedRect::expandRadii):
(WebCore::FloatRoundedRect::shrinkRadii):
(WebCore::FloatRoundedRect::topLeftCorner):
(WebCore::FloatRoundedRect::topRightCorner):
(WebCore::FloatRoundedRect::bottomLeftCorner):
(WebCore::FloatRoundedRect::bottomRightCorner):
(WebCore::operator==):

  • rendering/shapes/BoxShape.cpp: Added.

(WebCore::BoxShape::BoxShape):
(WebCore::BoxShape::getExcludedIntervals):
(WebCore::BoxShape::getIncludedIntervals):
(WebCore::BoxShape::firstIncludedIntervalLogicalTop):

  • rendering/shapes/BoxShape.h: Added.
  • rendering/shapes/Shape.cpp:

(WebCore::createBoxShape):
(WebCore::Shape::createShape):

1:44 PM Changeset in webkit [159582] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Remote Layer Tree: 100% repro crasher on the IPC thread when creating lots of layers
​https://bugs.webkit.org/show_bug.cgi?id=124643

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):
Dynamically allocate storage for the message if needed.

1:29 PM Changeset in webkit [159581] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

machMessageSize uses sizeof(mach_msg_ool_ports_descriptor_t) for out-of-line *memory*
​https://bugs.webkit.org/show_bug.cgi?id=124644

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::machMessageSize):
mach_msg_ool_descriptor_t is the correct type, given that
out-of-line memory descriptors use the mach_msg_ool_descriptor_t
member of the mach_msg_descriptor_t union.

1:24 PM Changeset in webkit [159580] by dino@apple.com
  • 4 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=124637

Unreviewed. Adding HTMLTemplateElement to global constructor
test, but this time for more platforms. I'm not sure if
GTK and EFL need this too.

  • platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
1:23 PM Changeset in webkit [159579] by Antti Koivisto
  • 5 edits
    4 adds in trunk

Simple line layout should support floats
​https://bugs.webkit.org/show_bug.cgi?id=124666

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/text/simple-lines-float-compare.html

fast/text/simple-lines-float.html

  • rendering/line/LineWidth.h:

(WebCore::LineWidth::logicalLeftOffset):

Expose the left offset so we don't need to recompute it.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::computeLineLeft):

Include the left offset from floats.

(WebCore::SimpleLineLayout::createTextRuns):

Keep the flow height updated during the loop as LineWidth reads the current position from there.

  • rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::RunResolver::Run::rect):
(WebCore::SimpleLineLayout::RunResolver::Run::baseline):
(WebCore::SimpleLineLayout::RunResolver::RunResolver):
(WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight):

We now bake the border and the padding to the line left offset. No need to add it during resolve.

LayoutTests:

  • fast/text/simple-lines-float-compare-expected.html: Added.
  • fast/text/simple-lines-float-compare.html: Added.
  • fast/text/simple-lines-float-expected.html: Added.
  • fast/text/simple-lines-float.html: Added.
1:18 PM Changeset in webkit [159578] by ap@apple.com
  • 27 edits in trunk/Source/WebCore

Use std::function callbacks in CryptoAlgorithm instead of JS promises
​https://bugs.webkit.org/show_bug.cgi?id=124673

Reviewed by Anders Carlsson.

To implement key wrapping/unwrapping, we'll need to chain existing operations.
It's much easier to do with C++ callbacks than with functions fulfilling JS
promises directly.

Also, this will decouple CryptoAlgorithm from JS, which is nice.

SubtleCrypto IDL says that all functions return Promise<any>, but in reality,
there is very little polymorphism, the only function whose return type depends
on algorithm is generateKey (it can create a Key or a KeyPair).

  • bindings/js/JSDOMPromise.cpp:

(WebCore::PromiseWrapper::PromiseWrapper):
(WebCore::PromiseWrapper::operator=):

  • bindings/js/JSDOMPromise.h:

Made it copyable, as each crypto function wraps the promise in success and failure
functional objects now.

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::digest):
(WebCore::JSSubtleCrypto::generateKey):
(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::exportKey):

  • crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::encrypt):
(WebCore::CryptoAlgorithm::decrypt):
(WebCore::CryptoAlgorithm::sign):
(WebCore::CryptoAlgorithm::verify):
(WebCore::CryptoAlgorithm::digest):
(WebCore::CryptoAlgorithm::generateKey):
(WebCore::CryptoAlgorithm::deriveKey):
(WebCore::CryptoAlgorithm::deriveBits):
(WebCore::CryptoAlgorithm::importKey):

  • crypto/CryptoAlgorithm.h:
  • crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):

  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::generateKey):
(WebCore::CryptoAlgorithmAES_CBC::importKey):

  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:
  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::generateKey):
(WebCore::CryptoAlgorithmHMAC::importKey):

  • crypto/algorithms/CryptoAlgorithmHMAC.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::generateKey):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmSHA1.cpp:

(WebCore::CryptoAlgorithmSHA1::digest):

  • crypto/algorithms/CryptoAlgorithmSHA1.h:
  • crypto/algorithms/CryptoAlgorithmSHA224.cpp:

(WebCore::CryptoAlgorithmSHA224::digest):

  • crypto/algorithms/CryptoAlgorithmSHA224.h:
  • crypto/algorithms/CryptoAlgorithmSHA256.cpp:

(WebCore::CryptoAlgorithmSHA256::digest):

  • crypto/algorithms/CryptoAlgorithmSHA256.h:
  • crypto/algorithms/CryptoAlgorithmSHA384.cpp:

(WebCore::CryptoAlgorithmSHA384::digest):

  • crypto/algorithms/CryptoAlgorithmSHA384.h:
  • crypto/algorithms/CryptoAlgorithmSHA512.cpp:

(WebCore::CryptoAlgorithmSHA512::digest):

  • crypto/algorithms/CryptoAlgorithmSHA512.h:
  • crypto/keys/CryptoKeyRSA.h:
  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):

  • crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):

  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::generatePair):

1:15 PM Changeset in webkit [159577] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

ARMv7: Crash due to use after free of AssemblerBuffer
​https://bugs.webkit.org/show_bug.cgi?id=124611

Reviewed by Geoffrey Garen.

Changed JITFinalizer constructor to take a MacroAssemblerCodePtr instead of a Label.
In finalizeFunction(), we use that value instead of calculating it from the label.

  • assembler/MacroAssembler.cpp:
  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::JITFinalizer):
(JSC::DFG::JITFinalizer::finalizeFunction):

  • dfg/DFGJITFinalizer.h:
1:02 PM Changeset in webkit [159576] by mrowe@apple.com
  • 2 edits in trunk/Tools

Remove some obsolete logic from WebKit.app.

Reviewed by Alexey Proskuryakov.

  • WebKitLauncher/WebKitNightlyEnabler.m:

(poseAsWebKitApp): Remove a pre-10.6 codepath.
(enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.

11:26 AM Changeset in webkit [159575] by robert@webkit.org
  • 10 edits
    2 adds in trunk

REGRESSION(r127163): Respect clearance set on ancestors when placing floats
​https://bugs.webkit.org/show_bug.cgi?id=119979

Reviewed by David Hyatt.

Source/WebCore:

Refactor the way self-collapsing blocks with clearance are positioned so that they
get the correct logical-top position during margin-collapsing.

Test: fast/block/margin-collapse/self-collapsing-block-with-float-descendants.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::marginOffsetForSelfCollapsingBlock):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::handleAfterSideOfBlock):

  • rendering/RenderBlockFlow.h:

LayoutTests:

  • fast/block/float/clear-negative-margin-top-expected.html:
  • fast/block/float/clear-negative-margin-top.html:
  • fast/block/margin-collapse/self-collapsing-block-with-float-descendants-expected.html: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-float-descendants.html: Added.
  • platform/mac/fast/block/float/024-expected.txt:
  • platform/mac/fast/block/margin-collapse/025-expected.txt:
  • platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/mac/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
11:08 AM WebKitGTK/2.2.x edited by vjaquez@igalia.com
I would like to integrate this patch in the release, but, as mrobinson … (diff)
11:03 AM Changeset in webkit [159574] by dino@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=124637

Unreviewed. Adding HTMLTemplateElement to global constructor
test after r159550.

  • js/dom/global-constructors-attributes-expected.txt:
11:01 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
10:57 AM Changeset in webkit [159573] by dino@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed. Trying to fix tests added in r159545.

  • js/regress/global-var-const-infer-fire-from-opt.html:
  • js/regress/global-var-const-infer.html:
10:44 AM Changeset in webkit [159572] by vjaquez@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] Remove Chromium as user agent and claim to be Safari in OS X
​https://bugs.webkit.org/show_bug.cgi?id=124229

Reviewed by Martin Robinson.

​http://www.duolingo.com/ doesn't get render correctly because it uses
Chrome/Chromium specific variables, added after it was forked. Because
of this, it is necessary to remove the Chrome/Chromium identification
in the user agent. Also, from now on, by default, The GTK+ port will
claim to be Safari in OS X to avoid loading wrong resources.

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::standardUserAgent):

10:32 AM Changeset in webkit [159571] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Fix CPU(ARM_TRADITIONAL) build after r159545.
​https://bugs.webkit.org/show_bug.cgi?id=124649

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-20
Reviewed by Michael Saboff.

Add missing memoryFence, load8 and store8 implementations in macro assembler.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::dmbSY):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::store8):
(JSC::MacroAssemblerARM::memoryFence):

10:26 AM Changeset in webkit [159570] by commit-queue@webkit.org
  • 21 edits in trunk/Source/WebCore

Unreviewed, rolling out r159551.
​http://trac.webkit.org/changeset/159551
​https://bugs.webkit.org/show_bug.cgi?id=124669

made many tests asserts (Requested by anttik on #webkit).

  • html/HTMLDetailsElement.h:
  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::selectNextSourceChild):

  • html/HTMLMetaElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::isDisabledFormControl):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateWidgetCallback):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::detailsElement):

  • html/HTMLSummaryElement.h:
  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption):
(WebCore::HTMLTableElement::tHead):
(WebCore::HTMLTableElement::tFoot):
(WebCore::HTMLTableElement::lastBody):

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

  • html/HTMLTableSectionElement.h:
  • html/HTMLTagNames.in:
  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::summaryElement):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

  • page/DragController.cpp:

(WebCore::DragController::canProcessDrag):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

  • page/SpatialNavigation.cpp:

(WebCore::frameOwnerElement):

10:24 AM Changeset in webkit [159569] by zoltan@webkit.org
  • 6 edits
    2 moves in trunk/Source/WebCore

Move LineWidth.{h,cpp} into rendering/line
<​https://webkit.org/b/124448>

Reviewed by David Hyatt.

In r159354 I introduced line directory. Now it's time to move the helper classes of RenderBlockLineLayout into 'line' subdirectory.

No new tests, no behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/line/LineWidth.cpp: Renamed from Source/WebCore/rendering/LineWidth.cpp.

(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineIncludingExtraWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
(WebCore::LineWidth::commit):
(WebCore::LineWidth::applyOverhang):
(WebCore::LineWidth::fitBelowFloats):
(WebCore::LineWidth::setTrailingWhitespaceWidth):
(WebCore::LineWidth::updateCurrentShapeSegment):
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):

  • rendering/line/LineWidth.h: Renamed from Source/WebCore/rendering/LineWidth.h.

(WebCore::LineWidth::currentWidth):
(WebCore::LineWidth::uncommittedWidth):
(WebCore::LineWidth::committedWidth):
(WebCore::LineWidth::availableWidth):
(WebCore::LineWidth::addUncommittedWidth):
(WebCore::LineWidth::shouldIndentText):

10:09 AM Changeset in webkit [159568] by beidson@apple.com
  • 7 edits in trunk/Source/WebCore

Alphabetization followup to r159567

Reviewed by style-bot :(

  • Modules/indexeddb/IDBDatabaseBackend.h:
  • Modules/indexeddb/IDBIndex.h:
  • Modules/indexeddb/IDBObjectStore.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • inspector/InspectorIndexedDBAgent.cpp:
10:02 AM Changeset in webkit [159567] by beidson@apple.com
  • 13 edits
    1 move in trunk/Source/WebCore

Rename IDBMetadata.h to IDBDatabaseMetadata.h
​https://bugs.webkit.org/show_bug.cgi?id=124668

Reviewed by Dean Jackson.

  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBDatabaseBackend.h:
  • Modules/indexeddb/IDBDatabaseMetadata.h: Renamed from Source/WebCore/Modules/indexeddb/IDBMetadata.h.

(WebCore::IDBIndexMetadata::IDBIndexMetadata):
(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):
(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):

  • Modules/indexeddb/IDBIndex.h:
  • Modules/indexeddb/IDBObjectStore.h:
  • Modules/indexeddb/IDBServerConnection.h:
  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.h:
  • inspector/InspectorIndexedDBAgent.cpp:
9:57 AM Changeset in webkit [159566] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove bogus assertions in updateNameForTreeScope and updateNameForDocument
​https://bugs.webkit.org/show_bug.cgi?id=124639

Reviewed by Darin Adler.

Removed assertions. We can't assert that the element in a tree scope or a document
since these two functions are called from removedFrom.

  • dom/Element.cpp:

(WebCore::Element::updateNameForTreeScope):
(WebCore::Element::updateNameForDocument):

9:02 AM Changeset in webkit [159565] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

  • platform/efl/TestExpectations: Add new test expectations for failing tests.
8:02 AM Changeset in webkit [159564] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[armv7][arm64] Speculative build fix after r159545.
​https://bugs.webkit.org/show_bug.cgi?id=124646

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-20
Reviewed by Filip Pizlo.

  • assembler/ARMv7Assembler.h:
  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::memoryFence):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::memoryFence):

8:00 AM Changeset in webkit [159563] by beidson@apple.com
  • 14 edits in trunk/Source

Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2
​https://bugs.webkit.org/show_bug.cgi?id=124635

Reviewed by Tim Horton.

Source/WebCore:

getOrEstablishIDBDatabaseMetadata() should not have to take a database name parameter because the
server connection should already know what database name it represents.

  • Modules/indexeddb/IDBDatabaseBackend.cpp:

(WebCore::IDBDatabaseBackend::openInternalAsync):

  • Modules/indexeddb/IDBServerConnection.h:
  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::IDBServerConnectionLevelDB):
(WebCore::IDBServerConnectionLevelDB::getOrEstablishIDBDatabaseMetadata):

  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:

(WebCore::IDBFactoryBackendLevelDB::deleteDatabase):
(WebCore::IDBFactoryBackendLevelDB::open):

Source/WebKit2:

Stub out the message for getOrEstablishIDBDatabaseMetadata in the DatabaseProcess.

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
  • Shared/SecurityOriginData.cpp:

(WebKit::SecurityOriginData::fromSecurityOrigin):

  • Shared/SecurityOriginData.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::WebIDBServerConnection):
(WebKit::WebIDBServerConnection::deleteDatabase):
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
7:49 AM Changeset in webkit [159562] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Moved stray urls from svn.py and statusserver.py into common.config.urls
​https://bugs.webkit.org/show_bug.cgi?id=124650

Patch by Dániel Bátyai <​Batyai.Daniel@stud.u-szeged.hu> on 2013-11-20
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVNRepository):

  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer.init):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(_generate_results_dict):

7:44 AM Changeset in webkit [159561] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk

[EFL] <video> and <audio> should be accessible.
​https://bugs.webkit.org/show_bug.cgi?id=124494

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2013-11-20
Reviewed by Gyuyoung Kim.

Source/WebCore:

Adding descriptions of media-element controls.

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::localizedMediaControlElementString):

LayoutTests:

Added new accessibility baseline for accessibility/media-elemen.html.

  • platform/efl-wk1/TestExpectations: test is no longer failing.
  • platform/efl-wk2/TestExpectations: test is no longer failing.
  • platform/efl/accessibility/media-element-expected.txt: Added.
7:14 AM Changeset in webkit [159560] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Don't paint simple text runs outside the paint rect
​https://bugs.webkit.org/show_bug.cgi?id=124651

Reviewed by Anders Carlsson.

This speeds up partial paints for long text paragraphs.
Also add the same optimization for hit testing.

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):

Iterate over the run range that needs painting.

(WebCore::SimpleLineLayout::hitTestFlow):

Iterate over the line range that needs painting.

  • rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::Range::Range):
(WebCore::SimpleLineLayout::Range::begin):
(WebCore::SimpleLineLayout::Range::end):

Add Range type.

(WebCore::SimpleLineLayout::RunResolver::Iterator::Iterator):
(WebCore::SimpleLineLayout::RunResolver::Iterator::operator++):
(WebCore::SimpleLineLayout::RunResolver::Iterator::advance):
(WebCore::SimpleLineLayout::RunResolver::Iterator::advanceLines):

Optimize case where runCount==lineCount. In this case we can just directly jump
to the right run/line.

(WebCore::SimpleLineLayout::RunResolver::begin):
(WebCore::SimpleLineLayout::RunResolver::end):
(WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight):
(WebCore::SimpleLineLayout::RunResolver::rangeForRect):

Get the range corresponding to a rect. This currently cares about y coordinates only.

(WebCore::SimpleLineLayout::LineResolver::Iterator::operator++):
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator*):
(WebCore::SimpleLineLayout::LineResolver::rangeForRect):

6:55 AM Changeset in webkit [159559] by Antoine Quint
  • 3 edits
    4 adds in trunk

Cannot animate "points" attribute for <svg:polygon>
​https://bugs.webkit.org/show_bug.cgi?id=21371

Reviewed by Antti Koivisto.

Source/WebCore:

Ensure we use animated list of points for SVG <polygon> and <polyline> elements
when we build the path used to draw them, otherwise the animated changes won't
be rendered and the base value will be used.

Tests: svg/animations/polygon-set.svg

svg/animations/polyline-set.svg

  • rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromPolygonElement):
(WebCore::updatePathFromPolylineElement):

LayoutTests:

New tests covering the actual application of the animated value
for the "points" attribute of the SVG <polygon> and <polyline> elements.

  • svg/animations/polygon-set-expected.svg: Added.
  • svg/animations/polygon-set.svg: Added.
  • svg/animations/polyline-set-expected.svg: Added.
  • svg/animations/polyline-set.svg: Added.
3:12 AM Changeset in webkit [159558] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Configurability test of prototype's properties in fast/dom/webidl-operations-on-node-prototype.html is wrong
​https://bugs.webkit.org/show_bug.cgi?id=124602

Reviewed by Darin Adler.

The test case landed in r159100 checks, among other tests, for configurability of properties on the Node's
interface prototype object. The test deletes the tested property from the prototype object and checks that
the property is undefined. This works for the Node's prototype object but is not technically correct since
there might be a property with the same identifier that's located upwards on the prototype chain.

Rather than testing that the property on the prototype object is undefined after it is deleted, a failure
should be reported if the value of the property remains the same even after it's deleted from the object.

  • fast/dom/webidl-operations-on-node-prototype.html:
2:35 AM Changeset in webkit [159557] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty/ANGLE

ANGLE doesn't build with bison 3.0
​https://bugs.webkit.org/show_bug.cgi?id=124642

Patch by Sergio Correia <Sergio Correia> on 2013-11-20
Reviewed by Gyuyoung Kim.

This is a reedition of r154109, now that ANGLE source has been updated
in r159533.

  • src/compiler/glslang.y: Use %lex-param to set YYLEX_PARAM and stop

using the deprecated YYID macro.

2:35 AM Changeset in webkit [159556] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Do not use deprecated callbacks in WebKitPolicyClient
​https://bugs.webkit.org/show_bug.cgi?id=124648

Reviewed by Philippe Normand.

Fixes compile warnings for uninitialized callbacks.

  • UIProcess/API/gtk/WebKitPolicyClient.cpp:

(decidePolicyForNavigationAction): Add originatingFrame parameter.
(decidePolicyForNewWindowAction): Renamed for consistency.
(decidePolicyForResponse): Add canShowMIMEType parameter.
(attachPolicyClientToView): Add new callbacks.

1:48 AM Changeset in webkit [159555] by Carlos Garcia Campos
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed. Fix GTK build.

  • GNUmakefile.am: Remove duplicated entries.
1:22 AM Changeset in webkit [159554] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r159496.
​http://trac.webkit.org/changeset/159496
​https://bugs.webkit.org/show_bug.cgi?id=124641

It caused warning and build break with cmake lower than 2.8.8
(Requested by ryuan on #webkit).

.:

  • Source/cmake/OptionsEfl.cmake:

Tools:

  • MiniBrowser/efl/CMakeLists.txt:
12:47 AM Changeset in webkit [159553] by abucur@adobe.com
  • 11 edits in trunk/Source/WebCore

[CSSRegions] Move region styling code into RenderNamedFlowFragment
​https://bugs.webkit.org/show_bug.cgi?id=122957

Reviewed by Mihnea Ovidenie.

The patch moves all the region styling functionality outside of RenderRegion
to RenderNamedFlowFragment and outside of RenderFlowThread to RenderNamedFlowThread.
This generates a couple of undesired casts that will be removed in later patches
when everything CSS Regions specific will be located inside RenderNamedFlowThread
and RenderNamedFlowFragment (e.g. the move of the isValid flag, the auto-height
code etc.).

The painting function was also moved from RenderRegion to RenderNamedFlowFragment. It
was only used by the CSS Regions code. The new multi-column implementation has its own
painting mechanism.

Tests: No changed functionality, just refactorings.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore::RenderFlowThread::clearRenderBoxRegionInfoAndCustomStyle):

  • rendering/RenderFlowThread.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):

  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::RenderNamedFlowFragment):
(WebCore::RenderNamedFlowFragment::styleDidChange):
(WebCore::RenderNamedFlowFragment::checkRegionStyle):
(WebCore::RenderNamedFlowFragment::computeStyleInRegion):
(WebCore::RenderNamedFlowFragment::computeChildrenStyleInRegion):
(WebCore::RenderNamedFlowFragment::setObjectStyleInRegion):
(WebCore::RenderNamedFlowFragment::clearObjectStyleInRegion):
(WebCore::RenderNamedFlowFragment::setRegionObjectsRegionStyle):
(WebCore::RenderNamedFlowFragment::restoreRegionObjectsOriginalStyle):
(WebCore::shouldPaintRegionContentsInPhase):
(WebCore::RenderNamedFlowFragment::paintObject):

  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::checkRegionsWithStyling):
(WebCore::RenderNamedFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderNamedFlowThread::removeFlowChildInfo):

  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::attachRegion):

  • rendering/RenderRegion.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderRegionList):

12:30 AM Changeset in webkit [159552] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[EFL] libseccomp-2.0.0 doesn't support ARM architecture
​https://bugs.webkit.org/show_bug.cgi?id=124412

Reviewed by Gyuyoung Kim.

Update libseccomp to a newer 2.1.0 version.

  • efl/jhbuild.modules:

Nov 19, 2013:

11:21 PM Changeset in webkit [159551] by gyuyoung.kim@samsung.com
  • 21 edits in trunk/Source/WebCore

Generate toHTMLFooElement() to clean up static_cast<>
​https://bugs.webkit.org/show_bug.cgi?id=124571

Reviewed by Darin Adler.

Though there are a lot of clean up commits before, there are still
use of static_cast<HTMLFooElement*>. To clean up them, we need to generate
toHTMLDetails|Meta|Summary|TableSection|TableCaptionElement().

Additionally, other static_cast<> are removed as well.

No new tests, no behavior changes.

  • html/HTMLDetailsElement.h:
  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::selectNextSourceChild):

  • html/HTMLMetaElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::isDisabledFormControl):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateWidgetCallback):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::detailsElement):

  • html/HTMLSummaryElement.h:
  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption):
(WebCore::HTMLTableElement::tHead):
(WebCore::HTMLTableElement::tFoot):
(WebCore::HTMLTableElement::lastBody):

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

  • html/HTMLTableSectionElement.h:
  • html/HTMLTagNames.in:
  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::summaryElement):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

  • page/DragController.cpp:

(WebCore::DragController::canProcessDrag):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

  • page/SpatialNavigation.cpp:

(WebCore::frameOwnerElement):

10:57 PM Changeset in webkit [159550] by rniwa@webkit.org
  • 10 edits in trunk

Enable HTMLTemplateElement on Mac port
​https://bugs.webkit.org/show_bug.cgi?id=124637

Reviewed by Tim Horton.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Enabled the feature.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

Unskip template element tests except fast/dom/HTMLTemplateElement/cycles-in-shadow.html
which depends on ENABLE(SHADOW_DOM).

  • platform/mac/TestExpectations:
10:01 PM Changeset in webkit [159549] by mrowe@apple.com
  • 2 edits in trunk/Tools

<rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.

Gestalt is deprecated on recent OS X versions so we should switch off it.

Reviewed by Sam Weinig.

  • WebKitLauncher/main.m:

(currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
(currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
two components, then join them back up.
(main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
the version we care about.

9:59 PM Changeset in webkit [159548] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebCore

Remove unused member function declaration in DocumentOrderedMap.h
​https://bugs.webkit.org/show_bug.cgi?id=124629

Reviewed by Ryosuke Niwa.

checkConsistency() is not used anywhere.

  • dom/DocumentOrderedMap.h:
9:57 PM Changeset in webkit [159547] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, remove completely bogus assertion.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addFunction):

9:53 PM Changeset in webkit [159546] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, debug build fix.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addFunction):

9:49 PM Changeset in webkit [159545] by fpizlo@apple.com
  • 52 edits
    6 adds in trunk

Infer constant global variables
​https://bugs.webkit.org/show_bug.cgi?id=124464

Source/JavaScriptCore:

Reviewed by Sam Weinig.

All global variables that are candidates for watchpoint-based constant inference (i.e.
not 'const' variables) will now have WatchpointSet's associated with them and those
are used to drive the inference by tracking three states of each variable:

Uninitialized: the variable's value is Undefined and the WatchpointSet state is

ClearWatchpoint.


Initialized: the variable's value was set to something (could even be explicitly set

to Undefined) and the WatchpointSet state is IsWatching.


Invalidated: the variable's value was set to something else (could even be the same

thing as before but the point is that a put operation did execute again) and the
WatchpointSet is IsInvalidated.


If the compiler tries to compile a GetGlobalVar and the WatchpointSet state is
IsWatching, then the current value of the variable can be folded in place of the get,
and a watchpoint on the variable can be registered.

We handle race conditions between the mutator and compiler by mandating that:

  • The mutator changes the WatchpointSet state after executing the put.


  • There is no opportunity to install code or call functions between when the mutator executes a put and changes the WatchpointSet state.


  • The compiler checks the WatchpointSet state prior to reading the value.


The concrete algorithm used by the mutator is:

  1. Store the new value into the variable. --- Execute a store-store fence.
  2. Bump the state (ClearWatchpoing becomes IsWatching, IsWatching becomes IsInvalidated); the IsWatching->IsInvalidated transition may end up firing watchpoints.


The concrete algorithm that the compiler uses is:

  1. Load the state. If it's *not* IsWatching, then give up on constant inference. --- Execute a load-load fence.
  2. Load the value of the variable and use that for folding, while also registering a DesiredWatchpoint. The various parts of this step can be done in any order.


The desired watchpoint registration will fail if the watchpoint set is already
invalidated. Now consider the following interesting interleavings:

Uninitialized->M1->M2->C1->C2: Compiler sees IsWatching because of the mutator's store

operation, and the variable is folded. The fencing ensures that C2 sees the value
stored in M1 - i.e. we fold on the value that will actually be watchpointed. If
before the compilation is installed the mutator executes another store then we
will be sure that it will be a complete sequence of M1+M2 since compilations get
installed at safepoints and never "in the middle" of a put_to_scope. Hence that
compilation installation will be invalidated. If the M1+M2 sequence happens after
the code is installed, then the code will be invalidated by triggering a jettison.


Uninitialized->M1->C1->C2->M2: Compiler sees Uninitialized and will not fold. This is

a sensible outcome since if the compiler read the variable's value, it would have
seen Undefined.


Uninitialized->C1->C2->M1->M2: Compiler sees Uninitialized and will not fold.
Uninitialized->C1->M1->C2->M2: Compiler sees Uninitialized and will not fold.
Uninitialized->C1->M1->M2->C2: Compiler sees Uninitialized and will not fold.
Uninitialized->M1->C1->M2->C2: Compiler sees Uninitialized and will not fold.

IsWatched->M1->M2->C1->C2: Compiler sees IsInvalidated and will not fold.

IsWatched->M1->C1->C2->M2: Compiler will fold, but will also register a desired

watchpoint, and that watchpoint will get invalidated before the code is installed.


IsWatched->M1->C1->M2->C2: As above, will fold but the code will get invalidated.
IsWatched->C1->C2->M1->M2: As above, will fold but the code will get invalidated.
IsWatched->C1->M1->C2->M2: As above, will fold but the code will get invalidated.
IsWatched->C1->M1->M2->C2: As above, will fold but the code will get invalidated.

Note that this kind of reasoning shows why having the mutator first bump the state and
then store the new value would be wrong. If we had done that (M1 = bump state, M2 =
execute put) then we could have the following deadly interleavings:

Uninitialized->M1->C1->C2->M2:
Uninitialized->M1->C1->M2->C2: Mutator bumps the state to IsWatched and then the

compiler folds Undefined, since M2 hasn't executed yet. Although C2 will set the
watchpoint, M1 didn't notify it - it mearly initiated watching. M2 then stores a
value other than Undefined, and you're toast.


You could fix this sort of thing by making the Desired Watchpoints machinery more
sophisticated, for example having it track the value that was folded; if the global
variable's value was later found to be different then we could invalidate the
compilation. You could also fix it by having the compiler also check that the value of
the variable is not Undefined before folding. While those all sound great, I decided
to instead just use the right interleaving since that results in less code and feels
more intuitive.

This is a 0.5% speed-up on SunSpider, mostly due to a 20% speed-up on math-cordic.
It's a 0.6% slow-down on LongSpider, mostly due to a 25% slow-down on 3d-cube. This is
because 3d-cube takes global variable assignment slow paths very often. Note that this
3d-cube slow-down doesn't manifest as much in SunSpider (only 6% there). This patch is
also a 1.5% speed-up on V8v7 and a 2.8% speed-up on Octane v1, mostly due to deltablue
(3.7%), richards (4%), and mandreel (26%). This is a 2% speed-up on Kraken, mostly due
to a 17.5% speed-up on imaging-gaussian-blur. Something that really illustrates the
slam-dunk-itude of this patch is the wide range of speed-ups on JSRegress. Casual JS
programming often leads to global-var-based idioms and those variables tend to be
assigned once, leading to excellent constant folding opportunities in an optimizing
JIT. This is very evident in the speed-ups on JSRegress.

  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::dmbSY):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::dmbSY):

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::memfence):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load8):
(JSC::MacroAssemblerARMv7::memfence):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::load8):
(JSC::MacroAssemblerX86::store8):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::getUnusedRegister):
(JSC::MacroAssemblerX86Common::store8):
(JSC::MacroAssemblerX86Common::memoryFence):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::load8):
(JSC::MacroAssemblerX86_64::store8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movb_rm):
(JSC::X86Assembler::movzbl_mr):
(JSC::X86Assembler::mfence):
(JSC::X86Assembler::X86InstructionFormatter::threeByteOp):
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp8):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::WatchpointSet):
(JSC::WatchpointSet::add):
(JSC::WatchpointSet::notifyWriteSlow):

  • bytecode/Watchpoint.h:

(JSC::WatchpointSet::state):
(JSC::WatchpointSet::isStillValid):
(JSC::WatchpointSet::addressOfSetIsNotEmpty):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getJSConstantForValue):
(JSC::DFG::ByteCodeParser::getJSConstant):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::isStronglyProvedConstantIn):
(JSC::DFG::Node::hasIdentifierNumberForCheck):
(JSC::DFG::Node::hasRegisterPointer):

  • dfg/DFGNodeFlags.h:
  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNotifyPutGlobalVar):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLAbbreviatedTypes.h:
  • ftl/FTLAbbreviations.h:

(JSC::FTL::buildFence):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNotifyPutGlobalVar):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::fence):

  • jit/JIT.h:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitPutGlobalVar):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitPutGlobalVar):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • llvm/LLVMAPIFunctions.h:
  • offlineasm/arm.rb:
  • offlineasm/arm64.rb:
  • offlineasm/cloop.rb:
  • offlineasm/instructions.rb:
  • offlineasm/x86.rb:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addGlobalVar):
(JSC::JSGlobalObject::addFunction):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::addVar):
(JSC::JSGlobalObject::addConst):

  • runtime/JSScope.cpp:

(JSC::abstractAccess):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::couldBeWatched):
(JSC::SymbolTableEntry::prepareToWatch):
(JSC::SymbolTableEntry::notifyWriteSlow):

  • runtime/SymbolTable.h:

LayoutTests:

Reviewed by Sam Weinig.

  • js/regress/global-var-const-infer-expected.txt: Added.
  • js/regress/global-var-const-infer-fire-from-opt-expected.txt: Added.
  • js/regress/global-var-const-infer-fire-from-opt.html: Added.
  • js/regress/global-var-const-infer.html: Added.
  • js/regress/script-tests/global-var-const-infer-fire-from-opt.js: Added.

(foo):
(setA):
(setB):
(check):

  • js/regress/script-tests/global-var-const-infer.js: Added.

(foo):
(check):

9:19 PM Changeset in webkit [159544] by Seokju Kwon
  • 2 edits in trunk/Source/WebCore

Removal of redundant function call in Editor::insertTextWithoutSendingTextEvent
​https://bugs.webkit.org/show_bug.cgi?id=124563

Reviewed by Brent Fulgham.

No new tests needed, no behavior change.

  • editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent):

9:08 PM Changeset in webkit [159543] by roger_fong@apple.com
  • 5 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed. Build fix for Mac.

  • src/compiler/glslang_tab.cpp:

(yysyntax_error):
(yyerror):

  • src/compiler/glslang_tab.h:
  • src/compiler/preprocessor/ExpressionParser.cpp:

(yysyntax_error):

9:04 PM Changeset in webkit [159542] by Martin Robinson
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Fix the GTK+ build after the ANGLE update in r159533

  • GNUmakefile.am: Update the source list.
7:50 PM Changeset in webkit [159541] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Fix build break after r159533.

  • CMakeLists.txt: Update ANGLE files.
7:19 PM Changeset in webkit [159540] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Tools

Unreviewed, rolling out r159538.
​http://trac.webkit.org/changeset/159538
​https://bugs.webkit.org/show_bug.cgi?id=124627

it broke run-jsc-stress-tests (Requested by mhahnenberg on
#webkit).

  • Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
  • Scripts/run-javascriptcore-tests:
  • Scripts/run-jsc-stress-tests:
7:13 PM Changeset in webkit [159539] by roger_fong@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed. Prospective build fix for GTK port following r159533.

  • GNUmakefile.am:
6:51 PM Changeset in webkit [159538] by mhahnenberg@apple.com
  • 3 edits
    1 delete in trunk/Tools

run-jsc-stress-tests should be able to package its tests and move them places
​https://bugs.webkit.org/show_bug.cgi?id=124549

Reviewed by Geoff Garen and Filip Pizlo.

  • Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation

of grep -i -q

  • Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
  • Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any

other files that those tests require to run in any environment along with a fixed root directory into which these
files and their expected directory structure are cloned. The default Bundle class is basically
a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows
how to translate local paths to bundle paths and does all the work of moving each test file into the right place
inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle
creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests
to use MovableBundle instead of just Bundle.

6:50 PM Changeset in webkit [159537] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

6:49 PM Changeset in webkit [159536] by Lucas Forschler
  • 1 copy in tags/Safari-537.73.12

New Tag.

6:40 PM Changeset in webkit [159535] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

[EFL] Layout tests need to be rebaselined.
​https://bugs.webkit.org/show_bug.cgi?id=124622

Unreviewed, EFL rebaseline.

EFL tests are rebaselined after r106181, r128728 and r133754.

Patch by Sun-woo Nam <​sunny.nam@samsung.com> on 2013-11-19

  • platform/efl-wk2/TestExpectations:
  • platform/efl/fast/replaced/applet-disabled-positioned-expected.txt:
  • platform/efl/fast/replaced/applet-rendering-java-disabled-expected.txt:
  • platform/efl/fast/text/shaping/shaping-script-order-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
6:12 PM Changeset in webkit [159534] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Implement spin control on WinCE port.
​https://bugs.webkit.org/show_bug.cgi?id=123254

Patch by Zhuang Zhigang <​zhuangzg@cn.fujitsu.com> on 2013-11-19
Reviewed by Brent Fulgham.

  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeWinCE::paintInnerSpinButton):

  • rendering/RenderThemeWinCE.h:
5:52 PM Changeset in webkit [159533] by roger_fong@apple.com
  • 135 edits
    23 adds
    8 deletes in trunk/Source

Update ANGLE sources.
​https://bugs.webkit.org/show_bug.cgi?id=124615.

Reviewed by Dean Jackson.

Tests covered by Khronos WebGL conformance tests.

Update ANGLE to checkout a60e0805721f62c28a55faf2df74472cc5fc91fc.
Modify xcodeproj files as necessary, update plist.
Stop using DerivedSources.make and just use the generated sources that are checked into ANGLE.
Add a note to bison generated files indicating that Apple elects to distribute said files under the BSD license:
ExpressionParser.cpp, glslang_tab.cpp, glslang_tab.h.

  • ANGLE.plist:
  • ANGLE.xcodeproj/project.pbxproj:
  • DerivedSources.make: Removed.
  • platform/graphics/ANGLEWebKitBridge.cpp: Resolve a build error that resulted from updating ANGLE.

(WebCore::getSymbolInfo):
(WebCore::ANGLEWebKitBridge::compileShaderSource):

  • include/EGL/egl.h:
  • include/EGL/eglsoftlinking.h: Removed.
  • include/GLES2/gl2.h:
  • include/GLES2/gl2softlinking.h: Removed.
  • include/GLSLANG/ShaderLang.h:
  • include/KHR/khrplatform.h:
  • src/ANGLE.sln: Added.
  • src/build_angle.gypi:
  • src/common/debug.h:
  • src/common/event_tracer.cpp: Added.

(gl::TraceGetTraceCategoryEnabledFlag):
(gl::TraceAddTraceEvent):

  • src/common/event_tracer.h: Added.
  • src/common/version.h:
  • src/compiler/CodeGen.cpp: Added.

(ConstructCompiler):
(DeleteCompiler):

  • src/compiler/CodeGenGLSL.cpp: Removed.
  • src/compiler/CodeGenHLSL.cpp: Removed.
  • src/compiler/Common.h:

(NewPoolTString):

  • src/compiler/Compiler.cpp:

(TCompiler::Init):
(TCompiler::compile):
(TCompiler::InitBuiltInSymbolTable):
(TCompiler::clearResults):
(TCompiler::collectVariables):

  • src/compiler/ConstantUnion.h:
  • src/compiler/DetectDiscontinuity.cpp:
  • src/compiler/InfoSink.h:
  • src/compiler/InitializeDll.cpp:

(InitProcess):
(DetachProcess):

  • src/compiler/InitializeDll.h:
  • src/compiler/InitializeGLPosition.cpp: Added.

(InitializeGLPosition::visitAggregate):
(InitializeGLPosition::insertCode):

  • src/compiler/InitializeGLPosition.h: Added.

(InitializeGLPosition::InitializeGLPosition):
(InitializeGLPosition::visitBinary):
(InitializeGLPosition::visitUnary):
(InitializeGLPosition::visitSelection):
(InitializeGLPosition::visitLoop):
(InitializeGLPosition::visitBranch):

  • src/compiler/InitializeGlobals.h:
  • src/compiler/InitializeParseContext.cpp:

(InitializeParseContextIndex):
(FreeParseContextIndex):
(SetGlobalParseContext):
(GetGlobalParseContext):

  • src/compiler/InitializeParseContext.h:
  • src/compiler/IntermTraverse.cpp:

(TIntermSymbol::traverse):
(TIntermConstantUnion::traverse):
(TIntermBinary::traverse):
(TIntermUnary::traverse):
(TIntermAggregate::traverse):
(TIntermSelection::traverse):
(TIntermLoop::traverse):
(TIntermBranch::traverse):

  • src/compiler/Intermediate.cpp:

(GetHigherPrecision):
(getOperatorString):
(TIntermLoop::replaceChildNode):
(TIntermBranch::replaceChildNode):
(TIntermBinary::replaceChildNode):
(TIntermUnary::replaceChildNode):
(TIntermAggregate::replaceChildNode):
(TIntermSelection::replaceChildNode):
(TIntermOperator::isAssignment):
(TIntermediate::promoteConstantUnion):

  • src/compiler/MapLongVariableNames.cpp:
  • src/compiler/MapLongVariableNames.h:
  • src/compiler/NodeSearch.h: Added.

(sh::NodeSearchTraverser::NodeSearchTraverser):
(sh::NodeSearchTraverser::found):
(sh::NodeSearchTraverser::search):
(sh::FindDiscard::visitBranch):
(sh::FindSideEffectRewriting::visitBinary):

  • src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::visitSelection):
(TOutputGLSLBase::visitAggregate):
(TOutputGLSLBase::visitLoop):

  • src/compiler/OutputGLSLBase.h:
  • src/compiler/OutputHLSL.cpp:

(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitBinary):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitBranch):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::addConstructor):

  • src/compiler/OutputHLSL.h:
  • src/compiler/ParseContext.cpp: Added.

(TParseContext::parseVectorFields):
(TParseContext::parseMatrixFields):
(TParseContext::recover):
(TParseContext::error):
(TParseContext::warning):
(TParseContext::trace):
(TParseContext::assignError):
(TParseContext::unaryOpError):
(TParseContext::binaryOpError):
(TParseContext::precisionErrorCheck):
(TParseContext::lValueErrorCheck):
(TParseContext::constErrorCheck):
(TParseContext::integerErrorCheck):
(TParseContext::globalErrorCheck):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::voidErrorCheck):
(TParseContext::boolErrorCheck):
(TParseContext::samplerErrorCheck):
(TParseContext::structQualifierErrorCheck):
(TParseContext::parameterSamplerErrorCheck):
(TParseContext::containsSampler):
(TParseContext::arraySizeErrorCheck):
(TParseContext::arrayQualifierErrorCheck):
(TParseContext::arrayTypeErrorCheck):
(TParseContext::arrayErrorCheck):
(TParseContext::nonInitConstErrorCheck):
(TParseContext::nonInitErrorCheck):
(TParseContext::paramErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::supportsExtension):
(TParseContext::isExtensionEnabled):
(TParseContext::findFunction):
(TParseContext::executeInitializer):
(TParseContext::areAllChildConst):
(TParseContext::addConstructor):
(TParseContext::foldConstConstructor):
(TParseContext::constructBuiltIn):
(TParseContext::constructStruct):
(TParseContext::addConstVectorNode):
(TParseContext::addConstMatrixNode):
(TParseContext::addConstArrayNode):
(TParseContext::addConstStruct):
(TParseContext::enterStructDeclaration):
(TParseContext::exitStructDeclaration):
(TParseContext::structNestingErrorCheck):
(TParseContext::addIndexExpression):
(PaParseStrings):

  • src/compiler/ParseContext.h: Added.

(TParseContext::TParseContext):
(TParseContext::numErrors):
(TParseContext::infoSink):
(TParseContext::pragma):
(TParseContext::extensionBehavior):

  • src/compiler/ParseHelper.cpp: Removed.
  • src/compiler/ParseHelper.h: Removed.
  • src/compiler/PoolAlloc.cpp:

(InitializePoolIndex):
(FreePoolIndex):
(GetGlobalPoolAllocator):
(SetGlobalPoolAllocator):

  • src/compiler/PoolAlloc.h:

(pool_allocator::pool_allocator):

  • src/compiler/SearchSymbol.h:
  • src/compiler/ShHandle.h:

(TCompiler::getVaryings):

  • src/compiler/ShaderLang.cpp:

(checkVariableMaxLengths):
(ShInitialize):
(ShFinalize):
(ShConstructCompiler):
(ShCompile):
(ShGetInfo):
(ShGetVariableInfo):
(ShCheckVariablesWithinPackingLimits):

  • src/compiler/SymbolTable.cpp:

(TSymbolTable::~TSymbolTable):

  • src/compiler/SymbolTable.h:

(TSymbol::TSymbol):
(TSymbolTableLevel::insert):
(TSymbolTable::push):
(TSymbolTable::pop):
(TSymbolTable::findBuiltIn):
(TSymbolTable::relateToExtension):
(TSymbolTable::setDefaultPrecision):
(TSymbolTable::getDefaultPrecision):
(TSymbolTable::supportsPrecision):

  • src/compiler/Types.h:

(NewPoolTFieldList):
(TType::TType):
(TType::setNominalSize):
(TPublicType::setAggregate):

  • src/compiler/UnfoldShortCircuit.cpp:

(sh::UnfoldShortCircuit::visitBinary):
(sh::UnfoldShortCircuit::visitSelection):

  • src/compiler/UnfoldShortCircuit.h:
  • src/compiler/UnfoldShortCircuitAST.cpp: Added.

(UnfoldShortCircuitAST::visitBinary):
(UnfoldShortCircuitAST::updateTree):

  • src/compiler/UnfoldShortCircuitAST.h: Added.

(UnfoldShortCircuitAST::UnfoldShortCircuitAST):
(UnfoldShortCircuitAST::NodeUpdateEntry::NodeUpdateEntry):

  • src/compiler/Uniform.cpp:

(sh::Uniform::Uniform):

  • src/compiler/Uniform.h:
  • src/compiler/ValidateLimitations.cpp:

(ValidateLimitations::validateFunctionCall):
(ValidateLimitations::validateOperation):

  • src/compiler/VariableInfo.cpp:

(TVariableInfo::TVariableInfo):
(CollectVariables::CollectVariables):
(CollectVariables::visitSymbol):
(CollectVariables::visitAggregate):

  • src/compiler/VariableInfo.h:
  • src/compiler/debug.cpp:
  • src/compiler/depgraph/DependencyGraph.cpp:
  • src/compiler/depgraph/DependencyGraphBuilder.cpp:

(TDependencyGraphBuilder::visitBinary):

  • src/compiler/generate_parser.sh:
  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp:

(input):
(yyerror):
(int_constant):
(float_constant):
(glslang_scan):

  • src/compiler/glslang_tab.cpp:

(yysyntax_error):
(glslang_parse):

  • src/compiler/glslang_tab.h:
  • src/compiler/intermediate.h:

(TIntermSymbol::hasSideEffects):
(TIntermSymbol::replaceChildNode):
(TIntermConstantUnion::hasSideEffects):
(TIntermConstantUnion::getIConst):
(TIntermConstantUnion::getFConst):
(TIntermConstantUnion::getBConst):
(TIntermConstantUnion::replaceChildNode):
(TIntermOperator::hasSideEffects):
(TIntermBinary::hasSideEffects):
(TIntermUnary::hasSideEffects):
(TIntermAggregate::hasSideEffects):
(TIntermSelection::hasSideEffects):
(TIntermTraverser::~TIntermTraverser):
(TIntermTraverser::incrementDepth):
(TIntermTraverser::decrementDepth):
(TIntermTraverser::getParentNode):

  • src/compiler/localintermediate.h:
  • src/compiler/parseConst.cpp:
  • src/compiler/preprocessor/ExpressionParser.cpp:

(yy_symbol_print):
(yy_stack_print):
(yy_reduce_print):
(yystrlen):
(yystpcpy):
(yytnamerr):
(yysyntax_error):
(yydestruct):
(yyparse):

  • src/compiler/preprocessor/ExpressionParser.y:
  • src/compiler/preprocessor/Preprocessor.cpp:

(pp::Preprocessor::setMaxTokenLength):
(pp::Preprocessor::lex):

  • src/compiler/preprocessor/Preprocessor.h:
  • src/compiler/preprocessor/Tokenizer.cpp:

(pp::Tokenizer::Tokenizer):
(pp::Tokenizer::lex):

  • src/compiler/preprocessor/Tokenizer.h:

(pp::Tokenizer::setMaxTokenLength):

  • src/compiler/preprocessor/Tokenizer.l:
  • src/compiler/preprocessor/generate_parser.sh:
  • src/compiler/preprocessor/preprocessor.vcxproj: Added.
  • src/compiler/preprocessor/preprocessor.vcxproj.filters: Added.
  • src/compiler/timing/RestrictFragmentShaderTiming.cpp:
  • src/compiler/translator.vcxproj: Added.
  • src/compiler/translator.vcxproj.filters: Added.
  • src/compiler/util.cpp:

(atof_clamp):
(atoi_clamp):

  • src/compiler/util.h:
  • src/libEGL/Surface.cpp:

(egl::Surface::checkForOutOfDateSwapChain):

  • src/libEGL/libEGL.cpp:
  • src/libEGL/libEGL.rc:
  • src/libEGL/libEGL.vcxproj: Added.
  • src/libEGL/libEGL.vcxproj.filters: Added.
  • src/libGLESv2/Buffer.cpp:

(gl::Buffer::bufferData):
(gl::Buffer::bufferSubData):
(gl::Buffer::size):
(gl::Buffer::getIndexRangeCache):

  • src/libGLESv2/Buffer.h:
  • src/libGLESv2/Context.cpp:

(gl::Context::applyTextures):
(gl::Context::getBoundFramebufferTextureSerials):

  • src/libGLESv2/Context.h:

(gl::Context::getRenderer):

  • src/libGLESv2/Framebuffer.h:
  • src/libGLESv2/ProgramBinary.cpp:

(gl::DiscardWorkaround):
(gl::ProgramBinary::load):
(gl::ProgramBinary::link):
(gl::ProgramBinary::linkAttributes):
(gl::AttributeSorter::AttributeSorter):
(gl::ProgramBinary::initAttributesByLayout):
(gl::ProgramBinary::sortAttributesByLayout):

  • src/libGLESv2/ProgramBinary.h:
  • src/libGLESv2/Renderbuffer.cpp:

(gl::RenderbufferTexture2D::getTextureSerial):
(gl::RenderbufferTextureCubeMap::getTextureSerial):
(gl::Renderbuffer::getTextureSerial):

  • src/libGLESv2/Renderbuffer.h:

(gl::RenderbufferStorage::getTextureSerial):

  • src/libGLESv2/Shader.cpp:

(gl::Shader::parseVaryings):
(gl::Shader::uncompile):

  • src/libGLESv2/Shader.h:
  • src/libGLESv2/Texture.cpp:

(gl::TextureCubeMap::storage):

  • src/libGLESv2/Uniform.cpp:

(gl::Uniform::Uniform):
(gl::Uniform::~Uniform):
(gl::Uniform::isArray):
(gl::Uniform::elementCount):

  • src/libGLESv2/Uniform.h:
  • src/libGLESv2/constants.h: Removed.
  • src/libGLESv2/libGLESv2.def:
  • src/libGLESv2/libGLESv2.rc:
  • src/libGLESv2/libGLESv2.vcxproj: Added.
  • src/libGLESv2/libGLESv2.vcxproj.filters: Added.
  • src/libGLESv2/precompiled.h:
  • src/libGLESv2/renderer/Image11.cpp:

(rx::Image11::generateMipmap):
(rx::Image11::loadData):
(rx::Image11::loadCompressedData):
(rx::Image11::copy):
(rx::Image11::createStagingTexture):
(rx::Image11::map):

  • src/libGLESv2/renderer/Image11.h:
  • src/libGLESv2/renderer/IndexBuffer.cpp:

(rx::IndexBufferInterface::mapBuffer):
(rx::StaticIndexBufferInterface::getIndexRangeCache):

  • src/libGLESv2/renderer/IndexBuffer.h:
  • src/libGLESv2/renderer/IndexBuffer11.cpp:

(rx::IndexBuffer11::mapBuffer):

  • src/libGLESv2/renderer/IndexDataManager.cpp:

(rx::IndexDataManager::prepareIndexData):
(rx::IndexDataManager::getCountingIndices):

  • src/libGLESv2/renderer/IndexRangeCache.cpp: Added.

(rx::IndexRangeCache::addRange):
(rx::IndexRangeCache::invalidateRange):
(rx::IndexRangeCache::findRange):
(rx::IndexRangeCache::clear):
(rx::IndexRangeCache::IndexRange::IndexRange):
(rx::IndexRangeCache::IndexRange::operator<):
(rx::IndexRangeCache::IndexBounds::IndexBounds):

  • src/libGLESv2/renderer/IndexRangeCache.h: Added.
  • src/libGLESv2/renderer/InputLayoutCache.cpp:

(rx::InputLayoutCache::InputLayoutCache):
(rx::InputLayoutCache::clear):
(rx::InputLayoutCache::markDirty):
(rx::InputLayoutCache::applyVertexBuffers):
(rx::InputLayoutCache::hashInputLayout):
(rx::InputLayoutCache::compareInputLayouts):

  • src/libGLESv2/renderer/InputLayoutCache.h:

(rx::InputLayoutCache::InputLayoutKey::begin):
(rx::InputLayoutCache::InputLayoutKey::end):

  • src/libGLESv2/renderer/RenderTarget11.cpp:

(rx::RenderTarget11::getTexture):
(rx::RenderTarget11::getRenderTargetView):
(rx::RenderTarget11::getDepthStencilView):
(rx::RenderTarget11::getShaderResourceView):

  • src/libGLESv2/renderer/RenderTarget11.h:
  • src/libGLESv2/renderer/Renderer.cpp:

(rx::Renderer::initializeCompiler):

  • src/libGLESv2/renderer/Renderer.h:
  • src/libGLESv2/renderer/Renderer11.cpp:

(rx::Renderer11::initialize):
(rx::Renderer11::applyPrimitiveType):
(rx::Renderer11::applyRenderTarget):
(rx::Renderer11::drawLineLoop):
(rx::Renderer11::drawTriangleFan):
(rx::Renderer11::applyUniforms):
(rx::Renderer11::clear):
(rx::Renderer11::markAllStateDirty):
(rx::Renderer11::copyImage):
(rx::Renderer11::compileToExecutable):
(rx::Renderer11::getRenderTargetResource):
(rx::Renderer11::blitRenderbufferRect):

  • src/libGLESv2/renderer/Renderer11.h:
  • src/libGLESv2/renderer/Renderer9.cpp:

(rx::Renderer9::initialize):
(rx::Renderer9::setViewport):
(rx::Renderer9::drawLineLoop):
(rx::Renderer9::compileToExecutable):

  • src/libGLESv2/renderer/Renderer9.h:
  • src/libGLESv2/renderer/SwapChain.h:
  • src/libGLESv2/renderer/SwapChain11.cpp:

(rx::SwapChain11::resetOffscreenTexture):
(rx::SwapChain11::reset):
(rx::SwapChain11::swapRect):

  • src/libGLESv2/renderer/SwapChain9.cpp:

(rx::convertInterval):

  • src/libGLESv2/renderer/TextureStorage11.cpp:

(rx::TextureStorage11::IsTextureFormatRenderable):
(rx::TextureStorage11::generateMipmapLayer):
(rx::TextureStorage11_Cube::getRenderTarget):

  • src/libGLESv2/renderer/VertexBuffer.cpp:

(rx::VertexBufferInterface::storeVertexAttributes):
(rx::VertexBufferInterface::storeRawData):
(rx::VertexBufferInterface::reserveVertexSpace):
(rx::StaticVertexBufferInterface::lookupAttribute):
(rx::StaticVertexBufferInterface::storeVertexAttributes):

  • src/libGLESv2/renderer/VertexBuffer.h:
  • src/libGLESv2/renderer/VertexBuffer11.cpp:

(rx::VertexBuffer11::getSpaceRequired):

  • src/libGLESv2/renderer/VertexBuffer11.h:
  • src/libGLESv2/renderer/VertexBuffer9.cpp:

(rx::VertexBuffer9::storeVertexAttributes):
(rx::VertexBuffer9::getSpaceRequired):
(rx::VertexBuffer9::requiresConversion):
(rx::VertexBuffer9::getVertexSize):
(rx::VertexBuffer9::spaceRequired):

  • src/libGLESv2/renderer/VertexBuffer9.h:
  • src/libGLESv2/renderer/VertexDataManager.cpp:

(rx::elementsInBuffer):
(rx::StreamingBufferElementCount):
(rx::VertexDataManager::prepareVertexData):

  • src/libGLESv2/renderer/VertexDataManager.h:
  • src/libGLESv2/renderer/renderer11_utils.cpp:

(gl_d3d11::ConvertTextureFormat):

  • src/libGLESv2/renderer/shaders/compiled/clear11vs.h:
  • src/libGLESv2/renderer/shaders/compiled/clearmultiple11ps.h:
  • src/libGLESv2/renderer/shaders/compiled/clearsingle11ps.h:
  • src/libGLESv2/renderer/shaders/compiled/componentmaskps.h:
  • src/libGLESv2/renderer/shaders/compiled/flipyvs.h:
  • src/libGLESv2/renderer/shaders/compiled/luminanceps.h:
  • src/libGLESv2/renderer/shaders/compiled/passthrough11vs.h:
  • src/libGLESv2/renderer/shaders/compiled/passthroughlum11ps.h:
  • src/libGLESv2/renderer/shaders/compiled/passthroughlumalpha11ps.h:
  • src/libGLESv2/renderer/shaders/compiled/passthroughps.h:
  • src/libGLESv2/renderer/shaders/compiled/passthroughrgb11ps.h:
  • src/libGLESv2/renderer/shaders/compiled/passthroughrgba11ps.h:
  • src/libGLESv2/renderer/shaders/compiled/standardvs.h:
  • src/libGLESv2/renderer/shaders/generate_shaders.bat:
  • src/libGLESv2/utilities.cpp:

(gl::ComputeTypeSize):

  • src/libGLESv2/utilities.h:
  • src/third_party/murmurhash/MurmurHash3.cpp:

(rotl32):
(rotl64):
(getblock):
(fmix):
(MurmurHash3_x86_32):
(MurmurHash3_x86_128):
(MurmurHash3_x64_128):

  • src/third_party/murmurhash/MurmurHash3.h:
  • src/third_party/trace_event: Added.
  • src/third_party/trace_event/trace_event.h: Added.

(gl::TraceEvent::TraceID::TraceID):
(gl::TraceEvent::TraceID::data):
(gl::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):
(gl::TraceEvent::TraceStringWithCopy::operator const char* ):
(gl::TraceEvent::setTraceValue):
(gl::TraceEvent::addTraceEvent):
(gl::TraceEvent::TraceEndOnScopeClose::TraceEndOnScopeClose):
(gl::TraceEvent::TraceEndOnScopeClose::~TraceEndOnScopeClose):
(gl::TraceEvent::TraceEndOnScopeClose::initialize):
(gl::TraceEvent::TraceEndOnScopeClose::addEventIfEnabled):
(gl::TraceEvent::SamplingStateScope::SamplingStateScope):
(gl::TraceEvent::SamplingStateScope::~SamplingStateScope):
(gl::TraceEvent::SamplingStateScope::current):
(gl::TraceEvent::SamplingStateScope::set):

4:35 PM Changeset in webkit [159532] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(158384) ARMv7 point checks too restrictive for native calls to traditional ARM code
​https://bugs.webkit.org/show_bug.cgi?id=124612

Reviewed by Geoffrey Garen.

Removed ASSERT checks (i.e. lower bit set) for ARM Thumb2 destination addresses related to
calls since we are calling native ARM traditional functions like sin() and cos().

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::relinkCall):

  • assembler/MacroAssemblerCodeRef.h:
4:29 PM Changeset in webkit [159531] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r159459.
​http://trac.webkit.org/changeset/159459
​https://bugs.webkit.org/show_bug.cgi?id=124616

tons of assertions on launch (Requested by thorton on
#webkit).

  • API/JSContext.mm:

(-[JSContext setException:]):
(-[JSContext wrapperForObjCObject:]):
(-[JSContext wrapperForJSObject:]):

  • API/JSContextRef.cpp:

(JSContextGroupRelease):
(JSGlobalContextRelease):

  • API/JSManagedValue.mm:

(-[JSManagedValue initWithValue:]):
(-[JSManagedValue value]):

  • API/JSObjectRef.cpp:

(JSObjectIsFunction):
(JSObjectCopyPropertyNames):

  • API/JSValue.mm:

(containerValueToObject):

  • API/JSWrapperMap.mm:

(tryUnwrapObjcObject):

3:58 PM Changeset in webkit [159530] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

3:54 PM Changeset in webkit [159529] by matthew_hanson@apple.com
  • 2 edits in tags/Safari-538.7/Source/JavaScriptCore

Merge of 159515.

3:48 PM Changeset in webkit [159528] by fpizlo@apple.com
  • 11 edits in trunk/Source

Rename WatchpointSet::notifyWrite() should be renamed to WatchpointSet::fireAll()
​https://bugs.webkit.org/show_bug.cgi?id=124609

Source/JavaScriptCore:

Rubber stamped by Mark Lam.

notifyWrite() is a thing that SymbolTable does. WatchpointSet uses that terminology
because it was original designed to match exactly SymbolTable's semantics. But now
it's a confusing term.

  • bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::fireAllSlow):

  • bytecode/Watchpoint.h:

(JSC::WatchpointSet::fireAll):
(JSC::InlineWatchpointSet::fireAll):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::haveABadTime):

  • runtime/Structure.h:

(JSC::Structure::notifyTransitionFromThisStructure):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::notifyWriteSlow):

Source/WebCore:

Rubber stamped by Mark Lam.

No new tests because no new behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::create):

3:47 PM Changeset in webkit [159527] by matthew_hanson@apple.com
  • 5 edits in tags/Safari-538.7/Source/JavaScriptCore

Merge of 159508.

3:38 PM Changeset in webkit [159526] by betravis@adobe.com
  • 15 edits in trunk
[CSS Shapes] Parse [<box>
<shape>] values

​https://bugs.webkit.org/show_bug.cgi?id=124426

Reviewed by Dirk Schulze.

Source/WebCore:

Shape values can now have an optional box specifying the coordinate sytem to use
for sizing and positioning the shape. This patch adds the functionality to support
parsing these new values.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForBox): Added function to convert between BasicShape::ReferenceBox
and CSSPrimitiveValue (which wraps a CSSValueID).
(WebCore::boxForValue): Ditto.
(WebCore::valueForBasicShape): Translations between CSSBasicShape and BasicShape
must now include the reference box.
(WebCore::basicShapeForValue): Ditto.

  • css/BasicShapeFunctions.h:
  • css/CSSBasicShapes.cpp:

(WebCore::buildRectangleString): Include the box in the built CSS string.
(WebCore::CSSBasicShapeRectangle::cssText): Ditto.
(WebCore::CSSBasicShapeRectangle::equals): Include the box in comparisions.
(WebCore::buildCircleString):
(WebCore::CSSBasicShapeCircle::cssText):
(WebCore::CSSBasicShapeCircle::equals):
(WebCore::buildEllipseString):
(WebCore::CSSBasicShapeEllipse::cssText):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::buildPolygonString):
(WebCore::CSSBasicShapePolygon::cssText):
(WebCore::CSSBasicShapePolygon::equals):
(WebCore::buildInsetRectangleString):
(WebCore::CSSBasicShapeInsetRectangle::cssText):
(WebCore::CSSBasicShapeInsetRectangle::equals):

  • css/CSSBasicShapes.h:

(WebCore::CSSBasicShape::box): BasicShapes now have an reference box.
(WebCore::CSSBasicShape::setBox): Ditto.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Shape-inside can also
parse the box values.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): The shape properties use parseShapeProperty,
while minor adjustments were made to parseBasicShape's return type.
(WebCore::isBoxValue): Is the CSSValueID one of the box values.
(WebCore::CSSParser::parseShapeProperty): Parse one of the shape properties
and return an appropriate CSSValue.
(WebCore::CSSParser::parseBasicShape): Return a CSSBasicShape rather than
adding a ShapeValue to the style.

  • css/CSSParser.h:
  • rendering/style/BasicShapes.h:

(WebCore::BasicShape::box): Add a box to BasicShape and getters/setters.
(WebCore::BasicShape::setBox): Ditto.
(WebCore::BasicShape::BasicShape): Ditto.

LayoutTests:

Test that <box> <shape> and <shape> <box> values are both supported and successfully parsed.
Currently, we order the parsed result as <shape> <box> when the value is output through
the CSSOM. Also test that other combinations with shapes and boxes are not parsed.

  • fast/shapes/parsing/parsing-shape-inside-expected.txt:
  • fast/shapes/parsing/parsing-shape-inside.html:
  • fast/shapes/parsing/parsing-shape-outside-expected.txt:
  • fast/shapes/parsing/parsing-shape-outside.html:
  • fast/shapes/parsing/parsing-test-utils.js:
3:06 PM Changeset in webkit [159525] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] 9 WebGL conformance failures after r159518.
​https://bugs.webkit.org/show_bug.cgi?id=124608

Reviewed by Dean Jackson.

Once we removed the CIImage drawing path, there was no longer any reason to flip the
CGImageRef before drawing to the provided GraphicsContext.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

2:57 PM Changeset in webkit [159524] by matthew_hanson@apple.com
  • 14 edits
    1 copy in tags/Safari-538.7/Source/JavaScriptCore

Rollout r159483. This change effectively adds r159351 back into the tag.

2:50 PM Changeset in webkit [159523] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

Web Speech API crashes onboundary event handling with reload
​https://bugs.webkit.org/show_bug.cgi?id=124607

Reviewed by Tim Horton.

If the page goes away, we need to cleanup the Mac platform synthesizer object, because
NSSpeechSynthesizer is retained elsewhere to handle the callbacks (so it doesn't automatically
get torn down).

The layout tests for speech rely on a Mock synthesizer, so there is no good way to test this
Mac platform specific behavior.

  • platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper invalidate]):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):

2:27 PM Changeset in webkit [159522] by mitz@apple.com
  • 2 edits in trunk/Tools

<rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5

Rubber-stamped by Mark Rowe.

Reverted r156840.

  • TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1:59 PM Changeset in webkit [159521] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r159395): Error compiling for ARMv7
​https://bugs.webkit.org/show_bug.cgi?id=124552

Reviewed by Geoffrey Garen.

Fixed the implementation of branch8(RelationalCondition cond, AbsoluteAddress address, TrustedImm32 right)
to materialize and use address similar to other ARMv7 branchXX() functions.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branch8):

1:55 PM Changeset in webkit [159520] by mark.lam@apple.com
  • 34 edits
    5 adds in trunk

Add tracking of endColumn for Executables.
​https://bugs.webkit.org/show_bug.cgi?id=124245.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  1. Fixed computation of columns to take into account the startColumn from <script> tags. Previously, we were only computing the column relative to the char after the <script> tag. Now, the column number that JSC computes is always the column number you'll see when viewing the source in a text editor (assuming the first column position is 1, not 0).
  1. Previously, unlinkedExecutables kept the a base-1 startColumn for ProgramExecutables and EvalExecutables, but uses base-0 columns for FunctionExecutables. This has been fixed so that they all use base-0 columns. When the executable gets linked, the column is adjusted into a base-1 value.
  1. In the UnlinkedFunctionExecutable, renamed m_functionStartOffset to m_unlinkedFunctionNameStart because it actually points to the start column in the name part of the function declaration.

Similarly, renamed m_functionStartColumn to m_unlinkedBodyStartColumn
because it points to the first character in the function body. This is
usually '{' except for functions created from "global code" which
excludes its braces. See FunctionExecutable::fromGlobalCode().

The exclusion of braces for the global code case is needed so that

computed start and end columns will more readily map to what a JS
developer would expect them to be. Otherwise, the first column of the
function source will not be 1 (includes prepended characters added in
constructFunctionSkippingEvalEnabledCheck()).

Also, similarly, a m_unlinkedBodyEndColumn has been added to track the
end column of the UnlinkedFunctionExecutable.

  1. For unlinked executables, end column values are either:
    1. Relative to the start of the last line if (last line != first line).
    2. Relative to the start column position if (last line == first line).

The second case is needed so that we can add an appropriate adjustment
to the end column value (just like we do for the start column) when we
link the executable.

  1. This is not new to this patch, but it worth noting that the lineCount values used through this patch has the following meaning:
    • a lineCount of 0 means the source for this code block is on 1 line.
    • a lineCount of N means there are N + l lines of source.

This interpretation is janky, but was present before this patch. We can
clean that up later in another patch.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • In order to implement WebCore::Internals::parserMetaData(), we need to move some seemingly unrelated header files from the Project section to the Private section so that they can be #include'd by the forwarding CodeBlock.h from WebCore.
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::sourceCodeForTools):
(JSC::CodeBlock::CodeBlock):

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

  • m_isFromGlobalCode is needed to support the exclusion of the open brace / prepended code for functions created from "global code".

(JSC::UnlinkedFunctionExecutable::link):
(JSC::UnlinkedFunctionExecutable::fromGlobalCode):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::create):
(JSC::UnlinkedFunctionExecutable::unlinkedFunctionNameStart):
(JSC::UnlinkedFunctionExecutable::unlinkedBodyStartColumn):
(JSC::UnlinkedFunctionExecutable::unlinkedBodyEndColumn):
(JSC::UnlinkedFunctionExecutable::recordParse):
(JSC::UnlinkedCodeBlock::recordParse):
(JSC::UnlinkedCodeBlock::endColumn):

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionBodyNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::setFunctionNameStart):

  • parser/Lexer.cpp:

(JSC::::shiftLineTerminator):

  • Removed an unused SourceCode Lexer<T>::sourceCode() function.
  • parser/Lexer.h:

(JSC::Lexer::positionBeforeLastNewline):
(JSC::Lexer::prevTerminator):

  • Added tracking of m_positionBeforeLastNewline in the Lexer to enable us to exclude the close brace / appended code for functions created from "global code".
  • parser/Nodes.cpp:

(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
(JSC::FunctionBodyNode::setEndPosition):

  • setEndPosition() is needed to fixed up the end position so that we can exclude the close brace / appended code for functions created from "global code".
  • parser/Nodes.h:

(JSC::ProgramNode::startColumn):
(JSC::ProgramNode::endColumn):
(JSC::EvalNode::startColumn):
(JSC::EvalNode::endColumn):
(JSC::FunctionBodyNode::setFunctionNameStart):
(JSC::FunctionBodyNode::functionNameStart):
(JSC::FunctionBodyNode::endColumn):

  • parser/Parser.cpp:

(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):

  • parser/Parser.h:

(JSC::Parser::positionBeforeLastNewline):
(JSC::::parse):

  • Subtracted 1 from startColumn here to keep the node column values consistently base-0. See note 2 above.

(JSC::parse):

  • parser/SourceProviderCacheItem.h:

(JSC::SourceProviderCacheItem::SourceProviderCacheItem):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::setFunctionNameStart):

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

  • runtime/CodeCache.h:
  • runtime/Executable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::ProgramExecutable::initializeGlobalProperties):
(JSC::FunctionExecutable::fromGlobalCode):

  • runtime/Executable.h:

(JSC::ExecutableBase::isEvalExecutable):
(JSC::ExecutableBase::isProgramExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::endColumn):
(JSC::ScriptExecutable::recordParse):
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::bodyIncludesBraces):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/FunctionPrototype.cpp:

(JSC::insertSemicolonIfNeeded):
(JSC::functionProtoFuncToString):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):

Source/WebCore:

Test: js/dom/script-start-end-locations.html

  • ForwardingHeaders/bytecode: Added.
  • ForwardingHeaders/bytecode/CodeBlock.h: Added.
  • WebCore.exp.in:
  • testing/Internals.cpp:

(WebCore::GetCallerCodeBlockFunctor::GetCallerCodeBlockFunctor):
(WebCore::GetCallerCodeBlockFunctor::operator()):
(WebCore::GetCallerCodeBlockFunctor::codeBlock):
(WebCore::Internals::parserMetaData):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
  • Added an exported symbol to make the Win32 build happy. The Win64 symbol is currently a copy of the Win32 one. It'll need to be updated if the mangled symbol is different for Win64.

LayoutTests:

  • fast/events/window-onerror2-expected.txt:
  • inspector-protocol/debugger/setBreakpoint-actions-expected.txt:
  • js/dom/script-start-end-locations-expected.txt: Added.
  • js/dom/script-start-end-locations.html: Added.
  • js/dom/script-tests/script-start-end-locations.js: Added.
  • js/dom/stack-trace-expected.txt:
  • js/dom/stack-trace.html:
  • Changed tabs to spaces. The tabs were making it hard to visually confirm the exected column values for 2 functions.
1:39 PM Changeset in webkit [159519] by jer.noble@apple.com
  • 20 edits
    4 adds in trunk

[MSE] Support fastSeek() in MediaSource.
​https://bugs.webkit.org/show_bug.cgi?id=124422

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-fastseek.html

  • Modules/mediasource/MediaSource.cpp:
  • Modules/mediasource/MediaSource.h:

Add support for "seek to the next fastest time" in MediaSource by
returning the time of the nearest Sync sample.

Move the data structure logic out of SourceBuffer and into it's own
class:

  • Modules/mediasource/SampleMap.cpp: Added.

(WebCore::SampleIsLessThanMediaTimeComparator::operator()):
(WebCore::SampleIsGreaterThanMediaTimeComparator::operator()):
(WebCore::SampleIsRandomAccess::operator()):
(WebCore::SamplePresentationTimeIsWithinRangeComparator::operator()):
(WebCore::SampleMap::addSample):
(WebCore::SampleMap::removeSample):
(WebCore::SampleMap::findSampleContainingPresentationTime):
(WebCore::SampleMap::findSampleAfterPresentationTime):
(WebCore::SampleMap::findSampleWithDecodeTime):
(WebCore::SampleMap::reverseFindSampleContainingPresentationTime):
(WebCore::SampleMap::reverseFindSampleBeforePresentationTime):
(WebCore::SampleMap::reverseFindSampleWithDecodeTime):
(WebCore::SampleMap::findSyncSamplePriorToPresentationTime):
(WebCore::SampleMap::findSyncSamplePriorToDecodeIterator):
(WebCore::SampleMap::findSyncSampleAfterPresentationTime):
(WebCore::SampleMap::findSyncSampleAfterDecodeIterator):
(WebCore::SampleMap::findSamplesBetweenPresentationTimes):
(WebCore::SampleMap::findDependentSamples):

  • Modules/mediasource/SampleMap.h: Added.

(WebCore::SampleMap::presentationBegin):
(WebCore::SampleMap::presentationEnd):
(WebCore::SampleMap::decodeBegin):
(WebCore::SampleMap::decodeEnd):
(WebCore::SampleMap::reversePresentationBegin):
(WebCore::SampleMap::reversePresentationEnd):
(WebCore::SampleMap::reverseDecodeBegin):
(WebCore::SampleMap::reverseDecodeEnd):

Add logic to find and return the time of the next & previous sync
sample, within the threshold provided:

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::TrackBuffer::TrackBuffer):
(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime):
(WebCore::SourceBuffer::sourceBufferPrivateFastSeekTimeForMediaTime):
(WebCore::SourceBuffer::appendBufferTimerFired):
(WebCore::SourceBuffer::setActive):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::sourceBufferPrivateDidBecomeReadyForMoreSamples):
(WebCore::SourceBuffer::provideMediaData):

  • Modules/mediasource/SourceBuffer.h:
  • platform/graphics/SourceBufferPrivate.h:

(WebCore::SourceBufferPrivate::setActive):

  • platform/graphics/SourceBufferPrivateClient.h:

(WebCore::SourceBufferPrivateClient::sourceBufferPrivateFastSeekTimeForMediaTime):
(WebCore::SourceBufferPrivateClient::sourceBufferPrivateSeekToTime):

Add new files to the project:

  • WebCore.xcodeproj/project.pbxproj:

Drive-by fixes in HTMLMediaElement:

  • html/HTMLMediaSource.h:
  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::finishSeek): Cause the MediaSource to check the ready state of all its buffers.
(HTMLMediaElement::selectNextSourceChild): Pass in whether the source element has a MediaSource URL.

Implement the seekWithTolerance behavior in MockMediaPlayerMediaSource:

  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::maxTimeSeekableDouble):
(WebCore::MockMediaPlayerMediaSource::currentTimeDouble):
(WebCore::MockMediaPlayerMediaSource::seekWithTolerance):
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime):

  • platform/mock/mediasource/MockMediaPlayerMediaSource.h:
  • platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::seekToTime):

  • platform/mock/mediasource/MockMediaSourcePrivate.h:
  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockMediaSample::flags):
(WebCore::MockSourceBufferPrivate::setActive):
(WebCore::MockSourceBufferPrivate::fastSeekTimeForMediaTime):
(WebCore::MockSourceBufferPrivate::seekToTime):

  • platform/mock/mediasource/MockSourceBufferPrivate.h:

LayoutTests:

  • media/media-source/media-source-fastseek-expected.txt: Added.
  • media/media-source/media-source-fastseek.html: Added.
  • media/media-source/mock-media-source.js:

(var):

1:37 PM Changeset in webkit [159518] by jer.noble@apple.com
  • 9 edits in trunk/Source/WebCore

[Mac] 10X slower than Chrome when drawing a video into a canvas
​https://bugs.webkit.org/show_bug.cgi?id=124599

Reviewed by Dean Jackson.

Improve performance by creating a CGImageRef which directly references the CVPixelBuffer provided
by AVPlayerItemVideoOutput:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::CVPixelBufferGetBytePointerCallback):
(WebCore::CVPixelBufferReleaseBytePointerCallback):
(WebCore::CVPixelBufferReleaseInfoCallback):
(WebCore::createImageFromPixelBuffer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateLastImage):

Additionally, when asked to paint with an AVPlayerItemVideoOutput, block until the output notifies
its delegate that a pixel buffer is available:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::globalPullDelegateQueue):
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::nativeImageForCurrentTime):
(WebCore::MediaPlayerPrivateAVFoundationObjC::waitForVideoOutputMediaDataWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange):
(-[WebCoreAVFPullDelegate initWithCallback:]):
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):
(-[WebCoreAVFPullDelegate outputSequenceWasFlushed:]):

To further optimize video -> canvas drawing, add a method which can return a PassNativeImage to be
drawn directly onto the canvas, rather than rendering into an intermediary context:

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::nativeImageForCurrentTime):

  • html/HTMLVideoElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::nativeImageForCurrentTime):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::nativeImageForCurrentTime):

1:23 PM Changeset in webkit [159517] by beidson@apple.com
  • 10 edits
    3 deletes in trunk/Source/WebCore

Consolidate IDBBackingStore*Interface and IDBBackingStore*LevelDB
​https://bugs.webkit.org/show_bug.cgi?id=124597

Reviewed by Alexey Proskuryakov.

The Interface abstraction doesn’t make sense anymore, as LevelDB will be the only implementor.

  • Modules/indexeddb/IDBBackingStoreCursorInterface.h: Removed.
  • Modules/indexeddb/IDBBackingStoreInterface.h: Removed.
  • Modules/indexeddb/IDBBackingStoreTransactionInterface.h: Removed.
  • Modules/indexeddb/IDBServerConnection.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h:

(WebCore::IDBBackingStoreCursorLevelDB::key):
(WebCore::IDBBackingStoreCursorLevelDB::primaryKey):
(WebCore::IDBBackingStoreCursorLevelDB::recordIdentifier):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::getOrEstablishIDBDatabaseMetadata):
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion):
(WebCore::IDBBackingStoreLevelDB::deleteDatabase):
(WebCore::IDBBackingStoreLevelDB::createObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteObjectStore):
(WebCore::IDBBackingStoreLevelDB::getRecord):
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::clearObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::createIndex):
(WebCore::IDBBackingStoreLevelDB::deleteIndex):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::IDBBackingStoreLevelDB::findKeyInIndex):
(WebCore::IDBBackingStoreLevelDB::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStoreLevelDB::keyExistsInIndex):
(WebCore::IDBBackingStoreLevelDB::makeIndexWriters):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h:

(WebCore::IDBBackingStoreTransactionLevelDB::levelDBTransactionFrom):

  • Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.cpp:

(WebCore::IDBIndexWriterLevelDB::writeIndexKeys):
(WebCore::IDBIndexWriterLevelDB::verifyIndexKeys):
(WebCore::IDBIndexWriterLevelDB::addingKeyAllowed):

  • Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.h:
  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::get):
(WebCore::IDBServerConnectionLevelDB::openCursor):
(WebCore::IDBServerConnectionLevelDB::count):
(WebCore::IDBServerConnectionLevelDB::deleteRange):

  • WebCore.xcodeproj/project.pbxproj:
1:14 PM Changeset in webkit [159516] by commit-queue@webkit.org
  • 20 edits in trunk/Source/WebCore

Get rid of bare new in SVGAnimatedColorAnimator::constructFromString()
​https://bugs.webkit.org/show_bug.cgi?id=124595

Patch by Sergio Correia <Sergio Correia> on 2013-11-19
Reviewed by Darin Adler.

Use std::unique_ptr instead, to manage the arguments passed to the create
methods of SVGAnimatedType.

No new tests, covered by existing tests.

  • svg/SVGAnimatedAngle.cpp:

(WebCore::SVGAnimatedAngleAnimator::constructFromString): Replace bare
pointer with std::unique_ptr.

  • svg/SVGAnimatedBoolean.cpp:

(WebCore::SVGAnimatedBooleanAnimator::constructFromString): Ditto.

  • svg/SVGAnimatedColor.cpp:

(WebCore::SVGAnimatedColorAnimator::constructFromString): Ditto.

  • svg/SVGAnimatedEnumeration.cpp:

(WebCore::SVGAnimatedEnumerationAnimator::constructFromString): Ditto.

  • svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::constructFromString): Ditto.

  • svg/SVGAnimatedIntegerOptionalInteger.cpp:

(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::constructFromString):
Ditto.

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::constructFromString): Ditto.

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::constructFromString): Ditto.

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::constructFromString): Ditto.

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::constructFromString): Ditto.

  • svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromString):
Ditto.

  • svg/SVGAnimatedPointList.cpp:

(WebCore::SVGAnimatedPointListAnimator::constructFromString): Ditto.

  • svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::constructFromString):
Ditto.

  • svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::constructFromString): Ditto.

  • svg/SVGAnimatedString.cpp:

(WebCore::SVGAnimatedStringAnimator::constructFromString): Ditto.

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::constructFromString):
Ditto.

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::createAngleAndEnumeration): Use
std::unique_ptr instead of bare pointer as parameter.
(WebCore::SVGAnimatedType::createBoolean): Ditto.
(WebCore::SVGAnimatedType::createColor): Ditto.
(WebCore::SVGAnimatedType::createEnumeration): Ditto.
(WebCore::SVGAnimatedType::createInteger): Ditto.
(WebCore::SVGAnimatedType::createIntegerOptionalInteger): Ditto.
(WebCore::SVGAnimatedType::createLength): Ditto.
(WebCore::SVGAnimatedType::createLengthList): Ditto.
(WebCore::SVGAnimatedType::createNumber): Ditto.
(WebCore::SVGAnimatedType::createNumberList): Ditto.
(WebCore::SVGAnimatedType::createNumberOptionalNumber): Ditto.
(WebCore::SVGAnimatedType::createPointList): Ditto.
(WebCore::SVGAnimatedType::createPreserveAspectRatio): Ditto.
(WebCore::SVGAnimatedType::createRect): Ditto.
(WebCore::SVGAnimatedType::createString): Ditto.
(WebCore::SVGAnimatedType::createTransformList): Ditto.

  • svg/SVGAnimatedType.h: Use std::unique_ptr as parameter in the

create methods.

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue): Make
helper return std::unique_ptr instead of bare pointer.
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValues): Ditto.

12:59 PM Changeset in webkit [159515] by dino@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

MarkedSpace::resumeAllocating needs to delay release
​https://bugs.webkit.org/show_bug.cgi?id=124596

Reviewed by Geoffrey Garen.

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::resumeAllocating): Add DelayedReleaseScope protection.

12:34 PM Changeset in webkit [159514] by Antoine Quint
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: layer info sidebar should convert to MB for very large layers
​https://bugs.webkit.org/show_bug.cgi?id=124570

Reviewed by Timothy Hatcher.

Setting higherResolution to true (its default value if omitted) when calling
Number.bytesToString() would always result in a KB-formatted string instead
since it didn't check for a < 1024 value as well.

  • UserInterface/Utilities.js:

(Number.bytesToString):

12:15 PM Changeset in webkit [159513] by hmuller@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSS Shapes] Refactor RectangleShape
​https://bugs.webkit.org/show_bug.cgi?id=124416

Privatize and rename the FloatRoundedRect class defined in RectangleShape.h.
The new class is called RectangleShape::ShapeBounds. This change enables
creating a proper FloatRoundedRect analog of the existing RoundedRect class;
part of adding support for box shapes, per the latest CSS spec.

Reviewed by Dean Jackson.

No new tests, just refactoring.

  • rendering/shapes/RectangleShape.cpp:

(WebCore::RectangleShape::ShapeBounds::paddingBounds):
(WebCore::RectangleShape::ShapeBounds::marginBounds):
(WebCore::RectangleShape::ShapeBounds::cornerInterceptForWidth):
(WebCore::RectangleShape::shapePaddingBounds):
(WebCore::RectangleShape::shapeMarginBounds):
(WebCore::RectangleShape::getExcludedIntervals):
(WebCore::RectangleShape::getIncludedIntervals):
(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):

  • rendering/shapes/RectangleShape.h:

(WebCore::RectangleShape::ShapeBounds::ShapeBounds):
(WebCore::RectangleShape::ShapeBounds::rx):
(WebCore::RectangleShape::ShapeBounds::ry):

12:14 PM Changeset in webkit [159512] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebCore

Mark classes deriving from SVGAnimatedTypeAnimator as FINAL
​https://bugs.webkit.org/show_bug.cgi?id=124456

Patch by Sergio Correia <Sergio Correia> on 2013-11-19
Reviewed by Darin Adler.

Also add OVERRIDE to their virtual methods appropriately and remove
existing empty virtual destructors.

No new tests, covered by existing ones.

  • svg/SVGAnimatedAngle.h:
  • svg/SVGAnimatedBoolean.h:
  • svg/SVGAnimatedColor.h:
  • svg/SVGAnimatedEnumeration.h:
  • svg/SVGAnimatedInteger.h:
  • svg/SVGAnimatedIntegerOptionalInteger.h:
  • svg/SVGAnimatedLength.h:
  • svg/SVGAnimatedLengthList.h:
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedNumberList.h:
  • svg/SVGAnimatedNumberOptionalNumber.h:
  • svg/SVGAnimatedPath.h:
  • svg/SVGAnimatedPointList.h:
  • svg/SVGAnimatedPreserveAspectRatio.h:
  • svg/SVGAnimatedRect.h:
  • svg/SVGAnimatedString.h:
  • svg/SVGAnimatedTransformList.h:
12:08 PM Changeset in webkit [159511] by beidson@apple.com
  • 13 edits
    3 moves
    2 adds
    2 deletes in trunk/Source

Add WebIDBServerConnection and DatabaseProcessIDBConnection stubs
​https://bugs.webkit.org/show_bug.cgi?id=124562

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Export some more symbols and headers for WK2 to use.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Also remove Web/DatabaseProcessDatabaseBackend stubs, as that is no longer the abstraction layer.

  • DatabaseProcess/DatabaseToWebProcessConnection.cpp:

(WebKit::DatabaseToWebProcessConnection::didReceiveMessage):
(WebKit::DatabaseToWebProcessConnection::establishIDBConnection):

  • DatabaseProcess/DatabaseToWebProcessConnection.h:
  • DatabaseProcess/DatabaseToWebProcessConnection.messages.in:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.cpp.

(WebKit::DatabaseProcessIDBConnection::DatabaseProcessIDBConnection):
(WebKit::DatabaseProcessIDBConnection::~DatabaseProcessIDBConnection):
(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::messageSenderConnection):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.h.

(WebKit::DatabaseProcessIDBConnection::create):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.messages.in.
  • Shared/Databases/IndexedDB/IDBUtilities.cpp:

(WebKit::uniqueDatabaseIdentifier): Modified to take two security origin arguments.

  • Shared/Databases/IndexedDB/IDBUtilities.h:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::open):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp: Added. Stubbed out all the pure virtual methods.

(WebKit::generateBackendIdentifier):
(WebKit::WebIDBServerConnection::WebIDBServerConnection):
(WebKit::WebIDBServerConnection::~WebIDBServerConnection):
(WebKit::WebIDBServerConnection::isClosed):
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::deleteDatabase):
(WebKit::WebIDBServerConnection::close):
(WebKit::WebIDBServerConnection::openTransaction):
(WebKit::WebIDBServerConnection::beginTransaction):
(WebKit::WebIDBServerConnection::commitTransaction):
(WebKit::WebIDBServerConnection::resetTransaction):
(WebKit::WebIDBServerConnection::rollbackTransaction):
(WebKit::WebIDBServerConnection::setIndexKeys):
(WebKit::WebIDBServerConnection::createObjectStore):
(WebKit::WebIDBServerConnection::createIndex):
(WebKit::WebIDBServerConnection::deleteIndex):
(WebKit::WebIDBServerConnection::get):
(WebKit::WebIDBServerConnection::put):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::count):
(WebKit::WebIDBServerConnection::deleteRange):
(WebKit::WebIDBServerConnection::clearObjectStore):
(WebKit::WebIDBServerConnection::deleteObjectStore):
(WebKit::WebIDBServerConnection::changeDatabaseVersion):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):
(WebKit::WebIDBServerConnection::cursorPrefetchIteration):
(WebKit::WebIDBServerConnection::cursorPrefetchReset):
(WebKit::WebIDBServerConnection::messageSenderConnection):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h: Added.
  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp: Removed.
  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h: Removed.
  • WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
  • DerivedSources.make:
  • WebKit2.xcodeproj/project.pbxproj:
11:55 AM Changeset in webkit [159510] by dino@apple.com
  • 2 edits in trunk/LayoutTests

fast/forms/form-associated-element-crash.html often times out on Mavericks WK1
​https://bugs.webkit.org/show_bug.cgi?id=124593

Marked as occasionally timing out.

  • platform/mac/TestExpectations:
11:25 AM Changeset in webkit [159509] by Michał Pakuła vel Rutka
  • 3 edits in trunk/Source/WebKit2

Unreviewed EFL and GTK build fix attempt after r159507

  • CMakeLists.txt: Changed Platform/CoreIPC/DataReference.cpp to Platform/IPC/DataReference.cpp
  • GNUmakefile.list.am: Ditto
11:10 AM Changeset in webkit [159508] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

IncrementalSweeper needs to use DelayedReleaseScope too
​https://bugs.webkit.org/show_bug.cgi?id=124558

Reviewed by Filip Pizlo.

It does sweeping too, so it needs to use it. Also refactored an
ASSERT that should have caught this sooner.

  • heap/DelayedReleaseScope.h:

(JSC::DelayedReleaseScope::isInEffectFor):

  • heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::doSweep):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::sweep):

10:32 AM Changeset in webkit [159507] by andersca@apple.com
  • 2 edits
    2 moves in trunk/Source/WebKit2

Move DataReference to Platform/IPC.

  • Platform/IPC/DataReference.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/DataReference.cpp.
  • Platform/IPC/DataReference.h: Renamed from Source/WebKit2/Platform/CoreIPC/DataReference.h.
  • WebKit2.xcodeproj/project.pbxproj:
10:20 AM Changeset in webkit [159506] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Add and call PageLoadState::reset
​https://bugs.webkit.org/show_bug.cgi?id=124591

Reviewed by Dan Bernstein.

  • UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::reset):

  • UIProcess/PageLoadState.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash):

10:14 AM Changeset in webkit [159505] by Antoine Quint
  • 2 edits in trunk/Source/WebInspectorUI

Remove some unused utilities from Utilities.js
​https://bugs.webkit.org/show_bug.cgi?id=124590

Reviewed by Darin Adler.

Remove some methods and properties that were no longer used through the codebase.

  • UserInterface/Utilities.js:
9:36 AM Changeset in webkit [159504] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk

Map the dir attribute to the CSS direction property.
​https://bugs.webkit.org/show_bug.cgi?id=124572.

Patch by Frédéric Wang <​fred.wang@free.fr> on 2013-11-19
Reviewed by Darin Adler.

Source/WebCore:

Tests: mathml/presentation/direction-overall.html

mathml/presentation/direction-token.html
mathml/presentation/direction.html

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isPresentationAttribute): add dir
(WebCore::MathMLElement::collectStyleForPresentationAttribute): map dir

  • mathml/mathattrs.in: add the dir attribute
  • mathml/mathtags.in: add the mstyle tag (needed to use mstyleTag)

LayoutTests:

  • mathml/presentation/direction-expected.html: add more tests.
  • mathml/presentation/direction-overall-expected.html: Added.
  • mathml/presentation/direction-overall.html: Added.
  • mathml/presentation/direction-token-expected.html: Added.
  • mathml/presentation/direction-token.html: Added.
  • mathml/presentation/direction.html: add more tests.
9:22 AM Changeset in webkit [159503] by commit-queue@webkit.org
  • 68 edits in trunk/Source/WebCore

[SVG] Convert OwnPtr/PassOwnPtr to std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=124382

Patch by Sergio Correia <Sergio Correia> on 2013-11-19
Reviewed by Darin Adler.

The files modified are mostly under WebCore/svg/; in a few cases, some
"external" files needed changes as well.

No new tests, covered by existing ones.

  • css/CSSFontFaceSource.cpp:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedImage.h:
  • platform/graphics/SimpleFontData.cpp:
  • platform/graphics/SimpleFontData.h:
  • rendering/svg/RenderSVGResourceContainer.cpp:
  • svg/SVGAnimateElement.cpp:
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimatedAngle.cpp:
  • svg/SVGAnimatedAngle.h:
  • svg/SVGAnimatedBoolean.cpp:
  • svg/SVGAnimatedBoolean.h:
  • svg/SVGAnimatedColor.cpp:
  • svg/SVGAnimatedColor.h:
  • svg/SVGAnimatedEnumeration.cpp:
  • svg/SVGAnimatedEnumeration.h:
  • svg/SVGAnimatedInteger.cpp:
  • svg/SVGAnimatedInteger.h:
  • svg/SVGAnimatedIntegerOptionalInteger.cpp:
  • svg/SVGAnimatedIntegerOptionalInteger.h:
  • svg/SVGAnimatedLength.cpp:
  • svg/SVGAnimatedLength.h:
  • svg/SVGAnimatedLengthList.cpp:
  • svg/SVGAnimatedLengthList.h:
  • svg/SVGAnimatedNumber.cpp:
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedNumberList.cpp:
  • svg/SVGAnimatedNumberList.h:
  • svg/SVGAnimatedNumberOptionalNumber.cpp:
  • svg/SVGAnimatedNumberOptionalNumber.h:
  • svg/SVGAnimatedPath.cpp:
  • svg/SVGAnimatedPath.h:
  • svg/SVGAnimatedPointList.cpp:
  • svg/SVGAnimatedPointList.h:
  • svg/SVGAnimatedPreserveAspectRatio.cpp:
  • svg/SVGAnimatedPreserveAspectRatio.h:
  • svg/SVGAnimatedRect.cpp:
  • svg/SVGAnimatedRect.h:
  • svg/SVGAnimatedString.cpp:
  • svg/SVGAnimatedString.h:
  • svg/SVGAnimatedTransformList.cpp:
  • svg/SVGAnimatedTransformList.h:
  • svg/SVGAnimatedType.cpp:
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatedTypeAnimator.cpp:
  • svg/SVGAnimatedTypeAnimator.h:
  • svg/SVGAnimatorFactory.h:
  • svg/SVGDocumentExtensions.cpp:
  • svg/SVGDocumentExtensions.h:
  • svg/SVGFontData.h:
  • svg/SVGFontElement.cpp:
  • svg/SVGFontElement.h:
  • svg/SVGGraphicsElement.cpp:
  • svg/SVGGraphicsElement.h:
  • svg/SVGPathByteStreamSource.h:
  • svg/SVGPathParser.h:
  • svg/SVGPathSegListSource.h:
  • svg/SVGPathStringSource.h:
  • svg/SVGPathUtilities.cpp:
  • svg/SVGPathUtilities.h:
  • svg/animation/SMILTimeContainer.cpp:
  • svg/animation/SMILTimeContainer.h:
  • svg/graphics/SVGImage.cpp:
  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.h:
  • svg/properties/SVGAttributeToPropertyMap.cpp:
  • svg/properties/SVGAttributeToPropertyMap.h:
9:15 AM Changeset in webkit [159502] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

Add LineInlineHeaders.h to WebCore.xcodeproj
<​https://webkit.org/b/124460>

Reviewed by Csaba Osztrogonác.

LineInlineHeaders.h (r159354) hasn't been added to WebCore.xcodeproj. This patch adds to it.

No new tests, no behavior change.

  • WebCore.xcodeproj/project.pbxproj:
9:11 AM Changeset in webkit [159501] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

  • platform/efl/TestExpectations: Add new failure test expectations.
6:55 AM Changeset in webkit [159500] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[AX] Use std::unique_ptr to manage AXComputedObjectAttributeCache
​https://bugs.webkit.org/show_bug.cgi?id=124404

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-11-19
Reviewed by Mario Sanchez Prada.

Convert OwnPtr/PassOwnPtr to std::unique_ptr.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):

  • accessibility/AXObjectCache.h:

(WebCore::AXComputedObjectAttributeCache::AXComputedObjectAttributeCache):

6:01 AM Changeset in webkit [159499] by Csaba Osztrogonác
  • 275 edits in trunk

Unreviewed typo fix after r159494.

5:15 AM Changeset in webkit [159498] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Yet another build fix. Just allow any character.
There are just too many special characters to be listed here.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest._lines_to_ignore_in_parser_result):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTest.test_parse_output_with_subtests)

5:05 AM Changeset in webkit [159497] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Another build fix. Allow ':' in subtest names.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest._lines_to_ignore_in_parser_result):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTest.test_parse_output_with_subtests)

4:38 AM Changeset in webkit [159496] by ryuan.choi@samsung.com
  • 4 edits in trunk

[EFL] Use Config mode of find_package for EFL 1.8
​https://bugs.webkit.org/show_bug.cgi?id=124555

Reviewed by Gyuyoung Kim.

.:

EFL 1.8 changed VERSION macro so it's difficult to use tricky approach
which parses header file to know the version. Instead, EFL 1.8 supports
Config mode of find_package using XXXConfig.cmake such as EinaConfig.cmake.

This patch tries to use Config mode if it is available after checking Eo.

  • Source/cmake/OptionsEfl.cmake:

Tools:

  • MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.
4:22 AM Changeset in webkit [159495] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Build fix. Subtest names need to be more permissive.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest._lines_to_ignore_in_parser_result):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTest.test_parse_output_with_subtests)

4:14 AM Changeset in webkit [159494] by Csaba Osztrogonác
  • 275 edits in trunk

Unreviewed. Set svn:eol-style=native for Windows project files.

3:45 AM Changeset in webkit [159493] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Adding a crash expectation.

  • platform/efl/TestExpectations:
3:30 AM Changeset in webkit [159492] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Adding a crash expectation for a test regarding
object-fit.

  • platform/efl/TestExpectations:
3:12 AM BuildingGtk edited by tomeu.vizoso@collabora.com
(diff)
3:08 AM Changeset in webkit [159491] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. descent-clip-in-scaled-page.html is being passed
after enabling subpixel layout on EFL port.

  • platform/efl/TestExpectations:
2:37 AM Changeset in webkit [159490] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Adding failure expectations for the remaining layout test failures.

  • platform/gtk/TestExpectations:
1:43 AM Changeset in webkit [159489] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Add more assertions with security implications in DocumentOrderedMap
​https://bugs.webkit.org/show_bug.cgi?id=124559

Reviewed by Antti Koivisto.

Assert that newly added elements and existing elements in the document ordered map are in the same tree scope
as the document ordered map. Also exit early if we're about to add an element in a wrong document to the map.
We don't exit early in get() because the damage has already been done at that point (the element may have been
deleted already).

  • dom/Document.cpp:

(WebCore::Document::addImageElementByLowercasedUsemap):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::add): Assert that the newly added element is in the current tree scope.
Also exit early if either the element is not in the tree scope or not in the right document.
While this doesn't make the function completely fault safe, it'll catch when we try to add a detached node.
(WebCore::DocumentOrderedMap::remove): Convert existing assertions to ones with security implication.
(WebCore::DocumentOrderedMap::get): Assert with security implication that the element we're about to return
is in the current tree scope. The element may have already been deleted if we ever hit these assertions.
(WebCore::DocumentOrderedMap::getAllElementsById): Convert an existing assertion to an assertion with security
implication.

  • dom/DocumentOrderedMap.h:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::addElementById):
(WebCore::TreeScope::addElementByName):
(WebCore::TreeScope::addImageMap):
(WebCore::TreeScope::addLabel):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::addDocumentNamedItem):
(WebCore::HTMLDocument::addWindowNamedItem):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::insertedInto): Set InTreeScope flag before calling addImageElementByLowercasedUsemap.

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::insertedInto): Ditto for addImageMap.

1:28 AM Changeset in webkit [159488] by Manuel Rego Casasnovas
  • 3 edits
    1 add in trunk/PerformanceTests

[CSS Regions] Add performance test for selection
​https://bugs.webkit.org/show_bug.cgi?id=119230

Reviewed by Ryosuke Niwa.

Add new performance test for selection in CSS Regions. It checks a
selection from the first region to the last one, passing through all the
regions.

Test is skipped for now while implementation of selection in CSS Regions
is still evolving.

  • Layout/RegionsSelection.html: Added.
  • Layout/resources/regions.js:

(.):

  • Skipped:
Note: See TracTimeline for information about the timeline view.