Timeline
Nov 25, 2013:
- 9:54 PM Changeset in webkit [159779] by
-
- 17 edits in trunk/Source/WebCore
Convert some Shape code to use references
https://bugs.webkit.org/show_bug.cgi?id=124876
Reviewed by Andreas Kling.
- inspector/InspectorOverlay.cpp:
- rendering/FloatingObjects.cpp:
- rendering/LayoutState.cpp:
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderBox.h:
- rendering/line/BreakingContextInlineHeaders.h:
- rendering/line/LineWidth.cpp:
- rendering/shapes/ShapeInfo.cpp:
- rendering/shapes/ShapeInfo.h:
- rendering/shapes/ShapeInsideInfo.cpp:
- rendering/shapes/ShapeInsideInfo.h:
- rendering/shapes/ShapeOutsideInfo.cpp:
- rendering/shapes/ShapeOutsideInfo.h:
Replace yet more pointers with references.
- 9:46 PM Changeset in webkit [159778] by
-
- 2 edits in trunk
[EFL] E_DBus should be an optional
https://bugs.webkit.org/show_bug.cgi?id=124881
Reviewed by Gyuyoung Kim.
- Source/cmake/OptionsEfl.cmake:
Checked E_DBus when only ENABLE_BATTERY_STATUS is on.
- 6:21 PM Changeset in webkit [159777] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: [CSS Regions] A page with many flows should collapse the resources tree
https://bugs.webkit.org/show_bug.cgi?id=122926
Reviewed by Timothy Hatcher.
Refactored the code in FrameTreeElement._shouldGroupIntoFolders to make it easy to track
more types of resources. Added the content flows as another type of resource that would trigger the
collapsing.
- UserInterface/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype.namedFlowRemoved): Added code to remove the content nodes from
a flow that has been removed.
- UserInterface/FrameTreeElement.js:
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushCategory):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushResourceType):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders):
- 6:16 PM Changeset in webkit [159776] by
-
- 4 edits1 delete in trunk
[EFL] Use Config mode of find_package for EFL 1.8
https://bugs.webkit.org/show_bug.cgi?id=124555
Reviewed by Gyuyoung Kim.
.:
EFL 1.8 changed VERSION macro so it's difficult to use tricky approach
which parses header files to know the version. Instead, EFL 1.8 supports
FooConfig.cmake such as EinaConfig.cmake.
This patch tries to use a config mode if it is available.
If config mode is not available with Eo, FindFoo.cmake will be used without
version requirement.
- Source/cmake/FindEo.cmake: Removed.
EoConfig.cmake is only preffered for EFL 1.8.
- Source/cmake/OptionsEfl.cmake:
Tools:
- MiniBrowser/efl/CMakeLists.txt:
Added optional config mode and made version requirement optional.
- 4:47 PM Changeset in webkit [159775] by
-
- 7 edits in trunk/Source/WebKit2
[Cocoa] Use class extensions for IPI
https://bugs.webkit.org/show_bug.cgi?id=124870
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKBrowsingContextController.mm: Reordered methods so that the Private
cateogry isn’t stuck between the API methods and the internal methods.
(-[WKBrowsingContextController setPaginationMode:]):
(-[WKBrowsingContextController paginationMode]):
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]):
(-[WKBrowsingContextController paginationBehavesLikeColumns]):
(-[WKBrowsingContextController setPageLength:]):
(-[WKBrowsingContextController pageLength]):
(-[WKBrowsingContextController setGapBetweenPages:]):
(-[WKBrowsingContextController gapBetweenPages]):
(-[WKBrowsingContextController pageCount]):
(-[WKBrowsingContextController handle]):
- UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Changed Internal category into
a class extension.
- UIProcess/API/mac/WKConnection.mm:
- UIProcess/API/mac/WKConnectionInternal.h: Changed Internal category into a class
extension.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h: Ditto.
- 4:21 PM Changeset in webkit [159774] by
-
- 2 edits in trunk/Tools
[GTK] Search functionality in MiniBrowser provides feedback on search fail
https://bugs.webkit.org/show_bug.cgi?id=122681
Patch by Andres Gomez <Andres Gomez> on 2013-11-25
Reviewed by Mario Sanchez Prada.
When using the search functionality in MiniBrowser, if the search
fails, the entry background color gets red to report the user
about the failing condition. When the entry is cleaned or the
search is again succesful the background turns back to its
original color.
- MiniBrowser/gtk/BrowserSearchBar.c:
(setFailedStyleForEntry): Added.
(doSearch): Sets the entry's background to its original style if
there is no text to search.
(findControllerFailedToFindTextCallback): Added.
(findControllerFoundTextCallback): Added.
(browser_search_bar_init): Creates and adds a new CSS provider to
the text entry so we can change its style based on the success
condition of the search.
(browserSearchBarFinalize): Frees the new CSS provider.
(browser_search_bar_new): Connects the two new handlers to the
"failed-to-find-text" and "found-text" signals emitted by the
WebKitFindController.
- 4:20 PM Changeset in webkit [159773] by
-
- 2 edits in trunk/Source/WebKit2
Fixed the iOS build.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadDelegateInternal]):
(-[WKBrowsingContextController setLoadDelegateInternal:]):
- 3:55 PM Changeset in webkit [159772] by
-
- 2 edits in trunk/Source/WebCore
[EFL] X11Helper::createPixmap doesn't initialise out value handleId
https://bugs.webkit.org/show_bug.cgi?id=124722
Reviewed by Gyuyoung Kim.
The overloaded functions X11Helper::createPixmap don't initialise out
value handleId, and they do early returns on error situations. Since
the functions are void and they don't communicate their failure in any
way, returning an out value without initialising it could make the
error go farther unnoticed. With the variable being initialised, it can
be reliably checked for errors when the function returns.
- platform/graphics/surfaces/glx/X11Helper.cpp:
(WebCore::X11Helper::createPixmap): Initialise handleId to 0.
- 3:50 PM Changeset in webkit [159771] by
-
- 7 edits in trunk/Source/WebCore
Mark URLRegistry's lookup() as const and its child classes as final
https://bugs.webkit.org/show_bug.cgi?id=124865
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.
No new tests needed. No behavior changes.
- Modules/mediasource/MediaSourceRegistry.cpp:
(WebCore::MediaSourceRegistry::lookup): marked as const.
- Modules/mediasource/MediaSourceRegistry.h: MediaSourceRegistry
marked as final.
- Modules/mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::lookup): marked as const.
- Modules/mediastream/MediaStreamRegistry.h: MediaStreamRegistry
marked as final.
- fileapi/Blob.cpp:
- html/URLRegistry.h: lookup() marked as const.
(WebCore::URLRegistry::lookup): marked as const.
- 3:50 PM Changeset in webkit [159770] by
-
- 9 edits in trunk/Source/WebKit2
[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime
https://bugs.webkit.org/show_bug.cgi?id=123065
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKBrowsingContextController.h: Removed _data ivar and
WKBrowsingContextControllerData class declaration.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController dealloc]): Removed
WKBrowsingContextControllerData class and moved ivars directly into
WKBrowsingContextController, declaring them in the @implementation. Removed ivar and
accessors for the delegate properties, letting the compiler synthesize them.
(-[WKBrowsingContextController _pageRef]): Removed indirection via _data.
(-[WKBrowsingContextController loadRequest:userData:]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]): Ditto.
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController stopLoading]): Ditto.
(-[WKBrowsingContextController reload]): Ditto.
(-[WKBrowsingContextController reloadFromOrigin]): Ditto.
(-[WKBrowsingContextController goForward]): Ditto.
(-[WKBrowsingContextController canGoForward]): Ditto.
(-[WKBrowsingContextController goBack]): Ditto.
(-[WKBrowsingContextController canGoBack]): Ditto.
(-[WKBrowsingContextController goToBackForwardListItem:]): Ditto.
(-[WKBrowsingContextController backForwardList]): Ditto.
(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController unreachableURL]): Removed idirection via _data.
(-[WKBrowsingContextController estimatedProgress]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController title]): Ditto.
(-[WKBrowsingContextController textZoom]): Ditto.
(-[WKBrowsingContextController setTextZoom:]): Ditto.
(-[WKBrowsingContextController pageZoom]): Ditto.
(-[WKBrowsingContextController setPageZoom:]): Ditto.
(-[WKBrowsingContextController setPaginationMode:]): Ditto.
(-[WKBrowsingContextController paginationMode]): Ditto.
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): Ditto.
(-[WKBrowsingContextController paginationBehavesLikeColumns]): Ditto.
(-[WKBrowsingContextController setPageLength:]): Ditto.
(-[WKBrowsingContextController pageLength]): Ditto.
(-[WKBrowsingContextController setGapBetweenPages:]): Ditto.
(-[WKBrowsingContextController gapBetweenPages]): Ditto.
(-[WKBrowsingContextController pageCount]): Ditto.
(-[WKBrowsingContextController handle]): Ditto.
(-[WKBrowsingContextController _initWithPageRef:]): Removed indirection via _data.
- UIProcess/API/mac/WKBrowsingContextGroup.h: Removed _data ivar and
WKBrowsingContextGroupData class declaration.
- UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed WKBrowsingContextGroupData class and
moved _pageGroupRef ivar directly into WKBrowsingContextGroup, declaring it in the
@implementation.
(-[WKBrowsingContextGroup initWithIdentifier:]): Removed indirection via _data.
(-[WKBrowsingContextGroup allowsJavaScript]): Removed indirection via -_pageGroupRef.
(-[WKBrowsingContextGroup setAllowsJavaScript:]): Ditto.
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]): Ditto.
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]): Ditto.
(-[WKBrowsingContextGroup allowsPlugIns]): Ditto.
(-[WKBrowsingContextGroup setAllowsPlugIns:]): Ditto.
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup removeAllUserStyleSheets]): Ditto.
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup removeAllUserScripts]): Ditto.
(-[WKBrowsingContextGroup _pageGroupRef]): Removed indirection via _data.
- UIProcess/API/mac/WKConnection.h: Removed _data ivar and WKConnectionData class declaration.
- UIProcess/API/mac/WKConnection.mm: Removed WKConnectionData class and moved _connectionRef
ivar directly into WKConnection, declaring it in the @implementation. Removed ivar and
accessors for the delegate property, letting the compiler synthesize them.
(-[WKConnection dealloc]): Removed indirection via _data.
(-[WKConnection sendMessageWithName:body:]): Ditto.
(-[WKConnection remoteObjectRegistry]): Ditto.
(didReceiveMessage): Ditto.
(-[WKConnection _initWithConnectionRef:]): Ditto.
- UIProcess/API/mac/WKProcessGroup.h: Replaced forward declaration of WKConnection with an
import. Removed _data ivar and WKProcessGroupData class declaration.
- UIProcess/API/mac/WKProcessGroup.mm: Removed WKProcessGroupData class and moved
_contextRef ivar directly into WKProcessGroup, declaring it in the @implementation. Removed
ivar and accessors for the delegate property, letting the compiler synthesize them.
(-[WKProcessGroup initWithInjectedBundleURL:]): Removed indirection via _data.
(-[WKProcessGroup dealloc]): Ditto.
(-[WKProcessGroup _contextRef]): Ditto.
(-[WKProcessGroup _geolocationProvider]): Ditto.
- 3:21 PM Changeset in webkit [159769] by
-
- 14 edits in trunk/Source/WebCore
[MediaStream] Use std::unique_ptr instead of OwnPtr/PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=124858
Patch by Sergio Correia <Sergio Correia> on 2013-11-25
Reviewed by Eric Carlson.
Another step of the OwnPtr/PassOwnPtr => std::unique_ptr conversion,
now targeting mediastream-related code.
No new tests, covered by existing ones.
- Modules/mediastream/RTCDTMFSender.cpp:
- Modules/mediastream/RTCDTMFSender.h:
- Modules/mediastream/RTCDataChannel.cpp:
- Modules/mediastream/RTCDataChannel.h:
- Modules/mediastream/RTCPeerConnection.cpp:
- Modules/mediastream/RTCPeerConnection.h:
- platform/mediastream/MediaStreamSource.cpp:
- platform/mediastream/RTCPeerConnectionHandler.cpp:
- platform/mediastream/RTCPeerConnectionHandler.h:
- platform/mediastream/RTCPeerConnectionHandlerClient.h:
- platform/mock/RTCNotifiersMock.cpp:
- platform/mock/RTCPeerConnectionHandlerMock.cpp:
- platform/mock/RTCPeerConnectionHandlerMock.h:
- 3:08 PM Changeset in webkit [159768] by
-
- 5 edits1 add in trunk/Source/WebKit
[Win] WebKit version in user agent string is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=124454
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-25
Reviewed by Brent Fulgham.
Source/WebKit:
Generate WebKitVersion.h file from mac's Version.xcconfig file.
- WebKit.vcxproj/WebKit/WebKit.vcxproj:
- WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
- WebKit.vcxproj/WebKit/WebKitVersion.cmd: Added.
Source/WebKit/win:
- WebView.cpp: Use WebKit version from WebKitVersion.h in user agent.
(webKitVersionString):
- 2:55 PM Changeset in webkit [159767] by
-
- 4 edits in trunk/Source/WebCore
MediaStreamRegistry should store MediaStreams instead of MediaStreamPrivates
https://bugs.webkit.org/show_bug.cgi?id=124860
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.
MediaStreamRegistry::lookup() should return a MediaStream instead of MediaStreamPrivate.
No new tests needed. No behavior changes.
- Modules/mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::registerURL): m_privateStreams -> m_mediaStreams
(WebCore::MediaStreamRegistry::unregisterURL): Ditto.
(WebCore::MediaStreamRegistry::lookup): Override URLRegistry::lookup() instead of add a
new method MediaStream::lookupMediaStreamPrivate().
- Modules/mediastream/MediaStreamRegistry.h:
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::loadResource): call lookup() instead of lookupMediaStreamPrivate()
- 2:08 PM Changeset in webkit [159766] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile fails when GSTREAMER is not used.
https://bugs.webkit.org/show_bug.cgi?id=124853
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-25
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/GStreamerUtilities.cpp: Don't include GStreamerUtilities.h when GSTREAMER is not used.
- 2:02 PM Changeset in webkit [159765] by
-
- 21 edits in trunk/Source/WebKit2
Unreviewed, rolling out r159740.
http://trac.webkit.org/changeset/159740
https://bugs.webkit.org/show_bug.cgi?id=124859
Crashing xmlhttprequest/access-control-repeated-failed-
preflight-crash.html on Mavericks and Mountain Lion -
ASSERT(m_pageGroup) WebPage.cpp:352 (Requested by dino_ on
#webkit).
- Scripts/webkit2/messages.py:
(struct_or_class):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- Shared/mac/ObjCObjectGraphCoders.h:
- Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::ObjCObjectGraphEncoder::baseEncode):
(WebKit::WebContextObjCObjectGraphEncoderImpl::WebContextObjCObjectGraphEncoderImpl):
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode):
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):
(WebKit::WebContextObjCObjectGraphEncoder::WebContextObjCObjectGraphEncoder):
(WebKit::WebContextObjCObjectGraphEncoder::encode):
- UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::encodeMessageBody):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
- UIProcess/WebPageGroup.cpp:
- UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::postMessageToInjectedBundle):
(WebKit::WebPageProxy::initializeCreationParameters):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::createWebPage):
- UIProcess/WebProcessProxy.h:
- WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webPageGroup):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 1:53 PM Changeset in webkit [159764] by
-
- 3 edits in trunk/Source/WebCore
Deduplicate shortish Text node strings during tree construction.
<https://webkit.org/b/124855>
Let HTMLConstructionSite keep a hash set of already seen strings over
its lifetime. Use this to deduplicate the strings inside Text nodes
for any string up to 64 characters of length.
This optimization already sort-of existed for whitespace-only Texts,
but those are laundered in the AtomicString table which we definitely
don't want to pollute with every single Text. It might be a good idea
to stop using the AtomicString table for all-whitespace Text too.
3.82 MB progression on HTML5-8266 locally.
Reviewed by Anders Carlsson.
- 1:36 PM Changeset in webkit [159763] by
-
- 2 edits in trunk/LayoutTests
RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857
Skipping these tests for now, since Ossy + Laszlo checked
in a lot of rebaselines and I didn't want to roll
everything out.
- 1:29 PM Changeset in webkit [159762] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary MediaStreamTrackDescriptor forward declaration
https://bugs.webkit.org/show_bug.cgi?id=124854
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.
No new tests needed. No behavior changed.
- Modules/mediastream/VideoStreamTrack.h:
- 12:53 PM Changeset in webkit [159761] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Fixed a typo in the change log.
- 12:52 PM Changeset in webkit [159760] by
-
- 52 edits in trunk
[Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
https://bugs.webkit.org/show_bug.cgi?id=124850
Reviewed by Brady Eidson.
Source/WebKit2:
Guarded all Cocoa API headers and implementatiosn with WK_API_ENABLED. Left the WKView class
unguarded, but limited its API.
- Shared/API/Cocoa/WKFoundation.h: Replaced OBJ_VISIBLE with an explicit attribute.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm: Moved #if WK_API_ENABLED before the rest of the
imports.
- Shared/API/Cocoa/WKRemoteObjectInterface.mm: Ditto.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm: Ditto.
- Shared/API/Cocoa/WKRemoteObjectRegistryPrivate.h: Ditto.
- UIProcess/API/mac/WKBrowsingContextController.h: Guarded all declarations with
WK_API_ENABLED, changed to use WK_API_CLASS instead of WK_EXPORT.
- UIProcess/API/mac/WKBrowsingContextController.mm: Guarded everything with WK_API_ENABLED.
(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController backForwardList]):
(didChangeBackForwardList):
(setUpPageLoaderClient):
(setUpPagePolicyClient):
(-[WKBrowsingContextController _initWithPageRef:]):
- UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Ditto.
- UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Ditto.
- UIProcess/API/mac/WKBrowsingContextGroup.h: Guarded all declarations with WK_API_ENABLED,
chanegd to use WK_API_CLASS instead of WK_EXPORT.
- UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed redundant import, guarded everything
with WK_API_ENABLED.
- UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Guarded with WK_API_ENABLED.
- UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Added necessary import.
- UIProcess/API/mac/WKConnection.h: Guarded all declarations with WK_API_ENABLED, chanegd to
use WK_API_CLASS instead of WK_EXPORT.
- UIProcess/API/mac/WKConnection.mm: Guarded everything with WK_API_ENABLED.
(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):
- UIProcess/API/mac/WKConnectionInternal.h: Guarded the delcarations with WK_API_ENABLED.
- UIProcess/API/mac/WKProcessGroup.h: Ditto. Also changed to use WK_API_CLASS instead of
WK_EXPORT.
- UIProcess/API/mac/WKProcessGroup.mm: Guarded everything with WK_API_ENABLED.
(-[WKProcessGroup initWithInjectedBundleURL:]):
- UIProcess/API/mac/WKProcessGroupPrivate.h: Guarded the declarations with WK_API_ENABLED.
- UIProcess/API/mac/WKTypeRefWrapper.h: Moved #if WK_API_ENABLED before the rest of the
imports, changed to use WK_API_CLASS instead of WK_EXPORT.
- UIProcess/API/mac/WKTypeRefWrapper.mm: Removed empty line after #import "config.h".
- UIProcess/API/mac/WKView.h: Added #if WK_API_ENABLED around API that uses other Cocoa API
types.
- UIProcess/API/mac/WKView.mm: Added #if WK_API_ENABLED around implementations of methods
that are only declared when the API is enabled.
- UIProcess/API/mac/WKViewInternal.h: Reordered imports.
- UIProcess/mac/WKFullScreenWindowController.mm: Added comment to #endif.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess): Guarded use of
WKBrowsingContextController with WK_API_ENABLED.
(WebKit::WebContext::platformInitializeNetworkProcess): Ditto.
- UIProcess/mac/WebContextMenuProxyMac.mm: Removed newline between imports.
- WebProcess/InjectedBundle/API/mac/WKDOMDocument.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
- WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm: Removed newline after #import
"config.h".
- WebProcess/InjectedBundle/API/mac/WKDOMElement.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
- WebProcess/InjectedBundle/API/mac/WKDOMElement.mm: Removed newline after #import
"config.h".
- WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm: Ditto.
- WebProcess/InjectedBundle/API/mac/WKDOMNode.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
- WebProcess/InjectedBundle/API/mac/WKDOMNode.mm: Removed redundant import.
- WebProcess/InjectedBundle/API/mac/WKDOMRange.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
- WebProcess/InjectedBundle/API/mac/WKDOMRange.mm: Removed newline and redundant import.
- WebProcess/InjectedBundle/API/mac/WKDOMText.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
- WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h: Ditto.
- WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm: Removed newline after
#import "config.h".
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h: Moved #if WK_API_ENABLED before
the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm: Removed newline and redundant
imports.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h: Moved #if
WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of
WK_EXPORT.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: Removed
newline after #import "config.h".
Tools:
Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
- TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
- TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
- TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
- TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
- TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
- 11:10 AM Changeset in webkit [159759] by
-
- 2 edits in trunk/Source/WebInspectorUI
Set the svn:ignore property on the Xcode project to ignore the workspace and user data.
- WebInspectorUI.xcodeproj: Added property svn:ignore.
- 10:50 AM Changeset in webkit [159758] by
-
- 2 edits in trunk/Source/WebCore
Remove code now unnecessary after r159575
https://bugs.webkit.org/show_bug.cgi?id=124809
Reviewed by Antti Koivisto.
Covered by existing tests fast/block/margin-collapse/self-collapsing-block-with-float*
- rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::skipLeadingWhitespace):
- 10:46 AM Changeset in webkit [159757] by
-
- 1 edit2 adds in trunk/LayoutTests
Add complex line layout path version of empty-clear-blocks.html
https://bugs.webkit.org/show_bug.cgi?id=124808
Reviewed by Sam Weinig.
- fast/block/margin-collapse/empty-clear-blocks-complex-expected.html: Added.
- fast/block/margin-collapse/empty-clear-blocks-complex.html: Added.
- 10:41 AM Changeset in webkit [159756] by
-
- 3 edits1 add in trunk/Tools
Unreviewed, rolling out r159752 and r159754.
http://trac.webkit.org/changeset/159752
http://trac.webkit.org/changeset/159754
https://bugs.webkit.org/show_bug.cgi?id=124847
Broke linux test bots. (Requested by mhahnenberg on #webkit).
- Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
- Scripts/run-javascriptcore-tests:
- Scripts/run-jsc-stress-tests:
- 10:24 AM Changeset in webkit [159755] by
-
- 20 edits in trunk/LayoutTests
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.
Rebaseline the rest of EFL and GTK tests.
- platform/efl/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug26178-expected.txt:
- platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug278385-expected.txt:
- platform/efl/tables/mozilla/bugs/bug55789-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
- 10:02 AM Changeset in webkit [159754] by
-
- 2 edits in trunk/Tools
Followup fix after r159752
- Scripts/run-jsc-stress-tests: We need to handle Release builds too.
- 9:34 AM Changeset in webkit [159753] by
-
- 265 edits1 add in trunk/LayoutTests
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.
Rebaseline efl tests (+mac corrections).
- platform/efl/fast/forms/input-align-expected.png:
- platform/efl/fast/forms/input-align-expected.txt:
- platform/efl/fast/forms/input-value-expected.png:
- platform/efl/fast/forms/input-value-expected.txt:
- platform/efl/fast/table/border-collapsing/004-vertical-expected.png:
- platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/efl/fast/table/floating-th-expected.png:
- platform/efl/fast/table/floating-th-expected.txt:
- platform/efl/fast/table/frame-and-rules-expected.png:
- platform/efl/fast/table/frame-and-rules-expected.txt:
- platform/efl/fast/table/multiple-captions-display-expected.png:
- platform/efl/fast/table/multiple-captions-display-expected.txt:
- platform/efl/fast/table/rowindex-expected.png:
- platform/efl/fast/table/rowindex-expected.txt:
- platform/efl/fast/table/table-display-types-expected.png:
- platform/efl/fast/table/table-display-types-expected.txt:
- platform/efl/fast/table/table-display-types-strict-expected.png:
- platform/efl/fast/table/table-display-types-strict-expected.txt:
- platform/efl/fast/table/table-display-types-vertical-expected.png:
- platform/efl/fast/table/table-display-types-vertical-expected.txt:
- platform/efl/tables/mozilla/bugs/bug119786-expected.png:
- platform/efl/tables/mozilla/bugs/bug119786-expected.txt:
- platform/efl/tables/mozilla/bugs/bug13118-expected.png:
- platform/efl/tables/mozilla/bugs/bug13118-expected.txt:
- platform/efl/tables/mozilla/bugs/bug19061-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug19061-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug220536-expected.png:
- platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
- platform/efl/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug27038-3-expected.png:
- platform/efl/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug30418-expected.png:
- platform/efl/tables/mozilla/bugs/bug30418-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3263-expected.png:
- platform/efl/tables/mozilla/bugs/bug3263-expected.txt:
- platform/efl/tables/mozilla/bugs/bug38916-expected.png:
- platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46268-3-expected.png:
- platform/efl/tables/mozilla/bugs/bug46268-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46268-5-expected.png:
- platform/efl/tables/mozilla/bugs/bug46268-5-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46268-expected.png:
- platform/efl/tables/mozilla/bugs/bug46268-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46924-expected.png:
- platform/efl/tables/mozilla/bugs/bug46924-expected.txt:
- platform/efl/tables/mozilla/bugs/bug57378-expected.png:
- platform/efl/tables/mozilla/bugs/bug57378-expected.txt:
- platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.png:
- platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_position-table-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/efl/tables/mozilla/marvin/body_tfoot-expected.png:
- platform/efl/tables/mozilla/marvin/body_tfoot-expected.txt:
- platform/efl/tables/mozilla/marvin/body_thead-expected.png:
- platform/efl/tables/mozilla/marvin/body_thead-expected.txt:
- platform/efl/tables/mozilla/marvin/table_rules_groups-expected.png:
- platform/efl/tables/mozilla/marvin/table_rules_groups-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_char-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_char-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_char-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_char-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/thead_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/thead_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/thead_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/thead_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/thead_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_char-expected.png:
- platform/efl/tables/mozilla/marvin/thead_char-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table-expected.png:
- platform/efl/tables/mozilla/marvin/x_table-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_border-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_border-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_border_none-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_border_none-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_border_px-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_border_px-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.png:
- platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_class-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_class-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_id-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_id-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_style-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_style-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.png:
- platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
- platform/mac-mountainlion/fast/forms/input-value-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:
- platform/mac/fast/forms/input-value-expected.txt:
- 9:29 AM Changeset in webkit [159752] by
-
- 3 edits1 delete in trunk/Tools
run-jsc-stress-tests should be able to package its tests and move them places
https://bugs.webkit.org/show_bug.cgi?id=124549
Reviewed by Filip Pizlo.
- Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
of grep -i -q
- Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
- Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
We now also copy whatever VM was specified, along with its associated framework, into this directory.
All of the generated scripts now are completely relative within the results directory. This allows
run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
tarball of the generated results directory. Also refactored several portions of the script into
separate functions to make it easier to run them conditionally depending on which mode we're running in.
- 9:02 AM Changeset in webkit [159751] by
-
- 271 edits1 add in trunk/LayoutTests
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.
Rebase GTK results after r159747.
- platform/gtk/fast/forms/input-value-expected.png:
- platform/gtk/fast/forms/input-value-expected.txt:
- platform/gtk/fast/table/011-expected.txt:
- platform/gtk/fast/table/border-collapsing/004-expected.txt:
- platform/gtk/fast/table/border-collapsing/004-vertical-expected.png:
- platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/gtk/fast/table/floating-th-expected.png:
- platform/gtk/fast/table/floating-th-expected.txt:
- platform/gtk/fast/table/frame-and-rules-expected.png:
- platform/gtk/fast/table/frame-and-rules-expected.txt:
- platform/gtk/fast/table/rowindex-expected.png:
- platform/gtk/fast/table/rowindex-expected.txt:
- platform/gtk/fast/table/table-display-types-expected.png:
- platform/gtk/fast/table/table-display-types-expected.txt:
- platform/gtk/fast/table/table-display-types-strict-expected.png:
- platform/gtk/fast/table/table-display-types-strict-expected.txt:
- platform/gtk/fast/table/table-display-types-vertical-expected.png:
- platform/gtk/fast/table/table-display-types-vertical-expected.txt:
- platform/gtk/fast/table/tableInsideCaption-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug119786-expected.png:
- platform/gtk/tables/mozilla/bugs/bug119786-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug13118-expected.png:
- platform/gtk/tables/mozilla/bugs/bug13118-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug19061-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug19061-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug220536-expected.png:
- platform/gtk/tables/mozilla/bugs/bug220536-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
- platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug27038-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug27038-3-expected.png:
- platform/gtk/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
- platform/gtk/tables/mozilla/bugs/bug278385-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug30418-expected.png:
- platform/gtk/tables/mozilla/bugs/bug30418-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3263-expected.png:
- platform/gtk/tables/mozilla/bugs/bug3263-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug38916-expected.png:
- platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46268-3-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46268-3-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46268-5-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46268-5-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46268-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46268-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46924-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46924-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug55789-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug57378-expected.png:
- platform/gtk/tables/mozilla/bugs/bug57378-expected.txt:
- platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.png:
- platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/gtk/tables/mozilla/marvin/body_tfoot-expected.png:
- platform/gtk/tables/mozilla/marvin/body_tfoot-expected.txt:
- platform/gtk/tables/mozilla/marvin/body_thead-expected.png:
- platform/gtk/tables/mozilla/marvin/body_thead-expected.txt:
- platform/gtk/tables/mozilla/marvin/table_rules_groups-expected.png:
- platform/gtk/tables/mozilla/marvin/table_rules_groups-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_char-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_char-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_char-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_border-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_border-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
- 8:04 AM Changeset in webkit [159750] by
-
- 117 edits2 adds in trunk/LayoutTests
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.
Rebase Mac results after r159747.
- platform/mac/tables/mozilla/bugs/bug119786-expected.txt:
- platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug220536-expected.txt: Added.
- platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
- platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
- platform/mac/tables/mozilla/bugs/bug278385-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30418-expected.txt:
- platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46268-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46268-5-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46268-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46924-expected.txt:
- platform/mac/tables/mozilla/bugs/bug55789-expected.txt:
- platform/mac/tables/mozilla/bugs/bug57378-expected.txt:
- platform/mac/tables/mozilla/marvin/table_rules_groups-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_align_justify-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_char-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_char-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_align_justify-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_char-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_table-expected.txt:
- platform/mac/tables/mozilla/marvin/x_table_border-expected.txt:
- platform/mac/tables/mozilla/marvin/x_table_border_none-expected.txt:
- platform/mac/tables/mozilla/marvin/x_table_border_px-expected.txt:
- platform/mac/tables/mozilla/marvin/x_table_frame_void-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_class-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_id-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_style-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_class-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_id-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_style-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
- platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
- 7:48 AM Changeset in webkit [159749] by
-
- 4 edits in trunk/Tools
EWS creates 0 byte sized log files
https://bugs.webkit.org/show_bug.cgi?id=107606
Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-25
Reviewed by Ryosuke Niwa.
There was a modification in r138264, that tried to make less log,
because some of the messeges were duplicated. After this the EWS
created the log file (with the same name as the bugID) but doesn't
write anything into it, even if there were errors during the build.
From now only creates the log file only if there is some error.
- Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
there is nothing to log. Open the log file only if a ScriptError was raised to
avoid to make empty log files for bugs.
(QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
because of changes in r138264. Teeing is used for locally testing purposes and
this feature is not used anymore.
(QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
teeing anymore. It is a necessary change because of QueueEngine._open_work_log
change.
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(LoggingDelegate): The order of the callbacks was changed by this patch.
(QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
so we have to update this test.
(QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
this patch.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
to be able to handle it in QueueEngine.run. Without this change, the existing
exception handler never run (the process_work_item method never raise ScriptError)
We can get the error message only from the ScriptError at this point.
- 7:28 AM Changeset in webkit [159748] by
-
- 3 edits in trunk/Source/JavaScriptCore
[arm][mips] Fix crash in dfg-arrayify-elimination layout jsc test.
https://bugs.webkit.org/show_bug.cgi?id=124839
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-25
Reviewed by Michael Saboff.
In ARM EABI and MIPS, 64-bit values have to be aligned on stack too.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JITInlines.h:
(JSC::JIT::callOperation): Add missing EABI_32BIT_DUMMY_ARG.
- 6:57 AM Changeset in webkit [159747] by
-
- 33 edits in trunk
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.
Source/WebCore:
Based on Chromium fix https://chromium.googlesource.com/chromium/blink/+/eb615069267f895c59bc576f9d65b3fa5add41e9
Rebaseline needed for table related tests (100+).
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
LayoutTests:
First tuple of rebaselined tests for mac. Rebaseline needed for table related tests (100+).
- fast/table/anonymous-table-section-removed.html:
- platform/mac/accessibility/table-detection-expected.txt:
- platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/table/011-expected.txt:
- platform/mac/fast/table/border-collapsing/004-expected.txt:
- platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/mac/fast/table/floating-th-expected.txt:
- platform/mac/fast/table/frame-and-rules-expected.txt:
- platform/mac/fast/table/multiple-captions-display-expected.txt:
- platform/mac/fast/table/rowindex-expected.txt:
- platform/mac/fast/table/table-display-types-expected.txt:
- platform/mac/fast/table/table-display-types-strict-expected.txt:
- platform/mac/fast/table/table-display-types-vertical-expected.txt:
- platform/mac/fast/table/tableInsideCaption-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug13118-expected.txt:
- platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3263-expected.txt:
- platform/mac/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/mac/tables/mozilla/marvin/body_tfoot-expected.txt:
- platform/mac/tables/mozilla/marvin/body_thead-expected.txt:
- 6:03 AM Changeset in webkit [159746] by
-
- 6 edits2 adds in trunk
[GStreamer] Seeking fails on media content provided by servers not supporting Range requests
https://bugs.webkit.org/show_bug.cgi?id=85994
Patch by Andres Gomez <Andres Gomez> on 2013-11-25
Reviewed by Philippe Normand.
Source/WebCore:
Based on the patch written by Andre Moreira Magalhaes.
When the GStreamer web source was doing a "Range" request we were
expecting to receive a 206 status reply with the "Content-Range"
header and just the requested data. Supporting "Range" requests is
not mandatory so, for the servers not supporting it they will be
replying with a 200 status and the whole content of the media
element. Now, we are properly handling these replies too.
Test: http/tests/media/media-seeking-no-ranges-server.html
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::handleResponseReceived): Do not fail when
receiving 200 as response for HTTP range requests.
(StreamingClient::handleDataReceived): Manually seek on stream
when receiving the full data after a seek.
LayoutTests:
Added test to check that seeking media files on http servers not
supporting "Range" requests doesn't trigger an error.
- http/tests/media/media-seeking-no-ranges-server-expected.txt: Added.
- http/tests/media/media-seeking-no-ranges-server.html: Added.
- http/tests/media/resources/load-video.php: Added support for new
"ranges" paramenter.
- http/tests/media/resources/serve-video.php: Added support for
new "ranges" paramenter. When "ranges" is "no" we always answer
the HTTP status "200 OK" and send the whole file.
- platform/mac/TestExpectations: New test skipped in Mac port as
media playback download control is passed to AVFoundation that
doesn't like fancy PHP URLs like the one used in the test and, in
addition, they won't care about HTTP servers not supporting
"Range" requests.
- 4:14 AM Changeset in webkit [159745] by
-
- 2 edits in trunk/Source/WebCore
Removed obsolete FIXME after the landing of visual overflow patch (https://bugs.webkit.org/show_bug.cgi?id=118665).
https://bugs.webkit.org/show_bug.cgi?id=124833
Reviewed by Mihnea Ovidenie.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layoutBlock):
- 3:36 AM Changeset in webkit [159744] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening. Removed expectations for test that is no
longer failing for the GTK bots, according to the flakiness dashboard.
- platform/gtk-wk2/TestExpectations: Removed expectation.
- platform/gtk/TestExpectations: Ditto.
- 3:19 AM Changeset in webkit [159743] by
-
- 3 edits2 deletes in trunk/LayoutTests
Unreviewed GTK gardening.
Managing current failures and removing redundant baselines.
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- platform/gtk/fast/dom/gc-attribute-node-expected.txt: Removed.
- platform/gtk/fast/repaint/increasing-region-content-height-expected.txt: Removed.
- 1:52 AM Changeset in webkit [159742] by
-
- 3 edits in trunk/LayoutTests
[EFL] Need to update EFL TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=124825
Unreviewed, EFL gardening.
webgl/1.0.2/conformance/extensions/webgl-compressed-texture-s3tc.html
webgl/conformance/extensions/webgl-compressed-texture-s3tc.html
Above two tests are passed in Webkit2 layout test after r158798.
Patch by Jongwoo Choi <jw0330.choi@samsung.com> on 2013-11-25
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 12:22 AM Changeset in webkit [159741] by
-
- 3 edits in trunk/Source/WebCore
[CSS Grid Layout] Cache several vectors to avoid malloc/free churn
https://bugs.webkit.org/show_bug.cgi?id=123995
Reviewed by Dean Jackson.
From Blink r158228 by <jchaffraix@chromium.org>
Laying-out the grid items means a lot of calls to
distributeSpaceToTracks() and
resolveContentBasedTrackSizingFunctionsForItems() as they're
called in a loop. This means that there is a lot of malloc/free
going on there. By moving the vectors used by these methods to a
new class which is kept during the whole layout process we save a
lot of those calls.
This obviously mean that the price we pay for a significant
perfomance improvement is that we keep the maximum allocation till
the end of each layout, but it's an amount of memory that we have
to allocate anyway. The improvement in the
auto-grid-lots-of-data.html perf test is ~24% (165 runs/s vs 207
runs/s).
No new tests required as we're just refactoring code to a new
helper class. Nevertheless the performance improvement is backed
by the perf test mentioned above.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridSizingData::GridSizingData):
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::distributeSpaceToTracks):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::findChildLogicalPosition):
- rendering/RenderGrid.h:
Nov 24, 2013:
- 7:09 PM Changeset in webkit [159740] by
-
- 21 edits in trunk/Source/WebKit2
WebPageGroup's should keep track of what processes they are being used by
https://bugs.webkit.org/show_bug.cgi?id=124556
Reviewed by Dan Bernstein.
- Scripts/webkit2/messages.py:
(struct_or_class):
Mark WebPageGroupData as a struct.
- Shared/UserMessageCoders.h:
- Shared/mac/ObjCObjectGraphCoders.h:
- Shared/mac/ObjCObjectGraphCoders.mm:
- WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
- UIProcess/WebConnectionToWebProcess.cpp:
- UIProcess/WebContext.cpp:
- UIProcess/WebContextUserMessageCoders.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
Pass the WebProcess/WebProcessProxy to both encode and decode.
- Shared/WebPageCreationParameters.h:
Pass the page group by ID when creating a page, as it will have had its own
creation message sent already.
- UIProcess/WebPageGroup.cpp:
- UIProcess/WebPageGroup.h:
Keep track of processes.
- UIProcess/WebProcessProxy.cpp:
- UIProcess/WebProcessProxy.h:
Keep track of the page groups used by the process.
- WebProcess/WebPage/WebPage.cpp:
Get the already create page group on creation.
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
Explicitly create page groups in the WebProcess.
- 6:00 PM Changeset in webkit [159739] by
-
- 13 edits1 add in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining various tests under fast/
- platform/efl/fast/backgrounds/background-position-parsing-expected.png:
- platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
- platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
- platform/efl/fast/css/empty-pseudo-class-expected.png:
- platform/efl/fast/css/empty-pseudo-class-expected.txt:
- platform/efl/fast/css/fieldset-display-row-expected.txt:
- platform/efl/fast/css/first-child-pseudo-class-expected.png:
- platform/efl/fast/css/first-child-pseudo-class-expected.txt:
- platform/efl/fast/css/last-child-pseudo-class-expected.png:
- platform/efl/fast/css/last-child-pseudo-class-expected.txt:
- platform/efl/fast/css/only-child-pseudo-class-expected.png:
- platform/efl/fast/css/only-child-pseudo-class-expected.txt:
- 4:10 PM Changeset in webkit [159738] by
-
- 4 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r159579.
- platform/efl/css1/formatting_model/vertical_formatting-expected.txt:
- platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/efl/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
- 3:12 PM Changeset in webkit [159737] by
-
- 12 edits2 copies2 adds in trunk/Source
DatabaseProcess: Add "UniqueIDBDatabase" that multiple WebProcesses can connect to
https://bugs.webkit.org/show_bug.cgi?id=124819
Reviewed by Dan Bernstein.
Source/WebCore:
- Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::~IDBDatabaseBackend): Unregister from the IDBFactory.
Source/WebKit2:
UniqueIDBDatabase instances are per-DatabaseProcess, so it manages the set of them.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::getOrCreateUniqueIDBDatabase):
(WebKit::DatabaseProcess::removeUniqueIDBDatabase):
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/DatabaseToWebProcessConnection.h:
Start forwarding things along to the appropriate UniqueIDBDatabase.
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::~DatabaseProcessIDBConnection):
(WebKit::DatabaseProcessIDBConnection::disconnectedFromWebProcess):
(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
A class that represents a single concrete IDB database that multiple WebProcesses can connect to.
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::~UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::registerConnection):
(WebKit::UniqueIDBDatabase::unregisterConnection):
(WebKit::UniqueIDBDatabase::getIDBDatabaseMetadata):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
(WebKit::UniqueIDBDatabase::create):
(WebKit::UniqueIDBDatabase::identifier):
A class to help uniquely identify an IDBDatabase that can be expanded as needed.
Importantly, it knows how to be used as a key in a HashMap.
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.cpp: Added.
(WebKit::UniqueIDBDatabaseIdentifier::UniqueIDBDatabaseIdentifier):
(WebKit::UniqueIDBDatabaseIdentifier::isHashTableDeletedValue):
(WebKit::UniqueIDBDatabaseIdentifier::hash):
(WebKit::UniqueIDBDatabaseIdentifier::isNull):
(WebKit::operator==):
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.h: Added.
(WebKit::UniqueIDBDatabaseIdentifier::databaseName):
(WebKit::UniqueIDBDatabaseIdentifier::openingOrigin):
(WebKit::UniqueIDBDatabaseIdentifier::mainFrameOrigin):
(WebKit::UniqueIDBDatabaseIdentifierHash::hash):
(WebKit::UniqueIDBDatabaseIdentifierHash::equal):
(WebKit::UniqueIDBDatabaseIdentifierHashTraits::isEmptyValue):
- Shared/SecurityOriginData.cpp:
(WebKit::operator==):
- Shared/SecurityOriginData.h:
- UIProcess/WebContext.cpp:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::open):
(WebKit::WebIDBFactoryBackend::removeIDBDatabaseBackend):
- WebKit2.xcodeproj/project.pbxproj:
- 1:46 PM Changeset in webkit [159736] by
-
- 3 edits3 adds in trunk
Fix more fallout from failed attempts at div/mod DFG strength reductions
https://bugs.webkit.org/show_bug.cgi?id=124813
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMod):
LayoutTests:
- js/dfg-mod-1-int.html: Added.
- js/dfg-mod-1-int-expected.txt: Added.
- js/script-tests/dfg-mod-1-int.js: Added.
(foo):
- 11:14 AM Changeset in webkit [159735] by
-
- 2 edits in trunk/Source/WTF
Upstream USE(IOSURFACE) from the iOS port
https://bugs.webkit.org/show_bug.cgi?id=124814
Reviewed by Sam Weinig.
Some code guarded by USE(IOSURFACE) was recently upstreamed,
but not the definition of WTF_USE_IOSURFACE itself.
- wtf/Platform.h:
- 10:20 AM Changeset in webkit [159734] by
-
- 9 edits in trunk/Source/WebKit2
[WK2][GTK] Adding SpatialNavigation setting to webkit2
https://bugs.webkit.org/show_bug.cgi?id=114298
Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk>, Arunprasad Rajkumar <arurajku@cisco.com> on 2013-11-24
Reviewed by Anders Carlsson.
Adding SpatialNavigation support to WebPreferencesStore allows us
to toggle that feature on WebKitSettings.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSpatialNavigationEnabled):
(WKPreferencesGetSpatialNavigationEnabled):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_enable_spatial_navigation):
(webkit_settings_get_enable_spatial_navigation):
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 7:24 AM Changeset in webkit [159733] by
-
- 18 edits in trunk/Source/WebCore
Generate toHTMLMarquee|OListElement() to cleanup static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=124707
Reviewed by Darin Adler.
As a step to use toFoo(), we need to generate toHTMLMarquee|OListElement().
Besides this patch cleans up remaining static_cast<> usage.
No new tests, no behavior changes.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::initElement):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::findSiblingForStyleSharing):
- dom/Attr.cpp:
(WebCore::Attr::style):
- dom/Element.cpp:
(WebCore::Element::removeAttribute):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::wrappingStyleForSerialization):
- editing/Editor.cpp:
(WebCore::Editor::applyEditingStyleToElement):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
- html/HTMLMarqueeElement.h:
- html/HTMLOListElement.h:
- html/HTMLTagNames.in:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForElementInfo):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
- rendering/RenderCounter.cpp:
(WebCore::planCounter):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::updateListMarkerNumbers):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::marqueeSpeed):
- 12:34 AM Changeset in webkit [159732] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r156291): TileController tiles don't always repaint when they resize
https://bugs.webkit.org/show_bug.cgi?id=124796
Reviewed by Simon Fraser.
In removing platformCALayerDidCreateTiles, r156291 also removed
the call to setNeedsDisplay when tiles are resized, without
putting it somewhere else.
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::setNeedsDisplay):
Use hasStaleContent when invalidating a whole tile, just
like we do for partial tile repaints.
(WebCore::TileController::setTileNeedsDisplayInRect):
Mark hasStaleContent for any unparented layers, so they'll be painted
when they are reparented.
(WebCore::TileController::ensureTilesForRect):
Invalidate the whole tile when it changes size.
Nov 23, 2013:
- 8:20 AM Changeset in webkit [159731] by
-
- 2 edits in trunk/LayoutTests
Remove lint from expected result.
Unreviewed.
- platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
- 6:35 AM Changeset in webkit [159730] by
-
- 41 edits3 deletes in trunk
[GStreamer] Remove 0.10 codepath
https://bugs.webkit.org/show_bug.cgi?id=124534
Reviewed by Philippe Normand.
.:
- Source/cmake/OptionsEfl.cmake: Removed GST_API_VERSION_1
definition.
Source/WebCore:
All GStreamer ports are using 1.0 now so we remove the 0.10
codepath.
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters: Removed
GStreamerVersioning.
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(onGStreamerWavparsePadAddedCallback): Removed.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Replaced webkitGstPipelineGetBus and removed 0.10 codepath.
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
Replaced webkitGstPipelineGetBus.
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::copyGstreamerBuffersToAudioChannel):
(WebCore::onAppsinkPullRequiredCallback): Removed 0.10 codepath.
(WebCore::AudioFileReader::~AudioFileReader): Replaced
webkitGstPipelineGetBus and removed 0.10 codepath.
(WebCore::AudioFileReader::handleSample): Left as only codepath.
(WebCore::AudioFileReader::handleBuffer): Removed.
(WebCore::AudioFileReader::handleNewDeinterleavePad): Removed 0.10
codepath.
(WebCore::AudioFileReader::plugDeinterleave): Replaced
getGstAudioCaps.
(WebCore::AudioFileReader::decodeAudioForBusCreation): Replaced
webkitGstPipelineGetBus.
(WebCore::AudioFileReader::createBus): Removed 0.10 codepath.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(getGStreamerMonoAudioCaps):
(webKitWebAudioGStreamerChannelPosition): Removed 0.10 codepath.
(webkit_web_audio_src_class_init): Replaced
setGstElementClassMetadata.
(webkit_web_audio_src_init):
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcFinalize):
(webKitWebAudioSrcLoop): Removed 0.10 codepath.
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
Removed checks for 1.0 as it is the only codepath now.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::GstElement):
(WTF::GstPad):
(WTF::GstPadTemplate):
(WTF::GstTask):
(WTF::GstBus):
(WTF::GstElementFactory):
(WTF::adoptGRef): Replaced gstObjectIsFloating.
(WTF::refGRef): Replaced webkitGstObjectRefSink.
(WTF::GstTagList):
(WTF::GstSample): Removed checks for 1.0 as it is the only
codepath now.
- platform/graphics/gstreamer/GRefPtrGStreamer.h: Removed checks
for 1.0 as it is the only codepath now.
- platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::webkitGstGhostPadFromStaticTemplate):
(WebCore::getVideoSizeAndFormatFromCaps):
(WebCore::createGstBuffer):
(WebCore::createGstBufferForData):
(WebCore::getGstBufferDataPointer):
(WebCore::mapGstBuffer):
(WebCore::unmapGstBuffer): Moved here from GstVersioning and added
to WebCore namespace.
- platform/graphics/gstreamer/GStreamerUtilities.h:
(WebCore::webkitGstCheckVersion): Moved here from GstVersioning
and added to WebCore namespace.
- platform/graphics/gstreamer/GStreamerVersioning.cpp: Removed.
- platform/graphics/gstreamer/GStreamerVersioning.h: Removed.
- platform/graphics/gstreamer/ImageGStreamer.h: Removed checks for
1.0 as it is the only codepath now.
- platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer): Removed 0.10 codepath.
(ImageGStreamer::~ImageGStreamer): Removed checks for 1.0 as it is
the only codepath now.
- platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
Removed checks for 1.0 as it is the only codepath now.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::setAudioStreamPropertiesCallback): Removed 0.10 codepath.
(WebCore::mediaPlayerPrivateTextChangedCallback): Removed checks
for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::isAvailable): Replaced
gPlaybinName.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Removed checks for 1.0 and replaced webkitGstPipelineGetBus.
(WebCore::MediaPlayerPrivateGStreamer::duration): Removed 0.10
codepath.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
Removed checks for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::buffered): Replaced
gPercentMax.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Removed
0.10 codepath.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
Removed checks for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::totalBytes): Removed 0.10
codepath.
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Replaced
gPlaybinName and webkitGstPipelineGetBus and removed checks for
1.0.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
Removed checks for 1.0 as it is the only codepath now.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::paint): Removed 0.10
codepath.
- platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
- platform/graphics/gstreamer/TextCombinerGStreamer.h:
- platform/graphics/gstreamer/TextSinkGStreamer.cpp:
- platform/graphics/gstreamer/TextSinkGStreamer.h:
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Removed
checks for 1.0 as it is the only codepath now.
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender): Removed 0.10 codepath and added WebCore
as createGstBuffer namespace.
(webkitVideoSinkSetCaps): Removed 0.10 codepath.
(webkitVideoSinkProposeAllocation): Removed checks for 1.0 as it
is the only codepath now.
(webkitVideoSinkMarshalVoidAndMiniObject): Removed as it was 0.10.
(webkit_video_sink_class_init): Removed 0.10 codepath and replaced
setGstElementClassMetadata.
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
Removed checks for 1.0 as it is the only codepath now.
- platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
(webkit_media_src_class_init): Replaced
setGstElementClassMetadata.
(webKitMediaSrcAddSrc): Added WebCore namespace to
webkitGstGhostPadFromStaticTemplate.
(MediaSourceClientGstreamer::didReceiveData): Added WebCore
namespace to createGstBufferForData.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
Removed 0.10 codepath.
(webKitWebSrcQuery): Removed as it was 0.10 only.
(void webkit_web_src_class_init): Replaced setGstElementClassMetadata.
(webkit_web_src_init): Removed haveAppSrc27 private attribute and
0.10 codepath.
(webKitWebSrcStop): Removed checks for 1.0 as it is the only
codepath now.
(webKitWebSrcSetProperty):
(webKitWebSrcUriGetType):
(webKitWebSrcGetProtocols):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri): Removed 0.10 codepath.
(StreamingClient::createReadBuffer): Removed checks for 1.0 and
replaced getGstBufferSize.
(StreamingClient::handleResponseReceived): Removed 0.10 codepath
and replaced notifyGstTagsOnPad.
(StreamingClient::handleDataReceived): Removed 0.10 codepath and
replaced setGstBufferSize and gst_buffer_get_size.
Source/WebKit:
- PlatformEfl.cmake: Removed FullscreenVideoControllerEfl.cpp.
Source/WebKit/efl:
- WebCoreSupport/FullscreenVideoControllerEfl.cpp: Removed.
Source/WTF:
- wtf/Platform.h: Removed macro for GStreamer 1.0 as it is the
only codepath now.
- 3:05 AM Changeset in webkit [159729] by
-
- 2 edits in trunk/LayoutTests
Rebaseline empty-clear-blocks.html after r159575
Unreviewed, rebaselining.
- platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
Nov 22, 2013:
- 11:11 PM Changeset in webkit [159728] by
-
- 7 edits1 copy1 add in trunk/Source/WebKit2
Add DatabaseProcessCreationParameters, starting with the database path.
https://bugs.webkit.org/show_bug.cgi?id=124804
Reviewed by Dean Jackson and Benjamin Poulain.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::initializeDatabaseProcess):
- DatabaseProcess/DatabaseProcess.h:
(WebKit::DatabaseProcess::indexedDatabaseDirectory):
- DatabaseProcess/DatabaseProcess.messages.in:
- Shared/Databases/DatabaseProcessCreationParameters.cpp: Added.
(WebKit::DatabaseProcessCreationParameters::DatabaseProcessCreationParameters):
(WebKit::DatabaseProcessCreationParameters::encode):
(WebKit::DatabaseProcessCreationParameters::decode):
- Shared/Databases/DatabaseProcessCreationParameters.h: Added.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureDatabaseProcess):
- WebKit2.xcodeproj/project.pbxproj:
- Scripts/webkit2/messages.py:
(struct_or_class):
- 10:03 PM Changeset in webkit [159727] by
-
- 5 edits in trunk/Source/WebKit2
[EFL] Build break after r159724
https://bugs.webkit.org/show_bug.cgi?id=124806
Reviewed by Tim Horton.
- Platform/CoreIPC/Connection.h: Include atomic header.
- UIProcess/CoordinatedGraphics/WebView.cpp: Rename didChangeContentsSize to didChangeContentSize.
(WebKit::WebView::didChangeContentSize):
- UIProcess/CoordinatedGraphics/WebView.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h: Adjust TARGET_OS_IPHONE macro.
- 8:50 PM Changeset in webkit [159726] by
-
- 4 edits1 add1 delete in trunk
Layout Test editing/deleting/password-delete-performance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=124781
Reviewed by Alexey Proskuryakov.
PerformanceTests:
Add a new performance test to replace editing/deleting/password-delete-performance.html.
We skip this test by default since it's a micro benchmark.
- Interactive/DeletingInPasswordField.html: Added.
- Skipped:
LayoutTests:
Removed the test that has been timing out.
- TestExpectations:
- editing/deleting/password-delete-performance.html: Removed.
- 7:43 PM Changeset in webkit [159725] by
-
- 2 edits in trunk/Source/WebKit2
Attempt build fixes for 32-bit after 159724.
There's probably a better fix, but this will work for now.
- UIProcess/API/mac/WKView.h:
- 7:29 PM Changeset in webkit [159724] by
-
- 101 edits50 adds2 deletes in trunk/Source/WebKit2
Upstream iOS WebKit2 to OpenSource (part 3).
https://bugs.webkit.org/show_bug.cgi?id=124803
Reviewed by Anders Carlsson and Tim Horton.
- 6:54 PM Changeset in webkit [159723] by
-
- 6 edits in trunk/Source/JavaScriptCore
JSC Obj-C API should have real documentation
https://bugs.webkit.org/show_bug.cgi?id=124805
Reviewed by Geoffrey Garen.
Massaging the header comments into proper headerdocs.
- API/JSContext.h:
- API/JSExport.h:
- API/JSManagedValue.h:
- API/JSValue.h:
- API/JSVirtualMachine.h:
- 6:27 PM TestExpectations edited by
- (diff)
- 4:57 PM Changeset in webkit [159722] by
-
- 4 edits in trunk/Source
[Mac] Can't drag full-screen video to another monitor
https://bugs.webkit.org/show_bug.cgi?id=124798
Reviewed by Geoffrey Garen.
Source/WebCore:
Make full screen windows movable by default. Previously, we wanted non-movable full screen
windows since they were in the same space and were just placed atop non-full screen windows.
Now that all our supported Mac platforms have explicit full screen support, we can remove this
non-movable restriction.
- platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
Source/WebKit2:
Make full screen windows resizable by default. This allows the window to be resized when
moved between monitors with different resolutions.
- UIProcess/API/mac/WKView.mm:
(-[WKView createFullScreenWindow]):
- 4:36 PM Changeset in webkit [159721] by
-
- 20 edits in trunk/Source/JavaScriptCore
CodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size needed for exit, or any other unrelated things
https://bugs.webkit.org/show_bug.cgi?id=124793
Reviewed by Mark Hahnenberg.
Now m_numCalleeRegisters always refers to the number of locals that the attached
bytecode uses. It never means anything else.
For frame size, we now have it lazily computed from m_numCalleeRegisters for the
baseline engines and we have it stored in DFG::CommonData for the optimizing JITs.
For frame-size-needed-at-exit, we store that in DFG::CommonData, too.
The code no longer implies that there is any arithmetic relationship between
m_numCalleeRegisters and frameSize. Previously it implied that the latter is greater
than the former.
The code no longer implies that there is any arithmetic relationship between the
frame Size and the frame-size-needed-at-exit. Previously it implied that the latter
is greater that the former.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::frameRegisterCount):
- bytecode/CodeBlock.h:
- dfg/DFGCommonData.h:
(JSC::DFG::CommonData::CommonData):
(JSC::DFG::CommonData::requiredRegisterCountForExecutionAndExit):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::frameRegisterCount):
(JSC::DFG::Graph::requiredRegisterCountForExit):
(JSC::DFG::Graph::requiredRegisterCountForExecutionAndExit):
- dfg/DFGGraph.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
- interpreter/JSStackInlines.h:
(JSC::JSStack::pushFrame):
- jit/JIT.h:
(JSC::JIT::frameRegisterCountFor):
- jit/JITOperations.cpp:
- llint/LLIntEntrypoint.cpp:
(JSC::LLInt::frameRegisterCountFor):
- llint/LLIntEntrypoint.h:
- 4:17 PM Changeset in webkit [159720] by
-
- 4 edits in trunk/Source/WebCore
[Win] Clean up ColorSpace handling in Windows code
https://bugs.webkit.org/show_bug.cgi?id=124795
Reviewed by Tim Horton.
Functionality covered by existing fast/css/color test suite.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::safeRGBColorSpaceRef): Handle case of Windows CG implementation not
handling sRGB correctly.
(WebCore::sRGBColorSpaceRef): Use new helper function.
- platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs): Pass correct color space to fill functions.
- platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::platformInit): Initialize color space to value passed
via the style to the constructor.
- 4:07 PM Changeset in webkit [159719] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Another build fix for NetworkProcess on iOS
https://bugs.webkit.org/show_bug.cgi?id=124797
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.
- NetworkProcess/NetworkResourceLoader.h:
- 3:47 PM Changeset in webkit [159718] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Fix the build of the NetworkProcess on iOS
https://bugs.webkit.org/show_bug.cgi?id=124794
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.
- NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/SynchronousNetworkLoaderClient.cpp:
(WebKit::SynchronousNetworkLoaderClient::willSendRequest):
- 3:43 PM Changeset in webkit [159717] by
-
- 15 edits2 moves in trunk/Source/WebCore
WebCrypto algorithms should check that key algorithm matches
https://bugs.webkit.org/show_bug.cgi?id=123628
Reviewed by Anders Carlsson.
No change in behavior yet, because we have one algorithm per key class.
Will be tested once more algorithms are added.
- WebCore.xcodeproj/project.pbxproj: Updated for file renames.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createRsaKeyParamsWithHash):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
- bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::createRSAKeyParametersWithHash):
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
- crypto/CryptoAlgorithmParameters.h:
(WebCore::CryptoAlgorithmParameters::ENUM_CLASS):
- crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h: Copied from Source/WebCore/crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h.
- crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Removed.
Renamed RsaSsaKeyParams to RsaKeyParamsWithHash, because other algorithms (like RSA-OAEP)
are in the same boat. Depending on where the spec goes, we might need to introduce
algorithm specific RSA parameter classes later, but let's reduce copy/pasted code at
least for now.
- crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Moved to the correct directory.
- crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Copied from Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign): Factored out Mac specific
code, leaving type casting to cross-platform files.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Ditto.
- crypto/CryptoAlgorithmRegistry.h:
(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Reduce copy/pasting in registration code.
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches): Check key type and algorithm.
(WebCore::CryptoAlgorithmAES_CBC::encrypt): Cross platform type casting code.
Maybe we'll find a way to autogenerate or eliminate it one day.
(WebCore::CryptoAlgorithmAES_CBC::decrypt): Ditto.
- crypto/algorithms/CryptoAlgorithmAES_CBC.h:
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
- crypto/algorithms/CryptoAlgorithmHMAC.h:
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
Same changes for all algorithms that have keys.
- 2:57 PM Changeset in webkit [159716] by
-
- 2 edits in trunk
[GTK] Review enabled/disabled CSS features for release builds
https://bugs.webkit.org/show_bug.cgi?id=124791
Reviewed by Martin Robinson.
Enable and disable some CSS features according to what last versions of
Safari ship or not.
- Source/autotools/SetupWebKitFeatures.m4: Enable ENABLE_CSS_REGIONS and
ENABLE_CSS_STICKY_POSITION. Disable ENABLE_CSS_EXCLUSIONS and
ENABLE_CSS_SHAPES.
- 2:52 PM Changeset in webkit [159715] by
-
- 4 edits6 adds in trunk/Source/WebKit2
Move the remaining page loader clients out into separate files
https://bugs.webkit.org/show_bug.cgi?id=124792
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKPageContextMenuClient.h: Added.
- UIProcess/API/C/WKPageFindClient.h: Added.
- UIProcess/API/C/WKPageFindMatchesClient.h: Added.
- UIProcess/API/C/WKPageFormClient.h: Added.
- UIProcess/API/C/WKPageLoaderClient.h:
- UIProcess/API/C/WKPagePolicyClient.h: Added.
- UIProcess/API/C/WKPageUIClient.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 2:24 PM Changeset in webkit [159714] by
-
- 4 edits2 adds in trunk
Fire "change" event on TextTrackList when a TextTrack's mode changes
https://bugs.webkit.org/show_bug.cgi?id=124789
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.
Source/WebCore:
Since AudioTrackList and VideoTrackList already have this event, the
interesting bits are in TrackListBase::scheduleChangeEvent(), and we
just need to call it for TextTrackList changes.
Test: media/track/track-change-event.html
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::textTrackModeChanged): Call TrackListBase::scheduleChangeEvent().
- html/track/TextTrackList.idl: Add onchange event listener.
LayoutTests:
- media/track/track-change-event-expected.txt: Added.
- media/track/track-change-event.html: Added.
- 2:03 PM Changeset in webkit [159713] by
-
- 17 edits in trunk/Source/JavaScriptCore
Combine SymbolTable and SharedSymbolTable
https://bugs.webkit.org/show_bug.cgi?id=124761
Reviewed by Geoffrey Garen.
SymbolTable was never used directly; we now always used SharedSymbolTable. So, this
gets rid of SymbolTable and renames SharedSymbolTable to SymbolTable.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::symbolTable):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedFunctionExecutable::symbolTable):
(JSC::UnlinkedCodeBlock::symbolTable):
(JSC::UnlinkedCodeBlock::finishCreation):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::symbolTable):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::symbolTableFor):
- runtime/Arguments.h:
(JSC::Arguments::finishCreation):
- runtime/Executable.h:
(JSC::FunctionExecutable::symbolTable):
- runtime/JSActivation.h:
(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::allocationSize):
- runtime/JSSymbolTableObject.h:
(JSC::JSSymbolTableObject::symbolTable):
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):
- runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
- runtime/SymbolTable.cpp:
(JSC::SymbolTable::destroy):
(JSC::SymbolTable::SymbolTable):
- runtime/SymbolTable.h:
(JSC::SymbolTable::create):
(JSC::SymbolTable::createStructure):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 1:59 PM Changeset in webkit [159712] by
-
- 3 edits1 add in trunk/Source/WebKit2
Move WKPageLoaderClient out into a separate header
https://bugs.webkit.org/show_bug.cgi?id=124790
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKPageLoaderClient.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 1:44 PM Changeset in webkit [159711] by
-
- 7 edits in trunk
Add TextTrackList::getTrackById().
https://bugs.webkit.org/show_bug.cgi?id=124785
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-id.html
- html/track/TextTrackList.cpp: Add getTrackById()
(TextTrackList::getTrackById):
- html/track/TextTrackList.h: Same.
- html/track/TextTrackList.idl: Same.
LayoutTests:
Update this test to make it more interesting. It now checks that the "id"
changes when the <track> id changes, makes sure TextTrack::id is readonly,
and looks the track up by id with getTrackById().
- media/track/track-id-expected.txt:
- media/track/track-id.html:
- 1:22 PM Changeset in webkit [159710] by
-
- 2 edits in trunk/Tools
Speculative Mountain Lion build fix.
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate openDocument:]):
- 1:09 PM Changeset in webkit [159709] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove residual references to "dynamicGlobalObject".
https://bugs.webkit.org/show_bug.cgi?id=124787.
Reviewed by Filip Pizlo.
- JavaScriptCore.order:
- interpreter/CallFrame.h:
- 12:57 PM Changeset in webkit [159708] by
-
- 2 edits in trunk/Tools
Fix Mountain Lion bug.
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate openDocument:]):
- 12:38 PM Changeset in webkit [159707] by
-
- 2 edits in trunk/Tools
MiniBrowser should use the blocks-based NSOpenPanel API
https://bugs.webkit.org/show_bug.cgi?id=124786
Reviewed by Simon Fraser.
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate frontmostBrowserWindowController]):
Account for windows that don't have a BrowserWindowController.
(-[BrowserAppDelegate openDocument:]):
- 12:31 PM Changeset in webkit [159706] by
-
- 3 edits in trunk/Source/JavaScriptCore
Ensure that arity fixups honor stack alignment requirements.
https://bugs.webkit.org/show_bug.cgi?id=124756.
Reviewed by Geoffrey Garen.
The LLINT and all the JITs rely on CommonSlowPaths::arityCheckFor() to
compute the arg count adjustment for the arity fixup. We take advantage
of this choke point and introduce the stack alignment padding there in
the guise of additional args.
The only cost of this approach is that the padding will also be
initialized to undefined values as if they were args. Since arity fixups
are considered a slow path that is rarely taken, this cost is not a
concern.
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
- runtime/VM.h:
(JSC::VM::isSafeToRecurse):
- 12:18 PM Changeset in webkit [159705] by
-
- 5 edits1 delete in trunk
BytecodeGenerator should align the stack according to native conventions
https://bugs.webkit.org/show_bug.cgi?id=124735
Source/JavaScriptCore:
Reviewed by Mark Lam.
Rolling this back in because it actually fixed fast/dom/gc-attribute-node.html, but
our infrastructure misleads peole into thinking that fixing a test constitutes
breaking it.
- bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):
- bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
LayoutTests:
Reviewed by Mark Lam.
- platform/mac/fast/dom/gc-attribute-node-expected.txt: Removed.
- 12:06 PM Changeset in webkit [159704] by
-
- 2 edits in trunk/Source/WebKit2
Fix 32-bit build.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController _initWithPageRef:]):
- 11:48 AM Changeset in webkit [159703] by
-
- 5 edits in trunk/Source/WebKit2
Debug builds unconditionally dump remote layer tree transactions to stderr.
Reviewed by Sam Weinig.
- Platform/Logging.h: Declared RemoteLayerTree logging channel.
- Shared/mac/RemoteLayerTreeTransaction.h: Declared description().
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::dump): Changed to use description().
(WebKit::RemoteLayerTreeTransaction::description): Returns a CString with the description.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit): Changed to use logging instead of calling dump().
- 11:35 AM Changeset in webkit [159702] by
-
- 7 edits4 adds in trunk
[CSS Shapes] When the <box> value is set, derive radii from border-radius
https://bugs.webkit.org/show_bug.cgi?id=124228
Reviewed by Dean Jackson.
Source/WebCore:
Add support for BoxShape elliptical corners.
Tests: fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html
fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html
- platform/graphics/FloatRoundedRect.h:
(WebCore::FloatRoundedRect::bottomLeftCorner): Corrected a copy-and-pasteO.
- rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::getExcludedIntervals): Returned interval now depends on the top and bottom of the line.
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape): Rounded rect parameters are now specified with a RoundedRect parameter.
- rendering/shapes/Shape.h:
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape): Pass style's rounded border to createShape().
LayoutTests:
- fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html: Added.
- 11:33 AM Changeset in webkit [159701] by
-
- 4 edits in trunk/Source/WebKit2
Send out the right KVO callbacks when the page title changes
https://bugs.webkit.org/show_bug.cgi?id=124753
Reviewed by Simon Fraser.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(PageLoadStateObserver::PageLoadStateObserver):
New class that sends the right KVO notifications when the load state changes.
(-[WKBrowsingContextController dealloc]):
Remove the observer.
(-[WKBrowsingContextController _initWithPageRef:]):
Allocate the observer and add it.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::~PageLoadState):
Assert that we don't have any observers left.
(WebKit::PageLoadState::addObserver):
Add the observer to the list.
(WebKit::PageLoadState::removeObserver):
Remove the observer from the list.
(WebKit::PageLoadState::reset):
Call title change callbacks.
(WebKit::PageLoadState::setTitle):
Ditto.
(WebKit::PageLoadState::callObserverCallback):
Helper function to dispatch callbacks to observers.
- UIProcess/PageLoadState.h:
Add new members.
- 11:31 AM Changeset in webkit [159700] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 11:28 AM Changeset in webkit [159699] by
-
- 1 copy in tags/Safari-537.60.7
New Tag.
- 11:14 AM Changeset in webkit [159698] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merge r159691
2013-11-21 Brent Fulgham <Brent Fulgham>
[Win] Avoid deadlock when interacting with some AVFoundationCF content
<rdar://problem/15482977> and https://bugs.webkit.org/show_bug.cgi?id=124752
Prevent deadlock caused by conflict over the "mapLock" mutex. Notification handling in the file,
which modify assets and make other changes, are required to happen on the main thread. This
patch enforces this requirement.
Reviewed by Eric Carlson.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::NotificationCallbackData::NotificationCallbackData): Added (WebCore::AVFWrapper::processNotification): Moved logic from 'notificationCallback', which was sometimes happening on a background thread. (WebCore::AVFWrapper::notificationCallback): Dispatch calls to main thread.
- 10:24 AM Changeset in webkit [159697] by
-
- 3 edits in trunk/Source/JavaScriptCore
Get rid of CodeBlock::dumpStatistics()
https://bugs.webkit.org/show_bug.cgi?id=124762
Reviewed by Mark Hahnenberg.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
- bytecode/CodeBlock.h:
- 9:46 AM Changeset in webkit [159696] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r159690.
http://trac.webkit.org/changeset/159690
https://bugs.webkit.org/show_bug.cgi?id=124782
Broke webkitpy tests (Requested by ap on #webkit).
- Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run):
(QueueEngine._open_work_log):
(QueueEngine._ensure_work_log_closed):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.review_patch):
- 9:44 AM Changeset in webkit [159695] by
-
- 2 edits in trunk/Source/WebCore
Several missing/incorrect guards for LOG_DISABLED=0 against Release build (Mac)
https://bugs.webkit.org/show_bug.cgi?id=78735
Patch by Andres Gomez <Andres Gomez> on 2013-11-22
Reviewed by Mario Sanchez Prada.
In a "Debug" build the CString.h header comes from another
indirect dependency. Now, we explicitly add this missing include.
- page/CaptionUserPreferencesMediaAF.cpp: Explicitly adding
missing include.
- 9:38 AM Changeset in webkit [159694] by
-
- 2 edits in trunk/LayoutTests
Layout Test editing/deleting/password-delete-performance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=124781
- TestExpectations: Skipped it, running a test that almost always times out makes little sense.
- 9:34 AM Changeset in webkit [159693] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r159652.
http://trac.webkit.org/changeset/159652
https://bugs.webkit.org/show_bug.cgi?id=124778
broke fast/dom/gc-attribute-node.html (Requested by ap on
#webkit).
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
- bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):
- bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument):
- 9:27 AM Changeset in webkit [159692] by
-
- 2 edits in trunk/Source/WebCore
[curl] Fix of SSL certificate chain storage
https://bugs.webkit.org/show_bug.cgi?id=124768
Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2013-11-22
Reviewed by Brent Fulgham.
Change the certificates storage type into ListHashSet
from HashSet to keep the chain order in each case.
This ensures that there is no difference between the stored
and the recieved certificate chain.
- platform/network/curl/SSLHandle.cpp:
(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::pemData):
(WebCore::certVerifyCallback):
- 9:23 AM Changeset in webkit [159691] by
-
- 2 edits in trunk/Source/WebCore
[Win] Avoid deadlock when interacting with some AVFoundationCF content
<rdar://problem/15482977> and https://bugs.webkit.org/show_bug.cgi?id=124752
Prevent deadlock caused by conflict over the "mapLock" mutex. Notification handling in the file,
which modify assets and make other changes, are required to happen on the main thread. This
patch enforces this requirement.
Reviewed by Eric Carlson.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::NotificationCallbackData::NotificationCallbackData): Added
(WebCore::AVFWrapper::processNotification): Moved logic from 'notificationCallback', which was
sometimes happening on a background thread.
(WebCore::AVFWrapper::notificationCallback): Dispatch calls to main thread.
- 8:26 AM Changeset in webkit [159690] by
-
- 3 edits in trunk/Tools
EWS creates 0 byte sized log files
https://bugs.webkit.org/show_bug.cgi?id=107606
Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-22
Reviewed by Ryosuke Niwa.
There was a modification in r138264, that tried to make less log,
because some of the messeges were duplicated. After this the EWS
created the log file (with the same name as the bugID) but doesn't
write anything into it, even if there were errors during the build.
From now only creates the log file only if there is some error.
- Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
there is nothing to log. Open the log file only if a ScriptError was raised to
avoid to make empty log files for bugs.
(QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
because of changes in r138264. Teeing is used for locally testing purposes and
this feature is not used anymore.
(QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
teeing anymore. It is a necessary change because of QueueEngine._open_work_log
change.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
to be able to handle it in QueueEngine.run. Without this change, the existing
exception handler never run (the process_work_item method never raise ScriptError)
We can get the error message only from the ScriptError at this point.
- 8:07 AM Changeset in webkit [159689] by
-
- 5 edits59 adds in trunk/LayoutTests
Import more W3C tests for parsing template elements
https://bugs.webkit.org/show_bug.cgi?id=124763
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Imported more W3c tests for HTML template element at 12a1164ae919f29f6ba2d0c8a63f0eafb6b599aa
after applying fixes proposed at https://github.com/w3c/web-platform-tests/pull/442.
- html-templates/definitions/template-contents-expected.txt: Added.
- html-templates/definitions/template-contents-owner-document-type-expected.txt: Added.
- html-templates/definitions/template-contents-owner-document-type.html: Added.
- html-templates/definitions/template-contents-owner-test-001-expected.txt: Added.
- html-templates/definitions/template-contents-owner-test-001.html: Added.
- html-templates/definitions/template-contents-owner-test-002-expected.txt: Added.
- html-templates/definitions/template-contents-owner-test-002.html: Added.
- html-templates/definitions/template-contents.html: Added.
- html-templates/innerhtml-on-templates/innerhtml-expected.txt: Added.
- html-templates/innerhtml-on-templates/innerhtml.html: Added.
- html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-a-foster-parent-element-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-a-foster-parent-element.html: Added.
- html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-not-a-foster-parent-element-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-not-a-foster-parent-element.html: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags.html: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-body-token-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-body-token.html: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-frameset-token-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-frameset-token.html: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-head-token-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-head-token.html: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-html-token-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-html-token.html: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-body-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-body.html: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-html-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-html.html: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one.html: Added.
- html-templates/parsing-html-templates/additions-to-the-in-frameset-insertion-mode/end-tag-frameset-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-the-in-frameset-insertion-mode/end-tag-frameset.html: Added.
- html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags.html: Added.
- html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one.html: Added.
- html-templates/parsing-html-templates/additions-to-the-in-table-insertion-mode/end-tag-table-expected.txt: Added.
- html-templates/parsing-html-templates/additions-to-the-in-table-insertion-mode/end-tag-table.html: Added.
- html-templates/parsing-html-templates/appending-to-a-template/template-child-nodes-expected.txt: Added.
- html-templates/parsing-html-templates/appending-to-a-template/template-child-nodes.html: Added.
- html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context-expected.txt: Added.
- html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context.html: Added.
- html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context-expected.txt: Added.
- html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context.html: Added.
- html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context-expected.txt: Added.
- html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context.html: Added.
- html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document-expected.txt: Added.
- html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document.html: Added.
LayoutTests:
Updated the testharness.js/css to bc4639ba51b62158d94bb4fc6884b23453f3f7a1.
- resources/testharness.css:
- resources/testharness.js:
- resources/testharnessreport.js: Use innerText instead of innerHTML to avoid interpreting markup inside
the status and message as HTML.
- 8:01 AM Changeset in webkit [159688] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error when ACCELERATED_COMPOSITING is not used.
https://bugs.webkit.org/show_bug.cgi?id=124773
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-22
Reviewed by Brent Fulgham.
- rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations): Added USE(ACCELERATED_COMPOSITING) guard.
- 7:12 AM Changeset in webkit [159687] by
-
- 6 edits5 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining after r159575 and r159579.
- platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
- platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
- platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Added.
- platform/gtk/editing/deleting/delete-by-word-002-expected.txt: Added.
- platform/gtk/editing/input/option-page-up-down-expected.txt: Added.
- platform/gtk/editing/input/scroll-viewport-page-up-down-expected.txt: Added.
- platform/gtk/editing/undo/undo-deleteWord-expected.txt: Added.
- platform/gtk/fast/block/float/024-expected.txt:
- platform/gtk/fast/block/margin-collapse/025-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- 7:00 AM Changeset in webkit [159686] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for tests that regressed with r159572.
- platform/gtk/TestExpectations:
- 3:03 AM Changeset in webkit [159685] by
-
- 4 edits3 adds in trunk
[CSS Grid Layout] Improve content-sized track layout
https://bugs.webkit.org/show_bug.cgi?id=124408
Reviewed by Dean Jackson.
PerformanceTests:
From Blink r156122 by <jchaffraix@chromium.org>
New test to check the performance of layouting grids with content sized tracks.
- Layout/auto-grid-lots-of-data.html: Added.
Source/WebCore:
Test: fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html
From Blink r156122 & r157633 by <jchaffraix@chromium.org>
Added a couple of optimizations to speed up the layout of content
based tracks. The idea is to narrow down the conditions for
relayouting when the height of a grid area changes. We basically
just need to layout tracks with percentage heights as they're the
only ones that change.
A new performance test is attached to demonstrate the effect of
these optimizations. We get a ~1000% improvement on a i7 M620
going from 14.5 runs/s to 165 runs/s.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::layoutGridItems):
LayoutTests:
From Blink r157633 by <jchaffraix@chromium.org>
New test to verify that grid items with percentage logical
{min|max}-height resolve their sizes properly.
- fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic-expected.txt: Added.
- fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html: Added.
- 1:25 AM Changeset in webkit [159684] by
-
- 9 edits1 add in trunk
[CSS Grid Layout] Run the content-sized tracks sizing algorithm only when required
https://bugs.webkit.org/show_bug.cgi?id=124039
Reviewed by Dean Jackson.
PerformanceTests:
From Blink r156028 and r156168 by <jchaffraix@chromium.org>.
New performance tests for layouts in grids with fixed size tracks.
- Layout/fixed-grid-lots-of-data.html: Added.
Source/WebCore:
The current code runs the content sized track sizing algorithm all
the time, which forces a layout even when the track is not
content-sized. This change improves the situation by applying two
optimizations. In the first one, we bail out the algorithm if we
detect that we don't need to run it. And by the second one we
reduce the amount of recomputations by only iterating over the
content sized tracks instead of all of them. Both changes follow
the ideas introduced in Blink r156028 and r156168 by
<jchaffraix@chromium.org>.
As we changed the way we iterate over children (we use the
GridIterator now) the way they're stored in the RenderGrid changes
too. If a item spans through several "cells" inside the grid, we
will have a reference to it on each of them.
These two changes account for a ~3200% improvement on a i7 M620 in
the test that accompanies this change (15.5 vs 520 run/s).
New perf test: PerformanceTests/Layout/fixed-grid-lots-of-data.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Keep track
of content sized tracks and only iterate over them.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Early return if there are no tracks to pass to the algorithm.
- rendering/RenderGrid.h:
- rendering/style/GridLength.h:
(WebCore::GridLength::isContentSized):
- rendering/style/GridTrackSize.h:
(WebCore::GridTrackSize::isContentSized):
LayoutTests:
From Blink r156028 and r156168 by <jchaffraix@chromium.org>.
Subtle baseline change due to grids triggering less layouts, which
changes the frame rects between 2 subsequent layouts thus changing
the repaint rectangles.
- fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
- fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:
- 1:22 AM Changeset in webkit [159683] by
-
- 2 edits in trunk/Source/WebCore
[CSS Regions] Move code after early break in RenderRegion::repaintFlowThreadContentRectangle
https://bugs.webkit.org/show_bug.cgi?id=124743
Reviewed by Mihnea Ovidenie.
No new tests, covered by existing tests.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::repaintFlowThreadContentRectangle): Variable
flippedFlowThreadPortionRect is not used before the early break, so we
can move it after and save some unneeded operations.
- 12:28 AM Changeset in webkit [159682] by
-
- 2 edits in trunk/Source/WebCore
[CSS Regions] Use hasOverflowClip() in RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=124746
Reviewed by Mihnea Ovidenie.
Implement the suggested FIXME in RenderRegion using hasOverflowClip().
No new tests, covered by existing tests.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion): Use
hasOverflowClip().
(WebCore::RenderRegion::rectFlowPortionForBox): Ditto.
Nov 21, 2013:
- 9:12 PM Changeset in webkit [159681] by
-
- 3 edits2 deletes in trunk/Source
Remove ANGLEGenerated from Windows build.
https://bugs.webkit.org/show_bug.cgi?id=124759
Patch by Alex Christensen <achristensen@webkit.org> on 2013-11-21
Reviewed by Darin Adler.
Source/ThirdParty/ANGLE:
- ANGLE.vcxproj/ANGLEGenerated.vcxproj: Removed.
- ANGLE.vcxproj/ANGLEGenerated.vcxproj.filters: Removed.
Source/WebKit:
- WebKit.vcxproj/WebKit.sln:
Remove references to ANGLEGenerated.vcxproj.
- 9:03 PM Changeset in webkit [159680] by
-
- 6 edits2 adds in trunk
Map the dir attribute to the CSS direction property.
https://bugs.webkit.org/show_bug.cgi?id=124572.
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-11-21
Reviewed by Darin Adler.
Source/WebCore:
Test: mathml/presentation/mstyle-css-attributes.html
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::isPresentationAttribute): reorder attributes
(WebCore::MathMLElement::collectStyleForPresentationAttribute): reorder tags that accept dir
(WebCore::MathMLElement::isMathMLToken): add an inline function to test that a tag corresponds to a MathML Token Element.
- mathml/MathMLElement.h:
Follow-up work to address Darin's comments.
LayoutTests:
- mathml/presentation/direction-overall-expected.html: test that dir does not apply to msqrt
- mathml/presentation/direction-overall.html:
- mathml/presentation/mstyle-css-attributes-expected.html: Added.
- mathml/presentation/mstyle-css-attributes.html: Added.
Add more tests for presentation attributes on mstyle.
- 9:01 PM Changeset in webkit [159679] by
-
- 116 edits in trunk
Remove ENABLE_WORKERS
https://bugs.webkit.org/show_bug.cgi?id=105784
.:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
Source/WebKit:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/efl:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):
Source/WebKit/win:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- WebWorkersPrivate.cpp:
(WebWorkersPrivate::workerThreadCount):
Source/WTF:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- wtf/FeatureDefines.h:
- wtf/nix/FeatureDefinesNix.h:
Tools:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- Scripts/webkitperl/FeatureList.pm:
WebKitLibraries:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- win/tools/vsprops/FeatureDefines.props:
- win/tools/vsprops/FeatureDefinesCairo.props:
- 8:42 PM Changeset in webkit [159678] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed build fix after r159632.
- platform/network/curl/SSLHandle.cpp:
(WebCore::certVerifyCallback):
Fixed template syntax.
- 8:24 PM Changeset in webkit [159677] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix a typo (requriements->requirements).
- runtime/StackAlignment.h:
- 8:22 PM Changeset in webkit [159676] by
-
- 2 edits in trunk/Tools
Try to fix buildbot Dashboard for people who have not hidden anything.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
Add a null check for hidden platforms.
- 8:17 PM Changeset in webkit [159675] by
-
- 7 edits in trunk/Tools
Remove chrome/chromium related things from webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=124493
Patch by Peter Szanka <h868064@stud.u-szeged.hu> on 2013-11-21
Reviewed by Darin Adler.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.assert_mock_port_works):
- Scripts/webkitpy/port/base.py:
(Port.to.setup_environ_for_server):
- Scripts/webkitpy/port/mac_unittest.py:
(test_tests_for_other_platforms):
- Scripts/webkitpy/port/mock_drt.py:
(MockTestShell.output_for_test):
- Scripts/webkitpy/tool/bot/irc_command.py:
(Restart.execute):
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):
- 8:05 PM Changeset in webkit [159674] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Fix build after r159656
https://bugs.webkit.org/show_bug.cgi?id=124755
Patch by Sergio Correia <Sergio Correia> on 2013-11-21
Reviewed by Gyuyoung Kim.
Page title was moved to page load state.
- UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
(WebKit::WebInspectorServer::buildPageList):
- 7:56 PM Changeset in webkit [159673] by
-
- 1 edit1 add in trunk/Source/ThirdParty/ANGLE
Unreviewed build fix.
- src/libGLESv2/Constants.h: Added from checkout a60e0805721f62c28a55faf2df74472cc5fc91fc.
- 7:49 PM Changeset in webkit [159672] by
-
- 3 edits in trunk/Tools
In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=124717
Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-21
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/style/filereader.py:
(TextFileReader.process_file):
- Scripts/webkitpy/style/filereader_unittest.py:
(TextFileReaderTest.test_process_filedoes_not_exist):
- 7:17 PM Changeset in webkit [159671] by
-
- 13 edits in trunk
Web Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API surface
https://bugs.webkit.org/show_bug.cgi?id=124737
Reviewed by Timothy Hatcher.
Source/WebCore:
Add a virtual method to Shapes, buildPath, that can be used to build the
path (in the Shape coordinate system) for display in the Inspector. This allows us
to remove methods such as type(), polygon(), and logicalRx/Ry() which exposed the
inner workings of the Shapes classes. Also covers the addition of the BoxShape type.
Refactoring, existing test is inspector-protocol/model/highlight-shape-outside.html.
- inspector/InspectorOverlay.cpp:
(WebCore::appendPathCommandAndPoints): Points need to be translated from shape space
to renderer space using ShapeInfo.
(WebCore::buildObjectForShapeOutside): Add the ShapeOutsideInfo to the path info struct.
- rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::buildPath): Build the path for a BoxShape.
- rendering/shapes/BoxShape.h:
- rendering/shapes/PolygonShape.cpp:
(WebCore::PolygonShape::buildPath): Build the path for a PolygonShape.
- rendering/shapes/PolygonShape.h:
- rendering/shapes/RasterShape.h:
- rendering/shapes/RectangleShape.cpp:
(WebCore::RectangleShape::buildPath): Build the path for a RectangleShape.
- rendering/shapes/RectangleShape.h:
- rendering/shapes/Shape.h:
LayoutTests:
The shapes paths are now drawn in shape-coordinate space before being translated to
renderer space. With different writing modes, shapes may have their coordinates
translated. For example, a rectangle specified as four points [top left, top right,
bottom right, bottom left] in vertical-lr space would appear as [top left, bottom left,
bottom right, top right] in horizontal-tb space. Adjusting the previous tests, and
adding a test for the new box value.
- inspector-protocol/model/highlight-shape-outside-expected.txt:
- inspector-protocol/model/highlight-shape-outside.html:
- 7:12 PM Changeset in webkit [159670] by
-
- 3 edits in trunk/Source/JavaScriptCore
CodeBlock::m_numCalleeRegisters need to honor native stack alignment.
https://bugs.webkit.org/show_bug.cgi?id=124754.
Reviewed by Filip Pizlo.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::newRegister):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- 7:04 PM Changeset in webkit [159669] by
-
- 13 edits in trunk
<https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
All modern versions of Xcode set it appropriately for our needs.
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
Tools:
- MiniBrowser/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- 7:01 PM Changeset in webkit [159668] by
-
- 2 edits2 adds in trunk/Tools
webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
https://bugs.webkit.org/show_bug.cgi?id=124676
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-21
Reviewed by Daniel Bates.
checkForArgumentAndRemoveFromArrayRef functions was removing wrong
elements when there were more then one occurrence of that argument.
E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
{b, a}, when it should be {b, c}.
- Scripts/webkitdirs.pm:
(checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
- Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
- 7:01 PM Changeset in webkit [159667] by
-
- 4 edits in trunk/Source
[GTK] Unreviewed buildfix after r159614 and r159656.
Source/WebCore:
- bindings/gobject/WebKitDOMCustom.cpp: Add missing header
Source/WebKit2:
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::buildPageList): Use the page load state to get page title.
- 6:59 PM Changeset in webkit [159666] by
-
- 2 edits in trunk/Source/WebCore
Fix WinCairo unreachable code warnings in SimpleLineLayout.cpp
https://bugs.webkit.org/show_bug.cgi?id=124704
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-21
Reviewed by Antti Koivisto.
Fix unreachable code warnings using conditional directives.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- 6:57 PM Changeset in webkit [159665] by
-
- 12 edits in trunk/Source
<https://webkit.org/b/124701> Fix an error in a few Xcode configuration setting files.
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- 6:56 PM Changeset in webkit [159664] by
-
- 2 edits in trunk/Tools
Update build-webkit after r159550.
- Scripts/webkitperl/FeatureList.pm:
- 6:55 PM Changeset in webkit [159663] by
-
- 8 edits in trunk/Source
<https://webkit.org/b/124700> Fix some deprecation warnings.
Reviewed by Anders Carlsson.
Source/WebCore:
- platform/mac/HTMLConverter.mm:
(fileWrapperForURL): Move off a deprecated NSFileWrapper method.
Source/WebKit/mac:
- Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::startStream): Move off a deprecated NSData method.
- WebView/WebDataSource.mm:
(-[WebDataSource _fileWrapperForURL:]): Move off a deprecated NSFileWrapper method.
- WebView/WebHTMLView.mm:
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
Source/WebKit2:
- UIProcess/API/mac/WKView.mm:
(-[WKView namesOfPromisedFilesDroppedAtDestination:]): Move off a deprecated NSFileWrapper method.
- 6:53 PM Changeset in webkit [159662] by
-
- 3 edits in trunk/LayoutTests
[EFL] Layout tests with editing need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124751
Unreviewed, EFL rebaseline.
editing/input/reveal-caret-of-multiline-contenteditable.html test is rebaselined after r137239.
editing/selection/5354455-2.html test is rebaselined after r133000.
Rebaseline the expected results to suit editing-related performance in EFL.
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-21
- platform/efl-wk1/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
- platform/efl/editing/selection/5354455-2-expected.txt:
- 6:38 PM Changeset in webkit [159661] by
-
- 2 edits in trunk/Tools
Update apple builders.
- 6:20 PM Changeset in webkit [159660] by
-
- 2 edits49 adds in trunk/LayoutTests
Import some W3C tests for HTML template element
https://bugs.webkit.org/show_bug.cgi?id=124699
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Imported the shared resources for web-platform-tests/html-templates as well as tests under
serializing-html-templates and template-element at a274ad93ef5dc02ac042e0a5d58327d4135178ac.
- ChangeLog: Added.
- html-templates/resources/end-template-tag-in-body.html: Added.
- html-templates/resources/end-template-tag-in-head.html: Added.
- html-templates/resources/frameset-end-tag.html: Added.
- html-templates/resources/head-template-contents-div-no-end-tag.html: Added.
- html-templates/resources/head-template-contents-table-no-end-tag.html: Added.
- html-templates/resources/html-start-tag.html: Added.
- html-templates/resources/template-child-nodes-div.xhtml: Added.
- html-templates/resources/template-child-nodes-nested.xhtml: Added.
- html-templates/resources/template-contents-attribute.html: Added.
- html-templates/resources/template-contents-body.html: Added.
- html-templates/resources/template-contents-div-no-end-tag.html: Added.
- html-templates/resources/template-contents-empty.html: Added.
- html-templates/resources/template-contents-frameset.html: Added.
- html-templates/resources/template-contents-head.html: Added.
- html-templates/resources/template-contents-html.html: Added.
- html-templates/resources/template-contents-nested.html: Added.
- html-templates/resources/template-contents-table-no-end-tag.html: Added.
- html-templates/resources/template-contents-text.html: Added.
- html-templates/resources/template-contents.html: Added.
- html-templates/resources/template-descendant-body.html: Added.
- html-templates/resources/template-descendant-frameset.html: Added.
- html-templates/resources/template-descendant-head.html: Added.
- html-templates/resources/two-templates.html: Added.
- html-templates/serializing-html-templates/outerhtml-expected.txt: Added.
- html-templates/serializing-html-templates/outerhtml.html: Added.
- html-templates/template-element/content-attribute-expected.txt: Added.
- html-templates/template-element/content-attribute.html: Added.
- html-templates/template-element/node-document-changes-expected.txt: Added.
- html-templates/template-element/node-document-changes.html: Added.
- html-templates/template-element/template-as-a-descendant-expected.txt: Added.
- html-templates/template-element/template-as-a-descendant.html: Added.
- html-templates/template-element/template-content-expected.txt: Added.
- html-templates/template-element/template-content-node-document-expected.txt: Added.
- html-templates/template-element/template-content-node-document.html: Added.
- html-templates/template-element/template-content.html: Added.
- html-templates/template-element/template-descendant-body-expected.txt: Added.
- html-templates/template-element/template-descendant-body.html: Added.
- html-templates/template-element/template-descendant-frameset-expected.txt: Added.
- html-templates/template-element/template-descendant-frameset.html: Added.
- html-templates/template-element/template-descendant-head-expected.txt: Added.
- html-templates/template-element/template-descendant-head.html: Added.
- html-templates/testcommon.js: Added.
LayoutTests:
- imported/w3c/: Added.
- platform/win/TestExpectations: Skip the imported tests since the template element is disabled on Windows.
- 6:12 PM Changeset in webkit [159659] by
-
- 3 edits in trunk/Tools
Don't fetch hidden platforms on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124750
Reviewed by Tim Horton.
If a platform is hidden, don't fetch its data. If it
becomes unhidden, try to fetch immediately (unless
you've recently fetched).
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
- 5:29 PM Changeset in webkit [159658] by
-
- 2 edits in trunk/Source/WebKit2
Didn't mean to commit this.
- UIProcess/PageLoadState.h:
- 5:16 PM Changeset in webkit [159657] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Unreviewed gardening to hide annoying *.user files when.
- ANGLE.vcxproj: Added property svn:ignore.
- 5:13 PM Changeset in webkit [159656] by
-
- 6 edits in trunk/Source/WebKit2
Move page title handling to the page load state
https://bugs.webkit.org/show_bug.cgi?id=124748
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKPage.cpp:
(WKPageCopyTitle):
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::didCommitLoad):
(WebKit::PageLoadState::title):
(WebKit::PageLoadState::setTitle):
- UIProcess/PageLoadState.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveTitleForFrame):
- UIProcess/WebPageProxy.h:
- 5:11 PM Changeset in webkit [159655] by
-
- 4 edits in trunk/Source/JavaScriptCore
ARM64: Implement push/pop equivalents in LLInt
https://bugs.webkit.org/show_bug.cgi?id=124721
Reviewed by Filip Pizlo.
Added pushLRAndFP and popLRAndFP that push and pop the link register and frame pointer register.
These ops emit code just like what the compiler emits in the prologue and epilogue. Also changed
pushCalleeSaves and popCalleeSaves to use the same store pair and load pair instructions to do
the actually pushing and popping. Finally changed the implementation of push and pop to raise
an exception since we don't have (or need) a single register push or pop.
- llint/LowLevelInterpreter64.asm:
- offlineasm/arm64.rb:
- offlineasm/instructions.rb:
- 4:46 PM Changeset in webkit [159654] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSC: Removed unused opcodes from offline assembler
https://bugs.webkit.org/show_bug.cgi?id=124749
Reviewed by Mark Hahnenberg.
Removed the unused, X86 only peekq and pokeq.
- offlineasm/instructions.rb:
- offlineasm/x86.rb:
- 4:31 PM Changeset in webkit [159653] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(159395) Fix branch8(…, AbsoluteAddress, …) in ARM64 MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=124688
Reviewed by Geoffrey Garen.
Changed handling of the address for the load8() in the branch8(AbsoluteAddress) to be like
the rest of the branchXX(AbsoluteAddress) fucntions.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::branch8):
- 3:55 PM Changeset in webkit [159652] by
-
- 4 edits in trunk/Source/JavaScriptCore
BytecodeGenerator should align the stack according to native conventions
https://bugs.webkit.org/show_bug.cgi?id=124735
Reviewed by Mark Lam.
- bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):
- bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
- 3:24 PM Changeset in webkit [159651] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Build fix; export symbol for WebCore::provideDeviceOrientationTo()
Add the symbol ZN7WebCore26provideDeviceOrientationToEPNS_4PageEPNS_23DeviceOrientationClientE.
- WebCore.exp.in:
- 3:21 PM Changeset in webkit [159650] by
-
- 2 edits in trunk/Source/WebCore
Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard
https://bugs.webkit.org/show_bug.cgi?id=124741
Reviewed by Alexey Proskuryakov.
Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused
when building with feature NETWORK_CFDATA_ARRAY_CALLBACK.
Additionally, add a declaration for allocateSegment() with attribute WARN_UNUSED_RETURN
to have the compiler warn when the return value of this function is unused. Together with
warnings treated as errors this change will prevent a memory leak.
- platform/SharedBuffer.cpp:
- 3:20 PM Changeset in webkit [159649] by
-
- 5 edits in trunk/Source
Remove unused functions from WebCore and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124739
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- editing/markup.cpp: Remove unused functions isHTMLBlockElement and
ancestorToRetainStructureAndAppearanceWithNoRenderer.
- rendering/InlineElementBox.cpp: Append newline to the end of the file.
Source/WebKit2:
Remove unused functions autoreleased({WKURLRequestRef, WKURLResponseRef}).
- UIProcess/API/mac/WKBrowsingContextController.mm:
- 3:19 PM Changeset in webkit [159648] by
-
- 16 edits11 adds in trunk/Source/WebCore
Only generate isObservable() when IDL specifies GenerateIsReachable
https://bugs.webkit.org/show_bug.cgi?id=124729
Reviewed by Geoffrey Garen.
We should only generate the static inline function isObservable() when the IDL
specifies GenerateIsReachable. Otherwise, this function is unused.
Added a new test IDL TestGenerateIsReachable.idl and expected results to test that
we generate isObservable() when an IDL specifies GenerateIsReachable. Additionally,
rebased existing test results.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.cpp: Added.
- bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachablePrivate.h: Added.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Removed unused function isObservable().
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
- bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
- bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
- bindings/scripts/test/JS/JSTestException.cpp: Ditto.
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: Added.
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h: Added.
- bindings/scripts/test/JS/JSTestInterface.cpp: Removed unused function isObservable().
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
- bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: Ditto.
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
- bindings/scripts/test/JS/JSTestTypedefs.cpp: Ditto.
- bindings/scripts/test/JS/JSattribute.cpp: Ditto.
- bindings/scripts/test/JS/JSreadonly.cpp: Ditto.
- bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h: Added.
- bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.mm: Added.
- bindings/scripts/test/ObjC/DOMTestGenerateIsReachableInternal.h: Added.
- bindings/scripts/test/TestGenerateIsReachable.idl: Added.
- 2:31 PM Changeset in webkit [159647] by
-
- 37 edits4 moves in trunk/Source/WebKit2
Rename PlatformCertificateInfo to CertificateInfo
https://bugs.webkit.org/show_bug.cgi?id=124150
Reviewed by Darin Adler.
- GNUmakefile.list.am:
- NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithCertficateChain):
(WKCertificateInfoGetCertificateChain):
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):
- Shared/Authentication/AuthenticationManager.h:
- Shared/Authentication/AuthenticationManager.messages.in:
- Shared/Authentication/mac/AuthenticationManager.mac.mm:
(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebCertificateInfo.h:
(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::certificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
- Shared/mac/CertificateInfo.h: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.h.
(WebKit::CertificateInfo::certificateChain):
- Shared/mac/CertificateInfo.mm: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm.
(WebKit::CertificateInfo::CertificateInfo):
(WebKit::CertificateInfo::encode):
(WebKit::CertificateInfo::decode):
(WebKit::CertificateInfo::dump):
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- Shared/soup/CertificateInfo.cpp: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp.
(WebKit::CertificateInfo::CertificateInfo):
(WebKit::CertificateInfo::~CertificateInfo):
(WebKit::CertificateInfo::encode):
(WebKit::CertificateInfo::decode):
- Shared/soup/CertificateInfo.h: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.h.
(WebKit::CertificateInfo::certificate):
(WebKit::CertificateInfo::tlsErrors):
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- UIProcess/API/gtk/WebKitCertificateInfo.cpp:
(webkitCertificateInfoGetCertificateInfo):
- UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_tls_info):
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::useCredential):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost):
- 2:28 PM Changeset in webkit [159646] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][GTK][WK2] Build fix after r159641
https://bugs.webkit.org/show_bug.cgi?id=124742
Patch by Sergio Correia <Sergio Correia> on 2013-11-21
Reviewed by Csaba Osztrogonác.
Should fetch activeURL from page load state.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewUpdateURI):
- UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
(WebKit::WebInspectorServer::buildPageList):
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::buildPageList):
- 2:26 PM WebKitGTK/Debugging edited by
- (diff)
- 1:57 PM Changeset in webkit [159645] by
-
- 9 edits in trunk/Source/WebCore
Add a new mode to extend the tile cache beyond the page
https://bugs.webkit.org/show_bug.cgi?id=124216
Reviewed by Simon Fraser.
This patch makes it possible to give the tile cache a margin of tiles. If there is
a margin of tiles, this patch paints those tiles with the background color. Note
that this patch does not actually give the tile cache a margin at this time.
You opt into a margined tiled cache by called setTileMargins() with number of
pixels that the margin on that side should be.
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
(WebCore::TileController::tilesWouldChangeForVisibleRect):
TileController::bounds() now computes the bounds INCLUDING the margin.
(WebCore::TileController::bounds):
adjustRectAtTileIndexForMargin() is a new function that is required to get the
rect size for tiles in the margin right. rectForTileIndex() assumes all tiles
strive to be the size of m_tileSize, but now margin tiles will be whatever the
margin sizes were set to.
(WebCore::TileController::adjustRectAtTileIndexForMargin):
(WebCore::TileController::rectForTileIndex):
This is another instance where m_tileSize is not always the right size to use.
(WebCore::TileController::getTileIndexRangeForRect):
The tile coverage rect now might include the margin tiles. Only include them in
slow-scrolling mode if the current position is within one tile of the edge.
(WebCore::TileController::computeTileCoverageRect):
tileSizeForCoverageRect() does not make sense in a world where the coverage rect
will include margin. Instead, this patch implements the current strategy more
explicitly by returning the visibleRect in the slow scrolling case, and in the
process this patch also re-names tileSizeForCoverageRect() to computeTileSize()
since it no longer takes a coverageRect.
(WebCore::TileController::computeTileSize):
(WebCore::TileController::revalidateTiles):
New setters and getters for the tile margins on each side.
(WebCore::TileController::setTileMargins):
(WebCore::TileController::hasMargins):
(WebCore::TileController::topMarginHeight):
(WebCore::TileController::bottomMarginHeight):
(WebCore::TileController::leftMarginWidth):
(WebCore::TileController::rightMarginWidth):
New function to add margin onto the composited bounds if there is one.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::tiledBackingHasMargin):
(WebCore::RenderLayerBacking::paintContents):
(WebCore::RenderLayerBacking::compositedBoundsIncludingMargin):
- rendering/RenderLayerBacking.h:
Do not set masks to bounds if there is a margin on the root layer.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::mainFrameBackingIsTiledWithMargin):
- rendering/RenderLayerCompositor.h:
Allow background color to paint into the margin tiles.
- rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
- 1:55 PM Changeset in webkit [159644] by
-
- 6 edits4 adds in trunk
Implement WebCrypto wrapKey
https://bugs.webkit.org/show_bug.cgi?id=124738
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html
crypto/subtle/aes-cbc-wrap-rsa.html
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::exportKey): Factored out the actual operation that can be chained with
encryption for wrapKey.
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey): Fixed a memory leak in failure code path.
- crypto/SubtleCrypto.idl: Added wrapKey.
LayoutTests:
- crypto/subtle/aes-cbc-wrap-rsa-expected.txt: Added.
- crypto/subtle/aes-cbc-wrap-rsa-non-extractable-expected.txt: Added.
- crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html: Added.
- crypto/subtle/aes-cbc-wrap-rsa.html: Added.
- crypto/subtle/aes-export-key-expected.txt:
- crypto/subtle/hmac-export-key-expected.txt:
There is no longer a console message, the error is in an exception.
- 1:11 PM Changeset in webkit [159643] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, preemptive build fix.
- runtime/StackAlignment.h:
(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):
- 1:07 PM Changeset in webkit [159642] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
JSC should know what the stack alignment conventions are
https://bugs.webkit.org/show_bug.cgi?id=124736
Reviewed by Mark Lam.
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/StackAlignment.h: Added.
(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):
- 12:30 PM Changeset in webkit [159641] by
-
- 6 edits in trunk/Source/WebKit2
Fetch all page loading related URLs from the page load state
https://bugs.webkit.org/show_bug.cgi?id=124732
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKPage.cpp:
(WKPageCopyActiveURL):
(WKPageCopyProvisionalURL):
(WKPageCopyCommittedURL):
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController unreachableURL]):
- UIProcess/PageLoadState.h:
(WebKit::PageLoadState::provisionalURL):
(WebKit::PageLoadState::url):
(WebKit::PageLoadState::unreachableURL):
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- 12:03 PM Changeset in webkit [159640] by
-
- 1 edit2 adds in trunk/LayoutTests
Added test for :hover and javascript events on the visual overflow of a region.
[CSS Regions] Content in a region's visible overflow does not trigger :hover state, nor JavaScript events
https://bugs.webkit.org/show_bug.cgi?id=112010
Reviewed by Antti Koivisto.
- fast/regions/hover-and-js-in-visual-overflow-expected.html: Added.
- fast/regions/hover-and-js-in-visual-overflow.html: Added.
- 12:00 PM Changeset in webkit [159639] by
-
- 8 edits2 adds in trunk/Source/WebKit2
Hook up WebProcess-side of getOrEstablishIDBDatabaseMetadata
https://bugs.webkit.org/show_bug.cgi?id=124698
Reviewed by Anders Carlsson.
With this change the IDB API in WebKit2 using the DatabaseProcess finally does something observable:
window.indexedDB.open() sends an error to Javascript.
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata): Continue calling back to the
WebProcess with dummy data, but include the request ID for reference.
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
Add a new class that wraps a completion callback function and gives it a unique integer identifier.
It also allows for wrapping an abort callback function (in case a connection is lost, for example).
It is templated to flexibly handle any callback function signature.
- Shared/AsyncRequest.cpp: Added.
(WebKit::generateRequestID):
(WebKit::AsyncRequest::AsyncRequest):
(WebKit::AsyncRequest::~AsyncRequest):
(WebKit::AsyncRequest::setAbortHandler):
(WebKit::AsyncRequest::requestAborted):
(WebKit::AsyncRequest::clearAbortHandler):
- Shared/AsyncRequest.h: Added.
(WebKit::AsyncRequest::requestID):
(WebKit::AsyncRequest::requestCompleted):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata): Wrap the completion handler in an
AsyncRequest and save off the request for later use.
(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata): Send the results to the AsyncRequest.
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- 11:43 AM Changeset in webkit [159638] by
-
- 4 edits in trunk/Source/WebKit2
Move activeURL getter to PageLoadState
https://bugs.webkit.org/show_bug.cgi?id=124690
Reviewed by Tim Horton.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::activeURL):
- UIProcess/PageLoadState.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activeURL):
- 11:05 AM Changeset in webkit [159637] by
-
- 13 edits4 adds in trunk
Implement WebCrypto unwrapKey
https://bugs.webkit.org/show_bug.cgi?id=124725
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: crypto/subtle/aes-cbc-unwrap-failure.html
crypto/subtle/aes-cbc-unwrap-rsa.html
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
- bindings/js/JSCryptoAlgorithmDictionary.h:
Removed calls for wrap/unwrap parameter parsing, these are just the same as encrypt/decrypt.
- bindings/js/JSCryptoOperationData.cpp:
(WebCore::cryptoOperationDataFromJSValue):
- bindings/js/JSCryptoOperationData.h:
- crypto/CryptoKeySerialization.h:
More Vector<char> elimination.
- bindings/js/JSDOMPromise.cpp:
- bindings/js/JSDOMPromise.h:
Removed unneccessary copy constructor and assignment operator, they are no diffdrent
than compiler generated ones.
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::cryptoKeyUsagesFromJSValue): Minor style fixes.
(WebCore::JSSubtleCrypto::encrypt): Ditto.
(WebCore::JSSubtleCrypto::decrypt): Ditto.
(WebCore::JSSubtleCrypto::sign): Ditto.
(WebCore::JSSubtleCrypto::verify): Ditto.
(WebCore::JSSubtleCrypto::generateKey): Ditto.
(WebCore::importKey): Separated actual import operation and the parts that read
arguments from ExecState, and call the promise. Logically, this should be outside
of bindings code even, but JWK makes that quite challenging.
(WebCore::JSSubtleCrypto::importKey): This only does the more mundane arguments
and return parts now.
(WebCore::JSSubtleCrypto::exportKey): Minor style fixes.
(WebCore::JSSubtleCrypto::unwrapKey): Chain decrypt and import.
- crypto/CryptoAlgorithm.cpp:
(WebCore::CryptoAlgorithm::encryptForWrapKey):
(WebCore::CryptoAlgorithm::decryptForUnwrapKey):
- crypto/CryptoAlgorithm.h:
There are algorithms that expose wrap/unwrap, but not encrypt/decrypt. These will
override these new functions, and leave encrypt/decrypt to raise NOT_SUPPORTED_ERR.
- crypto/SubtleCrypto.idl: Added unwrapKey.
LayoutTests:
- crypto/subtle/aes-cbc-unwrap-failure-expected.txt: Added.
- crypto/subtle/aes-cbc-unwrap-failure.html: Added.
- crypto/subtle/aes-cbc-unwrap-rsa-expected.txt: Added.
- crypto/subtle/aes-cbc-unwrap-rsa.html: Added.
- 11:02 AM Changeset in webkit [159636] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r159633.
http://trac.webkit.org/changeset/159633
https://bugs.webkit.org/show_bug.cgi?id=124726
it broke 10 webkitpy tests (Requested by dino_ on #webkit).
- Scripts/webkitpy/style/checker.py:
(check_webkit_style_configuration):
(CheckerDispatcher.dispatch):
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.init):
(StyleProcessorConfiguration.write_style_error):
- 10:32 AM Changeset in webkit [159635] by
-
- 4 edits in trunk/Source/JavaScriptCore
[MIPS] Build fails since r159545.
https://bugs.webkit.org/show_bug.cgi?id=124716
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-11-21
Reviewed by Michael Saboff.
Add missing implementations in MacroAssembler and LLInt for MIPS.
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::sync):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::store8):
(JSC::MacroAssemblerMIPS::memoryFence):
- offlineasm/mips.rb:
- 10:21 AM Changeset in webkit [159634] by
-
- 5 edits in trunk/Source/WebKit2
Clean up WebKit2 initialization
https://bugs.webkit.org/show_bug.cgi?id=124696
Reviewed by Sam Weinig.
Call InitializeWebKit2() everywhere we need to do one-time
initialization in WebKit2, rather than having a hotch-potch
of init code.
- Shared/APIObject.cpp:
(API::Object::Object):
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm: Removed an unused #include.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::create):
- 9:44 AM Changeset in webkit [159633] by
-
- 2 edits in trunk/Tools
Remove the stderr_write attribute from StyleProcessorConfiguration.
https://bugs.webkit.org/show_bug.cgi?id=124703
Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-21
Reviewed by Brent Fulgham.
- Scripts/webkitpy/style/checker.py:
(check_webkit_style_configuration):
(CheckerDispatcher.dispatch):
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.init):
(StyleProcessorConfiguration.write_style_error):
- 9:43 AM Changeset in webkit [159632] by
-
- 2 edits in trunk/Source/WebCore
[curl]Improve ssl certificate storage and check
https://bugs.webkit.org/show_bug.cgi?id=124569
Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2013-11-21
Reviewed by Brent Fulgham.
Storage and check the whole certificate chain, not just the root certificate.
- platform/network/curl/SSLHandle.cpp:
(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::pemData):
(WebCore::certVerifyCallback):
- 9:41 AM Changeset in webkit [159631] by
-
- 21 edits in trunk/Source/WebKit2
Reverted r159603, as it appears to have caused Safari’s Web processes to crash on launch.
Requested by Sam Weinig.
- Scripts/webkit2/messages.py:
(struct_or_class):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- Shared/mac/ObjCObjectGraphCoders.h:
- Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::ObjCObjectGraphEncoder::baseEncode):
(WebKit::WebContextObjCObjectGraphEncoderImpl::WebContextObjCObjectGraphEncoderImpl):
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode):
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):
(WebKit::WebContextObjCObjectGraphEncoder::WebContextObjCObjectGraphEncoder):
(WebKit::WebContextObjCObjectGraphEncoder::encode):
- UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::encodeMessageBody):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
- UIProcess/WebPageGroup.cpp:
- UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::postMessageToInjectedBundle):
(WebKit::WebPageProxy::initializeCreationParameters):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::createWebPage):
- UIProcess/WebProcessProxy.h:
- WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webPageGroup):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 9:36 AM Changeset in webkit [159630] by
-
- 15 edits in trunk/Source
[WinCairo] Building ANGLE libraries fails.
https://bugs.webkit.org/show_bug.cgi?id=124679
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-21
Reviewed by Brent Fulgham.
Source/ThirdParty/ANGLE:
Added/removed files to/from project, and re-added constants.h file.
- ANGLE.vcxproj/libEGL.vcxproj:
- ANGLE.vcxproj/libEGL.vcxproj.filters:
- ANGLE.vcxproj/libGLESv2.vcxproj:
- ANGLE.vcxproj/libGLESv2.vcxproj.filters:
- ANGLE.vcxproj/libGLESv2Common.props:
- ANGLE.vcxproj/translator_common.vcxproj:
- ANGLE.vcxproj/translator_common.vcxproj.filters:
- ANGLE.vcxproj/translator_glsl.vcxproj:
- ANGLE.vcxproj/translator_glsl.vcxproj.filters:
- ANGLE.vcxproj/translator_hlsl.vcxproj:
- ANGLE.vcxproj/translator_hlsl.vcxproj.filters:
- src/libGLESv2/libGLESv2.def:
Source/WebKit:
- WebKit.vcxproj/WebKit/WebKitCFLite.props: Link with translator_hlsl.lib.
- 9:11 AM Changeset in webkit [159629] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix sh4 build after r159545.
https://bugs.webkit.org/show_bug.cgi?id=124713
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-21
Reviewed by Michael Saboff.
Add missing implementations in macro assembler and LLINT for sh4.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::store8):
(JSC::MacroAssemblerSH4::memoryFence):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::synco):
- offlineasm/sh4.rb: Handle "memfence" opcode.
- 8:50 AM Changeset in webkit [159628] by
-
- 1 edit4 adds in trunk/LayoutTests
Added test for the overflow of a region being painted across multiple tiles.
Added test for correct repainting of a region's overflow.
[CSS Regions] Overflow areas from regions do not redraw
https://bugs.webkit.org/show_bug.cgi?id=117329
Reviewed by Antti Koivisto.
- fast/regions/regions-overflow-tile-expected.html: Added.
- fast/regions/regions-overflow-tile.html: Added.
- fast/repaint/repaint-regions-overflow-expected.txt: Added.
- fast/repaint/repaint-regions-overflow.html: Added.
- 8:48 AM WebKitGTK/Debugging edited by
- (diff)
- 8:45 AM WebKitGTK/Debugging edited by
- (diff)
- 8:44 AM WebKitGTK/Debugging edited by
- (diff)
- 8:13 AM BuildingGtk edited by
- (diff)
- 8:12 AM BuildingGtk edited by
- (diff)
- 8:12 AM BuildingGtk edited by
- (diff)
- 8:11 AM BuildingGtk edited by
- (diff)
- 8:00 AM WebKitGTK/StartHacking edited by
- (diff)
- 7:43 AM Changeset in webkit [159627] by
-
- 1 edit2 adds in trunk/LayoutTests
[CSS Regions] Float get sliced if its container has forced break and is less tall than float
https://bugs.webkit.org/show_bug.cgi?id=124205
Added test for the case when a float is overflowing a region due to a forced break.
Reviewed by Antti Koivisto.
- fast/regions/float-slicing-on-forced-break-expected.html: Added.
- fast/regions/float-slicing-on-forced-break.html: Added.
- 7:17 AM Changeset in webkit [159626] by
-
- 3 edits2 adds in trunk
Fix hover area for divs with css transforms
https://bugs.webkit.org/show_bug.cgi?id=124647
Patch by Mihai Maerean <Mihai Maerean> on 2013-11-21
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
Non transformed layers are now being hit last, not through or in-between transformed layers.
The paint order says that the divs creating stacking contexts (including transforms) are painted after the
other siblings so they should be hit tested in the reverse order. Also, a rotated div in a non-rotated parent
should be hit in its entire area, not hit its parent's background, even if the z-coordinate is negative where
the mouse is located.
Test: transforms/3d/hit-testing/hover-rotated-negative-z.html
- rendering/RenderLayer.cpp:
(WebCore::computeZOffset):
LayoutTests:
- transforms/3d/hit-testing/hover-rotated-negative-z.html: Added.
- transforms/3d/hit-testing/hover-rotated-negative-z-expected.txt: Added.
- 6:58 AM Changeset in webkit [159625] by
-
- 1 edit2 adds in trunk/LayoutTests
Created test for positioned fragmented content which overflows the regions.
[CSS Regions] Fragmented content that is relatively positioned get sliced (and overflows in the next region)
https://bugs.webkit.org/show_bug.cgi?id=117122
Reviewed by Antti Koivisto.
- fast/regions/positioned-fragmented-content-expected.html: Added.
- fast/regions/positioned-fragmented-content.html: Added.
- 6:57 AM Changeset in webkit [159624] by
-
- 1 edit2 adds in trunk/LayoutTests
Added test for visual overflow with transformed content in regions.
[CSS Regions] Transform applied to content node causes overflow to be hidden
https://bugs.webkit.org/show_bug.cgi?id=116242
Reviewed by Antti Koivisto.
- fast/regions/region-visual-overflow-transform-expected.html: Added.
- fast/regions/region-visual-overflow-transform.html: Added.
- 6:53 AM Changeset in webkit [159623] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Release compilation fails when defining "LOG_DISABLED=0"
https://bugs.webkit.org/show_bug.cgi?id=124661
Patch by Andres Gomez <Andres Gomez> on 2013-11-21
Reviewed by Mario Sanchez Prada.
In a "Debug" build the CString.h header comes from another
indirect dependency. Now, we explicitly add this missing include.
- html/HTMLTrackElement.cpp: Explicitly adding missing include.
- 6:52 AM Changeset in webkit [159622] by
-
- 2 edits in trunk/LayoutTests
[EFL] Fix accessibility media-element expectation
https://bugs.webkit.org/show_bug.cgi?id=124711
Unreviewed EFL gardening.
Changing main element AXRole AXUnknown -> AXEmbedded.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-11-21
- platform/efl/accessibility/media-element-expected.txt:
- 6:25 AM Changeset in webkit [159621] by
-
- 5 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Update baselines after r159575.
- platform/efl/fast/block/float/024-expected.txt:
- platform/efl/fast/block/margin-collapse/025-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
- 5:52 AM Changeset in webkit [159620] by
-
- 3 edits2 adds in trunk
Fix Range.insertNode when the inserted node is in the same container as the Range
https://bugs.webkit.org/show_bug.cgi?id=123957
Reviewed by Antti Koivisto.
Source/WebCore:
Inspired by https://chromium.googlesource.com/chromium/blink/+/fb6ca1f488703e8d4f20ce6449cc8ea210be6edb
When a node from the same container is inserted, we can't simply adjust m_end with the offset.
Compute m_start and m_end from the inserted nodes instead.
Also, don't adjust m_start and m_end to nodes outside of the document if the inserted nodes had been
removed by mutation events.
Test: fast/dom/Range/range-insertNode-same-container.html
- dom/Range.cpp:
(WebCore::Range::insertNode):
LayoutTests:
Merge https://chromium.googlesource.com/chromium/blink/+/fb6ca1f488703e8d4f20ce6449cc8ea210be6edb
Used better labels between divs, and added more evalAndLog and shouldBe so that
the expected result is self-explanatory.
- fast/dom/Range/range-insertNode-same-container-expected.txt: Added.
- fast/dom/Range/range-insertNode-same-container.html: Added.
- 5:46 AM Changeset in webkit [159619] by
-
- 4 edits2 adds in trunk
nextBoundary and previousBoundary are very slow when there is a password field
https://bugs.webkit.org/show_bug.cgi?id=123973
Reviewed by Antti Koivisto.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/57366eec5e3edea54062d4e74c0e047f8681dbad
When iterating through DOM nodes nextBoundary and previousBoundary convert the contents of nodes using
text security to a sequence of 'x' characters. The SimplifiedBackwardsTextIterator and TextIterator
may iterate past node boundaries. Before this patch, the transformation was done looking at the starting
node rather than the current node. In some situations, this replaced all boundaries with 'x' and caused
the text iterator to continue iterating and transforming until the extent of the document.
Test: editing/deleting/password-delete-performance.html
- editing/TextIterator.h:
(WebCore::SimplifiedBackwardsTextIterator::node):
- editing/VisibleUnits.cpp:
(WebCore::previousBoundary):
(WebCore::nextBoundary):
LayoutTests:
- editing/deleting/password-delete-performance-expected.txt: Added.
- editing/deleting/password-delete-performance.html: Added.
- 5:43 AM Changeset in webkit [159618] by
-
- 3 edits2 adds in trunk
HTML parser should not associate elements inside templates with forms
https://bugs.webkit.org/show_bug.cgi?id=117779
Reviewed by Antti Koivisto.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/45aadf7ee7ee010327eb692066cf013315ef3ed7
When parsing <form><template><input>, the previous behavior was to associate the <input> with the <form>,
even though they're not in the same tree (or even the same document).
This patch changes that by checking, prior to creating a form control element, whether the element to be
created lives in a document with a browsing context.
We don't update m_form as needed to faithfully match the HTML5 specification's form element pointer
http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#form-element-pointer
and its algorithm for creating and inserting nodes:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#creating-and-inserting-nodes
While this leaves isindex's reference to form element pointer stale:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#isindex
The HTML5 specification matches the behaviors of Chrome and Firefox so we leave it as is.
Test: fast/dom/HTMLTemplateElement/no-form-association.html
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElement):
LayoutTests:
- fast/dom/HTMLTemplateElement/no-form-association-expected.txt: Added.
- fast/dom/HTMLTemplateElement/no-form-association.html: Added.
- 5:22 AM Changeset in webkit [159617] by
-
- 4 edits in trunk/Tools
PerfTestRunner._generate_results_dict shouldn't depend on test objects
https://bugs.webkit.org/show_bug.cgi?id=124623
Removed the dependency on test objects from results JSON generation.
This allows single test.run to return metrics for multiple tests
Reviewed by Antti Koivisto.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTestMetric.init): Takes the test path and test name.
(PerfTestMetric.path): Added.
(PerfTestMetric.test_file_name): Added.
(PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
(PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
The path is going to have the names of subtests at the end once we support them.
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
(TestPerfTestMetric.test_init_set_time_metric): Ditto.
(TestPerfTestMetric.test_has_values): Ditto.
(TestPerfTestMetric.test_append): Ditto.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(_generate_results_dict): Only use metrics.
(_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
- 4:56 AM WebKitGTK/StartHacking edited by
- (diff)
- 4:26 AM Changeset in webkit [159616] by
-
- 2 edits in trunk/Tools
REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
https://bugs.webkit.org/show_bug.cgi?id=124697
Reviewed by Ryosuke Niwa.
- Scripts/webkitdirs.pm:
(checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
before trying to access to the first element.
- 12:52 AM Changeset in webkit [159615] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Cannot scroll in option menu when it larger than the screen
https://bugs.webkit.org/show_bug.cgi?id=124671
Reviewed by Martin Robinson.
The problem is that the popup menu is not resized to fit in the
screen, so it doesn't scroll and some of the items are offscreen
so they can't be selected either. GTK+ automatically resizes the
popup menus to fit in the work area, but only when the menu is
already positioned.
- platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::popUp): Schedule a resize of the popup
menu right after showing it once it has a position.
- 12:38 AM Changeset in webkit [159614] by
-
- 12 edits3 copies in trunk
[GTK] Mark all deprecated symbols in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=124406
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Move deprecated API from WebKitDOMCustom to a new file
WebKitDOMDeprecated leaving in WebKitDOMCustom only the
non-deprecated API that is not autogenerated. Also added the
deprecation decorations and tags in the documentation.
- bindings/gobject/GNUmakefile.am:
- bindings/gobject/WebKitDOMCustom.cpp:
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols:
- bindings/gobject/WebKitDOMDeprecated.cpp: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp.
(webkit_dom_blob_webkit_slice):
(webkit_dom_html_element_get_id):
(webkit_dom_html_element_set_id):
(webkit_dom_html_element_get_class_name):
(webkit_dom_html_element_set_class_name):
(webkit_dom_html_element_get_class_list):
(webkit_dom_html_form_element_dispatch_form_change):
(webkit_dom_html_form_element_dispatch_form_input):
(webkit_dom_webkit_named_flow_get_overflow):
(webkit_dom_element_get_webkit_region_overflow):
(webkit_dom_webkit_named_flow_get_content_nodes):
(webkit_dom_webkit_named_flow_get_regions_by_content_node):
(webkit_dom_bar_info_get_property):
(webkit_dom_bar_info_class_init):
(webkit_dom_bar_info_init):
(webkit_dom_bar_info_get_visible):
(webkit_dom_console_get_memory):
(webkit_dom_css_style_declaration_get_property_css_value):
(webkit_dom_document_get_webkit_hidden):
(webkit_dom_document_get_webkit_visibility_state):
(webkit_dom_html_document_open):
(webkit_dom_html_element_set_item_id):
(webkit_dom_html_element_get_item_id):
(webkit_dom_html_element_get_item_ref):
(webkit_dom_html_element_get_item_prop):
(webkit_dom_html_element_set_item_scope):
(webkit_dom_html_element_get_item_scope):
(webkit_dom_html_element_get_item_type):
(webkit_dom_html_style_element_set_scoped):
(webkit_dom_html_style_element_get_scoped):
(webkit_dom_html_properties_collection_get_property):
(webkit_dom_html_properties_collection_class_init):
(webkit_dom_html_properties_collection_init):
(webkit_dom_html_properties_collection_item):
(webkit_dom_html_properties_collection_named_item):
(webkit_dom_html_properties_collection_get_length):
(webkit_dom_html_properties_collection_get_names):
(webkit_dom_node_get_attributes):
(webkit_dom_node_has_attributes):
(webkit_dom_memory_info_get_property):
(webkit_dom_memory_info_class_init):
(webkit_dom_memory_info_init):
(webkit_dom_memory_info_get_total_js_heap_size):
(webkit_dom_memory_info_get_used_js_heap_size):
(webkit_dom_memory_info_get_js_heap_size_limit):
(webkit_dom_micro_data_item_value_class_init):
(webkit_dom_micro_data_item_value_init):
(webkit_dom_performance_get_memory):
(webkit_dom_property_node_list_get_property):
(webkit_dom_property_node_list_class_init):
(webkit_dom_property_node_list_init):
(webkit_dom_property_node_list_item):
(webkit_dom_property_node_list_get_length):
(webkit_dom_html_media_element_get_start_time):
(webkit_dom_html_media_element_get_initial_time):
(webkit_dom_html_head_element_get_profile):
(webkit_dom_html_head_element_set_profile):
(webkit_dom_processing_instruction_get_data):
(webkit_dom_processing_instruction_set_data):
- bindings/gobject/WebKitDOMDeprecated.h: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.h.
- bindings/gobject/WebKitDOMDeprecated.symbols: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.symbols.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction): Do not include deprecation guards in the cpp file.
- bindings/scripts/gobject-generate-headers.pl: Do not create
fordward declarations for non-existent classes like Custom and
Deprecated.
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(webkit_dom_test_event_target_dispatch_event):
Tools:
- Scripts/webkitpy/style/checker.py: Add special case for
WebKitDOMDeprecated.
- gtk/generate-gtkdoc:
(get_webkit2_options): Use the prefix of the methods as namespace,
since this is what gtkdoc expects to sort the index.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Ditto.
- gtk/generate-webkitdom-doc-files:
(WebKitDOMDocGenerator): Add a global list of deleted objects.
(WebKitDOMDocGenerator.write_deleted_classes): New method to write
the documentation for classes that are deprecated because they
have been removed.
(WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
for deleted classes too.
(WebKitDOMDocGeneratorSections.init): Build a list of
deprecated symbols using the given symbols file.
(WebKitDOMDocGeneratorSections._deleted_class): Returns the
deleted class corresponding to the given function.
(WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
dictionary of deprecated symbols for every class.
(WebKitDOMDocGeneratorSections.write_section): Add also the
deprecated symbols in every section.
(WebKitDOMDocGeneratorSections.write_deleted_classes): Add
sections for deleted classes too.