Timeline



Mar 6, 2017:

11:38 PM Changeset in webkit [213506] by sbarati@apple.com
  • 7 edits
    1 add in trunk

WebAssembly: Implement the WebAssembly.instantiate API
​https://bugs.webkit.org/show_bug.cgi?id=165982
<rdar://problem/29760110>

Reviewed by Keith Miller.

JSTests:

  • wasm/js-api/web-assembly-instantiate.js: Added.

(assert.eq.async.test):
(assert.eq):
(assert.truthy.async.test):
(assert.truthy):

Source/JavaScriptCore:

This patch is a straight forward implementation of the WebAssembly.instantiate
API: ​https://github.com/WebAssembly/design/blob/master/JS.md#webassemblyinstantiate

I implemented the API in a synchronous manner. We should make it
asynchronous: ​https://bugs.webkit.org/show_bug.cgi?id=169187

  • wasm/JSWebAssembly.cpp:

(JSC::webAssemblyCompileFunc):
(JSC::webAssemblyInstantiateFunc):
(JSC::JSWebAssembly::finishCreation):

  • wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):
(JSC::WebAssemblyInstanceConstructor::createInstance):

  • wasm/js/WebAssemblyInstanceConstructor.h:
  • wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::constructJSWebAssemblyModule):
(JSC::WebAssemblyModuleConstructor::createModule):

  • wasm/js/WebAssemblyModuleConstructor.h:
11:30 PM Changeset in webkit [213505] by mmaxfield@apple.com
  • 6 edits
    2 adds in trunk

Apply well-known-axis variation values at the right time in preparePlatformFont()
​https://bugs.webkit.org/show_bug.cgi?id=168896

Reviewed by Jon Lee.

Source/WebCore:

Simply plumb the FontSelectionRequest to the place where font variations are implemented.

Test: fast/text/variations/font-selection-properties.html

  • platform/graphics/FontCache.h:
  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::systemFallbackForCharacters):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

LayoutTests:

  • fast/text/variations/font-selection-properties-expected.html: Added.
  • fast/text/variations/font-selection-properties.html: Added.
11:19 PM Changeset in webkit [213504] by aakash_jain@apple.com
  • 4 edits in trunk/Source/WebKit2

Enable SUPPORTS_TEXT_BASED_API in WebKit2 for iOS
​https://bugs.webkit.org/show_bug.cgi?id=169233

Reviewed by Alexey Proskuryakov.

  • Configurations/Base.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
  • Configurations/WebKit.xcconfig: Pass information to TAPI about reexporting WebKitLegacy and few extra headers.
  • WebKit2.xcodeproj/project.pbxproj: Run scripts which are run for installhdrs phase for installapi phase as well.
11:01 PM Changeset in webkit [213503] by Yusuke Suzuki
  • 2 edits in trunk/Tools

Add Fujii Hironori to contributor's list
​https://bugs.webkit.org/show_bug.cgi?id=169261

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-06
Reviewed by Yusuke Suzuki.

Add myself to the contributor's lists so that my e-mail autocompletes for CC

  • Scripts/webkitpy/common/config/contributors.json:
10:24 PM Changeset in webkit [213502] by mmaxfield@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed post-review fixup after r213464
​https://bugs.webkit.org/show_bug.cgi?id=169255

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::computeHash):
(WebCore::FontDescriptionKey::makeFlagsKey):

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::computeNecessarySynthesis):

10:10 PM Changeset in webkit [213501] by Brent Fulgham
  • 3 edits
    2 adds in trunk

Validate DOM after potentially destructive actions during parser insert operations
​https://bugs.webkit.org/show_bug.cgi?id=169222
<rdar://problem/30689729>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Do not perform an insert operation if the next child's parent is no longer
part of the tree. This can happen if JavaScript runs during node removal
events and modifies the contents of the document.

This patch was inspired by a similar Blink change by Marius Mlynski:
<​https://src.chromium.org/viewvc/blink?view=revision&revision=200690>

Tests: fast/parser/scriptexec-during-parserInsertBefore.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::executeReparentTask):
(WebCore::executeInsertAlreadyParsedChildTask):

LayoutTests:

This change merges a Blink test case from:
<​https://src.chromium.org/viewvc/blink?view=revision&revision=200690>

  • fast/parser/scriptexec-during-parserInsertBefore-expected.txt: Added.
  • fast/parser/scriptexec-during-parserInsertBefore.html: Added.
9:44 PM Changeset in webkit [213500] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Unreviewed build fix to add
-isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
for objective C++ files.

  • Configurations/WebKitLegacy.xcconfig:
9:37 PM Changeset in webkit [213499] by mmaxfield@apple.com
  • 6 edits in trunk

Update isEmojiGroupCandidate() to the latest version of Unicode
​https://bugs.webkit.org/show_bug.cgi?id=168198

Reviewed by Jon Lee.

Source/WebCore:

In the latest version of Unicode, many more code points are candidates for emoji groups.
Therefore, isEmojiGroupCandidate() should be made more permissive. This way, the function
is more future-proof.

Test: editing/deleting/delete-emoji.html

  • platform/text/CharacterProperties.h:

(WebCore::icuLibraryUnderstandsSupplementalSymbolsAndPictographs):
(WebCore::isEmojiGroupCandidate):

LayoutTests:

  • platform/ios-simulator/editing/deleting/delete-emoji-expected.txt:
  • platform/mac/editing/deleting/delete-emoji-expected.txt:
  • editing/deleting/delete-emoji.html:
9:15 PM Changeset in webkit [213498] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Expose API::InjectedBundle::EditorClient::didChange via the Objective-C bundle SPI
​https://bugs.webkit.org/show_bug.cgi?id=169223

Reviewed by Tim Horton.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h: Declared new delegate method -_webProcessPlugInBrowserContextControllerDidChangeByEditing:.
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]): Added an override

of API::InjectedBundle::EditorClient::didChange that calls the new delegate method.

8:44 PM Changeset in webkit [213497] by commit-queue@webkit.org
  • 3 edits in trunk/Source/ThirdParty/libwebrtc

Bring back WebKit specific changes to disable temporarily libwebrtc video adaptation
​https://bugs.webkit.org/show_bug.cgi?id=169229

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-06
Reviewed by Alex Christensen.

  • Source/webrtc/modules/video_coding/video_sender.cc: disabling frame dropping.
  • Source/webrtc/video/vie_encoder.cc: disabling resolution decrease based on CPU overuse.
8:39 PM Changeset in webkit [213496] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r213492.

  • Configurations/Base.xcconfig:
8:22 PM Changeset in webkit [213495] by aakash_jain@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WK_CLASS_AVAILABLE to _WKLinkIconParameters and _WKWebViewPrintFormatter
​https://bugs.webkit.org/show_bug.cgi?id=169225

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/_WKLinkIconParameters.h:
  • UIProcess/_WKWebViewPrintFormatter.h:
8:21 PM Changeset in webkit [213494] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use default configuration for libwebrtc peerconnection
​https://bugs.webkit.org/show_bug.cgi?id=169239

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-06
Reviewed by Alex Christensen.

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::configurationFromMediaEndpointConfiguration): Using the default configuration instead of the aggressive one.

8:17 PM Changeset in webkit [213493] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMake] SN-DBS fails to build: Cannot open include file: 'WebCoreTestSupportPrefix.h'
​https://bugs.webkit.org/show_bug.cgi?id=169244

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-06
Reviewed by Alex Christensen.

A distributed build system SN-DBS can not find
WebCoreTestSupportPrefix.h without an include path to it.

  • CMakeLists.txt: Add 'WebCore/testing/js' to include paths.
7:37 PM Changeset in webkit [213492] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r213483.

  • Configurations/Base.xcconfig:
7:11 PM Changeset in webkit [213491] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[cairo] error C2065: 'quality': undeclared identifier since r213412
​https://bugs.webkit.org/show_bug.cgi?id=169240

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-06
Reviewed by Ryosuke Niwa.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::toDataURL): Name the unnamed second argument 'quality'.

7:09 PM Changeset in webkit [213490] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

[Mac][WK2] Support new CoreMedia routing features
​https://bugs.webkit.org/show_bug.cgi?id=169241
<rdar://problem/30077969>

Reviewed by Alexey Proskuryakov.

  • WebProcess/com.apple.WebProcess.sb.in:
6:56 PM Changeset in webkit [213489] by jiewen_tan@apple.com
  • 19 edits
    6 copies
    15 adds in trunk

[WebCrypto] Implement ECDH GenerateKey operation
​https://bugs.webkit.org/show_bug.cgi?id=169093
<rdar://problem/23789585>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

  • web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/successes_ECDH.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDH-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDH-expected.txt:

Source/WebCore:

This patch implements GenerateKey operation of ECDH according to:
​https://www.w3.org/TR/WebCryptoAPI/#ecdh-operations.
Note: Sad that we are not able to support P-521 at this moment due
to lack of necessary support in the underlying crypto library.

Tests: crypto/subtle/ec-generate-key-malformed-parameters.html

crypto/subtle/ecdh-generate-key-extractable.html
crypto/subtle/ecdh-generate-key-p256.html
crypto/subtle/ecdh-generate-key-p384.html
crypto/subtle/ecdh-generate-key-single-usage.html
crypto/workers/subtle/ec-generate-key.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCryptoKeyCustom.cpp:

(WebCore::JSCryptoKey::algorithm):

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::jsSubtleCryptoFunctionGenerateKeyPromise):
Add support for ECDH.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):
Structured clonable will be added later on.

  • crypto/CommonCryptoUtilities.h:

Add SPI for EC.

  • crypto/CryptoAlgorithmParameters.h:
  • crypto/CryptoKey.h:
  • crypto/algorithms/CryptoAlgorithmECDH.cpp: Added.

(WebCore::CryptoAlgorithmECDH::create):
(WebCore::CryptoAlgorithmECDH::identifier):
(WebCore::CryptoAlgorithmECDH::generateKey):

  • crypto/algorithms/CryptoAlgorithmECDH.h: Added.
  • crypto/gnutls/CryptoKeyECGnuTLS.cpp: Added.

(WebCore::CryptoKeyEC::~CryptoKeyEC):
(WebCore::CryptoKeyEC::platformGeneratePair):

  • crypto/keys/CryptoKeyEC.cpp: Added.

(WebCore::CryptoKeyEC::CryptoKeyEC):
(WebCore::CryptoKeyEC::generatePair):
(WebCore::CryptoKeyEC::buildAlgorithm):
(WebCore::CryptoKeyEC::exportData):

  • crypto/keys/CryptoKeyEC.h: Added.

(WebCore::EcKeyAlgorithm::EcKeyAlgorithm):
(WebCore::EcKeyAlgorithm::namedCurve):

  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Add support for ECDH.

  • crypto/mac/CryptoKeyECMac.cpp: Added.

(WebCore::CryptoKeyEC::~CryptoKeyEC):
(WebCore::CryptoKeyEC::platformGeneratePair):

  • crypto/parameters/CryptoAlgorithmEcKeyParams.h: Added.
  • crypto/parameters/EcKeyParams.idl: Added.

LayoutTests:

  • crypto/subtle/ec-generate-key-malformed-parameters-expected.txt: Added.
  • crypto/subtle/ec-generate-key-malformed-parameters.html: Added.
  • crypto/subtle/ecdh-generate-key-extractable-expected.txt: Added.
  • crypto/subtle/ecdh-generate-key-extractable.html: Added.
  • crypto/subtle/ecdh-generate-key-p256-expected.txt: Added.
  • crypto/subtle/ecdh-generate-key-p256.html: Added.
  • crypto/subtle/ecdh-generate-key-p384-expected.txt: Added.
  • crypto/subtle/ecdh-generate-key-p384.html: Added.
  • crypto/subtle/ecdh-generate-key-single-usage-expected.txt: Added.
  • crypto/subtle/ecdh-generate-key-single-usage.html: Added.
  • crypto/workers/subtle/ec-generate-key-expected.txt: Added.
  • crypto/workers/subtle/ec-generate-key.html: Added.
  • crypto/workers/subtle/resources/ec-generate-key.js: Added.
6:54 PM Changeset in webkit [213488] by jmarcell@apple.com
  • 6 edits in tags/Safari-604.1.8.1.2/Source

Versioning.

6:46 PM Changeset in webkit [213487] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.8.1.2

Tag Safari-604.1.8.1.2.

6:32 PM Changeset in webkit [213486] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix unused parameter warning after r213464

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):

6:31 PM Changeset in webkit [213485] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] Mark WTF_Lock.ContendedLongSection and WTF_WordLock.ContendedLongSection as slow.

Unreviewed test gardening.

The ContendedShortSection version of this tests were already marked as slow.
And the ContendedLongSection version takes more or less the same time to run.
They cause time outs on the bot sometimes.

  • Scripts/run-gtk-tests:

(TestRunner):

6:10 PM Changeset in webkit [213484] by sbarati@apple.com
  • 2 edits in trunk/JSTests

Unreviewed. Fix test expected error message.

  • wasm/js-api/element.js:

(assert.throws):

5:51 PM Changeset in webkit [213483] by msaboff@apple.com
  • 18 edits in trunk

Take advantage of fast permissions switching of JIT memory for devices that support it
​https://bugs.webkit.org/show_bug.cgi?id=169155

Reviewed by Saam Barati.

Source/JavaScriptCore:

Start using the os_thread_self_restrict_rwx_to_XX() SPIs when available to
control access to JIT memory.

Had to update the Xcode config files to handle various build variations of
public and internal SDKs.

  • Configurations/Base.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • jit/ExecutableAllocator.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
(JSC::FixedVMPoolExecutableAllocator::initializeSeparatedWXHeaps):

  • jit/ExecutableAllocator.h:

(JSC::performJITMemcpy):

Source/WebCore:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

  • Configurations/Base.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/WebCore.xcconfig:

Source/WebCore/PAL:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
5:39 PM Changeset in webkit [213482] by aakash_jain@apple.com
  • 4 edits in trunk/Source

Make WKMenuItemIdentifiersPrivate.h private header
​https://bugs.webkit.org/show_bug.cgi?id=168981

Reviewed by Tim Horton.

Source/WebCore:

  • platform/spi/mac/NSMenuSPI.h: NSUserInterfaceItemIdentification is in the public header in recent SDKs.

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj: Made WKMenuItemIdentifiersPrivate.h private.
5:39 PM Changeset in webkit [213481] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Replace -sub_umbrella linker flag with a build setting
​https://bugs.webkit.org/show_bug.cgi?id=169146

Reviewed by Tim Horton.

  • Configurations/WebKit.xcconfig:
5:29 PM Changeset in webkit [213480] by hyatt@apple.com
  • 22 edits
    2 adds in trunk

REGRESSION: Block no longer shrinks to preferred width in this flex box layout
​https://bugs.webkit.org/show_bug.cgi?id=169203
<rdar://problem/30873895>

Reviewed by Simon Fraser.

Source/WebCore:

Added new test in css3/flexbox.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustStyleForAlignment):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::resolveCustomStyle):
Resolve auto alignment values by adjusting the render style as needed. Make a helper
function for adjusting only alignment that can be called from the inner text control
custom style creation.

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild):
Replaced items in grids should not stretch by default.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::hasStretchedLogicalWidth):
Patched to properly check the default alignment for the child, making sure
that if it's a replacd item inside a grid, that the default is start and not
stretch.

  • rendering/RenderBox.h:

(WebCore::RenderBox::selfAlignmentNormalBehavior):
Self-alignment function now takes an optional child argument, since the behavior
varies in grids depending on the child being replaced or not.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignmentForChild):
Fixed to do the right thing when the child is anonymous.

(WebCore::RenderFlexibleBox::styleDidChange): Deleted.

  • rendering/RenderFlexibleBox.h:

Deleted, since alignment changes are handled at the style diff level now.

  • rendering/RenderFullScreen.h:

Patched the selfAlignmentNormalBehavior method to take an optional child argument.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::styleDidChange):
(WebCore::RenderGrid::alignSelfForChild):
(WebCore::RenderGrid::justifySelfForChild):
(WebCore::RenderGrid::columnAxisPositionForChild):
(WebCore::RenderGrid::rowAxisPositionForChild):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
(WebCore::defaultAlignmentIsStretch): Deleted.
(WebCore::defaultAlignmentChangedToStretchInRowAxis): Deleted.
(WebCore::defaultAlignmentChangedFromStretchInRowAxis): Deleted.
(WebCore::defaultAlignmentChangedFromStretchInColumnAxis): Deleted.
(WebCore::selfAlignmentChangedToStretchInRowAxis): Deleted.
(WebCore::selfAlignmentChangedFromStretchInRowAxis): Deleted.
(WebCore::selfAlignmentChangedFromStretchInColumnAxis): Deleted.

  • rendering/RenderGrid.h:

Removed the alignment change logic in styleDidChange for grids, since style diffing handles
it now. Updated all selfAlignmentForNormalBehavior queries to pass in the child so that
replaced elements are handled properly.

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::overflowInlineDirection):
(WebCore::RenderStyle::overflowBlockDirection):
(WebCore::RenderStyle::setJustifySelfPosition):
New helpers used by grid and by adjustRenderStyle.

  • style/StyleChange.cpp:

(WebCore::Style::determineChange):
If alignment or justification changes occur on a parent that could affect the child (e.g., align-items)
return Inherit so the child render styles get adjusted properly.

LayoutTests:

  • css3/flexbox/column-inside-normal-block-preferred-width-expected.html: Added.
  • css3/flexbox/column-inside-normal-block-preferred-width.html: Added.
  • fast/css-grid-layout/grid-align-stretching-replaced-items-expected.txt:
  • fast/css-grid-layout/grid-align-stretching-replaced-items.html:
  • fast/repaint/align-items-change-expected.txt:
  • fast/repaint/align-items-overflow-change-expected.txt:
  • fast/repaint/justify-items-change-expected.txt:
  • fast/repaint/justify-items-legacy-change-expected.txt:
  • fast/repaint/justify-items-overflow-change-expected.txt:
4:20 PM Changeset in webkit [213479] by Lucas Forschler
  • 2 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=169234
torchmobile.com.cn is no longer a registered domain. These email addresses will bounce, so clean them up.

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/config/contributors.json:
4:09 PM Changeset in webkit [213478] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

ASSERTION FAILED: numberOfChannels == 2 in WebCore::RealtimeIncomingAudioSource::OnData
​https://bugs.webkit.org/show_bug.cgi?id=169224
<rdar://problem/30856811>

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-06
Reviewed by Alex Christensen.

  • platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::OnData): Updated assertion to allow 1 channel since we can handle it as well.

3:38 PM Changeset in webkit [213477] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark inspector/worker/console-basic.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169228

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:33 PM Changeset in webkit [213476] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark scrollingcoordinator/ios/non-stable-viewport-scroll.html as flaky on ios-simulator.
​https://bugs.webkit.org/show_bug.cgi?id=168924

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
3:29 PM Changeset in webkit [213475] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169159

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:24 PM Changeset in webkit [213474] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169158

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:07 PM Changeset in webkit [213473] by Chris Dumez
  • 9 edits
    2 adds in trunk

[iOS] Throttle CSS animations to 30fps in low power mode
​https://bugs.webkit.org/show_bug.cgi?id=169138
<rdar://problem/30837805>

Reviewed by Said Abou-Hallawa.

Source/WebCore:

Throttle software CSS animations to 30fps in low power mode on iOS
to save battery.

Test: fast/animation/css-animation-throttling-lowPowerMode.html

  • page/Page.cpp:

(WebCore::Page::handleLowModePowerChange):

  • page/animation/CSSAnimationController.cpp:

(WebCore::CSSAnimationControllerPrivate::CSSAnimationControllerPrivate):
(WebCore::CSSAnimationControllerPrivate::updateAnimationTimer):
(WebCore::CSSAnimationControllerPrivate::updateThrottlingState):
(WebCore::CSSAnimationControllerPrivate::animationInterval):
(WebCore::CSSAnimationControllerPrivate::beginAnimationUpdateTime):
(WebCore::CSSAnimationControllerPrivate::beginAnimationUpdate):
(WebCore::CSSAnimationController::updateThrottlingState):
(WebCore::CSSAnimationController::animationInterval):

  • page/animation/CSSAnimationController.h:
  • page/animation/CSSAnimationControllerPrivate.h:
  • testing/Internals.cpp:

(WebCore::Internals::animationsInterval):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Add layout test coverage.

  • fast/animation/css-animation-throttling-lowPowerMode-expected.txt: Added.
  • fast/animation/css-animation-throttling-lowPowerMode.html: Added.
3:07 PM Changeset in webkit [213472] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r212778): It made 400 tests crash on AArch64 Linux
​https://bugs.webkit.org/show_bug.cgi?id=168502

Reviewed by Filip Pizlo.

  • heap/RegisterState.h: Use setjmp code path on AArch64 Linux too to fix crashes.
3:06 PM Changeset in webkit [213471] by mrajca@apple.com
  • 7 edits in trunk

Media: notify clients when the user never plays a media element that was prevented from auto-playing
​https://bugs.webkit.org/show_bug.cgi?id=169150

Reviewed by Alex Christensen.

Source/WebCore:

Added API tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):

  • page/AutoplayEvent.h:

Source/WebKit2:

  • UIProcess/API/C/WKPageUIClient.h:

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(TEST): Added.

2:56 PM Changeset in webkit [213470] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Refactor ContentExtensionParser
​https://bugs.webkit.org/show_bug.cgi?id=169214

Reviewed by Brady Eidson.

No change in behavior, as verified by existing API tests.
This will make it easier to use getStringList for other things in coming patches.

  • contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::getStringList):
(WebCore::ContentExtensions::getDomainList):

2:55 PM Changeset in webkit [213469] by achristensen@apple.com
  • 11 edits in trunk

Fix URLs relative to file URLs with paths beginning with Windows drive letters
​https://bugs.webkit.org/show_bug.cgi?id=169178

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

  • web-platform-tests/url/a-element-expected.txt:
  • web-platform-tests/url/a-element-xhtml-expected.txt:
  • web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Windows drives in file URLs can begin with windows drive letters, such as ​file:///C:/
which should not be removed when making other URLs relative to them.
See ​https://url.spec.whatwg.org/#file-slash-state

Covered by new API tests and newly passing web-platform-tests.

  • platform/URLParser.cpp:

(WebCore::URLParser::copyBaseWindowsDriveLetter):
(WebCore::URLParser::copyASCIIStringUntil):
(WebCore::URLParser::parse):

  • platform/URLParser.h:

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

LayoutTests:

  • fast/url/relative-win-expected.txt:

Some tests pass now. localhost should indeed be removed according to the latest spec.

2:46 PM Changeset in webkit [213468] by achristensen@apple.com
  • 3 edits in trunk/Source/ThirdParty/libwebrtc

Fix Production libwebrtc build after r213418
​https://bugs.webkit.org/show_bug.cgi?id=169217
<rdar://problem/30876775>

Reviewed by Tim Horton.

  • Source/webrtc/base/checks.h:
  • libwebrtc.xcodeproj/project.pbxproj:

MakeCheckOpString was a weak export, and it wasn't needed.
There is an internal build that checks for weak exports and fails if there is one.
Run the check-for-weak-vtables-and-externals script for libwebrtc.dylib like we do for the other frameworks.

2:03 PM Changeset in webkit [213467] by commit-queue@webkit.org
  • 29 edits
    4 adds in trunk

op_get_by_id_with_this should use inline caching
​https://bugs.webkit.org/show_bug.cgi?id=162124

Patch by Caio Lima <Caio Lima> on 2017-03-06
Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/super-getter.js: Added.

(A.prototype.get f):
(A):
(B.prototype.get f):
(B):

  • stress/super-force-ic-fail.js: Added.

(let.assert):
(let.aObj.get foo):
(let.obj.jaz):
(let.bObj.get foo):
(let.obj2.foo):

  • stress/super-get-by-id.js: Added.

(assert):
(Base):
(Base.prototype.get name):
(Base.prototype.set name):
(Subclass.prototype.get name):
(Subclass):
(getterName):
(getterValue):
(PolymorphicSubclass.prototype.get value):
(PolymorphicSubclass):
(i.let.BaseCode):
(i.get value):
(MegamorphicSubclass.prototype.get value):
(MegamorphicSubclass):
(let.subObj.get value):
(i.catch):
(subObj.get value):
(BaseException):
(BaseException.prototype.get name):
(SubclassException.prototype.get name):
(SubclassException):
(prototype.foo):
(prototype.get name):
(SubclassExceptionComplex.prototype.get name):
(SubclassExceptionComplex):

  • stress/super-getter-reset-ic.js: Added.

(let.assert):
(let.B.f):

Source/JavaScriptCore:

This patch is enabling inline cache for op_get_by_id_with_this in all
tiers. It means that operations using super.member are going to
be able to be optimized by PIC. To enable it, we introduced a new
member of StructureStubInfo.patch named thisGPR, created a new class
to manage the IC named JITGetByIdWithThisGenerator and changed
PolymorphicAccess.regenerate that uses StructureStubInfo.patch.thisGPR
to decide the correct this value on inline caches.
With inline cached enabled, super.member are ~4.5x faster,
according microbenchmarks.

  • bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

  • bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

  • bytecode/PolymorphicAccess.h:
  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::reset):

  • bytecode/StructureStubInfo.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addGetByIdWithThis):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileIn):
(JSC::FTL::DFG::LowerDFGToB3::getByIdWithThis):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/ICStats.h:
  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::link):

  • jit/JIT.h:
  • jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):
(JSC::JITGetByIdWithThisGenerator::generateFastPath):

  • jit/JITInlineCacheGenerator.h:

(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_get_by_id_with_this):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_get_by_id_with_this):

  • jit/Repatch.cpp:

(JSC::appropriateOptimizingGetByIdFunction):
(JSC::appropriateGenericGetByIdFunction):
(JSC::tryCacheGetByID):

  • jit/Repatch.h:
  • jsc.cpp:

(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetterAcessor):

1:45 PM Changeset in webkit [213466] by Simon Fraser
  • 18 edits
    1 copy
    15 adds in trunk

Only use layer backing store which supports subpixel antialiased text if we know subpixel antialiased will be painted into it
​https://bugs.webkit.org/show_bug.cgi?id=169191

Reviewed by Zalan Bujtas.

Source/WebCore:

Instead of unconditionally calling setSupportsSubpixelAntialiasedText() on GraphicsLayers created
by RenderLayerBacking, only do so when we know (or suspect) that a layer contains smoothed text.

This is done by enhancing RenderLayer::isVisuallyNonEmpty() and RenderLayer::hasNonEmptyChildRenderers()
to take a PaintedContentRequest parameter, which allows the caller to specify what qualities of
the layer contents it is interested in. Most of the time, this is just any painted content, but on
platforms where GraphicsLayer::supportsSubpixelAntialiasedLayerText() returns true, the query also
asks about whether the layer will contain subpixel-antialiased text. In this case, it can't early
return as soon as painted content is found; it must keep iterating renderers while all the query
requests are unsatisfied, or until it hits depth or sibling limits. If a limit is hit, we take the
same path of assuming there is subpixel-antialiased text (via the "Undetermined" state).

RenderLayerBacking also makes use of PaintedContentRequest during its non-composited child layer walk.

To offset the additional cost of this tree walking, RenderLayerBacking now caches information about its
painted content for the duration of a single update via PaintedContentsInfo, so we no longer call
isDirectlyCompositedImage() and isSimpleContainerCompositingLayer() multiple times per backing per update.
The traversal code here too now has to continue until all necessary states in the request have been computed.

Add some functions to RenderImage so that we know if it's showing the alt text or has a non-bitmap image
(which may contain text).

Subpixel-antialiased ("smoothed") text is disabled by DRT and WTR by default, so we need Internals API to enable it.

Platforms now express their support for subpixel-antialiased text via GraphicsLayer::supportsSubpixelAntialiasedLayerText()
which only returns true on Mac.

Tests: compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html

compositing/contents-format/subpixel-antialiased-text-configs.html
compositing/contents-format/subpixel-antialiased-text-images.html
compositing/contents-format/subpixel-antialiased-text-visibility.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::supportsSubpixelAntialiasedLayerText):

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayer::supportsSubpixelAntialiasedLayerText):
(WebCore::GraphicsLayerCA::changeLayerTypeTo):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::isShowingMissingOrImageError):
(WebCore::RenderImage::isShowingAltText):
(WebCore::RenderImage::hasNonBitmapImage):

  • rendering/RenderImage.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::PaintedContentsInfo::PaintedContentsInfo):
(WebCore::PaintedContentsInfo::setWantsSubpixelAntialiasedTextState):
(WebCore::PaintedContentsInfo::paintsBoxDecorations):
(WebCore::PaintedContentsInfo::paintsContent):
(WebCore::PaintedContentsInfo::paintsSubpixelAntialiasedText):
(WebCore::PaintedContentsInfo::isSimpleContainer):
(WebCore::PaintedContentsInfo::isDirectlyCompositedImage):
(WebCore::PaintedContentsInfo::paintsBoxDecorationsDetermination):
(WebCore::PaintedContentsInfo::paintsContentDetermination):
(WebCore::PaintedContentsInfo::paintsSubpixelAntialiasedTextDetermination):
(WebCore::PaintedContentsInfo::contentsTypeDetermination):
(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::computeParentGraphicsLayerRect):
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBoxDecorations):
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundColor):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::paintsContent):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::isPaintDestinationForDescendantLayers):
(WebCore::RenderLayerBacking::hasVisibleNonCompositedDescendants):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateImageContents):
(WebCore::RenderLayerBacking::paintsChildRenderers): Deleted.

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

  • testing/Internals.cpp:

(WebCore::Internals::setFontSmoothingEnabled):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Test lots of layer configs for subpixel antialiased text support. Only Mac results show the
"(supports subpixel antialiased text 1)" flag on layers now, since the patch makes this
dependent on platform support.

  • compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style-expected.txt: Added.
  • compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html: Added.
  • compositing/contents-format/subpixel-antialiased-text-configs-expected.txt: Added.
  • compositing/contents-format/subpixel-antialiased-text-configs.html: Added.
  • compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt:
  • compositing/contents-format/subpixel-antialiased-text-enabled.html:
  • compositing/contents-format/subpixel-antialiased-text-images-expected.txt: Added.
  • compositing/contents-format/subpixel-antialiased-text-images.html: Added.
  • compositing/contents-format/subpixel-antialiased-text-visibility-expected.txt: Added.
  • compositing/contents-format/subpixel-antialiased-text-visibility.html: Added.
  • compositing/resources/circle-with-text.svg: Added.
  • compositing/resources/circle.svg: Added.
  • platform/mac-wk1/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt:
  • platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style-expected.txt: Added.
  • platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-expected.txt: Added.
  • platform/mac/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt: Copied from LayoutTests/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt.
  • platform/mac/compositing/contents-format/subpixel-antialiased-text-images-expected.txt: Added.
  • platform/mac/compositing/contents-format/subpixel-antialiased-text-visibility-expected.txt: Added.
1:44 PM Changeset in webkit [213465] by sbarati@apple.com
  • 9 edits in trunk

WebAssembly: implement init_expr for Element
​https://bugs.webkit.org/show_bug.cgi?id=165888
<rdar://problem/29760199>

Reviewed by Keith Miller.

JSTests:

  • wasm/Builder_WebAssemblyBinary.js:

(const.emitters.Element):

  • wasm/assert.js:
  • wasm/js-api/element.js:

(assert.throws):
(badInstantiation.makeModule):
(badInstantiation.test):
(badInstantiation):

  • wasm/js-api/global-error.js:

Source/JavaScriptCore:

This patch fixes a few bugs. The main change is allowing init_expr
for the Element's offset. To do this, I had to fix a couple of
other bugs:

  • I removed our invalid early module-parse-time invalidation

of out of bound Element sections. This is not in the spec because
it can't be validated in the general case when the offset is a
get_global.

  • Our get_global validation inside our init_expr parsing code was simply wrong.

It thought that the index operand to get_global went into the pool of imports,
but it does not. It indexes into the pool of globals. I changed the code to
refer to the global pool instead.

  • wasm/WasmFormat.h:

(JSC::Wasm::Element::Element):

  • wasm/WasmModuleParser.cpp:
  • wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::evaluate):

1:40 PM Changeset in webkit [213464] by mmaxfield@apple.com
  • 56 edits
    2 copies
    7 adds in trunk

Expand font-weight and font-stretch to take any number
​https://bugs.webkit.org/show_bug.cgi?id=168889

Reviewed by Simon Fraser.

Source/WebCore:

This patch expands parsing support for font-weight and font-stretch so that they can accept
numbers in addition to the keyword values they accepted previously. Eventually, these numbers
will be used as inputs to select variation fonts; however, in this patch, the values are just
parsed and held in our internal data model. This means that this patch doesn't actually change
the general behavior of WebKit; instead, it parses new values, outputs them (via
getComputedStyle() and similar functions), and provides them as input to our preexisting font
selection algorithm.

This patch doesn't actually modify anything algorithmically, and therefore, it doesn't include
any additional tests for the font selection algorithm. Instead, it tests the parsing of the
newly accepted values (both input and output).

Because our internal data model needs to hold numbers now, this patch also completely eliminates
the FontWidth, FontItalic, and FontTraitsMask enum values in favor of FontSelectionValues (which
can hold numbers instead of individual enum values). Therefore, every place which we were using
these enum values is migrated in this patch to using FontSelectionValues instead.

Tests: fast/text/font-selection-font-face-parse.html

fast/text/font-selection-font-loading-api-parse.html
fast/text/font-style-parse.html
fast/text/font-weight-parse.html

  • accessibility/AccessibilityRenderObject.cpp: Migrate off of old enum types.

(WebCore::AccessibilityRenderObject::hasBoldFont):
(WebCore::AccessibilityRenderObject::hasItalicFont):
(WebCore::AccessibilityRenderObject::hasPlainText):

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp: Ditto.

(getAttributeSetForAccessibilityObject):

  • css/CSSComputedStyleDeclaration.cpp: Output newly parsed values.

(WebCore::fontWeightFromStyle):
(WebCore::fontStretchFromStyle):
(WebCore::fontStyleFromStyle):
(WebCore::fontShorthandValueForSelectionProperties):
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSFontFace.cpp: Migrate off old enum types.

(WebCore::calculateWeightRange):
(WebCore::CSSFontFace::setWeight):
(WebCore::calculateStretchRange):
(WebCore::CSSFontFace::setStretch):
(WebCore::calculateStyleRange):
(WebCore::CSSFontFace::setStyle):
(WebCore::CSSFontFace::calculateStyleMask): Deleted.
(WebCore::CSSFontFace::calculateWeightMask): Deleted.
(WebCore::CSSFontFace::calculateStretch): Deleted.

  • css/CSSFontFace.h:
  • css/CSSFontFaceSet.cpp: Migrate off old enum types.

(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
(WebCore::calculateWeightValue):
(WebCore::calculateStretchValue):
(WebCore::calculateStyleValue):
(WebCore::computeFontSelectionRequest):
(WebCore::CSSFontFaceSet::matchingFaces):
(WebCore::CSSFontFaceSet::fontFace):
(WebCore::computeFontTraitsMask): Deleted.
(WebCore::computeFontStretch): Deleted.

  • css/CSSFontFaceSet.h:
  • css/CSSFontSelector.cpp: Migrate off old enum types.

(WebCore::CSSFontSelector::fontRangesForFamily):

  • css/CSSPrimitiveValueMappings.h: font-weight and font-style are no longer

keyword properties.
(WebCore::CSSPrimitiveValue::operator FontWeight): Deleted.
(WebCore::CSSPrimitiveValue::operator FontItalic): Deleted.

  • css/CSSProperties.json: Use the same infrastructure for all three of the

font selection properties.

  • css/CSSSegmentedFontFace.cpp: Migrate off old enum types.

(WebCore::CSSSegmentedFontFace::fontRanges):

  • css/CSSValueKeywords.in: The 100-based font-weight values are now represented

as real numbers.

  • css/FontFace.cpp: Update the string output functions for the new values.

(WebCore::rangeIsSingleValue):
(WebCore::FontFace::style):
(WebCore::FontFace::weight):
(WebCore::FontFace::stretch):

  • css/StyleBuilderConverter.h: Use CSSValue conversion functions to convert

to our new data model.
(WebCore::StyleBuilderConverter::convertFontWeight):
(WebCore::StyleBuilderConverter::convertFontStretch):
(WebCore::StyleBuilderConverter::convertFontStyle):

  • css/StyleBuilderCustom.h: font-weight is no longer a completely custom

property.
(WebCore::StyleBuilderCustom::applyInitialFontWeight): Deleted.
(WebCore::StyleBuilderCustom::applyInheritFontWeight): Deleted.
(WebCore::StyleBuilderCustom::applyValueFontWeight): Deleted.

  • css/parser/CSSParserFastPaths.cpp: font-style is no longer a keyword property.

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

  • css/parser/CSSPropertyParser.cpp: Parse the new values in the font selection

properties.
(WebCore::consumeFontWeightKeywordValue):
(WebCore::consumeFontWeightCSS21):
(WebCore::consumeFontWeight):
(WebCore::consumeFontStyleKeywordValue):
(WebCore::consumeFontStyle):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
(WebCore::CSSPropertyParser::consumeSystemFont):
(WebCore::CSSPropertyParser::consumeFont):

  • editing/EditingStyle.cpp: Migrate off old enum types.

(WebCore::fontWeightIsBold):

  • editing/mac/EditorMac.mm: Ditto.

(WebCore::Editor::applyFontStyles):

  • platform/graphics/FontCache.h: Unify our font selection values into

their enclosing struct, FontSelectionCapabilities. Also, clean up utility
functions.

  • platform/graphics/FontCascade.cpp: Migrate off old enum types.

(WebCore::FontCascade::FontCascade):

  • platform/graphics/FontCascade.h: Ditto.

(WebCore::FontCascade::italic):
(WebCore::FontCascade::weight):

  • platform/graphics/FontDescription.cpp: Ditto.

(WebCore::FontDescription::FontDescription):
(WebCore::FontCascadeDescription::lighterWeight):
(WebCore::FontCascadeDescription::bolderWeight):
(WebCore::FontDescription::traitsMask): Deleted.

  • platform/graphics/FontDescription.h: Migrate off old enum types.

(WebCore::FontDescription::italic):
(WebCore::FontDescription::stretch):
(WebCore::FontDescription::weight):
(WebCore::FontDescription::fontSelectionRequest):
(WebCore::FontDescription::computedPixelSize):
(WebCore::FontDescription::setItalic):
(WebCore::FontDescription::setStretch):
(WebCore::FontDescription::setIsItalic):
(WebCore::FontDescription::setWeight):
(WebCore::FontDescription::operator==):
(WebCore::FontCascadeDescription::lighterWeight):
(WebCore::FontCascadeDescription::bolderWeight):
(WebCore::FontCascadeDescription::initialItalic):
(WebCore::FontCascadeDescription::initialWeight):
(WebCore::FontCascadeDescription::initialStretch):

  • platform/graphics/FontSelectionAlgorithm.cpp: Delete code which was only

present to convert from the old enum types to the new FontSelectionRequest
type.
(WebCore::fontSelectionRequestForTraitsMask): Deleted.
(WebCore::initialFontSelectionCapabilitiesForTraitsMask): Deleted.
(WebCore::fontSelectionCapabilitiesForTraitsMask): Deleted.

  • platform/graphics/FontSelectionAlgorithm.h: Migrate to new named functions

for special values.
(WebCore::isItalic):
(WebCore::boldWeightValue):
(WebCore::normalWeightValue):
(WebCore::isFontWeightBold):
(WebCore::normalStretchValue):
(WebCore::FontSelectionRequest::FontSelectionRequest):

  • platform/graphics/cocoa/FontCacheCoreText.cpp: Migrate all platforms which

compile this file to know about FontDatabase. This simplifies the interaction
between @font-face fonts and installed fonts. Also, migrate off old enum types.
(WebCore::stretchFromCoreTextTraits):
(WebCore::fontWeightFromCoreText):
(WebCore::capabilitiesForFontDescriptor):
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(WebCore::platformFontLookupWithFamily):
(WebCore::invalidateFontCache):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::lookupFallbackFont):
(WebCore::toTraitsMask): Deleted.
(WebCore::isFontWeightBold): Deleted.
(WebCore::toCoreTextFontWeight): Deleted.
(): Deleted.
(WebCore::FontDatabase::capabilitiesForFontDescriptor): Deleted.
(WebCore::calculateFontSelectionRequest): Deleted.

  • platform/graphics/freetype/FontCacheFreeType.cpp: Migrate off old enum types.

(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(WebCore::fontWeightToFontconfigWeight):
(): Deleted.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: Ditto.

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/ios/FontCacheIOS.mm: Ditto.

(WebCore::baseSystemFontDescriptor):
(WebCore::systemFontModificationAttributes):
(WebCore::systemFontDescriptor):
(WebCore::platformFontWithFamilySpecialCase):
(WebCore::FontCache::weightOfCTFont): Deleted.

  • platform/graphics/mac/FontCacheMac.mm: Ditto.

(WebCore::toNSFontWeight):
(WebCore::platformFontWithFamilySpecialCase):

  • platform/graphics/win/FontCacheWin.cpp: Ditto.

(WebCore::toGDIFontWeight):
(WebCore::traitsInFamilyEnumProc):
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(): Deleted.

  • platform/mock/MockRealtimeVideoSource.cpp: Ditto.

(WebCore::MockRealtimeVideoSource::applySize):

  • platform/text/TextFlags.h: Delete old enum types.
  • platform/win/DragImageWin.cpp: Migrate off old enum types.

(WebCore::dragLabelFont):

  • rendering/RenderEmbeddedObject.cpp: Ditto.

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):

  • rendering/RenderThemeGtk.cpp: Ditto.

(WebCore::RenderThemeGtk::updateCachedSystemFontDescription):

  • rendering/RenderThemeIOS.mm: Ditto.

(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):

  • rendering/RenderThemeMac.mm: Ditto.

(WebCore::toFontWeight):

  • rendering/RenderThemeWin.cpp: Ditto.

(WebCore::fillFontDescription):

Source/WebKit/mac:

Migrate off old enum types.

  • WebCoreSupport/PopupMenuMac.mm:

(PopupMenuMac::populate):

  • WebView/WebHTMLView.mm:

(fontNameForDescription):

  • WebView/WebView.mm:

(-[WebView updateTextTouchBar]):

Source/WebKit/win:

Migrate off old enum types.

  • WebKitGraphics.cpp:

(makeFont):

Source/WebKit2:

Migrate off old enum types.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

Tools:

Migrate off old enum types.

  • TestWebKitAPI/Tests/WebCore/FontCache.cpp:

(TestWebKitAPI::createPlatformFont):
(TestWebKitAPI::compareFonts):
(TestWebKitAPI::TEST_F):

LayoutTests:

  • fast/text/font-selection-font-face-parse-expected.txt: Added.
  • fast/text/font-selection-font-face-parse.html: Added.
  • fast/text/font-selection-font-loading-api-parse-expected.txt: Added.
  • fast/text/font-selection-font-loading-api-parse.html: Added.
  • fast/text/font-stretch-parse-expected.txt:
  • fast/text/font-stretch-parse.html:
  • fast/text/font-style-parse-expected.txt: Copied from LayoutTests/fast/text/font-stretch-parse-expected.txt.
  • fast/text/font-style-parse.html: Added.
  • fast/text/font-weight-parse-expected.txt: Copied from LayoutTests/fast/text/font-stretch-parse-expected.txt.
  • fast/text/font-weight-parse.html: Added.
1:14 PM Changeset in webkit [213463] by Jon Davis
  • 5 edits
    1 copy in trunk/PerformanceTests

Refined the ARES-6 experience
​https://bugs.webkit.org/show_bug.cgi?id=169205

Reviewed by Saam Barati.

  • ARES-6/about.html: Copied from PerformanceTests/ARES-6/index.html.
  • ARES-6/driver.js:

(Driver.prototype.start):
(Driver.prototype._updateIterations):
(Driver):

  • ARES-6/index.html:
  • ARES-6/stats.js:

(Stats.prototype.toString.span.span):

  • ARES-6/styles.css:

(body):
(.swoop):
(p):
(.logo):
(.start):
(.test):
(.test:nth-child(odd)):
(.overall):
(.about h2):
(.button):
(.button:hover):
(.button.return:before):
(@keyframes fade-in):
(@keyframes scale-in):
(@keyframes flicker-in):
(@keyframes wipe-in):
(.flip): Deleted.
(.testing, .about): Deleted.
(.testing): Deleted.
(.about): Deleted.
(#about:target): Deleted.

1:13 PM Changeset in webkit [213462] by clopez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Mark fast/parser/adoption-agency-unload-iframe-4.html as timing out on platform GTK.

Unreviewed test gardening.

  • platform/gtk/TestExpectations:
12:27 PM Changeset in webkit [213461] by commit-queue@webkit.org
  • 2 edits in trunk/PerformanceTests

StandardCanPlayThrough.html does not work on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=169207

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-03-06
Reviewed by Jer Noble.

On iOS only, add muted=true and autoplay=allowed. The loading policy on iOS requires these attributes to load enough
data to trigger canPlayThrough.

  • Media/StandardCanPlayThrough.html:
11:43 AM Changeset in webkit [213460] by Chris Dumez
  • 12 edits
    2 adds in trunk

[iOS] Disable autoplay of silent videos in low power mode
​https://bugs.webkit.org/show_bug.cgi?id=168985
<rdar://problem/30739051>

Reviewed by Jer Noble.

Source/WebCore:

Disable autoplay of silent videos in low power mode on iOS to save battery.
We force the display of the start button when denying autoplay in low power
mode to allow the user to start playback.

Test: media/modern-media-controls/start-support/start-support-lowPowerMode.html

  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::shouldForceControlsDisplay):

  • Modules/mediacontrols/MediaControlsHost.h:
  • Modules/mediacontrols/MediaControlsHost.idl:

Add shouldForceControlsDisplay property on MediaControlsHost. This property
is set to true when we want to force the display for media controls. Currently,
this only returns true for autoplay videos, while in low power mode.

  • Modules/modern-media-controls/media/controls-visibility-support.js:

(ControlsVisibilitySupport.prototype._updateControls):
Take into consideration MediaControlsHost.shouldForceControlsDisplay when
initializing shouldShowControls variable.

  • Modules/modern-media-controls/media/start-support.js:

(StartSupport.prototype._shouldShowStartButton):
Show the start button when MediaControlsHost.shouldForceControlsDisplay
returns true.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
Add MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode restriction
to the session when low power mode is enabled so we know we need to force a
gesture to start playback of autoplay videos.

(WebCore::HTMLMediaElement::shouldForceControlsDisplay):
Add convenience function to decide if we should force display of media controls.
This returns true if the media element is a video with autoplay attribute and
its session has the MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode
restriction (i.e. we are in low power mode).

(WebCore::HTMLMediaElement::configureMediaControls):
Force requireControls variable to true if shouldForceControlsDisplay() returns
true. We do this here instead of inside HTMLMediaElement::controls() because
we do not want to change the value of media.controls exposed to JavaScript.

(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture):
Add MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode to the list
of restrictions that get removed on user gesture.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted):
Deny playback for videos that have the RequireUserGestureForVideoDueToLowPowerMode
restriction unless there is a user gesture.

  • html/MediaElementSession.h:

Add new MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode
restriction.

LayoutTests:

Add layout test coverage.

  • media/modern-media-controls/start-support/start-support-lowPowerMode-expected.txt: Added.
  • media/modern-media-controls/start-support/start-support-lowPowerMode.html: Added.
11:24 AM Changeset in webkit [213459] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/icon-button/icon-button-active-state.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=167752

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
11:14 AM Changeset in webkit [213458] by Chris Dumez
  • 16 edits in trunk

LayoutTest fast/dom/timer-throttling-hidden-page.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=168927

Reviewed by Simon Fraser.

Source/WebCore:

Update internals.isTimerThrottled() to return true for any kind of throttling.
It used to only account only for specific timers that do not cause changes
inside the viewport. It now accounts for all kind of throttling, such as
timer alignment due to the page being hidden.

  • page/DOMTimer.h:
  • testing/Internals.cpp:

(WebCore::Internals::isTimerThrottled):

LayoutTests:

  • fast/dom/nested-timer-visible-element-throttling.html:
  • fast/dom/repeating-timer-element-overflow-throttling.html:
  • fast/dom/repeating-timer-element-overflowing-child-own-layer-throttling.html:
  • fast/dom/repeating-timer-mixed-visible-display-none-elements-throttling.html:
  • fast/dom/repeating-timer-visible-element-throttling.html:
  • fast/dom/timer-height-change-no-throttling.html:
  • fast/frames/flattening/resources/iframe-to-resize.html:

Use 10 milliseconds interval for tests relying on internals.isTimerThrottled().
Using 0 is problematic because we always internally cap to 1ms and 4ms after
reaching the max nesting level. Therefore, a 0 delay timer is always considered
to be throttled.

  • fast/dom/timer-throttling-hidden-page-expected.txt:
  • fast/dom/timer-throttling-hidden-page-non-nested-expected.txt:
  • fast/dom/timer-throttling-hidden-page-non-nested.html:
  • fast/dom/timer-throttling-hidden-page.html:

Rewrite tests to stop measuring timer intervals as this is inherently
flaky and rely on internals.isTimerThrottled() instead.

  • platform/mac/TestExpectations:

Unskip test that used to be flaky.

11:09 AM Changeset in webkit [213457] by Manuel Rego Casasnovas
  • 5 edits
    286 adds in trunk/LayoutTests

[css-grid] Import W3C Test Suite
​https://bugs.webkit.org/show_bug.cgi?id=169196

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

This patch imports the CSS Grid Layout test suite from csswg-test repository:
​https://github.com/w3c/csswg-test/tree/master/css-grid-1

  • csswg-test/css-grid-1/OWNERS: Added.
  • csswg-test/css-grid-1/README.md: Added.
  • csswg-test/css-grid-1/grid-definition/fr-unit-expected.html: Added.
  • csswg-test/css-grid-1/grid-definition/fr-unit-with-percentage-expected.html: Added.
  • csswg-test/css-grid-1/grid-definition/fr-unit-with-percentage.html: Added.
  • csswg-test/css-grid-1/grid-definition/fr-unit.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-repeat-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-repeat-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-layout-auto-tracks-expected.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-layout-auto-tracks.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-layout-basic-expected.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-layout-basic.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-layout-repeat-notation-expected.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-layout-repeat-notation.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-flexible-lengths-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-flexible-lengths-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-grid-template-areas-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-grid-template-areas-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-named-grid-lines-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-named-grid-lines-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-repeat-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-repeat-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/support/testing-utils.js: Added.

(checkGridTemplateRows):
(testGridTemplateColumnsRows):
(testGridTemplateAreas):
(TestingUtils):

  • csswg-test/css-grid-1/grid-definition/support/w3c-import.log: Added.
  • csswg-test/css-grid-1/grid-definition/w3c-import.log: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-inline-blocks-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-inline-blocks-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-001.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-002.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-003.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-004.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-inline-blocks-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-inline-blocks-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-layout-grid-in-grid-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-layout-grid-in-grid.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-layout-z-order-a-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-layout-z-order-a.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-layout-z-order-b-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-layout-z-order-b.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-005-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-006-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-006.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-008-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-008.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-010-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-010.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-011-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-011.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-012-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-012.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-013-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-013.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-014-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-014.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-015-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-015.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-016-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-016.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-017-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-017.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-018-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-018.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006.xht: Added.
  • csswg-test/css-grid-1/grid-items/ref-filled-green-100px-square-image.html: Added.
  • csswg-test/css-grid-1/grid-items/support/100x100-green.png: Added.
  • csswg-test/css-grid-1/grid-items/support/100x50-green.png: Added.
  • csswg-test/css-grid-1/grid-items/support/200x200-green.png: Added.
  • csswg-test/css-grid-1/grid-items/support/50x100-green.png: Added.
  • csswg-test/css-grid-1/grid-items/support/50x50-green.png: Added.
  • csswg-test/css-grid-1/grid-items/support/w3c-import.log: Added.
  • csswg-test/css-grid-1/grid-items/w3c-import.log: Added.
  • csswg-test/css-grid-1/grid-layout-properties-expected.txt: Added.
  • csswg-test/css-grid-1/grid-layout-properties.html: Added.
  • csswg-test/css-grid-1/grid-model/display-grid-expected.html: Added.
  • csswg-test/css-grid-1/grid-model/display-grid.html: Added.
  • csswg-test/css-grid-1/grid-model/display-inline-grid-expected.html: Added.
  • csswg-test/css-grid-1/grid-model/display-inline-grid.html: Added.
  • csswg-test/css-grid-1/grid-model/grid-computed-value-display-floated-items-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-model/grid-computed-value-display-floated-items-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-display-grid-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-display-grid-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-display-inline-grid-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-display-inline-grid-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-letter-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-letter-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-letter-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-letter-002.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-letter-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-letter-003.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-line-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-line-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-line-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-line-002.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-line-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-line-003.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-float-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-float-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-floats-no-intrude-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-floats-no-intrude-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-letter-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-letter-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-letter-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-letter-002.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-letter-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-letter-003.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-line-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-line-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-line-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-line-002.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-line-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-line-003.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-float-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-float-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-floats-no-intrude-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-floats-no-intrude-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-margins-no-collapse-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-margins-no-collapse-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-multicol-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-multicol-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-vertical-align-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-vertical-align-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-margins-no-collapse-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-margins-no-collapse-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-multicol-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-multicol-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-support-display-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-model/grid-support-display-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-vertical-align-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-vertical-align-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/w3c-import.log: Added.
  • csswg-test/css-grid-1/implicit-grids/grid-support-grid-auto-columns-rows-001-expected.html: Added.
  • csswg-test/css-grid-1/implicit-grids/grid-support-grid-auto-columns-rows-001.html: Added.
  • csswg-test/css-grid-1/implicit-grids/w3c-import.log: Added.
  • csswg-test/css-grid-1/layout-algorithm/grid-layout-free-space-unit-expected.html: Added.
  • csswg-test/css-grid-1/layout-algorithm/grid-layout-free-space-unit.html: Added.
  • csswg-test/css-grid-1/layout-algorithm/w3c-import.log: Added.
  • csswg-test/css-grid-1/placement/grid-layout-grid-span-expected.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-grid-span.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-lines-expected.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-lines-shorthands-expected.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-lines-shorthands.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-lines.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-placement-shorthands-expected.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-placement-shorthands.html: Added.
  • csswg-test/css-grid-1/placement/w3c-import.log: Added.
  • csswg-test/css-grid-1/test-plan/index.html: Added.
  • csswg-test/css-grid-1/test-plan/w3c-import.log: Added.
  • csswg-test/css-grid-1/w3c-import.log: Added.
  • resources/import-expectations.json:
  • resources/resource-files.json:

LayoutTests:

A few tests are not passing yet, so the TextExpectations file
has been updated accordingly linking the different bugs.

11:01 AM Changeset in webkit [213456] by clopez@igalia.com
  • 2 edits in trunk/JSTests

[JSC] [Linux] Test stress/spread-forward-call-varargs-stack-overflow.js fails
​https://bugs.webkit.org/show_bug.cgi?id=169206

Unreviewed test gardening.

  • stress/spread-forward-call-varargs-stack-overflow.js: Skip on Linux platforms.
10:00 AM Changeset in webkit [213455] by hyatt@apple.com
  • 38 edits
    22 adds
    2 deletes in trunk

Enable fieldsets to be flexboxes, grids and multicolumn.
​https://bugs.webkit.org/show_bug.cgi?id=169082

Source/WebCore:

Reviewed by Simon Fraser .

Added new tests in fast/forms/fieldset.

This patch eliminates RenderFieldset and moves the functionality into RenderBlock so that
derived classes can also be fieldsets.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:

Remove RenderFieldset from the project.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::titleUIElement):
Call in to RenderBlock now instead of RenderFieldset.

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::createElementRenderer):

  • html/HTMLFieldSetElement.h:

The fieldset DOM element now uses RenderElement::createFor to make renderers so that multiple display types
can be supported. A special flag has been added that indicates only to make flexbox and block-related
renderers (not table display types).

  • rendering/OrderIterator.cpp:

(WebCore::OrderIterator::shouldSkipChild):
(WebCore::OrderIteratorPopulator::collectChild):

  • rendering/OrderIterator.h:

Streamline child collection for flexboxes and grids to indicate whether the child should be skipped as a return
value from collectChild. Add a shouldSkipChild method that skips both out of flow positioned objects and
excluded children like the legends of fieldsets.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlockRareData::RenderBlockRareData):
When the legend is taller than the fieldset's borderBefore(), intrinsic border is added to the CSS border width.
This intrinsic border being factored in ensures that the padding and content boxes of fieldsets are correct
across any layout system, since the legend is now just treated as part of the border.

(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
Call the new computePreferredWidthsForExcludedChildren to ensure that excluded children contribute to
preferred width in their own way and not as part of a specific layout system.

(WebCore::RenderBlock::renderName):
Hacked to still return RenderFieldSet for RenderBlockFlow-backed fieldsets for layout test compatibility.

(WebCore::RenderBlock::layoutExcludedChildren):
Renamed from layoutSpecialExcludedChild to more accurately reflect the fact that multiple excluded children
can be included here (e.g., both a multicolumn flow thread and a legend). The RenderBlock base class handles
the layout of legends by both placing them and setting the correct intrinsic border before amount on the
block.

(WebCore::RenderBlock::findFieldsetLegend):
Moved from RenderFieldset.

(WebCore::RenderBlock::adjustBorderBoxRectForPainting):
(WebCore::RenderBlock::paintRectToClipOutFromBorder):
These methods are used when painting to shrink the border box as needed to account for the legend and to
provide the portion of the border that needs to be clipped out. These methods have been enhanced to
properly support all writing modes.

(WebCore::RenderBlock::intrinsicBorderForFieldset):
(WebCore::RenderBlock::setIntrinsicBorderForFieldset):
(WebCore::RenderBlock::borderTop):
(WebCore::RenderBlock::borderLeft):
(WebCore::RenderBlock::borderBottom):
(WebCore::RenderBlock::borderRight):
(WebCore::RenderBlock::borderBefore):
These methods are overridden for border to ensure that the intrinsic border added by a tall legend is
properly factored in.

(WebCore::RenderBlock::computePreferredWidthsForExcludedChildren):

  • rendering/RenderBlock.h:

This method computes the preferred widths for legend children in order to ensure that the legend properly
grows the width of the fieldset when it is the widest item.

(WebCore::RenderBlock::adjustBorderBoxLogicalHeightForBoxSizing):
(WebCore::RenderBlock::adjustContentBoxLogicalHeightForBoxSizing):
Preserve the behavior of fieldsets in that the available content size includes the space lost accounting
for the legend. I don't think this makes much sense, but it matches the behavior of other browsers
(and our old behavior).

(WebCore::RenderBlock::paintExcludedChildrenInBorder):
Method for painting the excluded children that might be present in our border. We only do this if the
paint phase is a box decoration painting phase and if the legend isn't self-painting.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willCreateColumns):
Allow fieldsets to create columns now.

(WebCore::RenderBlockFlow::layoutBlockChildren):
(WebCore::RenderBlockFlow::layoutExcludedChildren):
Renamed this method and change it to call the base class to ensure that legends in multicolumn fieldsets
get handled properly.

(WebCore::RenderBlockFlow::addChild):
Patched to make sure legends don't get put into the multicolumn flow thread, as they need to
remain outside of it.

(WebCore::RenderBlockFlow::layoutSpecialExcludedChild): Deleted.
Renamed to layoutExcludedChildren.

  • rendering/RenderBlockFlow.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):
Patched to call the new adjustBorderBoxRectForPainting and paintRectToClipOutFromBorder methods in
order to properly shrink the border box rect for painting and to clip out the portion of the border
covered by the legend.

(WebCore::RenderBox::avoidsFloats):
Add fieldsets as avoiding floats. RenderFieldset used to subclass this method to return true, but with
its removal, we need to put this in the base class along with legends.

  • rendering/RenderBox.h:

(WebCore::RenderBox::isGridItem):
(WebCore::RenderBox::isFlexItem):
Patched to exclude legends so that they don't try to size like they are really in the grid or flexbox.

(WebCore::RenderBox::adjustBorderBoxRectForPainting):
This method is overridden by RenderBLock to handle adjusting fieldset border rects for painting.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::paintRectToClipOutFromBorder):
Patched to properly paint fieldsets using the new helpers.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
Make sure deprecated flexible boxes lay out their legends properly by calling layoutExcludedChildren.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

  • rendering/RenderElement.h:

Patched to take a flag that limits what renderers can be created so that fieldsets don't make table
display types.

  • rendering/RenderFieldset.cpp: Removed.
  • rendering/RenderFieldset.h: Removed.

Remove RenderFieldset files from the tree.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderFlexibleBox::firstLineBaseline):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::prepareOrderIteratorAndMargins):
Make sure flexible boxes lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the flexible box layout.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::layoutGridItems):
Make sure grids lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the grid's layout.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::populate):
Pull legends back up into the block and don't let them be part of the flow thread.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::requiresBalancing):
Fix an assert to allow legends to exist as siblings of multicolumn sets.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::isFieldset):
Changed to examine the HTML element rather than RenderFieldset.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isExcludedFromNormalLayout):
(WebCore::RenderObject::setIsExcludedFromNormalLayout):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
RenderObjects now have a new bit that is set for excluded objects like legends, flow threads,
placeholders, and ruby text. This bit lets code easily detect that an object is excluded from
the layout system and can be skipped.

(WebCore::RenderObject::isExcludedAndPlacedInBorder):
Helper method for asking if an object is painting inside the border. Used to know we
need to factor it into preferred width calculations outside of any one layout system
and also to know that we need to paint it when we paint the fieldset's border instead of
later (after we might have scrolled or clipped the child painting area).

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layoutExcludedChildren):
(WebCore::RenderRubyRun::layoutSpecialExcludedChild): Deleted.

  • rendering/RenderRubyRun.h:

Rename layoutSpecialExcludedChild to layoutExcludedChildren.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::adjustBorderBoxRectForPainting):
(WebCore::RenderTable::paintBoxDecorations):
(WebCore::RenderTable::paintMask):
(WebCore::RenderTable::subtractCaptionRect): Deleted.

  • rendering/RenderTable.h:

Patched tables to share the same border box rect adjustment used by fieldsets when subtracting
out captions. This is prep work to allow tables to be fieldsets, but for now I didn't go all the
way.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):
Make sure table cells adjust their border box rects for painting. Again this is prep work for
cells potentially being fieldsets, but not supported yet.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::layoutExcludedChildren):
(WebCore::RenderTextControl::layoutSpecialExcludedChild): Deleted.

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::layoutExcludedChildren):
(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild): Deleted.

  • rendering/RenderTextControlMultiLine.h:

Renamed the methods for doing the excluded child layout.

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
Make sure to dump the original fieldset border and not the border with the extra legend stuff in it.

LayoutTests:

Reviewed by Simon Fraser.

  • fast/forms/fieldset/abs-pos-child-sizing-expected.html: Added.
  • fast/forms/fieldset/abs-pos-child-sizing.html: Added.
  • fast/forms/fieldset/fieldset-deprecated-flexbox-expected.html: Added.
  • fast/forms/fieldset/fieldset-deprecated-flexbox.html: Added.
  • fast/forms/fieldset/fieldset-flexbox-expected.html: Added.
  • fast/forms/fieldset/fieldset-flexbox.html: Added.
  • fast/forms/fieldset/fieldset-grid-expected.html: Added.
  • fast/forms/fieldset/fieldset-grid.html: Added.
  • fast/forms/fieldset/fieldset-multicolumn-expected.html: Added.
  • fast/forms/fieldset/fieldset-multicolumn.html: Added.
  • fast/forms/fieldset/fieldset-overflow-auto-expected.html: Added.
  • fast/forms/fieldset/fieldset-overflow-auto.html: Added.
  • fast/forms/fieldset/fieldset-overflow-hidden-expected.html: Added.
  • fast/forms/fieldset/fieldset-overflow-hidden.html: Added.
  • fast/forms/fieldset/fieldset-positioned-children-expected.html: Added.
  • fast/forms/fieldset/fieldset-positioned-children.html: Added.
  • fast/forms/fieldset/fieldset-positioned-legend-expected.html: Added.
  • fast/forms/fieldset/fieldset-positioned-legend.html: Added.
  • fast/forms/fieldset/fieldset-self-painting-legend-expected.html: Added.
  • fast/forms/fieldset/fieldset-self-painting-legend.html: Added.
  • fast/forms/fieldset/fieldset-writing-modes-expected.html: Added.
  • fast/forms/fieldset/fieldset-writing-modes.html: Added.
9:49 AM Changeset in webkit [213454] by commit-queue@webkit.org
  • 12 edits
    1 copy
    1 add in trunk

[Modern Media Controls] Tracks panel should clip and scroll content when numerous tracks are available
​https://bugs.webkit.org/show_bug.cgi?id=169201
<rdar://problem/30867979>

Patch by Antoine Quint <Antoine Quint> on 2017-03-06
Reviewed by Eric Carlson.

Source/WebCore:

We now position and size the tracks panel dynamically and ensure a max-height is applied
to the panel so that it allows a margin of 10px above it within the media controls. We also
apply that same max-height to a new intermediary scrollable container for the track lists,
so that it scrolls independently of the container and the background tint.

Test: media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html

  • Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:

(MacOSFullscreenMediaControls.prototype.showTracksPanel): Deleted.

  • Modules/modern-media-controls/controls/macos-inline-media-controls.css:

(.media-controls.mac.inline .volume.slider):
(.media-controls.mac.inline .tracks-panel): Deleted.

  • Modules/modern-media-controls/controls/macos-inline-media-controls.js:

(MacOSInlineMediaControls.prototype.showTracksPanel): Deleted.

  • Modules/modern-media-controls/controls/macos-media-controls.js:

(MacOSMediaControls.prototype.showTracksPanel):

  • Modules/modern-media-controls/controls/tracks-panel.css:

(.tracks-panel > .background-tint > div,):
(.tracks-panel > .scrollable-container):
(.tracks-panel section):
(.tracks-panel section:first-of-type):
(.tracks-panel section > h3):
(.tracks-panel section > ul):
(.tracks-panel section > ul > li):
(.tracks-panel section > ul > li:focus):
(.tracks-panel section > ul > li.selected:before):
(.tracks-panel section > ul > li.animated):
(.tracks-panel > .background-tint > div): Deleted.
(.tracks-panel > section): Deleted.
(.tracks-panel > section:first-of-type): Deleted.
(.tracks-panel > section > h3): Deleted.
(.tracks-panel > section > ul): Deleted.
(.tracks-panel > section > ul > li): Deleted.
(.tracks-panel > section > ul > li:focus): Deleted.
(.tracks-panel > section > ul > li.selected:before): Deleted.
(.tracks-panel > section > ul > li.animated): Deleted.

  • Modules/modern-media-controls/controls/tracks-panel.js:

(TracksPanel.prototype.presentInParent):
(TracksPanel.prototype.get maxHeight):
(TracksPanel.prototype.set maxHeight):
(TracksPanel.prototype.commitProperty):
(TracksPanel.prototype._childrenFromDataSource):

LayoutTests:

Rebaseline a couple of existing tests to account for the DOM structure change in
the tracks panel and the fact that positioning is now dependent on the bounds of
the tracks button.

We also add a new test that checks that the tracks panel is positioned and sized
correctly to ensure that it can be scrolled when it has too many tracks to fit.

  • media/modern-media-controls/tracks-panel/tracks-panel-population-expected.txt:
  • media/modern-media-controls/tracks-panel/tracks-panel-population.html:
  • media/modern-media-controls/tracks-panel/tracks-panel-position-and-size-expected.txt: Added.
  • media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html: Added.
  • media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse-expected.txt:
  • media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse.html:
9:26 AM Changeset in webkit [213453] by Yusuke Suzuki
  • 5 edits in trunk

[JSC] Allow indexed module namespace object fields
​https://bugs.webkit.org/show_bug.cgi?id=168870

Reviewed by Saam Barati.

JSTests:

  • wasm/spec-tests/names.wast.js:

Source/JavaScriptCore:

While JS modules cannot expose any indexed bindings,
Wasm modules can expose them. However, module namespace
object currently does not support indexed properties.
This patch allows module namespace objects to offer
indexed binding accesses.

  • runtime/JSModuleNamespaceObject.cpp:

(JSC::JSModuleNamespaceObject::getOwnPropertySlotCommon):
(JSC::JSModuleNamespaceObject::getOwnPropertySlot):
(JSC::JSModuleNamespaceObject::getOwnPropertySlotByIndex):

  • runtime/JSModuleNamespaceObject.h:
8:57 AM Changeset in webkit [213452] by Yusuke Suzuki
  • 4 edits
    2 adds in trunk

Null pointer crash when loading module with unresolved import also as a script file
​https://bugs.webkit.org/show_bug.cgi?id=168971

Reviewed by Saam Barati.

JSTests:

  • stress/re-execute-error-module.js: Added.

(shouldBe):
(async):

  • stress/resources/error-module.js: Added.

Source/JavaScriptCore:

If linking throws an error, this error should be re-thrown
when requesting the same module.

  • builtins/ModuleLoaderPrototype.js:

(globalPrivate.newRegistryEntry):

  • runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::link):

8:02 AM Changeset in webkit [213451] by Yusuke Suzuki
  • 2 edits in trunk

Unreviewed, fix AppleWin build
​https://bugs.webkit.org/show_bug.cgi?id=164032

  • Source/cmake/WebKitFeatures.cmake:
7:43 AM Changeset in webkit [213450] by Yusuke Suzuki
  • 12 edits in trunk

[GTK][JSCOnly] Enable WebAssembly on Linux environment
​https://bugs.webkit.org/show_bug.cgi?id=164032

Reviewed by Michael Catanzaro.

.:

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsJSCOnly.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

This patch enables WebAssembly on JSCOnly and GTK ports.
Basically, almost all the WASM code is portable to Linux.
One platform-dependent part is faster memory load using SIGBUS
signal handler. This patch ports this part to Linux.

  • CMakeLists.txt:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):
(JSC::Wasm::enableFastMemory):

Tools:

  • Scripts/run-jsc-stress-tests:

Enable WASM tests.

  • Scripts/webkitperl/FeatureList.pm:

Enable WebAssembly.

7:30 AM Changeset in webkit [213449] by Manuel Rego Casasnovas
  • 6 edits in trunk

[css-grid] Stretch should grow and shrink items to fit its grid area
​https://bugs.webkit.org/show_bug.cgi?id=163200

Reviewed by Darin Adler.

Source/WebCore:

After some discussions the CSS WG agreed that stretch should not only
grow items, but also shrink them to fit its grid area.
That way the "min-width|height: auto" is somehow ignored for grid items.
More info at: ​https://github.com/w3c/csswg-drafts/issues/283

The good part is that this allows us to remove some ugly code we've
in RenderBox that was only used by Grid Layout.

For images, we'll be stretching on both axis right now, so the aspect
ratio won't be preserved. The default behavior might change in those
cases, but that should be implemented in a different patch.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalHeight):

LayoutTests:

The tests have been updated according to the new expected behavior.

  • fast/css-grid-layout/grid-container-percentage-columns.html:
  • fast/css-grid-layout/min-width-height-auto-and-margins.html:
  • fast/css-grid-layout/min-width-height-auto.html:
6:19 AM Changeset in webkit [213448] by magomez@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] WebProcess from WebKitGtk+ 2.15.x SIGSEVs in GIFLZWContext::doLZW(unsigned char const*, unsigned long) at Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:303
​https://bugs.webkit.org/show_bug.cgi?id=167304

Reviewed by Carlos Garcia Campos.

Add a lock to ensure that the GIFImageReader that we are using for decoding is not deleted while
the decoding thread is using it.

No new tests.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::clearFrameBufferCache):

6:06 AM Changeset in webkit [213447] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Currency digits calculation in Intl.NumberFormat should call out to ICU
​https://bugs.webkit.org/show_bug.cgi?id=169182

Patch by Daniel Ehrenberg <​littledan@igalia.com> on 2017-03-06
Reviewed by Yusuke Suzuki.

  • runtime/IntlNumberFormat.cpp:

(JSC::computeCurrencyDigits):
(JSC::computeCurrencySortKey): Deleted.
(JSC::extractCurrencySortKey): Deleted.

4:19 AM Changeset in webkit [213446] by Antti Koivisto
  • 16 edits in trunk

Allow render tree building before loading stylesheet elements
​https://bugs.webkit.org/show_bug.cgi?id=169079
Source/WebCore:

<rdar://problem/30865709>

Reviewed by Andreas Kling.

Currently we don't resolve style or construct renderers if there are any pending
stylesheet loads. This patch enables style and renderer constuction up to the
first encountered loading style element.

This is a step toward allowing incremental rendering for in-body stylesheets.

  • dom/Document.cpp:

(WebCore::Document::needsStyleRecalc):

Ensure scrolling to anchor eventually happens.

  • dom/Document.h:

(WebCore::Document::isIgnoringPendingStylesheets):

  • dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::removedFrom):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):

  • style/StyleScope.cpp:

(WebCore::Style::Scope::addPendingSheet):
(WebCore::Style::Scope::removePendingSheet):

Track pending sheet nodes in a map so we can test if a given node has a pending sheet.
This is also more robust in general.

(WebCore::Style::Scope::hasProcessingInstructionWithPendingSheet):
(WebCore::Style::Scope::updateActiveStyleSheets):

  • style/StyleScope.h:

(WebCore::Style::Scope::hasPendingSheet):
(WebCore::Style::Scope::hasPendingSheets):
(WebCore::Style::Scope::addPendingSheet): Deleted.

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::styleForElement):

Instead of global test for placeholder construction check the status of the pending sheet flag.

(WebCore::Style::hasLoadingStylesheet):
(WebCore::Style::TreeResolver::resolveComposedTree):

Set a flag when encountering a pending top level sheet during DOM traversal.

(WebCore::Style::TreeResolver::resolve):

  • style/StyleTreeResolver.h:
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Ensure SVG images have layout before getting the size.

LayoutTests:

Reviewed by Andreas Kling.

Ensure that style is synchronized after adding a stylesheet dynamically by doing an additional test.
Otherwise the class/attr invalidation test may as we don't know about the new stylesheet yet.
This is functionally fine (future synchronization would invalidate the style) but messes up the test
trying to verify class/attr change invalidation specifically.

  • fast/css/style-invalidation-attribute-change-descendants-expected.txt:
  • fast/css/style-invalidation-attribute-change-descendants.html:
  • fast/css/style-invalidation-class-change-descendants-expected.txt:
  • fast/css/style-invalidation-class-change-descendants.html:
2:32 AM Changeset in webkit [213445] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebCore

[GStreamer] Adopt nullptr
​https://bugs.webkit.org/show_bug.cgi?id=123438

Patch by Vanessa Chipirrás Navalón <​vchipirras@igalia.com> on 2017-03-06
Reviewed by Xabier Rodriguez-Calvar.

To adapt the code to the C++11 standard, all NULL or 0 pointers have been changed to nullptr.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::decodeAudioForBusCreation):

  • platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:

(WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer):
(WebCore::AudioSourceProviderGStreamer::configureAudioBin):
(WebCore::AudioSourceProviderGStreamer::setClient):
(WebCore::AudioSourceProviderGStreamer::handleNewDeinterleavePad):

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webkit_web_audio_src_init):
(webKitWebAudioSrcLoop):
(webKitWebAudioSrcChangeState):

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::setEnabled):

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::initializeGStreamer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine):
(WebCore::initializeGStreamerAndRegisterWebKitElements):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::newTextSample):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
Removed the unused second argument on processTableOfContentsEntry function.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):
Removed the unused second argument on this function.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Removed the unused second argument on processTableOfContentsEntry function.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::setMuted):
(WebCore::MediaPlayerPrivateGStreamerBase::muted):
(WebCore::MediaPlayerPrivateGStreamerBase::notifyPlayerOfMute):
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:

(WebCore::MediaPlayerPrivateGStreamerOwr::registerMediaEngine):

  • platform/graphics/gstreamer/TextCombinerGStreamer.cpp:

(webkit_text_combiner_init):
(webkitTextCombinerPadEvent):
(webkitTextCombinerRequestNewPad):
(webkitTextCombinerNew):

  • platform/graphics/gstreamer/TextSinkGStreamer.cpp:

(webkitTextSinkNew):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkit_video_sink_init):
(webkitVideoSinkProposeAllocation):
(webkitVideoSinkNew):

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:

(WebCore::VideoTrackPrivateGStreamer::setSelected):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):
(webKitWebSrcDispose):
(webKitWebSrcSetProperty):
(webKitWebSrcStop):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetProtocols):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(ResourceHandleStreamingClient::didFail):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

  • platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcGetProtocols):

2:02 AM Changeset in webkit [213444] by akling@apple.com
  • 10 edits in trunk/Source

[iOS] Report domains crashing under memory pressure via enhanced privacy logging.
<​https://webkit.org/b/169133>
<rdar://problem/29964017>

Reviewed by Antti Koivisto.

Source/WebCore:

  • page/DiagnosticLoggingKeys.h:

Source/WebKit2:

Notify the UI process when the memory pressure status changes.
If a web process crashes while under memory pressure, log the domain of the last open page
using enhanced privacy logging.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::memoryPressureStatusChanged):
(WebKit::WebProcessProxy::isUnderMemoryPressure):

  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

Source/WTF:

Add a mechanism for getting a callback when the memory pressure status changes.

  • wtf/MemoryPressureHandler.cpp:

(WTF::MemoryPressureHandler::measurementTimerFired):
(WTF::MemoryPressureHandler::beginSimulatedMemoryPressure):
(WTF::MemoryPressureHandler::endSimulatedMemoryPressure):
(WTF::MemoryPressureHandler::setUnderMemoryPressure):
(WTF::MemoryPressureHandler::memoryPressureStatusChanged):

  • wtf/MemoryPressureHandler.h:

(WTF::MemoryPressureHandler::setMemoryPressureStatusChangedCallback):
(WTF::MemoryPressureHandler::setUnderMemoryPressure): Deleted.

Mar 5, 2017:

11:38 PM Changeset in webkit [213443] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline fast/css/css2-system-fonts.html after r213267.

  • platform/gtk/fast/css/css2-system-fonts-expected.txt:
9:51 PM Changeset in webkit [213442] by beidson@apple.com
  • 1 edit
    3 deletes in trunk/Source/WebKit2

Remove new files accidentally added in r213441

Unreviewed.

  • UIProcess/WebLoadingProviderProxy.cpp: Removed.
  • UIProcess/WebLoadingProviderProxy.h: Removed.
  • UIProcess/WebLoadingProviderProxy.messages.in: Removed.
6:53 PM Changeset in webkit [213441] by beidson@apple.com
  • 23 edits
    3 copies
    9 moves
    1 add
    1 delete in trunk/Source/WebKit2

Rename CustomProtocolFoo to LegacyCustomProtocolFoo.
​https://bugs.webkit.org/show_bug.cgi?id=169188

Reviewed by Andy Estes.

  • CMakeLists.txt:
  • DerivedSources.make:
  • NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm.

(+[WKCustomProtocol canInitWithRequest:]):
(+[WKCustomProtocol canonicalRequestForRequest:]):
(+[WKCustomProtocol requestIsCacheEquivalent:toRequest:]):
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]):
(-[WKCustomProtocol initializationRunLoop]):
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):
(WebKit::LegacyCustomProtocolManager::registerProtocolClass):
(WebKit::LegacyCustomProtocolManager::registerScheme):
(WebKit::LegacyCustomProtocolManager::unregisterScheme):
(WebKit::LegacyCustomProtocolManager::supportsScheme):
(WebKit::dispatchOnInitializationRunLoop):
(WebKit::LegacyCustomProtocolManager::didFailWithError):
(WebKit::LegacyCustomProtocolManager::didLoadData):
(WebKit::LegacyCustomProtocolManager::didReceiveResponse):
(WebKit::LegacyCustomProtocolManager::didFinishLoading):
(WebKit::LegacyCustomProtocolManager::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManager::protocolForID):

  • NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.cpp.

(WebKit::generateCustomProtocolID):
(WebKit::LegacyCustomProtocolManager::supplementName):
(WebKit::LegacyCustomProtocolManager::LegacyCustomProtocolManager):
(WebKit::LegacyCustomProtocolManager::initialize):
(WebKit::LegacyCustomProtocolManager::addCustomProtocol):
(WebKit::LegacyCustomProtocolManager::removeCustomProtocol):
(WebKit::LegacyCustomProtocolManager::startLoading):
(WebKit::LegacyCustomProtocolManager::stopLoading):

  • NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.h.
  • NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.messages.in.
  • NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/soup/CustomProtocolManagerSoup.cpp.

(WebKit::CustomProtocolManager::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::CustomProtocolManager::WebSoupRequestAsyncData::~WebSoupRequestAsyncData):
(WebKit::CustomProtocolManager::registerProtocolClass):
(WebKit::CustomProtocolManager::registerScheme):
(WebKit::CustomProtocolManager::unregisterScheme):
(WebKit::CustomProtocolManager::supportsScheme):
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):
(WebKit::CustomProtocolManager::wasRedirectedToRequest):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):

  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::create):

  • NetworkProcess/NetworkSession.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::globalLegacyCustomProtocolManager):
(WebKit::NetworkSessionCocoa::setLegacyCustomProtocolManager):
(WebKit::NetworkSessionCocoa::create):
(WebKit::NetworkSessionCocoa::defaultSession):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
(WebKit::globalCustomProtocolManager): Deleted.
(WebKit::NetworkSessionCocoa::setCustomProtocolManager): Deleted.

  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • UIProcess/API/APICustomProtocolManagerClient.h:

(API::LegacyCustomProtocolManagerClient::~LegacyCustomProtocolManagerClient):
(API::LegacyCustomProtocolManagerClient::startLoading):
(API::LegacyCustomProtocolManagerClient::stopLoading):
(API::LegacyCustomProtocolManagerClient::invalidate):
(API::CustomProtocolManagerClient::~CustomProtocolManagerClient): Deleted.
(API::CustomProtocolManagerClient::startLoading): Deleted.
(API::CustomProtocolManagerClient::stopLoading): Deleted.
(API::CustomProtocolManagerClient::invalidate): Deleted.

  • UIProcess/Cocoa/LegacyCustomProtocolManagerClient.h: Renamed from Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.h.
  • UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm: Renamed from Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.mm.

(-[WKCustomProtocolLoader initWithLegacyCustomProtocolManagerProxy:customProtocolID:request:]):
(-[WKCustomProtocolLoader dealloc]):
(-[WKCustomProtocolLoader customProtocolManagerProxyDestroyed]):
(-[WKCustomProtocolLoader connection:didFailWithError:]):
(-[WKCustomProtocolLoader connection:willCacheResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveData:]):
(-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]):
(-[WKCustomProtocolLoader connectionDidFinishLoading:]):
(WebKit::LegacyCustomProtocolManagerClient::startLoading):
(WebKit::LegacyCustomProtocolManagerClient::stopLoading):
(WebKit::LegacyCustomProtocolManagerClient::invalidate):

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitialize):

  • UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.cpp: Removed.
  • UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp: Added.

(WebKit::LegacyCustomProtocolManagerProxy::LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::~LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
(WebKit::LegacyCustomProtocolManagerProxy::processDidClose):
(WebKit::LegacyCustomProtocolManagerProxy::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
(WebKit::LegacyCustomProtocolManagerProxy::didLoadData):
(WebKit::LegacyCustomProtocolManagerProxy::didFailWithError):
(WebKit::LegacyCustomProtocolManagerProxy::didFinishLoading):

  • UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h: Renamed from Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h.
  • UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in: Renamed from Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in.
  • UIProcess/Network/NetworkProcessProxy.cpp:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::setLegacyCustomProtocolManagerClient):
(WebKit::WebProcessPool::registerSchemeForCustomProtocol):
(WebKit::WebProcessPool::unregisterSchemeForCustomProtocol):
(WebKit::WebProcessPool::setCustomProtocolManagerClient): Deleted.

  • UIProcess/WebProcessPool.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/cocoa/WebProcessCocoa.mm:
6:48 PM Changeset in webkit [213440] by Simon Fraser
  • 9 edits in trunk

Avoid backing store for layers with empty text nodes in a few more cases
​https://bugs.webkit.org/show_bug.cgi?id=169185

Reviewed by Dan Bernstein.

Source/WebCore:

In hasPaintingNonLayerDescendants() we can check whether the RenderText's linesBoundingBox()
is empty to avoid backing store in a few more cases. Also use containsOnlyWhitespace() rather
than isAllCollapsibleWhitespace(), because there's no need for backing store for non-selectable
whitespace text.

Covered by existing tests.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

LayoutTests:

inline-block-no-backing.html enhanced to have a layer with non-collapsible whitespace (an &nbsp;).

Rebaselined other tests.

  • compositing/backing/inline-block-no-backing-expected.txt:
  • compositing/backing/inline-block-no-backing.html:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • css3/blending/blend-mode-clip-accelerated-blending-canvas-expected.txt:
  • platform/ios-simulator-wk2/compositing/backing/inline-block-no-backing-expected.txt:
  • platform/ios-simulator-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
5:37 PM Changeset in webkit [213439] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Drop unnecessary backslash in ResourceResponse::sanitizeSuggestedFilename()
​https://bugs.webkit.org/show_bug.cgi?id=169066

Reviewed by Sam Weinig.

Drop unnecessary backslash in ResourceResponse::sanitizeSuggestedFilename().

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::sanitizeSuggestedFilename):

5:36 PM Changeset in webkit [213438] by Chris Dumez
  • 3 edits
    2 adds in trunk

Using <form> in <template> causes following <form> to get swallowed
​https://bugs.webkit.org/show_bug.cgi?id=163552

Reviewed by Sam Weinig.

Source/WebCore:

As per the HTML specification [1], when finding a "form" tag in the "in body"
insertion mode, we should insert an HTML element for the token, and, if there
is no template element on the stack of open elements, set the form element
pointer to point to the element created.

We were missing the "if there is no template element on the stack of open
elements" check and setting the form element pointer unconditionally.
This patch fixes the issue.

[1] ​https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody:form-element-pointer-2

Test: fast/parser/form-after-template.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLFormElement):

LayoutTests:

Add layout test coverage.

  • fast/parser/form-after-template-expected.html: Added.
  • fast/parser/form-after-template.html: Added.
12:31 PM Changeset in webkit [213437] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

Add support for canvas.toBlob
​https://bugs.webkit.org/show_bug.cgi?id=148878

Reviewed by Tim Horton.

Address additional review feedback received after r213412 landed.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toBlob): Passed null to the blob callback if blob conversion
fails for any reason.

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::cgImage): Removed an unnecessary local variable.

12:14 PM Changeset in webkit [213436] by mmaxfield@apple.com
  • 19 edits
    2 adds in trunk

Update CSSFontSelector's matching algorithm to understand ranges
​https://bugs.webkit.org/show_bug.cgi?id=168892

Reviewed by Jon Lee.

Source/WebCore:

This patch migrates the font selection algorithm out of FontCacheCoreText and into its own file which can be shared
among all ports. It then migrates our web font selection algorithm to use it.

This patch doesn't actually change the parsing rules; it just changes the internal machinery for how fonts get
selected. Therefore, this patch simply makes zero-length ranges from the discrete values the parser emits, and passes
those zero-length ranges to the range-based font selection routine. This means that this patch doesn't actually
change the results of the font selection algorithm.

One of the inputs to the new font selection algorithm is font-stretch, which previously was not parsed inside
@font-face blocks or the CSS Font Loading API. This patch therefore adds parsing support and modifies the existing
tests for these pieces to expect parsing to work. Because the font selection algorithm itself is shared between
installed fonts and webfonts, this patch doesn't add any additional tests for it (because it is already covered under
existing tests).

No new tests because there is no behavior change.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj: Add new file for the font selection algorithm.
  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::calculateStretch): Used on @font-face blocks and the CSS Font Loading API.
(WebCore::CSSFontFace::setStretch): Fill out the previously stubbed function.

  • css/CSSFontFace.h: Add the range member variable to CSSFontFaces.
  • css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered): Now that we care about font-stretch, we need to
look it up for local fonts too. This current approach of an extra FontSelectionValue hanging around with a
FontTraitsMask is very ugly and will be removed soon (​https://bugs.webkit.org/show_bug.cgi?id=168889 and
​https://bugs.webkit.org/show_bug.cgi?id=168890).
(WebCore::computeFontStretch): Used on @font-face blocks and the CSS Font Loading API.
(WebCore::CSSFontFaceSet::matchingFaces): Educate about font-stretch.
(WebCore::CSSFontFaceSet::fontFace): Migrate to the new font-selection algorithm.
(WebCore::fontFaceComparator): Deleted.

  • css/CSSFontFaceSet.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Educate about font-stretch.
(WebCore::CSSFontSelector::fontRangesForFamily): Ditto.

  • css/FontFace.cpp:

(WebCore::FontFace::setStretch): Ditto.
(WebCore::FontFace::stretch): Ditto.

  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseFontFaceDescriptor): Ditto.

  • platform/graphics/FontCache.h: Ditto.
  • platform/graphics/FontDescription.h:
  • platform/graphics/FontSelectionAlgorithm.cpp: Added.

(WebCore::FontSelectionAlgorithm::filterCapability):
(WebCore::FontSelectionAlgorithm::indexOfBestCapabilities):
(WebCore::fontSelectionRequestForTraitsMask):
(WebCore::initialFontSelectionCapabilitiesForTraitsMask):
(WebCore::fontSelectionCapabilitiesForTraitsMask):

  • platform/graphics/FontSelectionAlgorithm.h: Added. Taken from FontCacheCoreText.cpp.

(WebCore::FontSelectionValue::FontSelectionValue):
(WebCore::FontSelectionValue::operator float):
(WebCore::FontSelectionValue::rawValue):
(WebCore::FontSelectionValue::maximumValue):
(WebCore::FontSelectionValue::minimumValue):
(WebCore::FontSelectionValue::operator+):
(WebCore::FontSelectionValue::operator-):
(WebCore::FontSelectionValue::operator*):
(WebCore::FontSelectionValue::operator/):
(WebCore::FontSelectionValue::operator==):
(WebCore::FontSelectionValue::operator!=):
(WebCore::FontSelectionValue::operator<):
(WebCore::FontSelectionValue::operator<=):
(WebCore::FontSelectionValue::operator>):
(WebCore::FontSelectionValue::operator>=):
(WebCore::FontSelectionRange::isValid):
(WebCore::FontSelectionRange::expand):
(WebCore::FontSelectionRange::includes):
(WebCore::FontSelectionRequest::operator==):
(WebCore::FontSelectionRequest::operator!=):
(WebCore::FontSelectionRequestKey::FontSelectionRequestKey):
(WebCore::FontSelectionRequestKey::isHashTableDeletedValue):
(WebCore::FontSelectionRequestKey::operator==):
(WebCore::FontSelectionRequestKeyHash::hash):
(WebCore::FontSelectionRequestKeyHash::equal):
(WebCore::FontSelectionCapabilities::expand):
(WebCore::FontSelectionAlgorithm::FontSelectionAlgorithm):
(WebCore::FontSelectionAlgorithm::iterateActiveCapabilitiesWithReturn):
(WebCore::FontSelectionAlgorithm::iterateActiveCapabilities):

  • platform/graphics/cocoa/FontCacheCoreText.cpp: Moved to FontSelectionAlgorithm.

(WebCore::stretchFromCoreTextTraits):
(WebCore::FontDatabase::capabilitiesForFontDescriptor):
(WebCore::findClosestFont):
(WebCore::calculateFontSelectionRequest):
(WebCore::platformFontLookupWithFamily):
(WebCore::FontCache::getTraitsInFamily): Deleted.
(WebCore::iterateActiveFontsWithReturn): Deleted.
(WebCore::iterateActiveFonts): Deleted.
(WebCore::findClosestStretch): Deleted.
(WebCore::filterStretch): Deleted.
(WebCore::findClosestStyle): Deleted.
(WebCore::filterStyle): Deleted.
(WebCore::findClosestWeight): Deleted.
(WebCore::filterWeight): Deleted.
(WebCore::computeTargetWeight): Deleted.

  • platform/text/TextFlags.h: Moved to FontSelectionAlgorithm.

(WebCore::FontSelectionValue::FontSelectionValue): Deleted.
(WebCore::FontSelectionValue::operator float): Deleted.
(WebCore::FontSelectionValue::operator+): Deleted.
(WebCore::FontSelectionValue::operator-): Deleted.
(WebCore::FontSelectionValue::operator*): Deleted.
(WebCore::FontSelectionValue::operator/): Deleted.
(WebCore::FontSelectionValue::operator==): Deleted.
(WebCore::FontSelectionValue::operator!=): Deleted.
(WebCore::FontSelectionValue::operator<): Deleted.
(WebCore::FontSelectionValue::operator<=): Deleted.
(WebCore::FontSelectionValue::operator>): Deleted.
(WebCore::FontSelectionValue::operator>=): Deleted.
(WebCore::FontSelectionValue::rawValue): Deleted.
(WebCore::FontSelectionValue::maximumValue): Deleted.
(WebCore::FontSelectionValue::minimumValue): Deleted.
(WebCore::FontSelectionRange::isValid): Deleted.
(WebCore::FontSelectionRange::expand): Deleted.
(WebCore::FontSelectionRange::includes): Deleted.
(WebCore::FontSelectionCapabilities::expand): Deleted.

LayoutTests:

Update CSS Font Loading API test to accept font-stretch values.

  • fast/text/font-face-javascript-expected.txt:
  • fast/text/font-face-javascript.html:
11:14 AM Changeset in webkit [213435] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Make some RenderLayer tree traversal in RenderLayerBacking more generic
​https://bugs.webkit.org/show_bug.cgi?id=169177

Reviewed by Zalan Bujtas.

The real goal of this patch is reduce the number of callers of
RenderLayerBacking::isPaintDestinationForDescendantLayers() to one. To achieve that,
have the setContentsVisible() logic (which is really just about the CSS 'visibility' property)
do its own tree traversal which just consults layer.hasVisibleContent(). So
make descendantLayerPaintsIntoAncestor() a generic traversal function which walks
descendant layers which may paint into the target layer. The "Visible" in the name
reflects the fact that it can bypass a subtree for a layer with !hasVisibleDescendant().

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::traverseVisibleNonCompositedDescendantLayers):
(WebCore::RenderLayerBacking::isPaintDestinationForDescendantLayers):
(WebCore::RenderLayerBacking::hasVisibleNonCompositedDescendants):
(WebCore::descendantLayerPaintsIntoAncestor): Deleted.

  • rendering/RenderLayerBacking.h:
3:10 AM Changeset in webkit [213434] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] Two file reset tests are failing in the bots since they were added in r213042
​https://bugs.webkit.org/show_bug.cgi?id=169126

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2017-03-05
Reviewed by Michael Catanzaro.

They are failing because the GTK+ event sender is not firing the second UIHelper.activateAt() after the change
event. In one case this causes that the reset button is not clicked, and in the other one the file input is not
unfocused. This is because the change event is emitted before the mouse up, and the GTK+ event sender ignores
mouse down events when the button is already down to not confuse Xvfb. So, we can easily fix theses tests by
using a timeout to ensure the next UIHelper.activateAt() happens in a different run loop iteration, after the
mouse up.

  • fast/forms/file/file-input-reset-using-open-panel.html:
  • fast/forms/file/file-reset-in-change-using-open-panel.html:
12:37 AM Changeset in webkit [213433] by Yusuke Suzuki
  • 3 edits in trunk/Source/JavaScriptCore

[JSCOnly][GTK] Suppress warnings on return type in B3 and WASM
​https://bugs.webkit.org/show_bug.cgi?id=168869

Reviewed by Keith Miller.

  • b3/B3Width.h:
  • wasm/WasmSections.h:

Mar 4, 2017:

11:41 PM Changeset in webkit [213432] by mitz@apple.com
  • 2 edits
    1 add in trunk/Source/ThirdParty/libwebrtc

[Cocoa] libwebrtc.dylib’s current version is fixed at 1.0.0
​https://bugs.webkit.org/show_bug.cgi?id=169170

Reviewed by Alex Christensen.

  • Configurations/Version.xcconfig: Copied from Source/JavaScriptCore/Configurations/Version.xcconfig. This defines DYLIB_CURRENT_VERSION.
  • Configurations/libwebrtc.xcconfig: Include Version.xcconfig.
5:06 PM Changeset in webkit [213431] by Chris Dumez
  • 2 edits in trunk/LayoutTests/imported/w3c

Rebaseline W3C test after r213412.

  • web-platform-tests/html/dom/interfaces-expected.txt:
2:39 PM Changeset in webkit [213430] by eric.carlson@apple.com
  • 4 edits
    1 add in trunk/Source/WebKit2

[iOS] The web process should inherit application state from UI process
​https://bugs.webkit.org/show_bug.cgi?id=169156
<rdar://problem/30845473>

Reviewed by Alexey Proskuryakov.

  • Platform/spi/ios/CelestialSPI.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Include CelestialSPI.h.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist: Add entitlement.
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformInitialize): Set up PID proxying.

1:49 PM Changeset in webkit [213429] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Clarify some terminology in RenderLayerBacking
​https://bugs.webkit.org/show_bug.cgi?id=169174

Reviewed by Zalan Bujtas.

Rename some functions related to directly-composited background images and
box decorations for clarify.

Only behavior change is for canDirectlyCompositeBackgroundBackgroundImage() to check
GraphicsLayer::supportsContentsTiling(), which means that RenderLayerBacking::contentChanged()
will no longer trigger a updateGeometry() when it gets BackgroundImageChanged on non-
CoordinateGraphics platforms.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBoxDecorations):
(WebCore::canDirectlyCompositeBackgroundBackgroundImage):
(WebCore::hasPaintedBoxDecorationsOrBackgroundImage):
(WebCore::supportsDirectlyCompositedBoxDecorations):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents): Deleted.
(WebCore::canCreateTiledImage): Deleted.
(WebCore::hasVisibleBoxDecorationsOrBackgroundImage): Deleted.
(WebCore::supportsDirectBoxDecorationsComposition): Deleted.

  • rendering/RenderLayerBacking.h:
1:05 PM Changeset in webkit [213428] by aakash_jain@apple.com
  • 2 edits
    1 add in trunk/Source/WebKit2

Add symbols required by TAPI from Shared/API/Cocoa/WebKit.m in a header file
​https://bugs.webkit.org/show_bug.cgi?id=169162

Reviewed by Alexey Proskuryakov.

The symbols from binary and headers should match precisely, otherwise TAPI would
complain. There are few symbols which are not actually needed in header file, but
we still need to add them in a header file to make TAPI happy.

  • Platform/ExtraPublicSymbolsForTAPI.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Added ExtraPublicSymbolsForTAPI.h
11:53 AM Changeset in webkit [213427] by aakash_jain@apple.com
  • 2 edits
    1 add in trunk/Source/WebKit2

Add symbols required by TAPI in a header file
​https://bugs.webkit.org/show_bug.cgi?id=169113
<rdar://problem/30772033>

Reviewed by Alexey Proskuryakov.

The symbols from binary and headers should match precisely, otherwise TAPI would
complain. There are few symbols which are not actually needed in header file, but
we still need to add them in a header file to make TAPI happy.

  • Platform/ExtraPrivateSymbolsForTAPI.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Added Platform/ExtraPrivateSymbolsForTAPI.h
11:32 AM Changeset in webkit [213426] by Michael Catanzaro
  • 2 edits in trunk

Unreviewed, remove stray period from readme

  • ReadMe.md:
10:07 AM Changeset in webkit [213425] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[ARM] Unreviewed buildfix after r213376.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::isBkpt): Typo fixed.

9:31 AM Changeset in webkit [213424] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Cleanup after r213418
​https://bugs.webkit.org/show_bug.cgi?id=169165

Patch by Alex Christensen <​achristensen@webkit.org> on 2017-03-04
Reviewed by Youenn Fablet.

Source/ThirdParty/libwebrtc:

  • WebKit/patch-libwebrtc:

I made another change after the last patch I uploaded to stop crashing.
This should be reflected in our patch.

Source/WebCore:

  • platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::OnData):
Restore the assertion I removed.

9:15 AM Changeset in webkit [213423] by commit-queue@webkit.org
  • 38 edits
    2 adds
    22 deletes in trunk

Unreviewed, rolling out r213379.
​https://bugs.webkit.org/show_bug.cgi?id=169169

broke GTK+ and Windows builds (Requested by mcatanzaro on
#webkit).

Reverted changeset:

"Enable fieldsets to be flexboxes, grids and multicolumn."
​https://bugs.webkit.org/show_bug.cgi?id=169082
​http://trac.webkit.org/changeset/213379

6:52 AM Changeset in webkit [213422] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test commit against svn.webkit.org after SHA-1 cleanup.

Unreviewed.

12:57 AM Changeset in webkit [213421] by Nikita Vasilyev
  • 10 edits
    8 adds in trunk

Web Inspector: Show Web Socket connections in Network tab
​https://bugs.webkit.org/show_bug.cgi?id=167520

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

Show Web Socket connections in Network and Resources tabs. Display HTTP headers
of Web Socket handshake request in the details sidebar.

  • UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype.initialize):
(WebInspector.FrameResourceManager.prototype.webSocketCreated):
(WebInspector.FrameResourceManager.prototype.webSocketWillSendHandshakeRequest):
webSocketWillSendHandshakeRequest doesn't receive a request URL as one of its parameters.
Store URLs received from webSocketCreated method in _webSocketIdentifierToURL map.

(WebInspector.FrameResourceManager.prototype.webSocketHandshakeResponseReceived):
(WebInspector.FrameResourceManager.prototype.webSocketFrameReceived):
(WebInspector.FrameResourceManager.prototype.webSocketFrameSent):
(WebInspector.FrameResourceManager.prototype.webSocketClosed):
Mark resource as finished when Web Socket handshake is complete or Web Socket is closed.
This may change in the future.

(WebInspector.FrameResourceManager.prototype._webSocketFrameReceivedOrSent):

  • UserInterface/Main.html:
  • UserInterface/Models/WebSocketResource.js: Added.

(WebInspector.WebSocketResource):
(WebInspector.WebSocketResource.prototype.set readyState):
(WebInspector.WebSocketResource.prototype.get readyState):
(WebInspector.WebSocketResource.prototype.get frames):
(WebInspector.WebSocketResource.prototype.addFrame):
Introduce WebSocketResource model to store WebSocket frames (incoming and outgoing messages)
and readyState.

  • UserInterface/Protocol/NetworkObserver.js:

(WebInspector.NetworkObserver.prototype.webSocketCreated):
(WebInspector.NetworkObserver.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkObserver.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkObserver.prototype.webSocketClosed):
(WebInspector.NetworkObserver.prototype.webSocketFrameReceived):
(WebInspector.NetworkObserver.prototype.webSocketFrameError):
(WebInspector.NetworkObserver.prototype.webSocketFrameSent):
(WebInspector.NetworkObserver):
Add corresponding methods for the newly added FrameResourceManager methods.

  • UserInterface/Test.html:
  • UserInterface/Views/NetworkSidebarPanel.js:

(WebInspector.NetworkSidebarPanel.prototype.treeElementAddedOrChanged):
Don't show the go to arrow for WebSocket items since WebSocketContentView isn't implemented
yet.

  • UserInterface/Views/ResourceClusterContentView.js:

(WebInspector.ResourceClusterContentView.prototype.get responseContentView):
Don't show any content views for WebSocket items.

  • UserInterface/Views/ResourceTreeElement.js:

(WebInspector.ResourceTreeElement.prototype.ondblclick):
Don't open WebSocket URL in a new browser tab.

LayoutTests:

  • http/tests/websocket/tests/hybi/inspector/client-close-expected.txt: Added.
  • http/tests/websocket/tests/hybi/inspector/client-close.html: Added.
  • http/tests/websocket/tests/hybi/inspector/client-close_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/inspector/server-close-expected.txt: Added.
  • http/tests/websocket/tests/hybi/inspector/server-close.html: Added.
  • http/tests/websocket/tests/hybi/inspector/server-close_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • platform/ios-simulator/TestExpectations:
12:38 AM Changeset in webkit [213420] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove duplicate initialization guard in WebKit2 logging initialization
​https://bugs.webkit.org/show_bug.cgi?id=169164

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-04
Reviewed by Dan Bernstein.

  • Platform/Logging.cpp:

(WebKit::initializeLogChannelsIfNecessary):

12:20 AM Changeset in webkit [213419] by achristensen@apple.com
  • 2 edits in trunk/Source/WTF

[Win64] 'int128_t': undeclared identifier in MediaTime.cpp
​https://bugs.webkit.org/show_bug.cgi?id=169123

Patch by Jer Noble <​jer.noble@apple.com> on 2017-03-03
Reviewed by Alex Christensen.

Don't perform the 128-bit optimized path on Windows, where the int128_t intrinsic isn't available.

  • wtf/MediaTime.cpp:

(WTF::MediaTime::setTimeScale):

Mar 3, 2017:

11:57 PM Changeset in webkit [213418] by achristensen@apple.com
  • 1413 edits
    776 adds
    422 deletes in trunk/Source

[WebRTC] Update libwebrtc source code
​https://bugs.webkit.org/show_bug.cgi?id=168599

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-03
Reviewed by Alex Christensen.

Source/ThirdParty/libwebrtc:

Very long list of file changes omitted.

We updated to git commit 716e726ef0b322e8317b749613691da043bfc61c
of ​https://chromium.googlesource.com/external/webrtc and applied
the changes that are now in WebKit/patch-libwebrtc

Source/WebCore:

  • Modules/mediastream/RTCStatsReport.h:
  • Modules/mediastream/RTCStatsReport.idl:

Update to match the latest spec, which matches the new structures in libwebrtc.

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::fillRTCRTPStreamStats):
(WebCore::fillOutboundRTPStreamStats):

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
  • platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
  • platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::OnData):
Comment out an assertion that was failing. We should revisit this.

  • testing/MockLibWebRTCPeerConnection.h:

Source/WebKit2:

  • WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
9:49 PM Changeset in webkit [213417] by commit-queue@webkit.org
  • 11 edits
    15 deletes in trunk

Unreviewed, rolling out r213400.
​https://bugs.webkit.org/show_bug.cgi?id=169163

Caused frequent assertion failures (Requested by ap on
#webkit).

Reverted changeset:

"[Modern Media Controls] Improve media documents across macOS,
iPhone and iPad"
​https://bugs.webkit.org/show_bug.cgi?id=169145
​http://trac.webkit.org/changeset/213400

9:01 PM Changeset in webkit [213416] by clopez@igalia.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] build fix after r213399
​https://bugs.webkit.org/show_bug.cgi?id=169154

Unreviewed.

  • runtime/ConfigFile.cpp: Include unistd.h since its where getcwd() is defined.
6:43 PM Changeset in webkit [213415] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-603.1.30.1.32

Tag Safari-603.1.30.1.32.

6:43 PM Changeset in webkit [213414] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-603.1.30.0.33

Tag Safari-603.1.30.0.33.

6:21 PM Changeset in webkit [213413] by jmarcell@apple.com
  • 6 edits in tags/Safari-604.1.8.1.1/Source

Versioning.

6:16 PM Changeset in webkit [213412] by aestes@apple.com
  • 15 edits
    3 adds in trunk

Add support for canvas.toBlob
​https://bugs.webkit.org/show_bug.cgi?id=148878
<rdar://problem/22590406>

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png-expected.txt:

Source/WebCore:

These tests now pass:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/BlobCallback.cpp: Added.

(WebCore::BlobCallback::scheduleCallback):

  • fileapi/BlobCallback.h: Added.

(WebCore::BlobCallback::~BlobCallback):

  • fileapi/BlobCallback.idl: Added.
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toBlob):

  • html/HTMLCanvasElement.h:
  • html/HTMLCanvasElement.idl:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::writeFunction):
(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::data):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):
(WebCore::ImageBuffer::toCGImage):
(WebCore::cgImage):
(WebCore::dataURL):

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):

  • platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::ImageBuffer::toData):

6:15 PM Changeset in webkit [213411] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.8.1.1

Tag Safari-604.1.8.1.1.

6:08 PM Changeset in webkit [213410] by dino@apple.com
  • 32 edits in trunk

Add WebGPU compile flag and experimental feature flag
​https://bugs.webkit.org/show_bug.cgi?id=169161
<rdar://problem/30846689>

Reviewed by Tim Horton.

Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
and an InternalSetting.

.:

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebGPUEnabled):
(WebCore::RuntimeEnabledFeatures::webGPUEnabled):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setWebGPUEnabled):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences webGPUEnabled]):
(-[WebPreferences setWebGPUEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Shared/WebPreferencesDefinitions.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setWebGL2Enabled):
(WTR::TestRunner::setWebGPUEnabled):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
6:04 PM Changeset in webkit [213409] by jmarcell@apple.com
  • 2 edits in tags/Safari-604.1.8.0.2/Source/WebKit/mac

Merge r213373. rdar://problem/30825660

6:04 PM Changeset in webkit [213408] by jmarcell@apple.com
  • 2 edits in tags/Safari-604.1.8.0.2/Source/WebKit2

Merge r213394. rdar://problem/30825728

5:56 PM Changeset in webkit [213407] by jmarcell@apple.com
  • 6 edits in tags/Safari-604.1.8.0.2/Source

Versioning.

5:52 PM Changeset in webkit [213406] by matthew_hanson@apple.com
  • 9 edits
    2 adds in branches/safari-603.1.30.0-branch

Merge r213253. rdar://problem/30773140

5:45 PM Changeset in webkit [213405] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Clean up some RenderLayerBacking code
​https://bugs.webkit.org/show_bug.cgi?id=169160

Reviewed by Dean Jackson.

Modern loops in descendantLayerPaintsIntoAncestor().

Rename RenderLayerBacking::paintsChildren() to RenderLayerBacking::paintsChildRenderers() to clarify that
it refers to renderers, not RenderLayers.

Rename RenderLayerBacking::paintsNonDirectCompositedBoxDecoration() to RenderLayerBacking::paintsBoxDecorations().
"Paints" already implies non-composited.

No behavior change.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::paintsChildRenderers):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::descendantLayerPaintsIntoAncestor):
(WebCore::RenderLayerBacking::paintsNonDirectCompositedBoxDecoration): Deleted.
(WebCore::RenderLayerBacking::paintsChildren): Deleted.

  • rendering/RenderLayerBacking.h:
5:45 PM Changeset in webkit [213404] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Clean up RenderImage and a RenderImageResource function
​https://bugs.webkit.org/show_bug.cgi?id=169153

Reviewed by Zalan Bujtas.

Change all calls to imageResource().cachedImage() in RenderImage to use the inline
cachedImage() function.

In RenderImage::paintReplaced(), early return after the broken image block (and no need
to test imageResource().hasImage() again in the second condition). Convert height/width to size,
which also forces us to be explicit about using flooredIntSize() when fetching the image
(perhaps this should be a roundedIntSize, but I didn't want to change behavior).

Change RenderImageResource::image() to take an IntSize, rather than int height and width.

No behavior change.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::styleDidChange):
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::notifyFinished):
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
(WebCore::RenderImage::embeddedContentBox):

  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::image):

  • rendering/RenderImageResource.h:

(WebCore::RenderImageResource::image):

  • rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::image):

  • rendering/RenderImageResourceStyleImage.h:
5:45 PM Changeset in webkit [213403] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.8.0.2

New Tag.

5:42 PM Changeset in webkit [213402] by jmarcell@apple.com
  • 2 edits in tags/Safari-604.1.8.0.1/Source/WebKit2

Roll out r213394 via r213396. rdar://problem/30825728

5:42 PM Changeset in webkit [213401] by jmarcell@apple.com
  • 2 edits in tags/Safari-604.1.8.0.1/Source/WebKit/mac

Roll out r213373 via r213388. rdar://problem/30825660

5:12 PM Changeset in webkit [213400] by commit-queue@webkit.org
  • 11 edits
    2 copies
    17 adds in trunk

[Modern Media Controls] Improve media documents across macOS, iPhone and iPad
​https://bugs.webkit.org/show_bug.cgi?id=169145
<rdar://problem/17048858>

Patch by Antoine Quint <Antoine Quint> on 2017-03-03
Reviewed by Dean Jackson.

Source/WebCore:

There were a variety of issues with media documents, some longstanding, and some specifically
about modern media controls.

One issue was that fullscreen and picture-in-picture buttons would show for audio media documents,
due to using a <video> element to load the audio file. We now have additional logic in MediaController
to identify if the loaded media is really an audio file, and using this information to hide the
fullscreen and picture-in-picture buttons.

Another issue was that we would inject style in MediaDocument.cpp that was specific to modern media
controls when we could have the modern-media-controls module injected CSS handle this styling. We now
use the injected style in the shadow root to size media documents based on the device characteristics
and ensuring that page styles are overridden.

We also simplify how MediaDocument.cpp sets the source of the media element to simply use the "src"
attribute and not a <source> element.

Finally, we introduce a MediaDocumentController class that is instantiated when we're dealing with
a media document to hide the controls while we determine the type of media we're loading (audio vs.
video) in order to apply the appropriate styling without flashes.

As a result of the new styles applied by the modern-media-controls module, media documents have a
similar behavior on macOS and iPad, where we only enforce a min-width for video allowing them
to play at their natural size otherwise, and enforcing a fixed width for audio. On iPhone however,
we want to always play the media at full width, with some padding in the case of audio.

Tests: media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html

media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html
media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html
media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html
media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html
media/modern-media-controls/media-documents/media-document-video-ios-sizing.html
media/modern-media-controls/media-documents/media-document-video-mac-sizing.html
media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only.html

  • Modules/modern-media-controls/controls/ios-inline-media-controls.css:

(:host(audio) .media-controls.ios.inline > .controls-bar:before,):
(:host(audio) .media-controls.ios.inline > .controls-bar:before): Deleted.

  • Modules/modern-media-controls/controls/macos-media-controls.css:

(:host(audio) .media-controls.mac.inline > .controls-bar,):
(:host(audio) .media-controls.mac.inline > .controls-bar > .background-tint,):
(:host(audio) .media-controls.mac.inline > .controls-bar): Deleted.
(:host(audio) .media-controls.mac.inline > .controls-bar > .background-tint): Deleted.

  • Modules/modern-media-controls/controls/media-document.css: Added.

(:host(.media-document)):
(:host(.media-document.ready)):
(:host(.media-document.audio.mac)):
(:host(.media-document.audio.ipad)):
(:host(.media-document.audio.iphone)):
(:host(.media-document.video.mac)):
(:host(.media-document.video.ipad)):
(:host(.media-document.video.iphone)):

  • Modules/modern-media-controls/js-files:
  • Modules/modern-media-controls/media/fullscreen-support.js:

(FullscreenSupport.prototype.syncControl):
(FullscreenSupport):

  • Modules/modern-media-controls/media/media-controller.js:

(MediaController):
(MediaController.prototype.get isAudio):

  • Modules/modern-media-controls/media/media-document-controller.js: Added.

(MediaDocumentController):
(MediaDocumentController.prototype.handleEvent):
(MediaDocumentController.prototype._mediaDocumentHasMetadata):
(MediaDocumentController.prototype._mediaDocumentHasSize):

  • Modules/modern-media-controls/media/pip-support.js:

(PiPSupport.prototype.syncControl):
(PiPSupport):

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

We add new tests for media documents and related features that cover the following cases:

  • checking <video> with only audio tracks does not show the fullscreen button
  • checking <video> with only audio tracks does not show the picture-in-picture button
  • checking the size used in media documents for audio and video across macOS, iPhone and iPad
  • media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
  • media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html: Added.
  • media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing-expected.txt: Added.
  • media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html: Added.
  • media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing-expected.txt: Added.
  • media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html: Added.
  • media/modern-media-controls/media-documents/media-document-audio-ios-sizing-expected.txt: Added.
  • media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html: Added.
  • media/modern-media-controls/media-documents/media-document-audio-mac-sizing-expected.txt: Added.
  • media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html: Added.
  • media/modern-media-controls/media-documents/media-document-video-ios-sizing-expected.txt: Added.
  • media/modern-media-controls/media-documents/media-document-video-ios-sizing.html: Added.
  • media/modern-media-controls/media-documents/media-document-video-mac-sizing-expected.txt: Added.
  • media/modern-media-controls/media-documents/media-document-video-mac-sizing.html: Added.
  • media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
  • media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only.html: Added.
  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
5:10 PM Changeset in webkit [213399] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add support for relative pathnames to JSC config files
​https://bugs.webkit.org/show_bug.cgi?id=169154

Reviewed by Saam Barati.

If the config file is a relative path, prepend the current working directory.
After canonicalizing the config file path, we extract its directory path and
use that for the directory for a relative log pathname.

  • runtime/ConfigFile.cpp:

(JSC::ConfigFile::ConfigFile):
(JSC::ConfigFile::parse):
(JSC::ConfigFile::canonicalizePaths):

  • runtime/ConfigFile.h:
5:03 PM Changeset in webkit [213398] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Move Input Events and Gamepad from experimental features into main preferences
​https://bugs.webkit.org/show_bug.cgi?id=169157
<rdar://problems/30845587>

Reviewed by Myles C. Maxfield.

These are no longer experimental on trunk.

  • Shared/WebPreferencesDefinitions.h:
4:55 PM Changeset in webkit [213397] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add load / store exclusive instruction group to ARM64 disassembler
​https://bugs.webkit.org/show_bug.cgi?id=169152

Reviewed by Filip Pizlo.

  • disassembler/ARM64/A64DOpcode.cpp:

(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::format):

  • disassembler/ARM64/A64DOpcode.h:

(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::opName):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::rs):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::rt2):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::o0):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::o1):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::o2):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::loadBit):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::opNumber):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::isPairOp):

4:48 PM Changeset in webkit [213396] by jmarcell@apple.com
  • 2 edits in tags/Safari-604.1.8.0.1/Source/WebKit2

Merge r213394. rdar://problem/30825728

4:48 PM Changeset in webkit [213395] by dino@apple.com
  • 2 edits
    1 add in trunk/Tools

Add a script to synchronize FeatureDefines.xcconfig files
​https://bugs.webkit.org/show_bug.cgi?id=169151
<rdar://problem/30841856>

Reviewed by Simon Fraser.

I got sick of manually copying the FeatureDefines.xcconfig
files, so I added a script to do it. As long as you
run this after you've edited one, it will take the most
recently updated and copy it to all the others.

  • Scripts/sync-feature-defines: Added.
  • Scripts/webkitpy/style/checkers/featuredefines.py:

(FeatureDefinesChecker.check): Export the list of files,
and give a suggestion to use the sync script.

4:34 PM Changeset in webkit [213394] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

[MediaStream iOS] REGRESSION(r212883): Missing function definition breaks sandbox
​https://bugs.webkit.org/show_bug.cgi?id=169148
<rdar://problem/30825728>

Reviewed by Alex Christensen.

The changes in r212883 added a call to 'shared-preferences-read', which is not defined
for iOS. In fact, it's not needed since 'user-preference-read' does everything we need on iOS.
Switch to the correct preference rule.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Add missing function
3:54 PM Changeset in webkit [213393] by Chris Dumez
  • 11 edits
    2 adds in trunk

[iOS] Throttle SVG SMIL animations to 30fps in low power mode
​https://bugs.webkit.org/show_bug.cgi?id=169137
<rdar://problem/30833754>

Reviewed by Simon Fraser.

Source/WebCore:

Throttle SVG SMIL animations to 30fps in low power mode on iOS to save
battery.

Test: svg/animations/animations-lowPowerMode-throttling.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement):

  • svg/SVGSVGElement.idl:
  • svg/animation/SMILTime.h:

(WebCore::SMILTime::SMILTime):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::SMILTimeContainer):
(WebCore::SMILTimeContainer::animationFrameDelay):
(WebCore::SMILTimeContainer::updateDocumentOrderIndexes):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SMILTimeContainer.h:
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateNextProgressTime):

  • testing/Internals.cpp:

(WebCore::Internals::svgAnimationsInterval):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Add layout test coverage.

  • svg/animations/animations-lowPowerMode-throttling-expected.txt: Added.
  • svg/animations/animations-lowPowerMode-throttling.html: Added.
3:03 PM Changeset in webkit [213392] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

[Mac] WebCore.framework is missing a symlink from Frameworks to Versions/Current/Frameworks when the latter exists
​https://bugs.webkit.org/show_bug.cgi?id=169067

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj:
2:38 PM Changeset in webkit [213391] by achristensen@apple.com
  • 1 edit
    1 delete in trunk/Source/ThirdParty/libwebrtc

Remove empty build directories.

  • build: Removed.
  • build/Debug: Removed.
2:35 PM Changeset in webkit [213390] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603.1.30.0-branch

Merge r213385. rdar://problem/30838985

2:35 PM Changeset in webkit [213389] by matthew_hanson@apple.com
  • 9 edits
    2 deletes in branches/safari-603.1.30.0-branch

Roll out r213253 via r213374. rdar://problem/30773140

2:34 PM Changeset in webkit [213388] by jmarcell@apple.com
  • 2 edits in tags/Safari-604.1.8.0.1/Source/WebKit/mac

Merge r213373. rdar://problem/30825660

2:34 PM Changeset in webkit [213387] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603.1.30.1-branch

Merge r213385. rdar://problem/30838984

2:24 PM Changeset in webkit [213386] by keith_miller@apple.com
  • 34 edits
    2 copies
    2 adds in trunk/Source

WASM should support faster loads.
​https://bugs.webkit.org/show_bug.cgi?id=162693

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch adds support for WebAssembly using a 32-bit address
space for memory (along with some extra space for offset
overflow). With a 32-bit address space (we call them
Signaling/fast memories), we reserve the virtual address space for
232 + offset bytes of memory and only mark the usable section as
read/write. If wasm code would read/write out of bounds we use a
custom signal handler to catch the SIGBUS. The signal handler then
checks if the faulting instruction is wasm code and tells the
thread to resume executing from the wasm exception
handler. Otherwise, the signal handler crashes the process, as
usual.

All of the allocations of these memories are managed by the
Wasm::Memory class. In order to avoid TLB churn in the OS we cache
old Signaling memories that are no longer in use. Since getting
the wrong memory can cause recompiles, we try to reserve a memory
for modules that do not import a memory. If a module does import a
memory, we try to guess the type of memory we are going to get
based on the last one allocated.

This patch also changes how the wasm JS-api manages objects. Since
we can compile different versions of code, this patch adds a new
JSWebAssemblyCodeBlock class that holds all the information
specific to running a module in a particular bounds checking
mode. Additionally, the Wasm::Memory object is now a reference
counted class that is shared between the JSWebAssemblyMemory
object and the ArrayBuffer that also views it.

(JSC::JITThunks::existingCTIStub):

  • jit/JITThunks.h:
  • jsc.cpp:

(jscmain):

  • runtime/Options.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
  • wasm/JSWebAssemblyCodeBlock.h: Copied from Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.h.

(JSC::JSWebAssemblyCodeBlock::create):
(JSC::JSWebAssemblyCodeBlock::createStructure):
(JSC::JSWebAssemblyCodeBlock::functionImportCount):
(JSC::JSWebAssemblyCodeBlock::mode):
(JSC::JSWebAssemblyCodeBlock::module):
(JSC::JSWebAssemblyCodeBlock::jsEntrypointCalleeFromFunctionIndexSpace):
(JSC::JSWebAssemblyCodeBlock::wasmEntrypointCalleeFromFunctionIndexSpace):
(JSC::JSWebAssemblyCodeBlock::setJSEntrypointCallee):
(JSC::JSWebAssemblyCodeBlock::setWasmEntrypointCallee):
(JSC::JSWebAssemblyCodeBlock::callees):
(JSC::JSWebAssemblyCodeBlock::offsetOfCallees):
(JSC::JSWebAssemblyCodeBlock::allocationSize):

  • wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::getMemoryBaseAndSize):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::B3IRGenerator::emitLoadOp):
(JSC::Wasm::B3IRGenerator::emitStoreOp):

  • wasm/WasmCallingConvention.h:
  • wasm/WasmFaultSignalHandler.cpp: Added.

(JSC::Wasm::trapHandler):
(JSC::Wasm::registerCode):
(JSC::Wasm::unregisterCode):
(JSC::Wasm::fastMemoryEnabled):
(JSC::Wasm::enableFastMemory):

  • wasm/WasmFaultSignalHandler.h: Copied from Source/JavaScriptCore/wasm/js/JSWebAssemblyCallee.cpp.
  • wasm/WasmFormat.h:

(JSC::Wasm::ModuleInformation::importFunctionCount):
(JSC::Wasm::ModuleInformation::hasMemory): Deleted.

  • wasm/WasmMemory.cpp:

(JSC::Wasm::mmapBytes):
(JSC::Wasm::Memory::lastAllocatedMode):
(JSC::Wasm::availableFastMemories):
(JSC::Wasm::tryGetFastMemory):
(JSC::Wasm::releaseFastMemory):
(JSC::Wasm::Memory::Memory):
(JSC::Wasm::Memory::createImpl):
(JSC::Wasm::Memory::create):
(JSC::Wasm::Memory::~Memory):
(JSC::Wasm::Memory::grow):
(JSC::Wasm::Memory::dump):
(JSC::Wasm::Memory::makeString):

  • wasm/WasmMemory.h:

(JSC::Wasm::Memory::operator bool):
(JSC::Wasm::Memory::size):
(JSC::Wasm::Memory::check):
(JSC::Wasm::Memory::Memory): Deleted.
(JSC::Wasm::Memory::offsetOfMemory): Deleted.
(JSC::Wasm::Memory::offsetOfSize): Deleted.

  • wasm/WasmMemoryInformation.cpp:

(JSC::Wasm::MemoryInformation::MemoryInformation):

  • wasm/WasmMemoryInformation.h:

(JSC::Wasm::MemoryInformation::hasReservedMemory):
(JSC::Wasm::MemoryInformation::takeReservedMemory):
(JSC::Wasm::MemoryInformation::mode):

  • wasm/WasmModuleParser.cpp:
  • wasm/WasmModuleParser.h:

(JSC::Wasm::ModuleParser::ModuleParser):

  • wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::parseAndValidateModule):
(JSC::Wasm::Plan::run):

  • wasm/WasmPlan.h:

(JSC::Wasm::Plan::mode):

  • wasm/js/JSWebAssemblyCallee.cpp:

(JSC::JSWebAssemblyCallee::finishCreation):
(JSC::JSWebAssemblyCallee::destroy):

  • wasm/js/JSWebAssemblyCodeBlock.cpp: Added.

(JSC::JSWebAssemblyCodeBlock::JSWebAssemblyCodeBlock):
(JSC::JSWebAssemblyCodeBlock::destroy):
(JSC::JSWebAssemblyCodeBlock::isSafeToRun):
(JSC::JSWebAssemblyCodeBlock::visitChildren):
(JSC::JSWebAssemblyCodeBlock::UnconditionalFinalizer::finalizeUnconditionally):

  • wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::setMemory):
(JSC::JSWebAssemblyInstance::finishCreation):
(JSC::JSWebAssemblyInstance::visitChildren):

  • wasm/js/JSWebAssemblyInstance.h:

(JSC::JSWebAssemblyInstance::module):
(JSC::JSWebAssemblyInstance::codeBlock):
(JSC::JSWebAssemblyInstance::memoryMode):
(JSC::JSWebAssemblyInstance::setMemory): Deleted.

  • wasm/js/JSWebAssemblyMemory.cpp:

(JSC::JSWebAssemblyMemory::create):
(JSC::JSWebAssemblyMemory::JSWebAssemblyMemory):
(JSC::JSWebAssemblyMemory::buffer):
(JSC::JSWebAssemblyMemory::grow):
(JSC::JSWebAssemblyMemory::destroy):

  • wasm/js/JSWebAssemblyMemory.h:

(JSC::JSWebAssemblyMemory::memory):
(JSC::JSWebAssemblyMemory::offsetOfMemory):
(JSC::JSWebAssemblyMemory::offsetOfSize):

  • wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::buildCodeBlock):
(JSC::JSWebAssemblyModule::create):
(JSC::JSWebAssemblyModule::JSWebAssemblyModule):
(JSC::JSWebAssemblyModule::codeBlock):
(JSC::JSWebAssemblyModule::finishCreation):
(JSC::JSWebAssemblyModule::visitChildren):
(JSC::JSWebAssemblyModule::UnconditionalFinalizer::finalizeUnconditionally): Deleted.

  • wasm/js/JSWebAssemblyModule.h:

(JSC::JSWebAssemblyModule::takeReservedMemory):
(JSC::JSWebAssemblyModule::signatureIndexFromFunctionIndexSpace):
(JSC::JSWebAssemblyModule::codeBlock):
(JSC::JSWebAssemblyModule::functionImportCount): Deleted.
(JSC::JSWebAssemblyModule::jsEntrypointCalleeFromFunctionIndexSpace): Deleted.
(JSC::JSWebAssemblyModule::wasmEntrypointCalleeFromFunctionIndexSpace): Deleted.
(JSC::JSWebAssemblyModule::setJSEntrypointCallee): Deleted.
(JSC::JSWebAssemblyModule::setWasmEntrypointCallee): Deleted.
(JSC::JSWebAssemblyModule::callees): Deleted.
(JSC::JSWebAssemblyModule::offsetOfCallees): Deleted.
(JSC::JSWebAssemblyModule::allocationSize): Deleted.

  • wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

  • wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):

  • wasm/js/WebAssemblyMemoryConstructor.cpp:

(JSC::constructJSWebAssemblyMemory):

  • wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::WebAssemblyModuleConstructor::createModule):

  • wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):
(JSC::WebAssemblyModuleRecord::evaluate):

Source/WTF:

Add new forms of dataLog that take a boolean which describes if the log should happen. This makes cases where we have a static const bool for printing nicer since you can do:

dataLogIf(verbose, things, to, print);

instead of:

if (verbose)

dataLog(things, to, print);

Also, add a operator! to Ref that has the same semantics as C++ refs.

  • wtf/DataLog.h:

(WTF::dataLogLn):
(WTF::dataLogIf):
(WTF::dataLogLnIf):

  • wtf/Ref.h:

(WTF::Ref::operator!):

2:19 PM Changeset in webkit [213385] by weinig@apple.com
  • 5 edits in trunk

REGRESSION (r209760): Apple Pay doesn't work on casper.com, shopspring.com, maybe other sites
<rdar://problem/30313445>
​https://bugs.webkit.org/show_bug.cgi?id=169149

Reviewed by Simon Fraser.

Source/WebCore:

Relax restriction that the ApplePayShippingMethod sequence must not be empty. This
was incorrect.

  • Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):

LayoutTests:

  • http/tests/ssl/applepay/ApplePaySession-expected.txt:
  • http/tests/ssl/applepay/ApplePaySession.html:

Update test for relaxed ApplePayShippingMethod sequence requirements.

1:50 PM Changeset in webkit [213384] by achristensen@apple.com
  • 8 edits in trunk

[URLParser] Fix file: as a relative file URL
​https://bugs.webkit.org/show_bug.cgi?id=169122

Reviewed by Tim Horton.

Source/WebCore:

This is clearly defined in ​https://url.spec.whatwg.org/#file-state with the EOF code point.
I got it wrong and didn't test it. It's been added to the web platform tests since we last updated.

  • platform/URLParser.cpp:

(WebCore::URLParser::parse):

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

LayoutTests:

We don't need to skip url-setters.html any more. It used to assert before the new URLParser was enabled.

  • fast/loader/url-parse-1-expected.txt:
  • fast/url/file-expected.txt:

We used to add a strange and unnecessary :/ at the end of the URL.

1:38 PM Changeset in webkit [213383] by aakash_jain@apple.com
  • 4 edits
    1 add in trunk/Source/WebKit2

Move declaration of _WKSetCrashReportApplicationSpecificInformation to header file
​https://bugs.webkit.org/show_bug.cgi?id=169043

Reviewed by Alex Christensen.

  • WebKit2.xcodeproj/project.pbxproj: Added WebProcessCocoa.h
  • WebProcess/cocoa/WebProcessCocoa.h: Added.
  • WebProcess/cocoa/WebProcessCocoa.mm: Imported WebProcessCocoa.h
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm: Ditto.
1:37 PM Changeset in webkit [213382] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Add Debug flag to TestExpectation for webrtc/audio-peer-connection-webaudio.html.

Unreviewed test gardening.

1:37 PM Changeset in webkit [213381] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: fix broken ARM64 build.
​https://bugs.webkit.org/show_bug.cgi?id=169139

Not reviewed.

  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::excepnGenerationImmMask):

1:29 PM Changeset in webkit [213380] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark performance-api/performance-observer-periodic.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=168136

Unreviewed test gardening.

  • platform/mac/TestExpectations:
1:16 PM Changeset in webkit [213379] by hyatt@apple.com
  • 38 edits
    22 adds
    2 deletes in trunk

Enable fieldsets to be flexboxes, grids and multicolumn.
​https://bugs.webkit.org/show_bug.cgi?id=169082

Reviewed by Simon Fraser.

Source/WebCore:

Added new tests in fast/forms/fieldset.

This patch eliminates RenderFieldset and moves the functionality into RenderBlock so that
derived classes can also be fieldsets.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:

Remove RenderFieldset from the project.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::titleUIElement):
Call in to RenderBlock now instead of RenderFieldset.

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::createElementRenderer):

  • html/HTMLFieldSetElement.h:

The fieldset DOM element now uses RenderElement::createFor to make renderers so that multiple display types
can be supported. A special flag has been added that indicates only to make flexbox and block-related
renderers (not table display types).

  • rendering/OrderIterator.cpp:

(WebCore::OrderIterator::shouldSkipChild):
(WebCore::OrderIteratorPopulator::collectChild):

  • rendering/OrderIterator.h:

Streamline child collection for flexboxes and grids to indicate whether the child should be skipped as a return
value from collectChild. Add a shouldSkipChild method that skips both out of flow positioned objects and
excluded children like the legends of fieldsets.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlockRareData::RenderBlockRareData):
When the legend is taller than the fieldset's borderBefore(), intrinsic border is added to the CSS border width.
This intrinsic border being factored in ensures that the padding and content boxes of fieldsets are correct
across any layout system, since the legend is now just treated as part of the border.

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
Call the new computePreferredWidthsForExcludedChildren to ensure that excluded children contribute to
preferred width in their own way and not as part of a specific layout system.

(WebCore::RenderBlock::renderName):
Hacked to still return RenderFieldSet for RenderBlockFlow-backed fieldsets for layout test compatibility.

(WebCore::RenderBlock::layoutExcludedChildren):
Renamed from layoutSpecialExcludedChild to more accurately reflect the fact that multiple excluded children
can be included here (e.g., both a multicolumn flow thread and a legend). The RenderBlock base class handles
the layout of legends by both placing them and setting the correct intrinsic border before amount on the
block.

(WebCore::RenderBlock::findFieldsetLegend):
Moved from RenderFieldset.

(WebCore::RenderBlock::adjustBorderBoxRectForPainting):
(WebCore::RenderBlock::paintRectToClipOutFromBorder):
These methods are used when painting to shrink the border box as needed to account for the legend and to
provide the portion of the border that needs to be clipped out. These methods have been enhanced to
properly support all writing modes.

(WebCore::RenderBlock::intrinsicBorderForFieldset):
(WebCore::RenderBlock::setIntrinsicBorderForFieldset):
(WebCore::RenderBlock::borderTop):
(WebCore::RenderBlock::borderLeft):
(WebCore::RenderBlock::borderBottom):
(WebCore::RenderBlock::borderRight):
(WebCore::RenderBlock::borderBefore):
These methods are overridden for border to ensure that the intrinsic border added by a tall legend is
properly factored in.

(WebCore::RenderBlock::computePreferredWidthsForExcludedChildren):

  • rendering/RenderBlock.h:

This method computes the preferred widths for legend children in order to ensure that the legend properly
grows the width of the fieldset when it is the widest item.

(WebCore::RenderBlock::adjustBorderBoxLogicalHeightForBoxSizing):
(WebCore::RenderBlock::adjustContentBoxLogicalHeightForBoxSizing):
Preserve the behavior of fieldsets in that the available content size includes the space lost accounting
for the legend. I don't think this makes much sense, but it matches the behavior of other browsers
(and our old behavior).

(WebCore::RenderBlock::paintExcludedChildrenInBorder):
Method for painting the excluded children that might be present in our border. We only do this if the
paint phase is a box decoration painting phase and if the legend isn't self-painting.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willCreateColumns):
Allow fieldsets to create columns now.

(WebCore::RenderBlockFlow::layoutBlockChildren):
(WebCore::RenderBlockFlow::layoutExcludedChildren):
Renamed this method and change it to call the base class to ensure that legends in multicolumn fieldsets
get handled properly.

(WebCore::RenderBlockFlow::addChild):
Patched to make sure legends don't get put into the multicolumn flow thread, as they need to
remain outside of it.

(WebCore::RenderBlockFlow::layoutSpecialExcludedChild): Deleted.
Renamed to layoutExcludedChildren.

  • rendering/RenderBlockFlow.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):
Patched to call the new adjustBorderBoxRectForPainting and paintRectToClipOutFromBorder methods in
order to properly shrink the border box rect for painting and to clip out the portion of the border
covered by the legend.

(WebCore::RenderBox::avoidsFloats):
Add fieldsets as avoiding floats. RenderFieldset used to subclass this method to return true, but with
its removal, we need to put this in the base class along with legends.

  • rendering/RenderBox.h:

(WebCore::RenderBox::isGridItem):
(WebCore::RenderBox::isFlexItem):
Patched to exclude legends so that they don't try to size like they are really in the grid or flexbox.

(WebCore::RenderBox::adjustBorderBoxRectForPainting):
This method is overridden by RenderBLock to handle adjusting fieldset border rects for painting.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::paintRectToClipOutFromBorder):
Patched to properly paint fieldsets using the new helpers.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
Make sure deprecated flexible boxes lay out their legends properly by calling layoutExcludedChildren.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

  • rendering/RenderElement.h:

Patched to take a flag that limits what renderers can be created so that fieldsets don't make table
display types.

  • rendering/RenderFieldset.cpp: Removed.
  • rendering/RenderFieldset.h: Removed.

Remove RenderFieldset files from the tree.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderFlexibleBox::firstLineBaseline):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::prepareOrderIteratorAndMargins):
Make sure flexible boxes lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the flexible box layout.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::layoutGridItems):
Make sure grids lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the grid's layout.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::populate):
Pull legends back up into the block and don't let them be part of the flow thread.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::requiresBalancing):
Fix an assert to allow legends to exist as siblings of multicolumn sets.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::isFieldset):
Changed to examine the HTML element rather than RenderFieldset.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isExcludedFromNormalLayout):
(WebCore::RenderObject::setIsExcludedFromNormalLayout):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
RenderObjects now have a new bit that is set for excluded objects like legends, flow threads,
placeholders, and ruby text. This bit lets code easily detect that an object is excluded from
the layout system and can be skipped.

(WebCore::RenderObject::isExcludedAndPlacedInBorder):
Helper method for asking if an object is painting inside the border. Used to know we
need to factor it into preferred width calculations outside of any one layout system
and also to know that we need to paint it when we paint the fieldset's border instead of
later (after we might have scrolled or clipped the child painting area).

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layoutExcludedChildren):
(WebCore::RenderRubyRun::layoutSpecialExcludedChild): Deleted.

  • rendering/RenderRubyRun.h:

Rename layoutSpecialExcludedChild to layoutExcludedChildren.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::adjustBorderBoxRectForPainting):
(WebCore::RenderTable::paintBoxDecorations):
(WebCore::RenderTable::paintMask):
(WebCore::RenderTable::subtractCaptionRect): Deleted.

  • rendering/RenderTable.h:

Patched tables to share the same border box rect adjustment used by fieldsets when subtracting
out captions. This is prep work to allow tables to be fieldsets, but for now I didn't go all the
way.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):
Make sure table cells adjust their border box rects for painting. Again this is prep work for
cells potentially being fieldsets, but not supported yet.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::layoutExcludedChildren):
(WebCore::RenderTextControl::layoutSpecialExcludedChild): Deleted.

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::layoutExcludedChildren):
(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild): Deleted.

  • rendering/RenderTextControlMultiLine.h:

Renamed the methods for doing the excluded child layout.

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
Make sure to dump the original fieldset border and not the border with the extra legend stuff in it.

LayoutTests:

  • fast/forms/fieldset/abs-pos-child-sizing-expected.html: Added.
  • fast/forms/fieldset/abs-pos-child-sizing.html: Added.
  • fast/forms/fieldset/fieldset-deprecated-flexbox-expected.html: Added.
  • fast/forms/fieldset/fieldset-deprecated-flexbox.html: Added.
  • fast/forms/fieldset/fieldset-flexbox-expected.html: Added.
  • fast/forms/fieldset/fieldset-flexbox.html: Added.
  • fast/forms/fieldset/fieldset-grid-expected.html: Added.
  • fast/forms/fieldset/fieldset-grid.html: Added.
  • fast/forms/fieldset/fieldset-multicolumn-expected.html: Added.
  • fast/forms/fieldset/fieldset-multicolumn.html: Added.
  • fast/forms/fieldset/fieldset-overflow-auto-expected.html: Added.
  • fast/forms/fieldset/fieldset-overflow-auto.html: Added.
  • fast/forms/fieldset/fieldset-overflow-hidden-expected.html: Added.
  • fast/forms/fieldset/fieldset-overflow-hidden.html: Added.
  • fast/forms/fieldset/fieldset-positioned-children-expected.html: Added.
  • fast/forms/fieldset/fieldset-positioned-children.html: Added.
  • fast/forms/fieldset/fieldset-positioned-legend-expected.html: Added.
  • fast/forms/fieldset/fieldset-positioned-legend.html: Added.
  • fast/forms/fieldset/fieldset-self-painting-legend-expected.html: Added.
  • fast/forms/fieldset/fieldset-self-painting-legend.html: Added.
  • fast/forms/fieldset/fieldset-writing-modes-expected.html: Added.
  • fast/forms/fieldset/fieldset-writing-modes.html: Added.
1:15 PM Changeset in webkit [213378] by Ryan Haddad
  • 15 edits
    3 deletes in trunk

Unreviewed, rolling out r213344.

This changed caused LayoutTest crashes under GuardMalloc.

Reverted changeset:

"Add support for canvas.toBlob"
​https://bugs.webkit.org/show_bug.cgi?id=148878
​http://trac.webkit.org/changeset/213344

1:14 PM Changeset in webkit [213377] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm as flaky on El Capitan Release builds.
​https://bugs.webkit.org/show_bug.cgi?id=164870

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:05 PM Changeset in webkit [213376] by mark.lam@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Add MacroAssembler::isBreakpoint() query function.
​https://bugs.webkit.org/show_bug.cgi?id=169139

Reviewed by Michael Saboff.

This will be needed soon when we use breakpoint instructions to implement
non-polling VM traps, and need to discern between a VM trap signal and a genuine
assertion breakpoint.

  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::isBrk):
(JSC::ARM64Assembler::excepnGenerationImmMask):

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::isBkpt):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::isBkpt):

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::isBkpt):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::isBreakpoint):

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::isBreakpoint):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::isBreakpoint):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::isBreakpoint):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::isBreakpoint):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::isInt3):

11:38 AM Changeset in webkit [213375] by Konstantin Tokarev
  • 2 edits in trunk/Source/WebCore

Unreviewed typo fix

  • features.json:
11:36 AM Changeset in webkit [213374] by matthew_hanson@apple.com
  • 9 edits
    2 adds in branches/safari-603.1.30.0-branch

Merge r213253. rdar://problem/30773140

10:59 AM Changeset in webkit [213373] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Build fix
rdar://problem/30825660

Suggested by Dan Bernstein.

  • Configurations/WebKitLegacy.xcconfig:
10:20 AM Changeset in webkit [213372] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[MediaStream] Remove #if USE(VIDEOTOOLBOX) from AVVideoCaptureSource
​https://bugs.webkit.org/show_bug.cgi?id=169131

Reviewed by Youenn Fablet.

  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::currentFrameCGImage):

10:12 AM Changeset in webkit [213371] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603.1.30.0-branch/Source

Versioning.

10:10 AM Changeset in webkit [213370] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603.1.30.1-branch/Source

Versioning.

9:51 AM Changeset in webkit [213369] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Add assertion in Frame::setView() to make sure associated document has no living render tree
​https://bugs.webkit.org/show_bug.cgi?id=169134

Reviewed by Brent Fulgham.

Add assertion in Frame::setView() to make sure associated document has no living render tree.
This is not supposed to happen and r213311 fixed one case where this could happen. We need
to find out if it can still happen.

  • page/Frame.cpp:

(WebCore::Frame::setView):

9:50 AM Changeset in webkit [213368] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603.1.30.4-branch/Source

Versioning.

9:48 AM Changeset in webkit [213367] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

We should only check for traps that we're able to handle.
​https://bugs.webkit.org/show_bug.cgi?id=169136

Reviewed by Michael Saboff.

The execute methods in interpreter were checking for the existence of any traps
(without masking) and only handling a subset of those via a mask. This can
result in a failed assertion on debug builds.

This patch fixes this by applying the same mask for both the needTrapHandling()
check and the handleTraps() call. Also added a few assertions.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::execute):

  • jit/JITOperations.cpp:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

9:24 AM Changeset in webkit [213366] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Ensure WebKitWebView always have a user content manager
​https://bugs.webkit.org/show_bug.cgi?id=169130

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2017-03-03
Reviewed by Michael Catanzaro.

User content manager is a construct only property, so if not set by the user the web view doesn't have any. We
can create a default one, like we do for settings, when user didn't provide one.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):

6:16 AM Changeset in webkit [213365] by jfernandez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
​https://bugs.webkit.org/show_bug.cgi?id=169127

Unreviewed GTK+ gardening. Removed duplicated TestExpectations entry.

  • platform/gtk/TestExpectations:
  • editing/selection/extend-by-character-007.html fails in GTK as well, so using the general TestExpectations entry.
5:07 AM Changeset in webkit [213364] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

LayoutTest media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=167275
<rdar://problem/30824290>

Patch by Antoine Quint <Antoine Quint> on 2017-03-03
Reviewed by Dean Jackson.

Ensure that we have metrics for buttons before attempting to click on them and let dragging interaction
apply changes to CSS on the next rAF before trying to pursue the next step.

  • media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt:
  • media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html:
  • platform/mac/TestExpectations:
5:02 AM Changeset in webkit [213363] by Manuel Rego Casasnovas
  • 3 edits in trunk/Websites/webkit.org

Unreviewed, minor updates on CSS Grid Layout examples.

  • demos/css-grid/index.html:
  • demos/css-grid/responsive-grid.html:
3:38 AM Changeset in webkit [213362] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTest performance-api/performance-observer-basic.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=169097

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-03
Reviewed by Ryosuke Niwa.

  • performance-api/performance-now-api.html:
  • performance-api/performance-observer-basic.html:

Reorder the scripts so that testWorker is guarenteed
to be defined before code that uses it.

2:06 AM Changeset in webkit [213361] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Another reftest failing with 2 pixels in image diff.

  • platform/gtk/TestExpectations:
1:58 AM Changeset in webkit [213360] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark RAF throttling tests as failing.

  • platform/gtk/TestExpectations:
1:52 AM Changeset in webkit [213359] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html after r213284.

  • platform/gtk/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes-expected.txt:
1:44 AM Changeset in webkit [213358] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Skip tests that require FILE_REPLACEMENT.

  • platform/gtk/TestExpectations:
12:32 AM Changeset in webkit [213357] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark several WebCryptoAPI tests as failing.

  • platform/gtk/TestExpectations:

Mar 2, 2017:

10:49 PM Changeset in webkit [213356] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Remote Inspector: Move updateTargetListing() methods to RemoteInspector.cpp
​https://bugs.webkit.org/show_bug.cgi?id=169074

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2017-03-02
Reviewed by Joseph Pecoraro.

They are not actually cocoa specific.

  • inspector/remote/RemoteInspector.cpp:

(Inspector::RemoteInspector::updateTargetListing):

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/cocoa/RemoteInspectorCocoa.mm:
10:35 PM Changeset in webkit [213355] by commit-queue@webkit.org
  • 81 edits
    2 moves in trunk/Source

Rename htmlediting.h/cpp to Editing.h/cpp
​https://bugs.webkit.org/show_bug.cgi?id=169103

Patch by Sam Weinig <​sam@webkit.org> on 2017-03-02
Reviewed by Alex Christensen.

Source/WebCore:

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:
  • accessibility/AccessibilityNodeObject.cpp:
  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/atk/WebKitAccessibleHyperlink.cpp:
  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:
  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
  • dom/Document.cpp:
  • dom/Element.cpp:
  • dom/Node.h:
  • dom/Position.cpp:
  • dom/PositionIterator.cpp:
  • dom/Range.cpp:
  • editing/AlternativeTextController.cpp:
  • editing/AppendNodeCommand.cpp:
  • editing/ApplyBlockElementCommand.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/BreakBlockquoteCommand.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::CreateLinkCommand):

  • editing/DeleteFromTextNodeCommand.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/EditCommand.cpp:
  • editing/Editing.cpp: Copied from Source/WebCore/editing/htmlediting.cpp.
  • editing/Editing.h: Copied from Source/WebCore/editing/htmlediting.h.
  • editing/EditingAllInOne.cpp:
  • editing/EditingStyle.cpp:
  • editing/Editor.cpp:
  • editing/EditorCommand.cpp:
  • editing/FormatBlockCommand.cpp:
  • editing/FrameSelection.cpp:
  • editing/HTMLInterchange.cpp:
  • editing/IndentOutdentCommand.cpp:
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertListCommand.cpp:
  • editing/InsertNodeBeforeCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/ModifySelectionListLevel.cpp:
  • editing/RemoveNodeCommand.cpp:
  • editing/ReplaceNodeWithSpanCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/SpellChecker.cpp:
  • editing/TextIterator.cpp:
  • editing/TypingCommand.cpp:
  • editing/VisiblePosition.cpp:
  • editing/VisibleSelection.cpp:
  • editing/VisibleUnits.cpp:
  • editing/cocoa/DataDetection.mm:
  • editing/cocoa/EditorCocoa.mm:
  • editing/htmlediting.cpp: Removed.
  • editing/htmlediting.h: Removed.
  • editing/ios/EditorIOS.mm:
  • editing/mac/DictionaryLookup.mm:
  • editing/mac/EditorMac.mm:
  • editing/markup.cpp:
  • html/HTMLTextFormControlElement.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • page/DOMSelection.cpp:
  • page/DragController.cpp:
  • page/EventHandler.cpp:
  • page/FocusController.cpp:
  • page/Frame.cpp:
  • platform/ios/PasteboardIOS.mm:
  • platform/mac/PasteboardMac.mm:
  • rendering/RenderBox.cpp:
  • rendering/RenderObject.cpp:

Source/WebKit/ios:

  • WebCoreSupport/WebFrameIOS.mm:
  • WebCoreSupport/WebVisiblePosition.mm:

Source/WebKit/mac:

  • DOM/DOMUIKitExtensions.mm:
  • WebView/WebFrame.mm:
  • WebView/WebView.mm:

Source/WebKit/win:

  • AccessibleTextImpl.cpp:

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/ios/WebPageIOS.mm:
  • WebProcess/WebPage/mac/WebPageMac.mm:
10:10 PM Changeset in webkit [213354] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Mac] Set the NSURLSessionTask priority to match the request's priority
​https://bugs.webkit.org/show_bug.cgi?id=169115
<rdar://problem/28881392>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-02
Reviewed by Alex Christensen.

  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::toNSURLSessionTaskPriority):
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
Set the priority on the task based on the ResourceRequest's priority.
This is used for HTTP/2 request prioritization.

9:53 PM Changeset in webkit [213353] by Matt Baker
  • 5 edits
    4 adds in trunk

Web Inspector: Should be able to push nodes in an iframe subtree to the frontend
​https://bugs.webkit.org/show_bug.cgi?id=169086

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: inspector/dom/push-node-by-path-to-frontend.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::nodeForPath):
During top-down document traversal, descend into content document nodes
when visiting an HTMLFrameOwnerElement.

Source/WebInspectorUI:

  • UserInterface/Views/DOMTreeContentView.js:

(WebInspector.DOMTreeContentView.prototype._selectedNodeDidChange):
Use the URL of the main frame instead of the content frame URL.

LayoutTests:

Added test coverage for DOMTreeManager.prototype.pushNodeByPathToFrontend,
which now supports pushing iframe document nodes (#document) and their descendants.

  • inspector/dom/push-node-by-path-to-frontend-expected.txt: Added.
  • inspector/dom/push-node-by-path-to-frontend.html: Added.
  • inspector/dom/resources/frameset-frame.html: Added.
  • inspector/dom/resources/frameset-iframe.html: Added.
9:40 PM Changeset in webkit [213352] by jmarcell@apple.com
  • 6 edits in trunk/Source

Versioning.

9:33 PM Changeset in webkit [213351] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=169109
<rdar://problem/30824252>

Patch by Antoine Quint <Antoine Quint> on 2017-03-02
Reviewed by Simon Fraser.

Ensure the tracks button is sized before pressing it to make the track panel appear.

  • media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt:
  • media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:
9:22 PM Changeset in webkit [213350] by Ryan Haddad
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r213274.

This change caused flakiness with LayoutTest memory/memory-
pressure-simulation.html

Reverted changeset:

"Don't keep dead resources in MemoryCache while under memory
pressure."
​https://bugs.webkit.org/show_bug.cgi?id=169070
​http://trac.webkit.org/changeset/213274

9:21 PM Changeset in webkit [213349] by graouts@webkit.org
  • 2 edits in trunk/LayoutTests

Remove references to tests that no longer exist and remove a duplicate test.

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
8:47 PM Changeset in webkit [213348] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[ios-simulator Debug WK2] LayoutTest media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=168668
<rdar://problem/30823677>

Patch by Antoine Quint <Antoine Quint> on 2017-03-02
Reviewed by Simon Fraser.

This test would sometime fail for the first assertion because we may need more than just metadata
to determine that we can be in a state where the fullscreen button becomes enabled (see the logic
in FullscreenSupport). So we now use an asynchronous assertion to determine we've enabled the
fullscreen button and then force it to error to disable it.

  • media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt:
  • media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html:
  • platform/ios-simulator/TestExpectations:
8:31 PM Changeset in webkit [213347] by Lucas Forschler
  • 1 copy in tags/Safari-604.1.8.0.1

Tag Safari-604.1.8.0.1

8:27 PM Changeset in webkit [213346] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[iOS Release WK2] LayoutTest media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=168343
<rdar://problem/30823389>

Patch by Antoine Quint <Antoine Quint> on 2017-03-02
Reviewed by Simon Fraser.

Use an asynchronous assertion to ensure we have valid metrics before pressing the skip back button.

  • media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
  • platform/ios-simulator/TestExpectations:
8:24 PM Changeset in webkit [213345] by jiewen_tan@apple.com
  • 26 edits
    2 copies
    64 adds in trunk

WebCrypto API support for AES-GCM
​https://bugs.webkit.org/show_bug.cgi?id=157175
<rdar://problem/27311691>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

  • web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_gcm.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_gcm-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/failures_AES-GCM.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/successes_AES-GCM.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-GCM-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-GCM-expected.txt:
  • web-platform-tests/WebCryptoAPI/import_export/symmetric_importKey.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/import_export/test_symmetric_importKey-expected.txt:

Source/WebCore:

This patch adds support for AES-GCM. Operations of AES-GCM include: encrypt, decrypt, generateKey,
importKey, exportKey, wrapKey, and unwrapKey. ​https://www.w3.org/TR/WebCryptoAPI/#aes-gcm

Tests: crypto/subtle/aes-gcm-decrypt-malformed-parameters.html

crypto/subtle/aes-gcm-encrypt-malformed-parameters.html
crypto/subtle/aes-gcm-generate-export-key-jwk-length-128.html
crypto/subtle/aes-gcm-generate-export-key-jwk-length-192.html
crypto/subtle/aes-gcm-generate-export-key-jwk-length-256.html
crypto/subtle/aes-gcm-generate-export-raw-key.html
crypto/subtle/aes-gcm-generate-key-encrypt-decrypt.html
crypto/subtle/aes-gcm-generate-key.html
crypto/subtle/aes-gcm-import-jwk-key-length-128.html
crypto/subtle/aes-gcm-import-jwk-key-length-192.html
crypto/subtle/aes-gcm-import-jwk-key-length-256.html
crypto/subtle/aes-gcm-import-key-decrypt-additional-data-tag-length-32.html
crypto/subtle/aes-gcm-import-key-decrypt-additional-data.html
crypto/subtle/aes-gcm-import-key-decrypt-tagLengths.html
crypto/subtle/aes-gcm-import-key-decrypt.html
crypto/subtle/aes-gcm-import-key-encrypt-additional-data-tag-length-32.html
crypto/subtle/aes-gcm-import-key-encrypt-additional-data.html
crypto/subtle/aes-gcm-import-key-encrypt-tagLengths.html
crypto/subtle/aes-gcm-import-key-encrypt.html
crypto/subtle/aes-gcm-import-key-unwrap-jwk-key.html
crypto/subtle/aes-gcm-import-key-unwrap-raw-key.html
crypto/subtle/aes-gcm-import-key-wrap-jwk-key.html
crypto/subtle/aes-gcm-import-key-wrap-raw-key.html
crypto/subtle/aes-gcm-import-raw-key.html
crypto/workers/subtle/aes-gcm-import-key-decrypt.html
crypto/workers/subtle/aes-gcm-import-key-encrypt.html
crypto/workers/subtle/aes-gcm-import-key-unwrap-key.html
crypto/workers/subtle/aes-gcm-import-key-wrap-key.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:

Add CryptoAlgorithmAES_CFBMac.cpp as well.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
Add support for AES-GCM.

  • crypto/CommonCryptoUtilities.h:

Include SPI header for AES-GCM support. We have a mismatch SPI between different OS version.
Therefore, a guardian is placed.

  • crypto/CryptoAlgorithmParameters.h:
  • crypto/algorithms/CryptoAlgorithmAES_GCM.cpp: Added.

(WebCore::usagesAreInvalidForCryptoAlgorithmAES_GCM):
(WebCore::tagLengthIsValid):
(WebCore::CryptoAlgorithmAES_GCM::create):
(WebCore::CryptoAlgorithmAES_GCM::identifier):
(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):
(WebCore::CryptoAlgorithmAES_GCM::generateKey):
(WebCore::CryptoAlgorithmAES_GCM::importKey):
(WebCore::CryptoAlgorithmAES_GCM::exportKey):

  • crypto/algorithms/CryptoAlgorithmAES_GCM.h: Added.
  • crypto/gnutls/CryptoAlgorithmAES_GCMGnuTLS.cpp: Added.

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_GCMMac.cpp: Added.

(WebCore::encryptAES_GCM):
(WebCore::decyptAES_GCM):
(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

  • crypto/parameters/AesGcmParams.idl: Added.
  • crypto/parameters/CryptoAlgorithmAesGcmParams.h: Added.

LayoutTests:

This patch also adds some tests for AES-CFB.

  • crypto/subtle/aes-export-key-malformed-parameters-expected.txt:
  • crypto/subtle/aes-export-key-malformed-parameters.html:
  • crypto/subtle/aes-gcm-decrypt-malformed-parameters-expected.txt: Added.
  • crypto/subtle/aes-gcm-decrypt-malformed-parameters.html: Added.
  • crypto/subtle/aes-gcm-encrypt-malformed-parameters-expected.txt: Added.
  • crypto/subtle/aes-gcm-encrypt-malformed-parameters.html: Added.
  • crypto/subtle/aes-gcm-generate-export-key-jwk-length-128-expected.txt: Added.
  • crypto/subtle/aes-gcm-generate-export-key-jwk-length-128.html: Added.
  • crypto/subtle/aes-gcm-generate-export-key-jwk-length-192-expected.txt: Added.
  • crypto/subtle/aes-gcm-generate-export-key-jwk-length-192.html: Added.
  • crypto/subtle/aes-gcm-generate-export-key-jwk-length-256-expected.txt: Added.
  • crypto/subtle/aes-gcm-generate-export-key-jwk-length-256.html: Added.
  • crypto/subtle/aes-gcm-generate-export-raw-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-generate-export-raw-key.html: Added.
  • crypto/subtle/aes-gcm-generate-key-encrypt-decrypt-expected.txt: Added.
  • crypto/subtle/aes-gcm-generate-key-encrypt-decrypt.html: Added.
  • crypto/subtle/aes-gcm-generate-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-generate-key.html: Added.
  • crypto/subtle/aes-gcm-import-jwk-key-length-128-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-jwk-key-length-128.html: Added.
  • crypto/subtle/aes-gcm-import-jwk-key-length-192-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-jwk-key-length-192.html: Added.
  • crypto/subtle/aes-gcm-import-jwk-key-length-256-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-jwk-key-length-256.html: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-additional-data-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-additional-data-tag-length-32-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-additional-data-tag-length-32.html: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-additional-data.html: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-tagLengths-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-tagLengths.html: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt.html: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-additional-data-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-additional-data-tag-length-32-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-additional-data-tag-length-32.html: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-additional-data.html: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-tagLengths-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-tagLengths.html: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt.html: Added.
  • crypto/subtle/aes-gcm-import-key-unwrap-jwk-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-unwrap-jwk-key.html: Added.
  • crypto/subtle/aes-gcm-import-key-unwrap-raw-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-unwrap-raw-key.html: Added.
  • crypto/subtle/aes-gcm-import-key-wrap-jwk-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-wrap-jwk-key.html: Added.
  • crypto/subtle/aes-gcm-import-key-wrap-raw-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-wrap-raw-key.html: Added.
  • crypto/subtle/aes-gcm-import-raw-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-raw-key.html: Added.
  • crypto/subtle/aes-generate-key-malformed-parameters-expected.txt:
  • crypto/subtle/aes-generate-key-malformed-parameters.html:
  • crypto/subtle/aes-import-key-malformed-parameters-expected.txt:
  • crypto/subtle/aes-import-key-malformed-parameters.html:
  • crypto/workers/subtle/aes-gcm-import-key-decrypt-expected.txt: Added.
  • crypto/workers/subtle/aes-gcm-import-key-decrypt.html: Added.
  • crypto/workers/subtle/aes-gcm-import-key-encrypt-expected.txt: Added.
  • crypto/workers/subtle/aes-gcm-import-key-encrypt.html: Added.
  • crypto/workers/subtle/aes-gcm-import-key-unwrap-key-expected.txt: Added.
  • crypto/workers/subtle/aes-gcm-import-key-unwrap-key.html: Added.
  • crypto/workers/subtle/aes-gcm-import-key-wrap-key-expected.txt: Added.
  • crypto/workers/subtle/aes-gcm-import-key-wrap-key.html: Added.
  • crypto/workers/subtle/resources/aes-gcm-import-key-decrypt.js: Added.
  • crypto/workers/subtle/resources/aes-gcm-import-key-encrypt.js: Added.
  • crypto/workers/subtle/resources/aes-gcm-import-key-unwrap-key.js: Added.
  • crypto/workers/subtle/resources/aes-gcm-import-key-wrap-key.js: Added.
8:12 PM Changeset in webkit [213344] by aestes@apple.com
  • 15 edits
    3 adds in trunk

Add support for canvas.toBlob
​https://bugs.webkit.org/show_bug.cgi?id=148878
<rdar://problem/22590406>

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png-expected.txt:

Source/WebCore:

These tests now pass:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/BlobCallback.cpp: Added.

(WebCore::BlobCallback::scheduleCallback):

  • fileapi/BlobCallback.h: Added.

(WebCore::BlobCallback::~BlobCallback):

  • fileapi/BlobCallback.idl: Added.
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toBlob):

  • html/HTMLCanvasElement.h:
  • html/HTMLCanvasElement.idl:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::writeFunction):
(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::data):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):
(WebCore::ImageBuffer::toCGImage):
(WebCore::cgImage):
(WebCore::dataURL):

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):

  • platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::ImageBuffer::toData):

7:59 PM Changeset in webkit [213343] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Unreviewed, rolling out r213332.

These tests are failing on ios-simulator debug.

Reverted changeset:

"[iOS] Enable webrtc tests for debug builds"
​https://bugs.webkit.org/show_bug.cgi?id=169108
​http://trac.webkit.org/changeset/213332

7:28 PM Changeset in webkit [213342] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=167396

Patch by Antoine Quint <Antoine Quint> on 2017-03-02
Reviewed by Simon Fraser.

Since timing is hard to test accurately, simplify the test to only check that we're transitioning
from one state to another and use the asynchronous, polling-based assertions to check that we will
be transitioning between those two states (visible and faded).

  • media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html:
  • platform/mac/TestExpectations:
7:17 PM Changeset in webkit [213341] by mmaxfield@apple.com
  • 9 edits in trunk

Migrate font-stretch to use fixed-point values
​https://bugs.webkit.org/show_bug.cgi?id=169107

Reviewed by Dean Jackson.

Source/WebCore:

There are a few benefits of using fixed-point values:

  • Not all of the entropy of a float is necessary for font selection. In particular, values are

expected to stay between around -1000 to 1000, and only need to have a few fractional bits.
Therefore, the values can be represented by 16-bit fixed point numbers, which includes one sign
bit and two fractional bits. This is smaller than the 32-bit floating point numbers we were
using, which means FontDescription can be slimmed down. This becomes even more important when
the rest of the variation font properties are implemented, since those will use these fixed-
point values too.

  • Fixed point values have a larger distance between adjacent representable values, which means

there are more collisions, which means our cache hit rates are higher.

No new tests because there is no behavior change.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::fontStretchFromStyle):

  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertFontStretch):

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::FontDescriptionKey):

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::stretch):
(WebCore::FontDescription::setStretch):
(WebCore::FontCascadeDescription::initialStretch):

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::defaultFontSelectionValues):
(WebCore::preparePlatformFont):
(WebCore::FontDatabase::InstalledFont::InstalledFont):
(WebCore::FontDatabase::InstalledFontFamily::expand):
(WebCore::FontDatabase::capabilitiesForFontDescriptor):
(WebCore::FontDatabase::stretchThreshold):
(WebCore::FontDatabase::italicThreshold):
(WebCore::FontDatabase::weightThreshold):
(WebCore::findClosestStretch):
(WebCore::filterStretch):
(WebCore::findClosestStyle):
(WebCore::filterStyle):
(WebCore::findClosestWeight):
(WebCore::filterWeight):
(WebCore::computeTargetWeight):
(WebCore::findClosestFont):
(WebCore::platformFontLookupWithFamily):
(WebCore::fontWithFamily):
(WebCore::defaultVariationValues): Deleted.
(WebCore::FontDatabase::Range::Range): Deleted.
(WebCore::FontDatabase::Range::isValid): Deleted.
(WebCore::FontDatabase::Range::expand): Deleted.
(WebCore::FontDatabase::Range::includes): Deleted.
(): Deleted.

  • platform/text/TextFlags.h:

(WebCore::FontSelectionValue::FontSelectionValue):
(WebCore::FontSelectionValue::operator float):
(WebCore::FontSelectionValue::operator+):
(WebCore::FontSelectionValue::operator-):
(WebCore::FontSelectionValue::operator*):
(WebCore::FontSelectionValue::operator/):
(WebCore::FontSelectionValue::operator==):
(WebCore::FontSelectionValue::operator!=):
(WebCore::FontSelectionValue::operator<):
(WebCore::FontSelectionValue::operator<=):
(WebCore::FontSelectionValue::operator>):
(WebCore::FontSelectionValue::operator>=):
(WebCore::FontSelectionValue::rawValue):
(WebCore::FontSelectionRange::isValid):
(WebCore::FontSelectionRange::expand):
(WebCore::FontSelectionRange::includes):
(WebCore::FontSelectionCapabilities::expand):

Tools:

Update to new types.

  • TestWebKitAPI/Tests/WebCore/FontCache.cpp:

(TestWebKitAPI::createPlatformFont):

6:45 PM Changeset in webkit [213340] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=167348
<rdar://problem/30822186>

Patch by Antoine Quint <Antoine Quint> on 2017-03-02
Reviewed by Tim Horton.

Since timing is hard to test accurately, simplify the test to only check that we're transitioning
from one state to another and use the asynchronous, polling-based assertions to check that we will
be transitioning between those two states (visible and faded).

  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html:
  • platform/mac/TestExpectations:
6:45 PM Changeset in webkit [213339] by Megan Gardner
  • 2 edits in trunk/Source/WebKit/mac

Fix 32-bit
​https://bugs.webkit.org/show_bug.cgi?id=169114

Reviewed by Alex Christensen.

  • WebView/WebView.mm:
6:42 PM Changeset in webkit [213338] by mark.lam@apple.com
  • 10 edits
    3 adds in trunk/Source

Add WebKit2 hooks to notify the VM that the user has requested a debugger break.
​https://bugs.webkit.org/show_bug.cgi?id=169089

Reviewed by Tim Horton and Joseph Pecoraro.

Source/JavaScriptCore:

  • runtime/VM.cpp:

(JSC::VM::handleTraps):

  • runtime/VM.h:

(JSC::VM::notifyNeedDebuggerBreak):

Source/WebKit2:

  • CMakeLists.txt:
  • DerivedSources.make:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::connect):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp: Added.

(WebKit::WebInspectorInterruptDispatcher::create):
(WebKit::WebInspectorInterruptDispatcher::WebInspectorInterruptDispatcher):
(WebKit::WebInspectorInterruptDispatcher::~WebInspectorInterruptDispatcher):
(WebKit::WebInspectorInterruptDispatcher::initializeConnection):
(WebKit::WebInspectorInterruptDispatcher::notifyNeedDebuggerBreak):

  • WebProcess/WebPage/WebInspectorInterruptDispatcher.h: Added.
  • WebProcess/WebPage/WebInspectorInterruptDispatcher.messages.in: Added.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):

  • WebProcess/WebProcess.h:
6:05 PM Changeset in webkit [213337] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=167263
<rdar://problem/30821398>

Patch by Antoine Quint <Antoine Quint> on 2017-03-02
Reviewed by Myles C. Maxfield.

Since timing is hard to test accurately, simplify the test to only check that we're transitioning
from one state to another and use the asynchronous, polling-based assertions to check that we will
be transitioning between those two states (visible and faded).

  • media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide.html:
  • platform/mac/TestExpectations:
5:55 PM Changeset in webkit [213336] by Megan Gardner
  • 3 edits in trunk/Source/WebKit

More guard fixing
​https://bugs.webkit.org/show_bug.cgi?id=169112

Reviewed by Alex Christensen.

Fixed an internal build.

  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:
5:53 PM Changeset in webkit [213335] by clopez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Update expectation for WebRTC tests.

Unreviewed test gardening.

  • platform/gtk/TestExpectations:
5:44 PM Changeset in webkit [213334] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Fixing typo in LayoutTests/webrtc/audio-peer-connection-webaudio.html
​https://bugs.webkit.org/show_bug.cgi?id=169111

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-02

  • webrtc/audio-peer-connection-webaudio.html:
5:37 PM Changeset in webkit [213333] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-603.1.30.1.31

Tag Safari-603.1.30.1.31.

5:34 PM Changeset in webkit [213332] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[iOS] Enable webrtc tests for debug builds
​https://bugs.webkit.org/show_bug.cgi?id=169108

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-02

  • platform/ios-simulator-wk2/TestExpectations:
5:34 PM Changeset in webkit [213331] by beidson@apple.com
  • 6 edits in trunk

Update WKWebsiteDatastoreConfiguration SPI.
​https://bugs.webkit.org/show_bug.cgi?id=169102

Reviewed by Tim Horton.
Source/WebKit2:

Make these strings URLs, and throw exceptions if you try to use non-file URLs.

  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _initWithConfiguration:]):

  • UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
  • UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:

(checkURLArgument):
(-[_WKWebsiteDataStoreConfiguration _webStorageDirectory]):
(-[_WKWebsiteDataStoreConfiguration _setWebStorageDirectory:]):
(-[_WKWebsiteDataStoreConfiguration _indexedDBDatabaseDirectory]):
(-[_WKWebsiteDataStoreConfiguration _setIndexedDBDatabaseDirectory:]):
(-[_WKWebsiteDataStoreConfiguration _webSQLDatabaseDirectory]):
(-[_WKWebsiteDataStoreConfiguration _setWebSQLDatabaseDirectory:]):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:

(-[WebsiteDataStoreCustomPathsMessageHandler userContentController:didReceiveScriptMessage:]):
(TEST):

5:29 PM Changeset in webkit [213330] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Move part of NetworkRTCProvider::close implementation in NetworkRTCProvider destructor
​https://bugs.webkit.org/show_bug.cgi?id=169104

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-02
Reviewed by Alex Christensen.

Improving NetworkRTCProvider clean-up by moving some member field cleaning to the destructor.
The remaining cleaning is still kept in NetworkRTCProvider::close as we need to go to the rtc network thread and
for that, we take a ref of NetworkRTCProvider.
Stopping any resolver before freeing them.

  • NetworkProcess/webrtc/NetworkRTCMonitor.h:
  • NetworkProcess/webrtc/NetworkRTCProvider.cpp:

(WebKit::NetworkRTCProvider::~NetworkRTCProvider):
(WebKit::NetworkRTCProvider::close):

  • NetworkProcess/webrtc/NetworkRTCProvider.h:
5:10 PM Changeset in webkit [213329] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-603.1.30.0.32

Tag Safari-603.1.30.0.32.

5:08 PM Changeset in webkit [213328] by jmarcell@apple.com
  • 4 edits in tags/Safari-604.1.8

Merge r213324. rdar://problem/30812277

5:07 PM Changeset in webkit [213327] by jmarcell@apple.com
  • 9 edits in tags/Safari-604.1.8

Merge r213305. rdar://problem/30796872

5:07 PM Changeset in webkit [213326] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Actualy update fast/css/flex-calculated-value.html.

Unreviewed test gardening.

  • fast/css/flex-calculated-value-expected.txt:
  • fast/css/flex-calculated-value.html:
5:02 PM Changeset in webkit [213325] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS] Replicate NetworkProcess Mac sandboxing in iOS to allow TCP/UDP
​https://bugs.webkit.org/show_bug.cgi?id=169105

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-02
Reviewed by Alex Christensen.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: Adding sandbox extension support for TCP/UDP networking.
4:28 PM Changeset in webkit [213324] by jer.noble@apple.com
  • 4 edits in trunk

Sufficently large timeValue and timeScale arguments to MediaTime will cause wrapping in toTimeScale().
​https://bugs.webkit.org/show_bug.cgi?id=169098

Reviewed by Keith Miller.

Source/WTF:

Use a non-standard but Clang & GCC supported int128_t type extension to do the 128-bit math rather than
rolling our own. Since this is only available in 64-bit builds, for 32-bit, just fix the underlying 128-bit
math.

  • wtf/MediaTime.cpp:

(WTF::MediaTime::setTimeScale):

Tools:

  • TestWebKitAPI/Tests/WTF/MediaTime.cpp:

(TestWebKitAPI::TEST):

4:24 PM Changeset in webkit [213323] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add JSC identity when code signing to allow debugging on iOS
​https://bugs.webkit.org/show_bug.cgi?id=169099

Reviewed by Filip Pizlo.

  • Configurations/JSC.xcconfig:
  • Configurations/ToolExecutable.xcconfig:
4:18 PM Changeset in webkit [213322] by achristensen@apple.com
  • 6 edits in trunk/Source/WebCore

Modernize ContentExtensionParser
​https://bugs.webkit.org/show_bug.cgi?id=169106

Reviewed by Andy Estes.

We were returning std::error_code and passing the return value as a parameter reference.
because we wrote this code before we had WTF::Expected.

No change in behavior, verified by many API tests.

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):

  • contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::getDomainList):
(WebCore::ContentExtensions::loadTrigger):
(WebCore::ContentExtensions::loadAction):
(WebCore::ContentExtensions::loadRule):
(WebCore::ContentExtensions::loadEncodedRules):
(WebCore::ContentExtensions::parseRuleList):

  • contentextensions/ContentExtensionParser.h:
  • contentextensions/ContentExtensionRule.cpp:

(WebCore::ContentExtensions::ContentExtensionRule::ContentExtensionRule):

  • contentextensions/ContentExtensionRule.h:
4:10 PM Changeset in webkit [213321] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/Tools

Add ability to read bindings test results
​https://bugs.webkit.org/show_bug.cgi?id=169063

Patch by Srinivasan Vijayaraghavan <​svijayaraghavan@apple.com> on 2017-03-02
Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/net/bindingstestresults.py: Added.

(BindingsTestResults): Conforms to the AbstractTestResults interface.
(BindingsTestResults.init): Constructor.
(BindingsTestResults.results_from_string): Generates BindingsTestResults object from JSON string.
(BindingsTestResults.is_subset): Compare failing tests in two BindingsTestResults objects.
(BindingsTestResults.equals): Checks if two BindingsTestResults objects contain the same failing test names.
(BindingsTestResults.all_passed): Return True if all bindings tests passed.
(BindingsTestResults.failing_tests): Returns a list of failing tests.
(BindingsTestResults.did_exceed_test_failure_limit): Always returns False, exists to conform to the interface.

  • Scripts/webkitpy/common/net/bindingstestresults_unittest.py: Added.

(BindingsTestResultsTest): Class to test BindingsTestResults.
(BindingsTestResultsTest.test_results_from_string): Unit tests string -> BindingsTestResults conversion.
(BindingsTestResultsTest.test_results_from_string_success): Ditto, for success cases.

  • Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Added.

(BindingsTestResultsReader): Conforms to the AbstractTestResultsReader interface.
(BindingsTestResultsReader.results): Reads the results file and returns a BindingsTestResults object.

4:01 PM Changeset in webkit [213320] by Ryan Haddad
  • 26 edits
    66 deletes in trunk

Unreviewed, rolling out r213301.

This change broke internal builds.

Reverted changeset:

"WebCrypto API support for AES-GCM"
​https://bugs.webkit.org/show_bug.cgi?id=157175
​http://trac.webkit.org/changeset/213301

3:56 PM Changeset in webkit [213319] by aakash_jain@apple.com
  • 10 edits
    2 copies
    1 add
    1 delete in trunk

Move stringMatchesWildcardString from WebKit2 to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=169065

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Added StringUtilities.h and StringUtilities.mm
  • PlatformMac.cmake: Added StringUtilities.mm
  • platform/mac/StringUtilities.h: Added.
  • platform/mac/StringUtilities.mm: Added.

(WebCore::wildcardRegexPatternString): Added.
(WebCore::stringMatchesWildcardString): Added.

Source/WebKit2:

  • Platform/mac/StringUtilities.h: Moved stringMatchesWildcardString to WebCore.
  • WebKit2.xcodeproj/project.pbxproj: Make StringUtilities.h a project header.
  • Platform/mac/StringUtilities.mm:

(WebKit::wildcardRegexPatternString): Moved to WebCore.
(WebKit::stringMatchesWildcardString): Ditto.

  • WebProcess/Plugins/WebPluginInfoProvider.cpp: Using stringMatchesWildcardString from WebCore.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Moved StringUtilities.mm
  • TestWebKitAPI/Tests/WebCore/StringUtilities.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm.

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Removed.
3:55 PM Changeset in webkit [213318] by lforchler@apple.com
  • 1 copy in tags/Safari-604.1.8

Tag Safari-604.1.8.

3:53 PM Changeset in webkit [213317] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTest media/modern-media-controls/volume-support/volume-support-drag.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=164226
<rdar://problem/30811901>

Patch by Antoine Quint <Antoine Quint> on 2017-03-02
Reviewed by Dean Jackson.

Use asynchronous assertions to step through the test and make it more robust.

  • media/modern-media-controls/volume-support/volume-support-drag-expected.txt:
  • media/modern-media-controls/volume-support/volume-support-drag.html:
3:50 PM Changeset in webkit [213316] by mrajca@apple.com
  • 5 edits in trunk

Media: send "did interfere with playback" events when the user pauses an autoplaying element
​https://bugs.webkit.org/show_bug.cgi?id=169006

Reviewed by Alex Christensen.

Source/WebCore:

Added API tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::pauseInternal):

Tools:

  • TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(TEST): Added.

3:49 PM Changeset in webkit [213315] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Update fast/css/flex-calculated-value.html after r213305.
​https://bugs.webkit.org/show_bug.cgi?id=169100

Unreviewed test gardening.

  • fast/css/flex-calculated-value-expected.txt:
  • fast/css/flex-calculated-value.html:
3:49 PM Changeset in webkit [213314] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=168933

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
3:47 PM Changeset in webkit [213313] by keith_miller@apple.com
  • 3 edits
    1 add in trunk

WebAssemblyFunction should have Function.prototype as its prototype
​https://bugs.webkit.org/show_bug.cgi?id=169101

Reviewed by Filip Pizlo.

JSTests:

  • wasm/js-api/web-assembly-function.js: Added.

Source/JavaScriptCore:

Per ​https://github.com/WebAssembly/design/blob/master/JS.md#exported-function-exotic-objects our JSWebAssemblyFunction
objects should have Function.prototype as their prototype.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

3:43 PM Changeset in webkit [213312] by aakash_jain@apple.com
  • 2 edits in trunk/Source/WebKit2

IsSmartPtr<WKRetainPtr<T>>::value should not be exported
​https://bugs.webkit.org/show_bug.cgi?id=169047

Reviewed by Alexey Proskuryakov.

  • UIProcess/API/cpp/WKRetainPtr.h:
3:43 PM Changeset in webkit [213311] by Chris Dumez
  • 5 edits
    2 adds in trunk

We should prevent load of subframes inserted during FrameTree deconstruction
​https://bugs.webkit.org/show_bug.cgi?id=169095

Reviewed by Brent Fulgham.

Source/WebCore:

When deconstructing the FrameTree, we fire the unload event in each subframe.
Such unload event handler may insert a new frame, we would previously load
such new frame which was unsafe as we would end up with an attached subframe
on a detached tree. To address the issue, we prevent new subframes from loading
while deconstructing the FrameTree and firing the unload events. This new
behavior is consistent with Chrome and should therefore be safe from a
compatibility standpoint.

Test: fast/frames/insert-frame-unload-handler.html

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::disconnectSubframes):
Update SubframeLoadingDisabler call site now that the constructor takes in
a pointer instead of a reference.

  • html/HTMLFrameOwnerElement.h:

(WebCore::SubframeLoadingDisabler::SubframeLoadingDisabler):
(WebCore::SubframeLoadingDisabler::~SubframeLoadingDisabler):
Update SubframeLoadingDisabler constructor to take in a pointer instead
of a reference, for convenience.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::detachChildren):
Prevent loads in subframes while detaching the subframes. It would be unsafe
as we copy the list of frames before iterating to fire the unload events.
Therefore, newly inserted frames would not get unloaded.

LayoutTests:

Add layout test coverage. Our behavior on this test is consistent with Chrome.

  • fast/frames/insert-frame-unload-handler-expected.txt: Added.
  • fast/frames/insert-frame-unload-handler.html: Added.
3:39 PM Changeset in webkit [213310] by commit-queue@webkit.org
  • 6 edits in trunk

Activate some new webrtc tests
​https://bugs.webkit.org/show_bug.cgi?id=168850

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-02
Reviewed by Alex Christensen.

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h: Activating peer connection by default when libwebrtc is on.

This allows ensuring the network process will have its sandbox extension.

LayoutTests:

  • TestExpectations: Marking webrtc/audio-peer-connection-webaudio.html as failing.
  • webrtc/audio-peer-connection-webaudio.html: Making test nicer when failing.
  • webrtc/datachannel/basic-expected.txt: Updated test expectation.
2:50 PM Changeset in webkit [213309] by root
  • 1 delete in tags/test_tag

Remove Test Tag.

2:50 PM Changeset in webkit [213308] by Megan Gardner
  • 4 edits in trunk/Source/WebKit/mac

Data Interaction build fixes
​https://bugs.webkit.org/show_bug.cgi?id=169096

Reviewed by Tim Horton.

Guards weren't all correct, also missed a selector name change.

  • WebView/WebView.mm:

(-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:

(-[WebViewPrivate dealloc]):

2:47 PM Changeset in webkit [213307] by root
  • 1 copy in tags/test_tag

Test Tag.

2:46 PM Changeset in webkit [213306] by commit-queue@webkit.org
  • 6 edits
    2 copies in trunk/Tools

Refactor test results classes in webkitpy to enable faster EWS iteration
​https://bugs.webkit.org/show_bug.cgi?id=169053

Patch by Srinivasan Vijayaraghavan <​svijayaraghavan@apple.com> on 2017-03-02
Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/net/abstracttestresults.py:

(AbstractTestResults): Import json for parse_json_string().
(AbstractTestResults.parse_json_string): Abstracted out from JSCTestResults.results_from_string().

  • Scripts/webkitpy/common/net/abstracttestresults_unittest.py: Added.

(AbstractTestResultsTest): Class that tests AbstractTestResults.
(AbstractTestResultsTest.test_parse_json_string_invalid_inputs): Move unit tests from JSCTestResultsTest.
(AbstractTestResultsTest.test_parse_json_string_valid_input): Add a unit test for a success case.

  • Scripts/webkitpy/common/net/jsctestresults.py:

(JSCTestResults.results_from_string): Call parse_json_string because it was abstracted out.

  • Scripts/webkitpy/common/net/jsctestresults_unittest.py:

(JSCTestResultsTest.test_results_from_string): Remove JSON parsing unit tests, because they were moved.

  • Scripts/webkitpy/tool/bot/abstracttestresultsreader.py: Added.

(AbstractTestResultsReader): Generic TestResultsReader with functions common to jsc, bindings etc.
(AbstractTestResultsReader.init): Moved from JSCTestResultsReader.init().
(AbstractTestResultsReader._read_file_contents): Moved from JSCTestResultsReader._read_file_contents().
(AbstractTestResultsReader.results): Stub.

  • Scripts/webkitpy/tool/bot/jsctestresultsreader.py:

(JSCTestResultsReader): Now inherits from AbstractTestResultsReader.
(JSCTestResultsReader.init): Deleted.
(JSCTestResultsReader._read_file_contents): Deleted.

  • Scripts/webkitpy/tool/bot/layouttestresultsreader.py:

(LayoutTestResultsReader): Now inherits from AbstractTestResultsReader.

2:38 PM Changeset in webkit [213305] by hyatt@apple.com
  • 9 edits in trunk

flex-basis should be 0% (not 0px) when omitted
​https://bugs.webkit.org/show_bug.cgi?id=169100
rdar://problem/30429154

Reviewed by Dean Jackson.

Source/WebCore:

Covered by existing tests.

  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeFlex):

LayoutTests:

  • css3/flexbox/bug669714-expected.txt:
  • css3/flexbox/columns-auto-size-expected.txt:
  • css3/flexbox/flex-longhand-parsing-expected.txt:
  • css3/flexbox/flex-longhand-parsing.html:
  • css3/flexbox/flex-property-parsing-expected.txt:
  • css3/flexbox/flex-property-parsing.html:
2:30 PM Changeset in webkit [213304] by BJ Burg
  • 6 edits in trunk/Source/WebKit2

Web Automation: _WKAutomationSessionDelegate should work with WKWebViews
​https://bugs.webkit.org/show_bug.cgi?id=169091
<rdar://problem/30810538>

Reviewed by Tim Horton.

As a first step towards fixing the mistake of using WKPageRef in an Objective-C SPI,
add the correct delegate methods that take WKWebView so that Objective-C clients can
use this functionality.

In a future patch, we'll remove the WKPageRef delegate methods when they are no longer
being used by clients. Clients should switch to using WKWebView, or wait for a C SPI
with equivalent functionality (something like WKAutomationSessionClient) to be ported.

While I'm fixing this mess, make API::AutomationSessionClient use references instead
of pointers. We null-check all WebPageProxy parameters before calling its methods.

  • UIProcess/API/APIAutomationSessionClient.h:

(API::AutomationSessionClient::didDisconnectFromRemote):
(API::AutomationSessionClient::didRequestNewWindow):
(API::AutomationSessionClient::isShowingJavaScriptDialogOnPage):
(API::AutomationSessionClient::dismissCurrentJavaScriptDialogOnPage):
(API::AutomationSessionClient::acceptCurrentJavaScriptDialogOnPage):
(API::AutomationSessionClient::messageOfCurrentJavaScriptDialogOnPage):
(API::AutomationSessionClient::setUserInputForCurrentJavaScriptPromptOnPage):
Change pointer to reference.

  • UIProcess/API/Cocoa/_WKAutomationSessionDelegate.h:

Add duplicate delegate methods that take/return WKWebView instead of WKPageRef.
Adjust the delegate method names to reflect parameter type and avoid conflicts with the
WKPageRef-using methods that we need to remove eventually.

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::terminate):
(WebKit::WebAutomationSession::createBrowsingContext):
(WebKit::WebAutomationSession::isShowingJavaScriptDialog):
(WebKit::WebAutomationSession::dismissCurrentJavaScriptDialog):
(WebKit::WebAutomationSession::acceptCurrentJavaScriptDialog):
(WebKit::WebAutomationSession::messageOfCurrentJavaScriptDialog):
(WebKit::WebAutomationSession::setUserInputForCurrentJavaScriptPrompt):
Dereference this and webPageProxy when calling API::AutomationSessionClient methods.

  • UIProcess/Cocoa/AutomationSessionClient.h:
  • UIProcess/Cocoa/AutomationSessionClient.mm:

(WebKit::AutomationSessionClient::AutomationSessionClient):
(WebKit::AutomationSessionClient::didDisconnectFromRemote):
(WebKit::AutomationSessionClient::didRequestNewWindow):
(WebKit::AutomationSessionClient::isShowingJavaScriptDialogOnPage):
(WebKit::AutomationSessionClient::dismissCurrentJavaScriptDialogOnPage):
(WebKit::AutomationSessionClient::acceptCurrentJavaScriptDialogOnPage):
(WebKit::AutomationSessionClient::messageOfCurrentJavaScriptDialogOnPage):
(WebKit::AutomationSessionClient::setUserInputForCurrentJavaScriptPromptOnPage):
Now there are two possible delegate methods for most of these, so try to use the
WKWebView-based delegate method first and fall back to the WKPageRef delegate method.

2:09 PM Changeset in webkit [213303] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark inspector/model/color.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=153894

Unreviewed test gardening.

  • platform/mac/TestExpectations:
2:06 PM Changeset in webkit [213302] by mark.lam@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Add Options::alwaysCheckTraps() and Options::usePollingTraps() options.
​https://bugs.webkit.org/show_bug.cgi?id=169088

Reviewed by Keith Miller.

Options::alwaysCheckTraps() forces the op_check_traps bytecode to always be
generated. This is useful for testing purposes until we have signal based
traps, at which point, we will always emit the op_check_traps bytecode and remove
this option.

Options::usePollingTraps() enables the use of polling VM traps all the time.
This will be useful for benchmark comparisons, (between polling and non-polling
traps), as well as for forcing polling traps later for ports that don't support
signal based traps.

Note: signal based traps are not fully implemented yet. As a result, if the VM
watchdog is in use, we will force Options::usePollingTraps() to be true.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCheckTraps):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCheckTraps):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckTraps):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):

  • runtime/Options.h:
1:55 PM Changeset in webkit [213301] by jiewen_tan@apple.com
  • 26 edits
    2 copies
    64 adds in trunk

WebCrypto API support for AES-GCM
​https://bugs.webkit.org/show_bug.cgi?id=157175
<rdar://problem/27311691>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

  • web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_gcm.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_gcm-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/failures_AES-GCM.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/successes_AES-GCM.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-GCM-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-GCM-expected.txt:
  • web-platform-tests/WebCryptoAPI/import_export/symmetric_importKey.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/import_export/test_symmetric_importKey-expected.txt:

Source/WebCore:

This patch adds support for AES-GCM. Operations of AES-GCM include: encrypt, decrypt, generateKey,
importKey, exportKey, wrapKey, and unwrapKey. ​https://www.w3.org/TR/WebCryptoAPI/#aes-gcm

Tests: crypto/subtle/aes-gcm-decrypt-malformed-parameters.html

crypto/subtle/aes-gcm-encrypt-malformed-parameters.html
crypto/subtle/aes-gcm-generate-export-key-jwk-length-128.html
crypto/subtle/aes-gcm-generate-export-key-jwk-length-192.html
crypto/subtle/aes-gcm-generate-export-key-jwk-length-256.html
crypto/subtle/aes-gcm-generate-export-raw-key.html
crypto/subtle/aes-gcm-generate-key-encrypt-decrypt.html
crypto/subtle/aes-gcm-generate-key.html
crypto/subtle/aes-gcm-import-jwk-key-length-128.html
crypto/subtle/aes-gcm-import-jwk-key-length-192.html
crypto/subtle/aes-gcm-import-jwk-key-length-256.html
crypto/subtle/aes-gcm-import-key-decrypt-additional-data-tag-length-32.html
crypto/subtle/aes-gcm-import-key-decrypt-additional-data.html
crypto/subtle/aes-gcm-import-key-decrypt-tagLengths.html
crypto/subtle/aes-gcm-import-key-decrypt.html
crypto/subtle/aes-gcm-import-key-encrypt-additional-data-tag-length-32.html
crypto/subtle/aes-gcm-import-key-encrypt-additional-data.html
crypto/subtle/aes-gcm-import-key-encrypt-tagLengths.html
crypto/subtle/aes-gcm-import-key-encrypt.html
crypto/subtle/aes-gcm-import-key-unwrap-jwk-key.html
crypto/subtle/aes-gcm-import-key-unwrap-raw-key.html
crypto/subtle/aes-gcm-import-key-wrap-jwk-key.html
crypto/subtle/aes-gcm-import-key-wrap-raw-key.html
crypto/subtle/aes-gcm-import-raw-key.html
crypto/workers/subtle/aes-gcm-import-key-decrypt.html
crypto/workers/subtle/aes-gcm-import-key-encrypt.html
crypto/workers/subtle/aes-gcm-import-key-unwrap-key.html
crypto/workers/subtle/aes-gcm-import-key-wrap-key.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:

Add CryptoAlgorithmAES_CFBMac.cpp as well.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
Add support for AES-GCM.

  • crypto/CommonCryptoUtilities.h:

Include SPI header for AES-GCM support.

  • crypto/CryptoAlgorithmParameters.h:
  • crypto/algorithms/CryptoAlgorithmAES_GCM.cpp: Added.

(WebCore::usagesAreInvalidForCryptoAlgorithmAES_GCM):
(WebCore::tagLengthIsValid):
(WebCore::CryptoAlgorithmAES_GCM::create):
(WebCore::CryptoAlgorithmAES_GCM::identifier):
(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):
(WebCore::CryptoAlgorithmAES_GCM::generateKey):
(WebCore::CryptoAlgorithmAES_GCM::importKey):
(WebCore::CryptoAlgorithmAES_GCM::exportKey):

  • crypto/algorithms/CryptoAlgorithmAES_GCM.h: Added.
  • crypto/gnutls/CryptoAlgorithmAES_GCMGnuTLS.cpp: Added.

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_GCMMac.cpp: Added.

(WebCore::encryptAES_GCM):
(WebCore::decyptAES_GCM):
(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

  • crypto/parameters/AesGcmParams.idl: Added.
  • crypto/parameters/CryptoAlgorithmAesGcmParams.h: Added.

LayoutTests:

This patch also adds some tests for AES-CFB.

  • crypto/subtle/aes-export-key-malformed-parameters-expected.txt:
  • crypto/subtle/aes-export-key-malformed-parameters.html:
  • crypto/subtle/aes-gcm-decrypt-malformed-parameters-expected.txt: Added.
  • crypto/subtle/aes-gcm-decrypt-malformed-parameters.html: Added.
  • crypto/subtle/aes-gcm-encrypt-malformed-parameters-expected.txt: Added.
  • crypto/subtle/aes-gcm-encrypt-malformed-parameters.html: Added.
  • crypto/subtle/aes-gcm-generate-export-key-jwk-length-128-expected.txt: Added.
  • crypto/subtle/aes-gcm-generate-export-key-jwk-length-128.html: Added.
  • crypto/subtle/aes-gcm-generate-export-key-jwk-length-192-expected.txt: Added.
  • crypto/subtle/aes-gcm-generate-export-key-jwk-length-192.html: Added.
  • crypto/subtle/aes-gcm-generate-export-key-jwk-length-256-expected.txt: Added.
  • crypto/subtle/aes-gcm-generate-export-key-jwk-length-256.html: Added.
  • crypto/subtle/aes-gcm-generate-export-raw-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-generate-export-raw-key.html: Added.
  • crypto/subtle/aes-gcm-generate-key-encrypt-decrypt-expected.txt: Added.
  • crypto/subtle/aes-gcm-generate-key-encrypt-decrypt.html: Added.
  • crypto/subtle/aes-gcm-generate-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-generate-key.html: Added.
  • crypto/subtle/aes-gcm-import-jwk-key-length-128-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-jwk-key-length-128.html: Added.
  • crypto/subtle/aes-gcm-import-jwk-key-length-192-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-jwk-key-length-192.html: Added.
  • crypto/subtle/aes-gcm-import-jwk-key-length-256-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-jwk-key-length-256.html: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-additional-data-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-additional-data-tag-length-32-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-additional-data-tag-length-32.html: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-additional-data.html: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-tagLengths-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt-tagLengths.html: Added.
  • crypto/subtle/aes-gcm-import-key-decrypt.html: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-additional-data-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-additional-data-tag-length-32-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-additional-data-tag-length-32.html: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-additional-data.html: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-tagLengths-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt-tagLengths.html: Added.
  • crypto/subtle/aes-gcm-import-key-encrypt.html: Added.
  • crypto/subtle/aes-gcm-import-key-unwrap-jwk-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-unwrap-jwk-key.html: Added.
  • crypto/subtle/aes-gcm-import-key-unwrap-raw-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-unwrap-raw-key.html: Added.
  • crypto/subtle/aes-gcm-import-key-wrap-jwk-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-wrap-jwk-key.html: Added.
  • crypto/subtle/aes-gcm-import-key-wrap-raw-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-key-wrap-raw-key.html: Added.
  • crypto/subtle/aes-gcm-import-raw-key-expected.txt: Added.
  • crypto/subtle/aes-gcm-import-raw-key.html: Added.
  • crypto/subtle/aes-generate-key-malformed-parameters-expected.txt:
  • crypto/subtle/aes-generate-key-malformed-parameters.html:
  • crypto/subtle/aes-import-key-malformed-parameters-expected.txt:
  • crypto/subtle/aes-import-key-malformed-parameters.html:
  • crypto/workers/subtle/aes-gcm-import-key-decrypt-expected.txt: Added.
  • crypto/workers/subtle/aes-gcm-import-key-decrypt.html: Added.
  • crypto/workers/subtle/aes-gcm-import-key-encrypt-expected.txt: Added.
  • crypto/workers/subtle/aes-gcm-import-key-encrypt.html: Added.
  • crypto/workers/subtle/aes-gcm-import-key-unwrap-key-expected.txt: Added.
  • crypto/workers/subtle/aes-gcm-import-key-unwrap-key.html: Added.
  • crypto/workers/subtle/aes-gcm-import-key-wrap-key-expected.txt: Added.
  • crypto/workers/subtle/aes-gcm-import-key-wrap-key.html: Added.
  • crypto/workers/subtle/resources/aes-gcm-import-key-decrypt.js: Added.
  • crypto/workers/subtle/resources/aes-gcm-import-key-encrypt.js: Added.
  • crypto/workers/subtle/resources/aes-gcm-import-key-unwrap-key.js: Added.
  • crypto/workers/subtle/resources/aes-gcm-import-key-wrap-key.js: Added.
1:23 PM Changeset in webkit [213300] by rniwa@webkit.org
  • 13 edits
    7 adds
    1 delete in trunk/Websites/perf.webkit.org

Make baseline data points selectable
​https://bugs.webkit.org/show_bug.cgi?id=169069
<rdar://problem/29209427>

Reviewed by Antti Koivisto.

Add the capability to select data points other than "current" configuration type.

This patch refactors the way the "chart status" is computed. Before this patch, ChartStatusView was
responsible for determining two data points for which to compute the status, and computing the status
between two data points. ChartPaneStatusView which inherits from ChartStatusView and used in the charts
page relied upon ChartStatusView to compute these values, and computed the list of revision ranges for
each relevant repository between the data points. ChartPane then had callbacks on ChartPaneStatusView
to know whenever these values changed. Because of this entangled mess, ChartStatusView had to be aware
of InteractiveTimeSeriesChart even though only ChartPaneStatusView could be used with it.

This patch dramatically simplifies the situation by adding referencePoints() on TimeSeriesChart and
InteractiveTimeSeriesChart which returns the current point, the previous point if there is any, and
their time series view. It also extracts ChartStatusEvaluator which computes the current status values
and ChartRevisionRange which computes a list of revision differences both based on the referencePoints.
As a result, ChartPaneStatusView no longer inherits from ChartStatusView, and ChartStatusView has been
renamed to DashboardChartStatusView to reflect its purpose. Furthermore, ChartPane which used to rely on
ChartPaneStatusView's revisionCallback to update the commit log viewer simply uses another instance of
ChartRevisionRange, eliminating the need for the callback.

To implement these classes easily, this patch also introduces a new class, LazilyEvaluatedFunction to
memoize the return value of a function when called with the same arguments. Delaying the computation of
a value and avoiding the work when the values are the same is a very common pattern in the perf dashboard
so I expect this class would be used in a lot more places in the future.

  • browser-tests/chart-revision-range-tests.js: Added. Tests for ChartRevisionRange.
  • browser-tests/chart-status-evaluator-tests.js: Added. Tests for ChartStatusEvaluator.
  • browser-tests/index.html:

(BrowsingContext):
(BrowsingContext.importScripts): Fixed the bug that calling importScripts twice results in MockRemoteAPI
being loaded twice.
(ChartTest.importChartScripts): Import more model objects.
(ChartTest.sampleCluster): Made this a getter.
(ChartTest.makeModelObjectsForSampleCluster):
(ChartTest.makeSampleCluster): Added. Cutomizes the valus of baseline / target based on options.
(ChartTest.respondWithSampleCluster): Now takes an options argument for makeSampleCluster.

  • public/v3/components/chart-pane-base.js:

(ChartPaneBase): Added _openRepository to keep track of the currently open repository instead of relying
on _mainChartStatus or _commitLogViewer to keep track of it.
(ChartPaneBase.prototype.configure): The callback for when the user clicked on a repository name in
ChartPaneStatusView has been replaced by "openRepository" action.
(ChartPaneBase.prototype.setOpenRepository): Moved from ChartPane.
(ChartPaneBase.prototype._mainSelectionDidChange):
(ChartPaneBase.prototype._indicatorDidChange):
(ChartPaneBase.prototype._didFetchData):
(ChartPaneBase.prototype._updateCommitLogViewer): Renamed from _updateStatus.
(ChartPaneBase.prototype.openNewRepository): Renamed from _requestOpeningCommitViewer. Fixed a bug that
clicking on the repository name inside ChartPaneStatusView would not focus the pane, which resulted in
arrow keys to be ignored instead of moving the main chart's indicator or the currently open repository.
(ChartPaneBase.prototype._keyup):
(ChartPaneBase.prototype._moveOpenRepository): Moved from ChartPaneStatusView's
moveRepositoryWithNotification. Used when changing the open repository by up/down arrow keys.

  • public/v3/components/chart-revision-range.js: Added. Extracted from ChartPaneStatusView.

(ChartRevisionRange): Added.
(ChartRevisionRange.prototype.revisionList): Added.
(ChartRevisionRange.prototype.rangeForRepository): Added.
(ChartRevisionRange._revisionForPoint): Added. Extracted from ChartPaneStatusView's
_updateRevisionListForNewCurrentRepository.
(ChartRevisionRange._computeRevisionList): Ditto from computeChartStatusLabels.

  • public/v3/components/chart-status-evaluator.js: Added.

(ChartStatusEvaluator): Added.
(ChartStatusEvaluator.prototype.status): Added.
(ChartStatusEvaluator.computeChartStatus): Added. Extracted from ChartStatusView's updateStatusIfNeeded.

  • public/v3/components/chart-status-view.js: Removed.

(ChartStatusView): Deleted. Split into ChartStatusEvaluator and DashboardChartStatusView.

  • public/v3/components/chart-styles.js:

(ChartStyles.baselineStyle): Make baseline data points interactive. This single line change is what
enables the user to interact with the data points. The rest of changes in this patch mostly deals with
the status text such as "5% worse than baseline" and the list of revisions shown in the commit log viewer
which would have shown the wrong range without these changes.

  • public/v3/components/dashboard-chart-status-view.js: Added. Extracted from ChartStatusView.

(DashboardChartStatusView): Added.
(DashboardChartStatusView.prototype.render): Added.
(DashboardChartStatusView.htmlTemplate): Added.
(DashboardChartStatusView.cssTemplate): Added.

  • public/v3/components/interactive-time-series-chart.js:

(InteractiveTimeSeriesChart.prototype.referencePoints): Added. Return the first point and the last point
as the reference points when there is a selection. Only report the previous point if they are distinct as
showing a range of revisions from a data point to itself makes no sense. When there is a indicator simply
return it and its previous point as reference points. Otherwise return null unlike TimeSeriesChart's
referencePoints which always returns the latest point as the reference point.

  • public/v3/components/time-series-chart.js:

(TimeSeriesChart.prototype.referencePoints): Added. Return the latest point as the reference point. It
never returns the previous point even if there were more data points as there is no way for the user to
specify which data points to compare.

  • public/v3/index.html: Include newly added files.
  • public/v3/lazily-evaluated-function.js: Added.

(LazilyEvaluatedFunction): Added.
(LazilyEvaluatedFunction.prototype.evaluate): Added.

  • public/v3/models/commit-log.js:

(CommitLog.prototype.diff): Fixed a bug that computing the diff of two Subversion-like revisions results
in "from" field to be unexpectedly an integer instead of a string.

  • public/v3/models/metric.js:

(Metric): Moved the code to compute the unit from the metric name from v2's RunsData class. This makes
writing tests easier since it eliminates the need to load v2's data.js.
(Metric.prototype.unit):
(Metric.prototype.isSmallerBetter): Ditto for determining whether the unit is smaller-is-better.

  • public/v3/pages/analysis-task-page.js:

(AnalysisTaskChartPane.prototype._updateStatus): Deleted the unused code.

  • public/v3/pages/chart-pane-status-view.js:

(ChartPaneStatusView): No longer inherits from ChartStatusView. Uses ChartStatusEvaluator and
ChartRevisionRange to to compute the chart status and the list of revision changes.
(ChartPaneStatusView.prototype.pointsRangeForAnalysis): Deleted.
(ChartPaneStatusView.prototype.render): Split it into _renderStatus and _renderBuildRevisionTable using
LazilyEvaluatedFunction.
(ChartPaneStatusView.prototype._renderStatus): Added.
(ChartPaneStatusView.prototype._renderBuildRevisionTable): Added.
(ChartPaneStatusView.prototype.setCurrentRepository): _updateRevisionListForNewCurrentRepository has been
moved into ChartRevisionRange. Just enqueue itself to re-render.
(ChartPaneStatusView.prototype._setRevisionRange): Deleted.
(ChartPaneStatusView.prototype.moveRepositoryWithNotification): Deleted.
(ChartPaneStatusView.prototype.updateRevisionList): Deleted.
(ChartPaneStatusView.prototype._updateRevisionListForNewCurrentRepository): Deleted.
(ChartPaneStatusView.prototype.computeChartStatusLabels): Deleted.
(ChartPaneStatusView.htmlTemplate):
(ChartPaneStatusView.cssTemplate):

  • public/v3/pages/chart-pane.js:

(ChartPane.prototype.openNewRepository): Overrides the one in ChartPaneBase, which has been renamed from
_requestOpeningCommitViewer.
(ChartPane.prototype._analyzeRange):
(ChartPane.prototype._renderActionToolbar): Use the main chart's selection directly to determine whether
an analysis task can be created for the currenty selected range.

  • public/v3/pages/dashboard-page.js:

(DashboardPage.prototype._createChartForCell):

  • unit-tests/lazily-evaluated-function-tests.js: Added. Tests for LazilyEvaluatedFunction.
1:22 PM Changeset in webkit [213299] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix addressing mode for B3WasmAddress
​https://bugs.webkit.org/show_bug.cgi?id=169092

Reviewed by Filip Pizlo.

Fix the potential addressing modes for B3WasmAddress. ARM does not
support a base + index*1 + offset addressing mode. I think when I
read it the first time I assumed it would always work on both ARM
and X86. While true for X86 it's not true for ARM.

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::effectiveAddr):

12:52 PM Changeset in webkit [213298] by matthew_hanson@apple.com
  • 4 edits in branches/safari-603.1.30.1-branch/Source/WebCore

Roll out r212554 via r212893. rdar://problem/30812551

12:52 PM Changeset in webkit [213297] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603.1.30.1-branch/Source

Versioning.

12:49 PM Changeset in webkit [213296] by matthew_hanson@apple.com
  • 4 edits in branches/safari-603.1.30.0-branch/Source/WebCore

Roll out r212554 via r212886. rdar://problem/30812601

12:35 PM Changeset in webkit [213295] by mark.lam@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Add support for selective handling of VM traps.
​https://bugs.webkit.org/show_bug.cgi?id=169087

Reviewed by Keith Miller.

This is needed because there are some places in the VM where it's appropriate to
handle some types of VM traps but not others.

We implement this selection by using a VMTraps::Mask that allows the user to
specify which traps should be serviced.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::execute):

  • runtime/VM.cpp:

(JSC::VM::handleTraps):

  • runtime/VM.h:
  • runtime/VMTraps.cpp:

(JSC::VMTraps::takeTrap): Deleted.

  • runtime/VMTraps.h:

(JSC::VMTraps::Mask::Mask):
(JSC::VMTraps::Mask::allEventTypes):
(JSC::VMTraps::Mask::bits):
(JSC::VMTraps::Mask::init):
(JSC::VMTraps::needTrapHandling):
(JSC::VMTraps::hasTrapForEvent):

12:19 PM Changeset in webkit [213294] by achristensen@apple.com
  • 12 edits in trunk

Continue enabling WebRTC
​https://bugs.webkit.org/show_bug.cgi?id=169056

Reviewed by Jon Lee.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
11:30 AM Changeset in webkit [213293] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Mark inspector/debugger/breakpoint-action-eval.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=163604

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
11:16 AM Changeset in webkit [213292] by Megan Gardner
  • 9 edits in trunk/Source

Data interaction support for WK1
​https://bugs.webkit.org/show_bug.cgi?id=169062

Reviewed by Wenson Hsieh.

Source/WebKit/mac:

Support for data interaction in WebKit1

  • WebCoreSupport/WebDragClient.mm:
  • WebView/WebView.mm:

(-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
(-[WebUITextIndicatorData initWithImage:scale:]):
(-[WebUITextIndicatorData dealloc]):
(-[WebView _requestStartDataInteraction:globalPosition:]):
(-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
(-[WebView _getDataInteractionData]):

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:

(-[WebViewPrivate dealloc]):

  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:

Source/WebKit2:

Allow for separate additions files in WK1 and WK2

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
10:42 AM Changeset in webkit [213291] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTest media/modern-media-controls/pip-support/pip-support-click.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=168658
<rdar://problem/30799251>

Patch by Antoine Quint <Antoine Quint> on 2017-03-02
Reviewed by Dean Jackson.

Use an asynchronous assertion to determine when the PiP button has been sized and can thus be clicked.

  • media/modern-media-controls/pip-support/pip-support-click-expected.txt:
  • media/modern-media-controls/pip-support/pip-support-click.html:
10:38 AM Changeset in webkit [213290] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Land TestExpectations for rdar://problem/30735372.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:28 AM Changeset in webkit [213289] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[mac-wk1] LayoutTest media/modern-media-controls/mute-button/mute-button.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=165320
<rdar://problem/30809600>

Patch by Antoine Quint <Antoine Quint> on 2017-03-02
Reviewed by Dean Jackson.

Use asynchronous assertions to improve robustness.

  • media/modern-media-controls/mute-button/mute-button-expected.txt:
  • media/modern-media-controls/mute-button/mute-button.html:
10:28 AM Changeset in webkit [213288] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Unreviewed, restore inadvertently-removed non-breaking spaces in Polish translation

  • pl.po:
10:19 AM Changeset in webkit [213287] by Ryan Haddad
  • 5 edits in trunk

Unreviewed, rolling out r213281.

This change caused API test WebKit2.UserMediaBasic to time
out.

Reverted changeset:

"[MediaStream] UIClient may not be notified of capture state
change when leaving a page"
​https://bugs.webkit.org/show_bug.cgi?id=169014
​http://trac.webkit.org/changeset/213281

10:14 AM Changeset in webkit [213286] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Activate some new webrtc tests
​https://bugs.webkit.org/show_bug.cgi?id=168850

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-02

  • platform/ios-simulator-wk2/TestExpectations: Disabling webrtc tests for ios wk2 debug.
10:08 AM Changeset in webkit [213285] by jonlee@apple.com
  • 3 edits in trunk/Source/WebCore

Improve consistency of captions rendering on Mac
​https://bugs.webkit.org/show_bug.cgi?id=169071

Reviewed by Eric Carlson.

  • page/CaptionUserPreferencesMediaAF.h:

(WebCore::CaptionUserPreferencesMediaAF::captionsEdgeColorForTextColor): Deleted.
(WebCore::CaptionUserPreferencesMediaAF::cssPropertyWithTextEdgeColor): Deleted.

  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::appendCSS): Helper function to add a CSS rule with a provided StringBuilder.
(WebCore::CaptionUserPreferencesMediaAF::windowRoundedCornerRadiusCSS): Refactor to use
appendCSS.
(WebCore::CaptionUserPreferencesMediaAF::colorPropertyCSS): Ditto.
(WebCore::CaptionUserPreferencesMediaAF::captionsTextEdgeCSS): Update text edge styles.

  • Add a blur to the shadow
  • Drop shadow style includes 1px text border
  • Always use black for the text edge color

Also convert the stroke rules to using the CSS property and values instead of straight strings.
(WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride): Fly-by fix of a typo.

9:55 AM Changeset in webkit [213284] by Chris Dumez
  • 7 edits
    2 adds in trunk

Download attribute set to "*\" save file with name "example.com"
​https://bugs.webkit.org/show_bug.cgi?id=169066
<rdar://problem/30740875>

Reviewed by Alex Christensen.

Source/WebCore:

The issue is that a backslash in recognized as an escaping character in
a quoted string as per RFC2616:
"
The backslash character ("\") MAY be used as a single-character
quoting mechanism only within quoted-string and comment constructs.
"

We therefore need to escape the backslashes in the filename before
using it in the Content-Disposition header, inside the quoted string.

Test: fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::sanitizeSuggestedFilename):

LayoutTests:

Add layout test coverage.

  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html: Added.
8:24 AM Changeset in webkit [213283] by commit-queue@webkit.org
  • 19 edits
    2 adds in trunk

[WebRTC] Activate ICE candidate privacy policy
​https://bugs.webkit.org/show_bug.cgi?id=168975

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-02
Reviewed by Alex Christensen.

Source/WebCore:

Test: webrtc/datachannel/filter-ice-candidate.html

  • testing/Internals.cpp:

(WebCore::Internals::Internals): Disabling ICE candidate filtering by default for rwt.
(WebCore::Internals::setICECandidateFiltering):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
(-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
(-[WebPreferences iceCandidateFilteringEnabled]):
(-[WebPreferences setIceCandidateFilteringEnabled:]):

  • WebView/WebPreferencesPrivate.h:

Source/WebKit2:

Disabling network enumeration by default.
Enabling ICE candidate filtering by default.
Chaning ICE candidate filtering according userMediaAccess policy:

  • If access is denied, filtering is on.
  • If access is granted, filtering is off.
  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetICECandidateFilteringEnabled):
(WKPreferencesGetICECandidateFilteringEnabled):
(WKPreferencesSetEnumeratingAllNetworkInterfacesEnabled):
(WKPreferencesGetEnumeratingAllNetworkInterfacesEnabled):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::toWebCore):
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted):

  • UIProcess/UserMediaProcessManager.cpp:

(WebKit::UserMediaProcessManager::willCreateMediaStream):
(WebKit::UserMediaProcessManager::endedCaptureSession):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

  • WebProcess/WebPage/WebPage.cpp:

LayoutTests:

  • webrtc/datachannel/filter-ice-candidate-expected.txt: Added.
  • webrtc/datachannel/filter-ice-candidate.html: Added.
8:05 AM Changeset in webkit [213282] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk/LayoutTests

Activate some new webrtc tests
​https://bugs.webkit.org/show_bug.cgi?id=168850

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-02
Reviewed by Alex Christensen.

  • TestExpectations: Activating tests in debug builds.
  • webrtc/datachannel/basic-expected.txt: Added.
  • webrtc/datachannel/basic.html: Activating real webrtc backend.
  • webrtc/libwebrtc/release-while-creating-offer-expected.txt: Added.
  • webrtc/libwebrtc/release-while-getting-stats-expected.txt: Added.
  • webrtc/libwebrtc/release-while-setting-local-description-expected.txt: Added.
  • webrtc/video-disabled-black-expected.txt:
  • webrtc/video-disabled-black.html: Setting expected alpha channel to zero for black frames.
  • webrtc/video-expected.txt:
7:50 AM Changeset in webkit [213281] by eric.carlson@apple.com
  • 4 edits in trunk

[MediaStream] UIClient may not be notified of capture state change when leaving a page
​https://bugs.webkit.org/show_bug.cgi?id=169014
<rdar://problem/30632267>

Reviewed by Youenn Fablet.

Enable and update the WebKit API test WebKit2.UserMedia.

  • dom/Document.cpp:

(WebCore::Document::prepareForDestruction): Always call page.updateIsPlayingMedia() if there
is active media in the document because it won't be possible when the state changes later
because the frame will have been cleared.

7:45 AM Changeset in webkit [213280] by jfernandez@igalia.com
  • 3 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
​https://bugs.webkit.org/show_bug.cgi?id=169081

Unreviewed GTK+ gardening. Moved some failures to the GTK TestExpectations

7:07 AM Changeset in webkit [213279] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+ for 2.16
​https://bugs.webkit.org/show_bug.cgi?id=169072

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2017-03-02
Rubber-stamped by Michael Catanzaro.

  • pl.po:
6:20 AM Changeset in webkit [213278] by tpopela@redhat.com
  • 19 edits
    2 adds in trunk

[WK2] Keyboard menu key should show context menu
​https://bugs.webkit.org/show_bug.cgi?id=72099

Source/WebCore:

Reviewed by Carlos Garcia Campos.

Show the context menu when the GtkWidget::popup-menu signal is
emitted. This signal is triggered by pressing a key (usually
the Menu key or the Shift + F10 shortcut) or it could be emitted on
WebKitWebView.

Test: fast/events/context-activated-by-key-event.html

Also could be tested by:

ManualTests/keyboard-menukey-event.html
ManualTests/win/contextmenu-key.html
ManualTests/win/contextmenu-key2.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):
Correctly send the mouse event that used for showing the context menu.
Previously the event was immediately dispatched as it is, but this was
only the right way if some element was focused on the page. If there
was no focused element or non-empty text range then the event lacked
the right node, where it was supposed to be shown. The correct node
is determined and added to the event in the sendContextMenuEvent() so
we have to use this function to send the event.

Also use absoluteBoundingBoxRect() instead of
pixelSnappedAbsoluteClippedOverflowRect() when determining
a coordinate where to show the context menu for the currently focus
element. The latter is not returning a right box (it is bigger) which
could lead to the situation that no menu will be displayed at all,
because the HitTest won't contain the right element as the
determined coordinates could be outside of the element.

  • page/EventHandler.h:

Source/WebKit2:

Reviewed by Carlos Garcia Campos.

Show the context menu when the GtkWidget::popup-menu signal is
emitted. This signal is triggered by pressing a key (usually
the Menu key or the Shift + F10 shortcut) or it could be emitted on
WebKitWebView.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):
(webkit_web_view_class_init): Update the documentation for the
context-menu signal

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBasePopupMenu): Connect to the popup-menu signal and
save the event that was used to trigger the signal. If there is no
such event create a new GdkEvent with GDK_NOTHING type.
(webkitWebViewBasePopupMenu):
(webkit_web_view_base_class_init):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleContextMenuKeyEvent):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::contextMenuForKeyEvent):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

Show the context menu when the GtkWidget::popup-menu signal is
emitted. This signal is triggered by pressing a key (usually
the Menu key or the Shift + F10 shortcut) or it could be emitted on
WebKitWebView.

Reviewed by Carlos Garcia Campos.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(testContextMenuDefaultMenu):

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(WebViewTest::emitPopupMenuSignal):

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:

LayoutTests:

Reviewed by Carlos Garcia Campos.

Skip the fast/events/context-activated-by-key-event.html on Mac as it
does not have a key to activate the context menu and on iOS as well.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
5:15 AM Changeset in webkit [213277] by jfernandez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
​https://bugs.webkit.org/show_bug.cgi?id=169076

Unreviewed GTK+ gardening. Some tests fail after r213020:

  • editing/deleting/skip-virama-001.html [ Failure ]
  • editing/selection/extend-by-character-007.html [ Failure ]
  • editing/selection/regional-indicators.html [ Failure ]
3:44 AM Changeset in webkit [213276] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Crash in WebCore::CoordinatedGraphicsLayer::notifyFlushRequired
​https://bugs.webkit.org/show_bug.cgi?id=166420

Reviewed by Žan Doberšek.

This is happening when closing a page that is being inspected. When CoordinatedGraphicsLayer::removeFromParent()
is called, the coordinator has already been invalidated, so all its layers were set a nullptr coordinator. I
think it's safe to simply handle m_coordinator being nullptr in notifyFlushRequired().

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::notifyFlushRequired): Return early if the coordinator is nullptr.

1:43 AM Changeset in webkit [213275] by tpopela@redhat.com
  • 2 edits in trunk/Source/JavaScriptCore

Incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals()
​https://bugs.webkit.org/show_bug.cgi?id=169034

Reviewed by Mark Lam.

It should not assign to offset, but compare to offset.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addStaticGlobals):

1:03 AM Changeset in webkit [213274] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Don't keep dead resources in MemoryCache while under memory pressure.
<​https://webkit.org/b/169070>

Reviewed by Antti Koivisto.

Have CachedResource::deleteIfPossible() remove the resource from the MemoryCache
if we're under memory pressure and that was the only thing keeping it alive.

This is consistent with the policy where dead resources are evicted from the cache
as we come under pressure.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::deleteIfPossible):

12:59 AM Changeset in webkit [213273] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

REGRESSION(r213062): [SOUP] UTF-8 filename in Content-Disposition header incorrectly handled since r213062
​https://bugs.webkit.org/show_bug.cgi?id=169024

Reviewed by Youenn Fablet.

This made test http/tests/download/literal-utf-8.html to start failing. The problem is that I removed the
conversion made by String::fromUTF8WithLatin1Fallback that was added in r176930. I removed it because that made
fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html to timeout. This patch brings back
the String::fromUTF8WithLatin1Fallback call but only when the header string is 8 bit one.

Fixes: http/tests/download/literal-utf-8.html

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::platformSuggestedFilename):

Note: See TracTimeline for information about the timeline view.