Timeline



Mar 1, 2021:

10:59 PM Changeset in webkit [273724] by Fujii Hironori
  • 4 edits in trunk

[GTK] Web inspector related tests very slow or timeout in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=208000

Reviewed by Carlos Garcia Campos.

Source/WebKit:

setTimeout was very slow in the inspector page because it was
throttled by 1 second due to that the page is hidden. Mac port
disables HiddenPageDOMTimerThrottlingEnabled for the inspector
page under testing. Do the same for GTK port.

  • UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateFrontendPage):
setHiddenPageDOMTimerThrottlingEnabled(false) if under test.

LayoutTests:

  • platform/gtk/TestExpectations: Unmarked tests for Bug 149916 and Bug 208000.
9:00 PM Changeset in webkit [273723] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC][IFC] Move simplified baseline alignment to a dedicated function
​https://bugs.webkit.org/show_bug.cgi?id=222564

Reviewed by Antti Koivisto.

This is in preparation for supporting non-atomic inline level boxes.

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::simplifiedAlignInlineBoxIfApplicable const):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

8:21 PM Changeset in webkit [273722] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] Move simplified vertical alignment computation to struct SimplifiedVerticalAlignment
​https://bugs.webkit.org/show_bug.cgi?id=222562

Reviewed by Antti Koivisto.

This is in preparation for supporting non-atomic inline level boxes (by just calling simplifiedVerticalAlignment.adjust(inlineLevelBox)).

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::SimplifiedVerticalAlignment::SimplifiedVerticalAlignment):
(WebCore::Layout::SimplifiedVerticalAlignment::rootInlineBoxLogicalTop const):
(WebCore::Layout::SimplifiedVerticalAlignment::lineBoxHeight const):
(WebCore::Layout::SimplifiedVerticalAlignment::adjust):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

8:17 PM Changeset in webkit [273721] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make DictionaryLookup::rangeAtHitTestResult more robust
​https://bugs.webkit.org/show_bug.cgi?id=222301
<rdar://problem/74529831>

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-03-01
Reviewed by Brent Fulgham.

This may be related to r265084 but something is crashing and I'm not sure what.
Adding some Optional checks might fix something, but this is still puzzling to me.

  • editing/cocoa/DictionaryLookup.mm:

(WebCore::DictionaryLookup::rangeAtHitTestResult):

8:08 PM Changeset in webkit [273720] by Lauro Moura
  • 4 edits in trunk/LayoutTests

[GLIB] Gardening three common timeouts

Unreviewed test gardening.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
7:37 PM Changeset in webkit [273719] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] Do not try to run simplified alignment when line-height is set
​https://bugs.webkit.org/show_bug.cgi?id=222559

Reviewed by Antti Koivisto.

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::LineBoxBuilder):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

6:14 PM Changeset in webkit [273718] by keith_miller@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Reduce promise reaction memory usage when there are multiple reactions
​https://bugs.webkit.org/show_bug.cgi?id=222533

Reviewed by Yusuke Suzuki.

Previously, we would store each reaction in a linked list. This
meant each reaction required 8 bytes to point to the next
reaction. Instead, this patch makes it so the first reaction is
store inline an object and any additional reactions are store into
index storage for that object. This doesn't save memory for the
first reaction since we now need to have a count of all the out of
line reactions but extra reactions use 8 bytes less each.

  • builtins/BuiltinNames.h:
  • builtins/PromiseOperations.js:

(globalPrivate.pushNewPromiseReaction):
(globalPrivate.triggerPromiseReactions):
(globalPrivate.newPromiseReaction): Deleted.
(globalPrivate.resolvePromise): Deleted.
(globalPrivate.rejectPromise): Deleted.
(globalPrivate.fulfillPromise): Deleted.
(globalPrivate.resolvePromiseWithFirstResolvingFunctionCallCheck): Deleted.
(globalPrivate.fulfillPromiseWithFirstResolvingFunctionCallCheck): Deleted.
(globalPrivate.rejectPromiseWithFirstResolvingFunctionCallCheck): Deleted.
(globalPrivate.createResolvingFunctions): Deleted.
(globalPrivate.promiseReactionJobWithoutPromise): Deleted.
(globalPrivate.resolveWithoutPromise): Deleted.
(globalPrivate.rejectWithoutPromise): Deleted.
(globalPrivate.fulfillWithoutPromise): Deleted.
(globalPrivate.createResolvingFunctionsWithoutPromise): Deleted.
(globalPrivate.promiseReactionJob): Deleted.
(globalPrivate.promiseResolveThenableJobFast): Deleted.
(globalPrivate.promiseResolveThenableJobWithoutPromiseFast): Deleted.
(globalPrivate.promiseResolveThenableJob): Deleted.
(globalPrivate.promiseResolveThenableJobWithDerivedPromise): Deleted.
(onFulfilled): Deleted.
(onRejected): Deleted.
(globalPrivate.performPromiseThen): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/JSMicrotask.cpp:

(JSC::createJSMicrotask):

  • runtime/JSMicrotask.h:
6:04 PM Changeset in webkit [273717] by ysuzuki@apple.com
  • 3 edits
    1 add in trunk

REGRESSION: Object.defineProperties triggering a setter
​https://bugs.webkit.org/show_bug.cgi?id=222538

Reviewed by Keith Miller.

JSTests:

  • stress/dfg-put-by-val-string-or-symbol-should-check-direct.js: Added.

(test1):
(test2):

Source/JavaScriptCore:

DFG's compilePutByValForCellWithString and compilePutByValForCellWithSymbol do not care about "Direct" flag.
This patch fixes that to call appropriate function if node is PutByValDirect.
FTL does not have this issue.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForCellWithString):
(JSC::DFG::SpeculativeJIT::compilePutByValForCellWithSymbol):

5:57 PM Changeset in webkit [273716] by Jonathan Bedard
  • 8 edits in trunk/Tools

[wbkitscmpy] Add commits with colliding timestamps
​https://bugs.webkit.org/show_bug.cgi?id=222572
<rdar://problem/74887215>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Scripts/libraries/webkitscmpy/webkitscmpy/mocks/git-repo.json: Add commit with colliding timestamp.
  • Scripts/libraries/webkitscmpy/webkitscmpy/test/canonicalize_unittest.py:
  • Scripts/libraries/webkitscmpy/webkitscmpy/test/checkout_unittest.py:
  • Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py:
  • Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
5:52 PM Changeset in webkit [273715] by Chris Fleizach
  • 6 edits
    2 adds in trunk

AX: VoiceOver announces grid as having "0 columns" and VoiceOver cannot enter the grid
​https://bugs.webkit.org/show_bug.cgi?id=222440
<rdar://problem/74763792>

Reviewed by Zalan Bujtas.

Source/WebCore:

Support the ability of an ARIA table row to reference its cells through aria-owns.

Test: accessibility/aria-grid-with-aria-owns-rows.html

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::ariaOwnedByParent const):
(WebCore::AccessibilityTableCell::parentObjectUnignored const):
(WebCore::AccessibilityTableCell::parentRow const):

  • accessibility/AccessibilityTableCell.h:
  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::addChildren):

LayoutTests:

  • accessibility/aria-grid-with-aria-owns-rows-expected.txt: Added.
  • accessibility/aria-grid-with-aria-owns-rows.html: Added.
5:51 PM Changeset in webkit [273714] by Peng Liu
  • 2 edits in trunk/LayoutTests

[GPUP] Some media related security tests time out when media in GPU Process is enabled
​https://bugs.webkit.org/show_bug.cgi?id=221793

Unreviewed test gardening.

  • platform/wk2/TestExpectations:
5:44 PM Changeset in webkit [273713] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Have WebProcessProxy::requestTermination() call processDidTerminateOrFailedToLaunch()
​https://bugs.webkit.org/show_bug.cgi?id=222577

Reviewed by Geoffrey Garen.

Have WebProcessProxy::requestTermination() call processDidTerminateOrFailedToLaunch() instead of duplicating
the code. It was error-prone to have 2 separate code paths whether the process exited due to a crash or a
termination request. It led to Bug 222574 for example because we added some logic to remove the process from
the cache in processDidTerminateOrFailedToLaunch() but had failed to do so in requestTermination().

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch):
(WebKit::WebProcessProxy::didFinishLaunching):
(WebKit::WebProcessProxy::requestTermination):

  • UIProcess/WebProcessProxy.h:
5:40 PM Changeset in webkit [273712] by Peng Liu
  • 2 edits in trunk/LayoutTests

[GPUP] Some tests in http/tests/media fail or time out when media in GPU Process is enabled
​https://bugs.webkit.org/show_bug.cgi?id=221694

Unreviewed test gardening.

Remove the tests which are consistently passing on bots from the test expectations.

  • platform/wk2/TestExpectations:
5:32 PM Changeset in webkit [273711] by Wenson Hsieh
  • 7 edits
    1 add in trunk

Support rotated image overlay text for non-rectilinear text quads
​https://bugs.webkit.org/show_bug.cgi?id=222535
<rdar://problem/74886200>

Reviewed by Tim Horton.

Source/WebCore:

Add support for rendering image overlay elements at rotated angles. To achieve this, we add a new helper
function to GeometryUtilities.h, rotatedBoundingRect, that takes a FloatQuad and returns a struct that
describes a (potentially) rotated bounding rect that covers all the points in the quad.

Tests: FloatQuad.RotatedBoundingRectForPoint

FloatQuad.RotatedBoundingRectForLineSegment
FloatQuad.RotatedBoundingRectForTriangle
FloatQuad.RotatedBoundingRectForTrapezoid
FloatQuad.RotatedBoundingRectWithMinimumAngle

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::updateWithImageExtractionResult):

Add a slight (0.01 rad) tolerance here, such we won't attempt to apply a rotation transformation if the text
quad is aligned (or nearly aligned) with the unit vector (1, 0).

  • platform/graphics/GeometryUtilities.cpp:

(WebCore::midPoint):
(WebCore::dotProduct):
(WebCore::angleBetweenVectors):
(WebCore::rotatedBoundingRect):

  • platform/graphics/GeometryUtilities.h:
  • platform/graphics/PathTraversalState.cpp:

(WebCore::midPoint): Deleted.

Tools:

Add a new API test file to exercise the new rotatedBoundingRect function, with tests to cover a few degenerate
cases such as a single point, line segments, and triangles.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/FloatQuadTests.cpp: Added.

(TestWebKitAPI::areApproximatelyEqual):
(TestWebKitAPI::expectRotatedRect):
(TestWebKitAPI::TEST):

5:22 PM Changeset in webkit [273710] by Ruben Turcios
  • 1 copy in tags/Safari-611.1.21.3.1

Tag Safari-611.1.21.3.1.

5:16 PM Changeset in webkit [273709] by Ruben Turcios
  • 1 copy in tags/Safari-611.1.21.2.1

Tag Safari-611.1.21.2.1.

5:13 PM Changeset in webkit [273708] by Alan Coon
  • 1 copy in tags/Safari-611.1.21.1.2

Tag Safari-611.1.21.1.2.

5:13 PM Changeset in webkit [273707] by Peng Liu
  • 2 edits in trunk/LayoutTests

[GPUP] Some tests in imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements fail when media in GPU Process is enabled
​https://bugs.webkit.org/show_bug.cgi?id=221697

Unreviewed test gardening.

  • platform/wk2/TestExpectations:
5:09 PM Changeset in webkit [273706] by Alan Coon
  • 8 edits in branches/safari-611.1.21.1-branch/Source

Versioning.

WebKit-7611.1.21.1.2

5:04 PM Changeset in webkit [273705] by Peng Liu
  • 2 edits in trunk/LayoutTests

[GPUP] Some media related content security policy tests fail when media in GPU Process is enabled
​https://bugs.webkit.org/show_bug.cgi?id=221792

Unreviewed test gardening.

  • platform/wk2/TestExpectations:
5:03 PM Changeset in webkit [273704] by Truitt Savell
  • 2 edits in trunk/LayoutTests

fast/canvas/webgl/texImage2D-video-flipY-false.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=222500

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
5:00 PM Changeset in webkit [273703] by Alan Coon
  • 1 copy in tags/Safari-611.1.21.0.1

Tag Safari-611.1.21.0.1.

4:51 PM Changeset in webkit [273702] by Alan Coon
  • 1 copy in tags/Safari-611.1.21.1.1

Tag Safari-611.1.21.1.1.

4:10 PM Changeset in webkit [273701] by Peng Liu
  • 2 edits in trunk/LayoutTests

[GPUP] Some modern-media-controls tests are flaky when media in GPU Process is enabled
​https://bugs.webkit.org/show_bug.cgi?id=221685

Unreviewed test gardening.

  • platform/wk2/TestExpectations:
3:53 PM Changeset in webkit [273700] by Truitt Savell
  • 14 edits in trunk/Source

Unreviewed, reverting r273655.

Broke internal Mac

Reverted changeset:

"Set ownership of IOSurfaces from the GPUProcess instead of
the WebProcess"
​https://bugs.webkit.org/show_bug.cgi?id=222391
​https://commits.webkit.org/r273655

3:44 PM Changeset in webkit [273699] by pvollan@apple.com
  • 2 edits in trunk

[Win] Fix build failure
​https://bugs.webkit.org/show_bug.cgi?id=222576
<rdar://problem/74590803>
Reviewed by Brent Fulgham.

It appears a recent change has unintentionally enabled WebInspectorUI on Apple Win. Address this by explicitly disabling it.

  • Source/cmake/OptionsAppleWin.cmake:
3:28 PM Changeset in webkit [273698] by Chris Gambrell
  • 3 edits
    3 adds
    3 deletes in trunk/LayoutTests

[LayoutTests] Convert http/tests/websocket convert PHP to Python
​https://bugs.webkit.org/show_bug.cgi?id=221912
<rdar://problem/74358196>

Reviewed by Jonathan Bedard.

  • http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.php: Removed.
  • http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.py: Added.
  • http/tests/websocket/tests/hybi/contentextensions/block-cookies.php: Removed.
  • http/tests/websocket/tests/hybi/contentextensions/block-cookies.py: Added.
  • http/tests/websocket/tests/hybi/contentextensions/resources/block-cookies-worker.js:

(clearCookies):

  • http/tests/websocket/tests/hybi/error-event-ready-state-non-existent-url-with-server-responding-404.html:
  • http/tests/websocket/tests/hybi/resources/status-404-without-body.php: Removed.
  • http/tests/websocket/tests/hybi/resources/status-404-without-body.py: Added.
3:15 PM Changeset in webkit [273697] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix unused variable warning
​https://bugs.webkit.org/show_bug.cgi?id=222405
<rdar://problem/74769938>

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-03-01

  • platform/NowPlayingManager.cpp:

(WebCore::NowPlayingManager::setNowPlayingInfo):

3:11 PM Changeset in webkit [273696] by Peng Liu
  • 3 edits in trunk/LayoutTests

[GPUP] Clean up LayoutTests/gpu-process/TestExpectations related to media tests
​https://bugs.webkit.org/show_bug.cgi?id=222570

Reviewed by Eric Carlson.

Clean up test expectations.

  • Remove duplicate test expectations.
  • Move some media tests from gpu-process/TestExpectations to platform/wk2/TestExpectations.
  • Remove tests which are passing consistently from gpu-process/TestExpectations.
  • gpu-process/TestExpectations:
  • platform/wk2/TestExpectations:
3:07 PM Changeset in webkit [273695] by Chris Dumez
  • 6 edits in trunk

Crash under WebProcessPool::pageBeginUsingWebsiteDataStore()
​https://bugs.webkit.org/show_bug.cgi?id=222574
<rdar://68340471>

Reviewed by Geoffrey Garen.

Source/WebKit:

The issue was that when WebProcessProxy::requestTermination() was called (e.g. process is killed by WebKit
for using too much memory), we would fail to remove the process from the WebProcessCache. Because the
terminated would stay in the cache (even though WebProcessProxy::shutDown() was called), we could potentially
try and use it later on for a navigation to the same domain. This would lead to crashes because
WebProcessProxy::shutDown() has already been called.

Note that we were previously correctly removing the process from the cache in case of a proper crash, inside
WebProcessProxy::processDidTerminateOrFailedToLaunch(). I have moved the logic to remove from the cache
from processDidTerminateOrFailedToLaunch() to shutDown() to avoid similar issues in the future.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _requestWebProcessTermination:]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch):

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3:06 PM Changeset in webkit [273694] by stephan.szabo@sony.com
  • 2 edits in trunk/Source/WebKit

[WinCairo] Building with ENABLE_SERVICE_WORKER=OFF fails
​https://bugs.webkit.org/show_bug.cgi?id=222566

Unreviewed build fix.

  • UIProcess/WebProcessPool.cpp: Only compile a method when service

worker is enabled.

2:58 PM Changeset in webkit [273693] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Have WebProcessPool::processForRegistrableDomain() return a Ref<WebProcessProxy>
​https://bugs.webkit.org/show_bug.cgi?id=222575

Reviewed by Geoffrey Garen.

Have WebProcessPool::processForRegistrableDomain() return a Ref<WebProcessProxy> instead of a WebProcessProxy&,
for extra safety. Returning a WebProcessProxy& is generally safe because the WebProcessPool is expected to hold
a reference to the WebProcessProxy it is returning (via WebProcessPool::m_processes). However, this is a bit
fragile and can lead to bad bugs as we've seen recently.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::processForRegistrableDomain):
(WebKit::WebProcessPool::createWebPage):

  • UIProcess/WebProcessPool.h:
2:29 PM Changeset in webkit [273692] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Protect AudioWorkletGlobalScope::registerProcessor() against re-entry
​https://bugs.webkit.org/show_bug.cgi?id=222567
<rdar://74860464>

Reviewed by Eric Carlson.

AudioWorkletGlobalScope::registerProcessor() checks if 'name' is in m_processorConstructorMap
then does some checks that potentially run JS and thus call registerProcessor() again (potentially
with the same name). To address this, we now check the map again after potentially running the
JS code.

  • Modules/webaudio/AudioWorkletGlobalScope.cpp:

(WebCore::AudioWorkletGlobalScope::registerProcessor):

2:02 PM Changeset in webkit [273691] by Truitt Savell
  • 2 edits
    4 moves in trunk/LayoutTests

[Big Sur] platform/mac-bigsur/media/media-source/media-source-webm-vorbis-partial.html is consistently failing
​https://bugs.webkit.org/show_bug.cgi?id=222495

Unreviewed test gardening.

  • media/media-source/content/test-48kHz-vorbis-manifest.json: Renamed from LayoutTests/platform/mac-bigsur/media/media-source/content/test-48kHz-vorbis-manifest.json.
  • media/media-source/content/test-48kHz-vorbis.webm: Renamed from LayoutTests/platform/mac-bigsur/media/media-source/content/test-48kHz-vorbis.webm.
  • media/media-source/media-source-webm-vorbis-partial-expected.txt: Renamed from LayoutTests/platform/mac-bigsur/media/media-source/media-source-webm-vorbis-partial-expected.txt.
  • media/media-source/media-source-webm-vorbis-partial.html: Renamed from LayoutTests/platform/mac-bigsur/media/media-source/media-source-webm-vorbis-partial.html.
  • platform/mac/TestExpectations:
1:32 PM Changeset in webkit [273690] by Martin Robinson
  • 10 edits
    4 adds in trunk

Scroll snapping doesn't kick in when dragging scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=146696

Reviewed by Simon Fraser.

Source/WebCore:

This change adds support for scroll snap when the scrollbar thumb is
released from a drag operation. This animation is currently done with
the non-native scroll animator for all platforms, since that is also
what is used for smooth scrolling.

This change adjusts the non-native scroll animator's smoothness factor,
because it is too slow for short scroll snaps. I have verified that the
new smoothness factor is also a good selection for smooth scrolling
operations (still an experimental feature). A further change should use
"native" animations when possible for both smooth scrolling and scroll
snap after thumb drags. This is tracked by the following bug:
​https://bugs.webkit.org/show_bug.cgi?id=218857

Tests: css3/scroll-snap/scroll-snap-click-scrollbar-gutter.html

css3/scroll-snap/scroll-snap-drag-scrollbar-thumb.html

  • platform/ScrollAnimationSmooth.cpp: Modify smoothFactorForProgrammaticScroll to

a value that is good for both scroll snapping and smooth scrolling.

  • platform/ScrollAnimator.cpp: The tick method for the non-native scroll animation

should continually update the current active snap point.
(WebCore::ScrollAnimator::adjustScrollOffsetForSnappingIfNeeded): Split this into
two methods. One that handles a single axis and one that handles both.

  • platform/ScrollAnimator.h: Update method declarations.
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::doPostThumbDragSnapping): Added this method which does
axial snapping after a scrollbar thum drag.

  • platform/ScrollableArea.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::mouseUp): Use the new doPostThumbDragSnapping method.

LayoutTests:

Add support for scroll snap after dragging scrollbar thumb

This change adds support for scroll snap when the scrollbar thumb is
released from a drag operation. This animation is currently done with
the non-native scroll animator for all platforms, since that is also
what is used for smooth scrolling.

This change adjusts the non-native scroll animator's smoothness factor,
because it is too slow for short scroll snaps. I have verified that the
new smoothness factor is also a good selection for smooth scrolling
operations (still an experimental feature). A further change should use
"native" animations when possible for both smooth scrolling and scroll
snap after thumb drags. This is tracked by the following bug:
​https://bugs.webkit.org/show_bug.cgi?id=218857

  • css3/scroll-snap/scroll-snap-click-scrollbar-gutter-expected.txt: Added.
  • css3/scroll-snap/scroll-snap-click-scrollbar-gutter.html: Added.
  • css3/scroll-snap/scroll-snap-drag-scrollbar-thumb-expected.txt: Added.
  • css3/scroll-snap/scroll-snap-drag-scrollbar-thumb.html: Added.
  • platform/ios-wk2/TestExpectations: Mark new test as failing on iOS

which has issues with scrollbars.

  • platform/ios/TestExpectations: Skip the new test on iOS which does not

support scrolling by dragging the scrollbar.

1:29 PM Changeset in webkit [273689] by Alan Coon
  • 8 edits in branches/safari-611.1.21.1-branch/Source

Cherry-pick r273564. rdar://problem/74886917

[Cocoa] Register VP9 decoders when PlatformMediaSessionManager is created
​https://bugs.webkit.org/show_bug.cgi?id=222473
<rdar://problem/74790242>

Reviewed by Eric Carlson.

Source/WebCore:

Currently, VP9 decoders are registered when a Web page is created in the WebContent process. Instead, VP9 decoders can be registered
when PlatformMediaSessionManager is created, which should be a slight performance improvement, since calls into media frameworks will
then not be made unconditionally when creating a Web page, but delayed until required.

No new tests, covered by existing tests.

  • platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::setShouldEnableVP9Decoder): (WebCore::PlatformMediaSessionManager::shouldEnableVP9Decoder): (WebCore::PlatformMediaSessionManager::setShouldEnableVP8Decoder): (WebCore::PlatformMediaSessionManager::shouldEnableVP8Decoder): (WebCore::PlatformMediaSessionManager::setShouldEnableVP9SWDecoder): (WebCore::PlatformMediaSessionManager::shouldEnableVP9SWDecoder):
  • platform/audio/PlatformMediaSessionManager.h:
  • platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::MediaSessionManagerCocoa):

Source/WebKit:

Currently, VP9 decoders are registered when a Web page is created in the WebContent process. Instead, VP9 decoders can be registered when
PlatformMediaSessionManager is created, which should be a slight performance improvement, since calls into media frameworks will then not
be made unconditionally when creating a Web page, but delayed until required.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::m_lastNavigationWasAppBound):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::enableVP9Decoder): Deleted. (WebKit::WebProcess::enableVP8SWDecoder): Deleted. (WebKit::WebProcess::enableVP9SWDecoder): Deleted.
  • WebProcess/WebProcess.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:27 PM Changeset in webkit [273688] by weinig@apple.com
  • 19 edits
    3 adds in trunk/Source

Add alternate, non-named-getter based, implementation of CSSStyleDeclaration back into WebCore
​https://bugs.webkit.org/show_bug.cgi?id=222517

Reviewed by Darin Adler.

Source/WebCore:

Re-lands change from r268564 but disabled behind a new ENABLE flag,
ENABLE(ATTRIBUTE_BASED_PROPERTIES_FOR_CSS_STYLE_DECLARATION).

Replace named getter/setter based implementation of access to CSSStyleDeclaration property values
with a generated partial interface that lists all the properties exactly.

To keep things consistent with existing behavior, in addition to the spec'd properties, we also
maintain additional properties for epub prefixed properties.

  • CMakeLists.txt:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:

Generate CSSStyleDeclaration+PropertyNames.idl and ensure it is compile together with the other
bindings.

  • css/makeprop.pl:

Add generation of CSSStyleDeclaration+PropertyNames.idl from CSSProperties.json. Add checking
of the enable flag to ensure it is not compiled by default.

  • bindings/scripts/CodeGeneratorJS.pm:

(ToMethodName):
Don't transform names that start with CSSOM to ensure property names are consistent.

(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):

  • bindings/scripts/IDLAttributes.json:

Add initial support for the new CSSProperty extended attribute. Only the tests and
the disabled code in CSSStyleDeclaration+PropertyNames.idl currently use it.

  • bindings/scripts/test/BindingTestGlobalConstructors.idl:
  • bindings/scripts/test/JS/JSTestCSSProperty.cpp: Added.
  • bindings/scripts/test/JS/JSTestCSSProperty.h: Added.
  • bindings/scripts/test/SupplementalDependencies.dep:
  • bindings/scripts/test/TestCSSProperty.idl: Added.

Add tests for the new CSSProperty extended attribute.

(WebCore::CSSComputedStyleDeclaration::setPropertyInternal):

  • css/CSSComputedStyleDeclaration.h:
  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):

  • css/PropertySetCSSStyleDeclaration.h:

Remove unused bool return value from getPropertyValueInternal (it goes from
ExceptionOr<bool> to ExceptionOr<void>) to simplify some callers that no longer
need to check the return value.

  • css/CSSStyleDeclaration.cpp:
  • css/CSSStyleDeclaration.h:

Extract out setPropertyValueInternal so it can be used by the bindings generator
for CSSProperty attributes.

  • css/CSSStyleDeclaration.idl:

Move named getter/setter declarations and DefaultDefineOwnProperty inside of
enable flags checks so that when it is disabled, we don't use them.

Source/WTF:

  • wtf/PlatformEnable.h:

Add new off by default ENABLE flag ENABLE(ATTRIBUTE_BASED_PROPERTIES_FOR_CSS_STYLE_DECLARATION) which indicates
that we should use the new attribute based implementation of property getter/setters of CSSStyleDeclaration.
Once we remove the compile time and binary size regressions, we can enable this and remove the macro.

1:24 PM Changeset in webkit [273687] by Truitt Savell
  • 2 edits in trunk/LayoutTests

media/media-fullscreen-pause-inline.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=222573

RUnreviewed test gardening.

  • platform/mac/TestExpectations:
1:23 PM Changeset in webkit [273686] by Alan Coon
  • 8 edits in branches/safari-611.1.21.0-branch/Source

Cherry-pick r273564. rdar://problem/74886738

[Cocoa] Register VP9 decoders when PlatformMediaSessionManager is created
​https://bugs.webkit.org/show_bug.cgi?id=222473
<rdar://problem/74790242>

Reviewed by Eric Carlson.

Source/WebCore:

Currently, VP9 decoders are registered when a Web page is created in the WebContent process. Instead, VP9 decoders can be registered
when PlatformMediaSessionManager is created, which should be a slight performance improvement, since calls into media frameworks will
then not be made unconditionally when creating a Web page, but delayed until required.

No new tests, covered by existing tests.

  • platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::setShouldEnableVP9Decoder): (WebCore::PlatformMediaSessionManager::shouldEnableVP9Decoder): (WebCore::PlatformMediaSessionManager::setShouldEnableVP8Decoder): (WebCore::PlatformMediaSessionManager::shouldEnableVP8Decoder): (WebCore::PlatformMediaSessionManager::setShouldEnableVP9SWDecoder): (WebCore::PlatformMediaSessionManager::shouldEnableVP9SWDecoder):
  • platform/audio/PlatformMediaSessionManager.h:
  • platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::MediaSessionManagerCocoa):

Source/WebKit:

Currently, VP9 decoders are registered when a Web page is created in the WebContent process. Instead, VP9 decoders can be registered when
PlatformMediaSessionManager is created, which should be a slight performance improvement, since calls into media frameworks will then not
be made unconditionally when creating a Web page, but delayed until required.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::m_lastNavigationWasAppBound):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::enableVP9Decoder): Deleted. (WebKit::WebProcess::enableVP8SWDecoder): Deleted. (WebKit::WebProcess::enableVP9SWDecoder): Deleted.
  • WebProcess/WebProcess.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:16 PM Changeset in webkit [273685] by Chris Gambrell
  • 28 edits
    26 adds
    27 deletes in trunk/LayoutTests

[LayoutTests] Convert http/tests/loading convert PHP to Python
​https://bugs.webkit.org/show_bug.cgi?id=222198
<rdar://problem/74536576>

Reviewed by Jonathan Bedard.

  • http/tests/loading/307-after-303-after-post-expected.txt:
  • http/tests/loading/307-after-303-after-post.html:
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt:
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html:
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php: Removed.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.py: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php: Removed.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.py: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php: Removed.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.py: Added.
  • http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt:
  • http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html:
  • http/tests/loading/basic-auth-remove-credentials-expected.txt:
  • http/tests/loading/basic-auth-remove-credentials.html:
  • http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
  • http/tests/loading/basic-auth-resend-wrong-credentials.html:
  • http/tests/loading/basic-credentials-sent-automatically-expected.txt:
  • http/tests/loading/basic-credentials-sent-automatically.html:
  • http/tests/loading/nested_bad_objects.php: Removed.
  • http/tests/loading/nested_bad_objects.py: Added.
  • http/tests/loading/oauth.html:
  • http/tests/loading/post-in-iframe-with-back-navigation-expected.txt:
  • http/tests/loading/post-in-iframe-with-back-navigation.html:
  • http/tests/loading/preload-append-scan.php: Removed.
  • http/tests/loading/preload-append-scan.py: Added.
  • http/tests/loading/preload-slow-loading.php: Removed.
  • http/tests/loading/preload-slow-loading.py: Added.
  • http/tests/loading/redirect-with-no-location-crash.html:
  • http/tests/loading/resourceLoadStatistics/resources/get-cookies.php: Removed.
  • http/tests/loading/resourceLoadStatistics/resources/get-cookies.py: Added.
  • http/tests/loading/resourceLoadStatistics/resources/set-cookie.php: Removed.
  • http/tests/loading/resources/303-to-307-target.php: Removed.
  • http/tests/loading/resources/303-to-307-target.py: Added.
  • http/tests/loading/resources/307-post-output-target.php: Removed.
  • http/tests/loading/resources/307-post-output-target.py: Added.
  • http/tests/loading/resources/basic-auth-testing.php: Removed.
  • http/tests/loading/resources/basic-auth-testing.py: Added.
  • http/tests/loading/resources/cached-stylesheet-from-different-domain-frame.css.php: Removed.
  • http/tests/loading/resources/cached-stylesheet-from-different-domain-frame.css.py: Added.
  • http/tests/loading/resources/cached-stylesheet-from-different-domain-frame.html:
  • http/tests/loading/resources/imported-stylesheet-varying-according-domain.css.php: Removed.
  • http/tests/loading/resources/imported-stylesheet-varying-according-domain.css.py: Added.
  • http/tests/loading/resources/oauth-subresource.php: Removed.
  • http/tests/loading/resources/oauth-subresource.py: Added.
  • http/tests/loading/resources/othersubresources/protected-resource.php: Removed.
  • http/tests/loading/resources/othersubresources/protected-resource.py: Added.
  • http/tests/loading/resources/page-with-slow-loading-subresource.html:
  • http/tests/loading/resources/post-in-iframe-with-back-navigation-page-1.php: Removed.
  • http/tests/loading/resources/post-in-iframe-with-back-navigation-page-1.py: Added.
  • http/tests/loading/resources/post-in-iframe-with-back-navigation-page-2.php: Removed.
  • http/tests/loading/resources/post-in-iframe-with-back-navigation-page-2.py: Added.
  • http/tests/loading/resources/post-in-iframe-with-back-navigation-page-3.php: Removed.
  • http/tests/loading/resources/post-in-iframe-with-back-navigation-page-3.py: Added.
  • http/tests/loading/resources/post-to-303-target.php: Removed.
  • http/tests/loading/resources/post-to-303-target.py: Added.
  • http/tests/loading/resources/protected-resource.php: Removed.
  • http/tests/loading/resources/protected-resource.py: Added.
  • http/tests/loading/resources/redirect-with-no-location-crash.php: Removed.
  • http/tests/loading/resources/redirect-with-no-location-crash.py: Added.
  • http/tests/loading/resources/resource-that-goes-back-while-still-loading.php: Removed.
  • http/tests/loading/resources/resource-that-goes-back-while-still-loading.py: Added.
  • http/tests/loading/resources/server-redirect-result.html:
  • http/tests/loading/resources/server-redirect.php: Removed.
  • http/tests/loading/resources/server-redirect.py: Added.
  • http/tests/loading/resources/slowimage.php: Removed.
  • http/tests/loading/resources/slowimage.py: Added.
  • http/tests/loading/resources/subresources/protected-resource.php: Removed.
  • http/tests/loading/resources/subresources/protected-resource.py: Added.
  • http/tests/loading/resources/test2/basic-auth-testing.php: Removed.
  • http/tests/loading/resources/test2/basic-auth-testing.py: Added.
  • http/tests/loading/resources/test2/protected-resource.php: Removed.
  • http/tests/loading/resources/test2/protected-resource.py: Added.
  • http/tests/loading/server-redirect-for-provisional-load-caching-expected.txt:
  • http/tests/loading/server-redirect-for-provisional-load-caching.html:
  • http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html:
  • platform/ios-wk1/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt:
  • platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
  • platform/wk2/http/tests/loading/server-redirect-for-provisional-load-caching-expected.txt:
1:09 PM Changeset in webkit [273684] by Andres Gonzalez
  • 8 edits
    1 copy
    2 moves
    1 add in trunk

WebAccessibilityObjectWrapper method to retrieve related error message elements should return not-ignored accessibility elements.
​https://bugs.webkit.org/show_bug.cgi?id=222375

Reviewed by Chris Fleizach.

Source/WebCore:

Tests: accessibility/ios-simulator/aria-errormessage.html

accessibility/mac/aria-errormessage.html

The iOS implementation of [WebAccessibilityObjectWrapper accessibilityErrorMessageElements]
was returning container elements that are not accessibility elements,
i.e., isAccessibilityElement return false. That caused that iOS clients could not get any info about the error messages.
With this patch, accessibilityErrorMessageElements drills down the
hierarchy of accessibility objects for the error message elements and
returns those descendants that are accessibility elements.

  • accessibility/AccessibilityObjectInterface.h:

(WebCore::Accessibility::enumerateDescendants):
Hellper function to enumerate descendants of a given AX object.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityErrorMessageElements]):
Returns elements for which isAccessibilityElement == YES.

LayoutTests:

Replaced accessibility/aria-errormessage.html with mac and ios-simulator variants.

  • accessibility/ios-simulator/aria-errormessage-expected.txt: Added.
  • accessibility/ios-simulator/aria-errormessage.html: Copied from LayoutTests/accessibility/aria-errormessage.html.
  • accessibility/mac/aria-errormessage-expected.txt: Renamed from LayoutTests/accessibility/aria-errormessage-expected.txt.
  • accessibility/mac/aria-errormessage.html: Renamed from LayoutTests/accessibility/aria-errormessage.html.
  • platform/glib/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
12:56 PM Changeset in webkit [273683] by weinig@apple.com
  • 18 edits
    3 adds in trunk

Add experimental support for CSS Color 5 color-contrast()
​https://bugs.webkit.org/show_bug.cgi?id=222530

Reviewed by Simon Fraser.

Source/WebCore:

This feature is off by default and can be enabled via the CSSColorContrastEnabled
experimental preference flag.

This implementation has the same restriction on it that the recently landed
Relative Color Syntax and color-mix() do, in that it does support system colors
or currentColor as input, since those can't be resolved at parse time. Ultimately,
we will need to add a late binding version of this for those cases.

Test: fast/css/parsing-color-contrast.html

  • Headers.cmake:
  • WebCore.xcodeproj/project.pbxproj:

Add new ColorLuminance.h header where the generic relative luminance and contrast ratio
functions live.

  • css/CSSValueKeywords.in:

Add new keywords, color-contrast and vs, that are needed for the color-contrast() function.

  • css/parser/CSSParserContext.cpp:
  • css/parser/CSSParserContext.h:

Add a setting for color-contrast.

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::parseColorContrastFunctionParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunction):
Add parsing and computation of color-contrast().

  • platform/graphics/ColorUtilities.cpp:

(WebCore::lightness): Deleted.
(WebCore::luminance): Deleted.
(WebCore::contrastRatio): Deleted.
Moved luminance related functions to ColorLuminance.h and inlined lightness
to its one caller, Color and noted it should be removed.

  • platform/graphics/ColorUtilities.h:

(WebCore::invertedColorWithOverriddenAlpha):
(WebCore::invertedcolorWithOverriddenAlpha): Deleted.
Fix capitalization issue seen. invertedcolorWithOverriddenAlpha -> invertedColorWithOverriddenAlpha.

  • platform/graphics/Color.cpp:

(WebCore::Color::lightness const):
Inline implementation and add comment explaining it should be removed.

(WebCore::Color::luminance const):
Re-write to use the new WebCore::relativeLuminance that works for any color type
without conversion to sRGB.

(WebCore::Color::contrastRatio):
Add helper to call generic WebCore::contrastRatio that works on any color types
to avoid callers needing to do the unfolding themselves.

(WebCore::Color::isBlackColor):
(WebCore::Color::isWhiteColor):

  • platform/graphics/Color.h:

(WebCore::Color::isBlackColor): Deleted.
(WebCore::Color::isWhiteColor): Deleted.
Move these rare functions out of line to reduce the number of places in the header we are
calling callOnUnderlyingType(), which produces code linerally with the number of color spaces
supported. Calling it in the cpp files means we only expand it once for each function.

  • platform/graphics/ColorLuminance.h: Added.

(WebCore::relativeLuminance):
This is a generic version of the old luminance function that works for any color type
by converting to XYZ and taking the Y component. The old function required always
converting to sRGB which could be lossy.

(WebCore::contrastRatio):
Split out computation of contrastRatio based on relative luminace floats into its own
function so that if we have the relative luminance computed already, we don't have to
recompute it. Add version contrastRatio that works for any color type utilizing the
generic relativeLuminance function above.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::disabledTextColor const):

  • rendering/TextPaintStyle.cpp:

(WebCore::textColorIsLegibleAgainstBackgroundColor):
Update to use new Color::contrastRatio helper that handles all color types.

Source/WTF:

  • Scripts/Preferences/WebPreferencesExperimental.yaml:

Add new experimental preference for CSS Color 5 color-contrast()
which is off by default.

Tools:

  • TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):
Update luminance values to account for more accurate conversion to
XYZ now that we are usuing the actual matrix values from SRGBADescriptor
and not a truncated copy.

LayoutTests:

  • fast/css/parsing-color-contrast-expected.txt: Added.
  • fast/css/parsing-color-contrast.html: Added.

Add parsing and computed style computation tests for color-contast().

12:53 PM Changeset in webkit [273682] by Ruben Turcios
  • 27 edits
    2 moves
    2 deletes in branches/safari-611.1.21.2-branch

Revert "Cherry-pick r273590. rdar://problem/74881403"

This reverts commit 8714b941c814ac9e9771325be68853be779c4393.

12:51 PM Changeset in webkit [273681] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] Change LineBoxBuilder::m_inlineLevelBoxesNeedVerticalAlignment to m_useSimplifiedVerticalAlignment
​https://bugs.webkit.org/show_bug.cgi?id=222556

Reviewed by Antti Koivisto.

m_useSimplifiedVerticalAlignment is more descriptive. It's also in preparation for expanding the simplified vertical alignment coverage.

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::LineBoxBuilder):
(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

12:37 PM Changeset in webkit [273680] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Remove added element from Style::Update root set
​https://bugs.webkit.org/show_bug.cgi?id=222536

Reviewed by Zalan Bujtas.

With combined text and element updates an element might already exist in the root set when added.
Remove it from the root set to avoid updating it twice.

  • style/StyleUpdate.cpp:

(WebCore::Style::Update::addElement):
(WebCore::Style::Update::addText):

12:26 PM Changeset in webkit [273679] by Alan Coon
  • 3 edits
    2 adds in branches/safari-611.1.21.1-branch

Cherry-pick r273656. rdar://problem/74883377

REGRESSION(r272004): transform transition with delay doesn't behave correctly
​https://bugs.webkit.org/show_bug.cgi?id=222545
<rdar://problem/74865413>

Reviewed by Dean Jackson.

Source/WebCore:

To support accelerated animations of individual transform properties, we introduced the notion of
non-interpolating animations to apply the underlying value for a given property before applying
the actual animations for this property with additivity set to true.

These non-interpolating animations were meant to last between the time at which animations were
committed and the effective start of the first animation for that property, accounting for any
delay.

However, we neglected to handle the case where that first animation had a fill mode that would
make it fill backwards, such as CSS Transitions. In that situation, the animation would have
its first keyframe applied on top of the underlying value, effectively applying the underlying
value twice with additivity.

We now only add these non-interpolating animations if the first animation has a delay and does
not fill backwards.

Test: webanimations/transform-transition-with-delay-on-forced-layer-with-transform.html

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateAnimations):

LayoutTests:

Add a new test where an element with a non-identity transform starts a transform transition with a
long delay. Prior to this patch, this test failed because, while in the delay phase, the transition
would mean the underlying transform was applied twice: once by the non-interpolating animation
generated for the underlying "transform" value, and once by the first keyframe of the transition
since it fills backwards.

  • webanimations/transform-transition-with-delay-on-forced-layer-with-transform-expected.html: Added.
  • webanimations/transform-transition-with-delay-on-forced-layer-with-transform.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:24 PM Changeset in webkit [273678] by Alan Coon
  • 3 edits
    2 adds in branches/safari-611.1.21.3-branch

Cherry-pick r273656. rdar://problem/74883325

REGRESSION(r272004): transform transition with delay doesn't behave correctly
​https://bugs.webkit.org/show_bug.cgi?id=222545
<rdar://problem/74865413>

Reviewed by Dean Jackson.

Source/WebCore:

To support accelerated animations of individual transform properties, we introduced the notion of
non-interpolating animations to apply the underlying value for a given property before applying
the actual animations for this property with additivity set to true.

These non-interpolating animations were meant to last between the time at which animations were
committed and the effective start of the first animation for that property, accounting for any
delay.

However, we neglected to handle the case where that first animation had a fill mode that would
make it fill backwards, such as CSS Transitions. In that situation, the animation would have
its first keyframe applied on top of the underlying value, effectively applying the underlying
value twice with additivity.

We now only add these non-interpolating animations if the first animation has a delay and does
not fill backwards.

Test: webanimations/transform-transition-with-delay-on-forced-layer-with-transform.html

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateAnimations):

LayoutTests:

Add a new test where an element with a non-identity transform starts a transform transition with a
long delay. Prior to this patch, this test failed because, while in the delay phase, the transition
would mean the underlying transform was applied twice: once by the non-interpolating animation
generated for the underlying "transform" value, and once by the first keyframe of the transition
since it fills backwards.

  • webanimations/transform-transition-with-delay-on-forced-layer-with-transform-expected.html: Added.
  • webanimations/transform-transition-with-delay-on-forced-layer-with-transform.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:22 PM Changeset in webkit [273677] by Ruben Turcios
  • 3 edits
    2 adds in branches/safari-611.1.21.2-branch

Cherry-pick r273656. rdar://problem/74883395

REGRESSION(r272004): transform transition with delay doesn't behave correctly
​https://bugs.webkit.org/show_bug.cgi?id=222545
<rdar://problem/74865413>

Reviewed by Dean Jackson.

Source/WebCore:

To support accelerated animations of individual transform properties, we introduced the notion of
non-interpolating animations to apply the underlying value for a given property before applying
the actual animations for this property with additivity set to true.

These non-interpolating animations were meant to last between the time at which animations were
committed and the effective start of the first animation for that property, accounting for any
delay.

However, we neglected to handle the case where that first animation had a fill mode that would
make it fill backwards, such as CSS Transitions. In that situation, the animation would have
its first keyframe applied on top of the underlying value, effectively applying the underlying
value twice with additivity.

We now only add these non-interpolating animations if the first animation has a delay and does
not fill backwards.

Test: webanimations/transform-transition-with-delay-on-forced-layer-with-transform.html

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateAnimations):

LayoutTests:

Add a new test where an element with a non-identity transform starts a transform transition with a
long delay. Prior to this patch, this test failed because, while in the delay phase, the transition
would mean the underlying transform was applied twice: once by the non-interpolating animation
generated for the underlying "transform" value, and once by the first keyframe of the transition
since it fills backwards.

  • webanimations/transform-transition-with-delay-on-forced-layer-with-transform-expected.html: Added.
  • webanimations/transform-transition-with-delay-on-forced-layer-with-transform.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:22 PM Changeset in webkit [273676] by Alan Coon
  • 8 edits in branches/safari-611.1.21.3-branch/Source

Versioning.

WebKit-7611.1.21.3.1

12:19 PM Changeset in webkit [273675] by Peng Liu
  • 2 edits in trunk/Source/WebKitLegacy/mac

Rename the delegate property of WebAVPlayerView to webDelegate to fix a build failure with new SDKs
​https://bugs.webkit.org/show_bug.cgi?id=222560

Reviewed by Jer Noble.

We have to rename the delegate property of WebAVPlayerView because AVKit adds
a delegate property to AVPlayerView which will conflict with the one in WebKit.

  • WebView/WebVideoFullscreenController.mm:

(WebAVPlayerView_webDelegate):
(WebAVPlayerView_setWebDelegate):
(WebAVPlayerView_isFullScreen):
(WebAVPlayerView_enterFullScreen):
(WebAVPlayerView_exitFullScreen):
(allocWebAVPlayerViewInstance):
(-[WebVideoFullscreenController dealloc]):
(-[WebVideoFullscreenController windowDidLoad]):
(WebAVPlayerView_delegate): Deleted.
(WebAVPlayerView_setDelegate): Deleted.

12:08 PM Changeset in webkit [273674] by Alan Coon
  • 1 copy in branches/safari-611.1.21.3-branch

New branch.

12:02 PM Changeset in webkit [273673] by Ruben Turcios
  • 27 edits
    2 copies
    2 moves in branches/safari-611.1.21.2-branch

Cherry-pick r273590. rdar://problem/74881403

Non-cookie website data not deleted after 7 days of browser use without user interaction
​https://bugs.webkit.org/show_bug.cgi?id=222248
<rdar://problem/74612589>

Reviewed by Brent Fulgham and informally by Kate Cheney.

Source/WebKit:

Tests: http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago.html

http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp: (WebKit::ResourceLoadStatisticsDatabaseStore::updateOperatingDatesParameters):

Now sets two new member variables:

  • Optional<OperatingDate> m_longWindowOperatingDate
  • Optional<OperatingDate> m_shortWindowOperatingDate These are only set if the minimum number of operating days has passed. This function no longer sets m_leastRecentOperatingDate.

(WebKit::ResourceLoadStatisticsDatabaseStore::hasStatisticsExpired const):

Now checks against the two new member variables m_longWindowOperatingDate
and m_shortWindowOperatingDate. This fixes the bug.

(WebKit::ResourceLoadStatisticsDatabaseStore::insertExpiredStatisticForTesting):

Test infrastructure. Now takes the new parameter numberOfOperatingDaysPassed
with which layout tests can control the exact number of operating days
passed since user interaction.

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:

Added m_longWindowOperatingDate and m_shortWindowOperatingDate, and
removed m_leastRecentOperatingDate since it's no longer used.

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp: (WebKit::ResourceLoadStatisticsMemoryStore::insertExpiredStatisticForTesting):

Test infrastructure. The same changes as in the DB store.

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
  • NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::insertExpiredStatisticForTesting):

Test infrastructure.

  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
  • NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::insertExpiredStatisticForTesting):

Test infrastructure.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreSetStatisticsExpiredStatistic):

Test infrastructure.

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:
  • UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::insertExpiredStatisticForTesting):

Test infrastructure.

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::insertExpiredStatisticForTesting):

Test infrastructure.

  • UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

A new numberOfOperatingDaysPassed parameter was added to
testRunner.setStatisticsExpiredStatistic() to control the exact
number of operating days passed since user interaction.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setStatisticsExpiredStatistic):
  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::setStatisticsExpiredStatistic):
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Existing test cases now make use of the new numberOfOperatingDaysPassed
parameter to testRunner.setStatisticsExpiredStatistic() to control the exact
number of operating days passed since user interaction.
A new test case makes sure website data is not deleted below the threshold.

  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago-expected.txt: Added.
  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago.html: Added.

Sets numberOfOperatingDaysPassed to 6.

  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago-expected.txt: Renamed from LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-statistics-with-no-user-interaction-expected.txt.
  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html: Renamed from LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-statistics-with-no-user-interaction.html.

Sets numberOfOperatingDaysPassed to 7.

  • http/tests/resourceLoadStatistics/operating-dates-all-website-data-removed.html:

Sets numberOfOperatingDaysPassed to 30.

  • platform/wk2/TestExpectations:

Updated existing expectation with new file name.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:57 AM Changeset in webkit [273672] by Said Abou-Hallawa
  • 4 edits in trunk

[GPU Process] Some DisplayList items may not be replayed back before calling getImageData()
​https://bugs.webkit.org/show_bug.cgi?id=222343

Reviewed by Tim Horton.

Source/WebKit:

Make sure all the pending DisplayList items are pushed to the GPUP and
submitted to RemoteImageBuffer before calling the asynchronous method
getImageData().

  • WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

LayoutTests:

  • gpu-process/TestExpectations:
11:55 AM Changeset in webkit [273671] by Alan Coon
  • 27 edits
    2 copies
    2 moves in branches/safari-611.1.21.0-branch

Cherry-pick r273590. rdar://problem/74881366

Non-cookie website data not deleted after 7 days of browser use without user interaction
​https://bugs.webkit.org/show_bug.cgi?id=222248
<rdar://problem/74612589>

Reviewed by Brent Fulgham and informally by Kate Cheney.

Source/WebKit:

Tests: http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago.html

http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp: (WebKit::ResourceLoadStatisticsDatabaseStore::updateOperatingDatesParameters):

Now sets two new member variables:

  • Optional<OperatingDate> m_longWindowOperatingDate
  • Optional<OperatingDate> m_shortWindowOperatingDate These are only set if the minimum number of operating days has passed. This function no longer sets m_leastRecentOperatingDate.

(WebKit::ResourceLoadStatisticsDatabaseStore::hasStatisticsExpired const):

Now checks against the two new member variables m_longWindowOperatingDate
and m_shortWindowOperatingDate. This fixes the bug.

(WebKit::ResourceLoadStatisticsDatabaseStore::insertExpiredStatisticForTesting):

Test infrastructure. Now takes the new parameter numberOfOperatingDaysPassed
with which layout tests can control the exact number of operating days
passed since user interaction.

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:

Added m_longWindowOperatingDate and m_shortWindowOperatingDate, and
removed m_leastRecentOperatingDate since it's no longer used.

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp: (WebKit::ResourceLoadStatisticsMemoryStore::insertExpiredStatisticForTesting):

Test infrastructure. The same changes as in the DB store.

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
  • NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::insertExpiredStatisticForTesting):

Test infrastructure.

  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
  • NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::insertExpiredStatisticForTesting):

Test infrastructure.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreSetStatisticsExpiredStatistic):

Test infrastructure.

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:
  • UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::insertExpiredStatisticForTesting):

Test infrastructure.

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::insertExpiredStatisticForTesting):

Test infrastructure.

  • UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

A new numberOfOperatingDaysPassed parameter was added to
testRunner.setStatisticsExpiredStatistic() to control the exact
number of operating days passed since user interaction.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setStatisticsExpiredStatistic):
  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::setStatisticsExpiredStatistic):
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Existing test cases now make use of the new numberOfOperatingDaysPassed
parameter to testRunner.setStatisticsExpiredStatistic() to control the exact
number of operating days passed since user interaction.
A new test case makes sure website data is not deleted below the threshold.

  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago-expected.txt: Added.
  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago.html: Added.

Sets numberOfOperatingDaysPassed to 6.

  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago-expected.txt: Renamed from LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-statistics-with-no-user-interaction-expected.txt.
  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html: Renamed from LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-statistics-with-no-user-interaction.html.

Sets numberOfOperatingDaysPassed to 7.

  • http/tests/resourceLoadStatistics/operating-dates-all-website-data-removed.html:

Sets numberOfOperatingDaysPassed to 30.

  • platform/wk2/TestExpectations:

Updated existing expectation with new file name.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:50 AM Changeset in webkit [273670] by Antti Koivisto
  • 3 edits in trunk/Source/WebKit

Use PriorityQueue in NetworkCache::Storage
​https://bugs.webkit.org/show_bug.cgi?id=222555

Reviewed by Chris Dumez.

Replace Vector<Deque<>> with a more flexible, simpler to use data structure.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::ReadOperation::ReadOperation):
(WebKit::NetworkCache::Storage::isHigherPriority):
(WebKit::NetworkCache::Storage::cancelAllReadOperations):
(WebKit::NetworkCache::Storage::dispatchPendingReadOperations):
(WebKit::NetworkCache::Storage::retrieve):

  • NetworkProcess/cache/NetworkCacheStorage.h:
11:49 AM Changeset in webkit [273669] by Fujii Hironori
  • 2 edits in trunk/Source/WebKit

EventDispatcher::wheelEvent is accessing m_scrollingTrees without locking m_scrollingTreesMutex since r271235
​https://bugs.webkit.org/show_bug.cgi?id=222529

Reviewed by Carlos Garcia Campos.

r271235 added a code to access m_scrollingTrees, but it didn't
lock m_scrollingTreesMutex. The code can be removed by moving it
into the above lambda expression.

EventDispatcher::wheelEvent was using a local lambda expression.
However the return value wasn't used. And, MSVC can't compile the
lambda expression because it has a bug that 'this' can't be used
in lambda expressions. Converted the lambda expression to a
do-while statement.

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

11:47 AM Changeset in webkit [273668] by Alan Coon
  • 27 edits
    2 copies
    2 moves in branches/safari-611.1.21.1-branch

Cherry-pick r273590. rdar://problem/74881385

Non-cookie website data not deleted after 7 days of browser use without user interaction
​https://bugs.webkit.org/show_bug.cgi?id=222248
<rdar://problem/74612589>

Reviewed by Brent Fulgham and informally by Kate Cheney.

Source/WebKit:

Tests: http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago.html

http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp: (WebKit::ResourceLoadStatisticsDatabaseStore::updateOperatingDatesParameters):

Now sets two new member variables:

  • Optional<OperatingDate> m_longWindowOperatingDate
  • Optional<OperatingDate> m_shortWindowOperatingDate These are only set if the minimum number of operating days has passed. This function no longer sets m_leastRecentOperatingDate.

(WebKit::ResourceLoadStatisticsDatabaseStore::hasStatisticsExpired const):

Now checks against the two new member variables m_longWindowOperatingDate
and m_shortWindowOperatingDate. This fixes the bug.

(WebKit::ResourceLoadStatisticsDatabaseStore::insertExpiredStatisticForTesting):

Test infrastructure. Now takes the new parameter numberOfOperatingDaysPassed
with which layout tests can control the exact number of operating days
passed since user interaction.

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:

Added m_longWindowOperatingDate and m_shortWindowOperatingDate, and
removed m_leastRecentOperatingDate since it's no longer used.

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp: (WebKit::ResourceLoadStatisticsMemoryStore::insertExpiredStatisticForTesting):

Test infrastructure. The same changes as in the DB store.

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
  • NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::insertExpiredStatisticForTesting):

Test infrastructure.

  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
  • NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::insertExpiredStatisticForTesting):

Test infrastructure.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreSetStatisticsExpiredStatistic):

Test infrastructure.

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:
  • UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::insertExpiredStatisticForTesting):

Test infrastructure.

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::insertExpiredStatisticForTesting):

Test infrastructure.

  • UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

A new numberOfOperatingDaysPassed parameter was added to
testRunner.setStatisticsExpiredStatistic() to control the exact
number of operating days passed since user interaction.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setStatisticsExpiredStatistic):
  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::setStatisticsExpiredStatistic):
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Existing test cases now make use of the new numberOfOperatingDaysPassed
parameter to testRunner.setStatisticsExpiredStatistic() to control the exact
number of operating days passed since user interaction.
A new test case makes sure website data is not deleted below the threshold.

  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago-expected.txt: Added.
  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago.html: Added.

Sets numberOfOperatingDaysPassed to 6.

  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago-expected.txt: Renamed from LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-statistics-with-no-user-interaction-expected.txt.
  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html: Renamed from LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-statistics-with-no-user-interaction.html.

Sets numberOfOperatingDaysPassed to 7.

  • http/tests/resourceLoadStatistics/operating-dates-all-website-data-removed.html:

Sets numberOfOperatingDaysPassed to 30.

  • platform/wk2/TestExpectations:

Updated existing expectation with new file name.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:47 AM Changeset in webkit [273667] by Alan Coon
  • 4 edits in branches/safari-611.1.21.1-branch

Cherry-pick r273583. rdar://problem/74881429

Add AXTextMarkerRangeForNSRange attribute so that Mac clients can access this functionality.
​https://bugs.webkit.org/show_bug.cgi?id=222477
Source/WebCore:

<rdar://problem/74793445>

Reviewed by Chris Fleizach.

This is a follow up to: ​https://bugs.webkit.org/show_bug.cgi?id=222154.
As Chris Fleizach pointed out in the above review, it is necessary to
add a handler in accessibilityAttributeValue:forParameter: for a new AX
attribute in order for clients to access this functionality.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): (-[WebAccessibilityObjectWrapper textMarkerRangeForNSRange:]): Deleted.

Tools:

Reviewed by Chris Fleizach.

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::textMarkerRangeForRange):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:47 AM Changeset in webkit [273666] by Alan Coon
  • 15 edits
    2 adds in branches/safari-611.1.21.1-branch

Cherry-pick r273227. rdar://problem/74880937

Add [WebAccessibilityObjectWrapper textMarkerRangeForNSRange] to allow clients to efficiently get a TextMarkerRange from an NSRange.
​https://bugs.webkit.org/show_bug.cgi?id=222154

Reviewed by Chris Fleizach and Darin Adler.

Source/WebCore:

Test: accessibility/mac/textmarker-range-for-range.html

Clients like VoiceOver often need the ability to convert a text range
into an accessibility TextMarkerRange.
This patch adds [WebAccessibilityObjectWrapper textMarkerRangeForNSRange]
to allow clients to efficiently perform this conversion.
This is the Mac implementation, iOS implementation is pending.

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::allowsTextRanges const):
  • accessibility/AccessibilityObjectInterface.h:
  • accessibility/isolatedtree/AXIsolatedObject.h:
  • accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm: (WebCore::AXIsolatedObject::textMarkerRangeForNSRange const):
  • accessibility/mac/AccessibilityObjectMac.mm: (WebCore::AccessibilityObject::textMarkerRangeForNSRange const):
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper textMarkerRangeForNSRange:]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
  • editing/Editing.cpp: (WebCore::visiblePositionForIndexUsingCharacterIterator): Only advance the CharacterIterator if not atEnd yet.

Tools:

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::textMarkerRangeForRange):
  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::textMarkerRangeForRange):

LayoutTests:

  • accessibility/mac/textmarker-range-for-range-expected.txt: Added.
  • accessibility/mac/textmarker-range-for-range.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:40 AM Changeset in webkit [273665] by Alan Coon
  • 8 edits in branches/safari-611.1.21.0-branch/Source

Versioning.

WebKit-7611.1.21.0.1

11:40 AM Changeset in webkit [273664] by Alan Coon
  • 8 edits in branches/safari-611.1.21.2-branch/Source

Versioning.

WebKit-7611.1.21.2.1

11:40 AM Changeset in webkit [273663] by Alan Coon
  • 8 edits in branches/safari-611.1.21.1-branch/Source

Versioning.

WebKit-7611.1.21.1.1

11:29 AM Changeset in webkit [273662] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[JSC] WebAssembly: make Wasm::Signature 32bit friendly
​https://bugs.webkit.org/show_bug.cgi?id=222543

Patch by Xan Lopez <Xan Lopez> on 2021-03-01
Reviewed by Yusuke Suzuki.

The Wasm code uses the address of a Signature object as its
index. To make this work in 32bit just change Wasm::SignatureIndex
to be a uintptr_t instead of uint64_t. Also, remove some
unnecessary includes while we are at it.

  • wasm/WasmModule.h:
  • wasm/WasmSignature.h:
  • wasm/js/JSWebAssemblyModule.h:
11:21 AM Changeset in webkit [273661] by ysuzuki@apple.com
  • 49 edits in trunk

[JSC] Throw TypeError when getFunctionRealm hits revoked Proxy
​https://bugs.webkit.org/show_bug.cgi?id=222523

Reviewed by Alexey Shvayka.

JSTests:

  • test262/expectations.yaml:

Source/JavaScriptCore:

This patch throws TypeError when getFunctionRealm encounters revoked Proxy. However,
this makes derived structure creation code difficult to be written inlinely.
The fast path of derived structure creation must be inlined since this is critical
path of every builtin constructors.

So, this patch introduces JSC_GET_DERIVED_STRUCTURE macro which streamlines the derived
structure creation code while keeping the fast path inlined. And it inserts appropriate
error checks after this new getFunctionRealm call.

Then, we appropriately use getFunctionRealm in op_create_this implementation.

  • dfg/DFGOperations.cpp:

(JSC::DFG::JSC_DEFINE_JIT_OPERATION):

  • runtime/AggregateErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/BooleanConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/CommonSlowPaths.cpp:

(JSC::JSC_DEFINE_COMMON_SLOW_PATH):

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • runtime/ErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/FinalizationRegistryConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/InternalFunction.cpp:

(JSC::getFunctionRealm):

  • runtime/InternalFunction.h:
  • runtime/IntlCollatorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/IntlDisplayNamesConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/IntlListFormatConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/IntlLocaleConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/IntlNumberFormatConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/IntlPluralRulesConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/IntlRelativeTimeFormatConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/IntlSegmenterConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/JSArrayBufferConstructor.cpp:

(JSC::JSGenericArrayBufferConstructor<sharingMode>::constructImpl):

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructCustomArrayBufferIfNeeded):
(JSC::constructGenericTypedArrayViewImpl):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::errorStructureWithErrorType const):
(JSC::JSGlobalObject::arrayBufferStructureWithSharingMode const):
(JSC::JSGlobalObject::typedArrayStructureWithTypedArrayType const):

  • runtime/JSGlobalObjectInlines.h:

(JSC::JSGlobalObject::arrayStructureForIndexingTypeDuringAllocation const):

  • runtime/MapConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor<errorType>::constructImpl):

  • runtime/NumberConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/ObjectConstructor.cpp:

(JSC::constructObjectWithNewTarget):

  • runtime/ProxyConstructor.cpp:

(JSC::ProxyConstructor::create):
(JSC::ProxyConstructor::finishCreation):

  • runtime/ProxyConstructor.h:
  • runtime/RegExpConstructor.cpp:

(JSC::getRegExpStructure):

  • runtime/SetConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/StringConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/WeakMapConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/WeakObjectRefConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/WeakSetConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyCompileErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyGlobalConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyLinkErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyMemoryConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::WebAssemblyModuleConstructor::createModule):

  • wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • wasm/js/WebAssemblyTableConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

Source/WebCore:

  • bindings/js/JSDOMWrapperCache.h:

(WebCore::setSubclassStructureIfNeeded):

  • bindings/js/JSHTMLElementCustom.cpp:

(WebCore::constructJSHTMLElement):

11:18 AM Changeset in webkit [273660] by Alan Coon
  • 1 copy in branches/safari-611.1.21.2-branch

New branch.

11:18 AM Changeset in webkit [273659] by Alan Coon
  • 1 copy in branches/safari-611.1.21.1-branch

New branch.

11:17 AM Changeset in webkit [273658] by Alan Coon
  • 1 copy in branches/safari-611.1.21.0-branch

New branch.

11:15 AM Changeset in webkit [273657] by Simon Fraser
  • 35 edits in trunk/Source

Remove ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING which is always true for macOS
​https://bugs.webkit.org/show_bug.cgi?id=222459

Reviewed by Sam Weinig.

ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING is always defined for PLATFORM(MAC), so remove it,
replacing with PLATFORM(MAC) in a few places. In order to reduce the number PLATFORM(MAC), define
HAVE(CVDISPLAYLINK) and use it in WK2 code that relates to DisplayLinks.

Source/WebCore:

  • platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::ensurePlatformContext):

  • platform/graphics/opengl/GraphicsContextGLOpenGLManager.cpp:

(WebCore::GraphicsContextGLOpenGLManager::addContext):
(WebCore::GraphicsContextGLOpenGLManager::removeContext):

  • platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::currentStateOfModifierKeys):

  • platform/mac/PlatformScreenMac.mm:

(WebCore::gpuIDForDisplay):

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]):
(-[WebScrollbarPartAnimation startAnimation]):
(-[WebScrollbarPartAnimation setCurrentProgress:]):
(-[WebScrollbarPartAnimation stopAnimation]):
(-[WebScrollbarPartAnimation setCurrentProgress:setCurrentProgress:]): Deleted.

Source/WebKit:

  • Platform/cocoa/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createForExternalHostingProcess):

  • Shared/mac/HangDetectionDisablerMac.mm:

(WebKit::setClientsMayIgnoreEvents):

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):

  • UIProcess/WebPageProxy.cpp:

(WebKit::ScrollingObserver::singleton):
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::updateCurrentModifierState):

  • UIProcess/WebProcessPool.cpp:

(WebKit::displayReconfigurationCallBack):
(WebKit::WebProcessPool::sendDisplayConfigurationChangedMessageForTesting):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::processWillShutDown):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • UIProcess/mac/DisplayLink.cpp:
  • UIProcess/mac/DisplayLink.h:
  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::stopDisplayLink):

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::initialize):

  • WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):

  • WebProcess/WebPage/DrawingArea.cpp:
  • WebProcess/WebPage/EventDispatcher.cpp:
  • WebProcess/WebPage/EventDispatcher.h:
  • WebProcess/WebPage/EventDispatcher.messages.in:
  • WebProcess/WebPage/mac/DrawingAreaMac.cpp:

(WebKit::DrawingArea::createDisplayRefreshMonitor):

  • WebProcess/WebProcess.cpp:
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformInitializeProcess):

Source/WTF:

  • wtf/PlatformEnable.h:
  • wtf/PlatformEnableCocoa.h:
  • wtf/PlatformHave.h:
10:47 AM Changeset in webkit [273656] by graouts@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r272004): transform transition with delay doesn't behave correctly
​https://bugs.webkit.org/show_bug.cgi?id=222545
<rdar://problem/74865413>

Reviewed by Dean Jackson.

Source/WebCore:

To support accelerated animations of individual transform properties, we introduced the notion of
non-interpolating animations to apply the underlying value for a given property before applying
the actual animations for this property with additivity set to true.

These non-interpolating animations were meant to last between the time at which animations were
committed and the effective start of the first animation for that property, accounting for any
delay.

However, we neglected to handle the case where that first animation had a fill mode that would
make it fill backwards, such as CSS Transitions. In that situation, the animation would have
its first keyframe applied on top of the underlying value, effectively applying the underlying
value twice with additivity.

We now only add these non-interpolating animations if the first animation has a delay and does
not fill backwards.

Test: webanimations/transform-transition-with-delay-on-forced-layer-with-transform.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateAnimations):

LayoutTests:

Add a new test where an element with a non-identity transform starts a transform transition with a
long delay. Prior to this patch, this test failed because, while in the delay phase, the transition
would mean the underlying transform was applied twice: once by the non-interpolating animation
generated for the underlying "transform" value, and once by the first keyframe of the transition
since it fills backwards.

  • webanimations/transform-transition-with-delay-on-forced-layer-with-transform-expected.html: Added.
  • webanimations/transform-transition-with-delay-on-forced-layer-with-transform.html: Added.
10:21 AM Changeset in webkit [273655] by Chris Dumez
  • 14 edits in trunk/Source

Set ownership of IOSurfaces from the GPUProcess instead of the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=222391
Source/WebCore:

<rdar://problem/74748353>

Reviewed by Simon Fraser.

Replace use of IOSurfaceSetOwnership() SPI with IOSurfaceSetOwnershipIdentity().
Both do the same thing but IOSurfaceSetOwnershipIdentity() only requires an identity token
for the new owner (instead of a control port). As a result, IOSurfaceSetOwnershipIdentity()
requires a lot less priviledges and can now be used directly in the GPUProcess instead of
the WebProcess.

  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::setOwnershipIdentity):

Source/WebCore/PAL:

<rdar://74748353>

Reviewed by Simon Fraser.

Add declaration for new IOSurfaceSetOwnershipIdentity() SPI, for the open source
SDK.

  • pal/spi/cocoa/IOSurfaceSPI.h:

Source/WebKit:

<rdar://problem/74748353>

Reviewed by Simon Fraser.

Replace use of IOSurfaceSetOwnership() SPI with IOSurfaceSetOwnershipIdentity().
Both do the same thing but IOSurfaceSetOwnershipIdentity() only requires an identity token
for the new owner (instead of a control port). As a result, IOSurfaceSetOwnershipIdentity()
requires a lot less priviledges and can now be used directly in the GPUProcess instead of
the WebProcess.

  • GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:

(WebKit::RemoteGraphicsContextGLCocoa::prepareForDisplay):

  • GPUProcess/graphics/RemoteImageBuffer.h:

(WebKit::RemoteImageBuffer::setProcessOwnership):

  • GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::createImageBuffer):

  • WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:

(WebKit::RemoteGraphicsContextGLProxy::prepareForDisplay):

  • WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp:

(WebKit::ImageBufferShareableMappedIOSurfaceBackend::create):
(WebKit::ImageBufferShareableMappedIOSurfaceBackend::setProcessOwnership):

  • WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.h:

Source/WTF:

<rdar://74748353>

Reviewed by Simon Fraser.

Add HAVE_IOSURFACE_SET_OWNERSHIP_IDENTITY feature flag to protect uses of the
new IOSurfaceSetOwnershipIdentity() SPI.

  • wtf/PlatformHave.h:
9:36 AM Changeset in webkit [273654] by Megan Gardner
  • 4 edits in trunk

Restoring App Highlight crashes if no range is found.
​https://bugs.webkit.org/show_bug.cgi?id=222524

Reviewed by Tim Horton.

Source/WebCore:

Test: TestWebKitAPI.AppHighlights.AppHighlightRestoreFailure

  • Modules/highlight/AppHighlightStorage.cpp:

(WebCore::AppHighlightStorage::restoreAppHighlight):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm:

(TestWebKitAPI::TEST):

9:29 AM Changeset in webkit [273653] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[Python-3] Change shebang in runUnittests.py
​https://bugs.webkit.org/show_bug.cgi?id=222554

Reviewed by Jonathan Bedard.

  • CISupport/runUnittests.py:
8:41 AM Changeset in webkit [273652] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews] Use logname instead of deprecated logfile in PrintConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=222378

Reviewed by Jonathan Bedard.

  • CISupport/ews-build/steps.py:

(PrintConfiguration.run):

8:38 AM Changeset in webkit [273651] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Teach prepare-ChangeLog to recognize Swift structs/enums/protocols/extensions
​https://bugs.webkit.org/show_bug.cgi?id=222551

It formerly only knew how to recognize classes.

Patch by Adam Roben <Adam Roben> on 2021-03-01
Reviewed by Jonathan Bedard.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_swift): Replaced "class" with "type" in
variable names to make them more general. Generalized the pattern used
to find class declarations to find struct/enum/protocol/extension
declarations as well.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt:

Added new ranges to the results.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift:

(MyStruct.structFunction(argument:)):
(MyEnum.enumFunction(argument:)):
(MyProtocol.protocolFunction(argument:)):
(ExtendedType.extensionFunction(argument:)):
Added these new types/functions (and look, they got parsed!).

7:34 AM Changeset in webkit [273650] by Chris Lord
  • 7 edits in trunk/Source/WebCore

CSSFontFace should not need its m_fontSelector data member
​https://bugs.webkit.org/show_bug.cgi?id=208351
<rdar://problem/74346302>

Reviewed by Darin Adler.

Move the m_fontSelector member of CSSFontFace onto CSSFontFaceSource,
the only place where it's actually required.

No new tests because there is no behavior change.

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::appendSources):
(WebCore::CSSFontFace::create):
(WebCore::CSSFontFace::document):
(WebCore::CSSFontFace::opportunisticallyStartFontDataURLLoading):
(WebCore::CSSFontFace::pump):
(WebCore::CSSFontFace::font):

  • css/CSSFontFace.h:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::opportunisticallyStartFontDataURLLoading):
(WebCore::CSSFontFaceSource::load):

  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::opportunisticallyStartFontDataURLLoading):

  • css/FontFace.cpp:

(WebCore::populateFontFaceWithArrayBuffer):

7:00 AM Changeset in webkit [273649] by Alexey Shvayka
  • 4 edits in trunk/Source/JavaScriptCore

BytecodeGenerator::fuseCompareAndJump() fails for some language constructs
​https://bugs.webkit.org/show_bug.cgi?id=221927

Reviewed by Yusuke Suzuki.

For BytecodeGenerator::fuseCompareAndJump() to merge two ops into one, condition's dst
register should not be referenced from elsewhere. This change tracks down and eliminates
all such cases, which reduces bytecode size for a few language constructs:

-1 per every case of a switch;
-2 per generator function, -2 per every yield / yield*;
-2 per class extends;
-2 per finally, -1 per every break / continue / return inside;
-3 per Function.prototype.apply() with ...spread as a single argument.

Instead of mixing RefPtr with raw C++ pointers, single-line branches were preferred.
To keep them cleaner, this patch introduces emitLoad() override for JSGenerator::ResumeMode
enum, and tweaks existing override for CompletionType.

A few drive-by improvements:

  • to enable future optimizations, replaces emitBinaryOp() with emitEqualityOp() for OpEq / OpStricteq (adds an assert), and vice-versa for other comparison ops;
  • removes OperandTypes for comparison ops as it was ignored (let's re-introduce them consistently once supported);
  • inlines too specific BytecodeGenerator::emitJumpIf();
  • replaces eq with stricteq in ApplyFunctionCallDotNode.

No behavior change, no callee registers count grow.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitYield):
(JSC::BytecodeGenerator::emitDelegateYield):
(JSC::BytecodeGenerator::emitFinallyCompletion):
(JSC::BytecodeGenerator::emitJumpIf): Deleted.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitEqualityOp):
(JSC::BytecodeGenerator::emitLoad):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::CaseBlockNode::emitBytecodeForBlock):
(JSC::FunctionNode::emitBytecode):
(JSC::ClassExprNode::emitBytecode):

6:22 AM Changeset in webkit [273648] by Chris Gambrell
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

[LayoutTests] Convert http/tests/fetch convert PHP to Python
​https://bugs.webkit.org/show_bug.cgi?id=222367
<rdar://problem/74702641>

Reviewed by Jonathan Bedard.

  • http/tests/fetch/caching-with-different-options.html:
  • http/tests/fetch/redirectmode-and-preload-expected.txt:
  • http/tests/fetch/redirectmode-and-preload.html:
  • http/tests/fetch/resources/redirect-with-cache.php: Removed.
  • http/tests/fetch/resources/redirect-with-cache.py: Added.
6:22 AM Changeset in webkit [273647] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Change order in RenderBlock::availableLogicalHeightForPercentageComputation
​https://bugs.webkit.org/show_bug.cgi?id=222468

Patch by Rob Buis <​rbuis@igalia.com> on 2021-03-01
Reviewed by Manuel Rego Casasnovas.

Change order in RenderBlock::availableLogicalHeightForPercentageComputation in
order to remove one check.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const):

5:27 AM Changeset in webkit [273646] by commit-queue@webkit.org
  • 8 edits
    1 copy in trunk/Source/WebKit

Timeout calculations are error-prone for compound IPC operations
​https://bugs.webkit.org/show_bug.cgi?id=222305

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-03-01
Reviewed by Geoffrey Garen.

Add Timeout class to hold the timeout value in blocking functions
of IPC::.
This makes it possible to forward absolute points of time as the timeout
value, as well as preserving the ability to pass points of time relative
to the invocation.

Call the concept Timeout instead of TimeOut since word 'timeout' is an
English word and preferable when used as a noun according to ell stackoverflow.

No new tests, a refactor.

  • Platform/IPC/Connection.cpp:

(IPC::Connection::sendMessage):
(IPC::Connection::waitForMessage):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::waitForSyncReply):

  • Platform/IPC/Connection.h:

(IPC::Connection::sendSync):
(IPC::Connection::waitForAndDispatchImmediately):
(IPC::Connection::waitForAsyncCallbackAndDispatchImmediately):

  • Platform/IPC/IPCSemaphore.h:
  • Platform/IPC/MessageSender.h:

(IPC::MessageSender::sendSync):

  • Platform/IPC/StreamClientConnection.h:

(IPC::StreamClientConnection::send):
(IPC::StreamClientConnection::sendSync):
(IPC::StreamClientConnection::trySendDestinationIDIfNeeded):
(IPC::StreamClientConnection::tryAcquire):
Here are few examples of compound use-case.

  • Platform/IPC/Timeout.h: Copied from Source/WebKit/Platform/IPC/IPCSemaphore.h.

(IPC::Timeout::Timeout):
(IPC::Timeout::infinity):
(IPC::Timeout::operator Seconds const):
(IPC::Timeout::hasPassed const):

  • Platform/IPC/darwin/IPCSemaphoreDarwin.cpp:

(IPC::Semaphore::waitFor):

  • UIProcess/AuxiliaryProcessProxy.h:

(WebKit::AuxiliaryProcessProxy::sendSync):

2:44 AM Changeset in webkit [273645] by youenn@apple.com
  • 2 edits in trunk/LayoutTests

[GPUP] Fix WebRTC layout test failures with GPU Process enabled
​https://bugs.webkit.org/show_bug.cgi?id=222505
<rdar://problem/74814573>

Unreviewed.

  • gpu-process/TestExpectations:

Removed no longer valid expectations.

2:06 AM Changeset in webkit [273644] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[GStreamer][Playbin3] Stream collection handling fixes
​https://bugs.webkit.org/show_bug.cgi?id=222322

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-03-01
Reviewed by Xabier Rodriguez-Calvar.

The track orphaning trying to avoid un-necessary track addition/removals was making the
whole thing inconsistent with the final stream collection. Also stream-collection messages
don't need to be handled from a synchronous GstBus handler, this should be needed for
need-context messages only, so the corresponding code has been refactored.

This patch also includes changes and cleanups for the mediastreamsrc element, needed after
the stream collection handling fixes. Most notably the element now keeps an internal list of
tracks, in addition to observing the MediaStreamPrivate for topology changes. Also it emits
a new stream collection whenever a new source pad has been added.

No new tests, but this patch fixes flakyness of http/tests/media/hls/hls-audio-tracks.html
when the pipeline is driven by playbin3.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::updateTracks):
(WebCore::MediaPlayerPrivateGStreamer::setPipeline):
(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):
(WebCore::MediaPlayerPrivateGStreamer::handleNeedContextMessage):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::handleNeedContextSyncMessage):

  • platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

(stopObservingTracks):
(webkitMediaStreamSrcDispose):
(webkitMediaStreamSrcAddPad):
(ProbeData::ProbeData):
(webkitMediaStreamSrcPadProbeCb):
(webkitMediaStreamSrcSetupSrc):
(webkitMediaStreamSrcPostStreamCollection):
(webkitMediaStreamSrcAddTrack):
(webkitMediaStreamSrcSetStream):
(webkitMediaStreamSrcTrackEnded):

1:42 AM Changeset in webkit [273643] by berto@igalia.com
  • 2 edits in trunk/Source/WebKit

[GTK] Fails to build in i386: static assertion failed: divisor must be a power of two
​https://bugs.webkit.org/show_bug.cgi?id=222480

Reviewed by Carlos Garcia Campos.

  • Platform/IPC/StreamConnectionBuffer.h:

(IPC::StreamConnectionBuffer::headerSize):

Feb 28, 2021:

6:26 PM Changeset in webkit [273642] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Consider removing iOS only CSS property alias -webkit-hyphenate-locale introduced in r80288
​https://bugs.webkit.org/show_bug.cgi?id=222507

Reviewed by Anders Carlsson.

It's been about 10 years, let's try removing the iOS only CSS property alias for
-webkit-locale, -webkit-hyphenate-locale, and see what happens.

  • css/CSSStyleDeclaration.cpp:
  • css/parser/CSSPropertyParser.cpp:

(WebCore::cssPropertyID):
(WebCore::cssPropertyNameIOSAliasing): Deleted.

  • css/parser/CSSPropertyParser.h:
4:47 PM Changeset in webkit [273641] by ysuzuki@apple.com
  • 4 edits in trunk

[JSC] Add gc and clearKeptObjects to $262
​https://bugs.webkit.org/show_bug.cgi?id=222527

Reviewed by Ross Kirsling.

JSTests:

  • test262/config.yaml:

Source/JavaScriptCore:

Add $262.gc and $262.clearKeptObjects functions. They are required for test262 host-gc-required.
Since all the tests using "host-gc-required" are currently also marked with cleanupSome, we are currently not running them.
But if some more tests are landed in test262 with "host-gc-required", we will run them with these functions.

  • jsc.cpp:

(JSC_DEFINE_HOST_FUNCTION):

4:13 PM Changeset in webkit [273640] by Alan Bujtas
  • 11 edits in trunk/Source/WebCore

[LFC][IFC] Content left offset means just content left
​https://bugs.webkit.org/show_bug.cgi?id=222522

Reviewed by Antti Koivisto.

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::build):

  • layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::m_contentLogicalWidth):

  • layout/inlineformatting/InlineLineBox.h:
  • layout/inlineformatting/InlineLineGeometry.h:

(WebCore::Layout::InlineLineGeometry::contentLogicalLeft const):
(WebCore::Layout::InlineLineGeometry::InlineLineGeometry):
(WebCore::Layout::InlineLineGeometry::contentLogicalLeftOffset const): Deleted.

  • layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):

  • layout/integration/LayoutIntegrationLine.h:

(WebCore::LayoutIntegration::Line::Line):
(WebCore::LayoutIntegration::Line::contentLeft const):
(WebCore::LayoutIntegration::Line::contentLeftOffset const): Deleted.

  • layout/integration/LayoutIntegrationLineIteratorModernPath.h:

(WebCore::LayoutIntegration::LineIteratorModernPath::contentLogicalLeft const):

  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):

  • layout/integration/LayoutIntegrationPagination.cpp:

(WebCore::LayoutIntegration::makeAdjustedContent):

  • layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::createTextRun const):

12:56 PM Changeset in webkit [273639] by Darin Adler
  • 7 edits in trunk/Source

[iOS] Reduce use of retain/release in WAKWindow and remove unneeded methods from that class
​https://bugs.webkit.org/show_bug.cgi?id=222330

Reviewed by Chris Dumez.

Source/WebCore:

  • platform/ios/LegacyTileCache.h: Use pragma once, remove unneeded includes,

tweak coding style a bit to match WebKit standard. Removed hasPendingDraw.
added WEBCORE_EXPORT to setTileBordersVisible and setTilePaintCountersVisible
so they can be used in WebKitLegacy.

  • platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::hasPendingDraw const): Deleted.

  • platform/ios/wak/WAKWindow.h: Use pragma once, remove unneeded includes,

tweak coding style a bit to match WebKit standard. Removed hasPendingDraw,
setTileControllerShouldUseLowScaleTiles, setTileBordersVisible,
setTilePaintCountsVisible, setAcceleratedDrawingEnabled, freezeVisibleRect,
and unfreezeVisibleRect.

  • platform/ios/wak/WAKWindow.mm: Removed "using namespace WebCore".

Removed unused _WAKKeyWindow global. Converted currentEvent and
gOrientationProvider globals to NeverDestroyed<RetainPtr<>>.
(orientationProvider): Added
(currentEvent): Added.
(-[WAKWindow isKeyWindow]): Remove dead code; this method already always
returns YES.
(-[WAKWindow makeKeyWindow]): Remove dead code. This method wrote to a
global that was never read anywhere.
(-[WAKWindow sendEventSynchronously:]): Use the currentEvent function
and take advantage of the fact that it's a RetainPtr so we don't need a
a local variable named currentEventProtector.
(-[WAKWindow hasPendingDraw]): Deleted. No callers depend on this.
(-[WAKWindow willRotate]): Set _frozenVisibleRect here directly instead
of calling anoether method to do that.
(-[WAKWindow didRotate]): Ditto.
(-[WAKWindow freezeVisibleRect]): Deleted. The method above was the only
caller for this method.
(-[WAKWindow unfreezeVisibleRect]): Ditto.
(+[WAKWindow setOrientationProvider:]): Use the orientationProvider function.
Note, this now retains the passed-in object. This is safe; the only caller
passes in a class, so there's no risk of a retain cycle.
(+[WAKWindow hasLandscapeOrientation]): Use the orientationProvider function.
(-[WAKWindow setTileBordersVisible:]): Deleted. The only caller for this
was in WebKitLegacy, and refactored to use the tile cache directly.
(-[WAKWindow setTilePaintCountsVisible:]): Ditto.
(-[WAKWindow setAcceleratedDrawingEnabled:]): Ditto.
(-[WAKWindow setTileControllerShouldUseLowScaleTiles:]): Deleted. No
callers depend on this.
(+[WAKWindow currentEvent]): Use the currentEvent function.

Source/WebKitLegacy/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Call LegacyTileCache functions directly rather
than indirecting through WAKWindow methods.
(-[WebView viewDidMoveToWindow]): Ditto. Also tweaked conditionals a little for clarity.

11:58 AM Changeset in webkit [273638] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

[LFC][IFC] LineBox's horizontalAlignmentOffset is the root inline box's logical left
​https://bugs.webkit.org/show_bug.cgi?id=222521

Reviewed by Sam Weinig.

That's where the line content starts.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

  • layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::m_contentLogicalWidth):
(WebCore::Layout::LineBox::logicalRectForTextRun const):
(WebCore::Layout::m_horizontalAlignmentOffset): Deleted.

  • layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::setLogicalHeight):
(WebCore::Layout::LineBox::horizontalAlignmentOffset const): Deleted.
(WebCore::Layout::LineBox::setHorizontalAlignmentOffset): Deleted.

11:42 AM Changeset in webkit [273637] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Consider removing support for CSS value keywords with the -khtml- prefix
​https://bugs.webkit.org/show_bug.cgi?id=222515

Reviewed by Darin Adler.

Try removing re-writing of the -khtml- prefix to -webkit- for CSS value keywords
and see what breaks.

  • css/parser/CSSPropertyParser.cpp:

(WebCore::cssValueKeywordID):

8:22 AM Changeset in webkit [273636] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][IFC] Every line box must have a root inline box
​https://bugs.webkit.org/show_bug.cgi?id=222520

Reviewed by Antti Koivisto.

Let's create the root inline box during LineBox construction as even
an empty LineBox has to have a root inline box.

  • layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::m_rootInlineBox):
(WebCore::Layout::LineBox::logicalRectForTextRun const):
(WebCore::Layout::LineBox::logicalRectForInlineLevelBox const):
(WebCore::Layout::m_horizontalAlignmentOffset): Deleted.

  • layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::rootInlineBox const):
(WebCore::Layout::LineBox::rootInlineBox):

4:29 AM WebKitGTK/2.32.x edited by berto@igalia.com
(diff)
3:59 AM Changeset in webkit [273635] by graouts@webkit.org
  • 10 edits in trunk

Blending of border-image-width should be discrete between "auto" values and other types
​https://bugs.webkit.org/show_bug.cgi?id=222516

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Pass an extra 22 WPT interpolation tests for border-image-width. We also get 3 new FAIL results
in css/css-transitions/properties-value-auto-001.html but that test seems incorrect in assuming
there can be a transition for "clip" between "auto" and a non-auto value, at least Chrome and
Firefox both fail the newly-failed tests.

Incidentally, we also get 50 new PASS results from css-grid tests.

  • web-platform-tests/css/css-backgrounds/animations/border-image-width-interpolation-expected.txt:
  • web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-016-expected.txt:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-007-expected.txt:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-012-expected.txt:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-014-expected.txt:
  • web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-016-expected.txt:
  • web-platform-tests/css/css-transitions/properties-value-auto-001-expected.txt:

Source/WebCore:

The LengthBoxPropertyWrapper::canInterpolate() method checks whether the provided lengths are 0 to see if
they can be blended since 0 lengths can be blended with anything. However, currently Length::isZero() returns
true for "auto" values, which is incorrect, so we change the behavior of isZero() to not work when the type
is LengthType::Auto.

Incidentally, this makes a few css-grid tests progress as well.

  • platform/Length.h:

(WebCore::Length::isZero const):

2:15 AM Changeset in webkit [273634] by ysuzuki@apple.com
  • 4 edits in trunk

[JSC] Update test262 host environments
​https://bugs.webkit.org/show_bug.cgi?id=222525

Reviewed by Ross Kirsling.

JSTests:

  • test262/expectations.yaml:

Source/JavaScriptCore:

  1. $262.global should be globalThis of the realm according to test/built-ins/Function/call-bind-this-realm-undef.js
  2. $262.evalScript should uwrap JSProxy to get GlobalObject.

This fixes test262 test/built-ins/Function/call-bind-this-realm-undef.js, it was wrongly tested and failing.

  • jsc.cpp:

(JSC_DEFINE_HOST_FUNCTION):

Feb 27, 2021:

3:07 PM Changeset in webkit [273633] by Kocsen Chung
  • 1 copy in tags/Safari-610.4.3.1.7

Tag Safari-610.4.3.1.7.

3:07 PM Changeset in webkit [273632] by Kocsen Chung
  • 1 copy in tags/Safari-610.4.3.0.4

Tag Safari-610.4.3.0.4.

2:59 PM Changeset in webkit [273631] by Kocsen Chung
  • 4 edits in branches/safari-610.4.3.0-branch/Source/WebCore/Modules/webaudio

Apply patch. rdar://problem/74829324

2:54 PM Changeset in webkit [273630] by Kocsen Chung
  • 8 edits in branches/safari-610.4.3.0-branch/Source

Versioning.

WebKit-7610.4.3.0.4

2:54 PM Changeset in webkit [273629] by Kocsen Chung
  • 4 edits in branches/safari-610.4.3.1-branch/Source/WebCore/Modules/webaudio

Apply patch. rdar://problem/74829334

2:39 PM Changeset in webkit [273628] by Kocsen Chung
  • 8 edits in branches/safari-610.4.3.1-branch/Source

Versioning.

WebKit-7610.4.3.1.7

11:51 AM Changeset in webkit [273627] by weinig@apple.com
  • 5 edits in trunk

Source/WebCore:
Remove support for 'pixel' and 'pos' CSSOM prefixes
​https://bugs.webkit.org/show_bug.cgi?id=119712
<rdar://problem/70660490>

Reviewed by Simon Fraser.

Remove support for pixel/pos prefixed properties of CSSStyleDeclaration which
are no longer supported by any other browser.

  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::getCSSPropertyIDFromJavaScriptPropertyName):
(WebCore::CSSStyleDeclaration::namedItem):
(WebCore::CSSStyleDeclaration::setNamedItem):

LayoutTests:

Remove support for 'pixel' and 'pos' CSSOM prefixes
​https://bugs.webkit.org/show_bug.cgi?id=119712

Reviewed by Simon Fraser.

  • fast/dom/CSSStyleDeclaration/css-properties-case-sensitive-expected.txt:
  • fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html:

Update test to reflect removal of pos/pixel prefixes.

7:34 AM Changeset in webkit [273626] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC][Coverage] Add missing not-yet-modern-line-layout reasons
​https://bugs.webkit.org/show_bug.cgi?id=222488

Reviewed by Sam Weinig.

  • layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::canUseForChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):

  • layout/integration/LayoutIntegrationCoverage.h:
6:27 AM Changeset in webkit [273625] by graouts@webkit.org
  • 7 edits in trunk

border-image-slice blending does not account for the fill keyword
​https://bugs.webkit.org/show_bug.cgi?id=222513

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Pass an extra 96 WPT tests for border-image-slice.

  • web-platform-tests/css/css-backgrounds/animations/border-image-slice-composition-expected.txt:
  • web-platform-tests/css/css-backgrounds/animations/border-image-slice-interpolation-expected.txt:

Source/WebCore:

The border-image-slice CSS property allows for the "fill" keyword on top of the four values defining the slices.
The presence of this keyword is stored as a bool flag on the NinePieceImage returned by RenderStyle::borderImage(),
while the four slices values are stored as a separate LengthBox on that NinePieceImage. So as we blend the
border-image-slice property using the LengthBoxPropertyWrapper, we only account for the four slices values.

In order to account for the "fill" keyword, we use an OptionSet instead of a single flag to represent different blending
options for CSS properties represented by a LengthBox. This allows us to now indicate that a given property,
namely border-image-slice, supports the "fill" keyword.

If this "fill" keyword flag is set, we force discrete interpolation in the case where the from and to blend values
don't have the same value for "fill". Then, as we blend, we set the "fill" keyword to match the from and to values.

To do this, we add a new RenderStyle::setBorderImageSliceFill() property since the NinePieceImage returned by
RenderStyle::borderImage() is marked const.

  • animation/CSSPropertyAnimation.cpp:

(WebCore::LengthBoxPropertyWrapper::LengthBoxPropertyWrapper):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setBorderImageSliceFill):

  • rendering/style/RenderStyle.h:
6:25 AM Changeset in webkit [273624] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Null check ArrayBufferView RefPtr
​https://bugs.webkit.org/show_bug.cgi?id=221569

Patch by Rob Buis <​rbuis@igalia.com> on 2021-02-27
Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

Null check ArrayBufferView RefPtr before using it.

  • runtime/JSArrayBufferViewInlines.h:

(JSC::JSArrayBufferView::unsharedImpl):

LayoutTests:

Add test to verify oom situation does not result in a crash.

  • crypto/crypto-random-values-oom-expected.txt: Added.
  • crypto/crypto-random-values-oom.html: Added.
  • platform/win/TestExpectations:
3:49 AM Changeset in webkit [273623] by graouts@webkit.org
  • 9 edits in trunk

Improve blending of LengthBox values
​https://bugs.webkit.org/show_bug.cgi?id=222512

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Pass an extra 238 WPT tests across border-image-outset, border-image-slice and border-image-width.
As of this patch, web-platform-tests/css/css-backgrounds/animations/border-image-outset-interpolation.html
only has PASS results.

  • web-platform-tests/css/css-backgrounds/animations/border-image-outset-composition-expected.txt:
  • web-platform-tests/css/css-backgrounds/animations/border-image-outset-interpolation-expected.txt:
  • web-platform-tests/css/css-backgrounds/animations/border-image-slice-composition-expected.txt:
  • web-platform-tests/css/css-backgrounds/animations/border-image-slice-interpolation-expected.txt:
  • web-platform-tests/css/css-backgrounds/animations/border-image-width-composition-expected.txt:
  • web-platform-tests/css/css-backgrounds/animations/border-image-width-interpolation-expected.txt:

Source/WebCore:

Blending of LengthBox values used to be handle with a generic wrapper for Length-related types using
LengthVariantPropertyWrapper. However, to properly blend LengthBox values, we need some logic specific
to this value type.

First off, all CSS properties that we represent using a LengthBox disallow negative values, so we update
the blendFunc() implementation for LengthBox to pass in ValueRangeNonNegative to the Length blendFunc().

Then, we need a custom implementation of the canInterpolate() virtual function override so as to cater for
properties that support <length> and <number>, and those that support <length-percentage> and <number>,
namely border-image-width.

Finally, we support the case for discrete blending in the blend() virtual function override.

  • animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::LengthBoxPropertyWrapper::LengthBoxPropertyWrapper):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

1:33 AM Changeset in webkit [273622] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed, reverting r273474 and r273479.
​https://bugs.webkit.org/show_bug.cgi?id=222510

Not a speedup after all

Reverted changesets:

"Optimize the code to check if an element delegates focus to
its shadow root or not"
​https://bugs.webkit.org/show_bug.cgi?id=222404
​https://trac.webkit.org/changeset/273474

"Avoid tree traversals to look for form and canvas elements"
​https://bugs.webkit.org/show_bug.cgi?id=222159
​https://trac.webkit.org/changeset/273479

12:24 AM Changeset in webkit [273621] by Antti Koivisto
  • 16 edits in trunk

Render tree updates for Text node content mutations should happen during rendering update
​https://bugs.webkit.org/show_bug.cgi?id=222406

Reviewed by Simon Fraser.

Source/WebCore:

Calls to Text.insertData and similar should not mutate render tree synchronously.
Instead render tree should be updated during the next rendering update along with
any style changes.

These updates already go via RenderTreeUpdater. We just need to save the information
about which nodes need updating so the next rendering update can pick them up.

This seems to help with some performance benchmarks.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):

Move in-tree check to the updateRendererAfterContentChange and make it use isConnected().

  • dom/Document.cpp:

(WebCore::Document::removedLastRef):
(WebCore::Document::resolveStyle):

Include the text update when updating the render tree.

(WebCore::Document::updateTextRenderer):

Create a text update that will get flushed during the next rendering update.

(WebCore::Document::needsStyleRecalc const):

We need to recalc if there are pending text updates.

  • dom/Document.h:
  • dom/Text.cpp:

(WebCore::Text::splitText):

Use updateRendererAfterContentChange instead of poking render tree directly.

(WebCore::Text::updateRendererAfterContentChange):

  • rendering/updating/RenderTreeUpdater.cpp:
  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::TreeResolver):
(WebCore::Style::TreeResolver::resolve):

  • style/StyleTreeResolver.h:

(WebCore::Style::TreeResolver::TreeResolver):

  • style/StyleUpdate.cpp:

(WebCore::Style::Update::addText):

Merge text updates.

(WebCore::Style::Update::addPossibleRoot):

  • style/StyleUpdate.h:

(WebCore::Style::Update::roots const):
(WebCore::Style::Update:: const): Deleted.

Refcount the nodes since this now has longer lifetime.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):

Ensure we leave deleteInsignificantText with updated render tree. Clients expect that.
Do layout (instead of just style update) for consistency, deleteInsignificantText does one anyway in beginning.

  • editing/markup.cpp:

(WebCore::replaceChildrenWithFragment):

Pending text update may ref the node so this refcount assert is not correct.

  • style/StyleUpdate.cpp:

(WebCore::Style::Update::addText):

LayoutTests:

These are progressions.

  • fast/text/splitText-dirty-lines-expected.txt:
  • imported/blink/fast/css/first-letter-range-insert-expected.txt:

Here we were actually drawing text that didn't exist in DOM anymore.

12:04 AM Changeset in webkit [273620] by Megan Gardner
  • 9 edits
    1 add in trunk

API test for AppHighlights
​https://bugs.webkit.org/show_bug.cgi?id=222408

Reviewed by Tim Horton.

Source/WebCore:

Test: TestWebKitAPI.AppHighlights.AppHighlightCreateAndRestore

  • testing/Internals.cpp:

(WebCore::Internals::numberOfAppHighlights):

  • testing/Internals.h:
  • testing/Internals.idl:

Tools:

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/WKAppHighlights.mm: Added.

(-[AppHighlightDelegate _webView:storeAppHighlight:inNewGroup:]):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:

(TEST):
(waitForConditionWithLogging): Deleted.

  • TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:

(TestWebKitAPI::Util::waitForConditionWithLogging):

Feb 26, 2021:

11:29 PM Changeset in webkit [273619] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Tools

[GTK][WPE] Add a script to show a list of bugs closed since a given revision
​https://bugs.webkit.org/show_bug.cgi?id=222470

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-02-26
Reviewed by Adrian Perez de Castro.

It's useful to get a list of specific changes when making releases.

  • Scripts/webkit-filter-log: Added.
11:24 PM Changeset in webkit [273618] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebKit

[WPE][GTK] Bogus Response.{status,ok} for successful fetch() requests to a custom URI scheme handler
​https://bugs.webkit.org/show_bug.cgi?id=222471

Reviewed by Carlos Garcia Campos.

No new tests needed.

  • UIProcess/API/glib/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestReadCallback): Mark response as having status "200 OK" when
webkit_uri_scheme_request_finish() gets passed a GInputStream.

10:52 PM Changeset in webkit [273617] by ysuzuki@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

[JSC] Avoid creating functions unnecessarily in builtins
​https://bugs.webkit.org/show_bug.cgi?id=222509

Reviewed by Ross Kirsling.

Avoid unnecessary function creation and make them @globalPrivate.

  • builtins/ArrayPrototype.js:

(globalPrivate.maxWithPositives):
(globalPrivate.minWithMaybeNegativeZeroAndPositive):
(copyWithin):
(maxWithPositives): Deleted.
(minWithMaybeNegativeZeroAndPositive): Deleted.

  • builtins/DatePrototype.js:

(globalPrivate.toDateTimeOptionsAnyAll):
(toLocaleString):
(globalPrivate.toDateTimeOptionsDateDate):
(toLocaleDateString):
(globalPrivate.toDateTimeOptionsTimeTime):
(toLocaleTimeString):
(toLocaleString.toDateTimeOptionsAnyAll): Deleted.
(toLocaleDateString.toDateTimeOptionsDateDate): Deleted.
(toLocaleTimeString.toDateTimeOptionsTimeTime): Deleted.

  • builtins/RegExpPrototype.js:

(globalPrivate.getSubstitution):
(overriddenName.string_appeared_here.replace):
(getSubstitution): Deleted.

9:27 PM Changeset in webkit [273616] by Peng Liu
  • 4 edits in trunk/LayoutTests

[GPUP] Refresh test expectations after adding the support to paint GPUP hosted video to 2D canvas and WebGL surfaces
​https://bugs.webkit.org/show_bug.cgi?id=222500

Reviewed by Jer Noble.

r273568 adds the support to paint GPU process hosted video in the WebContent process to
2D canvas and WebGL surfaces. This function is used by layout tests no matter
"GPU Process: Canvas Rendering" and "GPU Process: WebGL" are enabled or not.
A lot of tests depending on it are passing now.

  • gpu-process/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/wk2/TestExpectations:
9:27 PM Changeset in webkit [273615] by Peng Liu
  • 16 edits in trunk/Source/WebKit

[GPUP] Replace references to GPUProcessConnection and Connection with WeakPtr<GPUProcessConnection>
​https://bugs.webkit.org/show_bug.cgi?id=222492

Reviewed by Eric Carlson.

As we did in r273473, this patch replaces some references to GPUProcessConnection and Connection
with WeakPtr<GPUProcessConnection>. r273473 was for the GPU process, this patch is for web processes.
When the GPU process crashes, the GPUProcessConnection object (as well as its Connection object)
will be destroyed, and the reference will be invalid.

No new tests, fixing test crashes on bots.

  • WebProcess/GPU/media/AudioTrackPrivateRemote.cpp:

(WebKit::AudioTrackPrivateRemote::AudioTrackPrivateRemote):
(WebKit::AudioTrackPrivateRemote::setEnabled):

  • WebProcess/GPU/media/AudioTrackPrivateRemote.h:
  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::addRemoteAudioTrack):
(WebKit::MediaPlayerPrivateRemote::addRemoteTextTrack):
(WebKit::MediaPlayerPrivateRemote::addRemoteVideoTrack):

  • WebProcess/GPU/media/MediaSourcePrivateRemote.cpp:

(WebKit::MediaSourcePrivateRemote::MediaSourcePrivateRemote):
(WebKit::MediaSourcePrivateRemote::~MediaSourcePrivateRemote):
(WebKit::MediaSourcePrivateRemote::addSourceBuffer):
(WebKit::MediaSourcePrivateRemote::durationChanged):
(WebKit::MediaSourcePrivateRemote::setReadyState):
(WebKit::MediaSourcePrivateRemote::setIsSeeking):
(WebKit::MediaSourcePrivateRemote::waitForSeekCompleted):
(WebKit::MediaSourcePrivateRemote::seekCompleted):
(WebKit::MediaSourcePrivateRemote::setTimeFudgeFactor):

  • WebProcess/GPU/media/MediaSourcePrivateRemote.h:
  • WebProcess/GPU/media/RemoteImageDecoderAVF.cpp:

(WebKit::RemoteImageDecoderAVF::RemoteImageDecoderAVF):
(WebKit::RemoteImageDecoderAVF::createFrameImageAtIndex):
(WebKit::RemoteImageDecoderAVF::setExpectedContentSize):
(WebKit::RemoteImageDecoderAVF::setData):
(WebKit::RemoteImageDecoderAVF::gpuProcessConnection const): Deleted.

  • WebProcess/GPU/media/RemoteImageDecoderAVF.h:
  • WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp:

(WebKit::RemoteImageDecoderAVFManager::gpuProcessConnection const):

  • WebProcess/GPU/media/RemoteImageDecoderAVFManager.h:
  • WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:

(WebKit::SourceBufferPrivateRemote::SourceBufferPrivateRemote):
(WebKit::SourceBufferPrivateRemote::~SourceBufferPrivateRemote):
(WebKit::SourceBufferPrivateRemote::append):
(WebKit::SourceBufferPrivateRemote::abort):
(WebKit::SourceBufferPrivateRemote::resetParserState):
(WebKit::SourceBufferPrivateRemote::removedFromMediaSource):
(WebKit::SourceBufferPrivateRemote::setReadyState):
(WebKit::SourceBufferPrivateRemote::setActive):
(WebKit::SourceBufferPrivateRemote::setMediaSourceEnded):
(WebKit::SourceBufferPrivateRemote::setMode):
(WebKit::SourceBufferPrivateRemote::updateBufferedFromTrackBuffers):
(WebKit::SourceBufferPrivateRemote::removeCodedFrames):
(WebKit::SourceBufferPrivateRemote::evictCodedFrames):
(WebKit::SourceBufferPrivateRemote::addTrackBuffer):
(WebKit::SourceBufferPrivateRemote::resetTrackBuffers):
(WebKit::SourceBufferPrivateRemote::clearTrackBuffers):
(WebKit::SourceBufferPrivateRemote::setAllTrackBuffersNeedRandomAccess):
(WebKit::SourceBufferPrivateRemote::setGroupStartTimestamp):
(WebKit::SourceBufferPrivateRemote::setGroupStartTimestampToEndTimestamp):
(WebKit::SourceBufferPrivateRemote::setShouldGenerateTimestamps):
(WebKit::SourceBufferPrivateRemote::reenqueueMediaIfNeeded):
(WebKit::SourceBufferPrivateRemote::resetTimestampOffsetInTrackBuffers):
(WebKit::SourceBufferPrivateRemote::startChangingType):
(WebKit::SourceBufferPrivateRemote::setTimestampOffset):
(WebKit::SourceBufferPrivateRemote::setAppendWindowStart):
(WebKit::SourceBufferPrivateRemote::setAppendWindowEnd):
(WebKit::SourceBufferPrivateRemote::seekToTime):
(WebKit::SourceBufferPrivateRemote::updateTrackIds):
(WebKit::SourceBufferPrivateRemote::bufferedSamplesForTrackId):

  • WebProcess/GPU/media/SourceBufferPrivateRemote.h:
  • WebProcess/GPU/media/TextTrackPrivateRemote.cpp:

(WebKit::TextTrackPrivateRemote::TextTrackPrivateRemote):
(WebKit::TextTrackPrivateRemote::setMode):

  • WebProcess/GPU/media/TextTrackPrivateRemote.h:
  • WebProcess/GPU/media/VideoTrackPrivateRemote.cpp:

(WebKit::VideoTrackPrivateRemote::VideoTrackPrivateRemote):
(WebKit::VideoTrackPrivateRemote::setSelected):

  • WebProcess/GPU/media/VideoTrackPrivateRemote.h:

(WebKit::VideoTrackPrivateRemote::create):

7:04 PM Changeset in webkit [273614] by Alan Bujtas
  • 1 edit
    1 add in trunk/PerformanceTests

[Performance test][Line layout] Add test with inline boxes
​https://bugs.webkit.org/show_bug.cgi?id=222498

Reviewed by Ryosuke Niwa.

We don't have a performance test on inline boxes yet.

  • Layout/line-layout-inline-level-boxes.html: Added.
6:51 PM Changeset in webkit [273613] by msaboff@apple.com
  • 2 edits in trunk/JSTests

Followup test fix to r273594
​https://bugs.webkit.org/show_bug.cgi?id=222506

Reviewed by Yusuke Suzuki.

  • stress/regexp-max-size.js:

(testTooBigBMPRegExp):
(testTooBigNonBMPRegExp):
(testAll):

6:42 PM Changeset in webkit [273612] by dino@apple.com
  • 3 edits in trunk/Source/ThirdParty/ANGLE

Support fast/canvas/webgl/copyBufferSubData.html, fix bugs in fast/canvas/webgl/getBufferSubData-webgl1.html in Metal ANGLE on Simulator
​https://bugs.webkit.org/show_bug.cgi?id=222508

Patch by Kyle Piddington <Kyle Piddington> on 2021-02-26
Reviewed by Dean Jackson.

  • src/libANGLE/renderer/metal/BufferMtl.mm:

(rx::BufferMtl::unmap):

  • src/libANGLE/renderer/metal/DisplayMtl.mm:

(rx::DisplayMtl::getMaxSupportedESVersion const):

5:58 PM Changeset in webkit [273611] by sbarati@apple.com
  • 3 edits
    1 add in trunk

Remove bad assertion of AI ArrayMode state in various "by val" opcodes
​https://bugs.webkit.org/show_bug.cgi?id=222494
<rdar://73613460>

Reviewed by Filip Pizlo.

JSTests:

  • stress/dont-assert-ai-proved-array-mode.js: Added.

(bar):
(foo):

Source/JavaScriptCore:

It's invalid to ever assert that AI must have proved something. We've been
slowly removing these faulty asserts from the compiler, and this patch
removes some more of them. AI is conservative, and it's not guaranteed
that it will prove X, even if X must be true.

In this particular test case, we are looking at a race between the concurrent
compiler thread and the main thread, and the compilation will be thrown away
because of a Structure transition.

What happened in this particular program is we had a CheckStructure that was
proved to exit in an early run of AI, that is not shown to exit during a later
run of AI. Because of that, in the earlier AI run, we have some narrower type
info (because fewer predecessory type info). This narrower type info allowed
us to elide a CheckArray. The later runs don't have this narrower type info,
because the CheckStructure doesn't exit. The safety of all of this is
guaranteed by the compilation being thrown away because we fired the transition
watchpoint from the earlier Structure seen by AI.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnDirectArguments):
(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):

5:54 PM Changeset in webkit [273610] by Chris Dumez
  • 37 edits in trunk

Reduce explicit usage of [objC retain] in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=222439

Reviewed by Darin Adler.

Reduce explicit usage of [objC retain] in WebKit by using RetainPtr<>.

Source/JavaScriptCore:

  • API/JSContext.mm:

(+[JSContext currentArguments]):
(-[JSContext beginCallbackWithData:calleeValue:thisValue:argumentCount:arguments:]):
(-[JSContext endCallbackWithData:]):

  • API/JSContextInternal.h:
  • API/tests/testapi.mm:

(-[TinyDOMNode initWithVirtualMachine:]):

Source/WebCore:

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):

  • editing/cocoa/DataDetection.mm:

(WebCore::resultIsURL):

  • editing/cocoa/HTMLConverter.mm:

(WebDefaultFont):

  • platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::imageDecoderAssetOptions):

  • platform/graphics/mac/ColorMac.mm:

(WebCore::nsColor):

  • platform/ios/QuickLook.mm:

(WebCore::QLPreviewGetSupportedMIMETypesSet):
(WebCore::temporaryFileAttributes):
(WebCore::temporaryDirectoryAttributes):

  • platform/ios/WebCoreMotionManager.mm:

(-[WebCoreMotionManager checkClientStatus]):

  • platform/ios/wak/WebCoreThread.mm:

(SendMessage):
(HandleDelegateSource):
(SendDelegateMessage):
(WebThreadCallDelegate):
(WebRunLoopUnlockInternal):
(RunWebThread):
(WebThreadNSRunLoop):

Source/WebKit:

  • NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:

(WebKit::Download::resume):

  • Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:

(WebKit::isFeatureFlagEnabled):

  • UIProcess/API/Cocoa/APIContentRuleListStoreCocoa.mm:

(API::ContentRuleListStore::defaultStorePath):

  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore _allWebsiteDataTypesIncludingPrivate]):

  • UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::tempDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::cacheDirectoryFileSystemRepresentation):
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView keyCommands]):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFPluginAccessibilityObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):

Source/WebKitLegacy/mac:

  • Misc/WebNSURLExtras.mm:

(-[NSString _webkit_rangeOfURLScheme]):

  • Misc/WebStringTruncator.mm:

(+[WebStringTruncator centerTruncateString:toWidth:]):

  • Storage/WebStorageManager.mm:

(+[WebStorageManager _storageDirectoryPath]):

  • WebCoreSupport/WebEditorClient.mm:

(_WebCreateFragment):

  • WebView/WebHTMLRepresentation.mm:

(+[WebHTMLRepresentation supportedMIMETypes]):
(+[WebHTMLRepresentation supportedMediaMIMETypes]):
(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
(+[WebHTMLRepresentation unsupportedTextMIMETypes]):

  • WebView/WebPreferencesDefaultValues.mm:

(WebKit::isFeatureFlagEnabled):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView _close]):
(-[WebView _checkDidPerformFirstNavigation]):
(-[WebView setPreferences:]):
(-[WebView preferences]):
(-[WebView setGroupName:]):

  • WebView/WebViewData.h:

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):
(-[DRTMockScroller drawKnob]):
(-[DRTMockScroller drawRect:]):
(prepareConsistentTestingEnvironment):

  • TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:

(TEST):

  • TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView selectionRectsAfterPresentationUpdate]):

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformLibraryPathForTesting):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::allowedFontFamilySet):
(WTR::systemHiddenFontFamilySet):
(WTR::TestController::platformLibraryPathForTesting):

  • WebKitTestRunner/mac/main.mm:

(disableAppNapInUIProcess):

5:08 PM Changeset in webkit [273609] by Ryan Haddad
  • 2 edits in trunk/Tools

macOS bots should build with ONLY_ACTIVE_ARCH=NO
​https://bugs.webkit.org/show_bug.cgi?id=222502

Reviewed by Aakash Jain.

We need this to correctly build for both arm64e and x86_64 and support M1 hardware in our infrastructure.

  • CISupport/build-webkit-org/steps.py:

(CompileWebKit.start):

5:08 PM Changeset in webkit [273608] by Alan Coon
  • 1 copy in tags/Safari-611.1.21

Tag Safari-611.1.21.

4:55 PM Changeset in webkit [273607] by Ryan Haddad
  • 2 edits in trunk/Tools

Move WebGL test bot to Big Sur
​https://bugs.webkit.org/show_bug.cgi?id=222501

Reviewed by Aakash Jain.

  • CISupport/build-webkit-org/config.json:
4:54 PM Changeset in webkit [273606] by commit-queue@webkit.org
  • 6 edits in trunk

Unreviewed, reverting r273435.
​https://bugs.webkit.org/show_bug.cgi?id=222503

Broke a test

Reverted changeset:

"[css-grid] Fix min/max widths of grid affected by ancestor"
​https://bugs.webkit.org/show_bug.cgi?id=222100
​https://trac.webkit.org/changeset/273435

4:37 PM Changeset in webkit [273605] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Avoid function allocations for non-user-provided Promise then callbacks
​https://bugs.webkit.org/show_bug.cgi?id=222490

Reviewed by Keith Miller.

At @performPromiseThen point, callback function objects themselves are not accessible from users
if they are not passed from users. So, we can reuse functions if users do not pass functions.

  • builtins/PromiseOperations.js:

(globalPrivate.promiseEmptyOnFulfilled):
(globalPrivate.promiseEmptyOnRejected):
(globalPrivate.performPromiseThen):
(onFulfilled): Deleted.
(onRejected): Deleted.

4:32 PM Changeset in webkit [273604] by commit-queue@webkit.org
  • 9 edits in trunk

Source/WebCore:
[MSE] WebContent/GPU process will hang when appending data under some circumstances.
​https://bugs.webkit.org/show_bug.cgi?id=222462

Patch by Jean-Yves Avenard <Jean-Yves Avenard> on 2021-02-26
Reviewed by Jer Noble.

No new test, this is covered by one of the MSE WPT.

  • platform/MediaSample.h:

Add an optional parameter to MediaSample::divide to use the buffer's end time
to determine where to divide it.

  • platform/graphics/SourceBufferPrivate.cpp:

(WebCore::SourceBufferPrivate::didReceiveSample):
When attempting to split the MediaSample so none ends after the
appendWindowEnd attribute, use the MediaSample's end time as split point.

  • platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:

(WebCore::MediaSampleAVFObjC::divide):
Expand the divide method to split the content according to the end time.
Side fix; use OutputPresentationTimeStamp thorough the devide method.
All time and duration comparisons made in the SourceBuffer are based on
the Output times, so to ensure consistency we use the output time when
looking on where to split.

  • platform/graphics/gstreamer/MediaSampleGStreamer.h:
  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

Update per new declaration. New argument is unused.

Tools:
[MSE] Ensure MediaSample is properly trimmed.
​https://bugs.webkit.org/show_bug.cgi?id=222462

Patch by Jean-Yves Avenard <Jean-Yves Avenard> on 2021-02-26
Reviewed by Jer Noble.

  • TestWebKitAPI/Tests/WebCore/SampleMap.cpp:

Update per new MediaSample::divide prototype.

4:29 PM Changeset in webkit [273603] by graouts@webkit.org
  • 4 edits in trunk/Source/WebCore

Length blending should allow for a ValueRange parameter
​https://bugs.webkit.org/show_bug.cgi?id=222497

Reviewed by Dean Jackson.

We introduced a new NonNegativeLengthPropertyWrapper in r273001, the fix for bug 222034, with a special
blend() override implementation which would disallow negative values. However, this is something that
should ideally be provided lower down in the blending code in the blend() function on the Length type
itself. This will allow us to blend other non-negative length-related types, such as LengthBox, without
duplicating this code.

We also use this opportunity to not use the { 0, Fixed } value in all cases where we clip to 0, and
instead use the type from the blended values, provided one isn't 0.

  • animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::NonNegativeLengthPropertyWrapper::NonNegativeLengthPropertyWrapper):

  • platform/Length.cpp:

(WebCore::blend):

  • platform/Length.h:
4:17 PM Changeset in webkit [273602] by Russell Epstein
  • 1 copy in tags/Safari-612.1.5.2

Tag Safari-612.1.5.2.

4:14 PM Changeset in webkit [273601] by Russell Epstein
  • 8 edits in branches/safari-612.1.5-branch/Source

Versioning.

WebKit-7612.1.5.2

4:11 PM Changeset in webkit [273600] by Alan Bujtas
  • 5 edits in trunk

[LFC][Coverage] Do not bail out on text underline position when text-decoration is 'none'
​https://bugs.webkit.org/show_bug.cgi?id=222481

Reviewed by Antti Koivisto.

Source/WebCore:

  • layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForStyle):

LayoutTests:

  • fast/text/simple-line-layout-with-text-underline-position-expected.html:
  • fast/text/simple-line-layout-with-text-underline-position.html:
3:51 PM Changeset in webkit [273599] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[BigSur Wk1] platform/mac-bigsur/media/media-source/media-source-webm-vp8-malformed-header.html is consistently failing
​https://bugs.webkit.org/show_bug.cgi?id=222493

Unreviewed test gardening.

Patch by Amir Mark Jr <Amir Mark Jr.> on 2021-02-26

  • platform/mac-wk1/TestExpectations:
3:48 PM Changeset in webkit [273598] by Russell Epstein
  • 2 edits in branches/safari-612.1.5-branch/Source/WebKit

Revert "Cherry-pick r273560. rdar://problem/74796083"

This reverts commit r273565.

3:45 PM Changeset in webkit [273597] by dino@apple.com
  • 10 edits in trunk/Source/ThirdParty/ANGLE

Fix iOS simulator crashes due to unsupported simulator pixel formats: r8Unorm_srgb, a1bgr5Unorm, b5g6r5Unorm, abgr4Unorm, bgr5A1Unorm, and program generation asserts.

iOS Simulator doesn't support the following packed 16 bit formats natively. While some of these can be emulated, we should fix up the crashing cases first.

Also fix up program generation issues for void fragment shaders

Disable support for PVRTC temporarily, as Non-square / NPOT PVRTC textures are not supported nativley on metal.

​https://bugs.webkit.org/show_bug.cgi?id=222458

Patch by Kyle Piddington <Kyle Piddington> on 2021-02-26
Reviewed by Dean Jackson.

  • src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:

(GenMetalTraverser::emitStructDeclaration):
(GenMetalTraverser::emitFunctionReturn):
(GenMetalTraverser::emitFunctionParameter):

  • src/compiler/translator/TranslatorMetalDirect/Pipeline.cpp:

(PipelineStructs::matches const):

  • src/compiler/translator/TranslatorMetalDirect/Pipeline.h:

(sh::PipelineScoped::matches const):

  • src/libANGLE/renderer/metal/TextureMtl.mm:

(rx::TextureMtl::setPerSliceSubImage):

  • src/libANGLE/renderer/metal/gen_mtl_format_table.py:
  • src/libANGLE/renderer/metal/mtl_format_map.json:
  • src/libANGLE/renderer/metal/mtl_format_table_autogen.mm:

(rx::mtl::Format::init):
(rx::mtl::VertexFormat::init):
(rx::mtl::FormatTable::initNativeFormatCapsAutogen):

  • src/libANGLE/renderer/metal/mtl_format_utils.mm:

(rx::mtl::FormatTable::initialize):

  • src/libANGLE/renderer/metal/mtl_resources.mm:

(rx::mtl::Texture::Make2DTexture):
(rx::mtl::Texture::MakeTexture):

3:41 PM Changeset in webkit [273596] by Devin Rousso
  • 4 edits in trunk

[Payment Request] log when the request is cancelled while waiting for the Promise provided to show()/updateWith() to settle
​https://bugs.webkit.org/show_bug.cgi?id=222491

Reviewed by Andy Estes.

Source/WebCore:

  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::cancel):

LayoutTests:

  • http/tests/paymentrequest/payment-request-show-method.https-expected.txt:
3:30 PM Changeset in webkit [273595] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Unreviewed, reverting r273560.
​https://bugs.webkit.org/show_bug.cgi?id=222499

reverting an unnecessary change after confirming it did not
fix build issues

Reverted changeset:

"Convert WKMediaPlaybackState NS_ENUM back to NSUInteger type"
​https://bugs.webkit.org/show_bug.cgi?id=222475
​https://trac.webkit.org/changeset/273560

3:22 PM Changeset in webkit [273594] by msaboff@apple.com
  • 3 edits
    1 add in trunk

unexpected minimumInputSize in setupDisjunctionOffsets for regexp engine(yarr)
​https://bugs.webkit.org/show_bug.cgi?id=220357

Reviewed by Saam Barati.

JSTests:

New tests to check the boundary conditions for overflowing a pattern in a RegExp.

  • stress/regexp-max-size.js: Added.

(testMaxRegExp):
(testTooBigRegExp):
(testMaxBMPRegExp):
(testTooBigBMPRegExp):
(testMaxNonBMPRegExp):
(testTooBigNonBMPRegExp):
(testAll):

Source/JavaScriptCore:

Removed an unnecessary ASSERT.
This assert checked that the minimum size wasn't UINT_MAX which I believe was
intended to make sure the minimum size was changed while computing the
disjunction's size and offsets. Those calculations involve checked arithmetic,
which would catch any overflow.

The other part of this patch adds a test that checks this condition as well
as the case where the pattern is one character longer, 232, which triggers
the arithmetic overflow.

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::setupDisjunctionOffsets):

3:20 PM Changeset in webkit [273593] by Kate Cheney
  • 2 edits in trunk/Source/WebKit

Remove unnecessary WKMediaPlaybackState header from Xcode project file
​https://bugs.webkit.org/show_bug.cgi?id=222496
<rdar://problem/74808525>

Reviewed by Brent Fulgham.

  • WebKit.xcodeproj/project.pbxproj:
3:17 PM Changeset in webkit [273592] by weinig@apple.com
  • 5 edits in trunk

Remove non-standard 'css'/'Css' prefixed properties on CSSStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=218158
Source/WebCore:

<rdar://problem/70666307>

Reviewed by Tim Horton.

Remove support for 'css'/'Css' prefixed properties of CSSStyleDeclaration which
are no longer supported by any other browser.

  • css/CSSStyleDeclaration.cpp:

LayoutTests:

Reviewed by Tim Horton.

  • fast/dom/CSSStyleDeclaration/css-properties-case-sensitive-expected.txt:
  • fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html:

Update test to reflect removal of css prefixes.

2:39 PM Changeset in webkit [273591] by Peng Liu
  • 3 edits in trunk/LayoutTests

Flaky Test: media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html
​https://bugs.webkit.org/show_bug.cgi?id=182571

Reviewed by Jer Noble.

Fix a flaky test by:
1) Enable "MockVideoPresentationMode".
2) Wait for a video presentation mode change to complete before moving to the next step in the test.
3) Request the video to exit fullscreen before finish the test (to avoid interference with other tests).

  • media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen-expected.txt:
  • media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html:
2:26 PM Changeset in webkit [273590] by wilander@apple.com
  • 27 edits
    2 copies
    2 moves in trunk

Non-cookie website data not deleted after 7 days of browser use without user interaction
​https://bugs.webkit.org/show_bug.cgi?id=222248
<rdar://problem/74612589>

Reviewed by Brent Fulgham and informally by Kate Cheney.

Source/WebKit:

Tests: http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago.html

http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::updateOperatingDatesParameters):

Now sets two new member variables:

  • Optional<OperatingDate> m_longWindowOperatingDate
  • Optional<OperatingDate> m_shortWindowOperatingDate These are only set if the minimum number of operating days has passed. This function no longer sets m_leastRecentOperatingDate.

(WebKit::ResourceLoadStatisticsDatabaseStore::hasStatisticsExpired const):

Now checks against the two new member variables m_longWindowOperatingDate
and m_shortWindowOperatingDate. This fixes the bug.

(WebKit::ResourceLoadStatisticsDatabaseStore::insertExpiredStatisticForTesting):

Test infrastructure. Now takes the new parameter numberOfOperatingDaysPassed
with which layout tests can control the exact number of operating days
passed since user interaction.

  • NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:

Added m_longWindowOperatingDate and m_shortWindowOperatingDate, and
removed m_leastRecentOperatingDate since it's no longer used.

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::insertExpiredStatisticForTesting):

Test infrastructure. The same changes as in the DB store.

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
  • NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::insertExpiredStatisticForTesting):

Test infrastructure.

  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::insertExpiredStatisticForTesting):

Test infrastructure.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetStatisticsExpiredStatistic):

Test infrastructure.

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::insertExpiredStatisticForTesting):

Test infrastructure.

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::insertExpiredStatisticForTesting):

Test infrastructure.

  • UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

A new numberOfOperatingDaysPassed parameter was added to
testRunner.setStatisticsExpiredStatistic() to control the exact
number of operating days passed since user interaction.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setStatisticsExpiredStatistic):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::setStatisticsExpiredStatistic):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Existing test cases now make use of the new numberOfOperatingDaysPassed
parameter to testRunner.setStatisticsExpiredStatistic() to control the exact
number of operating days passed since user interaction.
A new test case makes sure website data is not deleted below the threshold.

  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago-expected.txt: Added.
  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago.html: Added.

Sets numberOfOperatingDaysPassed to 6.

  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago-expected.txt: Renamed from LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-statistics-with-no-user-interaction-expected.txt.
  • http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html: Renamed from LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-statistics-with-no-user-interaction.html.

Sets numberOfOperatingDaysPassed to 7.

  • http/tests/resourceLoadStatistics/operating-dates-all-website-data-removed.html:

Sets numberOfOperatingDaysPassed to 30.

  • platform/wk2/TestExpectations:

Updated existing expectation with new file name.

2:11 PM Changeset in webkit [273589] by Devin Rousso
  • 2 edits in trunk/Tools

Unreviewed, add myself to the ConsoleUsage watchlist

  • Scripts/webkitpy/common/config/watchlist:
1:43 PM Changeset in webkit [273588] by BJ Burg
  • 5 edits in trunk/Source/WebKit

Web Inspector: give WebInspectorUIExtensionControllerProxy a chance to teardown when the frontend is about to close
​https://bugs.webkit.org/show_bug.cgi?id=222486

Reviewed by Devin Rousso.

Sometimes when closing Web Inspector, the message receiver for WebInspectorUIExtensionControllerProxy
is not removed. Move this teardown into a separate method. It's too late to do this in the destructor
if a lambda has kept a strong reference to the controller beyond the point when the frontend was closed.

Covered by existing API tests, which will hopefully become less flaky as a result.

  • UIProcess/Inspector/RemoteWebInspectorProxy.cpp:

(WebKit::RemoteWebInspectorProxy::closeFrontendPageAndWindow):

  • UIProcess/Inspector/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::closeFrontendPageAndWindow):
Notify the extensions controller that it's time to teardown.

  • UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.h:
  • UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp:

(WebKit::WebInspectorUIExtensionControllerProxy::~WebInspectorUIExtensionControllerProxy):
By the time this destructor runs, we should have already gotten the message to teardown.

(WebKit::WebInspectorUIExtensionControllerProxy::inspectorFrontendWillClose): Added.
Use the soon-to-be-gone m_frontendPage to unregister as a message receiver.

1:41 PM Changeset in webkit [273587] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Flaky JSC test: stress/atomic-increment-bigint64.js
​https://bugs.webkit.org/show_bug.cgi?id=221904

Reviewed by Keith Miller.

bytecode-cache test assumes that code can be cached once it is executed. But this
is not correct for threading tests using JSC shell's agent feature: code is running
different VM in the different thread. And we have no guarantee that this thread destroys
VM when the main thread is finished. So this is possible that bytecode used in that thread
is not committed.

We use Options::forceDiskCache's RELEASE_ASSERT only if it is in main thread.

  • runtime/CodeCache.h:
1:40 PM Changeset in webkit [273586] by BJ Burg
  • 2 edits in trunk/Source/WebKit

[Cocoa] Web Inspector: add support for receiving Web Extension events via _WKInspectorExtensionDelegate
​https://bugs.webkit.org/show_bug.cgi?id=222252
<rdar://problem/71206685>

Unreviewed, revert one unintentionally changed error code.

Fixes failing API test WKInspectorExtensionHost.UnregisterExtension.

  • UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp:

(WebKit::WebInspectorUIExtensionControllerProxy::unregisterExtension):

1:36 PM Changeset in webkit [273585] by Jonathan Bedard
  • 6 edits
    1 add in trunk/Tools

[webkitcorepy] Move credential access from webkitscmpy
​https://bugs.webkit.org/show_bug.cgi?id=222487
<rdar://problem/74801487>

Rubber-stamped by Aakash Jain.

  • Scripts/libraries/webkitcorepy/setup.py: Bump version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version, move keyring libraries.
  • Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py: Add.
  • Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version, move keyring libraries.
  • Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:

(GitHub.credentials): Use webkitcorepy credentials.

1:03 PM Changeset in webkit [273584] by Jonathan Bedard
  • 9 edits in trunk/Tools

[resultsdbpy] Use webkitcorepy requests mocking
​https://bugs.webkit.org/show_bug.cgi?id=222443
<rdar://problem/74764567>

Reviewed by Dewei Zhu.

  • Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Bump version.
  • Scripts/libraries/resultsdbpy/resultsdbpy/model/casserole_unittest.py:

(CasseroleTest.test_synchronous): Use webkitcorepy's requests mocking.
(CasseroleTest.test_asynchronous): Ditto.
(CasseroleTest.test_list_like): Ditto.
(MockRequest): Deleted.

  • Scripts/libraries/resultsdbpy/resultsdbpy/model/ci_context_unittest.py:

(URLFactoryTest.mock): Use webkitcorepy's requests mocking.
(URLFactoryTest.MockRequest): Deleted.
(URLFactoryTest.get): Deleted.

  • Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes_unittest.py:

(WebSiteTestCase.decorator): Referenced static files have already been moved.
(WebSiteTestCase.decorator.MockRequest): Deleted.

  • Scripts/libraries/resultsdbpy/setup.py: Bump version.
  • Scripts/libraries/webkitcorepy/setup.py: Ditto.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
  • Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests_.py:

(Requests.init): Allow caller to specify certain responses.
(Requests.request):

1:02 PM Changeset in webkit [273583] by Andres Gonzalez
  • 4 edits in trunk

Add AXTextMarkerRangeForNSRange attribute so that Mac clients can access this functionality.
​https://bugs.webkit.org/show_bug.cgi?id=222477
Source/WebCore:

<rdar://problem/74793445>

Reviewed by Chris Fleizach.

This is a follow up to: ​https://bugs.webkit.org/show_bug.cgi?id=222154.
As Chris Fleizach pointed out in the above review, it is necessary to
add a handler in accessibilityAttributeValue:forParameter: for a new AX
attribute in order for clients to access this functionality.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper textMarkerRangeForNSRange:]): Deleted.

Tools:

Reviewed by Chris Fleizach.

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::textMarkerRangeForRange):

12:44 PM Changeset in webkit [273582] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]
​https://bugs.webkit.org/show_bug.cgi?id=218637
<rdar://problem/71102126>

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-02-26
Reviewed by Kenneth Russell.

Remove incorrect validation that IOSurface pixel format matches
the pixel format of the texture image being specified.

The "Element" in IOSurface is a block of pixels, while the validation assumed
it means one pixel. The validation failed for a compressed format.

Currently we map non-public YUV formats, to which there is no elequent way
of implementing the validation.
Most likely this started to reproduce if IOSurfaceGetBytesPerElementOfPlane
was changed to produce correct results for the above YUV format.

Later commits could add the validation back for formats that we know the
pixel format type.

  • src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:

(rx::IOSurfaceSurfaceEAGL::validateAttributes):

12:31 PM Changeset in webkit [273581] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

[ews] Commit queue should show commit identifier every time it updates local checkout
​https://bugs.webkit.org/show_bug.cgi?id=222287

Reviewed by Jonathan Bedard.

  • CISupport/ews-build/factories.py:

(CommitQueueFactory.init): Added ShowIdentifier step.

  • CISupport/ews-build/factories_unittest.py: Updated unit-test.
12:27 PM Changeset in webkit [273580] by Alan Coon
  • 2 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r273558. rdar://problem/74800042

Unreviewed, address post-landing review feedback for r273542.

Update a comment and fix a check that was reversed.

  • Modules/webaudio/ScriptProcessorNode.cpp: (WebCore::ScriptProcessorNode::createOutputBufferForJS const): (WebCore::ScriptProcessorNode::process):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:27 PM Changeset in webkit [273579] by Alan Coon
  • 5 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r273542. rdar://problem/74800042

Fix threading issue in ScriptProcessorNode::process()
​https://bugs.webkit.org/show_bug.cgi?id=222447
<rdar://74700526>

Reviewed by Jer Noble.

It was possible for the audio thread (in ScriptProcessorNode::process())
and the main thread (via ScriptProcessorNode::fireProcessEvent()) to
access the same m_inputBuffers / m_outputBuffers concurrently, causing
crashes. The m_processLock was supposed to avoid this. However, the
scope of the locking in ScriptProcessorNode::process() was insufficient
to protect us. ScriptProcessorNode::process() now grabs the lock very
early, before interacting with any buffers and we make sure not to
modify the buffers when we are unable to grab the lock.

Also, to make sure that the m_inputBuffers / m_outputBuffers are modified
by the main thread only during the scope of the fireProcessEvent() function
(during which we hold the processLock), we no longer pass our internal
buffers to the JS process event handler. Instead, we pass new buffers to
JS and memcpy to and from them. While this is less efficient, this is
actually required because the script could store the buffers it is given
and modify them outside the scope of the process event handler.

  • Modules/webaudio/AudioBuffer.cpp: (WebCore::AudioBuffer::AudioBuffer): (WebCore::AudioBuffer::topologyMatches const): (WebCore::AudioBuffer::copyTo const): (WebCore::AudioBuffer::clone const):
  • Modules/webaudio/AudioBuffer.h:
  • Modules/webaudio/ScriptProcessorNode.cpp: (WebCore::ScriptProcessorNode::createInputBufferForJS const): (WebCore::ScriptProcessorNode::createOutputBufferForJS const): (WebCore::ScriptProcessorNode::process): (WebCore::ScriptProcessorNode::fireProcessEvent):
  • Modules/webaudio/ScriptProcessorNode.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:27 PM Changeset in webkit [273578] by Alan Coon
  • 5 edits
    4 adds in branches/safari-611-branch

Cherry-pick r273512. rdar://problem/74799698

REGRESSION(r269957): Empty font names passed to canvas2d cause all text routines to crash
​https://bugs.webkit.org/show_bug.cgi?id=222402
<rdar://problem/72621268>

Reviewed by Darin Adler and Chris Lord.

Source/WebCore:

It looks like it was simply an oversight from that patch. If the font name is empty,
CanvasRenderingContext2D::setFont() will set the font object to one that doesn't have
its internal FontCascadeFonts pointer set.

Tests: fast/text/canvas-font-resolution-2.html

fast/text/canvas-font-resolution.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont):
  • html/canvas/CanvasRenderingContext2DBase.h: (WebCore::CanvasRenderingContext2DBase::FontProxy::isPopulated const):
  • style/StyleResolveForFontRaw.cpp: (WebCore::Style::resolveForFontRaw):

LayoutTests:

  • fast/text/canvas-font-resolution-2-expected.html: Added.
  • fast/text/canvas-font-resolution-2.html: Added.
  • fast/text/canvas-font-resolution-expected.txt: Added.
  • fast/text/canvas-font-resolution.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:27 PM Changeset in webkit [273577] by Alan Coon
  • 2 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r273498. rdar://problem/74800989

[iOS] Crash when playing Dolby Atmos audio tracks with AVAudioTimePitchAlgorithmTimeDomain
​https://bugs.webkit.org/show_bug.cgi?id=222420
<rdar://74612532>

Reviewed by Eric Carlson.

CoreAudio throws an assertion when using the TimeDomain pitch-correction algorithm on tracks
with > 2 channels. To work around this assertion for now, only set the pitch-correction
algorithm when the playbackRate is set to a non 0 or 1 value.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::audioTimePitchAlgorithmForMediaPlayerPitchCorrectionAlgorithm): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): (WebCore::MediaPlayerPrivateAVFoundationObjC::setPlayerRate): (WebCore::MediaPlayerPrivateAVFoundationObjC::setPreservesPitch): (WebCore::MediaPlayerPrivateAVFoundationObjC::setPitchCorrectionAlgorithm): (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatusDidChange):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:22 PM Changeset in webkit [273576] by pvollan@apple.com
  • 7 edits in trunk/Source/WebKit

[Cocoa] Send QOS parameters as part of Web process creation parameters
​https://bugs.webkit.org/show_bug.cgi?id=222474

Reviewed by Chris Dumez.

In order to save one IPC call when starting a WebContent process, send QOS parameters as part of Web process creation parameters.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::initializeNewWebProcess):

  • WebProcess/WebProcess.messages.in:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

12:21 PM Changeset in webkit [273575] by pvollan@apple.com
  • 4 edits in trunk/Source/WebKit

[Cocoa] Start WebContent process pre-warming when process is initialized
​https://bugs.webkit.org/show_bug.cgi?id=222476

Reviewed by Chris Dumez.

Instead of pre-warming in response to a message, the WebContent process can start pre-warming automatically
if it is of a pre-warmed process type. This saves one IPC message on startup of the WebContent process.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::initializeNewWebProcess):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.messages.in:
12:09 PM Changeset in webkit [273574] by Devin Rousso
  • 10 edits in trunk/Source/WebKit

Provide the image URL for accessibility image extraction
​https://bugs.webkit.org/show_bug.cgi?id=222483
<rdar://problem/74144895>

Reviewed by Wenson Hsieh.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::requestImageExtraction):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestImageExtraction):

  • UIProcess/PageClient.h:

(WebKit::PageClient::requestImageExtraction):

  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::requestImageExtraction):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:
12:00 PM Changeset in webkit [273573] by Alan Coon
  • 1 copy in tags/Safari-611.1.20

Tag Safari-611.1.20.

11:51 AM Changeset in webkit [273572] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Remove old buildbot version from webkitpy autoinstaller
​https://bugs.webkit.org/show_bug.cgi?id=222272

Reviewed by Jonathan Bedard.

  • Scripts/webkitpy/autoinstalled/buildbot.py:
11:29 AM Changeset in webkit [273571] by Alan Coon
  • 2 edits in branches/safari-611-branch/LayoutTests

Cherry-pick r273567. rdar://problem/74798808

Emoji sequences with constituents in the UBLOCK_SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A Unicode block don't get combined properly
​https://bugs.webkit.org/show_bug.cgi?id=222438
<rdar://problem/74382039>

Unreviewed test gardening.

  • platform/mac/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:29 AM Changeset in webkit [273570] by Alan Coon
  • 5 edits
    2 adds in branches/safari-611-branch

Cherry-pick r273539. rdar://problem/74798808

Emoji sequences with constituents in the UBLOCK_SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A Unicode block don't get combined properly
​https://bugs.webkit.org/show_bug.cgi?id=222438
<rdar://problem/74382039>

Reviewed by Zalan Bujtas.

Source/WebCore:

Just add UBLOCK_SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A to the list.

We have to do some workarounds because not all versions of ICU include this value.
Luckily, these workarounds are compile-time-only, because we we're only using this value
to compare to a value produced by ICU (not a value we pass into ICU).

Test: fast/text/mending-heart.html

  • platform/text/CharacterProperties.h: (WebCore::isEmojiGroupCandidate):

LayoutTests:

  • fast/text/mending-heart-expected.txt: Added.
  • fast/text/mending-heart.html: Added.
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:29 AM Changeset in webkit [273569] by Lauro Moura
  • 4 edits
    15 moves in trunk/LayoutTests

[GLIB] Move some css3 blending baselines to glib and update expectations

Unreviewed test gardening.

These tests are passing in GTK and in WPE, so move the baselines to
glib.

The two GTK expectations left are now in GLIB and the PASS flakiness
removed as they are consistently ImageOnlyFailing. Also moved the
other expectations to the compositing section.

  • platform/glib/TestExpectations:
  • platform/glib/css3/blending/svg-blend-color-burn-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-color-burn-expected.txt.
  • platform/glib/css3/blending/svg-blend-color-dodge-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-color-dodge-expected.txt.
  • platform/glib/css3/blending/svg-blend-darken-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-darken-expected.txt.
  • platform/glib/css3/blending/svg-blend-difference-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-difference-expected.txt.
  • platform/glib/css3/blending/svg-blend-exclusion-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-exclusion-expected.txt.
  • platform/glib/css3/blending/svg-blend-hard-light-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-hard-light-expected.txt.
  • platform/glib/css3/blending/svg-blend-lighten-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-lighten-expected.txt.
  • platform/glib/css3/blending/svg-blend-multiply-alpha-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-multiply-alpha-expected.txt.
  • platform/glib/css3/blending/svg-blend-multiply-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-multiply-expected.txt.
  • platform/glib/css3/blending/svg-blend-normal-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-normal-expected.txt.
  • platform/glib/css3/blending/svg-blend-overlay-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-overlay-expected.txt.
  • platform/glib/css3/blending/svg-blend-plus-darker-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-plus-darker-expected.txt.
  • platform/glib/css3/blending/svg-blend-plus-lighter-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-plus-lighter-expected.txt.
  • platform/glib/css3/blending/svg-blend-screen-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-screen-expected.txt.
  • platform/glib/css3/blending/svg-blend-soft-light-expected.txt: Renamed from LayoutTests/platform/gtk/css3/blending/svg-blend-soft-light-expected.txt.
  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
11:28 AM Changeset in webkit [273568] by jer.noble@apple.com
  • 20 edits in trunk/Source

[GPUP] Allow painting of GPUP hosted video from the WebContent process
​https://bugs.webkit.org/show_bug.cgi?id=222461

Reviewed by Eric Carlson.

Source/WebCore:

  • Change the return type of pixelBufferForCurrentTime() to return a RetainPtr<> rather than just a raw pointer.
  • Add utility methods on IOSurface to retrieve an IOSurface from a CVPixelBuffer and to reconstitute a CVPixelBuffer from an IOSurface.
  • platform/cocoa/CoreVideoSoftLink.cpp:
  • platform/cocoa/CoreVideoSoftLink.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::pixelBufferForCurrentTime):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::pixelBufferForCurrentTime):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::pixelBufferForCurrentTime):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pixelBufferForCurrentTime):

  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::createFromPixelBuffer):
(WebCore::IOSurface::createPixelBuffer):

  • platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::copyTextureFromMedia):

Source/WebKit:

Add Cocoa implementations for nativeImageForCurrentTime() and pixelBufferForCurrentTime().
Use those methods to implement paintCurrentFrameInContext().

  • GPUProcess/media/RemoteMediaPlayerProxy.h:
  • GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
  • GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:

(WebKit::RemoteMediaPlayerProxy::nativeImageForCurrentTime):
(WebKit::RemoteMediaPlayerProxy::pixelBufferForCurrentTime):

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::paint):
(WebKit::MediaPlayerPrivateRemote::paintCurrentFrameInContext):
(WebKit::MediaPlayerPrivateRemote::pixelBufferForCurrentTime):

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
  • WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:

(WebKit::MediaPlayerPrivateRemote::nativeImageForCurrentTime):
(WebKit::MediaPlayerPrivateRemote::pixelBufferForCurrentTime):

10:44 AM Changeset in webkit [273567] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

Emoji sequences with constituents in the UBLOCK_SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A Unicode block don't get combined properly
​https://bugs.webkit.org/show_bug.cgi?id=222438
<rdar://problem/74382039>

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:40 AM Changeset in webkit [273566] by Russell Epstein
  • 1 copy in tags/Safari-612.1.5.1

Tag Safari-612.1.5.1.

10:33 AM Changeset in webkit [273565] by Russell Epstein
  • 2 edits in branches/safari-612.1.5-branch/Source/WebKit

Cherry-pick r273560. rdar://problem/74796083

Convert WKMediaPlaybackState NS_ENUM back to NSUInteger type
​https://bugs.webkit.org/show_bug.cgi?id=222475
<rdar://problem/74787665>

Reviewed by Alex Christensen.

  • UIProcess/API/Cocoa/WKWebView.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:24 AM Changeset in webkit [273564] by pvollan@apple.com
  • 8 edits in trunk/Source

[Cocoa] Register VP9 decoders when PlatformMediaSessionManager is created
​https://bugs.webkit.org/show_bug.cgi?id=222473
<rdar://problem/74790242>

Reviewed by Eric Carlson.

Source/WebCore:

Currently, VP9 decoders are registered when a Web page is created in the WebContent process. Instead, VP9 decoders can be registered
when PlatformMediaSessionManager is created, which should be a slight performance improvement, since calls into media frameworks will
then not be made unconditionally when creating a Web page, but delayed until required.

No new tests, covered by existing tests.

  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::setShouldEnableVP9Decoder):
(WebCore::PlatformMediaSessionManager::shouldEnableVP9Decoder):
(WebCore::PlatformMediaSessionManager::setShouldEnableVP8Decoder):
(WebCore::PlatformMediaSessionManager::shouldEnableVP8Decoder):
(WebCore::PlatformMediaSessionManager::setShouldEnableVP9SWDecoder):
(WebCore::PlatformMediaSessionManager::shouldEnableVP9SWDecoder):

  • platform/audio/PlatformMediaSessionManager.h:
  • platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::MediaSessionManagerCocoa):

Source/WebKit:

Currently, VP9 decoders are registered when a Web page is created in the WebContent process. Instead, VP9 decoders can be registered when
PlatformMediaSessionManager is created, which should be a slight performance improvement, since calls into media frameworks will then not
be made unconditionally when creating a Web page, but delayed until required.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_lastNavigationWasAppBound):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::enableVP9Decoder): Deleted.
(WebKit::WebProcess::enableVP8SWDecoder): Deleted.
(WebKit::WebProcess::enableVP9SWDecoder): Deleted.

  • WebProcess/WebProcess.h:
10:24 AM Changeset in webkit [273563] by Ruben Turcios
  • 8 edits in branches/safari-612.1.5-branch/Source

Versioning.

WebKit-7612.1.5.1

9:54 AM Changeset in webkit [273562] by Devin Rousso
  • 10 edits
    2 adds in trunk

[Payment Request] log if updateWith is not called synchronously
​https://bugs.webkit.org/show_bug.cgi?id=222436

Reviewed by Andy Estes.

Source/WebCore:

Test: http/tests/paymentrequest/updateWith-log-error-if-not-synchronous.https.html

  • Modules/paymentrequest/PaymentRequest.h:
  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::shippingAddressChanged):
(WebCore::PaymentRequest::shippingOptionChanged):
(WebCore::PaymentRequest::paymentMethodChanged):
(WebCore::PaymentRequest::dispatchAndCheckUpdateEvent): Added.

  • Modules/paymentrequest/PaymentRequestUpdateEvent.h:

(WebCore::PaymentRequestUpdateEvent::didCallUpdateWith const): Added.

LayoutTests:

  • http/tests/paymentrequest/updateWith-log-error-if-not-synchronous.https.html: Added.
  • http/tests/paymentrequest/updateWith-log-error-if-not-synchronous.https-expected.txt: Added.
  • http/tests/paymentrequest/payment-request-change-shipping-address.https.html:
  • http/tests/paymentrequest/payment-request-change-shipping-option.https.html:
  • http/tests/paymentrequest/payment-request-show-method.https.html:
  • http/tests/ssl/applepay/ApplePayBillingAddress.html:
  • http/tests/ssl/applepay/ApplePayPaymentMethodChangeEvent.https.html:

Add updateWith({}) calls to avoid the log.

9:49 AM Changeset in webkit [273561] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[ macOS ] fast/text/mending-heart.html is a constant text failure
​https://bugs.webkit.org/show_bug.cgi?id=222479

Unreviewed test gardening.

Patch by Robert Jenner <Robert Jenner> on 2021-02-26

  • platform/mac/TestExpectations: Test consantly fails. Already marked in test for iOS, updating test expectation to fail for macOS until the test is fixed.
9:40 AM Changeset in webkit [273560] by Kate Cheney
  • 2 edits in trunk/Source/WebKit

Convert WKMediaPlaybackState NS_ENUM back to NSUInteger type
​https://bugs.webkit.org/show_bug.cgi?id=222475
<rdar://problem/74787665>

Reviewed by Alex Christensen.

  • UIProcess/API/Cocoa/WKWebView.h:
9:14 AM Changeset in webkit [273559] by Peng Liu
  • 6 edits in trunk/LayoutTests

[GPUP] Clean up TestExpectations related to media tests
​https://bugs.webkit.org/show_bug.cgi?id=222456

Reviewed by Simon Fraser.

  • gpu-process/TestExpectations:

Remove a duplicated expectation (imported/w3c/web-platform-tests/fetch/range/general.window.html).
Move webaudio related test expectations to platform/wk2/TestExpectations.

  • platform/ios-wk2/TestExpectations:

webkit.org/b/221821 has been fixed in r273504.

  • platform/mac-wk2/TestExpectations:

Two media capabilities test failures have been fixed in r273504.
Move a test expectation (platform/mac/media/media-source/videoplaybackquality-decompressionsession.html)
to platform/mac/TestExpectations.
Reorganize expectations for tests in webgl/2.0.0/conformance2/textures/video.

  • platform/mac/TestExpectations:

Remove a duplicated test expectation (mediaElementAudioSourceToScriptProcessorTest.html).

  • platform/wk2/TestExpectations:

Track all modern-media-controls test failures in one bug.
Track all canvas related media test failures in one bug.

8:02 AM Changeset in webkit [273558] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, address post-landing review feedback for r273542.

Update a comment and fix a check that was reversed.

  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::createOutputBufferForJS const):
(WebCore::ScriptProcessorNode::process):

7:46 AM Changeset in webkit [273557] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[build.webkit.org] Stop using deprecated buildbot.status.builder
​https://bugs.webkit.org/show_bug.cgi?id=222373

Reviewed by Jonathan Bedard.

  • CISupport/build-webkit-org/steps.py:
6:51 AM WebKitFlatpakSDK/DebugWithRR edited by Philippe Normand
(diff)
6:48 AM Changeset in webkit [273556] by Alan Bujtas
  • 7 edits in trunk/Source/WebCore

[LFC][IFC] Inline boxes should not be referred as inline containers
​https://bugs.webkit.org/show_bug.cgi?id=222455

Reviewed by Antti Koivisto.

Inline boxes used to be called inline containers (e.g <span> -> [inline container start] and </span> -> [inline container end]).

  • layout/inlineformatting/InlineContentBreaker.cpp:

(WebCore::Layout::hasTextRun):
(WebCore::Layout::InlineContentBreaker::processOverflowingContentWithText const):

  • layout/inlineformatting/InlineContentBreaker.h:
  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::usedContentHeight const):
(WebCore::Layout::InlineFormattingContext::collectInlineContentIfNeeded):

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

  • layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::appendInlineBoxStart):
(WebCore::Layout::Line::appendInlineBoxEnd):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::TrimmableTrailingContent::remove):

  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::isAtSoftWrapOpportunity):
(WebCore::Layout::LineBuilder::nextWrapOpportunity const):

6:48 AM Changeset in webkit [273555] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] Include the inline box in the enclosing geometry only once
​https://bugs.webkit.org/show_bug.cgi?id=222454

Reviewed by Antti Koivisto.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

6:19 AM Changeset in webkit [273554] by Alan Bujtas
  • 4 edits in trunk/LayoutTests

Remove unnecessary whitespace (css1/text_properties/text_decoration.html)
​https://bugs.webkit.org/show_bug.cgi?id=222446

Reviewed by Antti Koivisto.

Whitespace characters often end up as trailing content and legacy line layout does not trim them properly.
They cause unnecessary noise in renderer tree dumps when switching to modern line layout.

  • css1/box_properties/border.html:
  • css1/text_properties/text_decoration.html:
  • platform/mac/css1/box_properties/border-expected.txt:
  • platform/mac/css1/text_properties/text_decoration-expected.txt:
6:07 AM Changeset in webkit [273553] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix clang compilation error in PlatformXR::ViewData initialization
​https://bugs.webkit.org/show_bug.cgi?id=222467

Patch by Imanol Fernandez <imanol> on 2021-02-26
Reviewed by Philippe Normand.

Mixture of designated and non-designated struct initializers is a C99 extension.
Switch to designated initializers to avoid compilation errors in compilers not
supporting the extension.

  • Modules/webxr/WebXRSystem.cpp:

(WebCore::WebXRSystem::DummyInlineDevice::views const):

  • platform/xr/openxr/PlatformXROpenXR.cpp:

(PlatformXR::OpenXRDevice::views const):

  • testing/WebFakeXRDevice.cpp:

(WebCore::SimulatedXRDevice::views const):

6:00 AM Changeset in webkit [273552] by Carlos Garcia Campos
  • 2 edits in trunk

Unreviewed. [GTK] Bump version numbers

  • Source/cmake/OptionsGTK.cmake:
4:45 AM Changeset in webkit [273551] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, WPE build fix after SDK r273544 deployment

  • TestWebKitAPI/PlatformWPE.cmake: GLib include path was missing in the TestJavaScriptCore

build.

4:05 AM Changeset in webkit [273550] by youenn@apple.com
  • 12 edits
    1 move
    7 adds in trunk

Add support for WebRTC priority
​https://bugs.webkit.org/show_bug.cgi?id=222416

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/webrtc-priority/META.yml: Added.
  • web-platform-tests/webrtc-priority/RTCPeerConnection-ondatachannel-expected.txt: Added.
  • web-platform-tests/webrtc-priority/RTCPeerConnection-ondatachannel.html: Added.
  • web-platform-tests/webrtc-priority/RTCRtpParameters-encodings-expected.txt: Added.
  • web-platform-tests/webrtc-priority/RTCRtpParameters-encodings.html: Added.
  • web-platform-tests/webrtc-priority/w3c-import.log: Added.

Source/WebCore:

Implement ​https://w3c.github.io/webrtc-priority/ by piping priorities between binding and backend.

Tests: imported/w3c/web-platform-tests/webrtc-priority/RTCPeerConnection-ondatachannel.html

imported/w3c/web-platform-tests/webrtc-priority/RTCRtpParameters-encodings.html

  • Modules/mediastream/RTCDataChannel.h:
  • Modules/mediastream/RTCDataChannel.idl:
  • Modules/mediastream/RTCRtpEncodingParameters.h:
  • Modules/mediastream/RTCRtpEncodingParameters.idl:
  • Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp:

(WebCore::LibWebRTCDataChannelHandler::fromRTCDataChannelInit):
(WebCore::LibWebRTCDataChannelHandler::channelEvent):
(WebCore::fromStdString): Deleted.

  • Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:

(WebCore::fromRTCPriorityType):
(WebCore::toRTCPriorityType):
(WebCore::toWebRTCBitRatePriority):
(WebCore::fromWebRTCBitRatePriority):
(WebCore::toRTCEncodingParameters):
(WebCore::fromRTCEncodingParameters):
(WebCore::updateRTCRtpSendParameters):

  • Modules/mediastream/libwebrtc/LibWebRTCUtils.h:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/RTCDataChannelHandler.h:
  • platform/mediastream/RTCPriorityType.h: Renamed from Source/WebCore/Modules/mediastream/RTCPriorityType.h.
3:53 AM Changeset in webkit [273549] by commit-queue@webkit.org
  • 14 edits in trunk

Implement OpenXR port graphics binding
​https://bugs.webkit.org/show_bug.cgi?id=222173

Patch by Imanol Fernandez <imanol> on 2021-02-26
Reviewed by Sergio Villar Senin.

.:

Enable OpenXR defines required for EGL graphics binding.

  • Source/cmake/OptionsWPE.cmake:

Source/WebCore:

This patch implements the graphics binding required to initialize OpenXR sessions
with tracking and rendering support. The current implementation was using a headless
OpenXR session which is not valid for tracking.

The headless session was used to avoid allocating the graphics resources during WebXR
device enumeration. The problem is that it can't be converted later to a valid session for
tracking, and the global XrInstance needs to be recreated. This patch implements a new approach
to keep the delayed graphics initialization without using the headless session.

  • platform/graphics/egl/GLContextEGL.cpp: Add EGLConfig argument to create methods

(WebCore::GLContextEGL::createWindowContext):
(WebCore::GLContextEGL::createPbufferContext):
(WebCore::GLContextEGL::createSurfacelessContext):
(WebCore::GLContextEGL::GLContextEGL):

  • platform/graphics/egl/GLContextEGL.h: Add EGLConfig member
  • platform/graphics/egl/GLContextEGLLibWPE.cpp: initialize m_config

(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::createWPEContext):

  • platform/graphics/egl/GLContextEGLWayland.cpp: initialize m_config

(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::createWaylandContext):

  • platform/graphics/egl/GLContextEGLX11.cpp: initialize m_config

(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::createPixmapContext):

  • platform/xr/openxr/OpenXRExtensions.cpp: Add OpenXRExtensionMethods

(PlatformXR::OpenXRExtensions::loadMethods):

  • platform/xr/openxr/OpenXRExtensions.h:
  • platform/xr/openxr/OpenXRInstance.cpp: Enable graphics related extensions instead of XR_MND_HEADLESS_EXTENSION

(PlatformXR::Instance::Impl::Impl):

  • platform/xr/openxr/OpenXRUtils.h: Forward declare symbols required by openxr_platform.
  • platform/xr/openxr/PlatformXROpenXR.cpp:

(PlatformXR::OpenXRDevice::initializeTrackingAndRendering): Setup XrGraphicsBindingEGLMNDX
(PlatformXR::OpenXRDevice::collectEnabledFeatures): Alternative solution to enumerateReferenceSpaces()
(PlatformXR::OpenXRDevice::collectSupportedSessionModes):
(PlatformXR::OpenXRDevice::resetSession): deallocate graphic resources

  • platform/xr/openxr/PlatformXROpenXR.h:
3:10 AM Changeset in webkit [273548] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.32.90

WebKitGTK 2.31.90

3:09 AM Changeset in webkit [273547] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.32

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.31.90 release

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

  • gtk/NEWS:Add release notes for 2.31.90.
2:11 AM WebKitGTK/2.32.x created by Carlos Garcia Campos
1:47 AM Changeset in webkit [273546] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.32

Branch WebKitGTK for 2.32

1:37 AM Changeset in webkit [273545] by Carlos Garcia Campos
  • 8 edits in trunk

[GTK][WPE] Bump libsoup3 version to 2.99.1
​https://bugs.webkit.org/show_bug.cgi?id=222413

Reviewed by Adrian Perez de Castro.

.:

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:

Source/WebCore:

Use new session getters and setters instead of g_object_get/set.

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setProxySettings):
(WebCore::SoupNetworkSession::setAcceptLanguages):

  • platform/network/soup/SoupVersioning.h:

(soup_session_set_proxy_resolver):
(soup_session_get_proxy_resolver):
(soup_session_set_accept_language):

Source/WTF:

  • wtf/Platform.h: Set minimum required version to 2.99
1:20 AM Changeset in webkit [273544] by Philippe Normand
  • 4 edits
    1 add in trunk/Tools/buildstream

[Flatpak SDK] Add recipe for libsoup3
​https://bugs.webkit.org/show_bug.cgi?id=222419

Reviewed by Carlos Garcia Campos.

LibSoup3 is parallel-installable with libsoup2, for now we want to keep libsoup2 in the SDK,
at least until porting to libsoup3 has progressed enough.

  • elements/sdk-platform.bst:
  • elements/sdk/glib.bst: Bump to latest 2.67 release.
  • elements/sdk/gtk+-3.bst: Bump to latest 3.24 release, not strictly needed but I was driving by.
  • elements/sdk/libsoup3.bst: Added.
1:04 AM Changeset in webkit [273543] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

REGRESSION (r269824): macCatalyst WKWebView shows chunks of other tiles in the middle of content
​https://bugs.webkit.org/show_bug.cgi?id=222460
<rdar://problem/74102753>

Reviewed by Simon Fraser.

  • Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
Reinstate some code that was accidentally deleted in r269824 that ensures
that we do not use an in-use IOSurface as our front buffer, so that
we don't paint into it while it's being composited in the render server.

Also, add some comments, since this code is all a little confusing
with its fronts and backs.

Feb 25, 2021:

10:43 PM Changeset in webkit [273542] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Fix threading issue in ScriptProcessorNode::process()
​https://bugs.webkit.org/show_bug.cgi?id=222447
<rdar://74700526>

Reviewed by Jer Noble.

It was possible for the audio thread (in ScriptProcessorNode::process())
and the main thread (via ScriptProcessorNode::fireProcessEvent()) to
access the same m_inputBuffers / m_outputBuffers concurrently, causing
crashes. The m_processLock was supposed to avoid this. However, the
scope of the locking in ScriptProcessorNode::process() was insufficient
to protect us. ScriptProcessorNode::process() now grabs the lock very
early, before interacting with any buffers and we make sure not to
modify the buffers when we are unable to grab the lock.

Also, to make sure that the m_inputBuffers / m_outputBuffers are modified
by the main thread only during the scope of the fireProcessEvent() function
(during which we hold the processLock), we no longer pass our internal
buffers to the JS process event handler. Instead, we pass new buffers to
JS and memcpy to and from them. While this is less efficient, this is
actually required because the script could store the buffers it is given
and modify them outside the scope of the process event handler.

  • Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::AudioBuffer):
(WebCore::AudioBuffer::topologyMatches const):
(WebCore::AudioBuffer::copyTo const):
(WebCore::AudioBuffer::clone const):

  • Modules/webaudio/AudioBuffer.h:
  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::createInputBufferForJS const):
(WebCore::ScriptProcessorNode::createOutputBufferForJS const):
(WebCore::ScriptProcessorNode::process):
(WebCore::ScriptProcessorNode::fireProcessEvent):

  • Modules/webaudio/ScriptProcessorNode.h:
9:06 PM Changeset in webkit [273541] by Brent Fulgham
  • 4 edits in trunk/Source/WebKit

Serialize NSURLRequest (rather than CFURLRequest) in IPC
​https://bugs.webkit.org/show_bug.cgi?id=222145
<rdar://problem/74500963>

Reviewed by Darin Adler and Alex Christensen.

Tested by existing layout and WebKitAPI tests.

Revise IPC serialization so that NSURLConnection (modern) Cocoa builds serialize the
NSURLRequest object, rather than bridging to CFURLRequest and serializing that. This
ensures that the full set of NSURLRequest features are accurately reconstituted on the
receiving side of the connection.

Because NSURL serialization doesn't handle some encoded parameters properly, we implement
an archiving delegate to archive the URL like we do for CFURL.

  • Shared/Cocoa/ArgumentCodersCocoa.mm:

(-[WKSecureCodingArchivingDelegate archiver:willEncodeObject:]): Added.
(-[WKSecureCodingArchivingDelegate unarchiver:didDecodeObject:]): Added.
(+[WKEncodedURL supportsSecureCoding]): Added.
(-[WKEncodedURL encodeWithCoder:]): Added.
(-[WKEncodedURL initWithCoder:]): Added.
(-[WKEncodedURL initWithURL:]): Added.
(IPC::encodeSecureCodingInternal): Update to use new delegate.
(IPC::decodeSecureCodingInternal): Ditto.
(-[WKSecureCodingFontAttributeNormalizer archiver:willEncodeObject:]): Deleted.

  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::ResourceRequest>::encodePlatformData): Add NSURLRequest encoding.
(IPC::ArgumentCoder<WebCore::ResourceRequest>::decodePlatformData): Add NSURLRequest decoding.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::createSerializableRepresentation): Deleted.
(IPC::extractDictionaryValue): Deleted.
(IPC::createArchiveList): Deleted.
(IPC::createCFURLRequestFromSerializableRepresentation): Deleted.
(IPC::createNSURLRequestFromSerializableRepresentation): Deleted.
(IPC::ArgumentCoder<WebCore::ResourceRequest>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::ResourceRequest>::decodePlatformData): Deleted.

7:58 PM Changeset in webkit [273540] by Lauro Moura
  • 2 edits in trunk/LayoutTests

[GLIB] Gardening a couple crashes

Unreviewed test gardening.

  • platform/glib/TestExpectations:
7:45 PM Changeset in webkit [273539] by mmaxfield@apple.com
  • 5 edits
    2 adds in trunk

Emoji sequences with constituents in the UBLOCK_SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A Unicode block don't get combined properly
​https://bugs.webkit.org/show_bug.cgi?id=222438
<rdar://problem/74382039>

Reviewed by Zalan Bujtas.

Source/WebCore:

Just add UBLOCK_SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A to the list.

We have to do some workarounds because not all versions of ICU include this value.
Luckily, these workarounds are compile-time-only, because we we're only using this value
to compare to a value produced by ICU (not a value we pass into ICU).

Test: fast/text/mending-heart.html

  • platform/text/CharacterProperties.h:

(WebCore::isEmojiGroupCandidate):

LayoutTests:

  • fast/text/mending-heart-expected.txt: Added.
  • fast/text/mending-heart.html: Added.
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
7:40 PM Changeset in webkit [273538] by mmaxfield@apple.com
  • 4 edits in branches/safari-611-branch

Unreviewed, reverting r273390 and r273391.
​https://bugs.webkit.org/show_bug.cgi?id=222449

Didn't fix the extreme test variance, and caused some internal
performance bots to hang during testing

Reverted changesets:

"MotionMark scores are super sensitive to a single long frame"
​https://bugs.webkit.org/show_bug.cgi?id=220847
​https://trac.webkit.org/changeset/273390

"MotionMark scores are super sensitive to a single long frame"
​https://bugs.webkit.org/show_bug.cgi?id=220847
​https://trac.webkit.org/changeset/273391

  • MotionMark/tests/resources/main.js:

(_measureAndResetInterval):
(update):
(start):
(didFinishInterval):
(filterOutOutliers): Deleted.
(registerFrameTime): Deleted.
(intervalHasConcluded): Deleted.

6:52 PM Changeset in webkit [273537] by Alan Coon
  • 7 edits
    1 copy in branches/safari-611-branch/Source/WebKit

Cherry-pick r273452. rdar://problem/74753294

[iOS] Get default value in the UI process for whether synchronous XMLHttpRequest are allowed during unload
​https://bugs.webkit.org/show_bug.cgi?id=222377

Reviewed by Brent Fulgham.

Getting this default value in the UI process instead of in every WebContent process should be a small speedup,
since getting this default value is a bit costly on iOS.

  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode):
  • Shared/WebPageCreationParameters.h:
  • Shared/ios/WebPreferencesDefaultValuesIOS.h: Added.
  • Shared/ios/WebPreferencesDefaultValuesIOS.mm: (WebKit::cachedAllowsRequest): (WebKit::allowsDeprecatedSynchronousXMLHttpRequestDuringUnload): (WebKit::setAllowsDeprecatedSynchronousXMLHttpRequestDuringUnload):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters):
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::m_lastNavigationWasAppBound):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:52 PM Changeset in webkit [273536] by Alan Coon
  • 5 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r273442. rdar://problem/74753214

Regression(r269481) Kugou Music: Can not leave "MV" category after selecting it
​https://bugs.webkit.org/show_bug.cgi?id=222380
<rdar://74602294>

Reviewed by Geoffrey Garen.

The new behavior in r269481 aligns us with the specification and with Blink so I
am adding a linked-on-after to maintain pre-r269481 behavior until Apps get
rebuilt against the new SDK.

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::supportedPropertyNames const):
  • page/Quirks.cpp: (WebCore::Quirks::shouldOmitHTMLDocumentSupportedPropertyNames):
  • page/Quirks.h:
  • platform/cocoa/VersionChecks.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [273535] by Alan Coon
  • 3 edits
    7 adds in branches/safari-611-branch

Cherry-pick r273501. rdar://problem/74760623

[Cocoa] Files from webmfiles.org do not play through MSE
​https://bugs.webkit.org/show_bug.cgi?id=222403
<rdar://74640660>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-webm-vp8-malformed-header.html

As per RFC 6386, each VP8 frame begins with a three-byte (minimum) frame header, with extra
bytes if that preamble indicates that the frame is a keyframe. Files from webmfiles.org (and
others) have valid frame headers for keyframes, but invalid or no header for interframes;
these interframes' headers, when parsed, erroneously report they are keyframes, and thus the
optional extra bytes are parsed, fail parsing, and generate an error.

Rather than drop frames when parsing fails, just assume the frame is an interframe, and
proceed normally.

  • platform/graphics/cocoa/SourceBufferParserWebM.cpp: (WebCore::SourceBufferParserWebM::VideoTrackData::consumeFrameData):

LayoutTests:

  • platform/mac-bigsur/media/media-source/content/test-vp8-malformed-header-manifest.json: Added.
  • platform/mac-bigsur/media/media-source/content/test-vp8-malformed-header.webm: Added.
  • platform/mac-bigsur/media/media-source/media-source-webm-vp8-malformed-header-expected.txt: Added.
  • platform/mac-bigsur/media/media-source/media-source-webm-vp8-malformed-header.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [273534] by Alan Coon
  • 2 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r273499. rdar://problem/74766327

Avoid setting page muted state if unchanged
​https://bugs.webkit.org/show_bug.cgi?id=222395

Reviewed by Brent Fulgham.

Return early in Page::setMuted if muted state did not change.

No new tests, covered by existing tests.

  • page/Page.cpp: (WebCore::Page::setMuted):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [273533] by Alan Coon
  • 11 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r273477. rdar://problem/74766196

Avoid heap allocation for EventContexts
​https://bugs.webkit.org/show_bug.cgi?id=222095
<rdar://problem/74586915>

Reviewed by Simon Fraser.

This patch merges all subclasses of EventContext into itself to avoid heap allocation for each
EventContext in EventPath::m_path. It also merges Node::handleLocalEvents into EventContext's
handleLocalEvents to avoid the extra virtual function call.

No new tests since there should be no observable behavioral differences.

  • dom/EventContext.cpp: (WebCore::EventContext::EventContext): Moved to the header to be inlined. (WebCore::EventContext::handleLocalEvents const): Merged handleLocalEvents of HTMLFormElement and Node. Moved the code to handle related target and touch targets from MouseOrFocusEventContext and TouchEventContext as they have been merged into this class. Also special case dispatching an event on window to preserve the behavior of WindowEventContext. (WebCore::EventContext::initializeTouchLists): Added. Creates TouchList objects. (WebCore::EventContext::isUnreachableNode const): Moved from the header. (WebCore::EventContext::isMouseOrFocusEventContext const): Deleted. (WebCore::EventContext::isTouchEventContext const): Deleted. (WebCore::MouseOrFocusEventContext::MouseOrFocusEventContext): Deleted. (WebCore::MouseOrFocusEventContext::handleLocalEvents const): Deleted. (WebCore::MouseOrFocusEventContext::isMouseOrFocusEventContext const): Deleted. (WebCore::TouchEventContext::TouchEventContext): Deleted. (WebCore::TouchEventContext::handleLocalEvents const): Deleted. (WebCore::TouchEventContext::isTouchEventContext const): Deleted. (WebCore::TouchEventContext::checkReachability const): Deleted. Merged into handleLocalEvents.
  • dom/EventContext.h: (WebCore::EventContext::isMouseOrFocusEventContext const): Now simply checks m_type. (WebCore::EventContext::isTouchEventContext const): Ditto. (WebCore::EventContext::isWindowContext const): Ditto. (WebCore::EventContext::relatedTarget const): Moved from MouseOrFocusEventContext. (WebCore::EventContext::setRelatedTarget): Ditto. (WebCore::EventContext::touchList): Moved from TouchEventContext. (WebCore::m_contextNodeIsFormElement): Added. Caching this state here instead of checking it at every event context during dispatching in EventContext::handleLocalEvents seems to be important to get a speed up in Intel processors. Apple silicons don't seem to be affected by this. (WebCore::m_type): Added. (WebCore::MouseOrFocusEventContext): Deleted. (WebCore::MouseOrFocusEventContext::relatedTarget const): Deleted. (WebCore::TouchEventContext): Deleted. (WebCore::EventContext::EventContext): Moved from cpp file to be inlined here. (WebCore::EventContext::isUnreachableNode const): Moved into cpp as this is only used for asserting shadow DOM related conditions. (WebCore::EventContext::touchList): Renamed from TouchEventContext::touchList. (isType): Deleted.
  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchEvent): Deleted the variant that takes a vector of elements since it's not used anywhere.
  • dom/EventDispatcher.h:
  • dom/EventPath.cpp: (WebCore::WindowEventContext): Deleted. (WebCore::EventPath::EventPath): Avoid calling setRelatedTarget if related target is not a node or the path is empty. These were early return conditions in setRelatedTarget before this patch. (WebCore::EventPath::buildPath): Always create EventContext. Dramatically simplifies the code. (WebCore::EventPath::setRelatedTarget): Moved the early exit to EventPath::EventPath. (WebCore::EventPath::retargetTouch): (WebCore::EventPath::retargetTouchList): (WebCore::EventPath::retargetTouchLists): (WebCore::EventPath::EventPath): Deleted the variant which takes a vector of elements as it's not used anywhere.
  • dom/EventPath.h: (WebCore::EventPath::contextAt const): (WebCore::EventPath::contextAt): (WebCore::EventPath::m_path): Now allocates EventContext in place. The size of the inline buffer has been reduced to 16 entries for EventContext from 32 entries for std::unique_ptr<EventContext> since the former is considerably larger than the latter.
  • dom/Node.cpp: (WebCore::Node::handleLocalEvents): Deleted. Merged into EventContext::handleLocalEvents.
  • dom/Node.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::handleLocalEvents): Ditto.
  • html/HTMLFormElement.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [273532] by Alan Coon
  • 6 edits
    3 adds in branches/safari-611-branch

Cherry-pick r273438. rdar://problem/74753272

Regression(r268700) postMessage changes prototype of basic types
​https://bugs.webkit.org/show_bug.cgi?id=222228
<rdar://problem/74612853>

Reviewed by Geoffrey Garen.

Source/WebCore:

r268700 updated ScriptExecutionContext::globalObject() to call:
WebCore::globalObject(mainThreadNormalWorld(), downcast<Document>(*this).page())
instead of
frame ? frame->script().globalObject(mainThreadNormalWorld()) : nullptr

This was not right for subframes because globalObject() gets the globalObject from
the page's main frame instead of the document's frame.

This patch gets rid of the error-prone WebCore::globalObject() taking in a Page*
and replaces it with one taking in a Frame* to avoid such issues in the future.

Test: fast/dom/Window/postMessage-Object-prototype.html

  • bindings/js/ScriptState.cpp: (WebCore::globalObject):
  • bindings/js/ScriptState.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::globalObject):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::addSelfToGlobalObjectInWorld): (WebCore::InspectorFrontendHost::showContextMenu):

LayoutTests:

Add layout test coverage.

  • fast/dom/Window/postMessage-Object-prototype-expected.txt: Added.
  • fast/dom/Window/postMessage-Object-prototype.html: Added.
  • fast/dom/Window/resources/postMessage-Object-prototype-frame.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [273531] by Alan Coon
  • 3 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r273415. rdar://problem/74763807

Move PostResolutionCallbackDisabler to resolveComputedStyle
​https://bugs.webkit.org/show_bug.cgi?id=222350

Reviewed by Ryosuke Niwa.

It can be constructed and deleted repeatedly in styleForElementIgnoringPendingStylesheets when
resolveComputedStyle calls it in a loop.

  • dom/Document.cpp: (WebCore::Document::styleForElementIgnoringPendingStylesheets):
  • dom/Element.cpp: (WebCore::Element::resolveComputedStyle): (WebCore::Element::resolvePseudoElementStyle):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [273530] by Alan Coon
  • 7 edits
    4 adds in branches/safari-611-branch

Cherry-pick r273385. rdar://problem/74753323

Runtime-disabled CSS features still appear enabled via CSS.supports()
​https://bugs.webkit.org/show_bug.cgi?id=222280
rdar://74595641

Reviewed by Sam Weinig.

Source/WebCore:

When parsing CSS.supports() for a runtime-disabled property, we'd successfully
parse a CSS-wide keyword like "inherit" and report that the property is supported.

We need to explicitly check for runtime-disabled properties.

Tests: css3/color-filters/color-filter-exposed-if-disabled.html

fast/css/scroll-behavior-exposed-if-disabled.html

  • css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::isPropertyRuntimeDisabled const): (WebCore::CSSParserImpl::consumeDeclaration):
  • css/parser/CSSParserImpl.h:

LayoutTests:

  • css3/color-filters/color-filter-exposed-if-disabled-expected.txt: Added. Fails tracked in webkit.org/b/217626
  • css3/color-filters/color-filter-exposed-if-disabled.html: Added.
  • fast/css/overscroll-behavior-invalidate-if-disabled-expected.txt:
  • fast/css/overscroll-behavior-invalidate-if-disabled.html:
  • fast/css/scroll-behavior-exposed-if-disabled-expected.txt: Added.
  • fast/css/scroll-behavior-exposed-if-disabled.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [273529] by Alan Coon
  • 6 edits
    2 adds in branches/safari-611-branch

Cherry-pick r273314. rdar://problem/74753260

aspect-ratio shows in computed style when disabled
​https://bugs.webkit.org/show_bug.cgi?id=222286

Patch by Rob Buis <​rbuis@igalia.com> on 2021-02-23
Reviewed by Simon Fraser.

Source/WebCore:

Make aspect-ratio invisible from style when disabled.

Test: fast/css/aspect-ratio-invalidate-if-disabled.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
  • css/CSSProperties.json:

Tools:

Add support for disabling aspect-ratio in wk1.

  • DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults):

LayoutTests:

Add test.

  • fast/css/aspect-ratio-invalidate-if-disabled-expected.txt: Added.
  • fast/css/aspect-ratio-invalidate-if-disabled.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:51 PM Changeset in webkit [273528] by Alan Coon
  • 8 edits in branches/safari-611-branch/Source

Versioning.

WebKit-7611.1.21

6:45 PM Changeset in webkit [273527] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, reverting r273122 and r273123.
​https://bugs.webkit.org/show_bug.cgi?id=222449

Didn't fix the extreme test variance, and caused some internal
performance bots to hang during testing

Reverted changesets:

"MotionMark scores are super sensitive to a single long frame"
​https://bugs.webkit.org/show_bug.cgi?id=220847
​https://trac.webkit.org/changeset/273122

"MotionMark scores are super sensitive to a single long frame"
​https://bugs.webkit.org/show_bug.cgi?id=220847
​https://trac.webkit.org/changeset/273123

6:31 PM Changeset in webkit [273526] by Peng Liu
  • 2 edits in trunk/Source/WebKit

[GPUP] The GPU Process crashes in WebKit::RemoteLegacyCDMFactoryProxy::getSession() with an assertion failure
​https://bugs.webkit.org/show_bug.cgi?id=222435

Reviewed by Eric Carlson.

Fix an assertion failure on debug bots.

No new tests. Fix crashes on the bots.

  • GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::mediaPlayerCachedKeyForKeyId const):
We should not search the hash table with an empty key (m_legacySession).

6:12 PM Changeset in webkit [273525] by ysuzuki@apple.com
  • 3 edits
    1 add in trunk

[JSC] Fix typo in wasm error message
​https://bugs.webkit.org/show_bug.cgi?id=222444

Reviewed by Saam Barati.

JSTests:

  • wasm/stress/invalid-wasm-header.js: Added.

(assert.throws):

Source/JavaScriptCore:

  • wasm/WasmStreamingParser.cpp:

(JSC::Wasm::StreamingParser::parseModuleHeader):

5:57 PM Changeset in webkit [273524] by sbarati@apple.com
  • 18 edits
    2 adds in trunk

Add some exception checks to the bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=222434
<rdar://69066130>

Reviewed by Yusuke Suzuki.

Source/WebCore:

Test: js/dom/local-storage-exception-checks.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateInvokeIndexedPropertySetter):
(GenerateInvokeNamedPropertySetter):
(GeneratePut):
(GeneratePutByIndex):
(GenerateDefineOwnProperty):

  • bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:

(WebCore::JSTestIndexedSetterNoIdentifier::put):
(WebCore::JSTestIndexedSetterNoIdentifier::putByIndex):
(WebCore::JSTestIndexedSetterNoIdentifier::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:

(WebCore::JSTestIndexedSetterThrowingException::put):
(WebCore::JSTestIndexedSetterThrowingException::putByIndex):
(WebCore::JSTestIndexedSetterThrowingException::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:

(WebCore::JSTestIndexedSetterWithIdentifier::put):
(WebCore::JSTestIndexedSetterWithIdentifier::putByIndex):
(WebCore::JSTestIndexedSetterWithIdentifier::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:

(WebCore::JSTestNamedAndIndexedSetterNoIdentifier::put):
(WebCore::JSTestNamedAndIndexedSetterNoIdentifier::putByIndex):
(WebCore::JSTestNamedAndIndexedSetterNoIdentifier::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:

(WebCore::JSTestNamedAndIndexedSetterThrowingException::put):
(WebCore::JSTestNamedAndIndexedSetterThrowingException::putByIndex):
(WebCore::JSTestNamedAndIndexedSetterThrowingException::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:

(WebCore::JSTestNamedAndIndexedSetterWithIdentifier::put):
(WebCore::JSTestNamedAndIndexedSetterWithIdentifier::putByIndex):
(WebCore::JSTestNamedAndIndexedSetterWithIdentifier::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:

(WebCore::JSTestNamedSetterNoIdentifier::put):
(WebCore::JSTestNamedSetterNoIdentifier::putByIndex):
(WebCore::JSTestNamedSetterNoIdentifier::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:

(WebCore::JSTestNamedSetterThrowingException::put):
(WebCore::JSTestNamedSetterThrowingException::putByIndex):
(WebCore::JSTestNamedSetterThrowingException::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:

(WebCore::JSTestNamedSetterWithIdentifier::put):
(WebCore::JSTestNamedSetterWithIdentifier::putByIndex):
(WebCore::JSTestNamedSetterWithIdentifier::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:

(WebCore::JSTestNamedSetterWithIndexedGetter::put):
(WebCore::JSTestNamedSetterWithIndexedGetter::putByIndex):
(WebCore::JSTestNamedSetterWithIndexedGetter::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:

(WebCore::JSTestNamedSetterWithIndexedGetterAndSetter::put):
(WebCore::JSTestNamedSetterWithIndexedGetterAndSetter::putByIndex):
(WebCore::JSTestNamedSetterWithIndexedGetterAndSetter::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverrideBuiltIns.cpp:

(WebCore::JSTestNamedSetterWithLegacyOverrideBuiltIns::put):
(WebCore::JSTestNamedSetterWithLegacyOverrideBuiltIns::putByIndex):
(WebCore::JSTestNamedSetterWithLegacyOverrideBuiltIns::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp:

(WebCore::JSTestNamedSetterWithLegacyUnforgeableProperties::put):
(WebCore::JSTestNamedSetterWithLegacyUnforgeableProperties::putByIndex):
(WebCore::JSTestNamedSetterWithLegacyUnforgeableProperties::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp:

(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns::put):
(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns::putByIndex):
(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns::defineOwnProperty):

  • bindings/scripts/test/JS/JSTestPluginInterface.cpp:

(WebCore::JSTestPluginInterface::put):
(WebCore::JSTestPluginInterface::putByIndex):

LayoutTests:

  • js/dom/local-storage-exception-checks-expected.txt: Added.
  • js/dom/local-storage-exception-checks.html: Added.
5:53 PM Changeset in webkit [273523] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Ensure MRMediaRemoteSetCanBeNowPlayingApplication is called at least once when we start playing something.
​https://bugs.webkit.org/show_bug.cgi?id=222405

Patch by Jean-Yves Avenard <Jean-Yves Avenard> on 2021-02-25
Reviewed by Eric Carlson.

Manually tested for NowPlaying functionality.

  • platform/NowPlayingManager.cpp:

(WebCore::NowPlayingManager::setNowPlayingInfo):
MediaSessionManagerCocoa::setNowPlayingInfo would have always been called
with false (setAsNowPlayingApplication) when the GPU process was in use.
It needed to be called at least once.
MRMediaRemoteSetCanBeNowPlayingApplication is fairly CPU intensive, so we
ensure we only call it if no content had been played before.

5:02 PM Changeset in webkit [273522] by BJ Burg
  • 37 edits
    4 copies
    1 add in trunk/Source

[Cocoa] Web Inspector: add support for receiving Web Extension events via _WKInspectorExtensionDelegate
​https://bugs.webkit.org/show_bug.cgi?id=222252
<rdar://problem/71206685>

Reviewed by Devin Rousso.

Source/WebCore:

Expose methods that the frontend can call to pass along extension lifecycle events
via the frontend client. Add 'supportsWebExtensions' to allow for feature detection from WebInspectorUI.

  • inspector/InspectorFrontendClient.h:

(WebCore::InspectorFrontendClient::supportsWebExtensions):
(WebCore::InspectorFrontendClient::didShowExtensionTab):
(WebCore::InspectorFrontendClient::didHideExtensionTab):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::supportsWebExtensions):
(WebCore::InspectorFrontendHost::didShowExtensionTab):
(WebCore::InspectorFrontendHost::didHideExtensionTab):

Source/WebInspectorUI:

  • UserInterface/Models/WebInspectorExtension.js: Update comment for namespace change.
  • UserInterface/Views/WebInspectorExtensionTabContentView.js:

(WI.WebInspectorExtensionTabContentView.prototype.attached):
(WI.WebInspectorExtensionTabContentView.prototype.detached):
When an extension tab is shown or hidden, notify the frontend host about the event.

Source/WebKit:

This patch adds support for clients to receive extension lifecycle events. For now this includes
extension tab shown/hidden, but will eventually include page navigations and other events exposed
via Web Extensions API.

This is implemented at the WebKit level via new InspectorFrontendClient methods. This gets piped to
WebInspectorUIExtensionControllerProxy via IPC, which then passes on the event to _WKInspectorExtensionDelegate.

_WKInspectorExtensionDelegate is a delegate of _WKInspectorExtension. It's for receiving lifecycle events, and
is implemented similarly to _WKInspectorDelegate. WebInspectorUIExtensionControllerProxy now keeps a map of
extension API objects so that it can call out to the the appropriate extension API object's client/delegate.

To better handle the situation where client completion handlers may be invoked after the inspector page has been torn down,
switch WebInspectorUIExtensionControllerProxy to be RefCounted instead of std::unique_ptr so that the appropriate
API object can be retrieved in the async IPC reply block. (IPC message receiver code knows how to ref the receiver
if it expects to deliver a response).

Lastly, since this patch introduces InspectorExtensionError at the WebCore level, I decided to move the contents
of InspectorExtensionTypes.h to the Inspector namespace. It made more sense than typing out WebCore::InspectorExtensionError
and the like. As part of this change, the string type aliases Inspector::ExtensionID and Inspector:ExtensionTabID are
now defined in InspectorFrontendClient.h.

  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:

Add generated files for new message receiver.

  • SourcesCocoa.txt:
  • WebKit.xcodeproj/project.pbxproj:

Add new files for inspector extension client/delegate boilerplate classes.

  • Scripts/webkit/messages.py:
  • Shared/InspectorExtensionTypes.h:
  • Shared/InspectorExtensionTypes.cpp:

(Inspector::extensionErrorToString):
(WebKit::inspectorExtensionErrorToString): Deleted.
Move these types and helpers to Inspector namespace.

  • UIProcess/API/APIInspectorExtension.cpp:

(API::InspectorExtension::setClient): Add a client member which is used to call out to _WKInspectorExtensionDelegate.
(API::InspectorExtension::createTab): Fix namespaces.
(API::InspectorExtension::evaluateScript): Fix namespaces.

  • UIProcess/API/APIInspectorExtension.h:
  • UIProcess/API/APIInspectorExtensionClient.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionInternal.h.

(API::InspectorExtensionClient::didShowExtensionTab):
(API::InspectorExtensionClient::didHideExtensionTab):
Added.

  • UIProcess/API/Cocoa/_WKInspector.mm:

(-[_WKInspector registerExtensionWithID:displayName:completionHandler:]):
(-[_WKInspector unregisterExtension:completionHandler:]):
Adjust to new type signature that returns an initialized API::InspectorExtension.

  • UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:

(-[_WKRemoteWebInspectorViewController registerExtensionWithID:displayName:completionHandler:]):
(-[_WKRemoteWebInspectorViewController unregisterExtension:completionHandler:]):
Adjust to new type signature that returns an initialized API::InspectorExtension.

  • UIProcess/API/Cocoa/_WKInspectorExtensionDelegate.h: Added.
  • UIProcess/API/Cocoa/_WKInspectorExtension.h: Add the delegate property and update documentation to mention its intended usage.
  • UIProcess/API/Cocoa/_WKInspectorExtensionInternal.h: Add delegate storage.
  • UIProcess/API/Cocoa/_WKInspectorExtension.mm:

(-[_WKInspectorExtension delegate]):
(-[_WKInspectorExtension setDelegate:]):
Added.

(-[_WKInspectorExtension createTabWithName:tabIconURL:sourceURL:completionHandler:]): Fix namespaces.
(-[_WKInspectorExtension evaluateScript:frameURL:contextSecurityOrigin:useContentScriptContext:completionHandler:]): Fix namespaces.

  • UIProcess/Inspector/Cocoa/InspectorExtensionDelegate.h: Added.
  • UIProcess/Inspector/Cocoa/InspectorExtensionDelegate.mm: Added.

(WebKit::InspectorExtensionDelegate::InspectorExtensionDelegate):
(WebKit::InspectorExtensionDelegate::delegate):
(WebKit::InspectorExtensionDelegate::InspectorExtensionClient::InspectorExtensionClient):
(WebKit::InspectorExtensionDelegate::InspectorExtensionClient::~InspectorExtensionClient):
(WebKit::InspectorExtensionDelegate::InspectorExtensionClient::didShowExtensionTab):
(WebKit::InspectorExtensionDelegate::InspectorExtensionClient::didHideExtensionTab):
Added. This is ObjC-to-C++ bridge code to connect API::InspectorExtensionClient (used by WebInspectorUIExtensionControllerProxy)
to _WKInspectorExtensionDelegate (used by client code).

  • UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.h: Fix namespaces.
  • UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.messages.in: Added.

Make this class an IPC::MessageReceiver. It receives messages for extension lifecycle events.

  • UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp:

(WebKit::WebInspectorUIExtensionControllerProxy::WebInspectorUIExtensionControllerProxy):
(WebKit::WebInspectorUIExtensionControllerProxy::~WebInspectorUIExtensionControllerProxy):
Make this class an IPC::MessageReceiver. It receives messages for extension lifecycle events.

(WebKit::WebInspectorUIExtensionControllerProxy::registerExtension):
Expand this code out so that we can save API::InspectorExtension instances into our own map
before sending it to the completionHandler. This map keeps strong references to the extension
API objects since they need to be used to send events at an arbitrary time in the future.
Previously, they were kept alive (or not) by the API client.

(WebKit::WebInspectorUIExtensionControllerProxy::unregisterExtension):
When the extension is no longer registered, remove the associated extension API object (and
our strong reference to it).

(WebKit::WebInspectorUIExtensionControllerProxy::createTabForExtension): Fix namespaces.
(WebKit::WebInspectorUIExtensionControllerProxy::evaluateScriptForExtension): Fix namespaces.
(WebKit::WebInspectorUIExtensionControllerProxy::didShowExtensionTab):
(WebKit::WebInspectorUIExtensionControllerProxy::didHideExtensionTab):
Added. Try to look up the associated API object for the extension and forward the event to
the client of the API object, which is ultimately _WKInspectorExtensionDelegate.

  • WebProcess/Inspector/RemoteWebInspectorUI.h:
  • WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::supportsWebExtensions):
(WebKit::RemoteWebInspectorUI::didShowExtensionTab):
(WebKit::RemoteWebInspectorUI::didHideExtensionTab):
Added. Defer to the extension controller to handle further event propagation.

  • WebProcess/Inspector/WebInspectorUI.h:
  • WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::supportsWebExtensions):
(WebKit::WebInspectorUI::didShowExtensionTab):
(WebKit::WebInspectorUI::didHideExtensionTab):
Added. Defer to the extension controller to handle further event propagation.

  • WebProcess/Inspector/WebInspectorUIExtensionController.h:
  • WebProcess/Inspector/WebInspectorUIExtensionController.messages.in:

Fix namespaces.

  • WebProcess/Inspector/WebInspectorUIExtensionController.cpp:

(WebKit::WebInspectorUIExtensionController::WebInspectorUIExtensionController):
(WebKit::WebInspectorUIExtensionController::~WebInspectorUIExtensionController):
Be more precise about associating this message receiver with the inspector page's identifier.
Also, save the page identifier so that methods that need to send IPC messages can send
the message to the correct destinationID.

(WebKit::WebInspectorUIExtensionController::parseInspectorExtensionErrorFromEvaluationResult):
(WebKit::WebInspectorUIExtensionController::registerExtension):
(WebKit::WebInspectorUIExtensionController::unregisterExtension):
(WebKit::WebInspectorUIExtensionController::createTabForExtension):
(WebKit::WebInspectorUIExtensionController::evaluateScriptForExtension):
Fix namespaces.

(WebKit::WebInspectorUIExtensionController::didShowExtensionTab):
(WebKit::WebInspectorUIExtensionController::didHideExtensionTab):
Added.

4:25 PM Changeset in webkit [273521] by Alan Coon
  • 7 edits in branches/safari-611-branch/Source

Unreviewed, add missing header includes to address build issues.

Source/WebCore:

  • Modules/webauthn/AuthenticationExtensionsClientOutputs.h:

Source/WebKit:

  • UIProcess/API/Cocoa/WKUserScript.mm:
  • UIProcess/API/Cocoa/_WKInspectorExtension.mm:
  • UIProcess/Cocoa/AutomationClient.mm:
  • UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.h:
3:52 PM Changeset in webkit [273520] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, reverting r273503.
​https://bugs.webkit.org/show_bug.cgi?id=222442

Caused a blob loading failure

Reverted changeset:

"Serialize NSURLRequest (rather than CFURLRequest) in IPC"
​https://bugs.webkit.org/show_bug.cgi?id=222145
​https://trac.webkit.org/changeset/273503

3:46 PM Changeset in webkit [273519] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[BigSur wk1] svg/canvas/canvas-global-alpha-svg.html is flakey failing
​https://bugs.webkit.org/show_bug.cgi?id=221559

Unreviewed test gardening.

Patch by Amir Mark Jr <Amir Mark Jr.> on 2021-02-25

  • platform/mac-wk1/TestExpectations:
3:45 PM Changeset in webkit [273518] by msaboff@apple.com
  • 20 edits
    11 adds
    13 deletes in trunk/JSTests

[test262] test/built-ins/RegExp/match-indices needs updating for 'd' flag
​https://bugs.webkit.org/show_bug.cgi?id=222142

Reviewed by Yusuke Suzuki.

Updated WebKit's copy of Test262 to the latest. All of the changes are related to
the RegExp match indices stage 3 proposal (​https://github.com/tc39/proposal-regexp-match-indices).
Removed the local copies of the built-ins/RegExp/match-indices/ tests now that they
have been merged.

Enabled the testing of the "regexp-match-indices" feature in config.yaml as we pass
all of the associated tests.

  • stress/test262-indices-array-element.js: Removed.
  • stress/test262-indices-array-matched.js: Removed.
  • stress/test262-indices-array-non-unicode-match.js: Removed.
  • stress/test262-indices-array-properties.js: Removed.
  • stress/test262-indices-array-unicode-match.js: Removed.
  • stress/test262-indices-array-unicode-property-names.js: Removed.
  • stress/test262-indices-array-unmatched.js: Removed.
  • stress/test262-indices-array.js: Removed.
  • stress/test262-indices-groups-object-undefined.js: Removed.
  • stress/test262-indices-groups-object-unmatched.js: Removed.
  • stress/test262-indices-groups-object.js: Removed.
  • stress/test262-indices-groups-properties.js: Removed.
  • stress/test262-indices-property.js: Removed.
  • test262/config.yaml:
  • test262/test/built-ins/RegExp/duplicate-flags.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-element.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-matched.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-non-unicode-match.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-properties.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-unicode-match.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-unicode-property-names.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-unmatched.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array.js:
  • test262/test/built-ins/RegExp/match-indices/indices-groups-object-undefined.js:
  • test262/test/built-ins/RegExp/match-indices/indices-groups-object-unmatched.js:
  • test262/test/built-ins/RegExp/match-indices/indices-groups-object.js:
  • test262/test/built-ins/RegExp/match-indices/indices-groups-properties.js:
  • test262/test/built-ins/RegExp/match-indices/indices-property.js:
  • test262/test/built-ins/RegExp/match-indices/no-indices-array.js: Added.
  • test262/test/built-ins/RegExp/prototype/flags/coercion-hasIndices.js: Added.

(get Object):
(assert.sameValue.get call):

  • test262/test/built-ins/RegExp/prototype/flags/get-order.js:

(re.get hasIndices):

  • test262/test/built-ins/RegExp/prototype/flags/rethrow.js:

(get Object):

  • test262/test/built-ins/RegExp/prototype/flags/return-order.js:
  • test262/test/built-ins/RegExp/prototype/flags/this-val-regexp.js:
  • test262/test/built-ins/RegExp/prototype/hasIndices: Added.
  • test262/test/built-ins/RegExp/prototype/hasIndices/cross-realm.js: Added.
  • test262/test/built-ins/RegExp/prototype/hasIndices/length.js: Added.
  • test262/test/built-ins/RegExp/prototype/hasIndices/name.js: Added.
  • test262/test/built-ins/RegExp/prototype/hasIndices/prop-desc.js: Added.
  • test262/test/built-ins/RegExp/prototype/hasIndices/this-val-invalid-obj.js: Added.
  • test262/test/built-ins/RegExp/prototype/hasIndices/this-val-non-obj.js: Added.
  • test262/test/built-ins/RegExp/prototype/hasIndices/this-val-regexp-prototype.js: Added.
  • test262/test/built-ins/RegExp/prototype/hasIndices/this-val-regexp.js: Added.
3:31 PM Changeset in webkit [273517] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[ macOS BigSur Wk2 ] http/tests/media/hls/hls-hdr-switch.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=222425

Unreviewed test gardening.

Patch by Robert Jenner <Robert Jenner> on 2021-02-25

  • platform/mac/TestExpectations: Updating test expectations as Timeout until changes made in r272842 are fully resolved.
3:25 PM Changeset in webkit [273516] by dino@apple.com
  • 15 edits in trunk/Source/ThirdParty/ANGLE

Fix crashes in fast/canvas/webgl/texImage video tests
Refactor IOSurfaceSurfaceMtl to match open source implementation.
Additional cleanup

​https://bugs.webkit.org/show_bug.cgi?id=222331

Patch by Kyle Piddington <Kyle Piddington> on 2021-02-25
Reviewed by Dean Jackson.

  • src/libANGLE/renderer/metal/ContextMtl.h:
  • src/libANGLE/renderer/metal/ContextMtl.mm:

(rx::ContextMtl::onBackbufferResized):

  • src/libANGLE/renderer/metal/DisplayMtl.mm:

(rx::DisplayMtl::createPbufferSurface):
(rx::DisplayMtl::createPbufferFromClientBuffer):

  • src/libANGLE/renderer/metal/FrameBufferMtl.h:

(rx::FramebufferMtl::getAttachedBackbuffer const):

  • src/libANGLE/renderer/metal/FrameBufferMtl.mm:

(rx::FramebufferMtl::FramebufferMtl):

  • src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.h:
  • src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm:

(rx::IOSurfaceSurfaceMtl::IOSurfaceSurfaceMtl):
(rx::IOSurfaceSurfaceMtl::~IOSurfaceSurfaceMtl):
(rx::IOSurfaceSurfaceMtl::bindTexImage):
(rx::IOSurfaceSurfaceMtl::releaseTexImage):
(rx::IOSurfaceSurfaceMtl::getAttachmentRenderTarget):
(rx::IOSurfaceSurfaceMtl::ensureColorTextureCreated):
(rx::IOSurfaceSurfaceMtl::ValidateAttributes):

  • src/libANGLE/renderer/metal/SurfaceMtl.h:

(rx::SurfaceMtl::getColorTexture):
(rx::SurfaceMtl::getSamples const):
(rx::SurfaceMtl::hasRobustResourceInit const):
(rx::WindowSurfaceMtl::preserveBuffer const):

  • src/libANGLE/renderer/metal/SurfaceMtl.mm:

(rx::SurfaceMtl::SurfaceMtl):

  • src/libANGLE/renderer/metal/TextureMtl.h:
  • src/libANGLE/renderer/metal/TextureMtl.mm:

(rx::TextureMtl::ensureTextureCreated):
(rx::TextureMtl::ensureSamplerStateCreated):
(rx::TextureMtl::bindTexImage):
(rx::TextureMtl::releaseTexImage):
(rx::TextureMtl::getAttachmentRenderTarget):

  • src/libANGLE/renderer/metal/mtl_common.h:
3:20 PM Changeset in webkit [273515] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source

Add stubs to enable SafariForWebKitDevelopment to launch
​https://bugs.webkit.org/show_bug.cgi?id=222388

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-02-25
Source/JavaScriptCore:

Reviewed by Myles Maxfield.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/SymbolStubsForSafariCompatibility.mm: Added.

(WTF::String::String):
(WTF::JSONImpl::ObjectBase::getArray const):
(WTF::JSONImpl::ObjectBase::getValue const):
(WTF::JSONImpl::ObjectBase::getObject const):
(Inspector::BackendDispatcher::sendResponse):

Source/WebKit:

Reviewed by Myles Maxfield.

I manually verified that before this change, DYLD won't let it launch or it calls a missing selector,
but after this change it launches and loads web pages.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _inspectorDelegate]):
(-[WKWebView _setInspectorDelegate:]):

Source/WTF:

Reviewed by Myles Maxfield

  • wtf/PlatformHave.h:
  • wtf/text/WTFString.h:
  • wtf/text/cocoa/StringCocoa.mm:

(WTF::String::String):

2:47 PM Changeset in webkit [273514] by Truitt Savell
  • 2 edits in trunk/LayoutTests

REGRESSION (r273461): [ macOS ] imported/w3c/web-platform-tests/media-source/mediasource-duration.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=222422

Unreviewed test gardening.

Patch by Robert Jenner <Robert Jenner> on 2021-02-25

  • platform/mac/TestExpectations: Updating test expectations to include slow to determine if changes caused a regression or actually made the test better.
2:14 PM Changeset in webkit [273513] by jer.noble@apple.com
  • 4 edits
    4 adds in trunk

[Cocoa] Appending a partial segment of a WebM audio file results in no additional samples
​https://bugs.webkit.org/show_bug.cgi?id=222407
<rdar://74610383>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-webm-vorbis-partial.html

When appending a partial WebM segment, it can occur that the parser is mid-way through
parsing a Block or SimpleBlock, and is waiting for enough data to be appended to construct a
full sample. However, previous appends are not accounted for when calculated the amount of
data to be requested from the reader, which both results in too much data read and a
miscalculation of the bytesRemaining out-param. This causes all subsequent appends to
generate no samples, leading to an apparent stall in playback.

Add a new ivar to track the number of partial bytes read, and use that value to calculate
the number of bytes yet to be parsed.

  • platform/graphics/cocoa/SourceBufferParserWebM.cpp:

(WebCore::SourceBufferParserWebM::VideoTrackData::createSampleBuffer):

  • platform/graphics/cocoa/SourceBufferParserWebM.h:

LayoutTests:

  • platform/mac-bigsur/media/media-source/content/test-48kHz-vorbis-manifest.json: Added.
  • platform/mac-bigsur/media/media-source/content/test-48kHz-vorbis.webm: Added.
  • platform/mac-bigsur/media/media-source/media-source-webm-vorbis-partial-expected.txt: Added.
  • platform/mac-bigsur/media/media-source/media-source-webm-vorbis-partial.html: Added.
2:14 PM Changeset in webkit [273512] by mmaxfield@apple.com
  • 5 edits
    4 adds in trunk

REGRESSION(r269957): Empty font names passed to canvas2d cause all text routines to crash
​https://bugs.webkit.org/show_bug.cgi?id=222402
<rdar://problem/72621268>

Reviewed by Darin Adler and Chris Lord.

Source/WebCore:

It looks like it was simply an oversight from that patch. If the font name is empty,
CanvasRenderingContext2D::setFont() will set the font object to one that doesn't have
its internal FontCascadeFonts pointer set.

Tests: fast/text/canvas-font-resolution-2.html

fast/text/canvas-font-resolution.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

  • html/canvas/CanvasRenderingContext2DBase.h:

(WebCore::CanvasRenderingContext2DBase::FontProxy::isPopulated const):

  • style/StyleResolveForFontRaw.cpp:

(WebCore::Style::resolveForFontRaw):

LayoutTests:

  • fast/text/canvas-font-resolution-2-expected.html: Added.
  • fast/text/canvas-font-resolution-2.html: Added.
  • fast/text/canvas-font-resolution-expected.txt: Added.
  • fast/text/canvas-font-resolution.html: Added.
2:10 PM Changeset in webkit [273511] by commit-queue@webkit.org
  • 4 edits in trunk

Make internal ContentFiltering tests not time out after r272293
​https://bugs.webkit.org/show_bug.cgi?id=222437

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-02-25
Reviewed by Andy Estes.

Source/WebCore:

The host "download" is being upgraded from http to https.
We are using that host in our tests. Let's make the open source builds have the same behavior
and let's fix the tests.

  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::makeSecureIfNecessary):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:

(-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]):
(-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]):
(TEST):
(downloadTest):
(loadAlternateTest):

2:09 PM Changeset in webkit [273510] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Update WebContent sandbox to allow it to call task_create_identity_token()
​https://bugs.webkit.org/show_bug.cgi?id=222423

Reviewed by Simon Fraser.

Update WebContent sandbox to allow it to call task_create_identity_token(). We started using
task_create_identity_token() in r273288 and need it for Bug 222391.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • WebProcess/com.apple.WebProcess.sb.in:
2:07 PM Changeset in webkit [273509] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r269359): Sources: the Images folder does not load most images in the main content area
​https://bugs.webkit.org/show_bug.cgi?id=222431
<rdar://problem/74498289>

Reviewed by BJ Burg.

  • UserInterface/Views/MultipleScopeBarItem.js:

(WI.MultipleScopeBarItem.prototype.set scopeBarItems):
(WI.MultipleScopeBarItem.prototype._itemSelectionDidChange):
(WI.MultipleScopeBarItem.prototype.get _visibleScopeBarItems): Deleted.
r269359 made it so that removeEventListener actually throws an error if this doesn't
have any event listeners (it also console.assert if the event/listener is missing).
WI.MultipleScopeBarItem.prototype.set scopeBarItems iterates over all _scopeBarItems
when calling removeEventListener, but only iterates over _visibleScopeBarItems when
adding them, meaning that removeEventListener will be called on objects that did not
have a corresponding addEventListener. Instead, iterate over all _scopeBarItems in
both cases and progressively build up _visibleScopeBarItems (which also avoids the
extra work of filter at the other callsites), ensuring that all items have both an
addEventListener and removeEventListener.

2:03 PM Changeset in webkit [273508] by Alan Coon
  • 2 edits in branches/safari-611-branch/Source/WebKit

Cherry-pick r272203. rdar://problem/74451201

WKASCAuthorizationPresenterDelegate needs to import RunLoop.h and BlockPtr.h
​https://bugs.webkit.org/show_bug.cgi?id=221250

Reviewed by Antti Koivisto.

  • UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@272203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:01 PM Changeset in webkit [273507] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[BigSur wk1] svg/clip-path/resource-clipper-multiple-repaints.html is flakey failing.
​https://bugs.webkit.org/show_bug.cgi?id=221506

Unreviewed test gardening.

Patch by Amir Mark Jr <Amir Mark Jr.> on 2021-02-25

  • platform/mac-wk1/TestExpectations:
1:52 PM Changeset in webkit [273506] by Ruben Turcios
  • 1 copy in tags/Safari-612.1.5

Tag Safari-612.1.5.

1:08 PM Changeset in webkit [273505] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Streamline ImageData size calculations and handle out-of-memory
​https://bugs.webkit.org/show_bug.cgi?id=222340

Reviewed by Geoff Garen.

  • html/ImageData.cpp:

(WebCore::ImageData::dataSize): Added
(WebCore::ImageData::create): Use the dataSize function consistently to compute
the size of the byteArray needed. In the JavaScript-exposed create function, use
tryCreateUninitialized and throw an exception if it fails. Removed an unnecessary
assertion that simply repeats something covered by an if statement just above it.
(WebCore::ImageData::ImageSize): Removed the overload that only takes an IntSize
and allocates a Uint8ClampedArray, moving that into the create function instead.

  • html/ImageData.h: Added dataSize, removed a constructor overload.
1:04 PM Changeset in webkit [273504] by eric.carlson@apple.com
  • 19 edits
    1 add in trunk

[GPUP] Some media-capabilities tests fail when media in GPU Process is enabled
​https://bugs.webkit.org/show_bug.cgi?id=221691
<rdar://problem/74439420>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, this fixes existing tests.

  • Headers.cmake:
  • platform/cocoa/SystemBattery.h:
  • platform/cocoa/SystemBattery.mm:

(WebCore::systemHasBattery):
(WebCore::systemHasAC):
(WebCore::SystemBatteryStatusTestingOverrides::singleton):
(WebCore::SystemBatteryStatusTestingOverrides::setHasBattery):
(WebCore::SystemBatteryStatusTestingOverrides::setHasAC):
(WebCore::SystemBatteryStatusTestingOverrides::setConfigurationChangedCallback):
(WebCore::setOverrideSystemHasBatteryForTesting): Deleted.
(WebCore::setOverrideSystemHasACForTesting): Deleted.

  • platform/graphics/VP9Utilities.h:

(WebCore::ScreenDataOverrides::encode const):
(WebCore::ScreenDataOverrides::decode):
(WebCore::operator==):

  • platform/graphics/cocoa/VP9UtilitiesCocoa.h:
  • platform/graphics/cocoa/VP9UtilitiesCocoa.mm:

(WebCore::VP9TestingOverrides::singleton):
(WebCore::VP9TestingOverrides::setHardwareDecoderDisabled):
(WebCore::VP9TestingOverrides::setVP9ScreenSizeAndScale):
(WebCore::VP9TestingOverrides::setConfigurationChangedCallback):
(WebCore::vp9HardwareDecoderAvailable):
(WebCore::isVP9CodecConfigurationRecordSupported):
(WebCore::validateVPParameters):
(): Deleted.
(WebCore::setOverrideVP9HardwareDecoderDisabledForTesting): Deleted.
(WebCore::setOverrideVP9ScreenSizeAndScaleForTesting): Deleted.
(WebCore::resetOverrideVP9ScreenSizeAndScaleForTesting): Deleted.

  • testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::setSystemHasBatteryForTesting):
(WebCore::Internals::setSystemHasACForTesting):
(WebCore::Internals::setHardwareVP9DecoderDisabledForTesting):
(WebCore::Internals::setVP9ScreenSizeAndScaleForTesting):

Source/WebKit:

  • GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::setMediaOverridesForTesting):

  • GPUProcess/GPUConnectionToWebProcess.h:
  • GPUProcess/GPUConnectionToWebProcess.messages.in:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::updateMediaConfiguration):

  • WebProcess/GPU/GPUProcessConnection.h:
  • WebProcess/GPU/media/MediaOverridesForTesting.h: Added.

(WebKit::MediaOverridesForTesting::encode const):
(WebKit::MediaOverridesForTesting::decode):

  • WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.cpp:

(WebKit::RemoteMediaEngineConfigurationFactory::registerFactory):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setUseGPUProcessForMedia):

LayoutTests:

  • platform/wk2/TestExpectations: Un-skip tests that no longer fail.
12:40 PM Changeset in webkit [273503] by Brent Fulgham
  • 10 edits in trunk

Serialize NSURLRequest (rather than CFURLRequest) in IPC
​https://bugs.webkit.org/show_bug.cgi?id=222145
<rdar://problem/74500963>

Source/WebKit:

Reviewed by Darin Adler and Alex Christensen.

Tested by existing layout and WebKitAPI tests.

Revise IPC serialization so that NSURLConnection (modern) Cocoa builds serialize the
NSURLRequest object, rather than bridging to CFURLRequest and serializing that. This
ensures that the full set of NSURLRequest features are accurately reconstituted on the
receiving side of the connection.

Because NSURL serialization doesn't handle some encoded parameters properly, we implement
an archiving delegate to archive the URL like we do for CFURL.

  • Shared/Cocoa/ArgumentCodersCocoa.mm:

(-[WKSecureCodingArchivingDelegate archiver:willEncodeObject:]): Added.
(-[WKSecureCodingArchivingDelegate unarchiver:didDecodeObject:]): Added.
(+[WKEncodedURL supportsSecureCoding]): Added.
(-[WKEncodedURL encodeWithCoder:]): Added.
(-[WKEncodedURL initWithCoder:]): Added.
(-[WKEncodedURL initWithURL:]): Added.
(IPC::encodeSecureCodingInternal): Update to use new delegate.
(IPC::decodeSecureCodingInternal): Ditto.
(-[WKSecureCodingFontAttributeNormalizer archiver:willEncodeObject:]): Deleted.

  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::ResourceRequest>::encodePlatformData): Add NSURLRequest encoding.
(IPC::ArgumentCoder<WebCore::ResourceRequest>::decodePlatformData): Add NSURLRequest decoding.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::createSerializableRepresentation): Deleted.
(IPC::extractDictionaryValue): Deleted.
(IPC::createArchiveList): Deleted.
(IPC::createCFURLRequestFromSerializableRepresentation): Deleted.
(IPC::createNSURLRequestFromSerializableRepresentation): Deleted.
(IPC::ArgumentCoder<WebCore::ResourceRequest>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::ResourceRequest>::decodePlatformData): Deleted.

Source/WTF:

Reviewed by Darin Adler.

URLWithData does an early return when the leading character in the URL is '/',
signifying a file path. However, URLs of the form "cdn.domain.com" are often
encountered, and RFC 3986 does not prohibit them. We should only do an early
return if the character after the initial '/' is not also '/'.

  • wtf/cocoa/NSURLExtras.mm:

(WTF::URLWithData):

Tools:

Reviewed by Darin Adler and Alex Christensen.

Add a new test to ensure we can successfully load URLs with accented characters,
and to test the updated IPC serialization for NSURLRequest.

  • TestWebKitAPI/Tests/WebKit/A/303/247/303/243o.html: Added.
  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm:

(TEST):

12:31 PM Changeset in webkit [273502] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Web Inspector: List of grid nodes is incomplete in Layout sidebar panel
​https://bugs.webkit.org/show_bug.cgi?id=222364
<rdar://problem/74700960>

Patch by Razvan Caliman <Razvan Caliman> on 2021-02-25
Reviewed by Devin Rousso.

Source/JavaScriptCore:

Update inspector protocol description for CSS domain to mention default value for
layoutContextTypeChangedMode ("observed") and clarify behavior of "all" value.

  • inspector/protocol/CSS.json:

Source/WebCore:

Ensure default value of layoutContextTypeChangedMode is set for InspectorCSSAgent
to recognize the mode change when switching monitor layout contexts of all nodes.

  • inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::reset):

12:26 PM Changeset in webkit [273501] by jer.noble@apple.com
  • 3 edits
    6 adds in trunk

[Cocoa] Files from webmfiles.org do not play through MSE
​https://bugs.webkit.org/show_bug.cgi?id=222403
<rdar://74640660>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-webm-vp8-malformed-header.html

As per RFC 6386, each VP8 frame begins with a three-byte (minimum) frame header, with extra
bytes if that preamble indicates that the frame is a keyframe. Files from webmfiles.org (and
others) have valid frame headers for keyframes, but invalid or no header for interframes;
these interframes' headers, when parsed, erroneously report they are keyframes, and thus the
optional extra bytes are parsed, fail parsing, and generate an error.

Rather than drop frames when parsing fails, just assume the frame is an interframe, and
proceed normally.

  • platform/graphics/cocoa/SourceBufferParserWebM.cpp:

(WebCore::SourceBufferParserWebM::VideoTrackData::consumeFrameData):

LayoutTests:

  • platform/mac-bigsur/media/media-source/content/test-vp8-malformed-header-manifest.json: Added.
  • platform/mac-bigsur/media/media-source/content/test-vp8-malformed-header.webm: Added.
  • platform/mac-bigsur/media/media-source/media-source-webm-vp8-malformed-header-expected.txt: Added.
  • platform/mac-bigsur/media/media-source/media-source-webm-vp8-malformed-header.html: Added.
11:58 AM Changeset in webkit [273500] by Jonathan Bedard
  • 3 edits in trunk/Tools

[build.webkit.org] Stop passing --master-name to run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=222427
<rdar://problem/74750838>

Reviewed by Aakash Jain.

  • CISupport/build-webkit-org/steps.py:

(RunWebKitTests):

  • CISupport/build-webkit-org/steps_unittest.py:

(TestRunWebKitTests.test_success):
(TestRunWebKitTests.test_warnings):
(TestRunWebKitTests.test_failure):
(TestRunWebKitTests.test_unexpected_error):
(TestRunWebKitTests.test_exception):

11:55 AM Changeset in webkit [273499] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

Avoid setting page muted state if unchanged
​https://bugs.webkit.org/show_bug.cgi?id=222395

Reviewed by Brent Fulgham.

Return early in Page::setMuted if muted state did not change.

No new tests, covered by existing tests.

  • page/Page.cpp:

(WebCore::Page::setMuted):

11:42 AM Changeset in webkit [273498] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Crash when playing Dolby Atmos audio tracks with AVAudioTimePitchAlgorithmTimeDomain
​https://bugs.webkit.org/show_bug.cgi?id=222420
<rdar://74612532>

Reviewed by Eric Carlson.

CoreAudio throws an assertion when using the TimeDomain pitch-correction algorithm on tracks
with > 2 channels. To work around this assertion for now, only set the pitch-correction
algorithm when the playbackRate is set to a non 0 or 1 value.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::audioTimePitchAlgorithmForMediaPlayerPitchCorrectionAlgorithm):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setPlayerRate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setPreservesPitch):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setPitchCorrectionAlgorithm):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatusDidChange):

11:09 AM Changeset in webkit [273497] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[ macOS Wk2 ] media/media-fragments/TC0051.html is flakey crashing
​https://bugs.webkit.org/show_bug.cgi?id=222277

Unreviewed test gardening.

Patch by Robert Jenner <Robert Jenner> on 2021-02-25

  • platform/mac-wk2/TestExpectations: Skipping 3 mediacapture-record tests, and marking 1 as Pass Failure due to tests causing other tests to crash.
11:05 AM Changeset in webkit [273496] by Jonathan Bedard
  • 6 edits in trunk/Tools

[ews-build.webkit.org] Compute identifiers locally
​https://bugs.webkit.org/show_bug.cgi?id=222370
<rdar://problem/74704298>

Reviewed by Aakash Jain.

  • CISupport/ews-build/factories.py:

(Factory.init): Add FetchBranches.
(StyleFactory.init): Ditto.
(WatchListFactory.init): Ditto.

  • CISupport/ews-build/factories_unittest.py: Add FetchBranches.
  • CISupport/ews-build/loadConfig.py:

(loadBuilderConfig): Remove GitHub credentials.

  • CISupport/ews-build/steps.py:

(FetchBranches): Added.
(ShowIdentifier.start): Construct identifier locally.

  • CISupport/ews-build/steps_unittest.py:
10:37 AM Changeset in webkit [273495] by Ryan Haddad
  • 6 edits in trunk/Tools

Unreviewed, reverting r273488.
​https://bugs.webkit.org/show_bug.cgi?id=222426

Landed before necessary buildbot change.

Reverted changeset:

"[run-webkit-tests] Delete old results server code"
​https://bugs.webkit.org/show_bug.cgi?id=222393
​https://trac.webkit.org/changeset/273488

Patch by Commit Queue <​commit-queue@webkit.org> on 2021-02-25

10:32 AM Changeset in webkit [273494] by Chris Gambrell
  • 23 edits
    10 adds
    10 deletes in trunk/LayoutTests

[LayoutTests] Convert http/tests/contentdispositionattachmentsandbox convert PHP to Python
​https://bugs.webkit.org/show_bug.cgi?id=221966
<rdar://problem/74393682>

Reviewed by Jonathan Bedard.

  • http/tests/contentdispositionattachmentsandbox/at-import-stylesheets-disabled-expected.txt:
  • http/tests/contentdispositionattachmentsandbox/at-import-stylesheets-disabled.html:
  • http/tests/contentdispositionattachmentsandbox/cross-origin-frames-disabled-expected.txt:
  • http/tests/contentdispositionattachmentsandbox/cross-origin-frames-disabled.html:
  • http/tests/contentdispositionattachmentsandbox/external-stylesheets-disabled-expected.txt:
  • http/tests/contentdispositionattachmentsandbox/external-stylesheets-disabled.html:
  • http/tests/contentdispositionattachmentsandbox/form-submission-disabled-expected.txt:
  • http/tests/contentdispositionattachmentsandbox/form-submission-disabled.html:
  • http/tests/contentdispositionattachmentsandbox/http-equiv-disabled.html:
  • http/tests/contentdispositionattachmentsandbox/plugins-disabled.html:
  • http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html:
  • http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html:
  • http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html:
  • http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html:
  • http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html:
  • http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html:
  • http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html:
  • http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html:
  • http/tests/contentdispositionattachmentsandbox/resources/at-import-stylesheets-frame.php: Removed.
  • http/tests/contentdispositionattachmentsandbox/resources/at-import-stylesheets-frame.py: Added.
  • http/tests/contentdispositionattachmentsandbox/resources/cross-origin-frames-frame.php: Removed.
  • http/tests/contentdispositionattachmentsandbox/resources/cross-origin-frames-frame.py: Added.
  • http/tests/contentdispositionattachmentsandbox/resources/echo-http-referer.php: Removed.
  • http/tests/contentdispositionattachmentsandbox/resources/echo-http-referer.py: Added.
  • http/tests/contentdispositionattachmentsandbox/resources/external-stylesheets-frame.php: Removed.
  • http/tests/contentdispositionattachmentsandbox/resources/external-stylesheets-frame.py: Added.
  • http/tests/contentdispositionattachmentsandbox/resources/form-submission-frame.php: Removed.
  • http/tests/contentdispositionattachmentsandbox/resources/form-submission-frame.py: Added.
  • http/tests/contentdispositionattachmentsandbox/resources/http-equiv-frame.php: Removed.
  • http/tests/contentdispositionattachmentsandbox/resources/http-equiv-frame.py: Added.
  • http/tests/contentdispositionattachmentsandbox/resources/plugins-frame.php: Removed.
  • http/tests/contentdispositionattachmentsandbox/resources/plugins-frame.py: Added.
  • http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped-frame.php: Removed.
  • http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped-frame.py: Added.
  • http/tests/contentdispositionattachmentsandbox/resources/scripts-frame.php: Removed.
  • http/tests/contentdispositionattachmentsandbox/resources/scripts-frame.py: Added.
  • http/tests/contentdispositionattachmentsandbox/resources/xml-stylesheet-processing-instructions-frame.php: Removed.
  • http/tests/contentdispositionattachmentsandbox/resources/xml-stylesheet-processing-instructions-frame.py: Added.
  • http/tests/contentdispositionattachmentsandbox/scripts-disabled-expected.txt:
  • http/tests/contentdispositionattachmentsandbox/scripts-disabled.html:
  • http/tests/contentdispositionattachmentsandbox/xml-stylesheet-processing-instructions-disabled-expected.txt:
  • http/tests/contentdispositionattachmentsandbox/xml-stylesheet-processing-instructions-disabled.html:
10:24 AM Changeset in webkit [273493] by Said Abou-Hallawa
  • 4 edits
    2 adds in trunk

[GPU Process] Stroke and fill StateChangeFlags should be set exclusively
​https://bugs.webkit.org/show_bug.cgi?id=222379
<rdar://problem/73610005>

Reviewed by Simon Fraser.

Source/WebCore:

When the stroke or the fill changes in the GraphicsContextState, we need
to clear the old stroke or fill flags.

Test: fast/canvas/stroke-text-after-gradient-fill-change.html

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContextStateChange::accumulate):

  • platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::SetState::encode const):
(WebCore::DisplayList::SetState::decode):

LayoutTests:

  • fast/canvas/stroke-text-after-gradient-fill-change-expected.txt: Added.
  • fast/canvas/stroke-text-after-gradient-fill-change.html: Added.
10:11 AM Changeset in webkit [273492] by Ryan Haddad
  • 5 edits
    2 deletes in trunk

Unreviewed, reverting r273470.

New test is asserting on WK1 and iOS bots

Reverted changeset:

"[css-grid] Do not allow negative heights"
​https://bugs.webkit.org/show_bug.cgi?id=221439
​https://commits.webkit.org/r273470

10:04 AM Changeset in webkit [273491] by Alan Coon
  • 13 edits
    2 adds in branches/safari-611-branch

Cherry-pick r272039. rdar://problem/74451201

[GPUP][MSE] A video element does not fire “canplaythrough” event if SourceBuffer.abort() is called
​https://bugs.webkit.org/show_bug.cgi?id=220964

Reviewed by Jer Noble.

Source/WebCore:

This patch removes initializationSegmentIsHandledSemaphore from both SourceBufferParserAVFObjC
and SourceBufferParserWebM, and implements a media sample cache mechanism in SourceBufferPrivateAVFObjC
to ensure that "Coded Frame Processing" steps execute after SourceBufferPrivate has handled the
initialization segment and enabled video/audio tracks. Without the cache mechanism, some media
samples following the initialization segment may be dropped when we run SourceBufferPrivateAVFObjC
in the GPU process, and the media element won't fire "canplaythrough" event because it cannot change
its ready state to a value greater than HAVE_METADATA.

This patch also implements the mechanism to make sure SourceBufferPrivateAVFObjC::appendCompleted()
runs after all media samples have gone through the "Coded Frame Processing" steps, so that the source
buffer object will fire "update" and "updateend" event after the parser has completedly parsed the
appended buffer.

  • platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm: (WebCore::SourceBufferParserAVFObjC::SourceBufferParserAVFObjC): (WebCore::SourceBufferParserAVFObjC::~SourceBufferParserAVFObjC): (WebCore::SourceBufferParserAVFObjC::appendData): Add a parameter "CompletionHandler" to notify the caller that the parser has parsed the whole buffer. (WebCore::SourceBufferParserAVFObjC::flushPendingMediaData): (WebCore::SourceBufferParserAVFObjC::resetParserState): (WebCore::SourceBufferParserAVFObjC::invalidate): (WebCore::SourceBufferParserAVFObjC::didParseStreamDataAsAsset):
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC): (WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC): (WebCore::SourceBufferPrivateAVFObjC::didParseInitializationData): After SourceBufferPrivateClient has done the configuration with the initialization segment, we need to push the cached media samples (if any) to SourceBufferPrivate to run the "Coded Frame Processing" steps. And we need to call "appendCompleted()" if there is a pending callback. (WebCore::SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackId): SourceBufferPrivateAVFObjC needs to cache the media sample if the initialization segment has not been processed by SourceBufferPrivateClient yet. (WebCore::SourceBufferPrivateAVFObjC::append): We need to postpone the "appendCompleted()" callback if there are cached media samples. (WebCore::SourceBufferPrivateAVFObjC::appendCompleted): (WebCore::SourceBufferPrivateAVFObjC::abort): (WebCore::SourceBufferPrivateAVFObjC::setVideoLayer): (WebCore::SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackID): Deleted.
  • platform/graphics/cocoa/SourceBufferParser.h:
  • platform/graphics/cocoa/SourceBufferParserWebM.cpp: (WebCore::SourceBufferParserWebM::SourceBufferParserWebM): (WebCore::SourceBufferParserWebM::~SourceBufferParserWebM): (WebCore::SourceBufferParserWebM::appendData): (WebCore::SourceBufferParserWebM::flushPendingMediaData): (WebCore::SourceBufferParserWebM::resetParserState): (WebCore::SourceBufferParserWebM::invalidate): (WebCore::SourceBufferParserWebM::OnClusterBegin):
  • platform/graphics/cocoa/SourceBufferParserWebM.h:

Source/WebKit:

  • Shared/mac/MediaFormatReader/MediaFormatReader.cpp: (WebKit::MediaFormatReader::parseByteSource):

LayoutTests:

  • gpu-process/TestExpectations:
  • media/media-source/media-source-webm-append-buffer-after-abort-expected.txt: Added.
  • media/media-source/media-source-webm-append-buffer-after-abort.html: Added.
  • platform/mac/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@272039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:04 AM Changeset in webkit [273490] by Alan Coon
  • 1 edit in branches/safari-611-branch/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm

Unreviewed build fix. rdar://problem/74410251

Sources/WebKit2/UIProcess/mac/WebPageProxyMac.mm:713:2: error: #endif without #if

9:34 AM Changeset in webkit [273489] by Truitt Savell
  • 7 edits in trunk/Source

Unreviewed, reverting r273462.

Caused API build failures

Reverted changeset:

"[iOS] Reduce use of retain/release in WAKWindow and remove
unneeded methods from that class"
​https://bugs.webkit.org/show_bug.cgi?id=222330
​https://commits.webkit.org/r273462

9:29 AM Changeset in webkit [273488] by Jonathan Bedard
  • 6 edits in trunk/Tools

[run-webkit-tests] Delete old results server code
​https://bugs.webkit.org/show_bug.cgi?id=222393
<rdar://problem/74722220>

Rubber-stamped by Alexey Proskuryakov.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._end_test_run): Remove upload code.
(Manager._save_json_files): Renamed from _upload_json_files.
(Manager._upload_json_files): Renamed to _save_json_files.
(Manager.upload_results): Deleted.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator.init): Remove buildbot arguments.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGenerator):
(JSONResultsGenerator.init): Remove buildbot arguments.
(JSONResultsGenerator.get_json): Remove concept of builder.
(JSONResultsGenerator.upload_json_files): Deleted.
(JSONResultsGenerator._get_svn_revision): Deleted.
(JSONResultsGenerator._get_archived_json_results): Deleted.
(JSONResultsGenerator._insert_generic_metadata): Deleted.
(JSONResultsGenerator._convert_json_to_current_version): Deleted.
(JSONResultsGenerator._convert_tests_to_trie): Deleted.
(JSONResultsGenerator._remove_items_over_max_number_of_builds): Deleted.
(JSONResultsGenerator._normalize_results_json): Deleted.
(JSONResultsGenerator._is_results_all_of_type): Deleted.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

(JSONGeneratorTest.setUp):
(JSONGeneratorTest._test_json_generation):
(JSONGeneratorTest._verify_json_results):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args): Remove arguments used to upload to old results database.

9:05 AM Changeset in webkit [273487] by Chris Gambrell
  • 2 edits in trunk/Tools

[contributors.json] Adding Chris Gambrell as a contributor
​https://bugs.webkit.org/show_bug.cgi?id=222415
<rdar://problem/74741371>

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/config/contributors.json:
9:03 AM Changeset in webkit [273486] by Lauro Moura
  • 2 edits in trunk/Source/WebCore

Unreviewed. GLib debug buildfix after r273477

  • dom/EventContext.cpp:

(WebCore::EventContext::handleLocalEvents const):

8:50 AM Changeset in webkit [273485] by pvollan@apple.com
  • 3 edits in trunk/Source/WebKit

Temporarily stop enforcing notification filtering
​https://bugs.webkit.org/show_bug.cgi?id=222386
<rdar://problem/73987767>

Reviewed by Brent Fulgham.

Temporarily stop enforcing notification filtering on macOS and iOS.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • WebProcess/com.apple.WebProcess.sb.in:
7:06 AM Changeset in webkit [273484] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk/Source

Unreviewed, reverting r273469.
​https://bugs.webkit.org/show_bug.cgi?id=222417

Broke 30+ debug layout tests

Reverted changeset:

"Add stubs to enable SafariForWebKitDevelopment to launch"
​https://bugs.webkit.org/show_bug.cgi?id=222388
​https://trac.webkit.org/changeset/273469

7:06 AM Changeset in webkit [273483] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] Adwaita controls have glitchy corners
​https://bugs.webkit.org/show_bug.cgi?id=222414

When drawing 2 rounded rectangles of different size within each other, the inner rectangle
should have a smaller corner radius, matching the offset. For example, if we draw a button
with a 1px border via 2 rectangles, the inner rectangle should have 1px smaller radius to
prevent the corners from looking thicker than they should be.

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2021-02-25
Reviewed by Carlos Garcia Campos.

  • platform/adwaita/ThemeAdwaita.cpp:

(WebCore::ThemeAdwaita::paintCheckbox):
(WebCore::ThemeAdwaita::paintButton):
(WebCore::ThemeAdwaita::paintSpinButton):

  • rendering/RenderThemeAdwaita.cpp:

(WebCore::RenderThemeAdwaita::paintTextField):
(WebCore::RenderThemeAdwaita::paintProgressBar):
(WebCore::RenderThemeAdwaita::paintSliderTrack):

7:05 AM Changeset in webkit [273482] by Wenson Hsieh
  • 2 edits in trunk/Source/WebCore

[iOS] Crash in ValidationBubble::show()
​https://bugs.webkit.org/show_bug.cgi?id=221565
<rdar://problem/74360282>

Reviewed by Megan Gardner.

Fixes the crash by turning the raw ObjC id m_presentingViewController on ValidationBubble into a
WeakObjCPtr instead, such that failure to initialize the member underneath ValidationBubble::setAnchorRect
won't cause undefined behavior.

In theory, this scenario is already exercised by the existing API test
FormValidation.PresentingFormValidationUIWithoutViewControllerDoesNotCrash, though it may not be crashing
with enough frequency to have resulted in a documented test failure, due to the uninitialized id frequently
turning out to be nil anyways.

  • platform/ValidationBubble.h:
6:39 AM Changeset in webkit [273481] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, WPE/GTK build warning fix after r273311

  • platform/graphics/gstreamer/eme/CDMThunder.cpp:

(WebCore::CDMFactoryThunder::supportedKeySystems const): Use size_t format specifier in logging statement.

1:48 AM Changeset in webkit [273480] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix signed vs unsigned comparision warning in JSBigInt
​https://bugs.webkit.org/show_bug.cgi?id=222400

Patch by Dmitry Bezhetskov <dbezhetskov> on 2021-02-25
Reviewed by Yusuke Suzuki.

Fix the warning about comparing uint64_t with int64_t in JSBigInt.

  • runtime/JSBigInt.cpp:

(JSC::JSBigInt::parseInt):

1:02 AM Changeset in webkit [273479] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

Avoid tree traversals to look for form and canvas elements
​https://bugs.webkit.org/show_bug.cgi?id=222159
<rdar://problem/74680265>

Reviewed by Simon Fraser.

This patch introduces a fast path for checking if an element has a canvas or a form as an ancestor
using new node flags, InclusiveAncestorStateForForm and InclusiveAncestorStateForCanvas.
We update these flags in Element::insertedIntoAncestor and Element::removedFromAncestor based on
the same node flags set on its new parent (clear if there is no parent).

HTMLFormElement and HTMLCanvasElement always add their respective flag (but never clear others)
inside their constructors and after calling Element's insertedIntoAncestor and removedFromAncestor.
Because notifyChildNodeInserted and notifyChildNodeRemoved traverse the newly inserted or newly
removed nodes in tree order, all its descendants will carry over the flag.

For convenience and code readability, we use OptionSet<Node::AncestorState> to represent
the node tree ancestory state of these elements.

No new tests since there should be no behavioral differences.

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::notifyNodeInsertedIntoDocument):
(WebCore::notifyNodeInsertedIntoTree):
(WebCore::notifyChildNodeInserted):
(WebCore::notifyNodeRemovedFromDocument):
(WebCore::notifyNodeRemovedFromTree):
(WebCore::notifyChildNodeRemoved):

  • dom/Element.cpp:

(WebCore::Element::isFocusable const): Optimized this function by avoiding the ancestor tree walk
when inclusiveAncestorStates() does not contain AncestorState::Canvas.
(WebCore::Element::insertedIntoAncestor): Clear or set new node flags based on the ancestor states.
(WebCore::Element::removedFromAncestor): Ditto.

  • dom/Node.h:

(WebCore::Node::delegatesFocusToShadowRoot const): Added.
(WebCore::Node::setDelegatesFocusToShadowRoot): Added.
(WebCore::Node::inclusiveAncestorStates const): Added.
(WebCore::Node::setInclusiveAncestorStates): Added.
(WebCore::Node::addInclusiveAncestorState): Added. Used by HTMLCanvasElement and HTMLFormElement
to set the respective node flags.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isKeyboardFocusable const): Added the same optimization as Element.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement): Set InclusiveAncestorStateForCanvas.
(WebCore::HTMLCanvasElement::insertedIntoAncestor): Ditto. Note that we must do this after calling
Element::insertedIntoAncestor as it can unset this flag (this is the point of this code).
Also note that Element::insertedIntoAncestor will always return InsertedIntoAncestorResult::Done.
(WebCore::HTMLCanvasElement::removedFromAncestor): Ditto for removal.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::HTMLFormElement): Ditto for InclusiveAncestorStateForForm.
(WebCore::HTMLFormElement::insertedIntoAncestor): Ditto.
(WebCore::HTMLFormElement::removedFromAncestor): Ditto.
(WebCore::HTMLFormElement::findClosestFormAncestorSlowCase): Renamed from findClosestFormAncestor.
Optimized this function a bit by avoiding the tree walk when the starting element itself is a form
since InclusiveAncestorStateForForm is always set on the element in that case.

  • html/HTMLFormElement.h:

(WebCore::HTMLFormElement::findClosestFormAncestor): Added the optimized version inlined here.
It exits early with nullptr if InclusiveAncestorStateForForm is not set.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::insertedIntoAncestor): Call Element::insertedIntoAncestor before calling
findClosestFormAncestor to find the form element to associate this image element with as it now
relies on InclusiveAncestorStateForForm flag which is updated in Element::insertedIntoAncestor.

12:31 AM Changeset in webkit [273478] by graouts@webkit.org
  • 4 edits in trunk

border-image-outset doesn't handle float values
​https://bugs.webkit.org/show_bug.cgi?id=222389

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Pass an extra 28 WPT tests for border-image-outset.

  • web-platform-tests/css/css-backgrounds/animations/border-image-outset-interpolation-expected.txt:

Source/WebCore:

We would get the int values rather than float values for the CSSValue created while parsing
the border-image-outset property.

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapNinePieceImageQuad):

12:30 AM Changeset in webkit [273477] by rniwa@webkit.org
  • 11 edits in trunk/Source/WebCore

Avoid heap allocation for EventContexts
​https://bugs.webkit.org/show_bug.cgi?id=222095
<rdar://problem/74586915>

Reviewed by Simon Fraser.

This patch merges all subclasses of EventContext into itself to avoid heap allocation for each
EventContext in EventPath::m_path. It also merges Node::handleLocalEvents into EventContext's
handleLocalEvents to avoid the extra virtual function call.

No new tests since there should be no observable behavioral differences.

  • dom/EventContext.cpp:

(WebCore::EventContext::EventContext): Moved to the header to be inlined.
(WebCore::EventContext::handleLocalEvents const): Merged handleLocalEvents of HTMLFormElement
and Node. Moved the code to handle related target and touch targets from MouseOrFocusEventContext
and TouchEventContext as they have been merged into this class. Also special case dispatching
an event on window to preserve the behavior of WindowEventContext.
(WebCore::EventContext::initializeTouchLists): Added. Creates TouchList objects.
(WebCore::EventContext::isUnreachableNode const): Moved from the header.
(WebCore::EventContext::isMouseOrFocusEventContext const): Deleted.
(WebCore::EventContext::isTouchEventContext const): Deleted.
(WebCore::MouseOrFocusEventContext::MouseOrFocusEventContext): Deleted.
(WebCore::MouseOrFocusEventContext::handleLocalEvents const): Deleted.
(WebCore::MouseOrFocusEventContext::isMouseOrFocusEventContext const): Deleted.
(WebCore::TouchEventContext::TouchEventContext): Deleted.
(WebCore::TouchEventContext::handleLocalEvents const): Deleted.
(WebCore::TouchEventContext::isTouchEventContext const): Deleted.
(WebCore::TouchEventContext::checkReachability const): Deleted. Merged into handleLocalEvents.

  • dom/EventContext.h:

(WebCore::EventContext::isMouseOrFocusEventContext const): Now simply checks m_type.
(WebCore::EventContext::isTouchEventContext const): Ditto.
(WebCore::EventContext::isWindowContext const): Ditto.
(WebCore::EventContext::relatedTarget const): Moved from MouseOrFocusEventContext.
(WebCore::EventContext::setRelatedTarget): Ditto.
(WebCore::EventContext::touchList): Moved from TouchEventContext.
(WebCore::m_contextNodeIsFormElement): Added. Caching this state here instead of checking it at
every event context during dispatching in EventContext::handleLocalEvents seems to be important
to get a speed up in Intel processors. Apple silicons don't seem to be affected by this.
(WebCore::m_type): Added.
(WebCore::MouseOrFocusEventContext): Deleted.
(WebCore::MouseOrFocusEventContext::relatedTarget const): Deleted.
(WebCore::TouchEventContext): Deleted.
(WebCore::EventContext::EventContext): Moved from cpp file to be inlined here.
(WebCore::EventContext::isUnreachableNode const): Moved into cpp as this is only used for
asserting shadow DOM related conditions.
(WebCore::EventContext::touchList): Renamed from TouchEventContext::touchList.
(isType): Deleted.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent): Deleted the variant that takes a vector of elements
since it's not used anywhere.

  • dom/EventDispatcher.h:
  • dom/EventPath.cpp:

(WebCore::WindowEventContext): Deleted.
(WebCore::EventPath::EventPath): Avoid calling setRelatedTarget if related target is not a node
or the path is empty. These were early return conditions in setRelatedTarget before this patch.
(WebCore::EventPath::buildPath): Always create EventContext. Dramatically simplifies the code.
(WebCore::EventPath::setRelatedTarget): Moved the early exit to EventPath::EventPath.
(WebCore::EventPath::retargetTouch):
(WebCore::EventPath::retargetTouchList):
(WebCore::EventPath::retargetTouchLists):
(WebCore::EventPath::EventPath): Deleted the variant which takes a vector of elements as it's
not used anywhere.

  • dom/EventPath.h:

(WebCore::EventPath::contextAt const):
(WebCore::EventPath::contextAt):
(WebCore::EventPath::m_path): Now allocates EventContext in place. The size of the inline buffer
has been reduced to 16 entries for EventContext from 32 entries for std::unique_ptr<EventContext>
since the former is considerably larger than the latter.

  • dom/Node.cpp:

(WebCore::Node::handleLocalEvents): Deleted. Merged into EventContext::handleLocalEvents.

  • dom/Node.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::handleLocalEvents): Ditto.

  • html/HTMLFormElement.h:
Note: See TracTimeline for information about the timeline view.