Context Navigation

← Previous Period
Next Period →

Timeline

Apr 12, 2022:

10:38 PM Changeset in webkit [292801] by Chris Dumez

14 edits in trunk/Source/WebCore

Crash under CachedResourceClientWalker<WebCore::CachedImageClient>::next()
https://bugs.webkit.org/show_bug.cgi?id=239253
<rdar://91346216>

Reviewed by Simon Fraser and Brent Fulgham.

I haven't been able to reproduce the issue or figure out why this is happening so I am doing
some hardening and adding assertions to help catch the underlying bug.

loader/ImageLoader.cpp:

(WebCore::ImageLoader::didUpdateCachedImage):
There is some speculation that r291141 could have caused this because of the timing of when
this patch landed and the fact that this patch modifies ImageLoader, which is a CachedImageClient.
I couldn't see anything wrong with the change. However, I did notice that we were calling
didUpdateCachedImage() twice with the same CachedImage now for lazy loading (once initially and then
another time when the image actually starts lazily). This was intentional. However, the registering
again as a client of the CachedImage (and then unregistering right away) was not. Technically, this
should be fine since CachedResource is using a HashCountedSet for m_clients locally. However, for
the sake of safety, I am now not doing this redundant registering/unregistering as a client of
the CachedImage when this image has not changed.

loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::checkNotify):

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::checkNotify):

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::load):
(WebCore::CachedImage::addClientWaitingForAsyncDecoding):
(WebCore::CachedImage::notifyObservers):
(WebCore::CachedImage::canDestroyDecodedData):
(WebCore::CachedImage::imageFrameAvailable):
(WebCore::CachedImage::scheduleRenderingUpdate):
(WebCore::CachedImage::isVisibleInViewport):
(WebCore::CachedImage::isVisibleInViewport const): Deleted.

loader/cache/CachedImage.h:
loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::notifyClientsDataWasReceived):
(WebCore::iterateRedirects):

(WebCore::CachedRawResource::redirectReceived):
The new assertions found a bug here where we were capturing the CachedRawResourceClient by value in the lambda and thus
making a copy of it (even though this is a polymorphic class). I fixed the bug and marked CachedResourceClient as non
copyable to avoid issues like these.

(WebCore::CachedRawResource::responseReceived):
(WebCore::CachedRawResource::shouldCacheResponse):
(WebCore::CachedRawResource::didSendData):
(WebCore::CachedRawResource::finishedTimingForWorkerLoad):
(WebCore::CachedRawResource::previewResponseReceived):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::checkNotify):
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):

loader/cache/CachedResource.h:
loader/cache/CachedResourceClient.h:

(WebCore::CachedResourceClient::~CachedResourceClient):
(WebCore::CachedResourceClient::addAssociatedResource):
(WebCore::CachedResourceClient::removeAssociatedResource):
Add new assertions to make sure that a CachedResourceClient is no longer associated (i.e. marked as a client of) with
any CachedResource at the time it is destroyed. Hopefully, this will catch the issue right away and give us a useful
stack trace, instead of crashing later on when iterating over the clients of a CachedResource.

loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
(WebCore::CachedResourceClientWalker::next):
CachedResourceClientWalker is meant to be a safe way of iterating over the clients of a CachedResource, allowing clients
to unregister themselves as we iterate. However, when clients unregister themselves, it could in theory cause the
CachedResource itself to get destroyed. In such cases, the CachedResourceClientWalker would not be safe since its
m_clientSet data member would come from a dead CachedResource. To address the issue, the walker now keeps a handle to
the cached resource, instead of the reference to the CachedResource's clients set. The handle will ensure the cached
resource stays alive.

loader/cache/CachedScript.cpp:
loader/cache/CachedTextTrack.cpp:

(WebCore::CachedTextTrack::doUpdateBuffer):

loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::checkNotify):

rendering/RenderObject.cpp:

9:58 PM Changeset in webkit [292800] by Wenson Hsieh

19 edits
2 deletes in trunk

Remove support for drawing cropped image overlays when hovering over "Copy Cropped Image"
https://bugs.webkit.org/show_bug.cgi?id=239269

Reviewed by Darin Adler.

Source/WebCore:

Revert <https://trac.webkit.org/r290211> -- the corresponding UI is no longer plan of record.

dom/ImageOverlay.cpp:

(WebCore::ImageOverlay::installImageOverlayStyleSheet):
(WebCore::ImageOverlay::imageOverlayCroppedImageIdentifier): Deleted.
(WebCore::ImageOverlay::imageOverlayCroppedImageBackdropIdentifier): Deleted.
(WebCore::ImageOverlay::CroppedImage::install): Deleted.
(WebCore::ImageOverlay::CroppedImage::CroppedImage): Deleted.
(WebCore::ImageOverlay::CroppedImage::~CroppedImage): Deleted.
(WebCore::ImageOverlay::CroppedImage::setVisibility): Deleted.

dom/ImageOverlay.h:
html/shadow/imageOverlay.css:

(div.image-overlay-data-detector-result):
(img#image-overlay-cropped-image): Deleted.
(div#image-overlay-cropped-image-backdrop): Deleted.

testing/Internals.cpp:

(WebCore::Internals::installCroppedImageOverlay): Deleted.
(WebCore::Internals::uninstallCroppedImageOverlay): Deleted.

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::encode const):
(WebKit::ContextMenuContextData::decode):

Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::hitTestedElementContext const): Deleted.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didDismissContextMenu):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

UIProcess/WebPageProxy.h:
UIProcess/mac/WebContextMenuProxyMac.mm:

(-[WKMenuDelegate menu:willHighlightItem:]): Deleted.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::handleContextMenuCopyCroppedImage):
(WebKit::WebPageProxy::willHighlightContextMenuItem): Deleted.

WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didDismissContextMenu):
(WebKit::WebPage::installCroppedImageOverlay): Deleted.
(WebKit::WebPage::setCroppedImageOverlayVisibility): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

LayoutTests:

fast/images/text-recognition/image-overlay-cropped-image-expected.txt: Removed.
fast/images/text-recognition/image-overlay-cropped-image.html: Removed.

9:27 PM Changeset in webkit [292799] by commit-queue@webkit.org

19 edits
1 add in trunk

Allow Wasm import from a JS Worker module
https://bugs.webkit.org/show_bug.cgi?id=238291

Patch by Asumu Takikawa <asumu@igalia.com> on 2022-04-12
Reviewed by Yusuke Suzuki.

LayoutTests/imported/w3c:

Fixed worker test and updated expectation.

web-platform-tests/wasm/webapi/esm-integration/resources/worker-helper.js:

(export.pm):

web-platform-tests/wasm/webapi/esm-integration/worker-import.tentative-expected.txt:
web-platform-tests/wasm/webapi/esm-integration/worker-import.tentative.html:

Source/WebCore:

Adds new source provider for Wasm module loading when imported via
a JS module running in a Worker. Also adjust how WorkerRunLoop
processes tasks for script module loading. In particular, during
the module parsing phase, Wasm modules schedule async tasks that
need to be run to produce a module record.

When a Wasm module is loaded (via the module loader's module parsing
step), the validation/compilation happens asynchronously and
completion callbacks are run via
DeferredWorkTimer::scheduleWorkSoon, which queues up microtasks
from the VM. These microtasks, however, don't get run in a Worker
run loop during module loading and therefore the Wasm module never
finishes loading.

This is because during non-default modes, the Worker run loop
does not install its set timer callback, and continues to wait for
a task to run (due to infinite timeout). This means the microtask
checkpoint is also not reached, so other microtasks cannot run.
In non-default modes, the run loop also ignores all tasks that were
not installed in that particular mode.

In addition, the Worker event loop cannot run either, as it posts
default mode tasks to the run loop to trigger its operation.

The current patch modifies the run loop to allow the run loop to time
out even in non-default modes if a useTimeout parameter is passed as
true (defaults to false). We set this to true for the Worker module
loading process. It also allows the timer notification callback to
post tasks to non-default run loops.

WebCore.xcodeproj/project.pbxproj:
bindings/js/ScriptBufferSourceProvider.h:

(WebCore::AbstractScriptBufferHolder::~AbstractScriptBufferHolder):

bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::notifyFinished):

bindings/js/WebAssemblyScriptBufferSourceProvider.h: Added.
bindings/js/WebAssemblyScriptSourceCode.h:

(WebCore::WebAssemblyScriptSourceCode::WebAssemblyScriptSourceCode):

workers/ScriptBuffer.cpp:

(WebCore::ScriptBuffer::append):

workers/ScriptBuffer.h:
workers/WorkerEventLoop.cpp:

(WebCore::WorkerEventLoop::scheduleToRun):
(WebCore::WorkerEventLoop::taskMode):

workers/WorkerEventLoop.h:
workers/WorkerOrWorkletGlobalScope.cpp:

(WebCore::WorkerOrWorkletGlobalScope::postTaskForMode):

workers/WorkerOrWorkletGlobalScope.h:
workers/WorkerOrWorkletScriptController.cpp:

(WebCore::WorkerOrWorkletScriptController::loadModuleSynchronously):

workers/WorkerRunLoop.cpp:

(WebCore::ModePredicate::ModePredicate):
(WebCore::ModePredicate::mode const):
(WebCore::ModePredicate::operator() const):
(WebCore::WorkerDedicatedRunLoop::run):
(WebCore::WorkerDedicatedRunLoop::runInDebuggerMode):
(WebCore::WorkerDedicatedRunLoop::runInMode):
(WebCore::WorkerMainRunLoop::runInMode):

workers/WorkerRunLoop.h:
workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::didReceiveData):

9:25 PM Changeset in webkit [292798] by Russell Epstein

3 edits in branches/safari-614.1.10-branch/Source/ThirdParty/libwebrtc

Cherry-pick r292758. rdar://problem/91585769

REGRESSION (r292411): libwebrtc header files aren't installed in system content path
https://bugs.webkit.org/show_bug.cgi?id=239100

Reviewed by Mark Lam.

Restored System Content Path processing for absl and webrtc header files.

Configurations/libabsl.xcconfig:
Configurations/libwebrtc.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:21 PM Changeset in webkit [292797] by Elliott Williams

35 edits in trunk

[Xcode] In open-source builds, disable bitcode in xcconfigs instead of build-webkit
https://bugs.webkit.org/show_bug.cgi?id=239262

Reviewed by Alexey Proskuryakov.

Source/bmalloc:

Configurations/Base.xcconfig:

Source/JavaScriptCore:

Disable bitcode in open-source builds, as WebKit never part of an App
Store submission. This improves support for building WebKit directly
from the workspace.

Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:

Source/ThirdParty/libwebrtc:

Configurations/Base.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:

Source/WebCore/PAL:

Configurations/Base.xcconfig:

Source/WebGPU:

Configurations/Base.xcconfig:

Source/WebInspectorUI:

Configurations/Base.xcconfig:

Source/WebKit:

Configurations/Base.xcconfig:
SwiftOverlay/Configurations/Base.xcconfig:

Source/WebKitLegacy/mac:

Configurations/Base.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:

Tools:

ContentExtensionTester/Configurations/Base.xcconfig:
DumpRenderTree/mac/Configurations/Base.xcconfig:
ImageDiff/cg/Configurations/Base.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
MiniBrowserSwiftUI/Configurations/Base.xcconfig:
MobileMiniBrowser/Configurations/Base.xcconfig:
Scripts/webkitdirs.pm:

(XcodeOptions):

TestWebKitAPI/Configurations/Base.xcconfig:
WebEditingTester/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:
lldb/lldbWebKitTester/Configurations/Base.xcconfig:

8:58 PM Changeset in webkit [292796] by Chris Dumez

14 edits in trunk/Source/WebCore

Use safer downcast<>() for CachedResourceClient subclasses
https://bugs.webkit.org/show_bug.cgi?id=239220

Reviewed by Simon Fraser.

loader/LinkPreloadResourceClients.h:

(WebCore::LinkPreloadImageResourceClient::LinkPreloadImageResourceClient):

loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::didAddClient):

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::didAddClient):

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::didAddClient):
(WebCore::CachedImage::didRemoveClient):

loader/cache/CachedImageClient.h:
loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::didAddClient):

loader/cache/CachedRawResourceClient.h:
loader/cache/CachedResourceClient.h:
loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):

loader/cache/CachedSVGDocumentClient.h:
loader/cache/CachedStyleSheetClient.h:
loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::didAddClient):

8:54 PM Changeset in webkit [292795] by ysuzuki@apple.com

16 edits in trunk/Source/JavaScriptCore

[JSC] Move StructureCache from VM to JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=239044

Reviewed by Saam Barati.

We should have StructureCache per JSGlobalObject since cached structures are tied to some of JSGlobalObject.
This can (1) reduce size of each StructureCache, (2) destroy StructureCache timely at the destruction of
JSGlobalObject, and (3) simplifies JSGlobalObject::haveABadTime handling in the compiler.

bytecode/InternalFunctionAllocationProfile.h:

(JSC::InternalFunctionAllocationProfile::createAllocationStructureFromBase):

bytecode/ObjectAllocationProfileInlines.h:

(JSC::ObjectAllocationProfileBase<Derived>::initializeProfile):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

runtime/InternalFunction.cpp:

(JSC::InternalFunction::createSubclassStructure):

runtime/IteratorOperations.cpp:

(JSC::createIteratorResultObjectStructure):

runtime/JSBoundFunction.cpp:

(JSC::getBoundFunctionStructure):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut):
(JSC::JSGlobalObject::haveABadTime):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::structureCache):

runtime/ObjectConstructor.h:

(JSC::constructEmptyObject):
(JSC::createDataPropertyDescriptorObjectStructure):
(JSC::createAccessorPropertyDescriptorObjectStructure):

runtime/PrototypeKey.h:

(JSC::PrototypeKey::PrototypeKey):
(JSC::PrototypeKey::classInfo const):
(JSC::PrototypeKey::operator== const):
(JSC::PrototypeKey::hash const):
(JSC::PrototypeKey::globalObject const): Deleted.

runtime/StructureCache.cpp:

(JSC::StructureCache::createEmptyStructure):
(JSC::StructureCache::emptyObjectStructureConcurrently):

runtime/StructureCache.h:
runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

8:15 PM Changeset in webkit [292794] by Devin Rousso

21 edits
4 adds in trunk

[Modern Media Controls] allow skipping by durations other than 15s
https://bugs.webkit.org/show_bug.cgi?id=239260
<rdar://problem/91441576>

Reviewed by Eric Carlson.

Source/WebCore:

Modules/modern-media-controls/main.js:
Modules/modern-media-controls/controls/ios-layout-traits.js:

(IOSLayoutTraits.prototype.skipDuration): Added.

Modules/modern-media-controls/controls/layout-traits.js:

(LayoutTraits.prototype.skipDuration): Added.

Modules/modern-media-controls/controls/macos-layout-traits.js:

(MacOSLayoutTraits.prototype.skipDuration): Added.

Modules/modern-media-controls/controls/skip-back-button.js:

(SkipBackButton):

Modules/modern-media-controls/controls/skip-forward-button.js:

(SkipForwardButton):

Modules/modern-media-controls/controls/watchos-layout-traits.js:

(WatchOSLayoutTraits.prototype.skipDuration): Added.

Modules/modern-media-controls/media/skip-back-support.js:

(SkipBackSupport.prototype.buttonWasPressed):

Modules/modern-media-controls/media/skip-forward-support.js:

(SkipForwardSupport.prototype.buttonWasPressed):
Instead of hardcoding the SkipDuration to 15, have the LayoutTraits to define it.

Modules/modern-media-controls/controls/icon-service.js:
Modules/modern-media-controls/images/iOS/SkipBack10.svg: Added.
Modules/modern-media-controls/images/iOS/SkipBack15.svg:
Modules/modern-media-controls/images/iOS/SkipForward10.svg: Added.
Modules/modern-media-controls/images/iOS/SkipForward15.svg:
Modules/modern-media-controls/images/macOS/SkipBack10.svg: Added.
Modules/modern-media-controls/images/macOS/SkipBack15.svg:
Modules/modern-media-controls/images/macOS/SkipForward10.svg: Added.
Modules/modern-media-controls/images/macOS/SkipForward15.svg:
en.lproj/modern-media-controls-localized-strings.js:

Add existing icons for other skip durations.

LayoutTests:

media/modern-media-controls/skip-back-button/skip-back-button.html:
media/modern-media-controls/skip-back-button/skip-back-button-expected.txt:
media/modern-media-controls/skip-forward-button/skip-forward-button.html:
media/modern-media-controls/skip-forward-button/skip-forward-button-expected.txt:

5:38 PM Changeset in webkit [292793] by timothy_horton@apple.com

61 edits in trunk

Adopt "version set"-based linked-on-or-after checks instead of platform-specific ones
https://bugs.webkit.org/show_bug.cgi?id=239054
<rdar://problem/83436715>

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

API/JSTypedArray.cpp:

(isLinkedBeforeTypedArrayLengthQuirk):

API/JSWrapperMap.mm:

(supportsInitMethodConstructors):

API/tests/testapi.cpp:

(TestAPI::promiseDrainDoesNotEatExceptions):

API/tests/testapi.mm:

(testMicrotaskWithFunction):

runtime/JSLock.cpp:

(JSC::JSLock::willReleaseLock):

runtime/ObjectPrototype.cpp:

(JSC::isPokerBros):
Adopt the new naming.

Source/WebCore:

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::allowsLegacyExpandoIndexedProperties):

bindings/js/JSWindowProxy.cpp:

(WebCore::JSWindowProxy::setWindow):

html/MediaElementSession.cpp:

(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback const):

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):

page/Quirks.cpp:

(WebCore::Quirks::needsWeChatScrollingQuirk const):
(WebCore::Quirks::shouldOmitHTMLDocumentSupportedPropertyNames):

page/SecurityOrigin.cpp:

(WebCore::shouldTreatAsUniqueOrigin):

platform/Timer.cpp:

(WebCore::shouldSuppressThreadSafetyCheck):

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::isDotPrefixedForbiddenFont):

platform/network/DataURLDecoder.cpp:

(WebCore::DataURLDecoder::shouldRemoveFragmentIdentifier):

testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::setLinkedOnOrAfterEverythingForTesting):
Adopt the new naming.

Source/WebKit:

Shared/AuxiliaryProcess.h:
Shared/Cocoa/AuxiliaryProcessCocoa.mm:

(WebKit::AuxiliaryProcess::platformInitialize):

Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):

Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::getClientSDKAlignedBehaviors):
(WebKit::XPCServiceInitializerDelegate::getClientSDKVersion): Deleted.
(WebKit::XPCServiceInitializerDelegate::getLinkedOnOrAfterOverride): Deleted.

UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:

(WebKit::ProcessLauncher::launchProcess):
Instead of transmitting the SDK version and override state in the bootstrap
message, just send the computed set of behaviors.

NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::configurationForSessionID):

Shared/Cocoa/CompletionHandlerCallChecker.mm:

(WebKit::shouldThrowExceptionForDuplicateCompletionHandlerCall):

Shared/Cocoa/DefaultWebBrowserChecks.mm:

(WebKit::determineITPState):

Shared/Cocoa/WebKit2InitializeCocoa.mm:

(WebKit::InitializeWebKit2):

Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultPassiveTouchListenersAsDefaultOnDocument):
(WebKit::defaultCSSOMViewScrollingAPIEnabled):
(WebKit::defaultPassiveWheelListenersAsDefaultOnDocument):
(WebKit::defaultWheelEventGesturesBecomeNonBlocking):
(WebKit::defaultOfflineWebApplicationCacheEnabled):

UIProcess/API/C/WKPage.cpp:

(WKPageReload):

UIProcess/API/Cocoa/WKProcessPool.mm:

(+[WKProcessPool _setLinkedOnOrBeforeEverythingForTesting]):
(+[WKProcessPool _setLinkedOnOrAfterEverything]):

UIProcess/API/Cocoa/WKWebView.mm:

(shouldAllowPictureInPictureMediaPlayback):
(shouldAllowSettingAnyXHRHeaderFromFileURLs):
(shouldRequireUserGestureToLoadVideo):
(shouldRestrictBaseURLSchemes):
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setupPageConfiguration:]):
(-[WKWebView reload]):
(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(defaultShouldDecidePolicyBeforeLoadingQuickLookPreview):
(-[WKWebViewConfiguration init]):

UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore init]):

UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _computedObscuredInset]):

UIProcess/API/mac/WKWebViewMac.mm:

(-[WKWebView _web_dragDestinationActionForDraggingInfo:]):

UIProcess/Inspector/mac/WKInspectorViewController.mm:

(-[WKInspectorViewController inspectorWKWebViewReload:]):

UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::hasScrollableOrZoomedMainFrame const):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::makeViewBlankIfUnpaintedSinceLastLoadCommit):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createWebPage):

UIProcess/WebProcessProxy.cpp:

(WebKit::isMainThreadOrCheckDisabled):

UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _shouldUseContextMenus]):
(applicationIsKnownToIgnoreMouseEvents):

UIProcess/ios/WKScrollView.mm:

(-[WKScrollView _systemContentInset]):

UIProcess/ios/WKStylusDeviceObserver.mm:

(-[WKStylusDeviceObserver start]):
(-[WKStylusDeviceObserver stop]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::desktopClassBrowsingRecommended):
Adopt the new naming.

Source/WebKitLegacy/mac:

DefaultDelegates/WebDefaultUIDelegate.mm:

(-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):

Misc/WebDownload.mm:

(shouldCallOnNetworkThread):

Misc/WebIconDatabase.mm:

(+[WebIconDatabase sharedIconDatabase]):

WebView/WebPreferencesDefaultValues.mm:

(WebKit::defaultAllowsPictureInPictureMediaPlayback):
(WebKit::defaultJavaScriptCanOpenWindowsAutomatically):
(WebKit::defaultPassiveTouchListenersAsDefaultOnDocument):
(WebKit::defaultRequiresUserGestureToLoadVideo):
(WebKit::defaultWebSQLEnabled):
(WebKit::defaultShouldRestrictBaseURLSchemes):
(WebKit::defaultShouldConvertInvalidURLsToBlank):
(WebKit::defaultPassiveWheelListenersAsDefaultOnDocument):
(WebKit::defaultWheelEventGesturesBecomeNonBlocking):

WebView/WebView.mm:

(needsLaBanquePostaleQuirks):
Adopt the new naming.

Source/WTF:

Switch to dyld_program_sdk_at_least, which correctly handles SDK
checks for binaries built for one SDK running on another platform
(e.g. iOS apps running on macOS).

Because dyld_program_sdk_at_least is based off more than a simple
integer comparison like our old SDK check, we move it into the
application process, and just transmit the computed behaviors to
subprocesses.

Remove functions that expose/transmit platform-specific SDK versions,
so that usage isn't accidentally reintroduced.

Re-frame the naming of our linked-on-or-after checks as being about
specific behaviors instead of SDK versions.

wtf/Bitmap.h:

(WTF::WordType>::setAll):
Add setAll, which sets all the bits in the Bitmap, like FastBitVector has.
Expose the length of the data in bytes to make transmitting the Bitmap simple.

wtf/cocoa/LanguageCocoa.mm:

(WTF::canMinimizeLanguages):
Adopt the new naming.

wtf/spi/darwin/dyldSPI.h:

Because of the nature of dyld_build_version_t values, we can't forward
declare them. Thus, maintain a fallback to the legacy platform-specific
SDK checks for use when building against the internal SDK, or when
back-deploying to older SDKs that don't yet have values for newer version sets.

wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:

(disableAdditionalSDKAlignedBehaviors):
(WTF::computeSDKAlignedBehaviors):
(WTF::sdkAlignedBehaviorsValue):
(WTF::sdkAlignedBehaviors):
(WTF::setSDKAlignedBehaviors):
(WTF::enableAllSDKAlignedBehaviors):
(WTF::disableAllSDKAlignedBehaviors):
(WTF::linkedOnOrAfterSDKWithBehavior):
(WTF::applicationSDKVersionOverride): Deleted.
(WTF::setApplicationSDKVersion): Deleted.
(WTF::applicationSDKVersion): Deleted.
(WTF::linkedOnOrAfterOverrideValue): Deleted.
(WTF::setLinkedOnOrAfterOverride): Deleted.
(WTF::linkedOnOrAfterOverride): Deleted.
(WTF::linkedOnOrAfter): Deleted.

wtf/cocoa/RuntimeApplicationChecksCocoa.h:

Tools:

TestWebKitAPI/Tests/WTF/Bitmap.cpp:

(TestWebKitAPI::testBitmapCountAfterSetAll):
(TestWebKitAPI::TEST):
Add a test that Bitmap.count() works correctly after Bitmap.setAll(),
because my initial implementation was incorrect for bitmaps where
the total number of bits was not a multiple of the word size.

4:10 PM Changeset in webkit [292792] by Diego Pino Garcia

5 edits in trunk/Tools

[JHBuild] Update ATSPI, GLib and GStreamer libraries
https://bugs.webkit.org/show_bug.cgi?id=239117

Reviewed by Adrian Perez de Castro.

Update several libraries to the same version as their Flatpak
counterparts.

JHBuild dependencies didn't build because ATSPI required a more recent
version of gdbus-codegen, provided by GLib. The patch also fixes
dependencies build in WPE, which required to update several GStreamer
libs. Finally, ATSPI and GLib are added to the minimal dependencies
modules set to make it possible to build with A11y support via ATSPI.

gstreamer/jhbuild.modules:
gtk/jhbuild.modules:
jhbuild/jhbuild-minimal.modules:
wpe/jhbuild.modules:

4:02 PM Changeset in webkit [292791] by Elliott Williams

35 edits in trunk

Reland "[XCBuild] Enable dependency validation by default"
https://bugs.webkit.org/show_bug.cgi?id=238901
<rdar://problem/91379968>

Reviewed by Alexey Proskuryakov.

Addresses two problems that impacted the previous attempt at landing:

Derived Sources scripts which use generated xcfilelists contain
"optional" inputs which are only available in internal builds. These
inputs lead to spurious dependency validation errors. These scripts
are unique in that they run from script-only targets, not as a phase
in one of the project's native targets. So, in open-source builds,
restrict VALIDATE_DEPENDENCIES to only run on native targets.

When building an individual project, and not a workspace, it's
expected that many input dependencies in the build directory will be
missing from XCBuild's graph. Disable dependency validation unless we
_know_ we're building from a workspace, defined as when the
USE_WORKSPACE Make flag or --use-workspace build-webkit flag is
passed.

Makefile.shared: Turn on validation errors when USE_WORKSPACE=YES.

Use a new build setting, WK_VALIDATE_DEPENDENCIES, which is the
"requested" validation level. The actual validation level set in
VALIDATE_DEPENDENCIES may be lower (see above).

Source/bmalloc:

Configurations/DebugRelease.xcconfig: In open-source builds, disable