Sep 9, 2007:

9:56 PM Changeset in webkit [25465] by weinig
  • 1 edit
    2 moves in trunk/LayoutTests

Disable more occasionally failing tests.

  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html-disabled: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html-disabled: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html.
8:32 PM Changeset in webkit [25464] by dsmith
  • 3 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Bug 15148: Poor performance on crazy DOM raytracer

Switch data structures to avoid quadratic behavior.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObjects): Update for ListHashSet (WebCore::RenderBlock::markPositionedObjectsForLayout): Update for ListHashSet (WebCore::RenderBlock::insertPositionedObject): Use ListHashSet to avoid expensive uniqueing (WebCore::RenderBlock::removePositionedObject): Update for ListHashSet (WebCore::RenderBlock::removePositionedObjects): Update for ListHashSet (WebCore::RenderBlock::lowestPosition): Update for ListHashSet (WebCore::RenderBlock::rightmostPosition): Update for ListHashSet (WebCore::RenderBlock::leftmostPosition): Update for ListHashSet (WebCore::RenderBlock::rightBottom): Update for ListHashSet
  • rendering/RenderBlock.h: Change m_positionedObjects from DeprecatedPtrList to ListHashSet
7:08 PM Changeset in webkit [25463] by beidson
  • 2 edits in trunk/WebCore

Rubberstamped by Darin

pthread_main_np() is a Darwin thing, not a Mac thing

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase):
5:05 PM Changeset in webkit [25462] by weinig
  • 5 edits in trunk


Reviewed by Mark Rowe.

Remove 'objC' prefix from methods now in the ObjCController.

  • DumpRenderTree/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController classNameOf:]): (-[ObjCController objectOfClass:]): (-[ObjCController identityIsEqual::]): (-[ObjCController longLongRoundTrip:]): (-[ObjCController unsignedLongLongRoundTrip:]):


Reviewed by Mark Rowe.

Update tests now that the 'objC' prefix is no longer used for methods of the ObjCController.

  • fast/dom/wrapper-classes.html:
  • platform/mac/fast/objc/longlongTest.html:
4:48 PM Known incompatibilities between open-source WebKit and Safari edited by bdash@webkit.org
4:48 PM Known incompatibilities between open-source WebKit and Safari edited by bdash@webkit.org
4:41 PM Changeset in webkit [25461] by weinig
  • 10 edits
    4 adds in trunk


Reviewed by Oliver.

Initial refactor of DumpRenderTree in preparation of making it more platform independent.

  • Move LayoutTestController into its own file.
  • Move Objective-C only functions on LayoutTestController into a new controller called the ObjCController.
  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.m: (displayWebView):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/FrameLoadDelegate.m: (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
  • DumpRenderTree/LayoutTestController.h: Added.
  • DumpRenderTree/LayoutTestController.m: Added. (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController clearBackForwardList]): (-[LayoutTestController setUseDashboardCompatibilityMode:]): (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]): (-[LayoutTestController setCustomPolicyDelegate:]): (-[LayoutTestController keepWebHistory]): (-[LayoutTestController setCallCloseOnWebViews:]): (-[LayoutTestController setCanOpenWindows]): (-[LayoutTestController waitUntilDone]): (-[LayoutTestController waitUntilDoneWatchdogFired]): (-[LayoutTestController notifyDone]): (-[LayoutTestController dumpAsText]): (-[LayoutTestController addFileToPasteboardOnDrag]): (-[LayoutTestController addDisallowedURL:]): (-[LayoutTestController setUserStyleSheetLocation:]): (-[LayoutTestController setUserStyleSheetEnabled:]): (-[LayoutTestController dumpDOMAsWebArchive]): (-[LayoutTestController dumpSourceAsWebArchive]): (-[LayoutTestController dumpSelectionRect]): (-[LayoutTestController dumpTitleChanges]): (-[LayoutTestController dumpBackForwardList]): (-[LayoutTestController windowCount]): (-[LayoutTestController dumpChildFrameScrollPositions]): (-[LayoutTestController dumpChildFramesAsText]): (-[LayoutTestController dumpEditingCallbacks]): (-[LayoutTestController dumpResourceLoadCallbacks]): (-[LayoutTestController dumpFrameLoadCallbacks]): (-[LayoutTestController setWindowIsKey:]): (-[LayoutTestController setMainFrameIsFirstResponder:]): (-[LayoutTestController display]): (-[LayoutTestController testRepaint]): (-[LayoutTestController repaintSweepHorizontally]): (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]): (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]): (-[LayoutTestController _doLoad:target:]): (-[LayoutTestController _doBackOrForwardNavigation:]): (-[LayoutTestController queueBackNavigation:]): (-[LayoutTestController queueForwardNavigation:]): (-[LayoutTestController queueReload]): (-[LayoutTestController queueScript:]): (-[LayoutTestController queueLoad:target:]): (-[LayoutTestController setAcceptsEditing:]): (-[LayoutTestController setTabKeyCyclesThroughElements:]): (-[LayoutTestController storeWebScriptObject:]): (-[LayoutTestController accessStoredWebScriptObject]): (-[LayoutTestController dealloc]): (-[LayoutTestController decodeHostName:]): (-[LayoutTestController encodeHostName:]):
  • DumpRenderTree/ObjCController.h: Added.
  • DumpRenderTree/ObjCController.m: Added. (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController objCClassNameOf:]): (-[ObjCController objCObjectOfClass:]): (-[ObjCController objCIdentityIsEqual::]): (-[ObjCController objCLongLongRoundTrip:]): (-[ObjCController objCUnsignedLongLongRoundTrip:]): (-[ObjCController testWrapperRoundTripping:]):


Reviewed by Oliver.

Change objective-c tests to use the new ObjCController.

  • fast/dom/Window/window-properties.html:
  • fast/dom/wrapper-classes.html:
  • platform/mac/fast/dom/wrapper-round-tripping.html:
  • platform/mac/fast/objc/longlongTest.html:
4:34 PM Known incompatibilities between open-source WebKit and Safari edited by beidson@apple.com
Added comment about icon db not working fully with current released Safaris (diff)
3:54 PM Changeset in webkit [25460] by zimmermann
  • 13 edits
    24 adds in branches/feature-branch

Reviewed by Oliver.

Rework <pattern> support to take overflow & viewBox into account.
Also fix all possible combinations of patternUnits/patternContentUnits, tested by several batik testcases.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12221 (Webkit ToT fails to render this pattern example)

6:23 AM Changeset in webkit [25459] by zecke
  • 2 edits in trunk/WebCore

2007-09-09 Holger Hans Peter Freyther <zecke@selfish.org>

Build fix for Gtk+ by adding WebCore::callOnMainThread to the TemporaryLinkStubs.

  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::callOnMainThread):
12:11 AM Changeset in webkit [25458] by weinig
  • 1 edit
    3 moves in trunk/LayoutTests

Rubber-stamped by Oliver.

Disable occasionally failing tests until the reason for their failure can be determined.

  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html-disabled: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html-disabled: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html-disabled: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html.

Sep 8, 2007:

10:31 PM Changeset in webkit [25457] by staikos
  • 1 edit in trunk/WebCore/WebCore.pro

missed file in previous checkin

10:14 PM Changeset in webkit [25456] by staikos
  • 2 edits
    2 adds in trunk/WebCore

implement a couple of FileSystem functions and stub out the new thread function
for future implementation

8:13 PM Changeset in webkit [25455] by bdash
  • 4 edits in trunk

2007-09-08 Mark Rowe <mrowe@apple.com>

Build fix for when ENABLE(ICONDATABASE) is not set.

  • loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::~IconDatabase):

2007-09-08 Mark Rowe <mrowe@apple.com>

Qt build fix. Move stub method implementations to the right class.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didPerformFirstNavigation):
7:50 PM Changeset in webkit [25454] by bdash
  • 4 edits in trunk/WebCore

2007-09-08 Mark Rowe <mrowe@apple.com>

More fixes for the Qt and Gtk builds.

  • WebCore.pro: Update for file changes.
  • loader/icon/IconDatabase.cpp: Include errno.h for EDEADLK.
  • loader/icon/PageURLRecord.h:
5:22 PM Changeset in webkit [25453] by justing
  • 4 edits
    2 adds
    2 deletes in trunk


Backing my change back in without the changes to VisiblePosition::next
and previous that weren't necessary to fix the bug and were causing some
layout test failures. Most of the failures appeared to be fixes but I
want more time to investigate and have to move to on to another task.

  • editing/Selection.cpp: (WebCore::Selection::validate):
  • editing/visible_units.cpp: (WebCore::endOfWord):


Re-enabling these tests.

  • editing/selection/5057506-2.html: Added.
  • editing/selection/5057506-2.html-disabled: Removed.
  • editing/selection/5057506.html: Added.
  • editing/selection/5057506.html-disabled: Removed.
4:15 PM Changeset in webkit [25452] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe

Fix the _NSAutoreleaseNoPool() errors on launch - We were using NSFileManager on the secondary
thread with no NSAutoreleasePool in place

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::iconDatabaseSyncThread):
3:45 PM Changeset in webkit [25451] by weinig
  • 3 edits in trunk/WebCore

Add fix to the correct file.

  • loader/icon/SQLDatabase.h:
  • loader/icon/SQLStatement.h:
3:25 PM Changeset in webkit [25450] by weinig
  • 2 edits in trunk/WebCore

Fix Windows build.

  • loader/icon/SQLStatement.h: Disable boolean conversion warning.
2:45 PM Changeset in webkit [25449] by bdash
  • 1 copy in tags/Safari-4523.5

New tag.

2:44 PM Changeset in webkit [25448] by beidson
  • 2 edits in trunk/WebKitQt

YABF (Yet Another Build Fix)

  • Api/qwebsettings.cpp: (QWebSettings::iconDatabaseEnabled):
2:35 PM Changeset in webkit [25447] by beidson
  • 3 edits in trunk/WebKit/gtk

Better build fix

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::registerForIconNotification):
  • WebCoreSupport/FrameLoaderClientGtk.h:
2:30 PM Changeset in webkit [25446] by beidson
  • 3 edits in trunk/WebKitQt

Better build fix

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClient::registerForIconNotification):
  • WebCoreSupport/FrameLoaderClientQt.h:
2:24 PM Changeset in webkit [25445] by beidson
  • 3 edits in trunk/WebKit/gtk

Build fix

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::registerForIconNotification):
  • WebCoreSupport/FrameLoaderClientGtk.h:
2:19 PM Changeset in webkit [25444] by beidson
  • 3 edits in trunk/WebKitQt

Build fix

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClient::registerForIconNotification):
  • WebCoreSupport/FrameLoaderClientQt.h:
2:09 PM Changeset in webkit [25443] by beidson
  • 2 edits in trunk/WebCore

Build fix for non-Mac platforms that use Icon Database

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): Apparently only Mac has the beauty that is pthread_main_np()
1:58 PM Changeset in webkit [25442] by bdash
  • 4 edits in trunk


1:57 PM Changeset in webkit [25441] by bdash
  • 1 copy in tags/Safari-5523.5

New tag.

1:48 PM Changeset in webkit [25440] by bdash
  • 2 edits in trunk/WebCore

2007-09-08 Mark Rowe <mrowe@apple.com>

Build fix.

  • WebCore.xcodeproj/project.pbxproj: Headers used up in WebKit need to be be "private" rather than "project".
1:33 PM Changeset in webkit [25439] by beidson
  • 28 edits
    9 adds
    2 deletes in trunk


Reviewed by Darin

<rdar://problem/5434431> - Asynchronous Icon Database

The IconDatabase API was originally designed to be fully asynchronous - if an icon wasn't read in from disk
when you asked for it, you would be notified when it was.

Safari 2 did writes on a background thread, but reads blocked the main thread.

The current WebCore implementation using SQLite attempted to get rid of the background thread by defering expensive
writes via timers, but falls short in moderate to extreme usage cases

Time to make the IconDatabase live up to it's fully asynchronous destiny.

This should -

  • Make the browser instantly usable while converting Safari 2 icons in the background occurs
  • Remedy any UI slowness/blocking when on slow network home directories
  • Remedy random UI slowness, pauses, and stutters do to random I/O occurring at the exact wrong time or under heavy disk usage from swapping or other apps on the system
  • Allow certain long-running procedures to be interruptible (Safari 2 import, reading icons in from disk when trying to quit, etc)

This will have a noticeable effect on current Safari 2 and Safari 3 beta browsers, including icons not appearing in bookmarks, history,
or the location field the first time they're asked for, as current released Safari's don't properly listen for these async notifations.
The second time such a menu or view is brought up, the icon should be there.

Additionally this includes a SQLite schema change which will be a lot more efficient but will result in the loss of current SQLite icons.
Converting from Safari 2 style icons will still work.

WebCore, welcome to multi-threadedness

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore.vcproj/WebCore.vcproj:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::iconLoadDecisionAvailable): Called when an Icon becomes available that was requested by this DocumentLoader (to support the webView:didReceiveIcon: delegate call in WebKit)
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconLoadDecisionAvailable): Called from the DocumentLoaders who get notified - if the FrameLoader ends up not caring because the WebView has transitioned to a new page, nothing occurs. Otherwise, the FrameLoader possibly starts it Icon Loader and possibly sends the webView:didReceiveIcon: delegate call (WebCore::FrameLoader::startIconLoader): Instead of "Yes, load the icon now" or "No, don't load it" there is a third possibility - "You might be asked to load your icon later." Add supporting logic for receiving this state, and being called a second time when the load decision is finally available.
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h: Added "registerForIconNotification" which is a way to tell WebViews "The icon you are interested in might become available via the generic WebIconDatabaseDidAddIconNotification instead of a targeted delegate call" A WebView can then receive the generic notification and pass on it's own targeted delegate call.
  • loader/icon/IconDataCache.cpp: Removed.
  • loader/icon/IconDataCache.h: Removed.
  • loader/icon/IconDatabase.cpp: (WebCore::urlForLogging): Cut a URL down in length for sane logging and debugging (WebCore::defaultClient): Return the default, empty IconDatabaseClient incase the API doesn't set one.

Following block of methods are for the Main thread's usage -
(WebCore::makeAllDirectories): Small optimization that checks to see if the entire path exists already, and doesn't try to loop

through each patch component if the full path is already present

(WebCore::IconDatabase::open): Makes all directories to the target path and kicks off the background thread - nothing more.
(WebCore::IconDatabase::close): Signals the thread to quit and waits for it to do so
(WebCore::IconDatabase::removeAllIcons): Purge the icon database
(WebCore::IconDatabase::loadDecisionForIconURL): Determine if an icon loader should load now. If the decision is "maybe later", then

mark the DocumentLoader to be notified later when the final decision is available.

(WebCore::IconDatabase::iconDataKnownForIconURL): Determine if the actual image data has been read from disk (or set from the loader) for

icon URL in question

(WebCore::IconDatabase::delayDatabaseCleanup): Restore this method from a year ago, as asynchronous pruning of icons can now occur on a

background thread.

(WebCore::IconDatabase::notifyPendingLoadDecisions): Tell all the registered DocumentLoaders "Hey, we've read in all URL mappings from disk,

so check to see if you are interested in any of them"

(WebCore::IconDatabase::wakeSyncThread): Wake the sync thread, if it is idle
(WebCore::IconDatabase::scheduleOrDeferSyncTimer): Even though we're on a background thread, we still defer writing out to disk during

periods of high activity

(WebCore::IconDatabase::syncTimerFired): Call wakeSyncThread()

Following block of methods may be used by either thread -

Following block of methods are used by the secondary thread only -
(WebCore::IconDatabase::importIconURLForPageURL): For the Safari 2 import procedure - write a URL mapping directly out to disk
(WebCore::IconDatabase::importIconDataForIconURL): For the Safari 2 import procedure - write an Icon directly out to disk
(WebCore::IconDatabase::shouldStopThreadActivity): To check and see if the thread should stop what it is doing now to do something

more important (such as quit, or delete all icons)

(WebCore::IconDatabase::iconDatabaseSyncThread): Entry point for the background thread
(WebCore::IconDatabase::performOpenInitialization): Open and validate the SQLite database, making sure it's schema jives with what

is expected

(WebCore::IconDatabase::performURLImport): Import all the Page URL -> Icon URL mappings from the database. Done "1st thing" on startup,

this is necessary to be able to give the loader decisions about whether or not it should load icons from the network

(WebCore::IconDatabase::syncThreadMainLoop): Main loop - sleeps until woken up, then does a read cycle and a write cycle until both cycles

do no work - then it goes back to sleep.

(WebCore::IconDatabase::readFromDatabase): Reads icons from the database that clients are waiting on
(WebCore::IconDatabase::writeToDatabase): Writes any changes page -> icon url mappings to disk, as well as any new image data that has

been received from the loader

(WebCore::IconDatabase::pruneUnretainedIcons): Done only once, and only after the first write to the database, this procedure removes all

icons and page URLs from disk that haven't been retained by any client. Note that the prune can be delayed by utilizing delayDatabaseCleanup()

(WebCore::IconDatabase::checkForDanglingPageURLs): Usually part of the prune procedure, prunes any pages who point to icons that no longer exist

in the database

(WebCore::IconDatabase::removeAllIconsOnThread): Completely purge both the on-disk and in memory records of all icons
(WebCore::IconDatabase::deleteAllPreparedStatements): Part of removeAllIcons and the thread cleanup procedure
(WebCore::IconDatabase::cleanupSyncThread): Write out any last remaining writes to disk, close the database, and then end the thread
(WebCore::IconDatabase::imported): Checks the DB to see if the Safari 2 import has occured
(WebCore::IconDatabase::setImported): Sets the "Safari 2 imported" flag
(WebCore::IconDatabase::setIconURLForPageURLInSQLDatabase): This and the following "SQLDatabase" suffixed methods are pretty self explanatory

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseClient.h: Added. (WebCore::IconDatabaseClient::~IconDatabaseClient): (WebCore::IconDatabaseClient::performImport): Perform the Safari 2 import, implemented by WebKit (WebCore::IconDatabaseClient::dispatchDidRemoveAllIcons): Send the API notification (WebCore::IconDatabaseClient::dispatchDidAddIconForPageURL): Ditto
  • loader/icon/IconDatabaseNone.cpp: Best attempt to keep non icon-DB platforms building (WebCore::IconDatabase::defaultDatabaseFilename): (WebCore::IconDatabase::readIconForPageURLFromDisk): (WebCore::IconDatabase::loadDecisionForIconURL): (WebCore::IconDatabase::iconDataKnownForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::isEnabled): (WebCore::IconDatabase::delayDatabaseCleanup): (WebCore::IconDatabase::allowDatabaseCleanup): (WebCore::IconDatabase::setClient):
  • loader/icon/IconRecord.cpp: Added. (WebCore::IconRecord::IconRecord): IconRecord used to be "IconDataCache" - it is merely a container for the url, timestamp, and image for a site icon. It is Shared, and therefore ref counted - PageURLRecords are the owning containers. This is a tricky way to track how many page urls are retaining an IconRecord and therefore tracking when we should try to get rid of one. (WebCore::IconRecord::~IconRecord): (WebCore::IconRecord::image): (WebCore::IconRecord::setImageData): (WebCore::IconRecord::loadImageFromResource): (WebCore::IconRecord::imageDataStatus): Return whether the image data hasn't been read yet, exists in memory, or is absent (site with no icon) (WebCore::IconRecord::snapshot): Returns a snapshot of the icon's data - url, timestamp, and image data - to be written to disk
  • loader/icon/IconRecord.h: Added. (WebCore::IconSnapshot::IconSnapshot): (WebCore::IconRecord::getTimestamp): (WebCore::IconRecord::setTimestamp): (WebCore::IconRecord::iconURL): (WebCore::IconRecord::retainingPageURLs):
  • loader/icon/PageURLRecord.cpp: Added. (WebCore::PageURLRecord::PageURLRecord): PageURLRecord is fundamentally a pairing of a Page URL to an Icon. It has manual ref counting for the sake of "retainIconForPageURL" and "releaseIconForPageURL", and can provide a quick snapshot of it's Page URL -> Icon URL mapping for writing to the database (WebCore::PageURLRecord::setIconRecord): (WebCore::PageURLRecord::snapshot):
  • loader/icon/PageURLRecord.h: Added. (WebCore::PageURLSnapshot::PageURLSnapshot): (WebCore::PageURLRecord::url): (WebCore::PageURLRecord::PageURLRecord::iconRecord): (WebCore::PageURLRecord::retain): (WebCore::PageURLRecord::release): (WebCore::PageURLRecord::retainCount):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::copy): Added a deep copy method for the purposes of handing icon data across the thread boundary into the icon database
  • platform/SharedBuffer.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::registerForIconNotification):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::callOnMainThread): Only other IconDatabase utilizing platform - keep their build going


Reviewed by Darin

<rdar://problem/5434431> - Asynchronous Icon Database

WebKit side of things
Mainly, there are Notifications WebKit has to listen for now that tell it when to either call back into WebCore
for some purpose or to send the webView:didReceiveIcon: delegate call

Many smaller tweaks as well.

  • Misc/WebIconDatabase.h:
  • Misc/WebIconDatabase.mm: (defaultClient): (-[WebIconDatabase init]): (+[WebIconDatabase delayDatabaseCleanup]): Accessor so clients can prevent the thread from cleaning up the database before they've done all their necessary retaining of icons. (+[WebIconDatabase allowDatabaseCleanup]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase _isEnabled]): (-[WebIconDatabase _sendNotificationForURL:]): (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): (-[WebIconDatabase _databaseDirectory]):

(-[ThreadEnabler threadEnablingSelector:]): Quick and dirty class to enabled Cocoa multithreading
(+[ThreadEnabler enableThreading]):

  • Misc/WebIconDatabaseInternal.h: Expose the internal methods of WebIconDatabase that are required by WebIconDatabaseClient
  • Misc/WebNSNotificationCenterExtras.h: Added. - Great utility class whose design was borrowed from Colloquy that allows the posting of a Cocoa notification on the main thread from *any* thread
  • Misc/WebNSNotificationCenterExtras.m: Added. (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:]): (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:userInfo:]): (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:userInfo:waitUntilDone:]): (+[NSNotificationCenter _postNotificationName:]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveIcon): Send the webView:didReceiveIcon: delegate call (WebFrameLoaderClient::registerForIconNotification):
  • WebCoreSupport/WebIconDatabaseClient.h: Added.
  • WebCoreSupport/WebIconDatabaseClient.mm: Added. (WebIconDatabaseClient::performImport): Perform the Safari 2 icon import (WebIconDatabaseClient::dispatchDidRemoveAllIcons): Send the NSNotification (WebIconDatabaseClient::dispatchDidAddIconForPageURL): Ditto
  • WebView/WebView.mm: (-[WebView _receivedIconChangedNotification:]): Check and see if this notification is for this WebView's current URL by calling back into the IconDatabase (-[WebView _registerForIconNotification:]): Support for WebIconDatabaseClient (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Dispatch this delegate call as well as unregister for the notification
  • WebView/WebViewInternal.h:
  • WebKit.xcodeproj/project.pbxproj:


<rdar://problem/5434431> - Asynchronous Icon Database

  • WebFrame.cpp: (WebFrame::didPerformFirstNavigation): Empty impl for now (WebFrame::registerForIconNotification): Ditto
  • WebFrame.h:

Sep 7, 2007:

9:00 PM Changeset in webkit [25438] by oliver
  • 1 edit in trunk/LayoutTests/ChangeLog

Spell Sams name correctly.

8:59 PM Changeset in webkit [25437] by oliver
  • 1 edit
    42 deletes in trunk/LayoutTests


r25382 moved a number of tests from platform/mac back to the cross-platform
directories, but did not commit the platform/mac changes themselves.

This patch actually does.

  • platform/mac/editing/execCommand/nsresponder-outdent-expected.txt: Removed.
  • platform/mac/editing/execCommand/nsresponder-indent-expected.checksum: Removed.
  • platform/mac/editing/execCommand/nsresponder-outdent-expected.checksum: Removed.
  • platform/mac/editing/execCommand/nsresponder-indent-expected.png: Removed.
  • platform/mac/editing/execCommand/nsresponder-outdent-expected.png: Removed.
  • platform/mac/editing/execCommand/nsresponder-indent.html: Removed.
  • platform/mac/editing/execCommand/nsresponder-outdent.html: Removed.
  • platform/mac/editing/execCommand/nsresponder-indent-expected.txt: Removed.
  • platform/mac/editing/selection/5195166-1-expected.png: Removed.
  • platform/mac/editing/selection/5195166-2-expected.png: Removed.
  • platform/mac/editing/selection/select-line-expected.txt: Removed.
  • platform/mac/editing/selection/selection-actions-expected.checksum: Removed.
  • platform/mac/editing/selection/selection-actions.html: Removed.
  • platform/mac/editing/selection/4947387-expected.txt: Removed.
  • platform/mac/editing/selection/4947387-expected.png: Removed.
  • platform/mac/editing/selection/5195166-1-expected.checksum: Removed.
  • platform/mac/editing/selection/5195166-2-expected.checksum: Removed.
  • platform/mac/editing/selection/selection-actions-expected.txt: Removed.
  • platform/mac/editing/selection/5195166-1.html: Removed.
  • platform/mac/editing/selection/5195166-2.html: Removed.
  • platform/mac/editing/selection/selection-actions-expected.png: Removed.
  • platform/mac/editing/selection/select-line.html: Removed.
  • platform/mac/editing/selection/4947387-expected.checksum: Removed.
  • platform/mac/editing/selection/5195166-1-expected.txt: Removed.
  • platform/mac/editing/selection/4947387.html: Removed.
  • platform/mac/editing/selection/5195166-2-expected.txt: Removed.
  • platform/mac/editing/deleting/smart-delete-003-expected.checksum: Removed.
  • platform/mac/editing/deleting/smart-delete-004-expected.checksum: Removed.
  • platform/mac/editing/deleting/smart-delete-003.html: Removed.
  • platform/mac/editing/deleting/smart-delete-004.html: Removed.
  • platform/mac/editing/deleting/5300379-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.checksum: Removed.
  • platform/mac/editing/deleting/5300379.html: Removed.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph.html: Removed.
  • platform/mac/editing/deleting/smart-delete-003-expected.txt: Removed.
  • platform/mac/editing/deleting/smart-delete-004-expected.txt: Removed.
  • platform/mac/editing/deleting/5300379-expected.txt: Removed.
  • platform/mac/editing/deleting/smart-delete-003-expected.png: Removed.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
  • platform/mac/editing/deleting/smart-delete-004-expected.png: Removed.
  • platform/mac/editing/deleting/5300379-expected.png: Removed.
  • platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
8:24 PM Changeset in webkit [25436] by oliver
  • 1 edit
    17 adds in trunk/LayoutTests

Reviewed by Sam.

Re-adding a few mac specific directories that accidentally got clobbered
during my recent layout test rearranging

  • platform/mac/editing/input: Added.
  • platform/mac/editing/input/hangul-enter-confirms-and-sends-keypress-expected.txt: Added.
  • platform/mac/editing/input/hangul-enter-confirms-and-sends-keypress.html: Added.
  • platform/mac/editing/input/hangul.js: Added.
  • platform/mac/editing/input/kotoeri-enter-to-confirm-and-newline-expected.txt: Added.
  • platform/mac/editing/input/kotoeri-enter-to-confirm-and-newline.html: Added.
  • platform/mac/editing/input/kotoeri.js: Added.
  • platform/mac/editing/input/logger.js: Added.
  • platform/mac/fast/AppleScript: Added.
  • platform/mac/fast/AppleScript/001-expected.txt: Added.
  • platform/mac/fast/AppleScript/001.html: Added.
  • platform/mac/fast/AppleScript/array-expected.txt: Added.
  • platform/mac/fast/AppleScript/array.html: Added.
  • platform/mac/fast/AppleScript/date-expected.txt: Added.
  • platform/mac/fast/AppleScript/date.html: Added.
  • platform/mac/fast/objc: Added.
  • platform/mac/fast/objc/longlongTest-expected.txt: Added.
  • platform/mac/fast/objc/longlongTest.html: Added.
8:10 PM Changeset in webkit [25435] by ddkilzer
  • 2 edits
    1 delete in trunk/WebCore


Reviewed by Timothy Hatcher.

Housekeeping. No test required.

  • bindings/objc/WebScriptObjectInternal.h: Removed unused file.
  • bindings/objc/WebScriptObjectPrivate.h: Updated copyright statement.
7:31 PM Changeset in webkit [25434] by justing
  • 6 edits
    2 adds
    2 deletes in trunk


Rolling out my changes from r25421 while I investigate the layout test failures
they caused.

  • editing/Selection.cpp: (WebCore::Selection::validate):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::lastEditablePositionAtOrBefore): (WebCore::VisiblePosition::firstEditablePositionAtOrAfter):
  • editing/VisiblePosition.h:
  • editing/visible_units.cpp: (WebCore::endOfWord): (WebCore::previousWordPosition): (WebCore::nextWordPosition): (WebCore::startOfLine): (WebCore::endOfLine): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition):


Disabling the layout tests checked in with r25421 while I investigate
some layout test failures that that change caused.

  • editing/selection/5057506-2.html: Removed.
  • editing/selection/5057506-2.html-disabled: Added.
  • editing/selection/5057506.html: Removed.
  • editing/selection/5057506.html-disabled: Added.
7:23 PM Changeset in webkit [25433] by weinig
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Remove a duplicate test.
6:40 PM Changeset in webkit [25432] by ggaren
  • 2 edits in trunk/WebKit

Suggested by Maciej Stachowiak.

Added wKiosk Browser to the browser list. Pretty sweet app.

  • WebView/WebPreferences.m: (cacheModelForMainBundle):
6:17 PM Changeset in webkit [25431] by ggaren
  • 2 edits in trunk/WebKit

Build fix.

  • WebView/WebView.mm: (+[WebView _setCacheModel:]):
5:40 PM Changeset in webkit [25430] by ggaren
  • 25 edits in trunk


Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.

Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no
memory cache, or a very tiny one

Keep the GTK build working with an empty stub.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didPerformFirstNavigation):
  • WebCoreSupport/FrameLoaderClientGtk.h:


Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.

Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no
memory cache, or a very tiny one

Added a client callback to notify WebKit when the first navigation has
taken place. "Navigation" here means a transition from one page to
another that ends up in the back/forward list.

WebKit Mac uses this notification to grow its cache model under certain

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addBackForwardItemClippedAtTarget):
  • loader/FrameLoaderClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::didPerformFirstNavigation): Ah, SVGEmptyFrameLoaderClient, my old friend.


Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.

Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no
memory cache, or a very tiny one

High level explanation:

  • Added SPI for specifying a cache model on a per-WebView basis. (Hopefully, this will become API soon.) We balance competing cache models simply by using the largest one that pertains at a given time.
  • Added heuristic for guessing a default cache model in WebViews that don't specify one:

1) Default to DocumentViewer for apps linked on or after this
WebKit. Default to DocumentBrowser otherwise.

2) Assign specific defaults to well-known clients based on
bundle ID.

3) Grow the default to DocumentBrowser if a navigation takes

  • As a part of the DocumentBrowser & PrimaryWebBrowser settings:

1) Make the Foundation disk cache much much bigger than the
default 20MB, if space allows. (This is a hedge against a small
WebCore cache in DocumentBrowser mode, but also an all-around
win for page load speed.)

2) Scaled the Foundation memory cache's capacity with physical
RAM, just like we do with other caches. This is a small win on
low memory systems.

  • Misc/WebKitSystemBits.h:
  • Misc/WebKitSystemBits.m: (WebMemorySize): Renamed from "WebSystemMainMemory." (WebHomeDirectoryFreeSize): Added function to measure the free space on the user's home directory. We use this as a factor in determining the disk cache's cacpacity.
  • Misc/WebKitVersionChecks.h: Support for linked on or after check.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didPerformFirstNavigation): Implementation of heuristic rule #3.
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (cacheModelForMainBundle): Implementation of heuristic rule #2. (-[NSMutableDictionary _web_checkLastReferenceForIdentifier:]): Added notification for when a WebPreferences instance becomes inert. We use this to shrink the cache model back down if possible. Moved this code into a WebPreferences method, since it's not really a feature of NSDictionary.
  • WebView/WebPreferencesPrivate.h: SPI declarations.

  • WebView/WebView.mm: Replaced manual notification posts with calls to the _postPreferencesChangesNotification convenience method.

(-[WebView _preferencesChangedNotification:]): Merged dispersed code
for updating preferences-related settings into this one function. This
was needed for an earlier version of the patch, even though the
current version could probably do without it.

(+[WebView _preferencesChangedNotification:]): Added a class-level
listener for WebPreferences changes. This listener takes care of
modifying the class-level global cache model setting if necessary.

(+[WebPreferences standardPreferences]): Removed call to
_postPreferencesChangesNotification because the notification already
posts when you create the WebPreferences object. (I noticed this
inefficiency because my new _preferencesChangedNotification: method was
called excessively at startup.)

Also Added explicit tracking of WebPreferences clients, so we know when
a WebPreferences instance becomes inert:

(-[WebPreferences didRemoveFromWebView]):
(-[WebPreferences willAddToWebView]):

(+[WebView _setCacheModel:]): Translates a cache model into actual
settings in various APIs. Caches that have unbounded value grow
linearly relative to available space. Caches that have bounded value
grow inverse-squaredly relative to available space.


Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.

Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no
memory cache, or a very tiny one

Keep the Qt build working with an empty stub.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClient::didPerformFirstNavigation):
  • WebCoreSupport/FrameLoaderClientQt.h:


Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.

Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no
memory cache, or a very tiny one

Keep the Windows build working with an empty stub.

  • WebFrame.cpp: (FrameLoaderClient::didPerformFirstNavigation):
  • WebFrame.h:
4:53 PM Changeset in webkit [25429] by adele
  • 6 edits
    2 adds in trunk


Reviewed by Dave Harrison.

Fix for <rdar://problem/5428427> Wrong characters are re-converted after doing reconversion with Kotoeri

Revert change for<rdar://problem/5279521> and add nil checks for the result of TextIterator::rangeFromLocationAndLength
TextIterator::exitNode shouldn't require the m_lastTextNode to be true, but we can't change that without making the logic in _web_attributedStringFromRange match.
We'll get that for free when we switch to use TextIterator in _web_attributedStringFromRange.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Added nil checks.
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): ditto.
  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Re-added check for m_lastTextNode before emitting newline.


Reviewed by Dave Harrison.

Tests for <rdar://problem/5428427> Wrong characters are re-converted after doing reconversion with Kotoeri

  • platform/mac/fast/text/attributed-substring-from-range-002-expected.txt: Added.
  • platform/mac/fast/text/attributed-substring-from-range-002.html: Added.
  • fast/forms/textarea-type-spaces-expected.txt: Revert back to old result.
4:45 PM Changeset in webkit [25428] by adachan
  • 2 edits in trunk/WebKit/win

Need to let the OS handle Alt+F4.

Reviewed by Hyatt.

  • WebView.cpp: (WebView::keyUp): (WebView::keyDown):
3:46 PM Changeset in webkit [25427] by andersca
  • 2 edits in trunk/WebKit/win

Reviewed by Oliver.

Seed: Embedded media content (Flash Player 9) inside RSS reported as unknown MIME type.

Don't return ObjectContentNone if the URL's extension can't be mapped to a MIME type. If the MIME type is empty,
we will try to display the content in a subframe instead, just like Mac WebKit.

  • WebFrame.cpp: (WebFrame::objectContentType):
3:39 PM Changeset in webkit [25426] by adachan
  • 6 edits in trunk

<rdar://problem/5395928> Need to be able to handle context menu item selection by index

Reviewed by Beth.


  • platform/ContextMenu.h: Added method to retrieve context menu item by index
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): call setPlatformDescription() since that will handle adding the MNS_NOTIFYBYPOS style to the context menu. (WebCore::contextMenuItemByIdOrPosition): helper method so we don't have to duplicate code between itemWithAction() and itemAtIndex(). (WebCore::ContextMenu::itemWithAction): (WebCore::ContextMenu::itemAtIndex): (WebCore::ContextMenu::setPlatformDescription): add MNS_NOTIFYBYPOS style to the context menu so we will get notified by menu position through WM_MENUCOMMAND when the item is selected.


  • WebView.cpp: (WebView::performContextMenuAction): performContextMenuAction() can now handle context menu item selection via WM_MENUCOMMAND (by specifying byPosition to be true). In that case, we get the ContextMenuItem by position rather than by action id. (WebViewWndProc): handle WM_MENUCOMMAND
  • WebView.h:
3:01 PM Changeset in webkit [25425] by weinig
  • 4 edits in trunk


Reviewed by Alice.

Strip trailing and leading space/newline characters from skiplist file names.

  • Scripts/run-webkit-tests:


  • platform/win/Skipped: fix typo
2:39 PM Changeset in webkit [25424] by aliceli1
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: removing a duplicated test
2:34 PM Changeset in webkit [25423] by aliceli1
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: moved a bunch of editing tests that actually succeed in both Debug and Release into a section at the end of the skip list. The reason I'm not just removing these tests from the skip list right now is because the windows bots are not stable and green yet, and I was asked to do this removal at a later time when regressions are easier to spot.
12:42 PM Changeset in webkit [25422] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Steve Falkenburg.

  • fix crash seen on Windows release builds
  • wtf/FastMalloc.cpp: Change pthread_getspecific optimization to be done only on the DARWIN platform. Also correct a couple reinterpret_cast that should be static_cast instead.
12:18 PM Changeset in webkit [25421] by justing
  • 7 edits
    8 adds in trunk


Reviewed by Darin.

<rdar://problem/5057506> Double-clicking after ToDo content doesn't select the paragraph break

  • editing/Selection.cpp: (WebCore::Selection::validate): Moved the code that moves across a paragraph boundary when expanding selections by word granularity from endOfWord to here. In the word and paragraph granularity cases, if the end of the selection is at the end of the last paragraph in the last cell of a block table, expand it so that it ends at the start of the paragraph after the table, instead of just after the table, so that ToDo content gets the same double/tripled click behavior that normal paragraphs get (added two testcases). When expanding the selection to include paragraph breaks, pass VisiblePosition::next true so that it doesn't change editability.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): Renamed the bool because it's now also used to keep non-editable positions non-editable. (WebCore::VisiblePosition::previous): Ditto. (WebCore::VisiblePosition::lastPositionWithSameEditabilityAtOrBefore): Renamed this function and made it also work with non-editable positions. (WebCore::VisiblePosition::firstPositionWithSameEditabilityAtOrAfter): Ditto.
  • editing/VisiblePosition.h:
  • editing/visible_units.cpp: (WebCore::endOfWord): Called the renamed function. (WebCore::previousWordPosition): Ditto. (WebCore::nextWordPosition): Ditto. (WebCore::startOfLine): Ditto. (WebCore::endOfLine): Ditto. (WebCore::previousSentencePosition): Ditto. (WebCore::nextSentencePosition): Ditto.


Reviewed by Darin.

<rdar://problem/5333725> -webkit-user-select: none makes selection difficult

  • editing/selection/5057506-2.html: Added.
  • editing/selection/5057506.html: Added.
  • platform/mac/editing/selection/5057506-2-expected.checksum: Added.
  • platform/mac/editing/selection/5057506-2-expected.png: Added.
  • platform/mac/editing/selection/5057506-2-expected.txt: Added.
  • platform/mac/editing/selection/5057506-expected.checksum: Added.
  • platform/mac/editing/selection/5057506-expected.png: Added.
  • platform/mac/editing/selection/5057506-expected.txt: Added.
12:07 PM Changeset in webkit [25420] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebDragClient.mm

Attempt to fix the PPC build.

12:04 PM Changeset in webkit [25419] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Sam

<rdar://problem/5089241> - ASSERT and other funky effects in IconLoader with large 404 pages

There were two problems:
1 - I originally didn't expect SubresourceLoader to keep pulling in data after it received a 404 response,

but if the server sends back a complex 404 page, the loader did just that. That could result in the
IconLoader "finishing" twice

2 - In this case, the long messy 404 page would be committed to the database as image data. This would

result in wasted space on disk, wasted space in RAM, and wasting processor time trying to parse 50k+
of HTML as image data

Fix is two parts - 1, monitor the "m_loadIsInProgress" flag and 2, make ::finishLoading() take an actual
SharedBuffer argument that is what should be committed to the database so the ResourceHandle is unnecessary

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): If the response is not valid, commit null data (WebCore::IconLoader::didFail): If we've already finished loading once (the 404 response), don't finish again! (WebCore::IconLoader::didFinishLoading): Ditto (WebCore::IconLoader::finishLoading): Take a SharedBuffer argumnt as the actual data to commit
  • loader/icon/IconLoader.h: Add a SharedBuffer arg to ::finishLoading()
10:59 AM Changeset in webkit [25418] by beidson
  • 1 edit in trunk/WebCore/platform/AutodrainedPool.h

Build fix (sigh)

10:49 AM Changeset in webkit [25417] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Darin

Inline the in-header definitions for non-Mac platforms

  • platform/AutodrainedPool.h: (WebCore::AutodrainedPool::AutodrainedPool): (WebCore::AutodrainedPool::~AutodrainedPool): (WebCore::AutodrainedPool::cycle):
10:39 AM Changeset in webkit [25416] by beidson
  • 2 edits
    4 adds in trunk/WebCore

Reviewed by Darin

Add some AutoreleasePool and Threading utilities in preparation for the multi-threaded
fix for <rdar://problem/5434431>

AutodrainedPool wraps an NSAutoreleasePool and tracks a "cycle" count. This allows clients
in WebCore to simply call ::cycle() and after a preset number of iterations the pool will drain
and recreate the underlying NSAutoreleasePool

Threading utilities include C++ wrappers for pthread mutexes and conditions, as well as a generic
"callOnMainThread()" function for any non-main thread to use.

  • platform/AutodrainedPool.h: Added. (WebCore::AutodrainedPool::AutodrainedPool): Empty implementations for all non-mac platforms (WebCore::AutodrainedPool::~AutodrainedPool): ditto (WebCore::AutodrainedPool::cycle): ditto
  • platform/mac/AutodrainedPool.mm: Added. (WebCore::AutodrainedPool::AutodrainedPool): (WebCore::AutodrainedPool::~AutodrainedPool): (WebCore::AutodrainedPool::cycle): Keep track of number of cycles, and drain/recreate the pool if the cycle limit is hit
  • platform/Threading.h: Added. (WebCore::Mutex::Mutex): C++ wrapper for pthread_mutex (WebCore::Mutex::~Mutex): (WebCore::Mutex::lock): (WebCore::Mutex::tryLock): (WebCore::Mutex::unlock): (WebCore::MutexLocker::MutexLocker): Handles automatically locking/unlocking a Mutex (for early returns from a function, for example) (WebCore::MutexLocker::~MutexLocker): (WebCore::ThreadCondition::ThreadCondition): C++ wrapper for pthread_condition (WebCore::ThreadCondition::~ThreadCondition): (WebCore::ThreadCondition::wait): (WebCore::ThreadCondition::signal): (WebCore::ThreadCondition::broadcast):
  • platform/mac/Threading.mm: Added. (-[WebCoreFunctionWrapper initWithFunction:]): Obj-C implementation of "callOnMainThread" (-[WebCoreFunctionWrapper _call]): (WebCore::callOnMainThread):
10:27 AM Changeset in webkit [25415] by adachan
  • 5 edits in trunk/WebKit/win

<rdar://problem/5453494> Better lifetime management of WebDataSource and WebDocumentLoader
The problem was that WebDataSource does not hold a strong reference to the WebDocumentLoader. If
a WebDataSource is still around after the loader has been destroyed, it'll just point to
a stale WebDocumentLoader.
To fix this without a circular reference, WebDataSource now holds a strong reference to the
WebDocumentLoader. The WebDocumentLoader holds a strong reference to the WebDataSource
until it's detached from the WebFrame. When the WebDataSource is destroyed, it'll notify
its WebDocumentLoader so the loader will clear any references to it.

Reviewed by Darin.

  • WebDataSource.cpp: (WebDataSource::~WebDataSource): call WebDocumentLoader::detachDataSource() so the loader will clear any references to this data source (WebDataSource::documentLoader): m_loader is now a RefPtr so we need to call get().
  • WebDataSource.h:
  • WebDocumentLoader.cpp: (WebDocumentLoader::WebDocumentLoader): initialize m_dataSource since it's no longer a COMPtr. (WebDocumentLoader::~WebDocumentLoader): release m_dataSource if necessary (WebDocumentLoader::setDataSource): add a reference to m_dataSource (WebDocumentLoader::dataSource): (WebDocumentLoader::detachDataSource): clear m_detachedDataSource. (WebDocumentLoader::attachToFrame): call setDataSource() so it'll add the reference to the data source if necessary. (WebDocumentLoader::detachFromFrame): release the reference to the data source
  • WebDocumentLoader.h:
10:21 AM Changeset in webkit [25414] by weinig
  • 2 edits
    18 moves in trunk/LayoutTests

Reviewed by Kevin McCullough.

Fix embarassing spelling mistakes.

  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe-expected.txt.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe.html.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open-expected.txt.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open.html.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe-expected.txt: Removed.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open-expected.txt: Removed.
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-expected.txt.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change-expected.txt.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open-expected.txt.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open.html.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-expected.txt: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change-expected.txt: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open-expected.txt: Removed.
  • http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open.html: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-subframe-expected.txt.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe.html: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-subframe.html.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-window-open-expected.txt.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open.html: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-window-open.html.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-subframe-expected.txt: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-subframe.html: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-window-open-expected.txt: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-window-open.html: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-subframe-expected.txt.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe.html: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-subframe.html.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-window-open-expected.txt.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open.html: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-window-open.html.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-subframe-expected.txt: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-subframe.html: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-window-open-expected.txt: Removed.
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-window-open.html: Removed.
  • platform/win/Skipped:
9:52 AM Changeset in webkit [25413] by kmccullo
  • 5 edits
    1 move in trunk


Reviewed by Maciej.

  • Moved JSRetainPtr to the API.
  • API/JSRetainPtr.h: Copied from kjs/JSRetainPtr.h. (JSRetain): (JSRelease): (JSRetainPtr::JSRetainPtr): (JSRetainPtr::~JSRetainPtr): (JSRetainPtr::get): (JSRetainPtr::releaseRef): (JSRetainPtr::operator->): (JSRetainPtr::operator!): (JSRetainPtr::operator UnspecifiedBoolType): (::operator): (::adopt): (::swap): (swap): (operator==): (operator!=):
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/JSRetainPtr.h: Removed.


Reviewed by Maciej.

  • Changed Drosera to take advantage of the JSRetainPtr changes.
  • Drosera/DebuggerDocument.cpp: (DebuggerDocument::breakpointEditorHTML): (DebuggerDocument::evaluateScript): (DebuggerDocument::valueForScopeVariableNamed): (DebuggerDocument::log): (DebuggerDocument::windowScriptObjectAvailable): (DebuggerDocument::toJSArray): (DebuggerDocument::callFunctionOnObject): (DebuggerDocument::logException):
  • Drosera/mac/DebuggerDocumentMac.mm: (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]): (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
9:29 AM Changeset in webkit [25412] by staikos
  • 4 edits in trunk

Fix typo in previous commit

7:49 AM Changeset in webkit [25411] by staikos
  • 6 edits in trunk

Patch from Qing Zhao to export more of the progress details and expose it from

Sep 6, 2007:

8:48 PM Changeset in webkit [25410] by tristan
  • 7 edits
    4 adds in trunk


Reviewed by Maciej Stachowiak.

<rdar://problem/5333496> Back button stopped working on sfgate.com (14957)

This fix is specifically targted to address sfgate.com and reuters.com with minimal
impact to other areas of the frameloader. It does not cause any regression tests to fail.
I've added two layout tests: One to detect this particular bug, and one to address
a secondary issue: if an iframe navigation occurs during onload by a timeout an
additional history item is added, similarly to firefox. We tried to match firefox
more than IE with this fix but did gain a little bit of IE compatability.

Tests: http/tests/navigation/onload-navigation-iframe-timeout.html


  • dom/Document.h: (WebCore::Document::processingLoadEvent): Return the m_processingLoadEvent boolean so FrameLoader knows that the document is in the middle of calling <body onload>

  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
  • html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::createdByParser): (WebCore::HTMLFrameOwnerElement::setCreatedByParser): Added support for a new member variable of frame elements: m_createdByParser. This lets us specifically target the fix to only iframes created via JS and not in-document.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): Initialize m_navigationDuringLoad to false

Determine if the load we're about to start is occuring during
an onload.

If the current frameloader is for a child frame, and the navigation is occuring
during an onload update the current history item rather than adding a new one.

  • loader/FrameLoader.h: Added a new member variable, m_navigationDuringLoad to track the navigation status during the on load, rather than trying to determine the status after (which is nearly impossible due to a new runloop spin).


Reviewed by Maciej Stachowiak.

  • http/tests/navigation/onload-navigation-iframe-expected.txt: Added.
  • http/tests/navigation/onload-navigation-iframe-timeout-expected.txt: Added.
  • http/tests/navigation/onload-navigation-iframe-timeout.html: Added.
  • http/tests/navigation/onload-navigation-iframe.html: Added.
7:53 PM Changeset in webkit [25409] by mjs
  • 4 edits
    1 delete in trunk/JavaScriptCore

Reviewed by Darin.

  • Remove single-threaded optimization for FastMalloc.

It does not appear to help anywhere but Mac OS X on PPC, due to
pthread_getspecific being slow there. On Intel, removing the
optimization results in a ~1.5% PLT speedup, a ~1-5% JS iBench
speedup, and a ~1.5% HTML iBench speedup. On PPC this change is a
speedup on some benchmarks, a slight hit on others.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/collector.cpp: (KJS::Collector::registerThread):
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_ThreadCache::GetCache): (WTF::TCMalloc_ThreadCache::GetCacheIfPresent): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary): (WTF::do_malloc):
  • wtf/FastMallocInternal.h: Removed.
7:02 PM Changeset in webkit [25408] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Kevin McCullough.

Update the Windows skiplist with the current failing tests.

  • platform/win/Skipped:
5:14 PM Changeset in webkit [25407] by sfalken
  • 1 copy in tags/Safari-523.4b

New tag.

5:14 PM Changeset in webkit [25406] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

3:38 PM Changeset in webkit [25405] by ddkilzer
  • 2 edits in trunk/WebCore


Reviewed by Darin.

The implementation of BackForwardList::clearPageCache() was removed in r21793.
It's now safe to remove it from the header.

  • history/BackForwardList.h: Removed clearPageCache().
3:34 PM Changeset in webkit [25404] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebDragClient.mm

Even better build fix.

3:17 PM Changeset in webkit [25403] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebDragClient.mm

Better build fix.

3:15 PM Changeset in webkit [25402] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebDragClient.mm

Build fix.

2:28 PM Changeset in webkit [25401] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Ada.

Crash when using mouse wheel with plug-ins disabled.

Null check the widget.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
2:15 PM Changeset in webkit [25400] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

Small tweak.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream):
2:12 PM Changeset in webkit [25399] by andersca
  • 2 edits
    1 move in trunk/LayoutTests

Reviewed by Mitz.

Re-enable and the npapi-response-headers.html test so it no longer
relies on the ordering of the requests being made.

  • http/tests/plugins/npapi-response-headers-expected.txt:
  • http/tests/plugins/npapi-response-headers.html: Copied from http/tests/plugins/npapi-response-headers.html.disabled.
  • http/tests/plugins/npapi-response-headers.html.disabled: Removed.
2:04 PM Changeset in webkit [25398] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam and Steve.

ADOBE: Safari 3 on Windows is passing bogus values in stream->headers in NPP_NewStream, causing Flash Player to crash.

Serialize the headers into a stream and pass it to NPP_NewStream in stream->headers.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream):
  • plugins/win/PluginStreamWin.h:
1:57 PM Changeset in webkit [25397] by darin
  • 5 edits in trunk/WebCore

Reviewed by Hyatt.

Back out the willRemove() part of the previous patch.
It was incorrect and not needed to fix the bug anyway.

  • dom/Document.cpp: (WebCore::Document::detach): Remove willRemove().
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Put the willRemove() call back here where it was originally before the previous fix.
  • history/CachedPage.cpp: (WebCore::CachedPage::clear):
  • page/Frame.cpp: (WebCore::Frame::setView): (WebCore::Frame::setDocument): Added FIXMEs about the fact that we call detach() on the document but not willRemove().
1:43 PM Changeset in webkit [25396] by thatcher
  • 18 edits in trunk


Reviewed by Darin.

Changed the blocked exception log message to match AppKit's blocked exception message.

  • platform/mac/BlockExceptions.mm: (ReportBlockedObjCException):


Reviewed by Darin.

<rdar://problem/5443883> Uncaught Objective-C exceptions in WebKit clients lead to hard-to-diagnose crashes

Changed all the direct delegate calls to use helper functions that have direct access to
WebView's delegate objects. These helper methods will catch any ObjC exceptions and call
ReportDiscardedDelegateException to log the discarded exception. WebView's that have
catchesDelegateExceptions set to NO will not pay the cost of a @try/@catch. The delegate
forwarders also have the same behavior.

  • Misc/WebKitLogging.h:
  • Misc/WebKitLogging.m: (ReportDiscardedDelegateException):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]):
  • Plugins/WebNullPluginView.mm: (-[WebNullPluginView viewDidMoveToWindow]):
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog): (WebChromeClient::runModal): (WebChromeClient::toolbarsVisible): (WebChromeClient::statusbarVisible): (WebChromeClient::addMessageToConsole): (WebChromeClient::canRunBeforeUnloadConfirmPanel): (WebChromeClient::runBeforeUnloadConfirmPanel): (WebChromeClient::runJavaScriptAlert): (WebChromeClient::runJavaScriptConfirm): (WebChromeClient::runJavaScriptPrompt): (WebChromeClient::shouldInterruptJavaScript): (WebChromeClient::setStatusbarText): (WebChromeClient::print):
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::getCustomMenuFromDefaultItems): (WebContextMenuClient::contextMenuItemSelected):
  • WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag):
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): (WebEditorClient::textDidChangeInTextArea):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithFrame:URL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::willCacheResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource):
  • WebView/WebHTMLView.mm: (-[WebHTMLView callDelegateDoCommandBySelectorIfNeeded:]): (-[WebHTMLView validateUserInterfaceItem:]):
  • WebView/WebPDFView.mm: (-[WebPDFView validateUserInterfaceItem:]): (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
  • WebView/WebView.mm: (-[WebView _openNewWindowWithRequest:]): (-[WebView _menuForElement:defaultItems:]): (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView _cacheResourceLoadDelegateImplementations]): (-[WebView _cacheFrameLoadDelegateImplementations]): (-[WebView _policyDelegateForwarder]): (-[WebView _UIDelegateForwarder]): (-[WebView _editingDelegateForwarder]): (-[WebView _scriptDebugDelegateForwarder]): (-[WebView _setCatchesDelegateExceptions:]): (-[WebView _catchesDelegateExceptions]): (-[_WebSafeForwarder initWithTarget:defaultTarget:]): (-[_WebSafeForwarder forwardInvocation:]): (-[_WebSafeForwarder methodSignatureForSelector:]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView validateUserInterfaceItem:]): (-[WebView _headerHeight]): (-[WebView _footerHeight]): (-[WebView _drawHeaderInRect:]): (-[WebView _drawFooterInRect:]): (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (CallDelegate): (CallDelegateReturningFloat): (CallDelegateReturningBoolean): (CallUIDelegate): (CallUIDelegateReturningFloat): (CallUIDelegateReturningBoolean): (CallFrameLoadDelegate): (CallResourceLoadDelegate): (CallFormDelegate): (CallFormDelegateReturningBoolean):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
12:39 PM Changeset in webkit [25395] by darin
  • 5 edits in trunk/WebCore

Reviewed by Hyatt.

  • <rdar://problem/5457865> REGRESSION (9A527): Safari crashes when opening a page that immediately redirects to a PDF

I don't know how to make an automated test that trips over this.

The immediate cause of this regression was making a back/forward list entry in
this case. Earlier, the quick redirect would not results in a separate entry.
That's possibly a bug too, but it's better to fix the crash first.

The page cache was putting the document into a strange state: Still attached but
with the renderer set to 0. There was no good reason to do this, so got rid of it.
Moved the responsibility to the caller of not calling detach() when moving into
the page cache. This is more of a frame loader thing than a document thing.

  • dom/Document.cpp: (WebCore::Document::detach): Added assertions that this is only called on a document that's attached and not in the page cache. Also moved the call to willRemove in here, so that callers can't make the mistake of not calling that function. Removed the incorrectly-positioned code that made this function do less if it was called on a document in the page cache.
  • history/CachedPage.cpp: (WebCore::CachedPage::clear): Removed the code to handle a document with a renderer of 0. There was no need to put the document into this state. Any document in the page cache will always be "attached".
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Added a check to prevent from calling an unnecessary cancelParsing() on a document that's in the page cache and guard the call to detach() with a check of attached(), like all other calls to detach() on DOM objects.
  • page/Frame.cpp: (WebCore::Frame::setView): Added a missing check of attached(), like all other calls to detach() on DOM objects. Also added code to not call detach() on the document when it's in the page cache. (WebCore::Frame::setDocument): This call site already had the attached() check, but was missing the page cache check.
11:48 AM Changeset in webkit [25394] by kmccullo
  • 14 edits
    1 copy
    3 adds in trunk


Reviewed by Adam, Sam, Darin.

  • Created a JSRetainPtr specifically for JSStringRefs so they can be automatically refed and derefed.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/JSRetainPtr.h: Copied from wtf/RetainPtr.h. (KJS::JSRetain): (KJS::JSRelease): (KJS::): (KJS::JSRetainPtr::JSRetainPtr): (KJS::JSRetainPtr::~JSRetainPtr): (KJS::JSRetainPtr::get): (KJS::JSRetainPtr::releaseRef): (KJS::JSRetainPtr::operator->): (KJS::JSRetainPtr::operator UnspecifiedBoolType): (KJS::::operator): (KJS::::adopt): (KJS::::swap): (KJS::swap): (KJS::operator==): (KJS::operator!=):


Reviewed by Adam, Sam, Darin.

  • Separated what is platform dependant from what is not. Creating the structure needed for Drosera for Win.
  • Drosera/Debugger.h: Added.
  • Drosera/DebuggerDocument.cpp: (DebuggerDocument::breakpointEditorHTMLCallback): (DebuggerDocument::isPausedCallback): (DebuggerDocument::pauseCallback): (DebuggerDocument::resumeCallback): (DebuggerDocument::stepIntoCallback): (DebuggerDocument::evaluateScriptCallback): (DebuggerDocument::currentFunctionStackCallback): (DebuggerDocument::localScopeVariableNamesForCallFrameCallback): (DebuggerDocument::valueForScopeVariableNamedCallback): (DebuggerDocument::logCallback): (DebuggerDocument::breakpointEditorHTML): (DebuggerDocument::isPaused): (DebuggerDocument::pause): (DebuggerDocument::resume): (DebuggerDocument::stepInto): (DebuggerDocument::evaluateScript): (DebuggerDocument::currentFunctionStack): (DebuggerDocument::localScopeVariableNamesForCallFrame): (DebuggerDocument::valueForScopeVariableNamed): (DebuggerDocument::log): (DebuggerDocument::toolbarPause): (DebuggerDocument::toolbarResume): (DebuggerDocument::toolbarStepInto): (DebuggerDocument::toolbarStepOver): (DebuggerDocument::toolbarStepOut): (DebuggerDocument::toolbarShowConsole): (DebuggerDocument::toolbarCloseCurrentFile): (DebuggerDocument::updateFileSource): (DebuggerDocument::didParseScript): (DebuggerDocument::willExecuteStatement): (DebuggerDocument::didEnterCallFrame): (DebuggerDocument::willLeaveCallFrame): (DebuggerDocument::exceptionWasRaised): (DebuggerDocument::windowScriptObjectAvailable): (DebuggerDocument::toJSArray): (DebuggerDocument::callGlobalFunction): (DebuggerDocument::callFunctionOnObject): (DebuggerDocument::getDroseraJSClass): (DebuggerDocument::staticFunctions): (DebuggerDocument::logException):
  • Drosera/DebuggerDocument.h: (DebuggerDocument::DebuggerDocument):
  • Drosera/ForwardingHeaders: Added.
  • Drosera/ForwardingHeaders/wtf: Added.
  • Drosera/ForwardingHeaders/wtf/Platform.h: Added.
  • Drosera/config.h:
  • Drosera/console.html:
  • Drosera/console.js:
  • Drosera/debugger.js:
  • Drosera/mac/DebuggerApplication.mm: (-[DebuggerApplication attach:]):
  • Drosera/mac/DebuggerDocumentMac.h:
  • Drosera/mac/DebuggerDocumentMac.mm: (+[NSString stringOrNilFromWebScriptResult:]): (+[DebuggerClientMac log:]): (-[DebuggerClientMac initWithServerName:]): (-[DebuggerClientMac dealloc]): (-[DebuggerClientMac pause]): (-[DebuggerClientMac resume]): (-[DebuggerClientMac pause:]): (-[DebuggerClientMac resume:]): (-[DebuggerClientMac stepInto:]): (-[DebuggerClientMac stepOver:]): (-[DebuggerClientMac stepOut:]): (-[DebuggerClientMac showConsole:]): (-[DebuggerClientMac closeCurrentFile:]): (-[DebuggerClientMac validateUserInterfaceItem:]): (-[DebuggerClientMac webView:windowScriptObjectAvailable:]): (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]): (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::platformCurrentFunctionStack): (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
11:42 AM Changeset in webkit [25393] by oliver
  • 1 edit in trunk/LayoutTests/ChangeLog

Appease Sam[e]

11:42 AM Changeset in webkit [25392] by oliver
  • 1 edit
    2 moves
    3 adds in trunk/LayoutTests

Reviewed by Same and Darin

Split the wrapper test into seperate Obj-C and JS tests so the we can use the JS tests on other platforms.

  • fast/dom/resources/wrapper-identity-base.js: Added -- This provides the basic utility functions and variables needed for the wrapper tests
  • fast/dom/wrapper-identity-expected.txt: Added.
  • fast/dom/wrapper-identity.html: Added.
  • platform/mac/fast/dom/objc-wrapper-identity-expected.txt: Copied from platform/mac/fast/dom/wrapper-identity-expected.txt.
  • platform/mac/fast/dom/objc-wrapper-identity.html: Copied from platform/mac/fast/dom/wrapper-identity.html.
  • platform/mac/fast/dom/wrapper-identity-expected.txt: Removed.
  • platform/mac/fast/dom/wrapper-identity.html: Removed.
11:11 AM Changeset in webkit [25391] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Adam Roben.

Add fast/frames/onload-remove-iframe-crash.html to the windows skiplist becuase it currently crashes.

  • platform/win/Skipped:
11:07 AM Changeset in webkit [25390] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Register the WebKit DLL on initialization of the DumpRenderTree.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize):
10:05 AM Changeset in webkit [25389] by staikos
  • 2 edits in trunk/WebKitQt

Make popup windows work again

9:56 AM Changeset in webkit [25388] by harrison
  • 1 edit in trunk/WebCore/editing/TextIterator.cpp

Check in source change now that I committed the changelog!

9:55 AM Changeset in webkit [25387] by harrison
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Darin.

Follow up on my fix for <rdar://problem/5306171>.
My first patch (r25373) broke svg/custom/stroke-width-click.svg.

  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Add currPos.isNotNull() check because positions in non-html content (like svg) do not have visible positions, and we don't want to emit for them either.
9:55 AM BuildingQtOnLinux edited by technomancy@gmail.com
libicu36-dev dependency (diff)
5:20 AM Changeset in webkit [25386] by bdash
  • 6 edits in trunk/WebCore

2007-09-06 Mitz Pettel <mitz@webkit.org>

Reviewed by Adam Roben.

  • platform/PlatformString.h: (WebCore::String::defaultWritingDirection):
  • platform/StringImpl.cpp: (WebCore::StringImpl::defaultWritingDirection): Moved textDirectionForParagraph() from RenderMenuList.cpp here.
  • platform/StringImpl.h:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural): Changed to return 'true'. (WebCore::PopupMenu::paint): Changed to use natural directionality for menu items.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Use defaultWritingDirection.
3:31 AM Changeset in webkit [25385] by mjs
  • 1 edit
    1 add in trunk/WebKitSite

Forgot the JS file.

  • misc/WebKitDetect.js: Added.
3:09 AM Changeset in webkit [25384] by mjs
  • 1 edit
    1 add in trunk/WebKitSite

Not reviewed - copy of WebKitDetect script from wiki

  • misc/WebKitDetect.html: Added.
2:25 AM Changeset in webkit [25383] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • fixed <rdar://problem/5455457> REGRESSION (9A527-9A535): Colloquy crash on launch in WebCoreScriptDebugger initWithDelegate (with announce.js plug-in installed)
  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject): Ensure that -[WebView windowScriptObject] and -[WebFrame windowObject] return null until the windowScriptObjectAvailable: delegate method is sent.

Sep 5, 2007:

9:34 PM Changeset in webkit [25382] by oliver
  • 2 edits
    42 copies in trunk/LayoutTests

Reviewed by Stephanie.

Moved a number of tests from platform/mac that are not currently cross-platform,
but should eventually be updated to work across all platforms.

  • editing/deleting/5300379-expected.checksum: Copied from platform/mac/editing/deleting/5300379-expected.checksum.
  • editing/deleting/5300379-expected.png: Copied from platform/mac/editing/deleting/5300379-expected.png.
  • editing/deleting/5300379-expected.txt: Copied from platform/mac/editing/deleting/5300379-expected.txt.
  • editing/deleting/5300379.html: Copied from platform/mac/editing/deleting/5300379.html.
  • editing/deleting/delete-to-end-of-paragraph-expected.checksum: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.checksum.
  • editing/deleting/delete-to-end-of-paragraph-expected.png: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png.
  • editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt.
  • editing/deleting/delete-to-end-of-paragraph.html: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph.html.
  • editing/deleting/smart-delete-003-expected.checksum: Copied from platform/mac/editing/deleting/smart-delete-003-expected.checksum.
  • editing/deleting/smart-delete-003-expected.png: Copied from platform/mac/editing/deleting/smart-delete-003-expected.png.
  • editing/deleting/smart-delete-003-expected.txt: Copied from platform/mac/editing/deleting/smart-delete-003-expected.txt.
  • editing/deleting/smart-delete-003.html: Copied from platform/mac/editing/deleting/smart-delete-003.html.
  • editing/deleting/smart-delete-004-expected.checksum: Copied from platform/mac/editing/deleting/smart-delete-004-expected.checksum.
  • editing/deleting/smart-delete-004-expected.png: Copied from platform/mac/editing/deleting/smart-delete-004-expected.png.
  • editing/deleting/smart-delete-004-expected.txt: Copied from platform/mac/editing/deleting/smart-delete-004-expected.txt.
  • editing/deleting/smart-delete-004.html: Copied from platform/mac/editing/deleting/smart-delete-004.html.
  • editing/execCommand/nsresponder-indent-expected.checksum: Copied from platform/mac/editing/execCommand/nsresponder-indent-expected.checksum.
  • editing/execCommand/nsresponder-indent-expected.png: Copied from platform/mac/editing/execCommand/nsresponder-indent-expected.png.
  • editing/execCommand/nsresponder-indent-expected.txt: Copied from platform/mac/editing/execCommand/nsresponder-indent-expected.txt.
  • editing/execCommand/nsresponder-indent.html: Copied from platform/mac/editing/execCommand/nsresponder-indent.html.
  • editing/execCommand/nsresponder-outdent-expected.checksum: Copied from platform/mac/editing/execCommand/nsresponder-outdent-expected.checksum.
  • editing/execCommand/nsresponder-outdent-expected.png: Copied from platform/mac/editing/execCommand/nsresponder-outdent-expected.png.
  • editing/execCommand/nsresponder-outdent-expected.txt: Copied from platform/mac/editing/execCommand/nsresponder-outdent-expected.txt.
  • editing/execCommand/nsresponder-outdent.html: Copied from platform/mac/editing/execCommand/nsresponder-outdent.html.
  • editing/selection/4947387-expected.checksum: Copied from platform/mac/editing/selection/4947387-expected.checksum.
  • editing/selection/4947387-expected.png: Copied from platform/mac/editing/selection/4947387-expected.png.
  • editing/selection/4947387-expected.txt: Copied from platform/mac/editing/selection/4947387-expected.txt.
  • editing/selection/4947387.html: Copied from platform/mac/editing/selection/4947387.html.
  • editing/selection/5195166-1-expected.checksum: Copied from platform/mac/editing/selection/5195166-1-expected.checksum.
  • editing/selection/5195166-1-expected.png: Copied from platform/mac/editing/selection/5195166-1-expected.png.
  • editing/selection/5195166-1-expected.txt: Copied from platform/mac/editing/selection/5195166-1-expected.txt.
  • editing/selection/5195166-1.html: Copied from platform/mac/editing/selection/5195166-1.html.
  • editing/selection/5195166-2-expected.checksum: Copied from platform/mac/editing/selection/5195166-2-expected.checksum.
  • editing/selection/5195166-2-expected.png: Copied from platform/mac/editing/selection/5195166-2-expected.png.
  • editing/selection/5195166-2-expected.txt: Copied from platform/mac/editing/selection/5195166-2-expected.txt.
  • editing/selection/5195166-2.html: Copied from platform/mac/editing/selection/5195166-2.html.
  • editing/selection/select-line-expected.txt: Copied from platform/mac/editing/selection/select-line-expected.txt.
  • editing/selection/select-line.html: Copied from platform/mac/editing/selection/select-line.html.
  • editing/selection/selection-actions-expected.checksum: Copied from platform/mac/editing/selection/selection-actions-expected.checksum.
  • editing/selection/selection-actions-expected.png: Copied from platform/mac/editing/selection/selection-actions-expected.png.
  • editing/selection/selection-actions-expected.txt: Copied from platform/mac/editing/selection/selection-actions-expected.txt.
  • editing/selection/selection-actions.html: Copied from platform/mac/editing/selection/selection-actions.html.
  • platform/win/Skipped:
6:47 PM Changeset in webkit [25381] by harrison
  • 5 edits in trunk/LayoutTests

Updated results for:
<rdar://problem/5306171> Mail: The first return after an attachment in multipart/mixed message is lost

  • http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
  • http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level-expected.txt:
  • http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-to-javscript-url-expected.txt:
  • http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level-expected.txt:
5:32 PM Changeset in webkit [25380] by weinig
  • 3 edits in trunk/LayoutTests

Reviewed by Kevin McCullough.

Use correct part of the test for cross-platform testing.

  • plugins/bindings-test-expected.txt:
  • plugins/bindings-test.html:
4:57 PM Changeset in webkit [25379] by weinig
  • 4 edits
    1 copy
    1 add in trunk/LayoutTests

Reviewed by Geoff Garen.

Split out mac specific tests from plugins/bindings-test.html into its own test.

  • platform/mac/plugins/bindings-test-objc-expected.txt: Added.
  • platform/mac/plugins/bindings-test-objc.html: Copied from plugins/bindings-test.html.
  • platform/win/Skipped:
  • plugins/bindings-test-expected.txt:
  • plugins/bindings-test.html:
4:39 PM Changeset in webkit [25378] by oliver
  • 2 edits in trunk/LayoutTests

Reviewed by Adam and Niko.

Force run-webkit-tests to not run the tests in platform/mac

  • platform/win/Skipped:
4:02 PM Changeset in webkit [25377] by hyatt
  • 3 edits in trunk/WebKit/win

Fix ALT+key combos so that they go into the DOM.

3:39 PM Changeset in webkit [25376] by weinig
  • 4 edits in trunk/LayoutTests

Reviewed by Geoff Garen.

Don't log DumpRenderTree injected properties in fast/dom/Window/window-properties.html. This change makes
it pass on Windows so it can be removed from the Skipped list.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • platform/win/Skipped:
3:23 PM Changeset in webkit [25375] by zimmermann
  • 18 edits
    4 adds
    1 delete in branches/feature-branch/LayoutTests

Reviewed by Anders.

Fix paths to css style sheets in the last added files. Enable smallFonts.svg as it doesn't crash anymore.
Fix paths to external <use> element reference, to make Batik happy. (We don't support it, yet.)

1:58 PM Changeset in webkit [25374] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver.

Fix many layout test failures caused by r25364.
Set text size to standand size at the begining of each test matching the mac.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest):
1:46 PM Changeset in webkit [25373] by harrison
  • 3 edits
    2 adds in trunk


Reviewed by Kevin Decker.

<rdar://problem/5306171> Mail: The first return after an attachment in multipart/mixed message is lost

Test added: editing/selection/toString-1.html

Source changes:

  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
  • Remove outdated and erroneous check for m_lastTextNode.
  • Fix VisiblePosition check to look for line diff. Simple position diff gives the wrong answer when the start is table/0 and the current is the first position inside the content of the table.


Reviewed by Kevin Decker.

Testcase for:
<rdar://problem/5306171> Mail: The first return after an attachment in multipart/mixed message is lost

  • editing/selection/toString-1-expected.txt: Added.
  • editing/selection/toString-1.html: Added.
1:36 PM webkit_xl.zip attached to DetectingWebKit by timothy@apple.com
Updated to detect mobile Safari.
1:34 PM webkit_normal.zip attached to DetectingWebKit by timothy@apple.com
Updated to detect mobile Safari.
1:25 PM Changeset in webkit [25372] by zimmermann
  • 3 edits
    5 adds in branches/feature-branch

Reviewed by Oliver.
Fix <mask> in userSpaceOnUse coordinates. Verified by new testcase taken from Batik.

11:45 AM Changeset in webkit [25371] by zimmermann
  • 20 edits in branches/feature-branch/WebCore

(Oops, forgot to commit WebCore/ changes!)
Reviewed by Oliver.

Rewrite text painting code path, to be based on "text chunks" instead of using the InlineBox* hierarchy.
This allows us to reuse paint servers as long as possible - and to actually paint in the way didacted by the spec.

This also implements advanced SVG text decorations (ie. stroked/filled decos with gradient/pattern).
Fixes: http://bugs.webkit.org/show_bug.cgi?id=7200 (Gradient appears and disappears in SVG when text is off screen)

Fixes paint server usage on text paths. (ie. styled text paths, with gradients/filters).

11:19 AM Changeset in webkit [25370] by zimmermann
  • 175 edits
    13 adds in branches/feature-branch/LayoutTests

Reviewed by Oliver.

Rewrite text painting code path, to be based on "text chunks" instead of using the InlineBox* hierarchy.
This allows us to reuse paint servers as long as possible - and to actually paint in the way didacted by the spec.

This also implements advanced SVG text decorations (ie. stroked/filled decos with gradient/pattern).
Fixes: http://bugs.webkit.org/show_bug.cgi?id=7200 (Gradient appears and disappears in SVG when text is off screen)

Fixes paint server usage on text paths. (ie. styled text paths, with gradients/filters).

7:24 AM Changeset in webkit [25369] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-09-05 Mark Rowe <mrowe@apple.com>

Unreviewed Qt build fix.

  • wtf/unicode/qt4/UnicodeQt4.h: Fix the constness of the src argument to toUpper to prevent build failures.
Note: See TracTimeline for information about the timeline view.