Timeline
Feb 18, 2008:
- 11:17 PM Changeset in webkit [30403] by
-
- 1 edit in trunk/WebCore/ChangeLog
Reviewed by Sam Weinig's white rhino tusk stamp
SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase
- platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop):
- 11:15 PM Changeset in webkit [30402] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig's rubberstamp
SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase
- platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop):
- 11:04 PM Changeset in webkit [30401] by
-
- 3 edits in branches/Safari-3-1-branch/LayoutTests
Merge r30399.
- 11:03 PM Changeset in webkit [30400] by
-
- 2 edits in trunk/WebKit/win
Make Drosera work on Vista.
Runtime type library registration on Vista requires use of two new call:
RegisterTypeLibraryForUser and UnRegisterTypeLibraryForUser, which write to
HKCU. LoadTypeLib[Ex] registers under HKLM, which fails under vista due to UAC.
Reviewed by Adam.
- WebKitDLL.cpp: (DllUnregisterServer): Call UnRegisterTypeLibraryForUser if available. Fix version number. (DllRegisterServer): Call RegisterTypeLibraryForUser if available.
- 10:24 PM Changeset in webkit [30399] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Adam Roben in California.
- remove unnecessary and erroneous layoutTestController calls from a test
- fast/css/font-face-multiple-remote-sources.html:
- platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt:
- 9:42 PM Changeset in webkit [30398] by
-
- 5 edits2 adds in branches/Safari-3-1-branch
Merge r30395.
- 9:41 PM Changeset in webkit [30397] by
-
- 4 edits4 adds in branches/Safari-3-1-branch
Merge r30392.
- 9:40 PM Changeset in webkit [30396] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30389.
- 9:19 PM Changeset in webkit [30395] by
-
- 6 edits2 adds in trunk
WebCore:
Reviewed by Darin
Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
Test: platform/mac/plugins/webScriptObject-exception-deadlock.html
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject valueForKey:]): The line
resultObj = [super valueForKey:key]; // defaults to throwing an exceptionsays it all - it throws an exception. This method also happens to hold the JSLock. Problematically, when the exeception is thrown and the method exited, the JSLock is never released. Fix that without otherwise changing behavior by holding the JSLock in two individual scopes - Right before the exception and right after.
WebKitTools:
Changes by Geoff Garen, Reviewed by Darin
Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
[WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread. If the lock has leaked,
this series of method calls will deadlock. If things are good, it will complete successfully.
- DumpRenderTree/mac/ObjCController.m: (runJavaScriptThread): (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController testValueForKey]):
LayoutTests:
Reviewed by Darin
Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
- platform/mac-tiger/Skipped: Removed 2 hanging tests that now don't hang
- platform/mac/plugins/webScriptObject-exception-deadlock-expected.txt: Added.
- platform/mac/plugins/webScriptObject-exception-deadlock.html: Added.
- 8:07 PM Changeset in webkit [30394] by
-
- 4 edits in trunk
Remove FindSafari's Release configuration.
- 6:21 PM Changeset in webkit [30393] by
-
- 20 edits in trunk
WebCore:
Reviewed by Sam.
- reduce use of DeprecatedString and memory allocations in processing of CSS
- remove unnecessary double -> float -> double trip in the CSS parser
- cleaned up names and structure in CSS grammar
- css/CSSGrammar.y: Remove getPropertyID and getValueID. Both are now in CSSParser.cpp instead, and they now work on ParseString and String objects and don't require the caller to put the string into a char*. Gave members of the %union more sensible names, removed duplicates, and sorted into a logical order. Put the %expect back in, rather than leaving it commented out.
- css/CSSParser.cpp: (WebCore::equalIgnoringCase): Added. (WebCore::hasPrefix): Added. (WebCore::CSSParser::parseTransitionProperty): Changed to call the new cssPropertyID, which obviates the need to call lower() and utf8() or to allocate memory at all. Also used equalIgnoringCase rather than putting the value into a String just to compare it. (WebCore::CSSParser::lex): Replaced convertASCIIToFloat with charactersToDouble. This change along with the CSSGrammar.y change, removes the double -> float -> double round trip, and affects the result of one layout test. (WebCore::cssPropertyID): Added. Gets the property ID from the gperf hash table, but without allocating any memory. (WebCore::cssValueKeywordID): Ditto.
- css/CSSParser.h: Removed declaration for deprecatedString function (now used only in CSSParser.cpp; soon to be deleted). Added cssPropertyID and cssValueKeywordID functions.
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Call cssPropertyID instead of propertyID. (WebCore::CSSStyleDeclaration::getPropertyValue): Ditto. (WebCore::CSSStyleDeclaration::getPropertyPriority): Ditto. (WebCore::CSSStyleDeclaration::getPropertyShorthand): Ditto. (WebCore::CSSStyleDeclaration::isPropertyImplicit): Ditto. (WebCore::CSSStyleDeclaration::setProperty): Ditto. (WebCore::CSSStyleDeclaration::removeProperty): Ditto. (WebCore::CSSStyleDeclaration::isPropertyName): Ditto.
- css/CSSStyleDeclaration.h: Removed unnecessary includes, unnecessary Noncopyable boilerplate, and the getPropertyID function declaration along with its associated apology comment.
- css/makevalues.pl: Generate constants instead of macros for CSS value numbers (but not an enumeration, like properties, since you rarely have any reason to handle all values, but often have a reason to handle all properties). Renamed the constant for the number of CSS value keywords from CSS_VAL_TOTAL to numCSSValueKeywords, and added maxCSSValueKeywordLength.
- platform/text/String.cpp: (WebCore::charactersToDouble): Made this function more efficient by using a stack buffer rather than a CString.
LayoutTests:
Reviewed by Sam.
- generate new results for the one test that was altered by the double -> float -> double trip taken by numeric values in the CSS parser
This test appears under three different names in three different
parts of our test suite.
- platform/mac/css1/box_properties/acid_test-expected.checksum: Updated.
- platform/mac/css1/box_properties/acid_test-expected.png: Ditto.
- platform/mac/css1/box_properties/acid_test-expected.txt: Ditto.
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.checksum: Ditto.
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.png: Ditto.
- platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt: Ditto.
- platform/mac/fast/block/basic/011-expected.checksum: Ditto.
- platform/mac/fast/block/basic/011-expected.png: Ditto.
- platform/mac/fast/block/basic/011-expected.txt: Ditto.
- 6:13 PM Changeset in webkit [30392] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms
Test: fast/css/font-face-multiple-remote-sources.html
- css/CSSFontFace.cpp: (WebCore::CSSFontFace::fontLoaded):
- css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::fontLoaded):
LayoutTests:
- test for <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms
- fast/css/font-face-multiple-remote-sources.html: Added.
- platform/mac/fast/css/font-face-multiple-remote-sources-expected.checksum: Added.
- platform/mac/fast/css/font-face-multiple-remote-sources-expected.png: Added.
- platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt: Added.
- 5:12 PM Changeset in webkit [30391] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): Added. (WebCore::cssPropertyName): Reimplement to not use DeprecatedString. Also made faster by using a Vector<UChar> and eliminating all the string operations.
- 4:54 PM Changeset in webkit [30390] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Sam.
- Misc/WebNSAttributedStringExtras.mm: (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of DeprecatedString.
- 4:48 PM Changeset in webkit [30389] by
-
- 2 edits in trunk/WebCore
2008-02-18 Stephanie Lewis <Stephanie Lewis>
Reviewed by Adam.
Remove workaround for <rdar://problem/5695848>.
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
- 4:48 PM Changeset in webkit [30388] by
-
- 2 edits in trunk/WebKit/qt
Reviewed by Sam.
- Api/qwebnetworkinterface.cpp: (QWebNetworkRequestPrivate::init): Removed use of DeprecatedString.
- 4:25 PM Changeset in webkit [30387] by
-
- 6 edits in trunk
Reviewed by Geoff Garen.
Fix for http://bugs.webkit.org/show_bug.cgi?id=17419
Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::setDebugger):
- kjs/date_object.cpp: (KJS::dateProtoFuncGetYear):
WebCore:
Reviewed by Geoff Garen.
Fix for http://bugs.webkit.org/show_bug.cgi?id=17419
Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript):
- 3:04 PM Changeset in webkit [30386] by
-
- 2 edits in trunk/WebCore
2008-02-18 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=17381
[CURL] Regression: data URL parsing broken after DeprecatedString removal (Acid2)
This patch resolves the regression for the GTK+ port.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):
- 3:03 PM Changeset in webkit [30385] by
-
- 4 edits in trunk/WebKit/gtk
2008-02-18 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=17312
[GTK] Webview Transparent Background
Add support for WebView background transparency.
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp:
- webkit/webkitwebview.h:
- 3:03 PM Changeset in webkit [30384] by
-
- 3 edits in trunk/WebKit/gtk
2008-02-18 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Implement webkit_web_view_get_focused_frame()
Equivalent to selectedFrame in the Mac API.
- webkit/webkitwebview.cpp:
- webkit/webkitwebview.h:
- 1:43 PM Changeset in webkit [30383] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): Use String instead of DeprecatedString. (WebCore::ResourceHandle::start): Ditto.
- 1:42 PM Changeset in webkit [30382] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): Use String instead of DeprecatedString. (WebCore::cookies): Ditto.
- 1:40 PM Changeset in webkit [30381] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- removed use of DeprecatedString in the Color class
- platform/graphics/Color.cpp: (WebCore::Color::parseHexColor): Streamlined logic a bit with early returns. Used toASCIIHexValue a character at a time rather than using toIntStrict in base 16 mode. (WebCore::findNamedColor): Added. Uses a fixed-size char buffer to look up a color using the gperf-generated findColor function. Saves a memory allocation vs. the old version that called DeprecatedString::latin1(). (WebCore::Color::setNamedColor): Changed to use findNamedColor.
- 1:28 PM Changeset in webkit [30380] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
- wtf/ASCIICType.h: (WTF::toASCIIHexValue): Added.
- 1:20 PM Changeset in webkit [30379] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Changed to use String instead of DeprecatedString.
- 1:16 PM Changeset in webkit [30378] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer): Changed to use String instead of DeprecatedString.
- 12:13 PM Changeset in webkit [30377] by
-
- 7 edits3 deletes in trunk/WebCore
Reviewed and landed by Sam.
Remove DeprecatedStringList.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- editing/markup.cpp:
- platform/DeprecatedStringList.cpp: Removed.
- platform/DeprecatedStringList.h: Removed.
- platform/mac/DeprecatedStringListMac.mm: Removed.
- 11:55 AM Changeset in webkit [30376] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30370.
- 11:49 AM Changeset in webkit [30375] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- css/CSSPrimitiveValueMappings.h: Add default cases to all the switch statements. This will ease the way some day if we decide to use an enum instead of int; otherwise we'll have a ton of "unhandled enum value" warnings here.
- 11:21 AM Changeset in webkit [30374] by
-
- 2 edits in trunk/WebCore
2008-02-18 Alp Toker <alp@atoker.com>
Build fix for GTK+ < 2.10. Fall back to simple text clipboard copy
with older GTK+ versions for now.
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection):
- 10:59 AM Changeset in webkit [30373] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- WebCore.base.exp: Export a couple of WebCore::String functions we plan to use in the future in WebKit.
- 10:58 AM Changeset in webkit [30372] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam.
- DerivedSources.make: Added the scripts to the ENABLE_SVG versions of the rules for CSSPropertyNames.h and CSSValueKeywords.h. Somehow that got left out, so the files would not be regenerated if the scripts were changed (but would if SVG was disabled).
- 10:41 AM Changeset in webkit [30371] by
-
- 2 edits in trunk/WebCore
Suggested by Darin.
- platform/KURL.h: (WebCore::KURL::operator const String&): Added, to avoid unexpected conversion via UString (as in bug 17418).
- 10:23 AM Changeset in webkit [30370] by
-
- 2 edits in trunk/WebCore
2008-02-18 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Darin.
<rdar://problem/5744899> Crash in Flash when clicking "Yes" to abort
slow script Flash 9 dialog at http://www.kidzui.com
When navigating to a new page, we stop all outstanding PluginStreams.
Flash hangs in the call to NPP_URLNotify. It eventually displays the
"slow script" dialog, which relinquishes control to the system. While
this dialog is running, the request we are in the process of cancelling
completes, and we re-enter Flash to deliver the data. When the dialog
is dismissed, the internal state of Flash has changed, and Flash
crashes with a null dereference.
To work around this, we can defer loading before entering plug-in code,
so that even if a plug-in yields to the system, we won't get callbacks
while we're handling a callback.
- plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Defers loads while calling into plug-in. (WebCore::PluginStream::destroyStream): Same. (WebCore::PluginStream::deliverData): Same. (WebCore::PluginStream::didFail): Protect 'this' from deletion by destroyStream. Null out m_loader only after destroyStream returns. (WebCore::PluginStream::didFinishLoading): Same.
- 10:14 AM Changeset in webkit [30369] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=17418
REGRESSION: Assertion failure dragging image (JSLock::lockCount() > 0)
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage): Explicitly convert from KURL to String, as an implicit conversion uses UString and thus needs a JSLock.
- 7:14 AM QtWebKitTodo edited by
- (diff)
- 6:33 AM QtWebKitTodo edited by
- (diff)
- 4:15 AM QtWebKitTodo edited by
- (diff)
- 1:10 AM QtWebKitTodo edited by
- (diff)
Feb 17, 2008:
- 10:45 PM Changeset in webkit [30368] by
-
- 2 edits in trunk/WebCore
Roll out r30360.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation):
- 10:31 PM Changeset in webkit [30367] by
-
- 4 edits in branches/Safari-3-1-branch
Make JavaScriptCore and WebKit's FEATURE_DEFINES match WebCore.
- 10:25 PM Changeset in webkit [30366] by
-
- 2 edits in trunk/WebCore
Mac build fix.
- WebCore.xcodeproj/project.pbxproj:
- 9:47 PM Changeset in webkit [30365] by
-
- 1 edit in branches/Safari-3-1-branch/WebCore/ChangeLog
ChangeLog fix.
- 9:43 PM Changeset in webkit [30364] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Build fix.
- WebCore.vcproj/build-generated-files.sh:
- 6:32 PM Changeset in webkit [30363] by
-
- 3 edits in trunk/WebCore
2008-02-17 Alp Toker <alp@atoker.com>
Attempt to fix the Wx build (has been broken all weekend).
Stub out some graphics functions.
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath):
- platform/graphics/wx/PathWx.cpp: (WebCore::Path::isEmpty):
- 6:02 PM Changeset in webkit [30362] by
-
- 4 edits2 copies2 moves2 adds in trunk
2008-02-17 Julien Chaffraix <julien.chaffraix@gmail.com>
Reviewed by Alexey Proskuryakov.
http://bugs.webkit.org/show_bug.cgi?id=16989
bug 16989 : Add send() flag checks in XmlHttpRequest
- Splitted xmlhttprequest-abort-readystate in 2 test cases (xmlhttprequest-abort-readystate-shouldDispatchEvent and xmlhttprequest-abort-readystate-shouldNotDispatchEvent)
- Added test case for the 2 send() flag checks in XmlHttpRequest::send and XmlHttpRequest::setRequestHeader
- 4:22 PM Changeset in webkit [30361] by
-
- 11 edits in trunk
WebCore:
Reviewed by Dan Bernstein.
Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
- Updated fast/events/event-instanceof.html to test document.createEvent("MessageEvent").
- DerivedSources.make: Generate Objective-C binding for DOMProgressEvent which was missing.
- WebCore.xcodeproj/project.pbxproj: Add missing DOMProgressEvent files to the project.
- bindings/js/JSEventCustom.cpp: (WebCore::toJS): Clean up and add case for SVGZoomEvent that was missing.
- bindings/objc/DOMEvents.mm: (+[DOMEvent _wrapEvent:WebCore::]): Clean up and add cases for ProgressEvent and MessageEvent that were missing.
- dom/Document.cpp: (WebCore::Document::createEvent): Add case for MessageEvent.
WebKit/mac:
Reviewed by Dan Bernstein.
Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
- MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were mistakenly not migrated.
LayoutTests:
Reviewed by Dan Bernstein.
Update test for http://bugs.webkit.org/show_bug.cgi?id=17365
document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
- fast/events/event-instanceof-expected.txt:
- fast/events/resources/event-instanceof.js: Test MessageEvent as well.
- 4:14 PM Changeset in webkit [30360] by
-
- 2 edits in trunk/WebCore
2008-02-17 Adam Treat <treat@kde.org>
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=17008
Meta refresh does not work with cache turned off
Fix for issue noticed on http://adserver.vivox.com/2
- loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation):
- 3:53 PM Changeset in webkit [30359] by
-
- 2 edits in trunk/WebCore
2008-02-17 Alp Toker <alp@atoker.com>
Reviewed by Sam Weinig.
Fix for change made in r30355. Issue noticed by İsmail Dönmez.
Verify SSL certs by default, but allow checks to be disabled with an
environment variable (WEBKIT_IGNORE_SSL_ERRORS) for now.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
- 12:21 PM Changeset in webkit [30358] by
-
- 2 edits in trunk/WebKit/win
http://bugs.webkit.org/show_bug.cgi?id=17397
<rdar://problem/5748245> REGRESSION (r30236-30336): Cannot backspace/enter in forms on Windows
- WebKit.vcproj/WebKit.vcproj: Add ENABLE_CROSS_DOCUMENT_MESSAGING definitions.
- 11:28 AM Changeset in webkit [30357] by
-
- 5 edits in trunk/LayoutTests
Reviewed by Mark Rowe.
- disable the non-ASCII parts of a test case for the ASCII code path because it is failing on the (Tiger) buildbots for an unrelated reason.
- fast/text/fixed-pitch-control-characters.html:
- platform/mac/fast/text/fixed-pitch-control-characters-expected.checksum:
- platform/mac/fast/text/fixed-pitch-control-characters-expected.png:
- platform/mac/fast/text/fixed-pitch-control-characters-expected.txt:
- 9:59 AM Changeset in webkit [30356] by
-
- 2 edits in trunk/JavaScriptCore
- wtf/ListHashSet.h: (WTF::swap): Removed stray return statement.
- 7:36 AM Changeset in webkit [30355] by
-
- 2 edits in trunk/WebCore
2008-02-17 Bin Chen <binary.chen@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=17404
Bug 17404: curl certification problem
Disable SSL cert verification until we have a way of distributing
certs and/or reporting SSL errors to the user.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):
- 7:09 AM Changeset in webkit [30354] by
-
- 2 edits in trunk/WebCore
2008-02-17 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
DevHelp fails to load local files; URL truncated by one character.
Fix a file:// URL regression introduced in KURL.cpp r30243.
- platform/KURL.cpp: (WebCore::KURL::KURL):
- 4:12 AM Changeset in webkit [30353] by
-
- 2 edits in trunk/WebKit/gtk
2008-02-17 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Mark Rowe.
Fix a crash introduced in changeset #29985 by moving the dereference to after
the null check.
- webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
- 2:46 AM Changeset in webkit [30352] by
-
- 15 edits in branches/Safari-3-1-branch
Merge r30331.
- 2:45 AM Changeset in webkit [30351] by
-
- 5 edits in branches/Safari-3-1-branch
Merge r30330.
- 2:44 AM Changeset in webkit [30350] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30329.
- 2:43 AM Changeset in webkit [30349] by
-
- 7 edits in branches/Safari-3-1-branch
Merge r30328.
- 2:42 AM Changeset in webkit [30348] by
-
- 23 edits1 move2 adds in branches/Safari-3-1-branch
Merge r30326.
- 2:40 AM Changeset in webkit [30347] by
-
- 23 edits1 add in branches/Safari-3-1-branch/WebCore
Merge r30325.
- 2:39 AM Changeset in webkit [30346] by
-
- 8 edits1 copy5 adds in branches/Safari-3-1-branch
Merge r30323.
- 1:03 AM WebKit Team edited by
- Edited my entry to humor Sam (diff)
- 12:50 AM Changeset in webkit [30345] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17033 <rdar://problem/5709315> REGRESSION: Really long <option> causes unnecessary page scroll bars to accommodate content
Test: fast/forms/control-clip-overflow.html
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): Account for control clipping. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.
LayoutTests:
Reviewed by Darin Adler.
- test for http://bugs.webkit.org/show_bug.cgi?id=17033 <rdar://problem/5709315> REGRESSION: Really long <option> causes unnecessary page scroll bars to accommodate content
- fast/forms/control-clip-overflow.html: Added.
- platform/mac/fast/forms/control-clip-overflow-expected.checksum: Added.
- platform/mac/fast/forms/control-clip-overflow-expected.png: Added.
- platform/mac/fast/forms/control-clip-overflow-expected.txt: Added.
Feb 16, 2008:
- 9:48 PM Changeset in webkit [30344] by
-
- 2 edits in trunk/WebCore
Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Reviewed by Eric S
Use cross-platform code to determine the dirty rects for
fill and stroke operations
- 7:43 PM Changeset in webkit [30343] by
-
- 8 edits in trunk/WebCore
Reviewed by Darin Adler.
Take another step in the direction of getting rid of DeprecatedString
by moving all the to{NumericType} off of it.
- Create free functions that take a UChar* buffer and length to do the string-to-number conversions. This allows us to avoid two allocations if we don't already have a String and is consistent with the design we would like going forward.
- Since the toInt (and family) functions on DeprecatedString were slightly different than the ones on String (they didn't allow trailing garbage), an extra set of 'Strict' toInt functions were added that have this behavior.
- platform/graphics/Color.cpp: (WebCore::Color::parseHexColor):
- platform/text/PlatformString.h:
- platform/text/String.cpp: (WebCore::String::percentage): (WebCore::String::toIntStrict): (WebCore::String::toUIntStrict): (WebCore::String::toInt64Strict): (WebCore::String::toUInt64Strict): (WebCore::String::toUInt): (WebCore::String::toDouble): (WebCore::isCharacterAllowedInBase): (WebCore::toIntegralType): (WebCore::lengthOfCharactersAsInteger): (WebCore::charactersToIntStrict): (WebCore::charactersToUIntStrict): (WebCore::charactersToInt64Strict): (WebCore::charactersToUInt64Strict): (WebCore::charactersToInt): (WebCore::charactersToUInt): (WebCore::charactersToInt64): (WebCore::charactersToUInt64): (WebCore::charactersToDouble): (WebCore::charactersToFloat):
- platform/text/StringImpl.cpp: (WebCore::parseLength): (WebCore::StringImpl::toIntStrict): (WebCore::StringImpl::toUIntStrict): (WebCore::StringImpl::toInt64Strict): (WebCore::StringImpl::toUInt64Strict): (WebCore::StringImpl::toInt): (WebCore::StringImpl::toUInt): (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64): (WebCore::StringImpl::toDouble): (WebCore::StringImpl::toFloat):
- platform/text/StringImpl.h:
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseClockValue):
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
- 7:08 PM Changeset in webkit [30342] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix fixed-pitch font measurement of control characters that render as zero-width space
Test: fast/text/fixed-pitch-control-characters.html
- rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache):
LayoutTests:
Reviewed by Sam Weinig.
- test fixed-pitch font measurement of control characters that render as zero-width space
- fast/text/fixed-pitch-control-characters.html: Added.
- platform/mac/fast/text/fixed-pitch-control-characters-expected.checksum: Added.
- platform/mac/fast/text/fixed-pitch-control-characters-expected.png: Added.
- platform/mac/fast/text/fixed-pitch-control-characters-expected.txt: Added.
- 2:04 PM Changeset in webkit [30341] by
-
- 2 edits in trunk/WebCore
wx build fix.
- 1:06 PM WebKit Team edited by
- Add areas of knowledge for Sam Weinig (diff)
- 1:02 PM WebKit Team edited by
- Remove Tristan as he is no longer at Apple (diff)
- 9:41 AM Changeset in webkit [30340] by
-
- 1 edit3 moves in trunk/LayoutTests
- disable some failing tests; someone can re-enable after fixing the problems causing them to fail or generating new expected results
- fast/frames/iframe-scroll-page-up-down.html: Removed.
- fast/frames/iframe-scroll-page-up-down.html-disabled: Copied from fast/frames/iframe-scroll-page-up-down.html.
- svg/batik/text/textBiDi.svg: Removed.
- svg/batik/text/textBiDi.svg-disabled: Copied from svg/batik/text/textBiDi.svg.
- svg/custom/use-on-symbol-inside-pattern.svg: Removed.
- svg/custom/use-on-symbol-inside-pattern.svg-disabled: Copied from svg/custom/use-on-symbol-inside-pattern.svg.
- 9:35 AM Changeset in webkit [30339] by
-
- 1 edit in trunk/WebCore/ChangeLog
Clean up some old log entries.
- 3:09 AM Changeset in webkit [30338] by
-
- 2 edits in trunk/WebCore
2008-02-16 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Alp Toker.
Cross document messaging GTK+/autotools build fix.
- GNUmakefile.am:
Feb 15, 2008:
- 10:44 PM Changeset in webkit [30337] by
-
- 3 edits in trunk/WebCore
Build fix for Qt and Cairo builds
- 10:00 PM Changeset in webkit [30336] by
-
- 8 edits in trunk/WebCore
Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Refactor CanvasRenderingContext2D::drawImage(HTMLCanvasElement) to remove evil ifdefs
Reviewed by Dan B.
Add logic draw(ImageBuffer*) method to GraphicsContext to handle
painting the source canvas content.
- 9:57 PM Changeset in webkit [30335] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Oliver Hunt.
- skip a test for a Leopard-only NSHTTPURLResponse bug workaround
- platform/mac-tiger/Skipped:
- 7:23 PM Changeset in webkit [30334] by
-
- 2 edits in trunk/WebCore
Using GetNativeFontInfoDesc() to generate the hash value was leading to duplicate entries in the HashMap. Use the font object's pointer instead.
- 6:51 PM Changeset in webkit [30333] by
-
- 2 edits in trunk/WebCore
When parsing url we get from a CFURLRef, we need to null terminate
the string for the case when url ends with a '/'.
Reviewed by Darin.
- platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL):
- 6:02 PM Changeset in webkit [30332] by
-
- 2 edits in trunk/LayoutTests
Added 2 skipped tests
- platform/mac-tiger/Skipped:
- 4:51 PM Changeset in webkit [30331] by
-
- 15 edits in trunk
WebCore:
Reviewed by Darin
Fix for <rdar://problem/5727175> and <rdar://problem/5740495> - Database threads and callback scripts can run after
a page has closed or loaded a new document
Deciding to make the Database I/O semantic the same as loaders/XHR when a document is shut down, this patch implements
a policy of shutting down the databases in a document at the same time. This includes removing all pending transactions
in a database, cutting off an queued statements in the current transaction, and preventing further callbacks from being
made.
No new layout tests with this patch as the current layout tests were catching this issue in a plethora of ways already
(crashing, unexpected exceptions and output, etc)
- dom/Document.cpp: (WebCore::Document::~Document): Don't actually stop the database thread here - it better have been stopped already. Add an assertion to that effect. (WebCore::Document::addOpenDatabase): Add a new database handle to this Document's open database set (WebCore::Document::removeOpenDatabase): Remove such a handle (WebCore::Document:: stopDatabases): Call "close" on all open Database handles for this document
- dom/Document.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): In addition to canceling all resource loads and XHRs, stop all database I/O
- platform/MessageQueue.h: (WebCore::MessageQueue::killed):
- platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop): Added. Explicit stop to cut off a transaction so it won't try anymore SQL activity
- platform/sql/SQLiteTransaction.h:
- storage/Database.cpp: (WebCore::Database::Database): (WebCore::Database::~Database): (WebCore::Database::markAsDeletedAndClose): Check if the thread has terminated before committing to waiting on the thread. (WebCore::Database::stop): Stop this database, including all queued transactions and callbacks
- storage/Database.h: (WebCore::Database::stopped):
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::terminationRequested):
- storage/DatabaseThread.h:
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL): Throw an exception if a new executeSQL comes in after a database is closed (WebCore::SQLTransaction::checkAndHandleClosedDatabase): Added. Clears queued statements and clear the next step when the database has been closed since the last step/callback was run. Also stops the current SQLite transaction, if any (WebCore::SQLTransaction::performNextStep): (WebCore::SQLTransaction::performPendingCallback):
- storage/SQLTransaction.h:
LayoutTests:
Reviewed by Darin
Fix for <rdar://problem/5727175> and <rdar://problem/5740495> - Database threads and callback scripts can run after
a page has closed or loaded a new document
- storage/close-during-stress-test-expected.txt: Update results - this test contained output from a javascript callback that never should have taken place
- 4:44 PM Changeset in webkit [30330] by
-
- 5 edits in trunk
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/5745072> REGRESSION (r29348): Shift + Tab does not change indent level on Google Docs
The immediate cause of this bug was that we stopped sending keypress events for the tab key when it is used to advance focus.
We had a special case for forward-tab in designMode, where the default behavior was to insert a tab key (or respect the keypress handler behavior).
This change makes the shift-tab behavior match the forward-tab behavior.
If the site had put their event handler (which does the indenting) on the keydown event, then this problem would have been avoided.
This is something we should look into and maybe advise the site on in the future. However, it's a low-risk change to just make tab and shift-tab uniform
in this respect, so I think this is the way to go for right now.
- page/EventHandler.cpp: (WebCore::EventHandler::defaultTabEventHandler):
LayoutTests:
Reviewed by Darin.
Updated test for <rdar://problem/5745072> REGRESSION (r29348): Shift + Tab does not change indent level on Google Docs
- editing/inserting/typing-tab-designmode-expected.txt:
- editing/inserting/typing-tab-designmode.html:
- 3:47 PM Changeset in webkit [30329] by
-
- 2 edits in trunk/WebCore
Reviewed by Alice.
<rdar://problem/5738678>
REGRESSION: "Loading" status remains when uploading file to .Mac iDisk via Safari
Use the new CFNetwork functions for setting body parts.
- platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody): (WebCore::httpBodyFromRequest):
- 3:39 PM Changeset in webkit [30328] by
-
- 7 edits in trunk
WebCore:
Reviewed by Anders Carlsson.
Fixed <rdar://problem/5725429> REGRESSION (r27898): Greenfield online
surveys no longer work due to XMLHttpRequest exceptions
Reverted some exception throwing code from r12194.
To comply with the W3C draft spec, we used to throw an exception when
trying to access responseText and responseXML at the wrong time, but
that turned out to be a compatibility problem.
Now, matching Firefox and previous versions of WebKit, we never throw
an exception when accessing responseText or responseXML.
See http://www.mail-archive.com/public-webapi@w3.org/msg02756.html.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML):
LayoutTests:
Reviewed by Anders Carlsson.
Fixed <rdar://problem/5725429> REGRESSION (r27898): Greenfield online
surveys no longer work due to XMLHttpRequest exceptions
Updated layout tests to expect an exception not to be thrown.
- http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html:
- http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html:
- http/tests/xmlhttprequest/zero-length-response-expected.txt:
- http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:
- 3:27 PM Changeset in webkit [30327] by
-
- 1 edit in trunk/WebCore/ChangeLog
minor correction to my last Changlog entry.
- 3:25 PM Changeset in webkit [30326] by
-
- 23 edits3 adds1 delete in trunk
WebCore:
Reviewed by Dan Bernstein.
<rdar://problem/5738768> REGRESSION (r30062): Crash in InlineTextBox::isLineBreak() when Undoing a replace
Rolled out <http://trac.webkit.org/projects/webkit/changeset/29667>
- editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved):
LayoutTests:
Reviewed by Dan Bernstein.
<rdar://problem/5738768> REGRESSION (r30062): Crash in InlineTextBox::isLineBreak() when Undoing a replace
Disabled:
- editing/selection/inconsistent-in-removeChildNode.html: Removed.
- editing/selection/inconsistent-in-removeChildNode.html-disabled: Added.
Demonstrates fix:
- editing/undo/5738768-expected.txt: Added.
- editing/undo/5738768.html: Added.
During a shouldChangeSelection call, the old selection is no longer null because
nodeWillBeRemoved doesn't blow it away:
- platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
- platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
- platform/mac/editing/style/remove-underline-in-bold-expected.txt:
During a shouldChangeSelection call, the old selection is now null because
nodeWillBeRemoved blows it away:
- platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
More instances of <rdar://problem/5729315>, where, during a shouldChangeSelection
call content that held the old selection is still around but it wouldn't make sense
to leave the selection there, so we shouldn't call shouldChangeSelection at all:
- platform/mac/editing/style/remove-underline-expected.txt:
- platform/mac/editing/style/unbold-in-bold-expected.txt:
Similar changes, but ones where I've also updated pixel results for old, unrelated fixes:
- platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
- platform/mac/editing/deleting/delete-leading-ws-001-expected.checksum:
- platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
- platform/mac/editing/deleting/delete-line-011-expected.checksum:
- platform/mac/editing/deleting/delete-line-011-expected.txt:
- platform/mac/editing/execCommand/paste-1-expected.checksum:
- platform/mac/editing/execCommand/paste-1-expected.txt:
- platform/mac/editing/execCommand/paste-2-expected.checksum:
- platform/mac/editing/execCommand/paste-2-expected.txt:
- platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.checksum:
- platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
- platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
- platform/mac/editing/pasteboard/paste-text-012-expected.checksum:
- platform/mac/editing/selection/4960116-expected.checksum:
- 3:18 PM Changeset in webkit [30325] by
-
- 23 edits1 add in trunk/WebCore
Reviewed by Darin.
Fixed <rdar://problem/5741440> REGRESSION (r28496): After deactivating JavaScript, scripts embedded in the HTML page continue to run
Before this patch, Frame::scriptProxy() would only return null in the case that javascript was
disabled and if the script proxy field wasn't set (which would only be the case if the window
hasn't loaded anything yet). Not all callers of scriptProxy() always check for a non-null return
value. Those that did check would effectively be checking if javascript was enabled before proceeding.
This fix consists of 2 elements: first, make sure that scriptProxy() will never return null, regardless
of whether javascript is disabled. This will mean that callers who don't check for null won't crash.
Second, callers who did check for null now instead check for javascript being disabled. This means that
code paths intended for preventing javascript from being run will be making the correct check. Another
minor addition to this patch is that I added a function on Frame to be a shortcut for checking if javascript
is enabled.
- bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
- bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
- bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
- bindings/js/kjs_html.cpp: (WebCore::runtimeObjectImplementsCall):
- bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::isEnabled):
- bindings/js/kjs_proxy.h:
- bindings/js/kjs_window.cpp: (KJS::Window::retrieveWindow): (KJS::Window::retrieve):
- dom/Document.cpp: (WebCore::Document::createHTMLEventListener):
- dom/EventTarget.cpp: (WebCore::EventTarget::dispatchGenericEvent):
- html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createNPObject):
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::userGestureHint): (WebCore::FrameLoader::open): (WebCore::FrameLoader::dispatchWindowObjectAvailable): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- manual-tests/disable-javascript-reload.html: Added.
- page/Frame.cpp: (WebCore::Frame::scriptProxy): (WebCore::Frame::bindingRootObject): (WebCore::Frame::windowScriptNPObject):
- page/Frame.h:
- page/InspectorController.cpp: (WebCore::canPassNodeToJavaScript):
- page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::createSVGEventListener):
- 2:30 PM Changeset in webkit [30324] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30285.
- 1:30 PM Changeset in webkit [30323] by
-
- 8 edits6 adds in trunk
WebCore:
Reviewed by Alexey Proskuryakov.
- WebCore part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360 <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
Test: http/tests/loading/text-content-type-with-binary-extension.html
Refined the workaround for <rdar://problem/5321972> to exclude files
with extensions that are known to be associated with binary MIME types.
- WebCore.xcodeproj/project.pbxproj: Added WebCoreURLResponse.{h,mm}.
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Moved the workaround logic into WebCoreURLResponse.
- platform/network/mac/WebCoreURLResponse.h: Added.
- platform/network/mac/WebCoreURLResponse.mm: Added. (createBinaryExtensionsSet): Returns a set of extensions known to belong to MIME types of binary data. (-[NSURLResponse _webcore_MIMEType]): (-[NSHTTPURLResponse _webcore_MIMEType]): Forces the MIME type from application/octet-stream to text/plain if that is the specified Content-Type, unless the extension is in the binary extensions set.
WebKit/mac:
Reviewed by Alexey Proskuryakov.
- WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360 <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
- WebView/WebDataSource.mm: (+[WebDataSource _representationClassForMIMEType:]): (-[WebDataSource _responseMIMEType]): (-[WebDataSource subresources]): (-[WebDataSource subresourceForURL:]):
- WebView/WebResource.mm: (-[WebResource _initWithData:URL:response:]):
- WebView/WebResourcePrivate.h:
LayoutTests:
Reviewed by Alexey Proskuryakov.
- test for http://bugs.webkit.org/show_bug.cgi?id=17360 <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
- http/tests/loading/resources/.htaccess: Added.
- http/tests/loading/resources/binaryData.m4a: Added.
- http/tests/loading/text-content-type-with-binary-extension-expected.txt: Added.
- http/tests/loading/text-content-type-with-binary-extension.html: Added.
- 1:28 PM Changeset in webkit [30322] by
-
- 6 edits in branches/Safari-3-1-branch
Merge r30276.
- 1:27 PM Changeset in webkit [30321] by
-
- 17 edits in branches/Safari-3-1-branch
Merge r30269.
- 1:26 PM Changeset in webkit [30320] by
-
- 1 edit1 add in trunk/LayoutTests
Reviewed and rubber-stamped by Oliver Hunt.
Add leopard specific results for stroke-width-click.svg to work around
a CG regression.
- platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Added.
- 1:08 PM Changeset in webkit [30319] by
-
- 3 edits1 add in trunk/WebCore
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=17306 <rdar://problem/5737923> Transitions between styles that have different transition-* properties behave inconsistently
- manual-tests/transitions.html: Added.
- page/AnimationController.cpp: (WebCore::CompositeImplicitAnimation::animate): Changed to use the transition properties of the current style rather than the target style. (WebCore::AnimationControllerPrivate::get): Changed to not create an animation if the style does not have transitions. (WebCore::AnimationController::updateImplicitAnimations): Added code to return the target style if the current style is not animating.
- rendering/RenderObject.cpp: (WebCore::RenderObject::setAnimatableStyle): Changed to call updateImplicitAnimations() even if the current style does not have transitions, because we may be animating out of a style that had them.
- 12:44 PM Changeset in webkit [30318] by
-
- 2 edits in branches/Safari-3-1-branch/WebKitTools
Merge r30242.
- 12:44 PM Changeset in webkit [30317] by
-
- 3 edits in branches/Safari-3-1-branch/LayoutTests
Merge r30241.
- 12:43 PM Changeset in webkit [30316] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30240.
- 12:43 PM Changeset in webkit [30315] by
-
- 6 edits in branches/Safari-3-1-branch
Merge r30239.
- 12:42 PM Changeset in webkit [30314] by
-
- 14 edits2 adds in branches/Safari-3-1-branch
Merge r30238.
- 12:41 PM Changeset in webkit [30313] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30237.
- 12:41 PM Changeset in webkit [30312] by
-
- 3 edits3 adds in branches/Safari-3-1-branch
Merge r30235.
- 12:40 PM Changeset in webkit [30311] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30233.
- 12:40 PM Changeset in webkit [30310] by
-
- 10 edits in branches/Safari-3-1-branch
Merge r30222.
- 12:39 PM Changeset in webkit [30309] by
-
- 3 edits in branches/Safari-3-1-branch/WebCore
Merge r30218.
- 12:38 PM Changeset in webkit [30308] by
-
- 3 edits2 adds in branches/Safari-3-1-branch
Merge r30213.
- 12:37 PM Changeset in webkit [30307] by
-
- 2 edits in branches/Safari-3-1-branch/WebKit/win
Merge r30206.
- 12:06 PM Changeset in webkit [30306] by
-
- 1 edit1 delete in trunk/WebCore
Rubber-stamped by Darin.
Remove an obsolete WebCore readme file.
- README: Removed.
- 11:46 AM Changeset in webkit [30305] by
-
- 7 edits4 adds in branches/Safari-3-1-branch
Merge r30195.
- 11:45 AM Changeset in webkit [30304] by
-
- 3 edits3 adds in branches/Safari-3-1-branch
Merge r30191.
- 11:45 AM Changeset in webkit [30303] by
-
- 1 edit in branches/Safari-3-1-branch/WebCore/platform/sql/SQLiteDatabase.cpp
Merge r30190.
- 11:44 AM Changeset in webkit [30302] by
-
- 7 edits in branches/Safari-3-1-branch/WebCore
Merge r30189.
- 11:44 AM Changeset in webkit [30301] by
-
- 5 edits in branches/Safari-3-1-branch/WebCore
Merge r30184.
- 11:43 AM Changeset in webkit [30300] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30179.
- 11:43 AM Changeset in webkit [30299] by
-
- 2 edits in branches/Safari-3-1-branch/JavaScriptCore
Merge r30177.
- 11:42 AM Changeset in webkit [30298] by
-
- 2 edits2 adds in branches/Safari-3-1-branch/LayoutTests
Merge r30176.
- 11:42 AM Changeset in webkit [30297] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30174.
- 11:41 AM Changeset in webkit [30296] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30173.
- 11:41 AM Changeset in webkit [30295] by
-
- 13 edits3 adds in branches/Safari-3-1-branch/WebCore
Merge r30172.
- 11:40 AM Changeset in webkit [30294] by
-
- 3 edits3 adds in branches/Safari-3-1-branch
Merge r30171.
- 10:29 AM Changeset in webkit [30293] by
-
- 13 edits in trunk/WebCore
Reviewed by Darin Adler.
Remove more uses of DeprecatedString in preparation of getting rid of it.
- bridge/mac/WebCoreScriptDebugger.mm:
- css/CSSCursorImageValue.cpp: (WebCore::isSVGCursorIdentifier): (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
- css/CSSStyleSelector.h:
- dom/Element.cpp: (WebCore::Element::dump): (WebCore::Element::formatForDebugger):
- dom/Position.cpp: (WebCore::Position::debugPosition): (WebCore::Position::formatForDebugger):
- dom/Range.cpp: (WebCore::Range::formatForDebugger):
- dom/Text.cpp: (WebCore::Text::formatForDebugger):
- editing/Selection.cpp: (WebCore::Selection::debugPosition): (WebCore::Selection::formatForDebugger):
- editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::debugPosition):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::notifyFinished):
- svg/SVGFontFaceElement.cpp: (WebCore::mapAttributeToCSSProperty):
- 10:25 AM Changeset in webkit [30292] by
-
- 3 edits4 adds in branches/Safari-3-1-branch
Merge r30162.
- 10:25 AM Changeset in webkit [30291] by
-
- 2 edits in trunk
2008-02-15 Alp Toker <alp@atoker.com>
Reviewed by Holger.
GTK+ configure script cleanups
Categorize the configuration summary printout.
Bump GTK+ requirement to 2.8.
Rename 'webkit_target' to just 'target'.
Don't check for pthread on Win32.
- configure.ac:
- 10:24 AM Changeset in webkit [30290] by
-
- 4 edits in branches/Safari-3-1-branch/JavaScriptCore
Merge r30158.
- 10:24 AM Changeset in webkit [30289] by
-
- 21 edits2 copies15 adds2 deletes in branches/Safari-3-1-branch
Merge r30157.
- 10:22 AM Changeset in webkit [30288] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30154.
- 10:22 AM Changeset in webkit [30287] by
-
- 2 edits4 adds in branches/Safari-3-1-branch
Merge r30153.
- 10:18 AM Changeset in webkit [30286] by
-
- 3 edits in branches/Safari-3-1-branch/WebCore
Merge r30146.
- 10:04 AM Changeset in webkit [30285] by
-
- 2 edits in trunk/WebCore
- bindings/scripts/CodeGenerator.pm: Touch this to force bindings to regenerate.
- 9:58 AM Changeset in webkit [30284] by
-
- 2 edits in branches/Safari-3-1-branch/LayoutTests
Remove MessageEvent output from window-properties.html since that interface will be disabled as well
Reviewed by Sam.
- fast/dom/Window/window-properties-expected.txt:
- 9:56 AM Changeset in webkit [30283] by
-
- 2 edits in branches/Safari-3-1-branch/WebKit/mac
Merge r30120.
- 9:56 AM Changeset in webkit [30282] by
-
- 2 edits in branches/Safari-3-1-branch/WebKit/mac
Merge r30119.
- 9:55 AM Changeset in webkit [30281] by
-
- 3 edits4 adds in branches/Safari-3-1-branch
Merge r30116.
- 9:55 AM Changeset in webkit [30280] by
-
- 1 edit in branches/Safari-3-1-branch/WebCore/css/CSSStyleSelector.cpp
Merge r30115.
- 9:54 AM Changeset in webkit [30279] by
-
- 4 edits in branches/Safari-3-1-branch/WebCore/rendering
Merge r30114.
- 9:54 AM Changeset in webkit [30278] by
-
- 1 edit in branches/Safari-3-1-branch/WebCore/css/CSSStyleSelector.cpp
Merge r30113.
- 9:54 AM Changeset in webkit [30277] by
-
- 70 edits in branches/Safari-3-1-branch/WebCore
Merge r30112.
- 9:49 AM Changeset in webkit [30276] by
-
- 6 edits in trunk
Mac build fix
Make JavaScriptCore's FEATURE_DEFINES match WebCore's
Reviewed by Mark.
- Configurations/JavaScriptCore.xcconfig:
WebKit/mac:
Make WebKit's FEATURE_DEFINES match WebCore's
Reviewed by Mark.
- Configurations/WebKit.xcconfig:
WebKitTools:
Fix a typo that broke the Mac build
Reviewed by Mark.
- Scripts/build-webkit:
- 9:13 AM Changeset in webkit [30275] by
-
- 6 edits in branches/Safari-3-1-branch
Merge r30105.
- 9:12 AM Changeset in webkit [30274] by
-
- 8 edits in branches/Safari-3-1-branch/WebCore
Merge r30104.
- 9:12 AM Changeset in webkit [30273] by
-
- 3 edits2 adds in branches/Safari-3-1-branch
Merge r30101.
- 9:04 AM Changeset in webkit [30272] by
-
- 2 edits in trunk/WebCore
Try to fix Qt/GTK+ builds
- WebCore.pro: Remove MessageEvent.{idl,cpp} from the unconditional parts of this file.
- 8:51 AM Changeset in webkit [30271] by
-
- 4 edits in branches/Safari-3-1-branch/LayoutTests
Disable postMessage tests since postMessage is disabled
Reviewed by Mitz.
- fast/dom/Window/window-properties-expected.txt: Updated result.
- platform/mac/Skipped: Skip tests that depend on postMessage
- platform/win/Skipped: Ditto.
- 8:36 AM Changeset in webkit [30270] by
-
- 8 edits in trunk
Turn on cross-document messaging support by default
top level:
Turn on cross-document messaging support by default
Reviewed by Darin.
- configure.ac:
WebCore:
Turn on cross-document messaging support by default
Reviewed by Darin.
- Configurations/WebCore.xcconfig:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
WebKitTools:
Turn on cross-document messaging support by default
Reviewed by Darin.
- Scripts/build-webkit:
- 8:36 AM Changeset in webkit [30269] by
-
- 17 edits in trunk
Conditionalize cross-document messaging support
top level:
Conditionalize cross-document messaging support
The cross-document messaging parts of HTML 5 are in flux and we want
ports to be able to turn off the support as needed.
Note that the support is turned off by default right now. A subsequent
commit will turn it on by default.
Reviewed by Darin.
- configure.ac:
WebCore:
Conditionalize cross-document messaging support
The cross-document messaging parts of HTML 5 are in flux and we want
ports to be able to turn off the support as needed.
Note that the support is turned off by default right now. A subsequent
commit will turn it on by default.
Reviewed by Darin.
- GNUmakefile.am:
- WebCore.vcproj/build-generated-files.sh:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
- bindings/js/JSEventCustom.cpp: (WebCore::toJS):
- dom/Event.cpp: (WebCore::Event::isMessageEvent):
- dom/Event.h:
- dom/MessageEvent.cpp:
- dom/MessageEvent.h:
- dom/MessageEvent.idl:
- page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage):
- page/DOMWindow.h:
- page/DOMWindow.idl:
WebKitTools:
Conditionalize cross-document messaging support
The cross-document messaging parts of HTML 5 are in flux and we want
ports to be able to turn off the support as needed.
Note that the support is turned off by default right now. A subsequent
commit will turn it on by default.
Reviewed by Darin.
- Scripts/build-webkit:
- 7:18 AM Changeset in webkit [30268] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Adam.
- quick fix for a problem causing an assertion on launch
- WebFrame.cpp: (WebFrame::loadData): Make an empty KURL even if the BSTR is null. Later we might want to rethink this.
- 3:41 AM Changeset in webkit [30267] by
-
- 3 edits in trunk/WebKit/gtk
2008-02-15 Alp Toker <alp@atoker.com>
Fix the GTK+ build following breakage introduced in r30243.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::objectContentType):
- 2:53 AM Changeset in webkit [30266] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30098.
- 2:52 AM Changeset in webkit [30265] by
-
- 5 edits in branches/Safari-3-1-branch/WebCore
Merge r30097.
- 2:52 AM Changeset in webkit [30264] by
-
- 4 edits5 adds in branches/Safari-3-1-branch
Merge r30096.
- 1:53 AM Changeset in webkit [30263] by
-
- 5 edits in branches/Safari-3-1-branch
Merge r30087.
- 1:52 AM Changeset in webkit [30262] by
-
- 7 edits1 add in branches/Safari-3-1-branch/WebKit/win
Merge r30086.
- 1:51 AM Changeset in webkit [30261] by
-
- 3 edits in branches/Safari-3-1-branch/WebCore
Merge r30085.
- 1:51 AM Changeset in webkit [30260] by
-
- 4 edits in branches/Safari-3-1-branch/WebKitLibraries
Merge r30084.
- 1:33 AM Changeset in webkit [30259] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30081.
- 1:33 AM Changeset in webkit [30258] by
-
- 3 edits in branches/Safari-3-1-branch/WebCore
Merge r30080.
- 1:32 AM Changeset in webkit [30257] by
-
- 4 edits2 adds in branches/Safari-3-1-branch/WebCore
Merge r30079.
- 1:31 AM Changeset in webkit [30256] by
-
- 23 edits in branches/Safari-3-1-branch/WebCore
Merge r30078.
- 1:30 AM Changeset in webkit [30255] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30077.
- 1:30 AM Changeset in webkit [30254] by
-
- 12 edits in branches/Safari-3-1-branch/WebCore
Merge r30076.
- 1:29 AM Changeset in webkit [30253] by
-
- 2 edits in branches/Safari-3-1-branch/WebCore
Merge r30075.
- 12:21 AM Changeset in webkit [30252] by
-
- 2 edits in trunk/WebCore
- another Qt build fix
- platform/qt/KURLQt.cpp: (WebCore::KURL::operator QUrl): Use the characters directly, not ascii(). Eliminate references to urlString.
- 12:12 AM Changeset in webkit [30251] by
-
- 4 edits in trunk
WebCore:
- another Qt build fix
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage): Use KURL instead of String.
WebKit/gtk:
- another try at fixing the build
- webkit/webkitwebview.cpp: Added some explicit conversions to KURL.
Feb 14, 2008:
- 11:23 PM Changeset in webkit [30250] by
-
- 3 edits in trunk/WebCore
- another round of build fixes
- platform/KURL.cpp: (WebCore::appendEncodedHostname): Fix spelling (strLen, not strlen).
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Fix a ".." typo and call data instead of characters.
- 10:45 PM Changeset in webkit [30249] by
-
- 1 edit3 copies in trunk/WebCore
- added back accidentally-removed files
- platform/DeprecatedStringList.cpp: Copied from platform/DeprecatedStringList.cpp.
- platform/DeprecatedStringList.h: Copied from platform/DeprecatedStringList.h.
- platform/mac/DeprecatedStringListMac.mm: Copied from platform/mac/DeprecatedStringListMac.mm.
- 10:38 PM Changeset in webkit [30248] by
-
- 4 edits3 deletes in trunk/WebCore
- more build fixes
- platform/KURL.cpp: (WebCore::appendEncodedHostname): Use String to make a QString.
- platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Updated to String rather than DeprecatedString functions.
- 10:03 PM Changeset in webkit [30247] by
-
- 3 edits in trunk/LayoutTests
Make assign-to-window-status testcase to be more thorough
Reviewed by Jon H
- 9:36 PM Changeset in webkit [30246] by
-
- 2 edits in trunk/WebCore
- next Qt build fix
- platform/network/qt/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.
- 9:29 PM Changeset in webkit [30245] by
-
- 2 edits in trunk/WebCore
- another build fix
- platform/network/curl/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed a stray deprecatedString() call.
- 9:14 PM Changeset in webkit [30244] by
-
- 2 edits in trunk/WebCore
- first Qt build fix
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): Added a missing string() call.
- 9:03 PM Changeset in webkit [30243] by
-
- 177 edits in trunk
WebCore:
Reviewed by Eric Seidel.
Based on work by Marvin Decker <marv.decker@gmail.com>
- fix http://bugs.webkit.org/show_bug.cgi?id=16538 KURL should use String instead of DeprecatedString
- fix http://bugs.webkit.org/show_bug.cgi?id=16485 DocLoader::checkForReload will crash if the URL isNull and a similar problem in IconDatabase
- fix http://bugs.webkit.org/show_bug.cgi?id=16487 KURL doesn't preserve isNull when constructed with a DeprecatedString
- changed completeURL and various DOM getters to return KURL, to avoid conversion back and forth from KURL to String
- changed the conversion of KURL to NSURL or NSString to be automatic, to ease the use of KURL in Objective C DOM bindings, and eliminated the getNSURL function
- because I had to visit the DOM bindings anyway, eliminated almost all the use of the KJS namespace for things in WebCore
- fixed HTMLOptionElement constructor to check for undefined rather than size of the arguments array
- eliminated some other unnecessary uses of DeprecatedString
- changed String::split to take a Vector parameter instead of returning a Vector, for better performance
- added a couple of missing calls to do layout in SVG image handling; I was able to reproduce these only because I had broken URLs for a while -- not sure how to reproduce them now but the changes are clearly needed
Performance testing shows this to be at least a 1% speedup.
Added a new function protocolIs to efficiently compare protocols
without case errors and a blankURL function so we don't have to
code "about:blank" in multiple places in the code and don't have to
construct a frash KURL each time. Moved decode_string and encode_string
out of KURL and gave them clearer names.
Made KURL constructors explicit to highlight potentially-expensive
operations and the poor semantics of KURL's constructor that takes
a String.
- WebCore.base.exp: Updated.
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue): Use protocolIs.
- bindings/js/JSAudioConstructor.h: KJS namespace change.
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): Ditto.
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): Ditto.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): Ditto. (WebCore::JSDocument::setLocation): Updated for KURL change. (WebCore::toJS): KJS namespace change.
- bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL): Use protocolIs. (WebCore::JSElement::setAttribute): KJS namespace change. (WebCore::JSElement::setAttributeNode): Ditto. (WebCore::JSElement::setAttributeNS): Ditto. (WebCore::JSElement::setAttributeNodeNS): Ditto.
- bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL): Use protocolIs. (WebCore::JSHTMLFrameElement::setSrc): KJS namespace change. (WebCore::JSHTMLFrameElement::setLocation): Ditto.
- bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Use protocolIs.
- bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): (WebCore::JSHTMLOptionElementConstructor::construct): Cleaned up the structure a bit and changed checking to check for undefined rather than number of arguments.
- bindings/js/JSHTMLOptionElementConstructor.h: KJS namespace change.
- bindings/js/JSLocation.cpp: (WebCore::JSLocation::put): Eliminated some DeprecatedString use, and use protocolIs. (WebCore::jsLocationProtoFuncReplace): Ditto. (WebCore::jsLocationProtoFuncReload): Ditto. (WebCore::jsLocationProtoFuncAssign): Ditto.
- bindings/js/JSLocation.h: KJS namespace change.
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::canGetItemsForName): Ditto. (WebCore::JSNamedNodeMap::nameGetter): Ditto.
- bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Ditto.
- bindings/js/JSNamedNodesCollection.h: Ditto.
- bindings/js/JSXMLHttpRequest.cpp: (WebCore::jsXMLHttpRequestPrototypeFunctionOpen): Removed DeprecatedString use. (WebCore::jsXMLHttpRequestPrototypeFunctionSend): Ditto.
- bindings/js/JSXMLHttpRequest.h: Moved this class into the WebCore namespace.
- bindings/js/JSXSLTProcessor.cpp: Namespace change.
- bindings/js/JSXSLTProcessor.h: Ditto.
- bindings/js/kjs_binding.cpp: Updated for namespace change. (WebCore::jsStringOrNull): Added an overload for KURL to allow DOM classes to return KURL even if the DOM expects a string. (WebCore::jsStringOrUndefined): Ditto. (WebCore::jsStringOrFalse): Ditto.
- bindings/js/kjs_binding.h: Moved everything into the WebCore namespace.
- bindings/js/kjs_css.h: Namespace change.
- bindings/js/kjs_events.cpp: Removed an include.
- bindings/js/kjs_events.h: Namespace change.
- bindings/js/kjs_html.h: Namespace change.
- bindings/js/kjs_navigator.cpp: Moved everything into the WebCore namespace.
- bindings/js/kjs_navigator.h: Ditto.
- bindings/js/kjs_window.cpp: (KJS::parseModalDialogFeatures): Updated for String::split change. (KJS::createWindow): Use protocolIs and removed some DeprecatedString. (KJS::Window::put): Ditto. (KJS::Window::allowsAccessFrom): Ditto. (KJS::windowProtoFuncOpen): Ditto.
- bindings/objc/DOM.mm: (-[DOMElement _getURLAttribute:]): Removed getNSURL call.
- bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Ditto.
- bindings/scripts/CodeGeneratorCOM.pm: Updated includes so conversions from KURL will work.
- bindings/scripts/CodeGeneratorJS.pm: Updated for namespace changes, and also updated includes so conversions from KURL will work.
- bindings/scripts/CodeGeneratorObjC.pm: Updated includes so conversions from KURL will work.
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Removed getNSURL call. Also streamlined the logic. (AXAttributedStringAppendText): Ditto.
- bridge/mac/WebCoreScriptDebugger.mm: (toNSString): Tweaked. (toNSURL): Removed getNSURL call.
- css/CSSImageValue.cpp: (WebCore::CSSImageValue::image): Removed DeprecatedString use.
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Ditto.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Ditto. (WebCore::CSSParser::parseContent): Ditto. (WebCore::CSSParser::parseBackgroundImage): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseBorderImage): Ditto.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::setEncodedURL): Ditto. (WebCore::checkPseudoState): Ditto.
- css/CSSStyleSelector.h: Ditto.
- css/MediaList.cpp: (WebCore::MediaList::setMediaText): Updated for String::split change.
- css/StyleBase.cpp: (WebCore::StyleBase::baseURL): Return KURL.
- css/StyleBase.h: DItto.
- dom/Document.cpp: (WebCore::Document::~Document): Updated for namespace change. (WebCore::Document::documentURI): Return KURL. (WebCore::Document::setDocumentURI): Removed DeprecatedString use. (WebCore::Document::baseURI): Return KURL. (WebCore::Document::open): Updated to use blankURL. (WebCore::Document::setURL): Take KURL. (WebCore::Document::shouldBeAllowedToLoadLocalResources): Updated for change to use KURL (WebCore::Document::setBaseURL): Take KURL. (WebCore::Document::elementSheet): Updated for KURL change. (WebCore::Document::mappedElementSheet): Ditto. (WebCore::Document::processHttpEquiv): Ditto. (WebCore::Document::recalcStyleSelector): Removed use of DeprecatedString -- also noticed some dead code here! (WebCore::Document::setCookie): Ditto. (WebCore::Document::completeURL): Return KURL.
- dom/Document.h: Use KURL instead of String in a few places.
- dom/DocumentType.cpp: (WebCore::DocumentType::baseURI): Return KURL.
- dom/DocumentType.h: Ditto.
- dom/Element.cpp: (WebCore::Element::baseURI): Return KURL.
- dom/Element.h: Ditto.
- dom/Node.cpp: (WebCore::Node::setDocument): Namespace change. (WebCore::Node::baseURI): Return KURL.
- dom/Node.h: Ditto.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Updated for KURL change.
- dom/StyleElement.cpp: (WebCore::StyleElement::process): Changed to use Vector<UChar> instead of String for better performance. (WebCore::StyleElement::createSheet): Removed use of DeprecateString.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): Updated for KURL change. (WebCore::XMLTokenizer::end): Ditto. (WebCore::xmlDocPtrForString): Removed use of DeprecateString.
- dom/XMLTokenizer.h: Ditto.
- editing/markup.cpp: Moved appendString to PlatformString.h. (WebCore::appendQuotedURLAttributeValue): Use protocolIs. (WebCore::completeURLs): Removed DeprecatedString use. (WebCore::createFragmentFromMarkup): Use blankURL. (WebCore::fillContainerFromString): Removed DeprecatedString use. (WebCore::createFragmentFromText): Ditto.
- history/HistoryItem.cpp: (WebCore::HistoryItem::url): Removed DeprecatedString use. (WebCore::HistoryItem::originalURL): Ditto.
- history/HistoryItem.h: Removed include.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Removed use of DeprecatedString. (WebCore::HTMLAnchorElement::href): Return KURL. (WebCore::HTMLAnchorElement::hash): Removed DeprecatedString use. (WebCore::HTMLAnchorElement::host): Ditto. (WebCore::HTMLAnchorElement::hostname): Ditto. (WebCore::HTMLAnchorElement::pathname): Ditto. (WebCore::HTMLAnchorElement::port): Ditto. (WebCore::HTMLAnchorElement::protocol): Ditto. (WebCore::HTMLAnchorElement::search): Ditto. (WebCore::HTMLAnchorElement::toString): Ditto.
- html/HTMLAnchorElement.h: Ditto.
- html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer): Updated for KURL change.
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::href): Return KURL.
- html/HTMLAreaElement.h: Ditto.
- html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::removedFromDocument): Updated for KURL change. (WebCore::HTMLBaseElement::process): Removed DeprecatedString use.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Updated for KURL change.
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed use of DeprecatedString.
- html/HTMLEmbedElement.h: Removed DeprecatedString use.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formWouldHaveSecureSubmission): Use protocolIs. (WebCore::encodeCString): Updated for change to String::split. (WebCore::HTMLFormElement::dataEncoding): Ditto. (WebCore::HTMLFormElement::formData): Removed DeprecatedString use. (WebCore::HTMLFormElement::isMailtoForm): Use protocolIs. (WebCore::HTMLFormElement::submit): Updated for KURL change. (WebCore::HTMLFormElement::reset): Ditto.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed): Updated for KURL change and use equalIgnoringRef instead of doing a setRef to get the same effect. (WebCore::HTMLFrameElementBase::openURL): Use blankURL. (WebCore::HTMLFrameElementBase::location): Return KURL. (WebCore::HTMLFrameElementBase::src): Return KURL.
- html/HTMLFrameElementBase.h: Ditto.
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Updated for KURL change. (WebCore::HTMLImageElement::longDesc): Return KURL. (WebCore::HTMLImageElement::lowsrc): Return KURL. (WebCore::HTMLImageElement::src): Return KURL.
- html/HTMLImageElement.h: Ditto. Also removed imageMap() function.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::src): Return KURL.
- html/HTMLInputElement.h: Ditto.
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute): Updated for KURL change. (WebCore::HTMLLinkElement::tokenizeRelAttribute): Updated for String::split change. (WebCore::HTMLLinkElement::href): Return KURL.
- html/HTMLLinkElement.h: Ditto.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::src): Return KURL. (WebCore::HTMLMediaElement::pickMedia): Updated for KURL change.
- html/HTMLMediaElement.h: Ditto.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType): Use protocolIs. (WebCore::HTMLObjectElement::data): Return KURL.
- html/HTMLObjectElement.h: Ditto.
- html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::groupLabelText): Removed DeprecatedString use.
- html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole): Updated for KURL change.
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::insertedIntoDocument): Ditto. (WebCore::HTMLScriptElement::text): Changed to use Vector<UChar> instead of String for better performance. (WebCore::HTMLScriptElement::src): Return KURL.
- html/HTMLScriptElement.h: Ditto.
- html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::src): Return KURL.
- html/HTMLSourceElement.h: Ditto.
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): Updated for KURL change.
- html/HTMLTablePartElement.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute): Updated for KURL change.
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): Removed DeprecatedString use.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution): Ditto. (WebCore::HTMLTokenizer::notifyFinished): Use protocolIs.
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::poster): Return KURL.
- html/HTMLVideoElement.h: Ditto.
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addText): Updated for String::split change.
- loader/DocLoader.cpp: (WebCore::DocLoader::checkForReload): Add an explicit check for an empty URL here to avoid problems using its string as a hash table key later. (WebCore::DocLoader::requestResource): Removed DeprecatedString use.
- loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::createTDForFilename): Updated for KURL change. (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine): Removed use of DeprecatedString.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Use protocolIs. (WebCore::FrameLoader::loadSubframe): Use blankURL. (WebCore::FrameLoader::submitForm): Use protocolIs and removed use of DeprecatedString. (WebCore::FrameLoader::iconURL): Return KURL. Use protcolIs. (WebCore::FrameLoader::didOpenURL): Use protocolIs. (WebCore::FrameLoader::didExplicitOpen): Use blankURL. (WebCore::FrameLoader::executeIfJavaScriptURL): Use protocolIs. Update for name change to decodeURLEscapeSequences. (WebCore::FrameLoader::receivedFirstData): Updated for KURL changes. (WebCore::FrameLoader::begin): Removed DeprecatedString use. Renamed baseurl to baseURL. Updated to use KURL more. (WebCore::FrameLoader::gotoAnchor): Removed use of encodedHtmlRef function, which is no different from ref. (WebCore::FrameLoader::completeURL): Updated for KURL change. (WebCore::FrameLoader::scheduleLocationChange): Ditto. (WebCore::FrameLoader::canCachePage): Use protocolIs. (WebCore::FrameLoader::updatePolicyBaseURL): Update for KURL change. (WebCore::FrameLoader::setPolicyBaseURL): Take KURL. (WebCore::FrameLoader::startRedirectionTimer): Removed use of DeprecatedString. (WebCore::FrameLoader::load): Use protocolIs. (WebCore::FrameLoader::shouldHideReferrer): Use protocolIs. (WebCore::FrameLoader::shouldAllowNavigation): Updated for KURL change. (WebCore::FrameLoader::commitProvisionalLoad): Use blankURL. (WebCore::FrameLoader::open): Use protcolIs. (WebCore::FrameLoader::createHistoryItem): Use blankURL. (WebCore::FrameLoader::createJavaAppletWidget): Updated for KURL change. (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady): Removed DeprecatedString use.
- loader/FrameLoader.h: Ditto.
- loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Updated for KURL change.
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): Ditto.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::iconForPageURL): Added a check for an empty URL before trying to use it as a hash table key.
- loader/icon/IconLoader.h: Tweaked includes.
- loader/loader.cpp: (WebCore::Loader::servePendingRequests): Use protcolIs. Also removed some code to set up a local variable that is never used (and a DeprecatedString on to boot!).
- loader/mac/LoaderNSURLExtras.m: (suggestedFilenameWithMIMEType): Removed unnecessary typecast.
- page/ContextMenuController.cpp: Removed include.
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks): Use protocolIs.
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge URLWithAttributeString:]): Removed getNSURL call. (-[WebCoreFrameBridge baseURL]): Ditto.
- platform/KURL.cpp: (WebCore::isSchemeFirstChar): Fixed bug in handling of values >= 0x80. (WebCore::isSchemeChar): Ditto. (WebCore::isPathSegmentEndChar): Ditto. (WebCore::hexDigitValue): Changed parameter type to UChar. (WebCore::copyASCII): Added. (WebCore::findFirstOf): Added. (WebCore::KURL::protocolIs): Added. (WebCore::KURL::KURL): Tightened logic up quite a bit. Changed parameter types from DeprecatedString to String. (WebCore::KURL::init): Changed parameter type to String. Preserved the passed-in string even if the base is invalid. Cleaned up logic to determine if the originalString should be pased in to the parse function. Simplified by calling the new parse overload that takes String in many cases. (WebCore::KURL::lastPathComponent): Return String. (WebCore::KURL::protocol): Ditto. (WebCore::KURL::host): Ditto. (WebCore::KURL::port): Changed logic to use early return for clarity. (WebCore::KURL::pass): Return String. (WebCore::KURL::user): Ditto. (WebCore::KURL::ref): Ditto. (WebCore::assertProtocolIsGood): Added. (WebCore::KURL::protocolIs): Added. (WebCore::KURL::query): Return String. (WebCore::KURL::path): Ditto. (WebCore::KURL::setProtocol): Take String. (WebCore::KURL::setHost): Ditto. (WebCore::KURL::setPort): Use String. (WebCore::KURL::setHostAndPort): Take String. (WebCore::KURL::setUser): Ditto. (WebCore::KURL::setPass): Ditto. (WebCore::KURL::setRef): Ditto. (WebCore::KURL::setQuery): Ditto. (WebCore::KURL::setPath): Ditto. (WebCore::KURL::prettyURL): Return String. Use Vector<UChar> to build it. (WebCore::decodeURLEscapeSequences): Renamed from KURL::decode_string. Return String. Use Vector<UChar> to build it. (WebCore::KURL::isLocalFile): Use protocolIs. (WebCore::KURL::parse): Added an overload that takes a String to replace the use of DeprecatedString::ascii at various call sites. Updated for name change (urlString -> m_string). (WebCore::equalIgnoringRef): Wrote a new implementation that doesn't do any allocation. (WebCore::encodeWithURLEscapeSequences): Renamed from KURL::encode_string. Return String. (WebCore::appendEncodedHostname): Added. Replaces encodeHostname and avoids the need to allocate a string. (WebCore::findHostnamesInMailToURL): Update to use findFirstOf instead of regular expressions. (WebCore::findHostnameInHierarchicalURL): Ditto. (WebCore::encodeHostnames): Use protocolIs and the other helpers above. (WebCore::encodeRelativeString): Changed to put result into a CharBuffer. (WebCore::substituteBackslashes): Updated to use String. (WebCore::KURL::copyToBuffer): Added. (WebCore::protocolIs): Added. (WebCore::blankURL): Added. (WebCore::KURL::print): Updated.
- platform/KURL.h: Added a number of comments. Reorganized the header a bit. Made the string constructors explicit. Changed to use String instead of DeprecatedString. Removed encodedHTMLRef. Renamed and added a few functions.
- platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL): Streamlined the logic a bit. (WebCore::KURL::createCFURL): Changed to use copyToBuffer.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Removed getNSURL call. Use protocolIs.
- platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::declareAndWriteDragImage): Removed getNSURL call.
- platform/mac/CookieJar.mm: (WebCore::cookies): Removed getNSURL call. (WebCore::setCookies): Removed getNSURL call.
- platform/mac/KURLMac.mm: (WebCore::KURL::KURL): Streamlined the logic a bit.
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeURL): Removed getNSURL call. (WebCore::Pasteboard::writeImage): Ditto.
- platform/mac/SSLKeyGeneratorMac.mm: (WebCore::signedPublicKeyAndChallengeString): Ditto.
- platform/network/HTTPParsers.cpp: (WebCore::filenameFromHTTPContentDisposition): Updated for String::split.
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed): Use protocolIs.
- platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::operator CFErrorRef): Removed deprecatedString call.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::headerCallback): Ditto. (WebCore::parseDataUrl): Use String instead of DeprecatedString. (WebCore::ResourceHandleManager::startJob): Updated for KURL changes.
- platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::operator NSError*): Removed getNSURL call.
- platform/network/mac/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Removed DeprecatedString use.
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Removed getNSURL call.
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse): Removed getNSURL call.
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL): Removed deprecatedString call.
- platform/text/CString.h: (WebCore::CStringBuffer::length): Fixed size_t/unsigned mismatch to make it possible to compile this on Windows with higher warning level
- platform/text/PlatformString.h: Updated split to modify a result parameter rather than returning a Vector. Added charactersAreAllASCII and an append function that appends a String to a Vector<UChar>.
- platform/text/String.cpp: (WebCore::String::split): Updated.
- platform/win/BString.cpp: (WebCore::BString::BString): Added conversion from KURL.
- platform/win/BString.h: Ditto.
- platform/win/ClipboardUtilitiesWin.cpp: (WebCore::markupToCF_HTML): Removed use of deprecatedString.
- platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): Ditto. (WebCore::createGlobalHDropContent): Ditto. (WebCore::ClipboardWin::setData): Ditto. (WebCore::ClipboardWin::writeRange): Ditto.
- platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): Ditto.
- plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Ditto. (WebCore::PluginStream::destroyStream): Ditto.
- plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): Ditto. (WebCore::PluginView::performRequest): Ditto. (WebCore::PluginView::PluginView): Ditto.
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): Removed DeprecatedString use. (WebCore::HitTestResult::absoluteLinkURL): Ditto.
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layOutAxis): Fixed comment wording.
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): Removed use of DeperecatedString, (WebCore::RenderImage::imageMap): Changed to call useMap instead of imageMap; both do the same thing, and the first is standard DOM.
- rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect): Rewrote and streamlined to remove DeprecatedString use.
- rendering/RenderObject.h: Changed addPDFURLRect to take const IntRect&.
- rendering/RenderPartObject.cpp: (WebCore::isURLAllowed): Updated for KURL change and use equalIgnoringRef instead of doing a setRef to get the same effect. (WebCore::RenderPartObject::updateWidget): Updated for KURL change.
- rendering/RenderText.cpp: (WebCore::charactersAreAllASCII): Moved the guts to PlatformString.h.
- rendering/SVGRenderSupport.cpp: (WebCore::renderSubtreeToImage): Added missing call to do layout. I ran into this while doing some layout tests while URL processing was broken.
- rendering/SVGRenderTreeAsText.h: Removed include.
- svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::updateFromElement): Removed DeprecatedString use.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw): Added missing call to do layout. I ran into this while doing some layout tests while URL processing was broken. (WebCore::SVGImage::dataChanged): Use a null URL rather than an arbitrary string for the document.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Removed DeprecatedString use. (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): Ditto. (WebCore::XMLHttpRequest::open): Ditto. (WebCore::XMLHttpRequest::send): Namespace change. (WebCore::XMLHttpRequest::dropProtection): Ditto.
- xml/XMLHttpRequest.h: Removed DeprecatedString use.
- xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet): Removed DeprecatedString use.
- xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::loadChildSheets): Ditto. (WebCore::XSLStyleSheet::loadChildSheet): Ditto.
- xml/XSLStyleSheet.h: Ditto.
- xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): Ditto. (WebCore::xsltStylesheetPointer): Ditto. (WebCore::xmlDocPtrFromNode): Ditto.
WebKit/gtk:
- webkit/webkitwebframe.cpp: Removed DeprecatedString use to try to keep it building.
- webkit/webkitwebview.cpp: Ditto.
WebKit/mac:
Reviewed by Eric Seidel.
- updated for WebCore KURL changes
- History/WebHistoryItem.mm: (-[WebHistoryItem URL]): Removed getNSURL call.
- Misc/WebElementDictionary.mm: (-[WebElementDictionary _absoluteImageURL]): Ditto. (-[WebElementDictionary _absoluteLinkURL]): Ditto.
- Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement): Ditto. (+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
- Misc/WebNSURLExtras.mm: (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated for function name change.
- WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::downloadURL): Removed getNSURL call.
- WebCoreSupport/WebDragClient.mm: (WebDragClient::createDragImageForLink): Ditto.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto. (WebFrameLoaderClient::startDownload): Ditto. (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto. (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto. (WebFrameLoaderClient::cancelledError): Ditto. (WebFrameLoaderClient::blockedError): Ditto. (WebFrameLoaderClient::cannotShowURLError): Ditto. (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto. (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto. (WebFrameLoaderClient::fileDoesNotExistError): Ditto. (WebFrameLoaderClient::willUseArchive): Ditto. (WebFrameLoaderClient::setTitle): Ditto. (WebFrameLoaderClient::actionDictionary): Ditto. (WebFrameLoaderClient::createFrame): Ditto. (WebFrameLoaderClient::objectContentType): Ditto. (WebFrameLoaderClient::createPlugin): Ditto. (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
- WebView/WebDataSource.mm: (-[WebDataSource _URL]): Ditto. (-[WebDataSource _initWithDocumentLoader:]): Ditto. (-[WebDataSource unreachableURL]): Ditto.
- WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
WebKit/win:
- updated for WebCore KURL changes
- MarshallingHelpers.cpp: (MarshallingHelpers::BSTRToKURL): Removed deprecatedString call. (MarshallingHelpers::KURLToBSTR): Tweaked for efficiency.
- WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Updated for KURL changes.
- WebDataSource.cpp: (WebDataSource::unreachableURL): Ditto.
- WebDownload.cpp: (WebDownload::init): Ditto. (WebDownload::initWithRequest): Ditto.
- WebFrame.cpp: (WebFrame::loadData): Ditto. (WebFrame::loadURLIntoChild): Ditto. (WebFrame::objectContentType): Ditto.
- WebResource.cpp: (WebResource::initWithData): Ditto.
- WebURLResponse.cpp: (WebURLResponse::createInstance): Ditto. (WebURLResponse::initWithURL): Ditto.
- WebView.cpp: (WebView::userAgentForURL): Ditto. (WebView::copyURL): Ditto. (WebView::notifyPreferencesChanged): Ditto.
WebKit/wx:
- WebView.cpp: Removed use of DeprecatedString to keep this compiling.
- 8:32 PM Changeset in webkit [30242] by
-
- 2 edits in trunk/WebKitTools
- fix Windows build
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::setStatusText): Update parameter types to match declaration.
- 8:30 PM Changeset in webkit [30241] by
-
- 3 edits in trunk/LayoutTests
- update this test further, so that it succeeds
- fast/dom/assign-to-window-status-expected.txt: Updated.
- fast/dom/assign-to-window-status.html: Updated.
- 6:17 PM Changeset in webkit [30240] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5744728> Fix leaks of RegularExpression objects in Frame.cpp.
Reviewed by Jon and Darin.
- page/Frame.cpp: (WebCore::createRegExpForLabels): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement):
- 6:03 PM Changeset in webkit [30239] by
-
- 6 edits in trunk
2008-02-14 Stephanie Lewis <Stephanie Lewis>
Reviewed by Geoff.
Update order files.
- WebKit.order:
- WebCore.order:
- JavaScriptCore.order:
- 6:00 PM Changeset in webkit [30238] by
-
- 14 edits2 adds in trunk
<rdar://problem/5726608> REGRESSION (r29428): Assigning to window.status does not update status bar
Reviewed by Geoff G and Weinig.
Revert the portions of r29428 responsible for breaking the ability to
set window.status
- 5:35 PM Changeset in webkit [30237] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/5721790>
Crash in WebCore::DeprecatedString::operator= + 31 at news.google.com
Use pointers in the cache map tables. Otherwise when we rehash,
we will end up destroying Cache objects that node lists might point to.
- dom/Node.cpp: (WebCore::NodeListsNodeData::~NodeListsNodeData): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
- 4:30 PM Changeset in webkit [30236] by
-
- 2 edits in trunk/WebCore
2008-02-14 Alp Toker <alp@atoker.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=17353
XMLTokenizer installs global libxml2 callbacks that can break client applications
Patch by Mark Rowe (with a few changes).
The xmlRegisterInputCallbacks/xmlRegisterOutputCallbacks done at
init are global so we need to make sure these callbacks only get used
by XMLTokenizer and never by libxml2 calls in user applications.
This patch modifies the match and open functions to only apply when we
are certain the caller is XMLTokenizer by checking globalDocLoader and
ensuring we're on the correct thread.
Some possible issues remain. See the bug report for details.
- dom/XMLTokenizer.cpp: (WebCore::matchFunc): (WebCore::openFunc): (WebCore::createStringParser):
- 3:29 PM Changeset in webkit [30235] by
-
- 3 edits3 adds in trunk
Reviewed by Sam Weinig.
Fixed <rdar://problem/5737835> nee http://bugs.webkit.org/show_bug.cgi?id=17329
Crash in JSGlobalObject::popActivation when inserting hyperlink in Wordpress (17329)
Don't reset the "activations" stack in JSGlobalObject::reset, since we
might be executing a script during the call to reset, and the script
needs to safely run to completion.
Instead, initialize the "activations" stack when the global object is
created, and subsequently rely on pushing and popping during normal
execution to maintain the stack's state.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init): (KJS::JSGlobalObject::reset):
LayoutTests:
Reviewed by Sam Weinig.
Layout test for <rdar://problem/5737835> nee http://bugs.webkit.org/show_bug.cgi?id=17329
Crash in JSGlobalObject::popActivation when inserting hyperlink in Wordpress (17329)
- fast/dom/javascript-url-crash-function.html: Added.
- fast/dom/javascript-url-crash-function-expected.txt: Added.
- fast/dom/resources/javascript-url-crash-function-iframe.html: Added.
- 2:27 PM Changeset in webkit [30234] by
-
- 8 edits in branches/Safari-3-1-branch
WebCore:
Reviewed by Adele Peterson.
- roll out changes to CSS2 system colors from r28775
- css/CSSStyleSelector.cpp: (WebCore::): (WebCore::colorForCSSValue):
- rendering/RenderTheme.cpp:
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
LayoutTests:
Reviewed by Adele Peterson.
- updated results after reverting CSS2 system colors changes from r28775
- platform/mac/tables/mozilla/bugs/bug103533-expected.txt:
- 1:00 PM Changeset in webkit [30233] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/5743768> A deadlock during storage layout tests
Make sure not to hold the m_openDatabaseMapGuard mutex when calling
Database::markAsDeletedAndClose(), since that can cause a deadlock
during the synchronous DatabaseThread call it triggers.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::deleteDatabaseFile):
- 11:45 AM Changeset in webkit [30232] by
-
- 1 edit40 adds in trunk/LayoutTests
Reviewed by Oliver.
Add dynamic update tests for SVGEllipseElement.
- 8:34 AM Changeset in webkit [30231] by
-
- 2 edits in trunk/WebCore
Improve the efficiency of SecurityOriginHash
Reviewed by Alexey.
- platform/SecurityOriginHash.h: (WebCore::SecurityOriginHash::hash): Now takes a const RefPtr<SecurityOrigin>& to reduce ref-count churn. (WebCore::SecurityOriginHash::equal): Ditto.
- 7:41 AM Changeset in webkit [30230] by
-
- 2 edits in trunk/WebKit/win
- WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Forgot to re-apply review comments to the previous check-in, fixing.
- 7:36 AM Changeset in webkit [30229] by
-
- 4 edits in trunk/WebKit
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=17207
Database example doesn't work (requires not-yet-released Safari)
- mac/WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage if it's too old.
- win/WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage if it's too old.
- 4:37 AM Changeset in webkit [30228] by
-
- 1 edit in trunk/WebKit/gtk/ChangeLog
Correct the e-mail address in the ChangeLog.
- 4:27 AM Changeset in webkit [30227] by
-
- 2 edits in trunk/WebKit/gtk
- Make the handling of the coreFrame consistent. We construct the coreFrame at the beginning and it will live until the end. Change the g_return_(val_)if to ASSERTs as having a 0 coreFrame can never happen.
- 4:26 AM Changeset in webkit [30226] by
-
- 6 edits in trunk/WebKit/gtk
- Make sure that the WebCore::Frame is living as long as the WebKitWebFrame wrapped around it. All current calls to WebCore::Frame from within the WebKitWebFrame are safe, even in the case where the WebCore::Frame is already detached from the WebCore::Page.
- For the mainFrame the WebKitWebView is holding the initial reference and will unref on destruction.
- For sub-frames the FramerLoaderClientGtk.cpp will do the unrefing when the frame gets detached from the parent.
- Make sure FrameLoader::detachFromParent gets called by calling FrameLoader::detachChildren
- 4:25 AM Changeset in webkit [30225] by
-
- 2 edits in trunk/WebKit/gtk
WebCore::Frame is RefCounted, do not manually delete it!
- 4:25 AM Changeset in webkit [30224] by
-
- 2 edits in trunk/WebKit/gtk
- Plug a leak
- 4:24 AM Changeset in webkit [30223] by
-
- 4 edits in trunk/WebKit/gtk
- Update the Copyright Information
