Timeline



Jun 15, 2008:

11:25 PM Changeset in webkit [34591] by Darin Adler
  • 27 edits
    4 moves in trunk

WebCore:

2008-06-15 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • renamed kjs_html.h/cpp to JSPluginElementFunctions.h/cpp
  • renamed kjs_events.h/cpp to JSEventListener.h/cpp
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • bindings/js/JSDOMApplicationCacheCustom.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSEventCustom.cpp:
  • bindings/js/JSEventListener.cpp: Copied from WebCore/bindings/js/kjs_events.cpp.
  • bindings/js/JSEventListener.h: Copied from WebCore/bindings/js/kjs_events.h.
  • bindings/js/JSEventTargetBase.h:
  • bindings/js/JSHTMLAppletElementCustom.cpp:
  • bindings/js/JSHTMLCollectionCustom.cpp:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/js/JSHTMLEmbedElementCustom.cpp:
  • bindings/js/JSHTMLInputElementBase.h:
  • bindings/js/JSHTMLObjectElementCustom.cpp:
  • bindings/js/JSHTMLSelectElementCustom.cpp:
  • bindings/js/JSPluginElementFunctions.cpp: Copied from WebCore/bindings/js/kjs_html.cpp.
  • bindings/js/JSPluginElementFunctions.h: Copied from WebCore/bindings/js/kjs_html.h.
  • bindings/js/JSSVGLazyEventListener.h:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/kjs_events.cpp: Removed.
  • bindings/js/kjs_events.h: Removed.
  • bindings/js/kjs_html.cpp: Removed.
  • bindings/js/kjs_html.h: Removed.

WebKitTools:

2008-06-15 Darin Adler <Darin Adler>

  • Scripts/do-webcore-rename: Updated for the latest round of renaming.
11:22 PM Changeset in webkit [34590] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2008-06-15 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Remove my name from the expected test results.

  • fast/dom/documenturi-can-hold-arbitrary-string-expected.txt:
  • fast/dom/documenturi-can-hold-arbitrary-string.html:
  • fast/dom/documenturi-not-affected-by-base-tag-expected.txt:
  • fast/dom/documenturi-not-affected-by-base-tag.html:
11:13 PM Changeset in webkit [34589] by Darin Adler
  • 90 edits in trunk

WebCore:

2008-06-15 Darin Adler <Darin Adler>

  • give Frame object functions shorter names: scriptProxy() -> script(), selectionController() -> selection(), animationController() -> animation()
  • WebCore.base.exp:
  • bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase): (WebCore::allowPopUp): (WebCore::createWindow): (WebCore::windowProtoFuncOpen): (WebCore::toJS): (WebCore::toJSDOMWindow):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::toJS): (WebCore::toJSDOMWindowShell):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::reload):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/kjs_html.cpp: (WebCore::runtimeObjectImplementsCall):
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • bridge/jni/jni_jsobject.mm: (createRootObject):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • dom/Document.cpp: (WebCore::Document::nodeWillBeRemoved): (WebCore::Document::createHTMLEventListener):
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
  • dom/EventTarget.cpp: (WebCore::EventTarget::dispatchGenericEvent):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::respondToChangedSelection): (WebCore::DeleteButtonController::enable): (WebCore::DeleteButtonController::deleteTarget):
  • editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand):
  • editing/Editor.cpp: (WebCore::Editor::selectionForCommand): (WebCore::Editor::canEdit): (WebCore::Editor::canEditRichly): (WebCore::Editor::canDHTMLCut): (WebCore::Editor::canDHTMLCopy): (WebCore::Editor::canCopy): (WebCore::Editor::canDelete): (WebCore::Editor::deleteWithDirection): (WebCore::Editor::deleteSelectionWithSmartDelete): (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::selectedRange): (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): (WebCore::Editor::fontForSelection): (WebCore::Editor::selectionUnorderedListState): (WebCore::Editor::selectionOrderedListState): (WebCore::Editor::increaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevelOrdered): (WebCore::Editor::increaseSelectionListLevelUnordered): (WebCore::Editor::decreaseSelectionListLevel): (WebCore::Editor::dispatchCPPEvent): (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle): (WebCore::Editor::applyStyleToSelection): (WebCore::Editor::applyParagraphStyleToSelection): (WebCore::Editor::selectionHasStyle): (WebCore::Editor::appliedEditing): (WebCore::Editor::unappliedEditing): (WebCore::Editor::reappliedEditing): (WebCore::Editor::insertLineBreak): (WebCore::Editor::insertParagraphSeparator): (WebCore::Editor::paste): (WebCore::Editor::selectComposition): (WebCore::Editor::confirmComposition): (WebCore::Editor::setComposition): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::getCompositionSelection): (WebCore::Editor::transpose):
  • editing/EditorCommand.cpp: (WebCore::expandSelectionToGranularity): (WebCore::executeDeleteToMark): (WebCore::executeMoveBackward): (WebCore::executeMoveBackwardAndModifySelection): (WebCore::executeMoveDown): (WebCore::executeMoveDownAndModifySelection): (WebCore::executeMoveForward): (WebCore::executeMoveForwardAndModifySelection): (WebCore::executeMoveLeft): (WebCore::executeMoveLeftAndModifySelection): (WebCore::executeMovePageDown): (WebCore::executeMovePageDownAndModifySelection): (WebCore::executeMovePageUp): (WebCore::executeMovePageUpAndModifySelection): (WebCore::executeMoveRight): (WebCore::executeMoveRightAndModifySelection): (WebCore::executeMoveToBeginningOfDocument): (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): (WebCore::executeMoveToBeginningOfLine): (WebCore::executeMoveToBeginningOfLineAndModifySelection): (WebCore::executeMoveToBeginningOfParagraph): (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): (WebCore::executeMoveToBeginningOfSentence): (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfDocument): (WebCore::executeMoveToEndOfDocumentAndModifySelection): (WebCore::executeMoveToEndOfSentence): (WebCore::executeMoveToEndOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfLine): (WebCore::executeMoveToEndOfLineAndModifySelection): (WebCore::executeMoveToEndOfParagraph): (WebCore::executeMoveToEndOfParagraphAndModifySelection): (WebCore::executeMoveParagraphBackwardAndModifySelection): (WebCore::executeMoveParagraphForwardAndModifySelection): (WebCore::executeMoveUp): (WebCore::executeMoveUpAndModifySelection): (WebCore::executeMoveWordBackward): (WebCore::executeMoveWordBackwardAndModifySelection): (WebCore::executeMoveWordForward): (WebCore::executeMoveWordForwardAndModifySelection): (WebCore::executeMoveWordLeft): (WebCore::executeMoveWordLeftAndModifySelection): (WebCore::executeMoveWordRight): (WebCore::executeMoveWordRightAndModifySelection): (WebCore::executeSelectAll): (WebCore::executeSelectToMark): (WebCore::executeSetMark): (WebCore::executeSwapWithMark): (WebCore::executeUnselect): (WebCore::enabledAnySelection): (WebCore::enabledAnySelectionAndMark): (WebCore::enabledInRichlyEditableText): (WebCore::enabledRangeInEditableText): (WebCore::enabledRangeInRichlyEditableText):
  • editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel): (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply):
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteSelection): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createNPObject):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::userGestureHint): (WebCore::FrameLoader::open): (WebCore::FrameLoader::dispatchWindowObjectAvailable): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createFromSelection):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::selection): (WebCore::AccessibilityRenderObject::setSelectedTextRange): (WebCore::AccessibilityRenderObject::isFocused): (WebCore::AccessibilityRenderObject::doAXTextMarkerRangeForLine): (WebCore::AccessibilityRenderObject::doSetAXSelectedTextMarkerRange): (WebCore::AccessibilityRenderObject::doAXRangeForLine): (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::anchorNode): (WebCore::DOMSelection::baseNode): (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::focusNode): (WebCore::DOMSelection::extentNode): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::extentOffset): (WebCore::DOMSelection::isCollapsed): (WebCore::DOMSelection::type): (WebCore::DOMSelection::rangeCount): (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::collapseToEnd): (WebCore::DOMSelection::collapseToStart): (WebCore::DOMSelection::empty): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::extend): (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::removeAllRanges): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument): (WebCore::DOMSelection::containsNode): (WebCore::DOMSelection::toString):
  • page/DragController.cpp: (WebCore::DragController::dragIsMove): (WebCore::DragController::tryDocumentDrag): (WebCore::setSelectionToDragCaret): (WebCore::DragController::concludeDrag): (WebCore::prepareClipboardForImageDrag): (WebCore::DragController::startDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::nodeIsNotBeingEdited): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::handleKeyboardSelectionMovement): (WebCore::EventHandler::handleDrag):
  • page/FocusController.cpp: (WebCore::FocusController::setFocusedFrame): (WebCore::clearSelectionIfNeeded): (WebCore::FocusController::setActive):
  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::script): (WebCore::Frame::setDocument): (WebCore::Frame::selectedText): (WebCore::Frame::selection): (WebCore::Frame::animation): (WebCore::Frame::notifyRendererOfSelectionChange): (WebCore::Frame::invalidateSelection): (WebCore::Frame::clearCaretRectIfNeeded): (WebCore::Frame::setFocusedNodeIfNeeded): (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::caretBlinkTimerFired): (WebCore::Frame::paintCaret): (WebCore::Frame::shouldChangeSelection): (WebCore::Frame::updateSecureKeyboardEntryIfActive): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::bindingRootObject): (WebCore::Frame::windowScriptNPObject): (WebCore::Frame::clearScriptController): (WebCore::Frame::selectionTextRects): (WebCore::Frame::currentForm): (WebCore::Frame::revealSelection): (WebCore::Frame::revealCaret): (WebCore::Frame::clearTimers): (WebCore::Frame::styleForSelectionStart): (WebCore::Frame::setSelectionFromNone): (WebCore::Frame::findString): (WebCore::Frame::pageDestroyed): (WebCore::Frame::respondToChangedSelection): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/InspectorController.cpp: (WebCore::canPassNodeToJavaScript): (WebCore::InspectorController::windowScriptObjectAvailable):
  • page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
  • page/Page.cpp: (WebCore::Page::findString): (WebCore::Page::selection): (WebCore::Page::setDebugger):
  • page/mac/FrameMac.mm: (WebCore::Frame::baseWritingDirectionForSelectionStart): (WebCore::Frame::dragImageForSelection): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::windowScriptObject):
  • page/win/FrameWin.cpp: (WebCore::Frame::dragImageForSelection):
  • platform/ContextMenu.cpp: (WebCore::selectionContainsPossibleWord): (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • plugins/PluginView.cpp: (WebCore::PluginView::performRequest): (WebCore::PluginView::bindingInstance):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::isSelected):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::selectionBackgroundColor): (WebCore::RenderObject::selectionForegroundColor): (WebCore::RenderObject::setAnimatableStyle): (WebCore::RenderObject::destroy): (WebCore::RenderObject::animation):
  • rendering/RenderObject.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selectionStart): (WebCore::RenderTextControl::selectionEnd): (WebCore::RenderTextControl::setSelectionRange): (WebCore::RenderTextControl::selectionChanged): (WebCore::RenderTextControl::capsLockStateMayHaveChanged):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeSelection):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::createSVGEventListener):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::deselectAll):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):

WebKit/gtk:

2008-06-15 Darin Adler <Darin Adler>

  • give Frame object functions shorter names: scriptProxy() -> script(), selectionController() -> selection(), animationController() -> animation()
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeyboardEvent):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::windowObjectCleared):
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebview.cpp:

WebKit/mac:

2008-06-15 Darin Adler <Darin Adler>

  • give Frame object functions shorter names: scriptProxy() -> script(), selectionController() -> selection(), animationController() -> animation()
  • Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerSelectionColor]):
  • WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]): (-[WebFrame _hasSelection]): (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): (-[WebFrame _convertToNSRange:]): (-[WebFrame _convertToDOMRange:]): (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): (-[WebFrame _insertParagraphSeparatorInQuotedContent]): (-[WebFrame _selectedNSRange]): (-[WebFrame _selectNSRange:]): (-[WebFrame globalContext]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _selectedRange]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): (-[WebHTMLView _updateFocusedAndActiveState]): (-[WebHTMLView readSelectionFromPasteboard:]): (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView maintainsInactiveSelection]): (-[WebHTMLView paste:]): (isTextInput): (-[WebHTMLView inputContext]): (-[WebTextCompleteController doCompletion]): (-[WebHTMLView selectAll]): (-[WebHTMLView deselectAll]): (-[WebHTMLView selectedAttributedString]):
  • WebView/WebView.mm: (-[WebView aeDescByEvaluatingJavaScriptFromString:]): (-[WebView setSelectedDOMRange:affinity:]): (-[WebView selectedDOMRange]): (-[WebView selectionAffinity]):

WebKit/qt:

2008-06-15 Darin Adler <Darin Adler>

  • give Frame object functions shorter names: scriptProxy() -> script(), selectionController() -> selection(), animationController() -> animation()
  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
  • Api/qwebpage.cpp: (QWebPagePrivate::focusInEvent): (QWebPagePrivate::focusOutEvent): (QWebPage::inputMethodQuery):
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

WebKit/win:

2008-06-15 Darin Adler <Darin Adler>

  • give Frame object functions shorter names: scriptProxy() -> script(), selectionController() -> selection(), animationController() -> animation()
  • WebFrame.cpp: (WebFrame::globalContext): (WebFrame::windowObjectCleared):
  • WebView.cpp: (WebView::handleContextMenuEvent): (WebViewWndProc): (WebView::updateFocusedAndActiveState): (WebView::hasSelectedRange): (WebView::replaceSelectionWithText): (WebView::clearSelection): (WebView::prepareCandidateWindow): (WebView::onIMERequestCharPosition): (WebView::onIMERequestReconvertString):

WebKit/wx:

2008-06-15 Darin Adler <Darin Adler>

  • give Frame object functions shorter names: scriptProxy() -> script(), selectionController() -> selection(), animationController() -> animation()
  • WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::handleKeyboardEvent):
  • WebView.cpp: (wxWebView::RunScript): (wxWebView::OnSetFocus): (wxWebView::OnKillFocus):

WebKitTools:

2008-06-15 Darin Adler <Darin Adler>

  • Scripts/do-webcore-rename: Updated for the latest round of renaming.
10:55 PM Changeset in webkit [34588] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-06-15 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Remove outdated comment.

  • bindings/js/ScriptController.h:
10:28 PM Changeset in webkit [34587] by Darin Adler
  • 148 edits in trunk

JavaScriptCore:

2008-06-15 Darin Adler <Darin Adler>

  • rename KJS::List to KJS::ArgList
  • API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: (KJS::::construct): (KJS::::callAsFunction):
  • API/JSObjectRef.cpp: (JSObjectMakeFunction): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
  • JavaScriptCore.exp:
  • VM/Machine.cpp: (KJS::Machine::execute): (KJS::Machine::privateExecute):
  • VM/Machine.h:
  • kjs/ArrayPrototype.cpp: (KJS::arrayProtoFuncToString): (KJS::arrayProtoFuncToLocaleString): (KJS::arrayProtoFuncJoin): (KJS::arrayProtoFuncConcat): (KJS::arrayProtoFuncPop): (KJS::arrayProtoFuncPush): (KJS::arrayProtoFuncReverse): (KJS::arrayProtoFuncShift): (KJS::arrayProtoFuncSlice): (KJS::arrayProtoFuncSort): (KJS::arrayProtoFuncSplice): (KJS::arrayProtoFuncUnShift): (KJS::arrayProtoFuncFilter): (KJS::arrayProtoFuncMap): (KJS::arrayProtoFuncEvery): (KJS::arrayProtoFuncForEach): (KJS::arrayProtoFuncSome): (KJS::arrayProtoFuncIndexOf): (KJS::arrayProtoFuncLastIndexOf): (KJS::ArrayConstructor::construct): (KJS::ArrayConstructor::callAsFunction):
  • kjs/ArrayPrototype.h:
  • kjs/BooleanObject.cpp: (KJS::booleanProtoFuncToString): (KJS::booleanProtoFuncValueOf): (KJS::BooleanConstructor::construct): (KJS::BooleanConstructor::callAsFunction):
  • kjs/BooleanObject.h:
  • kjs/CommonIdentifiers.h:
  • kjs/ExecState.h: (KJS::ExecState::emptyList):
  • kjs/FunctionPrototype.cpp: (KJS::FunctionPrototype::callAsFunction): (KJS::functionProtoFuncToString): (KJS::functionProtoFuncApply): (KJS::functionProtoFuncCall): (KJS::FunctionConstructor::construct): (KJS::FunctionConstructor::callAsFunction):
  • kjs/FunctionPrototype.h:
  • kjs/JSActivation.cpp: (KJS::JSActivation::createArgumentsObject):
  • kjs/JSArray.cpp: (KJS::JSArray::JSArray): (KJS::AVLTreeAbstractorForArrayCompare::compare_key_key):
  • kjs/JSArray.h:
  • kjs/JSFunction.cpp: (KJS::JSFunction::callAsFunction): (KJS::JSFunction::construct): (KJS::IndexToNameMap::IndexToNameMap): (KJS::Arguments::Arguments): (KJS::encode): (KJS::decode): (KJS::globalFuncEval): (KJS::globalFuncParseInt): (KJS::globalFuncParseFloat): (KJS::globalFuncIsNaN): (KJS::globalFuncIsFinite): (KJS::globalFuncDecodeURI): (KJS::globalFuncDecodeURIComponent): (KJS::globalFuncEncodeURI): (KJS::globalFuncEncodeURIComponent): (KJS::globalFuncEscape): (KJS::globalFuncUnescape): (KJS::globalFuncKJSPrint): (KJS::PrototypeFunction::callAsFunction): (KJS::PrototypeReflexiveFunction::callAsFunction):
  • kjs/JSFunction.h:
  • kjs/JSGlobalData.h:
  • kjs/JSImmediate.cpp: (KJS::JSImmediate::toObject):
  • kjs/JSNotAnObject.cpp: (KJS::JSNotAnObject::construct): (KJS::JSNotAnObject::callAsFunction):
  • kjs/JSNotAnObject.h:
  • kjs/JSObject.cpp: (KJS::JSObject::put): (KJS::JSObject::construct): (KJS::JSObject::callAsFunction): (KJS::Error::create):
  • kjs/JSObject.h:
  • kjs/MathObject.cpp: (KJS::mathProtoFuncAbs): (KJS::mathProtoFuncACos): (KJS::mathProtoFuncASin): (KJS::mathProtoFuncATan): (KJS::mathProtoFuncATan2): (KJS::mathProtoFuncCeil): (KJS::mathProtoFuncCos): (KJS::mathProtoFuncExp): (KJS::mathProtoFuncFloor): (KJS::mathProtoFuncLog): (KJS::mathProtoFuncMax): (KJS::mathProtoFuncMin): (KJS::mathProtoFuncPow): (KJS::mathProtoFuncRandom): (KJS::mathProtoFuncRound): (KJS::mathProtoFuncSin): (KJS::mathProtoFuncSqrt): (KJS::mathProtoFuncTan):
  • kjs/MathObject.h:
  • kjs/NumberObject.cpp: (KJS::numberProtoFuncToString): (KJS::numberProtoFuncToLocaleString): (KJS::numberProtoFuncValueOf): (KJS::numberProtoFuncToFixed): (KJS::numberProtoFuncToExponential): (KJS::numberProtoFuncToPrecision): (KJS::NumberConstructor::construct): (KJS::NumberConstructor::callAsFunction):
  • kjs/NumberObject.h:
  • kjs/RegExpObject.cpp: (KJS::regExpProtoFuncTest): (KJS::regExpProtoFuncExec): (KJS::regExpProtoFuncCompile): (KJS::regExpProtoFuncToString): (KJS::RegExpObject::match): (KJS::RegExpObject::test): (KJS::RegExpObject::exec): (KJS::RegExpObject::callAsFunction): (KJS::RegExpConstructor::construct): (KJS::RegExpConstructor::callAsFunction):
  • kjs/RegExpObject.h:
  • kjs/Shell.cpp: (functionPrint): (functionDebug): (functionGC): (functionVersion): (functionRun): (functionLoad): (functionReadline): (functionQuit):
  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/collector.h: (KJS::Collector::markListSet):
  • kjs/date_object.cpp: (KJS::formatLocaleDate): (KJS::fillStructuresUsingTimeArgs): (KJS::fillStructuresUsingDateArgs): (KJS::DateConstructor::construct): (KJS::DateConstructor::callAsFunction): (KJS::DateFunction::callAsFunction): (KJS::dateProtoFuncToString): (KJS::dateProtoFuncToUTCString): (KJS::dateProtoFuncToDateString): (KJS::dateProtoFuncToTimeString): (KJS::dateProtoFuncToLocaleString): (KJS::dateProtoFuncToLocaleDateString): (KJS::dateProtoFuncToLocaleTimeString): (KJS::dateProtoFuncValueOf): (KJS::dateProtoFuncGetTime): (KJS::dateProtoFuncGetFullYear): (KJS::dateProtoFuncGetUTCFullYear): (KJS::dateProtoFuncToGMTString): (KJS::dateProtoFuncGetMonth): (KJS::dateProtoFuncGetUTCMonth): (KJS::dateProtoFuncGetDate): (KJS::dateProtoFuncGetUTCDate): (KJS::dateProtoFuncGetDay): (KJS::dateProtoFuncGetUTCDay): (KJS::dateProtoFuncGetHours): (KJS::dateProtoFuncGetUTCHours): (KJS::dateProtoFuncGetMinutes): (KJS::dateProtoFuncGetUTCMinutes): (KJS::dateProtoFuncGetSeconds): (KJS::dateProtoFuncGetUTCSeconds): (KJS::dateProtoFuncGetMilliSeconds): (KJS::dateProtoFuncGetUTCMilliseconds): (KJS::dateProtoFuncGetTimezoneOffset): (KJS::dateProtoFuncSetTime): (KJS::setNewValueFromTimeArgs): (KJS::setNewValueFromDateArgs): (KJS::dateProtoFuncSetMilliSeconds): (KJS::dateProtoFuncSetUTCMilliseconds): (KJS::dateProtoFuncSetSeconds): (KJS::dateProtoFuncSetUTCSeconds): (KJS::dateProtoFuncSetMinutes): (KJS::dateProtoFuncSetUTCMinutes): (KJS::dateProtoFuncSetHours): (KJS::dateProtoFuncSetUTCHours): (KJS::dateProtoFuncSetDate): (KJS::dateProtoFuncSetUTCDate): (KJS::dateProtoFuncSetMonth): (KJS::dateProtoFuncSetUTCMonth): (KJS::dateProtoFuncSetFullYear): (KJS::dateProtoFuncSetUTCFullYear): (KJS::dateProtoFuncSetYear): (KJS::dateProtoFuncGetYear):
  • kjs/date_object.h:
  • kjs/debugger.h:
  • kjs/error_object.cpp: (KJS::errorProtoFuncToString): (KJS::ErrorConstructor::construct): (KJS::ErrorConstructor::callAsFunction): (KJS::NativeErrorConstructor::construct): (KJS::NativeErrorConstructor::callAsFunction):
  • kjs/error_object.h:
  • kjs/internal.cpp: (KJS::JSNumberCell::toObject): (KJS::JSNumberCell::toThisObject):
  • kjs/list.cpp: (KJS::ArgList::getSlice): (KJS::ArgList::markLists): (KJS::ArgList::slowAppend):
  • kjs/list.h: (KJS::ArgList::ArgList): (KJS::ArgList::~ArgList):
  • kjs/object_object.cpp: (KJS::objectProtoFuncValueOf): (KJS::objectProtoFuncHasOwnProperty): (KJS::objectProtoFuncIsPrototypeOf): (KJS::objectProtoFuncDefineGetter): (KJS::objectProtoFuncDefineSetter): (KJS::objectProtoFuncLookupGetter): (KJS::objectProtoFuncLookupSetter): (KJS::objectProtoFuncPropertyIsEnumerable): (KJS::objectProtoFuncToLocaleString): (KJS::objectProtoFuncToString): (KJS::ObjectConstructor::construct): (KJS::ObjectConstructor::callAsFunction):
  • kjs/object_object.h:
  • kjs/string_object.cpp: (KJS::replace): (KJS::stringProtoFuncToString): (KJS::stringProtoFuncValueOf): (KJS::stringProtoFuncCharAt): (KJS::stringProtoFuncCharCodeAt): (KJS::stringProtoFuncConcat): (KJS::stringProtoFuncIndexOf): (KJS::stringProtoFuncLastIndexOf): (KJS::stringProtoFuncMatch): (KJS::stringProtoFuncSearch): (KJS::stringProtoFuncReplace): (KJS::stringProtoFuncSlice): (KJS::stringProtoFuncSplit): (KJS::stringProtoFuncSubstr): (KJS::stringProtoFuncSubstring): (KJS::stringProtoFuncToLowerCase): (KJS::stringProtoFuncToUpperCase): (KJS::stringProtoFuncToLocaleLowerCase): (KJS::stringProtoFuncToLocaleUpperCase): (KJS::stringProtoFuncLocaleCompare): (KJS::stringProtoFuncBig): (KJS::stringProtoFuncSmall): (KJS::stringProtoFuncBlink): (KJS::stringProtoFuncBold): (KJS::stringProtoFuncFixed): (KJS::stringProtoFuncItalics): (KJS::stringProtoFuncStrike): (KJS::stringProtoFuncSub): (KJS::stringProtoFuncSup): (KJS::stringProtoFuncFontcolor): (KJS::stringProtoFuncFontsize): (KJS::stringProtoFuncAnchor): (KJS::stringProtoFuncLink): (KJS::StringConstructor::construct): (KJS::StringConstructor::callAsFunction): (KJS::StringConstructorFunction::callAsFunction):
  • kjs/string_object.h:

JavaScriptGlue:

2008-06-15 Darin Adler <Darin Adler>

  • rename KJS::List to KJS::ArgList
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCallFunction):
  • UserObjectImp.cpp: (UserObjectImp::callAsFunction):
  • UserObjectImp.h:

WebCore:

2008-06-15 Darin Adler <Darin Adler>

  • try to fix Qt build
  • dom/XMLTokenizer.cpp: Use create instead of new.
  • rename KJS::List to KJS::ArgList
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::construct):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow): (WebCore::JSCanvasRenderingContext2D::createPattern): (WebCore::JSCanvasRenderingContext2D::putImageData):
  • bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::types): (WebCore::JSClipboard::clearData): (WebCore::JSClipboard::getData): (WebCore::JSClipboard::setData): (WebCore::JSClipboard::setDragImage):
  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::debug): (WebCore::JSConsole::error): (WebCore::JSConsole::info): (WebCore::JSConsole::log): (WebCore::JSConsole::warn): (WebCore::JSConsole::assertCondition): (WebCore::JSConsole::profile): (WebCore::JSConsole::profileEnd):
  • bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener): (WebCore::JSDOMApplicationCache::dispatchEvent):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::windowProtoFuncAToB): (WebCore::windowProtoFuncBToA): (WebCore::windowProtoFuncOpen): (WebCore::windowProtoFuncSetTimeout): (WebCore::windowProtoFuncClearTimeout): (WebCore::windowProtoFuncSetInterval): (WebCore::windowProtoFuncAddEventListener): (WebCore::windowProtoFuncRemoveEventListener): (WebCore::windowProtoFuncShowModalDialog): (WebCore::windowProtoFuncNotImplemented): (WebCore::JSDOMWindowBase::installTimeout):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
  • bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttribute): (WebCore::JSElement::setAttributeNode): (WebCore::JSElement::setAttributeNS): (WebCore::JSElement::setAttributeNodeNS):
  • bindings/js/JSEventTargetBase.cpp: (WebCore::jsEventTargetAddEventListener): (WebCore::jsEventTargetRemoveEventListener): (WebCore::jsEventTargetDispatchEvent):
  • bindings/js/JSEventTargetBase.h:
  • bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::callAsFunction):
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::JSHTMLCollection::callAsFunction): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open): (WebCore::writeHelper): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln):
  • bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::callAsFunction):
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::jsHTMLInputElementBaseFunctionSetSelectionRange):
  • bindings/js/JSHTMLInputElementBase.h:
  • bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::callAsFunction):
  • bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::construct):
  • bindings/js/JSHTMLOptionElementConstructor.h:
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::add): (WebCore::JSHTMLOptionsCollection::remove):
  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::construct):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate): (WebCore::JSJavaScriptCallFrame::scopeChain):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::acceptNode):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::nextNode): (WebCore::JSNodeIterator::previousNode):
  • bindings/js/JSNodeListCustom.cpp: (WebCore::JSNodeList::callAsFunction):
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::construct): (WebCore::JSQuarantinedObjectWrapper::callAsFunction):
  • bindings/js/JSQuarantinedObjectWrapper.h:
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::rotateFromVector): (WebCore::JSSVGMatrix::flipX): (WebCore::JSSVGMatrix::flipY): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
  • bindings/js/JSSVGPathSegListCustom.cpp: (WebCore::JSSVGPathSegList::clear): (WebCore::JSSVGPathSegList::initialize): (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem): (WebCore::JSSVGPathSegList::appendItem):
  • bindings/js/JSSVGPointListCustom.cpp: (WebCore::JSSVGPointList::clear): (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
  • bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::clear): (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::parentNode): (WebCore::JSTreeWalker::firstChild): (WebCore::JSTreeWalker::lastChild): (WebCore::JSTreeWalker::nextSibling): (WebCore::JSTreeWalker::previousSibling): (WebCore::JSTreeWalker::previousNode): (WebCore::JSTreeWalker::nextNode):
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::construct):
  • bindings/js/JSXMLHttpRequestConstructor.h:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::setRequestHeader): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::getResponseHeader): (WebCore::JSXMLHttpRequest::overrideMimeType): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener): (WebCore::JSXMLHttpRequest::dispatchEvent):
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::construct):
  • bindings/js/JSXSLTProcessorConstructor.h:
  • bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::importStylesheet): (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument): (WebCore::JSXSLTProcessor::setParameter): (WebCore::JSXSLTProcessor::getParameter): (WebCore::JSXSLTProcessor::removeParameter):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/kjs_html.cpp: (WebCore::runtimeObjectCallAsFunction):
  • bindings/js/kjs_html.h:
  • bindings/objc/WebScriptObject.mm: (getListFromNSArray): (-[WebScriptObject callWebScriptMethod:withArguments:]):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp: (getListFromVariantArgs): (_NPN_InvokeDefault): (_NPN_Invoke):
  • bridge/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): (KJS::Bindings::CInstance::invokeDefaultMethod):
  • bridge/c/c_instance.h:
  • bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/jni_instance.h:
  • bridge/jni/jni_jsobject.h:
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::getListFromJArray):
  • bridge/objc/objc_instance.h:
  • bridge/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod):
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction):
  • bridge/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::construct): (KJS::Bindings::QtInstance::invokeMethod): (KJS::Bindings::QtInstance::invokeDefaultMethod):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.cpp: (KJS::Bindings::convertQVariantToValue): (KJS::Bindings::findMethodIndex): (KJS::Bindings::QtRuntimeMetaMethod::callAsFunction): (KJS::Bindings::QtRuntimeConnectionMethod::callAsFunction): (KJS::Bindings::QtConnectionObject::execute):
  • bridge/qt/qt_runtime.h:
  • bridge/runtime.h: (KJS::Bindings::Instance::invokeDefaultMethod):
  • bridge/runtime_method.cpp: (RuntimeMethod::callAsFunction):
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp: (RuntimeObjectImp::callAsFunction):
  • bridge/runtime_object.h:
  • page/Console.cpp: (WebCore::printToStandardOut): (WebCore::Console::debug): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::assertCondition): (WebCore::Console::profile): (WebCore::Console::profileEnd): (WebCore::Console::warn):
  • page/Console.h:
  • page/InspectorController.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::InspectorController::addMessageToConsole):
  • page/InspectorController.h:

WebKit/mac:

2008-06-15 Darin Adler <Darin Adler>

  • rename KJS::List to KJS::ArgList
  • WebView/WebScriptDebugger.h:

WebKit/win:

2008-06-15 Darin Adler <Darin Adler>

  • rename KJS::List to KJS::ArgList
  • WebScriptCallFrame.cpp: (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):

WebKitTools:

2008-06-15 Darin Adler <Darin Adler>

  • Scripts/do-webcore-rename: Updated for the latest round of renaming.
10:04 PM Changeset in webkit [34586] by Darin Adler
  • 7 edits in trunk/WebKit/gtk

2008-06-15 Darin Adler <Darin Adler>

  • undo bogus renaming done by the script
  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • webkit/webkitnetworkrequest.h:
  • webkit/webkitwebbackforwardlist.h:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebhistoryitem.h:
  • webkit/webkitwebsettings.h:
10:03 PM Changeset in webkit [34585] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-15 Darin Adler <Darin Adler>

  • platform/graphics/gtk/VideoSinkGStreamer.h: Undo a bogus rename done by the script.
9:43 PM Changeset in webkit [34584] by abarth@webkit.org
  • 5 edits
    12 adds in trunk

WebCore:

2008-06-15 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Fix our implementation of Document.documentURI (DOM Core Level 3).

Tests: fast/dom/documenturi-affects-relative-paths.html

fast/dom/documenturi-assigned-junk-implies-baseuri-null.html
fast/dom/documenturi-assigned-junk-implies-relative-urls-do-not-resolve.html
fast/dom/documenturi-can-hold-arbitrary-string.html
fast/dom/documenturi-loses-to-base-tag.html
fast/dom/documenturi-not-affected-by-base-tag.html

  • dom/Document.cpp: (WebCore::Document::setDocumentURI): (WebCore::Document::setURL): (WebCore::Document::updateBaseURL):
  • dom/Document.h:
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::url):

LayoutTests:

2008-06-15 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Test Document.documentURI (DOM Core Level 3). There don't appear to be
other browser implementations of this feature to compare against, but
these tests test my interpretation of the spec.

  • fast/dom/documenturi-affects-relative-paths-expected.txt: Added.
  • fast/dom/documenturi-affects-relative-paths.html: Added.
  • fast/dom/documenturi-assigned-junk-implies-baseuri-null-expected.txt: Added.
  • fast/dom/documenturi-assigned-junk-implies-baseuri-null.html: Added.
  • fast/dom/documenturi-assigned-junk-implies-relative-urls-do-not-resolve-expected.txt: Added.
  • fast/dom/documenturi-assigned-junk-implies-relative-urls-do-not-resolve.html: Added.
  • fast/dom/documenturi-can-hold-arbitrary-string-expected.txt: Added.
  • fast/dom/documenturi-can-hold-arbitrary-string.html: Added.
  • fast/dom/documenturi-loses-to-base-tag-expected.txt: Added.
  • fast/dom/documenturi-loses-to-base-tag.html: Added.
  • fast/dom/documenturi-not-affected-by-base-tag-expected.txt: Added.
  • fast/dom/documenturi-not-affected-by-base-tag.html: Added.
9:42 PM Changeset in webkit [34583] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2008-06-15 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Refactor our handling of Document::m_baseURL in preparation for
correcting our implementation of Document.documentURI.

  • dom/Document.cpp: (WebCore::Document::documentURI): (WebCore::Document::open): (WebCore::Document::setURL): (WebCore::Document::setBaseElementURL): (WebCore::Document::updateBaseURL): (WebCore::Document::elementSheet): (WebCore::Document::mappedElementSheet): (WebCore::Document::completeURL):
  • dom/Document.h: (WebCore::Document::url): (WebCore::Document::baseURL):
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::removedFromDocument): (WebCore::HTMLBaseElement::process):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
9:17 PM Changeset in webkit [34582] by Darin Adler
  • 45 edits
    26 moves in trunk

JavaScriptCore:

2008-06-15 Darin Adler <Darin Adler>

  • API/JSCallbackFunction.cpp:
  • API/JSObjectRef.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Machine.cpp:
  • kjs/AllInOneFile.cpp:
  • kjs/ArrayPrototype.cpp: Copied from JavaScriptCore/kjs/array_object.cpp.
  • kjs/ArrayPrototype.h: Copied from JavaScriptCore/kjs/array_object.h.
  • kjs/BooleanObject.cpp: Copied from JavaScriptCore/kjs/bool_object.cpp.
  • kjs/BooleanObject.h: Copied from JavaScriptCore/kjs/bool_object.h.
  • kjs/ExecState.cpp:
  • kjs/ExecState.h:
  • kjs/FunctionPrototype.cpp: Copied from JavaScriptCore/kjs/function_object.cpp.
  • kjs/FunctionPrototype.h: Copied from JavaScriptCore/kjs/function_object.h.
  • kjs/JSArray.cpp: Copied from JavaScriptCore/kjs/array_instance.cpp.
  • kjs/JSArray.h: Copied from JavaScriptCore/kjs/array_instance.h.
  • kjs/JSFunction.cpp:
  • kjs/JSFunction.h:
  • kjs/JSGlobalObject.cpp:
  • kjs/JSImmediate.cpp:
  • kjs/JSObject.h:
  • kjs/JSString.h:
  • kjs/JSValue.h:
  • kjs/JSVariableObject.cpp:
  • kjs/MathObject.cpp: Copied from JavaScriptCore/kjs/math_object.cpp.
  • kjs/MathObject.h: Copied from JavaScriptCore/kjs/math_object.h.
  • kjs/NumberObject.cpp: Copied from JavaScriptCore/kjs/number_object.cpp.
  • kjs/NumberObject.h: Copied from JavaScriptCore/kjs/number_object.h.
  • kjs/PropertyMap.cpp: Copied from JavaScriptCore/kjs/property_map.cpp.
  • kjs/PropertyMap.h: Copied from JavaScriptCore/kjs/property_map.h.
  • kjs/PropertySlot.cpp: Copied from JavaScriptCore/kjs/property_slot.cpp.
  • kjs/PropertySlot.h: Copied from JavaScriptCore/kjs/property_slot.h.
  • kjs/RegExpObject.cpp: Copied from JavaScriptCore/kjs/regexp_object.cpp.
  • kjs/RegExpObject.h: Copied from JavaScriptCore/kjs/regexp_object.h.
  • kjs/ScopeChain.cpp: Copied from JavaScriptCore/kjs/scope_chain.cpp.
  • kjs/ScopeChain.h: Copied from JavaScriptCore/kjs/scope_chain.h.
  • kjs/ScopeChainMark.h: Copied from JavaScriptCore/kjs/scope_chain_mark.h.
  • kjs/Shell.cpp:
  • kjs/array_instance.cpp: Removed.
  • kjs/array_instance.h: Removed.
  • kjs/array_object.cpp: Removed.
  • kjs/array_object.h: Removed.
  • kjs/bool_object.cpp: Removed.
  • kjs/bool_object.h: Removed.
  • kjs/error_object.h:
  • kjs/function_object.cpp: Removed.
  • kjs/function_object.h: Removed.
  • kjs/internal.cpp:
  • kjs/math_object.cpp: Removed.
  • kjs/math_object.h: Removed.
  • kjs/nodes.cpp:
  • kjs/number_object.cpp: Removed.
  • kjs/number_object.h: Removed.
  • kjs/object_object.cpp:
  • kjs/property_map.cpp: Removed.
  • kjs/property_map.h: Removed.
  • kjs/property_slot.cpp: Removed.
  • kjs/property_slot.h: Removed.
  • kjs/regexp_object.cpp: Removed.
  • kjs/regexp_object.h: Removed.
  • kjs/scope_chain.cpp: Removed.
  • kjs/scope_chain.h: Removed.
  • kjs/scope_chain_mark.h: Removed.
  • kjs/string_object.cpp:
  • kjs/string_object.h:

WebCore:

2008-06-15 Darin Adler <Darin Adler>

  • ForwardingHeaders/kjs/ArrayPrototype.h: Copied from WebCore/ForwardingHeaders/kjs/array_object.h.
  • ForwardingHeaders/kjs/BooleanObject.h: Copied from WebCore/ForwardingHeaders/kjs/bool_object.h.
  • ForwardingHeaders/kjs/FunctionPrototype.h: Copied from WebCore/ForwardingHeaders/kjs/function_object.h.
  • ForwardingHeaders/kjs/JSArray.h: Copied from WebCore/ForwardingHeaders/kjs/array_instance.h.
  • ForwardingHeaders/kjs/PropertyMap.h: Copied from WebCore/ForwardingHeaders/kjs/property_map.h.
  • ForwardingHeaders/kjs/array_instance.h: Removed.
  • ForwardingHeaders/kjs/array_object.h: Removed.
  • ForwardingHeaders/kjs/bool_object.h: Removed.
  • ForwardingHeaders/kjs/function_object.h: Removed.
  • ForwardingHeaders/kjs/property_map.h: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSClipboardCustom.cpp:
  • bindings/js/JSDatabaseCustom.cpp:
  • bindings/js/JSJavaScriptCallFrameCustom.cpp:
  • bindings/js/kjs_events.cpp:
  • bridge/jni/jni_utility.cpp:
  • bridge/qt/qt_runtime.cpp:
  • bridge/runtime_array.cpp:

WebKit/mac:

2008-06-15 Darin Adler <Darin Adler>

  • WebView/WebView.mm:

WebKit/qt:

2008-06-15 Darin Adler <Darin Adler>

  • WebKit_pch.h:

WebKitTools:

2008-06-15 Darin Adler <Darin Adler>

  • Scripts/do-file-rename: Updated.
  • Scripts/do-webcore-rename: Updated for the latest round of renaming.
9:00 PM Changeset in webkit [34581] by Darin Adler
  • 110 edits
    16 moves in trunk

JavaScriptCore:

2008-06-15 Darin Adler <Darin Adler>

  • API/JSBase.cpp:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSClassRef.h:
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp:
  • API/JSStringRef.cpp:
  • API/JSStringRefCF.cpp:
  • API/JSValueRef.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/CodeBlock.cpp:
  • VM/CodeGenerator.cpp:
  • VM/ExceptionHelpers.cpp:
  • VM/ExceptionHelpers.h:
  • VM/JSPropertyNameIterator.cpp:
  • VM/JSPropertyNameIterator.h:
  • VM/Machine.cpp:
  • kjs/AllInOneFile.cpp:
  • kjs/DateMath.cpp:
  • kjs/DebuggerCallFrame.cpp:
  • kjs/ExecState.cpp:
  • kjs/JSActivation.cpp:
  • kjs/JSFunction.cpp: Copied from JavaScriptCore/kjs/function.cpp.
  • kjs/JSFunction.h: Copied from JavaScriptCore/kjs/function.h.
  • kjs/JSImmediate.cpp:
  • kjs/JSNotAnObject.h:
  • kjs/JSObject.cpp: Copied from JavaScriptCore/kjs/object.cpp.
  • kjs/JSObject.h: Copied from JavaScriptCore/kjs/object.h.
  • kjs/JSString.h: Copied from JavaScriptCore/kjs/internal.h.
  • kjs/JSValue.cpp: Copied from JavaScriptCore/kjs/value.cpp.
  • kjs/JSValue.h: Copied from JavaScriptCore/kjs/value.h.
  • kjs/JSVariableObject.h:
  • kjs/JSWrapperObject.h:
  • kjs/Shell.cpp:
  • kjs/SymbolTable.h:
  • kjs/array_instance.h:
  • kjs/collector.cpp:
  • kjs/date_object.cpp:
  • kjs/date_object.h:
  • kjs/error_object.cpp:
  • kjs/function.cpp: Removed.
  • kjs/function.h: Removed.
  • kjs/function_object.cpp:
  • kjs/function_object.h:
  • kjs/grammar.y:
  • kjs/internal.cpp:
  • kjs/internal.h: Removed.
  • kjs/lexer.cpp:
  • kjs/list.h:
  • kjs/lookup.h:
  • kjs/nodes.h:
  • kjs/object.cpp: Removed.
  • kjs/object.h: Removed.
  • kjs/object_object.h:
  • kjs/operations.cpp:
  • kjs/property_map.cpp:
  • kjs/property_slot.cpp:
  • kjs/property_slot.h:
  • kjs/protect.h:
  • kjs/regexp_object.cpp:
  • kjs/scope_chain.cpp:
  • kjs/string_object.h:
  • kjs/ustring.cpp:
  • kjs/value.cpp: Removed.
  • kjs/value.h: Removed.
  • profiler/Profile.cpp:
  • profiler/Profiler.cpp:

JavaScriptGlue:

2008-06-15 Darin Adler <Darin Adler>

  • ForwardingHeaders/kjs/JSValue.h: Copied from JavaScriptGlue/ForwardingHeaders/kjs/value.h.
  • ForwardingHeaders/kjs/value.h: Removed.
  • JSUtils.h:

WebCore:

2008-06-15 Darin Adler <Darin Adler>

  • ForwardingHeaders/kjs/JSFunction.h: Copied from WebCore/ForwardingHeaders/kjs/function.h.
  • ForwardingHeaders/kjs/JSObject.h: Copied from WebCore/ForwardingHeaders/kjs/object.h.
  • ForwardingHeaders/kjs/JSString.h: Copied from WebCore/ForwardingHeaders/kjs/internal.h.
  • ForwardingHeaders/kjs/JSValue.h: Copied from WebCore/ForwardingHeaders/kjs/value.h.
  • ForwardingHeaders/kjs/function.h: Removed.
  • ForwardingHeaders/kjs/internal.h: Removed.
  • ForwardingHeaders/kjs/object.h: Removed.
  • ForwardingHeaders/kjs/value.h: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSCustomSQLStatementCallback.h:
  • bindings/js/JSCustomSQLStatementErrorCallback.h:
  • bindings/js/JSCustomSQLTransactionErrorCallback.h:
  • bindings/js/JSCustomVoidCallback.h:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSQuarantinedObjectWrapper.h:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_utility.h:
  • bridge/qt/qt_runtime.cpp:
  • bridge/runtime.h:
  • bridge/runtime_array.h:
  • bridge/runtime_method.h:
  • bridge/runtime_object.h:
  • bridge/testbindings.cpp:
  • bridge/testbindings.mm:
  • bridge/testqtbindings.cpp:
  • loader/FrameLoader.cpp:
  • page/JavaScriptCallFrame.cpp:
  • page/JavaScriptProfile.cpp:
  • page/JavaScriptProfileNode.cpp:
  • platform/graphics/gtk/VideoSinkGStreamer.h:
  • plugins/PluginView.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:

WebKit/gtk:

2008-06-15 Darin Adler <Darin Adler>

  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • webkit/webkitnetworkrequest.h:
  • webkit/webkitwebbackforwardlist.h:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebhistoryitem.h:
  • webkit/webkitwebsettings.h:

WebKit/mac:

2008-06-15 Darin Adler <Darin Adler>

  • ForwardingHeaders/kjs/JSFunction.h: Copied from WebKit/mac/ForwardingHeaders/kjs/function.h.
  • ForwardingHeaders/kjs/JSObject.h: Copied from WebKit/mac/ForwardingHeaders/kjs/object.h.
  • ForwardingHeaders/kjs/JSString.h: Copied from WebKit/mac/ForwardingHeaders/kjs/internal.h.
  • ForwardingHeaders/kjs/JSValue.h: Copied from WebKit/mac/ForwardingHeaders/kjs/value.h.
  • ForwardingHeaders/kjs/function.h: Removed.
  • ForwardingHeaders/kjs/internal.h: Removed.
  • ForwardingHeaders/kjs/object.h: Removed.
  • ForwardingHeaders/kjs/value.h: Removed.
  • WebView/WebScriptDebugDelegate.mm:

WebKit/qt:

2008-06-15 Darin Adler <Darin Adler>

  • Api/qwebframe.cpp:

WebKit/win:

2008-06-15 Darin Adler <Darin Adler>

  • WebView.cpp:

WebKit/wx:

2008-06-15 Darin Adler <Darin Adler>

  • WebView.cpp:

WebKitTools:

2008-06-15 Darin Adler <Darin Adler>

  • Scripts/do-file-rename: Updated for the latest round of renaming.
  • Scripts/do-webcore-rename: Tweaked and reorganized a bit.
8:02 PM Changeset in webkit [34580] by Darin Adler
  • 46 edits
    1 add in trunk

JavaScriptCore:

2008-06-15 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • cut down on confusing uses of "Object" and "Imp" in JavaScriptCore class names
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::JSCallbackFunction):
  • API/JSCallbackFunction.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • kjs/ExecState.h: (KJS::ExecState::regExpTable): (KJS::ExecState::regExpConstructorTable):
  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::JSGlobalData): (KJS::JSGlobalData::~JSGlobalData):
  • kjs/JSGlobalData.h:
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset):
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::objectConstructor): (KJS::JSGlobalObject::functionConstructor): (KJS::JSGlobalObject::arrayConstructor): (KJS::JSGlobalObject::booleanConstructor): (KJS::JSGlobalObject::stringConstructor): (KJS::JSGlobalObject::numberConstructor): (KJS::JSGlobalObject::dateConstructor): (KJS::JSGlobalObject::regExpConstructor): (KJS::JSGlobalObject::errorConstructor): (KJS::JSGlobalObject::evalErrorConstructor): (KJS::JSGlobalObject::rangeErrorConstructor): (KJS::JSGlobalObject::referenceErrorConstructor): (KJS::JSGlobalObject::syntaxErrorConstructor): (KJS::JSGlobalObject::typeErrorConstructor): (KJS::JSGlobalObject::URIErrorConstructor):
  • kjs/array_object.cpp: (KJS::ArrayConstructor::ArrayConstructor): (KJS::ArrayConstructor::getConstructData): (KJS::ArrayConstructor::construct): (KJS::ArrayConstructor::callAsFunction):
  • kjs/array_object.h:
  • kjs/bool_object.cpp: (KJS::BooleanObject::BooleanObject): (KJS::BooleanPrototype::BooleanPrototype): (KJS::booleanProtoFuncToString): (KJS::booleanProtoFuncValueOf): (KJS::BooleanConstructor::BooleanConstructor): (KJS::BooleanConstructor::getConstructData): (KJS::BooleanConstructor::construct): (KJS::BooleanConstructor::callAsFunction):
  • kjs/bool_object.h:
  • kjs/date_object.cpp: (KJS::DatePrototype::DatePrototype): (KJS::DateConstructor::DateConstructor): (KJS::DateConstructor::getConstructData): (KJS::DateConstructor::construct): (KJS::DateConstructor::callAsFunction): (KJS::DateFunction::DateFunction): (KJS::DateFunction::callAsFunction):
  • kjs/date_object.h:
  • kjs/error_object.cpp: (KJS::ErrorPrototype::ErrorPrototype): (KJS::ErrorConstructor::ErrorConstructor): (KJS::ErrorConstructor::getConstructData): (KJS::ErrorConstructor::construct): (KJS::ErrorConstructor::callAsFunction): (KJS::NativeErrorConstructor::NativeErrorConstructor): (KJS::NativeErrorConstructor::getConstructData): (KJS::NativeErrorConstructor::construct): (KJS::NativeErrorConstructor::callAsFunction): (KJS::NativeErrorConstructor::mark):
  • kjs/error_object.h:
  • kjs/function.cpp: (KJS::JSFunction::JSFunction): (KJS::JSFunction::mark): (KJS::JSFunction::getOwnPropertySlot): (KJS::JSFunction::put): (KJS::JSFunction::deleteProperty): (KJS::PrototypeFunction::PrototypeFunction): (KJS::PrototypeReflexiveFunction::PrototypeReflexiveFunction): (KJS::PrototypeReflexiveFunction::mark):
  • kjs/function.h:
  • kjs/function_object.cpp: (KJS::functionProtoFuncToString): (KJS::FunctionConstructor::FunctionConstructor): (KJS::FunctionConstructor::getConstructData): (KJS::FunctionConstructor::construct): (KJS::FunctionConstructor::callAsFunction):
  • kjs/function_object.h:
  • kjs/internal.cpp: (KJS::StringObject::create): (KJS::JSString::toObject): (KJS::JSString::toThisObject): (KJS::JSString::getOwnPropertySlot): (KJS::InternalFunction::InternalFunction): (KJS::InternalFunction::getCallData): (KJS::InternalFunction::implementsHasInstance):
  • kjs/math_object.cpp: (KJS::MathObject::MathObject): (KJS::MathObject::getOwnPropertySlot): (KJS::MathObject::getValueProperty):
  • kjs/math_object.h:
  • kjs/number_object.cpp: (KJS::NumberObject::NumberObject): (KJS::NumberPrototype::NumberPrototype): (KJS::numberProtoFuncToString): (KJS::numberProtoFuncToLocaleString): (KJS::numberProtoFuncValueOf): (KJS::numberProtoFuncToFixed): (KJS::numberProtoFuncToExponential): (KJS::numberProtoFuncToPrecision): (KJS::NumberConstructor::NumberConstructor): (KJS::NumberConstructor::getOwnPropertySlot): (KJS::NumberConstructor::getValueProperty): (KJS::NumberConstructor::getConstructData): (KJS::NumberConstructor::construct): (KJS::NumberConstructor::callAsFunction):
  • kjs/number_object.h:
  • kjs/object.cpp: (KJS::JSObject::putDirectFunction):
  • kjs/object.h:
  • kjs/object_object.cpp: (KJS::ObjectConstructor::ObjectConstructor): (KJS::ObjectConstructor::getConstructData): (KJS::ObjectConstructor::construct): (KJS::ObjectConstructor::callAsFunction):
  • kjs/object_object.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp):
  • kjs/regexp_object.cpp: (KJS::regExpProtoFuncTest): (KJS::regExpProtoFuncExec): (KJS::regExpProtoFuncCompile): (KJS::regExpProtoFuncToString): (KJS::RegExpObject::RegExpObject): (KJS::RegExpObject::~RegExpObject): (KJS::RegExpObject::getOwnPropertySlot): (KJS::RegExpObject::getValueProperty): (KJS::RegExpObject::put): (KJS::RegExpObject::putValueProperty): (KJS::RegExpObject::match): (KJS::RegExpObject::test): (KJS::RegExpObject::exec): (KJS::RegExpObject::getCallData): (KJS::RegExpObject::callAsFunction): (KJS::RegExpConstructorPrivate::RegExpConstructorPrivate): (KJS::RegExpConstructor::RegExpConstructor): (KJS::RegExpConstructor::performMatch): (KJS::RegExpMatchesArray::RegExpMatchesArray): (KJS::RegExpMatchesArray::~RegExpMatchesArray): (KJS::RegExpMatchesArray::fillArrayInstance): (KJS::RegExpConstructor::arrayOfMatches): (KJS::RegExpConstructor::getBackref): (KJS::RegExpConstructor::getLastParen): (KJS::RegExpConstructor::getLeftContext): (KJS::RegExpConstructor::getRightContext): (KJS::RegExpConstructor::getOwnPropertySlot): (KJS::RegExpConstructor::getValueProperty): (KJS::RegExpConstructor::put): (KJS::RegExpConstructor::putValueProperty): (KJS::RegExpConstructor::getConstructData): (KJS::RegExpConstructor::construct): (KJS::RegExpConstructor::callAsFunction): (KJS::RegExpConstructor::input):
  • kjs/regexp_object.h:
  • kjs/string_object.cpp: (KJS::StringObject::StringObject): (KJS::StringObject::getOwnPropertySlot): (KJS::StringObject::put): (KJS::StringObject::deleteProperty): (KJS::StringObject::getPropertyNames): (KJS::StringPrototype::StringPrototype): (KJS::StringPrototype::getOwnPropertySlot): (KJS::replace): (KJS::stringProtoFuncToString): (KJS::stringProtoFuncValueOf): (KJS::stringProtoFuncCharAt): (KJS::stringProtoFuncCharCodeAt): (KJS::stringProtoFuncConcat): (KJS::stringProtoFuncIndexOf): (KJS::stringProtoFuncLastIndexOf): (KJS::stringProtoFuncMatch): (KJS::stringProtoFuncSearch): (KJS::stringProtoFuncReplace): (KJS::stringProtoFuncSlice): (KJS::stringProtoFuncSplit): (KJS::stringProtoFuncSubstr): (KJS::stringProtoFuncSubstring): (KJS::stringProtoFuncToLowerCase): (KJS::stringProtoFuncToUpperCase): (KJS::stringProtoFuncToLocaleLowerCase): (KJS::stringProtoFuncToLocaleUpperCase): (KJS::stringProtoFuncLocaleCompare): (KJS::stringProtoFuncBig): (KJS::stringProtoFuncSmall): (KJS::stringProtoFuncBlink): (KJS::stringProtoFuncBold): (KJS::stringProtoFuncFixed): (KJS::stringProtoFuncItalics): (KJS::stringProtoFuncStrike): (KJS::stringProtoFuncSub): (KJS::stringProtoFuncSup): (KJS::stringProtoFuncFontcolor): (KJS::stringProtoFuncFontsize): (KJS::stringProtoFuncAnchor): (KJS::stringProtoFuncLink): (KJS::StringConstructor::StringConstructor): (KJS::StringConstructor::getConstructData): (KJS::StringConstructor::construct): (KJS::StringConstructor::callAsFunction): (KJS::StringConstructorFunction::StringConstructorFunction): (KJS::StringConstructorFunction::callAsFunction):
  • kjs/string_object.h: (KJS::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
  • profiler/Profiler.cpp: (KJS::createCallIdentifier):

WebCore:

2008-06-15 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • cut down on confusing uses of "Object" and "Imp" in JavaScriptCore class names
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter):
  • bridge/qt/qt_runtime.cpp: (KJS::Bindings::valueRealType): (KJS::Bindings::convertValueToQVariant): (KJS::Bindings::convertQVariantToValue): (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_method.cpp: (RuntimeMethod::RuntimeMethod): (RuntimeMethod::getOwnPropertySlot):
  • bridge/runtime_method.h:

WebKitTools:

2008-06-15 Darin Adler <Darin Adler>

  • Scripts/create-exports: Added.
  • Scripts/do-file-rename: Added some planned renames.
  • Scripts/do-webcore-rename: Updated for the latest round of renaming.
7:59 PM BuildingGtk edited by alp@atoker.com
Note that API is now stable (diff)
7:37 PM Changeset in webkit [34579] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/5825683> Three slash URLs are modified by WebKit

Test: fast/loader/url-parse-1.html

URIs in which the scheme is followed by ":" are ambiguous, because
"" can be either the beginning of a net_path or the beginning of an
abs_path whose first path segment is empty. In the case of ":/", the
net_path interpretation is invalid, because the authority (the part
between the second and third slashes) cannot be empty. However, for
historical reasons, this is allowed in http:, https: and file: URLs,
in which an empty authority means the local host.

  • platform/KURL.cpp: (WebCore::KURL::parse): Changed to interpret URLs in which the scheme is followed by ":/" as abs_path-only URLs, unless the scheme is http, https or file.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/5825683> Three slash URLs are modified by WebKit
  • fast/loader/url-parse-1-expected.txt: Added.
  • fast/loader/url-parse-1.html: Added.
7:19 PM Changeset in webkit [34578] by Darin Adler
  • 42 edits in trunk

JavaScriptCore:

2008-06-15 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • use JS prefix and simpler names for basic JavaScriptCore types, to complement JSValue and JSObject
  • JavaScriptCore.exp:
  • VM/Machine.cpp: (KJS::jsLess): (KJS::jsLessEq): (KJS::jsAdd): (KJS::callEval): (KJS::Machine::execute): (KJS::Machine::retrieveArguments): (KJS::Machine::retrieveCaller): (KJS::Machine::getCallFrame): (KJS::Machine::getFunctionAndArguments):
  • VM/Machine.h:
  • VM/Register.h:
  • kjs/DebuggerCallFrame.cpp: (KJS::DebuggerCallFrame::functionName):
  • kjs/ExecState.h:
  • kjs/JSActivation.cpp: (KJS::JSActivation::createArgumentsObject):
  • kjs/array_instance.cpp: (KJS::): (KJS::JSArray::checkConsistency): (KJS::JSArray::JSArray): (KJS::JSArray::~JSArray): (KJS::JSArray::getItem): (KJS::JSArray::lengthGetter): (KJS::JSArray::inlineGetOwnPropertySlot): (KJS::JSArray::getOwnPropertySlot): (KJS::JSArray::put): (KJS::JSArray::deleteProperty): (KJS::JSArray::getPropertyNames): (KJS::JSArray::increaseVectorLength): (KJS::JSArray::setLength): (KJS::JSArray::mark): (KJS::JSArray::sort): (KJS::JSArray::compactForSorting): (KJS::JSArray::lazyCreationData): (KJS::JSArray::setLazyCreationData):
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (KJS::): (KJS::ArrayPrototype::ArrayPrototype): (KJS::ArrayPrototype::getOwnPropertySlot): (KJS::arrayProtoFuncToString): (KJS::arrayProtoFuncToLocaleString): (KJS::arrayProtoFuncConcat): (KJS::arrayProtoFuncSort): (KJS::ArrayObjectImp::construct):
  • kjs/array_object.h:
  • kjs/completion.h:
  • kjs/function.cpp: (KJS::): (KJS::JSFunction::JSFunction): (KJS::JSFunction::mark): (KJS::JSFunction::getCallData): (KJS::JSFunction::callAsFunction): (KJS::JSFunction::argumentsGetter): (KJS::JSFunction::callerGetter): (KJS::JSFunction::lengthGetter): (KJS::JSFunction::getOwnPropertySlot): (KJS::JSFunction::put): (KJS::JSFunction::deleteProperty): (KJS::JSFunction::getParameterName): (KJS::JSFunction::getConstructData): (KJS::JSFunction::construct): (KJS::IndexToNameMap::IndexToNameMap): (KJS::Arguments::Arguments):
  • kjs/function.h:
  • kjs/function_object.cpp: (KJS::functionProtoFuncToString): (KJS::functionProtoFuncApply): (KJS::FunctionObjectImp::construct):
  • kjs/internal.cpp: (KJS::JSString::toPrimitive): (KJS::JSString::getPrimitiveNumber): (KJS::JSString::toBoolean): (KJS::JSString::toNumber): (KJS::JSString::toString): (KJS::StringInstance::create): (KJS::JSString::toObject): (KJS::JSString::toThisObject): (KJS::JSString::lengthGetter): (KJS::JSString::indexGetter): (KJS::JSString::indexNumericPropertyGetter): (KJS::JSString::getOwnPropertySlot): (KJS::JSNumberCell::type): (KJS::JSNumberCell::toPrimitive): (KJS::JSNumberCell::getPrimitiveNumber): (KJS::JSNumberCell::toBoolean): (KJS::JSNumberCell::toNumber): (KJS::JSNumberCell::toString): (KJS::JSNumberCell::toObject): (KJS::JSNumberCell::toThisObject): (KJS::JSNumberCell::getUInt32): (KJS::JSNumberCell::getTruncatedInt32): (KJS::JSNumberCell::getTruncatedUInt32): (KJS::GetterSetter::mark): (KJS::GetterSetter::toPrimitive): (KJS::GetterSetter::getPrimitiveNumber): (KJS::GetterSetter::toBoolean): (KJS::GetterSetter::toNumber): (KJS::GetterSetter::toString): (KJS::GetterSetter::toObject): (KJS::GetterSetter::getOwnPropertySlot): (KJS::GetterSetter::put): (KJS::GetterSetter::toThisObject):
  • kjs/internal.h: (KJS::JSString::JSString): (KJS::JSString::getStringPropertySlot):
  • kjs/nodes.cpp: (KJS::FuncDeclNode::makeFunction): (KJS::FuncExprNode::makeFunction):
  • kjs/nodes.h:
  • kjs/object.cpp: (KJS::JSObject::put): (KJS::JSObject::deleteProperty): (KJS::JSObject::defineGetter): (KJS::JSObject::defineSetter): (KJS::JSObject::lookupGetter): (KJS::JSObject::lookupSetter): (KJS::JSObject::fillGetterPropertySlot):
  • kjs/object.h: (KJS::): (KJS::GetterSetter::GetterSetter):
  • kjs/operations.cpp: (KJS::equal): (KJS::strictEqual):
  • kjs/property_map.cpp: (KJS::PropertyMap::containsGettersOrSetters):
  • kjs/regexp_object.cpp: (KJS::RegExpMatchesArray::getOwnPropertySlot): (KJS::RegExpMatchesArray::put): (KJS::RegExpMatchesArray::deleteProperty): (KJS::RegExpMatchesArray::getPropertyNames): (KJS::RegExpMatchesArray::RegExpMatchesArray): (KJS::RegExpMatchesArray::fillArrayInstance):
  • kjs/string_object.cpp: (KJS::StringInstance::StringInstance): (KJS::replace): (KJS::stringProtoFuncReplace): (KJS::stringProtoFuncToLowerCase): (KJS::stringProtoFuncToUpperCase): (KJS::stringProtoFuncToLocaleLowerCase): (KJS::stringProtoFuncToLocaleUpperCase):
  • kjs/string_object.h: (KJS::StringInstance::internalValue):
  • kjs/value.cpp: (KJS::JSCell::getNumber): (KJS::JSCell::getString): (KJS::JSCell::getObject): (KJS::jsString): (KJS::jsOwnedString):
  • kjs/value.h: (KJS::JSNumberCell::JSNumberCell): (KJS::jsNumberCell): (KJS::JSValue::uncheckedGetNumber):
  • profiler/Profiler.cpp: (KJS::createCallIdentifier): (KJS::createCallIdentifierFromFunctionImp):

WebCore:

2008-06-15 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • use JS prefix and simpler names for basic JavaScriptCore types, to complement JSValue and JSObject
  • bindings/js/JSNavigatorCustom.cpp: (WebCore::needsYouTubeQuirk):
  • bindings/js/kjs_events.cpp: (WebCore::JSLazyEventListener::parseCode):
  • bridge/jni/jni_utility.cpp: (KJS::Bindings::convertArrayInstanceToJavaArray): (KJS::Bindings::convertValueToJValue):
  • bridge/qt/qt_runtime.cpp: (KJS::Bindings::valueRealType): (KJS::Bindings::convertValueToQVariant): (KJS::Bindings::QtConnectionObject::execute):
  • bridge/runtime_array.cpp:

WebKit/mac:

2008-06-15 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • use JS prefix and simpler names for basic JavaScriptCore types, to complement JSValue and JSObject
  • WebView/WebView.mm: (aeDescFromJSValue):

WebKit/win:

2008-06-15 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • use JS prefix and simpler names for basic JavaScriptCore types, to complement JSValue and JSObject
  • WebScriptCallFrame.cpp: (WebScriptCallFrame::functionName):

WebKitTools:

2008-06-15 Darin Adler <Darin Adler>

  • Scripts/do-webcore-rename: Updated for the latest round of renaming.
7:11 PM Changeset in webkit [34577] by alp@webkit.org
  • 1 edit in trunk/configure.ac

Versioning.

6:53 PM ApplicationsGtk edited by alp@atoker.com
Add Blam and ilcontrast (diff)
4:59 PM Changeset in webkit [34576] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-06-15 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Alexey.


  • add emitUnaryOp, emitNullaryOp and emitUnaryOpNoDst; use them


This removes some boilerplate code and also reduces the number of
places that will need to be changed to do on-demand emit of
loads (and thus support k operands).

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitUnaryOp): (KJS::CodeGenerator::emitNullaryOp): (KJS::CodeGenerator::emitUnaryOpNoDst): (KJS::CodeGenerator::emitPushScope):
  • VM/CodeGenerator.h: (KJS::CodeGenerator::emitNewObject): (KJS::CodeGenerator::emitNewArray): (KJS::CodeGenerator::emitNot): (KJS::CodeGenerator::emitBitNot): (KJS::CodeGenerator::emitToJSNumber): (KJS::CodeGenerator::emitNegate): (KJS::CodeGenerator::emitInstanceOf): (KJS::CodeGenerator::emitTypeOf): (KJS::CodeGenerator::emitIn): (KJS::CodeGenerator::emitReturn): (KJS::CodeGenerator::emitEnd): (KJS::CodeGenerator::emitGetPropertyNames):
3:10 PM Changeset in webkit [34575] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-15 Darin Adler <Darin Adler>

Reviewed by Mitz.

This fix eliminates the crash, but the logic remaining seems a little strange.
We create an IconRecord and then immediately destroy it. Worth taking another
look at this later.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconDataForIconURL): Added code to remove the icon just as in the other cases where we might be holding the single reference to it. (WebCore::IconDatabase::setIconURLForPageURL): Fixed comment typo. (WebCore::IconDatabase::writeToDatabase): Removed unused local variable.
2:53 PM Changeset in webkit [34574] by weinig@apple.com
  • 32 edits
    3 adds in trunk

WebCore:

2008-06-15 Darin Adler <Darin Adler>

Reviewed and tweaked by Sam Weinig.

Fix for <rdar://problem/5908591>
​https://bugs.webkit.org/show_bug.cgi?id=18743

Makes DOMImplementation per-document.

Test: http/tests/security/cross-frame-access-DOMImplementation.html

  • bindings/objc/DOMImplementationFront.cpp: (WebCore::DOMImplementationFront::getInterface):
  • bindings/objc/DOMImplementationFront.h:
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::hasFeature): (WebCore::DOMImplementation::createDocumentType): (WebCore::DOMImplementation::getInterface): (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
  • dom/DOMImplementation.h: (WebCore::DOMImplementation::create):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::implementation):
  • dom/Document.h: (WebCore::Document::create): (WebCore::Document::createXHTML):
  • dom/DocumentType.cpp:
  • dom/DocumentType.h: (WebCore::DocumentType::create): (WebCore::DocumentType::entities): (WebCore::DocumentType::notations): (WebCore::DocumentType::name): (WebCore::DocumentType::publicId): (WebCore::DocumentType::systemId): (WebCore::DocumentType::internalSubset):
  • dom/Node.cpp: (WebCore::Node::isSupported):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::internalSubset):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
  • html/HTMLDocument.h: (WebCore::HTMLDocument::create): (WebCore::HTMLDocument::isHTMLDocument):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::parseDoctypeToken):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::createTokenizer):
  • html/HTMLViewSourceDocument.h: (WebCore::HTMLViewSourceDocument::create):
  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocument::FTPDirectoryDocument):
  • loader/FTPDirectoryDocument.h: (WebCore::FTPDirectoryDocument::create):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin):
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::ImageDocument):
  • loader/ImageDocument.h: (WebCore::ImageDocument::create): (WebCore::ImageDocument::isImageDocument):
  • loader/PluginDocument.cpp: (WebCore::PluginDocument::PluginDocument):
  • loader/PluginDocument.h: (WebCore::PluginDocument::create): (WebCore::PluginDocument::isPluginDocument):
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::checkBuffer): (WebCore::TextDocument::TextDocument): (WebCore::createTextTokenizer):
  • loader/TextDocument.h: (WebCore::TextDocument::create):
  • svg/SVGDocument.cpp: (WebCore::SVGDocument::SVGDocument):
  • svg/SVGDocument.h: (WebCore::SVGDocument::create):
  • svg/SVGElement.cpp: (WebCore::SVGElement::isSupported):
  • svg/SVGTests.cpp: (WebCore::SVGTests::isValid):
  • xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString):

LayoutTests:

2008-06-15 Darin Adler <Darin Adler>

Reviewed and tweaked by Sam Weinig.

Test for <rdar://problem/5908591>
​https://bugs.webkit.org/show_bug.cgi?id=18743

  • http/tests/security/cross-frame-access-DOMImplementation-expected.txt: Added.
  • http/tests/security/cross-frame-access-DOMImplementation.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-DOMImplementation-test.html: Added.
12:47 PM Changeset in webkit [34573] by mitz@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

  • copy generic test results from r34449 to platform/win, because the Mac behavior is not shared by Windows.
  • platform/win/editing/selection/drag-text-delay-expected.txt: Copied from LayoutTests/editing/selection/drag-text-delay-expected.txt.
12:41 PM Changeset in webkit [34572] by mitz@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests
  • update Windows copy of generic test results for r34475
  • platform/win/editing/selection/move-left-right-expected.txt: Replaced with LayoutTests/editing/selection/move-left-right-expected.txt.
7:40 AM Changeset in webkit [34571] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

[GTK] Property setters do not call g_object_notify()

​https://bugs.webkit.org/show_bug.cgi?id=18405

Reviewed by Alp Toker.

7:06 AM Changeset in webkit [34570] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

Tiny documentation fix, s/capacity/limit

Reviewed by Alp Toker.

4:46 AM Changeset in webkit [34569] by cwzwarich@webkit.org
  • 3 edits in trunk/WebCore

2008-06-15 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Mac build fix.

  • WebCore.base.exp:
  • WebCore.order:
4:46 AM Changeset in webkit [34568] by alp@webkit.org
  • 4 edits in trunk

2008-06-15 Alp Toker <​alp@nuanti.com>

Rubber-stamped by Maciej.

Install 'jsc' application by default.

3:59 AM Changeset in webkit [34567] by mjs@apple.com
  • 2 edits in trunk/WebKit/win

2008-06-15 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Oliver.


  • fix WebKit solution for testkjs --> jsc rename
  • WebKit.vcproj/WebKit.sln:
3:55 AM Changeset in webkit [34566] by mjs@apple.com
  • 13 edits
    1 copy
    4 moves
    1 add
    1 delete in trunk

JavaScriptCore:

2008-06-15 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • rename testkjs to jsc
  • GNUmakefile.am:
  • JavaScriptCore.vcproj/JavaScriptCore.sln:
  • JavaScriptCore.vcproj/jsc: Added.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Copied from JavaScriptCore.vcproj/testkjs/testkjs.vcproj.
  • JavaScriptCore.vcproj/testkjs: Removed.
  • JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Removed.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jscore.bkl:
  • kjs/Shell.cpp: Copied from kjs/testkjs.cpp. (main): (printUsageStatement): (jscmain):
  • kjs/jsc.pro: Copied from kjs/testkjs.pro.
  • kjs/testkjs.cpp: Removed.
  • kjs/testkjs.pro: Removed.
  • tests/mozilla/expected.html:
  • tests/mozilla/js1_2/Array/tostring_1.js:
  • tests/mozilla/js1_2/Array/tostring_2.js:
  • tests/mozilla/jsDriver.pl:

WebKitTools:

2008-06-15 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • rename testkjs to jsc
  • Scripts/build-jsc: Copied from Scripts/build-testkjs.
  • Scripts/build-testkjs: Removed.
  • Scripts/run-javascriptcore-tests:
  • Scripts/run-jsc: Copied from Scripts/run-testkjs.
  • Scripts/run-sunspider:
  • Scripts/run-testkjs: Removed.
  • Scripts/sunspider-compare-results:
3:38 AM Changeset in webkit [34565] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-06-15 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Mac build fix.

2:55 AM Changeset in webkit [34564] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-15 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Change the spelling of PrecMultiplicitave to PrecMultiplicative.

  • kjs/nodes.h: (KJS::): (KJS::MultNode::precedence): (KJS::DivNode::precedence): (KJS::ModNode::precedence):
2:40 AM Changeset in webkit [34563] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-15 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Remove unused preprocessor macros related to exceptions in the old
interpreter.

  • kjs/nodes.cpp:
2:30 AM Changeset in webkit [34562] by cwzwarich@webkit.org
  • 10 edits in trunk

2008-06-15 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Bug 19484: More instructions needs to use temporary registers
<​https://bugs.webkit.org/show_bug.cgi?id=19484>

Fix codegen for all binary operations so that temporaries are used if
necessary. This was done by making BinaryOpNode and ReverseBinaryOpNode
subclasses of ExpressionNode, and eliminating the custom emitCode()
methods for the individual node classes.

This only adds 3 new instructions to SunSpider code, and there is no
difference in SunSpider execution time.

JavaScriptCore:

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitBitNot): (KJS::CodeGenerator::emitBinaryOp):
  • VM/CodeGenerator.h:
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::PreIncResolveNode::emitCode): (KJS::PreDecResolveNode::emitCode): (KJS::BinaryOpNode::emitCode): (KJS::ReverseBinaryOpNode::emitCode): (KJS::emitReadModifyAssignment): (KJS::CaseBlockNode::emitCodeForBlock):
  • kjs/nodes.h: (KJS::BinaryOpNode::BinaryOpNode): (KJS::ReverseBinaryOpNode::ReverseBinaryOpNode): (KJS::MultNode::): (KJS::DivNode::): (KJS::DivNode::precedence): (KJS::ModNode::): (KJS::ModNode::precedence): (KJS::AddNode::): (KJS::AddNode::precedence): (KJS::SubNode::): (KJS::SubNode::precedence): (KJS::LeftShiftNode::): (KJS::LeftShiftNode::precedence): (KJS::RightShiftNode::): (KJS::RightShiftNode::precedence): (KJS::UnsignedRightShiftNode::): (KJS::UnsignedRightShiftNode::precedence): (KJS::LessNode::): (KJS::LessNode::precedence): (KJS::GreaterNode::): (KJS::GreaterNode::precedence): (KJS::LessEqNode::): (KJS::LessEqNode::precedence): (KJS::GreaterEqNode::): (KJS::GreaterEqNode::precedence): (KJS::InstanceOfNode::): (KJS::InstanceOfNode::precedence): (KJS::InNode::): (KJS::InNode::precedence): (KJS::EqualNode::): (KJS::EqualNode::precedence): (KJS::NotEqualNode::): (KJS::NotEqualNode::precedence): (KJS::StrictEqualNode::): (KJS::StrictEqualNode::precedence): (KJS::NotStrictEqualNode::): (KJS::NotStrictEqualNode::precedence): (KJS::BitAndNode::): (KJS::BitAndNode::precedence): (KJS::BitOrNode::): (KJS::BitOrNode::precedence): (KJS::BitXOrNode::): (KJS::BitXOrNode::precedence):
  • kjs/nodes2string.cpp: (KJS::LessNode::streamTo): (KJS::GreaterNode::streamTo): (KJS::LessEqNode::streamTo): (KJS::GreaterEqNode::streamTo): (KJS::InstanceOfNode::streamTo): (KJS::InNode::streamTo): (KJS::EqualNode::streamTo): (KJS::NotEqualNode::streamTo): (KJS::StrictEqualNode::streamTo): (KJS::NotStrictEqualNode::streamTo): (KJS::BitAndNode::streamTo): (KJS::BitXOrNode::streamTo): (KJS::BitOrNode::streamTo):

LayoutTests:

  • fast/js/codegen-temporaries-expected.txt:
  • fast/js/resources/codegen-temporaries.js:
12:00 AM Changeset in webkit [34561] by Darin Adler
  • 85 edits
    4 moves in trunk

WebCore:

2008-06-14 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • new names for kjs_binding.h and kjs_proxy.h
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSCustomSQLStatementCallback.cpp:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  • bindings/js/JSCustomSQLTransactionCallback.cpp:
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  • bindings/js/JSCustomVoidCallback.cpp:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSDOMBinding.cpp: Copied from WebCore/bindings/js/kjs_binding.cpp.
  • bindings/js/JSDOMBinding.h: Copied from WebCore/bindings/js/kjs_binding.h.
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSHTMLCollectionCustom.cpp:
  • bindings/js/JSHTMLFrameElementCustom.cpp:
  • bindings/js/JSHTMLFrameSetElementCustom.cpp:
  • bindings/js/JSHTMLIFrameElementCustom.cpp:
  • bindings/js/JSHTMLInputElementBase.h:
  • bindings/js/JSHTMLOptionElementConstructor.h:
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSLocationCustom.cpp:
  • bindings/js/JSNamedNodeMapCustom.cpp:
  • bindings/js/JSNamedNodesCollection.h:
  • bindings/js/JSNodeFilterCondition.cpp:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSRGBColor.h:
  • bindings/js/JSSVGPathSegCustom.cpp:
  • bindings/js/JSXMLHttpRequestConstructor.h:
  • bindings/js/JSXSLTProcessorConstructor.h:
  • bindings/js/JSXSLTProcessorCustom.cpp:
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/ScriptController.cpp: Copied from WebCore/bindings/js/kjs_proxy.cpp.
  • bindings/js/ScriptController.h: Copied from WebCore/bindings/js/kjs_proxy.h.
  • bindings/js/kjs_binding.cpp: Removed.
  • bindings/js/kjs_binding.h: Removed.
  • bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent):
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_html.h:
  • bindings/js/kjs_proxy.cpp: Removed.
  • bindings/js/kjs_proxy.h: Removed.
  • bindings/objc/DOMInternal.mm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/jni/jni_jsobject.mm:
  • dom/Document.cpp:
  • dom/EventTarget.cpp:
  • dom/Node.cpp:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore):
  • html/HTMLPlugInElement.cpp:
  • html/HTMLScriptElement.cpp:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processToken):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeScript):
  • page/Frame.cpp: (WebCore::Frame::scriptProxy):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/InspectorController.cpp:
  • page/JavaScriptDebugServer.cpp:
  • page/JavaScriptProfileNode.cpp:
  • page/Page.cpp:
  • page/gtk/FrameGtk.cpp:
  • page/mac/FrameMac.mm:
  • page/qt/FrameQt.cpp:
  • page/win/FrameWin.cpp:
  • plugins/PluginView.cpp: (WebCore::getString):
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:
  • svg/SVGDocumentExtensions.cpp:
  • xml/XMLHttpRequest.cpp:

WebKit/gtk:

2008-06-14 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • new names for kjs_binding.h and kjs_proxy.h
  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • webkit/webkitwebframe.cpp:

WebKit/mac:

2008-06-14 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • new names for kjs_binding.h and kjs_proxy.h
  • WebView/WebFrame.mm:
  • WebView/WebScriptDebugDelegate.mm:
  • WebView/WebView.mm:

WebKit/qt:

2008-06-14 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • new names for kjs_binding.h and kjs_proxy.h
  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
  • WebKit_pch.h:

WebKit/win:

2008-06-14 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • new names for kjs_binding.h and kjs_proxy.h
  • WebFrame.cpp:

WebKit/wx:

2008-06-14 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • new names for kjs_binding.h and kjs_proxy.h
  • WebView.cpp:

WebKitTools:

2008-06-14 Darin Adler <Darin Adler>

  • Scripts/do-webcore-rename: Moved planned renames into a separate hash from the actual renames. Removed many renames that are either done or no longer planned.

Jun 14, 2008:

11:23 PM Changeset in webkit [34560] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

2008-06-14 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • rename a bunch of local symbols within the regular expression code to follow our usual coding style, and do a few other name tweaks
  • pcre/pcre_compile.cpp: (CompileData::CompileData): (checkEscape): (readRepeatCounts): (compileBranch): (compileBracket): (calculateCompiledPatternLength): (returnError): (jsRegExpCompile):
  • pcre/pcre_exec.cpp: (MatchStack::MatchStack): (MatchStack::canUseStackBufferForNextFrame): (MatchStack::popCurrentFrame): (match): (tryFirstByteOptimization): (tryRequiredByteOptimization): (jsRegExpExecute):
  • pcre/pcre_internal.h:
11:09 PM Changeset in webkit [34559] by Darin Adler
  • 35 edits
    2 moves in trunk

WebCore:

2008-06-14 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • renamed HTMLGenericFormElement to HTMLFormControlElement
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement): (WebCore::HTMLButtonElement::parseMappedAttribute): (WebCore::HTMLButtonElement::defaultEventHandler):
  • html/HTMLButtonElement.h:
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
  • html/HTMLFieldSetElement.h:
  • html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::item): (WebCore::HTMLFormCollection::getNamedFormItem): (WebCore::HTMLFormCollection::updateNameCache):
  • html/HTMLFormControlElement.cpp: Copied from WebCore/html/HTMLGenericFormElement.cpp.
  • html/HTMLFormControlElement.h: Copied from WebCore/html/HTMLGenericFormElement.h.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::formElementIndex): (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement): (WebCore::HTMLFormElement::elementForAlias): (WebCore::HTMLFormElement::addElementAlias): (WebCore::HTMLFormElement::getNamedElements): (WebCore::HTMLFormElement::CheckedRadioButtons::addButton): (WebCore::HTMLFormElement::CheckedRadioButtons::removeButton):
  • html/HTMLFormElement.h:
  • html/HTMLGenericFormElement.cpp: Removed.
  • html/HTMLGenericFormElement.h: Removed.
  • html/HTMLInputElement.h:
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::parseMappedAttribute):
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::parseMappedAttribute):
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::HTMLLegendElement):
  • html/HTMLLegendElement.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::HTMLOptGroupElement): (WebCore::HTMLOptGroupElement::insertBefore): (WebCore::HTMLOptGroupElement::replaceChild): (WebCore::HTMLOptGroupElement::removeChild): (WebCore::HTMLOptGroupElement::appendChild): (WebCore::HTMLOptGroupElement::removeChildren): (WebCore::HTMLOptGroupElement::childrenChanged): (WebCore::HTMLOptGroupElement::parseMappedAttribute): (WebCore::HTMLOptGroupElement::attach): (WebCore::HTMLOptGroupElement::detach):
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::HTMLOptionElement): (WebCore::HTMLOptionElement::attach): (WebCore::HTMLOptionElement::detach): (WebCore::HTMLOptionElement::parseMappedAttribute): (WebCore::HTMLOptionElement::childrenChanged): (WebCore::HTMLOptionElement::disabled): (WebCore::HTMLOptionElement::insertedIntoDocument):
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLTextAreaElement.h:
  • page/Frame.cpp: (WebCore::scanForForm): (WebCore::Frame::currentForm):
  • page/mac/FrameMac.mm:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::RenderFieldset):
  • rendering/RenderFieldset.h:
  • rendering/RenderLegend.cpp: (WebCore::RenderLegend::RenderLegend):
  • rendering/RenderLegend.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): (WebCore::RenderTextControl::updateFromElement): (WebCore::RenderTextControl::subtreeHasChanged): (WebCore::RenderTextControl::selectionChanged):

WebKit/mac:

2008-06-14 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • renamed HTMLGenericFormElement to HTMLFormControlElement
  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementWithName:inForm:]): (-[WebHTMLRepresentation controlsInForm:]):

WebKit/win:

2008-06-14 Darin Adler <Darin Adler>

Rubber stamped by Sam.

  • renamed HTMLGenericFormElement to HTMLFormControlElement
  • WebFrame.cpp: (WebFrame::elementWithName): (WebFrame::controlsInForm):
10:56 PM Changeset in webkit [34558] by Darin Adler
  • 5 edits in trunk/WebKit

../win:

2008-06-14 Darin Adler <Darin Adler>

  • try to fix Windows build, again
  • WebFrame.cpp: (WebFrame::dispatchDecidePolicyForNewWindowAction): Fix arguments. Pass form. (WebFrame::dispatchDecidePolicyForNavigationAction): Ditto.
  • WebFrame.h: Fix arguments.

../wx:

2008-06-14 Darin Adler <Darin Adler>

  • try to fix wx build, again
  • WebView.cpp: (wxWebView::Create): Use create function instead of new.
10:54 PM Changeset in webkit [34557] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-06-14 Sam Weinig <​sam@webkit.org>

Windows build fix.

  • bindings/scripts/CodeGeneratorCOM.pm:
10:31 PM Changeset in webkit [34556] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-14 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Remove redundant uses of get().

  • kjs/nodes.cpp: (KJS::BracketAccessorNode::emitCode): (KJS::AddNode::emitCode): (KJS::SubNode::emitCode): (KJS::ReadModifyResolveNode::emitCode): (KJS::AssignDotNode::emitCode): (KJS::ReadModifyDotNode::emitCode): (KJS::AssignBracketNode::emitCode): (KJS::ReadModifyBracketNode::emitCode):
10:24 PM Changeset in webkit [34555] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-06-14 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Make code generation not use a temporary for the left-hand side of an
expression if the right-hand side is a local variable.

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::isLocal):
  • VM/CodeGenerator.h: (KJS::CodeGenerator::leftHandSideNeedsCopy): (KJS::CodeGenerator::emitNodeForLeftHandSide):
  • kjs/nodes.cpp: (KJS::ResolveNode::isPure): (KJS::BracketAccessorNode::emitCode): (KJS::AddNode::emitCode): (KJS::SubNode::emitCode): (KJS::ReadModifyResolveNode::emitCode): (KJS::AssignDotNode::emitCode): (KJS::ReadModifyDotNode::emitCode): (KJS::AssignBracketNode::emitCode): (KJS::ReadModifyBracketNode::emitCode):
  • kjs/nodes.h: (KJS::ExpressionNode::): (KJS::BooleanNode::): (KJS::NumberNode::): (KJS::StringNode::):
9:59 PM Changeset in webkit [34554] by Darin Adler
  • 3 edits in trunk/WebCore

2008-06-14 Darin Adler <Darin Adler>

  • more build fixing
  • platform/gtk/DragDataGtk.cpp: Added missing header.
  • platform/wx/DragDataWx.cpp: Ditto.
9:56 PM Changeset in webkit [34553] by Darin Adler
  • 4 edits in trunk/WebKit/win

2008-06-14 Darin Adler <Darin Adler>

  • try to fix Windows build
  • WebActionPropertyBag.cpp: (WebActionPropertyBag::Read): Use IDOMNode, not IHTMLFormElement.
  • WebFrame.h: Added missing FormState arguments.
  • WebScrollBar.cpp: (WebScrollBar::init): Use create instead of new.
9:40 PM Changeset in webkit [34552] by Darin Adler
  • 3 edits in trunk/WebCore

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Sam.

My recent change introduced a leak of objects owned by each DashboardRegion,
because I made ~Rect non-virtual. By using a separate RefCounted class for
each of Rect and DashboardRegion, the leak is gone. It's not clear if the
DashboardRegion class should really exist -- it doesn't have a DOM binding,
so it could conceivably be removed some day.

  • css/DashboardRegion.h: Derive from RectBase instead of from Rect.
  • css/Rect.h: Added RectBase. Changed Rect to derive from RectBase.
9:32 PM Changeset in webkit [34551] by Darin Adler
  • 9 edits in trunk/WebCore

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Sam.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseGradient): Call release() when assigning result to avoid a little bit of refcount churn.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleRulesForElement): Changed return value to PassRefPtr. (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto.
  • css/CSSStyleSelector.h: Ditto.
  • svg/SVGElementInstanceList.cpp: (WebCore::SVGElementInstanceList::length): Tweaked formatting. (WebCore::SVGElementInstanceList::item): Changed return value to raw pointer.
  • svg/SVGElementInstanceList.h: Ditto.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Changed return value to PassRefPtr. (WebCore::XSLTProcessor::transformToDocument): Ditto. (WebCore::XSLTProcessor::transformToFragment): Ditto.
  • xml/XSLTProcessor.h: Ditto.
9:30 PM Changeset in webkit [34550] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-14 Darin Adler <Darin Adler>

  • try to fix the gtk build
  • platform/gtk/DragDataGtk.cpp: (WebCore::DragData::createClipboard): Changed return type to PassRefPtr.
9:28 PM Changeset in webkit [34549] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-14 Darin Adler <Darin Adler>

  • another try at fixing the wx build
  • platform/wx/DragDataWx.cpp: (WebCore::DragData::createClipboard): Changed return type to PassRefPtr.
9:23 PM Changeset in webkit [34548] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-14 Darin Adler <Darin Adler>

  • try to fix Windows build
  • svg/graphics/SVGImageEmptyClients.h: Added missing include.
8:58 PM Changeset in webkit [34547] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-14 Darin Adler <Darin Adler>

  • fix wx build
  • platform/wx/TemporaryLinkStubs.cpp: Removed unneeded Icon constructor.
8:53 PM Changeset in webkit [34546] by Darin Adler
  • 2 edits in trunk/WebKit/qt

2008-06-14 Darin Adler <Darin Adler>

  • fix build
  • Api/qwebframe.cpp: (QWebFramePrivate::init): Added a missing semicolon.
8:52 PM Changeset in webkit [34545] by Darin Adler
  • 2 edits in trunk/WebKit/gtk

2008-06-14 Darin Adler <Darin Adler>

  • fix build
  • webkit/webkitwebframe.cpp: Remove a bogus release() call.
8:41 PM Changeset in webkit [34544] by Darin Adler
  • 88 edits in trunk

JavaScriptCore:

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Sam.

  • kjs/nodes.cpp: (KJS::ParserRefCounted::hasOneRef): Added. Replaces refcount.
  • kjs/nodes.h: Replaced refcount with hasOneRef.
  • wtf/ListRefPtr.h: (WTF::ListRefPtr::~ListRefPtr): Changed to use hasOneRef instead of refcount, so this class can be used with the RefCounted template.
  • wtf/RefCounted.h: (WTF::RefCounted::hasOneRef): Made const, since there's no reason for it to be non-const.

WebCore:

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Sam.

  • WebCore.base.exp: Added some new exports needed for functions that are now non-virtual.
  • WebCore.xcodeproj/project.pbxproj: Moved the "icon" group to the correct location in the project. Before it was inside "appcache"!
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):
  • editing/mac/EditorMac.mm: (WebCore::Editor::newGeneralClipboard):
  • editing/qt/EditorQt.cpp: (WebCore::Editor::newGeneralClipboard):
  • editing/wx/EditorWx.cpp: (WebCore::Editor::newGeneralClipboard):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::create):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::getOrCreateIconRecord): (WebCore::IconDatabase::performURLImport):
  • loader/icon/IconDatabase.h:
  • loader/icon/IconRecord.cpp: (WebCore::IconRecord::IconRecord):
  • loader/icon/IconRecord.h: (WebCore::IconRecord::create):
  • page/EventHandler.h:
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • page/Frame.h: (WebCore::Frame::create):
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::createDraggingClipboard):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/Cursor.h: (WebCore::SharedCursor::create): (WebCore::SharedCursor::~SharedCursor): (WebCore::SharedCursor::SharedCursor):
  • platform/DragData.h:
  • platform/PopupMenu.h: (WebCore::PopupMenu::create): (WebCore::PopupMenu::isActive):
  • platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar):
  • platform/SearchPopupMenu.h: (WebCore::SearchPopupMenu::create):
  • platform/graphics/FontFamily.cpp: (WebCore::FontFamily::FontFamily): (WebCore::operator==):
  • platform/graphics/FontFamily.h: (WebCore::FontFamily::FontFamily): (WebCore::SharedFontFamily::create): (WebCore::SharedFontFamily::SharedFontFamily): (WebCore::operator!=): (WebCore::FontFamily::next): (WebCore::FontFamily::appendFamily): (WebCore::FontFamily::releaseNext):
  • platform/graphics/Icon.h:
  • platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile):
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::Icon): (WebCore::Icon::newIconForFile):
  • platform/graphics/qt/IconQt.cpp: (WebCore::Icon::Icon): (WebCore::Icon::newIconForFile):
  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile):
  • platform/gtk/ClipboardGtk.cpp: (WebCore::Editor::newGeneralClipboard):
  • platform/gtk/ClipboardGtk.h: (WebCore::ClipboardGtk::create):
  • platform/gtk/PlatformScrollBar.h: (WebCore::PlatformScrollbar::create):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::create): (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
  • platform/mac/ClipboardMac.h: (WebCore::ClipboardMac::create):
  • platform/mac/DragDataMac.mm: (WebCore::DragData::createClipboard): (WebCore::DragData::containsCompatibleContent):
  • platform/mac/PlatformScrollBar.h: (WebCore::PlatformScrollbar::create): (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu):
  • platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::create):
  • platform/qt/DragDataQt.cpp: (WebCore::DragData::createClipboard):
  • platform/qt/PlatformScrollBar.h: (WebCore::PlatformScrollbar::create):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
  • platform/win/ClipboardWin.h: (WebCore::ClipboardWin::create):
  • platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor): (WebCore::loadSharedCursor):
  • platform/win/DragDataWin.cpp: (WebCore::DragData::createClipboard):
  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard):
  • platform/win/PlatformScrollBar.h: (WebCore::PlatformScrollbar::create):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::show):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
  • platform/wx/ClipboardWx.h: (WebCore::ClipboardWx::create):
  • platform/wx/PlatformScrollBar.h: (WebCore::PlatformScrollbar::create):
  • platform/wx/PopupMenuWx.cpp: (WebCore::PopupMenu::PopupMenu):
  • platform/wx/TemporaryLinkStubs.cpp: (Icon::Icon): (Icon::newIconForFile):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
  • svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader):

WebKit/gtk:

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Sam.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createDocumentLoader): Use create instead of new.
  • webkit/webkitwebframe.cpp: (webkit_web_frame_new): Ditto. (webkit_web_frame_init_with_web_view): Ditto.

WebKit/mac:

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Sam.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createDocumentLoader): Use create instead of new. (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by a ref call inside the Frame constructor. The lifetime rules for Frame are now the conventional ones without a special case.
  • WebView/WebDataSource.mm: (-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since this function takes ownership of the DocumentLoader. (-[WebDataSource initWithRequest:]): Use create instead of new.
  • WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a PassRefPtr and also cleaned up the header a bit.
  • WebView/WebDocumentLoaderMac.h: (WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual functions private.
  • WebView/WebFrame.mm: (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead of new.

WebKit/qt:

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Sam.

  • Api/qwebframe.cpp: (QWebFramePrivate::init): Use create instead of new.
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createDocumentLoader): Ditto.

WebKit/win:

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Sam.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by a ref call inside the Frame constructor. The lifetime rules for Frame are now the conventional ones without a special case.
  • WebFrame.cpp: (WebFrame::init): Renamed function from initWithWebFrameView and removed the unused IWebFrameView argument (every caller was passing 0). Also changed this to return the WebCore Frame object, which is needed to straighten out the lifetime and ownership issues.
  • WebFrame.h: Ditto.
  • WebView.cpp: (WebView::initWithFrame): Changed to call new init function and use the return value.

WebKit/wx:

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Sam.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::createDocumentLoader): Use create function instead of new.

LayoutTests:

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • fast/dom/CSSStyleDeclaration/resources/transition-property-names.js: Added.
  • fast/dom/CSSStyleDeclaration/transition-property-names-expected.txt: Added.
  • fast/dom/CSSStyleDeclaration/transition-property-names.html: Added.
7:03 PM Changeset in webkit [34543] by weinig@apple.com
  • 13 edits
    2 copies
    2 adds in trunk

WebCore:

2008-06-14 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/5775192>
insertAdjacentHTML and insertAdjacentText are not implemented although insertAdjacentElement is.

  • Implements insertAdjacentHTML and insertAdjacentText for HTMLElement.
  • Moves the insertAdjacentElement implementation from Element to HTMLElement.

Tests: fast/dynamic/insertAdjacentHTML.html

fast/dynamic/insertAdjacentText.html

  • dom/Element.cpp:
  • dom/Element.h:
  • dom/Element.idl:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::insertAdjacent): (WebCore::HTMLElement::insertAdjacentElement): (WebCore::HTMLElement::insertAdjacentHTML): (WebCore::HTMLElement::insertAdjacentText):
  • html/HTMLElement.h:
  • html/HTMLElement.idl:

LayoutTests:

2008-06-14 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Tests for <rdar://problem/5775192>
insertAdjacentHTML and insertAdjacentText are not implemented although insertAdjacentElement is.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/resources/domListEnumeration.js:
  • fast/dynamic/insertAdjacentElement.html:
  • fast/dynamic/insertAdjacentHTML-expected.txt: Added.
  • fast/dynamic/insertAdjacentHTML.html: Copied from fast/dynamic/insertAdjacentElement.html.
  • fast/dynamic/insertAdjacentText-expected.txt: Added.
  • fast/dynamic/insertAdjacentText.html: Copied from fast/dynamic/insertAdjacentElement.html.
  • platform/mac/fast/dynamic/insertAdjacentElement-expected.txt:
6:03 PM Changeset in webkit [34542] by Darin Adler
  • 4 edits
    3 adds in trunk

WebCore:

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Maciej.

Test: fast/dom/CSSStyleDeclaration/transition-property-names.html

  • css/CSSPrimitiveValue.cpp: (WebCore::valueOrPropertyName): Added. (WebCore::CSSPrimitiveValue::getStringValue): Use valueOrPropertyName since the ident can either be a value or property ID. (WebCore::CSSPrimitiveValue::cssText): Ditto.
  • css/makeprop.pl: Assign property IDs starting at 1001 instead of 1 so they can be stored along with value IDs with no ambiguity.

LayoutTests:

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • fast/dom/CSSStyleDeclaration/resources/transition-property-names.js: Added.
  • fast/dom/CSSStyleDeclaration/transition-property-names-expected.txt: Added.
  • fast/dom/CSSStyleDeclaration/transition-property-names.html: Added.
4:17 PM WebDevelopers edited by timothy@apple.com
(diff)
4:16 PM WebDevelopers edited by timothy@apple.com
(diff)
3:13 PM Changeset in webkit [34541] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-06-14 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • initialize local vars as side effect of call instead of in bytecode 1.004x speedup on SunSpider.

This removes just the dispatch overhead for these loads - in the
future, dead store elimination might be able to eliminate them
entirely.


  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): For function blocks, don't emit loads of undefined for var initialization.
  • VM/Machine.cpp: (KJS::slideRegisterWindowForCall): Instead, initialize locals as part of the call.
12:33 PM Changeset in webkit [34540] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2008-06-14 Adam Barth <​abarth@webkit.org>

Reviewed by David Kilzer.

Fix typo.

  • dom/XMLTokenizer.cpp: (WebCore::shouldAllowExternalLoad):
2:56 AM Changeset in webkit [34539] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-14 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Remove helper functions in the parser that are no longer needed.

  • kjs/grammar.y:
2:18 AM Changeset in webkit [34538] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-14 Darin Adler <Darin Adler>

  • fix build
  • plugins/PluginStream.h: Move functions back into public section.
1:47 AM Changeset in webkit [34537] by Darin Adler
  • 2 edits in trunk/WebKitTools

2008-06-14 Darin Adler <Darin Adler>

  • Scripts/do-webcore-rename: Fixed obvious typo.
1:46 AM Changeset in webkit [34536] by Darin Adler
  • 152 edits in trunk

WebCore:

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Sam.

  • WebCore.base.exp:
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::rotateFromVector): (WebCore::JSSVGMatrix::flipX): (WebCore::JSSVGMatrix::flipY): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
  • bindings/js/JSSVGPODTypeWrapper.h: (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create): (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite): (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create): (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly): (WebCore::JSSVGPODTypeWrapperCreatorForList::create): (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList): (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper): (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
  • bindings/js/JSSVGPointListCustom.cpp: (WebCore::finishGetter): (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult): (WebCore::JSSVGPointList::clear): (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
  • bindings/js/JSSVGTransformListCustom.cpp: (WebCore::finishGetter): (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult): (WebCore::JSSVGTransformList::clear): (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::CSSFontSelector): (WebCore::CSSFontSelector::~CSSFontSelector):
  • css/CSSFontSelector.h: (WebCore::CSSFontSelector::create):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::applyProperty):
  • dom/Attribute.cpp: (WebCore::Attribute::clone):
  • dom/Attribute.h: (WebCore::Attribute::create): (WebCore::Attribute::Attribute):
  • dom/BeforeTextInsertedEvent.h: (WebCore::BeforeTextInsertedEvent::create):
  • dom/BeforeUnloadEvent.h: (WebCore::BeforeUnloadEvent::create):
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
  • dom/ClipboardEvent.cpp: (WebCore::ClipboardEvent::ClipboardEvent):
  • dom/ClipboardEvent.h: (WebCore::ClipboardEvent::create):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild): (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
  • dom/Document.cpp: (WebCore::Document::createTextNode): (WebCore::Document::createComment): (WebCore::Document::createCDATASection): (WebCore::Document::createProcessingInstruction): (WebCore::Document::createEntityReference): (WebCore::Document::createEditingTextNode): (WebCore::Document::createEvent): (WebCore::Document::createAttributeNS): (WebCore::Document::finishedParsing):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::createAttribute):
  • dom/Element.h:
  • dom/Event.cpp: (WebCore::Event::Event):
  • dom/Event.h: (WebCore::Event::create):
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent): (WebCore::EventTargetNode::dispatchWindowEvent): (WebCore::EventTargetNode::dispatchUIEvent): (WebCore::EventTargetNode::dispatchKeyEvent): (WebCore::EventTargetNode::dispatchMouseEvent): (WebCore::EventTargetNode::dispatchWheelEvent): (WebCore::EventTargetNode::dispatchHTMLEvent): (WebCore::EventTargetNode::dispatchProgressEvent): (WebCore::EventTargetNode::dispatchStorageEvent):
  • dom/KeyboardEvent.h: (WebCore::KeyboardEvent::create):
  • dom/MappedAttribute.cpp: (WebCore::MappedAttribute::clone):
  • dom/MappedAttribute.h: (WebCore::MappedAttribute::create): (WebCore::MappedAttribute::setDecl): (WebCore::MappedAttribute::MappedAttribute):
  • dom/MessageEvent.cpp: (WebCore::MessageEvent::MessageEvent):
  • dom/MessageEvent.h: (WebCore::MessageEvent::create):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent): (WebCore::MouseEvent::initMouseEvent):
  • dom/MouseEvent.h: (WebCore::MouseEvent::create):
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent):
  • dom/MouseRelatedEvent.h:
  • dom/MutationEvent.cpp: (WebCore::MutationEvent::MutationEvent): (WebCore::MutationEvent::initMutationEvent):
  • dom/MutationEvent.h: (WebCore::MutationEvent::create):
  • dom/OverflowEvent.h: (WebCore::OverflowEvent::create):
  • dom/ProgressEvent.h: (WebCore::ProgressEvent::create):
  • dom/StyledElement.cpp: (WebCore::StyledElement::getMappedAttributeDecl): (WebCore::StyledElement::setMappedAttributeDecl): (WebCore::StyledElement::removeMappedAttributeDecl): (WebCore::StyledElement::createAttribute):
  • dom/StyledElement.h:
  • dom/TextEvent.cpp: (WebCore::TextEvent::TextEvent): (WebCore::TextEvent::initTextEvent):
  • dom/TextEvent.h: (WebCore::TextEvent::create):
  • dom/UIEvent.cpp: (WebCore::UIEvent::UIEvent): (WebCore::UIEvent::initUIEvent):
  • dom/UIEvent.h: (WebCore::UIEvent::create):
  • dom/UIEventWithKeyState.h: (WebCore::UIEventWithKeyState::ctrlKey): (WebCore::UIEventWithKeyState::shiftKey): (WebCore::UIEventWithKeyState::altKey): (WebCore::UIEventWithKeyState::metaKey): (WebCore::UIEventWithKeyState::UIEventWithKeyState):
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): (WebCore::WheelEvent::initWheelEvent):
  • dom/WheelEvent.h: (WebCore::WheelEvent::create):
  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::AppendNodeCommand):
  • editing/AppendNodeCommand.h: (WebCore::AppendNodeCommand::create):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):
  • editing/ApplyStyleCommand.h: (WebCore::ApplyStyleCommand::create):
  • editing/BreakBlockquoteCommand.h: (WebCore::BreakBlockquoteCommand::create):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyle): (WebCore::CompositeEditCommand::applyStyledElement): (WebCore::CompositeEditCommand::removeStyledElement): (WebCore::CompositeEditCommand::insertParagraphSeparator): (WebCore::CompositeEditCommand::insertLineBreak): (WebCore::CompositeEditCommand::insertNodeBefore): (WebCore::CompositeEditCommand::appendNode): (WebCore::CompositeEditCommand::removeNode): (WebCore::CompositeEditCommand::removeNodePreservingChildren): (WebCore::CompositeEditCommand::splitTextNode): (WebCore::CompositeEditCommand::splitElement): (WebCore::CompositeEditCommand::mergeIdenticalElements): (WebCore::CompositeEditCommand::wrapContentsInDummySpan): (WebCore::CompositeEditCommand::splitTextNodeContainingElement): (WebCore::CompositeEditCommand::joinTextNodes): (WebCore::CompositeEditCommand::inputText): (WebCore::CompositeEditCommand::insertTextIntoNode): (WebCore::CompositeEditCommand::deleteTextFromNode): (WebCore::CompositeEditCommand::replaceTextInNode): (WebCore::CompositeEditCommand::deleteSelection): (WebCore::CompositeEditCommand::removeCSSProperty): (WebCore::CompositeEditCommand::removeNodeAttribute): (WebCore::CompositeEditCommand::setNodeAttribute): (WebCore::CompositeEditCommand::appendBlockPlaceholder): (WebCore::CompositeEditCommand::insertBlockPlaceholder): (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::splitTreeToNode):
  • editing/CompositeEditCommand.h: (WebCore::CompositeEditCommand::isFirstCommand):
  • editing/CreateLinkCommand.h: (WebCore::CreateLinkCommand::create):
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::deleteTarget):
  • editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
  • editing/DeleteFromTextNodeCommand.h: (WebCore::DeleteFromTextNodeCommand::create):
  • editing/DeleteSelectionCommand.h: (WebCore::DeleteSelectionCommand::create):
  • editing/EditCommand.h: (WebCore::SimpleEditCommand::SimpleEditCommand):
  • editing/Editor.cpp: (WebCore::Editor::deleteSelectionWithSmartDelete): (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::removeFormattingAndStyle): (WebCore::Editor::clearLastEditCommand): (WebCore::Editor::dispatchCPPEvent): (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle): (WebCore::Editor::indent): (WebCore::Editor::outdent): (WebCore::dispatchEditableContentChangedEvents):
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeInsertFragment): (WebCore::executeCreateLink): (WebCore::executeFormatBlock): (WebCore::executeIndent): (WebCore::executeInsertOrderedList): (WebCore::executeInsertUnorderedList): (WebCore::executeOutdent): (WebCore::executeUnlink):
  • editing/FormatBlockCommand.h: (WebCore::FormatBlockCommand::create):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/IndentOutdentCommand.h: (WebCore::IndentOutdentCommand::create):
  • editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
  • editing/InsertIntoTextNodeCommand.h: (WebCore::InsertIntoTextNodeCommand::create):
  • editing/InsertLineBreakCommand.h: (WebCore::InsertLineBreakCommand::create):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
  • editing/InsertListCommand.h: (WebCore::InsertListCommand::create):
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
  • editing/InsertNodeBeforeCommand.h: (WebCore::InsertNodeBeforeCommand::create):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.h: (WebCore::InsertParagraphSeparatorCommand::create):
  • editing/InsertTextCommand.h: (WebCore::InsertTextCommand::create):
  • editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::JoinTextNodesCommand):
  • editing/JoinTextNodesCommand.h: (WebCore::JoinTextNodesCommand::create):
  • editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand):
  • editing/MergeIdenticalElementsCommand.h: (WebCore::MergeIdenticalElementsCommand::create):
  • editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType):
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):
  • editing/MoveSelectionCommand.h: (WebCore::MoveSelectionCommand::create):
  • editing/RemoveCSSPropertyCommand.cpp: (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
  • editing/RemoveCSSPropertyCommand.h: (WebCore::RemoveCSSPropertyCommand::create):
  • editing/RemoveFormatCommand.h: (WebCore::RemoveFormatCommand::create):
  • editing/RemoveNodeAttributeCommand.cpp: (WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
  • editing/RemoveNodeAttributeCommand.h: (WebCore::RemoveNodeAttributeCommand::create):
  • editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::RemoveNodeCommand):
  • editing/RemoveNodeCommand.h: (WebCore::RemoveNodeCommand::create):
  • editing/RemoveNodePreservingChildrenCommand.cpp: (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): (WebCore::RemoveNodePreservingChildrenCommand::doApply):
  • editing/RemoveNodePreservingChildrenCommand.h: (WebCore::RemoveNodePreservingChildrenCommand::create):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::): (WebCore::ReplacementFragment::hasInterchangeNewlineAtStart): (WebCore::ReplacementFragment::hasInterchangeNewlineAtEnd): (WebCore::ReplacementFragment::ReplacementFragment):
  • editing/ReplaceSelectionCommand.h: (WebCore::ReplaceSelectionCommand::create):
  • editing/SetNodeAttributeCommand.cpp: (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand):
  • editing/SetNodeAttributeCommand.h: (WebCore::SetNodeAttributeCommand::create):
  • editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::SplitElementCommand):
  • editing/SplitElementCommand.h: (WebCore::SplitElementCommand::create):
  • editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::SplitTextNodeCommand):
  • editing/SplitTextNodeCommand.h: (WebCore::SplitTextNodeCommand::create):
  • editing/SplitTextNodeContainingElementCommand.cpp: (WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
  • editing/SplitTextNodeContainingElementCommand.h: (WebCore::SplitTextNodeContainingElementCommand::create):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteSelection): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): (WebCore::TypingCommand::insertParagraphSeparator): (WebCore::TypingCommand::insertTextRunWithoutNewlines):
  • editing/TypingCommand.h: (WebCore::TypingCommand::create): (WebCore::TypingCommand::smartDelete):
  • editing/UnlinkCommand.h: (WebCore::UnlinkCommand::create):
  • editing/WrapContentsInDummySpanCommand.cpp: (WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand):
  • editing/WrapContentsInDummySpanCommand.h: (WebCore::WrapContentsInDummySpanCommand::create):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::additionalAttributeStyleDecls): (WebCore::HTMLTableElement::addSharedCellBordersDecl): (WebCore::HTMLTableElement::addSharedCellPaddingDecl): (WebCore::HTMLTableElement::addSharedGroupDecls):
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addLink):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL):
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::callListener):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/DOMWindow.cpp: (WebCore::PostMessageTimer::PostMessageTimer): (WebCore::PostMessageTimer::fired): (WebCore::DOMWindow::postMessage):
  • page/DragController.cpp: (WebCore::DragController::concludeDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::handleTextInputEvent):
  • page/Frame.cpp: (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::shouldClose):
  • page/FrameView.cpp: (WebCore::FrameView::updateOverflowStatus):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::currentKeyboardEvent):
  • page/mac/FrameMac.mm:
  • platform/DeprecatedValueListImpl.cpp: (WebCore::DeprecatedValueListImpl::Private::Private): (WebCore::DeprecatedValueListImpl::DeprecatedValueListImpl): (WebCore::DeprecatedValueListImpl::copyOnWrite):
  • platform/graphics/FontSelector.h:
  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
  • platform/graphics/GlyphPageTreeNode.h: (WebCore::GlyphPage::create): (WebCore::GlyphPage::GlyphPage):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::updateOverflowStatus): (WebCore::RenderLayer::updateReflectionStyle):
  • rendering/style/RenderStyle.h: (WebCore::TransformOperation::~TransformOperation): (WebCore::ScaleTransformOperation::create): (WebCore::ScaleTransformOperation::ScaleTransformOperation): (WebCore::RotateTransformOperation::create): (WebCore::RotateTransformOperation::RotateTransformOperation): (WebCore::SkewTransformOperation::create): (WebCore::SkewTransformOperation::operator==): (WebCore::SkewTransformOperation::SkewTransformOperation): (WebCore::TranslateTransformOperation::create): (WebCore::TranslateTransformOperation::operator==): (WebCore::TranslateTransformOperation::TranslateTransformOperation): (WebCore::MatrixTransformOperation::create): (WebCore::MatrixTransformOperation::MatrixTransformOperation): (WebCore::StyleReflection::create): (WebCore::StyleReflection::StyleReflection):
  • storage/StorageEvent.cpp: (WebCore::StorageEvent::StorageEvent): (WebCore::StorageEvent::initStorageEvent):
  • storage/StorageEvent.h: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent):
  • svg/SVGAngle.cpp: (WebCore::SVGAngle::SVGAngle):
  • svg/SVGAngle.h: (WebCore::SVGAngle::create):
  • svg/SVGAnimatedTemplate.h: (WebCore::SVGAnimatedTemplate::SVGAnimatedTemplate): (WebCore::lookupOrCreateWrapper):
  • svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible):
  • svg/SVGElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::setOrientToAngle):
  • svg/SVGMarkerElement.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGAngle):
  • svg/SVGSVGElement.h:
  • svg/SVGZoomEvent.h: (WebCore::SVGZoomEvent::create):
  • svg/graphics/SVGImage.cpp:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): (WebCore::XMLHttpRequest::dispatchProgressEvent):
  • xml/XMLHttpRequestProgressEvent.cpp:
  • xml/XMLHttpRequestProgressEvent.h: (WebCore::XMLHttpRequestProgressEvent::create): (WebCore::XMLHttpRequestProgressEvent::position): (WebCore::XMLHttpRequestProgressEvent::totalSize): (WebCore::XMLHttpRequestProgressEvent::XMLHttpRequestProgressEvent):

WebKit/mac:

2008-06-14 Darin Adler <Darin Adler>

Reviewed by Sam.

  • WebView/WebFrame.mm: (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
12:52 AM Changeset in webkit [34535] by cwzwarich@webkit.org
  • 7 edits in trunk

2008-06-14 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19484: More instructions needs to use temporary registers
<​https://bugs.webkit.org/show_bug.cgi?id=19484>

Make code generation for AddNode and SubNode use temporaries when
necessary.

JavaScriptCore:

  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::AddNode::emitCode): (KJS::SubNode::emitCode):
  • kjs/nodes.h: (KJS::AddNode::): (KJS::SubNode::):

LayoutTests:

  • fast/js/codegen-temporaries-expected.txt:
  • fast/js/resources/codegen-temporaries.js:

Jun 13, 2008:

10:40 PM Changeset in webkit [34534] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

WebCore:

2008-06-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=19199

Prevent external entities from loading across origins.

Test: http/tests/security/xss-DENIED-xsl-external-entity.xml

  • dom/XMLTokenizer.cpp: (WebCore::shouldAllowExternalLoad): (WebCore::openFunc):

LayoutTests:

2008-06-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Test that an XSL style sheet can't include an external entity from
another origin.

  • http/tests/security/resources/xsl-using-external-entity.xsl: Added.
  • http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
  • http/tests/security/xss-DENIED-xsl-external-entity.xml: Added.
10:40 PM Changeset in webkit [34533] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

WebCore:

2008-06-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=19450

Allow loads of same-origin documents only.

Test: http/tests/security/xss-DENIED-xsl-document.xml

  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):

LayoutTests:

2008-06-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Test that the XSL document() function doesn't load a document from a
foreign origin.

  • http/tests/security/resources/target.xml: Added.
  • http/tests/security/resources/xsl-using-document.xsl: Added.
  • http/tests/security/xss-DENIED-xsl-document-expected.txt: Added.
  • http/tests/security/xss-DENIED-xsl-document.xml: Added.
10:39 PM Changeset in webkit [34532] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2008-06-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Fixes <​https://bugs.webkit.org/show_bug.cgi?id=15100>:

XMLHttpRequest::urlMatchesDocumentDomain raises error if port
information does not match exactly

Refactor our security check for XMLHttpRequest into SecurityOrigin so
we can reuse it in other places. This leverages our default port
technology in SecurityOrigin.

I wasn't sure how to write a test for this because the LayoutTests run
on non-default ports.

  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canRequest):
  • platform/SecurityOrigin.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::willSendRequest):
  • xml/XMLHttpRequest.h:
10:39 PM Changeset in webkit [34531] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2008-06-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Test whether we permit XMLHttpRequest once document.domain is set.

  • http/tests/xmlhttprequest/document-domain-set-expected.txt: Added.
  • http/tests/xmlhttprequest/document-domain-set.html: Added.
10:39 PM Changeset in webkit [34530] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2008-06-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Removed unnecessary dependencies.

  • platform/SecurityOrigin.cpp:
  • platform/SecurityOrigin.h:
10:06 PM Changeset in webkit [34529] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-06-13 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Combine TrueNode and FalseNode to make BooleanNode, and remove the
unused class PlaceholderTrueNode.

  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::BooleanNode::emitCode):
  • kjs/nodes.h: (KJS::BooleanNode::): (KJS::BooleanNode::precedence):
  • kjs/nodes2string.cpp: (KJS::BooleanNode::streamTo):
9:40 PM Changeset in webkit [34528] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-06-13 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Eliminate the use of temporaries to store the left hand side of an
expression when the right hand side is a constant. This slightly
improves the generated bytecode for a few SunSpider tests, but it is
mostly in preparation for fixing

Bug 19484: More instructions needs to use temporary registers
<​https://bugs.webkit.org/show_bug.cgi?id=19484>

  • VM/CodeGenerator.h: (KJS::CodeGenerator::leftHandSideNeedsCopy): (KJS::CodeGenerator::emitNodeForLeftHandSide):
  • kjs/nodes.cpp: (KJS::BracketAccessorNode::emitCode): (KJS::ReadModifyResolveNode::emitCode): (KJS::AssignDotNode::emitCode): (KJS::ReadModifyDotNode::emitCode): (KJS::AssignBracketNode::emitCode): (KJS::ReadModifyBracketNode::emitCode):
  • kjs/nodes.h: (KJS::ExpressionNode::): (KJS::FalseNode::): (KJS::TrueNode::): (KJS::NumberNode::): (KJS::StringNode::):
9:12 PM Changeset in webkit [34527] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • prettify opcode stats output


I changed things to be a bit more aligned, also there is a new
section listing most common opcodes and most common sequences that
include them.

  • VM/Opcode.cpp: (KJS::): (KJS::OpcodeStats::~OpcodeStats):
  • VM/Opcode.h:
4:35 PM Changeset in webkit [34526] by Darin Adler
  • 6 edits in trunk/WebKit

WebKit/gtk:

2008-06-13 Darin Adler <Darin Adler>

  • try to fix build
  • WebCoreSupport/FrameLoaderClientGtk.h: Add missing argument.

WebKit/qt:

2008-06-13 Darin Adler <Darin Adler>

  • try to fix build
  • WebCoreSupport/FrameLoaderClientQt.h: Add missing argument.

WebKit/wx:

2008-06-13 Darin Adler <Darin Adler>

  • try to fix build
  • WebKitSupport/FrameLoaderClientWx.h: Add missing argument.
3:32 PM Changeset in webkit [34525] by cwzwarich@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2008-06-13 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Add a test for existing loader behaviour in preparation for:

Bug 19422: Distinct redirects from the same link do not create distinct history items
<​https://bugs.webkit.org/show_bug.cgi?id=19422>

  • http/tests/navigation/redirect-cycle-expected.txt: Added.
  • http/tests/navigation/redirect-cycle.html: Added.
  • http/tests/navigation/resources/redirect-cycle-1.pl: Added.
  • http/tests/navigation/resources/redirect-cycle-2.pl: Added.
3:05 PM Changeset in webkit [34524] by mjs@apple.com
  • 3 edits
    13 moves
    13 adds in trunk/LayoutTests

2008-06-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.



I also made a minor change to selftxhtml.js to handle the case
where the body is a frameset properly, and to frame.xhtml to match
the HTML version of that file, and what the tests expect.

  • dom/html/level2/html/HTMLFormElement10-expected.txt: Added.
  • dom/html/level2/html/HTMLFormElement10.html: Copied from dom/html/level2/html/HTMLFormElement10.html-disabled.
  • dom/html/level2/html/HTMLFormElement10.html-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFormElement10-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFormElement10.xhtml: Copied from dom/xhtml/level2/html/HTMLFormElement10.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFormElement10.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement01-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement01.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement01.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement01.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement02-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement02.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement02.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement02.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement03-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement03.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement03.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement03.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement04-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement04.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement04.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement04.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement05-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement05.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement05.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement05.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement06-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement06.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement06.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement06.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement07-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement07.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement07.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement07.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement08-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement08.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement08.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement08.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameElement09-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameElement09.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameSetElement01-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameSetElement01.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameSetElement01.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameSetElement01.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/HTMLFrameSetElement02-expected.txt: Added.
  • dom/xhtml/level2/html/HTMLFrameSetElement02.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameSetElement02.xhtml-disabled.
  • dom/xhtml/level2/html/HTMLFrameSetElement02.xhtml-disabled: Removed.
  • dom/xhtml/level2/html/resources/frame.xhtml:
  • dom/xhtml/level2/html/selfxhtml.js:
2:47 PM Changeset in webkit [34523] by Darin Adler
  • 21 edits in trunk

WebCore:

2008-06-13 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • added FormState argument to action policy functions
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::checkNavigationPolicy):
  • loader/FrameLoaderClient.h:
  • svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKit/gtk:

2008-06-13 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • updated for addition of FormState argument to action policy functions
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKit/mac:

2008-06-13 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • updated for addition of FormState argument to action policy functions
  • added WebActionFormKey
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::actionDictionary):
  • WebKit.exp:
  • WebView/WebPolicyDelegate.mm:
  • WebView/WebPolicyDelegatePrivate.h:

WebKit/qt:

2008-06-13 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • updated for addition of FormState argument to action policy functions
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

WebKit/win:

2008-06-13 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • updated for addition of FormState argument to action policy functions
  • added WebActionFormKey
  • Interfaces/IWebPolicyDelegate.idl:
  • WebActionPropertyBag.cpp: (WebActionPropertyBag::WebActionPropertyBag): (WebActionPropertyBag::createInstance): (WebActionPropertyBag::AddRef): (WebActionPropertyBag::Release): (WebActionPropertyBag::Read):
  • WebActionPropertyBag.h:
  • WebFrame.cpp: (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction):

WebKit/wx:

2008-06-13 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • updated for addition of FormState argument to action policy functions
  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):
11:23 AM Changeset in webkit [34522] by Darin Adler
  • 2 edits in trunk/WebKitTools

2008-06-13 Darin Adler <Darin Adler>

  • Scripts/make-js-test-wrappers: Added three more exceptions.
10:45 AM Changeset in webkit [34521] by kmccullough@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-06-13 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
profiler.

  • Remove recursion from exclude(). This leaves only focus() to fix.
  • JavaScriptCore.exp: Change the signatures of the exported functions.
  • profiler/Profile.cpp: (KJS::Profile::forEach): I added a traverseNextNodePreOrder() function and so needed to distinguish the other function by labeling it traverseNextNodePostOrder(). (KJS::Profile::exclude): All new exclude that iteratively walks the tree
  • profiler/Profile.h: (KJS::Profile::focus): Add a null check for m_head.
  • profiler/ProfileNode.cpp: (KJS::ProfileNode::traverseNextNodePostOrder): Renamed (KJS::ProfileNode::traverseNextNodePreOrder): Walks the tree in pre- order, where the parent is processed before the children. (KJS::ProfileNode::setTreeVisible): Iterate over the sub-tree and set all of the nodes visible value. This changes another function that used recursion. (KJS::ProfileNode::exclude): Remove recursion from this function. Because we now check for m_visible and we are walking the tree in pre- order we do not need to check if an excluded node is in an excluded sub-tree.
  • profiler/ProfileNode.h: Added specific selfTime functions to facilitate exclude(). (KJS::ProfileNode::setSelfTime): (KJS::ProfileNode::setActualSelfTime): (KJS::ProfileNode::setVisibleSelfTime):
10:42 AM Changeset in webkit [34520] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

2008-06-13 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Jess.

<rdar://problem/5702248> Crash on Copy Image from the contextual menu on a broken image in Mail

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Check to see the image loaded successfully before trying to put data for it on the Pasteboard. Mail shouldn't really include the Copy Image menu item, but if it does and the user selects it, we shouldn't crash.
5:51 AM Changeset in webkit [34519] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-06-11 Marc Ordinas i Llopis <​marc.ordinasillopis@collabora.co.uk>

With help from Siraj Razick <​siraj.razick@collabora.co.uk>

Reviewed by Simon.

​https://bugs.webkit.org/show_bug.cgi?id=19367
[Qt] Plugins are drawn over the scrollbars

1:22 AM WebDevelopers edited by cwzwarich@webkit.org
(diff)

Jun 12, 2008:

9:53 PM Changeset in webkit [34518] by Darin Adler
  • 12 edits in trunk/JavaScriptCore

2008-06-12 Darin Adler <Darin Adler>

Reviewed by Maciej.

Speeds up SunSpider by 1.1%.

Optimized code path for getting built-in properties from strings -- avoid
boxing with a string object in that case. We can make further changes to avoid
even more boxing, but this change alone is a win.

  • API/JSCallbackObjectFunctions.h: (KJS::JSCallbackObject::staticValueGetter): Use isObject instead of inherits in asssert, since the type of slotBase() is now JSValue, not JSObject. (KJS::JSCallbackObject::staticFunctionGetter): Ditto. (KJS::JSCallbackObject::callbackGetter): Ditto.
  • kjs/internal.cpp: (KJS::StringImp::getPrimitiveNumber): Updated for change of data member name. (KJS::StringImp::toBoolean): Ditto. (KJS::StringImp::toNumber): Ditto. (KJS::StringImp::toString): Ditto. (KJS::StringInstance::create): Added; avoids a bit of cut and paste code. (KJS::StringImp::toObject): Use StringInstance::create. (KJS::StringImp::toThisObject): Ditto. (KJS::StringImp::lengthGetter): Added. Replaces the getter that used to live in the StringInstance class. (KJS::StringImp::indexGetter): Ditto. (KJS::StringImp::indexNumericPropertyGetter): Ditto. (KJS::StringImp::getOwnPropertySlot): Added. Deals with built in properties of the string class without creating a StringInstance.
  • kjs/internal.h: (KJS::StringImp::getStringPropertySlot): Added. To be used by both the string and string object getOwnPropertySlot function.
  • kjs/lookup.h: (KJS::staticFunctionGetter): Updated since slotBase() is now a JSValue rather than a JSObject.
  • kjs/object.h: Removed PropertySlot::slotBase() function, which can now move back into property_slot.h where it belongs since it doesn't have to cast to JSObject*.
  • kjs/property_slot.cpp: (KJS::PropertySlot::functionGetter): Updated since slot.slotBase() is now a JSValue* instead of JSObject*. setGetterSlot still guarantees the base is a JSObject*.
  • kjs/property_slot.h: (KJS::PropertySlot::PropertySlot): Changed base to JSValue* intead of JSCell*. (KJS::PropertySlot::setStaticEntry): Ditto. (KJS::PropertySlot::setCustom): Ditto. (KJS::PropertySlot::setCustomIndex): Ditto. (KJS::PropertySlot::setCustomNumeric): Ditto. (KJS::PropertySlot::slotBase): Moved inline here since it no longer involves a downcast to JSObject*. (KJS::PropertySlot::setBase): Changed to JSValue*.
  • kjs/string_object.cpp: (KJS::StringInstance::getOwnPropertySlot): Changed to use getStringPropertySlot instead of coding the properties here. This allows sharing the code with StringImp.
  • kjs/string_object.h: Removed inlineGetOwnPropertySlot, lengthGetter, and indexGetter. Made one of the constructors protected.
  • kjs/value.h: Made getOwnPropertySlot private in the JSCell class -- this is better since it's not the real JSObject getOwnPropertySlot semantic and most callers shouldn't use it.
9:19 PM Changeset in webkit [34517] by sullivan@apple.com
  • 3 edits in trunk/WebKit/mac

2008-06-12 John Sullivan <​sullivan@apple.com>

Reviewed by Dan and Darin

Clear up the confusion about _close (older private method) vs -close (newer public method).

  • WebView/WebView.mm: (-[WebView _isClosed]): simplified style (-[WebView _close]): added a comment about how clients and subclasses should use -close instead (-[WebView dealloc]): call -close instead of _close, so subclasses that override the public method will have the intended behavior (-[WebView close]): added a comment (-[WebView _windowWillClose:]): call -close instead of _close, so subclasses that override the public method will have the intended behavior
  • WebView/WebViewPrivate.h: added a comment about how clients and subclasses should use -close instead
8:28 PM Changeset in webkit [34516] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-12 Darin Adler <Darin Adler>

  • try to fix no-SVG build
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a case for CSSPropertyWebkitMask.
8:10 PM Changeset in webkit [34515] by Darin Adler
  • 2 edits in trunk/WebCore

2008-06-12 Darin Adler <Darin Adler>

  • try to fix Windows build
  • dom/Element.idl: Turn off ElementTraversal functions when generating COM. Not sure why they're failing, but turning them off for now seems OK.
7:34 AM Changeset in webkit [34514] by ap@webkit.org
  • 6 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Preparation to making JavaScript heap per-thread.

  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/collector.h: (KJS::Collector::markListSet): The collector now holds the list of protected lists itself, to be made per-instance.
  • kjs/list.h: Changed to hold a pointer to a mark set this list is in, if any. (KJS::List::List): Explicitly initialize m_size with zero, as m_vector.size() is guaranteed to be such anyway. (KJS::List::append): Changed the fast case to only be executed as long as inline buffer is used, because otherwise, we now do more expensive checks.
  • kjs/list.cpp: (KJS::List::markLists): Renamed from markProtectedListsSlowCase, made it take the list set as a parameter. (KJS::List::slowAppend): If a non-immediate value is appended, the list needs to be added to an appropriate Heap's protected list. For now, a static Collector::markListSet() is used, but the code is layed out in preparation to making the switch to multiple heaps.
5:52 AM Disk Cache edited by ben@meyerhome.net
(diff)
3:40 AM Changeset in webkit [34513] by abarth@webkit.org
  • 4 edits
    2 copies in trunk

WebCore:

2008-06-12 Adam Barth <​abarth@webkit.org>

Rubberstamped by Maciej.

Roll 34504 back in.

Test: http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html

  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):

LayoutTests:

2008-06-12 Adam Barth <​abarth@webkit.org>

Rubberstamped by Maciej.

Add the data url test back and set more agressive Cache-Control headers.

  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt.
  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html.
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
3:02 AM Changeset in webkit [34512] by abarth@webkit.org
  • 2 deletes in trunk/LayoutTests/http/tests/xmlhttprequest

Continue backout of 34504.

2:35 AM Changeset in webkit [34511] by abarth@webkit.org
  • 1 edit in trunk/WebCore/platform/SecurityOrigin.cpp

Partial backout of 34504. I know this will regress the *-data-url.html test, but I'd like to see if it fixes the broken test.

2:03 AM Changeset in webkit [34510] by cwzwarich@webkit.org
  • 3 edits
    4 adds in trunk

2008-06-12 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Bug 19510: CodeBlock::needsFullScopeChain not always set for global code
<​https://bugs.webkit.org/show_bug.cgi?id=19510>

This fixes the symptoms by using CodeGenerator::m_codeType to determine
when to use temporaries instead of CodeBlock::needsFullScopeChain, but
it does not fix the problem itself.

JavaScriptCore:

  • VM/CodeGenerator.h: (KJS::CodeGenerator::leftHandSideNeedsCopy):

LayoutTests:

  • fast/js/codegen-temporaries-multiple-global-blocks-expected.txt: Added.
  • fast/js/codegen-temporaries-multiple-global-blocks.html: Added.
  • fast/js/resources/codegen-temporaries-multiple-global-blocks-1.js: Added.
  • fast/js/resources/codegen-temporaries-multiple-global-blocks-2.js: Added.
2:00 AM Changeset in webkit [34509] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2008-06-12 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej.

Prevent caching of this resource so we always see the up-to-date value
of the Access-Control-Origin header.

  • http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:

Jun 11, 2008:

11:52 PM Changeset in webkit [34508] by mitz@apple.com
  • 2 edits in trunk

Reverting changes I accidently made in r34507.

11:44 PM Changeset in webkit [34507] by mitz@apple.com
  • 33 edits
    6 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Tests: fast/parser/p-in-scope-strict.html

fast/parser/p-in-scope.html

  • html/HTMLParagraphElement.h: (WebCore::HTMLParagraphElement::endTagRequirement): Changed to require an end tag. The explicit closing of one P element by another is now done in error checking, and therefore takes scope into account, allowing for <p><button><p>, for example.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): Initialize m_hasPElementInScope. (WebCore::isScopingTag): Added. Returns whether the given tag represents a scoping element as defined in HTML 5 section 8.2.3.2. (WebCore::HTMLParser::formCreateErrorCheck): Added a call to pCloserCreateErrorCheck(). (WebCore::HTMLParser::ddCreateErrorCheck): Ditto. (WebCore::HTMLParser::dtCreateErrorCheck): Ditto. (WebCore::HTMLParser::nestedPCloserCreateErrorCheck): Added for use with <li>, which both closes P elements in scope and any previous LI. (WebCore::HTMLParser::pCloserCreateErrorCheck): Added. If there is a P element in scope, acts as if a </p> tag was seen. (WebCore::HTMLParser::pCloserStrictCreateErrorCheck): Ditto, but only in strict mode. Used for <table>. (WebCore::HTMLParser::getNode): Added entries for tags that close a P element in scope. (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added code to reset m_hasPElementInScope. (WebCore::HTMLParser::pushBlock): Added code to update m_hasPElementInScope. (WebCore::HTMLParser::popOneBlockCommon): Ditto. (WebCore::HTMLParser::checkIfHasPElementInScope): Added. Updates m_hasPElementInScope.
  • html/HTMLParser.h: (WebCore::HTMLParser::hasPElementInScope): Added. Calls checkIfHasPElementInScope() if needed and returns whether there is a P element in scope.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/block/basic/001.html:
  • fast/block/positioning/absolute-in-inline-ltr-2.html:
  • fast/block/positioning/absolute-in-inline-ltr-3.html:
  • fast/block/positioning/absolute-in-inline-ltr.html:
  • fast/block/positioning/absolute-in-inline-rtl-2.html:
  • fast/block/positioning/absolute-in-inline-rtl-3.html:
  • fast/block/positioning/absolute-in-inline-rtl.html:
  • fast/block/positioning/absolute-in-inline-short-ltr.html:
  • fast/block/positioning/absolute-in-inline-short-rtl.html:
  • fast/block/positioning/auto/006.html:
  • fast/inline/continuation-outlines-with-layers.html:
  • fast/inline/continuation-outlines.html:
  • fast/parser/p-in-scope-expected.txt: Added.
  • fast/parser/p-in-scope-strict-expected.txt: Added.
  • fast/parser/p-in-scope-strict.html: Added.
  • fast/parser/p-in-scope.html: Added.
  • fast/parser/resources/p-in-scope.css: Added.
  • fast/parser/resources/p-in-scope.js: Added.
  • fast/repaint/subtree-root-clip-2.html:
  • platform/mac/fast/block/basic/001-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-ltr-2-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-ltr-3-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-ltr-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-rtl-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-short-ltr-expected.txt:
  • platform/mac/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
  • platform/mac/fast/block/positioning/auto/006-expected.txt:
  • platform/mac/fast/inline/continuation-outlines-expected.txt:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
  • platform/mac/fast/repaint/subtree-root-clip-2-expected.txt:
11:41 PM Changeset in webkit [34506] by abarth@webkit.org
  • 8 edits
    20 adds in trunk

WebCore:

008-06-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=19460

Update the security context of a document after calling document.open
or document.write. Basically, when a script open()s a document, the
document gains the security context of the script. Our implementation
now matches Firefox 3 on all these tests.

Tests: http/tests/security/aboutBlank/security-context-alias.html

http/tests/security/aboutBlank/security-context-grandchildren-alias.html
http/tests/security/aboutBlank/security-context-grandchildren.html
http/tests/security/aboutBlank/security-context-window-open.html
http/tests/security/aboutBlank/security-context-with-base-tag.html
http/tests/security/aboutBlank/security-context-write.html
http/tests/security/aboutBlank/security-context-writeln.html
http/tests/security/aboutBlank/security-context.html
http/tests/security/cookies/document-open.html

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln):
  • dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::write): (WebCore::Document::writeln):
  • dom/Document.h:

LayoutTests:

008-06-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Tests for the security context of about:blank documents. These test
results all match Firefox 3.

  • fast/dom/resource-locations-in-created-html-document.html:
  • http/tests/security/aboutBlank/resources/iframe-with-about-blank-children.html: Added.
  • http/tests/security/aboutBlank/security-context-alias-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-alias.html: Added.
  • http/tests/security/aboutBlank/security-context-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-alias-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-alias.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren.html: Added.
  • http/tests/security/aboutBlank/security-context-window-open-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-window-open.html: Added.
  • http/tests/security/aboutBlank/security-context-with-base-tag-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-with-base-tag.html: Added.
  • http/tests/security/aboutBlank/security-context-write-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-write.html: Added.
  • http/tests/security/aboutBlank/security-context-writeln-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-writeln.html: Added.
  • http/tests/security/aboutBlank/security-context.html: Added.
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • http/tests/security/cookies/document-open-expected.txt: Added.
  • http/tests/security/cookies/document-open.html: Added.
11:41 PM Changeset in webkit [34505] by abarth@webkit.org
  • 7 edits
    5 adds in trunk

WebCore:

2008-06-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=19460

Compute the cookie context at the same time as the SecurityOrigin.

Tests: http/tests/security/cookies/create-document.html

http/tests/security/cookies/xmlhttprequest.html

  • dom/Document.cpp: (WebCore::Document::cookie): (WebCore::Document::initSecurityOrigin):
  • dom/Document.h:
  • platform/SecurityOrigin.cpp:
  • platform/SecurityOrigin.h:

LayoutTests:

2008-06-11 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=19460

Test esoteric cookie contexts.

  • http/tests/security/cookies/create-document-expected.txt: Added.
  • http/tests/security/cookies/create-document.html: Added.
  • http/tests/security/cookies/resources/simple.xml: Added.
  • http/tests/security/cookies/xmlhttprequest-expected.txt: Added.
  • http/tests/security/cookies/xmlhttprequest.html: Added.
10:15 PM Changeset in webkit [34504] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

WebCore:

2008-06-11 Adam Barth <​abarth@webkit.org>

Reviewed and tweaked by Sam Weinig.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19242
Data URLs should set an Access-Control-Origin of "null"

Correctly generate "null" as the value of the Access-Control-Origin
header for cross-site XMLHttpRequests for data URLs.

Test: http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html

  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlOrigin): (WebCore::XMLHttpRequest::crossSiteAccessRequest): (WebCore::XMLHttpRequest::handleAsynchronousMethodCheckResult):
  • xml/XMLHttpRequest.h:

LayoutTests:

2008-06-11 Adam Barth <​abarth@webkit.org>

Reviewed and tweaked by Sam Weinig.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=19242
Data URLs should set an Access-Control-Origin of "null"

Test that we correctly generate "null" as the value for the
Access-Control-Origin header when making requests from a data URL.

  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
7:51 PM Changeset in webkit [34503] by weinig@apple.com
  • 1 edit in trunk/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt

Add missing newline

7:26 PM Changeset in webkit [34502] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2008-06-11 Sam Weinig <​sam@webkit.org>

Update results on non-leopard platforms to fix the buildbot.

  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
7:19 PM Changeset in webkit [34501] by weinig@apple.com
  • 1 edit in trunk/LayoutTests/http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi

Set executable bit

5:33 PM Changeset in webkit [34500] by cwzwarich@webkit.org
  • 5 edits
    3 adds in trunk

2008-06-11 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Bug 19498: REGRESSION (r34497): crash while loading GMail
<​https://bugs.webkit.org/show_bug.cgi?id=19498>

JavaScriptCore:

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrueOptimized): (KJS::CodeGenerator::emitJumpIfTrue):
  • VM/CodeGenerator.h:
  • kjs/nodes.cpp: (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::CaseBlockNode::emitCodeForBlock):

LayoutTests:

  • fast/js/logical-or-jless-expected.txt: Added.
  • fast/js/logical-or-jless.html: Added.
  • fast/js/resources/logical-or-jless.js: Added.
3:01 PM Changeset in webkit [34499] by Darin Adler
  • 8 edits in trunk/JavaScriptCore

2008-06-11 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • a little bit of cleanup and prep for some upcoming optimizations
  • JavaScriptCore.exp: Re-sorted this file (with sort command line tool).
  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump): Fixed printf to avoid warnings -- to use %lu we need to make sure the type is unsigned long.
  • kjs/object.cpp: (KJS::Error::create): Eliminated unused error names array, and also put the strings into the code since there was already a switch statment. This also avoids having to contemplate a hypothetical access past the end of the array.
  • kjs/object.h: Got rid of errorNames.
  • kjs/property_slot.cpp: Deleted unused ungettableGetter.
  • kjs/property_slot.h: Ditto.
  • wtf/AlwaysInline.h: Added LIKELY alongside UNLIKELY.
12:55 PM Changeset in webkit [34498] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2008-06-11 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

Add support for "*" wildcarding for Access-Control.

Test: http/tests/xmlhttprequest/access-control-basic-allow-star.html

  • xml/AccessItem.cpp: (WebCore::AccessItem::AccessItem): (WebCore::AccessItem::parseAccessItem): (WebCore::AccessItem::matches):

LayoutTests:

2008-06-11 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

Add basic test for "*" wildcarding for Access-Control.

  • http/tests/xmlhttprequest/access-control-basic-allow-star-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-star.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi: Added.
12:48 PM Changeset in webkit [34497] by cwzwarich@webkit.org
  • 7 edits in trunk/JavaScriptCore

2008-06-11 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 19457: Create fused opcodes for tests and conditional jumps
<​https://bugs.webkit.org/show_bug.cgi?id=19457>

Add a new jless instruction, and modify the code generator to emit it
instead of the pair (less, jtrue).

Gives a 3.6% improvement on SunSpider.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): (KJS::CodeGenerator::emitOpcode): (KJS::CodeGenerator::retrieveLastBinaryOp): (KJS::CodeGenerator::rewindBinaryOp): (KJS::CodeGenerator::emitJump): (KJS::CodeGenerator::emitJumpIfTrue): (KJS::CodeGenerator::emitJumpIfFalse): (KJS::CodeGenerator::emitMove): (KJS::CodeGenerator::emitNot): (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitStrictEqual): (KJS::CodeGenerator::emitNotStrictEqual): (KJS::CodeGenerator::emitLess): (KJS::CodeGenerator::emitLessEq): (KJS::CodeGenerator::emitPreInc): (KJS::CodeGenerator::emitPreDec): (KJS::CodeGenerator::emitPostInc): (KJS::CodeGenerator::emitPostDec): (KJS::CodeGenerator::emitToJSNumber): (KJS::CodeGenerator::emitNegate): (KJS::CodeGenerator::emitAdd): (KJS::CodeGenerator::emitMul): (KJS::CodeGenerator::emitDiv): (KJS::CodeGenerator::emitMod): (KJS::CodeGenerator::emitSub): (KJS::CodeGenerator::emitLeftShift): (KJS::CodeGenerator::emitRightShift): (KJS::CodeGenerator::emitUnsignedRightShift): (KJS::CodeGenerator::emitBitAnd): (KJS::CodeGenerator::emitBitXOr): (KJS::CodeGenerator::emitBitOr): (KJS::CodeGenerator::emitBitNot): (KJS::CodeGenerator::emitInstanceOf): (KJS::CodeGenerator::emitTypeOf): (KJS::CodeGenerator::emitIn): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitNewObject): (KJS::CodeGenerator::emitNewArray): (KJS::CodeGenerator::emitResolve): (KJS::CodeGenerator::emitGetScopedVar): (KJS::CodeGenerator::emitPutScopedVar): (KJS::CodeGenerator::emitResolveBase): (KJS::CodeGenerator::emitResolveWithBase): (KJS::CodeGenerator::emitResolveFunction): (KJS::CodeGenerator::emitGetById): (KJS::CodeGenerator::emitPutById): (KJS::CodeGenerator::emitPutGetter): (KJS::CodeGenerator::emitPutSetter): (KJS::CodeGenerator::emitDeleteById): (KJS::CodeGenerator::emitGetByVal): (KJS::CodeGenerator::emitPutByVal): (KJS::CodeGenerator::emitDeleteByVal): (KJS::CodeGenerator::emitPutByIndex): (KJS::CodeGenerator::emitNewFunction): (KJS::CodeGenerator::emitNewRegExp): (KJS::CodeGenerator::emitNewFunctionExpression): (KJS::CodeGenerator::emitCall): (KJS::CodeGenerator::emitReturn): (KJS::CodeGenerator::emitEnd): (KJS::CodeGenerator::emitConstruct): (KJS::CodeGenerator::emitPushScope): (KJS::CodeGenerator::emitPopScope): (KJS::CodeGenerator::emitDebugHook): (KJS::CodeGenerator::emitComplexJumpScopes): (KJS::CodeGenerator::emitJumpScopes): (KJS::CodeGenerator::emitNextPropertyName): (KJS::CodeGenerator::emitGetPropertyNames): (KJS::CodeGenerator::emitCatch): (KJS::CodeGenerator::emitThrow): (KJS::CodeGenerator::emitNewError): (KJS::CodeGenerator::emitJumpSubroutine): (KJS::CodeGenerator::emitSubroutineReturn):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.cpp: (KJS::):
  • VM/Opcode.h:
12:37 PM Changeset in webkit [34496] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

2008-06-11 Darin Adler <Darin Adler>

Reviewed by Alexey.

  • kjs/array_instance.cpp: (KJS::ArrayInstance::checkConsistency): Added. Empty inline version for when consistency checks are turned off. (KJS::ArrayInstance::ArrayInstance): Check consistency after construction. (KJS::ArrayInstance::~ArrayInstance): Check consistency before destruction. (KJS::ArrayInstance::put): Check consistency before and after. (KJS::ArrayInstance::deleteProperty): Ditto. (KJS::ArrayInstance::setLength): Ditto. (KJS::compareByStringPairForQSort): Use typedef for clarity. (KJS::ArrayInstance::sort): Check consistency before and after. Also broke the loop to set up sorting into two separate passes. Added FIXMEs about various exception safety issues. Added code to set m_numValuesInVector after sorting. (KJS::ArrayInstance::compactForSorting): Ditto.
  • kjs/array_instance.h: Added a definition of an enum for the types of consistency check and a declaration of the consistency checking function.
11:30 AM Changeset in webkit [34495] by justin.garcia@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2008-06-11 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Eric.

<​https://bugs.webkit.org/show_bug.cgi?id=19455>
Crash at RenderObject::childAt during JustifyCenter

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Added a FIXME.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): If we're removing a line break that consists of a single '\n' in a text node by itself, remove the whole text node instead of just emptying it out.
  • editing/Selection.cpp: (WebCore::Selection::validate): Added a FIXME about canonicalizing to positions that aren't candidates.
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): When the base and/or extent are about to be removed but the start and end aren't, change the base and extent to the start and end, but don't re-validate the selection, since doing so could move the start and end into the node that is about to be removed.

LayoutTests:

2008-06-11 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Eric.

<​https://bugs.webkit.org/show_bug.cgi?id=19455>
Crash at RenderObject::childAt during JustifyCenter

  • editing/execCommand/19455-expected.txt: Added.
  • editing/execCommand/19455.html: Added.
11:27 AM Changeset in webkit [34494] by Chris Fleizach
  • 2 edits in trunk/WebCore

<rdar://problem/5990049> AXTextMarker bytes getting messed up when getting AXTextMarkerRangeForUnorderedTextMarkersParameterizedAttribute

8:19 AM Changeset in webkit [34493] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-06-11 Adriaan de Groot <​groot@kde.org>

Reviewed by Simon.

Fix compilation with Sun Studio 12

It seems like the compiler instantiates a different template version. I.e.,
instead of parseUASheet<char [nnnn]>, it's probably instantiating
parseUASheet<char *>, which then passes 4 or 8 as the size value.

8:10 AM Changeset in webkit [34492] by Simon Hausmann
  • 3 edits in trunk/WebCore

Benjamin Meyer <​bmeyer@trolltech.com>

Fixed a crash when a slot connect to QWebPage::unsupportedContent would show a
modal dialog with an event loop.

We have a queued connection to various signals in the QNetworkReply, for which
it can happen that after releasing the QNetworkReply and disconnecting from it
a slot connected to one of the signals may still be called due to a posted
MetaCall event due to the queued connections. This patch removes the posted
events explicitly, fixes the coding style a bit and makes sure the same happens
when abort() is called.

8:10 AM Changeset in webkit [34491] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <​ariya.hidayat@trolltech.com>

Fix left-click and middle-click mouse event are not properly accepted.

When copying or pasting text using left or middle-click, the event must be
accepted so that it will not be potentially processed further by the parent
and/or sub-classed widget.

7:57 AM Disk Cache edited by ben@meyerhome.net
(diff)
7:56 AM Changeset in webkit [34490] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Ariya Hidayat <​ariya.hidayat@trolltech.com>

Fix input element does not accept character typed in using AltGr.

EditorClient is modified to catch AltGr and Ctrl+Alt key combination.
This fixes ​http://trolltech.com/developer/task-tracker/index_html?id=207050&method=entry

7:56 AM Disk Cache created by ben@meyerhome.net
Note: See TracTimeline for information about the timeline view.