Timeline



Jun 10, 2009:

10:31 PM Changeset in webkit [44602] by bfulgham@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-10 Brent Fulgham <​bfulgham@gmail.com>

Unreviewed build fix.
Reverted change to skip file, as Windows build is
still failing.

  • platform/win/Skipped:
9:59 PM Changeset in webkit [44601] by bfulgham@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

2009-06-05 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Eric Seidel.

Re-enable the video-zoom-controls test on Windows.

​https://bugs.webkit.org/show_bug.cgi?id=25465

  • platform/win/Skipped:
  • platform/win/media: Added.
  • platform/win/media/video-zoom-controls-expected.checksum: Added.
  • platform/win/media/video-zoom-controls-expected.png: Added.
  • platform/win/media/video-zoom-controls-expected.txt: Added.
9:44 PM Changeset in webkit [44600] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-10 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Jan Alonzo.

[gtk] Change DumpRenderTree to use a GtkScrolledWindow instead of GtkFixed

Change the code to use GtkScrolledWindow and resize the GtkScrolledWindow
to pass more tests. Make sure the content is bigger than a thumbnail.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): (main):
8:14 PM Changeset in webkit [44599] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-10 Gustavo Noronha Silva <Gustavo Noronha Silva>

Disabling new tests, and tests that use features of DRT we don't
currently implement.

  • platform/gtk/Skipped:
7:48 PM Changeset in webkit [44598] by kov@webkit.org
  • 6 edits
    1 add in trunk

2009-06-10 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

Add unit tests for our WebKitNetworkRequest object.

  • GNUmakefile.am:

WebKit/gtk

2009-06-10 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

Make WebKitNetworkRequest a proper GObject, making URI and
SoupMessage properties. Also adding unit tests for creation and
destruction.

  • tests/testnetworkrequest.c: Added. (test_network_request_create_destroy): (test_network_request_properties): (main):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_get_property): (webkit_network_request_set_property): (webkit_network_request_class_init): (webkit_network_request_init): (webkit_network_request_constructor): (webkit_network_request_new_with_core_request): (webkit_network_request_new): (webkit_network_request_set_uri): (webkit_network_request_get_uri):
  • webkit/webkitnetworkrequest.h:
5:31 PM Changeset in webkit [44597] by pkasting@chromium.org
  • 11 edits in trunk/WebCore

2009-06-10 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=25709 part six
Miscellaneous tiny changes. The important bits here are the ANSI C++
compliance fix in skia/ImageDecoders.h (needed to compile this file on
non-MSVC) and some behavioral fixes for the XBM decoder that Chromium
unit tests partly exposed. Other changes are mostly cosmetic.

  • platform/image-decoders/ImageDecoder.h: Make some variables private again. This will break QTWebKit but those guys have agreed to wait on my finishing the ImageDecoder changes.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
  • platform/image-decoders/skia/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP): Make more in line with other decoders' comments and structure, use a ref to decrease verbosity. (WebCore::BMPImageReader::processRLEData): Use a ref to decrease verbosity. (WebCore::BMPImageReader::processNonRLEData): Use a ref to decrease verbosity.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0). (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes): Fix ANSI violation that MSVC let me compile (!).
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
  • platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
  • platform/image-decoders/skia/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::frameBufferAtIndex): Return 0 for non-zero indexes, don't try to decode unnecessarily after failure or when the size couldn't be computed, make more in line with other decoders' comments and structure, call RGBA32Buffer::setRect() appropriately.
5:16 PM Changeset in webkit [44596] by bfulgham@webkit.org
  • 1 edit
    1 move
    2 adds
    1 delete in trunk/LayoutTests

2009-06-10 Brent Fulgham <​bfulgham@webkit.org>

Unreviewed build correction.

Clean up some stupid test mistakes, add pixel-level Mac tests
for the new zero-radius gradient test.

4:22 PM Changeset in webkit [44595] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Build correction for @r44574 (missing expected results).
See ​https://bugs.webkit.org/show_bug.cgi?id=26059.

3:47 PM Changeset in webkit [44594] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-06-10 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

Clear the frame name before we run each tests so we don't get
"someFloaString" or "3" in the target frame name.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
3:40 PM BuildingQtOnLinux edited by tonikitoo@gmail.com
(diff)
3:37 PM BuildingQtOnLinux edited by tonikitoo@gmail.com
(diff)
3:37 PM BuildingQtOnLinux edited by tonikitoo@gmail.com
(diff)
2:54 PM Changeset in webkit [44593] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

Fix collapsing empty shadow nodes in textareas.

1:55 PM Changeset in webkit [44592] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections

Implement atk_text_get_n_selections.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_n_selections):
1:37 PM Changeset in webkit [44591] by mitz@apple.com
  • 13 edits in trunk

WebCore:

Reviewed by Anders Carlsson.

  • fix <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a Google map in iPhoto Places, it drags a map tile instead

Calling stopLoadRequest() from notifyFinished() removed the
ScriptElementData from the CachedScript's client set, which could make
it eligible for purging. The fix is to call removeClient() only after
executing the script, which protects it from being purged while it is
in the document's queue of scripts to execute soon.

  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::execute): Call removeClient() here. (WebCore::ScriptElementData::notifyFinished): Instead of calling stopLoadRequest(), which calls removeClient(), just reset m_cachedScript.

WebKitTools:

Reviewed by Adele Peterson.

  • add a LayoutTestController method for temporarily changing the WebKit cache model
  • DumpRenderTree/LayoutTestController.cpp: (setCacheModelCallback): Added. Calls LayoutTestController::setCacheModel() with the first argument as an integer. (LayoutTestController::staticFunctions): Added setCacheModel.
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCacheModel):
  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): Reset the cache model to WebCacheModelDocumentBrowser.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setCacheModel): Added. Calls -[WebPreferences setCacheModel:].
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCacheModel):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setCacheModel):

LayoutTests:

Reviewed by Adele Peterson.

  • updated test to cover <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a Google map in iPhoto Places, it drags a map tile instead
  • fast/dom/HTMLScriptElement/nested-execution.html:
  • fast/dom/HTMLScriptElement/resources/nested-execution.js:
1:36 PM Changeset in webkit [44590] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Mark Rowe and Eric Seidel.

Update WebInspector localizedStrings.js with new resource tracking strings
​https://bugs.webkit.org/show_bug.cgi?id=26247

  • English.lproj/localizedStrings.js:
12:43 PM Changeset in webkit [44589] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.9

Tagging 1.1.9.

12:22 PM Changeset in webkit [44588] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android specific files.
​https://bugs.webkit.org/show_bug.cgi?id=26280

12:21 PM Changeset in webkit [44587] by bfulgham@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android specific file to WebCore/platform/android (part 9).
​https://bugs.webkit.org/show_bug.cgi?id=26266

12:19 PM Changeset in webkit [44586] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android platform specific files.
​https://bugs.webkit/org/show_bug.cgi?id=26265 (part 8).

12:18 PM Changeset in webkit [44585] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform. (part 6).
​https://bugs.webkit.org/show_bug.cgi?id=26264

12:11 PM Changeset in webkit [44584] by bfulgham@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 7).
​https://bugs.webkit.org/show_bug.cgi?id=23296

12:09 PM Changeset in webkit [44583] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 5).
​https://bugs.webkit.org/show_bug.cgi?id=23296

12:06 PM Changeset in webkit [44582] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 4).
​https://bugs.webkit.org/show_bug.cgi?id=23296

12:05 PM Changeset in webkit [44581] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 3).
​https://bugs.webkit.org/show_bug.cgi?id=23296

12:01 PM Changeset in webkit [44580] by bfulgham@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

009-06-10 Feng Qian <​feng@chromium.org>

Reviewed by Eric Seidel.

Add Android port files to WebCore/platform (part 2).
​https://bugs.webkit.org/show_bug.cgi?id=23296

11:46 AM Changeset in webkit [44579] by levin@chromium.org
  • 6 edits
    1 copy in trunk/WebCore

2009-06-10 Nate Chapin <​japhet@google.com>

Reviewed by David Levin.

Finish moving V8Custom from src.chromium.org to svn.webkit.org.

​https://bugs.webkit.org/show_bug.cgi?id=26258

  • bindings/v8/custom/V8CustomBinding.cpp: Finished upstreaming. (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp. (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::V8Custom::GetTargetFrame): Moved from v8_custom.cpp. (WebCore::V8Custom::DowncastSVGPathSeg): Moved from v8_custom.cpp.
  • bindings/v8/custom/V8CustomBinding.h: Finished upstreaming.
  • bindings/v8/custom/V8DatabaseCustom.cpp: Updated includes.
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Updated includes.
  • bindings/v8/custom/V8SQLTransactionCustom.cpp: Updated includes.
  • bindings/v8/custom/V8WebKitPointConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp.
11:21 AM Changeset in webkit [44578] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

2009-06-05 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by NOBODY (OOPS!).

​https://bugs.webkit.org/show_bug.cgi?id=26214
Bug 26214: RenderTextControl: Remove ASSERT for checking that visiblePositionForIndex()'s return is not null.

11:18 AM Changeset in webkit [44577] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-10 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

News for 1.1.9.

  • NEWS:
11:16 AM Changeset in webkit [44576] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-04 Roland Steiner <​rolandsteiner@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26197
Bug 26197: Incorrect variable initialization in PlatformContextSkia.cpp

11:04 AM Changeset in webkit [44575] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

2009-06-10 Dean McNamee <​deanm@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26061
Make sure filling a canvas pattern with an empty image doesn't crash.

10:57 AM Changeset in webkit [44574] by bfulgham@webkit.org
  • 4 edits
    1 add in trunk

Correct Bug #26059.
​https://bugs.webkit.org/show_bug.cgi?id=26059.

10:46 AM Changeset in webkit [44573] by pkasting@chromium.org
  • 5 edits in trunk/WebCore

2009-06-10 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=25709 part five
Rewrite users of ImageDecoder.h to use "safe" API calls, Skia side.
This tweaks the RGBA32Buffer interfaces to be implementable by Cairo as
well and modifies Skia's usage of those interfaces accordingly. Once a
similar change lands on the Cairo side, the Skia and Cairo decoders
should be identical except for the implementation of RGBA32Buffer.

  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() function.
  • platform/image-decoders/skia/BMPImageReader.cpp: (WebCore::BMPImageReader::processNonRLEData): Use new RGBA32Buffer::zeroFill() function.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow): Rewrite to use RGBA32Buffer::setRGBA(x, y, ...) calls as well as other RGBA32Buffer interface calls instead of knowing the underlying types inside the buffer; also try and add clarity.
  • platform/image-decoders/skia/ImageDecoder.h: Removed bitmap(), width(), and height(). (WebCore::RGBA32Buffer::zeroFill): Added. (WebCore::RGBA32Buffer::copyBitmapData): Avoid using bitmap(), which is going away. (WebCore::RGBA32Buffer::copyRowNTimes): Added. (WebCore::RGBA32Buffer::setSize): Use new zeroFill() function. (WebCore::RGBA32Buffer::asNewNativeImage): Added. (WebCore::RGBA32Buffer::setRGBA): Condensed two versions into one that takes coordinates instead of a raw pointer.
10:36 AM Changeset in webkit [44572] by xan@webkit.org
  • 2 edits in trunk

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Version bump in preparation for 1.1.9 release.

  • configure.ac:
10:27 AM Changeset in webkit [44571] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25671
[GTK] Implement support for set_caret_offset

Make an implementation that actually works.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_set_caret_offset):
10:26 AM Changeset in webkit [44570] by bfulgham@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-06-09 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

Clear the frame name before we run each tests so we don't get
"someFloaString" or "3" in the target frame name.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_clear_main_frame_name):
10:25 AM Changeset in webkit [44569] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-10 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26294

Make sure all member variables are initialized so that the default
assignment operator and copy constructors do not read uninitialized
memory.

  • platform/network/ResourceResponseBase.cpp:
10:18 AM Changeset in webkit [44568] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-06-10 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

Update main resource meta-data when resource tracking is disabled.

​https://bugs.webkit.org/show_bug.cgi?id=26253

  • inspector/InspectorController.cpp: (WebCore::InspectorController::getTrackedResource): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorController.h:
10:17 AM Changeset in webkit [44567] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections

Implement atk_text_get_selection.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_selection):
10:03 AM Changeset in webkit [44566] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not check if our parent class has the finalize method, it's
guaranteed to be there.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_finalize):
9:25 AM Changeset in webkit [44565] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Brent Fulgham <​bfulgham@webkit.org>

Build correct for Windows Cairo targets.

  • WebCore.vcproj/WebCore.vcproj: Disable warning 4611 (interaction between '_setjmp' and C++ object destruction is non-portable) for the two Cairo targets. This used to be disabled in a #pragma, but recent refactoring removed these lines.
9:20 AM Changeset in webkit [44564] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-06-10 Brent Fulgham <​bfulgham@webkit.org>

Build fix for Windows target.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Correct missing </File> tag after @r44550 that prevents the project from being loaded in the Visual Studio IDE.
9:06 AM QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
8:37 AM Changeset in webkit [44563] by Simon Hausmann
  • 4 edits in trunk/WebCore

2009-06-10 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Fix the build of PluginView on Qt with 64-bit where we disable plugins
at compile time.

Use the FooNone.cpp files at compile-time.

8:32 AM Changeset in webkit [44562] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-06-10 Simon Hausmann <​simon.hausmann@nokia.com>

Fix the Qt build.

ImageDecoderQt needs m_size and m_sizeAvailable to be protected.

8:21 AM Changeset in webkit [44561] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Use absolute path for install_name on Mac

7:48 AM Changeset in webkit [44560] by ariya@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-06-10 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

Documented ResolveRule and StylePriority enum values as well as their use in
QWebElement::styleProperty and QWebElement::setStyleProperty methods.

Based on the work of Simon Hausmann.

  • Api/qwebelement.cpp: (QWebElement::styleProperty): (QWebElement::setStyleProperty):
  • Api/qwebelement.h:
6:10 AM Changeset in webkit [44559] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-08 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Reduce duplicated code to access the text of a AtkText
object. doAXStringForRange calls text() internally, so we are
doing exactly the same after the change.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getGailTextUtilForAtk): (getPangoLayoutForAtk):
6:10 AM Changeset in webkit [44558] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Pass a PangoLayout to the GailTextUtil function calls.

It's needed for LINE boundary calls to work correctly.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (updateLayout): (getPangoLayoutForAtk): (webkit_accessible_text_get_text_after_offset): (webkit_accessible_text_get_text_at_offset):
6:10 AM Changeset in webkit [44557] by xan@webkit.org
  • 7 edits in trunk

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Add new dependency on the Gail utils library, needed for our a11y
implementation.

  • GNUmakefile.am:
  • configure.ac:

WebCore:

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Use GailUtilText instead of my crappy partial reimplementation of
it. This should add support for LINE boundaries too, although it's
mostly untested for now.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getGailTextUtilForAtk): (webkit_accessible_text_get_text_after_offset): (webkit_accessible_text_get_text_at_offset):

WebKit/gtk:

2009-06-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Update test for new implementation (it fixes two bugs and adds
actual implementations for LINE boundaries).

  • tests/testatk.c: (test_webkit_atk_get_text_at_offset):
3:41 AM Changeset in webkit [44556] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-10 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix: include <stdio.h> as it is required in jpeglib.h

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

Jun 9, 2009:

11:18 PM Changeset in webkit [44555] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Have sunspider-compare-results use the system version of the jsc
command line binary as there's no good reason to rebuild from source
to simply compare results.

Reviewed by Sam Weinig.

  • Scripts/sunspider-compare-results:
11:18 PM Changeset in webkit [44554] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-06-09 Gavin Barraclough <​barraclough@apple.com>

Rubber Stamped by Mark Rowe.

Tidy up a couple of comments.

  • assembler/ARMv7Assembler.h:

Fix date in copyright, neaten up a couple of comments.

  • assembler/MacroAssemblerARMv7.h:

Fix date in copyright.

7:23 PM Changeset in webkit [44553] by pkasting@chromium.org
  • 11 edits in trunk/WebCore

2009-06-09 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=25709 part four
Most of the remaining Cairo changes needed before merging Skia/Cairo
image decoders. Most of these involve plumbing more error detection and
handling (or, in some cases, merely the capability to detect errors, as
e.g. Skia detects and handles image allocation failure while Cairo
currently doesn't). There is also some general cleanup and
simplification; RGBA32Buffer::m_height and all associated functions have
been removed (set but never used) and some places now rely on superclass
implementations.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::RGBA32Buffer): Remove m_height, ensureHeight() and associated stuff (WebCore::RGBA32Buffer::copyBitmapData): Add API function so refcounted backing stores (like Skia uses) can be used with GIFs (WebCore::RGBA32Buffer::setSize): Zero-fill image to avoid garbage (WebCore::RGBA32Buffer::height): Remove (WebCore::RGBA32Buffer::ensureHeight): Remove (WebCore::ImageDecoder::ImageDecoder): Keep member initialization in order, force subclasses to go through size() instead of accessing m_size directly (WebCore::ImageDecoder::isSizeAvailable): Check that decoding hasn't failed (WebCore::ImageDecoder::size): Check that decoding hasn't failed (WebCore::ImageDecoder::setSize): Protect against integer overflow (WebCore::ImageDecoder::isOverSize): Protect against integer overflow
  • platform/image-decoders/gif/GIFImageDecoder.cpp: Remove prepEmptyFrameBuffer() (WebCore::GIFImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling (WebCore::GIFImageDecoder::sizeNowAvailable): Add return values for better failure handling, rely on superclass setSize() for overflow protection (WebCore::GIFImageDecoder::initFrameBuffer): Add return values for better failure handling, remove prepEmptyFrameBuffer(), use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), use RGBA32Buffer::copyBitmapData() so backing store can be refcounted internally (Cairo won't be, Skia is), rely on superclass size() for better failure handling (WebCore::GIFImageDecoder::haveDecodedRow): Fix style violation, remove RGBA32Buffer::ensureHeight() (WebCore::GIFImageDecoder::frameComplete): Remove RGBA32Buffer::ensureHeight()
  • platform/image-decoders/gif/GIFImageDecoder.h: Remove prepEmptyFrameBuffer(), add return values for better failure handling
  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::do_lzw): Protect against array overflow, add comments (GIFImageReader::read): Protect against array overflow, be more tolerant of bad data, better failure handling
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove MSVC-specific warning disable (bfulgham will move into build files) (WebCore::JPEGImageReader::decode): Better failure handling (WebCore::JPEGImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling (WebCore::JPEGImageDecoder::outputScanlines): Use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), rely on superclass size() for better failure handling, remove RGBA32Buffer::ensureHeight()
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: Rely on superclass setSize() for overflow protection
  • platform/image-decoders/png/PNGImageDecoder.cpp: Remove MSVC-specific warning disable (bfulgham will move into build files) (WebCore::PNGImageDecoder::PNGImageDecoder): Don't allocate a slot in the framebuffer cache until it's needed (WebCore::PNGImageDecoder::isSizeAvailable): Rely on superclass isSizeAvailable() for better failure handling (WebCore::PNGImageDecoder::frameBufferAtIndex): Don't allocate a slot in the framebuffer cache until it's needed (WebCore::PNGImageDecoder::decode): Don't allocate a slot in the framebuffer cache until it's needed (WebCore::PNGImageDecoder::decodingFailed): Fix style violation (WebCore::PNGImageDecoder::headerAvailable): Rely on superclass isSizeAvailable() and setSize() for overflow protection and better failure handling (WebCore::PNGImageDecoder::rowAvailable): Don't allocate a slot in the framebuffer cache until it's needed, use RGBA32Buffer::setSize() to handle potential allocation failures (won't happen with Cairo port, can in Skia), remove RGBA32Buffer::ensureHeight() (WebCore::PNGImageDecoder::pngComplete): Don't allocate a slot in the framebuffer cache until it's needed
5:44 PM Changeset in webkit [44552] by kevino@webkit.org
  • 5 edits in trunk

wx build fix, adding JSCore/assembler to the list of include dirs, and adding editing/ReplaceNodeSpanCommand.cpp to the build.

5:39 PM Changeset in webkit [44551] by bfulgham@webkit.org
  • 2 edits in trunk/LayoutTests

2009-06-09 Brent Fulgham <​bfulgham@webkit.org>

No review, build fix only.
Correct DOS line-endings in expected file.
​https://bugs.webkit.org/show_bug.cgi?id=26187.

  • fast/canvas/canvas-lineWidth-expected.txt:
5:37 PM Changeset in webkit [44550] by oliver@apple.com
  • 12 edits
    6 adds in trunk

Bug 26249: Support JSON.stringify
<​https://bugs.webkit.org/show_bug.cgi?id=26249>

Reviewed by Sam Weinig.

Implement JSON.stringify. This patch handles all the semantics of the ES5
JSON.stringify function, including replacer functions and arrays and both
string and numeric gap arguments.

Currently uses a clamped recursive algorithm basically identical to the spec
description but with a few minor tweaks for performance and corrected semantics
discussed in the es-discuss mailing list.

5:20 PM Changeset in webkit [44549] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-06-09 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

When checking if the loader is the main resource loader make sure that the loader's frame is the main frame.

​https://bugs.webkit.org/show_bug.cgi?id=26218

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::isMainResourceLoader):
  • inspector/InspectorController.h:
5:18 PM Changeset in webkit [44548] by bfulgham@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2009-06-09 Brent Fulgham <​bfulgham@webkit.org>

No review, build fix only.
Added missing expected results from
​https://bugs.webkit.org/show_bug.cgi?id=26187.

  • fast/canvas/canvas-lineWidth-expected.txt: Added.
3:47 PM Changeset in webkit [44547] by bfulgham@webkit.org
  • 2 edits in trunk/BugsSite

2009-06-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Roben.

Add support for displaying added png files in PrettyPatch diffs
​https://bugs.webkit.org/show_bug.cgi?id=26210

Currently this is SVN only (git-send-bugzilla patches exclude binary data)
and only works for PNG files but could easily be made to work for other images as needed.

  • PrettyPatch/PrettyPatch.rb:
3:43 PM Changeset in webkit [44546] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-09 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26190

Test: media/controls-css-overload.html

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls): Prevent NULL dereference in case containers gets hidden.

LayoutTests:

2009-06-09 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Eric Seidel.

Test case on internal -webkit-media overload.

​https://bugs.webkit.org/show_bug.cgi?id=26190

  • media/controls-css-overload-expected.txt: Added.
  • media/controls-css-overload.html: Added.
3:00 PM Changeset in webkit [44545] by pkasting@chromium.org
  • 8 edits in trunk/WebCore

2009-06-08 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=25709 part three
Various minor cleanups to the Skia files. Mostly non-functional, except
for two specific changes:

  • JPEGs and PNGs were always marked as transparent; now they are only marked as transparent when they actually are. I doubt this has much of an effect but in theory it could be used to optimize their display.
  • Instead of arbitrarily disallowing images over 32 * 1024 * 1024 px2, only disallow images which are so large they will cause overflow in other parts of the code. This should fix the testcase on ​http://code.google.com/p/chromium/issues/detail?id=3643.
  • platform/image-decoders/skia/BMPImageReader.h: (WebCore::BMPImageReader::setRGBA): Use simpler non-static setRGBA() form
  • platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer): Remove unneeded code, use more readable setRGBA() form (WebCore::GIFImageDecoder::haveDecodedRow): Fix style violation
  • platform/image-decoders/skia/GIFImageDecoder.h: Remove unneeded code
  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::setSize): setSize() should just setStatus() when it fails since all callers were doing it (WebCore::ImageDecoder::isOverSize): Ease "oversized" image constraints to allow any image that won't overflow
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::outputScanlines): Remove unneeded code, mark JPEGs as non-transparent
  • platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::decodingFailed): Fix style violation (WebCore::PNGImageDecoder::rowAvailable): Mark un-decoded PNGs as non-transparent (this will get reset later as needed)
  • platform/image-decoders/skia/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::frameBufferAtIndex): Remove unneeded code
2:11 PM Changeset in webkit [44544] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-06-09 Darin Fisher <​darin@chromium.org>

Fix Chromium build bustage.


CachedResource.cpp no longer compiles if USE(JSC) is not defined. The
problem is that this file is using a macro from StdLibExtras.h without
including that file. It just happenes to get that file via a JSC
specific include.

  • loader/CachedResource.cpp:
1:47 PM Changeset in webkit [44543] by bfulgham@webkit.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

2009-06-09 Ryosuke Niwa <​rniwa@google.com>

Reviewed by Eric Seidel.

Changing editing/deleting/4866671.html to use a dumpAsText test instead of a pixel test
so as to remove the platform dependency.

  • editing/deleting/4866671.html:
1:39 PM Changeset in webkit [44542] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-09 Dean McNamee <​deanm@chromium.org>

Reviewed by Oliver Hunt.

Make sure the graphics backends are in sync with the canvas lineWidth state.
​https://bugs.webkit.org/show_bug.cgi?id=26187

Test: fast/canvas/canvas-line-width.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):

LayoutTests:

2009-06-09 Dean McNamee <​deanm@chromium.org>

Reviewed by Oliver Hunt.

Make sure the graphics backends are in sync with the canvas lineWidth state.
​https://bugs.webkit.org/show_bug.cgi?id=26187

  • fast/canvas/canvas-lineWidth.html: Added.
  • fast/canvas/canvas-lineWidth.js: Added. (compareRows):
1:34 PM QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
1:03 PM Changeset in webkit [44541] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-09 Michael Nordman <Michael Nordman>

Reviewed by Eric Seidel.

Proactively cancel pending requests at DocLoader dtor time,
otherwise crashes can occur.

​https://bugs.webkit.org/show_bug.cgi?id=26230
​http://code.google.com/p/chromium/issues/detail?id=12161

Test: fast/frames/javascript-url-as-framesrc-crash.html

  • loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader):

LayoutTests:

2009-06-09 Michael Nordman <Michael Nordman>

Reviewed by Eric Seidel.

Proactively cancel pending requests at DocLoader dtor time,
otherwise crashes can occur.

​https://bugs.webkit.org/show_bug.cgi?id=26230
​http://code.google.com/p/chromium/issues/detail?id=12161

  • fast/frames/javascript-url-as-framesrc-crash-expected.txt: Added.
  • fast/frames/javascript-url-as-framesrc-crash.html: Added.
12:34 PM Changeset in webkit [44540] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-09 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

Fix ASSERT seen in shadow tree testing
​https://bugs.webkit.org/show_bug.cgi?id=25092

Test: svg/custom/use-mutation-event-crash.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::instanceForShadowTreeElement):

LayoutTests:

2009-06-09 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

Fix ASSERT seen in shadow tree testing
​https://bugs.webkit.org/show_bug.cgi?id=25092

  • svg/custom/use-mutation-event-crash.svg: Added.
11:27 AM Changeset in webkit [44539] by bfulgham@webkit.org
  • 8 edits in trunk/WebCore

2009-06-09 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Eric Seidel.

Fixes ​https://bugs.webkit.org/show_bug.cgi?id=22891
Scrolling in Windows Cairo Broken if no background color set.

  • platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::fill): Use the GraphicsContext save and restore methods (rather than the Cairo-only functions) so that the Windows device context is kept in sync.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext): Add new constructor call to sync Windows HDC with Cairo surface.
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::syncContext): Provide declaration for Windows HDC sync method (and stub for non-Windows Cairo implementations).
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): Use GraphicsContext save and restore methods (rather than the Cairo-only functions) so that the Windows device context is kept in sync.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::CairoContextWithHDC): New method to create a valid Cairo context for a given HDC. (WebCore::GraphicsContext::GraphicsContext): Modify constructor to use new CairoContextWithHDC call. (WebCore::GraphicsContext::getWindowsContext): Revise to match behavior of CG implementation. (WebCore::GraphicsContext::releaseWindowsContext): Revise to match behavior of CG implementation. (WebCore::GraphicsContextPlatformPrivate::concatCTM): Get rid of incorrect new HDC, and use object's HDC member for dealing with concatCTM operations. (WebCore::GraphicsContextPlatformPrivate::syncContext): New method to sync Windows HDC with Cairo context.
  • platform/graphics/win/ImageCairoWin.cpp: (WebCore::BitmapImage::getHBITMAPOfSize): Revise implementation to match CG behavior.
11:24 AM Changeset in webkit [44538] by jianli@chromium.org
  • 12 edits in trunk

WebCore:

2009-06-09 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

Bug 26196: Fix the problem that worker's importScripts fails if the
script URL is redirected from different origin.
​https://bugs.webkit.org/show_bug.cgi?id=26196

Test: http/tests/workers/worker-importScripts.html

The fix is to pass an additional enum parameter to the loader in
order to tell it to perform the redirect origin check or not.

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::create): (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::willSendRequest):
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::create): (WebCore::ThreadableLoader::loadResourceSynchronously):
  • loader/ThreadableLoader.h: (WebCore::):
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
  • loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously):

LayoutTests:

2009-06-09 Jian Li <​jianli@chromium.org>

Reviewed by David Levin.

Bug 26196: Fix the problem that worker's importScripts fails if the
script URL is redirected from different origin.
​https://bugs.webkit.org/show_bug.cgi?id=26196

Add a test case in the importScripts layout test to cover the scenario
that the import script URL can come from different redirect origin.

  • http/tests/workers/resources/worker-importScripts.js:
  • http/tests/workers/worker-importScripts-expected.txt:
10:09 AM Changeset in webkit [44537] by Dimitri Glazkov
  • 5 edits
    4 adds in trunk

WebCore:

2009-06-09 Anand K. Mistry <​amistry@google.com>

Reviewed by Dimitri Glazkov.

Paint bitmaps with the alpha channel in Skia.
​https://bugs.webkit.org/show_bug.cgi?id=26037

Test: fast/canvas/drawImage-with-globalAlpha.html

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::getAlpha):
  • platform/graphics/skia/PlatformContextSkia.h:

LayoutTests:

2009-06-09 Anand K. Mistry <​amistry@google.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26037
Test the globalAlpha property of canvas contexts.

  • fast/canvas/drawImage-with-globalAlpha.html: Added.
  • platform/mac/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
  • platform/mac/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
  • platform/mac/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
10:05 AM QtWebKitTodo edited by kenneth.christiansen@gmail.com
(diff)
8:35 AM Changeset in webkit [44536] by kov@webkit.org
  • 7 edits in trunk

WebCore

2009-06-09 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=26104
[GTK] Make NetworkRequest a proper GObject and expose SoupMessage

Refactor how SoupMessage is handled, so that our ResourceRequest
object doesn't have to store it as a member, which complicates
managing ResourceRequest's lifetime.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
  • platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):

WebKit/gtk

2009-06-09 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=26104
[GTK] Make NetworkRequest a proper GObject and expose SoupMessage

Refactor how SoupMessage is handled, so that our ResourceRequest
object doesn't have to store it as a member, which complicates
managing ResourceRequest's lifetime.

  • tests/testhttpbackend.c: (navigation_policy_decision_requested_cb): (test_soup_message_lifetime):
  • webkit/webkitnetworkrequest.cpp: (WTF::SoupMessage): (webkit_network_request_new_with_core_request):
7:31 AM Changeset in webkit [44535] by ariya@webkit.org
  • 1 edit in trunk/WebKit/qt/ChangeLog

Correct the reviewer in the previous commit.

7:29 AM Changeset in webkit [44534] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-06-09 Ariya Hidayat <​ariya.hidayat@nokia.com>

Rubber-stamped by Tor Arne Vestbø.

Fix qdoc warning, function parameter string must be referred.

  • Api/qwebview.cpp:
6:42 AM QtWebKitTodo edited by ariya@webkit.org
(diff)
6:42 AM QtWebKitTodo edited by ariya@webkit.org
(diff)
6:19 AM QtWebKitTodo edited by Simon Hausmann
(diff)
5:54 AM QtWebKitTodo edited by Simon Hausmann
(diff)
5:54 AM Changeset in webkit [44533] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-06-09 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Renamed QWebSettings::AllowUniversalAccessFromFileUrls to
LocalContentCanAccessRemoteUrls, as discussed in the API review.

3:53 AM QtWebKitTodo edited by Simon Hausmann
(diff)
3:51 AM Changeset in webkit [44532] by Simon Hausmann
  • 9 edits in trunk

LayoutTests:

2009-06-09 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Adjusted Qt fixed layout testcase to LayoutController API change.

WebKit/qt:

2009-06-09 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Merged useFixedLayout property with fixedLayoutSize and
renamed the latter to fixedContentsSize.

WebKitTools:

2009-06-09 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Removed setUseFixedLayout and renamed setFixedLayoutSize to
setFixedContentsSize.

3:51 AM QtWebKitTodo edited by Simon Hausmann
(diff)
3:51 AM Changeset in webkit [44531] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

2009-06-09 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Renamed QWebHitTestResult::linkTarget to linkElement() and made it return
a QWebElement. The link target itself is always the target DOM attribute.

2:10 AM QtWebKitTodo edited by Simon Hausmann
(diff)
2:00 AM Changeset in webkit [44530] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2009-06-09 Simon Hausmann <​simon.hausmann@nokia.com>

Fix the Qt build, add missing function declaration.

1:50 AM Changeset in webkit [44529] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-06-09 Simon Hausmann <​simon.hausmann@nokia.com>

Fix the Qt build, the time functions moved into the WTF namespace.

1:34 AM QtWebKitTodo edited by Simon Hausmann
(diff)
1:31 AM Changeset in webkit [44528] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-09 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Enable JIT_OPTIMIZE_CALL & JIT_OPTIMIZE_METHOD_CALLS on ARMv7 platforms.

These optimizations function correctly with no further changes.

  • wtf/Platform.h:

Change to enable JIT_OPTIMIZE_CALL & JIT_OPTIMIZE_METHOD_CALLS.

1:20 AM Changeset in webkit [44527] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-09 Gavin Barraclough <​barraclough@apple.com>

Not Reviewed, build fix.

  • assembler/MacroAssemblerARMv7.h:
1:14 AM Changeset in webkit [44526] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-06-09 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Enable JIT_OPTIMIZE_ARITHMETIC on ARMv7 platforms.

Temporarily split support for 'branchTruncateDoubleToInt32' onto its own switch
('supportsFloatingPointTruncate'). See comment in MacroAssemblerARMv7, we need
to work out wherther we are going to be able to support the current interface on
all platforms, or whether this should be refactored.

  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPoint):

Add implementation of supportsFloatingPointTruncate (returns true).

(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):

Add implementation of supportsFloatingPointTruncate (returns false).

(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::storeDouble):
(JSC::MacroAssemblerARMv7::addDouble):
(JSC::MacroAssemblerARMv7::subDouble):
(JSC::MacroAssemblerARMv7::mulDouble):
(JSC::MacroAssemblerARMv7::convertInt32ToDouble):
(JSC::MacroAssemblerARMv7::branchDouble):

Implement FP code genertion operations.

  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::supportsFloatingPointTruncate):

Add implementation of supportsFloatingPointTruncate (returns true).

  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):

Add implementation of supportsFloatingPointTruncate (returns true).

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift):

Changed to call supportsFloatingPointTruncate().

(JSC::JIT::emitSlow_op_rshift):

Changed to call supportsFloatingPointTruncate().

  • wtf/Platform.h:

Change to enable JIT_OPTIMIZE_ARITHMETIC.

12:46 AM Changeset in webkit [44525] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-06-09 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Mark Rowe & Geoff Garen.

Enable JIT_OPTIMIZE_PROPERTY_ACCESS on ARMv7 platforms.

Firm up interface for planting load intructions that will be repatched by
repatchLoadPtrToLEA(). This method should now no longer be applied to just
any loadPtr instruction.

  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::loadPtrWithPatchToLEA):

Implement loadPtrWithPatchToLEA interface (plants a load with a fixed width address).

(JSC::MacroAssemblerARMv7::move):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::moveWithPatch):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):

Switch to use common method 'moveFixedWidthEncoding()' to perform fixed width (often patchable) loads.

(JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):

Move an immediate to a register, always plants movT3/movt instruction pair.

  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::loadPtrWithPatchToLEA):

Implement loadPtrWithPatchToLEA interface (just a regular 32-bit load on x86).

  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::loadPtrWithPatchToLEA):

Implement loadPtrWithPatchToLEA interface (just a regular 64-bit load on x86_64).

  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id):
  • wtf/Platform.h:

Change to enable JIT_OPTIMIZE_PROPERTY_ACCESS.

12:33 AM Changeset in webkit [44524] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix <​https://bugs.webkit.org/show_bug.cgi?id=24642>.
Bug 24642: REGRESSION: Nightly builds sometimes erroneously display a message about failing to launch successfully

Safari 4 on Tiger plays some shenanigans during launch that can confuse the nightly launcher application
in to running its initialization code too soon.

  • WebKitLauncher/WebKitNightlyEnabler.m:

(insideSafariOnTigerTrampoline): Detect these shenanigans.
(enableWebKitNightlyBehaviour): Delay initialization when needed.

Jun 8, 2009:

11:52 PM Changeset in webkit [44523] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

2009-06-08 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Enable JS language JIT for ARM thumb2 platforms. Add ARMv7 specific
asm & constants, add appropriate configuration switches to Platform.h.

Landing this disabled until jump linking is completed (see YARR jit patch).

  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::load32):

Fix: should load pointer with ImmPtr not Imm32.

(JSC::MacroAssemblerARMv7::store32):

Fix: should load pointer with ImmPtr not Imm32.

(JSC::MacroAssemblerARMv7::move):

Fix: When moving an Imm32 that is actually a pointer, should call movT3()
not mov(), to ensure code generation is repeatable (for exception handling).

  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):

Disable JIT_OPTIMIZE_NATIVE_CALL specific code generation if the optimization is not enabled.

  • jit/JIT.h:

Add ARMv7 specific values of constants & register names.

  • jit/JITInlineMethods.h: (JSC::JIT::preverveReturnAddressAfterCall): (JSC::JIT::restoreReturnAddressBeforeReturn): (JSC::JIT::restoreArgumentReferenceForTrampoline):

Implement for ARMv7 (move value to/from lr).

  • jit/JITStubs.cpp:

Add JIT entry/thow trampolines, add macro to add thunk wrapper around stub routines.

  • jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):

Add ARMv7 stack frame object.

  • wtf/Platform.h:

Add changes necessary to allow JIT to build on this platform, disabled.

11:24 PM Changeset in webkit [44522] by oliver@apple.com
  • 12 edits
    6 deletes in trunk

Revert r44521 as it causes regressions on windows for some reason.

11:02 PM Changeset in webkit [44521] by oliver@apple.com
  • 12 edits
    6 adds in trunk

Bug 26249: Support JSON.stringify
<​https://bugs.webkit.org/show_bug.cgi?id=26249>

Reviewed by Sam Weinig.

Implement JSON.stringify. This patch handles all the semantics of the ES5
JSON.stringify function, including replacer functions and arrays and both
string and numeric gap arguments.

Currently uses a clamped recursive algorithm basically identical to the spec
description but with a few minor tweaks for performance and corrected semantics
discussed in the es-discuss mailing list.

10:27 PM Changeset in webkit [44520] by mitz@apple.com
  • 3 edits
    6 moves in trunk/WebKit

WebKit:

Rubber-stamped by Mark Rowe.

  • updated the project after giving Objective-C++ the .mm extension
  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Rubber-stamped by Mark Rowe.

  • gave Objective-C++ files the .mm extension
  • Carbon/HIWebView.m: Removed.
  • Carbon/HIWebView.mm: Copied from WebKit/mac/Carbon/HIWebView.m.
  • Misc/WebKitNSStringExtras.m: Removed.
  • Misc/WebKitNSStringExtras.mm: Copied from WebKit/mac/Misc/WebKitNSStringExtras.m.
  • Misc/WebStringTruncator.m: Removed.
  • Misc/WebStringTruncator.mm: Copied from WebKit/mac/Misc/WebStringTruncator.m.
  • WebInspector/WebNodeHighlight.m: Removed.
  • WebInspector/WebNodeHighlight.mm: Copied from WebKit/mac/WebInspector/WebNodeHighlight.m.
  • WebInspector/WebNodeHighlightView.m: Removed.
  • WebInspector/WebNodeHighlightView.mm: Copied from WebKit/mac/WebInspector/WebNodeHighlightView.m.
  • WebView/WebDynamicScrollBarsView.m: Removed.
  • WebView/WebDynamicScrollBarsView.mm: Copied from WebKit/mac/WebView/WebDynamicScrollBarsView.m.
10:11 PM Changeset in webkit [44519] by beidson@apple.com
  • 15 edits
    4 adds in trunk

WebCore:

2009-06-08 Brady Eidson <​beidson@apple.com>

Reviewed by Antti Koivisto

<rdar://problem/6727495> Repro crash in WebCore::Loader::Host::servePendingRequests() and dupes.

Test: http/tests/loading/deleted-host-in-resource-load-delegate-callback.html

Loader::Host objects were manually managed via new/delete.
There's a variety of circumstances where a Host might've been deleted while it was still in the middle
of a resource load delegate callback.
Changing them to be RefCounted then adding protectors in the callbacks makes this possibility disappear.

At the same time, remove ProcessingResource which was an earlier fix for this same problem that wasn't
fully implemented.

  • loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::load): (WebCore::Loader::servePendingRequests): (WebCore::Loader::resumePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): (WebCore::Loader::Host::didReceiveResponse): (WebCore::Loader::Host::didReceiveData):
  • loader/loader.h: (WebCore::Loader::Host::create):

WebKitTools:

2009-06-08 Brady Eidson <​beidson@apple.com>

Reviewed by Antti Koivisto

Add dispatchPendingLoadRequests() to test fix for <rdar://problem/6727495>

  • DumpRenderTree/LayoutTestController.cpp: (dispatchPendingLoadRequestsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::dispatchPendingLoadRequests): Implement using [WebView _dispatchPendingLoadRequests] SPI
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::dispatchPendingLoadRequests): Need implementations.
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::dispatchPendingLoadRequests): Ditto.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::dispatchPendingLoadRequests): Ditto.
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::dispatchPendingLoadRequests): Ditto.

LayoutTests:

2009-06-08 Brady Eidson <​beidson@apple.com>

Reviewed by Antti Koivisto

<rdar://problem/6727495> Repro crash in WebCore::Loader::Host::servePendingRequests() and dupes.

Note this "Loader::Host deleted while still in use" could come up in a variety of ways but this layout
test only covers the single most reproducible way we know that *could* be tested by DRT.

  • http/tests/loading/deleted-host-in-resource-load-delegate-callback-expected.txt: Added.
  • http/tests/loading/deleted-host-in-resource-load-delegate-callback.html: Added.
  • http/tests/loading/resources/snow-shoes-vs-pie-copy.png: Added.
  • http/tests/loading/resources/snow-shoes-vs-pie.png: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:48 PM Changeset in webkit [44518] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Speculative GTK build fix.

  • wtf/DateMath.cpp:
9:20 PM Changeset in webkit [44517] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-08 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Mark Rowe.

Previous patch caused a regression.

Restructure so no new (empty, inline) function calls are added on x86.

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::makeWritable): (JSC::ExecutableAllocator::makeExecutable): (JSC::ExecutableAllocator::reprotectRegion): (JSC::ExecutableAllocator::cacheFlush):
8:56 PM Changeset in webkit [44516] by Dimitri Glazkov
  • 2 edits in trunk/JavaScriptCore

2009-06-08 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, GTK build fix (thanks, bdash).

  • GNUmakefile.am: Moved DateMath with all other wtf kin.
8:01 PM Changeset in webkit [44515] by dimich@chromium.org
  • 13 edits
    1 copy in trunk/WebCore

2009-06-08 Dmitry Titov <​dimich@chromium.org>

Reviewed by David Levin.

​https://bugs.webkit.org/show_bug.cgi?id=26126
Refactor methods of WorkerMessagingProxy used to talk to main-thread loader into new interface.

Split a couple of methods used to schedule cross-thread tasks between worker thread and loader thread
implemented on WorkerMessagingProxy into a separate interface so the loading can be implemented in
Chromium's workers.

No changes in functionality so no tests added.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Added WorkerLoaderProxy.h to the bulid.
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): WorkerThread::workerObjectProxy() now returns & instead of *
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): same.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): same. (WebCore::WorkerContext::reportException): same. (WebCore::WorkerContext::addMessage): same. (WebCore::WorkerContext::postMessage): same.
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy): (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation): Use WorkerLoaderProxy instead of WorkerMessagingProxy for the MainThreadBridge. Mostly rename.

(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
In addition to using WorkerLoaderProxy instead of WorkerMessagingProxy, the check for
AskedToTerminate is removed. It seems to be an optimization for a very small number of cases
when worker termination is requested a very short time before the request to load something
(XHR or importScript) was dispatched on the main thread.

  • loader/WorkerThreadableLoader.h: Now keeps a pointer to WorkerLoaderProxy rather then to a WorkerMessagingProxy. This allows to implement WorkerThreadableLoader for Chromium.
  • workers/WorkerLoaderProxy.h: Added. (WebCore::WorkerLoaderProxy::~WorkerLoaderProxy):
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::startWorkerContext): (WebCore::WorkerMessagingProxy::postTaskToLoader): Added ASSERT since this needs to be implemented for nested workers.
  • workers/WorkerMessagingProxy.h: Derived from WorkerLoaderProxy, the methods for posting tasks cross-thread are now virtual. Removed unused postTaskToWorkerContext() method.
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread):
  • workers/WorkerThread.h: (WebCore::WorkerThread::workerLoaderProxy):
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
  • workers/WorkerThread.h: (WebCore::WorkerThread::workerLoaderProxy): (WebCore::WorkerThread::workerObjectProxy): WorkerThread gets a new member of type WorkerLoaderProxy&, and accessor. Also, existing WorkerObjectProxy* member is now WorkerObjectProxy& because it can't be null.
6:40 PM Changeset in webkit [44514] by barraclough@apple.com
  • 8 edits
    2 adds in trunk/JavaScriptCore

2009-06-08 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Add (incomplete) support to YARR for running with the jit enabled
on Arm thumb2 platforms. Adds new Assembler/MacroAssembler classes,
along with cache flushing support, tweaks to MacroAssemblerCodePtr
to support decorated thumb code pointers, and new enter/exit code
to YARR jit for the platform.

Support for this platform is still under development - the assembler
currrently only supports planting and linking jumps with a 16Mb range.
As such, initially commiting in a disabled state.

Add new assembler files.

  • assembler/ARMv7Assembler.h: Added.

Add new Assembler.

  • assembler/AbstractMacroAssembler.h:

Tweaks to ensure sizes of pointer values planted in JIT code do not change.

  • assembler/MacroAssembler.h:

On ARMv7 platforms use MacroAssemblerARMv7.

  • assembler/MacroAssemblerARMv7.h: Added.

Add new MacroAssembler.

  • assembler/MacroAssemblerCodeRef.h: (JSC::FunctionPtr::FunctionPtr):

Add better ASSERT.

(JSC::ReturnAddressPtr::ReturnAddressPtr):

Add better ASSERT.

(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):

On ARMv7, MacroAssemblerCodePtr's mush be 'decorated' with a low bit set,
to indicate to the processor that the code is thumb code, not traditional
32-bit ARM.

(JSC::MacroAssemblerCodePtr::dataLocation):

On ARMv7, decoration must be removed.

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::makeWritable):

Reformatted, no change.

(JSC::ExecutableAllocator::makeExecutable):

When marking code executable also cache flush it, where necessary.

(JSC::ExecutableAllocator::MakeWritable::MakeWritable):

Only use the null implementation of this class if both !ASSEMBLER_WX_EXCLUSIVE
and running on x86(_64) - on other platforms we may also need ensure that
makeExecutable is called at the end to flush caches.

(JSC::ExecutableAllocator::reprotectRegion):

Reformatted, no change.

(JSC::ExecutableAllocator::cacheFlush):

Cache flush a region of memory, or platforms where this is necessary.

  • wtf/Platform.h:

Add changes necessary to allow YARR jit to build on this platform, disabled.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):

Add support to these methods for ARMv7.

5:37 PM WebKit Team edited by levin@chromium.org
(diff)
4:59 PM Changeset in webkit [44513] by Dimitri Glazkov
  • 2 edits in trunk/JavaScriptCore

2009-06-08 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, fix my previous fix.

  • runtime/DateInstance.cpp: (JSC::DateInstance::msToGregorianDateTime): Use WTF namespace qualifier to

disambiguate func signatures.

4:52 PM Changeset in webkit [44512] by Dimitri Glazkov
  • 3 edits in trunk/JavaScriptCore

2009-06-08 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, another Windows build fix.

4:48 PM Changeset in webkit [44511] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Attempt to fix the Tiger build.

  • wtf/Platform.h: Only test the value of the macro once we know it is defined.
4:16 PM Changeset in webkit [44510] by Dimitri Glazkov
  • 3 edits in trunk/JavaScriptCore

2009-06-08 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, projectile-fixing Windows build.

  • runtime/DateConversion.cpp: Added StringExtras include.
  • wtf/DateMath.cpp: Replaced math with algorithm include (looking for std::min def for Windows).
4:01 PM Changeset in webkit [44509] by Dimitri Glazkov
  • 5 edits in trunk/JavaScriptCore

2009-06-08 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, Windows build fix.

  • runtime/DateConstructor.cpp: Changed to use WTF namespace.
  • runtime/DateConversion.cpp: Added UString include.
  • runtime/DateInstance.cpp: Changed to use WTF namespace.
  • wtf/DateMath.cpp: Added math include.
3:37 PM Changeset in webkit [44508] by Dimitri Glazkov
  • 20 edits
    2 copies
    3 moves in trunk

JavaScriptCore:

2009-06-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26238
Move most of runtime/DateMath functions to wtf/DateMath, and split off conversion-related
helpers to DateConversion.

  • AllInOneFile.cpp: Changed DateMath->DateConversion.
  • GNUmakefile.am: Ditto and added DateMath.
  • JavaScriptCore.exp: Ditto.
  • JavaScriptCore.pri: Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Added DateMath.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • JavaScriptCoreSources.bkl: Ditto.
  • pcre/pcre_exec.cpp: Changed to use DateMath.
  • profiler/ProfileNode.cpp: (JSC::getCount): Changed to use DateConversion.
  • runtime/DateConstructor.cpp: Ditto.
  • runtime/DateConversion.cpp: Copied from JavaScriptCore/runtime/DateMath.cpp. (JSC::parseDate): Refactored to use null-terminated characters as input.
  • runtime/DateConversion.h: Copied from JavaScriptCore/runtime/DateMath.h.
  • runtime/DateInstance.cpp: Changed to use wtf/DateMath.
  • runtime/DateInstance.h: Ditto.
  • runtime/DateMath.cpp: Removed.
  • runtime/DateMath.h: Removed.
  • runtime/DatePrototype.cpp: Ditto.
  • runtime/InitializeThreading.cpp: Ditto.
  • wtf/DateMath.cpp: Copied from JavaScriptCore/runtime/DateMath.cpp.
  • wtf/DateMath.h: Copied from JavaScriptCore/runtime/DateMath.h.

WebCore:

2009-06-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=26238
Add parseDate helper to HTTPParsers, which uses WTF::parseDateFromNullTerminatedCharacters.

  • ForwardingHeaders/runtime/DateMath.h: Removed.
  • ForwardingHeaders/wtf/DateMath.h: Copied from WebCore/ForwardingHeaders/runtime/DateMath.h.
  • platform/network/HTTPParsers.cpp: (WebCore::parseDate): Added.
  • platform/network/HTTPParsers.h:
  • platform/network/ResourceResponseBase.cpp: (WebCore::parseDateValueInHeader): Changed to use the new helper.
2:43 PM Changeset in webkit [44507] by sfalken@apple.com
  • 2 edits in tags/Safari-6530.17.1/JavaScriptCore

Merge r44506.

2:38 PM Changeset in webkit [44506] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

2:18 PM Changeset in webkit [44505] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.17.1

New tag.

1:47 PM Changeset in webkit [44504] by barraclough@apple.com
  • 9 edits in trunk/JavaScriptCore

2009-06-07 David Kilzer <​ddkilzer@apple.com>

Make JavaScriptCore compile for iPhone and iPhone Simulator

Reviewed by Gavin Barraclough.

  • Configurations/Base.xcconfig: Split GCC_ENABLE_OBJC_GC on $(REAL_PLATFORM_NAME). Added $(ARCHS_UNIVERSAL_IPHONE_OS) to VALID_ARCHS. Added REAL_PLATFORM_NAME_iphoneos, REAL_PLATFORM_NAME_iphonesimulator, HAVE_DTRACE_iphoneos and HAVE_DTRACE_iphonesimulator variables.
  • Configurations/DebugRelase.xcconfig: Split ARCHS definition on $(REAL_PLATFORM_NAME).
  • Configurations/JavaScriptCore.xcconfig: Added EXPORTED_SYMBOLS_FILE_armv6 and EXPORTED_SYMBOLS_FILE_armv7 variables. Split OTHER_LDFLAGS into OTHER_LDFLAGS_BASE and OTHER_LDFLAGS_$(REAL_PLATFORM_NAME) since CoreServices.framework is only linked to on Mac OS X.
  • JavaScriptCore.xcodeproj/project.pbxproj: Removed references to CoreServices.framework since it's linked using OTHER_LDFLAGS in JavaScriptCore.xcconfig.
  • profiler/ProfilerServer.mm: Added #import for iPhone Simulator. (-[ProfilerServer init]): Conditionalize use of NSDistributedNotificationCenter to non-iPhone or iPhone Simulator.
  • wtf/FastMalloc.cpp: (WTF::TCMallocStats::): Build fix for iPhone and iPhone Simulator.
  • wtf/Platform.h: Defined PLATFORM(IPHONE) and PLATFORM(IPHONE_SIMULATOR).
  • wtf/ThreadingPthreads.cpp: (WTF::setThreadNameInternal): Build fix for iPhone and iPhone Simulator.
10:52 AM Changeset in webkit [44503] by agl@chromium.org
  • 5 edits
    1 add in trunk/WebCore

2009-06-08 Adam Langley <​agl@google.com>

Reviewed by Eric Siedel.

Chromium Linux ignored the background color on <select>s. Rather
than encode magic colours, we start with a base color (specified
via CSS) and derive the other colors from it. Thus, setting the
CSS background-color now correctly changes the colour of the
control.

This should not change the appearence controls without
background-colors. However, <select>s with a background-color
will now renderer correctly, which may require rebaselining
pixel tests in the Chromium tree.

​https://bugs.webkit.org/show_bug.cgi?id=26030
​http://code.google.com/p/chromium/issues/detail?id=12596

  • platform/graphics/Color.cpp: (WebCore::Color::getHSL): new member
  • platform/graphics/Color.h:
  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::systemColor): (WebCore::brightenColor): (WebCore::paintButtonLike):
10:19 AM Changeset in webkit [44502] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-08 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=26240
[GTK] Try again button loses query strings

Only trigger reload, when try again is clicked, this way we do not
lose the query strings, like we did when also triggering a form
submission.

  • resources/error.html:
9:24 AM Changeset in webkit [44501] by Dimitri Glazkov
  • 1 edit in trunk/WebCore/ChangeLog

Fixed the name in the ChangeLog

9:23 AM Changeset in webkit [44500] by Dimitri Glazkov
  • 2 edits
    2 adds in trunk/WebCore

2009-06-08 victorw <​victorw@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26087
Bug 26087: Removing element in JS crashes Chrome tab if it fired the change event

Fix tab crash caused by destroying the popup list that fired the change event on abandon.

If a popup list is abandoned (press a key to jump to an item
and then use tab or mouse to get away from the select box),
the current code fires a change event in PopupListBox::updateFromElemt().
The JS that listens to this event may destroy the object and cause the
rest of popup list code crashes.

The updateFromElement() is called before abandon() and this causes
the selected index to be discarded after updateFromElement(). From
the code comments, this appears to be the reason why valueChanged is
called in updateFromElement.

Fix the issue by removing the valueChanged call in updateFromElement,
saving the selected index that we should accept on abandon and pass
it to the valueChange in abandon().

A manual test has been added.

  • manual-tests/chromium: Added.
  • manual-tests/chromium/onchange-reload-popup.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::PopupListBox): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::updateFromElement):
8:53 AM Changeset in webkit [44499] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-08 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Disable a few warnings on Windows

8:53 AM QtWebKitTodo edited by Simon Hausmann
(diff)
8:51 AM Changeset in webkit [44498] by Simon Hausmann
  • 6 edits in trunk/WebKit/qt

2009-06-08 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

Renamed QWebElement::enclosingBlock to enclosingBlockElement
and changed the return type to QWebElement, as discussed in
the API review. This API is more generic and through
QWebElement's geometry() it is possible to retrieve the
same information.

8:38 AM Changeset in webkit [44497] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-06-08 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Don't enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH on Windows

This define was brought in after refactoring some code from
PluginPackage(Qt|Gtk).cpp into the shared PluginPackage.cpp.

8:23 AM QtWebKitTodo edited by Simon Hausmann
(diff)
8:14 AM QtWebKitTodo edited by Simon Hausmann
(diff)
8:13 AM QtWebKitTodo edited by Simon Hausmann
(diff)
8:10 AM QtWebKitTodo edited by Simon Hausmann
(diff)
7:35 AM Changeset in webkit [44496] by vestbo@webkit.org
  • 6 edits in trunk

2009-06-08 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Use $QMAKE_PATH_SEP instead of hardcoded / to fix Windows build

7:35 AM QtWebKitTodo edited by Simon Hausmann
(diff)
7:17 AM QtWebKitTodo edited by Simon Hausmann
(diff)
6:25 AM QtWebKitTodo edited by Simon Hausmann
(diff)
5:56 AM QtWebKitTodo edited by Simon Hausmann
(diff)
5:05 AM Changeset in webkit [44495] by ariya@webkit.org
  • 4 edits in trunk/WebCore

2009-06-08 Laszlo Gombos <Laszlo Gombos>

Reviewed by Ariya Hidayat.

[Qt] Build fix when NETSCAPE_PLUGIN_API support is turned off
​https://bugs.webkit.org/show_bug.cgi?id=26244

  • WebCore.pro: Define PLUGIN_PACKAGE_SIMPLE_HASH only if NETSCAPE_PLUGIN_API is turned on
  • plugins/PluginPackage.cpp: Guard initializeBrowserFuncs()
  • plugins/PluginViewNone.cpp: Match guards with PluginView.h

Jun 7, 2009:

11:38 PM Changeset in webkit [44494] by jmalonzo@webkit.org
  • 5 edits in trunk

Revert "2009-06-05 WANG Lu <​coolwanglu@gmail.com>"

Revert commit r44479 as we need to workout first what the best option is for adding
optional features like this.

9:28 PM Changeset in webkit [44493] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-06-07 Gavin Barraclough <​barraclough@apple.com>

RS by Sam Weinig.

Remove bonus bogus \n from last commit.

  • jit/JITStubs.cpp: (JSC::):
9:23 PM Changeset in webkit [44492] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-06-07 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Sam Weinig.

Change the implementation of op_throw so the stub function always modifies its
return address - if it doesn't find a 'catch' it will switch to a trampoline
to force a return from JIT execution. This saves memory, by avoiding the need
for a unique return for every op_throw.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):

JITStubs::cti_op_throw now always changes its return address,
remove return code generated after the stub call (this is now
handled by ctiOpThrowNotCaught).

  • jit/JITStubs.cpp: (JSC::):

Add ctiOpThrowNotCaught definitions.

(JSC::JITStubs::DEFINE_STUB_FUNCTION):

Change cti_op_throw to always change its return address.

  • jit/JITStubs.h:

Add ctiOpThrowNotCaught declaration.

7:19 PM Changeset in webkit [44491] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • fix <rdar://problem/6931661> -[WebView _selectionIsAll] returns YES when the selection is inside a text field.
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::isAll): Return false if the selection is in a shadow tree.
1:25 PM Changeset in webkit [44490] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-06-07 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=26106
[GTK] Crashes when you keep a combo open during a page transition, then close it

Hide the combo popup and disconnect from its signals during
PopupMenu destruction to handle this exceptional case with no
crash.

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::menuUnmapped):
1:55 AM Changeset in webkit [44489] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Delete the AccessibilityController that we allocated in -init.

Rubber-stamped by Cameron Zwarich.

  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate dealloc]):

Jun 6, 2009:

10:45 PM Changeset in webkit [44488] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Factor out the code to check whether a library contains a given symbol in to a helper function.

Reviewed by Dan Bernstein.

  • Scripts/webkitdirs.pm:
10:25 PM Changeset in webkit [44487] by mrowe@apple.com
  • 8 edits in trunk

Detect when XHTML MP and WCSS are disabled and skip their associated regression tests.

Reviewed by Sam Weinig.

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:

Remove XHTML MP and WCSS tests from the skipped lists as run-webkit-tests
now treats them like our other optional features and will skip them automatically
when the feature is not compiled in.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
8:09 PM Changeset in webkit [44486] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Unskip two more tests that now pass.

  • platform/mac-snowleopard/Skipped:
6:38 PM Changeset in webkit [44485] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-06-06 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=26175
[GTK] Download progress notification should be throttled, for the benefit of download managers

Throttle notifications for the 'progress' property of the Download
object, and update documentation to note the fact that this is
being done, and how to get all notifications if you really care
about them.

  • webkit/webkitdownload.cpp: (webkit_download_class_init): (webkit_download_received_data):
6:10 PM Changeset in webkit [44484] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Unskip some tests now that they pass.

  • platform/mac-snowleopard/Skipped:
6:10 PM Changeset in webkit [44483] by mrowe@apple.com
  • 4 edits in trunk

<rdar://problem/6778101> Four SSL-related test failures

Reviewed by Brady Eidson.

With newer versions of CFNetwork we receive a NSURLErrorServerCertificateUntrusted error
code rather than the more specific NSURLErrorServerCertificateHasUnknownRoot that DumpRenderTree
was looking for. Update DumpRenderTree to accommodate the different error code.

  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):

  • platform/mac-snowleopard/Skipped: Unskip the tests.
5:20 PM Changeset in webkit [44482] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-06-06 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6930540>
REGRESSION (r43797): Serif and fantasy font-family names are wrong in result of getComputedStyle

Test: fast/css/font-family-builtins.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::identifierForFamily): Fix typo. Fantasy family should be -webkit-fantasy not, -webkit-serif.

LayoutTests:

2009-06-06 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Test for <rdar://problem/6930540>
REGRESSION (r43797): Serif and fantasy font-family names are wrong in result of getComputedStyle

  • fast/css/font-family-builtins-expected.txt: Added.
  • fast/css/font-family-builtins.html: Added.
3:17 PM Changeset in webkit [44481] by weinig@apple.com
  • 13 edits in trunk

WebCore:

2009-06-06 Sam Weinig <​sam@webkit.org>

Reviewed by Brady Eidson.

Fix for <rdar://problem/6936235>
Need to support StorageEvent.storageArea to meet the Web Storage spec

  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::dispatchStorageEvent): Pass the localStorage for the frame being dispatched to.
  • storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::dispatchStorageEvent): Ditto, only for sessionStorage.
  • storage/StorageEvent.cpp: (WebCore::StorageEvent::StorageEvent): (WebCore::StorageEvent::initStorageEvent):
  • storage/StorageEvent.h: (WebCore::StorageEvent::create): (WebCore::StorageEvent::storageArea):
  • storage/StorageEvent.idl: Add storageArea member.

LayoutTests:

2009-06-06 Sam Weinig <​sam@webkit.org>

Reviewed by Brady Eidson.

Update tests for <rdar://problem/6936235>
Need to support StorageEvent.storageArea to meet the Web Storage spec

Test StorageEvent.uri, StorageEvent.source and StorageEvent.storageArea.

  • storage/domstorage/localstorage/iframe-events-expected.txt:
  • storage/domstorage/localstorage/iframe-events.html:
  • storage/domstorage/localstorage/resources/iframe-events-second.html:
  • storage/domstorage/sessionstorage/iframe-events-expected.txt:
  • storage/domstorage/sessionstorage/iframe-events.html:
  • storage/domstorage/sessionstorage/resources/iframe-events-second.html:
9:53 AM Changeset in webkit [44480] by Nikolas Zimmermann
  • 11 edits in trunk

Reviewed by Anders Carlsson.

Force initialization of the WML variable state, right after the dynamically created WML elements have been added to the tree.
Note that "regular WML" doesn't support JavaScript at all, in a normal WML document WMLDocument::finishedParsing() takes care of that.

Note: See TracTimeline for information about the timeline view.