Context Navigation

(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub): Don't take a stub call when operating on
a constant int and a double.

8:40 PM QtWebKitPerformanceUtilities created by zecke@selfish.org

Create overview of the utilities... stub

8:27 PM QtWebKitPerformanceWork created by zecke@selfish.org

Start QtWebKit performance analysis page.

7:46 PM Changeset in webkit [48919] by hyatt@apple.com

3 edits in trunk/WebCore

Fix a couple of bugs with patterns. Move the setting of the document URL to before the style
selector gets constructed so that pattern match testing gets the correct URL.

Reviewed by Jon Honeycutt.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::begin):

page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::parse):

7:02 PM Changeset in webkit [48918] by ap@apple.com

2 edits in trunk/WebCore

Rubber-stamped by Brady Eidson.

Assertion failure in http/tests/xmlhttprequest/failed-auth.html.

I couldn't find out why this only started to happen now, but it was incorrect to check
persistence of a credential returned by CredentialStorage::get() without checking that it
was non-null. When there is no credential for the protection space in storage, get()
returns a new object, and Credentil constructor doesn't initialize m_persistence.

platform/network/mac/ResourceHandleMac.mm: (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Moved the assertion after credential null check. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Added the same persistence assertion, matching sync code (and CF one, as well).

7:00 PM Changeset in webkit [48917] by beidson@apple.com

7 edits in trunk

Rubberstamped by Dan Bernstein.

Fix license and some sorting in new files.

WebKit/mac:

WebView/WebHistoryDelegate.h:
WebView/WebNavigationData.h:
WebView/WebNavigationData.mm:

WebKitTools:

DumpRenderTree/mac/HistoryDelegate.h:
DumpRenderTree/mac/HistoryDelegate.mm:

6:46 PM Changeset in webkit [48916] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-09-29 Yaar Schnitman <yaar@chromium.org>

Reviewed by David Kilzer.

Fixed how error codes are handled.
https://bugs.webkit.org/show_bug.cgi?id=29898

Scripts/update-webkit:
Scripts/update-webkit-chromium:

6:36 PM Changeset in webkit [48915] by beidson@apple.com

3 edits in trunk/WebKitTools

Updated way-out-of-date sorting throughout the dump methods/flags.

Reviewed by John Sullivan.

DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(dumpAsPDFCallback):
(dumpAsTextCallback):
(dumpFrameLoadCallbacksCallback):
(dumpResourceLoadCallbacksCallback):
(LayoutTestController::staticFunctions):

DumpRenderTree/LayoutTestController.h:

(LayoutTestController::dumpAsText):
(LayoutTestController::setDumpAsText):
(LayoutTestController::dumpFrameLoadCallbacks):
(LayoutTestController::setDumpFrameLoadCallbacks):
(LayoutTestController::dumpSelectionRect):
(LayoutTestController::setDumpSelectionRect):
(LayoutTestController::dumpSourceAsWebArchive):
(LayoutTestController::setDumpSourceAsWebArchive):
(LayoutTestController::dumpStatusCallbacks):
(LayoutTestController::setDumpStatusCallbacks):
(LayoutTestController::dumpTitleChanges):
(LayoutTestController::setDumpTitleChanges):
(LayoutTestController::dumpWillCacheResponse):
(LayoutTestController::setDumpWillCacheResponse):

6:35 PM Changeset in webkit [48914] by beidson@apple.com

17 edits
11 adds in trunk

WebKit Mac API should provide a delegate interface for global history.
<rdar://problem/7042773> and https://webkit.org/b/29904

Reviewed by John Sullivan.

WebKit:

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

WebView/WebHistoryDelegate.h: Added. New interface for WebKit clients to implement to manage their own global history store.

Object to store all of the bits of data relevant to a page visit:

WebView/WebNavigationData.h: Added.
WebView/WebNavigationData.mm: Added.

(-[WebNavigationDataPrivate dealloc]):
(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
(-[WebNavigationData url]):
(-[WebNavigationData title]):
(-[WebNavigationData originalRequest]):
(-[WebNavigationData response]):
(-[WebNavigationData hasSubstituteData]):
(-[WebNavigationData clientRedirectSource]):
(-[WebNavigationData dealloc]):

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::updateGlobalHistory): If the delegate exists, don't use the built-in WebHistory.

If the implementation for this method exists, call it.

(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Ditto

WebView/WebDelegateImplementationCaching.h:
WebView/WebDelegateImplementationCaching.mm:

(WebViewGetHistoryDelegateImplementations):
(CallHistoryDelegate):

WebView/WebView.mm:

(-[WebView _cacheHistoryDelegateImplementations]):
(-[WebView setHistoryDelegate:]):
(-[WebView historyDelegate]):

WebView/WebViewData.h:
WebView/WebViewPrivate.h:

WebKitTools:

Adding the dumping of global history delegate callbacks.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:

DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):
(allocateGlobalControllers):
(shouldLogFrameLoadDelegates):
(shouldLogHistoryDelegates):
(runTest):

Dump history delegate callbacks:

DumpRenderTree/mac/HistoryDelegate.h: Added.
DumpRenderTree/mac/HistoryDelegate.mm: Added.

(-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
(-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
(-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):

LayoutTests:

http/tests/globalhistory: Added.
http/tests/globalhistory/history-delegate-basic-302-redirect-expected.txt: Added.
http/tests/globalhistory/history-delegate-basic-302-redirect.html: Added.
http/tests/globalhistory/history-delegate-basic-refresh-redirect-expected.txt: Added.
http/tests/globalhistory/history-delegate-basic-refresh-redirect.html: Added.
http/tests/resources/notify-done.html: Added.
http/tests/resources/redirect.php: Augment to optionally do "Refresh:"-style redirects.

Skip these new tests on all platforms that don't have history delegates (yet):

platform/gtk/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

6:07 PM Changeset in webkit [48913] by yong.li@torchmobile.com

2 edits in trunk/WebCore

2009-09-29 Yong Li <yong.li@torchmobile.com>

Reviewed by Darin Adler.

Add an ASSERT for UTF8Encoding().isValid()
https://bugs.webkit.org/show_bug.cgi?id=29908

platform/text/TextEncoding.cpp: (WebCore::UTF8Encoding):

5:32 PM Changeset in webkit [48912] by hyatt@apple.com

8 edits
2 adds in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=29892
Add support for whitelist patterns to control conditional injection of user scripts and
user stylesheets.

Reviewed by Jon Honeycutt.

No new tests. Not testable until WebKit portion is added in followup patch.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::Document::pageGroupUserSheets):

page/Frame.cpp:

(WebCore::Frame::injectUserScriptsForWorld):

page/UserContentURLPattern.cpp: Added.

(WebCore::UserContentURLPattern::matchesPatterns):
(WebCore::UserContentURLPattern::parse):
(WebCore::UserContentURLPattern::matches):
(WebCore::UserContentURLPattern::matchesHost):
(WebCore::MatchTester::MatchTester):
(WebCore::MatchTester::testStringFinished):
(WebCore::MatchTester::patternStringFinished):
(WebCore::MatchTester::eatWildcard):
(WebCore::MatchTester::eatSameChars):
(WebCore::MatchTester::test):
(WebCore::UserContentURLPattern::matchesPath):

page/UserContentURLPattern.h: Added.

(WebCore::UserContentURLPattern::UserContentURLPattern):
(WebCore::UserContentURLPattern::scheme):
(WebCore::UserContentURLPattern::host):
(WebCore::UserContentURLPattern::path):
(WebCore::UserContentURLPattern::matchSubdomains):

4:20 PM Changeset in webkit [48911] by dbates@webkit.org

1 edit
15 adds in trunk/LayoutTests

2009-09-29 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=29837

More tests for the XSSAuditor.

http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt: Added.
http/tests/security/xssAuditor/embed-tag-javascript-url.html: Added.
http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt: Added.
http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html: Added.
http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt: Added.
http/tests/security/xssAuditor/object-tag-javascript-url.html: Added.
http/tests/security/xssAuditor/property-escape-noquotes-expected.txt: Added.
http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt: Added.
http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html: Added.
http/tests/security/xssAuditor/property-escape-noquotes.html: Added.
http/tests/security/xssAuditor/property-inject-expected.txt: Added.
http/tests/security/xssAuditor/property-inject.html: Added.
http/tests/security/xssAuditor/resources/echo-head.pl: Added.
http/tests/security/xssAuditor/resources/echo-inner-tag.pl: Added.
http/tests/security/xssAuditor/resources/echo-property-noquotes.pl: Added.

4:10 PM Changeset in webkit [48910] by eric@webkit.org

4 edits
2 adds in trunk

2009-09-29 Enrica Casucci <enrica@apple.com>

Reviewed by Adele Peterson.

Test case for <rdar://problem/7085453>.

editing/selection/blockquote-crash-expected.txt: Added.
editing/selection/blockquote-crash.html: Added.

2009-09-29 Enrica Casucci <enrica@apple.com>

Reviewed by Adele Peterson.

Reproducible crash pressing return inside quoted content
at WebCore::BreakBlockquoteCommand::doApply.
<rdar://problem/7085453>
In some case, like the one provided in the test case, m_downStreamEnd
refers to a node that gets deleted when executing the DeleteSelectionCommand.
We shouldn't use m_downStreamEnd to recalculate the new m_endPosition when
pruning is needed, because it may be point to a node that has been deleted, but
rather rely on removeNode in CompositeEditCommand to update m_endPosition correctly.

Test: editing/selection/blockquote-crash.html

editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Added check for invalid position to avoid dereferencing a null node pointer.
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Don't reset m_endPosition using the value in m_downStreamEnd when it is necessary to prune the start block.

3:58 PM Changeset in webkit [48909] by ap@apple.com

2 edits in trunk/WebCore

Reviewed by Brady Eidson.

Basic authentication credentials are not sent automatically to top resources
https://bugs.webkit.org/show_bug.cgi?id=29901

No new tests - I don't want to pollute root directory of http tests to check for this rather
minor issue.

platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Changed to always preserve leading slash. (WebCore::CredentialStorage::getDefaultAuthenticationCredential): Made breaking out of the loop more explicit.

3:27 PM Changeset in webkit [48908] by bweinstein@apple.com

2 edits in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore

Windows build fix.

3:10 PM Changeset in webkit [48907] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-09-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Oliver Hunt.

Web Inspector REGRESSION(r47820-r47822): Profiles aren't
added to the inspector unless the inspector is already open
when the profile completes.

https://bugs.webkit.org/show_bug.cgi?id=29897

inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._populateProfiles):

3:06 PM Changeset in webkit [48906] by kenneth@webkit.org

2 edits in trunk/WebCore

Rubberstamped by David Hyatt.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Fix to logic of earlier commit 48902.

When merging two if's before committing, I forgot to invert the
bool check.

platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::ignoreHttpError):

2:48 PM Changeset in webkit [48905] by oliver@apple.com

14 edits in trunk/JavaScriptCore

Tidy up codeblock sampler
https://bugs.webkit.org/show_bug.cgi?id=29836

Reviewed by Gavin Barraclough.

Some rather simple refactoring of codeblock sampler so that
it's easier for us to use it to find problems in non-jsc
environments

2:43 PM Changeset in webkit [48904] by senorblanco@chromium.org

5 edits in trunk/WebCore

Unreviewed, build fix.

Fixing Chromium build, following r48884.

https://bugs.webkit.org/show_bug.cgi?id=29894

bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::handleEvent):

bindings/v8/V8AbstractEventListener.h:
bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::handleEvent):

bindings/v8/V8WorkerContextEventListener.h:

2:25 PM Changeset in webkit [48903] by eric@webkit.org

12 edits in trunk

2009-09-29 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Update for .maxLength behavior change.
https://bugs.webkit.org/show_bug.cgi?id=29796

fast/forms/input-maxlength-expected.txt:
fast/forms/input-maxlength.html:
fast/forms/script-tests/textarea-maxlength.js:
fast/forms/textarea-maxlength-expected.txt:

2009-09-29 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Follows HTML5's maxLength change in September 2009.

Change HTMLTextAreaElement.maxLength type to signed.
HTMLTextAreaElement.maxLength returns -1 if maxlength= attribute is missing.
HTMLTextAreaElement.maxLength and HTMLInputElement.maxLength throw INDEX_SIZE_ERR for setting negative values. https://bugs.webkit.org/show_bug.cgi?id=29796

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setMaxLength):
html/HTMLInputElement.h:
html/HTMLInputElement.idl:
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent): (WebCore::HTMLTextAreaElement::maxLength): (WebCore::HTMLTextAreaElement::setMaxLength):
html/HTMLTextAreaElement.h:
html/HTMLTextAreaElement.idl:

2:07 PM Changeset in webkit [48902] by kenneth@webkit.org

2 edits in trunk/WebCore

Don't rely on QNetworkReply::NetworkError codes, but
on HTTP error codes instead.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::ignoreHttpError):
(WebCore::QNetworkReplyHandler::finish):

2:07 PM Changeset in webkit [48901] by kenneth@webkit.org

2 edits in trunk/WebCore

Use const references when using Qt's foreach.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

2:07 PM Changeset in webkit [48900] by kenneth@webkit.org

2 edits in trunk/WebCore

Fix handling of QNetworkReply errors.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

In the QNetworkReplyHandler::finish() a response was sent even when
the reply contained an error. This resulted in a sendResponseIfNeeded()
calling didReceiveResponse on the client, leading to the destruction
of the m_resourceHandle, discontinuing further processing in finish(),
and thus not calling didFail on the client.

Instead it continued as everything went fine, and
FrameLoaderClientQt::dispatchDecidePolicyForMIMEType() changed the
policy to PolicyDownload due to not being able to show the non existing
MIMEType. As the download also obviously fails, it ended up with a
policy change error.

platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):

2:01 PM Changeset in webkit [48899] by dbates@webkit.org

4 edits in trunk/WebKitTools

2009-09-29 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=28902

Fixes an issue where the drop effect returned by Window Dump Render Tree
was always DROPEFFECT_NONE (since it was hard coded to do so).

This patch corrects this issue by determining the actual drop effect
performed by the corresponding drag-and-drop operation so that we can
return it.

DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect. (DraggingInfo::DraggingInfo): (DraggingInfo::performedDropEffect): Added method. (DraggingInfo::setPerformedDropEffect): Added method.
DumpRenderTree/win/EventSender.cpp: (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect. Moved delete draggingInfo to UIDelegate::doDragDrop.
DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().

1:48 PM Changeset in webkit [48898] by jorlow@chromium.org

2 edits in trunk/JavaScriptCore

2009-09-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Add GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=29895

The following files are generated by JavaScriptCore's GYP file and should be ignored:

pcre.mk
wtf.scons
wtf.mk
SConstruct
wtf_config.scons
wtf_config.mk
pcre.scons

JavaScriptCore.gyp: Changed property svn:ignore.

1:42 PM Changeset in webkit [48897] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-29 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r48894, because review discussion was not complete.
http://trac.webkit.org/changeset/48894

platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::begin):

1:29 PM Changeset in webkit [48896] by krit@webkit.org

3 edits
4 adds in trunk

2009-09-29 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter feComposite implementation is missing
https://bugs.webkit.org/show_bug.cgi?id=28362

feComposite implementation for SVG.

Test: svg/filters/feComposite.svg

platform/graphics/filters/FEComposite.cpp: (WebCore::arithmetic): (WebCore::FEComposite::apply):

Tests the feComposite implementation for SVG.

platform/mac/svg/filters/feComposite-expected.checksum: Added.
platform/mac/svg/filters/feComposite-expected.png: Added.
platform/mac/svg/filters/feComposite-expected.txt: Added.
svg/filters/feComposite.svg: Added.

1:28 PM Changeset in webkit [48895] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Standardized an optimization for adding non-numbers.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
Reviewed by Sam Weinig.

SunSpider says maybe a tiny speedup.

jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

1:05 PM Changeset in webkit [48894] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-29 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Starting all read-only transactions with an explicit BEGIN
DEFERRED command instead of BEGIN, since some ports (chromium)
might compile their own SQLite library and set BEGIN to BEGIN
IMMEDIATE by default; which would result in a deadlock in case of
two concurrent read-only transactions on the same DB, and would
unnecessarily delay other potential transactions to the same DB.

https://bugs.webkit.org/show_bug.cgi?id=29729

platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::begin):

12:49 PM Changeset in webkit [48893] by Dimitri Glazkov

9 edits in trunk

WebCore:

2009-09-29 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Add support for run-time flag for 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=29826

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): Check page settings for experimental WebGL flag before returning 3D graphics context.
page/Settings.cpp: (WebCore::Settings::Settings): Initialize new flag to false. (WebCore::Settings::setExperimentalWebGLEnabled):
page/Settings.h: Set new flag. (WebCore::Settings::experimentalWebGLEnabled): Return new flag.

WebKit/mac:

2009-09-29 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Add support for run-time flag for 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=29826

WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Enable experimental WebGL flag when 3D_CANVAS is enabled in the build.

WebKit/win:

2009-09-29 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Add support for run-time flag for 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=29826

WebView.cpp: (WebView::notifyPreferencesChanged): Enable experimental WebGL flag when 3D_CANVAS is enabled in the build.

12:39 PM Changeset in webkit [48892] by jorlow@chromium.org

2 edits
1 add in trunk/WebCore

2009-09-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Chromium needs to be able to override the way storage events are delivered - part 1
https://bugs.webkit.org/show_bug.cgi?id=29889

Chromium needs to be able to override the way storage events are delivered.
This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be
faster (no vtables and extra allocation) and somewhat cleaner (no dependency
injection). This is necessary because Chromium needs to transport events across
a process barrier and then dispatch them without use of a Frame*.

This patch should be a no-op for all ports other than Chromium.

WebCore.gypi:
storage/StorageEventDispatcher.h: Added.

12:15 PM Changeset in webkit [48891] by eric@webkit.org

109 edits in trunk/LayoutTests

2009-09-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Kilzer.

Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=12140

Change the URLs in dumpAsText tests.

editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
editing/deleting/delete-all-text-in-text-field-assertion.html:
fast/dom/Document/doc-open-while-parsing.html:
fast/dom/Document/document-reopen.html:
fast/dom/Element/setAttribute-case-insensitivity.html:
fast/dom/HTMLHeadElement/head-check.html:
fast/dom/HTMLImageElement/image-without-renderer-width-expected.txt:
fast/dom/HTMLImageElement/image-without-renderer-width.html:
fast/dom/HTMLScriptElement/script-load-events-expected.txt:
fast/dom/HTMLScriptElement/script-load-events.html:
fast/dom/clone-node-form-elements-with-attr.html:
fast/dom/document-dir-property-expected.txt:
fast/dom/document-dir-property.html:
fast/dom/everything-to-string.html:
fast/dom/generic-form-element-assert-expected.txt:
fast/dom/generic-form-element-assert.html:
fast/dom/inner-text-rtl-expected.txt:
fast/dom/inner-text-rtl.html:
fast/dom/navigator-vendorSub.html:
fast/dom/option-properties-expected.txt:
fast/dom/option-properties.html:
fast/dom/replace-child-siblings-expected.txt:
fast/dom/replace-child-siblings.html:
fast/dom/replace-first-child.html:
fast/dom/setAttribute-using-initial-input-value.html:
fast/dom/space-to-text.html:
fast/dynamic/hovered-detach-expected.txt:
fast/dynamic/hovered-detach.html:
fast/encoding/charset-koi8-u.html:
fast/encoding/css-charset-dom.html:
fast/encoding/css-charset-evil.html:
fast/encoding/css-charset.html:
fast/encoding/latin1-winlatin.html:
fast/encoding/mispositioned-meta.html:
fast/encoding/percent-escaping.html:
fast/encoding/pseudo-xml-2.html:
fast/encoding/pseudo-xml-3.html:
fast/encoding/pseudo-xml-4.html:
fast/encoding/pseudo-xml.html:
fast/events/init-event-null-view.html:
fast/events/mouseover-mouseout.html:
fast/events/mouseover-mouseout2.html:
fast/events/onload-webkit-before-webcore.html:
fast/forms/button-in-forms-collection.html:
fast/forms/document-write.html:
fast/forms/domstring-replace-crash-expected.txt:
fast/forms/domstring-replace-crash.html:
fast/forms/element-by-name.html:
fast/forms/empty-get.html:
fast/forms/form-data-encoding-normalization-overrun.html:
fast/forms/radio-button-no-change-event.html:
fast/forms/selected-index-assert-expected.txt:
fast/forms/selected-index-assert.html:
fast/forms/textarea-hard-linewrap-empty-expected.txt:
fast/forms/textarea-hard-linewrap-empty.html:
fast/forms/textfield-focus-out-expected.txt:
fast/forms/textfield-focus-out.html:
fast/frames/empty-frame-document-expected.txt:
fast/frames/empty-frame-document.html:
fast/frames/frame-name-reset.html:
fast/frames/frame-set-same-location.html:
fast/frames/frame-set-same-src.html:
fast/frames/frameElement-widthheight.html:
fast/frames/iframe-name-and-id-expected.txt:
fast/frames/iframe-name-and-id.html:
fast/frames/iframe-set-same-location.html:
fast/frames/iframe-set-same-src.html:
fast/frames/repaint-display-none-crash-expected.txt:
fast/frames/repaint-display-none-crash.html:
fast/js/exception-linenums-in-html-2.html:
fast/js/missing-title-end-tag-js.html:
fast/loader/link-no-URL.html:
fast/loader/url-strip-cr-lf-tab.html:
fast/overflow/generated-content-crash-expected.txt:
fast/overflow/generated-content-crash.html:
fast/parser/number-sign-in-map-name.html:
fast/parser/remove-current-node-parent.html:
fast/parser/script-after-frameset-assert.html:
fast/tokenizer/image-empty-crash-expected.txt:
fast/tokenizer/image-empty-crash.html:
fast/tokenizer/nested-cached-scripts-expected.txt:
fast/tokenizer/nested-cached-scripts.html:
fast/tokenizer/write-unclosed-script-expected.txt:
fast/tokenizer/write-unclosed-script.html:
fast/xsl/transformToFragment-XML-declaration.html:
http/tests/misc/text-refresh.html:
http/tests/plugins/npapi-response-headers.html:
http/tests/uri/utf8-path.html:
http/tests/xmlhttprequest/cache-override.html:
http/tests/xmlhttprequest/event-listener-gc-expected.txt:
http/tests/xmlhttprequest/event-listener-gc.html:
http/tests/xmlhttprequest/event-target.html:
http/tests/xmlhttprequest/frame-load-cancelled-abort.html:
http/tests/xmlhttprequest/interactive-state.html:
http/tests/xmlhttprequest/methods-async.html:
http/tests/xmlhttprequest/methods-lower-case.html:
http/tests/xmlhttprequest/methods.html:
http/tests/xmlhttprequest/post-content-type.html:
http/tests/xmlhttprequest/readystatechange.html:
http/tests/xmlhttprequest/supported-xml-content-types.html:
http/tests/xmlhttprequest/xhr-onunload.html:
http/tests/xmlhttprequest/zero-length-response.html:
platform/mac/fast/events/objc-event-api.html:
platform/mac/fast/events/objc-keyboard-event-creation.html:
plugins/get-empty-url.html:
plugins/geturl-replace-query.html:
plugins/invoke.html:
plugins/mouse-events.html:

12:01 PM Changeset in webkit [48890] by oliver@apple.com

1 edit
1 add in trunk/WebCore

Adding file missed in previous commit.

11:51 AM Changeset in webkit [48889] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-29 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

[V8] Correct an issue with XMLHttpRequest attribute event listeners never being cleared.
https://bugs.webkit.org/show_bug.cgi?id=29888

Test: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-abort-readyState-shouldDispatchEvent.html

bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener): Added isAttribute parameter. (WebCore::ACCESSOR_SETTER): Made all event listener setters create attribute listeners. (WebCore::CALLBACK_FUNC_DECL): Made addEventListener create object listener.

11:40 AM Changeset in webkit [48888] by oliver@apple.com

3 edits in trunk/WebCore

[GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
https://bugs.webkit.org/show_bug.cgi?id=29654

Patch by Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Eric Seidel

Added an additional manual-test for this issue to the existing Gtk
cursor image test.

11:39 AM Changeset in webkit [48887] by ap@apple.com

6 edits in trunk/WebCore

Reviewed by Timothy Hatcher.

Build fix - pass a proper ScriptExecutipnContext to getEventListenerHandlerBody()

bindings/js/ScriptEventListener.cpp: (WebCore::getEventListenerHandlerBody):
bindings/js/ScriptEventListener.h:
bindings/v8/ScriptEventListener.cpp: (WebCore::getEventListenerHandlerBody):
bindings/v8/ScriptEventListener.h:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForEventListener):

11:37 AM Changeset in webkit [48886] by Nate Chapin

4 edits
2 adds in trunk

2009-09-29 Nate Chapin <Nate Chapin>

Reviewed by Eric Seidel.

Ensure that we don't scroll lock to an anchor node after a
user-initiated scroll, even if that scroll doesn't propagate
all the way up to FrameView.

Test: fast/events/node-event-anchor-lock.html

11:12 AM Changeset in webkit [48885] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Windows build fix: export a new symbol.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

11:05 AM Changeset in webkit [48884] by ap@apple.com

35 edits
10 adds in trunk

Reviewed by Darin Adler and Sam Weinig.

Onclick not fired for an element copied with cloneContents() or cloneNode()
https://bugs.webkit.org/show_bug.cgi?id=25130

The change here is that JS event listeners don't keep a reference to a global object from
where they were created, and instead take it as a parameter when parsing source code. Also,
the listener creation won't fail just because it happens for an element in a frameless
document.
Thus, moving nodes between documents no longer results in having incorrect registered
lazy event listeners on them.

Tests: fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html

fast/events/attribute-listener-cloned-from-frameless-doc-context.html
fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
fast/events/attribute-listener-extracted-from-frameless-doc-context.html

bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): Don't take a reference to JSDOMGlobalObject. (WebCore::JSEventListener::jsFunction): Take ScriptExecutionContext as a parameter for getting to JSDOMGlobalObject. It's not used in base class, but is in JSLazyEventListner. (WebCore::JSEventListener::markJSFunction): Don't mark the global object. (WebCore::JSEventListener::handleEvent): Get global object from ScriptExecutionContext. (WebCore::JSEventListener::reportError): Ditto.

bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): Don't keep a reference to JSDOMGlobalObject.

bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Listener creation was split between this function and ScriptEventListener; moved it here, as JS global object can be different now.

bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): Keep source URL, which can not be determined at parsing time.

bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Moved code for listener creation to JSLazyEventListener. XSSAuditor code remains here, because tests expect that errors are logged at document parsing time, and because I don't know what other side effects moving it vould have.

dom/EventListener.h: handleEvent() and reportError() now take ScriptExecutionContext, because JSC needs a global context here.

bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener):
bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
bindings/js/JSEventSourceCustom.cpp: (WebCore::JSEventSource::addEventListener): (WebCore::JSEventSource::removeEventListener):
bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
bindings/objc/ObjCEventListener.h:
bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
bindings/scripts/CodeGeneratorJS.pm:
dom/EventTarget.cpp: (WebCore::EventTarget::fireEventListeners):
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::handleEvent):
inspector/InspectorDOMAgent.h:
inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent):
inspector/InspectorDOMStorageResource.h:
loader/ImageDocument.cpp: (WebCore::ImageEventListener::handleEvent):
svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::handleEvent):
workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException): Don't pass global object to JSEventListener::create(), which no longer needs it. Note that some of these functions still have an early return for null global object, which can probably be removed in a later patch. Pass ScriptExecutionContext to EventListener methods that now need it.

bindings/scripts/CodeGeneratorCOM.pm: Don't force EventTarget implementation on Node - it doesn't work yet (it didn't quite work before this patch, too, because it assumed that any object implementing EventTarget COM interface originated from WebCore).

dom/EventListener.idl: Just like in ObjC, EventListener should be a pure interface in COM bindings.

WebKit/win:

DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now.

WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp.

10:54 AM Changeset in webkit [48883] by ggaren@apple.com

10 edits in trunk

Removed virtual destructor from JSGlobalObjectData to eliminate pointer
fix-ups when accessing JSGlobalObject::d.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
Reviewed by Sam Weinig.

JavaScriptCore:

Replaced with an explicit destructor function pointer.

6% speedup on bench-alloc-nonretained.js.

JavaScriptCore.exp:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::destroyJSGlobalObjectData):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
(JSC::JSGlobalObject::JSGlobalObject):

JavaScriptGlue:

Replaced with an explicit destructor function pointer.

JSRun.cpp:

(JSGlueGlobalObject::destroyData):

JSRun.h:

(JSGlueGlobalObject::Data::Data):

WebCore:

Replaced with an explicit destructor function pointer.

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::destroyJSDOMGlobalObjectData):

bindings/js/JSDOMGlobalObject.h:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):

10:44 AM Changeset in webkit [48882] by kenneth@webkit.org

2 edits in trunk/WebCore

The code for showing error pages when the response was
a 401/403/404, was not actually doing so. This patch
fixes that.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):

9:43 AM Changeset in webkit [48881] by mitz@apple.com

2 edits in trunk/WebKitTools

Remove copying of unnecessary or nonexistent files from the ImageDiff
post-build event.

Reviewed by Adam Roben.

DumpRenderTree/win/ImageDiff.vcproj:

9:19 AM Changeset in webkit [48880] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-09-29 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by David Kilzer.

[Qt] Make build-webkit script work on Windows
https://bugs.webkit.org/show_bug.cgi?id=29802

Scripts/run-webkit-tests:
Scripts/webkitdirs.pm:
- Removed unnecessary -p switch for mkdir on Windows.
- Use canonical path, which uses slashes or backslashes depends on platform.
- isWindows() only test for Windows and not for Cyqwin.

9:19 AM Changeset in webkit [48879] by ap@apple.com

7 edits in trunk

Reviewed by Brady Eidson.

<rdar://problem/7259965> REGRESSION: http/tests/xmlhttprequest/cross-origin-authorization.html
is failing/crashing intermittently
https://bugs.webkit.org/show_bug.cgi?id=29322

This was caused by CStringBuffer::encodeBase64() returning a buffer that wasn't zero terminated.
The code had other issues as well, so I removed it altogether:

it claimed to avoid some buffer copies, but it didn't;
and I don't think that base64 encoding should be part of CString interface.

WebCore:

platform/network/mac/ResourceHandleMac.mm: (WebCore::encodeBasicAuthorization): Encode username and password using Base64.h directly. (WebCore::ResourceHandle::start): Use encodeBasicAuthorization(). (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Ditto. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Extended logging to synchronous case. (-[WebCoreSynchronousLoader connectionShouldUseCredentialStorage:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto. (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto. (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.

platform/network/cf/ResourceHandleCFNet.cpp: Matched Mac changes.

platform/text/CString.cpp:
platform/text/CString.h: (WebCore::CStringBuffer::create): (WebCore::CStringBuffer::CStringBuffer): Removed code that was added for Base64 in r48363.

LayoutTests:

http/tests/xmlhttprequest/cross-origin-authorization.html: While at it, made the test detect more error conditions

9:10 AM Changeset in webkit [48878] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by David Kilzer.

[Qt] Assert messages prints visible in Symbian
https://bugs.webkit.org/show_bug.cgi?id=29808

Asserts use vprintf to print the messages to stderr.
In Symbian Open C it is not possible to see stderr so
I routed the messages to stdout instead.

wtf/Assertions.cpp:

8:18 AM Changeset in webkit [48877] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not set a non-default parent window for child widgets. We are
just doing the same than the default path does, and on top of that
if the widget's window changes (for example, during DnD widgets
are usually unrealized/realized) the child widget will we left
pointing to a dead window.

For examples of crashers caused by this see
https://bugzilla.gnome.org/show_bug.cgi?id=596397 and
https://bugzilla.gnome.org/show_bug.cgi?id=596398

webkit/webkitwebview.cpp: (webkit_web_view_container_add):

8:00 AM Changeset in webkit [48876] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-29 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Fix typo in Localizations.cpp

https://bugs.webkit.org/show_bug.cgi?id=29872

platform/qt/Localizations.cpp: (WebCore::localizedMediaControlElementHelpText):

7:45 AM Changeset in webkit [48875] by Simon Hausmann

2 edits in trunk/WebCore

Make the XSLT conditional in DOMWindow.idl's xsltProcessor
attribute conditional in the generated files, similar to
r44116.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-29
Reviewed by Tor Arne Vestbø.

page/DOMWindow.idl:

7:40 AM Changeset in webkit [48874] by zoltan@webkit.org

2 edits in trunk/WebKitTools

2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Fix time measurement in build-webkit after refactoring done in r48853.

Scripts/build-webkit:

7:25 AM Changeset in webkit [48873] by vestbo@webkit.org

391 edits in trunk

[Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.

This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-29
Reviewed by Tor Arne Vestbø.

Done together with Renata Hodovan <renata.hodovan@stud.u-szeged.hu>

7:06 AM Changeset in webkit [48872] by Simon Hausmann

2 edits in trunk/WebKit/qt

https://bugs.webkit.org/show_bug.cgi?id=29844

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-09-29
Reviewed by Simon Hausmann.

QWebPage dependency autotest fix.

Fix for database() autotest. All opened databases should be removed at
end of test.

tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::database):

7:06 AM Changeset in webkit [48871] by Simon Hausmann

3 edits in trunk/WebKit/qt

Some QWebHistory and QWebPage autotest crash fixes.

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2009-09-29
Reviewed by Simon Hausmann.

Some checking for m_mainFrame were added. MainFrame should be created
at some point of QWebPage live cicle.

https://bugs.webkit.org/show_bug.cgi?id=29803

Api/qwebpage.cpp:

(QWebPage::~QWebPage):
(QWebPage::currentFrame):
(QWebPage::history):
(QWebPage::selectedText):
(QWebPage::updatePositionDependentActions):

tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::crashTests_LazyInitializationOfMainFrame):

6:55 AM Changeset in webkit [48870] by kenneth@webkit.org

7 edits in trunk

WebCore: Use the ResourceError as it is supposed to and handle
not HTTP errors from QNetworkReply.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

Thanks to Adam Roben for his input.

platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::finish):

WebKit/qt: Implement QWebPage Extension for error pages, incl.
an example on how to use it in QtLauncher.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-29
Reviewed by Simon Hausmann.

Correct our use of ResourceError.

Api/qwebpage.h:

(ExtensionOption::):
(ExtensionOption::ErrorPageExtensionReturn::ErrorPageExtensionReturn):

QtLauncher/main.cpp:

(WebPage::supportsExtension):
(MainWindow::MainWindow):
(MainWindow::selectElements):
(WebPage::extension):

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::cancelledError):
(WebCore::FrameLoaderClientQt::blockedError):
(WebCore::FrameLoaderClientQt::cannotShowURLError):
(WebCore::FrameLoaderClientQt::interruptForPolicyChangeError):
(WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientQt::fileDoesNotExistError):
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
(WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFailLoad):

WebCoreSupport/FrameLoaderClientQt.h:

5:20 AM Changeset in webkit [48869] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Darin Adler.

[Qt] Symbian CRASH macro implementation

Added Symbian specific crash macro that
stops to crash line if JIT debugging is used.
Additional differentiation of access violation
(KERN-EXEC 3) and CRASH panic.

wtf/Assertions.h:

4:43 AM Changeset in webkit [48868] by zoltan@webkit.org

2 edits in trunk/LayoutTests

2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Update Skipped list after test refactoring done in r48806.

platform/qt/Skipped:

3:15 AM QtWebKitContrib edited by Simon Hausmann

(diff)

3:12 AM QtWebKitTodo edited by Simon Hausmann

(diff)

3:11 AM QtWebKitTodo edited by Simon Hausmann

(diff)

2:56 AM Changeset in webkit [48867] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-09-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Unskip the passing tests that make use of eventSender.contextClick().
https://bugs.webkit.org/show_bug.cgi?id=29821

platform/qt/Skipped:

2:53 AM Changeset in webkit [48866] by pfeldman@chromium.org

6 edits in trunk/WebCore

2009-09-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Encapsulate JS listeners specifics into ScriptEventListener.

https://bugs.webkit.org/show_bug.cgi?id=29816

bindings/js/ScriptEventListener.cpp: (WebCore::getEventListenerHandlerBody):
bindings/js/ScriptEventListener.h:
bindings/v8/ScriptEventListener.cpp: (WebCore::getEventListenerHandlerBody):
bindings/v8/ScriptEventListener.h:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForEventListener):

2:48 AM Changeset in webkit [48865] by xan@webkit.org

2 edits in trunk/WebCore

2009-09-29 Xan Lopez <xlopez@igalia.com>

Unreviewed attempt to fix the build.

page/Settings.cpp: (WebCore::Settings::Settings):

2:48 AM Changeset in webkit [48864] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-09-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement eventSender.contextClick().
https://bugs.webkit.org/show_bug.cgi?id=29821

DumpRenderTree/qt/jsobjects.cpp: (EventSender::contextClick):
DumpRenderTree/qt/jsobjects.h:

1:57 AM Changeset in webkit [48863] by ukai@chromium.org

5 edits in trunk/LayoutTests

2009-09-29 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed. Fix 4 layout test failures by webkit r48861.
http://bugs.webkit.org/show_bug.cgi?id=29840

r48861 introduced experimentalWebSocketsEnabled, and false by default.
When experimentalWebSocketsEnabled is false, window.WebSocket is
undefined, instead of a constructor.

fast/dom/Window/window-properties-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/dom/prototype-inheritance-expected.txt:
fast/js/global-constructors-expected.txt:

12:22 AM Changeset in webkit [48862] by bweinstein@apple.com

1 edit in trunk/WebKit/win/WebPreferences.cpp

Fix the build by fixing a typo.

12:02 AM Changeset in webkit [48861] by ukai@chromium.org

21 edits in trunk

2009-09-28 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Add experimentalWebSocketsEnabled in Settings.
https://bugs.webkit.org/show_bug.cgi?id=28941

WebCore.base.exp:
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webSocket):
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor):
bindings/v8/custom/V8WebSocketCustom.cpp:
page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setExperimentalWebSocketsEnabled):
page/Settings.h: (WebCore::Settings::experimentalWebSocketsEnabled):

2009-09-28 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Add experimentalWebSocketsEnabled in WebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=28941

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences experimentalWebSocketsEnabled]): (-[WebPreferences setExperimentalWebSocketsEnabled:]):
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2009-09-28 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Add experimentalWebSocketsEnabled in WebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=28941

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setExperimentalWebSocketsEnabled): (WebPreferences::experimentalWebSocketsEnabled):
WebPreferences.h:
WebView.cpp: (WebView::notifyPreferencesChanged): (core):

2009-09-28 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Add experimentalWebSocketsEnabled in WebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=28941

DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

Sep 28, 2009:

10:51 PM Changeset in webkit [48860] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Fix the PowerPC build.

JavaScriptCore.exp:

10:42 PM Changeset in webkit [48859] by ukai@chromium.org

2 edits
2 adds in trunk/WebCore

2009-09-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

Add platform code to support WebSocket for chromium.
https://bugs.webkit.org/show_bug.cgi?id=29171

To build within chromium tree, it requires a patch in bug 29174.
Real implementation will be landed in chromium tree.

WebCore.gypi:
platform/network/chromium/SocketStreamError.h: Added. (WebCore::SocketStreamError::SocketStreamError):
platform/network/chromium/SocketStreamHandle.h: Added. (WebCore::SocketStreamHandle::create):

10:16 PM Changeset in webkit [48858] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-09-29 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Eric Seidel.

[Gtk] Crash when saving a password
https://bugs.webkit.org/show_bug.cgi?id=28070

Disconnect the 'got-headers' callback when we are done with
it. The signal can be emitted more than once if the message is
retransmitted, but each time that happens authData is created
again and a new callback connected, so we have to get rid of the
old one (which will crash because we free authData).

webkit/webkitsoupauthdialog.c: (save_password_callback):

9:57 PM Changeset in webkit [48857] by mrowe@apple.com

1 edit in tags/Safari-6531.5.1/JavaScriptCore/Configurations/Version.xcconfig

Versioning.

9:56 PM Changeset in webkit [48856] by mrowe@apple.com

2 edits in tags/Safari-6531.5.1/JavaScriptCore

Merge r48854.

9:53 PM Changeset in webkit [48855] by mrowe@apple.com

1 copy in tags/Safari-6531.5.1

New tag.

9:51 PM Changeset in webkit [48854] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

<rdar://problem/7195704> JavaScriptCore fails to mark registers when built for x86_64 using LLVM GCC.

Reviewed by Gavin Barraclough.

runtime/Collector.cpp:

(JSC::Heap::markCurrentThreadConservatively): Force jmp_buf to use the appropriate alignment for a pointer
to ensure that we correctly interpret the contents of registers during marking.

9:01 PM Changeset in webkit [48853] by ddkilzer@apple.com

4 edits
1 add in trunk/WebKitTools

2009-09-28 Yaar Schnitman <yaar@chromium.org>

Reviewed by David Kilzer.

Integrated chromium port building into webkit tools update-webkit and
build-webkit.

https://bugs.webkit.org/show_bug.cgi?id=29749

Scripts/build-webkit: When --chromium is specified, will build the chromium port (currently only Mac is supported).
Scripts/update-webkit: When --chromium is specified, delegates to update-webkit-chromium.
Scripts/webkitdirs.pm: Added chromium specific defs.
Scripts/update-webkit-chromium: Uses gclient and gyp to fetch chromium port's dependencies and update its project files.

6:48 PM Changeset in webkit [48852] by ukai@chromium.org

2 edits in trunk/WebKitTools

2009-09-28 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Add myself to list of committers.

Scripts/modules/committers.py:

6:10 PM Changeset in webkit [48851] by eric@webkit.org

2 edits
5 adds in trunk/LayoutTests

2009-09-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

[Gtk][Layout tests] Generate results for css3 tests
https://bugs.webkit.org/show_bug.cgi?id=29784

Add results for css3 tests and enable these tests in the Skipped.

platform/gtk/Skipped:
platform/gtk/css3/css3-modsel-33-expected.txt: Added.
platform/gtk/css3/css3-modsel-35-expected.txt: Added.
platform/gtk/css3/css3-modsel-36-expected.txt: Added.
platform/gtk/css3/css3-modsel-37-expected.txt: Added.

5:47 PM Changeset in webkit [48850] by eric@webkit.org

2 edits
2 adds in trunk/LayoutTests

2009-09-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

[Gtk][Layout tests] Generate results for transitions tests
https://bugs.webkit.org/show_bug.cgi?id=29786

Add results for transitions tests and enable these tests in the Skipped.

platform/gtk/Skipped:
platform/gtk/transitions/transition-drt-api-expected.txt: Added.

5:35 PM Changeset in webkit [48849] by eric@webkit.org

2 edits
3 adds in trunk/LayoutTests

2009-09-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

[Gtk][Layout tests] Generate results for animations tests
https://bugs.webkit.org/show_bug.cgi?id=29783

Add results for animations tests and enable these tests in the Skipped.

platform/gtk/Skipped:
platform/gtk/animations/animation-drt-api-expected.txt: Added.
platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt: Added.

5:28 PM Changeset in webkit [48848] by mitz@apple.com

2 edits in trunk/WebCore

<rdar://problem/7157288> Crash in RenderStyle::computedLineHeight()
when Times New Roman is not installed

Reviewed by Sam Weinig.

platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::getLastResortFallbackFont): If Times New Roman is
not available, use the Windows default GUI font.

5:27 PM Changeset in webkit [48847] by eric@webkit.org

2 edits
6 adds in trunk/LayoutTests

2009-09-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by David Kilzer.

[Gtk][Layout tests] Generate results for transforms tests
https://bugs.webkit.org/show_bug.cgi?id=29785

Add results for transforms tests and enable these tests in the Skipped.

platform/gtk/Skipped:
platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
platform/gtk/transforms/2d/transform-borderbox-expected.txt: Added.
platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt: Added.
platform/gtk/transforms/no_transform_hit_testing-expected.txt: Added.

4:56 PM Changeset in webkit [48846] by jianli@chromium.org

4 edits in trunk/WebCore

Do not add platform-specific methods to cross-platform header
FileSystem.h per Darin's feedback for 29109.
https://bugs.webkit.org/show_bug.cgi?id=29830

Reviewed by David Levin.

platform/FileSystem.h:
platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):

platform/chromium/FileSystemChromium.cpp:

4:35 PM WebKit Team edited by ukai@chromium.org

add ukai (diff)

4:33 PM Changeset in webkit [48845] by eric@webkit.org

3 edits in trunk/WebCore

2009-09-28 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Register Chromium's VFSs with a proper sqlite3_io_methods
finder. This should only affect the POSIX implementation. The
Windows change is included for consistency and in case sqlite
starts using something similar in its Windows VFS in the future.

https://bugs.webkit.org/show_bug.cgi?id=29743

platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):

4:25 PM Changeset in webkit [48844] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-09-28 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Update the Skipped list after adding XSLT support.
https://bugs.webkit.org/show_bug.cgi?id=29817

Remove the tests that are passing now and skip these that are not,
with a reason of failure for each of them.

platform/qt/Skipped:

3:58 PM Changeset in webkit [48843] by ddkilzer@apple.com

2 edits in trunk/WebKitSite

2009-09-28 Alex Milowski <alex@milowski.com>

<http://webkit.org/b/29098> Update to MathML project webpage

Reviewed by David Kilzer.

Updated MathML project page and added link to Wiki page.

projects/mathml/index.html:

3:50 PM Changeset in webkit [48842] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-09-28 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

11 transforms/3d tests failing on the Leopard Debug bot after r48833
https://bugs.webkit.org/show_bug.cgi?id=29828

Leopard has HW compositing disabled until rdar://problem/7228836 can be fixed.
So skip tests which depend on it being enabled per Simon's request.

platform/mac-leopard/Skipped:

3:25 PM Changeset in webkit [48841] by Nate Chapin

2 edits in trunk/WebCore

2009-09-28 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Change the V8 bindings' handling of window.toString(),
so we return [object DOMWindow] (like JSC), not [object global].

https://bugs.webkit.org/show_bug.cgi?id=29742

This will fix a couple of Chromium port test failures and enable us to
use the default expectations for a bunch more.

3:23 PM Changeset in webkit [48840] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Windows build fix: added new exports.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

3:16 PM Changeset in webkit [48839] by mrowe@apple.com

4 edits in trunk

Roll out r48825. It causes build failures by calling an undefined function from within RefPtr.h.

3:06 PM Changeset in webkit [48838] by Nate Chapin

2 edits in trunk/WebCore

2009-09-28 Nate Chapin <Nate Chapin>

Rubber stamped by David Levin.

Chromium build fix, add back in #include of V8Proxy.h in V8WebKitPointConstructor.cpp.

bindings/v8/custom/V8WebKitPointConstructor.cpp: Re-include V8Proxy.h.

3:06 PM Changeset in webkit [48837] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Windows build fix: removed exports that no longer exist.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

2:45 PM Changeset in webkit [48836] by ggaren@apple.com

104 edits in trunk

NotNullPassRefPtr: smart pointer optimized for passing references that are not null
https://bugs.webkit.org/show_bug.cgi?id=29822

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-28
Reviewed by Darin Adler.

JavaScriptCore:

Added NotNullPassRefPtr, and deployed it in all places that initialize
JavaScript objects.

2.2% speedup on bench-allocate-nonretained.js.

API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::JSCallbackConstructor):

API/JSCallbackConstructor.h:
API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject::JSCallbackObject):

JavaScriptCore.exp:
bytecode/CodeBlock.h:

(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::addFunctionExpr):

runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::ArrayConstructor):

runtime/ArrayConstructor.h:
runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::ArrayPrototype):

runtime/ArrayPrototype.h:
runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::BooleanConstructor):

runtime/BooleanConstructor.h:
runtime/BooleanObject.cpp:

(JSC::BooleanObject::BooleanObject):

runtime/BooleanObject.h:
runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):

runtime/BooleanPrototype.h:
runtime/DateConstructor.cpp:

(JSC::DateConstructor::DateConstructor):

runtime/DateConstructor.h:
runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

runtime/DateInstance.h:
runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype):

runtime/DatePrototype.h:
runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::ErrorConstructor):

runtime/ErrorConstructor.h:
runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

runtime/ErrorInstance.h:
runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

runtime/ErrorPrototype.h:
runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::FunctionConstructor):

runtime/FunctionConstructor.h:
runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):

runtime/FunctionPrototype.h:
runtime/GlobalEvalFunction.cpp:

(JSC::GlobalEvalFunction::GlobalEvalFunction):

runtime/GlobalEvalFunction.h:
runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):

runtime/InternalFunction.h:

(JSC::InternalFunction::InternalFunction):

runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):

runtime/JSActivation.h:

(JSC::JSActivation::JSActivationData::JSActivationData):

runtime/JSArray.cpp:

(JSC::JSArray::JSArray):

runtime/JSArray.h:
runtime/JSByteArray.cpp:

(JSC::JSByteArray::JSByteArray):

runtime/JSByteArray.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):

runtime/JSFunction.h:
runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::JSGlobalObject):

runtime/JSONObject.h:

(JSC::JSONObject::JSONObject):

runtime/JSObject.h:

(JSC::JSObject::JSObject):
(JSC::JSObject::setStructure):

runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):

runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::JSWrapperObject):

runtime/MathObject.cpp:

(JSC::MathObject::MathObject):

runtime/MathObject.h:
runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

runtime/NativeErrorConstructor.h:
runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):

runtime/NativeErrorPrototype.h:
runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::NumberConstructor):

runtime/NumberConstructor.h:
runtime/NumberObject.cpp:

(JSC::NumberObject::NumberObject):

runtime/NumberObject.h:
runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):

runtime/NumberPrototype.h:
runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::ObjectConstructor):

runtime/ObjectConstructor.h:
runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):

runtime/ObjectPrototype.h:
runtime/PropertyNameArray.h:

(JSC::PropertyNameArrayData::setCachedPrototypeChain):

runtime/PrototypeFunction.cpp:

(JSC::PrototypeFunction::PrototypeFunction):

runtime/PrototypeFunction.h:
runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):

runtime/RegExpConstructor.h:
runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):

runtime/RegExpObject.h:

(JSC::RegExpObject::RegExpObjectData::RegExpObjectData):

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):

runtime/RegExpPrototype.h:
runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

runtime/StringConstructor.h:
runtime/StringObject.cpp:

(JSC::StringObject::StringObject):

runtime/StringObject.h:
runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):

runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):

runtime/StringPrototype.h:
wtf/PassRefPtr.h:

(WTF::NotNullPassRefPtr::NotNullPassRefPtr):
(WTF::NotNullPassRefPtr::~NotNullPassRefPtr):
(WTF::NotNullPassRefPtr::get):
(WTF::NotNullPassRefPtr::clear):
(WTF::NotNullPassRefPtr::releaseRef):
(WTF::NotNullPassRefPtr::operator*):
(WTF::NotNullPassRefPtr::operator->):
(WTF::NotNullPassRefPtr::operator!):
(WTF::NotNullPassRefPtr::operator UnspecifiedBoolType):

wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::operator==):

WebCore:

Added NotNullPassRefPtr, and deployed it in all places that initialize
JavaScript objects.

bindings/js/DOMObjectWithSVGContext.h:

(WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):

bindings/js/JSDOMBinding.cpp:

(WebCore::cacheDOMStructure):

bindings/js/JSDOMBinding.h:

(WebCore::DOMObject::DOMObject):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):

bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):

bindings/js/JSDOMWindowBase.h:
bindings/js/JSHTMLAllCollection.h:

(WebCore::JSHTMLAllCollection::JSHTMLAllCollection):

bindings/js/JSInspectedObjectWrapper.cpp:

(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):

bindings/js/JSInspectedObjectWrapper.h:
bindings/js/JSInspectorCallbackWrapper.cpp:

(WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):

bindings/js/JSInspectorCallbackWrapper.h:
bindings/js/JSQuarantinedObjectWrapper.cpp:

(WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):

bindings/js/JSQuarantinedObjectWrapper.h:
bindings/js/JSWorkerContextBase.cpp:

(WebCore::JSWorkerContextBase::JSWorkerContextBase):

bindings/js/JSWorkerContextBase.h:
bindings/scripts/CodeGeneratorJS.pm:
bridge/runtime_object.cpp:

(JSC::RuntimeObjectImp::RuntimeObjectImp):

bridge/runtime_object.h:

2:38 PM Changeset in webkit [48835] by eric@webkit.org

1 edit
1 add in trunk/LayoutTests

2009-09-28 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Add the expected result for the fast/xsl/document-function test.
https://bugs.webkit.org/show_bug.cgi?id=29817

platform/qt/fast/xsl/document-function-expected.txt: Added.

2:30 PM Changeset in webkit [48834] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-28 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Allow V8 to handle x/y parameters in a WebKitPoint constructor.
https://bugs.webkit.org/show_bug.cgi?id=29823

Fixes V8's handling of LayoutTests/fast/dom/Window/webkitConvertPoint.html

bindings/v8/custom/V8WebKitPointConstructor.cpp: Allow for x/y parameters in constructor.

2:22 PM Changeset in webkit [48833] by eric@webkit.org

4 edits
6 adds in trunk

2009-09-25 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
https://bugs.webkit.org/show_bug.cgi?id=28624

No longer skip media tests now that we're disabling hardware compositing instead.
Add leopard-specific results for 2 tests expected to fail with HW compositing disabled.

platform/mac-leopard/Skipped:
platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.checksum.
platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.png.
platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-02-expected.txt.
platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.checksum.
platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.png.
platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-tiger/fast/media/mq-transform-03-expected.txt.

2009-09-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Darin Adler.

run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
https://bugs.webkit.org/show_bug.cgi?id=29771

Scripts/run-webkit-tests:

1:57 PM Changeset in webkit [48832] by mrowe@apple.com

2 edits in trunk/WebCore

Fix the build by doing something approximating reasonableness in the Xcode project.

WebCore.xcodeproj/project.pbxproj:

1:55 PM Changeset in webkit [48831] by mitz@apple.com

2 edits in trunk/WebKit/mac

<rdar://problem/7240911> REGRESSION (r48586): Crash occurs when loading
a PDF

Reviewed by Anders Carlsson.

CGPDFObjectRef is not a CFTypeRef, and cannot be retained or released.
Its lifetime is managed by its container. Just use a Vector to store
CGPDFObjectRefs, relying on the CGPDFDocument to keep them alive.

WebView/WebPDFDocumentExtras.mm:

(appendValuesInPDFNameSubtreeToVector):
(getAllValuesInPDFNameTree):
(web_PDFDocumentAllScripts):

1:42 PM Changeset in webkit [48830] by oliver@apple.com

3 edits in trunk/JavaScriptCore

Hard dependency on SSE2 instruction set with JIT
https://bugs.webkit.org/show_bug.cgi?id=29779

Reviewed by Geoff Garen

Add floating point support checks to op_jfalse and op_jtrue, and
fix the logic for the slow case of op_add

1:41 PM Changeset in webkit [48829] by Simon Hausmann

2 edits in trunk/WebCore

Prospective Tiger build fix.

Patch by Simon Hausmann <Simon Hausmann> on 2009-09-28

WebCore.xcodeproj/project.pbxproj: Try to use unique IDs for the new files.

1:33 PM Changeset in webkit [48828] by pfeldman@chromium.org

6 edits in trunk/WebCore

2009-09-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add explicit frontend event for commit load.

https://bugs.webkit.org/show_bug.cgi?id=29814

inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCommitLoad):
inspector/InspectorFrontend.h:
inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDocument):
inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.didCommitLoad):

1:30 PM Changeset in webkit [48827] by eric@webkit.org

5 edits
2 adds in trunk

2009-09-28 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium port - recognize we are being built independently
of chromium and look for dependencies under webkit/chromium rather
than chromium/src.

https://bugs.webkit.org/show_bug.cgi?id=29722

JavaScriptCore.gyp/JavaScriptCore.gyp:

2009-09-28 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium port - recognize we are being built independently
of chromium and look for dependencies under webkit/chromium rather
than chromium/src.

https://bugs.webkit.org/show_bug.cgi?id=29722

WebCore.gyp/WebCore.gyp: See above. Also removed a few files from the sources list, since they are not supposed to be built here.

2009-09-28 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=29722

chromium/DEPS: Describes the chromium port's dependencies and is used by gclient to fetch them.
chromium/webkit.gyp: Currently only builds webcore but in the future will also build the webkit api.

1:11 PM Changeset in webkit [48826] by Simon Hausmann

17 edits
5 adds in trunk

[Qt] Implement XSLT support with QtXmlPatterns.
https://bugs.webkit.org/show_bug.cgi?id=28303

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.

JavaScriptCore:

wtf/Platform.h: Add a WTF_USE_QXMLQUERY #define.

WebCore:

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCoreSources.bkl:
dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setTransformSource):

dom/Document.h:

(WebCore::Document::transformSource):

dom/TransformSource.h: Added.

(WebCore::TransformSource::platformSource):

dom/TransformSourceLibxslt.cpp: Added.

(WebCore::TransformSource::TransformSource): Wraps a libxml2 document.
(WebCore::TransformSource::~TransformSource):

dom/TransformSourceQt.cpp: Added.

(WebCore::TransformSource::TransformSource): Wraps a plain string.
(WebCore::TransformSource::~TransformSource):

dom/XMLTokenizerLibxml2.cpp:

(WebCore::XMLTokenizer::doEnd):

dom/XMLTokenizerQt.cpp:

(WebCore::XMLTokenizer::doEnd):
(WebCore::XMLTokenizer::parseProcessingInstruction):

xml/XSLStyleSheet.h:

(WebCore::XSLStyleSheet::sheetString):

xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::document):

xml/XSLStyleSheetQt.cpp: Added.
xml/XSLTProcessor.h:
xml/XSLTProcessorLibxslt.cpp:

(WebCore::xmlDocPtrFromNode):

xml/XSLTProcessorQt.cpp: Added.

(WebCore::XSLTMessageHandler::XSLTMessageHandler): A subclass of QAbstractMessageHandler.
(WebCore::XSLTMessageHandler::handleMessage): Forwards all processor messages to the Console.
(WebCore::XSLTProcessor::transformToString): Uses QXmlQuery.

1:09 PM Changeset in webkit [48825] by eric@webkit.org

4 edits in trunk

2009-09-28 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=28054

Use derefInNotNull() to work around winscw compiler forward declaration bug
regarding templated classes.

The compiler bug is reported at
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.

The change should be reverted when the above bug is fixed in winscw compiler.

Add parenthesis around (RefPtr::*UnspecifiedBoolType) to make winscw compiler
work with the default UnSpecifiedBoolType() operator, which removes the winscw hack.

wtf/RefPtr.h: (WTF::RefPtr::~RefPtr): (WTF::RefPtr::clear): (WTF::RefPtr::operator UnspecifiedBoolType):

2009-09-28 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

Make JObjectWrapper::ref() and deref() public accessible to derefIfNull().

Will be reverted when the following winscw compiler bug is fixed.
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812

bridge/jni/jni_instance.h:

11:57 AM Changeset in webkit [48824] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Remove clear_cache which is an internal function of GCC
https://bugs.webkit.org/show_bug.cgi?id=28886

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-09-28
Reviewed by Simon Hausmann.

Although clear_cache is exported from GCC, this is an internal
function. GCC makes no promises about it.

jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

11:51 AM Changeset in webkit [48823] by eric@webkit.org

3 edits
1 move in trunk/LayoutTests

2009-09-28 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Move message-port-multi.js from resources to script-tests
https://bugs.webkit.org/show_bug.cgi?id=29798

fast/events/message-port-multi-expected.txt:
fast/events/message-port-multi.html:
fast/events/resources/message-port-multi.js: Removed.
fast/events/script-tests/message-port-multi.js: Added. (channel.port2.onmessage):

11:43 AM Changeset in webkit [48822] by eric@webkit.org

7 edits in trunk/WebCore

2009-09-28 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Delegate implementation of rendererIsNeeded() for media control elements to RenderTheme.

https://bugs.webkit.org/show_bug.cgi?id=28689

Covered by LayoutTests/media/video-no-audio.html

rendering/MediaControlElements.cpp: Removed subclass implementations of rendererIsNeeded(). (WebCore::MediaControlElement::rendererIsNeeded): Include calling shouldRenderMediaControlPart(). (WebCore::MediaControlInputElement::rendererIsNeeded): Include calling shouldRenderMediaControlPart().
rendering/MediaControlElements.h:
rendering/RenderTheme.cpp: (WebCore::RenderTheme::shouldRenderMediaControlPart): New method. Contains logic moved from subclass implementations of rendererIsNeeded().
rendering/RenderTheme.h:
rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Override to always render mute button.
rendering/RenderThemeChromiumSkia.h:

11:13 AM Changeset in webkit [48821] by jianli@chromium.org

5 edits in trunk/WebCore

[chromium] DragData::asURL should return file URL.
https://bugs.webkit.org/show_bug.cgi?id=29109

Reviewed by David Levin.

Tested by LayoutTests/fast/events/drag-to-navigate.html.

platform/FileSystem.h:
platform/chromium/ChromiumBridge.h:
platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):

platform/chromium/FileSystemChromium.cpp:

(WebCore::getAbsolutePath):
(WebCore::isDirectory):
(WebCore::filePathToURL):

10:57 AM Changeset in webkit [48820] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

[V8] Add a special case to handle index arguments, because we need to be
able to see if they're < 0.
https://bugs.webkit.org/show_bug.cgi?id=29810

Test: LayoutTests/dom/html/level1/core/hc_characterdataindexsizeerrdeletedatacountnegative.html

bindings/scripts/CodeGeneratorV8.pm: Added special case (matching CodeGeneratorJS.pm) for index arguments.

10:55 AM Changeset in webkit [48819] by weinig@apple.com

2 edits in trunk/JavaScriptCore

Fix an absolute path to somewhere in Oliver's machine to a relative path
for derived JSONObject.lut.h.

Reviewed by Oliver Hunt.

JavaScriptCore.xcodeproj/project.pbxproj:

9:34 AM Changeset in webkit [48818] by mitz@apple.com

2 edits in trunk/WebCore

Extend the MediaWiki/KHTMLFixes.css workaround to cover older MediaWiki versions
https://bugs.webkit.org/show_bug.cgi?id=29792

Reviewed by Darin Adler.

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet): If site specific hacks are
enabled, check if the linked style sheet is one of two versions of the
MediaWiki KHTMLFixes.css. If so, remove the offending rule.

9:29 AM Changeset in webkit [48817] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-09-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

[V8] Fix an error in type logic in CodeGeneratorV8.pm, where
unsigned ints are accidentally used as signed.
https://bugs.webkit.org/show_bug.cgi?id=29810

Test: LayoutTests/fast/forms/textarea-maxlength.html

bindings/scripts/CodeGeneratorV8.pm: Made sure "unsigned long" in IDL is properly generates on "unsigned" return value.

9:14 AM Changeset in webkit [48816] by Simon Fraser

6 edits
4 adds in trunk

2009-09-25 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

ASSERTION FAILED: !repaintContainer

repaintContainer == this

https://bugs.webkit.org/show_bug.cgi?id=29755

It's possible for RenderObject::container() to return an object that is higher
in the hierarchy than the repaintContainer that is being used to repaint an
object. For example, this can happen when running an accelerated opacity
transition on an element with a position:absolute parent, and a position:absolute child.

In this case we need to detect when RenderObject::container() will skip over
repaintContainer, and in that case adjust the coords to shift into repaintContainer's space.

Test: compositing/repaint/opacity-between-absolute.html

rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::computeRectForRepaint):
rendering/RenderInline.cpp: (WebCore::RenderInline::computeRectForRepaint):
rendering/RenderObject.cpp: (WebCore::RenderObject::container):
rendering/RenderObject.h:

8:06 AM Changeset in webkit [48815] by Simon Hausmann

6 edits
1 move in trunk/WebCore

Rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp.
https://bugs.webkit.org/show_bug.cgi?id=28303

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.

In preparation for adding XSLT support with QtXmlPatterns to the Qt
port, rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp as we will
have our own implementation which most likely will not share any code
with the current one.

Additionally, fix some coding style issues.

GNUmakefile.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
xml/XSLStyleSheet.cpp: Renamed to XSLStyleSheetLibxslt.cpp.
xml/XSLStyleSheetLibxslt.cpp: Added.

7:45 AM Changeset in webkit [48814] by Simon Hausmann

2 edits in trunk/WebCore

Prospective build fix for r48812.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-28
Forgot to remove the inline reset() implementation when reverting the indentation
changes in the file.

xml/XSLTProcessor.h:

7:40 AM Changeset in webkit [48813] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-09-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by nobody (trivial follow up fix), Joseph Pecoraro LGTM-ed.

Web Inspector: Follow up to r48809.
InspectorController.wrapObject should only be called on the inspectable page side.

https://bugs.webkit.org/show_bug.cgi?id=17429

inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update): (WebInspector.EventListenersSection): (WebInspector.EventListenersSection.prototype.update): (WebInspector.EventListenerBar): (WebInspector.EventListenerBar.prototype.update):

7:36 AM Changeset in webkit [48812] by Simon Hausmann

7 edits
1 copy in trunk/WebCore

Move the libxslt specific part of XSLTProcessor to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=28303

Patch by Jakub Wieczorek <faw217@gmail.com> on 2009-09-28
Reviewed by Simon Hausmann.

In preparation for adding XSLT support with QtXmlPatterns to the Qt
port, move the libxslt part of the XSLTProcessor implementation into
another file and leave the part that can be reused and shared.

Additionally, fix some coding style issues.

GNUmakefile.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource): Remove trailing whitespaces.
(WebCore::createFragmentFromSource): Remove trailing whitespaces.
(WebCore::XSLTProcessor::transformToFragment): Remove trailing whitespaces.
(WebCore::XSLTProcessor::reset): Moved out of the class definition.

xml/XSLTProcessorLibxslt.cpp: Added.

(WebCore::XSLTProcessor::genericErrorFunc): Moved.
(WebCore::XSLTProcessor::parseErrorFunc): Moved.
(WebCore::docLoaderFunc): Moved.
(WebCore::setXSLTLoadCallBack): Moved.
(WebCore::writeToVector): Moved.
(WebCore::saveResultToString): Moved.
(WebCore::xsltParamArrayFromParameterMap): Moved.
(WebCore::freeXsltParamArray): Moved.
(WebCore::xsltStylesheetPointer): Moved.
(WebCore::xmlDocPtrFromNode): Moved.
(WebCore::resultMIMEType): Moved.
(WebCore::XSLTProcessor::transformToString): Moved.

7:28 AM Changeset in webkit [48811] by staikos@webkit.org

1 edit in trunk/WebCore/svg/SVGUseElement.cpp

Minor correction to Copyright notice. Not reviewed.

6:35 AM Changeset in webkit [48810] by eric@webkit.org

3 edits
2 adds in trunk

2009-09-28 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Fix the crash of SVG that crashes when use a non-exist symbol
https://bugs.webkit.org/show_bug.cgi?id=27693

svg/custom/use-non-existing-symbol-crash-expected.txt: Added.
svg/custom/use-non-existing-symbol-crash.svg: Added.

2009-09-28 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Fix the crash of SVG that crashes when use a non-exist symbol
https://bugs.webkit.org/show_bug.cgi?id=27693

Test: svg/custom/use-non-existing-symbol-crash.svg

svg/SVGUseElement.cpp: (WebCore::shadowTreeContainsChangedNodes):

5:36 AM Changeset in webkit [48809] by pfeldman@chromium.org

21 edits
3 adds in trunk/WebCore

2009-09-28 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Inspector Should Show Event Listeners/Handlers Registered on each Node
https://bugs.webkit.org/show_bug.cgi?id=17429

Extracted a method from dispatchEvent to get the event ancestor chain

dom/Node.cpp: (WebCore::Node::eventAncestors): the extracted method (WebCore::Node::dispatchGenericEvent): use eventAncestors
dom/Node.h:

Asynchronous Flow For the Inspector, Backend -> DOM Agent -> Frontend
The DOMAgent's getEventListenersForNode handles the logic of finding
all the relevant listeners in the event flow.

inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getEventListenersForNode):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::buildObjectForEventListener): (WebCore::InspectorDOMAgent::buildObjectForNode): added localName
inspector/InspectorDOMAgent.h: (WebCore::EventListenerInfo::EventListenerInfo):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetEventListenersForNode):
inspector/InspectorFrontend.h: (WebCore::InspectorFrontend::scriptState):
inspector/front-end/DOMAgent.js: added localName to WebInspector.DOMNode from payload (WebInspector.EventListeners.getEventListenersForNodeAsync.mycallback): (WebInspector.EventListeners.getEventListenersForNodeAsync):

New Sidebar Pane in the Element's Panel
Includes Gear Menu for filtering the Event Listeners on the
"Selected Node Only" or "All Nodes"

inspector/front-end/ElementsPanel.js: Handles refreshing the Pane when necessary (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.updateEventListeners):
inspector/front-end/EventListenersSidebarPane.js: Added. (WebInspector.EventListenersSidebarPane): The 1st level in the Pane (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update): (WebInspector.EventListenersSection): The 2nd level in the Pane (WebInspector.EventListenersSection.prototype.update): filters on Preference (WebInspector.EventListenersSection.prototype.addListener): (WebInspector.EventListenerBar): The 3rd level in the Pane (WebInspector.EventListenerBar.prototype._getNodeDisplayName): (WebInspector.EventListenerBar.prototype._getFunctionDisplayName): (WebInspector.EventListenersSidebarPane.prototype._changeSetting): For the Gear Menu

Consolidated "appropriateSelectorForNode"

inspector/front-end/StylesSidebarPane.js:
inspector/front-end/utilities.js:

Miscellaneous Updates

English.lproj/localizedStrings.js: "Event Listeners", "No Event Listeners", "Selected Node Only", "All Nodes"
WebCore.gypi: included the new inspector files
WebCore.vcproj/WebCore.vcproj: included source files that were missing
inspector/front-end/Images/grayConnectorPoint.png: Added. Thanks to Timothy Hatcher.
inspector/front-end/Images/whiteConnectorPoint.png: Added. Thanks to Timothy Hatcher.
inspector/front-end/inspector.js: Preferences for the Gear Menu Event Listeners filter
inspector/front-end/inspector.css: reused as much as possible
inspector/front-end/inspector.html: include the new script
inspector/front-end/WebKit.qrc: included the new inspector files

4:16 AM Changeset in webkit [48808] by Simon Hausmann

2 edits in trunk/WebKit/qt

Compile fix with namespaced Qt.

Patch by Andre Poenitz <andre.poenitz@trolltech.com> on 2009-09-28
Reviewed by Simon Hausmann.

Api/qwebinspector_p.h:

2:17 AM Changeset in webkit [48807] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Add ARM version detection for Windows CE.

Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-28
Reviewed by Simon Hausmann.

wtf/Platform.h:

Sep 27, 2009:

9:49 PM WebKit Team edited by hamaji@chromium.org

(diff)

4:59 PM Changeset in webkit [48806] by weinig@apple.com

8 edits
6 moves
6 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29760
Implement CSSOM Range.getClientRects/getBoundingClientRect

Reviewed by Dan Bernstein.

Tests: fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport.html

fast/dom/Range/getBoundingClientRect.html
fast/dom/Range/getClientRects.html

dom/Range.cpp:

(WebCore::Range::getClientRects):
(WebCore::Range::getBoundingClientRect):
(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoom):
(WebCore::Range::getBorderAndTextQuads):

dom/Range.h:
dom/Range.idl:

Implement Range.getClientRects/getBoundingClientRect.

dom/Element.cpp:
rendering/RenderObject.h:

(WebCore::adjustForAbsoluteZoom):
(WebCore::adjustIntRectForAbsoluteZoom):
(WebCore::adjustFloatPointForAbsoluteZoom):
(WebCore::adjustFloatQuadForAbsoluteZoom):
Move point/quad adjustment methods from Element.cpp to RenderObject.h
so that Range.cpp can use them as well.

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=29760
Implement CSSOM Range.getClientRects/getBoundingClientRect

Reviewed by Dan Bernstein.

fast/dom/Element/getBoundingClientRect-expected.txt: Copied from LayoutTests/fast/dom/getBoundingClientRect-expected.txt.
fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Copied from LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt.
fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport.html: Copied from LayoutTests/fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html.
fast/dom/Element/getBoundingClientRect.html: Copied from LayoutTests/fast/dom/getBoundingClientRect.html.
fast/dom/Element/getClientRects-expected.txt: Copied from LayoutTests/fast/dom/getClientRects-expected.txt.
fast/dom/Element/getClientRects.html: Copied from LayoutTests/fast/dom/getClientRects.html.
fast/dom/Range/getBoundingClientRect-expected.txt: Added.
fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Added.
fast/dom/Range/getBoundingClientRect-getClientRects-relative-to-viewport.html: Added.
fast/dom/Range/getBoundingClientRect.html: Added.
fast/dom/Range/getClientRects-expected.txt: Added.
fast/dom/Range/getClientRects.html: Added.
fast/dom/Window/window-properties-expected.txt:
fast/dom/getBoundingClientRect-expected.txt: Removed.
fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Removed.
fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html: Removed.
fast/dom/getBoundingClientRect.html: Removed.
fast/dom/getClientRects-expected.txt: Removed.
fast/dom/getClientRects.html: Removed.

2:33 PM Changeset in webkit [48805] by eric@webkit.org

4 edits in trunk/WebKit/qt

2009-09-27 Joe Ligman <joseph.ligman@mindspring.com>

Reviewed by Simon Hausmann.

[Qt] Adding API setFocus and hasFocus to QWebElement. This API is needed for
clients that want to check/set the focus node of the document.
https://bugs.webkit.org/show_bug.cgi?id=29682

Api/qwebelement.cpp: (QWebElement::hasFocus): (QWebElement::setFocus):
Api/qwebelement.h:
tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::hasSetFocus):

2:32 PM Changeset in webkit [48804] by Simon Hausmann

2 edits in trunk/WebCore

Unreviewed fix for WebInspector with Qt build.

Patch by Simon Hausmann <Simon Hausmann> on 2009-09-27
Simply re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource

inspector/front-end/WebKit.qrc:

12:45 PM Changeset in webkit [48803] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-09-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Darin Adler.

run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
https://bugs.webkit.org/show_bug.cgi?id=29771

Scripts/run-webkit-tests:

12:17 PM BuildingGtk edited by kov@webkit.org

(diff)

12:12 PM Changeset in webkit [48802] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-09-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Remove tests that are passing from the Skipped list after implementing
the waitForPolicyDelegate() function in LayoutTestController.
https://bugs.webkit.org/show_bug.cgi?id=25037

platform/qt/Skipped:

12:05 PM Changeset in webkit [48801] by eric@webkit.org

5 edits in trunk/WebKitTools

2009-09-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Implement layoutTestController.waitForPolicyDelegate.
https://bugs.webkit.org/show_bug.cgi?id=25037

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::acceptNavigationRequest):
DumpRenderTree/qt/DumpRenderTree.pro:
DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::notifyDone): (LayoutTestController::waitForPolicyDelegate):
DumpRenderTree/qt/jsobjects.h: (LayoutTestController::waitForPolicy):

2:44 AM Changeset in webkit [48800] by pfeldman@chromium.org

1 edit in trunk/WebCore/ChangeLog

2009-09-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by nobody (trivial ChangeLog fix).

Restore WebCore/ChangeLog truncated in r48778.

2:19 AM Changeset in webkit [48799] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-09-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: DOM store is being unbound twice, leading to assertion failure.

https://bugs.webkit.org/show_bug.cgi?id=29770

inspector/InspectorController.cpp: (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage):
inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::unbind):

2:14 AM Changeset in webkit [48798] by pfeldman@chromium.org

7 edits in trunk/WebCore

2009-09-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not track DOM changes while inspector window is closed.

https://bugs.webkit.org/show_bug.cgi?id=29769

inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad):
inspector/InspectorController.h:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
inspector/InspectorDOMAgent.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchWindowObjectAvailable):
page/android/InspectorControllerAndroid.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared):

12:08 AM Changeset in webkit [48797] by pfeldman@chromium.org

4 edits in trunk/WebCore

2009-09-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] Double Clicking Resources Fails to Open in New Window

https://bugs.webkit.org/show_bug.cgi?id=29762

inspector/front-end/InjectedScript.js: (InjectedScript.setStyleText): (InjectedScript.openInInspectedWindow):
inspector/front-end/InjectedScriptAccess.js:
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):

Sep 26, 2009:

8:15 PM Changeset in webkit [48796] by ddkilzer@apple.com

2 edits in trunk

GTK BUILD FIX: add ENABLE_ORIENTATION_EVENTS support to configure.ac

configure.ac: Added support for ENABLE_ORIENTATION_EVENTS.

8:02 PM Changeset in webkit [48795] by ddkilzer@apple.com

6 edits in trunk

Part 2 of 2: <http://webkit.org/b/29753> DerivedSources.make broken for non-Mac targets

Reviewed by Darin Adler.

Fix ENABLE_ORIENTATION_EVENTS for non-Mac platforms.

WebCore:

DerivedSources.make: Moved Platform.h check for ENABLE_ORIENTATION_EVENTS into Mac-only section and added default of ENABLE_ORIENTATION_EVENTS = 0 to non-Mac section. Added ifndef test to make it possible to override both ENABLE_DASHBOARD_SUPPORT and ENABLE_ORIENTATION_EVENTS external to the makefile. Moved addition of ENABLE_ORIENTATION_EVENTS to ADDITIONAL_IDL_DEFINES to common section.
GNUmakefile.am: Added support for ENABLE_ORIENTATION_EVENTS if it is ever used.
WebCore.pro: Ditto.

WebKit:

chromium/features.gypi: Added 'ENABLE_ORIENTATION_EVENTS=0' to disable this feature by default.

4:14 PM Changeset in webkit [48794] by ddkilzer@apple.com

3 edits in trunk/WebKitTools

<http://webkit.org/b/29764> mark-bug-fixed: add -oopen switch

Reviewed by Eric Seidel.

The -oopen switch uses the open(1) command on Mac OS X to

open the bug URL in the default web browser. If there are
similar mechanisms on other platforms, they may be added later.

Scripts/mark-bug-fixed:

(MarkBugFixed.init): Added -oopen switch to list of parse

options.
(MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
code into main() and extracted prompting code into
_prompt_user_for_correctness().
(MarkBugFixed._open_bug_in_web_browser): Added.
(MarkBugFixed._prompt_user_for_correctness): Added.
(MarkBugFixed.main): Added logging code from
_determine_bug_id_and_svn_revision(). Added code to call
_open_bug_in_web_browser() if the switch is set. Added code to
call _prompt_user_for_correctness() when needed.

Scripts/modules/bugzilla.py: (Bugzilla.short_bug_url_for_bug_id): Added.

3:57 PM Changeset in webkit [48793] by ddkilzer@apple.com

3 edits in trunk/WebKitTools

svn-unapply and svn-apply don't work when used outside multiple svn working directories

<http://webkit.org/b/29744>
<rdar://problem/7252905>

Reviewed by Eric Seidel.

Some users have a workflow where svn-create-patch, svn-apply and
svn-unapply are used outside of multiple svn working
directories. Instead of aborting the scripts in these cases,
print a warning and assume that Subversion is being used.

Scripts/VCSUtils.pm: (determineVCSRoot): Call warn() instead of die() if both isGit() and isSVN() initially return false. Set $VCSUtils::isSVN to 1 to enforce the assumption about Subversion, then return determineSVNRoot().
Scripts/svn-apply: Switch to using isGit() and isSVN() from VCSUtils.pm. They both already cache their values and checking here is redundant since determineVCSRoot() is called later.

11:56 AM Changeset in webkit [48792] by eric@webkit.org

18 edits in trunk/WebCore

2009-09-26 Kent Tamura <tkent@chromium.org>

Reviewed by David Kilzer.

Move placeholder-related code to HTMLTextFormControlElement from
HTMLInputElement, WMLInputElement, InputElement, and
HTMLTextAreaElement.
https://bugs.webkit.org/show_bug.cgi?id=28703

dom/InputElement.cpp: (WebCore::InputElement::dispatchFocusEvent): (WebCore::InputElement::dispatchBlurEvent): (WebCore::InputElement::setValueFromRenderer):
dom/InputElement.h:
html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): (WebCore::HTMLTextFormControlElement::~HTMLTextFormControlElement): (WebCore::HTMLTextFormControlElement::dispatchFocusEvent): (WebCore::HTMLTextFormControlElement::dispatchBlurEvent): (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible): (WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
html/HTMLFormControlElement.h: (WebCore::HTMLTextFormControlElement::handleFocusEvent): (WebCore::HTMLTextFormControlElement::handleBlurEvent):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): (WebCore::HTMLInputElement::handleFocusEvent): (WebCore::HTMLInputElement::handleBlurEvent): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer):
html/HTMLInputElement.h: (WebCore::HTMLInputElement::supportsPlaceholder): (WebCore::HTMLInputElement::isEmptyValue):
html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::parseMappedAttribute):
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): (WebCore::HTMLTextAreaElement::createRenderer):
html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::supportsPlaceholder): (WebCore::HTMLTextAreaElement::isEmptyValue):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl):
rendering/RenderTextControl.h:
rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
rendering/RenderTextControlMultiLine.h:
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::updateFromElement):
rendering/RenderTextControlSingleLine.h:
wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::createRenderer):
wml/WMLInputElement.h:

10:51 AM Changeset in webkit [48791] by eric@webkit.org

3 edits
1 add in trunk/WebKitTools

2009-09-26 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
https://bugs.webkit.org/show_bug.cgi?id=29689

Load test fonts through FontConfig before each test.
This ensures a more proper rendering of the tests.

DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): (runTest): (main):
DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
GNUmakefile.am:

8:00 AM Changeset in webkit [48790] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-26 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Alexey Proskuryakov.

Optimize the code so only the text from start to end is scanned.
https://bugs.webkit.org/show_bug.cgi?id=29092

On a platform with webkit+Qt+Symbian, the parsing time for a 600K text
file improved from 400ms to 40ms (10x faster).

dom/Text.cpp: (WebCore::Text::createWithLengthLimit):

6:12 AM Changeset in webkit [48789] by eric@webkit.org

2 edits
2 adds in trunk/WebCore

2009-09-26 Xiaomei Ji <xji@chromium.org>

Reviewed by Eric Seidel.

This Patch fixes [chromium] the drop-down is always left-aligned even
for RTL element.
https://bugs.webkit.org/show_bug.cgi?id=29612

For auto-complete, the items in drop-down should be right-aligned if
the directionality of <input> field is RTL.
For <select><option>, the items in drop-down should be right-aligned
if the directionality of <select> is RTL.

No automatic test is possible. Manual tests are added.

manual-tests/autofill_alignment.html: Added.
manual-tests/select_alignment.html: Added.
platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow): Adjust the starting x-axis of text to be paint if it should be right-aligned.

5:47 AM Changeset in webkit [48788] by Simon Hausmann

3 edits
1 add in trunk/JavaScriptCore

Add MarkStackSymbian.cpp to build JavascriptCore for Symbian.

Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-09-26
Reviewed by Simon Hausmann.

Re-use Windows shrinkAllocation implementation because Symbian doesn't
support releasing part of memory region.

Use fastMalloc and fastFree to implement allocateStack and releaseStack
for Symbian port.

JavaScriptCore.pri:
runtime/MarkStack.h:

(JSC::MarkStack::MarkStackArray::shrinkAllocation):

runtime/MarkStackSymbian.cpp: Added.

(JSC::MarkStack::initializePagesize):
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):

Sep 25, 2009:

11:43 PM Changeset in webkit [48787] by mitz@apple.com

2 edits in trunk/WebCore

REGRESSION (r48775) FontList.plist written by TOT WebKit causes Safari 4
to crash on launch
https://bugs.webkit.org/show_bug.cgi?id=29759

Reviewed by Sam Weinig.

platform/graphics/win/FontDatabase.cpp:

(WebCore::writeFontDatabaseToPlist): Reverted to saving the CG font DB
property list at the root of FontList.plist, but with an additional
key for the last value of the Fonts registry key.
(WebCore::populateFontDatabase): Pass the FontList.plist in its entirety
to populatFontDatabaseFromPlist.

11:41 PM Changeset in webkit [48786] by kevino@webkit.org

2 edits in trunk/WebKit/wx

wx build fix. Add EmptyPluginHalterClient when creating Page.

11:31 PM Changeset in webkit [48785] by kevino@webkit.org

2 edits in trunk/WebCore

Build fix. Adding missing header files.

9:32 PM Changeset in webkit [48784] by ddkilzer@apple.com

2 edits in trunk/WebCore

Part 1 of 2: <http://webkit.org/b/29753> DerivedSources.make broken for non-Mac targets

Reviewed by Darin Adler.

DerivedSources.make: Move tests for ENABLE_CONTEXT_MENUS, ENABLE_DRAG_SUPPORT and ENABLE_INSPECTOR into Mac-only section.

7:35 PM Changeset in webkit [48783] by eric@webkit.org

3 edits
3 adds in trunk

2009-09-25 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Load blocks during unload should not affect targeted loads
https://bugs.webkit.org/show_bug.cgi?id=29747

Test that we can follow targeted hyperlinks in an unload handler.

fast/loader/resources/unload-hyperlink-targeted-subframe.html: Added.
fast/loader/unload-hyperlink-targeted-expected.txt: Added.
fast/loader/unload-hyperlink-targeted.html: Added.

2009-09-25 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Load blocks during unload should not affect targeted loads
https://bugs.webkit.org/show_bug.cgi?id=29747

Move the check of the unload state after checking for targeted links.

Test: fast/loader/unload-hyperlink-targeted.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL):

7:27 PM Changeset in webkit [48782] by eric@webkit.org

7 edits in trunk/JavaScriptCore

2009-09-25 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Fix unaligned data access in YARR_JIT on ARMv5 and below.
https://bugs.webkit.org/show_bug.cgi?id=29695

On ARMv5 and below all data access should be naturally aligned.
In the YARR_JIT there is a case when character pairs are
loaded from the input string, but this data access is not
naturally aligned. This fix introduces load32WithUnalignedHalfWords
and branch32WithUnalignedHalfWords functions which contain
naturally aligned memory loads - half word loads - on ARMv5 and below.

assembler/MacroAssemblerARM.cpp: (JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::load32WithUnalignedHalfWords): (JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords):
assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::load32WithUnalignedHalfWords): (JSC::MacroAssemblerARMv7::branch32): (JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords):
assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::load32WithUnalignedHalfWords): (JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords):
wtf/Platform.h:
yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generatePatternCharacterPair):

7:13 PM Changeset in webkit [48781] by eric@webkit.org

13 edits
5 copies
5 adds in trunk

2009-09-25 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[Chromium] Add initial V8 bindings for WebGL
https://bugs.webkit.org/show_bug.cgi?id=29664

WebCore.gypi:
bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/DOMObjectsInclude.h:
bindings/v8/DerivedSourcesAllInOne.cpp:
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
bindings/v8/V8Index.cpp:
bindings/v8/V8Index.h:
bindings/v8/custom/V8CanvasArrayBufferCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8CanvasArrayCustom.h: Added. (WebCore::constructCanvasArray):
bindings/v8/custom/V8CanvasByteArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CanvasFloatArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CanvasIntArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CanvasRenderingContext3DCustom.cpp: Added. (WebCore::jsArrayToFloatArray): (WebCore::jsArrayToIntArray): (WebCore::CALLBACK_FUNC_DECL): (WebCore::): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
bindings/v8/custom/V8CanvasShortArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CanvasUnsignedByteArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CanvasUnsignedIntArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CanvasUnsignedShortArrayCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
platform/graphics/GraphicsContext3D.h:

6:45 PM Changeset in webkit [48780] by jorlow@chromium.org

4 edits in trunk

JavaScriptCore: This is breaking Chromium try bots, so I'm counting this as a build fix.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-25
Add more svn:ignore exceptions. On different platforms, these files are
generated with different case for JavaScriptCore. Also there are some
wtf project files that get built apparently.

JavaScriptCore.gyp: Changed property svn:ignore.

WebCore: This is breaking Chromium try bots, so I'm counting this as a build fix.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-25
Add more svn:ignore exceptions. On different platforms, these files are
generated with different case for WebCore.

WebCore.gyp: Changed property svn:ignore.

5:57 PM Changeset in webkit [48779] by adachan@apple.com

3 edits in trunk/JavaScriptCore

Build fix.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

5:21 PM Changeset in webkit [48778] by ap@apple.com

30 edits
10 deletes in trunk

Reverting r48767, as it broke Windows build in a non-trivial way.

4:18 PM Changeset in webkit [48777] by agl@chromium.org

2 edits in trunk/WebCore

2009-09-24 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

Add a gyp variable to allow building a debug webcore without debug
symbols. This allows for faster compile, link, and gdb times.

https://bugs.webkit.org/show_bug.cgi?id=29721

No new tests, build config change.

WebCore.gyp/WebCore.gyp:

4:11 PM Changeset in webkit [48776] by darin@chromium.org

2 edits in trunk/WebCore

2009-09-25 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Declare RegisteredEventListener as a class instead of a struct.
This fixes a warning in the Chromium build.

dom/RegisteredEventListener.h:

4:07 PM Changeset in webkit [48775] by mitz@apple.com

6 edits in trunk

WebCore: WebCore part of
<rdar://problem/7211635> 2 byte characters are displayed as garbaged
<rdar://problem/7212626> garbled/gibberish text (off-by-one)

Reviewed by Jon Honeycutt.

When the Windows Fonts directory contains more than one font file for a
given font name, which of the fonts gets assigned to the name in the
Core Graphics font database was determined arbitrarily and did not
always match the font GDI used for the same font name. The mismatch
caused character-to-glyph mapping to use one font and glyph rendering to
use another.

The fix is to update the Core Graphics font database from the registry
entries (that reflect the name-to-font mapping that GDI uses) after
populating it with the result of scanning the Fonts directory. As a
consequence, the directory needs to be scanned at startup every time the
registry key changes, so the last value of the registry key is kept
in the property list on disk so that it could be compared to the current
value on startup.

platform/graphics/win/FontDatabase.cpp:

(WebCore::populateFontDatabaseFromPlist): Now takes a property list as
a parameter and avoids round-tripping through XML by calling
wkAddFontsFromPlist() instead of wkAddFontsFromPlistRepresentation().
(WebCore::fontFilenamesFromRegistryKey):
(WebCore::cgFontDBKey):
(WebCore::writeFontDatabaseToPlist): Now takes the CG font DB property
list and a property list with the font filenames from the registry and
writes a dictionary with those property lists as values.
(WebCore::fontFilenamesFromRegistry): Added. Returns an array with the
values in the HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Fonts
registry key.
(WebCore::populateFontDatabase): Changed to read the contents of the
Fonts registry key and compare it with the last-saved value from the
property list, and to call wkAddFontsFromRegistry() after populating the
CG font DB from the file system. Uses wkCreateFontsPlist() instead of
wkCreateFontsPlistRepresentation() to avoid round-tripping through XML.

WebKitLibraries: WebKitSystemInterface changes for
<rdar://problem/7211635> 2 byte characters are displayed as garbaged
<rdar://problem/7212626> garbled/gibberish text (off-by-one)

Reviewed by Adam Roben.

win/include/WebKitSystemInterface/WebKitSystemInterface.h: Added

wkAddFontsFromPlistRepresentation() and replaced
wkCreateFontsPlistRepresentation() with wkCreateFontsPlist() and
wkAddFontsFromPlistRepresentation() with wkAddFontsFromPlist().

win/lib/WebKitSystemInterface.lib:
win/lib/WebKitSystemInterface_debug.lib:

3:26 PM Changeset in webkit [48774] by ggaren@apple.com

18 edits in trunk

JavaScriptCore: Inlined some object creation code, including lexicalGlobalObject access
https://bugs.webkit.org/show_bug.cgi?id=29750

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-25
Reviewed by Darin Adler.

SunSpider says 0.5% faster.

0.8% speedup on bench-alloc-nonretained.js.
2.5% speedup on v8-splay.js.

interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):

interpreter/CallFrame.h:

(JSC::ExecState::lexicalGlobalObject):
(JSC::ExecState::globalThisValue):

interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::print):

runtime/ScopeChain.h:

(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::~ScopeChainNode):
(JSC::ScopeChainNode::push):
(JSC::ScopeChain::ScopeChain):
(JSC::ScopeChain::globalObject): Added a globalObject data member to ScopeChainNode.
Replaced accessor function for globalObject() with data member. Replaced
globalThisObject() accessor with direct access to globalThis, to match.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/JSGlobalObject.h: Inlined array and object construction.

WebCore: Inlined some object creation code, including lexicalGlobalObject access
https://bugs.webkit.org/show_bug.cgi?id=29750

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-25
Reviewed by Darin Adler.

bindings/js/JSInspectorBackendCustom.cpp:

(WebCore::JSInspectorBackend::currentCallFrame):

inspector/JavaScriptDebugServer.cpp:

(WebCore::JavaScriptDebugServer::hasBreakpoint): Updated for JavaScriptCore
API changes.

3:24 PM Changeset in webkit [48773] by hyatt@apple.com

5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=24399
Make @import work in user stylesheets. The first bug was that the URL wasn't being set on the
user sheets themselves, so relative @import URLs couldn't resolve properly. The second bug
was that the loads would be denied. This is fixed by using the requestUserCSSStyleSheet method
instead of the normal request method. In order to know when to do this, CSSStyleSheets now have
a propagated boolean, m_isUserStyleSheet, that lets them know if they are user stylesheets or not.

Reviewed by Anders Carlsson.

css/CSSImportRule.cpp:

(WebCore::CSSImportRule::insertedIntoParent):

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::CSSStyleSheet):

css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::setIsUserStyleSheet):
(WebCore::CSSStyleSheet::isUserStyleSheet):

dom/Document.cpp:

(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):

3:02 PM Changeset in webkit [48772] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/29718> mark-bug-fixed: add -uupdate-only switch

Reviewed by Eric Seidel.

Scripts/mark-bug-fixed:

(MarkBugFixed.init): Added -uupdate-only switch to list

of parse options.

(MarkBugFixed.main): When -uupdate-only is specified, add a

comment to the bug without marking it Resolved/Fixed.

3:01 PM Changeset in webkit [48771] by Simon Fraser

3 edits
4 adds in trunk

2009-09-25 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Crash with hardware accelerated rotation of a PDF image in a data URL
<rdar://problem/7250378>

PDF images don't return a color space from CGImageGetColorSpace(),
so we need to null-check the return value before use.

Test: compositing/color-matching/pdf-image-match.html

platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):

2:40 PM Changeset in webkit [48770] by Darin Adler

2 edits in trunk/WebKit/win

Speed up access to history items by caching date computation.

Patch by Darin Adler <Darin Adler> on 2009-09-25
Reviewed by Steve Falkenburg.

History/WebHistory.mm:

(getDayBoundaries): Refactored from timeIntervalForBeginningOfDay.
Returns the beginning of the day that the passed time is within and
the beginning of the next day.
(beginningOfDay): Added. Uses getDayBoundaries so it can be fast for
multiple dates within the same day, which is the common case.
(dateKey): Added. Calls beginningOfDay and converts to an integer.
(WebHistory::findKey): Changed to call dateKey instead of
timeIntervalForBeginningOfDay.

2:08 PM Changeset in webkit [48769] by Darin Adler

8 edits
1 copy
5 adds in trunk

Null-deref when first access to an Attr node is after its Element is destroyed
https://bugs.webkit.org/show_bug.cgi?id=29748

Patch by Darin Adler <Darin Adler> on 2009-09-25
Reviewed by Geoffrey Garen.

WebCore:

Test: fast/dom/Attr/access-after-element-destruction.html

bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::markChildren): Added. Keeps the ownerElement alive as
long as the Attr is alive.

bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::markChildren): Added. Keeps the Element alive as
long as the NamedNodeMap is alive.

dom/Attr.idl: Added CustomMarkFunction attribute.

dom/NamedAttrMap.cpp:

(WebCore::NamedNodeMap::getAttributeItem): Tweaked formatting.
(WebCore::NamedNodeMap::detachFromElement): Call clearAttributes so we don't
have attributes hanging around that might need an Attr node created; that way
we won't crash with a null-dereference trying to deal with one of them. This
can't happen when working with JavaScript since the Element will be kept
alive due to the change above.
(WebCore::NamedNodeMap::addAttribute): Fix function name in comment.
(WebCore::NamedNodeMap::removeAttribute): Removed unneeded "+ 1" and added
missing braces.

dom/NamedAttrMap.h: Made the element function public so it can be used by

the JavaScript binding to keep the Element alive.

dom/NamedNodeMap.idl: Added CustomMarkFunction attribute.

LayoutTests:

fast/dom/Attr/access-after-element-destruction-expected.txt: Added.
fast/dom/Attr/access-after-element-destruction.html: Added.
fast/dom/Attr/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Node/script-tests/TEMPLATE.html.
fast/dom/Attr/script-tests/access-after-element-destruction.js: Added.

2:07 PM Changeset in webkit [48768] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/prepare-ChangeLog: Leave files from the script-tests directory

out, just as we do for the resources directory.

Reviewed by Geoffrey Garen.

1:44 PM Changeset in webkit [48767] by ap@apple.com

30 edits
10 adds in trunk

Reviewed by Darin Adler and Sam Weinig.

Onclick not fired for an element copied with cloneContents() or cloneNode()
https://bugs.webkit.org/show_bug.cgi?id=25130

The change here is that JS event listeners don't keep a reference to a global object from
where they were created, and instead take it as a parameter when parsing source code. Also,
the listener creation won't fail just because it happens for an element in a frameless
document.
Thus, moving nodes between documents no longer results in having incorrect registered
lazy event listeners on them.

Tests: fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html

fast/events/attribute-listener-cloned-from-frameless-doc-context.html
fast/events/attribute-listener-cloned-from-frameless-doc.xhtml
fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html
fast/events/attribute-listener-extracted-from-frameless-doc-context.html

bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): Don't take a reference to JSDOMGlobalObject. (WebCore::JSEventListener::jsFunction): Take ScriptExecutionContext as a parameter for getting to JSDOMGlobalObject. It's not used in base class, but is in JSLazyEventListner. (WebCore::JSEventListener::markJSFunction): Don't mark the global object. (WebCore::JSEventListener::handleEvent): Get global object from ScriptExecutionContext. (WebCore::JSEventListener::reportError): Ditto.

bindings/js/JSEventListener.h: (WebCore::JSEventListener::create): Don't keep a reference to JSDOMGlobalObject.

bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Listener creation was split between this function and ScriptEventListener; moved it here, as JS global object can be different now.

bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create): Keep source URL, which can not be determined at parsing time.

bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Moved code for listener creation to JSLazyEventListener. XSSAuditor code remains here, because tests expect that errors are logged at document parsing time, and because I don't know what other side effects moving it vould have.

dom/EventListener.h: handleEvent() and reportError() now take ScriptExecutionContext, because JSC needs a global context here.

bindings/js/JSAbstractWorkerCustom.cpp: (WebCore::JSAbstractWorker::addEventListener): (WebCore::JSAbstractWorker::removeEventListener):
bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
bindings/js/JSEventSourceCustom.cpp: (WebCore::JSEventSource::addEventListener): (WebCore::JSEventSource::removeEventListener):
bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
bindings/objc/ObjCEventListener.h:
bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
bindings/scripts/CodeGeneratorJS.pm:
dom/EventTarget.cpp: (WebCore::EventTarget::fireEventListeners):
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::handleEvent):
inspector/InspectorDOMAgent.h:
inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent):
inspector/InspectorDOMStorageResource.h:
loader/ImageDocument.cpp: (WebCore::ImageEventListener::handleEvent):
svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::handleEvent):
workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException): Don't pass global object to JSEventListener::create(), which no longer needs it. Note that some of these functions still have an early return for null global object, which can probably be removed in a later patch. Pass ScriptExecutionContext to EventListener methods that now need it.

1:24 PM Changeset in webkit [48766] by Darin Adler

1 edit
1 add in trunk/LayoutTests

Checked in a file that was created by make-script-test-wrappers.

Patch by Darin Adler <Darin Adler> on 2009-09-25

platform/gtk/editing/pasteboard/middle-click-onpaste.html: Added.

1:00 PM Changeset in webkit [48765] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-09-25 Adam Barth <abarth@webkit.org>

Unreviewed. Added Tony to committers.py because he's a
committer now.

Scripts/modules/committers.py:

11:55 AM Changeset in webkit [48764] by adele@apple.com

5 edits
2 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29740
<rdar://problem/7168738> Gmail: After changing a foreground text color, pressing return doesn't apply background to new line

Patch by Enrica Casucci <enrica@apple.com> on 2009-09-25
Reviewed by Darin Adler, Dan Bernstein, Adele Peterson, and others.

Change the way style is preserved when inserting a new paragraph.
The original code handled insertion at the beginning and at the end of a paragraph as special
cases. The newly created paragraph contained a set of nodes generated starting from the
computed style of the insertion node. This approach has two problems:

if the insertion node has a non opaque background color and one of the parent element did have

a solid background color the new paragraph did not have the element with the solid color in the tree.

in some circumstances it generated more markup than the original paragraph had (a span with bold, italic,

background color and some font attribute was being reproduced as span + bold + italic + font as separate tags.
The new approach is to recreate in the new paragraph the same hierarchy of nodes found in the
paragraph where the insertion point is.

Test: editing/inserting/insert-bg-font.html

editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::getAncestorsInsideBlock): retrieves the list of all the ancestors
between the insert node and the outer block.
(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock): uses the list of ancestors to recreate
in the new paragraph the same element hierarchy present in the starting paragraph.
(WebCore::InsertParagraphSeparatorCommand::doApply): changed the code to handle the general case of insertion
in the middle of the paragraph to use the new methods. Changed the handling of the insertion at the beginning and
at the end of the paragraph to use the new methods instead of applying the calculated style.

editing/InsertParagraphSeparatorCommand.h: added methods getAncestorsInsideBlock and cloneHierarchyUnderNewBlock.

LayoutTests: Updated the expected results to reflect the changes in the way the new paragraph
is created and added test case for https://bugs.webkit.org/show_bug.cgi?id=29740
<rdar://problem/7168738> Gmail: After changing a foreground text color, pressing return doesn't apply background to new line

Patch by Enrica Casucci <enrica@apple.com> on 2009-09-25
Reviewed by Darin Adler, Dan Bernstein, Adele Peterson, and others.

editing/inserting/insert-bg-font.html: Added.
platform/mac/editing/inserting/insert-bg-font-expected.txt: Added.
platform/mac/editing/pasteboard/5478250-expected.txt:

11:36 AM Changeset in webkit [48763] by eric@webkit.org

4 edits in trunk/WebCore

2009-09-25 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Content-type parameters not taken into account when building form-data
https://bugs.webkit.org/show_bug.cgi?id=28970

existing manual test case extended with new tests

English.lproj/localizedStrings.js:
inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshFormData): (WebInspector.ResourceView.prototype._refreshParms):
manual-tests/inspector/display-form-data.html:

11:27 AM Changeset in webkit [48762] by eric@webkit.org

5 edits in trunk/WebKitTools

2009-09-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should auto-retry patches which fail to commit due to out of date files
https://bugs.webkit.org/show_bug.cgi?id=28316

Scripts/bugzilla-tool:
- Handle new CheckoutNeedsUpdate exception.
Scripts/modules/logging_unittest.py:
- Call the ScriptError constructor correctly (this test had regressed).
Scripts/modules/scm.py:
- Added the ability to define custom error handlers for run_command and added a commit_error_handler which throws CheckoutNeedsUpdate instead of ScriptError.
- Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
Scripts/modules/scm_unittest.py:
- Added tests of new error handlers.

10:53 AM Changeset in webkit [48761] by eric@webkit.org

6 edits
4 adds in trunk

2009-09-25 Yuan Song <song.yuan@ericsson.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=14566

Add test "invalid-domain-change-throws-exception.html" to ensure a SECURITY_ERR exception is raised if an attempt is made to change document.domain to an invalid value. In the existing test case "basic-textareas.html", fix the faulty behavior of setting document.domain to invalid value, and replace the data URL to a file URL that points to "basic-textareas-standards.html" in order to make "basic-textareas.html" runnable in a browser.

fast/forms/basic-textareas.html:
fast/forms/resources/basic-textareas-standards.html: Added.
fast/js/invalid-domain-change-throws-exception-expected.txt: Added.
fast/js/invalid-domain-change-throws-exception.html: Added.
fast/js/resources/invalid-domain-change-throws-exception.js: Added.

2009-09-25 Yuan Song <song.yuan@ericsson.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=14566

Raise SECURITY_ERR exception if an attempt is made to change document.domain to an invalid value.

Test: fast/js/invalid-domain-change-throws-exception.html

dom/Document.cpp: (WebCore::Document::setDomain):
dom/Document.h:
dom/Document.idl:

10:40 AM Changeset in webkit [48760] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-09-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should give better feedback when failing a patch
https://bugs.webkit.org/show_bug.cgi?id=29316

Scripts/bugzilla-tool:
- Update ScriptError uses to the new constructor format.
- Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output so that we can print to both stdout as well as an output buffer for error reporting.
- Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
- Use e.message_with_output() when failing a patch (this is the real fix here). I also removed use of "This patch will require manual commit." as that's not always true.
- Add missing word "bug" from log message.
Scripts/modules/scm.py:
- Make ScriptError save a bunch more data so that error messages can be nicer.
- Update ScriptError callers.

10:31 AM BuildingOnWindows edited by dbates@webkit.org

Changed title of subsection to reflect fix for linker problems (diff)

9:36 AM Changeset in webkit [48759] by eric@webkit.org

3 edits
2 adds in trunk

2009-09-25 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703

Test a strange error condition after clearing a setInterval
timer. The key point is not to crash on this test.

fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Added.
fast/dom/timer-clear-interval-in-handler-and-generate-error.html: Added.

2009-09-25 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703

When setTimeout is called with a string argument in an isolated
world, we now compile the string in the isolated world.

Last time we tried this change, we got a lot of crashes. This
time we're using a fresh local handle as our context to avoid
trouble if the peristent handle gets disposed before we leave
the context.

Test: fast/dom/timer-clear-interval-in-handler-and-generate-error.html

bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):

9:30 AM Changeset in webkit [48758] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-09-25 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Make tst_qwebframe work if Qt built without SSL support
https://bugs.webkit.org/show_bug.cgi?id=29735

tests/qwebframe/tst_qwebframe.cpp: Missing #ifndef blocks added.

9:23 AM Changeset in webkit [48757] by eric@webkit.org

2 edits in trunk/WebCore

2009-09-25 Paul Godavari <paul@chromium.org>

Reviewed by Darin Fisher.

Fix a regression in Mac Chromium popup menus, where the user's
selection was ignored and the popup became unresponsive.
https://bugs.webkit.org/show_bug.cgi?id=29726

The fix is to notify the popup's client that the popup was hidden,
even if the popup has no parent.

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::hidePopup):

9:10 AM Changeset in webkit [48756] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-09-25 Laszlo Gombos <Laszlo Gombos>

Reviewed by Gavin Barraclough.

Add ARM version detection rules for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29715

wtf/Platform.h:

8:47 AM Changeset in webkit [48755] by pfeldman@chromium.org

5 edits in trunk/WebCore

2009-09-25 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Dan Bernstein.

Enable Pasteboard::writePlainText for Chromium and fix code style nits.
https://bugs.webkit.org/show_bug.cgi?id=29734

platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writePlainText):
platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writePlainText):

8:32 AM Changeset in webkit [48754] by Adam Roben

4 edits in trunk/WebKit/win

Add SPI to invalidate a WebView's backing store

This is useful in conjunction with
IWebUIDelegatePrivate2::drawBackground. This provides a way for the UI
delegate to force WebView to get its background redrawn.

Fixes <http://webkit.org/b/29737> Need SPI to invalidate a WebView's
backing store

Reviewed by Anders Carlsson.

Interfaces/IWebViewPrivate.idl: Added invalidateBackingStore.
WebView.cpp:

(WebView::invalidateBackingStore): If rect is 0, invalidate our whole
client rect. Otherwise invalidate the intersection of rect with our
client rect.

WebView.h:

7:01 AM Changeset in webkit [48753] by kov@webkit.org

4 edits in trunk/WebKit/gtk

2009-09-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Pop down the context menu when the page transitions to committed,
to avoid keeping a context menu out of context.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
webkit/webkitprivate.h:
webkit/webkitwebview.cpp: (destroy_menu_cb): (webkit_web_view_forward_context_menu_event):

1:54 AM Changeset in webkit [48752] by Simon Hausmann

2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=28876
[Qt] reduce peak memory consumption of text decoding.

Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-09-25
Reviewed by Ariya Hidayat.

Chop large input buffer into small buffers to reduce peak memory
during decoding.

platform/text/qt/TextCodecQt.cpp:

(WebCore::TextCodecQt::decode):

1:53 AM Changeset in webkit [48751] by Simon Hausmann

4 edits in trunk/WebKit/qt

[Qt] Update QWebElement API to remove script related methods.
QWebElement::evaluateScript is the only one kept, these are
removed to postpone most of the QtWebKit<->JavaScript API design
after 4.6.
https://bugs.webkit.org/show_bug.cgi?id=29708

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-24
Reviewed by Simon Hausmann.

Api/qwebelement.cpp:
Api/qwebelement.h:

Methods removed:

QWebElement::callFunction
QWebElement::functions
QWebElement::scriptableProperty
QWebElement::setScriptableProperty
QWebElement::scriptableProperties
tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::evaluateScript):

1:19 AM Changeset in webkit [48750] by Simon Hausmann

4 edits in trunk/WebKit/qt

[Qt] Rename QWebElement::evaluateScript
to QWebElement::evaluateJavaScript.
https://bugs.webkit.org/show_bug.cgi?id=29709

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-25
Reviewed by Simon Hausmann.

Api/qwebelement.cpp:

(QWebElement::evaluateJavaScript):

Api/qwebelement.h:
tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::evaluateJavaScript):

1:18 AM Changeset in webkit [48749] by Simon Hausmann

5 edits in trunk/WebKit/qt

[Qt] Update the stypeProperty API of QWebElement.
https://bugs.webkit.org/show_bug.cgi?id=29711

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-25
Reviewed by Simon Hausmann.

Api/qwebelement.cpp:

(QWebElement::styleProperty):

Merge the stypeProperty and the computedStyleProperty methods
Remove the default value for the style resolving enum
Rename ResolveRule to StyleResolveStrategy

(QWebElement::setStyleProperty):

Remove the priority argument since it is possible to control the behaviour by adding !important or removing in the value.
Api/qwebelement.h:
tests/qwebelement/tst_qwebelement.cpp:

Context Navigation

Timeline

Sep 29, 2009:

Sep 28, 2009:

Sep 27, 2009:

Sep 26, 2009:

Sep 25, 2009:

Download in other formats: