Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Nov 23, 2009:

8:25 PM Changeset in webkit [51336] by Laszlo Gombos

• 19 edits in trunk

2009-11-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
​https://bugs.webkit.org/show_bug.cgi?id=31792

• wtf/unicode/UTF8.cpp:
• wtf/unicode/glib/UnicodeGLib.cpp:
• wtf/unicode/wince/UnicodeWince.cpp:

2009-11-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
​https://bugs.webkit.org/show_bug.cgi?id=31792

• GEN_DOMObject.cpp:
• WebScriptObject.cpp:

2009-11-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
​https://bugs.webkit.org/show_bug.cgi?id=31792

• WebKitSupport/DragClientWx.cpp:

2009-11-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
​https://bugs.webkit.org/show_bug.cgi?id=31792

No new tests as there is no new functionality.

• platform/graphics/win/IntPointWin.cpp:
• platform/graphics/win/IntRectWin.cpp:
• platform/graphics/win/IntSizeWin.cpp:
• platform/network/chromium/ResourceRequest.cpp:
• platform/win/PlatformMouseEventWin.cpp:

2009-11-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
​https://bugs.webkit.org/show_bug.cgi?id=31792

• DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
• DumpRenderTree/qt/jsobjects.cpp:
• DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:

6:33 PM Changeset in webkit [51335] by jianli@chromium.org

• 5 edits in trunk

WebCore: * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):

• platform/graphics/GraphicsContext3D.h:

Reviewed by NOBODY (Chromium build fix).

WebKit/chromium: * src/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::createShader):

Reviewed by NOBODY (Chromium build fix).

6:30 PM Changeset in webkit [51334] by ggaren@apple.com

• 4 edits in trunk/JavaScriptCore

Streamlined some Math functions where we expect or know the result not
to be representable as an int.

Reviewed by Oliver Hunt.

SunSpider says 0.6% faster.

• runtime/JSNumberCell.h:

(JSC::JSValue::JSValue):

• runtime/JSValue.h:

(JSC::JSValue::):
(JSC::jsDoubleNumber):
(JSC::JSValue::JSValue): Added a function for making a numeric JSValue
and skipping the "can I encode this as an int?" check, avoiding the
overhead of int <-> double roundtripping and double <-> double comparison
and branching.

• runtime/MathObject.cpp:

(JSC::mathProtoFuncACos):
(JSC::mathProtoFuncASin):
(JSC::mathProtoFuncATan):
(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncCos):
(JSC::mathProtoFuncExp):
(JSC::mathProtoFuncLog):
(JSC::mathProtoFuncRandom):
(JSC::mathProtoFuncSin):
(JSC::mathProtoFuncSqrt):
(JSC::mathProtoFuncTan): For these functions, which we expect or know
to produce results not representable as ints, call jsDoubleNumber instead
of jsNumber.

6:24 PM Changeset in webkit [51333] by mrowe@apple.com

• 3 edits in trunk/JavaScriptCore

Unreviewed. Unbreak the regression tests after r51329.

• API/JSBase.cpp:

(JSEvaluateScript): Null-check clientData before dereferencing it.

• API/JSObjectRef.cpp:

(JSObjectCallAsFunction): Ditto.

5:31 PM Changeset in webkit [51332] by bweinstein@apple.com

• 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Add exported functions to fix the Windows build.

5:07 PM Changeset in webkit [51331] by agolden@apple.com

• 4 edits in trunk/WebCore

Prevent ResourceHandleMac's version of ResourceHandle::receivedCredential from stripping
identity and certificate information from a WebCore::Credential when receivedCredential
needs to modify the credential's persistence.

Reviewed by Alexey Proskuryakov.

4:55 PM Changeset in webkit [51330] by barraclough@apple.com

• 10 edits in trunk/WebCore

Part 2/3 of <rdar://problem/7377477> REGRESSION: Many web pages fail to render after interesting script runs in isolated world

Reviewed by Geoff Garen.

Some clients of the JavaScriptCore API expect to be able to make callbacks over the JSC API,
and for this to automagically cause execution to take place in the world associated with the
global object associated with the ExecState (JSContextRef) passed. However this is not how
things work - the world must be explicitly set within WebCore.

Making this work just for API calls to evaluate & call will be a far from perfect solution,
since direct (non-API) use of JSC still relies on WebCore setting the current world correctly.
A better solution would be to make this all work automagically all throughout WebCore, but this
will require more refactoring.

Add references from the JSDOMWindowShell and the JSDOMGlobalObject to the world that owns them,
so that we can get to the world from the lexical global object of an ExecState. In the long-term
we should switch over to using this approach for all cases we want to get a world from an exec state.

• bindings/js/JSDOMBinding.cpp:

(WebCore::WebCoreJSClientData::beginningExecution):
(WebCore::WebCoreJSClientData::completedExecution):

• bindings/js/JSDOMBinding.h:
• bindings/js/JSDOMGlobalObject.h:

(WebCore::JSDOMGlobalObject::world):
(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):

• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):

• bindings/js/JSDOMWindowBase.h:
• bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::JSDOMWindowShell):

• bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::world):

• bindings/js/JSWorkerContextBase.cpp:

(WebCore::JSWorkerContextBase::JSWorkerContextBase):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initScript):

4:54 PM Changeset in webkit [51329] by barraclough@apple.com

• 6 edits in trunk/JavaScriptCore

Part 1/3 of <rdar://problem/7377477> REGRESSION: Many web pages fail to render after interesting script runs in isolated world

Reviewed by Geoff Garen.

Some clients of the JavaScriptCore API expect to be able to make callbacks over the JSC API,
and for this to automagically cause execution to take place in the world associated with the
global object associated with the ExecState (JSContextRef) passed. However this is not how
things work - the world must be explicitly set within WebCore.

Making this work just for API calls to evaluate & call will be a far from perfect solution,
since direct (non-API) use of JSC still relies on WebCore setting the current world correctly.
A better solution would be to make this all work automagically all throughout WebCore, but this
will require more refactoring.

Since the API is in JSC but worlds only exist in WebCore, add callbacks on the JSGlobalData::ClientData
to allow it to update the current world on entry/exit via the JSC API. This is temporary duck
tape, and should be removed once the current world no longer needs to be explicitly tracked.

• API/JSBase.cpp:

(JSEvaluateScript):

• API/JSObjectRef.cpp:

(JSObjectCallAsFunction):

• JavaScriptCore.exp:
• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::ClientData::beginningExecution):
(JSC::JSGlobalData::ClientData::completedExecution):

• runtime/JSGlobalData.h:

4:35 PM Changeset in webkit [51328] by cmarrin@apple.com

• 1 edit in trunk/WebCore/html/canvas/WebGLRenderingContext.cpp

Forgot one file for ​https://bugs.webkit.org/show_bug.cgi?id=31239

4:33 PM Changeset in webkit [51327] by cmarrin@apple.com

• 15 edits
  4 adds in trunk

Add range checks to rendering calls in WebGL
​https://bugs.webkit.org/show_bug.cgi?id=31239

I am now tracking the size of the data in each CanvasBuffer object
and keeping track of the buffer size of each active vertex attrib.
In drawArrays and drawElements I make sure no attempt is made to
access elements outside the valid buffer ranges. The test at:

​http://cs.helsinki.fi/u/ilmarihe/c3d/functions/drawArraysOutOfBounds.html

no longer crashes.

I also added all the WebGL enumerations to GraphicsContext3D to use them in the validation checks

4:30 PM Changeset in webkit [51326] by arv@chromium.org

• 6 edits
  10 adds in trunk

2009-11-23 Erik Arvidsson <​arv@chromium.org>

Reviewed by Eric Seidel.

JSC bindings for HasIndexGetter generates incorrect code (affects
MediaList and CSSStyleDeclaration).
This cleans up the edge cases for indexing out of range for style and
computed style objects to return an empty string according to the spec.
MediaList now returns null when indexed out of range.
​https://bugs.webkit.org/show_bug.cgi?id=31683

• fast/dom/CSSStyleDeclaration/css-computed-style-item-expected.txt: Added.
• fast/dom/CSSStyleDeclaration/css-computed-style-item.html: Added.
• fast/dom/CSSStyleDeclaration/css-style-item-expected.txt: Added.
• fast/dom/CSSStyleDeclaration/css-style-item.html: Added.
• fast/dom/CSSStyleDeclaration/script-tests/css-computed-style-item.js: Added.
• fast/dom/CSSStyleDeclaration/script-tests/css-style-item.js: Added.
• fast/dom/StyleSheet/css-medialist-item-expected.txt: Added.
• fast/dom/StyleSheet/css-medialist-item.html: Added.
• fast/dom/StyleSheet/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/backgrounds/repeat/script-tests/TEMPLATE.html.
• fast/dom/StyleSheet/script-tests/css-medialist-item.js: Added.

2009-11-23 Erik Arvidsson <​arv@chromium.org>

Reviewed by Eric Seidel.

JSC bindings for HasIndexGetter generates incorrect code (affects
MediaList and CSSStyleDeclaration).
This cleans up the edge cases for indexing out of range for style and
computed style objects to return an empty string according to the spec.
MediaList now returns null when indexed out of range.
​https://bugs.webkit.org/show_bug.cgi?id=31683

Tests: fast/dom/CSSStyleDeclaration/css-computed-style-item.html

fast/dom/CSSStyleDeclaration/css-style-item.html
fast/dom/StyleSheet/css-medialist-item.html

• bindings/scripts/CodeGeneratorJS.pm: If IndexGetterReturnsString then

we do not check the length before calling the item function.

• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::item):
• css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::item):
• css/CSSStyleDeclaration.idl:

4:16 PM Changeset in webkit [51325] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

Unreviewed. Skip new test added in r51324.

• platform/qt/Skipped: Added editing/selection/trransformed-selection-rects.html

3:30 PM Changeset in webkit [51324] by Simon Fraser

• 15 edits
  4 adds in trunk

2009-11-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

DocumentMarkers need to be educated about transforms
​https://bugs.webkit.org/show_bug.cgi?id=31751

Find highlight is incorrect with transforms
<rdar://problem/6358394>

Allow callers to specify that Frame::selectionTextRects() takes transforms into account
when computing the set of rects that encompass a selection. For transformed elemenets, the
selection rect will be the bounding box of the selected content.

Fix DocumentMarkers to cache rects in absolute coordinates, rather than painting coordinates.

Test: editing/selection/transformed-selection-rects.html

• WebCore.base.exp: Frame::selectionTextRects() has a new parameter.

• dom/Document.cpp: (WebCore::Document::setRenderedRectForMarker):
• dom/Document.h: Pass the marker as a const reference.

• dom/Range.h:
• dom/Range.cpp: (WebCore::Range::textQuads): Add a new method, textQuads(), which returns a list of quads, respecting transforms.

• page/Frame.h:
• page/Frame.cpp: (WebCore::Frame::selectionTextRects): Add a new parameter, respectTransforms, and when that is RespectTransforms, use the quad method to get quads for ranges, and then take their bounding boxes.

• rendering/InlineTextBox.h:
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers): (WebCore::InlineTextBox::textPos): (WebCore::InlineTextBox::offsetForPosition):

Pass DocumentMarkers as a const references.
Convert the argument to setRenderedRectForMarker() into absolute coordinates.

• rendering/RenderView.cpp: (WebCore::RenderView::selectionBounds):

2:55 PM Changeset in webkit [51323] by eric@webkit.org

• 1 edit
  2 adds in trunk/JavaScriptCore

2009-11-23 Steve Block <​steveblock@google.com>

Reviewed by Dmitry Titov.

Adds MainThreadAndroid.cpp with Android-specific WTF threading functions.
​https://bugs.webkit.org/show_bug.cgi?id=31807

• wtf/android: Added.
• wtf/android/MainThreadAndroid.cpp: Added. (WTF::timeoutFired): (WTF::initializeMainThreadPlatform): (WTF::scheduleDispatchFunctionsOnMainThread):

2:36 PM Changeset in webkit [51322] by krit@webkit.org

• 2 edits in trunk/WebCore

2009-11-23 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

[Cairo] support blurred test-shadow
​https://bugs.webkit.org/show_bug.cgi?id=31797

Support for blurred text-shadows on Cairo. This patch
reuses the code of blurred box-shadows, introduced in
bug 26102. For a full textshadow support, a filters enabled
build is needed.

• platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):

2:25 PM Changeset in webkit [51321] by snej@chromium.org

• 6 edits in trunk/WebCore

Change incorrect calls to the constructor "EventNames()" to the correct accessor
"eventNames()". This saves ~100 AtomicString lookups each time.
​https://bugs.webkit.org/show_bug.cgi?id=31811

Reviewed by Geoffrey Garen.

• dom/EventNames.h: Make constructor private to prevent this from happening again.
• history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): EventNames() --> eventNames()

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::checkValidity): EventNames() --> eventNames()

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading): EventNames() --> eventNames()
(WebCore::FrameLoader::pageHidden): EventNames() --> eventNames()

• page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingUnloadEvents): EventNames() --> eventNames()

2:22 PM Changeset in webkit [51320] by kov@webkit.org

• 2 edits in trunk/WebKitTools

Reviewed by Oliver Hunt.

Implement new required function to pass test we used to pass. This
change is required since r51294.

• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):

2:10 PM Changeset in webkit [51319] by agl@chromium.org

• 2 edits in trunk/WebCore

2009-11-23 Adam Langley <​agl@google.com>

Reviewed by Dmitry Titov.

Chromium Linux: Limit the stroke width and mitre limit.

Limit the stroke width and mitre limit that we'll pass into Skia to
avoid overflowing Skia's uint16_t glyph widths.

​http://code.google.com/p/chromium/issues/detail?id=28250
​https://bugs.webkit.org/show_bug.cgi?id=31747

• platform/graphics/skia/PlatformContextSkia.cpp: (scalarBound): (PlatformContextSkia::setupPaintForStroking):

1:57 PM Changeset in webkit [51318] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

Unreviewed. Skip new tests.

• platform/qt/Skipped:

1:53 PM Changeset in webkit [51317] by ap@apple.com

• 3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=31812
WebSocket code uses RefPtr::get() where it shouldn't

No change in funcitonality, just coding style correction.

• websockets/WebSocket.cpp: (WebCore::WebSocket::~WebSocket):
• websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::connect): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::close): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): (WebCore::WebSocketChannel::didFail):

1:48 PM Changeset in webkit [51316] by eric@webkit.org

• 4 edits in trunk

2009-11-23 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
​https://bugs.webkit.org/show_bug.cgi?id=31775

LayoutTestController::dumpBackForwardList() should work with local URLs
as well as with normal URLs (in http tests for instance).
Currently it does not output the latter properly.

Unskip a bunch of passing http/navigation tests.

• platform/qt/Skipped:

2009-11-23 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
​https://bugs.webkit.org/show_bug.cgi?id=31775

LayoutTestController::dumpBackForwardList() should work with local URLs
as well as with normal URLs (in http tests for instance).
Currently it does not output the latter properly.

Unskip a bunch of passing http/navigation tests.

• DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::dumpHistoryItem):

1:28 PM Changeset in webkit [51315] by ap@apple.com

• 2 edits in trunk/WebCore

Build fix.

• platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): pacExecutionCallbackMainThread is static, so it can't use member variables directly.

1:00 PM Changeset in webkit [51314] by ap@apple.com

• 5 edits in trunk

Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=31748
Make WebSocketHandleCFNet respect proxy auto-configuration files via CFProxySupport

• platform/network/cf/SocketStreamHandle.h: Removed names from some void* arguments, since they didn't carry useful information.

• platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): When we need an http-style URL, we actually always need https. (WebCore::SocketStreamHandle::scheduleStreams): Factored out from constructor, since streams only get scheduled after PAC is fetched and executed asynchronously. (WebCore::SocketStreamHandle::copyPACExecutionDescription): Return a description for event source. (WebCore::MainThreadPACCallbackInfo::MainThreadPACCallbackInfo): Forward callback to main thread. (WebCore::SocketStreamHandle::pacExecutionCallback): Ditto. (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): Ditto. To avoid code duplication, we make the call even on Mac. (WebCore::SocketStreamHandle::executePACFileURL): Make an async call to CFNetworkExecuteProxyAutoConfigurationURL. (WebCore::SocketStreamHandle::removePACRunLoopSource): Once PAC execution is done or aborted, we need to get rid of the event source. (WebCore::SocketStreamHandle::chooseProxy): Use stored m_httpsURL.get. (WebCore::SocketStreamHandle::chooseProxyFromArray): Factored out from chooseProxy - the array may come directly from system configuration, or from PAC. (WebCore::SocketStreamHandle::chooseProxy): Tiger version of this function is now completely separate. (WebCore::SocketStreamHandle::~SocketStreamHandle): Run loop source should be destroyed before we get to the destructor. (WebCore::SocketStreamHandle::platformClose): Destroy the run loop source, if PAC execution is still in progress.

12:10 PM Changeset in webkit [51313] by oliver@apple.com

• 2 edits in trunk/WebCore

Don't leak the CGImage we create when drawing a sub image.

Reviewed by Geoff Garen.

11:12 AM Changeset in webkit [51312] by abarth@webkit.org

• 3 edits in trunk/WebCore

2009-11-23 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Don't crash when OOM in creating isolated world
​https://bugs.webkit.org/show_bug.cgi?id=31805

We need to add some more null checks to avoid crashing. No new tests
because we don't have a good way to test out-of-memory bugs.

• bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::setInjectedScriptContextDebugId):
• bindings/v8/V8Proxy.h:

11:07 AM Changeset in webkit [51311] by bweinstein@apple.com

• 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild.

8:15 AM Changeset in webkit [51310] by krit@webkit.org

• 28 edits in trunk/WebCore

2009-11-23 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

This is the implementation of the filterRes attribute. It
helps the SVG developer to set the quality of a filter by
giving the width or height of filter.
This patch also sets the filter resolution to lower values
if a intermediate ImageBuffer size is bigger than the given
maximal size.
The maximal size is set to 5000x5000 by default. This is a
subjectiv decission. Everthing greater than this values gets
sensible slower. Values of 10000x10000 crashed on WebKitGtk.
For mobil devices a maximum size of 100x100 or 200x200 seems
to be reasonable.
The important fact on filter resolution is, that the output
size is still the size given by the <filter> element.

Tests: svg/filters/big-sized-filter-2.svg

svg/filters/big-sized-filter.svg
svg/filters/filterRes.svg

• platform/graphics/FloatRect.cpp: (WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
• platform/graphics/FloatRect.h: (WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
• platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::createPlatformShadow): Use scaledSubRegion for calculation.
• platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply): Use scaledSubRegion for effect intern calculations.
• platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply): Use scaledSubRegion for effect intern calculations.
• platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply): Use scaledSubRegion for effect intern calculations.
• platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply): Use scaledSubRegion for effect intern calculations.
• platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply): Use scaledSubRegion for effect intern calculations.
• platform/graphics/filters/Filter.h: Add the abbility to change the quality of a filter output. (WebCore::Filter::filterResolution): (WebCore::Filter::setFilterResolution): (WebCore::Filter::calculateEffectSubRegion): Calculates the correct subRegion as well as the scaledSubRegion. It also searches for the biggest effect size. We have to change the filter resolution, if one intermediate ImageBuffer size doesn't fit in the maximal image size.
• platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::calculateDrawingIntRect): Use scaledSubRegion to get the right part of a previous effect result. (WebCore::FilterEffect::calculateDrawingRect): Use scaledSubRegion to get the right part of a previous effect result. (WebCore::FilterEffect::getEffectContext): Use scaledSubRegion to create a new intermediate ImageBuffer for the result of the current effect.
• platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::scaledSubRegion): The scaled subRegion of a the filter effect. (WebCore::FilterEffect::setScaledSubRegion): (WebCore::FilterEffect::effectBoundaries): The original values of the EffectElement for a second subRegion calculation. (WebCore::FilterEffect::setEffectBoundaries):
• platform/graphics/filters/ImageBufferFilter.cpp: (WebCore::ImageBufferFilter::ImageBufferFilter): Set the scale factor to one.
• platform/graphics/filters/ImageBufferFilter.h: (WebCore::ImageBufferFilter::maxImageSize): (WebCore::ImageBufferFilter::calculateEffectSubRegion):
• platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::calculateEffectRect): Use scaledSubRegion for effect intern calculations.
• platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::calculateEffectRect): Use scaledSubRegion for effect intern calculations.
• svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::parseMappedAttribute): Parse filterRes attribute. (WebCore::SVGFilterElement::buildFilter): Give SVGResourceFilter the current filterResolution.
• svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes): Save values to effectBoundaries of the filter effect
• svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::shouldProcessFilter): Return signal if a neccessary value is zero. (WebCore::SVGResourceFilter::fitsInMaximumImageSize): Checks if the given size fits into the maximal image size, modifys scale factors if not and return a bool: fits. (WebCore::SVGResourceFilter::prepareFilter): Scale the SourceImage to filterResolution (given by FilterElement or calculated on to big image sizes). Set the scale level to SVGFilter. (WebCore::SVGResourceFilter::applyFilter): Don't apply filters if shouldProcessFilter is wrong.
• svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::setFilterResolution): FilterResolution of FilterElement. (WebCore::SVGResourceFilter::setHasFilterResolution): Does FilterElement provides a FilterResolution? (WebCore::SVGResourceFilter::scaleX): Current scale factor for horizontal. (WebCore::SVGResourceFilter::scaleY): Current scale factor for vertical.
• svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply): Use scaledSubRegion for effect intern calculations. Kernel values are scaled to current filter resolution too.
• svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply): Use scaledSubRegion for effect intern calculations.
• svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply): Use scaledSubRegion for effect intern calculations. Kernel values are scaled to current filter resolution too.
• svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply): Use scaledSubRegion for effect intern calculations. Kernel values are scaled to current filter resolution too.
• svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply): Use scaledSubRegion for effect intern calculations.
• svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply): Use scaledSubRegion for effect intern calculations.
• svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::calculateEffectSubRegion): Calculate subRegion for LayoutTests, scaledSubRegion according to the current filterResolution and get the maximal image size.
• svg/graphics/filters/SVGFilter.h: (WebCore::SVGFilter::effectBoundingBoxMode): Original values of the FilterElement. (WebCore::SVGFilter::filterRegion): Use virtual for clarification. (WebCore::SVGFilter::sourceImageRect): Use virtual for clarification. (WebCore::SVGFilter::maxImageSize): Get the maximal image size.

8:05 AM Changeset in webkit [51309] by kdecker@apple.com

• 2 edits in trunk/WebKit/mac

Reviewed by Adam Roben.

<rdar://problem/7401503>

Added a workaround for plug-ins not drawing immediately.

• Plugins/WebBaseNetscapePluginView.mm: Added new constant. (-[WebBaseNetscapePluginView _clearSubstituteImage]): Added. (-[WebBaseNetscapePluginView resumeFromHalt]): Call above new method.

7:27 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

7:17 AM Changeset in webkit [51308] by eric@webkit.org

• 4 edits in trunk/WebKit/qt

2009-11-23 David Boddie <​dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Updated the QWebElement documentation with links to examples and
external resources.
Fixed the project file for the webelement snippet and tidied up the
markers used for quoting the code.

• Api/qwebelement.cpp:
• docs/webkitsnippets/webelement/main.cpp: (findAll):
• docs/webkitsnippets/webelement/webelement.pro:

7:02 AM QtBackLog edited by zecke@selfish.org

Mention QtPlugin bug (diff)

7:00 AM QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org

(diff)

6:37 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:31 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:29 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:29 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:25 AM QtWebKitJournal edited by Simon Hausmann

(diff)

5:04 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

5:02 AM Changeset in webkit [51307] by Simon Hausmann

• 2 edits in trunk/JavaScriptCore

[Symbian] Fix lastIndexOf() for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=31773

Patch by Laszlo Gombos <Laszlo Gombos> on 2009-11-23
Reviewed by Kenneth Rohde Christiansen.

Symbian soft floating point library has problems with operators
comparing NaN to numbers. Without a workaround lastIndexOf()
function does not work.

Patch developed by David Leong.

• runtime/StringPrototype.cpp:

(JSC::stringProtoFuncLastIndexOf):Add an extra test
to check for NaN for Symbian.

4:58 AM Changeset in webkit [51306] by eric@webkit.org

• 5 edits in trunk

2009-11-23 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Wrong runtime instance objects of wrapped QObjects may be used if
the wrapped object died before the gc removed the instance.

​https://bugs.webkit.org/show_bug.cgi?id=31681

Before using a cached instance, verify that its wrapped QObject is
still alive.

• bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getQtInstance):
• bridge/qt/qt_instance.h: (JSC::Bindings::QtInstance::hashKey):

2009-11-23 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Wrong runtime instance objects of wrapped QObjects may be used if
the wrapped object died before the gc removed the instance.

​https://bugs.webkit.org/show_bug.cgi?id=31681

Added a unit-test to verify that wrapping a QObject with the
same identity as a previously but now dead object works.

• tests/qwebframe/tst_qwebframe.cpp:

3:29 AM Changeset in webkit [51305] by steveblock@google.com

• 2 edits in trunk/JavaScriptCore

Android port lacks implementation of atomicIncrement and atomicDecrement

Nov 22, 2009:

10:21 PM Changeset in webkit [51304] by eric@webkit.org

• 12 edits
  2 adds in trunk

2009-11-22 Chris Fleizach <Chris Fleizach>

Reviewed by Oliver Hunt.

ARIA: support aria-flowto
​https://bugs.webkit.org/show_bug.cgi?id=31762

• platform/mac/accessibility/aria-flowto-expected.txt: Added.
• platform/mac/accessibility/aria-flowto.html: Added.

2009-11-22 Chris Fleizach <Chris Fleizach>

Reviewed by Oliver Hunt.

ARIA: support aria-flowto
​https://bugs.webkit.org/show_bug.cgi?id=31762

Test: platform/mac/accessibility/aria-flowto.html

• accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::ariaOwnsElements): (WebCore::AccessibilityObject::supportsARIAFlowTo): (WebCore::AccessibilityObject::ariaFlowToElements):
• accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::linkedUIElements): (WebCore::AccessibilityRenderObject::supportsARIAFlowTo): (WebCore::AccessibilityRenderObject::ariaFlowToElements):
• accessibility/AccessibilityRenderObject.h:
• html/HTMLAttributeNames.in:

2009-11-22 Chris Fleizach <Chris Fleizach>

Reviewed by Oliver Hunt.

ARIA: support aria-flowto
​https://bugs.webkit.org/show_bug.cgi?id=31762

• DumpRenderTree/AccessibilityUIElement.cpp: (ariaFlowToElementAtIndexCallback): (AccessibilityUIElement::getJSClass):
• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::ariaFlowToElementAtIndex):
• DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::ariaFlowToElementAtIndex):
• DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::ariaFlowToElementAtIndex):

8:27 PM Changeset in webkit [51303] by mitz@apple.com

• 4 edits in trunk/WebKitLibraries

Updated WebKitSystemInterface.

Reviewed by Eric Carlson.

• libWebKitSystemInterfaceLeopard.a:
• libWebKitSystemInterfaceSnowLeopard.a:
• libWebKitSystemInterfaceTiger.a:

7:45 PM Changeset in webkit [51302] by Laszlo Gombos

• 2 edits in trunk/JavaScriptCore

2009-11-22 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Sort source lists and remove obsolete comments
from the build system.

• JavaScriptCore.pri:

5:38 PM HighLevelOverview edited by chris.jerdonek@gmail.com

Added information about JavaScriptGlue (diff)

5:33 PM Changeset in webkit [51301] by eric@webkit.org

• 1 edit
  10 adds in trunk/LayoutTests

2009-11-22 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Tests to the filterRes implementation for SVG Filters
​https://bugs.webkit.org/show_bug.cgi?id=6021

big-sized-filter: tests if filter quality is scaled down on a too

big SourceImage (SourceGraphic, SourceAlpha)

big-sized-filter-2: tests if the filter quality is scaled down

on a too big filter effect size.

filterRes: Various tests of SVG Filters with different values for

filterRes attributes. Checks

• that kernel values (if present) are scaled with the filterRes
• subRegion calculation is correct for effects with deeper dependencies.

• platform/mac/svg/filters/big-sized-filter-2-expected.txt: Added.
• platform/mac/svg/filters/big-sized-filter-expected.checksum: Added.
• platform/mac/svg/filters/big-sized-filter-expected.png: Added.
• platform/mac/svg/filters/big-sized-filter-expected.txt: Added.
• platform/mac/svg/filters/filterRes-expected.checksum: Added.
• platform/mac/svg/filters/filterRes-expected.png: Added.
• platform/mac/svg/filters/filterRes-expected.txt: Added.
• svg/filters/big-sized-filter-2.svg: Added.
• svg/filters/big-sized-filter.svg: Added.
• svg/filters/filterRes.svg: Added.

5:29 PM Changeset in webkit [51300] by Nikolas Zimmermann

• 3 edits in trunk/WebCore

Not reviewed. Build fix for WML enabled builds.
Adopt WebCore API changes.

3:14 PM Changeset in webkit [51299] by tonikitoo@webkit.org

• 2 edits in trunk/WebKitTools

[Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
​https://bugs.webkit.org/show_bug.cgi?id=31638

Reviewed by Kenneth Christiansen.

Unfreeze WorkQueue after each test execution.

• DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

2:29 PM Changeset in webkit [51298] by eric@webkit.org

• 5 edits in trunk

2009-11-22 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Adam Barth.

[Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
for localhost and 127.0.0.1.
​https://bugs.webkit.org/show_bug.cgi?id=31783

Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.

• platform/qt/Skipped:

2009-11-22 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Adam Barth.

[Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
for localhost and 127.0.0.1.
​https://bugs.webkit.org/show_bug.cgi?id=31783

Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.

• DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::NetworkAccessManager::NetworkAccessManager): (WebCore::NetworkAccessManager::sslErrorsEncountered): (WebCore::WebPage::WebPage):
• DumpRenderTree/qt/DumpRenderTree.h:

12:54 PM BuildingQtOnLinux edited by faw217@gmail.com

libxslt is no longer required (diff)

12:05 PM Changeset in webkit [51297] by pfeldman@chromium.org

• 3 edits in trunk/WebCore

2009-11-22 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce sidebar background on timeline panel in order
to prevent it from flickering on scroll.

​https://bugs.webkit.org/show_bug.cgi?id=31789

• inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.setSidebarWidth): (WebInspector.TimelinePanel.prototype._onScroll): (WebInspector.TimelinePanel.prototype._scheduleRefresh):
• inspector/front-end/inspector.css:

10:25 AM Changeset in webkit [51296] by pfeldman@chromium.org

• 9 edits
  2 adds in trunk

2009-11-22 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Reimplement TimelinePanel to make it fast:

• Extract grid and overview into separate files
• Make timeline create only divs for visible rows

​https://bugs.webkit.org/show_bug.cgi?id=31784

• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.createInterface): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.set calculator):
• inspector/front-end/TimelineGrid.js: Added. (WebInspector.TimelineGrid): (WebInspector.TimelineGrid.prototype.get itemsGraphsElement): (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype.addEventDivider): (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
• inspector/front-end/TimelineOverviewPane.js: Added. (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype._onCheckboxClicked): (WebInspector.TimelineOverviewPane.prototype.update): (WebInspector.TimelineOverviewPane.prototype.setSidebarWidth): (WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth): (WebInspector.TimelineOverviewPane.prototype.reset): (WebInspector.TimelineOverviewPane.prototype._resizeWindow): (WebInspector.TimelineOverviewPane.prototype._windowResizeDragging): (WebInspector.TimelineOverviewPane.prototype._dragWindow): (WebInspector.TimelineOverviewPane.prototype._windowDragging): (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft): (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight): (WebInspector.TimelineOverviewPane.prototype._setWindowPosition): (WebInspector.TimelineOverviewPane.prototype._endWindowDragging): (WebInspector.TimelineOverviewCalculator): (WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineOverviewCalculator.prototype.reset): (WebInspector.TimelineOverviewCalculator.prototype.updateBoundaries): (WebInspector.TimelineOverviewCalculator.prototype.get boundarySpan): (WebInspector.TimelineOverviewCalculator.prototype.formatValue): (WebInspector.TimelineCategoryTreeElement): (WebInspector.TimelineCategoryTreeElement.prototype.onattach): (WebInspector.TimelineCategoryGraph): (WebInspector.TimelineCategoryGraph.prototype.get graphElement): (WebInspector.TimelineCategoryGraph.prototype.addChunk): (WebInspector.TimelineCategoryGraph.prototype.clearChunks): (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
• inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype.setSidebarWidth): (WebInspector.TimelinePanel.prototype.updateMainViewWidth): (WebInspector.TimelinePanel.prototype.resize): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype.show): (WebInspector.TimelinePanel.prototype._onScroll): (WebInspector.TimelinePanel.prototype._scheduleRefresh): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.prototype._adjustScrollPosition): (WebInspector.TimelineCategory): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.get boundarySpan): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update):
• inspector/front-end/WebKit.qrc:
• inspector/front-end/inspector.css:
• inspector/front-end/inspector.html:

9:22 AM Changeset in webkit [51295] by abarth@webkit.org

• 3 edits in trunk

2009-11-22 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Disable access to ​file:/// directory listings
​https://bugs.webkit.org/show_bug.cgi?id=31329

Updates the test to make sure it is disabling universal access for
​file:/// URLs (if the API is supported). This is required to do
effective intra-file:/// access tests.
Note that Safari only passes by virtual of supporting no directory
listings at all.

• fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html: Added.
• fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
• fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html: Disable universal access for ​file:/// URLs (if API available). Run the real test in an iframe without universal access.

2009-11-22 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Disable access to ​file:/// directory listings
​https://bugs.webkit.org/show_bug.cgi?id=31329

Deny access to directory listings. This needs doing in WebKit for
WebKit clients that do permit top-level navigation to ​file:///dir.
This matches Firefox, plus the existing Safari implementation (which
does not support any directory access at all). It will fix the
LayoutTest named below for Chromium.

Test: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html

• page/SecurityOrigin.cpp: Deny access to directory listings. (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canRequest):

2009-11-22 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Disable access to ​file:/// directory listings
​https://bugs.webkit.org/show_bug.cgi?id=31329

Implemented setAllowUniversalAccessFromFileURLs to support testing of
file URL security.

• DumpRenderTree/LayoutTestController.cpp: (setAllowUniversalAccessFromFileURLsCallback): (LayoutTestController::staticFunctions):
• DumpRenderTree/LayoutTestController.h:
• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
• DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
• DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
• DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):

9:22 AM Changeset in webkit [51294] by abarth@webkit.org

• 12 edits
  1 copy in trunk

2009-11-22 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Updates the test to make sure it is disabling universal access for
​file:/// URLs (if the API is supported). This is required to do
effective intra-file:/// access tests.
Note that Safari only passes by virtual of supporting no directory
listings at all.

• fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html: Added.
• fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
• fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html: Disable universal access for ​file:/// URLs (if API available). Run the real test in an iframe without universal access.

2009-11-22 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Deny access to directory listings. This needs doing in WebKit for
WebKit clients that do permit top-level navigation to ​file:///dir.
This matches Firefox, plus the existing Safari implementation (which
does not support any directory access at all). It will fix the
LayoutTest named below for Chromium.

Test: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html

• page/SecurityOrigin.cpp: Deny access to directory listings. (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canRequest):

2009-11-22 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Implemented setAllowUniversalAccessFromFileURLs to support testing of
file URL security.

• DumpRenderTree/LayoutTestController.cpp: (setAllowUniversalAccessFromFileURLsCallback): (LayoutTestController::staticFunctions):
• DumpRenderTree/LayoutTestController.h:
• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
• DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
• DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
• DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):

7:16 AM Changeset in webkit [51293] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-22 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the timeout of fast/frames/frame-navigation.html
​https://bugs.webkit.org/show_bug.cgi?id=31638

The test is timeouting, because it uses the WorkQueue to load a document in one
of the child frames and once the loading is finished, the DRT does not dump the
tree. This is because it waits for the QWebFrame::loadFinished() signal from
the main frame, while it should connect to QWebPage::loadFinished().

• DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):

2:04 AM Changeset in webkit [51292] by mitz@apple.com

• 4 edits in trunk/WebKitLibraries

Fixed a leak in WKDrawMediaUIPart().

Reviewed by Cameron Zwarich.

• libWebKitSystemInterfaceLeopard.a:
• libWebKitSystemInterfaceSnowLeopard.a:
• libWebKitSystemInterfaceTiger.a:

Nov 21, 2009:

7:39 PM Changeset in webkit [51291] by Joseph Pecoraro

• 2 edits in trunk/WebCore

2009-11-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Support Ctrl+P and Ctrl+N, Readline keyboard shortcuts in the Console
​https://bugs.webkit.org/show_bug.cgi?id=31400

Handle the following when on a Mac:

Ctrl+P = Previous (like Up arrow)
Ctrl+N = Next (like Down arrow)

No longer rerun autocompletion when just pushing a modifier key
like Control, Alt, Shift, or Meta.

Improved arrow key behavior with Multiline code in the Console, with the following behavior:

Up = Previous Command if on First Line (caret moves to the end of the first line)

otherwise default caret movement in text.

Down = Next Command if on Last Line (caret naturally moves to the end)

otherwise default caret movement in text.

• inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.handleKeyEvent): handle new keyboard shortcuts (WebInspector.TextPrompt.prototype.isCaretOnFirstLine): check if the caret is on the top line (WebInspector.TextPrompt.prototype.isCaretOnLastLine): check if the caret is on the bottom line (WebInspector.TextPrompt.prototype._upKeyPressed): (WebInspector.TextPrompt.prototype._downKeyPressed): (WebInspector.TextPrompt.prototype._moveBackInHistory): (WebInspector.TextPrompt.prototype._moveForwardInHistory):

7:04 PM Changeset in webkit [51290] by jberlin@webkit.org

• 2 edits in trunk/WebCore

Adds a tooltip containing the full url of the resource to each element
in the Resources panel so that it is possible to quickly see the query
parameters.
​https://bugs.webkit.org/show_bug.cgi?id=19103

Reviewed by Timothy Hatcher.

• inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourceSidebarTreeElement.prototype.refresh):
Set the tooltip to be the resource's url.

4:18 PM Changeset in webkit [51289] by Simon Fraser

• 5 edits in trunk

2009-11-21 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages
​https://bugs.webkit.org/show_bug.cgi?id=31588

In WebKitCSSKeyframesRule::findRuleIndex(), map 'from' to 0% an 'to' to 100%
so that findRule() and deleteRule() work with these keywords.

• css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::findRuleIndex):

3:13 PM Changeset in webkit [51288] by eric@webkit.org

• 2 edits in trunk/JavaScriptCore

2009-11-21 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt][Mac] Turn on multiple JavaScript threads for QtWebkit on Mac
​https://bugs.webkit.org/show_bug.cgi?id=31753

• wtf/Platform.h:

1:34 PM Changeset in webkit [51287] by eric@webkit.org

• 8 edits in trunk/WebKitTools

2009-11-21 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool --help spews way too much text
​https://bugs.webkit.org/show_bug.cgi?id=31771

• Scripts/bugzilla-tool:
  • Remove self.cached_scm initialization hack.
• Scripts/modules/buildbot.py:
  • Make default_host accessible to callers.
• Scripts/modules/commands/download.py:
  • Phrase help for all commands consistently and remove spurious help text punctuation.
• Scripts/modules/commands/queries.py: Ditto.
• Scripts/modules/commands/queues.py: Ditto.
• Scripts/modules/commands/upload.py: Ditto.
• Scripts/modules/multicommandtool.py:
  • Add HelpPrintingOptionParser.format_epilog to replace NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
  • Make --help only show a list of commands like "svn help" and "git help" do -- previously --help was listing all commands and options.
  • Sort list of commands alphabetically.

1:32 PM Changeset in webkit [51286] by jhoneycutt@apple.com

• 2 edits in trunk/WebKit/win

2009-11-21 Jon Honeycutt <​jhoneycutt@apple.com>

Windows build fix. Unreviewed.

• Interfaces/IWebSerializedJSValue.idl:

1:26 PM Changeset in webkit [51285] by eric@webkit.org

• 3 edits in trunk/WebCore

2009-11-21 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31647

Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.

No functionality was changed. So, no new tests.

• dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::~KeyboardEvent):
• dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr. (WebCore::KeyboardEvent::keyEvent):

1:12 PM Changeset in webkit [51284] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-21 Eric Seidel <​eric@webkit.org>

No review. Fixing a typo from the previous patch for bug 31767.

AbstractQueue.run_bugzilla_tool throws an exception
​https://bugs.webkit.org/show_bug.cgi?id=31769

• Scripts/modules/commands/queues.py:

7:50 AM Changeset in webkit [51283] by eric@webkit.org

• 5 edits in trunk/WebKitTools

2009-11-21 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
​https://bugs.webkit.org/show_bug.cgi?id=31767

What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
Since we don't have a good way to test BugzillaTool pieces, I've
left out a test for now.

• Scripts/bugzilla-tool:
  • Add a path() implementation to expose bugzilla-tool's file path to commit-queue.
• Scripts/modules/commands/queues.py:
  • Use tool.path() instead of file.
• Scripts/modules/multicommandtool.py:
  • Add a new path() method to MultiComandTool.
• Scripts/modules/multicommandtool_unittest.py:
  • Provide a path() method. Little point in testing this mock implementation.

7:37 AM Changeset in webkit [51282] by abarth@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-21 Adam Barth <​abarth@webkit.org>

Unreviewed "build" fix. Turns out I was testing the wrong copy of
WebKitTools.

• Scripts/modules/commands/download.py:

7:29 AM Changeset in webkit [51281] by abarth@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Convert check-style to use LandingSequence
​https://bugs.webkit.org/show_bug.cgi?id=31763

Instead of manipulating the working copy by hand, we should use the
LandingSequence in CheckStyle. This will make this code eaiser to
test.

• Scripts/modules/commands/download.py:

12:53 AM Web Inspector Update.ja edited by keishi@webkit.org

(diff)

12:52 AM WebKit nightlies support HTML5 noreferrer link relation.ja created by keishi@webkit.org

12:50 AM Web Inspector Update.ja edited by keishi@webkit.org

(diff)

12:48 AM Surfin' Safari Translations edited by keishi@webkit.org

(diff)

Nov 20, 2009:

8:50 PM Changeset in webkit [51280] by jhoneycutt@apple.com

• 2 edits in trunk/WebKit/win

DOMElement::tagName() is unimplemented

​https://bugs.webkit.org/show_bug.cgi?id=31746

Reviewed by Darin Adler.

• DOMCoreClasses.cpp:

(DOMElement::tagName):
Create a BString from the element's tag name, and release its BSTR
into result.

8:50 PM Changeset in webkit [51279] by jhoneycutt@apple.com

• 2 edits in trunk/WebKit/win

DOMNode::childNodes() is unimplemented

​https://bugs.webkit.org/show_bug.cgi?id=31745

Reviewed by Darin Adler.

• DOMCoreClasses.cpp:

(DOMNode::childNodes):
Create a DOMNodeList from the node's child nodes.

8:06 PM Changeset in webkit [51278] by abarth@webkit.org

• 2 edits
  2 copies in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Unit test query commands
​https://bugs.webkit.org/show_bug.cgi?id=31755

These tests are pretty rough, but hopefully they'll grow.

• Scripts/modules/commands/queries_unittest.py: Added.
• Scripts/modules/mock_bugzillatool.py: Added.
• Scripts/run-webkit-unittests:

7:53 PM Changeset in webkit [51277] by abarth@webkit.org

• 6 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
​https://bugs.webkit.org/show_bug.cgi?id=31758

• Scripts/modules/multicommandtool.py:
  • Allow passing of explicit commands to MultiCommandTool.init
• Scripts/modules/multicommandtool_unittest.py:
  • Use new Command.name naming system.
  • Test Command auto-discovery.
• Scripts/modules/workqueue.py:
  • bug_id no longer exists, use patchbug_id instead.
• Scripts/modules/workqueue_unittest.py:
  • WorkQueues require names now.
  • should_proceed_with_work_item must return a patch object.

7:29 PM Changeset in webkit [51276] by Chris Fleizach

• 13 edits
  2 adds in trunk

WAI-ARIA: add support for aria-owns
​https://bugs.webkit.org/show_bug.cgi?id=31702

Reviewed by Beth Dakin.

WebCore:

Re-organized how accessibilityAttributeNames are returned so
that it's possible for an element to add an attribute based on
a dynamic value. In this case, we only want to add AXOwn if the
element actually supports aria-owns.

Test: platform/mac/accessibility/aria-owns.html

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::supportsARIAOwns):
(WebCore::AccessibilityObject::ariaOwnsElements):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaOwnsElements):
(WebCore::AccessibilityRenderObject::supportsARIAOwns):

• accessibility/AccessibilityRenderObject.h:
• accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

• html/HTMLAttributeNames.in:

WebKitTools:

• DumpRenderTree/AccessibilityUIElement.cpp:

(ariaOwnsElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):

• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::ariaOwnsElementAtIndex):

• DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::ariaOwnsElementAtIndex):

• DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::ariaOwnsElementAtIndex):

LayoutTests:

• platform/mac/accessibility/aria-owns-expected.txt: Added.
• platform/mac/accessibility/aria-owns.html: Added.

7:14 PM Changeset in webkit [51275] by eric@webkit.org

• 3 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix exception thrown when running the commit-queue.

• Scripts/modules/statusbot.py: patch is optional.
• Scripts/modules/workqueue.py: WorkQUeue requires a name.

6:54 PM Changeset in webkit [51274] by hyatt@apple.com

• 4 edits in trunk/WebKit/win

Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the
serialization into a separate serialize() function that can be called after the object has been
created.

Reviewed by Jon Honeycutt.

Fix a typo in serialize() caused when fixing build bustage (put a ! back in).

• Interfaces/IWebSerializedJSValue.idl:
• WebSerializedJSValue.cpp:

(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::serialize):
(WebSerializedJSValue::deserialize):

• WebSerializedJSValue.h:

6:36 PM Changeset in webkit [51273] by bweinstein@apple.com

• 7 edits in trunk/WebKit/win

Another go at the Windows Build Fix - this is a couple steps of it,
so a little more involved than most build fixes.

Reviewed by Dave Hyatt.

• Interfaces/IWebSerializedJSValue.idl:
• Interfaces/JavaScriptCoreAPITypes.idl:
• WebKit.vcproj/Interfaces.vcproj:
• WebSerializedJSValue.cpp:

(WebSerializedJSValue::deserialize):

• WebSerializedJSValue.h:

6:07 PM Changeset in webkit [51272] by hyatt@apple.com

• 2 edits in trunk/WebKit/mac

Make sure to export WebSerializedJSValue.

Reviewed by Darin Adler.

• WebKit.exp:

5:54 PM Changeset in webkit [51271] by bweinstein@apple.com

• 5 edits
  1 add in trunk/WebKit/win

Build fix for Windows - only declare JSContextRef once, instead
of in two different idl files. Create a new file to hold the
definition of JSContextRef.

Reviewed by Dave Hyatt.

• Interfaces/IWebFrameLoadDelegate.idl:
• Interfaces/IWebSerializedJSValue.idl:
• Interfaces/JavaScriptCoreAPITypes.idl: Added.
• Interfaces/WebKit.idl:
• WebKit.vcproj/Interfaces.vcproj:

5:44 PM Changeset in webkit [51270] by eric.carlson@apple.com

• 12 edits in trunk

2009-11-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element

• css/mediaControls.css:

Define closed caption toggle button.

• rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):

Create closed caption toggle button in display order.

• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldRenderMediaControlPart):

Don't require MediaControllerThemeQuickTime theme for captions toggle button.
No need to check if the movie has video, a closed captions track is a video
track.

2009-11-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element

• WebKitSystemInterface.h:
• libWebKitSystemInterfaceLeopard.a:
• libWebKitSystemInterfaceSnowLeopard.a:
• libWebKitSystemInterfaceTiger.a:

2009-11-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element

Remove closed captions test from skipped list.

• platform/mac-leopard/Skipped:
• platform/mac-tiger/Skipped:

5:34 PM Changeset in webkit [51269] by jianli@chromium.org

• 3 edits in trunk/WebKit/chromium

Not reviewed. Fix chromium build.

• public/WebAccessibilityRole.h:

(WebKit::):

• src/AssertMatchingEnums.cpp:

5:18 PM Changeset in webkit [51268] by Joseph Pecoraro

• 2 edits in trunk/WebCore

2009-11-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Running code in the Console that ends with a
single line comment no longer produces a parse error.

• inspector/front-end/InjectedScript.js: (InjectedScript._evaluateOn):

5:17 PM Changeset in webkit [51267] by hyatt@apple.com

• 6 edits
  5 adds in trunk/WebKit

Add support for WebSerializedJSValue to WebKit. This object wraps the SerializedScriptValue functionality in WebCore
and exposes the ability to do JS value serialization/deserialization to WebKit clients.

Reviewed by Oliver Hunt and Jon Honeycutt.

WebKit:

• WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

• WebView/WebSerializedJSValue.h: Added.
• WebView/WebSerializedJSValue.mm: Added.

(-[WebSerializedJSValue initWithValue:context:]):
(-[WebSerializedJSValue deserialize:]):
(-[WebSerializedJSValue dealloc]):

WebKit/win:

• Interfaces/IWebSerializedJSValue.idl: Added.
• Interfaces/WebKit.idl:
• WebKit.vcproj/WebKit.vcproj:
• WebSerializedJSValue.cpp: Added.

(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::~WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::AddRef):
(WebSerializedJSValue::Release):
(WebSerializedJSValue::QueryInterface):
(WebSerializedJSValue::deserialize):

• WebSerializedJSValue.h: Added.

5:15 PM Changeset in webkit [51266] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Teach the StatusBot how to support more than just the commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=31754

• Scripts/modules/workqueue.py: Another typo.

5:09 PM Changeset in webkit [51265] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Teach the StatusBot how to support more than just the commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=31754

• Scripts/modules/commands/queues.py: Fix silly typo.

5:02 PM Changeset in webkit [51264] by eric@webkit.org

• 7 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Teach the StatusBot how to support more than just the commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=31754

• CommitQueueStatus/index.yaml:
  • Add indices required for the new queries.
• CommitQueueStatus/queue_status.py:
  • Add a patch-status page and move update_status to update-status.
  • Only display "commit-queue" status records for the commit-queue.
  • Add support for a queue_name property on status records.
  • Fix _int_from_request to actually work.
• CommitQueueStatus/update_status.html:
  • Add support for a queue_name on status records.
  • Remove unused list of bug ids.
  • Scripts/modules/commands/queues.py
    • Make the queues pass the patch instead of the bug_id to StatusBot.
• Scripts/modules/statusbot.py:
  • Support passing the queue_name to the status updates.
  • Support fetching patch status with patch_status().
• Scripts/modules/workqueue.py:
  • Pass the patch to the StatusBot instead of the bug_id.
  • Let WorkQueues have a name.

4:15 PM Changeset in webkit [51263] by abarth@webkit.org

• 2 edits
  7 adds in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move bugzilla-tool commands into their own file
​https://bugs.webkit.org/show_bug.cgi?id=31752

This will let us write unit tests.

• Scripts/bugzilla-tool:
• Scripts/modules/commands/init.py: Added.
• Scripts/modules/commands/download.py: Added.
• Scripts/modules/commands/queries.py: Added.
• Scripts/modules/commands/queues.py: Added.
• Scripts/modules/commands/upload.py: Added.
• Scripts/modules/grammar.py: Added.

4:00 PM Changeset in webkit [51262] by eric@webkit.org

• 12 edits in trunk

2009-11-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

WAI-ARIA: add support for 'math' role
​https://bugs.webkit.org/show_bug.cgi?id=31706

• platform/mac/accessibility/aria-grouping-roles-expected.txt:
• platform/mac/accessibility/aria-grouping-roles.html:

2009-11-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

WAI-ARIA: add support for 'math' role
​https://bugs.webkit.org/show_bug.cgi?id=31706

• accessibility/AccessibilityObject.cpp:
• accessibility/AccessibilityObject.h:
• accessibility/mac/AccessibilityObjectWrapper.mm:

2009-11-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

WAI-ARIA: add support for 'math' role
​https://bugs.webkit.org/show_bug.cgi?id=31706

• English.lproj/Localizable.strings:
• StringsNotToBeLocalized.txt:

2009-11-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

WAI-ARIA: add support for 'math' role
​https://bugs.webkit.org/show_bug.cgi?id=31706

• WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory AXARIAContentGroupText:]):

2:54 PM Changeset in webkit [51261] by abarth@webkit.org

• 1 edit in trunk/WebKitTools/ChangeLog

Fix ChangeLog

2:52 PM Changeset in webkit [51260] by abarth@webkit.org

• 4 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.
Reviewed by Eric Seidel.

BuildQueue should check if the tree is currently buildable
​https://bugs.webkit.org/show_bug.cgi?id=31744

• Scripts/bugzilla-tool:
• Scripts/modules/landingsequence.py:
• Scripts/modules/webkitlandingscripts.py:

2:51 PM Changeset in webkit [51259] by abarth@webkit.org

• 3 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move prepare_clean_working_directory into the LandingSequence
​https://bugs.webkit.org/show_bug.cgi?id=31743

• Scripts/bugzilla-tool:
• Scripts/modules/landingsequence.py:

2:34 PM Changeset in webkit [51258] by yael.aharon@nokia.com

• 3 edits in trunk/LayoutTests

Unreviewed fix.

Fix file names in the skipped list, for files added in ​http://trac.webkit.org/changeset/51257.

1:40 PM Changeset in webkit [51257] by yael.aharon@nokia.com

• 7 edits
  4 adds in trunk

NPN_ReloadPlugins does not reload the page even if reloadPages is true.
​https://bugs.webkit.org/show_bug.cgi?id=30460

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Replace call to PluginDatabase::installedPlugins()->refresh() with Page::refreshPlugins().
It already refreshes plugins and reloads pages when necessary.

Tests: plugins/reloadplugins-and-pages.html

plugins/reloadplugins-no-pages.html

• plugins/PluginInfoStore.cpp:

(WebCore::refreshPlugins):

WebKitTools:

Added code for calling NPN_ReloadPlugins with reloadPages true and false.

• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:

(pluginInvoke):

LayoutTests:

Added tests for calling NPN_ReloadPlugins with reloadPages being true and false.

1:32 PM Changeset in webkit [51256] by oliver@apple.com

• 4 edits in trunk/WebCore

<rdar://7409188> WebKit needs to be able to serialize and deserialize objects.

Reviewed by Dave Hyatt.

Expose WebCore object serialization to WebKit.

1:29 PM Changeset in webkit [51255] by bweinstein@apple.com

• 2 edits in trunk/WebCore

Fixes <​http://webkit.org/b/31741>.
Web Inspector: User Entered Data on the console should show up no matter what filters.

Reviewed by Tim Hatcher.

Always show .console-user-command-result, no matter what the filter say
we should do with the other classes.

• inspector/front-end/inspector.css:

1:29 PM Changeset in webkit [51254] by ap@apple.com

• 1 edit
  2 adds in trunk/LayoutTests

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25381
Needs test: jQuery animation crashing Safari

Adding a regression test for a bug that doesn't reproduce in ToT.

• fast/dynamic/jQuery-animation-crash-expected.txt: Added.
• fast/dynamic/jQuery-animation-crash.html: Added.

1:03 PM Changeset in webkit [51253] by abarth@webkit.org

• 5 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Pass the port information to the child process
​https://bugs.webkit.org/show_bug.cgi?id=31736

We need to do this so the child process knows what to build!

• Scripts/bugzilla-tool:
• Scripts/modules/landingsequence.py:
• Scripts/modules/webkitport.py:
• Scripts/modules/webkitport_unittest.py:

12:26 PM Changeset in webkit [51252] by ap@apple.com

• 2 edits in trunk/LayoutTests

WebSocket tests still don't work on Windows, disabling for futher invesigation.

• platform/win/Skipped:

11:55 AM Changeset in webkit [51251] by bweinstein@apple.com

• 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Fix a closing tag issue in the vcproj and remove tabs.

11:51 AM Changeset in webkit [51250] by bweinstein@apple.com

• 7 edits in trunk/WebCore

Fixes <​http://webkit.org/b/31700>.
Web Inspector: isMac should be in one central location + Cached.

Reviewed by Tim Hatcher.

We should cache the value of isMac, and make the indexOf call in one
single location, because we are calling it from multiple places, and saving
the result can save us time, and make the call sites simpler.

• inspector/front-end/AbstractTimelinePanel.js:

(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

• inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._updateFilter):

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleKeyEvent):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

• inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._loaded):

• inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):
(WebInspector.isMac):

11:31 AM Changeset in webkit [51249] by abarth@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Support Qt port in build-queue
​https://bugs.webkit.org/show_bug.cgi?id=31733

• Scripts/bugzilla-tool:

11:22 AM Changeset in webkit [51248] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement a build-queue
​https://bugs.webkit.org/show_bug.cgi?id=31725

Currently this just builds the first 10 patches in the review queue.
We'll want to do something smarter soon.

• Scripts/bugzilla-tool:

11:22 AM Changeset in webkit [51247] by ap@apple.com

• 2 edits in trunk/LayoutTests

Enabling WebSocket tests on Windows - let's see if they pass after the recent fixes.

• platform/win/Skipped:

11:19 AM Changeset in webkit [51246] by Joseph Pecoraro

• 1 edit
  1 delete in trunk/WebCore

2009-11-19 Joseph Pecoraro <Joseph Pecoraro>

Removed .DS_Store accidentally added in last (r51245).

11:11 AM Changeset in webkit [51245] by Joseph Pecoraro

• 12 edits
  3 adds in trunk/WebCore

2009-11-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Add Console Only Layout Mode
​https://bugs.webkit.org/show_bug.cgi?id=30282

Adds a Console Panel, which allows for a Full size Console. This
extends the Drawer to the size of a Panel. This also fixes previous
resize issues with the Drawer.

• inspector/front-end/ConsolePanel.js: added. (WebInspector.ConsolePanel): (WebInspector.ConsolePanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide):
• inspector/front-end/Drawer.js: (WebInspector.Drawer): (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.get savedHeight): access the saved height of the variable console. (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show): (WebInspector.Drawer.prototype.hide.animationFinished): (WebInspector.Drawer.prototype.hide): (WebInspector.Drawer.prototype.resize): resize appropriately if full/non-full (WebInspector.Drawer.prototype.enterPanelMode): (WebInspector.Drawer.prototype.exitPanelMode): (WebInspector.Drawer.prototype.immediatelyExitPanelMode): (WebInspector.Drawer.prototype._cancelAnimationIfNeeded): (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): (WebInspector.Drawer.prototype._animateDrawerHeight): (WebInspector.Drawer.prototype._animationDuration): (WebInspector.Drawer.prototype._startStatusBarDragging): (WebInspector.Drawer.prototype._statusBarDragging): (WebInspector.Drawer.prototype._endStatusBarDragging):

Miscellaneous changes and cleanup.

• English.lproj/localizedStrings.js: "Console" toolbar title.
• inspector/front-end/ConsoleView.js: removed unnecessary element reordering
• inspector/front-end/Images/consoleIcon.png: added.
• inspector/front-end/inspector.css: added icon.
• inspector/front-end/inspector.html:
• inspector/front-end/inspector.js: (WebInspector._createPanels): create console panel (WebInspector.windowResize): resize drawer if necessary (WebInspector.documentKeyDown): esc should not toggle the console when in panel mode (WebInspector.animateStyle): start animation interval, returns the interval key (WebInspector.toggleAttach): resize drawer if necessary (WebInspector.showConsolePanel): restore the panel when the inspector restarts (WebInspector.showProfileForURL): style fix

Restore the panel when the inspector restarts.

• inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::specialPanelForJSName):
• inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):

Build files.

• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• inspector/front-end/WebKit.qrc:

11:06 AM Changeset in webkit [51244] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make commit-queue and style-queue show up in help
​https://bugs.webkit.org/show_bug.cgi?id=31724

We need to store their names on their class to make these commands
properly register themselves with MultiCommandTool.

• Scripts/bugzilla-tool:

10:57 AM Changeset in webkit [51243] by eric@webkit.org

• 4 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement bugzilla-tool build-attachment
​https://bugs.webkit.org/show_bug.cgi?id=31722

This command builds an attachment from bugzilla. It leaves the built
patch in the working copy.

• Scripts/bugzilla-tool:
• Scripts/modules/landingsequence.py:
• Scripts/modules/webkitlandingscripts.py:

10:40 AM Changeset in webkit [51242] by bweinstein@apple.com

• 7 edits in trunk/WebCore

Fixes <​http://webkit.org/b/31699>.
Web Inspector: Should Cache Values of InspectorController.platform() and port().

Reviewed by Tim Hatcher.

Refactor the Inspector to cache the value of InspectorController.platform
and InspectorController.port, because those need to call into C++, they are
being called more and more as we add platform specific keyboard shortcuts, and
they shouldn't change in the lifecycle of the Web Inspector.

• inspector/front-end/AbstractTimelinePanel.js:

(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

• inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._updateFilter):

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleKeyEvent):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

• inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._loaded):

• inspector/front-end/inspector.js:

(WebInspector.get platform):
(WebInspector.get port):
(WebInspector.loaded):
(WebInspector.documentKeyDown):
(WebInspector.toolbarDragStart):

9:53 AM Changeset in webkit [51241] by eric@webkit.org

• 1 edit
  2 adds in trunk/LayoutTests

2009-11-20 Victor Wang <​victorw@chromium.org>

Reviewed by Darin Adler.

Add expected pixel result for layout test input-file-re-render

​https://bugs.webkit.org/show_bug.cgi?id=31696

• platform/mac/fast/forms/input-file-re-render-expected.checksum: Added.
• platform/mac/fast/forms/input-file-re-render-expected.png: Added.

9:49 AM Changeset in webkit [51240] by krit@webkit.org

• 8 edits in trunk/WebCore

2009-11-20 Dirk Schulze <​krit@webkit.org>

Unreviewed build fix for filters enabled builds.

• platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
• platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
• platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
• svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::applyFilter):
• svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
• svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
• svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):

9:45 AM Changeset in webkit [51239] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT release event does not create the state correctly
​https://bugs.webkit.org/show_bug.cgi?id=31717

• WebKitTools/DumpRenderTree/gtk/EventSender.cpp:

9:27 AM Changeset in webkit [51238] by eric.carlson@apple.com

• 7 edits in trunk

2009-11-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7389945> QTKit based media engine should not claim to support
fullscreen on Leopard

• platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsFullscreen):

Only return true on SnowLeopard for now.

• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldRenderMediaControlPart):

No need to special case MediaFullscreenButtonPart as the default implementation
asks the media engine if it supports fullscreen.

2009-11-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7389945> QTKit based media engine should not claim to support fullscreen on Leopard

Update test results.

• platform/mac/media/audio-controls-rendering-expected.checksum:
• platform/mac/media/audio-controls-rendering-expected.png:
• platform/mac/media/audio-controls-rendering-expected.txt:

6:54 AM Changeset in webkit [51237] by abarth@webkit.org

• 3 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

MultiCommandTool should find Command objects automatically instead of with a manual list
​https://bugs.webkit.org/show_bug.cgi?id=31710

• Scripts/bugzilla-tool:
• Scripts/modules/multicommandtool.py:
  • Use some wild python-fu to crawl all the known subclasses of Command.

6:45 AM Changeset in webkit [51236] by abarth@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Unreviewed "build" fix. Added missing import.

• Scripts/bugzilla-tool:

6:44 AM Changeset in webkit [51235] by abarth@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Unreviewed "build" fix. I failed to update LandingSequence.test
properly.

• Scripts/modules/landingsequence.py:

6:21 AM QtWebKitBackportingFixes created by Simon Hausmann

5:47 AM QtWebKitContrib edited by Simon Hausmann

(diff)

4:29 AM QtWebKitJournal edited by Simon Hausmann

(diff)

3:18 AM Changeset in webkit [51234] by Girish Ramakrishnan

• 4 edits in trunk/WebCore

[Qt] Implement support for rendering plugins on Qt/Mac when a page is used
without a QWebView or when inside QGraphicsWebView.

Reviewed by Simon Hausmann.

Patch by Yongjun Zhang <​yongjun.zhang@nokia.com> and

Girish Ramakrishnan <Girish Ramakrishnan>

Currently, the code provides the cgcontext of the PlatformPluginWidget to
the plugin. This approach does not work when we are printing, or using
QWebFrame::render() to render to a QImage/QPixmap since the plugin ends
up drawing on the QWebView (i.e platformPluginWidget's cgcontext) instead
of the QPaintDevice's context.

To solve all cases and keep the code simple, we render the plugin to an
offscreen pixmap in all cases. This way, the plugin always renders to the
CGContext of the pixmap and we then use QPainter to blit the pixmap into
the QPaintDevice. We also create a fake window and set it's WindowRef in
NPWindow. Only with this WindowRef does Flash paint correctly to the QPixmap.

Now, that's the theory. In practice, ATM, mouse events do not work when using
the fake window. So, setPlatformPluginWidget() is still called when using QWebView
so that there are no regressions after this patch. Once we get mouse events
working, setPlatformPluginWidget will be removed.

​https://bugs.webkit.org/show_bug.cgi?id=31183

1:01 AM Changeset in webkit [51233] by eric@webkit.org

• 2 edits
  2 adds in trunk/WebKitTools

2009-11-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Create LandingSequence as the all-sing, all-dance landing class
​https://bugs.webkit.org/show_bug.cgi?id=31709

Client can inherit from this class to carefully control exactly which
steps they wish to have happen in the landing sequence.

• Scripts/bugzilla-tool:
• Scripts/modules/landingsequence.py: Added.
• Scripts/modules/webkitlandingscripts.py: Added.

Nov 19, 2009:

11:01 PM Changeset in webkit [51232] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
​https://bugs.webkit.org/show_bug.cgi?id=31707

This is to help when we implement build-attachment.

• Scripts/bugzilla-tool:

10:43 PM Changeset in webkit [51231] by eric@webkit.org

• 3 edits
  2 copies in trunk/WebKitTools

2009-11-19 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Support Qt port in bugzilla-tool
​https://bugs.webkit.org/show_bug.cgi?id=31701

Now we support building with Qt!

• Scripts/bugzilla-tool:
• Scripts/modules/webkitport.py: Added.
• Scripts/modules/webkitport_unittest.py: Added.
• Scripts/run-webkit-unittests:

10:20 PM Changeset in webkit [51230] by eric@webkit.org

• 3 edits in trunk/WebKitTools

2009-11-19 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Adam Barth.

Remove inserting stderr into patch in bugzilla-tool
​https://bugs.webkit.org/show_bug.cgi?id=29914

Modify SCM python module's run_command function to avoid return of stderr
by default, so stderr won't be inserted into the patches.
Modify the related unit test.

• Scripts/modules/scm.py:
• Scripts/modules/scm_unittest.py:

10:17 PM Changeset in webkit [51229] by Joseph Pecoraro

• 2 edits in trunk/WebCore

2009-11-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Resync Resources Backend and Frontend
​https://bugs.webkit.org/show_bug.cgi?id=31705

• inspector/front-end/Resource.js: resync enum values with backend (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): return false if all else fails, not true in all cases

10:03 PM Changeset in webkit [51228] by eric@webkit.org

• 4 edits in trunk

2009-11-19 Steve Block <​steveblock@google.com>

Android port lacks configuration in Platform.h and config.h.
​https://bugs.webkit.org/show_bug.cgi?id=31671

• wtf/Platform.h: Modified. Added Android-specific configuration.

2009-11-19 Steve Block <​steveblock@google.com>

Reviewed by Darin Fisher.

Android port lacks configuration in Platform.h and config.h.
​https://bugs.webkit.org/show_bug.cgi?id=31671

Build change only. No new tests possible.

• config.h: Modified. Added Android-specific configuration.

9:44 PM Changeset in webkit [51227] by rolandsteiner@chromium.org

• 3 edits
  2 adds in trunk

2009-11-20 Roland Steiner <​rolandsteiner@chromium.org>

WebCore: Change default stylesheet to reset text indentation for ruby elements by default.
(​https://bugs.webkit.org/show_bug.cgi?id=31247)

Reviewed by Darin Adler.

Test: fast/ruby/ruby-text-indent.html

• css/html.css: reset text-indent on <ruby> and <rt> elements

LayoutTests: Test checking that CSS 'text-indent' does not affect ruby rendering by default.
(​https://bugs.webkit.org/show_bug.cgi?id=31247)

Reviewed by Darin Adler.

• fast/ruby/ruby-text-indent-expected.txt: Added.
• fast/ruby/ruby-text-indent.html: Added.

6:18 PM Changeset in webkit [51226] by eric@webkit.org

• 3 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool needs per-command help
​https://bugs.webkit.org/show_bug.cgi?id=31697

Added support for "bugzilla-tool help command-name"
and a unit test to make sure it works.

• Scripts/modules/multicommandtool.py:
• Scripts/modules/multicommandtool_unittest.py:

6:12 PM Changeset in webkit [51225] by bweinstein@apple.com

• 2 edits in trunk/WebCore

Fixes <​http://webkit.org/b/22754>.
Web Inspector: Keyboard shortcut for Element finder.

Reviewed by Darin Adler.

Use Command + Shift + C as a shortcut for Node Search, to
match the Firebug shortcut to do the same thing.

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleKeyEvent):

5:09 PM Changeset in webkit [51224] by eric@webkit.org

• 12 edits in trunk/WebKit/chromium

2009-11-19 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Fisher.

Make chromium/webkit/glue/FormFieldValues use the WebKit API

​https://bugs.webkit.org/show_bug.cgi?id=31650

• public/WebElement.h:
• public/WebFormElement.h:
• public/WebInputElement.h: (WebKit::WebInputElement::):
• public/WebNode.h:
• src/AssertMatchingEnums.cpp:
• src/DOMUtilitiesPrivate.cpp: (WebKit::nameOfInputElement):
• src/DOMUtilitiesPrivate.h:
• src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill): (WebKit::EditorClientImpl::doAutofill):
• src/WebFormElement.cpp: (WebKit::WebFormElement::name): (WebKit::WebFormElement::method): (WebKit::WebFormElement::getNamedElements): (WebKit::WebFormElement::getInputElements):
• src/WebInputElement.cpp: (WebKit::WebInputElement::isEnabledFormControl): (WebKit::WebInputElement::inputType): (WebKit::WebInputElement::formControlType): (WebKit::WebInputElement::value): (WebKit::WebInputElement::dispatchFormControlChangeEvent): (WebKit::WebInputElement::setSelectionRange): (WebKit::WebInputElement::name): (WebKit::WebInputElement::nameForAutofill):
• src/WebNode.cpp: (WebKit::WebNode::frame):

4:55 PM Changeset in webkit [51223] by eric@webkit.org

• 3 edits
  2 adds in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move MultiCommandTool and Command into a separate file and add some basic unit tests
​https://bugs.webkit.org/show_bug.cgi?id=31695

• Scripts/bugzilla-tool:
• Scripts/modules/multicommandtool.py: Added.
• Scripts/modules/multicommandtool_unittest.py: Added.
• Scripts/run-webkit-unittests:

4:53 PM Changeset in webkit [51222] by ap@apple.com

• 13 edits
  2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31690
Make SocketStreamHandleCFNet work on Windows

• WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.

• platform/network/ResourceHandle.h: Removed loaderRunLoop().

• platform/network/cf/LoaderRunLoopCF.cpp: Added. (WebCore::emptyPerform): (WebCore::runLoaderThread): (WebCore::loaderRunLoop):
• platform/network/cf/LoaderRunLoopCF.h: Added. Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because it's needed for more than just resource loading.

• platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.

• platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.

• platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to main thread.
• platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of inoperable main run loop.

(WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::readStreamCallbackMainThread):
(WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
Forward stream events to main thread on Windows.

4:47 PM Changeset in webkit [51221] by eric@webkit.org

• 2 edits in trunk/WebCore

2009-11-19 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Adler.

Quick style fix.
​https://bugs.webkit.org/show_bug.cgi?id=27777

• platform/graphics/cg/PDFDocumentImage.cpp:

4:30 PM Changeset in webkit [51220] by bweinstein@apple.com

• 2 edits
  1 delete in trunk/LayoutTests/platform/win/fast/table

Update Windows expected pixel results, and remove the RenderTree results, because they are the same as the Mac.

4:25 PM Changeset in webkit [51219] by Beth Dakin

• 3 edits in trunk/WebCore

Build fix. No review needed.

• platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::paintTickmarks):

• rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaButton):

4:02 PM Changeset in webkit [51218] by Beth Dakin

• 2 edits in trunk/WebCore

Build fix. No review needed.

• rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintCheckbox):
(WebCore::RenderThemeChromiumSkia::paintRadio):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

3:58 PM Changeset in webkit [51217] by Beth Dakin

• 3 edits in trunk/WebCore

Build fix. No review needed.

• platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::draw):

• platform/graphics/qt/StillImageQt.h:

3:53 PM Changeset in webkit [51216] by Beth Dakin

• 2 edits in trunk/WebCore

Build fix. No review needed.

• rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):

3:50 PM Changeset in webkit [51215] by Beth Dakin

• 2 edits in trunk/WebCore

Build fix. No review needed.

• plugins/PluginView.cpp:

(WebCore::PluginView::paintMissingPluginIcon):

3:46 PM Changeset in webkit [51214] by Beth Dakin

• 2 edits in trunk/WebCore

Build fix. No review needed.

• platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

3:38 PM Changeset in webkit [51213] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

No review, just adding a FIXME.

Split out command parsing and help printing from BugzillaTool
​https://bugs.webkit.org/show_bug.cgi?id=31688

• Scripts/bugzilla-tool: Add an extra comment about current design failures.

3:36 PM Changeset in webkit [51212] by Beth Dakin

• 42 edits
  9 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
color-correction work with untagged images

Reviewed by Darin Adler.

Image's draw(), drawPattern(), and fillWithSolidColor() functions
now take a ColorSpace. A bunch of classes inherit from Image, so
draw() and drawPattern() functions there must also take a
ColorSpace.

• platform/graphics/Image.cpp:

(WebCore::Image::fillWithSolidColor):
(WebCore::Image::drawTiled):

• platform/graphics/Image.h:
• platform/graphics/BitmapImage.h:
• platform/graphics/GeneratedImage.cpp:

(WebCore::GeneratedImage::draw):
(WebCore::GeneratedImage::drawPattern):

• platform/graphics/GeneratedImage.h:
• platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

• platform/graphics/cg/PDFDocumentImage.h:
• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

• svg/graphics/SVGImage.h:

All of the drawImage() functions and drawTiled() functions of
GraphicsContext now take a ColorSpace.

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):

• platform/graphics/GraphicsContext.h:

This is where the actual work is done.

• platform/graphics/cg/ImageCG.cpp:

(WebCore::imageWithColorSpace): New static function that returns a
copy of the given image in the given ColorSpace *IF* we should use
the given ColorSpace. We will ignore the color space if the image
is tagged and return 0.
(WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to
call imageWithColorSpace().
(WebCore::Image::drawPattern): Same.

Attempt to keep all ports building.

• platform/graphics/cairo/ImageCairo.cpp:

(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):

• platform/graphics/haiku/ImageHaiku.cpp:

(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):

• platform/graphics/qt/ImageQt.cpp:

(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):

• platform/graphics/skia/BitmapImageSingleFrameSkia.h:
• platform/graphics/skia/ImageSkia.cpp:

(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

• platform/graphics/wx/ImageWx.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::drawPattern):

Callers of GraphicsContext's drawImage() and drawTiled() functions
now need to send a ColorSpace.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):

• platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

• platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::apply):

• platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::apply):

• platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::apply):

• platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintResizer):

• rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

• rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

• rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

• svg/graphics/SVGPaintServerPattern.cpp:

(WebCore::SVGPaintServerPattern::setup):

• svg/graphics/SVGResourceFilter.cpp:

(WebCore::SVGResourceFilter::applyFilter):

• svg/graphics/filters/SVGFEMerge.cpp:

(WebCore::FEMerge::apply):

• svg/graphics/filters/SVGFEOffset.cpp:

(WebCore::FEOffset::apply):

• svg/graphics/filters/SVGFETile.cpp:

(WebCore::FETile::apply):

LayoutTests: Tests for ​https://bugs.webkit.org/show_bug.cgi?id=31321 Make
-webkit-color-correction work with untagged images

Reviewed by Darin Adler.

• fast/css/color-correction-on-background-image.html: Added.
• fast/css/color-correction-untagged-images.html: Added.
• fast/css/resources/purple-noprofile.png: Added.
• platform/mac/fast/css/color-correction-on-background-image-expected.checksum: Added.
• platform/mac/fast/css/color-correction-on-background-image-expected.png: Added.
• platform/mac/fast/css/color-correction-on-background-image-expected.txt: Added.
• platform/mac/fast/css/color-correction-untagged-images-expected.checksum: Added.
• platform/mac/fast/css/color-correction-untagged-images-expected.png: Added.
• platform/mac/fast/css/color-correction-untagged-images-expected.txt: Added.

3:32 PM Changeset in webkit [51211] by dimich@chromium.org

• 2 edits in trunk/JavaScriptCore

isMainThread() on Chromium (Mac and Linux) is so slow it timeouts LayoutTests..
​https://bugs.webkit.org/show_bug.cgi?id=31693

Reviewed by David Levin.

• wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): grab and use the pthread_t of the main thread instead of ThreadIdentifier.
(WTF::isMainThread): Ditto.

3:30 PM Changeset in webkit [51210] by Michelangelo De Simone

• 3 edits in trunk/LayoutTests

2009-11-19 Michelangelo De Simone <Michelangelo De Simone>

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=27959>
Files missed when landing patch.

• platform/qt/Skipped:
• platform/win/Skipped:

3:28 PM Changeset in webkit [51209] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Split out command parsing and help printing from BugzillaTool
​https://bugs.webkit.org/show_bug.cgi?id=31688

• Scripts/bugzilla-tool:
  • Add new MultiCommandTool class to contain option parsing and help printing logic.
  • Rename private methods to use _ pattern.
  • MultiCommandTool has two abstract methods should_show_command_help and should_execute_command. -

3:21 PM Changeset in webkit [51208] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Re-factor help printing to use modern python idioms
​https://bugs.webkit.org/show_bug.cgi?id=31685

• Scripts/bugzilla-tool:

3:12 PM Changeset in webkit [51207] by eric@webkit.org

• 4 edits in trunk/WebCore

2009-11-19 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Adler.

Properly create a CGImageRef on non-PLATFORM(MAC).
​https://bugs.webkit.org/show_bug.cgi?id=27777

• platform/graphics/cg/ImageSourceCG.cpp: (WebCore::sharedBufferGetBytesAtPosition): (WebCore::sharedBufferRelease): (WebCore::ImageSource::setData):
• platform/graphics/cg/ImageSourceCG.h:
• platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged):

2:16 PM Changeset in webkit [51206] by ap@apple.com

• 2 edits in trunk/LayoutTests

Trying to enable WebSocket tests on Tiger again, as the bot seems to behave now.

• platform/mac-tiger/Skipped:

2:04 PM Changeset in webkit [51205] by oliver@apple.com

• 2 edits
  1 add in trunk/WebCore

-webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
​https://bugs.webkit.org/show_bug.cgi?id=31656

Reviewed Dave Hyatt

Make sure we're a child of the painting root before drawing overflow features.

1:29 PM Changeset in webkit [51204] by dimich@chromium.org

• 2 edits in trunk/WebCore

Not reviewed, attempt to fix Chromium build.

• rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.

1:02 PM Changeset in webkit [51203] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

commit-queue empty queue logs twice
​https://bugs.webkit.org/show_bug.cgi?id=31679

• Scripts/bugzilla-tool:

12:28 PM Changeset in webkit [51202] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

bugzilla-tool's reviewer/committer rejection message should be clearer
​https://bugs.webkit.org/show_bug.cgi?id=31126

Add more explanatory prose to bugzilla-tool's flag permission rejection message.

• Scripts/modules/bugzilla.py:

12:25 PM Changeset in webkit [51201] by eric@webkit.org

• 3 edits
  2 adds in trunk

2009-11-19 Rahul Kuchhal <​kuchhal@chromium.org>

Reviewed by Darin Adler.

Do not assert when a high number is used for roman numerals in lists.
​https://bugs.webkit.org/show_bug.cgi?id=31652

• fast/lists/ol-start-roman.html: Added.
• platform/mac/fast/lists/ol-start-roman-expected.txt: Added.

2009-11-19 Rahul Kuchhal <​kuchhal@chromium.org>

Reviewed by Darin Adler.

Do not assert when a high number is used for roman numerals in lists.
​https://bugs.webkit.org/show_bug.cgi?id=31652

Test: fast/lists/ol-start-roman.html

• rendering/RenderListMarker.cpp: (WebCore::toRoman): Increase the char array size.

12:14 PM Changeset in webkit [51200] by kov@webkit.org

• 2 edits in trunk/WebCore

Rubber-stamped by Oliver Hunt.

Add translatable strings to cover validationMessage, after
r51172. Already covered by existing test.

• platform/gtk/LocalizedStringsGtk.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

12:12 PM Changeset in webkit [51199] by eric@webkit.org

• 3 edits in trunk/JavaScriptCore

2009-11-19 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove HAVE(STRING_H) guard from JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=31668

• config.h:
• runtime/UString.cpp:

11:59 AM Changeset in webkit [51198] by dumi@chromium.org

• 2 edits in trunk/JavaScriptCore

Fixing a bug in MessageQueue::removeIf() that leads to an
assertion failure.

Reviewed by Dmitry Titov.

​https://bugs.webkit.org/show_bug.cgi?id=31657

• wtf/MessageQueue.h:

(WTF::MessageQueue::removeIf):

11:54 AM Changeset in webkit [51197] by eric@webkit.org

• 9 edits in trunk

2009-11-19 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove HAVE(FLOAT_H) guard
​https://bugs.webkit.org/show_bug.cgi?id=31661

JavaScriptCore has a dependency on float.h, there is
no need to guard float.h.

• runtime/DatePrototype.cpp: Remove include directive for float.h as it is included in MathExtras.h already.
• runtime/Operations.cpp: Ditto.
• runtime/UString.cpp: Ditto.
• wtf/dtoa.cpp: Ditto.
• wtf/MathExtras.h: Remove HAVE(FLOAT_H) guard.
• wtf/Platform.h: Ditto.

2009-11-19 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove HAVE(FLOAT_H) guard
​https://bugs.webkit.org/show_bug.cgi?id=31661

WebCore has a dependency on float.h, there is
no need to guard float.h.

No new tests as there is no functional change.

• html/HTMLInputElement.cpp: Remove include directive for float.h as it is included in MathExtras.h already.

11:41 AM Changeset in webkit [51196] by eric@webkit.org

• 6 edits in trunk

2009-11-19 Eric Z. Ayers <​zundel@google.com>

Reviewed by Pavel Feldman.

Updated timeline paint test to ignore width and height. GTK+ testing
uses a different top level window size than other platforms.

​https://bugs.webkit.org/show_bug.cgi?id=31402

• inspector/timeline-paint-expected.txt:
• inspector/timeline-test.js:
• platform/win/Skipped:

2009-11-19 Eric Z. Ayers <​zundel@google.com>

Reviewed by Pavel Feldman.

Forces a WM_PAINT event on calling layoutTestController.display()
in order to enable the timeline-paint.html test on Windows.
::UpdateWindow() does not force an event becaue the window is
not visible.

​https://bugs.webkit.org/show_bug.cgi?id=31402

• DumpRenderTree/win/DumpRenderTree.cpp: (displayWebView):

11:28 AM Changeset in webkit [51195] by eric@webkit.org

• 8 edits
  2 adds in trunk

2009-11-19 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

WAI-ARIA roles not supported on image map <area>
​https://bugs.webkit.org/show_bug.cgi?id=31525

• accessibility/aria-used-on-image-maps-expected.txt: Added.
• accessibility/aria-used-on-image-maps.html: Added.
• platform/gtk/Skipped:
• platform/win/Skipped:

11:03 AM Changeset in webkit [51194] by Simon Fraser

• 2 edits in trunk/WebCore

2009-11-19 Simon Fraser <Simon Fraser>

Reviewed by Pavel Feldman.

Instrumentation should account for painting in compositing layers
​https://bugs.webkit.org/show_bug.cgi?id=31674

Add calls to InspectorTimelineAgent for painting into compositing layers,
which is not accounted for in FrameView::paintContents().

• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): Avoid fetching the FrameView multiple times.

(WebCore::inspectorTimelineAgent):
(WebCore::RenderLayerBacking::paintContents):

10:21 AM Changeset in webkit [51193] by Michelangelo De Simone

• 2 edits in trunk/WebKitTools

2009-11-19 Michelangelo De Simone <Michelangelo De Simone>

No review needed.

Added myself to committers list.

• Scripts/modules/committers.py:

10:16 AM Changeset in webkit [51192] by eric@webkit.org

• 2 edits in trunk/WebKitTools

2009-11-19 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Bugzilla-tool command classes should match command names
​https://bugs.webkit.org/show_bug.cgi?id=31666

I renamed all the commands except CommitMessageForCurrentDiff because
the new name would conflict with an existing class.

• Scripts/bugzilla-tool:

10:14 AM Changeset in webkit [51191] by eric.carlson@apple.com

• 49 edits
  3 adds in trunk

2009-11-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

Test: media/media-captions.html

• WebCore.base.exp:
• accessibility/AccessibilityMediaControls.cpp: (WebCore::AccessibilityMediaControl::controlTypeName):

Define ShowClosedCaptionsButton and HideClosedCaptionsButton.

• css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

Add MediaToggleClosedCaptionsButtonPart.

• css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):

Define and match mediaControlsToggleClosedCaptionsButton.

• css/CSSSelector.h: (WebCore::CSSSelector::):
• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

Define and match PseudoMediaControlsToggleClosedCaptions.

• css/CSSValueKeywords.in:

Define and use media-toggle-closed-captions-button.

• css/mediaControls.css:
• css/mediaControlsQuickTime.css:

Add webkit-media-controls-toggle-closed-captions-button.

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):

Initialize m_closedCaptionsVisible.

(WebCore::HTMLMediaElement::loadInternal):

Set m_closedCaptionsVisible to false.

(WebCore::HTMLMediaElement::hasClosedCaptions):
(WebCore::HTMLMediaElement::closedCaptionsVisible):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):

New, captions internal methods.

(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible):
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible):
(WebCore::HTMLMediaElement::webkitHasClosedCaptions):

New, captions DOM API.

• html/HTMLMediaElement.h:
• html/HTMLMediaElement.idl:

Declare methods needed for captions API.

• platform/ThemeTypes.h:

Add MediaToggleClosedCaptionsButtonPart.

• platform/android/LocalizedStringsAndroid.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):

Add empty implmentations.

• platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::hasClosedCaptions): (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):

New, empty implementations of media engine closed caption functions.

(WebCore::MediaPlayer::hasClosedCaptions):
(WebCore::MediaPlayer::setClosedCaptionsVisible):

New, call media engine closed caption functions.

• platform/graphics/MediaPlayer.h:
• platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::hasClosedCaptions): (WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):

Declare new media engine methods.

• platform/graphics/mac/MediaPlayerPrivateQTKit.h:
• platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::hasClosedCaptions): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):

New, QTKit implementation of closed caption methods.

• platform/gtk/LocalizedStringsGtk.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText):

Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.

• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:

Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.

• rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement):

Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.

(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):

New, implement the closed caption toggle button,

• rendering/MediaControlElements.h:

Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
declare MediaControlToggleClosedCaptionsButtonElement.

• rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange): (WebCore::RenderMedia::createToggleClosedCaptionsButton): (WebCore::RenderMedia::createStatusDisplay): (WebCore::RenderMedia::updateControls): (WebCore::RenderMedia::forwardEvent):
• rendering/RenderMedia.h:

Deal with m_toggleClosedCaptionsButton.

• rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint):

Deal with MediaToggleClosedCaptionsButtonPart.

• rendering/RenderTheme.h:
• rendering/RenderThemeMac.h:

Declare paintMediaToggleClosedCaptionsButton.

• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):

New.

(WebCore::RenderThemeMac::shouldRenderMediaControlPart):

Don't render captions toggle button unless we are using the new theme, the
movie has captions, and the movie is in a <video> element since we currently
rely on QTKit to render the captions.

• rendering/style/RenderStyleConstants.h:

Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.

2009-11-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

• media/media-captions-expected.txt: Added.
• media/media-captions.html: Added.
• media/content/counting-captioned.mov: Added.

• platform/gtk/Skipped:
• platform/mac-leopard/Skipped:
• platform/mac-tiger/Skipped:
• platform/win/Skipped:

Skipped on platforms that don't support closed captions yet.

2009-11-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

• English.lproj/Localizable.strings:

Add strings for toggle captions button.

2009-11-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

Add QTMovieHasClosedCaptions and QTMovieSetShowClosedCaptions.

• WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaControlElementString:]): (-[WebViewFactory localizedMediaControlElementHelpText:]):

Add accessibility help strings for media controller closed caption button.

2009-11-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

• WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText):

Add accessibility help strings for media controller closed caption button.

2009-11-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

• WebKitSystemInterface.h:

Add prototypes for WKQTMovieHasClosedCaptions and WKQTMovieSetShowClosedCaptions,
define WKMediaUIPartToggleClosedCaptionsButton.

10:10 AM Changeset in webkit [51190] by kevino@webkit.org

• 2 edits in trunk/WebCore

wx build fix. Add missing header.

9:43 AM Changeset in webkit [51189] by ap@apple.com

• 3 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=31634
Ignore realm for proxy protection spaces

Only affects WebSocket proxy authentication, cannot be tested in DRT.

• platform/network/ProtectionSpace.cpp: (WebCore::operator==):
• platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash):

9:42 AM Changeset in webkit [51188] by eric@webkit.org

• 7 edits in trunk

2009-11-19 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Gustavo Noronha Silva.

Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.

​https://bugs.webkit.org/show_bug.cgi?id=31669

• platform/gtk/Skipped:

2009-11-19 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Gustavo Noronha Silva.

Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.

​https://bugs.webkit.org/show_bug.cgi?id=31669

• webkit/webkitwebinspector.cpp: (webkit_web_inspector_show):
• webkit/webkitwebinspector.h:

2009-11-19 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Gustavo Noronha Silva.

Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.

​https://bugs.webkit.org/show_bug.cgi?id=31669

• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector):

6:23 AM Changeset in webkit [51187] by kenneth@webkit.org

• 2 edits in trunk/WebKitTools

Minor refactoring + more documentation.

Reviewed by Simon Hausmann.

• DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::clearHistory):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

6:12 AM Changeset in webkit [51186] by eric@webkit.org

• 2 edits
  3 adds in trunk/WebKit/qt

2009-11-19 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add instantiation tests for QWebInspector.

• tests/qwebinspector/qwebinspector.pro: Added.
• tests/qwebinspector/tst_qwebinspector.cpp: Added. (tst_QWebInspector::attachAndDestroy):
• tests/tests.pro:

6:04 AM Changeset in webkit [51185] by eric@webkit.org

• 2 edits in trunk/WebKit/qt

2009-11-19 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix QWebInspector destruction problem.
​https://bugs.webkit.org/show_bug.cgi?id=31664

• Api/qwebpage.cpp: (QWebPage::~QWebPage):

5:47 AM Changeset in webkit [51184] by Simon Hausmann

• 9 edits in trunk

[Qt] Normalize signal and slot signatures.

Patch by Olivier Goffart <​ogoffart@trolltech.com> on 2009-11-19
Reviewed by Simon Hausmann.

WebCore:

• platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):

WebKit/qt:

• Api/qgraphicswebview.cpp:

(QGraphicsWebView::setPage):

• Api/qwebview.cpp:

(QWebView::setPage):

• WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::setFrame):

• docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp:

(wrapInFunction):

• tests/qwebframe/tst_qwebframe.cpp:
• tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::modified):
(tst_QWebPage::database):

5:46 AM Changeset in webkit [51183] by Simon Hausmann

• 2 edits in trunk/JavaScriptCore

Build fix for 32-bit Sparc machines: these machines are big-endian.

Patch by Thiago Macieira <​thiago.macieira@nokia.com> on 2009-11-19
Reviewed by Simon Hausmann.

• wtf/Platform.h:

5:03 AM Changeset in webkit [51182] by eric@webkit.org

• 7 edits in trunk/WebCore

2009-11-19 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Store cookie domains in the WebInspector object

The cookie domains have been moved from StoragePanel into WebInspector.
Also, the document URLs are now passed inside the WebInspector.addResource()
payload rather than pushed directly from InspectorController.
​https://bugs.webkit.org/show_bug.cgi?id=31627

• inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didFinishLoading):
• inspector/InspectorFrontend.cpp:
• inspector/InspectorFrontend.h:
• inspector/InspectorResource.cpp: (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject):
• inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addCookieDomain):
• inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.addCookieDomain): (WebInspector.reset):

4:32 AM Changeset in webkit [51181] by hamaji@chromium.org

• 5 edits
  4 adds
  15 deletes in trunk/LayoutTests

2009-11-19 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Some tests in fast/css-generated-content can be dumpAsText test
​https://bugs.webkit.org/show_bug.cgi?id=31663

• fast/css-generated-content/absolute-position-inside-inline-expected.txt: Added.
• fast/css-generated-content/absolute-position-inside-inline.html:
• fast/css-generated-content/hit-test-generated-content-expected.txt: Added.
• fast/css-generated-content/hit-test-generated-content.html:
• fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Added.
• fast/css-generated-content/positioned-background-hit-test-crash.html:
• fast/css-generated-content/spellingToolTip-assert-expected.txt: Added.
• fast/css-generated-content/spellingToolTip-assert.html:
• platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.checksum: Removed.
• platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.png: Removed.
• platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.txt: Removed.
• platform/mac/fast/css-generated-content/hit-test-generated-content-expected.checksum: Removed.
• platform/mac/fast/css-generated-content/hit-test-generated-content-expected.png: Removed.
• platform/mac/fast/css-generated-content/hit-test-generated-content-expected.txt: Removed.
• platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.checksum: Removed.
• platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.png: Removed.
• platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Removed.
• platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.checksum: Removed.
• platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.png: Removed.
• platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.txt: Removed.
• platform/qt/fast/css-generated-content/absolute-position-inside-inline-expected.txt: Removed.
• platform/qt/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Removed.
• platform/qt/fast/css-generated-content/spellingToolTip-assert-expected.txt: Removed.

2:41 AM Changeset in webkit [51180] by ukai@chromium.org

• 2 edits in trunk/WebKitTools

2009-11-19 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Eric Seidel.

Ignore websocket tests when --no-http is specified.
​https://bugs.webkit.org/show_bug.cgi?id=31662

• Scripts/run-webkit-tests:

1:34 AM Changeset in webkit [51179] by zoltan@webkit.org

• 10 edits in trunk/WebCore

Allow custom memory allocation control for the other part of platform directory in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=31585

Reviewed by Darin Adler.

Inherits the following classes from FastAllocBase because these are
instantiated by 'new':

class RegularExpression - instantiated at: WebCore/page/Frame.cpp:415
class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
class Path - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
class FontPlatformData - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188

Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:

class Cursors - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
class NetworkStateNotifier - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71

class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119

• platform/graphics/MediaPlayerPrivate.h:
• platform/graphics/Path.h:
• platform/graphics/qt/FontPlatformData.h:
• platform/graphics/transforms/TransformationMatrix.h:
• platform/image-decoders/ImageDecoder.h:
• platform/network/NetworkStateNotifier.h:
• platform/network/ResourceRequestBase.h:
• platform/qt/CursorQt.cpp:
• platform/text/RegularExpression.h:

12:15 AM Changeset in webkit [51178] by mitz@apple.com

• 5 edits in trunk/LayoutTests

Update the test fast/overflow/004.html to make it match the test
description and expected results.
​https://bugs.webkit.org/show_bug.cgi?id=31455

Patch by Kinuko Yasuda <​kinuko@google.com> on 2009-11-19
Reviewed by Dan Bernstein.

• fast/overflow/004.html:
• platform/mac/fast/overflow/004-expected.checksum:
• platform/mac/fast/overflow/004-expected.png:
• platform/mac/fast/overflow/004-expected.txt: