Context Navigation

Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.

fast/canvas/webgl/null-uniform-location-expected.txt: Added.
fast/canvas/webgl/null-uniform-location.html: Added.
fast/canvas/webgl/script-tests/null-uniform-location.js: Added. (callUniformFunction):
fast/canvas/webgl/uniform-location-expected.txt:

2010-04-03 yael aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Enable HTMLProgressElement for Safari on OSX
https://bugs.webkit.org/show_bug.cgi?id=36961

Configurations/FeatureDefines.xcconfig:
WebCore.xcodeproj/project.pbxproj:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeMac::animationDurationForProgressBar): (WebCore::RenderThemeMac::adjustProgressBarStyle): (WebCore::RenderThemeMac::paintProgressBar):

2010-04-03 yael aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Enable HTMLProgressElement for Safari on OSX
https://bugs.webkit.org/show_bug.cgi?id=36961

Configurations/FeatureDefines.xcconfig:

7:34 AM Changeset in webkit [57050] by jwieczorek@webkit.org

2 edits in trunk/WebCore

2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org>

Unreviewed.

Fix debug build with GCC >= 4.3.

platform/graphics/GraphicsLayer.cpp: Include stdio.h explicitly.

12:49 AM Changeset in webkit [57049] by eric@webkit.org

5 edits
3 adds in trunk

2010-04-03 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
https://bugs.webkit.org/show_bug.cgi?id=36574

Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.

fast/canvas/webgl/null-uniform-location-expected.txt: Added.
fast/canvas/webgl/null-uniform-location.html: Added.
fast/canvas/webgl/script-tests/null-uniform-location.js: Added. (callUniformFunction):
fast/canvas/webgl/uniform-location-expected.txt:

2010-04-03 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
https://bugs.webkit.org/show_bug.cgi?id=36574

Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.

Test: fast/canvas/webgl/null-uniform-location.html

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::V8WebGLRenderingContext::getUniformCallback): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv):

12:46 AM Changeset in webkit [57048] by Chris Jerdonek

4 edits in trunk/WebKitTools

The check-webkit-style script now logs an ERROR and exits when
encountering a file path that does not exist. Previously, it failed
silently on such paths.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=36957

Scripts/webkitpy/common/system/logtesting.py:
- Added a FIXME to rename the LoggingTestCase class to LoggingTestCaseBase.

Scripts/webkitpy/style/checker.py:
- In the StyleChecker.check_file() method:
  - Added a mock_os_path_exists parameter.
  - Renamed the process_file parameter to mock_process_file.
  - Added logic to log an error and exist if the given path does not exist.

Scripts/webkitpy/style/checker_unittest.py:
- Refactored the StyleCheckerCheckFileTest class slightly to inherit from LoggingTestCase.
- Added a test method to unit-test the case of a file that does not exist.
- Adjusted the other test methods as necessary.

12:34 AM Changeset in webkit [57047] by abarth@webkit.org

3 edits in trunk/WebKitTools

2010-04-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red)
https://bugs.webkit.org/show_bug.cgi?id=33289

Add Tiger and SnowLeopard Tests to the core builders. This is a bit of
an experiment now that the bots are green. Hopefully we can keep them
on the list and have the tree stay greener.

Scripts/webkitpy/common/net/buildbot.py:

12:12 AM Changeset in webkit [57046] by darin@chromium.org

2 edits in trunk/WebKit/chromium

2010-04-03 Darin Fisher <darin@chromium.org>

Add default implementations of WebNotificationPresenter methods to
repair the downstream Chromium build.

public/WebNotificationPresenter.h: (WebKit::WebNotificationPresenter::show): (WebKit::WebNotificationPresenter::cancel): (WebKit::WebNotificationPresenter::objectDestroyed): (WebKit::WebNotificationPresenter::checkPermission): (WebKit::WebNotificationPresenter::requestPermission):

12:05 AM Changeset in webkit [57045] by abarth@webkit.org

13 edits
8 adds in trunk

2010-04-02 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

Tests for https://bugs.webkit.org/show_bug.cgi?id=37008.

fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
fast/events/popup-allowed-from-gesture-initiated-event.html: Added.
fast/events/popup-blocked-from-fake-button-click-expected.txt: Added.
fast/events/popup-blocked-from-fake-button-click.html: Added.
fast/events/popup-blocked-from-fake-focus-expected.txt: Added.
fast/events/popup-blocked-from-fake-focus.html: Added.

2010-04-02 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

The previous mechanism for testing whether an event was due to a user
gesture only checked the event type, not the source of the event. This
allowed scripts to defeat popup blocking by programatically emitting
certain types of events.

Change the user gesture detection to check for a flag that is only set
when the event in question was generated through the platform and not
through the DOM.

https://bugs.webkit.org/show_bug.cgi?id=37008

Tests: fast/events/popup-allowed-from-gesture-initiated-event.html

fast/events/popup-blocked-from-fake-button-click.html
fast/events/popup-blocked-from-fake-focus.html

Android.mk: Add UserGestureIndicator.{cpp, h}.
GNUmakefile.am: Same.
WebCore.gypi: Same.
WebCore.pro: Same.
WebCore.vcproj/WebCore.vcproj: Same.
WebCore.xcodeproj/project.pbxproj: Same.
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): Check the value of UserGesureIndicator::processingUserGesture().
dom/Document.cpp: (WebCore::Document::createEvent): Remove call to Event::setCreatedByDOM().
dom/Event.cpp: (WebCore::Event::Event): Remove initializers for m_createdByDOM. (WebCore::Event::fromUserGesture): Check the value of UserGestureIndicator::processingUserGesture().
dom/Event.h: Remove m_createdByDOM.
dom/UserGestureIndicator.cpp: Added. (WebCore::UserGestureIndicator::UserGestureIndicator): Save the previous value of s_processingUserGesture before setting it to true. (WebCore::UserGestureIndicator::~UserGestureIndicator): Restore s_processingUserGesture to its previous value.
dom/UserGestureIndicator.h: Added. (WebCore::UserGestureIndicator::processingUserGesture): Return the value of s_processingUserGesture.
page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Instantiate a UserGestureIndicator object on the stack to indicate a user gesture is being processed. (WebCore::EventHandler::handleMouseDoubleClickEvent): Same. (WebCore::EventHandler::handleMouseReleaseEvent): Same. (WebCore::EventHandler::keyEvent): Same. (WebCore::EventHandler::handleTouchEvent): Same.

Apr 2, 2010:

11:15 PM Changeset in webkit [57044] by abarth@webkit.org

2 edits in trunk/LayoutTests

2010-04-02 Adam Barth <abarth@webkit.org>

Unreviewed.

REGRESSION(56394): http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html fails on Tiger
https://bugs.webkit.org/show_bug.cgi?id=36934

Attempt Alexey's solution of using a non-sniffable MIME type.

http/tests/xmlhttprequest/resources/download-with-delay.php:

10:49 PM Changeset in webkit [57043] by abarth@webkit.org

2 edits in trunk/LayoutTests

2010-04-02 Adam Barth <abarth@webkit.org>

Unreviewed. Disabled fast/workers/worker-terminate.html because it
randomly fails about 25% of the time.

https://bugs.webkit.org/show_bug.cgi?id=36646

platform/mac/Skipped:

9:48 PM Changeset in webkit [57042] by darin@chromium.org

3 edits
2 adds in trunk/LayoutTests

2010-04-02 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36647
Make replacestate-in-frame.html less insane and hopefully no longer flaky.

fast/loader/stateobjects/replacestate-in-iframe-expected.txt:
fast/loader/stateobjects/replacestate-in-iframe.html:
fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html: Added.
fast/loader/stateobjects/resources/replacestate-in-iframe-window.html: Added.

9:20 PM Changeset in webkit [57041] by abarth@webkit.org

3 edits
9 adds in trunk

2010-04-02 Justin Schuh <jschuh@chromium.org>

Reviewed by Alexey Proskuryakov.

XHR allows arbitrary XSRF across domains
https://bugs.webkit.org/show_bug.cgi?id=36843

Added a one-line change to prevent bypassing the XDC check on
synchronous preflighted requests. Added layout tests to cover
variations of this problem.

http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt: Added.
http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html: Added.
http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Added.
http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html: Added.
http/tests/xmlhttprequest/access-control-preflight-sync-header-denied-expected.txt: Added.
http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html: Added.
http/tests/xmlhttprequest/access-control-preflight-sync-method-denied-expected.txt: Added.
http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html: Added.
http/tests/xmlhttprequest/resources/access-control-preflight-denied-xsrf.php: Added.

2010-04-02 Justin Schuh <jschuh@chromium.org>

Reviewed by Alexey Proskuryakov.

XHR allows arbitrary XSRF across domains
https://bugs.webkit.org/show_bug.cgi?id=36843

Added a one-line change to prevent bypassing the XDC check on
synchronous preflighted requests. Added layout tests to cover
variations of this problem.

Tests: http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html

http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html
http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html
http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html

loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::preflightFailure):

9:09 PM Changeset in webkit [57040] by abarth@webkit.org

4 edits in trunk/WebKitTools

2010-04-02 Adam Barth <abarth@webkit.org>

Unreviewed.

Have Eric and Adam watch the SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=37054

Scripts/webkitpy/tool/bot/sheriff.py:
Scripts/webkitpy/tool/bot/sheriff_unittest.py:
Scripts/webkitpy/tool/commands/sheriffbot.py:

6:05 PM Changeset in webkit [57039] by Simon Fraser

3 edits in trunk/WebCore

2010-04-02 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Very bad scrolling-performance with the Trackpad at http://www.apple.com/ipad/app-store/
https://bugs.webkit.org/show_bug.cgi?id=36978

When we update compositing layers (which can happen on scrolling, when there are fixed position elements
on the page), we can end up redundantly setting images as layer contents if we have to color-correct
the image. This is because we call CGImageCreateCopyWithColorSpace(), which hands back a new image
every time.

Avoid this by storing a reference to the original uncorrected image, which is used to then
avoid work if the image does not change.

platform/graphics/mac/GraphicsLayerCA.h:
platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):

6:03 PM Changeset in webkit [57038] by eric@webkit.org

5 edits in trunk/WebCore

2010-04-02 Nayan Kumar K <nayankk@gmail.com>

Reviewed by Eric Seidel.

Fix for WML enabled build failure.

https://bugs.webkit.org/show_bug.cgi?id=36648

wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::disabled):
wml/WMLOptionElement.h:
wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::listBoxSelectItem):
wml/WMLSelectElement.h:

5:38 PM Changeset in webkit [57037] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-02 MORITA Hajime <morrita@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=37011
Position::primaryDirection() should not use its own accessor.

No new tests. This is small clenaup with no behaviour change.

dom/Position.cpp: (WebCore::Position::primaryDirection):

5:16 PM Changeset in webkit [57036] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-02 Eric Uhrhane <ericu@chromium.org>

Reviewed by Brady Eidson.

window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5. This is caused by a SecurityOrigin pointer comparison that I should have switched to be a hash comparison in r56293 [bug 34991].
https://bugs.webkit.org/show_bug.cgi?id=36671

No new tests. Requires testing on Safari on Windows.

storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Convert a pointer comparison to use SecurityOriginHash::hash() instead, and move it to the end of the clause for speed in the easy-out case.

5:14 PM Changeset in webkit [57035] by abarth@webkit.org

4 edits in trunk/WebKitTools

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

commit-queue should ignore builders when landing rollouts
https://bugs.webkit.org/show_bug.cgi?id=37051

When we moved the "builders are red" check into the master process, we
forgot about rollouts. I thought we had a test covering this case, but
looking at the test, it was a bit too loose. I added a new test and
introduced some new logging technology into MockTool to make the test
tighter.

Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/mocktool.py:

5:06 PM Changeset in webkit [57034] by eric@webkit.org

6 edits in trunk

2010-04-02 Michael Nordman <Michael Nordman>

Reviewed by Nate Chapin.

Set the close policy used by the DatabaseCloseTask in a constructor argument
instead of hard coding it.
https://bugs.webkit.org/show_bug.cgi?id=37037

No new tests, new new functionality.

storage/Database.cpp: This callsite passes in DoNotRemoveFromDatabaseContext to retain its current behavior. (WebCore::Database::markAsDeletedAndClose):
storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::DatabaseCloseTask): (WebCore::DatabaseCloseTask::doPerformTask):
storage/DatabaseTask.h: (WebCore::DatabaseCloseTask::create):

2010-04-02 Michael Nordman <Michael Nordman>

Reviewed by Nate Chapin.

Set the close policy used by the DatabaseCloseTask at this callsite to
RemoveDatabaseFromContext. This restores its behavior to what it was prior to
r56293.
https://bugs.webkit.org/show_bug.cgi?id=37037

src/WebDatabase.cpp: (WebKit::WebDatabase::closeDatabaseImmediately):

4:52 PM Changeset in webkit [57033] by jamesr@google.com

2 edits in trunk/WebCore

2010-04-02 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Remove an ASSERT that sometimes flakes due to time dependent animations
https://bugs.webkit.org/show_bug.cgi?id=37048

The outline repaint rectangle for a layer might change between two calls
if there are animations involved, even if nothing in the DOM has actually
changed between the calls.

No change in behavior, no new tests.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):

4:45 PM Changeset in webkit [57032] by abarth@webkit.org

1 edit
2 adds in trunk/WebCore

2010-04-02 Evan Stade <estade@chromium.org>

Reviewed by Adam Barth.

[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811

Add two files that failed to get added in my previous patch.

platform/chromium/DragImageChromiumMac.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
platform/chromium/DragImageChromiumSkia.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):

4:30 PM Changeset in webkit [57031] by eric.carlson@apple.com

12 edits in trunk

2010-04-02 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Configure multi-language movies: when QuickTime has sufficiently loaded
the movie, call into wkQTMovieSelectPreferredAlternates to select the
movie's alternate tracks according to the user's language preferences.

https://bugs.webkit.org/show_bug.cgi?id=36624

WebCore.base.exp:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): If the movie is sufficiently loaded, call wkQTMovieSelectPreferredAlternates to set up the alternate tracks.
platform/mac/WebCoreSystemInterface.h: Declare WKQTMovieSelectPreferredAlternates.
platform/mac/WebCoreSystemInterface.mm: Add WKQTMovieSelectPreferredAlternates.

2010-04-02 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

https://bugs.webkit.org/show_bug.cgi?id=36624

Update WebKitSystemInterface

WebKitSystemInterface.h: add WKQTMovieSelectPreferredAlternates.
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

2010-04-02 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

https://bugs.webkit.org/show_bug.cgi?id=36624
Add an INIT macro for the WebKitSystemInterface function wkQTMovieSelectPreferredAlternates.

WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

4:21 PM Changeset in webkit [57030] by jamesr@google.com

3 edits in trunk/WebCore

2010-04-02 James Robinson <jamesr@chromium.org>

Reviewed by Darin Adler.

Splits RenderBlock::layoutInline into smaller functions
https://bugs.webkit.org/show_bug.cgi?id=36921

RenderBlock::layoutInlineChildren is 351 lines long and very difficult
to comprehend or edit safely. This patch splits it up into a few
slightly smaller functions. Most of the code is now in the 241 line
layoutRunsAndFloats() which is a slight improvement.

Perf neutral on the page cyclers. This doesn't introduce any function
calls into the hottest layout paths inside layoutRunsAndFloats and
findNextLineBreak.

No change in behavior, no new tests.

rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutReplacedElements): (WebCore::RenderBlock::createLineBoxesForResolver): (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::layoutInlineChildren):

3:57 PM Changeset in webkit [57029] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Symbian] Rebaseline Symbian def file
https://bugs.webkit.org/show_bug.cgi?id=37038

Switch the ordinal numbers for qtwebkit_webframe_scrollRecursively
and QWebInspector::closeEvent to match QtWebkit 4.6 branch

Fix the signature for qt_drt_setFrameFlatteningEnabled
after r56718.

Add new QtWebKit API symbols introduced not listed in the file yet.

symbian/eabi/QtWebKitu.def:

3:48 PM Changeset in webkit [57028] by eric@webkit.org

9 edits
1 delete in trunk

2010-04-02 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811

Basic implementation using SkBitmap. Transformations are not supported
yet. No implementation for mac.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
platform/chromium/DragImageChromium.cpp:
platform/chromium/DragImageRef.h:

2010-04-02 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811

Use the DragImageRef that the DragController passes to us.

public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
src/WebViewImpl.h:

3:23 PM Changeset in webkit [57027] by eric@webkit.org

2 edits in trunk/WebCore

2010-04-02 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

[chromium] font fallback for generic fonts picks wrong font
https://bugs.webkit.org/show_bug.cgi?id=37033

When a page specifies the generic "monospace" font and the user's
browser-configured monospace font doesn't exist, we previously relied
on getLastResortFallbackFont to eventually pick a monospace font for us.

But that doesn't quite work: WebKit first falls back to the user's
"preferred standard font" before hitting the last resort code path.
So if the above conditions hold but this font exists, we'll end up
never hitting the last resort codepath.

The fix is to allow OS-level font fallback when first attempting to
resolve monospace. The existing code tried to do this, but the logic
was wrong. We would eventually fall back to the correct font anyway
so we didn't notice the logic was wrong.

This code is all handling cases where particular fonts aren't installed,
so I can't think of a way to test it; existing tests should still pass.

platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):

3:13 PM Changeset in webkit [57026] by eric@webkit.org

6 edits in trunk/WebKit

2010-04-02 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Clean up unused calls after changes to checkPermission and requestPermission argument lists.

public/WebNotificationPresenter.h:
src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission): (WebKit::NotificationPresenterImpl::requestPermission):

2010-04-02 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Clean up unused calls after changes to checkPermission and requestPermission argument lists.

WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::requestPermission):
WebCoreSupport/WebDesktopNotificationsDelegate.h:

2:53 PM Changeset in webkit [57025] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2010-04-02 Ruben Van Boxem <vanboxem.ruben@gmail.com>

Reviewed by Eric Seidel.

Mingw-w64 fixes for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=35607

runtime/Collector.cpp: use the msvc code for mingw-w64 (but not mingw-w32) (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr): (JSC::currentThreadStackBase): (JSC::currentThreadStackBase):
wtf/Platform.h: added COMPILER(MINGW64) check to differentiate between mingw.org and mingw-w64 functions

2:21 PM Changeset in webkit [57024] by ap@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=37043
Java regression tests spam stderr about being unable to set status message

With this change, there is still spam about "Attempt to access JavaScript from destroyed
applet, type 9." I haven't investigated if that indicates a problem or not.

Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]): Removed check for _documentView. We don't seem to care.

2:18 PM Changeset in webkit [57023] by scherkus@chromium.org

6 edits
2 adds in trunk

2010-04-02 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson and Eric Seidel.

Don't stop the playback event timer when media resource loading has suspended.
https://bugs.webkit.org/show_bug.cgi?id=37003

When a user agent decides to suspend media resource loading and enters the
NETWORK_IDLE state we are supposed to only stop the progress event timer but
keep the playback timer running.

Test: http/tests/media/video-play-suspend.html

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Only stop the progress event timer.

2010-04-02 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson and Eric Seidel.

Don't stop the playback event timer when media resource loading has suspended.
https://bugs.webkit.org/show_bug.cgi?id=37003

When a user agent decides to suspend media resource loading and enters the
NETWORK_IDLE state we are supposed to only stop the progress event timer but
keep the playback timer running.

Currently Chromium is the only platform that fires the suspend event
hence most platforms skipping this test.

http/tests/media/video-play-suspend-expected.txt: Added.
http/tests/media/video-play-suspend.html: Added.
platform/gtk/Skipped: Doesn't fire a suspend event.
platform/mac/Skipped: Ditto.
platform/win/Skipped: Ditto.

2:01 PM Changeset in webkit [57022] by Darin Adler

3 edits in trunk/WebCore

Fix mispelling that broke the build.

html/canvas/CanvasRenderingContext2D.cpp:
html/canvas/CanvasRenderingContext2D.h:

Dashbard -> Dashboard.

1:40 PM Changeset in webkit [57021] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: updated the .def file.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

1:31 PM Changeset in webkit [57020] by levin@chromium.org

10 edits in trunk

(non-generated) code should only use CanvasRenderingContext::canvas as a CanvasSurface.
https://bugs.webkit.org/show_bug.cgi?id=36906

Reviewed by Darin Adler.

WebCore:

dom/CanvasSurface.cpp: Added methods for items that depended on

CanvasRenderingContext::canvas() being an HTMLElement(), so that this usage
can be dealt with in one place.
(WebCore::CanvasSurface::securityOrigin): Only used by methods that are
only run in the document context.
(WebCore::CanvasSurface::renderBox): Will likely return 0 in a worker context.
(WebCore::CanvasSurface::computedStyle): Used by setFont. Return value is TBD for
the worker context.
(WebCore::CanvasSurface::styleSelector): Ditto.

dom/CanvasSurface.h:
html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext): Passing in information into
the CanvasRenderingContext2D constructor to eliminate some uses of document
inside of the CanvasRenderingContext2D class.

html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::renderBox): Added to disambiguate between the
two parent class versions of the method.
(WebCore::HTMLCanvasElement::computedStyle): Ditto.

html/canvas/CanvasRenderingContext2D.cpp: All of these changes are about

removing document usage either by using a bool that is set in the constructor or
by calling one of the new methods added to CanvasSurface.
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode):
(WebCore::CanvasRenderingContext2D::checkOrigin):
(WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

html/canvas/CanvasRenderingContext2D.h:
html/canvas/WebGLRenderingContext.cpp: Removed some duplicate includes.

(WebCore::WebGLRenderingContext::markContextChanged): Reduced calls to renderBox

as it may become slightly more expensive in the future.

(WebCore::WebGLRenderingContext::reshape): Ditto.

LayoutTests:

fast/canvas/script-tests/canvas-gradient-addStop-error.js: Changed the test

to create a new canvas after switching to dashboard compatiblity mode, which is
needed now that the compatibility mode is cached in the canvas.

1:15 PM Changeset in webkit [57019] by ggaren@apple.com

11 edits in trunk/JavaScriptCore

Inlined toThisString and toThisJSString to avoid virtual function call overhead
https://bugs.webkit.org/show_bug.cgi?id=37039

Reviewed by Oliver Hunt.

Maybe a 1% speedup on iBench JS.

JavaScriptCore.exp: New exports.

runtime/JSCell.cpp:
runtime/JSCell.h:
runtime/JSNumberCell.cpp:
runtime/JSNumberCell.h:
runtime/JSString.cpp:
runtime/JSString.h:
runtime/JSValue.h:
runtime/JSZombie.h:

(JSC::JSZombie::toThisObject): Nixed the old virtual-type implementation.

runtime/JSObject.h:

(JSC::JSValue::toThisString):
(JSC::JSValue::toThisJSString): Added the inlined implementation.

1:03 PM Changeset in webkit [57018] by eric@webkit.org

14 edits
2 adds in trunk

2010-04-02 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

Implement and test new framebuffer object attachment behavior.
https://bugs.webkit.org/show_bug.cgi?id=35611

fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added, test framebuffer object attachment behavior.
fast/canvas/webgl/framebuffer-object-attachment.html: Added, framebuffer object attachment behavior.
fast/canvas/webgl/script-tests/gl-object-get-calls.js: DEPTH_COMPONENT is no longer a valid input, use DEPTH_COMPONENT16 instead.
platform/mac-snowleopard/Skipped: The bot does not support EXT_packed_depth_stencil, skip the framebuffer-object-attachment.html test.

2010-04-02 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

Implement and test new framebuffer object attachment behavior.
https://bugs.webkit.org/show_bug.cgi?id=35611

Test: fast/canvas/webgl/framebuffer-object-attachment.html

html/canvas/WebGLFramebuffer.cpp: Keep track of attached stencil/depth renderbuffers in WebGLFramebuffer. (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::setIsAttached):
html/canvas/WebGLFramebuffer.h: Ditto. (WebCore::WebGLFramebuffer::isDepthAttached): (WebCore::WebGLFramebuffer::isStencilAttached): (WebCore::WebGLFramebuffer::isDepthStencilAttached):
html/canvas/WebGLRenderbuffer.cpp: Keep track of internalformat. (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
html/canvas/WebGLRenderbuffer.h: Ditto. (WebCore::WebGLRenderbuffer::setInternalformat): (WebCore::WebGLRenderbuffer::getInternalformat):
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Detect stencil/depth buffer conflicts. (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Handling DEPTH_STENCIL case. (WebCore::WebGLRenderingContext::getRenderbufferParameter): Get correct WebGL internalformat. (WebCore::WebGLRenderingContext::renderbufferStorage): Detect illegal enums.
html/canvas/WebGLRenderingContext.idl: Add DEPTH_STENCIL enums.
platform/graphics/GraphicsContext3D.h: Add DEPTH_STENCIL enums. (WebCore::GraphicsContext3D::):
platform/graphics/mac/GraphicsContext3DMac.cpp: Map to correct DEPTH_STENCIL format. (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):

2010-04-02 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

Implement and test new framebuffer object attachment behavior.
https://bugs.webkit.org/show_bug.cgi?id=35611

Test: fast/canvas/webgl/framebuffer-object-attachment.html

src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format. (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv): (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage):

12:55 PM Changeset in webkit [57017] by tonikitoo@webkit.org

2 edits in trunk/WebKit/qt

Stored focused frame and document in a vars, instead of querying for them many times.

Reviewed by Adam Treat.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Api/qwebpage.cpp:

(QWebPagePrivate::mousePressEvent(QEvent* ev)):
(QWebPagePrivate::mousePressEvent(QGraphicsSceneMouseEvent* ev):

12:51 PM Changeset in webkit [57016] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-04-02 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Geoffrey Garen.

Beef up documentation for ASSERT* and CRASH macros a bit.

https://bugs.webkit.org/show_bug.cgi?id=36527

wtf/Assertions.h:

12:21 PM Changeset in webkit [57015] by eric@webkit.org

3 edits in trunk/LayoutTests

2010-04-02 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=36908

fast/canvas/webgl/index-validation-expected.txt: Gathering more information about the cause of the failure. It's not a fix, and it won't worse change the current test behavior either, i.e., it won't make it better or worse.
fast/canvas/webgl/script-tests/index-validation.js: Ditto.

12:11 PM Changeset in webkit [57014] by eric@webkit.org

4 edits
1 add in trunk/WebKit/chromium

2010-04-02 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

The popup type (select or suggestion) is now passed to the
WebClient::createPopupMenu() method. This is required for
Chromium on Linux to make the select popups work correctly.
https://bugs.webkit.org/show_bug.cgi?id=37013

WebKit.gyp:
public/WebPopupType.h: Added. (WebKit::):
public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
src/ChromeClientImpl.cpp: (WebCore::convertPopupType): (WebKit::ChromeClientImpl::popupOpened):

12:09 PM Changeset in webkit [57013] by tkent@chromium.org

5 edits
2 adds in trunk

2010-04-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Form control state shouldn't be restored for hidden inputs.
https://bugs.webkit.org/show_bug.cgi?id=26241

fast/forms/button-state-restore.html: Updated for the behavior change.
fast/forms/state-restore-to-non-edited-controls-expected.txt: Added.
fast/forms/state-restore-to-non-edited-controls.html: Added.

2010-04-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Form control state shouldn't be restored for hidden inputs.
https://bugs.webkit.org/show_bug.cgi?id=26241

To fix this issue, we don't save values if it is not changed from
the default value.

Updating the value IDL attribute of some controls such as
type=hidden also updates the value content attribute, and it's
impossible to distinguish the initial value and the current
value. The values of such controls are not saved. It won't be a
problem because we want to save and restore user-edited values.

Test: fast/forms/state-restore-to-non-edited-controls.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::saveFormControlState): Do not save the value if it is same as the default value.
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::saveFormControlState): ditto.

11:31 AM Changeset in webkit [57012] by eric@webkit.org

7 edits
2 adds in trunk

2010-04-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Forms with autocomplete=off should not consume saved state
https://bugs.webkit.org/show_bug.cgi?id=36762

fast/forms/state-restore-to-non-autocomplete-form-expected.txt: Added.
fast/forms/state-restore-to-non-autocomplete-form.html: Added.

2010-04-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Forms with autocomplete=off should not consume saved state
https://bugs.webkit.org/show_bug.cgi?id=36762

Introduce Element::shouldSaveAndRestoreFormControlState() to check
if we should save and restore control state.

Test: fast/forms/state-restore-to-non-autocomplete-form.html

dom/Document.cpp: (WebCore::Document::formElementsState): Check shouldSaveAndRestoreFormControlState().
dom/Element.h: (WebCore::Element::shouldSaveAndRestoreFormControlState): Added. It just returns true.
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::autoComplete): Added. It return autocomplete state of the form. (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): Added. It returns the result of autoComplete(). (WebCore::HTMLFormControlElementWithState::finishParsingChildren): Do not restore state if shouldSaveAndRestoreFormControlState() is false.
html/HTMLFormControlElement.h: Declare autoComplete() and overriding methods.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::autoComplete): Reduce code by using autoComplete() of the parent class. (WebCore::HTMLInputElement::saveFormControlState): Remove the autoComplete() check. Document::formElementsState() does equivalent check.

11:03 AM Changeset in webkit [57011] by levin@chromium.org

4 edits in trunk/WebKitTools

sherrifbot should ensure that the rollout reason doesn't start with - (and fix webkit-patch upload).
https://bugs.webkit.org/show_bug.cgi?id=37030

Reviewed by Adam Barth.

Scripts/webkitpy/tool/bot/sheriff.py: Ensure that the rollout reason doesn't start with -.
Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: A test with a rollout reason which starts with -.
Scripts/webkitpy/tool/steps/createbug.py: Fix webkit-patch upload.

10:41 AM Changeset in webkit [57010] by Chris Jerdonek

2 edits in trunk/WebKitTools

Unreviewed.

Fixed check-webkit-style to recognize the short form of the
--verbose option, as stated in --help.

Scripts/check-webkit-style:
- Tweaked one line.

10:40 AM Changeset in webkit [57009] by Simon Fraser

3 edits in trunk/WebCore

2010-04-02 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Avoid doing work in FrameView::scrollPositionChanged() if there are no fixed position elements
https://bugs.webkit.org/show_bug.cgi?id=36994

r55890 added knowledge to FrameView about whether it contains any fixed-position elements. We can
use this to avoid updating widget positions, and compositing layer positions when possible.

page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged):
page/FrameView.h: (WebCore::FrameView::hasFixedObjects):

10:33 AM Changeset in webkit [57008] by Nate Chapin

2 edits in trunk/WebCore

2010-04-02 Nate Chapin <Nate Chapin>

Rubber-stamped by Dimitri Glazkov.

http://trac.webkit.org/changeset/57004 caused
fast/dom/console-log-stack-overflow.html to fail for Chromium.
Add check for empty wrappers before using them to create a hidden reference.

bindings/scripts/CodeGeneratorV8.pm:

10:24 AM Changeset in webkit [57007] by krit@webkit.org

2 edits in trunk/LayoutTests

2010-04-02 Dirk Schulze <krit@webkit.org>

Unreviewed.

[Gtk] LayoutTest feColorMatrix-value with different results over Gtk bots
https://bugs.webkit.org/show_bug.cgi?id=37029

Adding svg/filters/feColorMatrix-values.svg to the Gtk skip list. Opened
the bug report from above.

platform/gtk/Skipped:

10:01 AM Changeset in webkit [57006] by eric@webkit.org

1 edit
1 add in trunk/LayoutTests

2010-04-02 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Incorrect insertion position after typing 'ำ' (THAI CHARACTER SARA AM = 0E33)
https://bugs.webkit.org/show_bug.cgi?id=36858

Add failing results for Tiger to make the Tiger bot green.
We may wish to actually fix Tiger at some point.

platform/mac-tiger/fast/text/multiglyph-characters-expected.txt: Added.

9:45 AM Changeset in webkit [57005] by kevino@webkit.org

2 edits in trunk/WebKitTools

[wx] Build fix for DumpRenderTree after addition of layerTreeAsText.

9:40 AM Changeset in webkit [57004] by Nate Chapin

14 edits
4 deletes in trunk/WebCore

2010-04-01 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Generalize (and generate!) the creation of hidden references
between JS wrappers.

https://bugs.webkit.org/show_bug.cgi?id=36777

Android.v8bindings.mk:
WebCore.gypi:
bindings/scripts/CodeGeneratorV8.pm: Generate calls to setHiddenReference() in attribute getters.
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenReference): Split common logic out of hidden setHiddenWindowReference (WebCore::V8DOMWrapper::setHiddenWindowReference): Now contains logic specific to putting a hidden reference on a global object. (WebCore::globalObjectPrototypeIsDOMWindow): Be more thorough in the COMPILE_ASSERTs. (WebCore::V8DOMWrapper::convertEventTargetToV8Object): Cleanup: Remove a duplicate if statement.
bindings/v8/V8DOMWrapper.h:
bindings/v8/WrapperTypeInfo.h:
bindings/v8/custom/V8BarInfoCustom.cpp: Removed.
bindings/v8/custom/V8CSSStyleSheetCustom.cpp: (WebCore::toV8):
bindings/v8/custom/V8DOMSelectionCustom.cpp: Removed.
bindings/v8/custom/V8HistoryCustom.cpp:
bindings/v8/custom/V8LocationCustom.cpp:
bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::toV8):
bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
bindings/v8/custom/V8ScreenCustom.cpp: Removed.
bindings/v8/custom/V8StyleSheetCustom.cpp: (WebCore::toV8):
loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::frame): Add frame() accessor.

8:43 AM Changeset in webkit [57003] by pfeldman@chromium.org

7 edits in trunk/WebCore

2010-04-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: start editing DOM and styles on click-and-pause (part 1).

https://bugs.webkit.org/show_bug.cgi?id=36965

inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onattach): (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._handleClickAndPause): (WebInspector.ElementsTreeElement.prototype._startEditingTarget): (WebInspector.ElementsTreeElement.prototype._startEditingAttribute): (WebInspector.ElementsTreeElement.prototype._startEditingTextNode): (WebInspector.ElementsTreeElement.prototype._startEditingTagName): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick): (WebInspector.StylePropertiesSection.prototype._handleSelectorClick): (WebInspector.StylePropertiesSection.prototype._handleSelectorClickAndPause): (WebInspector.StylePropertiesSection.prototype._handleSelectorDoubleClick): (WebInspector.StylePropertiesSection.prototype._startEditingOnMouseEvent): (WebInspector.StylePropertyTreeElement.prototype.onattach): (WebInspector.StylePropertyTreeElement.prototype):
inspector/front-end/inspector.css:
inspector/front-end/inspector.js:
inspector/front-end/treeoutline.js: (TreeElement.prototype._attach): (TreeElement.treeElementMouseDown): (TreeElement.prototype.selectOnMouseDown):

8:07 AM Changeset in webkit [57002] by darin@chromium.org

2 edits in trunk/LayoutTests

2010-04-02 Darin Fisher <darin@chromium.org>

Add chromium suppression for http/tests/xhtmlmp since we do not support
this feature.

platform/chromium/test_expectations.txt:

7:54 AM Changeset in webkit [57001] by Laszlo Gombos

2 edits in trunk/JavaScriptCore

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Unreviewed, minor build fix.

Change the order of the member initialisation list
in constructor to match declaration order

runtime/Collector.cpp: (JSC::Heap::Heap):

6:41 AM WebKit Team edited by chang.shu@nokia.com

(diff)

6:05 AM Changeset in webkit [57000] by Laszlo Gombos

2 edits in trunk/WebCore

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix when building --no-svg.

Build fix after r56941. Add ENABLE(SVG) guard.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):

5:55 AM Changeset in webkit [56999] by yurys@chromium.org

14 edits
1 copy
1 add in trunk

2010-04-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Implement InspectorFrontendHost::showContextMenu for Chromium.

Move inspector frontend context menu code from InspectorFrontendClient to InspectorFrontendHost as it's platform independent.

https://bugs.webkit.org/show_bug.cgi?id=36817

WebCore.Inspector.exp:
bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
inspector/InspectorFrontendClient.h:
inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
inspector/InspectorFrontendClientLocal.h:
inspector/InspectorFrontendHost.cpp: (WebCore::FrontendMenuProvider::create): (WebCore::FrontendMenuProvider::disconnect): (WebCore::FrontendMenuProvider::FrontendMenuProvider): (WebCore::FrontendMenuProvider::~FrontendMenuProvider): (WebCore::FrontendMenuProvider::populateContextMenu): (WebCore::FrontendMenuProvider::contextMenuItemSelected): (WebCore::FrontendMenuProvider::contextMenuCleared): (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::disconnectClient): (WebCore::InspectorFrontendHost::showContextMenu):
inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::create):

2010-04-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Implement InspectorFrontendClient in Chromium and remove all custom bindings for the host methods from WebDevToolsFrontendImpl.

https://bugs.webkit.org/show_bug.cgi?id=36817

WebKit.gyp:
src/InspectorFrontendClientImpl.cpp: Added. (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl): (WebKit::InspectorFrontendClientImpl::~InspectorFrontendClientImpl): (WebKit::InspectorFrontendClientImpl::windowObjectCleared): (WebKit::InspectorFrontendClientImpl::frontendLoaded): (WebKit::InspectorFrontendClientImpl::moveWindowBy): (WebKit::InspectorFrontendClientImpl::localizedStringsURL): (WebKit::InspectorFrontendClientImpl::hiddenPanels): (WebKit::InspectorFrontendClientImpl::bringToFront): (WebKit::InspectorFrontendClientImpl::closeWindow): (WebKit::InspectorFrontendClientImpl::canAttachWindow): (WebKit::InspectorFrontendClientImpl::attachWindow): (WebKit::InspectorFrontendClientImpl::detachWindow): (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight): (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
src/InspectorFrontendClientImpl.h: Added.
src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
src/WebDevToolsFrontendImpl.h:
src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_):
src/js/DevTools.js: ():

5:18 AM Changeset in webkit [56998] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] http/tests/xmlhttprequest/access-control-response-with-body.html was introduced in r56955,
but it fails: "NETWORK_ERR: XMLHttpRequest Exception 101: A network error occured in synchronous requests."

platform/qt/Skipped: http/tests/xmlhttprequest/access-control-response-with-body.html skipped.

5:17 AM Changeset in webkit [56997] by loislo@chromium.org

4 edits in trunk/WebCore

2010-04-02 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Timeline Overview pane should support short records filtering.
https://bugs.webkit.org/show_bug.cgi?id=37020

English.lproj/localizedStrings.js:
inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.update.markTimeline): (WebInspector.TimelineOverviewPane.prototype.update):
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelinePanel.FormattedRecord.prototype.isLong):

4:25 AM Changeset in webkit [56996] by Csaba Osztrogonác

1 edit
1 add in trunk/LayoutTests

[Qt] Platform specific expected file added for test introduced in r56775,
because it passes. Compared to png file and Mac expected file.

platform/qt/svg/custom/animation-currentColor-expected.txt: Added.

3:10 AM Changeset in webkit [56995] by tkent@chromium.org

1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Update the expectation for fast/dom/HTMLProgressElement/set-progress-properties.html

2:31 AM Changeset in webkit [56994] by eric@webkit.org

8 edits
3 adds in trunk

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Accept XHTML-MP content type as XHTML content
https://bugs.webkit.org/show_bug.cgi?id=34262

Add a simple test that fails if XHTML-MP mime
type is not accepted.

http/conf/mime.types: Register XHTML-MP mime type with the test server
http/tests/xhtmlmp: Added.
http/tests/xhtmlmp/xhtml-expected.txt: Added.
http/tests/xhtmlmp/xhtml.xhtmlmp: Added. Testcase with the newly registered file extension.

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Accept XHTML-MP content type as XHTML content
https://bugs.webkit.org/show_bug.cgi?id=34262

Enable processing XHTML-MP mime type as an XHTML document
even if XHTML-MP support is not enabled.

platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):

2010-04-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Accept XHTML-MP content type as XHTML content
https://bugs.webkit.org/show_bug.cgi?id=34262

Register xhtmlmp file extension as the new type
for XHTML-MP test content.

Scripts/run-webkit-tests:
Scripts/webkitpy/layout_tests/layout_package/test_files.py:
Scripts/webkitpy/layout_tests/port/lighttpd.conf:

2:20 AM Changeset in webkit [56993] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

create-rollout doesn't fill out ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=37010

The contract between apply_reverse_diff and PrepareChangeLogForRevert
was unclear. I broke filling out the ChangeLog during rollout earlier
when I changed apply_reverse_diff to revert the ChangeLogs because
PrepareChangeLogForRevert thought that it was supposed to do that.
I've now taught PrepareChangeLogsForRevert the new contract.

It's unclear to me how to test this change because it's essentially an
integration issue that requires the file system. At some point we
should think about a testing strategy for integration. As the system
becomes larger, we're running into more of these issues.

Scripts/webkitpy/common/checkout/api.py:
Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:

2:10 AM Changeset in webkit [56992] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add cr-win-ews to QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=37004

QueueStatusServer/model/queues.py:
QueueStatusServer/templates/dashboard.html:
QueueStatusServer/templates/statusbubble.html:

2:00 AM Changeset in webkit [56991] by eric@webkit.org

7 edits
1 add in trunk/WebCore

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Make XSSAuditor go fast with large POST data
https://bugs.webkit.org/show_bug.cgi?id=36694

There were two things slowing down this bechmark:

1) Searching the large POST data for each inline event handler. To

make this faster, we now use a suffix tree to fast-reject strings
that don't appear as substrings of the POST data.

2) The next largest cost was flattening the form data into a string.

To make this fater, we now use the form data object itself as a key
and only flatten once.

GNUmakefile.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
page/XSSAuditor.cpp: (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): (WebCore::XSSAuditor::CachingURLCanonicalizer::clear): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::findInRequest):
page/XSSAuditor.h: (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): (WebCore::XSSAuditor::CachingURLCanonicalizer::generation):
platform/text/SuffixTree.h: Added. (WebCore::UnicodeCodebook::codeWord): (WebCore::UnicodeCodebook::): (WebCore::ASCIICodebook::codeWord): (WebCore::ASCIICodebook::): (WebCore::SuffixTree::SuffixTree): (WebCore::SuffixTree::mightContain): (WebCore::SuffixTree::Node::Node): (WebCore::SuffixTree::Node::~Node): (WebCore::SuffixTree::Node::at): (WebCore::SuffixTree::build):

1:33 AM Changeset in webkit [56990] by tkent@chromium.org

2 edits in trunk/LayoutTests

2010-04-02 Kent Tamura <tkent@chromium.org>

Unreviewed test fix. Follow the behavior change by r56962.

editing/selection/4960137.html:

1:31 AM Changeset in webkit [56989] by eric@webkit.org

3 edits in trunk/WebCore

2010-04-02 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Eric Seidel.

Bug 36741 - Duplicate, slightly divergent implementation of Position[Iterator]::isCandidate()
https://bugs.webkit.org/show_bug.cgi?id=36741

Patch: change Position::isCandididate() to call the PositionIterator::isCandidate() version.
Update PositionIterator::isCandidate() to mirror Position::isCandidate().

Rationale: PositionIterator::isCandidate() is called in a tight loop within
next/previousCandidate(). Also, creation of a PositionIterator from a Position
is cheaper than vice-versa.

Tests: ran all tests in 'editing'.

dom/Position.cpp: (WebCore::Position::isCandidate):
dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):

1:31 AM Changeset in webkit [56988] by Chris Jerdonek

3 edits in trunk/WebKitTools

2010-04-02 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

Unit-test networktransaction.py's log messages, and add a base
class to make unit-testing log messages even easier.

https://bugs.webkit.org/show_bug.cgi?id=36958

The purpose of this patch is also to provide a mini-tutorial on
how to unit-test Python logging.py messages.

Scripts/webkitpy/common/net/networktransaction_unittest.py:
- Unit-tested the log messages in test_retry().

Scripts/webkitpy/common/system/logtesting.py:
- Adjusted the LogTesting class by moving the code that clears the array of log messages into a finally block. This prevents redundant AssertionErrors from getting rendered to the screen while running unit tests.
- Added a LoggingTestCase class so the setUp() and tearDown() methods do not need to be implemented in order to test logging. Rather, TestCase classes can simply inherit from this class.

1:27 AM Changeset in webkit [56987] by Chris Jerdonek

3 edits in trunk/WebKitTools

2010-04-02 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Re-wrote check-webkit-style's argument parsing code to use
Python's optparser module and more uniform error-handling logic.

https://bugs.webkit.org/show_bug.cgi?id=34676

Scripts/webkitpy/style/optparser.py:
- Removed "option help" from check-webkit-style's usage string since that is provided separately by the OptionParser class.
- Also changed the usage string from a function to a constant string _USAGE.
- Added an _EPILOG string which renders after OptionParser's usage string and option help.
- In the ArgumentParser class:
  - Changed the constructor's stderr_write parameter to a mock_stderr since the OptionParser accepts a sys.stderr substitute rather than a sys.stderr.write substitute.
  - Changed the constructor to set a _parser data attribute with an OptionParser instance.
  - Added a _create_option_parser() method which instantiates the OptionParser.
  - Updated _exit_with_help() to interact with the OptionParser's help method.
  - Updated the parse() method as necessary. Also changed the raising of ValueErrors to calls to _exit_with_help().

Scripts/webkitpy/style/optparser_unittest.py:
- Removed the CreateUsageTest class since the create_usage method was replaced by a constant string.
- Added a _MockStdErr class to the ArgumentParserTest class.
- Updated the unit tests as necessary.

1:18 AM Changeset in webkit [56986] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The master commit-queue process should take responsibility for checking that the builders are green
https://bugs.webkit.org/show_bug.cgi?id=37009

We had a failure where the child process noticed that the builders were
red. We've always had this race condition, but the new optimistic
design made it easier to trigger.

Scripts/webkitpy/tool/commands/queues.py:

1:18 AM Changeset in webkit [56985] by abarth@webkit.org

3 edits in trunk/WebKitTools

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Tweak rollout changelog to pass ValidateReviewer check
https://bugs.webkit.org/show_bug.cgi?id=37019

We need to use the magic word "unreviewed" to make the commit-queue
happy when landing rollouts.

Scripts/webkitpy/common/checkout/changelog.py:
Scripts/webkitpy/common/checkout/changelog_unittest.py:

1:16 AM Changeset in webkit [56984] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-04-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_SETTINGS
https://bugs.webkit.org/show_bug.cgi?id=36533

If QT_NO_SETTINGS is defined, QSettings is not available.

WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): (WebCore::InspectorClientQt::storeSetting):

1:13 AM Changeset in webkit [56983] by Chris Jerdonek

1 edit in trunk/WebKitTools/ChangeLog

Unreviewed.

Removed duplicate ChangeLog entry.

1:04 AM Changeset in webkit [56982] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-04-02 Eric Seidel <eric@webkit.org>

Unreviewed, just updating expected results for passing tests.

suppress image failures for now to get a clean test run w/ pixel tests enabled for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=36620

Remove several tests marked MISSING which no longer seem to be missing.

platform/mac/test_expectations.txt:

1:03 AM Changeset in webkit [56981] by Chris Jerdonek

4 edits in trunk/WebKitTools

Rubber-stamped by Eric Seidel.

To the Python 2.4 error message, added a link to the wiki page
that contains instructions on how to upgrade.

Scripts/test-webkitpy:
- Eliminated a use of the ternary operator in configure_logging() to let the version warning display in case of Python 2.4.

Scripts/webkitpy/python24/versioning.py:
- Added this link to the error text: http://trac.webkit.org/wiki/PythonGuidelines

Scripts/webkitpy/python24/versioning_unittest.py:
- Updated unit test text.

12:39 AM Changeset in webkit [56980] by eric@webkit.org

3 edits in trunk/WebKit/qt

2010-04-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - customized popup for <select multiple> elements
https://bugs.webkit.org/show_bug.cgi?id=36368

Using QtMaemoWebPopup instead of QtFallbackWebPopup for Maemo.

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate):

12:30 AM Changeset in webkit [56979] by abarth@webkit.org

3 edits in trunk/LayoutTests

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(56295): http/tests/security/xssAuditor/xss-protection-parsing-01.html times out on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=36933

Change the test design in an attempt to get this passing on Tiger. In
this variation, we use a POST request to work around possible caching
issues in Tiger's CFNetwork.

http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
http/tests/security/xssAuditor/xss-protection-parsing-01.html:

12:25 AM Changeset in webkit [56978] by sfalken@apple.com

2 edits in trunk/WebCore

Database code falsely returns errors due to errant pointer check
https://bugs.webkit.org/show_bug.cgi?id=37014

Reviewed by Dan Bernstein.

r56943 introduced a check to see if there were any unprocessed
SQL commands after calling sqlite3_prepare16_v2.

Accessing the remaining data via pointer wasn't possible since
the query string is deallocated immediately after the
query runs. The String returned from strippedWhiteSpace
goes out of scope at that point.

Fix is to store the strippedWhiteSpace in a temporary String
so we can access it via character ptr later in the function.

platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

12:14 AM Changeset in webkit [56977] by eric@webkit.org

5 edits in trunk/WebKitTools

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Record the IRC nick of folks who request rollouts
https://bugs.webkit.org/show_bug.cgi?id=36999

Scripts/webkitpy/common/net/irc/ircbot.py:
Scripts/webkitpy/tool/bot/irc_command.py:
Scripts/webkitpy/tool/bot/sheriffircbot.py:
Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

12:04 AM Changeset in webkit [56976] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-04-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add cr-win-ews
https://bugs.webkit.org/show_bug.cgi?id=36974

Adds support for an Early Warning System for Chromium on Linux. The
interface to the Chromium port is the same on every platform, so we
don't need to create a new Port object for this queue.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

Apr 1, 2010:

11:44 PM Changeset in webkit [56975] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Using a failure exit code when failing to load a required import
https://bugs.webkit.org/show_bug.cgi?id=37000

Well spotted by Mark Rowe.

Scripts/webkitpy/common/system/user.py:

11:34 PM Changeset in webkit [56974] by eric@webkit.org

3 edits
3 adds in trunk

2010-04-01 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

setting document.title doesn't change document.title value
https://bugs.webkit.org/show_bug.cgi?id=36802

fast/dom/Document/script-tests/title-with-multiple-children.js: Added.
fast/dom/Document/title-with-multiple-children-expected.txt: Added.
fast/dom/Document/title-with-multiple-children.html: Added.

2010-04-01 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

setting document.title doesn't change document.title value
https://bugs.webkit.org/show_bug.cgi?id=36802

An entity of "value" argument on HTMLTitleElement::setTitle() could be
Document::m_title and be changed during HTMLTitleElement::setText().
Fix copying the argument to keep the original value.

Test: fast/dom/Document/title-with-multiple-children.html

html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::setText):

11:15 PM Changeset in webkit [56973] by Chris Jerdonek

3 edits in trunk/WebKitTools

Rewrote the revision (r56942) to disable the 79 character line
length limit Python/PEP8 style check.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33639#c39

This rewrite puts the disabling not in the PythonProcessor but
in the calling code's default filter rule configuration. This
allows the user to check line-length style from the command-line
if desired.

Scripts/webkitpy/style/checker.py:
- Added "-pep8/E501" to the _BASE_FILTER_RULES configuration variable to disable the line-length check.
- Added "-pep8/E501" to the list of recognized style categories to permit the category to be checked from the command line.

Scripts/webkitpy/style/processors/python.py:
- Reverted r56942: http://trac.webkit.org/changeset/56942

11:09 PM Changeset in webkit [56972] by eric@webkit.org

4 edits in trunk/WebKit/chromium

2010-04-01 Jay Civelli <jcivelli@google.com>

Reviewed by David Levin.

Adds a method to WebFrame to execute JavaScript and get the value
it evaluates to.
https://bugs.webkit.org/show_bug.cgi?id=36907

public/WebFrame.h:
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeScriptAndReturnValue):
src/WebFrameImpl.h:

10:35 PM Changeset in webkit [56971] by krit@webkit.org

1 edit
3 moves
1 add in trunk/LayoutTests

2010-04-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Move some SVG mac results to the SVG base directory, to give other platforms like Gtk
access to them.
Gtk needs a platform specific result for feColorMatrix-values.

platform/gtk/svg/filters/feColorMatrix-values-expected.txt: Added.
platform/mac/svg/custom/animation-currentColor-expected.txt: Removed.
platform/mac/svg/custom/glyph-transformation-with-hkern-expected.txt: Removed.
platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt: Removed.
svg/custom/animation-currentColor-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/animation-currentColor-expected.txt.
svg/custom/glyph-transformation-with-hkern-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/glyph-transformation-with-hkern-expected.txt.
svg/custom/gradient-with-1d-boundingbox-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt.

10:33 PM Changeset in webkit [56970] by eric@webkit.org

3 edits in trunk/WebCore

2010-04-01 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - <select multiple> custom rendering
https://bugs.webkit.org/show_bug.cgi?id=36369

Customizing rendering of <select multiple> elements in Maemo5.

platform/qt/Maemo5Webstyle.cpp: (Maemo5WebStyle::drawMultipleComboButton): (Maemo5WebStyle::drawSimpleComboButton): (Maemo5WebStyle::getButtonImageSize): (Maemo5WebStyle::findComboButton): (Maemo5WebStyle::drawComplexControl):
platform/qt/Maemo5Webstyle.h:

10:24 PM Changeset in webkit [56969] by krit@webkit.org

2 edits in trunk/LayoutTests

2010-04-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

This is a follow up to commit r56906. The fourth filter example,
feMorphology, shouldn't be displayed. filterRes causes a scaling of the filter
parameters, so that one value of 'radius' is lower than one.
The spec want us to round filter values down and a value of zero
for 'radius' stops the rendering process of feMorphology.

platform/mac/svg/filters/filterRes-expected.png:

10:22 PM Changeset in webkit [56968] by eric@webkit.org

24 edits
2 adds in trunk

2010-04-01 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896

Add EANBEL_FILE_READER and ENABLE_FILE_WRITER flags.

configure.ac:

2010-04-01 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896

Add ENABLE_FILE_READER and ENABLE_FILE_WRITER flags.

Configurations/FeatureDefines.xcconfig:

2010-04-01 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896

Add FileThread for async file operation support for FileReader and
FileWriter. The patch also adds ENABLE_FILE_READER or
ENABLE_FILE_WRITER build flags/defines. Both flags are disabled
by default.

No new tests, will add ones when after adding modules which use the thread.

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext): (WebCore::ScriptExecutionContext::fileThread):
dom/ScriptExecutionContext.h:
html/FileThread.cpp: Added. (WebCore::FileThread::FileThread): (WebCore::FileThread::~FileThread): (WebCore::FileThread::start): (WebCore::FileThread::stop): (WebCore::FileThread::postTask): (WebCore::SameFilePredicate::SameFilePredicate): (WebCore::SameFilePredicate::operator()): (WebCore::FileThread::removeTask): (WebCore::FileThread::fileThreadStart): (WebCore::FileThread::runLoop):
html/FileThread.h: Added. (WebCore::FileThread::create): (WebCore::FileThread::Task::Task): (WebCore::FileThread::Task::~Task): (WebCore::FileThread::Task::fileHandle):
platform/Logging.cpp: (WebCore::): (WebCore::getChannelFromName):
platform/Logging.h:

2010-04-01 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896

Add ENABLE_FILE_READER and ENABLE_FILE_WRITER flags.

features.gypi:

2010-04-01 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896

Add FILE_READER or FILE_WRITER feature defines.

Configurations/FeatureDefines.xcconfig:

2010-04-01 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896

Adds ENABLE_FILE_READER and ENABLE_FILE_WRITER feature flags
for FileReader and FileWriter support.

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-04-01 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dmitry Titov.

Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896

Add options to enable FILE_READER and FILE_WRITER support.

Scripts/build-webkit:

10:22 PM Changeset in webkit [56967] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-04-01 Eric Seidel <eric@webkit.org>

Unreviewed, just adding flaky tests to test_expectations.

Mark fast/dom/global-constructors.html and
fast/tokenizer/doctype-search-reset.html as flaky when run
under new-run-webkit-tests.

https://bugs.webkit.org/show_bug.cgi?id=35006
https://bugs.webkit.org/show_bug.cgi?id=37007

platform/mac/test_expectations.txt:

9:46 PM Changeset in webkit [56966] by tkent@chromium.org

2 edits in trunk/WebKitTools

2010-04-01 Kent Tamura <tkent@chromium.org>

Unreviewed. Add missing license header.

DumpRenderTree/chromium/TestShellMac.mm:

9:38 PM Changeset in webkit [56965] by abarth@webkit.org

3 edits
2 deletes in trunk

2010-04-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed. Rollout of http://trac.webkit.org/changeset/56930
https://bugs.webkit.org/show_bug.cgi?id=36977

We suspect that this change broke aria-liveregions-notifications

platform/mac/accessibility/area-with-aria-label-expected.txt: Removed.
platform/mac/accessibility/area-with-aria-label.html: Removed.

2010-04-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed. Rollout of http://trac.webkit.org/changeset/56930
https://bugs.webkit.org/show_bug.cgi?id=36977

accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::accessibilityDescription):

9:31 PM Changeset in webkit [56964] by abarth@webkit.org

6 edits in trunk/WebKitTools

2010-04-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Improve the error handling in rollout a bit
https://bugs.webkit.org/show_bug.cgi?id=36995

This patch does a few things to make the error handling in rollout a
bit more robust.

Scripts/webkitpy/common/checkout/api.py:

The old logic here was wrong. We don't want to resolve the
ChangeLogs (that would remove the old ChangeLog entry). Instead,
we want to revert the ChangeLogs so we can fill them with the new
message.

Scripts/webkitpy/tool/commands/download_unittest.py:

Update test expectations because we're using a different mock object.

Scripts/webkitpy/tool/commands/download.py:
- Added an update command to make updating from the SheriffBot more robust.
- Now that we have CommitInfo, we can automatically CC the responsible parties on the bug we create.
- Re-ordered the steps in create-rollout. Our original thinking was that we always wanted to create the bug, but that's not really true given how things appear to be playing out. If we fail to apply the reverse diff, we don't want to create the bug.
Scripts/webkitpy/tool/commands/sheriffbot.py:
- Use the new, more robust update command.
Scripts/webkitpy/tool/steps/createbug.py:

Allow commands to pre-load who they want to be CCed on a new bug.

8:37 PM Changeset in webkit [56963] by tkent@chromium.org

1 edit
7 adds in trunk/WebKitTools

2010-04-01 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add TestShell and WebViewHost class, main(), and so on
https://bugs.webkit.org/show_bug.cgi?id=36814

This change introduces:

WebViewHost class It's an implementation of some delegates required by Chromium WebKit API, and manages painting of a WebView. It's base on src/webkit/tools/test_shell/test_webview_delegate.{cc,h} of Chromium rev.40492.
TestShell class The TestShell instance holds global states of DumpRenderTree process. Unlike TestShell class of Chromium test_shell, TestShell instance is created just once.
DumpRenderTree.cpp The program entry.

DumpRenderTree/chromium/DumpRenderTree.cpp: Added.
DumpRenderTree/chromium/TestShell.cpp: Added.
DumpRenderTree/chromium/TestShell.h: Added.
DumpRenderTree/chromium/TestShellMac.mm: Added.
DumpRenderTree/chromium/WebViewHost.cpp: Added.
DumpRenderTree/chromium/WebViewHost.h: Added.
DumpRenderTree/chromium/config.h: Added.

8:14 PM Changeset in webkit [56962] by tkent@chromium.org

6 edits
6 adds in trunk

2010-04-01 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31680
Ownerless nodes leads a crash on DOMSelection APIs
https://bugs.webkit.org/show_bug.cgi?id=36800

editing/selection/DOMSelection-DocumentType-expected.txt: Added.
editing/selection/DOMSelection-DocumentType.html: Added.
editing/selection/DOMSelection-crossing-document-expected.txt: Added.
editing/selection/DOMSelection-crossing-document.html: Added.
editing/selection/drag-in-iframe.html: Updated to follow follow behaviour change.
editing/selection/script-tests/DOMSelection-DocumentType.js: Added.
editing/selection/script-tests/DOMSelection-crossing-document.js: Added. (makeEditableDocument): (clear):

2010-04-01 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31680
Ownerless nodes leads a crash on DOMSelection APIs
https://bugs.webkit.org/show_bug.cgi?id=36800

Added guards nodes from foreign documents to DOMSelection APIs.

Tests: editing/selection/DOMSelection-DocumentType.html

editing/selection/DOMSelection-crossing-document.html

editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend): (WebCore::DOMSelection::containsNode): (WebCore::DOMSelection::isValidForPosition):
page/DOMSelection.h:

7:54 PM Changeset in webkit [56961] by tkent@chromium.org

5 edits in trunk

Unreviewed. Roll out r56959 because of some test failures

6:45 PM Changeset in webkit [56960] by levin@chromium.org

4 edits in trunk/WebKitTools

sheriffbot rollout should verify that the svn revision is a number.
https://bugs.webkit.org/show_bug.cgi?id=37001

Reviewed by Adam Barth.

Scripts/webkitpy/common/net/bugzilla.py: Allow for the message to be None.
Scripts/webkitpy/tool/bot/sheriff.py: Did verification that svn revision is a number. Fixed the imports (since the files uses ScriptError and log) and a typo.
Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added a test to verify the behavior.

6:37 PM Changeset in webkit [56959] by yuzo@google.com

5 edits in trunk

2010-04-01 Yuzo Fujishima <yuzo@google.com>

Reviewed by David Hyatt.

Fix bug: CSS3 :not selector with ID simple selector sequence test fails
https://bugs.webkit.org/show_bug.cgi?id=36276

fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
fast/css/invalid-not-with-simple-selector-sequence.html: Added.

2010-04-01 Yuzo Fujishima <yuzo@google.com>

Reviewed by David Hyatt.

Fix bug: CSS3 :not selector with ID simple selector sequence test fails
As per http://www.w3.org/TR/css3-selectors/#negation, :not(X) takes a simple selector as an argument.
WebKit was accepting a simple selector *sequence*.
This patch adds WebCore::CSSSelector::isSimple which judges if the selector is simple.
The method is used in CSSGrammar.y to decide whether to accept the selector as the argument of :not().
https://bugs.webkit.org/show_bug.cgi?id=36276

Test: fast/css/invalid-not-with-simple-selector-sequence.html

css/CSSGrammar.y:
css/CSSSelector.cpp: (WebCore::CSSSelector::isSimple):
css/CSSSelector.h:

6:25 PM Changeset in webkit [56958] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-04-01 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by Eric Seidel.

[chromium] FindInPage on multi-frame pages wasn't always updating
tickmarks on scrollbars for the subframes. It was calling invalidateRect
on the View and specifying a rect that's in window coordinates, whereas
the invalidateRect expects frame coordinates.

https://bugs.webkit.org/show_bug.cgi?id=36982

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::invalidateArea):

6:14 PM Changeset in webkit [56957] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Print an error message for readline bogosity in MacPorts
https://bugs.webkit.org/show_bug.cgi?id=36979

Scripts/webkitpy/common/system/user.py:

5:44 PM Changeset in webkit [56956] by eric@webkit.org

3 edits
4 adds in trunk

2010-04-01 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add test for XSLT NULL crash:
https://bugs.webkit.org/show_bug.cgi?id=36804

LayoutTests/fast/xsl/xslt-bad-import-uri.html: added
LayoutTests/fast/xsl/xslt-bad-import-uri-expected.txt: added
LayoutTests/fast/xsl/resources/xslt-bad-import-uri.xml: added
LayoutTests/fast/xsl/resources/xslt-bad-import-uri.xsl: added

2010-04-01 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Fix a NULL pointer crash if @import fails to load a stylesheet.

https://bugs.webkit.org/show_bug.cgi?id=36804

Test: fast/xsl/xslt-bad-import-uri.html

xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::parseString): Handle an empty string gracefully. An empty string has a NULL buffer, which we pass in to xmlCreateMemoryParserCtxt(). It returns NULL if it is passed a NULL buffer. In the top-level XSL case, the current code does not crash "by luck" because the other APIs used can handle a NULL argument. In the @import case, additional code runs which will deference the NULL.

5:26 PM Changeset in webkit [56955] by ap@apple.com

3 edits
5 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36854
<rdar://problem/7811668> REGRESSION (r47291): Body from cross origin preflight response
is prepended to the actual response body

Tests: http/tests/xmlhttprequest/access-control-response-with-body-sync.html

http/tests/xmlhttprequest/access-control-response-with-body.html

loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData): Don't send data to the client when handling a preflight request.

5:13 PM Changeset in webkit [56954] by adachan@apple.com

6 edits in trunk

WebCore: Change DatabaseTracker::deleteOrigin() to return true if there are no errors in deleting the origin.
Ditto for DatabaseTracker::deleteDatabase().

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36988

storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):

storage/DatabaseTracker.h:

WebKit/mac: Change WebDatabaseManager::deleteOrigin() to return true if there are no errors in deleting the origin.
Ditto for WebDatabaseManager::deleteDatabase().

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36988

Storage/WebDatabaseManager.mm:

(-[WebDatabaseManager deleteOrigin:]):
(-[WebDatabaseManager deleteDatabase:withOrigin:]):

Storage/WebDatabaseManagerPrivate.h:

4:58 PM Changeset in webkit [56953] by Simon Fraser

2 edits in trunk/WebCore

2010-04-01 Simon Fraser <Simon Fraser>

No review.

Remove some casts that I indended to remove before committing r56948.

rendering/RenderTreeAsText.cpp: (WebCore::writeRenderObject): (WebCore::write):

4:54 PM Changeset in webkit [56952] by cmarrin@apple.com

1 edit in trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

Attempt to fix GTK LayoutTestController build

4:52 PM Changeset in webkit [56951] by abarth@webkit.org

3 edits in trunk/WebKitTools

2010-04-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't pass --non-interactive to create-rollout
https://bugs.webkit.org/show_bug.cgi?id=36989

It turns out you can't pass --non-interactive to create-rollout. Also,
improve our error reporting slighly to catch the case where we error
out after creating the rollout bug.

Scripts/webkitpy/tool/bot/irc_command.py:
Scripts/webkitpy/tool/bot/sheriff.py:

4:49 PM Changeset in webkit [56950] by ojan@chromium.org

2 edits in trunk/WebKitTools

2010-04-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

webkit-patch can incorrectly think the working directory is modified
https://bugs.webkit.org/show_bug.cgi?id=36985

If a file's modification time is modified, but the contents are not,
then diff-index will think the file has been modified unless you do
some crazy update-index call. Instead, call diff --name-only, which
has the index update builtin.

Tried to write a test, but could not reproduce this in a unittest.
To test manually:

touch file-in-repo
git diff-index HEAD
git diff HEAD --name-only

The diff-index call incorrectly shows file-in-repo as modified.

Scripts/webkitpy/common/checkout/scm.py:

4:42 PM Changeset in webkit [56949] by Simon Fraser

4 edits
2 adds in trunk

2010-04-01 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Assertion failure (willBeComposited == needsToBeComposited(layer)) in
RenderLayerCompositor::computeCompositingRequirements() on hulu.com
https://bugs.webkit.org/show_bug.cgi?id=36516

Fix assertions added in r56017. That changed replaced calls to needsToBeComposited()
with use of the local 'willBeComposited' variable, but that fails to take into
account the fact that needsToBeComposited() also tests layer->isSelfPaintingLayer().

Fix by adding a canBeComposited() method that we call before testing
whether the layer should go into compositing mode.

Test: compositing/self-painting-layers2.html

rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): Repace use of isSelfPaintingLayer() with a call to canBeComposited(). (WebCore::RenderLayerCompositor::computeCompositingRequirements): Call canBeComposited() to ensure that we only toggle 'willBeComposited' for layers that can. (WebCore::RenderLayerCompositor::needsToBeComposited): Call canBeComposited(). (WebCore::RenderLayerCompositor::canBeComposited): Test if compositing is enabled, and whether the layer is self-painting.
rendering/RenderLayerCompositor.h: Add canBeComposited().

4:38 PM Changeset in webkit [56948] by Simon Fraser

6 edits in trunk/WebCore

2010-04-01 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36980
Add object addresses to debug showLayerTree() output.

Add the ability to print RenderLayer and RenderObject addresses in the showLayerTree()
output.

platform/text/TextStream.cpp: (WebCore::TextStream::operator<<):
platform/text/TextStream.h:
rendering/RenderLayer.cpp: (showLayerTree):
rendering/RenderTreeAsText.cpp: (WebCore::writeRenderObject): (WebCore::write):
rendering/RenderTreeAsText.h:

4:34 PM Changeset in webkit [56947] by abarth@webkit.org

8 edits
1 copy
1 add in trunk/WebKitTools

2010-04-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add rollout command to sheriffbot
https://bugs.webkit.org/show_bug.cgi?id=36986

This IRC command creates a new bug an attaches a rollout patch. To
actually commit the rollout, a committer needs to mark the patch
commit-queue+ in bugs.webkit.org.

Also, factored out some of the logic from the queue into a separate
object for easier testing.

Scripts/webkitpy/common/system/executive.py:
Scripts/webkitpy/tool/bot/irc_command.py:
Scripts/webkitpy/tool/bot/sheriff.py: Added.
Scripts/webkitpy/tool/bot/sheriff_unittest.py: Added.
Scripts/webkitpy/tool/bot/sheriffircbot.py:
Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/sheriffbot.py:
Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

3:57 PM Changeset in webkit [56946] by cmarrin@apple.com

1 edit in trunk/WebKitTools/Scripts/run-webkit-tests

Backed out change to run-webkit-tests accidentally checked in

3:54 PM Changeset in webkit [56945] by cmarrin@apple.com

2 edits in trunk

Skipping compositing/geometry/preserve-3d-switching.html test on Leopard until we can fix https://bugs.webkit.org/show_bug.cgi?id=36984

3:53 PM Changeset in webkit [56944] by ojan@chromium.org

2 edits in trunk

2010-04-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

autoinstalled should be git ignored
https://bugs.webkit.org/show_bug.cgi?id=36970

.gitignore:

3:45 PM Changeset in webkit [56943] by dumi@chromium.org

3 edits
2 adds in trunk

WebCore: Changing SQLiteStatement::prepare() to return an error when it's
given a string that has more than one statement in it. Currently,
everything past the first statement is silently ignored.

Reviewed by Dimitri Glazkov.

Test: storage/executesql-accepts-only-one-statement.html

platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

LayoutTests: Testing that executeSql() accepts only one-statement strings.

Reviewed by Dimitri Glazkov.

storage/executesql-accepts-only-one-statement-expected.txt: Added.
storage/executesql-accepts-only-one-statement.html: Added.

3:39 PM Changeset in webkit [56942] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-01 Eric Seidel <eric@webkit.org>

Unreviewed, only ignoring chatty style errors.

check-webkit-style: WebKit needs a python style checker
https://bugs.webkit.org/show_bug.cgi?id=33639

Remove the 79 char line limit by ignoring
pep8/E501. Because we have our own report_error
implementation we have to ignore E501 by hand
instead of passing --ignore=E501.

Right now over 1400 lines of our existing python
fail E501 so this rule just generates needless noise.
The rest of WebKit has no wrapping rule so it makes
little sense for our Python to differ here.

Scripts/webkitpy/style/processors/python.py:

3:21 PM Changeset in webkit [56941] by jamesr@google.com

10 edits
8 adds in trunk

2010-04-01 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Keeps a transient optimistic offset to the root in RenderLayer::updateLayerPositions
https://bugs.webkit.org/show_bug.cgi?id=33520

RenderLayer::updateLayerPositions() makes a recursive walk through all RenderLayers and updates the repaint rectangles on each.
These rectangles have to be calculated in the repaint container's coordinates using RenderObject::mapLocalToContainer to walk
up to the repaint container. This patch keeps track of the offset to the root and uses that offset instead of walking back up to
the root every time.

Tests: fast/layers/nested-layers-1.html

fast/layers/nested-layers-2.html
fast/layers/nested-layers-3.html
fast/layers/nested-layers-4.html

page/FrameView.cpp: (WebCore::FrameView::layout):
rendering/RenderBox.cpp: (WebCore::RenderBox::outlineBoundsForRepaint):
rendering/RenderBox.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
rendering/RenderLayer.h:
rendering/RenderObject.h: (WebCore::RenderObject::outlineBoundsForRepaint):
rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
rendering/RenderSVGModelObject.h:

2010-04-01 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Mapping from local to container coord space in updateLayerPositions is quadratic
https://bugs.webkit.org/show_bug.cgi?id=33520

These tests move layers around in various ways to test that the offset caching in
updateLayerPositions() is correct.

fast/layers/nested-layers-1-expected.txt: Added.
fast/layers/nested-layers-1.html: Added.
fast/layers/nested-layers-2-expected.txt: Added.
fast/layers/nested-layers-2.html: Added.
fast/layers/nested-layers-3-expected.txt: Added.
fast/layers/nested-layers-3.html: Added.
fast/layers/nested-layers-4-expected.txt: Added.
fast/layers/nested-layers-4.html: Added.

3:06 PM Changeset in webkit [56940] by dbates@webkit.org

5 edits
1 add in trunk/WebCore

2010-04-01 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36901

Removed functions Range::operator == and Range::operator != as they
were using C++ code that was not sound and hence may have undefined
behavior.

Test case: manual-tests/crash-on-find-with-no-selection.html

dom/Range.cpp: (WebCore::areRangesEqual): Added.
dom/Range.h:
editing/markup.cpp: (WebCore::createMarkup): Modified to call WebCore::areRangesEqual.
manual-tests/crash-on-find-with-no-selection.html: Added.
page/Frame.cpp: (WebCore::Frame::findString): Modified to call WebCore::areRangesEqual.

2:57 PM Changeset in webkit [56939] by bweinstein@apple.com

1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild of Interfaces

2:43 PM Changeset in webkit [56938] by cmarrin@apple.com

3 edits in trunk

Fixed Windows (and hopefully Tiger) build

2:15 PM Changeset in webkit [56937] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-04-01 Adam Barth <abarth@webkit.org>

Unreviewed. Add cmarrin's IRC nickname.

Scripts/webkitpy/common/config/committers.py:

2:10 PM Changeset in webkit [56936] by abarth@webkit.org

5 edits in trunk/WebKitTools

2010-04-01 Adam Barth <abarth@webkit.org>

Unreviewed.

EWS spins hot when unable to build
https://bugs.webkit.org/show_bug.cgi?id=36981

The problem is that the queue engine things we have more work to do,
but the bot isn't actually able to do anything. After this change, we
back off the usual amount.

Scripts/webkitpy/tool/bot/queueengine.py:
Scripts/webkitpy/tool/bot/queueengine_unittest.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/sheriffbot.py:

1:59 PM Changeset in webkit [56935] by ap@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36976
<rdar://problem/7817498>
REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): The HashTable assertions aren't there to catch potential future attempts to store empty/deleted values before these happen - it's actually wrong to try to look up these values. Added an early return. (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Ditto.

1:15 PM Changeset in webkit [56934] by cmarrin@apple.com

18 edits
2 adds in trunk

Added layerTreeAsText function to DRT (for Mac)
https://bugs.webkit.org/show_bug.cgi?id=36782

1:11 PM Changeset in webkit [56933] by ggaren@apple.com

3 edits in trunk/WebCore

Synchronous rendering when setting form control values slows down JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36967

Reviewed by Sam Weinig.

This patch basically reverts http://trac.webkit.org/changeset/19006.

Dan asked me to investigate why 19006 is no longer needed. I have two answers:

(1) I was also able to remove the synchronous call to updateFromElement().
That call was the proximate cause of the crash that 19006 fixed.

(2) updateFromElement() no longer calls HTMLElement::setInnerText()
in the way that it used to. (However, it doesn't seem prudent to
rely on this happy coincidence.)

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Simplified some logic here. Moved
setNeedsValidityCheck() outside of individual 'if' clauses, since they all
called it.

Removed call to updateStyleIfNeeded(), which does rendering synchronously,
since that was the performance problem. (setNeedsStyleRecalc() ensures
that rendering will happen asynchronously.) Also removed comment about
ordering dangers introduced by updateStyleIfNeeded().

Removed call to updateFromElement(), since it's dangerous and also a minor
performance problem. (setNeedsStyleRecalc() ensures that updateFromElement()
will happen asynchronously, too.)

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setNonDirtyValue): Ditto. Here, I had to
add a call to setNeedsStyleRecalc(), since there wasn't one before.

12:59 PM Changeset in webkit [56932] by ap@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=36976
<rdar://problem/7817498>
REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Use find() instead of get(), because the latter fails with an assertion when looking up 0 or -1. (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Be prepared for unexpected object IDs coming from plug-in host.

12:58 PM Changeset in webkit [56931] by eric@webkit.org

4 edits in trunk/WebCore

2010-04-01 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Sometimes js code can detach page from it's frame and in that case
Dispatch Events will stay in the TimelineAgent's events stack. Only immediate events will
appear at frontend.
https://bugs.webkit.org/show_bug.cgi?id=36890

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):

12:46 PM Changeset in webkit [56930] by Chris Fleizach

3 edits
2 adds in trunk

Bug 36977 - aria-label doesn't work on image map area
https://bugs.webkit.org/show_bug.cgi?id=36977

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/area-with-aria-label.html

accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::accessibilityDescription):

LayoutTests:

platform/mac/accessibility/area-with-aria-label-expected.txt: Added.
platform/mac/accessibility/area-with-aria-label.html: Added.

12:36 PM Changeset in webkit [56929] by eric@webkit.org

3 edits in trunk/WebKit/qt

2010-04-01 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add Single and Multiple Selection Popup for Maemo 5.

[Qt] Maemo5 theme - popup dialogs
https://bugs.webkit.org/show_bug.cgi?id=36789

WebCoreSupport/QtMaemoWebPopup.cpp: (WebCore::Maemo5Popup::populateList): (WebCore::Maemo5Popup::onItemSelected): (WebCore::QtMaemoWebPopup::createSingleSelectionPopup): (WebCore::QtMaemoWebPopup::createMultipleSelectionPopup): (WebCore::Maemo5SingleSelectionPopup::Maemo5SingleSelectionPopup): (WebCore::MultipleItemListDelegate::MultipleItemListDelegate): (WebCore::MultipleItemListDelegate::paint): (WebCore::Maemo5MultipleSelectionPopup::Maemo5MultipleSelectionPopup):
WebCoreSupport/QtMaemoWebPopup.h:

12:23 PM Changeset in webkit [56928] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-04-01 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Part of:
REGRESSION(56394):
http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html
fails on Tiger
https://bugs.webkit.org/show_bug.cgi?id=36934

http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html: Add more explicit failing messages to help find out what is failing.

11:54 AM Changeset in webkit [56927] by kevino@webkit.org

2 edits in trunk/WebKitTools

[wx] Build fix after addition of JavaScriptCore/wtf/text directory.

11:46 AM Changeset in webkit [56926] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-04-01 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

REGRESSION(56489): security/block-test.html fails on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=36932

It appears that r56489 just forgot to update the Tiger results
to include the new parts of the test. Tiger has had custom
results for this test since r54193.

I just pulled these off the bot. I do not have the domain knowledge
to know if these are right or not. They look fine to me.

platform/mac-tiger/security/block-test-expected.txt:

11:37 AM Changeset in webkit [56925] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-04-01 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=36908

fast/canvas/webgl/script-tests/index-validation.js: Disable antialias for this test.

11:19 AM Changeset in webkit [56924] by Simon Fraser

3 edits
2 adds in trunk

2010-04-01 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Assertion failure: !repaintContainer

repaintContainer == this

https://bugs.webkit.org/show_bug.cgi?id=36672

RenderText's implementation of clippedOverflowRectForRepaint() uses containingBlock()
to get the renderer to use for computing the repaint rect. However, the renderer returned
by containingBlock() may be an ancestor of the repaintContainer, and containingBlock()
doesn't have the 'repaintContainerSkipped' logic that container() has.

So in this case, check to see whether repaintContainer is actually a descendant of the
containing block, and in that case just repaint the entire repaintContainer.

Test: compositing/repaint/inline-repaint-container.html

rendering/RenderText.cpp: (WebCore::RenderText::clippedOverflowRectForRepaint):

11:05 AM Changeset in webkit [56923] by eric@webkit.org

2 edits in trunk

2010-04-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt]Add -Wextra warning level to the QtWebKit build
https://bugs.webkit.org/show_bug.cgi?id=36971

WebKit.pri:

10:49 AM WebKit Team edited by jianli@chromium.org

(diff)

10:49 AM Changeset in webkit [56922] by Csaba Osztrogonác

3 edits in trunk/WebCore

[Qt] REGRESSION(r56869): Windows build is broken
https://bugs.webkit.org/show_bug.cgi?id=36929

Reviewed by Jian Li.

WebCore.pro: LIBS += -lOle32 added.
platform/UUID.cpp: Define ARRAYSIZE macro if it isn't defined before.

10:31 AM Changeset in webkit [56921] by jianli@chromium.org

2 edits in trunk/WebKitTools

Rubber-stamped by David Levin.

Add myself to the reviewers list.

Scripts/webkitpy/common/config/committers.py:

10:17 AM Changeset in webkit [56920] by Chris Fleizach

3 edits
2 adds in trunk

Bug 36968 - 1 crash in Safari at com.apple.WebCore: WebCore::Element::getAttribute const
https://bugs.webkit.org/show_bug.cgi?id=36968

Reviewed by Beth Dakin.

WebCore:

Test: accessibility/crash-with-noelement-selectbox.html

When a <select> element had no options, the selectedIndex == -1 and that was being
used to index into an empty array.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::stringValue):

LayoutTests:

accessibility/crash-with-noelement-selectbox-expected.txt: Added.
accessibility/crash-with-noelement-selectbox.html: Added.

10:10 AM Changeset in webkit [56919] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-04-01 Adam Barth <abarth@webkit.org>

Unreviewed.

Turns out the Chromium Windows bots don't have pdevenv installed.

Scripts/webkitdirs.pm:

9:54 AM Changeset in webkit [56918] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-01 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Let Chromium Windows build with Visual Studio Express
https://bugs.webkit.org/show_bug.cgi?id=36919

This is horrible, horrible copy/paste code, but that seems to be the
way of webkitdirs.pm. :(

Someone needs to go through an cleanup this code, but I don't have the
heart to do it in this patch.

Scripts/webkitdirs.pm:

9:45 AM Changeset in webkit [56917] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-04-01 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

[chromium] FindInPage should clear the focused node when a match has
been found. This is because WebFrameImpl::setFocus will try to refocus
editable elements if it thinks they have focus, causing the page to
scroll.

https://bugs.webkit.org/show_bug.cgi?id=36923

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::find):

9:07 AM Changeset in webkit [56916] by kov@webkit.org

4 edits
1 add in trunk

2010-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] webkit_get_default_session() should make sure webkit_init() is called
https://bugs.webkit.org/show_bug.cgi?id=36754

Make sure global functions that do not require a WebKitWebView to
be created call webkit_init() before doing their job. Also add an
API test to check for that.

tests/testglobals.c: Added. (test_globals_default_session): (main):
webkit/webkitwebview.cpp: (webkit_get_default_session): (webkit_set_cache_model): (webkit_get_cache_model):

8:14 AM Changeset in webkit [56915] by hamaji@chromium.org

4 edits in trunk/WebCore

2010-04-01 MORITA Hajime <morrita@google.com>

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=36948
Refactoring: Position::primaryDirection() should be extracted.

No new tests. No functinal change.

dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): (WebCore::Position::primaryDirection): Added
dom/Position.h:
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):

8:03 AM Changeset in webkit [56914] by eric@webkit.org

1 edit
1 add in trunk/WebKit

2010-04-01 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add EFL's pkg-config metadata file file to efl/.
http://webkit.org/b/36766

efl/ewebkit.pc.in: Added.

7:46 AM Changeset in webkit [56913] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-01 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Add myself to the committers list.
https://bugs.webkit.org/show_bug.cgi?id=36953

Scripts/webkitpy/common/config/committers.py:

7:12 AM Changeset in webkit [56912] by eric@webkit.org

1 edit
1 move in trunk/LayoutTests

2010-04-01 yael aharon <yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

set-progress-properties.html expected result should not be platform specific
https://bugs.webkit.org/show_bug.cgi?id=36918

fast/dom/HTMLProgressElement/set-progress-properties-expected.txt: Added.
platform/qt/fast/dom/HTMLProgressElement/set-progress-properties-expected.txt: Removed.

6:48 AM Changeset in webkit [56911] by chang.shu@nokia.com

3 edits
2 adds in trunk/LayoutTests

2010-04-01 Shu Chang <chang.shu@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] As Qt does not support dashboard compatibility mode, the red squares on
the second row are expected. Rebaseline and unskip test case.
https://bugs.webkit.org/show_bug.cgi?id=36869

platform/qt/Skipped:
platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.txt:

6:10 AM Changeset in webkit [56910] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-04-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Mark console-log-before-frame-navigation as pssing on Chromium Win.

https://bugs.webkit.org/show_bug.cgi?id=36807

platform/chromium/test_expectations.txt:

6:00 AM Changeset in webkit [56909] by eric@webkit.org

5 edits in trunk

2010-04-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Audits: fix parsing of injected script-evaluated result for CssInHeadRule
https://bugs.webkit.org/show_bug.cgi?id=36952

inspector/audits-panel-functional-expected.txt:
inspector/audits-panel-functional.html:

2010-04-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Audits: fix parsing of injected script-evaluated result for CssInHeadRule
https://bugs.webkit.org/show_bug.cgi?id=36952

inspector/front-end/AuditRules.js: (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):

5:02 AM Changeset in webkit [56908] by eric@webkit.org

4 edits
1 delete in trunk/WebKit/chromium

2010-04-01 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

As a follow up on https://bugs.webkit.org/show_bug.cgi?id=36535, remove:
GeolocationServiceBridgeChromium.h
dettachBridge()
getGeolocationService()
https://bugs.webkit.org/show_bug.cgi?id=36895

WebKit.gyp:
public/GeolocationServiceBridgeChromium.h: Removed.
public/WebGeolocationService.h: (WebKit::WebGeolocationService::detachBridge):
public/WebViewClient.h: (WebKit::WebViewClient::geolocationService):

3:19 AM Changeset in webkit [56907] by jorlow@chromium.org

13 edits in trunk

2010-03-31 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Misc IndexedDatabase cleanup
https://bugs.webkit.org/show_bug.cgi?id=36889

No functional changes.

bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::onSuccess): (WebCore::V8CustomIDBCallbacks::onError): (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks):

Get rid of 2 largely redundant bools

storage/IndexedDatabase.h:
storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
storage/IndexedDatabaseImpl.h:
storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
storage/IndexedDatabaseRequest.h:

Plumb the Frame* and style cleanups.

2010-03-31 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Misc IndexedDatabase cleanup
https://bugs.webkit.org/show_bug.cgi?id=36889

Plumb the Frame* so Chromium knows where the request originated from.

public/WebIndexedDatabase.h:
src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
src/IndexedDatabaseProxy.h:
src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
src/WebIndexedDatabaseImpl.h:

2:16 AM WebKit Team edited by jwieczorek@webkit.org

(diff)

1:54 AM Changeset in webkit [56906] by Nikolas Zimmermann

2 edits in trunk/LayoutTests

2010-04-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Fix filter references in svg/filters/filterRes.svg, to make two filters show up in Opera.
Clearly shows we have a regression with filterRes + feMorphology.

svg/filters/filterRes.svg:

1:30 AM Changeset in webkit [56905] by Nikolas Zimmermann

18 edits
9 adds in trunk

2010-03-31 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: document.documentElement.getScreenCTM() returns incorrect matrix.
https://bugs.webkit.org/show_bug.cgi?id=27183

Rewrite getCTM() / getScreenCTM() handling in an iterative way, fixing all known problems/limitations.
The bug mentioned above is actually not a regression, getScreenCTM() only worked before, because we
did not handle non-SVG CSS box parents properly. When support was added to handle those cases, the
getScreenCTM() handling was completly off, causing a lot of trouble in real-life SVG applications (carto.net for instance)

Tests: svg/custom/svgsvgelement-ctm.xhtml (fixed typo, missing unit identifier in CSS 'height' property, leading to incorrect results)

svg/custom/svgsvgelement-ctm2.xhtml
svg/custom/svgsvgelement-ctm3.xhtml
svg/custom/svgsvgelement-ctm4.xhtml
svg/custom/svgsvgelement-ctm5.xhtml

svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getBBox): (WebCore::SVGLocatable::computeCTM):
svg/SVGLocatable.h: (WebCore::SVGLocatable::localCoordinateSpaceTransform):
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::localCoordinateSpaceTransform): (WebCore::SVGSVGElement::createRenderer):
svg/SVGSVGElement.h:
svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::localCoordinateSpaceTransform):
svg/SVGStyledElement.h:
svg/SVGStyledLocatableElement.cpp: (WebCore::SVGStyledLocatableElement::getCTM): (WebCore::SVGStyledLocatableElement::getScreenCTM):
svg/SVGStyledLocatableElement.h: (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::getCTM): (WebCore::SVGStyledTransformableElement::getScreenCTM):
svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::localCoordinateSpaceTransform):
svg/SVGTextElement.cpp: (WebCore::SVGTextElement::getCTM): (WebCore::SVGTextElement::getScreenCTM):
svg/SVGTextElement.h: (WebCore::SVGTextElement::localCoordinateSpaceTransform):
svg/SVGTransformable.cpp: (WebCore::SVGTransformable::SVGTransformable):
svg/SVGTransformable.h: (WebCore::SVGTransformable::localCoordinateSpaceTransform):

2010-03-31 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: document.documentElement.getScreenCTM() returns incorrect matrix.
https://bugs.webkit.org/show_bug.cgi?id=27183

Share code between the different svgsvgelement-ctm*.xhtm tests, placed in svg/custom/resources.
Add several new tests covering getCTM()/getScreenCTM() on text, inner and outer svg elements and containers.

svg/custom/resources/svgsvgelement-ctm.js: Added. (log): (stringForMatrix): (printCTMs):
svg/custom/svgsvgelement-ctm-expected.txt:
svg/custom/svgsvgelement-ctm.xhtml:
svg/custom/svgsvgelement-ctm2-expected.txt: Added.
svg/custom/svgsvgelement-ctm2.xhtml: Added.
svg/custom/svgsvgelement-ctm3-expected.txt: Added.
svg/custom/svgsvgelement-ctm3.xhtml: Added.
svg/custom/svgsvgelement-ctm4-expected.txt: Added.
svg/custom/svgsvgelement-ctm4.xhtml: Added.
svg/custom/svgsvgelement-ctm5-expected.txt: Added.
svg/custom/svgsvgelement-ctm5.xhtml: Added.

1:22 AM Changeset in webkit [56904] by hclam@chromium.org

1 edit
2 adds in trunk/LayoutTests

Not reviewed. Build fix.

Adding test expectations missing in r56873.

platform/chromium-mac/media/audio-constructor-src-expected.txt: Added.
platform/chromium-mac/media/video-source-add-src-expected.txt: Added.

1:16 AM Changeset in webkit [56903] by darin@chromium.org

2 edits in trunk/WebCore

2010-04-01 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Darin Fisher.

[V8] Quick fix for failure in SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=36943

This allows the web worker layout tests to pass again.

bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::deserializeAndSetProperty):

1:02 AM Changeset in webkit [56902] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-04-01 Eric Seidel <eric@webkit.org>

Rubber-stamped by Adam Barth.

Add Snow Leopard Release bot to the list of "core builders" (builders which stop the commit-queue when they turn red)
https://bugs.webkit.org/show_bug.cgi?id=33292

Just adding the "Build" builder for now.
We'll add the "Test" builders when the tests
are less flaky.

Scripts/webkitpy/common/net/buildbot.py:
Scripts/webkitpy/common/net/buildbot_unittest.py:

12:38 AM Changeset in webkit [56901] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-04-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by David Levin.

Add myself to the reviewers list.

https://bugs.webkit.org/show_bug.cgi?id=36935

Scripts/webkitpy/common/config/committers.py:

12:10 AM WebKit Team edited by yurys@chromium.org

(diff)

12:04 AM Changeset in webkit [56900] by rolandsteiner@chromium.org

2 edits
6 moves in trunk/LayoutTests

2010-04-01 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed - more layout test result build fixes:
.) Fix expected layout test filenames for Chromium.
.) Add new layout test to gtk Skipped list.

Original patch review by Darin Adler (no functional change):

Bug 36803 - 'Inline-table' workaround for <ruby> broken with ruby support
https://bugs.webkit.org/show_bug.cgi?id=36803

platform/chromium-linux/fast/ruby/ruby-inline-table-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/fast/ruby/ruby-inline-table-actual.checksum.
platform/chromium-linux/fast/ruby/ruby-inline-table-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/ruby/ruby-inline-table-actual.png.
platform/chromium-linux/fast/ruby/ruby-inline-table-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/ruby/ruby-inline-table-actual.txt.
platform/chromium-win/fast/ruby/ruby-inline-table-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/ruby/ruby-inline-table-actual.checksum.
platform/chromium-win/fast/ruby/ruby-inline-table-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/ruby/ruby-inline-table-actual.png.
platform/chromium-win/fast/ruby/ruby-inline-table-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/ruby/ruby-inline-table-actual.txt.
platform/gtk/Skipped:

Mar 31, 2010:

11:35 PM Changeset in webkit [56899] by Chris Jerdonek

4 edits
3 adds in trunk/WebKitTools

Added Python style checking to check-webkit-style using
the third-party pep8 module (via autoinstall).

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=33639

Scripts/webkitpy/style/checker.py:
- Added PYTHON to FileType.
- Updated ProcessorDispatcher to return a PythonProcessor for *.py files.

Scripts/webkitpy/style/checker_unittest.py:
- Updated the ProcessorDispatcher unit tests for *.py files.

Scripts/webkitpy/style/processors/python.py: Added.
- Added PythonProcessor class.

Scripts/webkitpy/style/processors/python_unittest.py: Added.
- Added PythonProcessor unit tests.

Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
- Added a sample Python file to test the PythonProcessor.process() code path (since pep8 accepts a file path).

Scripts/webkitpy/style/unittests.py:
- Updated the style unit test file to import python_unittest.py.

Scripts/webkitpy/style_references.py:
- Adjusted style references to import pep8.

11:23 PM Changeset in webkit [56898] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-03-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

fast/replaced/border-radius-clip.html failed on Snow Leopard Debug bot
https://bugs.webkit.org/show_bug.cgi?id=36642

This test is flaky (seemingly due to <video> load times)
and is thus useless until fixed. Skipping for now.

platform/mac/Skipped:

11:09 PM Changeset in webkit [56897] by Chris Jerdonek

9 edits
1 add
2 deletes in trunk/WebKitTools

Rewrote autoinstall.py to support unzipping *.zip files after
download, unzipping and extracting *.tar.gz files after download,
and copying installed files to a given destination directory.

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=35163

These changes will let us autoinstall pep8.py from the web and put
our third-party autoinstalled code in an explicit directory like
webkitpy/thirdparty/autoinstalled. These changes should also speed
up the execution of autoinstalled *.zip packages slightly since
*.pyc files cannot be generated when importing from zipped
packages using the current autoinstall.

Scripts/test-webkitpy:
- Addressed the FIXME to enable auto-install logging once autoinstall was rewritten not to log as verbosely.

Scripts/webkitpy/common/net/bugzilla.py:
- Updated mechanize import statement.

Scripts/webkitpy/common/net/buildbot.py:
- Updated mechanize import statement.

Scripts/webkitpy/common/net/irc/ircbot.py:
- Updated ircbot and irclib import statements.

Scripts/webkitpy/common/net/networktransaction.py:
- Updated mechanize import statement.

Scripts/webkitpy/common/net/networktransaction_unittest.py:
- Updated mechanize import statement.

Scripts/webkitpy/common/net/statusserver.py:
- Updated mechanize import statement.

Scripts/webkitpy/common/system/autoinstall.py: Added.
- Added AutoInstaller class.
- Added sample/testing usage to the main block.

Scripts/webkitpy/thirdparty/init.py:
- Updated the autoinstall lines to use the new autoinstall methods.
- Added pep8.py to the list of auto-installed packages.
- Added a README file to the target autoinstallation directory so users know that the directory is safe to delete.

Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
- This is replaced by the rewritten autoinstall webkitpy/common/system/autoinstall.py.

Scripts/webkitpy/thirdparty/autoinstalled/init.py: Removed.
- The target autoinstallation directory is now auto-generated.

10:22 PM Changeset in webkit [56896] by rolandsteiner@chromium.org

1 edit
6 adds in trunk/LayoutTests

2010-04-01 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed - add missing Chromium layout test results for:

Bug 36803 - 'Inline-table' workaround for <ruby> broken with ruby support
https://bugs.webkit.org/show_bug.cgi?id=36803

(original patch review by Darin Adler).

platform/chromium-linux/fast/ruby/ruby-inline-table-expected.checksum: Added.
platform/chromium-linux/fast/ruby/ruby-inline-table-expected.png: Added.
platform/chromium-linux/fast/ruby/ruby-inline-table-expected.txt: Added.
platform/chromium-win/fast/ruby/ruby-inline-table-expected.checksum: Added.
platform/chromium-win/fast/ruby/ruby-inline-table-expected.png: Added.
platform/chromium-win/fast/ruby/ruby-inline-table-expected.txt: Added.

10:02 PM Changeset in webkit [56895] by eric@webkit.org

3 edits
2 adds in trunk

2010-03-31 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

Crash when writing into a detached TITLE element
https://bugs.webkit.org/show_bug.cgi?id=25567

fast/dom/title-content-write-set-expected.txt: Added.
fast/dom/title-content-write-set.html: Added.

2010-03-31 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

Crash when writing into a detached TITLE element
https://bugs.webkit.org/show_bug.cgi?id=25567

Document::setTitle() invoked HTMLTitleElement::setText(), which
contains DOM tree modification, even when setTitle() is called
from HTMLTitleElement::childrenChanged(). Fix to skip setText()
when setTitle() is called childrenChanged() to avoid cascading
DOM mutations between Document and HTMLTitleElement.

Test: fast/dom/title-content-write-set.html

dom/Document.cpp: (WebCore::Document::setTitle):

9:50 PM Changeset in webkit [56894] by Chris Jerdonek

2 edits in trunk/WebKitTools

Tweak webkitpy's logtesting.LogTesting class to get more mileage out
of our unit tests that test log messages.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=36886

This patch adds to the LogTesting class's tearDown() method a line
asserting that the array of remaining log messages is empty. This
ensures that no extra log messages are getting logged that the caller
might not be aware of or may have forgotten to check for.

Scripts/webkitpy/common/system/logtesting.py:
- Modified the tearDown() method as described above.
- Also modified the assertMessages() method to clear the array of log messages after asserting.

9:22 PM Changeset in webkit [56893] by Chris Jerdonek

4 edits in trunk/WebKitTools

Added support for a --verbose-logging flag to test-webkitpy.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36429

Verbose logging is useful for debugging test-webkitpy code that
runs before the actual unit tests -- things like autoinstalling and
unit-test auto-detection logic. This is different from verbose
logging of the unit tests themselves (which corresponds to the
unittest module's --verbose flag).

Scripts/test-webkitpy:
- In the configure_logging() method--
  - Added an is_verbose_logging parameter that sets the logging level to logging.DEBUG instead of logging.INFO.
  - Changed the method to throttle the logging level on the root logger's handler instead of directly on the root logger itself.
  - Enabled logging of the autoinstall module when the flag is set.

Scripts/webkitpy/thirdparty/autoinstalled/init.py:
- Added a work-around for a bug in Python 2.6's logging module that was discovered while working on this patch.

8:56 PM Changeset in webkit [56892] by Chris Jerdonek

7 edits in trunk/WebKitTools

Enabled Python's logging module for webkit-patch, and replaced
deprecated_logging with Python logging in networktransaction.py.
This eliminates some spurious output when running test-webkitpy.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36725

Scripts/webkit-patch:
- Replaced the configure_logging() function with a call to the new logutils.configure_logging() function.

Scripts/webkitpy/common/net/networktransaction.py:
- Replaced the use of deprecated_logging with Python logging.

Scripts/webkitpy/common/system/logutils.py:
- Added _default_handlers() which creates the default logging handler for webkitpy.
- Added configure_logging() which configures default logging for webkitpy.

Scripts/webkitpy/common/system/logutils_unittest.py:
- Added unit tests for logutils.configure_logging().

Scripts/webkitpy/style/checker.py:
- Refactored check-webkit-style's configure_logging() method to call the new logutils.configure_logging().

Scripts/webkitpy/style_references.py:
- Updated references as necessary.

8:49 PM Changeset in webkit [56891] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-03-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch land fails if not run from the root directory
https://bugs.webkit.org/show_bug.cgi?id=35822

The root of the problem was that ChangeLog.init expects a path
relative to the current working directory, and SCM expects to
return paths relative to the SCM root. Fix it by converting from
SCM-relative to absolute paths in Checkout.modified_changelogs

Scripts/webkitpy/common/checkout/api.py:
Scripts/webkitpy/common/checkout/api_unittest.py:

8:28 PM Changeset in webkit [56890] by rolandsteiner@chromium.org

3 edits
4 adds in trunk

2010-03-29 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Darin Adler.

Bug 36803 - 'Inline-table' workaround for <ruby> broken with ruby support
https://bugs.webkit.org/show_bug.cgi?id=36803

Don't use ruby rendering if the underlying 'display' property has been
changed into a value other than 'inline' or 'block' (such as 'inline-table').

Test: fast/ruby/ruby-inline-table.html

rendering/RenderObject.cpp: (WebCore::RenderObject::createObject):

Add layout test to confirm that 'inline-table' rendering is not affected
by ruby implementation.

fast/ruby/ruby-inline-table.html: Added.
platform/mac/fast/ruby/ruby-inline-table-expected.checksum: Added.
platform/mac/fast/ruby/ruby-inline-table-expected.png: Added.
platform/mac/fast/ruby/ruby-inline-table-expected.txt: Added.

8:27 PM Changeset in webkit [56889] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add more tests for webkitpy.common.checkout
https://bugs.webkit.org/show_bug.cgi?id=36926

We don't have a great way of testing checkout, sadly.

Scripts/webkitpy/common/checkout/api_unittest.py:

7:55 PM Changeset in webkit [56888] by abarth@webkit.org

4 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: EWS crashes on failure
https://bugs.webkit.org/show_bug.cgi?id=36924

Turns out we need to pass one more argument. My test is kind of lame,
but at least it's there.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

7:33 PM Changeset in webkit [56887] by Chris Jerdonek

1 edit in trunk/WebKitTools/ChangeLog

Unreviewed.

Fixed typo in WebKitTools/ChangeLog: opsys -> ospath.

7:08 PM Changeset in webkit [56886] by eric@webkit.org

7 edits in trunk/LayoutTests

2010-03-31 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

Fix 3 failed tests on Snow Leopard bot from 33416
https://bugs.webkit.org/show_bug.cgi?id=36910

fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Considering the case where EXT_packed_depth_stencil is unsupported.
fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Ditto.
fast/canvas/webgl/context-attributes-expected.txt: Ditto.
fast/canvas/webgl/context-attributes.html: Ditto.
fast/canvas/webgl/gl-get-calls-expected.txt: Ditto.
fast/canvas/webgl/gl-get-calls.html: Ditto.

6:54 PM Changeset in webkit [56885] by ggaren@apple.com

4 edits
2 adds in trunk

Crash submitting display:none textarea in a form
https://bugs.webkit.org/show_bug.cgi?id=36905

Reviewed by Darin Adler.

WebCore:

Test: fast/forms/textarea-submit-crash.html

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData): Do update layout before
asking our renderer for its text, since we can't rely on our renderer's
text if layout is needed.

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textWithHardLineBreaks): Don't update layout
while being asked for our text, since doing so may delete us, causing a crash.

LayoutTests:

fast/forms/textarea-submit-crash-expected.txt: Added.
fast/forms/textarea-submit-crash.html: Added.

6:43 PM Changeset in webkit [56884] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make the EWS go faster by being optimistic
https://bugs.webkit.org/show_bug.cgi?id=36916

Have the EWS be optimistic that a patch will correctly build. This
should speed up the common case by not requiring two builds for every
patch.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Scripts/webkitpy/tool/commands/queues.py:

6:13 PM Changeset in webkit [56883] by eric@webkit.org

5 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add the ability to restart sheriffbot from IRC
https://bugs.webkit.org/show_bug.cgi?id=36909

Scripts/webkitpy/tool/bot/irc_command.py:
Scripts/webkitpy/tool/bot/queueengine.py:
Scripts/webkitpy/tool/bot/sheriffircbot.py:
Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

5:58 PM Changeset in webkit [56882] by Chris Fleizach

8 edits
2 adds in trunk

WebCore: Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
https://bugs.webkit.org/show_bug.cgi?id=36845

Reviewed by Darin Adler.

Provide a way through WebKit to set an accessible label that describes the web area.

Test: platform/mac/accessibility/html-with-aria-label.html

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::setAccessibleName):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::setAccessibleName):

accessibility/AccessibilityRenderObject.h:

WebKit/mac: Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
https://bugs.webkit.org/show_bug.cgi?id=36845

Reviewed by Darin Adler.

Provide a way through WebKit to set an accessible label that describes the web area.

WebView/WebFrame.mm:

(-[WebFrame setAccessibleName:]):

WebView/WebFramePrivate.h:

LayoutTests: Test for
Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
https://bugs.webkit.org/show_bug.cgi?id=36845

Reviewed by Darin Adler.

platform/mac/accessibility/html-with-aria-label-expected.txt: Added.
platform/mac/accessibility/html-with-aria-label.html: Added.

5:47 PM Changeset in webkit [56881] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add win-ews to QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=36876

The win-ews is still experimental, but it seems to be more or less
running. We should show its results to the people.

QueueStatusServer/model/queues.py:
QueueStatusServer/templates/dashboard.html:
QueueStatusServer/templates/statusbubble.html:

5:23 PM Changeset in webkit [56880] by hclam@chromium.org

2 edits in trunk/WebKit/chromium

Not reviewed. Build fix.

Fixing a build break caused by 56872. One of the Chromium bots doesn't
like std::strstr(). Includes string.h and use strstr() instead.

src/WebGraphicsContext3DDefaultImpl.cpp:

(WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
Includes string.h and use strstr().

5:13 PM Changeset in webkit [56879] by mrowe@apple.com

5 edits in trunk

<http://webkit.org/b/36878> REGRESSION: Trailing colon on hostnames (with no port specified) causes "Not allowed to use restricted network port"

Reviewed by Darin Adler.

WebCore:

platform/KURL.cpp:

(WebCore::KURL::port): Explicitly handle the case of a colon being present in the URL after the host name but with
no port number before the path. This is handled in the same manner as the colon and port being omitted completely.

LayoutTests:

Add explicit tests for handling of allowed ports. We currently only test the ports that map to port 80: 0, 80, and "".

platform/mac/security/block-test-expected.txt:
security/block-test.html:

5:12 PM Changeset in webkit [56878] by barraclough@apple.com

9 edits in trunk/WebCore

Remove dependency on TextBreakIterator from StringImpl.cpp,
and from member methods of String.

Reviewed by Oliver Hunt.

Make 'numGraphemeClusters' & 'numCharactersInGraphemeClusters'
global function defined in PlatformString.h, rather than
member methods on String (these can be implemented purely
using the characters() and length() public interface),
and make 'makeCapitalized' a static function in RenderText.cpp.

dom/InputElement.cpp:

(WebCore::InputElement::sanitizeUserInputValue):
(WebCore::InputElement::handleBeforeTextInsertedEvent):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::tooLong):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
(WebCore::HTMLTextAreaElement::sanitizeUserInputValue):
(WebCore::HTMLTextAreaElement::tooLong):

platform/text/PlatformString.h:

(WebCore::String::makeSecure):

platform/text/String.cpp:

(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):

platform/text/StringImpl.cpp:
platform/text/StringImpl.h:
rendering/RenderText.cpp:

(WebCore::makeCapitalized):
(WebCore::RenderText::setTextInternal):

5:09 PM Changeset in webkit [56877] by eric@webkit.org

4 edits in trunk/WebCore

2010-03-31 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by David Levin.

[V8] SerializedScriptValue must be deserialized only once and in the right context
https://bugs.webkit.org/show_bug.cgi?id=36892

See also https://bugs.webkit.org/show_bug.cgi?id=34227 for the
corresponding JSC change.

General idea: SerializedScriptValue must be deserialized only once
and in the context of the intended MessageEvent recepient. The
approach we take for now is to eagerly deserialize when a
JavaScript wrapper for MessageEvent is created.

A better fix would be to keep a reference to the context in
MessageEvent and use it when lazily deserializing. It's harder to
do since the API doesn't have a clean method to have such a reference.

Tested by fast/dom/Window/window-postmessage-clone-frames.html. This
test still fails but only for the types which we can't serialize yet.

bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::deserializeAndSetProperty):
bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback):

4:45 PM Changeset in webkit [56876] by victorw@chromium.org

4 edits in trunk/WebKitTools

2010-03-30 Victor Wang <victorw@chromium.org>

Reviewed by Eric Seidel.

Update rebaseline tool to check the release image diff binary and
fallback to debug if the release version does not exist.

https://bugs.webkit.org/show_bug.cgi?id=36245

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

4:22 PM Changeset in webkit [56875] by eric@webkit.org

3 edits in trunk/WebCore

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Cleanup RedirectScheduler
https://bugs.webkit.org/show_bug.cgi?id=36874

Removed the nutty ScheduledRedirection struct in favor of a hierarchy
of classes to represent the various kinds of scheduled redirects.
Doing this lets us get rid of the pseudo RTTI switch statements on
"type" in favour of calling virtual functions.

No new tests because this change should be API identical with the
existing RedirectScheduler.

loader/RedirectScheduler.cpp: (WebCore::ScheduledNavigation::ScheduledNavigation): (WebCore::ScheduledNavigation::~ScheduledNavigation): (WebCore::ScheduledNavigation::isLocationChange): (WebCore::ScheduledNavigation::shouldStartTimer): (WebCore::ScheduledNavigation::didStartTimer): (WebCore::ScheduledNavigation::didStopTimer): (WebCore::ScheduledNavigation::delay): (WebCore::ScheduledNavigation::lockHistory): (WebCore::ScheduledNavigation::lockBackForwardList): (WebCore::ScheduledNavigation::wasDuringLoad): (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): (WebCore::ScheduledURLNavigation::fire): (WebCore::ScheduledURLNavigation::didStartTimer): (WebCore::ScheduledURLNavigation::didStopTimer): (WebCore::ScheduledURLNavigation::url): (WebCore::ScheduledURLNavigation::referrer): (WebCore::ScheduledURLNavigation::wasUserGesture): (WebCore::ScheduledRedirect::ScheduledRedirect): (WebCore::ScheduledRedirect::isLocationChange): (WebCore::ScheduledRedirect::shouldStartTimer): (WebCore::ScheduledLocationChange::ScheduledLocationChange): (WebCore::ScheduledRefresh::ScheduledRefresh): (WebCore::ScheduledRefresh::fire): (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation): (WebCore::ScheduledHistoryNavigation::fire): (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
loader/RedirectScheduler.h:

3:55 PM Changeset in webkit [56874] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-03-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach buildbot.py how to parse builder activity from /one_box_per_builder
https://bugs.webkit.org/show_bug.cgi?id=36898

I also removed some obsolete FIXMEs and
refactored one_box_per_builder parsing into multiple
methods for easier reading.

Scripts/webkitpy/common/net/buildbot.py:
Scripts/webkitpy/common/net/buildbot_unittest.py:

3:53 PM Changeset in webkit [56873] by scherkus@chromium.org

2 edits
10 adds in trunk/LayoutTests

2010-03-31 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Dmitry Titov.

Checking in Chromium media baselines for layout tests fixed in r56481.

https://bugs.webkit.org/show_bug.cgi?id=36860

platform/chromium-linux/media/video-no-audio-expected.checksum: Added.
platform/chromium-linux/media/video-no-audio-expected.png: Added.
platform/chromium-mac/media/video-no-audio-expected.checksum: Added.
platform/chromium-mac/media/video-no-audio-expected.png: Added.
platform/chromium-mac/media/video-no-audio-expected.txt: Added.
platform/chromium-win/media/audio-constructor-src-expected.txt: Added.
platform/chromium-win/media/video-no-audio-expected.checksum: Added.
platform/chromium-win/media/video-no-audio-expected.png: Added.
platform/chromium-win/media/video-no-audio-expected.txt: Added.
platform/chromium-win/media/video-source-add-src-expected.txt: Added.
platform/chromium/test_expectations.txt: Tests are now passing.

3:15 PM Changeset in webkit [56872] by eric@webkit.org

15 edits
2 adds in trunk

2010-03-31 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Added.
fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Added.
fast/canvas/webgl/context-attributes-expected.txt: WebGL context attributes behavior changed with this fix.
fast/canvas/webgl/context-attributes.html: Ditto.
fast/canvas/webgl/gl-get-calls-expected.txt: Stencil buffer is enabled, thus Stencil Bits is no longer 0.
fast/canvas/webgl/gl-get-calls.html: Ditto.

2010-03-31 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Fix an index bug. (WebCore::V8HTMLCanvasElement::getContextCallback):
platform/graphics/GraphicsContext3D.h: Add members/functions for multisampling/stencil buffer purpose.
platform/graphics/mac/Canvas3DLayer.h: Add GraphicsContext3D as a member of Canvas3DLayer.
platform/graphics/mac/Canvas3DLayer.mm: Add multisampling support. (-[Canvas3DLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]):
platform/graphics/mac/GraphicsContext3DMac.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Mac. (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::validateAttributes): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::prepareTexture): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::readPixels):
platform/graphics/mac/GraphicsLayerCA.mm: Adjust to modified Canvas3DLayer init call. (WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D):

2010-03-31 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

src/WebGraphicsContext3DDefaultImpl.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Chrome. (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Deal with wrong returned alpha values in Mac.
src/WebGraphicsContext3DDefaultImpl.h: Add a function.

2:51 PM Changeset in webkit [56871] by dpranke@chromium.org

4 edits in trunk/WebKitTools

2010-03-31 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Fix logging in new-run-webkit-tests so that we don't report IMAGE
expected failures as unexpected passes when we run with pixel tests
disabled.

This change splits some of the logic embedded into the TestExpectations
classes out into separate pure functions (result_was_expected,
remove_image_failures) to make them easier to test. This also adds
a parameter to matches_an_expected_result() to indicate whether or
not pixel test results should be included in the expectations.

https://bugs.webkit.org/show_bug.cgi?id=36771

Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:

2:44 PM Changeset in webkit [56870] by Chris Jerdonek

4 edits
2 adds in trunk/WebKitTools

In webkitpy, refactored two calls to os.path.relpath() replacements
to use a common method.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=36891

Scripts/webkitpy/common/net/bugzilla.py:
- Replaced the relpath implementation with a call to webkitpy.common.system.opsys.relpath().

Scripts/webkitpy/common/system/ospath.py: Added.
- Moved the relpath() implementation from style/main.py.

Scripts/webkitpy/common/system/ospath_unittest.py: Added.
- Moved the relpath() unit tests from style/main_unittest.py.

Scripts/webkitpy/style/main.py:
- Replaced the relpath implementation with a call to webkitpy.common.system.opsys.relpath().

Scripts/webkitpy/style/main_unittest.py:
- Moved the relpath unit tests to opsys_unittest.py.

2:23 PM Changeset in webkit [56869] by jianli@chromium.org

6 edits
2 adds in trunk/WebCore

Add support to create UUID string.
https://bugs.webkit.org/show_bug.cgi?id=36472

Reviewed by Dmitry Titov.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/UUID.cpp: Added.

(WebCore::createCanonicalUUIDString):

platform/UUID.h: Added.

2:15 PM Changeset in webkit [56868] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Reviewed by NOBODY (windows build fix pt II).

1:59 PM Changeset in webkit [56867] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Reviewed by NOBODY (windows build fix).

1:57 PM Changeset in webkit [56866] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a Builder.force_build method
https://bugs.webkit.org/show_bug.cgi?id=36875

We plan to eventually use this in SheriffBot to break deadlocks created
by flaky tests.

Scripts/webkitpy/common/net/buildbot.py:

1:38 PM Changeset in webkit [56865] by eric@webkit.org

3 edits
2 adds in trunk/LayoutTests

2010-03-31 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable LayoutTests/fast/canvas/zero-size-fill-rect.html
https://bugs.webkit.org/show_bug.cgi?id=36837

Remove zero-size-fill-rect.html from skipped and create expected files.

platform/qt/Skipped:
platform/qt/fast/canvas/zero-size-fill-rect-expected.checksum: Added.
platform/qt/fast/canvas/zero-size-fill-rect-expected.png: Added.
platform/qt/fast/canvas/zero-size-fill-rect-expected.txt:

1:36 PM Changeset in webkit [56864] by barraclough@apple.com

6 edits
2 adds in trunk

Bug 36871 - Remove JSC::CString
Use WTF::CString instead (which until recently was WebCore::CString).

Reviewed by Geoff Garen.

JavaScriptCore:

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/UString.cpp:
runtime/UString.h:

JavaScriptGlue:

ForwardingHeaders/wtf/text: Added.
ForwardingHeaders/wtf/text/CString.h: Added.

1:28 PM Changeset in webkit [56863] by eric@webkit.org

6 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch reads wrong bug url from unified diff context
https://bugs.webkit.org/show_bug.cgi?id=36477

Instead of trying to figure out the bug_id from the diff, we should
just get the information from the Checkout object, which understands
these concepts.

Scripts/webkitpy/common/checkout/api.py:
Scripts/webkitpy/common/checkout/commitinfo.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/mocktool.py:

1:28 PM Changeset in webkit [56862] by Darin Adler

2 edits in trunk/WebCore

rendering/RenderThemeChromiumWin.h: Fix inconsistent line endings.

1:21 PM Changeset in webkit [56861] by hclam@chromium.org

4 edits in trunk/LayoutTests

2010-03-31 Alpha Lam <hclam@chromium.org>

Reviewed by Darin Fisher.

Update test results due to changes in r56824.
https://bugs.webkit.org/show_bug.cgi?id=36900

platform/chromium-win/fast/forms/input-file-re-render-expected.checksum:
platform/chromium-win/fast/forms/input-file-re-render-expected.png:
platform/chromium/test_expectations.txt: fast/forms/input-file-re-render.html generates incorrect results on Linux, mark it so.

1:18 PM Changeset in webkit [56860] by eric@webkit.org

5 edits
3 adds in trunk/WebCore

2010-03-31 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - form controls style
https://bugs.webkit.org/show_bug.cgi?id=36370

Adjusting Mameo5 form elements rendering.

WebCore.pri:
WebCore.pro:
css/themeQtMaemo5.css: Added. (select): (select:disabled): (select:active): (select:active:disabled): (textarea): (textarea:disabled): (textarea:active):
platform/qt/Maemo5Webstyle.cpp: Added. (Maemo5WebStyle::Maemo5WebStyle): (drawRectangularControlBackgorund): (Maemo5WebStyle::drawChecker): (Maemo5WebStyle::findChecker): (Maemo5WebStyle::drawRadio): (Maemo5WebStyle::findRadio): (Maemo5WebStyle::drawControl): (Maemo5WebStyle::drawComplexControl):
platform/qt/Maemo5Webstyle.h: Added.
platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::popupInternalPaddingBottom): (WebCore::RenderThemeQt::extraDefaultStyleSheet): (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
platform/qt/RenderThemeQt.h:

12:51 PM Changeset in webkit [56859] by ap@apple.com

3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36897
<rdar://problem/7804018> REGRESSION (r56429): Flash ads are clipped when main page is scrolled (boxofficemojo.com)

Addressing additional review comments.

rendering/RenderWidget.cpp: Removed an unneeded include.
rendering/RenderWidget.h: Reworded the new comment.

12:48 PM Changeset in webkit [56858] by ap@apple.com

4 edits
2 adds in trunk/WebCore

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=36897
<rdar://problem/7804018> REGRESSION (r56429): Flash ads are clipped when main page is scrolled (boxofficemojo.com)

manual-tests/plugin-in-iframe-scroll.html: Added.
manual-tests/resources/plugin-in-iframe-scroll-iframe.html: Added.

rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidgetGeometry): This method isn't called when an iframe containing the widget moves, so we should store a value that is not dependent on current scroll offset. (WebCore::RenderWidget::windowClipRect): Apply scroll offset and window clip now.

rendering/RenderWidget.h: Renamed m_windowClipRect to m_clipRect, because it is no longer in window coordinates.

WebCore.base.exp: Export RenderWidget::windowClipRect(), since it's no longer inline.

12:32 PM Changeset in webkit [56857] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch commit-queue should land patches optimistically
https://bugs.webkit.org/show_bug.cgi?id=34187

This patch adds an optimistic path to commit-queue and a "fail twice"
requirement for rejecting patches. That means we'll land good patches
faster (via the optmistic first run) and we'll reject many fewer
patches due to flaky tests.

Scripts/webkitpy/tool/commands/queues.py:

12:17 PM Changeset in webkit [56856] by kenneth@webkit.org

3 edits in trunk/WebCore

Unreviewed crash fix.

Crash with frame flattening on after r56854
https://bugs.webkit.org/show_bug.cgi?id=36894

Solution tested by Greg Bolsinga, thanks.

page/FrameView.cpp:

(WebCore::FrameView::avoidScrollbarCreation):

platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

12:12 PM PythonGuidelines edited by Chris Jerdonek

Retitled, and clarified the minimum Python version requirement. (diff)

11:46 AM Changeset in webkit [56855] by Csaba Osztrogonác

4 edits
8 adds in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

iframe flattening doesn't flatten
https://bugs.webkit.org/show_bug.cgi?id=36798

Platform specific expected files added, and updated after r56852.

platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt: Added.
platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt: Added.
platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt: Added.
platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt: Added.
platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt: Added.
platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt: Added.
platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt: Added.
platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt: Added.

11:03 AM Changeset in webkit [56854] by kenneth@webkit.org

6 edits in trunk/WebCore

Do not draw scrollbars for subframes when frame flattening is
enabled. Implemented using a virtual method in ScrollView as
suggested by Dave Hyatt.

Reviewed by Antti Koivisto.

Do not suppress scrollbars as that is wrong according to
Dave Hyatt.

Covered by current tests.

page/FrameView.cpp:

(WebCore::FrameView::avoidScrollbarCreation):

page/FrameView.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

platform/ScrollView.h:

(WebCore::ScrollView::avoidScrollbarCreation):

rendering/RenderPart.cpp:

(WebCore::RenderPart::layoutWithFlattening):

11:00 AM Changeset in webkit [56853] by darin@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-31 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[chromium] including WebKit.gyp:webkit should automatically add Skia
and NPAPI include paths

https://bugs.webkit.org/show_bug.cgi?id=36887

WebKit.gyp:

10:55 AM Changeset in webkit [56852] by kenneth@webkit.org

3 edits
4 adds in trunk

iframe flattening doesn't flatten
https://bugs.webkit.org/show_bug.cgi?id=36798

WebCore: Fix wrongly reversing logic in frame flattening check.

Reviewed by Antti Koivisto.

Tests:
fast/frames/flattening/iframe-flattening-fixed-height.html
fast/frames/flattening/iframe-flattening-fixed-width.html
fast/frames/flattening/iframe-flattening-fixed-width-and-height.html
fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html

rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::flattenFrame):

LayoutTests: Add more tests for iframe flattening

Reviewed by Antti Koivisto.

fast/frames/flattening/iframe-flattening-fixed-height.html
fast/frames/flattening/iframe-flattening-fixed-width.html
fast/frames/flattening/iframe-flattening-fixed-width-and-height.html
fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html

10:54 AM PythonGuidelines edited by Chris Jerdonek

Eliminated the Tips section (diff)

10:47 AM Changeset in webkit [56851] by eric@webkit.org

23 edits in trunk

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Implements cancelGeolocationPermissionRequestForFrame.
Similar to requestGeolocationPermissionForFrame(), passes Geolocation* to cancelGeolocationPermissionRequestForFrame(),
so that the embedder can identify which Geolocation object is cancelling the pending permission request.
Calls cancelGeolocationPermissionRequestForFrame() before stopUpdating() so it better matches the startUpdating() / requestPermission() flow.
https://bugs.webkit.org/show_bug.cgi?id=35031

loader/EmptyClients.h: (WebCore::EmptyChromeClient::cancelGeolocationPermissionRequestForFrame):
page/Chrome.cpp: (WebCore::Chrome::cancelGeolocationPermissionRequestForFrame):
page/Chrome.h:
page/ChromeClient.h:
page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame):

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Implements cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

public/WebGeolocationService.h: (WebKit::WebGeolocationService::cancelPermissionRequestForFrame):
src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
src/ChromeClientImpl.h:

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame):
WebCoreSupport/ChromeClientGtk.h:

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

WebCoreSupport/ChromeClientHaiku.h: (WebCore::ChromeClientHaiku::cancelGeolocationPermissionRequestForFrame):

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

WebCoreSupport/WebChromeClient.h: (WebChromeClient::cancelGeolocationPermissionRequestForFrame):

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

WebCoreSupport/WebChromeClient.h: (WebChromeClient::cancelGeolocationPermissionRequestForFrame):

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::cancelGeolocationPermissionRequestForFrame):

10:06 AM Changeset in webkit [56850] by yael.aharon@nokia.com

8 edits
2 adds in trunk/WebCore

Add animation to progress element
https://bugs.webkit.org/show_bug.cgi?id=36664

Reviewed by Antti Koivisto.

Add a timer to control the animation. The timer is started after painting
or a state change in the progress bar, to prevent animation from running
when the progress bar is not visible.

html/HTMLProgressElement.cpp:
platform/qt/RenderThemeQt.cpp:
platform/qt/RenderThemeQt.h:
rendering/RenderProgress.cpp:
rendering/RenderProgress.h:
rendering/RenderTheme.cpp:
rendering/RenderTheme.h:

10:01 AM Changeset in webkit [56849] by pfeldman@chromium.org

9 edits in trunk

2010-03-31 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out r56829 since it broke chromium layout tests.

[REGRESSION] Inspector tests started crashing since r56829
https://bugs.webkit.org/show_bug.cgi?id=36888

bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/V8Utilities.cpp:
bindings/v8/V8Utilities.h:
loader/FrameLoaderClient.h: WebKit/chromium:
public/WebFrameClient.h:
src/FrameLoaderClientImpl.cpp:
src/FrameLoaderClientImpl.h:

9:53 AM Changeset in webkit [56848] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-03-31 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

[Chromium] Enable fast/events/onbeforeunload-focused-iframe.html
https://bugs.webkit.org/show_bug.cgi?id=36781

platform/chromium/test_expectations.txt: Enable test now that callShouldCloseOnWebView is implemented in test_shell.

9:44 AM PythonGuidelines edited by Chris Jerdonek

Added section on consequences of not using Python 2.6 (diff)

9:29 AM Changeset in webkit [56847] by cmarrin@apple.com

1 edit in trunk/WebKitSite/blog-files/webgl/WebGL+CSS.html

more tweaks to WebGL+CSS

9:23 AM Changeset in webkit [56846] by pfeldman@chromium.org

4 edits in trunk/WebCore

2010-03-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: creating new style bugfixing.

https://bugs.webkit.org/show_bug.cgi?id=36884

InspectorDOMAgent should clear internal state upon reset (we are re-using single dom agent instance throughout entire inspector controller lifetime)
Brought back blank style 'refresh' processing logic - remove it by mistake earlier
Blocked couple of click handlers so that double-click to edit was not expanding / collapsing the pane
There is no need to reach out for matched rules upon 'refresh' update - getting computed style is sufficient.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList):
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.getStylesCallback): (WebInspector.StylesSidebarPane.prototype.update.getComputedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._refreshUpdate): (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): (WebInspector.StylesSidebarPane.prototype.addBlankSection): (WebInspector.StylePropertiesSection.prototype._dblclickEmptySpace): (WebInspector.StylePropertiesSection.prototype._clickSelector):

9:22 AM PythonGuidelines edited by Chris Jerdonek

Wording improvements to upgrade section. (diff)

9:16 AM PythonGuidelines edited by Chris Jerdonek

Added outline (diff)

9:10 AM Changeset in webkit [56845] by Laszlo Gombos

2 edits in trunk/JavaScriptCore

2010-03-31 Laszlo Gombos <Laszlo Gombos>

Unreviewed, fix after r56842.

Add UNUSED_PARAM a to silence warning.

jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):

9:09 AM Changeset in webkit [56844] by yurys@chromium.org

2 edits in trunk/WebCore

2010-03-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Chromium build fix: create missing v8::HandleScope.

https://bugs.webkit.org/show_bug.cgi?id=36828

bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::canAccessInspectedWindow):

9:01 AM Changeset in webkit [56843] by eric@webkit.org

3 edits in trunk/LayoutTests

2010-03-31 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix crash

Web Inspector: [Chromium] inspector/audits-panel-functional.html crashes test_shell
https://bugs.webkit.org/show_bug.cgi?id=36885

inspector/audits-panel-functional.html:
platform/chromium/test_expectations.txt:

8:59 AM Changeset in webkit [56842] by Laszlo Gombos

3 edits in trunk/JavaScriptCore

2010-03-31 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

Refactor JITStubs.cpp so that the list of STUB_FUNCTIONs
are not dependent on the JSVALUE32_64 guard.

jit/JITStubs.cpp: Place the JSVALUE32_64 guard inside the body of cti_op_eq_strings.
jit/JITStubs.h: Remove JSVALUE32_64 guard from cti_op_eq_strings stub.

8:24 AM Changeset in webkit [56841] by yurys@chromium.org

10 edits in trunk

2010-03-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Check that injected script can still access inspected window object when wrapping console object. When the window cannot be access serialize objects as strings. Also don't call InjectedScript.dispatch if the window cannot be accessed (due to frame navigation).

https://bugs.webkit.org/show_bug.cgi?id=36828

bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::canAccessInspectedWindow):
bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::canAccessInspectedWindow):
inspector/InjectedScript.cpp: (WebCore::InjectedScript::wrapForConsole):
inspector/InjectedScriptHost.h:
inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

2010-03-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: get rid of "Unsafe JavaScript attempt..." message when inspecting frames whose content has changed.

https://bugs.webkit.org/show_bug.cgi?id=36828

http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html:

7:45 AM Changeset in webkit [56840] by eric@webkit.org

4 edits in trunk/WebCore

2010-03-31 Mattias Nissler <mnissler@google.com>

Reviewed by Pavel Feldman.

Allow generic resource URLs for cookie handling in the inspector. This
enables display of all cookies, not only those that are associated
with resources accessed through http, https or file.
https://bugs.webkit.org/show_bug.cgi?id=36877

inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
inspector/front-end/DOMAgent.js: (WebInspector.Cookies.cookieMatchesResourceURL):
inspector/front-end/inspector.js: (WebInspector.updateResource):

7:42 AM Changeset in webkit [56839] by Nikolas Zimmermann

1 edit
2 adds in trunk/LayoutTests

2010-03-31 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add missing pixel test results for svg/filters/feColorMatrix-values.svg

platform/mac/svg/filters/feColorMatrix-values-expected.checksum: Added.
platform/mac/svg/filters/feColorMatrix-values-expected.png: Added.

7:26 AM Changeset in webkit [56838] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-31 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Custom user agent for user agent switcher
https://bugs.webkit.org/show_bug.cgi?id=36757

QtLauncher/main.cpp: (LauncherWindow::showUserAgentDialog):

6:27 AM Changeset in webkit [56837] by antti.j.koivisto@nokia.com

3 edits in trunk/WebKit/qt

https://bugs.webkit.org/show_bug.cgi?id=36446
[Qt] QWebSettings::TiledBackingStoreEnabled attribute lacks documentation and default value

Reviewed by Kenneth Rohde Christiansen.

Api/qgraphicswebview.cpp:
Api/qwebsettings.cpp:

(QWebSettings::QWebSettings):

4:04 AM Changeset in webkit [56836] by eric@webkit.org

3 edits in trunk/WebKit/chromium

2010-03-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Add stubs for moveWindowBy and setAttachedWindowHeight.

https://bugs.webkit.org/show_bug.cgi?id=36842

src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsSetAttachedWindowHeight): (WebKit::WebDevToolsFrontendImpl::jsMoveWindowBy):
src/WebDevToolsFrontendImpl.h:

3:45 AM Changeset in webkit [56835] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-03-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

path to committers.py in commit-queue rejection message is wrong
https://bugs.webkit.org/show_bug.cgi?id=36865

This fix would have only been 3 lines long if we had

Had access to an SCM object or tool to give us the checkout root
Been able to depend on Python 2.6 Instead I've added a bunch of hack code, but at least now we should never have to update this string again as the location of committers.py is fully dynamically discovered. :p

Scripts/webkitpy/common/net/bugzilla.py:
Scripts/webkitpy/common/net/bugzilla_unittest.py:

3:35 AM Changeset in webkit [56834] by jorlow@chromium.org

6 edits
1 copy
1 move in trunk/WebCore

2010-03-30 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB: Finish hooking up bindings for IndexedDatabaseRequest
https://bugs.webkit.org/show_bug.cgi?id=36830

Still not enough hooked up to test. Soon!

WebCore.gypi:
bindings/v8/custom/V8CustomIDBCallback.h: Removed.
bindings/v8/custom/V8CustomIDBCallbacks.h: Added. (WebCore::V8CustomIDBCallbacks::create): (WebCore::V8CustomIDBCallbacks::~V8CustomIDBCallbacks): (WebCore::V8CustomIDBCallbacks::onSuccess): (WebCore::V8CustomIDBCallbacks::onError): (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks):
bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: (WebCore::V8IndexedDatabaseRequest::openCallback):
storage/IDBDatabaseRequest.cpp: Added. (WebCore::IDBDatabaseRequest::IDBDatabaseRequest): (WebCore::IDBDatabaseRequest::~IDBDatabaseRequest):
storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::create):
storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
storage/IndexedDatabaseRequest.h:

3:26 AM Changeset in webkit [56833] by eric@webkit.org

5 edits in trunk

2010-03-31 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Implement memmove behavior for WebGLArray set()
https://bugs.webkit.org/show_bug.cgi?id=35619

fast/canvas/webgl/array-setters-expected.txt: Testing shared overlapping buffer set() behaviors.
fast/canvas/webgl/array-setters.html: Ditto.

2010-03-31 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Implement memmove behavior for WebGLArray set()
https://bugs.webkit.org/show_bug.cgi?id=35619

New test cases are added to fast/canvas/webgl/array-setters.html.

html/canvas/WebGLArray.cpp: Use memmove instead of memcpy; with memmove, copying takes place as if an intermediate buffer was used, allowing the destination and source to overlap. (WebCore::WebGLArray::setImpl):

3:08 AM Changeset in webkit [56832] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-03-31 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

[chromium] test_expectations.txt swept for MAC test cases becoming PASS
https://bugs.webkit.org/show_bug.cgi?id=36863

platform/chromium/test_expectations.txt: Cleaned up test_expectations.txt for MAC which are now PASS.

2:50 AM Changeset in webkit [56831] by eric@webkit.org

3 edits in trunk/WebCore

2010-03-31 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Darin Adler.

tryLayoutDoingPositionedMovementOnly does not have to be in RenderObject or be virtual
https://bugs.webkit.org/show_bug.cgi?id=36810

Move tryLayoutDoingPositionedMovementOnly as a regular method of RenderBox

rendering/RenderBox.h: (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
rendering/RenderObject.h:

2:48 AM QtWebKitJournal edited by fboudra@gmail.com

(diff)

1:56 AM Changeset in webkit [56830] by eric@webkit.org

3 edits
2 adds in trunk/LayoutTests

2010-03-31 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Darin Adler.

[Qt] Remove LayoutTests/fast/canvas/image-object-in-canvas.html from Skipped
https://bugs.webkit.org/show_bug.cgi?id=36836

Enable LayoutTests/fast/canvas/image-object-in-canvas.html at LayoutTests

platform/qt/Skipped:
platform/qt/fast/canvas/image-object-in-canvas-expected.checksum: Added.
platform/qt/fast/canvas/image-object-in-canvas-expected.png: Added.
platform/qt/fast/canvas/image-object-in-canvas-expected.txt:

1:37 AM Changeset in webkit [56829] by eric@webkit.org

9 edits in trunk

2010-03-31 John Gregg <johnnyg@google.com>

Reviewed by Darin Fisher.

[chromium] add logging of cross-frame property accesses for site isolation
https://bugs.webkit.org/show_bug.cgi?id=35773

No new tests as no new functionality.

bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/V8Utilities.cpp: (WebCore::logPropertyAccess):
bindings/v8/V8Utilities.h:
loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::logCrossFramePropertyAccess):

2010-03-31 John Gregg <johnnyg@google.com>

Reviewed by Darin Fisher.

[chromium] add logging of cross-frame property accesses for site isolation
https://bugs.webkit.org/show_bug.cgi?id=35773

public/WebFrameClient.h: (WebKit::WebFrameClient::logCrossFramePropertyAccess):
src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::logCrossFramePropertyAccess):
src/FrameLoaderClientImpl.h:

12:16 AM April 2010 Meeting edited by kim.gronholm@nomovok.com

(diff)

12:14 AM Changeset in webkit [56828] by hamaji@chromium.org

2 edits in trunk/WebKitTools

2010-03-31 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed test fix for r56809.

webkit-patch what-broke throws exception
https://bugs.webkit.org/show_bug.cgi?id=36852

Scripts/webkitpy/common/checkout/api_unittest.py:

12:04 AM Changeset in webkit [56827] by hamaji@chromium.org

2 edits
7 adds in trunk/LayoutTests

2010-03-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

[Chromium] fast/repaint/overflow-scroll-body-appear need to be rebaselined
https://bugs.webkit.org/show_bug.cgi?id=36825

platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
platform/chromium/test_expectations.txt:

Mar 30, 2010:

11:09 PM Changeset in webkit [56826] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Fixing b0rked version of JavaScriptCore.vcproj - added lines were truncated.

Reviewed by NOBODY (windows build fix).

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

10:44 PM Changeset in webkit [56825] by barraclough@apple.com

259 edits
2 moves
3 adds in trunk

Rubber stamped by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=36866
Move CString to WTF

JavaScriptCore:

Android.mk:
GNUmakefile.am:
JavaScriptCore.exp:
JavaScriptCore.gypi:
JavaScriptCore.pro:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
wtf/text: Added.
wtf/text/CString.cpp: Copied from WebCore/platform/text/CString.cpp.
wtf/text/CString.h: Copied from WebCore/platform/text/CString.h.

(WTF::CStringBuffer::data):
(WTF::CStringBuffer::length):
(WTF::CStringBuffer::create):
(WTF::CStringBuffer::CStringBuffer):
(WTF::CStringBuffer::mutableData):
(WTF::CString::CString):
(WTF::CString::isNull):
(WTF::CString::buffer):
(WTF::operator!=):

WebCore:

Android.mk:
ForwardingHeaders/wtf/text: Added.
ForwardingHeaders/wtf/text/CString.h: Added.
GNUmakefile.am:
WebCore.base.exp:
WebCore.gypi:
WebCore.order:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
bindings/js/JSDOMWindowBase.cpp:
bindings/js/ScheduledAction.cpp:
bindings/js/ScriptController.cpp:
bindings/v8/ScriptController.cpp:
bindings/v8/V8Binding.cpp:
bindings/v8/V8DOMWindowShell.cpp:
bridge/jni/JNIBridge.cpp:
bridge/jni/v8/JavaStringV8.h:

(JSC::Bindings::JavaStringImpl::init):

css/CSSParser.cpp:
dom/CharacterData.cpp:
dom/Document.cpp:
dom/Element.cpp:
dom/Node.cpp:
dom/Position.cpp:
dom/Range.cpp:
dom/Text.cpp:
dom/XMLTokenizer.cpp:
dom/XMLTokenizerLibxml2.cpp:
dom/XMLTokenizerQt.cpp:
editing/SelectionController.cpp:
editing/VisiblePosition.cpp:
editing/VisibleSelection.cpp:
history/CachedFrame.cpp:
history/HistoryItem.cpp:
history/qt/HistoryItemQt.cpp:
html/FormDataList.h:

(WebCore::FormDataList::appendData):
(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::Item::data):

html/HTMLDocument.cpp:
html/PreloadScanner.cpp:
inspector/InspectorController.cpp:
inspector/InspectorDOMAgent.cpp:
loader/DocLoader.cpp:
loader/FTPDirectoryDocument.cpp:
loader/FrameLoader.cpp:
loader/HistoryController.cpp:
loader/ProgressTracker.cpp:
loader/appcache/ApplicationCacheStorage.cpp:
loader/archive/cf/LegacyWebArchive.cpp:
loader/icon/wince/IconDatabaseWince.cpp:
loader/loader.cpp:
page/Console.cpp:
page/DOMWindow.cpp:
page/SecurityOrigin.cpp:
page/XSSAuditor.cpp:
page/animation/AnimationBase.cpp:
platform/ContextMenu.cpp:
platform/FileSystem.h:
platform/KURL.cpp:
platform/KURLGoogle.cpp:
platform/KURLGooglePrivate.h:
platform/Pasteboard.h:
platform/android/FileSystemAndroid.cpp:
platform/android/TemporaryLinkStubs.cpp:
platform/brew/KURLBrew.cpp:
platform/cf/FileSystemCF.cpp:
platform/chromium/MIMETypeRegistryChromium.cpp:
platform/efl/FileSystemEfl.cpp:
platform/efl/PasteboardEfl.cpp:
platform/efl/PlatformKeyboardEventEfl.cpp:
platform/efl/PlatformScreenEfl.cpp:
platform/efl/RenderThemeEfl.cpp:
platform/efl/ScrollbarEfl.cpp:
platform/efl/SharedBufferEfl.cpp:
platform/efl/WidgetEfl.cpp:
platform/graphics/GlyphPageTreeNode.cpp:
platform/graphics/cairo/FontPlatformDataCairo.cpp:
platform/graphics/cg/ImageBufferCG.cpp:
platform/graphics/chromium/FontCacheLinux.cpp:
platform/graphics/chromium/FontPlatformDataLinux.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
platform/graphics/gtk/FontPlatformDataPango.cpp:
platform/graphics/gtk/IconGtk.cpp:
platform/graphics/gtk/ImageGtk.cpp:
platform/graphics/haiku/GraphicsContextHaiku.cpp:
platform/graphics/mac/GraphicsContext3DMac.cpp:
platform/graphics/mac/GraphicsLayerCA.mm:
platform/graphics/qt/GraphicsContext3DQt.cpp:
platform/graphics/qt/ImageBufferQt.cpp:
platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
platform/graphics/qt/MediaPlayerPrivateQt.cpp:
platform/graphics/skia/GraphicsLayerSkia.cpp:
platform/graphics/win/GraphicsLayerCACF.cpp:
platform/graphics/win/WKCACFLayer.cpp:
platform/graphics/wx/FontPlatformData.h:
platform/gtk/ClipboardGtk.cpp:
platform/gtk/ContextMenuItemGtk.cpp:
platform/gtk/DataObjectGtk.h:
platform/gtk/FileChooserGtk.cpp:
platform/gtk/FileSystemGtk.cpp:
platform/gtk/GeolocationServiceGtk.cpp:
platform/gtk/KURLGtk.cpp:
platform/gtk/Language.cpp:
platform/gtk/LocalizedStringsGtk.cpp:
platform/gtk/PasteboardGtk.cpp:
platform/gtk/PopupMenuGtk.cpp:
platform/gtk/RenderThemeGtk.cpp:
platform/gtk/SharedBufferGtk.cpp:
platform/haiku/FileSystemHaiku.cpp:
platform/haiku/PlatformKeyboardEventHaiku.cpp:
platform/network/CredentialStorage.cpp:
platform/network/FormData.cpp:
platform/network/FormData.h:
platform/network/FormDataBuilder.cpp:
platform/network/FormDataBuilder.h:
platform/network/HTTPParsers.cpp:
platform/network/android/ResourceHandleAndroid.cpp:
platform/network/cf/FormDataStreamCFNet.cpp:
platform/network/cf/ResourceHandleCFNet.cpp:
platform/network/chromium/ResourceResponse.h:
platform/network/curl/FormDataStreamCurl.cpp:
platform/network/curl/ResourceHandleManager.cpp:
platform/network/curl/ResourceHandleManager.h:
platform/network/mac/FormDataStreamMac.mm:
platform/network/mac/ResourceHandleMac.mm:
platform/network/qt/QNetworkReplyHandler.cpp:
platform/network/soup/CookieJarSoup.cpp:
platform/network/soup/ResourceHandleSoup.cpp:
platform/network/soup/ResourceRequestSoup.cpp:
platform/network/soup/ResourceResponseSoup.cpp:
platform/network/win/ResourceHandleWin.cpp:
platform/posix/FileSystemPOSIX.cpp:
platform/qt/FileSystemQt.cpp:
platform/qt/KURLQt.cpp:
platform/qt/TemporaryLinkStubs.cpp:
platform/sql/chromium/SQLiteFileSystemChromium.cpp:
platform/text/CString.cpp: Removed.
platform/text/CString.h: Removed.
platform/text/PlatformString.h:
platform/text/String.cpp:
platform/text/StringImpl.cpp:
platform/text/TextCodec.h:
platform/text/TextCodecICU.cpp:
platform/text/TextCodecLatin1.cpp:
platform/text/TextCodecUTF16.cpp:
platform/text/TextCodecUserDefined.cpp:
platform/text/TextEncoding.cpp:
platform/text/TextEncoding.h:
platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
platform/text/gtk/TextCodecGtk.cpp:
platform/text/haiku/StringHaiku.cpp:
platform/text/mac/TextCodecMac.cpp:
platform/text/qt/TextCodecQt.cpp:
platform/text/wx/StringWx.cpp:
platform/win/ClipboardUtilitiesWin.cpp:
platform/win/ClipboardWin.cpp:
platform/win/ContextMenuItemWin.cpp:
platform/win/ContextMenuWin.cpp:
platform/win/FileSystemWin.cpp:
platform/win/GDIObjectCounter.cpp:
platform/win/Language.cpp:
platform/win/PasteboardWin.cpp:
platform/wince/FileSystemWince.cpp:
platform/wince/KeygenWince.cpp:
platform/wince/PasteboardWince.cpp:
platform/wx/FileSystemWx.cpp:
platform/wx/LoggingWx.cpp:
plugins/PluginDebug.h:
plugins/PluginPackage.cpp:
plugins/PluginStream.cpp:
plugins/PluginStream.h:
plugins/PluginView.h:
plugins/gtk/PluginPackageGtk.cpp:
plugins/mac/PluginPackageMac.cpp:
plugins/qt/PluginPackageQt.cpp:
plugins/symbian/PluginPackageSymbian.cpp:
plugins/win/PluginPackageWin.cpp:
rendering/RenderLayer.cpp:
rendering/RenderLayerCompositor.cpp:
rendering/RenderTreeAsText.cpp:
storage/Database.cpp:
storage/SQLTransactionCoordinator.cpp:
storage/SQLTransactionCoordinator.h:
storage/StorageAreaSync.cpp:
storage/StorageSyncManager.cpp:
storage/chromium/DatabaseTrackerChromium.cpp:
storage/chromium/QuotaTracker.cpp:
storage/chromium/QuotaTracker.h:
svg/SVGFontFaceElement.cpp:
svg/SVGStyledElement.cpp:
svg/SVGUseElement.cpp:
websockets/WebSocket.cpp:
websockets/WebSocketChannel.cpp:
websockets/WebSocketHandshake.cpp:
wml/WMLErrorHandling.cpp:
wml/WMLGoElement.cpp:
wml/WMLPageState.cpp:
wml/WMLPostfieldElement.cpp:
wml/WMLSelectElement.cpp:
xml/XMLHttpRequest.cpp:
xml/XSLStyleSheetLibxslt.cpp:
xml/XSLTProcessorLibxslt.cpp:

WebKit:

efl/WebCoreSupport/ChromeClientEfl.cpp:
efl/ewk/ewk_frame.cpp:

(ewk_frame_name_get):
(ewk_frame_selection_get):
(ewk_frame_uri_changed):

efl/ewk/ewk_history.cpp:
efl/ewk/ewk_settings.cpp:

WebKit/chromium:

public/WebCString.h:
src/FrameLoaderClientImpl.cpp:
src/GraphicsContext3D.cpp:
src/WebCString.cpp:

(WebKit::WebCString::assign):
(WebKit::WebCString::WebCString):
(WebKit::WebCString::operator=):
(WebKit::WebCString::operator WTF::CString):

src/WebMediaPlayerClientImpl.cpp:
src/WebString.cpp:
src/WebURLError.cpp:

WebKit/gtk:

WebCoreSupport/ChromeClientGtk.cpp:
WebCoreSupport/ContextMenuClientGtk.cpp:
WebCoreSupport/EditorClientGtk.cpp:
WebCoreSupport/FrameLoaderClientGtk.cpp:
WebCoreSupport/InspectorClientGtk.cpp:
gdom/ConvertToGCharPrivate.h:
webkit/webkitdownload.cpp:
webkit/webkithittestresult.cpp:
webkit/webkitnetworkrequest.cpp:
webkit/webkitprivate.h:
webkit/webkitsecurityorigin.cpp:
webkit/webkitwebdatabase.cpp:
webkit/webkitwebframe.cpp:
webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_finalize):
(webkit_web_history_item_get_target):

webkit/webkitwebresource.cpp:
webkit/webkitwebsettings.cpp:
webkit/webkitwebview.cpp:

WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::getCookies):
(WebKit::NetscapePluginInstanceProxy::getProxy):
(WebKit::NetscapePluginInstanceProxy::getAuthenticationInfo):
(WebKit::NetscapePluginInstanceProxy::resolveURL):

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm:
Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView resolveURL:forTarget:]):

WebKit/qt:

Api/qwebelement.cpp:

WebKit/win:

WebDownload.cpp:
WebDownloadCFNet.cpp:
WebDownloadCurl.cpp:
WebHistoryItem.cpp:
WebLocalizableStrings.cpp:
WebMutableURLRequest.cpp:
WebPreferences.cpp:

(WebPreferences::migrateWebKitPreferencesToCFPreferences):

WebView.cpp:

WebKit/wx:

WebFrame.cpp:
WebView.cpp:

9:35 PM Changeset in webkit [56824] by tkent@chromium.org

7 edits in trunk

2010-03-30 Kent Tamura <tkent@chromium.org>

Reviewed by Brady Eidson.

REGRESSION (r56439) - Crash when a renderer for a file upload control
with a selected file is recreated
https://bugs.webkit.org/show_bug.cgi?id=36723

fast/forms/input-file-re-render.html: Force to do re-layout to check the regression.

2010-03-30 Kent Tamura <tkent@chromium.org>

Reviewed by Brady Eidson.

REGRESSION (r56439) - Crash when a renderer for a file upload control
with a selected file is recreated
https://bugs.webkit.org/show_bug.cgi?id=36723

RenderFileUploadControl::chooseIconForFiles was called before
m_fileChooser was initialized.

platform/FileChooser.cpp: (WebCore::FileChooser::FileChooser): Introduce m_isInitializing flag to avoid FileChooserClient::repaint() call. (WebCore::FileChooser::loadIcon): (WebCore::FileChooser::iconLoaded):
platform/FileChooser.h: Add a FielChooser parameter to FileChooserClient::chooseIconForFiles().
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::chooseIconForFiles): (WebCore::RenderFileUploadControl::paintObject): Add an assertion.
rendering/RenderFileUploadControl.h:

9:32 PM Changeset in webkit [56823] by Chris Jerdonek

2 edits in trunk/WebKitTools

Rubber stamped by Dave Levin.

Made check-webkit-style less chatty.

Examples include:

Scripts/webkitpy/style/checker.py:
- Changed unrecognized file type log message from info to debug.

8:36 PM Changeset in webkit [56822] by Laszlo Gombos

2 edits in trunk/WebCore

2010-03-30 Stanislav Paltis <Stanislav.Paltis@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] qmake/symbian build failure
https://bugs.webkit.org/show_bug.cgi?id=36745

Fix build break in Symbian build introduced in r56714,
by modifying comment escape character from ";" to "#".

WebCore.pro:

8:09 PM April 2010 Meeting edited by staikos@kde.org

(diff)

7:00 PM Changeset in webkit [56821] by yuzo@google.com

3 edits
2 deletes in trunk/LayoutTests

2010-03-30 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Fix LayoutTests/fast/dom/Window/window-resize.html
The test failed on Mac if Dock is placed on the left or the right because the window's width
and horizontal position can be adjusted by the OS.
This patch fixes it by using window.availWidth instead of window.width as the expected
values and by avoid using constant expected values.
As a side effect, the expected values become platform independent.

https://bugs.webkit.org/show_bug.cgi?id=36813

fast/dom/Window/window-resize-expected.txt:
fast/dom/Window/window-resize.html:
platform/mac/fast/dom/Window/window-resize-expected.txt: Removed.
platform/win/fast/dom/Window/window-resize-expected.txt: Removed.

6:25 PM Changeset in webkit [56820] by hclam@chromium.org

2 edits in trunk/LayoutTests

2010-03-30 Alpha Lam <hclam@chromium.org>

Reviewed by Dmitry Titov.

[chromium] Fix test expectations for a new test added in r56779
https://bugs.webkit.org/show_bug.cgi?id=36868

inspector/audits-panel-functional.html is crashing on Windows. Mark it so.

platform/chromium/test_expectations.txt: Add expectation for inspector/audits-panel-functional.html to mark it as crashing.

6:19 PM Changeset in webkit [56819] by kevino@webkit.org

6 edits in trunk

wx build fixes after new method additions and a method rename.

5:35 PM Changeset in webkit [56818] by hclam@chromium.org

7 edits
6 adds in trunk/LayoutTests

2010-03-30 Alpha Lam <hclam@chromium.org>

Reviewed by Dmitry Titov.

[chromium] New test results due to 56776
https://bugs.webkit.org/show_bug.cgi?id=36857

Adding new layout test results for chromium for tests added in r56776.

platform/chromium-linux/svg/custom/glyph-transformation-with-hkern-expected.checksum: Added.
platform/chromium-linux/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum: Added.
platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
platform/chromium-win/svg/custom/glyph-transformation-with-hkern-expected.checksum: Added.
platform/chromium-win/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
platform/chromium/test_expectations.txt: Removed the failing expectation for platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html because the difference in only in the scroll bar, there is not difference in the image content. Also fixed a grammar problem in last commit.

5:34 PM Changeset in webkit [56817] by hclam@chromium.org

1 edit in trunk/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py

fixed rebaseline

5:27 PM Changeset in webkit [56816] by scherkus@chromium.org

2 edits in trunk/LayoutTests

2010-03-30 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, expectations tweak.

Updating expectations to stop skipping tests that were fixed in r56481.

platform/chromium/test_expectations.txt: Don't skip fixed tests.

4:58 PM Changeset in webkit [56815] by weinig@apple.com

2 edits in trunk/WebCore

Add missing export.

Reviewed by Anders Carlsson.

WebCore.base.exp:

4:44 PM Changeset in webkit [56814] by hclam@chromium.org

2 edits in trunk/LayoutTests

2010-03-30 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

[chromium] Fix test_expectations for new test added in r56795
https://bugs.webkit.org/show_bug.cgi?id=36861

platform/chromium/test_expectations.txt: Expects svg/animations/animate-points.html to fail because a API is missing in Chromium. See http://crbug.com/39904.

4:12 PM Changeset in webkit [56813] by enrica@apple.com

3 edits
2 adds in trunk

Incorrect insertion position after typing THAI CHARACTER SARA AM = 0E33.
<rdar://problem/7810749>
https://bugs.webkit.org/show_bug.cgi?id=36858

Reviewed by Darin Adler.

WebCore:

Test: fast/text/multiglyph-characters.html

Characters with multiple glyph were not supported correctly.
Computing the advance width was producing a division by zero.

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::advance):

LayoutTests:

fast/text/multiglyph-characters-expected.txt: Added.
fast/text/multiglyph-characters.html: Added.

3:35 PM Changeset in webkit [56812] by mrowe@apple.com

4 edits in trunk

Versioning.

3:33 PM Changeset in webkit [56811] by mrowe@apple.com

1 copy in tags/Safari-533.3

New tag.

2:51 PM Changeset in webkit [56810] by abarth@webkit.org

3 edits
3 adds in trunk

2010-03-30 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add test for SVG pattern canvas tainting.

https://bugs.webkit.org/show_bug.cgi?id=36838

fast/canvas/svg-taint.html: Added
fast/canvas/svg-taint-expected.txt: Added
fast/canvas/resources/empty.svg: Added

2010-03-30 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Taint the canvas if an SVG-derived pattern is rendered into it.

https://bugs.webkit.org/show_bug.cgi?id=36838

Test: fast/canvas/svg-taint.html

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern): Take into account the image's hasSingleSecurityOrigin() property.

2:44 PM Changeset in webkit [56809] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-03-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch what-broke throws exception
https://bugs.webkit.org/show_bug.cgi?id=36852

Scripts/webkitpy/common/checkout/api.py: Add missing import StringIO.
Scripts/webkitpy/common/checkout/api_unittest.py: Test the function which previously threw and exception.

2:27 PM Changeset in webkit [56808] by ap@apple.com

2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36616
Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown

https://bugs.webkit.org/show_bug.cgi?id=36797
For non-Roman layouts, keydown Event.keyCode is always 0

DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): Generate a correct keyCode for keys used in tests (we used to always pass 0 for 'A').

1:58 PM April 2010 Meeting edited by jasonr@bsquare.com

(diff)

1:48 PM Changeset in webkit [56807] by scherkus@chromium.org

3 edits in trunk/LayoutTests

2010-03-30 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Darin Adler.

Updating expectations for video-no-audio.html to reflect changes made in r56481.

https://bugs.webkit.org/show_bug.cgi?id=36846

platform/mac-tiger/media/video-no-audio-expected.txt: Updating due to different source video dimensions.
platform/win/media/video-no-audio-expected.txt: Ditto.

1:37 PM Changeset in webkit [56806] by sullivan@apple.com

2 edits in trunk/WebKit/mac

https://bugs.webkit.org/show_bug.cgi?id=36848
<rdar://problem/7362913>
Menu items appropriate only for rich-content editing can appear in plain-text contexts

Reviewed by Dan Bernstein.

WebView/WebHTMLView.mm:

(-[WebHTMLView validRequestorForSendType:returnType:]):
Don't return self for non-string content if _canEditRichly is false.

1:10 PM Changeset in webkit [56805] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-03-30 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QGraphicsScene mousePressEvent does not set the clickCausedFocus flag
https://bugs.webkit.org/show_bug.cgi?id=35259

The clickCausedFocus flag is not being set in method
mousePressEvent(QGraphicsSceneMouseEvent* ev). This flag is used
in conjunction with QStyle::RSIP_OnMouseClickAndAlreadyFocused when
deciding to launch the software input panel.

Api/qwebpage.cpp: (QWebPagePrivate::mousePressEvent):

1:00 PM Changeset in webkit [56804] by ap@apple.com

3 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36616
Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown

https://bugs.webkit.org/show_bug.cgi?id=36797
For non-Roman layouts, keydown Event.keyCode is always 0

platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForKeyCode): This is now the primary function for determining Windows key code - there is no reason to round trip a virtual key code via character code to get Windows virtual key code, and this can't work for non-Roman alphabets. (WebCore::windowsKeyCodeForCharCode): Removed keys that are now handled in windowsKeyCodeForKeyCode(), only keeping those for which we don't have known key codes (yet?).

platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Added comments.

12:51 PM Changeset in webkit [56803] by eric@webkit.org

9 edits
2 copies
1 move
1 add in trunk

2010-03-30 Marcus Bulach <bulach@chromium.org>

Reviewed by Darin Fisher.

Rename / tidy up Geolocation bridge
Uses Geoposition instead of individual params for setLastPosition.
https://bugs.webkit.org/show_bug.cgi?id=36535

platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceChromium::GeolocationServiceChromium): (WebCore::GeolocationServiceChromium::setIsAllowed): (WebCore::GeolocationServiceChromium::setLastPosition):
platform/chromium/GeolocationServiceChromium.h:

2010-03-30 Marcus Bulach <bulach@chromium.org>

Reviewed by Darin Fisher.

Rename / tidy up Geolocation bridge:
Rename GeolocationServiceBridgeChromium.cpp to WebGeolocationServiceBridgeImpl.cpp
Uses a temporary compatibility layer in GeolocationServiceBridgeChromium.h.

https://bugs.webkit.org/show_bug.cgi?id=36535

WebKit.gyp:
public/GeolocationServiceBridgeChromium.h:
public/WebGeolocationService.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h. (WebKit::WebGeolocationService::detachBridge):
public/WebGeolocationServiceBridge.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
public/WebViewClient.h: (WebKit::WebViewClient::geolocationService):
src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
src/ChromiumBridge.cpp:
src/GeolocationServiceBridgeChromium.cpp: Removed.
src/WebGeolocationServiceBridgeImpl.cpp: Copied from WebKit/chromium/src/GeolocationServiceBridgeChromium.cpp. (WebKit::createGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::getBridgeId): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::getWebViewClient):
src/WebGeolocationServiceBridgeImpl.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.

12:31 PM Changeset in webkit [56802] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-03-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement win-ews
https://bugs.webkit.org/show_bug.cgi?id=36809

Scripts/webkitpy/common/config/ports.py:
Scripts/webkitpy/tool/commands/earlywarningsystem.py:

12:21 PM Changeset in webkit [56801] by cmarrin@apple.com

1 edit in trunk/WebKitSite/blog-files/webgl/WebGL+CSS.html

Fixed some size issues caused by how we now compute the WebGL canvas size

11:16 AM Changeset in webkit [56800] by agl@chromium.org

7 edits in trunk

2010-03-30 Adam Langley <agl@chromium.org>

Reviewed by David Levin.

[chromium] linux: prefer the "hinting" fontconfig preference.

fontconfig can give contradictory hinting information, setting
"hinting" to zero and "hintstyle" to non-zero. In this case we
should take the "hinting" preference.

https://bugs.webkit.org/show_bug.cgi?id=36602

platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):

10:42 AM Changeset in webkit [56799] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-03-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Copying from the Content tab in Resources includes line numbers.

https://bugs.webkit.org/show_bug.cgi?id=35104

inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype._beforeCopy): (WebInspector.TextViewer.prototype._copy):

10:32 AM Changeset in webkit [56798] by pfeldman@chromium.org

5 edits in trunk

2010-03-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not send empty matching rules for pseudo elements to frontend.

https://bugs.webkit.org/show_bug.cgi?id=36834

inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update):

10:09 AM Changeset in webkit [56797] by ap@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36791
Add assertions for instance proxy validity

Add some assertions that the instance proxy hasn't been deleted. We sometimes keep a raw
pointer to one across complicated function calls, relying on the caller to protect the
reference.

Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::renderContextID): (WebKit::NetscapePluginInstanceProxy::pluginView): (WebKit::NetscapePluginInstanceProxy::hostProxy):

9:57 AM Changeset in webkit [56796] by jianli@chromium.org

2 edits in trunk/LayoutTests

[chromium] Update test_expectations.txt to enable send-dragged-sliced-file.html
https://bugs.webkit.org/show_bug.cgi?id=36764

Reviewed by Dmitry Titov.

platform/chromium/test_expectations.txt:

9:40 AM Changeset in webkit [56795] by krit@webkit.org

8 edits
3 adds in trunk

2010-03-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Cannot animate "points" attribute for <svg:polygon>
https://bugs.webkit.org/show_bug.cgi?id=21371

Add animation support for 'points' on polygons in SVG.

Test: svg/animations/animate-points.html

svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::determinePropertyType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget):
svg/SVGAnimateElement.h: (WebCore::SVGAnimateElement::): added PropertyType PointsProperty
svg/SVGPointList.cpp: (WebCore::blendFunc): (WebCore::SVGPointList::createAnimated): calculates animated PointList
svg/SVGPointList.h:

2010-03-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Cannot animate "points" attribute for <svg:polygon>
https://bugs.webkit.org/show_bug.cgi?id=21371

Tests if points of a polygon are animateable.

svg/animations/animate-points-expected.txt: Added.
svg/animations/animate-points.html: Added.
svg/animations/script-tests/animate-points.js: Added. (sample1): (sample2): (sample3): (executeTest):

9:18 AM Changeset in webkit [56794] by Chris Jerdonek

2 edits in trunk/WebKitTools

Adjusted test-webkitpy to delete all orphaned *.pyc files
from webkitpy/ prior to importing any modules from webkitpy.
This ensures that no import statements in webkitpy falsely
succeed because of leftover *.pyc files.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=36599

Scripts/test-webkitpy:
- Added _clean_pyc_files() to delete orphaned *.pyc files from a directory.
- Added _clean_webkitpy_with_test() to call and test _clean_pyc_files().
- Moved the "import webkitpy.python24.versioning" statement from the top of the module to the init() method -- immediately after the call to _clean_webkitpy_with_test().

8:43 AM Changeset in webkit [56793] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-03-30 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: bring test expectation back - it still fails for some
reason.

platform/chromium/test_expectations.txt:

8:40 AM Changeset in webkit [56792] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Audits: bad CSS selector results in exception inside evaluated code
https://bugs.webkit.org/show_bug.cgi?id=36821

inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):

8:23 AM Changeset in webkit [56791] by jocelyn.turcotte@nokia.com

2 edits in trunk/JavaScriptCore

[Qt] Fix build break on Qt Mac.

Reviewed by nobody, build break.

DESTDIR path on Mac do not include the configuration path by default
like on Windows. Have to force it.

JavaScriptCore.pro:

7:51 AM Changeset in webkit [56790] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Package build fixes for Symbian

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-03-29
Reviewed by Simon Hausmann.

enable building standalone QtWebkit for Symbian using qtlibinfix configuration option

qtlibinfix adds possibility having multiple versions of Qt in Symbian devices.
Fix also allows unfrozen DLL exports during development.

Removed heap size configuration. DLLs don't have a heap.

Removed enforcement to def files for package builds. Instead inherit the setting from

Qt's qconfig.pri whether to use def files or not. It's still possible to override this
also at qmake time by passing CONFIG+=def_files.

WebCore.pro:

7:50 AM Changeset in webkit [56789] by pfeldman@chromium.org

3 edits in trunk/WebCore

2010-03-30 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Title for show/hide short records button was adjusted.
Some unused code was removed.
https://bugs.webkit.org/show_bug.cgi?id=36823

inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):

7:49 AM Changeset in webkit [56788] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-03-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium/test_expectations.txt:

7:45 AM Changeset in webkit [56787] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2010-03-30 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: removed failure expectation from Chromium.

platform/chromium/test_expectations.txt:

7:16 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

7:13 AM Changeset in webkit [56786] by Adam Roben

2 edits in trunk/WebKit/win

Windows build fix

Interfaces/WebKit.idl: Touched this to force a build.

7:13 AM Changeset in webkit [56785] by Adam Roben

2 edits in trunk/WebCore

Enable extra Direct3D debugging information in Debug builds

This makes it easier to track down memory leaks and misuses of the D3D
APIs in Debug builds.

Fixes <http://webkit.org/b/36820>

Reviewed by John Sullivan.

platform/graphics/win/WKCACFLayerRenderer.cpp: Define D3D_DEBUG_INFO

in Debug builds before #including d3d9.h so that extra D3D debugging
information will be enabled.

7:10 AM April 2010 Meeting edited by ukai@chromium.org

Add Fumitoshi Ukai (diff)

7:10 AM Changeset in webkit [56784] by eric@webkit.org

4 edits
2 adds in trunk

2010-03-30 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - QtMaemoWebPopup class
https://bugs.webkit.org/show_bug.cgi?id=36790

Moving maemo5 theme related code from WebCore.pri to WebCore.pro and adding
new maemo menu lists popup class source and header to the project.

The code was in .pri file because of a theme css that was conditionally included.
As the css file is been included unconditionally there is no need to this
code to be kept in webcore.pri.

WebCore.pri:
WebCore.pro:

2010-03-30 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - QtMaemoWebPopup class
https://bugs.webkit.org/show_bug.cgi?id=36790

A new QtAbstractWebPopup descendant class to be used for maemo menu lists.
This is the first step. The next step will be the dialogs implementation that
will come in bug 36789 and finally to use QtMaemoWebPopup instead of QtFallbackWebPopup
that will come in bug 36368.

WebCoreSupport/QtMaemoWebPopup.cpp: Added. (WebCore::QtMaemoWebPopup::QtMaemoWebPopup): (WebCore::QtMaemoWebPopup::~QtMaemoWebPopup): (WebCore::QtMaemoWebPopup::createSingleSelectionPopup): (WebCore::QtMaemoWebPopup::createMultipleSelectionPopup): (WebCore::QtMaemoWebPopup::createPopup): (WebCore::QtMaemoWebPopup::show): (WebCore::QtMaemoWebPopup::hide): (WebCore::QtMaemoWebPopup::popupClosed): (WebCore::QtMaemoWebPopup::itemClicked):
WebCoreSupport/QtMaemoWebPopup.h: Added. (WebCore::Maemo5Popup::Maemo5Popup):

7:01 AM FAQ edited by tony@gonk.net

Fixed incorrect use of “it’s”. Changed hyphen to m-dash. (diff)

7:01 AM Changeset in webkit [56783] by jchaffraix@webkit.org

2 edits
1 add
9 deletes in trunk/LayoutTests

fast/parser/comments.html needs some clean-up
https://bugs.webkit.org/show_bug.cgi?id=36537

Reviewed by Darin Adler.

The test is converted to dumpAsText now.
The output is also made more explicit as to what is expected (adding some PASSED and FAILED).
Finally some part of the test were actually commented so added some comment endings to make sure we run all the part of the test.

fast/parser/comments-expected.txt: Added.
fast/parser/comments.html:
platform/chromium-linux/fast/parser/comments-expected.checksum: Removed.
platform/chromium-linux/fast/parser/comments-expected.png: Removed.
platform/chromium-win/fast/parser/comments-expected.checksum: Removed.
platform/chromium-win/fast/parser/comments-expected.png: Removed.
platform/chromium-win/fast/parser/comments-expected.txt: Removed.
platform/mac/fast/parser/comments-expected.checksum: Removed.
platform/mac/fast/parser/comments-expected.png: Removed.
platform/mac/fast/parser/comments-expected.txt: Removed.
platform/qt/fast/parser/comments-expected.txt: Removed.

6:45 AM Changeset in webkit [56782] by eric@webkit.org

3 edits in trunk/WebKit/chromium

2010-03-30 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Remove dysfunctional implementation of canEstablishDatabase for
Workers. I postpone this implementation until Workers can actually
access Web Databases.

https://bugs.webkit.org/show_bug.cgi?id=36795

src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
src/WebWorkerBase.h:

6:27 AM Changeset in webkit [56781] by eric@webkit.org

16 edits
1 add in trunk

2010-03-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by David Kilzer.

Guard Geolocation files with ENABLE_GEOLOCATION
https://bugs.webkit.org/show_bug.cgi?id=25756

The intent is to guard the Geolocation implementation files
and minimize the impact on on clients/call sites.

DerivedSources.make:
WebCore.Geolocation.exp: Added. Exported interfaces if GEOLOCATION is enabled.
WebCore.base.exp:
bindings/js/JSCustomPositionCallback.cpp:
bindings/js/JSCustomPositionErrorCallback.cpp:
bindings/js/JSGeolocationCustom.cpp:
page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame): Stub implementation if GEOLOCATION is turned off. (WebCore::Geolocation::Geolocation): Ditto. (WebCore::Geolocation::~Geolocation): Ditto. (WebCore::Geolocation::setIsAllowed): Ditto.
page/Geolocation.h:
page/Geolocation.idl:
page/GeolocationPositionCache.cpp:
page/Geoposition.idl:
page/PositionError.idl:
platform/GeolocationService.cpp:
platform/mock/GeolocationServiceMock.cpp:

2010-03-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by David Kilzer.

Explicit guards for ENABLE_GEOLOCATION
https://bugs.webkit.org/show_bug.cgi?id=25756

WebCoreSupport/WebGeolocationMock.mm: (-[WebGeolocationMock setError:code:]): Make the body conditional on ENABLE(GEOLOCATION) (-[WebGeolocationMock setPosition:]): Ditto.

6:08 AM Changeset in webkit [56780] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-30 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Support EventTarget interface in fake workers (both for Worker object
and WorkerContext). Use MessagePort to implement message passing to
support passing ports in PostMessage.
https://bugs.webkit.org/show_bug.cgi?id=36763

inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.Worker.onmessageGetter): (InjectedFakeWorker.Worker.onmessageSetter): (InjectedFakeWorker.Worker): (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.onmessageGetter): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.onmessageSetter): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext): (InjectedFakeWorker.FakeWorker.prototype._addEventListener): (InjectedFakeWorker.FakeWorker.prototype._removeEventListener): (InjectedFakeWorker.FakeWorker.prototype._callbackWrapper): (InjectedFakeWorker.FakeWorker.prototype._handleException):

5:44 AM Changeset in webkit [56779] by apavlov@chromium.org

1 edit
6 adds in trunk/LayoutTests

2010-03-30 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, test missing in r56732.

inspector/audits-panel-functional-expected.txt: Added.
inspector/audits-panel-functional.html: Added.
inspector/resources/audits-script1.js: Added. (foo1):
inspector/resources/audits-script2.js: Added. (foo2):
inspector/resources/audits-script3.js: Added. (foo3):
inspector/resources/audits-style1.css: Added.

5:44 AM Changeset in webkit [56778] by benm@google.com

2 edits in trunk/WebCore

[v8] Add if ENABLE guard for Worker specific code.
https://bugs.webkit.org/show_bug.cgi?id=36597

Patch by Kristian Monsen <kristianm@google.com> on 2010-03-30
Reviewed by David Levin.

Build fix only, no new tests.

bindings/v8/V8DOMWrapper.h:

4:58 AM Changeset in webkit [56777] by jorlow@chromium.org

20 edits
1 copy
1 move
3 deletes in trunk

2010-03-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

More IndexedDB work
https://bugs.webkit.org/show_bug.cgi?id=36770

Add the "singleton" IndexedDatabase object to PageGroup
IndexedDatabase now has a create() method since PageGroup can own the instance (at least for now)
Rip out the IDBRequest stuff (now obsolete).
DOMWindow now can instantiate indexedDatabase objects on demand.

New layout tests starting with the next patch (which should make indexedDB.open() "work").

WebCore.gypi:
bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
page/DOMWindow.cpp: (WebCore::DOMWindow::indexedDB):
page/DOMWindow.h:
page/PageGroup.cpp: (WebCore::PageGroup::indexedDatabase):
page/PageGroup.h:
storage/IDBDatabase.cpp:
storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::createObjectStore):
storage/IDBDatabaseRequest.idl:
storage/IDBRequest.cpp: Removed.
storage/IDBRequest.h: Removed.
storage/IDBRequest.idl: Removed.
storage/IndexedDatabase.cpp: (WebCore::IndexedDatabase::create):
storage/IndexedDatabase.h:
storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::create): (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl):
storage/IndexedDatabaseImpl.h:
storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest):
storage/IndexedDatabaseRequest.h: (WebCore::IndexedDatabaseRequest::create):
storage/IndexedDatabaseRequest.idl:
storage/chromium/IndexedDatabase.cpp: (WebCore::IndexedDatabase::create):

2010-03-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

More IndexedDB work
https://bugs.webkit.org/show_bug.cgi?id=36770

Start the implementation of WebIndexedDatabase (for entrance back into WebKit).

WebKit.gyp:
public/WebIndexedDatabase.h:
src/WebIndexedDatabaseImpl.cpp: Added. (WebKit::WebIndexedDatabase::create): (WebKit::WebIndexedDatabaseImpl::~WebIndexedDatabaseImpl): (WebKit::WebIndexedDatabaseImpl::open):
src/WebIndexedDatabaseImpl.h: Added.

4:30 AM Changeset in webkit [56776] by krit@webkit.org

8 edits
5 adds in trunk

2010-03-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyph transformations wrong on use of SVGFont
https://bugs.webkit.org/show_bug.cgi?id=36731

Kerning on SVGFonts should be applied to the userSpace of the current Char
and not to the userSpace of the viewport. This means scaling the kerning
to match the current userSpace.

Test: svg/custom/glyph-transformation-with-hkern.svg

rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):

2010-03-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyph transformations wrong on use of SVGFont
https://bugs.webkit.org/show_bug.cgi?id=36731

Test of correct scaled kerning, if userSpace on SVGFont doesn't
match the scaling of the viewport userSpace.

platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
svg/custom/glyph-transformation-with-hkern.svg: Added.
svg/custom/resources/SVGFreeSans.svg: Added.

4:28 AM Changeset in webkit [56775] by krit@webkit.org

3 edits
4 adds in trunk

2010-03-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Animation doesn't respect 'currentColor'
https://bugs.webkit.org/show_bug.cgi?id=36695

Test: svg/custom/animation-currentColor.svg

SVG Animation can't handle currentColor at the moment. This patch catches the
color value of the target element and replaces 'currentColor' with it's color string.

svg/SVGAnimationElement.cpp: (WebCore::adjustForCurrentColor): (WebCore::SVGAnimationElement::startedActiveInterval):

2010-03-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Animation doesn't respect 'currentColor'
https://bugs.webkit.org/show_bug.cgi?id=36695

Check if SVG animation takes the color value of the target element as 'currentColor'.

platform/mac/svg/custom/animation-currentColor-expected.checksum: Added.
platform/mac/svg/custom/animation-currentColor-expected.png: Added.
platform/mac/svg/custom/animation-currentColor-expected.txt: Added.
svg/custom/animation-currentColor.svg: Added.

2:27 AM Changeset in webkit [56774] by ukai@chromium.org

2 edits in trunk/WebKitTools

2010-03-30 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Shinichiro Hamaji.

[Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
https://bugs.webkit.org/show_bug.cgi?id=36811

subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
We don't need stdin, so use devnull as stdin.
Same as https://bugs.webkit.org/show_bug.cgi?id=36586

Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin

2:11 AM Changeset in webkit [56773] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-03-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Skip http/tests/inspector-enabled on Linux and Mac where LayoutTestContoller doesn't support inspector methods yet.

https://bugs.webkit.org/show_bug.cgi?id=36807

platform/chromium/test_expectations.txt:

1:59 AM Changeset in webkit [56772] by pfeldman@chromium.org

4 edits in trunk/WebCore

2010-03-30 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Visible/captured records counter should be implemented in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=36708

English.lproj/localizedStrings.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._updateRecordsCounter): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._createRootRecord): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._filterRecords):
inspector/front-end/inspector.css: (.timeline-records-counter):

12:53 AM April 2010 Meeting edited by Philippe Normand

Igalia people (diff)

12:24 AM Changeset in webkit [56771] by levin@chromium.org

3 edits in trunk/LayoutTests

[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Adam Barth.

platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum: Due to r56655.
platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Ditto.

12:09 AM Changeset in webkit [56770] by Philippe Normand

2 edits in trunk/WebCore

2010-03-30 Philippe Normand <pnormand@igalia.com>

[GStreamer] define static variables with DEFINE_STATIC_LOCAL macro
https://bugs.webkit.org/show_bug.cgi?id=36653

Unreviewed, don't define the bool variable with
DEFINE_STATIC_LOCAL, it makes sense only for objects which have a
destructor. Thanks to Dan Bernstein for spotting this.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

12:08 AM Changeset in webkit [56769] by eric@webkit.org

3 edits in trunk/WebCore

2010-03-29 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

There is a build break due to the disabled() when wml feature is
enabled. This break comes from the Bug 35056 - Disabled menu options
are still submitted.(https://bugs.webkit.org/show_bug.cgi?id=35056)
The WMLOptionElement.h needs to define the disabled() as well.
And, there is an additional break due to Bug 36177 - Multiselect Popup

Listbox click simulation. (https://bugs.webkit.org/show_bug.cgi?id=36177) virtual void listBoxSelectItem() should be added to WMLSelectElement.h as well.

https://bugs.webkit.org/show_bug.cgi?id=36698

wml/WMLOptionElement.h: (WebCore::WMLOptionElement::disabled):
wml/WMLSelectElement.h: (WebCore::WMLSelectElement::listBoxSelectItem):

12:02 AM Changeset in webkit [56768] by levin@chromium.org

2 edits in trunk/LayoutTests

Rubber-stamped by Adam Barth.

Needed to fix test_expectations.txt for recent addition in r56764.

platform/chromium/test_expectations.txt: Added IMAGE (due to the results on OSX).

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed