Timeline
Apr 9, 2010:
- 11:35 PM Changeset in webkit [57407] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, another change to executive.py to make it run with
python 2.4.
- Scripts/webkitpy/common/system/executive.py:
- 11:20 PM Changeset in webkit [57406] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, attempting to make executive.py run with python 2.4
(which is still used on Chromium's Windows canary bot).
- Scripts/webkitpy/common/system/executive.py:
- 10:02 PM Changeset in webkit [57405] by
-
- 6 edits in trunk
2010-04-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: Console with two recursive arrays causes infinite loop trying to display.
https://bugs.webkit.org/show_bug.cgi?id=37133
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._printArray): (WebInspector.ConsoleView.prototype._formatAsArrayEntry):
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 8:18 PM WebKit2 edited by
- Spelling corrections. (diff)
- 8:09 PM Changeset in webkit [57404] by
-
- 11 edits in trunk
2010-04-09 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Eric Seidel.
[wx] Basic implementation of SVG support for wx port.
- css/CSSFontFaceSource.cpp:
- platform/graphics/wx/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size):
- platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::setLineDash):
- platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
- platform/graphics/wx/PathWx.cpp: (WebCore::Path::strokeContains): (WebCore::Path::debugString): (WebCore::Path::operator=): (WebCore::Path::isEmpty):
- rendering/RenderSVGResourceMasker.cpp:
- wscript:
2010-04-09 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Eric Seidel.
[wx] Basic implementation of SVG support for wx port.
- wx/build/settings.py:
- 7:59 PM Changeset in webkit [57403] by
-
- 2 edits in trunk/WebKit/mac
2010-04-09 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]):
- 7:50 PM Changeset in webkit [57402] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-09 Evan Stade <estade@chromium.org>
Reviewed by Eric Seidel.
[chromium] Linux: respect the scale factor during printing
https://bugs.webkit.org/show_bug.cgi?id=37168
Chromium doesn't support testing .pdfs from printing at the moment, so
this change is not covered by any tests.
- src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::spoolPage):
- 7:34 PM Changeset in webkit [57401] by
-
- 3 edits in trunk/WebKit/chromium
2010-04-09 Aaron Boodman <aa@chromium.org>
Reviewed by Eric Seidel.
Remove applicationID() from WebDocument as it is Chromium-specific.
https://bugs.webkit.org/show_bug.cgi?id=37350
- public/WebDocument.h:
- src/WebDocument.cpp:
- 7:24 PM Changeset in webkit [57400] by
-
- 2 edits in trunk/LayoutTests
2010-04-09 Adam Barth <abarth@webkit.org>
Unreviewed.
Test a theory about why this is failing downstream.
- http/tests/security/xss-DENIED-mime-type-execute-as-html.html:
- 7:17 PM Changeset in webkit [57399] by
-
- 10 edits in trunk/WebKitTools
2010-04-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't reinvent Executive.cpu_count for every port
https://bugs.webkit.org/show_bug.cgi?id=37377
mac.py and chromium_mac.py had some copy/paste code. This code doesn't
actually have anything to do with WebKit ports. It's really just
something in the multiprocessing package. The lame bit is that package
isn't available in older versions of Python, so we need to implement a
fallback. However, we already have the fallback in common. We don't
need to reinvent it specificly for layout_tests.
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 7:17 PM Changeset in webkit [57398] by
-
- 3 edits in trunk/WebKitTools
2010-04-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
new-run-webkit-tests --release fails to build release DRT when global configuration is Debug
https://bugs.webkit.org/show_bug.cgi?id=37376
We need to explicitly pass the --release flag. I bet there are more
instances of this bug.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- 7:16 PM Changeset in webkit [57397] by
-
- 2 edits in trunk/WebKit/qt
2010-04-09 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Simon Hausmann.
[Qt]Fix compile error with QT_NO_IM
https://bugs.webkit.org/show_bug.cgi?id=36533
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup):
- 7:13 PM Changeset in webkit [57396] by
-
- 59 edits in trunk/LayoutTests
2010-04-09 Sergey Ulanov <sergeyu@chromium.org>
Unreviewed, checking in baselines due to Chromium's new video scaling algorithm.
- platform/chromium-linux/media/controls-after-reload-expected.checksum:
- platform/chromium-linux/media/controls-after-reload-expected.png:
- platform/chromium-linux/media/controls-strict-expected.checksum:
- platform/chromium-linux/media/controls-strict-expected.png:
- platform/chromium-linux/media/video-aspect-ratio-expected.checksum:
- platform/chromium-linux/media/video-aspect-ratio-expected.png:
- platform/chromium-linux/media/video-controls-rendering-expected.checksum:
- platform/chromium-linux/media/video-controls-rendering-expected.png:
- platform/chromium-linux/media/video-display-toggle-expected.checksum:
- platform/chromium-linux/media/video-display-toggle-expected.png:
- platform/chromium-linux/media/video-layer-crash-expected.checksum:
- platform/chromium-linux/media/video-layer-crash-expected.png:
- platform/chromium-linux/media/video-no-audio-expected.checksum:
- platform/chromium-linux/media/video-no-audio-expected.png:
- platform/chromium-linux/media/video-transformed-expected.checksum:
- platform/chromium-linux/media/video-transformed-expected.png:
- platform/chromium-linux/media/video-volume-slider-expected.checksum:
- platform/chromium-linux/media/video-volume-slider-expected.png:
- platform/chromium-linux/media/video-zoom-expected.checksum:
- platform/chromium-linux/media/video-zoom-expected.png:
- platform/chromium-mac/media/controls-after-reload-expected.checksum:
- platform/chromium-mac/media/controls-after-reload-expected.png:
- platform/chromium-mac/media/controls-strict-expected.checksum:
- platform/chromium-mac/media/controls-strict-expected.png:
- platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
- platform/chromium-mac/media/video-aspect-ratio-expected.png:
- platform/chromium-mac/media/video-controls-rendering-expected.checksum:
- platform/chromium-mac/media/video-controls-rendering-expected.png:
- platform/chromium-mac/media/video-display-toggle-expected.checksum:
- platform/chromium-mac/media/video-display-toggle-expected.png:
- platform/chromium-mac/media/video-layer-crash-expected.checksum:
- platform/chromium-mac/media/video-layer-crash-expected.png:
- platform/chromium-mac/media/video-no-audio-expected.checksum:
- platform/chromium-mac/media/video-no-audio-expected.png:
- platform/chromium-mac/media/video-transformed-expected.checksum:
- platform/chromium-mac/media/video-transformed-expected.png:
- platform/chromium-mac/media/video-volume-slider-expected.checksum:
- platform/chromium-mac/media/video-volume-slider-expected.png:
- platform/chromium-mac/media/video-zoom-expected.checksum:
- platform/chromium-mac/media/video-zoom-expected.png:
- platform/chromium-win/media/controls-after-reload-expected.checksum:
- platform/chromium-win/media/controls-after-reload-expected.png:
- platform/chromium-win/media/controls-strict-expected.checksum:
- platform/chromium-win/media/controls-strict-expected.png:
- platform/chromium-win/media/video-aspect-ratio-expected.checksum:
- platform/chromium-win/media/video-aspect-ratio-expected.png:
- platform/chromium-win/media/video-controls-rendering-expected.checksum:
- platform/chromium-win/media/video-controls-rendering-expected.png:
- platform/chromium-win/media/video-display-toggle-expected.checksum:
- platform/chromium-win/media/video-display-toggle-expected.png:
- platform/chromium-win/media/video-layer-crash-expected.checksum:
- platform/chromium-win/media/video-layer-crash-expected.png:
- platform/chromium-win/media/video-no-audio-expected.checksum:
- platform/chromium-win/media/video-no-audio-expected.png:
- platform/chromium-win/media/video-transformed-expected.checksum:
- platform/chromium-win/media/video-transformed-expected.png:
- platform/chromium-win/media/video-volume-slider-expected.checksum:
- platform/chromium-win/media/video-volume-slider-expected.png:
- 7:06 PM Changeset in webkit [57395] by
-
- 2 edits in trunk/WebKitTools
2010-04-09 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] DRT compile fix on win/linux
https://bugs.webkit.org/show_bug.cgi?id=37314
Looks like this was missed when upstreaming.
- DumpRenderTree/chromium/EventSender.cpp: (applyKeyModifier):
- 6:56 PM Changeset in webkit [57394] by
-
- 3 edits in trunk/WebCore
2010-04-09 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
StorageEvent destructor should be in StorageEvent.cpp
https://bugs.webkit.org/show_bug.cgi?id=37356
Because Storage is forward-declared in StorageEvent.h, we need to define
the StorageEvent destructor in the .cpp file so that the RefPtr<Storage>
destructor has a complete type for Storage.
- storage/StorageEvent.cpp: (WebCore::StorageEvent::~StorageEvent):
- storage/StorageEvent.h:
- 6:45 PM Changeset in webkit [57393] by
-
- 1 edit2 adds in trunk/WebCore
2010-04-09 Young Han Lee <joybro@company100.net>
Reviewed by Eric Seidel.
[WINCE] Add forwarding header for UnicodeWince.h
https://bugs.webkit.org/show_bug.cgi?id=37224
- ForwardingHeaders/wtf/unicode/wince/UnicodeWince.h: Added.
- 6:15 PM Changeset in webkit [57392] by
-
- 5 edits in trunk/WebKit2
Bring the WebKit2 Xcode configuration in to sync with recent changes to the WebKit Xcode configuration files.
Reviewed by Sam Weinig.
In particular, this updates the FEATURE_DEFINES to match those used in the other projects, and brings in
the changes to support building WebKit for older Mac OS X versions from the current Mac OS X version.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- 6:09 PM Changeset in webkit [57391] by
-
- 7 edits in trunk/WebCore
Tidied up some more DOMWrapperWorld lifetime issues.
Reviewed by Sam "R the K!" Weinig.
- bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld): Notify the document that
we're going away instead of deleting its data, since deleting other
objects' data is error-prone and, more importantly, rude.
- bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::didCreateWrapperCache):
(WebCore::DOMWrapperWorld::didDestroyWrapperCache): A few renames for
clarity.
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h: Converted forgetAllDOMNodesForDocument
to a Document member function, for the same reason.
- dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::createWrapperCache):
(WebCore::Document::destroyWrapperCache):
(WebCore::Document::destroyAllWrapperCaches):
- dom/Document.h: Added a destroyWrapperCache function to balance
createWrapperCache, so it's clear who allocates and deletes these wrapper
caches.
- 6:00 PM Changeset in webkit [57390] by
-
- 4 edits4 adds in trunk
Reviewed by Simon Fraser.
Fixed bug where animation time was not updated when dynamically loading a style sheet
https://bugs.webkit.org/show_bug.cgi?id=37352
A dynamically loaded style sheet kicks off its own styleRecalc cycle. This was not
bracketed with a beginAnimationUpdate/endAnimationUpdate which wasn't resetting the
animation time. In some time-dependent cases this was causing a negative elapsedTime
to be sent to the keyframe animator. This is an invalid case which destroys the
animation prematurely. I not only added the brackets, but I also added an assert
and protection for when the elapsedTime comes up negative.
Test: animations/dynamic-stylesheet-loading.html
- dom/Document.cpp: Added brackets (WebCore::Document::updateStyleSelector):
- page/animation/KeyframeAnimation.cpp: Added assert and protection (WebCore::KeyframeAnimation::getKeyframeAnimationInterval):
- 5:52 PM Changeset in webkit [57389] by
-
- 5 edits1 copy1 move1 add in trunk/WebKit2
Clean up the Xcode project configuration.
Reviewed by Sam Weinig.
Common target settings are pulled out in to BaseTarget.xcconfig. The majority of setting overrides are
removed from the Xcode project itself. Info.plist files are updated to match those used in other frameworks.
- Configurations/BaseTarget.xcconfig: Copied from WebKit2/Configurations/WebKit2.xcconfig.
- Configurations/WebKit2.xcconfig:
- Configurations/WebProcess.xcconfig: Copied from WebKit2/Configurations/WebKit2.xcconfig.
- Info.plist:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess-Info.plist: Removed.
- WebProcess/Info.plist: Moved from WebProcess-Info.plist.
- 5:51 PM Changeset in webkit [57388] by
-
- 2 edits in trunk/WebKit/qt
2010-04-09 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] tst_QWebFrame::popupFocus() fails
https://bugs.webkit.org/show_bug.cgi?id=37320
The QWebPopup class has been moved & renamed, so tst_QWebFrame::popupFocus() should use
the class name "QComboBox", rather than "WebCore::QWebPopup" to find the popup menu.
- tests/qwebframe/tst_qwebframe.cpp:
- 5:41 PM Changeset in webkit [57387] by
-
- 2 edits in trunk/WebCore
2010-04-09 Jaime Yap <jaimeyap@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Fixes "wrong parent" for GCEvents that come at the end of a
timeline record node.
https://bugs.webkit.org/show_bug.cgi?id=37340
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
- 5:26 PM Changeset in webkit [57386] by
-
- 4 edits3 adds in trunk
2010-04-09 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Prevent HTTP responses served with JSON content type from being rendered as HTML.
Test: http/tests/security/xss-DENIED-mime-type-execute-as-html.html
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isTextMIMEType): Render application/json as text/plain.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes): Add a compile assert to prevent addition of new mime types in non-image types.
2010-04-09 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Test non-image and javascript mime types are not rendered as HTML.
- http/tests/security/resources/send-mime-types.php: Added.
- http/tests/security/xss-DENIED-mime-type-execute-as-html-expected.txt: Added.
- http/tests/security/xss-DENIED-mime-type-execute-as-html.html: Added.
- 4:45 PM Changeset in webkit [57385] by
-
- 2 edits in trunk/WebKit2
Build fix.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.m:
(InitWebCoreSystemInterface): Update for recent WKSI changes.
- 4:40 PM Changeset in webkit [57384] by
-
- 3 edits in trunk/WebCore
2010-04-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Prevent wrong use of PrintContext
https://bugs.webkit.org/show_bug.cgi?id=37194
No new tests because this doesn't change the behavior.
- page/PrintContext.cpp: (WebCore::PrintContext::PrintContext): (WebCore::PrintContext::~PrintContext): (WebCore::PrintContext::begin): (WebCore::PrintContext::end):
- page/PrintContext.h:
- 4:28 PM Changeset in webkit [57383] by
-
- 1 edit1 move in trunk/WebKitTools
2010-04-09 Adam Barth <abarth@webkit.org>
Unreviewed, but approved by Dirk Pranke.
rename test_expectations_test.py to test_expectations_unittest.py so it actually gets run
https://bugs.webkit.org/show_bug.cgi?id=37372
We need to end unit tests with _unittest.py for them to be autodetected
by the test harness. +6 tests.
- Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py.
- 4:28 PM Changeset in webkit [57382] by
-
- 2 edits in trunk/WebCore
2010-04-09 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Darin Fisher.
[V8] SerializedScriptValue value doesn't follow the spec for DOM objects and files
https://bugs.webkit.org/show_bug.cgi?id=37094
This patch adds support for file-related types.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::writeString): (WebCore::Writer::writeWebCoreString): (WebCore::Writer::writeBlob): (WebCore::Writer::writeFile): (WebCore::Writer::writeFileList): (WebCore::Writer::doWriteString): (WebCore::Writer::doWriteWebCoreString): (WebCore::Serializer::writeBlob): (WebCore::Serializer::writeFile): (WebCore::Serializer::writeFileList): (WebCore::Serializer::doSerialize): (WebCore::Reader::read): (WebCore::Reader::readWebCoreString): (WebCore::Reader::readBlob): (WebCore::Reader::readFile): (WebCore::Reader::readFileList): (WebCore::SerializedScriptValue::SerializedScriptValue):
- 4:19 PM Changeset in webkit [57381] by
-
- 6 edits1 move in trunk/WebKitTools
2010-04-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
new-run-webkit-tests should talk about DumpRenderTree not test_shell
https://bugs.webkit.org/show_bug.cgi?id=37371
test_shell is some strange Chromium thing.
DumpRenderTree (tm) is the real deal.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/server_process.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 4:18 PM Changeset in webkit [57380] by
-
- 2 edits in trunk/WebKitTools
2010-04-09 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix 2 issues (what were introduced in r56524) in svn-create-patch's generateDiff()
https://bugs.webkit.org/show_bug.cgi?id=32582
Add missing return variable. Initialize $patch variable and remove unnecessary condition.
- Scripts/svn-create-patch:
- 4:16 PM Changeset in webkit [57379] by
-
- 7 edits in trunk/WebCore
Tidied up some DOMWrapperWorld lifetime issues.
Reviewed by Cameron Zwarich.
- bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld): Made DOMWrapperWorld wholly
responsible for managing its presence in WebCoreJSClientData's world set.
This is simpler and more encapsulated than making its clients sometimes
responsible for managing that set and sometimes not.
- bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::create): Made isNormal default to false,
removing one of the reasons for the IsolatedWorld class to exist, so I
could remove that class.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData): Used the work-around below.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createWorld): Nixed IsolatedWorld, which is
now superfluous.
- bindings/js/WebCoreJSClientData.h:
(WebCore::initNormalWorldClientData): Added a work-around for the fact
that WebCoreJSClientData must be set as globalData->clientData before
the DOMWrapperWorld constructor runs. This removed the other reason
for the IsolatedWorld class to exist, so I could remove that class.
- 4:12 PM Changeset in webkit [57378] by
-
- 1 edit5 adds in trunk/WebCore
2010-04-09 Yaar Schnitman <yaar@chromium.org>
Reviewed by Nate Chapin.
Testing utility for CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=37286
- bindings/v8/test: Added.
- bindings/v8/test/TestObj.idl: Contains basic IDL definitions for testing purposes.
- bindings/v8/test/V8TestObj.cpp: Expected output.
- bindings/v8/test/V8TestObj.h: Expected output.
- bindings/v8/test/run_tests.py: Tool for generating the above h/cpp files from the idl file.
- 3:58 PM Changeset in webkit [57377] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=37370
Division by 0 in RenderBoxModelObject::calculateFillTileSize
Reviewed by Maciej Stachowiak.
WebCore:
Test: fast/backgrounds/background-fill-zero-area-crash.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize): Added checks for
zero before doing division. These come up when the area to fill is zero.
LayoutTests:
- fast/backgrounds/background-fill-zero-area-crash-expected.txt: Added.
- fast/backgrounds/background-fill-zero-area-crash.html: Added.
- 3:53 PM Changeset in webkit [57376] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix after addition of LayoutTestController method.
- 3:50 PM Changeset in webkit [57375] by
-
- 3 edits in trunk/WebKit2
Fix for https://bugs.webkit.org/show_bug.cgi?id=37351
Cannot build with build-webkit --webkit2
Reviewed by Darin Adler.
Add some headers that it seems others are not getting
already.
- Platform/mac/WorkQueueMac.cpp: #inlude <mach/mach_port.h>
- Shared/mac/UpdateChunk.cpp: #inlude <mach/vm_map.h>
- 3:46 PM Changeset in webkit [57374] by
-
- 1 edit29 adds in trunk/WebKitTools
Fix for https://bugs.webkit.org/show_bug.cgi?id=37368
Add MiniBrowser.
Reviewed by Anders Carlsson.
- MiniBrowser: Added.
- MiniBrowser/MiniBrowser.vcproj: Added.
- MiniBrowser/MiniBrowser.xcodeproj: Added.
- MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added.
- MiniBrowser/mac: Added.
- MiniBrowser/mac/AppDelegate.h: Added.
- MiniBrowser/mac/AppDelegate.m: Added.
- MiniBrowser/mac/BrowserWindowController.h: Added.
- MiniBrowser/mac/BrowserWindowController.m: Added.
- MiniBrowser/mac/English.lproj: Added.
- MiniBrowser/mac/English.lproj/BrowserWindow.xib: Added.
- MiniBrowser/mac/English.lproj/InfoPlist.strings: Added.
- MiniBrowser/mac/English.lproj/MainMenu.xib: Added.
- MiniBrowser/mac/MiniBrowser-Info.plist: Added.
- MiniBrowser/mac/MiniBrowser_Prefix.pch: Added.
- MiniBrowser/mac/main.m: Added.
- MiniBrowser/win: Added.
- MiniBrowser/win/BrowserView.cpp: Added.
- MiniBrowser/win/BrowserView.h: Added.
- MiniBrowser/win/BrowserWindow.cpp: Added.
- MiniBrowser/win/BrowserWindow.h: Added.
- MiniBrowser/win/MiniBrowser.cpp: Added.
- MiniBrowser/win/MiniBrowser.h: Added.
- MiniBrowser/win/MiniBrowser.rc: Added.
- MiniBrowser/win/Resources: Added.
- MiniBrowser/win/main.cpp: Added.
- MiniBrowser/win/resource.h: Added.
- MiniBrowser/win/stdafx.cpp: Added.
- MiniBrowser/win/stdafx.h: Added.
- 3:33 PM Changeset in webkit [57373] by
-
- 16 edits3 copies2 adds2 deletes in trunk
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=24572
XMLHttpRequest.statusText returns always "OK" on Mac
Covered by existing tests, which now pass.
- WebCore.base.exp:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm: Added a WebKitSystemInterface method to fetch status line.
- platform/network/HTTPParsers.cpp: (WebCore::extractReasonPhraseFromHTTPStatusLine):
- platform/network/HTTPParsers.h:
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit): Moved code for parsing status line to HTTPHeaders, as it's used for both Mac and CF now.
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Use the actual reason phrase when available, and "OK" otherwise. Synthesizing a reson when there isn't one is misleading, so we'll stick to our old broken behavior on Tiger, rather than introduce a new broken one.
- 3:19 PM Changeset in webkit [57372] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling back the last two changes. The failing tests
are a Chromium problem, not a WebKit one.
- platform/chromium/test_expectations.txt:
- 3:14 PM Changeset in webkit [57371] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=37361, clean up FillLayer.
Reviewed by Oliver Hunt.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- rendering/style/FillLayer.h:
(WebCore::FillLayer::sizeType):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::backgroundImage):
(WebCore::InheritedFlags::backgroundRepeatX):
(WebCore::InheritedFlags::backgroundRepeatY):
(WebCore::InheritedFlags::backgroundComposite):
(WebCore::InheritedFlags::backgroundAttachment):
(WebCore::InheritedFlags::backgroundClip):
(WebCore::InheritedFlags::backgroundOrigin):
(WebCore::InheritedFlags::backgroundXPosition):
(WebCore::InheritedFlags::backgroundYPosition):
(WebCore::InheritedFlags::backgroundSizeType):
(WebCore::InheritedFlags::backgroundSizeLength):
(WebCore::InheritedFlags::maskImage):
(WebCore::InheritedFlags::maskRepeatX):
(WebCore::InheritedFlags::maskRepeatY):
(WebCore::InheritedFlags::maskComposite):
(WebCore::InheritedFlags::maskAttachment):
(WebCore::InheritedFlags::maskClip):
(WebCore::InheritedFlags::maskOrigin):
(WebCore::InheritedFlags::maskXPosition):
(WebCore::InheritedFlags::maskYPosition):
(WebCore::InheritedFlags::maskSizeType):
(WebCore::InheritedFlags::maskSizeLength):
- 3:05 PM Changeset in webkit [57370] by
-
- 2 edits in tags/Safari-533.4.1/WebKit/win
Merge r57336.
- 2:59 PM Changeset in webkit [57369] by
-
- 4 edits in tags/Safari-533.4.1
Versioning.
- 2:40 PM Changeset in webkit [57368] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, adding a TIMEOUT expectations for worker-simple.html
on Linux.
https://bugs.webkit.org/show_bug.cgi?id=37274
- platform/chromium/test_expectations.txt:
- 2:36 PM Changeset in webkit [57367] by
-
- 4 edits in trunk/WebKit2
More build fixes.
- WebProcess/win/WebProcessMain.h:
Include windows.h here.
- win/WebKit2.def:
Add new exports.
- win/WebKit2.vcproj:
Add new files.
- 2:36 PM Changeset in webkit [57366] by
-
- 1 copy in tags/Safari-533.4.1
New tag.
- 2:20 PM Changeset in webkit [57365] by
-
- 2 edits in trunk/WebCore
Add another missing export to fix the build.
- WebCore.base.exp:
- 2:19 PM Changeset in webkit [57364] by
-
- 2 edits in trunk/WebKit2
Add new WKString.h and WKURL.h headers to top
level include.
Reviewed by Anders Carlsson.
- UIProcess/API/C/WebKit2.h:
- 2:10 PM Changeset in webkit [57363] by
-
- 4 edits in trunk/WebKit2
More Windows build fixes.
- Shared/NotImplemented.h:
- UIProcess/API/C/cf/WKURLCF.cpp:
Fix typo.
(WKURLCreateWithCFURL):
- UIProcess/API/C/cf/WKURLCF.h:
Ditto.
- win/WebKit2Generated.make:
Copy the new CF headers.
- 2:06 PM Changeset in webkit [57362] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skipping a test on Linux in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=37359
- platform/chromium/test_expectations.txt:
- 2:01 PM Changeset in webkit [57361] by
-
- 4 edits in trunk/WebKitTools
2010-04-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch attached my patch to the wrong bug
https://bugs.webkit.org/show_bug.cgi?id=37015
The problem here is that SVN was violating SCM's implicit
contract of always returning paths relative to the repository root.
That can easily be fixed by telling SVN that the CWD is the repository root.
When fixing this I realized there are a large number of places in SCM.py where
we want to consider explicitly passing self.checkout_root as the CWD.
That would allow scm methods to be executed even when the CWD is not inside
the scm tree at all, and would also make sure (in the case of SVN) that paths
returned are relative to the root. Git (almost always) returns paths relative
to the repository root.
- Scripts/webkitpy/common/checkout/scm.py:
- Explicitly pass self.checkout_root as cwd in run_status_and_extract_filenames
- Add a ton of FIXMEs about the need to go back and decide which methods require cwd=self.checkout_root and which do not. We'll probably add a helper function to scm (likely SCM._run) which always passes cwd=self.checkout_root to Executive.run_command
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Add a test for this change.
- Scripts/webkitpy/tool/commands/upload.py:
- Removed the explicit os.chdir to the repository root, since scm.py methods should be robust against the cwd not being equal to the root.
- 1:51 PM Changeset in webkit [57360] by
-
- 3 edits in trunk/WebKit2
Two more #include sorting issues.
Reviewed by Anders Carlsson.
- Shared/NotImplemented.h:
- WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:
- 1:49 PM Changeset in webkit [57359] by
-
- 37 edits in trunk/WebKit2
Fix minor style nits found by the style-script.
Reviewed by Anders Carlsson.
- Platform/CoreIPC/ArgumentDecoder.h:
- Platform/CoreIPC/ArgumentEncoder.cpp:
- Platform/CoreIPC/Attachment.cpp:
- Platform/CoreIPC/Connection.cpp:
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/mac/ConnectionMac.cpp:
- Platform/CoreIPC/win/ConnectionWin.cpp:
- Platform/WorkQueue.h:
- Platform/mac/WorkQueueMac.cpp:
- Platform/win/RunLoopWin.cpp:
- Shared/KURLWrapper.h:
- Shared/WebCoreTypeArgumentMarshalling.h:
- Shared/mac/UpdateChunk.cpp:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/WKURL.cpp:
- UIProcess/Launcher/win/WebProcessLauncher.cpp:
- UIProcess/ResponsivenessTimer.cpp:
- UIProcess/WebLoaderClient.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPolicyClient.cpp:
- UIProcess/WebUIClient.cpp:
- UIProcess/win/DrawingAreaProxy.cpp:
- UIProcess/win/WebView.cpp:
- WebProcess/Launching/win/WebProcessWinMain.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.h:
- WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp:
- WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
- WebProcess/WebProcess.h:
- WebProcess/win/WebLocalizableStrings.cpp:
- WebProcess/win/WebLocalizableStrings.h:
- WebProcess/win/WebProcessMain.cpp:
- 1:44 PM Changeset in webkit [57358] by
-
- 5 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=37353, clean up cursors used by RenderStyles.
Reviewed by Adam Roben.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
- rendering/style/CursorData.h:
(WebCore::CursorData::CursorData):
(WebCore::CursorData::operator==):
(WebCore::CursorData::image):
(WebCore::CursorData::hotSpot):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::addCursor):
- 1:40 PM Changeset in webkit [57357] by
-
- 2 edits in trunk/WebKit/qt
2010-04-09 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Holger Freyther.
Removing the use of topLevelWidget of QWidget class since it is deprecated/obsolete
since Qt 4.5. window() method is being used instead now.
See http://doc.trolltech.com/4.5/qwidget-obsolete.html#topLevelWidget for more info.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::windowRect): (WebCore::ChromeClientQt::show): (WebCore::ChromeClientQt::windowResizerRect):
- 1:35 PM Changeset in webkit [57356] by
-
- 2 edits in trunk/WebKit2
Fix Windows build.
- Shared/NotImplemented.h:
Include stdio.h.
- 1:21 PM Changeset in webkit [57355] by
-
- 11 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=37349, RenderStyle cleanup. Working from the outside in to
bring some style consistency to RenderStyle and its associated classes. This patch cleans up the
border and outline classes.
Reviewed by Adam Roben.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::calcBorderLeft):
(WebCore::RenderTable::calcBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):
- rendering/RenderTableCell.cpp:
(WebCore::compareBorders):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcOuterBorderTop):
(WebCore::RenderTableSection::calcOuterBorderBottom):
(WebCore::RenderTableSection::calcOuterBorderLeft):
(WebCore::RenderTableSection::calcOuterBorderRight):
- rendering/style/BorderData.h:
(WebCore::BorderData::hasBorder):
(WebCore::BorderData::hasBorderRadius):
(WebCore::BorderData::borderLeftWidth):
(WebCore::BorderData::borderRightWidth):
(WebCore::BorderData::borderTopWidth):
(WebCore::BorderData::borderBottomWidth):
(WebCore::BorderData::operator==):
(WebCore::BorderData::left):
(WebCore::BorderData::right):
(WebCore::BorderData::top):
(WebCore::BorderData::bottom):
(WebCore::BorderData::image):
(WebCore::BorderData::topLeft):
(WebCore::BorderData::topRight):
(WebCore::BorderData::bottomLeft):
(WebCore::BorderData::bottomRight):
- rendering/style/BorderValue.h:
(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::nonZero):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::color):
(WebCore::BorderValue::width):
(WebCore::BorderValue::style):
- rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::width):
(WebCore::CollapsedBorderValue::style):
(WebCore::CollapsedBorderValue::exists):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::isTransparent):
(WebCore::CollapsedBorderValue::precedence):
(WebCore::CollapsedBorderValue::operator==):
- rendering/style/OutlineValue.h:
(WebCore::OutlineValue::OutlineValue):
(WebCore::OutlineValue::operator==):
(WebCore::OutlineValue::offset):
(WebCore::OutlineValue::isAuto):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getBorderRadiiForRect):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::borderLeft):
(WebCore::InheritedFlags::borderRight):
(WebCore::InheritedFlags::borderTop):
(WebCore::InheritedFlags::borderBottom):
(WebCore::InheritedFlags::borderImage):
(WebCore::InheritedFlags::borderTopLeftRadius):
(WebCore::InheritedFlags::borderTopRightRadius):
(WebCore::InheritedFlags::borderBottomLeftRadius):
(WebCore::InheritedFlags::borderBottomRightRadius):
(WebCore::InheritedFlags::borderLeftStyle):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderLeftIsTransparent):
(WebCore::InheritedFlags::borderRightStyle):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderRightIsTransparent):
(WebCore::InheritedFlags::borderTopStyle):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderTopIsTransparent):
(WebCore::InheritedFlags::borderBottomStyle):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::borderBottomIsTransparent):
(WebCore::InheritedFlags::outlineWidth):
(WebCore::InheritedFlags::outlineStyleIsAuto):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::outlineOffset):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::resetBorderTop):
(WebCore::InheritedFlags::resetBorderRight):
(WebCore::InheritedFlags::resetBorderBottom):
(WebCore::InheritedFlags::resetBorderLeft):
(WebCore::InheritedFlags::resetBorderImage):
(WebCore::InheritedFlags::resetBorderTopLeftRadius):
(WebCore::InheritedFlags::resetBorderTopRightRadius):
(WebCore::InheritedFlags::resetBorderBottomLeftRadius):
(WebCore::InheritedFlags::resetBorderBottomRightRadius):
(WebCore::InheritedFlags::setBorderImage):
(WebCore::InheritedFlags::setBorderTopLeftRadius):
(WebCore::InheritedFlags::setBorderTopRightRadius):
(WebCore::InheritedFlags::setBorderBottomLeftRadius):
(WebCore::InheritedFlags::setBorderBottomRightRadius):
(WebCore::InheritedFlags::setBorderLeftWidth):
(WebCore::InheritedFlags::setBorderLeftStyle):
(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightWidth):
(WebCore::InheritedFlags::setBorderRightStyle):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopWidth):
(WebCore::InheritedFlags::setBorderTopStyle):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomWidth):
(WebCore::InheritedFlags::setBorderBottomStyle):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineWidth):
(WebCore::InheritedFlags::setOutlineStyle):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setOutlineOffset):
(WebCore::InheritedFlags::setColumnRuleColor):
(WebCore::InheritedFlags::setColumnRuleWidth):
- rendering/style/StyleMultiColData.h:
(WebCore::StyleMultiColData::ruleWidth):
- 1:20 PM Changeset in webkit [57354] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-09 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Make CallIdentifier constructor to handle null urls.
- profiler/CallIdentifier.h: (JSC::CallIdentifier::CallIdentifier):
- 1:10 PM Changeset in webkit [57353] by
-
- 1 edit in trunk/WebKit2/ChangeLog
Add some missing URLs to ChangeLogs.
- 1:08 PM Changeset in webkit [57352] by
-
- 21 edits10 adds in trunk/WebKit2
Fix for https://bugs.webkit.org/show_bug.cgi?id=37347
Don't use CF types in the new C API
Reviewed by Anders Carlsson.
Replace all uses of CF types in the C API.
- Replace CFStringRef with WKStringRef.
- Replace CFURLRef with WKURLRef.
- WebKit2.xcodeproj/project.pbxproj: Add new files.
- Shared/KURLWrapper.h: Added. RefCounted wrapper around KURL.
- UIProcess/API/C/WKAPICast.h: Add new conversions.
- UIProcess/API/C/WKBase.h: Add new types.
- UIProcess/API/C/WKFrame.cpp:
- UIProcess/API/C/WKFrame.h:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/WKPage.h:
Replace uses of CF types with WK equivalents.
- UIProcess/API/C/WKString.cpp: Added.
- UIProcess/API/C/WKString.h: Added.
Represents a WebCore::StringImpl*.
- UIProcess/API/C/WKURL.cpp: Added.
- UIProcess/API/C/WKURL.h: Added.
Represents a WebKit::KURLWrapper*.
- UIProcess/API/C/cf: Added.
- UIProcess/API/C/cf/WKStringCF.cpp: Added.
- UIProcess/API/C/cf/WKStringCF.h: Added.
- UIProcess/API/C/cf/WKURLCF.cpp: Added.
- UIProcess/API/C/cf/WKURLCF.h: Added.
CoreFoundation conversion files. Allows converting
WKStringRef <-> CFStringRef
WKURLRef <-> CFURLRef
- UIProcess/ScriptReturnValueCallback.cpp:
(WebKit::ScriptReturnValueCallback::performCallbackWithReturnValue):
- UIProcess/ScriptReturnValueCallback.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):
- UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::processDidExit):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::urlAtProcessExit):
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):
- UIProcess/WebPolicyClient.h:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::runJavaScriptAlert):
- UIProcess/WebUIClient.h:
Don't use CF types internally at all.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::frameLoaderDestroyed):
Fix typo.
- 1:01 PM Changeset in webkit [57351] by
-
- 6 edits in trunk
2010-04-09 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Darin Adler.
Changed expectation for text status for HTTP status of 4xx following
a fix for localized status messages.
https://bugs.webkit.org/show_bug.cgi?id=37274
- platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt:
- platform/mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt:
2010-04-09 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Darin Adler.
Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText()
to return meaningful values.
https://bugs.webkit.org/show_bug.cgi?id=37274
- platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::platformLazyInit):
- platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
- 12:50 PM Changeset in webkit [57350] by
-
- 13 edits in trunk
2010-04-09 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Move the IDB::open ExceptionCode paramter to be last
https://bugs.webkit.org/show_bug.cgi?id=37277
Move the ExceptionCode paramter to the last position in
IndexedDatabaseRequest::open and friends. It should definitely
go after the callbacks to keep the parameters that come directly
from javascript together. And having output parameters appear
last is done often in the code base, so it makes sense to push
it past the Frame* param as well.
No functional change.
- bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: (WebCore::V8IndexedDatabaseRequest::openCallback):
- storage/IndexedDatabase.h:
- storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
- storage/IndexedDatabaseImpl.h:
- storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
- storage/IndexedDatabaseRequest.h:
2010-04-09 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Move the IDB::open ExceptionCode paramter to be last
https://bugs.webkit.org/show_bug.cgi?id=37277
Move the ExceptionCode paramter to the last position in
IndexedDatabaseRequest::open and friends. It should definitely
go after the callbacks to keep the parameters that come directly
from javascript together. And having output parameters appear
last is done often in the code base, so it makes sense to push
it past the Frame* param as well.
- public/WebIndexedDatabase.h:
- src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
- src/IndexedDatabaseProxy.h:
- src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
- src/WebIndexedDatabaseImpl.h:
- 12:29 PM Changeset in webkit [57349] by
-
- 12 edits2 adds in trunk
WebCore: WorkerGlobalScope.close() should let the currently running script complete execution, then terminate the worker.
https://bugs.webkit.org/show_bug.cgi?id=37053
Reviewed by Darin Adler.
WebCore:
Test: fast/workers/worker-close-more.html
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::forbidExecution):
- bindings/v8/WorkerScriptController.h:
(WebCore::WorkerScriptController::):
Added option parameter to forbidExecution (both JCS and V8 versions) that specifies whether currently running
script should be immediately terminated or left executed until the end.
- bindings/js/WorkerScriptController.h:
(WebCore::WorkerScriptController::workerContextWrapper):
This method now can return 0 instead of context if the further execution of JS is forbidden. Since any JS execution requires
fetching JS global object first, returning 0 here is a good way to prevent re-entry into JS once worker started termination.
V8 version does similar thing already in WorkerScriptController::proxy().
- workers/DedicatedWorkerContext.cpp:
(WebCore::DedicatedWorkerContext::postMessage):
Removed check that immediately disables postMessage from WorkerContext after close().
- workers/WorkerContext.cpp:
(WebCore::CloseWorkerContextTask::create):
(WebCore::CloseWorkerContextTask::performTask):
(WebCore::CloseWorkerContextTask::isCleanupTask):
(WebCore::WorkerContext::close):
Use new forbidExecution(LetRunningScriptFinish) to avoid termination of script until it executes and exits.
Post a task to actually terminate the worker once the currently executing JS fragment exits.
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):
Use new forbidExecution(TerminateRunningScript) to immediately terminate the JS.
LayoutTests:
- fast/workers/resources/worker-close.js:
- fast/workers/worker-close-expected.txt:
Updated tests to expect the script fragment that includes close() to run to completion.
- fast/workers/worker-close-more-expected.txt: Added.
- fast/workers/worker-close-more.html: Added.
- fast/workers/worker-close.html:
Added test to check terminate() after close() and close() in the case of multiple MessagePort messages dispatching.
- 12:10 PM Changeset in webkit [57348] by
-
- 2 edits in trunk/WebKit/mac
2010-04-09 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r57343.
http://trac.webkit.org/changeset/57343
https://bugs.webkit.org/show_bug.cgi?id=37311
Broke Tiger compile.
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]):
- 11:56 AM Changeset in webkit [57347] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/7846015> REGRESSION (r57332) - Crash in [WebDynamicScrollBarsView(WebInternal) reflectScrolledClipView:] when opening the Downloads window
Reviewed by Darin Adler.
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView initWithCoder:]): Added. Calls super and then initializes _private.
- 11:03 AM Changeset in webkit [57346] by
-
- 6 edits13 adds in trunk
Implement interactive validation for forms.
https://bugs.webkit.org/show_bug.cgi?id=34930
Reviewed by Darin Adler.
WebCore:
- HTMLFormControlElement::checkValidity() supports unhandled invalid control list
- HTMLFormElement::validateInteractively() called from prepareSubmit() prevents the submission if neither noValidate nor formNoValidate is specified, and focuses on the first invalid control of which "invalid" event is not canceled.
Tests: fast/forms/checkValidity-cancel.html
fast/forms/interactive-validation-cancel.html
fast/forms/interactive-validation-formnovalidate.html
fast/forms/interactive-validation-novalidate.html
fast/forms/interactive-validation-prevented.html
fast/forms/interactive-validation-remove-node-in-handler.html
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::checkValidity):
If the control is invalid and the "invalid" is not canceled,
push the control to the specified vector.
- html/HTMLFormControlElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
The main part of the interactive validation.
(WebCore::HTMLFormElement::prepareSubmit):
Calls validateInteractively().
(WebCore::HTMLFormElement::checkValidity):
Uses collectUnhandledInvalidControls().
(WebCore::HTMLFormElement::collectUnhandledInvalidControls):
- html/HTMLFormElement.h:
LayoutTests:
Add tests for "invalid" event and interactive validation.
- fast/forms/checkValidity-cancel-expected.txt: Added.
- fast/forms/checkValidity-cancel.html: Added.
- fast/forms/interactive-validation-cancel-expected.txt: Added.
- fast/forms/interactive-validation-cancel.html: Added.
- fast/forms/interactive-validation-formnovalidate-expected.txt: Added.
- fast/forms/interactive-validation-formnovalidate.html: Added.
- fast/forms/interactive-validation-novalidate-expected.txt: Added.
- fast/forms/interactive-validation-novalidate.html: Added.
- fast/forms/interactive-validation-prevented-expected.txt: Added.
- fast/forms/interactive-validation-prevented.html: Added.
- fast/forms/interactive-validation-remove-node-in-handler-expected.txt: Added.
- fast/forms/interactive-validation-remove-node-in-handler.html: Added.
- fast/forms/script-tests/checkValidity-cancel.js: Added.
- 10:45 AM Changeset in webkit [57345] by
-
- 2 edits in trunk/LayoutTests
2010-04-09 Gustavo Noronha Silva <Gustavo Noronha Silva>
[GTK+] media/video-src-invalid-remove.html
https://bugs.webkit.org/show_bug.cgi?id=37344
Skip test that is failing constantly but apparently without reason
on the 64 bits release bot.
- platform/gtk/Skipped:
- 10:04 AM Changeset in webkit [57344] by
-
- 2 edits in trunk/WebCore
Fix the mac WebKit2 build.
- WebCore.base.exp:
- 9:53 AM Changeset in webkit [57343] by
-
- 2 edits in trunk/WebKit/mac
2010-04-09 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]):
- 9:49 AM Changeset in webkit [57342] by
-
- 1 edit107 adds in trunk/LayoutTests
[Qt] Add expected results for passing new tests. Compared to the Mac png-s and expected files these
platform dependent results only differ from Mac resulst in font metrics and svg implementation.
Rubber-stamped by Simon Hausmann.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu>
- platform/qt/editing/deleting/non-smart-delete-expected.checksum: Added.
- platform/qt/editing/deleting/non-smart-delete-expected.png: Added.
- platform/qt/editing/deleting/non-smart-delete-expected.txt: Added.
- platform/qt/fast/css/first-letter-first-line-hover-expected.checksum: Added.
- platform/qt/fast/css/first-letter-first-line-hover-expected.png: Added.
- platform/qt/fast/css/first-letter-first-line-hover-expected.txt: Added.
- platform/qt/fast/forms/basic-selects-expected.checksum: Added.
- platform/qt/fast/forms/basic-selects-expected.png: Added.
- platform/qt/fast/forms/basic-selects-expected.txt: Added.
- platform/qt/fast/repaint/moving-shadow-on-container-expected.checksum: Added.
- platform/qt/fast/repaint/moving-shadow-on-container-expected.png: Added.
- platform/qt/fast/repaint/moving-shadow-on-container-expected.txt: Added.
- platform/qt/fast/repaint/moving-shadow-on-path-expected.checksum: Added.
- platform/qt/fast/repaint/moving-shadow-on-path-expected.png: Added.
- platform/qt/fast/repaint/moving-shadow-on-path-expected.txt: Added.
- platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
- platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
- platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
- platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum: Added.
- platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
- platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
- platform/qt/fast/repaint/stacked-diacritics-expected.checksum: Added.
- platform/qt/fast/repaint/stacked-diacritics-expected.png: Added.
- platform/qt/fast/repaint/stacked-diacritics-expected.txt: Added.
- platform/qt/fast/ruby: Added.
- platform/qt/fast/ruby/ruby-inline-table-expected.checksum: Added.
- platform/qt/fast/ruby/ruby-inline-table-expected.png: Added.
- platform/qt/fast/ruby/ruby-inline-table-expected.txt: Added.
- platform/qt/fast/runin/generated2-expected.checksum: Added.
- platform/qt/fast/runin/generated2-expected.png: Added.
- platform/qt/fast/runin/generated2-expected.txt: Added.
- platform/qt/fast/runin/generated3-expected.checksum: Added.
- platform/qt/fast/runin/generated3-expected.png: Added.
- platform/qt/fast/runin/generated3-expected.txt: Added.
- platform/qt/fast/runin/generated4-expected.checksum: Added.
- platform/qt/fast/runin/generated4-expected.png: Added.
- platform/qt/fast/runin/generated4-expected.txt: Added.
- platform/qt/fast/text/international/hebrew-vowels-expected.checksum: Added.
- platform/qt/fast/text/international/hebrew-vowels-expected.png: Added.
- platform/qt/fast/text/international/hebrew-vowels-expected.txt: Added.
- platform/qt/svg/custom/mask-invalidation-expected.checksum: Added.
- platform/qt/svg/custom/mask-invalidation-expected.png: Added.
- platform/qt/svg/custom/mask-invalidation-expected.txt: Added.
- platform/qt/svg/custom/pattern-excessive-malloc-expected.checksum: Added.
- platform/qt/svg/custom/pattern-excessive-malloc-expected.png: Added.
- platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Added.
- platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.checksum: Added.
- platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
- platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.
- platform/qt/svg/custom/pattern-skew-transformed-expected.checksum: Added.
- platform/qt/svg/custom/pattern-skew-transformed-expected.png: Added.
- platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Added.
- platform/qt/svg/custom/stroke-width-large-expected.checksum: Added.
- platform/qt/svg/custom/stroke-width-large-expected.png: Added.
- platform/qt/svg/custom/stroke-width-large-expected.txt: Added.
- platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
- platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
- platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt: Added.
- platform/qt/svg/filters/filter-on-tspan-expected.checksum: Added.
- platform/qt/svg/filters/filter-on-tspan-expected.png: Added.
- platform/qt/svg/filters/filter-on-tspan-expected.txt: Added.
- platform/qt/svg/overflow: Added.
- platform/qt/svg/overflow/overflow-on-foreignObject-expected.checksum: Added.
- platform/qt/svg/overflow/overflow-on-foreignObject-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt: Added.
- platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.checksum: Added.
- platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Added.
- platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.checksum: Added.
- platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.txt: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.checksum: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.checksum: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.checksum: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.checksum: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.checksum: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.checksum: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.checksum: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.checksum: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.checksum: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Added.
- platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
- platform/qt/svg/text/selection-doubleclick-expected.checksum: Added.
- platform/qt/svg/text/selection-doubleclick-expected.png: Added.
- platform/qt/svg/text/selection-doubleclick-expected.txt: Added.
- platform/qt/svg/text/selection-styles-expected.checksum: Added.
- platform/qt/svg/text/selection-styles-expected.png: Added.
- platform/qt/svg/text/selection-styles-expected.txt: Added.
- platform/qt/svg/text/selection-tripleclick-expected.checksum: Added.
- platform/qt/svg/text/selection-tripleclick-expected.png: Added.
- platform/qt/svg/text/selection-tripleclick-expected.txt: Added.
- 9:38 AM Changeset in webkit [57341] by
-
- 4 edits in trunk/WebKit/chromium
2010-04-09 Jochen Eisinger <jochen@chromium.org>
Reviewed by Darin Fisher.
Complete move of createApplicationCacheHost from WebKitClient to WebFrameClient.
https://bugs.webkit.org/show_bug.cgi?id=37330
- public/WebApplicationCacheHost.h:
- public/WebKitClient.h:
- src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
- 9:35 AM Changeset in webkit [57340] by
-
- 4 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37181
<rdar://problem/7835374> REGRESSION (r54400): Hangs when doing AJAX update with large amount of data
Test: fast/events/gc-freeze-with-attribute-listeners.html
The problem was that we were creating JS wrappers for nodes with attribute event listeners,
and GC is very slow if there are nodes with wrappers in a detached tree whose root does not
have a wrapper.
- bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Don't create wrappers for attribute event listeners - if there is a node, JSLazyEventListener::initializeJSFunction() will create one.
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Added a FIXME about the problem we are stepping around now.
- 8:56 AM Changeset in webkit [57339] by
-
- 4 edits8 adds in trunk
Make :visited tests added in r57292 not assert on Windows and GTK builds
Fixes <http://webkit.org/b/37333>.
Reviewed by Anders Carlsson.
WebKitTools:
Don't return 0 as a JSValueRef
That is an illegal use of the JSC API.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::computedStyleIncludingVisitedInfo):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::computedStyleIncludingVisitedInfo):
Return an "undefined" JSValueRef instead of 0.
LayoutTests:
Add Windows- and GTK-specific results for new :visited tests
These platforms haven't yet implemented the new LayoutTestController
API these tests require. Implementing the API is tracked by
<http://webkit.org/b/37336> and <http://webkit.org/b/37337>.
- platform/gtk/fast/history/nested-visited-test-expected.txt: Added.
- platform/gtk/fast/history/self-is-visited-expected.txt: Added.
- platform/gtk/fast/history/sibling-visited-test-expected.txt: Added.
- platform/win/fast/history/nested-visited-test-expected.txt: Added.
- platform/win/fast/history/self-is-visited-expected.txt: Added.
- platform/win/fast/history/sibling-visited-test-expected.txt: Added.
- 7:25 AM QtWebKitBackportingFixes edited by
- (diff)
- 7:01 AM Changeset in webkit [57338] by
-
- 2 edits in trunk/WebCore
2010-04-09 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
WebGtk GLib-CRITICAL Segmentation fault
https://bugs.webkit.org/show_bug.cgi?id=34937
Do not crash if a plugin does not return anything in
NP_GetMIMEDescription. This can happen, and other ports gracefully
handle the situation.
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
- 6:44 AM Changeset in webkit [57337] by
-
- 4 edits in trunk/WebCore
2010-04-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Cannot select elements within iframes with the magnifying glass.
- inspector/InspectorController.cpp: (WebCore::InspectorController::inspect): (WebCore::InspectorController::handleMousePress):
- inspector/InspectorController.h:
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
- 6:40 AM Changeset in webkit [57336] by
-
- 2 edits in trunk/WebKit/win
Windows Debug/Release build fix after r57244
- WebKit.vcproj/WebKit.vcproj: Don't delay-load QuartzCore.dll or
QuartzCoreInterface.dll in any configurations. r57244 made this change
only for Debug_Internal.
- 6:14 AM QtWebKitJournal edited by
- (diff)
- 6:13 AM Changeset in webkit [57335] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-09 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Crash on WebKit::WebGeolocationServiceBridgeImpl::stopUpdating() during frame disconnection
Should not try to access WebViewClient if the frame has already been disconnected.
https://bugs.webkit.org/show_bug.cgi?id=37318
- src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
- 6:03 AM Changeset in webkit [57334] by
-
- 4 edits in trunk/WebCore
2010-04-09 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Simon Hausmann.
[Qt]Fix compile error with QT_NO_PROPERTIES
https://bugs.webkit.org/show_bug.cgi?id=36526
Disable dynamic properties when QT_NO_PROPERTIES is defined.
- bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fieldNamed):
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getPropertyNames): (JSC::Bindings::QtField::name): (JSC::Bindings::QtField::valueFromInstance): (JSC::Bindings::QtField::setValueToInstance):
- bridge/qt/qt_runtime.h: (JSC::Bindings::QtField::):
- 5:47 AM QtWebKitJournal edited by
- (diff)
- 5:15 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:14 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:12 AM Changeset in webkit [57333] by
-
- 2 edits in trunk/WebCore
[Qt] Symbian apps crash on exit due to a bad qObject_cast.
Patch by David Leong <david.leong@nokia.com> on 2010-04-09
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=37303
Added check for NULL to avoid the crash.
- plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::platformDestroy):
- 5:03 AM Changeset in webkit [57332] by
-
- 3 edits in trunk/WebKit/mac
<rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]
[ Re-landing of r57329 with the requisite memset added in -initWithFrame: so that the tests keep working. ]
Reviewed by John Sullivan.
In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
size and layout of their subclasses is baked in at compile time. This results in instances
being allocated that are smaller than the new code expects, and may result in the new instance
variables sharing the same memory space as any instance variables that the subclass defines.
We can avoid this problem by having the class contain only a single member that acts as a pointer
to a heap-allocated structure that acts as storage for the real instance variables. This makes
us free to add instance variables in the future without risk of changing the size of the class.
To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
are able to run against older versions of WebKit we pad the class out to its previous size. This
results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
with both versions of the code.
This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
instance variables of its superclass. However, this is a private header and no known subclasses
of WebDynamicScrollBarsView access superclass instance variables in this fashion.
- WebView/WebDynamicScrollBarsView.h:
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView initWithFrame:]):
(-[WebDynamicScrollBarsView dealloc]):
(-[WebDynamicScrollBarsView finalize]):
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
(-[WebDynamicScrollBarsView contentViewFrame]):
(-[WebDynamicScrollBarsView tile]):
(-[WebDynamicScrollBarsView setSuppressLayout:]):
(-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
(-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
(-[WebDynamicScrollBarsView horizontalScrollingMode]):
(-[WebDynamicScrollBarsView verticalScrollingMode]):
(-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
(-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setScrollingModesLocked:]):
(-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
(-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
(-[WebDynamicScrollBarsView scrollWheel:]):
- 4:55 AM Changeset in webkit [57331] by
-
- 2 edits in trunk
Unreviewed crash fix.
Revert part of 57320 that would remove NDEBUG in release builds for
DRT, etc.
- WebKit.pri:
- 4:55 AM Changeset in webkit [57330] by
-
- 3 edits in trunk/WebKit/mac
Roll out r57329 since the bots are seeing lots of failures that I wasn't seeing locally.
- 4:51 AM WebKit2 edited by
- (diff)
- 4:47 AM WebKit2 edited by
- (diff)
- 4:44 AM Changeset in webkit [57329] by
-
- 3 edits in trunk/WebKit/mac
<rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]
Reviewed by John Sullivan.
In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
size and layout of their subclasses is baked in at compile time. This results in instances
being allocated that are smaller than the new code expects, and may result in the new instance
variables sharing the same memory space as any instance variables that the subclass defines.
We can avoid this problem by having the class contain only a single member that acts as a pointer
to a heap-allocated structure that acts as storage for the real instance variables. This makes
us free to add instance variables in the future without risk of changing the size of the class.
To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
are able to run against older versions of WebKit we pad the class out to its previous size. This
results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
with both versions of the code.
This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
instance variables of its superclass. However, this is a private header and no known subclasses
of WebDynamicScrollBarsView access superclass instance variables in this fashion.
- WebView/WebDynamicScrollBarsView.h:
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView initWithFrame:]):
(-[WebDynamicScrollBarsView dealloc]):
(-[WebDynamicScrollBarsView finalize]):
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
(-[WebDynamicScrollBarsView contentViewFrame]):
(-[WebDynamicScrollBarsView tile]):
(-[WebDynamicScrollBarsView setSuppressLayout:]):
(-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
(-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
(-[WebDynamicScrollBarsView horizontalScrollingMode]):
(-[WebDynamicScrollBarsView verticalScrollingMode]):
(-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
(-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setScrollingModesLocked:]):
(-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
(-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
(-[WebDynamicScrollBarsView scrollWheel:]):
- 4:42 AM WebKit2 edited by
- (diff)
- 4:30 AM Changeset in webkit [57328] by
-
- 4 edits in trunk/WebKitTools
Make DumpRenderTree parallelizable
https://bugs.webkit.org/show_bug.cgi?id=36899
Reviewed by Eric Seidel.
- DumpRenderTree/mac/DumpRenderTree.mm:
(libraryPathForDumpRenderTree): Use DUMPRENDERTREE_TEMP if exist.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree): Use DUMPRENDERTREE_TEMP if exist.
- Scripts/run-webkit-tests:
- Create a unique temporary directory and pass its path to DumpRenderTree with DUMPRENDERTREE_TEMP environment variable.
- 4:26 AM WebKit2 edited by
- (diff)
- 4:14 AM WebKit2 edited by
- (diff)
- 4:13 AM WebKit2 edited by
- (diff)
- 3:55 AM Changeset in webkit [57327] by
-
- 6 edits in trunk/WebKit/qt
2010-04-09 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix compile error with QT_NO_ACTION
https://bugs.webkit.org/show_bug.cgi?id=36529
Make sure QT_NO_ACTION is not defined to use QAction
- Api/qgraphicswebview.cpp: (QGraphicsWebView::pageAction):
- Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPage::updatePositionDependentActions):
- Api/qwebpage.h:
- Api/qwebview.cpp:
- Api/qwebview.h:
- 3:53 AM Changeset in webkit [57326] by
-
- 3 edits1 add in trunk
<http://webkit.org/b/37326> IDL files are being copied in to the WebCore framework again
Reviewed by Oliver Hunt.
WebCore:
- WebCore.xcodeproj/project.pbxproj: Wire up the script. Remove the three inappropriate
files from the Copy Bundle Resources build phase.
WebKitTools:
Add a script to detect the presence of inappropriate files in the frameworks. At present
it only looks for .css, .idl and .in files in the top level of WebCore.framework/Resources,
as these are the only cases we've encountered recently. It can be extended to check the
other frameworks or for other inappropriate files in the future.
- Scripts/check-for-inappropriate-files-in-framework: Added.
- 3:46 AM Changeset in webkit [57325] by
-
- 3 edits in trunk/WebKit/chromium
2010-04-09 Jochen Eisinger <jochen@chromium.org>
Reviewed by Adam Barth.
Expose SecurityOrigin::canRequest in WebSecurityOrigin.
https://bugs.webkit.org/show_bug.cgi?id=37271
- public/WebSecurityOrigin.h:
- src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::canRequest):
- 3:37 AM Changeset in webkit [57324] by
-
- 8 edits in trunk
2010-04-09 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Passing null WebGLObjects should synthesize INVALID_VALUE error
https://bugs.webkit.org/show_bug.cgi?id=37047
- fast/canvas/webgl/error-reporting-expected.txt: Change a few errors from INVALID_OPERATION to INVALID_VALUE.
- fast/canvas/webgl/getActiveTest-expected.txt: Ditto.
- fast/canvas/webgl/null-object-behaviour-expected.txt: Ditto.
- fast/canvas/webgl/script-tests/error-reporting.js: Ditto.
2010-04-09 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Passing null WebGLObjects should synthesize INVALID_VALUE error
https://bugs.webkit.org/show_bug.cgi?id=37047
- html/canvas/WebGLRenderingContext.cpp: Synthesize INVALID_VALUE error when input object is 0. (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::validateWebGLObject): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::shaderSource):
- html/canvas/WebGLRenderingContext.h: Add helper function to validate webgl object input parameters.
- 3:10 AM Changeset in webkit [57323] by
-
- 2 edits in trunk/WebKit/qt
[Qt] tests/qgraphicswebview fails
https://bugs.webkit.org/show_bug.cgi?id=37317
Reviewed by Lars Knoll.
- Api/qwebpage.cpp:
(QWebPage::userAgentForUrl): Don't crash if the ownerWidget is null.
- 3:06 AM Changeset in webkit [57322] by
-
- 6 edits2 adds in trunk
2010-04-09 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=37174
- fast/canvas/webgl/copy-tex-image-and-sub-image-2d-expected.txt: Added.
- fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html: Added.
- fast/canvas/webgl/resources/utils3d.js: Add ContextAttributes parameter to initWebGL function.
2010-04-09 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=37174
Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html
- platform/graphics/mac/GraphicsContext3DMac.cpp: resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D. (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D):
2010-04-09 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=37174
Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html
- src/WebGraphicsContext3DDefaultImpl.cpp: Resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D. (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D):
- 3:00 AM ApplicationsGtk edited by
- (diff)
- 2:48 AM Changeset in webkit [57321] by
-
- 3 edits in trunk/WebCore
2010-04-09 Evan Stade <estade@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] <select> dropdowns don't die when an item is selected
https://bugs.webkit.org/show_bug.cgi?id=37243
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::hidePopup): (WebCore::PopupContainer::notifyPopupHidden): (WebCore::PopupListBox::hidePopup): inform container that popup is closing
- platform/chromium/PopupMenuChromium.h:
- 2:03 AM Changeset in webkit [57320] by
-
- 6 edits in trunk
[Qt] Fix crashes with package builds in release
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-04-09
Reviewed by Simon Hausmann.
.:
- WebKit.pri: Don't randomly add NDEBUG to the defines.
Add NDEBUG to the defines for package build in JavaScriptCore.pri,
so that it's consistently used for JavaScriptCore, WebCore, jsc and all
other tools using wtf, etc. data structures directly. Mixing NDEBUG with
non-NDEBUG builds causes crashes due to differences in data structures when
assertions/checks are enabled.
- JavaScriptCore.pri:
WebCore:
- WebCore.pro: Don't add NDEBUG to the defines here, add it from JavaScriptCore.pri
- 1:59 AM Changeset in webkit [57319] by
-
- 5 edits in trunk
2010-04-09 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Fraser.
Update test as the 'all' value has been removed
- fast/media/media-feature-wgt-view-mode.html:
2010-04-09 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Fraser.
Remove "all" value from the view-mode media feature (as agreed on
1-Apr-2010) in the Widgets voice conf.
- css/CSSValueKeywords.in:
- css/MediaQueryEvaluator.cpp: (WebCore::view_modeMediaFeatureEval):
- 1:36 AM Changeset in webkit [57318] by
-
- 4 edits in trunk/JavaScriptCore
2010-04-09 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Implement NO_RETURN for COMPILER(MSVC).
https://bugs.webkit.org/show_bug.cgi?id=33056
Added NO_RETURN_WITH_VALUE for functions with non-void return type.
- jsc.cpp:
- wtf/AlwaysInline.h:
- wtf/FastMalloc.cpp:
- 1:21 AM WebKit2 edited by
- (diff)
- 1:20 AM QtWebKitRelease20 edited by
- (diff)
- 1:15 AM Changeset in webkit [57317] by
-
- 4 edits in trunk/WebCore
2010-04-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57286.
http://trac.webkit.org/changeset/57286
https://bugs.webkit.org/show_bug.cgi?id=37312
"Caused intermittent test failures on all Mac bots."
(Requested by eseidel on #webkit).
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::originQuotaManagerNoLock): (WebCore::DatabaseTracker::originQuotaManager): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::getMaxSizeForDatabase): (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::addOpenDatabase): (WebCore::DatabaseTracker::removeOpenDatabase): (WebCore::DatabaseTracker::usageForOriginNoLock): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): (WebCore::DatabaseTracker::deleteOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile):
- storage/DatabaseTracker.h:
- storage/SQLTransactionClient.cpp: (WebCore::SQLTransactionClient::didExecuteStatement):
- 1:06 AM WebKit2 edited by
- (diff)
- 12:59 AM Changeset in webkit [57316] by
-
- 7 edits in trunk
[Qt] User agent style sheets are crippled by moc -E in make-css-file-arrays.pl
https://bugs.webkit.org/show_bug.cgi?id=37296
Reviewed by Simon Hausmann.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu>
WebCore:
Do not use moc to preprocess user agent style sheets because it removes at-symbols
and hexadecimal colours from declarations.
Remove unneeded preprocessor usage from make-css-file-arrays.pl since the script
processes default css files using regular expressions therefore preprocessing is redundant.
- WebCore.pri: remove --preprocessor usage
- css/make-css-file-arrays.pl: remove gcc dependency
LayoutTests:
Update expected files after removal of moc preprocessing of default css sheets.
These test results now only differ in metrics from Mac ones.
- platform/qt/editing/execCommand/insert-list-xml-expected.txt:
- platform/qt/svg/custom/createImageElement2-expected.txt:
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- 12:58 AM WebKit2 edited by
- (diff)
- 12:35 AM Changeset in webkit [57315] by
-
- 5 edits in trunk
Versioning.
- 12:33 AM Changeset in webkit [57314] by
-
- 1 copy in tags/Safari-533.4
New tag.
Apr 8, 2010:
- 11:43 PM Changeset in webkit [57313] by
-
- 8 edits2 adds in trunk
2010-04-08 Chris Evans <cevans@chromium.org>
Reviewed by Sam Weinig.
Add test for POST & _blank popup blocker bypass.
https://bugs.webkit.org/show_bug.cgi?id=34541
- fast/events/popup-blocked-to-post-blank.html: added
- fast/events/popup-blocked-to-post-blank-expected.txt: added
2010-04-08 Chris Evans <cevans@chromium.org>
Reviewed by Sam Weinig.
Use the new UserGestureIndictor for _blank POST requests.
Test: fast/events/popup-blocked-to-post-blank.html
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): Use UserGestureIndicator in more cases.
- page/EventHandler.cpp: (WebCore::EventHandler): Impact from UserGestureIndicator API change. (WebCore::FrameLoader::submitForm): Block the load immediately if popups are not allowed and it would open a new window.
- loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): Note the UserGestureIndicator status at the time of submission. (WebCore::ScheduledFormSubmission::fire): Use the stored UserGestureIndicator status in the asynchronous callback.
- dom/UserGestureIndicator.h:
- dom/UserGestureIndicator.cpp: (WebCore::UserGestureIndicator::UserGestureIndicator): Add ability to store a negative indication.
- 6:14 PM Changeset in webkit [57312] by
-
- 2 edits in trunk/WebKitTools
Add option to build WebKit2 to build-webkit.
Reviewed by Darin Adler.
- Scripts/build-webkit:
- 5:52 PM Changeset in webkit [57311] by
-
- 1 edit23 adds in trunk/WebKit2
Add build support for WebKit2.
Reviewed by Anders Carlsson.
- Configurations: Added.
- Configurations/Base.xcconfig: Added.
- Configurations/DebugRelease.xcconfig: Added.
- Configurations/FeatureDefines.xcconfig: Added.
- Configurations/Version.xcconfig: Added.
- Configurations/WebKit2.xcconfig: Added.
- English.lproj: Added.
- English.lproj/InfoPlist.strings: Added.
- Info.plist: Added.
- Makefile: Added.
- WebKit2.xcodeproj: Added.
- WebKit2.xcodeproj/project.pbxproj: Added.
- WebKit2Prefix.cpp: Added.
- WebKit2Prefix.h: Added.
- WebKit2_Prefix.pch: Added.
- WebProcess-Info.plist: Added.
- version.plist: Added.
- win: Added.
- win/WebKit2.def: Added.
- win/WebKit2.vcproj: Added.
- win/WebKit2Generated.make: Added.
- win/WebKit2Generated.vcproj: Added.
- win/WebKit2WebProcess.vcproj: Added.
- 5:50 PM Changeset in webkit [57310] by
-
- 1 edit73 adds in trunk/WebKit2
Add WebKit2/UIProcess directory.
Patch by Anders Carlsson <andersca@apple.com> on 2010-04-08
Reviewed by Sam Weinig.
- UIProcess: Added.
- UIProcess/API: Added.
- UIProcess/API/C: Added.
- UIProcess/API/C/WKAPICast.h: Added.
- UIProcess/API/C/WKBase.h: Added.
- UIProcess/API/C/WKContext.cpp: Added.
- UIProcess/API/C/WKContext.h: Added.
- UIProcess/API/C/WKFrame.cpp: Added.
- UIProcess/API/C/WKFrame.h: Added.
- UIProcess/API/C/WKFramePolicyListener.cpp: Added.
- UIProcess/API/C/WKFramePolicyListener.h: Added.
- UIProcess/API/C/WKPage.cpp: Added.
- UIProcess/API/C/WKPage.h: Added.
- UIProcess/API/C/WKPageNamespace.cpp: Added.
- UIProcess/API/C/WKPageNamespace.h: Added.
- UIProcess/API/C/WKPreferences.cpp: Added.
- UIProcess/API/C/WKPreferences.h: Added.
- UIProcess/API/C/WebKit2.h: Added.
- UIProcess/API/mac: Added.
- UIProcess/API/mac/PageClientImpl.h: Added.
- UIProcess/API/mac/PageClientImpl.mm: Added.
- UIProcess/API/mac/WKView.h: Added.
- UIProcess/API/mac/WKView.mm: Added.
- UIProcess/API/mac/WKViewInternal.h: Added.
- UIProcess/API/win: Added.
- UIProcess/API/win/WKAPICastWin.h: Added.
- UIProcess/API/win/WKBaseWin.h: Added.
- UIProcess/API/win/WKView.cpp: Added.
- UIProcess/API/win/WKView.h: Added.
- UIProcess/Launcher: Added.
- UIProcess/Launcher/WebProcessLauncher.h: Added.
- UIProcess/Launcher/mac: Added.
- UIProcess/Launcher/mac/WebProcessLauncher.mm: Added.
- UIProcess/Launcher/win: Added.
- UIProcess/Launcher/win/WebProcessLauncher.cpp: Added.
- UIProcess/PageClient.h: Added.
- UIProcess/ProcessModel.h: Added.
- UIProcess/ResponsivenessTimer.cpp: Added.
- UIProcess/ResponsivenessTimer.h: Added.
- UIProcess/ScriptReturnValueCallback.cpp: Added.
- UIProcess/ScriptReturnValueCallback.h: Added.
- UIProcess/WebContext.cpp: Added.
- UIProcess/WebContext.h: Added.
- UIProcess/WebFramePolicyListenerProxy.cpp: Added.
- UIProcess/WebFramePolicyListenerProxy.h: Added.
- UIProcess/WebFrameProxy.cpp: Added.
- UIProcess/WebFrameProxy.h: Added.
- UIProcess/WebLoaderClient.cpp: Added.
- UIProcess/WebLoaderClient.h: Added.
- UIProcess/WebPageNamespace.cpp: Added.
- UIProcess/WebPageNamespace.h: Added.
- UIProcess/WebPageProxy.cpp: Added.
- UIProcess/WebPageProxy.h: Added.
- UIProcess/WebPolicyClient.cpp: Added.
- UIProcess/WebPolicyClient.h: Added.
- UIProcess/WebPreferences.cpp: Added.
- UIProcess/WebPreferences.h: Added.
- UIProcess/WebProcessManager.cpp: Added.
- UIProcess/WebProcessManager.h: Added.
- UIProcess/WebProcessProxy.cpp: Added.
- UIProcess/WebProcessProxy.h: Added.
- UIProcess/WebUIClient.cpp: Added.
- UIProcess/WebUIClient.h: Added.
- UIProcess/mac: Added.
- UIProcess/mac/DrawingAreaProxy.h: Added.
- UIProcess/mac/DrawingAreaProxy.mm: Added.
- UIProcess/mac/DrawingAreaProxyUpdateChunk.h: Added.
- UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: Added.
- UIProcess/win: Added.
- UIProcess/win/DrawingAreaProxy.cpp: Added.
- UIProcess/win/DrawingAreaProxy.h: Added.
- UIProcess/win/WebView.cpp: Added.
- UIProcess/win/WebView.h: Added.
- 5:49 PM Changeset in webkit [57309] by
-
- 1 edit50 adds in trunk/WebKit2
Add WebKit2/WebProcess directory.
Patch by Anders Carlsson <andersca@apple.com> on 2010-04-08
Reviewed by Sam Weinig and Oliver Hunt.
- WebProcess: Added.
- WebProcess/Launching: Added.
- WebProcess/Launching/mac: Added.
- WebProcess/Launching/mac/WebProcessMain.mm: Added.
- WebProcess/Launching/win: Added.
- WebProcess/Launching/win/WebProcessWinMain.cpp: Added.
- WebProcess/WebCoreSupport: Added.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: Added.
- WebProcess/WebCoreSupport/WebChromeClient.h: Added.
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp: Added.
- WebProcess/WebCoreSupport/WebContextMenuClient.h: Added.
- WebProcess/WebCoreSupport/WebDragClient.cpp: Added.
- WebProcess/WebCoreSupport/WebDragClient.h: Added.
- WebProcess/WebCoreSupport/WebEditorClient.cpp: Added.
- WebProcess/WebCoreSupport/WebEditorClient.h: Added.
- WebProcess/WebCoreSupport/WebErrors.h: Added.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: Added.
- WebProcess/WebCoreSupport/WebInspectorClient.h: Added.
- WebProcess/WebCoreSupport/mac: Added.
- WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: Added.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.h: Added.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.m: Added.
- WebProcess/WebCoreSupport/win: Added.
- WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp: Added.
- WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: Added.
- WebProcess/WebPage: Added.
- WebProcess/WebPage/DrawingArea.cpp: Added.
- WebProcess/WebPage/DrawingArea.h: Added.
- WebProcess/WebPage/WebFrame.cpp: Added.
- WebProcess/WebPage/WebFrame.h: Added.
- WebProcess/WebPage/WebPage.cpp: Added.
- WebProcess/WebPage/WebPage.h: Added.
- WebProcess/WebPage/mac: Added.
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: Added.
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h: Added.
- WebProcess/WebPage/mac/WebPageMac.mm: Added.
- WebProcess/WebPage/win: Added.
- WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp: Added.
- WebProcess/WebPage/win/DrawingAreaUpdateChunk.h: Added.
- WebProcess/WebPage/win/WebPageWin.cpp: Added.
- WebProcess/WebProcess.cpp: Added.
- WebProcess/WebProcess.h: Added.
- WebProcess/win: Added.
- WebProcess/win/DllMain.cpp: Added.
- WebProcess/win/WebLocalizableStrings.cpp: Added.
- WebProcess/win/WebLocalizableStrings.h: Added.
- WebProcess/win/WebProcessMain.cpp: Added.
- WebProcess/win/WebProcessMain.h: Added.
- 5:47 PM Changeset in webkit [57308] by
-
- 1 edit24 adds in trunk/WebKit2
Add WebKit2/Shared directory.
Reviewed by Anders Carlsson.
- Shared: Added.
- Shared/CoreIPCSupport: Added.
- Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Added.
- Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Added.
- Shared/CoreIPCSupport/WebPageMessageKinds.h: Added.
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added.
- Shared/CoreIPCSupport/WebProcessMessageKinds.h: Added.
- Shared/NotImplemented.h: Added.
- Shared/WebCoreTypeArgumentMarshalling.h: Added.
- Shared/WebEvent.h: Added.
- Shared/WebEventConversion.cpp: Added.
- Shared/WebEventConversion.h: Added.
- Shared/WebPreferencesStore.cpp: Added.
- Shared/WebPreferencesStore.h: Added.
- Shared/mac: Added.
- Shared/mac/UpdateChunk.cpp: Added.
- Shared/mac/UpdateChunk.h: Added.
- Shared/mac/WebEventFactory.h: Added.
- Shared/mac/WebEventFactory.mm: Added.
- Shared/win: Added.
- Shared/win/UpdateChunk.cpp: Added.
- Shared/win/UpdateChunk.h: Added.
- Shared/win/WebEventFactory.cpp: Added.
- Shared/win/WebEventFactory.h: Added.
- 5:46 PM Changeset in webkit [57307] by
-
- 1 edit29 adds in trunk/WebKit2
Add WebKit2/Platform directory.
Reviewed by Anders Carlsson.
- Platform: Added.
- Platform/CoreIPC: Added.
- Platform/CoreIPC/ArgumentDecoder.cpp: Added.
- Platform/CoreIPC/ArgumentDecoder.h: Added.
- Platform/CoreIPC/ArgumentEncoder.cpp: Added.
- Platform/CoreIPC/ArgumentEncoder.h: Added.
- Platform/CoreIPC/Arguments.h: Added.
- Platform/CoreIPC/Attachment.cpp: Added.
- Platform/CoreIPC/Attachment.h: Added.
- Platform/CoreIPC/Connection.cpp: Added.
- Platform/CoreIPC/Connection.h: Added.
- Platform/CoreIPC/MessageID.h: Added.
- Platform/CoreIPC/mac: Added.
- Platform/CoreIPC/mac/ConnectionMac.cpp: Added.
- Platform/CoreIPC/mac/MachPort.h: Added.
- Platform/CoreIPC/win: Added.
- Platform/CoreIPC/win/ConnectionWin.cpp: Added.
- Platform/PlatformProcessIdentifier.h: Added.
- Platform/RunLoop.cpp: Added.
- Platform/RunLoop.h: Added.
- Platform/WorkItem.h: Added.
- Platform/WorkQueue.cpp: Added.
- Platform/WorkQueue.h: Added.
- Platform/mac: Added.
- Platform/mac/RunLoopMac.mm: Added.
- Platform/mac/WorkQueueMac.cpp: Added.
- Platform/win: Added.
- Platform/win/RunLoopWin.cpp: Added.
- 5:37 PM Changeset in webkit [57306] by
-
- 2 edits in trunk/WebKitTools
run-webkit-tests should respect argument order
https://bugs.webkit.org/show_bug.cgi?id=37257
Reviewed by Alexey Proskuryakov.
- Scripts/run-webkit-tests: Changed so that sorting is done only
on the results of iterating directories. Test order is based on
what's passed on the command line. Removed code that aimed to
eliminate duplicates since it can be useful to run the same test
more than once.
- 4:31 PM Changeset in webkit [57305] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[Chromium] Mark failing tests after r57292
https://bugs.webkit.org/show_bug.cgi?id=37298
- platform/chromium/test_expectations.txt:
- 4:24 PM Changeset in webkit [57304] by
-
- 3 edits2 adds in trunk
Spatial Navigation: proper handle negative x or y coordinates https://bugs.webkit.org/show_bug.cgi?id=36773
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
WebCore:
In Spatial Navigation logic, during rect acquisition in renderRectRelativeToRootDocument,
sometimes negative x() or y() values are got, and the current algorithm bails out in
any of such cases.
However, when a node is in a scrollable content (content overflow <div>) and
this scrollable container scrolled up, element gets offscreen, and gets negative values
for y(), for example. In such cases, they are still valid to be used in Spatial Navigation
logic.
Test: fast/events/spatial-navigation/snav-offscreen-content.html
- page/SpatialNavigation.cpp:
(WebCore::distanceDataForNode):
(WebCore::checkNegativeCoordsForNode):
LayoutTests:
- fast/events/spatial-navigation/snav-offscreen-content-expected.txt: Added.
- fast/events/spatial-navigation/snav-offscreen-content.html: Added.
- 4:07 PM Changeset in webkit [57303] by
-
- 2 edits in trunk/LayoutTests
[Qt] r57274 removed fast/forms/willvalidate-000.html,
so it should be removed from Skipped list too.
- platform/qt/Skipped: fast/forms/willvalidate-000.html removed.
- 3:59 PM Changeset in webkit [57302] by
-
- 2 edits in trunk/WebKit/win
WebView::isLoading should null check m_mainFrame
https://bugs.webkit.org/show_bug.cgi?id=37294
Reviewed by Darin Adler.
- WebView.cpp:
(WebView::isLoading):
- 3:55 PM Changeset in webkit [57301] by
-
- 5 edits in trunk
WebCore: Create the creation callback is the current world.
https://bugs.webkit.org/show_bug.cgi?id=37290
Reviewed by Geoffrey Garen.
- bindings/js/JSDatabaseCallback.cpp:
(WebCore::JSDatabaseCallback::JSDatabaseCallback):
LayoutTests: Test that the creation callback is executed in the world where it
was created.
https://bugs.webkit.org/show_bug.cgi?id=37290
Reviewed by Geoffrey Garen.
- storage/open-database-creation-callback-isolated-world-expected.txt:
- storage/open-database-creation-callback-isolated-world.html:
- 3:39 PM Changeset in webkit [57300] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip new tests introduced in r57292, because of unimplemented
layoutTestController.computedStyleIncludingVisitedInfo()
- platform/qt/Skipped:
- fast/history/nested-visited-test.html skipped.
- fast/history/self-is-visited.html skipped.
- fast/history/sibling-visited-test.html skipped.
- 3:37 PM Changeset in webkit [57299] by
-
- 5 edits in trunk/WebCore
Followup optimization to bug 24300, don't leak history info via CSS :visited. If a Web
site uses document colors that are the same for link and vlink in HTML and also doesn't
specify any :link or :visited rules, then don't waste time resolving visited styles.
Reviewed by Oliver Hunt.
There is a further optimization that could be done to detect when :link and :visited are
used together in the same rule to specify a color, and this is how most sites turn off
visited link colors, but this fix doesn't address that. It just restores the optimization
that existed prior to the patch in 24300 landing.
- css/CSSGrammar.y:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore::Document::usesLinkRules):
(WebCore::Document::setUsesLinkRules):
- 3:36 PM WebKit2 edited by
- (diff)
- 3:18 PM Changeset in webkit [57298] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-04-08 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Another trial
Tests that should have been landed as part of the earlier patch for Bug 36276.
https://bugs.webkit.org/show_bug.cgi?id=36276
- fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
- fast/css/invalid-not-with-simple-selector-sequence.html: Added.
- 3:18 PM WebKit2 created by
- Initial chech-in.
- 3:17 PM Changeset in webkit [57297] by
-
- 2 edits in trunk/WebCore
Caught by pixel tests. I missed patching the borderRightColor() call for fieldset border painting so the
border stopped showing up.
Reviewed by Oliver Hunt.
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBorderMinusLegend):
- 3:16 PM WikiStart edited by
- Add link to WebKit2 design doc (diff)
- 3:09 PM Changeset in webkit [57296] by
-
- 2 adds in trunk/WebKit2
Rubber-stamped by Mark Rowe.
Add WebKit2 directory.
- 3:05 PM Changeset in webkit [57295] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
2010-04-08 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Tests that should have been landed as part of the earlier patch for Bug 36276.
https://bugs.webkit.org/show_bug.cgi?id=36276
- fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
- fast/css/invalid-not-with-simple-selector-sequence.html: Added.
- 3:02 PM Changeset in webkit [57294] by
-
- 1 edit in trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
Fix Qt build.
- 2:48 PM Changeset in webkit [57293] by
-
- 22 edits1 delete in trunk/LayoutTests
2010-04-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799
I missed the linux-only results in http://trac.webkit.org/changeset/57291
- platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
- platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
- platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
- 2:29 PM Changeset in webkit [57292] by
-
- 44 edits7 adds3 deletes in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=24300, don't leak history info via CSS :visited.
Reviewed by Oliver Hunt.
This patch implements the policy described by David Baron here:
http://dbaron.org/mozilla/visited-privacy
Added new tests in fast/history.
- WebCore.base.exp:
Expose functions needed for the WebKit SPI used by layout tests.
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isVisited):
Make sure accessibility objects still return visited information.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSComputedStyleDeclaration.h:
(WebCore::computedStyle):
Add a boolean to computed style declarations that - if set - causes the computed style
to still return :visited information. For normal Web pages, this will be false. It is set
to true for the Web Inspector and by the WebKit SPI used by the layout tests.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::keyframeStylesForAnimation):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyPropertyToStyle):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
- css/CSSStyleSelector.h:
Rework the style selector to resolve two styles instead of one. The first forces the link to
be unvisited, and the second forces the link to be visited. The real state of the link is
cached on the principal (unvisited) style. The visited style hangs off the principal style
as a pseudo style (VISITED_LINK).
- dom/Element.cpp:
(WebCore::Element::pseudoStyleCacheIsInvalid):
Make sure to deal with the VISITED_LINK pseudo to know when only :visited style info changed.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getStyles):
Let the Web Inspector see :visited computed styles by default.
- platform/LinkHash.cpp:
(WebCore::visitedURL):
Fix an issue where <a href=""> is not hashed properly to the document's base URI, so it wasn't
correctly reported as :visited.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintTextDecorations):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintObject):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBorderMinusLegend):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintFocusRings):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::drawArcForBoxSide):
(WebCore::RenderObject::paintOutline):
(WebCore::decorationColor):
(WebCore::RenderObject::getTextDecorationColors):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp:
(WebCore::RenderPath::paint):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
- rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
- rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paint):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::collapsedLeftBorder):
(WebCore::RenderTableCell::collapsedRightBorder):
(WebCore::RenderTableCell::collapsedTopBorder):
(WebCore::RenderTableCell::collapsedBottomBorder):
(WebCore::RenderTableCell::paintCollapsedBorder):
- rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::operator==):
Patch painting code to fetch visitedDependentColors from the RenderStyle. Properties that
are honored include background-color, color, border colors, outline color, column rules,
and fill and stroke (both SVG and our custom versions).
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):
(WebCore::borderStyleForColorProperty):
(WebCore::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):
- rendering/style/RenderStyle.h:
(WebCore::):
(WebCore::InheritedFlags::NonInheritedFlags::operator==):
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::insideLink):
(WebCore::InheritedFlags::isLink):
(WebCore::InheritedFlags::setInsideLink):
(WebCore::InheritedFlags::setIsLink):
- rendering/style/RenderStyleConstants.h:
Change how link information is stored. The noninherited flags now have a bit set for if you're a link
or not. The inherited flags now cache whether you're inside a visited or unvisited link (or no link at
all).
(WebCore::):
- svg/graphics/SVGPaintServer.cpp:
(WebCore::SVGPaintServer::fillPaintServer):
(WebCore::SVGPaintServer::strokePaintServer):
Patch SVG fill/stroke painting to honor :visited.
WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS
Reviewed by Oliver Hunt.
Add SPI so that layout tests can access computed style including :visited information.
- WebView/WebRenderNode.mm:
(copyRenderNode):
- WebView/WebView.mm:
(-[WebView _computedStyleIncludingVisitedInfo:forElement:]):
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS. Add a new method for
obtaining computed style with :visited info included. This allows layout tests to actually tell that
:visited is in effect.
Reviewed by Oliver Hunt.
- DumpRenderTree/LayoutTestController.cpp:
(computedStyleIncludingVisitedInfoCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::computedStyleIncludingVisitedInfo):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS
Reviewed by Oliver Hunt.
- fast/history/clicked-link-is-visited.html: Removed.
- fast/history/nested-visited-test-expected.txt: Added.
- fast/history/nested-visited-test.html: Added.
- fast/history/resources/dummy.html: Added.
- fast/history/self-is-visited-expected.txt: Added.
- fast/history/self-is-visited.html: Added.
- fast/history/sibling-visited-test-expected.txt: Added.
- fast/history/sibling-visited-test.html: Added.
- fast/history/subframe-is-visited-expected.txt: Removed.
- fast/history/subframe-is-visited.html: Removed.
- 2:09 PM Changeset in webkit [57291] by
-
- 33 edits4 deletes in trunk/LayoutTests
2010-04-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Daniel Bates.
[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799
Adds new results for all the tests that started failing after http://trac.webkit.org/changeset/57287.
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Removed.
- platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
- platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
- 1:47 PM Changeset in webkit [57290] by
-
- 3 edits in trunk/WebKitTools
2010-04-07 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix trunk (non-standalone) builds for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37136
Test for source files before building instead of relying on
standalone_package config.
- WebKit.pro:
- 12:46 PM Changeset in webkit [57289] by
-
- 1 edit51 deletes in trunk/LayoutTests
2010-04-08 Daniel Bates <dbates@rim.com>
No review, rolling out 56717.
http://trac.webkit.org/changeset/56717
https://bugs.webkit.org/show_bug.cgi?id=9268
Rolling out the change committed in change set 56717
since we rolled out the change committed in change set 56655,
<http://trac.webkit.org/changeset/56655> (in change set 57287,
<http://trac.webkit.org/changeset/57287>). The change committed
in change set 56655 caused a layout test regression of the some
of the mozilla- and mozilla expected failure- tests. See bug #9268
for more details.
- platform/qt/fast/table/table-background-expected.checksum: Removed.
- platform/qt/fast/table/table-background-expected.png: Removed.
- platform/qt/fast/table/table-background-expected.txt: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Removed.
- platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Removed.
- platform/qt/fast/table/table-cell-overrides-row-background-expected.checksum: Removed.
- platform/qt/fast/table/table-cell-overrides-row-background-expected.png: Removed.
- platform/qt/fast/table/table-cell-overrides-row-background-expected.txt: Removed.
- platform/qt/fast/table/table-col-background-expected.checksum: Removed.
- platform/qt/fast/table/table-col-background-expected.png: Removed.
- platform/qt/fast/table/table-col-background-expected.txt: Removed.
- platform/qt/fast/table/table-col-group-background-expected.checksum: Removed.
- platform/qt/fast/table/table-col-group-background-expected.png: Removed.
- platform/qt/fast/table/table-col-group-background-expected.txt: Removed.
- platform/qt/fast/table/table-col-group-col-span-background-expected.checksum: Removed.
- platform/qt/fast/table/table-col-group-col-span-background-expected.png: Removed.
- platform/qt/fast/table/table-col-group-col-span-background-expected.txt: Removed.
- platform/qt/fast/table/table-col-group-span-background-expected.checksum: Removed.
- platform/qt/fast/table/table-col-group-span-background-expected.png: Removed.
- platform/qt/fast/table/table-col-group-span-background-expected.txt: Removed.
- platform/qt/fast/table/table-col-span-background-expected.checksum: Removed.
- platform/qt/fast/table/table-col-span-background-expected.png: Removed.
- platform/qt/fast/table/table-col-span-background-expected.txt: Removed.
- platform/qt/fast/table/table-row-background-expected.checksum: Removed.
- platform/qt/fast/table/table-row-background-expected.png: Removed.
- platform/qt/fast/table/table-row-background-expected.txt: Removed.
- platform/qt/fast/table/table-row-background-left-50px-expected.checksum: Removed.
- platform/qt/fast/table/table-row-background-left-50px-expected.png: Removed.
- platform/qt/fast/table/table-row-background-left-50px-expected.txt: Removed.
- platform/qt/fast/table/table-row-background-right-100percent-expected.checksum: Removed.
- platform/qt/fast/table/table-row-background-right-100percent-expected.png: Removed.
- platform/qt/fast/table/table-row-background-right-100percent-expected.txt: Removed.
- platform/qt/fast/table/table-row-background-right-50px-expected.checksum: Removed.
- platform/qt/fast/table/table-row-background-right-50px-expected.png: Removed.
- platform/qt/fast/table/table-row-background-right-50px-expected.txt: Removed.
- platform/qt/fast/table/table-row-group-background-expected.checksum: Removed.
- platform/qt/fast/table/table-row-group-background-expected.png: Removed.
- platform/qt/fast/table/table-row-group-background-expected.txt: Removed.
- platform/qt/fast/table/table-row-group-background-positioned-expected.checksum: Removed.
- platform/qt/fast/table/table-row-group-background-positioned-expected.png: Removed.
- platform/qt/fast/table/table-row-group-background-positioned-expected.txt: Removed.
- 12:42 PM Changeset in webkit [57288] by
-
- 2 edits in trunk/WebCore
2010-04-08 Benjamin Otte <otte@gnome.org>
Reviewed by Gustavo Noronha.
Fix build with MathML enabled.
- GNUmakefile.am:
- 12:21 PM Changeset in webkit [57287] by
-
- 7 edits68 deletes in trunk
2010-04-08 Daniel Bates <dbates@rim.com>
No review, rolling out 56655.
http://trac.webkit.org/changeset/56655
https://bugs.webkit.org/show_bug.cgi?id=9268
Rolling out the change committed in change set 56655
because it caused a regression in some of the mozilla
and mozilla expected failure test cases, such as:
tables/mozilla/marvin/backgr_simple-table-row.html, and
tables/mozilla/marvin/backgr_simple-table-row-group.html.
We need to look into this issue some more.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/RenderBoxModelObject.h:
- rendering/RenderObject.h:
- rendering/RenderTableCell.cpp:
- rendering/RenderTableCell.h:
2010-04-08 Daniel Bates <dbates@rim.com>
No review, rolling out 56655.
http://trac.webkit.org/changeset/56655
https://bugs.webkit.org/show_bug.cgi?id=9268
Rolling out the change committed in change set 56655
because it caused a regression in some of the mozilla
and mozilla expected failure test cases, such as:
tables/mozilla/marvin/backgr_simple-table-row.html, and
tables/mozilla/marvin/backgr_simple-table-row-group.html.
We need to look into this issue some more.
- fast/table/table-background.html: Removed.
- fast/table/table-cell-border-draws-on-top-of-col-background.html: Removed.
- fast/table/table-cell-border-draws-on-top-of-col-group-background.html: Removed.
- fast/table/table-cell-border-draws-on-top-of-row-background.html: Removed.
- fast/table/table-cell-border-draws-on-top-of-row-group-background.html: Removed.
- fast/table/table-cell-overrides-row-background.html: Removed.
- fast/table/table-col-background.html: Removed.
- fast/table/table-col-group-background.html: Removed.
- fast/table/table-col-group-col-span-background.html: Removed.
- fast/table/table-col-group-span-background.html: Removed.
- fast/table/table-col-span-background.html: Removed.
- fast/table/table-row-background-left-50px.html: Removed.
- fast/table/table-row-background-right-100percent.html: Removed.
- fast/table/table-row-background-right-50px.html: Removed.
- fast/table/table-row-background.html: Removed.
- fast/table/table-row-group-background-positioned.html: Removed.
- fast/table/table-row-group-background.html: Removed.
- platform/mac/fast/table/table-background-expected.checksum: Removed.
- platform/mac/fast/table/table-background-expected.png: Removed.
- platform/mac/fast/table/table-background-expected.txt: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Removed.
- platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Removed.
- platform/mac/fast/table/table-cell-overrides-row-background-expected.checksum: Removed.
- platform/mac/fast/table/table-cell-overrides-row-background-expected.png: Removed.
- platform/mac/fast/table/table-cell-overrides-row-background-expected.txt: Removed.
- platform/mac/fast/table/table-col-background-expected.checksum: Removed.
- platform/mac/fast/table/table-col-background-expected.png: Removed.
- platform/mac/fast/table/table-col-background-expected.txt: Removed.
- platform/mac/fast/table/table-col-group-background-expected.checksum: Removed.
- platform/mac/fast/table/table-col-group-background-expected.png: Removed.
- platform/mac/fast/table/table-col-group-background-expected.txt: Removed.
- platform/mac/fast/table/table-col-group-col-span-background-expected.checksum: Removed.
- platform/mac/fast/table/table-col-group-col-span-background-expected.png: Removed.
- platform/mac/fast/table/table-col-group-col-span-background-expected.txt: Removed.
- platform/mac/fast/table/table-col-group-span-background-expected.checksum: Removed.
- platform/mac/fast/table/table-col-group-span-background-expected.png: Removed.
- platform/mac/fast/table/table-col-group-span-background-expected.txt: Removed.
- platform/mac/fast/table/table-col-span-background-expected.checksum: Removed.
- platform/mac/fast/table/table-col-span-background-expected.png: Removed.
- platform/mac/fast/table/table-col-span-background-expected.txt: Removed.
- platform/mac/fast/table/table-row-background-expected.checksum: Removed.
- platform/mac/fast/table/table-row-background-expected.png: Removed.
- platform/mac/fast/table/table-row-background-expected.txt: Removed.
- platform/mac/fast/table/table-row-background-left-50px-expected.checksum: Removed.
- platform/mac/fast/table/table-row-background-left-50px-expected.png: Removed.
- platform/mac/fast/table/table-row-background-left-50px-expected.txt: Removed.
- platform/mac/fast/table/table-row-background-right-100percent-expected.checksum: Removed.
- platform/mac/fast/table/table-row-background-right-100percent-expected.png: Removed.
- platform/mac/fast/table/table-row-background-right-100percent-expected.txt: Removed.
- platform/mac/fast/table/table-row-background-right-50px-expected.checksum: Removed.
- platform/mac/fast/table/table-row-background-right-50px-expected.png: Removed.
- platform/mac/fast/table/table-row-background-right-50px-expected.txt: Removed.
- platform/mac/fast/table/table-row-group-background-expected.checksum: Removed.
- platform/mac/fast/table/table-row-group-background-expected.png: Removed.
- platform/mac/fast/table/table-row-group-background-expected.txt: Removed.
- platform/mac/fast/table/table-row-group-background-positioned-expected.checksum: Removed.
- platform/mac/fast/table/table-row-group-background-positioned-expected.png: Removed.
- platform/mac/fast/table/table-row-group-background-positioned-expected.txt: Removed.
- 11:40 AM Changeset in webkit [57286] by
-
- 4 edits in trunk/WebCore
Refactor DatabaseTracker, part 1: Remove the dependency on
OriginQuotaManager from DatabaseTracker.h.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31482
- storage/DatabaseTracker.cpp:
(originQuotaManager):
(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
- storage/DatabaseTracker.h:
- storage/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didExecuteStatement):
- 11:11 AM Changeset in webkit [57285] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Dimitri Glazkov.
A couple test expectations cleanups
https://bugs.webkit.org/show_bug.cgi?id=37285
- platform/chromium/test_expectations.txt:
- 9:57 AM BuildBot edited by
- webkit-dev is a better choice for bot discussions (diff)
- 9:35 AM Changeset in webkit [57284] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
Fix http.conf for GTK-Debug and Chromium-Linux bots
https://bugs.webkit.org/show_bug.cgi?id=37279
- http/conf/apache2-debian-httpd.conf:
- 9:23 AM Changeset in webkit [57283] by
-
- 2 edits in trunk/WebCore
2010-04-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Simon Hausmann.
[WINCE] Replace max with std::max
https://bugs.webkit.org/show_bug.cgi?id=37201
std::max is preferred.
- platform/wince/FileSystemWince.cpp: (WebCore::makeAllDirectories): (WebCore::pathGetFileName):
- 9:08 AM Changeset in webkit [57282] by
-
- 1 edit1 move1 add in trunk/WebCore
[EFL] Move AccessibilityObjectEfl.cpp from page to accessibility
https://bugs.webkit.org/show_bug.cgi?id=36405
Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>
- accessibility/efl/AccessibilityObjectEfl.cpp: Renamed from WebCore/page/efl/AccessibilityObjectEfl.cpp.
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
- 8:57 AM Changeset in webkit [57281] by
-
- 2 edits in trunk/WebKit/qt
2010-04-08 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Warnings when compiling InspectorClientQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=37266
Add a default: for the switch()-case to avoid
warnings.
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::variantToSetting):
- 8:27 AM Changeset in webkit [57280] by
-
- 14 edits in trunk
2010-04-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Render Load, DOM Content and MarkTimeline event dividers on Timeline panel.
- English.lproj/localizedStrings.js:
- inspector/InspectorController.cpp: (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent):
- inspector/InspectorController.h:
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
- inspector/InspectorTimelineAgent.h: (WebCore::):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.removeEventDividers):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._updateMarks): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition): (WebInspector.TimelineRecordGraphRow.prototype.update):
- inspector/front-end/inspector.css: (.resources-event-divider): (.resources-red-divider): (.resources-blue-divider): (.resources-orange-divider):
- 8:00 AM Changeset in webkit [57279] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Fix a test for the behavior change by r57274.
- fast/css/pseudo-invalid-novalidate-001.html:
- 7:43 AM Changeset in webkit [57278] by
-
- 7 edits in trunk/WebKitTools
2010-04-05 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Hausmann.
[Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
https://bugs.webkit.org/show_bug.cgi?id=29431
Added stubs for Mac, win, gtk and wx DRTs to implement setScrollbarPolicy method.
- DumpRenderTree/LayoutTestController.cpp: (setScrollbarPolicyCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setScrollbarPolicy):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setScrollbarPolicy):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setScrollbarPolicy):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setScrollbarPolicy):
- 7:38 AM Changeset in webkit [57277] by
-
- 19 edits2 adds in trunk
2010-04-01 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by David Hyatt.
[Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
https://bugs.webkit.org/show_bug.cgi?id=29431
Test: fast/overflow/scrollbar-restored-and-then-locked.html
WebCore:
Patch introduces a lock scrollbars concept to ScrollView, as in WebDynamicScrollBarsView.mm/h
on WebKit/mac. It is needed because in QtWebKit, we have Api for setting both vertical and
horizontal scrollbars on/off/auto. When it is set to off, for example, it should remain
as such, unless unset.
For the locking concept, optional 'lock' parameters were added to setScrollbarModes,
setHorizontalScrollbarMode and setVerticalScrollbarMode methods of ScrollView. As these
are all optional, any previous code calling them do not need modification.
Two optional parameters were also added to Frame's createView method, for horizontal and vertical
lock state persistence cross page loads.
- WebCore.base.exp:
- page/Frame.cpp: (WebCore::Frame::createView):
- platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::setScrollbarModes): (WebCore::ScrollView::setHorizontalScrollbarMode): (WebCore::ScrollView::setVerticalScrollbarMode):
- platform/ScrollView.h: (WebCore::ScrollView::setHorizontalScrollbarLock): (WebCore::ScrollView::isHorizontalScrollbarLocked): (WebCore::ScrollView::setVerticalScrollbarLock): (WebCore::ScrollView::isVerticalScrollbarLocked): (WebCore::ScrollView::setScrollingModesLocked):
WebKit/qt:
Make use of the new lock parameter of set{Vertical,Horizontal}ScrollbarMode.
Always added a qt auto test for set scrollbar policy feature.
- Api/qwebframe.cpp: (QWebFrame::setScrollBarPolicy):
- tests/qwebframe/tst_qwebframe.cpp:
- WebCoreSupport/FrameLoaderClientQt.cpp: (FrameLoaderClientQt::transitionToCommittedForNewPage):
WebKitTools:
Make possible to DRT to set scrollbar policies (on, off or auto).
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setScrollbarPolicy):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- QtLauncher/main.cpp: (LauncherWindow::toggleScrollbars): (LauncherWindow::createChrome):
LayoutTests:
- fast/overflow/scrollbar-restored-and-then-locked-expected.txt: Added.
- fast/overflow/scrollbar-restored-and-then-locked.html: Added.
- 7:29 AM QtWebKitJournal edited by
- (diff)
- 7:28 AM Changeset in webkit [57276] by
-
- 5 edits in trunk
2010-04-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Correctly save number of properties when object being serialized
have properties in its prorotype.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::ZigZag::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::ZigZag::Serializer::AbstractObjectState::advance):
2010-04-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Test that object with ptototype can be sent as message.
- fast/dom/Window/window-postmessage-clone-expected.txt:
- fast/dom/Window/window-postmessage-clone.html:
- 7:14 AM Changeset in webkit [57275] by
-
- 4 edits in trunk/WebCore
2010-04-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Yury Semikhatsky.
IDB callbacks should fire asynchronously
https://bugs.webkit.org/show_bug.cgi?id=37265
Fix the firing behavior of the callbacks to not be synchronous.
There's still a major bug that I'm trying to track down that is keeping
us from testing this stuff. Promise lots of tests ASAP.
- bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::onSuccessAsync): (WebCore::V8CustomIDBCallbacks::onErrorAsync):
- storage/IDBCallbacks.h: (WebCore::IDBCallbacks::IDBCallbacks): (WebCore::IDBCallbacks::onSuccess): (WebCore::IDBCallbacks::onError): (WebCore::IDBCallbacks::timerFired):
- storage/IndexedDatabaseRequest.cpp:
- 7:10 AM Changeset in webkit [57274] by
-
- 9 edits3 adds20 deletes in trunk
willValidate doesn't need to check existence of a form element and a name attribute.
https://bugs.webkit.org/show_bug.cgi?id=34733
Reviewed by Darin Adler.
WebCore:
Remove checks against m_form and m_hasName in
HTMLFormControlElement::willValidate(), and remove the code to
track their updates.
Test: fast/forms/willvalidate.html
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseMappedAttribute):
(WebCore::HTMLFormControlElement::insertedIntoTree):
(WebCore::HTMLFormControlElement::removedFromTree):
(WebCore::HTMLFormControlElement::recalcWillValidate):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
- html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::formDestroyed):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setInputType):
setNeedsWillValidateCheck() should be called before
setAttribute(valueAttr, ...) is called.
LayoutTests:
- Merge willvalidate-00x tests into one file.
- Update tests affected by the willValidate behavior change.
- fast/forms/input-live-pseudo-selectors-expected.txt:
- fast/forms/resources/input-live-pseudo-selectors.js:
- fast/forms/resources/textarea-live-pseudo-selectors.js:
- fast/forms/script-tests/willvalidate.js: Added.
- fast/forms/textarea-live-pseudo-selectors-expected.txt:
- fast/forms/willvalidate-000-expected.txt: Removed.
- fast/forms/willvalidate-000.html: Removed.
- fast/forms/willvalidate-001-expected.txt: Removed.
- fast/forms/willvalidate-001.html: Removed.
- fast/forms/willvalidate-002-expected.txt: Removed.
- fast/forms/willvalidate-002.html: Removed.
- fast/forms/willvalidate-003-expected.txt: Removed.
- fast/forms/willvalidate-003.html: Removed.
- fast/forms/willvalidate-004-expected.txt: Removed.
- fast/forms/willvalidate-004.html: Removed.
- fast/forms/willvalidate-005-expected.txt: Removed.
- fast/forms/willvalidate-005.html: Removed.
- fast/forms/willvalidate-006-expected.txt: Removed.
- fast/forms/willvalidate-006.html: Removed.
- fast/forms/willvalidate-007-expected.txt: Removed.
- fast/forms/willvalidate-007.html: Removed.
- fast/forms/willvalidate-008-expected.txt: Removed.
- fast/forms/willvalidate-008.html: Removed.
- fast/forms/willvalidate-009-expected.txt: Removed.
- fast/forms/willvalidate-009.html: Removed.
- fast/forms/willvalidate-expected.txt: Added.
- fast/forms/willvalidate.html: Added.
- 7:05 AM Changeset in webkit [57273] by
-
- 7 edits in trunk/WebCore
2010-04-08 Young Han Lee <joybro@company100.net>
Reviewed by Simon Hausmann.
[WINCE] Add missing headers
https://bugs.webkit.org/show_bug.cgi?id=37199
Include missing headers.
- platform/graphics/wince/FontCustomPlatformData.cpp:
- platform/graphics/wince/FontPlatformData.cpp:
- platform/graphics/wince/GraphicsContextWince.cpp:
- platform/graphics/wince/ImageBufferWince.cpp:
- platform/graphics/wince/PlatformPathWince.h:
- platform/wince/FileSystemWince.cpp:
- 6:54 AM Changeset in webkit [57272] by
-
- 3 edits in trunk/WebCore
2010-04-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Simon Hausmann.
[WINCE] Use WebCore::instanceHandle()
https://bugs.webkit.org/show_bug.cgi?id=37202
Page::instanceHandle() is moved to WebCore::instanceHandle().
- platform/wince/PasteboardWince.cpp: (WebCore::Pasteboard::Pasteboard):
- platform/wince/SharedTimerWince.cpp: (WebCore::initializeOffScreenTimerWindow):
- 6:44 AM Changeset in webkit [57271] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Simon Hausmann.
[WINCE] Check if ARM or _ARM_ is defined
https://bugs.webkit.org/show_bug.cgi?id=37200
MSVC defines ARM and _ARM_ for Windows CE ARM. Define WTF_CPU_ARM=1
when either ARM or _ARM_ is defined.
- wtf/Platform.h:
- 6:24 AM Changeset in webkit [57270] by
-
- 3 edits in trunk/WebKit/qt
2010-04-08 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] WebKit crashes while input text through input method.
The formatted text underline painting crashes when painting with invalid indexes.
https://bugs.webkit.org/show_bug.cgi?id=36870
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethodsTextFormat_data): (tst_QWebPage::inputMethodsTextFormat):
- 5:38 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:15 AM Changeset in webkit [57269] by
-
- 9 edits2 adds in trunk
2010-04-08 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Fix crash in NodeFilterCondition in detached iframe
https://bugs.webkit.org/show_bug.cgi?id=37234
Test: fast/dom/node-filter-detached-iframe-crash.html
- bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode): Switched to using callFunctionWithoutFrame.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunctionWithoutFrame): Added a function to call V8 with no current frame.
- bindings/v8/V8Proxy.h:
2010-04-08 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Fix crash in NodeFilterCondition in detached iframe
https://bugs.webkit.org/show_bug.cgi?id=37234
- fast/dom/node-filter-detached-iframe-crash-expected.txt: Added.
- fast/dom/node-filter-detached-iframe-crash.html: Added.
- 2:50 AM Changeset in webkit [57268] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Eric Seidel <eric@webkit.org>
Unreviewed. Update test_expectations to account for tests which fail
when run out of order.
fast/dom/SelectorAPI/dumpNodeList tests fail when run out of order.
https://bugs.webkit.org/show_bug.cgi?id=37259
- platform/mac/test_expectations.txt:
- 2:23 AM Changeset in webkit [57267] by
-
- 2 edits in trunk/WebCore
2010-04-08 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Simon Hausmann.
[Qt] Remove shaderSource manipulation from GraphicsContext3DQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=37226
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::shaderSource):
- 2:13 AM Changeset in webkit [57266] by
-
- 2 edits in trunk/WebKit/qt
2010-04-08 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] qtwebkit_webframe_scrollRecursively scrolls when body.style.overflow="hidden"
https://bugs.webkit.org/show_bug.cgi?id=36674
The scrolling check was based on the frameview's scrolloffset, and
maximumScrollPosition, which does not acknowledge the overflow properties.
I am now basing the scrolling off the scrollbar position. The scrollbars are
affected by the overflow properties indicating when not to scroll. The scrollbar
positions also continue to work for CSS ::-webkit-scrollbar styles.
- Api/qwebframe.cpp: (qtwebkit_webframe_scrollRecursively):
- 1:59 AM Changeset in webkit [57265] by
-
- 2 edits in trunk/WebKitTools
2010-04-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
new-run-webkit-tests should give a percent complete indication
https://bugs.webkit.org/show_bug.cgi?id=37258
Because it's awesome.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 1:26 AM Changeset in webkit [57264] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Adam Barth <abarth@webkit.org>
Unreviewed. Update test_expectations to account for some tests that
fail when run out of order.
- platform/mac/test_expectations.txt:
- 1:19 AM Changeset in webkit [57263] by
-
- 3 edits2 adds in trunk
2010-04-08 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Add test for SVG image with excessive nesting.
https://bugs.webkit.org/show_bug.cgi?id=37247
- fast/images/svg-nested.html: added
- fast/images/svg-nested-expected.txt: added
2010-04-08 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Sanity: apply a max node depth to XML parsing.
Test: fast/images/svg-nested.html
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode): Error out the parse upon a really large node depth.
- 1:16 AM Changeset in webkit [57262] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed Oliver Hunt.
[Qt]r57240 broke Qt build (might be a gcc bug)
https://bugs.webkit.org/show_bug.cgi?id=37253
Workaround until fix. On PLATFORM(QT) use inline instead of ALWAYS_INLINE.
- wtf/PassRefPtr.h: Qt guards added.
- 1:04 AM Changeset in webkit [57261] by
-
- 3 edits in trunk/LayoutTests
2010-04-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
cross-frame-access-put depends on test ordering
https://bugs.webkit.org/show_bug.cgi?id=37254
If you run the tests in a different order, the value of this property
can change. We just need to avoid printing the actual value.
- http/tests/security/cross-frame-access-put-expected.txt:
- http/tests/security/resources/cross-frame-iframe-for-put-test.html:
- 12:54 AM Changeset in webkit [57260] by
-
- 2 edits in trunk/LayoutTests
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104
Turns out the CYGWIN also uses Apache 1.3, so can't bind to ::1 either.
- http/conf/cygwin-httpd.conf:
- 12:51 AM Changeset in webkit [57259] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, cleaning up Chromium Mac test expecatations for fast/media.
- platform/chromium/test_expectations.txt:
- 12:49 AM Changeset in webkit [57258] by
-
- 2 edits in trunk/WebKitTools
2010-04-08 Adam Barth <abarth@webkit.org>
Unreviewed.
Add back the --target option because it's needed by the downstream
Chromium bots.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 12:45 AM Changeset in webkit [57257] by
-
- 4 edits in trunk/WebKitTools
2010-04-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
new-run-webkit-tests should understand set-webkit-configuration
https://bugs.webkit.org/show_bug.cgi?id=37252
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 12:27 AM Changeset in webkit [57256] by
-
- 15 edits in trunk/WebKitTools
2010-04-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename target to configuration in new-run-webkit-tests to match the rest of WebKit
https://bugs.webkit.org/show_bug.cgi?id=37251
The rest of our tools call --debug or --release the configuration.
It's confusing to call it target in this script.
- Scripts/webkitpy/layout_tests/driver_test.py:
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 12:19 AM Changeset in webkit [57255] by
-
- 2 edits in trunk/LayoutTests
2010-04-08 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, cleaning up test expectations for fast/media and media/video-played-reset.html.
Previously all of fast/media was marked as PASS FAIL, but now has finer-grained
expectations for all tests.
Due to Chromium-side changes, media/video-played-reset.html is now passing again.
- platform/chromium/test_expectations.txt:
Apr 7, 2010:
- 11:56 PM Changeset in webkit [57254] by
-
- 2 edits in trunk/WebKitTools
2010-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove depricated op.popen2 call in new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37249
Python complains that this API is depricated. We already solved this
problem in executive.py.
- Scripts/webkitpy/layout_tests/port/mac.py:
- 11:55 PM Changeset in webkit [57253] by
-
- 2 edits in trunk/WebKitTools
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
new-run-webkit-tests crashes when run on a 64-bit machine
https://bugs.webkit.org/show_bug.cgi?id=37248
- Scripts/webkitpy/layout_tests/port/mac.py:
- The code was trying to always run the 32-bit intel version of the DumpRenderTree binary. DRT does not build 32-bit on 64-bit machines so that makes no sense. This may have made sense for test_shell at some point, but I think we should just remove this for DRT.
- 11:51 PM Changeset in webkit [57252] by
-
- 2 edits in trunk/LayoutTests
2010-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
https://bugs.webkit.org/show_bug.cgi?id=37145
I think this test might be getting confused because it only expects the
end event to fire once but actually it fires again for the second
transition. Let's try this patch and see if it fixes the flakiness.
- transitions/transition-end-event-set-none.html:
- 11:40 PM QtWebKit edited by
- (diff)
- 11:13 PM Changeset in webkit [57251] by
-
- 1 edit1 add in trunk/WebKitSite
(Not reviewed.)
Random demo to look cool on twitter.
- misc/gradient-input.html: Added.
- 11:03 PM Changeset in webkit [57250] by
-
- 2 edits in trunk/LayoutTests
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Alexey Proskuryakov.
WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104
Apache 1.3 does not support IPv6, so remove the Listen [::1] directive
and add a warning about how that may cause flakiness on systems which
use Apache 1.3, but support IPv6.
- http/conf/httpd.conf:
- 10:00 PM Changeset in webkit [57249] by
-
- 9 edits in trunk
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104
WebKit Apache configs were only listening on IPv4 loopback (127.0.0.1), however
the system will resolve "localhost." to both IPv4 and IPv6 (::1) loopback
addreses when IPv6 is enabled. Since DNS lookup returns addresses in random
order, we would occasionally fail to make connections to "localhost" addresses
if the various network re-tries all happen to resolve to the IPv6 loopback.
To make matters worse, the kernel has a connection reset throttle which we
could trigger if we would repeatedly attempt to connect to ::1 and fail.
The trottle would cause a 1 or 2 second delay on the connection, sometimes
causing slow tests to time out.
I also discovered during this investigation that we have some partial support
for specifying our apache port numbers at runtime. The support is already incomplete
by not accounting for WebSockets or SSL ports. This fix will make our partial
support for dynamic apache port numbers even more broken.
I've added Listen [::1]:PORT directives for 8000, 8080, and 8443 to all
platforms (except cygwin which does not have the 8443 directive to begin with).
- http/conf/apache2-debian-httpd.conf:
- http/conf/apache2-httpd.conf:
- http/conf/cygwin-httpd.conf:
- http/conf/fedora-httpd.conf:
- http/conf/httpd.conf:
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104
Add warnings that the partial support for specifying what port numbers
apache should bind to is even more broken after this fix.
- Scripts/run-webkit-httpd:
- Scripts/run-webkit-tests:
- 9:35 PM Changeset in webkit [57248] by
-
- 2 edits in trunk/JavaScriptCore
Vector<UString> makes many needless calls to UString::UString and UString::~UString
Reviewed by Anders Carlsson.
Add a VectorTrait<UString> specialisation to allow vector to simply memset/memcpy
data around. Only difference from the VectorTrait<RefPtr<T> > traits is the inability
to use memset to initialize data.
- runtime/UString.h:
(WTF::):
- 9:12 PM Changeset in webkit [57247] by
-
- 2 edits in trunk/WebKitTools
2010-04-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
LayoutTestController::m_handlesAuthenticationChallenges isn't initialized
https://bugs.webkit.org/show_bug.cgi?id=37190
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
- 9:11 PM Changeset in webkit [57246] by
-
- 5 edits in trunk/WebKit/mac
Refactor WebHTMLView printing code and add private methods to enter and exit printing mode.
https://bugs.webkit.org/show_bug.cgi?id=37246
Reviewed by Adele Peterson.
- Misc/WebNSPrintOperationExtras.h: Declared -_web_availablePaperWidth and -_web_availablePaperHeight.
- Misc/WebNSPrintOperationExtras.m:
(-[NSPrintOperation _web_availablePaperWidth]): Turned -[WebHTMLView _availablePaperWidthForPrintOperation:]
into this method.
(-[NSPrintOperation _web_availablePaperHeight]): Turned -[WebHTMLView _calculatePrintHeight] into this
method.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _isInPrintMode]): Added this accessor.
(-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Added. Moved the code from -knowsPageRange: that
computes the layout widths and enters printing mode into this private method.
(-[WebHTMLView _endPrintMode]): New private method (the old -_endPrintMode has been renamed).
(-[WebHTMLView _scaleFactorForPrintOperation:]): Use -[NSPrintOperation _web_availablePaperWidth].
(-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Renamed -_endPrintMode to this, changed it to call
_endPrintMode.
(-[WebHTMLView _delayedEndPrintMode:]): Updated for rename.
(-[WebHTMLView knowsPageRange:]): Use -_beginPrintModeWithPageWidth:shrintToFit:,
-[NSPrintOperation _web_availablePaperWidth], and -[NSPrintOperation _web_availablePaperHeight]. Updated for
rename.
(-[WebHTMLView beginDocument]): Updated for rename.
(-[WebHTMLView endDocument]): Ditto.
- WebView/WebHTMLViewPrivate.h: Declared new private methods -_isInPrintMode,
-_beginPrintModeWithPageWidth:shrinkToFit: and -_endPrintMode.
- 6:18 PM Changeset in webkit [57245] by
-
- 9 edits in trunk/WebCore
Fix Chromium's HTML5 DB support in --single-process mode.
https://bugs.webkit.org/show_bug.cgi?id=37186.
Reviewed by Jeremy Orlow.
Always register and use Chromium's SQLite VFS for
WebSQLDatabases. Keep using the default VFS in all other
cases. This change should allow Chromium to support
WebSQLDatabases in --single-process mode.
Also, cleaning up a bit SQLiteFileSystemChromium and getting rid
of the SQLITE_OPEN_FULLMUTEX flag: we use sqlite DB handles only
on the DB thread, so we don't need multi-threaded support.
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):
- platform/sql/SQLiteDatabase.h:
- platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
- platform/sql/SQLiteFileSystem.h:
- platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
- platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
- platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
- storage/Database.cpp:
(WebCore::Database::performOpenAndVerify):
- 5:38 PM Changeset in webkit [57244] by
-
- 7 edits3 deletes in trunk
Remove QuartzCoreInterface from the build
No longer needed since QuartzCore.dll is now included in the latest Safari release (4.0.5).
- 5:32 PM Changeset in webkit [57243] by
-
- 2 edits2 deletes in trunk
2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57178.
http://trac.webkit.org/changeset/57178
https://bugs.webkit.org/show_bug.cgi?id=37240
Caused chromium browser_test and ui_test regressions
(Requested by ojan on #webkit).
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
- 4:52 PM Changeset in webkit [57242] by
-
- 5 edits4 adds in trunk/LayoutTests
2010-04-07 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
New chromium expected results after r57215
https://bugs.webkit.org/show_bug.cgi?id=37239
- platform/chromium-linux/fast/repaint/stacked-diacritics-expected.checksum: Added.
- platform/chromium-linux/fast/text/line-breaks-expected.checksum:
- platform/chromium-linux/fast/text/line-breaks-expected.png:
- platform/chromium-linux/fast/text/line-breaks-expected.txt: Our new behavior is no more broken than the old behavior. Evan says he'll fix the underlying problem some day.
- platform/chromium-win/fast/repaint/stacked-diacritics-expected.checksum: Added.
- platform/chromium-win/fast/repaint/stacked-diacritics-expected.png: Added.
- platform/chromium-win/fast/repaint/stacked-diacritics-expected.txt: Added. This is a new test. These are just the usual windows vs. mac font rendering differences.
- platform/chromium/test_expectations.txt:
- 4:49 PM Changeset in webkit [57241] by
-
- 3 edits in trunk/LayoutTests
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
https://bugs.webkit.org/show_bug.cgi?id=37235
Tiger's CFNetwork doesn't seem to understand "max-age=-1" so we'll
use "expires=some date in the past" to clear cookies instead.
I've verified that these tests still work on Snow Leopard.
- http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
- http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
- 4:06 PM Changeset in webkit [57240] by
-
- 2 edits in trunk/JavaScriptCore
Beat gcc with a clue bat -- force inlining of refIfNotNull and derefIfNotNull
Reviewed by Geoff Garen.
- wtf/PassRefPtr.h:
- 4:04 PM Changeset in webkit [57239] by
-
- 3 edits in trunk/WebCore
Add the comment and assert that we're generating version 4 random number
based UUIDs.
https://bugs.webkit.org/show_bug.cgi?id=36472
Reviewed by Adam Barth and Dmitry Titov.
- platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
- platform/UUID.h:
- 3:59 PM Changeset in webkit [57238] by
-
- 5 edits2 adds in trunk
2010-04-07 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Allow white listing access from origin to local origin.
https://bugs.webkit.org/show_bug.cgi?id=37228
This makes it possible to load a local resource from a non local
origin if the access has previously been white listed by calling
SecurityOrigin::whiteListAccessFromOrigin.
- http/tests/security/local-image-from-remote-whitelisted-expected.txt: Added.
- http/tests/security/local-image-from-remote-whitelisted.html: Added.
2010-04-07 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Allow white listing access from origin to local origin.
https://bugs.webkit.org/show_bug.cgi?id=37228
This makes it possible to load a local resource from a non local
origin if the access has previously been white listed by calling
SecurityOrigin::whiteListAccessFromOrigin.
Test: http/tests/security/local-image-from-remote-whitelisted.html
- page/OriginAccessEntry.cpp: (WebCore::OriginAccessEntry::OriginAccessEntry): Removed assert that only the http and https protocol are valid.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canRequest): Use isAccessWhiteListed (WebCore::SecurityOrigin::isAccessWhiteListed): Extracted code that goes through the originAccessMap to do the origin matching. (WebCore::SecurityOrigin::canLoad): Check if access has been white listed.
- page/SecurityOrigin.h: Add private function isAccessWhiteListed
- 3:43 PM Changeset in webkit [57237] by
-
- 5 edits in trunk/LayoutTests
2010-04-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
https://bugs.webkit.org/show_bug.cgi?id=37235
Added a ?clear=1 query parameter to the two "set cookies" cgi scripts
that these tests use, and call it to clear the cookies before leaving the test.
I could not resist the temptation of cleaning up the ridiculously awful copy/paste
in these tests, so the changes are larger than strictly necessary.
- http/tests/xmlhttprequest/cookies.html:
- http/tests/xmlhttprequest/cross-origin-cookie-storage.html:
- http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
- http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
- 2:53 PM Changeset in webkit [57236] by
-
- 3 edits in trunk/WebCore
2010-04-07 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Adler.
Adding static method zero() to classes IntPoint and FloatPoint.
https://bugs.webkit.org/show_bug.cgi?id=37220
Adding static method zero() to classes IntPoint and FloatPoint as suggested by Darin Adler.
- platform/graphics/FloatPoint.h: (WebCore::FloatPoint::zero):
- platform/graphics/IntPoint.h: (WebCore::IntPoint::zero): (WebCore::IntPoint::clampNegativeToZero):
- 2:32 PM Changeset in webkit [57235] by
-
- 2 edits in trunk/WebCore
- platform/network/mac/AuthenticationMac.mm: Fix a typo in comment.
- 2:30 PM Changeset in webkit [57234] by
-
- 3 edits in trunk/LayoutTests
2010-04-07 Zhenyao Mo <zmo@google.com>
Reviewed by Eric Seidel.
A few tests in fast/canvas/webgl failed randomly on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=37098
- fast/canvas/webgl/resources/webgl-test.js: Turn off stencil/antialias by default. (create3DContext):
- fast/canvas/webgl/script-tests/index-validation.js: By default antialias is off.
- 2:25 PM Changeset in webkit [57233] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix a typo.
- 2:25 PM Changeset in webkit [57232] by
-
- 5 edits in trunk/WebCore
Reviewed by Darinn Adler.
https://bugs.webkit.org/show_bug.cgi?id=37230
<rdar://problem/7813115> REGRESSION (4.0.5): Safari asks for credentials all the time when
authenticating to Windows IIS Server
- platform/network/ProtectionSpace.h: (WebCore::ProtectionSpaceAuthenticationScheme): Added a constant for ProtectionSpaceAuthenticationSchemeUnknown.
- platform/network/cf/AuthenticationCF.cpp: (WebCore::core):
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::authenticationSchemeFromAuthenticationMethod): Return ProtectionSpaceAuthenticationSchemeUnknown for unknown scheme.
- platform/network/mac/AuthenticationMac.mm: (WebCore::mac): Support NTLM on systems older than 10.6. We actually get this string from NSURLConnection, even though there was no public constant. (WebCore::core): Return ProtectionSpaceAuthenticationSchemeUnknown for unknown scheme.
- 2:20 PM Changeset in webkit [57231] by
-
- 17 edits in trunk
2010-04-07 Jaime Yap <jaimeyap@google.com>
Reviewed by Pavel Feldman.
Tests expectations changed due to the addition of the function symbol name for
the call location for records sent by the InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=36839
No new tests.
- inspector/timeline-test.js:
- platform/chromium-win/inspector/timeline-event-dispatch-expected.txt:
- platform/chromium-win/inspector/timeline-mark-timeline-expected.txt:
- platform/chromium-win/inspector/timeline-network-resource-expected.txt:
- platform/chromium-win/inspector/timeline-paint-expected.txt:
- platform/chromium-win/inspector/timeline-parse-html-expected.txt:
2010-04-07 Jaime Yap <jaimeyap@google.com>
Reviewed by Pavel Feldman.
Adds the ability to get the function symbol name when looking up the call location
for records sent by the InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=36839
No new tests.
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
- bindings/js/ScriptCallStack.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createUtilityContext): (WebCore::ScriptDebugServer::topStackFrame):
- bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::utilityContext):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
- 2:10 PM Changeset in webkit [57230] by
-
- 3 edits3 adds in trunk
2010-04-07 Jay Civelli <jcivelli@chromium.org>
Reviewed by Jian Li.
[chromium] Add test for a popup related crasher.
https://bugs.webkit.org/show_bug.cgi?id=37141
- platform/chromium/fast/forms: Added.
- platform/chromium/fast/forms/search-popup-crasher-expected.txt: Added.
- platform/chromium/fast/forms/search-popup-crasher.html: Added.
2010-04-07 Jay Civelli <jcivelli@chromium.org>
Reviewed by Jian Li.
[chromium] Fixing a NULL pointer being dereferenced in some cases.
https://bugs.webkit.org/show_bug.cgi?id=37141
Test: platform/chromium/fast/forms/search-popup-crasher.html
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenu::~PopupMenu):
- 1:47 PM Changeset in webkit [57229] by
-
- 8 edits3 copies in trunk/WebCore
Add skeleton FileStream module for providing sync file operations for FileAPI
https://bugs.webkit.org/show_bug.cgi?id=37217
Patch by Kinuko Yasuda <kinuko@chromium.org> on 2010-04-07
Reviewed by Jian Li.
For now the module just defines an interface and is almost empty.
Implementation will be added.
No new tests; will be added when we have complete implementation.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/FileStream.cpp: Added.
- html/FileStream.h: Added.
- html/FileStreamClient.h: Added.
- html/FileThread.cpp:
(WebCore::SameFilePredicate::SameFilePredicate):
(WebCore::SameFilePredicate::operator()):
(WebCore::FileThread::unscheduleTasks):
- html/FileThread.h:
(WebCore::FileThread::Task::stream):
(WebCore::FileThread::Task::Task):
- 1:44 PM Changeset in webkit [57228] by
-
- 1 edit2 adds in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
Poor rendering on lala.com with frame flattening
https://bugs.webkit.org/show_bug.cgi?id=37164
Platform specific expected files added for test introduced in r57225.
- platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
- platform/qt/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
- 1:37 PM Changeset in webkit [57227] by
-
- 5 edits in trunk/WebCore
2010-04-07 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Remove some unnecessary uses of commonJSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=37229
Pass the ExecState down to identifierFromNPIdentifier and update call sites
- bridge/NP_jsobject.cpp: (_NPN_Invoke): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::getPropertyNames):
- bridge/c/c_utility.cpp: (JSC::Bindings::identifierFromNPIdentifier):
- bridge/c/c_utility.h:
- 1:32 PM Changeset in webkit [57226] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-07 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Replace isprint with isASCIIPrintable
https://bugs.webkit.org/show_bug.cgi?id=37223
WebKit does not use functions in <ctype.h> as they are dependent on the current
locale. Use the equivalent functions in <wtf/ASCIICType.h>. isASCIIPrintable
replaces isprint.
- pcre/pcre_exec.cpp: (pchars):
- 1:22 PM Changeset in webkit [57225] by
-
- 3 edits1 add in trunk
2010-04-07 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Darin Adler.
Poor rendering on lala.com with frame flattening
https://bugs.webkit.org/show_bug.cgi?id=37164
Do not flatten offscreen iframes.
Test: fast/frames/flattening/iframe-flattening-offscreen.html
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::flattenFrame):
- rendering/RenderPartObject.h:
- 12:57 PM BuildBot edited by
- update contact and port (diff)
- 12:49 PM Changeset in webkit [57224] by
-
- 3 edits3 adds in trunk
2010-04-07 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Make sure that calling bindings constructors as function does not result in crash.
- fast/constructors: Added.
- fast/constructors/constructor-as-function-crash-expected.txt: Added.
- fast/constructors/constructor-as-function-crash.html: Added.
2010-04-07 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
[V8] Add a missing check for constructor call in WebKitPointConstructor.
https://bugs.webkit.org/show_bug.cgi?id=37210
Test: fast/constructors/constructor-as-function-crash.html
- bindings/v8/custom/V8WebKitPointConstructor.cpp: (WebCore::V8WebKitPoint::constructorCallback): Added a check for constructor call.
- 12:17 PM Changeset in webkit [57223] by
-
- 5 edits in trunk/LayoutTests
2010-04-07 Ojan Vafai <ojan@chromium.org>
Reviewed by Simon Fraser.
Make tests pass with tolerance=0 after r57215
https://bugs.webkit.org/show_bug.cgi?id=37225
- platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum:
- platform/mac-leopard/fast/text/complex-text-opacity-expected.png:
- platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
- platform/mac/fast/repaint/stacked-diacritics-expected.png:
- 11:54 AM Changeset in webkit [57222] by
-
- 2 edits3 deletes in trunk/LayoutTests
2010-04-07 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, skipping fast/media/media-feature-wgt-view-mode.html for Chromium.
Chromium doesn't implement layoutTestController.setViewModeMediaFeature(), which is needed
to pass this layout test.
- platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.checksum: Removed.
- platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.png: Removed.
- platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.txt: Removed.
- platform/chromium/test_expectations.txt: Skip fast/media/media-feature-wgt-view-mode.html.
- 11:44 AM Changeset in webkit [57221] by
-
- 1 edit in trunk/WebCore/platform/graphics/mac/SimpleFontDataMac.mm
Fixing TIGER build (take 2)
- 11:16 AM Changeset in webkit [57220] by
-
- 3 edits5 adds in trunk/WebKit/chromium
2010-04-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium: support themes in devtools window.
- WebKit.gypi:
- src/js/DevTools.js: (WebInspector.setToolbarColors): (WebInspector.resetToolbarColors):
- src/js/Images/segmentChromium2.png: Added.
- src/js/Images/segmentHoverChromium2.png: Added.
- src/js/Images/segmentSelectedChromium2.png: Added.
- src/js/Images/statusbarBackgroundChromium2.png: Added.
- src/js/Images/statusbarMenuButtonChromium2.png: Added.
- 11:12 AM Changeset in webkit [57219] by
-
- 3 edits4 adds in trunk/LayoutTests
2010-04-07 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, checking in missing image baselines for fast/layers/video-layer.html
- platform/chromium-linux/fast/layers/video-layer-expected.checksum: Added.
- platform/chromium-linux/fast/layers/video-layer-expected.png: Added.
- platform/chromium-mac/fast/layers/video-layer-expected.checksum: Added.
- platform/chromium-mac/fast/layers/video-layer-expected.png: Added.
- platform/chromium-win/fast/layers/video-layer-expected.checksum: Updated.
- platform/chromium-win/fast/layers/video-layer-expected.png: Updated.
- 10:59 AM Changeset in webkit [57218] by
-
- 5 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=37219
Reviewed by Darin Adler.
This change disables text caret for the iPhone platflorm.
- wtf/Platform.h: Disabled text caret for iPhone.
WebCore:
This change disables text caret for the iPhone platflorm.
Added UNUSED_PARAM to build when ENABLE_TEXT_CARET is 0.
- editing/SelectionController.cpp:
(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::paintCaret):
- page/Frame.cpp:
(WebCore::Frame::paintDragCaret):
- 10:57 AM Changeset in webkit [57217] by
-
- 1 edit in trunk/WebCore/platform/graphics/mac/SimpleFontDataMac.mm
Fixing TIGER build
- 10:06 AM Changeset in webkit [57216] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>
Reviewed by Dave Hyatt.
- fast/repaint/stacked-diacritics.html: Added.
- platform/mac/fast/repaint/stacked-diacritics-expected.checksum: Added.
- platform/mac/fast/repaint/stacked-diacritics-expected.png: Added.
- platform/mac/fast/repaint/stacked-diacritics-expected.txt: Added.
- 10:01 AM Changeset in webkit [57215] by
-
- 42 edits2 moves4 adds in trunk
WebCore: Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>
Reviewed by Dave Hyatt.
In order to be able to handle successfully this case, it is necessary to change the glyph width cache to store
the bounding box for the glyph instead of the simply caching the glyph width.
Retrieving the bounding box for the glyph is expensive, therefore we do it only
when we are rendering text using the complex text path to minimize the performance impact.
To support characters with stacked diacritics, the method canUseGlyphCache has been modified to
return false for the range of characters with stacked diacritics.
The glyph cache has been also updated to allow storing the glyph bounding box together with the
horizontal width. The bounding box is populated only for complex text.
The original version of this patch has been written by Dan Bernstein.
Test: fast/repaint/stacked-diacritics.html
- Android.mk: File name change.
- GNUmakefile.am: File name change.
- WebCore.base.exp: Added parameter in exported function.
- WebCore.gypi: File name change.
- WebCore.vcproj/WebCore.vcproj: File name change.
- WebCore.xcodeproj/project.pbxproj: File name change.
- platform/graphics/Font.cpp:
(WebCore::Font::floatWidth): Added glyphOverflow parameter.
- platform/graphics/Font.h:
(WebCore::GlyphOverflow::GlyphOverflow): Added.
(WebCore::Font::width): Added glyphOverflow parameter.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::canUseGlyphCache): Modified to render characters with stacked diacritics with complex text path.
- platform/graphics/GlyphMetricsMap.cpp: Copied from WebCore/platform/graphics/GlyphWidthMap.cpp.
(WebCore::GlyphMetricsMap::locatePageSlowCase): Class name changed to reflect new semantics.
- platform/graphics/GlyphMetricsMap.h: Copied from WebCore/platform/graphics/GlyphWidthMap.h.
(WebCore::GlyphMetricsMap::GlyphMetricsMap):
(WebCore::GlyphMetricsMap::~GlyphMetricsMap):
(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::widthForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
(WebCore::GlyphMetricsMap::locatePage):
- platform/graphics/GlyphWidthMap.cpp: Removed.
- platform/graphics/GlyphWidthMap.h: Removed.
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit):
- platform/graphics/SimpleFontData.h:
(WebCore::):
(WebCore::SimpleFontData::widthForGlyph):
(WebCore::SimpleFontData::metricsForGlyph):
- platform/graphics/cairo/SimpleFontDataCairo.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
- platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph): Name and signature vachange
- platform/graphics/efl/FontEfl.cpp:
(WebCore::Font::floatWidthForComplexText): Name and signature change.
- platform/graphics/gtk/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- platform/graphics/haiku/FontHaiku.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
- platform/graphics/haiku/SimpleFontDataHaiku.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::minGlyphBoundingBoxX):
(WebCore::ComplexTextController::maxGlyphBoundingBoxX):
(WebCore::ComplexTextController::minGlyphBoundingBoxY):
(WebCore::ComplexTextController::maxGlyphBoundingBoxY):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::floatWidthForComplexText): Added paramter.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::floatWidthForComplexText): Added paramter.
- platform/graphics/win/FontWin.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
- platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::metricsForGDIGlyph):
- platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):
- platform/graphics/win/UniscribeController.h:
(WebCore::UniscribeController::minGlyphBoundingBoxX):
(WebCore::UniscribeController::maxGlyphBoundingBoxX):
(WebCore::UniscribeController::minGlyphBoundingBoxY):
(WebCore::UniscribeController::maxGlyphBoundingBoxY):
- platform/graphics/wince/FontWince.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
- platform/graphics/wx/FontWx.cpp:
(WebCore::Font::floatWidthForComplexText): Added parameter.
- platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::computeVerticalOverflow):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::setFallbackFonts):
(WebCore::InlineTextBox::fallbackFonts):
(WebCore::InlineTextBox::setGlyphOverflow):
(WebCore::InlineTextBox::glyphOverflow):
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::clearGlyphOverflowAndFallbackFontMap): Added.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
- rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::calcPrefWidths):
(WebCore::RenderText::setText):
(WebCore::RenderText::width):
- rendering/RenderText.h:
LayoutTests: Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>
Reviewed by Dave Hyatt.
- fast/repaint/stacked-diacritics.html: Added.
- platform/mac/fast/repaint/stacked-diacritics-expected.checksum: Added.
- platform/mac/fast/repaint/stacked-diacritics-expected.png: Added.
- platform/mac/fast/repaint/stacked-diacritics-expected.txt: Added.
- 9:53 AM Changeset in webkit [57214] by
-
- 2 edits in trunk/WebCore
2010-04-07 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Darin Adler.
Fix incorrect white-space in WebGLRenderingContext.idl
https://bugs.webkit.org/show_bug.cgi?id=31339
- html/canvas/WebGLRenderingContext.idl: Remove offending extra whitespace.
- 9:43 AM Changeset in webkit [57213] by
-
- 2 edits in trunk/WebCore
2010-04-07 Rodrigo Belem <rodrigo.belem@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] The build system is not installing the generated headers (QGraphicsWebView, QWebDatabase, etc)
https://bugs.webkit.org/show_bug.cgi?id=37173
This patch sets the correct path to the classheaders.pri and then
fixes the installation of the generated headers.
- WebCore.pro:
- 9:33 AM Changeset in webkit [57212] by
-
- 1 edit2 adds in trunk/WebKit
2010-04-07 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add ewk_view (the high level object to acces the WebKit-EFL browser
component) to efl/ewk.
http://webkit.org/b/35932
- efl/ewk/ewk_view.cpp: Added.
- efl/ewk/ewk_view.h: Added.
- 9:32 AM Changeset in webkit [57211] by
-
- 2 edits in trunk/WebCore
Spatial Navigation: bail out as soon as algorithm finds a focus candidate is not applicable https://bugs.webkit.org/show_bug.cgi?id=37135
Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>
It happens, for example, when distanceDataForNode assigns numeric_limits<long long> to
current focus candidate's. It means that current candidate is not in direction, or not
a valid target node.
- page/FocusController.cpp:
(WebCore::FocusController::findFocusableNodeInDirection):
- 9:18 AM Changeset in webkit [57210] by
-
- 44 edits in trunk
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed inspector methods from ScriptExecutionContext and derived classes.
Removed MessageDestination parameter from console-related calls (we now always
log to the same destination(s)).
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- dom/Document.cpp: (WebCore::Document::reportException): (WebCore::Document::addMessage):
- dom/Document.h:
- dom/ScriptExecutionContext.h:
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
- loader/FrameLoaderClient.h:
- loader/ResourceLoadNotifier.cpp:
- loader/ResourceLoadNotifier.h:
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::appendToBuffer):
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::checkResponseHeaders):
- workers/DefaultSharedWorkerRepository.cpp: (WebCore::postConsoleMessageTask): (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts): (WebCore::WorkerContext::addMessage):
- workers/WorkerContext.h:
- workers/WorkerMessagingProxy.cpp: (WebCore::postConsoleMessageTask): (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
- workers/WorkerMessagingProxy.h:
- workers/WorkerReportingProxy.h:
- xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage): (WebCore::XMLHttpRequest::didFinishLoading):
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed inspector methods from ScriptExecutionContext and derived classes.
Removed MessageDestination parameter from console-related calls (we now always
log to the same destination(s)).
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
- src/FrameLoaderClientImpl.cpp:
- src/FrameLoaderClientImpl.h:
- src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject): (WebKit::WebWorkerBase::postConsoleMessageTask):
- src/WebWorkerBase.h:
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask):
- src/WebWorkerClientImpl.h:
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.h:
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- WebCoreSupport/FrameLoaderClientHaiku.cpp:
- WebCoreSupport/FrameLoaderClientHaiku.h:
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- WebCoreSupport/FrameLoaderClientQt.cpp:
- WebCoreSupport/FrameLoaderClientQt.h:
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- WebCoreSupport/WebFrameLoaderClient.cpp:
- WebCoreSupport/WebFrameLoaderClient.h:
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
- WebKitSupport/FrameLoaderClientWx.cpp:
- WebKitSupport/FrameLoaderClientWx.h:
- 8:52 AM Changeset in webkit [57209] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
[Chromium] WebIDBDatabaseError::assign doesn't work correctly
https://bugs.webkit.org/show_bug.cgi?id=37209
- src/WebIDBDatabaseError.cpp: (WebKit::WebIDBDatabaseError::assign):
- 7:14 AM Changeset in webkit [57208] by
-
- 7 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=36827
Patch by Dawit Alemayehu <adawit@kde.org> on 2010-04-07
Reviewed by Simon Hausmann.
WebCore:
Replaced the 'shouldTreatAsAttachment' function with a more generic
function that returns the content disposition type.
See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395
- platform/network/HTTPParsers.cpp:
(WebCore::contentDispositionType):
- platform/network/HTTPParsers.h:
(WebCore::):
WebKit/chromium:
Updated the WebCore::shouldTreatAsAttachement function call with the
new more generic replacement WebCore::contentDispositionType.
See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):
WebKit/qt:
Updated the WebCore::shouldTreatAsAttachement function call with the
new more generic replacement WebCore::contentDispositionType.
See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType):
- 7:04 AM Changeset in webkit [57207] by
-
- 10 edits in trunk/WebCore
2010-04-07 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Yury Semikhatsky.
[V8] Throw exception in SerializedScriptValue on input errors
https://bugs.webkit.org/show_bug.cgi?id=37160
When cycles are detected SerializedScriptValue should throw
NOT_SUPPORTED_ERR. See
http://www.whatwg.org/specs/web-apps/2009-10-27/multipage/urls.html#structured-clone
- bindings/scripts/CodeGeneratorV8.pm: Custom processing for function arguments of type SerializedScriptValue.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::SerializedScriptValue):
- bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::create): Added a constructor function with an extra paratemer to check whether an exception was thrown.
SerializedScriptValue::create callers updated to check for
exceptions:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::postMessageCallback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: (WebCore::V8DedicatedWorkerContext::postMessageCallback):
- bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::pushStateCallback): (WebCore::V8History::replaceStateCallback):
- bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::V8MessagePort::postMessageCallback):
- bindings/v8/custom/V8PopStateEventCustom.cpp: (WebCore::V8PopStateEvent::initPopStateEventCallback):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::postMessageCallback):
- 6:10 AM Changeset in webkit [57206] by
-
- 5 edits in trunk/WebCore
2010-04-07 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Provide a placeholder for resources with no content available
https://bugs.webkit.org/show_bug.cgi?id=37142
- English.lproj/localizedStrings.js:
- inspector/front-end/ImageView.js: (WebInspector.ImageView): (WebInspector.ImageView.prototype.contentTabSelected):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab): (WebInspector.ResourceView.prototype.contentTabSelected):
- inspector/front-end/inspector.css: (.resource-content-unavailable):
- 5:48 AM Changeset in webkit [57205] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=36750
Reviewed by Laszlo Gombos.
[Qt] Package build without touch support is broken
Use the conditional attribute instead of #ifdefs in the idl file for the
touch specific properties, to make the generated files compile with and
without the touch events enabled.
- dom/Document.idl: Use conditional instead of #ifdef.
- dom/Element.idl: Ditto.
- page/DOMWindow.idl: Ditto.
- 5:03 AM Changeset in webkit [57204] by
-
- 4 edits in trunk/WebCore
Add the touch event related IDL files to the idl generation, so that
they can be safely included from generated JS bindings files. The
generated files have #ifdef feature guards.
Reviewed by Holger Freyther.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- 4:39 AM Changeset in webkit [57203] by
-
- 4 edits in trunk/WebCore
2010-04-06 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
V8CustomIDBCallbacks<> should not hold a reference to the frame
https://bugs.webkit.org/show_bug.cgi?id=37154
Don't hold on to a Frame reference.
Instead, be an ActiveDOMObject and use scriptExecutionContext()
to get the v8 context.
Factor the guts of onSuccess and onError out.
Doesn't work enough to test yet.
- bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::create): (WebCore::V8CustomIDBCallbacks::onSuccess): (WebCore::V8CustomIDBCallbacks::onError): (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks): (WebCore::V8CustomIDBCallbacks::onEvent):
- bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: (WebCore::V8IndexedDatabaseRequest::openCallback):
- storage/IDBCallbacks.h: (WebCore::IDBCallbacks::IDBCallbacks):
- 4:14 AM Changeset in webkit [57202] by
-
- 2 edits in trunk/WebKit/qt
2010-04-07 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] When providing a widget for the PDF mime type it will cause a crash
m_pluginView may actually be a Widget (for embedded Qt widgets),
so always check isPluginView() before calling PluginView specific methods.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad):
- 3:19 AM Changeset in webkit [57201] by
-
- 12 edits in trunk
2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57196.
http://trac.webkit.org/changeset/57196
https://bugs.webkit.org/show_bug.cgi?id=37196
Multiple layout test failures on Chromium (Requested by yurys
on #webkit).
- inspector/timeline-test.js:
2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57196.
http://trac.webkit.org/changeset/57196
https://bugs.webkit.org/show_bug.cgi?id=37196
Multiple layout test failures on Chromium (Requested by yurys
on #webkit).
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
- bindings/js/ScriptCallStack.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/ScriptDebugServer.cpp:
- bindings/v8/ScriptDebugServer.h:
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createUtilityContext): (WebCore::V8Proxy::sourceLineNumber): (WebCore::V8Proxy::sourceName):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::utilityContext):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
- 3:07 AM QtWebKitTriageRoster edited by
- (diff)
- 2:19 AM Changeset in webkit [57200] by
-
- 4 edits in trunk/WebCore
Unreviewed, rolling out r57199.
http://trac.webkit.org/changeset/57199
https://bugs.webkit.org/show_bug.cgi?id=36750
Breaks non-touch enabled build
- dom/Document.idl:
- dom/Element.idl:
- page/DOMWindow.idl:
- 2:08 AM Changeset in webkit [57199] by
-
- 4 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=36750
Reviewed by Laszlo Gombos.
[Qt] Package build without touch support is broken
Use the conditional attribute instead of #ifdefs in the idl file for the
touch specific properties, to make the generated files compile with and
without the touch events enabled.
- dom/Document.idl: Use conditional instead of #ifdef.
- dom/Element.idl: Ditto.
- page/DOMWindow.idl: Ditto.
- 1:15 AM Changeset in webkit [57198] by
-
- 2 edits in trunk
2010-04-07 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix trunk (non-standalone) builds for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37136
Test for source files before building instead of relying on
standalone_package config.
- WebKit.pro:
- 12:39 AM Changeset in webkit [57197] by
-
- 3 edits in trunk/WebKit/chromium
2010-04-07 Jochen Eisinger <jochen@chromium.org>
Reviewed by Darin Fisher.
Add createApplicationCacheHost to WebFrameClient so
the ApplicationCacheHost has access to its frame.
- public/WebFrameClient.h: (WebKit::WebFrameClient::createApplicationCacheHost):
- src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
- 12:20 AM Changeset in webkit [57196] by
-
- 12 edits in trunk
2010-04-07 Jaime Yap <jaimeyap@google.com>
Reviewed by Yury Semikhatsky.
Adds callerFuncName to the list of nondeterministic fields in the timeline
layout tests.
https://bugs.webkit.org/show_bug.cgi?id=36839
- inspector/timeline-test.js:
2010-04-07 Jaime Yap <jaimeyap@google.com>
Reviewed by Yury Semikhatsky.
Adds the ability to get the function symbol name when looking up the call location
for records sent by the InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=36839
No new tests.
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
- bindings/js/ScriptCallStack.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createUtilityContext): (WebCore::ScriptDebugServer::lastCallFrame):
- bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::utilityContext):
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
Apr 6, 2010:
- 11:40 PM Changeset in webkit [57195] by
-
- 6 edits in trunk/WebKitTools
2010-03-31 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add webkit-patch command to crawl buildbot history and find when tests
started to fail.
https://bugs.webkit.org/show_bug.cgi?id=36911
This is a very bare-bones implementation, which works, but isn't pretty.
We will need further re-factoring and improvement to this code, but
after long discussions with Adam, I think it's best that we land this
and iterate from there.
- Scripts/webkitpy/common/net/buildbot.py:
- Add revision_build_pairs_with_results for cleaner code and possible optimization of this command.
- Return None if a build number can't be found for a revision in build_for_revision
- Separate out suspect_revisions_for_transition for re-use by FailureReason
- Add LayoutTestResults.failing_tests() and make our parsing code explict about what tables it accepts.
- Scripts/webkitpy/tool/commands/queries.py:
- Move _print_blame_information_for_commit out of WhatBroke for re-use by FailureReason.
- Add FailureReason command which can crawl a given builder and explain why it is currently red on a per-test basis.
- 10:14 PM Changeset in webkit [57194] by
-
- 3 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=37188
WebCore::page::Geolocation::m_shouldClearCache is not used.
Reviewed by Darin Adler.
- page/Geolocation.cpp:
(WebCore::Geolocation::Geolocation): Remove m_shouldClearCache.
- page/Geolocation.h:
(WebCore::Geolocation::): Ditto.
- 9:58 PM Changeset in webkit [57193] by
-
- 3 edits in trunk/WebCore
2010-04-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Remove obsolete MOBILE flag
https://bugs.webkit.org/show_bug.cgi?id=37125
The MOBILE flag is no longer used by any of the ports.
The flag use to control some tokenizer defaults that
can be changed runtime.
No new tests as there is no new functionality.
- config.h:
- html/HTMLTokenizer.cpp:
- 9:38 PM Changeset in webkit [57192] by
-
- 19 edits1 copy3 adds in trunk
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646
Add a new exception type for forcibly terminating a JavaScript stack.
The new exception functions similarly to the
InterruptedExecutionException but is conceptually different because
execution is terminated instead of just interrupted.
- GNUmakefile.am:
- Added new Terminator.h file.
- JavaScriptCore.gypi:
- Added new Terminator.h file.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- Added new Terminator.h file.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Added new Terminator.h file.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
- Fully unwind the stack for TerminatedExecutionException.
(JSC::Interpreter::privateExecute):
- Check if we've been terminated at the same time we check if we've timed out.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Check if we've been terminated at the same time we check if we've timed out.
- runtime/Completion.cpp:
- Some exceptions define special completion types so that calls can see why we terminated evaluation.
(JSC::evaluate):
- runtime/Completion.h:
- Define a new completion type for termination.
(JSC::):
- runtime/ExceptionHelpers.cpp:
- Define TerminatedExecutionException and refactor pseudo-RTTI virtual function to be more semantic.
(JSC::InterruptedExecutionError::exceptionType):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::exceptionType):
(JSC::TerminatedExecutionError::toString):
(JSC::createTerminatedExecutionException):
- runtime/ExceptionHelpers.h:
- Entry point for generating a TerminatedExecutionException.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- Add a Terminator object that can be used to asynchronously terminate a JavaScript execution stack.
- runtime/JSGlobalData.h:
- runtime/JSObject.h:
(JSC::JSObject::exceptionType):
- Define that, by default, thrown objects have a normal exception type.
- runtime/Terminator.h: Added.
- Added a new controller object that can be used to terminate execution asynchronously. This object is more or less a glorified bool.
(JSC::Terminator::Terminator):
(JSC::Terminator::termianteSoon):
(JSC::Terminator::shouldTerminate):
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646
- fast/workers/resources/worker-run-forever.js: Added.
- fast/workers/worker-terminate-forever-expected.txt: Added.
- fast/workers/worker-terminate-forever.html: Added.
- Test what happens when we terminate an infinitely running worker. The essential point is that we don't spam the console with nonsense about a timeout.
- platform/mac/Skipped:
- Rescue worker-terminate.html from the Skipped list now that we've fixed the underlying bug that was causing the flakiness.
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646
Cause the worker code to swallow termination exceptions because these
need not be reported to the user because they are an implementation
detail of how we terminate worker execution.
Test: fast/workers/worker-terminate-forever.html
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
- Refuse to report termination exceptions to the user because they are an implementation detail.
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::forbidExecution):
- Instead of using timeouts to stop run away workers, use our fancy new Terminator object.
- 9:17 PM Changeset in webkit [57191] by
-
- 5 edits2 adds in trunk/LayoutTests
2010-04-06 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Checking in new baselines for media/video-controls-rendering.html and fast/layers/video-layer.html.
https://bugs.webkit.org/show_bug.cgi?id=37180
- platform/chromium-linux/media/video-controls-rendering-expected.checksum: Wasn't rebaselined when Linux scrollbars changed.
- platform/chromium-linux/media/video-controls-rendering-expected.png: Ditto.
- platform/chromium-mac/fast/layers/video-layer-expected.txt: Wasn't rebaselined when audio/video UI was refreshed.
- platform/chromium-win/fast/layers/video-layer-expected.txt: Ditto.
- platform/chromium/test_expectations.txt: Removed expectations for the above two tests.
- 8:10 PM Changeset in webkit [57190] by
-
- 2 edits in trunk/WebKit/mac
Tiger build fix after r57184.
- WebView/WebHTMLViewPrivate.h:
- 7:54 PM Changeset in webkit [57189] by
-
- 2 edits in trunk/WebKit/mac
Tiger build fix after r57184.
- WebView/WebHTMLViewPrivate.h:
- 7:39 PM Changeset in webkit [57188] by
-
- 5 edits2 adds in trunk/WebKitTools
2010-04-06 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add DumpRenderTree.gyp, and some small fixes
https://bugs.webkit.org/show_bug.cgi?id=37137
- Add DumpRenderTree.gyp
- Remove some dependencies to base/string_util.h, base/compiler_specific.h, base/file_path.h, base/file_util.h, base/message_loop.h, base/sys_string_conversions.h,
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Added.
- DumpRenderTree/chromium/CppVariant.cpp: (CppVariant::toStringVector):
- DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::keyDown): (EventSender::scheduleAsynchronousClick): (EventSender::beginDragWithFiles):
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::pathToLocalResource):
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::markedRange): (TextInputController::selectedRange):
- 7:33 PM Changeset in webkit [57187] by
-
- 2 edits in trunk/WebKitTools
2010-04-06 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Write stack traces into the results directory for new-run-webkit-tests,
instead of writing them alongside the test file.
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- 7:29 PM Changeset in webkit [57186] by
-
- 2 edits in trunk/WebKit/mac
2010-04-06 Adam Barth <abarth@webkit.org>
Unreviewed.
Speculative build fix for Tiger.
- WebView/WebHTMLViewPrivate.h:
- 7:27 PM Changeset in webkit [57185] by
-
- 2 edits in trunk/WebKitTools
2010-04-06 Dirk Pranke <dpranke@chromium.org>
Unreviewed build fix.
Enable pixel tests by default in new-run-webkit-tests unless
explicitly set by the port or by the command line. This was broken in
the fix for bug 36801 (rev. 57173).
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 6:53 PM Changeset in webkit [57184] by
-
- 3 edits in trunk/WebKit/mac
Expose WebHTMLView’s page breaking logic as SPI.
Reviewed by Sam Weinig and Anders Carlsson.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): Factored out of -adjustPageHeightNew:top:bottom:limit:
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Call -_adjustedBottomOfPageWithTop:bottom:limit:
- WebView/WebHTMLViewPrivate.h: Declared -_adjustedBottomOfPageWithTop:bottom:limit:
- 6:40 PM Changeset in webkit [57183] by
-
- 2 edits in trunk/WebKit/mac
Add an #if in order to make Tiger happy.
- WebView/WebViewData.mm:
(-[WebViewPrivate init]):
- 6:29 PM Changeset in webkit [57182] by
-
- 3 edits in trunk/WebCore
2010-04-06 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
Add basic FileSystem operations for FileReader/FileWriter support for POSIX (incl. Mac)
https://bugs.webkit.org/show_bug.cgi?id=36938
No new tests; will be added when we implement upper layers.
- platform/FileSystem.h: (WebCore::):
- platform/posix/FileSystemPOSIX.cpp: (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::writeToFile): (WebCore::readFromFile):
- 6:15 PM Changeset in webkit [57181] by
-
- 2 edits in trunk/WebKit/mac
Build fix.
- WebView/WebViewData.mm:
(-[WebViewPrivate init]): Use objc_collectingEnabled like we do elsewhere in WebKit.
- 6:02 PM Changeset in webkit [57180] by
-
- 6 edits in trunk
2010-04-06 Nicolas Weber <thakis@chromium.org>
Reviewed by Dimitri Glazkov.
Implement DragImage functionality for chromium/mac.
https://bugs.webkit.org/show_bug.cgi?id=37069
- page/chromium/DragControllerChromium.cpp: (WebCore::DragController::maxDragImageSize): Use a max size of 400x400 on OS X.
- platform/chromium/DragImageChromiumMac.cpp: (WebCore::dragImageSize): Implement. (WebCore::deleteDragImage): Implement. (WebCore::scaleDragImage): Implement. (WebCore::dissolveDragImageToFraction): Implement. (WebCore::createDragImageFromImage): Implement.
- platform/chromium/DragImageRef.h: Use CGImageRefs as DragImageRef on OS X.
2010-04-06 Nicolas Weber <thakis@chromium.org>
Reviewed by Dimitri Glazkov.
Use drag images on OS X as well.
https://bugs.webkit.org/show_bug.cgi?id=37069
- src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
- 4:37 PM Changeset in webkit [57179] by
-
- 1 edit3 adds in trunk/LayoutTests
REGRESSION (r57113): editing/inserting/break-blockquote-after-delete.html fails on Windows
<http://webkit.org/b/37156> / <rdar://problem/7832408>
Rubber-stamped by Oliver Hunt.
Land Windows-specific results for editing/inserting/break-blockquote-after-delete.html. <rdar://problem/7834280>
tracks understanding the root cause of this difference between Mac and Windows.
- platform/win/editing/inserting/break-blockquote-after-delete-expected.checksum: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.checksum.
- platform/win/editing/inserting/break-blockquote-after-delete-expected.png: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.png.
- platform/win/editing/inserting/break-blockquote-after-delete-expected.txt: Copied from LayoutTests/platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.txt.
- 4:36 PM Changeset in webkit [57178] by
-
- 3 edits2 adds in trunk
2010-04-06 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Add test for javascript:window.open() popup blocker bypass.
https://bugs.webkit.org/show_bug.cgi?id=37138
- fast/events/popup-blocked-from-window-open.html: added
- fast/events/popup-blocked-from-window-open-expected.txt: added
2010-04-06 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Use the new UserGestureIndictor to process javascript:window.open()
- bindings/v8/ScriptController.cpp (WebCore::ScriptController::processingUserGesture): Use the new UserGestureIndicator when processing a javascript:window.open()
- 4:27 PM Changeset in webkit [57177] by
-
- 3 edits in trunk/LayoutTests
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
https://bugs.webkit.org/show_bug.cgi?id=37145
The timeout on this test is wrong because the helper library assumes
that we're only going to do one transition, but the test actually does
two in sequence. This patch doubles the timeout to account for that.
The design of these tests are quite unfortunate because these timeout
behaviors don't seem like they'd be reliable on slow machines like
Tiger. I'm not 100% convinced that this will fix the flakiness, but it
seems like an improvement.
I'll file a separate bug about DRT leaking state from one test to
another.
- transitions/transition-end-event-helpers.js:
- transitions/transition-end-event-set-none.html:
- 4:17 PM Changeset in webkit [57176] by
-
- 11 edits in trunk
2010-04-06 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
Renaming Graphics Layer related classes used by Chromium from *Skia to *Chromium and replacing wherever possible Skia-specific
data types with WebCore equivalents. The source files will be renamed accordingly and moved out of platform/graphics/skia
in a subsequent CL.
https://bugs.webkit.org/show_bug.cgi?id=37116
No new functionality so no new tests.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/skia/GraphicsLayerSkia.cpp: (WebCore::setLayerBorderColor): (WebCore::clearBorderColor): (WebCore::setLayerBackgroundColor): (WebCore::clearLayerBackgroundColor): (WebCore::GraphicsLayer::create): (WebCore::GraphicsLayerChromium::GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::setName): (WebCore::GraphicsLayerChromium::nativeLayer): (WebCore::GraphicsLayerChromium::setChildren): (WebCore::GraphicsLayerChromium::addChild): (WebCore::GraphicsLayerChromium::addChildAtIndex): (WebCore::GraphicsLayerChromium::addChildBelow): (WebCore::GraphicsLayerChromium::addChildAbove): (WebCore::GraphicsLayerChromium::replaceChild): (WebCore::GraphicsLayerChromium::removeFromParent): (WebCore::GraphicsLayerChromium::setPosition): (WebCore::GraphicsLayerChromium::setAnchorPoint): (WebCore::GraphicsLayerChromium::setSize): (WebCore::GraphicsLayerChromium::setTransform): (WebCore::GraphicsLayerChromium::setChildrenTransform): (WebCore::GraphicsLayerChromium::setPreserves3D): (WebCore::GraphicsLayerChromium::setMasksToBounds): (WebCore::GraphicsLayerChromium::setDrawsContent): (WebCore::GraphicsLayerChromium::setBackgroundColor): (WebCore::GraphicsLayerChromium::clearBackgroundColor): (WebCore::GraphicsLayerChromium::setContentsOpaque): (WebCore::GraphicsLayerChromium::setBackfaceVisibility): (WebCore::GraphicsLayerChromium::setOpacity): (WebCore::GraphicsLayerChromium::setNeedsDisplay): (WebCore::GraphicsLayerChromium::setNeedsDisplayInRect): (WebCore::GraphicsLayerChromium::setContentsRect): (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::setContentsToVideo): (WebCore::GraphicsLayerChromium::setGeometryOrientation): (WebCore::GraphicsLayerChromium::hostLayerForSublayers): (WebCore::GraphicsLayerChromium::layerForSuperlayer): (WebCore::GraphicsLayerChromium::platformLayer): (WebCore::GraphicsLayerChromium::setDebugBackgroundColor): (WebCore::GraphicsLayerChromium::setDebugBorder): (WebCore::GraphicsLayerChromium::updateSublayerList): (WebCore::GraphicsLayerChromium::updateLayerPosition): (WebCore::GraphicsLayerChromium::updateLayerSize): (WebCore::GraphicsLayerChromium::updateAnchorPoint): (WebCore::GraphicsLayerChromium::updateTransform): (WebCore::GraphicsLayerChromium::updateChildrenTransform): (WebCore::GraphicsLayerChromium::updateMasksToBounds): (WebCore::GraphicsLayerChromium::updateContentsOpaque): (WebCore::GraphicsLayerChromium::updateBackfaceVisibility): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): (WebCore::GraphicsLayerChromium::updateLayerDrawsContent): (WebCore::GraphicsLayerChromium::updateLayerBackgroundColor): (WebCore::GraphicsLayerChromium::updateContentsImage): (WebCore::GraphicsLayerChromium::updateContentsVideo): (WebCore::GraphicsLayerChromium::updateContentsRect): (WebCore::GraphicsLayerChromium::updateGeometryOrientation): (WebCore::GraphicsLayerChromium::setupContentsLayer): (WebCore::GraphicsLayerChromium::updateOpacityOnLayer):
- platform/graphics/skia/GraphicsLayerSkia.h: (WebCore::GraphicsLayerChromium::primaryLayer): (WebCore::GraphicsLayerChromium::contentsLayer):
- platform/graphics/skia/LayerRendererSkia.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::updateLayerContents): (WebCore::LayerRendererChromium::drawLayersInCanvas): (WebCore::LayerRendererChromium::drawLayerInCanvasRecursive): (WebCore::LayerRendererChromium::updateLayerContentsRecursive):
- platform/graphics/skia/LayerRendererSkia.h: (WebCore::LayerRendererChromium::setRootLayer): (WebCore::LayerRendererChromium::rootLayer):
- platform/graphics/skia/LayerSkia.cpp: (WebCore::LayerChromium::create): (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::updateGraphicsContext): (WebCore::LayerChromium::updateContents): (WebCore::LayerChromium::drawDebugBorder): (WebCore::LayerChromium::setNeedsCommit): (WebCore::LayerChromium::addSublayer): (WebCore::LayerChromium::insertSublayer): (WebCore::LayerChromium::removeFromSuperlayer): (WebCore::LayerChromium::removeSublayer): (WebCore::LayerChromium::indexOfSublayer): (WebCore::LayerChromium::setBackingStoreRect): (WebCore::LayerChromium::setBounds): (WebCore::LayerChromium::setFrame): (WebCore::LayerChromium::rootLayer): (WebCore::LayerChromium::removeAllSublayers): (WebCore::LayerChromium::setSublayers): (WebCore::LayerChromium::setSuperlayer): (WebCore::LayerChromium::superlayer): (WebCore::LayerChromium::setNeedsDisplay):
- platform/graphics/skia/LayerSkia.h: (WebCore::LayerChromium::setAnchorPoint): (WebCore::LayerChromium::anchorPoint): (WebCore::LayerChromium::borderWidth): (WebCore::LayerChromium::bounds): (WebCore::LayerChromium::frame): (WebCore::LayerChromium::setPosition): (WebCore::LayerChromium::position): (WebCore::LayerChromium::zPosition): (WebCore::LayerChromium::getSublayers): (WebCore::LayerChromium::setSublayerTransform): (WebCore::LayerChromium::sublayerTransform): (WebCore::LayerChromium::setTransform): (WebCore::LayerChromium::transform):
2010-04-06 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
Changing references to Graphics Layer related classes from *Skia to *Chromium.
https://bugs.webkit.org/show_bug.cgi?id=37116
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::setAcceleratedCompositing): (WebKit::WebViewImpl::updateRootLayerContents):
- src/WebViewImpl.h:
- 4:04 PM Changeset in webkit [57175] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] These tests can be removed from the skipped list since these
work after the redirection loop detection implemented in qt network.
https://bugs.webkit.org/show_bug.cgii?id=36690
- platform/qt/Skipped:
- 3:55 PM Changeset in webkit [57174] by
-
- 3 edits in trunk/WebCore
2010-04-06 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Laszlo Gombos.
[Qt] WebKit does not build on Windows with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=37026
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform):
- 3:47 PM Changeset in webkit [57173] by
-
- 6 edits in trunk/WebKitTools
2010-04-06 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Disable pixel tests on the mac port by default.
Also, revamp the way we check for pixel tests being enabled or
disabled. We now look for options.pixel_tests instead of
options.no_pixel_tests, and we have the "--pixel-tests" (force enable)
and "--no-pixel-tests" (force disable) flags.
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 3:42 PM Changeset in webkit [57172] by
-
- 2 edits in trunk/WebKitTools
2010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Laszlo Gombos.
[Qt] Added the iPhone and iPad latest user agent in QtLauncher UA switcher
https://bugs.webkit.org/show_bug.cgi?id=37159
- QtLauncher/useragentlist.txt:
- 3:39 PM Changeset in webkit [57171] by
-
- 3 edits in trunk/WebKit/chromium
2010-04-06 James Hawkins <jhawkins@chromium.org>
Reviewed by Adam Barth.
[Chromium] Implement WebInputElement::maxLength.
https://bugs.webkit.org/show_bug.cgi?id=37172
- public/WebInputElement.h:
- src/WebInputElement.cpp: (WebKit::WebInputElement::maxLength):
- 3:32 PM Changeset in webkit [57170] by
-
- 2 edits in trunk/WebCore
2010-04-06 Abhinav Mithal <abhinav.mithal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] npapi header leaves XP_WIN flag defined even when SYMBIAN32 flag is found
https://bugs.webkit.org/show_bug.cgi?id=34614
Do not define XP_WIN if WebKit is compiled for Symbian.
No new tests as there is no new functionality.
- bridge/npapi.h:
- 3:02 PM Changeset in webkit [57169] by
-
- 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py
Added myself to the committers list.
- 2:58 PM Changeset in webkit [57168] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, media test expectations tweak.
We now regularly run http/tests/media and have to mark a few tests as TIMEOUT.
- platform/chromium/test_expectations.txt:
- 2:28 PM Changeset in webkit [57167] by
-
- 3 edits2 adds in trunk
aria-label doesn't work on image map area
https://bugs.webkit.org/show_bug.cgi?id=36977
Reviewed by Beth Dakin.
WebCore:
Test: platform/mac/accessibility/area-with-aria-label.html
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::accessibilityDescription):
LayoutTests:
- platform/mac/accessibility/area-with-aria-label-expected.txt: Added.
- platform/mac/accessibility/area-with-aria-label.html: Added.
- 2:21 PM Changeset in webkit [57166] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, cleaning up media layout test expectations.
Mostly correcting bug numbers, updating comments, and fixing expectations.
- platform/chromium/test_expectations.txt:
- 1:44 PM Changeset in webkit [57165] by
-
- 6 edits in trunk/WebCore
2010-04-06 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Reverts the incorrect fixed position fastpath scrolling logic
https://bugs.webkit.org/show_bug.cgi?id=33150
This code does not properly handle overflow or transforms on fixed
position elements, causing repaint bugs on scroll.
No new tests.
- page/FrameView.cpp: (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject):
- page/FrameView.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
- platform/ScrollView.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
- 12:58 PM Changeset in webkit [57164] by
-
- 2 edits in trunk/WebCore
[wx] Build fix for wxMac / Cocoa on wx trunk.
- 12:50 PM Changeset in webkit [57163] by
-
- 2 edits in trunk/WebCore
2010-04-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Darin Adler.
JS code generator does not support feature conditional attributes that are writable
https://bugs.webkit.org/show_bug.cgi?id=37149
Write out the feature #ifdef not only for the getter, but also for the setter
function.
- bindings/scripts/CodeGeneratorJS.pm:
- 12:17 PM Changeset in webkit [57162] by
-
- 9 edits1 copy1 move in trunk
2010-04-06 Evan Stade <estade@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811
Use the DragImageRef that the DragController passes to us.
This was previously committed but rolled back for breaking layout
tests. The fix is on the WebKit/chromium side.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/DragImageChromium.cpp: Removed.
- platform/chromium/DragImageChromiumMac.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
- platform/chromium/DragImageChromiumSkia.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
- platform/chromium/DragImageRef.h:
2010-04-06 Evan Stade <estade@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811
Basic implementation using SkBitmap. Transformations are not supported
yet. No implementation for mac.
This was previously committed but rolled back for breaking layout
tests.
- public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
- src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag): new: check for null dragImage.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
- src/WebViewImpl.h:
- 11:56 AM Changeset in webkit [57161] by
-
- 5 edits in trunk
2010-04-01 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Fix bug: CSS3 :not selector with ID simple selector sequence test fails
https://bugs.webkit.org/show_bug.cgi?id=36276
- fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
- fast/css/invalid-not-with-simple-selector-sequence.html: Added.
2010-04-01 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Fix bug: CSS3 :not selector with ID simple selector sequence test fails
As per http://www.w3.org/TR/css3-selectors/#negation, :not(X) takes a simple selector as an argument.
WebKit was accepting a simple selector *sequence*.
This patch adds WebCore::CSSSelector::isSimple which judges if the selector is simple.
The method is used in CSSGrammar.y to decide whether to accept the selector as the argument of :not().
https://bugs.webkit.org/show_bug.cgi?id=36276
Test: fast/css/invalid-not-with-simple-selector-sequence.html
- css/CSSGrammar.y:
- css/CSSSelector.cpp: (WebCore::CSSSelector::isSimple):
- css/CSSSelector.h:
- 11:18 AM Changeset in webkit [57160] by
-
- 1 edit1 copy in trunk/LayoutTests
REGRESSION (r57109): editing/pasteboard/drag-image-to-contenteditable-in-iframe.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=37157
- platform/win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
Copied from platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt.
Windows gets a different result than Mac because the dragging code ends up making the src attribute
of the dragged element have a full path on Windows, but not on Mac.
- 11:17 AM Changeset in webkit [57159] by
-
- 3 edits in trunk/WebCore
Rubber-stamped by Dan Bernstein.
Patch by Andy Estes <aestes@apple.com> on 2010-04-06
Remove non-ASCII characters from license headers to fix build errors on
Japanese Windows.
https://bugs.webkit.org/show_bug.cgi?id=37008
- dom/UserGestureIndicator.cpp:
- dom/UserGestureIndicator.h:
- 10:59 AM Changeset in webkit [57158] by
-
- 5 edits in trunk/WebKit/chromium
2010-04-06 James Hawkins <jhawkins@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Move the getElementsByTagName from WebDocument to WebNode.
https://bugs.webkit.org/show_bug.cgi?id=37161
- public/WebDocument.h:
- public/WebNode.h:
- src/WebDocument.cpp:
- src/WebNode.cpp: (WebKit::WebNode::getElementsByTagName):
- 10:49 AM Changeset in webkit [57157] by
-
- 2 edits in trunk/WebCore
2010-04-06 Andrei Popescu <andreip@google.com>
Reviewed by Dimitri Glazkov.
[V8][Android] PageCache crashes when JavaScript is disabled
https://bugs.webkit.org/show_bug.cgi?id=37150
This patch ensures that saving and restoration of the script
state only happens when JS is enabled and each frame has a
non-null context.
No new tests: existing tests show the feature is working
when JS is enabled. When JS is disabled, manual testing
is required.
- bindings/v8/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore):
- 10:39 AM Changeset in webkit [57156] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Bryan Yeung <bryeung@chromium.org>
Reviewed by Dimitri Glazkov.
Update chromium expectations for passing Linux tests.
- platform/chromium/test_expectations.txt:
- 10:29 AM Changeset in webkit [57155] by
-
- 2 edits in trunk/WebKit/qt
2010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Add mechanism to detect QtWebKit 2.0 via the preprocessor
https://bugs.webkit.org/show_bug.cgi?id=36538
- Api/qwebkitglobal.h:
- 10:11 AM Changeset in webkit [57154] by
-
- 4 edits in trunk/LayoutTests
2010-04-06 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update Chromium test expectations for fast/dom/error-to-string-stack-overflow.html.
- platform/chromium-mac/fast/dom/error-to-string-stack-overflow-expected.txt:
- platform/chromium-win/fast/dom/error-to-string-stack-overflow-expected.txt:
- platform/chromium/test_expectations.txt:
- 9:15 AM Changeset in webkit [57153] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for Chromium DEPS.
- DEPS:
- 8:56 AM Changeset in webkit [57152] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed: build fixi for WebKit Chromium bots.
- DEPS:
- 8:11 AM Changeset in webkit [57151] by
-
- 2 edits4 adds in trunk/WebCore
2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix.
Web Inspector: missed files were added.
- GNUmakefile.am:
- bindings/js/ScriptGCEvent.h: Added. (WebCore::ScriptGCEvent::addEventListener): (WebCore::ScriptGCEvent::removeEventListener): (WebCore::ScriptGCEvent::getHeapSize):
- bindings/v8/ScriptGCEvent.cpp: Added. (WebCore::ScriptGCEvent::addEventListener): (WebCore::ScriptGCEvent::removeEventListener): (WebCore::ScriptGCEvent::getHeapSize): (WebCore::ScriptGCEvent::getUsedHeapSize): (WebCore::ScriptGCEvent::gcPrologueCallback): (WebCore::ScriptGCEvent::gcEpilogueCallback):
- bindings/v8/ScriptGCEvent.h: Added.
- inspector/ScriptGCEventListener.h: Added. (WebCore::ScriptGCEventListener::~ScriptGCEventListener):
- 7:50 AM QtWebKitBackportingFixes edited by
- (diff)
- 7:46 AM QtWebKitBackportingFixes edited by
- (diff)
- 7:44 AM Changeset in webkit [57150] by
-
- 28 edits in trunk
2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: The JS code can be not optimal from memory usage point of view.
As example it can generate a lot of temp objects and GC will spend significant time to collect these objects.
GC event will show us these moments. Also each event can show us how much memory is in use.
https://bugs.webkit.org/show_bug.cgi?id=37025
- WebCore.gypi:
- WebCore.pro:
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::didGC): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::setHeapSizeStatistic): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
- inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::instanceCount): (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry): (WebCore::InspectorTimelineAgent::GCEvent::GCEvent):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGCEventData):
- inspector/TimelineRecordFactory.h:
- inspector/front-end/Popover.js: (WebInspector.PopoverHelper.prototype._mouseHover):
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- 7:33 AM Changeset in webkit [57149] by
-
- 1 edit in trunk/WebCore/rendering/RenderBox.cpp
Unreviewed identation fix.
- 7:32 AM Changeset in webkit [57148] by
-
- 2 edits in trunk/WebCore
Remove unused DIRECTIONAL_PAD_NAVIGATION
https://bugs.webkit.org/show_bug.cgi?id=37134
Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Android browser was planning to have a "directional pad navigation" available on
trunk, under a build guard called DIRECTIONAL_PAD_NAVIGATION, but according to
https://bugs.webkit.org/show_bug.cgi?id=23145#c3 , the plan was dropped.
However bug 23163 landed some code relying on the build flag supposedly to be added,
and is now dead code in trunk.
- dom/Element.cpp:
(WebCore::Element::updateFocusAppearance):
- 7:00 AM Changeset in webkit [57147] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update Chromium test expectations.
- platform/chromium-win/fast/workers/worker-script-error-expected.txt:
- 6:45 AM Changeset in webkit [57146] by
-
- 13 edits in trunk
2010-04-06 Mattias Nissler <mnissler@chromium.org>
Reviewed by Pavel Feldman.
Rework inspector docking to issue a request call from the frontend
whenever the user triggers to (un)dock the inspector window. Doing so
enables InspectorFrontendHost implementations to asynchronously decide
whether the window is docked or not. The old canAttachWindow() is not
required anymore, remove it.
https://bugs.webkit.org/show_bug.cgi?id=36944
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::requestAttachWindow):
- inspector/InspectorFrontendClientLocal.h:
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::requestAttachWindow):
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/inspector.js: (WebInspector.toggleAttach):
2010-04-06 Mattias Nissler <mnissler@chromium.org>
Reviewed by Pavel Feldman.
Handle docking requests from the developer tools and forward them to
WebDevToolsFrontendClient.
https://bugs.webkit.org/show_bug.cgi?id=36944
- public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::requestDockWindow):
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsRequestAttachWindow):
- src/WebDevToolsFrontendImpl.h:
- 6:33 AM Changeset in webkit [57145] by
-
- 2 edits in trunk/WebCore
2010-04-06 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Yury Semikhatsky.
[V8] Extend the set of types supported by SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=37052
New types include sparse arrays, Uint32, Date, and ImageData.
Serialization process became more flexible. A state can either
directly write primitive values (instead of returning them like
iterator) or construct a new state for serializing complex values
that will return to the current state when done.
Deserialization process now avoids exposing the tags using a set
of factory functions for complex objects instead.
Internal buffer type changed to uint8_t to be independent of
whether char is signed or not.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::Writer): (WebCore::Writer::writeString): (WebCore::Writer::writeUint32): (WebCore::Writer::writeDate): (WebCore::Writer::writeNumber): (WebCore::Writer::writeImageData): (WebCore::Writer::writeArray): (WebCore::Writer::writeObject): (WebCore::Writer::writeSparseArray): (WebCore::Writer::doWriteUint32): (WebCore::Writer::doWriteNumber): (WebCore::Writer::append): (WebCore::Writer::fillHole): (WebCore::Writer::byteAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::writeArray): (WebCore::Serializer::writeObject): (WebCore::Serializer::writeSparseArray): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::ErrorState::ErrorState): (WebCore::Serializer::ErrorState::advance): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::State): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::objectDone): (WebCore::Serializer::SparseArrayState::SparseArrayState): (WebCore::Serializer::SparseArrayState::objectDone): (WebCore::Serializer::push): (WebCore::Serializer::pop): (WebCore::Serializer::handleError): (WebCore::Serializer::checkComposite): (WebCore::Serializer::writeString): (WebCore::Serializer::writeImageData): (WebCore::Serializer::newArrayState): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::Reader::Reader): (WebCore::Reader::read): (WebCore::Reader::readString): (WebCore::Reader::readUint32): (WebCore::Reader::readDate): (WebCore::Reader::readNumber): (WebCore::Reader::readImageData): (WebCore::Reader::doReadUint32): (WebCore::Reader::doReadNumber): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::createArray): (WebCore::Deserializer::createObject): (WebCore::Deserializer::createSparseArray): (WebCore::Deserializer::initializeObject): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::stackDepth): (WebCore::SerializedScriptValue::deserialize):
- 6:29 AM QtWebKitTriageRoster edited by
- (diff)
- 6:19 AM Changeset in webkit [57144] by
-
- 2 edits in trunk/WebKitTools
2010-04-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add current user-agent string for Symbian for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=37131
- QtLauncher/useragentlist.txt:
- 5:53 AM QtWebKitTriageRoster edited by
- (diff)
- 5:50 AM QtWebKitTriageRoster edited by
- (diff)
- 5:46 AM QtWebKitTriageRoster edited by
- (diff)
- 5:35 AM QtWebKitTriageRoster edited by
- (diff)
- 5:31 AM QtWebKitTriageRoster created by
- 5:26 AM Changeset in webkit [57143] by
-
- 2 edits7 adds in trunk/LayoutTests
2010-04-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rebaselining Chromium layout test expectations.
- platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
- platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
- platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.
- platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Added.
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 5:26 AM QtWebKitBugs edited by
- (diff)
- 5:25 AM QtWebKitBugs edited by
- (diff)
- 5:25 AM QtWebKitBugs edited by
- (diff)
- 4:54 AM Changeset in webkit [57142] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-04-06 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Eric Seidel.
[Qt] LayoutTests/fast/canvas/canvas-text-alignment.html skipped on Qt
https://bugs.webkit.org/show_bug.cgi?id=36058
fast/canvas/canvas-text-alignment.html passes, so it can be unskipped.
Compared to png file and Mac expected file.
- platform/qt/Skipped: fast/canvas/canvas-text-alignment.html unskipped.
- platform/qt/fast/canvas/canvas-text-alignment-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-text-alignment-expected.png: Added.
- platform/qt/fast/canvas/canvas-text-alignment-expected.txt: Added.
- 3:47 AM Changeset in webkit [57141] by
-
- 2 edits in trunk/WebCore
Unreviewed buildfix for --minimal build.
Buildfix after r57134. Add ENABLE(WORKERS) guard.
original bug: https://bugs.webkit.org/show_bug.cgi?id=36375
- bindings/js/JSWorkerContextErrorHandler.cpp:
- 3:37 AM Changeset in webkit [57140] by
-
- 3 edits3 adds in trunk
2010-04-06 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
SVG/SMIL parse failure on attribute keySplines
https://bugs.webkit.org/show_bug.cgi?id=37071
Test: svg/animations/animate-keySplines.html
The String in 'keySplines' can have multiple spaces between numbers
and delimiters. The parsing code is inspired by SVGParserUtilities
and respects this.
- svg/SVGAnimationElement.cpp: (WebCore::parseKeySplines):
2010-04-06 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
SVG/SMIL parse failure on attribute keySplines
https://bugs.webkit.org/show_bug.cgi?id=37071
Test correct parsing of keySplines.
- svg/animations/animate-keySplines-expected.txt: Added.
- svg/animations/animate-keySplines.html: Added.
- svg/animations/script-tests/animate-keySplines.js: Added. (sample1): (sample2): (sample3): (executeTest):
- 3:34 AM Changeset in webkit [57139] by
-
- 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt
2010-04-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: more updates to test expectations for Chromium roll.
- platform/chromium/test_expectations.txt:
- 3:14 AM Changeset in webkit [57138] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-06 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Fixed logging of unhndled worker exceptions.
https://bugs.webkit.org/show_bug.cgi?id=37143
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
- 2:59 AM Changeset in webkit [57137] by
-
- 5 edits in trunk/WebKitTools
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Explain how to handle rollout patches
https://bugs.webkit.org/show_bug.cgi?id=37139
We need to set expectations for how long landing rollout patches with
the commit-queue takes. The commit-queue is optimized for safety, not
performance. Also, give folks an alternative way to land patches
quickly.
In addition, improve our testing of add_patch_to_bug by having
MockBugzilla log. This caused me to tighten a bunch of tests and
notice that one of our tests wasn't being run.
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/postdiffforrevert.py:
- 2:58 AM Changeset in webkit [57136] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: more updates to test expectations for Chromium roll.
- platform/chromium/test_expectations.txt:
- 2:07 AM Changeset in webkit [57135] by
-
- 2 edits in trunk/LayoutTests
2010-04-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: updated test expectations for Chromium roll.
- platform/chromium/test_expectations.txt:
- 1:46 AM Changeset in webkit [57134] by
-
- 20 edits3 copies1 add in trunk
2010-04-06 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Refactored error reporting mechanizm on Worker Global Objects.
Unlike other event listeners which accept single argument(Event)
onerror handler on worker global object should be a function
accepting three arguments. This error reporting was implementedas
EventListener::reportError method which had custom implementations
for v8 and JSC. This patch removes EventListener::reportError and
moves its functionality into custom bindings(V8WorkerContextErrorHandler
and JSWorkerContextErrorHandler) that implement EventListener inerface
for the onerror handler.
This patch also makes uncaught exceptions that happen in the onerror
listener be reported to the Worker's onerror handler.
- Android.jscbindings.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSEventListener.cpp:
- bindings/js/JSEventListener.h:
- bindings/js/JSWorkerContextErrorHandler.cpp: Added. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
- bindings/js/JSWorkerContextErrorHandler.h: Added. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8WorkerContextErrorHandler.cpp: Added. (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler): (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
- bindings/v8/V8WorkerContextErrorHandler.h: Added. (WebCore::V8WorkerContextErrorHandler::create):
- bindings/v8/V8WorkerContextEventListener.cpp:
- bindings/v8/V8WorkerContextEventListener.h:
- dom/EventListener.h:
- workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException):
- workers/WorkerContext.h:
2010-04-06 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Test that exception which occurs in onerror handler is reported to the Worker object.
- fast/workers/worker-script-error-expected.txt:
- fast/workers/worker-script-error.html:
- 1:12 AM Changeset in webkit [57133] by
-
- 2 edits in trunk/WebCore
2010-04-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: reverting v8 change at r57079 for crashing Chromium layout tests.
- 12:27 AM Changeset in webkit [57132] by
-
- 5 edits in trunk/WebKitTools
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Turns out commit_info.committer() can be None
https://bugs.webkit.org/show_bug.cgi?id=37106
When the committer isn't in committers.py, the committer() property on
commit_info can be None. We need to handle that case gracefully.
- Scripts/webkitpy/common/checkout/commitinfo.py:
- Scripts/webkitpy/tool/bot/sheriff.py:
- Scripts/webkitpy/tool/bot/sheriff_unittest.py:
- Scripts/webkitpy/tool/commands/queries.py:
- 12:09 AM Changeset in webkit [57131] by
-
- 2 edits in trunk/WebKitTools
2010-04-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [Symbian] Build fix for Dumprendertree if Qt printing is not supported
https://bugs.webkit.org/show_bug.cgi?id=37082
Use the QT_NO_PRINTER guard to flag QPrinter dependent code.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dryRunPrint):
Apr 5, 2010:
- 11:59 PM Changeset in webkit [57130] by
-
- 2 edits in trunk/WebCore
2010-04-05 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
RenderProgress.cpp is missing CurrentTime.h
https://bugs.webkit.org/show_bug.cgi?id=37080
No new tests. just fixed compilation error.
- rendering/RenderProgress.cpp:
- 11:48 PM Changeset in webkit [57129] by
-
- 2 edits in trunk/WebKit/win
2010-04-05 Peter Nelson <charn.opcode@gmail.com>
Reviewed by Eric Seidel.
Fixed style errors in DOMCoreClasses.h to bring it up to scratch
for https://bugs.webkit.org/show_bug.cgi?id=34979.
- DOMCoreClasses.h: (DOMObject::throwException): (DOMObject::callWebScriptMethod): (DOMObject::evaluateWebScript): (DOMObject::removeWebScriptKey): (DOMObject::stringRepresentation): (DOMObject::webScriptValueAtIndex): (DOMObject::setWebScriptValueAtIndex): (DOMObject::setException): (DOMNodeList::throwException): (DOMNodeList::callWebScriptMethod): (DOMNodeList::evaluateWebScript): (DOMNodeList::removeWebScriptKey): (DOMNodeList::stringRepresentation): (DOMNodeList::webScriptValueAtIndex): (DOMNodeList::setWebScriptValueAtIndex): (DOMNodeList::setException): (DOMDocument::throwException): (DOMDocument::callWebScriptMethod): (DOMDocument::evaluateWebScript): (DOMDocument::removeWebScriptKey): (DOMDocument::stringRepresentation): (DOMDocument::webScriptValueAtIndex): (DOMDocument::setWebScriptValueAtIndex): (DOMDocument::setException): (DOMDocument::nodeName): (DOMDocument::nodeValue): (DOMDocument::setNodeValue): (DOMDocument::nodeType): (DOMDocument::parentNode): (DOMDocument::childNodes): (DOMDocument::firstChild): (DOMDocument::lastChild): (DOMDocument::previousSibling): (DOMDocument::nextSibling): (DOMDocument::attributes): (DOMDocument::ownerDocument): (DOMDocument::insertBefore): (DOMDocument::replaceChild): (DOMDocument::removeChild): (DOMDocument::appendChild): (DOMDocument::hasChildNodes): (DOMDocument::cloneNode): (DOMDocument::isSupported): (DOMDocument::namespaceURI): (DOMDocument::prefix): (DOMDocument::setPrefix): (DOMDocument::localName): (DOMDocument::hasAttributes): (DOMDocument::isSameNode): (DOMDocument::isEqualNode): (DOMDocument::textContent): (DOMDocument::setTextContent): (DOMElement::throwException): (DOMElement::callWebScriptMethod): (DOMElement::evaluateWebScript): (DOMElement::removeWebScriptKey): (DOMElement::stringRepresentation): (DOMElement::webScriptValueAtIndex): (DOMElement::setWebScriptValueAtIndex): (DOMElement::setException): (DOMElement::nodeName): (DOMElement::nodeValue): (DOMElement::setNodeValue): (DOMElement::nodeType): (DOMElement::parentNode): (DOMElement::childNodes): (DOMElement::firstChild): (DOMElement::lastChild): (DOMElement::previousSibling): (DOMElement::nextSibling): (DOMElement::attributes): (DOMElement::ownerDocument): (DOMElement::insertBefore): (DOMElement::replaceChild): (DOMElement::removeChild): (DOMElement::appendChild): (DOMElement::hasChildNodes): (DOMElement::cloneNode): (DOMElement::isSupported): (DOMElement::namespaceURI): (DOMElement::prefix): (DOMElement::setPrefix): (DOMElement::localName): (DOMElement::hasAttributes): (DOMElement::isSameNode): (DOMElement::isEqualNode): (DOMElement::textContent): (DOMElement::setTextContent):
- 11:33 PM Changeset in webkit [57128] by
-
- 2 edits in trunk/WebCore
2010-04-05 Eric Uhrhane <ericu@chromium.org>
Reviewed by Brady Eidson.
window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5
https://bugs.webkit.org/show_bug.cgi?id=36671
The previous "fix" I mistakenly compared hashes, an improvement over comparing pointers, but still not right.
No new tests.
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Use SecurityOrigin::equal to compare instead of SecurityOriginHash.
- 11:32 PM WebInspector edited by
- (diff)
- 11:11 PM Changeset in webkit [57127] by
-
- 3 edits in trunk/WebCore
2010-04-05 Anthony Ricaud <rik@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Audits launcher view is unusable with a small height window
https://bugs.webkit.org/show_bug.cgi?id=37109
Use flex box instead of absolute positioning to avoid overlapping elements.
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
- inspector/front-end/audits.css: (.audit-launcher-view .audit-launcher-view-content): (.audit-launcher-view div.button-container): (.audit-launcher-view .flexible-space):
- 11:08 PM WikiStart edited by
- (diff)
- 11:01 PM Changeset in webkit [57126] by
-
- 2 edits in trunk/WebCore
2010-04-05 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Maemo5 theme - wrong spelling
https://bugs.webkit.org/show_bug.cgi?id=37110
Correcting wrong spelling in RenderThemeQt.cpp.
- platform/qt/RenderThemeQt.cpp:
- 10:52 PM Changeset in webkit [57125] by
-
- 6 edits in trunk/WebKitTools
2010-04-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
SheriffBot should force_build builders that are idle and have failed exactly once
https://bugs.webkit.org/show_bug.cgi?id=37059
We can get into a deadlocked state where the commit-queue is stopped
because the builders are red but the SheriffBot hasn't taken action
because the builder has failed only once. The SheriffBot should force
build idle builders that have failed exactly once to either turn the
tree green again (if the test was flaky) or trigger the "failed twice"
remedies (IRC and bug posts).
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/tool/bot/sheriff.py:
- Scripts/webkitpy/tool/bot/sheriff_unittest.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/mocktool.py:
- 10:51 PM Changeset in webkit [57124] by
-
- 4 edits in trunk/WebCore
2010-04-05 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL-specific code to platform/Platform*Event.h.
http://webkit.org/b/36309
- platform/PlatformWheelEvent.h:
- platform/PlatformMouseEvent.h:
- platform/PlatformKeyboardEvent.h:
- 10:23 PM Changeset in webkit [57123] by
-
- 2 edits in trunk/JavaScriptCore
Another build fix
- 10:07 PM Changeset in webkit [57122] by
-
- 2 edits in trunk/JavaScriptCore
And another build fix.
- 10:00 PM Changeset in webkit [57121] by
-
- 2 edits in trunk/JavaScriptCore
Build fix
- 9:18 PM Changeset in webkit [57120] by
-
- 4 edits3 adds in trunk/JavaScriptCore
2010-04-05 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Support weak maps in JSC
https://bugs.webkit.org/show_bug.cgi?id=37132
Expose an API to allow creation of a map for storing
weak JS references.
- API/JSWeakObjectMapRefInternal.h: Added. (OpaqueJSWeakObjectMap::create): (OpaqueJSWeakObjectMap::map): (OpaqueJSWeakObjectMap::~OpaqueJSWeakObjectMap): (OpaqueJSWeakObjectMap::OpaqueJSWeakObjectMap):
- API/JSWeakObjectMapRefPrivate.cpp: Added.
- API/JSWeakObjectMapRefPrivate.h: Added.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::registerWeakMap): (JSC::JSGlobalObject::deregisterWeakMap):
- 8:59 PM Changeset in webkit [57119] by
-
- 3 edits in trunk/WebKitTools
2010-04-05 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Fixed check-webkit-style issue where the script was prematurely
exiting when encountering deleted files in patches.
- Scripts/webkitpy/style/checker.py:
- Changed non-existent file message from ERROR to WARN.
- StyleChecker.check_file() no longer raises an exception when a file is not found.
- Scripts/webkitpy/style/checker_unittest.py:
- Updated unit tests as necessary.
- 8:50 PM Changeset in webkit [57118] by
-
- 5 edits in trunk/WebCore
2010-04-05 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL-specific code to platform/graphics/*.h.
http://webkit.org/b/36308
- platform/graphics/Icon.h:
- platform/graphics/IntRect.h:
- platform/graphics/FloatRect.h:
- platform/graphics/IntPoint.h:
- 8:33 PM Changeset in webkit [57117] by
-
- 3 edits in trunk/WebCore
2010-04-05 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix infinite redirection loop in QNetworkReplyHandler
Put a maximum on consecutive redirections so we don't have to
worry about whether it's the same url or not.
Tolerate up to 10 consecutive redirections, anything beyond
that is considered a potentially infinite recursion in the
redirection requests. This is the same behaviour as Firefox.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- platform/network/qt/QNetworkReplyHandler.h:
- 8:08 PM Changeset in webkit [57116] by
-
- 6 edits6 adds in trunk
2010-04-05 Dimitri Glazkov <Dimitri Glazkov> and James Robinson <jamesr@chromium.org>
Reviewed by Darin Adler and Dimitri Glazkov.
Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864
Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html
fast/forms/select-change-popup-to-listbox-roundtrip.html
fast/forms/textarea-and-mutation-events.html
- dom/Document.cpp: (WebCore::Document::finishedParsing): Added updateStyleIfNeeded()
call to ensure that object loads start before firing window load.
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Removed invocation of
Document::updateStyleForAllDocuments
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit
recalc to ensure accuracy of representation, especially for
menuList/listBox switches.
2010-04-05 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler
Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864
Modified listbox-selection.html to correctly set the size during
creation. Otherwise, options added to it as a menuList, resulting
in a default selection of the first item.
Added a few more tests to ensure we capture correct behavior for
select elements and their default selection, as well as the influence
of when layout occurs.
- fast/forms/listbox-selection.html:
- fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
- fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
- fast/forms/textarea-and-mutation-events.html: Added.
- 8:02 PM Changeset in webkit [57115] by
-
- 7 edits in trunk/WebKitTools
2010-04-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
SheriffBot should include blamelist when posting to bugs
https://bugs.webkit.org/show_bug.cgi?id=37113
When posting on bugs, we should include the full list of SVN revisions
that caused the regression to folks have a better sense of whether they
are to blame.
- Scripts/webkitpy/tool/bot/sheriff.py:
- Scripts/webkitpy/tool/bot/sheriff_unittest.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 7:32 PM Changeset in webkit [57114] by
-
- 2 edits1 delete in trunk/WebKitTools
Unreviewed after discussion with Adam, Darin, and Eric.
Deleted the auto-install directory since it is no longer needed in
source control (it is auto-generated).
Also added webkitpy/thirdparty/autoinstalled to webkitpy/thirdparty's
svn:ignore property.
- Scripts/webkitpy/thirdparty/autoinstalled: Removed.
- 7:24 PM Changeset in webkit [57113] by
-
- 2 edits in trunk/LayoutTests
Update a test result.
- platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:
- 7:03 PM Changeset in webkit [57112] by
-
- 2 edits1 add in trunk/WebCore
2010-04-05 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Laszlo Gombos.
Cleaned up spatial-navigation-test-cases.html by removing the wrongly
used <frameset> tag. Patch also adds a manual-test specifically to
test Spatial Navigation with framesets.
- manual-tests/spatial-navigation/frameset.html: Added.
- manual-tests/spatial-navigation/spatial-navigation-test-cases.html:
- 6:45 PM Changeset in webkit [57111] by
-
- 12 edits2 adds in trunk
Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>.
REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI
Reviewed by Adele Peterson.
WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _updateFontPanel]): Ask the window whether it is the key window rather than doing the comparison
manually. This allows DumpRenderTree's override of isKeyWindow to force this code path to be taken during tests.
WebKitTools:
Add a JavaScript hook in DRT to call through to WebView's -setEditable:. This is required in order to reproduce
the crash.
- DumpRenderTree/LayoutTestController.cpp:
(setWebViewEditableCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setWebViewEditable):
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setWebViewEditable):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setWebViewEditable):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setWebViewEditable):
(LayoutTestController::layerTreeAsText):
LayoutTests:
- platform/mac/editing/deleting/deletionUI-successful-deletion-expected.txt: Added.
- platform/mac/editing/deleting/deletionUI-successful-deletion.html: Added.
- platform/mac/editing/deleting/resources/deletionUI-helpers.js:
(deletionUIDeleteButtonForElement):
(determineDeletionUIExistence):
- 6:45 PM Changeset in webkit [57110] by
-
- 3 edits in trunk/WebCore
Roll out r56989 as it introduced crashes in Mail.
<http://webkit.org/b/37115> / <rdar://problem/7829331>
Reviewed by Adele Peterson.
- dom/Position.cpp:
(WebCore::Position::isCandidate):
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
- 6:38 PM Changeset in webkit [57109] by
-
- 18 edits3 adds in trunk
Images must re-load when an image-holding element moves into a new document
https://bugs.webkit.org/show_bug.cgi?id=37127
Reviewed by Sam Weinig.
WebCore:
Test: fast/images/move-image-to-new-document.html
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::willMoveToNewOwnerDocument): Call ImageLoader's
elementWillMoveToNewOwnerDocument function.
- html/HTMLImageElement.h: Added willMoveToNewOwnerDocument.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Ditto.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::willMoveToNewOwnerDocument): Ditto.
- html/HTMLPlugInImageElement.h: Ditto.
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::willMoveToNewOwnerDocument): Ditto.
- html/HTMLVideoElement.h: Ditto.
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::willMoveToNewOwnerDocument): Ditto.
- svg/SVGImageElement.h: Ditto.
- html/HTMLMediaElement.h: Made willMoveToNewOwnerDocument protected
so it can be called by HTMLVideoElement.cpp.
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::elementWillMoveToNewOwnerDocument): Added.
Resets the loader by clearing out the cached image.
- loader/ImageLoader.h: Added it.
LayoutTests:
- fast/images/move-image-to-new-document-expected.txt: Added.
- fast/images/move-image-to-new-document.html: Added.
- fast/images/script-tests/move-image-to-new-document.js: Added.
- fast/js/resources/js-test-post.js: Added a feature for doing asynchronous scripting
tests. The caller sets jsTestIsAsync to true and then calls finishJSTest when done.
Used by the above test.
- platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
- platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
- platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
Updated since the old test result relied on an incorrect load of an image.
The relative URL has a different base when moved into the subframe document.
- 5:55 PM Changeset in webkit [57108] by
-
- 4 edits in trunk
2010-04-05 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Symbian] Consolidate Symbian WINSCW environment configuration
https://bugs.webkit.org/show_bug.cgi?id=37100
Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.
PLATFORM(WIN) and OS(WIN) no longer needs to be undefined as
undefining WIN32 takes care of it.
- wtf/Platform.h:
2010-04-05 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Symbian] Consolidate Symbian WINSCW environment configuration
https://bugs.webkit.org/show_bug.cgi?id=37100
Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.
No new tests as there is no new functionality.
- config.h:
- 5:34 PM Changeset in webkit [57107] by
-
- 1 edit1 add in trunk/WebCore
2010-04-05 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add missing ClipboardEfl.h to platform/efl.
http://webkit.org/b/36242
- platform/efl/ClipboardEfl.h: Added.
- 5:18 PM Changeset in webkit [57106] by
-
- 7 edits in trunk/LayoutTests
2010-04-05 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Adler.
A few tests in fast/canvas/webgl/ failed on Leopard Release Bot randomly.
https://bugs.webkit.org/show_bug.cgi?id=37077
https://bugs.webkit.org/show_bug.cgi?id=37098
- fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Gathering more information about framebuffer status when failure happens.
- fast/canvas/webgl/drawArraysOutOfBounds.html: Ditto.
- fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Ditto.
- fast/canvas/webgl/drawElementssOutOfBounds.html: Ditto.
- fast/canvas/webgl/index-validation-copies-indices-expected.txt: Ditto.
- fast/canvas/webgl/index-validation-copies-indices.html: Ditto.
- 5:08 PM Changeset in webkit [57105] by
-
- 7 edits3 adds in trunk
2010-04-05 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
Escape control characters in CSS string value when it is serialilzed.
When WebKit serializes a CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts. This change fixes
this issue.
As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (quoteCSSString).
CSS string value is not correctly serialized when it contains binary characters
https://bugs.webkit.org/show_bug.cgi?id=28938
- fast/css/script-tests/string-quote-binary.js: Added.
- fast/css/string-quote-binary-expected.txt: Added.
- fast/css/string-quote-binary.html: Added.
- fast/js/resources/js-test-pre.js: (shouldBeEqualToString): Considering the case when the argument contains binary characters.
2010-04-05 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
Escape control characters in CSS string value when it is serialilzed.
When WebKit serializes a CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts. This change fixes
this issue.
As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (quoteCSSString).
CSS string value is not correctly serialized when it contains binary characters
https://bugs.webkit.org/show_bug.cgi?id=28938
Test: fast/css/string-quote-binary.html
- css/CSSParser.cpp: (WebCore::isCSSTokenizerIdentifier): (WebCore::isCSSTokenizerURL): (WebCore::quoteCSSString): (WebCore::quoteCSSStringIfNeeded): (WebCore::quoteCSSURLIfNeeded):
- css/CSSParser.h:
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
- css/FontFamilyValue.cpp: (WebCore::FontFamilyValue::cssText):
- 5:06 PM Changeset in webkit [57104] by
-
- 2 edits in trunk/SunSpider
Updated the ignore property for changes to the contents here.
- .: Modified property svn:ignore.
- 4:54 PM Changeset in webkit [57103] by
-
- 3 edits2 adds in trunk
2010-04-05 John Gregg <johnnyg@google.com>
Reviewed by Darin Adler.
Notifications should not resolve an empty icon parameter as a relative URL
https://bugs.webkit.org/show_bug.cgi?id=36862
- fast/notifications/notifications-no-icon-expected.txt: Added.
- fast/notifications/notifications-no-icon.html-disabled: Added.
2010-04-05 John Gregg <johnnyg@google.com>
Reviewed by Darin Adler.
Notifications should not resolve an empty icon parameter as a relative URL
https://bugs.webkit.org/show_bug.cgi?id=36862
- notifications/Notification.cpp: (WebCore::Notification::Notification):
- 4:40 PM Changeset in webkit [57102] by
-
- 10 edits in trunk/WebKitTools
Ignore more files the Python tools strew about the working directory.
- Scripts/webkitpy: Added property svn:ignore.
- Scripts/webkitpy/common: Added property svn:ignore.
- Scripts/webkitpy/common/checkout: Added property svn:ignore.
- Scripts/webkitpy/common/config: Added property svn:ignore.
- Scripts/webkitpy/common/net: Added property svn:ignore.
- Scripts/webkitpy/common/thread: Added property svn:ignore.
- Scripts/webkitpy/python24: Added property svn:ignore.
- Scripts/webkitpy/thirdparty/autoinstalled: Modified property svn:ignore.
- Scripts/webkitpy/tool/bot: Added property svn:ignore.
- 4:19 PM Changeset in webkit [57101] by
-
- 5 edits in trunk/WebCore
Removed some unneeded type casts.
Reviewed by Mark Rowe.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText): Removed an unneeded cast.
- page/Location.cpp:
(WebCore::Location::host): Removed unneeded parentheses and cast.
(WebCore::Location::port): Ditto.
- platform/KURLGoogle.cpp:
(WebCore::KURL::setPort): Ditto.
- workers/WorkerLocation.cpp:
(WebCore::WorkerLocation::host): Ditto.
(WebCore::WorkerLocation::port): Ditto.
- 4:07 PM Changeset in webkit [57100] by
-
- 5 edits6 deletes in trunk
2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57081.
http://trac.webkit.org/changeset/57081
https://bugs.webkit.org/show_bug.cgi?id=37121
We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).
- fast/forms/listbox-selection.html:
- fast/forms/select-change-listbox-to-popup-roundtrip-expected.txt: Removed.
- fast/forms/select-change-listbox-to-popup-roundtrip.html: Removed.
- fast/forms/select-change-popup-to-listbox-roundtrip-expected.txt: Removed.
- fast/forms/select-change-popup-to-listbox-roundtrip.html: Removed.
- fast/forms/textarea-and-mutation-events-expected.txt: Removed.
- fast/forms/textarea-and-mutation-events.html: Removed.
2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57081.
http://trac.webkit.org/changeset/57081
https://bugs.webkit.org/show_bug.cgi?id=37121
We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
- 3:57 PM Changeset in webkit [57099] by
-
- 2 edits in trunk/WebCore
ASSERT close()ing the same StorageAreaImpl twice when using multiple PageGroups
<rdar://problem/7828420> and https://bugs.webkit.org/show_bug.cgi?id=37120
Reviewed by Oliver Hunt.
No new tests. (No behavior change)
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::close): Change this invalid ASSERT to an early return.
- 3:39 PM Changeset in webkit [57098] by
-
- 3 edits in trunk/LayoutTests
Updated expected pixel results for missing plug-in, now using text placeholder.
- platform/mac/plugins/qt-qwidget-plugin-expected.checksum:
- platform/mac/plugins/qt-qwidget-plugin-expected.png:
- 3:03 PM Changeset in webkit [57097] by
-
- 1 edit5 adds in trunk/LayoutTests
Unreviewed.
Separate test results for windows platform because progress element is not implemented for that platform yet.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Added.
- platform/win/fast/dom/prototype-inheritance-2-expected.txt: Added.
- platform/win/fast/dom/prototype-inheritance-expected.txt: Added.
- platform/win/fast/js: Added.
- platform/win/fast/js/global-constructors-expected.txt: Added.
- 2:52 PM Changeset in webkit [57096] by
-
- 3 edits in trunk/WebCore
2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57030.
http://trac.webkit.org/changeset/57030
https://bugs.webkit.org/show_bug.cgi?id=37114
Regressed fast/repaint/line-flow-with-floats-9 pixel tests in
chromium port (Requested by jamesr on #webkit).
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 2:49 PM Changeset in webkit [57095] by
-
- 22 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37111
<rdar://problem/7790327> Draw replacement text when plug-in host crashes
- 2:16 PM Changeset in webkit [57094] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Bug 37112 - aria-liveregion-notifications.html fails on leopard release bot
https://bugs.webkit.org/show_bug.cgi?id=37112
Disabling this test on Leopard until further investigation can reveal the answer.
It looks like at this point, any new test added will cause this test to fail on Leopard
release bot, even if it has nothing to do with live regions.
- platform/mac-leopard/Skipped:
- 1:41 PM Changeset in webkit [57093] by
-
- 8 edits2 adds in trunk
WebCore: Bug 37040 - AX: need to send selected children change notification when aria-selected changed
https://bugs.webkit.org/show_bug.cgi?id=37040
Reviewed by Darin Adler.
When aria-selected is changed in the DOM, it will trigger a selected children change notification.
Test: platform/mac/accessibility/aria-listbox-selectedchildren-change.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::selectedChildrenChanged):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::controlType):
Remove extra whitespace before comment (webkit-style).
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::observableObject):
Allowed a listBox to be an observable object.
(WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
Updated and streamlined existing code.
- dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
LayoutTests: Tests for
Bug 37040 - AX: need to send selected children change notification when aria-selected changed
https://bugs.webkit.org/show_bug.cgi?id=37040
Reviewed by Darin Adler.
- platform/mac/accessibility/aria-listbox-selectedchildren-change-expected.txt: Added.
- platform/mac/accessibility/aria-listbox-selectedchildren-change.html: Added.
- 1:38 PM Changeset in webkit [57092] by
-
- 1 edit4 adds in trunk/LayoutTests
Unreviewed.
Separate test results for gtk platform because progress element is not implemented for that platform yet.
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Added.
- platform/gtk/fast/dom/prototype-inheritance-expected.txt: Added.
- platform/gtk/fast/js: Added.
- platform/gtk/fast/js/global-constructors-expected.txt: Added.
- 12:55 PM Changeset in webkit [57091] by
-
- 6 edits in trunk/WebKitTools
2010-04-05 Adam Barth <abarth@webkit.org>
Unreviewed. Add Vitaly Repeshko as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 12:33 PM Changeset in webkit [57090] by
-
- 2 edits in trunk/WebKitTools
2010-04-05 Adam Barth <abarth@webkit.org>
Unreviewed. Add Vitaly Repeshko as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 12:27 PM Changeset in webkit [57089] by
-
- 2 edits in trunk/WebCore
Fix regression in pixel test for animated svg background images.
Patch by Adam Treat <atreat@rim.com> on 2010-04-05
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37027
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):
- 11:30 AM Changeset in webkit [57088] by
-
- 2 edits in trunk/WebKitTools
2010-04-05 Adam Barth <abarth@webkit.org>
Unreviewed. Update kenne's IRC nick to his registered nick.
- Scripts/webkitpy/common/config/committers.py:
- 11:27 AM Changeset in webkit [57087] by
-
- 6 edits in trunk/LayoutTests
2010-04-05 Adam Barth <abarth@webkit.org>
Unreviewed.
Update expected results for addition of HTMLProgressElement. We didn't
see these errors until later because our dependencies are screwed up.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 11:24 AM Changeset in webkit [57086] by
-
- 5 edits in trunk/LayoutTests
Unreviewed layout test fix.
Update mac results for iframe flattening.
- platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
- 11:16 AM WebKit Team edited by
- (diff)
- 10:57 AM Changeset in webkit [57085] by
-
- 4 edits in trunk
2010-04-05 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde-Christiansen.
[Qt] Fix infinite redirection loop in QNetworkReplyHandler
Qt enters an infinite loop if a redirect response redirects to itself.
Fixes http/tests/xmlhttprequest/connection-error-sync.html
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
2010-04-05 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde-Christiansen.
[Qt] Fix infinite redirection loop in QNetworkReplyHandler
Unskip http/tests/xmlhttprequest/connection-error-sync.html
- platform/qt/Skipped:
- 10:55 AM Changeset in webkit [57084] by
-
- 2 edits in trunk/WebKitTools
2010-04-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
prepare-ChangeLog should take a merge-base for which git branch to diff against.
https://bugs.webkit.org/show_bug.cgi?id=36394
- Scripts/prepare-ChangeLog:
- 10:36 AM Changeset in webkit [57083] by
-
- 5 edits in trunk/LayoutTests
Unreviewed layout test fix.
Update Qt results for iframe flattening.
- platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
- platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
- platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
- platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt:
- 10:35 AM Changeset in webkit [57082] by
-
- 19 edits4 deletes in trunk
2010-04-05 Yury Semikhatsky <yurys@chromium.org>
Unreviewed, revert r57078.
- 10:27 AM Changeset in webkit [57081] by
-
- 5 edits6 adds in trunk
2010-04-05 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864
Modified listbox-selection.html to correctly set the size during
creation. Otherwise, options added to it as a menuList, resulting
in a default selection of the first item.
Added a few more tests to ensure we capture correct behavior for
select elements and their default selection, as well as the influence
of when layout occurs.
- fast/forms/listbox-selection.html:
- fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
- fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
- fast/forms/textarea-and-mutation-events.html: Added.
2010-04-05 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864
Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html
fast/forms/select-change-popup-to-listbox-roundtrip.html
fast/forms/textarea-and-mutation-events.html
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Removed invocation of
Document::updateStyleForAllDocuments
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit
recalc to ensure accuracy of representation, especially for
menuList/listBox switches.
- 10:18 AM Changeset in webkit [57080] by
-
- 4 edits in trunk/WebCore
iframe flattening doesn't flatten
https://bugs.webkit.org/show_bug.cgi?id=36798
Reviewed by Dave Hyatt.
Fixed to the iframe flattening code so that the iframes on
http://www.samisite.com/test-csb2nf/id43.htm are actually
flattened.
Covered by current tests.
- page/FrameView.cpp: Propagate contents changes of iframes
and subframes in framesets to the parent so that it is relayouted
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::scheduleRelayout):
- rendering/RenderPart.cpp: HTMLIFrameElement do not inherit from
HTMLFrameElement, but HTMLFrameElementBase, correct cast. Correct
the use of inset border values. Avoid a sometimes unnecessary
relayout.
(WebCore::RenderPart::layoutWithFlattening):
- rendering/RenderPartObject.cpp: Make the calcHeight and calcWidth
return the right values, considering scrolling and fixed width/height
(WebCore::RenderPartObject::flattenFrame):
(WebCore::RenderPartObject::calcHeight):
(WebCore::RenderPartObject::calcWidth):
(WebCore::RenderPartObject::layout):
- 10:06 AM Changeset in webkit [57079] by
-
- 2 edits in trunk/WebCore
2010-04-05 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Yury Semikhatsky.
[V8] Extend the set of types supported by SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=37052
New types include sparse arrays, Uint32, Date, and ImageData.
Serialization process became more flexible. A state can either
directly write primitive values (instead of returning them like
iterator) or construct a new state for serializing complex values
that will return to the current state when done.
Deserialization process now avoids exposing the tags using a set
of factory functions for complex objects instead.
Internal buffer type changed to uint8_t to be independent of
whether char is signed or not.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::Writer): (WebCore::Writer::writeString): (WebCore::Writer::writeUint32): (WebCore::Writer::writeDate): (WebCore::Writer::writeNumber): (WebCore::Writer::writeImageData): (WebCore::Writer::writeArray): (WebCore::Writer::writeObject): (WebCore::Writer::writeSparseArray): (WebCore::Writer::doWriteUint32): (WebCore::Writer::doWriteNumber): (WebCore::Writer::append): (WebCore::Writer::fillHole): (WebCore::Writer::byteAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::writeArray): (WebCore::Serializer::writeObject): (WebCore::Serializer::writeSparseArray): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::ErrorState::ErrorState): (WebCore::Serializer::ErrorState::advance): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::State): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::objectDone): (WebCore::Serializer::SparseArrayState::SparseArrayState): (WebCore::Serializer::SparseArrayState::objectDone): (WebCore::Serializer::push): (WebCore::Serializer::pop): (WebCore::Serializer::handleError): (WebCore::Serializer::checkComposite): (WebCore::Serializer::writeString): (WebCore::Serializer::writeImageData): (WebCore::Serializer::newArrayState): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::Reader::Reader): (WebCore::Reader::read): (WebCore::Reader::readString): (WebCore::Reader::readUint32): (WebCore::Reader::readDate): (WebCore::Reader::readNumber): (WebCore::Reader::readImageData): (WebCore::Reader::doReadUint32): (WebCore::Reader::doReadNumber): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::createArray): (WebCore::Deserializer::createObject): (WebCore::Deserializer::createSparseArray): (WebCore::Deserializer::initializeObject): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::stackDepth): (WebCore::SerializedScriptValue::deserialize):
- 10:00 AM Changeset in webkit [57078] by
-
- 19 edits3 copies1 add in trunk
2010-04-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Refactored error reporting mechanizm on Worker Global Objects.
Unlike other event listeners which accept single argument(Event)
onerror handler on worker global object should be a function
accepting three arguments. This error reporting was implementedas
EventListener::reportError method which had custom implementations
for v8 and JSC. This patch removes EventListener::reportError and
moves its functionality into custom bindings(V8WorkerContextErrorHandler
and JSWorkerContextErrorHandler) that implement EventListener inerface
for the onerror handler.
This patch also makes uncaught exceptions that happen in the onerror
listener be reported to the Worker's onerror handler.
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventListener.cpp:
- bindings/js/JSEventListener.h:
- bindings/js/JSWorkerContextErrorHandler.cpp: Added. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
- bindings/js/JSWorkerContextErrorHandler.h: Added. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8WorkerContextErrorHandler.cpp: Added. (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler): (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
- bindings/v8/V8WorkerContextErrorHandler.h: Added. (WebCore::V8WorkerContextErrorHandler::create):
- bindings/v8/V8WorkerContextEventListener.cpp:
- bindings/v8/V8WorkerContextEventListener.h:
- dom/EventListener.h: Removed reportError method that was used only for reporting worker errors.
- workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException):
2010-04-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Test that exception which occurs in onerror handler is reported to the Worker object.
- fast/workers/worker-script-error-expected.txt:
- fast/workers/worker-script-error.html:
- workers/WorkerContext.h:
- 8:53 AM Changeset in webkit [57077] by
-
- 3 edits in trunk/WebCore
Fix some "explicit braces to avoid ambiguous 'else'" warnings
https://bugs.webkit.org/show_bug.cgi?id=37088
Reviewed by Darin Adler.
Patch by Antonio Gomes (tonikitoo@webkit.org)
- dom/Node.cpp:
(WebCore::Node::dispatchGenericEvent):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchEvent):
- 7:28 AM Changeset in webkit [57076] by
-
- 2 edits in trunk/WebCore
2010-04-05 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Consolidate the definition of SKIP_STATIC_CONSTRUCTORS_ON_GCC
Instead of defining and undefining it later, let's not
define SKIP_STATIC_CONSTRUCTORS_ON_GCC for WINSCW.
No new tests as there is no new functionality.
- config.h:
- 7:12 AM Changeset in webkit [57075] by
-
- 2 edits in trunk/LayoutTests
2010-04-05 Robert Hogan <robert@webkit.org>
Rubber-stamped by Kenneth-Rohde Christiansen.
re-login.html and re-login-async.html are now tracked in bugzilla.
- platform/qt/Skipped:
- 6:47 AM Changeset in webkit [57074] by
-
- 2 edits in trunk/WebCore
2010-04-05 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [Symbian] Remove obsolete build flags for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37083
Symbian port of QtWebKit port does not use icu, so it does
not need U_HAVE_* defines.
Symbian now has inttypes.h as part of OpenC.
stdio.h, limits.h and MathExtras.h are already included in
more appropriate locations.
No new tests as there is no new functionality.
- config.h:
- 5:48 AM Changeset in webkit [57073] by
-
- 2 edits in trunk/WebCore
2010-04-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium build fix.
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platformCallback): (WebCore::V8InspectorFrontendHost::portCallback):
- 5:48 AM Changeset in webkit [57072] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-04-05 Lucas Lommer <llommer@svn.gnome.org>
Reviewed by Gustavo Noronha.
Czech translation for WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=36879
- cs.po: Added.
- 5:44 AM Changeset in webkit [57071] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-04-05 Christian Kirbach <Christian.Kirbach@googlemail.com>
Reviewed by Gustavo Noronha.
Updated German translation
https://bugs.webkit.org/show_bug.cgi?id=36453
- de.po:
- 5:38 AM Changeset in webkit [57070] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-04-05 Luca Ferretti <elle.uca@libero.it>
Reviewed by Gustavo Noronha.
Italian translation for 1.1.90
https://bugs.webkit.org/show_bug.cgi?id=36323
- it.po:
- 5:37 AM Changeset in webkit [57069] by
-
- 6 edits in trunk/WebCore
2010-04-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION] platform detection in Chromium
has regressed to unknown.
- bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::platform): (WebCore::JSInspectorFrontendHost::port):
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platform): (WebCore::V8InspectorFrontendHost::port):
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- 4:59 AM Changeset in webkit [57068] by
-
- 8 edits in trunk/WebCore
2010-04-05 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Remove logging of successful XHR and worker's importScript()
to inspector console
https://bugs.webkit.org/show_bug.cgi?id=37078
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::importScripts):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::V8WorkerContext::importScriptsCallback):
- workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::importScripts):
- workers/DedicatedWorkerContext.h:
- workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
- workers/WorkerContext.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
- 2:27 AM Changeset in webkit [57067] by
-
- 2 edits in trunk/LayoutTests
2010-04-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium test expectations update for the roll.
- platform/chromium/test_expectations.txt:
- 12:41 AM Changeset in webkit [57066] by
-
- 5 edits in trunk/WebKitTools
2010-04-05 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Removed the PatchStyleErrorHandler class and incorporated its
functionality into the DefaultStyleErrorHandler class.
- Scripts/webkitpy/style/checker.py:
- In the StyleChecker class:
- Added a line_number parameter to the check_file() method.
- Renamed the handle_style_error parameter to mock_handle_style_error to be consistent with the other mock_* parameter names.
- Added a mock_check_file parameter to the check_patch() method to facilitate unit testing the changes in this patch.
- Rewrote the check_patch() method with the patch-parsing logic taken from the PatchStyleErrorHandler class.
- In the StyleChecker class:
- Scripts/webkitpy/style/checker_unittest.py:
- Added a StyleCheckerCheckFileBase class and sub-classed the existing StyleCheckerCheckFileTest class from it.
- Added a StyleCheckerCheckPatchTest class to unit-test the rewritten check_patch() method.
- Removed the vestigial main code at the bottom of the file. This is left over from when check-webkit-style was implemented as a module and a wrapper module.
- Scripts/webkitpy/style/error_handlers.py:
- Added an optional line_numbers parameter to the DefaultStyleErrorHandler class constructor and adjusted the call() method as necessary.
- Removed the PatchStyleErrorHandler class.
- Scripts/webkitpy/style/error_handlers_unittest.py:
- Removed the PatchStyleErrorHandlerTest class which unit-tested the PatchStyleErrorHandler class which is being removed in this patch.
- Added a test_line_numbers() test method to the DefaultStyleErrorHandlerTest class to test use of the DefaultStyleErrorHandler's new line_numbers attribute.
- 12:24 AM Changeset in webkit [57065] by
-
- 4 edits in trunk/WebKitTools
2010-04-05 Adam Barth <abarth@webkit.org>
Unreviewed.
Tighten SheriffBot's flaky test detector
https://bugs.webkit.org/show_bug.cgi?id=37063
Instead of just looking for two sequential red builds, look for two
sequential failures of the same test. This should reduce sheriffbot
false positive substantially.
I'm landing this change unreviewed because I've noticed SheriffBot
triggering a lot more false positives now that we've expanded the set
of core builders. I've tried to take Eric's comments on Bug 37063 into
account. I'm happy to iterate on this patch tomorrow once Eric wakes
up.
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- Scripts/webkitpy/tool/commands/queries.py:
