Timeline



May 7, 2010:

11:56 PM Changeset in webkit [59003] by jer.noble@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/win/QTMovieVisualContext.cpp

Fix the windows build.

11:27 PM Changeset in webkit [59002] by zherczeg@webkit.org
  • 2 edits in trunk/WebCore

Fixed the inverse function of f(x) = ((x + 0.055) / 1.055) 2.4
​https://bugs.webkit.org/show_bug.cgi?id=38735

Reviewed by Dirk Schulze

It is ((x (1 / 2.4)) * 1.055) - 0.055

Chromium pixel tests cover the issue.

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::transformColorSpace):

11:24 PM Changeset in webkit [59001] by jer.noble@apple.com
  • 14 edits
    4 copies
    2 moves
    10 adds in trunk

JavaScriptCore: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<​https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>

Reviewed by Maciej Stachowiak

Added cancelCallOnMainThread. callOnMainThread should always now be paired
with cancelCallOnMainThread in situations where the refcon passed to callOnMainThread
may be dealloced before the main thread function can be dispatched.

  • wtf/MainThread.cpp:

(WTF::FunctionWithContext::operator == ): Supports the FunctionWithContextFinder predicate functor.
(WTF::FunctionWithContextFinder::FunctionWithContextFinder): Predicate functor for use with Dequeue::findIf
(WTF::FunctionWithContextFinder::operator()):
(WTF::cancelCallOnMainThread):

  • wtf/MainThread.h:

WebCore: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<​https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>

Reviewed by Eric Carlson

The original functionality of QTMovieWin has been split between QTMovieGWorld,
and a new class: QTMovie. QTMovie contains all the "controller" parts (changing
the rate, seeking, etc) while QTMovieGWorld retains all the drawing code. QTMovieGWorld
now takes a QTMovie, and as such QTMovie is now retainable. QTMovieGWorld registers
itself as a client of QTMovie, so that it can receive load-state notifications,
and thus QTMovie must now support multiple clients. Movie tasking timer support
has been moved into its own class (QTMovieTask) and will be addressed in a future
patch. Most of the functions listed below only changed so much as their class name changed.

  • platform/graphics/win/QTMovie.cpp: Copied from WebCore/platform/graphics/win/QTMovieWin.cpp.

(QTMoviePrivate::QTMoviePrivate):
(QTMoviePrivate::~QTMoviePrivate):
(QTMoviePrivate::startTask):
(QTMoviePrivate::endTask):
(QTMoviePrivate::task):
(QTMoviePrivate::createMovieController):
(QTMovie::QTMovie):
(QTMovie::~QTMovie):
(QTMovie::addClient):
(QTMovie::removeClient):
(QTMovie::play):
(QTMovie::pause):
(QTMovie::rate):
(QTMovie::setRate):
(QTMovie::duration):
(QTMovie::currentTime):
(QTMovie::setCurrentTime):
(QTMovie::setVolume):
(QTMovie::setPreservesPitch):
(QTMovie::dataSize):
(QTMovie::maxTimeLoaded):
(QTMovie::loadState):
(QTMovie::getNaturalSize):
(QTMovie::load):
(QTMovie::disableUnsupportedTracks):
(QTMovie::isDisabled):
(QTMovie::setDisabled):
(QTMovie::hasVideo):
(QTMovie::hasAudio):
(QTMovie::hasClosedCaptions):
(QTMovie::setClosedCaptionsVisible):
(QTMovie::countSupportedTypes):
(QTMovie::getSupportedType):
(QTMovie::initializeQuickTime):
(QTMovie::getMovieHandle):

  • platform/graphics/win/QTMovie.h: Copied from WebCore/platform/graphics/win/QTMovieWin.h.
  • platform/graphics/win/QTMovieGWorld.cpp: Copied from WebCore/platform/graphics/win/QTMovieWin.cpp.

(QTMovieGWorldPrivate::QTMovieGWorldPrivate):
(QTMovieGWorldPrivate::~QTMovieGWorldPrivate):
(QTMovieGWorldPrivate::cacheMovieScale):
(movieDrawingCompleteProc):
(QTMovieGWorldPrivate::registerDrawingCallback):
(QTMovieGWorldPrivate::unregisterDrawingCallback):
(QTMovieGWorldPrivate::drawingComplete):
(QTMovieGWorldPrivate::updateGWorld):
(QTMovieGWorldPrivate::createGWorld):
(QTMovieGWorldPrivate::clearGWorld):
(QTMovieGWorldPrivate::setSize):
(QTMovieGWorldPrivate::updateMovieSize):
(QTMovieGWorldPrivate::deleteGWorld):
(QTMovieGWorldPrivate::movieEnded):
(QTMovieGWorldPrivate::movieLoadStateChanged):
(QTMovieGWorldPrivate::movieTimeChanged):
(QTMovieGWorld::QTMovieGWorld):
(QTMovieGWorld::~QTMovieGWorld):
(QTMovieGWorld::setSize):
(QTMovieGWorld::setVisible):
(QTMovieGWorld::getCurrentFrameInfo):
(QTMovieGWorld::paint):
(QTMovieGWorld::setDisabled):
(QTMovieGWorld::isDisabled):
(QTMovieGWorld::fullscreenWndProc):
(QTMovieGWorld::enterFullscreen):
(QTMovieGWorld::exitFullscreen):
(QTMovieGWorld::setMovie):
(QTMovieGWorld::movie):

  • platform/graphics/win/QTMovieGWorld.h: Copied from WebCore/platform/graphics/win/QTMovieWin.h.
  • platform/graphics/win/QTMovieTask.cpp: Added.

(QTMovieTask::QTMovieTask):
(QTMovieTask::~QTMovieTask):
(QTMovieTask::sharedTask):
(QTMovieTask::updateTaskTimer):
(QTMovieTask::fireTaskClients):
(QTMovieTask::addTaskClient):
(QTMovieTask::removeTaskClient):
(QTMovieTask::setTaskTimerFuncs):

  • platform/graphics/win/QTMovieTask.h: Added.

WebKit/win: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
​https://bugs.webkit.org/show_bug.cgi?id=34005

Reviewed by Adele Peterson.

QTMovieWin is now QTMovieGWorld.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::movie):

  • FullscreenVideoController.h:
11:10 PM Changeset in webkit [59000] by eric@webkit.org
  • 25 edits
    1 add
    3 deletes in trunk

2010-05-06 Eric Seidel <​eric@webkit.org>

Reviewed by Daniel Bates.

test-webkitpy fails under cygwin
​https://bugs.webkit.org/show_bug.cgi?id=38718

  • Scripts/webkitpy/common/system/executive.py:
    • Add _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE and _KILL_ALL_KILLED_PROCESS_EXIT_CODE to store the expected exit codes of processes killed by kill_process and kill_all. These two constants are only used by the unit tests but are stored in executive.py so they can be right next to the platform ifs.
    • Remove unnecessary str() conversion, run_command does that for us.
    • Make os.kill retry on cygwin on EAGAIN. It's unclear why CYGWIN throws EAGAIN, but it only does so sometimes. 3 may not be enough retries, but we'll try it to start with.
    • Add _windows_image_name to automatically convert "yes" to "yes.exe" for use with taskkill.exe /im. Various callers to kill_all could be updated to remove the .exe, but that can be done in another patch.
    • Use taskkill.exe for killall on cygwin.
  • Scripts/webkitpy/common/system/executive_unittest.py:
    • Use the new *_KILLED_PROCESS_EXIT_CODE constants which are correctly set to 0 on windows/cygwin systems where taskkill.exe is used.
    • Test _windows_image_name
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
    • Add FIXME about including mac-snowleopard in baseline_search_path.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Make default_configuration actually read from the Configuration file.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
    • Test default_configuration
  • Scripts/webkitpy/layout_tests/port/win.py:
    • Need a basic baseline_search_path if --platform dryrun is to work.
11:03 PM Changeset in webkit [58999] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-07 Eric Seidel <​eric@webkit.org>

Reviewed by Nikolas Zimmermann.

DryrunTest fails on every platform other than mac
​https://bugs.webkit.org/show_bug.cgi?id=38796

The test uses the port detection logic to find a suitable
port to use results from. However that detection logic assumes
chromium on linux, which requires a chromium checkout which the
bots don't have. The test is broken and we'll need to fix it.
For now I'm just going to disable the test on all platforms besides mac.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
11:01 PM Changeset in webkit [58998] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-05-07 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dmitry Titov.

JSCallbackData is deleted on the Main thread, not the Context thread.
​https://bugs.webkit.org/show_bug.cgi?id=38623

No new tests; you'll only see a problem after the worker-access-to-DB
code goes in. Without this fix, the GTK bots assert, but it's
timing-sensitive and not truly platform-specific.

  • bindings/js/JSCallbackData.h: (WebCore::JSCallbackData::JSCallbackData): (WebCore::JSCallbackData::~JSCallbackData): Store the allocating thread, then assert that we're on it at deletion.

(WebCore::DeleteCallbackDataTask):
This is the task that can get posted to the context thread for cleanup.

  • bindings/js/JSCustomVoidCallback.cpp:
  • bindings/js/JSCustomVoidCallback.h: This callback isn't autogenerated, so we have to do the cleanup manually.
  • bindings/scripts/CodeGeneratorJS.pm: Add the proper cleanup to all autogenerated callbacks.
  • workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownFinishTask::performTask): (WebCore::WorkerThreadShutdownStartTask::performTask): WorkerContext::clearScript can't be called until the posted deletion tasks have completed; move the call from shutdown start to shutdown finish.
10:51 PM Changeset in webkit [58997] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-05-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Attempt to turn Windows bots green again.

Skip two failing tests:

​https://bugs.webkit.org/show_bug.cgi?id=38794
fast/css/display-none-inline-style-change-crash.html (fails on Windows Release bot)

​https://bugs.webkit.org/show_bug.cgi?id=38795
inspector/timeline-paint.html

  • platform/win/Skipped:
10:35 PM Changeset in webkit [58996] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-05-07 Eric Seidel <​eric@webkit.org>

Reviewed by Daniel Bates.

Clean up baseline_search_path to use map to reduce copy/paste code
​https://bugs.webkit.org/show_bug.cgi?id=38792

Reading which portnames a port falls back to is easier if
we convert port names to paths with map instead of using copy/paste code.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
9:17 PM Changeset in webkit [58995] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-05-07 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r58990.
​http://trac.webkit.org/changeset/58990

Broke 4 tests on Snow Leopard and Qt.

  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/JSCell.h:
9:00 PM Changeset in webkit [58994] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-07 Eric Seidel <​eric@webkit.org>

Reviewed by Daniel Bates.

rollout commands fail when commit is missing bug number
​https://bugs.webkit.org/show_bug.cgi?id=38791

  • Scripts/webkitpy/tool/commands/download.py:
    • _commit_info failed to actually return the CommitInfo in the no-bug-id case.
  • Scripts/webkitpy/tool/commands/download_unittest.py:
    • Test that the fix worked.
8:19 PM Changeset in webkit [58993] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Optimize access to the global object from a function that uses eval
​https://bugs.webkit.org/show_bug.cgi?id=38644

Reviewed by Gavin Barraclough.

JavaScriptCore:

Fix bug where cross scope access to a global var (vs. property) would
be allowed without checking for intervening dynamic scopes.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):

LayoutTests:

Add test case to ensure we don't incorrectly allow dynamic scopes
to be skipped when doing direct var access.

  • fast/js/global-resolve-through-eval-expected.txt: Added.
  • fast/js/global-resolve-through-eval.html: Added.
  • fast/js/script-tests/global-resolve-through-eval.js: Added.

(accessGlobal):
(accessLocal):

8:16 PM Changeset in webkit [58992] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix JSC binding generation to match webkit style
​https://bugs.webkit.org/show_bug.cgi?id=38173

Add spaces around "|" to match webkit style.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp:
7:49 PM Changeset in webkit [58991] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Macro expansion I stab at thee!

32bit test fix

7:18 PM Changeset in webkit [58990] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Optimized o[s] where o is a cell and s is a string, removing some old
code that wasn't really tuned for the JIT.

Reviewed by Darin Adler.

SunSpider says 0.8% faster.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSCell.h:
6:27 PM Changeset in webkit [58989] by dumi@chromium.org
  • 25 edits
    8 adds in trunk/WebCore

Adding the IDL files for the sync DB API and the stubs for the JS and V8 bindings.
​https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Brady Eidson.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDatabaseSyncCustom.cpp: Added.

(WebCore::JSDatabaseSync::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabaseSync::transaction):
(WebCore::JSDatabaseSync::readTransaction):

  • bindings/js/JSSQLTransactionSyncCustom.cpp: Added.

(WebCore::JSSQLTransactionSync::executeSql):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::openDatabaseSync):

  • bindings/v8/custom/V8BindingMacros.h: Added.
  • bindings/v8/custom/V8DatabaseSyncCustom.cpp: Added.

(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):
(WebCore::V8DatabaseSync::transactionCallback):
(WebCore::V8DatabaseSync::readTransactionCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp: Added.

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::openDatabaseSyncCallback):

  • storage/Database.idl:
  • storage/DatabaseCallback.h:
  • storage/DatabaseCallback.idl:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):

  • storage/DatabaseSync.h:
  • storage/DatabaseSync.idl: Added.
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • storage/SQLTransactionSync.idl: Added.
  • storage/SQLTransactionSyncCallback.h:
  • storage/SQLTransactionSyncCallback.idl: Added.
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabaseSync):

  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:
6:05 PM Changeset in webkit [58988] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix

5:51 PM Changeset in webkit [58987] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

5:05 PM Changeset in webkit [58986] by oliver@apple.com
  • 20 edits in trunk/JavaScriptCore

2010-05-07 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Optimize access to the global object from a function that uses eval
​https://bugs.webkit.org/show_bug.cgi?id=38644

Add op_resolve_global_dynamic, a variant of op_resolve_global that
checks each node in the scope chain for dynamically inserted properties
and falls back to the normal resolve logic in that case.

  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::isGlobalResolve): (JSC::CodeBlock::printStructures): (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::findScopedProperty):

Now take an additional reference parameter to used to indicate that
there were nodes that may gain dynamic properties

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveWithBase):

deal with additional argument to findScopedProperty

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::FunctionCallResolveNode::emitBytecode): (JSC::PostfixResolveNode::emitBytecode): (JSC::PrefixResolveNode::emitBytecode): (JSC::ReadModifyResolveNode::emitBytecode): (JSC::AssignResolveNode::emitBytecode):

These functions use findScopedProperty directly in order to
optimise lookup. They cannot trivially handle any degree of
dynamism in the lookup so we just give up in such case.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::execute): (JSC::Interpreter::privateExecute):
  • interpreter/Interpreter.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_resolve_global_dynamic): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global_dynamic):

Happily resolve_global_dynamic can share the slow case!

  • jit/JITStubs.h: (JSC::):
  • runtime/JSActivation.cpp: (JSC::JSActivation::isDynamicScope):
  • runtime/JSActivation.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::isDynamicScope):
  • runtime/JSGlobalObject.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::isDynamicScope):
  • runtime/JSStaticScopeObject.h:
  • runtime/JSVariableObject.h:
4:53 PM Changeset in webkit [58985] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-07 Darin Fisher <​darin@chromium.org>

Fix build bustage. Update to Chromium code that avoids a bad
dependency from net/ on chrome/.

  • DEPS:
4:51 PM Changeset in webkit [58984] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

2010-05-06 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Alexey Proskuryakov.

Rewrite test to fail faster if the inner frame doesn't load at all
for some reason (previous version would raise a TypeError before
the timeout was set).

​https://bugs.webkit.org/show_bug.cgi?id=38705

  • http/tests/security/sandbox-inherit-to-initial-document-2.html:
  • platform/chromium/test_expectations.txt:
4:35 PM Changeset in webkit [58983] by Beth Dakin
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/7956972> REGRESSION: Can't focus and type
in GMail due to bad repainting
-and corresponding-
​https://bugs.webkit.org/show_bug.cgi?id=38782

Reviewed by Simon Fraser.

This patch reverts back to pre-r58797 behavior when
shouldPropagateCompositingToIFrameParent() is false.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintingGoesToWindow):

4:23 PM Changeset in webkit [58982] by andersca@apple.com
  • 8 edits in trunk/WebKit/mac

<rdar://problem/7947356>
QT Plug-in in hardware-accelerated WebKit is missing the controller

Reviewed by Sam Weinig and Simon Fraser.

Replace the useSoftwareRenderer boolean with an enum that lets the plug-in host opt into using a layer
backed NSView instead of inserting the layer into the WebCore layer hierarchy.

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::instantiatePlugin):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WKPCInstantiatePluginReply):

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:

(WebKit::NetscapePluginInstanceProxy::rendererType):
(WebKit::NetscapePluginInstanceProxy::setRendererType):
(WebKit::NetscapePluginInstanceProxy::InstantiatePluginReply::InstantiatePluginReply):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Replace the useSoftwareRenderer boolean everywhere with the RendererType enum.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView createPlugin]):
Only go into full compositing mode when the renderer type returned is UseAcceleratedCompositing.
Otherwise, use a layer backed NSView.

  • Plugins/Hosted/WebKitPluginHostTypes.h:

Add a RendererType enum.

4:15 PM Changeset in webkit [58981] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-07 Darin Fisher <​darin@chromium.org>

Fix build bustage. Update to Chromium code that no longer uses
deprecated methods.

  • DEPS:
4:10 PM Changeset in webkit [58980] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/AudioBasicProcessorNode.cpp

Pull more AudioBasicProcessorNode::process() code inside the lock

3:55 PM Changeset in webkit [58979] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Fix AudioBasicProcessorNode::inputHasBeenConnected() to allow dynamic re-initialization.

  • this requires a lock around process()
  • also fix uninitialize() method
3:55 PM Changeset in webkit [58978] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Initial rough implementation for buffer source gain - later to be more optimized

3:55 PM Changeset in webkit [58977] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/AudioResampler.cpp

More descriptive debugging message for resampler channel mismatch

3:55 PM Changeset in webkit [58976] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Add temporary mono and stereo processing busses for use by any processing node.

  • also change local variables from PassRefPtr to RefPtr
3:50 PM Changeset in webkit [58975] by darin@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-07 Darin Fisher <​darin@chromium.org>

Fix build bustage: toElement<T> should be to<T>.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId):
3:18 PM Changeset in webkit [58974] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed Sputnik failure seen on buildbot.

Reviewed by Gavin Barraclough.

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString): Cast to unsigned before checking magnitude,
to efficiently exclude negative numbers, which require two characters
instead of one.

2:44 PM Changeset in webkit [58973] by johnnyg@google.com
  • 2 edits in trunk/WebCore

2010-05-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r58963.
​http://trac.webkit.org/changeset/58963
​https://bugs.webkit.org/show_bug.cgi?id=38773

Broke Chromium layout tests. (Requested by dcheng on #webkit).

  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):
2:18 PM Changeset in webkit [58972] by johnnyg@google.com
  • 2 edits
    6 adds in trunk/LayoutTests

2010-05-07 John Gregg <​johnnyg@google.com>

Unreviewed [re-]baseline of chromium tests.

  • platform/chromium-linux/fast/frames/take-focus-from-iframe-expected.checksum: Added.
  • platform/chromium-linux/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.checksum: Added.
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.checksum: Added.
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt: Added.
  • platform/chromium-win/svg/hixie/error/017-expected.txt:
1:28 PM Changeset in webkit [58971] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-07 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Adjust the position of the comment on the WOFF test and
link to the bug report. This should fix a spurious error
while running layout tests.

  • platform/gtk/Skipped:
1:13 PM Changeset in webkit [58970] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Slightly more effective way to guarantee a compile-time constant, at
least on gcc.

Reviewed by Alexey Proskuryakov.

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString): Use pointer notation instead of array
notation, so the compiler treats the string and its contents as constant.

1:13 PM Changeset in webkit [58969] by krit@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-05-07 Dirk Schulze <​krit@webkit.org>

Unreviewed fix of Windows test.

Windows need an platform dependent DRT result for clip-path-referencing-use2.svg,
Win doesn't have console output during DRT.

  • platform/win/svg/custom/clip-path-referencing-use2-expected.txt: Added.
1:03 PM Changeset in webkit [58968] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-05-07 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

​https://bugs.webkit.org/show_bug.cgi?id=38769
ClipboardGtk should write the URL label in the text portion of the DataObject

No tests as this code path is currently unused in the GTK+ port.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::writeURL): Write the label to the text portion of the DataObject, instead of the URL.
12:57 PM Changeset in webkit [58967] by darin@chromium.org
  • 6 edits in trunk/WebKit/chromium

2010-05-07 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] clear out more deprecated methods that are no longer used
​https://bugs.webkit.org/show_bug.cgi?id=38702

  • public/WebFrame.h:
  • public/WebNode.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
  • src/WebNode.cpp:
12:56 PM Changeset in webkit [58966] by abarth@webkit.org
  • 2 edits
    1 add in trunk/JavaScriptCore

2010-05-07 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

[WTFURL] Add core URL parser
​https://bugs.webkit.org/show_bug.cgi?id=38572

This patch adds the core of the URL parser. The URL parser uses a
templated notion of a code unit to support different string types.
Later we'll add some non-templated APIs with concrete types that
clients can use more conveniently.

The URLParser has a couple calls to ASSERT(), which I've commented out
for now. I'm not 100% sure how to handle the dependency issues there
yet, so I've punted on the issue for now.

Also, there are a number of methods that are declared public in this
patch that are only used by the canonicalizer. My plan is to make
those private or protected and make the canonicalizer a friend of the
parser. The details will be in a later patch.

  • wtf/url/src/URLComponent.h: (WTF::URLComponent::fromRange): (WTF::URLComponent::isNonEmpty): (WTF::URLComponent::isEmptyOrInvalid):
  • wtf/url/src/URLParser.h: Added. (WTF::URLParser::): (WTF::URLParser::isPossibleAuthorityTerminator): (WTF::URLParser::parseAuthority): (WTF::URLParser::extractScheme): (WTF::URLParser::parseAfterScheme): (WTF::URLParser::parseStandardURL): (WTF::URLParser::parsePath): (WTF::URLParser::parsePathURL): (WTF::URLParser::parseMailtoURL): (WTF::URLParser::parsePort): (WTF::URLParser::extractFileName): (WTF::URLParser::extractQueryKeyValue): (WTF::URLParser::isURLSlash): (WTF::URLParser::shouldTrimFromURL): (WTF::URLParser::trimURL): (WTF::URLParser::consecutiveSlashes): (WTF::URLParser::isPortDigit): (WTF::URLParser::nextAuthorityTerminator): (WTF::URLParser::parseUserInfo): (WTF::URLParser::parseServerInfo):
12:35 PM Changeset in webkit [58965] by Nikolas Zimmermann
  • 10 edits in trunk

2010-05-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGResourceClipper assigns a temporary mutated RenderStyle but does not correctly preserve the old style
​https://bugs.webkit.org/show_bug.cgi?id=38767

Fix small logic error leading to a problem in RenderSVGResourceClipper. It assigns a new temporary RenderStyle
to the target object, but fails to reset it correctly to the old style. Fixes all svg/clip-path errors on the windows bots.

  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::createClipData):

2010-05-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGResourceClipper assigns a temporary mutated RenderStyle but does not correctly preserve the old style
​https://bugs.webkit.org/show_bug.cgi?id=38767

Update baseline after fixing a logic error in RenderSVGResourceClipper.

  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt:
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.txt:
  • platform/mac/svg/clip-path/clip-path-clipped-expected.txt:
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.txt:
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt:
12:30 PM Changeset in webkit [58964] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Added a fast path for number-to-character conversion via
Number.prototype.toString base 36.

Reviewed by Oliver Hunt.

0.7% speedup on SunSpider.

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString): Made radix interpretation a little more
efficient by keeping it in int space. Turned "const char" into
"static const char" just in case. Added a fast path for base 36
conversion of something that will turn into a character.

12:23 PM Changeset in webkit [58963] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Add a few more files with Windows linefeeds to the .gitattributes file.

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2010-05-07

  • .gitattributes:
11:46 AM Changeset in webkit [58962] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-05-07 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix debug-only render tree output to show object addresses in hex.

  • rendering/RenderTreeAsText.cpp: (WebCore::writeRenderObject): (WebCore::write):
11:40 AM Changeset in webkit [58961] by ap@apple.com
  • 3 edits
    4 adds in trunk

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly

Test: fast/frames/take-focus-from-iframe.html

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus): Don't clear focus if this frame doesn't have it. This can happen if page's and HTMLFrameElement's ideas of focused frame get out of sync temporarily.
11:24 AM Changeset in webkit [58960] by Nikolas Zimmermann
  • 9 edits in trunk

2010-05-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

svg/custom/use-instanceRoot-as-event-target.xhtml crashes randomly
​https://bugs.webkit.org/show_bug.cgi?id=37798

When creating JSEventListeners through attributes (onclick, etc..) or add/removeEventListener
calls on a SVGElementInstance, do NOT pass the element instance itself as JS wrapper object
but the correspondingElement(). SVGElementInstance redirects all event listener registrations
to the correspondingElement(), as they share an event listener list, per SVG spec. The old
code was very dangerous, leading to random assertions, when garbage collection teared down
the JSSVGElementInstance and event listeners fired, whose listeners were registered with
it, but residing in the correspondingElement() event listener list.

Removes the need for CustomToJS code for JSSVGElementInstance, which was wrong anyways. We hoped
to keep the event listeers alive by just creating a js wrapper of the correspondingElement(), that
could only work as long as garbage collection didn't tear it down, just luck. Also remove the
CustomPushEventHandlerScope marker, as it is only used for JSLazyEventListeners and only works
for JSNode derived objects, it was a no-op for SVGElementInstance, thus removed it.

Should fix all random crashes/assertions seen with svg/custom/use-instanceRoot-as-event-target.xhtml
See bug report for a detailed crash analysis.

  • bindings/js/JSSVGElementInstanceCustom.cpp: Remove custom toJS()/pushEventHandlerScope() handling, not necessary anymore. (WebCore::JSSVGElementInstance::markChildren):
  • bindings/scripts/CodeGeneratorJS.pm: For JSSVGElementInstance pass the correspondingElement() as JS wrapper object, not itself.
  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::invalidateAllInstancesOfElement): Be sure to trigger a style update here, so dirty shadow trees for <use> get rebuild. Otherwhise DOM may be out-of-sync. (WebCore::SVGElementInstance::eventTargetData): Add ASSERT_NOT_REACHED(), all event listener calls are forwarded to the correspondingElement(). (WebCore::SVGElementInstance::ensureEventTargetData): Ditto.
  • svg/SVGElementInstance.idl: Remove CustomToJS, CustomPushEventHandlerScope markers.

2010-05-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

svg/custom/use-instanceRoot-as-event-target.xhtml crashes randomly
​https://bugs.webkit.org/show_bug.cgi?id=37798

Make use-instanceRoot-as-event-target.xhtml behave more correctly. Due a copy & paste problem test #7 was not executed. Fixed.
Make destruction more reliable, by using the standard js-test-post.js injection through <script> before calling notifyDone(), and "TEST COMPLETE" magically appears.

  • platform/mac/svg/hixie/error/017-expected.txt: Update result, now that invalidateAllInstancesOfElement(), correctly triggers <use> shadow tree rebuilds.
  • svg/custom/use-instanceRoot-as-event-target-expected.txt: Update result, was missing a "TEST COMPLETE" marker, and Test #7 was not executed before.
  • svg/custom/use-instanceRoot-as-event-target.xhtml: Fix typo, test #7 is now executed, it also had a bug which has been corrected.
11:20 AM Changeset in webkit [58959] by eric@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2010-05-07 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

[WTFURL] Add a malloc-backed URLBuffer
​https://bugs.webkit.org/show_bug.cgi?id=38694

This patch adds a URLBuffer that uses new/delete to manage the backing
store for the buffer.

  • wtf/url/src/RawURLBuffer.h: Added. (WTF::RawURLBuffer::RawURLBuffer): (WTF::RawURLBuffer::~RawURLBuffer): (WTF::RawURLBuffer::resize):
11:05 AM Changeset in webkit [58958] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-05-07 Finnur Thorarinsson <​finnur.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

[chromium]: Fixing Find in page crash on sites.google.com
​https://bugs.webkit.org/show_bug.cgi?id=38591

setMarkerActive should not try to set a collapsed marker as
active. This can happen when you Edit a Sites page after doing
a Find operation and then you press FindNext.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setMarkerActive):
10:52 AM Changeset in webkit [58957] by kbr@google.com
  • 38 edits
    4 adds in trunk

2010-05-06 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

WebCore::WebGLUnsignedIntArrayInternal::getCallback ReadAV@Arbitrary (deef89ee3d0345edebeaf13cf974c47c)
​https://bugs.webkit.org/show_bug.cgi?id=38039

Web IDL now allows indexed getters and setters to be unnamed. Per
discussion in WebGL working group and recent update to spec,
removed the buggy get() and single-element set() methods from the
JavaScript bindings to the WebGL array types. Refactored set()
implementation in JSC bindings to share more code and modified V8
binding to look more like it. Added unit tests for indexed getter
with out-of-range indices and verifying removal of get and
single-element set methods. Updated existing WebGL array tests.

Tests: fast/canvas/webgl/array-get-and-set-method-removal.html

fast/canvas/webgl/array-get-out-of-bounds.html

  • bindings/js/JSWebGLArrayHelper.h: (WebCore::setWebGLArrayHelper):
  • bindings/js/JSWebGLByteArrayCustom.cpp: (WebCore::JSWebGLByteArray::set):
  • bindings/js/JSWebGLFloatArrayCustom.cpp: (WebCore::JSWebGLFloatArray::set):
  • bindings/js/JSWebGLIntArrayCustom.cpp: (WebCore::JSWebGLIntArray::set):
  • bindings/js/JSWebGLShortArrayCustom.cpp: (WebCore::JSWebGLShortArray::set):
  • bindings/js/JSWebGLUnsignedByteArrayCustom.cpp: (WebCore::JSWebGLUnsignedByteArray::set):
  • bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: (WebCore::JSWebGLUnsignedIntArray::set):
  • bindings/js/JSWebGLUnsignedShortArrayCustom.cpp: (WebCore::JSWebGLUnsignedShortArray::set):
  • bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::setWebGLArrayHelper):
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp: (WebCore::V8WebGLByteArray::setCallback):
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: (WebCore::V8WebGLFloatArray::setCallback):
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp: (WebCore::V8WebGLIntArray::setCallback):
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp: (WebCore::V8WebGLShortArray::setCallback):
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: (WebCore::V8WebGLUnsignedByteArray::setCallback):
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: (WebCore::V8WebGLUnsignedIntArray::setCallback):
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: (WebCore::V8WebGLUnsignedShortArray::setCallback):
  • html/canvas/WebGLByteArray.h:
  • html/canvas/WebGLByteArray.idl:
  • html/canvas/WebGLFloatArray.h:
  • html/canvas/WebGLFloatArray.idl:
  • html/canvas/WebGLIntArray.h:
  • html/canvas/WebGLIntArray.idl:
  • html/canvas/WebGLShortArray.h:
  • html/canvas/WebGLShortArray.idl:
  • html/canvas/WebGLUnsignedByteArray.h:
  • html/canvas/WebGLUnsignedByteArray.idl:
  • html/canvas/WebGLUnsignedIntArray.h:
  • html/canvas/WebGLUnsignedIntArray.idl:
  • html/canvas/WebGLUnsignedShortArray.h:
  • html/canvas/WebGLUnsignedShortArray.idl:

2010-05-06 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

WebCore::WebGLUnsignedIntArrayInternal::getCallback ReadAV@Arbitrary (deef89ee3d0345edebeaf13cf974c47c)
​https://bugs.webkit.org/show_bug.cgi?id=38039

Web IDL now allows indexed getters and setters to be unnamed. Per
discussion in WebGL working group and recent update to spec,
removed the buggy get() and single-element set() methods from the
JavaScript bindings to the WebGL array types. Refactored set()
implementation in JSC bindings to share more code and modified V8
binding to look more like it. Added unit tests for indexed getter
with out-of-range indices and verifying removal of get and
single-element set methods. Updated existing WebGL array tests.

  • fast/canvas/webgl/array-get-and-set-method-removal-expected.txt: Added.
  • fast/canvas/webgl/array-get-and-set-method-removal.html: Added.
  • fast/canvas/webgl/array-get-out-of-bounds-expected.txt: Added.
  • fast/canvas/webgl/array-get-out-of-bounds.html: Added.
  • fast/canvas/webgl/array-setters-expected.txt:
  • fast/canvas/webgl/array-setters.html:
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/bug-32456-expected.txt:
  • fast/canvas/webgl/bug-32456.html:
10:32 AM Changeset in webkit [58956] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-05-07 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium dev tools tests fix.
Add a more strict check prior to accessing constructor property in
Web Inspector frontend.

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
10:30 AM Changeset in webkit [58955] by johnnyg@google.com
  • 3 edits in trunk/LayoutTests

2010-05-07 John Gregg <​johnnyg@google.com>

Unreviewed, rebaseline for chromium.

  • platform/chromium-mac/fast/layers/video-layer-expected.checksum:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
10:03 AM Changeset in webkit [58954] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-05-07 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: On Linux/Windows panel history is
traversed while iterating over words in text prompt.

​https://bugs.webkit.org/show_bug.cgi?id=38740

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt):
  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
9:59 AM Changeset in webkit [58953] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-05-07 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: come up with InjectedScript._className that works for both JSC and V8.

​https://bugs.webkit.org/show_bug.cgi?id=38755

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
9:32 AM Changeset in webkit [58952] by johnnyg@google.com
  • 17 edits in trunk/LayoutTests

2010-05-07 John Gregg <​johnnyg@google.com>

Unreviewed, rebaseline for chromium.

  • platform/chromium-mac/media/audio-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.checksum:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
8:54 AM Changeset in webkit [58951] by Chris Jerdonek
  • 6 edits in trunk/WebKitTools

Refactored VCSUtils.pm's parse-related methods to leave inapplicable
hash values unset instead of setting them to "undef".

Reviewed by Daniel Bates.

​https://bugs.webkit.org/show_bug.cgi?id=38724

Preferring "not set" over "undef" keeps the unit tests smaller and
easier to maintain. Otherwise, we would have to update every unit
test case each time we add support for a new key-value pair --
instead of just the relevant ones.

  • Scripts/VCSUtils.pm:
    • In parseGitDiffHeader(), adjusted the handling of these key-values: executableBitDelta and isBinary.
    • In parseSvnDiffHeader(), adjusted the handling of these key-values: copiedFromPath, isBinary, and sourceRevision.
    • In parseDiffHeader(), adjusted the handling of these key-values: isGit and isSvn.
    • In parseDiff(), adjusted the handling of these key-values: isBinary, isGit, isSvn, and sourceRevision.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
    • Updated the unit tests as necessary.
8:42 AM Changeset in webkit [58950] by Joseph Pecoraro
  • 4 edits
    1 add in trunk/WebCore

2010-05-07 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Adam Barth.

document.write is not synchronous after page load
​https://bugs.webkit.org/show_bug.cgi?id=38146

If there are no pending scripts, a document.write call should be
synchronous. This matches other browsers and the HTML5 spec. Forcing
the tokenizer to be synchronous in Document::write does not affect
external scripts written by the write call. This should only change
behavior of document.write after the page is done loading.

Difficult to test reliably due to HTMLTokenizing relying on processing time.
I made a manual test because the test requires processing very large strings
synchronously and therefore can take some time.

Test: WebCore/manual-tests/dom/document-write-synchronous-after-page-load.html

  • dom/Document.cpp: (WebCore::SynchronousHTMLTokenizerGuard::SynchronousHTMLTokenizerGuard): if the provided tokenizer is an HTMLTokenizer make it synchronous (WebCore::SynchronousHTMLTokenizerGuard::~SynchronousHTMLTokenizerGuard): if the provided tokenizer was an HTMLTokenizer return its synchronous state (WebCore::Document::write): temporarily set the tokenizer to synchronous during document.write
  • dom/Tokenizer.h: (WebCore::Tokenizer::asHTMLTokenizer): default implementation returns 0, to be overridden by HTMLTokenizer
  • html/HTMLTokenizer.h: allow access to to the force synchronous state (WebCore::HTMLTokenizer::forceSynchronous): accessor (WebCore::HTMLTokenizer::asHTMLTokenizer): override the default to return itself
  • manual-tests/dom/document-write-synchronous-after-page-load.html: Added.
8:15 AM QtWebKitJournal edited by Simon Hausmann
(diff)
8:13 AM Changeset in webkit [58949] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix rendering of -webkit-user-select: none

Reviewed by Simon Hausmann.

-webkit-user-select: none is implemented by filling
the area with an invalid default-constructed Color.
In most ports passing an invalid color down to the
graphics backend seems to produce transparent fills.

In Qt the behavior of painting with an invalid QColor
is undefined, and in practice it results in painting
black opaque areas.

One way to fix this would be to use Qt::transparent
when converting an undefined Color to a QColor, but
Qt does not have short circuits for fully transparent
painting, and we actually end up in slow code paths
due to the transparency. So, we're better of doing the
short circuit in WebKit.

​https://bugs.webkit.org/show_bug.cgi?id=38523

  • platform/graphics/qt/GraphicsContextQt.cpp:
8:04 AM Changeset in webkit [58948] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-07 Ben Murdoch <​benm@google.com>

Reviewed by Darin Adler.

Potential crash in EventHandler::handleTouchEvent
​https://bugs.webkit.org/show_bug.cgi?id=38646

Fix a ref counting bug that can cause a crash if the m_originatingouchPointTargets
hashmap holds the last ref to an EventTarget when the user lifts their finger.

This is very hard to reproduce in a consistent way and clearly a
simple logic error in the code, therefore no new tests.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Don't let the RefPtr we get back from

the hasmap go out of scope so soon as it could delete the wrapped ptr if the
hashmap held the last ref (and we use the raw ptr that the RefPtr
wraps later in the WebCore::Touch constructor).

8:03 AM Changeset in webkit [58947] by Simon Hausmann
  • 2 edits in trunk

Add a few more files with Windows linefeeds to the .gitattributes file.

  • .gitattributes:
7:08 AM Changeset in webkit [58946] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-05-07 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Kenneth Rohde Christiansen.

[GTK] Fails to build on GTK+ < 2.14
​https://bugs.webkit.org/show_bug.cgi?id=38746

Build fix only. Do basically the same as gtk_adjustment_configure
would do if we are bellow GTK+ 2.14.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::AdjustmentConfigure):
6:43 AM Changeset in webkit [58945] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-05-07 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Crash with MgOpenModerna font, with non-UTF-8 character
​https://bugs.webkit.org/show_bug.cgi?id=37795

NULL-check the font platform data, for now, to avoid the crash.

Could not yet figure out a way to get a test written that does not
involve adding the font to the tree, but there are doubts about
licensing.

  • platform/graphics/cairo/FontCacheCairo.cpp: (WebCore::FontCache::getFontDataForCharacters):
5:33 AM Changeset in webkit [58944] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-05-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Turn Tiger core builder green again, filed ​https://bugs.webkit.org/show_bug.cgi?id=38743 for failing webarchive/test-link-rel-icon.html.

  • platform/mac-tiger/Skipped:
5:31 AM Changeset in webkit [58943] by morrita@google.com
  • 6 edits in trunk/WebCore

2010-05-07 MORITA Hajime <​morrita@google.com>

Reviewed by Eric Seidel.

[Chromium] RenderThemeChromiumMac.mm should share the code with RenderThemeMac.mm
​https://bugs.webkit.org/show_bug.cgi?id=37204

Made RenderThemeChromiumMac subclass of RenderThemeMac, instead of RenderTheme.
Added some method to RenderThemeMac for overriding on RenderThemeChromiumMac.

No new tests; Should have no behavioural change.

  • WebCore.gyp/WebCore.gyp:
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor): (WebCore::RenderThemeChromiumMac::documentViewFor): (WebCore::RenderThemeChromiumMac::adjustMediaSliderThumbSize): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
  • rendering/RenderThemeMac.h: (WebCore::RenderThemeMac::updateActiveState): Added for overriding
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::usesTestModeFocusRingColor): Added for overriding (WebCore::RenderThemeMac::documentViewFor): Added for overriding (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::setPopupButtonCellState): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::setSearchCellState): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton): (WebCore::RenderThemeMac::adjustSliderThumbSize): (WebCore::RenderThemeMac::adjustMediaSliderThumbSize): Added for overriding (WebCore::RenderThemeMac::extraMediaControlsStyleSheet):
4:53 AM Changeset in webkit [58942] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with absent exports.

  • symbian/eabi/QtWebKitu.def:
12:32 AM Changeset in webkit [58941] by ukai@chromium.org
  • 5 edits in trunk

2010-05-06 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

JavaScriptCore/wtf/RandomNumber.h should provide using WTF::*
​https://bugs.webkit.org/show_bug.cgi?id=38719

  • wtf/RandomNumber.h: Add using directives.

2010-05-06 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

JavaScriptCore/wtf/RandomNumber.h should provide using WTF::*
​https://bugs.webkit.org/show_bug.cgi?id=38719

  • platform/graphics/wince/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
Remove WTF
prefix from randomNumber()
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString): Ditto.

May 6, 2010:

11:42 PM Changeset in webkit [58940] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Exclude leaks due to <rdar://problem/7815391> from the output.

Rubber-stamped by Dan Bernstein.

  • Scripts/old-run-webkit-tests:
11:22 PM Changeset in webkit [58939] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2010-05-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable YARR_JIT for X86 Mac for QtWebKit
​https://bugs.webkit.org/show_bug.cgi?id=38668

  • wtf/Platform.h:
11:18 PM Changeset in webkit [58938] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Skip compositing/layer-creation/overflow-scroll-overlap.html from r58936, since hardware
compositing is disabled on the Leopard test bot.

  • platform/mac-leopard/Skipped:
10:12 PM Changeset in webkit [58937] by tony@chromium.org
  • 4 edits
    3 adds in trunk

2010-04-27 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] clicking a scrollbar in an iframe shouldn't lose the selection
​https://bugs.webkit.org/show_bug.cgi?id=38189

  • fast/events/mousedown-in-subframe-scrollbar-expected.txt: Added.
  • fast/events/mousedown-in-subframe-scrollbar.html: Added.
  • fast/events/resources/mousedown-in-subframe-scrollbar.html: Added.
  • platform/win/Skipped:

2010-04-27 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] clicking a scrollbar in an iframe shouldn't lose the selection
​https://bugs.webkit.org/show_bug.cgi?id=38189

Test: fast/events/mousedown-in-subframe-scrollbar.html

  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): If clicking on

a scrollbar, pass the event directly to the scrollbar. This matches
mac which passes the event to the NSScroller.

10:04 PM Changeset in webkit [58936] by Simon Fraser
  • 3 edits
    3 adds in trunk

2010-05-06 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Compositing layers that are clipped out by an overflow:scroll parent fail to get created on reveal
​https://bugs.webkit.org/show_bug.cgi?id=38712

When compositing layer creation is testing layer overlap, we need to re-run the
algorithm when an overflow:scroll element scrolls, to create new layers for revealed
elements.

Test: compositing/layer-creation/overflow-scroll-overlap.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): First, move the compositing updates until after the call to updateWidgetPositions(), so that this order is similar to what we done when a FrameView scrolls. This change has no known side effects. Second, if compositingConsultsOverlap() is true, we need to actually do a compositing layer update to compute whether revealed/hidden layers should be created/destroyed.
9:58 PM Changeset in webkit [58935] by barraclough@apple.com
  • 5 edits
    1 add in trunk/JavaScriptCore

Bug 38714 - Add result caching for Math.sin

Reviewed by Geoff Garen.

Math.sin is frequently called with the same operand, caching the result should
improve performance. CachedTranscendentalFunction adds a generic mechanism to
cache results for pure functions with the signature "double func(double)", and
where NaN maps to NaN.

CachedTranscendentalFunction uses a very simple hash function designed to be
fast to execute since we cannot cache the result, and trivial to JIT generate,
should we wish to do so.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/CachedTranscendentalFunction.h: Added.

(JSC::CachedTranscendentalFunction::CachedTranscendentalFunction):
(JSC::CachedTranscendentalFunction::~CachedTranscendentalFunction):
(JSC::CachedTranscendentalFunction::operator()):
(JSC::CachedTranscendentalFunction::initialize):
(JSC::CachedTranscendentalFunction::hash):

  • runtime/JSGlobalData.h:
  • runtime/MathObject.cpp:

(JSC::mathProtoFuncSin):

  • wtf/Platform.h:
9:51 PM Changeset in webkit [58934] by eric@webkit.org
  • 6 edits
    5 copies
    30 adds in trunk/WebKitTools

2010-05-06 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r58933.
​http://trac.webkit.org/changeset/58933
​https://bugs.webkit.org/show_bug.cgi?id=38717

"Broke all websocket tests on Tiger" (Requested by eseidel on
#webkit).

  • Scripts/new-run-webkit-websocketserver:
  • Scripts/old-run-webkit-tests:
  • Scripts/run-webkit-websocketserver:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/thirdparty/init.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/COPYING: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/MANIFEST.in: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/README: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/example/echo_client.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/example/echo_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/example/handler_map.txt: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/init.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/dispatch.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/handshake.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/msgutil.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/standalone.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/util.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/setup.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/config.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/mock.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/run_all.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_dispatch.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_handshake.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_memorizingfile.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_mock.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_msgutil.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_util.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/README: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/hello.pl: Added.
8:56 PM Changeset in webkit [58933] by ukai@chromium.org
  • 6 edits
    35 deletes in trunk/WebKitTools

2010-05-06 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by David Levin.

WebSocket: pywebsocket 0.5
​https://bugs.webkit.org/show_bug.cgi?id=38034

Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.

  • Scripts/new-run-webkit-websocketserver: Add --output-dir option.
  • Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
  • Scripts/run-webkit-websocketserver: Ditto.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
  • Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
  • Scripts/webkitpy/thirdparty/pywebsocket: Removed.
8:13 PM Changeset in webkit [58932] by Chris Jerdonek
  • 4 edits in trunk/WebKitTools

svn-apply now understands the Git diff "copy from" syntax when the
similarity index is 100%.

Reviewed by Daniel Bates.

​https://bugs.webkit.org/show_bug.cgi?id=38628

  • Scripts/VCSUtils.pm:
    • Adjusted parseGitDiffHeader() to parse the "copy from" and "similarity index" lines.
  • Scripts/svn-unapply:
    • Adjusted the patch() subroutine so that copies are recognized as file additions.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
    • Added unit tests for the cases of a copy with similarity index 100% and less than 100%.
7:58 PM Changeset in webkit [58931] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

7:58 PM Changeset in webkit [58930] by mrowe@apple.com
  • 1 copy in tags/Safari-533.8

New tag.

7:54 PM Changeset in webkit [58929] by Chris Jerdonek
  • 8 edits in trunk/WebKitTools

2010-05-06 Chris Jerdonek <Chris Jerdonek>

Reviewed by Daniel Bates.

Removed the need for svn-apply and -unapply to re-parse whether
a diff is binary or not.

​https://bugs.webkit.org/show_bug.cgi?id=38320

  • Scripts/VCSUtils.pm:
    • Adjusted parseGitDiffHeader() to set the isBinary key.
    • Adjusted parseSvnDiffHeader() to set the isBinary key.
    • Adjusted parseDiffHeader() to set the isBinary key.
    • Changed the scmFormat key set by parseDiffHeader() to isGit and isSvn keys.
    • Adjusted parseDiff() to set the isBinary, isGit, and isSvn keys.
  • Scripts/svn-apply:
    • Updated the patch() method to use the isBinary, isGit, and isSvn keys.
  • Scripts/svn-unapply:
    • Updated the patch() method to use the isBinary and isSvn keys.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Updated the unit tests as necessary.
    • Added a test case to test that the isBinary key is getting set properly.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
    • Updated the unit tests as necessary.
7:37 PM Changeset in webkit [58928] by dpranke@chromium.org
  • 6 edits
    2 moves
    2 adds in trunk/LayoutTests

2010-05-06 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, rebaseline and expectation changes from WK roll from a
few days ago.

  • platform/chromium-linux/http/tests/loading/bad-scheme-subframe-expected.txt: Copied from LayoutTests/platform/chromium-mac/http/tests/loading/bad-scheme-subframe-expected.txt.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-linux/svg/text/kerning-expected.checksum:
  • platform/chromium-linux/svg/text/kerning-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/editing/selection/caret-rtl-2-actual.checksum.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/selection/caret-rtl-2-actual.png.
  • platform/chromium-mac/svg/text/kerning-expected.checksum: Added.
  • platform/chromium/test_expectations.txt:
6:56 PM Changeset in webkit [58927] by tkent@chromium.org
  • 4 edits in trunk

2010-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add support for resources on Mac
​https://bugs.webkit.org/show_bug.cgi?id=38637

  • DEPS: Check out tools/data_pack.

2010-05-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add support for resources on Mac
​https://bugs.webkit.org/show_bug.cgi?id=38637

Repack webkit_chromium_resources.pak, webkit_strings_en-US.pak,
and webkit_resources.pak, and put them as Mac bundle resource.
The 'actions' section is almost same as a part of test_shell.gypi.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
6:29 PM Changeset in webkit [58926] by dpranke@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-06 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, rebaseline a chromium test.

Need a linux baseline for fast/notifications/notifications-replace-expected.txt to override the windows version.

  • platform/chromium-linux/fast/notifications/notifications-replace-expected.txt: Added.
5:47 PM Changeset in webkit [58925] by mjs@apple.com
  • 2 edits in trunk/WebCore

Not reviewed, build fix.

Try again - with quotes this time. *facepalm*

  • dom/Notation.cpp:
5:39 PM Changeset in webkit [58924] by mjs@apple.com
  • 2 edits in trunk/WebCore

Not reviewed, build fix.

Speculative fix for Qt and Gtk.

  • dom/Notation.cpp:
5:34 PM BuildingQtOnWindows edited by Laszlo Gombos
few words on how to generate MSVC project files (diff)
5:25 PM Changeset in webkit [58923] by mjs@apple.com
  • 2 edits in trunk/WebCore

Not reviewed, build fix.

Fix an assert that I failed to update in my earlier change.

  • dom/CharacterData.h:

(WebCore::CharacterData::CharacterData):

5:03 PM Changeset in webkit [58922] by ap@apple.com
  • 4 edits
    2 adds in trunk

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=38697
REGRESSION (r58299): Replying on reddit.com no longer works

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Don't recognize :first, :left and :right. The aren't allowed in all contexts, and properly implementing them is out of scope for this regression fix.
5:01 PM Changeset in webkit [58921] by jianli@chromium.org
  • 11 edits in trunk/WebCore

Improve code generator scripts to support converting ScriptString.
​https://bugs.webkit.org/show_bug.cgi?id=38699

Reviewed by Adam Barth.

Change both JSC and V8 generators to introduce "ConvertScriptString"
attribute to allow converting from ScriptString. Also updated the
bindings test result.

These changes are necessary in order to avoid adding custom binding codes
when we add the FileReader interface.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_script_string_attr):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::):
(WebCore::jsTestObjScriptStringAttr):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj scriptStringAttr]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::scriptStringAttrAttrGetter):
(WebCore::):

4:45 PM Changeset in webkit [58920] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

[Qt] Unreviewed buildfix after r58917.

  • DumpRenderTree/qt/LayoutTestControllerQt.h: Missing function declaration added.
4:33 PM Changeset in webkit [58919] by jianli@chromium.org
  • 4 edits
    11 adds in trunk/WebCore

Improve code generator scripts to pass additional ScriptExecutionContext
argument to the constructor.
​https://bugs.webkit.org/show_bug.cgi?id=38687

Reviewed by Adam Barth.

Change both JSC and V8 generators to introduce "CallWith=ScriptExecutionContext"
attribute to allow passing the additional ScriptExecutionContext argument to
the constructor. Also add another test IDL file to test interface-level
features.

These changes are necessary in order to avoid adding custom binding codes
when we add the FileReader interface.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h: Added.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Added.
  • bindings/scripts/test/JS/JSTestInterface.h: Added.
  • bindings/scripts/test/ObjC/DOMTestInterface.h: Added.
  • bindings/scripts/test/ObjC/DOMTestInterface.mm: Added.
  • bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h: Added.
  • bindings/scripts/test/TestInterface.idl: Added.
  • bindings/scripts/test/V8/V8TestInterface.cpp: Added.
  • bindings/scripts/test/V8/V8TestInterface.h: Added.
  • bindings/v8/V8Proxy.h:

(WebCore::V8Proxy::constructDOMObjectWithScriptExecutionContext):

4:23 PM Changeset in webkit [58918] by mjs@apple.com
  • 2 edits in trunk/WebCore

Build fix, not reviewed.

Speculative Windows and Debug build fixes for the last change.

  • dom/Node.h:

(WebCore::Node::inDocument):
(WebCore::Node::setFlag):

4:23 PM Changeset in webkit [58917] by andersca@apple.com
  • 14 edits
    2 adds in trunk

2010-05-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler and Dan Bernstein..

REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
​https://bugs.webkit.org/show_bug.cgi?id=38698
<rdar://problem/7942075>

When the plug-in database is initialized, we will register all the MIME types it supports with the global
WebView dictionary. When plug-ins are disabled for a single web view, the MIME types still need to be
in the global mapping (because other web views might still have plug-ins enabled).


Prior to r51617 we would always look at the plug-in database to determine that the MIME type belongs to a
plug-in, but now we won't even touch the plug-in database when plug-ins are disabled.


In order to fix this, a new set of registered MIME types that are known to be plug-ins is added. When
+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:] is called and allowingPlugins is FALSE
we check if the MIME type is a known plug-in MIME type and return false in that case.


  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
  • WebView/WebView.mm: (knownPluginMIMETypes): (+[WebView _registerPluginMIMEType:]): (+[WebView _unregisterPluginMIMEType:]): (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
  • WebView/WebViewInternal.h:

2010-05-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler and Dan Bernstein..

REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
​https://bugs.webkit.org/show_bug.cgi?id=38698
<rdar://problem/7942075>

Add tests.

  • platform/mac/plugins/disable-plugins-expected.txt: Added.
  • platform/mac/plugins/disable-plugins.html: Added.

2010-05-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler and Dan Bernstein..

REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
​https://bugs.webkit.org/show_bug.cgi?id=38698
<rdar://problem/7942075>

Add a 'setPluginsEnabled' layoutTestController function for disabling plug-ins. This is only implemented on Mac currently
because the bug that needs this functionality is mac specific.

  • DumpRenderTree/LayoutTestController.cpp: (setPluginsEnabledCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setPluginsEnabled):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setPluginsEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setPluginsEnabled):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setPluginsEnabled):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setPluginsEnabled):
4:18 PM Changeset in webkit [58916] by jamesr@google.com
  • 10 edits in trunk/WebCore

2010-05-06 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
​https://bugs.webkit.org/show_bug.cgi?id=38158

Fixes:

  • replace NULL with 0
  • remove unusued locals
add parens around ambiguous looking compound predicates like (a
b && c)

This also adds a check for x >= 0 to FontLinux.cpp's in this statement:

if (x < walker.width())

This is more documentation than anything else since walker.width() returns
an unsigned the current behavior is that x is promoted to unsigned and as
long as x + walker.width() is less than 231 all negative values of x
end up wrapping around and not being < walker.width(). This behavior is
tested by fast/text/international/khmer-selection.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::adjustTextRenderMode): (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::length): (WebCore::TextRunWalker::width): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::isCoordinateSkiaSafe): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
3:53 PM Changeset in webkit [58915] by adachan@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=38695

Reviewed by David Kilzer.

Check the result from widget() for NULL before accessing it.

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::calcHeight):
(WebCore::RenderIFrame::calcWidth):

3:41 PM Changeset in webkit [58914] by mjs@apple.com
  • 44 edits in trunk/WebCore

2010-05-06 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

further fixes towards REGRESSION (r57292): 1% PLT regression from visited link information leak fix
​https://bugs.webkit.org/show_bug.cgi?id=38682
<rdar://problem/7859794>

Looks like a 1-2% speedup on PLT.

  • Reorder CSS properties.
  • Remove short circuit tag check in matchRulesForList which costs more than it saves.
  • Inline initForStyleResolve.
  • Optimize applyDeclarations to avoid switch and take fewer branches in the inner loop.


  • Change the way Node handles flags - replace bitfield with a uint32_t and explicit masking, to make it cheaper to initialize the bits and give faster access.
  • Added new Node flags to check for isStyledElement, isHTMLElement, isSVGElement, isComment, and devirtualize those methods.
  • Inline constructors for Node, Element, Text, CharacterData, StyledElement, etc since they are very simple and lots of nodes get constructed.


  • css/CSSPropertyNames.in: Move a few of the properties up front so we can check for them with < instead of switch statements
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): Remove unnecessary preflight check for tag match before checking selector. This check very rarely short circuits anything, since most rules with a tag end up in the appropriate tag bucket. So doing the check cost more time than the time saved. (WebCore::CSSStyleSelector::initForStyleResolve): Inline. Create RenderStyle in a better way. (WebCore::CSSStyleSelector::applyDeclarations): Get rid of switch statement and use <= to check for the high priority properties. Convert to template to avoid checking "applyFirst" each time through the loop. (WebCore::CSSStyleSelector::styleForElement): Adjust for new applyDeclarations() signature. (WebCore::CSSStyleSelector::keyframeStylesForAnimation): ditto (WebCore::CSSStyleSelector::pseudoStyleForElement): ditto
  • css/CSSStyleSelector.h: Adjust for new applyDeclarations() signature.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle): Inline constructor.
  • rendering/style/RenderStyle.h: Make constructor private so it can be inline.
  • dom/Node.h: (WebCore::): See high-level description of changes above. Redid the way boolean flags work. (WebCore::Node::isElementNode): (WebCore::Node::isContainerNode): (WebCore::Node::isTextNode): (WebCore::Node::isHTMLElement): (WebCore::Node::isSVGElement): (WebCore::Node::isStyledElement): (WebCore::Node::isCommentNode): (WebCore::Node::hasID): (WebCore::Node::hasClass): (WebCore::Node::active): (WebCore::Node::inActiveChain): (WebCore::Node::inDetach): (WebCore::Node::hovered): (WebCore::Node::attached): (WebCore::Node::setAttached): (WebCore::Node::needsStyleRecalc): (WebCore::Node::styleChangeType): (WebCore::Node::childNeedsStyleRecalc): (WebCore::Node::isLink): (WebCore::Node::setHasID): (WebCore::Node::setHasClass): (WebCore::Node::setChildNeedsStyleRecalc): (WebCore::Node::clearChildNeedsStyleRecalc): (WebCore::Node::setInDocument): (WebCore::Node::clearInDocument): (WebCore::Node::setInActiveChain): (WebCore::Node::clearInActiveChain): (WebCore::Node::setIsLink): (WebCore::Node::clearIsLink): (WebCore::Node::setActive): (WebCore::Node::setHovered): (WebCore::Node::inDocument): (WebCore::Node::): (WebCore::Node::getFlag): (WebCore::Node::setFlag): (WebCore::Node::clearFlag): (WebCore::Node::hasRareData): (WebCore::Node::isParsingChildrenFinished): (WebCore::Node::setIsParsingChildrenFinished): (WebCore::Node::clearIsParsingChildrenFinished): (WebCore::Node::isStyleAttributeValid): (WebCore::Node::setIsStyleAttributeValid): (WebCore::Node::clearIsStyleAttributeValid): (WebCore::Node::isSynchronizingStyleAttribute): (WebCore::Node::setIsSynchronizingStyleAttribute): (WebCore::Node::clearIsSynchronizingStyleAttribute): (WebCore::Node::areSVGAttributesValid): (WebCore::Node::setAreSVGAttributesValid): (WebCore::Node::clearAreSVGAttributesValid): (WebCore::Node::isSynchronizingSVGAttributes): (WebCore::Node::setIsSynchronizingSVGAttributes): (WebCore::Node::clearIsSynchronizingSVGAttributes): (WebCore::Node::hasRareSVGData): (WebCore::Node::setHasRareSVGData): (WebCore::Node::clearHasRareSVGData): (WebCore::Node::initialRefCount):
  • dom/Node.cpp: (WebCore::Node::trackForDebugging): Adjusted for changes in flag handling. (WebCore::Node::ensureRareData): ditto (WebCore::Node::setStyleChange): ditto (WebCore::Node::setNeedsStyleRecalc): ditto (WebCore::Node::lazyAttach): ditto (WebCore::Node::attach): ditto (WebCore::Node::detach): ditto (WebCore::Node::insertedIntoDocument): ditto (WebCore::Node::removedFromDocument): ditto
  • dom/CharacterData.cpp:
  • dom/CharacterData.h: (WebCore::CharacterData::CharacterData): Inline the constructor (moved from .cpp)
  • dom/Comment.cpp: (WebCore::Comment::Comment): Tell the base class that we're a comment.
  • dom/Comment.h: Remove isCommentNode override.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::detach): Adjusted for changes in flag handling. (WebCore::ContainerNode::removedFromDocument): ditto
  • dom/Document.cpp: (WebCore::Document::Document): Adjusted for changes in flag handling. (WebCore::Document::recalcStyle): ditto (WebCore::Document::setFocusedNode): ditto
  • dom/Document.h: (WebCore::Node::Node): Inline the Node constructor - goes here because it uses Document.
  • dom/DocumentFragment.cpp: include Document.h due to above change
  • dom/EditingText.cpp: ditto
  • dom/EntityReference.cpp: ditto
  • dom/Element.cpp: (WebCore::Element::getAttribute): Adjusted for changes in flag handling. (WebCore::Element::setAttribute): ditto (WebCore::Element::hasAttributes): ditto (WebCore::Element::recalcStyle): ditto (WebCore::Element::finishParsingChildren): ditto
  • dom/Element.h: (WebCore::Element::Element): Inline (moved from .cpp) (WebCore::Element::isFinishedParsingChildren): (WebCore::Element::beginParsingChildren): (WebCore::Element::attributes): Adjusted for changes in flag handling.
  • dom/StyledElement.cpp: (WebCore::StyledElement::updateStyleAttribute): Adjust for changes to flag handling. (WebCore::StyledElement::mapToEntry): ditto (WebCore::StyledElement::parseMappedAttribute): ditto (WebCore::StyledElement::copyNonAttributeProperties): ditto
  • dom/StyledElement.h: (WebCore::StyledElement::StyledElement): Inline (moved from.cpp) (WebCore::StyledElement::invalidateStyleAttribute): Adjust for changes in flag handling.
  • dom/Text.h: (WebCore::Text::Text): Inline (moved from .cpp)
  • dom/Text.cpp:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): Adjust for changes in flag handling. (WebCore::HTMLAnchorElement::parseMappedAttribute): ditto
  • html/HTMLElement.cpp: (WebCore::HTMLElement::create): Tell base class we're an HTML element.
  • html/HTMLElement.h: ditto above; remove isHTMLElement override.
  • html/HTMLFormControlElement.h: Tell base class we're an HTML element.
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): ditto
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::HTMLProgressElement): ditto
  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement): Tell base class we're a styled element.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): Adjust for changes in flag handling. (WebCore::MediaControlElement::MediaControlElement): ditto (WebCore::MediaControlInputElement::MediaControlInputElement): ditto
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement): ditto
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateHoverActiveState): ditto
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::updateValuePartState): ditto
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement): ditto
  • rendering/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): ditto
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): ditto
  • svg/SVGAnimatedProperty.h: (WebCore::SVGAnimatedPropertyTearOff::setBaseVal): ditto (WebCore::SVGAnimatedPropertyTearOff::setAnimVal): ditto
  • svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): Tell base class we're an svg element. (WebCore::SVGElement::ensureRareSVGData): Adjust for flag handling changes. (WebCore::SVGElement::updateAnimatedSVGAttribute): ditto
  • svg/SVGElement.h: (WebCore::SVGElement::invalidateSVGAttributes): ditto
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged): ditto
  • wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::WMLAnchorElement): ditto
  • wml/WMLElement.cpp: (WebCore::WMLElement::WMLElement): Tell base class we're a styled element.
3:28 PM Changeset in webkit [58913] by mitz@apple.com
  • 4 edits in trunk/WebKit/mac

<rdar://problem/7951285> REGRESSION (r58847): Composited iframe content obscures Safari's application chrome

Reviewed by Simon Fraser.

Fixed this other regression from r58847. The regression was caused by overriding -visibleRect to
return the WebClipView’s full bounds. AppKit uses -visibleRect to determine the geometry
of the surface for the child WebFrameView. The fix is to restrict the special behavior of
-[WebClipView visibleRect] to when AppKit is consulting it for the purpose of invalidating
areas while scrolling.

  • WebView/WebClipView.h:
  • WebView/WebClipView.mm:

(-[WebClipView visibleRect]): If the WebClipView is not scrolling, always return
[super visibleRect].
(-[WebClipView _immediateScrollToPoint:]): Override this internal NSClipView method
to set a flag telling -visibleRect that the view is scrolling.

  • WebView/WebView.mm:

(layerSyncRunLoopObserverCallBack): Ensure that screen updates, disabled by AppKit
when it thinks an upcoming window flush will re-enable them, are enabled here in
case the -setNeedsDisplayInRect: override has prevented the window from needing to be
flushed.

3:28 PM Changeset in webkit [58912] by johnnyg@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-06 John Gregg <​johnnyg@google.com>

Unreviewed, rebaseline for chromium test.

[chromium] Deal with different local path structure on windows.

  • platform/chromium-win/fast/notifications: Added.
  • platform/chromium-win/fast/notifications/notifications-replace-expected.txt: Added.
3:19 PM Changeset in webkit [58911] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix.

  • bytecode/SamplingTool.cpp:

(JSC::SamplingFlags::sample): Use a cast, so Windows will be happy when
this code is enabled.

  • wtf/Platform.h: Reverted last change to this file, which seems to have

been accidental.

3:12 PM Changeset in webkit [58910] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-05-06 Adam Barth <​abarth@webkit.org>

Unreviewed. Fix indent. Sorry, my OCD was acting up.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):
3:09 PM Changeset in webkit [58909] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-06 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations fix.

Delete a line for a test that is no longer failing on chromium linux.

  • platform/chromium/test_expectations.txt:
2:20 PM BuildingQtOnSymbian edited by Laszlo Gombos
(diff)
1:50 PM Changeset in webkit [58908] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: store selected Headers / Content tab on explicit switch and/or explicit navigate only.

​https://bugs.webkit.org/show_bug.cgi?id=38660

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectHeadersTab): (WebInspector.ResourceView.prototype.selectContentTab):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource):
1:47 PM Changeset in webkit [58907] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Add compile switch to make debugger keyword plant breakpoint instructions.

Reviewed by Oliver Hunt.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_debug):

  • wtf/Platform.h:
1:38 PM Changeset in webkit [58906] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-06 Luiz Agostini <​luiz.agostini@openbossa.org>

Rubber-stamped by Simon Hausmann.

[Qt] use QT_MOBILE_THEME in Symbian
​https://bugs.webkit.org/show_bug.cgi?id=38440

Putting QT_MOBILE_THEME into use for Symbian.

  • WebCore.pro:
1:26 PM Changeset in webkit [58905] by eric@webkit.org
  • 3 edits
    1 move in trunk/WebCore

2010-05-06 Laszlo Gombos <Laszlo Gombos>

Unreviewed, build fix WinCE for QtWebKit.

[Qt] Compilation with Plugins disabled is broken
​https://bugs.webkit.org/show_bug.cgi?id=31407

Rename platform/qt/TemporaryLinkStubs.cpp to avoid name collition on
Windows.

Thanks for Ismail "cartman" Donmez for help.

No new tests, as there is no new functionality.

  • WebCore.gypi:
  • WebCore.pro:
  • platform/qt/TemporaryLinkStubs.cpp: Removed.
  • platform/qt/TemporaryLinkStubsQt.cpp: Copied from WebCore/platform/qt/TemporaryLinkStubs.cpp.
1:04 PM Changeset in webkit [58904] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix ARM builds

1:01 PM Changeset in webkit [58903] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-06 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] REGRESSION: Loading of external CSS and JS files over network fails in some cases
​https://bugs.webkit.org/show_bug.cgi?id=36755

Enable the direct connection between QtNetwork and QtWebKit only for Qt versions
greater than 4.6.2, due to a bug in Qt that's been fixed after 4.6.2.

  • platform/network/qt/QNetworkReplyHandler.cpp:
12:39 PM Changeset in webkit [58902] by oliver@apple.com
  • 14 edits
    9 adds in trunk

2010-05-06 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Improve performance of single character string compares
​https://bugs.webkit.org/show_bug.cgi?id=38659

Add logic to the jit to identify comparisons to single character string literals
and then just perform the comparison inline, rather than ignoring the evidence
and attempting to perform an integer comparison.

Multiple changes required -- add jnlesseq opcode, add helper function to identify
single character string constants, add a helper to load single character strings.
Then add the 32_64 and normal codepaths to the JIT.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::load16):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpIfTrue):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jlesseq): (JSC::JIT::emitSlow_op_jnlesseq):
  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emitBinaryDoubleOp):
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadCharacterString): (JSC::JIT::isOperandConstantImmediateChar):
  • jit/JSInterfaceJIT.h: (JSC::ThunkHelpers::stringImplDataOffset): (JSC::ThunkHelpers::jsStringLengthOffset): (JSC::ThunkHelpers::jsStringValueOffset): Moved from ThunkGenerators to make it possible to share.
  • jit/ThunkGenerators.cpp:

2010-05-06 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Improve performance of single character string compares
​https://bugs.webkit.org/show_bug.cgi?id=38659

Add many tests of <, >, <=, >=, ==, ===, !=, !== as the existing
tests were woefully inadequate.

  • fast/js/comparison-operators-expected.txt: Added.
  • fast/js/comparison-operators-greater-expected.txt: Added.
  • fast/js/comparison-operators-greater.html: Added.
  • fast/js/comparison-operators-less-expected.txt: Added.
  • fast/js/comparison-operators-less.html: Added.
  • fast/js/comparison-operators.html: Added.
  • fast/js/script-tests/comparison-operators-greater.js: Added. (description.makeTest.func.f.toString): (description.makeTest): (doTest):
  • fast/js/script-tests/comparison-operators-less.js: Added. (description.makeTest.func.f.toString): (description.makeTest): (doTest):
  • fast/js/script-tests/comparison-operators.js: Added. (description.makeTest.func.f.toString): (description.makeTest): (doTest):
12:06 PM Changeset in webkit [58901] by Martin Robinson
  • 6 edits in trunk/WebKit/gtk

2010-05-06 Martin Robinson <Martin Robinson>

Reviewed by Xan Lopez.

Remove use of GOwnPtr to hold GObject types.
​https://bugs.webkit.org/show_bug.cgi?id=38669

Change use of GOwnPtr to GRefPtr to types which are natively reference-counted.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): Change GOwnPtr to GRefPtr in some places. (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto.
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_new_with_core_request): Ditto.
  • webkit/webkitnetworkresponse.cpp: (webkit_network_response_new_with_core_response): Ditto.
  • webkit/webkitprivate.cpp: Remove GOwnPtr reference counting template specialization.
  • webkit/webkitprivate.h: Ditto.
11:50 AM Changeset in webkit [58900] by Adam Roben
  • 2 edits in trunk/WebKit/win

2010-05-06 Adam Roben <Adam Roben>

Bail out of WebView::paint when there's nothing to paint

Fixes <​http://webkit.org/b/38670> <rdar://problem/7947105> REGRESSION
(r58067): Crash in WebView::paint when Web Inspector is docked and
window is resized so small that WebView disappears

When the WebView is 0-sized, ensureBackingStore() bails out without
creating a bitmap, leaving m_backingStoreBitmap null. Before r58067,
m_backingStoreBitmap was an HBITMAP, so we were happily passing along
a null HBITMAP to various Windows APIs. These calls would fail but not
crash. r58067 changed m_backingStoreBitmap to a RefCountedHBITMAP, and
dereferencing a null RefCountedHBITMAP* of course crashes.

Reviewed by Steve Falkenburg.

  • WebView.cpp: (WebView::paint): Bail if the rect to paint is empty.
11:47 AM Changeset in webkit [58899] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

2010-05-06 John Gregg <​johnnyg@google.com>

Unreviewed. Updating test expectations.

[chromium] enabling notifications tests after test_shell change.

  • platform/chromium/test_expectations.txt:
11:46 AM Changeset in webkit [58898] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-05-06 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Rework where we get page step and line step from, so we do not
depend on scrollbars existing. Caught by API test I forgot to run.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
10:47 AM Changeset in webkit [58897] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-05-06 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Adjustment resetting uses wrong values, and misses page_size and steps
​https://bugs.webkit.org/show_bug.cgi?id=38657

Fix resetting adjustment values. In the page cache case, we were
confusing page_size and upper, leading to stray scrollbars
sometimes.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
10:42 AM Changeset in webkit [58896] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-05-06 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

editing/selection/shift-click.html fails on GTK and QT
​https://bugs.webkit.org/show_bug.cgi?id=38656

r58892 added this test. It's the first test for shift+click behavior,
so it exposed bugs in GTK/QT. Skipping to green the bots.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
10:37 AM Changeset in webkit [58895] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2010-05-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

WebFrame::paintDocumentRectToContext paints content at the wrong location
​https://bugs.webkit.org/show_bug.cgi?id=38651

  • WebFrame.cpp: (WebFrame::paintDocumentRectToContext):
10:12 AM Changeset in webkit [58894] by Darin Adler
  • 2 edits in trunk/WebCore

2010-05-06 Darin Adler <Darin Adler>

Reviewed by Beth Dakin.

Page::setCanStartMedia does not properly handle the case where a media listener is removed
​https://bugs.webkit.org/show_bug.cgi?id=38602

We can't find any real case where this causes a crash at this time, but
we want to harden the code anyway. Thus there are no new regression tests.

  • page/Page.cpp: (WebCore::Page::removeMediaCanStartListener): Removed incorrect assertion. (WebCore::Page::setCanStartMedia): Change algorithm so we notify listeners one at a time and don't notify any listener that has already been removed from the set.
10:05 AM Changeset in webkit [58893] by evan@chromium.org
  • 9 edits in trunk/LayoutTests

2010-05-06 Evan Martin <​evan@chromium.org>

Unreviewed. Updating test expectations.

[chromium] new baselines for r58886
​https://bugs.webkit.org/show_bug.cgi?id=38652

  • platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.txt:
  • platform/chromium-linux/fast/text/international/danda-space-expected.checksum:
  • platform/chromium-linux/fast/text/international/danda-space-expected.png:
  • platform/chromium-linux/fast/text/international/danda-space-expected.txt:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt:
  • platform/chromium/test_expectations.txt:
9:58 AM Changeset in webkit [58892] by ojan@chromium.org
  • 3 edits
    4 adds in trunk

2010-05-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

shift+click on an existing selection doesn't work right
​https://bugs.webkit.org/show_bug.cgi?id=36542

NSTextView behavior is to move the end of the selection
closest to the shift-click. Win/Linux behavior is to always
move the focus end of the selection.

  • editing/selection/script-tests/shift-click.js: Added. (shiftClick): (assertSelectionString):
  • editing/selection/shift-click-expected.txt: Added.
  • editing/selection/shift-click.html: Added.
  • platform/win/editing/selection/shift-click-expected.txt: Added.

2010-05-05 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

shift+click on an existing selection doesn't work right
​https://bugs.webkit.org/show_bug.cgi?id=36542

NSTextView behavior is to move the end of the selection
closest to the shift-click. Win/Linux behavior is to always
move the focus end of the selection.

Test: editing/selection/shift-click.html

  • page/EventHandler.cpp: (WebCore::textDistance): (WebCore::EventHandler::handleMousePressEventSingleClick):
9:53 AM Changeset in webkit [58891] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-05-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: implement panels history traversal on Cmd+Left/Right.

​https://bugs.webkit.org/show_bug.cgi?id=38649

9:49 AM Changeset in webkit [58890] by pfeldman@chromium.org
  • 4 edits in trunk

2010-05-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Chromium Dev Tools: Large toolbar icons flash when dev
tools is opened in docked mode.

​https://bugs.webkit.org/show_bug.cgi?id=38631

  • src/js/DevTools.js: (devtools.domContentLoaded):
9:46 AM Changeset in webkit [58889] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-06 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Dimitri Glazkov.

Make ImageDiff depend on WebKit. When compiled from within Chromium, WTF is not a standalone dynamic library but depends on WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=38632

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
9:43 AM Changeset in webkit [58888] by tonikitoo@webkit.org
  • 4 edits
    4 deletes in trunk/LayoutTests

2010-05-05 Antonio Gomes <​tonikitoo@webkit.org>

Rubber-stamped by Kenneth Christiansen.

Spatial Navigation: use data url in layout tests
​https://bugs.webkit.org/show_bug.cgi?id=38584

In order to make Spatial Navigation layout tests more readable, patch
changes the use or src=resources/iframeXXX.html by inlined sources via
data uri schema.

It is a polishment.

  • fast/events/spatial-navigation/resources/iframe.html: Removed.
  • fast/events/spatial-navigation/resources/iframe2.html: Removed.
  • fast/events/spatial-navigation/resources/iframe3.html: Removed.
  • fast/events/spatial-navigation/resources/iframe4.html: Removed.
  • fast/events/spatial-navigation/snav-iframe-no-focusable-content.html:
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
  • fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:
9:42 AM Changeset in webkit [58887] by tonikitoo@webkit.org
  • 1 edit in trunk/LayoutTests/platform/gtk/Skipped

2010-05-06 Antonio Gomes <​tonikitoo@webkit.org>

[Gtk] Skipped fast/events/spatial-navigation/snav-iframe-flattening-simple.html

DRT does not support frame flattening testing.
​https://bugs.webkit.org/show_bug.cgi?id=38650

  • platform/gtk/Skipped:
9:34 AM Changeset in webkit [58886] by evan@chromium.org
  • 2 edits in trunk/WebCore

2010-05-03 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

[chromium] use glyphDataForCharacter so we hit the glyphdata cache
​https://bugs.webkit.org/show_bug.cgi?id=38500

Calling fontDataForCharacters() while rendering text is expensive.
Examining the relevant Mac code in WebKit revealed that calling the
similarly-named glyphDataForCharacters() results in caching the font
data on a per-glyph basis.

Since we now choose a font based on the first character in a run, we
need to be careful that all the glyphs within the run use the same font.
This is also similar to the WebKit Mac code. We need to remove all of
the script run bits eventually and this is a step in that direction.

Tests: fast/text/international/danda-space.html spacing changes slightly
(now matches Firefox better) and fast/text/international/thai-baht-space.html
now picks the correct (serif) font for the digits.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::setupFontForScriptRun):
9:32 AM Changeset in webkit [58885] by Martin Robinson
  • 11 edits in trunk

2010-05-06 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Convert dragging portion of drag-and-drop to use DataObjectGtk.

  • wtf/gobject/GRefPtr.h: Add forward declarations for GObject functions.

2010-05-06 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Convert dragging portion of drag-and-drop to use DataObjectGtk.

No new tests, because functionality has not changed.

  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::createDraggingClipboard): Pass the DataObjectGtk as a parameter here.
  • platform/gtk/ClipboardGtk.h: (WebCore::ClipboardGtk::create): Take the DataObject as a parameter instead of creating it here. (WebCore::ClipboardGtk::helper): Added. (WebCore::ClipboardGtk::dataObject): Added.
  • platform/gtk/PasteboardHelper.h: Make targetListForDataObject a public method.

2010-05-06 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Convert dragging portion of drag-and-drop to use DataObjectGtk.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::willPerformDragDestinationAction): Remove the notImplemented. It is implemented, it's just a no-op. (WebKit::DragClient::startDrag): Start the drag context via the ClipboardGtk and PasteboardHelper now.
  • WebCoreSupport/DragClientGtk.h: Small style fix.
  • webkit/webkitprivate.h: Add a HashMap of contexts and DataObjects here to to represent all current drag operations.
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose): Clear all data objects during disposal. (webkit_web_view_drag_end): When a drag is over, just remove it from the map. (webkit_web_view_drag_data_get): To get the drag data, just grab it from the DataObject.
9:30 AM Changeset in webkit [58884] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-05-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not show content tab for resources
not supporting content preview.

​https://bugs.webkit.org/show_bug.cgi?id=38635

  • English.lproj/localizedStrings.js:
  • inspector/front-end/FontView.js: (WebInspector.FontView.prototype.hasContentTab):
  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.hasContentTab):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype.hasContentTab):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hasContentTab):
9:23 AM Changeset in webkit [58883] by tonikitoo@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-05 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

Spatial Navigation: Add LayoutTest with frame flattening feature on.
​https://bugs.webkit.org/show_bug.cgi?id=38585

  • fast/events/spatial-navigation/snav-iframe-flattening-simple-expected.txt: Added.
  • fast/events/spatial-navigation/snav-iframe-flattening-simple.html: Added.
9:17 AM Changeset in webkit [58882] by tonikitoo@webkit.org
  • 3 edits in trunk/WebCore

2010-05-06 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

Spatial Navigation: adapt the logic of {deep}findFocusableNodeInDirection to do traversal starting from Node* not Document*
​https://bugs.webkit.org/show_bug.cgi?id=37803

Instead of receiving a Document pointer as incoming parameter, patch modifies
findFocusableNodeInDirection and deepFindFocusableNodeInDirection methods to
receive a Node pointer as start for content traversal.
This way we can make good use of deepFindFocusableNodeInDirection to traverse
other scrollable container like scrollable div's, and not only frames or iframes.

Patch also makes use of 'while' instead of 'for' to loop control, that gives move
flexibility to the incremental step: e.g. if a scrollable div was processed, the incremental
step in the loop does not have to do node->traverseNextNode() but node->traverseNextSibling().

No behavior change. It is a preparation for supporting scrollable containers in Spatial
Navigation.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionally): (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):
  • page/FocusController.h:
9:04 AM Changeset in webkit [58881] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

Unreviewed WinCE buildfix after r58842.
Preprocessor doesn't understand "true", changed to "1"

  • platform/graphics/MediaPlayer.cpp:
8:31 AM Changeset in webkit [58880] by mnaganov@chromium.org
  • 2 edits in trunk/WebCore

2010-05-06 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Temporarily disable 'console.profiles' until we can distinguish
functions from different frames

​https://bugs.webkit.org/show_bug.cgi?id=38638

  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::profilesAccessorGetter):
8:13 AM Changeset in webkit [58879] by vitalyr@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

2010-05-06 Vitaly Repeshko <​vitalyr@chromium.org>

[chromium] Unreviewed. Updating expectations.

  • platform/chromium-linux/fast/url/segments-expected.txt: Added.
  • platform/chromium-linux/fast/url/segments-from-data-url-expected.txt: Added.
  • platform/chromium-mac/fast/url/segments-expected.txt: Added.
  • platform/chromium-mac/fast/url/segments-from-data-url-expected.txt: Added.
  • platform/chromium-win/fast/url/segments-expected.txt: Added.
  • platform/chromium-win/fast/url/segments-from-data-url-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
7:12 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
7:09 AM Changeset in webkit [58878] by eric@webkit.org
  • 26 edits in trunk

2010-05-06 Steve Block <​steveblock@google.com>

Reviewed by Eric Seidel.

MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
​https://bugs.webkit.org/show_bug.cgi?id=38544

  • wtf/Platform.h:

2010-05-06 Steve Block <​steveblock@google.com>

Reviewed by Eric Seidel.

MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
​https://bugs.webkit.org/show_bug.cgi?id=38544

No new tests, build fix only.

  • DerivedSources.make:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
  • bridge/jni/JNIBridge.cpp:
  • bridge/jni/JNIBridge.h:
  • bridge/jni/JNIUtility.cpp:
  • bridge/jni/JNIUtility.h:
  • bridge/jni/jni_jsobject.h:
  • bridge/jni/jni_jsobject.mm:
  • bridge/jni/jni_objc.mm:
  • bridge/jni/jsc/JNIBridgeJSC.cpp:
  • bridge/jni/jsc/JNIBridgeJSC.h:
  • bridge/jni/jsc/JNIUtilityPrivate.cpp:
  • bridge/jni/jsc/JNIUtilityPrivate.h:
  • bridge/jni/jsc/JavaClassJSC.cpp:
  • bridge/jni/jsc/JavaClassJSC.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
  • bridge/jni/jsc/JavaInstanceJSC.h:
  • loader/FrameLoaderClient.h:

2010-05-06 Steve Block <​steveblock@google.com>

Reviewed by Eric Seidel.

MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
​https://bugs.webkit.org/show_bug.cgi?id=38544

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
6:12 AM Changeset in webkit [58877] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-06 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Patch to fix compilation warnings for QGraphicsWebView
​https://bugs.webkit.org/show_bug.cgi?id=37428

Patch by Alexis Menard <​alexis.menard@nokia.com>

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::itemChange):
6:00 AM Changeset in webkit [58876] by eric@webkit.org
  • 8 edits in trunk

2010-05-06 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Replace public inspector url with private property for QtLauncher
​https://bugs.webkit.org/show_bug.cgi?id=35340

Replace the public API with a private dynamic property until this feature
is ready.

  • Api/qwebsettings.cpp:
  • Api/qwebsettings.h:
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
  • symbian/bwins/QtWebKitu.def:
  • symbian/eabi/QtWebKitu.def:

2010-05-06 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Replace public inspector url with private property for QtLauncher
​https://bugs.webkit.org/show_bug.cgi?id=35340

Replace the public API with a private dynamic property until this feature
is ready.

  • QtLauncher/main.cpp: (LauncherWindow::init):
2:44 AM Changeset in webkit [58875] by alex
  • 4 edits in trunk

2010-05-05 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Fixed the gobject introspection compilation with the new DOM
bindings, we needed to add DOM objects.

  • GNUmakefile.am:
2:31 AM Changeset in webkit [58874] by eric@webkit.org
  • 2 edits
    2 adds in trunk/JavaScriptCore

2010-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

[WTFURL] Add a class to represent the segments of a URL
​https://bugs.webkit.org/show_bug.cgi?id=38566

When paired with a string, this class represents a parsed URL.

  • wtf/url/src/URLSegments.cpp: Added. (WTF::URLSegments::length): (WTF::URLSegments::charactersBefore):
  • wtf/url/src/URLSegments.h: Added. (WTF::URLSegments::): (WTF::URLSegments::URLSegments):
  • wtf/url/wtfurl.gyp:
2:19 AM Changeset in webkit [58873] by eric@webkit.org
  • 11 edits in trunk

2010-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

drop support for sessionStorage in sandbox iframes
​https://bugs.webkit.org/show_bug.cgi?id=38151

Update test expectation. This test was originally created to show that
we complied with the letter of the spec, but our behavior is insecure.
In the future, we might revert this change and implement a separate
storage area for each unique origin.

  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-storage-expected.txt:

2010-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

drop support for sessionStorage in sandbox iframes
​https://bugs.webkit.org/show_bug.cgi?id=38151

This patch causes us to throw a security exception when a sandboxed
iframe attempts to access sessionStorage, matching our behavior for
localStorage. The letter of the spec asks us to create a separate
storage area for each unique origin. We might want to do that in a
future patch, but throwing a security error seems like a safe move now.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessSessionStorage):
  • storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):

2010-05-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

drop support for sessionStorage in sandbox iframes
​https://bugs.webkit.org/show_bug.cgi?id=38151

Update client of sessionStorage to handle exceptions.

  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent):
1:51 AM Changeset in webkit [58872] by aestes@apple.com
  • 4 edits
    3 adds in trunk

WebCore: Allow forms submitting to target="_blank" to open popups if the submission
originated from a user gesture.

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=37335
<rdar://problem/7884980>

Test: fast/events/popup-allowed-from-gesture-initiated-form-submit.html

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::processingUserGesture): If no DOM event is
being processed, consult UserGestureIndicator to determine return value.

  • bindings/js/ScriptController.h: Moved the logic of processingUserGestureEvent()

into processingUserGesture().

LayoutTests: Add a test to ensure popups are allowed when the user submits a form with target="_blank".

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=37335
<rdar://problem/7884980>

  • fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Added.
  • fast/events/popup-allowed-from-gesture-initiated-form-submit.html: Added.
  • fast/events/resources/popup-allowed-from-gesture-initiated-form-submit-target.html: Added.
1:10 AM Changeset in webkit [58871] by xan@webkit.org
  • 3 edits in trunk/WebCore

2010-05-06 Xan Lopez <​xlopez@igalia.com>

Rubber-stamped by Eric Seidel.

[GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
​https://bugs.webkit.org/show_bug.cgi?id=38577

Thinko caught while refactoring, $custom variable was not
initialized.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
1:09 AM Changeset in webkit [58870] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-06 Xan Lopez <​xlopez@igalia.com>

Rubber-stamped by Eric Seidel.

[GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
​https://bugs.webkit.org/show_bug.cgi?id=38577

Refactor GenerateProperty out of GenerateProperties. This is in
preparation for EventListeren attributes, which won't generate
normal GObject properties.

  • bindings/scripts/CodeGeneratorGObject.pm:
1:01 AM Changeset in webkit [58869] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: follow up to linkify event listeners.

​https://bugs.webkit.org/show_bug.cgi?id=38257

  • bindings/js/ScriptEventListener.cpp: (WebCore::eventListenerHandlerLocation):
  • bindings/v8/ScriptEventListener.cpp: (WebCore::eventListenerHandlerLocation):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.linkifyNodeReference):
  • inspector/front-end/EventListenersSidebarPane.js:
12:05 AM Changeset in webkit [58868] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-05 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: build-webkit --inspector-frontend Should Exclude *.re2js
​https://bugs.webkit.org/show_bug.cgi?id=38449

  • Scripts/webkitdirs.pm:

May 5, 2010:

11:54 PM Changeset in webkit [58867] by eric@webkit.org
  • 14 edits
    4 adds in trunk

2010-05-05 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos

​https://bugs.webkit.org/show_bug.cgi?id=37848
Add test cases for -wap-input-format and -wap-input-required of WCSS

  • fast/wcss/wap-input-format-expected.txt: Added.
  • fast/wcss/wap-input-format.xhtml: Added.
  • fast/wcss/wap-input-required-expected.txt: Added.
  • fast/wcss/wap-input-required.xhtml: Added.

2010-05-05 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos

​https://bugs.webkit.org/show_bug.cgi?id=37848
This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit

Tests: fast/wcss/wap-input-format.xhtml

fast/wcss/wap-input-required.xhtml

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseWCSSInputProperty):
  • css/CSSParser.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/WCSSPropertyNames.in:
  • dom/InputElement.cpp: (WebCore::InputElement::sanitizeValue): (WebCore::InputElement::handleBeforeTextInsertedEvent): (WebCore::InputElementData::InputElementData): (WebCore::formatCodes): (WebCore::cursorPositionToMaskIndex): (WebCore::InputElement::isConformToInputMask): (WebCore::InputElement::validateInputMask):
  • dom/InputElement.h: (WebCore::InputElementData::inputFormatMask): (WebCore::InputElementData::setInputFormatMask): (WebCore::InputElementData::maxInputCharsAllowed): (WebCore::InputElementData::setMaxInputCharsAllowed):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setWapInputFormat):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::data):
  • wml/WMLInputElement.h: (WebCore::WMLInputElement::data):

2010-05-05 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos

This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit
Make the test cases in fast/wcss optionional only when WCSS is enabled.

​https://bugs.webkit.org/show_bug.cgi?id=37848

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitperl/features.pm:
11:23 PM Changeset in webkit [58866] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-05 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

[GTK] Markup of copied non ASCII characters is broken
​https://bugs.webkit.org/show_bug.cgi?id=37918

This test was fixed by ​http://trac.webkit.org/changeset/58468

  • platform/gtk/Skipped:
11:06 PM Changeset in webkit [58865] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Fixed a crash when closing Top Sites after r58847.

Reviewed by Mark Rowe.

  • WebView/WebFrameView.mm:

(-[WebFrameView webFrame]): Null-check _private.

11:02 PM Changeset in webkit [58864] by morrita@google.com
  • 6 edits in trunk/WebCore

2010-05-05 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=38150
Refactoring: webkitEditableContentChangedEvent should be handled by the owner of appropriate the renderer.

Moved a part of code chunk in HTMLFormControlElementWithState::defaultEventHandler()
which accesses the renderer from foreign node,
to TextControlInnerTextElement::defaultEventHandler() which owns the renderer.

No new tests. No behavioral change.

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::defaultEventHandler):
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::defaultEventHandler):
10:47 PM Changeset in webkit [58863] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Enable Sputnik tests.
​https://bugs.webkit.org/show_bug.cgi?id=38457

Rubber-stamped by Alexey Proskuryakov.

  • platform/qt/Skipped: Only skip tests that fail.
10:40 PM Changeset in webkit [58862] by tkent@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-05 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

[DRT/Chromium] Remove InitWebCoreSystemInterface() call
​https://bugs.webkit.org/show_bug.cgi?id=38624

Chromium r45167 <​http://src.chromium.org/viewvc/chrome?view=rev&revision=45167>
added InitWebCoreSystemInterface() to webkit/support/platform_support_mac.mm.
So we don't need to call it from DumpRenderTree.cpp anymore.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Remove InitWebCoreSystemInterface().
10:34 PM Changeset in webkit [58861] by eric@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

2010-05-05 Steven Lai <​steven_lai@asia.apple.com>

Reviewed by Alexey Proskuryakov.

Remove platform specific test result
Don't print the formatted string of the z-index in the test case
since there's a risk that the output on different c stdlib implementations/platforms/locale could be different
​https://bugs.webkit.org/show_bug.cgi?id=38617.

  • fast/dom/clone-node-z-index-expected.txt:
  • fast/dom/clone-node-z-index.html:
  • platform/win/fast/dom/clone-node-z-index-expected.txt: Removed.
10:23 PM Changeset in webkit [58860] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-05-05 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Add a test of URL segmentation from a data URL base
​https://bugs.webkit.org/show_bug.cgi?id=38606

As requested by Alexey. These tests find some interesting behavior in
both KURL and GURL. We'll need to go through them in more detail later
to understand what the right behavior is.

  • fast/url/script-tests/segments-from-data-url.js: Added.
  • fast/url/segments-from-data-url-expected.txt: Added.
  • fast/url/segments-from-data-url.html: Added.
10:11 PM Changeset in webkit [58859] by eric@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

2010-05-05 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Add a test of URL segmentation
​https://bugs.webkit.org/show_bug.cgi?id=38600

These tests are based on URLParser.Standard from
​http://code.google.com/p/google-url/source/browse/trunk/src/url_parse_unittest.cc

  • fast/url/resources/utilities.js: (canonicalize):
    • I changed this to use deterministic IDs because (theoretically) the old way was flaky in case the IDs collided.

(segments):

  • Here we're using HTMLAnchorElement's attributes to infer the internal segmentation. Unforunately, there don't seem to be accessors for usernames and passwords of URLs.
  • fast/url/script-tests/segments.js: Added.
    • I'm not 100% sure all the test cases here represent the intent of the original test author. The tricky bit is we don't have a good way to test absolute URL parsing from the web platform, which means a bunch of these become tests of how we handle relative URLs. However, I'm not one to turn down more test cases.
  • fast/url/script-tests/trivial-segments.js: Added.
    • This is more of a test of the testing harness to make sure its working properly when running on other browsers.
  • fast/url/segments-expected.txt: Added.
  • fast/url/trivial-segments-expected.txt: Added.
    • As usual, these have their "PASS" expectations set to the Chromium behavior but have their -expected.txt set to the normal WebKit behavior, letting us track differences between the two.
  • fast/url/segments.html: Added.
  • fast/url/trivial-segments.html: Added.
9:50 PM Changeset in webkit [58858] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-05 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Adding comment with link to RefPtr documentation.
​https://bugs.webkit.org/show_bug.cgi?id=38601

  • wtf/RefPtr.h:
9:28 PM Changeset in webkit [58857] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-05 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Line Numbers should be Aligned with the Source Code Line
​https://bugs.webkit.org/show_bug.cgi?id=38593

If there is a message bubble, such as an error message, in a source view
the line number should be in line with the source code line, not centered
between the source and bubble.

  • inspector/front-end/textViewer.css: (.webkit-line-number): added vertical-align: top
8:16 PM Changeset in webkit [58856] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Fixed test crashes after r58847.

Rubber-stamped by Mark Rowe.

  • WebView/WebHTMLView.mm:

(setNeedsDisplayInRect): Null-check the frame.

6:51 PM Changeset in webkit [58855] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-05 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
6:36 PM Changeset in webkit [58854] by mitz@apple.com
  • 3 edits in trunk/WebCore

Fix the decelerated compositing build.

  • page/FrameView.cpp:

(WebCore::FrameView::isEnclosedInCompositingLayer):

  • page/FrameView.h:
6:33 PM Changeset in webkit [58853] by dpranke@chromium.org
  • 6 edits
    3 adds in trunk/WebKitTools

2010-05-05 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: clean up newline handling in printing

The new printing module seems to handle newlines somewhat
inconsistently, especially in --verbose mode. This change cleans up
the code to make things more consistent and adds a bunch of unit tests.

​https://bugs.webkit.org/show_bug.cgi?id=38616

  • Scripts/webkitpy/common/array_stream.py: Added.
  • Scripts/webkitpy/common/array_stream_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
6:12 PM Changeset in webkit [58852] by jamesr@google.com
  • 3 edits in trunk/WebKitTools

2010-05-05 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Ban the single letter 'l' as an identifier name
​http://trac.webkit.org/changeset/58844

Add a lint rule to ban the single letter 'l' as an identifier name
since it is very easy to confuse with the numeral '1', especially
in code like WebCore/css/CSSHelper.cpp.

See ​http://trac.webkit.org/changeset/58844 as an example of a bug
caused by confusing short variable names.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
6:08 PM Changeset in webkit [58851] by barraclough@apple.com
  • 9 edits in trunk

Bug 38604 - workers-gc2 crashing on Qt

Reviewed by Darin Adler.

This appears to be due to a couple of issues.
(1) When the atomic string table is deleted it does not clear the 'inTable' bit
on AtomicStrings - it implicitly assumes that all AtomicStrings have already
been deleted at this point (otherwise they will crash in their destructor when
they try to remove themselves from the atomic string table).
(2) We don't fix the ordering in which WTF::WTFThreadData and
WebCore::ThreadGlobalData are destructed.

We should make sure that ThreadGlobalData is cleaned up before worker threads
terminate and WTF::WTFThreadData is destroyed, and we should clear the inTable
bit of members on atomic string table destruction.

JavaScriptCore:

WTF changes (fix issue 1, above) - ensure inTable property is cleared when the
atomic string table is destroyed (also, rename InTable to IsAtomic, to make it
clear which table we are refering to!)

  • wtf/text/AtomicString.cpp:

(WebCore::AtomicStringTable::destroy):
(WebCore::CStringTranslator::translate):
(WebCore::UCharBufferTranslator::translate):
(WebCore::HashAndCharactersTranslator::translate):
(WebCore::AtomicString::add):

  • wtf/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::isAtomic):
(WebCore::StringImpl::setIsAtomic):

  • wtf/text/StringImplBase.h:

WebCore:

WTF changes (fix issue 2, above) - clean up the thread data on worker termination.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::~ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):

  • platform/ThreadGlobalData.h:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

6:05 PM Changeset in webkit [58850] by bweinstein@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows-specific results for clone-node-z-index.html. The difference in results is harmless (the number is the same),
but the difference is being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=38617.

Rubber-stamped by Mark Rowe.

  • platform/win/fast/dom/clone-node-z-index-expected.txt: Added.
5:53 PM Changeset in webkit [58849] by crogers@google.com
  • 8 edits in branches/audio/WebCore/audio

Fix problems with node disconnection

  • add notifyInputConnection() method to AudioNode
5:53 PM Changeset in webkit [58848] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Cleanup AudioContext - clarify memory management a little bit

5:37 PM Changeset in webkit [58847] by mitz@apple.com
  • 10 edits
    1 move
    4 adds in trunk

<rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affects Yahoo! Mail with Flash Player 10.1)
​https://bugs.webkit.org/show_bug.cgi?id=38427

Reviewed by Simon Fraser.

WebCore:

Test: compositing/iframes/iframe-in-composited-layer.html

  • WebCore.base.exp: Export FrameView::isEnclosedInCompositingLayer().
  • page/FrameView.cpp:

(WebCore::FrameView::isEnclosedInCompositingLayer): Added this predicate.

  • page/FrameView.h:

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Renamed WebClipView.m to WebClipView.mm and changed it to

Objective-C++.

WebKit/mac:

  • WebView/WebClipView.m: Renamed to WebClipView.mm.
  • WebView/WebClipView.mm:

(-[WebClipView visibleRect]): Added this override, which for instances used for WebFrameViews in
composited layers, returns the clip view’s entire bounds. This prevents drawing from being clipped to
AppKit’s idea of what part of the view would be visible if it was drawn as part of the view hierarchy.
Since it is drawn into a compositing layer, that’s irrelevant, and we should not be clipping.

  • WebView/WebHTMLView.mm:

(setCursor): Style tweak.
(setNeedsDisplayInRect): Added. Replaces the default implementation of -[NSView setNeedsDisplayInRect:],
so that if the receiver is a descendant of a WebFrameView that draws into a composited layer, the invalidation
is routed back through the WebCore FrameView, which propagates it to the layer.
(+[WebHTMLViewPrivate initialize]): Swizzle the setNeedsDisplayInRect: override in.
(-[WebHTMLView visibleRect]): Removed whitespace.

  • WebView/WebView.mm:

(layerSyncRunLoopObserverCallBack): If we bailed out on syncing, due to pending layout, do an eager layout
in preparation for the displaying of compositing layers.

LayoutTests:

  • compositing/iframes/iframe-in-composited-layer.html: Added.
  • platform/mac/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
  • platform/mac/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
  • platform/mac/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
5:20 PM Changeset in webkit [58846] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7942606> Output appears in Console when exiting Safari with multiple windows opened

Reviewed by Mark Rowe.

  • WebView/WebView.mm:

(+[WebView closeAllWebViews]):
Make copy of allWebViewsSet to avoid mutating it while iterating through it.

5:02 PM Changeset in webkit [58845] by cmarrin@apple.com
  • 3 edits
    4 adds in trunk

2010-05-05 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Got composited iframes showing up on Mac again
​https://bugs.webkit.org/show_bug.cgi?id=38565

This was broken by ​http://trac.webkit.org/changeset/58798. That
change connected iframes through the parent document to the root
of the layer tree. That is correct for Windows, but not for Mac.
So the places where the linkage is made were wrapped in
shouldPropagateCompositingToIFrameParent() calls, which is
always false for Mac.

Test: compositing/iframes/composited-iframe-alignment.html

  • rendering/RenderLayerCompositor.cpp:Avoid doing composited iframe linkage on Mac (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::didMoveOnscreen): (WebCore::RenderLayerCompositor::willMoveOffscreen): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
4:24 PM Changeset in webkit [58844] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=38260
<rdar://problem/7917548> Fix whitespace removing in deprecatedParseURL().

Broken all the way since r4 (yes, that's a revision number).

Test: http/tests/security/xss-DENIED-javascript-with-spaces.html

  • css/CSSHelper.cpp: (WebCore::deprecatedParseURL): Fixed loop conditions for remaining length.
4:12 PM Changeset in webkit [58843] by Chris Fleizach
  • 5 edits
    2 adds in trunk

Many AXUnknown showing up in the hierarchy
​https://bugs.webkit.org/show_bug.cgi?id=38607

Reviewed by Beth Dakin.

WebCore:

The RenderTableSection should not be an accessible element.

Test: platform/mac/accessibility/parent-of-table-row-is-table.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/accessibility/parent-of-table-row-is-table-expected.txt: Added.
  • platform/mac/accessibility/parent-of-table-row-is-table.html: Added.
3:59 PM Changeset in webkit [58842] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

[Qt]Disable Qt Multimedia backend for HTML 5 Audio and Video elements
Fall back to the Phonon backend until the release situation has been cleared up.

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=38612

Buildfix for QT_VERSION >= 0x040700 after r58810.

  • platform/graphics/MediaPlayer.cpp:
3:42 PM Changeset in webkit [58841] by jianli@chromium.org
  • 9 edits
    3 adds in trunk

XMLHttpRequestUpload events do not fire when sending a raw file or FormData object.
​https://bugs.webkit.org/show_bug.cgi?id=37771

Reviewed by David Levin.

WebCore:

Test: http/tests/local/formdata/upload-events.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

LayoutTests:

Add a layout test to test upload events firing.

  • http/tests/local/formdata/resources/send-form-data-common.js:

(dumpResponse):
(sendFormData):
(testSendingFormData):

  • http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js:
  • http/tests/local/formdata/script-tests/send-form-data.js:
  • http/tests/local/formdata/script-tests/upload-events.js: Added.
  • http/tests/local/formdata/upload-events-expected.txt: Added.
  • http/tests/local/formdata/upload-events.html: Added.
  • platform/gtk/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in gtk platform.
  • platform/qt/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in qt platform.
  • platform/win/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in win platform.
3:28 PM Changeset in webkit [58840] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

[Qt] Qt port should use its own QUuid class to create UUID string.
​https://bugs.webkit.org/show_bug.cgi?id=38581

Reviewed by Simon Hausmann.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString): Added PLATFORM(QT) case.

2:51 PM Changeset in webkit [58839] by darin@chromium.org
  • 11 edits in trunk/WebKit/chromium

2010-05-05 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] clear out deprecated methods that are no longer used
​https://bugs.webkit.org/show_bug.cgi?id=38610

  • public/WebFormElement.h:
  • public/WebInputElement.h:
  • public/WebKitClient.h:
  • public/WebView.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened):
  • src/WebFormElement.cpp:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::setSelectionRange):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::hideSuggestionsPopup):
  • src/WebViewImpl.h:
2:16 PM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
1:16 PM Changeset in webkit [58838] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-05 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations fix.

Update expectations with tests that are now passing (possibly flaky?).

  • platform/chromium/test_expectations.txt:
1:06 PM Changeset in webkit [58837] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-05 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations fix.

Mark svg/custom/mask-changes.svg and http/tests/loading/bad-scheme-subframe.html as failing on Chromium Linux until they can be triaged.

  • platform/chromium/test_expectations.txt:
12:19 PM Changeset in webkit [58836] by ap@apple.com
  • 3 edits
    4 deletes in trunk

Roll out r58830 for breaking tests.

Was: ​https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly

12:11 PM Changeset in webkit [58835] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Call to pull() must take return value into account for non-inplace case

12:11 PM Changeset in webkit [58834] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/AudioBufferSourceNode.cpp

Audio buffer source node needs default number of channels

12:10 PM Changeset in webkit [58833] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Keep track of mixer input availability

11:52 AM Changeset in webkit [58832] by jianli@chromium.org
  • 12 edits
    2 adds in trunk/WebCore

Implement FileReader class.
​https://bugs.webkit.org/show_bug.cgi?id=38157

Reviewed by Adam Barth.

This patch only contains the implementation of FileReader class as defined
in the File API spec: ​http://www.w3.org/TR/file-upload/#dfn-filereader.

New test will be added when a IDL is exposed and the FILE_READER is turned
on.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.h:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::toFileReader):

  • dom/EventTarget.h:
  • html/FileError.h:

(WebCore::FileError::FileError):

  • html/FileReader.cpp: Added.
  • html/FileReader.h: Added.
  • html/FileStream.cpp:

(WebCore::FileStream::FileStream):
(WebCore::FileStream::openForRead):
(WebCore::FileStream::close):
(WebCore::FileStream::read):

  • html/FileStream.h:
11:35 AM Changeset in webkit [58831] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2010-05-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION(r57969) Image decoder is repeatedly destroyed/created in CoreGraphics-based Windows WebKit
​https://bugs.webkit.org/show_bug.cgi?id=38595

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
11:26 AM Changeset in webkit [58830] by ap@apple.com
  • 3 edits
    4 adds in trunk

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly

Test: fast/frames/take-focus-from-iframe.html

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus): Don't clear focus if this frame doesn't have it. This can happen if page's and HTMLFrameElement's ideas of focused frame get out of sync temporarily.
11:24 AM How to CC yourself on (or make other changes to) many bugs at once created by Adam Roben
Initial version
11:20 AM WikiStart edited by Adam Roben
(diff)
11:17 AM Changeset in webkit [58829] by ap@apple.com
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=26824
<rdar://problem/7018610> EventHandler can operate on a wrong frame if focus changes during
keyboard event dispatch.

EventHandler object is tied to a frame, so it's wrong for it to continue processing a keyboard
event if focused frame changes between keydown and keypress.

  • manual-tests/focus-change-between-key-events.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Bail out early if focused frame changes while dispatching keydown. Also made similar changes for Windows to maintain matching behavior, even though EventHandler was re-entered anyway due to WM_KEYDOWN and WM_CHAR being separate events.
11:14 AM Changeset in webkit [58828] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-05 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] Add quota parameter to WebStorageNamespace::createSessionStorageNamespace
​https://bugs.webkit.org/show_bug.cgi?id=38589

  • public/WebStorageNamespace.h: (WebKit::WebStorageNamespace::createSessionStorageNamespace):
  • src/WebStorageNamespaceImpl.cpp: (WebKit::WebStorageNamespace::createSessionStorageNamespace):
10:53 AM Changeset in webkit [58827] by hamaji@chromium.org
  • 2 edits in trunk/WebKitSite

2010-05-05 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Adam Barth.

Commit and Review policy should encourage unofficial reviews
​https://bugs.webkit.org/show_bug.cgi?id=38517

  • coding/commit-review-policy.html:
10:20 AM Changeset in webkit [58826] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-05 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

MediaError.h is missing PassRefPtr.h include
​https://bugs.webkit.org/show_bug.cgi?id=38575

No new tests, build fix only.

  • html/MediaError.h:
10:06 AM Changeset in webkit [58825] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-05 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Audits panel: Resource counters get reset when switching panels while reloading page
​https://bugs.webkit.org/show_bug.cgi?id=38579

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState): (WebInspector.AuditLauncherView.prototype._updateResourceProgress):
10:03 AM Changeset in webkit [58824] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-05-05 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Array.join specialised for actual arrays
​https://bugs.webkit.org/show_bug.cgi?id=38592

Bring Array.join in line with the other array methods by specialising for
this === an array.

  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin):
9:48 AM Changeset in webkit [58823] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Doubleclick on line number should not trigger source editing.

​https://bugs.webkit.org/show_bug.cgi?id=38588

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleDoubleClick):
9:30 AM Changeset in webkit [58822] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-05-05 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Add support in the PasteboardHelper for images, in preparation for drag-and-drop data.

No new tests as functionality has not changed.

  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::fillSelectionData): Add support for images here. (WebCore::PasteboardHelper::targetListForDataObject): Add support for images here.
9:22 AM Changeset in webkit [58821] by eric@webkit.org
  • 26 edits in trunk

2010-05-05 Stuart Morgan <​stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Add a "focused" parameter to Widget::setFocus, and updates Document
so that Widget is informed of focus loss as well as focus gain.
Changes all existing setFocus implementations so that they ignore
the 'false' case, so no behavior is changed until individual
platforms are updated to handle the new case (if they want to).

​https://bugs.webkit.org/show_bug.cgi?id=37961

  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • platform/Widget.h:
  • platform/android/WidgetAndroid.cpp: (WebCore::Widget::setFocus):
  • platform/chromium/WidgetChromium.cpp: (WebCore::Widget::setFocus):
  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::setFocus):
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setFocus):
  • platform/haiku/WidgetHaiku.cpp: (WebCore::Widget::setFocus):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus):
  • platform/qt/WidgetQt.cpp: (WebCore::Widget::setFocus):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::setFocus):
  • platform/wx/WidgetWx.cpp: (WebCore::Widget::setFocus):
  • plugins/PluginView.h:
  • plugins/PluginViewNone.cpp: (WebCore::PluginView::setFocus):
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setFocus):
  • plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::setFocus):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setFocus):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setFocus):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::setFocus):

2010-05-05 Stuart Morgan <​stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Update the plugin container's setFocus implementation to pass the new
boolean argument to the next layer.

​https://bugs.webkit.org/show_bug.cgi?id=37961

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setFocus):
  • src/WebPluginContainerImpl.h:

2010-05-05 Stuart Morgan <​stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Update setFocus for the new boolean argument; no behavioral change.

​https://bugs.webkit.org/show_bug.cgi?id=37961

  • WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::setFocus):
  • WebCoreSupport/EmbeddedWidget.h:
9:01 AM Changeset in webkit [58820] by jeremy@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-05 Jeremy Moskovich <​jeremy@chromium.org>

Unreviewed, updated baselines.

skia r561 broke a bunch of chromium image baselines.
Update test_expectations to include remaining failures.

  • platform/chromium/test_expectations.txt:
8:18 AM Changeset in webkit [58819] by jeremy@chromium.org
  • 4 edits
    2 adds in trunk/LayoutTests

2010-05-05 Jeremy Moskovich <​jeremy@chromium.org>

Unreviewed, updated baselines.

skia r561 broke a bunch of chromium image baselines.
Rebase a few tests that were missed by previous passes.

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/chromium-linux/svg/custom/mask-changes-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/mask-changes-expected.png: Added.
  • platform/chromium/test_expectations.txt:
8:08 AM Changeset in webkit [58818] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-05 Steve Block <​steveblock@google.com>

Reviewed by Pavel Feldman.

Move V8 ScriptDebugServer::topStackFrame() to ScriptCallStack
​https://bugs.webkit.org/show_bug.cgi?id=38531

ScriptCallStack::create() uses ScriptDebugServer::topStackFrame(), but ScriptDebugServer
is guarded with ENABLE(JAVASCRIPT_DEBUGGER). This prevents ScriptCallStack from being
built on platforms that do not define ENABLE(JAVASCRIPT_DEBUGGER).

No new tests, build fix only.

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::createUtilityContext): Helper for topStackFrame, moved from ScriptDebugServer (WebCore::ScriptCallStack::topStackFrame): Moved from ScriptDebugServer
  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::utilityContext): Helper for topStackFrame, moved from ScriptDebugServer
  • bindings/v8/ScriptDebugServer.cpp:
  • bindings/v8/ScriptDebugServer.h:
7:42 AM Changeset in webkit [58817] by jeremy@chromium.org
  • 7 edits
    1 delete in trunk/LayoutTests

2010-05-05 Jeremy Moskovich <​jeremy@chromium.org>

Unreviewed, updated baselines - 6th and final batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

  • platform/chromium/test_expectations.txt:
7:18 AM Changeset in webkit [58816] by jeremy@chromium.org
  • 671 edits
    10 adds
    62 deletes in trunk/LayoutTests

2010-05-05 Jeremy Moskovich <​jeremy@chromium.org>

Unreviewed, updated baselines - 5th batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

  • platform/chromium/test_expectations.txt:
7:01 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
(diff)
6:52 AM Changeset in webkit [58815] by jeremy@chromium.org
  • 852 edits
    4 adds
    41 deletes in trunk/LayoutTests

2010-05-05 Jeremy Moskovich <​jeremy@chromium.org>

Unreviewed, updated baselines - 4th batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

  • platform/chromium/test_expectations.txt:
6:49 AM QtWebKitJournal edited by Simon Hausmann
(diff)
6:31 AM Changeset in webkit [58814] by jeremy@chromium.org
  • 820 edits
    2 adds
    69 deletes in trunk/LayoutTests

2010-05-05 Jeremy Moskovich <​jeremy@chromium.org>

Unreviewed, updated baselines - 3rd batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

  • platform/chromium/test_expectations.txt:
5:57 AM Changeset in webkit [58813] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

[Qt] REGRESSION(r56869): WinCE build is broken
​https://bugs.webkit.org/show_bug.cgi?id=36929

Rubber-stamped by Simon Hausmann.

  • WebCore.pro: LIBS += -lOle32 added.
5:44 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
Added python as a dependency (diff)
5:36 AM Changeset in webkit [58812] by jeremy@chromium.org
  • 1080 edits
    8 adds
    111 deletes in trunk/LayoutTests

Unreviewed, updated baselines - 2nd batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

  • platform/chromium/test_expectations.txt:
4:54 AM Changeset in webkit [58811] by jeremy@chromium.org
  • 379 edits
    39 deletes in trunk/LayoutTests

Unreviewed, updated baselines - 1st batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

  • platform/chromium/test_expectations.txt:
4:30 AM Changeset in webkit [58810] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Disable Qt Multimedia backend for HTML 5 Audio and Video elements

Reviewed by Tor Arne Vestbø.

Fall back to the Phonon backend until the release situation has been cleared up.

  • WebCore.pro:
4:30 AM Changeset in webkit [58809] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-05-05 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Clickable links to resources should be used as 'details' part for the all suitable kinds of records.
​https://bugs.webkit.org/show_bug.cgi?id=38542

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper): (WebInspector.TimelinePanel.PopupContentHelper.prototype._createCell): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendTextRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
2:33 AM Changeset in webkit [58808] by Nikolas Zimmermann
  • 1 edit
    6 adds in trunk/WebCore

2010-05-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add missing files generated by "run-bindings-test", after the DOMTestCallback.idl addition.

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Added. (WebKit::kit): (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type): (WebKit::wrapTestCallback): (WebKit::core): (webkit_dom_test_callback_finalize): (webkit_dom_test_callback_set_property): (webkit_dom_test_callback_get_property): (webkit_dom_test_callback_class_init): (webkit_dom_test_callback_init):
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h: Added.
  • bindings/scripts/test/ObjC/DOMTestCallback.h: Added.
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: Added. (-[DOMTestCallback dealloc]): (-[DOMTestCallback finalize]): (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]): (core): (kit):
  • bindings/scripts/test/ObjC/DOMTestCallbackInternal.h: Added.
1:00 AM Changeset in webkit [58807] by jeremy@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations change.

recommit r58747 - Preparing for chromium skia roll incorporating changes up to r561.
Add expected failures so bots don't turn red while rolling.

​https://bugs.webkit.org/show_bug.cgi?id=38512

  • platform/chromium/test_expectations.txt:
12:57 AM Changeset in webkit [58806] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-05 Xan Lopez <​xlopez@igalia.com>

Skip flakey workers test.

  • platform/gtk/Skipped:
12:57 AM Changeset in webkit [58805] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-05 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: FontView needs Cleanup
​https://bugs.webkit.org/show_bug.cgi?id=38567

FontView was missing some of the newer practices for initialization
that other Resource Views had. Also its width calculations could
result in a single character wrapping. This is general cleanup.

  • inspector/front-end/FontView.js: (WebInspector.FontView): move initialization into contentTabSelected (WebInspector.FontView.prototype.contentTabSelected): handle initialization like other Resource Views (WebInspector.FontView.prototype.updateFontPreviewSize): use a narrower width to prevent text from widowing
12:31 AM Changeset in webkit [58804] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-05-05 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG hit testing is *way* too slow
​https://bugs.webkit.org/show_bug.cgi?id=19312

Use the cached stroke and fill boundaries in RenderPath as a heuristik to
speed up SVG's hit testing.

No new tests added.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::fillContains): (WebCore::RenderPath::strokeContains):

May 4, 2010:

11:06 PM Changeset in webkit [58803] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-04 Eric Seidel <​eric@webkit.org>

Reviewed by Shinichiro Hamaji.

PrettyPatch.pretty_diff("") should not hang
​https://bugs.webkit.org/show_bug.cgi?id=38552

Also found a bug in PrettyPatch.pretty_diff where it would
hang when passed "" as input.

I suspect there may be bugs in prettify.rb (or our use there-of)
where it can hang, which would then cause the testing thread to hang.

  • Scripts/webkitpy/common/prettypatch.py:
    • Don't hang when passed ""
  • Scripts/webkitpy/common/prettypatch_unittest.py:
    • Test that we don't hang when passed ""
  • Scripts/webkitpy/layout_tests/port/base.py:
    • Add a FIXME that we should share code with prettypatch.rb
10:09 PM Changeset in webkit [58802] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2010-05-04 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Improve check for drawing into the window that was added in r58623
​https://bugs.webkit.org/show_bug.cgi?id=38562

Rather than assuming that any non-bitmap context is the window's context,
compare the current graphics context with -[NSWindow graphicsContext] to
determine that we're drawing into the window.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
8:24 PM Changeset in webkit [58801] by dumi@chromium.org
  • 24 edits
    5 adds
    18 deletes in trunk/WebCore

Auto-generate all Database callbacks.
​https://bugs.webkit.org/show_bug.cgi?id=38503

Reviewed by Adam Barth.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCustomSQLStatementCallback.cpp: Removed.
  • bindings/js/JSCustomSQLStatementCallback.h: Removed.
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementErrorCallback.h: Removed.
  • bindings/js/JSCustomSQLTransactionCallback.cpp: Removed.
  • bindings/js/JSCustomSQLTransactionCallback.h: Removed.
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: Removed.
  • bindings/js/JSCustomSQLTransactionErrorCallback.h: Removed.
  • bindings/js/JSDatabaseCallback.cpp: Removed.
  • bindings/js/JSDatabaseCallback.h: Removed.
  • bindings/js/JSDatabaseCustom.cpp:

(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomSQLStatementCallback.h: Removed.
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8SQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Removed.
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomSQLTransactionCallback.h: Removed.
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Removed.
  • bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
  • bindings/v8/custom/V8DatabaseCallback.h: Removed.
  • bindings/v8/custom/V8DatabaseCustom.cpp:

(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • storage/DatabaseCallback.h:
  • storage/DatabaseCallback.idl: Added.
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::performCallback):

  • storage/SQLStatementCallback.h:
  • storage/SQLStatementCallback.idl: Added.
  • storage/SQLStatementErrorCallback.idl: Added.
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverTransactionCallback):

  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionCallback.idl: Added.
  • storage/SQLTransactionErrorCallback.h:
  • storage/SQLTransactionErrorCallback.idl: Added.
8:06 PM Changeset in webkit [58800] by cmarrin@apple.com
  • 1 add in trunk/LayoutTests/platform/mac/compositing/iframes/composited-parent-iframe-expected.txt

results for new test checked in with ​http://trac.webkit.org/changeset/58797

7:43 PM Changeset in webkit [58799] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-04 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations fix.

Re-add the two expectations lines that got mistakenly deleted in
r58798.

  • platform/chromium/test_expectations.txt:
7:05 PM Changeset in webkit [58798] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-04 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Made composited iframes work on Windows
​https://bugs.webkit.org/show_bug.cgi?id=32446

I've added one new test (composited-parent-iframe.html) which
shows both the parent iframe and the iframe contents document
with compositing. It also shows correct behavior with clipping,
borders, margins, padding and shadows. It also sets the iframe
size as a percent of the page to show correct resizing behavior.
The existing composited-iframe.html has been changed similarly
but without the page resizing. The existing preserve-3d-switching.html
test needed new results because of changes to the layer dumper.

  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/composited-iframe.html:
  • compositing/iframes/composited-parent-iframe.html: Added.
  • compositing/iframes/resources/composited-subframe.html:
  • platform/win/compositing/iframes/composited-iframe-expected.txt:
  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Added.
6:50 PM Changeset in webkit [58797] by cmarrin@apple.com
  • 9 edits
    2 adds in trunk

Reviewed by Simon Fraser.

Made composited iframes work on Windows
​https://bugs.webkit.org/show_bug.cgi?id=32446


This completes the work in ​http://trac.webkit.org/changeset/57919
to create compositing layers in the parent document when an iframe has
a compositing layer. The parent document has a layer for the iframe
element and builds a layer tree to the page root. The layer tree for the
iframe document is then parented to the iframe element's GraphicsLayer.


The RenderLayerCompositor for the iframe document (which owns the
root of the layer tree) now has a clippingLayer which is the
parent of the layer tree root so it can be clipped to the parent
iframe's bounds, taking into account borders, padding, etc. in
the parent iframe element.


I also got rid of a no longer used function: RenderLayerCompositor::parentInRootLayer

Test: compositing/iframes/composited-parent-iframe.html

  • rendering/RenderLayerBacking.cpp:Make calls to RenderLayerCompositor to set the clipping bounds for iframe content
  • rendering/RenderLayerCompositor.cpp:Hook the iframe content to the parent iframe element
  • rendering/RenderLayerCompositor.h:
6:24 PM Changeset in webkit [58796] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Not reviewed.

Updated test results - the test still passes.

  • http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
6:22 PM Changeset in webkit [58795] by dumi@chromium.org
  • 2 edits in trunk/WebKitSite

Fix the sticky-notes demo.
​https://bugs.webkit.org/show_bug.cgi?id=38550

Reviewed by Darin Adler.

  1. Exceptions thrown by openDatabase() should be treated as

failures.

  1. Do not allow users to create new notes when openDatabase()

failed.

  • demos/sticky-notes/index.html:
6:11 PM Changeset in webkit [58794] by Chris Fleizach
  • 9 edits in trunk/LayoutTests

AX: layout tests need to be updated to reflect what is being tested
​https://bugs.webkit.org/show_bug.cgi?id=38556

Reviewed by Beth Dakin.

Many of the initial AX layout tests just dumped a lot of attributes and did not
have a focused test. This updates some of those tests (more to follow in the future).

  • accessibility/image-map1.html:
  • accessibility/img-aria-button-alt-tag-expected.txt:
  • accessibility/img-aria-button-alt-tag.html:
  • accessibility/input-image-alt-expected.txt:
  • accessibility/input-image-alt.html:
  • accessibility/placeholder-expected.txt:
  • accessibility/placeholder.html:
  • platform/mac/accessibility/image-map1-expected.txt:
6:08 PM Changeset in webkit [58793] by eric@webkit.org
  • 5 edits in trunk/WebKit/chromium

2010-05-04 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

Provide an API for querying whether a WebWidget is using gpu accelerated compositing.
Also changed: isAcceleratedCompositing to: isAcceleratedCompositingActive.
​https://bugs.webkit.org/show_bug.cgi?id=38220

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.h: (WebKit::WebPopupMenuImpl::isAcceleratedCompositingActive):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::isAcceleratedCompositingActive): (WebKit::WebViewImpl::setRootGraphicsLayer): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::updateRootLayerContents):
  • src/WebViewImpl.h:
5:57 PM Changeset in webkit [58792] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=38497
<rdar://problem/7759438> Make sure that http URLs always have a host in SecurityOrigin

This is a hardening fix, and behavior really depends on what an underlying networking layer
does. So, no test.

  • page/SecurityOrigin.cpp: (WebCore::schemeRequiresAuthority): List schemes that need an authority for successful loading. (WebCore::SecurityOrigin::SecurityOrigin): Never let e.g. http origins with empty authorities have the same security origin.
5:49 PM Changeset in webkit [58791] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-04 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark fast/forms/placeholder-pseudo-style.html as an IMAGE diff on
chromium-linux . This was mistaken deleted earlier today. Mark
fast/dom/clone-node-z-index.html as a TEXT diff on chromium-win; I
haven't looked at this yet but I need to roll past this to get the
new-run-webkit-tests change I checked in in r58789 downstream to
the Chromium bots.

  • platform/chromium/test_expectations.txt:
5:30 PM Changeset in webkit [58790] by eric@webkit.org
  • 15 edits in trunk

2010-05-04 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getFramebufferAttachmentParameter should return the original WebGLTexture/WebGLRenderbuffer instead of creating new ones sharing names.
​https://bugs.webkit.org/show_bug.cgi?id=38236

  • fast/canvas/webgl/gl-object-get-calls-expected.txt: Check if getFramebufferAttachmentParameter return a texture/renderbuffer that matches the original one.
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js: Ditto.

2010-05-04 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getFramebufferAttachmentParameter should return the original WebGLTexture/WebGLRenderbuffer instead of creating new ones sharing names.
​https://bugs.webkit.org/show_bug.cgi?id=38236

  • html/canvas/CanvasObject.h: Add type check functions. (WebCore::CanvasObject::isBuffer): (WebCore::CanvasObject::isFramebuffer): (WebCore::CanvasObject::isProgram): (WebCore::CanvasObject::isRenderbuffer): (WebCore::CanvasObject::isShader): (WebCore::CanvasObject::isTexture):
  • html/canvas/WebGLBuffer.h: Add type check functions. (WebCore::WebGLBuffer::isBuffer):
  • html/canvas/WebGLFramebuffer.h: Add type check functions. (WebCore::WebGLFramebuffer::isFramebuffer):
  • html/canvas/WebGLProgram.h: Add type check functions. (WebCore::WebGLProgram::isProgram):
  • html/canvas/WebGLRenderbuffer.cpp: remove constructor using existing name.
  • html/canvas/WebGLRenderbuffer.h: Add type check functions; remove constructor using existing name. (WebCore::WebGLRenderbuffer::isRenderbuffer):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Return original Texture/Renderbuffer instead of creating new ones. (WebCore::WebGLRenderingContext::findTexture): Find a WebGLTexture using a name. (WebCore::WebGLRenderingContext::findRenderbuffer): Find a WebGLRenderbuffer using a name.
  • html/canvas/WebGLRenderingContext.h: Add find* functions.
  • html/canvas/WebGLShader.h: Add type check functions. (WebCore::WebGLShader::isShader):
  • html/canvas/WebGLTexture.cpp: remove constructor using existing name.
  • html/canvas/WebGLTexture.h: Add type check functions; remove constructor using existing name. (WebCore::WebGLTexture::isTexture):
5:16 PM Changeset in webkit [58789] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-05-04 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: turn off threading on the Chromium Mac port until
we can stabilize the port more and figure out why it is hanging so
frequently.

​https://bugs.webkit.org/show_bug.cgi?id=38553

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
    • override default_child_processes() and log a warning
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • fix a typo that caused us to print a method object instead of the value the method object returns in the case where there is only one child process.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
    • Add unit tests for the output of run_webkit_tests - in this case, the handling of --child-processes and --print config
5:16 PM Changeset in webkit [58788] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-04 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] QT_MOBILE_THEME compile time flag
​https://bugs.webkit.org/show_bug.cgi?id=38439

Replacing preprocessor conditional used in RenderThemeQt from Q_WS_MAEMO_5 to
USE(QT_MOBILE_THEME).

  • WebCore.pro:
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::qStyle): (WebCore::RenderThemeQt::extraDefaultStyleSheet): (WebCore::RenderThemeQt::adjustMenuListButtonStyle): (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
  • platform/qt/RenderThemeQt.h:
4:57 PM Changeset in webkit [58787] by adachan@apple.com
  • 2 edits in trunk/WebKit/mac

​https://bugs.webkit.org/show_bug.cgi?id=38555

Reviewed by David Kilzer.

Small code refactoring: move the logic to figure out the path to the
databases directory to another method.

  • Storage/WebDatabaseManager.mm:

(databasesDirectoryPath):
(WebKitInitializeDatabasesIfNecessary):

4:17 PM Changeset in webkit [58786] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-05-04 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dan Bernstein.

SVG fonts trigger GlyphPage::fill with null font
​https://bugs.webkit.org/show_bug.cgi?id=38530

SVG fonts do not use the glyph page cache. This change detects when
attempting to fill a GlyphPage with an SVG font and indicates that
the glyphs were not available.

  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::fill): helper method which handles attempts to fill a GlyphPage with SVG or non-SVG fonts (WebCore::GlyphPageTreeNode::initializePage): use the helper where appropriate
3:59 PM Changeset in webkit [58785] by crogers@google.com
  • 1 edit in branches/audio/WebCore/bindings/v8/V8DOMWrapper.cpp

Fixes to V8DOMWrapper to handle CachedAudio

3:58 PM Changeset in webkit [58784] by crogers@google.com
  • 2 edits in branches/audio/WebCore

Initial changes to gyp files to build audio engine

3:58 PM Changeset in webkit [58783] by crogers@google.com
  • 2 adds in branches/audio/WebCore/audio

Add custom V8 bindings for AudioContext and AudioNode

3:46 PM Changeset in webkit [58782] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed tests skips for qt/gtk.

Add the recently added drag and drop tests to the
skipped lists for both gtk and qt to go along with
the other drag and drop tests that are skipped on
those platforms.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
3:24 PM Changeset in webkit [58781] by andersca@apple.com
  • 5 edits in trunk/WebKit2

2010-05-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

[WebKit2] The web process doesn't need to paint when the web view is hidden.
​https://bugs.webkit.org/show_bug.cgi?id=38549

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: (DrawingAreaMessage::): Add SuspendPainting/ResumePainting messages.


  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: (WebKit::DrawingAreaProxyUpdateChunk::setPageIsVisible): Suspend and resume painting accordingly.


  • WebProcess/WebPage/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk): Initialize m_shouldPaint to true.


(WebKit::DrawingAreaUpdateChunk::display):
Return if m_shouldPaint is false.


(WebKit::DrawingAreaUpdateChunk::scheduleDisplay):
Ditto.


(WebKit::DrawingAreaUpdateChunk::setSize):
Assert that we should paint here.

(WebKit::DrawingAreaUpdateChunk::suspendPainting):
Set m_shouldPaint to false and stop the timer.


(WebKit::DrawingAreaUpdateChunk::resumePainting):
Set m_shouldPaint to true and paint if needed.

(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
handle SuspendPainting/ResumePainting messages.

  • WebProcess/WebPage/DrawingAreaUpdateChunk.h:
3:04 PM Changeset in webkit [58780] by levin@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION(r54368): Text drag-and-drop from input/textarea doesn't work
if the text is like a URL
​https://bugs.webkit.org/show_bug.cgi?id=38374

Patch by Kent Tamura <​tkent@chromium.org> on 2010-05-04
Reviewed by David Levin (and unofficially by Enrica Casucci).

WebCore:

Since r54368, documentFragmentFromDragData() creates an <a> element
with no anchor text for URL-like text dragged from input/textarea
element. If such text is dropped to input/textarea element, the text
is not inserted.
To fix this problem, use the original text or the URL as an anchor
text.

Test: editing/pasteboard/drag-drop-url-text.html

  • page/DragController.cpp:

(WebCore::documentFragmentFromDragData):

LayoutTests:

  • editing/pasteboard/drag-drop-url-text-expected.txt: Added.
  • editing/pasteboard/drag-drop-url-text.html: Added.
3:01 PM Changeset in webkit [58779] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-04 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by Darin Adler.

WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
​https://bugs.webkit.org/show_bug.cgi?id=38535

Don't call asFunction if callee is not a FunctionType to prevent assertion failure
in JSCell::isObject().

  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::functionName): (JSC::DebuggerCallFrame::calculatedFunctionName):
2:50 PM Changeset in webkit [58778] by timothy@apple.com
  • 1 edit in trunk/WebKit/ChangeLog

Remove ChangeLog from bad merge.

2:49 PM Changeset in webkit [58777] by timothy@apple.com
  • 3 edits in trunk/WebKitTools

Fix the find command in extract-localizable-strings so skip
directories are correctly skipped and header files are searched.

​https://bugs.webkit.org/show_bug.cgi?id=38545
rdar://problem/7941295

Reviewed by Darin Adler.

  • Scripts/extract-localizable-strings: Append -o after each -prune

so -and isn't implied. Surround all the -name arguments so they get
an implied -print action. Removed check for "icu". Skip any header that
ends in LocalizableStrings.h, so SafariLocalizableStrings.h is skipped.

  • Scripts/update-webkit-localizable-strings: Add the two icu directories

to the skip list.

2:49 PM Changeset in webkit [58776] by timothy@apple.com
  • 1 edit in trunk/WebKit/ChangeLog

Updated the localizable strings to run without errors.

Rubber-stamped by John Sullivan.

  • English.lproj/Localizable.strings: Updated.
  • StringsNotToBeLocalized.txt: Updated.
2:13 PM Changeset in webkit [58775] by steveblock@google.com
  • 4 edits in trunk/WebCore

JavaInstanceJSC.cpp and JNIUtilityPrivate.cpp need to include jni_jsobject.h for jlong_to_pt() and ptr_to_jlong()
​https://bugs.webkit.org/show_bug.cgi?id=38525

Reviewed by Darin Adler.

No new tests, build fix only.

  • bridge/jni/jni_jsobject.h: Guard Mac-specific code with PLATFORM(MAC)
  • bridge/jni/jsc/JNIUtilityPrivate.cpp: Include jni_jsobject.h
  • bridge/jni/jsc/JavaInstanceJSC.cpp: Include jni_jsobject.h
2:02 PM Changeset in webkit [58774] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-04 Steve Block <​steveblock@google.com>

Reviewed by Darin Adler.

New FileSystemPOSIX functions cause linker errors on Android
​https://bugs.webkit.org/show_bug.cgi?id=38521

No new tests, build fix only.

  • platform/android/FileSystemAndroid.cpp: Remove closeFile, which is provided in FileSystemPOSIX.cpp
  • platform/posix/FileSystemPOSIX.cpp: Guard writeToFile with !PLATFORM(ANDROID)
1:49 PM Changeset in webkit [58773] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove redundant exports to fix Windows build warnings.

1:37 PM Changeset in webkit [58772] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-04 Jesus Sanchez-Palencia <​jesus@webkit.org>

Reviewed by Eric Seidel.

Wrong documentation on 'webkit-patch help land'.
​https://bugs.webkit.org/show_bug.cgi?id=37871

Small fix on the help documentation for webkit-patch
land.

  • Scripts/webkitpy/tool/commands/download.py:
1:16 PM Changeset in webkit [58771] by Beth Dakin
  • 2 edits in trunk/WebKit/mac

Fix for <rdar://problem/7818509> Crash occurs when exiting Safari

Reviewed by Mike Thole.

We can avoid this crash if we call [self _removeFromAllWebViewsSet]
even in the case when we are doing a fastDocumentTeardown. This is
a much safer approach.

  • WebView/WebView.mm:

(-[WebView _close]):

1:13 PM Changeset in webkit [58770] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] http/tests/security/cross-frame-access-name-getter.html timed out
​https://bugs.webkit.org/show_bug.cgi?id=38540

  • platform/qt/Skipped: http/tests/security/cross-frame-access-name-getter.html skipped until bug fixed.
1:02 PM Changeset in webkit [58769] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-04 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Remove a bunch of test failures that are no longer failing (likely fixed in r58762).

  • platform/chromium/test_expectations.txt:
11:49 AM Changeset in webkit [58768] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2010-05-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: restore main and sidebar scroller positions
when switching between panels.

​https://bugs.webkit.org/show_bug.cgi?id=38522

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.elementsToRestoreScrollPositionsFor):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.hide): (WebInspector.Panel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.Panel.prototype._storeScrollPositions): (WebInspector.Panel.prototype._restoreScrollPositions):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.elementsToRestoreScrollPositionsFor):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
11:12 AM Changeset in webkit [58767] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, build fix for Qt skipping new notifications tests.

10:42 AM Changeset in webkit [58766] by eric@webkit.org
  • 5 edits
    4 adds in trunk

2010-05-04 Steven Lai <​steven_lai@asia.apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37900
<rdar://problem/7806164> cloneNode() does not preserve z-index with more than six digits

  • fast/dom/HTMLInputElement/clone-input-checked-expected.txt: Added.
  • fast/dom/HTMLInputElement/clone-input-checked.html: Added.
  • fast/dom/clone-node-z-index-expected.txt: Added.
  • fast/dom/clone-node-z-index.html: Added.

2010-05-04 Steven Lai <​steven_lai@asia.apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=37900
<rdar://problem/7806164> cloneNode() does not preserve z-index with more than six digits

Tests: fast/dom/HTMLInputElement/clone-input-checked.html

fast/dom/clone-node-z-index.html

  • dom/Element.cpp: undid the order change of calling copyNonAttributeProperties() before setAttributes() (WebCore::Element::cloneElementWithoutChildren): uncheck the previous radio button in the same radio button group only when the checked radio box is appended to the dom tree
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateCheckedRadioButtons): (WebCore::HTMLInputElement::attach): (WebCore::HTMLInputElement::setChecked):
  • html/HTMLInputElement.h:
10:20 AM Changeset in webkit [58765] by johnnyg@google.com
  • 8 edits
    4 adds in trunk

2010-04-29 John Gregg <​johnnyg@google.com>

Reviewed by Dmitry Titov.

notifications should have dir and replaceId attributes
​https://bugs.webkit.org/show_bug.cgi?id=38336

  • public/WebNotification.h:
  • src/WebNotification.cpp: (WebKit::WebNotification::dir): (WebKit::WebNotification::replaceId):

2010-04-29 John Gregg <​johnnyg@google.com>

Reviewed by Dmitry Titov.

notifications should have dir and replaceId attributes.
Note that tests are only enabled in Chromium, skipped elsewhere
since notifications aren't implemented.
​https://bugs.webkit.org/show_bug.cgi?id=38336

Tests: fast/notifications/notifications-replace.html

fast/notifications/notifications-rtl.html

  • notifications/Notification.h: (WebCore::Notification::dir): (WebCore::Notification::setDir): (WebCore::Notification::replaceId): (WebCore::Notification::setReplaceId):
  • notifications/Notification.idl:

2010-04-29 John Gregg <​johnnyg@google.com>

Reviewed by Dmitry Titov.

notifications should have dir and replaceId attributes
Tests are disabled until the attributes are correctly handled
in Chromium test_shell.
​https://bugs.webkit.org/show_bug.cgi?id=38336

  • fast/notifications/notifications-replace-expected.txt: Added.
  • fast/notifications/notifications-replace.html: Added.
  • fast/notifications/notifications-rtl-expected.txt: Added.
  • fast/notifications/notifications-rtl.html: Added.
  • platform/chromium/test_expectations.txt:
9:31 AM Changeset in webkit [58764] by eric@webkit.org
  • 5 edits in trunk

2010-05-04 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage viewMode property
​https://bugs.webkit.org/show_bug.cgi?id=38119

Rename the property from wrt_viewMode to _q_viewMode.

  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::viewModes):

2010-05-04 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage viewMode property
​https://bugs.webkit.org/show_bug.cgi?id=38119

Rename the property from wrt_viewMode to _q_viewMode.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature):
9:24 AM Changeset in webkit [58763] by alex
  • 2 edits in trunk/WebCore

2010-05-04 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Fixed error defining the float/double minimum in the object
properties, the smallest value of a float/double is
-G_MAXDOUBLE/-G_MAXFLOAT.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorGObject.pm:
8:55 AM Changeset in webkit [58762] by Joseph Pecoraro
  • 7 edits in trunk

2010-05-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dan Bernstein.

REGRESSION: Text clipped in absolutely positioned search inputs
​https://bugs.webkit.org/show_bug.cgi?id=38468

Update the test to include a second search field and show
the clipping of a search input is like a text input.

  • fast/css/input-search-padding.html:
  • platform/mac/fast/css/input-search-padding-expected.checksum:
  • platform/mac/fast/css/input-search-padding-expected.png:
  • platform/mac/fast/css/input-search-padding-expected.txt:

2010-05-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dan Bernstein.

REGRESSION: Text clipped in absolutely positioned search inputs
​https://bugs.webkit.org/show_bug.cgi?id=38468

Previously I incorrectly added x() and y() to the tx and ty positioning.
This clips a search input like a text input, respecting the vertically
centered text.

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): only the Y changes, so change setLocation to setY (WebCore::RenderTextControlSingleLine::controlClipRect):
8:41 AM Changeset in webkit [58761] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-04 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: REGRESSION: Up/Down, PgUp/PgDown keys do not change numeric style properties
​https://bugs.webkit.org/show_bug.cgi?id=38516

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
8:30 AM Changeset in webkit [58760] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2010-05-04 Ben Murdoch <​benm@google.com>

Reviewed by Simon Hausmann.

Crash in handleTouchEvent: using dangling node ptrs in hashmap
​https://bugs.webkit.org/show_bug.cgi?id=38514

  • fast/events/touch/resources/touch-stale-node-crash.js: Added.
  • fast/events/touch/resources/send-touch-up.html: Added.
  • fast/events/touch/touch-stale-node-crash-expected.txt: Added.
  • fast/events/touch/touch-stale-node-crash.html: Added.

2010-05-04 Ben Murdoch <​benm@google.com>

Reviewed by Simon Hausmann.

Crash in handleTouchEvent: using dangling node ptrs in hashmap
​https://bugs.webkit.org/show_bug.cgi?id=38514

When navigating away from a page, if you have your finger still
pressed and then lift it on the new page we see a crash if the
node got deleted as we still have a dangling pointer in the
m_originatingTouchPointTargets hashmap and try to use it as the
receiver to dispatch a touchend event.

Test: fast/events/touch/touch-stale-node-crash.html

  • page/EventHandler.cpp: (WebCore::EventHandler::clear): Clear the hashmap of touch targets.
7:54 AM QtWebKitPackaging edited by Simon Hausmann
(diff)
7:53 AM QtWebKitPackaging edited by Simon Hausmann
(diff)
7:52 AM QtWebKitPackaging edited by Simon Hausmann
(diff)
7:29 AM Changeset in webkit [58759] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-04 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Fix typo in run_webkit_tests.py: s/_print\./_printer./
​https://bugs.webkit.org/show_bug.cgi?id=38515

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:15 AM Changeset in webkit [58758] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-04 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Drawer Misbehaving when Docking / Undocking in Console Panel
​https://bugs.webkit.org/show_bug.cgi?id=38510

  • inspector/front-end/inspector.js: (WebInspector.set attached): resize the drawer after docking/undocking
7:04 AM Changeset in webkit [58757] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-05-04 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

[chromium] Make the select popup not close on right/middle clicks.
​https://bugs.webkit.org/show_bug.cgi?id=38473

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseDown):
7:04 AM Changeset in webkit [58756] by Laszlo Gombos
  • 2 edits in trunk

2010-05-04 Laszlo Gombos <Laszlo Gombos>

Unreviewed, build fix for Symbian.

[Symbian] Symbian builds does not support shadow builds

Revision r54715 broke the Symbian build. For Symbian
the include directory is generated in the root of the source tree.
This patch sets the INCLUDEPATH accordingly for Symbian.

  • WebKit.pri:
6:53 AM Changeset in webkit [58755] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-04 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Holger Freyther.

Fix a memory leak inside the QScriptValue.

QSciptValuePrivate::toString should release all temporary variables.

[Qt] QScriptValue::toString have a memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=38112

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toString):
6:30 AM Changeset in webkit [58754] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Preserve binary compatibility with qtwebkit-2.0 branch

Rubber-stamped by Tor Arne Vestbø.

Moved the WebGL attribute in QWebSettings to the end of the enum,
to ensure that the numeric values of the enum values following it
are the same as in the release branch.

  • Api/qwebsettings.h:
5:34 AM Changeset in webkit [58753] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-04 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Darin Adler.

Does not work on SPARC because of alignment issues
​https://bugs.webkit.org/show_bug.cgi?id=38455

Use AllocAlignmentInteger instead of void* on pageheap_memory to
avoid crashing at runtime in some architectures. Investigated by
Mike Hommey <​mh@glandium.org>, change suggested by Darin Adler.

  • wtf/FastMalloc.cpp:
5:31 AM Changeset in webkit [58752] by Laszlo Gombos
  • 3 edits in trunk/WebCore

2010-05-04 Laszlo Gombos <Laszlo Gombos>

Unreviewed, build fix for Symbian.

[Symbian] Build fix after r58598.

Use C99 integer types for the Symbian plugin
implementation.

No new tests, as there is no new functionality.

  • plugins/symbian/PluginPackageSymbian.cpp: (WebCore::PluginPackage::NPVersion):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::handlePostReadFile):
5:07 AM Changeset in webkit [58751] by Nikolas Zimmermann
  • 11 edits
    3 copies in trunk/WebCore

2010-05-04 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Split SVGCharacterLayoutInfo in smaller pieces
​https://bugs.webkit.org/show_bug.cgi?id=38513

Split SVGCharacterLayoutInfo into SVGCharacterLayoutInfo/SVGCharacterData and SVGTextChunkLayoutInfo.
This is a preparation for more work in the text area.

  • Android.mk: Add SVGCharacterData.(cpp|h) and SVGTextChunkLayoutInfo.h to build.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/SVGCharacterData.cpp: Copied from rendering/SVGCharacterLayoutInfo.cpp.
  • rendering/SVGCharacterData.h: Copied from rendering/SVGCharacterLayoutInfo.h. (WebCore::SVGChar::SVGChar):
  • rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::isInitialLayout): Introduced new helper function to share code between addLayoutInformation/addStackContent. (WebCore::SVGCharacterLayoutInfo::addLayoutInformation): Use new helper function. (WebCore::SVGCharacterLayoutInfo::addStackContent): Ditto
  • rendering/SVGCharacterLayoutInfo.h:
  • rendering/SVGRootInlineBox.h: Include new files.
  • rendering/SVGTextChunkLayoutInfo.h: Copied from rendering/SVGCharacterLayoutInfo.h.
4:49 AM BuildingQtOnOSX edited by vestbo@webkit.org
(diff)
4:48 AM Changeset in webkit [58750] by jeremy@chromium.org
  • 2 edits in trunk/LayoutTests

Revert r58747 - postponing Skia roll, at which time
we'll need to add these expected failures back.

​https://bugs.webkit.org/show_bug.cgi?id=38512

  • platform/chromium/test_expectations.txt:
4:16 AM Changeset in webkit [58749] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-04 Xan Lopez <​xlopez@igalia.com>

Reviewed by Holger Freyther.

[GTK] GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=33590

Use helper functions from CodeGenerator.pm to figure out whether a
type is "fundamental" or not (basically whether it's anything
other than a string or a non-pointer type).

  • bindings/scripts/CodeGeneratorGObject.pm:
3:25 AM Changeset in webkit [58748] by apavlov@chromium.org
  • 10 edits
    2 adds in trunk/WebCore

2010-04-30 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: REGRESSION: Disabled style properties are absent in Styles sidebar after WebInspector is re-opened
​https://bugs.webkit.org/show_bug.cgi?id=38255

Moved stylesheet-related mappings into a separate object stored
in InspectorController rather than InspectorDOMAgent (which gets reset
on every frontend [dis]connect).

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorCSSStore.cpp: Added. (WebCore::InspectorCSSStore::InspectorCSSStore): (WebCore::InspectorCSSStore::~InspectorCSSStore): (WebCore::InspectorCSSStore::reset):
  • inspector/InspectorCSSStore.h: Added.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setFrontend): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::bindStyle): (WebCore::InspectorDOMAgent::bindRule): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::buildObjectForRule):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create): (WebCore::InspectorDOMAgent::cssStore):
2:55 AM Changeset in webkit [58747] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-04 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Pavel Feldman.

Preparing for chromium skia roll incorporating changes up to r561.
Add expected failures so bots don't turn red while rolling.

​https://bugs.webkit.org/show_bug.cgi?id=38512

  • platform/chromium/test_expectations.txt:
2:36 AM Changeset in webkit [58746] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix to make Qt bot happier.

r58712 made fast/workers/worker-gc2.html crash. It seems to be a DRT sideeffect,
skipping worker-event-listener.html solve the problem until we find a real fix.
​https://bugs.webkit.org/show_bug.cgi?id=38502

  • platform/qt/Skipped: fast/workers/worker-event-listener.html skipped.
2:25 AM Changeset in webkit [58745] by mnaganov@chromium.org
  • 4 edits in trunk/WebCore

2010-05-04 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Display "Recording..." item when recording an user-initiated CPU profile.

​https://bugs.webkit.org/show_bug.cgi?id=38043

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.removeProfileHeader): (WebInspector.ProfilesPanel.prototype.showProfile):
  • inspector/front-end/inspector.js: (WebInspector.setRecordingProfile):
2:15 AM Changeset in webkit [58744] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2010-05-04 Tucker Jay <​jay.tucker@nokia.com>

Reviewed by Holger Freyther.

Animated GIF images does not animate 10x as expected by default.
​https://bugs.webkit.org/show_bug.cgi?id=36818

Added test case to existing manual test to test the
fixed functionality.

  • manual-tests/qt/qt-10loop-anim.gif: Added.
  • manual-tests/qt/qt-gif-test.html:
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::repetitionCount):
1:27 AM Changeset in webkit [58743] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-05-04 Dirk Schulze <​krit@webkit.org>

Unreviewed sort of XCodes project file.

  • WebCore.xcodeproj/project.pbxproj:
1:06 AM Changeset in webkit [58742] by Chris Jerdonek
  • 14 edits in trunk/WebKitTools

2010-05-04 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

This revision completes the terminology change from "processor" to
"checker" for the CarriageReturnProcessor, CppProcessor,
PythonProcessor, and TextProcessor classes, etc.

​https://bugs.webkit.org/show_bug.cgi?id=38262

The word "processor" currently has two uses in our code. This
revision renames the lower-level use to "checker" and preserves the
word "processor" for higher-level, more general uses. This
revision also makes whatever other name changes that logically
followed from this change.

  • Scripts/check-webkit-style:
    • Updated references to PatchChecker.
  • Scripts/webkitpy/style/checker.py:
    • Renamed the StyleCheckerConfiguration class to StyleProcessorConfiguration.
    • Renamed the ProcessorDispatcher class to CheckerDispatcher, and made similar changes for the class's method names.
    • Renamed the PatchChecker class to PatchReader.
    • Updated the file as necessary to accommodate the other class renames in this patch.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/checkers/common.py:
    • Renamed the CarriageReturnProcessor class to CarriageReturnChecker, and changed its process() method to check().
  • Scripts/webkitpy/style/checkers/common_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/checkers/cpp.py:
    • Renamed the CppProcessor class to CppChecker, and renamed its process() method to check().
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/checkers/python.py:
    • Renamed the PythonProcessor class to PythonChecker, and renamed its process() method to check().
  • Scripts/webkitpy/style/checkers/python_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/checkers/text.py:
    • Renamed the TextProcessor class to TextChecker, and renamed its process() method to check().
  • Scripts/webkitpy/style/checkers/text_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/error_handlers.py:
    • Updated the code as necessary.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Updated the unit test code as necessary.
1:00 AM Changeset in webkit [58741] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-05-04 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

Adjusted svn-apply and -unapply to accept git diffs generated
using the --no-prefix flag.

​https://bugs.webkit.org/show_bug.cgi?id=32438

  • Scripts/VCSUtils.pm:
    • Loosened the regular expression for the "diff --git" line to match when the --no-prefix flag is used with "git diff".
    • Also refactored the code parsing the first line so that the script exits with an error message if the first line cannot be parsed.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
    • Added a unit test case for the --no-prefix case.
12:57 AM Changeset in webkit [58740] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/JavaScriptCore

2010-05-04 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add first WTFURL file
​https://bugs.webkit.org/show_bug.cgi?id=38470

This class represents a component of a URL, such as the scheme or path.
Essentially, the class is an index into a string buffer.

  • wtf/url: Added.
    • There was some discussion about where to put the URL library. There are a number of reasonable options, but putting the library in the WTF directory seems like a reasonable alternative. This location will make more sense once WTF is moved out of JavaScriptCore and into a top-level directory.
  • wtf/url/src: Added.
    • I've added this extra directory to the usual structure because we eventually want a "public" folder that defines the public interface to this library that clients outside of svn.webkit.org can rely upon, much like the various subfolders of the WebKit directory often define a public API.
  • wtf/url/src/URLComponent.h: Added.
    • I've added this somewhat trivial class to get the ball rolling.

(WTF::URLComponent::URLComponent):
(WTF::URLComponent::isValid):
(WTF::URLComponent::isNonempty):
(WTF::URLComponent::reset):
(WTF::URLComponent::operator==):
(WTF::URLComponent::begin):
(WTF::URLComponent::setBegin):
(WTF::URLComponent::length):
(WTF::URLComponent::setLength):
(WTF::URLComponent::end):

  • wtf/url/wtfurl.gyp: Added.
    • WTFURL will be an independently buildable library, hence the beginnings of a wtfurl.gyp file.
12:55 AM Changeset in webkit [58739] by Chris Jerdonek
  • 3 edits
    1 copy
    1 delete in trunk/WebKitTools

2010-05-04 Chris Jerdonek <Chris Jerdonek>

Reviewed by Daniel Bates.

Changed VCSUtils.pm's parseDiffHeader() to call the new
parseGitDiffHeader() method.

​https://bugs.webkit.org/show_bug.cgi?id=38454

This revision makes more progress towards adding executable-bit
support to svn-apply and svn-unapply. It also makes more progress
towards refactoring the code into a more maintainable form.

  • Scripts/VCSUtils.pm:
    • Removed gitdiff2svndiff().
    • Removed the Git-specific logic from parseDiffHeader() and renamed it parseSvnDiffHeader().
    • Added a new parseDiffHeader() subroutine which calls parseSvnDiffHeader() or parseGitDiffHeader() depending on the format of the first header line.
  • Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Removed.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Removed most of the test cases since these cases are now covered by the unit tests for parseSvnDiffHeader() and parseGitDiffHeader().
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl: Added.
    • Copied the SVN unit tests from parseDiffHeader.pl and updated them as necessary.
12:22 AM Changeset in webkit [58738] by alex
  • 2 edits in trunk/LayoutTests

2010-05-04 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, skip test.

Skipping inspector/timeline-parse-html.html
​https://bugs.webkit.org/show_bug.cgi?id=38509

  • platform/gtk/Skipped:
12:03 AM Changeset in webkit [58737] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-03 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Builders should run the perl and python unit tests on every commit
​https://bugs.webkit.org/show_bug.cgi?id=37976

The unit tests take a few seconds to run, so they should not
have any noticable effect on builder speed.

We're running the tests everywhere but Tiger as Tiger's
Python version is ancient.
I would have rather have detected the python version of the
slave but I couldn't find any API to do that, and I didn't want
to hack version detection into test-webkitpy (at least not yet).

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

May 3, 2010:

11:52 PM Changeset in webkit [58736] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-05-03 Steven Lai <​steven_lai@asia.apple.com>

Reviewed by Brady Eidson.

Test hashchange() event is fired in asynchronous manner.
​https://bugs.webkit.org/show_bug.cgi?id=36201

  • fast/loader/hashchange-event-async-expected.txt: Added.
  • fast/loader/hashchange-event-async.html: Added.

2010-05-03 Steven Lai <​steven_lai@asia.apple.com>

Reviewed by Brady Eidson.

Reverted hashchange() event back to async.
(This change does not update HashChangeEvent to its new proposed interface)
​https://bugs.webkit.org/show_bug.cgi?id=36201
rdar://problem/7780794
rdar://problem/7761278 (partial fix)

Tests: fast/loader/hashchange-event-async.html

  • dom/Document.cpp: reverted hashchange() event back to async (WebCore::Document::enqueueHashchangeEvent):
11:14 PM Changeset in webkit [58735] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-05-03 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

Fixed a recent REGRESSION that caused svn-apply and -unapply to
skip over changes to the first file in a diff if leading junk was
present (like in an e-mail diff) and if the --force option was used.

​https://bugs.webkit.org/show_bug.cgi?id=38507

  • Scripts/svn-apply:
    • Removed the bit of code at the beginning of the patch() subroutine that checks for the "Index:" line at the beginning of a file diff (since the parsePatch() subroutine already checks this).
  • Scripts/svn-unapply:
    • Removed the bit of code at the beginning of the patch() subroutine that checks for the "Index:" line at the beginning of a file diff (since the parsePatch() subroutine already checks this).
9:44 PM Changeset in webkit [58734] by zecke@webkit.org
  • 3 edits in trunk/WebCore

[Cairo,WX] Stop leaking a FontPlatformData.

Allocate the FontPlatformData on the stack and fix
a memory leak by doing so.

2010-05-03 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber-stamped by Xan Lopez.

[Cairo,WX] Stop leaking a FontPlatformData.
​https://bugs.webkit.org/show_bug.cgi?id=37500

Stephan Aßmus pointed out that the pango font backend
is leaking memory and fixed it. The WX font backend
and the Cairo/Fontconfig backend have the same snippet
of code and are leaking memory as well. This commit is
fixing that.

  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::smallCapsFontData):
  • platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::smallCapsFontData):
9:16 PM Changeset in webkit [58733] by Chris Jerdonek
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed.

Adjusted the ChangeLog entry below for r58732 (bug 35804) to reflect
the fact that the change will not become active until the patch
for bug 38454 lands.

9:00 PM Changeset in webkit [58732] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

2010-05-03 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

The svn-apply and svn-unapply scripts now display an instructive
error message if the --binary flag is left off the "git diff" command
for diffs containing binary file differences.

​https://bugs.webkit.org/show_bug.cgi?id=35804

  • Scripts/VCSUtils.pm:
    • Adjusted parseDiffHeader() to exit with an appropriate error message if it encounters a line of the form "Binary files <path1> and <path2> differ".
7:53 PM Changeset in webkit [58731] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests: r58728 broke the buildbot logic for parsing the
output of the log; specifying --verbose should basically be equivalent
to --print everything, but instead it was equivalent to not specifying
--print and getting the default set. Now, --verbose acts as if
--print everything was implicitly specified as the default (you can
still override it if you specify both; this is a somewhat debatable
call).

​https://bugs.webkit.org/show_bug.cgi?id=38504

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
7:39 PM Changeset in webkit [58730] by Stephanie Lewis
  • 2 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=38368
<rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028
(return memory quicker).
Instead of returning everything but the smallest spans spread out
the spans kept over several size lists.

Reviewed by Geoff Garen.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::scavenge):

7:26 PM Changeset in webkit [58729] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests: Fix minor precedence bug introduced in r58728 where we printed
"-\n" 78 times instead of "-" 78 times followed by a single "\n".

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
6:59 PM Changeset in webkit [58728] by dpranke@chromium.org
  • 6 edits
    2 adds in trunk/WebKitTools

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: refactor a large chunk of the printing/logging
code out of run-webkit-tests py (almost 300 lines out of 1900).

This change also renames --log to --print (to be slightly more
descriptive). I've also added better help messages for printing.

The new code has unit tests!

There is still more code to be moved, but this patch is big enough as
it is. Namely, still to move are the printing of the actual results
and the timing statistics, which should move another 300-400 lines
out of the file.

Notable changes to run_webkit_tests.py beyond code simply moving:

  • MeteredStream is now hidden under the new printing.Printer class. All the references to self._meter now point to self._printer.
  • All logging configuration is done in printing.configure_logging()
  • Instead of using write() lambdas to control what is and isn't printed, we use separate methods on the printer object. This will make it easier to grep which print statements are printed under protection of each flag.
  • The print_results flag I added a few revs back to suppress printing in the unit tests has been replaced with --print nothing.
  • The ResultSummary class now stores the entire TestResult for each test, not just the actual result type.
  • summarize_unexpected_results() got moved from a method on TestRunner to a standalone function. This should move into a separate file along with the ResultSummary class and the TestResult class
  • The --trace option added recently has been replaced by '--print trace-everything' and '--print trace-unexpected'

​https://bugs.webkit.org/show_bug.cgi?id=38018

  • Scripts/new-run-webkit-tests:
    • update to new entry points in run_webkit_tests.py
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
    • fix a minor nit where we were printing an empty string where we didn't need to
  • Scripts/webkitpy/layout_tests/layout_package/printing.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Added
  • Scripts/webkitpy/layout_tests/port/test.py:
    • implement relative_test_filename() and expected_filename() so we can test printing unexpected results in a platform-neutral way
  • Scripts/webkitpy/run_webkit_test.py:
    • move a lot of the printing code into printing.py
    • change the signatures of the exported entry points for easier unit testing
  • Scripts/webkitpy/run_webkit_tests_unittest.py:
    • update w/ changes to run_webkit_tests entry points.
6:55 PM Changeset in webkit [58727] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-05-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Expose HTMLTokenizer yielding parameters
​https://bugs.webkit.org/show_bug.cgi?id=37023

Enables to set TimeDelay and ChunkSize for
HTMLTokenizer.

  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent):
6:37 PM Changeset in webkit [58726] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Fix expectation for fast/forms/searchfield-heights.html - IMAGE+TEXT
on Linux, IMAGE on win and mac.

  • platform/chromium/test_expectations.txt:
6:32 PM Changeset in webkit [58725] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Restore editing/pasteboard/paste-xml.xhtml as failing w/ a TEXT
failure (was failing prior to landing fix for 27751).

Mark editiing/selection/caret-rtl-2.html as failing w/ IMAGE; need
to investigate further.

Mark svg/text/kerning.svg as failing on mac w/ IMAGE as well as Linux.

  • platform/chromium/test_expectations.txt:
6:08 PM Changeset in webkit [58724] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dirk Pranke.

Roll back test expectations change, initially needed to land bug 27751.

  • platform/chromium/test_expectations.txt:
5:45 PM Changeset in webkit [58723] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild

5:42 PM Changeset in webkit [58722] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Roll in Chromium expectations from overrides file.

  • platform/chromium/test_expectations.txt:
5:35 PM Changeset in webkit [58721] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark the SVG test failures as linux-only.
Mark fast/forms/searchfield-heights.html as IMAGE+TEXT, not IMAGE.

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [58720] by andersca@apple.com
  • 3 edits in trunk/WebKit2

2010-05-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon Honeycutt.

[WebKit2] WKView should respond to WM_SHOWWINDOW messages
​https://bugs.webkit.org/show_bug.cgi?id=38496

  • UIProcess/win/WebView.cpp: (WebKit::WebView::wndProc): Add case for WM_SHOWWINDOW.

(WebKit::WebView::onShowWindowEvent):
Update the page visibility accordingly.

  • UIProcess/win/WebView.h:
5:07 PM Changeset in webkit [58719] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

And add one more Linux test (fast/forms/search-placeholder-value-changed.html)
from r58700. Plus, fix sorting of tests from that rev.

  • platform/chromium/test_expectations.txt:
5:03 PM Changeset in webkit [58718] by jamesr@google.com
  • 6 edits in trunk

2010-05-03 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

Clean up a few compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=38073

  • wtf/text/StringImpl.cpp: (WebCore::StringImpl::ascii):

2010-05-03 James Robinson <​jamesr@chromium.org>

Reviewed by Eric Seidel.

Clean up a few compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=38073

  • html/TextMetrics.h: (WebCore::TextMetrics::width):
  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.h:
5:01 PM Changeset in webkit [58717] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark yet more mac-specific tests as failling from r58700.

  • platform/chromium/test_expectations.txt:
4:48 PM Changeset in webkit [58716] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark more tests as failing from r58700 and change the sandbox test from SLOW to a
flaky PASS TIMEOUT.

  • platform/chromium/test_expectations.txt:
4:43 PM Changeset in webkit [58715] by Darin Adler
  • 3 edits in trunk/WebKit
  • English.lproj/Localizable.strings: Regenerated.
  • StringsNotToBeLocalized.txt: Updated for recent changes.
4:09 PM Changeset in webkit [58714] by andersca@apple.com
  • 10 edits in trunk/WebKit2

2010-05-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of PageClient::isPageVisible and pass visibility directly in setPageIsVisible
​https://bugs.webkit.org/show_bug.cgi?id=38493

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: Remove isPageVisible.


  • UIProcess/API/mac/WKView.mm: (isViewVisible): New function (moved here from PageClientImpl).


(-[WKView _updateVisibility]):
Call didChangeVisibility.


(-[WKView viewDidMoveToWindow]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
Call _updateVisibility.


  • UIProcess/DrawingAreaProxy.h: Rename didChangeVisibility to setPageIsVisible and add an isVisible parameter.


  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: (WebKit::DrawingAreaProxyUpdateChunk::setPageIsVisible): Don't call WebPageProxy::isVisible.
  • UIProcess/DrawingAreaProxyUpdateChunk.h:


  • UIProcess/PageClient.h: Remove isPageVisible.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h: Remove isVisible.
4:07 PM Changeset in webkit [58713] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark more editing/* tests from r58703 as failing. Also, (re-?) add the SVG tests again
as they do fail on some platforms.

  • platform/chromium/test_expectations.txt:
4:03 PM Changeset in webkit [58712] by barraclough@apple.com
  • 16 edits
    1 delete in trunk/JavaScriptCore

Rolling out r58114 - this introduced memory leaks of
AtomicStrings then workers terminated.

Reviewed by NOBODY (reverting previous commit).

(JSC::ThunkHelpers::stringImplDataOffset):

  • runtime/Identifier.cpp:

(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierCStringTranslator::equal):
(JSC::IdentifierCStringTranslator::translate):
(JSC::Identifier::add):
(JSC::IdentifierUCharBufferTranslator::hash):
(JSC::IdentifierUCharBufferTranslator::equal):
(JSC::IdentifierUCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):

  • runtime/Identifier.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:
  • wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):

  • wtf/WTFThreadData.h:

(JSC::IdentifierTable::remove):
(JSC::IdentifierTable::literalTable):
(WTF::WTFThreadData::atomicStringTable):

  • wtf/text/AtomicString.cpp:

(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable):
(WebCore::CStringTranslator::hash):
(WebCore::CStringTranslator::equal):
(WebCore::CStringTranslator::translate):
(WebCore::operator==):
(WebCore::AtomicString::add):
(WebCore::equal):
(WebCore::UCharBufferTranslator::hash):
(WebCore::UCharBufferTranslator::equal):
(WebCore::UCharBufferTranslator::translate):
(WebCore::HashAndCharactersTranslator::hash):
(WebCore::HashAndCharactersTranslator::equal):
(WebCore::HashAndCharactersTranslator::translate):
(WebCore::AtomicString::find):
(WebCore::AtomicString::remove):

  • wtf/text/AtomicStringTable.h: Removed.
  • wtf/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
(WebCore::equal):

  • wtf/text/StringImplBase.h:

(WTF::StringImplBase::StringImplBase):

3:46 PM Changeset in webkit [58711] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittently on Qt bot
Fails caused by layoutTestController.display() in fast/frames/flattening/frameset-flattening-subframe-resize.html
​https://bugs.webkit.org/show_bug.cgi?id=37334

  • platform/qt/Skipped:
    • fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix
    • fast/frames/flattening/frameset-flattening-subframesets.html unskipped, because it works.
3:37 PM Changeset in webkit [58710] by dumi@chromium.org
  • 3 edits
    5 adds in trunk/WebCore

Add the ability to auto-generate callbacks to all code generators.
​https://bugs.webkit.org/show_bug.cgi?id=38414

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp: Added.

(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
(WebCore::JSTestCallback::callbackWithClass1Param):
(WebCore::JSTestCallback::callbackWithClass2Param):

  • bindings/scripts/test/JS/JSTestCallback.h: Added.

(WebCore::JSTestCallback::create):

  • bindings/scripts/test/V8/JSTestCallback.cpp: Added.

(WebCore::V8TestCallback::V8TestCallback):
(WebCore::V8TestCallback::~V8TestCallback):
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):

  • bindings/scripts/test/V8/V8TestCallback.h: Added.

(WebCore::V8TestCallback::create):

  • bindings/scripts/test/TestCallback.idl: Added.
3:37 PM Changeset in webkit [58709] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Kevin Ollivier.

[wx] Implement scheduleDispatchFunctionsOnMainThread for wx port.
​https://bugs.webkit.org/show_bug.cgi?id=38480

3:34 PM Changeset in webkit [58708] by kevino@webkit.org
  • 1 edit in trunk/WebKit/wx/ChangeLog

Fix missing bug URL.

3:31 PM Changeset in webkit [58707] by kevino@webkit.org
  • 23 edits
    1 add in trunk

Reviewed by Kevin Ollivier.

[wx] Build and use Mac's ComplexTextController to support complex text in wx.
​https://bugs.webkit.org/show_bug.cgi?id=38482

3:27 PM Changeset in webkit [58706] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark the editing/* tests from r58703 as temporarily expected to fail
until the other half of the two-sided patch can land.

  • platform/chromium/test_expectations.txt:
3:18 PM Changeset in webkit [58705] by oliver@apple.com
  • 4 edits in trunk

2010-05-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Interpreter crashes due to incorrect refcounting of cached structures.
​https://bugs.webkit.org/show_bug.cgi?id=38491
rdar://problem/7926160

Make sure we ref/deref structures used for cached custom property getters

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):

2010-05-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Interpreter crashes due to incorrect refcounting of cached structures.
​https://bugs.webkit.org/show_bug.cgi?id=38491

Add test for cached structure chains used for custom getters.

  • fast/js/pic/cached-named-property-getter.html:
2:51 PM Changeset in webkit [58704] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Fix duplicate expectation, remove the SVG tests added in r58700.

  • platform/chromium/test_expectations.txt:
2:50 PM Changeset in webkit [58703] by abarth@webkit.org
  • 43 edits
    3 adds in trunk

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Tests that javascript cannot access clipboard.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • editing/execCommand/clipboard-access-expected.txt: Added.
  • editing/execCommand/clipboard-access.html: Added.
  • editing/execCommand/script-tests/clipboard-access.js: Added. (enabled): (whenEnabled):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

Test: editing/execCommand/clipboard-access.html

  • WebCore.base.exp:
  • editing/EditorCommand.cpp: (WebCore::supportedCopyCut): (WebCore::supportedPaste): (WebCore::createCommandMap):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setJavaScriptCanAccessClipboard):
  • page/Settings.h: (WebCore::Settings::javaScriptCanAccessClipboard):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
  • src/WebSettingsImpl.h:

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences javaScriptCanAccessClipboard]): (-[WebPreferences setJavaScriptCanAccessClipboard:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::javaScriptCanAccessClipboard): (WebPreferences::setJavaScriptCanAccessClipboard):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

2010-05-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is enabled in test framework.
​https://bugs.webkit.org/show_bug.cgi?id=27751

  • DumpRenderTree/LayoutTestController.cpp: (setJavaScriptCanAccessClipboardCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::overridePreference):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
2:43 PM Changeset in webkit [58702] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark a sandbox test as SLOW and change one of the fast/forms tests I
just changed from IMAGE+TEXT->IMAGE back to IMAGE.

  • platform/chromium/test_expectations.txt:
2:34 PM Changeset in webkit [58701] by andersca@apple.com
  • 4 edits in trunk/WebKitTools

2010-05-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Maui MiniBrowser: Add an option to show/hide the web view
​https://bugs.webkit.org/show_bug.cgi?id=38486

  • MiniBrowser/win/BrowserWindow.cpp: (BrowserWindow::createWindow): Set the background brush to something other than null.

(BrowserWindow::onCommand):
Show and hide the web view accordingly.


  • MiniBrowser/win/MiniBrowser.rc:
  • MiniBrowser/win/resource.h: Add new menu item.
2:15 PM Changeset in webkit [58700] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Change expectations for some of the fast/forms tests that just started
failing from IMAGE+TEXT to just IMAGE, and add some failing SVG tests
so that we can get the bots to green up.

  • platform/chromium/test_expectations.txt:
1:45 PM Changeset in webkit [58699] by eric@webkit.org
  • 5 edits in trunk/WebKit/wx

2010-05-03 Kevin Watters <​kevinwatters@gmail.com>

Reviewed by Kevin Ollivier.

Provide access to GrantUniversalAccess to allow enabling of XSS support.

  • WebFrame.cpp: (wxWebFrame::GrantUniversalAccess):
  • WebFrame.h:
  • WebView.cpp: (wxWebView::GetParseMode): (wxWebView::GrantUniversalAccess):
  • WebView.h:
1:36 PM Changeset in webkit [58698] by yaar@chromium.org
  • 6 edits in trunk/LayoutTests

2010-05-03 Yaar Schnitman <​yaar@chromium.org>

Not Reviewed.

Preparing for chromium webkit roll 58626:TBD: Rebaselines
​https://bugs.webkit.org/show_bug.cgi?id=38485

  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [58697] by andersca@apple.com
  • 4 edits in trunk/WebKit2

2010-05-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Implement PageClient::isPageVisible on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=38483

  • UIProcess/PageClient.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::isPageVisible):
  • UIProcess/win/WebView.h:
1:12 PM Changeset in webkit [58696] by ap@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed a typo in ChangeLog.

1:04 PM Changeset in webkit [58695] by ap@apple.com
  • 3 edits
    5 adds in trunk

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=38285
<rdar://problem/7903453> REGRESSION: Javascript command window.open does not work in empty tab

Cannot be tested, because new windows created in DRT always have an opener, and thus inherit
its security origin. Only new windows and tabs created by browser chrome had this problem.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Moved updateSandboxFlags() call to the beginning, so that an initial document would get correct flags.

LayoutTests:

These tests don't verify that this bug is fixed (that cannpt be tested automatically),
but test closely related behavior that hasn't been covered before.

  • http/tests/security/resources/iframe-no-src.html: Added.
  • http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt: Added.
  • http/tests/security/sandbox-inherit-to-initial-document-2.html: Added.
  • http/tests/security/sandbox-inherit-to-initial-document-expected.txt: Added.
  • http/tests/security/sandbox-inherit-to-initial-document.html: Added.
12:51 PM Changeset in webkit [58694] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-03 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Darin Adler.

WebGL compile issue.
Added ExceptionCode.h to JSWebGLArrayBufferConstructor.cpp, for some reason it was missing.
​https://bugs.webkit.org/show_bug.cgi?id=38453

No new tests: compile fix.

  • bindings/js/JSWebGLArrayBufferConstructor.cpp:
12:47 PM Changeset in webkit [58693] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Fix Windows build.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::sendOutgoingMessage):

  • Shared/win/UpdateChunk.cpp:

(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):

  • Shared/win/UpdateChunk.h:

(WebKit::UpdateChunk::rect):

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyUpdateChunk.h:
  • UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp:

(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):

  • WebProcess/WebPage/win/DrawingAreaUpdateChunkWin.cpp:

(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):

  • WebProcess/win/WebProcessMain.cpp:
12:11 PM Changeset in webkit [58692] by yaar@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Yaar Schnitman <​yaar@chromium.org>

Not Reviewed.

Preparing for Chromium WebKit roll 58626:TBD
​https://bugs.webkit.org/show_bug.cgi?id=38479

  • platform/chromium/test_expectations.txt: added missing expectation
11:51 AM Changeset in webkit [58691] by yaar@chromium.org
  • 9 edits
    4 adds in trunk/LayoutTests

2010-05-03 Yaar Schnitman <​yaar@chromium.org>

Not Reviewed.

Added missing chromium baselines for svg text kerning
​https://bugs.webkit.org/show_bug.cgi?id=38476

  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • platform/chromium-win/svg/text/kerning-expected.checksum:
  • platform/chromium-win/svg/text/kerning-expected.png:
  • platform/chromium-win/svg/text/text-hkern-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-hkern-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:49 AM Changeset in webkit [58690] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-03 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r58685.
​http://trac.webkit.org/changeset/58685
​https://bugs.webkit.org/show_bug.cgi?id=38461

Broke a test on Gtk

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates):
11:23 AM Changeset in webkit [58689] by yaar@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-03 Yaar Schnitman <​yaar@chromium.org>

Not Reviewed.

Preparing for chromium webkit roll 58626:TBD
​https://bugs.webkit.org/show_bug.cgi?id=38474

  • platform/chromium/test_expectations.txt: Added temporary expectations.
11:19 AM Changeset in webkit [58688] by andersca@apple.com
  • 10 edits in trunk/WebKit2

2010-04-30 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=38415
Have the WKView notify the DrawingAreaProxy when its visibility changes.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::isPageVisible):
  • UIProcess/API/mac/WKView.mm: (-[WKView viewDidMoveToWindow]): (-[WKView viewDidHide]): (-[WKView viewDidUnhide]):
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: (WebKit::DrawingAreaProxyUpdateChunk::DrawingAreaProxyUpdateChunk): (WebKit::DrawingAreaProxyUpdateChunk::didChangeVisibility):
  • UIProcess/DrawingAreaProxyUpdateChunk.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::isVisible):
  • UIProcess/WebPageProxy.h:
11:16 AM Changeset in webkit [58687] by yael.aharon@nokia.com
  • 7 edits in trunk

Use HTML5 number parsing in HTMLProgressElement
​https://bugs.webkit.org/show_bug.cgi?id=38434

Reviewed by Darin Adler.

WebCore:

Use parseToDoubleForNumberType instead of toDouble.
Throw an exception when the number is NaN or Infinity.

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::value):
(WebCore::HTMLProgressElement::setValue):
(WebCore::HTMLProgressElement::max):
(WebCore::HTMLProgressElement::setMax):

  • html/HTMLProgressElement.h:
  • html/HTMLProgressElement.idl:

LayoutTests:

  • fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js:
  • fast/dom/HTMLProgressElement/set-progress-properties-expected.txt:
11:12 AM Changeset in webkit [58686] by eric@webkit.org
  • 24 edits in trunk

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareSubmit): Call frame loader's dispatchWillSendSubmitEvent
  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchWillSendSubmitEvent): New empty method

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • efl/WebCoreSupport/FrameLoaderClientEfl.h: (WebCore::FrameLoaderClientEfl::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • public/WebFrameClient.h: (WebKit::WebFrameClient::willSendSubmitEvent): New empty method
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillSendSubmitEvent): Delegate to client
  • src/FrameLoaderClientImpl.h:

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientGtk.h: (WebKit::FrameLoaderClient::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientHaiku.h: (WebCore::FrameLoaderClientHaiku::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/WebFrameLoaderClient.h: (WebFrameLoaderClient::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientQt.h: (WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebFrame.h:

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebKitSupport/FrameLoaderClientWx.h: (WebCore::FrameLoaderClientWx::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h: (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
10:58 AM Changeset in webkit [58685] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-05-03 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] forgotten call to durationChanged in updateStates()
​https://bugs.webkit.org/show_bug.cgi?id=38461

Notify MediaPlayer if duration is known after playback started.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates):
10:28 AM Changeset in webkit [58684] by weinig@apple.com
  • 9 edits
    1 add
    4 deletes in trunk/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=38471
Add generic callback mechanism

Reviewed by Anders Carlsson.

Added GenericCallback class replacing RenderTreeExternalRepresentationCallback
and ScriptReturnValueCallback.

Also,

  • Standardize C API callbacks to take the context last.
  • Standardize C API callbacks to not have the _f suffix (now the block variants have a _b suffix).
  • Re-write toWK and toRef methods as a set of template functions using the generic API->implementation mapping information.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame):
(callRunJavaScriptBlockAndRelease):
(disposeRunJavaScriptBlock):
(WKPageRunJavaScriptInMainFrame_b):
(WKPageRenderTreeExternalRepresentation):
(WKPageRenderTreeExternalRepresentation_b):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/GenericCallback.h: Added.

(WebKit::GenericCallback::create):
(WebKit::GenericCallback::~GenericCallback):
(WebKit::GenericCallback::performCallbackWithReturnValue):
(WebKit::GenericCallback::invalidate):
(WebKit::GenericCallback::callbackID):
(WebKit::GenericCallback::generateCallbackID):
(WebKit::GenericCallback::GenericCallback):

  • UIProcess/RenderTreeExternalRepresentationCallback.cpp: Removed.
  • UIProcess/RenderTreeExternalRepresentationCallback.h: Removed.
  • UIProcess/ScriptReturnValueCallback.cpp: Removed.
  • UIProcess/ScriptReturnValueCallback.h: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::didGetRenderTreeExternalRepresentation):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
10:25 AM Changeset in webkit [58683] by abarth@webkit.org
  • 1 delete in trunk/URLCore

Remove URLCore top-level directory. The diff wasn't clear where this folder was going and Darin Adler would prefer that we not put this code in a top-level directory.

10:24 AM Changeset in webkit [58682] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-03 Ryuan Choi <​ryuan.choi@gmail.com>

Reviewed by Darin Adler.

fixing build break due to clearWatch() when Geolocation feature is
disabled.

​https://bugs.webkit.org/show_bug.cgi?id=38091

no test because this is a build fix only

  • page/Geolocation.cpp: (WebCore::Geolocation::clearWatch):
10:09 AM Changeset in webkit [58681] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-03 Chris Jerdonek <Chris Jerdonek>

Reviewed by Daniel Bates.

Added a parseGitDiffHeader() subroutine to VCSUtils.pm that
parses any changes to the executable bit in a Git diff.

​https://bugs.webkit.org/show_bug.cgi?id=38425

This revision is more preparation towards adding "executable bit"
support to svn-apply and svn-unapply. No code is going "live" in
this change except for the new unit tests in test-webkitperl.

  • Scripts/VCSUtils.pm:
    • Added isExecutable() to determine whether a file mode has the executable bit set or not.
    • Added parseGitDiffHeader() to parse the header of a Git diff.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Added.
    • Added unit tests for parseGitDiffHeader().
10:00 AM Changeset in webkit [58680] by abarth@webkit.org
  • 2 adds in trunk/URLCore

Add empty folder to house URL parser
​https://bugs.webkit.org/show_bug.cgi?id=38470

Reviewed by Darin Adler.

Add URLCore directory.

9:56 AM Changeset in webkit [58679] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-03 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by Holger Freyther.

[Gtk] Fix leaking the FontPlatformData instance used to create the the
small caps font data.
​https://bugs.webkit.org/show_bug.cgi?id=37500

No new tests needed.

  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::smallCapsFontData):
    • Use a stack allocated FontPlatformData instead of a heap allocated one that is never freed.
9:37 AM Changeset in webkit [58678] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-03 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: support webGL
​https://bugs.webkit.org/show_bug.cgi?id=35388

Added support GraphicsContext3D to GraphicsLayer.
Added paint method to GraphicsContext3D for Qt platform that
uses drawTexture() when QGLWidget is used as viewport of
QGraphicsWebView.
Fine-tuned texture and handling and image to texture conversion to
work also when drawTexture() blitting is used.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::paint): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::): (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsToGraphicsContext3D): (WebCore::GraphicsLayerQt::setGraphicsContext3DNeedsDisplay):
  • platform/graphics/qt/GraphicsLayerQt.h:
9:20 AM Changeset in webkit [58677] by abarth@webkit.org
  • 2 edits in trunk

2010-05-03 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add some more Chromium-specific files to gitignore
​https://bugs.webkit.org/show_bug.cgi?id=38469

These files are generated as part of the update-webkit --chromium
script.

  • .gitignore:
8:59 AM Changeset in webkit [58676] by Csaba Osztrogonác
  • 1 edit
    14 adds in trunk/LayoutTests

Unreviewed. Qt specific expected files added after r58675.

  • platform/qt/editing/pasteboard/4944770-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/5028447-expected.txt: Added.
  • platform/qt/editing/pasteboard/5089327-expected.txt: Added.
  • platform/qt/editing/pasteboard/5601583-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-text-013-expected.txt: Added.
  • platform/qt/editing/pasteboard/select-element-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/testcase-9507-expected.txt: Added.
  • platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
  • platform/qt/editing/pasteboard/unrendered-br-expected.txt: Added.
8:39 AM Changeset in webkit [58675] by robert@webkit.org
  • 105 edits
    4 adds in trunk/LayoutTests

2010-05-03 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed. Qt specific expected files added and updated.

[Qt] Unskip editing/pasteboard tests that fail due to 'x,y' differences
​https://bugs.webkit.org/show_bug.cgi?id=38435

  • platform/qt/editing/pasteboard/3976872-expected.txt:
  • platform/qt/editing/pasteboard/4076267-3-expected.txt:
  • platform/qt/editing/pasteboard/4242293-expected.txt:
  • platform/qt/editing/pasteboard/4631972-expected.txt:
  • platform/qt/editing/pasteboard/4641033-expected.txt:
  • platform/qt/editing/pasteboard/4700297-expected.txt:
  • platform/qt/editing/pasteboard/4806874-expected.txt:
  • platform/qt/editing/pasteboard/4840662-expected.txt:
  • platform/qt/editing/pasteboard/4944770-1-expected.txt:
  • platform/qt/editing/pasteboard/4944770-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/4989774-expected.txt:
  • platform/qt/editing/pasteboard/5006779-expected.txt:
  • platform/qt/editing/pasteboard/5027857-expected.txt:
  • platform/qt/editing/pasteboard/5028447-expected.txt: Added.
  • platform/qt/editing/pasteboard/5032095-expected.txt:
  • platform/qt/editing/pasteboard/5065605-expected.txt:
  • platform/qt/editing/pasteboard/5071074-2-expected.txt:
  • platform/qt/editing/pasteboard/5071074-expected.txt:
  • platform/qt/editing/pasteboard/5075944-2-expected.txt:
  • platform/qt/editing/pasteboard/5075944-3-expected.txt:
  • platform/qt/editing/pasteboard/5075944-expected.txt:
  • platform/qt/editing/pasteboard/5089327-expected.txt: Added.
  • platform/qt/editing/pasteboard/5134759-expected.txt:
  • platform/qt/editing/pasteboard/5156401-1-expected.txt:
  • platform/qt/editing/pasteboard/5245519-expected.txt:
  • platform/qt/editing/pasteboard/5247341-expected.txt:
  • platform/qt/editing/pasteboard/5368833-expected.txt:
  • platform/qt/editing/pasteboard/5478250-expected.txt:
  • platform/qt/editing/pasteboard/5483567-expected.txt:
  • platform/qt/editing/pasteboard/5601583-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/5780697-2-expected.txt:
  • platform/qt/editing/pasteboard/7955-expected.txt:
  • platform/qt/editing/pasteboard/8145-1-expected.txt:
  • platform/qt/editing/pasteboard/8145-2-expected.txt:
  • platform/qt/editing/pasteboard/8145-3-expected.txt:
  • platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
  • platform/qt/editing/pasteboard/cut-text-001-expected.txt:
  • platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/displaced-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/display-block-on-spans-expected.txt:
  • platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
  • platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-1-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-3-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-4-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-3-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-4-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-5-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-list-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-table-expected.txt:
  • platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/merge-start-list-expected.txt:
  • platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-4038267-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-1-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-2-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-3-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-line-endings-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-004-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/qt/editing/pasteboard/paste-list-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-pre-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-pre-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-cells-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-004-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-009-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-010-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-011-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-012-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-013-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-text-014-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-015-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-016-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-017-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-018-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-019-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
  • platform/qt/editing/pasteboard/pasting-object-expected.txt:
  • platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
  • platform/qt/editing/pasteboard/quirks-mode-br-1-expected.txt:
  • platform/qt/editing/pasteboard/select-element-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/styled-element-markup-expected.txt:
  • platform/qt/editing/pasteboard/testcase-9507-expected.txt: Added.
  • platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
  • platform/qt/editing/pasteboard/unrendered-br-expected.txt: Added.

2010-05-03 Robert Hogan <​robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Unskip editing/pasteboard tests that fail due to 'x,y' differences

​https://bugs.webkit.org/show_bug.cgi?id=38435

Unskip a large number of editing/pasteboard tests that fail only due
to rendertree differences in the height/width of rendered text.

Reduce the skipped editing/pasteboard tests to those that fail for
a good reason and add some initial commentary on each.

Unskip:

editing/pasteboard/3976872.html
editing/pasteboard/4076267-3.html
editing/pasteboard/4242293.html
editing/pasteboard/4631972.html
editing/pasteboard/4641033.html
editing/pasteboard/4700297.html
editing/pasteboard/4840662.html
editing/pasteboard/4944770-1.html
editing/pasteboard/4944770-2.html
editing/pasteboard/4989774.html
editing/pasteboard/5006779.html
editing/pasteboard/5027857.html
editing/pasteboard/5028447.html
editing/pasteboard/5032095.html
editing/pasteboard/5065605.html
editing/pasteboard/5071074-2.html
editing/pasteboard/5071074.html
editing/pasteboard/5075944-2.html
editing/pasteboard/5075944-3.html
editing/pasteboard/5075944.html
editing/pasteboard/5089327.html
editing/pasteboard/5134759.html
editing/pasteboard/5156401-1.html
editing/pasteboard/5245519.html
editing/pasteboard/5247341.html
editing/pasteboard/5368833.html
editing/pasteboard/5478250.html
editing/pasteboard/5483567.html
editing/pasteboard/5601583-1.html
editing/pasteboard/5780697-2.html
editing/pasteboard/7955.html
editing/pasteboard/8145-1.html
editing/pasteboard/8145-2.html
editing/pasteboard/8145-3.html
editing/pasteboard/copy-paste-bidi.html
editing/pasteboard/cut-text-001.html
editing/pasteboard/displaced-generic-placeholder.html
editing/pasteboard/displaced-placeholder.html
editing/pasteboard/display-block-on-spans.html
editing/pasteboard/emacs-cntl-y-001.html
editing/pasteboard/innerText-inline-table.html
editing/pasteboard/interchange-newline-1.html
editing/pasteboard/interchange-newline-3.html
editing/pasteboard/interchange-newline-4.html
editing/pasteboard/merge-after-delete-1.html
editing/pasteboard/merge-after-delete-2.html
editing/pasteboard/merge-after-delete.html
editing/pasteboard/merge-end-1.html
editing/pasteboard/merge-end-2.html
editing/pasteboard/merge-end-3.html
editing/pasteboard/merge-end-4.html
editing/pasteboard/merge-end-5.html
editing/pasteboard/merge-end-blockquote.html
editing/pasteboard/merge-end-borders.html
editing/pasteboard/merge-end-list.html
editing/pasteboard/merge-end-table.html
editing/pasteboard/merge-start-blockquote.html
editing/pasteboard/merge-start-list.html
editing/pasteboard/paste-4035648-fix.html
editing/pasteboard/paste-4038267-fix.html
editing/pasteboard/paste-4039777-fix.html
editing/pasteboard/paste-blockquote-1.html
editing/pasteboard/paste-blockquote-2.html
editing/pasteboard/paste-blockquote-3.html
editing/pasteboard/paste-blockquote-after-blockquote.html
editing/pasteboard/paste-blockquote-into-blockquote-2.html
editing/pasteboard/paste-blockquote-into-blockquote-3.html
editing/pasteboard/paste-blockquote-into-blockquote-4.html
editing/pasteboard/paste-blockquote-into-blockquote.html
editing/pasteboard/paste-line-endings-001.html
editing/pasteboard/paste-line-endings-002.html
editing/pasteboard/paste-line-endings-003.html
editing/pasteboard/paste-line-endings-004.html
editing/pasteboard/paste-line-endings-005.html
editing/pasteboard/paste-line-endings-006.html
editing/pasteboard/paste-line-endings-007.html
editing/pasteboard/paste-line-endings-008.html
editing/pasteboard/paste-line-endings-009.html
editing/pasteboard/paste-line-endings-010.html
editing/pasteboard/paste-list-001.html
editing/pasteboard/paste-match-style-001.html
editing/pasteboard/paste-match-style-002.html
editing/pasteboard/paste-pre-001.html
editing/pasteboard/paste-pre-002.html
editing/pasteboard/paste-table-001.html
editing/pasteboard/paste-table-003.html
editing/pasteboard/paste-table-cells.html
editing/pasteboard/paste-text-002.html
editing/pasteboard/paste-text-003.html
editing/pasteboard/paste-text-004.html
editing/pasteboard/paste-text-005.html
editing/pasteboard/paste-text-006.html
editing/pasteboard/paste-text-007.html
editing/pasteboard/paste-text-009.html
editing/pasteboard/paste-text-010.html
editing/pasteboard/paste-text-011.html
editing/pasteboard/paste-text-012.html
editing/pasteboard/paste-text-013.html
editing/pasteboard/paste-text-014.html
editing/pasteboard/paste-text-015.html
editing/pasteboard/paste-text-016.html
editing/pasteboard/paste-text-017.html
editing/pasteboard/paste-text-018.html
editing/pasteboard/paste-text-019.html
editing/pasteboard/paste-text-at-tabspan-002.html
editing/pasteboard/paste-text-at-tabspan-003.html
editing/pasteboard/paste-unrendered-select.html
editing/pasteboard/pasting-object.html
editing/pasteboard/prevent-block-nesting-01.html
editing/pasteboard/quirks-mode-br-1.html
editing/pasteboard/select-element-1.html
editing/pasteboard/styled-element-markup.html
editing/pasteboard/testcase-9507.html
editing/pasteboard/undoable-fragment-removes.html
editing/pasteboard/unrendered-br.html

  • platform/qt/Skipped:
8:18 AM Changeset in webkit [58674] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-05-03 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Csaba Osztrogonac.

media/video-duration-known-after-eos.html failing
​https://bugs.webkit.org/show_bug.cgi?id=38466

  • platform/qt/Skipped: Skipping failing test. A lot of media tests are already skipped on this platform. Tor Arne said he'd look at them, at some point.
7:13 AM Changeset in webkit [58673] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix qtlibraryinfix not to contain space

Patch by Janne Koskinen <​janne.p.koskinen@digia.com> on 2010-05-03
Reviewed by Simon Hausmann.

List catenation with += adds whitespace cutting the infix
from the final target.

  • WebCore.pro:
7:10 AM Changeset in webkit [58672] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix rendering of <button> elements on Mac OS X

Reviewed by Simon Hausmann.

The <button> element has ButtonPart appearance, not PushButton part,
so we have to include ButtonPart when we decide if we should draw the
button as raised on Mac OS X.

7:09 AM Changeset in webkit [58671] by Philippe Normand
  • 3 edits
    2 adds in trunk

2010-04-30 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] endless loop after playback ended
​https://bugs.webkit.org/show_bug.cgi?id=38384

At playback end ensure duration() will return a valid duration if
we managed to calculate it based on current position.

Test: media/video-duration-known-after-eos.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::didEnd):

2010-04-30 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] endless loop after playback ended
​https://bugs.webkit.org/show_bug.cgi?id=38384

  • media/video-duration-known-after-eos-expected.txt: Added.
  • media/video-duration-known-after-eos.html: Added.
5:00 AM Changeset in webkit [58670] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Prune dead code in QWebPage

Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:
4:17 AM Changeset in webkit [58669] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Fix build break on Mac OS X

  • plugins/mac/PluginPackageMac.cpp: Use correct type
  • WebCore.pro: Remove duplicate symbol, we now have a Qt implementation
4:00 AM Changeset in webkit [58668] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-03 Daniel Bates <​dbates@rim.com>

Reviewed by Chris Jerdonek.

​https://bugs.webkit.org/show_bug.cgi?id=38447

Refactor the unit tests in VCSUtils_unittest/parseDiff.pl to use
Test::More::is_deeply like we do in VCSUtils_unittest/parseDiffHeader.pl.

  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2:09 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:57 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:22 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:16 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
1:15 AM QtWebKitRelease20 edited by Simon Hausmann
(diff)
12:59 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
12:12 AM Changeset in webkit [58667] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix library infix usage when compiling inside of Qt

Patch by Thomas Zander <​t.zander@nokia.com> on 2010-05-03
Reviewed by Simon Hausmann.

Don't apply the infix when building inside Qt, as that's done through the
inclusion of qbase.pri.

  • WebCore.pro:
Note: See TracTimeline for information about the timeline view.