Timeline



Jul 13, 2010:

11:33 PM Changeset in webkit [63284] by bweinstein@apple.com
  • 1 edit
    4 moves in trunk/LayoutTests

Fix Windows checkouts by shortening paths.

  • fast/js/sputnik/Conformance: Renamed a few directories so checkouts can succeed.
10:02 PM Changeset in webkit [63283] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-07-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Page flashes to mostly white towards the end of loading
​https://bugs.webkit.org/show_bug.cgi?id=42230

We constrain the size of huge composited layers. When doing so, we
need to use the constained size to set the position as well
as the dimensions, to ensure the layer appears in the correct place.

Test: compositing/tiling/constrained-layer-size.html

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateLayerPosition):
9:51 PM Changeset in webkit [63282] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Versioning.

9:50 PM Changeset in webkit [63281] by mrowe@apple.com
  • 1 copy in tags/Safari-533.17.6

New tag.

9:48 PM Changeset in webkit [63280] by tkent@chromium.org
  • 7 edits
    2 adds in trunk

[Chromium] Linux implementation of <input type=number> UI
​https://bugs.webkit.org/show_bug.cgi?id=41925

Reviewed by Darin Fisher.

WebCore:

  • Move the code for scrollbar steppers from ScrollbarThemeChromiumLinux to PlatformThemeChromiumGtk.
  • Move the code for scrollbar colors from RenderThemeChromiumLinux to PlatformThemeChromiumGtk.
  • WebCore.gypi:
  • platform/chromium/PlatformThemeChromiumGtk.cpp: Added.

(WebCore::PlatformThemeChromiumGtk::setScrollbarColors): Moved from RenderThemeChromiumLinux.
(WebCore::clamp): Moved from ScrollbarThemeChromiumLinux.
(WebCore::PlatformThemeChromiumGtk::saturateAndBrighten): ditto.
(WebCore::PlatformThemeChromiumGtk::outlineColor): ditto.
(WebCore::PlatformThemeChromiumGtk::paintArrowButton): ditto.

  • platform/chromium/PlatformThemeChromiumGtk.h: Added.
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp:

(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):

Move the main part of the code to PlatformThemeChromiumGtk.

(WebCore::ScrollbarThemeChromiumLinux::paintThumb):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle): Added.
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton): Added.

  • rendering/RenderThemeChromiumLinux.h:

WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setScrollbarColors):

Call PlatformThemeChromiumGtk::setScrollbarColors() instead of
RenderThemeChromiumLinux::setScrollbarColors().

9:47 PM Changeset in webkit [63279] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Versioning.

9:46 PM Changeset in webkit [63278] by dumi@chromium.org
  • 36 edits
    1 copy
    3 moves
    45 adds in trunk

WebCore: Implementing DatabaseSync::transaction() and DatabaseSync::changeVersion().
​https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Darin Fisher

Tests: fast/workers/storage/change-version-handle-reuse-sync.html

fast/workers/storage/change-version-sync.html
fast/workers/storage/empty-statement-sync.html
fast/workers/storage/execute-sql-args-sync.html
fast/workers/storage/executesql-accepts-only-one-statement-sync.html
fast/workers/storage/multiple-transactions-on-different-handles-sync.html
fast/workers/storage/open-database-creation-callback-sync.html
fast/workers/storage/open-database-empty-version-sync.html
fast/workers/storage/open-database-inputs-sync.html
fast/workers/storage/open-database-set-empty-version-sync.html
fast/workers/storage/open-database-while-transaction-in-progress-sync.html
fast/workers/storage/sql-data-types-sync.html
fast/workers/storage/sql-exception-codes-sync.html
fast/workers/storage/test-authorizer-sync.html
fast/workers/storage/transaction-in-transaction-sync.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::maximumSize):
(WebCore::AbstractDatabase::incrementalVacuumIfNeeded):

  • storage/AbstractDatabase.h:

(WebCore::AbstractDatabase::sqliteDatabase):

  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):

  • storage/Database.cpp:

(WebCore::Database::performGetTableNames):

  • storage/Database.h:
  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::createVTable):
(WebCore::DatabaseAuthorizer::dropVTable):

  • storage/DatabaseCallback.h:
  • storage/DatabaseSync.cpp:

(WebCore::ChangeVersionPreflightStep::create):
(WebCore::ChangeVersionPreflightStep::performStep):
(WebCore::ChangeVersionPreflightStep::ChangeVersionPreflightStep):
(WebCore::ChangeVersionPostflightStep::create):
(WebCore::ChangeVersionPostflightStep::performStep):
(WebCore::ChangeVersionPostflightStep::ChangeVersionPostflightStep):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):
(WebCore::DatabaseSync::runTransaction):

  • storage/DatabaseSync.h:
  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):

  • storage/SQLError.h:
  • storage/SQLResultSet.cpp:
  • storage/SQLResultSet.h:
  • storage/SQLStatementCallback.h:
  • storage/SQLStatementErrorCallback.h:
  • storage/SQLStatementSync.cpp: Copied from WebCore/storage/SQLStatement.cpp.

(WebCore::SQLStatementSync::SQLStatementSync):
(WebCore::SQLStatementSync::execute):

  • storage/SQLStatementSync.h: Added.
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
(WebCore::SQLTransaction::postflightAndCommit):

  • storage/SQLTransaction.h:
  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):

  • storage/SQLTransactionClient.h:
  • storage/SQLTransactionErrorCallback.h:
  • storage/SQLTransactionSync.cpp:

(WebCore::transactionClient):
(WebCore::SQLTransactionSync::create):
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::~SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):
(WebCore::SQLTransactionSync::execute):
(WebCore::SQLTransactionSync::commit):
(WebCore::SQLTransactionSync::rollback):

  • storage/SQLTransactionSync.h:

(WebCore::SQLTransactionSync::SQLTransactionSyncOptionalStep::~SQLTransactionSyncOptionalStep):

  • storage/SQLTransactionSyncCallback.h:
  • storage/chromium/SQLTransactionClientChromium.cpp:

(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):

LayoutTests: Porting as many async DB tests as possible to sync DBs.
​https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Darin Fisher.

  • fast/workers/storage/change-version-handle-reuse-sync-expected.txt: Added.
  • fast/workers/storage/change-version-handle-reuse-sync.html: Added.
  • fast/workers/storage/change-version-sync-expected.txt: Added.
  • fast/workers/storage/change-version-sync.html: Added.
  • fast/workers/storage/empty-statement-sync-expected.txt: Added.
  • fast/workers/storage/empty-statement-sync.html: Added.
  • fast/workers/storage/execute-sql-args-sync-expected.txt: Added.
  • fast/workers/storage/execute-sql-args-sync.html: Added.
  • fast/workers/storage/executesql-accepts-only-one-statement-sync-expected.txt: Added.
  • fast/workers/storage/executesql-accepts-only-one-statement-sync.html: Added.
  • fast/workers/storage/multiple-transactions-on-different-handles-sync-expected.txt: Added.
  • fast/workers/storage/multiple-transactions-on-different-handles-sync.html: Added.
  • fast/workers/storage/open-database-creation-callback-sync-expected.txt: Added.
  • fast/workers/storage/open-database-creation-callback-sync.html: Added.
  • fast/workers/storage/open-database-empty-version-sync-expected.txt: Added.
  • fast/workers/storage/open-database-empty-version-sync.html: Added.
  • fast/workers/storage/open-database-inputs-sync-expected.txt: Copied from LayoutTests/fast/workers/storage/open-database-sync-inputs-expected.txt.
  • fast/workers/storage/open-database-inputs-sync.html: Copied from LayoutTests/fast/workers/storage/open-database-sync-inputs.html.
  • fast/workers/storage/open-database-set-empty-version-sync-expected.txt: Added.
  • fast/workers/storage/open-database-set-empty-version-sync.html: Added.
  • fast/workers/storage/open-database-sync-inputs-expected.txt: Removed.
  • fast/workers/storage/open-database-sync-inputs.html: Removed.
  • fast/workers/storage/open-database-while-transaction-in-progress-sync-expected.txt: Added.
  • fast/workers/storage/open-database-while-transaction-in-progress-sync.html: Added.
  • fast/workers/storage/resources/change-version-handle-reuse-sync.js: Added.

(catch):

  • fast/workers/storage/resources/change-version-sync-1.js: Added.

():
(try):

  • fast/workers/storage/resources/change-version-sync-2.js: Added.
  • fast/workers/storage/resources/empty-statement-sync.js: Added.
  • fast/workers/storage/resources/execute-sql-args-sync.js: Added.

(throwOnToStringObject.toString):
(var):
():
(runTransactionTest):
(runTransactionTests):

  • fast/workers/storage/resources/executesql-accepts-only-one-statement-sync.js: Added.

(executeStatement):

  • fast/workers/storage/resources/multiple-transactions-on-different-handles-sync.js: Added.

(runTransaction):
(var):

  • fast/workers/storage/resources/multiple-transactions-sync.js: Added.

(checkCompletion):
(runTest.db):
(runTest):

  • fast/workers/storage/resources/open-database-creation-callback-sync.js: Added.
  • fast/workers/storage/resources/open-database-empty-version-sync.js: Added.
  • fast/workers/storage/resources/open-database-inputs-sync.js: Copied from LayoutTests/fast/workers/storage/resources/open-database-sync-inputs.js.
  • fast/workers/storage/resources/open-database-set-empty-version-sync.js: Added.
  • fast/workers/storage/resources/open-database-sync-inputs.js: Removed.
  • fast/workers/storage/resources/open-database-while-transaction-in-progress-sync.js: Added.

(openTestDatabase):

  • fast/workers/storage/resources/sql-data-types-sync.js: Added.

():
(testDBValues):

  • fast/workers/storage/resources/sql-exception-codes-sync.js: Added.

(testTransaction):
():
(testInvalidStatement):
(testIncorrectNumberOfBindParameters):
(testBindParameterOfWrongType.badString.toString):
(testBindParameterOfWrongType):
(testVersionMismatch.testTransaction):
(testVersionMismatch):

  • fast/workers/storage/resources/test-authorizer-sync.js: Added.

(cleanup):
(executeStatement):
(createTableCallback):
(createStatementsCallback):
(otherStatementsCallback):
(dropStatementsCallback):
(testReadWriteMode):
(testReadOnlyMode):

  • fast/workers/storage/resources/transaction-in-transaction-sync.js: Added.
  • fast/workers/storage/sql-data-types-sync-expected.txt: Added.
  • fast/workers/storage/sql-data-types-sync.html: Added.
  • fast/workers/storage/sql-exception-codes-sync-expected.txt: Added.
  • fast/workers/storage/sql-exception-codes-sync.html: Added.
  • fast/workers/storage/test-authorizer-sync-expected.txt: Added.
  • fast/workers/storage/test-authorizer-sync.html: Added.
  • fast/workers/storage/transaction-in-transaction-sync-expected.txt: Added.
  • fast/workers/storage/transaction-in-transaction-sync.html: Added.
9:21 PM Changeset in webkit [63277] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk

2010-07-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63262.
​http://trac.webkit.org/changeset/63262
​https://bugs.webkit.org/show_bug.cgi?id=42229

broke Windows compile (Requested by bweinstein on #webkit).

  • WebKit.pro:

2010-07-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63262.
​http://trac.webkit.org/changeset/63262
​https://bugs.webkit.org/show_bug.cgi?id=42229

broke Windows compile (Requested by bweinstein on #webkit).

  • API/tests/testapi.c: (assertEqualsAsCharactersPtr): (main):
  • testapi.pro: Removed.
7:39 PM Changeset in webkit [63276] by mjs@apple.com
  • 5 edits in trunk

2010-07-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=42227

  • platform/mac-wk2/Skipped: Skip some tests newly revealed as failing for an already-classified reason.

2010-07-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=42227

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize new bool members. (WTR::LayoutTestController::display): Dummy method. (WTR::displayCallback): Call the dummy. (WTR::repaintSweepHorizontallyCallback): ditto (WTR::testRepaintCallback): ditto (WTR::LayoutTestController::staticFunctions): Expose new methods.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::setTestRepaint): Set the flag (which currently does nothing). (WTR::LayoutTestController::setTestRepaintSweepHorizontally): ditto
6:38 PM Changeset in webkit [63275] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63162.
​http://trac.webkit.org/changeset/63162
​https://bugs.webkit.org/show_bug.cgi?id=42224

This is no longer needed (Requested by olliej_ on #webkit).

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
6:11 PM Changeset in webkit [63274] by eric@webkit.org
  • 6 edits in trunk

2010-07-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix my misreading of "clear to the last marker" in the HTML5 spec
​https://bugs.webkit.org/show_bug.cgi?id=42199

  • html5lib/runner-expected-html5.txt:

2010-07-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix my misreading of "clear to the last marker" in the HTML5 spec
​https://bugs.webkit.org/show_bug.cgi?id=42199

  • html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::clearToLastMarker):
  • html/HTMLFormattingElementList.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndOfFile):
6:02 PM Changeset in webkit [63273] by oliver@apple.com
  • 25 edits in trunk

2010-07-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

ES5 requires BOMs to be treated as whitespace
​https://bugs.webkit.org/show_bug.cgi?id=42218

Add BOM character to the Lexer's definition of whitespace,
and remove the logic that dealt with stripping BOMs and
caching the cleaned string.

  • parser/Lexer.h: (JSC::Lexer::isWhiteSpace):
  • parser/SourceProvider.h: (JSC::UStringSourceProvider::create): (JSC::UStringSourceProvider::UStringSourceProvider):
  • wtf/text/StringImpl.h:

2010-07-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

ES5 requires BOMs to be treated as whitespace
​https://bugs.webkit.org/show_bug.cgi?id=42218

Update the fast/js/removing-Cf-characters to reflect
new behaviour. Update a whole group of sputnik results
that we now pass.

  • fast/js/removing-Cf-characters-expected.txt:
  • fast/js/script-tests/removing-Cf-characters.js:
  • fast/js/sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.1_T2-expected.txt:
  • fast/js/sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.4_T2-expected.txt:
  • fast/js/sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.1_T2-expected.txt:
  • fast/js/sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.4_T2-expected.txt:
  • fast/js/sputnik/Unicode/Unicode_218/S7.1_A2.1_T2-expected.txt:
  • fast/js/sputnik/Unicode/Unicode_218/S7.1_A2.2_T2-expected.txt:
  • fast/js/sputnik/Unicode/Unicode_320/S7.1_A2.1_T2-expected.txt:
  • fast/js/sputnik/Unicode/Unicode_320/S7.1_A2.2_T2-expected.txt:
  • fast/js/sputnik/Unicode/Unicode_410/S7.1_A2.1_T2-expected.txt:
  • fast/js/sputnik/Unicode/Unicode_410/S7.1_A2.2_T2-expected.txt:
  • fast/js/sputnik/Unicode/Unicode_500/S7.1_A2.1_T2-expected.txt:
  • fast/js/sputnik/Unicode/Unicode_500/S7.1_A2.2_T2-expected.txt:
  • fast/js/sputnik/Unicode/Unicode_510/S7.1_A2.1_T2-expected.txt:
  • fast/js/sputnik/Unicode/Unicode_510/S7.1_A2.2_T2-expected.txt:

2010-07-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

ES5 requires BOMs to be treated as whitespace
​https://bugs.webkit.org/show_bug.cgi?id=42218

Remove BOM handling logic from WebCore Script objects.

  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::StringSourceProvider):
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::script):
  • loader/CachedScript.h:
5:59 PM Changeset in webkit [63272] by ajwong@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed, add details to chromium test expectations.

Adding details and references to filed bugs to chromium expectations
that were added in the past few days. Also rebaseline the svg test.

  • platform/chromium-mac/svg/custom/clip-path-child-changes-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:59 PM Changeset in webkit [63271] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2010-07-13 Simon Fraser <Simon Fraser>

Fix Tiger build.

Avoid non-ASCII in souce files to keep Tiger compiler happy.

  • WebView/WebRenderLayer.mm: (+[WebRenderLayer nameForLayer:]):
5:45 PM Changeset in webkit [63270] by andreas.kling@nokia.com
  • 5 edits in trunk

2010-07-13 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Canvas: rect(x,y,w,h) should move to (x,y) even if w=0 and h=0
​https://bugs.webkit.org/show_bug.cgi?id=42211

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::rect):

2010-07-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make our end tag in-foreign-content mode spec bug workarounds more closely match minefield
​https://bugs.webkit.org/show_bug.cgi?id=42187

  • html5lib/runner-expected-html5.txt:
5:38 PM Changeset in webkit [63269] by Simon Fraser
  • 4 edits in trunk/WebCore

2010-07-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Show IDs and classnames in layer tree dumps
​https://bugs.webkit.org/show_bug.cgi?id=42213

When dumping the layer tree via showLayerTree(), include id and class attributes for
ease of debugging.

No tests, since this is debug-only code.

  • rendering/RenderLayer.cpp: (showLayerTree):
  • rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject):
  • rendering/RenderTreeAsText.h: (WebCore::):
5:29 PM Changeset in webkit [63268] by andreas.kling@nokia.com
  • 7 edits in trunk/JavaScriptCore

2010-07-13 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Avoid slow-path for put() in Array.splice()
​https://bugs.webkit.org/show_bug.cgi?id=41920

Defer creation of the returned array until its final size is known
to avoid growing it while adding elements.

  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): Add two modes of creation, CreateInitialized (old) and CreateCompact (which should only be used when constructing arrays whose size and contents are known at the time of creation.) (JSC::JSArray::setLength): Skip first consistency check if in CreateCompact initialization mode. (Only applies to non-empty arrays.) (JSC::JSArray::checkConsistency): Build fix (JSValue::type() is gone)
  • runtime/JSArray.h: (JSC::JSArray::uncheckedSetIndex): Added for fast initialization of compact arrays. Does no bounds or other sanity checking.
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice): Optimized creation of the returned JSArray.
  • runtime/ArrayConstructor.cpp: (JSC::constructArrayWithSizeQuirk): Pass CreateInitialized to ctor.
  • runtime/JSGlobalObject.h: (JSC::constructEmptyArray): Pass CreateInitialized to ctor.
  • runtime/RegExpConstructor.cpp: (JSC::RegExpMatchesArray::RegExpMatchesArray): Pass CreateInitialized to ctor.
5:27 PM Changeset in webkit [63267] by barraclough@apple.com
  • 12 edits in trunk/JavaScriptCore

Bug 42207 - Clean up interface to compile executables, always check for exceptions

Reviewed by Oliver Hunt.

Presently interface to compile executable is inconsistent between eval/program and
function code, and is error prone in allowing a caller to byte compile without JIT
compiling an executable (we rely on all executables with codeblocks having JIT code).
Unify on an interface where all compilation is performed by a single compile (with
ForCall|ForConstruct variants) method, and make all clients check for errors.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • parser/Parser.h:

(JSC::Parser::isFunctionBodyNode):
(JSC::Parser::parse):

  • runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction):

  • runtime/ExceptionHelpers.cpp:

(JSC::createStackOverflowError):

  • runtime/ExceptionHelpers.h:
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::fromGlobalCode):

  • runtime/Executable.h:

(JSC::EvalExecutable::compile):
(JSC::EvalExecutable::generatedBytecode):
(JSC::EvalExecutable::generatedJITCode):
(JSC::ProgramExecutable::compile):
(JSC::ProgramExecutable::generatedBytecode):
(JSC::ProgramExecutable::generatedJITCode):
(JSC::FunctionExecutable::generatedBytecode):
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::generatedJITCodeForConstructWithArityCheck):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::argumentsGetter):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::canUseJIT):

5:20 PM Changeset in webkit [63266] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-07-13 Simon Fraser <Simon Fraser>

Build fix: fix WebCore exports by editing the .in file, rather than the generated file.

  • WebCore.exp.in:
5:20 PM Changeset in webkit [63265] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=42216
ResourceRequest::doUpdateResourceRequest() crashes if client denied request

This is covered by many regression tests with patch for bug 42201 applied (because it makes
us also use this code path for sync requests, and those currently have more strict limitations).

  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdateResourceRequest): Added a null check.
5:18 PM Changeset in webkit [63264] by eric@webkit.org
  • 6 edits in trunk

2010-07-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make our end tag in-foreign-content mode spec bug workarounds more closely match minefield
​https://bugs.webkit.org/show_bug.cgi?id=42187

  • html5lib/runner-expected-html5.txt:

2010-07-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make our end tag in-foreign-content mode spec bug workarounds more closely match minefield
​https://bugs.webkit.org/show_bug.cgi?id=42187

I do not expect these work-arounds to be permanent. Hixie has promised to
addresses the feedback to the parser sections of HTML5 soon.
I added these hacks to make our hacks more-closely match Minefield's hacks
and thus have us "pass" a few more html5lib runner tests.

We now pass all of the html5lib foreign content tests
(thus we'll likely need to write more).

Tested by html5lib/runner.html

  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::contains):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag):
5:04 PM Changeset in webkit [63263] by Simon Fraser
  • 4 edits
    2 adds in trunk/WebKit

2010-07-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/8186963> Expose RenderLayer hierarchy via Obj-C for debugging.

Add a WebRenderLayer class that reflects the RenderLayer tree into a hierarchy
of Objective-C objects suitable for display in an outline view.

  • WebKit.exp: Export the WebRenderLayer Objective-C class.
  • WebView/WebRenderLayer.h: Added.
  • WebView/WebRenderLayer.mm: Added.
4:59 PM Changeset in webkit [63262] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

2010-07-13 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Oliver Hunt.

Separate CoreFoundation specific tests in JSC's testapi.c

testapi.c depends on the Core Foundation.
​https://bugs.webkit.org/show_bug.cgi?id=40058

  • WebKit.pro: enable compilation of JSC C API test.

2010-07-13 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Oliver Hunt.

testapi.c depends on the Core Foundation.
​https://bugs.webkit.org/show_bug.cgi?id=40058

Separate CoreFoundation specific tests in JSC's testapi.c. Enabling it
to compile in Qt environments.

All tests should work except for the JSStringCreateWithCharacters() function,
because its tests depend on Core Foundation specific functions.

  • API/tests/testapi.c: (testJSStringRefCF): moved CoreFoundation specific tests to this function. (main): The moves plus some minor tweaks.
  • testapi.pro: Added.
4:51 PM Changeset in webkit [63261] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating test expectatins.

[chromium] Adding more test expectations to bring chromium build
green.

  • platform/chromium/test_expectations.txt:
4:36 PM Changeset in webkit [63260] by bweinstein@apple.com
  • 2 edits
    17 adds in trunk/LayoutTests

Sputnik tests aren't running on Windows
​https://bugs.webkit.org/show_bug.cgi?id=42208

Reviewed by Steve Falkenburg.

We should run the Sputnik tests on Windows, by unskipping fast/js/Sputnik, and adding Windows
specific test results. There are 6 tests that needs Windows specific results. 3 of them are
progressions (Unicode_510/S7.6_A3.2.html, Unicode_510/S7.6_A5.3_T1.html, Unicode_510/S7.6_A5.3_T2.html)
and the others are failures that are being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=42209.

  • platform/win/Skipped: Remove fast/js/sputnik from the Skipped list.
  • platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Applying_the_percent_Operator/S11.5.3_A4_T6-expected.txt: Added failing result.
  • platform/win/fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.12_Array_prototype_splice/S15.4.4.12_A2.1_T3-expected.txt: Added failing result.
  • platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Added failing result.
  • platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Added progression.
  • platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Added progression.
  • platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Added progression.
4:27 PM Changeset in webkit [63259] by tonyg@chromium.org
  • 7 edits in trunk

2010-07-12 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Fisher.

Wire network times from ResourceLoadTiming to performance.timing
​https://bugs.webkit.org/show_bug.cgi?id=41824

Expectations set to fail because --web-timing disabled by default.

  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-expected.txt:

2010-07-12 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Fisher.

Wire network times from ResourceLoadTiming to performance.timing
​https://bugs.webkit.org/show_bug.cgi?id=41824

4:20 PM Changeset in webkit [63258] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-07-13 Chris Guillory <​chris.guillory@google.com>

Reviewed by David Levin.

Fix adoptRef usage violation in WebAccessibilityCacheImpl.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=42092

  • src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::WeakHandle::create): (WebKit::WebAccessibilityCacheImpl::WeakHandle::WeakHandle):
4:07 PM Changeset in webkit [63257] by andersca@apple.com
  • 15 edits in trunk

Add support for URL frame loading using NPN_GetURLNotify
​https://bugs.webkit.org/show_bug.cgi?id=42192

Reviewed by Sam Weinig.

WebCore:

  • WebCore.exp.in:

Export ResourceRequestBase::setHTTPMethod and ResourceRequestBase::setURL.

WebKit2:

  • WebProcess/Plugins/DummyPlugin.cpp:

(WebKit::DummyPlugin::frameDidFinishLoading):
(WebKit::DummyPlugin::frameDidFail):

  • WebProcess/Plugins/DummyPlugin.h:

Add empty stubs.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

Implement NPN_GetURLNotify and have it call NetscapePlugin::loadURL.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_nextRequestID to 0.

(WebKit::NetscapePlugin::loadURL):
Ask the plug-in controller to load the URL.

(WebKit::NetscapePlugin::frameDidFinishLoading):
(WebKit::NetscapePlugin::frameDidFail):
Add empty stubs for now.

  • WebProcess/Plugins/Plugin.h:

Add new member functions for frame load notifications.

  • WebProcess/Plugins/PluginController.h:

Add loadURL.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::URLRequest::URLRequest):
Add class that represents an URL request.

(WebKit::PluginView::PluginView):
Initialize m_pendingURLRequestsTimer.

(WebKit::PluginView::~PluginView):
Unset all active load listeners.

(WebKit::PluginView::pendingURLRequestsTimerFired):
Take the first request in the queue and process it.

(WebKit::PluginView::performURLRequest):
Call performFrameLoadURLRequest if necessary.

(WebKit::PluginView::performFrameLoadURLRequest):
Find a frame to load the request in. If a frame doesn't exist try to create a new frame.

(WebKit::PluginView::loadURL):
Create a URLRequest and add it to the queue.

(WebKit::PluginView::didFinishLoad):
Get the pending frame load request and call Plugin::frameDidFinishLoading.

(WebKit::PluginView::didFailLoad):
Get the pending frame load request and call Plugin::frameDidFail.

  • WebProcess/Plugins/PluginView.h:

Inherit from WebFrame::LoadListener.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::didFinishLoad):
Call the WebFrame's load listener if needed.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::WebFrame):
Initialize m_loadListener to 0.

  • WebProcess/WebPage/WebFrame.h:

Add a LoadListener class that the plug-in view can use to track frame loads.

(WebKit::WebFrame::LoadListener::~LoadListener):
(WebKit::WebFrame::setLoadListener):
(WebKit::WebFrame::loadListener):

4:05 PM Changeset in webkit [63256] by diegohcg@webkit.org
  • 3 edits in trunk/WebKit2

2010-07-13 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WebKit2] Hook up navigation actions
​https://bugs.webkit.org/show_bug.cgi?id=42183

Make Back, Forward, Stop and Reload being enable/disabled according
page loading.

  • UIProcess/API/qt/ClientImpl.cpp: (qt_wk_didStartProvisionalLoadForFrame): (qt_wk_didCommitLoadForFrame): (qt_wk_didFinishLoadForFrame): (qt_wk_didFailLoadWithErrorForFrame):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::updateAction):
4:03 PM Changeset in webkit [63255] by crogers@google.com
  • 12 edits in branches/audio/WebCore

Get rid of all references to HTMLXAudioElement

4:03 PM Changeset in webkit [63254] by crogers@google.com
  • 3 deletes in branches/audio/WebCore/audio

Remove HTMLXAudioElement files

3:53 PM Changeset in webkit [63253] by zmo@google.com
  • 6 edits
    2 adds in trunk

2010-07-04 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Need to track texture completeness
​https://bugs.webkit.org/show_bug.cgi?id=41381

Test: fast/canvas/webgl/texture-complete.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Init max texture level. (WebCore::WebGLRenderingContext::bindTexture): Pass max texture level to setTarget(). (WebCore::WebGLRenderingContext::copyTexImage2D): Cache full texture info rather than partial. (WebCore::WebGLRenderingContext::generateMipmap): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::validateTexFuncParameters): Also validate level.
  • html/canvas/WebGLRenderingContext.h: Add max texture level.
  • html/canvas/WebGLTexture.cpp: Update the class to fully cache texture information and track NPOT and COMPLETE states. (WebCore::WebGLTexture::WebGLTexture): (WebCore::WebGLTexture::setTarget): Check whether the texture is initialized or has been deleted. (WebCore::WebGLTexture::setParameteri): Ditto. (WebCore::WebGLTexture::setParameterf): Ditto. (WebCore::WebGLTexture::setLevelInfo): Set texture info. (WebCore::WebGLTexture::generateMipmapLevelInfo): Generate texture info for all levels after generateMipmaps() is called. (WebCore::WebGLTexture::getInternalFormat): Return internal format on texture face 0 level 0. (WebCore::WebGLTexture::isNPOT): Check whether the texture is initialized or has been deleted. (WebCore::WebGLTexture::needToUseBlackTexture): Ditto. (WebCore::WebGLTexture::_deleteObject): (WebCore::WebGLTexture::mapTargetToIndex): Map target to index. (WebCore::WebGLTexture::canGenerateMipmaps): Check whether Mipmaps can be generated. (WebCore::WebGLTexture::computeLevelCount): Compute texture level count from width/height. (WebCore::WebGLTexture::update): Update NPOT/COMPLETE states.
  • html/canvas/WebGLTexture.h: Ditto. (WebCore::WebGLTexture::LevelInfo::LevelInfo): Add data structure to fully cache texture info. (WebCore::WebGLTexture::LevelInfo::setInfo): Set information.

2010-07-04 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Need to track texture completeness
​https://bugs.webkit.org/show_bug.cgi?id=41381

  • fast/canvas/webgl/texture-complete-expected.txt: Added.
  • fast/canvas/webgl/texture-complete.html: Added.
3:49 PM Changeset in webkit [63252] by andreas.kling@nokia.com
  • 7 edits in trunk

2010-07-13 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Canvas: drawImage() with wrong 'image' argument type should always throw TypeError
​https://bugs.webkit.org/show_bug.cgi?id=42160

Updated 2d.drawImage.wrongtype.html from ​http://dvcs.w3.org/hg/html/
and unskipped it.

  • canvas/philip/tests/2d.drawImage.wrongtype-expected.txt:
  • canvas/philip/tests/2d.drawImage.wrongtype.html:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-07-13 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Canvas: drawImage() with wrong 'image' argument type should always throw TypeError
​https://bugs.webkit.org/show_bug.cgi?id=42160

Test: canvas/philip/tests/2d.drawImage.wrongtype.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): Throw TypeError instead of TYPE_MISMATCH_ERR if 'image' argument is not an image, canvas or video element.
3:21 PM Changeset in webkit [63251] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Make all NPN_ functions static.

Reviewed by Adam Roben.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
3:02 PM Changeset in webkit [63250] by kbr@google.com
  • 9 edits
    8 deletes in trunk/LayoutTests

2010-07-13 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Fold most WebGL script-tests into .html files
​https://bugs.webkit.org/show_bug.cgi?id=42204

For each WebGL script-test layout test which has a corresponding
copy in the Khronos repository, folded the .js into the .html. This
will make it easier to synchronize these tests between repositories.

  • fast/canvas/webgl/error-reporting.html:
  • fast/canvas/webgl/get-active-test.html:
  • fast/canvas/webgl/gl-object-get-calls.html:
  • fast/canvas/webgl/incorrect-context-object-behaviour.html:
  • fast/canvas/webgl/index-validation.html:
  • fast/canvas/webgl/null-object-behaviour.html:
  • fast/canvas/webgl/null-uniform-location.html:
  • fast/canvas/webgl/script-tests/error-reporting.js: Removed.
  • fast/canvas/webgl/script-tests/get-active-test.js: Removed.
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js: Removed.
  • fast/canvas/webgl/script-tests/incorrect-context-object-behaviour.js: Removed.
  • fast/canvas/webgl/script-tests/index-validation.js: Removed.
  • fast/canvas/webgl/script-tests/null-object-behaviour.js: Removed.
  • fast/canvas/webgl/script-tests/null-uniform-location.js: Removed.
  • fast/canvas/webgl/script-tests/uniform-location.js: Removed.
  • fast/canvas/webgl/uniform-location.html:
2:39 PM Changeset in webkit [63249] by kbr@google.com
  • 1 edit
    8 moves
    2 deletes in trunk/LayoutTests

2010-07-13 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

Rename bug-zzzzz.html WebGL tests
​https://bugs.webkit.org/show_bug.cgi?id=42200

Per changes already made to Khronos copy of tests, renamed:

bug-31889.html to array-buffer-crash.html
bug-32364.html to tex-image-and-uniform-binding-bugs.html
bug-32692.html to index-validation-verifies-too-many-indices.html
bug-32888.html to texture-transparent-pixels-initialized.html

Deleted bug-32456.html because it is now redundant; its
functionality is already in array-unit-tests.html.

  • fast/canvas/webgl/array-buffer-crash-expected.txt: Copied from LayoutTests/fast/canvas/webgl/bug-31889-expected.txt.
  • fast/canvas/webgl/array-buffer-crash.html: Copied from LayoutTests/fast/canvas/webgl/bug-31889.html.
  • fast/canvas/webgl/bug-31889-expected.txt: Removed.
  • fast/canvas/webgl/bug-31889.html: Removed.
  • fast/canvas/webgl/bug-32364-expected.txt: Removed.
  • fast/canvas/webgl/bug-32364.html: Removed.
  • fast/canvas/webgl/bug-32456-expected.txt: Removed.
  • fast/canvas/webgl/bug-32456.html: Removed.
  • fast/canvas/webgl/bug-32692-expected.txt: Removed.
  • fast/canvas/webgl/bug-32692.html: Removed.
  • fast/canvas/webgl/bug-32888-expected.txt: Removed.
  • fast/canvas/webgl/bug-32888.html: Removed.
  • fast/canvas/webgl/index-validation-verifies-too-many-indices-expected.txt: Copied from LayoutTests/fast/canvas/webgl/bug-32692-expected.txt.
  • fast/canvas/webgl/index-validation-verifies-too-many-indices.html: Copied from LayoutTests/fast/canvas/webgl/bug-32692.html.
  • fast/canvas/webgl/tex-image-and-uniform-binding-bugs-expected.txt: Copied from LayoutTests/fast/canvas/webgl/bug-32364-expected.txt.
  • fast/canvas/webgl/tex-image-and-uniform-binding-bugs.html: Copied from LayoutTests/fast/canvas/webgl/bug-32364.html.
  • fast/canvas/webgl/texture-transparent-pixels-initialized-expected.txt: Copied from LayoutTests/fast/canvas/webgl/bug-32888-expected.txt.
  • fast/canvas/webgl/texture-transparent-pixels-initialized.html: Copied from LayoutTests/fast/canvas/webgl/bug-32888.html.
2:29 PM Changeset in webkit [63248] by ajwong@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed, build fix.

Updating chromium test expectations to keep pace with regressions and
baselines.

  • platform/chromium-linux/svg/custom/text-rotated-gradient-expected.checksum:
  • platform/chromium-linux/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium/test_expectations.txt:
2:07 PM Changeset in webkit [63247] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2010-07-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

Skip various layout tests for WebKit2 due to missing WK or DRT features
​https://bugs.webkit.org/show_bug.cgi?id=42198

  • platform/mac-wk2/Skipped:
2:00 PM Changeset in webkit [63246] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Versioning.

1:58 PM Changeset in webkit [63245] by mrowe@apple.com
  • 1 copy in tags/Safari-533.17.5

New tag.

1:34 PM Changeset in webkit [63244] by barraclough@apple.com
  • 9 edits
    3 adds in trunk

Bug 42182 - Change how numeric compare functions are detected

Reviewed by Oliver Hunt.

JavaScriptCore:

There are three problems with the current mechanism:

  • It requires that a function executable be bytecode compiled without being JIT generated (in order to copy the bytecode from the numeric compare function). This is a problem since we have an invariant when running with the JIT that functions are never bytecode compiled without also being JIT generated (after checking the codeblock we assume the function has JIT code). To help maintain this invariant
  • This implementation will prevent us from experimenting with alternate compilation paths which do not compile via bytecode.
  • It doesn't work. Functions passing more than two arguments will match if they are comparing their last two arguments, not the first two. Generally the mapping back from bytecode to semantics may be more complex then initially expected.
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::setIsNumericCompareFunction):
(JSC::BytecodeGenerator::argumentNumberFor):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::BlockNode::singleStatement):
(JSC::FunctionBodyNode::emitBytecode):

  • parser/Nodes.h:

(JSC::ExpressionNode::isSubtract):
(JSC::BinaryOpNode::lhs):
(JSC::BinaryOpNode::rhs):
(JSC::SubNode::isSubtract):
(JSC::ReturnNode::value):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

LayoutTests:

Test case.

  • fast/js/array-sort-numericCompare-expected.txt: Added.
  • fast/js/array-sort-numericCompare.html: Added.
  • fast/js/script-tests/array-sort-numericCompare.js: Added.

(doSort):
(dontSort):

1:31 PM Changeset in webkit [63243] by aa@chromium.org
  • 3 edits in trunk/WebCore

2010-07-13 Aaron Boodman <​aa@chromium.org>

Reviewed by Timothy Hatcher.

Don't reset per-document user style caches when user styles are updated in
Chromium.

​https://bugs.webkit.org/show_bug.cgi?id=42003

  • page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld): (WebCore::PageGroup::removeUserStyleSheetFromWorld): (WebCore::PageGroup::removeUserStyleSheetsFromWorld): (WebCore::PageGroup::removeAllUserContent): (WebCore::PageGroup::resetUserStyleCacheInAllFrames):
  • page/PageGroup.h:
1:25 PM Changeset in webkit [63242] by ajwong@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreviewed, build fix.

[chromium] The comparision between signed/unsigned breaks the chromium
mac build.

  • src/AutoFillPopupMenuClient.cpp:

(WebKit::AutoFillPopupMenuClient::getSuggestion):
(WebKit::AutoFillPopupMenuClient::getLabel):

1:24 PM Changeset in webkit [63241] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/WebKit

2010-07-13 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

This commit implements an API for configuring a path to the cookie
file in the Mozilla "cookies.txt" format, and functions to deal with it
in a more EFL like API.

[EFL] Add API for dealing with cookies in EFL port.
​https://bugs.webkit.org/show_bug.cgi?id=41770

  • CMakeListsEfl.txt:
  • efl/ewk/EWebKit.h:
  • efl/ewk/ewk_cookies.cpp: Added. (ewk_cookies_file_set): Set a path to the file storing cookies. (ewk_cookies_clear): Clear all the cookies from the current cookie jar. (ewk_cookies_get_all): Get all the cookies from the current cookie jar. (ewk_cookies_cookie_del): Delete a specific cookie from the cookie jar. (ewk_cookies_cookie_free): Free memory used by a cookie. (ewk_cookies_policy_set): Set which acceptance policy will be used. (ewk_cookies_policy_get): Get current acceptance policy being used.
  • efl/ewk/ewk_cookies.h: Added. (_Ewk_Cookie::):
1:20 PM Changeset in webkit [63240] by sullivan@apple.com
  • 2 edits in trunk/WebKit2

Written by Simon Fraser, reviewed by me.

Cleaner fix for previous check-in.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
Use std::max<int> for int-casting brevity.

1:12 PM Changeset in webkit [63239] by eric.carlson@apple.com
  • 5 edits
    2 moves in trunk

2010-07-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

On Leopard, media element can't handle audio/mp4 MIME type in source tag
​https://bugs.webkit.org/show_bug.cgi?id=29326

Test: media/media-can-play-mpeg-audio.html

  • platform/MIMETypeRegistry.cpp: (WebCore::TypeExtensionPair::): Add "audio/mp4", "m4a" to mappings table.

2010-07-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

On Leopard, media element can't handle audio/mp4 MIME type in source tag
​https://bugs.webkit.org/show_bug.cgi?id=29326


Rename media-can-play-mp3 to media-can-play-mpeg-audio and add "audio/mp4" and "audio/aac" tests.

  • media/media-can-play-mp3-expected.txt: Removed.
  • media/media-can-play-mp3.html: Removed.
  • media/media-can-play-mpeg-audio-expected.txt: Copied from LayoutTests/media/media-can-play-mp3-expected.txt.
  • media/media-can-play-mpeg-audio.html: Copied from LayoutTests/media/media-can-play-mp3.html.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
1:08 PM Changeset in webkit [63238] by sullivan@apple.com
  • 2 edits in trunk/WebKit2

Fixed signed/unsigned problem that led to bogus contents in the array
returned by WKBackForwardListCopyBackListWithLimit().

Reviewed by Sam Weinig.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
Cast m_current and limit to signed values in std::max call.

12:59 PM Applications using WebKit edited by tom-brown@live.co.uk
Browser added (diff)
12:57 PM Changeset in webkit [63237] by oliver@apple.com
  • 7 edits in trunk/JavaScriptCore

2010-07-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

REGRESSION: Crash at JSC::JIT::privateCompile(JSC::MacroAssemblerCodePtr*)
​https://bugs.webkit.org/show_bug.cgi?id=41763

There are two parts to this patch, the first is to fix the actual
problem. When calling copyStringWithoutBOMs on a string we know
to contain BOMs we return a value indicating that there are no
BOMs.

The second part of this fix is simply to harden the path that
led to a crash when parsing failed.

  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):

Harden compilation stubs against parser failure.

  • parser/Lexer.cpp: (JSC::Lexer::sourceCode):

Add assertions to ensure that subranges into a source provider
are always actually braces. Hopefully this should catch similar
failures in future. These assertions fire on existing tests
without this fix.

  • runtime/Executable.h: (JSC::FunctionExecutable::tryJitCodeForCall): (JSC::FunctionExecutable::tryJitCodeForConstruct):
  • wtf/text/StringImpl.h: (WebCore::StringImpl::copyStringWithoutBOMs):

Make copyStringWithBOMs do the right thing.

12:56 PM Changeset in webkit [63236] by commit-queue@webkit.org
  • 2 edits in trunk

2010-07-13 Scott Violet <​sky@chromium.org>

Reviewed by David Levin.

[Chromium] Makes pressing tab accept the currently selected item in a popup.
​https://bugs.webkit.org/show_bug.cgi?id=42172

  • WebCore/platform/chromium/PopupMenuChromium.cpp:
12:51 PM Changeset in webkit [63235] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/index.html

2010-07-13 William Siegrist <​wsiegrist@apple.com>

Add Test Results link to buildbot master home page.

12:47 PM Changeset in webkit [63234] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-13 Robert Hogan <​robert@webkit.org>

[Gtk] Skip http/tests/uppercase-mime-type.html on Gtk

Unreviewed.

The test now requires dumpResourceResponseMIMETypes(), which Gtk
does not yet support.

  • platform/gtk/Skipped:
12:33 PM Changeset in webkit [63233] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk/JavaScriptCore/qt

2010-07-13 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Introduce QScriptValueIterator.

The QScriptValueIterator class permits to iterate over a QScriptValue's properties.

[Qt] QtScript should provide an API for enumerating a JS object's properties
​https://bugs.webkit.org/show_bug.cgi?id=41680

  • api/QtScript.pro:
  • api/qscriptvalueiterator.cpp: Added. (QScriptValueIterator::QScriptValueIterator): (QScriptValueIterator::~QScriptValueIterator): (QScriptValueIterator::hasNext): (QScriptValueIterator::next): (QScriptValueIterator::hasPrevious): (QScriptValueIterator::previous): (QScriptValueIterator::toFront): (QScriptValueIterator::toBack): (QScriptValueIterator::name): (QScriptValueIterator::scriptName): (QScriptValueIterator::value): (QScriptValueIterator::setValue): (QScriptValueIterator::remove): (QScriptValueIterator::flags): (QScriptValueIterator::operator=):
  • api/qscriptvalueiterator.h: Added.
  • api/qscriptvalueiterator_p.h: Added. (QScriptValueIteratorPrivate::QScriptValueIteratorPrivate): (QScriptValueIteratorPrivate::~QScriptValueIteratorPrivate): (QScriptValueIteratorPrivate::hasNext): (QScriptValueIteratorPrivate::next): (QScriptValueIteratorPrivate::hasPrevious): (QScriptValueIteratorPrivate::previous): (QScriptValueIteratorPrivate::name): (QScriptValueIteratorPrivate::scriptName): (QScriptValueIteratorPrivate::value): (QScriptValueIteratorPrivate::setValue): (QScriptValueIteratorPrivate::remove): (QScriptValueIteratorPrivate::toFront): (QScriptValueIteratorPrivate::toBack): (QScriptValueIteratorPrivate::flags): (QScriptValueIteratorPrivate::isValid): (QScriptValueIteratorPrivate::engine):
  • tests/qscriptvalueiterator/qscriptvalueiterator.pro: Added.
  • tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp: Added. (tst_QScriptValueIterator::tst_QScriptValueIterator): (tst_QScriptValueIterator::~tst_QScriptValueIterator): (tst_QScriptValueIterator::iterateForward_data): (tst_QScriptValueIterator::iterateForward): (tst_QScriptValueIterator::iterateBackward_data): (tst_QScriptValueIterator::iterateBackward): (tst_QScriptValueIterator::iterateArray_data): (tst_QScriptValueIterator::iterateArray): (tst_QScriptValueIterator::iterateBackAndForth): (tst_QScriptValueIterator::setValue): (tst_QScriptValueIterator::remove): (tst_QScriptValueIterator::removeMixed): (tst_QScriptValueIterator::removeUndeletable): (tst_QScriptValueIterator::iterateString): (tst_QScriptValueIterator::assignObjectToIterator):
  • tests/tests.pro:
12:22 PM Changeset in webkit [63232] by tonyg@chromium.org
  • 2 edits in trunk

ChangeLog

12:21 PM Changeset in webkit [63231] by tonyg@chromium.org
  • 9 edits in trunk

2010-07-13 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Fix two baselines from my previous commit.

  • platform/gtk/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/gtk/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:

2010-07-13 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Fisher.

Implement performance.timing.fetchStart
​https://bugs.webkit.org/show_bug.cgi?id=41816

See: ​http://dev.w3.org/2006/webapi/WebTiming/#nt-fetch-start

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Record the fetchStart time for each request for the main resource. This means it is called for each server redirect, overwritting the previous value. In ​https://bugs.webkit.org/show_bug.cgi?id=42018, this will be modified such that if a previous value exists, it is stored as the redirect time.
  • loader/FrameLoaderTypes.h: (WebCore::FrameLoadTimeline::FrameLoadTimeline):
  • page/Timing.cpp: (WebCore::Timing::fetchStart):
  • page/Timing.h:
  • page/Timing.idl:
12:16 PM Changeset in webkit [63230] by commit-queue@webkit.org
  • 9 edits
    5 adds in trunk/WebCore

2010-07-13 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech input plumbing in webcore
​https://bugs.webkit.org/show_bug.cgi?id=41518

Adds the following:

  • a SpeechInput class to be used by the speech enabled HTML elements
  • a SpeechInputListener interface to be implemented by the speech enabled HTML elements
  • a SpeechInputClient interface (defined in WebCore, implemented by WebKit) for WebCore to call into WebKit. This is available as a member of WebCore::Page, set by the platforms which support speech input.
  • a SpeechInputClientListener interface for WebCore to receive events from WebKit

No new tests, the relevant LayoutTestController bindings will be added in a subsequent patch.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: Added SpeechInputClient member variable and associated methods. (WebCore::Page::setSpeechInputClient): (WebCore::Page::speechInputClient):
  • page/SpeechInput.cpp: Added new class to provide speech API services to HTML elements. (WebCore::SpeechInput::SpeechInput): (WebCore::SpeechInput::recordingComplete): (WebCore::SpeechInput::setRecognitionResult): (WebCore::SpeechInput::startRecognition):
  • page/SpeechInput.h: Added. (WebCore::SpeechInput::~SpeechInput): (WebCore::SpeechInput::client):
  • page/SpeechInputListener.h: Added. (WebCore::SpeechInputListener::~SpeechInputListener):
  • page/SpeechInputClient.h: Added new interface implemented by WebKit to bubble up speech API requests to the embedder. (WebCore::SpeechInputClient::~SpeechInputClient):
  • page/SpeechInputClientListener.h: Added. (WebCore::SpeechInputClientListener::~SpeechInputClientListener):
11:56 AM Changeset in webkit [63229] by robert@webkit.org
  • 5 edits in trunk

2010-07-13 Richard Moore <​rich@kde.org>, Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] MIME handling in qtwebkit network layer case-sensitivity

​https://bugs.webkit.org/show_bug.cgi?id=28654

Modify existing test uppercase-mime-type.html to test for the
lower-casing explicitly.

  • http/tests/mime/uppercase-mime-type-expected.txt:
  • http/tests/mime/uppercase-mime-type.html:

2010-07-13 Richard Moore <​rich@kde.org>, Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] MIME handling in qtwebkit network layer case-sensitivity

​https://bugs.webkit.org/show_bug.cgi?id=28654

Like other platforms, Qt needs to convert MIME types to lower case
so they will be handled by WebCore.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
11:56 AM Changeset in webkit [63228] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

Fix the constant encoding in data transfer instructions on ARM
​https://bugs.webkit.org/show_bug.cgi?id=42166

Reviewed by Gavin Barraclough.

The getImm function is designed to produce modified immediate constant
for data processing instructions. It should not be used to encode
any constant for data transfer. In the current situation there is no
way to use any immediate constant for data transfer. So, the moveImm
function is the desired method to pass the offset value to the data
transfer instructions.

Reported by Jacob Bramley.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::dataTransfer32):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::call32):

11:27 AM Changeset in webkit [63227] by sfalken@apple.com
  • 2 edits
    1 copy in trunk/WebKit2

2010-07-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada Chan.

Fix missing resources causing layout test failures
​https://bugs.webkit.org/show_bug.cgi?id=42179


Quick fix to get the layout tests going again.
I'll work on getting resource.h from WebKit into a cross-project
propagated header after this lands.

  • win/WebKit2.rc:
  • win/resource.h: Copied from WebKit/win/WebKit.vcproj/resource.h.
11:21 AM Changeset in webkit [63226] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-07-13 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

REGRESSION(55056) debug builds ASSERT falsely on pages with animations
​https://bugs.webkit.org/show_bug.cgi?id=42175

Revision 55065 added some repaint box precomputation and some debug ASSERT()ions
to ensure the precomputed values were valid. However, if animations are enabled and
not hardware accelerated, the repaint box dimensions become time-dependent and the
ASSERT()s can trigger. This can make it impossible to interactively debug pages
like google maps.

​https://bugs.webkit.org/show_bug.cgi?id=37048 is another example of an assertion
failing due to time dependent animation values.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
11:01 AM Changeset in webkit [63225] by alex
  • 1 edit
    1 delete in trunk/WebKit/gtk/po

2010-07-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Gustavo Noronha.

This file is generated, we do not need to upload it to the
repository.

  • webkit.pot: Removed.
10:53 AM Changeset in webkit [63224] by zmo@google.com
  • 11 edits
    2 adds in trunk

2010-07-10 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Implement bufferData and bufferSubData with ArrayBuffer as input
​https://bugs.webkit.org/show_bug.cgi?id=41884

  • src/GraphicsContext3D.cpp: Implement bufferData and bufferSubData with ArrayBuffer as input. (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData):

2010-07-10 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Implement bufferData and bufferSubData with ArrayBuffer as input
​https://bugs.webkit.org/show_bug.cgi?id=41884

Test: fast/canvas/webgl/buffer-data-array-buffer.html

  • html/canvas/WebGLBuffer.cpp: Implement associateBufferData & associateBufferSubData with ArrayBuffer as input. (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData):
  • html/canvas/WebGLBuffer.h: Ditto.
  • html/canvas/WebGLRenderingContext.cpp: Implement bufferData and bufferSubData with ArrayBuffer as input. (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData):
  • html/canvas/WebGLRenderingContext.h: Ditto.
  • html/canvas/WebGLRenderingContext.idl: Ditto.
  • platform/graphics/GraphicsContext3D.h: Ditto.
  • platform/graphics/mac/GraphicsContext3DMac.mm: Ditto. (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData):

2010-07-10 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Implement bufferData and bufferSubData with ArrayBuffer as input
​https://bugs.webkit.org/show_bug.cgi?id=41884

  • fast/canvas/webgl/buffer-data-array-buffer-expected.txt: Added.
  • fast/canvas/webgl/buffer-data-array-buffer.html: Added.
10:52 AM Changeset in webkit [63223] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Windows build fix.
Make WebKit.sln build WebKit.dll as it used to in the past.
(sln is updated to include necessary projects)

  • WebKit.vcproj/WebKit.sln:
10:39 AM Changeset in webkit [63222] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-07-13 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Fix two baselines from my previous commit.

  • platform/gtk/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/gtk/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
10:28 AM Changeset in webkit [63221] by tonyg@chromium.org
  • 9 edits in trunk

2010-07-13 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Fisher.

Implement performance.timing.responseEnd
​https://bugs.webkit.org/show_bug.cgi?id=42006

  • fast/dom/script-tests/webtiming.js: (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-expected.txt:

2010-07-13 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Fisher.

Implement performance.timing.responseEnd
​https://bugs.webkit.org/show_bug.cgi?id=42006

See: ​http://dev.w3.org/2006/webapi/WebTiming/#nt-response-end

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoading):
  • loader/FrameLoaderTypes.h: (WebCore::FrameLoadTimeline::FrameLoadTimeline):
  • page/Timing.cpp: (WebCore::Timing::responseEnd):
  • page/Timing.h:
  • page/Timing.idl:
10:22 AM Changeset in webkit [63220] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-13 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. It seems rebaseline for foreign-object-skew.svg somehow failed.

Update padding on Windows?
​https://bugs.webkit.org/show_bug.cgi?id=38016

  • platform/chromium/test_expectations.txt:
10:19 AM Changeset in webkit [63219] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-07-13 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by Darin Fisher

Bug 41962 Limit html canvas element dimensions to 32767 for Skia platform
​https://bugs.webkit.org/show_bug.cgi?id=41962

Test: fast/canvas/canvas-skia-excessive-size.html

  • WebCore/html/HTMLCanvasElement.cpp (WebCore::HTMLCanvasElement::convertLogicalToDevice):

2010-07-13 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by Darin Fisher

Bug 41962 Limit html canvas element dimensions to 32767 for Skia platform
​https://bugs.webkit.org/show_bug.cgi?id=41962

  • fast/canvas/canvas-skia-excessive-size.html: Added.
  • fast/canvas/canvas-skia-excessive-size-expected.txt: Added.
10:10 AM Changeset in webkit [63218] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Document the member functions of the abstract Plugin and PluginController classes.

Reviewed by Adam Roben.

  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginController.h:
10:09 AM Changeset in webkit [63217] by ap@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=9504
img tag rewritten by innerHTML doesn't use image map

The test didn't get landed with the fix 5 weeks ago, landing now.

  • fast/dom/replaced-image-map-expected.txt: Added.
  • fast/dom/replaced-image-map.html: Added.
9:57 AM Changeset in webkit [63216] by Martin Robinson
  • 1 edit
    28 adds in trunk/LayoutTests

2010-07-13 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests.

  • platform/gtk/fast/gradients/radial-centered-expected.txt: Added.
  • platform/gtk/fast/inline/continuation-outlines-with-layers-2-expected.txt: Added.
  • platform/gtk/fast/repaint/stacked-diacritics-expected.txt: Added.
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/gtk/fast/text/international/plane2-expected.txt: Added.
  • platform/gtk/scrollbars/basic-scrollbar-expected.txt: Added.
  • platform/gtk/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/gtk/svg/css/text-shadow-multiple-expected.txt: Added.
  • platform/gtk/svg/custom/bug45331-expected.txt: Added.
  • platform/gtk/svg/custom/clone-element-with-animated-svg-properties-expected.txt: Added.
  • platform/gtk/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/gtk/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/gtk/svg/custom/repaint-moving-svg-and-div-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/repaint-moving-svg-and-div-expected.txt.
  • platform/gtk/svg/custom/svg-curve-with-relative-cordinates-expected.txt: Added.
  • platform/gtk/svg/custom/text-rotated-gradient-expected.txt: Added.
  • platform/gtk/svg/custom/use-font-face-crash-expected.txt: Added.
  • platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-property-synchronization-crash-expected.txt.
  • platform/gtk/svg/filters/filter-width-update-expected.txt: Added.
  • platform/gtk/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Copied from LayoutTests/platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt.
  • platform/gtk/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added.
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added.
  • platform/gtk/svg/foreignObject/svg-document-in-html-document-expected.txt: Added.
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt: Added.
9:50 AM Changeset in webkit [63215] by zmo@google.com
  • 7 edits in trunk

2010-07-10 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Need to emulate MAX_VARYING_VECTORS/MAX_FRAGMENT_UNIFORM_VECTORs/MAX_VERTEX_UNIFORM_VECTORS for glGet
​https://bugs.webkit.org/show_bug.cgi?id=42032

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): Emulate the enums.

2010-07-10 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Need to emulate MAX_VARYING_VECTORS/MAX_FRAGMENT_UNIFORM_VECTORs/MAX_VERTEX_UNIFORM_VECTORS for glGet
​https://bugs.webkit.org/show_bug.cgi?id=42032

  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::getIntegerv): Emulate the enums.

2010-07-10 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Need to emulate MAX_VARYING_VECTORS/MAX_FRAGMENT_UNIFORM_VECTORs/MAX_VERTEX_UNIFORM_VECTORS for glGet
​https://bugs.webkit.org/show_bug.cgi?id=42032

  • fast/canvas/webgl/gl-get-calls-expected.txt: Add the test cases for the three enums.
  • fast/canvas/webgl/gl-get-calls.html: Ditto.
9:44 AM Changeset in webkit [63214] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-07-13 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] video playback position query flood when mouse over the video element
​https://bugs.webkit.org/show_bug.cgi?id=35333

Don't trigger a position query only to know which play/pause
button to display. Instead use the media-control button display
type to select the image to paint.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaPlayButton):
9:37 AM Changeset in webkit [63213] by andreas.kling@nokia.com
  • 2 edits
    1 delete in trunk/WebCore

2010-07-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63192.
​http://trac.webkit.org/changeset/63192
​https://bugs.webkit.org/show_bug.cgi?id=42173

Broke fast/backgrounds/size/contain-and-cover.html (Requested
by kling on #webkit).

  • manual-tests/css3-background-layer-count.html: Removed.
  • rendering/style/FillLayer.cpp: (WebCore::FillLayer::cullEmptyLayers):
9:17 AM Changeset in webkit [63212] by Martin Robinson
  • 2 edits
    3 adds in trunk/LayoutTests

2010-07-13 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Unskip and add results for a test that is passing after r63176.

  • platform/gtk/Skipped:
  • platform/gtk/fast/text/shadow-translucent-fill-expected.checksum: Added.
  • platform/gtk/fast/text/shadow-translucent-fill-expected.png: Added.
  • platform/gtk/fast/text/shadow-translucent-fill-expected.txt: Added.
9:12 AM Changeset in webkit [63211] by bulach@chromium.org
  • 10 edits in trunk/WebCore

2010-07-13 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Removes cycles caused by "m_this" members in a few IndexedDB classes.
​https://bugs.webkit.org/show_bug.cgi?id=42161

Adds IDBAny::create for the various types.
No functionality change, just cleaning up.

  • storage/IDBAny.cpp: (WebCore::createIDBAny): (WebCore::IDBAny::create):
  • storage/IDBAny.h:
  • storage/IDBDatabaseRequest.cpp: (WebCore::IDBDatabaseRequest::IDBDatabaseRequest): (WebCore::IDBDatabaseRequest::createObjectStore): (WebCore::IDBDatabaseRequest::removeObjectStore):
  • storage/IDBDatabaseRequest.h:
  • storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::IDBKeyRange):
  • storage/IDBKeyRange.h: (WebCore::IDBKeyRange::left): (WebCore::IDBKeyRange::right):
  • storage/IDBObjectStoreRequest.cpp: (WebCore::IDBObjectStoreRequest::IDBObjectStoreRequest): (WebCore::IDBObjectStoreRequest::get): (WebCore::IDBObjectStoreRequest::add): (WebCore::IDBObjectStoreRequest::put): (WebCore::IDBObjectStoreRequest::remove): (WebCore::IDBObjectStoreRequest::createIndex): (WebCore::IDBObjectStoreRequest::removeIndex):
  • storage/IDBObjectStoreRequest.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest): (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:
8:54 AM Changeset in webkit [63210] by andreas.kling@nokia.com
  • 5 edits in trunk/LayoutTests

2010-07-13 Andreas Kling <​andreas.kling@nokia.com>

Unreviewed. Rebaseline resize-from-plugin.html

  • platform/gtk/plugins/resize-from-plugin-expected.txt:
  • platform/qt/plugins/resize-from-plugin-expected.txt:
  • platform/win/plugins/resize-from-plugin-expected.txt:
  • plugins/resize-from-plugin-expected.txt:
8:31 AM Changeset in webkit [63209] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2010-07-13 Andreas Kling <​andreas.kling@nokia.com>

Unreviewed.

Putting 2d.imageData.get.source.outside.html back on the mac skiplist
since it fails on the bot for some reason.

​https://bugs.webkit.org/show_bug.cgi?id=41478

  • platform/mac/Skipped:
8:22 AM Changeset in webkit [63208] by andreas.kling@nokia.com
  • 7 edits in trunk/LayoutTests

2010-07-13 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] results from resize-from-plugin.html are wrong
​https://bugs.webkit.org/show_bug.cgi?id=40879

Reorder test contents to get same metrics on all platforms
and unskip it on Qt, since it's now meeting the criteria of the test.

  • platform/gtk/plugins/resize-from-plugin-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/plugins/resize-from-plugin-expected.txt:
  • platform/win/plugins/resize-from-plugin-expected.txt:
  • plugins/resize-from-plugin-expected.txt:
  • plugins/resize-from-plugin.html:
8:06 AM Changeset in webkit [63207] by Simon Hausmann
  • 2 edits in trunk/WebKit2

[Qt] Trivial build fix.

Provide a stub for mimeTypeFromExtension() that uses notImplemented().

  • UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:

(WebKit::PluginInfoStore::mimeTypeFromExtension):

8:00 AM Changeset in webkit [63206] by Simon Hausmann
  • 6 edits in trunk

WebCore: [Qt] Land the initial build system for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=41604

Patch by Antti Koivisto <​koivisto@iki.fi> on 2010-07-13
Reviewed by Kenneth Rohde Christiansen.

The build is enabled by passing --qmakearg="CONFIG+=webkit2" to build-webkit

  • WebCore.pri:
  • WebCore.pro:

WebKit2: [Qt] Tweaks needed to compile WebKit2 with Qt
​https://bugs.webkit.org/show_bug.cgi?id=41604

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncherHelper::launch): Adjust to PassOwnPtr API changes.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Don't include JavaScriptCore.h,

as it unconditionally includes JSStringRefCF. Instead include JavaScript.h.

7:52 AM Changeset in webkit [63205] by andreas.kling@nokia.com
  • 8 edits in trunk/LayoutTests

2010-07-13 Andreas Kling <​andreas.kling@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Unskip 6 canvas/philip tests for Qt

  • canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.inside2-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.inside3-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.outside1-expected.txt:
  • canvas/philip/tests/2d.line.cap.closed-expected.txt:
  • canvas/philip/tests/2d.line.join.parallel-expected.txt:
  • platform/qt/Skipped:
7:33 AM Changeset in webkit [63204] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-07-13 Leon Clarke <​leonclarke@google.com>

Reviewed by Pavel Feldman.

Don't access objects after deleting them, following
the addition of link prefetching. Also remove a forward declaration
of the now-nonexistent CachedLinkPrefetch class.
​https://bugs.webkit.org/show_bug.cgi?id=3652

No new tests. Correcting aspects of the prefetch change that shouldn't
have affected functionality.

  • html/HTMLLinkElement.h:
  • loader/loader.cpp: (WebCore::Loader::Host::cancelPendingRequests):
7:24 AM Changeset in webkit [63203] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix the case of a linker option to lowercase to be able to
cross compile QtWebKit for Windows on Linux.

Reviewed by Simon Hausmann.

No new tests needed.

  • WebCore.pro:
7:24 AM Changeset in webkit [63202] by andreas.kling@nokia.com
  • 4 edits in trunk/LayoutTests

2010-07-13 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Unskip canvas/philip/tests/2d.imageData.get.source.outside.html
​https://bugs.webkit.org/show_bug.cgi?id=41478

  • canvas/philip/tests/2d.imageData.get.source.outside-expected.txt:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
7:23 AM Changeset in webkit [63201] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-07-13 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: catch and log JS exceptions resulting from executing a
script on inspector front-end to prevent renderer from crashing.
​https://bugs.webkit.org/show_bug.cgi?id=42157

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::executeScript):
6:43 AM Changeset in webkit [63200] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/inspector/resource-har-conversion.html is failing on the 32bit Linux Release bot.
webkit.org/b/42162

Rubber-stamped by Tor Arne Vestbø.

  • platform/qt/Skipped: Skip the test until fix.
6:39 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
6:04 AM Changeset in webkit [63199] by pfeldman@chromium.org
  • 4 edits in trunk/LayoutTests

2010-07-13 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Rebaseline html5lib/runner.html
​https://bugs.webkit.org/show_bug.cgi?id=42158

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium/test_expectations.txt:
5:26 AM Changeset in webkit [63198] by loislo@chromium.org
  • 22 edits
    1 add
    1 delete in trunk

2010-07-12 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Next iteration of Inspector code generator.
The InspectorFrontend2 was replaced by slightly modified version of
InspectorBackend file (Inspector.idl). At the end all the interface
between WebInspector and inspected page will be specified by this file
and generated by CodeGeneratorInspector (InspectorFrontend.cpp,
InspectorBackend.cpp and InspectorBackend.js).
​https://bugs.webkit.org/show_bug.cgi?id=42104

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_binding.py:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/IDLParser.pm:
  • bindings/scripts/IDLStructure.pm:
  • bindings/scripts/generate-bindings.pl:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl: Added.
  • inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::inspectorStyleSheet):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::startTimelineProfiler):
  • inspector/InspectorController.h: (WebCore::InspectorController::remoteInspectorFrontend):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
  • inspector/InspectorFrontend2.idl: Removed.
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::resetFrontendProxyObject):
  • inspector/InspectorTimelineAgent.h:
5:25 AM Changeset in webkit [63197] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/win

Windows build fix

  • Interfaces/WebKit.idl: Touched to force a build
5:22 AM Changeset in webkit [63196] by hamaji@chromium.org
  • 484 edits
    1 copy
    3 adds in trunk/LayoutTests

2010-07-13 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. Rebaseline chromium tests for r63071.

Update padding on Windows?
​https://bugs.webkit.org/show_bug.cgi?id=38016

  • platform/chromium-linux/editing/selection/3690703-2-expected.checksum:
  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-2-expected.txt:
  • platform/chromium-linux/editing/selection/3690703-expected.checksum:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.txt:
  • platform/chromium-linux/editing/selection/3690719-expected.checksum:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.txt:
  • platform/chromium-linux/editing/selection/4397952-expected.checksum:
  • platform/chromium-linux/editing/selection/4397952-expected.png:
  • platform/chromium-linux/editing/selection/4397952-expected.txt:
  • platform/chromium-linux/editing/selection/5240265-expected.checksum:
  • platform/chromium-linux/editing/selection/5240265-expected.png:
  • platform/chromium-linux/editing/selection/5240265-expected.txt:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.checksum:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.txt:
  • platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/chromium-linux/fast/css/continuationCrash-expected.checksum:
  • platform/chromium-linux/fast/css/continuationCrash-expected.png:
  • platform/chromium-linux/fast/css/continuationCrash-expected.txt:
  • platform/chromium-linux/fast/css/margin-top-bottom-dynamic-expected.checksum:
  • platform/chromium-linux/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-linux/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/chromium-linux/fast/css/rtl-ordering-expected.checksum:
  • platform/chromium-linux/fast/css/rtl-ordering-expected.png:
  • platform/chromium-linux/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-linux/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.checksum:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.png:
  • platform/chromium-linux/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-linux/fast/forms/blankbuttons-expected.checksum:
  • platform/chromium-linux/fast/forms/blankbuttons-expected.png:
  • platform/chromium-linux/fast/forms/blankbuttons-expected.txt:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.checksum:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/button-align-expected.checksum:
  • platform/chromium-linux/fast/forms/button-align-expected.png:
  • platform/chromium-linux/fast/forms/button-align-expected.txt:
  • platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.checksum:
  • platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.png:
  • platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/chromium-linux/fast/forms/button-default-title-expected.checksum:
  • platform/chromium-linux/fast/forms/button-default-title-expected.png:
  • platform/chromium-linux/fast/forms/button-default-title-expected.txt:
  • platform/chromium-linux/fast/forms/button-generated-content-expected.checksum:
  • platform/chromium-linux/fast/forms/button-generated-content-expected.png:
  • platform/chromium-linux/fast/forms/button-generated-content-expected.txt:
  • platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.checksum:
  • platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.png:
  • platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/chromium-linux/fast/forms/button-positioned-expected.checksum:
  • platform/chromium-linux/fast/forms/button-positioned-expected.png:
  • platform/chromium-linux/fast/forms/button-positioned-expected.txt:
  • platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/button-sizes-expected.txt:
  • platform/chromium-linux/fast/forms/button-style-color-expected.checksum:
  • platform/chromium-linux/fast/forms/button-style-color-expected.png:
  • platform/chromium-linux/fast/forms/button-style-color-expected.txt:
  • platform/chromium-linux/fast/forms/button-table-styles-expected.checksum:
  • platform/chromium-linux/fast/forms/button-table-styles-expected.png:
  • platform/chromium-linux/fast/forms/button-table-styles-expected.txt:
  • platform/chromium-linux/fast/forms/button-text-transform-expected.checksum:
  • platform/chromium-linux/fast/forms/button-text-transform-expected.png:
  • platform/chromium-linux/fast/forms/button-text-transform-expected.txt:
  • platform/chromium-linux/fast/forms/button-white-space-expected.checksum:
  • platform/chromium-linux/fast/forms/button-white-space-expected.png:
  • platform/chromium-linux/fast/forms/button-white-space-expected.txt:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.checksum:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.png:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.txt:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.checksum:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.png:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.checksum:
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.txt:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.checksum:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-linux/fast/forms/formmove3-expected.checksum:
  • platform/chromium-linux/fast/forms/formmove3-expected.png:
  • platform/chromium-linux/fast/forms/formmove3-expected.txt:
  • platform/chromium-linux/fast/forms/hidden-input-file-expected.checksum:
  • platform/chromium-linux/fast/forms/hidden-input-file-expected.png:
  • platform/chromium-linux/fast/forms/hidden-input-file-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.checksum:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.checksum:
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.txt:
  • platform/chromium-linux/fast/forms/input-value-expected.checksum:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.txt:
  • platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-linux/fast/forms/select-baseline-expected.png:
  • platform/chromium-linux/fast/forms/select-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/targeted-frame-submission-expected.checksum:
  • platform/chromium-linux/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-linux/fast/forms/targeted-frame-submission-expected.txt:
  • platform/chromium-linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
  • platform/chromium-linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-linux/fast/replaced/width100percent-button-expected.checksum:
  • platform/chromium-linux/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-button-expected.txt:
  • platform/chromium-linux/fast/selectors/064-expected.checksum:
  • platform/chromium-linux/fast/selectors/064-expected.png:
  • platform/chromium-linux/fast/selectors/064-expected.txt:
  • platform/chromium-linux/fast/table/append-cells2-expected.checksum:
  • platform/chromium-linux/fast/table/append-cells2-expected.png:
  • platform/chromium-linux/fast/table/append-cells2-expected.txt:
  • platform/chromium-linux/fast/table/remove-td-display-none-expected.checksum:
  • platform/chromium-linux/fast/table/remove-td-display-none-expected.png:
  • platform/chromium-linux/fast/table/remove-td-display-none-expected.txt:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.checksum:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.txt:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.checksum:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-linux/http/tests/navigation/anchor-frames-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/anchor-frames-expected.png:
  • platform/chromium-linux/http/tests/navigation/anchor-frames-expected.txt:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.checksum:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/chromium-win/editing/selection/3690703-2-expected.checksum:
  • platform/chromium-win/editing/selection/3690703-2-expected.png:
  • platform/chromium-win/editing/selection/3690703-2-expected.txt:
  • platform/chromium-win/editing/selection/3690703-expected.checksum:
  • platform/chromium-win/editing/selection/3690703-expected.png:
  • platform/chromium-win/editing/selection/3690703-expected.txt:
  • platform/chromium-win/editing/selection/3690719-expected.checksum:
  • platform/chromium-win/editing/selection/3690719-expected.png:
  • platform/chromium-win/editing/selection/3690719-expected.txt:
  • platform/chromium-win/editing/selection/4397952-expected.checksum:
  • platform/chromium-win/editing/selection/4397952-expected.png:
  • platform/chromium-win/editing/selection/4397952-expected.txt:
  • platform/chromium-win/editing/selection/5240265-expected.checksum:
  • platform/chromium-win/editing/selection/5240265-expected.png:
  • platform/chromium-win/editing/selection/5240265-expected.txt:
  • platform/chromium-win/fast/block/float/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-win/fast/block/float/float-avoidance-expected.txt:
  • platform/chromium-win/fast/block/positioning/inline-block-relposition-expected.checksum:
  • platform/chromium-win/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/chromium-win/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/chromium-win/fast/css/continuationCrash-expected.checksum:
  • platform/chromium-win/fast/css/continuationCrash-expected.png:
  • platform/chromium-win/fast/css/continuationCrash-expected.txt:
  • platform/chromium-win/fast/css/margin-top-bottom-dynamic-expected.checksum:
  • platform/chromium-win/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-win/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/chromium-win/fast/css/rtl-ordering-expected.checksum:
  • platform/chromium-win/fast/css/rtl-ordering-expected.png:
  • platform/chromium-win/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/chromium-win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/chromium-win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/chromium-win/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
  • platform/chromium-win/fast/forms/001-expected.checksum:
  • platform/chromium-win/fast/forms/001-expected.png: Added.
  • platform/chromium-win/fast/forms/001-expected.txt:
  • platform/chromium-win/fast/forms/basic-buttons-expected.checksum:
  • platform/chromium-win/fast/forms/basic-buttons-expected.png:
  • platform/chromium-win/fast/forms/basic-buttons-expected.txt:
  • platform/chromium-win/fast/forms/blankbuttons-expected.checksum:
  • platform/chromium-win/fast/forms/blankbuttons-expected.png:
  • platform/chromium-win/fast/forms/blankbuttons-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.checksum:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/button-align-expected.checksum:
  • platform/chromium-win/fast/forms/button-align-expected.png:
  • platform/chromium-win/fast/forms/button-align-expected.txt:
  • platform/chromium-win/fast/forms/button-cannot-be-nested-expected.checksum:
  • platform/chromium-win/fast/forms/button-cannot-be-nested-expected.png:
  • platform/chromium-win/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/chromium-win/fast/forms/button-default-title-expected.checksum:
  • platform/chromium-win/fast/forms/button-default-title-expected.png:
  • platform/chromium-win/fast/forms/button-default-title-expected.txt:
  • platform/chromium-win/fast/forms/button-generated-content-expected.checksum:
  • platform/chromium-win/fast/forms/button-generated-content-expected.png:
  • platform/chromium-win/fast/forms/button-generated-content-expected.txt:
  • platform/chromium-win/fast/forms/button-inner-block-reuse-expected.checksum:
  • platform/chromium-win/fast/forms/button-inner-block-reuse-expected.png:
  • platform/chromium-win/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/chromium-win/fast/forms/button-positioned-expected.checksum:
  • platform/chromium-win/fast/forms/button-positioned-expected.png:
  • platform/chromium-win/fast/forms/button-positioned-expected.txt:
  • platform/chromium-win/fast/forms/button-sizes-expected.checksum:
  • platform/chromium-win/fast/forms/button-sizes-expected.png:
  • platform/chromium-win/fast/forms/button-sizes-expected.txt:
  • platform/chromium-win/fast/forms/button-style-color-expected.checksum:
  • platform/chromium-win/fast/forms/button-style-color-expected.png:
  • platform/chromium-win/fast/forms/button-style-color-expected.txt:
  • platform/chromium-win/fast/forms/button-table-styles-expected.checksum:
  • platform/chromium-win/fast/forms/button-table-styles-expected.png:
  • platform/chromium-win/fast/forms/button-table-styles-expected.txt:
  • platform/chromium-win/fast/forms/button-text-transform-expected.checksum:
  • platform/chromium-win/fast/forms/button-text-transform-expected.png:
  • platform/chromium-win/fast/forms/button-text-transform-expected.txt:
  • platform/chromium-win/fast/forms/button-white-space-expected.checksum:
  • platform/chromium-win/fast/forms/button-white-space-expected.png:
  • platform/chromium-win/fast/forms/button-white-space-expected.txt:
  • platform/chromium-win/fast/forms/control-clip-overflow-expected.checksum:
  • platform/chromium-win/fast/forms/control-clip-overflow-expected.png:
  • platform/chromium-win/fast/forms/control-clip-overflow-expected.txt:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-win/fast/forms/file-input-direction-expected.checksum:
  • platform/chromium-win/fast/forms/file-input-direction-expected.png:
  • platform/chromium-win/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-win/fast/forms/file-input-disabled-expected.checksum:
  • platform/chromium-win/fast/forms/file-input-disabled-expected.png:
  • platform/chromium-win/fast/forms/file-input-disabled-expected.txt:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.checksum:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-win/fast/forms/formmove3-expected.checksum:
  • platform/chromium-win/fast/forms/formmove3-expected.png:
  • platform/chromium-win/fast/forms/formmove3-expected.txt:
  • platform/chromium-win/fast/forms/hidden-input-file-expected.checksum:
  • platform/chromium-win/fast/forms/hidden-input-file-expected.png:
  • platform/chromium-win/fast/forms/hidden-input-file-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.checksum:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/input-file-re-render-expected.checksum:
  • platform/chromium-win/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-win/fast/forms/input-file-re-render-expected.txt:
  • platform/chromium-win/fast/forms/input-first-letter-expected.checksum:
  • platform/chromium-win/fast/forms/input-first-letter-expected.png: Added.
  • platform/chromium-win/fast/forms/input-first-letter-expected.txt:
  • platform/chromium-win/fast/forms/input-value-expected.checksum:
  • platform/chromium-win/fast/forms/input-value-expected.png:
  • platform/chromium-win/fast/forms/input-value-expected.txt:
  • platform/chromium-win/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-win/fast/forms/select-baseline-expected.png:
  • platform/chromium-win/fast/forms/select-baseline-expected.txt:
  • platform/chromium-win/fast/forms/targeted-frame-submission-expected.checksum:
  • platform/chromium-win/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-win/fast/forms/targeted-frame-submission-expected.txt:
  • platform/chromium-win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
  • platform/chromium-win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/chromium-win/fast/overflow/scrollRevealButton-expected.checksum:
  • platform/chromium-win/fast/overflow/scrollRevealButton-expected.png: Added.
  • platform/chromium-win/fast/overflow/scrollRevealButton-expected.txt:
  • platform/chromium-win/fast/replaced/replaced-breaking-expected.checksum:
  • platform/chromium-win/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-win/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-button-expected.checksum:
  • platform/chromium-win/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-win/fast/replaced/width100percent-button-expected.txt:
  • platform/chromium-win/fast/selectors/064-expected.checksum:
  • platform/chromium-win/fast/selectors/064-expected.png:
  • platform/chromium-win/fast/selectors/064-expected.txt:
  • platform/chromium-win/fast/table/append-cells2-expected.checksum:
  • platform/chromium-win/fast/table/append-cells2-expected.png:
  • platform/chromium-win/fast/table/append-cells2-expected.txt:
  • platform/chromium-win/fast/table/remove-td-display-none-expected.checksum:
  • platform/chromium-win/fast/table/remove-td-display-none-expected.png:
  • platform/chromium-win/fast/table/remove-td-display-none-expected.txt:
  • platform/chromium-win/fast/text/international/hindi-spacing-expected.checksum:
  • platform/chromium-win/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win/fast/text/international/hindi-spacing-expected.txt:
  • platform/chromium-win/fast/text/textIteratorNilRenderer-expected.checksum:
  • platform/chromium-win/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-win/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-win/http/tests/navigation/anchor-frames-expected.checksum:
  • platform/chromium-win/http/tests/navigation/anchor-frames-expected.png:
  • platform/chromium-win/http/tests/navigation/anchor-frames-expected.txt:
  • platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.checksum:
  • platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.checksum:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug138725-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug26178-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug33855-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug39209-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4429-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug44505-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug51037-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug51727-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug52505-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug52505-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug52506-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug52506-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug60749-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug68912-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug68912-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug68912-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-4-expected.checksum:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/chromium-win/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-win/tables/mozilla/other/move_row-expected.checksum:
  • platform/chromium-win/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-win/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/chromium/test_expectations.txt:
5:01 AM Changeset in webkit [63195] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed test fix.

Add new DeviceOrientation test to GTK skipped list.

  • platform/gtk/Skipped:
4:53 AM Changeset in webkit [63194] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKitTools

2010-07-13 Andreas Kling <​andreas.kling@nokia.com>

Unreviewed. Adding myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
4:35 AM Changeset in webkit [63193] by steveblock@google.com
  • 15 edits
    7 adds in trunk

2010-07-12 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

DeviceOrientationEvent should use optional properties
​https://bugs.webkit.org/show_bug.cgi?id=41607

This change adds a new DeviceOrientation class which takes care of which of the
optional properties are present. DeviceOrientationEvent owns an instance of
DeviceOrientation, rather than owning the properties directly.
DeviceOrientationEvent now requires custom bindings.

Test: fast/dom/DeviceOrientation/optional-event-properties.html

  • Android.mk:
  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDeviceOrientationEventCustom.cpp: Added. (WebCore::JSDeviceOrientationEvent::alpha): (WebCore::JSDeviceOrientationEvent::beta): (WebCore::JSDeviceOrientationEvent::gamma): (WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):
  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp: Added. (WebCore::V8DeviceOrientationEvent::alphaAccessorGetter): (WebCore::V8DeviceOrientationEvent::betaAccessorGetter): (WebCore::V8DeviceOrientationEvent::gammaAccessorGetter): (WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):
  • dom/DeviceOrientation.cpp: Added.
  • dom/DeviceOrientation.h: Added. (WebCore::DeviceOrientation::create): (WebCore::DeviceOrientation::canProvideAlpha): (WebCore::DeviceOrientation::alpha): (WebCore::DeviceOrientation::canProvideBeta): (WebCore::DeviceOrientation::beta): (WebCore::DeviceOrientation::canProvideGamma): (WebCore::DeviceOrientation::gamma): (WebCore::DeviceOrientation::DeviceOrientation):
  • dom/DeviceOrientationEvent.cpp: (WebCore::DeviceOrientationEvent::DeviceOrientationEvent): (WebCore::DeviceOrientationEvent::initDeviceOrientationEvent):
  • dom/DeviceOrientationEvent.h: (WebCore::DeviceOrientationEvent::create): (WebCore::DeviceOrientationEvent::orientation):
  • dom/DeviceOrientationEvent.idl:

2010-07-12 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

DeviceOrientationEvent should use optional properties
​https://bugs.webkit.org/show_bug.cgi?id=41607

  • fast/dom/DeviceOrientation/optional-event-properties-expected.txt: Added.
  • fast/dom/DeviceOrientation/optional-event-properties.html: Added.
  • fast/dom/DeviceOrientation/script-tests/optional-event-properties.js: Added.
4:05 AM WebKit Team edited by andreas.kling@nokia.com
Moving myself to committers (diff)
4:04 AM Changeset in webkit [63192] by andreas.kling@nokia.com
  • 2 edits
    1 add in trunk/WebCore

2010-07-13 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Antti Koivisto.

CSS3 background: Number of layers should be determined by background-image element count
​https://bugs.webkit.org/show_bug.cgi?id=41201

Change FillLayer culling logic to discard all layers
after the first one without an image set.

Manual test: css3-background-layer-count.html

  • manual-tests/css3-background-layer-count.html: Added.
  • rendering/style/FillLayer.cpp: (WebCore::FillLayer::cullEmptyLayers):
3:47 AM Changeset in webkit [63191] by vestbo@webkit.org
  • 31 edits
    2 adds in trunk

Prevent assertion/duplicate loads for non-deferred subtitute-data loads

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=30879

MainResourceLoader uses the member m_initialRequest to store requests for future
deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
have to clear this request so that subsequent entries into the loader will not
start yet another load.

This can happen as a result of a PageGroupLoadDeferrer going out of scope when
returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
but only in the case of using both substitute-data and non-deferred main resource
load together. That's why two new DRT functions were added:

  • queueLoadHTMLString()
  • setDeferMainResourceLoad()

The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.

3:25 AM Changeset in webkit [63190] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-07-13 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Kent Tamura.

Make sure correct Nodes are passed to childrenChanged so that
:last-child gets properly applied when fragment is inserted.
​https://bugs.webkit.org/show_bug.cgi?id=37944

  • fast/css/last-child-innerhtml-expected.txt: Added.
  • fast/css/last-child-innerhtml.html: Added.

2010-07-13 Yoshiki Hayashi <​yhayashi@google.com>

Reviewed by Kent Tamura.

Make sure correct Nodes are passed to childrenChanged so that
:last-child gets properly applied when fragment is inserted.
​https://bugs.webkit.org/show_bug.cgi?id=37944

Test: fast/css/last-child-innerhtml.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild):
3:11 AM Changeset in webkit [63189] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-07-13 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

InsertListCommand's modifyRange and doApply should be merged
​https://bugs.webkit.org/show_bug.cgi?id=41403

Isolated the code in doApply to insert and remove lists for single paragraph into doApplyForSingleParagraph.
Merged the code in modifyRange into doApply and cleaned up.

No test is added since this is a clean up.

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::InsertListCommand): m_forceCreateList is no longer initialized (WebCore::InsertListCommand::doApply): Isolated the code to insert/remove lists in doApplyForSingleParagraph (WebCore::InsertListCommand::doApplyForSingleParagraph): Insert/remove lists for single paragraph
  • editing/InsertListCommand.h: Added doApplyForSingleParagraph and removed m_forceCreateList
3:05 AM Changeset in webkit [63188] by Philippe Normand
  • 4 edits in trunk/WebKit/mac

2010-07-13 Philippe Normand <​pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

Updated the copyright headers of the files modified in r62476.

  • WebView/WebView.mm:
  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:
3:02 AM Changeset in webkit [63187] by mjs@apple.com
  • 3 edits
    20 adds in trunk/WebKitTools

2010-07-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Nikolas Zimmermann.

Activate test fonts for layout tests in WebKitTestRunner (on Mac)
​https://bugs.webkit.org/show_bug.cgi?id=42153

  • WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::initialize): Activate fonts on startup.
  • WebKitTestRunner/InjectedBundle/mac: Added.
  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added. (WTR::activateFonts): Activate our fonts.
  • WebKitTestRunner/InjectedBundle/win: Added.
  • WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added. (WTR::activateFonts): Dummy version.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle; add more files.
  • WebKitTestRunner/fonts: Added.
  • WebKitTestRunner/fonts/AHEM.TTF: Added.
  • WebKitTestRunner/fonts/ColorBits-A.png: Added.
  • WebKitTestRunner/fonts/ColorBits.ttf: Added.
  • WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added.
  • WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added.
  • WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added.
  • WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added.
  • WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added.
  • WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added.
  • WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added.
  • WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added.
  • WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added.
  • WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added.
  • WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added.
2:49 AM Changeset in webkit [63186] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

Add tests that require layoutTestController.layerTreeAsText to WebKit2 skipped list
​https://bugs.webkit.org/show_bug.cgi?id=42147

Reviewed by Steve Falkenburg.

  • platform/mac-wk2/Skipped:
2:39 AM Changeset in webkit [63185] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Remove extra line added in r63183 "resources/whitespace01.dat: PASS"
from html5lib/runner-expected.txt (which was probably added accidentally),
because no bot produces this output in the tree.

  • html5lib/runner-expected.txt:
1:26 AM Changeset in webkit [63184] by dumi@chromium.org
  • 1 edit
    1 delete in trunk/WebKitTools

Remove check-header-includes, as it didn't turn out to be very useful.
​https://bugs.webkit.org/show_bug.cgi?id=41970

Reviewed by Eric Seidel.

  • Scripts/check-header-includes: Removed.
1:23 AM Changeset in webkit [63183] by eric@webkit.org
  • 5 edits in trunk

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix typo in "close the cell" which caused assertion
​https://bugs.webkit.org/show_bug.cgi?id=42138

  • html5lib/resources/tables01.dat:

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix typo in "close the cell" which caused assertion
​https://bugs.webkit.org/show_bug.cgi?id=42138

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::closeTheCell):
1:11 AM Changeset in webkit [63182] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-13 Kent Tamura <​tkent@chromium.org>

Unreviewed, build fix.

Fix a build error by r63179 for Chromium.

  • tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::itemLabel): Added.
12:01 AM Changeset in webkit [63181] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.
Don't build MiniBrowser except for Debug_Internal.

  • WebKit2.sln:

Jul 12, 2010:

11:53 PM Changeset in webkit [63180] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix line number handling in HTMLTreeBuilder to fix a zillion layout tests
​https://bugs.webkit.org/show_bug.cgi?id=42143

Covered by a zillion layout tests.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processScriptStartTag):
11:41 PM Changeset in webkit [63179] by jcivelli@chromium.org
  • 10 edits in trunk

2010-07-12 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Kent Tamura.

Adding right aligned text called labels to PopupMenus.
​https://bugs.webkit.org/show_bug.cgi?id=41964

  • platform/PopupMenuClient.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemLabel):
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::itemLabel):
  • rendering/RenderTextControlSingleLine.h:

2010-07-12 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Kent Tamura.

Making the autofill popup use labels to show the label
associated with an item.
​https://bugs.webkit.org/show_bug.cgi?id=41964

  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getSuggestion): (WebKit::AutoFillPopupMenuClient::getLabel): (WebKit::AutoFillPopupMenuClient::itemLabel): (WebKit::AutoFillPopupMenuClient::setSuggestions): (WebKit::AutoFillPopupMenuClient::convertListIndexToInternalIndex):
  • src/AutoFillPopupMenuClient.h:
11:32 PM Changeset in webkit [63178] by sfalken@apple.com
  • 4 edits in trunk

2010-07-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Maciej Stachowiak.

Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
​https://bugs.webkit.org/show_bug.cgi?id=40922


Always build WebKit2 on Windows. Necessary since our WebKit build on
Windows is packaged into a DLL with WebKit2.

  • Scripts/build-webkit: Always build WebKit2 on Windows.

2010-07-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Maciej Stachowiak.

Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
​https://bugs.webkit.org/show_bug.cgi?id=40922


Add additional dependent projects. Necessary since our WebKit build on
Windows is packaged into a DLL with WebKit2.

  • WebKit2.sln:
11:24 PM Changeset in webkit [63177] by bweinstein@apple.com
  • 3 edits in trunk/WebKitTools

One http test timing out on Windows can cause all future tests to time out
​https://bugs.webkit.org/show_bug.cgi?id=42146

Reviewed by Steve Falkenburg.

There have been multiple times on the Windows bots where one http test timing out causes all future
http tests to time out. This is because the httpd process becomes unresponsive. When an http test
times out, we should restart httpd on Cygwin to prevent this.

  • Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
  • Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if

using kill fails.

11:21 PM Changeset in webkit [63176] by Martin Robinson
  • 4 edits
    6 adds in trunk

2010-07-12 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[Cairo] Incorrect Test for Text Fill
​https://bugs.webkit.org/show_bug.cgi?id=42123

Unskip tests which cover text stroking and add pixel dump results for
them via the GTK+ port.

  • platform/gtk/Skipped: Unskip passing tests.
  • platform/gtk/fast/text/stroking-decorations-expected.checksum: Added.
  • platform/gtk/fast/text/stroking-decorations-expected.png: Added.
  • platform/gtk/fast/text/stroking-decorations-expected.txt: Added.
  • platform/gtk/fast/text/stroking-expected.checksum: Added.
  • platform/gtk/fast/text/stroking-expected.png: Added.
  • platform/gtk/fast/text/stroking-expected.txt: Added.

2010-07-12 Mihnea Ovidenea <​mihnea@adobe.com>

Reviewed by Dirk Schulze.

[Cairo] Incorrect Test for Text Fill
​https://bugs.webkit.org/show_bug.cgi?id=42123

Correct test used for text shadow. It currently checks for
equality with cTextFill. However, this test fails if the
text drawing mode is set to 'cTextFill | cTextStroke'. Fix
is to modify the test to be like other Cairo uses of the
text drawing mode, and check for the cTextFill bit being
set, not for equality with the bit.

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
11:05 PM Changeset in webkit [63175] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-07-12 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Fix a small error in the Skipped list.

  • platform/gtk/Skipped:
11:01 PM Changeset in webkit [63174] by sfalken@apple.com
  • 1 edit in trunk/WebKit2/Platform/win/WorkQueueWin.cpp

Windows build fix.

10:54 PM Changeset in webkit [63173] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63171.
​http://trac.webkit.org/changeset/63171
​https://bugs.webkit.org/show_bug.cgi?id=42144

Broke Chromium canary (Requested by tkent on #webkit).

  • WebKit.gyp:
10:41 PM Changeset in webkit [63172] by pfeldman@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2010-07-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: rebaseline chromium tests.

  • platform/chromium-win-xp/fast/gradients/radial-centered-expected.checksum: Copied from LayoutTests/platform/chromium-win/fast/gradients/radial-centered-expected.checksum.
  • platform/chromium-win-xp/fast/gradients/radial-centered-expected.png: Copied from LayoutTests/platform/chromium-win/fast/gradients/radial-centered-expected.png.
  • platform/chromium-win-xp/fast/gradients/radial-centered-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/gradients/radial-centered-expected.txt.
  • platform/chromium/test_expectations.txt:
10:37 PM Changeset in webkit [63171] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-12 Kent Tamura <​tkent@chromium.org>

Reviewed by David Levin.

[Chromium] Upstreaming inspector_resources target
​https://bugs.webkit.org/show_bug.cgi?id=41669

'inspector_resource' is currently in src/webkit/webkit.gyp of
Chromium tree. We move it to WebKit tree because:

  • DumpRenderTree in WebKit tree needs it, and
  • It's hard to refer to WebKit.gypi and WebCore.gypi from webkit_support in both cases of Chromium-tree build and WebKit-tree build.
  • WebKit.gyp:
10:30 PM Changeset in webkit [63170] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-07-12 Viet-Trung Luu <​viettrungluu@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Pass key down events on to plugins.
​https://bugs.webkit.org/show_bug.cgi?id=42113

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
10:24 PM Changeset in webkit [63169] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2010-07-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by David Levin.

Add failing animation and canvas tests to WebKit2 Skipped list
​https://bugs.webkit.org/show_bug.cgi?id=42141

  • platform/mac-wk2/Skipped:
10:10 PM Changeset in webkit [63168] by eric@webkit.org
  • 4 edits in trunk

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Sam Weinig.

Fix a typo in the adoption agency causing test failures
​https://bugs.webkit.org/show_bug.cgi?id=42133

  • html5lib/runner-expected-html5.txt:

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Sam Weinig.

Fix a typo in the adoption agency causing test failures
​https://bugs.webkit.org/show_bug.cgi?id=42133

The new behavior actually differs from old webkit.
<p><b><p>TEST
was not bold in the old parser, but is bold now.
This matches Minefield and the HTML5 spec.

Covered by two tests in html5lib/runner.html.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
9:27 PM Changeset in webkit [63167] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Fix WebKit2 to use the same compiler-selection logic as the other projects.

Rubber-stamped by Maciej Stachowiak.

  • WebKit2.xcodeproj/project.pbxproj: Don't hard-code WebKit2 to build with GCC 4.2.
9:04 PM Changeset in webkit [63166] by pfeldman@chromium.org
  • 11 edits in trunk

2010-07-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: provide starts and ends for network phases instead of duration.

​https://bugs.webkit.org/show_bug.cgi?id=42091

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::buildObjectForTiming):
  • platform/network/ResourceLoadTiming.h: (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::wasCached): (WebCore::ResourceResponseBase::setWasCached):
  • platform/network/ResourceResponseBase.h:

2010-07-12 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: provide starts and ends for network phases instead of duration.

​https://bugs.webkit.org/show_bug.cgi?id=42091

  • public/WebURLLoadTiming.h:
  • public/WebURLResponse.h:
  • src/WebURLLoadTiming.cpp: (WebKit::WebURLLoadTiming::proxyStart): (WebKit::WebURLLoadTiming::setProxyStart): (WebKit::WebURLLoadTiming::proxyEnd): (WebKit::WebURLLoadTiming::setProxyEnd): (WebKit::WebURLLoadTiming::dnsStart): (WebKit::WebURLLoadTiming::setDNSStart): (WebKit::WebURLLoadTiming::dnsEnd): (WebKit::WebURLLoadTiming::setDNSEnd): (WebKit::WebURLLoadTiming::connectStart): (WebKit::WebURLLoadTiming::setConnectStart): (WebKit::WebURLLoadTiming::connectEnd): (WebKit::WebURLLoadTiming::setConnectEnd): (WebKit::WebURLLoadTiming::sendStart): (WebKit::WebURLLoadTiming::setSendStart): (WebKit::WebURLLoadTiming::sendEnd): (WebKit::WebURLLoadTiming::setSendEnd): (WebKit::WebURLLoadTiming::receiveHeadersStart): (WebKit::WebURLLoadTiming::setReceiveHeadersStart): (WebKit::WebURLLoadTiming::receiveHeadersEnd): (WebKit::WebURLLoadTiming::setReceiveHeadersEnd): (WebKit::WebURLLoadTiming::sslStart): (WebKit::WebURLLoadTiming::setSSLStart): (WebKit::WebURLLoadTiming::sslEnd): (WebKit::WebURLLoadTiming::setSSLEnd):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasCached): (WebKit::WebURLResponse::setWasCached):
8:41 PM Changeset in webkit [63165] by abarth@webkit.org
  • 5 edits in trunk

2010-07-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 Parser: document.write after onload blows away document
​https://bugs.webkit.org/show_bug.cgi?id=40745

Update test to expect new behavior.

  • http/tests/misc/write-while-waiting.html:

2010-07-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 Parser: document.write after onload blows away document
​https://bugs.webkit.org/show_bug.cgi?id=40745

Rather than blowing away the document when we get a document.write call
after the document is closed, we new ignore the write. This
technically violates the spec (which requires us to blow away the
document), but blowing away the document breaks too many web sites.

Rather than this patch, we could go back to our old behavior (which was
to append the bytes just before EOF), but implementing this approach
(suggested by Henri) will let us gather data about whether his approach
is workable.

See also: ​http://www.w3.org/Bugs/Public/show_bug.cgi?id=9767

  • dom/Document.cpp: (WebCore::Document::write):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::insert):
8:39 PM Changeset in webkit [63164] by mjs@apple.com
  • 3 edits in trunk/WebKitTools

2010-07-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Remove use of auto_ptr in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=42134


Replaced auto_ptr with PassOwnPtr / OwnPtr.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::WKStringToUTF8): (WTR::InjectedBundlePage::dump): (WTR::InjectedBundlePage::addMessageToConsole):
  • WebKitTestRunner/TestInvocation.cpp: (WTR::WKStringToUTF8): (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
8:13 PM Changeset in webkit [63163] by mjs@apple.com
  • 3 edits
    2 adds in trunk

Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
​https://bugs.webkit.org/show_bug.cgi?id=42132

Reviewed by Sam Weinig.

WebKitTools:

  • Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of

platform directories.

LayoutTests:

  • platform/mac-wk2: Added.
  • platform/mac-wk2/Skipped: Added. Initially add the accessibility

directory (with two blocking bugs).

7:57 PM Changeset in webkit [63162] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2010-07-12 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Oliver Hunt.

Strip BOMs from source before passing to V8
​https://bugs.webkit.org/show_bug.cgi?id=42102

This extra copy may carry a performance penalty. We should investigate
whether this allows any simplification in v8/scanner.cc:SkipJavaScriptWhiteSpace().

No new tests because no new functionality.

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
7:45 PM Changeset in webkit [63161] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-07-12 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed. make distcheck fix.

  • GNUmakefile.am:
7:45 PM Changeset in webkit [63160] by commit-queue@webkit.org
  • 8 edits
    8 deletes in trunk/WebKit/chromium

2010-07-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63156.
​http://trac.webkit.org/changeset/63156
​https://bugs.webkit.org/show_bug.cgi?id=42129

broke chromium compile (Requested by jamesr on #webkit).

  • WebKit.gyp:
  • public/WebAccessibilityObject.h:
  • public/WebAttribute.h: Removed.
  • public/WebDocumentType.h: Removed.
  • public/WebElement.h:
  • public/WebNamedNodeMap.h: Removed.
  • public/WebNode.h:
  • public/WebRenderStyle.h: Removed.
  • src/WebAccessibilityObject.cpp:
  • src/WebAttribute.cpp: Removed.
  • src/WebDocumentType.cpp: Removed.
  • src/WebElement.cpp:
  • src/WebNamedNodeMap.cpp: Removed.
  • src/WebNode.cpp:
  • src/WebRenderStyle.cpp: Removed.
7:42 PM Changeset in webkit [63159] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

2010-07-12 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix crash caused by unintentional deletion of worker bridge and channel.

WebSocket: Crash caused by calling close() within onmessage handler
​https://bugs.webkit.org/show_bug.cgi?id=41507

  • websocket/tests/workers/close-in-onmessage-crash-expected.txt: Added.
  • websocket/tests/workers/close-in-onmessage-crash.html: Added.
  • websocket/tests/workers/resources/close-in-onmessage-crash.js: Added. (runTests.try.ws.onopen): (runTests.try.ws.onmessage): Calling close() inside the onmessage handler causes the crash. (runTests.try.ws.onclose): (runTests):

2010-07-12 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix crash caused by unintentional deletion of worker bridge and channel.

WebSocket: Crash caused by calling close() within onmessage handler
​https://bugs.webkit.org/show_bug.cgi?id=41507

Test: websocket/tests/workers/close-in-onmessage-crash.html

  • websockets/WebSocket.cpp: (WebCore::WebSocket::close): bufferedAmount() may call WebSocket::didClose(), which causes m_channel to get freed.
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Bridge::send): Add reference to the bridge because waitForMethodCompletion() may dereference the bridge. (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount): Ditto. (WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion): The root cause is a call to WorkerRunLoop::runInMode in this function. It may call WebSocket::didClose() even inside WebSocket::close(), which frees everything including the worker bridge and the channel.
7:05 PM Changeset in webkit [63158] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-12 Eric Seidel <​eric@webkit.org>

Unreviewed. Just skipping a test on Gtk due to missing DRT features.

REGRESSION (HTML5 parser?): Impossible to get past the CAPTCHA on postcode.royalmail.com
​https://bugs.webkit.org/show_bug.cgi?id=41797

  • platform/gtk/Skipped:
    • Gtk is missing DRT api.
6:58 PM Changeset in webkit [63157] by mjs@apple.com
  • 2 edits in trunk/WebKit2

2010-07-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

WKView should override setFrameSize: instead of setFrame:
​https://bugs.webkit.org/show_bug.cgi?id=42127

  • UIProcess/API/mac/WKView.mm: (-[WKView setFrameSize:]): Override this method instead of setFrame:, since that is the right way to do it.
6:45 PM Changeset in webkit [63156] by commit-queue@webkit.org
  • 8 edits
    8 copies in trunk/WebKit/chromium

2010-07-12 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Darin Fisher.

Add methods to WebAccessibilityObject to access the Node and
Document, and then add methods to access some document, node,
and element properties needed for Windows accessibility.

​https://bugs.webkit.org/show_bug.cgi?id=41569

  • WebKit.gyp:
  • public/WebAccessibilityObject.h:
  • public/WebAttribute.h: Added. (WebKit::WebAttribute::~WebAttribute): (WebKit::WebAttribute::WebAttribute): (WebKit::WebAttribute::operator=):
  • public/WebDocumentType.h: Added. (WebKit::WebDocumentType::WebDocumentType): (WebKit::WebDocumentType::operator=): (WebKit::WebDocumentType::assign):
  • public/WebElement.h:
  • public/WebNamedNodeMap.h: Added. (WebKit::WebNamedNodeMap::~WebNamedNodeMap): (WebKit::WebNamedNodeMap::WebNamedNodeMap): (WebKit::WebNamedNodeMap::operator=):
  • public/WebNode.h:
  • public/WebRenderStyle.h: Added. (WebKit::WebRenderStyle::~WebRenderStyle): (WebKit::WebRenderStyle::WebRenderStyle): (WebKit::WebRenderStyle::operator=):
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::node): (WebKit::WebAccessibilityObject::document):
  • src/WebAttribute.cpp: Added. (WebKit::WebAttribute::reset): (WebKit::WebAttribute::assign): (WebKit::WebAttribute::WebAttribute): (WebKit::WebAttribute::localName): (WebKit::WebAttribute::value):
  • src/WebDocumentType.cpp: Added. (WebKit::WebDocumentType::name): (WebKit::WebDocumentType::WebDocumentType): (WebKit::WebDocumentType::operator=): (WebKit::WebDocumentType::operator PassRefPtr<DocumentType>):
  • src/WebElement.cpp: (WebKit::WebElement::attributes):
  • src/WebNamedNodeMap.cpp: Added. (WebKit::WebNamedNodeMap::reset): (WebKit::WebNamedNodeMap::assign): (WebKit::WebNamedNodeMap::WebNamedNodeMap): (WebKit::WebNamedNodeMap::length): (WebKit::WebNamedNodeMap::attributeItem):
  • src/WebNode.cpp: (WebKit::WebNode::element): (WebKit::WebNode::hasComputedStyle): (WebKit::WebNode::computedStyle):
  • src/WebRenderStyle.cpp: Added. (WebKit::WebRenderStyle::reset): (WebKit::WebRenderStyle::assign): (WebKit::WebRenderStyle::WebRenderStyle): (WebKit::WebRenderStyle::display):
6:36 PM Changeset in webkit [63155] by mjs@apple.com
  • 6 edits in trunk/WebKitTools

2010-07-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

Make WebKitTestRunner resize the view specially for the W3C SVG tests.
​https://bugs.webkit.org/show_bug.cgi?id=42126

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::TestInvocation): Store the path as a C string for later use. (WTR::TestInvocation::~TestInvocation): (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper size, depending on whether this is a W3C SVG test. (WTR::TestInvocation::invoke): Call the size function.
  • WebKitTestRunner/TestInvocation.h:
  • WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::resizeTo): Implement.
  • WebKitTestRunner/win/PlatformWebViewWin.cpp: (WTR::PlatformWebView::resizeTo): Placeholder.
6:28 PM Changeset in webkit [63154] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-07-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (HTML5 parser?): Impossible to get past the CAPTCHA on postcode.royalmail.com
​https://bugs.webkit.org/show_bug.cgi?id=41797

This test is a bit subtle, but it captures a reduction of what I think
is going on with the site.

Essentially, the real parser doesn't see the <img> tag, but the preload
scanner does. Prior to this patch, we were preload scanning this
region of the document even though we weren't supposed to.

  • http/tests/loading/preload-slow-loading-expected.txt: Added.
  • http/tests/loading/preload-slow-loading.php: Added.

2010-07-12 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (HTML5 parser?): Impossible to get past the CAPTCHA on postcode.royalmail.com
​https://bugs.webkit.org/show_bug.cgi?id=41797

Once we resume parsing after script execution, we want to clear the
preload scanner so we don't scan any bytes it might have accumulated.

Test: http/tests/loading/preload-slow-loading.php

  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
6:15 PM Changeset in webkit [63153] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

Reviewed by Jian Li.

Adding directional property enums back into
CSSComputedStyleDeclaration::getPropertyCSSValue().

​https://bugs.webkit.org/show_bug.cgi?id=42122

The four directional -webkit- properties -- CSSPropertyWebkitMarginEnd,
CSSPropertyWebkitMarginStart, CSSPropertyWebkitPaddingEnd, and
CSSPropertyWebkitPaddingStart -- are resolved into other css
properties before the swtich statement via a call to
CSSProperty::resolveDirectionAwareProperty(). Thus, they are never
seen by the switch statement. However, if you leave out a potential
enum value from the switch, gcc will generate a warning if -Wall is
specified. This warning breaks the Chromium build. To avoid this,
we add in the enum values and ASSERT_NOT_REACHED() if they are hit.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

5:58 PM Changeset in webkit [63152] by mrowe@apple.com
  • 5 edits
    11 adds in branches/safari-533.17-branch

Merge r63149.

5:54 PM Changeset in webkit [63151] by sfalken@apple.com
  • 10 edits
    26 moves
    1 add
    5 deletes in trunk

WebKit/win: <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL
​https://bugs.webkit.org/show_bug.cgi?id=40921

Reviewed by Alice Liu.

Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.

This is a first step. We'll likely want to migrate the remainder of
the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.

  • WebKit.vcproj/WebKit.def: Removed.
  • WebKit.vcproj/WebKit.make: Don't fail if WebKit doesn't produce a DLL.
  • WebKit.vcproj/WebKit.vcproj: Build WebKit as a static lib.

Renamed project name to WebKitLib to avoid confusion and naming conflicts.
Generate intermediate pdb file for debuggability of static lib.
Removed DLL-related options.

  • WebKit.vcproj/deleteButton.png: Removed.
  • WebKit.vcproj/deleteButtonPressed.png: Removed.
  • WebKit.vcproj/fsVideoAudioVolumeHigh.png: Removed.
  • WebKit.vcproj/fsVideoAudioVolumeLow.png: Removed.
  • WebKit.vcproj/fsVideoExitFullscreen.png: Removed.
  • WebKit.vcproj/fsVideoPause.png: Removed.
  • WebKit.vcproj/fsVideoPlay.png: Removed.
  • WebKit.vcproj/missingImage.png: Removed.
  • WebKit.vcproj/nullplugin.png: Removed.
  • WebKit.vcproj/panEastCursor.png: Removed.
  • WebKit.vcproj/panIcon.png: Removed.
  • WebKit.vcproj/panNorthCursor.png: Removed.
  • WebKit.vcproj/panNorthEastCursor.png: Removed.
  • WebKit.vcproj/panNorthWestCursor.png: Removed.
  • WebKit.vcproj/panSouthCursor.png: Removed.
  • WebKit.vcproj/panSouthEastCursor.png: Removed.
  • WebKit.vcproj/panSouthWestCursor.png: Removed.
  • WebKit.vcproj/panWestCursor.png: Removed.
  • WebKit.vcproj/searchCancel.png: Removed.
  • WebKit.vcproj/searchCancelPressed.png: Removed.
  • WebKit.vcproj/searchMagnifier.png: Removed.
  • WebKit.vcproj/searchMagnifierResults.png: Removed.
  • WebKit.vcproj/textAreaResizeCorner.png: Removed.
  • WebKit.vcproj/verticalTextCursor.png: Removed.
  • WebKit.vcproj/zoomInCursor.png: Removed.
  • WebKit.vcproj/zoomOutCursor.png: Removed.

WebKit2: <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL
​https://bugs.webkit.org/show_bug.cgi?id=40921

Reviewed by Alice Liu.

Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.

This is a first step. We'll likely want to migrate the remainder of
the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.

  • UIProcess/API/C/WKBase.h: Updated to new BUILDING_ name.
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h: Updated to new BUILDING_ name.
  • WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp: Removed.
  • WebProcess/win/DllMain.cpp: Removed. Overlaps with implementation in WebKitLib.lib.
  • WebProcess/win/WebLocalizableStrings.cpp: Removed. Overlaps with implementation in WebKitLib.lib.
  • WebProcess/win/WebLocalizableStrings.h: Removed. Overlaps with implementation in WebKitLib.lib.
  • win/WebKit2.def: Added. Copied from WebKit project.
  • win/WebKit2.rc: Added resources previously in WebKit.
  • win/WebKit2.vcproj: Changed project name to WebKit so we will link output to WebKit.dll.

Removed implementations overlapping with WebKitLib (WebCoreLocalizedStrings, DllMain, WebLocalizableStrings, WebProcessMain).

  • win/WebKit2Common.vsprops: Use a framework name of WebKit instead of WebKit2 to reflect project name.

Renamed BUILDING_WEBKIT2 to BUILDING_WEBKIT since there is now just a single WebKit.dll.

  • win/WebKit2WebProcess.vcproj: Link against WebKit instead of WebKit2 due to renaming.
  • win/deleteButton.png: Copied from ../WebKit/win/WebKit.vcproj/deleteButton.png.
  • win/deleteButtonPressed.png: Copied from ../WebKit/win/WebKit.vcproj/deleteButtonPressed.png.
  • win/fsVideoAudioVolumeHigh.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoAudioVolumeHigh.png.
  • win/fsVideoAudioVolumeLow.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoAudioVolumeLow.png.
  • win/fsVideoExitFullscreen.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoExitFullscreen.png.
  • win/fsVideoPause.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoPause.png.
  • win/fsVideoPlay.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoPlay.png.
  • win/missingImage.png: Copied from ../WebKit/win/WebKit.vcproj/missingImage.png.
  • win/nullplugin.png: Copied from ../WebKit/win/WebKit.vcproj/nullplugin.png.
  • win/panEastCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panEastCursor.png.
  • win/panIcon.png: Copied from ../WebKit/win/WebKit.vcproj/panIcon.png.
  • win/panNorthCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panNorthCursor.png.
  • win/panNorthEastCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panNorthEastCursor.png.
  • win/panNorthWestCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panNorthWestCursor.png.
  • win/panSouthCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panSouthCursor.png.
  • win/panSouthEastCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panSouthEastCursor.png.
  • win/panSouthWestCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panSouthWestCursor.png.
  • win/panWestCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panWestCursor.png.
  • win/searchCancel.png: Copied from ../WebKit/win/WebKit.vcproj/searchCancel.png.
  • win/searchCancelPressed.png: Copied from ../WebKit/win/WebKit.vcproj/searchCancelPressed.png.
  • win/searchMagnifier.png: Copied from ../WebKit/win/WebKit.vcproj/searchMagnifier.png.
  • win/searchMagnifierResults.png: Copied from ../WebKit/win/WebKit.vcproj/searchMagnifierResults.png.
  • win/textAreaResizeCorner.png: Copied from ../WebKit/win/WebKit.vcproj/textAreaResizeCorner.png.
  • win/verticalTextCursor.png: Copied from ../WebKit/win/WebKit.vcproj/verticalTextCursor.png.
  • win/zoomInCursor.png: Copied from ../WebKit/win/WebKit.vcproj/zoomInCursor.png.
  • win/zoomOutCursor.png: Copied from ../WebKit/win/WebKit.vcproj/zoomOutCursor.png.
5:53 PM Changeset in webkit [63150] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.17-branch

Merge r63112.

5:40 PM Changeset in webkit [63149] by Simon Fraser
  • 5 edits
    10 adds in trunk

2010-07-12 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Don't go into compositing mode for 0x0 plugins
​https://bugs.webkit.org/show_bug.cgi?id=34009

Don't use compositing for small (0-height or width, or 1x1) plugins, or iframes whose
height or width is zero.

Previously we made all compositing decisions inside styleChanged(). However,
now that plugin and iframe compositing behavior depends on renderer size, we have
to wait until layout before deciding whether to composite these. This behavior
change is controlled by the m_compositingDependsOnGeometry flag. When set,
updateCompositingLayers() always does a hierarchy update.

Tests: compositing/iframes/iframe-size-from-zero.html

compositing/iframes/iframe-size-to-zero.html
compositing/plugins/1x1-composited-plugin.html
compositing/plugins/large-to-small-composited-plugin.html
compositing/plugins/small-to-large-composited-plugin.html

  • page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers): No longer bail if usesCompositing() is false; we have to always enter updateCompositingLayers(). (WebCore::FrameView::repaintFixedElementsAfterScrolling): Ditto (WebCore::FrameView::enterCompositingMode): Remove bogus return of a void.
  • rendering/RenderLayerCompositor.h: Add m_compositingDependsOnGeometry.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): Initialize m_compositingDependsOnGeometry to false. (WebCore::RenderLayerCompositor::updateCompositingLayers): If m_compositingDependsOnGeometry is true, we always need to run through the layer hierarchy looking for things which need to be composited, even if we're not (yet) in compositing mode.

(WebCore::RenderLayerCompositor::computeCompositingRequirements): Because we can enter compositing mode
on the fly inside updateCompositingLayers() now, the state of willBeComposited needs to be updated
when processing the root layer, for the case where the compositing mode changes.

(WebCore::RenderLayerCompositor::requiresCompositingForPlugin): Set the m_compositingDependsOnGeometry
flag if we see a potentially-composited plugin. Once we have layout information, only composite the plugin
if height * width > 1.

(WebCore::RenderLayerCompositor::requiresCompositingForIFrame): Set the m_compositingDependsOnGeometry
flag if we see a potentially-composited iframe. Once we have layout information, only composite the plugin
if height or width is greater than zero.

5:37 PM Changeset in webkit [63148] by mjs@apple.com
  • 16 edits in trunk/WebKit2

2010-07-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

Get rid of auto_ptr use in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42119


Replace all use of auto_ptr with OwnPtr/PassOwnPtr.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendMessage): (CoreIPC::Connection::waitForMessage): (CoreIPC::Connection::sendSyncMessage): (CoreIPC::Connection::processIncomingMessage): (CoreIPC::Connection::sendOutgoingMessages): (CoreIPC::Connection::dispatchMessages):
  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Message::Message): (CoreIPC::Connection::send): (CoreIPC::Connection::sendSync): (CoreIPC::Connection::waitFor):
  • Platform/CoreIPC/mac/ConnectionMac.cpp: (CoreIPC::Connection::sendOutgoingMessage): (CoreIPC::createArgumentDecoder): (CoreIPC::Connection::receiveSourceEventHandler):
  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::readyReadHandler): (CoreIPC::Connection::sendOutgoingMessage):
  • Platform/CoreIPC/win/ConnectionWin.cpp: (CoreIPC::Connection::readEventHandler): (CoreIPC::Connection::sendOutgoingMessage):
  • Platform/RunLoop.cpp: (RunLoop::performWork): (RunLoop::scheduleWork):
  • Platform/RunLoop.h:
  • Platform/WorkItem.h: (WorkItem::create):
  • Platform/WorkQueue.h:
  • Platform/mac/WorkQueueMac.cpp: (WorkQueue::executeWorkItem): (WorkQueue::scheduleWork): (WorkQueue::EventSource::EventSource): (WorkQueue::registerMachPortEventHandler):
  • Platform/qt/WorkQueueQt.cpp: (WorkQueue::connectSignal): (WorkQueue::scheduleWork):
  • Platform/win/WorkQueueWin.cpp: (WorkQueue::registerHandle): (WorkQueue::scheduleWork): (WorkQueue::performWork):
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::paint):
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::sendMessage): (WebKit::WebProcessProxy::didFinishLaunching):
  • UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::send):
5:37 PM Changeset in webkit [63147] by ajwong@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed, build fix.

[chromium] rebaseline new test expectations.

  • platform/chromium-mac/media/video-source-expected.txt:
  • platform/chromium-mac/media/video-src-expected.txt:
  • platform/chromium-win/media/video-source-expected.txt:
  • platform/chromium-win/media/video-src-expected.txt:
5:29 PM Changeset in webkit [63146] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r62302.

5:22 PM Changeset in webkit [63145] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r62271.

5:18 PM Changeset in webkit [63144] by mrowe@apple.com
  • 3 edits
    3 moves in branches/safari-533.17-branch

Merge r62304.

5:14 PM Changeset in webkit [63143] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/JavaScriptCore

Merge r62464.

5:14 PM Changeset in webkit [63142] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Merge r62456.

5:14 PM Changeset in webkit [63141] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/LayoutTests

Merge r62433.

5:14 PM Changeset in webkit [63140] by mrowe@apple.com
  • 6 edits
    3 adds in branches/safari-533.17-branch

Merge r62432.

4:53 PM Changeset in webkit [63139] by Chris Fleizach
  • 2 edits in trunk/WebCore

AX converts AtomicStrings to .string() more than needed
​https://bugs.webkit.org/show_bug.cgi?id=42056

4:38 PM Changeset in webkit [63138] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-07-12 Tony Chang <​tony@chromium.org>

Reviewed by David Hyatt.

crash in FrameView::detachCustomScrollbars
​https://bugs.webkit.org/show_bug.cgi?id=41196

  • scrollbars/hidden-iframe-scrollbar-crash-expected.txt: Added.
  • scrollbars/hidden-iframe-scrollbar-crash.html: Added.

2010-07-12 Tony Chang <​tony@chromium.org>

Reviewed by David Hyatt.

crash in FrameView::detachCustomScrollbars
​https://bugs.webkit.org/show_bug.cgi?id=41196

Test: scrollbars/hidden-iframe-scrollbar-crash.html

  • page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars):
4:20 PM Changeset in webkit [63137] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Versioning.

4:19 PM Changeset in webkit [63136] by mrowe@apple.com
  • 1 copy in tags/Safari-533.17.4

New tag.

4:16 PM Changeset in webkit [63135] by eric@webkit.org
  • 6 edits in trunk

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTML tags should break out of foreign content
​https://bugs.webkit.org/show_bug.cgi?id=42106

  • html5lib/runner-expected-html5.txt:

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTML tags should break out of foreign content
​https://bugs.webkit.org/show_bug.cgi?id=42106

Implement another paragraph of the spec to pass another
bunch of foreign content tests.

This fixes a bunch of tests in html5lib/runner.html.
After this change we only have 4 remaining foreign content failures.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
4:13 PM Changeset in webkit [63134] by zmo@google.com
  • 7 edits in trunk

2010-07-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Bring bufferData and clear to GLES2 compliant
​https://bugs.webkit.org/show_bug.cgi?id=41574

  • fast/canvas/webgl/invalidPassedParams-expected.txt: Add wrong param test cases for bufferData and clear.
  • fast/canvas/webgl/invalidPassedParams.html: Ditto.
  • fast/canvas/webgl/resources/desktop-gl-constants.js: Add ACCUM_BUFFER_BIT enum.

2010-07-12 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Fisher.

Bring bufferData and clear to GLES2 compliant
​https://bugs.webkit.org/show_bug.cgi?id=41574

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bufferData): Call validateBufferDataUsage(). (WebCore::WebGLRenderingContext::clear): Check mask. (WebCore::WebGLRenderingContext::validateBufferDataUsage): Check usage.
  • html/canvas/WebGLRenderingContext.h: Declare validateBufferDataUsage.
3:51 PM Changeset in webkit [63133] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-12 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

Ensure DRT loads GAIL (Gtk+ module), for a11y tests
​https://bugs.webkit.org/show_bug.cgi?id=38648

Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port

  • Scripts/old-run-webkit-tests:
3:37 PM Changeset in webkit [63132] by adachan@apple.com
  • 2 edits in trunk/WebKit2

Build fix. Copy WKArray.h to the include directory.

  • win/WebKit2Generated.make:
3:24 PM Changeset in webkit [63131] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-12 Eric Seidel <​eric@webkit.org>

Unreviewed. Attempt to fix Chromium Windows build.

Always generate SVGNames and MathMLNames for all ports (to support HTML5)
​https://bugs.webkit.org/show_bug.cgi?id=42050

Another way to fix this might be to mark all the .in files with
svn:eol=native. But fixing the perl to be more robust against
stray whitespace seems to be a better long-term fix.

No functional change, thus no tests.

  • bindings/scripts/InFilesParser.pm:
3:22 PM Changeset in webkit [63130] by Martin Robinson
  • 6 edits
    1 copy in trunk/WebKitTools

2010-07-12 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[GTK] Support pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=31518

Finish support for pixel tests on GTK+.

  • DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only works on CoreFoundation systems) and add missing cstdio include.
  • DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found in JSC library. MD5.cpp and MD5.h are only available for the Windows build. (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported by the ANSI standard and this fails on Linux, so unroll the loop here.
  • DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior. (BitmapContext::BitmapContext): There is no reason to check the value of the m_context member in the constructor and it certainly should not be freed. Instead just initialize it with the incoming value.
  • DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes. (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to dump pixels.
  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added. (createBitmapContextFromWebView):
  • GNUmakefile.am: Add new files to the build.
3:12 PM Changeset in webkit [63129] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Re-do an Xcode project change that Xcode decided not to save.

  • WebKit2.xcodeproj/project.pbxproj: Remove WebKit2.exp from the project.

For some reason it was being copied in to the framework wrapper.

3:07 PM Changeset in webkit [63128] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-07-12 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] r63100 broke the testwebview test
​https://bugs.webkit.org/show_bug.cgi?id=42114

  • tests/testwebview.c: Disable a failing assertion in test_webkit_web_view_adjustments until we can get to the bottom of the failure.
3:06 PM Changeset in webkit [63127] by crogers@google.com
  • 11 edits in branches/audio/WebCore

Allow AudioContext to operate without need for <xaudio>

  • created constructor for AudioContext
  • AudioContext signs up for notifications from Document to stop playing when document goes away
  • CachedAudio now can deal directly with AudioContext
  • still need to remove the now obsolete <xaudio> files
3:01 PM Changeset in webkit [63126] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-07-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Remove dependency on PlatformString.h in Color.h
​https://bugs.webkit.org/show_bug.cgi?id=42109

  • platform/graphics/Color.cpp:
  • platform/graphics/Color.h:
2:58 PM Changeset in webkit [63125] by mrowe@apple.com
  • 5 edits
    1 delete in trunk/WebKit2

Remove the exports file from WebKit2.

Reviewed by Sam Weinig.

  • Configurations/Base.xcconfig: Have symbols default to hidden visibility.
  • Configurations/WebKit2.xcconfig: Remove the export file.
  • UIProcess/API/mac/WKView.h: Export the WKView class.
  • WebProcess/WebKitMain.cpp: Export the WebKitMain function.
  • mac/WebKit2.exp: Removed.
2:58 PM Changeset in webkit [63124] by mrowe@apple.com
  • 4 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.

Rubber-stamped by Sam Weinig.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
2:45 PM Changeset in webkit [63123] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-12 Eric Seidel <​eric@webkit.org>

Unreviewed, build fix.

Update HTMLTreeBuilder now that MathMLNames is always generated
​https://bugs.webkit.org/show_bug.cgi?id=42059

Fix the Windows project file to build MathMLNames.*.
Also added MathMLElementFactory.* which is a NOOP now, but will
prevent folks from breaking the build when they turn MathML on.

  • WebCore.vcproj/WebCore.vcproj:
2:38 PM Changeset in webkit [63122] by ap@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401

​https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown

Enable xmlhttprequest/failed-auth.html on Windows. It now passes on my machine.

  • platform/win/Skipped: Also removed two userscript tests that don't exist (run-webkit-tests loudly complained about those).
2:33 PM Changeset in webkit [63121] by sfalken@apple.com
  • 1 edit in trunk/WebKit2/win/WebKit2.vcproj

Windows build fix.

2:32 PM Changeset in webkit [63120] by Darin Adler
  • 15 edits in trunk

2010-07-09 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

String to number coercion is not spec compliant
​https://bugs.webkit.org/show_bug.cgi?id=31349

ToNumber should ignore NBSP (\u00a0)
​https://bugs.webkit.org/show_bug.cgi?id=25490

  • runtime/JSGlobalObjectFunctions.cpp: (JSC::parseIntOverflow): Added a version that works on UChar.
  • runtime/JSGlobalObjectFunctions.h: Ditto.
  • runtime/UString.cpp: (JSC::isInfinity): Added helper functions. (JSC::UString::toDouble): Use isStrWhiteSpace instead of isSASCIISpace to define what we should skip. Got rid of the code that used CString and UTF8String, instead processing the UChar of the string directly, except for when we call strtod. For strtod, use our own home-grown conversion function that does not try to do any UTF-16 processing. Tidied up the logic a bit as well.

2010-07-09 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

String to number coercion is not spec compliant
​https://bugs.webkit.org/show_bug.cgi?id=31349

  • fast/js/ToNumber-expected.txt: Updated to expect more tests to pass.
  • fast/js/parseFloat-expected.txt: Ditto.
  • fast/js/sputnik/Conformance/09_Type_Conversion/9.3_ToNumber/9.3.1_ToNumber_from_String/S9.3.1_A2-expected.txt: Ditto.
  • fast/js/sputnik/Conformance/09_Type_Conversion/9.3_ToNumber/9.3.1_ToNumber_from_String/S9.3.1_A3_T1-expected.txt: Ditto.
  • fast/js/sputnik/Conformance/09_Type_Conversion/9.3_ToNumber/9.3.1_ToNumber_from_String/S9.3.1_A3_T2-expected.txt: Ditto.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T10-expected.txt: Ditto.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T3-expected.txt: Ditto.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T8-expected.txt: Ditto.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T9-expected.txt: Ditto.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A6-expected.txt: Ditto.
2:26 PM Changeset in webkit [63119] by eric.carlson@apple.com
  • 20 edits
    2 deletes in trunk

2010-07-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

Update media element's handling of empty 'src' attribute
​https://bugs.webkit.org/show_bug.cgi?id=42001

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::src): Return getNonEmptyURLAttribute(). (WebCore::HTMLMediaElement::selectMediaResource): Call noneSupported() for empty 'src'. (WebCore::HTMLMediaElement::selectNextSourceChild): Use getNonEmptyURLAttribute() to convert 'src' to URL instead of document()->completeURL(). Don't consider a <source> with an empty 'src'.
  • html/HTMLMediaElement.idl: Add 'NonEmpty' option to 'src' attribute.
  • html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::src): Return getNonEmptyURLAttribute(). (WebCore::HTMLSourceElement::isURLAttribute): New, 'src' is a URL attribute.
  • html/HTMLSourceElement.h:
  • html/HTMLSourceElement.idl: Add 'NonEmpty' option to 'src' attribute.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Use getNonEmptyURLAttribute() to convert 'poster' to URL instead of document()->completeURL().
  • html/HTMLVideoElement.idl: Add 'NonEmpty' option to 'poster' attribute.

2010-07-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by NOBODY (OOPS!).

Update media element's handling of empty 'src' attribute
​https://bugs.webkit.org/show_bug.cgi?id=42001

  • fast/dom/URL-attribute-reflection-expected.txt: Update results now that audio, video, and source return 'non-empty URL'.
  • media/video-poster-expected.txt:
  • media/video-poster.html: Test empty poster url.
  • media/video-source-error-no-candidate-expected.txt:
  • media/video-source-error-no-candidate.html: Empty 'src' should fires an error event.
  • media/video-source-expected.txt:
  • media/video-source.html: Test <source> element's 'src' attribute and property as well as currentSrc.
  • media/video-src-empty-expected.txt: Removed.
  • media/video-src-empty.html: Removed, the test is no longer valid.
  • media/video-src-none-expected.txt:
  • media/video-src-none.html: Updated to test empty 'src'. Add tests to ensure that an error is fired when load() is called and the 'src' is empty, but not when 'src' is missing.
  • media/video-src.html:
  • media/video-src-expected.txt: Test 'src' attribute and property as well as currentSrc.
2:24 PM Changeset in webkit [63118] by Martin Robinson
  • 4 edits in trunk

2010-07-12 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] make dist is broken because of missing headers and other miscellaneous reasons
​https://bugs.webkit.org/show_bug.cgi?id=42107

  • GNUmakefile.am: Add missing header to the sources list.

2010-07-12 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] make dist is broken because of missing headers and other miscellaneous reasons
​https://bugs.webkit.org/show_bug.cgi?id=42107

  • GNUmakefile.am: Remove InspectorFrontend2.idl from the list of IDL files, so that it is not built into libWebCoreJS. Add missing header to the source list. Make sure to distribute the new file: WebCore/inspector/CodeGeneratorInspector.pm.
2:20 PM Changeset in webkit [63117] by xan@webkit.org
  • 4 edits in trunk

2010-07-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump to 1.3.3

  • configure.ac:

WebKit/gtk:

2010-07-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.3.3

  • NEWS:
2:13 PM Changeset in webkit [63116] by eric@webkit.org
  • 6 edits in trunk

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs to support mixing SVG and MathML content
​https://bugs.webkit.org/show_bug.cgi?id=42096

  • html5lib/runner-expected-html5.txt:

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs to support mixing SVG and MathML content
​https://bugs.webkit.org/show_bug.cgi?id=42096

This is just a direct transcription of another paragraph of the
HTML5 spec.

This improved a couple results in html5lib/runner.html, but more
work to do yet to pass all the foreign content tests.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processUsingSecondaryInsertionModeAndAdjustInsertionMode):
  • html/HTMLTreeBuilder.h:
  • mathml/mathtags.in:
2:09 PM Changeset in webkit [63115] by eric@webkit.org
  • 5 edits in trunk

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Update HTMLTreeBuilder now that MathMLNames is always generated
​https://bugs.webkit.org/show_bug.cgi?id=42059

We pass a bunch more tests now that our MathML code path is enabled.

  • html5lib/runner-expected-html5.txt:

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Update HTMLTreeBuilder now that MathMLNames is always generated
​https://bugs.webkit.org/show_bug.cgi?id=42059

Fix the HTMLTreeBuilder MathML code path to compile and remove
the MathML and SVG guards now that SVGNames and MathMLNames are
always compiled into ever port after:
​https://bugs.webkit.org/show_bug.cgi?id=42050

This fixed a whole bunch of libhtml5 tests now that we have the
mathml code paths enabled.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTag):
  • page/Frame.cpp: (WebCore::Frame::Frame):
    • Always init SVGNames and MathML names.
2:06 PM Changeset in webkit [63114] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-12 Adam Barth <​abarth@webkit.org>

Unreviewed.

Remove stray "raise e" that got included in a previous patch. This
caused the EWS bots to turn red instead of purple when a patch failed
to apply.

  • Scripts/webkitpy/tool/commands/stepsequence.py:
2:06 PM Changeset in webkit [63113] by sfalken@apple.com
  • 1 edit in trunk/WebKit2/win/WebKit2.vcproj

Windows build fix

2:02 PM Changeset in webkit [63112] by Simon Fraser
  • 3 edits
    3 adds in trunk

2010-07-12 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Need to do a layout when RenderLayers come and go because of compositing
​https://bugs.webkit.org/show_bug.cgi?id=42108

If we create or destroy RenderLayers for reasons other than style changes
(e.g. because of composited iframes or plugins), then we need to ensure
that we do a layout.

Test: compositing/iframes/layout-on-compositing-change.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::adjustStyleDifference):
1:53 PM Changeset in webkit [63111] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-07-11 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

Always generate SVGNames and MathMLNames for all ports (to support HTML5)
​https://bugs.webkit.org/show_bug.cgi?id=42050

Historically, FOONames has only been generate when ENABLE(FOO) is defined.
However, for HTML5 parser support, we need to have access to the SVG
and MathML tag names regardless of whether we the engine is configured
to render SVG or MathML content.

This change enables generation of SVGNames and MathMLNames on all ports and
makes it so that ports can include FOOElementFactory.* regardless of whether
ENABLE(FOO) is defined (and have it do the right thing).

No functional change (yet) so no tests.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pri:
  • dom/make_names.pl:
1:53 PM Changeset in webkit [63110] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63101.
​http://trac.webkit.org/changeset/63101
​https://bugs.webkit.org/show_bug.cgi?id=42103

Broke one API test (Requested by xan_ on #webkit).

  • Scripts/old-run-webkit-tests:
1:50 PM Changeset in webkit [63109] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

make_names.pl should always generate all names in Names.* files
​https://bugs.webkit.org/show_bug.cgi?id=42023

Only the *ElementFactory files need to have conditional contents
based on enabled features. WebCore should always have all known
names for SVG, MathML, XML, XLink, HTML, etc. generated in the
various *Names files, even if features are disabled.

make_names.pl is kinda a big hack at this point. I tried to clean
up a little as I went. The way I made *Names include all names was to
read the .in files twice, once using the preprocessor and once without.

  • dom/make_names.pl:
1:39 PM Changeset in webkit [63108] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401

​https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown

Fix crashes in Windows DumpRenderTree.

  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge() again on a destroyed sender.
1:33 PM Changeset in webkit [63107] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows failure-to-launch fix

  • DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and

CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
we already do for CoreFoundation, CFNetwork, etc.

1:18 PM Changeset in webkit [63106] by ajwong@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed, build fix

[chromium] update test_expectations, and rebaseline a changed svg test.

  • platform/chromium-win/fast/gradients/radial-centered-expected.checksum:
  • platform/chromium-win/fast/gradients/radial-centered-expected.png:
  • platform/chromium-win/fast/gradients/radial-centered-expected.txt:
  • platform/chromium/test_expectations.txt:
1:09 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
1:05 PM Changeset in webkit [63105] by ap@apple.com
  • 2 edits
    1 copy in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401

​https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown

The fix doesn't help Tiger, update results of one test and skip another.

  • platform/mac-tiger/Skipped: Skip 401-alternative-content.php.
  • platform/mac-tiger/http/tests/xmlhttprequest/failed-auth-expected.txt: Copied from http/tests/xmlhttprequest/failed-auth-expected.txt, updated for failure result in async case.
12:22 PM Changeset in webkit [63104] by Adam Roben
  • 2 edits
    4 adds in trunk/WebKit2

Move WebKit2.vcproj's settings into .vsprops files

This makes it easier to make changes that affect all configurations.

Fixes <​http://webkit.org/b/42097> WebKit2 should use .vsprops files

Reviewed by Steve Falkenburg.

  • win/WebKit2.vcproj: Moved settings from here to the files below.
  • win/WebKit2Apple.vsprops: Added. Links against Apple-specific

libraries.

  • win/WebKit2CFLite.vsprops: Added. Links against CFLite.
  • win/WebKit2Common.vsprops: Added. Contains settings shared by all

configurations.

  • win/WebKit2DirectX.vsprops: Added. Contains settings to help with

linking against DirectX.

12:21 PM Changeset in webkit [63103] by Adam Roben
  • 6 edits in trunk

Stop generating stripped symbols for Release builds

It turns out we can strip the symbols after-the-fact using PDBCopy.

Fixes <​http://webkit.org/b/42085>.

Reviewed by Steve Falkenburg.

JavaScriptCore:

Removed the pre-link event, which just created the public\sym
directory.

WebKit2:

  • win/WebKit2.vcproj: Removed the no-longer-needed Release override of

the StripPrivateSymbols attribute. (This attribute is no longer set in
release.vsprops, so doesn't need to be overridden.)

WebKitLibraries:

  • win/tools/vsprops/release.vsprops: Removed the StripPrivateSymbols

attribute, which caused link.exe to generate a stripped PDB file for
each project.

11:34 AM Changeset in webkit [63102] by commit-queue@webkit.org
  • 6 edits in trunk/WebCore

2010-07-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

Canvas: Move fillRect() save/restore into GraphicsContext implementations
​https://bugs.webkit.org/show_bug.cgi?id=42088

Saving the platform painter state is an expensive operation,
so don't do it in fillRect() for platforms that don't need it. (CG, Qt)

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fillRect):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillRect):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillRect):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::fillRect):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::fillRect):
11:18 AM Changeset in webkit [63101] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-12 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

Ensure DRT loads GAIL (Gtk+ module), for a11y tests
​https://bugs.webkit.org/show_bug.cgi?id=38648

Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port

  • Scripts/old-run-webkit-tests:
11:14 AM Changeset in webkit [63100] by Nate Chapin
  • 4 edits
    3 adds in trunk

2010-07-12 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

Ensure that a cache policy that forces validation is cleared once
the load event is fired, rather than only doing so at the next
navigation. This leads to a lot of unnecessary load on AJAX-y
websites.

​https://bugs.webkit.org/show_bug.cgi?id=41813

Test: http/tests/xmlhttprequest/cache-headers-after-reload.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::handledOnloadEvents): Reset m_loadType to FrameLoadTypeStandard. (WebCore::FrameLoader::addExtraFieldsToRequest): Only respect the original request's cache policy if the

DocumentLoader is still loading, and handle the other cache policy settings that were scattered around the loader.

(WebCore::FrameLoader::loadResourceSynchronously): Merge cachePolicy setting into FrameLoader::addExtraFieldsToRequest.

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Merge cachePolicy setting into FrameLoader::addExtraFieldsToRequest.
11:00 AM Changeset in webkit [63099] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-07-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

CSS color parsing optimizations
​https://bugs.webkit.org/show_bug.cgi?id=42073

  • Avoid instantiating a CSSParser in parseColor() unless necessary.
  • Fixed hex color fast-path to support strings starting with '#'.
  • Avoid allocating a new string for the value part of a '#' color.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor):
  • platform/graphics/Color.cpp: (WebCore::Color::parseHexColor): (WebCore::Color::Color):
  • platform/graphics/Color.h:
10:49 AM WikiStart edited by me@elv1s.ru
Link to HackingWebInspector added. (diff)
10:42 AM Changeset in webkit [63098] by xan@webkit.org
  • 2 edits in trunk

2010-07-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Suffix .mo files with the GTK+ API version so that they can be
parallel installable.

  • configure.ac:
10:33 AM HackingWebInspector edited by me@elv1s.ru
(diff)
10:31 AM Changeset in webkit [63097] by bweinstein@apple.com
  • 3 edits in trunk/WebKit2

WebKit2 build fix for Windows.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: Remove some stub function definitions.
  • win/WebKit2.vcproj: Add PluginController.h to the vcproj.
10:29 AM HackingWebInspector edited by me@elv1s.ru
(diff)
10:28 AM WebKit Team edited by inferno@chromium.org
Adding Justin, Chris (google security team) who have committer access (diff)
10:28 AM Changeset in webkit [63096] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Some inspector test fail intermittently
​https://bugs.webkit.org/show_bug.cgi?id=42090

Add tests to the Skipped list until fix to avoid false positive alarms.

  • platform/qt/Skipped:
    • inspector/timeline-layout.html skipped.
    • inspector/timeline-parse-html.html skipped.
    • inspector/timeline-recalculate-styles.html skipped.
10:12 AM HackingWebInspector edited by me@elv1s.ru
Move images from my host to the attachments (diff)
10:10 AM reload.png attached to HackingWebInspector by me@elv1s.ru
10:09 AM tooltip.png attached to HackingWebInspector by me@elv1s.ru
10:09 AM inspect.png attached to HackingWebInspector by me@elv1s.ru
10:09 AM inspector.png attached to HackingWebInspector by me@elv1s.ru
10:05 AM HackingWebInspector created by me@elv1s.ru
9:57 AM Changeset in webkit [63095] by ap@apple.com
  • 11 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=13075
XMLHttpRequest with failed authentication should set status to 401

​https://bugs.webkit.org/show_bug.cgi?id=6871
<rdar://problem/3363403> 401 error page is never shown

9:52 AM Changeset in webkit [63094] by andersca@apple.com
  • 12 edits
    1 copy in trunk

Add a PluginController class, use it for invalidation and getting the user agent
​https://bugs.webkit.org/show_bug.cgi?id=42084

Reviewed by Adam Roben.

WebCore:

  • WebCore.exp.in:

Export Widget::convertToContainingWindow.

WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:

Add PluginController.h

  • WebProcess/Plugins/DummyPlugin.cpp:

(WebKit::DummyPlugin::initialize):

  • WebProcess/Plugins/DummyPlugin.h:

Pass the PluginController to initialize.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

Implement NPN_UserAgent, NPN_MemAlloc, NPN_MemFree, NPN_InvalidateRect and NPN_InvalidateRegion.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_pluginController to null.

(WebKit::NetscapePlugin::invalidate):
Ask the plug-in controller to invalidate.

(WebKit::NetscapePlugin::userAgent):´
Ask the plug-in controller for the user agent.

(WebKit::NetscapePlugin::initialize):
Set the m_pluginController member variable.

  • WebProcess/Plugins/Plugin.h:

Make initialize take a PluginController.

  • WebProcess/Plugins/PluginController.h: Added.
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
Pass the PluginController to initialize.

(WebKit::PluginView::invalidateRect):
Tell the host window to invalidate the given rect.

(WebKit::PluginView::invalidate):
Call invalidateRect.

(WebKit::PluginView::userAgent):
Ask the frame loader client for the user agent.

  • WebProcess/Plugins/PluginView.h:
9:41 AM Changeset in webkit [63093] by andersca@apple.com
  • 5 edits in trunk/JavaScriptCore

Add WARN_UNUSED_RETURN to the smart pointer "leak" member functions
​https://bugs.webkit.org/show_bug.cgi?id=42086

Reviewed by Dan Bernstein.

  • wtf/OwnPtr.h:
  • wtf/PassOwnPtr.h:
  • wtf/PassRefPtr.h:

(WTF::PassRefPtr::releaseRef):
(WTF::NonNullPassRefPtr::leakRef):
(WTF::NonNullPassRefPtr::releaseRef):

  • wtf/RetainPtr.h:

(WTF::RetainPtr::releaseRef):

9:07 AM Changeset in webkit [63092] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium test expectations updated.

  • platform/chromium/test_expectations.txt:
8:48 AM Changeset in webkit [63091] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium test expectations updated.

  • platform/chromium/test_expectations.txt:
8:40 AM Changeset in webkit [63090] by commit-queue@webkit.org
  • 4 edits in trunk/WebKitTools

2010-07-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=42082

  • QtTestBrowser/main.cpp: (LauncherWindow::createChrome):
  • QtTestBrowser/mainwindow.cpp: (MainWindow::openLocation):
  • QtTestBrowser/mainwindow.h:
8:18 AM Changeset in webkit [63089] by commit-queue@webkit.org
  • 4 edits in trunk

2010-07-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Dragging within webkit with a drag created via Javascript ends up misinterpreting the data
​https://bugs.webkit.org/show_bug.cgi?id=41457

Rebaseline test now that Qt doesn't corrupt non-breaking spaces on clipboard roundtrip.

  • platform/qt/editing/pasteboard/onpaste-text-html-expected.txt:

2010-07-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Dragging within webkit with a drag created via Javascript ends up misinterpreting the data
​https://bugs.webkit.org/show_bug.cgi?id=41457

Treat non-special-cased mime-types as Unicode strings in ClipboardQt's getData()
Fixes corruption when retrieving data that was set with anything other than text/plain

Also use QMimeData::setHtml() when applicable to be consistent with PasteboardQt.

  • platform/qt/ClipboardQt.cpp: (WebCore::isHtmlMimeType): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData):
8:06 AM Changeset in webkit [63088] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-07-12 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

add ANDROID to STORE_FONT_CUSTOM_PLATFORM_DATA
​https://bugs.webkit.org/show_bug.cgi?id=32273

Tested by existing tests, just adding ANDROID to the list of platforms that use this feature.

  • loader/CachedFont.cpp:
7:58 AM Changeset in webkit [63087] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make the Python autoinstaller not use a dead SourceForge server

Fixes <​http://webkit.org/b/42080> webkit-patch is broken due to
offline SourceForge server

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/thirdparty/init.py: Use

surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
which seems to be down.

7:54 AM Changeset in webkit [63086] by pfeldman@chromium.org
  • 3 edits
    13 adds
    3 deletes in trunk/LayoutTests

2010-07-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: rebaseline chromium layout tests.

  • platform/chromium-linux/fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
  • platform/chromium-linux/fast/gradients/radial-centered-expected.checksum:
  • platform/chromium-linux/fast/gradients/radial-centered-expected.png:
  • platform/chromium-linux/fast/gradients/radial-centered-expected.txt: Added.
  • platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.png: Added.
  • platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.txt: Added.
  • platform/chromium-mac/fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
  • platform/chromium-mac/fast/gradients/radial-centered-expected.checksum: Removed.
  • platform/chromium-mac/fast/gradients/radial-centered-expected.png: Removed.
  • platform/chromium-mac/fast/gradients/radial-centered-expected.txt: Removed.
  • platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.png: Added.
  • platform/chromium-win-vista/fast/gradients/radial-centered-expected.checksum: Added.
  • platform/chromium-win-vista/fast/gradients/radial-centered-expected.png: Added.
  • platform/chromium-win-vista/fast/gradients/radial-centered-expected.txt: Added.
7:49 AM Changeset in webkit [63085] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make run-webkit-tests print how many tests timed out when exiting early

The number of timed-out tests is taken into account when deciding
whether to exit early. Leaving it out of the output just makes the
script look buggy (because it might say something like "Exiting early
after 0 crashes.").

Fixes <​http://webkit.org/b/42077> run-webkit-tests prints confusing
messages when exiting early due to crashes and time-outs

Reviewed by Anders Carlsson.

  • Scripts/old-run-webkit-tests:

(stopRunningTestsEarlyIfNeeded): When stopping, print the number of
timed-out tests, too.

7:27 AM Changeset in webkit [63084] by leandro@webkit.org
  • 3 edits in trunk/WebCore

2010-07-12 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed.

[EFL] Move ScriptConcotrollerEfl.cpp from CMakeLists.txt to
CMakeListsEfl.txt.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
7:23 AM Changeset in webkit [63083] by leandro@webkit.org
  • 4 edits in trunk

2010-07-12 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed build fix after r60050.

  • CMakeLists.txt: Add WebCore/bindings to the include path.

2010-07-12 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed build fix after r60050.

  • CMakeLists.txt: Add WebCore/bindings to the include path.
7:19 AM Changeset in webkit [63082] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crashes when going back with page cache in unknown circunstances
​https://bugs.webkit.org/show_bug.cgi?id=41710

Could not yet find a way to reproduce this in a layout test. The
issue is document being NULL, so this NULL-check should be enough
to get rid of the crash. We are working on trying to find a better
solution for these null cases, like attaching the document earlier
when openning a cached page.

  • page/EventHandler.cpp: (WebCore::EventHandler::sendScrollEvent):
7:13 AM Changeset in webkit [63081] by Adam Roben
  • 2 edits
    2 adds in trunk/WebKit2

Windows build fix

  • WebProcess/Plugins/Netscape/win/NetscapePluginModuleWin.cpp: Added.

(WebKit::NetscapePluginModule::tryLoad):
(WebKit::NetscapePluginModule::unload):
Stubbed these out.

  • win/WebKit2.vcproj: Added a Netscape filter beneath

WebProcess/Plugins, and moved NetscapePlugin into it. Added
NetscapePluginModule to the new Netscape filter. Added
WebProcess/Plugins to the include path for all configurations (it was
only added to Release and Debug_Internal previously) and added
WebProcess/Plugins/Netscape to the include path for all
configurations.

7:07 AM Changeset in webkit [63080] by apavlov@chromium.org
  • 5 edits in trunk

2010-07-12 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] Crash when stepping on a breakpoint while debugging Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=41958

WebCore:

  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
  • page/PageGroupLoadDeferrer.h:

WebKit/chromium:

  • src/WebViewImpl.cpp: (WebKit::WebView::willEnterModalLoop): (WebKit::WebView::didExitModalLoop):
6:20 AM Changeset in webkit [63079] by commit-queue@webkit.org
  • 8 edits in trunk

2010-07-12 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Test the mathsize MathML attribute.
​https://bugs.webkit.org/show_bug.cgi?id=42067

  • mathml/presentation/attributes.xhtml:
  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:

2010-07-12 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Make the mathsize MathML attribute handle values in em, px, pt,...
​https://bugs.webkit.org/show_bug.cgi?id=42067

Test: mathml/presentation/attributes.xhtml

  • css/mathml.css: (math[mathsize="small"], mstyle[mathsize="small"], mo[mathsize="small"], mn[mathsize="small"], mi[mathsize="small"], mtext[mathsize="small"], mspace[mathsize="small"], ms[mathsize="small"]): (math[mathsize="normal"], mstyle[mathsize="normal"], mo[mathsize="normal"], mn[mathsize="normal"], mi[mathsize="normal"], mtext[mathsize="normal"], mspace[mathsize="normal"], ms[mathsize="normal"]): (math[mathsize="big"], mstyle[mathsize="big"], mo[mathsize="big"], mn[mathsize="big"], mi[mathsize="big"], mtext[mathsize="big"], mspace[mathsize="big"], ms[mathsize="big"]):
  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::parseMappedAttribute):
6:18 AM MathML 3 testsuite results edited by François Sausset
(diff)
5:52 AM Changeset in webkit [63078] by xan@webkit.org
  • 5 edits in trunk

WebCore:

2010-07-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix compilation with sealed GTK+.

  • platform/gtk/GtkVersioning.h:
  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::fillDataObjectFromDropData):

WebKit/gtk:

2010-07-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix compilation with sealed GTK+.

  • webkit/webkitwebview.cpp: (webkit_web_view_drag_motion): (webkit_web_view_drag_data_received): (webkit_web_view_drag_drop):
5:51 AM Changeset in webkit [63077] by xan@webkit.org
  • 2 edits in trunk

2010-07-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add another include path to the scanner to avoid warnings related
to undefined types. It wasn't picking up <webkit/foo.h>-like
headers.

  • GNUmakefile.am:
5:45 AM Changeset in webkit [63076] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Fix duplicate test expectations
​https://bugs.webkit.org/show_bug.cgi?id=42072

  • platform/chromium/test_expectations.txt:
5:43 AM Changeset in webkit [63075] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2010-07-12 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Update of the results to the test introduced here:
​https://bugs.webkit.org/show_bug.cgi?id=41626
as they were outdated in the commit.

  • platform/mac/mathml/presentation/tokenElements-expected.checksum:
  • platform/mac/mathml/presentation/tokenElements-expected.png:
  • platform/mac/mathml/presentation/tokenElements-expected.txt:
5:31 AM Changeset in webkit [63074] by commit-queue@webkit.org
  • 12 edits in trunk

2010-07-12 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Update tests to check that msqrt and mfrac use style color to draw themselves
​https://bugs.webkit.org/show_bug.cgi?id=41889

  • mathml/presentation/fractions.xhtml:
  • mathml/presentation/roots.xhtml:
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:

2010-07-12 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Fix a bug preventing msqrt and mfrac to use style color to draw themselves.
In mfrac, the fraction bar is now using the color defined by the element style instead of black.
In msqrt, the radical was always drawn in black due to a colorSpace problem.
​https://bugs.webkit.org/show_bug.cgi?id=41889

Test: mathml/presentation/roots.xhtml
Test: mathml/presentation/fractions.xhtml

  • mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
  • mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
5:17 AM Changeset in webkit [63073] by commit-queue@webkit.org
  • 4 edits in trunk

2010-07-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Antti Koivisto.

Canvas: arc() with startAngle == endAngle shouldn't add to the path
​https://bugs.webkit.org/show_bug.cgi?id=41420

Unskip (for Qt) test that now passes:

  • canvas/philip/tests/2d.path.stroke.prune.arc.html

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-stroke

  • platform/qt/Skipped:

2010-07-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Antti Koivisto.

Canvas: arc() with startAngle == endAngle shouldn't add to the path
​https://bugs.webkit.org/show_bug.cgi?id=41420

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-stroke

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arc):
5:08 AM Changeset in webkit [63072] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-12 Jeremy Orlow <​jorlow@chromium.org>

Somehow the updated expectations got dropped form the original patch. Added.

  • storage/indexeddb/idb-objectstore-request-expected.txt:
4:46 AM Changeset in webkit [63071] by hamaji@chromium.org
  • 10 edits in trunk

2010-07-12 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Ojan Vafai.

Update padding on Windows?
​https://bugs.webkit.org/show_bug.cgi?id=38016

  • platform/chromium/test_expectations.txt:
  • platform/win/Skipped:

2010-07-12 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Ojan Vafai.

Update padding on Windows?
​https://bugs.webkit.org/show_bug.cgi?id=38016

Remove internal padding and add 1px vertical padding for Windows.

  • css/themeWin.css: (input[type="button"], input[type="submit"], input[type="reset"], input[type="file"]::-webkit-file-upload-button, button):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::setupInnerStyle):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeWin.cpp:
  • rendering/RenderThemeWin.h:
  • rendering/RenderThemeWince.cpp:
  • rendering/RenderThemeWince.h:
4:18 AM Changeset in webkit [63070] by hamaji@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-07-12 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. Put the expected result for Win.

REGRESSION: printing is broken if stylesheet has @page
​https://bugs.webkit.org/show_bug.cgi?id=40452

  • platform/win/printing/page-rule-in-media-query-expected.txt: Added.
4:15 AM Changeset in webkit [63069] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-12 Jeremy Orlow <​jorlow@chromium.org>

Speculative fix for visual studio retardedness.

  • public/WebCommon.h:
4:10 AM Changeset in webkit [63068] by hamaji@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-07-12 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. Put wrong results for Mac and Win instead of Skipped list.

Results for editing/pasteboard/5761530-1.html are wrong
​https://bugs.webkit.org/show_bug.cgi?id=38437

  • platform/mac/Skipped:
  • platform/mac/editing/pasteboard/5761530-1-expected.txt: Copied from LayoutTests/platform/chromium/editing/pasteboard/5761530-1-expected.txt.
  • platform/win/editing/pasteboard/5761530-1-expected.txt: Copied from LayoutTests/platform/chromium/editing/pasteboard/5761530-1-expected.txt.
3:50 AM Changeset in webkit [63067] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium tests fix.

[Chromium, V8] r63057 regressed url tests.

​https://bugs.webkit.org/show_bug.cgi?id=42063

  • bindings/scripts/CodeGeneratorV8.pm:
3:47 AM MathML 3 testsuite results edited by François Sausset
(diff)
3:43 AM MathML 3 testsuite results edited by François Sausset
(diff)
3:42 AM Changeset in webkit [63066] by steveblock@google.com
  • 3 edits
    2 adds in trunk

2010-07-12 Steve Block <​steveblock@google.com>

Reviewed by Alexey Proskuryakov.

XPath substring function does not correctly handle non-positive values for the position argument
​https://bugs.webkit.org/show_bug.cgi?id=41913

This patch changes the behavior of the XPath evaluate function when a non-positive
position argument is supplied and no length argument is supplied. In this case,
we reset the position to 1. This follows the spec and matches the current behaviour
when a length argument is supplied.

Test: fast/xpath/substring-non-positive-postion.html

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunSubstring::evaluate):

2010-07-12 Steve Block <​steveblock@google.com>

Reviewed by Alexey Proskuryakov.

XPath substring function does not correctly handle non-positive values for the position argument
​https://bugs.webkit.org/show_bug.cgi?id=41913

  • fast/xpath/substring-non-positive-postion-expected.txt: Added.
  • fast/xpath/substring-non-positive-postion.html: Added.
3:39 AM Changeset in webkit [63065] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-12 Jeremy Orlow <​jorlow@chromium.org>

Build fix. Add an include.

  • public/WebCommon.h:
3:00 AM Changeset in webkit [63064] by jorlow@chromium.org
  • 53 edits
    2 copies in trunk

2010-06-27 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dumitru Daniliuc.

Implement IDBObjectStore.get/set/remove
​https://bugs.webkit.org/show_bug.cgi?id=41250

Modify existing test to provide basic coverage for get/put/remove functions.

  • storage/indexeddb/script-tests/idb-objectstore-request.js: (test): (openSuccess): (createSuccess): (addSuccess): (getSuccess): (removeSuccess):

2010-06-27 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dumitru Daniliuc.

Implement IDBObjectStore.get/set/remove
​https://bugs.webkit.org/show_bug.cgi?id=41250

Implement these functions in IDBObjectStore,
add plumbing, teach IDBAny/Callbacks how to deal
with IDBKey, and a few small bits of cleanup.

Test: Modified existing test to provide basic coverage.

Will add much more extensive layout test coverage
in future patches.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.jscbindings.mk:
  • Android.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
  • storage/IDBAny.cpp: (WebCore::IDBAny::idbKey): (WebCore::IDBAny::set):
  • storage/IDBAny.h: (WebCore::IDBAny::):
  • storage/IDBAny.idl:
  • storage/IDBCallbacks.h:
  • storage/IDBDatabaseRequest.h:
  • storage/IDBDatabaseRequest.idl:
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::):
  • storage/IDBObjectStoreImpl.cpp: (WebCore::IDBObjectStoreImpl::IDBObjectStoreImpl): (WebCore::IDBObjectStoreImpl::get): (WebCore::IDBObjectStoreImpl::set): (WebCore::IDBObjectStoreImpl::remove):
  • storage/IDBObjectStoreImpl.h:
  • storage/IDBObjectStoreRequest.cpp: (WebCore::IDBObjectStoreRequest::get): (WebCore::IDBObjectStoreRequest::add): (WebCore::IDBObjectStoreRequest::modify): (WebCore::IDBObjectStoreRequest::addOrModify): (WebCore::IDBObjectStoreRequest::remove):
  • storage/IDBObjectStoreRequest.h:
  • storage/IDBObjectStoreRequest.idl:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):
  • storage/IDBRequest.h:

2010-06-27 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dumitru Daniliuc.

Implement IDBObjectStore.get/set/remove
​https://bugs.webkit.org/show_bug.cgi?id=41250

Plumbing for new features, IDBKey, and added support
for both invalid (i.e. not serializable) and null
(i.e. the RefPtr was 0) to SerializedScriptValue.

  • WebKit.gyp:
  • public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess):
  • public/WebIDBKey.h: Added. (WebKit::WebIDBKey::WebIDBKey): (WebKit::WebIDBKey::operator=): (WebKit::WebIDBKey::):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::set): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::index): (WebKit::WebIDBObjectStore::removeIndex):
  • public/WebSerializedScriptValue.h:
  • src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::get): (WebCore::IDBObjectStoreProxy::set): (WebCore::IDBObjectStoreProxy::remove):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCallbacksImpl.h:
  • src/WebIDBKey.cpp: Added. (WebKit::WebIDBKey::~WebIDBKey): (WebKit::WebIDBKey::createNull): (WebKit::WebIDBKey::createInvalid): (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::assignNull): (WebKit::WebIDBKey::assignInvalid): (WebKit::WebIDBKey::type): (WebKit::WebIDBKey::string): (WebKit::WebIDBKey::number): (WebKit::WebIDBKey::WebIDBKey): (WebKit::WebIDBKey::operator=): (WebKit::WebIDBKey::operator PassRefPtr<IDBKey>):
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::set): (WebKit::WebIDBObjectStoreImpl::remove):
  • src/WebIDBObjectStoreImpl.h:
  • src/WebSerializedScriptValue.cpp: (WebKit::WebSerializedScriptValue::createInvalid):
12:57 AM Changeset in webkit [63063] by mjs@apple.com
  • 11 edits in trunk

2010-07-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Implement animation-related methods for WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=42053

  • WebCore.exp.in: Export Document::getElementById for WebKit2's benefit.

2010-07-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Implement animation-related methods for WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=42053


Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
animation tests were hanging otherwise.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::numberOfActiveAnimations): (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): (WTR::numberOfActiveAnimationsCallback): (WTR::pauseAnimationAtTimeOnElementWithIdCallback): (WTR::LayoutTestController::staticFunctions):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

2010-07-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Implement animation-related methods for WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=42053

Implemented some helpers for WebKitTestRunner;


  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameGetNumberOfActiveAnimations): (WKBundleFramePauseAnimationOnElementWithId):
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::numberOfActiveAnimations): (WebKit::WebFrame::pauseAnimationOnElementWithId):
  • WebProcess/WebPage/WebFrame.h:
  • mac/WebKit2.exp:
12:08 AM WebKit Team edited by inferno@chromium.org
Adding myself (diff)

Jul 11, 2010:

11:29 PM Changeset in webkit [63062] by dbates@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-11 Daniel Bates <​dbates@rim.com>

Reviewed by David Kilzer.

Enable executable support for svn-apply and svn-unapply
​https://bugs.webkit.org/show_bug.cgi?id=39409

Connect up the Git and SVN executable bit support in parseDiff() so that
executable bit changes are propagated via the returned diff hash to the
patch function in svn-apply and svn-unapply.

  • Scripts/VCSUtils.pm:
    • Modified parseDiff() to call parseSvnDiffProperties when it finds the start of an SVN property change diff.
    • Removed FIXME comment above parseSvnDiffProperties() since it is now being used by parseDiff().
    • Export method scmToggleExecutableBit() now that we added the executableBitDelta hash key. (This should have been exported when we added this function in Bug #38423 <​https://bugs.webkit.org/show_bug.cgi?id=38423>).
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Updated results for: "rename (with executable bit change)"
      • Test value of executableBitDelta (now that we have support).
      "SVN: binary file (isBinary true)"
      • Remove the property change diff from svnConvertedText. We plan to remove svnConvertedText in the future. So, we decided against adding such support to any new code, such as the property parsing routines. Therefore, we do not keep SVN converted text for property change diffs.
    • Added unit tests: "SVN: file change diff with property change diff" "SVN: file change diff, followed by property change diff on different file" "SVN: property diff, followed by file change diff" "SVN: copied file with property change" "SVN: two consecutive property diffs" "SVN: binary file with executable bit change" "SVN: binary file followed by property change on different file" "SVN: binary file followed by file change on different file" "SVN: file change diff with property change, followed by property change diff" "SVN: file change diff with property change, followed by file change diff"
8:41 PM Changeset in webkit [63061] by mjs@apple.com
  • 7 edits in trunk/WebKitTools

2010-07-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Implement waitUntilDone and notifyDone for WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=42049

With this fix, most of the DOM tests pass.


  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didCreatePage): Track the main page. Not a great way to do it in the future case where we may get multiple pages - we really need a way to send it over from the ui process.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::page): A way to get the main page.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false. (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we are loading. (WTR::InjectedBundlePage::dump): Factor into a method so this can be called by the layout test controller. Also, cancel any pending watchdogs. (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading. (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump to false. (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate the watchdog. (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer. (WTR::LayoutTestController::setWaitToDump): Set the flag. (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case where waitUntilDone times out. (WTR::LayoutTestController::notifyDone): Dump, if loading is done. (WTR::waitUntilDoneCallback): JS glue for waitUntilDone. (WTR::notifyDoneCallback): JS glue for notifyDone. (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone to the layoutController.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
7:35 PM Changeset in webkit [63060] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit

2010-07-11 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

[EFL] Fix style errors in ewk_private.h.
​https://bugs.webkit.org/show_bug.cgi?id=41742

  • efl/ewk/ewk_private.h:
5:09 PM Changeset in webkit [63059] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-07-11 Adam Barth <​abarth@webkit.org>

Rubber-stamped by Eric Seidel

Add a complete list of the HTML5 entities in JSON format.

  • html/HTMLEntityNames.json: Added.
10:37 AM Changeset in webkit [63058] by Martin Robinson
  • 8 edits in trunk

2010-07-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitWebView should support drops
​https://bugs.webkit.org/show_bug.cgi?id=39843

Add support for dropping content onto GTK+ WebViews.

No new tests, as the DRT does not support simulating drops yet.

  • platform/gtk/ClipboardUtilitiesGtk.cpp: (WebCore::dragOperationToGdkDragAction): Added. (WebCore::gdkDragActionToDragOperation): Properly detect DragOperationEvery.
  • platform/gtk/ClipboardUtilitiesGtk.h: Add declaration for dragOperationToGdkDragAction.
  • platform/gtk/PasteboardHelper.cpp: Add new target atom and rename the markup target type to match the others. Add a method which fills a data object from drop data. (WebCore::PasteboardHelper::initializeTargetList): Add support for new atoms. (WebCore::selectionDataToUTF8String): Added this helper. (WebCore::PasteboardHelper::getClipboardContents): Use the selectionDataToUTF8String helper. (WebCore::PasteboardHelper::targetListForDataObject): Change to reflect markup atom rename. (WebCore::PasteboardHelper::fillDataObjectFromDropData): Added. (WebCore::PasteboardHelper::dropAtoms): Added.
  • platform/gtk/PasteboardHelper.h: Add declarations of new methods.

2010-07-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitWebView should support drops
​https://bugs.webkit.org/show_bug.cgi?id=39843

Add support for dropping content onto GTK+ WebViews.

  • webkit/webkitprivate.h: Add a DroppingContext struct to keep track of drop data while the drop is in progress. Have WebKitWebView keep a map of GdkDragContexts to DroppingContexts.
  • webkit/webkitwebview.cpp: Add necessary includes and globalPointForClientPoint helper. (webkit_web_view_popup_menu_handler): Use globalPointForClientPoint helper. (webkit_web_view_dispose): Properly clean up droppingContexts member. (webkit_web_view_finalize): Delete droppingContext member. (globalPointForClientPoint): Added. (doDragLeaveLater): Added. (webkit_web_view_drag_leave): Added. (webkit_web_view_drag_motion): Added. (webkit_web_view_drag_data_received): Added. (webkit_web_view_drag_drop): Added. (webkit_web_view_class_init): Connect new drop signal handlers to the widget definition. (webkit_web_view_init): Set up the widget as a drop destination and initialize droppingContexts.
4:46 AM MathML 3 testsuite results edited by François Sausset
(diff)
4:13 AM MathML 3 testsuite results edited by François Sausset
(diff)

Jul 10, 2010:

11:54 PM Changeset in webkit [63057] by Darin Adler
  • 27 edits
    3 adds in trunk

2010-07-10 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Enhance content attribute reflection for URL attributes, including adding a non-empty option
​https://bugs.webkit.org/show_bug.cgi?id=42040

Test: fast/dom/URL-attribute-reflection.html

Changed syntax from [ReflectURL] to [Reflect,URL] and also added support for
a new option, NonEmpty, which implements the non-empty URL concept from the
HTML5 specification.

  • bindings/scripts/CodeGenerator.pm: Changed code to expect the Reflect and URL extended attributes to come in separately. The URL one simply means "the string of this attribute is a URL", since we don't have a distinct type for URL. Also added a new NonEmpty extended attribute.
  • bindings/scripts/CodeGeneratorJS.pm: Removed now-unneeded code to handle ReflectURL.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated for new added test cases and the fix I made to the reflectedCustomURLAttr test.
  • bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto. Also, for some reason the V8 bindig writes out the keywords into the generated file as comments, so the keyword change had a direct efffect on the output file.
  • bindings/scripts/test/TestObj.idl: Changed the test cases for ReflectURL to use the new syntax. Added test cases for NonEmpty. Fixed the name of reflectedNonEmptyURLAttr, which accidentally was repeating reflectedURLAttr instead; never noticed because we never compile the test output.
  • dom/Element.cpp: (WebCore::Element::getNonEmptyURLAttribute): Added. For use by NonEmpty and also by any code that wants to implement the non-empty URL content attribute semantic.
  • dom/Element.h: Ditto.
  • html/HTMLAnchorElement.idl: Use Reflect,URL instead of ReflectURL.
  • html/HTMLAreaElement.idl: Ditto.
  • html/HTMLFrameElement.idl: Ditto.
  • html/HTMLImageElement.idl: Ditto.
  • html/HTMLInputElement.idl: Ditto.
  • html/HTMLLinkElement.idl: Ditto.
  • html/HTMLMediaElement.idl: Ditto.
  • html/HTMLObjectElement.idl: Ditto.
  • html/HTMLScriptElement.idl: Ditto.
  • html/HTMLVideoElement.idl: Ditto.

2010-07-10 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Enhance content attribute reflection for URL attributes, including adding a non-empty option
​https://bugs.webkit.org/show_bug.cgi?id=42040

The current test results show many failures, and we should follow up with fixes
either to the DOM implementation, or to the test result expectations.

  • fast/dom/URL-attribute-reflection-expected.txt: Added.
  • fast/dom/URL-attribute-reflection.html: Added.
  • fast/dom/script-tests/URL-attribute-reflection.js: Added.
6:14 PM Changeset in webkit [63056] by oliver@apple.com
  • 6 edits in trunk/JavaScriptCore

2010-07-10 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

HAVE_COMPUTED_GOTO is dependent on the interpreter being enabled
​https://bugs.webkit.org/show_bug.cgi?id=42039

Separate the existence of computed goto support in the compiler
from whether or not we are using the interpreter. All the current
HAVE(COMPUTED_GOTO) guards are for the interpreter, but I'd like
the option of using it elsewhere. The interpreter now uses
ENABLE(COMPUTED_GOTO_INTERPRETER)

  • bytecode/Instruction.h: (JSC::Instruction::Instruction):
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter): (JSC::Interpreter::isOpcode): (JSC::Interpreter::privateExecute):
  • interpreter/Interpreter.h: (JSC::Interpreter::getOpcode): (JSC::Interpreter::getOpcodeID):
  • wtf/Platform.h:
5:11 PM Changeset in webkit [63055] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-07-10 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove switches from inner expression loops in the parser
​https://bugs.webkit.org/show_bug.cgi?id=42035

Use bitmasks and flags on the token types to identify unary and
binary operators, rather than switching on the token type to
identify them.

  • parser/JSParser.cpp: (JSC::isUnaryOp): (JSC::JSParser::isBinaryOperator):
  • parser/JSParser.h: (JSC::):
4:11 PM Changeset in webkit [63054] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2010-07-10 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Adler.

Add missing derrived sources to xcode project
​https://bugs.webkit.org/show_bug.cgi?id=42034

This allows --web-timing to work with build-webkit on OSX with JSC.
This should have been done in bug 41442.

No new tests because no new functionality.

  • WebCore.xcodeproj/project.pbxproj:
3:31 PM MathML 3 testsuite results edited by François Sausset
(diff)
3:28 PM Changeset in webkit [63053] by andersca@apple.com
  • 6 edits in trunk

Don't initialize plug-ins until allowed by the page
​https://bugs.webkit.org/show_bug.cgi?id=42033

Reviewed by Sam Weinig.

WebCore:

  • WebCore.exp.in:

Export Document::addMediaCanStartListener and Document::removeMediaCanStartListener.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::paint):
(WebKit::NetscapePlugin::geometryDidChange):
Assert that the plug-in is started.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Initialize m_isWaitingUntilMediaCanStart.

(WebKit::PluginView::~PluginView):
If necessary, remove the plug-in view as a MediaCanStartListener.

(WebKit::PluginView::initializePlugin):
If we're not allowed to initialize the plug-in, add the plug-in view as a MediaCanStartListener.

(WebKit::PluginView::paint):
Check that the plug-in is initialized.

(WebKit::PluginView::viewGeometryDidChange):
Ditto.

(WebKit::PluginView::mediaCanStart):
Initialize the plug-in.

  • WebProcess/Plugins/PluginView.h:
2:47 PM Changeset in webkit [63052] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Have the plug-in view initialize the plug-in
​https://bugs.webkit.org/show_bug.cgi?id=42030

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/DummyPlugin.cpp:

(WebKit::DummyPlugin::initialize):

  • WebProcess/Plugins/DummyPlugin.h:

Plugin::initialize now takes a struct.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::initialize):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Plugin::initialize now takes a struct.

  • WebProcess/Plugins/Plugin.h:

Add Parameters struct.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Add Parameters parameter.

(WebKit::PluginView::~PluginView):
Add m_plugin null check.

(WebKit::PluginView::initializePlugin):
Try to initialize the plug-in and zero out the plug-in if initialization fails.

(WebKit::PluginView::paint):
Add m_plugin null check.

(WebKit::PluginView::setParent):
Initialize the plug-in.

  • WebProcess/Plugins/PluginView.h:

(WebKit::PluginView::create):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Don't initialize the plug-in here.

2:38 PM Changeset in webkit [63051] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore: Patch for ​https://bugs.webkit.org/show_bug.cgi?id=42021
isEqualNode should work for DocumentType nodes

Reviewed by Anders Carlsson.

Test: fast/dom/Node/isEqualNode.html

  • dom/Node.cpp:

(WebCore::Node::isEqualNode): Add DocumentType logic from the DOM3 spec.

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=42021
isEqualNode should work for DocumentType nodes

Reviewed by Anders Carlsson.

  • fast/dom/Node/isEqualNode-expected.txt: Added.
  • fast/dom/Node/isEqualNode.html: Added.
  • fast/dom/Node/script-tests/isEqualNode.js: Added.
2:18 PM Changeset in webkit [63050] by dbates@webkit.org
  • 9 edits
    1 add in trunk/WebCore

2010-07-10 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

Move enum ReasonForCallingCanExecuteScripts to header ScriptControllerBase.h
​https://bugs.webkit.org/show_bug.cgi?id=39339

Moved the enum ReasonForCallingCanExecuteScripts, which was
defined in both the JSC and V8 ScriptController.h file, into
a shared file called ScriptControllerBase.h.

No functionality was changed, so no new tests.

  • GNUmakefile.am: Added file bindings/ScriptControllerBase.h.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcproj/WebCoreCommon.vsprops: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/ScriptControllerBase.h: Added. (WebCore::):
  • bindings/js/ScriptController.h: #include ScriptControllerBase.h
  • bindings/v8/ScriptController.h: Ditto.
1:18 PM MathML 3 testsuite results edited by François Sausset
(diff)
12:39 PM Changeset in webkit [63049] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Call Page::canStartMedia when the WKView is added to/removed from a window
​https://bugs.webkit.org/show_bug.cgi?id=42029

Reviewed by Oliver Hunt.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:

(WebPageMessage::):
Add SetIsInWindow.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:]):
Call setIsInWindow.

(-[WKView _updateVisibility]):
Call setIsInWindow.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Initialize m_isInWindow.

(WebKit::WebPageProxy::setIsInWindow):
Send WebPageMessage::SetIsInWindow.

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setIsInWindow):
Call Page::canStartMedia.

(WebKit::WebPage::didReceiveMessage):
Handle the SetIsInWindow message.

  • WebProcess/WebPage/WebPage.h:
10:57 AM Changeset in webkit [63048] by mitz@apple.com
  • 6 edits
    4 adds in trunk

<rdar://problem/8153214> Continuation outlines in layers do not paint correctly

Reviewed by Anders Carlsson.

WebCore:

Test: fast/inline/continuation-outlines-with-layers-2.html

Continuation outlines are normally painted by the containing block. However, when the
block and the inline are not enclosed by the same self-painting layer, the inline has to
paint its own outlines. This was handled correctly only for the case where the inline had
its own self-painting layer, but now when an ancestor inline had the self-painting layer.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paint): Instead of testing for having a self-painting layer, test
whether any intermediate box between the inline and the containing block has a self-painting
layer.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject): Ditto.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingBoxModelObject): Added this utility method.

  • rendering/RenderObject.h:

LayoutTests:

  • fast/inline/continuation-outlines-with-layers-2.html: Added.
  • platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.checksum: Added.
  • platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.png: Added.
  • platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.txt: Added.
10:33 AM Changeset in webkit [63047] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Reuse initialized NetscapePluginModules, pass parameters to NPP_New
​https://bugs.webkit.org/show_bug.cgi?id=42028

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Let the plug-in module know that a plug-in has been created.

(WebKit::NetscapePlugin::~NetscapePlugin):
Let the plug-in module know that a plug-in has been destroyed.

(WebKit::NetscapePlugin::initialize):
Pass the MIME type and parameters to the plug-in.

  • WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::initializedNetscapePluginModules):
Add list of initialized plug-in modules.

(WebKit::NetscapePluginModule::NetscapePluginModule):
Initialize m_pluginCount to 0.

(WebKit::NetscapePluginModule::~NetscapePluginModule):
Assert that we're not in the list of initialized plug-ins.

(WebKit::NetscapePluginModule::pluginCreated):
Increment the plug-in count.

(WebKit::NetscapePluginModule::pluginDestroyed):
Decrement the plug-in count and call shutdown if it's 0.

(WebKit::NetscapePluginModule::shutdown):
Call NP_Shutdown and remove the plug-in from the list of initialized plug-ins.

(WebKit::NetscapePluginModule::getOrCreate):
Look for an already initialized plug-in module before creating one.

(WebKit::NetscapePluginModule::load):
Set m_isInitialized to true.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginModuleMac.cpp:

(WebKit::NetscapePluginModule::unload):
Leak the CFBundleRef to avoid possible crashes.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Call getOrCreate instead of create.

9:02 AM Changeset in webkit [63046] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-10 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Build fix: syntax and typo issues
​https://bugs.webkit.org/show_bug.cgi?id=41859

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag):
5:02 AM MathML 3 testsuite results edited by François Sausset
(diff)
2:01 AM Changeset in webkit [63045] by eric@webkit.org
  • 5 edits in trunk

2010-07-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs adjustForeignAttributes support
​https://bugs.webkit.org/show_bug.cgi?id=42022

  • html5lib/runner-expected-html5.txt:
    • We now pass 3 more tests.

2010-07-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs adjustForeignAttributes support
​https://bugs.webkit.org/show_bug.cgi?id=42022

To add adjust foreign attributes support I had to add an
AtomicString (prefixed name) to QualifiedName hash. Once I had
done that, I decided it would be best for the other "adjust" functions
to share the same hash logic, so I moved them to using the same
AtomicString -> QualifiedName hash as well.

Tested by html5lib/runner.html

  • dom/Attribute.h: (WebCore::Attribute::parserSetName):
  • html/HTMLTreeBuilder.cpp:
1:14 AM Changeset in webkit [63044] by rwlbuis@webkit.org
  • 16 edits in trunk/WebCore

2010-07-10 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=41978
Remove namespace prefixes from idl files

No new tests, idl syntax fixes.

  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSVariablesRule.idl:
  • svg/SVGAnimatedString.idl:
  • svg/SVGColor.idl:
  • svg/SVGDocument.idl:
  • svg/SVGLangSpace.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGStringList.idl:
  • svg/SVGStylable.idl:
  • svg/SVGStyleElement.idl:
  • svg/SVGTests.idl:
  • svg/SVGZoomEvent.idl:
  • xml/XPathEvaluator.idl:
12:59 AM Changeset in webkit [63043] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, GTK build fix.

  • bindings/gobject/GObjectEventListener.h:
12:24 AM Changeset in webkit [63042] by dumi@chromium.org
  • 16 edits in trunk/WebCore

Remove unnecessary includes in header files in WebCore/dom.
​https://bugs.webkit.org/show_bug.cgi?id=41941

Reviewed by Darin Adler.

  • css/StyleMedia.h:
  • dom/BeforeLoadEvent.h:
  • dom/CustomEvent.h:
  • dom/DOMStringMap.h:
  • dom/DeviceOrientationEvent.h:
  • dom/EventListener.h:
  • dom/MessagePort.h:
  • dom/Node.cpp:
  • dom/NodeFilter.h:
  • dom/NodeRareData.h:
  • dom/RegisteredEventListener.h:
  • dom/SelectorNodeList.cpp:
  • dom/SelectorNodeList.h:
  • dom/StyleElement.h:
  • dom/Traversal.h:

Jul 9, 2010:

10:01 PM Changeset in webkit [63041] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

Windows testers running Windows 7 were hanging during test_kill_process. Changing the
number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
slow down the tests).

Rubber-stamped by Dan Bernstein.

  • Scripts/webkitpy/common/system/executive.py:
9:32 PM Changeset in webkit [63040] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-09 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Take out WebPlugin::supportsFind since we can accomplish the same thing by having a return value on startFind
​https://bugs.webkit.org/show_bug.cgi?id=42011

  • public/WebPlugin.h: (WebKit::WebPlugin::startFind):
9:20 PM Changeset in webkit [63039] by tony@chromium.org
  • 4 edits
    2 adds in trunk

2010-07-09 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting pre
​https://bugs.webkit.org/show_bug.cgi?id=38231

  • editing/execCommand/indent-pre-expected.txt: Added.
  • editing/execCommand/indent-pre.html: Added.

2010-07-09 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting pre
​https://bugs.webkit.org/show_bug.cgi?id=38231

Test: editing/execCommand/indent-pre.html

  • editing/IndentOutdentCommand.cpp: (WebCore::countParagraphs): (WebCore::IndentOutdentCommand::indentRegion): Split text nodes into one node per paragraph

so moveParagraph doesn't get confused.

(WebCore::IndentOutdentCommand::splitTextNodes):

  • editing/IndentOutdentCommand.h:
9:08 PM Changeset in webkit [63038] by arv@chromium.org
  • 10 edits in trunk

2010-07-09 Erik Arvidsson <​arv@chromium.org>

Reviewed by Darin Adler.

Computed style is not implemented for padding-start, padding-end, margin-start, margin-end
​https://bugs.webkit.org/show_bug.cgi?id=41496

  • fast/css/margin-start-end-expected.txt:
  • fast/css/padding-start-end-expected.txt:
  • fast/css/script-tests/margin-start-end.js: Added tests for computed style.
  • fast/css/script-tests/padding-start-end.js: Added tests for computed style.

2010-07-09 Erik Arvidsson <​arv@chromium.org>

Reviewed by Darin Adler.

Computed style is not implemented for padding-start, padding-end, margin-start, margin-end
​https://bugs.webkit.org/show_bug.cgi?id=41496

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSProperty.cpp: (WebCore::CSSProperty::resolveDirectionAwareProperty): This function resolves the property ID for a direction aware property.
  • css/CSSProperty.h:
  • css/CSSStyleSelector.cpp: Use helper function. (WebCore::CSSStyleSelector::applyProperty):
8:47 PM Changeset in webkit [63037] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 tree builder should pass some LayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=41991

Before this patch, we weren't attaching text nodes to the render tree,
which turns out to be important. :)

This patch fixes more than 10,000 LayoutTests.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): (WebCore::HTMLConstructionSite::attachAtSite):
8:36 PM Changeset in webkit [63036] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

[WINCE] Buildfix for TextEncodingRegistry
​https://bugs.webkit.org/show_bug.cgi?id=41992

Renamed TextCodecWince to TextCodecWinCE.

  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
8:20 PM Changeset in webkit [63035] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-09 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Mac build fix
​https://bugs.webkit.org/show_bug.cgi?id=41967

Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
8:13 PM Changeset in webkit [63034] by dbates@webkit.org
  • 7 edits
    1 move in trunk/LayoutTests

2010-07-09 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Clean up: Move dump-list.js utility script from LayoutTests/fast/lists
to LayoutTests/fast/lists/resources
​https://bugs.webkit.org/show_bug.cgi?id=42016

Move fast/lists/dump-list.js to fast/lists/resources since it
is a utility script and not a test case.

  • fast/lists/dump-list.js: Removed. Moved to fast/lists/resources.
  • fast/lists/ol-nested-items-dynamic-insert.html: Modified to look for dump-list.js in new location.
  • fast/lists/ol-nested-items-dynamic-remove.html: Ditto.
  • fast/lists/ol-nested-items.html: Ditto.
  • fast/lists/ol-nested-list-dynamic-insert.html: Ditto.
  • fast/lists/ol-nested-list-dynamic-remove.html: Ditto.
  • fast/lists/ol-nested-list.html: Ditto.
  • fast/lists/resources/dump-list.js: Copied from LayoutTests/fast/lists/dump-list.js.
8:02 PM Changeset in webkit [63033] by diegohcg@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-09 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Antonio Gomes.

[Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
​https://bugs.webkit.org/show_bug.cgi?id=41966

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow):
7:41 PM Changeset in webkit [63032] by commit-queue@webkit.org
  • 29 edits
    3 adds in trunk

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

  • Configurations/FeatureDefines.xcconfig:

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

  • fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
  • fast/dom/HTMLLinkElement/prefetch.html: Added.
  • fast/dom/HTMLLinkElement/prefetch.link: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

Test: fast/dom/HTMLLinkElement/prefetch.html

  • Configurations/FeatureDefines.xcconfig:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process):
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
  • loader/Cache.cpp: (WebCore::createResource):
  • loader/CachedResource.cpp: (WebCore::CachedResource::data): (WebCore::CachedResource::didAddClient):
  • loader/CachedResource.h: (WebCore::CachedResource::): (WebCore::CachedResource::error): (WebCore::CachedResource::isPrefetch): (WebCore::CachedResource::schedule):
  • loader/CachedScript.cpp:
  • loader/CachedScript.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestLinkPrefetch): (WebCore::DocLoader::canRequest): (WebCore::DocLoader::incrementRequestCount): (WebCore::DocLoader::decrementRequestCount):
  • loader/DocLoader.h:
  • loader/loader.cpp: (WebCore::cachedResourceTypeToTargetType): (WebCore::Loader::determinePriority): (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): (WebCore::Loader::Host::didReceiveResponse): (WebCore::Loader::Host::cancelPendingRequests):
  • loader/loader.h: (WebCore::Loader::):
  • platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::):

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

  • public/WebURLRequest.h: (WebKit::WebURLRequest::):

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

  • Configurations/FeatureDefines.xcconfig:

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

  • Configurations/FeatureDefines.xcconfig:

2010-07-09 Leon Clarke <​leonclarke@google.com>

Reviewed by Adam Barth.

add support for link prefetching
​https://bugs.webkit.org/show_bug.cgi?id=3652

  • Scripts/build-webkit:
7:30 PM Changeset in webkit [63031] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-07-09 James Robinson <​jamesr@chromium.org>

Unreviewed build fix. Add #include to pick up ExceptionCode values for config (like Qt) where it's not picked up indirectly.

  • html/HTMLCanvasElement.cpp:
6:54 PM Changeset in webkit [63030] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r61710.

6:54 PM Changeset in webkit [63029] by mrowe@apple.com
  • 4 edits in branches/safari-533.17-branch/WebCore

Merge r61341.

6:40 PM Changeset in webkit [63028] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch/WebCore

Merge r62687.

6:39 PM Changeset in webkit [63027] by mrowe@apple.com
  • 9 edits in branches/safari-533.17-branch

Merge r62894.

6:27 PM Changeset in webkit [63026] by mrowe@apple.com
  • 18 edits
    2 adds in branches/safari-533.17-branch

Merge r62875.

6:26 PM Changeset in webkit [63025] by jamesr@google.com
  • 9 edits
    2 deletes in trunk/WebCore

2010-07-09 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler.

Removes CanvasSurface and moves all of its functionality to HTMLCanvasElement.
​https://bugs.webkit.org/show_bug.cgi?id=42005

​http://trac.webkit.org/changeset/55201 introduced a new base class for HTMLCanvasElement called CanvasSurface.
The intention was that this would allow for code sharing with the then-proposed OffscreenCanvas. However,
there is no OffscreenCanvas and there's unlikely to be one soon. Additionally CanvasSurface breaks
encapsulation pretty badly by doing "static_cast<HTMLCanvasElement* const>(this)". Until an abstraction is
really needed we should just use HTMLCanvasElement when we want to talk about a canvas.

This patch moves all of CanvasSurface's functionality back up to HTMLCanvasElement and reorders the header
to be a bit more logical.

Refactor with no behavior change, thus no new tests.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CanvasSurface.cpp: Removed.
  • dom/CanvasSurface.h: Removed.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): (WebCore::HTMLCanvasElement::willDraw): (WebCore::HTMLCanvasElement::setSurfaceSize): (WebCore::HTMLCanvasElement::toDataURL): (WebCore::HTMLCanvasElement::convertLogicalToDevice): (WebCore::HTMLCanvasElement::securityOrigin): (WebCore::HTMLCanvasElement::styleSelector): (WebCore::HTMLCanvasElement::createImageBuffer): (WebCore::HTMLCanvasElement::drawingContext): (WebCore::HTMLCanvasElement::buffer): (WebCore::HTMLCanvasElement::baseTransform):
  • html/HTMLCanvasElement.h: (WebCore::HTMLCanvasElement::setObserver): (WebCore::HTMLCanvasElement::width): (WebCore::HTMLCanvasElement::height): (WebCore::HTMLCanvasElement::size): (WebCore::HTMLCanvasElement::toDataURL): (WebCore::HTMLCanvasElement::setOriginTainted): (WebCore::HTMLCanvasElement::originClean): (WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
6:25 PM Changeset in webkit [63024] by oliver@apple.com
  • 6 edits in trunk/JavaScriptCore

Tidy up lexer token ids
​https://bugs.webkit.org/show_bug.cgi?id=42014

Reviewed by Darin Adler

Stop using character literals to identify single character tokens
and instead use symbolic names for all tokens.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::makeBinaryNode):

  • parser/JSParser.cpp:

(JSC::JSParser::consume):
(JSC::JSParser::match):
(JSC::JSParser::autoSemiColon):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::allowAutomaticSemicolon):
(JSC::JSParser::parseDoWhileStatement):
(JSC::JSParser::parseWhileStatement):
(JSC::JSParser::parseVarDeclarationList):
(JSC::JSParser::parseConstDeclarationList):
(JSC::JSParser::parseForStatement):
(JSC::JSParser::parseReturnStatement):
(JSC::JSParser::parseWithStatement):
(JSC::JSParser::parseSwitchStatement):
(JSC::JSParser::parseSwitchClauses):
(JSC::JSParser::parseSwitchDefaultClause):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseDebuggerStatement):
(JSC::JSParser::parseStatement):
(JSC::JSParser::parseFormalParameters):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseExpressionOrLabelStatement):
(JSC::JSParser::parseIfStatement):
(JSC::JSParser::parseExpression):
(JSC::JSParser::parseAssignmentExpression):
(JSC::JSParser::parseConditionalExpression):
(JSC::isUnaryOp):
(JSC::JSParser::isBinaryOperator):
(JSC::JSParser::parseBinaryExpression):
(JSC::JSParser::parseProperty):
(JSC::JSParser::parseObjectLiteral):
(JSC::JSParser::parseStrictObjectLiteral):
(JSC::JSParser::parseArrayLiteral):
(JSC::JSParser::parsePrimaryExpression):
(JSC::JSParser::parseArguments):
(JSC::JSParser::parseMemberExpression):
(JSC::JSParser::parseUnaryExpression):

  • parser/JSParser.h:

(JSC::):

  • parser/Lexer.cpp:

(JSC::):
(JSC::Lexer::lex):

  • parser/Lexer.h:
6:24 PM Changeset in webkit [63023] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

Bug 42015 - Enable JSValue32_64 on ARMv7

Reviewed by Oliver Hunt.

  • Configurations/JavaScriptCore.xcconfig:
  • jit/JIT.h:
  • jit/JITStubs.cpp:
  • wtf/Platform.h:
6:17 PM Changeset in webkit [63022] by Simon Fraser
  • 15 edits in trunk

2010-07-09 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Calling layoutTestController.layerTreeAsText() should update layout
​https://bugs.webkit.org/show_bug.cgi?id=41818

Need to call updateLayout() before we check for any layers, not after,
since layout will update compositing, and may create layers.

  • page/Frame.cpp: (WebCore::Frame::layerTreeAsText):
6:16 PM Changeset in webkit [63021] by mrowe@apple.com
  • 14 edits in branches/safari-533.17-branch

Merge r62451.

6:14 PM Changeset in webkit [63020] by abarth@webkit.org
  • 11 edits in trunk/WebKitTools

2010-07-09 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

r63004 broke some python tests
​https://bugs.webkit.org/show_bug.cgi?id=42007

AbstractStep now checks options.no_squash and options.squash, so
they needed to have real values. Mock would return an object for those,
which would then act as if the values were True.

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
5:56 PM Changeset in webkit [63019] by mrowe@apple.com
  • 7 edits in branches/safari-533.17-branch/WebKit/win

Merge r62365.

5:54 PM Changeset in webkit [63018] by mrowe@apple.com
  • 10 edits in branches/safari-533.17-branch

Merge r62284.

5:47 PM Changeset in webkit [63017] by kbr@google.com
  • 3 edits
    2 adds in trunk

2010-07-09 Kenneth Russell <​kbr@google.com>

Reviewed by Nate Chapin.

bufferSubData causes crash in WebGLBuffer::associateBufferSubData
​https://bugs.webkit.org/show_bug.cgi?id=42004

Test: fast/canvas/webgl/index-validation-crash-with-buffer-sub-data.html

  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferData):
    • Allocate m_elementArrayBuffer for entry point taking only size. Guard against allocation failures of m_elementArrayBuffer.

(WebCore::WebGLBuffer::associateBufferSubData):

  • Guard against any possibility of crashes due to m_elementArrayBuffer being NULL.

2010-07-09 Kenneth Russell <​kbr@google.com>

Reviewed by Nate Chapin.

bufferSubData causes crash in WebGLBuffer::associateBufferSubData
​https://bugs.webkit.org/show_bug.cgi?id=42004

  • fast/canvas/webgl/index-validation-crash-with-buffer-sub-data-expected.txt: Added.
  • fast/canvas/webgl/index-validation-crash-with-buffer-sub-data.html: Added.
5:34 PM Changeset in webkit [63016] by kbr@google.com
  • 3 edits
    2 adds in trunk

2010-07-09 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Assertion failure in String::utf8() for certain invalid UTF16 inputs
​https://bugs.webkit.org/show_bug.cgi?id=41983

  • wtf/text/WTFString.cpp: (WebCore::String::utf8):
    • Fixed assertion when sourceExhausted is returned from convertUTF16ToUTF8.

2010-07-09 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Assertion failure in String::utf8() for certain invalid UTF16 inputs
​https://bugs.webkit.org/show_bug.cgi?id=41983

  • fast/canvas/webgl/invalid-UTF-16-expected.txt: Added.
  • fast/canvas/webgl/invalid-UTF-16.html: Added.
5:13 PM Changeset in webkit [63015] by mrowe@apple.com
  • 10 edits
    4 adds in branches/safari-533.17-branch

Merge r59338.

5:11 PM Changeset in webkit [63014] by dumi@chromium.org
  • 6 edits in trunk/WebCore

Unreviewed, but pre-approved by Eric Seidel.

Remove unnecessary includes in header files in WebCore/css.
​https://bugs.webkit.org/show_bug.cgi?id=41941

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontFaceSource.h:
  • css/CSSPrimitiveValueMappings.h:
  • css/StyleMedia.h:
4:23 PM Changeset in webkit [63013] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Get rid of manual case maps in HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=42000

No functional change, thus no tests.

  • html/HTMLTreeBuilder.cpp:
4:13 PM Changeset in webkit [63012] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61645.

4:10 PM Changeset in webkit [63011] by tonyg@chromium.org
  • 7 edits in trunk

2010-07-09 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Implement performance.timing.navigationStart
​https://bugs.webkit.org/show_bug.cgi?id=41815

  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-expected.txt:

2010-07-09 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Implement performance.timing.navigationStart
​https://bugs.webkit.org/show_bug.cgi?id=41815

See: ​http://dev.w3.org/2006/webapi/WebTiming/#nt-navigation-start

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader):
  • loader/FrameLoaderTypes.h: (WebCore::FrameLoadTimeline::FrameLoadTimeline):
  • page/Timing.cpp: (WebCore::Timing::navigationStart):
4:05 PM Changeset in webkit [63010] by ajwong@chromium.org
  • 2 edits
    102 adds in trunk/LayoutTests

Unreviewed. Build fix.

[chromium] Add in baseline for ietestcenter tests that pass. Also
rebaseline two other tests.

  • platform/chromium-mac/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/11.4.1-4.a-10-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/11.4.1-4.a-8-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.12.1.1-0-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.12.1.1-0-3-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.12.2-0-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.12.3-0-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-0-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-0-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.10-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-0-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-0-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-0-3-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-10-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-11-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-12-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-13-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-14-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-15-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-16-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-17-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-18-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-19-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-2-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-20-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-21-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-3-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-4-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-5-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-6-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-7-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-8-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.13-2-9-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.14-2-4-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.14-3-4-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.3-4-22-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.3-4-25-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.2.3.6-4-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.14-9-a-12-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-3-26-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-3-27-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-12-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-14-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-16-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-5-4-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-8-9-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.4.4.15-8-a-12-expected.txt: Added.
  • platform/chromium-win/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/11.4.1-4.a-10-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/11.4.1-4.a-8-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.12.1.1-0-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.12.1.1-0-3-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.12.2-0-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.12.3-0-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.10-0-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.10-0-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.10-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.10-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-0-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-0-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-0-3-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-10-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-11-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-12-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-13-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-14-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-15-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-16-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-17-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-18-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-19-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-2-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-20-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-21-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-3-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-4-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-5-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-6-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-7-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-8-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.13-2-9-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.14-2-4-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.14-3-4-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.3-4-22-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.3-4-25-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.2.3.6-4-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.14-9-a-12-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-3-26-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-3-27-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-12-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-14-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-16-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-5-4-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-8-9-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.4.4.15-8-a-12-expected.txt: Added.
4:05 PM Changeset in webkit [63009] by ajwong@chromium.org
  • 6 edits in trunk/LayoutTests/platform

2010-07-09 Albert J. Wong <​ajwong@chromium.org>

Reviewed by NOBODY (OOPS!).

Need a short description and bug URL (OOPS!)

  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-win/http/tests/plugins/plugin-document-has-focus-expected.txt:
  • platform/chromium-win/plugins/keyboard-events-expected.txt:
  • platform/chromium/test_expectations.txt:
4:02 PM Changeset in webkit [63008] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.17-branch

Merge r61801.

3:55 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
3:54 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
3:54 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
3:53 PM Changeset in webkit [63007] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-533.17-branch/LayoutTests

Merge r61721.

3:53 PM Changeset in webkit [63006] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61707.

3:52 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
3:44 PM Changeset in webkit [63005] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.17-branch

Merge r61424.

3:43 PM Changeset in webkit [63004] by ojan@chromium.org
  • 22 edits
    1 delete in trunk/WebKitTools

2010-07-09 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

--squash should go away and become the default
​https://bugs.webkit.org/show_bug.cgi?id=39624

If there are local commits and working copy changes, then prompt the user
whether to continue. Setting git config webkit-patch.commit_should_always_squash
true bypasses the prompt.

--git-commit=HEAD.. operates on working copy changes only.
--git-commit=committish operates on a range of commits as a single commit.

e.g. --git-commit=HEAD only operates on the HEAD commit.
--git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.

--no-squash and --squash are left in with descriptive error messages if used.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/common/net/rietveld.py:
  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/style/optparser.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
  • Scripts/webkitpy/tool/steps/commit.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
3:29 PM Changeset in webkit [63003] by eric@webkit.org
  • 4 edits in trunk

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix SVG tag name casing for HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=41998

  • html5lib/runner-expected-html5.txt:

2010-07-09 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayerQt must have syncCompositingStateForThisLayerOnly() implemented
​https://bugs.webkit.org/show_bug.cgi?id=41954

Add GraphicsLayerQt::syncCompositingStateForThisLayerOnly, a non-recursive
implementation of GraphicsLayerQt::syncCompositingState and which targets
the current layer only.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::syncCompositingStateForThisLayerOnly):
  • platform/graphics/qt/GraphicsLayerQt.h:
3:26 PM Changeset in webkit [63002] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Versioning.

3:21 PM Changeset in webkit [63001] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-07-09 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayerQt must have syncCompositingStateForThisLayerOnly() implemented
​https://bugs.webkit.org/show_bug.cgi?id=41954

Add GraphicsLayerQt::syncCompositingStateForThisLayerOnly, a non-recursive
implementation of GraphicsLayerQt::syncCompositingState and which targets
the current layer only.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::syncCompositingStateForThisLayerOnly):
  • platform/graphics/qt/GraphicsLayerQt.h:
3:07 PM Changeset in webkit [63000] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Handle setting of drawing and event models
​https://bugs.webkit.org/show_bug.cgi?id=41994

Reviewed by Sam Weinig and Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

Handle NPPVpluginDrawingModel and NPPVpluginEventModel.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_inNPPNew.

(WebKit::NetscapePlugin::~NetscapePlugin):
Assert that we aren't still running.

(WebKit::NetscapePlugin::fromNPP):
New function that returns a NetscapePlugin object given a NPP pointer.

(WebKit::NetscapePlugin::initialize):

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.cpp:

(WebKit::NetscapePlugin::setDrawingModel):
Set the drawing model.

(WebKit::NetscapePlugin::setEventModel):
Set the event model.

(WebKit::initializeEvent):
(WebKit::NetscapePlugin::platformPaint):
Only send the Cocoa event when using the Cocoa event model.

2:58 PM Changeset in webkit [62999] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Add two new Windows test build slaves.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
2:52 PM Changeset in webkit [62998] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 David Kozub <​zub@linux.fjfi.cvut.cz>

Reviewed by Darin Adler.

Fix build by adding missing html/TimeRanges.idl to CMakeLists.txt.

​https://bugs.webkit.org/show_bug.cgi?id=41945

No functional changes, thus no tests.

  • CMakeLists.txt:
2:32 PM Changeset in webkit [62997] by ajwong@chromium.org
  • 2 edits in trunk/WebKitTools

Reviewed by David Levin.

rebaseline_chromium_webkit_tests missing --use_drt option on linux
​https://bugs.webkit.org/show_bug.cgi?id=41985

This adds in the --use_drt option for rebaseline_chromium_webkit_tests
so that it works on linux. This is essentially a "compile-fix" for the
script.

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2:32 PM Changeset in webkit [62996] by weinig@apple.com
  • 18 edits in trunk/WebKit2

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=41971
Add really basic BackForwardList support.

Reviewed by Anders Carlsson.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:

(WebPageMessage::):
Add new message kind.

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

(WebPageProxyMessage::):
Add new message kinds. Remove DidChangeCanGoBack and DidChangeCanGoForward.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGoToBackForwardListItem):

  • UIProcess/API/C/WKPage.h:

Add function to initiate a navigation to a BackForward item. The
BackForward list will be updated to use this as the current item
asynchronously.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::addItem): Added.
(WebKit::WebBackForwardList::goToItem): Added.
(WebKit::WebBackForwardList::itemAtIndex): Added.
(WebKit::WebBackForwardList::backListCount): Changed to return int matching WebCore.
(WebKit::WebBackForwardList::forwardListCount): Ditto.
(WebKit::WebBackForwardList::backListWithLimit): Add cast to int.
(WebKit::WebBackForwardList::forwardListWithLimit): Ditto.
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit): Ditto.
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit): Ditto.

  • UIProcess/WebBackForwardList.h:
  • UIProcess/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::WebBackForwardListItem):

  • UIProcess/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::itemID):
Added itemID.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::canGoForward):
(WebKit::WebPageProxy::canGoBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
(WebKit::WebPageProxy::addItemToBackForwardList):
(WebKit::WebPageProxy::goToItemInBackForwardList):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:
  • Removed m_canGoBack and m_canGoForward booleans and instead use the BackForwardList.
  • Forward goToBackForwardItem to the WebProcess.
  • Respond to messages from the WebBackForwardListProxy in the WebProcess, forwarding to the WebBackForwardList.
  • WebProcess/WebCoreSupport/WebBackForwardControllerClient.cpp:

(WebKit::WebBackForwardControllerClient::createBackForwardList):
Start using a WebBackForwardListProxy instead of a BackForwardListImpl.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidAddBackForwardItem):
(WebKit::WebFrameLoaderClient::dispatchDidRemoveBackForwardItem):
(WebKit::WebFrameLoaderClient::dispatchDidChangeBackForwardIndex):
Remove calls backForwardListDidChange() now that we communicate much more
information than just this state.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::idToHistoryItemMap):
(WebKit::historyItemToIDMap):
(WebKit::generateHistoryItemID):
(WebKit::getIDForHistoryItem):
(WebKit::WebBackForwardListProxy::itemForID):
Add leaking cached maps of HistoryItems to IDs, the life time of these
objects will be improved in a subsequent patch.

(WebKit::WebBackForwardListProxy::WebBackForwardListProxy):
(WebKit::WebBackForwardListProxy::addItem):
(WebKit::WebBackForwardListProxy::goBack):
(WebKit::WebBackForwardListProxy::goForward):
(WebKit::WebBackForwardListProxy::goToItem):
(WebKit::WebBackForwardListProxy::backItem):
(WebKit::WebBackForwardListProxy::currentItem):
(WebKit::WebBackForwardListProxy::forwardItem):
(WebKit::WebBackForwardListProxy::itemAtIndex):
(WebKit::WebBackForwardListProxy::backListWithLimit):
(WebKit::WebBackForwardListProxy::forwardListWithLimit):
(WebKit::WebBackForwardListProxy::capacity):
(WebKit::WebBackForwardListProxy::setCapacity):
(WebKit::WebBackForwardListProxy::enabled):
(WebKit::WebBackForwardListProxy::setEnabled):
(WebKit::WebBackForwardListProxy::backListCount):
(WebKit::WebBackForwardListProxy::forwardListCount):
(WebKit::WebBackForwardListProxy::containsItem):
(WebKit::WebBackForwardListProxy::close):
(WebKit::WebBackForwardListProxy::closed):
(WebKit::WebBackForwardListProxy::removeItem):
(WebKit::WebBackForwardListProxy::entries):
(WebKit::WebBackForwardListProxy::pushStateItem):

  • WebProcess/WebPage/WebBackForwardListProxy.h:

Forward functions to the UIProcess.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::goToBackForwardItem):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:

Respond to GoToBackForwardItem message.

  • mac/WebKit2.exp: Add new API function.
2:24 PM Changeset in webkit [62995] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-07-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Remove a couple of excess writes from the lexer
​https://bugs.webkit.org/show_bug.cgi?id=41981

Remove a couple of fields from JSTokenInfo, and rename the remaining ones
to something more accurate

  • parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::tokenStart): (JSC::JSParser::tokenLine): (JSC::JSParser::tokenEnd):
  • parser/JSParser.h: (JSC::JSTokenInfo::JSTokenInfo):
  • parser/Lexer.cpp: (JSC::Lexer::lex):
2:21 PM Changeset in webkit [62994] by eric@webkit.org
  • 5 edits in trunk

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement SVG attribute case mapping for HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=41949

Update results now that we pass 3 more tests.

  • html5lib/runner-expected-html5.txt:

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement SVG attribute case mapping for HTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=41949

Tested by html5lib/runner.html.

  • html/HTMLTreeBuilder.cpp:
2:18 PM MathML 3 testsuite results edited by François Sausset
(diff)
2:18 PM Changeset in webkit [62993] by andersca@apple.com
  • 6 edits
    1 add in trunk/WebKit2

Verify drawing coordinates, add crude painting support
​https://bugs.webkit.org/show_bug.cgi?id=41984

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:

Add NetscapePluginMac.cpp.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize drawing and event models.

(WebKit::NetscapePlugin::initialize):
Call platformPostInitialize.

(WebKit::NetscapePlugin::destroy):
Call NPP_Destroy.

(WebKit::NetscapePlugin::paint):
Call platformPaint.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add member functions.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.cpp: Added.

(WebKit::NetscapePlugin::platformPostInitialize):
Set default event and drawing models and verify that they are compatible.

(WebKit::NetscapePlugin::platformPaint):
Send a paint event (assuming the Cocoa event model currently).

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::paint):
Change the paint rect to be in window coordinates.

(WebKit::PluginView::viewGeometryDidChange):
(WebKit::PluginView::clipRectInWindowCoordinates):

  • WebProcess/Plugins/PluginView.h:
2:04 PM Changeset in webkit [62992] by aestes@apple.com
  • 2 edits in trunk/WebCore

2010-07-09 Andy Estes <​aestes@apple.com>

Reviewed by Adele Peterson.

Remove the workaround for a Core Animation bug on platforms where the
bug has been fixed.
​https://bugs.webkit.org/show_bug.cgi?id=41927
<rdar://problem/7920153>

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): Add a compile-time check for platforms that have a Core Animation bug that needs working around.
1:50 PM Changeset in webkit [62991] by thakis@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-09 Nico Weber <​thakis@chromium.org>

Unreviewed. Adding myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
1:49 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
1:47 PM MathML 3 testsuite results edited by François Sausset
(diff)
1:40 PM Changeset in webkit [62990] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Revert "<​http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"

This reverts commit r62692.

  • Scripts/commit-log-editor:
1:38 PM Changeset in webkit [62989] by kinuko@chromium.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-07-08 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
​https://bugs.webkit.org/show_bug.cgi?id=38693

Introduced a new base class JSONResultsGeneratorBase that doesn't
have any dependency on layout_tests packages.
Turned JSONResultsGenerator into a wrapper class of the base class
so that the old code can work with it during the cleanup.

Added json_results_generator_unittest.py.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
1:32 PM Changeset in webkit [62988] by xji@chromium.org
  • 4 edits
    9 adds in trunk/LayoutTests

2010-07-09 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Levin.

Rebaseline bidi-mirror-he-ar.html and bidi-neutral-run.html for Chromium after r62965
​https://bugs.webkit.org/show_bug.cgi?id=41974

  • platform/chromium-linux/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/chromium-linux/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-linux/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:29 PM Changeset in webkit [62987] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/AudioDestinationNode.idl

add AudioDestinationNode.idl

1:29 PM Changeset in webkit [62986] by crogers@google.com
  • 1 edit in branches/audio/WebCore/DerivedSources.make

Make sure derived sources get updated to new naming for AudioDestinationNode

1:29 PM Changeset in webkit [62985] by crogers@google.com
  • 9 edits
    10 moves in branches/audio/WebCore

Change name from AudioOutputNode to AudioDestinationNode

  • this avoids overloading the term 'output' which is also used to refer to a specific output of an AudioNode
  • this makes the naming more symmetric:
  • input <--> output (inputs and outputs to AudioNodes)
  • source <--> destination (source nodes and destination node)
1:25 PM MathML 3 testsuite results edited by François Sausset
(diff)
1:16 PM Changeset in webkit [62984] by tonyg@chromium.org
  • 9 edits
    3 adds in trunk

2010-07-08 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Nate Chapin.

Implement unloadEventEnd, loadEventStart, and loadEventEnd for Web Timing
​https://bugs.webkit.org/show_bug.cgi?id=41332

Expectations are set to FAIL because disabled by default. Passes with --web-timing.

  • fast/dom/script-tests/webtiming.js: Added. (sleepFiftyMilliseconds): (shouldBeGreaterThanOrEqual): (checkTimingBeforeLoad): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-expected.txt: Added.
  • fast/dom/webtiming.html: Added.

2010-07-08 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Nate Chapin.

Implement unloadEventEnd, loadEventStart, and loadEventEnd for Web Timing
​https://bugs.webkit.org/show_bug.cgi?id=41332

Test: fast/dom/webtiming.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::loadWithDocumentLoader):
  • loader/FrameLoader.h: (WebCore::FrameLoader::frameLoadTimeline):
  • loader/FrameLoaderTypes.h: (WebCore::FrameLoadTimeline::FrameLoadTimeline):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
  • page/Timing.cpp: (WebCore::Timing::navigationStart): (WebCore::Timing::unloadEventEnd): (WebCore::Timing::loadEventStart): (WebCore::Timing::loadEventEnd):
  • page/Timing.h:
  • page/Timing.idl:
1:15 PM MathML 3 testsuite results edited by François Sausset
(diff)
1:13 PM Changeset in webkit [62983] by inferno@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-09 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Marking myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
1:11 PM CommitterTips edited by thakis@chromium.org
mention sheriffbot for rollouts (diff)
1:05 PM Changeset in webkit [62982] by aa@chromium.org
  • 3 edits in trunk/LayoutTests

2010-07-09 Aaron Boodman <​aa@chromium.org>

Reviewed by Ojan Vafai.

Fix regression from r62876.
​https://bugs.webkit.org/show_bug.cgi?id=41928

  • platform/mac/Skipped:
  • printing/page-rule-selection.html:
12:53 PM Changeset in webkit [62981] by thakis@chromium.org
  • 5 edits in trunk/LayoutTests

2010-07-09 Nico Weber <​thakis@chromium.org>

Reviewed by Simon Fraser.
​https://bugs.webkit.org/show_bug.cgi?id=41580

Fix layout test to be smaller in y direction. Also add explanatory text.

  • fast/gradients/radial-centered.html: Make divs display:inline-block.
12:45 PM MathML 3 testsuite results edited by François Sausset
(diff)
12:45 PM Changeset in webkit [62980] by Darin Adler
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Updated for recent changes.
12:36 PM Changeset in webkit [62979] by xji@chromium.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

2010-07-09 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Levin.

Rebaseline bidi-mirror-he-ar.html for leopard and snowleopard.
​https://bugs.webkit.org/show_bug.cgi?id=41974

  • platform/mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/mac-snowleopard/platform/mac/fast/text: Removed.
  • platform/mac-snowleopard/platform/mac/fast/text/international: Removed.
  • platform/mac-snowleopard/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
12:04 PM Changeset in webkit [62978] by dumi@chromium.org
  • 5 edits in trunk/WebCore

Unreviewed, but pre-approved by Eric Seidel.

Remove all unnecessary includes from the header files in WebCore/accessibility/.
​https://bugs.webkit.org/show_bug.cgi?id=41941

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityListBox.cpp:
  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityMenuList.h:
  • accessibility/mac/AccessibilityObjectWrapper.h:
12:00 PM Changeset in webkit [62977] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed

[chromium] upstreaming expectations from chromium.

  • platform/chromium/test_expectations.txt:
11:54 AM Changeset in webkit [62976] by crogers@google.com
  • 9 edits in branches/audio/WebCore/audio

Make an AudioContext contain an AudioListener, and remove from AudioPanner

  • all panners will now implicitly use the listener from the context
11:52 AM Changeset in webkit [62975] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, build fix.

[chromium] Update test expecations for failing tests.

  • platform/chromium/test_expectations.txt:
11:52 AM MathML 3 testsuite results edited by François Sausset
(diff)
11:51 AM Changeset in webkit [62974] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Buildfix for EventHandlerWin
​https://bugs.webkit.org/show_bug.cgi?id=41909

Use Clipboard.h instead of ClipboardWin.h on WinCE.

  • page/win/EventHandlerWin.cpp:
11:46 AM MathML 3 testsuite results edited by François Sausset
(diff)
11:43 AM Changeset in webkit [62973] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Pass a clip rect to the plugin and call NPP_SetWindow
​https://bugs.webkit.org/show_bug.cgi?id=41969

Reviewed by Sam Weinig.

  • WebProcess/Plugins/DummyPlugin.cpp:

(WebKit::DummyPlugin::geometryDidChange):

  • WebProcess/Plugins/DummyPlugin.h:

Add clip rect parameter.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_npWindow.

(WebKit::NetscapePlugin::callSetWindow):
Call NPP_SetWindow.

(WebKit::NetscapePlugin::initialize):
Set the window type to NPWindowTypeDrawable for now.

(WebKit::NetscapePlugin::geometryDidChange):
Update the frame and clip rects and call NPP_SetWindow.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add an NPWindow member variable.

  • WebProcess/Plugins/Plugin.h:

Add a clipRect parameter to geometryDidChange.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Add the plug-in element to the constructor.

(WebKit::PluginView::viewGeometryDidChange):
Compute the clip rect and pass it to the plug-in.

  • WebProcess/Plugins/PluginView.h:

(WebKit::PluginView::create):
Pass the plug-in element to the constructor.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Pass the plug-in element to PluginView::create.

11:38 AM MathML 3 testsuite results edited by François Sausset
(diff)
11:36 AM Changeset in webkit [62972] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r62946.
​http://trac.webkit.org/changeset/62946
​https://bugs.webkit.org/show_bug.cgi?id=41965

AppCache inspector support should be enabled in WebKit ToT.
(Requested by pfeldman_ on #webkit).

11:31 AM MathML 3 testsuite results edited by François Sausset
(diff)
11:26 AM Changeset in webkit [62971] by crogers@google.com
  • 1 edit in branches/audio/WebCore/WebCore.xcodeproj/project.pbxproj

Remove some more obsolete files from WebCore.xcodeproj

11:26 AM Changeset in webkit [62970] by crogers@google.com
  • 12 deletes in branches/audio/WebCore/audio

Remove obsolete files: AudioEffect, AudioMixer, AudioSource, BiquadFilter, RealtimeAnalyser.idl, SendPoint.h

11:26 AM Changeset in webkit [62969] by crogers@google.com
  • 18 edits in branches/audio/WebCore

Get rid of use of obsolete files: AudioEffect, AudioMixer, AudioSource, BiquadFilter, SendPoint, RealtimeAnalyser.idl

11:22 AM Changeset in webkit [62968] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

2010-07-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Test for the newly implemented MathML mathcolor & mathbackground attributes
​https://bugs.webkit.org/show_bug.cgi?id=41895

  • mathml/presentation/attributes.xhtml: Added.
  • platform/mac/mathml/presentation/attributes-expected.checksum: Added.
  • platform/mac/mathml/presentation/attributes-expected.png: Added.
  • platform/mac/mathml/presentation/attributes-expected.txt: Added.

2010-07-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Implement MathML mathcolor & mathbackground attributes
​https://bugs.webkit.org/show_bug.cgi?id=41895

Test: mathml/presentation/attributes.xhtml

  • dom/MappedAttributeEntry.h: (WebCore::):
  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement): (WebCore::MathMLElement::mapToEntry): (WebCore::MathMLElement::parseMappedAttribute):
  • mathml/MathMLElement.h:
  • mathml/mathattrs.in:
11:19 AM MathML 3 testsuite results created by François Sausset
11:11 AM Changeset in webkit [62967] by mitz@apple.com
  • 270 edits in trunk/LayoutTests

Set the svn:mime-type property of recently-added PNG files to image/png.

10:53 AM Changeset in webkit [62966] by vitalyr@chromium.org
  • 26 edits in trunk/LayoutTests

2010-07-09 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Updating expectations.

  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/chromium-win/svg/batik/text/textLength-expected.txt:
  • platform/chromium-win/svg/carto.net/button-expected.txt:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.txt:
  • platform/chromium-win/svg/carto.net/combobox-expected.txt:
  • platform/chromium-win/svg/carto.net/slider-expected.txt:
  • platform/chromium-win/svg/carto.net/textbox-expected.txt:
  • platform/chromium-win/svg/carto.net/window-expected.txt:
  • platform/chromium-win/svg/custom/animate-path-morphing-expected.txt:
  • platform/chromium-win/svg/custom/coords-relative-units-transforms-expected.txt:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
  • platform/chromium-win/svg/custom/pattern-rotate-expected.txt:
  • platform/chromium-win/svg/custom/text-rotated-gradient-expected.txt:
  • platform/chromium-win/svg/custom/use-detach-expected.txt:
  • platform/chromium-win/svg/custom/use-font-face-crash-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/chromium-win/svg/custom/use-property-changes-through-svg-dom-expected.txt:
  • platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-transform-expected.txt:
  • platform/chromium-win/svg/hixie/text/003b-expected.txt:
  • platform/chromium-win/svg/text/foreignObject-repaint-expected.txt:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
10:28 AM Changeset in webkit [62965] by xji@chromium.org
  • 5 edits
    8 adds in trunk

2010-07-09 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Levin.

Fix characters with unicode-bidi-mirror property are not correctly
mirrored in Linux.
​https://bugs.webkit.org/show_bug.cgi?id=41305

Since harfbuzz does not do mirroring, chromium should iterate each
character in the string and mirror it if needed before passing the
string to harfbuzz for shaping.

Test: fast/text/international/bidi-mirror-he-ar.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::mirrorCharacters):

2010-07-09 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Levin.

Fix characters with unicode-bidi-mirror property are not correctly
mirrored in Linux.
​https://bugs.webkit.org/show_bug.cgi?id=41305

Since harfbuzz does not do mirroring, chromium should iterate each
character in the string and mirror it if needed before passing the
string to harfbuzz for shaping.

  • fast/text/international/bidi-mirror-he-ar.html: Added.
  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac-snowleopard/platform/mac/fast/text: Added.
  • platform/mac-snowleopard/platform/mac/fast/text/international: Added.
  • platform/mac-snowleopard/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/mac-tiger/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
10:14 AM Changeset in webkit [62964] by andersca@apple.com
  • 9 edits in trunk

Instantiate Netscape plug-ins, pass geometry information to Plugin
​https://bugs.webkit.org/show_bug.cgi?id=41960

Reviewed by Simon Fraser.

WebCore:

  • WebCore.exp.in:

Export ScrollView::contentsToWindow.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

Handle NPNVsupportsCoreGraphicsBool and NPNVsupportsCocoaBool.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Set npp.ndata.

(WebKit::NetscapePlugin::initialize):
Try to instantiate the plug-in by calling NPP_New.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Store the NetscapePluginModule and the NPP struct.

  • WebProcess/Plugins/Netscape/NetscapePluginModule.h:

Add a getter for the NPPluginFuncs vtable.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::frameRectsChanged):
Make sure to call viewGeometryDidChange.

(WebKit::PluginView::setParent):
Ditto.

(WebKit::PluginView::viewGeometryDidChange):
Convert the frame rect to window coordinates and pass it to the plug-in.

  • WebProcess/Plugins/PluginView.h:

Add function declarations.

10:12 AM Changeset in webkit [62963] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Buildfix for FrameWince after r47440
​https://bugs.webkit.org/show_bug.cgi?id=41904

  • page/wince/FrameWince.cpp: Added property svn:eol-style. (WebCore::computePageRectsForFrame): (WebCore::imageFromSelection):
10:06 AM Changeset in webkit [62962] by vitalyr@chromium.org
  • 2 edits in trunk/WebCore

2010-07-09 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Pavel Feldman.

[v8] Call JS gc in a fresh context to avoid retaining the current one.
​https://bugs.webkit.org/show_bug.cgi?id=41963
​http://crbug.com/46571

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::collectGarbage):
9:48 AM MathML edited by François Sausset
(diff)
9:43 AM Changeset in webkit [62961] by kbr@google.com
  • 6 edits in trunk

2010-07-09 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Crash with uniform array test
​https://bugs.webkit.org/show_bug.cgi?id=36028

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
    • Fixed type tests and casting of incoming arrays.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform):
    • Fixed crash when null WebGLUniform is passed to getUniform.

2010-07-09 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Crash with uniform array test
​https://bugs.webkit.org/show_bug.cgi?id=36028

  • fast/canvas/webgl/gl-uniform-arrays-expected.txt:
    • Updated test expectations.
  • fast/canvas/webgl/gl-uniform-arrays.html:
    • Separated calling wrong uniform*fv entry point from calling with non-array.
9:24 AM Changeset in webkit [62960] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: text editing not spoken by VO on web view contenteditable textbox
​https://bugs.webkit.org/show_bug.cgi?id=41912

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/selection-value-changes-for-aria-textbox.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::renderObjectIsObservable):

LayoutTests:

  • platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt: Added.
  • platform/mac/accessibility/selection-value-changes-for-aria-textbox.html: Added.
9:14 AM Changeset in webkit [62959] by diegohcg@webkit.org
  • 3 edits in trunk/WebKit2

2010-07-08 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WebKit2] Make QWKPage call _q_webActionTriggered as a private slot
​https://bugs.webkit.org/show_bug.cgi?id=41880

  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/qwkpage.h:
9:05 AM Changeset in webkit [62958] by vitalyr@chromium.org
  • 256 edits
    23 adds
    11 deletes in trunk/LayoutTests

2010-07-09 Vitaly Repeshko <​vitalyr@chromium.org>

Unreviewed.

[chromium] Updating expectations.

  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.txt:
  • platform/chromium-linux/svg/batik/text/textOnPath-expected.txt:
  • platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/stroke-width-large-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/001-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/002-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/007-expected.txt:
  • platform/chromium-linux/svg/hixie/text/003a-expected.txt:
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/chromium-linux/svg/text/selection-doubleclick-expected.txt:
  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt: Added.
  • platform/chromium-mac/plugins/clicking-missing-plugin-fires-delegate-expected.txt: Added.
  • platform/chromium-mac/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-evenodd-expected.txt: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/chromium-mac/svg/custom/createelement-expected.txt:
  • platform/chromium-mac/svg/custom/junk-data-expected.txt:
  • platform/chromium-mac/svg/custom/missing-xlink-expected.txt:
  • platform/chromium-mac/svg/custom/repaint-moving-svg-and-div-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/repaint-moving-svg-and-div-expected.png: Added.
  • platform/chromium-mac/userscripts/user-script-top-frame-only-expected.txt: Added.
  • platform/chromium-mac/userscripts/user-style-top-frame-only-expected.txt: Added.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt: Added.
  • platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt: Added.
  • platform/chromium-win/plugins/clicking-missing-plugin-fires-delegate-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor2-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor3-expected.txt:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
  • platform/chromium-win/svg/batik/text/textDecoration2-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath2-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath3-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/chromium-win/svg/batik/text/textPCDATA-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
  • platform/chromium-win/svg/batik/text/textStyles-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalText-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium-win/svg/carto.net/scrollbar-expected.txt:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-evenodd-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-text-and-stroke-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-text-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/chromium-win/svg/css/group-with-shadow-expected.txt:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.txt:
  • platform/chromium-win/svg/custom/SVGMatrix-interface-expected.txt:
  • platform/chromium-win/svg/custom/SVGPoint-matrixTransform-expected.txt:
  • platform/chromium-win/svg/custom/alignment-baseline-modes-expected.txt:
  • platform/chromium-win/svg/custom/altglyph-expected.txt:
  • platform/chromium-win/svg/custom/circle-move-invalidation-expected.txt:
  • platform/chromium-win/svg/custom/clip-path-referencing-use-expected.txt:
  • platform/chromium-win/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
  • platform/chromium-win/svg/custom/container-opacity-clip-viewBox-expected.txt:
  • platform/chromium-win/svg/custom/createImageElement2-expected.txt:
  • platform/chromium-win/svg/custom/createelement-expected.txt:
  • platform/chromium-win/svg/custom/dominant-baseline-modes-expected.txt:
  • platform/chromium-win/svg/custom/empty-clip-path-expected.txt:
  • platform/chromium-win/svg/custom/empty-mask-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/chromium-win/svg/custom/fill-fallback-expected.txt:
  • platform/chromium-win/svg/custom/focus-ring-expected.txt:
  • platform/chromium-win/svg/custom/font-face-cascade-order-expected.txt:
  • platform/chromium-win/svg/custom/font-face-simple-expected.txt:
  • platform/chromium-win/svg/custom/foreignObject-crash-on-hover-expected.txt:
  • platform/chromium-win/svg/custom/getTransformToElement-expected.txt:
  • platform/chromium-win/svg/custom/gradient-cycle-detection-expected.txt:
  • platform/chromium-win/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/chromium-win/svg/custom/hit-test-unclosed-subpaths-expected.txt:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.txt:
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/chromium-win/svg/custom/invalid-css-expected.txt:
  • platform/chromium-win/svg/custom/invalid-fill-expected.txt:
  • platform/chromium-win/svg/custom/invalid-fill-hex-expected.txt:
  • platform/chromium-win/svg/custom/invalid-lengthlist-expected.txt:
  • platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-clipPath-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.txt:
  • platform/chromium-win/svg/custom/junk-data-expected.txt:
  • platform/chromium-win/svg/custom/marker-default-width-height-expected.txt:
  • platform/chromium-win/svg/custom/marker-overflow-clip-expected.txt:
  • platform/chromium-win/svg/custom/mask-invalidation-expected.txt:
  • platform/chromium-win/svg/custom/missing-xlink-expected.txt:
  • platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
  • platform/chromium-win/svg/custom/path-bad-data-expected.txt:
  • platform/chromium-win/svg/custom/path-textPath-simulation-expected.txt:
  • platform/chromium-win/svg/custom/pattern-cycle-detection-expected.txt:
  • platform/chromium-win/svg/custom/pattern-deep-referencing-expected.txt:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.txt:
  • platform/chromium-win/svg/custom/pointer-events-image-expected.txt:
  • platform/chromium-win/svg/custom/pointer-events-path-expected.txt:
  • platform/chromium-win/svg/custom/pointer-events-text-expected.txt:
  • platform/chromium-win/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/chromium-win/svg/custom/repaint-moving-svg-and-div-expected.checksum: Added.
  • platform/chromium-win/svg/custom/repaint-moving-svg-and-div-expected.png: Added.
  • platform/chromium-win/svg/custom/second-inline-text-expected.txt:
  • platform/chromium-win/svg/custom/shape-rendering-expected.txt:
  • platform/chromium-win/svg/custom/shapes-supporting-markers-expected.txt:
  • platform/chromium-win/svg/custom/stroke-fallback-expected.txt:
  • platform/chromium-win/svg/custom/stroke-width-large-expected.txt:
  • platform/chromium-win/svg/custom/stroked-pattern-expected.txt:
  • platform/chromium-win/svg/custom/style-attribute-font-size-expected.txt:
  • platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/chromium-win/svg/custom/svg-float-border-padding-expected.txt:
  • platform/chromium-win/svg/custom/text-clip-expected.txt:
  • platform/chromium-win/svg/custom/text-ctm-expected.txt:
  • platform/chromium-win/svg/custom/text-decoration-visibility-expected.txt:
  • platform/chromium-win/svg/custom/text-filter-expected.txt:
  • platform/chromium-win/svg/custom/text-hit-test-expected.txt:
  • platform/chromium-win/svg/custom/text-image-opacity-expected.txt:
  • platform/chromium-win/svg/custom/text-letter-spacing-expected.txt:
  • platform/chromium-win/svg/custom/text-linking-expected.txt:
  • platform/chromium-win/svg/custom/text-repaint-including-stroke-expected.txt:
  • platform/chromium-win/svg/custom/text-whitespace-handling-expected.txt:
  • platform/chromium-win/svg/custom/text-x-dx-lists-expected.txt:
  • platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.txt:
  • platform/chromium-win/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/chromium-win/svg/custom/text-xy-updates-expected.txt:
  • platform/chromium-win/svg/custom/tref-update-expected.txt:
  • platform/chromium-win/svg/custom/use-clipped-hit-expected.txt:
  • platform/chromium-win/svg/custom/use-dynamic-append-expected.txt:
  • platform/chromium-win/svg/custom/use-elementInstance-event-target-expected.txt:
  • platform/chromium-win/svg/custom/use-elementInstance-methods-expected.txt:
  • platform/chromium-win/svg/custom/use-event-handler-on-referenced-element-expected.txt:
  • platform/chromium-win/svg/custom/use-event-handler-on-use-element-expected.txt:
  • platform/chromium-win/svg/custom/use-events-crash-expected.txt:
  • platform/chromium-win/svg/custom/use-instanceRoot-modifications-expected.txt:
  • platform/chromium-win/svg/custom/use-modify-container-in-target-expected.txt:
  • platform/chromium-win/svg/custom/use-modify-target-container-expected.txt:
  • platform/chromium-win/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/chromium-win/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-on-g-containing-use-expected.txt:
  • platform/chromium-win/svg/custom/use-on-g-expected.txt:
  • platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/chromium-win/svg/custom/use-on-rect-expected.txt:
  • platform/chromium-win/svg/custom/use-on-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-win/svg/custom/use-on-text-expected.txt:
  • platform/chromium-win/svg/custom/use-on-use-expected.txt:
  • platform/chromium-win/svg/custom/use-property-changes-through-dom-expected.txt:
  • platform/chromium-win/svg/custom/use-recursion-1-expected.txt:
  • platform/chromium-win/svg/custom/use-recursion-2-expected.txt:
  • platform/chromium-win/svg/custom/use-recursion-3-expected.txt:
  • platform/chromium-win/svg/custom/use-recursion-4-expected.txt:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/chromium-win/svg/custom/viewbox-syntax-expected.txt:
  • platform/chromium-win/svg/custom/viewport-em-expected.txt:
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
  • platform/chromium-win/svg/filters/feComposite-expected.txt:
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
  • platform/chromium-win/svg/filters/filter-width-update-expected.txt:
  • platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
  • platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/chromium-win/svg/hixie/data-types/002-expected.txt:
  • platform/chromium-win/svg/hixie/dynamic/002-expected.txt:
  • platform/chromium-win/svg/hixie/error/002-expected.txt:
  • platform/chromium-win/svg/hixie/error/010-expected.txt:
  • platform/chromium-win/svg/hixie/error/011-expected.txt:
  • platform/chromium-win/svg/hixie/error/012-expected.txt:
  • platform/chromium-win/svg/hixie/error/013-expected.txt:
  • platform/chromium-win/svg/hixie/error/017-expected.txt:
  • platform/chromium-win/svg/hixie/links/002-expected.txt:
  • platform/chromium-win/svg/hixie/links/003-broken-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/003-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/004-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/005-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/011-expected.txt:
  • platform/chromium-win/svg/hixie/perf/001-expected.txt:
  • platform/chromium-win/svg/hixie/perf/002-expected.txt:
  • platform/chromium-win/svg/hixie/perf/007-expected.txt:
  • platform/chromium-win/svg/hixie/shapes/path/001-expected.txt:
  • platform/chromium-win/svg/hixie/text/002-expected.txt:
  • platform/chromium-win/svg/hixie/text/003a-expected.txt:
  • platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/chromium-win/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
  • platform/chromium-win/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/chromium-win/svg/text/kerning-expected.txt:
  • platform/chromium-win/svg/text/multichar-glyph-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-1-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-2-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-3-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-4-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/chromium-win/svg/text/selection-background-color-expected.txt:
  • platform/chromium-win/svg/text/selection-doubleclick-expected.txt:
  • platform/chromium-win/svg/text/selection-styles-expected.txt:
  • platform/chromium-win/svg/text/selection-tripleclick-expected.txt:
  • platform/chromium-win/svg/text/text-gradient-positioning-expected.txt:
  • platform/chromium-win/svg/text/text-repaint-rects-expected.txt:
  • platform/chromium-win/svg/text/textPathBoundsBug-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
  • platform/chromium-win/transforms/svg-vs-css-expected.txt:
  • platform/chromium-win/userscripts/user-script-top-frame-only-expected.txt: Added.
  • platform/chromium-win/userscripts/user-style-top-frame-only-expected.txt: Added.
8:55 AM Changeset in webkit [62957] by commit-queue@webkit.org
  • 11 edits
    3 adds in trunk

2010-07-09 Michael Nordman <Michael Nordman>

Reviewed by Dumitru Daniliuc.

Add a layout test to verify the expected number of progress events are raised by the appcache,
and that those events have properly set 'lengthComputable', 'loaded', and 'total' attributes.
Also update a couple of other tests that depend on counting the number of progress events to
determine success or failure to now expect the additional final progress event that is being
raised.
​https://bugs.webkit.org/show_bug.cgi?id=37602

  • http/tests/appcache/foreign-iframe-main-expected.txt:
  • http/tests/appcache/progress-counter-expected.txt: Added.
  • http/tests/appcache/progress-counter.html: Added.
  • http/tests/appcache/resources/different-https-origin-resource.html:
  • http/tests/appcache/resources/progress-counter.manifest: Added.

2010-07-09 Michael Nordman <Michael Nordman>

Reviewed by Dumitru Daniliuc.

Use class ProgressEvent when raising appcache related progress events and
set the 'total', 'loaded', and 'lengthComputable' attributes.
Also raise the final progress event with the 'total' and 'loaded' attribute
values are equal to one another to keep pace with the spec for this feature.
​https://bugs.webkit.org/show_bug.cgi?id=37602

Test: http/tests/appcache/progress-counter.html

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::CallCacheListenerTask::create): (WebCore::CallCacheListenerTask::performTask): (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask):
  • loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::postListenerTask):
  • loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): (WebCore::ApplicationCacheHost::stopDeferringEvents): (WebCore::ApplicationCacheHost::dispatchDOMEvent):
  • loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::DeferredEvent::DeferredEvent):

2010-07-09 Michael Nordman <Michael Nordman>

Reviewed by Dumitru Daniliuc.

Use class ProgressEvent when raising appcache related progress events and
set the 'total', 'loaded', and 'lengthComputable' attributes.
Also raise the final progress event with the 'total' and 'loaded' attribute
values are equal to one another to keep pace with the spec for this feature.
​https://bugs.webkit.org/show_bug.cgi?id=37602

  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): (WebCore::ApplicationCacheHost::stopDeferringEvents): (WebCore::ApplicationCacheHost::dispatchDOMEvent):
  • src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::notifyEventListener): (WebCore::ApplicationCacheHostInternal::notifyProgressEventListener):
8:39 AM Changeset in webkit [62956] by commit-queue@webkit.org
  • 1 edit
    5 adds in trunk/WebKitTools

2010-07-09 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

Implement MiniBrowser for Qt.
​https://bugs.webkit.org/show_bug.cgi?id=40233

  • MiniBrowser/qt/BrowserWindow.cpp: Added. (createNewPage): (BrowserView::BrowserView): (BrowserView::resizeEvent): (BrowserView::load): (BrowserView::view): (BrowserWindow::BrowserWindow): (BrowserWindow::load): (BrowserWindow::changeLocation): (BrowserWindow::~BrowserWindow):
  • MiniBrowser/qt/BrowserWindow.h: Added. (BrowserView::~BrowserView):
  • MiniBrowser/qt/MiniBrowser.pro: Added.
  • MiniBrowser/qt/main.cpp: Added. (main):
8:26 AM Changeset in webkit [62955] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Sebastian Dröge <​sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha Silva.

Bug 41340 - [GStreamer] Subtle race condition during seeks
​https://bugs.webkit.org/show_bug.cgi?id=41340

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcStop): (webKitWebSrcNeedDataMainCb): (webKitWebSrcNeedDataCb): (webKitWebSrcEnoughDataMainCb): (webKitWebSrcEnoughDataCb): (webKitWebSrcSeekDataCb): (StreamingClient::didFinishLoading): Fix two subtle race conditions that can happen during seeks:
  • The timeout callback could be called before the callback ID is assigned to the instance private data. This causes the ID to be set after the callback has finished and breaks all future processing.
  • The source must not go EOS while a seek is pending because this confuses appsrc due to the different threads involved here.
8:06 AM Changeset in webkit [62954] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Removed hard-coded enabled default of video support

Reviewed by Tor Arne Vestbø.

Properly detect video/audio instead of defaulting to true.Properly detect video/audio instead of defaulting to true.Properly detect video/audio instead of defaulting to true.Properly detect video/audio instead of defaulting to true.

  • WebCore.pri:
7:59 AM Changeset in webkit [62953] by Simon Hausmann
  • 3 edits in trunk/WebCore

[Qt] Prospective build fix.

Reviewed by Tor Arne Vestbø.

Moved the media element detection from WebCore.pro into WebCore.pri, where
all the features are detected. This is also used by build-webkit to determine
the defaults, which may be the reason for the build breakage.

  • WebCore.pri:
  • WebCore.pro:
7:53 AM Changeset in webkit [62952] by benm@google.com
  • 3 edits
    2 adds in trunk

[Arm] Missing NaN check in XPath substring function
​https://bugs.webkit.org/show_bug.cgi?id=41862

Reviewed by Steve Block.

WebCore:

Test: fast/xpath/substring-nan-position.html

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunSubstring::evaluate): Add an isnan()

to the value returned from evaluating the position
argument and early out and return the empty string.

LayoutTests:

This layout test checks for the case described in the bug
and some related edge cases that do currently already pass
but only through a fluke.

  • fast/xpath/substring-nan-position-expected.txt: Added.
  • fast/xpath/substring-nan-position.html: Added.
7:47 AM Changeset in webkit [62951] by Simon Hausmann
  • 4 edits in trunk/WebCore

[Qt] Re-enable support for QtMultimediaKit as backend for the media elements

Reviewed by Tor Arne Vestbø.

Experimental support is re-enabled if QtMobility is available and the Qt
version is 4.7 or above.

  • WebCore.pro:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivate::supportsType): Adapt to latest QtMultimediaKit API changes.
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::totalBytes):

7:28 AM Changeset in webkit [62950] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-07-09 David Holloway <​dhollowa@chromium.org>

Reviewed by Dimitri Glazkov.

Roll Chromium DEPS forward to r51736.
​https://bugs.webkit.org/show_bug.cgi?id=41867

  • DEPS:
7:17 AM Changeset in webkit [62949] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-07-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not show default tooltip when detailed network info is available.

​https://bugs.webkit.org/show_bug.cgi?id=41957

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._getPopoverAnchor): (WebInspector.ResourcesPanel.prototype._showPopover): (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels):
7:11 AM Changeset in webkit [62948] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

2010-07-09 François Sausset <François Sausset>

Reviewed by Beth Dakin.

Add test to be sure that only <mi> elements use italic fonts by default.
Update test with fractions to take into account the correct behaviour of mtext (regular instead of italic).
​https://bugs.webkit.org/show_bug.cgi?id=41626

  • mathml/presentation/tokenElements.xhtml: Added.
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/tokenElements-expected.checksum: Added.
  • platform/mac/mathml/presentation/tokenElements-expected.png: Added.
  • platform/mac/mathml/presentation/tokenElements-expected.txt: Added.

2010-07-09 François Sausset <François Sausset>

Reviewed by Beth Dakin.

Correct the default font variant of mtext (regular instead of italic).
​https://bugs.webkit.org/show_bug.cgi?id=41626

Add test to be sure that only <mi> elements use italic fonts by default.
Update test with fractions to take into account the correct behaviour of mtext (regular instead of italic).

  • css/mathml.css: (mi):
6:58 AM Changeset in webkit [62947] by tonyg@chromium.org
  • 5 edits
    7 adds in trunk

2010-07-09 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Implement performance.navigation.type
​https://bugs.webkit.org/show_bug.cgi?id=41564

Expectations set to FAIL because disabled by default. Tests pass with --web-timing.

  • fast/dom/navigation-type-back-forward-expected.txt: Added.
  • fast/dom/navigation-type-back-forward.html: Added.
  • fast/dom/navigation-type-navigate-expected.txt: Added.
  • fast/dom/navigation-type-navigate.html: Added.
  • fast/dom/navigation-type-reload-expected.txt: Added.
  • fast/dom/navigation-type-reload.html: Added.
  • fast/dom/resources/navigation-type-matches-querystring.html: Added.

2010-07-09 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Implement performance.navigation.type
​https://bugs.webkit.org/show_bug.cgi?id=41564

Tests: fast/dom/navigation-type-back-forward.html

fast/dom/navigation-type-navigate.html
fast/dom/navigation-type-reload.html

  • page/Navigation.cpp: (WebCore::Navigation::type):
  • page/Navigation.h: (WebCore::Navigation::):
  • page/Navigation.idl:
6:45 AM Changeset in webkit [62946] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: hide AppCache until implemented.

​https://bugs.webkit.org/show_bug.cgi?id=41858

6:29 AM Changeset in webkit [62945] by commit-queue@webkit.org
  • 7 edits in trunk

2010-07-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Set the good default behaviour for the columalign attribute on MathML mtable element
​https://bugs.webkit.org/show_bug.cgi?id=41631

Test updated.

  • mathml/presentation/tables.xhtml:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:

2010-07-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Set the good default behaviour for the columalign attribute on MathML mtable element
​https://bugs.webkit.org/show_bug.cgi?id=41631

Test update: mathml/tables.xhtml

  • css/mathml.css: (math):
5:42 AM Changeset in webkit [62944] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

2010-07-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r62937.
​http://trac.webkit.org/changeset/62937
​https://bugs.webkit.org/show_bug.cgi?id=41955

Crashes SnowLeopard leaks and Windows debug bot in fast/xsl
/xslt-relative-path.xml, with assertion in
XSLTProcessorLibxslt.cpp:264 (Requested by WildFox on
#webkit).

  • xml/XSLTProcessor.h: (WebCore::XSLTProcessor::XSLTProcessor):
  • xml/XSLTProcessorLibxslt.cpp: (WebCore::docLoaderFunc): (WebCore::setXSLTLoadCallBack): (WebCore::xsltStylesheetPointer): (WebCore::XSLTProcessor::transformToString):
5:08 AM Changeset in webkit [62943] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Add mac-tiger specific results. That should mark the end of the journey.

  • platform/mac-tiger/svg/hixie/text/003-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003a-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
5:05 AM Changeset in webkit [62942] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-09 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium build fix.

  • public/WebGLES2Context.h:
5:02 AM Changeset in webkit [62941] by antti.j.koivisto@nokia.com
  • 2 edits in trunk/WebKit2

Build fix.

  • cmake/OptionsEfl.cmake:
4:51 AM Changeset in webkit [62940] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/WebKitTools

Introduce the Qt autotest launcher.

Patch by Jedrzej Nowacki <​jedrzej.nowacki@nokia.com> on 2010-07-09
Reviewed by Simon Hausmann.

Qt autotests should be executed more frequently, ideally by the Qt
build bot. This is the first step to provide the tests more accessible.

[Qt] It should be easier to run all Qt's autotests.
​https://bugs.webkit.org/show_bug.cgi?id=31625

  • Scripts/run-qtwebkit-tests: Added.
4:47 AM Changeset in webkit [62939] by yael.aharon@nokia.com
  • 11 edits in trunk

2010-07-09 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

NotificationPresenter needs a cancelRequestPermission API
​https://bugs.webkit.org/show_bug.cgi?id=41783

Updated NotificationPresenter API, to use ScriptExecutionContext instead of origin.
Added new API NotificationPresenter::cancelRequestsForPermision
The new API will be implemented and a test will be added in a followup patch.

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission): (WebCore::NotificationCenter::requestPermission): (WebCore::NotificationCenter::disconnectFrame):
  • notifications/NotificationCenter.h:
  • notifications/NotificationPresenter.h:

2010-07-09 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

NotificationPresenter needs a cancelRequestPermission API
​https://bugs.webkit.org/show_bug.cgi?id=41783

Updated the NotificationPresenter API.

  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission): (WebKit::NotificationPresenterImpl::requestPermission):
  • src/NotificationPresenterImpl.h: (WebKit::NotificationPresenterImpl::cancelRequestsForPermission):

2010-07-09 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

NotificationPresenter needs a cancelRequestPermission API
​https://bugs.webkit.org/show_bug.cgi?id=41783

Updated NotificationPresenter API to use ScriptExecutionContext instead of origin
and added a new NotificationPresenter::cancelRequestsForPermission API.
The new API will be implemented in a followup patch.

  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::requestPermission): (WebCore::NotificationPresenterClientQt::checkPermission): (WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
  • WebCoreSupport/NotificationPresenterClientQt.h:
4:34 AM Changeset in webkit [62938] by Nikolas Zimmermann
  • 21 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Hopefully last round of gtk specific results.

  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/gtk/svg/text/selection-background-color-expected.txt:
  • platform/gtk/svg/text/selection-doubleclick-expected.txt:
  • platform/gtk/svg/text/selection-styles-expected.txt:
  • platform/gtk/svg/text/selection-tripleclick-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/svg/zoom/text/relative-sized-document-scrollbars-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/transforms/svg-vs-css-expected.txt:
4:33 AM Changeset in webkit [62937] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-07-09 Andreas Wictor <​andreas.wictor@xcerion.com>

Reviewed by Alexey Proskuryakov.

Remove global variables from XSLTProcessorLibxslt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=41348

Remove the globalProcessor and globalDocLoader global variables
by using the _private field that exists on most libxml structs.

No new tests, existing tests covers this.

  • xml/XSLTProcessor.h: (WebCore::XSLTProcessor::sourceNode): (WebCore::XSLTProcessor::XSLTProcessor):
  • xml/XSLTProcessorLibxslt.cpp: (WebCore::registeredXSLTProcessors): (WebCore::registeredXSLStyleSheets): (WebCore::docLoaderFunc): (WebCore::clearSavedStyleSheetPointers): (WebCore::xsltStylesheetPointer): (WebCore::XSLTProcessor::transformToString):
4:20 AM Changeset in webkit [62936] by Nikolas Zimmermann
  • 11 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Next round of gtk specific results.

  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-4-expected.txt:
4:19 AM Changeset in webkit [62935] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-09 Adam Barth <​abarth@webkit.org>

Unreviewed build fix.

We recently taught the HTMLTokenizer to recognize self-closing tags,
<​http://trac.webkit.org/changeset/62926>, but that confused the
LegacyHTMLTreeBuilder. It turns out that it's much happier if we never
say a tag is self-closing.

  • html/HTMLTreeBuilder.cpp: (WebCore::convertToOldStyle):
4:08 AM Changeset in webkit [62934] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Last round of qt specific results.

  • platform/qt/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/qt/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/qt/fast/repaint/svg-layout-root-style-attr-update-expected.txt:
3:57 AM Changeset in webkit [62933] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Next round of win specific results.

  • platform/win/svg/custom/broken-internal-references-expected.txt:
  • platform/win/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/win/svg/filters/feColorMatrix-values-expected.txt:
3:54 AM Changeset in webkit [62932] by Csaba Osztrogonác
  • 84 edits in trunk/LayoutTests

[Qt] Update platform specific expected results after r62922.

Reviewed by Nikolas Zimmermann.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

  • platform/qt/svg/custom/js-update-image-and-display-expected.txt:
  • platform/qt/svg/custom/js-update-image-and-display2-expected.txt:
  • platform/qt/svg/custom/js-update-image-and-display3-expected.txt:
  • platform/qt/svg/custom/marker-opacity-expected.txt:
  • platform/qt/svg/custom/marker-referencePoint-expected.txt:
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
  • platform/qt/svg/custom/mask-invalidation-expected.txt:
  • platform/qt/svg/custom/mask-on-multiple-objects-expected.txt:
  • platform/qt/svg/custom/mask-with-default-value-expected.txt:
  • platform/qt/svg/custom/non-scaling-stroke-expected.txt:
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/qt/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
  • platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/qt/svg/custom/repaint-stroke-width-changes-expected.txt:
  • platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/qt/svg/custom/stroke-width-large-expected.txt:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/qt/svg/custom/text-zoom-expected.txt:
  • platform/qt/svg/custom/transformedMaskFails-expected.txt:
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feLighting-crash-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/filter-clip-expected.txt:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/filters/filter-source-position-expected.txt:
  • platform/qt/svg/filters/filteredImage-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
  • platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt:
  • platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt:
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt:
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.txt:
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/qt/svg/text/select-x-list-1-expected.txt:
  • platform/qt/svg/text/select-x-list-2-expected.txt:
  • platform/qt/svg/text/select-x-list-3-expected.txt:
  • platform/qt/svg/text/select-x-list-4-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/qt/svg/text/selection-background-color-expected.txt:
  • platform/qt/svg/text/selection-doubleclick-expected.txt:
  • platform/qt/svg/text/selection-styles-expected.txt:
  • platform/qt/svg/text/selection-tripleclick-expected.txt:
  • platform/qt/svg/text/text-hkern-expected.txt:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/qt/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.txt:
  • platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
3:51 AM Changeset in webkit [62931] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

svg/custom/use-instanceRoot-event-bubbling.xhtml test crashes
​https://bugs.webkit.org/show_bug.cgi?id=41931

Be careful to not mutate (marking it for recreation) the shadow tree, while building it.
The recent change that cloneNode() properly synchronizes the style/SVG attributes caused this problem.

Fixes crash seen on the buildbots in svg/custom/use-instanceRoot-event-bubbling.xhtml.

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::recalcStyle): (WebCore::SVGUseElement::buildShadowAndInstanceTree): (WebCore::SVGUseElement::invalidateShadowTree):
  • svg/SVGUseElement.h: (WebCore::SVGUseElement::setUpdatesBlocked):
3:47 AM Changeset in webkit [62930] by Nikolas Zimmermann
  • 13 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Next round of gtk specific results.

  • platform/gtk/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/gtk/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
3:40 AM Changeset in webkit [62929] by Nikolas Zimmermann
  • 9 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Next round of gtk specific results.

  • platform/gtk/svg/custom/text-zoom-expected.txt:
  • platform/gtk/svg/filters/feDisplacementMap-expected.txt:
  • platform/gtk/svg/filters/feLighting-crash-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt:
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
3:24 AM Changeset in webkit [62928] by abarth@webkit.org
  • 4 edits in trunk

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Skip leading newlines in <textarea>
​https://bugs.webkit.org/show_bug.cgi?id=41947

We would have caught this earlier with the ASSERT.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Skip leading newlines in <textarea>
​https://bugs.webkit.org/show_bug.cgi?id=41947

  • html5lib/runner-expected-html5.txt:
3:18 AM Changeset in webkit [62927] by pfeldman@chromium.org
  • 22 edits
    2 adds in trunk

2010-07-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Provide detailed network info in the resources panel.

​https://bugs.webkit.org/show_bug.cgi?id=40227

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::updateResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::buildObjectForTiming):
  • inspector/InspectorResource.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):

2010-07-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Provide detailed network info in the resources panel.

​https://bugs.webkit.org/show_bug.cgi?id=40227

  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebURLLoadTiming.h: Added. (WebKit::WebURLLoadTiming::~WebURLLoadTiming): (WebKit::WebURLLoadTiming::WebURLLoadTiming): (WebKit::WebURLLoadTiming::operator=): (WebKit::WebURLLoadTiming::isNull):
  • public/WebURLRequest.h:
  • public/WebURLResponse.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::willSendRequest):
  • src/WebDevToolsAgentImpl.h:
  • src/WebURLLoadTiming.cpp: Added. (WebKit::WebURLLoadTiming::initialize): (WebKit::WebURLLoadTiming::reset): (WebKit::WebURLLoadTiming::assign): (WebKit::WebURLLoadTiming::setDomainLookupTimes): (WebKit::WebURLLoadTiming::setConnectStartTime): (WebKit::WebURLLoadTiming::setRequestTimes): (WebKit::WebURLLoadTiming::setHeadersAvailableTime): (WebKit::WebURLLoadTiming::WebURLLoadTiming): (WebKit::WebURLLoadTiming::operator=): (WebKit::WebURLLoadTiming::operator PassRefPtr<ResourceLoadTiming>):
  • src/WebURLRequest.cpp: (WebKit::WebURLRequest::reportLoadTiming): (WebKit::WebURLRequest::setReportLoadTiming):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::setConnectionID): (WebKit::WebURLResponse::setLoadTiming):
3:10 AM Changeset in webkit [62926] by eric@webkit.org
  • 11 edits in trunk

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement self closing start tag state in the tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=41946

  • html5lib/runner-expected-html5.txt:
    • Yay progressions!

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Implement self closing start tag state in the tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=41946

Amazingly we got this far w/o needing self closing.
The LegacyHTMLTreeBuilder clearly uses the self-closing
state, but the fact that we never exposed it seems to
not have caused any test failures. Sad.

The new HTMLTreeBuilder only needs the self closing state
for foreign content mode (and a few parse error cases).

  • html/HTMLToken.h: (WebCore::HTMLToken::setSelfClosing):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
  • html/HTMLTreeBuilder.cpp: (WebCore::):
3:02 AM Changeset in webkit [62925] by Nikolas Zimmermann
  • 39 edits in trunk/LayoutTests

2010-07-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Update gtk/qt specific results, and 4 mac results I missed.

  • fast/repaint/svg-layout-root-style-attr-update-expected.txt:
  • platform/gtk/svg/css/shadow-and-opacity-expected.txt:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/custom/clip-path-id-changes-expected.txt:
  • platform/gtk/svg/custom/empty-mask-expected.txt:
  • platform/gtk/svg/custom/fill-opacity-hsl-expected.txt:
  • platform/gtk/svg/custom/fill-opacity-rgba-expected.txt:
  • platform/gtk/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt:
  • platform/gtk/svg/custom/marker-opacity-expected.txt:
  • platform/gtk/svg/custom/marker-referencePoint-expected.txt:
  • platform/gtk/svg/custom/mask-invalidation-expected.txt:
  • platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt:
  • platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/repaint-stroke-width-changes-expected.txt:
  • platform/gtk/svg/custom/stroke-width-large-expected.txt:
  • platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/mac/transforms/svg-vs-css-expected.txt:
  • platform/qt/svg/batik/text/textDecoration-expected.txt:
  • platform/qt/svg/css/arrow-with-shadow-expected.txt:
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/qt/svg/css/clippath-with-shadow-expected.txt:
  • platform/qt/svg/css/mask-with-shadow-expected.txt:
  • platform/qt/svg/css/path-with-shadow-expected.txt:
  • platform/qt/svg/css/shadow-and-opacity-expected.txt:
  • platform/qt/svg/css/shadow-with-large-radius-expected.txt:
  • platform/qt/svg/css/shadow-with-negative-offset-expected.txt:
  • platform/qt/svg/css/stars-with-shadow-expected.txt:
  • platform/qt/svg/custom/animation-currentColor-expected.txt:
  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/custom/clip-path-id-changes-expected.txt:
  • platform/qt/svg/custom/createImageElement-expected.txt:
  • platform/qt/svg/custom/createImageElement2-expected.txt:
  • platform/qt/svg/custom/empty-mask-expected.txt:
  • platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt:
2:57 AM Changeset in webkit [62924] by abarth@webkit.org
  • 5 edits in trunk

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Coalesce text nodes when foster parenting
​https://bugs.webkit.org/show_bug.cgi?id=41921

Yay test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Coalesce text nodes when foster parenting
​https://bugs.webkit.org/show_bug.cgi?id=41921

Introduces the notion of an AttachmentSite to the overall
HTMLConstructionSite. Maybe we should rename HTMLConstructionSite to
HTMLConstructionArea since we construct things all over the tree? :)

There's something wrong in the internal layering in this class, but I
can't quite see what it is. I added a FIXME for the some of the
symptoms.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): (WebCore::HTMLConstructionSite::attachAtSite): (WebCore::HTMLConstructionSite::insertTextNode): (WebCore::HTMLConstructionSite::findFosterSite): (WebCore::HTMLConstructionSite::fosterParent):
  • html/HTMLConstructionSite.h:
2:40 AM Changeset in webkit [62923] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue should merge to TOT when checkout needs update
​https://bugs.webkit.org/show_bug.cgi?id=41944

There are a bunch of different designs that are possible here. This
one merges to top of tree by cleaning out the working copy and
re-applying the patch. Once you decide to merge that way, you need to
decide who's going to retry. In this patch, we retry in the child
process instead of plumbing the failure reason to the master process.

This patch is difficult to test end-to-end, but hopefully it will work.
:)

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py:
  • Scripts/webkitpy/tool/multicommandtool.py:
  • Scripts/webkitpy/tool/multicommandtool_unittest.py:
2:30 AM Changeset in webkit [62922] by Nikolas Zimmermann
  • 477 edits
    4 adds in trunk

2010-07-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

RenderSVGRoot does not include border/padding in the repaint rect.
clippedOverflowRectForRepaint() was missing. Affects all DRT results,
as <svg> now gets properly sized.

Test: svg/custom/repaint-moving-svg-and-div.xhtml

  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates): (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
  • rendering/RenderSVGRoot.h:

2010-07-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGRoot does not include border/padding while repainting
​https://bugs.webkit.org/show_bug.cgi?id=41854

Update most textual results as <svg> now receives a proper size and location.
NOTE: This requires updating more platform specific results, after landing with the help of the buildbots.

  • platform/mac-leopard/svg/custom/junk-data-expected.txt: .... (stripped long list)
2:19 AM Changeset in webkit [62921] by Simon Hausmann
  • 6 edits in trunk/JavaScriptCore/qt

Implementation of the QScriptValue::propertyFlags function.

Patch by Jedrzej Nowacki <​jedrzej.nowacki@nokia.com> on 2010-07-09
Reviewed by Simon Hausmann.

The function returns the flags of a property with the given name,
using a given mode to resolve the property. This is a simple
implementation that is sufficient to test the QScriptValueIterator.

[Qt] QScriptValue API should have a property flag accessor.
​https://bugs.webkit.org/show_bug.cgi?id=41769

  • api/qscriptvalue.cpp:

(QScriptValue::propertyFlags):

  • api/qscriptvalue.h:
  • api/qscriptvalue_p.h:

(QScriptValuePrivate::propertyFlags):

  • tests/qscriptvalue/tst_qscriptvalue.cpp:

(tst_QScriptValue::propertyFlag_data):
(tst_QScriptValue::propertyFlag):

  • tests/qscriptvalue/tst_qscriptvalue.h:
2:18 AM Changeset in webkit [62920] by ajwong@chromium.org
  • 3 edits in trunk/WebCore

Add RuntimeEnabledFeatures::timeRangesEnabled() required by r62880

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=41935

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::timeRangesEnabled):

Add in timeRangesEnabled() implementation.

  • bindings/generic/RuntimeEnabledFeatures.h:

Add in timeRangesEnabled() declaration.

2:01 AM Changeset in webkit [62919] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add setInsertionMode setter in preparation for "in foreign content" mode
​https://bugs.webkit.org/show_bug.cgi?id=41942

"in foreign content" mode needs to be able to use a fake
insertion mode for processing. We need to be able to save the
original insertion mode, set a fake one, and then restore the original
if it wasn't changed. To detect changes, we need all callsites to
use a setInsertionMode accessor instead of m_insertionMode =

No functional changes, thus no tests.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup): (WebCore::HTMLTreeBuilder::processStartTagForInTable): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): (WebCore::HTMLTreeBuilder::setInsertionModeAndEnd): (WebCore::HTMLTreeBuilder::processEndTagForInTableBody): (WebCore::HTMLTreeBuilder::processEndTagForInCell): (WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption): (WebCore::HTMLTreeBuilder::processTrEndTagForInRow): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processDefaultForInTableTextMode): (WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag): (WebCore::HTMLTreeBuilder::processGenericRawTextStartTag): (WebCore::HTMLTreeBuilder::processScriptStartTag):
1:53 AM Changeset in webkit [62918] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, build fix.

plugins/return-negative-one-from-write.html times out after r62739.
Marking as skip.

  • platform/chromium/test_expectations.txt:
1:35 AM Changeset in webkit [62917] by dumi@chromium.org
  • 1 edit
    1 add in trunk/WebKitTools

Add a script to check for unnecessary includes in header files.
​https://bugs.webkit.org/show_bug.cgi?id=41894

Reviewed by Darin Adler.

  • Scripts/check-header-includes: Added.
1:26 AM Changeset in webkit [62916] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add insertForeignElement in preparation for adding "in foreign content" support
​https://bugs.webkit.org/show_bug.cgi?id=41940

No functional changes, thus no tests.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertForeignElement): (WebCore::HTMLConstructionSite::createElement): (WebCore::HTMLConstructionSite::createHTMLElement):
  • html/HTMLConstructionSite.h:
1:13 AM Changeset in webkit [62915] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add --html5-treebuilder option to run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=41922

We're down to one or two regressions in the HTML5lib test suite. It's
getting to be time to look at fixing LayoutTests.

  • Scripts/old-run-webkit-tests:
1:11 AM Changeset in webkit [62914] by abarth@webkit.org
  • 5 edits in trunk

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implementing pending table characters
​https://bugs.webkit.org/show_bug.cgi?id=41916

This turned out to not be as scary as I thought it would be.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processDoctypeToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::processDefaultForInTableTextMode):
  • html/HTMLTreeBuilder.h:

2010-07-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implementing pending table characters
​https://bugs.webkit.org/show_bug.cgi?id=41916

This doesn't quite fix all the tests, but it fixes a bunch of them.

  • html5lib/runner-expected-html5.txt:
1:09 AM Changeset in webkit [62913] by kent.hansen@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-07-09 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Skip test that never terminates on maemo5

Due to ​https://bugs.webkit.org/show_bug.cgi?id=38538
the tst_QWebPage::infiniteLoopJS() autotest never terminates.
Skip the test so that the test case may run to completion.

Patch by Dominik Holland <​dominik.holland@nokia.com>

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::infiniteLoopJS):
1:08 AM Changeset in webkit [62912] by abarth@webkit.org
  • 9 edits in trunk

2010-07-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Handle whitespace correctly
​https://bugs.webkit.org/show_bug.cgi?id=41907

This patch introduces an extra memcpy in the character token pipeline.
I'll remove the memcpy in a future patch.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode):
  • html/HTMLConstructionSite.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCharacter):
  • html/HTMLTreeBuilder.h:

2010-07-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Handle whitespace correctly
​https://bugs.webkit.org/show_bug.cgi?id=41907

Update expectations to show massive progression.

  • html5lib/resources/doctype01.dat:
    • When I created this test, I set the expectations incorrectly. The new expectations now match the spec and Minefield.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
1:02 AM Changeset in webkit [62911] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move more mode handling into functions for later re-use
​https://bugs.webkit.org/show_bug.cgi?id=41939

No functional changes, thus no tests.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInTableBody): (WebCore::HTMLTreeBuilder::processEndTagForInRow): (WebCore::HTMLTreeBuilder::processEndTagForInCell): (WebCore::HTMLTreeBuilder::processEndTag):
  • html/HTMLTreeBuilder.h:
12:56 AM QtWebKitWeeklyBuilds edited by Simon Hausmann
(diff)
12:51 AM Changeset in webkit [62910] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Unreviewed trivial Symbian build fix.

[Qt] Fix the Symbian build when compiling without S60

Use Q_OS_SYMBIAN instead of Q_WS_S60 for the user agent
determination.

  • Api/qwebpage.cpp:

(QWebPage::userAgentForUrl):

12:48 AM Changeset in webkit [62909] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add new popUntilPopped functions to clean up code
​https://bugs.webkit.org/show_bug.cgi?id=41936

Pretty self explanatory. Much awesome code reduction.

No functional changes, thus no tests.

  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::popUntilPopped):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption): (WebCore::HTMLTreeBuilder::processTableEndTagForInTable): (WebCore::HTMLTreeBuilder::processEndTag):
12:44 AM Changeset in webkit [62908] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fixed Qt symbian/linux-armcc mkspec when configured with -qtlibinfix.

Patch by Kristian Amlie <​kristian.amlie@nokia.com> on 2010-07-09
Reviewed by Simon Hausmann.

  • declarative/declarative.pro: Use QT_LIBINFIX.
12:35 AM Changeset in webkit [62907] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Unreviewed. Just renaming (discussed with Adam Barth).

Rename createElement* to createHTMLElement* to better reflect
behavior. This is in preparation for adding foreign content support.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::createHTMLElementAndAttachToCurrent): (WebCore::HTMLConstructionSite::insertHTMLHtmlElement): (WebCore::HTMLConstructionSite::insertHTMLHeadElement): (WebCore::HTMLConstructionSite::insertHTMLBodyElement): (WebCore::HTMLConstructionSite::insertHTMLElement): (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement): (WebCore::HTMLConstructionSite::createHTMLElement):
  • html/HTMLConstructionSite.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
12:30 AM Changeset in webkit [62906] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-07-09 Eric Seidel <​eric@webkit.org>

Unreviewed. Just renaming (discussed with Adam Barth).

Rename insertElement to insertHTMLElement and
insertSelfClosingElement to insertSelfClosingHTMLElement
to better reflect what they actually do. This is in preparation
for adding foreign content support.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertHTMLElement): (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement): (WebCore::HTMLConstructionSite::insertFormattingElement): (WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements): (WebCore::HTMLConstructionSite::fosterParent):
  • html/HTMLConstructionSite.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTagForInTable): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): (WebCore::HTMLTreeBuilder::processStartTagForInHead): (WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag): (WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
12:27 AM Changeset in webkit [62905] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed fix.

[Qt] Add platform specific expected file after r62889.
This test say it passes if doesn't crash. It passes, but
Qt has an extra newline character in its expected file.

  • platform/qt/editing/inserting/return-key-in-hidden-field-expected.txt: Added.
12:22 AM Changeset in webkit [62904] by rwlbuis@webkit.org
  • 5 edits
    2 adds in trunk

2010-07-08 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Eric Seidel.

Implement SVGSVGElement.getElementById
​https://bugs.webkit.org/show_bug.cgi?id=41655

Implement getElementById for SVGSVGElement by trying to
reuse Document.getElementById. If that fails to find an
SVG element in the document fragent do a subtree search.

Test: svg/custom/svg-getelementid.xhtml

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getElementById):
  • svg/SVGSVGElement.h:
  • svg/SVGSVGElement.idl:
12:11 AM Changeset in webkit [62903] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-07-09 Anders Bakken <​agbakken@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Remove superfluous function calls
​https://bugs.webkit.org/show_bug.cgi?id=40353

QWebFrame::setUrl() calls ensureAbsoluteUrl() twice. It's better to
store a local variable and reuse this one.

QWebFrame::load(QUrl) calls QWebFrame::load(QNetworkRequest) which in
turn will get the QUrl from the request and make sure it's absolute by
calling ensureAbsoluteUrl() on it.

  • Api/qwebframe.cpp: (QWebFrame::setUrl): (QWebFrame::load):
Note: See TracTimeline for information about the timeline view.