Timeline



Sep 23, 2010:

11:45 PM Changeset in webkit [68238] by hyatt@apple.com
  • 32 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46451

Reviewed by Sam Weinig.

Rename calcWidth to computeLogicalWidth. Rename calcHeight to computeLogicalHeight.

  • rendering/RenderApplet.cpp:

(WebCore::RenderApplet::layout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::getClearDelta):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::calcPercentageHeight):
(WebCore::RenderBox::calcReplacedHeightUsing):
(WebCore::RenderBox::availableHeightUsing):
(WebCore::RenderBox::calcAbsoluteHorizontal):

  • rendering/RenderBox.h:

(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::layout):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderForeignObject.cpp:

(WebCore::RenderForeignObject::computeLogicalWidth):
(WebCore::RenderForeignObject::computeLogicalHeight):

  • rendering/RenderForeignObject.h:
  • rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::canvasSizeChanged):

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::computeLogicalHeight):
(WebCore::RenderIFrame::computeLogicalWidth):
(WebCore::RenderIFrame::layout):

  • rendering/RenderIFrame.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):

  • rendering/RenderIndicator.cpp:

(WebCore::RenderIndicator::layout):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computeLogicalHeight):

  • rendering/RenderListBox.h:
  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::computeLogicalWidth):
(WebCore::RenderMeter::computeLogicalHeight):

  • rendering/RenderMeter.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::layout):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):

  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeLogicalWidth):

  • rendering/RenderTableCell.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeLogicalHeight):

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::textBlockWidth):
(WebCore::RenderTextControlSingleLine::decorationWidthRight):
(WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):
(WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):

  • rendering/RenderView.cpp:

(WebCore::RenderView::computeLogicalHeight):
(WebCore::RenderView::computeLogicalWidth):

  • rendering/RenderView.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::svgAttributeChanged):

11:24 PM Changeset in webkit [68237] by Csaba Osztrogonác
  • 11 edits in trunk/JavaScriptCore

2010-09-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68223.
http://trac.webkit.org/changeset/68223
https://bugs.webkit.org/show_bug.cgi?id=46448

It broke 2-3 tests on bots (Requested by Ossy on #webkit).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::registerFor): (JSC::BytecodeGenerator::constRegisterFor): (JSC::BytecodeGenerator::emitNewFunction):
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_func): (JSC::JIT::emit_op_init_arguments):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_new_func): (JSC::JIT::emit_op_init_arguments):
  • parser/Nodes.h:
11:05 PM Changeset in webkit [68236] by dino@apple.com
  • 13 edits in trunk

2010-09-23 Hans Wennborg <hans@chromium.org>

Reviewed by Simon Fraser.

Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344

The spec has changed: the DeviceMotionEvent attributes accelerationX,
accelerationY, etc. have been baked into an 'acceleration' attribute
which returns an object with x, y, and z values. Likewise for the
rotation rate. The 'accelerationIncludingGravity' attribute is new.

  • WebCore.exp.in: The DeviceMotionData::create member function has changed. Also export create functions for DeviceMotionData::Acceleration and RotationRate.
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::acceleration): (WebCore::JSDeviceMotionEvent::accelerationIncludingGravity): (WebCore::JSDeviceMotionEvent::rotationRate): (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent): Manually create and return objects with the right attributes for acceleration, accelerationIncludingGravity, and rotationRate. When creating the DeviceMotionData object in initDeviceMotionEvent, accept any input objects that have the right attributes.
  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::accelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter): (WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback): V8 counterpart to the JSC code above.
  • dom/DeviceMotionData.cpp: (WebCore::DeviceMotionData::Acceleration::create): (WebCore::DeviceMotionData::Acceleration::Acceleration): (WebCore::DeviceMotionData::RotationRate::create): (WebCore::DeviceMotionData::RotationRate::RotationRate): (WebCore::DeviceMotionData::create): (WebCore::DeviceMotionData::DeviceMotionData):
  • dom/DeviceMotionData.h: (WebCore::DeviceMotionData::Acceleration::canProvideX): (WebCore::DeviceMotionData::Acceleration::canProvideY): (WebCore::DeviceMotionData::Acceleration::canProvideZ): (WebCore::DeviceMotionData::Acceleration::x): (WebCore::DeviceMotionData::Acceleration::y): (WebCore::DeviceMotionData::Acceleration::z): (WebCore::DeviceMotionData::RotationRate::canProvideAlpha): (WebCore::DeviceMotionData::RotationRate::canProvideBeta): (WebCore::DeviceMotionData::RotationRate::canProvideGamma): (WebCore::DeviceMotionData::RotationRate::alpha): (WebCore::DeviceMotionData::RotationRate::beta): (WebCore::DeviceMotionData::RotationRate::gamma): (WebCore::DeviceMotionData::acceleration): (WebCore::DeviceMotionData::accelerationIncludingGravity): (WebCore::DeviceMotionData::rotationRate): Add member classes Acceleration and RotationRate to DeviceMotionData.
  • dom/DeviceMotionEvent.idl: Update according to the spec. Acceleration and RotationRate need not be backed by native classes.

2010-09-23 Hans Wennborg <hans@chromium.org>

Reviewed by Simon Fraser.

Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344

  • fast/dom/DeviceMotion/script-tests/create-event.js:
  • fast/dom/DeviceMotion/create-event-expected.txt: Look for the new attributes.
  • fast/dom/DeviceMotion/script-tests/optional-event-properties.js:
  • fast/dom/DeviceMotion/optional-event-properties-expected.txt: Test the new attributes.
  • fast/dom/script-tests/prototype-inheritance.js: DeviceMotionEvent is not implemented on all platforms, so it should be skipped in this test.
10:43 PM Changeset in webkit [68235] by Csaba Osztrogonác
  • 4 edits in trunk/WebKit2

Unreviewed buildfix after r68220 on WebKit2.

WebKit2 API: Need way to know when a frame is removed from the hierarchy
https://bugs.webkit.org/show_bug.cgi?id=46432

[Qt] qt_wk_didRemoveFrameFromHierarchy needs to be implemented

  • UIProcess/API/qt/ClientImpl.cpp:

(qt_wk_didRemoveFrameFromHierarchy):

  • UIProcess/API/qt/ClientImpl.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

9:28 PM Changeset in webkit [68234] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-23 Tony Chang <tony@chromium.org>

Unreviewed, rolling out r68232.
http://trac.webkit.org/changeset/68232

Broken NRWT on the canary bots.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
9:17 PM Changeset in webkit [68233] by Simon Fraser
  • 11 edits
    8 adds in trunk

2010-09-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Accelerated transitions do not suspend/resume properly.
https://bugs.webkit.org/show_bug.cgi?id=43792

Fix suspending of accelerated transitions.

GraphicsLayer changes unify the handling of transitions and animations
in GraphicsLayer. Both are now identified by name, so the code
now refers to "animationName" rather than "keyframesName". Transitions
use a dummy name which is not a valid keyframe identifier.

Tests: animations/suspend-transform-animation.html

transitions/suspend-transform-transition.html

  • page/animation/ImplicitAnimation.h:
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::pauseAnimation): Call down to the RenderLayerBacking to tell it that an accelerated transition was paused.
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::animationNameForTransition): Create a name for the transition of the given property. (WebCore::GraphicsLayer::addAnimation): Generalize "keyframe" to "animation" in the parameter names. (WebCore::GraphicsLayer::pauseAnimation): ditto (WebCore::GraphicsLayer::removeAnimation): ditto
  • platform/graphics/mac/GraphicsLayerCA.h: Parameter renaming, and some method renames for clarity. (WebCore::GraphicsLayerCA::animationIsRunning): (WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation): struct rename for clarity.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::animationIdentifier): the animationName already has the property baked in. (WebCore::GraphicsLayerCA::moveOrCopyLayerAnimation): just deals with one animation now. (WebCore::GraphicsLayerCA::moveOrCopyAnimationsForProperty): we have to trawl through m_runningAnimations to get the identifiers for the animations that need to be copied. (WebCore::GraphicsLayerCA::addAnimation): rename parameters. (WebCore::GraphicsLayerCA::pauseAnimation): re-ordered methods here. member var renames. (WebCore::GraphicsLayerCA::removeAnimation): ditto. (WebCore::GraphicsLayerCA::updateLayerAnimations): no need to iterate over m_transitionPropertiesToRemove, and no more divergence between transitions and animations. (WebCore::GraphicsLayerCA::setCAAnimationOnLayer): renames for clarity. (WebCore::GraphicsLayerCA::removeCAAnimationFromLayer): ditto (WebCore::GraphicsLayerCA::pauseCAAnimationOnLayer): ditto (WebCore::GraphicsLayerCA::createAnimationFromKeyframes): renames (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): renames (WebCore::GraphicsLayerCA::suspendAnimations): whitespace.
  • rendering/RenderLayerBacking.h: Group the transition and animation methods together.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::animationPaused): Re-ordered methods for clarity. (WebCore::RenderLayerBacking::animationFinished): ditto (WebCore::RenderLayerBacking::startTransition): Use animationNameForTransition() to generate the animation identifier. (WebCore::RenderLayerBacking::transitionPaused): Call pauseAnimation, using animationNameForTransition() to generate the animation identifier. (WebCore::RenderLayerBacking::transitionFinished): Call removeAnimation, using animationNameForTransition() to generate the animation identifier. (WebCore::RenderLayerBacking::notifyAnimationStarted): Moved. (WebCore::RenderLayerBacking::notifySyncRequired): Moved.
8:57 PM Changeset in webkit [68232] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-23 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

r68008 broke new-run-webkit-tests in that the chromium ports no
longer respect set-webkit-configuration. The correct fix for this
is being pursued in bug 46278 (along with a bunch of unit tests),
but in the meantime I'm reverting the particular lines that broke
things. This was tested by hand.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
8:54 PM Changeset in webkit [68231] by tony@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-09-23 Tony Chang <tony@chromium.org>

Unreviewed. Removing a png that I didn't mean to check in. This
pixel result matches Windows so it doesn't need a png (and I forgot
the checksum file anyway).

  • platform/chromium-linux/svg/custom/broken-internal-references-expected.png: Removed.
8:41 PM Changeset in webkit [68230] by tkent@chromium.org
  • 4 edits in trunk

2010-09-23 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Fix some IndexedDB tests for DRT
https://bugs.webkit.org/show_bug.cgi?id=46444

  • platform/chromium/drt_expectations.txt:

2010-09-23 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Fix some IndexedDB tests for DRT
https://bugs.webkit.org/show_bug.cgi?id=46444

  • DEPS: Roll Chromium revision to 60394, which added WebKitClient::createIDBKeysFromSerializedValuesAndKeyPath() implementation.
8:38 PM Changeset in webkit [68229] by tony@chromium.org
  • 2 edits
    7 adds
    11 deletes in trunk/LayoutTests

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] layout test rebaselines
https://bugs.webkit.org/show_bug.cgi?id=46440

These 2 tests were being skipped for an unknown reason. Remove the results
and mark as failing so we can see it on the flakiness dashboard.

  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Removed.
  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Removed.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Removed.
  • platform/chromium-win/svg/carto.net/tabgroup-expected.png: Removed.

Small antialiasing difference in borders and font metric differences.

  • platform/chromium-linux/svg/custom/broken-internal-references-expected.png: Added.
  • platform/chromium-linux/svg/custom/broken-internal-references-expected.txt: Added.
  • platform/chromium-win/svg/custom/broken-internal-references-expected.checksum: Added.
  • platform/chromium-win/svg/custom/broken-internal-references-expected.png: Added.
  • platform/chromium-win/svg/custom/broken-internal-references-expected.txt: Added.

This test passes once these bad baselines are removed.

  • platform/chromium-mac/svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
  • platform/chromium-win/svg/clip-path/clip-path-child-clipped-expected.txt: Removed.

I don't think this is correct, so I'm removing the baseline and I
updated test_expecations.txt with a note.

  • platform/chromium-win/svg/custom/use-font-face-crash-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/use-font-face-crash-expected.png: Removed.
  • platform/chromium-win/svg/custom/use-font-face-crash-expected.txt: Removed.

This is just a difference it error text between V8 and JSC.

  • platform/chromium/fast/dom/Window/invalid-protocol-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
7:28 PM Changeset in webkit [68228] by aestes@apple.com
  • 2 edits in trunk/WebKit/mac

2010-09-23 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r61285): some Dashboard widgets are always invisible due to
HTML parser changes.
https://bugs.webkit.org/show_bug.cgi?id=46435

Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility
mode.

  • WebView/WebView.mm: (-[WebView _needsPreHTML5ParserQuirks]): Renamed from shouldUsePreHTML5ParserQuirks(). Return true if WebCore::Settings::usesDashboardCompatibilityMode() is true. (-[WebView _preferencesChangedNotification:]): (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks if Dashboard behavior is set to backward compatibility mode.
7:27 PM Changeset in webkit [68227] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46442

Reviewed by Sam Weinig.

Disallow the setting of block-flow to anything other than "tb" for all table-related display types
and flexible box display types. By disallowing block-flow on the subclasses of RenderBlock like tables
and flexible boxes, we ensure that alterations to the RenderBlock base class won't result in misrenderings
in tables and flexible boxes that try to specify other block flow values.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

7:12 PM Changeset in webkit [68226] by kinuko@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-09-23 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, another attempt to fix build. The code didn't have proper if-defs.

  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystem):
  • src/WebWorkerBase.h:
  • src/WorkerFileSystemCallbacksBridge.h:
6:54 PM Changeset in webkit [68225] by kinuko@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-09-23 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed; build fix attempt.

  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystem):
  • src/WorkerFileSystemCallbacksBridge.h:
6:09 PM Changeset in webkit [68224] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-23 Tony Chang <tony@chromium.org>

Unreviewed. Fix a test expecatation for no-caret-repaint-in-non-content-editable-element.html (should be TEXT not TEXT+IMAGE).

  • platform/chromium/test_expectations.txt:
5:52 PM Changeset in webkit [68223] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

2010-09-23 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Delay construction of functions that aren't captured
https://bugs.webkit.org/show_bug.cgi?id=46433

If a function isn't captured by an activation there's no
way it can be accessed indirectly, so we can delay the
construction until it's used (similar to what we do with
arguments). We rename the existing op_init_arguments to
op_init_lazy_reg and removed its implicit handling of
the anonymous argument register, and make op_new_function
take a parameter to indicate whether it should null check
the target slot before creating the function object.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitInitLazyRegister): (JSC::BytecodeGenerator::registerFor): (JSC::BytecodeGenerator::createLazyRegisterIfNecessary): (JSC::BytecodeGenerator::constRegisterFor): (JSC::BytecodeGenerator::emitNewFunction): (JSC::BytecodeGenerator::emitLazyNewFunction): (JSC::BytecodeGenerator::emitNewFunctionInternal):
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_init_lazy_reg): (JSC::JIT::emit_op_new_func):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_init_lazy_reg):
  • parser/Nodes.h: (JSC::ScopeNode::needsActivationForMoreThanVariables):
5:46 PM Changeset in webkit [68222] by kinuko@chromium.org
  • 24 edits
    2 adds in trunk

2010-09-23 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add Worker support for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=45808

Added WebWorkerBase::openFileSystem and WebCommonWorkerClient::
openFileSystem to call in to the browser via Worker stub/proxy
in the chromium.

Also added WorkerFileSystemCallbacksBridge class that proxies
requests and callbacks between from/to worker thread to/from the
main thread.

  • public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::openFileSystem): Added.
  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::localFileSystem): Added. (WebCore::LocalFileSystem::requestFileSystem): Added implementation for workers. In worker case this calls WebWorkerBase::openFileSystem.
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystem): Added. This is called from LocalFileSystem::requestFileSystem on the worker thread and creates a bridge to call WebCommonWorkerClient::openFileSystem on the main thread.
  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.h: (WebKit::WebWorkerClientImpl::openFileSystem): Added.
  • src/WorkerFileSystemCallbacksBridge.cpp: Added.
  • src/WorkerFileSystemCallbacksBridge.h: Added.

2010-09-23 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add Worker support for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=45808

Exposed requestFileSystem and Flags constructor on worker contexts.

Also changed how to get the base path for Web file systems (in
non-chromium ports) so that it works for workers too.
This patch assumes each port calls
LocalFileSystem::initializeLocalFileSystem() in its initialization
phase.

No new tests; tests will be added when we have complete implementation.

  • bindings/generic/RuntimeEnabledFeatures.cpp: (WebCore::RuntimeEnabledFeatures::fileSystemEnabled): Changed to reflect AsyncFileSystem::isAvailable
  • bindings/generic/RuntimeEnabledFeatures.h: Moved the implementation of fileSystemEnabled to .cpp.
  • fileapi/LocalFileSystem.cpp: (WebCore::LocalFileSystem::initializeLocalFileSystem): Added. (WebCore::LocalFileSystem::localFileSystem): Added. (WebCore::LocalFileSystem::fileSystemBasePath): Added.
  • fileapi/LocalFileSystem.h: (WebCore::LocalFileSystem::~LocalFileSystem): Removed. (As now it's going to be used as a singleton.)
  • page/DOMWindow.cpp: (WebCore::DOMWindow::requestFileSystem): Changed to use a singleton instance of LocalFileSystem.
  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessFileSystem): Added.
  • page/Settings.cpp: Removed fileSystemRootPath method.
  • page/Settings.h: Removed fileSystemRootPath method.
  • platform/AsyncFileSystem.cpp: (WebCore::AsyncFileSystem::isAvailable): Added.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::requestFileSystem): Added to expose requestFileSystem method in worker contexts. (WebCore::WorkerContext::Observer): Added. (WebCore::WorkerContext::registerObserver): Added. (WebCore::WorkerContext::unregisterObserver): Added. (WebCore::WorkerContext::notifyObserversOfStop): Added.
  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:
  • workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownStartTask::performTask): Modified to call workerContext->notifyObserversOfStop to notify worker observers of the worker thread termination.
5:29 PM Changeset in webkit [68221] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Oliver Hunt.

Lower the default canvas interpolation quality for platforms that use CG
https://bugs.webkit.org/show_bug.cgi?id=45722

Lowered the default image interpolation quality for platforms that
use CG down to low since this is as good as if not better than
other graphics platforms defaults (being bilinear interpolation).

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
  • html/HTMLCanvasElement.h: Moved in macros for default canvas interp quality.
  • platform/graphics/GraphicsContext.h: Moved out macros for default canvas interp quality. It makes more sense for them to be housed where they're used.
5:21 PM Changeset in webkit [68220] by weinig@apple.com
  • 15 edits in trunk

WebKit2 API: Need way to know when a frame is removed from the hierarchy
<rdar://problem/8414062>
https://bugs.webkit.org/show_bug.cgi?id=46432

Reviewed by Anders Carlsson.

WebKit2:

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didRemoveFrameFromHierarchy):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):

  • UIProcess/WebPageProxy.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didRemoveFrameFromHierarchy):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::didTransferChildFrameToNewDocument):

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(didRemoveFrameFromHierarchy):
(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

5:09 PM Changeset in webkit [68219] by andersca@apple.com
  • 2 edits
    4 adds in trunk/WebKit2

Add PluginProcessConnection and PluginProcessConnectionManager
https://bugs.webkit.org/show_bug.cgi?id=46425

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

Add empty file for now.

  • WebProcess/Plugins/PluginProcessConnection.h:

Add header.

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp: Added.

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Check for an existing plug-in process connection. If we don't have one, ask the
UI process to create one.

(WebKit::PluginProcessConnectionManager::removePluginProcessConnection):
Remove the connection from our global vector.

5:01 PM Changeset in webkit [68218] by tony@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] add baselines for no-caret-repaint-in-non-content-editable-element.html
https://bugs.webkit.org/show_bug.cgi?id=46428

  • platform/chromium-linux/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
  • platform/chromium-mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
  • platform/chromium-win/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
  • platform/chromium-win/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:58 PM Changeset in webkit [68217] by mihaip@chromium.org
  • 3 edits
    1 add
    8 deletes in trunk/LayoutTests

2010-09-23 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Convert http/tests/navigation/error404-frames.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=46341

  • http/tests/navigation/error404-frames-expected.txt: Added.
  • http/tests/navigation/error404-frames.html:
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/error404-frames-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/error404-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/error404-frames-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/http/tests/navigation/error404-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/error404-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/error404-frames-expected.txt: Removed.
4:48 PM Changeset in webkit [68216] by tony@chromium.org
  • 9 edits in trunk

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
https://bugs.webkit.org/show_bug.cgi?id=46426

  • platform/chromium/test_expectations.txt: Mark 4 tests as passing.

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
https://bugs.webkit.org/show_bug.cgi?id=46426

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pauseSVGAnimation):
  • src/WebFrameImpl.h:

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
https://bugs.webkit.org/show_bug.cgi?id=46426

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::sampleSVGAnimationForElementAtTime):
  • DumpRenderTree/chromium/LayoutTestController.h:
4:41 PM Changeset in webkit [68215] by atwilson@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium-linux/svg/in-html/by-reference-expected.txt: Added.
  • platform/chromium-win/svg/in-html/by-reference-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:39 PM Changeset in webkit [68214] by mihaip@chromium.org
  • 3 edits
    1 add
    9 deletes in trunk/LayoutTests

2010-09-23 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] convert clientWidthAfterDocumentIsRemoved to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=46397

As suggested in http://crbug.com/9613, this should just be a text-only
test.

  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Added.
  • fast/dom/clientWidthAfterDocumentIsRemoved.html:
  • platform/chromium-linux/fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Removed.
  • platform/chromium-linux/fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Removed.
  • platform/chromium-mac/fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Removed.
  • platform/chromium-win/fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Removed.
  • platform/chromium-win/fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Removed.
  • platform/chromium-win/fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Removed.
  • platform/mac/fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Removed.
  • platform/mac/fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Removed.
4:35 PM Changeset in webkit [68213] by tony@chromium.org
  • 6 edits in trunk/LayoutTests

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] make fast/events/standalone-image-drag-to-editable.html non-flakey
https://bugs.webkit.org/show_bug.cgi?id=46381

In chromium, the image that was dropped sometimes hasn't loaded when
the pixel results are taken. This results in a 0x0 image and makes
the test flakey. The fix is to wait for the image load event if it's
not already loaded.

  • fast/events/resources/standalone-image-drag-to-editable-frame.html:
  • fast/events/standalone-image-drag-to-editable.html:
  • platform/chromium-linux/fast/events/standalone-image-drag-to-editable-expected.checksum: Image result with dropped image loaded.
  • platform/chromium-linux/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/chromium/test_expectations.txt:
4:11 PM Changeset in webkit [68212] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/8460731> ~9.9% speedup when compiling interpreter with llvm-gcc-4.2
https://bugs.webkit.org/show_bug.cgi?id=46423

Reviewed by Oliver Hunt.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Disable the gcc computed
goto hacks added in r55564 when compiling with llvm-gcc-4.2.

4:09 PM Changeset in webkit [68211] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Nate Chapin.

[GTK] r68199 introduced two test failures
https://bugs.webkit.org/show_bug.cgi?id=46424

Fix a regression handling preference overrides that are attached to boolean properties.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match so we must check for that when converting a string to a boolean.
3:53 PM Changeset in webkit [68210] by Adam Roben
  • 6 edits in trunk/WebKit2

Remove the DrawingAreaProxy parameter to WebPagProxy::initializeWebPage

Callers are now required to set the drawing area via
WebPageProxy::setDrawingArea before calling initializeWebPage. This
will allow us to delay calling initializeWebPage on Windows until
after we've created the WebView's HWND, which in turn will allow us to
send the HWND over to the web process when the page is created. (The
drawing area must be set before creating the HWND so that its size can
be updated, etc., as the window is created.)

Fixes <http://webkit.org/b/46409> DrawingAreaProxy parameter to
initializeWebPage is unnecessary, and causes problems on Windows

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:]):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::init):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):
Added explicit calls to setDrawingArea.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):

  • UIProcess/WebPageProxy.h:

Removed the DrawingAreaProxy parameter and a stray puts(), and added
an assertion.

3:46 PM Changeset in webkit [68209] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Darin Adler.

Fix usage of enum as if it was a define
https://bugs.webkit.org/show_bug.cgi?id=46355

pthread.h defines PTHREAD_MUTEX_DEFAULT and PTHREAD_MUTEX_NORMAL as an
enum. Hence, it cannot be used by the preprocessor which always
evaluates that condition as true. This was giving a warning when
compiling with gcc and "-Wundef" flag.

The second path, when PTHREAD_MUTEX_DEFAULT is not the same of
PTHREAD_MUTEX_NORMAL, is not slow. So, let's eliminate the first path
and get rid of that #if.

  • wtf/ThreadingPthreads.cpp: Always call pthread_mutexattr_init() to set mutex type to PTHREAD_MUTEX_NORMAL. (WTF::Mutex::Mutex):
3:26 PM Changeset in webkit [68208] by mihaip@chromium.org
  • 2 edits
    2 adds
    2 deletes in trunk/LayoutTests

2010-09-23 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

[Chromium] traversal/node-iterator-prototype.html has incorrect baselines
https://bugs.webkit.org/show_bug.cgi?id=46413

Chromium/V8 actually gets this test right (unlike JSC), but had
incorrect baselines for it checked in by r58524.

  • platform/chromium-mac/traversal/node-iterator-prototype-expected.txt: Removed.
  • platform/chromium-win/traversal/node-iterator-prototype-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/chromium/traversal/node-iterator-prototype-expected.txt: Added.
3:23 PM Changeset in webkit [68207] by msaboff@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-09-23 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Removed extraneous truncation of ovector on entry and error exit.
Changed the initialization to -1 of vector to only initialize
the start indecies, which is sufficient for the pattern/subpatterns.
Changed the JIT code to not clear the end index for subpatterns
as it isn't needed. These changes are worth ~2.7% on v8-regexp.
https://bugs.webkit.org/show_bug.cgi?id=46404

  • runtime/RegExp.cpp: (JSC::RegExp::match):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
3:21 PM Changeset in webkit [68206] by hyatt@apple.com
  • 8 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46414, rename line box methods that refer specifically to
"horizontal" and "vertical." Replace those terms with "inline direction" and "block direction."

Reviewed by Adele Peterson.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::computeBlockDirectionOverflow):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::setInlineDirectionOverflowPositions):
(WebCore::InlineFlowBox::setBlockDirectionOverflowPositions):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):

  • rendering/RootInlineBox.h:
3:20 PM Changeset in webkit [68205] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Implement handlers for the GetPluginProcessConnection message
https://bugs.webkit.org/show_bug.cgi?id=46415

Reviewed by Darin Adler.

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:

Add GetPluginProcessConnection message kind

  • UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::PluginProcessManager):
Add missing constructor.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPluginProcessConnection):
Ask the plug-in process manager for a connection.

(WebKit::WebProcessProxy::didReceiveSyncMessage):
Call getPluginProcessConnection.

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Send the GetPluginProcessConnection message.

3:08 PM Changeset in webkit [68204] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-09-23 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Kenneth Rohde Christiansen.

Fix QWebHapticFeedbackPlayer exposure via QWebKitPlatformPlugin

[Qt] QWebHapticFeedbackPlayer needs correct exposure through QWebKitPlatformPlugin
https://bugs.webkit.org/show_bug.cgi?id=46402

QWebHapticFeedbackPlayer is exported through
QWebKitPlatformPlugin::createExtension(), but
createHapticFeedbackPlayer() and the correct
inheritage are missing.

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createHapticFeedbackPlayer):
  • WebCoreSupport/QtPlatformPlugin.h:
3:03 PM Changeset in webkit [68203] by atwilson@chromium.org
  • 13 edits in trunk

Revert "2010-09-23 Hans Wennborg <hans@chromium.org>"

Revert r68197 because it breaks the chromium linux build.
https://bugs.webkit.org/show_bug.cgi?id=46344

2:56 PM Changeset in webkit [68202] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-22 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Update the comments to more accurately reflect which tests we expect
to run and pass.

https://bugs.webkit.org/show_bug.cgi?id=46331

  • platform/chromium-gpu/test_expectations.txt:
2:49 PM Changeset in webkit [68201] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2010-09-23 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
https://bugs.webkit.org/show_bug.cgi?id=46406

This breaks when the method is called with specified size of data (image data), and the
buffer hasn't yet reached this size.

  • Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of index larger than 0.
2:47 PM Changeset in webkit [68200] by hyatt@apple.com
  • 6 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46403, convert the margin/border/padding accessors
to be logical.

Reviewed by Adele Peterson.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::getFlowSpacingLogicalWidth):
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::paintBoxShadow):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::marginBorderPaddingLogicalLeft):
(WebCore::InlineFlowBox::marginBorderPaddingLogicalRight):
(WebCore::InlineFlowBox::marginLogicalLeft):
(WebCore::InlineFlowBox::marginLogicalRight):
(WebCore::InlineFlowBox::borderLogicalLeft):
(WebCore::InlineFlowBox::borderLogicalRight):
(WebCore::InlineFlowBox::paddingLogicalLeft):
(WebCore::InlineFlowBox::paddingLogicalRight):
(WebCore::InlineFlowBox::includeLogicalLeftEdge):
(WebCore::InlineFlowBox::includeLogicalRightEdge):
(WebCore::InlineFlowBox::setEdges):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockWidthForPositioned):
(WebCore::RenderBox::calcAbsoluteHorizontalValues):
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

2:36 PM Changeset in webkit [68199] by mrobinson@webkit.org
  • 4 edits in trunk

2010-09-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Nate Chapin.

[GTK] Some tests from r68174 fail on the GTK+ bots
https://bugs.webkit.org/show_bug.cgi?id=46396

Fix since version number in this new WebKitWebSettings property.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): Fix the since version number.

2010-09-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Nate Chapin.

[GTK] Some tests from r68174 fail on the GTK+ bots
https://bugs.webkit.org/show_bug.cgi?id=46396

Simplify LayoutTestController::overridePreference to make it easier for
people unfamiliar with the code to keep the list of preferences up to date.
Add the conversion for enable-hyperlink-auditing.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::overridePreference): Use a simple if-else block to determine out the property name for overrridePreference. Also simplify the logic for setting string properties. Add the conversion for enable-hyperlink-auditing.
2:36 PM Changeset in webkit [68198] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

2010-09-23 Jeff Schiller <jeffschiller@google.com>

Reviewed by David Hyatt.

Test to confirm that object/iframe/embed backgrounds are transparent for SVG documents
https://bugs.webkit.org/show_bug.cgi?id=10687

  • platform/mac/svg/in-html/by-reference-expected.txt: Added.
  • svg/in-html/by-reference-expected.checksum: Added.
  • svg/in-html/by-reference-expected.png: Added.
  • svg/in-html/by-reference.html: Added.

2010-09-23 Jeff Schiller <jeffschiller@google.com>

Reviewed by David Hyatt.

Ensure that SVG documents included by reference (object, iframe, embed) have transparent
backgrounds (not white). https://bugs.webkit.org/show_bug.cgi?id=10687

Test: svg/in-html/by-reference.html

  • dom/Document.cpp: (WebCore::Document::hasSVGRootNode):
  • dom/Document.h: (WebCore::Document::hasSVGRootNode):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2:31 PM Changeset in webkit [68197] by hans@chromium.org
  • 13 edits in trunk

2010-09-23 Hans Wennborg <hans@chromium.org>

Reviewed by Simon Fraser.

Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344

  • fast/dom/DeviceMotion/script-tests/create-event.js:
  • fast/dom/DeviceMotion/create-event-expected.txt: Look for the new attributes.
  • fast/dom/DeviceMotion/script-tests/optional-event-properties.js:
  • fast/dom/DeviceMotion/optional-event-properties-expected.txt: Test the new attributes.
  • fast/dom/script-tests/prototype-inheritance.js: DeviceMotionEvent is not implemented on all platforms, so it should be skipped in this test.

2010-09-23 Hans Wennborg <hans@chromium.org>

Reviewed by Simon Fraser.

Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344

The spec has changed: the DeviceMotionEvent attributes accelerationX,
accelerationY, etc. have been baked into an 'acceleration' attribute
which returns an object with x, y, and z values. Likewise for the
rotation rate. The 'accelerationIncludingGravity' attribute is new.

  • WebCore.exp.in: The DeviceMotionData::create member function has changed. Also export create functions for DeviceMotionData::Acceleration and RotationRate.
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::acceleration): (WebCore::JSDeviceMotionEvent::accelerationIncludingGravity): (WebCore::JSDeviceMotionEvent::rotationRate): (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent): Manually create and return objects with the right attributes for acceleration, accelerationIncludingGravity, and rotationRate. When creating the DeviceMotionData object in initDeviceMotionEvent, accept any input objects that have the right attributes.
  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::accelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter): (WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback): V8 counterpart to the JSC code above.
  • dom/DeviceMotionData.cpp: (WebCore::DeviceMotionData::Acceleration::create): (WebCore::DeviceMotionData::Acceleration::Acceleration): (WebCore::DeviceMotionData::RotationRate::create): (WebCore::DeviceMotionData::RotationRate::RotationRate): (WebCore::DeviceMotionData::create): (WebCore::DeviceMotionData::DeviceMotionData):
  • dom/DeviceMotionData.h: (WebCore::DeviceMotionData::Acceleration::canProvideX): (WebCore::DeviceMotionData::Acceleration::canProvideY): (WebCore::DeviceMotionData::Acceleration::canProvideZ): (WebCore::DeviceMotionData::Acceleration::x): (WebCore::DeviceMotionData::Acceleration::y): (WebCore::DeviceMotionData::Acceleration::z): (WebCore::DeviceMotionData::RotationRate::canProvideAlpha): (WebCore::DeviceMotionData::RotationRate::canProvideBeta): (WebCore::DeviceMotionData::RotationRate::canProvideGamma): (WebCore::DeviceMotionData::RotationRate::alpha): (WebCore::DeviceMotionData::RotationRate::beta): (WebCore::DeviceMotionData::RotationRate::gamma): (WebCore::DeviceMotionData::acceleration): (WebCore::DeviceMotionData::accelerationIncludingGravity): (WebCore::DeviceMotionData::rotationRate): Add member classes Acceleration and RotationRate to DeviceMotionData.
  • dom/DeviceMotionEvent.idl: Update according to the spec. Acceleration and RotationRate need not be backed by native classes.
2:18 PM Changeset in webkit [68196] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Set synchronous handle in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46395

When loading synchronous network resources, we need to use a synchronous internet handle.

  • platform/network/ResourceHandle.h:
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::setSynchronousInternetHandle):
2:09 PM Changeset in webkit [68195] by ap@apple.com
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=46326
Crash when trying to create a NodeIterator rooted at a document-less DocumentType node

Test: fast/dom/node-iterator-with-doctype-root.html

  • dom/Document.cpp: (WebCore::Document::detachNodeIterator): Added a comment explaining that attach/detach may not always be paired.
  • dom/NodeIterator.cpp: (WebCore::NodeIterator::NodeIterator): Don't try to register with the document if there is none. (WebCore::NodeIterator::~NodeIterator): Ditto. (WebCore::NodeIterator::detach): Ditto. (WebCore::NodeIterator::updateForNodeRemoval): There should be a document if we're getting a notification.
2:03 PM Changeset in webkit [68194] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-23 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium text_expectations.txt change.

Unskip traversal/node-iterator-prototype.html on Chromium, so we can
get updated expectations for it from the bots.

  • platform/chromium/test_expectations.txt:
1:56 PM Changeset in webkit [68193] by atwilson@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
1:53 PM Changeset in webkit [68192] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add synchronous loading for local files to ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46392

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
1:52 PM Changeset in webkit [68191] by tony@chromium.org
  • 8 edits in trunk

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] add caretBrowsingEnabled to WebSettings and DRT
https://bugs.webkit.org/show_bug.cgi?id=46388

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setCaretBrowsingEnabled):
  • src/WebSettingsImpl.h:

2010-09-23 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] add caretBrowsingEnabled to WebSettings and DRT
https://bugs.webkit.org/show_bug.cgi?id=46388

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::overridePreference):
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h:
1:45 PM Changeset in webkit [68190] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Remove (has|set)ReceivedResponse() from public ResourceHandleWin API
https://bugs.webkit.org/show_bug.cgi?id=46391

There is no need for this functions to be public, so remove them.

  • platform/network/ResourceHandle.h:
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete):
1:41 PM Changeset in webkit [68189] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46400

Reviewed by Adele Peterson.

Add logicalLeft/Top getter/setters to line boxes.

  • rendering/InlineBox.h:

(WebCore::InlineBox::logicalLeft):
(WebCore::InlineBox::setLogicalLeft):
(WebCore::InlineBox::logicalTop):
(WebCore::InlineBox::setLogicalTop):

1:35 PM Changeset in webkit [68188] by commit-queue@webkit.org
  • 8 edits in trunk

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

Since the setInterval call is meant to reflect a global change for
all pages' DOMTimers, it's misleading to have it be a method on a
given page's settings' object. Thus, this patch changes the call to be static.

This simple change to using a static call instead of the page's setting's
method doesn't warrant a test.

  • page/Settings.h: Changed the setInterval call to be static.

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView/WebView.mm: Updating set interval call to use Settings' static version inside one time init block.

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView.cpp: Updating set interval call to use Settings' static version inside one time init block.

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebProcess/WebPage/WebPage.cpp: Updating set interval call to use Settings' static version.
1:24 PM Changeset in webkit [68187] by mihaip@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2010-09-23 Mihai Parparita <mihaip@chromium.org>

Reviewed by David Levin.

[Chromium] remove incorrect baselines for two WebGL tests
https://bugs.webkit.org/show_bug.cgi?id=46372

As far as I can tell, these tests were not failing because of
"new-run-webkit-tests's diff trimming line ends", but because they had
chromium-mac baselines checked in with r56251, but then the test was
changed since then, with the chromium-mac baselines not being updated.
The test seems to pass on chromium-mac (both test_shell and DRT) with
the regular baselines.

  • platform/chromium-mac/fast/canvas/webgl/null-object-behaviour-expected.txt: Removed.
  • platform/chromium-mac/fast/canvas/webgl/uniform-location-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
1:21 PM Changeset in webkit [68186] by hyatt@apple.com
  • 8 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46386, give line boxes a vertical bit so that it's easy to know
the overall direction of the line without having to ask the containing block.

Reviewed by Dan Bernstein.

Also couldn't resist some cleanup. Tightened up the type of the renderobject passed to RootInlineBox's
constructor to be a RenderBlock. Moved all the virtual logical height stuff outside of the SVG ifdef
since TrailingFloatsRootInlineBox uses it and should work without SVG enabled.

  • rendering/EllipsisBox.h:

(WebCore::EllipsisBox::EllipsisBox):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isVertical):
(WebCore::InlineBox::setIsVertical):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::placeEllipsis):

  • rendering/RootInlineBox.h:
  • rendering/SVGRootInlineBox.h:

(WebCore::SVGRootInlineBox::SVGRootInlineBox):

  • rendering/TrailingFloatsRootInlineBox.h:

(WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox):

1:10 PM Changeset in webkit [68185] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Check for a valid ResourceHandleClient in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46389

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): Add checks to ensure client() is not 0.
12:55 PM Changeset in webkit [68184] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Fix ResourceHandleWin::cancel() for network resources
https://bugs.webkit.org/show_bug.cgi?id=46383

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): Check it requestHandle is not 0. (WebCore::ResourceHandle::cancel): Set requestHandle to 0.
12:52 PM WebKit Team edited by eric.carlson@apple.com
(diff)
12:43 PM Changeset in webkit [68183] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add handling for form data and additional HTTP headers in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46369

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
12:39 PM Changeset in webkit [68182] by Adam Roben
  • 2 edits in trunk/WebKit2

Try to fix the Windows build

  • win/WebKit2Common.vsprops: Add WebKit2/PluginProcess to the include

path.

12:37 PM Changeset in webkit [68181] by eric.carlson@apple.com
  • 4 edits in trunk

2010-09-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser

'seeking' event should always fire
https://bugs.webkit.org/show_bug.cgi?id=45694

Update seek algorithm to match current spec.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Don't need to fire 'seeking' event here. (WebCore::HTMLMediaElement::seek): Always fire 'seeking'. Update comments. (WebCore::HTMLMediaElement::finishSeek): Update comments. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto.

2010-09-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser

'seeking' event should always fire
https://bugs.webkit.org/show_bug.cgi?id=45694

  • media/event-attributes-expected.txt: Update for changes.
12:33 PM Changeset in webkit [68180] by commit-queue@webkit.org
  • 13 edits
    1 move in trunk

2010-09-23 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Rename FileWriterClient to AsyncFileWriterClient.
https://bugs.webkit.org/show_bug.cgi?id=46325

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/AsyncFileWriter.h:
  • fileapi/AsyncFileWriterClient.h: Copied from WebCore/fileapi/FileWriterClient.h.
  • fileapi/FileWriter.h:
  • fileapi/FileWriterClient.h: Removed.
  • platform/AsyncFileSystem.h:

2010-09-23 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Rename FileWriterClient to AsyncFileWriterClient.
https://bugs.webkit.org/show_bug.cgi?id=46325

  • src/AsyncFileSystemChromium.cpp:
  • src/AsyncFileSystemChromium.h:
  • src/AsyncFileWriterChromium.cpp:
  • src/AsyncFileWriterChromium.h:
12:24 PM Changeset in webkit [68179] by Nate Chapin
  • 5 edits in trunk/WebKit/win

2010-09-23 Nate Chapin <Nate Chapin>

Unreviewed, build fix.

Move hyperlinkAuditingEnabled to IWebPreferencesPrivate.idl
and touch WebKit.idl

  • Interfaces/IWebPreferences.idl:
  • Interfaces/IWebPreferencesPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebView.cpp: (WebView::notifyPreferencesChanged):
12:17 PM Changeset in webkit [68178] by atwilson@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

Unreviewed chromium expecations update.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
12:17 PM Changeset in webkit [68177] by hyatt@apple.com
  • 27 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46378, rename width/height on line boxes to logicalWidth/logicalHeight.

Reviewed by Dan Bernstein.

  • editing/visible_units.cpp:

(WebCore::previousLinePosition):
(WebCore::nextLinePosition):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::canAccommodateEllipsis):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::hasVirtualLogicalHeight):
(WebCore::InlineBox::setHasVirtualLogicalHeight):
(WebCore::InlineBox::virtualLogicalHeight):
(WebCore::InlineBox::setLogicalWidth):
(WebCore::InlineBox::logicalWidth):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::paintTextDecorations):
(WebCore::InlineFlowBox::placeEllipsisBox):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::visibleOverflowRect):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCustomHighlight):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::calculateBoundaries):
(WebCore::InlineTextBox::setSpaceAdd):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::addFocusRingRects):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::RenderBlock::checkLinesForTextOverflow):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintCustomHighlight):
(WebCore::RenderBox::containingBlockWidthForPositioned):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::applyLineClamp):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):

  • rendering/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::createInlineFlowBox):
(WebCore::RenderSVGInline::absoluteQuads):

  • rendering/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::createTextBox):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::createRootInlineBox):

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::linesBoundingBox):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeTextRun):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::canAccommodateEllipsis):
(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::paintCustomHighlight):
(WebCore::RootInlineBox::fillLineSelectionGap):
(WebCore::RootInlineBox::closestLeafChildForXPos):

  • rendering/SVGInlineFlowBox.h:

(WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
(WebCore::SVGInlineFlowBox::virtualLogicalHeight):
(WebCore::SVGInlineFlowBox::setLogicalHeight):

  • rendering/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::SVGInlineTextBox):

  • rendering/SVGInlineTextBox.h:

(WebCore::SVGInlineTextBox::virtualLogicalHeight):
(WebCore::SVGInlineTextBox::setLogicalHeight):
(WebCore::SVGInlineTextBox::selectionHeight):

  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeRenderSVGTextBox):

  • rendering/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::SVGRootInlineBox::layoutRootBox):

  • rendering/SVGRootInlineBox.h:

(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::virtualLogicalHeight):
(WebCore::SVGRootInlineBox::setLogicalHeight):

  • rendering/TrailingFloatsRootInlineBox.h:

(WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox):
(WebCore::TrailingFloatsRootInlineBox::virtualLogicalHeight):

12:15 PM Changeset in webkit [68176] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Oliver Hunt.

context.drawImage with (source rect's height) = -(input image's native height) draws nothing
https://bugs.webkit.org/show_bug.cgi?id=46243

These test simply exercise using negative widths and heights for the source rect in ctx.drawImage calls.

  • canvas/philip/tests/2d.drawImage.negativeSourceHeight-expected.txt: Added.
  • canvas/philip/tests/2d.drawImage.negativeSourceHeight.html: Added.
  • canvas/philip/tests/2d.drawImage.negativeSourceHeight2-expected.txt: Added.
  • canvas/philip/tests/2d.drawImage.negativeSourceHeight2.html: Added.
  • canvas/philip/tests/2d.drawImage.negativeSourceHeightAndWidth-expected.txt: Added.
  • canvas/philip/tests/2d.drawImage.negativeSourceHeightAndWidth.html: Added.

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Oliver Hunt.

context.drawImage with (source rect's height) = -(input image's native height) draws nothing
https://bugs.webkit.org/show_bug.cgi?id=46243

This patch changes canvasrenderingcontext2d's drawImage with an image element to
normalize the source and dest rects to acheive the desired canvas spec behavior
of allowing negative widths and heights that don't cause flipping and fix the
adverse behavior of specifying a source rect height of negative the source image's height

Tests: canvas/philip/tests/2d.drawImage.negativeSourceHeight.html

canvas/philip/tests/2d.drawImage.negativeSourceHeight2.html
canvas/philip/tests/2d.drawImage.negativeSourceHeightAndWidth.html

  • html/canvas/CanvasRenderingContext2D.cpp: Normalize rects in drawImage before calling lower level draw calls.
12:14 PM Changeset in webkit [68175] by aestes@apple.com
  • 6 edits in trunk

2010-09-22 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window
https://bugs.webkit.org/show_bug.cgi?id=46334

Microsoft My Day loads scripts using self-closing script tags, markup
which is incompatible with the HTML5 parser. Enable parser quirks for
this application.

  • WebView/WebView.mm: (shouldUsePreHTML5ParserQuirks): Return true if the application is Microsoft My Day and was linked against a version of WebKit prior to the introduction of the HTML5 parser.

2010-09-23 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEMorphologyElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46363
The patch also implements the simple setRadius method.

Tests: svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr.html

svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call.html

  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::setRadius): (WebCore::SVGFEMorphologyElement::svgAttributeChanged):
  • svg/SVGFEMorphologyElement.h:
12:06 PM Changeset in webkit [68174] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-09-23 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations tweak.

Temporarily add http/tests/navigation/ping-*.

  • platform/chromium/test_expectations.txt:
11:59 AM Changeset in webkit [68173] by andersca@apple.com
  • 3 edits
    3 adds in trunk/WebKit2

Add PluginProcessMain files
https://bugs.webkit.org/show_bug.cgi?id=46379

Reviewed by Sam Weinig.

  • PluginProcess/PluginProcessMain.h: Added.
  • PluginProcess/mac/PluginProcessMainMac.mm: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Add PluginProcessMain files. Remove PluginProcess.messages.in from the target so it
won't be installed in the WebKit2.framework bundle.

  • WebProcess/WebKitMain.cpp:

(WebKitMain):
Call PluginProcessMain if the process type is ProcessLauncher::PluginProcess.

11:50 AM Changeset in webkit [68172] by Patrick Gansterer
  • 1 edit
    2 copies in trunk/WebKit/wince

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add PlatformStrategiesWinCE
https://bugs.webkit.org/show_bug.cgi?id=46371

  • WebCoreSupport/PlatformStrategiesWinCE.cpp: Copied from WebKit/win/WebCoreSupport/WebPlatformStrategies.cpp.
  • WebCoreSupport/PlatformStrategiesWinCE.h: Copied from WebKit/win/WebCoreSupport/WebPlatformStrategies.h.
11:49 AM Changeset in webkit [68171] by oliver@apple.com
  • 9 edits in trunk/JavaScriptCore

Only copy captured variables into activation
https://bugs.webkit.org/show_bug.cgi?id=46330

Reviewed by Geoff Garen

We now track free variable information which means that
we no longer need to copy every variable defined in a
function. With this patch activations only retain those
variables needed for correctness. In order to interact
safely with the inspector this means that JSActivation
now provides its own lookup functions so it can avoid
trying to read or write to variables that have been
optimised out.

  • bytecode/CodeBlock.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • parser/Nodes.h:

(JSC::ScopeNode::capturedVariableCount):
(JSC::ScopeNode::captures):

  • runtime/Arguments.h:

(JSC::JSActivation::copyRegisters):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::FunctionExecutable::capturedVariableCount):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::markChildren):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

  • runtime/JSActivation.h:
11:21 AM Changeset in webkit [68170] by andersca@apple.com
  • 9 edits
    1 copy
    3 adds in trunk/WebKit2

Add PluginProcessProxy class
https://bugs.webkit.org/show_bug.cgi?id=46377

Reviewed by Sam Weinig.

  • DerivedSources.make:

Add PluginProcess.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::send):
Add send overload that takes a message.

  • Platform/CoreIPC/MessageID.h:

Add MessageClassPluginProcess message kind.

  • PluginProcess/PluginProcess.messages.in: Added.

Add PluginProcess messages.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::infoForPluginWithPath):

  • UIProcess/Plugins/PluginInfoStore.h:

New function that returns the plug-in info for a plug-in with the given path.

  • UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::getPluginProcessConnection):
Look for an existing plug-in process proxy.

  • UIProcess/Plugins/PluginProcessProxy.cpp: Added.

(WebKit::PluginProcessProxy::create):
Launch the process.

(WebKit::PluginProcessProxy::didReceiveMessage):
(WebKit::PluginProcessProxy::didReceiveInvalidMessage):
Add stubbed out functions.

(WebKit::PluginProcessProxy::didClose):
Delete the plug-in process proxy.

(WebKit::PluginProcessProxy::didFinishLaunching):
Open a connection to the plug-in process proxy.

  • UIProcess/Plugins/PluginProcessProxy.h: Added.

(WebKit::PluginProcessProxy::pluginInfo):
Return the plug-in info.

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::context):
Add a context getter.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

11:19 AM Changeset in webkit [68169] by Nate Chapin
  • 4 edits in trunk/WebKit

2010-09-23 Nate Chapin <Nate Chapin>

Unreviewed, build fix.

Look for hyperlinkAuditingEnabled in the right set of preferences.

  • WebView.cpp: (WebView::notifyPreferencesChanged):
11:17 AM Changeset in webkit [68168] by commit-queue@webkit.org
  • 4 edits
    30 adds in trunk

2010-09-23 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEMorphologyElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46363
Adding layout tests for feMorphology dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr.html: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop.html: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEMorphologyElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEMorphologyElement-dom-operator-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEMorphologyElement-dom-radius-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEMorphologyElement-svgdom-in-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEMorphologyElement-svgdom-operator-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEMorphologyElement-svgdom-radius-call.js: Added. (executeTest):

2010-09-23 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEMorphologyElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46363
The patch also implements the simple setRadius method.

Tests: svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr.html

svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop.html
svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call.html

  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::setRadius): (WebCore::SVGFEMorphologyElement::svgAttributeChanged):
  • svg/SVGFEMorphologyElement.h:
11:08 AM Changeset in webkit [68167] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add synchronous loading for network resources to ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46364

Use return value of onRequestComplete() to indicate that an additional
call to it is required for receiving remaining network data.

  • platform/network/ResourceHandle.h:
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::start):
11:02 AM Changeset in webkit [68166] by Nate Chapin
  • 39 edits
    6 adds in trunk

2010-09-23 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.


Implement <a ping> (disabled by default).
https://bugs.webkit.org/show_bug.cgi?id=30458


Tests: http/tests/navigation/ping-cross-origin-from-https.html

http/tests/navigation/ping-cross-origin.html
http/tests/navigation/ping-same-origin.html

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::sendPings):
  • html/HTMLAnchorElement.h:
  • html/HTMLAttributeNames.in:
  • loader/PingLoader.cpp: (WebCore::PingLoader::sendPing): Set ping-specific headers. (WebCore::PingLoader::PingLoader):
  • loader/PingLoader.h: (WebCore::PingLoader::timeout): Ensure pings eventually timeout, since

the normal cancel mechanism can't stop them.

  • page/Settings.cpp:
  • page/Settings.h: Add hyperlinkAuditingEnabled.
10:56 AM Changeset in webkit [68165] by jhawkins@chromium.org
  • 7 edits in trunk/WebCore

2010-09-23 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=46312

Use Skia's SkSafeRef/SkSafeUnref functions instead of safeRef/safeUnref.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
  • platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::platformDestroy):
  • platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::platformDestroy):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::State::State): (WebCore::PlatformContextSkia::State::~State): (WebCore::PlatformContextSkia::drawRect): (WebCore::PlatformContextSkia::setStrokeShader): (WebCore::PlatformContextSkia::setFillShader): (WebCore::PlatformContextSkia::setDashPathEffect):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::paintSkiaText):
10:52 AM Changeset in webkit [68164] by demarchi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Csaba Osztrogonác.

Fix warnings regarding print format in 64 bits
https://bugs.webkit.org/show_bug.cgi?id=46357

Use inttypes.h in order to have portable print formats across 32 and
64 bits.

  • platform/sql/SQLiteFileSystem.cpp: (WebCore::SQLiteFileSystem::getFileNameForNewDatabase):
10:49 AM Changeset in webkit [68163] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-23 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioContext files
https://bugs.webkit.org/show_bug.cgi?id=44890

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp: Added. (WebCore::AudioContext::createAudioRequest): (WebCore::AudioContext::create): (WebCore::AudioContext::AudioContext): (WebCore::AudioContext::~AudioContext): (WebCore::AudioContext::lazyInitialize): (WebCore::AudioContext::uninitialize): (WebCore::AudioContext::isInitialized): (WebCore::AudioContext::isRunnable): (WebCore::AudioContext::stop): (WebCore::AudioContext::document): (WebCore::AudioContext::hasDocument): (WebCore::AudioContext::refBuffer): (WebCore::AudioContext::createBuffer): (WebCore::AudioContext::createBufferSource): (WebCore::AudioContext::createJavaScriptNode): (WebCore::AudioContext::createLowPass2Filter): (WebCore::AudioContext::createHighPass2Filter): (WebCore::AudioContext::createPanner): (WebCore::AudioContext::createConvolver): (WebCore::AudioContext::createAnalyser): (WebCore::AudioContext::createGainNode): (WebCore::AudioContext::createDelayNode): (WebCore::AudioContext::createChannelSplitter): (WebCore::AudioContext::createChannelMerger): (WebCore::AudioContext::notifyNodeFinishedProcessing): (WebCore::AudioContext::derefFinishedSourceNodes): (WebCore::AudioContext::refNode): (WebCore::AudioContext::derefNode): (WebCore::AudioContext::derefUnfinishedSourceNodes): (WebCore::AudioContext::lock): (WebCore::AudioContext::tryLock): (WebCore::AudioContext::unlock): (WebCore::AudioContext::isAudioThread): (WebCore::AudioContext::isGraphOwner): (WebCore::AudioContext::addDeferredFinishDeref): (WebCore::AudioContext::handlePostRenderTasks): (WebCore::AudioContext::handleDeferredFinishDerefs): (WebCore::AudioContext::markForDeletion): (WebCore::AudioContext::deleteMarkedNodes):
  • webaudio/AudioContext.h: Added. (WebCore::AudioContext::destination): (WebCore::AudioContext::currentTime): (WebCore::AudioContext::sampleRate): (WebCore::AudioContext::listener): (WebCore::AudioContext::temporaryMonoBus): (WebCore::AudioContext::temporaryStereoBus): (WebCore::AudioContext::incrementConnectionCount): (WebCore::AudioContext::connectionCount): (WebCore::AudioContext::setAudioThread): (WebCore::AudioContext::audioThread): (WebCore::AudioContext::isAudioThreadFinished): (WebCore::AudioContext::AutoLocker::AutoLocker): (WebCore::AudioContext::AutoLocker::~AutoLocker): (WebCore::AudioContext::RefInfo::RefInfo):
  • webaudio/AudioContext.idl: Added.
10:37 AM Changeset in webkit [68162] by jberlin@webkit.org
  • 3 edits in trunk/WebKit2

Expose the BundlePage on the BundleFrame in the API.
https://bugs.webkit.org/show_bug.cgi?id=46366

Reviewed by Sam Weinig.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetPage):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
10:32 AM Changeset in webkit [68161] by jorlow@chromium.org
  • 5 edits in trunk

2010-09-23 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB shouldn't crash on invalid index names
https://bugs.webkit.org/show_bug.cgi?id=46362

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2010-09-23 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB shouldn't crash on invalid index names
https://bugs.webkit.org/show_bug.cgi?id=46362

For now, return null. In a later patch, we'll do proper exception raising.

  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::index):
10:29 AM Changeset in webkit [68160] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=43667
ASSERT failure in NetscapePluginInstanceProxy::disconnectStream

Test: plugins/get-javascript-url.html

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just like any other one.
10:27 AM Changeset in webkit [68159] by andersca@apple.com
  • 3 edits in trunk/WebKit2

It should be possible to conditionally define an entire group of messages
https://bugs.webkit.org/show_bug.cgi?id=46368

Reviewed by Adam Roben.

  • Scripts/webkit2/messages.py:

Check for a condition when parsing the "messages -> " string and set it as the
message receiver condition.

  • Scripts/webkit2/messages_unittest.py:

Add test.

10:21 AM Changeset in webkit [68158] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Fix the memory safety issue by checking containerObject is a RenderBox
before doing the transforms.
https://bugs.webkit.org/show_bug.cgi?id=46365

Test: compositing/overflow/get-transform-from-non-box-container.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):

2010-09-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we donot assert on object->isBox.
https://bugs.webkit.org/show_bug.cgi?id=46365

  • compositing/overflow/get-transform-from-non-box-container-expected.txt: Added.
  • compositing/overflow/get-transform-from-non-box-container.html: Added.
10:17 AM Changeset in webkit [68157] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46314.

Reviewed by Simon Fraser.

The RenderView's block-flow should match the root element's block-flow. When we create (or re-create) the style for the document, take
the block-flow from the document element's style and use it if it's available.

Also patch styleDidChange so that if the block-flow changes dynamically after we have already made the document style, we'll propagate
the change back up to the RenderView and have it do a relayout.

No tests possible yet, since you can't see the document's style anywhere, and block-flow isn't doing anything to affect layout
yet.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

10:11 AM Changeset in webkit [68156] by kenneth@webkit.org
  • 2 edits
    2 adds in trunk/WebKit2

Add a preference class for Qt for WebKit2.

Reviewed by Andreas Kling.

  • UIProcess/API/qt/qwkpreferences.cpp: Added.

(QWKPreferences::globalPreferences):
(QWKPreferences::QWKPreferences):
(QWKPreferences::~QWKPreferences):
(QWKPreferences::testAttribute):
(QWKPreferences::setAttribute):

  • UIProcess/API/qt/qwkpreferences.h: Added.
  • WebKit2.pro:
10:10 AM Changeset in webkit [68155] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-09-23 Dimitri Glazkov <Dimitri Glazkov>

Remove passing tests. These were failing because the bot was missing QuickTime.

  • platform/chromium/drt_expectations.txt: Removed QuickTime-dependent tests after installing QuickTime on the build bot.
9:56 AM Changeset in webkit [68154] by demarchi@webkit.org
  • 5 edits in trunk/WebKit/efl

2010-09-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Csaba Osztrogonác.

[EFL] Fix warnings during build
https://bugs.webkit.org/show_bug.cgi?id=46354

  • ewk/ewk_frame.cpp: (ewk_frame_text_matches_nth_pos_get): Change argument type because it's meant to be always positive.
  • ewk/ewk_frame.h: Ditto.
  • ewk/ewk_view.cpp: (ewk_view_exceeded_database_quota): Add missing "%" causing warning about number of arguments to printf-like function.
  • ewk/ewk_view.h: Add missing initialization.
9:46 AM Changeset in webkit [68153] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Message autogeneration script should parse sync message syntax
https://bugs.webkit.org/show_bug.cgi?id=46359

Reviewed by Adam Roben.

  • Scripts/webkit2/messages.py:

(MessageReceiver.parse): Expand the regular expression to handle sync messages.
(function_parameter_type): Use a const reference for all parameters except the known builtins.
(base_class): Returns the base class for a sync message reply struct.
(delayed_base_class): Returns the base class for a delayed sync message reply struct.

  • Scripts/webkit2/messages_unittest.py:

Add unit tests for various sync messages.

9:45 AM Changeset in webkit [68152] by caseq@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-23 Andrey Kosyakov <caseq@chromium.org>

Unreviewed build fix ("WTF/" -> "wtf/" in include, broke Arm build)

  • src/AsyncFileWriterChromium.h:
9:37 AM Changeset in webkit [68151] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-09-23 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: source frame popups shouldn't disappear when hovered
https://bugs.webkit.org/show_bug.cgi?id=46358

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseMove):
9:21 AM Changeset in webkit [68150] by demarchi@webkit.org
  • 2 edits in trunk

2010-09-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Enable warnings during build by default
https://bugs.webkit.org/show_bug.cgi?id=46351

Change default build to enable several warnings like other ports do.
We need to pay special attention to "-Wall" in order to produce better
code, so highlight this keyword, too.

  • cmake/WebKitHelpers.cmake:
9:20 AM Changeset in webkit [68149] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-23 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Regression][Gtk] Left and Right Arrows no longer function when caret browsing is enabled
https://bugs.webkit.org/show_bug.cgi?id=45375

Added the following test to make sure key navigation across a
paragraph always work as expected, both with and without the shift
and ctrl modifiers.

  • platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Added.
  • platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html: Added.

2010-09-23 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Regression][Gtk] Left and Right Arrows no longer function when caret browsing is enabled
https://bugs.webkit.org/show_bug.cgi?id=45375

Consider caret browsing for Move commands.

Test: platform/gtk/editing/selection/caret-mode-left-right-arrows.html

  • editing/EditorCommand.cpp: (WebCore::createCommandMap): Use "caret browsing aware functions" as isEnabled() function for those commands moving the caret forward and backward across characters, words, lines or paragraphs, not just left and right, as it was the case so far.
9:18 AM Changeset in webkit [68148] by mitz@apple.com
  • 2 edits in trunk/WebCore

Address a remaining discrepancy in piecewise text measurement
https://bugs.webkit.org/show_bug.cgi?id=45796

Patch by Brad Moore <bradm@apple.com> on 2010-09-23
Reviewed by Dan Bernstein.

Don't include always-integral space widths in the floating point accumulator designed
to minimize precision loss. This brings whole-string measurement in line with piecewise
text measurement when dealing with fonts with fractional advances.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance): Change the associativity of width addition to minimize precision loss.

9:12 AM Changeset in webkit [68147] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Cleanup network communication code in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46200

Add logic for request handling directly into ResourceHandle::start and fix style.
Use Unicode instead of ASCII Windows API functions.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::start):
8:56 AM Changeset in webkit [68146] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-23 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Andreas Kling.

Invalid assertion in ScriptCallback
https://bugs.webkit.org/show_bug.cgi?id=46348

Removing invalid ASSERT from method ScriptCallback::call().

  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptCallback::call):
8:51 AM Changeset in webkit [68145] by mrobinson@webkit.org
  • 7 edits
    2 moves
    2 adds in trunk/WebCore

2010-09-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ariya Hidayat.

[Cairo] Generalize ContextShadow from the Qt port and use it for shadow code
https://bugs.webkit.org/show_bug.cgi?id=45599

Make ContextShadow platform-independent and add a Cairo implementation. This is currently
disabled for Cairo, but will be enabled in a followup patch with new baselines.

No new tests as this does not change functionality.

  • GNUmakefile.am: Update source lists.
  • WebCore.pro: Update source lists.
  • platform/graphics/ContextShadow.cpp: Added. A generalized version of Qt's ContextShadow. (WebCore::ContextShadow::ContextShadow): (WebCore::ContextShadow::clear): (WebCore::ContextShadow::blurLayerImage): (WebCore::ContextShadow::calculateMinimalLayerRect):
  • platform/graphics/ContextShadow.h: Added. (WebCore::ContextShadow::offset):
  • platform/graphics/cairo/CairoUtilities.cpp: Added. (WebCore::setSourceRGBAFromColor): A utility to set the source RGBA on a Cairo surface from a WebCore color.
  • platform/graphics/cairo/CairoUtilities.h: Added.
  • platform/graphics/cairo/ContextShadowCairo.cpp: Added. (WebCore::purgeScratchBuffer): Static function to purge the shadow buffer. (WebCore::PurgeScratchBufferTimer::fired): Timer callback. (WebCore::scheduleScratchBufferPurge): Schedule's a WebCore timer to purge the shadow buffer. (WebCore::getScratchBuffer): Create or reuse the scratch buffer. (WebCore::ContextShadow::beginShadowLayer): Added. (WebCore::ContextShadow::endShadowLayer): Added.
  • platform/graphics/gtk/CairoUtilities.cpp: Removed.
  • platform/graphics/gtk/CairoUtilities.h: Removed.
  • platform/graphics/gtk/GdkCairoUtilities.cpp: Renamed from CairoUtilities.cpp. (getCairoSurfacePixel): (getGdkPixbufPixel): (cairoImageSurfaceToGdkPixbuf):
  • platform/graphics/gtk/GdkCairoUtilities.h: Added.
  • platform/graphics/gtk/ImageBufferGtk.cpp:
  • platform/graphics/gtk/ImageGtk.cpp:
  • platform/graphics/qt/ContextShadow.cpp: Removed.
  • platform/graphics/qt/ContextShadow.h: Removed.
  • platform/graphics/qt/ContextShadowQt.cpp: Added. Adapted from code originally in ContextShadow.cpp. (WebCore::ShadowBuffer::ShadowBuffer): (WebCore::ShadowBuffer::scratchImage): (WebCore::ShadowBuffer::schedulePurge): (WebCore::ShadowBuffer::timerEvent): (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): Updated to reflect new ContextShadow members.
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::hasShadow): Updated to reflect new ContextShadow members. (WebCore::GraphicsContext::strokeArc): Ditto. (WebCore::GraphicsContext::drawConvexPolygon): Ditto. (WebCore::GraphicsContext::fillPath): Ditto. (WebCore::GraphicsContext::strokePath): Ditto. (WebCore::GraphicsContext::fillRect): Ditto. (WebCore::GraphicsContext::fillRoundedRect): Ditto. (WebCore::GraphicsContext::setPlatformShadow): Ditto.
8:39 AM Changeset in webkit [68144] by Patrick Gansterer
  • 4 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add internetStatusCallback to ResourceHandleWin.
https://bugs.webkit.org/show_bug.cgi?id=46187

Add callback for asynchronous network transfer.

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::callOnRedirect): (WebCore::callOnRequestComplete): (WebCore::ResourceHandle::internetStatusCallback): (WebCore::ResourceHandle::onRedirect):
8:37 AM Changeset in webkit [68143] by andreip@google.com
  • 2 edits in trunk/WebCore

2010-09-23 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBTransactionCoordinator contains a broken assertion.
https://bugs.webkit.org/show_bug.cgi?id=46356

Remove the broken assertion.

  • storage/IDBTransactionCoordinator.cpp: (WebCore::IDBTransactionCoordinator::processStartedTransactions):
8:29 AM Changeset in webkit [68142] by andreas.kling@nokia.com
  • 2 edits in trunk/JavaScriptCore

2010-09-23 Ismail Donmez <ismail@namtrac.org>

Reviewed by Andreas Kling.

Fix jsc.exe build for Windows CE

  • jsc.pro: Add mmtimer.lib for Windows CE.
8:29 AM Changeset in webkit [68141] by tonyg@chromium.org
  • 5 edits
    2 adds in trunk/WebKit/chromium

2010-09-08 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add chromium port API for accessing Web Timing information
https://bugs.webkit.org/show_bug.cgi?id=45428

  • WebKit.gyp:
  • public/WebFrame.h:
  • public/WebPerformance.h: Added. (WebKit::WebPerformance::WebPerformance):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::performance):
  • src/WebFrameImpl.h:
  • src/WebPerformance.cpp: Added. (WebKit::WebPerformance::WebPerformance): (WebKit::WebPerformance::~WebPerformance): (WebKit::WebPerformance::operator=): (WebKit::WebPerformance::navigationType): (WebKit::WebPerformance::navigationStart): (WebKit::WebPerformance::unloadEventEnd): (WebKit::WebPerformance::redirectStart): (WebKit::WebPerformance::redirectEnd): (WebKit::WebPerformance::redirectCount): (WebKit::WebPerformance::fetchStart): (WebKit::WebPerformance::domainLookupStart): (WebKit::WebPerformance::domainLookupEnd): (WebKit::WebPerformance::connectStart): (WebKit::WebPerformance::connectEnd): (WebKit::WebPerformance::requestStart): (WebKit::WebPerformance::requestEnd): (WebKit::WebPerformance::responseStart): (WebKit::WebPerformance::responseEnd): (WebKit::WebPerformance::loadEventStart): (WebKit::WebPerformance::loadEventEnd): (WebKit::WebPerformance::operator PassRefPtr<Performance>):
8:20 AM Changeset in webkit [68140] by podivilov@chromium.org
  • 3 edits in trunk/WebCore

2010-09-23 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: highlight DOM nodes when navigating the DOM with keyboard
https://bugs.webkit.org/show_bug.cgi?id=46346

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onselect):
  • inspector/front-end/treeoutline.js: (TreeOutline.prototype._treeKeyDown): (TreeElement.prototype.selectOnMouseDown): (TreeElement.prototype.select):
8:13 AM Changeset in webkit [68139] by andreip@google.com
  • 3 edits in trunk/WebCore

2010-09-23 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] Build broken due to missing include in IDBTransactionBackendImpl.h
https://bugs.webkit.org/show_bug.cgi?id=46352

No new tests needed, build fix.

  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::objectStore):
  • storage/IDBTransactionBackendImpl.h:
7:34 AM Changeset in webkit [68138] by andreip@google.com
  • 46 edits in trunk

2010-09-23 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBObjectStore::get should run in a transaction.
https://bugs.webkit.org/show_bug.cgi?id=44700

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

2010-09-23 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBObjectStore::get should run in a transaction.
https://bugs.webkit.org/show_bug.cgi?id=44700

Implements logic for running IDBObjectStore::get() in a transaction.
Refactors the pending transaction monitor and the transaction coordinator
to use pointers instead of transaction IDs.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::didLeaveScriptContext):
  • storage/IDBCursorBackendImpl.cpp:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::objectStore):
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::objectStore):
  • storage/IDBDatabaseBackendImpl.h: (WebCore::IDBDatabaseBackendImpl::transactionCoordinator):
  • storage/IDBFactoryBackendImpl.cpp:
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::get):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::create):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBTask::IDBTask): (WebCore::IDBTask::performTask): (WebCore::createTask): (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::getInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBPendingTransactionMonitor.cpp: (WebCore::IDBPendingTransactionMonitor::addPendingTransaction): (WebCore::IDBPendingTransactionMonitor::removePendingTransaction): (WebCore::IDBPendingTransactionMonitor::abortPendingTransactions):
  • storage/IDBPendingTransactionMonitor.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired):
  • storage/IDBRequest.h: (WebCore::IDBRequest::create):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::objectStore):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::create): (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::objectStore): (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::abort): (WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents): (WebCore::IDBTransactionBackendImpl::run): (WebCore::IDBTransactionBackendImpl::start): (WebCore::IDBTransactionBackendImpl::commit): (WebCore::IDBTransactionBackendImpl::timerFired):
  • storage/IDBTransactionBackendImpl.h: (WebCore::IDBTransactionBackendImpl::~IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::isFinished):
  • storage/IDBTransactionBackendInterface.h:
  • storage/IDBTransactionCoordinator.cpp: (WebCore::IDBTransactionCoordinator::createTransaction): (WebCore::IDBTransactionCoordinator::didStartTransaction): (WebCore::IDBTransactionCoordinator::didFinishTransaction): (WebCore::IDBTransactionCoordinator::processStartedTransactions):
  • storage/IDBTransactionCoordinator.h:

2010-09-23 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBObjectStore::get should run in a transaction.
https://bugs.webkit.org/show_bug.cgi?id=44700

  • public/WebIDBFactory.h:
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::didCompleteTaskEvents): (WebKit::WebIDBTransaction::getIDBTransactionBackendInterface):
  • src/IDBDatabaseProxy.h:
  • src/IDBFactoryBackendProxy.cpp:
  • src/IDBFactoryBackendProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::get):
  • src/IDBObjectStoreProxy.h:
  • src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::scheduleTask): (WebCore::IDBTransactionBackendProxy::didCompleteTaskEvents):
  • src/IDBTransactionBackendProxy.h: (WebCore::IDBTransactionBackendProxy::getWebIDBTransaction):
  • src/WebIDBFactoryImpl.cpp:
  • src/WebIDBFactoryImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get):
  • src/WebIDBObjectStoreImpl.h:
  • src/WebIDBTransactionImpl.cpp: (WebKit::WebIDBTransactionImpl::didCompleteTaskEvents): (WebKit::WebIDBTransactionImpl::getIDBTransactionBackendInterface):
  • src/WebIDBTransactionImpl.h:
7:24 AM Changeset in webkit [68137] by Patrick Gansterer
  • 1 edit
    2 adds in trunk/WebKit/wince

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add ChromeClientWinCE
https://bugs.webkit.org/show_bug.cgi?id=46294

  • WebCoreSupport/ChromeClientWinCE.cpp: Added.
  • WebCoreSupport/ChromeClientWinCE.h: Added.
7:24 AM Changeset in webkit [68136] by senorblanco@chromium.org
  • 6 edits in trunk/WebKitTools

2010-09-21 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=46208

This flag allows the layout tests to be run with or without accelerated
2D canvas rendering.

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Declare the new flag string, and check for it on startup.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Add a boolean for the new flag, in order to preserve its value over preferences reset. (TestShell::resetWebSettings): Set the new flag to the stored value on reset.
  • DumpRenderTree/chromium/TestShell.h: (TestShell::setAccelerated2dCanvasEnabled): Add an accessor for the new flag.
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): Initialize the new flag to false. (WebPreferences::applyTo): Copy the flag's value to the WebSettings.
  • DumpRenderTree/chromium/WebPreferences.h: Add the new flag.
7:22 AM Changeset in webkit [68135] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Remove usage of MemoryManager
https://bugs.webkit.org/show_bug.cgi?id=46206

MemoryManager does not provide any extra value, so remove it.

  • page/wince/FrameWinCE.cpp: (WebCore::imageFromSelection):
  • platform/graphics/wince/PlatformPathWinCE.cpp: (WebCore::drawPolygons):
7:14 AM Changeset in webkit [68134] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-23 Ismail Dönmez <ismail@namtrac.org>

Unreviewed.

JIT should be disabled on Windows CE. Broken in r64176.

  • wtf/Platform.h:
6:47 AM QtWebKitRelease20 edited by Ademar Reis
(diff)
6:36 AM Changeset in webkit [68133] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/win

2010-09-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Adam Roben.

Create one time initialization block for WebView's initWithFrame
https://bugs.webkit.org/show_bug.cgi?id=46307

  • WebView.cpp: Added one time initialization block for webview code that needs only be run once and not for each webview. This is just as the mac version WebView.mm does.
6:29 AM Changeset in webkit [68132] by Patrick Gansterer
  • 3 edits in trunk/WebKit/wince

2010-09-23 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Build fix for FrameLoaderClientWinCE.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::canShowMIMETypeAsHTML): Add missing method.
  • WebCoreSupport/FrameLoaderClientWinCE.h:
5:38 AM Changeset in webkit [68131] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-23 Jeremy Orlow <jorlow@chromium.org>

Unreviewed small fix for my last patch.

  • public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::id):
4:24 AM Changeset in webkit [68130] by vestbo@webkit.org
  • 1 add in trunk/WebKit/qt/examples/examples.pro

Fix Qt build by adding missing file

4:13 AM Changeset in webkit [68129] by abarth@webkit.org
  • 14 edits
    3 adds
    1 delete in trunk/LayoutTests

2010-09-23 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Sync HTML5lib tests with upstream.

  • html5lib/resources/comments01.dat:
  • html5lib/resources/pending-spec-changes-plain-text-unsafe.dat: Added.
  • html5lib/resources/pending-spec-changes.dat: Added.
  • html5lib/resources/plain-text-unsafe.dat: Added.
  • html5lib/resources/tests1.dat:
  • html5lib/resources/tests10.dat:
  • html5lib/resources/tests13.dat: Removed.
  • html5lib/resources/tests14.dat:
  • html5lib/resources/tests15.dat:
  • html5lib/resources/tests17.dat:
  • html5lib/resources/tests19.dat:
  • html5lib/resources/tests20.dat:
  • html5lib/resources/tests21.dat:
  • html5lib/resources/tests9.dat:
  • html5lib/resources/tests_innerHTML_1.dat:
  • html5lib/runner-expected.txt:
3:53 AM Changeset in webkit [68128] by vestbo@webkit.org
  • 9 edits in trunk

2010-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Refactor QtWebKitPlatformPlugin interface

Make it easier to keep source-compability for the
QtWebKitPlatformPlugin interface, and run qmake
on the example (but not build) for convenience.

https://bugs.webkit.org/show_bug.cgi?id=46345

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/QtPlatformPlugin.cpp:
  • examples/platformplugin/README:
  • examples/platformplugin/WebPlugin.cpp:
  • examples/platformplugin/WebPlugin.h:
  • examples/platformplugin/qwebkitplatformplugin.h:

2010-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Refactor QtWebKitPlatformPlugin interface

Make it easier to keep source-compability for the
QtWebKitPlatformPlugin interface, and run qmake
on the example (but not build) for convenience.

https://bugs.webkit.org/show_bug.cgi?id=46345

  • Scripts/webkitdirs.pm:
1:40 AM Changeset in webkit [68127] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-09-23 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Reduce the number of BOL checks in YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46260

Extend the YARR Interpreter with an optimization which reduces the number of
BOL assertion checks. If a "TypeBodyAlternative" byteTerm is followed by a
"TypeAssertionBOL" byteTerm it will be checked just one time.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::ByteCompiler::compile): (JSC::Yarr::ByteCompiler::regexBegin): (JSC::Yarr::ByteCompiler::alternativeBodyDisjunction): (JSC::Yarr::ByteCompiler::emitDisjunction):
  • yarr/RegexInterpreter.h: (JSC::Yarr::ByteTerm::BodyAlternativeBegin): (JSC::Yarr::ByteTerm::BodyAlternativeDisjunction): (JSC::Yarr::ByteTerm::BodyAlternativeEnd): (JSC::Yarr::ByteTerm::AlternativeBegin): (JSC::Yarr::ByteTerm::AlternativeDisjunction): (JSC::Yarr::ByteTerm::AlternativeEnd):
1:38 AM Changeset in webkit [68126] by Darin Adler
  • 3 edits in trunk/WebCore

2010-09-23 Darin Adler <Darin Adler>

Reviewed by Chris Fleizach.

media/video-controls-with-mutation-event-handler.html crashing
https://bugs.webkit.org/show_bug.cgi?id=46169

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement): Don't take a type argument. We can't set the type until after the element is created beacuse of reference counting rules. (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Don't pass the type. (WebCore::MediaControlMuteButtonElement::create): Set the type. (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): More of the same. (WebCore::MediaControlPlayButtonElement::create): Ditto. (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Ditto. (WebCore::MediaControlSeekButtonElement::create): Ditto. (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Ditto. (WebCore::MediaControlRewindButtonElement::create): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::create): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::create): Ditto. (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Ditto. (WebCore::MediaControlTimelineElement::create): Ditto. (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): Ditto. (WebCore::MediaControlVolumeSliderElement::create): Ditto. (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Ditto. (WebCore::MediaControlFullscreenButtonElement::create): Ditto.
  • rendering/MediaControlElements.h: Removed the type argument from the MediaControlInputElement constructor.
12:23 AM Changeset in webkit [68125] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Tweak some status messages that Eric thought were confusing
https://bugs.webkit.org/show_bug.cgi?id=46342

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:

Sep 22, 2010:

11:59 PM Changeset in webkit [68124] by commit-queue@webkit.org
  • 2 edits
    4 adds in trunk

2010-09-22 Luke Macpherson <macpherson@chromium.org>

Reviewed by Alexey Proskuryakov.

Don't allow empty strings as tokens in xmlhttprequest, as per rfc2616 section 2.2.

XMLHttpRequest: setRequestHeader() does not throw SYNTAX_ERR exception if the header field name is empty
https://bugs.webkit.org/show_bug.cgi?id=46151

Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-name.html

  • xml/XMLHttpRequest.cpp: (WebCore::isValidToken):
10:15 PM Changeset in webkit [68123] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2010-09-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Adam Barth.

[BREWMP] Enable touch events
https://bugs.webkit.org/show_bug.cgi?id=46321

Enable TOUCH_EVENTS by porting PlatformTouchEvent and PlatformTouchPoint.
Brew MP does not support multi touch, so enable only single touch for now.

  • platform/PlatformTouchEvent.h:
  • platform/PlatformTouchPoint.h:
  • platform/brew/PlatformTouchEventBrew.cpp: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent):
  • platform/brew/PlatformTouchPointBrew.cpp: Added. (WebCore::PlatformTouchPoint::PlatformTouchPoint):
9:55 PM Changeset in webkit [68122] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix comm-queue typo
https://bugs.webkit.org/show_bug.cgi?id=46339

We were missing a "self". The real problem is that we didn't have an
integration test for the failure case.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
9:33 PM Changeset in webkit [68121] by Dimitri Glazkov
  • 6 edits
    26 adds in trunk/LayoutTests

2010-09-22 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Rebaseline a few repainting tests for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=46337

  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/list-marker-expected.checksum:
  • platform/chromium-linux/fast/repaint/list-marker-expected.png:
  • platform/chromium-mac/fast/repaint/background-misaligned-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/background-misaligned-expected.png: Added.
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/chromium-mac/fast/repaint/continuation-after-outline-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/continuation-after-outline-expected.png: Added.
  • platform/chromium-mac/fast/repaint/inline-outline-repaint-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/inline-outline-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/opacity-change-on-overflow-float-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/opacity-change-on-overflow-float-expected.png: Added.
  • platform/chromium-mac/fast/repaint/subtree-root-clip-3-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/subtree-root-clip-3-expected.png: Added.
  • platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
  • platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
  • platform/chromium-win/fast/repaint/list-marker-expected.checksum:
  • platform/chromium-win/fast/repaint/list-marker-expected.png:
  • platform/chromium/test_expectations.txt: Updated, removed crazy comment.
9:19 PM Changeset in webkit [68120] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-09-22 Adam Barth <abarth@webkit.org>

Reviewed by John Sullivan.

New review-page design doesn't include name of reviewer
https://bugs.webkit.org/show_bug.cgi?id=46271

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
8:46 PM Changeset in webkit [68119] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-22 Adam Barth <abarth@webkit.org>

Fix typo in CSS.

  • PrettyPatch/PrettyPatch.rb:
8:42 PM Changeset in webkit [68118] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-09-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add link to bug to review page
https://bugs.webkit.org/show_bug.cgi?id=46192

To make room for the link, I moved the help text to the top of the page
and tweaked the language to help folks discover that you can select
context using the line numbers.

Also, move more text to sans-serif since that fits in better with the
pretty-patch fonts.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
8:11 PM Changeset in webkit [68117] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-09-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue should log more detailed messages to the QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=46333

When I created CommitQueueTask, I removed most of the previous logging.
This patch adds back more detailed logging so folks can see their patch
progress through the queue.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
7:57 PM Changeset in webkit [68116] by aestes@apple.com
  • 2 edits in trunk/WebCore

Fix a typo and correct an inaccurate phrase in a comment.

Rubber-stamped by Darin Adler.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

7:39 PM Changeset in webkit [68115] by aestes@apple.com
  • 8 edits
    3 adds in trunk

2010-09-22 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (r61285): <script /> parses differently in HTML5
https://bugs.webkit.org/show_bug.cgi?id=42909

If pre-HTML5 parser quirks are enabled, the HTMLTreeBuilder should
handle self-closing script tags like the old parser did. Specifically,
"<script />" should be treated as "<script></script>".

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): Instantiate HTMLTreeBuilder with the value of usePreHTML5ParserQuirks().
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processEndTag): If the tokenizer is not currently in DataState, this means that the current end token is fake and was created by the tree builder to handle a self-closing script tag. Assert that pre-HTML5 quirks are enabled and set the tokenizer's state to DataState in this case. (WebCore::HTMLTreeBuilder::processStartTagForInHead): If pre-HTML5 parser quirks are enabled and the script tag is self-closing, create and procses a fake script end tag.
  • html/parser/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::create):

2010-09-22 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (r61285): <script /> parses differently in HTML5
https://bugs.webkit.org/show_bug.cgi?id=42909

Add tests for the self-closing script tag quirk.

  • fast/parser/pre-html5-parser-quirks-expected.txt:
  • fast/parser/pre-html5-parser-quirks.html:
  • fast/parser/resources/pre-html5-parser-quirk-document-fragment.html:
  • fast/parser/resources/pre-html5-parser-quirk-self-closing-script-in-body.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-self-closing-script-in-head.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-self-closing-script.js: Added. (printToConsole):
7:08 PM Changeset in webkit [68114] by mihaip@chromium.org
  • 15 edits
    2 deletes in trunk

2010-09-22 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

[Chromium] User style layout tests don't pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=46069

User style tests should now pass with the Chromium DRT since we now
apply the styles immediately, just like the other ports (once we also
remove some bad baselines for user-style-top-frame-only added by
r62958).

Tests still don't pass with test_shell until it starts to use
InjectInExistingDocuments too.

  • platform/chromium-mac/userscripts/user-style-top-frame-only-expected.txt: Removed.
  • platform/chromium-win/userscripts/user-style-top-frame-only-expected.txt: Removed.
  • platform/chromium/drt_expectations.txt:

2010-09-22 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

[Chromium] User style layout tests don't pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=46069

Instead of making resetUserStyleCacheInAllFrames be a no-op for
Chromium, have it be controlled by a UserStyleInjectionTime enum.

Also move the UserStyleSheet::Level enum to be inside
UserStyleSheetTypes for consistency.

  • WebCore.exp.in:
  • dom/Document.cpp: (WebCore::Document::pageGroupUserSheets):
  • page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld):
  • page/PageGroup.h:
  • page/UserStyleSheet.h: (WebCore::UserStyleSheet::UserStyleSheet): (WebCore::UserStyleSheet::level):
  • page/UserStyleSheetTypes.h:

2010-09-22 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

[Chromium] User style layout tests don't pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=46069

Expose UserStyleInjectionTime in WebView.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebView::addUserStyleSheet):

2010-09-22 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

[Chromium] User style layout tests don't pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=46069

Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
behavior from other ports.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::addUserStyleSheet):
7:02 PM Changeset in webkit [68113] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-22 James Robinson <jamesr@chromium.org>

[chromium] Re-synchronizes features.gypi with upstream feature_overrides.gypi.

  • features.gypi:
6:55 PM Changeset in webkit [68112] by jamesr@google.com
  • 18 edits in trunk

2010-09-22 Ruben <chromium@hybridsource.org>

Reviewed by Tony Chang.

[chromium] added ifdefs for FreeBSD support
https://bugs.webkit.org/show_bug.cgi?id=46316

  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::platform):
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platformCallback):
  • dom/SelectElement.cpp:
  • loader/CachedFont.cpp:
  • page/EventHandler.cpp:
  • page/chromium/EventHandlerChromium.cpp:
  • platform/Scrollbar.cpp:
  • platform/chromium/ChromiumBridge.h:
  • platform/graphics/chromium/FontPlatformData.h:
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/skia/FontCustomPlatformData.h:

2010-09-22 Ruben <chromium@hybridsource.org>

Reviewed by Tony Chang.

[chromium] added ifdefs for FreeBSD support
https://bugs.webkit.org/show_bug.cgi?id=46316

  • WebKit.gyp:
  • features.gypi:
  • src/ChromiumBridge.cpp:
  • src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::spoolPage):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::mouseUp): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::setScrollbarColors): (WebKit::WebViewImpl::setSelectionColors):
6:48 PM Changeset in webkit [68111] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Replace instances of g_timeout_add() with g_idle_add() in testatk.c
https://bugs.webkit.org/show_bug.cgi?id=46284

Use g_idle_add() whenever g_timeout_add() was being used.

This is desired because it's better to rely on the main loop to
decide when it's a good moment to execute the task (when idle)
than manually setting a timeout, which also sets a minimum amount
of time needed to get the function executed.

  • tests/testatk.c: (testWekitAtkTextSelections): (testWebkitAtkGetExtents): (testWebkitAtkListsOfItems): (main):
6:31 PM Changeset in webkit [68110] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-22 Rafael Antognolli <antognolli@profusion.mobi>

Unreviewed build fix.

[EFL] Fix build due to latest EFL (Edje) changes.
https://bugs.webkit.org/show_bug.cgi?id=46317

Make the change int -> Edje_Load_Error (enum).

No new functionality, so no new tests.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::themePartCacheEntryReset): (WebCore::RenderThemeEfl::createEdje): (WebCore::RenderThemeEfl::applyPartDescriptions):
  • platform/efl/ScrollbarEfl.cpp: (ScrollbarEfl::setParent):
6:31 PM Changeset in webkit [68109] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-22 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, temporarily disabling the new filesystem test on chromium.

  • platform/chromium/test_expectations.txt:
6:27 PM Changeset in webkit [68108] by Chris Fleizach
  • 3 edits
    2 adds in trunk

WebCore: AX: aria-hidden change doesn't update the ax tree
https://bugs.webkit.org/show_bug.cgi?id=45836

Reviewed by Darin Adler.

Test: accessibility/aria-hidden-update.html

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests: [FileSystem] Fix Flags handling in DirectoryEntry custom binding code
https://bugs.webkit.org/show_bug.cgi?id=46028

Patch by Kinuko Yasuda <kinuko@chromium.org> on 2010-09-22
Reviewed by Dumitru Daniliuc.

  • fast/filesystem/flags-passing-expected.txt: Added.
  • fast/filesystem/flags-passing.html: Added.
  • fast/filesystem/script-tests/TEMPLATE.html: Added.
  • fast/filesystem/script-tests/flags-passing.js: Added.
  • platform/gtk/Skipped: FileSystem API not supported on gtk.
  • platform/mac/Skipped: FileSystem API not supported on mac.
  • platform/qt/Skipped: FileSystem API not supported on qt.
  • platform/win/Skipped: FileSystem API not supported on win.
6:20 PM Changeset in webkit [68107] by bfulgham@webkit.org
  • 6 edits
    2 adds in trunk

[WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
https://bugs.webkit.org/show_bug.cgi?id=46303.

Reviewed by Martin Robinson.

WebKit/win:

  • WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and

Release_Cairo configurations to select appropriate build
targets for WebKitTestRunner and MiniBrowser.

WebKitTools:

  • MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved

CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
property sheet.

  • MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
  • MiniBrowser/MiniBrowser.vcproj: Updated configuration to use

appropriate property sheet for the build types.

  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the

configuration to use appropriate property sheet for CoreFoundation
and CFLite-style builds.

6:18 PM Changeset in webkit [68106] by demarchi@webkit.org
  • 2 edits in trunk

2010-09-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Fix build with GCC 4.4.x
https://bugs.webkit.org/show_bug.cgi?id=40826

Change the -fstrict-aliasing flag to -fno-strict-aliasing as other
ports like GTK and QT are using in their build systems. It was failing
to execute when compiled with GCC 4.4.x in Release mode.

Refactor the flags in order to be more readable.

  • cmake/WebKitHelpers.cmake:
5:58 PM Changeset in webkit [68105] by kinuko@chromium.org
  • 8 edits
    6 adds in trunk

2010-09-22 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

[FileSystem] Fix Flags handling in DirectoryEntry custom binding code
https://bugs.webkit.org/show_bug.cgi?id=46028

Do not use adoptRef to get RefPtr from a raw pointer that is already
adopted in toNative/toJS.

Test: fast/filesystem/flags-passing.html

  • bindings/js/JSDirectoryEntryCustom.cpp: (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
  • bindings/v8/custom/V8DirectoryEntryCustom.cpp: (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):

2010-09-22 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

[FileSystem] Fix Flags handling in DirectoryEntry custom binding code
https://bugs.webkit.org/show_bug.cgi?id=46028

  • fast/filesystem/flags-passing-expected.txt: Added.
  • fast/filesystem/flags-passing.html: Added.
  • fast/filesystem/script-tests/TEMPLATE.html: Added.
  • fast/filesystem/script-tests/flags-passing.js: Added.
  • platform/gtk/Skipped: FileSystem API not supported on gtk.
  • platform/mac/Skipped: FileSystem API not supported on mac.
  • platform/qt/Skipped: FileSystem API not supported on qt.
  • platform/win/Skipped: FileSystem API not supported on win.
5:45 PM Changeset in webkit [68104] by tony@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-09-22 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] add baselines for xmlhttprequest tests for chromium
https://bugs.webkit.org/show_bug.cgi?id=46281

  • platform/chromium/http/tests/xmlhttprequest/methods-async-expected.txt: Allow no content-length for non-get/post requests
  • platform/chromium/http/tests/xmlhttprequest/methods-expected.txt: Allow no content-length for non-get/post requests
  • platform/chromium/test_expectations.txt: Enable 3 tests on linux + mac
5:44 PM Changeset in webkit [68103] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-22 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

Need to stop autocorrection panel timer when selection changes.
https://bugs.webkit.org/show_bug.cgi?id=46201
<rdar://problem/8441042>

  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): Stop correction timer after editing. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): When text checking is done for showing autocorrection panel, we suppress all corrections that are not at the end of text checking range. So that we don't replace other words while showing correction panel for the last word. (WebCore::Editor::stopCorrectionPanelTimer): Stop correction timer.
  • editing/Editor.h: Added stopCorrectionPanelTimer() method.
5:37 PM Changeset in webkit [68102] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/WebKitTools

2010-09-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Optimize commit-queue performance for green trees
https://bugs.webkit.org/show_bug.cgi?id=46254

This patch redesigns the controller logic for the commit-queue. In the
new design, the controller exercises much finer-grained control over
the landing process. In particular:

  • Patches that fail to apply now get rejected almost immediately.
  • Patches that fail to build get rejects after two builds (instead of three builds and one test run).
  • Patches that run into a flaky test now get accepted after one build and two test runs instead of three full build-and-test runs.

The main cost of these optimizations is that we don't find out the tree
has a failing test until the very end of the process, but if the tree
has a busted test, there's not much we can do anyway. We might as well
burn commit-queue resources spinning optimisticly.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/queues.py:
5:07 PM Changeset in webkit [68101] by commit-queue@webkit.org
  • 14 edits in trunk

2010-09-22 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dumitru Daniliuc.

Add Chromium implementation for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44361

No new tests; the implementation's not yet far enough along for that.

This makes a chain of contruction-and-linking-up for various sorts of
FileWriter interfaces to call through to Chromium, and for various
sorts of FileWriterClients to call back, with object ownership always
pointing towards the Chromium API. That is, the DOM object owns an
AsyncFileWriter, which owns its implementation object, and the reverse
(client) direction is raw pointers.

File metadata is looked up before the FileWriter is returned, so that
we know the file exists and can cache its length.

The WebCore part of this is simple and generic enough to handle
Chromium, so it should be easy for me to put in a WebCore-only
implementation next.

  • fileapi/AsyncFileWriter.h:
  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::createWriter):
  • fileapi/DOMFileSystem.h:
  • fileapi/FileSystemCallbacks.cpp: (WebCore::FileSystemCallbacksBase::didCreateFileWriter): (WebCore::FileWriterCallbacks::FileWriterCallbacks): (WebCore::FileWriterCallbacks::didCreateFileWriter):
  • fileapi/FileSystemCallbacks.h:
  • platform/AsyncFileSystem.h:
  • platform/AsyncFileSystemCallbacks.h:

2010-09-22 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dumitru Daniliuc.

Add Chromium implementation for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44361

No new tests; the implementation's not yet far enough along for that.

This makes a chain of construction-and-linking-up for various sorts of
FileWriter interfaces to call through to Chromium, and for various
sorts of FileWriterClients to call back, with object ownership always
pointing towards the Chromium API. That is, the DOM object owns an
AsyncFileWriter, which owns its implementation object, and the reverse
(client) direction is raw pointers.

File metadata is looked up before the FileWriter is returned, so that
we know the file exists and can cache its length.

The WebKit/chromium interface here is modeled after that of the
FileSystem.

  • public/WebFileInfo.h: (WebKit::WebFileInfo::WebFileInfo):
  • src/AsyncFileSystemChromium.cpp: (WebCore::FileWriterHelperCallbacks::FileWriterHelperCallbacks): (WebCore::FileWriterHelperCallbacks::didSucceed): (WebCore::FileWriterHelperCallbacks::didReadMetadata): (WebCore::FileWriterHelperCallbacks::didReadDirectory): (WebCore::FileWriterHelperCallbacks::didOpenFileSystem): (WebCore::FileWriterHelperCallbacks::didCreateFileWriter): (WebCore::FileWriterHelperCallbacks::didFail): (WebCore::AsyncFileSystemChromium::createWriter):
  • src/AsyncFileSystemChromium.h:
  • src/AsyncFileWriterChromium.cpp: (WebCore::AsyncFileWriterChromium::setWebFileWriter): (WebCore::AsyncFileWriterChromium::write): (WebCore::AsyncFileWriterChromium::didFail):
  • src/AsyncFileWriterChromium.h:
  • src/WebFileSystemCallbacksImpl.h:
5:06 PM Changeset in webkit [68100] by msaboff@apple.com
  • 5 edits in trunk

2010-09-22 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Fixed the cross over from alternatives executed once and
those that loop. This fixed the problem where the index
was getting messed up for looping alternatives causing an
infinite loop.
https://bugs.webkit.org/show_bug.cgi?id=46189

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateDisjunction):

2010-09-22 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Updated tests to include patterns similar to what caused the problems
in https://bugs.webkit.org/show_bug.cgi?id=46189.

  • fast/js/regexp-bol-expected.txt:
  • fast/js/script-tests/regexp-bol.js:
4:40 PM Changeset in webkit [68099] by abecsi@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-09-22 Andras Becsi <abecsi@webkit.org>

Speculative build fix for the Qt Windows bots.

  • Api/DerivedSources.pro:
4:34 PM Changeset in webkit [68098] by bfulgham@webkit.org
  • 6 edits
    2 adds in trunk

WebKit/win: [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.rt
https://bugs.webkit.org/show_bug.cgi?id=46303.

Reviewed by Martin Robinson.

  • WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and

Release_Cairo configurations to select appropriate build
targets for InjectionBundle.

WebKitTools: [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
https://bugs.webkit.org/show_bug.cgi?id=46303.

Reviewed by Martin Robinson.

  • DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources

for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
WinCairo build.

  • WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
  • WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo

build targets that use the new InjectedBundleCFLite.vsprops file.

4:20 PM Changeset in webkit [68097] by abecsi@webkit.org
  • 3 edits in trunk/WebKit2

2010-09-22 Andras Becsi <abecsi@webkit.org>

Unreviewed build fix after r68079.

[Qt] Also generate WebPage's message-receiving code and message types
for the Qt port of WebKit2.

  • DerivedSources.pro:
  • WebKit2.pro:
4:12 PM Changeset in webkit [68096] by ap@apple.com
  • 6 edits
    2 adds in trunk

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=46222
<rdar://problem/8461701> Document.getElementById() malfunctions if ID was changed via Attr node modification.

Test: fast/dom/Attr/change-id-via-attr-node-value.html

  • dom/Attr.h:
  • dom/Attr.cpp: (WebCore::Attr::setValue): Separated a version callable from WebCore from one avaiable to JS. Attr::setValue() can be called from Element::setAttribute(), and we don't want to update m_elementsById (or to call attributeChanged()) twice in that case. (WebCore::Attr::childrenChanged): If Attr's node children change, id changes.
  • dom/Document.cpp: (WebCore::Document::removeElementById): Added an assertion that we are not trying to remove something that isn't there. If we are, we probably failed to update m_elementsById earlier.
  • dom/Element.cpp: (WebCore::Element::setAttribute): If the attribute has an Attr node, its children should be updated to match attribute value.
4:06 PM Changeset in webkit [68095] by sfalken@apple.com
  • 2 edits in tags/Safari-534.8.1/JavaScriptCore

Merge r68092.

4:02 PM Changeset in webkit [68094] by sfalken@apple.com
  • 5 edits in tags/Safari-534.8.1

Versioning.

3:53 PM Changeset in webkit [68093] by sfalken@apple.com
  • 1 copy in tags/Safari-534.8.1

New tag.

3:49 PM Changeset in webkit [68092] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Allow jsc.exe to be run against unversioned ICU.

Rubber stamped by Jon Honeycutt.

3:40 PM Changeset in webkit [68091] by tony@chromium.org
  • 4 edits
    2 adds in trunk/LayoutTests

2010-09-22 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Rebaseline 3 tests on win/linux
https://bugs.webkit.org/show_bug.cgi?id=46315

  • platform/chromium-linux/editing/selection/move-by-line-001-expected.checksum: Minor differences in how text and borders are anti-aliased.
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-win/fast/dom/Element/getBoundingClientRect-expected.txt: This test is sensitive to font metrics. They appear correct visually, just positioned slightly different vertically.
  • platform/chromium-win/fast/dom/Range/getBoundingClientRect-expected.txt: Same as above.
  • platform/chromium/test_expectations.txt:
3:35 PM Changeset in webkit [68090] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-22 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] remove commented out test failures from test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=46313

  • platform/chromium/test_expectations.txt:
3:11 PM Changeset in webkit [68089] by hyatt@apple.com
  • 4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46311, lock form controls and replaced elements to vertical block flow.

Reviewed by Dan Bernstein.

Patch form controls that don't use RenderReplaced by hand in html.css. Patch all RenderReplaced elements
with an override of setStyle that forces the new style to have a vertical block flow. We have to do something like
this to cover the CSS3 content: url(img) method of image replacement.

  • css/html.css:

(input, textarea, keygen, select, button, isindex, meter, progress):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::setStyle):

  • rendering/RenderReplaced.h:
3:07 PM Changeset in webkit [68088] by andersca@apple.com
  • 2 edits
    2 adds in trunk/WebKit2

Stub out a PluginProcessManager class
https://bugs.webkit.org/show_bug.cgi?id=46305

Reviewed by Adam Roben.

  • UIProcess/Plugins/PluginProcessManager.cpp: Added.

(WebKit::PluginProcessManager::shared):
(WebKit::PluginProcessManager::getPluginProcessConnection):
(WebKit::PluginProcessManager::removePluginProcessProxy):

  • UIProcess/Plugins/PluginProcessManager.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
3:05 PM Changeset in webkit [68087] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-09-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Laszlo Gombos.

Use "typedef wchar_t JSChar" when compiled with RVCT
https://bugs.webkit.org/show_bug.cgi?id=40651

Use wchar_t for JSChar and UChar when compiled with RVCT.
Linux is the exception for this rule.

  • API/JSStringRef.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
3:03 PM Changeset in webkit [68086] by atwilson@chromium.org
  • 16 edits
    1 add
    2 deletes in trunk/LayoutTests

Unreviewed chromium test expectation changes.

  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Removed.
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
2:56 PM Changeset in webkit [68085] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-22 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix bustage of rebaseline-chromium-webkit-tests resulting from
r67974. Really need better unit tests for this tool :(

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2:43 PM Changeset in webkit [68084] by Adam Roben
  • 2 edits in trunk/WebKitTools

Unbreak test-webkitpy

  • Scripts/webkitpy/test/main.py:

(Tester.run_tests): Add a line that mysteriously got deleted.

2:37 PM Changeset in webkit [68083] by hyatt@apple.com
  • 4 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46304

Reviewed by Dan Bernstein.

display:inline should become display:inline-block when an object's block flow does not match its parent's block flow.

Added fast/blockflow/display-mutation.html

WebCore:

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::adjustRenderStyle):

  • css/CSSStyleSelector.h:

LayoutTests:

  • fast/blockflow/display-mutation-expected.txt: Added.
  • fast/blockflow/display-mutation.html: Added.
2:37 PM Changeset in webkit [68082] by kenneth@webkit.org
  • 4 edits in trunk/WebKit2

Add a ViewportConfiguration class for the Qt WebKit2 API, which
currently calculated a fallback viewport configuration.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-09-22
Reviewed by Antonio Gomes.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::ViewportConfiguration::ViewportConfiguration):
(QWKPage::ViewportConfiguration::~ViewportConfiguration):
(QWKPage::ViewportConfiguration::operator=):
(QWKPage::viewportConfigurationForSize):

  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:

(QtViewportConfigurationPrivate::QtViewportConfigurationPrivate):

2:14 PM Changeset in webkit [68081] by Adam Roben
  • 2 edits in trunk/WebKit2

Windows build fix

  • WebProcess/WebKitMain.cpp:

(WebKitMain): Fix typo

1:44 PM Changeset in webkit [68080] by Adam Roben
  • 3 edits in trunk/WebKitTools

Make test-webkitpy test WebKit2's scripts

These scripts can't be in WebKitTools due to limitations of Apple's
build process. But that doesn't mean we can't test them!

Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
WebKit2/Scripts

Reviewed by Adam Barth.

  • Scripts/test-webkitpy:

(_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
Now takes an external_package_paths parameter and cleans both webkitpy
and any external packages.
(init): Added an external_package_paths parameter which we pass along
to _clean_packages_with_test.
(top level): Add WebKit2/Scripts/webkit2 as our only external package
and pass it along to init and Tester.run_tests.

  • Scripts/webkitpy/test/main.py:

(Tester.run_tests): Added an optional external_package_paths
parameter. We modify sys.path so that the external packages can be
imported, and search for unittest files inside all external packages
in addition to inside webkitpy.

1:43 PM Changeset in webkit [68079] by Adam Roben
  • 13 edits
    11 adds
    1 delete in trunk/WebKit2

Autogenerate WebPage's message-receiving code and message types

This patch encompasses several changes that allow message types and
receiving code to be generated by a script, and add some type-safety
as a bonus. Messages are now represented by structs instead of an ID +
ArgumentCoder. The struct contains the arguments and the ID together,
and has a constructor that enforces the use of correct types.
Correspondingly, a new overload of WebProcessProxy::send that takes a
message struct (instead of a message ID and separate arguments) has
been added. Eventually all callers should use this overload and the
old one can be removed.

This patch only touches WebPage's messages. We should transition other
message receivers over to this new system eventually.

Fixes <http://webkit.org/b/43636> <rdar://problem/8282462> Add a
type-safe IPC mechanism to WebKit2

Reviewed by Anders Carlsson.

  • DerivedSources.make: Added. Calls generate-message-receiver.py and

generate-messages-header.py for each message receiver it knows about
(just WebPage for now).

  • Platform/CoreIPC/Arguments.h: Added First/Second/ThirdArgumentType

typedefs for use in handleMessage.

  • Platform/CoreIPC/HandleMessage.h: Added.

(CoreIPC::handleMessage): This overloaded function template decodes
arguments and passes them along to the specified function.

  • Scripts/generate-message-receiver.py: Added.
  • Scripts/generate-messages-header.py: Added.

These scripts just wrap functionality in messages.py.

  • Scripts/webkit2/init.py: Added. This just exists so that Python

will treat this directory as a package.

  • Scripts/webkit2/messages.py: Added. Contains the code to parse

messages files and generate .cpp/.h files from them.
(MessageReceiver.init): This class represents a single receiver of
messages.
(MessageReceiver.iterparameters): Returns a generator that can be used
to iterate over all the parameters of all the messages of this
receiver.
(MessageReceiver.parse): Reads a messages file from a file-like object
and parses it into a MessageReceiver object.
(Message.init): This class represents a single message.
(Message.id): Returns the ID name for this message.
(Parameter.init): This class represents a single parameter for a
message.
(messages_header_filename): Returns the name of the header that
defines the messages for a given receiver.
(surround_in_condition): Surrounds the given string in #if/#endif if
there is an associated condition.
(messages_to_kind_enum): Returns a string that defines the Kind enum
for these messages.
(function_parameter_type): Returns the type that should be used when
passing a value of the given type as a parameter to a function.
(base_class): Returns the base class for a message struct.
(message_to_struct_declaration): Returns a string that declares the
struct for this message.
(forward_declarations_for_namespace): Returns a string that contains
forward-declarations for a set of types in a given namespace.
(forward_declarations): Returns a string that contains all the
forward-declarations needed in order to declare all the message
structs for this receiver.
(generate_header_file): Returns a string containing the messages
header file for this receiver.
(handler_function): Returns the name of the function that handles a
given message for a given receiver.
(case_statement): Returns a string containing a case statement for
handling the given message.
(header_for_type): Returns the header needed to define a given type,
enclosed in quotes or angle brackets as needed.
(generate_message_handler): Returns a string containing the contents
of a .cpp file that defines a didReceive*Message function.

  • Scripts/webkit2/messages_unittest.py: Added. Contains tests for

messages.py.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h: Removed. This has been

replaced by a generated WebPageMessages.h header.

  • UIProcess/WebEditCommandProxy.cpp:
  • UIProcess/WebPageProxy.cpp:

Updated to use the new message structs and WebProcessProxy::send
overload.

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::send): Added this new overload that takes a
message struct.

  • WebKit2.xcodeproj/project.pbxproj: Added a Derived Sources shell

script target that invokes DerivedSources.make. Added "Derived
Sources" and "Scripts" groups that contain the various new files.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceivePolicyDecision):
(WebKit::WebPage::getSourceForFrame):
Changed these functions to take the raw IPC types and do the necessary
translation themselves. This keeps the generated code from need to
know how to perform the translation.

(WebKit::WebPage::didReceiveMessage): Replaced handling of WebPage
messages with a call to didReceiveWebPageMessage, whose implementation
is generated by the scripts.

  • WebProcess/WebPage/WebPage.h: Added didReceiveWebPageMessage.
  • WebProcess/WebPage/WebPage.messages.in: Added. This file declares

all of the messages that WebPage receives, roughly grouped by
functionality.

  • win/WebKit2.vcproj: Added "Derived Sources" and "Scripts" filters

that contain the various new files. Let VS resort some other files.

  • win/WebKit2Common.vsprops: Added

$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources to the include
path so that the generated messages header can be found.

  • win/WebKit2.make: Copy the generated source files to $(DSTROOT).
  • win/WebKit2Generated.make: Added a call to build-generated-files.sh.
  • win/WebKit2Generated.vcproj: Added build-generated-files.sh.
  • win/build-generated-files.sh: Added. Invokes DerivedSources.make.
1:43 PM Changeset in webkit [68078] by commit-queue@webkit.org
  • 15 edits in trunk

2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] object:text-changed events should be emitted for entries and password text
https://bugs.webkit.org/show_bug.cgi?id=25898

Implement proper 'text-changed' signal emission for the GTK port

Call deleteTextFromNode() when needed while removing text nodes.
Do it even when removeNode() is going to be called afterwards, in
order to allow accessibility to get properly notified about the
text being removed alongside with that node.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete):

New function in AXObjectCache to call when text changes in a node.
Added one new function to allow notifying something changed in a
text node through the associated RenderObject, making such a
function dependant on the platform-specific implementation,
provided through a protected function (provided a proper
implementation for the GTK port and a dummy one for the others).

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::nodeTextChangeNotification): New
  • accessibility/AXObjectCache.h: (WebCore::AXObjectCache::AXTextChange): New enumeration (WebCore::AXObjectCache::nodeTextChangeNotification): New (WebCore::AXObjectCache::nodeTextChangePlatformNotification): New
  • accessibility/AccessibilityRenderObject.h: (WebCore::toAccessibilityRenderObject):
  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::nodeTextChangePlatformNotification): New
  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::emitTextChanged): (WebCore::AXObjectCache::nodeTextChangePlatformNotification): New
  • accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::nodeTextChangePlatformNotification): New
  • accessibility/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::nodeTextChangePlatformNotification): New

Notify accessibility when something changes in a text node.
Call to AXObjectCache::nodeTextChangeNotification() to notify when
text was inserted/deleted when applying/unapplying a text edition
command, along with the offset in the original text where the
change took place and the number of characters that got affected.

  • editing/AppendNodeCommand.cpp: (WebCore::sendAXTextChangedIgnoringLineBreaks): (WebCore::AppendNodeCommand::doApply): (WebCore::AppendNodeCommand::doUnapply):
  • editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::doApply): (WebCore::DeleteFromTextNodeCommand::doUnapply):
  • editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::doApply): (WebCore::InsertIntoTextNodeCommand::doUnapply):
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply): (WebCore::InsertNodeBeforeCommand::doUnapply): (WebCore::DeleteSelectionCommand::handleGeneralDelete):

2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] object:text-changed events should be emitted for entries and password text
https://bugs.webkit.org/show_bug.cgi?id=25898

New unit test to make sure text-changed signals are emitted

  • tests/testatk.c: (textChangedCb): New. Signal handler for the text-changed::insert and text-changed::delete signals. (checkTextChangesAndBailOut): New. Source function to check the global result of the test and quit from the main loop. (testWebkitAtkTextChangedNotifications): New test. (main):
1:27 PM Changeset in webkit [68077] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46298, add logicalWidth/Height getters/setters to RenderBox.

Reviewed by Dan Bernstein.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::logicalWidth):
(WebCore::RenderBox::logicalHeight):
(WebCore::RenderBox::setLogicalWidth):
(WebCore::RenderBox::setLogicalHeight):

  • rendering/RenderBox.h:
1:24 PM Changeset in webkit [68076] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-09-22 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[INTERPRETER] Two tests fail with SputnikError: #1.1: if argArray is neither an array nor an arguments object (see 10.1.8), a TypeError exception is thrown
https://bugs.webkit.org/show_bug.cgi?id=44245

Remove incorrect code from op_load_varargs in the interpreter.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
1:14 PM Changeset in webkit [68075] by andersca@apple.com
  • 10 edits in trunk/WebKit2

Enhance ProcessLauncher to be able to launch plug-in processes
https://bugs.webkit.org/show_bug.cgi?id=46295

Reviewed by Darin Adler.

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::ProcessLauncher):
Make the ProcessLauncher constructor take a LaunchOptions struct.

(WebKit::ProcessLauncher::processTypeAsString):
Given a process type, return its string representation.

(WebKit::ProcessLauncher::getProcessTypeFromString):
And vice versa.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):
Rename "mode" to "type" and pass the type as a string based on the LaunchOptions struct.
Also, set the launch architecture from the LaunchOptions struct.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:

(WebKit::ProcessLauncher::launchProcess):
Rename "mode" to "type."

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connect):
Initialize a LaunchOptions struct.

  • WebProcess/WebKitMain.cpp:

(WebKitMain):
Factor code that can be shared between the mac and windows WebKitMain code out into a
WebKitMain overload that takes a CommandLine.

  • WebProcess/WebProcessMain.h:
  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

  • WebProcess/win/WebProcessMainWin.cpp:

(WebKit::WebProcessMain):
Change WebProcessMain to take a const CommandLine reference instead of a pointer.

12:46 PM Changeset in webkit [68074] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-09-22 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Oliver Hunt.

Script engine agnostic ScriptCallback class
https://bugs.webkit.org/show_bug.cgi?id=43216

Refactoring class ScriptFunctionCall to create a class (ScriptCallback) that
receives a script function as a ScriptValue and calls that function with provided parameters.

  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptCallArgumentHandler::appendArgument): (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptCallback::ScriptCallback): (WebCore::ScriptCallback::call):
  • bindings/js/ScriptFunctionCall.h: (WebCore::ScriptCallArgumentHandler::ScriptCallArgumentHandler):
  • bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptCallArgumentHandler::appendArgument): (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptCallback::ScriptCallback): (WebCore::ScriptCallback::call):
  • bindings/v8/ScriptFunctionCall.h: (WebCore::ScriptCallArgumentHandler::ScriptCallArgumentHandler):
12:38 PM Changeset in webkit [68073] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: r68063 broke linux python tests

Add a missing "from future import with_statement" to this
new file; the perils of testing only on the Mac and by review :(

https://bugs.webkit.org/show_bug.cgi?id=46293

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
12:38 PM Changeset in webkit [68072] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed.

Build fix for invalid assertion after r68059.

  • editing/ApplyStyleCommand.cpp:

(WebCore::getPropertiesNotIn): Correct assertion target after
name change.

12:37 PM Changeset in webkit [68071] by inferno@chromium.org
  • 5 edits in trunk/LayoutTests

2010-09-22 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Rebaseline multicol/span tests for GTK, QT platforms as part of r68062.

  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
12:37 PM Changeset in webkit [68070] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Rename GetPluginHostConnection to GetPluginPath
https://bugs.webkit.org/show_bug.cgi?id=46292

Reviewed by Adam Roben.

Rename GetPluginHostConnection to GetPluginPath since this message will always get the
plug-in path. We'll add another message to actually get the connection.

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPluginPath):
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

12:35 PM Changeset in webkit [68069] by hyatt@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=45957, fix regression in column rules stacking test.

Reviewed by Simon Fraser.

WebCore:

Rewrite how the pagination bit gets set in RenderLayers, since it was totally broken and not
accounting for whether or not the columns block was even in the layer's containing block
hierarchy.

  • rendering/RenderLayer.cpp:

(WebCore::checkContainingBlockChainForPagination):
(WebCore::RenderLayer::updatePagination):

LayoutTests:

  • platform/mac/fast/multicol/column-rules-stacking-expected.checksum:
  • platform/mac/fast/multicol/column-rules-stacking-expected.png:
12:29 PM Changeset in webkit [68068] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-22 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium build fix. Fix build when accelerated
compositing is not enabled at compile time.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize):
12:18 PM Changeset in webkit [68067] by noam.rosenthal@nokia.com
  • 2 edits in trunk

2010-09-22 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Move the accelerated compositing build flag to the right place
https://bugs.webkit.org/show_bug.cgi?id=43882

  • WebKit.pri: Removed the redundant version check.
12:17 PM Changeset in webkit [68066] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed.

[WinCairo] Build fix for platform/cairo stuff after r67981.

  • WebCore.vcproj/WebCore.vcproj: Add new files needed by all cairo

ports.

12:12 PM Changeset in webkit [68065] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Move plug-in creation to WebPage::createPlugin
https://bugs.webkit.org/show_bug.cgi?id=46289

Reviewed by Adam Roben.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Call WebPage::createPlugin.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Create the plug-in.

12:11 PM Changeset in webkit [68064] by arv@chromium.org
  • 2 edits in trunk/WebCore

2010-09-22 Erik Arvidsson <arv@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Fix memory model for dataset
https://bugs.webkit.org/show_bug.cgi?id=46280

This is covered by existing tests.

  • bindings/v8/custom/V8DOMStringMapCustom.cpp: (WebCore::toV8):
12:06 PM Changeset in webkit [68063] by dpranke@chromium.org
  • 8 edits
    10 adds in trunk

2010-09-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Adds platform/chromium-gpu-* directories for holding the
GPU-accelerated baselines and expectations for Chromium.

https://bugs.webkit.org/show_bug.cgi?id=46225

  • platform/chromium-gpu/test_expectations.txt: Added.
  • platform/chromium-gpu-mac/README.txt: Added.
  • platform/chromium-gpu-win/README.txt: Added.
  • platform/chromium-gpu-linux/README.txt: Added.

2010-09-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Add a 'chromium-gpu' set of ports that will test the accelerated
GPU paths. This patch adds:

  • support for the '--accelerated-compositing' and 'accelerated-2d-canvas' flags to new-run-webkit-tests (and the 'no-' flags)
  • adds a new set of Ports that will look under platform/chromium-gpu-$OS/ for baselines before looking in the regular chromium search path
  • adds a new test_expectations.txt file in platform/chromium-gpu that skips all but the tests we actually want to run with acceleration.

This patch will allow us to run both with and without acceleration
and to change the defaults for both the regular and -gpu options
as the code evolves.

We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
each test bot.

https://bugs.webkit.org/show_bug.cgi?id=46225

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
12:03 PM Changeset in webkit [68062] by inferno@chromium.org
  • 9 edits
    4 adds in trunk

2010-09-22 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Fix wrong casts for table cell since its parent is not a RenderBlock. Remove
the redundant destroy call for empty anonymous columns or column span block.
https://bugs.webkit.org/show_bug.cgi?id=46245

Tests: fast/table/table-anonymous-block-destroy-crash.html

fast/table/table-columns-blocks-calc-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildToAnonymousColumnBlocks): (WebCore::RenderBlock::columnsBlockForSpanningElement): (WebCore::RenderBlock::removeChild):

2010-09-22 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that removing an anonymous block from a table cell does not result in crash.
Also, tests that calculating columns block for a table cell does not result in crash.
Rebaseline existing multicol span tests since we don't explicitly remove an empty
anonymous columns or column span blocks.
https://bugs.webkit.org/show_bug.cgi?id=46245

  • fast/table/table-anonymous-block-destroy-crash-expected.txt: Added.
  • fast/table/table-anonymous-block-destroy-crash.html: Added.
  • fast/table/table-columns-blocks-calc-crash-expected.txt: Added.
  • fast/table/table-columns-blocks-calc-crash.html: Added.
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
11:59 AM Changeset in webkit [68061] by mpcomplete@chromium.org
  • 12 edits in trunk

2010-09-22 Matt Perry <mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Trying to reland a version of r67749:
Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::allowScriptExtension):
  • loader/FrameLoaderClient.h:

2010-09-22 Matt Perry <mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Trying to reland a version of r67749:
Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721

  • public/WebFrameClient.h: (WebKit::WebFrameClient::allowScriptExtension):
  • public/WebScriptController.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowScriptExtension):
  • src/FrameLoaderClientImpl.h:
  • src/WebScriptController.cpp: (WebKit::WebScriptController::registerExtension):
11:59 AM Changeset in webkit [68060] by oliver@apple.com
  • 5 edits in trunk

2010-09-22 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[JIT] fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.5/S15.3.5.3_A2_T6.html fails
https://bugs.webkit.org/show_bug.cgi?id=44246

JIT code generated for instanceof was not checking to ensure that the prototype property was
an object, this patch ensures that it does.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emitSlow_op_instanceof):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emitSlow_op_instanceof):

2010-09-22 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[JIT] fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.5/S15.3.5.3_A2_T6.html fails
https://bugs.webkit.org/show_bug.cgi?id=44246

Correct expected output from this test.

  • fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.5/S15.3.5.3_A2_T6-expected.txt:
11:30 AM Changeset in webkit [68059] by rniwa@webkit.org
  • 7 edits
    2 adds in trunk

2010-09-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandState returns false for Underline command when no selection is made
https://bugs.webkit.org/show_bug.cgi?id=17594

The bug was caused by selectionComputedStyle's adding -webkit-text-decorations-in-effect property
to a dummy span used to obtain the computed style when there is a typing style.
Since this property is for internal use only, the CSS parser always stripped the property.
As a result, we were always ignoring the text decorations set by the typing style.

Fixed the bug by making selectionComputedStyle directly merge the computed style of the current
caret position and the typing style. This also eliminates the need for a dummy span element.
Due to the merge, the return value of selectionComputedStyle had to be changed to CSSMutableStyleDeclaration
from CSSComputedStyleDeclaration.

Test: editing/execCommand/query-text-decoration-with-typing-style.html

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): Calls getPropertiesNotIn. (WebCore::getPropertiesNotIn): Renamed from getPropertiesNotInComputedStyle since it takes CSSStyleDeclaration* instead of CSSComputedStyleDeclaration* for the second argument. (WebCore::ApplyStyleCommand::removeNonEditingProperties): Extracted from editingStyleAtPosition. (WebCore::ApplyStyleCommand::editingStyleAtPosition): Calls removeNonEditingProperties.
  • editing/ApplyStyleCommand.h:
  • editing/Editor.cpp: (WebCore::triStateOfStyle): Calls getPropertiesNotIn. Renamed from triStateOfStyleInComputedStyle since it no longer takes CSSComputedStyleDeclaration. (WebCore::Editor::selectionStartHasStyle): Calls selectionComputedStyle and triStateOfStyle. (WebCore::Editor::selectionHasStyle): Ditto. (WebCore::Editor::selectionStartCSSPropertyValue): Calls selectionComputedStyle. (WebCore::Editor::selectionComputedStyle): See above.
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeToggleStyleInList): Calls selectionComputedStyle.

2010-09-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandState returns false for Underline command when no selection is made
https://bugs.webkit.org/show_bug.cgi?id=17594

Added a test to ensure queryCommandValue('underline') and queryCommandValue('strikeThrough')
correctly incorporates the typing style.

  • editing/execCommand/query-text-decoration-with-typing-style-expected.txt: Added.
  • editing/execCommand/query-text-decoration-with-typing-style.html: Added.
11:14 AM Changeset in webkit [68058] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Random plug-in cleanups
https://bugs.webkit.org/show_bug.cgi?id=46279

Reviewed by Darin Adler.

  • WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):
Add CoreIPC coding support for the Plugin::Parameters struct.

  • WebProcess/Plugins/PluginController.h:

Add pluginProcessCrashed pure virtual member function.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):
handleEvent can be called when m_plugin is null.

(WebKit::PluginView::pluginProcessCrashed):
Ask the renderer to show the crashed plug-in indicator.

10:48 AM Changeset in webkit [68057] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Don't listen for some window notifications on all windows
https://bugs.webkit.org/show_bug.cgi?id=46277

Reviewed by John Sullivan.

Only listen for NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification notifications
on all windows; this matches old WebKit and fixes a crash where we would send notifications to views whose
underlying pages were invalid.

  • UIProcess/API/mac/WKView.mm:

(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):

10:33 AM Changeset in webkit [68056] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

2010-09-22 Jamey Hicks <jamey.hicks@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Web Inspector: Remote Web Inspector support for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=43988

Runs a web debug server on port specified by QtTestBrowser
argument -remote-inspector-port. Property
_q_webInspectorServerPort of the QWebPage instance will be set
according to the argument. All pages with that property set will
be remotely inspectable.

URL for remote inspection of first QWebPage is

http://localhost:9222/webkit/inspector/inspector.html?page=1

where 1 is the number of the QWebPage instance.

The base URL yields an index page with links to the individual inspectors:

http://localhost:9222/

  • WebCore.pro

2010-09-22 Jamey Hicks <jamey.hicks@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Web Inspector: Remote Web Inspector support for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=43988

Runs a web debug server on port specified by QtTestBrowser
argument -remote-inspector-port. Property
_q_webInspectorServerPort of the QWebPage instance will be set
according to the argument. All pages with that property set will
be remotely inspectable.

URL for remote inspection of first QWebPage is

http://localhost:9222/webkit/inspector/inspector.html?page=1

where 1 is the number of the QWebPage instance.

The base URL yields an index page with links to the individual inspectors:

http://localhost:9222/

  • Api/qwebinspector.cpp: (QWebInspectorPrivate::attachAndReplaceRemoteFrontend): (QWebInspectorPrivate::detachRemoteFrontend):
  • Api/qwebinspector_p.h: (QWebInspectorPrivate::QWebInspectorPrivate):
  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPagePrivate::inspectorServerPort):
  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::InspectorClientQt): (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorClientQt::attachAndReplaceRemoteFrontend): (WebCore::InspectorClientQt::detachRemoteFrontend): (WebCore::InspectorClientQt::sendMessageToFrontend):
  • WebCoreSupport/InspectorClientQt.h:
  • WebCoreSupport/InspectorServerQt.cpp: Added. (WebCore::generateWebSocketChallengeResponse): (WebCore::parseWebSocketChallengeNumber): (WebCore::InspectorServerQt::server): (WebCore::InspectorServerQt::InspectorServerQt): (WebCore::InspectorServerQt::~InspectorServerQt): (WebCore::InspectorServerQt::listen): (WebCore::InspectorServerQt::close): (WebCore::InspectorServerQt::inspectorClientForPage): (WebCore::InspectorServerQt::registerClient): (WebCore::InspectorServerQt::unregisterClient): (WebCore::InspectorServerQt::newConnection): (WebCore::InspectorServerRequestHandlerQt::InspectorServerRequestHandlerQt): (WebCore::InspectorServerRequestHandlerQt::~InspectorServerRequestHandlerQt): (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead): (WebCore::InspectorServerRequestHandlerQt::tcpConnectionDisconnected): (WebCore::InspectorServerRequestHandlerQt::webSocketSend): (WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead): (WebCore::RemoteFrontendChannel::RemoteFrontendChannel): (WebCore::RemoteFrontendChannel::sendMessageToFrontend):
  • WebCoreSupport/InspectorServerQt.h: Added.

2010-09-22 Jamey Hicks <jamey.hicks@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Web Inspector: Remote Web Inspector support for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=43988

Runs a web debug server on port specified by QtTestBrowser
argument -remote-inspector-port. Property
_q_webInspectorServerPort of the QWebPage instance will be set
according to the argument. All pages with that property set will
be remotely inspectable.

URL for remote inspection of first QWebPage is

http://localhost:9222/webkit/inspector/inspector.html?page=1

where 1 is the number of the QWebPage instance.

The base URL yields an index page with links to the individual inspectors:

http://localhost:9222/

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init):
  • QtTestBrowser/launcherwindow.h:
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
10:28 AM Changeset in webkit [68055] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Inline UTF8SequenceLength
https://bugs.webkit.org/show_bug.cgi?id=45589

  • wtf/unicode/UTF8.cpp: (WTF::Unicode::convertUTF8ToUTF16): Use inline version of UTF8SequenceLength to improve performance.
10:26 AM Changeset in webkit [68054] by Darin Adler
  • 18 edits in trunk

2010-09-21 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
https://bugs.webkit.org/show_bug.cgi?id=46220

  • Misc/WebNSFileManagerExtras.m: (setMetaData): Use CFRelease instead of HardRelease. (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Use CFStringCreateCopy instead of -[NSObject copy] combined with HardRetainWithNSRelease.

2010-09-21 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
https://bugs.webkit.org/show_bug.cgi?id=46220

  • WebCore.exp.in: Updated.
  • bindings/objc/ObjCEventListener.h: Use a RetainPtr for m_listener, since that will do a CFRetain, which is right for GC rather than an -[NSObject retain], which is not.
  • bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::ObjCEventListener): Removed explicit retain. (WebCore::ObjCEventListener::~ObjCEventListener): Removed explicit release and added get(). (WebCore::ObjCEventListener::handleEvent): Added get();
  • bridge/objc/objc_instance.mm: (ObjcInstance::setGlobalException): Use copy/release instead of HardRetain/HardRelease. (ObjcInstance::moveGlobalExceptionToExecState): Ditto.
  • platform/Cursor.h: Use RetainPtr for PlatformCursor on Mac.
  • platform/Cursor.cpp: (WebCore::Cursor::platformCursor): Moved this to CursorMac for the Mac.
  • platform/Widget.cpp: Removed retain/releasePlatformWidget and made them both inlines in the header file.
  • platform/Widget.h: Fixed includes and added an include of RetainPtr. Made platformWidget and setPlatformWidget non-inline on the Mac platform. Made releasePlatformWidget and retainPlatformWidget empty inline functions for non-GTK platforms.
  • platform/graphics/mac/ImageMac.mm: Removed unneeded FoundationExtras.h include.
  • platform/mac/ClipboardMac.mm: (WebCore::cocoaTypeFromHTMLClipboardType): use RetainPtr for the return type. (WebCore::ClipboardMac::clearData): Use RetainPtr. (WebCore::ClipboardMac::getData): Ditto. (WebCore::ClipboardMac::setData): Ditto.
  • platform/mac/CursorMac.mm: (WebCore::createCustomCursor): Use RetainPtr for the return type. (WebCore::Cursor::ensurePlatformCursor): Removed all the calls to HardRetain since m_platformCursor is now a RetainPtr. (WebCore::Cursor::Cursor): Ditto. (WebCore::Cursor::operator=): Ditto. Also HardRelease. (WebCore::Cursor::~Cursor): Ditto. (WebCore::Cursor::platformCursor): Use get here.
  • platform/mac/FoundationExtras.h: Removed all the functions except for HardAutorelease. Later we can remove that one too.
  • platform/mac/ThemeMac.mm: (WebCore::setUpButtonCell): Changed this function to have a return value. Otherwise we end up taking a pointer (actually a reference) to a global variable, which does not do the right thing for GC. (WebCore::nonDefaultButton): Added. (WebCore::defaultButton): Added. (WebCore::button): Changed to call two separate functions with two separate global variables to avoid the problem with pointers to globals.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::~Widget): Removed unneeded call to releasePlatformWidget. (WebCore::Widget::platformWidget): Non-inline so we can comipile the header plain non-Objective-C C++. (WebCore::Widget::setPlatformWidget): Ditto.
  • platform/network/mac/WebCoreURLResponse.mm: (mimeTypeFromUTITree): Use RetainPtr for the return type. (-[NSURLResponse adjustMIMETypeIfNecessary]): Use RetainPtr.
10:18 AM Changeset in webkit [68053] by Adam Roben
  • 3 edits in trunk/WebKitTools

Fix webkit-patch failure-reason now that build.webkit.org has been updated

Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
every time

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/net/buildbot.py:

(BuildBot._file_cell_text): Added. Travels down the firstChild chain
looking for an element that contains text, then returns it.
(BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
text out of the cells. This way it doesn't matter whether the cells
have <b> children (as for cells in directory rows) or not (as for
cells in file rows)
(BuildBot._parse_twisted_directory_listing): Look for rows that have
the "directory" or "file" class, rather than rows with any class,
since header rows now have a class attribute.

  • Scripts/webkitpy/common/net/buildbot_unittest.py:

(BuildBotTest._example_directory_listing): Updated to more closely
match the markup that build.webkit.org is producing now.

10:00 AM Changeset in webkit [68052] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Crash when running plug-in layout tests
https://bugs.webkit.org/show_bug.cgi?id=46269

Reviewed by Adam Roben.

Store the web page directly in the PluginView class, instead of getting it from the frame
of the plug-in element; this fixes two crashes, one where the plug-in element had been deallocated
before the plug-in view, and another where the plug-in element's document did not have a frame.

This also makes things more robust since we're asserting in the WebPage destructor that no plug-ins have
an outstanding reference to it.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::webPage):
(WebKit::PluginView::PluginView):
(WebKit::PluginView::~PluginView):
(WebKit::PluginView::initializePlugin):

  • WebProcess/Plugins/PluginView.h:
9:57 AM Changeset in webkit [68051] by jorlow@chromium.org
  • 7 edits in trunk/WebKit/chromium

2010-09-22 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Change WebKit API for IDBTransaciton to new style
https://bugs.webkit.org/show_bug.cgi?id=46263

  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::get):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::openCursor):
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openCursor): (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::get):
  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBObjectStoreImpl.h:
9:25 AM Changeset in webkit [68050] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-09-22 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] r68027 caused many crashes on the bots
https://bugs.webkit.org/show_bug.cgi?id=46268

Add the appropriate OwnPtrCairo.h include which has the OwnPtr
specialization for Cairo paths. Without it, we will have memory
corruption.

  • platform/graphics/cairo/PathCairo.cpp: Add OwnPtrCairo.h include.
9:06 AM Changeset in webkit [68049] by podivilov@chromium.org
  • 16 edits in trunk

2010-09-22 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement pausing on XHR
https://bugs.webkit.org/show_bug.cgi?id=46086

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setNativeBreakpoint): (WebCore::InspectorController::removeNativeBreakpoint): (WebCore::InspectorController::willInsertDOMNodeImpl): (WebCore::InspectorController::willRemoveDOMNodeImpl): (WebCore::InspectorController::willModifyDOMAttrImpl): (WebCore::InspectorController::instrumentWillSendXMLHttpRequestImpl):
  • inspector/InspectorController.h: (WebCore::InspectorController::instrumentWillSendXMLHttpRequest): (WebCore::InspectorController::inspectorControllerForScriptExecutionContext): (WebCore::InspectorController::inspectorControllerForNode): (WebCore::InspectorController::inspectorControllerForDocument):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::breakProgram):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorTimelineAgent.h:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.updateStatus):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.reset):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerPaused): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/Settings.js:
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::url):

2010-09-22 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement pausing on XHR
https://bugs.webkit.org/show_bug.cgi?id=46086

  • src/js/DevTools.js: ():
8:57 AM Changeset in webkit [68048] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Change a bunch of Vector<char> to Vector<uint8_t> to better indicate that we're
dealing with raw bytes.

Reviewed by Adam Roben.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):
(WebKit::NPN_GetURL):
(WebKit::NPN_PostURL):
(WebKit::NPN_GetURLNotify):
(WebKit::NPN_PostURLNotify):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::loadURL):
(WebKit::NetscapePlugin::initialize):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::deliverData):
(WebKit::NetscapePluginStream::deliverDataToPlugin):

  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):

  • WebProcess/Plugins/PluginView.h:
8:46 AM Changeset in webkit [68047] by brettw@chromium.org
  • 6 edits in trunk/WebKit/chromium

2010-09-21 Brett Wilson <brettw@chromium.org>

Reviewed by Darin Fisher.

Add caps log and num lock toggle state to WebInputEvent.
https://bugs.webkit.org/show_bug.cgi?id=46229

  • public/WebInputEvent.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):
  • src/WebViewImpl.h:
  • src/gtk/WebInputEventFactory.cpp: (WebKit::gdkStateToWebEventModifiers):
  • src/win/WebInputEventFactory.cpp: (WebKit::SetToggleKeyState): (WebKit::WebInputEventFactory::keyboardEvent): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):
8:37 AM Changeset in webkit [68046] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Assertion fails in [WKView _updateWindowFrame] when closing a WebKit2 window
https://bugs.webkit.org/show_bug.cgi?id=46264
<rdar://problem/8463534>

Reviewed by Adam Roben.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
Only update window visibility and frame when we're moving to a window.

8:31 AM Changeset in webkit [68045] by kbr@google.com
  • 1 edit in trunk/WebCore/ChangeLog

2010-09-22 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Add local triangulation of cubic curve control points
https://bugs.webkit.org/show_bug.cgi?id=45252

Adding a localized triangulation algorithm which takes as input
the four control points of a cubic curve segment and provides both
triangles as well as the ability to walk the interior edges. The
latter will be used later to fill the interior of shapes bounded
by these cubic curves, quadratic curves and line segments.

  • platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp: Added. (WebCore::LoopBlinnLocalTriangulator::Triangle::contains): (WebCore::LoopBlinnLocalTriangulator::Triangle::nextVertex): (WebCore::LoopBlinnLocalTriangulator::Triangle::indexForVertex): (WebCore::LoopBlinnLocalTriangulator::Triangle::makeCounterClockwise): (WebCore::LoopBlinnLocalTriangulator::LoopBlinnLocalTriangulator): (WebCore::LoopBlinnLocalTriangulator::reset): (WebCore::LoopBlinnLocalTriangulator::triangulate): (WebCore::LoopBlinnLocalTriangulator::triangulateHelper): (WebCore::LoopBlinnLocalTriangulator::addTriangle): (WebCore::LoopBlinnLocalTriangulator::addInteriorVertex): (WebCore::LoopBlinnLocalTriangulator::isSharedEdge):
  • platform/graphics/gpu/LoopBlinnLocalTriangulator.h: Added. (WebCore::LoopBlinnLocalTriangulator::Vertex::Vertex): (WebCore::LoopBlinnLocalTriangulator::Vertex::xyCoordinates): (WebCore::LoopBlinnLocalTriangulator::Vertex::klmCoordinates): (WebCore::LoopBlinnLocalTriangulator::Vertex::set): (WebCore::LoopBlinnLocalTriangulator::Vertex::end): (WebCore::LoopBlinnLocalTriangulator::Vertex::setEnd): (WebCore::LoopBlinnLocalTriangulator::Vertex::marked): (WebCore::LoopBlinnLocalTriangulator::Vertex::setMarked): (WebCore::LoopBlinnLocalTriangulator::Vertex::interior): (WebCore::LoopBlinnLocalTriangulator::Vertex::setInterior): (WebCore::LoopBlinnLocalTriangulator::Vertex::resetFlags): (WebCore::LoopBlinnLocalTriangulator::Triangle::Triangle): (WebCore::LoopBlinnLocalTriangulator::Triangle::getVertex): (WebCore::LoopBlinnLocalTriangulator::Triangle::setVertices): (WebCore::LoopBlinnLocalTriangulator::getVertex): (WebCore::LoopBlinnLocalTriangulator::numberOfTriangles): (WebCore::LoopBlinnLocalTriangulator::getTriangle): (WebCore::LoopBlinnLocalTriangulator::numberOfInteriorVertices): (WebCore::LoopBlinnLocalTriangulator::getInteriorVertex):
8:27 AM Changeset in webkit [68044] by demarchi@webkit.org
  • 5 edits in trunk

2010-09-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed, EFL build fix.

  • CMakeListsEfl.txt:
  • platform/efl/ClipboardEfl.cpp: (WebCore::ClipboardEfl::ClipboardEfl):

2010-09-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed, EFL build fix.

  • CMakeLists.txt:
8:18 AM Changeset in webkit [68043] by mrobinson@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-09-22 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Added information about drop shadow improvements to the NEWS file.

  • NEWS: Added information about drop shadow improvements.
8:03 AM Changeset in webkit [68042] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-22 İsmail Dönmez <ismail@namtrac.org>

Reviewed by Andreas Kling.

[Qt] Build fix for WinCE

Add two missing stubs:

  • privateBrowsingStateChanged(bool)
  • bindingInstance()
  • platform/qt/TemporaryLinkStubsQt.cpp: (PluginView::privateBrowsingStateChanged): (PluginView::bindingInstance):
8:01 AM Changeset in webkit [68041] by mrobinson@webkit.org
  • 3 edits in trunk/WebCore

2010-09-22 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] FontCustomPlatformData.cpp leaks FT_Faces
https://bugs.webkit.org/show_bug.cgi?id=16941

Attach lifetime of the FontCustomPlatformData FT_Face to the resulting cairo_font_face_t.
This will free the memory associated with the FT_Face once the cairo_font_face_t is
destroyed.

No new tests as functionality should not change.

  • platform/graphics/cairo/FontCustomPlatformData.cpp: (WebCore::releaseCustomFontData): Moved this helper method to the top of the file and gave it a more descriptive name. (WebCore::FontCustomPlatformData::FontCustomPlatformData): Changed the constructor to take the FT_Face and the buffer, so to better encapsulate the creation of the cairo face. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added a comment about the fate of the FT_Face to the destructor. (WebCore::createFontCustomPlatformData): Cleaned up the code here and moved some of the logic into the constructor.
  • platform/graphics/cairo/FontCustomPlatformData.h: Updated method definitions.
7:40 AM Changeset in webkit [68040] by xan@webkit.org
  • 13 edits in trunk/WebKit/gtk

2010-09-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix transfer annotations for WebKitGTK+ static API
https://bugs.webkit.org/show_bug.cgi?id=46244

Deal with all the warnings related to transfer issues. Mostly the
problem was the transfer being missing, but there were also typos
in the function name or missing ':' at the end of the function
name in the gtk-doc.

  • webkit/webkitdownload.cpp:
  • webkit/webkitnetworkrequest.cpp:
  • webkit/webkitnetworkresponse.cpp:
  • webkit/webkitsecurityorigin.cpp:
  • webkit/webkitwebdatabase.cpp:
  • webkit/webkitwebdatasource.cpp:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebhistoryitem.cpp:
  • webkit/webkitwebinspector.cpp:
  • webkit/webkitwebresource.cpp:
  • webkit/webkitwebsettings.cpp:
  • webkit/webkitwebview.cpp: (webkit_web_view_class_init): (webkit_web_view_get_main_frame):
7:25 AM Changeset in webkit [68039] by andreas.kling@nokia.com
  • 6 edits in trunk

2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] PluginStrategy implementation is broken
https://bugs.webkit.org/show_bug.cgi?id=46078

Remove the QWebPage* member from WebPlatformStrategies.
Get the originator QWebPage of the getPluginInfo call via
the Page* argument.

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::initialize): (WebPlatformStrategies::WebPlatformStrategies): (WebPlatformStrategies::getPluginInfo): Use the ChromeClient for accessing the originator QWebPage.
  • WebCoreSupport/WebPlatformStrategies.h:

2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] PluginStrategy implementation is broken
https://bugs.webkit.org/show_bug.cgi?id=46078

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): Initialize the WebPlatformStrategies at the UI side as well because we are using the LocalizationStrategy in the UI process. Added a FIXME since this should be fixed in the future.
7:17 AM Changeset in webkit [68038] by andreas.kling@nokia.com
  • 12 edits in trunk

2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

PluginStrategy should satisfy the needs of Qt
https://bugs.webkit.org/show_bug.cgi?id=45857
No new functionality so no new tests.

  • WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::getPluginInfo):
  • WebCoreSupport/WebPlatformStrategies.h:

2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

PluginStrategy should satisfy the needs of Qt
https://bugs.webkit.org/show_bug.cgi?id=45857
No new functionality so no new tests.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):

2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

PluginStrategy should satisfy the needs of Qt
https://bugs.webkit.org/show_bug.cgi?id=45857
No new functionality so no new tests.

  • plugins/PluginData.cpp: (WebCore::PluginData::initPlugins):
  • plugins/PluginStrategy.h: Added a |const Page*| argument to getPluginInfo.

2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

PluginStrategy should satisfy the needs of Qt
https://bugs.webkit.org/show_bug.cgi?id=45857
No new functionality so no new tests.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
6:53 AM Changeset in webkit [68037] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-22 İsmail Dönmez <ismail@namtrac.org>

Reviewed by Andreas Kling.

[Qt] Buildfix for WinCE

  • Api/DerivedSources.pro:
6:02 AM Changeset in webkit [68036] by pfeldman@chromium.org
  • 11 edits in trunk/WebCore

2010-09-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Elements panel does not reflect changes to the text node values.
https://bugs.webkit.org/show_bug.cgi?id=46166

  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::characterDataModifiedImpl):
  • inspector/InspectorController.h: (WebCore::InspectorController::characterDataModified):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::characterDataModified):
  • inspector/InspectorDOMAgent.h: (WebCore::EventListenerInfo::EventListenerInfo): (WebCore::InspectorDOMAgent::create): (WebCore::InspectorDOMAgent::cast): (WebCore::InspectorDOMAgent::cssStore):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._characterDataModified): (WebInspector.characterDataModified):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._characterDataModified):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
5:10 AM Changeset in webkit [68035] by diegohcg@webkit.org
  • 2 edits in trunk/WebCore

[Qt] On Maemo platform, web style is missing for some inputs
https://bugs.webkit.org/show_bug.cgi?id=46182

Patch by Ragner Magalhaes <ragner.magalhaes@openbossa.org> on 2010-09-21
Reviewed by Kenneth Rohde Christiansen.

  • css/themeQtMaemo5.css:
4:03 AM QtWebKitRelease20 edited by andreas.kling@nokia.com
(diff)
3:31 AM WebKit Team edited by andreas.kling@nokia.com
(diff)
3:26 AM Changeset in webkit [68034] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-09-22 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

REGRESSION: HTMLElement.localName returns lowercase, breaks Jira
https://bugs.webkit.org/show_bug.cgi?id=14114

Add tests from bug.

  • fast/parser/localname-case-expected.txt: Added.
  • fast/parser/localname-case-strict-expected.txt: Added.
  • fast/parser/localname-case-strict.html: Added.
  • fast/parser/localname-case.html: Added.
3:25 AM QtWebKitRelease20Deployment edited by andreas.kling@nokia.com
(diff)
3:19 AM Changeset in webkit [68033] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-22 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

[WINCE] Build fix for ResourceHandleWin after r67291.

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Replace Frame* parameter with NetworkingContext*.
2:34 AM Changeset in webkit [68032] by kbalazs@webkit.org
  • 2 edits in trunk/WebKitSite

2010-09-22 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed HTML syntax fix for my recent change in the coding-style.

  • coding/coding-style.html: Change "&gt" and "&lt" to "&gt;" and "&lt;".
1:58 AM Changeset in webkit [68031] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-09-22 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Crash due to bad cast in AXObjectCacheChromium.cpp.
https://bugs.webkit.org/show_bug.cgi?id=46237

  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
  • page/ChromeClient.h: (WebCore::ChromeClient::postAccessibilityNotification): (WebCore::ChromeClient::didChangeAccessibilityObjectState): (WebCore::ChromeClient::didChangeAccessibilityObjectChildren):
  • page/chromium/ChromeClientChromium.h:
1:55 AM Changeset in webkit [68030] by kbalazs@webkit.org
  • 2 edits in trunk/WebKitSite

2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Darin Adler.

check-webkit-style and the coding style guidelines page are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=46099

  • coding/coding-style.html: Making clear that includes of system headers must come after includes of other headers.
1:45 AM QtWebKitRelease20 edited by Henry Haverinen
(diff)
1:45 AM Changeset in webkit [68029] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-22 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

Add HRTFElevation files
https://bugs.webkit.org/show_bug.cgi?id=45864

No new tests since audio API is not yet implemented.

  • platform/audio/HRTFElevation.cpp: Added. (WebCore::HRTFElevation::calculateSymmetricKernelsForAzimuthElevation): (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation): (WebCore::HRTFElevation::createForSubject): (WebCore::HRTFElevation::createByInterpolatingSlices): (WebCore::HRTFElevation::getKernelsFromAzimuth):
  • platform/audio/HRTFElevation.h: Added. (WebCore::HRTFElevation::kernelListL): (WebCore::HRTFElevation::kernelListR): (WebCore::HRTFElevation::elevationAngle): (WebCore::HRTFElevation::numberOfAzimuths): (WebCore::HRTFElevation::sampleRate): (WebCore::HRTFElevation::HRTFElevation):
1:44 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:37 AM Changeset in webkit [68028] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-09-22 Paul Knight <pknight@apple.com>

Reviewed by Simon Fraser.

-[WebView _scheduleCompositingLayerSync] should wake the run loop
https://bugs.webkit.org/show_bug.cgi?id=46226

Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting.

  • WebView/WebView.mm: (-[WebView _scheduleCompositingLayerSync]):
1:23 AM Changeset in webkit [68027] by alex
  • 3 edits in trunk/WebCore

2010-09-22 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[gtk] Use the smart pointers to handle cairo_path_t
https://bugs.webkit.org/show_bug.cgi?id=46212

Modified the code to use smart pointers with cairo_path_t
variables.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::appendPathToCairoContext): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawTiledShadow):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::Path): (WebCore::Path::operator=): (WebCore::Path::apply): (WebCore::Path::debugString):
1:11 AM Changeset in webkit [68026] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-09-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Implement Image::loadPlatformResource
https://bugs.webkit.org/show_bug.cgi?id=45873

Load images from the resource directory.

  • platform/graphics/brew/ImageBrew.cpp: Added. (WebCore::Image::loadPlatformResource):
1:10 AM Changeset in webkit [68025] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-22 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

Add HRTFKernel files
https://bugs.webkit.org/show_bug.cgi?id=45863

No new tests since audio API is not yet implemented.

  • platform/audio/HRTFKernel.cpp: Added. (WebCore::extractAverageGroupDelay): (WebCore::HRTFKernel::HRTFKernel): (WebCore::HRTFKernel::createImpulseResponse): (WebCore::HRTFKernel::createInterpolatedKernel):
  • platform/audio/HRTFKernel.h: Added. (WebCore::HRTFKernel::create): (WebCore::HRTFKernel::fftFrame): (WebCore::HRTFKernel::fftSize): (WebCore::HRTFKernel::frameDelay): (WebCore::HRTFKernel::sampleRate): (WebCore::HRTFKernel::nyquist): (WebCore::HRTFKernel::HRTFKernel):
1:09 AM Changeset in webkit [68024] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

2010-09-22 Kent Tamura <tkent@chromium.org>

Reviewed by Chris Fleizach.

Support keyboard operations for <input type=range>.
https://bugs.webkit.org/show_bug.cgi?id=45803

  • fast/forms/range-keyoperation-expected.txt: Added.
  • fast/forms/range-keyoperation.html: Added.

2010-09-22 Kent Tamura <tkent@chromium.org>

Reviewed by Chris Fleizach.

Support keyboard operations for <input type=range>.
https://bugs.webkit.org/show_bug.cgi?id=45803

Increasing the value with Up/Right arrow keys by its step value,
and decreasing with Down/Left arrow keys. If an input element has
step=any attribute, increasing/decreasing by 1/100 of max-min.

Note: This change is not useful on Mac because users can't set
focus on range controls.

Test: fast/forms/range-keyoperation.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Calls handleKeyEventForRange() for RANGE and key events. (WebCore::HTMLInputElement::handleKeyEventForRange):
  • html/HTMLInputElement.h: Add handleKeyEventForRange() declaration.
12:49 AM Changeset in webkit [68023] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] Incorrect exposure of list items whose children are elements
https://bugs.webkit.org/show_bug.cgi?id=45383

Check that list items will be always exposed like that for GTK

  • platform/gtk/accessibility/list-items-always-exposed-expected.txt: Added.
  • platform/gtk/accessibility/list-items-always-exposed.html: Added.

2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] Incorrect exposure of list items whose children are elements
https://bugs.webkit.org/show_bug.cgi?id=45383

Set ATK_ROLE_LIST_ITEM looking for the role of the parent object

Test: platform/gtk/accessibility/list-items-always-exposed.html

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Always include objects with ListItemRole in accessibility for GTK.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getInterfaceMaskFromObject): Add some specific code to handle the special case of list markers by implementing AtkText when needed.
12:42 AM Changeset in webkit [68022] by krit@webkit.org
  • 22 edits
    27 moves in trunk/WebCore

2010-09-22 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Make FilterEffects independent of SVG
https://bugs.webkit.org/show_bug.cgi?id=46177

Moving all FilterEffects from svg/graphics/filters to platform/graphics/filters, now that they
are independent of SVG. Removed the SVG prefix of the files and updated the headers.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/DistantLightSource.h: Copied from WebCore/svg/graphics/filters/SVGDistantLightSource.h.
  • platform/graphics/filters/FEConvolveMatrix.cpp: Copied from WebCore/svg/graphics/filters/SVGFEConvolveMatrix.cpp.
  • platform/graphics/filters/FEConvolveMatrix.h: Copied from WebCore/svg/graphics/filters/SVGFEConvolveMatrix.h.
  • platform/graphics/filters/FEDiffuseLighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFEDiffuseLighting.cpp.
  • platform/graphics/filters/FEDiffuseLighting.h: Copied from WebCore/svg/graphics/filters/SVGFEDiffuseLighting.h.
  • platform/graphics/filters/FEDisplacementMap.cpp: Copied from WebCore/svg/graphics/filters/SVGFEDisplacementMap.cpp.
  • platform/graphics/filters/FEDisplacementMap.h: Copied from WebCore/svg/graphics/filters/SVGFEDisplacementMap.h.
  • platform/graphics/filters/FEFlood.cpp: Copied from WebCore/svg/graphics/filters/SVGFEFlood.cpp.
  • platform/graphics/filters/FEFlood.h: Copied from WebCore/svg/graphics/filters/SVGFEFlood.h.
  • platform/graphics/filters/FELighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFELighting.cpp.
  • platform/graphics/filters/FELighting.h: Copied from WebCore/svg/graphics/filters/SVGFELighting.h.
  • platform/graphics/filters/FEMerge.cpp: Copied from WebCore/svg/graphics/filters/SVGFEMerge.cpp.
  • platform/graphics/filters/FEMerge.h: Copied from WebCore/svg/graphics/filters/SVGFEMerge.h.
  • platform/graphics/filters/FEMorphology.cpp: Copied from WebCore/svg/graphics/filters/SVGFEMorphology.cpp.
  • platform/graphics/filters/FEMorphology.h: Copied from WebCore/svg/graphics/filters/SVGFEMorphology.h.
  • platform/graphics/filters/FEOffset.cpp: Copied from WebCore/svg/graphics/filters/SVGFEOffset.cpp.
  • platform/graphics/filters/FEOffset.h: Copied from WebCore/svg/graphics/filters/SVGFEOffset.h.
  • platform/graphics/filters/FESpecularLighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFESpecularLighting.cpp.
  • platform/graphics/filters/FESpecularLighting.h: Copied from WebCore/svg/graphics/filters/SVGFESpecularLighting.h.
  • platform/graphics/filters/FETile.cpp: Copied from WebCore/svg/graphics/filters/SVGFETile.cpp.
  • platform/graphics/filters/FETile.h: Copied from WebCore/svg/graphics/filters/SVGFETile.h.
  • platform/graphics/filters/FETurbulence.cpp: Copied from WebCore/svg/graphics/filters/SVGFETurbulence.cpp.
  • platform/graphics/filters/FETurbulence.h: Copied from WebCore/svg/graphics/filters/SVGFETurbulence.h.
  • platform/graphics/filters/LightSource.cpp: Copied from WebCore/svg/graphics/filters/SVGLightSource.cpp.
  • platform/graphics/filters/LightSource.h: Copied from WebCore/svg/graphics/filters/SVGLightSource.h.
  • platform/graphics/filters/PointLightSource.h: Copied from WebCore/svg/graphics/filters/SVGPointLightSource.h.
  • platform/graphics/filters/SpotLightSource.h: Copied from WebCore/svg/graphics/filters/SVGSpotLightSource.h.
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDistantLightElement.cpp:
  • svg/SVGFEFloodElement.h:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFEPointLightElement.cpp:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFESpotLightElement.cpp:
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.h:
  • svg/graphics/filters/SVGDistantLightSource.h: Removed.
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: Removed.
  • svg/graphics/filters/SVGFEConvolveMatrix.h: Removed.
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp: Removed.
  • svg/graphics/filters/SVGFEDiffuseLighting.h: Removed.
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: Removed.
  • svg/graphics/filters/SVGFEDisplacementMap.h: Removed.
  • svg/graphics/filters/SVGFEFlood.cpp: Removed.
  • svg/graphics/filters/SVGFEFlood.h: Removed.
  • svg/graphics/filters/SVGFELighting.cpp: Removed.
  • svg/graphics/filters/SVGFELighting.h: Removed.
  • svg/graphics/filters/SVGFEMerge.cpp: Removed.
  • svg/graphics/filters/SVGFEMerge.h: Removed.
  • svg/graphics/filters/SVGFEMorphology.cpp: Removed.
  • svg/graphics/filters/SVGFEMorphology.h: Removed.
  • svg/graphics/filters/SVGFEOffset.cpp: Removed.
  • svg/graphics/filters/SVGFEOffset.h: Removed.
  • svg/graphics/filters/SVGFESpecularLighting.cpp: Removed.
  • svg/graphics/filters/SVGFESpecularLighting.h: Removed.
  • svg/graphics/filters/SVGFETile.cpp: Removed.
  • svg/graphics/filters/SVGFETile.h: Removed.
  • svg/graphics/filters/SVGFETurbulence.cpp: Removed.
  • svg/graphics/filters/SVGFETurbulence.h: Removed.
  • svg/graphics/filters/SVGLightSource.cpp: Removed.
  • svg/graphics/filters/SVGLightSource.h: Removed.
  • svg/graphics/filters/SVGPointLightSource.h: Removed.
  • svg/graphics/filters/SVGSpotLightSource.h: Removed.
12:40 AM Changeset in webkit [68021] by msaboff@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-09-22 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

New test for (BOL) anchored regular expressions. Some of the
tests inspired by https://bugs.webkit.org/show_bug.cgi?id=46049.

  • fast/js/regexp-bol-expected.txt: Added.
  • fast/js/regexp-bol.html: Added.
  • fast/js/script-tests/regexp-bol.js: Added.
12:37 AM Changeset in webkit [68020] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Add internetHandle to WebCoreSynchronousLoader.
https://bugs.webkit.org/show_bug.cgi?id=46185

For loading content via network the WebCoreSynchronousLoader needs its own (synchronous) internetHandle.
This also adds asynchronousInternetHandle() to create a static asynchronous internetHandle.

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::createInternetHandle): (WebCore::asynchronousInternetHandle): (WebCore::WebCoreSynchronousLoader::internetHandle): (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Create synchronous internetHandle. (WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Delete synchronous internetHandle.
12:26 AM Changeset in webkit [68019] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Chris Fleizach.

[chromium] Remove unused sys/types.h in VDMXParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=46136

sys/types.h is not needed here.

  • platform/graphics/chromium/VDMXParser.cpp:
12:25 AM Changeset in webkit [68018] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Change the home directory path to the WebKit module directory
https://bugs.webkit.org/show_bug.cgi?id=45895

AEEFS_HOME_DIR denotes the currently running application's directory.
Change it to fs:/~<clsid> to use the WebKit module directory as home.

  • platform/brew/FileSystemBrew.cpp: (WebCore::homeDirectoryPath):
12:12 AM Changeset in webkit [68017] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-09-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Add dummy Pasteboard
https://bugs.webkit.org/show_bug.cgi?id=46107

Pasteboard is not supported yet. Add dummy implementation to avoid link errors.

  • platform/brew/PasteboardBrew.cpp: Added. (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):

Sep 21, 2010:

10:56 PM Changeset in webkit [68016] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-09-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Each EntityMaskIn* needs explanation
https://bugs.webkit.org/show_bug.cgi?id=44833

Added a description as to why we escape nbsp when serializing HTML documents but not when serializing XML documents.

  • editing/markup.cpp:
10:53 PM Changeset in webkit [68015] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-21 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Check if the acceleratedCompositingEnabled setting is active in WebViewImpl::graphicsContext3D()
https://bugs.webkit.org/show_bug.cgi?id=46239

This adds a check for whether acceleratedCompositingEnabled is true on the Page's Settings
object before creating and vending a GraphicsContext3D object. This is needed because when
an offscreen WebGraphicsContext3DCommandBufferImpl is initialized it first asks the WebViewImpl
for the compositor context. WebGraphicsContext3DCommandBufferImpl::initialize checks if the
disable accelerated compositing command line switch is set, but this is insufficient as sometimes
the Setting object does not agree exactly with the command line switches. For example,
we explicitly toggle accelerated compositing for some chrome UI URLs regardless of what the
flag says.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::graphicsContext3D):
10:36 PM Changeset in webkit [68014] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-09-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

cleanup: removeInlineStyleFromElement and extractInlineStyleToPushDown should be merged
https://bugs.webkit.org/show_bug.cgi?id=46205

Cleanup required to fix the bug 27818. Added the style extraction mechanism to removeInlineStyleFromElement
and removeCSSStyle and replaced the call to extractInlineStyleToPushDown by a call to removeInlineStyleFromElement.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added extractedStyle argument. (WebCore::ApplyStyleCommand::removeCSSStyle): Added extractedStyle argument. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls removeInlineStyleFromElement instead of extractInlineStyleToPushDown which has been deleted.
  • editing/ApplyStyleCommand.h:
10:22 PM Changeset in webkit [68013] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-21 Kent Tamura <tkent@chromium.org>

Unreviewed, text expectation update.

  • platform/chromium/drt_expectations.txt:
8:45 PM Changeset in webkit [68012] by tkent@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-09-21 Kent Tamura <tkent@chromium.org>

Reviewed by David Levin.

[Chromium] Remove WebInputElement::InputType and inputType()
https://bugs.webkit.org/show_bug.cgi?id=46238

  • DEPS: Roll Chromium revision to 60132, which removed all usage of inputType().
  • public/WebInputElement.h: Remove InputType and inputType().
  • src/AssertMatchingEnums.cpp: Remove WebInputElement::InputType - HTMLInputElement::InputType matching tests.
  • src/WebInputElement.cpp: Remove inputType().
8:35 PM Changeset in webkit [68011] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-21 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Remove passing tests, and fix typo.
8:31 PM Changeset in webkit [68010] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-21 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Update DRT results.
8:13 PM Changeset in webkit [68009] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-21 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests: fix bug introduced in r68008 where if you
specify --chromium and no --platform, and you're running on
windows, you use the 'chromium-win' port by default instead of the
version-specific port. This breaks the buildbots.

It will be good for this refactoring to settle down so I can
rewrite the logic for default ports and the unit tests to be
clearer (and the testing more comprehensive).

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
7:24 PM Changeset in webkit [68008] by dpranke@chromium.org
  • 21 edits in trunk/WebKitTools

2010-09-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Modify the Port interface to take only a series of keyword arguments
in the constructor, and modify Port/factory.get() to accomodate that,
and to accept user=XXX as an argument so we can pass
webkitpy.common.system.user.User objects in.

Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
to use the common routine in webkitpy.common.system.user.open_url()
to display HTML files.

There was a routine in the Port interface to do the same thing,
but I see no need for a port-specific hook for this, since it is
something that will always be executed by the host environment
and displaying web pages has nothing to do with running layout tests.

Note that new-run-webkit-tests used to use test_shell to display
the page; this is potentially useful so that you can actually click
from a result to the broken page; however, since DumpRenderTree
doesn't support this functionality, it will be going away eventually.

https://bugs.webkit.org/show_bug.cgi?id=46128

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
6:25 PM Changeset in webkit [68007] by jamesr@google.com
  • 4 edits
    2 copies in branches/chromium/517

Merge 68004 - 2010-09-21 Cosmin Truta <ctruta@chromium.org>

Reviewed by James Robinson.

RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing
https://bugs.webkit.org/show_bug.cgi?id=46120

Test a style change applied to a zoomed image.

  • css3/style-zoomed-image.html: Added.
  • css3/style-zoomed-image-expected.txt: Added.

2010-09-21 Cosmin Truta <ctruta@chromium.org>

Reviewed by James Robinson.

RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing
https://bugs.webkit.org/show_bug.cgi?id=46120

Avoid applying operator -> to m_imageResource when its underlying pointer is NULL.

  • rendering/RenderImage.h: (WebCore::RenderImage::intrinsicSizeChanged): Checked m_imageResource.
  • html/HTMLImageElement.cpp: (HTMLImageElement::createRenderer): Fixed indentation.

TBR=jamesr@google.com
BUG=54972
Review URL: http://codereview.chromium.org/3431018

6:22 PM Changeset in webkit [68006] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-09-21 Oliver Hunt <oliver@apple.com>

RS=Gavin Barraclough.

Fix codeblock dumping

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • runtime/Executable.h: (JSC::ScriptExecutable::ScriptExecutable):
6:10 PM Changeset in webkit [68005] by atwilson@chromium.org
  • 35 edits
    1 delete in trunk

Revert "2010-09-21 Chris Guillory <chris.guillory@google.com>"

This reverts commit 347aab9430be62b827cd1130adbfdf99d18bfaf0.

6:08 PM Changeset in webkit [68004] by jamesr@google.com
  • 4 edits
    2 adds in trunk

2010-09-21 Cosmin Truta <ctruta@chromium.org>

Reviewed by James Robinson.

RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing
https://bugs.webkit.org/show_bug.cgi?id=46120

Test a style change applied to a zoomed image.

  • css3/style-zoomed-image.html: Added.
  • css3/style-zoomed-image-expected.txt: Added.

2010-09-21 Cosmin Truta <ctruta@chromium.org>

Reviewed by James Robinson.

RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing
https://bugs.webkit.org/show_bug.cgi?id=46120

Avoid applying operator -> to m_imageResource when its underlying pointer is NULL.

  • rendering/RenderImage.h: (WebCore::RenderImage::intrinsicSizeChanged): Checked m_imageResource.
  • html/HTMLImageElement.cpp: (HTMLImageElement::createRenderer): Fixed indentation.
6:07 PM Changeset in webkit [68003] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated test after r67994.

Reviewed by Geoffrey Garen.

  • fast/dom/Range/range-expand.html: Do not expect sentence selections to include

trailing newline characters.

5:38 PM Changeset in webkit [68002] by demarchi@webkit.org
  • 5 edits in trunk

2010-09-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Get fresh theme when running EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=46210

If user tried to run EWebLauncher outside of the build tree, it would
not find the theme and fallback to the installed one. However, since
EWebLauncher is not installed, we always want to take the theme from
the just compiled source code. If user had never installed WebKit's
EFL port it could even receive a segv since no theme would be found.

Now EWebLauncher does not fallback to the installed theme and CMake
gives as DATA_DIR the directory of the theme it has just built.

  • CMakeListsEfl.txt: export DATA_DIR to parent CMakeLists.txt in order to be used by EWebLauncher.

2010-09-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Get fresh theme when running EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=46210

If user tried to run EWebLauncher outside of the build tree, it would
not find the theme and fallback to the installed one. However, since
EWebLauncher is not installed, we always want to take the theme from
the just compiled source code. If user had never installed WebKit's
EFL port it could even receive a segv since no theme would be found.

Now EWebLauncher does not fallback to the installed theme and CMake
gives as DATA_DIR the directory of the theme it has just built.

  • CMakeListsEfl.txt: Pass the build directory as DATA_DIR to EWebLauncher.
  • EWebLauncher/main.c: Use only the theme from build director. Do not fallback to others as this could hide real bugs. (quit): (browserCreate): (findThemePath): (main):
5:35 PM Changeset in webkit [68001] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

2010-09-21 John Gregg <johnnyg@google.com>

Unreviewed, chromium test expecations.

[chromium] update test expectations
https://bugs.webkit.org/show_bug.cgi?id=46235

  • platform/chromium/test_expectations.txt:
5:34 PM Changeset in webkit [68000] by kbr@google.com
  • 13 edits
    5 deletes in trunk

2010-09-21 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Remove GLES2Context and WebGLES2Context
https://bugs.webkit.org/show_bug.cgi?id=46131

Removed now-obsolete GLES2Context and WebGLES2Context classes, and
dependency on command buffer client code from WebCore. Built and
tested 3D CSS and WebGL content on Mac OS X to test.

  • WebKit.gyp:
  • public/WebGLES2Context.h: Removed.
  • public/WebGraphicsContext3D.h:
  • public/WebKitClient.h:
  • public/WebView.h:
  • src/ChromeClientImpl.cpp:
  • src/GLES2Context.cpp: Removed.
  • src/GLES2ContextInternal.cpp: Removed.
  • src/GLES2ContextInternal.h: Removed.
  • src/WebGraphicsContext3DDefaultImpl.cpp:
  • src/WebGraphicsContext3DDefaultImpl.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

2010-09-21 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Remove GLES2Context and WebGLES2Context
https://bugs.webkit.org/show_bug.cgi?id=46131

Removed now-obsolete GLES2Context and WebGLES2Context classes, and
dependency on command buffer client code from WebCore. Built and
tested 3D CSS and WebGL content on Mac OS X to test.

  • WebCore.gypi:
  • platform/chromium/GLES2Context.h: Removed.
  • platform/graphics/skia/ImageSkia.cpp:
5:33 PM Changeset in webkit [67999] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-21 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Don't pass the --test-shell arg to the Chromium Mac port of DRT;
it just confuses it.

https://bugs.webkit.org/show_bug.cgi?id=46230

  • Scripts/webkitpy/layout_tests/port/webkit.py:
5:31 PM Changeset in webkit [67998] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Try to fix the Windows build.

  • loader/Cache.cpp:

(WebCore::Cache::makeResourcePurgeable):
(WebCore::Cache::evict): Cast to int before using unary '-', to avoid an
MSVC warning.

5:27 PM Changeset in webkit [67997] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Add DirectX SDK include path.

Rubber stamped by Simon Fraser.

  • win/WebKit2DirectX.vsprops:
5:18 PM Changeset in webkit [67996] by ggaren@apple.com
  • 6 edits in trunk/WebCore

Use purgeable memory to keep more dead resources in cache
https://bugs.webkit.org/show_bug.cgi?id=44806
<rdar://problem/8350901>

Patch by Pratik Solanki <psolanki@apple.com> on 2010-09-21
Reviewed by Geoffrey Garen and Darin Adler.

This changes the behavior of dead resources in the WebCore cache to be the following if
shouldMakeResourcePurgeableOnEviction() returns true.

  1. Dead resources in the cache are kept in non-purgeable memory.
  2. When we prune dead resources, instead of freeing them, we mark their memory as purgeable

and keep the resources until the kernel reclaims the purgeable memory.

By leaving the in-cache dead resources in dirty resident memory, we decrease the likelihood
of the kernel claiming that memory and forcing us to refetch the resource (for example when
a user presses back).

And by having an unbounded number of resource objects using purgeable memory, we can use
as much memory as is available on the machine. The trade-off is that the CachedResource
object (and its member variables) are allocated in non-purgeable TC-malloc'd memory so
we would see slightly more memory use due to this.

  • loader/Cache.cpp:

(WebCore::Cache::resourceForURL): Adjust sizes appropriately if we made resource memory
non-purgeable.
(WebCore::Cache::pruneDeadResources): When removing dead resources, try first to mark their
memory as purgeable. If not, evict the resource.
(WebCore::Cache::makeResourcePurgeable): Added. Try to mark resource
memory as purgeable. If successful, adjust the sizes so that we don't
factor this resources size in the Cache size calculation.
(WebCore::Cache::evict): Don't decrement size if we already did it in makeResourcePurgeable.
(WebCore::Cache::dumpLRULists): Extra debug logging.

  • loader/Cache.h:

(WebCore::Cache::shouldMakeResourcePurgeableOnEviction): Added. Indicates if the new
behaviour is enabled.

  • loader/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::allClientsRemoved): Do not mark memory as purgeable. The
Cache class takes care of this.

  • loader/CachedImage.cpp:

(WebCore::CachedImage::destroyDecodedData): Ditto.

  • loader/CachedScript.cpp:

(WebCore::CachedScript::destroyDecodedData): Ditto.

5:17 PM Changeset in webkit [67995] by Stephanie Lewis
  • 2 edits in trunk/WebKitTools

Make a new buildbot for Leopard Debug Test

Reviewed by Stephanie Lewis.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
5:13 PM Changeset in webkit [67994] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7729077> Extending the selection to sentence boundary after a line break may select extra character
https://bugs.webkit.org/show_bug.cgi?id=46232

Reviewed by Darin Adler.

WebCore:

Test: editing/selection/extend-by-sentence-002.html

  • editing/visible_units.cpp:

(WebCore::nextBoundary): The text iterator’s range end can be the position after
the line break, in which case the next visible is actually after the first character
of the next sentence. Instead, advance the text iterator past the newline character
and return the beginning of its range, which is guaranteed to still be before the
next sentence.

LayoutTests:

  • editing/selection/extend-by-sentence-002-expected.txt: Added.
  • editing/selection/extend-by-sentence-002.html: Added.
5:06 PM Changeset in webkit [67993] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-21 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix breakage of Chromium Mac DRT port caused by r67905.

https://bugs.webkit.org/show_bug.cgi?id=46230

  • Scripts/webkitpy/layout_tests/port/webkit.py:
4:59 PM Changeset in webkit [67992] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-21 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Roll forward Chromium DEPS to pick up removal of WebGLES2Context dependencies
https://bugs.webkit.org/show_bug.cgi?id=46231

Ran build-webkit --chromium --debug on Mac OS X to test the roll-forward.

  • DEPS:
4:39 PM Changeset in webkit [67991] by andersca@apple.com
  • 8 edits in trunk/WebKit2

Forward window focus changes to the plug-in
https://bugs.webkit.org/show_bug.cgi?id=46227

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::windowFocusChanged):
Send the NPCocoaEventWindowFocusChanged event.

(WebKit::NetscapePlugin::windowFrameChanged):
(WebKit::NetscapePlugin::windowVisibilityChanged):
Add stubs.

  • WebProcess/Plugins/Plugin.h:

Add windowFocusChanged, windowFrameChanged and windowVisibilityChanged.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::webPage):
Make webPage a member function instead.

(WebKit::PluginView::setWindowIsFocused):
Call the plug-in member function.

(WebKit::PluginView::initializePlugin):
When the plug-in has been initialized, update its window frame, window visibility
and window focus states.

(WebKit::PluginView::setParent):
Move viewGeometryDidChange to initializePlugin.

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setActive):
Tell all plug-in views about the new window focus state.

(WebKit::WebPage::windowIsFocused):
Return whether the window is focused or not.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::windowIsVisible):
(WebKit::WebPage::windowFrame):
Add getters.

4:19 PM Changeset in webkit [67990] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-09-21 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Speed up function.apply(..., arguments)
https://bugs.webkit.org/show_bug.cgi?id=46207

Add code to do argument copying inline in the case
where we're using Function.apply to forward our arguments
directly.

  • jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):

Splitted op_load_varargs into fast and slow paths, so add the call
to the slow path generator.

  • jit/JIT.h:
  • jit/JITCall32_64.cpp: Remove 32bit specific emit_op_load_varargs as the logic is the same for all value representations
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_load_varargs): Copy arguments inline (JSC::JIT::emitSlow_op_load_varargs):
3:27 PM Changeset in webkit [67989] by robert@webkit.org
  • 2 edits in trunk/WebCore

2010-09-21 Robert Hogan <robert@webkit.org>

Rubber-stamped by Ariya Hidayat.

[Qt] Build fix against qt trunk

  • platform/graphics/qt/ContextShadow.cpp: (WebCore::ContextShadow::beginShadowLayer):
2:25 PM Changeset in webkit [67988] by crogers@google.com
  • 28 edits in branches/audio/WebCore

audio branch: changes in preparation for landing in trunk

  • added more rigorous thread safety and ASSERTS in AudioNode and AudioContext
  • added HRTFDatabaseLoader to load HRTF datasets asynchronously in another thread
  • cleaned up HRTF audio resource loading abstraction in HRTFElevation
  • general cleanup in the HRTF classes
  • added addInput() and addOutput() protected methods to AudioNode and added calls in AudioNode constructors
2:25 PM Changeset in webkit [67987] by crogers@google.com
  • 2 adds in branches/audio/WebCore/platform/audio

audio branch: add HRTFDatabaseLoader files

2:04 PM Changeset in webkit [67986] by jorlow@chromium.org
  • 9 edits in trunk/WebKit/chromium

2010-09-21 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Plumb the IDBTransansaction's id
https://bugs.webkit.org/show_bug.cgi?id=46197

Next step, add the plumbing to Chromium. Then we add code to WebKit
that uses it (and take out the default IDBTransaction param).

  • public/WebIDBCursor.h: (WebKit::WebIDBCursor::key): (WebKit::WebIDBCursor::value):
  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::get):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::removeIndex): (WebKit::WebIDBObjectStore::openCursor):
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openCursor): (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::get):
  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBObjectStoreImpl.h:
2:00 PM Changeset in webkit [67985] by tony@chromium.org
  • 2 edits in trunk/WebCore

2010-09-21 Tony Chang <tony@chromium.org>

Unreviewed, QT build fix.

  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::ClipboardQt):
1:51 PM Changeset in webkit [67984] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Handle booleans in injected bundle messages
https://bugs.webkit.org/show_bug.cgi?id=46213

Reviewed by John Sullivan.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

1:43 PM Changeset in webkit [67983] by aestes@apple.com
  • 7 edits in trunk

2010-09-21 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
https://bugs.webkit.org/show_bug.cgi?id=46134

AIM clients linked against versions of WebKit prior to the introduction
of the HTML5 parser contain markup incompatible with the new parser.
Enable parser quirks in this case to remain compatible with these
clients.

  • WebView/WebView.mm: (shouldUsePreHTML5ParserQuirks): Returns true if the embedding application is AIM and was linked against a version of WebKit prior to the introduction of the HTML5 parser, or if the WebKitPreHTML5ParserQuirks WebPreference is enabled. (-[WebView _preferencesChangedNotification:]): Call WebCore::Settings::setUsePreHTML5ParserQuirks().

2010-09-21 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
https://bugs.webkit.org/show_bug.cgi?id=46134

  • WebCore.exp.in: Export ZN7WebCore32applicationIsAOLInstantMessengerEv.
  • platform/mac/RuntimeApplicationChecks.h:
  • platform/mac/RuntimeApplicationChecks.mm: (WebCore::applicationIsAOLInstantMessenger): Determine if the embedding application is AOL Instant Messenger by checking the bundle identifier.
1:22 PM Changeset in webkit [67982] by commit-queue@webkit.org
  • 35 edits
    1 copy in trunk

2010-09-21 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send webkit accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156

  • platform/chromium/accessibility/post-notification-ActiveDescendantChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-CheckedStateChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-ChildrenChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-FocusedUIElementChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html:
  • platform/chromium/accessibility/post-notification-LayoutComplete-expected.txt:
  • platform/chromium/accessibility/post-notification-LayoutComplete.html:
  • platform/chromium/accessibility/post-notification-LiveRegionChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-LoadComplete-expected.txt:
  • platform/chromium/accessibility/post-notification-LoadComplete.html:
  • platform/chromium/accessibility/post-notification-MenuListValueChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-RowCollapsed-expected.txt:
  • platform/chromium/accessibility/post-notification-RowCountChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-RowExpanded-expected.txt:
  • platform/chromium/accessibility/post-notification-ScrolledToAnchor-expected.txt:
  • platform/chromium/accessibility/post-notification-ScrolledToAnchor.html:
  • platform/chromium/accessibility/post-notification-SelectedChildrenChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-SelectedTextChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-SelectedTextChanged.html:
  • platform/chromium/accessibility/post-notification-ValueChanged-expected.txt:
  • platform/chromium/accessibility/post-notification.js: (test):

2010-09-21 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send webkit accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156

  • WebCore.gypi:
  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::handleScrolledToAnchor):
  • dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::setFocusedNode):
  • editing/SelectionController.h:
  • editing/chromium/SelectionControllerChromium.cpp: Added. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • page/chromium/ChromeClientChromium.h:

2010-09-21 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send webkit accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156

  • public/WebAccessibilityCache.h:
  • public/WebViewClient.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focusedNodeChanged): (WebKit::ChromeClientImpl::getPopupMenuInfo):
  • src/ChromeClientImpl.h:
  • src/WebAccessibilityCache.cpp: (WebKit::WebAccessibilityCache::accessibilityEnabled):
1:21 PM Changeset in webkit [67981] by alex
  • 5 edits
    2 copies
    2 moves in trunk/WebCore

2010-09-21 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[gtk] Move copyContextProperties outside the GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=46179.

Moved the copyContextProperties function to the CairoUtilities so
we can use it outside GraphicsContextCairo. We moved also the old
gtk CairoUtilities file to GdkCairoUtilities and added the new
file in the cairo directory.

  • GNUmakefile.am:
  • platform/graphics/cairo/CairoUtilities.cpp: Added. (WebCore::copyContextProperties):
  • platform/graphics/cairo/CairoUtilities.h: Added.
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/gtk/CairoUtilities.cpp: Removed.
  • platform/graphics/gtk/CairoUtilities.h: Removed.
  • platform/graphics/gtk/GdkCairoUtilities.cpp: Added. (getCairoSurfacePixel): (getGdkPixbufPixel): (cairoImageSurfaceToGdkPixbuf):
  • platform/graphics/gtk/GdkCairoUtilities.h: Added.
  • platform/graphics/gtk/ImageBufferGtk.cpp:
  • platform/graphics/gtk/ImageGtk.cpp:
1:20 PM Changeset in webkit [67980] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [67979] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

WebKit2 should look for WebKit2WebProcess.exe next to WebKit.dll
https://bugs.webkit.org/show_bug.cgi?id=46209
<rdar://problem/8445639>

Reviewed by Adam Roben.

Find WebKit2WebProcess.exe by getting the full path to WebKit.dll, and then
removing the last path component and replacing it with WebKit2WebProcess.exe.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:

(WebKit::ProcessLauncher::launchProcess):

1:06 PM Changeset in webkit [67978] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-21 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Add missing import of 'tempfile'.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
12:48 PM Changeset in webkit [67977] by vangelis@chromium.org
  • 2 edits in trunk/WebCore

2010-09-21 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Cleaned up LayerRendererChromium::prepareToDrawLayers
logic to avoid unnecessary copy operations if the existing root layer
contents aren't useful for scrolling. Also removed call to updateLayersRecursive()
as the composited layer update is actually happening in the drawLayers() method.
https://bugs.webkit.org/show_bug.cgi?id=46199

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::prepareToDrawLayers):
12:47 PM Changeset in webkit [67976] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-09-21 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

stray param elements are dropped during parsing
https://bugs.webkit.org/show_bug.cgi?id=14551

This bug was fixed by the HTML5 parser. Add tests from bug.

  • fast/parser/stray-param-expected.txt: Added.
  • fast/parser/stray-param.html: Added.
12:37 PM Changeset in webkit [67975] by abarth@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

2010-09-21 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

[html-parsing] make entity handling match IE7 / HTML5
https://bugs.webkit.org/show_bug.cgi?id=14391

This patch adds more test coverage of entity parsing. We seem to have
a bug with AElig, but I'll fix that in a future patch.

  • fast/tokenizer/entities-01.html: Added.
  • fast/tokenizer/entities-02.html: Added.
  • fast/tokenizer/entities-03.html: Added.
  • fast/tokenizer/entities-04.html: Added.
12:11 PM Changeset in webkit [67974] by dpranke@chromium.org
  • 21 edits
    1 move
    1 add
    51 deletes in trunk/WebKitTools

2010-09-17 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: pull the list of tests from the Port, and

make it possible to run with no actual test files in the filesystem.

This set of changes allows us to delete the special
webkitpy/layout_tests/data directory and test the generic code without
touching the filesystem (except to write results). This speeds up
test-webkitpy substantially.

This also cleans up and removes several code paths in the generic
code and fixes some minor bugs, notably in the test_expectations
parsing, which was previously fragile if the tests weren't present.

We also change the way we diff image results to be able to do so
in memory, without relying on files. This slows down chromium
test_shell, which always writes images to files, but should speed
up DRT and ImageDiff-based implementations slightly.

Note that pulling the list of tests to run from the Port will allow
ports to specify what tests to run as an inclusive list; previously
you could only do this as an exclusive list by using a
test_expectations file or Skipped files; nothing actually uses this
feature yet and it's unclear if it should be used.

Note that there are no functional changes -- apart from now
always printing out the location of the checksum file when we are
tracing test runs -- and the total number of lines of non-test code
actually drops by two.

There is some more cleanup that can be done in the Port/Driver
interface and in some handling of filenames, but I'll save that
for another change.

https://bugs.webkit.org/show_bug.cgi?id=45801

  • Scripts/webkitpy/layout_tests/data/*: Removed.
    • no longer need special mock layout_tests_directory in the repository.
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
    • add code to display missing text files, checksums when tracing
    • update to not look at the filesystem directly.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
    • add more unit tests
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
    • remove tests_are_present flag
    • update with changes in Port interface - no longer access the filesystem directly, although we still use os.path for filename manipulation.
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
    • add more unit tests
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
    • renamed to port/test_files.py
  • Scripts/webkitpy/layout_tests/port/base.py:
    • change diff_image() to expect actual image data, not filenames
    • add expected_checksum(), expected_image(), expected_text() to return the content of the files so that we don't need a filesystem
    • add path_exists(), path_isdir() for filesystem-like access.
    • add test_dirs() to keep clobber-test-results from needing to actually look at a real layout tests dir
    • add tests() to return the list of tests to run on the port (calls port/test_files to do the work).
    • add update_baseline() to be able to save new baselines
    • add uri_to_test_name() from port/dryrun.py so we can easily check filename_to_uri()
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
    • add more unit tests
  • Scripts/webkitpy/layout_tests/port/chromium.py:
    • change diff_image() to accept image content, not filenames. This will be slower for test_shell/image_diff, but faster for DRT/ImageDiff.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
    • add more unit tests
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
    • simplify greatly
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
    • add more unit tests
  • Scripts/webkitpy/layout_tests/port/test.py:
    • massive rewrite to use in-script list of tests and expectations
  • Scripts/webkitpy/layout_tests/port/test_files.py:
    • rename from layout_package/test_files.
  • Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
    • add unit tests
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • update diff_image() to take image contents, not files. Should make things slightly faster.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
    • update with changes to diff_image()
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
    • update with changes to diff_image()
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • remove tests_are_present from test_expectations
    • pull the list of tests from port.tests() instead of calling test_files.py directly.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
    • update unit tests
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
    • update with changes to
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
    • update with change in Port interface
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
    • update with change in Port interface
  • Scripts/webkitpy/style/checkers/test_expectations.py:
    • remove the tests_are_present flag
11:50 AM Changeset in webkit [67973] by commit-queue@webkit.org
  • 40 edits in trunk/WebCore

2010-09-21 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Change Clipboard to use an enum instead of isForDragging = true/false
https://bugs.webkit.org/show_bug.cgi?id=46004

No new tests, since it's just a refactoring change.

  • bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::setDragImage):
  • bindings/v8/custom/V8ClipboardCustom.cpp: (WebCore::V8Clipboard::setDragImageCallback):
  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::setDropEffect): (WebCore::Clipboard::setEffectAllowed):
  • dom/Clipboard.h: (WebCore::Clipboard::isForCopyAndPaste): (WebCore::Clipboard::isForDragAndDrop):
  • editing/android/EditorAndroid.cpp: (WebCore::Editor::newGeneralClipboard):
  • editing/brew/EditorBrew.cpp: (WebCore::Editor::newGeneralClipboard):
  • editing/chromium/EditorChromium.cpp: (WebCore::Editor::newGeneralClipboard):
  • editing/haiku/EditorHaiku.cpp: (WebCore::Editor::newGeneralClipboard):
  • editing/mac/EditorMac.mm: (WebCore::Editor::newGeneralClipboard):
  • editing/wx/EditorWx.cpp: (WebCore::Editor::newGeneralClipboard):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/efl/EventHandlerEfl.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::createDraggingClipboard):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/android/ClipboardAndroid.cpp: (WebCore::ClipboardAndroid::ClipboardAndroid): (WebCore::ClipboardAndroid::clearData): (WebCore::ClipboardAndroid::clearAllData): (WebCore::ClipboardAndroid::setData):
  • platform/android/ClipboardAndroid.h:
  • platform/brew/ClipboardBrew.cpp: (WebCore::ClipboardBrew::ClipboardBrew): (WebCore::ClipboardBrew::clearData): (WebCore::ClipboardBrew::clearAllData): (WebCore::ClipboardBrew::setData):
  • platform/brew/ClipboardBrew.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::Clipboard::create): (WebCore::ClipboardChromium::ClipboardChromium): (WebCore::ClipboardChromium::create): (WebCore::ClipboardChromium::getData):
  • platform/chromium/ClipboardChromium.h:
  • platform/efl/ClipboardEfl.cpp: (WebCore::Editor::newGeneralClipboard): (WebCore::ClipboardEfl::ClipboardEfl):
  • platform/efl/ClipboardEfl.h: (WebCore::ClipboardEfl::create):
  • platform/gtk/ClipboardGtk.cpp: (WebCore::Editor::newGeneralClipboard): (WebCore::Clipboard::create): (WebCore::ClipboardGtk::ClipboardGtk): (WebCore::dataObjectTypeFromHTMLClipboardType): (WebCore::ClipboardGtk::clearData): (WebCore::ClipboardGtk::getData): (WebCore::ClipboardGtk::setData):
  • platform/gtk/ClipboardGtk.h: (WebCore::ClipboardGtk::create):
  • platform/haiku/ClipboardHaiku.cpp: (WebCore::Clipboard::create): (WebCore::ClipboardHaiku::ClipboardHaiku):
  • platform/haiku/ClipboardHaiku.h: (WebCore::ClipboardHaiku::create):
  • platform/mac/ClipboardMac.h: (WebCore::ClipboardMac::create):
  • platform/mac/ClipboardMac.mm: (WebCore::Clipboard::create): (WebCore::ClipboardMac::ClipboardMac):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::~ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::writePlainText):
  • platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::create):
  • platform/win/ClipboardWin.cpp: (WebCore::Clipboard::create): (WebCore::ClipboardWin::ClipboardWin): (WebCore::ClipboardWin::clearData): (WebCore::ClipboardWin::clearAllData): (WebCore::ClipboardWin::setData): (WebCore::ClipboardWin::setExternalDataObject):
  • platform/win/ClipboardWin.h: (WebCore::ClipboardWin::create):
  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard):
  • platform/wx/ClipboardWx.cpp: (WebCore::ClipboardWx::ClipboardWx):
  • platform/wx/ClipboardWx.h: (WebCore::ClipboardWx::create):
11:43 AM Changeset in webkit [67972] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-09-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8363003> REGRESSION: ~1.4% sunspider regression in
interpreter due to 54724 and 54596


Fixed a typo (using "UNLIKELY" instead of "LIKELY").


  • wtf/PassRefPtr.h: (WTF::refIfNotNull): (WTF::derefIfNotNull): It is likely that m_ptr != 0 because most RefPtrs hold real data. Also, in cases where they do not hold real data, the compiler usually sees a call to release() right before the call to the destructor, so it can probably optimize out the test completely.
11:42 AM Changeset in webkit [67971] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Send window visibility and window frame change sizes to the plug-in
https://bugs.webkit.org/show_bug.cgi?id=46202

Reviewed by Adam Roben.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowVisibility]):
Call WebPageProxy::setWindowIsVisible.

(-[WKView addWindowObserversForWindow:]):
Add additional observers.

(-[WKView removeWindowObservers]):
Remove observers.

(-[WKView _updateWindowFrame]):
Call WebPageProxy::setWindowFrame.

(-[WKView viewDidMoveToWindow]):
Update the window visibility and the web frame.

(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
Update the window visibility.

(-[WKView _windowFrameDidChange:]):
Update the window frame.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setWindowIsVisible):
(WebKit::WebPageProxy::setWindowFrame):
Send messages along to the web process.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Register the plug-in view.

(WebKit::PluginView::~PluginView):
Unregister the plug-in view.

(WebKit::PluginView::setWindowIsVisible):
(WebKit::PluginView::setWindowFrame):
Add empty stubs.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Initialize m_windowIsVisible.

(WebKit::WebPage::~WebPage):
Assert that all plug-in views have been removed.

(WebKit::WebPage::setWindowIsVisible):
Notify all plug-ins about the window visibility change.

(WebKit::WebPage::setWindowFrame):
Notify all plug-ins about the window frame change.

(WebKit::WebPage::didReceiveMessage):
Handle setWindowIsVisible and setWindowFrame.

11:39 AM Changeset in webkit [67970] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Disable logging.

  • MiniBrowser/mac/MiniBrowser_Prefix.pch:
11:32 AM Changeset in webkit [67969] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-21 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Closing <li> should close nested <div>
https://bugs.webkit.org/show_bug.cgi?id=26170

This bug is fixed by the HTML5 parser. Adding test. (We have lots of
variations of this test, but I'm adding another one to make Alexey
happy.)

  • html5lib/resources/webkit01.dat:
11:21 AM Changeset in webkit [67968] by andersca@apple.com
  • 3 edits in trunk/WebKit2
  • Configurations/WebKit2.xcconfig:

Add a note about keeping the path in MainMac.cpp in sync with the install path.

Reviewed by Mark Rowe.

  • mac/MainMac.cpp:

(main):
Use the correct framework path.

11:16 AM Changeset in webkit [67967] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-21 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Take isValueList() checks out of the asserts for memory safety.
https://bugs.webkit.org/show_bug.cgi?id=46194

Test: editing/execCommand/apply-style-text-decoration-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::extractTextStyles): (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):

2010-09-21 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that applying a text decoration style does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=46194

  • editing/execCommand/apply-style-text-decoration-crash-expected.txt: Added.
  • editing/execCommand/apply-style-text-decoration-crash.html: Added.
10:51 AM Changeset in webkit [67966] by vangelis@chromium.org
  • 2 edits in trunk/WebCore

2010-09-21 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fixing double translation of composited layers when scrolling.
The scrolling transform is now applied by a separate layer maintained in
the RenderLayerCompositor.
https://bugs.webkit.org/show_bug.cgi?id=46193

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
10:50 AM Changeset in webkit [67965] by tony@chromium.org
  • 1 edit
    1 add in trunk/WebKitTools

2010-09-21 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

add a script for running webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=46014

  • Scripts/run-chromium-webkit-unit-tests: Added.
10:49 AM Changeset in webkit [67964] by hyatt@apple.com
  • 6 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46196, add marginStart/Before/End/After accessors to RenderBoxModelObject.

Reviewed by Dan Bernstein.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderInline.cpp:

(WebCore::computeMargin):
(WebCore::RenderInline::marginLeft):
(WebCore::RenderInline::marginRight):
(WebCore::RenderInline::marginTop):
(WebCore::RenderInline::marginBottom):
(WebCore::RenderInline::marginStart):
(WebCore::RenderInline::marginEnd):

  • rendering/RenderInline.h:

(WebCore::RenderInline::marginBefore):
(WebCore::RenderInline::marginAfter):

10:44 AM Changeset in webkit [67963] by commit-queue@webkit.org
  • 7 edits in trunk

2010-09-21 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Fix linking issues of the GTK+ port on Windows
https://bugs.webkit.org/show_bug.cgi?id=45844

  • GNUmakefile.am: link on Windows with ole32.dll, winmm.dll and shlwapi.dll
  • configure.ac: link on Windows with ole32.dll, winmm.dll and shlwapi.dll and export correctly all needed symbols from the libwebkitgtk DLL.

2010-09-21 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Build issues with Windows versions of the GTK+ port
https://bugs.webkit.org/show_bug.cgi?id=45844

Link with winmm.dll when necessary and specify the executable extension
explicitely so that the Programs/jsc-@WEBKITGTK_API_MAJOR_VERSION@
rule actually works.

Don't try to build the ThreadSpecificWin.cpp since GTK+ port uses
a section in ThreadSpecific.cpp

  • GNUmakefile.am:

2010-09-21 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Fix linking problems on Windows.
https://bugs.webkit.org/show_bug.cgi?id=45844

  • GNUmakefile.am: link the executables with winmm.dll
10:05 AM Changeset in webkit [67962] by abarth@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-09-21 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

HTML parser double quote error recovery doesn't match Firefox 3.0.x
https://bugs.webkit.org/show_bug.cgi?id=23970

This bug is fixed by the HTML5 parser. Adding test.

  • fast/tokenizer/unterminated-quote-in-noscript-expected.txt: Added.
  • fast/tokenizer/unterminated-quote-in-noscript.html: Added.
  • html5lib/resources/webkit02.dat:
9:48 AM Changeset in webkit [67961] by tony@chromium.org
  • 34 edits in trunk/LayoutTests

2010-09-17 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] last 16 linux baselines due to scrollbar arrows
https://bugs.webkit.org/show_bug.cgi?id=46019

  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/backgrounds-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/col_span2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/empty_cells-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium/test_expectations.txt:
9:34 AM Changeset in webkit [67960] by hyatt@apple.com
  • 4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46190, add borderStart/Before/End/After accessors to RenderBoxModelObject.

Reviewed by Dan Bernstein.

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::borderBefore):
(WebCore::RenderBoxModelObject::borderAfter):
(WebCore::RenderBoxModelObject::borderStart):
(WebCore::RenderBoxModelObject::borderEnd):
(WebCore::RenderBoxModelObject::borderAndPaddingLogicalHeight):
(WebCore::RenderBoxModelObject::borderAndPaddingLogicalWidth):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):

  • rendering/RenderTableCell.h:
9:26 AM Changeset in webkit [67959] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • mac/MainMac.cpp:

(closeUnusedFileDescriptors):
Move this out into a separate function.

(main):
Don't use the soft linking macros, they were bringing in WTFReportAssertionFailure.

9:16 AM Changeset in webkit [67958] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed a typo in the change log

9:02 AM Changeset in webkit [67957] by mrobinson@webkit.org
  • 4 edits in trunk

2010-09-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] 'make dist' should be fixed in preparation for the next release
https://bugs.webkit.org/show_bug.cgi?id=46129

  • GNUmakefile.am: Update the sources list to include missing headers.

2010-09-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] 'make dist' should be fixed in preparation for the next release
https://bugs.webkit.org/show_bug.cgi?id=46129

  • GNUmakefile.am: Update the sources list to include missing headers.
8:58 AM Changeset in webkit [67956] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46188, make the cross-platform setPrinting method match the Mac version of the method.
Specifically don't pass the page size down to subframes of the one you're printing.

Reviewed by John Sullivan.

  • page/Frame.cpp:

(WebCore::Frame::setPrinting):

8:53 AM Changeset in webkit [67955] by xan@webkit.org
  • 2 edits in trunk

2010-09-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Generate correct WebKit gir file with g-i 0.9.5
https://bugs.webkit.org/show_bug.cgi?id=46173

Generate a correct gir file for WebKit with the
gobject-introspection 0.9.5 scanner.

  • GNUmakefile.am:
8:39 AM Changeset in webkit [67954] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Zombie WebProcesses are left around
https://bugs.webkit.org/show_bug.cgi?id=46148
<rdar://problem/8455898>

Reviewed by Dan Bernstein.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::setupTerminationNotificationHandler):
Register a dispatch handler that calls waitpid when the child process exits. This prevents zombies from
staying around after the child process has quit.

(WebKit::ProcessLauncher::launchProcess):
Pass POSIX_SPAWN_START_SUSPENDED to posix_spawn to avoid race conditions when setting up the termination
notification handler. When the handler is set up we send the SIGCONT signal to the child process.

  • mac/MainMac.cpp:

(main):
Loop through all file descriptors except for stdin, stdout and stderr and close them.

  • WebKit2.xcodeproj/project.pbxproj:

Soft-link the Web process with WebKit2. We do this so we can ensure that we won't accidentally close any
file descriptors opened by initialization code that would have been called before main().

7:35 AM Changeset in webkit [67953] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Use WTF::Vector for storing formData in ResourceHandleWin.
https://bugs.webkit.org/show_bug.cgi?id=46180

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestComplete):
7:34 AM Changeset in webkit [67952] by satish@chromium.org
  • 2 edits
    1 move in trunk/LayoutTests

2010-09-21 Satish Sampath <satish@chromium.org>

Unreviewed, rename a test baseline to the correct name and update a test's expectation for chromium linux.

  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-actual.txt.
  • platform/chromium/test_expectations.txt:
7:30 AM Changeset in webkit [67951] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

2010-09-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Andreas Kling.

[Qt] Check if the reply has been deleted before finishing a network request
https://bugs.webkit.org/show_bug.cgi?id=46174

A crash can happen with the following sequence:

  1. QNetworkReplyHandler::abort() emits reply->deleteLater()
  2. QNAM emits QNetworkReply::finished() -> calls QNetworkReplyHandler::finish()
  3. event loop would call reply->deleteLater() However a crash occurs since m_reply == 0 on step 2.
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
7:19 AM Changeset in webkit [67950] by jochen@chromium.org
  • 2 edits in trunk/WebCore

2010-09-21 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Use @ to concatenate the database name and the database identifier when building
the filename to use for indexed databases. That character is valid for filenames
but cannot occur in a database identifier derived from a security origin.
https://bugs.webkit.org/show_bug.cgi?id=46178

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::databaseFileName):
7:03 AM Changeset in webkit [67949] by steveblock@google.com
  • 15 edits in trunk

2010-09-21 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
https://bugs.webkit.org/show_bug.cgi?id=45891

Tested by existing DeviceOrientation tests.

  • dom/DeviceMotionClient.h:
  • dom/DeviceMotionController.cpp: (WebCore::DeviceMotionController::~DeviceMotionController):
  • dom/DeviceMotionController.h:
  • dom/DeviceOrientationClient.h:
  • dom/DeviceOrientationController.cpp: (WebCore::DeviceOrientationController::~DeviceOrientationController):
  • dom/DeviceOrientationController.h:
  • loader/EmptyClients.h: (WebCore::EmptyDeviceMotionClient::deviceOrientationControllerDestroyed): (WebCore::EmptyDeviceOrientationClient::deviceOrientationControllerDestroyed):
  • platform/mock/DeviceOrientationClientMock.h: (WebCore::DeviceOrientationClientMock::deviceOrientationControllerDestroyed):

2010-09-21 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
https://bugs.webkit.org/show_bug.cgi?id=45891

Implements DeviceOrientationClientProxy::deviceOrientationControllerDestroyed() as a no-op,
as the client's lifetime is determined by the WebViewImpl.

  • src/DeviceOrientationClientProxy.cpp: (WebKit::DeviceOrientationClientProxy::deviceOrientationControllerDestroyed):
  • src/DeviceOrientationClientProxy.h:

2010-09-21 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
https://bugs.webkit.org/show_bug.cgi?id=45891

Implements WebDeviceOrientationClient::deviceOrientationControllerDestroyed to delete the client.

  • WebCoreSupport/WebDeviceOrientationClient.h:
  • WebCoreSupport/WebDeviceOrientationClient.mm: (WebDeviceOrientationClient::deviceOrientationControllerDestroyed):
6:47 AM Changeset in webkit [67948] by Patrick Gansterer
  • 9 edits in trunk/WebKit/wince

2010-09-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Add "WinCE" to classname for all WebCoreSupport classes to match filename.
https://bugs.webkit.org/show_bug.cgi?id=46175

  • WebCoreSupport/ContextMenuClientWinCE.cpp: Rename ContextMenuClient to ContextMenuClientWinCE.
  • WebCoreSupport/ContextMenuClientWinCE.h: Ditto.
  • WebCoreSupport/DragClientWinCE.cpp: Rename DragClient to DragClientWinCE.
  • WebCoreSupport/DragClientWinCE.h: Ditto.
  • WebCoreSupport/EditorClientWinCE.cpp: Rename EditorClient to EditorClientWinCE.
  • WebCoreSupport/EditorClientWinCE.h: Ditto.
  • WebCoreSupport/InspectorClientWinCE.cpp: Rename InspectorClient to InspectorClientWinCE.
  • WebCoreSupport/InspectorClientWinCE.h: Ditto.
6:32 AM Changeset in webkit [67947] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

feeder-queue svn updates more often than needed
https://bugs.webkit.org/show_bug.cgi?id=46171

We don't need to poll SVN every time we feed the feeders. Rather, we
can count on the wrapper shell script to auto-update the queue.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
6:10 AM Changeset in webkit [67946] by xan@webkit.org
  • 4 edits in trunk

2010-09-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.3.4 release.

  • configure.ac:

WebKit/gtk:

2010-09-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.3.4 release.

  • NEWS:
6:05 AM Changeset in webkit [67945] by commit-queue@webkit.org
  • 4 edits
    1 copy
    1 add in trunk/WebKit2

2010-09-21 Andras Becsi <abecsi@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] QtWebProcess should clean up shared memory map files on close
https://bugs.webkit.org/show_bug.cgi?id=45984

Relocate MappedMemory struct code to it's own header and implement
a singleton pool class (MappedMemoryPool) which tracks shared memory
to be able to clean up map files from disk if RunLoop stops.

  • Shared/qt/MappedMemory.h: Added. (WebKit::MappedMemory::markUsed): (WebKit::MappedMemory::markFree): (WebKit::MappedMemory::isFree):
  • Shared/qt/MappedMemoryPool.cpp: Added. (WebKit::MappedMemoryPool::MappedMemoryPool): (WebKit::MappedMemoryPool::instance): (WebKit::MappedMemoryPool::size): (WebKit::MappedMemoryPool::at): (WebKit::MappedMemoryPool::append): (WebKit::MappedMemoryPool::cleanUp):
  • Shared/qt/UpdateChunk.cpp: (WebKit::mapMemory): (WebKit::mapFile):
  • Shared/qt/UpdateChunk.h:
  • WebKit2.pro:
5:31 AM Changeset in webkit [67944] by satish@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-09-21 Satish Sampath <satish@chromium.org>

Unreviewed, disable a test in chromium per the original author and added missing expectations for another.

  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-actual.txt: Added.
  • platform/chromium/test_expectations.txt:
4:59 AM Changeset in webkit [67943] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-09-21 Dave Tapuska <dtapuska@rim.com>

Reviewed by Csaba Osztrogonác.

https://bugs.webkit.org/show_bug.cgi?id=45673

r65596 caused ENABLE_PROFILER_REFERENCE_OFFSET to not be
8 byte aligned. A non 8 byte divisible value for this will
cause the sp to become non 8 byte aligned.

Verify and correct offset values that r65596 effected that
weren't updated.

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
4:25 AM Changeset in webkit [67942] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/WebKitTools

[Qt] Add robot loader timeout and extra time options.
https://bugs.webkit.org/show_bug.cgi?id=46172

Reviewed by Andreas Kling.

[-robot-timeout <s>]: Load the next page after s seconds if the current
page didn't finish loading.
[-robot-extra-time <s>]: Wait s seconds after the current page finished
loading before loading the next one. This should allow some time for the
page's JavaScript to execute.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::applyPrefs):

  • QtTestBrowser/main.cpp:

(LauncherApplication::robotTimeout):
(LauncherApplication::robotExtraTime):
(LauncherApplication::LauncherApplication):
(LauncherApplication::handleUserOptions):
(main):

  • QtTestBrowser/urlloader.cpp:

(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::loadUrlList):

  • QtTestBrowser/urlloader.h:
4:15 AM Changeset in webkit [67941] by jochen@chromium.org
  • 6 edits
    1 add in trunk

2010-09-21 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Factor out the file name used for a given indexed database to a static method.
https://bugs.webkit.org/show_bug.cgi?id=46090

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::openSQLiteDatabase): (WebCore::IDBFactoryBackendImpl::databaseFileName):
  • storage/IDBFactoryBackendImpl.h:

2010-09-21 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] expose the filename used for a given indexed DB
https://bugs.webkit.org/show_bug.cgi?id=46090

  • WebKit.gyp:
  • public/WebIDBFactory.h:
  • src/WebIDBFactory.cpp: (WebKit::WebIDBFactory::databaseFileName):
3:55 AM Changeset in webkit [67940] by xan@webkit.org
  • 2 edits in trunk

2010-09-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Configure flag for Opcode stats
https://bugs.webkit.org/show_bug.cgi?id=46081

Opcode stats won't work with JIT enabled, so bail out if both are
enabled at the same time.

  • configure.ac:
3:55 AM Changeset in webkit [67939] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix Opcode stats compilation
https://bugs.webkit.org/show_bug.cgi?id=46079

The FixedArray API had changed, and <stdio.h> was not included for
printf.

  • bytecode/Opcode.cpp: (JSC::OpcodeStats::~OpcodeStats):
3:55 AM Changeset in webkit [67938] by xan@webkit.org
  • 2 edits in trunk

2010-09-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix --disable-jit
https://bugs.webkit.org/show_bug.cgi?id=46080

Manually define ENABLE_JIT to 0 when we want the feature disabled.

If the value is undefined Platform.h will enable it again
automatically in some platforms, which is probably not what the
user wanted if he passed --disable-jit.

  • configure.ac:
3:27 AM Changeset in webkit [67937] by satish@chromium.org
  • 1 edit
    3 moves in trunk/LayoutTests

2010-09-21 Satish Sampath <satish@chromium.org>

Unreviewed, move an xp-specific results to win-xp

  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.checksum.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt.
3:21 AM Changeset in webkit [67936] by aestes@apple.com
  • 9 edits in trunk/LayoutTests

2010-09-21 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

Test that parser quirks apply when processing both start and end tags.
https://bugs.webkit.org/show_bug.cgi?id=40961

  • fast/parser/pre-html5-parser-quirks-expected.txt:
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-name-state.html:
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-quoted-state.html:
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-unquoted-state.html:
  • fast/parser/resources/pre-html5-parser-quirk-attribute-name-state.html:
  • fast/parser/resources/pre-html5-parser-quirk-before-attribute-name-state.html:
  • fast/parser/resources/pre-html5-parser-quirk-document-fragment.html:
  • fast/parser/resources/pre-html5-parser-quirk-tag-name-state.html:
3:09 AM Changeset in webkit [67935] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-21 Pavel Podivilov <podivilov@chromium.org>

Unreviewed.

[Chromium] remove test expectations for tests regressed in r67178:r67358 (fixed in r67659)

  • platform/chromium/test_expectations.txt:
2:24 AM Changeset in webkit [67934] by podivilov@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-21 Pavel Podivilov <podivilov@chromium.org>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
2:21 AM Changeset in webkit [67933] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-09-21 Dirk Schulze <krit@webkit.org>

SVG Filter cleanup
https://bugs.webkit.org/show_bug.cgi?id=45612

Unreviewed change of episolon back to a more tolerant value in RenderTreeAsText and made it a static const.
This should turn the bots green again.

  • rendering/RenderTreeAsText.cpp: (WebCore::hasFractions):
2:02 AM CommitterTips edited by podivilov@chromium.org
(diff)
1:29 AM Changeset in webkit [67932] by alex
  • 2 edits in trunk/LayoutTests

2010-09-21 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skipped crashing test:
media/video-controls-with-mutation-event-handler.html. Added the
bug: https://bugs.webkit.org/show_bug.cgi?id=46169

  • platform/gtk/Skipped:
1:02 AM Changeset in webkit [67931] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-09-21 Adam Barth <abarth@webkit.org>

Unreviewed.

[reviewtool] Publish button doesn't work
https://bugs.webkit.org/show_bug.cgi?id=46168

Darin's recent patch had a runtime error. Sadly, we don't have any
testing for this code.

  • code-review.js:
12:45 AM Changeset in webkit [67930] by hyatt@apple.com
  • 5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46125, convert table cell intrinsic padding from top/bottom-based
to before/after-based. A vertical text table can have intrinsic padding built into the left/right
direction (and this allows the base class logical padding methods on RenderBoxModelObject to be safe to use).

Reviewed by Dan Bernstein.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::setIntrinsicPaddingBefore):
(WebCore::RenderTableCell::setIntrinsicPaddingAfter):
(WebCore::RenderTableCell::setIntrinsicPadding):
(WebCore::RenderTableCell::intrinsicPaddingBefore):
(WebCore::RenderTableCell::intrinsicPaddingAfter):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowHeight):
(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeTextRun):

12:36 AM Changeset in webkit [67929] by krit@webkit.org
  • 48 edits in trunk/WebCore

2010-09-21 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter cleanup
https://bugs.webkit.org/show_bug.cgi?id=45612

Second cleanup patch. Modified files to follow webkit style. Removed dependencies
to SVG of most of the filter effects and prepared them to move from WebCore/svg/graphics/filters
to WebCore/platform/graphics/filters/.
Renamed calculateDrawingIntRect and calculateDrawingRect to requestedRegionOfInputImageData and
drawingRegionOfInputImage to clarify the functionality and make both functions distinguishable.

  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
  • platform/graphics/filters/FEComponentTransfer.h: (WebCore::ComponentTransferFunction::ComponentTransferFunction):
  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/Filter.h:
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::requestedRegionOfInputImageData): (WebCore::FilterEffect::drawingRegionOfInputImage): (WebCore::FilterEffect::effectContext):
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/ImageBufferFilter.cpp:
  • platform/graphics/filters/ImageBufferFilter.h:
  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
  • platform/graphics/filters/SourceAlpha.h: (WebCore::SourceAlpha::isSourceInput): (WebCore::SourceAlpha::SourceAlpha):
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
  • platform/graphics/filters/SourceGraphic.h: (WebCore::SourceGraphic::isSourceInput): (WebCore::SourceGraphic::SourceGraphic):
  • rendering/RenderTreeAsText.cpp: (WebCore::hasFractions): (WebCore::operator<<):
  • rendering/RenderTreeAsText.h: (WebCore::operator<<):
  • rendering/SVGRenderTreeAsText.cpp:
  • rendering/SVGRenderTreeAsText.h:
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::apply):
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp:
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply): (WebCore::FEFlood::externalRepresentation):
  • svg/graphics/filters/SVGFEFlood.h:
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFELighting.cpp: (WebCore::FELighting::apply):
  • svg/graphics/filters/SVGFELighting.h:
  • svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp:
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::FETurbulence::apply):
  • svg/graphics/filters/SVGFETurbulence.h:

Sep 20, 2010:

11:54 PM Changeset in webkit [67928] by Philippe Normand
  • 38 edits
    2 adds in trunk

2010-09-20 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New items in the media Element context menu:

  • play/pause
  • mute/unmute
  • controls display control
  • switch to fullscreen (for video only)
  • loop playback control
  • copy media url to clipboard
  • open in new window

Test: media/context-menu-actions.html

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/brew/LocalizedStringsBrew.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL): (WebCore::HitTestResult::mediaSupportsFullscreen): (WebCore::HitTestResult::mediaElement): (WebCore::HitTestResult::toggleMediaControlsDisplay): (WebCore::HitTestResult::toggleMediaLoopPlayback): (WebCore::HitTestResult::enterFullscreenForVideo): (WebCore::HitTestResult::mediaControlsEnabled): (WebCore::HitTestResult::mediaLoopEnabled): (WebCore::HitTestResult::mediaPlaying): (WebCore::HitTestResult::toggleMediaPlayState): (WebCore::HitTestResult::mediaHasAudio): (WebCore::HitTestResult::mediaMuted): (WebCore::HitTestResult::toggleMediaMuteState):
  • rendering/HitTestResult.h:

LayoutTests:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New test checking the actions that can be triggered by activating
the contex-menu of the media element. Skipped on mac, qt and win
because of lack of DRT support.

  • media/context-menu-actions-expected.txt: Added.
  • media/context-menu-actions.html: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

WebKit:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

Updated localizable strings.

  • English.lproj/Localizable.strings:

WebKit/chromium:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New localized strings for the media element context-menu.

  • src/LocalizedStrings.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):

WebKit/mac:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New localized strings for the media element context-menu.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagToggleMediaControls): (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): (WebPlatformStrategies::contextMenuItemTagMediaPlay): (WebPlatformStrategies::contextMenuItemTagMediaPause): (WebPlatformStrategies::contextMenuItemTagMediaMute):

Webkit/qt:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

  • WebCoreSupport/WebPlatformStrategies.cpp:
  • WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagToggleMediaControls) (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop) (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen) (WebPlatformStrategies::contextMenuItemTagMediaPlay) (WebPlatformStrategies::contextMenuItemTagMediaPause) (WebPlatformStrategies::contextMenuItemTagMediaMute)

WebKit/win:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New localized strings for the media element context-menu.

  • WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagToggleMediaControls): (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): (WebPlatformStrategies::contextMenuItemTagMediaPlay): (WebPlatformStrategies::contextMenuItemTagMediaPause): (WebPlatformStrategies::contextMenuItemTagMediaMute):
  • WebCoreSupport/WebPlatformStrategies.h:

WebKit2:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New localized strings for the media element context-menu.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebKit::WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebKit::WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebKit::WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebKit::WebPlatformStrategies::contextMenuItemTagToggleMediaControls): (WebKit::WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): (WebKit::WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaPlay): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaPause): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaMute): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaUnMute):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

WebKitTools:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

EventSender::contextClick() now returns an array of js
objects. Each object has a title property and a click() method.

  • DumpRenderTree/gtk/EventSender.cpp: (getMenuItemTitleCallback): (setMenuItemTitleCallback): (menuItemClickCallback): (getMenuItemClass): (contextClickCallback):
11:44 PM Changeset in webkit [67927] by Darin Adler
  • 3 edits in trunk/BugsSite

2010-09-20 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Add Preview button and link to bug to patch review bar
https://bugs.webkit.org/show_bug.cgi?id=46153

  • PrettyPatch/PrettyPatch.rb: Bump version number to make caches happy.
  • code-review.js: Added Preview button and link to bug.
10:44 PM Changeset in webkit [67926] by hayato@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-20 Hayato Ito <hayato@chromium.org>

Unreviewed.
Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
10:25 PM Changeset in webkit [67925] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by Daniel Bates.

[BREWMP] Handle tab key
https://bugs.webkit.org/show_bug.cgi?id=46104

In Brew MP, AVK_FUNCTION is the key code for tab.
Process AVK_FUNCTION as tab in PlatformKeyboardEvent.

  • platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::keyIdentifierForBrewKeyCode): (WebCore::windowsKeyCodeForKeyEvent):
10:06 PM Changeset in webkit [67924] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test_expectations.txt update.

All of the fill-mode tests that used to fail on Windows were fixed by
r67877. change-one-anim.html and combo-transform-translate+scale.html
haven't failed in the past 750 runs.

  • platform/chromium/test_expectations.txt:
9:50 PM Changeset in webkit [67923] by mihaip@chromium.org
  • 4 edits in trunk/LayoutTests

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Unreviewed expectations update for Windows for r67898.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
9:36 PM Changeset in webkit [67922] by commit-queue@webkit.org
  • 3 edits
    1 move in trunk/WebCore

2010-09-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67918.
http://trac.webkit.org/changeset/67918
https://bugs.webkit.org/show_bug.cgi?id=46162

Broke chromium win compile (Requested by jamesr on #webkit).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Renamed from WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp. (WebCore::GlyphPage::fill):
9:27 PM Changeset in webkit [67921] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-09-20 Daniel Bates <dbates@rim.com>

Reviewed by Dan Bernstein.

Cleanup: Extract common border radii expansion code in
RenderBoxModelObject::paintBoxShadow() into function
https://bugs.webkit.org/show_bug.cgi?id=45934

Extracted code for expanding and clamping the border radii
into common function to remove duplicate code.

No functionality was changed. So, no new tests.

  • rendering/RenderBoxModelObject.cpp: (WebCore::uniformlyExpandBorderRadii): Added. (WebCore::RenderBoxModelObject::paintBoxShadow): Moved common code to uniformlyExpandBorderRadii().
9:07 PM Changeset in webkit [67920] by Dimitri Glazkov
  • 18 edits
    18 adds in trunk/LayoutTests

2010-09-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Ojan Vafai.

Create Chromium/Skia baselines for tests, affected by http://trac.webkit.org/changeset/65665.
https://bugs.webkit.org/show_bug.cgi?id=46062

  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.checksum:
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.checksum:
  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.png: Added.
  • platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pattern-no-pixelation-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/pattern-no-pixelation-expected.png: Added.
  • platform/chromium-linux/svg/custom/stroked-pattern-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/stroked-pattern-expected.png: Added.
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.checksum:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-win/svg/custom/non-scaling-stroke-expected.checksum:
  • platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
  • platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
  • platform/chromium-win/svg/custom/pattern-no-pixelation-expected.checksum: Added.
  • platform/chromium-win/svg/custom/pattern-no-pixelation-expected.png: Added.
  • platform/chromium-win/svg/custom/stroked-pattern-expected.checksum:
  • platform/chromium-win/svg/custom/stroked-pattern-expected.png:
  • platform/chromium/test_expectations.txt:
8:51 PM Changeset in webkit [67919] by thakis@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-20 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Trivial clang warning fix
https://bugs.webkit.org/show_bug.cgi?id=46143

  • src/WebFileSystemCallbacksImpl.h:
8:45 PM Changeset in webkit [67918] by commit-queue@webkit.org
  • 3 edits
    1 move in trunk/WebCore

2010-09-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by James Robinson.

Make sure skia is not Chromium specific
https://bugs.webkit.org/show_bug.cgi?id=39672

GGlyphPageTreeNodeLinux does not depend on Linux or Chromium.
Move GGlyphPageTreeNodeLinux to platform/graphics/skia and rename it to
GlyphPageTreeNodeSkia.cpp so that other ports can use it.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Removed.
  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added.
8:37 PM Changeset in webkit [67917] by kinuko@chromium.org
  • 9 edits in trunk/WebCore

2010-09-20 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add NoStaticTables attributes to IDLs of FileSystem API for Worker support
https://bugs.webkit.org/show_bug.cgi?id=46021

Added NoStaticTables attributes to IDLs except for ones for Callbacks.
(As NoStaticTables only affects non-callback interfaces.)

  • fileapi/DOMFileSystem.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryReader.idl:
  • fileapi/Entry.idl:
  • fileapi/EntryArray.idl:
  • fileapi/FileEntry.idl:
  • fileapi/Flags.idl:
  • fileapi/Metadata.idl:
8:24 PM Changeset in webkit [67916] by abarth@webkit.org
  • 10 edits in trunk/WebKitTools

2010-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The tool member variable should be called _tool
https://bugs.webkit.org/show_bug.cgi?id=46160

Created by find-and-replace.

  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/openbugs.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/multicommandtool.py:
8:08 PM Changeset in webkit [67915] by thakis@chromium.org
  • 3 edits in trunk/WebCore

2010-09-20 Nico Weber <thakis@chromium.org>

Reviewed by Adam Barth.

Fix "operands of ? are integers of different signs" clang warnings
https://bugs.webkit.org/show_bug.cgi?id=46157

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::advance):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
7:52 PM Changeset in webkit [67914] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-20 Adam Barth <abarth@webkit.org>

I ran the tests before landing but ignored the fact that they failed. :(

  • Scripts/webkitpy/tool/commands/queues.py:
7:45 PM Changeset in webkit [67913] by abarth@webkit.org
  • 5 edits
    2 adds in trunk/WebKitTools

2010-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a feeder queue that polls bugs.webkit.org for the commit-cluster
https://bugs.webkit.org/show_bug.cgi?id=46141

The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
list of work items on the status server. The individual commit-cluster
nodes then grab the patches from the server and process them.

  • Scripts/webkitpy/tool/bot/feeders.py: Added.
  • Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
7:12 PM Changeset in webkit [67912] by vangelis@chromium.org
  • 3 edits in trunk/WebCore

2010-09-20 Vangelis Kokkevis <vangelis@chromium.org>

Unreviewed, rolling out r67906.
http://trac.webkit.org/changeset/67906
https://bugs.webkit.org/show_bug.cgi?id=46139

Change causes chromium to crash when switching pages

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h:
7:07 PM Changeset in webkit [67911] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-20 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Darin Adler.

build-webkit: Add support for CMake build system
https://bugs.webkit.org/show_bug.cgi?id=44979

  • Scripts/build-webkit: Add "--efl" command-line option to build the EFL port of WebKit.
  • Scripts/webkitdirs.pm: Define buildCMakeProject() and buildEflCMakeProject() subroutines.
7:03 PM Changeset in webkit [67910] by commit-queue@webkit.org
  • 1 edit in trunk/WebKit/chromium

Update svn:ignore to ignore more Chromium specific files that are not part of the repository

6:51 PM Changeset in webkit [67909] by tonikitoo@webkit.org
  • 4 edits in trunk/WebCore

2010-09-19 Antonio Gomes <agomes@rim.com>

Reviewed by Ojan Vafai.

SelectionController::modify should ask EditingBehavior for platform specific behavior
https://bugs.webkit.org/show_bug.cgi?id=41975

As a follow up of the refactoring work in bug 39854, patch makes SelectionController::modify()
stop accessing EditingBehaviorType values directly, and replaces its use by the EditingBehavior class.

Since the "Settings*" parameter of the private SelectionController::modify() method becomes unneeded
with this change (it was used to query the editingBehaviorType), patch merges two modify() methods.

No behavior change, so no new tests.

  • editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldAlwaysGrowSelectionWhenExtendingToBoundary):
  • editing/SelectionController.cpp: (WebCore::SelectionController::modify):
  • editing/SelectionController.h:
6:45 PM Changeset in webkit [67908] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for r67898.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:

Updated to reflect r67898.

6:38 PM Changeset in webkit [67907] by mihaip@chromium.org
  • 9 edits in trunk/LayoutTests

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Rebaseline tests after HashChangeEvent was added by r67898
https://bugs.webkit.org/show_bug.cgi?id=46155

GTK and Qt changes that mirror the changes from r67898, plus a missed
test window-property-descriptors from the original change.

  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
6:35 PM Changeset in webkit [67906] by vangelis@chromium.org
  • 3 edits in trunk/WebCore

2010-09-20 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Making destructors of LayerChromium and ContentLayerChromium virtual
so that the derived class' destructor code gets called.
https://bugs.webkit.org/show_bug.cgi?id=46139

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h:
6:26 PM Changeset in webkit [67905] by dpranke@chromium.org
  • 9 edits in trunk/WebKitTools

2010-09-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: refactor command line args getting passed to DRT

This change cleans up some argument parsing between functions to get
rid of some overlapping data structures. There should be no functional
changes in this patch; it is pure refactoring in preparation for
landing the Chrome GPU port and adding a generic way to pass
args to DRT/TestShell.

https://bugs.webkit.org/show_bug.cgi?id=46135

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • pass the options argument explicitly to the threads and drivers, also consolidate the passing of options to the driver.
    • pass options directly to process_output() to remove a couple parameters (minor cleanup).
  • Scripts/webkitpy/layout_tests/port/base.py:
    • pass the options argument to Port.create_driver().
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
    • update Port.create_driver() test
  • Scripts/webkitpy/layout_tests/port/chromium.py:
    • pass the options argument to Port.create_driver(), and clean up building of the cmd line for DRT.
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
    • pass the options argument to Port.create_driver()
  • Scripts/webkitpy/layout_tests/port/test.py:
    • pass the options argument to Port.create_driver()
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • pass the options argument to Port.create_driver(), and clean up building of the cmd line for DRT.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • consolidate args in _get_dump_render_tree_args and rename to _get_test_args(); move all of the command-line args to the Port implementations.
6:11 PM Changeset in webkit [67904] by Darin Adler
  • 2 edits in trunk

Fix wrong change log! It should have said this:

Deprecate the inputType function on HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=46023

Reviewed by James Robinson.

WebCore:

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement): Use m_deprecatedTypeNumber.
(WebCore::HTMLInputElement::isValidValue): Use deprecatedInputType.
(WebCore::HTMLInputElement::typeMismatch): Ditto.
(WebCore::HTMLInputElement::valueMissing): Ditto.
(WebCore::HTMLInputElement::rangeUnderflow): Ditto.
(WebCore::HTMLInputElement::rangeOverflow): Ditto.
(WebCore::HTMLInputElement::minimum): Ditto.
(WebCore::HTMLInputElement::maximum): Ditto.
(WebCore::HTMLInputElement::stepBase): Ditto.
(WebCore::HTMLInputElement::stepMismatch): Ditto.
(WebCore::HTMLInputElement::getStepParameters): Ditto.
(WebCore::HTMLInputElement::getAllowedValueStep): Ditto.
(WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
(WebCore::HTMLInputElement::shouldUseInputMethod): Ditto.
(WebCore::HTMLInputElement::handleBlurEvent): Ditto.
(WebCore::HTMLInputElement::setType): Added a comment.
(WebCore::HTMLInputElement::updateType): Replaced the setInputType function
with this. The type is always the type attribute value, so there is no value
in passing the type string in, and this is an internal implementation detail,
not a public function.
(WebCore::createFormControlTypes): Use deprecatedNumberOfTypes.
(WebCore::HTMLInputElement::formControlType): Use deprecatedInputType.
(WebCore::HTMLInputElement::saveFormControlState): Ditto.
(WebCore::HTMLInputElement::restoreFormControlState): Ditto.
(WebCore::HTMLInputElement::accessKeyAction): Ditto.
(WebCore::HTMLInputElement::mapToEntry): Ditto.
(WebCore::HTMLInputElement::parseMappedAttribute): Ditto.
(WebCore::HTMLInputElement::rendererIsNeeded): Ditto.
(WebCore::HTMLInputElement::createRenderer): Ditto.
(WebCore::HTMLInputElement::attach): Ditto.
(WebCore::HTMLInputElement::isSuccessfulSubmitButton): Ditto.
(WebCore::HTMLInputElement::appendFormData): Ditto.
(WebCore::HTMLInputElement::isTextField): Ditto.
(WebCore::HTMLInputElement::isTextType): Ditto.
(WebCore::HTMLInputElement::setChecked): Ditto.
(WebCore::HTMLInputElement::value): Ditto.
(WebCore::HTMLInputElement::valueWithDefault): Ditto.
(WebCore::HTMLInputElement::setSuggestedValue): Ditto.
(WebCore::HTMLInputElement::setValue): Ditto.
(WebCore::HTMLInputElement::parseToDouble): Ditto.
(WebCore::HTMLInputElement::valueAsDate): Ditto.
(WebCore::HTMLInputElement::setValueAsDate): Ditto.
(WebCore::HTMLInputElement::valueAsNumber): Ditto.
(WebCore::HTMLInputElement::setValueAsNumber): Ditto.
(WebCore::HTMLInputElement::serializeForDateTimeTypes): Ditto.
(WebCore::HTMLInputElement::serialize): Ditto.
(WebCore::HTMLInputElement::setValueFromRenderer): Ditto.
(WebCore::HTMLInputElement::storesValueSeparateFromAttribute): Ditto.
(WebCore::HTMLInputElement::preDispatchEventHandler): Ditto.
(WebCore::HTMLInputElement::postDispatchEventHandler): Ditto.
(WebCore::HTMLInputElement::defaultEventHandler): Ditto.
(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent): Ditto.
(WebCore::HTMLInputElement::files): Ditto.
(WebCore::HTMLInputElement::isAcceptableValue): Ditto.
(WebCore::HTMLInputElement::sanitizeValue): Ditto.
(WebCore::HTMLInputElement::hasUnacceptableValue): Ditto.
(WebCore::HTMLInputElement::needsActivationCallback): Ditto.
(WebCore::HTMLInputElement::isRequiredFormControl): Ditto.
(WebCore::HTMLInputElement::recalcWillValidate): Ditto.
(WebCore::HTMLInputElement::parseToDateComponents): Ditto.
(WebCore::HTMLInputElement::dataList): Ditto.
(WebCore::HTMLInputElement::isSpeechEnabled): Ditto.

  • html/HTMLInputElement.h: Renamed InputType to DeprecatedInputType since it

should not be used outside this class. Renamed numberOfTypes to
dprecatedNumberOfTypes for the same reason. Changed all code to use
deprecatedInputType function instead of m_type. Renamed inputType function
to deprecatedInputType. Replaced public setInputType function with private
updateType function. Renamed m_type data member to m_deprecatedTypeNumber.

  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlInputElement::MediaControlInputElement):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement):
Use setType instead of setInputType.

WebKit/chromium:

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::inputType):

  • src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

  • src/WebSearchableFormData.cpp:

(WebCore::HasSuitableTextElement):
Use deprecatedInputType instead of inputType.

6:06 PM Changeset in webkit [67903] by Darin Adler
  • 9 edits in trunk

2010-09-20 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
https://bugs.webkit.org/show_bug.cgi?id=45912

Switched Chromium's compositor to use GraphicsContext3D to issue
its OpenGL rendering calls rather than the Chromium-specific
GLES2Context and command buffer OpenGL implementation.

The in-process software rendering path for GraphicsContext3D does
not yet work with the compositor, at least not on Mac OS X. This
will be worked on in subsequent bugs.

Tested manually with 3D CSS, WebGL and video content on Mac OS X
and Linux. No new tests.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::extractWebGraphicsContext3D): (WebCore::GraphicsContext3D::create):
  • src/GraphicsContext3DInternal.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::gles2Context): (WebKit::WebViewImpl::graphicsContext3D):
  • src/WebViewImpl.h:

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Unreviewed; an attempt to fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
5:51 PM Changeset in webkit [67902] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations changes (added back mistakenly-deleted lines).

  • platform/chromium/test_expectations.txt:
5:46 PM Changeset in webkit [67901] by mihaip@chromium.org
  • 2 edits in trunk/WebCore

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Unreviewed; an attempt to fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
5:42 PM Changeset in webkit [67900] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-09-20 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

When PDF image is directly composited, it does not display
https://bugs.webkit.org/show_bug.cgi?id=46144

In the "direct image compositing" code path, we set the image directly
as the contents of the GraphicsLayer. However, this only works with
bitmap images, so we have to check that the image is a bitmap image.

Test: compositing/images/direct-pdf-image.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
5:42 PM Changeset in webkit [67899] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-09-20 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Crash when div with content set to image gets composited (Vimeo).
https://bugs.webkit.org/show_bug.cgi?id=46140

When CSS specifies that the content of an element is an image, we make
a RenderImage, and setStyle() before setting the image resource. In this
case the compositing code can attempt to access the cached image, which
would crash with a null deref.

Fix by null-checking m_imageResource.

Test: compositing/images/content-image.html

  • rendering/RenderImage.h: (WebCore::RenderImage::cachedImage):
5:22 PM Changeset in webkit [67898] by mihaip@chromium.org
  • 21 edits
    4 adds in trunk

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Hashchange event is no longer a simple event, needs to be its own interface
https://bugs.webkit.org/show_bug.cgi?id=36335

Add explicit test for newURL and oldURL properties of hashchange events.
Add HashChangeEvent to expected global objects.
Update stateobjects tests to also check newURL on the hashchange event.

The original version of this patch was written by
Steven Lai <s3lance@hotmail.com>.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • fast/loader/hashchange-event-properties-expected.txt: Added.
  • fast/loader/hashchange-event-properties.html: Added.
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Hashchange event is no longer a simple event, needs to be its own interface
https://bugs.webkit.org/show_bug.cgi?id=36335

Add HashChangeEvent.idl and supporting files/changes.

Test: fast/loader/hashchange-event-properties.html

The original version of this patch was written by
Steven Lai <s3lance@hotmail.com>.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Document.cpp: (WebCore::Document::enqueueHashchangeEvent):
  • dom/Event.cpp: (WebCore::Event::isHashChangeEvent):
  • dom/Event.h:
  • dom/HashChangeEvent.h: Added. (WebCore::HashChangeEvent::isHashChangeEvent): (WebCore::HashChangeEvent::create): (WebCore::HashChangeEvent::initHashChangeEvent): (WebCore::HashChangeEvent::oldURL): (WebCore::HashChangeEvent::newURL): (WebCore::HashChangeEvent::HashChangeEvent):
  • dom/HashChangeEvent.idl: Added.
  • page/DOMWindow.idl:
5:18 PM Changeset in webkit [67897] by atwilson@chromium.org
  • 8 edits
    4 deletes in trunk

Revert r67892 (expectations update) as the expectations are out-of-date due to r67879.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • platform/chromium-mac/fast/repaint/table-cell-move-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.png: Removed.
  • platform/chromium-win/fast/repaint/table-cell-move-expected.checksum:
  • platform/chromium-win/fast/repaint/table-cell-move-expected.png:
  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.checksum:
  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/chromium/test_expectations.txt:
5:12 PM Changeset in webkit [67896] by mihaip@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Add explicit --force-patch flag to webkitpy tools
https://bugs.webkit.org/show_bug.cgi?id=46103

It wasn't obvious until I read the applypatch.py source code that
--non-interfactive implies passing --force to patch. Add --force-patch
as an alias to the flag, so that this behavior is more discoverable.

  • Scripts/webkitpy/tool/steps/applypatch.py:
  • Scripts/webkitpy/tool/steps/options.py:
5:07 PM Changeset in webkit [67895] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-20 Eric Seidel <eric@webkit.org>

Unreviewed, adding a line which got dropped and is trivially correct (and tested).

commit-queue can't land patches
https://bugs.webkit.org/show_bug.cgi?id=46138

Add a line of code I forgot in my last commit.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
5:04 PM Changeset in webkit [67894] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed detection of alternative smaller than the first alternative
to only check looping alternatives.
https://bugs.webkit.org/show_bug.cgi?id=46049

Patch by Michael Saboff <msaboff@apple.com> on 2010-09-20
Reviewed by Gavin Barraclough.

  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generateDisjunction):

4:59 PM Changeset in webkit [67893] by abarth@webkit.org
  • 2 edits
    1 copy in trunk/WebKitTools

2010-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The commit-cluster bots still race to lock patch_ids
https://bugs.webkit.org/show_bug.cgi?id=46130

It turns out we need to use a transaction object to make the
read/modify/write lock operation atomic. From reading the AppEngine
documentation, I think this patch should do what we want. It's hard to
test locally because the test instance isn't distributed in the same
way the production instance is.

  • QueueStatusServer/handlers/nextpatch.py:
  • QueueStatusServer/model/activeworkitems.py: Added.
4:57 PM CommitQueue edited by mihaip@chromium.org
The commit queue no longer blocks on tree redness (as of r66058) (diff)
4:55 PM Changeset in webkit [67892] by atwilson@chromium.org
  • 7 edits
    4 adds in trunk

Unreviewed expectations update for chromium.

  • platform/chromium-mac/fast/repaint/table-cell-move-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-cell-move-expected.checksum:
  • platform/chromium-win/fast/repaint/table-cell-move-expected.png:
  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.checksum:
  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/chromium/test_expectations.txt:

Removed duplicate expectations entries to allow rebaselining tool to work.
Disabled 2d.imageData.get.source.outside.html test as it fails on Chromium.

4:25 PM Changeset in webkit [67891] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Add a way to delay sending replies to sync requests
https://bugs.webkit.org/show_bug.cgi?id=46117

Reviewed by Adam Roben.

Change the didReceiveSyncMessage client message to return a SyncReplyMode. If the SyncReplyMode is
AutomaticReply, the reply will be sent when the didReceiveSyncMessage function returns. However, if it is
ManualReply, then the client is handed ownership of the reply ArgumentEncoder and can choose to send it
at a later time using Connection::sendSyncReply.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendSyncReply):
Send the message as a sync reply.

(CoreIPC::Connection::dispatchMessages):
Check the return value of didReceiveSyncMessage. If it is AutomaticReply, immediately send the reply.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::MessageReceiver::didReceiveSyncMessage):
Change return type.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • UIProcess/WebProcessProxy.h:

Update for changed return type.

4:01 PM Changeset in webkit [67890] by aestes@apple.com
  • 22 edits
    9 adds in trunk

2010-09-20 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961

Implement WebKitUsePreHTML5ParserQuirks preference.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to false. (-[WebPreferences usePreHTML5ParserQuirks]): (-[WebPreferences setUsePreHTML5ParserQuirks:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings with the value of WebKitUsePreHTML5ParserQuirks when a preference changes.

2010-09-20 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961

Add an optional quirk to the HTML5 tokenizer that reverts it to WebKit's
legacy behavior when the start of a new token is encountered before the
current token is finished parsing. The legacy behavior is to emit the
current token as if it were properly closed and being parsing the new
token.

Test: fast/parser/pre-html5-parser-quirks.html

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): Instantiate m_tokenizer with the value of Settings::usePreHTML5ParserQuirks(). (WebCore::usePreHTMLParserQuirks): Add a helper function to return the value of Settings::usePreHTML5ParserQuirks() if Settings is non-NULL.
  • html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLPreloadScanner::HTMLPreloadScanner): Instantiate m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
  • html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::nextToken): If the quirk is enabled and an unexpected '<' is encountered in certain states, emit the current token and reprocess the '<' as the start of a new token.
  • html/parser/HTMLTokenizer.h: (WebCore::HTMLTokenizer::create):
  • html/parser/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::HTMLViewSourceParser): Instantiate m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setUsePreHTML5ParserQuirks): (WebCore::Settings::usePreHTML5ParserQuirks):

2010-09-20 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961

  • fast/parser/pre-html5-parser-quirks-expected.txt: Added.
  • fast/parser/pre-html5-parser-quirks.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-name-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-quoted-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-unquoted-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-attribute-name-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-before-attribute-name-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-document-fragment.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-tag-name-state.html: Added.
  • platform/chromium/test_expectations.txt: Skip pre-html5-parser-quirks.html.
  • platform/gtk/Skipped: Skip pre-html5-parser-quirks.html.
  • platform/mac-wk2/Skipped: Skip pre-html5-parser-quirks.html.
  • platform/qt/Skipped: Skip pre-html5-parser-quirks.html.
  • platform/win/Skipped: Skip pre-html5-parser-quirks.html.

2010-09-20 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961

Implement WebKitUsePreHTML5ParserQuirks preference.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks to false after a test finishes.
3:49 PM Changeset in webkit [67889] by hyatt@apple.com
  • 4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46132, add an isVerticalBlockFlow() method to RenderStyle and
patch callers so that they don't have to check both top-to-bottom and bottom-to-top block flow.

Reviewed by Dan Bernstein.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalWidth):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::logicalWidth):
(WebCore::RenderStyle::logicalHeight):
(WebCore::RenderStyle::logicalMinWidth):
(WebCore::RenderStyle::logicalMaxWidth):
(WebCore::RenderStyle::logicalMinHeight):
(WebCore::RenderStyle::logicalMaxHeight):
(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::isVerticalBlockFlow):

3:39 PM Changeset in webkit [67888] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows build fix

  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put

$(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
we'll pick up the most recent versions of the headers.

3:38 PM Changeset in webkit [67887] by hyatt@apple.com
  • 4 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46124, add support for logical padding accessors to
RenderBoxModelObject.

Reviewed by Dan Bernstein.

Added fast/blockflow/percentage-padding.html even though it fails, so that when more of layout is patched
we can see it start passing.

WebCore:

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):

  • rendering/RenderBoxModelObject.h:

LayoutTests:

  • fast/blockflow: Added.
  • fast/blockflow/percentage-padding-expected.txt: Added.
  • fast/blockflow/percentage-padding.html: Added.
3:35 PM Changeset in webkit [67886] by hyatt@apple.com
  • 5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46126, add availableLogicalWidth() to RenderBox.

Reviewed by Dan Bernstein.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::availableWidth):
(WebCore::RenderBlock::availableLogicalWidth):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalWidth):

  • rendering/RenderBox.h:

(WebCore::RenderBox::availableWidth):

3:28 PM Changeset in webkit [67885] by kbr@google.com
  • 20 edits in trunk

2010-09-20 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
https://bugs.webkit.org/show_bug.cgi?id=45912

Switched Chromium's compositor to use GraphicsContext3D to issue
its OpenGL rendering calls rather than the Chromium-specific
GLES2Context and command buffer OpenGL implementation.

The in-process software rendering path for GraphicsContext3D does
not yet work with the compositor, at least not on Mac OS X. This
will be worked on in subsequent bugs.

Tested manually with 3D CSS, WebGL and video content on Mac OS X
and Linux. No new tests.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::extractWebGraphicsContext3D): (WebCore::GraphicsContext3D::create):
  • src/GraphicsContext3DInternal.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::gles2Context): (WebKit::WebViewImpl::graphicsContext3D):
  • src/WebViewImpl.h:

2010-09-20 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
https://bugs.webkit.org/show_bug.cgi?id=45912

Switched Chromium's compositor to use GraphicsContext3D to issue
its OpenGL rendering calls rather than the Chromium-specific
GLES2Context and command buffer OpenGL implementation.

The in-process software rendering path for GraphicsContext3D does
not yet work with the compositor, at least not on Mac OS X. This
will be worked on in subsequent bugs.

Tested manually with 3D CSS, WebGL and video content on Mac OS X
and Linux. No new tests.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium): (WebCore::Canvas2DLayerChromium::updateContents):
  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::SharedValues::SharedValues): (WebCore::CanvasLayerChromium::SharedValues::~SharedValues): (WebCore::CanvasLayerChromium::draw):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::SharedValues::~SharedValues): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::loadShader): (WebCore::LayerChromium::SharedValues::SharedValues): (WebCore::LayerChromium::SharedValues::~SharedValues): (WebCore::LayerChromium::createShaderProgram): (WebCore::LayerChromium::layerRendererContext): (WebCore::LayerChromium::drawTexturedQuad): (WebCore::LayerChromium::drawDebugBorder): (WebCore::LayerChromium::drawAsMask): (WebCore::LayerChromium::prepareForDraw):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::SharedValues::context):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::context): (WebCore::LayerRendererChromium::debugGLCall): (WebCore::LayerRendererChromium::useShader): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::updateRootLayerTextureRect): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::finish): (WebCore::LayerRendererChromium::present): (WebCore::LayerRendererChromium::getFramebufferPixels): (WebCore::LayerRendererChromium::createLayerTexture): (WebCore::LayerRendererChromium::drawLayerIntoStencilBuffer): (WebCore::LayerRendererChromium::drawLayersRecursive): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::scissorToRect): (WebCore::LayerRendererChromium::makeContextCurrent): (WebCore::LayerRendererChromium::resizeOnscreenContent): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::createTextureRect): (WebCore::VideoLayerChromium::updateTextureRect):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContents):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::flush): (WebCore::SharedGraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM): (WebCore::SharedGraphicsContext3D::copyTextureToParentTextureCHROMIUM):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
2:35 PM Changeset in webkit [67884] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46119, add logical accessors to RenderStyle. Not used by any RenderObjects yet, so no tests
until then.

Reviewed by Dan Bernstein.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::logicalWidth):
(WebCore::RenderStyle::logicalHeight):
(WebCore::RenderStyle::logicalMinWidth):
(WebCore::RenderStyle::logicalMaxWidth):
(WebCore::RenderStyle::logicalMinHeight):
(WebCore::RenderStyle::logicalMaxHeight):
(WebCore::RenderStyle::borderBeforeWidth):
(WebCore::RenderStyle::borderAfterWidth):
(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginBefore):
(WebCore::RenderStyle::marginAfter):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::paddingBefore):
(WebCore::RenderStyle::paddingAfter):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):

  • rendering/style/RenderStyle.h:
2:07 PM Changeset in webkit [67883] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-20 Eric Carlson <eric.carlson@apple.com>

Rubber-stamped by by Simon Fraser.

video-served-as-text.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=46111

  • platform/win/Skipped: Skip http/tests/media/video-served-as-text.html.
2:03 PM Changeset in webkit [67882] by hyatt@apple.com
  • 8 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46116, implement block-flow-aware logical properties.

Reviewed by Dan Bernstein.

This patch adds all the logical properties from the CSS3 Writing Mode draft for margins, padding, border,
width and height.

Added fast/css/logical-property-resolution.html

WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::resolveToPhysicalProperty):
(WebCore::CSSProperty::resolveDirectionAwareProperty):

  • css/CSSProperty.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

  • fast/css/logical-property-resolution-expected.txt: Added.
  • fast/css/logical-property-resolution.html: Added.
2:00 PM Changeset in webkit [67881] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-20 James Robinson <jamesr@chromium.org>

Fix mis-merge of chromium mac expectations.

  • platform/chromium/test_expectations.txt:
1:49 PM Changeset in webkit [67880] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-09-20 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should check commit-queue+ again just before committing
https://bugs.webkit.org/show_bug.cgi?id=32679

Added a _revalidate_patch check, right before landing.

Since _revalidate_patch passes the patch_id from the work item
back to bugzilla, I had to fix all of the previous queue tests to
use valid attachment ids (that's the majority of this change).

In order to validate that the bug was still open, I had to teach
bugzilla.Bug about open/closed states.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/mocktool.py:
1:21 PM Changeset in webkit [67879] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46114, two tables repaint tests failing on bots.

Reviewed by Beth Dakin.

Patch layoutRows to apply the layout delta when setting a new cell location prior to laying out the cell.

The layout delta is then removed after layout has happened when the repaint check is done. This change
makes cell layout match block child layout, and now the cells have the correct new location up front
when laying out (a necessity for pagination).

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

1:20 PM Changeset in webkit [67878] by commit-queue@webkit.org
  • 4 edits in trunk

2010-09-20 Jacob Dinu <dinu.jacob@nokia.com>

Reviewed by Adam Barth.

When loading a cached page, dispatchDidCommitLoad is called after FrameLoader::open so
that all initialzations are done before calling client dispatchDidCommitLoad to avoid
client from accessing incorrect data.
https://bugs.webkit.org/show_bug.cgi?id=41155

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted):

2010-09-20 Jacob Dinu <dinu.jacob@nokia.com>

Reviewed by Adam Barth.

Added a new qwebpage test for loading a cached page
https://bugs.webkit.org/show_bug.cgi?id=41155

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::loadCachedPage):
1:19 PM Changeset in webkit [67877] by Simon Fraser
  • 4 edits
    2 adds in trunk

2010-09-20 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

REGRESSION: alternating animation direction doesn't work on Windows
https://bugs.webkit.org/show_bug.cgi?id=46017

Animation-direction on Windows was broken because bitfields on
Windows are signed.

Fixed by making m_direction an unsigned in the bitfield, and
casting in the accessor.

Test: animations/animation-direction.html

  • platform/animation/Animation.h: (WebCore::Animation::direction):
1:18 PM WebKit Team edited by mihaip@chromium.org
(diff)
1:09 PM Changeset in webkit [67876] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Unreviewed.

Adding myself as a comitter.

  • Scripts/webkitpy/common/config/committers.py:
1:01 PM Changeset in webkit [67875] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-20 James Robinson <jamesr@chromium.org>

Fix bad merge in chromium test_expectations.txt

  • platform/chromium/test_expectations.txt:
12:59 PM Changeset in webkit [67874] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Don't use bufferIsLargeEnoughToContain for Vectors with variable sized elements
https://bugs.webkit.org/show_bug.cgi?id=46109

Reviewed by Adam Roben.

Add a new VectorArgumentCoder class template, with specializations based on whether the
element is fixed size or not. Then update the ArgumentEncoder<Vector<T>> specialization to choose the
right VectorArgumentCoder specialization. To determine this, we use the "IsArithmetic" type trait,
which holds true for all integer types and all floating point types.

  • Platform/CoreIPC/ArgumentCoders.h:
12:57 PM Changeset in webkit [67873] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-20 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Roll forward Chromium DEPS to pick up WebGraphicsContext3D implementation changes
https://bugs.webkit.org/show_bug.cgi?id=46115

  • DEPS:
12:49 PM CommitterTips edited by mihaip@chromium.org
(diff)
12:40 PM Changeset in webkit [67872] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-17 James Robinson <jamesr@chromium.org>

Reviewed by Andreas Kling

[chromium] Add specific expectations for canvas/philip tests
https://bugs.webkit.org/show_bug.cgi?id=45991

Instead of marking all of canvas/philip and http/tests/canvas/philip/ as
TEXT failures, this marks each test exactly.

  • platform/chromium/test_expectations.txt:
12:32 PM Changeset in webkit [67871] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Two instances of commit-queue try to process the same patch
https://bugs.webkit.org/show_bug.cgi?id=46113

This patch makes next-patch atomic so that the server won't vend the
same patch twice in the same hour.

  • QueueStatusServer/handlers/nextpatch.py:
12:30 PM Changeset in webkit [67870] by Dimitri Glazkov
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

2010-09-20 Dimitri Glazkov <Dimitri Glazkov>

Fix up the goober from http://trac.webkit.org/changeset/67856.

  • platform/chromium-win-xp/css2.1/hindi-spacing-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.checksum: Renamed from LayoutTests/platform/chromium-win-xp/css2.1/hindi-spacing-expected.checksum.
12:29 PM Changeset in webkit [67869] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-20 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Geoffrey Garen.

REGRESSION(67790): jsc tests are failed with YARR interpreter
https://bugs.webkit.org/show_bug.cgi?id=46083

Fix the initializing of the lastSubpatternId member of
parentheses.

  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd):
11:51 AM Changeset in webkit [67868] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Attributes not interpreted correctly if there is a syntax error
https://bugs.webkit.org/show_bug.cgi?id=16254

The underlying bug was fixed by the HTML5 parser, but I don't think we
have a test for this particular tokenization behavior.

  • html5lib/resources/webkit01.dat:
11:31 AM Changeset in webkit [67867] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

2010-09-20 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Bug 46077 - ASSERT failure in YARR JIT

We will currently attempt to loop if there are multiple alternatives, they are all
BOL predicated, and the last alternative is longer then the first - however if all
alternatives are BOL predicated the head of loop label will not have been set, and
we'll try to link a jump to an undefined label. Stop doing so.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateDisjunction):

2010-09-20 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Bug 46077 - ASSERT failure in YARR JIT

We will currently attempt to loop if there are multiple alternatives, they are all
BOL predicated, and the last alternative is longer then the first - however if all
alternatives are BOL predicated the head of loop label will not have been set, and
we'll try to link a jump to an undefined label. Stop doing so.

  • fast/js/regexp-norepeat-expected.txt: Added.
  • fast/js/regexp-norepeat.html: Added.
  • fast/js/script-tests/regexp-norepeat.js: Added.
11:18 AM Changeset in webkit [67866] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some failing animation tests on Windows

The failures are covered by http://webkit.org/b/46017

Rubber-stamped by Simon Fraser.

  • platform/win/Skipped:
11:12 AM Changeset in webkit [67865] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-20 Martin Robinson <mrobinson@igalia.com>

Correct a GTK+ baseline. These issues should hopefully be mitigated
by upcoming font fixes.

  • platform/gtk/fast/events/keydown-1-expected.txt: Updated baseline.
11:10 AM Changeset in webkit [67864] by enrica@apple.com
  • 11 edits
    1 add in trunk

Pasteboard doesn't work in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42317
<rdar://problem/7660537>

Reviewed by Sam Weinig.

WebCore:

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Changed parameter to
be a Vector of RefPtr.

  • page/EditorClient.h:
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::documentFragmentWithRtf): Stylistic changes.

WebKit/mac:

Some changes to fix style inconsistencies.
Added OBJC 2.0 style enumeration.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::userVisibleString):
(createExcludedElementsForAttributedStringConversion):
(WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
a Vector of RefPtr.
(WebEditorClient::setInsertionPasteboard):
(WebEditorClient::pasteboardTypesForSelection):

WebKit2:

Adding support for RTF, RTFD and NSUrl formats on the Mac.
Still missing the selective enabling of the menu entries.

  • WebKit2.xcodeproj/project.pbxproj: Added WebEditorClientMac.mm.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: Removed Mac only methods

that are now in WebEditorClientMac.mm

  • WebProcess/WebCoreSupport/WebEditorClient.h: Fixed style and changed parameter

type in documentFragmentFromAttributedString to be a Vector of RefPtr.

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Added.

All the following methods have been moved from WebEditorClient.cpp.
(WebKit::WebEditorClient::userVisibleString): Added implementation.
(WebKit::createExcludedElementsForAttributedStringConversion): Added.
(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added implementation.
(WebKit::WebEditorClient::setInsertionPasteboard):
(WebKit::WebEditorClient::pasteboardTypesForSelection):
(WebKit::WebEditorClient::uppercaseWord):
(WebKit::WebEditorClient::lowercaseWord):
(WebKit::WebEditorClient::capitalizeWord):
(WebKit::WebEditorClient::showSubstitutionsPanel):
(WebKit::WebEditorClient::substitutionsPanelIsShowing):
(WebKit::WebEditorClient::toggleSmartInsertDelete):
(WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
(WebKit::WebEditorClient::toggleAutomaticQuoteSubstitution):
(WebKit::WebEditorClient::isAutomaticLinkDetectionEnabled):
(WebKit::WebEditorClient::toggleAutomaticLinkDetection):
(WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled):
(WebKit::WebEditorClient::toggleAutomaticDashSubstitution):
(WebKit::WebEditorClient::isAutomaticTextReplacementEnabled):
(WebKit::WebEditorClient::toggleAutomaticTextReplacement):
(WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):
(WebKit::WebEditorClient::toggleAutomaticSpellingCorrection):
(WebKit::WebEditorClient::checkTextOfParagraph):
(WebKit::WebEditorClient::showCorrectionPanel):
(WebKit::WebEditorClient::dismissCorrectionPanel):
(WebKit::WebEditorClient::isShowingCorrectionPanel):

11:07 AM Changeset in webkit [67863] by Patrick Gansterer
  • 1 edit
    2 adds in trunk/WebKit/wince

2010-09-20 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

Add FrameLoaderClientWinCE
https://bugs.webkit.org/show_bug.cgi?id=45682

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: Added.
  • WebCoreSupport/FrameLoaderClientWinCE.h: Added.
10:55 AM Changeset in webkit [67862] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-20 Yong Li <yoli@rim.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=39966
Make compareBorders() a consistent compare function which can beused by qsort().

New test case added: LayoutTests/tables/sort-collapsed-border-styles.html

  • rendering/RenderTableCell.cpp: (WebCore::compareBorders): (WebCore::chooseBorder): (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder): (WebCore::RenderTableCell::collapsedTopBorder): (WebCore::RenderTableCell::collapsedBottomBorder): (WebCore::compareBorderStylesForQSort):
10:50 AM Changeset in webkit [67861] by Adam Roben
  • 6 edits
    2 adds in trunk/WebKitTools

Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows

We were previously trying to use a CFRunLoopTimer, but since Windows
doesn't use CFRunLoop on most threads this doesn't work. Now we use a
Windows-style timer on Windows.

I also replaced all uses of "watchdog" with "watchdog timer".

Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
watchdog timer doesn't work on Windows

Reviewed by Anders Carlsson.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Updated for rename.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed

platform-specific functions.
(WTR::LayoutTestController::LayoutTestController): Added call to
platformInitialize.
(WTR::LayoutTestController::waitUntilDone): Changed to call
initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
right in this function.
(WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
rename.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new

members needed to support the watchdog timer abstraction. Replaced
some "watchdog"s with "watchdog timer".

  • WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:

Added.
(WTR::LayoutTestController::platformInitialize): Does nothing on this
platform.
(WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
from LayoutTestController.cpp and changed to use an early return.
(WTR::waitUntilDoneWatchdogTimerFired): Moved here from
LayoutTestController.cpp.
(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
Moved code here from LayoutTestController::waitUntilDone and changed
to use an early return.

  • WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:

Added.
(WTR::LayoutTestController::platformInitialize): Initialize our
watchdog timer.
(WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
Kills and clears the watchdog timer.
(WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
LayoutTestController member function of the same name.
(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
Added. Sets up the timer if it isn't already set.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added

LayoutTestControllerMac.mm.

  • WebKitTestRunner/win/InjectedBundle.vcproj: Added

LayoutTestControllerWin.cpp.

10:44 AM Changeset in webkit [67860] by mrobinson@webkit.org
  • 4 edits
    1 add in trunk

2010-09-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] fast/forms/listbox-selection.html fails
https://bugs.webkit.org/show_bug.cgi?id=45942

  • platform/gtk/Skipped: Unskip test which is now passing.
  • platform/gtk/fast/events/keydown-1-expected.txt: Added.

2010-09-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] fast/forms/listbox-selection.html fails
https://bugs.webkit.org/show_bug.cgi?id=45942

Use the gdkModifersFromJSValue helper to parse all appropriate modifier
strings in keyDownCallback.

  • DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the modifier parsing logic.
10:26 AM Changeset in webkit [67859] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-09-20 Dimitri Glazkov <Dimitri Glazkov>

Update a win-xp-specific baseline.

  • platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.png: Updated.
10:14 AM Changeset in webkit [67858] by aestes@apple.com
  • 2 edits in trunk/WebKit2

2010-09-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Fix a style issue and add a FIXME to make the AppleConnect plug-in
workaround dependent on site-specific quirks being enabled, which
WebKit2 does not yet support in its WebPreferences implementation.
https://bugs.webkit.org/show_bug.cgi?id=45960

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
9:48 AM Changeset in webkit [67857] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

script element created with html element as parent
https://bugs.webkit.org/show_bug.cgi?id=17023

The underlying bug is fixed by the HTML5 parser. We have lots of tests
for the resulting DOM in this case, but we don't have a test for what
the DOM looks like to a script running inline at that time. Since
that's how the test case attached to the bug was written, it seems
worth adding.

  • fast/parser/parent-of-script-before-head-expected.txt: Added.
  • fast/parser/parent-of-script-before-head.html: Added.
9:20 AM Changeset in webkit [67856] by Dimitri Glazkov
  • 2 edits
    6 moves
    1 add in trunk/LayoutTests

2010-09-20 Dimitri Glazkov <Dimitri Glazkov>

Move a few more xp-specific results to win-xp and clean up test expectations.

  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt.
  • platform/chromium-win-xp/css2.1/hindi-spacing-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-spacing-expected.checksum.
  • platform/chromium-win-xp/css2.1/hindi-spacing-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-spacing-expected.png.
  • platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counter-09-b-expected.checksum.
  • platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.png: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counter-09-b-expected.png.
  • platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counters-09-b-expected.checksum.
  • platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.png: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counters-09-b-expected.png.
  • platform/chromium/test_expectations.txt:
9:18 AM Changeset in webkit [67855] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Export RegExpObject::info from JavaScriptCore

This allows obj->inherits(&RegExpObject::info) to work correctly from
outside JavaScriptCore.dll on Windows.

Fixes <http://webkit.org/b/46098>
fast/loader/stateobjects/pushstate-object-types.html fails on Windows

Reviewed by John Sullivan.

  • runtime/RegExpObject.h: Added JS_EXPORTDATA to the info member, as

we already have for some other classes whose info members have to be
used from outside the DLL.

9:16 AM Changeset in webkit [67854] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-20 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Buildfix for PluginViewWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=46033

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintIntoTransformedContext): (WebCore::PluginView::snapshot):
9:12 AM Changeset in webkit [67853] by hyatt@apple.com
  • 6 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46030, aintitcool.com doesn't paginate correctly when printed.

Reviewed by Sam Weinig.

This happens because the site always has a document width that will exceed the page width.
We incorrectly apply a double scale instead of clipping after the first scale still doesn't fit.
The fix for the issue is to cap the right layout overflow to the page width and to just clip out
any additional excess. This is the code in FrameView.cpp.

This patch also cleans up table cell invalidation to reduce the # of relayouts. This change is not
a correctness fix. It's just performance.

I'm not sure how to write a test for this, since the double scale is an artifact of how WebKit mac calls
back in when really printing.

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::positionNewFloats):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::markForPaginationRelayout):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

9:07 AM BuildingGtk edited by mrobinson@webkit.org
(diff)
8:47 AM Changeset in webkit [67852] by loislo@chromium.org
  • 18 edits in trunk

2010-09-20 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: merge Inspector client runtime events into the serialized inspector state object.

Drive-by rename getBackendSettings -> getInspectorState to better reflect the nature of the data.

https://bugs.webkit.org/show_bug.cgi?id=45974

WebCore:

  • inspector/Inspector.idl:
  • inspector/InspectorClient.h: (WebCore::InspectorClient::updateInspectorStateCookie):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::saveApplicationSettings): (WebCore::InspectorController::getInspectorState): (WebCore::InspectorController::updateInspectorStateCookie): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::getSettings): (WebCore::InspectorController::setMonitoringXHREnabled): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger):
  • inspector/InspectorController.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
  • inspector/front-end/Settings.js: (WebInspector.Settings.initialize):
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState): (WebInspector.doLoadedDone):

WebKit/chromium:

  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::updateInspectorStateCookie):
  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled): (WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
  • src/WebDevToolsAgentImpl.h:

LayoutTests:

  • http/tests/inspector/console-xhr-logging.html:
  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
8:18 AM Changeset in webkit [67851] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION? (r67762): 23 layout tests fail
https://bugs.webkit.org/show_bug.cgi?id=46093

  • platform/qt/Skipped: Skip failing tests until fix.
8:10 AM Changeset in webkit [67850] by Adam Roben
  • 1 edit
    1 delete in trunk/LayoutTests

Remove no-longer-needed Windows-specific results for a Sputnik Array.prototype.splice test

Rubber-stamped by Anders Carlsson.

  • platform/win/fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.12_Array_prototype_splice/S15.4.4.12_A2.1_T3-expected.txt: Removed.
8:08 AM Changeset in webkit [67849] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Add WebKit2 API to load a string as plain text
https://bugs.webkit.org/show_bug.cgi?id=46091

Reviewed by Adam Roben.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadPlainTextString):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadPlainTextString):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadData):
(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::loadPlainTextString):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:
7:56 AM Changeset in webkit [67848] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed, update Qt specific expected result after r67770.

Canvas sizing ignores intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=46024

  • platform/qt/fast/replaced/table-percent-height-expected.txt: Updated.
7:39 AM Changeset in webkit [67847] by krit@webkit.org
  • 55 edits in trunk/WebCore

2010-09-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter cleanup
https://bugs.webkit.org/show_bug.cgi?id=45612


All effect inputs are stored in a Vector in FilterEffect instead of passing them via constructors to every effect type.
This simplifies the primitive subregion logic and centralizes it in determineFilterPrimitiveSubregion.
Just SourceGraphic, SourceAlpha and FETile still calculate filter primitive subregions on
their own. Working on it in a followup patch.
The subregions code is SVG specific and moving this calculation to FilterEffect is an
intermediate step before moving it to RenderSVGResourceFilterPrimitive in a following patch.
The new FilterEffectVector will also make it possible to add code to determine the
smallest used region of an effect and will help save memory and resources in the future.
subRegion got renamed to filterPrimitiveSubregion to match the name scheme. scaledSubRegion got
renamed to repaintRectInLocalCoordinates since this is its proper meaning.
Removed unnecessary member variables and functions from FilterEffect.

No new tests added since the functionality didn't change.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: scaledSubRegion was renamed to repaintRectInLocalCoordinates. (WebCore::GraphicsContext::createShadowMask):
  • platform/graphics/filters/FEBlend.cpp: Removed Filter effect inputs from constructor. (WebCore::FEBlend::FEBlend): (WebCore::FEBlend::create): (WebCore::FEBlend::apply): Call inputFilterEffects to get input filter primitives. (WebCore::FEBlend::externalRepresentation): Call inputFilterEffects to get input filter primitives.
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp: Ditto. (WebCore::FEColorMatrix::FEColorMatrix): (WebCore::FEColorMatrix::create): (WebCore::FEColorMatrix::apply): (WebCore::FEColorMatrix::externalRepresentation):
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp: Ditto. (WebCore::FEComponentTransfer::FEComponentTransfer): (WebCore::FEComponentTransfer::create): (WebCore::FEComponentTransfer::apply): (WebCore::FEComponentTransfer::externalRepresentation):
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp: Ditto. (WebCore::FEComposite::FEComposite): (WebCore::FEComposite::create): (WebCore::FEComposite::apply): (WebCore::FEComposite::externalRepresentation):
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEGaussianBlur.cpp: Ditto. (WebCore::FEGaussianBlur::FEGaussianBlur): (WebCore::FEGaussianBlur::create): (WebCore::FEGaussianBlur::apply): (WebCore::FEGaussianBlur::externalRepresentation):
  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/Filter.h: (WebCore::Filter::determineFilterPrimitiveSubregion): Renamed from calculateEffectSubRegion to match name scheme.
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect): (WebCore::FilterEffect::determineFilterPrimitiveSubregion): The main place for subregion calculation. (WebCore::FilterEffect::calculateDrawingIntRect): Takes repaintRectInLocalCoordinates now. (WebCore::FilterEffect::calculateDrawingRect): ditto. (WebCore::FilterEffect::getEffectContext): Check if ImageBuffer was created.
  • platform/graphics/filters/FilterEffect.h: Changed names to match name scheme. Removed unnecessary member variables and functions.

Seperate SVG specific member variables and functions. Will get removed in followup patches.

(WebCore::FilterEffect::resultImage):
(WebCore::FilterEffect::setEffectBuffer):
(WebCore::FilterEffect::inputEffect):
(WebCore::FilterEffect::inputEffects):
(WebCore::FilterEffect::numberOfinputEffects):
(WebCore::FilterEffect::isAlphaImage):
(WebCore::FilterEffect::setIsAlphaImage):
(WebCore::FilterEffect::repaintRectInLocalCoordinates):
(WebCore::FilterEffect::setRepaintRectInLocalCoordinates):
(WebCore::FilterEffect::isSourceInput):
(WebCore::FilterEffect::hasX):
(WebCore::FilterEffect::setHasX):
(WebCore::FilterEffect::hasY):
(WebCore::FilterEffect::setHasY):
(WebCore::FilterEffect::hasWidth):
(WebCore::FilterEffect::setHasWidth):
(WebCore::FilterEffect::hasHeight):
(WebCore::FilterEffect::setHasHeight):
(WebCore::FilterEffect::filterPrimitiveSubregion):
(WebCore::FilterEffect::setFilterPrimitiveSubregion):
(WebCore::FilterEffect::effectBoundaries):
(WebCore::FilterEffect::setEffectBoundaries):

  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::determineFilterPrimitiveSubregion): Renamed to match name scheme.
  • platform/graphics/filters/SourceAlpha.h: (WebCore::SourceAlpha::isSourceInput):
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::determineFilterPrimitiveSubregion): Ditto.
  • platform/graphics/filters/SourceGraphic.h: (WebCore::SourceGraphic::isSourceInput):
  • rendering/RenderSVGResourceFilter.cpp: Adapt to renames in FilterEffect. (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • svg/SVGFEBlendElement.cpp: Constructor of FEBlend doesn't take input effects. Adding them afterwards. (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEColorMatrixElement.cpp: Ditto. (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEComponentTransferElement.cpp: Ditto. (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFECompositeElement.cpp: Ditto. (WebCore::SVGFECompositeElement::build):
  • svg/SVGFEConvolveMatrixElement.cpp: Ditto. (WebCore::SVGFEConvolveMatrixElement::build):
  • svg/SVGFEDiffuseLightingElement.cpp: Ditto. (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDisplacementMapElement.cpp: Ditto. (WebCore::SVGFEDisplacementMapElement::build):
  • svg/SVGFEGaussianBlurElement.cpp: Ditto. (WebCore::SVGFEGaussianBlurElement::build):
  • svg/SVGFEMergeElement.cpp: Ditto. (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEMorphologyElement.cpp: Ditto. (WebCore::SVGFEMorphologyElement::build):
  • svg/SVGFEOffsetElement.cpp: Ditto. (WebCore::SVGFEOffsetElement::build):
  • svg/SVGFESpecularLightingElement.cpp: Ditto. (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFETileElement.cpp: Ditto. (WebCore::SVGFETileElement::build):
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: Ditto. (WebCore::FEConvolveMatrix::FEConvolveMatrix): (WebCore::FEConvolveMatrix::create): (WebCore::FEConvolveMatrix::apply): (WebCore::FEConvolveMatrix::externalRepresentation):
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto. (WebCore::FEDiffuseLighting::FEDiffuseLighting): (WebCore::FEDiffuseLighting::create): (WebCore::FEDiffuseLighting::externalRepresentation):
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: Ditto. (WebCore::FEDisplacementMap::FEDisplacementMap): (WebCore::FEDisplacementMap::create): (WebCore::FEDisplacementMap::apply): (WebCore::FEDisplacementMap::externalRepresentation):
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp: Ditto. (WebCore::FEFlood::apply):
  • svg/graphics/filters/SVGFEImage.cpp: Ditto. (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFELighting.cpp: Ditto. (WebCore::FELighting::FELighting): (WebCore::FELighting::apply):
  • svg/graphics/filters/SVGFELighting.h:
  • svg/graphics/filters/SVGFEMerge.cpp: Ditto. (WebCore::FEMerge::FEMerge): (WebCore::FEMerge::create): (WebCore::FEMerge::apply): (WebCore::FEMerge::externalRepresentation):
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp: Ditto. (WebCore::FEMorphology::FEMorphology): (WebCore::FEMorphology::create): (WebCore::FEMorphology::apply): (WebCore::FEMorphology::externalRepresentation):
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp: Ditto. (WebCore::FEOffset::FEOffset): (WebCore::FEOffset::create): (WebCore::FEOffset::apply): (WebCore::FEOffset::externalRepresentation):
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto. (WebCore::FESpecularLighting::FESpecularLighting): (WebCore::FESpecularLighting::create): (WebCore::FESpecularLighting::externalRepresentation):
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp: Ditto. (WebCore::FETile::FETile): (WebCore::FETile::create): (WebCore::FETile::determineFilterPrimitiveSubregion): Renamed to match name scheme. (WebCore::FETile::apply): (WebCore::FETile::externalRepresentation):
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFilter.cpp: Renamed itemBox to targetBoundingBox to match name scheme. (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::determineFilterPrimitiveSubregion): Renamed to match name scheme. (WebCore::SVGFilter::create):
  • svg/graphics/filters/SVGFilter.h: (WebCore::SVGFilter::sourceImageRect):
7:28 AM CommitQueue edited by Patrick Gansterer
(diff)
6:23 AM Changeset in webkit [67846] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] Fix forward includes generation for MSVC when sh is in PATH.

Reviewed by Simon Hausmann.

MSVC's nmake isn't affected by having sh in PATH.

  • Api/DerivedSources.pro:
6:13 AM Changeset in webkit [67845] by satish@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-09-20 Satish Sampath <satish@chromium.org>

Unreviewed, updating baselines for a layout test and setting expectations for 3 others.

  • platform/chromium-linux/animations/animation-drt-api-expected.checksum: Added.
  • platform/chromium-linux/animations/animation-drt-api-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:42 AM Changeset in webkit [67844] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-09-20 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: highlight DOM node when hover on link element or DOM breakpoint
https://bugs.webkit.org/show_bug.cgi?id=45897

4:27 AM Changeset in webkit [67843] by satish@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

2010-09-20 Satish Sampath <satish@chromium.org>

Unreviewed, updating baselines for a layout test and adding 5 others to the skip list.

  • platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
  • platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
  • platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
  • platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
  • platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
  • platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:57 AM Changeset in webkit [67842] by Csaba Osztrogonác
  • 19 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r67660.

Paginate and column-break at layout time rather than when painting
https://bugs.webkit.org/show_bug.cgi?id=38402

  • platform/qt/fast/multicol/client-rects-expected.txt:
  • platform/qt/fast/multicol/column-count-with-rules-expected.txt:
  • platform/qt/fast/multicol/float-paginate-expected.txt:
  • platform/qt/fast/multicol/layers-in-multicol-expected.txt:
  • platform/qt/fast/multicol/nested-columns-expected.txt:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/qt/fast/repaint/multicol-repaint-expected.txt:
1:28 AM Changeset in webkit [67841] by pfeldman@chromium.org
  • 5 edits in branches/chromium/517/WebCore

Merge 67709 - 2010-09-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
resource as not cached to InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=45961

There is one path in control flow that leads to resources being
reported as not cached. Patch to follow.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::markResourceAsCached):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::markAsCached): (WebCore::InspectorResource::updateResponse):
  • inspector/InspectorResource.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/3441018

12:10 AM Changeset in webkit [67840] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-20 James Kozianski <koz@chromium.org>

Reviewed by Ojan Vafai.

[chromium] Unskip the canvas philip suite
https://bugs.webkit.org/show_bug.cgi?id=45991

Adds failing mac canvas/philip tests to test_expectations.txt.

  • platform/chromium/test_expectations.txt:

Sep 19, 2010:

11:16 PM Changeset in webkit [67839] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Publish button should actually publish the review comments
https://bugs.webkit.org/show_bug.cgi?id=46074

Instead of showing the confirmation lightbox, the Publish button now
publishes the comments directly. If there's demand for a "Preview"
button, we can find a way to add that feature.

  • code-review.js:
10:29 PM Changeset in webkit [67838] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix windows build.

  • UIProcess/API/C/WKPage.h:
10:23 PM Changeset in webkit [67837] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Attempt to fix Qt build.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::doTextFieldCommandFromEvent):

10:20 PM Changeset in webkit [67836] by weinig@apple.com
  • 5 edits in trunk/WebKit2

Add WebKit2 equivalent of the WebFormDelegate's doCommandBySelector
<rdar://problem/8377088>
https://bugs.webkit.org/show_bug.cgi?id=46073

Reviewed by Anders Carlsson.

Add bundle client to match the behavior of:

  • (BOOL)textField:(DOMHTMLInputElement *)element doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame;
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::shouldPerformActionInTextField):

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::getActionTypeForKeyEvent):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):

9:26 PM Changeset in webkit [67835] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-09-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move reviewtool to action=review
https://bugs.webkit.org/show_bug.cgi?id=46071

This patch removes the old Review Patch screen and moves the new
reviewtool from Pretty Diff to Review Patch.

  • attachment.cgi:
  • code-review.js:
9:06 PM Changeset in webkit [67834] by weinig@apple.com
  • 10 edits in trunk

WebKit2 decidePolicyForNavigationAction should include mouse button information
<rdar://problem/8413165>
https://bugs.webkit.org/show_bug.cgi?id=46060

Reviewed by Anders Carlsson.

WebKit2:

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toRef):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):

  • UIProcess/WebPolicyClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::findMouseEvent):
(WebKit::mouseButtonForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):

8:05 PM Changeset in webkit [67833] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-19 Adam Barth <abarth@webkit.org>

Review tool UI tweak. This patch lengthens the status bubbles so all
the bubble fit (even when they have numbers inside).

  • PrettyPatch/PrettyPatch.rb:
7:41 PM Changeset in webkit [67832] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-19 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Add unit tests for diffs that delete or modify a change log entry
or describe changes that are far apart
https://bugs.webkit.org/show_bug.cgi?id=46046

Add additional unit tests to test change log diffs that contain
deletions or changes that are far apart from each other in the
ChangeLog file.

  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
    • Added the following unit tests: "fixChangeLogPatch: [no change] In-place change." "fixChangeLogPatch: [no change] Remove first entry." "fixChangeLogPatch: [no change] Remove entry in the middle." "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
7:27 PM Changeset in webkit [67831] by abarth@webkit.org
  • 12 edits in trunk

2010-09-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67749.
http://trac.webkit.org/changeset/67749
https://bugs.webkit.org/show_bug.cgi?id=46068

breaking ToT chromium canary build (Requested by shans on
#webkit).

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:
  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:

2010-09-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67749.
http://trac.webkit.org/changeset/67749
https://bugs.webkit.org/show_bug.cgi?id=46068

breaking ToT chromium canary build (Requested by shans on
#webkit).

  • public/WebFrameClient.h:
  • public/WebScriptController.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:
  • src/WebScriptController.cpp: (WebKit::WebScriptController::registerExtension):
7:00 PM Changeset in webkit [67830] by Dimitri Glazkov
  • 1 edit
    16 moves in trunk/LayoutTests

2010-09-19 Dimitri Glazkov <Dimitri Glazkov>

Move win-xp-specific baselines to their proper places.

  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/forms/search-styled-expected.txt.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.checksum.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.txt.
  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.checksum.
  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png.
  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.txt.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.checksum.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.png.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt.
  • platform/chromium-win-xp/fast/text/international/plane2-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.checksum.
  • platform/chromium-win-xp/fast/text/international/plane2-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.png.
  • platform/chromium-win-xp/fast/text/international/plane2-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.txt.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.checksum.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.png.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.txt.
6:59 PM Changeset in webkit [67829] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix pt 2.

6:52 PM Changeset in webkit [67828] by abarth@webkit.org
  • 3 edits
    2 deletes in trunk/LayoutTests

2010-09-19 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] userscripts/user-script-top-frame-only.html has incorrect expectations
https://bugs.webkit.org/show_bug.cgi?id=46064

r62958 added incorrect expectations for this test. Chromium DRT actually
gets this test right if we let it use the base expectations file. Mark
the test as failing with test_shell only.

  • platform/chromium-mac/userscripts/user-script-top-frame-only-expected.txt: Removed.
  • platform/chromium-win/userscripts/user-script-top-frame-only-expected.txt: Removed.
  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
6:43 PM Changeset in webkit [67827] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix pt 1.

6:35 PM Changeset in webkit [67826] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix - implicit double-to-int conversion invalid on 32-bit.

  • runtime/DatePrototype.cpp:

(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncSetYear):

6:23 PM Changeset in webkit [67825] by barraclough@apple.com
  • 12 edits
    3 adds in trunk

Bug 46065 - Unify implementation of ToInt32 and ToUInt32, don't use fmod.

Reviewed by Oliver Hunt.

These methods implement the same conversion (see discussion in the notes
of sections of 9.5 and 9.6 of the spec), only differing in how the result
is interpretted.

JavaScriptCore:

Date prototype is incorrectly using toInt32, and this is causing us to
provide an output value indicating whether the input to ToInt32 was finite
(the corresponding methods on Date are actually spec'ed to use ToInteger,
not ToInt32). This patch partially fixes this in order to remove this
bogus output value, hoewever more work will be require to bring Date
fully up to spec compliance (the constructor is still performing ToInt32
conversions).

(JSC::fillStructuresUsingTimeArgs):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncSetYear):

  • runtime/JSValue.cpp:

(JSC::toInt32):

  • runtime/JSValue.h:

(JSC::toUInt32):
(JSC::JSValue::toInt32):
(JSC::JSValue::toUInt32):

WebCore:

Removing JSValue::toInt32 (since this has weird, non-spec function).
A couple of places in the binding are using this method, so adding
finiteInt32Value to the bindings to maintain current behaviour.

Test: fast/js/toInt32UInt32.html

  • bindings/js/JSDOMBinding.h:

(WebCore::finiteInt32Value):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::add):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:

(WebCore::JSSQLResultSetRowList::item):

  • bindings/js/JSSVGPODListCustom.h:

(WebCore::JSSVGPODListCustom::getItem):
(WebCore::JSSVGPODListCustom::insertItemBefore):
(WebCore::JSSVGPODListCustom::replaceItem):
(WebCore::JSSVGPODListCustom::removeItem):

  • bindings/js/JSSVGPathSegListCustom.cpp:

(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):

LayoutTests:

Add test cases for ToInt32 / ToUInt32 functionality.

  • fast/js/script-tests/toInt32UInt32.js: Added.
  • fast/js/toInt32UInt32-expected.txt: Added.
  • fast/js/toInt32UInt32.html: Added.
4:45 PM Changeset in webkit [67824] by Dimitri Glazkov
  • 1 edit
    2 moves
    2 deletes in trunk/LayoutTests

2010-09-19 Dimitri Glazkov <Dimitri Glazkov>

Fix up expectation sadness I introduced in http://trac.webkit.org/changeset/67822, because no sadness is allowed.

  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win-vista/css2.1/t1202-counter-09-b-checksum.png.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win-vista/css2.1/t1202-counters-09-b-checksum.png.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Removed.
3:46 PM Changeset in webkit [67823] by Dimitri Glazkov
  • 3 edits
    1 add in trunk/LayoutTests

2010-09-19 Dimitri Glazkov <Dimitri Glazkov>

Create one more text baseline for win-vista.

  • platform/chromium-win-vista/fast/forms/search-styled-expected.txt: Added.
  • platform/chromium/drt_expectations.txt: Removed search-styled as it's now passing.
  • platform/chromium/test_expectations.txt: Removed an errant line break.
3:31 PM Changeset in webkit [67822] by Dimitri Glazkov
  • 6 edits
    20 adds
    2 deletes in trunk/LayoutTests

2010-09-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Update win-vista baselines for Chromium to make a few more tests pass.
https://bugs.webkit.org/show_bug.cgi?id=46056

  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-checksum.png: Added.
  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Added.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-checksum.png: Added.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Added.
  • platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/plane2-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/international/plane2-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/plane2-expected.txt: Added.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/chromium-win-vista/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-win-vista/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium/drt_expectations.txt: Removed expectations of failure, also added more info on remaining Windows failures.
3:09 PM Changeset in webkit [67821] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-19 Adam Barth <abarth@webkit.org>

Turns out these still fail.

  • platform/chromium/test_expectations.txt:
2:57 PM Changeset in webkit [67820] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-19 Adam Barth <abarth@webkit.org>

These tests now pass. Go team.

  • platform/chromium/test_expectations.txt:
2:14 PM Changeset in webkit [67819] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] clipBoundingRect() should return rect relevant to current layer
https://bugs.webkit.org/show_bug.cgi?id=46059

r65791 inadvertently changed clipBoundingRect() to always use the GC painter
without checking the TransparencyLayer stack first.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContextPlatformPrivate::clipBoundingRect):
2:10 PM Changeset in webkit [67818] by weinig@apple.com
  • 3 edits in trunk/WebCore

Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054

Reviewed by Anders Carlsson.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
2:08 PM Changeset in webkit [67817] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-19 Adam Barth <abarth@webkit.org>

Also update mac-leopard and mac-tiger.
See https://bugs.webkit.org/show_bug.cgi?id=46042

  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
12:54 PM Changeset in webkit [67816] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-09-19 Patrick Gansterer <paroga@paroga.com>

Unreviewed.

[WINCE] Buildfix for Gradient after r67801.

  • platform/graphics/Gradient.h:
  • platform/graphics/wince/GradientWinCE.cpp: (WebCore::Gradient::getStops):
11:25 AM Changeset in webkit [67815] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

[Qt] Unreviewed buildfix after r67813.

Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054

  • DerivedSources.pro: Add WebCore/generated/JSRange.h to WEBCORE_GENERATED_HEADERS_FOR_WEBKIT2
10:47 AM Changeset in webkit [67814] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

[Qt] Unreviewed buildfix after r67802.

WebKit2: Improve/unify the PageLoadClient interfaces.
https://bugs.webkit.org/show_bug.cgi?id=46043

  • UIProcess/API/qt/ClientImpl.h:
10:40 AM Changeset in webkit [67813] by weinig@apple.com
  • 19 edits
    4 adds
    2 deletes in trunk

Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054

Reviewed by Anders Carlsson.

The new one acts like WKBundleNodeHandleRef and allows for getting a
wrapper in a specific world for the handle.

WebKit2:

  • Shared/APIObject.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetJavaScriptWrapperForRangeForWorld):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundleRange.cpp: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleRange.h: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp: Added.

(WKBundleRangeHandleGetTypeID):

  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.h: Added.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp: Added.

(WebKit::domHandleCache):
(WebKit::InjectedBundleRangeHandle::getOrCreate):
(WebKit::InjectedBundleRangeHandle::create):
(WebKit::InjectedBundleRangeHandle::InjectedBundleRangeHandle):
(WebKit::InjectedBundleRangeHandle::~InjectedBundleRangeHandle):
(WebKit::InjectedBundleRangeHandle::coreRange):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h: Added.

(WebKit::InjectedBundleRangeHandle::type):

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
(WebKit::InjectedBundlePageEditorClient::shouldEndEditing):
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
(WebKit::InjectedBundlePageEditorClient::shouldInsertText):
(WebKit::InjectedBundlePageEditorClient::shouldDeleteRange):
(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange):
(WebKit::InjectedBundlePageEditorClient::shouldApplyStyle):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::jsWrapperForWorld):

  • WebProcess/WebPage/WebFrame.h:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::propertyValue):
(WTR::propertyValueDouble):
(WTR::propertyValueInt):
(WTR::numericWindowPropertyValue):
(WTR::toStr):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
10:37 AM Changeset in webkit [67812] by mitz@apple.com
  • 2 edits in trunk/BugsSite

Fixed a typo.

Reviewed by Anders Carlsson.

  • code-review.js: Changed the label of the OK button from Ok to OK.
6:31 AM Changeset in webkit [67811] by tkent@chromium.org
  • 5 edits in trunk

2010-09-19 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add is<input type>() functions to WebInputElement
https://bugs.webkit.org/show_bug.cgi?id=46035

  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isText): Added. It is used by WebKit/chromium.

2010-09-19 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add is<input type>() functions to WebInputElement
https://bugs.webkit.org/show_bug.cgi?id=46035

We're going to stop exposing HTMLInputElemnt::InputType. So, add
isFoo() functions in order to remove WebInputElement::InputType.

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::isTextField): (WebKit::WebInputElement::isText): (WebKit::WebInputElement::isPasswordField): (WebKit::WebInputElement::isImageButton):
6:30 AM Changeset in webkit [67810] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-19 Kent Tamura <tkent@chromium.org>

Unreviewed. Fix WebGL test regressions by r67809.

  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
5:55 AM Changeset in webkit [67809] by tkent@chromium.org
  • 7 edits
    2 adds in trunk

2010-09-19 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

[DRT/Chromium] Fix a WebSettings handling bug
https://bugs.webkit.org/show_bug.cgi?id=45945

  • platform/chromium/drt_expectations.txt: Remove link-opens-new-window.html, which is fixed by this revision.

2010-09-19 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

[DRT/Chromium] Fix a WebSettings handling bug
https://bugs.webkit.org/show_bug.cgi?id=45945

Before this change, Chromium DRT reset WebSettings for every new
window. It was wrong.
If new window is not the first one, we have to apply the same
settings as the first window. So, we introduce WebPreference to
store the current settings, and apply it to new windows. It's same
as test_shell's behavior.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Use WebPreferences instead of WebSettings. (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::disableImageLoading): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setAllowUniversalAccessFromFileURLs): (LayoutTestController::setAllowFileAccessFromFileURLs): (LayoutTestController::overridePreference): (LayoutTestController::setEditingBehavior):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Use WebPreferences. (TestShell::runFileTest): ditto. (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
  • DumpRenderTree/chromium/TestShell.h: (TestShell::preferences): (TestShell::applyPreferences):
  • DumpRenderTree/chromium/WebPreferences.cpp: Added.
  • DumpRenderTree/chromium/WebPreferences.h: Added.
Note: See TracTimeline for information about the timeline view.