Timeline
Oct 18, 2010:
- 11:54 PM Changeset in webkit [70032] by
-
- 2 edits in trunk/LayoutTests
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed.
Re-enabled editing/execCommand/remove-formatting.html and editing/execCommand/remove-formatting-2.html on Qt platforms.
- platform/qt/Skipped:
- 11:34 PM Changeset in webkit [70031] by
-
- 3 edits2 adds22 deletes in trunk/LayoutTests
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
dump-as-markup conversion: editing/execCommand/remove-formatting.html and remove-formatting-2.html
https://bugs.webkit.org/show_bug.cgi?id=47792
Converted editing/execCommand/remove-formatting.html and remove-formatting-2.html to dump-as-markup tests.
- editing/execCommand/remove-formatting-2-expected.txt: Added.
- editing/execCommand/remove-formatting-2.html:
- editing/execCommand/remove-formatting-expected.txt: Added.
- editing/execCommand/remove-formatting.html:
- platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/remove-formatting-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-2-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-expected.txt: Removed.
- platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/mac-leopard/editing/execCommand/remove-formatting-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
- platform/mac/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-2-expected.txt: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.checksum: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.txt: Removed.
- platform/qt/editing/execCommand/remove-formatting-2-expected.txt: Removed.
- platform/qt/editing/execCommand/remove-formatting-expected.txt: Removed.
- 10:37 PM Changeset in webkit [70030] by
-
- 3 edits in trunk/WebKit/qt
2010-10-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Export QWebPage::ViewportAttributes class.
https://bugs.webkit.org/show_bug.cgi?id=47845
- Api/qwebpage.h:
- symbian/eabi/QtWebKitu.def:
- 10:36 PM Changeset in webkit [70029] by
-
- 2 edits in trunk/WebKitTools
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add Chromium Mac EWS to the list of queues at queues.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=47878
- QueueStatusServer/model/queues.py:
- 10:35 PM Changeset in webkit [70028] by
-
- 6 edits in trunk/WebKitTools
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queues.webkit.org/next_patch is always 404
https://bugs.webkit.org/show_bug.cgi?id=47881
With the addition of the Queue class, I changed most of the
code to lookup WorkItems using get_or_insert with a key_name
instead of WorkItems.all().filter(queue_name=).
Because the new get_or_insert code uses an explicit key_name
(which is obviously different from the previously autogenerated
ones), there were new WorkItem records created for each queue.
However, some parts of the code still use WorkItems.all().filter,
thus some parts were getting the new record and some parts the old record.
The same basic bug was occurring with ActiveWorkItems, because I
changed the key_name for that class as well.
To fix this I've moved more of the code over to using Queue.*work_items.
I've also enabled the datastore_admin (new in GAE 1.3.8) so that
we can go delete the old WorkItems records.
I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).
- QueueStatusServer/app.yaml:
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/handlers/updatestatus.py:
- QueueStatusServer/handlers/updateworkitems.py:
- 10:33 PM Changeset in webkit [70027] by
-
- 3 edits2 adds in trunk
2010-10-18 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Should not save state of a detached form control.
https://bugs.webkit.org/show_bug.cgi?id=47811
- fast/forms/state-save-of-detached-control-expected.txt: Added.
- fast/forms/state-save-of-detached-control.html: Added.
2010-10-18 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Should not save state of a detached form control.
https://bugs.webkit.org/show_bug.cgi?id=47811
Test: fast/forms/state-save-of-detached-control.html
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): If the node is detached, don't save the state.
- 9:55 PM Changeset in webkit [70026] by
-
- 9 edits in trunk
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Bump version numbers for 1.3.5 release.
- configure.ac:
WebCore:
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- GNUmakefile.am: add missing files.
WebKit/gtk:
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- NEWS: update for 1.3.5 release.
- docs/webkitgtk-sections.txt: add new APIs.
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- GNUmakefile.am: add missing file.
- 9:48 PM Changeset in webkit [70025] by
-
- 8 edits2 copies in trunk/WebKitTools
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Correct a bunch of typos in QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=47880
These are all due to our complete lack of unit testing in QueueStatusServer.
I added a couple unit tests to cover a few of these fixes, but most of these
are still only caught by actually running the application.
- QueueStatusServer/handlers/nextpatch.py:
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/handlers/statusbubble_unittest.py: Added.
- QueueStatusServer/handlers/updateworkitems.py:
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queuepropertymixin.py:
- QueueStatusServer/model/queuepropertymixin_unittest.py:
- QueueStatusServer/model/workitems.py:
- QueueStatusServer/model/workitems_unittest.py: Added.
- 9:25 PM Changeset in webkit [70024] by
-
- 2 edits in trunk/WebKitTools
2010-10-18 Adam Barth <abarth@webkit.org>
Disable this test because it's failing on the bots and the authors
aren't around to fix it.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 9:11 PM Changeset in webkit [70023] by
-
- 6 edits in trunk/WebKitTools
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CC authors of flaky tests when the commit-queue hits a flaky test
https://bugs.webkit.org/show_bug.cgi?id=47872
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/net/layouttestresults.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 9:05 PM Changeset in webkit [70022] by
-
- 3 edits in trunk/WebKitTools
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to run a chromium-mac-ews builder
https://bugs.webkit.org/show_bug.cgi?id=47876
Since we can't run Mac OS X in a VM, we need to only run committer patches.
There was a multiple inheritance problem which was holding this patch back,
but I decided to just ignore the problem and go with a functional hack for now.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- 8:22 PM Changeset in webkit [70021] by
-
- 2 edits in trunk/WebKitTools
2010-10-18 Kenneth Russell <kbr@google.com>
Reviewed by Tony Chang.
Regression in run_webkit_tests_unittest from r70017
https://bugs.webkit.org/show_bug.cgi?id=47875
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 7:44 PM Changeset in webkit [70020] by
-
- 6 edits in trunk/WebKitTools
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement webkit-patch suggest-reviewers
https://bugs.webkit.org/show_bug.cgi?id=47866
- Scripts/webkitpy/common/checkout/api.py:
- The main logic. We look at the last five changes to each modified (non-ChangeLog) file and collect up the reviewers of those changes as well as the authors of those changes who are reviewers.
- Scripts/webkitpy/common/checkout/api_unittest.py:
- Test the logic with some fun mocks.
- Scripts/webkitpy/common/checkout/scm.py:
- Fix a bug when you have local git commits.
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Test that the bug is fixed.
- Scripts/webkitpy/tool/commands/queries.py:
- Add the query.
- 7:37 PM Changeset in webkit [70019] by
-
- 9 edits1 copy1 add in trunk/WebKitTools
2010-10-18 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
new-run-webkit-tests produces corrupt PNG baselines on Windows
https://bugs.webkit.org/show_bug.cgi?id=47867
- Scripts/webkitpy/layout_tests/port/base.py:
- 7:33 PM Changeset in webkit [70018] by
-
- 5 edits in trunk
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
REGRESSION: Feedly extension crashes Webkit
https://bugs.webkit.org/show_bug.cgi?id=45811
Make test cover large number of properties/string pairs, at two offsets to get the
new allocation to occur at different locations.
- fast/dom/Window/window-postmessage-clone-expected.txt:
- fast/dom/Window/window-postmessage-clone.html:
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
REGRESSION: Feedly extension crashes Webkit
https://bugs.webkit.org/show_bug.cgi?id=45811
The basic problem was the deserializer was holding a pointer into
the constant pool, but if you were sufficiently unlucky then the
constant pool would be moved while still relying on the pointer,
which leads to badness.
I looked at just making all the sites this could happen extract the
right string/jsstring before any possible allocations, but it seemed
too fragile so i've gone for a forwarding object as the solution.
- bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::CachedStringRef::CachedStringRef): (WebCore::CloneDeserializer::CachedStringRef::operator->): (WebCore::CloneDeserializer::readStringData): (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal): (WebCore::CloneDeserializer::deserialize):
- 7:32 PM Changeset in webkit [70017] by
-
- 2 edits in trunk/WebKitTools
2010-10-18 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
new-run-webkit-tests produces corrupt PNG baselines on Windows
https://bugs.webkit.org/show_bug.cgi?id=47867
- Scripts/webkitpy/layout_tests/port/base.py:
- 7:13 PM Changeset in webkit [70016] by
-
- 8 edits2 copies in trunk/WebKitTools
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Deploy Queue class in more places throughout QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=47855
I also caught two typos from the previous change. Unfortunately
I don't yet know how to unittest request handlers yet.
- QueueStatusServer/handlers/dashboard.py:
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/handlers/updateworkitems.py:
- QueueStatusServer/model/activeworkitems.py:
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queuepropertymixin.py: Added.
- QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
- QueueStatusServer/model/queuestatus.py:
- QueueStatusServer/model/workitems.py:
- 6:59 PM Changeset in webkit [70015] by
-
- 1 edit2 adds in trunk/WebCore
2010-10-18 Chris Rogers <crogers@google.com>
Reviewed by Chris Fleizach.
Add AudioResampler files
https://bugs.webkit.org/show_bug.cgi?id=47623
No new tests since audio API is not yet implemented.
- platform/audio/AudioResampler.cpp: Added. (WebCore::AudioResampler::AudioResampler): (WebCore::AudioResampler::configureChannels): (WebCore::AudioResampler::process): (WebCore::AudioResampler::setRate): (WebCore::AudioResampler::reset):
- platform/audio/AudioResampler.h: Added. (WebCore::AudioResampler::~AudioResampler): (WebCore::AudioResampler::rate):
- 6:38 PM Changeset in webkit [70014] by
-
- 3 edits in trunk/WebKitTools
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
scm.py should be able tell us what revisions made changes to a given file
https://bugs.webkit.org/show_bug.cgi?id=47863
Look again, your SCM.py can now log files.
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- 6:02 PM Changeset in webkit [70013] by
-
- 16 edits1 add in trunk/WebKitTools
2010-10-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
new-run-webkit-tests: clean up the options-parsing code in the port
classes.
This change modifies the Port interface to have a get_option() and
set_option_default() method for accessing the options argument
passed to the constructor. If the constructor is not passed an
options argument, we default to a MockOptions() argument from
mocktool, which has the same semantics we want.
Note that there is a disadvantage to port.get_option('foo') over
port._options.foo, which is that you lose some of the checking
for whether 'foo' is set (typos result in the default value, not
an exception being raised. This is desired in this case, since the
Port class is not allowed to assume that options does have any
particular values set, and so this change ensures that all of
the subclasses are following the same, intended, logic.
Arguably this is the wrong semantics to have, and the Port
classes should be able to assume a default set of
attributes/arguments, but that change will need to wait for a
different CL where we can modify new-run-webkit-tests to pull a
list of arguments from the port factory routines.
Also, add unit tests for webkitpy.tool.mocktool.MockOptions .
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/dryrun.py:
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
- Scripts/webkitpy/tool/mocktool_unittest.py: Added.
- 5:40 PM Changeset in webkit [70012] by
-
- 9 edits in trunk/WebKitTools
2010-10-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Re-submit a revised version of r69638 - enabling new-run-webkit-tests
under cygwin. The initial version had a bug in base:uri_to_test_name
that was causing tests to fail. This version corrects that bug, but
also makes the code safer by calling cygpath more reliably, and
leaving a long-running cygpath process open.
This patch also corrects a couple of minor bugs in http_lock_unittest,
chromium_unittest, and dedpulicate_tests_unittest that showed up
while testing this.
- Scripts/webkitpy/common/system/path.py:
- Scripts/webkitpy/common/system/path_unittest.py:
- Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 5:06 PM Changeset in webkit [70011] by
-
- 2 edits1 add in trunk/LayoutTests
2010-10-18 James Robinson <jamesr@chromium.org>
Update chromium test expectations
- platform/chromium-linux/svg/custom/text-linking-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/svg/custom/text-linking-expected.txt.
- platform/chromium/test_expectations.txt:
- 4:53 PM Changeset in webkit [70010] by
-
- 6 edits in trunk/WebCore
2010-10-18 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Prevent the creation of very large textures for layers by switching
to "large layer" mode when a texture is larger than some fixed reasonable size
(set to 2000 pixels for now).
https://bugs.webkit.org/show_bug.cgi?id=47751
The code also changes the large layer logic to use the current scissor rect used
by the compositor instead of the visible rect to determine how to clip large layers.
This will provide additional texture savings. In addition, the various layer rects
have been converted to use integers instead of floats to preserve uniformity in the code.
Tests: Existing large layer layout tests including huge-layer and huge-layer-img
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect):
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::getDrawRect):
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::drawLayersRecursive): (WebCore::LayerRendererChromium::scissorToRect):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::currentScissorRect):
- 4:38 PM Changeset in webkit [70009] by
-
- 2 edits2 moves1 delete in trunk/LayoutTests
2010-10-18 James Robinson <jamesr@chromium.org>
Move chromium xp specific baselines to right place.
- platform/chromium-win-xp/svg/custom/text-linking-expected.checksum:
- platform/chromium-win-xp/svg/custom/text-linking-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/custom/text-linking-expected.png.
- platform/chromium-win-xp/svg/custom/text-linking-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/custom/text-linking-expected.txt.
- platform/chromium-win/svg/custom/text-linking-expected.checksum: Removed.
- 4:28 PM Changeset in webkit [70008] by
-
- 5 edits in trunk
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: Functions created with the function constructor don't implement strict mode semantics
https://bugs.webkit.org/show_bug.cgi?id=47860
When creating the FunctionExecutable for a new function the function constructor
was always passing false for whether or not a function was strict, rather than
using the information from the freshly parsed function itself.
- runtime/Executable.cpp: (JSC::FunctionExecutable::fromGlobalCode):
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: Functions created with the function constructor don't implement strict mode semantics
https://bugs.webkit.org/show_bug.cgi?id=47860
Test that the function constructor produces correct strict mode functions.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
- 4:21 PM Changeset in webkit [70007] by
-
- 2 edits in trunk/WebKit2
Initialize the API client.
Reviewed by Sam Weinig.
- Shared/APIClient.h:
(WebKit::APIClient::APIClient):
- 4:08 PM Changeset in webkit [70006] by
-
- 11 edits1 add in trunk/WebKitTools
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add Queue class and add minimal unittesting of QueueStatusServer code
https://bugs.webkit.org/show_bug.cgi?id=47847
- QueueStatusServer/handlers/dashboard.py:
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/handlers/updateworkitems.py:
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queues.py:
- QueueStatusServer/model/queues_unittest.py: Added.
- QueueStatusServer/model/svnrevision.py:
- Scripts/test-webkitpy:
- Scripts/webkitpy/test/main.py:
- 3:44 PM Changeset in webkit [70005] by
-
- 2 edits in trunk/LayoutTests
2010-10-18 James Robinson <jamesr@chromium.org>
Mark flaky SVG tests as flaky in chromium test expectations.
- platform/chromium/test_expectations.txt:
- 3:40 PM Changeset in webkit [70004] by
-
- 5 edits in trunk/WebKit2
WebKit2 should handle dismissing the Find overlay on mouse-down
https://bugs.webkit.org/show_bug.cgi?id=47854
Reviewed by John Sullivan.
- WebProcess/WebPage/FindPageOverlay.cpp:
(WebKit::FindPageOverlay::mouseEvent):
Dismiss the find UI on MouseDown.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEvent):
If there's a page overlay, let it have a go at the event.
- 3:29 PM Changeset in webkit [70003] by
-
- 2 edits in trunk/WebCore
2010-10-18 Jia Pu <jpu@apple.com>
Reviewed by Stephanie Lewis.
Correct the description of manual test: autocorrection-cancelled-by-typing-1.html
https://bugs.webkit.org/show_bug.cgi?id=47722
<rdar://problem/8556206>
- manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Update description to match the test content.
- 3:19 PM Changeset in webkit [70002] by
-
- 2 edits in trunk/LayoutTests
2010-10-18 Mihai Parparita <mihaip@chromium.org>
Group Chromium DRT media test failures and add media/video-src.html,
which became flaky around r68970.
- platform/chromium/drt_expectations.txt:
- 3:14 PM Changeset in webkit [70001] by
-
- 5 edits in trunk/WebKit2
Fix clang build.
- UIProcess/API/mac/FindIndicatorWindow.mm:
(-[WebFindIndicatorWindowAnimation _initWithFindIndicatorWindow:WebKit::animationProgressCallback:WebKit::FindIndicatorWindow::animationDidEndCallback:WebKit::FindIndicatorWindow::]):
(WebKit::FindIndicatorWindow::setFindIndicator):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPopupMenuProxy.h:
- WebProcess/WebCoreSupport/WebPopupMenu.h:
- 3:13 PM Changeset in webkit [70000] by
-
- 1 edit in trunk/ChangeLog
70,000!
- 3:11 PM Changeset in webkit [69999] by
-
- 2 edits in trunk/WebKit2
Fix Qt build.
- WebKit2.pro:
- 3:10 PM WebKit2 edited by
- (diff)
- 3:02 PM Changeset in webkit [69998] by
-
- 2 edits in trunk/WebCore
2010-10-18 Martin Robinson <mrobinson@igalia.com>
Build fix for newer versions of GTK+ 2.0. Instead of using GDK_DISPLAY()
use GDK_DRAWABLE_XDISPLAY(gdk_display_get_default()). GDK_DISPLAY() was
recently deprecated and the latter method has been available since GTK+
2.2.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::initXEvent): (WebCore::PluginView::platformGetValue): (WebCore::getVisualAndColormap): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
- 2:55 PM Changeset in webkit [69997] by
-
- 3 edits in trunk/WebKit2
Don't try to change accelerated compositing mode if the web page is closed
https://bugs.webkit.org/show_bug.cgi?id=47852
Reviewed by Simon Fraser.
changeAcceleratedCompositingMode ends up sending a sync message to the UI process which is unnecessary if
the UI process is being torn down.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::changeAcceleratedCompositingMode):
(WebKit::WebPage::close):
- WebProcess/WebPage/WebPage.h:
- 2:53 PM Changeset in webkit [69996] by
-
- 6 edits in trunk
2010-10-18 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Update context attribute conformance test from updated Khronos source.
https://bugs.webkit.org/show_bug.cgi?id=47697
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
- platform/chromium/test_expectations.txt:
2010-10-18 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Turn off antialiasing when using Mesa during testing.
https://bugs.webkit.org/show_bug.cgi?id=47697
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
- 2:44 PM Changeset in webkit [69995] by
-
- 1 edit in branches/chromium/552/WebKit/chromium/src/WebFontImpl.cpp
Merge 69719 - 2010-10-13 Brett Wilson <brettw@chromium.org>
Reviewed by Darin Fisher.
Save and restore the GraphicsContext around setting the clip rect for
drawing text.
https://bugs.webkit.org/show_bug.cgi?id=47634
- src/WebFontImpl.cpp: (WebKit::WebFontImpl::drawText):
- 2:42 PM Changeset in webkit [69994] by
-
- 5 edits in trunk/WebCore
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
elementCannotHaveEndTag should be a member function of MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=47846
Moved elementCannotHaveEndTag into MarkupAccumulator.
No new tests are added since this is a cleanup.
- editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::elementCannotHaveEndTag): Added.
- editing/MarkupAccumulator.h: Added MarkupAccumulator::elementCannotHaveEndTag.
- editing/markup.cpp: Removed elementCannotHaveEndTag.
- editing/markup.h: Removed elementCannotHaveEndTag.
- 2:41 PM Changeset in webkit [69993] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-18 James Robinson <jamesr@chromium.org>
Update the chromium DEPS from 62399 to 62813 to pick up skia fixes
- DEPS:
- 2:28 PM Changeset in webkit [69992] by
-
- 4 edits in trunk/WebKit2
<rdar://problem/8036034>
WebKit2's WebProcess dies immediately on Mac due to DYLD_FRAMEWORK_PATH problem
Reviewed by Sam Weinig.
Pass the path to the WebKit2 framework along to the web process and don't rely on DYLD_FRAMEWORK_PATH being set.
- Shared/mac/CommandLineMac.cpp:
(WebKit::CommandLine::parse):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
- mac/MainMac.cpp:
(main):
- 2:24 PM Changeset in webkit [69991] by
-
- 9 edits3 adds in trunk/WebKit2
Need a WebKit2 equivalent of the WebKit1 WebUserContentURLPattern.
https://bugs.webkit.org/show_bug.cgi?id=47783
Reviewed by Sam Weinig.
- Shared/API/c/WKBase.h:
- Shared/API/c/WKSharedAPICast.h:
- Shared/API/c/WKUserContentURLPattern.cpp: Added.
(WKUserContentURLPatternGetTypeID):
(WKUserContentURLPatternCreate):
(WKUserContentURLPatternMatchesURL):
- Shared/API/c/WKUserContentURLPattern.h: Added.
- Shared/APIObject.h:
- Shared/UserMessageCoders.h:
Use the original pattern string to encode and decode a UserContentURLPattern.
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebUserContentURLPattern.h: Added.
(WebKit::WebUserContentURLPattern::create):
(WebKit::WebUserContentURLPattern::matchesURL):
Use WebCore::UserContentURLPattern::matches.
(WebKit::WebUserContentURLPattern::patternString):
Expose the pattern string used to create the UserContentURLPattern for the purpose of
encoding and decoding.
(WebKit::WebUserContentURLPattern::WebUserContentURLPattern):
(WebKit::WebUserContentURLPattern::type):
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add WKUserContentURLPattern.h/.cpp and WebUserContentURLPattern.h
- win/WebKit2Generated.make:
Copy over WKUsercontentURLPattern into the output directory.
- 2:15 PM Changeset in webkit [69990] by
-
- 4 edits2 adds in trunk
2010-10-18 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Set the right referent sourceURL for the script with force user gesture.
https://bugs.webkit.org/show_bug.cgi?id=37138
Because empty sourceURL indicates running script with force user gesture,
make WebKit use document.url() as referent sourceURL (Since it uses blank
URL instead empty if the input URL is empty) if WebKit isn't running the
script from a hyper-link.
Test: fast/events/popup-blocked-from-window-open.html
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorld):
2010-10-18 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Set the right referent sourceURL for the script with force user gesture.
https://bugs.webkit.org/show_bug.cgi?id=37138
- fast/events/popup-blocked-from-window-open-expected.txt: Added.
- fast/events/popup-blocked-from-window-open.html: Added.
- 2:12 PM Changeset in webkit [69989] by
-
- 15 edits6 adds in trunk/LayoutTests
2010-10-18 James Robinson <jamesr@chromium.org>
Update chromium expectations and baselines.
- platform/chromium/test_expectations.txt:
- 12:59 PM Changeset in webkit [69988] by
-
- 2 edits in trunk/WebCore
- dom/Node.h: Fix ancient typo in just-modified comment.
- 12:52 PM Changeset in webkit [69987] by
-
- 10 edits in trunk/WebCore
2010-10-18 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov.
Remove some functions from class Node and make a few others non-virtual
https://bugs.webkit.org/show_bug.cgi?id=47735
Refactoring. No new tests.
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Added a FIXME about the use of the virtual ownerDocument function.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Removed the unused return value.
- dom/ContainerNode.h: Made insertBefore, replaceChild, removeChild, and appendChild non-virtual for clarity and performance. Made removeChildren non-virtual and removed its return value. Moved the inline Node functions that call through to ContainerNode into this file since the old way involved an extra level of inline function but otherwise had no advantages.
- dom/Element.h: Moved isMathMLElement here because there is no call site that needs to call it on a Node*. We can always move it back if we need to, but it's better to have less in the Node class.
- dom/Node.cpp: (WebCore::Node::insertBefore): Added an isContainerNode check so this can be non-virtual. There are very few callers who call this function on Node. If we want to optimize them further we can make the isContainerNode check inline in the future. (WebCore::Node::replaceChild): Ditto. (WebCore::Node::removeChild): Ditto. (WebCore::Node::appendChild): Ditto. (WebCore::Node::remove): Removed unneeded ref/unref because ContainerNode::removeChild already does this. (WebCore::Node::createRendererIfNeeded): Removed #if around call to childShouldCreateRenderer since it's needed even without SVG and XHTMLMP.
- dom/Node.h: Moved definitions of inline functions that depend on ContainerNode to the ContainerNode.h header. They already required inclusion of that header, so there is no functional change. Made insertBefore, replaceChild, removeChild, and appendChild non-virtual. There are very few callers of these functions on this class. Moved isMathMLElement to Element. Added a FIXME about the name of eventAncestors. Fixed comment formatting. Eliminated unused isEditableBlock function. Moved the body of the enclosingInlineElement function to the editing file that was the only call site. Removed the previousEditable and nextEditable functions, incorporating their bodies into the one place they were called. Took the childShouldCreateRenderer function out of #if since it's now used by the implementation of the <noscript> element.
- dom/Position.cpp: (WebCore::nextRenderedEditable): Rewrote the function to use nextLeafNode instead of nextEditable. (WebCore::previousRenderedEditable): Rewrote the function to use previousLeafNode instead of previousEditable.
- editing/ReplaceSelectionCommand.cpp: (WebCore::enclosingInline): Moved function here from the Node class. Also fixed an incorrect cast this function did, which assumed the function result was always an element, which the function does not guarantee. (WebCore::ReplaceSelectionCommand::doApply): Call the function above.
- history/HistoryItem.cpp: Added include of MathExtras.h.
- 12:48 PM Changeset in webkit [69986] by
-
- 2 edits in trunk/WebKitTools
Fix build.
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventCarbon):
- 12:46 PM Changeset in webkit [69985] by
-
- 2 edits in trunk/WebKit2
Fix build.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformSetFocus):
- 12:33 PM Changeset in webkit [69984] by
-
- 3 edits3 adds in trunk
2010-10-18 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Darin Adler.
Missing support for document.createEvent("OrientationEvent")
https://bugs.webkit.org/show_bug.cgi?id=32492
Add support for document.createEvent("OrientationEvent") to help unit testing of
onOrientationChange event.
- fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt: Added.
- fast/dom/DeviceOrientation/create-event-onorientationchange.html: Added.
- fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js: Added.
2010-10-18 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Darin Adler.
Missing support for document.createEvent("OrientationEvent")
https://bugs.webkit.org/show_bug.cgi?id=32492
Add support for document.createEvent("OrientationEvent") to help unit testing of
onOrientationChange event.
Test: fast/dom/DeviceOrientation/create-event-onorientationchange.html
- dom/Document.cpp: (WebCore::Document::createEvent):
- 12:15 PM Changeset in webkit [69983] by
-
- 9 edits in trunk
2010-10-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829
Add tests for out of range behavior here since IndexedDB is the only user
of DOMStringList.
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
2010-10-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829
When item() returns a null string, it needs to be passed to JS as
null. The indexed getter will then magically do the right thing.
So all that's left is having DOMStringList::item() return null when
the index is out of bounds.
- dom/DOMStringList.cpp: (WebCore::DOMStringList::item):
- dom/DOMStringList.h:
- dom/DOMStringList.idl:
- 12:14 PM Changeset in webkit [69982] by
-
- 4 edits3 adds33 deletes in trunk/LayoutTests
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
dump-as-markup conversion: editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html
https://bugs.webkit.org/show_bug.cgi?id=47784
Converted editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html to dump-as-markup tests.
- editing/execCommand/4920742-1-expected.txt: Added.
- editing/execCommand/4920742-1.html:
- editing/execCommand/5049671-expected.txt: Added.
- editing/execCommand/5049671.html:
- editing/execCommand/5573879-expected.txt: Added.
- editing/execCommand/5573879.html:
- platform/chromium-linux/editing/execCommand/4920742-1-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/4920742-1-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/5049671-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/5049671-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/5573879-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/5573879-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4920742-1-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/4920742-1-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4920742-1-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/5049671-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/5049671-expected.png: Removed.
- platform/chromium-win/editing/execCommand/5049671-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/5573879-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/5573879-expected.png: Removed.
- platform/chromium-win/editing/execCommand/5573879-expected.txt: Removed.
- platform/gtk/editing/execCommand/4920742-1-expected.txt: Removed.
- platform/gtk/editing/execCommand/5049671-expected.txt: Removed.
- platform/gtk/editing/execCommand/5573879-expected.txt: Removed.
- platform/mac-leopard/editing/execCommand/4920742-1-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/4920742-1-expected.png: Removed.
- platform/mac-leopard/editing/execCommand/5049671-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/5049671-expected.png: Removed.
- platform/mac/editing/execCommand/4920742-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/4920742-1-expected.png: Removed.
- platform/mac/editing/execCommand/4920742-1-expected.txt: Removed.
- platform/mac/editing/execCommand/5049671-expected.checksum: Removed.
- platform/mac/editing/execCommand/5049671-expected.png: Removed.
- platform/mac/editing/execCommand/5049671-expected.txt: Removed.
- platform/mac/editing/execCommand/5573879-expected.checksum: Removed.
- platform/mac/editing/execCommand/5573879-expected.png: Removed.
- platform/mac/editing/execCommand/5573879-expected.txt: Removed.
- platform/qt/editing/execCommand/4920742-1-expected.txt: Removed.
- platform/qt/editing/execCommand/5049671-expected.txt: Removed.
- 12:13 PM Changeset in webkit [69981] by
-
- 3 edits in trunk/WebCore
[Qt] Implement Accelerated Composition for NPAPI Plugins.
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=35524
- plugins/PluginView.h:
(WebCore::PluginView::platformLayer):
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::paint):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::invalidateRegion):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformLayer):
- 11:54 AM Changeset in webkit [69980] by
-
- 4 edits3 adds34 deletes in trunk/LayoutTests
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
dump-as-markup conversion: editing/execCommand/4786404-1.html, 4786404-2.html, 4920488.html
https://bugs.webkit.org/show_bug.cgi?id=47782
Converted editing/execCommand/4786404-1.html, 4786404-2.html, 4920488.html to dump-as-markup tests.
- editing/execCommand/4786404-1-expected.txt: Added.
- editing/execCommand/4786404-1.html:
- editing/execCommand/4786404-2-expected.txt: Added.
- editing/execCommand/4786404-2.html:
- editing/execCommand/4920488-expected.txt: Added.
- editing/execCommand/4920488.html:
- platform/chromium-linux/editing/execCommand/4786404-1-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/4786404-1-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/4786404-2-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/4786404-2-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/4920488-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/4920488-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4786404-1-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/4786404-1-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4786404-1-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/4786404-2-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/4786404-2-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4786404-2-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/4920488-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/4920488-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4920488-expected.txt: Removed.
- platform/gtk/editing/execCommand/4786404-1-expected.txt: Removed.
- platform/gtk/editing/execCommand/4786404-2-expected.txt: Removed.
- platform/gtk/editing/execCommand/4920488-expected.txt: Removed.
- platform/mac-leopard/editing/execCommand/4786404-2-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/4786404-2-expected.png: Removed.
- platform/mac-leopard/editing/execCommand/4920488-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/4920488-expected.png: Removed.
- platform/mac/editing/execCommand/4786404-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/4786404-1-expected.png: Removed.
- platform/mac/editing/execCommand/4786404-1-expected.txt: Removed.
- platform/mac/editing/execCommand/4786404-2-expected.checksum: Removed.
- platform/mac/editing/execCommand/4786404-2-expected.png: Removed.
- platform/mac/editing/execCommand/4786404-2-expected.txt: Removed.
- platform/mac/editing/execCommand/4920488-expected.checksum: Removed.
- platform/mac/editing/execCommand/4920488-expected.png: Removed.
- platform/mac/editing/execCommand/4920488-expected.txt: Removed.
- platform/qt/editing/execCommand/4786404-1-expected.txt: Removed.
- platform/qt/editing/execCommand/4786404-2-expected.txt: Removed.
- platform/qt/editing/execCommand/4920488-expected.txt: Removed.
- 11:54 AM Changeset in webkit [69979] by
-
- 7 edits in trunk
2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Eric Seidel.
Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.
- bridge/npapi.h:
- plugins/mac/PluginViewMac.mm: (WebCore::PluginView::setFocus): (WebCore::PluginView::handleMouseEvent):
2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Eric Seidel.
Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.
- Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::mouseEntered): (WebNetscapePluginEventHandlerCarbon::mouseExited): (WebNetscapePluginEventHandlerCarbon::mouseMoved): (WebNetscapePluginEventHandlerCarbon::focusChanged):
2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Eric Seidel.
Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventCarbon):
- 11:46 AM Changeset in webkit [69978] by
-
- 13 edits in trunk/WebKit2
Add matchCountDidChange callback
https://bugs.webkit.org/show_bug.cgi?id=47840
Reviewed by Darin Adler.
- UIProcess/API/C/WKPage.h:
Add matchCountDidChange WKPageFindClient callback.
- UIProcess/WebFindClient.cpp:
(WebKit::WebFindClient::matchCountDidChange):
Call the WKPageFindClient callback.
- UIProcess/WebPageProxy.messages.in:
Add MatchCountDidChange message.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):
Move code here from WebPage.
(WebKit::FindController::findString):
Send the MatchCountDidChange message.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::countStringMatches):
Move this code over to FindController.
- 11:32 AM Changeset in webkit [69977] by
-
- 5 edits in trunk
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Strict mode: |this| should be undefined if it is not explicitly provided
https://bugs.webkit.org/show_bug.cgi?id=47833
To make strict mode behave correctly we want to pass undefined instead of null
as the default this value. This has no impact on behaviour outside of strict
mode as both values are replaced with the global object if necessary.
- bytecompiler/NodesCodegen.cpp: (JSC::FunctionCallValueNode::emitBytecode): (JSC::FunctionCallResolveNode::emitBytecode): (JSC::CallFunctionCallDotNode::emitBytecode): (JSC::ApplyFunctionCallDotNode::emitBytecode):
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Strict mode: |this| should be undefined if it is not explicitly provided
https://bugs.webkit.org/show_bug.cgi?id=47833
Add tests to ensure that |this| is undefined rather than null when it has
not been explicitly provided.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
- 11:17 AM Changeset in webkit [69976] by
-
- 2 edits in trunk/WebCore
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: comment out resource manager instantiation on front-end side.
https://bugs.webkit.org/show_bug.cgi?id=47823
- inspector/front-end/inspector.js:
- 11:08 AM Changeset in webkit [69975] by
-
- 2 edits in trunk/LayoutTests
2010-10-18 Robert Hogan <robert@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
Unskip:
http/tests/navigation/no-referrer-reset.html
http/tests/navigation/no-referrer-target-blank.html
These tests now pass.
- platform/qt/Skipped:
- 11:04 AM Changeset in webkit [69974] by
-
- 8 edits in trunk
2010-10-18 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
The description parameter of IDBFactory::open() should be mandatory.
https://bugs.webkit.org/show_bug.cgi?id=47835
- storage/indexeddb/basics-expected.txt:
- storage/indexeddb/basics.html:
2010-10-18 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
The description parameter of IDBFactory::open() should be mandatory.
https://bugs.webkit.org/show_bug.cgi?id=47835
Makes the description parameter mandatory, as per the IndexedDatabase specification.
Modified existing tests to cover this change.
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::extractMetaData): (WebCore::setMetaData): (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
- storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
- storage/IDBFactory.h:
- storage/IDBFactory.idl:
- 11:02 AM Changeset in webkit [69973] by
-
- 4 edits in trunk/WebKit2
Use nullptr instead of 0.
Reviewed by Darin Adler.
- UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::closeWindow):
- UIProcess/API/mac/WKView.mm:
(-[WKView renewGState]):
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::removePluginProxy):
- 10:41 AM Changeset in webkit [69972] by
-
- 2 edits in trunk/WebCore
2010-10-18 Xiaomei Ji <xji@chromium.org>
Reviewed by David Levin.
Code cleanup: Move most function members in TextRunWorker from inlined.
https://bugs.webkit.org/show_bug.cgi?id=47732
No functionality change, so no tests added.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::setWordSpacingAdjustment): (WebCore::TextRunWalker::setLetterSpacingAdjustment): (WebCore::TextRunWalker::setXOffsetToZero): (WebCore::TextRunWalker::rtl): (WebCore::TextRunWalker::glyphs): (WebCore::TextRunWalker::length): (WebCore::TextRunWalker::xPositions): (WebCore::TextRunWalker::advances): (WebCore::TextRunWalker::width): (WebCore::TextRunWalker::logClusters): (WebCore::TextRunWalker::numCodePoints): (WebCore::TextRunWalker::fontPlatformDataForScriptRun): (WebCore::TextRunWalker::isCodepointSpace): (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::isWordBreak): (WebCore::TextRunWalker::setPadding): (WebCore::TextRunWalker::reset): (WebCore::TextRunWalker::setBackwardsIteration): (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::widthOfFullRun): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setupFontForScriptRun): (WebCore::TextRunWalker::allocHarfbuzzFont): (WebCore::TextRunWalker::deleteGlyphArrays): (WebCore::TextRunWalker::createGlyphArrays): (WebCore::TextRunWalker::resetGlyphArrays): (WebCore::TextRunWalker::shapeGlyphs): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::TextRunWalker::mirrorCharacters):
- 10:27 AM Changeset in webkit [69971] by
-
- 3 edits in trunk/WebCore
2010-10-18 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] AC rendering bugs
There were a few missing connections in Qt AC between GraphicsLayer and plugins, like changing the plugin's geometry to the layer's
contentsRect, and making sure media layers handle ParentChange events and setContentsNeedsDisplay. Now media layers behave correctly.
No new tests. This is in preparation for fixing AC+plugins, which already has tests that don't work yet with Qt.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsNeedsDisplay):
- platform/graphics/qt/GraphicsLayerQt.h:
- 10:23 AM Changeset in webkit [69970] by
-
- 10 edits1 add in trunk/JavaScriptCore
2010-10-18 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Make a nullptr that works with OwnPtr and RefPtr
https://bugs.webkit.org/show_bug.cgi?id=47756
- JavaScriptCore.xcodeproj/project.pbxproj: Added NullPtr.h.
- wtf/NullPtr.h: Added.
- wtf/OwnArrayPtr.h: Add an overload of = taking nullptr.
- wtf/OwnPtr.h: Ditto.
- wtf/PassOwnArrayPtr.h: Ditto.
- wtf/PassOwnPtr.h: Ditto.
- wtf/PassRefPtr.h: Ditto.
- wtf/RefPtr.h: Ditto.
- wtf/RetainPtr.h: Ditto.
- 10:21 AM Changeset in webkit [69969] by
-
- 4 edits in trunk/WebKit
2010-10-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: disable private browsing for inspector
https://bugs.webkit.org/show_bug.cgi?id=47827
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]):
2010-10-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: disable private browsing for inspector
https://bugs.webkit.org/show_bug.cgi?id=47827
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::openInspectorFrontend):
- 10:08 AM Changeset in webkit [69968] by
-
- 15 edits1 add in trunk
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorClient.cpp: Added. (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
- inspector/InspectorClient.h: (WebCore::InspectorClient::InspectorClient):
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224
- WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::sendMessageToFrontend):
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::sendMessageToFrontend):
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::sendMessageToFrontend):
- 10:07 AM Changeset in webkit [69967] by
-
- 2 edits in trunk/LayoutTests
2010-10-18 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skip test failing in the bots, bug opened to check the
problem: https://bugs.webkit.org/show_bug.cgi?id=47832
- platform/gtk/Skipped:
- 9:48 AM Changeset in webkit [69966] by
-
- 3 edits in trunk/WebKit/qt
2010-10-18 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] AC rendering bugs
This fixes a regression that was introduced by making scrolling in accelerated compositing automatic,
which made our explicit function to scroll the compositing layers superfluous, making the scrolling behavior
when graphics layers are present incorrect. The fix simply removes those redundant functions.
- WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::scroll): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
- WebCoreSupport/PageClientQt.h:
- 9:47 AM Changeset in webkit [69965] by
-
- 5 edits in trunk
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: JIT doesn't check for |this| being an immediate before dereferencing
https://bugs.webkit.org/show_bug.cgi?id=47826
There's no guarantee that |this| will be a cell in a strict mode function, so
don't claim that it is.
- bytecode/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: JIT doesn't check for |this| being an immediate before dereferencing
https://bugs.webkit.org/show_bug.cgi?id=47826
Add tests for accessing properties on |this| when |this| is not an object
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js: (testThisDotAccess): (testThisBracketAccess):
- 9:35 AM Changeset in webkit [69964] by
-
- 3 edits1 delete in trunk/WebCore
2010-10-18 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBKeyTree.h is no longer used.
https://bugs.webkit.org/show_bug.cgi?id=47824
No new tests, just removing unused files.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- storage/IDBKeyTree.h: Removed.
- 9:30 AM Changeset in webkit [69963] by
-
- 5 edits in trunk
2010-10-18 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Oliver Hunt.
if (0) throw "x" ; else { } throws parse error after r69906
https://bugs.webkit.org/show_bug.cgi?id=47807
r69906 introduced a bug: the semicolon is not parsed after a throw
expression anymore. Thus, the semicolon terminates the "if" parsing
in the example above, and the else token results a parse error.
- parser/JSParser.cpp: (JSC::JSParser::parseThrowStatement):
2010-10-18 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Oliver Hunt.
if (0) throw "x" ; else { } throws parse error after r69906
https://bugs.webkit.org/show_bug.cgi?id=47807
Adding a new test case to break-ASI.js
- fast/js/break-ASI-expected.txt:
- fast/js/script-tests/break-ASI.js:
- 9:16 AM Changeset in webkit [69962] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix the build with MSVC.
Reviewed by nobody, build fix.
Splitting the condition in two to prevent qmake parentheses issues.
- Api/DerivedSources.pro:
- 8:41 AM Changeset in webkit [69961] by
-
- 2 edits in trunk/WebKit/qt
2010-10-18 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Antonio Gomes.
[QT] Unable to load pages on QtTestBrowser after canceling a page load.
https://bugs.webkit.org/show_bug.cgi?id=43827
- Api/qwebpage.cpp: (QWebPage::triggerAction):
- 8:39 AM Changeset in webkit [69960] by
-
- 2 edits in trunk/WebCore
2010-10-18 Andreas Kling <kling@webkit.org>
Unreviewed buildfix for Qt + V8.
Add missing <wtf/text/CString.h> include.
- inspector/InspectorInstrumentation.cpp:
- 8:24 AM Changeset in webkit [69959] by
-
- 2 edits in trunk/WebCore
2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: toJSON serialization for Numbers should be fixed.
DecimalNumber is used instead of printf.
- inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
- 6:29 AM Changeset in webkit [69958] by
-
- 1 edit107 adds in trunk/LayoutTests
[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.
- platform/qt/editing/input: Added.
- platform/qt/editing/input/emacs-ctrl-o-expected.checksum: Added.
- platform/qt/editing/input/emacs-ctrl-o-expected.png: Added.
- platform/qt/editing/input/emacs-ctrl-o-expected.txt: Added.
- platform/qt/fast/blockflow: Added.
- platform/qt/fast/blockflow/block-level-images-expected.checksum: Added.
- platform/qt/fast/blockflow/block-level-images-expected.png: Added.
- platform/qt/fast/blockflow/block-level-images-expected.txt: Added.
- platform/qt/fast/blockflow/fieldsets-expected.checksum: Added.
- platform/qt/fast/blockflow/fieldsets-expected.png: Added.
- platform/qt/fast/blockflow/fieldsets-expected.txt: Added.
- platform/qt/fast/blockflow/floats-in-block-layout-expected.checksum: Added.
- platform/qt/fast/blockflow/floats-in-block-layout-expected.png: Added.
- platform/qt/fast/blockflow/floats-in-block-layout-expected.txt: Added.
- platform/qt/fast/blockflow/inline-direction-positioning-expected.checksum: Added.
- platform/qt/fast/blockflow/inline-direction-positioning-expected.png: Added.
- platform/qt/fast/blockflow/inline-direction-positioning-expected.txt: Added.
- platform/qt/fast/blockflow/margin-collapse-expected.checksum: Added.
- platform/qt/fast/blockflow/margin-collapse-expected.png: Added.
- platform/qt/fast/blockflow/margin-collapse-expected.txt: Added.
- platform/qt/fast/blockflow/root-lr-basic-expected.checksum: Added.
- platform/qt/fast/blockflow/root-lr-basic-expected.png: Added.
- platform/qt/fast/blockflow/root-lr-basic-expected.txt: Added.
- platform/qt/fast/blockflow/self-collapsing-block-expected.checksum: Added.
- platform/qt/fast/blockflow/self-collapsing-block-expected.png: Added.
- platform/qt/fast/blockflow/self-collapsing-block-expected.txt: Added.
- platform/qt/fast/css/first-letter-punctuation-expected.checksum: Added.
- platform/qt/fast/css/first-letter-punctuation-expected.png: Added.
- platform/qt/fast/css/first-letter-punctuation-expected.txt: Added.
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
- platform/qt/fast/css/rtl-to-viewport-expected.checksum: Added.
- platform/qt/fast/css/rtl-to-viewport-expected.png: Added.
- platform/qt/fast/css/rtl-to-viewport-expected.txt: Added.
- platform/qt/fast/forms/input-button-sizes-expected.checksum: Added.
- platform/qt/fast/forms/input-button-sizes-expected.png: Added.
- platform/qt/fast/forms/input-button-sizes-expected.txt: Added.
- platform/qt/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
- platform/qt/fast/forms/input-placeholder-focus-twice-expected.png: Added.
- platform/qt/fast/forms/input-placeholder-focus-twice-expected.txt: Added.
- platform/qt/fast/images/gif-large-checkerboard-expected.checksum: Added.
- platform/qt/fast/images/gif-large-checkerboard-expected.png: Added.
- platform/qt/fast/images/gif-large-checkerboard-expected.txt: Added.
- platform/qt/fast/multicol/border-padding-pagination-expected.checksum: Added.
- platform/qt/fast/multicol/border-padding-pagination-expected.png: Added.
- platform/qt/fast/multicol/border-padding-pagination-expected.txt: Added.
- platform/qt/fast/multicol/column-break-with-balancing-expected.checksum: Added.
- platform/qt/fast/multicol/column-break-with-balancing-expected.png: Added.
- platform/qt/fast/multicol/column-break-with-balancing-expected.txt: Added.
- platform/qt/fast/multicol/float-paginate-complex-expected.checksum: Added.
- platform/qt/fast/multicol/float-paginate-complex-expected.png: Added.
- platform/qt/fast/multicol/float-paginate-complex-expected.txt: Added.
- platform/qt/fast/multicol/margin-collapse-expected.checksum: Added.
- platform/qt/fast/multicol/margin-collapse-expected.png: Added.
- platform/qt/fast/multicol/margin-collapse-expected.txt: Added.
- platform/qt/fast/multicol/shadow-breaking-expected.checksum: Added.
- platform/qt/fast/multicol/shadow-breaking-expected.png: Added.
- platform/qt/fast/multicol/shadow-breaking-expected.txt: Added.
- platform/qt/fast/multicol/table-margin-collapse-expected.checksum: Added.
- platform/qt/fast/multicol/table-margin-collapse-expected.png: Added.
- platform/qt/fast/multicol/table-margin-collapse-expected.txt: Added.
- platform/qt/fast/multicol/table-vertical-align-expected.checksum: Added.
- platform/qt/fast/multicol/table-vertical-align-expected.png: Added.
- platform/qt/fast/multicol/table-vertical-align-expected.txt: Added.
- platform/qt/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
- platform/qt/fast/multicol/unsplittable-inline-block-expected.png: Added.
- platform/qt/fast/multicol/unsplittable-inline-block-expected.txt: Added.
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
- platform/qt/scrollbars: Added.
- platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
- platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
- platform/qt/svg/custom/fill-opacity-hsl-expected.checksum: Added.
- platform/qt/svg/custom/fill-opacity-hsl-expected.png: Added.
- platform/qt/svg/custom/fill-opacity-hsl-expected.txt: Added.
- platform/qt/svg/custom/fill-opacity-rgba-expected.checksum: Added.
- platform/qt/svg/custom/fill-opacity-rgba-expected.png: Added.
- platform/qt/svg/custom/fill-opacity-rgba-expected.txt: Added.
- platform/qt/svg/custom/recursive-filter-expected.checksum: Added.
- platform/qt/svg/custom/recursive-filter-expected.png: Added.
- platform/qt/svg/custom/recursive-filter-expected.txt: Added.
- platform/qt/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
- platform/qt/svg/custom/repaint-on-constant-size-change-expected.png: Added.
- platform/qt/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
- platform/qt/svg/custom/text-rotation-expected.checksum: Added.
- platform/qt/svg/custom/text-rotation-expected.png: Added.
- platform/qt/svg/custom/text-rotation-expected.txt: Added.
- platform/qt/svg/custom/text-x-dy-lists-expected.checksum: Added.
- platform/qt/svg/custom/text-x-dy-lists-expected.png: Added.
- platform/qt/svg/custom/text-x-dy-lists-expected.txt: Added.
- platform/qt/svg/in-html/by-reference-expected.txt: Added.
- 6:20 AM Changeset in webkit [69957] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-18 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Andreas Kling.
Remove some unnecessary lines of code from Parser.cpp
https://bugs.webkit.org/show_bug.cgi?id=47816
- parser/Parser.cpp:
- 5:46 AM Changeset in webkit [69956] by
-
- 2 edits in trunk/WebCore
2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION] Inspector window visible during run-webkit-tests.
The initial state of an inspector setting should stay untouched
if the profile has no value for it.
- inspector/InspectorState.cpp: (WebCore::InspectorState::loadFromSettings):
- 5:43 AM Styling Form Controls edited by
- (diff)
- 5:42 AM Styling Form Controls edited by
- (diff)
- 5:41 AM Styling Form Controls edited by
- (diff)
- 5:32 AM Styling Form Controls created by
- 5:29 AM Changeset in webkit [69955] by
-
- 2 edits in trunk/WebKitTools
2010-10-18 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
check-webkit-style should treat the GObject binding directory like other GTK directories.
https://bugs.webkit.org/show_bug.cgi?id=47796
- Scripts/webkitpy/style/checker.py: Added the GObject binding directory with the other gtk directories (and fixed typo).
- 5:24 AM WikiStart edited by
- (diff)
- 5:13 AM Changeset in webkit [69954] by
-
- 2 edits in trunk/WebCore
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: tab headers on resource panel are 1px off on Mac.
https://bugs.webkit.org/show_bug.cgi?id=47798
- inspector/front-end/inspector.css: (.tabbed-pane-header li):
- 4:57 AM Changeset in webkit [69953] by
-
- 4 edits in trunk/WebKitTools
2010-10-18 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
check-webkit-style needs to ignore underscores in opcode names and vm_throw
https://bugs.webkit.org/show_bug.cgi?id=47789
- Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
- Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.
- 4:46 AM Changeset in webkit [69952] by
-
- 20 edits in trunk
2010-10-18 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=47659
Changed the reciever of hasSpellingMarkers from
textInputController to layoutTestController.
- editing/spelling/design-mode-spellcheck-off.html:
- editing/spelling/script-tests/spelling-backspace-between-lines.js: (testWithDelete): (testWithForwardDelete):
- editing/spelling/spelling-backspace-between-lines-expected.txt:
- editing/spelling/spelling-contenteditable.html:
- editing/spelling/spelling-textarea.html:
2010-10-18 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=47659
Moved hasSpellingMarkers() from TextInputController to
LayoutTestController. Currently the implementation is available
only for Mac and for Chromium.
- DumpRenderTree/LayoutTestController.cpp: (hasSpellingMarkerCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): (TextInputController::makeAttributedString):
- DumpRenderTree/chromium/TextInputController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/mac/TextInputController.m: (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::hasSpellingMarker):
- 4:42 AM Changeset in webkit [69951] by
-
- 3 edits in trunk/WebKitTools
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
commit-queue's flaky test notice is very Pythony
https://bugs.webkit.org/show_bug.cgi?id=47790
This patch make the list of tests delimted by \n instead of just
converting the array to a string.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 3:42 AM Changeset in webkit [69950] by
-
- 2 edits in trunk/LayoutTests
2010-10-18 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skip another mathml flaky test, check bug:
https://bugs.webkit.org/show_bug.cgi?id=47727
- platform/gtk/Skipped:
- 3:39 AM Changeset in webkit [69949] by
-
- 2 edits in trunk/WebCore
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Build fix.
- inspector/InspectorResourceAgent.cpp: (WebCore::cachedResourceTypeString):
- 3:14 AM Changeset in webkit [69948] by
-
- 27 edits1 add in trunk
2010-10-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
fill network panel with data.
https://bugs.webkit.org/show_bug.cgi?id=47779
InspectorResourceAgent instance / JS part are introduced in this patch. Agent's lifetime is equal
to the front-end's. This new resource agent does not have state, instead it covers two functions:
1) forwards loader client messages to the front-end 2) is capable of building a tree of cached resources.
(1) feeds network panel with data, (2) shows the resource tree in the new ResourcesPanel concept.
This bug is for extracting this new InspectorResourceAgent class and its javascript counterpart.
Once resources panel is refactored for the new concept, InspectorResource, InspectorController's
resource-related routines, inspector.js's code dealing with resources, they all will be gone.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse): (WebCore::cachedResourceType): (WebCore::InspectorResource::type): (WebCore::InspectorResource::sourceString): (WebCore::InspectorResource::sourceBytes): (WebCore::InspectorResource::endTiming):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::resourceContentBase64): (WebCore::InspectorResourceAgent::resourceData): (WebCore::InspectorResourceAgent::cachedResource): (WebCore::buildObjectForHeaders): (WebCore::buildObjectForTiming): (WebCore::buildObjectForResourceRequest): (WebCore::buildObjectForResourceResponse): (WebCore::buildObjectForMainResource): (WebCore::cachedResourceTypeString): (WebCore::buildObjectForCachedResource): (WebCore::buildObjectForFrameResources): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::identifierForInitialRequest): (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::markResourceAsCached): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::didFailLoading): (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): (WebCore::InspectorResourceAgent::setOverrideContent): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::createReadableStringFromBinary): (WebCore::InspectorResourceAgent::didCreateWebSocket): (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorResourceAgent::didCloseWebSocket): (WebCore::InspectorResourceAgent::cachedResources): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
- inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetResourceContent):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get responseReceivedTime): (WebInspector.Resource.prototype.set endTime):
- inspector/front-end/Settings.js:
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: (.tabbed-pane-header li):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse):
2010-10-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
fill network panel with data.
https://bugs.webkit.org/show_bug.cgi?id=47779
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didReceiveResponse):
- 2:18 AM Changeset in webkit [69947] by
-
- 11 edits in trunk
2010-10-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: brush up URL parsing on the front-end.
https://bugs.webkit.org/show_bug.cgi?id=47772
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.getDomainToResourcesMap): (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun): (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun): (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies): (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
- inspector/front-end/DOMAgent.js: (WebInspector.Cookies.cookieMatchesResourceURL):
- inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.set url): (WebInspector.Resource.prototype.get displayName):
- inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory.prototype.addResource):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.updateResource): (WebInspector.linkifyStringAsFragment): (WebInspector.resourceURLForRelatedNode): (WebInspector.completeURL):
- inspector/front-end/utilities.js: (String.prototype.asParsedURL):
- 1:15 AM Changeset in webkit [69946] by
-
- 3 edits in trunk/WebCore
2010-10-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Support custom open() verbs/methods in XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=40476
Fall back to QNetworkAccessManager::CustomOperation for any HTTP verb
that's not specifically supported by QNetworkAccessManager.
This prevents the infinite loop that otherwise occurs after sending
an UnknownOperation request.
This change is covered by existing (skipped) tests that will be
unskipped once the Qt bots are running Qt 4.7.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::httpMethod): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- platform/network/qt/QNetworkReplyHandler.h:
- 12:53 AM Changeset in webkit [69945] by
-
- 5 edits in trunk/LayoutTests
2010-10-18 Adam Barth <abarth@webkit.org>
Add more Skipped list entries because WebP requires an external decoder
library.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 12:39 AM Changeset in webkit [69944] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Csaba Osztrogonác.
Build broken with JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=47801
This is a regression caused by r69940.
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolveBase):
- 12:25 AM Changeset in webkit [69943] by
-
- 2 edits in trunk/JavaScriptCore
Change FastAllocBase implementation into a macro
https://bugs.webkit.org/show_bug.cgi?id=42998
Reviewed by Darin Adler.
It was investigated in bug #33896 that inheriting classes from FastAllocBase
can result in objects getting larger which leads to memory regressions.
Using a macro instead of inheriting classes from FastAllocBase would solve the issue.
- wtf/FastAllocBase.h: Add a WTF_MAKE_FAST_ALLOCATED macro
Oct 17, 2010:
- 11:51 PM Changeset in webkit [69942] by
-
- 11 edits6 adds in trunk
2010-10-17 Pascal Massimino <pascal.massimino@gmail.com>
Reviewed by Adam Barth.
Add support for WebP image decoding in ImageDecoder
using library libwebp-decode library available from
http://www.webmproject.org/code/
Tests: fast/images/webp-image-decoding.html
- CMakeLists.txt:
add platform/image-decoders/webp files and directory
- GNUmakefile.am:
add platform/image-decoders/webp directory
- WebCore.gyp/WebCore.gyp:
add platform/image-decoders/webp directory
- WebCore.gypi:
add platform/image-decoders/webp directory
- features.gypi:
add WTF_USE_WEBP=1
- platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create):
instantiate webp decoder for file starting with 'RIFF????WEBP'
- platform/image-decoders/webp: Added.
- platform/image-decoders/webp/WEBPImageDecoder.cpp: Added. (WebCore::WEBPImageDecoder::WEBPImageDecoder): (WebCore::WEBPImageDecoder::~WEBPImageDecoder): (WebCore::WEBPImageDecoder::isSizeAvailable): (WebCore::WEBPImageDecoder::frameBufferAtIndex): (WebCore::WEBPImageDecoder::decode):
sub-class handling decoding of webp images
- platform/image-decoders/webp/WEBPImageDecoder.h: Added. (WebCore::WEBPImageDecoder::filenameExtension): (WebCore::WEBPImageDecoder::supportsAlpha):
header for webp-decoder sub-class
2010-10-17 Pascal Massimino <pascal.massimino@gmail.com>
Reviewed by Adam Barth.
Add support for decoding WebP image
https://bugs.webkit.org/show_bug.cgi?id=47512
- DEPS:
- Add dependency to libwebp.
- 10:42 PM Changeset in webkit [69941] by
-
- 5 edits in trunk
2010-10-17 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: arguments is not valid as the base expression for pre- or post-fix expressions
https://bugs.webkit.org/show_bug.cgi?id=47791
Simple fix, check for arguments in addition to eval.
- parser/JSParser.cpp: (JSC::JSParser::parseUnaryExpression):
2010-10-17 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: arguments is not valid as the base expression for pre- or post-fix expressions
https://bugs.webkit.org/show_bug.cgi?id=47791
Add arguments tests, and make pre-/post-fix expression tests cover another case I was
needlessly worried about.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
- 9:08 PM Changeset in webkit [69940] by
-
- 20 edits in trunk
2010-10-17 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: Assignment that would create a global should be a late ReferenceError, not a syntax failure
https://bugs.webkit.org/show_bug.cgi?id=47788
Fixing this required a couple of changes:
- resolve_base now has a flag to indicate whether it is being used for a put in strict mode. this allows us to throw an exception when we're doing a completely generic resolve for assignment, and that assignment would create a new global.
- There is a new opcode 'op_ensure_property_exists' that is used to determine whether the property being assigned to already exists on the global object. This currently has no caching, but such caching could be added relatively trivially. It is only used in the case where we know that a property will be placed on the global object, and we cannot verify that the property already exists.
In the jit we plant a call to cti_op_resolve_base_strict_put in the effected case rather
than making op_resolve_base have an additional runtime branch.
There's also a new helper function to create the exception for the invalid assignment.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitResolveBase): (JSC::BytecodeGenerator::emitResolveBaseForPut):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp: (JSC::AssignResolveNode::emitBytecode): (JSC::ForInNode::emitBytecode):
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolveBase): (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_ensure_property_exists):
- jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_ensure_property_exists):
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- parser/JSParser.cpp: (JSC::JSParser::parseProgram):
- runtime/ExceptionHelpers.cpp: (JSC::createErrorForInvalidGlobalAssignment):
- runtime/ExceptionHelpers.h:
- runtime/Operations.h: (JSC::resolveBase):
2010-10-17 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: Assignment that would create a global should be a late ReferenceError, not a syntax failure
https://bugs.webkit.org/show_bug.cgi?id=47788
Update test to check for the correct behaviour.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
- 9:02 PM Changeset in webkit [69939] by
-
- 3 edits in trunk/LayoutTests
2010-10-17 Antonio Gomes <agomes@rim.com>
Reviewed by Simon Fraser.
Enrich /fast/dom/nodesFromRect-basic.html test
https://bugs.webkit.org/show_bug.cgi?id=47766
The patch makes fast/dom/nodesFromRect-basic.html test more precise:
instead of calling nodesFromRect always with equal vertical (up and down) and
horizontal (right and left) padding values, it are now tests it by passing
different padding values on the various directions.
It is now possible due to the work on bug 46336: Make Document::nodesFromRect more flexible.
- fast/dom/nodesFromRect-basic-expected.txt:
- fast/dom/nodesFromRect-basic.html:
- 7:59 PM Changeset in webkit [69938] by
-
- 9 edits in trunk/WebCore
2010-10-17 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Remove explicit passing of user gesture in NavigationScheduler
https://bugs.webkit.org/show_bug.cgi?id=47786
As requested by Mr. Glazkov, remove more explicit passing of the user
gesture state. We now use a static to pass this information around.
- bindings/generic/BindingFrame.h: (WebCore::::navigateIfAllowed):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::reload):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::reloadCallback):
- inspector/InspectorController.cpp: (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::reloadPage):
- loader/NavigationScheduler.cpp: (WebCore::ScheduledNavigation::ScheduledNavigation): (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): (WebCore::ScheduledRedirect::ScheduledRedirect): (WebCore::ScheduledLocationChange::ScheduledLocationChange): (WebCore::ScheduledRefresh::ScheduledRefresh): (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation): (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::NavigationScheduler::scheduleRedirect): (WebCore::NavigationScheduler::mustLockBackForwardList): (WebCore::NavigationScheduler::scheduleLocationChange): (WebCore::NavigationScheduler::scheduleFormSubmission): (WebCore::NavigationScheduler::scheduleRefresh): (WebCore::NavigationScheduler::scheduleHistoryNavigation):
- loader/NavigationScheduler.h:
- loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadOrRedirectSubframe):
- 6:22 PM Changeset in webkit [69937] by
-
- 5 edits2 adds in trunk
WebCore: 'transparent' should be a valid color
https://bugs.webkit.org/show_bug.cgi?id=45482
Reviewed by Andreas Kling.
Test: svg/animations/svg-animate-color-transparent.svg
Based on previous work by Jan Erik Hanssen <jhanssen@codeaurora.org>
- platform/ColorData.gperf: Added 'transparent' to the list of colors.
Added the alpha to all the colors as it was needed to support the new color.
- platform/graphics/Color.cpp:
(WebCore::Color::Color):
(WebCore::Color::setNamedColor): Avoid setting the alpha as now it is not
always 0xFF.
LayoutTests: Test for: 'transparent' should be a valid color
https://bugs.webkit.org/show_bug.cgi?id=45482
Reviewed by Andreas Kling.
Test that animation works with 'transparent' as they check the validity of the
color.
- svg/animations/svg-animate-color-transparent-expected.txt: Added.
- svg/animations/svg-animate-color-transparent.svg: Added.
- 5:47 PM Changeset in webkit [69936] by
-
- 3 edits2 adds in trunk
2010-10-17 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
Duplicate use element children in shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=47561
Test: svg/custom/use-nested-children.svg
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::expandUseElementsInShadowTree):
2010-10-17 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
Duplicate use element children in shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=47561
- svg/custom/use-nested-children-expected.txt: Added.
- svg/custom/use-nested-children.svg: Added.
- 5:04 PM Changeset in webkit [69935] by
-
- 2 edits in trunk/WebCore
2010-10-17 Hyung Song <beergun@company100.net>
Reviewed by David Levin.
Add !SINGLE_THREADED guard.
https://bugs.webkit.org/show_bug.cgi?id=47608
For SINGLE_THREADED ports LockingMutex.tryLock() returns false.
This will prevent interrupt() from falling into infinite loop.
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::interrupt):
- 3:05 PM Changeset in webkit [69934] by
-
- 1 edit1 delete in trunk/LayoutTests
2010-10-17 Simon Fraser <Simon Fraser>
Remove Windows-specific result, which is not longer needed after r69928.
- platform/win/fast/css/large-number-round-trip-expected.txt: Removed.
- 2:55 PM Changeset in webkit [69933] by
-
- 32 edits in branches/chromium/552
The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508
BUG=59508
Patch by Andrei Popescu <andreip@google.com> on 2010-10-11
Reviewed by Jeremy Orlow.
LayoutTests:
- storage/indexeddb/basics-expected.txt:
- storage/indexeddb/basics.html:
- storage/indexeddb/constants-expected.txt:
- storage/indexeddb/constants.html:
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/database-quota-expected.txt:
- storage/indexeddb/database-quota.html:
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/index-cursor-expected.txt:
- storage/indexeddb/index-cursor.html:
- storage/indexeddb/keyrange-expected.txt:
- storage/indexeddb/keyrange.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/objectstore-cursor-expected.txt:
- storage/indexeddb/objectstore-cursor.html:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore.html:
- storage/indexeddb/open-cursor-expected.txt:
- storage/indexeddb/open-cursor.html:
- storage/indexeddb/transaction-basics-expected.txt:
- storage/indexeddb/transaction-basics.html:
WebCore:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBCursorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseExceptionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBErrorEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBFactoryEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBIndexEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBKeyRangeEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBObjectStoreEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBRequestEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBSuccessEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBTransactionEnabled):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitIndexedDB):
- page/DOMWindow.h:
- page/DOMWindow.idl:
WebKit/chromium:
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableIndexedDatabase):
(WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):
Merge 69540 - 2010-10-11 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508
- storage/indexeddb/basics-expected.txt:
- storage/indexeddb/basics.html:
- storage/indexeddb/constants-expected.txt:
- storage/indexeddb/constants.html:
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/database-quota-expected.txt:
- storage/indexeddb/database-quota.html:
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/index-cursor-expected.txt:
- storage/indexeddb/index-cursor.html:
- storage/indexeddb/keyrange-expected.txt:
- storage/indexeddb/keyrange.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/objectstore-cursor-expected.txt:
- storage/indexeddb/objectstore-cursor.html:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore.html:
- storage/indexeddb/open-cursor-expected.txt:
- storage/indexeddb/open-cursor.html:
- storage/indexeddb/transaction-basics-expected.txt:
- storage/indexeddb/transaction-basics.html:
2010-10-11 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBCursorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseErrorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseExceptionEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBErrorEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBFactoryEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBIndexEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBKeyRangeEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBObjectStoreEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBRequestEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBSuccessEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBTransactionEnabled):
- page/DOMWindow.cpp: (WebCore::DOMWindow::webkitIndexedDB):
- page/DOMWindow.h:
- page/DOMWindow.idl:
2010-10-11 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableIndexedDatabase): (WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):
- 2:48 PM Changeset in webkit [69932] by
-
- 3 edits in branches/chromium/552/LayoutTests
storage/indexeddb/database-quota.html expects the wrong database version string
https://bugs.webkit.org/show_bug.cgi?id=47533
BUG=59506
Patch by Andrei Popescu <andreip@google.com> on 2010-10-11
Reviewed by Jeremy Orlow.
- storage/indexeddb/database-quota-expected.txt:
- storage/indexeddb/database-quota.html:
Merge 69612 - 2010-10-11 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
storage/indexeddb/database-quota.html expects the wrong database version string
https://bugs.webkit.org/show_bug.cgi?id=47533
- storage/indexeddb/database-quota-expected.txt:
- storage/indexeddb/database-quota.html:
- 2:46 PM Changeset in webkit [69931] by
-
- 2 edits in branches/chromium/552/WebKit/chromium
[Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
https://bugs.webkit.org/show_bug.cgi?id=47531
BUG=59506
Patch by Andrei Popescu <andreip@google.com> on 2010-10-11
Reviewed by Jeremy Orlow.
Remove the temporary open() method since the appropriate Chromium plumbing was
added in http://codereview.chromium.org/3729003/
- public/WebIDBFactory.h:
(WebKit::WebIDBFactory::open):
Merge 69670 - 2010-10-11 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
https://bugs.webkit.org/show_bug.cgi?id=47531
Remove the temporary open() method since the appropriate Chromium plumbing was
added in http://codereview.chromium.org/3729003/
- public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
- 2:44 PM Changeset in webkit [69930] by
-
- 11 edits in trunk/LayoutTests
2010-10-17 Martin Robinson <mrobinson@igalia.com>
Rebaseline MathML tests after r69926.
- platform/gtk/mathml/presentation/attributes-expected.txt:
- platform/gtk/mathml/presentation/fenced-mi-expected.txt:
- platform/gtk/mathml/presentation/fractions-expected.txt:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/gtk/mathml/presentation/mo-expected.txt:
- platform/gtk/mathml/presentation/row-alignment-expected.txt:
- platform/gtk/mathml/presentation/row-expected.txt:
- platform/gtk/mathml/presentation/style-expected.txt:
- platform/gtk/mathml/presentation/tokenElements-expected.txt:
- platform/gtk/mathml/presentation/underover-expected.txt:
- 1:40 PM Changeset in webkit [69929] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-17 Simon Fraser <Simon Fraser>
First part of fix for Windows build failure. Will wait for the
next set of link errors to determine the mangled forms for dtoaRoundSF
and dtoaRoundDP.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:05 PM Changeset in webkit [69928] by
-
- 12 edits2 adds1 delete in trunk
2010-10-17 Simon Fraser <Simon Fraser>
Reviewed by Nikolas Zimmermann.
Very large and small numbers fail to round-trip through CSS
https://bugs.webkit.org/show_bug.cgi?id=20674
Use the new DecimalNumber functionality to convert CSS numberic values to strings
using decimal notation, rather than %g (which can output scientific notation).
Test: fast/css/round-trip-values.html
- css/CSSPrimitiveValue.cpp: (WebCore::formatNumber): (WebCore::CSSPrimitiveValue::cssText):
- 12:46 PM Changeset in webkit [69927] by
-
- 3 edits2 adds in trunk
2010-10-17 Cosmin Truta <ctruta@chromium.org>
Reviewed by Nikolas Zimmermann.
Crash while processing ill-formed SVG with cycles
https://bugs.webkit.org/show_bug.cgi?id=47498
Checked the behavior of the attributes fill, stroke, clip and mask
when used with URLs that point to wrong elements.
- svg/custom/invalid-paint-shape-mask.svg: Added.
- svg/custom/invalid-paint-shape-mask-expected.svg: Added.
2010-10-17 Cosmin Truta <ctruta@chromium.org>
Reviewed by Nikolas Zimmermann.
Crash while processing ill-formed SVG with cycles
https://bugs.webkit.org/show_bug.cgi?id=47498
Test: svg/custom/invalid-paint-shape-mask.svg
- rendering/SVGResources.cpp: (paintingResourceFromSVGPaint): Ensured that the painting resource is either a pattern resource or a gradient resource. (SVGResources::setClipper): (SVGResources::setFilter): (SVGResources::setMarkerStart): (SVGResources::setMarkerMid): (SVGResources::setMarkerEnd): (SVGResources::setMasker): (SVGResources::setFill): (SVGResources::setStroke): Added ASSERT statements for previously-unchecked preconditions.
- 11:44 AM Changeset in webkit [69926] by
-
- 26 edits in trunk
2010-10-17 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Since whitespace and baseline alignment have changed for operators,
many tests needed to be re-baselined.
- platform/mac/mathml/presentation/attributes-expected.checksum:
- platform/mac/mathml/presentation/attributes-expected.png:
- platform/mac/mathml/presentation/attributes-expected.txt:
- platform/mac/mathml/presentation/fenced-expected.checksum:
- platform/mac/mathml/presentation/fenced-expected.png:
- platform/mac/mathml/presentation/fenced-expected.txt:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/mac/mathml/presentation/mo-expected.checksum:
- platform/mac/mathml/presentation/mo-expected.png:
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/roots-expected.checksum:
- platform/mac/mathml/presentation/roots-expected.png:
- platform/mac/mathml/presentation/roots-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.checksum:
- platform/mac/mathml/presentation/row-alignment-expected.png:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/row-expected.checksum:
- platform/mac/mathml/presentation/row-expected.png:
- platform/mac/mathml/presentation/row-expected.txt:
2010-10-17 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Fixed extra whitespace above operators when they aren't stretched
yet the stretch height is large. Also, the baseline alignment
was changed so that rows and operators interact appropriately now
that operators don't have the extra white space.
- mathml/RenderMathMLOperator.cpp:
- mathml/RenderMathMLRow.cpp:
- 11:19 AM Changeset in webkit [69925] by
-
- 4 edits3 adds in trunk
2010-10-17 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Layout tests for fix focusing of control elements on mouse click.
https://bugs.webkit.org/show_bug.cgi?id=40641
- fast/events/click-focus-control-expected.txt: Added.
- fast/events/click-focus-control.html: Added.
- platform/mac/fast/events/click-focus-control-expected.txt: Added.
- platform/win/Skipped:
2010-10-17 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Fix focusing of control elements on mouse click.
Brings GTK fix to Qt platform.
https://bugs.webkit.org/show_bug.cgi?id=40641
Test: fast/events/click-focus-control.html
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isMouseFocusable):
- 9:02 AM Changeset in webkit [69924] by
-
- 14 edits in trunk
2010-10-17 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
FrameLoader doesn't need an explicit userGesture parameter
https://bugs.webkit.org/show_bug.cgi?id=47777
We used to pass around the user gesture state explicitly. Now we use
static state. Explicitly passing the user gesture state to FrameLoader
in these methods is pretty out-dated.
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
- bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow): (WebCore::::open):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
- bindings/js/ScriptController.h:
- bindings/v8/ScriptController.h:
- html/HTMLAnchorElement.cpp: (WebCore::handleLinkClick):
- inspector/InspectorController.cpp: (WebCore::InspectorController::openInInspectedWindow):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm):
- loader/FrameLoader.h:
- loader/NavigationScheduler.cpp: (WebCore::ScheduledURLNavigation::fire): (WebCore::ScheduledRefresh::fire): (WebCore::ScheduledHistoryNavigation::fire): (WebCore::NavigationScheduler::scheduleLocationChange):
2010-10-17 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
FrameLoader doesn't need an explicit userGesture parameter
https://bugs.webkit.org/show_bug.cgi?id=47777
Update for the new API.
- WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
- 7:31 AM Changeset in webkit [69923] by
-
- 2 edits in trunk/WebCore
2010-10-17 Sergey A. Sukiyazov <sergey.sukiyazov@gmail.com>
Reviewed by Andreas Kling
[Qt] Hovering the mouse over links produce a trail of underlined links (X11 paint engine)
https://bugs.webkit.org/show_bug.cgi?id=42248
The problem will appear because coordinates of points may increase by 0.05f (if line width is odd) inside
method GraphicsContext::adjustLineToPixelBoundaries(...) and become outside of text bounding rect htere,
then the new point coordinates will be passed to Qt graphics engine.
The solution decreases Y cordinates of points inside drawLineForText(...) method only if Qt graphics engine
is X11. The Y coordinates will be increase by 0.5f inside method adjustLineToPixelBoundaries(...), which
called from drawLine(...), and then inside Qt painting engine will be rounded to next greater integer value.
NOTE: This changes will affect only Qt X11 verision and if only X11 Painting Engine will be used.
No new tests.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForText):
- 3:53 AM Changeset in webkit [69922] by
-
- 10 edits in trunk
2010-10-17 Rob Buis <rwlbuis@gmail.com>
Reviewed by Dirk Schulze.
Text under nested link dropped
https://bugs.webkit.org/show_bug.cgi?id=46460
Allow links inside of tspan and textPath elements.
- svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::childShouldCreateRenderer):
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::childShouldCreateRenderer):
