Timeline



Oct 21, 2010:

10:52 PM Changeset in webkit [70294] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-10-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Add a String constructor which takes AECHAR*
https://bugs.webkit.org/show_bug.cgi?id=45043

Implement String(const AECHAR*) constructor.

  • platform/text/brew/StringBrew.cpp: Added. (WTF::String::String):
10:49 PM Changeset in webkit [70293] by commit-queue@webkit.org
  • 9 edits in trunk

2010-10-21 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

HTMLTreeBuilder's InForeignContent code needs a re-write

Foreign Content mode was changed significantly by:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=10314

The differences can be seen here:
http://html5.org/tools/web-apps-tracker?from=5520&to=5522

This bug addresses all spec changes in the diff except the select scope
changes, which have already been fixed in a separate bug.

https://bugs.webkit.org/show_bug.cgi?id=46676

  • html5lib/resources/webkit01.dat: Added the demo case for the new code. Added a case that exposes crash when not using hasTagName().
  • html5lib/runner-expected.txt: Since the behavior of InForeignContentMode has changed, the expectations need to be updated. These have been manually verified.
  • platform/chromium/html5lib/runner-expected.txt: Ditto.
  • platform/win/html5lib/runner-expected.txt: Ditto.

2010-10-21 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

HTMLTreeBuilder's InForeignContent code needs a re-write

Foreign Content mode was changed significantly by:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=10314

The differences can be seen here:
http://html5.org/tools/web-apps-tracker?from=5520&to=5522

This bug addresses all spec changes in the diff except the select scope
changes, which have already been fixed in a separate bug.

https://bugs.webkit.org/show_bug.cgi?id=46676

  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isScopeMarker): Add foreign elements to list.
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processDoctypeToken): Switch mode before reprocessing any tokens. (WebCore::HTMLTreeBuilder::processStartTagForInBody): Ditto. Remove secondary insertion mode. (WebCore::HTMLTreeBuilder::processStartTagForInTable): Switch mode before reprocessing any tokens. (WebCore::HTMLTreeBuilder::processStartTag): Ditto. Remove secondary insertion mode. (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): Remove foreign var. Use hasTagName() instead of == localName() to fix bug with foreign elements. (WebCore::HTMLTreeBuilder::processEndTagForInTableBody): Switch mode before reprocessing any tokens. (WebCore::HTMLTreeBuilder::processEndTagForInRow): Ditto. (WebCore::HTMLTreeBuilder::processEndTagForInCell): Ditto. (WebCore::HTMLTreeBuilder::processEndTagForInBody): Ditto. (WebCore::HTMLTreeBuilder::processEndTag): Ditto. (WebCore::HTMLTreeBuilder::prepareToReprocessToken): Added. (WebCore::HTMLTreeBuilder::reprocessStartTag): Added. (WebCore::HTMLTreeBuilder::reprocessEndTag): Added. (WebCore::HTMLTreeBuilder::processForeignContentUsingInBodyModeAndResetMode): Added. (WebCore::HTMLTreeBuilder::resetForeignInsertionMode): Added. (WebCore::HTMLTreeBuilder::processComment): Switch mode before reprocessing any tokens. (WebCore::HTMLTreeBuilder::processCharacterBuffer): Ditto. (WebCore::HTMLTreeBuilder::processEndOfFile): Ditto.
  • html/parser/HTMLTreeBuilder.h: Functions and member for tracking potential switch from InForeignContentMode.
10:47 PM Changeset in webkit [70292] by morrita@google.com
  • 2 edits in trunk/WebKit/win

2010-10-21 MORITA Hajime <morrita@google.com>

Unreviewed, touched it to fix the build.

  • Interfaces/WebKit.idl:
10:35 PM Changeset in webkit [70291] by morrita@google.com
  • 9 edits in trunk

2010-10-21 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Win][DRT] should have LayoutTestController.hasSpellingMarker()
https://bugs.webkit.org/show_bug.cgi?id=47885

Added IWebFramePrivate::hasSpellingMarker() and impelmented it for
LayoutTestController.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp: (WebFrame::hasSpellingMarker):
  • WebFrame.h:

2010-10-21 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Win][DRT] should have LayoutTestController.hasSpellingMarker()
https://bugs.webkit.org/show_bug.cgi?id=47885

  • Implemented LayoutTestController.hasSpellingMarker(),
  • Added fake spellcheck implementation.
  • DumpRenderTree/win/DumpRenderTree.cpp: (main):
  • DumpRenderTree/win/EditingDelegate.cpp: (indexOfFirstWordCharacter): (wordLength): (EditingDelegate::checkSpellingOfString):
  • DumpRenderTree/win/EditingDelegate.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::hasSpellingMarker):
10:34 PM Changeset in webkit [70290] by abarth@webkit.org
  • 3 edits
    3 deletes in trunk

2010-10-21 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Remove Android build system
https://bugs.webkit.org/show_bug.cgi?id=48111

  • Android.mk: Removed.

2010-10-21 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Remove Android build system
https://bugs.webkit.org/show_bug.cgi?id=48111

  • Android.mk: Removed.

2010-10-21 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Remove Android build system
https://bugs.webkit.org/show_bug.cgi?id=48111

As far as I can tell, these files are not maintained. They are a
mantaince burden on the project. If folks would like to come out of
the woodwork and maintain these files, that's great. At the moment,
they seem like dead weight for the project.

  • Android.mk: Removed.
10:16 PM Changeset in webkit [70289] by yuzo@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-21 Yuzo Fujishima <yuzo@google.com>

Unreviewed build fix attempt for Chromium Linux Debug Clang

  • public/WebExternalPopupMenu.h:
9:43 PM Changeset in webkit [70288] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Add a String constructor which takes AECHAR*
https://bugs.webkit.org/show_bug.cgi?id=45043

Add String(const AECHAR*) constructor for convenience.

  • wtf/text/WTFString.h:
8:39 PM Changeset in webkit [70287] by commit-queue@webkit.org
  • 3 edits
    1 move in trunk/WebCore

2010-10-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by James Robinson.

Make sure skia is not Chromium specific
https://bugs.webkit.org/show_bug.cgi?id=39672

GlyphPageTreeNodeLinux does not depend on Linux or Chromium.
Move GlyphPageTreeNodeLinux to platform/graphics/skia and rename it to
GlyphPageTreeNodeSkia.cpp so that other ports can use it.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Removed.
  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added.
7:58 PM Changeset in webkit [70286] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; rebaseline for r70240.

  • platform/mac-leopard/inspector/extensions-resources-expected.txt: Replaced XHR by xhr.
7:45 PM Changeset in webkit [70285] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2010-10-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

REGRESSION(r70283): editing/execCommand/remove-format-elements.html fails on qt, gtk, and chromium
https://bugs.webkit.org/show_bug.cgi?id=48108

Modified the test to ignore the contents of keygen element.

  • editing/execCommand/remove-format-elements-expected.txt:
  • editing/execCommand/remove-format-elements.html:
6:50 PM Changeset in webkit [70284] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-10-21 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium/test_expectations.txt:
6:30 PM Changeset in webkit [70283] by rniwa@webkit.org
  • 25 edits
    5 adds in trunk

2010-10-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

removeFormat needs to be reimplemented
https://bugs.webkit.org/show_bug.cgi?id=43017

Reimplemented execCommand('RemoveFormat', false, null). New implementation removes
the same elements removed by Internet Explorer. Because WebKit supports StyleWithCSS
we also reset any editing styles to match that of the root editable element
while Internet Explorer does not remove any CSS styles.

New implementation uses ApplyStyleCommand to remove appropriate elements and reset the style.
Added new constructor and member variable to ApplyStyleCommand to support mass-removal of elements
since it's inefficient to call ApplyStyleCommand on each element we're removing.

To avoid an infinite loop in pushDownInlineStyleAroundNode when mass-removing, WebKit no longer
push down element one level at a time. Instead, we keep a stack of styled elements to be applied,
and apply wrap siblings of targetNode's ancestors by all of them at once.

Tests: editing/execCommand/remove-format-elements.html

editing/execCommand/remove-format-multiple-elements.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): Added; this version takes style and a function pointer to a boolean function that determines which element needs to removed, and set m_removeOnly to true. (WebCore::ApplyStyleCommand::doApply): Added support for m_isInlineElementToRemoveFunction. (WebCore::ApplyStyleCommand::applyBlockStyle): Ditto. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Exits early if m_removeOnly is true. (WebCore::ApplyStyleCommand::isStyledInlineElementToRemove): Added. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls isStyledInlineElementToRemove. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Ditto. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): See above.
  • editing/ApplyStyleCommand.h: (WebCore::ApplyStyleCommand::create): Added.
  • editing/RemoveFormatCommand.cpp: (WebCore::isElementForRemoveFormatCommand): Added. (WebCore::RemoveFormatCommand::doApply): Rewritten.

2010-10-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

removeFormat needs to be reimplemented
https://bugs.webkit.org/show_bug.cgi?id=43017

  • editing/execCommand/19403-expected.txt: hr element is no longer removed erroneously.
  • editing/execCommand/19403.html: Updated the test description.
  • editing/execCommand/4786404-1-expected.txt: Change in text nodes but identical rendering.
  • editing/execCommand/4786404-2-expected.txt: Ditto.
  • editing/execCommand/4920488-expected.txt: Preserves anchor element on RemoveFormat.
  • editing/execCommand/4920488.html: Updated the test description.
  • editing/execCommand/4920742-1-expected.txt: Preserves div elements.
  • editing/execCommand/5049671.html: Updated the test to dump twice before and after RemoveFormat. This was a test to ensure WebKit removes anchor elements but we no longer removes anchor elements.
  • editing/execCommand/5049671-expected.txt:
  • editing/execCommand/5573879.html: Updated the test description because WebKit no longer removes lists on RemoveFormat.
  • editing/execCommand/5573879-expected.txt:
  • editing/execCommand/5770834-1-expected.txt: Removed redundant text-align property value.
  • editing/execCommand/remove-format-elements-expected.txt: Added.
  • editing/execCommand/remove-format-elements.html: Added.
  • editing/execCommand/remove-format-multiple-elements-expected.txt: Added.
  • editing/execCommand/remove-format-multiple-elements.html: Added.
  • editing/execCommand/remove-formatting-2-expected.txt: Change in text nodes but identical rendering.
  • editing/execCommand/remove-formatting-expected.txt: WebKit no longer removes anchor, table, tbody, tr, and td elements.
  • editing/execCommand/script-tests/remove-format-multiple-elements.js: Added. (testRemoveFormat): (selectAll): (selectSecondWord): (selectFirstTwoWords): (selectLastTwoWords): (selectLastWord):
  • editing/execCommand/script-tests/toggle-link.js: Anchor wraps div instead of div wrapping anchor.
  • editing/execCommand/script-tests/toggle-unlink.js: Ditto.
  • editing/execCommand/toggle-link-expected.txt: Ditto.
  • editing/execCommand/toggle-unlink-expected.txt: Ditto.
  • editing/execCommand/unlink-expected.txt: i wraps div instead of i wrapping anchor.
  • editing/inserting/space-after-removeformat-expected.txt: Editing delegate change.
6:27 PM Changeset in webkit [70282] by tonyg@chromium.org
  • 12 edits
    3 moves
    2 adds
    3 deletes in trunk

2010-10-21 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Ignore document.write() when it comes from a network task
https://bugs.webkit.org/show_bug.cgi?id=47560

write()s from deferred scripts are now ignored. This matches the latest
Firefox 4 beta behavior. The defer-write expectations are updated, and
the other tests are now all moot since deferred scrits can't write().

  • fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-double-defer-write.html: Removed.
  • fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-double-write.html: Removed.
  • fast/dom/HTMLScriptElement/defer-write.html: Updated to match FF4.
  • fast/dom/HTMLScriptElement/remove-source-expected.txt: Added.
  • fast/dom/HTMLScriptElement/remove-source.html: Added. Verifies that writes are still ignored when the src is removed after the script is requested but before it is executed.
  • fast/dom/HTMLScriptElement/two-defer-writes-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/two-defer-writes.html: Removed.
  • fast/dom/HTMLScriptElement/write-after-ignored-write-expected.txt: Added. Verifies that after a write from a network task is ignored, a write which is not from a network task still blows away the document.
  • fast/dom/HTMLScriptElement/write-after-ignored-write.html: Added.

2010-10-21 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Ignore document.write() when it comes from a network task
https://bugs.webkit.org/show_bug.cgi?id=47560

This implements the update to the spec made by:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=9767

It also matches the latest Firefox 4 beta. The notable change is that
document.write from a deferred script no longer works. This avoids
blowing the patch away.

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::write):
  • dom/Document.h: (WebCore::DestructiveWriteCountIncrementer::DestructiveWriteCountIncrementer): (WebCore::Document::ignoreDestructiveWriteCountIncrementer):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::insertedIntoDocument): (WebCore::ScriptElementData::ScriptElementData): (WebCore::ScriptElementData::evaluateScript):
  • dom/ScriptElement.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
6:03 PM Changeset in webkit [70281] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed Leopard build fix attempt.

6:03 PM Changeset in webkit [70280] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-21 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Re-enable test that was mistakenly disabled by r67974.

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
5:52 PM Changeset in webkit [70279] by mihaip@chromium.org
  • 4 edits in trunk/WebKitTools

2010-10-21 Mihai Parparita <mihaip@chromium.org>

Unreviewed fix for rebaseline-chromium-webkit-tests.

Port.diff_image no longer has a tolerance parameter. Also, use
get_option('tolerance') which is safer if the options object doesn't
define a tolerance attribute (it doesn't for the one used in
rebaseline_chromium_webkit_tests).

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
5:22 PM Changeset in webkit [70278] by jamesr@google.com
  • 78 edits
    18 adds in trunk/LayoutTests

2010-10-21 James Robinson <jamesr@chromium.org>

Update chromium baselines, primarly for underline pixel changes.

  • platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.checksum:
  • platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/chromium-linux/css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum:
  • platform/chromium-linux/css2.1/t1504-c543-txt-decor-00-d-g-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-clip-text-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/background-clip-text-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-inherit-color-bug-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/chromium-linux/fast/css-generated-content/010-expected.checksum:
  • platform/chromium-linux/fast/css-generated-content/010-expected.png:
  • platform/chromium-linux/fast/css/compare-content-style-expected.checksum:
  • platform/chromium-linux/fast/css/compare-content-style-expected.png:
  • platform/chromium-linux/fast/css/css1_forward_compatible_parsing-expected.checksum:
  • platform/chromium-linux/fast/css/css1_forward_compatible_parsing-expected.png:
  • platform/chromium-linux/fast/css/line-height-font-order-expected.checksum:
  • platform/chromium-linux/fast/css/line-height-font-order-expected.png:
  • platform/chromium-linux/fast/css/text-overflow-ellipsis-strict-expected.checksum:
  • platform/chromium-linux/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.checksum:
  • platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.png:
  • platform/chromium-linux/fast/layers/normal-flow-hit-test-expected.checksum:
  • platform/chromium-linux/fast/layers/normal-flow-hit-test-expected.png:
  • platform/chromium-linux/fast/lists/003-expected.checksum:
  • platform/chromium-linux/fast/lists/003-expected.png:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.png:
  • platform/chromium-linux/fast/parser/remove-block-in-residual-style-expected.checksum:
  • platform/chromium-linux/fast/parser/remove-block-in-residual-style-expected.png:
  • platform/chromium-linux/fast/reflections/reflection-overflow-hidden-expected.checksum:
  • platform/chromium-linux/fast/reflections/reflection-overflow-hidden-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.checksum:
  • platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-linux/fast/selectors/016-expected.checksum:
  • platform/chromium-linux/fast/selectors/016-expected.png:
  • platform/chromium-linux/fast/selectors/017-expected.checksum:
  • platform/chromium-linux/fast/selectors/017-expected.png:
  • platform/chromium-linux/fast/selectors/020-expected.checksum:
  • platform/chromium-linux/fast/selectors/020-expected.png:
  • platform/chromium-linux/fast/selectors/061-expected.checksum:
  • platform/chromium-linux/fast/selectors/061-expected.png:
  • platform/chromium-linux/fast/selectors/062-expected.checksum:
  • platform/chromium-linux/fast/selectors/062-expected.png:
  • platform/chromium-linux/fast/selectors/065-expected.checksum:
  • platform/chromium-linux/fast/selectors/065-expected.png:
  • platform/chromium-linux/fast/selectors/166-expected.checksum:
  • platform/chromium-linux/fast/selectors/166-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-linux/fast/text/international/khmer-selection-expected.checksum:
  • platform/chromium-linux/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-linux/fast/transforms/transform-positioned-ancestor-expected.checksum:
  • platform/chromium-linux/fast/transforms/transform-positioned-ancestor-expected.png:
  • platform/chromium-linux/fast/transforms/transformed-caret-expected.checksum:
  • platform/chromium-linux/fast/transforms/transformed-caret-expected.png:
  • platform/chromium-linux/svg/custom/rootmost-svg-xy-attrs-expected.checksum:
  • platform/chromium-linux/svg/custom/rootmost-svg-xy-attrs-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/010-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/010-expected.png: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
  • platform/chromium-mac/fast/selectors: Added.
  • platform/chromium-mac/fast/selectors/166-expected.checksum: Added.
  • platform/chromium-mac/fast/selectors/166-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/collapsing_borders: Added.
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Added.
  • platform/chromium-win/css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum:
  • platform/chromium-win/css2.1/t1504-c543-txt-decor-00-d-g-expected.png:
  • platform/chromium-win/fast/css-generated-content/010-expected.checksum:
  • platform/chromium-win/fast/css-generated-content/010-expected.png:
  • platform/chromium-win/fast/css/text-overflow-ellipsis-strict-expected.checksum:
  • platform/chromium-win/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium/test_expectations.txt:
5:04 PM Changeset in webkit [70277] by mihaip@chromium.org
  • 7 edits in trunk/WebKitTools

2010-10-21 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

Add support for --tolerance in NRWT
https://bugs.webkit.org/show_bug.cgi?id=47959

Add support for the --tolerance flag in NRWT. The Port.diff_image
signature shouldn't need a tolerance parameter (it's not set per test),
just have ports that use it (currently only WebKitPort) read it from
the options object.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
5:00 PM Changeset in webkit [70276] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-21 Ojan Vafai <ojan@chromium.org>

Update some expectations to match the bots. A couple of these are to
green the new webkit linux debug build slaves. For some reason these
tests crashed on the old slaves, but now match other platforms on
the new slaves.

  • platform/chromium/test_expectations.txt:
4:50 PM Changeset in webkit [70275] by jhoneycutt@apple.com
  • 5 edits
    2 adds in trunk/WebKit2

<rdar://problem/8423766> Cursor does not become "busy" when a page is
loading with WebKit2

Reviewed by Sam Weinig.

  • UIProcess/API/C/win/WKViewPrivate.cpp: Added.

(WKViewSetOverrideCursor):
Call the WebView's setOverrideCursor().

  • UIProcess/API/C/win/WKViewPrivate.h: Added.

Declare WKViewSetOVerrideCursor().

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):
Initialize new member vars to 0.
(WebKit::WebView::updateNativeCursor):
If there is an override cursor, and the last cursor set from the web
process was the arrow cursor, use the override cursor. Otherwise, use
the cursor from the web process.
(WebKit::WebView::setCursor):
Record the web process's cursor, and call updateNativeCursor().
(WebKit::WebView::setOverrideCursor):
Record the override cursor, and call updateNativeCursor().

  • UIProcess/win/WebView.h:

Declare setOverrideCursor() and updateNativeCursor(). Add members to
hold the last cursor set from the web process and the override cursor.

  • win/WebKit2.vcproj:

Add new files to project.

  • win/WebKit2Generated.make:

Copy WKViewPrivate.h with other headers.

4:45 PM WebKitGTKFonts edited by mrobinson@webkit.org
(diff)
4:00 PM Changeset in webkit [70274] by eric@webkit.org
  • 8 edits
    2 adds in trunk/WebKitTools

2010-10-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch
https://bugs.webkit.org/show_bug.cgi?id=48088

This is a first-pass. Works, but we'll eventually
turn this on by default, refine the suggestion algorithm
and possibly move it to a different place in the upload step order.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/options.py:
3:58 PM Changeset in webkit [70273] by tony@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-10-21 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] roll chromium DEPS to include forwarding headers refactor
https://bugs.webkit.org/show_bug.cgi?id=48097

  • DEPS: Roll chromium forward to include new forwarding headers script
  • WebKit.gyp: This dependency always existed, it's just exposed now

that the header files are in a different include dir.

3:37 PM Changeset in webkit [70272] by mihaip@chromium.org
  • 2 edits in trunk/WebCore

2010-10-21 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

[Chromium] Fix Chromium Mac build
https://bugs.webkit.org/show_bug.cgi?id=48096

Fix Chromium Mac build after r70225 (Chromium uses Core Text but is not
PLATFORM(MAC)).

  • platform/graphics/SimpleFontData.h:
3:17 PM Changeset in webkit [70271] by jparent@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2010-10-21 Julie Parent <jparent@chromium.org>

Reviewed by Tony Chang.

[Chromium] Remove chromium baseline for http/tests/plugins/geturlnotify-from-npp-destroystream.html
https://bugs.webkit.org/show_bug.cgi?id=48025

  • platform/chromium-win/http/tests/plugins/geturlnotify-from-npp-destroystream-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: updated to account for expected results after this change
3:14 PM Changeset in webkit [70270] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-21 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Segfault while testing accessibility/iframe-bastardization.html
https://bugs.webkit.org/show_bug.cgi?id=30123

Check m_element before actually using it to get the parent.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::parentElement): Add an extra check to make sure m_element points to a valid value before actually using it to get the parent. Also, assert ATK_IS_OBJECT(m_element).
3:04 PM Changeset in webkit [70269] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add two plug-in tests to the WebKit2 Skipped list.

Reviewed by Adam Roben.

  • platform/mac-wk2/Skipped:
2:46 PM Changeset in webkit [70268] by hyatt@apple.com
  • 5 edits in trunk/LayoutTests/platform/mac/fast/blockflow

Check in ugly result for now.

2:46 PM Changeset in webkit [70267] by andersca@apple.com
  • 6 edits
    1 add in trunk

Crash evaluating JavaScript string that throws an exception
https://bugs.webkit.org/show_bug.cgi?id=48092
<rdar://problem/8487657>

Reviewed by Adam Roben.

WebKit2:

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::sendMessage):
m_connection can be null here; just return false if that is the case.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):
If the JSValue returned is null we just send along a null string.

WebKitTools:

Add a test that evaluates a JavaScript string that throws an exception and check that
the callback is called.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Added.

(TestWebKitAPI::didRunJavaScript):
(TestWebKitAPI::WebKit2_EvaluateJavaScript):

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
2:43 PM Changeset in webkit [70266] by xji@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-21 Xiaomei Ji <xji@chromium.org>

Reviewed by David Levin.

Performance improvement for FontLinux.
https://bugs.webkit.org/show_bug.cgi?id=47019


Reduce the number of calls for the normalization function because converting
to NFC form is very expensive.


Combine space normalization and character mirroring into one text scan.

Test: platform/chromium/fast/text/font-linux-normalize.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::normalizeSpacesAndMirrorChars):

2010-10-21 Xiaomei Ji <xji@chromium.org>

Reviewed by David Levin.

Performance improvement for FontLinux.
https://bugs.webkit.org/show_bug.cgi?id=47019


Reduce the number of calls for the normalization function because converting
to NFC form is very expensive.


Combine space normalization and character mirroring into one text scan.

  • platform/chromium/fast/text/font-linux-normalize-expected.txt: Added.
  • platform/chromium/fast/text/font-linux-normalize.html: Added.
2:40 PM Changeset in webkit [70265] by Adam Roben
  • 11 edits
    3 adds in trunk

Invalidate the plugin's HWND when NPN_InvalidateRect is called

Fixes <http://webkit.org/b/48086> <rdar://problem/8482944> Silverlight
doesn't repaint in WebKit2

Reviewed by Anders Carlsson.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::invalidate): Call platformInvalidate before
invalidating via the PluginController.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Added platformInvalidate.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformInvalidate):

  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:

(WebKit::NetscapePlugin::platformInvalidate):
Stubbed out.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformInvalidate): If the plugin is
windowed, invalidate its HWND via ::InvalidateRect.

WebKitTools:

Test that the plugin's HWND is invalidated when NPN_InvalidateRect is
called

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPN_InvalidateRect): Added. Calls through to the browser.
(executeScript): Added. Asks the browser to evaluate the script.

(PluginTest::waitUntilDone):
(PluginTest::notifyDone):
Added. Calls through to layoutTestController.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added
  • NPN_InvalidateRect and waitUntilDone/notifyDone.
  • DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp: Added.

(TemporaryWindowMover::moveSucceeded):
(TemporaryWindowMover::TemporaryWindowMover):
(TemporaryWindowMover::~TemporaryWindowMover):
This class moves a window on-screen and shows it, then moves it back and hides it.

(NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
Initialize our members.
(NPNInvalidateRectInvalidatesWindow::~NPNInvalidateRectInvalidatesWindow):
Delete our window mover if it hasn't been deleted already.
(NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Subclass the
plugin HWND and move the test harness window on screen.
(NPNInvalidateRectInvalidatesWindow::wndProc): Call through to onPaint
when we get a WM_PAINT message.
(NPNInvalidateRectInvalidatesWindow::onPaint): Do the test and tell
LayoutTestController we're done.
(NPNInvalidateRectInvalidatesWindow::testInvalidateRect): Validate
ourselves, invalidate our lower-right quadrant via NPN_InvalidateRect,
then check that our HWND's invalid region is the rect that we
invalidated.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • Added NPNInvalidateRectInvalidatesWindow.

LayoutTests:

Test that the plugin's HWND is invalidated when NPN_InvalidateRect is
called

  • platform/win/plugins/npn-invalidate-rect-invalidates-window-expected.txt: Added.
  • platform/win/plugins/npn-invalidate-rect-invalidates-window.html: Added.
2:21 PM Changeset in webkit [70264] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-21 Daniel Bates <dbates@rim.com>

Add Git-support to do-file-rename
https://bugs.webkit.org/show_bug.cgi?id=48015

Fix tools. Export function scmMoveOrRenameFile so that it can be called from
do-file-rename and do-webcore-rename. I inadvertently left this out of the patch.

  • Scripts/VCSUtils.pm:
2:16 PM Changeset in webkit [70263] by hyatt@apple.com
  • 10 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=48085

Reviewed by Darin Adler.

Make basic vertical text painting work. This includes the text itself, underlines, overlines, line-throughs and shadows.

Added fast/blockflow/english-lr-text.html

WebCore:

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paint):

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintTextMatchMarker):

  • rendering/InlineTextBox.h:
  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintTextWithShadows):

LayoutTests:

  • fast/blockflow/english-lr-text.html: Added.
  • platform/mac/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/mac/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/mac/fast/blockflow/english-lr-text-expected.txt: Added.
1:31 PM Changeset in webkit [70262] by noam.rosenthal@nokia.com
  • 5 edits in trunk/WebCore

2010-10-21 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

[Qt] When doing rendering through tiling, it seems the tiles are not initialized before rendering
https://bugs.webkit.org/show_bug.cgi?id=48070

No new tests. Auto-tests for Tiled Backing Store should be added, see bug 48082

  • page/Frame.cpp: (WebCore::Frame::tiledBackingStoreBackgroundColor):
  • page/Frame.h:
  • platform/graphics/TiledBackingStoreClient.h:
  • platform/graphics/qt/TileQt.cpp: (WebCore::Tile::updateBackBuffer):
1:24 PM Changeset in webkit [70261] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Find indicator does not draw found text in WebKit2 when page is not scrolled to top
<rdar://problem/8562647>
https://bugs.webkit.org/show_bug.cgi?id=48089

Reviewed by John Sullivan.

We always want the selection rectangle in "WebCore window coordinates" which is the same
as WKView coordinates in WebKit2.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):

1:09 PM QtWebKitRelease20 edited by Ademar Reis
minor refactorings (diff)
1:08 PM Changeset in webkit [70260] by jamesr@google.com
  • 4 edits in trunk/LayoutTests

2010-10-21 James Robinson <jamesr@chromium.org>

Reviewed by Darin Adler.

Spurious reference to undefined variable 'test' in fast/text/international/vertical-text-glyph-test.html
https://bugs.webkit.org/show_bug.cgi?id=48084

  • fast/text/international/vertical-text-glyph-test.html:
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/mac-leopard/fast/text/international/vertical-text-glyph-test-expected.txt:
12:53 PM Changeset in webkit [70259] by robert@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-10-21 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Sending a QInputMethodEvent::Selection event forces the

Editor to go into Composition mode

Improve QWebPage handling of input method events:

  • Selections don't trigger entering composition mode.
  • Handle multiple selections

Also remove redundant cancellation of composition in tst_qwebpage.
There is no composition in progress at that point.

Finally, move infiniteLoopJS() to the end of the tst_qwebpage unit
tests - so you don't have to wait for it to complete when running
other tests.

https://bugs.webkit.org/show_bug.cgi?id=39625

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
12:51 PM Changeset in webkit [70258] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Always clear the selection when the find string isn't found
https://bugs.webkit.org/show_bug.cgi?id=48087
<rdar://problem/8564640>

Reviewed by David Hyatt.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):

12:33 PM Changeset in webkit [70257] by commit-queue@webkit.org
  • 5 edits in trunk

2010-10-21 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use GCharsetConverter instead of g_iconv in TextCodecGtk
https://bugs.webkit.org/show_bug.cgi?id=47896

  • wtf/gobject/GTypedefs.h:

2010-10-21 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use GCharsetConverter instead of g_iconv in TextCodecGtk
https://bugs.webkit.org/show_bug.cgi?id=47896

It makes error handling easier. Fixes tests:

fast/encoding/invalid-multi-byte-over-consumption.html
fast/encoding/invalid-xml.html
fast/encoding/japanese-encoding-mix.html

when building with glib unicode

  • platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::TextCodecGtk): (WebCore::TextCodecGtk::~TextCodecGtk): (WebCore::TextCodecGtk::createIConvDecoder): (WebCore::TextCodecGtk::createIConvEncoder): (WebCore::TextCodecGtk::decode): (WebCore::TextCodecGtk::encode):
  • platform/text/gtk/TextCodecGtk.h:
12:22 PM Changeset in webkit [70256] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: contenteditable nodes do not return correct AXSelectedText* attributes
https://bugs.webkit.org/show_bug.cgi?id=48080

Reviewed by Beth Dakin.

WebCore:

The ariaSelectedDOMTextRange() method was not returning the correct values.
The fix is to return a plain text range that represents the current selection.

Test: platform/mac/accessibility/content-editable-range-properties.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::accessibilityDescription):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaSelectedTextRange):
(WebCore::AccessibilityRenderObject::selectedText):
(WebCore::AccessibilityRenderObject::selectedTextRange):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • platform/mac/accessibility/content-editable-range-properties-expected.txt: Added.
  • platform/mac/accessibility/content-editable-range-properties.html: Added.
12:21 PM Changeset in webkit [70255] by ap@apple.com
  • 8 edits in trunk/WebKit2

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=48083
<rdar://problem/8489082> Need WebKit2 API for private browsing

This just adds glue code for passing the preference from embedder to WebCore. The aspects of
private browsing that WebCore is responsible for do work, but cookies are not handled yet.

  • Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::WebPreferencesStore): (WebKit::WebPreferencesStore::encode): (WebKit::WebPreferencesStore::decode):
  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetPrivateBrowsingEnabled): (WKPreferencesGetPrivateBrowsingEnabled):
  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::setPrivateBrowsingEnabled): (WebKit::WebPreferences::privateBrowsingEnabled):
  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Do what it takes to pass a single boolean from WebKit2 to WebCore. And we aren't even syncing the preference to user defaults yet.
12:19 PM Changeset in webkit [70254] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-10-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

mac-ews is not properly releasing patches
https://bugs.webkit.org/show_bug.cgi?id=48076

mac-ews overrides process_work_item, so it was not calling
release_work_item like the default process_work_item would.
To fix this I made all the status-reporting methods just
release the patch. I expect we'll iterate on this design further.

  • Scripts/webkitpy/common/net/statusserver.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
12:11 PM Changeset in webkit [70253] by mrobinson@webkit.org
  • 46 edits
    1 copy
    11 adds in trunk

2010-10-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] mathml flaky tests after adding SystemFonts to the theme
https://bugs.webkit.org/show_bug.cgi?id=47727

Rebaseline, add pixel results for, and unskip all MathML tests.

  • platform/gtk/Skipped: Unskip MathML tests.
  • platform/gtk/mathml/presentation/attributes-expected.checksum:
  • platform/gtk/mathml/presentation/attributes-expected.png:
  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fenced-expected.checksum: Added.
  • platform/gtk/mathml/presentation/fenced-expected.png: Added.
  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/fenced-mi-expected.checksum:
  • platform/gtk/mathml/presentation/fenced-mi-expected.png:
  • platform/gtk/mathml/presentation/fenced-mi-expected.txt:
  • platform/gtk/mathml/presentation/fractions-expected.checksum:
  • platform/gtk/mathml/presentation/fractions-expected.png:
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.checksum:
  • platform/gtk/mathml/presentation/mo-expected.png:
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/over-expected.checksum:
  • platform/gtk/mathml/presentation/over-expected.png:
  • platform/gtk/mathml/presentation/over-expected.txt:
  • platform/gtk/mathml/presentation/roots-expected.checksum: Added.
  • platform/gtk/mathml/presentation/roots-expected.png: Added.
  • platform/gtk/mathml/presentation/roots-expected.txt:
  • platform/gtk/mathml/presentation/row-alignment-expected.checksum:
  • platform/gtk/mathml/presentation/row-alignment-expected.png:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.checksum:
  • platform/gtk/mathml/presentation/row-expected.png:
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.checksum:
  • platform/gtk/mathml/presentation/style-expected.png:
  • platform/gtk/mathml/presentation/style-expected.txt:
  • platform/gtk/mathml/presentation/sub-expected.checksum: Added.
  • platform/gtk/mathml/presentation/sub-expected.png: Added.
  • platform/gtk/mathml/presentation/sub-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.checksum: Added.
  • platform/gtk/mathml/presentation/subsup-expected.png: Added.
  • platform/gtk/mathml/presentation/subsup-expected.txt:
  • platform/gtk/mathml/presentation/sup-expected.checksum: Added.
  • platform/gtk/mathml/presentation/sup-expected.png: Added.
  • platform/gtk/mathml/presentation/sup-expected.txt:
  • platform/gtk/mathml/presentation/tables-expected.checksum: Added.
  • platform/gtk/mathml/presentation/tables-expected.png: Added.
  • platform/gtk/mathml/presentation/tables-expected.txt:
  • platform/gtk/mathml/presentation/tokenElements-expected.checksum:
  • platform/gtk/mathml/presentation/tokenElements-expected.png:
  • platform/gtk/mathml/presentation/tokenElements-expected.txt:
  • platform/gtk/mathml/presentation/under-expected.checksum:
  • platform/gtk/mathml/presentation/under-expected.png:
  • platform/gtk/mathml/presentation/under-expected.txt:
  • platform/gtk/mathml/presentation/underover-expected.checksum:
  • platform/gtk/mathml/presentation/underover-expected.png:
  • platform/gtk/mathml/presentation/underover-expected.txt:

2010-10-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] mathml flaky tests after adding SystemFonts to the theme
https://bugs.webkit.org/show_bug.cgi?id=47727

The Fontconfig setup in the GTK+ now specifically checks for and
loads the STIX fonts for MathML tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Add hooks for loading the STIX fonts specifically.
11:19 AM Changeset in webkit [70252] by jer.noble@apple.com
  • 8 edits
    2 adds in trunk/WebCore

2010-10-20 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Video -> Canvas doesn't work on Windows
https://bugs.webkit.org/show_bug.cgi?id=47996
rdar://problem/7884690

  • WebCore.vcproj/QTMovieWin.vcproj: Added QTDecompressionSession.{cpp,h}
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): Create a

QTDecompressionSession if necessary and convert the QTPixelBuffer
into a CG-compatible one.

  • platform/graphics/win/QTDecompressionSession.cpp: Added.
  • platform/graphics/win/QTDecompressionSession.h: Added.
  • platform/graphics/win/QTPixelBuffer.cpp: (SetNumberValue): Moved from QTMovieVisualContext. (QTPixelBuffer::createPixelBufferAttributesDictionary): Moved from inside

QTMovieVisualContext::createPixelBufferOptionsDictionary().

  • platform/graphics/win/QTPixelBuffer.h: Moved the Type enum

from QTMovieVisualContext.h.

11:13 AM Changeset in webkit [70251] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-21 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] TextBreakIteratorGtk should initialize its internal index to 0
https://bugs.webkit.org/show_bug.cgi?id=48065

It fixes the following tests when using glib unicode:

fast/forms/ValidityState-tooLong-input.html
fast/forms/ValidityState-tooLong-textarea.html
fast/forms/input-appearance-maxlength.html
fast/forms/input-implicit-length-limit.html
fast/forms/input-maxlength.html
fast/forms/textarea-live-pseudo-selectors.html
fast/forms/mailto/advanced-get.html
fast/forms/mailto/advanced-put.html

  • platform/text/gtk/TextBreakIteratorGtk.cpp: (WebCore::setUpIterator):
11:03 AM Changeset in webkit [70250] by mitz@apple.com
  • 36 edits
    9 adds in trunk

2010-10-21 takano takumi <takano1@asia.apple.com>

Reviewed by Dan Bernstein.

Need to swap glyphs for vertical writing
https://bugs.webkit.org/show_bug.cgi?id=46973

Made changes to pass the writing-mode orientation flag in RenderStyle down to FontPlatformData,
and ultimately to CoreText APIs in both font complex path and fast path.

Tests: fast/text/international/vertical-text-glyph-test.html

fast/text/international/vertical-text-metrics-test.html

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj: Added platform/graphics/FontOrientation.h.
  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData): Added font orientation parameter to SimpleFontData.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Set appropriate font orientation to the font description when writing-mode is being specified.
  • loader/CachedFont.cpp: (WebCore::CachedFont::platformDataFromCustomData): Made to pass font orientation to FontPlatformData.
  • loader/CachedFont.h:
  • platform/graphics/FontCache.cpp: Added font orientation to FontPlatformDataCacheKey (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::computeHash): (WebCore::FontCache::getCachedFontPlatformData):
  • platform/graphics/FontDescription.h: Added font orientation support to FontDescription class (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::orientation): (WebCore::FontDescription::setOrientation): (WebCore::FontDescription::operator==):
  • platform/graphics/FontOrientation.h: Added.
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cairo/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/cairo/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/cocoa/FontPlatformData.h: Added font orientation support to FontPlatformData class (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::orientation): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: Added font orientation support (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::allowsLigatures): Don't allow ligatures when the font is vertical orientation. (WebCore::FontPlatformData::description):
  • platform/graphics/gtk/FontCustomPlatformDataPango.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/haiku/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/haiku/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/mac/FontCacheMac.mm: Added font orientation parameter when creating FontPlatformData object. (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.cpp: Added font orientation parameter when creating FontPlatformData object. (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.h: Changed to pass font orientation parameter to fontPlatformData()
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp: (WebCore::GlyphPage::fill): Changed to use CoreText to extract glyphs when the current font is vertical orientation. CoreText automatically swaps glyphs with vertical variants when the font orientation is vertical.
  • platform/graphics/mac/SimpleFontDataCoreText.cpp: Added vertical form attribute to the attribute dictionary for a CTLine. (WebCore::SimpleFontData::getCFStringAttributes):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformBoundsForGlyph): Changed to use CoreText (from CG) to support vertical metrics. (WebCore::SimpleFontData::platformWidthForGlyph): Made to use CoreText, instead of wkGetGlyphTransformedAdvances, to get vertical metrics when the font orientation is vertical.
  • platform/graphics/qt/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/qt/FontCustomPlatformDataQt.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/skia/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/skia/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/win/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/win/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/win/FontCustomPlatformDataCairo.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/win/FontCustomPlatformDataCairo.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/wince/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/wince/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/wx/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/wx/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
10:53 AM Changeset in webkit [70249] by jamesr@google.com
  • 1 edit
    44 adds in trunk/LayoutTests

2010-10-21 James Robinson <jamesr@chromium.org>

Add chromium pixel baselines for new SVG length tests.

  • platform/chromium-linux/svg/dom/SVGLengthList-appendItem-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-appendItem-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-getItem-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-getItem-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-initialize-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-initialize-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-removeItem-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-removeItem-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-replaceItem-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-appendItem-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-appendItem-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-basics-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-basics-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-getItem-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-getItem-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-initialize-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-initialize-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-removeItem-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-removeItem-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-replaceItem-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
10:20 AM Changeset in webkit [70248] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2010-10-21 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Fixed inspector extensions test expectations.

  • inspector/extensions-api-expected.txt:
  • inspector/extensions-resources-expected.txt:
10:04 AM Changeset in webkit [70247] by Adam Roben
  • 4 edits
    1 add in trunk

Ask the UI client to close the page when the WKView receives a WM_CLOSE message

Fixes <http://webkit.org/b/48044> <rdar://problem/8488446> Pressing
Ctrl+W when viewing a full-page PDF destroys the WKView but doesn't
close its parent window

Reviewed by Jon Honeycutt.

WebKit2:

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::wndProc): Call through to WebPageProxy::tryClose when
we receive a WM_CLOSE message, rather than passing the message along to
::DefWindowProcW. tryClose will end up asking the UI client to close
the page, while ::DefWindowProcW would destroy us synchronously without
notifying the UI client at all. One case where we'll get sent a
WM_CLOSE message is when the user presses Ctrl+W when using the Adobe
Reader plugin to view a PDF.

WebKitTools:

Test that the UI client gets notified when WKView receives a WM_CLOSE message

  • TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Added.

(TestWebKitAPI::close): Record that this function was called.
(TestWebKitAPI::WebKit2_WMCloseCallsUIClientClose): Create a WKView,
send it a WM_CLOSE message, and test that the UI client's close
callback got called. Note that this will hang if the bug is
reintroduced; <http://webkit.org/b/48043> covers making TestWebKitAPI
able to handle hangs.

  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
10:03 AM Changeset in webkit [70246] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make prepare-ChangeLog much faster when using git

This change also seems to make it detect renames better in some cases.

Fixes <http://webkit.org/b/48040> prepare-ChangeLog is slow when using
git

Reviewed by David Kilzer.

  • Scripts/prepare-ChangeLog:

(statusCommand):
(createPatchCommand):
Use "-M -C" instead of "-C -C -M" to tell git-diff to detect renames
and copies. The two "-C"s were making it read many more files than were
necessary.

10:03 AM Changeset in webkit [70245] by Adam Roben
  • 5 edits in trunk/WebKit2

Remove confusing and redundant "host window" terminology from WKView on Windows

WKView's "host window" is really just its HWND's parent window. The
terminology has been updated to reflect this. The unnecessary
WKViewGetHostWindow function has been removed, as it was a synonym for
::GetParent(WKViewGetWindow(view)).

Fixes <http://webkit.org/b/48039> WKView's "host window" API is
confusing

Reviewed by Sam Weinig.

  • UIProcess/API/C/win/WKView.cpp:

(WKViewCreate):
(WKViewSetParentWindow):

  • UIProcess/API/C/win/WKView.h:

Replaced "host window" with "parent window". Removed
WKViewGetHostWindow.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::setParentWindow):
(WebKit::WebView::windowAncestryDidChange):
(WebKit::WebView::close):

  • UIProcess/win/WebView.h:

(WebKit::WebView::create):
Replaced "host window" with "parent window". Removed m_hostWindow and
hostWindow().

9:45 AM Changeset in webkit [70244] by weinig@apple.com
  • 11 edits
    2 adds in trunk

Null frame passed when running alert from UserScript run at document start
<rdar://problem/8573809>
https://bugs.webkit.org/show_bug.cgi?id=48036

Reviewed by Adam Roben.

WebKit2:

Don't initialize a Frame until after we have notified the UIProcess of its creation.
This is necessary since arbitrary actions can happen during the call to Frame::init()
such as the running of UserScripts.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createFrame):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::create):
(WebKit::WebFrame::WebFrame):
(WebKit::WebFrame::init):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

WebKitTools:

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • TestWebKitAPI/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::didReceiveMessage):
(TestWebKitAPI::InjectedBundleController::initializeTestNamed):

  • TestWebKitAPI/InjectedBundleController.h:
  • TestWebKitAPI/InjectedBundleTest.h:

(TestWebKitAPI::InjectedBundleTest::initialize):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Added.

(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Added.

(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::DocumentStartUserScriptAlertCrashTest):
(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
Add test for invoking an alert during a UserScript run at document start.

9:44 AM Changeset in webkit [70243] by Adam Roben
  • 2 edits in trunk/LayoutTests

Unskip plugins/pass-different-npp-struct.html on SnowLeopard

The test seems to be passing when run manually on the bots.

  • platform/mac/Skipped:
9:44 AM Changeset in webkit [70242] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKitTools

2010-10-21 Andreas Kling <kling@webkit.org>

Reviewed by Adam Roben.

TestNetscapePlugIn: Actually call NPP_SetWindow on Unix

We were just returning NPERR_NO_ERROR previously.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_set_window):
9:38 AM Changeset in webkit [70241] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

<http://webkit.org/b/48051> Move macros from DumpRenderTreeMac.h to config.h

Reviewed by Adam Roben.

  • DumpRenderTree/config.h: Moved macros to here...
  • DumpRenderTree/mac/DumpRenderTreeMac.h: ...from here.

Addresses a FIXME comment from r28419.

9:31 AM Changeset in webkit [70240] by pfeldman@chromium.org
  • 15 edits
    1 add in trunk/WebCore

2010-10-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide resource tree in the Storage panel (behind the flag).
https://bugs.webkit.org/show_bug.cgi?id=48069

  • WebCore.gypi:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::frameDetachedFromParent):
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForDocumentLoader): (WebCore::buildObjectForFrameResource): (WebCore::buildObjectForCachedResource): (WebCore::populateObjectWithFrameResources): (WebCore::InspectorResourceAgent::identifierForInitialRequest): (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): (WebCore::buildObjectForFrameTree): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::InspectorResourceAgent::cachedResources): (WebCore::InspectorResourceAgent::resourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/Images/frame.png: Added.
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refreshResource): (WebInspector.NetworkPanel.prototype._showResource):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.getContents):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager): (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype._createResource): (WebInspector.ResourceManager.prototype.willSendRequest): (WebInspector.ResourceManager.prototype._appendRedirect): (WebInspector.ResourceManager.prototype.markResourceAsCached): (WebInspector.ResourceManager.prototype.didReceiveResponse): (WebInspector.ResourceManager.prototype._updateResourceWithResponse): (WebInspector.ResourceManager.prototype.didReceiveContentLength): (WebInspector.ResourceManager.prototype.didFinishLoading): (WebInspector.ResourceManager.prototype.didFailLoading): (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.ResourceManager.prototype._updateResourceWithCachedResource): (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceManager.prototype.didCommitLoadForFrame): (WebInspector.ResourceManager.prototype.frameDetachedFromParent): (WebInspector.ResourceManager.prototype._clearResources): (WebInspector.ResourceManager.prototype.didCreateWebSocket): (WebInspector.ResourceManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.ResourceManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.ResourceManager.prototype.didCloseWebSocket): (WebInspector.ResourceManager.prototype._processCachedResources): (WebInspector.ResourceManager.prototype._appendFramesRecursively.comparator): (WebInspector.ResourceManager.prototype._appendFramesRecursively): (WebInspector.ResourceManager.createResourceView): (WebInspector.ResourceManager.resourceViewTypeMatchesResource): (WebInspector.ResourceManager.resourceViewForResource): (WebInspector.ResourceManager.getContents):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get searchableViews): (WebInspector.ResourcesPanel.prototype.addMessageToResource): (WebInspector.ResourcesPanel.prototype._recreateViewForResourceIfNeeded): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype.sourceFrameForResource):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.addFrame): (WebInspector.StoragePanel.prototype.removeFrame): (WebInspector.StoragePanel.prototype.addFrameResource): (WebInspector.StoragePanel.prototype.removeFrameResources): (WebInspector.StoragePanel.prototype.showResource): (WebInspector.BaseStorageTreeElement.prototype.onattach): (WebInspector.BaseStorageTreeElement.prototype.onreveal): (WebInspector.FrameTreeElement): (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameResourceTreeElement): (WebInspector.FrameResourceTreeElement.prototype.onselect): (WebInspector.FrameResourceTreeElement.prototype.onattach):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.frame-storage-tree-item .icon): (.storage.panel .sidebar.outline-disclosure > ol): (.resources-category-images .image-resource-icon-preview): (.children.small .resources-category-images .image-resource-icon-preview):
  • inspector/front-end/inspector.js:
9:21 AM Changeset in webkit [70239] by ddkilzer@apple.com
  • 8 edits in trunk

<http://webkit.org/b/48047> Fix warnings found by check-Xcode-source-file-types

Reviewed by Adam Roben.

WebCore:

Fixes the following warning:

WARNING: Unknown file type 'sourcecode' for file 'CSSPrimitiveValue.idl'.
1 issues found for WebCore/WebCore.xcodeproj/project.pbxproj.

  • WebCore.xcodeproj/project.pbxproj: Removed explicit file type

for CSSPrimitiveValue.idl to make it match other IDL files.

WebKit:

Fixes the following warning:

WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'WebStringTruncator.h'.
1 issues found for WebKit/WebKit.xcodeproj/project.pbxproj.

  • WebKit.xcodeproj/project.pbxproj: Removed explicit file type

for WebStringTruncator.h to make it match other header files.

WebKitTools:

Fixes the following warnings:

WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'PixelDumpSupport.cpp'.
WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'LayoutTestController.cpp'.
WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'WorkQueue.cpp'.
WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'cg/PixelDumpSupportCG.cpp'.
WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'GCController.cpp'.
5 issues found for WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Removed explicit file type for *.cpp files above to make them
match other C++ source files. This exposed the fact that
DumpRenderTreeMac.h was not safe to include in C++ source, which
caused PixelDumpSupport.cpp and PixelDumpSupportCG.cpp to fail
to build.

  • DumpRenderTree/PixelDumpSupport.cpp: Adjusted header order.
  • DumpRenderTree/mac/DumpRenderTreeMac.h: Made safe to include

in C++ source files. Included CoreFoundation/CoreFoundation.h
to make sure all CF types were defined. Removed CFStringRef
typedef.

9:11 AM Changeset in webkit [70238] by Adam Roben
  • 4 edits in trunk

Attempt to fix plugins/pass-different-npp-struct.html on GTK.

See <http://webkit.org/b/47690>.

LayoutTests:

  • platform/gtk/Skipped: Stop skipping this test.

WebKitTools:

  • GNUmakefile.am: Added PassDifferentNPPStruct.cpp.
8:51 AM Changeset in webkit [70237] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-21 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt] PluginInfoStore does not set up mime types for plugins
https://bugs.webkit.org/show_bug.cgi?id=48063

  • UIProcess/Plugins/qt/PluginInfoStoreQt.cpp: (WebKit::PluginInfoStore::getPluginInfo): Store the mime types that are supported by the plugin into the plugin argument.
8:33 AM Changeset in webkit [70236] by andreas.kling@nokia.com
  • 1 edit
    3 adds
    2 deletes in trunk/LayoutTests

2010-10-21 Andreas Kling <kling@webkit.org>

Reviewed by Nikolas Zimmermann.

'transparent' should be a valid color
https://bugs.webkit.org/show_bug.cgi?id=45482

Reworked testcase to use SVG animation testing framework.

  • svg/animations/animate-color-transparent-expected.txt: Added.
  • svg/animations/animate-color-transparent.html: Added.
  • svg/animations/script-tests/animate-color-transparent.js: Added.
  • svg/animations/svg-animate-color-transparent-expected.txt: Removed.
  • svg/animations/svg-animate-color-transparent.svg: Removed.
6:58 AM Changeset in webkit [70235] by yurys@chromium.org
  • 26 edits
    1 copy
    7 moves
    3 deletes in trunk/WebCore

2010-10-21 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert r70232. Chromium compilation failure.

6:42 AM QtBackLog edited by Ademar Reis
(diff)
6:40 AM QtWebKitWeeklyBuilds edited by Ademar Reis
(diff)
6:39 AM Changeset in webkit [70234] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-10-21 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert r70233 and r70232. Too many failures.

5:56 AM Changeset in webkit [70233] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-10-21 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Remove references to deleted headers from WebCore.pro

  • WebCore.pro:
5:31 AM Changeset in webkit [70232] by yurys@chromium.org
  • 26 edits
    4 copies
    6 moves
    2 deletes in trunk/WebCore

2010-10-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: decouple ScriptArguments from ScriptCallStack
https://bugs.webkit.org/show_bug.cgi?id=48058

ScriptCallFrame and ScriptCallStack are now the same for both JSC and V8.
The factory functions that allow to create ScriptCallStack from VM-specific
objects are defined in ScriptCallStackFactory.cpp.

ScriptArguments class is used for passing arguments from JS code to the native
part.

No new tests. This refactoring is covered with existing Console tests.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptCallFrame.cpp: Removed.
  • bindings/js/ScriptCallFrame.h: Removed.
  • bindings/js/ScriptCallStack.cpp: Removed.
  • bindings/js/ScriptCallStack.h: Removed.
  • bindings/js/ScriptCallStackFactory.cpp: Added. (WebCore::createScriptCallStack): (WebCore::createScriptArguments): (WebCore::ScriptCallStack::stackTrace):
  • bindings/js/ScriptCallStackFactory.h: Added.
  • bindings/js/ScriptState.h: (WebCore::ScriptStateProtectedPtr::get):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptCallFrame.cpp: Removed.
  • bindings/v8/ScriptCallFrame.h: Removed.
  • bindings/v8/ScriptCallStack.cpp: Removed.
  • bindings/v8/ScriptCallStack.h: Removed.
  • bindings/v8/ScriptCallStackFactory.cpp: Added. (WebCore::toScriptCallFrame): (WebCore::toScriptCallFramesVector): (WebCore::createScriptCallStack): (WebCore::createScriptArguments): (WebCore::ScriptCallStack::stackTrace):
  • bindings/v8/ScriptCallStackFactory.h: Added.
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
  • bindings/v8/ScriptState.h: (WebCore::ScriptStateProtectedPtr::get):
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler): (WebCore::V8ConsoleMessage::dispatchNow):
  • bindings/v8/V8ConsoleMessage.h:
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::traceCallback): (WebCore::V8Console::assertCallback):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup):
  • inspector/InspectorController.h:
  • inspector/ScriptArguments.cpp: Added. (WebCore::ScriptArguments::ScriptArguments): (WebCore::ScriptArguments::~ScriptArguments): (WebCore::ScriptArguments::argumentAt): (WebCore::ScriptArguments::globalState): (WebCore::ScriptArguments::getFirstArgumentAsString): (WebCore::ScriptArguments::isEqual):
  • inspector/ScriptArguments.h: Added. (WebCore::ScriptArguments::argumentCount):
  • inspector/ScriptCallFrame.cpp: Added. (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::~ScriptCallFrame): (WebCore::ScriptCallFrame::isEqual): (WebCore::ScriptCallFrame::buildInspectorObject):
  • inspector/ScriptCallFrame.h: Added. (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber):
  • inspector/ScriptCallStack.cpp: Added. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::isEqual): (WebCore::ScriptCallStack::buildInspectorObject):
  • inspector/ScriptCallStack.h: Added.
  • page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::debug): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::dirxml): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::count): (WebCore::Console::markTimeline): (WebCore::Console::profile): (WebCore::Console::profileEnd): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed): (WebCore::Console::shouldCaptureFullStackTrace): (WebCore::Console::warn):
  • page/Console.h:
5:19 AM Changeset in webkit [70231] by pfeldman@chromium.org
  • 4 edits in trunk

2010-10-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: use dedicated event listener type in EventListenerWrapper.
https://bugs.webkit.org/show_bug.cgi?id=48059

This change introduces new EventListener::Type NativeEventListenerType.
This new type is intended to be used by any code that wants to protect
itself from unsafe casts to particular event listener implementations.

  • dom/EventListener.h:

2010-10-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: use dedicated event listener type in EventListenerWrapper.
https://bugs.webkit.org/show_bug.cgi?id=48059

  • src/EventListenerWrapper.cpp: (WebKit::EventListenerWrapper::EventListenerWrapper):
4:43 AM Changeset in webkit [70230] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-21 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[NRWT] Set ImageDiff path on Qt port
https://bugs.webkit.org/show_bug.cgi?id=48052

  • Scripts/webkitpy/layout_tests/port/qt.py:
4:37 AM Changeset in webkit [70229] by commit-queue@webkit.org
  • 36 edits
    7 deletes in trunk

2010-10-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70225.
http://trac.webkit.org/changeset/70225
https://bugs.webkit.org/show_bug.cgi?id=48061

Build breakage on Leopard. (Requested by pfeldman on #webkit).

  • fast/text/international/vertical-text-glyph-test.html: Removed.
  • fast/text/international/vertical-text-metrics-test.html: Removed.
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.checksum: Removed.
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.png: Removed.
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
  • platform/mac/fast/text/international/vertical-text-metrics-test-expected.txt: Removed.

2010-10-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70225.
http://trac.webkit.org/changeset/70225
https://bugs.webkit.org/show_bug.cgi?id=48061

Build breakage on Leopard. (Requested by pfeldman on #webkit).

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • loader/CachedFont.cpp: (WebCore::CachedFont::platformDataFromCustomData):
  • loader/CachedFont.h:
  • platform/graphics/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::computeHash): (WebCore::FontCache::getCachedFontPlatformData):
  • platform/graphics/FontDescription.h: (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::operator==):
  • platform/graphics/FontOrientation.h: Removed.
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cairo/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/cairo/FontCustomPlatformData.h:
  • platform/graphics/cocoa/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::allowsLigatures): (WebCore::FontPlatformData::description):
  • platform/graphics/gtk/FontCustomPlatformDataPango.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/haiku/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/haiku/FontCustomPlatformData.h:
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.h:
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp: (WebCore::GlyphPage::fill):
  • platform/graphics/mac/SimpleFontDataCoreText.cpp: (WebCore::SimpleFontData::getCFStringAttributes):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformBoundsForGlyph): (WebCore::SimpleFontData::platformWidthForGlyph):
  • platform/graphics/qt/FontCustomPlatformData.h:
  • platform/graphics/qt/FontCustomPlatformDataQt.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/skia/FontCustomPlatformData.h:
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/win/FontCustomPlatformData.h:
  • platform/graphics/win/FontCustomPlatformDataCairo.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/win/FontCustomPlatformDataCairo.h:
  • platform/graphics/wince/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/wince/FontCustomPlatformData.h:
  • platform/graphics/wx/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/wx/FontCustomPlatformData.h:
4:26 AM Changeset in webkit [70228] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't CC authors of flaky tests
https://bugs.webkit.org/show_bug.cgi?id=48038

Some authors found this too annoying. We'll look for another way to
close the flaky test loop.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
4:26 AM Changeset in webkit [70227] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-21 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Tests LayoutTests/fast/encoding/utf-32* fail when using glib unicode
https://bugs.webkit.org/show_bug.cgi?id=47805

Register UTF-32 encodings in TextCodecGtk.

  • platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerBaseEncodingNames): (WebCore::TextCodecGtk::registerBaseCodecs):
4:04 AM Changeset in webkit [70226] by commit-queue@webkit.org
  • 1 edit
    13 adds in trunk/WebCore

2010-10-21 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Darin Adler.

Adding MediaQueryListListener binding test cases
https://bugs.webkit.org/show_bug.cgi?id=48028

MediaQueryListListener type will need special handling of the code generators. Adding the test cases.

  • bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp: Added. (WebDOMTestMediaQueryListListener::WebDOMTestMediaQueryListListenerPrivate::WebDOMTestMediaQueryListListenerPrivate): (WebDOMTestMediaQueryListListener::WebDOMTestMediaQueryListListener): (WebDOMTestMediaQueryListListener::operator=): (WebDOMTestMediaQueryListListener::impl): (WebDOMTestMediaQueryListListener::~WebDOMTestMediaQueryListListener): (WebDOMTestMediaQueryListListener::method): (toWebCore): (toWebKit):
  • bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp: Added. (WebKit::kit): (webkit_dom_test_media_query_list_listener_method): (WebKit::core): (webkit_dom_test_media_query_list_listener_finalize): (webkit_dom_test_media_query_list_listener_set_property): (webkit_dom_test_media_query_list_listener_get_property): (webkit_dom_test_media_query_list_listener_constructed): (webkit_dom_test_media_query_list_listener_class_init): (webkit_dom_test_media_query_list_listener_init): (WebKit::wrapTestMediaQueryListListener):
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h: Added.
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Added. (WebCore::JSTestMediaQueryListListenerConstructor::classInfo): (WebCore::JSTestMediaQueryListListenerConstructor::createStructure): (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor): (WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlot): (WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertyDescriptor): (WebCore::JSTestMediaQueryListListenerPrototype::self): (WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot): (WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor): (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener): (WebCore::JSTestMediaQueryListListener::~JSTestMediaQueryListListener): (WebCore::JSTestMediaQueryListListener::createPrototype): (WebCore::JSTestMediaQueryListListener::getOwnPropertySlot): (WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor): (WebCore::jsTestMediaQueryListListenerConstructor): (WebCore::JSTestMediaQueryListListener::getConstructor): (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod): (WebCore::toJS): (WebCore::toTestMediaQueryListListener):
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h: Added. (WebCore::JSTestMediaQueryListListener::classInfo): (WebCore::JSTestMediaQueryListListener::createStructure): (WebCore::JSTestMediaQueryListListener::impl): (WebCore::JSTestMediaQueryListListenerPrototype::classInfo): (WebCore::JSTestMediaQueryListListenerPrototype::createStructure): (WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
  • bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.h: Added.
  • bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.mm: Added. (-[DOMTestMediaQueryListListener dealloc]): (-[DOMTestMediaQueryListListener finalize]): (-[DOMTestMediaQueryListListener method:]): (core): (kit):
  • bindings/scripts/test/ObjC/DOMTestMediaQueryListListenerInternal.h: Added.
  • bindings/scripts/test/TestMediaQueryListListener.idl: Added.
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Added. (WebCore::TestMediaQueryListListenerInternal::V8_USE): (WebCore::TestMediaQueryListListenerInternal::methodCallback): (WebCore::ConfigureV8TestMediaQueryListListenerTemplate): (WebCore::V8TestMediaQueryListListener::GetRawTemplate): (WebCore::V8TestMediaQueryListListener::GetTemplate): (WebCore::V8TestMediaQueryListListener::HasInstance): (WebCore::V8TestMediaQueryListListener::wrapSlow): (WebCore::V8TestMediaQueryListListener::derefObject):
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Added. (WebCore::V8TestMediaQueryListListener::toNative): (WebCore::V8TestMediaQueryListListener::wrap): (WebCore::toV8):
3:42 AM Changeset in webkit [70225] by commit-queue@webkit.org
  • 36 edits
    7 adds in trunk

2010-10-21 takano takumi <takano1@asia.apple.com>

Reviewed by Dan Bernstein.

Need to swap glyphs for vertical writing
https://bugs.webkit.org/show_bug.cgi?id=46973

  • fast/text/international/vertical-text-glyph-test.html: Added.
  • fast/text/international/vertical-text-metrics-test.html: Added.
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.checksum: Added.
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.png: Added.
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/mac/fast/text/international/vertical-text-metrics-test-expected.txt: Added.

2010-10-21 takano takumi <takano1@asia.apple.com>

Reviewed by Dan Bernstein.

Need to swap glyphs for vertical writing
https://bugs.webkit.org/show_bug.cgi?id=46973

Made changes to pass the writing-mode orientation flag in RenderStyle down to FontPlatformData,
and ultimately to CoreText APIs in both font complex path and fast path.

Tests: fast/text/international/vertical-text-glyph-test.html

fast/text/international/vertical-text-metrics-test.html

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj: Added platform/graphics/FontOrientation.h.
  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData): Added font orientation parameter to SimpleFontData.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Set appropriate font orientation to the font description when writing-mode is being specified.
  • loader/CachedFont.cpp: (WebCore::CachedFont::platformDataFromCustomData): Made to pass font orientation to FontPlatformData.
  • loader/CachedFont.h:
  • platform/graphics/FontCache.cpp: Added font orientation to FontPlatformDataCacheKey (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::computeHash): (WebCore::FontCache::getCachedFontPlatformData):
  • platform/graphics/FontDescription.h: Added font orientation support to FontDescription class (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::orientation): (WebCore::FontDescription::setOrientation): (WebCore::FontDescription::operator==):
  • platform/graphics/FontOrientation.h: Added.
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cairo/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/cairo/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/cocoa/FontPlatformData.h: Added font orientation support to FontPlatformData class (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::orientation): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: Added font orientation support (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::allowsLigatures): Don't allow ligatures when the font is vertical orientation. (WebCore::FontPlatformData::description):
  • platform/graphics/gtk/FontCustomPlatformDataPango.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/haiku/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/haiku/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/mac/FontCacheMac.mm: Added font orientation parameter when creating FontPlatformData object. (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.cpp: Added font orientation parameter when creating FontPlatformData object. (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.h: Changed to pass font orientation parameter to fontPlatformData()
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp: (WebCore::GlyphPage::fill): Changed to use CoreText to extract glyphs when the current font is vertical orientation. CoreText automatically swaps glyphs with vertical variants when the font orientation is vertical.
  • platform/graphics/mac/SimpleFontDataCoreText.cpp: Added vertical form attribute to the attribute dictionary for a CTLine. (WebCore::SimpleFontData::getCFStringAttributes):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformBoundsForGlyph): Changed to use CoreText (from CG) to support vertical metrics. (WebCore::SimpleFontData::platformWidthForGlyph): Made to use CoreText, instead of wkGetGlyphTransformedAdvances, to get vertical metrics when the font orientation is vertical.
  • platform/graphics/qt/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/qt/FontCustomPlatformDataQt.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/skia/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/skia/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/win/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/win/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/win/FontCustomPlatformDataCairo.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/win/FontCustomPlatformDataCairo.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/wince/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/wince/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
  • platform/graphics/wx/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData() (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/wx/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
3:33 AM Changeset in webkit [70224] by jparent@chromium.org
  • 3 edits in trunk/LayoutTests

2010-10-21 Julie Parent <jparent@chromium.org>

Reviewed by Tony Chang.

[Chromium] fast/repaint/renderer-destruction-by-invalidateSelection-crash needs image rebaseline for linux
https://bugs.webkit.org/show_bug.cgi?id=48009

Was incorrectly rebaselined in r61912 (massive rebaseline for
scrollbar changes, but this test has no scrollbars).

  • platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
  • platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
3:25 AM Changeset in webkit [70223] by Nikolas Zimmermann
  • 43 edits
    60 adds in trunk

2010-10-20 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Redesign SVGAnimatedProperty concept to share "POD type wrappers" between all bindings (-> add ObjC SVG bindings)
https://bugs.webkit.org/show_bug.cgi?id=47905

Tests: svg/dom/SVGLengthList-appendItem.xhtml

svg/dom/SVGLengthList-basics.xhtml
svg/dom/SVGLengthList-getItem.xhtml
svg/dom/SVGLengthList-initialize.xhtml
svg/dom/SVGLengthList-insertItemBefore.xhtml
svg/dom/SVGLengthList-removeItem.xhtml
svg/dom/SVGLengthList-replaceItem.xhtml
svg/dom/SVGLengthList-xml-dom-modifications.xhtml

Introduce a more lightweight, less intrusive way to expose SVGAnimated* DOM bindings.

Concrete example:
The SVG DOM defines a 'SVGAnimatedLength' object, that's used to represent the x / y / width / height attributes of a 'SVGRectElement'.
Each 'SVGAnimatedLength' object exposes a baseVal (markup defined attribute value) and an animVal (reflects the current state during animations),
both of type 'SVGLength'. These objects are all _live_. That means you can do:
var foobar = rect.x.baseVal; foobar.value += 150;

If we'd implement the SVG DOM straightforward, we'd have to store a refcounted SVGAnimatedLength object, containing two refcounted SVGLength objects
in SVGRectElement, for each of the x/y/width/height attributes. Our solution, to reduce memory footprint and increase performance is to store
SVGLength stack-allocated, non refcounted types in SVGRectElement for x/y/width/height, and don't implement the SVGAnimatedLength object at all.

In the past the JS bindings had to expose wrappers for SVGAnimatedLength on their own, and wrap each SVGLength object in an object called JSSVGPODTypeWrapper<SVGLength>.
When JS changed the 'value' of the 'SVGLength', we constructed a copy of the SVGLength object, modified it, and called rectElement->setXBaseValue(newLength).
This is not efficient at all, as we have to construct several copies of the SVGLength object, utilize callbacks to propagate the value changes in the SVG DOM.
Furthermore, all bindings had to expose a similar concept, otherwhise SVG DOM wouldn't work. Up until now, only JSC and V8 bindings were available, that worked properly.

The new SVGAnimatedProperty concept removes the need for JSSVGPODTypeWrapper (and friends like JSSVGContextCache, that associated a SVGLength with its SVGRectElement).
Instead a solution is offered, that all bindings can use simultaneously, without adding new types or special concepts like JSSVGPODTypeWrapper.

It works like this:
A new refcounted SVGAnimatedProperty<PropertyType> template class is available, that stores a QualifiedName to associate the SVG DOM property with a XML DOM attribute.
It also stores a RefPtr to the SVGElement that created it.


In SVGRectElement we still store SVGLength m_x/m_y/m_width/m_height members, and offer a new "xAnimated()" method which looks up or creates a SVGAnimatedProperty<SVGLength>
object. The JS/V8/ObjC bindings call this method whenever someone requests "rect.x/y/width/height", and a new wrapper is created, and stored in a HashMap.

The SVGAnimatedProperty<PropertyType> is a base class for SVGAnimatedPropertyTearOff and SVGAnimatedListPropertyTearOff, the latter is used for all types of lists (SVGLengthList).
SVGAnimatedProperty contains two methods used in the bindings: SVGProperty* baseVal and SVGProperty* animVal. SVGProperty is a base class for SVGPropertyTearOff and
SVGListPropertyTearOff. Upon invocation of the baseVal/animVal methods a new SVG(List)PropertyTearOff object is created and stored in a RefPtr.
The SVGPropertyTearOff objects stores a _reference_ to the type it wraps. Concrete example:
When calling rect.x, a SVGAnimatedPropertyTearOff<SVGLength> is created, that stores a pointer to the SVGRectElement, and a SVGNames::xAttr.
When calling rect.x.baseVal, a SVGPropertyTearOf<SVGLength> is created, that stores a reference to the "m_x" member variable of the SVGRectElement.
Any changes applied to the SVGLength object, through the wrapper, are immediately live, as no copies are involved anymore, nor the need to fire any callback methods.
This is the key concept of the new tear offs, no copies, no callbacks, no virtual methods (except one, needed for lists, but it's a detail).

The SVGAnimatedListPropertyTearOff and SVGListPropertyTearOff work the same, but for SVG*List objects. The whole SVG*List API is _removed_ from the SVG DOM classes
like SVGLengthList. It now inherits from Vector<SVGLength>, where it used to store a Vector<RefPtr<SVGListItem<SVGLength> > >. The SVGList API (insertItemBefore, appendItem, etc.)
is exposed through SVGListPropertyTearOff, and there's no need anymore for SVGLengthList to deal with it at all.
SVGLengthList is live just like most other SVG DOM object. Concrete example:
var item0 = text.x.baseVal.getItem(0); item0.value += 150;

Previously we chose to store a refcounted SVGListItem object, which wrapped the SVGLength object, to achieve liveness. We could change a single list item from DOM
w/o copying the whole list. The drawback is that a simple type likeSVGLengthList, was heavy to store, as it contained a list of RefPtrs around a wrapper object
around the real object 'SVGLength'. This complexity is completly gone.

The SVGListPropertyTearOff<SVGLengthList> stores a reference to the SVGLengthList object (eg. SVGTextElement::m_x) and maintains a list of SVGPropertyTearOff<SVGLength>
wrappers, that are created when necessary (getItem(2), will create a wrapper around the third list item), and cached. These SVGPropertyTearOff<SVGLength> objects
store references to the SVGLength object _in the SVGLengthList_. One has to be extra carefully, to keep those lists synchronized.
The SVGLengthList API is fully implemented for the first time, including moving items between lists, and is extensively tested with 8 new testcases.

This patch only changed SVGLength/SVGLengthList to the new concept. All other types remain using the old DeprecatedSVGAnimatedProperty* concept.
This will change in follow-up patches.

  • GNUmakefile.am: Add new files from svg/properties to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSSVGLengthCustom.cpp: Adapt to context cache removal for SVGLength. (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/scripts/CodeGenerator.pm: Add new isSVGNewStyleAnimatedProperty() helper method, return true for "SVGAnimatedLength" and "SVGAnimatedLengthList".
  • bindings/scripts/CodeGeneratorJS.pm: Generate new style SVG JS bindings, that don't need JSSVGContextCache / JSSVGPODTypeWrapper.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto. (+ Finally expose a working set of SVG DOM API for Objective C).
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • bindings/v8/custom/V8SVGLengthCustom.cpp: Adapt to context cache removal for SVGLength. (WebCore::V8SVGLength::valueAccessorGetter): (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGLengthList): SVGLengthList is a POD type now, passed as const reference.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove handling for SVGLength/SVGLengthList, those are converted to the new SVGAnimatedProperty design now.
  • svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
  • svg/SVGAnimatedLength.h: Added.
  • svg/SVGAnimatedLength.idl: Mark as [SVGAnimatedProperty].
  • svg/SVGAnimatedLengthList.h: Added.
  • svg/SVGAnimatedLengthList.idl: Mark as [SVGAnimatedProperty].
  • svg/SVGCircleElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ until the transition to the new concept is finished.
  • svg/SVGCursorElement.h: Ditto.
  • svg/SVGEllipseElement.h: Ditto.
  • svg/SVGFilterElement.h: Ditto.
  • svg/SVGFilterPrimitiveStandardAttributes.h: Ditto.
  • svg/SVGForeignObjectElement.h: Ditto.
  • svg/SVGImageElement.h: Ditto.
  • svg/SVGLength.idl: Mark as [SVGProperty].
  • svg/SVGLengthList.cpp: Use Vector API (appendItem -> append). No need to ever use the SVGList API internally. SVGLengthList is a Vector<SVGLength> now. (WebCore::SVGLengthList::parse): (WebCore::SVGLengthList::valueAsString):
  • svg/SVGLengthList.h: Inherit from Vector<SVGLength> - not from the SVGList base class. It's a simple, non-refcounted POD type now. (WebCore::SVGLengthList::SVGLengthList):
  • svg/SVGLengthList.idl: Mark as [SVGListProperty].
  • svg/SVGLineElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ until the transition to the new concept is finished.
  • svg/SVGLinearGradientElement.h: Ditto.
  • svg/SVGMarkerElement.h: Ditto.
  • svg/SVGMaskElement.h: Ditto.
  • svg/SVGPatternElement.h: Ditto.
  • svg/SVGRadialGradientElement.h: Ditto.
  • svg/SVGRectElement.h: Ditto.
  • svg/SVGSVGElement.h: Ditto.
  • svg/SVGSVGElement.idl: Mark createSVGLength() as [SVGLiveProperty] - a wrapper for the returned object has to be created.
  • svg/SVGTextContentElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ until the transition to the new concept is finished.
  • svg/SVGTextPathElement.h: Ditto.
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::parseMappedAttribute): Detach wrappers pointing to the old x/y/dx/dy list, if the underlying list changes via XML DOM. (WebCore::listContainsRelativeValue): Adapt to SVGLengthList interface changes, it's a POD type now.
  • svg/SVGTextPositioningElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_LIST_PROPERTY_NEW/ until the transition to the new concept is finished.
  • svg/SVGUseElement.h:
  • svg/properties/SVGAnimatedListPropertyTearOff.h: Added.
  • svg/properties/SVGAnimatedProperty.h: Added. This is the base class for SVGAnimatedPropertyTearOff and SVGAnimatedListPropertyTearOff.
  • svg/properties/SVGAnimatedPropertyDescription.h: Added. Refactored from DeprecatedSVGAnimatedProperty.h.
  • svg/properties/SVGAnimatedPropertyMacros.h: Added. These macros will be _removed_ as soon as the transition to the new concept is finished.
  • svg/properties/SVGAnimatedPropertyTearOff.h: Added.
  • svg/properties/SVGListPropertyTearOff.h: Added.
  • svg/properties/SVGProperty.h: Added. This is the base class for SVGPropertyTearOff and SVGListPropertyTearOff.
  • svg/properties/SVGPropertyTearOff.h: Added.
  • svg/properties/SVGPropertyTraits.h: Added.

2010-10-20 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Redesign SVGAnimatedProperty concept to share "POD type wrappers" between all bindings (-> add ObjC SVG bindings)
https://bugs.webkit.org/show_bug.cgi?id=47905

Add extensive set of SVGLengthList tests, that all PASS now.

  • platform/mac-leopard/svg/dom: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-appendItem-expected.checksum: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-appendItem-expected.png: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-basics-expected.checksum: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-basics-expected.png: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-getItem-expected.checksum: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-getItem-expected.png: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-initialize-expected.checksum: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-initialize-expected.png: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-removeItem-expected.checksum: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-removeItem-expected.png: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-replaceItem-expected.checksum: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Added.
  • platform/mac-leopard/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
  • platform/mac/svg/dom/SVGLengthList-appendItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGLengthList-appendItem-expected.png: Added.
  • platform/mac/svg/dom/SVGLengthList-basics-expected.checksum: Added.
  • platform/mac/svg/dom/SVGLengthList-basics-expected.png: Added.
  • platform/mac/svg/dom/SVGLengthList-getItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGLengthList-getItem-expected.png: Added.
  • platform/mac/svg/dom/SVGLengthList-initialize-expected.checksum: Added.
  • platform/mac/svg/dom/SVGLengthList-initialize-expected.png: Added.
  • platform/mac/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Added.
  • platform/mac/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
  • platform/mac/svg/dom/SVGLengthList-removeItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGLengthList-removeItem-expected.png: Added.
  • platform/mac/svg/dom/SVGLengthList-replaceItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
  • platform/mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Added.
  • platform/mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
  • svg/dom/SVGLengthList-appendItem-expected.txt: Added.
  • svg/dom/SVGLengthList-appendItem.xhtml: Added.
  • svg/dom/SVGLengthList-basics-expected.txt: Added.
  • svg/dom/SVGLengthList-basics.xhtml: Added.
  • svg/dom/SVGLengthList-getItem-expected.txt: Added.
  • svg/dom/SVGLengthList-getItem.xhtml: Added.
  • svg/dom/SVGLengthList-initialize-expected.txt: Added.
  • svg/dom/SVGLengthList-initialize.xhtml: Added.
  • svg/dom/SVGLengthList-insertItemBefore-expected.txt: Added.
  • svg/dom/SVGLengthList-insertItemBefore.xhtml: Added.
  • svg/dom/SVGLengthList-removeItem-expected.txt: Added.
  • svg/dom/SVGLengthList-removeItem.xhtml: Added.
  • svg/dom/SVGLengthList-replaceItem-expected.txt: Added.
  • svg/dom/SVGLengthList-replaceItem.xhtml: Added.
  • svg/dom/SVGLengthList-xml-dom-modifications-expected.txt: Added.
  • svg/dom/SVGLengthList-xml-dom-modifications.xhtml: Added.
3:11 AM Changeset in webkit [70222] by jcivelli@chromium.org
  • 8 edits
    2 copies
    2 adds in trunk/WebKit/chromium

2010-10-21 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Adding an API that allows external
popup menus, without the use of WebCore::PopupMenuChromium.
Once this is hooked up in Chromium, the plan is to remove
entirely the external case from PopupMenuChromium.
https://bugs.webkit.org/show_bug.cgi?id=46016

  • WebKit.gyp:
  • public/WebExternalPopupMenu.h: Added.
  • public/WebExternalPopupMenuClient.h: Added.
  • public/WebMenuItemInfo.h: (WebKit::WebMenuItemInfo::WebMenuItemInfo):
  • public/WebView.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::createExternalPopupMenu):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createPopupMenu):
  • src/ExternalPopupMenu.cpp: Added.
  • src/ExternalPopupMenu.h: Added.
  • src/WebViewImpl.cpp: (WebKit::WebView::setUseExternalPopupMenus): (WebKit::WebViewImpl::useExternalPopupMenus):
  • src/WebViewImpl.h:
3:08 AM Changeset in webkit [70221] by commit-queue@webkit.org
  • 32 edits in trunk

2010-10-21 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Updated the tests results with changes from the new row layout algorithm.

  • mathml/presentation/row.xhtml:

Added an mrow to make the tests more consistent.

  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/fenced-mi-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.checksum:
  • platform/mac/mathml/presentation/sub-expected.png:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.txt:

2010-10-21 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Changed the layout algorithm for rows to avoid unnecessary recursion
into child rows. This solves the long rendering time experienced in
https://bugs.webkit.org/show_bug.cgi?id=43462 as well as reports in
various other bugs. The change in the algorithm required some
tweaks to other rendering objects to make sure that the baseline
alignment still works.

In addition, an attempt was made to go through the various
rendering objects for MathML and reduce unnecessary calls that
mark the tree in need of layout.

  • mathml/RenderMathMLFenced.cpp:
  • mathml/RenderMathMLFenced.h:
  • mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::layout):
  • mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::stretchToHeight):
  • mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::layout):
  • mathml/RenderMathMLRow.cpp: (WebCore::RenderMathMLRow::layout):
  • mathml/RenderMathMLRow.h: (WebCore::RenderMathMLRow::stretchToHeight):
  • mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::addChild): (WebCore::RenderMathMLSubSup::stretchToHeight): (WebCore::RenderMathMLSubSup::nonOperatorHeight): (WebCore::RenderMathMLSubSup::layout): (WebCore::RenderMathMLSubSup::baselinePosition):
  • mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::stretchToHeight): (WebCore::RenderMathMLUnderOver::layout): (WebCore::RenderMathMLUnderOver::nonOperatorHeight):
  • mathml/mathtags.in:
2:53 AM Changeset in webkit [70220] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should run run-webkit-tests with --no-new-test-results
https://bugs.webkit.org/show_bug.cgi?id=47998

  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
2:53 AM Changeset in webkit [70219] by evan@chromium.org
  • 2 edits in trunk/WebCore

2010-10-21 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

sqlite: show extended error codes in error logs
https://bugs.webkit.org/show_bug.cgi?id=47859

SQLite can provide "extended" error codes, where extra information
about the error is potentially encoded in the high bits of the error
code. It's only off by default in case older apps rely on equality
testing on the older error codes, which WebKit doesn't do.

  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open):
  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::step):
2:39 AM Changeset in webkit [70218] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk/WebKit2

2010-10-21 Juha Savolainen <juha.savolainen@weego.fi>

Reviewed by Kenneth Rohde Christiansen.

This is initial implementation of QWKHistory. The QWKHistory class represents the history of a QWKPage.
https://bugs.webkit.org/show_bug.cgi?id=47716

Each QWKPage instance contains a history of a visited pages that can be accessed by QWKHistory::history().
The QWKPagePrivate class creates QWKHistory in constructor.

  • UIProcess/API/qt/qwkhistory.cpp: Added. (QWKHistoryPrivate::QWKHistoryPrivate): (QWKHistoryPrivate::createHistory): Creates history object. (QWKHistoryPrivate::~QWKHistoryPrivate): (QWKHistory::QWKHistory): (QWKHistory::~QWKHistory): (QWKHistory::backListCount): Gets items count in back. (QWKHistory::forwardListCount): Gets items count in forward. (QWKHistory::count): Gets items count.
  • UIProcess/API/qt/qwkhistory.h: Added.
  • UIProcess/API/qt/qwkhistory_p.h: Added.
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::~QWKPagePrivate): (QWKPage::history): Returns history object.
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h: Added history member variable.
  • WebKit2.pro: Added WKBackForwardList.h, WKBackForwardList.cpp and new files.
2:35 AM Changeset in webkit [70217] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-21 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Ojan Vafai.

[NRWT] Get child process number from an environment variable
https://bugs.webkit.org/show_bug.cgi?id=47981

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:23 AM Changeset in webkit [70216] by yutak@chromium.org
  • 5 edits in trunk/WebCore

2010-10-21 Yuta Kitamura <yutak@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Handle WebSocket events via InspectorInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=47968

  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCreateWebSocketImpl): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didCreateWebSocket): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorInstrumentation::didCloseWebSocket):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): Now we do not depend on InspectorController to generate a resource identifier. (WebCore::WebSocketChannel::disconnect): Check if m_identifier is valid in case we could not obtain an identifier. (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer):
  • websockets/WebSocketChannel.h:
2:07 AM Changeset in webkit [70215] by alex
  • 2 edits in trunk/LayoutTests

2010-10-21 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip test failing in the GTK bots.
https://bugs.webkit.org/show_bug.cgi?id=47690

  • platform/gtk/Skipped:
1:44 AM Changeset in webkit [70214] by pfeldman@chromium.org
  • 8 edits in trunk/WebCore

2010-10-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Convert sidebar into the browsing tree in the Storage panel.
https://bugs.webkit.org/show_bug.cgi?id=47988

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addDatabase): (WebInspector.StoragePanel.prototype.addCookieDomain): (WebInspector.StoragePanel.prototype.addDOMStorage): (WebInspector.StoragePanel.prototype.addApplicationCache): (WebInspector.StoragePanel.prototype.showDatabase): (WebInspector.StoragePanel.prototype.showDOMStorage): (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.StoragePanel.prototype.showApplicationCache): (WebInspector.StoragePanel.prototype.showCategoryView): (WebInspector.StoragePanel.prototype._innerShowView): (WebInspector.BaseStorageTreeElement): (WebInspector.BaseStorageTreeElement.prototype.onattach): (WebInspector.StorageCategoryTreeElement): (WebInspector.StorageCategoryTreeElement.prototype.onselect): (WebInspector.DatabaseTreeElement): (WebInspector.DatabaseTreeElement.prototype.onselect): (WebInspector.DatabaseTreeElement.prototype.onpopulate.tableNamesCallback): (WebInspector.DatabaseTreeElement.prototype.onpopulate): (WebInspector.DatabaseTableTreeElement): (WebInspector.DatabaseTableTreeElement.prototype.onselect): (WebInspector.DOMStorageTreeElement): (WebInspector.DOMStorageTreeElement.prototype.onselect): (WebInspector.CookieTreeElement): (WebInspector.CookieTreeElement.prototype.onselect): (WebInspector.ApplicationCacheTreeElement): (WebInspector.ApplicationCacheTreeElement.prototype.onselect): (WebInspector.StorageCategoryView): (WebInspector.StorageCategoryView.prototype.setText):
  • inspector/front-end/inspector.css: (.properties-tree ol): (.properties-tree ol.expanded): (.database-storage-tree-item .icon): (.database-table-storage-tree-item .icon): (.domstorage-storage-tree-item.local-storage .icon): (.domstorage-storage-tree-item.session-storage .icon): (.cookie-storage-tree-item .icon): (.application-cache-storage-tree-item .icon): (.storage.panel .sidebar): (.storage.panel .outline-disclosure > ol): (.storage.panel .outline-disclosure li): (.storage.panel .outline-disclosure li .selection): (.storage.panel .sidebar-resizer-vertical): (.storage-base-tree-element-title): (.storage.panel .outline-disclosure ol): (.storage.panel .outline-disclosure li.selected): (.storage.panel .outline-disclosure .icon): (.storage-empty-view, .storage-view.table .storage-table-error):
1:42 AM Changeset in webkit [70213] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-21 Adam Barth <abarth@webkit.org>

Skip new test that's failing on Snow Leopard. Author of patch poked.
https://bugs.webkit.org/show_bug.cgi?id=47690

  • platform/mac/Skipped:
1:36 AM Changeset in webkit [70212] by abarth@webkit.org
  • 3 edits
    3 deletes in trunk

2010-10-21 Adam Barth <abarth@webkit.org>

Unreviewed, rolling out r70174.
http://trac.webkit.org/changeset/70174
https://bugs.webkit.org/show_bug.cgi?id=41948

This patch reverts a change that causes
http/tests/xmlhttprequest/origin-whitelisting-removal.html to crash.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::throwException):

2010-10-21 Adam Barth <abarth@webkit.org>

Unreviewed, rolling out r70174.
http://trac.webkit.org/changeset/70174
https://bugs.webkit.org/show_bug.cgi?id=41948

This patch reverts a change that causes
http/tests/xmlhttprequest/origin-whitelisting-removal.html to crash.

  • fast/js/exception-registerfile-shrink-expected.txt: Removed.
  • fast/js/exception-registerfile-shrink.html: Removed.
  • fast/js/script-tests/exception-registerfile-shrink.js: Removed.
1:08 AM Changeset in webkit [70211] by mrobinson@webkit.org
  • 3 edits in trunk/WebCore

2010-10-21 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Replace encodings multi-dimensional array with calls to registrar method
https://bugs.webkit.org/show_bug.cgi?id=47990

  • platform/text/gtk/TextCodecGtk.cpp: (WebCore::isEncodingAvailable): (WebCore::registerEncodingNameIfAvailable): (WebCore::registerEncodingAliasIfAvailable): (WebCore::registerCodecIfAvailable): (WebCore::TextCodecGtk::registerBaseEncodingNames): (WebCore::TextCodecGtk::registerBaseCodecs): (WebCore::TextCodecGtk::registerExtendedEncodingNames): (WebCore::TextCodecGtk::registerExtendedCodecs): (WebCore::TextCodecGtk::createIConvDecoder): (WebCore::TextCodecGtk::createIConvEncoder):
  • platform/text/gtk/TextCodecGtk.h:
1:02 AM Changeset in webkit [70210] by mrobinson@webkit.org
  • 5 edits in trunk/LayoutTests

2010-10-21 Martin Robinson <mrobinson@igalia.com>

Rebaseline some tests after r70170.

  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/gtk/fast/borders/border-image-rotate-transform-expected.txt:
  • platform/gtk/fast/borders/border-image-scale-transform-expected.txt:
  • platform/gtk/transforms/2d/hindi-rotated-expected.txt:

Oct 20, 2010:

11:25 PM Changeset in webkit [70209] by hayato@chromium.org
  • 4 edits
    2 deletes in trunk

2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70040.
http://trac.webkit.org/changeset/70040
https://bugs.webkit.org/show_bug.cgi?id=48042

"Reverting a performance regression detected by page_cycler"
(Requested by hayato on #webkit).

  • fast/css/long-css-selector-matches-expected.txt: Removed.
  • fast/css/long-css-selector-matches.html: Removed.

2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70040.
http://trac.webkit.org/changeset/70040
https://bugs.webkit.org/show_bug.cgi?id=48042

"Reverting a performance regression detected by page_cycler"
(Requested by hayato on #webkit).

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::checkSelector):
  • css/CSSStyleSelector.h:
9:26 PM Changeset in webkit [70208] by Adam Roben
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove some no-longer-needed Windows-specific results

  • platform/win/fast/media/mq-transform-02-expected.txt: Removed.
  • platform/win/fast/media/mq-transform-03-expected.txt: Removed.
9:03 PM Changeset in webkit [70207] by ddkilzer@apple.com
  • 1 edit
    1 add in trunk/WebKitTools

<http://webkit.org/b/47754> New script to verify explicit source file types in Xcode project files

Reviewed by Darin Adler.

The script parses an Xcode project file and makes sure the file
extension matches the explicit file type set for all source
files. Note that the majority of source files will have their
type set by Xcode, so the script doesn't check them since there
is no need to second-guess Xcode.

  • Scripts/check-Xcode-source-file-types: Added. Code borrowed

heavily from sort-Xcode-project-file.

7:23 PM Changeset in webkit [70206] by yuzo@google.com
  • 3 edits in trunk/LayoutTests

2010-10-20 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium-mac/fast/forms/search-transformed-expected.checksum:
  • platform/chromium-mac/fast/forms/search-transformed-expected.png:
7:14 PM Changeset in webkit [70205] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-10-20 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.
fast/transforms/scrollIntoView-transformed.html now passes for WIN and LINUX.

  • platform/chromium/test_expectations.txt:
7:03 PM Changeset in webkit [70204] by yuzo@google.com
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-10-20 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium-win-vista/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Removed.
6:44 PM Changeset in webkit [70203] by mihaip@chromium.org
  • 133 edits
    132 copies in trunk/LayoutTests

2010-10-19 Mihai Parparita <mihaip@chromium.org>

css2.1/ layout tests need new Mac baselines for Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=47760

Unreviewed rebaseline of 66 more css2.1/ test for Snow Leopard using
the experimental local rebaselining tool.

  • platform/mac-leopard/css2.1/t040103-escapes-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-01-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-escapes-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-01-b-expected.png.
  • platform/mac-leopard/css2.1/t040103-escapes-02-d-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-02-d-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-escapes-02-d-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-02-d-expected.png.
  • platform/mac-leopard/css2.1/t040103-escapes-03-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-03-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-escapes-03-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-03-b-expected.png.
  • platform/mac-leopard/css2.1/t040103-escapes-04-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-04-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-escapes-04-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-04-b-expected.png.
  • platform/mac-leopard/css2.1/t040103-escapes-05-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-05-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-escapes-05-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-05-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-escapes-06-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-06-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-escapes-06-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-06-b-expected.png.
  • platform/mac-leopard/css2.1/t040103-escapes-07-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-07-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-escapes-07-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-07-b-expected.png.
  • platform/mac-leopard/css2.1/t040103-escapes-08-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-08-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-escapes-08-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-08-b-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-00-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-00-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-00-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-00-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-01-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-01-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-01-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-01-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-02-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-02-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-02-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-02-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-03-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-03-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-03-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-03-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-04-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-04-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-04-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-04-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-05-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-05-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-05-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-05-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-06-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-06-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-06-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-06-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-07-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-07-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-07-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-07-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-08-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-08-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-08-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-08-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-09-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-09-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-09-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-09-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-10-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-10-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-10-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-10-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-11-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-11-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-11-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-11-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-12-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-12-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-12-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-12-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-ident-13-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-13-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-ident-13-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-ident-13-c-expected.png.
  • platform/mac-leopard/css2.1/t040105-atkeyw-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040105-atkeyw-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040105-atkeyw-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040105-atkeyw-00-b-expected.png.
  • platform/mac-leopard/css2.1/t040105-atkeyw-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040105-atkeyw-01-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040105-atkeyw-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040105-atkeyw-01-b-expected.png.
  • platform/mac-leopard/css2.1/t040105-atkeyw-02-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040105-atkeyw-02-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040105-atkeyw-02-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040105-atkeyw-02-b-expected.png.
  • platform/mac-leopard/css2.1/t040105-atrule-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040105-atrule-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040105-atrule-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040105-atrule-00-b-expected.png.
  • platform/mac-leopard/css2.1/t040105-atrule-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040105-atrule-01-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040105-atrule-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040105-atrule-01-b-expected.png.
  • platform/mac-leopard/css2.1/t040105-atrule-02-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040105-atrule-02-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040105-atrule-02-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040105-atrule-02-b-expected.png.
  • platform/mac-leopard/css2.1/t040105-atrule-03-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040105-atrule-03-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040105-atrule-03-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040105-atrule-03-b-expected.png.
  • platform/mac-leopard/css2.1/t040105-atrule-04-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040105-atrule-04-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040105-atrule-04-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040105-atrule-04-b-expected.png.
  • platform/mac-leopard/css2.1/t040105-import-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040105-import-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040105-import-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040105-import-00-b-expected.png.
  • platform/mac-leopard/css2.1/t040105-import-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040105-import-01-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040105-import-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040105-import-01-b-expected.png.
  • platform/mac-leopard/css2.1/t040109-c17-comments-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040109-c17-comments-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040109-c17-comments-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040109-c17-comments-00-b-expected.png.
  • platform/mac-leopard/css2.1/t040109-c17-comments-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040109-c17-comments-01-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040109-c17-comments-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040109-c17-comments-01-b-expected.png.
  • platform/mac-leopard/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum.
  • platform/mac-leopard/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png.
  • platform/mac-leopard/css2.1/t040302-c61-phys-len-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040302-c61-phys-len-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040302-c61-phys-len-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040302-c61-phys-len-00-b-expected.png.
  • platform/mac-leopard/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum.
  • platform/mac-leopard/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png.
  • platform/mac-leopard/css2.1/t040303-c62-percent-00-b-ag-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040303-c62-percent-00-b-ag-expected.checksum.
  • platform/mac-leopard/css2.1/t040303-c62-percent-00-b-ag-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040303-c62-percent-00-b-ag-expected.png.
  • platform/mac-leopard/css2.1/t040304-c64-uri-00-a-g-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040304-c64-uri-00-a-g-expected.checksum.
  • platform/mac-leopard/css2.1/t040304-c64-uri-00-a-g-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040304-c64-uri-00-a-g-expected.png.
  • platform/mac-leopard/css2.1/t040306-c63-color-00-b-ag-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040306-c63-color-00-b-ag-expected.checksum.
  • platform/mac-leopard/css2.1/t040306-c63-color-00-b-ag-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040306-c63-color-00-b-ag-expected.png.
  • platform/mac-leopard/css2.1/t040306-syntax-01-f-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040306-syntax-01-f-expected.checksum.
  • platform/mac-leopard/css2.1/t040306-syntax-01-f-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040306-syntax-01-f-expected.png.
  • platform/mac-leopard/css2.1/t040307-syntax-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040307-syntax-01-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040307-syntax-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040307-syntax-01-b-expected.png.
  • platform/mac-leopard/css2.1/t050201-c12-grouping-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t050201-c12-grouping-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t050201-c12-grouping-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t050201-c12-grouping-00-b-expected.png.
  • platform/mac-leopard/css2.1/t050803-c14-classes-00-e-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t050803-c14-classes-00-e-expected.checksum.
  • platform/mac-leopard/css2.1/t050803-c14-classes-00-e-expected.png: Copied from LayoutTests/platform/mac/css2.1/t050803-c14-classes-00-e-expected.png.
  • platform/mac-leopard/css2.1/t051103-c21-activ-ln-00-e-i-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t051103-c21-activ-ln-00-e-i-expected.checksum.
  • platform/mac-leopard/css2.1/t051103-c21-activ-ln-00-e-i-expected.png: Copied from LayoutTests/platform/mac/css2.1/t051103-c21-activ-ln-00-e-i-expected.png.
  • platform/mac-leopard/css2.1/t051103-c21-focus-ln-00-e-i-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t051103-c21-focus-ln-00-e-i-expected.checksum.
  • platform/mac-leopard/css2.1/t051103-c21-focus-ln-00-e-i-expected.png: Copied from LayoutTests/platform/mac/css2.1/t051103-c21-focus-ln-00-e-i-expected.png.
  • platform/mac-leopard/css2.1/t051103-c21-hover-ln-00-e-i-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t051103-c21-hover-ln-00-e-i-expected.checksum.
  • platform/mac-leopard/css2.1/t051103-c21-hover-ln-00-e-i-expected.png: Copied from LayoutTests/platform/mac/css2.1/t051103-c21-hover-ln-00-e-i-expected.png.
  • platform/mac-leopard/css2.1/t051103-dom-hover-01-c-io-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t051103-dom-hover-01-c-io-expected.checksum.
  • platform/mac-leopard/css2.1/t051103-dom-hover-01-c-io-expected.png: Copied from LayoutTests/platform/mac/css2.1/t051103-dom-hover-01-c-io-expected.png.
  • platform/mac-leopard/css2.1/t051103-dom-hover-02-c-io-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t051103-dom-hover-02-c-io-expected.checksum.
  • platform/mac-leopard/css2.1/t051103-dom-hover-02-c-io-expected.png: Copied from LayoutTests/platform/mac/css2.1/t051103-dom-hover-02-c-io-expected.png.
  • platform/mac-leopard/css2.1/t051201-c23-first-line-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t051201-c23-first-line-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t051201-c23-first-line-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t051201-c23-first-line-00-b-expected.png.
  • platform/mac-leopard/css2.1/t051202-c24-first-lttr-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t051202-c24-first-lttr-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t051202-c24-first-lttr-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t051202-c24-first-lttr-00-b-expected.png.
  • platform/mac-leopard/css2.1/t051202-c26-psudo-nest-00-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t051202-c26-psudo-nest-00-c-expected.checksum.
  • platform/mac-leopard/css2.1/t051202-c26-psudo-nest-00-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t051202-c26-psudo-nest-00-c-expected.png.
  • platform/mac-leopard/css2.1/t060401-c32-cascading-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t060401-c32-cascading-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t060401-c32-cascading-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t060401-c32-cascading-00-b-expected.png.
  • platform/mac-leopard/css2.1/t060402-c31-important-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t060402-c31-important-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t060402-c31-important-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t060402-c31-important-00-b-expected.png.
  • platform/mac-leopard/css2.1/t060403-c21-pseu-cls-00-e-i-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t060403-c21-pseu-cls-00-e-i-expected.checksum.
  • platform/mac-leopard/css2.1/t060403-c21-pseu-cls-00-e-i-expected.png: Copied from LayoutTests/platform/mac/css2.1/t060403-c21-pseu-cls-00-e-i-expected.png.
  • platform/mac-leopard/css2.1/t060403-c21-pseu-id-00-e-i-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t060403-c21-pseu-id-00-e-i-expected.checksum.
  • platform/mac-leopard/css2.1/t060403-c21-pseu-id-00-e-i-expected.png: Copied from LayoutTests/platform/mac/css2.1/t060403-c21-pseu-id-00-e-i-expected.png.
  • platform/mac-leopard/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png.
  • platform/mac-leopard/css2.1/t0805-c5513-brdr-bw-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t0805-c5513-brdr-bw-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t0805-c5513-brdr-bw-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t0805-c5513-brdr-bw-00-b-expected.png.
  • platform/mac-leopard/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.checksum.
  • platform/mac-leopard/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.png: Copied from LayoutTests/platform/mac/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.png.
  • platform/mac-leopard/css2.1/t0805-c5513-brdr-bw-02-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t0805-c5513-brdr-bw-02-b-expected.checksum.
  • platform/mac-leopard/css2.1/t0805-c5513-brdr-bw-02-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t0805-c5513-brdr-bw-02-b-expected.png.
  • platform/mac-leopard/css2.1/t0805-c5513-brdr-bw-03-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t0805-c5513-brdr-bw-03-b-expected.checksum.
  • platform/mac-leopard/css2.1/t0805-c5513-brdr-bw-03-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t0805-c5513-brdr-bw-03-b-expected.png.
  • platform/mac-leopard/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.checksum.
  • platform/mac-leopard/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.png: Copied from LayoutTests/platform/mac/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.png.
  • platform/mac-leopard/css2.1/t0805-c5514-brdr-lw-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t0805-c5514-brdr-lw-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t0805-c5514-brdr-lw-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t0805-c5514-brdr-lw-00-b-expected.png.
  • platform/mac-leopard/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.checksum.
  • platform/mac-leopard/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.png: Copied from LayoutTests/platform/mac/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.png.
  • platform/mac-leopard/css2.1/t0805-c5514-brdr-lw-02-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t0805-c5514-brdr-lw-02-b-expected.checksum.
  • platform/mac-leopard/css2.1/t0805-c5514-brdr-lw-02-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t0805-c5514-brdr-lw-02-b-expected.png.
  • platform/mac-leopard/css2.1/t0805-c5514-brdr-lw-03-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t0805-c5514-brdr-lw-03-b-expected.checksum.
  • platform/mac-leopard/css2.1/t0805-c5514-brdr-lw-03-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t0805-c5514-brdr-lw-03-b-expected.png.
  • platform/mac/css2.1/t040103-escapes-01-b-expected.checksum:
  • platform/mac/css2.1/t040103-escapes-01-b-expected.png:
  • platform/mac/css2.1/t040103-escapes-02-d-expected.checksum:
  • platform/mac/css2.1/t040103-escapes-02-d-expected.png:
  • platform/mac/css2.1/t040103-escapes-03-b-expected.checksum:
  • platform/mac/css2.1/t040103-escapes-03-b-expected.png:
  • platform/mac/css2.1/t040103-escapes-04-b-expected.checksum:
  • platform/mac/css2.1/t040103-escapes-04-b-expected.png:
  • platform/mac/css2.1/t040103-escapes-05-c-expected.checksum:
  • platform/mac/css2.1/t040103-escapes-05-c-expected.png:
  • platform/mac/css2.1/t040103-escapes-06-b-expected.checksum:
  • platform/mac/css2.1/t040103-escapes-06-b-expected.png:
  • platform/mac/css2.1/t040103-escapes-07-b-expected.checksum:
  • platform/mac/css2.1/t040103-escapes-07-b-expected.png:
  • platform/mac/css2.1/t040103-escapes-08-b-expected.checksum:
  • platform/mac/css2.1/t040103-escapes-08-b-expected.png:
  • platform/mac/css2.1/t040103-ident-00-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-00-c-expected.png:
  • platform/mac/css2.1/t040103-ident-01-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-01-c-expected.png:
  • platform/mac/css2.1/t040103-ident-02-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-02-c-expected.png:
  • platform/mac/css2.1/t040103-ident-03-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-03-c-expected.png:
  • platform/mac/css2.1/t040103-ident-04-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-04-c-expected.png:
  • platform/mac/css2.1/t040103-ident-05-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-05-c-expected.png:
  • platform/mac/css2.1/t040103-ident-06-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-06-c-expected.png:
  • platform/mac/css2.1/t040103-ident-07-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-07-c-expected.png:
  • platform/mac/css2.1/t040103-ident-08-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-08-c-expected.png:
  • platform/mac/css2.1/t040103-ident-09-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-09-c-expected.png:
  • platform/mac/css2.1/t040103-ident-10-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-10-c-expected.png:
  • platform/mac/css2.1/t040103-ident-11-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-11-c-expected.png:
  • platform/mac/css2.1/t040103-ident-12-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-12-c-expected.png:
  • platform/mac/css2.1/t040103-ident-13-c-expected.checksum:
  • platform/mac/css2.1/t040103-ident-13-c-expected.png:
  • platform/mac/css2.1/t040105-atkeyw-00-b-expected.checksum:
  • platform/mac/css2.1/t040105-atkeyw-00-b-expected.png:
  • platform/mac/css2.1/t040105-atkeyw-01-b-expected.checksum:
  • platform/mac/css2.1/t040105-atkeyw-01-b-expected.png:
  • platform/mac/css2.1/t040105-atkeyw-02-b-expected.checksum:
  • platform/mac/css2.1/t040105-atkeyw-02-b-expected.png:
  • platform/mac/css2.1/t040105-atrule-00-b-expected.checksum:
  • platform/mac/css2.1/t040105-atrule-00-b-expected.png:
  • platform/mac/css2.1/t040105-atrule-01-b-expected.checksum:
  • platform/mac/css2.1/t040105-atrule-01-b-expected.png:
  • platform/mac/css2.1/t040105-atrule-02-b-expected.checksum:
  • platform/mac/css2.1/t040105-atrule-02-b-expected.png:
  • platform/mac/css2.1/t040105-atrule-03-b-expected.checksum:
  • platform/mac/css2.1/t040105-atrule-03-b-expected.png:
  • platform/mac/css2.1/t040105-atrule-04-b-expected.checksum:
  • platform/mac/css2.1/t040105-atrule-04-b-expected.png:
  • platform/mac/css2.1/t040105-import-00-b-expected.checksum:
  • platform/mac/css2.1/t040105-import-00-b-expected.png:
  • platform/mac/css2.1/t040105-import-01-b-expected.checksum:
  • platform/mac/css2.1/t040105-import-01-b-expected.png:
  • platform/mac/css2.1/t040109-c17-comments-00-b-expected.checksum:
  • platform/mac/css2.1/t040109-c17-comments-00-b-expected.png:
  • platform/mac/css2.1/t040109-c17-comments-01-b-expected.checksum:
  • platform/mac/css2.1/t040109-c17-comments-01-b-expected.png:
  • platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum:
  • platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png:
  • platform/mac/css2.1/t040302-c61-phys-len-00-b-expected.checksum:
  • platform/mac/css2.1/t040302-c61-phys-len-00-b-expected.png:
  • platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum:
  • platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png:
  • platform/mac/css2.1/t040303-c62-percent-00-b-ag-expected.checksum:
  • platform/mac/css2.1/t040303-c62-percent-00-b-ag-expected.png:
  • platform/mac/css2.1/t040304-c64-uri-00-a-g-expected.checksum:
  • platform/mac/css2.1/t040304-c64-uri-00-a-g-expected.png:
  • platform/mac/css2.1/t040306-c63-color-00-b-ag-expected.checksum:
  • platform/mac/css2.1/t040306-c63-color-00-b-ag-expected.png:
  • platform/mac/css2.1/t040306-syntax-01-f-expected.checksum:
  • platform/mac/css2.1/t040306-syntax-01-f-expected.png:
  • platform/mac/css2.1/t040307-syntax-01-b-expected.checksum:
  • platform/mac/css2.1/t040307-syntax-01-b-expected.png:
  • platform/mac/css2.1/t050201-c12-grouping-00-b-expected.checksum:
  • platform/mac/css2.1/t050201-c12-grouping-00-b-expected.png:
  • platform/mac/css2.1/t050803-c14-classes-00-e-expected.checksum:
  • platform/mac/css2.1/t050803-c14-classes-00-e-expected.png:
  • platform/mac/css2.1/t051103-c21-activ-ln-00-e-i-expected.checksum:
  • platform/mac/css2.1/t051103-c21-activ-ln-00-e-i-expected.png:
  • platform/mac/css2.1/t051103-c21-focus-ln-00-e-i-expected.checksum:
  • platform/mac/css2.1/t051103-c21-focus-ln-00-e-i-expected.png:
  • platform/mac/css2.1/t051103-c21-hover-ln-00-e-i-expected.checksum:
  • platform/mac/css2.1/t051103-c21-hover-ln-00-e-i-expected.png:
  • platform/mac/css2.1/t051103-dom-hover-01-c-io-expected.checksum:
  • platform/mac/css2.1/t051103-dom-hover-01-c-io-expected.png:
  • platform/mac/css2.1/t051103-dom-hover-02-c-io-expected.checksum:
  • platform/mac/css2.1/t051103-dom-hover-02-c-io-expected.png:
  • platform/mac/css2.1/t051201-c23-first-line-00-b-expected.checksum:
  • platform/mac/css2.1/t051201-c23-first-line-00-b-expected.png:
  • platform/mac/css2.1/t051202-c24-first-lttr-00-b-expected.checksum:
  • platform/mac/css2.1/t051202-c24-first-lttr-00-b-expected.png:
  • platform/mac/css2.1/t051202-c26-psudo-nest-00-c-expected.checksum:
  • platform/mac/css2.1/t051202-c26-psudo-nest-00-c-expected.png:
  • platform/mac/css2.1/t060401-c32-cascading-00-b-expected.checksum:
  • platform/mac/css2.1/t060401-c32-cascading-00-b-expected.png:
  • platform/mac/css2.1/t060402-c31-important-00-b-expected.checksum:
  • platform/mac/css2.1/t060402-c31-important-00-b-expected.png:
  • platform/mac/css2.1/t060403-c21-pseu-cls-00-e-i-expected.checksum:
  • platform/mac/css2.1/t060403-c21-pseu-cls-00-e-i-expected.png:
  • platform/mac/css2.1/t060403-c21-pseu-id-00-e-i-expected.checksum:
  • platform/mac/css2.1/t060403-c21-pseu-id-00-e-i-expected.png:
  • platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum:
  • platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/mac/css2.1/t0805-c5513-brdr-bw-00-b-expected.checksum:
  • platform/mac/css2.1/t0805-c5513-brdr-bw-00-b-expected.png:
  • platform/mac/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.checksum:
  • platform/mac/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.png:
  • platform/mac/css2.1/t0805-c5513-brdr-bw-02-b-expected.checksum:
  • platform/mac/css2.1/t0805-c5513-brdr-bw-02-b-expected.png:
  • platform/mac/css2.1/t0805-c5513-brdr-bw-03-b-expected.checksum:
  • platform/mac/css2.1/t0805-c5513-brdr-bw-03-b-expected.png:
  • platform/mac/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5514-brdr-lw-00-b-expected.checksum:
  • platform/mac/css2.1/t0805-c5514-brdr-lw-00-b-expected.png:
  • platform/mac/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.checksum:
  • platform/mac/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.png:
  • platform/mac/css2.1/t0805-c5514-brdr-lw-02-b-expected.checksum:
  • platform/mac/css2.1/t0805-c5514-brdr-lw-02-b-expected.png:
  • platform/mac/css2.1/t0805-c5514-brdr-lw-03-b-expected.checksum:
  • platform/mac/css2.1/t0805-c5514-brdr-lw-03-b-expected.png:
6:39 PM Changeset in webkit [70202] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-10-20 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium/test_expectations.txt:
6:36 PM Changeset in webkit [70201] by Simon Fraser
  • 2 edits in trunk/JavaScriptCore

2010-10-20 Simon Fraser <Simon Fraser>

Fix the EFL build.

  • wtf/CMakeLists.txt:
6:28 PM Changeset in webkit [70200] by Simon Fraser
  • 2 edits in trunk/JavaScriptCore

2010-10-20 Simon Fraser <Simon Fraser>

Fix Windows build: export needed symbols.

6:17 PM Changeset in webkit [70199] by Simon Fraser
  • 4 edits in trunk/WebKit/mac

2010-10-20 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Composited elements drawn twice when WebView is layer-backed
https://bugs.webkit.org/show_bug.cgi?id=48024
<rdar://problem/7916580>

When drawing content in a layer-backed WebView, WebFrame's test
for drawing to a bitmap succeeded, causing us to paint flattened
compositing layers into the view. They would also be rendered
by the normal compositing path, resulting in double rendering.

Fix this by detecting when the WebHTMLView is being drawn into
a layer, and avoiding flattening in that case.

  • WebView/WebFrame.mm: (-[WebFrame _showFlattenedCompositingLayers:]): (-[WebFrame _drawRect:contentsOnly:]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView drawLayer:inContext:]): (-[WebHTMLView _web_isDrawingIntoLayer]):
  • WebView/WebHTMLViewInternal.h:
6:15 PM Changeset in webkit [70198] by Simon Fraser
  • 17 edits
    3 adds in trunk

2010-10-19 Simon Fraser <Simon Fraser>

Reviewed by Gavin Barraclough.

https://bugs.webkit.org/show_bug.cgi?id=47851

Add methods to DecimalNumber to return the buffer length
required for decimal and exponential output.

Make some of the DecimalNumber code non-inline (no
effect on Sunspider), adding DecimalNumber.cpp to various
build systems.

Make some DecimalNumber methods 'const'.

  • Android.mk:
  • Android.v8.wtf.mk:
  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToExponential): (JSC::numberProtoFuncToFixed): (JSC::numberProtoFuncToPrecision):
  • wtf/DecimalNumber.cpp: Added. (WTF::DecimalNumber::bufferLengthForStringDecimal): (WTF::DecimalNumber::bufferLengthForStringExponential): (WTF::DecimalNumber::toStringDecimal): (WTF::DecimalNumber::toStringExponential):
  • wtf/DecimalNumber.h: (WTF::DecimalNumber::sign): (WTF::DecimalNumber::exponent): (WTF::DecimalNumber::significand): (WTF::DecimalNumber::precision):
  • wtf/dtoa.cpp: (WTF::dtoa):
  • wtf/dtoa.h:
  • wtf/wtf.pri:

2010-10-19 Simon Fraser <Simon Fraser>

Reviewed by Gavin Barraclough.

https://bugs.webkit.org/show_bug.cgi?id=47851

Avoid buffer overflows in CSSPrimitiveValue's use of
DecimalNumber, and pass the buffer size in InspectorBasicValue.

Test: fast/css/large-value-csstext.html

  • css/CSSPrimitiveValue.cpp: (WebCore::formatNumber):
  • inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):

2010-10-20 Simon Fraser <Simon Fraser>

Reviewed by Gavin Barraclough.

https://bugs.webkit.org/show_bug.cgi?id=47851

Fix buffer overflow in the printing of very large and very small numbers in
CSSPrimitiveValues.

  • fast/css/large-value-csstext-expected.txt: Added.
  • fast/css/large-value-csstext.html: Added.
5:39 PM Changeset in webkit [70197] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows build fix

  • TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added missing #include.
5:35 PM Changeset in webkit [70196] by Adam Roben
  • 2 edits in trunk/WebKitTools

Qt test fix

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Added

PassDifferentNPPStruct.cpp.

5:25 PM Changeset in webkit [70195] by dumi@chromium.org
  • 6 edits in trunk

WebCore: Add SecurityOrigin::threadsafeCopy() to the list of exported symbols.
https://bugs.webkit.org/show_bug.cgi?id=40655

Reviewed by David Levin.

  • WebCore.exp.in:

WebKit/mac: Repost the DatabaseTracker notifications to the main thread, if needed.
https://bugs.webkit.org/show_bug.cgi?id=40655

Reviewed by David Levin.

  • Storage/WebDatabaseTrackerClient.mm:

(DidModifyOriginData::dispatchToMainThread):
(DidModifyOriginData::DidModifyOriginData):
(DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
(WebDatabaseTrackerClient::dispatchDidModifyOrigin):
(WebDatabaseTrackerClient::dispatchDidModifyDatabase):

WebKit/win: Repost the DatabaseTracker notifications to the main thread, if needed.
https://bugs.webkit.org/show_bug.cgi?id=40655

Reviewed by David Levin.

  • WebDatabaseManager.cpp:

(DidModifyOriginData::dispatchToMainThread):
(DidModifyOriginData::DidModifyOriginData):
(DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
(WebDatabaseManager::dispatchDidModifyOrigin):
(WebDatabaseManager::dispatchDidModifyDatabase):

5:22 PM Changeset in webkit [70194] by weinig@apple.com
  • 6 edits
    9 adds in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=48027
Add ability to test injected bundle API using TestWebKitAPI

Reviewed by Adam Roben.

  • TestWebKitAPI/InjectedBundleController.cpp: Added.
  • TestWebKitAPI/InjectedBundleController.h: Added.

Shared main object for bundle functionality.

  • TestWebKitAPI/InjectedBundleMain.cpp: Added.

Bundle entry point.

  • TestWebKitAPI/InjectedBundleTest.h: Added.

Base class for which the bundle portion of a test derives from.

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/PlatformUtilities.cpp: Added.
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
  • TestWebKitAPI/win/PlatformUtilitiesWin.cpp:

(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::URLForNonExistentResource):
Add helper to create a context with the shared injected bundle,
and send the initial message to set up the test.

  • TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Added.
  • TestWebKitAPI/InjectedBundle-Info.plist: Added.

Add mac configuration files.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add the new files.

  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Added.
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Added.

Add a simple initial bundle test.

5:11 PM Changeset in webkit [70193] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-20 Eric Seidel <eric@webkit.org>

Unreviewed. Fixing /release-patch url used by the EWS bots.

EWS should test patches with r+
https://bugs.webkit.org/show_bug.cgi?id=35460

  • Scripts/webkitpy/common/net/statusserver.py:
    • I changed the URL during development, and 404s are intentionally silenced during release_patch.
5:11 PM Changeset in webkit [70192] by Beth Dakin
  • 3 edits in trunk/LayoutTests

Fix for https://bugs.webkit.org/show_bug.cgi?id=48023
fast/transforms/scrollIntoView-transformed.html should have
different expectations now that transforms affect overflow

Reviewed by Simon Fraser.

  • fast/transforms/scrollIntoView-transformed-expected.txt:
  • fast/transforms/scrollIntoView-transformed.html:
4:54 PM Changeset in webkit [70191] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-10-20 Kenneth Russell <kbr@google.com>

Unreviewed, test expectations update.

Added skip entries for crashing plugin-related compositing/ layout
tests on the chromium-gpu-mac platform. Aside from this, the
common (Mac) test expectations can be reused. At this point, it
should be possible to expect that the enabled compositing/ tests
will all pass.

  • platform/chromium-gpu/test_expectations.txt:
4:39 PM Changeset in webkit [70190] by Adam Roben
  • 6 edits
    3 adds in trunk

Don't require the plugin to always use the same NPP struct we gave it in NPP_New

Neither WebCore, nor WebKit/mac, nor Firefox requires this, and
Shockwave (at least) seems to use a different NPP struct that contains
the same ndata member. So we shouldn't enforce it, either.

Fixes <http://webkit.org/b/47690> <rdar://problem/8553020> Assertion
failure in NetscapePlugin::fromNPP when using Shockwave in WebKit2

Reviewed by John Sullivan.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::fromNPP): Removed the bogus assertion.

WebKitTools:

Test that passing a different NPP struct back to the browser doesn't
cause an assertion failure

  • DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp: Copied from WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp.

(PassDifferentNPPStruct::PassDifferentNPPStruct): Initialize our
members.
(PassDifferentNPPStruct::NPP_SetWindow): Pass a different NPP to the
browser than the one it gave us in NPP_New and see if it works.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:

Added PassDifferentNPPStruct.

LayoutTests:

Test that passing a different NPP struct back to the browser doesn't
cause an assertion failure

  • plugins/pass-different-npp-struct-expected.txt: Added.
  • plugins/pass-different-npp-struct.html: Added.
4:16 PM Changeset in webkit [70189] by kbr@google.com
  • 2 edits
    81 adds in trunk/LayoutTests

2010-10-20 Kenneth Russell <kbr@google.com>

Unreviewed, test expectations update.

Added pixel expectations for compositing/ layout tests on
chromium-gpu-linux platform and updated
chromium-gpu/test_expectations.txt with needed SKIP entries for
currently failing tests. The majority of the text tests pass by falling
back to the Windows test expectations.

  • platform/chromium-gpu-linux/compositing: Added.
  • platform/chromium-gpu-linux/compositing/animation: Added.
  • platform/chromium-gpu-linux/compositing/animation/state-at-end-event-transform-layer-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/compositing-visible-descendant-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/compositing-visible-descendant-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/generated-content-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/generated-content-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry: Added.
  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/outline-change-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/outline-change-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/partial-layout-update-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/partial-layout-update-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/root-layer-update-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/root-layer-update-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/iframes: Added.
  • platform/chromium-gpu-linux/compositing/iframes/iframe-content-flipping-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/iframes/iframe-content-flipping-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/iframes/iframe-copy-on-scroll-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/images: Added.
  • platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/overflow: Added.
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/overflow/overflow-positioning-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/overflow/parent-overflow-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/overflow/parent-overflow-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/overflow/scrollbar-painting-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/overflow/scrollbar-painting-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/overflow/zero-size-overflow-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/overflow/zero-size-overflow-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections: Added.
  • platform/chromium-gpu-linux/compositing/reflections/backface-hidden-reflection-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/backface-hidden-reflection-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/repaint: Added.
  • platform/chromium-gpu-linux/compositing/repaint/become-overlay-composited-layer-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/repaint/content-into-overflow-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/repaint/content-into-overflow-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/repaint/layer-repaint-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/repaint/layer-repaint-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/repaint/layer-repaint-rects-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/repaint/layer-repaint-rects-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/repaint/opacity-between-absolute-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/repaint/opacity-between-absolute2-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/repaint/overflow-into-content-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/repaint/overflow-into-content-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/sibling-positioning-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/sibling-positioning-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/transitions: Added.
  • platform/chromium-gpu-linux/compositing/transitions/singular-scale-transition-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/transitions/singular-scale-transition-expected.png: Added.
  • platform/chromium-gpu/test_expectations.txt:
4:12 PM Changeset in webkit [70188] by Adam Roben
  • 4 edits in trunk/WebKitTools

Gently nudge old-run-webkit-tests toward working with Win32 Perl

This makes old-run-webkit-tests able to build DRT and find all the
tests to run. It even invokes DRT and passes it the list of tests. But
DRT ends up hung blocking on I/O.

Fixes <http://webkit.org/b/47961> Get old-run-webkit-tests mostly
working with Win32 Perl

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:
    • Use File::Spec instead of manually concatenating paths
    • Use dirname instead of manually stripping off the base name
    • Use isCygwin/isWindows/isAppleWinWebKit more judiciously
    • Explicitly invoke Perl when running Perl scripts
    • Quote paths when using them in regular expressions to allow them to include characters that have special meanings in regular expressions
  • Scripts/run-webkit-tests: Use File::Spec instead of manually

concatenating paths.

  • Scripts/webkitdirs.pm:
    • Remove the unused $windowsTmpPath variable
    • Use isCygwin/isWindows/isAppleWinWebKit more judiciously
    • Only pass paths to cygpath when using Cygwin Perl
    • Only use pdevenv when using Cygwin Perl, for now
3:54 PM Changeset in webkit [70187] by dbates@webkit.org
  • 4 edits in trunk/WebKitTools

2010-10-20 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Add Git-support to do-file-rename
https://bugs.webkit.org/show_bug.cgi?id=48015

Also, abstracts the SCM move/rename functionality in do-file-rename and
do-webcore-rename into a common function VCSUtils::scmMoveOrRenameFile().

Currently, do-file-rename is hard coded to assume the SCM is Subversion.
Instead, we should abstract the rename logic to be SCM-independent. This
will allow us to add Git support as well move such functionality into
our SCM library VCSUtils, where it can be shared by do-webcore-rename.

  • Scripts/VCSUtils.pm:
    • Added function scmMoveOrRenameFile.
  • Scripts/do-file-rename: Modified to call VCSUtils::scmMoveOrRenameFile().
  • Scripts/do-webcore-rename: Ditto.
3:52 PM Changeset in webkit [70186] by jamesr@google.com
  • 17 edits
    23 adds in trunk/LayoutTests

2010-10-20 James Robinson <jamesr@chromium.org>

Add/update chromium expectations for newly added and changed tests.

  • platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.checksum:
  • platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.checksum: Added.
  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/chromium-linux/fast/transforms/rotated-transform-affects-scrolling-1-expected.checksum: Added.
  • platform/chromium-linux/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
  • platform/chromium-linux/fast/transforms/rotated-transform-affects-scrolling-2-expected.checksum: Added.
  • platform/chromium-linux/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.checksum:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.checksum: Added.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.checksum: Added.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/chromium-win/fast/blockflow/basic-vertical-line-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/basic-vertical-line-expected.png: Added.
  • platform/chromium-win/fast/blockflow/basic-vertical-line-expected.txt: Added.
  • platform/chromium-win/fast/borders/border-image-rotate-transform-expected.checksum:
  • platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-rotate-transform-expected.txt:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.checksum:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.txt:
  • platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-1-expected.checksum: Added.
  • platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
  • platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-2-expected.checksum: Added.
  • platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:41 PM QtWebKitReleases edited by Ademar Reis
(diff)
3:36 PM QtWebKit edited by Ademar Reis
(diff)
3:30 PM UsingGitWithWebKit edited by Ademar Reis
(diff)
3:29 PM QtWebKitContrib edited by Ademar Reis
(diff)
3:29 PM QtWebKitAPI edited by Ademar Reis
(diff)
3:23 PM Changeset in webkit [70185] by dbates@webkit.org
  • 4 edits
    1 add
    10 deletes in trunk/LayoutTests

2010-10-20 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

Convert layout test LayoutTests/fast/frames/frame-element-name.html from
render-tree/pixel test to text-only test
https://bugs.webkit.org/show_bug.cgi?id=48011

Converts the test case frame-element-name.html from a render-tree dump/pixel-test
to a text-only test.

Also, changes the test output to a PASS/FAIL style.

  • fast/frames/frame-element-name-expected.txt: Added.
  • fast/frames/frame-element-name.html: Modified to dump its child frames as text.
  • fast/frames/resources/frame-element-name-left.html: Changed output to PASS/FAIL.
  • fast/frames/resources/frame-element-name-right.html: Changed output to PASS/FAIL; changed <title> of page from "Left" to "Right" to reflect the name of the file and the location of the frame this page is to be loaded in.
  • platform/chromium-linux/fast/frames/frame-element-name-expected.checksum: Removed.
  • platform/chromium-linux/fast/frames/frame-element-name-expected.png: Removed.
  • platform/chromium-win/fast/frames/frame-element-name-expected.checksum: Removed.
  • platform/chromium-win/fast/frames/frame-element-name-expected.png: Removed.
  • platform/chromium-win/fast/frames/frame-element-name-expected.txt: Removed.
  • platform/gtk/fast/frames/frame-element-name-expected.txt: Removed.
  • platform/mac/fast/frames/frame-element-name-expected.checksum: Removed.
  • platform/mac/fast/frames/frame-element-name-expected.png: Removed.
  • platform/mac/fast/frames/frame-element-name-expected.txt: Removed.
  • platform/qt/fast/frames/frame-element-name-expected.txt: Removed.
3:20 PM QtWebKitGitInstructions edited by Ademar Reis
(diff)
3:15 PM QtWebKitFeaturePlanning edited by Ademar Reis
minor fixes on URLs (diff)
3:10 PM Changeset in webkit [70184] by Adam Roben
  • 8 edits in trunk/LayoutTests

Update media test results to account for the presence of the fullscreen button

This button appears now that hardware acceleration is enabled.

  • platform/win/media/controls-after-reload-expected.txt:
  • platform/win/media/controls-drag-timebar-expected.txt:
  • platform/win/media/controls-strict-expected.txt:
  • platform/win/media/controls-styling-expected.txt:
  • platform/win/media/video-controls-rendering-expected.txt:
  • platform/win/media/video-display-toggle-expected.txt:
  • platform/win/media/video-no-audio-expected.txt:
3:02 PM Changeset in webkit [70183] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix old-run-webkit-tests when there's a space in the path to DRT

Reviewed by Jon Honeycutt.

  • Scripts/old-run-webkit-tests: Quote the path to DRT before executing

it.

2:57 PM Changeset in webkit [70182] by kbr@google.com
  • 2 edits in trunk/WebKitTools

2010-10-20 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Regression in chromium_gpu_unittests after r70175
https://bugs.webkit.org/show_bug.cgi?id=48008

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2:49 PM Changeset in webkit [70181] by commit-queue@webkit.org
  • 32 edits
    2 deletes in trunk

2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70165.
http://trac.webkit.org/changeset/70165
https://bugs.webkit.org/show_bug.cgi?id=48007

It broke tests on Qt bot (Requested by Ossy on #webkit).

2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70165.
http://trac.webkit.org/changeset/70165
https://bugs.webkit.org/show_bug.cgi?id=48007

It broke tests on Qt bot (Requested by Ossy on #webkit).

  • ForwardingHeaders/wtf/text/TextPosition.h: Removed.
  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::eventHandlerLineNumber): (WebCore::ScriptController::eventHandlerColumnNumber):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::startLine):
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::prepareListenerObject):
  • bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::runScript):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate): (WebCore::WorkerContextExecutionProxy::runScript):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  • dom/PendingScript.cpp: (WebCore::PendingScript::releaseElementAndClear):
  • dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=): (WebCore::PendingScript::startingLineNumber):
  • dom/ScriptableDocumentParser.h:
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): (WebCore::HTMLDocumentParser::columnNumber):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript): (WebCore::HTMLScriptRunner::execute): (WebCore::HTMLScriptRunner::runScript):
  • html/parser/HTMLScriptRunner.h:
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::takeScriptToProcess): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processScriptStartTag):
  • html/parser/HTMLTreeBuilder.h:

2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70165.
http://trac.webkit.org/changeset/70165
https://bugs.webkit.org/show_bug.cgi?id=48007

It broke tests on Qt bot (Requested by Ossy on #webkit).

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeScript): (WebKit::WebFrameImpl::executeScriptInIsolatedWorld): (WebKit::WebFrameImpl::executeScriptAndReturnValue):
2:28 PM Changeset in webkit [70180] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix clang++ build.

  • UIProcess/API/C/WKNativeEvent.h:
2:14 PM Changeset in webkit [70179] by kbr@google.com
  • 1 edit
    79 copies
    3 adds
    1 delete in trunk/LayoutTests

2010-10-20 Kenneth Russell <kbr@google.com>

Unreviewed, test expectations update.

Moved text test expectations generated on Windows for chromium-gpu
port from chromium-gpu to chromium-gpu-win. chromium_gpu.py has
been changed on Linux to search first chromium-gpu-linux and then
chromium-gpu-win for expectations. This will allow these test
expectations to be shared between Windows and Linux without
affecting the Mac port.

  • platform/chromium-gpu-win/compositing/animation/animated-composited-inside-hidden-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/animation/animated-composited-inside-hidden-expected.txt.
  • platform/chromium-gpu-win/compositing/animation/animation-compositing-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/animation/animation-compositing-expected.txt.
  • platform/chromium-gpu-win/compositing/animation/computed-style-during-delay-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/animation/computed-style-during-delay-expected.txt.
  • platform/chromium-gpu-win/compositing/animation/state-at-end-event-transform-layer-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/animation/state-at-end-event-transform-layer-expected.txt.
  • platform/chromium-gpu-win/compositing/composited-negative-zindex-child-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/composited-negative-zindex-child-expected.txt.
  • platform/chromium-gpu-win/compositing/compositing-visible-descendant-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/compositing-visible-descendant-expected.txt.
  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/direct-image-compositing-expected.txt.
  • platform/chromium-gpu-win/compositing/generated-content-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/generated-content-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/clip-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/clip-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/clipping-foreground-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/empty-embed-rects-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/empty-embed-rects-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/fixed-in-composited-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/fixed-position-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/huge-layer-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/huge-layer-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/limit-layer-bounds-transformed-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/object-clip-rects-assertion-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/object-clip-rects-assertion-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/outline-change-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/outline-change-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/partial-layout-update-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/partial-layout-update-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/preserve-3d-switching-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/preserve-3d-switching-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/root-layer-update-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/root-layer-update-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt.
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/composited-iframe-alignment-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/composited-parent-iframe-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-delayed-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe2-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/connect-compositing-iframe2-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe3-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/connect-compositing-iframe3-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/enter-compositing-iframe-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/enter-compositing-iframe-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/iframe-content-flipping-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/iframe-content-flipping-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/iframe-copy-on-scroll-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/iframe-copy-on-scroll-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/iframe-in-composited-layer-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/iframe-in-composited-layer-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/iframe-resize-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/iframe-resize-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/iframe-size-from-zero-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/iframe-size-to-zero-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/iframe-size-to-zero-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/iframe-src-change-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/iframe-src-change-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/layout-on-compositing-change-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/layout-on-compositing-change-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/leave-compositing-iframe-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/leave-compositing-iframe-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/overlapped-iframe-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/overlapped-iframe-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/remove-iframe-crash-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/remove-iframe-crash-expected.txt.
  • platform/chromium-gpu-win/compositing/iframes/scrolling-iframe-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/iframes/scrolling-iframe-expected.txt.
  • platform/chromium-gpu-win/compositing/images/clip-on-directly-composited-image-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/images/clip-on-directly-composited-image-expected.txt.
  • platform/chromium-gpu-win/compositing/images/content-image-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/images/content-image-expected.txt.
  • platform/chromium-gpu-win/compositing/images/direct-image-background-color-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/images/direct-image-background-color-expected.txt.
  • platform/chromium-gpu-win/compositing/layer-creation: Added.
  • platform/chromium-gpu-win/compositing/layer-creation/scroll-partial-update-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/layer-creation/scroll-partial-update-expected.txt.
  • platform/chromium-gpu-win/compositing/overflow/clip-descendents-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/clip-descendents-expected.txt.
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.txt.
  • platform/chromium-gpu-win/compositing/overflow/get-transform-from-non-box-container-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/get-transform-from-non-box-container-expected.txt.
  • platform/chromium-gpu-win/compositing/overflow/overflow-positioning-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/overflow-positioning-expected.txt.
  • platform/chromium-gpu-win/compositing/overflow/overflow-scroll-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/overflow-scroll-expected.txt.
  • platform/chromium-gpu-win/compositing/overflow/parent-overflow-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/parent-overflow-expected.txt.
  • platform/chromium-gpu-win/compositing/overflow/resize-painting-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/resize-painting-expected.txt.
  • platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/scrollbar-painting-expected.txt.
  • platform/chromium-gpu-win/compositing/overflow/zero-size-overflow-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/zero-size-overflow-expected.txt.
  • platform/chromium-gpu-win/compositing/plugins: Added.
  • platform/chromium-gpu-win/compositing/plugins/1x1-composited-plugin-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/plugins/1x1-composited-plugin-expected.txt.
  • platform/chromium-gpu-win/compositing/plugins/large-to-small-composited-plugin-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/plugins/large-to-small-composited-plugin-expected.txt.
  • platform/chromium-gpu-win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/plugins/small-to-large-composited-plugin-expected.txt.
  • platform/chromium-gpu-win/compositing/reflections/backface-hidden-reflection-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/reflections/backface-hidden-reflection-expected.txt.
  • platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/reflections/reflection-in-composited-expected.txt.
  • platform/chromium-gpu-win/compositing/repaint/become-overlay-composited-layer-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/repaint/become-overlay-composited-layer-expected.txt.
  • platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/repaint/content-into-overflow-expected.txt.
  • platform/chromium-gpu-win/compositing/repaint/inline-repaint-container-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/repaint/inline-repaint-container-expected.txt.
  • platform/chromium-gpu-win/compositing/repaint/layer-repaint-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/repaint/layer-repaint-expected.txt.
  • platform/chromium-gpu-win/compositing/repaint/layer-repaint-rects-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/repaint/layer-repaint-rects-expected.txt.
  • platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/repaint/opacity-between-absolute-expected.txt.
  • platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute2-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/repaint/opacity-between-absolute2-expected.txt.
  • platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/repaint/overflow-into-content-expected.txt.
  • platform/chromium-gpu-win/compositing/sibling-positioning-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/sibling-positioning-expected.txt.
  • platform/chromium-gpu-win/compositing/tiling: Added.
  • platform/chromium-gpu-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/tiling/crash-reparent-tiled-layer-expected.txt.
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-img-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt.
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-resize-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/tiling/huge-layer-resize-expected.txt.
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt.
  • platform/chromium-gpu-win/compositing/transitions/opacity-on-inline-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/transitions/opacity-on-inline-expected.txt.
  • platform/chromium-gpu-win/compositing/transitions/singular-scale-transition-expected.txt: Copied from LayoutTests/platform/chromium-gpu/compositing/transitions/singular-scale-transition-expected.txt.
  • platform/chromium-gpu/compositing: Removed.
  • platform/chromium-gpu/compositing/animation: Removed.
  • platform/chromium-gpu/compositing/animation/animated-composited-inside-hidden-expected.txt: Removed.
  • platform/chromium-gpu/compositing/animation/animation-compositing-expected.txt: Removed.
  • platform/chromium-gpu/compositing/animation/computed-style-during-delay-expected.txt: Removed.
  • platform/chromium-gpu/compositing/animation/state-at-end-event-transform-layer-expected.txt: Removed.
  • platform/chromium-gpu/compositing/composited-negative-zindex-child-expected.txt: Removed.
  • platform/chromium-gpu/compositing/compositing-visible-descendant-expected.txt: Removed.
  • platform/chromium-gpu/compositing/direct-image-compositing-expected.txt: Removed.
  • platform/chromium-gpu/compositing/generated-content-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry: Removed.
  • platform/chromium-gpu/compositing/geometry/clip-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/clipping-foreground-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/empty-embed-rects-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/fixed-in-composited-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/fixed-position-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/huge-layer-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/outline-change-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/partial-layout-update-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/preserve-3d-switching-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/root-layer-update-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes: Removed.
  • platform/chromium-gpu/compositing/iframes/composited-iframe-alignment-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/connect-compositing-iframe2-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/enter-compositing-iframe-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/iframe-content-flipping-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/iframe-copy-on-scroll-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/iframe-in-composited-layer-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/iframe-resize-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/iframe-size-to-zero-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/iframe-src-change-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/layout-on-compositing-change-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/leave-compositing-iframe-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/overlapped-iframe-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/remove-iframe-crash-expected.txt: Removed.
  • platform/chromium-gpu/compositing/iframes/scrolling-iframe-expected.txt: Removed.
  • platform/chromium-gpu/compositing/images: Removed.
  • platform/chromium-gpu/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
  • platform/chromium-gpu/compositing/images/content-image-expected.txt: Removed.
  • platform/chromium-gpu/compositing/images/direct-image-background-color-expected.txt: Removed.
  • platform/chromium-gpu/compositing/layer-creation: Removed.
  • platform/chromium-gpu/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
  • platform/chromium-gpu/compositing/overflow: Removed.
  • platform/chromium-gpu/compositing/overflow/clip-descendents-expected.txt: Removed.
  • platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Removed.
  • platform/chromium-gpu/compositing/overflow/get-transform-from-non-box-container-expected.txt: Removed.
  • platform/chromium-gpu/compositing/overflow/overflow-positioning-expected.txt: Removed.
  • platform/chromium-gpu/compositing/overflow/overflow-scroll-expected.txt: Removed.
  • platform/chromium-gpu/compositing/overflow/parent-overflow-expected.txt: Removed.
  • platform/chromium-gpu/compositing/overflow/resize-painting-expected.txt: Removed.
  • platform/chromium-gpu/compositing/overflow/scrollbar-painting-expected.txt: Removed.
  • platform/chromium-gpu/compositing/overflow/zero-size-overflow-expected.txt: Removed.
  • platform/chromium-gpu/compositing/plugins: Removed.
  • platform/chromium-gpu/compositing/plugins/1x1-composited-plugin-expected.txt: Removed.
  • platform/chromium-gpu/compositing/plugins/large-to-small-composited-plugin-expected.txt: Removed.
  • platform/chromium-gpu/compositing/plugins/small-to-large-composited-plugin-expected.txt: Removed.
  • platform/chromium-gpu/compositing/reflections: Removed.
  • platform/chromium-gpu/compositing/reflections/backface-hidden-reflection-expected.txt: Removed.
  • platform/chromium-gpu/compositing/reflections/reflection-in-composited-expected.txt: Removed.
  • platform/chromium-gpu/compositing/repaint: Removed.
  • platform/chromium-gpu/compositing/repaint/become-overlay-composited-layer-expected.txt: Removed.
  • platform/chromium-gpu/compositing/repaint/content-into-overflow-expected.txt: Removed.
  • platform/chromium-gpu/compositing/repaint/inline-repaint-container-expected.txt: Removed.
  • platform/chromium-gpu/compositing/repaint/layer-repaint-expected.txt: Removed.
  • platform/chromium-gpu/compositing/repaint/layer-repaint-rects-expected.txt: Removed.
  • platform/chromium-gpu/compositing/repaint/opacity-between-absolute-expected.txt: Removed.
  • platform/chromium-gpu/compositing/repaint/opacity-between-absolute2-expected.txt: Removed.
  • platform/chromium-gpu/compositing/repaint/overflow-into-content-expected.txt: Removed.
  • platform/chromium-gpu/compositing/sibling-positioning-expected.txt: Removed.
  • platform/chromium-gpu/compositing/tiling: Removed.
  • platform/chromium-gpu/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Removed.
  • platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Removed.
  • platform/chromium-gpu/compositing/tiling/huge-layer-resize-expected.txt: Removed.
  • platform/chromium-gpu/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Removed.
  • platform/chromium-gpu/compositing/transitions: Removed.
  • platform/chromium-gpu/compositing/transitions/opacity-on-inline-expected.txt: Removed.
  • platform/chromium-gpu/compositing/transitions/singular-scale-transition-expected.txt: Removed.
2:05 PM Changeset in webkit [70178] by jamesr@google.com
  • 5 edits
    3 adds in trunk/LayoutTests

2010-10-20 James Robinson <jamesr@chromium.org>

Add chromium vista expectations for some SVG tests.

  • platform/chromium-win-vista/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-win-vista/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win-vista/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
  • platform/chromium-win-vista/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win-vista/svg/custom/text-linking-expected.checksum: Copied from LayoutTests/platform/chromium-win-xp/svg/custom/text-linking-expected.checksum.
  • platform/chromium-win-vista/svg/custom/text-linking-expected.png: Copied from LayoutTests/platform/chromium-win-xp/svg/custom/text-linking-expected.png.
  • platform/chromium-win-vista/svg/custom/text-linking-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/text-linking-expected.txt.
2:03 PM Changeset in webkit [70177] by bweinstein@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix the Windows build after r70165. Move the copying of JavaScript headers from JavaScriptCore's post-build
step to JavaScriptCoreGenerated, so the copying is done even when a cpp file in JavaScriptCore is changed.

Reviewed by Adam Roben.

1:58 PM Changeset in webkit [70176] by dumi@chromium.org
  • 2 edits in trunk/JavaScriptCore

Unreviewed, fixing the Win build.

1:54 PM Changeset in webkit [70175] by kbr@google.com
  • 2 edits in trunk/WebKitTools

2010-10-20 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback
https://bugs.webkit.org/show_bug.cgi?id=48005

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1:54 PM Changeset in webkit [70174] by ggaren@apple.com
  • 3 edits
    3 adds in trunk

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=41948
REGRESSION(r60392): Registerfile can be unwound too far following an exception

Reviewed by Darin Adler.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException): Walk the stack to calculate the high
water mark currently in use. It's not safe to assume that the current
CallFrame's high water mark is the highest high water mark because
calls do not always set up at the end of a CallFrame. A large caller
CallFrame can encompass a small callee CallFrame.

LayoutTests: Added a test for:

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=41948
REGRESSION(r60392): Registerfile can be unwound too far following an exception

  • fast/js/exception-registerfile-shrink-expected.txt: Added.
  • fast/js/exception-registerfile-shrink.html: Added.
  • fast/js/script-tests/exception-registerfile-shrink.js: Added.
1:51 PM Changeset in webkit [70173] by eric.carlson@apple.com
  • 2 edits in trunk/WebKit2

2010-10-20 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Crash closing page with <video> element
https://bugs.webkit.org/show_bug.cgi?id=47960
<rdar://problem/8573297>

I couldn't think of a good way to make a layout test for this because the
crash isn't triggered by closing an iframe.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::scheduleCompositingLayerSync): NULL check drawingArea().
1:51 PM Changeset in webkit [70172] by hyatt@apple.com
  • 6 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=48001

Reviewed by Dan Bernstein.

Make boxes place themselves properly in the block direction. Get basic painting working for spans and add a test that
verifies that span painting and replaced element painting (like images) works correctly.

Added fast/blockflow/basic-vertical-line.html

WebCore:

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::verticalPositionForBox):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::flipLinesInBlockDirection):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

  • rendering/InlineFlowBox.h:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::isFlippedLinesWritingMode):

LayoutTests:

  • fast/blockflow/basic-vertical-line.html: Added.
  • platform/mac/fast/blockflow/basic-vertical-line-expected.checksum: Added.
  • platform/mac/fast/blockflow/basic-vertical-line-expected.png: Added.
  • platform/mac/fast/blockflow/basic-vertical-line-expected.txt: Added.
1:44 PM Changeset in webkit [70171] by eric@webkit.org
  • 7 edits
    2 deletes in trunk/WebKitTools

2010-10-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch doesn't get along with git rm
https://bugs.webkit.org/show_bug.cgi?id=47940

Turns out we need to pass "--" to tell git this is a path.

  • Scripts/webkitpy/common/checkout/scm.py:
1:38 PM Changeset in webkit [70170] by Beth Dakin
  • 27 edits
    12 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=47514 CSS
transforms should affect scrolling

Reviewed by Dave Hyatt.

This patch causes topmostPosition, lowestPosition,
leftmostPosition, and rightmostPosition to take transforms into
account.

Compute the topmost/lowest/leftmost/rightmost position without
factoring in the block's transform until the end.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::topmostPosition):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):

  • rendering/RenderBlock.h:

transformedFrameRect() returns the frameRect() transformed to the
layer's transform. applyLayerTransformToRect() does the same thing
for the input rect.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::applyLayerTransformToRect):
(WebCore::RenderBox::transformedFrameRect):
(WebCore::RenderBox::topmostPosition):
(WebCore::RenderBox::lowestPosition):
(WebCore::RenderBox::rightmostPosition):
(WebCore::RenderBox::leftmostPosition):

  • rendering/RenderBox.h:
  • rendering/RenderMedia.cpp:

(WebCore::RenderMedia::topmostPosition):
(WebCore::RenderMedia::lowestPosition):
(WebCore::RenderMedia::rightmostPosition):
(WebCore::RenderMedia::leftmostPosition):

  • rendering/RenderMedia.h:
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::topmostPosition):
(WebCore::RenderTableSection::lowestPosition):
(WebCore::RenderTableSection::rightmostPosition):
(WebCore::RenderTableSection::leftmostPosition):

  • rendering/RenderTableSection.h:

LayoutTests: New tests and updated results for https://bugs.webkit.org/show_bug.cgi?id=47514
CSS transforms should affect scrolling

Reviewed by Dave Hyatt.

New tests.

  • fast/transforms/rotated-transform-affects-scrolling-1.html: Added.
  • fast/transforms/rotated-transform-affects-scrolling-2.html: Added.
1:36 PM Changeset in webkit [70169] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch doesn't get along with git rm
https://bugs.webkit.org/show_bug.cgi?id=47940

Turns out we need to pass "--" to tell git this is a path.

  • Scripts/webkitpy/common/checkout/scm.py:
1:28 PM Changeset in webkit [70168] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-10-20 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Rename SVGAnimatedProperty* -> DeprecatedSVGAnimatedProperty*
https://bugs.webkit.org/show_bug.cgi?id=47973

Copy headers from svg/properties, otherwhise builds from scratch on win are broken.

  • WebCore.vcproj/copyForwardingHeaders.cmd:
1:11 PM Changeset in webkit [70167] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70151.
http://trac.webkit.org/changeset/70151
https://bugs.webkit.org/show_bug.cgi?id=47995

This patch introduced failures on some bots which have
different versions of libsoup (Requested by mrobinson on
#webkit).

  • platform/gtk/Skipped:
1:07 PM Changeset in webkit [70166] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-10-20 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard
https://bugs.webkit.org/show_bug.cgi?id=47369

r46947 added code that limits the size of the layer-backed view on Leopard when
the page height exceeds 4096px (later adjusted to 2048px in r48401).

Later, r67576 altered the geometry flipping behavior to push the geometry flipping
down into WebKit. However, the code that adjusts the hosting layer's sublayer transform
to account for layer-backed view size-limiting was not fixed at the same time.
This change corrects that.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateLayerHostingViewPosition]):
1:06 PM Changeset in webkit [70165] by commit-queue@webkit.org
  • 32 edits
    2 adds in trunk

2010-10-20 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

HTML parser should provide script column position within HTML document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271

Adds TextPosition* classes -- a structure that stores line/column/generation
level coordinates inside text document. Adds *BasedNumber classes -- typesafe int
wrappers that emphasize whether int number is used as zero-based or
one-based.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/text/TextPosition.h: Added. (WTF::TextPosition::TextPosition): (WTF::TextPosition::minimumPosition): (WTF::TextPosition::belowRangePosition): (WTF::ZeroBasedNumber::fromZeroBasedInt): (WTF::ZeroBasedNumber::ZeroBasedNumber): (WTF::ZeroBasedNumber::zeroBasedInt): (WTF::ZeroBasedNumber::base): (WTF::ZeroBasedNumber::belowBase): (WTF::OneBasedNumber::fromOneBasedInt): (WTF::OneBasedNumber::OneBasedNumber): (WTF::OneBasedNumber::oneBasedInt): (WTF::OneBasedNumber::convertAsZeroBasedInt): (WTF::OneBasedNumber::convertToZeroBased): (WTF::OneBasedNumber::base): (WTF::OneBasedNumber::belowBase): (WTF::toZeroBasedTextPosition): (WTF::toOneBasedTextPosition): (WTF::ZeroBasedNumber::convertToOneBased):

2010-10-20 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

HTML parser should provide script column position within HTML document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271

Replaces line number with TextPosition struct so that script engine
gets script starting line/column.

  • ForwardingHeaders/wtf/text/TextPosition.h: Added.
  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::eventHandlerPosition):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::startLine): (WebCore::ScriptSourceCode::startPosition):
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::prepareListenerObject):
  • bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::runScript):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate): (WebCore::WorkerContextExecutionProxy::runScript):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  • dom/PendingScript.cpp: (WebCore::PendingScript::releaseElementAndClear):
  • dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=): (WebCore::PendingScript::startingPosition):
  • dom/ScriptableDocumentParser.h:
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::textPositionOneBased):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): (WebCore::HTMLDocumentParser::textPosition):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript): (WebCore::HTMLScriptRunner::execute): (WebCore::HTMLScriptRunner::runScript):
  • html/parser/HTMLScriptRunner.h:
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::uninitializedPositionValue1): (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::takeScriptToProcess): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processScriptStartTag):
  • html/parser/HTMLTreeBuilder.h:

2010-10-20 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

HTML parser should provide script column position within HTML document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271

Replaces script line number with TextPosition structure.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeScript): (WebKit::WebFrameImpl::executeScriptInIsolatedWorld): (WebKit::WebFrameImpl::executeScriptAndReturnValue):
12:49 PM Changeset in webkit [70164] by robert@webkit.org
  • 5 edits in trunk

2010-10-20 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Fix layoutTestController.getJsObjectCount

Qt Bridge doesn't know size_t so pass result as unsigned int.

Unskip fast/dom/gc-10.html

https://bugs.webkit.org/show_bug.cgi?id=47931

  • platform/qt/Skipped:

2010-10-20 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Fix layoutTestController.getJsObjectCount

Qt Bridge doesn't know size_t so pass result as unsigned int.

Unskip fast/dom/gc-10.html

https://bugs.webkit.org/show_bug.cgi?id=47931

  • DumpRenderTree/qt/GCControllerQt.cpp: (GCController::getJSObjectCount):
  • DumpRenderTree/qt/GCControllerQt.h:
12:46 PM Changeset in webkit [70163] by mitz@apple.com
  • 1 edit
    1 copy
    3 adds in trunk/LayoutTests

Updated Mac results for fast/text/hyphenate-locale.html

Rubber-stamped by Anders Carlsson.

  • platform/mac-snowleopard/fast: Added.
  • platform/mac-snowleopard/fast/text: Added.
  • platform/mac-snowleopard/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
  • platform/mac/fast/text/hyphenate-locale-expected.txt: Replaced.
12:37 PM Changeset in webkit [70162] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Out of process plug-ins are never asked to initially paint
https://bugs.webkit.org/show_bug.cgi?id=47993
<rdar://problem/8570342>

Reviewed by Darin Adler.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new callMemberFunction overload.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paintEntirePlugin):
Set the dirty rect to be the entire plug-in rect and then paint the plug-in.

  • PluginProcess/PluginControllerProxy.messages.in:

Add PaintEntirePlugin message.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::PluginProxy):
Initialize m_pluginBackingStoreContainsValidData to false.

(WebKit::PluginProxy::paint):
If m_pluginBackingStoreContainsValidData is false, synchronously ask the plug-in to paint,
then blit the plug-in backing store into our own backing store.

(WebKit::PluginProxy::geometryDidChange):
Set m_pluginBackingStoreContainsValidData to false.

(WebKit::PluginProxy::update):
Set m_pluginBackingStoreContainsValidData to true if the plug-in has painted its entire area.

12:20 PM Changeset in webkit [70161] by jam@chromium.org
  • 1 edit in trunk/LayoutTests/plugins/mouse-move-over-plugin-in-frame-expected.txt

Follow-up to 70155: mmatch newlines for test expectation

12:13 PM QtWebKitContrib edited by Ademar Reis
(diff)
12:11 PM QtWebKit edited by Ademar Reis
(diff)
12:08 PM Changeset in webkit [70160] by jam@chromium.org
  • 1 edit in trunk/LayoutTests/plugins/mouse-move-over-plugin-in-frame-expected.txt

Update expectations

11:59 AM Changeset in webkit [70159] by jam@chromium.org
  • 1 edit
    1 copy
    1 delete in branches/chromium/552/LayoutTests

Merge 70157 - 2010-10-20 James Robinson <jamesr@chromium.org>

Follow-up to 70155: rename an expectation to -expected.txt

  • plugins/mouse-move-over-plugin-in-frame-expected.txt: Renamed from LayoutTests/plugins/mouse-move-over-plugin-in-frame.txt.

TBR=jamesr@google.com

11:55 AM QtWebKitBackportingFixes edited by Ademar Reis
(diff)
11:52 AM QtBackLog edited by Ademar Reis
deprecate page (diff)
11:45 AM QtWebKit edited by Ademar Reis
(diff)
11:31 AM QtWebKitReleases edited by Ademar Reis
(diff)
11:17 AM Changeset in webkit [70158] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=47994

Reviewed by Simon Fraser.

Make computeBlockDirectionPositionsForLine writing-mode-aware. None of the functions it calls are patched yet.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):

11:12 AM Changeset in webkit [70157] by jamesr@google.com
  • 1 edit
    1 move in trunk/LayoutTests

2010-10-20 James Robinson <jamesr@chromium.org>

Follow-up to 70155: rename an expectation to -expected.txt

  • plugins/mouse-move-over-plugin-in-frame-expected.txt: Renamed from LayoutTests/plugins/mouse-move-over-plugin-in-frame.txt.
11:11 AM QtWebKitReleases edited by Ademar Reis
(diff)
11:10 AM Changeset in webkit [70156] by vangelis@chromium.org
  • 3 edits in branches/chromium/552/WebCore/platform/graphics/chromium

Merge 70075 - 2010-10-19 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Disable mipmapping for ImageLayer's to prevent memory use and
performance regression.
https://bugs.webkit.org/show_bug.cgi?id=47913


This patch is a straight revert of the patch committed with issue 46493

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::updateTextureRect):
  • platform/graphics/chromium/ContentLayerChromium.h: (WebCore::ContentLayerChromium::SharedValues::initialized):
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):

TBR=vangelis@chromium.org
BUG=59828

11:09 AM Changeset in webkit [70155] by jam@chromium.org
  • 9 edits
    3 copies in branches/chromium/552

Merge 70153 - 2010-10-20 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix crash when mousing over scrollview
https://bugs.webkit.org/show_bug.cgi?id=47956

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::mouseDidMoveOverElement):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::pluginScriptableObject):
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::redirectDataToPlugin):
  • src/WebPluginContainerImpl.h: (WebKit::WebPluginContainerImpl::isPluginContainer):

2010-10-20 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix crash when mousing over scrollview
https://bugs.webkit.org/show_bug.cgi?id=47956

Test: plugins/mouse-move-over-plugin-in-frame.html

  • platform/Widget.h: (WebCore::Widget::isPluginContainer):

2010-10-20 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix crash when mousing over scrollview
https://bugs.webkit.org/show_bug.cgi?id=47956

  • plugins/mouse-move-over-plugin-in-frame.html: Added.
  • plugins/mouse-move-over-plugin-in-frame.txt: Added.
  • plugins/resources/mouse-move-over-plugin-in-frame.html: Added.

TBR=jam@chromium.org

11:07 AM Changeset in webkit [70154] by vangelis@chromium.org
  • 5 edits in branches/chromium/552/WebCore/platform/graphics/chromium

Merge 70010 - 2010-10-18 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Prevent the creation of very large textures for layers by switching
to "large layer" mode when a texture is larger than some fixed reasonable size
(set to 2000 pixels for now).
https://bugs.webkit.org/show_bug.cgi?id=47751

The code also changes the large layer logic to use the current scissor rect used
by the compositor instead of the visible rect to determine how to clip large layers.
This will provide additional texture savings. In addition, the various layer rects
have been converted to use integers instead of floats to preserve uniformity in the code.


Tests: Existing large layer layout tests including huge-layer and huge-layer-img

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::getDrawRect):
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::drawLayersRecursive): (WebCore::LayerRendererChromium::scissorToRect):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::currentScissorRect):

TBR=vangelis@chromium.org
BUG=58634

11:04 AM Changeset in webkit [70153] by jam@chromium.org
  • 9 edits
    3 adds in trunk

2010-10-20 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix crash when mousing over scrollview
https://bugs.webkit.org/show_bug.cgi?id=47956

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::mouseDidMoveOverElement):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::pluginScriptableObject):
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::redirectDataToPlugin):
  • src/WebPluginContainerImpl.h: (WebKit::WebPluginContainerImpl::isPluginContainer):

2010-10-20 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix crash when mousing over scrollview
https://bugs.webkit.org/show_bug.cgi?id=47956

Test: plugins/mouse-move-over-plugin-in-frame.html

  • platform/Widget.h: (WebCore::Widget::isPluginContainer):

2010-10-20 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix crash when mousing over scrollview
https://bugs.webkit.org/show_bug.cgi?id=47956

  • plugins/mouse-move-over-plugin-in-frame.html: Added.
  • plugins/mouse-move-over-plugin-in-frame.txt: Added.
  • plugins/resources/mouse-move-over-plugin-in-frame.html: Added.
11:01 AM QtWebKitWeeklyBuilds edited by Ademar Reis
(diff)
10:51 AM QtWebKitJournal edited by Ademar Reis
(diff)
10:27 AM QtWebKitBackportingFixes edited by Ademar Reis
(diff)
10:25 AM QtWebKitReleases edited by Ademar Reis
(diff)
10:22 AM QtWebKitReleases edited by Ademar Reis
(diff)
9:25 AM Changeset in webkit [70152] by commit-queue@webkit.org
  • 26 edits in trunk

2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70149.
http://trac.webkit.org/changeset/70149
https://bugs.webkit.org/show_bug.cgi?id=47989

"Build breaks in mac and win" (Requested by satish on
#webkit).

  • fast/speech/input-text-speechbutton.html:
  • fast/speech/speech-button-ignore-generated-events.html:
  • platform/chromium/test_expectations.txt:

2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70149.
http://trac.webkit.org/changeset/70149
https://bugs.webkit.org/show_bug.cgi?id=47989

"Build breaks in mac and win" (Requested by satish on
#webkit).

  • dom/Element.cpp: (WebCore::Element::computeInheritedLanguage):
  • page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h:
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): (WebCore::SpeechInputClientMock::timerFired):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):

2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70149.
http://trac.webkit.org/changeset/70149
https://bugs.webkit.org/show_bug.cgi?id=47989

"Build breaks in mac and win" (Requested by satish on
#webkit).

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
  • public/WebSpeechInputControllerMock.h:
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::startRecognition):
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
  • src/WebSpeechInputControllerMockImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:

2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70149.
http://trac.webkit.org/changeset/70149
https://bugs.webkit.org/show_bug.cgi?id=47989

"Build breaks in mac and win" (Requested by satish on
#webkit).

  • DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult):
9:07 AM Changeset in webkit [70151] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-20 Martin Robinson <mrobinson@igalia.com>

Unskip some tests that are now passing.

  • platform/gtk/Skipped: Unskip passing tests.
8:59 AM Changeset in webkit [70150] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2010-10-19 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews

AppKit has some special code to prevent it meddling with view's layers
under layer-backed WebViews. When a layer-backed WebView became composited,
this caused our layer to remain zero-sized. Fix this by manually
setting the geometry for our layer, if the WebHTMLView has a layer.

This does not seem to be a problem if the WebView becomes layer-backed, or
stops being layer-backed after the WebView starts using compositing.

  • WebView/WebHTMLView.mm: (-[WebHTMLView attachRootLayer:]):
8:56 AM Changeset in webkit [70149] by andreip@google.com
  • 26 edits in trunk

2010-10-19 Leandro Gracia Gil <leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Added a layout test for the language tag in speech input. Updated
the speech button tests to include the new language parameter in the
mock result.
https://bugs.webkit.org/show_bug.cgi?id=47089

  • fast/speech/input-text-language-tag-expected.txt: Added.
  • fast/speech/input-text-language-tag.html: Added.
  • fast/speech/input-text-speechbutton.html: Added an empty language parameter.
  • fast/speech/speech-button-ignore-generated-events.html: Added an empty language parameter.
  • platform/chromium/test_expectations.txt: language tag test is expected to fail until the chromium-side patch has been applied.

2010-10-19 Leandro Gracia Gil <leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Patch the current speech input implementation to use and validate the
nearest language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=47089

This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see http://codereview.chromium.org/3615005/show and
http://codereview.chromium.org/3595018/show.

Test: fast/speech/input-text-language-tag.html

  • dom/Element.cpp: (WebCore::Element::computeInheritedLanguage): includes a brief character validation for the BCP 47 language tag.
  • page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h:
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): results are now stored by language using a hash map. (WebCore::SpeechInputClientMock::timerFired):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):

2010-10-19 Leandro Gracia Gil <leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Patch the current speech input implementation to use and validate the
nearest language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=47089

This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see http://codereview.chromium.org/3615005/show and
http://codereview.chromium.org/3595018/show.

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
  • public/WebSpeechInputControllerMock.h:
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::create): (WebKit::SpeechInputClientImpl::startRecognition):
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
  • src/WebSpeechInputControllerMockImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:

2010-10-19 Leandro Gracia Gil <leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Added a second parameter to setMockSpeechInputResult for
the language used in speech input.
https://bugs.webkit.org/show_bug.cgi?id=47089

  • DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult):
8:29 AM Changeset in webkit [70148] by jberlin@webkit.org
  • 2 edits in trunk/WebKit2

ASSERTION FAILURE: !m_adoptionIsRequired for the WebFrame under the
InjectedBundlePageLoaderClient::didClearWindowObjectForFrame callback.
https://bugs.webkit.org/show_bug.cgi?id=47960

Reviewed by Geoffrey Garen.

Do not try to initialize the coreFrame (which results in the
InjectedBundlePageLoaderClient::didClearWindowObjectForFrame being called) until after the
WebFrame constructor has returned and the WebFrame has been adopted.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::create):
Moved the call to init the coreFrame here ...
(WebKit::WebFrame::WebFrame):
... from here.

8:10 AM Changeset in webkit [70147] by tonikitoo@webkit.org
  • 7 edits
    2 adds in trunk/LayoutTests

2010-10-19 Antonio Gomes <agomes@rim.com>

Reviewed by Kenneth Rohde Christiansen.

Add an inner frame test to Document::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=47794

Patch continues to improve the test coverage of Document::nodesFromRect,
similarly to bugs 47795 (Add a test to nodesFromRect involving links and
text nodes) and 47766 (Enrich /fast/dom/nodesFromRect-basic.html test).
This time it is being adding tests involving inner frame contents.

Three situations are added:
1) Hit testing an inner frame from an outer document should not include

nodes of the former in the returned result, but the inner frame itself;

2) Hit testing inner frame and outer frame contents should return all

nodes in the later whose area intersect with the hit area and the intersected
inner frame itself;

3) Hit testing an inner document content should return all nodes in the inner document

whose area intersect the hit area.

Tests skipped on Win, Qt, GTK and Chromium.

  • fast/dom/nodesFromRect-inner-documents-expected.txt: Added.
  • fast/dom/nodesFromRect-inner-documents.html: Added.
  • fast/dom/resources/nodesFromRect.css:
  • fast/dom/resources/nodesFromRect.js:
7:16 AM Changeset in webkit [70146] by krit@webkit.org
  • 3 edits in trunk/LayoutTests

2010-10-20 Dirk Schulze <krit@webkit.org>

Unreviewed rebaseline of Snow Leopard pixel result after commit r69922.

  • platform/mac/svg/custom/text-linking-expected.checksum:
  • platform/mac/svg/custom/text-linking-expected.png:
6:33 AM Changeset in webkit [70145] by krit@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-10-20 Dirk Schulze <krit@webkit.org>

Unreviewed Chromium win build fix.

  • tests/TransparencyWinTest.cpp: (WebCore::TEST):
6:24 AM Changeset in webkit [70144] by krit@webkit.org
  • 5 edits in trunk/LayoutTests

2010-10-20 Dirk Schulze <krit@webkit.org>

Unreviewed rebaseline of SL pixel tests after commit r69928.

  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
6:09 AM Changeset in webkit [70143] by krit@webkit.org
  • 100 edits in trunk

2010-10-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Merge ColorSpace and ImageColorSpace enums
https://bugs.webkit.org/show_bug.cgi?id=47922

Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
to follow webkit style rules.

  • src/WebFontImpl.cpp: (WebKit::WebFontImpl::drawText):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::paintWithContext):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas):
  • tests/TransparencyWinTest.cpp: (WebCore::TEST):

2010-10-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Merge ColorSpace and ImageColorSpace enums
https://bugs.webkit.org/show_bug.cgi?id=47922

Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
to follow webkit style rules.

  • FullscreenVideoController.cpp: (HUDButton::draw): (HUDSlider::draw): (FullscreenVideoController::draw):
  • WebCoreSupport/WebDragClient.cpp: (WebDragClient::createDragImageForLink):
  • WebKitGraphics.cpp: (WebDrawText):

2010-10-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Merge ColorSpace and ImageColorSpace enums
https://bugs.webkit.org/show_bug.cgi?id=47922

Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
to follow webkit style rules.

  • Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):

2010-10-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Merge ColorSpace and ImageColorSpace enums
https://bugs.webkit.org/show_bug.cgi?id=47922

Merging these two enums makes it easier to implement color-interpolation as well as
color-interpolation-filter for SVG.
Added ColorSpaceLinearRGB to the ColorSpace enum and changed ImageColorSpace to ColorSpace in all related
files. Renamed enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
to follow webkit style rules.
Removed gray scale support in ImageBuffer since it is not used anymore on WebKit.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator ColorSpace):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • editing/SelectionController.cpp: (WebCore::SelectionController::paintCaret):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect): (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • inspector/InspectorController.cpp: (WebCore::drawOutlinedQuad): (WebCore::InspectorController::drawElementTitle):
  • mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::paint):
  • mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
  • mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):
  • mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
  • page/FrameView.cpp: (WebCore::FrameView::paintContents):
  • page/PrintContext.cpp: (WebCore::PrintContext::spoolAllPagesWithBoundaries):
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::paintScrollCorner):
  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paintScrollCorner):
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::paintBorder): (WebCore::PopupListBox::paint): (WebCore::PopupListBox::paintRow):
  • platform/chromium/ScrollbarThemeChromium.cpp: (WebCore::ScrollbarThemeChromium::paintTickmarks):
  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint):
  • platform/graphics/ColorSpace.h:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient):
  • platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState):
  • platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::transformColorSpace):
  • platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create):
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/cg/ColorCG.cpp: (WebCore::cachedCGColorSpace): (WebCore::cachedCGColor):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::linearRGBColorSpaceRef):
  • platform/graphics/cg/GraphicsContextCG.h:
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::cgImage): (WebCore::ImageBuffer::draw):
  • platform/graphics/cg/ImageBufferData.h:
  • platform/graphics/cg/ImageCG.cpp: (WebCore::imageWithColorSpace):
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::fillRect):
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::setupLayerForWhiteLayer):
  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
  • platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::apply):
  • platform/graphics/filters/FEMerge.cpp: (WebCore::FEMerge::apply):
  • platform/graphics/filters/FEOffset.cpp: (WebCore::FEOffset::apply):
  • platform/graphics/filters/FETile.cpp: (WebCore::FETile::apply):
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::effectContext):
  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::paint):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::setLayerBorderColor): (WebCore::setLayerBackgroundColor):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::GraphicsContext):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::draw):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::setLayerBorderColor): (WebCore::setLayerBackgroundColor):
  • platform/graphics/win/ImageCGWin.cpp: (WebCore::BitmapImage::getHBITMAPOfSize):
  • platform/graphics/win/ImageCairoWin.cpp: (WebCore::BitmapImage::getHBITMAPOfSize): (WebCore::BitmapImage::drawFrameMatchingSourceSize):
  • platform/graphics/win/WebLayer.cpp: (WebCore::WebLayer::drawInContext):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::fillRect):
  • platform/graphics/wince/ImageWinCE.cpp: (WebCore::BitmapImage::getHBITMAPOfSize):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::GraphicsContext):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::paintMediaButton): (WebCore::RenderThemeGtk::paintMediaSliderTrack): (WebCore::RenderThemeGtk::paintMediaSliderThumb):
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::paint):
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::doDrawTextAtPoint):
  • platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp: (WebCore::drawTextWithSpacing):
  • plugins/PluginView.cpp: (WebCore::PluginView::paintMissingPluginIcon):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintResizer):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaButton): (WebCore::paintMediaSlider): (WebCore::paintMediaVolumeSlider): (WebCore::paintMediaTimelineContainer):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyClippingToContext):
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource): (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
  • rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::createTileImage):
  • rendering/RenderSVGResourceSolidColor.cpp: (WebCore::RenderSVGResourceSolidColor::applyResource):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::paintScrollCorner):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintProgressBar): (WebCore::RenderThemeMac::paintMenuListButton):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButton):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton): (WebCore::RenderThemeWinCE::paintSliderTrack): (WebCore::RenderThemeWinCE::paintSliderThumb):
  • rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::createImageBuffer):
  • rendering/SVGImageBufferTools.h:
  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData):
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::apply):

2010-10-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Merge ColorSpace and ImageColorSpace enums
https://bugs.webkit.org/show_bug.cgi?id=47922

Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
to follow webkit style rules.

  • UIProcess/FindIndicator.cpp: (WebKit::FindIndicator::draw):
  • WebProcess/WebPage/FindPageOverlay.cpp: (WebKit::FindPageOverlay::drawRect):
2:43 AM Changeset in webkit [70142] by Nikolas Zimmermann
  • 2 edits in trunk/WebKit

2010-10-20 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Fix efl build, add missing svg/properties include directory.

  • CMakeLists.txt:
2:24 AM Changeset in webkit [70141] by jorlow@chromium.org
  • 6 edits
    2 copies in branches/chromium/552

Fix multiple index support in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=47919

BUG=59831

Reviewed by Nate Chapin.

LayoutTests:

Modify an existing test to verify behavior and add another test for
something I thought might have been related (but wasn't, but it still
seems like a good test).

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/queued-commands-expected.txt: Added.
  • storage/indexeddb/queued-commands.html: Added.

WebCore:

Fix 2 bugs that caused the IndexData of all but the last index to be
properly updated:

  • The objectStoreDataId is NOT unique if there are multiple indexes. So remove the constraint.
  • Do not delete all existing entries with that objectStoreDataId before adding an entry for each index. Only do it once at the beginning.

Test: storage/indexeddb/queued-commands.html

+ index-basics.html modified

  • storage/IDBFactoryBackendImpl.cpp:

(WebCore::createTables):

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::deleteIndexData):
(WebCore::putIndexData):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
Merge 70093 - 2010-10-19 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Fix multiple index support in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=47919

Modify an existing test to verify behavior and add another test for
something I thought might have been related (but wasn't, but it still
seems like a good test).

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/queued-commands-expected.txt: Added.
  • storage/indexeddb/queued-commands.html: Added.

2010-10-19 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Fix multiple index support in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=47919

Fix 2 bugs that caused the IndexData of all but the last index to be
properly updated:

  • The objectStoreDataId is NOT unique if there are multiple indexes. So remove the constraint.
  • Do not delete all existing entries with that objectStoreDataId before adding an entry for each index. Only do it once at the beginning.

Test: storage/indexeddb/queued-commands.html

+ index-basics.html modified

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::deleteIndexData): (WebCore::putIndexData): (WebCore::IDBObjectStoreBackendImpl::putInternal):

TBR=jorlow@chromium.org

2:24 AM Changeset in webkit [70140] by krit@webkit.org
  • 7 edits
    2 deletes in trunk/WebCore

2010-10-20 Dirk Schulze <krit@webkit.org>

Reviewed by Andreas Kling.

Remove left over code after moving Cairo port to ShadowContext
https://bugs.webkit.org/show_bug.cgi?id=47929

ImageBufferFilter is not needed anymore, since Cairo is using ShadowContext now.
Made kernelPosition() in FEGaussianBlur a inline function instead of a static function.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::kernelPosition):
  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/ImageBufferFilter.cpp: Removed.
  • platform/graphics/filters/ImageBufferFilter.h: Removed.
2:19 AM Changeset in webkit [70139] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-10-20 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Fix efl build, by adding the new svg/properties include directory.

  • CMakeLists.txt:
2:14 AM Changeset in webkit [70138] by Nikolas Zimmermann
  • 2 edits in trunk/WebKit2

2010-10-20 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Fix Qt/WebKit2 build, also needs a svg/properties include.

  • WebKit2.pro:
2:14 AM Changeset in webkit [70137] by caseq@chromium.org
  • 14 edits
    3 adds in trunk

2010-10-19 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: expose request/response cookies in HAR
https://bugs.webkit.org/show_bug.cgi?id=47894

Test: inspector/cookie-parser.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CookieParser.js: Added.
  • inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype._buildRequest): (WebInspector.HAREntry.prototype._buildResponse): (WebInspector.HAREntry.prototype._buildCookies): (WebInspector.HAREntry.prototype._buildCookie):
  • inspector/front-end/Resource.js: Parse Cookie/Set-Cookie headers and expose cookies. (WebInspector.Resource.prototype.set requestHeaders): (WebInspector.Resource.prototype.get requestCookies): (WebInspector.Resource.prototype.set responseHeaders): (WebInspector.Resource.prototype.get responseCookies): (WebInspector.Resource.prototype._parseRequestCookies): (WebInspector.Resource.prototype._parseResponseCookies):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

2010-10-19 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: expose request/response cookies in HAR
https://bugs.webkit.org/show_bug.cgi?id=47894

  • src/WebResourceRawHeaders.cpp: (WebKit::addHeader): paste coalescent headers using "\n: as a separator instead of ", "

2010-10-19 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: expose request/response cookies in HAR
https://bugs.webkit.org/show_bug.cgi?id=47894

  • http/tests/inspector/inspector-test.js: (dumpObject): Handle null objects as a special case (display null instead of empty object)
  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.addObject): Ditto.
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • inspector/cookie-parser-expected.txt: Added.
  • inspector/cookie-parser.html: Added.
2:06 AM Changeset in webkit [70136] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

2010-10-20 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Fix non-mac builds, by adding the new svg/properties include directory.

  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pro:
  • WebCore.vcproj/WebCoreCommon.vsprops:
1:32 AM Changeset in webkit [70135] by Nikolas Zimmermann
  • 12 edits
    4 moves
    1 add in trunk/WebCore

2010-10-20 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Roben.

Rename SVGAnimatedProperty* -> DeprecatedSVGAnimatedProperty*
https://bugs.webkit.org/show_bug.cgi?id=47973

Prepare fixing bug 47905, redesigning SVGAnimatedProperty. As we're going to move type by type
to the new animated property concept, keep the old one around, marked deprecated, until the
transition is finished.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • svg/DeprecatedSVGAnimatedProperty.h: Copied from svg/SVGAnimatedProperty.h. (WebCore::DeprecatedSVGAnimatedPropertyTearOff::DeprecatedSVGAnimatedPropertyTearOff): (WebCore::DeprecatedSVGAnimatedPropertyTearOff::~DeprecatedSVGAnimatedPropertyTearOff): (WebCore::DeprecatedSVGAnimatedProperty::~DeprecatedSVGAnimatedProperty): (WebCore::DeprecatedSVGAnimatedProperty::DeprecatedSVGAnimatedProperty): (WebCore::DeprecatedSVGAnimatedProperty::value): (WebCore::DeprecatedSVGAnimatedProperty::baseValue):
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Copied from svg/SVGAnimatedPropertyTraits.h.
  • svg/DeprecatedSVGAnimatedTemplate.h: Copied from svg/SVGAnimatedTemplate.h. (WebCore::DeprecatedSVGAnimatedTypeWrapperKey::DeprecatedSVGAnimatedTypeWrapperKey): (WebCore::DeprecatedSVGAnimatedTypeWrapperKey::operator==): (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHash::hash): (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHash::equal): (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHashTraits::constructDeletedValue): (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHashTraits::isDeletedValue): (WebCore::DeprecatedSVGAnimatedTemplate::~DeprecatedSVGAnimatedTemplate): (WebCore::DeprecatedSVGAnimatedTemplate::forgetWrapper): (WebCore::lookupOrCreateWrapper):
  • svg/SVGAnimatedProperty.h: Removed.
  • svg/SVGAnimatedPropertySynchronizer.h: Removed.
  • svg/SVGAnimatedPropertyTraits.h: Removed.
  • svg/SVGAnimatedTemplate.h: Removed.
  • svg/SVGElement.h:
  • svg/SVGExternalResourcesRequired.h:
  • svg/SVGFitToViewBox.h:
  • svg/SVGURIReference.h:
  • svg/properties: Added.
  • svg/properties/SVGAnimatedPropertySynchronizer.h: Copied from svg/SVGAnimatedPropertySynchronizer.h.
1:04 AM Changeset in webkit [70134] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-10-20 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antonio Gomes.

[Qt] Wrong null check in PopupMenuQt
https://bugs.webkit.org/show_bug.cgi?id=47945

Wrong null check in PopupMenuQt.

  • WebCoreSupport/PopupMenuQt.cpp: (WebCore::PopupMenuQt::hide):
12:52 AM Changeset in webkit [70133] by Philippe Normand
  • 2 edits in trunk/WebKit/gtk

2010-10-20 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] use gtk_widget_hide instead of gtk_widget_hide_all in the fullscreen video conroller
https://bugs.webkit.org/show_bug.cgi?id=47972

  • WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::hideHud): (FullscreenVideoController::exitFullscreen):
12:44 AM Changeset in webkit [70132] by hamaji@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-20 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

absolutely positioned list in inline element crashes
https://bugs.webkit.org/show_bug.cgi?id=45095

  • fast/lists/positioned-count-crash-expected.txt: Added.
  • fast/lists/positioned-count-crash.html: Added. Note that this test is failing for now.

2010-10-20 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

absolutely positioned list in inline element crashes
https://bugs.webkit.org/show_bug.cgi?id=45095

Add a NULL check to avoid crash. The rendering result isn't ideal yet.

Test: fast/lists/positioned-count-crash.html

  • rendering/RenderListItem.cpp: (WebCore::previousListItem):
12:21 AM Changeset in webkit [70131] by Adam Roben
  • 4 edits in trunk/WebKitLibraries

Windows build fix

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:

Use a WKCFURLCredentialRef type to protect against changes to the
definition of CFURLCredentialRef.

Oct 19, 2010:

11:45 PM Changeset in webkit [70130] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Windows build fix

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h: Check in

this file that I meant to check in in r70129.

11:36 PM Changeset in webkit [70129] by Adam Roben
  • 10 edits in trunk

Remove uses of CACFContextRef and CARender* from WebCore

These types are now wrapped in a WKCACFContext type exported by
WebKitSystemInterface.

Fixes <http://webkit.org/b/43244>.

Reviewed by Sam Weinig.

WebCore:

  • platform/graphics/win/WKCACFContextFlusher.cpp:

(WebCore::WKCACFContextFlusher::addContext):
(WebCore::WKCACFContextFlusher::removeContext):
(WebCore::WKCACFContextFlusher::flushAllContexts):

  • platform/graphics/win/WKCACFContextFlusher.h:

Changed to use WKCACFContext. We don't retain/release the context when
putting it into/taking it out of the set. WKCACFContext is not a
ref-counted type, so we can't retain/release it, but the
retain/release was also unnecessary as WKCACFLayerRenderer calls
removeContext before the context is destroyed.

  • platform/graphics/win/WKCACFLayer.cpp:

(WebCore::WKCACFLayer::becomeRootLayerForContext):

  • platform/graphics/win/WKCACFLayer.h:

Changed to use WKCACFContext.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::didFlushContext):
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::layerTreeDidChange):
(WebCore::WKCACFLayerRenderer::createRenderer):
(WebCore::WKCACFLayerRenderer::destroyRenderer):
(WebCore::WKCACFLayerRenderer::render): Also replaced uses of
CGSRegion with WebKitSystemInterface functions/types.
(WebCore::WKCACFLayerRenderer::resetDevice):

  • platform/graphics/win/WKCACFLayerRenderer.h:

Replaced our CACFContextRef, CARenderContext, and CARenderOGLContext
with a single WKCACFContext, which wraps all three. We hold a bare
pointer to it and destroy it in our destructor.

WebKitLibraries:

Add WKCACFContext and related functions

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
11:33 PM Changeset in webkit [70128] by Adam Roben
  • 2 edits in trunk/WebKitTools

Teach update-webkit-support-libs about the new versioning of WebKitSupportLibrary

Fixes <http://webkit.org/b/47915> update-webkit-support-libs should
check version numbers instead of modification times

Reviewed by Sam Weinig.

  • Scripts/update-webkit-support-libs: Fetch the expected version

number from developer.apple.com, then compare with the version number
of the extracted library and of the zipped library to see if anything
needs to be done. Removed code that tracked the modified timestamp of
the library, as it is no longer needed.

9:59 PM Changeset in webkit [70127] by yuzo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-10-19 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test rebaseline.

  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png: Added.
9:43 PM Changeset in webkit [70126] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-19 Kwang Yul Seo <skyul@company100.net>

Reviewed by David Kilzer.

[BREWMP] Turn off JIT for simulator build
https://bugs.webkit.org/show_bug.cgi?id=47937

We don't need to test x86 JIT.

  • wtf/Platform.h:
8:34 PM Changeset in webkit [70125] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-10-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70124.
http://trac.webkit.org/changeset/70124
https://bugs.webkit.org/show_bug.cgi?id=47965

test expectation conflict (Requested by yuzo on #webkit).

  • platform/chromium/test_expectations.txt:
8:24 PM Changeset in webkit [70124] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-10-19 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

The following tests are failing for WIN and LINUX.
editing/spelling/spelling-contenteditable.html
editing/spelling/spelling-textarea.html

  • platform/chromium/test_expectations.txt:
8:19 PM Changeset in webkit [70123] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-10-19 James Robinson <jamesr@chromium.org>

Update chromium expectations.

  • platform/chromium/test_expectations.txt:
8:07 PM Changeset in webkit [70122] by jamesr@google.com
  • 2 edits
    7 adds in trunk/LayoutTests

2010-10-19 James Robinson <jamesr@chromium.org>

Update chromium expectations and add baselines for new test.

  • platform/chromium-linux/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
  • platform/chromium-linux/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
  • platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
  • platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
  • platform/chromium-win/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
  • platform/chromium-win/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
  • platform/chromium-win/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
7:53 PM Changeset in webkit [70121] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitSite

2010-10-19 Jenn Braithwaite <jennb@chromium.org>

Reviewed by David Levin.

Add DirectX SDK to Installing Developer Tools web page
https://bugs.webkit.org/show_bug.cgi?id=47911

  • building/tools.html:
7:18 PM Changeset in webkit [70120] by commit-queue@webkit.org
  • 2 edits in trunk

2010-10-19 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed, adding missed additionalArguments.

[CMAKE] additional arguments was missed in GENERATE_DOM_NAMES
https://bugs.webkit.org/show_bug.cgi?id=47694

Pass additionalArguments for make_names.pl to choose enabled features.

  • cmake/WebKitMacros.cmake:
6:55 PM Changeset in webkit [70119] by kbr@google.com
  • 2 edits
    169 adds in trunk/LayoutTests

2010-10-19 Kenneth Russell <kbr@google.com>

Unreviewed, test expectations update.

Added initial test expectations for the chromium-gpu configuration,
generated on Windows. Pixel results have been added under chromium-gpu-win.
The hope is that at least the text results might be shareable between the
Windows and Linux platforms; for the time being, they are being placed
under chromium-gpu, though they may be moved in the near future.

platform/chromium-gpu/test_expectations.txt still has all of the tests
marked "PASS FAIL". Only once we have a certain set of the tests passing on
all three platforms (Windows, Mac, Linux) will we remove the FAIL from that
line. The current effort has focused on the "compositing" directory.

  • platform/chromium-gpu-win/compositing: Added.
  • platform/chromium-gpu-win/compositing/animation: Added.
  • platform/chromium-gpu-win/compositing/animation/state-at-end-event-transform-layer-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
  • platform/chromium-gpu-win/compositing/compositing-visible-descendant-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/compositing-visible-descendant-expected.png: Added.
  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-gpu-win/compositing/generated-content-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/generated-content-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry: Added.
  • platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/outline-change-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/outline-change-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/partial-layout-update-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/partial-layout-update-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/root-layer-update-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/root-layer-update-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-gpu-win/compositing/iframes: Added.
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-gpu-win/compositing/iframes/iframe-content-flipping-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/iframes/iframe-content-flipping-expected.png: Added.
  • platform/chromium-gpu-win/compositing/iframes/iframe-copy-on-scroll-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
  • platform/chromium-gpu-win/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
  • platform/chromium-gpu-win/compositing/images: Added.
  • platform/chromium-gpu-win/compositing/images/direct-image-background-color-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/images/direct-image-background-color-expected.png: Added.
  • platform/chromium-gpu-win/compositing/overflow: Added.
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/chromium-gpu-win/compositing/overflow/overflow-positioning-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-gpu-win/compositing/overflow/overflow-scroll-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/chromium-gpu-win/compositing/overflow/parent-overflow-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/overflow/parent-overflow-expected.png: Added.
  • platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.png: Added.
  • platform/chromium-gpu-win/compositing/overflow/zero-size-overflow-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/overflow/zero-size-overflow-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections: Added.
  • platform/chromium-gpu-win/compositing/reflections/backface-hidden-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/backface-hidden-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-gpu-win/compositing/repaint: Added.
  • platform/chromium-gpu-win/compositing/repaint/become-overlay-composited-layer-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
  • platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.png: Added.
  • platform/chromium-gpu-win/compositing/repaint/layer-repaint-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/repaint/layer-repaint-expected.png: Added.
  • platform/chromium-gpu-win/compositing/repaint/layer-repaint-rects-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/repaint/layer-repaint-rects-expected.png: Added.
  • platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute2-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.png: Added.
  • platform/chromium-gpu-win/compositing/sibling-positioning-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/sibling-positioning-expected.png: Added.
  • platform/chromium-gpu-win/compositing/transitions: Added.
  • platform/chromium-gpu-win/compositing/transitions/singular-scale-transition-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/transitions/singular-scale-transition-expected.png: Added.
  • platform/chromium-gpu/compositing/animation: Added.
  • platform/chromium-gpu/compositing/animation/animated-composited-inside-hidden-expected.txt: Added.
  • platform/chromium-gpu/compositing/animation/animation-compositing-expected.txt: Added.
  • platform/chromium-gpu/compositing/animation/computed-style-during-delay-expected.txt: Added.
  • platform/chromium-gpu/compositing/animation/state-at-end-event-transform-layer-expected.txt: Added.
  • platform/chromium-gpu/compositing/composited-negative-zindex-child-expected.txt: Added.
  • platform/chromium-gpu/compositing/compositing-visible-descendant-expected.txt: Added.
  • platform/chromium-gpu/compositing/direct-image-compositing-expected.txt: Added.
  • platform/chromium-gpu/compositing/generated-content-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry: Added.
  • platform/chromium-gpu/compositing/geometry/clip-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/clipping-foreground-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/empty-embed-rects-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/fixed-in-composited-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/fixed-position-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/huge-layer-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/outline-change-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/partial-layout-update-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/preserve-3d-switching-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/root-layer-update-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added.
  • platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes: Added.
  • platform/chromium-gpu/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/iframe-content-flipping-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/iframe-size-to-zero-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/iframe-src-change-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/layout-on-compositing-change-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/remove-iframe-crash-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/scrolling-iframe-expected.txt: Added.
  • platform/chromium-gpu/compositing/images: Added.
  • platform/chromium-gpu/compositing/images/clip-on-directly-composited-image-expected.txt: Added.
  • platform/chromium-gpu/compositing/images/content-image-expected.txt: Added.
  • platform/chromium-gpu/compositing/images/direct-image-background-color-expected.txt: Added.
  • platform/chromium-gpu/compositing/layer-creation: Added.
  • platform/chromium-gpu/compositing/layer-creation/scroll-partial-update-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow: Added.
  • platform/chromium-gpu/compositing/overflow/clip-descendents-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/get-transform-from-non-box-container-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/overflow-positioning-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/overflow-scroll-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/parent-overflow-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/resize-painting-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/scrollbar-painting-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/zero-size-overflow-expected.txt: Added.
  • platform/chromium-gpu/compositing/plugins: Added.
  • platform/chromium-gpu/compositing/plugins/1x1-composited-plugin-expected.txt: Added.
  • platform/chromium-gpu/compositing/plugins/large-to-small-composited-plugin-expected.txt: Added.
  • platform/chromium-gpu/compositing/plugins/small-to-large-composited-plugin-expected.txt: Added.
  • platform/chromium-gpu/compositing/reflections: Added.
  • platform/chromium-gpu/compositing/reflections/backface-hidden-reflection-expected.txt: Added.
  • platform/chromium-gpu/compositing/reflections/reflection-in-composited-expected.txt: Added.
  • platform/chromium-gpu/compositing/repaint: Added.
  • platform/chromium-gpu/compositing/repaint/become-overlay-composited-layer-expected.txt: Added.
  • platform/chromium-gpu/compositing/repaint/content-into-overflow-expected.txt: Added.
  • platform/chromium-gpu/compositing/repaint/inline-repaint-container-expected.txt: Added.
  • platform/chromium-gpu/compositing/repaint/layer-repaint-expected.txt: Added.
  • platform/chromium-gpu/compositing/repaint/layer-repaint-rects-expected.txt: Added.
  • platform/chromium-gpu/compositing/repaint/opacity-between-absolute-expected.txt: Added.
  • platform/chromium-gpu/compositing/repaint/opacity-between-absolute2-expected.txt: Added.
  • platform/chromium-gpu/compositing/repaint/overflow-into-content-expected.txt: Added.
  • platform/chromium-gpu/compositing/sibling-positioning-expected.txt: Added.
  • platform/chromium-gpu/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
  • platform/chromium-gpu/compositing/tiling/huge-layer-resize-expected.txt: Added.
  • platform/chromium-gpu/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
  • platform/chromium-gpu/compositing/transitions: Added.
  • platform/chromium-gpu/compositing/transitions/opacity-on-inline-expected.txt: Added.
  • platform/chromium-gpu/compositing/transitions/singular-scale-transition-expected.txt: Added.
  • platform/chromium-gpu/test_expectations.txt:
6:44 PM Changeset in webkit [70118] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk

2010-10-19 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by Dan Bernstein.

Pixel cracks when using background image sprite on transformed element at certain scales.
https://bugs.webkit.org/show_bug.cgi?id=47868

  • fast/images/pixel-crack-image-background-webkit-transform-scale.html: Added.
  • fast/images/resources/pixel-crack-image-background-webkit-transform-scale.png: Added.
  • platform/mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
  • platform/mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
  • platform/mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.txt: Added.

2010-10-19 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by Dan Bernstein.

Pixel cracks when using background image sprite on transformed element at certain scales.
https://bugs.webkit.org/show_bug.cgi?id=47868

The pixel bleeding happens when the current context has scale and interpolation is kCGInterpolationHigh
or kCGInterpolationDefault. If the source rect size is smaller than the intrinsic image size, some
pixels outside of the clip rect will also be used to interpolate the color value for clip edges, which
results in unwanted thin lines around the painted area. We need to use sub-image patch to get rid of
the artifacts in this case.

Test: fast/images/pixel-crack-image-background-webkit-transform-scale.html

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
6:26 PM Changeset in webkit [70117] by eric@webkit.org
  • 7 edits
    1 add in trunk/WebKitTools

2010-10-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach feeder-queue how to feed the EWS bots
https://bugs.webkit.org/show_bug.cgi?id=47943

queues.webkit.org already knew how to accept EWS submissions
via /submit-to-ews. This teaches the feeder queue how to post
to that page with any new r? patches it sees.

  • QueueStatusServer/model/activeworkitems_unitest.py: Added.
    • More unit testing is always a good thing.
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/statusserver.py:
  • Scripts/webkitpy/tool/bot/feeders.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
6:25 PM Changeset in webkit [70116] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-10-19 James Robinson <jamesr@chromium.org>

Remove test expectations entries for tests that consistently pass.

  • platform/chromium/test_expectations.txt:
6:10 PM Changeset in webkit [70115] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-19 Tony Chang <tony@chromium.org>

Unreviewed, plugins/plugin-javascript-access.html is
passing again on Chromium mac after a chromium side fix to TestShell.

  • platform/chromium/test_expectations.txt:
6:08 PM Changeset in webkit [70114] by evan@chromium.org
  • 3 edits in trunk/WebCore

2010-10-19 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

sqlite: remove unused member variable
https://bugs.webkit.org/show_bug.cgi?id=47957

There's no need to save the error code into a member variable
because nobody ever looks at it.

  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open):
  • platform/sql/SQLiteDatabase.h:
5:20 PM Changeset in webkit [70113] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-19 Jia Pu <jpu@apple.com>

Reviewed by James Robinson.

Moving cursor back to autocorrected word in the same line shouldn't remove the underline
https://bugs.webkit.org/show_bug.cgi?id=47629
<rdar://problem/8546758>

Patch <http://trac.webkit.org/changeset/70071> breaks some Chromium Mac hehavior. This patch
fixes that.

  • editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Add "!PLATFORM(MAC)" to make sure nothing changes on non-Mac platforms.
5:06 PM Changeset in webkit [70112] by jianli@chromium.org
  • 18 edits in branches/chromium/552

Merge 70102 - Rename createBlobURL to createObjectURL and revokeBlobURL to
revokeObjectURL per the latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=47934

Reviewed by Darin Fisher.

BUG=59875
TEST=none

TBR=jianli@chromium.org

4:55 PM Changeset in webkit [70111] by oliver@apple.com
  • 24 edits in trunk/JavaScriptCore

2010-10-19 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Remove support for JSVALUE32 from JSC
https://bugs.webkit.org/show_bug.cgi?id=47948

Remove all the code for supporting JSVALUE32 from JSC.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_lshift): (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emit_op_urshift): (JSC::JIT::emitSlow_op_urshift): (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emitSlow_op_jlesseq): (JSC::JIT::emit_op_bitand): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
  • jit/JITCall.cpp:
  • jit/JITInlineMethods.h: (JSC::JIT::emitGetFromCallFrameHeaderPtr): (JSC::JIT::emitGetFromCallFrameHeader32):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_next_pname):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val):
  • jit/JITStubs.h:
  • jit/JSInterfaceJIT.h:
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::tagReturnAsInt32):
  • jit/ThunkGenerators.cpp: (JSC::sqrtThunkGenerator): (JSC::powThunkGenerator):
  • runtime/Collector.cpp: (JSC::isPossibleCell): (JSC::typeName):
  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.h: (JSC::Structure::prototypeForLookup):
  • runtime/JSImmediate.h: (JSC::reinterpretIntptrToDouble): (JSC::JSImmediate::isIntegerNumber): (JSC::JSImmediate::isDouble): (JSC::JSImmediate::areBothImmediateIntegerNumbers): (JSC::JSImmediate::makeDouble): (JSC::JSImmediate::doubleValue): (JSC::JSImmediate::toBoolean): (JSC::JSImmediate::fromNumberOutsideIntegerRange): (JSC::JSImmediate::from): (JSC::JSImmediate::toDouble): (JSC::JSFastMath::rightShiftImmediateNumbers):
  • runtime/JSNumberCell.cpp:
  • runtime/JSNumberCell.h:
  • runtime/JSObject.h: (JSC::JSObject::JSObject):
  • runtime/JSValue.h:
  • runtime/NumberObject.h:
  • wtf/Platform.h:
4:41 PM Changeset in webkit [70110] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-19 Tony Chang <tony@chromium.org>

Unreviewed, updating drt expectations for plugin tests on mac.

  • platform/chromium/drt_expectations.txt:
4:40 PM Changeset in webkit [70109] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Fix MiniBrowser crashes during startup and shutdown
https://bugs.webkit.org/show_bug.cgi?id=47954

Reviewed by Sam Weinig.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::sharedProcessContext):
Initialize the main thread.

(WebKit::WebContext::create):
Ditto.

(WebKit::WebContext::WebContext):
Add the language observer here so we know that it will always be set up.

(WebKit::WebContext::ensureWebProcess):
Remove code.

  • UIProcess/WebContext.h:
4:27 PM Changeset in webkit [70108] by timothy@apple.com
  • 5 edits in trunk

Versioning.

4:25 PM Changeset in webkit [70107] by zmo@google.com
  • 4 edits in branches/chromium/552/WebCore

Merge 69804 - 2010-10-14 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Cache link status at linkProgram and use it in useProgram instead of querying GPU
https://bugs.webkit.org/show_bug.cgi?id=47685

  • html/canvas/WebGLProgram.cpp: Always cache link status at linkStatus and use it upon query. (WebCore::WebGLProgram::WebGLProgram):
  • html/canvas/WebGLProgram.h: Ditto. (WebCore::WebGLProgram::getLinkStatus): (WebCore::WebGLProgram::setLinkStatus):
  • html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::useProgram):

TBR=zmo@google.com

4:23 PM Changeset in webkit [70106] by timothy@apple.com
  • 1 copy in tags/Safari-534.10

New tag.

4:17 PM Changeset in webkit [70105] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-10-19 James Robinson <jamesr@chromium.org>

Update chromium test expectations

  • platform/chromium/test_expectations.txt:
4:15 PM Changeset in webkit [70104] by ap@apple.com
  • 2 edits in trunk/WebCore

Build fix (EFL, maybe more).

  • CMakeLists.txt: Added platform/Language.cpp here, too.
4:02 PM Changeset in webkit [70103] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-19 Eric Seidel <eric@webkit.org>

Unreviewed, just fixing test-webkitpy. I'm really on a roll today.

commit-queue gets stuck when release-patch returns 404
https://bugs.webkit.org/show_bug.cgi?id=47935

Fix test-webkitpy and unittest NetworkTransaction.

  • Scripts/webkitpy/common/net/networktransaction.py:
  • Scripts/webkitpy/common/net/networktransaction_unittest.py:
4:02 PM Changeset in webkit [70102] by jianli@chromium.org
  • 21 edits in trunk

Rename createBlobURL to createObjectURL and revokeBlobURL to
revokeObjectURL per the latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=47934

Reviewed by Darin Fisher.

WebCore:

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._contextMenu):

  • inspector/front-end/utilities.js:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::createObjectURL):
(WebCore::DOMWindow::revokeObjectURL):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::createObjectURL):
(WebCore::WorkerContext::revokeObjectURL):

  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:

LayoutTests:

Update all the related test and result files to account for the
renaming changes.

  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/files/apply-blob-url-to-img.html:
  • fast/files/apply-blob-url-to-xhr.html:
  • fast/files/create-blob-url-crash-expected.txt:
  • fast/files/create-blob-url-crash.html:
  • fast/files/revoke-blob-url-expected.txt:
  • fast/files/revoke-blob-url.html:
  • fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
3:59 PM Changeset in webkit [70101] by vangelis@chromium.org
  • 6 edits
    1 copy in branches/chromium/552

Merge 69747 - 2010-10-14 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
https://bugs.webkit.org/show_bug.cgi?id=47016

  • compositing/tiling/huge-layer-img.html: Added.
  • platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/mac-wk2/Skipped:
  • platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.

2010-10-14 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
https://bugs.webkit.org/show_bug.cgi?id=47016

Test: compositing/tiling

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerContentRect):

TBR=commit-queue@webkit.org

3:55 PM Changeset in webkit [70100] by vangelis@chromium.org
  • 8 edits
    1 delete in branches/chromium/552

Reverting 70099 as checkin messed up Changelog files..

Revert 70099 - Merge 69747 - 2010-10-14 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
https://bugs.webkit.org/show_bug.cgi?id=47016

  • compositing/tiling/huge-layer-img.html: Added.
  • platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/mac-wk2/Skipped:
  • platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.

2010-10-14 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
https://bugs.webkit.org/show_bug.cgi?id=47016

Test: compositing/tiling

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerContentRect):

TBR=commit-queue@webkit.org

TBR=vangelis@chromium.org

3:49 PM Changeset in webkit [70099] by vangelis@chromium.org
  • 8 edits
    1 copy in branches/chromium/552

Merge 69747 - 2010-10-14 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
https://bugs.webkit.org/show_bug.cgi?id=47016

  • compositing/tiling/huge-layer-img.html: Added.
  • platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/mac-wk2/Skipped:
  • platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.

2010-10-14 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
https://bugs.webkit.org/show_bug.cgi?id=47016

Test: compositing/tiling

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerContentRect):

TBR=commit-queue@webkit.org

3:48 PM Changeset in webkit [70098] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Coalesce plug-in drawing
https://bugs.webkit.org/show_bug.cgi?id=47939

Reviewed by Sam Weinig.

Coalesce plug-in drawing in the same manner as we do it in the chunked update drawing area.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_waitingForDidUpdate to false.

(WebKit::PluginControllerProxy::startPaintTimer):
Move code from invalidate out to here. Don't start the paint timer if m_waitingForDidUpdate is true.

(WebKit::PluginControllerProxy::invalidate):
Call startPaintTimer.

(WebKit::PluginControllerProxy::didUpdate):
Set m_waitingForDidUpdate to false and start the paint timer.

  • PluginProcess/PluginControllerProxy.messages.in:

Add DidUpdate message.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::PluginProxy):
Initialize m_waitingForPaintInResponseToUpdate to false.

(WebKit::PluginProxy::paint):
If m_waitingForPaintInResponseToUpdate is true, send a DidUpdate message.

(WebKit::PluginProxy::update):
Set m_waitingForPaintInResponseToUpdate to true.

3:45 PM Changeset in webkit [70097] by weinig@apple.com
  • 13 edits in trunk/WebKit2

Add alternateHTMLString and unreachableURL API to WebKit2
<rdar://problem/8557864>
https://bugs.webkit.org/show_bug.cgi?id=47938

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameCopyUnreachableURL):

  • UIProcess/API/C/WKFrame.h:

Add accessor for the unreachableURL if one is set. It will only be
set during a loadAlternateHTMLString and will be unset on the next normal
didStartProvisionalLoadForFrame call.

  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadHTMLString): Remove whitespace.
(WKPageLoadAlternateHTMLString):

  • UIProcess/API/C/WKPage.h:

Add function to load a string as "alternate", meant for use as error pages.

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::setUnreachableURL):
(WebKit::WebFrameProxy::unreachableURL):
Add setter/getter for the unreachableURL.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadAlternateHTMLString):
Plumb through the call to loadAlternateHTMLString to the WebProcess
and set the main frame's unreachableURL. This does nothing if no pages
have ever been loaded in this page.

(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
If this is not a provisional load of substitute data for an unreachableURL
(e.g. someone who called WKPageLoadAlternateHTMLString), reset the
frame's unreachableURL.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Update function signatures.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
Pass whether or not this is a load of SubstituteData for an unreachableURL
to the UIProcess.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadData):
(WebKit::WebPage::loadAlternateHTMLString):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Plumb through the loading of the alternate HTML string.

3:29 PM Changeset in webkit [70096] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-19 Eric Seidel <eric@webkit.org>

Unreviewed.

commit-queue gets stuck when release-patch returns 404
https://bugs.webkit.org/show_bug.cgi?id=47935

Turns out ClientForm gets upset if passed an int() instead of a string type.
Yay for untestable code.

  • Scripts/webkitpy/common/net/statusserver.py:
3:28 PM Changeset in webkit [70095] by ap@apple.com
  • 25 edits
    5 moves
    1 add in trunk

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=47933
<rdar://problem/8494337> navigator.language doesn't work in WebKit2

3:16 PM Changeset in webkit [70094] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-10-19 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Add "in select" insertion mode to parser.

This was added to the spec in:
http://html5.org/tools/web-apps-tracker?from=5520&to=5522

And as a result of:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=10314

https://bugs.webkit.org/show_bug.cgi?id=47706

No new tests. Open to ideas.

  • html/parser/HTMLElementStack.cpp: Added "in select" mode. (WebCore::HTMLNames::isSelectScopeMarker): Ditto. (WebCore::HTMLElementStack::inSelectScope): Ditto.
  • html/parser/HTMLElementStack.h: Ditto.
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): Use "in select" instead of "in table." (WebCore::HTMLTreeBuilder::processEndTag): Ditto.
3:10 PM Changeset in webkit [70093] by jorlow@chromium.org
  • 6 edits
    2 adds in trunk

2010-10-19 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Fix multiple index support in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=47919

Modify an existing test to verify behavior and add another test for
something I thought might have been related (but wasn't, but it still
seems like a good test).

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/queued-commands-expected.txt: Added.
  • storage/indexeddb/queued-commands.html: Added.

2010-10-19 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Fix multiple index support in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=47919

Fix 2 bugs that caused the IndexData of all but the last index to be
properly updated:

  • The objectStoreDataId is NOT unique if there are multiple indexes. So remove the constraint.
  • Do not delete all existing entries with that objectStoreDataId before adding an entry for each index. Only do it once at the beginning.

Test: storage/indexeddb/queued-commands.html

+ index-basics.html modified

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::deleteIndexData): (WebCore::putIndexData): (WebCore::IDBObjectStoreBackendImpl::putInternal):
3:06 PM Changeset in webkit [70092] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-10-19 Eric Seidel <eric@webkit.org>

Unreviewed. Will get Adam's commentary after his meeting
for now this gets the commit-cluster back running.

commit-queue gets stuck when release-patch returns 404
https://bugs.webkit.org/show_bug.cgi?id=47935

I taught NetworkTransaction the basics of 404 handling.
We'll want to go back and teach it how to handle urllib2 404's too
and then deploy it to the places that want it.

  • QueueStatusServer/handlers/releasepatch.py:
  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/networktransaction.py:
  • Scripts/webkitpy/common/net/statusserver.py:
2:58 PM Changeset in webkit [70091] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/efl

2010-10-19 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

[EFL] Add setting api for disabling auto resize window
https://bugs.webkit.org/show_bug.cgi?id=47787

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::setWindowRect): Return when auto_resize_window was disabled.
  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_enable_auto_resize_window_get): Added. (ewk_view_setting_enable_auto_resize_window_set): Added.
  • ewk/ewk_view.h:
2:42 PM Changeset in webkit [70090] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

2010-10-19 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Geoffrey Garen.

BytecodeGenerator::m_lastOpcodePosition must be initialized in all constructors
https://bugs.webkit.org/show_bug.cgi?id=47920

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Add missing member initialization.
2:38 PM Changeset in webkit [70089] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-10-19 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build after r70072. The logic looks incorrect, but
this fix tries to preserves it, even so.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (baselinePositionForAccessibilityRenderObject): (getAttributeSetForAccessibilityObject):
2:19 PM Changeset in webkit [70088] by eric@webkit.org
  • 13 edits
    1 copy
    1 add in trunk/WebKitTools

2010-10-19 Eric Seidel <eric@webkit.org>

Unreviewed. Fixing typos in my previous commit.

Make patch release explicit and not a magic part of "retry" status
https://bugs.webkit.org/show_bug.cgi?id=47909

All of these typos again due to our inability to unit
test much of this code. I added one unit test where
possible. activeworkitems_unittest.py will be in a separate patch.

  • QueueStatusServer/handlers/releasepatch.py:
  • QueueStatusServer/main.py:
  • QueueStatusServer/model/activeworkitems.py:
  • QueueStatusServer/model/workitems.py:
  • QueueStatusServer/model/workitems_unittest.py:
  • QueueStatusServer/templates/releasepatch.html:
  • Scripts/webkitpy/common/net/statusserver.py:
2:18 PM Changeset in webkit [70087] by jamesr@google.com
  • 3 edits in trunk/LayoutTests

2010-10-19 James Robinson <jamesr@chromium.org>

Update chromium expectations.

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
2:14 PM Changeset in webkit [70086] by tonikitoo@webkit.org
  • 4 edits in trunk/LayoutTests

2010-10-19 Antonio Gomes <agomes@rim.com>

Unreviewed complementary fix to r70058 (Part III).

Skipping fast/dom/nodesFromRect-links-and-text.html instead of fast/dom/nodesFromRect-links-and-text-expected.html.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
2:11 PM Changeset in webkit [70085] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Stop waiting for sync replies if the connection is closed
https://bugs.webkit.org/show_bug.cgi?id=47930

Reviewed by Adam Roben.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::Connection):
Initialize m_shouldWaitForSyncReplies to true.

(CoreIPC::Connection::sendSyncMessage):
Don't attempt to send a message if m_shouldWaitForSyncReplies is false.

(CoreIPC::Connection::waitForSyncReply):
Return if m_shouldWaitForSyncReplies was set to false.

(CoreIPC::Connection::connectionDidClose):
Set m_shouldWaitForSyncReplies to true and signal the semaphore.

  • Platform/CoreIPC/Connection.h:
2:11 PM Changeset in webkit [70084] by jer.noble@apple.com
  • 5 edits in trunk

Windows: Implement 'preload=none'
https://bugs.webkit.org/show_bug.cgi?id=47317
<rdar://problem/7718442>

Reviewed by Eric Carlson.

WebCore:

Implement the 'preload=none' identically to the mac implementation. Add three new
ivars: m_preload, m_delayLoad and m_movieURL; and override the MediaPlayerPrivate
functions: prepareToPlay() and setPreload().

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):

Initialize new ivars m_delayLoad and m_preload.

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::resumeLoad): Added; new.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load): Split contents between

load and loadInternal.

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::loadInternal): Added; new.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::prepareToPlay): Added; overrides MediaPlayerPrivate.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPreload): Added; overrides MediaPlayerPrivate.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

LayoutTests:

Do not skip the media/video-preload.html test on windows any longer.

  • platform/win/Skipped:
2:03 PM Changeset in webkit [70083] by enrica@apple.com
  • 2 edits in trunk/WebCore

Upstream support of KeyCodes for iOS
https://bugs.webkit.org/show_bug.cgi?id=47857

Reviewed by Alexey Proskuryakov.

  • platform/cocoa/KeyEventCocoa.mm:

(WebCore::windowsKeyCodeForCharCode): Added special handling of keyCodes for iOS.

1:59 PM Changeset in webkit [70082] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-10-19 Zhenyao Mo <zmo@google.com>

Unreviewed, remove a passing webgl test from test_expectations.txt.

  • platform/chromium/test_expectations.txt:
1:54 PM Changeset in webkit [70081] by tony@chromium.org
  • 5 edits
    1 add in trunk

2010-10-19 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Use webkit's TestNetscapePlugIn in DRT mac
https://bugs.webkit.org/show_bug.cgi?id=47850

  • platform/chromium/drt_expectations.txt: Update passing/failing test

list. More new passing tests than new failing tests.

2010-10-19 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Use webkit's TestNetscapePlugIn in DRT mac
https://bugs.webkit.org/show_bug.cgi?id=47850

  • WebKit.gyp: Copy WebKitTestPlugIn into plugins and add

GCC_SYMBOLS_PRIVATE_EXTERN: NO to export the symbols.

2010-10-19 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Use webkit's TestNetscapePlugIn in DRT mac
https://bugs.webkit.org/show_bug.cgi?id=47850

  • DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked

because we're going to name our plugin WebKitTestNetscapePlugIn
temporarily until the chromium forked plugin goes away.

1:47 PM Changeset in webkit [70080] by tonikitoo@webkit.org
  • 4 edits in trunk/LayoutTests

2010-10-19 Antonio Gomes <agomes@rim.com>

Unreviewed complementary fix to r70058 (Part II).

Skipping the test on Gtk, Qt and Windows, because they do not implement LayoutTestController::nodesFromRect.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
1:44 PM Changeset in webkit [70079] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

cr-mac bubble has caused status bubbles to wrap
https://bugs.webkit.org/show_bug.cgi?id=47928

We now have too many EWSes to fit in the bugs.webkit.org
status-bubble iframe when more than a couple EWS builds are pending.
To fix this I've reduced the space taken up by queue position,
and also moved cr-mac to the end of the list (since it's going to be
triple-digits for a while).

  • QueueStatusServer/model/queues.py:
  • QueueStatusServer/templates/statusbubble.html:
1:39 PM Changeset in webkit [70078] by tonikitoo@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

2010-10-19 Antonio Gomes <agomes@rim.com>

Unreviewed complementary fix to r70058.

  • fast/dom/nodesFromRect-links-and-text-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-links-and-text-expected.html.
1:34 PM Changeset in webkit [70077] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-10-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

iOS: ASSERT in Cache::adjustSize running layout tests
https://bugs.webkit.org/show_bug.cgi?id=47873

Inside Cache::pruneDeadResources we loop over the LRU lists and make resources purgeable
with Cache::makeResourcePurgeable(). This wasn't taking into account whether the resource
was already purgeable or not, and the makeResourcePurgeable call was always calling
adjustSize(). Now we make sure makeResourcePurgable only adjusts the size of the Cache's
dead sizes when it first marks the resource purgeable. Likewise, if a resource is marked
as purgeable and then evicted, we should not adjust the size again.

The balancing call is when we have a resource that has been marked as purgeable and we
successfully mark it as no longer purgeable in Cache::resourceForURL.

No test added because this requires testing purgeable memory.

  • loader/Cache.cpp: (WebCore::Cache::makeResourcePurgeable): (WebCore::Cache::evict):
12:43 PM Changeset in webkit [70076] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-19 Kwang Yul Seo <skyul@company100.net>

Reviewed by David Kilzer.

RVCT fails to compile DateMath.cpp due to overloaded function pow
https://bugs.webkit.org/show_bug.cgi?id=47844

Choose std::pow(double, double) among multiple overloaded pow functions
to fix build for RVCT.

  • wtf/DateMath.cpp: (WTF::parseES5DateFromNullTerminatedCharacters):
12:38 PM Changeset in webkit [70075] by vangelis@chromium.org
  • 4 edits in trunk/WebCore

2010-10-19 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Disable mipmapping for ImageLayer's to prevent memory use and
performance regression.
https://bugs.webkit.org/show_bug.cgi?id=47913


This patch is a straight revert of the patch committed with issue 46493

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::updateTextureRect):
  • platform/graphics/chromium/ContentLayerChromium.h: (WebCore::ContentLayerChromium::SharedValues::initialized):
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
12:23 PM Changeset in webkit [70074] by Patrick Gansterer
  • 3 edits in trunk/JavaScriptCore

2010-10-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Use UChar instead of wchar_t in UnicodeWinCE
https://bugs.webkit.org/show_bug.cgi?id=47904

Make UnicodeWinCE more portable, so we can use it for other ports too.

  • wtf/unicode/wince/UnicodeWinCE.cpp: (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSpace): (WTF::Unicode::isLetter): (WTF::Unicode::isUpper): (WTF::Unicode::isLower): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::isAlphanumeric): (WTF::Unicode::toTitleCase): (WTF::Unicode::mirroredChar): (WTF::Unicode::digitValue):
  • wtf/unicode/wince/UnicodeWinCE.h: (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isHighSurrogate): (WTF::Unicode::isLowSurrogate): (WTF::Unicode::umemcasecmp): (WTF::Unicode::surrogateToUcs4):
12:16 PM Changeset in webkit [70073] by zmo@google.com
  • 4 edits in trunk/WebCore

2010-10-18 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

gl-teximage.html fails on chromium webkit mac bot
https://bugs.webkit.org/show_bug.cgi?id=47034

  • platform/graphics/GraphicsContext3D.cpp: Deal with endians in 16 bit image data. (WebCore::convertColor16LittleTo8): (WebCore::convertColor16BigTo8): (WebCore::doPacking):
  • platform/graphics/GraphicsContext3D.h: Ditto.
  • platform/graphics/cg/GraphicsContext3DCG.cpp: Ditto. (WebCore::GraphicsContext3D::getImageData):
11:38 AM Changeset in webkit [70072] by hyatt@apple.com
  • 54 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=47841

Reviewed by Dan Bernstein.

Rework baselinePosition and lineHeight to be writing-mode-aware. There's a lot of refactoring here to clean up
the method parameters to be more readable and to simplify the subclassing of the various methods in order to
keep the horizontal/vertical querying to a minimum.

  • WebCore.xcodeproj/project.pbxproj:
  • mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::baselinePosition):

  • mathml/RenderMathMLFraction.h:
  • mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::baselinePosition):

  • mathml/RenderMathMLOperator.h:
  • mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::baselinePosition):

  • mathml/RenderMathMLRow.h:
  • mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::baselinePosition):

  • mathml/RenderMathMLSubSup.h:
  • mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::layout):
(WebCore::RenderMathMLUnderOver::baselinePosition):

  • mathml/RenderMathMLUnderOver.h:
  • rendering/InlineBox.h:

(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):

  • rendering/InlineTextBox.h:
  • rendering/RenderBR.cpp:

(WebCore::RenderBR::lineHeight):

  • rendering/RenderBR.h:

(WebCore::toRenderBR):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):
(WebCore::RenderBlock::localCaretRect):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::lineHeight):
(WebCore::RenderBox::baselinePosition):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::verticalPosition):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::lineHeight):
(WebCore::RenderInline::baselinePosition):

  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::baselinePosition):

  • rendering/RenderListBox.h:
  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::lineHeight):
(WebCore::RenderListMarker::baselinePosition):

  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp:
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGRoot.cpp:
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::baselinePosition):

  • rendering/RenderSlider.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::baselinePosition):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.h:

(WebCore::RenderTableCol::isTableCol):

  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.cpp:
  • rendering/RenderText.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeLogicalHeight):

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::baselinePosition):

  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::lineHeight):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::calculateBoundaries):

11:30 AM Changeset in webkit [70071] by commit-queue@webkit.org
  • 9 edits
    24 adds in trunk

2010-10-19 Jia Pu <jpu@apple.com>

Reviewed by Adele Peterson.

Moving cursor back to autocorrected word in the same line shouldn't remove the underline
https://bugs.webkit.org/show_bug.cgi?id=47629
<rdar://problem/8546758>

  • platform/mac-leopard/Skipped: New tests don't apply to this Mac OSX version.
  • platform/mac-snowleopard/Skipped: Ditto.
  • platform/mac-tiger/Skipped: Ditto.
  • platform/mac-wk2/Skipped: Ditto.
  • platform/mac/editing/spelling/autocorrection-delete-expected.checksum:
  • platform/mac/editing/spelling/autocorrection-delete-expected.png:
  • platform/mac/editing/spelling/click-autocorrected-word-expected.checksum: Added.
  • platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
  • platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
  • platform/mac/editing/spelling/click-autocorrected-word.html: Added.
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum: Added.
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
  • platform/mac/editing/spelling/delete-into-autocorrected-word.html: Added.
  • platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt: Added.
  • platform/mac/editing/spelling/delete-into-misspelled-word.html: Added.
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.checksum: Added.
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html: Added.
  • platform/mac/editing/spelling/move-cursor-around-misspelled-word-expected.txt: Added.
  • platform/mac/editing/spelling/move-cursor-around-misspelled-word.html: Added.
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.checksum: Added.
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html: Added.
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.checksum: Added.
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html: Added.

2010-10-19 Jia Pu <jpu@apple.com>

Reviewed by Adele Peterson.

Moving cursor back to autocorrected word in the same line shouldn't remove the underline
https://bugs.webkit.org/show_bug.cgi?id=47629
<rdar://problem/8546758>

Tests: platform/mac/editing/spelling/click-autocorrected-word.html

platform/mac/editing/spelling/delete-into-autocorrected-word.html
platform/mac/editing/spelling/delete-into-misspelled-word.html
platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html

  • editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Don't remove misspelling or autocorrection underlines when cursor is moved onto a word.
11:02 AM Changeset in webkit [70070] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-19 Tony Chang <tony@chromium.org>

Unreviewed. Rolling chromium DEPS to 63057 to pick up mac plugin
loading in DRT.

  • DEPS: bump chromium DEPS to 63057.
10:58 AM Changeset in webkit [70069] by ap@apple.com
  • 3 edits
    1 move in trunk/WebKit

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=47864
Convert WebNSUserDefaultsExtras.m to .mm

Also, fixed some issues in the process:

  • removed locking, which was only necessary when this code was in Foundation;
  • fixed notification center observer to actually work (previously, it picked up changes when application preferences changed, not when system language did);
  • removed unused NSString category;
  • updated style.
  • Misc/WebNSUserDefaultsExtras.m: Removed.
  • Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m. (createHTTPStyleLanguageCode): (+[NSUserDefaults _webkit_defaultsDidChange]): (addLanguageChangeObserver): (+[NSUserDefaults _webkit_preferredLanguageCode]):
10:56 AM Changeset in webkit [70068] by kbr@google.com
  • 3 edits in trunk/WebKitTools

2010-10-19 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
https://bugs.webkit.org/show_bug.cgi?id=47874

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
10:47 AM Changeset in webkit [70067] by Adam Roben
  • 2 edits in trunk/WebKit2

Windows build fix

  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:

(WebKit::interruptForPolicyChangeError): Add a missing comma.

10:15 AM Changeset in webkit [70066] by weinig@apple.com
  • 9 edits
    1 add in trunk/WebKit2

Part 2 of:
Need to include WKErrorRef in the WKPageDidFail... functions
<rdar://problem/8564110>
https://bugs.webkit.org/show_bug.cgi?id=47871

Reviewed by Anders Carlsson.

  • Shared/API/c/WKError.cpp:

(WKErrorCopyWKErrorDomain):

  • Shared/API/c/WKError.h:
  • Shared/WebError.cpp: Added.

(WebKit::WebError::webKitErrorDomain):

  • Shared/WebError.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(+[NSError _webKitErrorWithCode:failingURL:]):
(registerErrors):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):

  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:

(WebKit::cancelledError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptForPolicyChangeError):

  • win/WebKit2.vcproj:
10:10 AM Changeset in webkit [70065] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-10-19 Eric Carlson <eric.carlson@apple.com>

Not reviewed. Build fix.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectNextSourceChild): Initialize variable to avoid Windows "potentially uninitialized local variable" warning.
9:43 AM Changeset in webkit [70064] by tony@chromium.org
  • 33 edits in trunk

2010-10-19 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] DumpRenderTree shouldn't put '.' in include path
https://bugs.webkit.org/show_bug.cgi?id=47877

  • WebKit.gyp: Replace '.' with <(chromium_src_dir) and add public

2010-10-19 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] DumpRenderTree shouldn't put '.' in include path
https://bugs.webkit.org/show_bug.cgi?id=47877

Fix include paths.

  • DumpRenderTree/chromium/AccessibilityController.cpp:
  • DumpRenderTree/chromium/AccessibilityUIElement.cpp:
  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/CppBoundClass.cpp:
  • DumpRenderTree/chromium/CppVariant.cpp:
  • DumpRenderTree/chromium/CppVariant.h:
  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp:
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
  • DumpRenderTree/chromium/EventSender.cpp:
  • DumpRenderTree/chromium/EventSender.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp:
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/MockSpellCheck.cpp:
  • DumpRenderTree/chromium/NotificationPresenter.cpp:
  • DumpRenderTree/chromium/NotificationPresenter.h:
  • DumpRenderTree/chromium/PlainTextController.cpp:
  • DumpRenderTree/chromium/Task.cpp:
  • DumpRenderTree/chromium/TestNavigationController.h:
  • DumpRenderTree/chromium/TestShell.cpp:
  • DumpRenderTree/chromium/TestWebWorker.h:
  • DumpRenderTree/chromium/TextInputController.cpp:
  • DumpRenderTree/chromium/WebPreferences.cpp:
  • DumpRenderTree/chromium/WebPreferences.h:
  • DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
  • DumpRenderTree/chromium/WebThemeEngineDRT.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
9:43 AM Changeset in webkit [70063] by eric.carlson@apple.com
  • 7 edits
    4 adds in trunk

2010-10-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=46763
CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal

Fix crashes caused by moving and deleting <source> element(s) of active media element.

Tests: media/video-source-moved.html

media/video-source-removed.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Add logging. Initialize selectNextSourceChild. (WebCore::HTMLMediaElement::~HTMLMediaElement): Ditto. (WebCore::HTMLMediaElement::insertedIntoDocument): Ditto. (WebCore::HTMLMediaElement::removedFromDocument): Ditto. (WebCore::HTMLMediaElement::scheduleLoad): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Deal with m_currentSourceNode being null when the media engine signals a failure by skipping the error message and continuing as usual. (WebCore::HTMLMediaElement::setVolume): Fix logging typo. (WebCore::HTMLMediaElement::havePotentialSourceChild): Save and restore m_nextChildNodeToConsider around call to selectNextSourceChild because they are both significant. (WebCore::HTMLMediaElement::selectNextSourceChild): Use m_nextChildNodeToConsider to pick the first node to consider. Bail immediately if it signals that we have already processed every <source> node. Stach the node following the current source element in m_nextChildNodeToConsider so we can resume the search even if m_currentSourceNode is removed while it is being processed. (WebCore::HTMLMediaElement::sourceWasAdded): New, move logic from HTMLSourceElement::insertedIntoTree here and correct it to deal with a <source> node being inserted immediately after the current <source> node and a new <source> node being inserted at the end of the list after all candidates have failed. (WebCore::HTMLMediaElement::sourceWillBeRemoved): New, deal with current source node and next potential node being removed.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::sourceChildEndOfListValue): New, define sentinal value used to indicate that all nodes have been processed.
  • html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::HTMLSourceElement): Add logging. (WebCore::HTMLSourceElement::insertedIntoTree): Call mediaElement->sourceWasAdded instead of having logic here. (WebCore::HTMLSourceElement::willRemove): New, call mediaElement->sourceWillBeRemoved (WebCore::HTMLSourceElement::scheduleErrorEvent): Add logging. (WebCore::HTMLSourceElement::cancelPendingErrorEvent): Add logging.
  • html/HTMLSourceElement.h:

2010-10-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=46763
CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal

Test moving and deleting <source> element(s) of active <video>.

  • media/media-file.js: (mimeTypeForExtension): New, added to make it possible to set 'type' attribute on <source>.
  • media/video-source-moved-expected.txt: Added.
  • media/video-source-moved.html: Added.
  • media/video-source-removed-expected.txt: Added.
  • media/video-source-removed.html: Added.
8:56 AM Changeset in webkit [70062] by weinig@apple.com
  • 23 edits in trunk

WebKit2: Need to include WKErrorRef in the WKPageDidFail... functions
<rdar://problem/8564110>
https://bugs.webkit.org/show_bug.cgi?id=47871

Reviewed by Dan Bernstein.

Give WebError a WebCore::ResourceError backing and start passing it over the wire
for failure cases. Also, fill out the WKError API to include domain, errorCode,
failingURL and localizedDescription.

  • Shared/API/c/WKError.cpp:

(WKErrorCopyDomain):
(WKErrorGetErrorCode):
(WKErrorCopyFailingURL):
(WKErrorCopyLocalizedDescription):

  • Shared/API/c/WKError.h:
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebError.h:

(WebKit::WebError::create):
(WebKit::WebError::domain):
(WebKit::WebError::errorCode):
(WebKit::WebError::failingURL):
(WebKit::WebError::localizedDescription):
(WebKit::WebError::platformError):
(WebKit::WebError::WebError):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/ClientImpl.cpp:

(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didFailLoadWithErrorForFrame):

  • UIProcess/API/qt/ClientImpl.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):

WebKitTools: Need to include WKErrorRef in the WKPageDidFail... functions
https://bugs.webkit.org/show_bug.cgi?id=47871

Reviewed by Dan Bernstein.

Update tools for new parameter in failure callbacks.

  • MiniBrowser/mac/BrowserWindowController.m:

(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
(-[BrowserWindowController updateProvisionalURLForFrame:]):

  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:

(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
8:31 AM Changeset in webkit [70061] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-19 Christian Sejersen <Christian Sejersen>

Reviewed by Kenneth Rohde Christiansen.

Scratchbox has an old version of python as the default one, so
force it to use version 2.6.
https://bugs.webkit.org/show_bug.cgi?id=47895

  • DerivedSources.pro:
8:28 AM Changeset in webkit [70060] by luiz@webkit.org
  • 9 edits in trunk

2010-10-19 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] WebKit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47897

Qt WebKit2 MacOS build fix.

  • bridge/npapi.h:

2010-10-19 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] WebKit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47897

Qt WebKit2 MacOS build fix.

  • UIProcess/WebPageProxy.cpp:
  • WebKit2.pri:
  • WebKit2.pro:

2010-10-19 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] WebKit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47897

Qt WebKit2 MacOS build fix.

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/qt/TestControllerQt.cpp:
8:21 AM Changeset in webkit [70059] by abarth@webkit.org
  • 7 edits in trunk/WebKitTools

2010-10-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch stats the filesystem too many times
https://bugs.webkit.org/show_bug.cgi?id=47883

This patch attempts to cache the list of changed files more agressively
and to use that list to compute the diff instead of stating the file
system again.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/editchangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
8:12 AM Changeset in webkit [70058] by tonikitoo@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-10-18 Antonio Gomes <agomes@rim.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to nodesFromRect involving links and text nodes
https://bugs.webkit.org/show_bug.cgi?id=47795

Similarly to bug 47766 (Enrich /fast/dom/nodesFromRect-basic.html test,
this patch continues to improve the test coverage for Document::nodesFromRect.
This time tests involving links and text nodes are being added this time. Basically
it performs various rect hit tests involving the positions of the elements.

  • fast/dom/nodesFromRect-links-and-text-expected.html: Added.
  • fast/dom/nodesFromRect-links-and-text.html: Added.
7:51 AM Changeset in webkit [70057] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly

Reviewed by Darin Adler.

  • Scripts/sort-Xcode-project-file:
  • Don't print an error message about missing arguments when
-hhelp is used.
  • Allow Xcode project files to be specified as Project.xcodeproj instead of Project.xcodeproj/project.pbxproj.
7:37 AM Changeset in webkit [70056] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-10-19 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] Soup cache code still has some warnings
https://bugs.webkit.org/show_bug.cgi?id=47733

Fixed some compilation warnings happening with gcc 4.4.5 on
64-bits architecture.

  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_entry_set_freshness): (close_ready_cb):
7:21 AM Changeset in webkit [70055] by pfeldman@chromium.org
  • 1 edit in branches/chromium/552/WebCore/inspector/front-end/ScriptsPanel.js

Merge 70054 - 2010-10-19 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: crash while trying to step over a function using inspector
https://bugs.webkit.org/show_bug.cgi?id=47902

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset): reset scripts panel to resumed state on navigation.

TBR=yurys@chromium.org
BUG=59622

7:12 AM Changeset in webkit [70054] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-10-19 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: crash while trying to step over a function using inspector
https://bugs.webkit.org/show_bug.cgi?id=47902

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset): reset scripts panel to resumed state on navigation.
6:44 AM Changeset in webkit [70053] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2010-10-19 Andreas Kling <kling@webkit.org>

Unreviewed, skip fast/canvas/canvas-getImageData-negative-source.html on Mac.
https://bugs.webkit.org/show_bug.cgi?id=47901

  • platform/mac/Skipped:
5:52 AM Changeset in webkit [70052] by benm@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, update the Qt test expectations after r70047.

Missing support for document.createTouch and document.createTouchList
https://bugs.webkit.org/show_bug.cgi?id=47676

  • platform/qt/fast/dom/Window/window-properties-expected.txt:

Add the new APIs to the expected results.

5:47 AM Changeset in webkit [70051] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-19 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed attempt to remove warning in EFL build.

Fix #if to #ifdef.

No new features, so no tests added.

  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyFallbackCursor):
5:46 AM Changeset in webkit [70050] by andreas.kling@nokia.com
  • 3 edits
    3 adds in trunk

2010-10-19 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] getImageData returns wrong data for non-0,0 source offset
https://bugs.webkit.org/show_bug.cgi?id=47898

Test: fast/canvas/canvas-getImageData-negative-source.html

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): Add missing *4's to get correct pixel offset.

2010-10-19 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] getImageData returns wrong data for non-0,0 source offset
https://bugs.webkit.org/show_bug.cgi?id=47898

  • fast/canvas/canvas-getImageData-negative-source-expected.txt: Added.
  • fast/canvas/canvas-getImageData-negative-source.html: Added.
  • fast/canvas/script-tests/canvas-getImageData-negative-source.js: Added.
5:44 AM Changeset in webkit [70049] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-19 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Correct initial state of ImageBuffer QPen
https://bugs.webkit.org/show_bug.cgi?id=47804

Have the QPen on ImageBuffers start in Qt::SvgMiterJoin mode.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBufferData::ImageBufferData):
5:15 AM Changeset in webkit [70048] by Philippe Normand
  • 5 edits in trunk/WebCore

2010-10-19 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

GStreamer PlatformVideoWindow needs an API to prepare the widget before applying the overlay
https://bugs.webkit.org/show_bug.cgi?id=46790

Simple API addition to PlatformVideoWindow to allow
implementations to optionally prepare their own PlatformWidget
before applying the GStreamer XOverlay to it. This will likely be
needed on Mac OSX only.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay):
  • platform/graphics/gstreamer/PlatformVideoWindow.h:
  • platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: (PlatformVideoWindow::prepareForOverlay):
  • platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp: (PlatformVideoWindow::prepareForOverlay):
4:50 AM Changeset in webkit [70047] by benm@google.com
  • 12 edits
    8 adds in trunk

2010-10-19 Ben Murdoch <benm@google.com>

Reviewed by Steve Block.

Missing support for document.createTouch and document.createTouchList
https://bugs.webkit.org/show_bug.cgi?id=47676

Add tests to verify the presence of the APIs and that they work correctly.

  • fast/events/touch/document-create-touch-expected.txt: Added.
  • fast/events/touch/document-create-touch-list-expected.txt: Added.
  • fast/events/touch/document-create-touch-list.html: Added.
  • fast/events/touch/document-create-touch.html: Added.
  • fast/events/touch/script-tests/document-create-touch-list.js: Added.
  • fast/events/touch/script-tests/document-create-touch.js: Added.

2010-10-19 Ben Murdoch <benm@google.com>

Reviewed by Steve Block.

Missing support for document.createTouch and document.createTouchList
https://bugs.webkit.org/show_bug.cgi?id=47676

These APIs are used by many sites to detect support for touch events.

Implement the APIs according to the documentation at:
http://developer.apple.com/library/safari/#documentation/UserExperience/Reference/DocumentAdditionsReference/DocumentAdditions/DocumentAdditions.html

Tests: fast/events/touch/document-create-touch-list.html

fast/events/touch/document-create-touch.html

  • bindings/js/JSBindingsAllInOne.cpp: Add new files to list.
  • bindings/js/JSTouchCustom.cpp: Added. (WebCore::toJSNewlyCreated):
  • bindings/js/JSTouchListCustom.cpp: Added. (WebCore::toJSNewlyCreated):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.cpp: (WebCore::Document::createTouch): (WebCore::Document::createTouchList):
  • dom/Document.h:
  • dom/Document.idl: Add createTouch and createTouchList functions.
  • Android.jscbindings.mk: Update makefiles.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
3:38 AM Changeset in webkit [70046] by pfeldman@chromium.org
  • 11 edits in trunk/WebCore

2010-10-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: migrate from legacy Object.properties to Object.keys, remove dead code.
https://bugs.webkit.org/show_bug.cgi?id=47890

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._reportCompletions):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onGetResources):
  • inspector/front-end/HAREntry.js: (WebInspector.HARLog.prototype.build):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/utilities.js:
3:35 AM Changeset in webkit [70045] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-10-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not access ResourcePanel from resources directly.
https://bugs.webkit.org/show_bug.cgi?id=47892

3:34 AM Changeset in webkit [70044] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/WebKitTools

[Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode.
https://bugs.webkit.org/show_bug.cgi?id=47809

Reviewed by Andreas Kling.

Connecting a call to load from the loadFinished signal can cause
re-entrance crashes in WebCore. This patch uses a timer to do so,
also giving some time to subsequent frames to finish loading.

  • QtTestBrowser/urlloader.cpp:

(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::checkIfFinished):
(UrlLoader::frameLoadStarted):
(UrlLoader::frameLoadFinished):

  • QtTestBrowser/urlloader.h:
3:21 AM Changeset in webkit [70043] by yutak@chromium.org
  • 2 edits in trunk/WebCore

2010-10-19 Yuta Kitamura <yutak@chromium.org>

Reviewed by Pavel Feldman.

Make sure WebSocket resource has the url field when it is created.

Web Inspector: Uncaught TypeError when connection to WebSocket server is refused
https://bugs.webkit.org/show_bug.cgi?id=47891

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::createWebSocket):
2:38 AM Changeset in webkit [70042] by jorlow@chromium.org
  • 9 edits in branches/chromium/552

DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829

BUG=59579

Reviewed by Darin Adler.

LayoutTests:

Add tests for out of range behavior here since IndexedDB is the only user
of DOMStringList.

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

WebCore:

When item() returns a null string, it needs to be passed to JS as
null. The indexed getter will then magically do the right thing.
So all that's left is having DOMStringList::item() return null when
the index is out of bounds.

  • dom/DOMStringList.cpp:

(WebCore::DOMStringList::item):

  • dom/DOMStringList.h:
  • dom/DOMStringList.idl:

Merge 69983 - 2010-10-18 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829

Add tests for out of range behavior here since IndexedDB is the only user
of DOMStringList.

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2010-10-18 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829

When item() returns a null string, it needs to be passed to JS as
null. The indexed getter will then magically do the right thing.
So all that's left is having DOMStringList::item() return null when
the index is out of bounds.

  • dom/DOMStringList.cpp: (WebCore::DOMStringList::item):
  • dom/DOMStringList.h:
  • dom/DOMStringList.idl:

TBR=jorlow@chromium.org

2:05 AM Changeset in webkit [70041] by Patrick Gansterer
  • 3 edits in trunk/JavaScriptCore

2010-10-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Fix style of UnicodeWinCE
https://bugs.webkit.org/show_bug.cgi?id=47818

  • wtf/unicode/wince/UnicodeWinCE.cpp: (WTF::Unicode::toLower): (WTF::Unicode::toUpper):
  • wtf/unicode/wince/UnicodeWinCE.h:
1:57 AM Changeset in webkit [70040] by hayato@chromium.org
  • 4 edits
    2 adds in trunk

2010-10-19 Hayato Ito <hayato@chromium.org>

Reviewed by Darin Adler.

Make CSS style selector non-recursive.
https://bugs.webkit.org/show_bug.cgi?id=43783

This change is one of the required changes to fix the following master bug:
https://bugs.webkit.org/show_bug.cgi?id=42806

To avoid recursion, we prepare a call stack and maintain a list of
function call state by ourselves and try matching iteratively.

  • fast/css/long-css-selector-matches-expected.txt: Added.
  • fast/css/long-css-selector-matches.html: Added.

2010-10-19 Hayato Ito <hayato@chromium.org>

Reviewed by Darin Adler.

Make CSS style selector non-recursive.
https://bugs.webkit.org/show_bug.cgi?id=43783

This change is one of the required changes to fix the following master bug:
https://bugs.webkit.org/show_bug.cgi?id=42806

To avoid recursion, we prepare a call stack and maintain a list of
function call state by ourselves and try matching iteratively.

Test: fast/css/long-css-selector-matches.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::checkSelector):
  • css/CSSStyleSelector.h:
1:48 AM Changeset in webkit [70039] by commit-queue@webkit.org
  • 5 edits in trunk

2010-10-19 Sergio Villar Senín <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/history tests are failing
https://bugs.webkit.org/show_bug.cgi?id=36173

Removed skipped tests from http/history

  • platform/gtk/Skipped:

2010-10-19 Sergio Villar Senín <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] http/history tests are failing
https://bugs.webkit.org/show_bug.cgi?id=36173

Clear the history each time a test is run. Return the actual
history item count when calling
LayoutTestController::webHistoryItemCount

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::webHistoryItemCount):
1:30 AM Changeset in webkit [70038] by commit-queue@webkit.org
  • 6 edits in trunk

2010-10-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70034.
http://trac.webkit.org/changeset/70034
https://bugs.webkit.org/show_bug.cgi?id=47889

"Gustavo's bot is lame" (Requested by xan_ on #webkit).

  • configure.ac:

2010-10-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70034.
http://trac.webkit.org/changeset/70034
https://bugs.webkit.org/show_bug.cgi?id=47889

"Gustavo's bot is lame" (Requested by xan_ on #webkit).

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar): (WebCore::setCookies):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL): (WebCore::restartedCallback): (WebCore::startHttp):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
1:23 AM Changeset in webkit [70037] by pfeldman@chromium.org
  • 1 edit in branches/chromium/552/WebCore/inspector/front-end/inspector.css

Merge 69954 - 2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: tab headers on resource panel are 1px off on Mac.
https://bugs.webkit.org/show_bug.cgi?id=47798

  • inspector/front-end/inspector.css: (.tabbed-pane-header li):

TBR=pfeldman@chromium.org
BUG=59748

1:17 AM Changeset in webkit [70036] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-10-19 Joone Hur <joone@kldp.org>

Reviewed by Martin Robinson.

[GTK] Needs fixing mistyped comments in the API documentation
https://bugs.webkit.org/show_bug.cgi?id=47656

Fixed mistyped comments in the API documenentation.

  • webkit/webkitwebsettings.cpp: Fixed a mistyped comment in the the section block.
  • webkit/webkitwebwindowfeatures.cpp: Fixed a mistyped comment in the section block.
12:58 AM Changeset in webkit [70035] by commit-queue@webkit.org
  • 2 edits in trunk

2010-10-19 Prof. MAAD <himself@prof-maad.org>

Reviewed by Xan Lopez.

[GTK] Correct erroneous documentation for webkit_web_navigation_action_get_button()
https://bugs.webkit.org/show_bug.cgi?id=46723

  • WebKit/gtk/webkit/webkitwebnavigationaction.cpp:
12:50 AM Changeset in webkit [70034] by xan@webkit.org
  • 6 edits in trunk

2010-10-19 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Bump minimum requirement for libsoup to 2.30
https://bugs.webkit.org/show_bug.cgi?id=46176

Bump minimum libsoup to required version to 2.30.0.

  • configure.ac:

WebCore:

2010-10-19 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Bump minimum requirement for libsoup to 2.30
https://bugs.webkit.org/show_bug.cgi?id=46176

Bump minimum required libsoup version to 2.30.

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar): (WebCore::setCookies):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL): (WebCore::restartedCallback): (WebCore::startHttp):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
12:15 AM Changeset in webkit [70033] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-10-19 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix distcheck, take 2.

  • GNUmakefile.am: also move the generated CSS hash files to the build dir.

Oct 18, 2010:

11:54 PM Changeset in webkit [70032] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-18 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed.

Re-enabled editing/execCommand/remove-formatting.html and editing/execCommand/remove-formatting-2.html on Qt platforms.

  • platform/qt/Skipped:
11:34 PM Changeset in webkit [70031] by rniwa@webkit.org
  • 3 edits
    2 adds
    22 deletes in trunk/LayoutTests

2010-10-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

dump-as-markup conversion: editing/execCommand/remove-formatting.html and remove-formatting-2.html
https://bugs.webkit.org/show_bug.cgi?id=47792

Converted editing/execCommand/remove-formatting.html and remove-formatting-2.html to dump-as-markup tests.

  • editing/execCommand/remove-formatting-2-expected.txt: Added.
  • editing/execCommand/remove-formatting-2.html:
  • editing/execCommand/remove-formatting-expected.txt: Added.
  • editing/execCommand/remove-formatting.html:
  • platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/remove-formatting-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/remove-formatting-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/remove-formatting-2-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/remove-formatting-2-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/remove-formatting-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/remove-formatting-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/remove-formatting-expected.txt: Removed.
  • platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
  • platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.png: Removed.
  • platform/mac-leopard/editing/execCommand/remove-formatting-expected.checksum: Removed.
  • platform/mac-leopard/editing/execCommand/remove-formatting-expected.png: Removed.
  • platform/mac/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
  • platform/mac/editing/execCommand/remove-formatting-2-expected.png: Removed.
  • platform/mac/editing/execCommand/remove-formatting-2-expected.txt: Removed.
  • platform/mac/editing/execCommand/remove-formatting-expected.checksum: Removed.
  • platform/mac/editing/execCommand/remove-formatting-expected.png: Removed.
  • platform/mac/editing/execCommand/remove-formatting-expected.txt: Removed.
  • platform/qt/editing/execCommand/remove-formatting-2-expected.txt: Removed.
  • platform/qt/editing/execCommand/remove-formatting-expected.txt: Removed.
10:37 PM Changeset in webkit [70030] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-10-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Export QWebPage::ViewportAttributes class.
https://bugs.webkit.org/show_bug.cgi?id=47845

  • Api/qwebpage.h:
  • symbian/eabi/QtWebKitu.def:
10:36 PM Changeset in webkit [70029] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add Chromium Mac EWS to the list of queues at queues.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=47878

  • QueueStatusServer/model/queues.py:
10:35 PM Changeset in webkit [70028] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

queues.webkit.org/next_patch is always 404
https://bugs.webkit.org/show_bug.cgi?id=47881

With the addition of the Queue class, I changed most of the
code to lookup WorkItems using get_or_insert with a key_name
instead of WorkItems.all().filter(queue_name=).
Because the new get_or_insert code uses an explicit key_name
(which is obviously different from the previously autogenerated
ones), there were new WorkItem records created for each queue.
However, some parts of the code still use WorkItems.all().filter,
thus some parts were getting the new record and some parts the old record.

The same basic bug was occurring with ActiveWorkItems, because I
changed the key_name for that class as well.

To fix this I've moved more of the code over to using Queue.*work_items.
I've also enabled the datastore_admin (new in GAE 1.3.8) so that
we can go delete the old WorkItems records.
I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/handlers/recentstatus.py:
  • QueueStatusServer/handlers/updatestatus.py:
  • QueueStatusServer/handlers/updateworkitems.py:
10:33 PM Changeset in webkit [70027] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-18 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Should not save state of a detached form control.
https://bugs.webkit.org/show_bug.cgi?id=47811

  • fast/forms/state-save-of-detached-control-expected.txt: Added.
  • fast/forms/state-save-of-detached-control.html: Added.

2010-10-18 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Should not save state of a detached form control.
https://bugs.webkit.org/show_bug.cgi?id=47811

Test: fast/forms/state-save-of-detached-control.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): If the node is detached, don't save the state.
9:55 PM Changeset in webkit [70026] by xan@webkit.org
  • 9 edits in trunk

2010-10-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Bump version numbers for 1.3.5 release.

  • configure.ac:

WebCore:

2010-10-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

  • GNUmakefile.am: add missing files.

WebKit/gtk:

2010-10-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

  • NEWS: update for 1.3.5 release.
  • docs/webkitgtk-sections.txt: add new APIs.

JavaScriptCore:

2010-10-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

  • GNUmakefile.am: add missing file.
9:48 PM Changeset in webkit [70025] by eric@webkit.org
  • 8 edits
    2 copies in trunk/WebKitTools

2010-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Correct a bunch of typos in QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=47880

These are all due to our complete lack of unit testing in QueueStatusServer.
I added a couple unit tests to cover a few of these fixes, but most of these
are still only caught by actually running the application.

  • QueueStatusServer/handlers/nextpatch.py:
  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/handlers/statusbubble_unittest.py: Added.
  • QueueStatusServer/handlers/updateworkitems.py:
  • QueueStatusServer/model/attachment.py:
  • QueueStatusServer/model/queuepropertymixin.py:
  • QueueStatusServer/model/queuepropertymixin_unittest.py:
  • QueueStatusServer/model/workitems.py:
  • QueueStatusServer/model/workitems_unittest.py: Added.
9:25 PM Changeset in webkit [70024] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-18 Adam Barth <abarth@webkit.org>

Disable this test because it's failing on the bots and the authors
aren't around to fix it.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
9:11 PM Changeset in webkit [70023] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-10-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CC authors of flaky tests when the commit-queue hits a flaky test
https://bugs.webkit.org/show_bug.cgi?id=47872

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
9:05 PM Changeset in webkit [70022] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to run a chromium-mac-ews builder
https://bugs.webkit.org/show_bug.cgi?id=47876

Since we can't run Mac OS X in a VM, we need to only run committer patches.
There was a multiple inheritance problem which was holding this patch back,
but I decided to just ignore the problem and go with a functional hack for now.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
8:22 PM Changeset in webkit [70021] by kbr@google.com
  • 2 edits in trunk/WebKitTools

2010-10-18 Kenneth Russell <kbr@google.com>

Reviewed by Tony Chang.

Regression in run_webkit_tests_unittest from r70017
https://bugs.webkit.org/show_bug.cgi?id=47875

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
7:44 PM Changeset in webkit [70020] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-10-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement webkit-patch suggest-reviewers
https://bugs.webkit.org/show_bug.cgi?id=47866

  • Scripts/webkitpy/common/checkout/api.py:
    • The main logic. We look at the last five changes to each modified (non-ChangeLog) file and collect up the reviewers of those changes as well as the authors of those changes who are reviewers.
  • Scripts/webkitpy/common/checkout/api_unittest.py:
    • Test the logic with some fun mocks.
  • Scripts/webkitpy/common/checkout/scm.py:
    • Fix a bug when you have local git commits.
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Test that the bug is fixed.
  • Scripts/webkitpy/tool/commands/queries.py:
    • Add the query.
7:37 PM Changeset in webkit [70019] by eric@webkit.org
  • 9 edits
    1 copy
    1 add in trunk/WebKitTools

2010-10-18 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

new-run-webkit-tests produces corrupt PNG baselines on Windows
https://bugs.webkit.org/show_bug.cgi?id=47867

  • Scripts/webkitpy/layout_tests/port/base.py:
7:33 PM Changeset in webkit [70018] by oliver@apple.com
  • 5 edits in trunk

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

REGRESSION: Feedly extension crashes Webkit
https://bugs.webkit.org/show_bug.cgi?id=45811

Make test cover large number of properties/string pairs, at two offsets to get the
new allocation to occur at different locations.

  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone.html:

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

REGRESSION: Feedly extension crashes Webkit
https://bugs.webkit.org/show_bug.cgi?id=45811

The basic problem was the deserializer was holding a pointer into
the constant pool, but if you were sufficiently unlucky then the
constant pool would be moved while still relying on the pointer,
which leads to badness.

I looked at just making all the sites this could happen extract the
right string/jsstring before any possible allocations, but it seemed
too fragile so i've gone for a forwarding object as the solution.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::CachedStringRef::CachedStringRef): (WebCore::CloneDeserializer::CachedStringRef::operator->): (WebCore::CloneDeserializer::readStringData): (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal): (WebCore::CloneDeserializer::deserialize):
7:32 PM Changeset in webkit [70017] by kbr@google.com
  • 2 edits in trunk/WebKitTools

2010-10-18 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

new-run-webkit-tests produces corrupt PNG baselines on Windows
https://bugs.webkit.org/show_bug.cgi?id=47867

  • Scripts/webkitpy/layout_tests/port/base.py:
7:13 PM Changeset in webkit [70016] by eric@webkit.org
  • 8 edits
    2 copies in trunk/WebKitTools

2010-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Deploy Queue class in more places throughout QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=47855

I also caught two typos from the previous change. Unfortunately
I don't yet know how to unittest request handlers yet.

  • QueueStatusServer/handlers/dashboard.py:
  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/handlers/updateworkitems.py:
  • QueueStatusServer/model/activeworkitems.py:
  • QueueStatusServer/model/attachment.py:
  • QueueStatusServer/model/queuepropertymixin.py: Added.
  • QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
  • QueueStatusServer/model/queuestatus.py:
  • QueueStatusServer/model/workitems.py:
6:59 PM Changeset in webkit [70015] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-18 Chris Rogers <crogers@google.com>

Reviewed by Chris Fleizach.

Add AudioResampler files
https://bugs.webkit.org/show_bug.cgi?id=47623

No new tests since audio API is not yet implemented.

  • platform/audio/AudioResampler.cpp: Added. (WebCore::AudioResampler::AudioResampler): (WebCore::AudioResampler::configureChannels): (WebCore::AudioResampler::process): (WebCore::AudioResampler::setRate): (WebCore::AudioResampler::reset):
  • platform/audio/AudioResampler.h: Added. (WebCore::AudioResampler::~AudioResampler): (WebCore::AudioResampler::rate):
6:38 PM Changeset in webkit [70014] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

scm.py should be able tell us what revisions made changes to a given file
https://bugs.webkit.org/show_bug.cgi?id=47863

Look again, your SCM.py can now log files.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
6:02 PM Changeset in webkit [70013] by dpranke@chromium.org
  • 16 edits
    1 add in trunk/WebKitTools

2010-10-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

new-run-webkit-tests: clean up the options-parsing code in the port
classes.

This change modifies the Port interface to have a get_option() and
set_option_default() method for accessing the options argument
passed to the constructor. If the constructor is not passed an
options argument, we default to a MockOptions() argument from
mocktool, which has the same semantics we want.

Note that there is a disadvantage to port.get_option('foo') over
port._options.foo, which is that you lose some of the checking
for whether 'foo' is set (typos result in the default value, not
an exception being raised. This is desired in this case, since the
Port class is not allowed to assume that options does have any
particular values set, and so this change ensures that all of
the subclasses are following the same, intended, logic.

Arguably this is the wrong semantics to have, and the Port
classes should be able to assume a default set of
attributes/arguments, but that change will need to wait for a
different CL where we can modify new-run-webkit-tests to pull a
list of arguments from the port factory routines.

Also, add unit tests for webkitpy.tool.mocktool.MockOptions .

https://bugs.webkit.org/show_bug.cgi?id=47510

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool_unittest.py: Added.
5:40 PM Changeset in webkit [70012] by dpranke@chromium.org
  • 9 edits in trunk/WebKitTools

2010-10-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Re-submit a revised version of r69638 - enabling new-run-webkit-tests
under cygwin. The initial version had a bug in base:uri_to_test_name
that was causing tests to fail. This version corrects that bug, but
also makes the code safer by calling cygpath more reliably, and
leaving a long-running cygpath process open.

This patch also corrects a couple of minor bugs in http_lock_unittest,
chromium_unittest, and dedpulicate_tests_unittest that showed up
while testing this.

https://bugs.webkit.org/show_bug.cgi?id=47220

  • Scripts/webkitpy/common/system/path.py:
  • Scripts/webkitpy/common/system/path_unittest.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5:06 PM Changeset in webkit [70011] by jamesr@google.com
  • 2 edits
    1 add in trunk/LayoutTests

2010-10-18 James Robinson <jamesr@chromium.org>

Update chromium test expectations

  • platform/chromium-linux/svg/custom/text-linking-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/svg/custom/text-linking-expected.txt.
  • platform/chromium/test_expectations.txt:
4:53 PM Changeset in webkit [70010] by vangelis@chromium.org
  • 6 edits in trunk/WebCore

2010-10-18 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Prevent the creation of very large textures for layers by switching
to "large layer" mode when a texture is larger than some fixed reasonable size
(set to 2000 pixels for now).
https://bugs.webkit.org/show_bug.cgi?id=47751

The code also changes the large layer logic to use the current scissor rect used
by the compositor instead of the visible rect to determine how to clip large layers.
This will provide additional texture savings. In addition, the various layer rects
have been converted to use integers instead of floats to preserve uniformity in the code.


Tests: Existing large layer layout tests including huge-layer and huge-layer-img

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::getDrawRect):
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::drawLayersRecursive): (WebCore::LayerRendererChromium::scissorToRect):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::currentScissorRect):
4:38 PM Changeset in webkit [70009] by jamesr@google.com
  • 2 edits
    2 moves
    1 delete in trunk/LayoutTests

2010-10-18 James Robinson <jamesr@chromium.org>

Move chromium xp specific baselines to right place.

  • platform/chromium-win-xp/svg/custom/text-linking-expected.checksum:
  • platform/chromium-win-xp/svg/custom/text-linking-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/custom/text-linking-expected.png.
  • platform/chromium-win-xp/svg/custom/text-linking-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/custom/text-linking-expected.txt.
  • platform/chromium-win/svg/custom/text-linking-expected.checksum: Removed.
4:28 PM Changeset in webkit [70008] by oliver@apple.com
  • 5 edits in trunk

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: Functions created with the function constructor don't implement strict mode semantics
https://bugs.webkit.org/show_bug.cgi?id=47860

When creating the FunctionExecutable for a new function the function constructor
was always passing false for whether or not a function was strict, rather than
using the information from the freshly parsed function itself.

  • runtime/Executable.cpp: (JSC::FunctionExecutable::fromGlobalCode):

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: Functions created with the function constructor don't implement strict mode semantics
https://bugs.webkit.org/show_bug.cgi?id=47860

Test that the function constructor produces correct strict mode functions.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
4:21 PM Changeset in webkit [70007] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Initialize the API client.

Reviewed by Sam Weinig.

  • Shared/APIClient.h:

(WebKit::APIClient::APIClient):

4:08 PM Changeset in webkit [70006] by eric@webkit.org
  • 11 edits
    1 add in trunk/WebKitTools

2010-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add Queue class and add minimal unittesting of QueueStatusServer code
https://bugs.webkit.org/show_bug.cgi?id=47847

  • QueueStatusServer/handlers/dashboard.py:
  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/handlers/recentstatus.py:
  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/handlers/updateworkitems.py:
  • QueueStatusServer/model/attachment.py:
  • QueueStatusServer/model/queues.py:
  • QueueStatusServer/model/queues_unittest.py: Added.
  • QueueStatusServer/model/svnrevision.py:
  • Scripts/test-webkitpy:
  • Scripts/webkitpy/test/main.py:
3:44 PM Changeset in webkit [70005] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-10-18 James Robinson <jamesr@chromium.org>

Mark flaky SVG tests as flaky in chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:40 PM Changeset in webkit [70004] by andersca@apple.com
  • 5 edits in trunk/WebKit2

WebKit2 should handle dismissing the Find overlay on mouse-down
https://bugs.webkit.org/show_bug.cgi?id=47854

Reviewed by John Sullivan.

  • WebProcess/WebPage/FindPageOverlay.cpp:

(WebKit::FindPageOverlay::mouseEvent):
Dismiss the find UI on MouseDown.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEvent):
If there's a page overlay, let it have a go at the event.

3:29 PM Changeset in webkit [70003] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-18 Jia Pu <jpu@apple.com>

Reviewed by Stephanie Lewis.

Correct the description of manual test: autocorrection-cancelled-by-typing-1.html
https://bugs.webkit.org/show_bug.cgi?id=47722
<rdar://problem/8556206>

  • manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Update description to match the test content.
3:19 PM Changeset in webkit [70002] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-18 Mihai Parparita <mihaip@chromium.org>

Group Chromium DRT media test failures and add media/video-src.html,
which became flaky around r68970.

  • platform/chromium/drt_expectations.txt:
3:14 PM Changeset in webkit [70001] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Fix clang build.

  • UIProcess/API/mac/FindIndicatorWindow.mm:

(-[WebFindIndicatorWindowAnimation _initWithFindIndicatorWindow:WebKit::animationProgressCallback:WebKit::FindIndicatorWindow::animationDidEndCallback:WebKit::FindIndicatorWindow::]):
(WebKit::FindIndicatorWindow::setFindIndicator):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPopupMenuProxy.h:
  • WebProcess/WebCoreSupport/WebPopupMenu.h:
3:13 PM Changeset in webkit [70000] by beidson@apple.com
  • 1 edit in trunk/ChangeLog

70,000!

3:11 PM Changeset in webkit [69999] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix Qt build.

  • WebKit2.pro:
3:10 PM WebKit2 edited by Simon Fraser
(diff)
3:02 PM Changeset in webkit [69998] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-10-18 Martin Robinson <mrobinson@igalia.com>

Build fix for newer versions of GTK+ 2.0. Instead of using GDK_DISPLAY()
use GDK_DRAWABLE_XDISPLAY(gdk_display_get_default()). GDK_DISPLAY() was
recently deprecated and the latter method has been available since GTK+
2.2.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::initXEvent): (WebCore::PluginView::platformGetValue): (WebCore::getVisualAndColormap): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
2:55 PM Changeset in webkit [69997] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Don't try to change accelerated compositing mode if the web page is closed
https://bugs.webkit.org/show_bug.cgi?id=47852

Reviewed by Simon Fraser.

changeAcceleratedCompositingMode ends up sending a sync message to the UI process which is unnecessary if
the UI process is being torn down.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::changeAcceleratedCompositingMode):
(WebKit::WebPage::close):

  • WebProcess/WebPage/WebPage.h:
2:53 PM Changeset in webkit [69996] by commit-queue@webkit.org
  • 6 edits in trunk

2010-10-18 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Update context attribute conformance test from updated Khronos source.
https://bugs.webkit.org/show_bug.cgi?id=47697

  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
  • platform/chromium/test_expectations.txt:

2010-10-18 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Turn off antialiasing when using Mesa during testing.
https://bugs.webkit.org/show_bug.cgi?id=47697

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
2:44 PM Changeset in webkit [69995] by brettw@chromium.org
  • 1 edit in branches/chromium/552/WebKit/chromium/src/WebFontImpl.cpp

Merge 69719 - 2010-10-13 Brett Wilson <brettw@chromium.org>

Reviewed by Darin Fisher.

Save and restore the GraphicsContext around setting the clip rect for
drawing text.
https://bugs.webkit.org/show_bug.cgi?id=47634

  • src/WebFontImpl.cpp: (WebKit::WebFontImpl::drawText):

TBR=brettw@chromium.org

2:42 PM Changeset in webkit [69994] by rniwa@webkit.org
  • 5 edits in trunk/WebCore

2010-10-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

elementCannotHaveEndTag should be a member function of MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=47846

Moved elementCannotHaveEndTag into MarkupAccumulator.

No new tests are added since this is a cleanup.

  • editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::elementCannotHaveEndTag): Added.
  • editing/MarkupAccumulator.h: Added MarkupAccumulator::elementCannotHaveEndTag.
  • editing/markup.cpp: Removed elementCannotHaveEndTag.
  • editing/markup.h: Removed elementCannotHaveEndTag.
2:41 PM Changeset in webkit [69993] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-18 James Robinson <jamesr@chromium.org>

Update the chromium DEPS from 62399 to 62813 to pick up skia fixes

  • DEPS:
2:28 PM Changeset in webkit [69992] by andersca@apple.com
  • 4 edits in trunk/WebKit2

<rdar://problem/8036034>
WebKit2's WebProcess dies immediately on Mac due to DYLD_FRAMEWORK_PATH problem

Reviewed by Sam Weinig.

Pass the path to the WebKit2 framework along to the web process and don't rely on DYLD_FRAMEWORK_PATH being set.

  • Shared/mac/CommandLineMac.cpp:

(WebKit::CommandLine::parse):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

  • mac/MainMac.cpp:

(main):

2:24 PM Changeset in webkit [69991] by jberlin@webkit.org
  • 9 edits
    3 adds in trunk/WebKit2

Need a WebKit2 equivalent of the WebKit1 WebUserContentURLPattern.
https://bugs.webkit.org/show_bug.cgi?id=47783

Reviewed by Sam Weinig.

  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKSharedAPICast.h:
  • Shared/API/c/WKUserContentURLPattern.cpp: Added.

(WKUserContentURLPatternGetTypeID):
(WKUserContentURLPatternCreate):
(WKUserContentURLPatternMatchesURL):

  • Shared/API/c/WKUserContentURLPattern.h: Added.
  • Shared/APIObject.h:
  • Shared/UserMessageCoders.h:

Use the original pattern string to encode and decode a UserContentURLPattern.
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebUserContentURLPattern.h: Added.

(WebKit::WebUserContentURLPattern::create):
(WebKit::WebUserContentURLPattern::matchesURL):
Use WebCore::UserContentURLPattern::matches.
(WebKit::WebUserContentURLPattern::patternString):
Expose the pattern string used to create the UserContentURLPattern for the purpose of
encoding and decoding.
(WebKit::WebUserContentURLPattern::WebUserContentURLPattern):
(WebKit::WebUserContentURLPattern::type):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add WKUserContentURLPattern.h/.cpp and WebUserContentURLPattern.h

  • win/WebKit2Generated.make:

Copy over WKUsercontentURLPattern into the output directory.

2:15 PM Changeset in webkit [69990] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-10-18 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Set the right referent sourceURL for the script with force user gesture.
https://bugs.webkit.org/show_bug.cgi?id=37138

Because empty sourceURL indicates running script with force user gesture,
make WebKit use document.url() as referent sourceURL (Since it uses blank
URL instead empty if the input URL is empty) if WebKit isn't running the
script from a hyper-link.

Test: fast/events/popup-blocked-from-window-open.html

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorld):

2010-10-18 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Set the right referent sourceURL for the script with force user gesture.
https://bugs.webkit.org/show_bug.cgi?id=37138

  • fast/events/popup-blocked-from-window-open-expected.txt: Added.
  • fast/events/popup-blocked-from-window-open.html: Added.
2:12 PM Changeset in webkit [69989] by jamesr@google.com
  • 15 edits
    6 adds in trunk/LayoutTests

2010-10-18 James Robinson <jamesr@chromium.org>

Update chromium expectations and baselines.

  • platform/chromium/test_expectations.txt:
12:59 PM Changeset in webkit [69988] by Darin Adler
  • 2 edits in trunk/WebCore
  • dom/Node.h: Fix ancient typo in just-modified comment.
12:52 PM Changeset in webkit [69987] by Darin Adler
  • 10 edits in trunk/WebCore

2010-10-18 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Remove some functions from class Node and make a few others non-virtual
https://bugs.webkit.org/show_bug.cgi?id=47735

Refactoring. No new tests.

  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Added a FIXME about the use of the virtual ownerDocument function.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Removed the unused return value.
  • dom/ContainerNode.h: Made insertBefore, replaceChild, removeChild, and appendChild non-virtual for clarity and performance. Made removeChildren non-virtual and removed its return value. Moved the inline Node functions that call through to ContainerNode into this file since the old way involved an extra level of inline function but otherwise had no advantages.
  • dom/Element.h: Moved isMathMLElement here because there is no call site that needs to call it on a Node*. We can always move it back if we need to, but it's better to have less in the Node class.
  • dom/Node.cpp: (WebCore::Node::insertBefore): Added an isContainerNode check so this can be non-virtual. There are very few callers who call this function on Node. If we want to optimize them further we can make the isContainerNode check inline in the future. (WebCore::Node::replaceChild): Ditto. (WebCore::Node::removeChild): Ditto. (WebCore::Node::appendChild): Ditto. (WebCore::Node::remove): Removed unneeded ref/unref because ContainerNode::removeChild already does this. (WebCore::Node::createRendererIfNeeded): Removed #if around call to childShouldCreateRenderer since it's needed even without SVG and XHTMLMP.
  • dom/Node.h: Moved definitions of inline functions that depend on ContainerNode to the ContainerNode.h header. They already required inclusion of that header, so there is no functional change. Made insertBefore, replaceChild, removeChild, and appendChild non-virtual. There are very few callers of these functions on this class. Moved isMathMLElement to Element. Added a FIXME about the name of eventAncestors. Fixed comment formatting. Eliminated unused isEditableBlock function. Moved the body of the enclosingInlineElement function to the editing file that was the only call site. Removed the previousEditable and nextEditable functions, incorporating their bodies into the one place they were called. Took the childShouldCreateRenderer function out of #if since it's now used by the implementation of the <noscript> element.
  • dom/Position.cpp: (WebCore::nextRenderedEditable): Rewrote the function to use nextLeafNode instead of nextEditable. (WebCore::previousRenderedEditable): Rewrote the function to use previousLeafNode instead of previousEditable.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::enclosingInline): Moved function here from the Node class. Also fixed an incorrect cast this function did, which assumed the function result was always an element, which the function does not guarantee. (WebCore::ReplaceSelectionCommand::doApply): Call the function above.
  • history/HistoryItem.cpp: Added include of MathExtras.h.
12:48 PM Changeset in webkit [69986] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Fix build.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(handleEventCarbon):

12:46 PM Changeset in webkit [69985] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformSetFocus):

12:33 PM Changeset in webkit [69984] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-10-18 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by Darin Adler.

Missing support for document.createEvent("OrientationEvent")
https://bugs.webkit.org/show_bug.cgi?id=32492

Add support for document.createEvent("OrientationEvent") to help unit testing of
onOrientationChange event.

  • fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt: Added.
  • fast/dom/DeviceOrientation/create-event-onorientationchange.html: Added.
  • fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js: Added.

2010-10-18 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by Darin Adler.

Missing support for document.createEvent("OrientationEvent")
https://bugs.webkit.org/show_bug.cgi?id=32492

Add support for document.createEvent("OrientationEvent") to help unit testing of
onOrientationChange event.

Test: fast/dom/DeviceOrientation/create-event-onorientationchange.html

  • dom/Document.cpp: (WebCore::Document::createEvent):
12:15 PM Changeset in webkit [69983] by jorlow@chromium.org
  • 9 edits in trunk

2010-10-18 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829

Add tests for out of range behavior here since IndexedDB is the only user
of DOMStringList.

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2010-10-18 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829

When item() returns a null string, it needs to be passed to JS as
null. The indexed getter will then magically do the right thing.
So all that's left is having DOMStringList::item() return null when
the index is out of bounds.

  • dom/DOMStringList.cpp: (WebCore::DOMStringList::item):
  • dom/DOMStringList.h:
  • dom/DOMStringList.idl:
12:14 PM Changeset in webkit [69982] by rniwa@webkit.org
  • 4 edits
    3 adds
    33 deletes in trunk/LayoutTests

2010-10-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

dump-as-markup conversion: editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html
https://bugs.webkit.org/show_bug.cgi?id=47784

Converted editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html to dump-as-markup tests.

  • editing/execCommand/4920742-1-expected.txt: Added.
  • editing/execCommand/4920742-1.html:
  • editing/execCommand/5049671-expected.txt: Added.
  • editing/execCommand/5049671.html:
  • editing/execCommand/5573879-expected.txt: Added.
  • editing/execCommand/5573879.html:
  • platform/chromium-linux/editing/execCommand/4920742-1-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/4920742-1-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/5049671-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/5049671-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/5573879-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/5573879-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/4920742-1-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/4920742-1-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/4920742-1-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/5049671-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/5049671-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/5049671-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/5573879-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/5573879-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/5573879-expected.txt: Removed.
  • platform/gtk/editing/execCommand/4920742-1-expected.txt: Removed.
  • platform/gtk/editing/execCommand/5049671-expected.txt: Removed.
  • platform/gtk/editing/execCommand/5573879-expected.txt: Removed.
  • platform/mac-leopard/editing/execCommand/4920742-1-expected.checksum: Removed.
  • platform/mac-leopard/editing/execCommand/4920742-1-expected.png: Removed.
  • platform/mac-leopard/editing/execCommand/5049671-expected.checksum: Removed.
  • platform/mac-leopard/editing/execCommand/5049671-expected.png: Removed.
  • platform/mac/editing/execCommand/4920742-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/4920742-1-expected.png: Removed.
  • platform/mac/editing/execCommand/4920742-1-expected.txt: Removed.
  • platform/mac/editing/execCommand/5049671-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5049671-expected.png: Removed.
  • platform/mac/editing/execCommand/5049671-expected.txt: Removed.
  • platform/mac/editing/execCommand/5573879-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5573879-expected.png: Removed.
  • platform/mac/editing/execCommand/5573879-expected.txt: Removed.
  • platform/qt/editing/execCommand/4920742-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/5049671-expected.txt: Removed.
12:13 PM Changeset in webkit [69981] by Girish Ramakrishnan
  • 3 edits in trunk/WebCore

[Qt] Implement Accelerated Composition for NPAPI Plugins.

Reviewed by Ariya Hidayat.

https://bugs.webkit.org/show_bug.cgi?id=35524

  • plugins/PluginView.h:

(WebCore::PluginView::platformLayer):

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::paint):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::invalidateRegion):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformLayer):

11:54 AM Changeset in webkit [69980] by rniwa@webkit.org
  • 4 edits
    3 adds
    34 deletes in trunk/LayoutTests

2010-10-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

dump-as-markup conversion: editing/execCommand/4786404-1.html, 4786404-2.html, 4920488.html
https://bugs.webkit.org/show_bug.cgi?id=47782

Converted editing/execCommand/4786404-1.html, 4786404-2.html, 4920488.html to dump-as-markup tests.

  • editing/execCommand/4786404-1-expected.txt: Added.
  • editing/execCommand/4786404-1.html:
  • editing/execCommand/4786404-2-expected.txt: Added.
  • editing/execCommand/4786404-2.html:
  • editing/execCommand/4920488-expected.txt: Added.
  • editing/execCommand/4920488.html:
  • platform/chromium-linux/editing/execCommand/4786404-1-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/4786404-1-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/4786404-2-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/4786404-2-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/4920488-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/4920488-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/4786404-1-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/4786404-1-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/4786404-1-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/4786404-2-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/4786404-2-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/4786404-2-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/4920488-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/4920488-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/4920488-expected.txt: Removed.
  • platform/gtk/editing/execCommand/4786404-1-expected.txt: Removed.
  • platform/gtk/editing/execCommand/4786404-2-expected.txt: Removed.
  • platform/gtk/editing/execCommand/4920488-expected.txt: Removed.
  • platform/mac-leopard/editing/execCommand/4786404-2-expected.checksum: Removed.
  • platform/mac-leopard/editing/execCommand/4786404-2-expected.png: Removed.
  • platform/mac-leopard/editing/execCommand/4920488-expected.checksum: Removed.
  • platform/mac-leopard/editing/execCommand/4920488-expected.png: Removed.
  • platform/mac/editing/execCommand/4786404-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/4786404-1-expected.png: Removed.
  • platform/mac/editing/execCommand/4786404-1-expected.txt: Removed.
  • platform/mac/editing/execCommand/4786404-2-expected.checksum: Removed.
  • platform/mac/editing/execCommand/4786404-2-expected.png: Removed.
  • platform/mac/editing/execCommand/4786404-2-expected.txt: Removed.
  • platform/mac/editing/execCommand/4920488-expected.checksum: Removed.
  • platform/mac/editing/execCommand/4920488-expected.png: Removed.
  • platform/mac/editing/execCommand/4920488-expected.txt: Removed.
  • platform/qt/editing/execCommand/4786404-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/4786404-2-expected.txt: Removed.
  • platform/qt/editing/execCommand/4920488-expected.txt: Removed.
11:54 AM Changeset in webkit [69979] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Eric Seidel.

Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.

https://bugs.webkit.org/show_bug.cgi?id=40784

  • bridge/npapi.h:
  • plugins/mac/PluginViewMac.mm: (WebCore::PluginView::setFocus): (WebCore::PluginView::handleMouseEvent):

2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Eric Seidel.

Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.

https://bugs.webkit.org/show_bug.cgi?id=40784

  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::mouseEntered): (WebNetscapePluginEventHandlerCarbon::mouseExited): (WebNetscapePluginEventHandlerCarbon::mouseMoved): (WebNetscapePluginEventHandlerCarbon::focusChanged):

2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Eric Seidel.

Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.

https://bugs.webkit.org/show_bug.cgi?id=40784

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventCarbon):
11:46 AM Changeset in webkit [69978] by andersca@apple.com
  • 13 edits in trunk/WebKit2

Add matchCountDidChange callback
https://bugs.webkit.org/show_bug.cgi?id=47840

Reviewed by Darin Adler.

  • UIProcess/API/C/WKPage.h:

Add matchCountDidChange WKPageFindClient callback.

  • UIProcess/WebFindClient.cpp:

(WebKit::WebFindClient::matchCountDidChange):
Call the WKPageFindClient callback.

  • UIProcess/WebPageProxy.messages.in:

Add MatchCountDidChange message.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::countStringMatches):
Move code here from WebPage.

(WebKit::FindController::findString):
Send the MatchCountDidChange message.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::countStringMatches):
Move this code over to FindController.

11:32 AM Changeset in webkit [69977] by oliver@apple.com
  • 5 edits in trunk

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Strict mode: |this| should be undefined if it is not explicitly provided
https://bugs.webkit.org/show_bug.cgi?id=47833

To make strict mode behave correctly we want to pass undefined instead of null
as the default this value. This has no impact on behaviour outside of strict
mode as both values are replaced with the global object if necessary.

  • bytecompiler/NodesCodegen.cpp: (JSC::FunctionCallValueNode::emitBytecode): (JSC::FunctionCallResolveNode::emitBytecode): (JSC::CallFunctionCallDotNode::emitBytecode): (JSC::ApplyFunctionCallDotNode::emitBytecode):

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Strict mode: |this| should be undefined if it is not explicitly provided
https://bugs.webkit.org/show_bug.cgi?id=47833

Add tests to ensure that |this| is undefined rather than null when it has
not been explicitly provided.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
11:17 AM Changeset in webkit [69976] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: comment out resource manager instantiation on front-end side.
https://bugs.webkit.org/show_bug.cgi?id=47823

  • inspector/front-end/inspector.js:
11:08 AM Changeset in webkit [69975] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-18 Robert Hogan <robert@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

Unskip:

http/tests/navigation/no-referrer-reset.html
http/tests/navigation/no-referrer-target-blank.html

These tests now pass.

  • platform/qt/Skipped:
11:04 AM Changeset in webkit [69974] by andreip@google.com
  • 8 edits in trunk

2010-10-18 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The description parameter of IDBFactory::open() should be mandatory.
https://bugs.webkit.org/show_bug.cgi?id=47835

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:

2010-10-18 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The description parameter of IDBFactory::open() should be mandatory.
https://bugs.webkit.org/show_bug.cgi?id=47835

Makes the description parameter mandatory, as per the IndexedDatabase specification.
Modified existing tests to cover this change.

  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::extractMetaData): (WebCore::setMetaData): (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBFactory.h:
  • storage/IDBFactory.idl:
11:02 AM Changeset in webkit [69973] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Use nullptr instead of 0.

Reviewed by Darin Adler.

  • UIProcess/API/mac/FindIndicatorWindow.mm:

(WebKit::FindIndicatorWindow::closeWindow):

  • UIProcess/API/mac/WKView.mm:

(-[WKView renewGState]):

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::removePluginProxy):

10:41 AM Changeset in webkit [69972] by xji@chromium.org
  • 2 edits in trunk/WebCore

2010-10-18 Xiaomei Ji <xji@chromium.org>

Reviewed by David Levin.

Code cleanup: Move most function members in TextRunWorker from inlined.
https://bugs.webkit.org/show_bug.cgi?id=47732

No functionality change, so no tests added.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::setWordSpacingAdjustment): (WebCore::TextRunWalker::setLetterSpacingAdjustment): (WebCore::TextRunWalker::setXOffsetToZero): (WebCore::TextRunWalker::rtl): (WebCore::TextRunWalker::glyphs): (WebCore::TextRunWalker::length): (WebCore::TextRunWalker::xPositions): (WebCore::TextRunWalker::advances): (WebCore::TextRunWalker::width): (WebCore::TextRunWalker::logClusters): (WebCore::TextRunWalker::numCodePoints): (WebCore::TextRunWalker::fontPlatformDataForScriptRun): (WebCore::TextRunWalker::isCodepointSpace): (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::isWordBreak): (WebCore::TextRunWalker::setPadding): (WebCore::TextRunWalker::reset): (WebCore::TextRunWalker::setBackwardsIteration): (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::widthOfFullRun): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setupFontForScriptRun): (WebCore::TextRunWalker::allocHarfbuzzFont): (WebCore::TextRunWalker::deleteGlyphArrays): (WebCore::TextRunWalker::createGlyphArrays): (WebCore::TextRunWalker::resetGlyphArrays): (WebCore::TextRunWalker::shapeGlyphs): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::TextRunWalker::mirrorCharacters):
10:27 AM Changeset in webkit [69971] by noam.rosenthal@nokia.com
  • 3 edits in trunk/WebCore

2010-10-18 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] AC rendering bugs
There were a few missing connections in Qt AC between GraphicsLayer and plugins, like changing the plugin's geometry to the layer's
contentsRect, and making sure media layers handle ParentChange events and setContentsNeedsDisplay. Now media layers behave correctly.

https://bugs.webkit.org/show_bug.cgi?id=47571

No new tests. This is in preparation for fixing AC+plugins, which already has tests that don't work yet with Qt.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsNeedsDisplay):
  • platform/graphics/qt/GraphicsLayerQt.h:
10:23 AM Changeset in webkit [69970] by Darin Adler
  • 10 edits
    1 add in trunk/JavaScriptCore

2010-10-18 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Make a nullptr that works with OwnPtr and RefPtr
https://bugs.webkit.org/show_bug.cgi?id=47756

  • wtf/NullPtr.h: Added.
  • wtf/OwnArrayPtr.h: Add an overload of = taking nullptr.
  • wtf/OwnPtr.h: Ditto.
  • wtf/PassOwnArrayPtr.h: Ditto.
  • wtf/PassOwnPtr.h: Ditto.
  • wtf/PassRefPtr.h: Ditto.
  • wtf/RefPtr.h: Ditto.
  • wtf/RetainPtr.h: Ditto.
10:21 AM Changeset in webkit [69969] by podivilov@chromium.org
  • 4 edits in trunk/WebKit

2010-10-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: disable private browsing for inspector
https://bugs.webkit.org/show_bug.cgi?id=47827

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]):

2010-10-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: disable private browsing for inspector
https://bugs.webkit.org/show_bug.cgi?id=47827

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::openInspectorFrontend):
10:08 AM Changeset in webkit [69968] by pfeldman@chromium.org
  • 15 edits
    1 add in trunk

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Simon Fraser.

Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorClient.cpp: Added. (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
  • inspector/InspectorClient.h: (WebCore::InspectorClient::InspectorClient):

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Simon Fraser.

Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224

  • WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::sendMessageToFrontend):

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Simon Fraser.

Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::sendMessageToFrontend):

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Simon Fraser.

Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::sendMessageToFrontend):
10:07 AM Changeset in webkit [69967] by alex
  • 2 edits in trunk/LayoutTests

2010-10-18 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip test failing in the bots, bug opened to check the
problem: https://bugs.webkit.org/show_bug.cgi?id=47832

  • platform/gtk/Skipped:
9:48 AM Changeset in webkit [69966] by noam.rosenthal@nokia.com
  • 3 edits in trunk/WebKit/qt

2010-10-18 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] AC rendering bugs

This fixes a regression that was introduced by making scrolling in accelerated compositing automatic,
which made our explicit function to scroll the compositing layers superfluous, making the scrolling behavior
when graphics layers are present incorrect. The fix simply removes those redundant functions.

https://bugs.webkit.org/show_bug.cgi?id=47571

  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::scroll): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
  • WebCoreSupport/PageClientQt.h:
9:47 AM Changeset in webkit [69965] by oliver@apple.com
  • 5 edits in trunk

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: JIT doesn't check for |this| being an immediate before dereferencing
https://bugs.webkit.org/show_bug.cgi?id=47826

There's no guarantee that |this| will be a cell in a strict mode function, so
don't claim that it is.

  • bytecode/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: JIT doesn't check for |this| being an immediate before dereferencing
https://bugs.webkit.org/show_bug.cgi?id=47826

Add tests for accessing properties on |this| when |this| is not an object

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js: (testThisDotAccess): (testThisBracketAccess):
9:35 AM Changeset in webkit [69964] by andreip@google.com
  • 3 edits
    1 delete in trunk/WebCore

2010-10-18 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBKeyTree.h is no longer used.
https://bugs.webkit.org/show_bug.cgi?id=47824

No new tests, just removing unused files.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/IDBKeyTree.h: Removed.
9:30 AM Changeset in webkit [69963] by zherczeg@webkit.org
  • 5 edits in trunk

2010-10-18 Zoltan Herczeg <zherczeg@webkit.org>

Reviewed by Oliver Hunt.

if (0) throw "x" ; else { } throws parse error after r69906
https://bugs.webkit.org/show_bug.cgi?id=47807

r69906 introduced a bug: the semicolon is not parsed after a throw
expression anymore. Thus, the semicolon terminates the "if" parsing
in the example above, and the else token results a parse error.

  • parser/JSParser.cpp: (JSC::JSParser::parseThrowStatement):

2010-10-18 Zoltan Herczeg <zherczeg@webkit.org>

Reviewed by Oliver Hunt.

if (0) throw "x" ; else { } throws parse error after r69906
https://bugs.webkit.org/show_bug.cgi?id=47807

Adding a new test case to break-ASI.js

  • fast/js/break-ASI-expected.txt:
  • fast/js/script-tests/break-ASI.js:
9:16 AM Changeset in webkit [69962] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] Fix the build with MSVC.

Reviewed by nobody, build fix.

Splitting the condition in two to prevent qmake parentheses issues.

  • Api/DerivedSources.pro:
8:41 AM Changeset in webkit [69961] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-10-18 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Antonio Gomes.

[QT] Unable to load pages on QtTestBrowser after canceling a page load.
https://bugs.webkit.org/show_bug.cgi?id=43827

  • Api/qwebpage.cpp: (QWebPage::triggerAction):
8:39 AM Changeset in webkit [69960] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-18 Andreas Kling <kling@webkit.org>

Unreviewed buildfix for Qt + V8.
Add missing <wtf/text/CString.h> include.

  • inspector/InspectorInstrumentation.cpp:
8:24 AM Changeset in webkit [69959] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: toJSON serialization for Numbers should be fixed.
DecimalNumber is used instead of printf.

https://bugs.webkit.org/show_bug.cgi?id=43832

  • inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
6:29 AM Changeset in webkit [69958] by Csaba Osztrogonác
  • 1 edit
    107 adds in trunk/LayoutTests

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/editing/input: Added.
  • platform/qt/editing/input/emacs-ctrl-o-expected.checksum: Added.
  • platform/qt/editing/input/emacs-ctrl-o-expected.png: Added.
  • platform/qt/editing/input/emacs-ctrl-o-expected.txt: Added.
  • platform/qt/fast/blockflow: Added.
  • platform/qt/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/qt/fast/blockflow/block-level-images-expected.png: Added.
  • platform/qt/fast/blockflow/block-level-images-expected.txt: Added.
  • platform/qt/fast/blockflow/fieldsets-expected.checksum: Added.
  • platform/qt/fast/blockflow/fieldsets-expected.png: Added.
  • platform/qt/fast/blockflow/fieldsets-expected.txt: Added.
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.checksum: Added.
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.png: Added.
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.txt: Added.
  • platform/qt/fast/blockflow/inline-direction-positioning-expected.checksum: Added.
  • platform/qt/fast/blockflow/inline-direction-positioning-expected.png: Added.
  • platform/qt/fast/blockflow/inline-direction-positioning-expected.txt: Added.
  • platform/qt/fast/blockflow/margin-collapse-expected.checksum: Added.
  • platform/qt/fast/blockflow/margin-collapse-expected.png: Added.
  • platform/qt/fast/blockflow/margin-collapse-expected.txt: Added.
  • platform/qt/fast/blockflow/root-lr-basic-expected.checksum: Added.
  • platform/qt/fast/blockflow/root-lr-basic-expected.png: Added.
  • platform/qt/fast/blockflow/root-lr-basic-expected.txt: Added.
  • platform/qt/fast/blockflow/self-collapsing-block-expected.checksum: Added.
  • platform/qt/fast/blockflow/self-collapsing-block-expected.png: Added.
  • platform/qt/fast/blockflow/self-collapsing-block-expected.txt: Added.
  • platform/qt/fast/css/first-letter-punctuation-expected.checksum: Added.
  • platform/qt/fast/css/first-letter-punctuation-expected.png: Added.
  • platform/qt/fast/css/first-letter-punctuation-expected.txt: Added.
  • platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
  • platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
  • platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
  • platform/qt/fast/css/rtl-to-viewport-expected.checksum: Added.
  • platform/qt/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/qt/fast/css/rtl-to-viewport-expected.txt: Added.
  • platform/qt/fast/forms/input-button-sizes-expected.checksum: Added.
  • platform/qt/fast/forms/input-button-sizes-expected.png: Added.
  • platform/qt/fast/forms/input-button-sizes-expected.txt: Added.
  • platform/qt/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
  • platform/qt/fast/forms/input-placeholder-focus-twice-expected.png: Added.
  • platform/qt/fast/forms/input-placeholder-focus-twice-expected.txt: Added.
  • platform/qt/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/qt/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/qt/fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/qt/fast/multicol/border-padding-pagination-expected.checksum: Added.
  • platform/qt/fast/multicol/border-padding-pagination-expected.png: Added.
  • platform/qt/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/qt/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/qt/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/qt/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/qt/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/qt/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/qt/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/qt/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/qt/fast/multicol/margin-collapse-expected.png: Added.
  • platform/qt/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/qt/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/qt/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/qt/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/qt/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/qt/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/qt/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/qt/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/qt/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/qt/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/qt/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/qt/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/qt/fast/multicol/unsplittable-inline-block-expected.txt: Added.
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
  • platform/qt/scrollbars: Added.
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/qt/svg/custom/fill-opacity-hsl-expected.checksum: Added.
  • platform/qt/svg/custom/fill-opacity-hsl-expected.png: Added.
  • platform/qt/svg/custom/fill-opacity-hsl-expected.txt: Added.
  • platform/qt/svg/custom/fill-opacity-rgba-expected.checksum: Added.
  • platform/qt/svg/custom/fill-opacity-rgba-expected.png: Added.
  • platform/qt/svg/custom/fill-opacity-rgba-expected.txt: Added.
  • platform/qt/svg/custom/recursive-filter-expected.checksum: Added.
  • platform/qt/svg/custom/recursive-filter-expected.png: Added.
  • platform/qt/svg/custom/recursive-filter-expected.txt: Added.
  • platform/qt/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
  • platform/qt/svg/custom/repaint-on-constant-size-change-expected.png: Added.
  • platform/qt/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
  • platform/qt/svg/custom/text-rotation-expected.checksum: Added.
  • platform/qt/svg/custom/text-rotation-expected.png: Added.
  • platform/qt/svg/custom/text-rotation-expected.txt: Added.
  • platform/qt/svg/custom/text-x-dy-lists-expected.checksum: Added.
  • platform/qt/svg/custom/text-x-dy-lists-expected.png: Added.
  • platform/qt/svg/custom/text-x-dy-lists-expected.txt: Added.
  • platform/qt/svg/in-html/by-reference-expected.txt: Added.
6:20 AM Changeset in webkit [69957] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-18 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Andreas Kling.

Remove some unnecessary lines of code from Parser.cpp
https://bugs.webkit.org/show_bug.cgi?id=47816

  • parser/Parser.cpp:
5:46 AM Changeset in webkit [69956] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Inspector window visible during run-webkit-tests.
The initial state of an inspector setting should stay untouched
if the profile has no value for it.

https://bugs.webkit.org/show_bug.cgi?id=47785

  • inspector/InspectorState.cpp: (WebCore::InspectorState::loadFromSettings):
5:43 AM Styling Form Controls edited by morrita@google.com
(diff)
5:42 AM Styling Form Controls edited by morrita@google.com
(diff)
5:41 AM Styling Form Controls edited by morrita@google.com
(diff)
5:33 AM custom-progress.png attached to Styling Form Controls by morrita@google.com
A <progress> screenshot
5:33 AM custom-meter.png attached to Styling Form Controls by morrita@google.com
A <meter> screenshot
5:32 AM Styling Form Controls created by morrita@google.com
5:29 AM Changeset in webkit [69955] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-18 David Levin <levin@chromium.org>

Reviewed by Adam Barth.

check-webkit-style should treat the GObject binding directory like other GTK directories.
https://bugs.webkit.org/show_bug.cgi?id=47796

  • Scripts/webkitpy/style/checker.py: Added the GObject binding directory with the other gtk directories (and fixed typo).
5:24 AM WikiStart edited by morrita@google.com
(diff)
5:13 AM Changeset in webkit [69954] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: tab headers on resource panel are 1px off on Mac.
https://bugs.webkit.org/show_bug.cgi?id=47798

  • inspector/front-end/inspector.css: (.tabbed-pane-header li):
4:57 AM Changeset in webkit [69953] by levin@chromium.org
  • 4 edits in trunk/WebKitTools

2010-10-18 David Levin <levin@chromium.org>

Reviewed by Oliver Hunt.

check-webkit-style needs to ignore underscores in opcode names and vm_throw
https://bugs.webkit.org/show_bug.cgi?id=47789

  • Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
  • Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.
4:46 AM Changeset in webkit [69952] by morrita@google.com
  • 20 edits in trunk

2010-10-18 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=47659

Changed the reciever of hasSpellingMarkers from
textInputController to layoutTestController.

  • editing/spelling/design-mode-spellcheck-off.html:
  • editing/spelling/script-tests/spelling-backspace-between-lines.js: (testWithDelete): (testWithForwardDelete):
  • editing/spelling/spelling-backspace-between-lines-expected.txt:
  • editing/spelling/spelling-contenteditable.html:
  • editing/spelling/spelling-textarea.html:

2010-10-18 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=47659

Moved hasSpellingMarkers() from TextInputController to
LayoutTestController. Currently the implementation is available
only for Mac and for Chromium.

  • DumpRenderTree/LayoutTestController.cpp: (hasSpellingMarkerCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::hasSpellingMarker):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): (TextInputController::makeAttributedString):
  • DumpRenderTree/chromium/TextInputController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::hasSpellingMarker):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasSpellingMarker):
  • DumpRenderTree/mac/TextInputController.m: (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::hasSpellingMarker):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::hasSpellingMarker):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::hasSpellingMarker):
4:42 AM Changeset in webkit [69951] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-18 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

commit-queue's flaky test notice is very Pythony
https://bugs.webkit.org/show_bug.cgi?id=47790

This patch make the list of tests delimted by \n instead of just
converting the array to a string.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
3:42 AM Changeset in webkit [69950] by alex
  • 2 edits in trunk/LayoutTests

2010-10-18 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip another mathml flaky test, check bug:
https://bugs.webkit.org/show_bug.cgi?id=47727

  • platform/gtk/Skipped:
3:39 AM Changeset in webkit [69949] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Build fix.

  • inspector/InspectorResourceAgent.cpp: (WebCore::cachedResourceTypeString):
3:14 AM Changeset in webkit [69948] by pfeldman@chromium.org
  • 27 edits
    1 add in trunk

2010-10-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
fill network panel with data.
https://bugs.webkit.org/show_bug.cgi?id=47779


InspectorResourceAgent instance / JS part are introduced in this patch. Agent's lifetime is equal
to the front-end's. This new resource agent does not have state, instead it covers two functions:

1) forwards loader client messages to the front-end 2) is capable of building a tree of cached resources.

(1) feeds network panel with data, (2) shows the resource tree in the new ResourcesPanel concept.
This bug is for extracting this new InspectorResourceAgent class and its javascript counterpart.
Once resources panel is refactored for the new concept, InspectorResource, InspectorController's
resource-related routines, inspector.js's code dealing with resources, they all will be gone.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse): (WebCore::cachedResourceType): (WebCore::InspectorResource::type): (WebCore::InspectorResource::sourceString): (WebCore::InspectorResource::sourceBytes): (WebCore::InspectorResource::endTiming):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::resourceContentBase64): (WebCore::InspectorResourceAgent::resourceData): (WebCore::InspectorResourceAgent::cachedResource): (WebCore::buildObjectForHeaders): (WebCore::buildObjectForTiming): (WebCore::buildObjectForResourceRequest): (WebCore::buildObjectForResourceResponse): (WebCore::buildObjectForMainResource): (WebCore::cachedResourceTypeString): (WebCore::buildObjectForCachedResource): (WebCore::buildObjectForFrameResources): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::identifierForInitialRequest): (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::markResourceAsCached): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::didFailLoading): (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): (WebCore::InspectorResourceAgent::setOverrideContent): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::createReadableStringFromBinary): (WebCore::InspectorResourceAgent::didCreateWebSocket): (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorResourceAgent::didCloseWebSocket): (WebCore::InspectorResourceAgent::cachedResources): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetResourceContent):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get responseReceivedTime): (WebInspector.Resource.prototype.set endTime):
  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.tabbed-pane-header li):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse):

2010-10-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
fill network panel with data.
https://bugs.webkit.org/show_bug.cgi?id=47779

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didReceiveResponse):
2:18 AM Changeset in webkit [69947] by pfeldman@chromium.org
  • 11 edits in trunk

2010-10-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up URL parsing on the front-end.
https://bugs.webkit.org/show_bug.cgi?id=47772

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.getDomainToResourcesMap): (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun): (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun): (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies): (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
  • inspector/front-end/DOMAgent.js: (WebInspector.Cookies.cookieMatchesResourceURL):
  • inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.set url): (WebInspector.Resource.prototype.get displayName):
  • inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory.prototype.addResource):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView):
  • inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.updateResource): (WebInspector.linkifyStringAsFragment): (WebInspector.resourceURLForRelatedNode): (WebInspector.completeURL):
  • inspector/front-end/utilities.js: (String.prototype.asParsedURL):
1:15 AM Changeset in webkit [69946] by andreas.kling@nokia.com
  • 3 edits in trunk/WebCore

2010-10-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support custom open() verbs/methods in XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=40476

Fall back to QNetworkAccessManager::CustomOperation for any HTTP verb
that's not specifically supported by QNetworkAccessManager.

This prevents the infinite loop that otherwise occurs after sending
an UnknownOperation request.

This change is covered by existing (skipped) tests that will be
unskipped once the Qt bots are running Qt 4.7.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::httpMethod): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  • platform/network/qt/QNetworkReplyHandler.h:
12:53 AM Changeset in webkit [69945] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2010-10-18 Adam Barth <abarth@webkit.org>

Add more Skipped list entries because WebP requires an external decoder
library.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
12:39 AM Changeset in webkit [69944] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Csaba Osztrogonác.

Build broken with JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=47801

This is a regression caused by r69940.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveBase):
12:25 AM Changeset in webkit [69943] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

Change FastAllocBase implementation into a macro
https://bugs.webkit.org/show_bug.cgi?id=42998

Reviewed by Darin Adler.

It was investigated in bug #33896 that inheriting classes from FastAllocBase
can result in objects getting larger which leads to memory regressions.
Using a macro instead of inheriting classes from FastAllocBase would solve the issue.

  • wtf/FastAllocBase.h: Add a WTF_MAKE_FAST_ALLOCATED macro

Oct 17, 2010:

11:51 PM Changeset in webkit [69942] by commit-queue@webkit.org
  • 11 edits
    6 adds in trunk

2010-10-17 Pascal Massimino <pascal.massimino@gmail.com>

Reviewed by Adam Barth.

Add support for WebP image decoding in ImageDecoder
using library libwebp-decode library available from
http://www.webmproject.org/code/

https://bugs.webkit.org/show_bug.cgi?id=47512

Tests: fast/images/webp-image-decoding.html

  • CMakeLists.txt:

add platform/image-decoders/webp files and directory

  • GNUmakefile.am:

add platform/image-decoders/webp directory

  • WebCore.gyp/WebCore.gyp:

add platform/image-decoders/webp directory

  • WebCore.gypi:

add platform/image-decoders/webp directory

  • features.gypi:

add WTF_USE_WEBP=1

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create):

instantiate webp decoder for file starting with 'RIFF????WEBP'

  • platform/image-decoders/webp: Added.
  • platform/image-decoders/webp/WEBPImageDecoder.cpp: Added. (WebCore::WEBPImageDecoder::WEBPImageDecoder): (WebCore::WEBPImageDecoder::~WEBPImageDecoder): (WebCore::WEBPImageDecoder::isSizeAvailable): (WebCore::WEBPImageDecoder::frameBufferAtIndex): (WebCore::WEBPImageDecoder::decode):

sub-class handling decoding of webp images

  • platform/image-decoders/webp/WEBPImageDecoder.h: Added. (WebCore::WEBPImageDecoder::filenameExtension): (WebCore::WEBPImageDecoder::supportsAlpha):

header for webp-decoder sub-class

2010-10-17 Pascal Massimino <pascal.massimino@gmail.com>

Reviewed by Adam Barth.


Add support for decoding WebP image
https://bugs.webkit.org/show_bug.cgi?id=47512


  • DEPS:
    • Add dependency to libwebp.
10:42 PM Changeset in webkit [69941] by oliver@apple.com
  • 5 edits in trunk

2010-10-17 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: arguments is not valid as the base expression for pre- or post-fix expressions
https://bugs.webkit.org/show_bug.cgi?id=47791

Simple fix, check for arguments in addition to eval.

  • parser/JSParser.cpp: (JSC::JSParser::parseUnaryExpression):

2010-10-17 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: arguments is not valid as the base expression for pre- or post-fix expressions
https://bugs.webkit.org/show_bug.cgi?id=47791

Add arguments tests, and make pre-/post-fix expression tests cover another case I was
needlessly worried about.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
9:08 PM Changeset in webkit [69940] by oliver@apple.com
  • 20 edits in trunk

2010-10-17 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: Assignment that would create a global should be a late ReferenceError, not a syntax failure
https://bugs.webkit.org/show_bug.cgi?id=47788

Fixing this required a couple of changes:

  • resolve_base now has a flag to indicate whether it is being used for a put in strict mode. this allows us to throw an exception when we're doing a completely generic resolve for assignment, and that assignment would create a new global.
  • There is a new opcode 'op_ensure_property_exists' that is used to determine whether the property being assigned to already exists on the global object. This currently has no caching, but such caching could be added relatively trivially. It is only used in the case where we know that a property will be placed on the global object, and we cannot verify that the property already exists.

In the jit we plant a call to cti_op_resolve_base_strict_put in the effected case rather
than making op_resolve_base have an additional runtime branch.

There's also a new helper function to create the exception for the invalid assignment.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitResolveBase): (JSC::BytecodeGenerator::emitResolveBaseForPut):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::AssignResolveNode::emitBytecode): (JSC::ForInNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveBase): (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_ensure_property_exists):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_ensure_property_exists):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
  • parser/JSParser.cpp: (JSC::JSParser::parseProgram):
  • runtime/ExceptionHelpers.cpp: (JSC::createErrorForInvalidGlobalAssignment):
  • runtime/ExceptionHelpers.h:
  • runtime/Operations.h: (JSC::resolveBase):

2010-10-17 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: Assignment that would create a global should be a late ReferenceError, not a syntax failure
https://bugs.webkit.org/show_bug.cgi?id=47788

Update test to check for the correct behaviour.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
9:02 PM Changeset in webkit [69939] by tonikitoo@webkit.org
  • 3 edits in trunk/LayoutTests

2010-10-17 Antonio Gomes <agomes@rim.com>

Reviewed by Simon Fraser.

Enrich /fast/dom/nodesFromRect-basic.html test
https://bugs.webkit.org/show_bug.cgi?id=47766

The patch makes fast/dom/nodesFromRect-basic.html test more precise:
instead of calling nodesFromRect always with equal vertical (up and down) and
horizontal (right and left) padding values, it are now tests it by passing
different padding values on the various directions.

It is now possible due to the work on bug 46336: Make Document::nodesFromRect more flexible.

  • fast/dom/nodesFromRect-basic-expected.txt:
  • fast/dom/nodesFromRect-basic.html:
7:59 PM Changeset in webkit [69938] by abarth@webkit.org
  • 9 edits in trunk/WebCore

2010-10-17 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Remove explicit passing of user gesture in NavigationScheduler
https://bugs.webkit.org/show_bug.cgi?id=47786

As requested by Mr. Glazkov, remove more explicit passing of the user
gesture state. We now use a static to pass this information around.

  • bindings/generic/BindingFrame.h: (WebCore::::navigateIfAllowed):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::reload):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::reloadCallback):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::reloadPage):
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledNavigation::ScheduledNavigation): (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): (WebCore::ScheduledRedirect::ScheduledRedirect): (WebCore::ScheduledLocationChange::ScheduledLocationChange): (WebCore::ScheduledRefresh::ScheduledRefresh): (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation): (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::NavigationScheduler::scheduleRedirect): (WebCore::NavigationScheduler::mustLockBackForwardList): (WebCore::NavigationScheduler::scheduleLocationChange): (WebCore::NavigationScheduler::scheduleFormSubmission): (WebCore::NavigationScheduler::scheduleRefresh): (WebCore::NavigationScheduler::scheduleHistoryNavigation):
  • loader/NavigationScheduler.h:
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadOrRedirectSubframe):
6:22 PM Changeset in webkit [69937] by jchaffraix@webkit.org
  • 5 edits
    2 adds in trunk

WebCore: 'transparent' should be a valid color
https://bugs.webkit.org/show_bug.cgi?id=45482

Reviewed by Andreas Kling.

Test: svg/animations/svg-animate-color-transparent.svg

Based on previous work by Jan Erik Hanssen <jhanssen@codeaurora.org>

  • platform/ColorData.gperf: Added 'transparent' to the list of colors.

Added the alpha to all the colors as it was needed to support the new color.

  • platform/graphics/Color.cpp:

(WebCore::Color::Color):
(WebCore::Color::setNamedColor): Avoid setting the alpha as now it is not
always 0xFF.

LayoutTests: Test for: 'transparent' should be a valid color
https://bugs.webkit.org/show_bug.cgi?id=45482

Reviewed by Andreas Kling.

Test that animation works with 'transparent' as they check the validity of the
color.

  • svg/animations/svg-animate-color-transparent-expected.txt: Added.
  • svg/animations/svg-animate-color-transparent.svg: Added.
5:47 PM Changeset in webkit [69936] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-17 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Duplicate use element children in shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=47561

Test: svg/custom/use-nested-children.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::expandUseElementsInShadowTree):

2010-10-17 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Duplicate use element children in shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=47561

  • svg/custom/use-nested-children-expected.txt: Added.
  • svg/custom/use-nested-children.svg: Added.
5:04 PM Changeset in webkit [69935] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-17 Hyung Song <beergun@company100.net>

Reviewed by David Levin.

Add !SINGLE_THREADED guard.
https://bugs.webkit.org/show_bug.cgi?id=47608

For SINGLE_THREADED ports LockingMutex.tryLock() returns false.
This will prevent interrupt() from falling into infinite loop.

  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::interrupt):
3:05 PM Changeset in webkit [69934] by Simon Fraser
  • 1 edit
    1 delete in trunk/LayoutTests

2010-10-17 Simon Fraser <Simon Fraser>

Remove Windows-specific result, which is not longer needed after r69928.

  • platform/win/fast/css/large-number-round-trip-expected.txt: Removed.
2:55 PM Changeset in webkit [69933] by jorlow@chromium.org
  • 32 edits in branches/chromium/552

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508

BUG=59508

Patch by Andrei Popescu <andreip@google.com> on 2010-10-11
Reviewed by Jeremy Orlow.

LayoutTests:

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:

WebCore:

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBCursorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseExceptionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBErrorEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBFactoryEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBIndexEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBKeyRangeEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBObjectStoreEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBRequestEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBSuccessEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBTransactionEnabled):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitIndexedDB):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableIndexedDatabase):
(WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):
Merge 69540 - 2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:

2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBCursorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseErrorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseExceptionEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBErrorEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBFactoryEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBIndexEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBKeyRangeEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBObjectStoreEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBRequestEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBSuccessEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBTransactionEnabled):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitIndexedDB):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508

  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableIndexedDatabase): (WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):

TBR=andreip@google.com

2:48 PM Changeset in webkit [69932] by jorlow@chromium.org
  • 3 edits in branches/chromium/552/LayoutTests

storage/indexeddb/database-quota.html expects the wrong database version string
https://bugs.webkit.org/show_bug.cgi?id=47533

BUG=59506

Patch by Andrei Popescu <andreip@google.com> on 2010-10-11
Reviewed by Jeremy Orlow.

  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:

Merge 69612 - 2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

storage/indexeddb/database-quota.html expects the wrong database version string
https://bugs.webkit.org/show_bug.cgi?id=47533

  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:

TBR=andreip@google.com

2:46 PM Changeset in webkit [69931] by jorlow@chromium.org
  • 2 edits in branches/chromium/552/WebKit/chromium

[Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
https://bugs.webkit.org/show_bug.cgi?id=47531

BUG=59506

Patch by Andrei Popescu <andreip@google.com> on 2010-10-11
Reviewed by Jeremy Orlow.

Remove the temporary open() method since the appropriate Chromium plumbing was
added in http://codereview.chromium.org/3729003/

  • public/WebIDBFactory.h:

(WebKit::WebIDBFactory::open):
Merge 69670 - 2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
https://bugs.webkit.org/show_bug.cgi?id=47531

Remove the temporary open() method since the appropriate Chromium plumbing was
added in http://codereview.chromium.org/3729003/

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):

TBR=andreip@google.com

2:44 PM Changeset in webkit [69930] by mrobinson@webkit.org
  • 11 edits in trunk/LayoutTests

2010-10-17 Martin Robinson <mrobinson@igalia.com>

Rebaseline MathML tests after r69926.

  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fenced-mi-expected.txt:
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.txt:
  • platform/gtk/mathml/presentation/tokenElements-expected.txt:
  • platform/gtk/mathml/presentation/underover-expected.txt:
1:40 PM Changeset in webkit [69929] by Simon Fraser
  • 2 edits in trunk/JavaScriptCore

2010-10-17 Simon Fraser <Simon Fraser>

First part of fix for Windows build failure. Will wait for the
next set of link errors to determine the mangled forms for dtoaRoundSF
and dtoaRoundDP.

1:05 PM Changeset in webkit [69928] by Simon Fraser
  • 12 edits
    2 adds
    1 delete in trunk

2010-10-17 Simon Fraser <Simon Fraser>

Reviewed by Nikolas Zimmermann.

Very large and small numbers fail to round-trip through CSS
https://bugs.webkit.org/show_bug.cgi?id=20674

Use the new DecimalNumber functionality to convert CSS numberic values to strings
using decimal notation, rather than %g (which can output scientific notation).

Test: fast/css/round-trip-values.html

  • css/CSSPrimitiveValue.cpp: (WebCore::formatNumber): (WebCore::CSSPrimitiveValue::cssText):
12:46 PM Changeset in webkit [69927] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-10-17 Cosmin Truta <ctruta@chromium.org>

Reviewed by Nikolas Zimmermann.

Crash while processing ill-formed SVG with cycles
https://bugs.webkit.org/show_bug.cgi?id=47498

Checked the behavior of the attributes fill, stroke, clip and mask
when used with URLs that point to wrong elements.

  • svg/custom/invalid-paint-shape-mask.svg: Added.
  • svg/custom/invalid-paint-shape-mask-expected.svg: Added.

2010-10-17 Cosmin Truta <ctruta@chromium.org>

Reviewed by Nikolas Zimmermann.

Crash while processing ill-formed SVG with cycles
https://bugs.webkit.org/show_bug.cgi?id=47498

Test: svg/custom/invalid-paint-shape-mask.svg

  • rendering/SVGResources.cpp: (paintingResourceFromSVGPaint): Ensured that the painting resource is either a pattern resource or a gradient resource. (SVGResources::setClipper): (SVGResources::setFilter): (SVGResources::setMarkerStart): (SVGResources::setMarkerMid): (SVGResources::setMarkerEnd): (SVGResources::setMasker): (SVGResources::setFill): (SVGResources::setStroke): Added ASSERT statements for previously-unchecked preconditions.
11:44 AM Changeset in webkit [69926] by commit-queue@webkit.org
  • 26 edits in trunk

2010-10-17 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Since whitespace and baseline alignment have changed for operators,
many tests needed to be re-baselined.

  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/fenced-expected.checksum:
  • platform/mac/mathml/presentation/fenced-expected.png:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.checksum:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.checksum:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:

2010-10-17 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Fixed extra whitespace above operators when they aren't stretched
yet the stretch height is large. Also, the baseline alignment
was changed so that rows and operators interact appropriately now
that operators don't have the extra white space.

  • mathml/RenderMathMLOperator.cpp:
  • mathml/RenderMathMLRow.cpp:
11:19 AM Changeset in webkit [69925] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

2010-10-17 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Layout tests for fix focusing of control elements on mouse click.
https://bugs.webkit.org/show_bug.cgi?id=40641

  • fast/events/click-focus-control-expected.txt: Added.
  • fast/events/click-focus-control.html: Added.
  • platform/mac/fast/events/click-focus-control-expected.txt: Added.
  • platform/win/Skipped:

2010-10-17 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Fix focusing of control elements on mouse click.
Brings GTK fix to Qt platform.
https://bugs.webkit.org/show_bug.cgi?id=40641

Test: fast/events/click-focus-control.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isMouseFocusable):
9:02 AM Changeset in webkit [69924] by abarth@webkit.org
  • 14 edits in trunk

2010-10-17 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

FrameLoader doesn't need an explicit userGesture parameter
https://bugs.webkit.org/show_bug.cgi?id=47777

We used to pass around the user gesture state explicitly. Now we use
static state. Explicitly passing the user gesture state to FrameLoader
in these methods is pretty out-dated.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow): (WebCore::::open):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.h:
  • html/HTMLAnchorElement.cpp: (WebCore::handleLinkClick):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::openInInspectedWindow):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm):
  • loader/FrameLoader.h:
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledURLNavigation::fire): (WebCore::ScheduledRefresh::fire): (WebCore::ScheduledHistoryNavigation::fire): (WebCore::NavigationScheduler::scheduleLocationChange):

2010-10-17 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

FrameLoader doesn't need an explicit userGesture parameter
https://bugs.webkit.org/show_bug.cgi?id=47777

Update for the new API.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
7:31 AM Changeset in webkit [69923] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-17 Sergey A. Sukiyazov <sergey.sukiyazov@gmail.com>

Reviewed by Andreas Kling

[Qt] Hovering the mouse over links produce a trail of underlined links (X11 paint engine)
https://bugs.webkit.org/show_bug.cgi?id=42248

The problem will appear because coordinates of points may increase by 0.05f (if line width is odd) inside
method GraphicsContext::adjustLineToPixelBoundaries(...) and become outside of text bounding rect htere,
then the new point coordinates will be passed to Qt graphics engine.

The solution decreases Y cordinates of points inside drawLineForText(...) method only if Qt graphics engine
is X11. The Y coordinates will be increase by 0.5f inside method adjustLineToPixelBoundaries(...), which
called from drawLine(...), and then inside Qt painting engine will be rounded to next greater integer value.

NOTE: This changes will affect only Qt X11 verision and if only X11 Painting Engine will be used.

No new tests.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForText):
3:53 AM Changeset in webkit [69922] by rwlbuis@webkit.org
  • 10 edits in trunk

2010-10-17 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

Text under nested link dropped
https://bugs.webkit.org/show_bug.cgi?id=46460

Allow links inside of tspan and textPath elements.

  • svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::childShouldCreateRenderer):
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::childShouldCreateRenderer):
Note: See TracTimeline for information about the timeline view.