Context Navigation

← Previous Period
Next Period →

Timeline

Nov 11, 2010:

11:58 PM Changeset in webkit [71897] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2010-11-11 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed. Disable SVG tests added by r71895 because Qt has its own XML parser,
and it needs to be fixed separately.

platform/qt/Skipped:

11:39 PM Changeset in webkit [71896] by levin@chromium.org

3 edits in trunk/WebKitTools

check-webkit-style function detection doesn't handle templates with spaces.
https://bugs.webkit.org/show_bug.cgi?id=49427

Reviewed by Shinichiro Hamaji.

Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when finding the function name.
Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a template with a space.

11:21 PM Changeset in webkit [71895] by rniwa@webkit.org

13 edits
8 adds in trunk

2010-11-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Script runs more than once after a clone
https://bugs.webkit.org/show_bug.cgi?id=48966

The bug was caused by cloneElementWithoutChildren's not propagating isEvaluated flag,
which indicates whether or not the script has already started, and the fact
neither HTMLScriptRunner nor XMLDocumentParser was setting isEvaluated flag to true.

Fixed the bug by making cloneElementWithoutChildren call a virtual cloneElementWithoutAttributesAndChildren,
and override it in HTMLScriptElement and SVGScriptElement to propagate isEvaluated flag,
and replacing direct access to ScriptController by a call to new ScriptElementData::executeScript,
which updates the isEvaluated flag properly.

See also: http://www.whatwg.org/specs/web-apps/current-work/#already-started

Tests: fast/dom/script-clone-rerun-self.html

fast/dom/script-clone-rerun.html
svg/dom/SVGScriptElement/script-clone-rerun-self.svg
svg/dom/SVGScriptElement/script-clone-rerun.svg

dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren): Calls cloneElementWithoutChildren. (WebCore::Element::cloneElementWithoutAttributesAndChildren): Extracted from cloneElementWithoutChildren.
dom/Element.h:
dom/ScriptElement.cpp: (WebCore::ScriptElementData::ScriptElementData): Added isEvaluated flag to the argument list. (WebCore::ScriptElementData::evaluateScript): Extracted from HTMLScriptRunner::executeScript. (WebCore::ScriptElementData::executeScript): Renamed evaluated to isEvaluated. (WebCore::ScriptElementData::ignoresLoadRequest): Renamed evaluated to isEvaluated.
dom/ScriptElement.h: Renamed evaluated to isEvaluated. (WebCore::ScriptElementData::isEvaluated): Added.
dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs): Calls ScriptElement::executeScript.
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::HTMLScriptElement): Added isEvaluated flag to the argument list. (WebCore::HTMLScriptElement::create): Calls the constructor with the isEvaluated flag set to false. (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Propagates isEvaluated. (WebCore::HTMLScriptElement::executeScript): Added; calls ScriptElementData::executeScript.
html/HTMLScriptElement.h:
html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Added an assertion that was lost in extracting ScriptElementData::executeScript. (WebCore::HTMLScriptRunner::runScript): Calls ScriptElementData::executeScript.
html/parser/HTMLScriptRunner.h:
svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement): Added isEvaluated flag to the argument list. (WebCore::SVGScriptElement::create): Calls the constructor with the isEvaluated flag set to false. (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren): Propagates isEvaluated. (WebCore::SVGScriptElement::executeScript): Added; calls ScriptElementData::executeScript.
svg/SVGScriptElement.h:

2010-11-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Script runs more than once after a clone
https://bugs.webkit.org/show_bug.cgi?id=48966

Added tests to ensure WebKit does not evaluate the script of a clone of
a script element that has already been evaluated (has already started).

See also: http://www.whatwg.org/specs/web-apps/current-work/#already-started

fast/dom/script-clone-rerun-expected.txt: Added.
fast/dom/script-clone-rerun-self-expected.txt: Added.
fast/dom/script-clone-rerun-self.html: Added.
fast/dom/script-clone-rerun.html: Added.
svg/dom/SVGScriptElement/script-clone-rerun-expected.txt: Added.
svg/dom/SVGScriptElement/script-clone-rerun-self-expected.txt: Added.
svg/dom/SVGScriptElement/script-clone-rerun-self.svg: Added.
svg/dom/SVGScriptElement/script-clone-rerun.svg: Added.

11:21 PM Changeset in webkit [71894] by commit-queue@webkit.org

3 edits in trunk/WebKitTools

2010-11-11 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Shinichiro Hamaji.

Enable check-webkit-style on Qt files
https://bugs.webkit.org/show_bug.cgi?id=48322

Adding exception for _q_... private slots and
..._data() methods in tests

Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
Scripts/webkitpy/style/checker_unittest.py: improve unittests

11:06 PM Changeset in webkit [71893] by morrita@google.com

2 edits in trunk/WebKit/chromium

2010-11-11 MORITA Hajime <morrita@google.com>

Unreviewed another attempt to fx windows build.

src/WebBindings.cpp: (WebKit::makeStringArrayImpl):

10:51 PM Changeset in webkit [71892] by hamaji@chromium.org

5 edits
1 add in trunk/WebCore

2010-11-11 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

REGRESSION: window.print in onload doesn't fire if there's an img
https://bugs.webkit.org/show_bug.cgi?id=48195

This issue was introduced in
https://bugs.webkit.org/show_bug.cgi?id=43658
This happens because FrameLoader::isLoading() is false while an
image is still loading. Now, window.print() happens after all
resources are loaded.

Also changed the name of a member variable as Darin suggested in Bug 43658.

Added a manual test as DRT doesn't support window.print() yet.

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::updateLoading):
loader/DocumentLoader.h:
page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::print): (WebCore::DOMWindow::finishedLoading):
page/DOMWindow.h:

10:46 PM Changeset in webkit [71891] by morrita@google.com

2 edits in trunk/WebKit/chromium

2010-11-11 MORITA Hajime <morrita@google.com>

Unreviewed attempt to fx windows build.

src/WebBindings.cpp: (WebKit::makeStringArrayImpl):

10:37 PM Changeset in webkit [71890] by levin@chromium.org

3 edits in trunk/WebKitTools

2010-11-11 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style function detection doesn't work for templates and destructors.
https://bugs.webkit.org/show_bug.cgi?id=49425

Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.

10:27 PM Changeset in webkit [71889] by mihaip@chromium.org

6 edits
2 adds in trunk/LayoutTests

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Rebaseline css2.1/t1204-order-01-d.html after r71882 (new Chromium
baselines match the updated mac one)

platform/chromium-linux/css2.1/t1204-order-01-d-expected.checksum:
platform/chromium-linux/css2.1/t1204-order-01-d-expected.png:
platform/chromium-mac/css2.1/t1204-order-01-d-expected.checksum: Added.
platform/chromium-mac/css2.1/t1204-order-01-d-expected.png: Added.
platform/chromium-win/css2.1/t1204-order-01-d-expected.checksum:
platform/chromium-win/css2.1/t1204-order-01-d-expected.png:
platform/chromium-win/css2.1/t1204-order-01-d-expected.txt:

10:20 PM Changeset in webkit [71888] by commit-queue@webkit.org

7 edits in trunk

2010-11-11 Joone Hur <joone@kldp.org>

Reviewed by Antonio Gomes.

[GTK][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46598

Unskip fast/dom/nodesFromRect-basic.html on Gtk+.

platform/gtk/Skipped:

2010-11-11 Joone Hur <joone@kldp.org>

Reviewed by Antonio Gomes.

[GTK][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46598

Support nodesFromRect in DRT

WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::nodesFromRect): Added.
WebCoreSupport/DumpRenderTreeSupportGtk.h:

2010-11-11 Joone Hur <joone@kldp.org>

Reviewed by Antonio Gomes.

[GTK][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46598

Support nodesFromRect in DRT

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::nodesFromRect):

10:04 PM Changeset in webkit [71887] by commit-queue@webkit.org

6 edits in trunk

2010-11-11 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[chromium] Support letter spacing and fix whitespace wrapping on linux

When lines wrapped on RTL text, the whitespace was inserted before
the first character on the new line instead of at the end of the
previous line. This has been fixed.

The missing cluster information needed for letter spacing was hidden in
harfbuzz's attributes struct.

https://bugs.webkit.org/show_bug.cgi?id=49405

platform/chromium-linux/fast/text/atsui-spacing-features-expected.checksum: Rebaselined.
platform/chromium-linux/fast/text/atsui-spacing-features-expected.png: Ditto.
platform/chromium-linux/fast/text/atsui-spacing-features-expected.txt: Ditto.

2010-11-11 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[chromium] Support letter spacing and fix whitespace wrapping on linux

When lines wrapped on RTL text, the whitespace was inserted before
the first character on the new line instead of at the end of the
previous line. This has been fixed.

The missing cluster information needed for letter spacing was hidden in
harfbuzz's attributes struct.

https://bugs.webkit.org/show_bug.cgi?id=49405

platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::letterSpacing): Added. (WebCore::TextRunWalker::isWordBreak): No need for isRTL. (WebCore::TextRunWalker::setPadding): Ditto. (WebCore::TextRunWalker::setGlyphXPositions): Support letter spacing. No whitespace before RTL text on new line. (WebCore::glyphIndexForXPositionInScriptRun): Support letter spacing.

10:02 PM Changeset in webkit [71886] by morrita@google.com

9 edits in trunk

2010-11-11 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

editing/selection/context-menu-on-text.html fails on chromium
https://bugs.webkit.org/show_bug.cgi?id=45898

platform/chromium/test_expectations.txt: Unskipped context-menu-on-text.html

2010-11-11 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

editing/selection/context-menu-on-text.html fails on chromium
https://bugs.webkit.org/show_bug.cgi?id=45898

Added makeStringArray(), that is used by DumpRenderTree.

public/WebBindings.h:
src/WebBindings.cpp: (WebKit::makeStringArrayImpl): Added. (WebKit::WebBindings::makeStringArray): Added.

2010-11-11 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

editing/selection/context-menu-on-text.html fails on chromium
https://bugs.webkit.org/show_bug.cgi?id=45898

Enhance Chromium's EventSender::contextClick() to return
array of menu strings. The implementation incomplete because
Although actual context menu is implemented by the browser,
it reflects editability of underlying context thus makes
context-menu-on-text.html passed.

DumpRenderTree/chromium/EventSender.cpp: (makeMenuItemStringsFor): Added. (EventSender::contextClick): Now returns array of menu strings.
DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::showContextMenu): Now storing given WebContextMenuData object. (WebViewHost::clearContextMenuData): Added. (WebViewHost::lastContextMenuData): Added.
DumpRenderTree/chromium/WebViewHost.h:

9:38 PM Changeset in webkit [71885] by commit-queue@webkit.org

3 edits in trunk/WebCore

2010-11-11 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Dumitru Daniliuc.

FileSystem: Fix a link error for non-chromium WebKit build
https://bugs.webkit.org/show_bug.cgi?id=49296

WebCore.xcodeproj/project.pbxproj:
inspector/InspectorFileSystemAgent.cpp: (WebCore::InspectorFileSystemAgentCallbacks::didOpenFileSystem): (WebCore::InspectorFileSystemAgentCallbacks::didReadDirectoryEntry): (WebCore::InspectorFileSystemAgentCallbacks::didReadDirectoryEntries): (WebCore::InspectorFileSystemAgentCallbacks::didCreateFileWriter): (WebCore::InspectorFileSystemAgentCallbacks::didFail): (WebCore::InspectorFileSystemAgent::revealFolderInOS):

9:17 PM Changeset in webkit [71884] by Nate Chapin

11 edits in trunk

2010-11-11 Nate Chapin <Nate Chapin>

Reviewed by Antti Koivisto.

Test update for https://bugs.webkit.org/show_bug.cgi?id=49351,
the timing of willSendRequest() calls will be slightly different.

platform/mac/security/block-test-expected.txt:

2010-11-11 Nate Chapin <Nate Chapin>

Reviewed by Antti Koivisto.

Cleanup after http://trac.webkit.org/changeset/71562, namely:
Make deferred request handle simpler.
Don't perform callbacks associated with network load starting
(e.g., willSendRequest) until the load is in fact sent to the network.
Make ResourceLoadScheduler a friend of ResourceLoader and make
ResourceLoader::start() protected to try to ensure loads actually
go through the scheduler.
https://bugs.webkit.org/show_bug.cgi?id=49351

Behavior should be covered by existing tests.

loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::create):
loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::servePendingRequests):
loader/ResourceLoadScheduler.h: (WebCore::ResourceLoadScheduler::HostInformation::limitRequests):
loader/ResourceLoader.cpp: (WebCore::ResourceLoader::init): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::didCancel):
loader/ResourceLoader.h: (WebCore::ResourceLoader::reachedTerminalState): (WebCore::ResourceLoader::request):
loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::willSendRequest):
loader/loader.h:

8:55 PM Changeset in webkit [71883] by tonyg@chromium.org

2 edits in trunk/WebKit/chromium

2010-11-11 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Nate Chapin.

[chromium] Convert WebPerformance doubles to seconds
https://bugs.webkit.org/show_bug.cgi?id=49232

This makes them suitable for passing to Time::FromDoubleT().

src/WebPerformance.cpp: (WebKit::millisecondsToSeconds): (WebKit::WebPerformance::navigationStart): (WebKit::WebPerformance::unloadEventEnd): (WebKit::WebPerformance::redirectStart): (WebKit::WebPerformance::redirectEnd): (WebKit::WebPerformance::fetchStart): (WebKit::WebPerformance::domainLookupStart): (WebKit::WebPerformance::domainLookupEnd): (WebKit::WebPerformance::connectStart): (WebKit::WebPerformance::connectEnd): (WebKit::WebPerformance::requestStart): (WebKit::WebPerformance::requestEnd): (WebKit::WebPerformance::responseStart): (WebKit::WebPerformance::responseEnd): (WebKit::WebPerformance::loadEventStart): (WebKit::WebPerformance::loadEventEnd):

8:35 PM Changeset in webkit [71882] by carol.szabo@nokia.com

6 edits
5 adds in trunk

2010-11-11 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Kent Tamura.

css2:order of counters in out-of flow content
https://bugs.webkit.org/show_bug.cgi?id=32412

fast/css/content: Added.
fast/css/content/content-none-expected.txt: Added.
fast/css/content/content-none.html: Added.
fast/css/content/content-normal-expected.txt: Added.
fast/css/content/content-normal.html: Added. Added to provide portable tests for the "content" CSS property.
platform/mac/css2.1/t1204-order-01-d-expected.checksum:
platform/mac/css2.1/t1204-order-01-d-expected.png:
platform/mac/css2.1/t1204-order-01-d-expected.txt: Changed because the existing content was bad, but matching the existing bug that this patch fixes.

2010-11-11 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Kent Tamura.

css2:order of counters in out-of flow content
https://bugs.webkit.org/show_bug.cgi?id=32412

Tests: fast/css/content/content-none.html

fast/css/content/content-normal.html

css/CSSParser.cpp: (WebCore::CSSParser::parseContent): Added support for none, normal, open-quote, no-open-quote, etc. identifiers in terms of parsing only, as this has effect on the evaluation of counters. No further implementation needed for none and normal, the others are parsed but do not work as expected.

8:16 PM Changeset in webkit [71881] by chang.shu@nokia.com

4 edits in trunk

2010-11-11 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

[GTK] Unskip tests that are passing now.
fast/events/spatial-navigation/snav-input.html
fast/events/spatial-navigation/snav-textarea.html
https://bugs.webkit.org/show_bug.cgi?id=49056

platform/gtk/Skipped:

2010-11-11 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

[GTK] Replace "MoveForward"/"MoveBackward" with "MoveRight"/"MoveLeft"
to make spatial navigation work on input/textarea.
https://bugs.webkit.org/show_bug.cgi?id=49056

WebCoreSupport/EditorClientGtk.cpp: (WebKit::moveCursorCallback):

7:56 PM Changeset in webkit [71880] by commit-queue@webkit.org

5 edits
2 adds in trunk

2010-11-11 Julie-Jeongeun-Kim <jiyuluna@gmail.com>

Reviewed by Kent Tamura.

SelectionStart, selectionEnd properties return wrong values when the selection is in a read-only input or textarea element
https://bugs.webkit.org/show_bug.cgi?id=25444

fast/forms/selection-start-end-readonly-expected.txt: Added.
fast/forms/selection-start-end-readonly.html: Added.

2010-11-11 Julie-Jeongeun-Kim <jiyuluna@gmail.com>

Reviewed by Kent Tamura.

SelectionStart, selectionEnd properties return wrong values when the selection is in a read-only input or textarea element
https://bugs.webkit.org/show_bug.cgi?id=25444

'rootEditableElement()' is checked on RenderTextControl::indexForVisiblePosition.
It means that just editable elements can get selection information.
ReadOnly element is not editable element. So, it just returns and can't get correct selection information.
INPUT and TEXTAREA elements can be read-only but 'indexForVisiblePosition' doesn't accept them.
So, Selectable elements, INPUT and TEXTAREA, checking is added for that case.
Even if they are read-only, they are selectable.

new tests:fast/forms/selection-start-end-readonly.html

html/HTMLInputElement.idl:
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::isSelectableElement): (WebCore::RenderTextControl::indexForVisiblePosition):
rendering/RenderTextControl.h:

7:07 PM Changeset in webkit [71879] by abarth@webkit.org

2 edits in trunk/WebCore

2010-11-11 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Add some RefPtrs to be on the safe side
https://bugs.webkit.org/show_bug.cgi?id=49301

Hopefully no behavior change.

html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):

7:06 PM Changeset in webkit [71878] by barraclough@apple.com

15 edits in trunk/JavaScriptCore

Bug 49420 - Clean up syntax/reference error throw.

Reviewed by Oliver Hunt.

Some errors detected at compile time are thrown at runtime. We currently do so using a op_new_error/op_throw bytecode pair.
This is not ideal. op_throw is used for explicit user throw statements, and has different requirements in terms or meta data
attached to the exception (controlled by the explicitThrow parameter passed to Interpreter::throwException). To work around
this, op_new_error has to add the meta data at an early stage, which is unlike other VM exceptions being raised.

We can simplify this and bring into line with other exception behaviour by changing new_error from just allocating an
Exception instance to also throwing it – but as a regular VM throw, correctly passing explicitThrow as false.

JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):

bytecode/Opcode.h:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitThrowSyntaxError):
(JSC::BytecodeGenerator::emitThrowExpressionTooDeepException):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNodeInConditionContext):

bytecompiler/NodesCodegen.cpp:

(JSC::ThrowableExpressionData::emitThrowReferenceError):
(JSC::ThrowableExpressionData::emitThrowSyntaxError):
(JSC::RegExpNode::emitBytecode):
(JSC::PostfixErrorNode::emitBytecode):
(JSC::PrefixErrorNode::emitBytecode):
(JSC::AssignErrorNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::LabelNode::emitBytecode):

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

jit/JIT.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_throw_reference_error):
(JSC::JIT::emit_op_throw_syntax_error):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_throw_reference_error):
(JSC::JIT::emit_op_throw_syntax_error):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

jit/JITStubs.h:
parser/Nodes.h:

6:49 PM Changeset in webkit [71877] by crogers@google.com

2 edits in trunk/WebCore

2010-11-11 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Fix Accelerate.framework issues in VectorMath 32-bit ppc & i386 vs. other architectures (64-bit, ARM, etc.).
On the Mac we use the highly optimized versions in Accelerate.framework
In 32-bit mode (ppc or i386) <Accelerate/Accelerate.h> includes <vecLib/vDSP_translate.h> which defines macros
of the same name as our namespaced function names, so we must handle this case differently.
Other architectures (64bit, ARM, etc.) do not include this header file.

https://bugs.webkit.org/show_bug.cgi?id=49112

No new tests since audio API is not yet implemented.

platform/audio/VectorMath.cpp: (WebCore::VectorMath::vsmul): (WebCore::VectorMath::vadd):

6:30 PM Changeset in webkit [71876] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.txt

Fix layout test since it progressed.

6:28 PM Changeset in webkit [71875] by mihaip@chromium.org

1 edit
2 adds in trunk/LayoutTests

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Missed a chromium-mac baseline in r71869 (for r71851).

platform/chromium-mac/fast/repaint/box-shadow-h-expected.checksum: Added.
platform/chromium-mac/fast/repaint/box-shadow-h-expected.png: Added.

6:20 PM Changeset in webkit [71874] by mihaip@chromium.org

1 edit
1 add in trunk/LayoutTests

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Restore baseline that r71870 deleted, Chromium Windows and Linux still
have the old behavior.

platform/chromium-win/fast/text/justification-padding-mid-word-expected.txt: Added.

5:48 PM Changeset in webkit [71873] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-11-11 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

fix build breakage caused by fix for bug 49380 (r71858).

config_standalone needs to ensure that the packages it needs are
in sys.path.

https://bugs.webkit.org/show_bug.cgi?id=49419

Scripts/webkitpy/layout_tests/port/config_standalone.py:

5:33 PM Changeset in webkit [71872] by andersca@apple.com

11 edits in trunk/WebKit2

Add didReceiveResponse and didReceiveData to the download client
https://bugs.webkit.org/show_bug.cgi?id=49418

Reviewed by Darin Adler.

UIProcess/API/C/WKContext.h:

Add didReceiveResponse and didReceiveData to WKContextDownloadClient.

UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didReceiveResponse):
(WebKit::DownloadProxy::didReceiveData):
Call WebDownloadClient member functions.

UIProcess/Downloads/DownloadProxy.messages.in:

Add DidReceiveResponse and DidReceiveData messages.

UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::didReceiveResponse):
(WebKit::WebDownloadClient::didReceiveData):
Call client functions.

WebKit2.xcodeproj/project.pbxproj:

Let Xcode update the file.

WebProcess/Downloads/Download.cpp:

(WebKit::Download::didReceiveResponse):
(WebKit::Download::didReceiveData):
Send messages.

WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::start):
Set deletesFileUponFailure to NO.

(-[WKDownloadAsDelegate download:didReceiveResponse:]):
Call didReceiveResponse.

5:25 PM Changeset in webkit [71871] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed, fix bug number.

platform/chromium/test_expectations.txt:

5:21 PM Changeset in webkit [71870] by mitz@apple.com

3 edits
1 delete in trunk

<rdar://problem/8657116> fast/text/justification-padding-mid-word.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=49378

Reviewed by Darin Adler.

WebCore:

platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem): For all characters that need to be treated
as zero-width spaces, substitute the space glyph with zero advance. Apply justification padding
and word spacing only at characters treated as (non-zero-width) spaces.

LayoutTests:

platform/win/fast/text/justification-padding-mid-word-expected.txt: Removed Windows-specific

expected failure.

5:20 PM Changeset in webkit [71869] by mihaip@chromium.org

8 edits
38 adds in trunk/LayoutTests

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Update fast/repaint baselines after r71851. Add expected failure
for fast/table/colspanMinWidth-vertical.html, which needs rebaselining
upstream for the mac port too.

platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.checksum: Added.
platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Added.
platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
platform/chromium-linux/fast/repaint/selection-rl-expected.checksum:
platform/chromium-linux/fast/repaint/selection-rl-expected.png:
platform/chromium-mac/fast/repaint/box-shadow-v-expected.checksum: Added.
platform/chromium-mac/fast/repaint/box-shadow-v-expected.png: Added.
platform/chromium-mac/fast/repaint/flexible-box-overflow-expected.checksum: Added.
platform/chromium-mac/fast/repaint/flexible-box-overflow-expected.png: Added.
platform/chromium-mac/fast/repaint/flexible-box-overflow-horizontal-expected.checksum: Added.
platform/chromium-mac/fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
platform/chromium-mac/fast/repaint/focus-layers-expected.checksum: Added.
platform/chromium-mac/fast/repaint/focus-layers-expected.png: Added.
platform/chromium-mac/fast/repaint/inline-block-overflow-expected.checksum: Added.
platform/chromium-mac/fast/repaint/inline-block-overflow-expected.png: Added.
platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.checksum: Added.
platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Added.
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
platform/chromium-mac/fast/repaint/layer-child-outline-expected.checksum: Added.
platform/chromium-mac/fast/repaint/layer-child-outline-expected.png: Added.
platform/chromium-mac/fast/repaint/layer-outline-expected.checksum: Added.
platform/chromium-mac/fast/repaint/layer-outline-expected.png: Added.
platform/chromium-mac/fast/repaint/layer-outline-horizontal-expected.checksum: Added.
platform/chromium-mac/fast/repaint/layer-outline-horizontal-expected.png: Added.
platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Added.
platform/chromium-mac/fast/repaint/list-marker-expected.png: Added.
platform/chromium-mac/fast/repaint/selection-rl-expected.checksum:
platform/chromium-mac/fast/repaint/selection-rl-expected.png:
platform/chromium-mac/fast/repaint/text-shadow-expected.checksum: Added.
platform/chromium-mac/fast/repaint/text-shadow-expected.png: Added.
platform/chromium-mac/fast/repaint/text-shadow-horizontal-expected.checksum: Added.
platform/chromium-mac/fast/repaint/text-shadow-horizontal-expected.png: Added.
platform/chromium-win/fast/repaint/japanese-rl-selection-clear-expected.checksum: Added.
platform/chromium-win/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
platform/chromium-win/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Added.
platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
platform/chromium-win/fast/repaint/selection-rl-expected.checksum:
platform/chromium-win/fast/repaint/selection-rl-expected.png:
platform/chromium/test_expectations.txt:

5:03 PM Changeset in webkit [71868] by andersca@apple.com

6 edits in trunk/WebKit2

Add an argument coder for ResourceResponse.
https://bugs.webkit.org/show_bug.cgi?id=49415

Reviewed by Sam Weinig.

Shared/WebCoreArgumentCoders.h:
Shared/gtk/WebCoreArgumentCodersGtk.cpp:

(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

5:01 PM Changeset in webkit [71867] by Darin Adler

4 edits in trunk

2010-11-11 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Harden some string functions against large lengths
https://bugs.webkit.org/show_bug.cgi?id=49293

wtf/text/StringImpl.cpp: (WTF::StringImpl::create): Fix incorrect use of PassRefPtr. Check for strlen results that are too large for StringImpl. (WTF::StringImpl::lower): Check for lengths that are too large for int32_t. (WTF::StringImpl::upper): Fix incorrect use of PassRefPtr. Check for lengths that are too large for int32_t. (WTF::StringImpl::secure): Fix incorect use of PassRefPtr. Use unsigned rather than int and int32_t so we can handle any length. (WTF::StringImpl::foldCase): Fix incorrect use of PassRefPtr. Check for lengths that are too large for int32_t. (WTF::StringImpl::find): Check for strlen results that are too large for StringImpl. (WTF::StringImpl::findIgnoringCase): Ditto. (WTF::StringImpl::replace): Fix incorrect use of PassRefPtr. (WTF::StringImpl::createWithTerminatingNullCharacter): Check before incrementing length.

2010-11-11 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Harden some string functions against large lengths
https://bugs.webkit.org/show_bug.cgi?id=49293

rendering/RenderText.cpp: (WebCore::makeCapitalized): Check before incrementing length.

4:50 PM Changeset in webkit [71866] by rniwa@webkit.org

2 edits in trunk/WebKit2

2010-11-11 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed build fix for r71587.

WebKit2.xcodeproj/project.pbxproj: No longer uses absolute path.

4:33 PM Changeset in webkit [71865] by Csaba Osztrogonác

3 edits in trunk/WebKit2

[Qt] Unreviewed WebKit2 buildfix after r71587.

UIProcess/qt/WebInspectorProxyQt.cpp:
WebKit2.pro:

4:28 PM Changeset in webkit [71864] by bweinstein@apple.com

3 edits in trunk/WebKit2

More Windows build fixing. Change another #import to a #include, and remove an unneeded
namespace.

UIProcess/win/WebInspectorProxyWin.cpp:
WebProcess/WebPage/win/WebInspectorWin.cpp:

4:19 PM Changeset in webkit [71863] by bfulgham@webkit.org

2 edits in trunk/WebKit2

Windows [Cairo] build fix. Unreviewed.

Provide stubs for two BackingStore methods.

Shared/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::createFlippedGraphicsContext):
(WebKit::BackingStore::paint):

4:17 PM Changeset in webkit [71862] by bweinstein@apple.com

2 edits in trunk/WebKit2

Windows Build Fix. Change #imports to #includes.

UIProcess/win/WebInspectorProxyWin.cpp:

4:02 PM Changeset in webkit [71861] by zmo@google.com

5 edits in trunk

2010-11-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

bufferData/bufferSubData should not crash with null data input
https://bugs.webkit.org/show_bug.cgi?id=49350

html/canvas/WebGLRenderingContext.cpp: return early if input data is null. (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData):

2010-11-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

bufferData/bufferSubData should not crash with null data input
https://bugs.webkit.org/show_bug.cgi?id=49350

fast/canvas/webgl/buffer-data-array-buffer-expected.txt:
fast/canvas/webgl/buffer-data-array-buffer.html: test the null data input cases.

3:55 PM Changeset in webkit [71860] by zmo@google.com

2 edits in trunk/LayoutTests

2010-11-11 Zhenyao Mo <zmo@google.com>

Unreviewed, build fix, update test results.

fast/canvas/webgl/texture-transparent-pixels-initialized-expected.txt:

3:52 PM Changeset in webkit [71859] by jhoneycutt@apple.com

2 edits in trunk/LayoutTests

Add a flaky test to the Windows skipped list.

platform/win/Skipped:

3:51 PM Changeset in webkit [71858] by dpranke@chromium.org

3 edits
1 add in trunk/WebKitTools

2010-11-11 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Roben.

Fix NRWT to respect set-webkit-configuration again :(

This change fixes a typo in config.py that was causing the wrong
value to be read initially and us never actually looking into
the filesystem to get the default configuration.

Scripts/webkitpy/layout_tests/port/config.py:
Scripts/webkitpy/layout_tests/port/config_standalone.py:
Scripts/webkitpy/layout_tests/port/config_unittest.py:

3:43 PM Changeset in webkit [71857] by timothy@apple.com

16 edits
6 copies
1 add in trunk/WebKit2

Create and load the Web Inspector page.

https://webkit.org/b/49207

Reviewed by Anders Carlsson.

UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage): Added. Call platformCreateInspectorPage and then
call WebPageProxy::loadURL with inspectorPageURL.
(WebKit::WebInspectorProxy::didLoadInspectorPage): Added stub.

UIProcess/WebInspectorProxy.h:
UIProcess/WebInspectorProxy.messages.in: Added.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage): Call WebInspectorProxy::didReceiveWebInspectorProxyMessage.
(WebKit::WebPageProxy::didReceiveSyncMessage): Call WebInspectorProxy::didReceiveSyncWebInspectorProxyMessage.

UIProcess/WebPageProxy.h: Made creationParameters public so WebInspectorProxy can use it.

UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Make a WkView and return the WebPageProxy.
(WebKit::WebInspectorProxy::inspectorPageURL): Return the file URL for the inspector.html file.

UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Added stub.
(WebKit::WebInspectorProxy::inspectorPageURL): Ditto.

UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Added stub.
(WebKit::WebInspectorProxy::inspectorPageURL): Ditto.

WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend): Call WebInspector::createInspectorPage and set up the WebInspectorFrontendClient.
(WebKit::WebInspectorClient::sendMessageToFrontend): Call doDispatchMessageOnFrontendPage in the base class.

WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::frontendLoaded): Call WebInspector::didLoadInspectorPage.
(WebKit::WebInspectorFrontendClient::localizedStringsURL): Call WebInspector::localizedStringsURL.

WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:

WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::WebInspector):
(WebKit::WebInspector::createInspectorPage): Send a sync WebInspectorProxy::CreateInspectorPage message and set up
the WebPage using the result page ID.
(WebKit::WebInspector::didLoadInspectorPage): Send a WebInspectorProxy::DidLoadInspectorPage message.

WebProcess/WebPage/WebInspector.h:

(WebKit::WebInspector::inspectorPage): Added.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage): Call WebInspector::didReceiveWebInspectorMessage.

WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::WebInspector::localizedStringsURL): Return the file URL for the localizedStrings.js file.

WebProcess/WebPage/qt/WebInspectorQt.cpp:

(WebKit::WebInspector::localizedStringsURL): Added stub.

WebProcess/WebPage/win/WebInspectorWin.cpp:

(WebKit::WebInspector::localizedStringsURL): Added stub.

DerivedSources.make: Added WebInspectorProxy.messages.in.
DerivedSources.pro: Ditto.

WebKit2.pro: Added new files.
WebKit2.xcodeproj/project.pbxproj: Ditto.
win/WebKit2.vcproj: Ditto.

3:26 PM Changeset in webkit [71856] by eric@webkit.org

6 edits
5 adds in trunk/WebKitTools

2010-11-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split out Bug, Attachment and CommitterValidator from bugzilla.py
https://bugs.webkit.org/show_bug.cgi?id=49403

CommitterValidator really had nothing to do with bugzilla.py.
I've put it next to committers.py for now since its rather tied to that file.

Scripts/webkitpy/common/config/committervalidator.py: Added.
Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
Scripts/webkitpy/common/net/bugzilla/init.py:
Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
Scripts/webkitpy/tool/bot/feeders.py:
Scripts/webkitpy/tool/commands/queues.py:

3:04 PM Changeset in webkit [71855] by zmo@google.com

12 edits
2 adds in trunk

2010-11-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

This is the first patch for this bug. We add constants and methods, but haven't hooked it up with texture uploading yet. Also, in order to check in constants.html, we need to remove out-dated constants, and update affected tests correspondingly.

Test: fast/canvas/webgl/constants.html

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Move init code to initializeNewContext. (WebCore::WebGLRenderingContext::initializeNewContext): Ditto. (WebCore::WebGLRenderingContext::getParameter): Implement UNPACK_COLORSPACE_CONVERSION_WEBGL. (WebCore::WebGLRenderingContext::pixelStorei): Ditto.
html/canvas/WebGLRenderingContext.h: Add a member to track UNPACK_COLORSPACE_CONVERSION_WEBGL setting.
html/canvas/WebGLRenderingContext.idl: Update constants.
platform/graphics/GraphicsContext3D.h: Update constants.

2010-11-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

This is the first patch for this bug. We add constants and methods, but haven't hooked it up with texture uploading yet. Also, in order to check in constants.html, we need to remove out-dated constants, and update affected tests correspondingly.

fast/canvas/webgl/constants-expected.txt: Added.
fast/canvas/webgl/constants.html: Added.
fast/canvas/webgl/copy-tex-image-and-sub-image-2d-expected.txt:
fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html: Update due to removal of TRUE/FALSE.
fast/canvas/webgl/texture-transparent-pixels-initialized-expected.txt:
fast/canvas/webgl/texture-transparent-pixels-initialized.html: Ditto.
fast/canvas/webgl/webgl-specific-expected.txt:
fast/canvas/webgl/webgl-specific.html: Add test cases for UNPACK_COLORSPACE_CONVERSION_WEBGL.

2:52 PM Changeset in webkit [71854] by dpranke@chromium.org

2 edits in trunk/WebKitTools

2010-11-11 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

fix missing 'pid' argument for http lockfile checking on win32
https://bugs.webkit.org/show_bug.cgi?id=49363

Scripts/webkitpy/common/system/executive.py:

2:43 PM Changeset in webkit [71853] by cmarrin@apple.com

10 edits in trunk/WebCore

2010-11-11 Chris Marrin <cmarrin@apple.com>

Reviewed by James Robinson.

Add multisampling support to DrawingBuffer.
https://bugs.webkit.org/show_bug.cgi?id=49206

Added support for the GL_ANGLE_framebuffer_blit and GL_ANGLE_framebuffer_multisample
extensions to Extensions3D. Then I use these to add multisample support to DrawingBuffer.

This re-lands changes rolled out by http://trac.webkit.org/changeset/71839. It includes
the change from http://trac.webkit.org/changeset/71831 and additional changes to
DrawingBufferChromium.cpp which cause the broken canvas tests to pass.

platform/graphics/Extensions3D.h:
platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::publishToPlatformLayer): (WebCore::DrawingBuffer::didReset): (WebCore::DrawingBuffer::platformColorBuffer):
platform/graphics/chromium/Extensions3DChromium.h: (WebCore::Extensions3DChromium::blitFramebuffer): (WebCore::Extensions3DChromium::renderbufferStorageMultisample):
platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::create): (WebCore::DrawingBuffer::clear): (WebCore::DrawingBuffer::reset): (WebCore::DrawingBuffer::commit): (WebCore::DrawingBuffer::bind):
platform/graphics/gpu/DrawingBuffer.h: (WebCore::DrawingBuffer::multisample):
platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::didReset): (WebCore::DrawingBuffer::platformColorBuffer):
platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::supports): (WebCore::Extensions3DOpenGL::blitFramebuffer): (WebCore::Extensions3DOpenGL::renderbufferStorageMultisample):
platform/graphics/opengl/Extensions3DOpenGL.h:
platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::draw):

2:32 PM Changeset in webkit [71852] by mihaip@chromium.org

3 edits in trunk/LayoutTests

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectation update:

fast/selectors/001.html is flaky under release too
svg/animations/animate-text-nested-transforms.html is flaky

DRT:

Add more crashy/flaky media tests
Add flaky SVG tests
fast/selectors/001.html is flaky for all platforms

platform/chromium/drt_expectations.txt:
platform/chromium/test_expectations.txt:

2:17 PM Changeset in webkit [71851] by hyatt@apple.com

228 edits
8 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=48664

Reviewed by Simon Fraser.

Make repaint invalidation work with flipped blocks ("rl" and "bt" writing modes).

This patch disables the layout state for flipped blocks, since the paint offset isn't right.

Bugs in the overflow sides for lines have been fixed. before/AfterSideVisible/LayoutOverflowForLine
now respect flipping (and don't incorrectly change sides). This is a very confusing aspect of
the overflow stuff (and at some point we should consider renaming top/left/right/bottom since they
aren't physical).

offsetFromContainer and mapLocalToContainer remain physical and refer to the top left offset.
This means at every step up you convert to the correct physical coordinate. It also means these
functions will be unreliable during layout for flipped blocks. At first glance, this seems to be
more or less ok.

computeRectForRepaint now delays flipping conversions until you cross a writing-mode boundary. This
allows for documents to be fully flipped and repaint during layout can still be reliable. This is
critical for incremental line layout repainting.

Added new tests in fast/repaint and also rebaselined the tests in that directory because I'm tired
of all the stale results and failures.

WebCore:

editing/SelectionController.cpp:

(WebCore::SelectionController::absoluteBoundsForLocalRect):
(WebCore::SelectionController::paintCaret):

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutOnlyPositionedObjects):
(WebCore::RenderBlock::paintSelection):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::beforeSideVisibleOverflowForLine):
(WebCore::RenderBlock::afterSideVisibleOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):

rendering/RenderBox.cpp:

(WebCore::RenderBox::layout):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::flipForWritingMode):
(WebCore::RenderBox::locationOffsetIncludingFlipping):

rendering/RenderBox.h:
rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):

rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):

rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::layoutRows):

rendering/RenderView.cpp:

(WebCore::RenderView::computeRectForRepaint):

rendering/ShadowElement.cpp:

(WebCore::ShadowBlockElement::layoutAsPart):

LayoutTests:

fast/repaint/japanese-rl-selection-clear.html: Added.
fast/repaint/japanese-rl-selection-repaint.html: Added.
fast/repaint/repaint-svg-after-style-change-expected.png:
platform/mac/fast/repaint/4774354-expected.checksum:
platform/mac/fast/repaint/4774354-expected.png:
platform/mac/fast/repaint/4776765-expected.checksum:
platform/mac/fast/repaint/4776765-expected.png:
platform/mac/fast/repaint/background-generated-expected.checksum:
platform/mac/fast/repaint/background-generated-expected.png:
platform/mac/fast/repaint/background-misaligned-expected.png:
platform/mac/fast/repaint/backgroundSizeRepaint-expected.checksum:
platform/mac/fast/repaint/backgroundSizeRepaint-expected.png:
platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
platform/mac/fast/repaint/block-no-inflow-children-expected.checksum:
platform/mac/fast/repaint/block-no-inflow-children-expected.png:
platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.checksum:
platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
platform/mac/fast/repaint/border-fit-lines-expected.checksum:
platform/mac/fast/repaint/border-fit-lines-expected.png:
platform/mac/fast/repaint/border-radius-repaint-expected.checksum:
platform/mac/fast/repaint/border-radius-repaint-expected.png:
platform/mac/fast/repaint/border-repaint-glitch-expected.checksum:
platform/mac/fast/repaint/border-repaint-glitch-expected.png:
platform/mac/fast/repaint/box-shadow-dynamic-expected.checksum:
platform/mac/fast/repaint/box-shadow-dynamic-expected.png:
platform/mac/fast/repaint/box-shadow-h-expected.checksum:
platform/mac/fast/repaint/box-shadow-h-expected.png:
platform/mac/fast/repaint/box-shadow-v-expected.checksum:
platform/mac/fast/repaint/box-shadow-v-expected.png:
platform/mac/fast/repaint/bugzilla-3509-expected.checksum:
platform/mac/fast/repaint/bugzilla-3509-expected.png:
platform/mac/fast/repaint/bugzilla-5699-expected.checksum:
platform/mac/fast/repaint/bugzilla-5699-expected.png:
platform/mac/fast/repaint/bugzilla-6278-expected.checksum:
platform/mac/fast/repaint/bugzilla-6278-expected.png:
platform/mac/fast/repaint/bugzilla-6388-expected.checksum:
platform/mac/fast/repaint/bugzilla-6388-expected.png:
platform/mac/fast/repaint/bugzilla-6473-expected.checksum:
platform/mac/fast/repaint/bugzilla-6473-expected.png:
platform/mac/fast/repaint/bugzilla-7235-expected.checksum:
platform/mac/fast/repaint/bugzilla-7235-expected.png:
platform/mac/fast/repaint/button-spurious-layout-hint-expected.png:
platform/mac/fast/repaint/caret-outside-block-expected.checksum:
platform/mac/fast/repaint/caret-outside-block-expected.png:
platform/mac/fast/repaint/change-transform-expected.checksum:
platform/mac/fast/repaint/change-transform-expected.png:
platform/mac/fast/repaint/clip-with-layout-delta-expected.png:
platform/mac/fast/repaint/clipped-relative-expected.checksum:
platform/mac/fast/repaint/clipped-relative-expected.png:
platform/mac/fast/repaint/containing-block-position-change-expected.checksum:
platform/mac/fast/repaint/containing-block-position-change-expected.png:
platform/mac/fast/repaint/content-into-overflow-expected.png:
platform/mac/fast/repaint/continuation-after-outline-expected.checksum:
platform/mac/fast/repaint/continuation-after-outline-expected.png:
platform/mac/fast/repaint/control-clip-expected.checksum:
platform/mac/fast/repaint/control-clip-expected.png:
platform/mac/fast/repaint/create-layer-repaint-expected.checksum:
platform/mac/fast/repaint/create-layer-repaint-expected.png:
platform/mac/fast/repaint/delete-into-nested-block-expected.checksum:
platform/mac/fast/repaint/delete-into-nested-block-expected.png:
platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.checksum:
platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
platform/mac/fast/repaint/erase-overflow-expected.png:
platform/mac/fast/repaint/fixed-expected.checksum:
platform/mac/fast/repaint/fixed-expected.png:
platform/mac/fast/repaint/flexible-box-overflow-expected.checksum:
platform/mac/fast/repaint/flexible-box-overflow-expected.png:
platform/mac/fast/repaint/flexible-box-overflow-horizontal-expected.checksum:
platform/mac/fast/repaint/flexible-box-overflow-horizontal-expected.png:
platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
platform/mac/fast/repaint/float-move-during-layout-expected.checksum:
platform/mac/fast/repaint/float-move-during-layout-expected.png:
platform/mac/fast/repaint/float-new-in-block-expected.png:
platform/mac/fast/repaint/float-overflow-expected.png:
platform/mac/fast/repaint/float-overflow-right-expected.png:
platform/mac/fast/repaint/focus-layers-expected.checksum:
platform/mac/fast/repaint/focus-layers-expected.png:
platform/mac/fast/repaint/focus-ring-expected.png:
platform/mac/fast/repaint/inline-block-overflow-expected.checksum:
platform/mac/fast/repaint/inline-block-overflow-expected.png:
platform/mac/fast/repaint/inline-block-resize-expected.png:
platform/mac/fast/repaint/inline-color-change-expected.checksum:
platform/mac/fast/repaint/inline-color-change-expected.png:
platform/mac/fast/repaint/inline-outline-repaint-expected.checksum:
platform/mac/fast/repaint/inline-outline-repaint-expected.png:
platform/mac/fast/repaint/intermediate-layout-position-clip-expected.png:
platform/mac/fast/repaint/intermediate-layout-position-expected.png:
platform/mac/fast/repaint/invisible-objects-expected.png:
platform/mac/fast/repaint/japanese-rl-selection-clear-expected.checksum: Added.
platform/mac/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
platform/mac/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Added.
platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
platform/mac/fast/repaint/layer-child-outline-expected.checksum:
platform/mac/fast/repaint/layer-child-outline-expected.png:
platform/mac/fast/repaint/layer-full-repaint-expected.png:
platform/mac/fast/repaint/layer-hide-when-needs-layout-expected.png:
platform/mac/fast/repaint/layer-outline-expected.checksum:
platform/mac/fast/repaint/layer-outline-expected.png:
platform/mac/fast/repaint/layer-outline-horizontal-expected.checksum:
platform/mac/fast/repaint/layer-outline-horizontal-expected.png:
platform/mac/fast/repaint/layer-visibility-expected.png:
platform/mac/fast/repaint/layout-state-only-positioned-expected.png:
platform/mac/fast/repaint/layout-state-relative-expected.checksum:
platform/mac/fast/repaint/layout-state-relative-expected.png:
platform/mac/fast/repaint/layout-state-scrolloffset-expected.checksum:
platform/mac/fast/repaint/layout-state-scrolloffset-expected.png:
platform/mac/fast/repaint/layout-state-scrolloffset2-expected.checksum:
platform/mac/fast/repaint/layout-state-scrolloffset2-expected.png:
platform/mac/fast/repaint/layout-state-scrolloffset3-expected.checksum:
platform/mac/fast/repaint/layout-state-scrolloffset3-expected.png:
platform/mac/fast/repaint/line-overflow-expected.checksum:
platform/mac/fast/repaint/line-overflow-expected.png:
platform/mac/fast/repaint/lines-with-layout-delta-expected.checksum:
platform/mac/fast/repaint/lines-with-layout-delta-expected.png:
platform/mac/fast/repaint/list-marker-2-expected.checksum:
platform/mac/fast/repaint/list-marker-2-expected.png:
platform/mac/fast/repaint/list-marker-expected.checksum:
platform/mac/fast/repaint/list-marker-expected.png:
platform/mac/fast/repaint/make-children-non-inline-expected.checksum:
platform/mac/fast/repaint/make-children-non-inline-expected.png:
platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum:
platform/mac/fast/repaint/moving-shadow-on-container-expected.png:
platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum:
platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
platform/mac/fast/repaint/multicol-repaint-expected.checksum:
platform/mac/fast/repaint/multicol-repaint-expected.png:
platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.checksum:
platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.png:
platform/mac/fast/repaint/outline-child-repaint-expected.checksum:
platform/mac/fast/repaint/outline-child-repaint-expected.png:
platform/mac/fast/repaint/outline-inset-expected.png:
platform/mac/fast/repaint/outline-repaint-glitch-expected.checksum:
platform/mac/fast/repaint/outline-repaint-glitch-expected.png:
platform/mac/fast/repaint/outline-shrinking-expected.checksum:
platform/mac/fast/repaint/outline-shrinking-expected.png:
platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.png:
platform/mac/fast/repaint/overflow-delete-line-expected.checksum:
platform/mac/fast/repaint/overflow-delete-line-expected.png:
platform/mac/fast/repaint/overflow-into-content-expected.png:
platform/mac/fast/repaint/overflow-outline-repaint-expected.checksum:
platform/mac/fast/repaint/overflow-outline-repaint-expected.png:
platform/mac/fast/repaint/overflow-scroll-body-appear-expected.checksum:
platform/mac/fast/repaint/overflow-scroll-body-appear-expected.png:
platform/mac/fast/repaint/overflow-scroll-delete-expected.checksum:
platform/mac/fast/repaint/overflow-scroll-delete-expected.png:
platform/mac/fast/repaint/reflection-redraw-expected.checksum:
platform/mac/fast/repaint/reflection-redraw-expected.png:
platform/mac/fast/repaint/reflection-repaint-test-expected.png:
platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
platform/mac/fast/repaint/repaint-resized-overflow-expected.checksum:
platform/mac/fast/repaint/repaint-resized-overflow-expected.png:
platform/mac/fast/repaint/search-field-cancel-expected.checksum:
platform/mac/fast/repaint/search-field-cancel-expected.png:
platform/mac/fast/repaint/selected-replaced-expected.checksum:
platform/mac/fast/repaint/selected-replaced-expected.png:
platform/mac/fast/repaint/selection-after-delete-expected.checksum:
platform/mac/fast/repaint/selection-after-delete-expected.png:
platform/mac/fast/repaint/selection-after-remove-expected.checksum:
platform/mac/fast/repaint/selection-after-remove-expected.png:
platform/mac/fast/repaint/selection-clear-expected.checksum:
platform/mac/fast/repaint/selection-clear-expected.png:
platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
platform/mac/fast/repaint/selection-rl-expected.checksum:
platform/mac/fast/repaint/selection-rl-expected.png:
platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png:
platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
platform/mac/fast/repaint/shadow-multiple-vertical-expected.png:
platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
platform/mac/fast/repaint/stacked-diacritics-expected.png:
platform/mac/fast/repaint/static-to-positioned-expected.checksum:
platform/mac/fast/repaint/static-to-positioned-expected.png:
platform/mac/fast/repaint/subtree-root-clip-2-expected.png:
platform/mac/fast/repaint/subtree-root-clip-3-expected.png:
platform/mac/fast/repaint/subtree-root-clip-expected.png:
platform/mac/fast/repaint/subtree-root-skipped-expected.checksum:
platform/mac/fast/repaint/subtree-root-skipped-expected.png:
platform/mac/fast/repaint/table-cell-collapsed-border-expected.checksum:
platform/mac/fast/repaint/table-cell-collapsed-border-expected.png:
platform/mac/fast/repaint/table-cell-move-expected.checksum:
platform/mac/fast/repaint/table-cell-move-expected.png:
platform/mac/fast/repaint/table-cell-vertical-overflow-expected.png:
platform/mac/fast/repaint/table-col-background-expected.png:
platform/mac/fast/repaint/table-collapsed-border-expected.checksum:
platform/mac/fast/repaint/table-collapsed-border-expected.png:
platform/mac/fast/repaint/table-extra-bottom-grow-expected.checksum:
platform/mac/fast/repaint/table-extra-bottom-grow-expected.png:
platform/mac/fast/repaint/table-outer-border-expected.png:
platform/mac/fast/repaint/table-row-expected.png:
platform/mac/fast/repaint/table-section-overflow-expected.png:
platform/mac/fast/repaint/table-section-repaint-expected.png:
platform/mac/fast/repaint/table-two-pass-layout-overpaint-expected.png:
platform/mac/fast/repaint/text-append-dirty-lines-expected.checksum:
platform/mac/fast/repaint/text-append-dirty-lines-expected.png:
platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.checksum:
platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
platform/mac/fast/repaint/text-selection-rect-in-overflow-expected.checksum:
platform/mac/fast/repaint/text-selection-rect-in-overflow-expected.png:
platform/mac/fast/repaint/text-shadow-expected.checksum:
platform/mac/fast/repaint/text-shadow-expected.png:
platform/mac/fast/repaint/text-shadow-horizontal-expected.checksum:
platform/mac/fast/repaint/text-shadow-horizontal-expected.png:
platform/mac/fast/repaint/transform-absolute-child-expected.png:
platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.checksum:
platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.png:
platform/mac/fast/repaint/transform-disable-layoutstate-expected.png:
platform/mac/fast/repaint/transform-layout-repaint-expected.png:
platform/mac/fast/repaint/transform-relative-position-expected.checksum:
platform/mac/fast/repaint/transform-relative-position-expected.png:
platform/mac/fast/repaint/transform-repaint-descendants-expected.checksum:
platform/mac/fast/repaint/transform-repaint-descendants-expected.png:
platform/mac/fast/repaint/transform-replaced-shadows-expected.png:
platform/mac/fast/repaint/transform-translate-expected.png:

2:07 PM Changeset in webkit [71850] by weinig@apple.com

10 edits
2 adds in trunk/WebKit2

Move the remaining API client classes to use the APIClient base class.
https://bugs.webkit.org/show_bug.cgi?id=49404

Reviewed by Anders Carlsson.

Also moves InjectedBundleClient into its own class to match other API clients.

UIProcess/WebContextInjectedBundleClient.cpp:
UIProcess/WebContextInjectedBundleClient.h:
UIProcess/WebHistoryClient.cpp:

(WebKit::WebHistoryClient::didNavigateWithNavigationData):
(WebKit::WebHistoryClient::didPerformClientRedirect):
(WebKit::WebHistoryClient::didPerformServerRedirect):
(WebKit::WebHistoryClient::didUpdateHistoryTitle):
(WebKit::WebHistoryClient::populateVisitedLinks):

UIProcess/WebHistoryClient.h:

(WebKit::WebHistoryClient::shouldTrackVisitedLinks):

WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::initializeClient):
(WebKit::InjectedBundle::reportException):
(WebKit::InjectedBundle::didCreatePage):
(WebKit::InjectedBundle::willDestroyPage):
(WebKit::InjectedBundle::didReceiveMessage):

WebProcess/InjectedBundle/InjectedBundle.h:
WebProcess/InjectedBundle/InjectedBundleClient.cpp: Added.

(WebKit::InjectedBundleClient::didCreatePage):
(WebKit::InjectedBundleClient::willDestroyPage):
(WebKit::InjectedBundleClient::didReceiveMessage):

WebProcess/InjectedBundle/InjectedBundleClient.h: Added.
win/WebKit2.vcproj:

1:12 PM Changeset in webkit [71849] by eric@webkit.org

1 edit
2 moves
2 adds in trunk/WebKitTools

2010-11-11 Eric Seidel <eric@webkit.org>

Rubber-stamped by Adam Barth.

Move bugzilla.py into its own module in preparation for splitting one-file-per-class
https://bugs.webkit.org/show_bug.cgi?id=49402

Scripts/webkitpy/common/net/bugzilla/init.py: Added.
Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.

1:10 PM Changeset in webkit [71848] by cmarrin@apple.com

2 edits
2 moves in trunk/WebCore

2010-11-11 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388

Renamed GraphicsLayerCA.* to GraphicsLayerMac.*

WebCore.xcodeproj/project.pbxproj:
platform/graphics/mac/GraphicsLayerCA.h: Removed.
platform/graphics/mac/GraphicsLayerCA.mm: Removed.
platform/graphics/mac/GraphicsLayerMac.h: Copied from WebCore/platform/graphics/mac/GraphicsLayerCA.h.
platform/graphics/mac/GraphicsLayerMac.mm: Copied from WebCore/platform/graphics/mac/GraphicsLayerCA.mm.

1:05 PM Changeset in webkit [71847] by kbr@google.com

2 edits in trunk/WebCore

2010-11-11 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Missing adoptPtr in GraphicsContext3DSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=49359

platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):

1:02 PM Changeset in webkit [71846] by mihaip@chromium.org

3 edits
1 delete in trunk/LayoutTests

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update and rebaseline.

fast/text/justification-padding-mid-word.html started to pass on Linux and Windows after r71809 updated baselines for it.
fast/text/international/bidi-control-chars-treated-as-ZWS.html should pass with the regular Mac baselines, don't need chromium-mac ones anymore
Rebaseline fast/text/international/bidi-neutral-run.html

platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt:
platform/chromium/test_expectations.txt:

12:59 PM Changeset in webkit [71845] by andersca@apple.com

3 edits in trunk/WebKit2

Remove an unneeded CFAllocatorRef parameter.

Reviewed by Adam Roben.

Shared/API/c/mac/WKURLResponseNS.h:
Shared/API/c/mac/WKURLResponseNS.mm:

(WKURLResponseCopyNSURLResponse):

12:57 PM Changeset in webkit [71844] by commit-queue@webkit.org

2 edits in trunk/JavaScriptCore

2010-11-11 Dan Horák <dan@danny.cz>

Reviewed by Andreas Kling.

Add support for the s390/s390x architectures, it's big-endian
with s390 being 32-bit and s390x being 64-bit.

https://bugs.webkit.org/show_bug.cgi?id=34786

wtf/Platform.h:

12:57 PM Changeset in webkit [71843] by mitz@apple.com

3 edits in trunk/WebCore

<rdar://problem/8113511> Enable auto-hyphenation

Reviewed by Adam Roben.

WebCore.vcproj/WebCore.vcproj: Included HyphenationCF.cpp instead of Hyphenation.cpp.
platform/text/cf/HyphenationCF.cpp: Added functions and definitions for Windows to look up CFStringGetHyphenationLocationBeforeIndex

and CFStringIsHyphenationAvailableForLocale at runtime.
(wkCFStringGetHyphenationLocationBeforeIndex):
(wkCFStringIsHyphenationAvailableForLocale):
(WebCore::lastHyphenLocation): Added a cast.

12:31 PM Changeset in webkit [71842] by eric.carlson@apple.com

2 edits in trunk/WebCore

2010-11-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

video-pause-immediately.html sometimes fails
https://bugs.webkit.org/show_bug.cgi?id=49397

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::playInternal): Don't bother calling invalidateCachedTime, it will be called from updatePlayState. (WebCore::HTMLMediaElement::pauseInternal): Don't bother calling refreshCachedTime, it will be called from updatePlayState. (WebCore::HTMLMediaElement::updatePlayState): Call refreshCachedTime after telling the media engine to pause so we cache the post-paused time.

12:24 PM Changeset in webkit [71841] by eric@webkit.org

2 edits in trunk

2010-11-11 Eric Seidel <eric@webkit.org>

Rubber-stamped by Adam Roben.

.: Modified property svn:ignore.
- Add WebKitSupportLibrary.zip and WebKitBuild to the root ignore list.

12:18 PM Changeset in webkit [71840] by andersca@apple.com

12 edits in trunk/WebKit2

Add and implement WKDownloadCopyRequest
https://bugs.webkit.org/show_bug.cgi?id=49393

Reviewed by Adam Roben.

Shared/API/c/mac/WKURLRequestNS.h:
Shared/API/c/mac/WKURLRequestNS.mm:

(WKURLRequestCopyNSURLRequest):
Remove unneeded CFAllocator parameter.

Shared/WebURLRequest.cpp:

(WebKit::WebURLRequest::WebURLRequest):

Shared/WebURLRequest.h:

(WebKit::WebURLRequest::create):
Change create to take a ResourceRequest instead.

UIProcess/API/C/WKDownload.cpp:

(WKDownloadCopyRequest):
Return a copied WKURLRequest.

UIProcess/API/C/WKDownload.h:
UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didStart):
Set the request.

UIProcess/Downloads/DownloadProxy.h:

(WebKit::DownloadProxy::request):
Return the request.

UIProcess/Downloads/DownloadProxy.messages.in:
WebProcess/Downloads/Download.cpp:

(WebKit::Download::didStart):
Pass the request along when sending the DidStart message.

11:39 AM Changeset in webkit [71839] by mihaip@chromium.org

11 edits in trunk/WebCore

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed rollout.

Roll out r71827 and r71831, which caused many GPU canvas test failures.

platform/graphics/Extensions3D.h:
platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::reset): (WebCore::DrawingBuffer::getRenderingResultsAsTexture):
platform/graphics/chromium/Extensions3DChromium.h:
platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::create): (WebCore::DrawingBuffer::clear): (WebCore::DrawingBuffer::bind):
platform/graphics/gpu/DrawingBuffer.h:
platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create):
platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::reset):
platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::supports):
platform/graphics/opengl/Extensions3DOpenGL.h:
platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::draw):

11:07 AM Changeset in webkit [71838] by xji@chromium.org

1 edit
3 moves in trunk/LayoutTests

2010-11-11 Xiaomei Ji <xji@chromium.org>

Reviewed by Adam Roben.

Rebaseline bidi-control-chars-treated-as-ZWS after r71566.
Move the result from win/ (since Windows 7 result matches Mac's) to win-xp/
https://bugs.webkit.org/show_bug.cgi?id=49391

platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Copied from LayoutTests/platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum.
platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Copied from LayoutTests/platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png.
platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Copied from LayoutTests/platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt.
platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Removed.
platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Removed.
platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.

10:52 AM Changeset in webkit [71837] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

2010-11-11 Eric Carlson <eric.carlson@apple.com>

Unreviewed.

video-played-* tests results are sensitive to timing
https://bugs.webkit.org/show_bug.cgi?id=49390

Skip tests that fail on Leopard Release builds.

platform/mac-leopard/Skipped:

10:44 AM Changeset in webkit [71836] by mihaip@chromium.org

2 edits
2 adds in trunk/LayoutTests

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; add missing baseline checksums.

r71784 did not include .checksum files, add them (Chromium needs a
different one, persumably because it computes checksums for images
with alpha channels differently).

fast/images/png_per_row_alpha_decoding-expected.checksum: Added.
platform/chromium/fast/images/png_per_row_alpha_decoding-expected.checksum: Added.
platform/chromium/test_expectations.txt:

10:40 AM Changeset in webkit [71835] by sullivan@apple.com

2 edits in trunk/WebKit2

WebKit2.xcodeproj/project.pbxproj:

Added WKBundlePageOverlay.h to the WebKit2 Target and made it public.

Rubber-stamped by Anders Carlsson.

10:18 AM Changeset in webkit [71834] by andersca@apple.com

4 edits in trunk/WebKit2

Move GraphicsContext setup code to PageOverlay::drawRect
https://bugs.webkit.org/show_bug.cgi?id=49389

Reviewed by John Sullivan.

WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::drawRect):

WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::drawRect):

10:13 AM Changeset in webkit [71833] by eric.carlson@apple.com

1 edit in trunk/WebCore/ChangeLog

2010-11-11 Eric Carlson <eric.carlson@apple.com>

Restore the portion of the ChangeLog removed in my last commit.

9:47 AM Changeset in webkit [71832] by eric.carlson@apple.com

2 edits in trunk/WebCore

2010-11-11 Eric Carlson <eric.carlson@apple.com>

Unreviewed Leoaprd build fix.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::invalidateCachedTime): Make the const a double.

9:45 AM Changeset in webkit [71831] by cmarrin@apple.com

1 edit in trunk/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp

SL bug fix in ExtensionsOpenGL.cpp

9:41 AM Changeset in webkit [71830] by krit@webkit.org

2 edits in trunk/WebCore

2010-11-11 Dirk Schulze <krit@webkit.org>

Unreviewed Qt build fix.

SVGAnimation calcMode 'spline' should be useable for from-to and from-by animations
https://bugs.webkit.org/show_bug.cgi?id=49284

svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints): (WebCore::SVGAnimationElement::startedActiveInterval):

9:35 AM Changeset in webkit [71829] by hans@chromium.org

8 edits in trunk

2010-11-11 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: signal IDBFactoryBackendInterface destruction to embedder
https://bugs.webkit.org/show_bug.cgi?id=49313

Implement ChromiumBridge::idbShutdown(), passing through to the
WebKitClient.

public/WebKitClient.h: (WebKit::WebKitClient::idbShutdown):
src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::idbShutdown):

2010-11-11 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: signal IDBFactoryBackendInterface destruction to embedder
https://bugs.webkit.org/show_bug.cgi?id=49313

Define IDBFactoryBackendInterface destructor out-of-line to allow
for embedder-specific implementation. For Chromium, have the
destructor call ChromiumBridge::idbShutdown().

platform/chromium/ChromiumBridge.h:
storage/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
storage/IDBFactoryBackendInterface.h:
storage/chromium/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):

9:26 AM Changeset in webkit [71828] by krit@webkit.org

4 edits
15 adds in trunk

2010-11-11 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimation calcMode 'spline' should be useable for from-to and from-by animations
https://bugs.webkit.org/show_bug.cgi?id=49284

Add support for from-to and from-by animations in combination with calcMode 'spline' for SVGAnimations.

Tests: svg/animations/animate-calcMode-spline-by.html

svg/animations/animate-calcMode-spline-from-by.html
svg/animations/animate-calcMode-spline-from-to.html
svg/animations/animate-calcMode-spline-to.html
svg/animations/animate-calcMode-spline-values.html

svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculateKeyTimesIndex): Added to share more code. (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::startedActiveInterval): (WebCore::SVGAnimationElement::updateAnimation):
svg/SVGAnimationElement.h:

2010-11-11 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimation calcMode="spline" should use 'to' 'by' animation if no values were specified
https://bugs.webkit.org/show_bug.cgi?id=49284

Added new SVG animation tests to test calcMode 'spline'.

svg/animations/animate-calcMode-spline-by-expected.txt: Added.
svg/animations/animate-calcMode-spline-by.html: Added.
svg/animations/animate-calcMode-spline-from-by-expected.txt: Added.
svg/animations/animate-calcMode-spline-from-by.html: Added.
svg/animations/animate-calcMode-spline-from-to-expected.txt: Added.
svg/animations/animate-calcMode-spline-from-to.html: Added.
svg/animations/animate-calcMode-spline-to-expected.txt: Added.
svg/animations/animate-calcMode-spline-to.html: Added.
svg/animations/animate-calcMode-spline-values-expected.txt: Added.
svg/animations/animate-calcMode-spline-values.html: Added.
svg/animations/script-tests/animate-calcMode-spline-by.js: Added. (sample1): (sample2): (sample3): (executeTest):
svg/animations/script-tests/animate-calcMode-spline-from-by.js: Added. (sample1): (sample2): (sample3): (executeTest):
svg/animations/script-tests/animate-calcMode-spline-from-to.js: Added. (sample1): (sample2): (sample3): (executeTest):
svg/animations/script-tests/animate-calcMode-spline-to.js: Added. (sample1): (sample2): (sample3): (executeTest):
svg/animations/script-tests/animate-calcMode-spline-values.js: Added. (sample1): (sample2): (sample3): (executeTest):

9:11 AM Changeset in webkit [71827] by cmarrin@apple.com

11 edits in trunk/WebCore

2010-11-10 Chris Marrin <cmarrin@apple.com>

Reviewed by James Robinson.

Add multisampling support to DrawingBuffer.
https://bugs.webkit.org/show_bug.cgi?id=49206

Added support for the GL_ANGLE_framebuffer_blit and GL_ANGLE_framebuffer_multisample
extensions to Extensions3D. Then I use these to add multisample support to DrawingBuffer.

platform/graphics/Extensions3D.h:
platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::platformColorBuffer):
platform/graphics/chromium/Extensions3DChromium.h: (WebCore::Extensions3DChromium::blitFramebuffer): (WebCore::Extensions3DChromium::renderbufferStorageMultisample):
platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::create): (WebCore::DrawingBuffer::clear): (WebCore::DrawingBuffer::reset): (WebCore::DrawingBuffer::commit): (WebCore::DrawingBuffer::bind):
platform/graphics/gpu/DrawingBuffer.h: (WebCore::DrawingBuffer::multisample):
platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::platformLayer): (WebCore::DrawingBuffer::platformColorBuffer):
platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::supports): (WebCore::Extensions3DOpenGL::blitFramebuffer): (WebCore::Extensions3DOpenGL::renderbufferStorageMultisample):
platform/graphics/opengl/Extensions3DOpenGL.h:
platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::draw):

8:42 AM Changeset in webkit [71826] by eric.carlson@apple.com

2 edits in trunk/WebCore

2010-11-11 Eric Carlson <eric.carlson@apple.com>

Build fix after r71824.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::invalidateCachedTime): Use an explicit cast from double to float. (WebCore::HTMLMediaElement::currentTime): Ditto.

8:22 AM Changeset in webkit [71825] by Adam Roben

2 edits in trunk/WebKit2

Build fix after r71816

WebProcess/WebPage/WebPage.messages.in: Compile out

SetActualVisibleContentRect when ENABLE(TILED_BACKING_STORE) is
turned off.

8:08 AM Changeset in webkit [71824] by eric.carlson@apple.com

7 edits in trunk/WebCore

2010-11-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

Lots of time spent in MediaPlayerPrivate::currentTime() when playing multiple videos.
https://bugs.webkit.org/show_bug.cgi?id=49009

Make it possible for HTMLMediaElement to cache the movie time and report 'currentTime'
as [cached time + elapsed wall time]. The media engine returns the maximum duration it
is safe to calculate time before resampling the actual movie time with the new
maximumDurationToCacheMovieTime method. Because this may be different for different media
engines the default return value is 0, making it an opt-in feature.

No new tests were added because the existing tests already check currentTime, and because
it is only possible to look for drift between the calculated and actual media time by
calculating the time AND getting the actual media time - which the defeats the purpose of
the change. Building with LOG_CACHED_TIME_WARNINGS defined enables code that does both
and logs warnings when the delta between calculated and observed is greater than 0.01.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize new member variables. (WebCore::HTMLMediaElement::prepareForLoad): Force a time resync before setting m_paused. (WebCore::HTMLMediaElement::seek): Force a time resync before getting the current time before seeking so there is no drift. (WebCore::HTMLMediaElement::refreshCachedTime): New, update the cached movie time and the wall clock time it was recorded. (WebCore::HTMLMediaElement::invalidateCachedTime): New, flag the cached time as invalid. (WebCore::HTMLMediaElement::currentTime): Use a cached movie time for as long as the media engine says it is safe. Lots of optional logging can be enabled to help ports fine tune the maximum cache interval. (WebCore::HTMLMediaElement::ended): Force a time resync before setting m_paused. (WebCore::HTMLMediaElement::endScrubbing): Fix a typo in the logging. (WebCore::HTMLMediaElement::scheduleTimeupdateEvent): Call currentTime() instead of calling MediaPlayer so we use the cached time as much as it possible. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Invalidate cached time because the engine seeked. (WebCore::HTMLMediaElement::mediaPlayerRateChanged): Ditto. (WebCore::HTMLMediaElement::updatePlayState): Invalidate cached time before changing m_paused.
html/HTMLMediaElement.h:

platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::maximumDurationToCacheMovieTime): New.
platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::maximumDurationToCacheMovieTime): New.

platform/graphics/mac/MediaPlayerPrivateQTKit.h: (WebCore::MediaPlayerPrivate::maximumDurationToCacheMovieTime): New, say it is safe to cache time for five seconds (based on lots of experimenting with LOG_CACHED_TIME_WARNINGS enabled).

8:02 AM Changeset in webkit [71823] by Adam Roben

5 edits
1 move
1 add in trunk/WebCore

Windows build fix after r71816

r71816 renamed
WebCore/platform/graphics/cairo/FontPlatformDataCairoWin.h to
WebCore/platform/graphics/win/FontPlatformData.h. This made Apple's
Windows port pick up this header in preference to
WebCore/platform/cg/FontPlatformData.h, thus breaking the build. I
moved the file to
WebCore/platform/graphics/win/cairo/FontPlatformData.h so it won't be
picked up by Apple's Windows build.

WebCore.vcproj/WebCore.vcproj: Updated for file move and let VS

re-sort the files.

WebCore.vcproj/WebCoreCairo.vsprops: Added

platform/graphics/win/cairo to the include path.

WebCore.vcproj/copyForwardingHeaders.cmd: Copy files from

platform/graphics/win/cairo to $WebKitOutputDir.

platform/graphics/cg/FontPlatformData.h: Touched to force this file

to be recopied for Apple's build.

platform/graphics/win/cairo/FontPlatformData.h: Renamed from

WebCore/platform/graphics/win/FontPlatformData.h.

7:51 AM Changeset in webkit [71822] by chang.shu@nokia.com

5 edits
20 deletes in trunk/LayoutTests

2010-11-11 Chang Shu <chang.shu@nokia.com>

Reviewed by Csaba Osztrogonác <Csaba Osztrogonác>.

Clean up LayoutTests/canvas/philip/tests/security* tests
https://bugs.webkit.org/show_bug.cgi?id=49317

The security tests require httpd and should be in http/tests/canvas/philip/tests.

canvas/philip/tests/security.drawImage.canvas-expected.txt: Removed.
canvas/philip/tests/security.drawImage.canvas.html: Removed.
canvas/philip/tests/security.drawImage.image-expected.txt: Removed.
canvas/philip/tests/security.drawImage.image.html: Removed.
canvas/philip/tests/security.pattern.canvas.fillStyle-expected.txt: Removed.
canvas/philip/tests/security.pattern.canvas.fillStyle.html: Removed.
canvas/philip/tests/security.pattern.canvas.strokeStyle-expected.txt: Removed.
canvas/philip/tests/security.pattern.canvas.strokeStyle.html: Removed.
canvas/philip/tests/security.pattern.canvas.timing-expected.txt: Removed.
canvas/philip/tests/security.pattern.canvas.timing.html: Removed.
canvas/philip/tests/security.pattern.create-expected.txt: Removed.
canvas/philip/tests/security.pattern.create.html: Removed.
canvas/philip/tests/security.pattern.cross-expected.txt: Removed.
canvas/philip/tests/security.pattern.cross.html: Removed.
canvas/philip/tests/security.pattern.image.fillStyle-expected.txt: Removed.
canvas/philip/tests/security.pattern.image.fillStyle.html: Removed.
canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt: Removed.
canvas/philip/tests/security.pattern.image.strokeStyle.html: Removed.
canvas/philip/tests/security.reset-expected.txt: Removed.
canvas/philip/tests/security.reset.html: Removed.
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac-leopard/Skipped:
platform/qt/Skipped:

7:50 AM TriagingTestFailures edited by Adam Roben

Wordsmithing (diff)

7:47 AM Changeset in webkit [71821] by kbalazs@webkit.org

5 edits in trunk

2010-11-11 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Implement BackingStore
https://bugs.webkit.org/show_bug.cgi?id=49377
No change in functionality so no tests.

Add a way to hand off ownership of the QPainter and the underlying
QPaintDevice to the GraphicsContext.

platform/graphics/GraphicsContext.h:
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::takeOwnershipOfPlatformContext): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::takeOwnershipOfPlatformContext):

2010-11-11 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Implement BackingStore
https://bugs.webkit.org/show_bug.cgi?id=49377

Shared/qt/BackingStoreQt.cpp: (WebKit::createQImage): Added static helper. Creates a QImage from the shared memory buffer. (WebKit::BackingStore::createGraphicsContext): (WebKit::BackingStore::createFlippedGraphicsContext): Leave unimplemented with an ASSERT_NOT_REACHED since this is only needed for the CoreGraphics backend. (WebKit::BackingStore::paint):

7:45 AM TriagingTestFailures edited by Adam Roben

Mention that you should verify your changes worked (diff)

7:40 AM Changeset in webkit [71820] by bulach@chromium.org

1 edit
46 adds in trunk/LayoutTests

2010-11-11 Marcus Bulach <bulach@chromium.org>

Update chromium baselines for svg following r71802

Not reviewed, Chromium test expectation update..

https://bugs.webkit.org/show_bug.cgi?id=49380

platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.

7:27 AM Changeset in webkit [71819] by Csaba Osztrogonác

1 edit
27 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected results for new passing tests introduced in r71802.
Compared to Mac png files and Mac expected files.

platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum: Added.
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Added.
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.

6:50 AM Changeset in webkit [71818] by commit-queue@webkit.org

2 edits in trunk/WebKit/qt

2010-11-11 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] QWebScriptWorld::world() may crash
https://bugs.webkit.org/show_bug.cgi?id=49342

Api/qwebscriptworld.cpp: (QWebScriptWorld::world):

6:47 AM Changeset in webkit [71817] by andreas.kling@nokia.com

8 edits in trunk/WebKit2

2010-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

[Qt] Add a Qt WebKit2 API for overriding the actual visible content rect
https://bugs.webkit.org/show_bug.cgi?id=49381

Add an Qt WebKit2 API for overriding the actual visible content rect in
WebCore. This is supposed to be used in combination with tiling.

UIProcess/API/qt/qwkpage.cpp: (QWKPage::setActualVisibleContentsRect):
UIProcess/API/qt/qwkpage.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setActualVisibleContentRect):
UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setActualVisibleContentRect):
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

6:33 AM Changeset in webkit [71816] by commit-queue@webkit.org

6 edits
13 moves
2 adds
1 delete in trunk

2010-11-11 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Adam Barth.

[GTK] Move font related files.
https://bugs.webkit.org/show_bug.cgi?id=48116

Move pango and freetype related files to share non-GTK+ platforms.

No new tests because this is pure refactoring.

CMakeListsEfl.txt:
GNUmakefile.am:
WebCore.vcproj/WebCore.vcproj:
platform/graphics/cairo/FontCacheFreeType.cpp: Removed.
platform/graphics/cairo/FontCustomPlatformData.cpp: Removed.
platform/graphics/cairo/FontPlatformData.h: Removed.
platform/graphics/cairo/FontPlatformDataFreeType.cpp: Removed.
platform/graphics/cairo/FontPlatformDataFreeType.h: Removed.
platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: Removed.
platform/graphics/cairo/SimpleFontDataCairo.cpp: Removed.
platform/graphics/freetype: Added.
platform/graphics/freetype/FontCacheFreeType.cpp: Copied from WebCore/platform/graphics/cairo/FontCacheFreeType.cpp.
platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp: Copied from WebCore/platform/graphics/cairo/FontCustomPlatformData.cpp.
platform/graphics/freetype/FontPlatformData.h: Copied from WebCore/platform/graphics/cairo/FontPlatformDataFreeType.h.
platform/graphics/freetype/FontPlatformDataFreeType.cpp: Copied from WebCore/platform/graphics/cairo/FontPlatformDataFreeType.cpp.
platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp: Copied from WebCore/platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp.
platform/graphics/freetype/SimpleFontDataFreeType.cpp: Copied from WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp.
platform/graphics/gtk/FontCachePango.cpp: Removed.
platform/graphics/gtk/FontCustomPlatformDataPango.cpp: Removed.
platform/graphics/gtk/FontPlatformDataPango.cpp: Removed.
platform/graphics/gtk/FontPlatformDataPango.h: Removed.
platform/graphics/gtk/GlyphPageTreeNodePango.cpp: Removed.
platform/graphics/gtk/SimpleFontDataPango.cpp: Removed.
platform/graphics/pango: Added.
platform/graphics/pango/FontCachePango.cpp: Copied from WebCore/platform/graphics/gtk/FontCachePango.cpp.
platform/graphics/pango/FontCustomPlatformDataPango.cpp: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformDataPango.cpp.
platform/graphics/pango/FontPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontPlatformDataPango.h.
platform/graphics/pango/FontPlatformDataPango.cpp: Copied from WebCore/platform/graphics/gtk/FontPlatformDataPango.cpp.
platform/graphics/pango/GlyphPageTreeNodePango.cpp: Copied from WebCore/platform/graphics/gtk/GlyphPageTreeNodePango.cpp.
platform/graphics/pango/SimpleFontDataPango.cpp: Copied from WebCore/platform/graphics/gtk/SimpleFontDataPango.cpp.
platform/graphics/win/FontPlatformData.h: Copied from WebCore/platform/graphics/win/FontPlatformDataCairoWin.h.
platform/graphics/win/FontPlatformDataCairoWin.h: Removed.

2010-11-11 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Adam Barth.

[GTK] Move font related files.
https://bugs.webkit.org/show_bug.cgi?id=48116

Add freetype/ to include path.

CMakeListsEfl.txt:

6:08 AM Changeset in webkit [71815] by Nikolas Zimmermann

43 edits
40 copies in trunk/LayoutTests

2010-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Update Snow Leopard baseline, move leopard generated files into platform/mac-leopard.

platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum.
platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png.
platform/mac-leopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.checksum.
platform/mac-leopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png.
platform/mac-leopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.checksum.
platform/mac-leopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png.
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum:
platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:

6:06 AM Changeset in webkit [71814] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-11-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: size of resources in summary is 0
when there are redirects.
https://bugs.webkit.org/show_bug.cgi?id=49242

inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._updateSummaryBar):

5:49 AM Changeset in webkit [71813] by benm@google.com

3 edits in trunk/WebCore

2010-11-11 Ben Murdoch <benm@google.com>

Reviewed by Darin Fisher.

document.createTouch and document.createTouchList should specify EnabledAtRuntime
https://bugs.webkit.org/show_bug.cgi?id=49324

The createTouch and createTouchList APIs added to Document.idl in
http://trac.webkit.org/changeset/70047 should have EnabledAtRuntime
specified as touch related features are controlled by a
RuntimeEnabledFeature flag in addition to a compile time guard.

No new tests. This should have been part of r70047 and
that revision provided adequate tests of the new feature.

bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::createTouchEnabled): (WebCore::RuntimeEnabledFeatures::createTouchListEnabled):
dom/Document.idl: Add EnabledAtRuntime specifier to the

idl methods.

5:46 AM Changeset in webkit [71812] by pfeldman@chromium.org

3 edits in trunk/WebCore

2010-11-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Provide context menu item 'Reveal in Elements Panel'
on elements in inspector UI.
https://bugs.webkit.org/show_bug.cgi?id=49161

English.lproj/localizedStrings.js:
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement): (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired): (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired.revealElement):

5:27 AM Changeset in webkit [71811] by Adam Roben

2 edits in trunk/LayoutTests

Skip a newly-crashing test on Windows

platform/win/Skipped: Added accessibility/iframe-bastardization.html.

5:27 AM Changeset in webkit [71810] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-11-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Audit panel toolbar icon shifts left when clicked.
https://bugs.webkit.org/show_bug.cgi?id=48766

inspector/front-end/Images/auditsIcon.png:

5:24 AM TriagingTestFailures edited by Adam Roben

CC the author and reviewer of the guilty change, too (diff)

5:23 AM Changeset in webkit [71809] by Adam Roben

1 edit
4 adds in trunk/LayoutTests

Update Windows results after r71566 and r71783

<http://webkit.org/b/49378> covers the
justification-padding-mid-word.html failure. The other test seems to be
passing (the two lines are the same width), but the text is slightly
lower than on Mac.

platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Added.
platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
platform/win/fast/text/justification-padding-mid-word-expected.txt: Added.

5:21 AM TriagingTestFailures edited by Adam Roben

Mention linking to crash logs (diff)

5:11 AM Changeset in webkit [71808] by andreas.kling@nokia.com

1 edit
1 delete in trunk/LayoutTests

2010-11-11 Andreas Kling <kling@webkit.org>

Unreviewed, remove SL-specific failure result for canvas test 2d.drawImage.null since it now passes.

platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.null-expected.txt: Removed.

5:01 AM Changeset in webkit [71807] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] clean canvas layout tests skipped file
Removed the following test cases from skipped list:
canvas/philip/tests/2d.imageData.get.source.negative.html
canvas/philip/tests/toDataURL.jpeg.quality.basic.html

Patch by Qi Zhang <qi.2.zhang@nokia.com> on 2010-11-11
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped:

4:46 AM Changeset in webkit [71806] by andreas.kling@nokia.com

3 edits in trunk/WebKit/qt

2010-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

[Qt] Add an API for overriding the actual visible content rect in WebCore
https://bugs.webkit.org/show_bug.cgi?id=49373

Api/qwebpage.cpp: (QWebPage::setActualVisibleContentRect):
Api/qwebpage.h:

4:46 AM Changeset in webkit [71805] by Nikolas Zimmermann

3 edits
2 adds in trunk

2010-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

chrome.dll!WebCore::SVGLengthInternal::valueInSpecifiedUnitsAttrGetter ReadAV@NULL (4cf97a4f3ebe8006a2f5ffcc5bc10aeb)
https://bugs.webkit.org/show_bug.cgi?id=49331

Test: svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html

svg/properties/SVGListProperty.h: (WebCore::SVGListProperty::replaceItemValuesAndWrappers): Avoid premature deletion of 'oldItem'. (WebCore::SVGListProperty::removeItemValuesAndWrappers): Ditto.

2010-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

chrome.dll!WebCore::SVGLengthInternal::valueInSpecifiedUnitsAttrGetter ReadAV@NULL (4cf97a4f3ebe8006a2f5ffcc5bc10aeb)
https://bugs.webkit.org/show_bug.cgi?id=49331

svg/dom/SVGPolygonElement-baseVal-list-removal-crash-expected.txt: Added.
svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html: Added.

4:38 AM Changeset in webkit [71804] by andreas.kling@nokia.com

3 edits in trunk/WebCore

2010-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to override the visibleContentRect in the case the
client is handling the scrolling. This is similar to what the iPhone does.

platform/ScrollView.cpp: (WebCore::ScrollView::visibleContentRect):
platform/ScrollView.h: (WebCore::ScrollView::setActualVisibleContentRect):

4:32 AM Changeset in webkit [71803] by andreas.kling@nokia.com

5 edits in trunk

2010-11-11 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

FrameView: Don't clip to visibleContentRect in paintEntireContents mode
https://bugs.webkit.org/show_bug.cgi?id=49375

Use paintEntireContents in combination with tiling, allowing to
actually set visibleContentRect to something different from
the actual contents size.

Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

2010-11-11 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

FrameView: Don't clip to visibleContentRect in paintEntireContents mode
https://bugs.webkit.org/show_bug.cgi?id=49375

In paintEntireContents mode (used in combination with tiling) we
cannot clip to the actual visibleContentRect as the clipped regions
will not be updated again on scroll. If paintsEntireContents is
enabled, return the actual content rect.

page/FrameView.cpp: (WebCore::FrameView::windowClipRect):

3:20 AM Changeset in webkit [71802] by Nikolas Zimmermann

52 edits
50 adds
2 deletes in trunk

2010-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGMatrix/SVGTransform/SVGTransformList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49311

Move the last list type, SVGTransformList, and the last POD types, SVGMatrix & SVGTransform, over to the new SVGPropertyTearOff concept.
Removes the need for a custom JSSVGMatrix/V8SVGMatrix implementation, it's all integrated within the bindings now.

Tests: svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg

svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg
svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg
svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg
svg/W3C-SVG-1.1-SE/types-dom-01-b.svg
svg/W3C-SVG-1.1-SE/types-dom-02-f.svg
svg/W3C-SVG-1.1-SE/types-dom-03-b.svg
svg/W3C-SVG-1.1-SE/types-dom-04-b.svg
svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
svg/dom/SVGMatrix.html
svg/dom/SVGTransform.html
svg/dom/SVGTransformList.html

Android.jscbindings.mk: Removed JSSVGMatrixCustom.cpp.
Android.v8bindings.mk: Removed V8SVGMatrixCustom.cpp.
CMakeLists.txt: Remove JSSVGMatrixCustom.cpp.
GNUmakefile.am: Ditto. Add SVGAnimatedTransformListPropertyTearOff.h/SVGStaticPropertyWithParentTearOff.h/SVGTransformListPropertyTearOff.h/SVGAnimatedTransformList.h/SVGMatrix.h to build.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/js/JSBindingsAllInOne.cpp: Remove JSSVGMatrixCustom.cpp
bindings/js/JSSVGMatrixCustom.cpp: Removed.
bindings/scripts/CodeGenerator.pm: Convert SVGMatrix/SVGTransform/SVGTransformList to the new concept.
bindings/scripts/CodeGeneratorJS.pm: Ditto.
bindings/scripts/CodeGeneratorObjC.pm: Ditto.
bindings/scripts/CodeGeneratorV8.pm: Ditto.
bindings/v8/custom/V8SVGMatrixCustom.cpp: Removed.
svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGTransformList handling.
svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
svg/SVGAnimateTransformElement.cpp: Adapt to SVGTransformList API changes. (WebCore::transformListFor): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::calculateAnimatedValue): (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
svg/SVGAnimatedTransformList.h: Added.
svg/SVGGradientElement.cpp: Ditto. (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::parseMappedAttribute):
svg/SVGGradientElement.h: Ditto.
svg/SVGLinearGradientElement.cpp: Ditto. (WebCore::SVGLinearGradientElement::collectGradientAttributes):
svg/SVGMatrix.h: Added. SVGMatrix inherits from AffineTransform, and is only used in the bindings. It implements SVGs special requirements. (WebCore::SVGMatrix::translate): Returns a copy of the matrix, not affecting the original matrix. (WebCore::SVGMatrix::scale): Ditto. (WebCore::SVGMatrix::scaleNonUniform): Ditto. (WebCore::SVGMatrix::rotate): Ditto. (WebCore::SVGMatrix::flipX): Ditto. (WebCore::SVGMatrix::flipY): Ditto. (WebCore::SVGMatrix::skewX): Ditto. (WebCore::SVGMatrix::skewY): Ditto. (WebCore::SVGMatrix::multiply): Ditto. (WebCore::SVGMatrix::inverse): Ditto. (WebCore::SVGMatrix::rotateFromVector): Dittto.
svg/SVGMatrix.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise on all attributes/functions.
svg/SVGPatternElement.cpp: Adapt to SVGTransformList API changes. (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::parseMappedAttribute): (WebCore::SVGPatternElement::collectPatternAttributes):
svg/SVGPatternElement.h: Ditto.
svg/SVGPoint.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise for 'matrixTransform', now that SVGMatrix has been converted to the new scheme.
svg/SVGRadialGradientElement.cpp: Adapt to SVGTransformList API changes. (WebCore::SVGRadialGradientElement::collectGradientAttributes):
svg/SVGSVGElement.cpp: Ditto. (WebCore::SVGSVGElement::createSVGTransformFromMatrix): (WebCore::SVGSVGElement::viewBoxToViewTransform):
svg/SVGSVGElement.h: Ditto.
svg/SVGStyledTransformableElement.cpp: Ditto. (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement): (WebCore::SVGStyledTransformableElement::animatedLocalTransform): (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
svg/SVGStyledTransformableElement.h: Ditto.
svg/SVGTextElement.cpp: Ditto. (WebCore::SVGTextElement::SVGTextElement): (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::animatedLocalTransform):
svg/SVGTextElement.h: Ditto.
svg/SVGTransform.cpp: Modernize code, inlined some getters. (WebCore::SVGTransform::SVGTransform): (WebCore::SVGTransform::setMatrix):
svg/SVGTransform.h: Reindent header. (WebCore::SVGTransform::type): (WebCore::SVGTransform::svgMatrix): (WebCore::SVGTransform::matrix): (WebCore::SVGTransform::angle): (WebCore::SVGTransform::rotationCenter): (WebCore::SVGTransform::isValid): (WebCore::operator==): Avoid function calls, make operator== a friend of SVGTransform, and compare members directly. (WebCore::operator!=):
svg/SVGTransform.idl:
svg/SVGTransformList.cpp: Rewritten as plain Vector<SVGTransform>. (WebCore::SVGTransformList::createSVGTransformFromMatrix): (WebCore::SVGTransformList::consolidate): (WebCore::SVGTransformList::concatenate): (WebCore::SVGTransformList::valueAsString):
svg/SVGTransformList.h: (WebCore::SVGTransformList::SVGTransformList):
svg/SVGTransformList.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise on all attributes/functions.
svg/SVGTransformable.cpp: Adapt to SVGTransformList API changes. (WebCore::SVGTransformable::parseTransformAttribute):
svg/SVGTransformable.h: Ditto.
svg/SVGViewSpec.cpp: Ditto. (WebCore::SVGViewSpec::SVGViewSpec): (WebCore::SVGViewSpec::setTransform): (WebCore::SVGViewSpec::parseViewSpec):
svg/SVGViewSpec.h: Ditto. (WebCore::SVGViewSpec::transform):
svg/properties/SVGAnimatedListPropertyTearOff.h: Made constructor and members protected.
svg/properties/SVGAnimatedPropertyMacros.h: Add new helper macro DECLARE_ANIMATED_TRANSFORM_LIST_PROPERTY. This is needed until we expand all macros.
svg/properties/SVGAnimatedTransformListPropertyTearOff.h: Added. Extends SVGAnimatedListPropertyTearOff, returning SVGTransformListPropertyTearOff objects. (WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal): (WebCore::SVGAnimatedTransformListPropertyTearOff::animVal): (WebCore::SVGAnimatedTransformListPropertyTearOff::create): (WebCore::SVGAnimatedTransformListPropertyTearOff::SVGAnimatedTransformListPropertyTearOff):
svg/properties/SVGListPropertyTearOff.h: Made construct and members protected.
svg/properties/SVGProperty.h: Declare commitChange() as pure virtual method.
svg/properties/SVGPropertyTraits.h: Handle SVGTransformList.
svg/properties/SVGStaticPropertyWithParentTearOff.h: Added. Same concept as JSSVGStaticPODTypeWrapperWithParent, used to expose SVGPropertyTearOffs for types

that are using this concept themselves. (SVGMatrix attribute of SVGTransform, both are POD types, using SVGPropertyTearOff).

(WebCore::SVGStaticPropertyWithParentTearOff::create):
(WebCore::SVGStaticPropertyWithParentTearOff::commitChange):
(WebCore::SVGStaticPropertyWithParentTearOff::SVGStaticPropertyWithParentTearOff):

svg/properties/SVGTransformListPropertyTearOff.h: Added. Extends SVGListPropertyTearOff by two special SVGTransformList methods: consolidate and createSVGTransformFromMatrix. (WebCore::SVGTransformListPropertyTearOff::create): (WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix): (WebCore::SVGTransformListPropertyTearOff::consolidate): (WebCore::SVGTransformListPropertyTearOff::SVGTransformListPropertyTearOff):

2010-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGMatrix/SVGTransform/SVGTransformList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49311

Add tests covering StrictTypeChecking and RequiresAllArguments=Raise for SVGMatrix/SVGPoint.
Imported several new tests from SVG 1.1 2nd Edition, regarding SVG DOM primitives.

platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum: Added.
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Added.
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg: Added.
svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg: Added.
svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg: Added.
svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg: Added.
svg/W3C-SVG-1.1-SE/types-dom-01-b.svg: Added.
svg/W3C-SVG-1.1-SE/types-dom-02-f.svg: Added.
svg/W3C-SVG-1.1-SE/types-dom-03-b.svg: Added.
svg/W3C-SVG-1.1-SE/types-dom-04-b.svg: Added.
svg/W3C-SVG-1.1-SE/types-dom-05-b.svg: Added.
svg/dom/SVGMatrix-expected.txt: Added.
svg/dom/SVGMatrix.html: Added.
svg/dom/SVGPoint-expected.txt:
svg/dom/SVGTransform-expected.txt: Added.
svg/dom/SVGTransform.html: Added.
svg/dom/SVGTransformList-expected.txt: Added.
svg/dom/SVGTransformList.html: Added.
svg/dom/script-tests/SVGMatrix.js: Added.
svg/dom/script-tests/SVGPoint.js:
svg/dom/script-tests/SVGTransform.js: Added.
svg/dom/script-tests/SVGTransformList.js: Added.

1:44 AM Changeset in webkit [71801] by alex

2 edits in trunk/WebCore

2010-11-11 Alejandro G. Castro <alex@igalia.com>

Reviewed by Nikolas Zimmermann.

Fixed WebKitGTK gtk3 compilation.

platform/gtk/WidgetRenderingContextGtk3.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext):

12:56 AM Changeset in webkit [71800] by mitz@apple.com

3 edits in trunk/WebCore

Reverted r71975:71976. That change was wrong, and the tests caught it.

platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::ComplexTextRun::create):

platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

12:25 AM Changeset in webkit [71799] by tkent@chromium.org

1 edit
2 adds in trunk/LayoutTests

Add a test for form submission by <input type=image>
https://bugs.webkit.org/show_bug.cgi?id=49302

Reviewed by Shinichiro Hamaji.

fast/forms/input-image-submit-expected.txt: Added.
fast/forms/input-image-submit.html: Added.

12:07 AM Changeset in webkit [71798] by mdelaney@apple.com

2 edits in trunk/WebCore

2010-11-11 Matthew Delaney <mdelaney@apple.com>

Reviewed by Dan Bernstein.

Fix LayoutTests/canvas/philip/tests/2d.drawImage.null.html
https://bugs.webkit.org/show_bug.cgi?id=48307

There are no new tests because this is a fix for a pre-existing failing test.)

bindings/js/JSCanvasRenderingContext2DCustom.cpp: Corrected expection throwing cases to match up with spec.

Nov 10, 2010:

11:37 PM Changeset in webkit [71797] by rniwa@webkit.org

5 edits
3 adds in trunk

2010-11-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

[HTML5] 10.2.8.4 Scripts that modify the page as it is being parsed
https://bugs.webkit.org/show_bug.cgi?id=49364

Fixed HTMLScriptRunner's executeScript to use the ScriptController of the frame to which script element belongs
as supposed to that of the frame associated with the HTMLScriptRunner.

See also: http://www.whatwg.org/specs/web-apps/current-work/#scripts-that-modify-the-page-as-it-is-being-parsed

Test: fast/parser/script-modify-page-outer.html

html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Calls executeScript. (WebCore::HTMLScriptRunner::executeScript): Uses the correct ScriptController instance. (WebCore::HTMLScriptRunner::runScript): Call executeScript.
html/parser/HTMLScriptRunner.h:

2010-11-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

[HTML5] 10.2.8.4 Scripts that modify the page as it is being parsed
https://bugs.webkit.org/show_bug.cgi?id=49364

Added a test to ensure moving the script element to the parent document as it is being parsed
changes the script's global object to the parent document's window object.

See also: http://www.whatwg.org/specs/web-apps/current-work/#scripts-that-modify-the-page-as-it-is-being-parsed

fast/parser/move-during-parsing-expected.txt:
fast/parser/resources/script-modify-page-inner.html: Added.
fast/parser/script-modify-page-outer-expected.txt: Added.
fast/parser/script-modify-page-outer.html: Added.

9:20 PM Changeset in webkit [71796] by mitz@apple.com

2 edits in trunk/WebCore

Style fix I said I’d make then forgot to make.

platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):

9:18 PM Changeset in webkit [71795] by mitz@apple.com

3 edits in trunk/WebCore

Allow for the possibility of CoreText generating multiple runs for a single text run.
https://bugs.webkit.org/show_bug.cgi?id=49353

Patch by Ned Holbrook <nholbrook@apple.com> on 2010-11-10
Reviewed by Dan Bernstein.

platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::ComplexTextRun::create):

platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

8:58 PM Changeset in webkit [71794] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

platform/chromium/test_expectations.txt:

7:09 PM Changeset in webkit [71793] by kbr@google.com

2 edits in trunk/WebKit/chromium

2010-11-10 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Clean up gfx::GetGLImplementation calls in WebGraphicsContext3DDefaultImpl
https://bugs.webkit.org/show_bug.cgi?id=49336

src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv):

6:37 PM Changeset in webkit [71792] by commit-queue@webkit.org

6 edits in trunk

2010-11-10 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Use IAccessibleComparable to compare accessibility objects.
https://bugs.webkit.org/show_bug.cgi?id=49118

platform/win/Skipped:

2010-11-10 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Use IAccessibleComparable to compare accessibility objects.
https://bugs.webkit.org/show_bug.cgi?id=49118

DumpRenderTree/AccessibilityUIElement.cpp: (AccessibilityUIElement::isEqual):
DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/win/AccessibilityUIElementWin.cpp: (comparableObject): (AccessibilityUIElement::isEqual):

6:28 PM Changeset in webkit [71791] by Martin Robinson

9 edits
4 adds in trunk

2010-10-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Widgets do not support CSS transformations
https://bugs.webkit.org/show_bug.cgi?id=40139

Added a platform-specific baseline for the slider transformation
test. This baseline says "FAIL" because the test has platform-specific
offsets hard-coded. The result is only one tick off from expected though,
so it's likely correct for us.

platform/gtk/Skipped: Unskip.
platform/gtk/fast/forms/slider-transformed-expected.txt: Added.

2010-10-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Widgets do not support CSS transformations
https://bugs.webkit.org/show_bug.cgi?id=40139

Instead of rendering directly onto the target drawable when rendering
form controls on GTK+ 2.0, render onto an intermediate surface and use
cairo to blit the result back to the target surface. This has two
benefits. The first is that it always honors the current Cairo
transformation. The second is that since the intermediate drawable is
always a 32-bit GdkPixmap, we do not have to have a set of widgets
per-colormap any longer.

This change also begins the abstraction of widget rendering so that GTK+
2 and GTK+ 3 can use the same code path. The WidgetRenderingContext will
eventually hide all version differences from RenderThemeGtk, which can
just focus on interpreting the GtkStyle properties.

GNUmakefile.am: Add WidgetRenderinContext source files to the sources list.
platform/graphics/cairo/PlatformRefPtrCairo.cpp: (WTF::refPlatformPtr): Add a specialization for Cairo patterns. (WTF::derefPlatformPtr): Ditto.
platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto.
platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): No longer keep a set of widgets per-colormap for GTK+, instead just determine if we can use RGBA colormaps and go from there. (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto. (WebCore::RenderThemeGtk::getIndicatorMetrics): Put the logic for getting toggle button indicator metrics into this helper. (WebCore::RenderThemeGtk::paintRenderObject): Now uses WidgetRenderingContext to do widget rendering. (WebCore::setToggleSize): Use the new getIndicatorMetrics helper.
platform/gtk/RenderThemeGtk.h: Added a member to track whether or not the widgets are using a RGBA colormap. Also remove a defunct Page* member.
platform/gtk/ScrollbarThemeGtk.cpp: Switch all widget drawing operations to use WidgetRenderingContext. (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintThumb): Ditto. (WebCore::ScrollbarThemeGtk::paint): Ditto. (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
platform/gtk/WidgetRenderingContext.h: Added.
platform/gtk/WidgetRenderingContextGtk2.cpp: Added. (WebCore::purgeScratchBuffer): Added, this is similar to the scratch buffer implementation from ContextShadow. (WebCore::PurgeScratchBufferTimer::fired): Ditto. (WebCore::scheduleScratchBufferPurge): Ditto. (WebCore::getExtraSpaceForWidget): (WebCore::WidgetRenderingContext::WidgetRenderingContext): Added. (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Added. (WebCore::WidgetRenderingContext::paintMozillaWidget): Added.
platform/gtk/WidgetRenderingContextGtk3.cpp: Added. (WebCore::WidgetRenderingContext::WidgetRenderingContext): Added. (WebCore::~WidgetRenderingContext::WidgetRenderingContext): Added. (WebCore::WidgetRenderingContext::paintMozillaWidget): Added.

6:00 PM Changeset in webkit [71790] by Beth Dakin

16 edits in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
-[WebView _scaleWebView:] should take and origin and scroll the
document
-and corresponding-
<rdar://problem/8643921>

Reviewed by Simon Fraser.

WebCore:

Apply the scale to the origin, and set a new scroll position.

page/Frame.cpp:

(WebCore::Frame::scalePage):

page/Frame.h:
WebCore.exp.in:

WebKit/mac:

WebView/WebView.mm:

(-[WebView _scaleWebView:atOrigin:]):

WebView/WebViewPrivate.h:

WebKit2:

Shared/API/c/WKSharedAPICast.h:

(WebKit::toImpl):

UIProcess/API/C/WKPage.cpp:

(WKPageScaleWebView):

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::scaleWebView):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaleWebView):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

5:19 PM Changeset in webkit [71789] by mihaip@chromium.org

2 edits
4 adds in trunk/LayoutTests

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaselines.

Rebaseline fast/lists/001-vertical.html and fast/lists/008-vertical.html
with the chromium-mac scrollbars.

Rest of fast/lists/00*-vertical.html tests fail due to bug 48634,
add them to that grouping.

platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Added.
platform/chromium-mac/fast/lists/001-vertical-expected.png: Added.
platform/chromium-mac/fast/lists/008-vertical-expected.checksum: Added.
platform/chromium-mac/fast/lists/008-vertical-expected.png: Added.
platform/chromium/test_expectations.txt:

5:16 PM Changeset in webkit [71788] by adachan@apple.com

2 edits in trunk/WebKit2

Fix Windows build.

win/WebKit2Generated.make:

5:11 PM Changeset in webkit [71787] by mitz@apple.com

5 edits in trunk

REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
https://bugs.webkit.org/show_bug.cgi?id=49295

Reviewed by Darin Adler.

WebCore:

platform/graphics/mac/ComplexTextControllerATSUI.cpp: Reverted to r71565. Eliding bidi

control characters from ATSUI is no longer necessary since ComplexTextController removes
any glyphs corresponding to them.
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation):
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):

LayoutTests:

platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:

5:02 PM Changeset in webkit [71786] by mihaip@chromium.org

1 edit
1 delete in trunk/LayoutTests

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed removal of unncessary Qt baseline (atfer r71781 Qt should
use the base one).

platform/qt/svg/animations/repeatDur-zero-expected.txt: Removed.

5:01 PM Changeset in webkit [71785] by estade@chromium.org

3 edits in branches/chromium/552/WebKit/chromium

Merge 71774 - 2010-11-10 Evan Stade <estade@chromium.org>

Reviewed by Tony Chang.

[chromium] menu key doesn't work when capslock or numslock is on
https://bugs.webkit.org/show_bug.cgi?id=49289

Add a special bitmask for the "input" modifier keys (shift, alt, crtl, meta). The Modifier
enum has grown to something that might be better termed State, but changing the nomenclature
now is difficult. The bitmask gets its name from the related function getWebInputModifiers.

public/WebInputEvent.h: add InputModifiers mask for true modifier keys
src/WebViewImpl.cpp: disregard non-modifier keys (WebKit::WebViewImpl::keyEvent):

TBR=estade@chromium.org

4:48 PM Changeset in webkit [71784] by commit-queue@webkit.org

3 edits
4 adds in trunk

2010-11-10 Pascal Massimino <pascal.massimino@gmail.com>

Reviewed by Adam Barth.

add test case for png where each row has or hasn't alpha values.
This is to exercise code logic within PNGImageDecoder.cpp

https://bugs.webkit.org/show_bug.cgi?id=49333

fast/images/png_per_row_alpha_decoding-expected.png: Added.
fast/images/png_per_row_alpha_decoding-expected.txt: Added.
fast/images/png_per_row_alpha_decoding.html: Added.
fast/images/resources/png_per_row_alpha.png: Added.

2010-11-10 Pascal Massimino <pascal.massimino@gmail.com>

Reviewed by Adam Barth.

Simplify the alpha-detection code in png's decoding loop.
https://bugs.webkit.org/show_bug.cgi?id=49333

Added a special test for this case: png_per_row_alpha_decoding.html

platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): modified loop.

4:40 PM Changeset in webkit [71783] by mitz@apple.com

3 edits
2 adds in trunk

<rdar://problem/8647848> REGRESSION (r68551): Spaces shown at soft hyphens with complex justification
https://bugs.webkit.org/show_bug.cgi?id=49352

Reviewed by Simon Fraser.

WebCore:

Test: fast/text/justification-padding-mid-word.html

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Changed to add justification padding
and word spacing only at characters that are treated as space, instead of all characters that
use the space glyph (which includes characters treated as zero-width space as well).

LayoutTests:

fast/text/justification-padding-mid-word-expected.txt: Added.
fast/text/justification-padding-mid-word.html: Added.

4:31 PM Changeset in webkit [71782] by Simon Fraser

3 edits in trunk/WebKit2

2010-11-10 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Misc drawing area cleanup
https://bugs.webkit.org/show_bug.cgi?id=49349

UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::setSize): (WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible): (WebKit::LayerBackedDrawingAreaProxy::update): Call process()->send() instead of process()->connection()->send() in case the web process has not been launched yet.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Delay creation of the drawing area until after other WebPage state has been initialized, in case the DrawingArea creation needs to call back to the WebPage.

4:29 PM Changeset in webkit [71781] by mihaip@chromium.org

3 edits
1 add
1 delete in trunk/LayoutTests

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Reviewed by Simon Fraser.

svg/animations/repeatDur-zero.xhtml should use dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=49348

Per r71066 (which added the test), all that we're testing for is whether
or not we hang, therefore using dumpAsText is better (since then we
don't need per-platform baselines).

platform/chromium/test_expectations.txt:
platform/mac/svg/animations/repeatDur-zero-expected.txt: Removed.
svg/animations/repeatDur-zero-expected.txt: Added.
svg/animations/repeatDur-zero.xhtml:

4:22 PM Changeset in webkit [71780] by Simon Fraser

10 edits in trunk/WebKit2

2010-11-10 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

Push m_viewSize down to DrawingAreaProxy base class
https://bugs.webkit.org/show_bug.cgi?id=49347

Some refactoring so that the various drawing area classes
can share m_size.

UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::setSize):
UIProcess/ChunkedUpdateDrawingAreaProxy.h:
UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::setSize): (WebKit::DrawingAreaProxy::size):
UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::setSize):
UIProcess/LayerBackedDrawingAreaProxy.h:
UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: (WebKit::LayerBackedDrawingAreaProxy::platformSetSize): (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):

4:22 PM Changeset in webkit [71779] by mihaip@chromium.org

4 edits
11 adds in trunk/LayoutTests

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaselines.

Add missing Mac, Windows and Linux baselines (no actual Linux baselines
are included, the Windows ones are also used for it).

platform/chromium-mac/fast/blockflow/background-horizontal-bt-expected.checksum:
platform/chromium-mac/fast/blockflow/background-horizontal-bt-expected.png: Added.
platform/chromium-mac/fast/blockflow/background-vertical-lr-expected.checksum:
platform/chromium-mac/fast/blockflow/background-vertical-lr-expected.png: Added.
platform/chromium-win/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
platform/chromium-win/fast/blockflow/background-horizontal-bt-expected.png: Added.
platform/chromium-win/fast/blockflow/background-horizontal-bt-expected.txt: Added.
platform/chromium-win/fast/blockflow/background-vertical-lr-expected.checksum: Added.
platform/chromium-win/fast/blockflow/background-vertical-lr-expected.png: Added.
platform/chromium-win/fast/blockflow/background-vertical-lr-expected.txt: Added.
platform/chromium-win/fast/blockflow/background-vertical-rl-expected.checksum: Added.
platform/chromium-win/fast/blockflow/background-vertical-rl-expected.png: Added.
platform/chromium-win/fast/blockflow/background-vertical-rl-expected.txt: Added.
platform/chromium/test_expectations.txt:

4:00 PM Changeset in webkit [71778] by mihaip@chromium.org

1 edit
1 add in trunk/LayoutTests

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Add back text expectation mistakenly removed by r71773.

platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.

3:34 PM Changeset in webkit [71777] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Leopard rebaseline.

Rebaseline fast/text/international/bidi-neutral-run.html after r71763.

platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:

3:08 PM Changeset in webkit [71776] by tony@chromium.org

3 edits in trunk/LayoutTests

2010-11-10 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

plugins/npruntime/enumerate.html shouldn't depend on object enumeration order
https://bugs.webkit.org/show_bug.cgi?id=49338

The ES spec doesn't specify the order, so the test shouldn't depend on it.
Unfortunately, the test still fails in Chromium.

platform/chromium/test_expectations.txt:
plugins/npruntime/enumerate.html:

2:49 PM Changeset in webkit [71775] by senorblanco@chromium.org

3 edits
1 add in trunk/LayoutTests

2010-11-10 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations and baselines.

[chromium] Clean up test_expectations from my lazy gardening. One
new baseline. Remove expectations for many-layers.html (which itself
was removed in r71577).

platform/chromium-gpu/test_expectations.txt:
platform/chromium-linux/fast/text/midword-break-after-breakable-char-expected.txt: Added.
platform/chromium/test_expectations.txt:

2:47 PM Changeset in webkit [71774] by estade@chromium.org

3 edits in trunk/WebKit/chromium

2010-11-10 Evan Stade <estade@chromium.org>

Reviewed by Tony Chang.

[chromium] menu key doesn't work when capslock or numslock is on
https://bugs.webkit.org/show_bug.cgi?id=49289

Add a special bitmask for the "input" modifier keys (shift, alt, crtl, meta). The Modifier
enum has grown to something that might be better termed State, but changing the nomenclature
now is difficult. The bitmask gets its name from the related function getWebInputModifiers.

public/WebInputEvent.h: add InputModifiers mask for true modifier keys
src/WebViewImpl.cpp: disregard non-modifier keys (WebKit::WebViewImpl::keyEvent):

2:44 PM Changeset in webkit [71773] by mihaip@chromium.org

4 edits
1 delete in trunk/LayoutTests

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Update chromium-mac baselines after r71763.

platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt:

2:44 PM Changeset in webkit [71772] by mdelaney@apple.com

3 edits
1 add in trunk/WebCore

2010-11-10 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Crash in documentWillBecomeInactive() when closing window with Reader showing content with SVG
https://bugs.webkit.org/show_bug.cgi?id=49084

Manual test added.

manual-tests/svg-deep-clone-to-new-doc.html: Added manual test for reproducing bug since an automated version proved to be a bit tough to craft up.
svg/SVGSVGElement.cpp: Added in necessary document ownership transfer calls.
svg/SVGSVGElement.h:

2:32 PM Changeset in webkit [71771] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-11-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Red error bubbles don't fit content.
https://bugs.webkit.org/show_bug.cgi?id=49305

inspector/front-end/textViewer.css: (.webkit-html-message-bubble):

2:07 PM Changeset in webkit [71770] by ap@apple.com

1 edit
2 adds in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=45205
<rdar://problem/8391455> Detached elements shouldn't have style sheets.

Land test files I missed in original check-in.

fast/dom/StyleSheet/resources: Added.
fast/dom/StyleSheet/resources/detached-style.css: Added.

1:38 PM Changeset in webkit [71769] by ap@apple.com

2 edits in trunk/WebCore

Release build fix.

css/StyleSheet.cpp: isAcceptableStyleSheetParent() is a debug-only function.

1:16 PM Changeset in webkit [71768] by senorblanco@chromium.org

37 edits in trunk/LayoutTests

2010-11-10 Stephen White <senorblanco@chromium.org>

Unreviewed; updated test baselines.

Updated chromium-win tests affected slightly by
http://trac.webkit.org/changeset/71760.

platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
platform/chromium-win/svg/filters/feLighting-crash-expected.checksum:
platform/chromium-win/svg/filters/feLighting-crash-expected.png:

1:12 PM Changeset in webkit [71767] by ap@apple.com

17 edits
8 adds
4 deletes in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=45205
<rdar://problem/8391455> Detached elements shouldn't have style sheets.

Tests: fast/dom/StyleSheet/detached-style-2.html

fast/dom/StyleSheet/detached-style-pi.xhtml
fast/dom/StyleSheet/detached-style.html
fast/dom/StyleSheet/detached-style-pi-2.xhtml

bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::markChildren): There is no longer a need to mark owner nodes - StyleSheet->ownerNode() is only non-null when the node is in document.

css/StyleSheet.cpp: (WebCore::StyleSheet::StyleSheet): Added an assertion checking that all nodes that can be StyleSheet parents have been verified.

css/StyleSheet.h: (WebCore::StyleSheet::clearOwnerNode): Added.

dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::~ProcessingInstruction): Clear stylesheet's owner node. This shouldn't have observable effect, since a processing instruction that is in document can only be destroyed with document, and a reachable stylsheet keeps document alive. (WebCore::ProcessingInstruction::removedFromDocument): Clear the relationship between node and style sheet when removed. (WebCore::ProcessingInstruction::setCSSStyleSheet): If the element was removed during load, we still don't want to create a style sheet.

dom/StyleElement.cpp: (WebCore::StyleElement::sheet): There is no reason for lazy creation. It was a wrong fix for bug 14462, whose regression test still passes. (WebCore::StyleElement::removedFromDocument): Clear the relationship between node and style sheet when removed. (WebCore::StyleElement::finishParsingChildren): Don't call sheet(), it doens't have side effects any more. (WebCore::StyleElement::createSheet): Assert that the element is in document. We never want to create a style sheet for an element that isn't.

dom/StyleElement.h: (WebCore::StyleElement::sheet): Made implementation inline, now that it's a simple getter.

html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): Clear stylesheet's owner node. (WebCore::HTMLLinkElement::process): Assert that there is no style sheet lingering for any reason. (WebCore::HTMLLinkElement::removedFromDocument): Clear the relationship between node and style sheet when removed. (WebCore::HTMLLinkElement::setCSSStyleSheet): If the element was removed during load, we still don't want to create a style sheet.

html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::~HTMLStyleElement):
html/HTMLStyleElement.h:
svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::~SVGStyleElement):
svg/SVGStyleElement.h: Clear stylesheet's owner node. As above, this shouldn't have observable effect.

xml/XSLTProcessor.h:
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::~XSLTProcessor):
dom/Document.cpp: (WebCore::Document::~Document):
css/CSSParser.cpp: (WebCore::CSSParser::parseSelector): Assert that stylesheet won't outlive its owner node. We don't really use refcounting here.

1:11 PM Changeset in webkit [71766] by crogers@google.com

38 edits
2 copies in branches/audio

audio branch: changes made for landing in trunk

update Webcore.gyp with latest audio files
remove PassThroughPanner from WebCore.xcodeproj
FFMPEG file reading cleanup
remove obsolete pass-through panning model
deal with ppc and i386 vs. other architectures in calls to Accelerate.framework
various custom bindings cleanup
add ChromiumBridge loadPlatformAudioResource() and decodeAudioFileData() methods
add WebAudioBus thin wrapper class for use by WebKitClient::decodeAudioFileData()
enable WEB_AUDIO on audio branch for chrome
cleanup AudioBusMac, RealtimeAnalyser, RealtimeAnalyerNode, JavaScriptAudioNode, AudioProcessingEvent, ConvolverNode, AudioBufferSourceNode, AudioChannelSplitter, AudioDestinationNode, AudioGainNode
use Conditional=WEB_AUDIO for DOMWindow AudioContext constructor
include <CoreServices/CoreServices.h> in AudioFileReaderMac.cpp
no longer need to include "HTMLNames.h" in AudioContext.cpp

1:04 PM Changeset in webkit [71765] by senorblanco@chromium.org

1 edit in trunk/LayoutTests/ChangeLog

Fixed messed-up ChangeLog.

12:55 PM Changeset in webkit [71764] by senorblanco@chromium.org

37 edits in trunk/LayoutTests

2010-11-10 Dan Bernstein <mitz@apple.com>

REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
https://bugs.webkit.org/show_bug.cgi?id=49295

platform/mac-leopard/Skipped: Re-enable the previously failing test.

12:53 PM Changeset in webkit [71763] by mitz@apple.com

5 edits in trunk

REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
https://bugs.webkit.org/show_bug.cgi?id=49295

WebCore:

Reviewed by Dave Hyatt.

platform/graphics/mac/ComplexTextController.h: Added m_indexOffset.
platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Use m_indexOffset
instead of computing the offset based on m_directionalOverride.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Set m_indexOffset to
the offset between indices in m_characters and indices in the text passed to ATSUI.

LayoutTests:

platform/mac-leopard/Skipped: Re-enable the previously failing test.

12:44 PM Changeset in webkit [71762] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-11-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Gear menu floats to right edge and expands
to bottom of "Styles" section.
https://bugs.webkit.org/show_bug.cgi?id=49303

This fixes computed style's option wrapping to the next line.

inspector/front-end/inspector.css: (.sidebar-pane-subtitle):

12:30 PM Changeset in webkit [71761] by andersca@apple.com

2 edits in trunk/WebKit2

Closing tabs sometimes crashes the WebProcess in invalidateContentsAndWindow
https://bugs.webkit.org/show_bug.cgi?id=49335
<rdar://problem/8646621>

Reviewed by Dan Bernstein.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::changeAcceleratedCompositingMode):
If we fail to send the DidChangeAcceleratedCompositing message, don't null out the
drawing area. This will happen during page teardown.

12:16 PM Changeset in webkit [71760] by senorblanco@chromium.org

4 edits in trunk

2010-11-10 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Fix canvas.putImageData(canvas.getImageData(...)) to be lossless.
https://bugs.webkit.org/show_bug.cgi?id=49330

These cycles should be lossless for valid colours. A similar fix went
into the CG port at r32878.

Covered by canvas/philip/tests/2d.imageData.put.unchanged.html.

platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::mulDiv255Ceil): A helper function to do (a + b + 254) / 255 without a divide. (WebCore::putImageData): Use the above helper to round up when premultiplying alpha.

2010-11-10 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Mark 2d.imageData.put.unchanged.html as passing on Win/Linux.
https://bugs.webkit.org/show_bug.cgi?id=49330

platform/chromium/test_expectations.txt:

11:29 AM Changeset in webkit [71759] by mihaip@chromium.org

2 edits
19 adds in trunk/LayoutTests

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Mac rebaselines.

Add Chromium Mac baselines for tests added by r71382 (since they have
scrollbars they can't use the upstream Mac baselines).

platform/chromium-mac/fast/table/027-vertical-expected.checksum: Added.
platform/chromium-mac/fast/table/027-vertical-expected.png: Added.
platform/chromium-mac/fast/table/028-vertical-expected.checksum: Added.
platform/chromium-mac/fast/table/028-vertical-expected.png: Added.
platform/chromium-mac/fast/table/038-vertical-expected.checksum: Added.
platform/chromium-mac/fast/table/038-vertical-expected.png: Added.
platform/chromium-mac/fast/table/040-vertical-expected.checksum: Added.
platform/chromium-mac/fast/table/040-vertical-expected.png: Added.
platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.png: Added.
platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.png: Added.
platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
platform/chromium-mac/fast/table/height-percent-test-vertical-expected.checksum: Added.
platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png: Added.
platform/chromium-mac/fast/table/table-display-types-vertical-expected.checksum: Added.
platform/chromium-mac/fast/table/table-display-types-vertical-expected.png: Added.
platform/chromium/test_expectations.txt:

11:18 AM Changeset in webkit [71758] by tony@chromium.org

2 edits in trunk/LayoutTests

2010-11-10 Tony Chang <tony@chromium.org>

Unreviewed, update DRT Chromium Mac plugin test results.
This matches the past 2 runs on the bot.

platform/chromium/drt_expectations.txt:

11:11 AM Changeset in webkit [71757] by mihaip@chromium.org

2 edits
96 adds in trunk/LayoutTests

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Mac rebaselines.

Rebaseline css1/ and css2.1/ (because of scrollbar display diferences).

platform/chromium-mac/css1/cascade/cascade_order-expected.checksum: Added.
platform/chromium-mac/css1/cascade/cascade_order-expected.png: Added.
platform/chromium-mac/css1/classification/display-expected.checksum: Added.
platform/chromium-mac/css1/classification/display-expected.png: Added.
platform/chromium-mac/css1/classification/list_style_type-expected.checksum: Added.
platform/chromium-mac/css1/classification/list_style_type-expected.png: Added.
platform/chromium-mac/css1/classification/white_space-expected.checksum: Added.
platform/chromium-mac/css1/classification/white_space-expected.png: Added.
platform/chromium-mac/css1/color_and_background/background-expected.checksum: Added.
platform/chromium-mac/css1/color_and_background/background-expected.png: Added.
platform/chromium-mac/css1/color_and_background/background_attachment-expected.checksum: Added.
platform/chromium-mac/css1/color_and_background/background_attachment-expected.png: Added.
platform/chromium-mac/css1/color_and_background/background_position-expected.checksum: Added.
platform/chromium-mac/css1/color_and_background/background_position-expected.png: Added.
platform/chromium-mac/css1/color_and_background/background_repeat-expected.checksum: Added.
platform/chromium-mac/css1/color_and_background/background_repeat-expected.png: Added.
platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.checksum: Added.
platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.png: Added.
platform/chromium-mac/css1/font_properties/font-expected.checksum: Added.
platform/chromium-mac/css1/font_properties/font-expected.png: Added.
platform/chromium-mac/css1/font_properties/font_size-expected.checksum: Added.
platform/chromium-mac/css1/font_properties/font_size-expected.png: Added.
platform/chromium-mac/css1/font_properties/font_weight-expected.checksum: Added.
platform/chromium-mac/css1/font_properties/font_weight-expected.png: Added.
platform/chromium-mac/css1/formatting_model/floating_elements-expected.checksum: Added.
platform/chromium-mac/css1/formatting_model/floating_elements-expected.png: Added.
platform/chromium-mac/css1/formatting_model/height_of_lines-expected.checksum: Added.
platform/chromium-mac/css1/formatting_model/height_of_lines-expected.png: Added.
platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.checksum: Added.
platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.png: Added.
platform/chromium-mac/css1/formatting_model/inline_elements-expected.checksum: Added.
platform/chromium-mac/css1/formatting_model/inline_elements-expected.png: Added.
platform/chromium-mac/css1/formatting_model/replaced_elements-expected.checksum: Added.
platform/chromium-mac/css1/formatting_model/replaced_elements-expected.png: Added.
platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.checksum: Added.
platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.png: Added.
platform/chromium-mac/css1/pseudo/anchor-expected.checksum: Added.
platform/chromium-mac/css1/pseudo/anchor-expected.png: Added.
platform/chromium-mac/css1/pseudo/firstletter-expected.checksum: Added.
platform/chromium-mac/css1/pseudo/firstletter-expected.png: Added.
platform/chromium-mac/css1/pseudo/firstline-expected.checksum: Added.
platform/chromium-mac/css1/pseudo/firstline-expected.png: Added.
platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.checksum: Added.
platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.png: Added.
platform/chromium-mac/css1/text_properties/letter_spacing-expected.checksum: Added.
platform/chromium-mac/css1/text_properties/letter_spacing-expected.png: Added.
platform/chromium-mac/css1/text_properties/line_height-expected.checksum: Added.
platform/chromium-mac/css1/text_properties/line_height-expected.png: Added.
platform/chromium-mac/css1/text_properties/text_decoration-expected.checksum: Added.
platform/chromium-mac/css1/text_properties/text_decoration-expected.png: Added.
platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
platform/chromium-mac/css1/text_properties/text_transform-expected.checksum: Added.
platform/chromium-mac/css1/text_properties/text_transform-expected.png: Added.
platform/chromium-mac/css1/text_properties/vertical_align-expected.checksum: Added.
platform/chromium-mac/css1/text_properties/vertical_align-expected.png: Added.
platform/chromium-mac/css1/text_properties/word_spacing-expected.checksum: Added.
platform/chromium-mac/css1/text_properties/word_spacing-expected.png: Added.
platform/chromium-mac/css1/units/color_units-expected.checksum: Added.
platform/chromium-mac/css1/units/color_units-expected.png: Added.
platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
platform/chromium-mac/css1/units/length_units-expected.png: Added.
platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: Added.
platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Added.
platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.checksum: Added.
platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.png: Added.
platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum: Added.
platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Added.
platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
platform/chromium-mac/css2.1/t1202-counters-08-b-expected.checksum: Added.
platform/chromium-mac/css2.1/t1202-counters-08-b-expected.png: Added.
platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum: Added.
platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png: Added.
platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Added.
platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum: Added.
platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: Added.
platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.checksum: Added.
platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.png: Added.
platform/chromium/test_expectations.txt:

11:02 AM Changeset in webkit [71756] by Martin Robinson

2 edits in trunk/LayoutTests

2010-11-10 Martin Robinson <mrobinson@igalia.com>

Rebaseline a new test. The patch was posted before font
hinting was disabled in the GTK+ DRT.

platform/gtk/fonts/complex-text-shadows-expected.txt:

10:51 AM Changeset in webkit [71755] by mihaip@chromium.org

3 edits in trunk/LayoutTests

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium DRT expectations update.

fast/images/gif-loop-count.html fails on Linux and Mac when under the DRT.
Add more flaky media tests
Tweak video-referrer.html error output to be more useful

http/tests/media/video-referer.html:
platform/chromium/drt_expectations.txt:

10:43 AM Changeset in webkit [71754] by Csaba Osztrogonác

39 edits in trunk