Timeline



Dec 9, 2010:

11:48 PM Changeset in webkit [73690] by rniwa@webkit.org
  • 16 edits
    5 copies in trunk

2010-12-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Make DOM Mutation Events Asynchronous
https://bugs.webkit.org/show_bug.cgi?id=46936

Implemented DOM mutations events as scoped events. A scoped event is an event whose
dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by
EventQueueScope objects (RAII idiom), which increments and decrements the scoping level
on its constructor and destructor respectively.

When the scoping level is 0 (initial level), scoped events are dispatched as soon as
they are enqueued and act like synchronous events. When the scoping level is greater than 0,
however, events are queued in ScopedEventQueue and their dispatches are delayed until
the scoping level goes back to 0 (by the destruction of EventQueueScope).

DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument,
DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as
scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
of the events until the completion of each call of EditCommand::doApply.

Test: fast/events/mutation/execCommands.html

  • Android.mk: Added ScopedEventQueue.cpp.
  • CMakeLists.txt: Ditto.
  • WebCore.pro: Ditto.
  • GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/project.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent. (WebCore::dispatchChildRemovalEvents): Ditto.
  • dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
  • dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): Ditto. (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
  • dom/Node.cpp: (WebCore::Node::dispatchScopedEvent): Added. (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent.
  • dom/Node.h:
  • dom/ScopedEventQueue.cpp: Added. (WebCore::ScopedEventQueue::initialize): Added. (WebCore::ScopedEventQueue::enqueueEvent): Added. (WebCore::ScopedEventQueue::dispatchAllEvents): Added. (WebCore::ScopedEventQueue::dispatchEvent): Added. (WebCore::ScopedEventQueue::instance): Added. (WebCore::ScopedEventQueue::incrementScopingLevel): Added. (WebCore::ScopedEventQueue::decrementScopingLevel): Added.
  • dom/ScopedEventQueue.h: Added. (WebCore::ScopedEventQueue::~ScopedEventQueue): Added. (WebCore::ScopedEventQueue::ScopedEventQueue): Added. (WebCore::EventQueueScope::EventQueueScope): Added. (WebCore::EventQueueScope::~EventQueueScope): Added.
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Instantiates EventQueueScope.

2010-12-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Make DOM Mutation Events Asynchronous
https://bugs.webkit.org/show_bug.cgi?id=46936

Added a test to ensure no DOM mutation events are fired while execCommand is in progress.

  • fast/events/crash-on-mutate-during-drop.html: DOMNodeInserted is fired after BR is detached from the document, and can't be observed. Modify the DOM when text node is inserted.
  • fast/events/scoped: Added.
  • fast/events/scoped/editing-commands-expected.txt: Added.
  • fast/events/scoped/editing-commands.html: Added.
11:15 PM Changeset in webkit [73689] by rniwa@webkit.org
  • 16 edits
    3 deletes in trunk

2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73684.
http://trac.webkit.org/changeset/73684
https://bugs.webkit.org/show_bug.cgi?id=50801

"missing bug number" (Requested by rniwa on #webkit).

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
  • dom/DOMAllInOne.cpp:
  • dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent):
  • dom/Node.cpp: (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchUIEvent):
  • dom/Node.h:
  • dom/ScopedEventQueue.cpp: Removed.
  • dom/ScopedEventQueue.h: Removed.
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply):

2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73684.
http://trac.webkit.org/changeset/73684
https://bugs.webkit.org/show_bug.cgi?id=50801

"missing bug number" (Requested by rniwa on #webkit).

  • fast/events/crash-on-mutate-during-drop.html:
  • fast/events/scoped/editing-commands-expected.txt: Removed.
  • fast/events/scoped/editing-commands.html: Removed.
10:45 PM Changeset in webkit [73688] by eric@webkit.org
  • 4 edits
    1 add in trunk/WebKitTools

2010-12-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach webkit-patch how to search bugzilla
https://bugs.webkit.org/show_bug.cgi?id=50500

This is a step towards teaching webkitpy how to file
new bugs for flaky tests and update them when new flakes occur.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/bugsearch.py: Added.
10:21 PM Changeset in webkit [73687] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-09 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] enable orientation flag when QtMobility available
https://bugs.webkit.org/show_bug.cgi?id=50781

When QtMobility available, enable orientation flag by default.

  • features.pri:
9:59 PM Changeset in webkit [73686] by commit-queue@webkit.org
  • 14 edits
    3 adds in trunk

2010-12-09 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Improve validation API support of <object> and <keygen>
https://bugs.webkit.org/show_bug.cgi?id=50663

Adds tests for validation API for <object>.
Tests for <output> and <keygen> are also added.

  • fast/dom/plugin-attributes-enumeration-expected.txt: Updated.
  • fast/forms/ValidityState-001-expected.txt: Updated.
  • fast/forms/ValidityState-001.html: Updated.
  • fast/forms/checkValidity-001-expected.txt: Updated.
  • fast/forms/checkValidity-001.html: Updated.
  • fast/forms/script-tests/setCustomValidity-existence.js: Added.
  • fast/forms/script-tests/validationMessage.js: Updated.
  • fast/forms/script-tests/willvalidate.js: Updated.
  • fast/forms/setCustomValidity-existence-expected.txt: Added.
  • fast/forms/setCustomValidity-existence.html: Added.
  • fast/forms/validationMessage-expected.txt: Updated.
  • fast/forms/willvalidate-expected.txt: Updated.

2010-12-09 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Improve validation API support of <object> and <keygen>
https://bugs.webkit.org/show_bug.cgi?id=50663

Adds validation API to HTMLObjectElement class.
Makes HTMLKeygenElement::willValidate() return false.

Test: fast/forms/setCustomValidity-existence.html

  • html/HTMLKeygenElement.h: (WebCore::HTMLKeygenElement::willValidate): Added.
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::validationMessage): Added. (WebCore::HTMLObjectElement::checkValidity): Added. (WebCore::HTMLObjectElement::setCustomValidity): Added.
  • html/HTMLObjectElement.idl: Added validation API properties.
9:44 PM Changeset in webkit [73685] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-12-09 Sadrul Habib Chowdhury <sadrul@chromium.org>

Reviewed by Kent Tamura.

Make sure a non-zero value is used for tile-width to avoid a crash
https://bugs.webkit.org/show_bug.cgi?id=50341

The scaled tile width can be very small at times (e.g. with 'style: font 1
required'). So use a minimum width of 1 instead of using 0 (which leads to a
crash).

  • fast/dom/HTMLProgressElement/progress-element-with-style-crash.html: Added.
  • fast/dom/HTMLProgressElement/progress-element-with-style-crash-expected.txt: Added.

2010-12-09 Sadrul Habib Chowdhury <sadrul@chromium.org>

Reviewed by Kent Tamura.

Make sure a non-zero value is used for tile-width to avoid a crash
https://bugs.webkit.org/show_bug.cgi?id=50341

The scaled tile width can be very small at times (e.g. with 'style: font 1
required'). So use a minimum width of 1 instead of using 0 (which leads to a
crash).

Tests: fast/dom/HTMLProgressElement/progress-element-with-style-crash.html

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintProgressBar):
9:08 PM Changeset in webkit [73684] by rniwa@webkit.org
  • 16 edits
    5 adds in trunk

2010-12-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Implemented DOM mutations events as scoped events. A scoped event is an event whose
dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by
EventQueueScope objects (RAII idiom), which increments and decrements the scoping level
on its constructor and destructor respectively.

When the scoping level is 0 (initial level), scoped events are dispatched as soon as
they are enqueued and act like synchronous events. When the scoping level is greater than 0,
however, events are queued in ScopedEventQueue and their dispatches are delayed until
the scoping level goes back to 0 (by the destruction of EventQueueScope).

DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument,
DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as
scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
of the events until the completion of each call of EditCommand::doApply.

Test: fast/events/mutation/execCommands.html

  • Android.mk: Added ScopedEventQueue.cpp.
  • CMakeLists.txt: Ditto.
  • WebCore.pro: Ditto.
  • GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/project.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent. (WebCore::dispatchChildRemovalEvents): Ditto.
  • dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
  • dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): Ditto. (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
  • dom/Node.cpp: (WebCore::Node::dispatchScopedEvent): Added. (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent.
  • dom/Node.h:
  • dom/ScopedEventQueue.cpp: Added. (WebCore::ScopedEventQueue::initialize): Added. (WebCore::ScopedEventQueue::enqueueEvent): Added. (WebCore::ScopedEventQueue::dispatchAllEvents): Added. (WebCore::ScopedEventQueue::dispatchEvent): Added. (WebCore::ScopedEventQueue::instance): Added. (WebCore::ScopedEventQueue::incrementScopingLevel): Added. (WebCore::ScopedEventQueue::decrementScopingLevel): Added.
  • dom/ScopedEventQueue.h: Added. (WebCore::ScopedEventQueue::~ScopedEventQueue): Added. (WebCore::ScopedEventQueue::ScopedEventQueue): Added. (WebCore::EventQueueScope::EventQueueScope): Added. (WebCore::EventQueueScope::~EventQueueScope): Added.
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Instantiates EventQueueScope.

2010-12-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Added a test to ensure no DOM mutation events are fired while execCommand is in progress.

  • fast/events/crash-on-mutate-during-drop.html: DOMNodeInserted is fired after BR is detached from the document, and can't be observed. Modify the DOM when text node is inserted.
  • fast/events/mutation: Added.
  • fast/events/mutation/execCommands.html: Added.
8:54 PM Changeset in webkit [73683] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix scrolling with mouse wheel in WebKit2 views. Once
we coalesce wheel events, we can re-enable this.

Reviewed by Gavin Barraclough.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scroll):

8:53 PM Changeset in webkit [73682] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-12-09 Adam Barth <abarth@webkit.org>

Reviewed by Ojan Vafai.

commit-queue errors out due to local commits
https://bugs.webkit.org/show_bug.cgi?id=50766

We seem to be tripping over having local commits in the working copy a
lot recently. I don't quite fully understand what the issue is, but
this patch attempts to solve the problem by adding an explicit clean
step before processing a patch. Previously, we did the cleaning as
part of the apply-attachment step, so this might not actually fix the
problem.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
8:43 PM Changeset in webkit [73681] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-12-09 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

For details element, ensure that if we ended up being inline that we set out replaced
flag so that we are treated like an inline block.
https://bugs.webkit.org/show_bug.cgi?id=50671

Test: fast/html/details-element-render-inline-crash.html

  • rendering/RenderDetails.cpp: (WebCore::RenderDetails::styleDidChange): setReplaced to true if we are set as inline.
  • rendering/RenderDetails.h: function definition.

2010-12-09 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

Tests that we do not crash when we set details element with children to show as inline.
https://bugs.webkit.org/show_bug.cgi?id=50671

  • fast/html/details-element-render-inline-crash-expected.txt: Added.
  • fast/html/details-element-render-inline-crash.html: Added.
8:29 PM Changeset in webkit [73680] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-12-09 James Robinson <jamesr@chromium.org>

Unreviewed. Update Chromium GPU test expecations for canvas/philip.

  • platform/chromium-gpu/test_expectations.txt:
8:06 PM Changeset in webkit [73679] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-12-09 Jasmin Lapalme <jlapalme@druide.com>

Reviewed by Alexey Proskuryakov.

Test for a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT transformation.
https://bugs.webkit.org/show_bug.cgi?id=50708

  • fast/xsl/utf8-chunks-expected.txt: Added.
  • fast/xsl/utf8-chunks.xml: Added.
  • fast/xsl/utf8-chunks.xsl: Added.

2010-12-09 Jasmin Lapalme <jlapalme@druide.com>

Reviewed by Alexey Proskuryakov.

Fix a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT transformation.
https://bugs.webkit.org/show_bug.cgi?id=50708

Test: fast/xsl/utf8-chunks.xml

  • xml/XSLTProcessorLibxslt.cpp: (WebCore::writeToVector): now converts and returns the correct byte count when the end of the chunk is in the middle of a multibyte UTF-8 character.
7:56 PM Changeset in webkit [73678] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-09 Vincent Scheib <scheib@chromium.org>

Reviewed by James Robinson.

Clip update rectangle for Texture::updateSubRect to texture size
https://bugs.webkit.org/show_bug.cgi?id=49929

Test: fast/canvas/canvas-largedraws.html

  • platform/graphics/gpu/Texture.cpp: (WebCore::Texture::updateSubRect):

2010-12-09 Vincent Scheib <scheib@chromium.org>

Reviewed by James Robinson.

Clip update rectangle for Texture::updateSubRect to texture size
https://bugs.webkit.org/show_bug.cgi?id=49929

  • fast/canvas/canvas-largedraws-expected.txt: Added.
  • fast/canvas/canvas-largedraws.html: Added.
7:36 PM Changeset in webkit [73677] by jocelyn.turcotte@nokia.com
  • 8 edits in trunk/WebKit2

2010-12-09 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Use a single QNetworkAccessManager per web process.
https://bugs.webkit.org/show_bug.cgi?id=50757

This allows a better management of network resources and the use
of global cookie jar and disk cache across all frames.

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp: (WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext): (WebCore::WebFrameNetworkingContext::networkAccessManager):
  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::initializeWebProcess): (WebKit::WebProcess::shutdownIfPossible):
  • WebProcess/WebProcess.h: (WebKit::WebProcess::networkAccessManager):
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown):
  • WebProcess/qt/WebProcessQt.cpp: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown):
6:53 PM Changeset in webkit [73676] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Fix the 32-bit build.

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::sizeForNumberType):

6:45 PM Changeset in webkit [73675] by mjs@apple.com
  • 2 edits in trunk/WebKit2

2010-12-09 Maciej Stachowiak <mjs@apple.com>

Reviewed by Brady Eidson.

WebKit2: Control-click doesn't invoke context menu
https://bugs.webkit.org/show_bug.cgi?id=50793
<rdar://problem/8664800>

  • WebProcess/WebPage/WebPage.cpp: (WebKit::isContextClick): New helper function - on Mac, not only right clicks but also control-left-clicks are context clicks. (WebKit::handleMouseEvent): Use above.
6:45 PM Changeset in webkit [73674] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-12-09 Kenneth Russell <kbr@google.com>

Unreviewed. Another speculative Gtk build fix after r73669. Add
needed derived sources to GNUmakefile.am.

  • GNUmakefile.am:
6:43 PM Changeset in webkit [73673] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-09 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Group canvas/philip failures together, fix some expectations (many tests
that were marked as flaky actually fail consistently).

  • platform/chromium/test_expectations.txt:
6:33 PM Changeset in webkit [73672] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-12-09 Kenneth Russell <kbr@google.com>

Unreviewed. Speculative Gtk build fix after
https://bugs.webkit.org/show_bug.cgi?id=36512 / r73669. Process
all of the WebGL classes' IDL files.

  • CMakeLists.txt:
6:00 PM Changeset in webkit [73671] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Fix clang++ build.

  • Scripts/webkit2/messages.py:

DrawingAreaInfo is a struct.

  • Shared/WebPreferencesStore.cpp:

(WebKit::valueForKey):
Move valueForKey above code that uses it.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WebInspectorProxyObjCAdapter windowWillClose:]):
Remove trailing semicolon.

5:59 PM Changeset in webkit [73670] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-09 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Was overly aggressive with r73661, canvas/philip/tests/
toDataURL.jpeg.alpha.html still fails.

  • platform/chromium/test_expectations.txt:
5:58 PM Changeset in webkit [73669] by zmo@google.com
  • 17 edits
    2 adds in trunk

2010-12-09 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Expose constructor functions for instanceof checks of WebGL objects
https://bugs.webkit.org/show_bug.cgi?id=36512

Test: fast/canvas/webgl/instanceof-test.html

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::webGLActiveInfoEnabled): (WebCore::RuntimeEnabledFeatures::webGLBufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLFramebufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLProgramEnabled): (WebCore::RuntimeEnabledFeatures::webGLRenderbufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLShaderEnabled): (WebCore::RuntimeEnabledFeatures::webGLTextureEnabled): (WebCore::RuntimeEnabledFeatures::webGLUniformLocationEnabled):
  • html/canvas/WebGLActiveInfo.idl: Remove OmitConstructor.
  • html/canvas/WebGLBuffer.idl: Ditto.
  • html/canvas/WebGLFramebuffer.idl: Ditto.
  • html/canvas/WebGLProgram.idl: Ditto.
  • html/canvas/WebGLRenderbuffer.idl: Ditto.
  • html/canvas/WebGLShader.idl: Ditto.
  • html/canvas/WebGLTexture.idl: Ditto.
  • html/canvas/WebGLUniformLocation.idl: Ditto.
  • page/DOMWindow.idl: Expose constructors for WebGL objects in DOMWindow.

2010-12-09 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Expose constructor functions for instanceof checks of WebGL objects
https://bugs.webkit.org/show_bug.cgi?id=36512

  • fast/canvas/webgl/instanceof-test-expected.txt: Added.
  • fast/canvas/webgl/instanceof-test.html: Added.
  • fast/dom/Window/script-tests/window-property-descriptors.js: Register newly added WebGL objects.
  • fast/dom/Window/window-properties.html: Ditto.
  • fast/dom/script-tests/prototype-inheritance-2.js: Ditto. (constructorNamesForWindow):
  • fast/dom/script-tests/prototype-inheritance.js: Ditto.
  • fast/js/script-tests/global-constructors.js: Ditto.
5:54 PM Changeset in webkit [73668] by andersca@apple.com
  • 6 edits in trunk

Cannot use NSKeyedArchiver in WK2 for ResourceResponses
https://bugs.webkit.org/show_bug.cgi?id=50792
<rdar://problem/8741799>

Reviewed by Sam Weinig.

WebKit2:

When encoding, first convert the requests and responses to the serializable dictionary representation
and use the newly added CF CoreIPC encoders. When decoding, do the opposite.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):
(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
5:53 PM Changeset in webkit [73667] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix a bug uncovered by clang++.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):

5:51 PM Changeset in webkit [73666] by timothy@apple.com
  • 14 edits in trunk

WebCore: Export Color::white and Color::transparent.

Reviewed by Anders Carlsson.

  • WebCore.exp.in:

WebKit2: Add support for transparent WebKit2 WKViews.

https://webkit.org/b/50785

Reviewed by Anders Carlsson.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode): Encode drawsBackground and drawsTransparentBackground.
(WebKit::WebPageCreationParameters::decode): Decode drawsBackground and drawsTransparentBackground.

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView setDrawsBackground:]): Added.
(-[WKView drawsBackground]): Added.
(-[WKView setDrawsTransparentBackground:]): Added.
(-[WKView drawsTransparentBackground]): Added.
(-[WKView drawRect:]): Only fill the background if the WebProcess isn't valid and drawsBackground.
Use white or clear based on setDrawsTransparentBackground.
(-[WKView isOpaque]): Return drawsBackground.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Initialize m_drawsBackground and m_drawsTransparentBackground.
(WebKit::WebPageProxy::setDrawsBackground): Added. Send a SetDrawsBackground message.
(WebKit::WebPageProxy::setDrawsTransparentBackground): Added. Send a SetDrawsTransparentBackground message.
(WebKit::WebPageProxy::creationParameters): Set drawsBackground and drawsTransparentBackground.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::drawsBackground): Added. Return m_drawsBackground.
(WebKit::WebPageProxy::drawsTransparentBackground): Added. Return m_drawsTransparentBackground.

  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:

(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint): Use the copy blend mode when drawing a background.
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore): Use the copy blend mode to replace existing content.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Setup the new view's background color and transparent flag.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialize m_drawsBackground and m_drawsTransparentBackground.
(WebKit::WebPage::setDrawsBackground): Added. Propagate the flag to the FrameViews.
(WebKit::WebPage::setDrawsTransparentBackground): Added. Propagate the background color to the FrameViews.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::drawsBackground): Added. Return m_drawsBackground.
(WebKit::WebPage::drawsTransparentBackground): Added. Return m_drawsTransparentBackground.

  • WebProcess/WebPage/WebPage.messages.in: Added SetDrawsBackground and SetDrawsTransparentBackground.
5:49 PM Changeset in webkit [73665] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix failing Mac tests.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scroll): Don't smooth scroll if the default
AppleScrollAnimationEnabled is false.

5:49 PM Changeset in webkit [73664] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

Clang++ build fixes.

Silence a couple of warnings.

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

  • WebView/WebTextCompletionController.mm:

(-[WebTextCompletionController filterKeyDown:]):

5:45 PM Changeset in webkit [73663] by jamesr@google.com
  • 22 edits
    13 adds in trunk

2010-12-09 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Compositor needs to manage its VRAM use
https://bugs.webkit.org/show_bug.cgi?id=49629

Adds a few tests involving lots of visible image layers. The tests are designed
to require slightly more than 64MB of VRAM.

  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.png: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.png: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.txt: Added.
  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/compositing/lots-of-img-layers-with-opacity.html: Added.
  • platform/chromium/compositing/lots-of-img-layers.html: Added.
  • platform/chromium/test_expectations.txt:

2010-12-09 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Compositor needs to manage its VRAM use
https://bugs.webkit.org/show_bug.cgi?id=49629

This adds a basic texture manager to the Chromium compositor to limit the amount of VRAM
used by compositor textures and switches ContentLayerChromium, ImageLayerChromium, and
RenderSurfaceChromium to use managed LayerTexture. The other *LayerChromium classes (Canvas,
Video, and WebGL) and the root layer are still unmanaged.

The TextureManager works by providing tokens to callers that want to use a managed texture.
The token can be used to request a texture, see if the previously requested texture is still
available, and to protect/unprotect textures when they cannot be collected. Whenever a
texture is created the manager attempts to free up the least recently used textures until the
total memory use is below the provided threshhold. If the manager cannot satisfy the memory
limit it will not return any new textures until some old textures are released.

A LayerTexture wraps a TextureManager token, size, and format. A LayerChromium can check if a
previously requested texture is still available for use and reserve the LayerTexture's underlying
storage between the updateContentsIfDirty() and the draw() call.

Also changes LayerChromium from having separate contentsDirty()/updateContents() calls to a single
updateContentsIfDirty().

Tests: platform/chromium/compositing/lots-of-img-layers-with-opacity.html

platform/chromium/compositing/lots-of-img-layers.html

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::updateContentsIfDirty): (WebCore::LayerChromium::draw):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::useShader): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::updateRootLayerTextureRect): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::getFramebufferPixels): (WebCore::LayerRendererChromium::createLayerTexture): (WebCore::LayerRendererChromium::deleteLayerTexture): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect): (WebCore::LayerRendererChromium::setDrawViewportRect): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::renderSurfaceSharedValues): (WebCore::LayerRendererChromium::textureManager):
  • platform/graphics/chromium/LayerTexture.cpp: Added. (WebCore::LayerTexture::LayerTexture): (WebCore::LayerTexture::~LayerTexture): (WebCore::LayerTexture::isValid): (WebCore::LayerTexture::reserve): (WebCore::LayerTexture::unreserve): (WebCore::LayerTexture::bindTexture): (WebCore::LayerTexture::framebufferTexture2D):
  • platform/graphics/chromium/LayerTexture.h: Added. (WebCore::LayerTexture::create):
  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/PluginLayerChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::SharedValues::SharedValues): (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues): (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::cleanupResources): (WebCore::RenderSurfaceChromium::prepareContentsTexture): (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.h: (WebCore::RenderSurfaceChromium::SharedValues::shaderProgram): (WebCore::RenderSurfaceChromium::SharedValues::shaderSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::shaderMatrixLocation): (WebCore::RenderSurfaceChromium::SharedValues::shaderAlphaLocation): (WebCore::RenderSurfaceChromium::SharedValues::initialized):
  • platform/graphics/chromium/TextureManager.cpp: Added. (WebCore::memoryUseBytes): (WebCore::TextureManager::TextureManager): (WebCore::TextureManager::getToken): (WebCore::TextureManager::releaseToken): (WebCore::TextureManager::hasTexture): (WebCore::TextureManager::protectTexture): (WebCore::TextureManager::unprotectTexture): (WebCore::TextureManager::reduceMemoryToLimit): (WebCore::TextureManager::addTexture): (WebCore::TextureManager::removeTexture): (WebCore::TextureManager::requestTexture):
  • platform/graphics/chromium/TextureManager.h: Added. (WebCore::TextureManager::create):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/WebGLLayerChromium.h:
5:31 PM Changeset in webkit [73662] by andersca@apple.com
  • 4 edits
    3 adds in trunk/WebKit2

[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572

Patch by Philippe Normand <pnormand@igalia.com> on 2010-12-06
Reviewed by Martin Robinson.

  • configure.ac: new configure flag to disable the new Javascript

Fullscreen API build. It is enabled by default.

5:29 PM Changeset in webkit [73661] by mihaip@chromium.org
  • 2 edits
    15 deletes in trunk/LayoutTests

2010-12-09 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Delete a bunch of chromium-win specific baselines that were added by
r68608. That was done because r68568 checked in failing expectations,
but since Chromium was passing the tests with Skia, we wanted to keep
passing them. However, the failing expectations were rolled out by
r68737, so we no longer needed Chromium-specific expectations.

Later, with r71481 we updated to a new version of the Philip test suite,
which has a different output format, and the Chromium-specific
expectations were out of date. Since they're not needed (we should pass
with the base ones), they can just be deleted.

  • platform/chromium-mac/canvas/philip/tests/2d.drawImage.null-expected.txt: Removed.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.null-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.drawImage.null-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.line.cap.closed-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.line.join.parallel-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.pattern.image.null-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Removed.
  • platform/chromium-win/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
5:06 PM Changeset in webkit [73660] by Darin Adler
  • 5 edits in trunk/WebCore

Rework my recent setLocation refactoring to use DOMWindow instead of Frame.
It's difficult to make correct security decisions based on Frame since a
Frame can navigate to a new document.

Reviewed by Sam Weinig.

Fixes some test failures that I somehow missed before the last check-in.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Call to the
shell DOMWindow; not sure this one matters, but it's closer to the old
code before my last patch. Also pass the DOMWindow rather than the
frame to crossDomainAccessErrorMessage.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setLocation): Pass DOMWindow rather than Frame
to the DOMWindow::setLocation function.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::setLocation): Take DOMWindow rather than Frame.
(WebCore::DOMWindow::crossDomainAccessErrorMessage): Ditto.

  • page/DOMWindow.h: Update new functions to take DOMWindow rather

than Frame.

4:56 PM Changeset in webkit [73659] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-09 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Remove test_expectations.txt entries for 4 Philip suite canvas tests
that pass consistently on all bots. 2d.drawImage.incomplete.html was
fixed by r71292, the rest have been passing for as long as we have
history in the Chromium test dashboard.

  • platform/chromium/test_expectations.txt:
4:28 PM Changeset in webkit [73658] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

4:26 PM Changeset in webkit [73657] by mrowe@apple.com
  • 1 copy in tags/Safari-534.14

New tag.

3:47 PM Changeset in webkit [73656] by weinig@apple.com
  • 2 edits in trunk/WebCore

Try and fix the mac build.

  • WebCore.exp.in:
3:24 PM Changeset in webkit [73655] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

Mark a test as timing out on Win Debug.

  • platform/chromium/test_expectations.txt:
3:22 PM Changeset in webkit [73654] by dpranke@chromium.org
  • 7 edits in trunk/WebKitTools

2010-12-09 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

Make new-run-webkit-tests --lint-test-files log slightly better
messages and return -1 if lint fails. Remove the
'suppress_errors' keyword param to the TestExpectationsFile
class, and clean up logging and exception raising for error
handling. Also add more unit tests and clean up the unit test code a bit.

https://bugs.webkit.org/show_bug.cgi?id=50205

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3:02 PM Changeset in webkit [73653] by mitz@apple.com
  • 2 edits in trunk/WebCore

Removed an unused variable.

Reviewed by Dave Hyatt.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights): Removed parentLineHeight.

2:35 PM Changeset in webkit [73652] by beidson@apple.com
  • 2 edits in trunk/WebKit2

<rdar://problem/8749750> and https://bugs.webkit.org/show_bug.cgi?id=50786
WK2 authentication never consults WebCore session credential storage.

Reviewed by Sam Weinig.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Since we don't need to expose this as

API at this time, always return true.

2:32 PM Changeset in webkit [73651] by pkasting@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

Rebaseline a Linux test.

  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/chromium/test_expectations.txt:
2:31 PM Changeset in webkit [73650] by weinig@apple.com
  • 2 edits in trunk/WebKit2

WebKit2: Add support for access keys
https://bugs.webkit.org/show_bug.cgi?id=49832

Reviewed by Alexey Proskuryakov.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleKeyEvent): Match windows WebKit and call
the event handler's for handleAccessKey function for
system keys. This will never be hit on the Mac.

2:30 PM Changeset in webkit [73649] by Darin Adler
  • 2 edits in trunk/WebKit2

Qt build fix.

  • WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Include "NotImplemented.h".
2:29 PM Changeset in webkit [73648] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Fix date.

2:24 PM Changeset in webkit [73647] by Darin Adler
  • 6 edits in trunk/WebCore

2010-12-08 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
https://bugs.webkit.org/show_bug.cgi?id=50640

  • bindings/js/JSDOMBinding.cpp: (WebCore::printErrorMessageForFrame): Removed body; just call through to DOMWindow::printErrorMessage.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body; just call through to DOMWindow::crossDomainAccessErrorMessage.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFrame and firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most of the body and moved it into DOMWindow::setLocation.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): Added. Does all the same work that JSDOMWindow::setLocation used to do, but in a way that's not specific to JavaScript. (WebCore::DOMWindow::printErrorMessage): Added. (WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.
  • page/DOMWindow.h: Added setLocation, printErrorMessage, and crossDomainAccessErrorMessage.
2:17 PM Changeset in webkit [73646] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.

  • WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp:
1:49 PM Changeset in webkit [73645] by hyatt@apple.com
  • 2 edits in trunk/WebKit/mac

https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
writing-mode. This first part of the patch just patches Mac WebKit 1 views.

Reviewed by Dan Bernstein.

  • WebView/WebFrameView.mm:

(-[WebFrameView _isVerticalDocument]):
(-[WebFrameView _isFlippedDocument]):
(-[WebFrameView _scrollToEndOfDocument]):
(-[WebFrameView _pageInBlockProgressionDirection:]):
(-[WebFrameView scrollPageUp:]):
(-[WebFrameView scrollPageDown:]):

1:47 PM Changeset in webkit [73644] by weinig@apple.com
  • 3 edits
    1 move in trunk/WebCore

WebKit2 needs smooth scrolling support on the mac
<rdar://problem/8219402>

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj: Change ScrollAnimatorMac.cpp to ScrollAnimatorMac.mm.
  • platform/mac/ScrollAnimatorMac.cpp: Removed.
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm: Copied from platform/mac/ScrollAnimatorMac.cpp.

(-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollAnimationHelperDelegate bounds]):
(-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
(-[ScrollAnimationHelperDelegate convertSizeToBase:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
(-[ScrollAnimationHelperDelegate superview]):
(-[ScrollAnimationHelperDelegate documentView]):
(-[ScrollAnimationHelperDelegate window]):
(-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::setScrollPositionAndStopAnimation):
(WebCore::ScrollAnimatorMac::currentPosition):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Add implementation of ScrollAnimator for the Mac.

1:12 PM Changeset in webkit [73643] by beidson@apple.com
  • 8 edits
    3 adds in trunk

<rdar://problem/8613779> and https://bugs.webkit.org/show_bug.cgi?id=50777
WebKit2 ContextMenuClient support

Reviewed by Anders Carlsson.

WebCore:

Export some symbols and headers needed by WebKit2 Mac:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

WebKit2:

Implement google search in a cross platform manner, and add a FIXME for download support:

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::downloadURL):
(WebKit::WebContextMenuClient::searchWithGoogle):

Mac implementations for speaking and searching:

  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm: Added.

(WebKit::WebContextMenuClient::lookUpInDictionary): Add a FIXME for now.
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):
(WebKit::WebContextMenuClient::searchWithSpotlight):

Stubs for Win and Qt:

  • WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Added.

(WebKit::WebContextMenuClient::lookUpInDictionary):
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):

  • WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp: Added.

(WebKit::WebContextMenuClient::lookUpInDictionary):
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):

Project file stuffs:

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
1:10 PM Changeset in webkit [73642] by commit-queue@webkit.org
  • 9 edits in trunk

2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73635.
http://trac.webkit.org/changeset/73635
https://bugs.webkit.org/show_bug.cgi?id=50778

'Side-effects on 3 css tests needs closer review' (Requested
by mwenge on #webkit).

  • platform/qt/Skipped:

2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73635.
http://trac.webkit.org/changeset/73635
https://bugs.webkit.org/show_bug.cgi?id=50778

'Side-effects on 3 css tests needs closer review' (Requested
by mwenge on #webkit).

  • platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintSearchField): (WebCore::RenderThemeQt::adjustSearchFieldStyle): (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
  • platform/qt/RenderThemeQt.h:

2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73635.
http://trac.webkit.org/changeset/73635
https://bugs.webkit.org/show_bug.cgi?id=50778

'Side-effects on 3 css tests needs closer review' (Requested
by mwenge on #webkit).

  • Api/qwebsettings.cpp: (graphics):
  • Api/qwebsettings.h:
1:06 PM Changeset in webkit [73641] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-12-09 Alex Bredariol Grilo <abgrilo@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Add missing function in WebKit-EFL API

Add ewk_tiled_backing_store_zoom_weak_smooth_scale_set function in
WebKit-EFL API. This function was already implemented but missing in
header file.

  • ewk/ewk_tiled_backing_store.h:
1:06 PM Changeset in webkit [73640] by msaboff@apple.com
  • 5 edits in trunk

2010-12-09 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

REGRESSION (r73065?): A regex no longer works
https://bugs.webkit.org/show_bug.cgi?id=50570

Changed the handling of adjacent parentheses backtracks in two ways.
First, only outer most paren backtracks default to back tracking
to the "next character" looping code. Second, added a jump around
backtracks that fall through to the next backtrack where the
second backtrack has some greedy processing before the backtracking
from outside the parentheses code.
Also cleaned up extraneous white spce, removing white space at the
end of or that makes up a whole line.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::GenerationState::GenerationState): (JSC::Yarr::RegexGenerator::GenerationState::incrementParenNestingLevel): (JSC::Yarr::RegexGenerator::GenerationState::decrementParenNestingLevel): (JSC::Yarr::RegexGenerator::GenerationState::addParenthesesTail): (JSC::Yarr::RegexGenerator::GenerationState::emitParenthesesTail): (JSC::Yarr::RegexGenerator::ParenthesesTail::ParenthesesTail): (JSC::Yarr::RegexGenerator::ParenthesesTail::setNextIteration): (JSC::Yarr::RegexGenerator::ParenthesesTail::generateCode): (JSC::Yarr::RegexGenerator::generateParenthesesSingle):

2010-12-09 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

REGRESSION (r73065?): A regex no longer works
https://bugs.webkit.org/show_bug.cgi?id=50570

Added tests that came from submitter to validate change.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
12:57 PM Changeset in webkit [73639] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
12:56 PM Changeset in webkit [73638] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-09 Tony Chang <tony@chromium.org>

Unreviewed, fix for windows code. We were catching the wrong
exception in Windows.

  • Scripts/webkitpy/common/system/filesystem.py:
12:51 PM Changeset in webkit [73637] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk/LayoutTests

2010-12-09 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Barth.

Rebaseline svg/custom/text-linking.svg
https://bugs.webkit.org/show_bug.cgi?id=50310

  • platform/chromium/test_expectations.txt:
  • platform/chromium-win/svg/custom/text-linking-expected.checksum: Added.
  • platform/chromium-win/svg/custom/text-linking-expected.png: Added.
  • platform/chromium-win/svg/custom/text-linking-expected.txt: Added.
  • platform/mac-leopard/svg/custom/text-linking-expected.checksum: Updated.
  • platform/mac-leopard/svg/custom/text-linking-expected.png: Updated.
12:09 PM Changeset in webkit [73636] by pkasting@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
11:54 AM Changeset in webkit [73635] by robert@webkit.org
  • 9 edits in trunk

2010-12-09 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Search input field doesn't have cancel button
Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.

Unskip a bunch of search field related tests that pass now:

fast/forms/search-cancel-button-mouseup.html
fast/forms/search-rtl.html
fast/forms/search-abs-pos-cancel-button.html
fast/forms/search-styled.html
fast/forms/search-transformed.html
fast/forms/search-zoomed.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-display-none-cancel-button.html
fast/forms/search-placeholder-value-changed.html
fast/repaint/search-field-cancel.html
fast/forms/search-cancel-button-events.html

https://bugs.webkit.org/show_bug.cgi?id=42887

  • platform/qt/Skipped:

2010-12-09 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Search input field doesn't have cancel button

Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.

https://bugs.webkit.org/show_bug.cgi?id=42887

  • platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintSearchField): (WebCore::RenderThemeQt::adjustSearchFieldStyle): (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeQt::convertToPaintingRect): (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
  • platform/qt/RenderThemeQt.h:

2010-12-09 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Search input field doesn't have cancel button

Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.

https://bugs.webkit.org/show_bug.cgi?id=42887

  • Api/qwebsettings.cpp: (graphics):
  • Api/qwebsettings.h:
11:45 AM QtWebKitFeatures21 edited by Ademar Reis
(diff)
11:36 AM Changeset in webkit [73634] by yael.aharon@nokia.com
  • 3 edits
    2 adds in trunk

2010-12-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Crash when handling iframe of size 0.
https://bugs.webkit.org/show_bug.cgi?id=50730

  • fast/spatial-navigation/snav-hidden-iframe-zero-size-expected.txt: Added.
  • fast/spatial-navigation/snav-hidden-iframe-zero-size.html: Added.

2010-12-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Crash when handling iframe of size 0.
https://bugs.webkit.org/show_bug.cgi?id=50730

if we have a frame of size 0, we would get into infinite loop and eventually crash. The reason is
that when the algorithm sees a starting rect of size 0, it assumes that there is no focused node,
thus restarts itself. The solution is to avoid considering iframes with size 0 for the spatial
navigation algorithm.

Test: fast/spatial-navigation/snav-hidden-iframe-zero-size.html

  • page/FocusController.cpp: (WebCore::updateFocusCandidateIfNeeded):
11:35 AM Changeset in webkit [73633] by hans@chromium.org
  • 16 edits in trunk

2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73616.
http://trac.webkit.org/changeset/73616
https://bugs.webkit.org/show_bug.cgi?id=50772

Breaks chromium win build (Requested by hwennborg on #webkit).

  • public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey):
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::number):

2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73616.
http://trac.webkit.org/changeset/73616
https://bugs.webkit.org/show_bug.cgi?id=50772

Breaks chromium win build (Requested by hwennborg on #webkit).

  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue):
  • bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls):
  • storage/IDBKey.h: (WebCore::IDBKey::create): (WebCore::IDBKey::number):

2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73616.
http://trac.webkit.org/changeset/73616
https://bugs.webkit.org/show_bug.cgi?id=50772

Breaks chromium win build (Requested by hwennborg on #webkit).

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-cursor.html:
11:28 AM Changeset in webkit [73632] by bweinstein@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Land failing expected results for editing tests that have been failing since they were
added in r73548.

Fixing the failures is being tracked by: https://bugs.webkit.org/show_bug.cgi?id=50731.

  • platform/win/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/win/editing/selection/caret-rtl-2-left-expected.txt: Added.
  • platform/win/editing/selection/caret-rtl-right-expected.txt: Added.
11:17 AM Changeset in webkit [73631] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Don't leak the PDFDocument
https://bugs.webkit.org/show_bug.cgi?id=50771

Reviewed by Sam Weinig.

  • UIProcess/API/mac/PDFViewController.mm:

(WebKit::PDFViewController::setPDFDocumentData):

10:58 AM Changeset in webkit [73630] by andersca@apple.com
  • 5 edits
    1 copy
    1 add in trunk/WebKit2

Add a basic implementation of PDF support on Mac
https://bugs.webkit.org/show_bug.cgi?id=50768

Reviewed by Sam Weinig.

  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm: Added.

(-[WKPDFView initWithFrame:PDFViewController:WebKit::]):
Setup the view hierarchy.

(-[WKPDFView invalidate]):
Set the controller to null.

(-[WKPDFView pdfView]):
Return the PDF view.

(WebKit::PDFViewController::create):
(WebKit::PDFViewController::PDFViewController):
Create a WKPDFView and insert it as a subview of the WKView.

(WebKit::PDFViewController::~PDFViewController):
Remove the WKPDFView from the view hierarchy and invalidate it.

(WebKit::convertPostScriptDataSourceToPDF):
Convert the data in the data reference to PDF and return it as a CFDataRef.

(WebKit::PDFViewController::setPDFDocumentData):
Create a PDFDocument and set it on the PDF view.

(WebKit::PDFViewController::pdfDocumentClass):
(WebKit::PDFViewController::pdfPreviewViewClass):
(WebKit::PDFViewController::pdfKitBundle):
Add soft-linking helper functions.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
Call the WKView methods.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPageHasCustomRepresentation:]):
Create a PDF view controller if necessary.

(-[WKView _didFinishLoadingDataForCustomRepresentation:CoreIPC::]):
Pass the data along to the PDF view controller.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

10:54 AM Changeset in webkit [73629] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

2010-12-09 Antonio Gomes <agomes@rim.com>

Rubber stamped by Gustavo Noronha.

Buildfix for GTK+ with building with -no-video.

paintStockIcon static function was implemented under the ENABLE(VIDEO) guard
but used from outside the guard. See RenderThemeGtk::paintSearchFieldResultsDecoration()
and RenderThemeGtk::paintSearchFieldCancelButton() methods.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::getMediaElementFromRenderObject):
10:54 AM Changeset in webkit [73628] by tonikitoo@webkit.org
  • 7 edits
    1 delete in trunk

2010-12-09 Antonio Gomes <agomes@rim.com>

Reviewed by Martin Robinson.

[Gtk] Populate DumpRenderTreeSupportGtk (part IV)
https://bugs.webkit.org/show_bug.cgi?id=48429

WebKit/gtk:
Moved also webkit_worker_thread_count() to DumpRenderTreeSupportGtk,
since it was only used by DRT for now.

Since this method was the only one in webkitworker.cpp, the file was
also removed.

  • GNUmakefile.am:
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::workerThreadCount):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • webkit/webkitprivate.h:
  • webkit/webkitworkers.cpp: Removed.

WebKitTools/DumpRenderTree/gtk:
Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::workerThreadCount):
10:53 AM Changeset in webkit [73627] by tonikitoo@webkit.org
  • 3 edits in trunk/WebCore

2010-12-07 Antonio Gomes <agomes@rim.com>

Reviewed by Daniel Bates.

Spatial Navigation: code clean up
https://bugs.webkit.org/show_bug.cgi?id=50666

Patch unifies two FocusCandidate constructors, making caller sites
simpler. Now the special handling HTMLAreaElement gets is done within
the non default constructor (i.e. FocusCanditate(Node*, FocusDirection)).

No new tests needed.

  • page/FocusController.cpp: (WebCore::FocusController::findFocusCandidateInContainer):
  • page/SpatialNavigation.cpp: (WebCore::FocusCandidate::FocusCandidate):
10:49 AM Changeset in webkit [73626] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-12-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] disable fullscreen on MacOS Tiger and Leopard
https://bugs.webkit.org/show_bug.cgi?id=50748

Don't support fullscreen video on Tiger and Leopard, just like the
QTKit player.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::supportsFullscreen):
10:37 AM Changeset in webkit [73625] by andersca@apple.com
  • 20 edits in trunk/WebKit2

Add support for custom representation
https://bugs.webkit.org/show_bug.cgi?id=50767

Reviewed by Sam Weinig.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add mimeTypesWithCustomRepresentation and encode and decode accordingly.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
Add empty stubs for now.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::didCommitLoadForMainFrame):
(QWKPagePrivate::didFinishLoadingDataForCustomRepresentation):

  • UIProcess/API/qt/qwkpage_p.h:

Add empty stubs.

  • UIProcess/PageClient.h:

Add new functions for custom representations.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canShowMIMEType):
Check that the mime type is not null.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):
This now takes an additional frameHasCustomRepresentation parameter.
Call the page client function.

(WebKit::WebPageProxy::didFinishLoadingDataForCustomRepresentation):
Call the page client function.

  • UIProcess/WebPageProxy.messages.in:

Change DidCommitLoadForFrame message, add DidFinishLoadingDataForCustomRepresentation message.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
We want to use custom representations for PDF and PostScript MIME types.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame):
(WebKit::WebView::didFinishLoadingDataForCustomRepresentation):

  • UIProcess/win/WebView.h:

Add stubs.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
Initialize m_frameHasCustomRepresentation.

(WebKit::WebFrameLoaderClient::hasHTMLView):
The frame has a HTML view unless it has a custom representation.

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
Pass along whether the frame has a custom representation.

(WebKit::WebFrameLoaderClient::committedLoad):
Don't send data back to WebCore if the frame has a custom representation.

(WebKit::WebFrameLoaderClient::finishedLoading):
Send all the data to the UI process.

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Update the m_frameHasCustomRepresentation state based on the MIME type.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebKit::WebFrameLoaderClient::frameHasCustomRepresentation):
Add getter.

  • WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp:

(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
Don't do any painting if the main frame has a custom representation.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Add all the MIME types with custom representations.

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::shouldUseCustomRepresentationForMIMEType):
Add getter.

10:31 AM Changeset in webkit [73624] by Philippe Normand
  • 15 edits in trunk

2010-12-06 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572

  • configure.ac: new configure flag to disable the new Javascript Fullscreen API build. It is enabled by default.

WebCore:

Reviewed by Martin Robinson.

[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572

  • GNUmakefile.am: enable the Javascript Fullscreen API feature if it's been requested at configure time.

WebKit/gtk:

Reviewed by Martin Robinson.

[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572

Fullscreen API support. It is controlled at runtime using a new
setting called enable-fullscreen, set to FALSE by default.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::supportsFullScreenForElement): (WebKit::ChromeClient::enterFullScreenForElement): (WebKit::ChromeClient::exitFullScreenForElement):
  • WebCoreSupport/ChromeClientGtk.h:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings):

WebKitTools:

Reviewed by Martin Robinson.

[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572

Enable the Javascript Fullscreen support in the GtkLauncher. Also
make DRT update the Chrome when the WebView settings have been
reset to consistent values.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • GtkLauncher/main.c: (create_window):
  • Scripts/build-webkit:

LayoutTests:

Reviewed by Martin Robinson.

[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572

  • platform/gtk/Skipped: Unskip now passing fullscreen tests.
10:27 AM Changeset in webkit [73623] by msaboff@apple.com
  • 6 edits
    3 adds in trunk

2010-12-09 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Addressed the "FIXME" issues in array sort for toString() methods that
mutate the array in either size or contents. The change is to mark
the temporary array contents so that they are not garbage collected
and to make sure the array is large enough to hold the contents
of the sorted temporary vector.
https://bugs.webkit.org/show_bug.cgi?id=50718

  • runtime/Collector.cpp: (JSC::Heap::addTempSortVector): (JSC::Heap::removeTempSortVector): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/Collector.h:
  • runtime/JSArray.cpp: (JSC::JSArray::sort):
  • runtime/JSValue.h:

2010-12-09 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

New test to verify that arrays sort per the standard even it
there is an override for toString() that modifies the array.
https://bugs.webkit.org/show_bug.cgi?id=50718

  • fast/js/array-sort-modifying-tostring-expected.txt: Added.
  • fast/js/array-sort-modifying-tostring.html: Added.
  • fast/js/script-tests/array-sort-modifying-tostring.js: Added. (do_gc): (Item): (toString_Mutate): (test):
10:26 AM Changeset in webkit [73622] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-09 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Check the return value of ImageBuffer::create()
to avoid crash when ImageBuffer::create() fails.
https://bugs.webkit.org/show_bug.cgi?id=50631

No new test because it relies on the platform implementation
of ImageBuffer. It is hard to make ImageBuffer::create() fail
in most ports.

  • platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
10:07 AM Changeset in webkit [73621] by mjs@apple.com
  • 6 edits in trunk

2010-12-09 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Implement "Use Selection for Find" in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50737
<rdar://problem/8564881>

Implement a TakeFindStringFromSelection editor command. This is
used solely to implement the "Use Selection for Find" menu command
on Mac, and is not made available to script. On WebKit2, it is
very convenient to reuse the editing machinery since this command
is very similar to Copy.

  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeTakeFindStringFromSelection): Call to a mac-only Editor function. (WebCore::enabledTakeFindStringFromSelection): Check using Editor::canCopyExcludingStandaloneImage (WebCore::createCommandMap): Add "TakeFindStringFromSelection" command.
  • editing/mac/EditorMac.mm: (WebCore::Editor::canCopyExcludingStandaloneImages): Helper function; we can't use Editor::canCopy since it would make no sense to enable "Use Selection for Find" when viewing a standalone image document. (WebCore::Editor::takeFindStringFromSelection): Implement by copying the selected text to the special Find pasteboard.

2010-12-09 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Implement "Use Selection for Find" in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50737
<rdar://problem/8564881>


  • UIProcess/API/mac/WKView.mm: Add support for the takeFindStringFromSelection: selector as a command.
9:51 AM Changeset in webkit [73620] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-09 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

As part of r73559, I added the referenceNode check to validate whether the root
node of the iterator matches the node which is getting moved to other document.
referenceNode is initialized to root, however can get moved using previousNode
and nextNode methods, so it is required to use root directly.
https://bugs.webkit.org/show_bug.cgi?id=50764

Test: fast/dom/node-iterator-reference-node-moved-crash.html

  • dom/Document.cpp: (WebCore::Document::moveNodeIteratorsToNewDocument): change referenceNode to root.

2010-12-09 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when we move the referenceNode using node iterator
methods previousNode and nextNode.
https://bugs.webkit.org/show_bug.cgi?id=50764

  • fast/dom/node-iterator-reference-node-moved-crash-expected.txt: Added.
  • fast/dom/node-iterator-reference-node-moved-crash.html: Added.
9:40 AM Changeset in webkit [73619] by xji@chromium.org
  • 2 edits in branches/chromium/597/WebCore

Merge 73586 - Fix regression from xji's wheel scroll patch. The vertical case is looking at the horizontal
maximum position and not the vertical position.

Reviewed by Simon Fraser.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

TBR=hyatt@apple.com

9:31 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
9:23 AM QtWebKitFeatures21 edited by Henry Haverinen
(diff)
9:23 AM Changeset in webkit [73618] by Dimitri Glazkov
  • 22 edits in trunk/WebCore

2010-12-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Provide a generic way to store shadowParent on a Node.
https://bugs.webkit.org/show_bug.cgi?id=50184

This patch makes TreeShared::m_parent act as either parentNode() or
shadowHost() for Node. The distinction is controlled by IsShadowRootFlag.

Refactoring, so no new tests. See performance result testing in bug.

  • dom/Element.cpp: (WebCore::Element::recalcStyle): Changed to use parentOrHostNode().
  • dom/Node.cpp: (WebCore::Node::shadowHost): Added. (WebCore::Node::setShadowHost): Added. (WebCore::Node::isContentEditable): Changed to use parentOrHostNode(). (WebCore::Node::isContentRichlyEditable): Ditto. (WebCore::Node::nextRenderer): Ditto. (WebCore::Node::virtualComputedStyle): Ditto. (WebCore::Node::canStartSelection): Ditto. (WebCore::Node::shadowTreeRootNode): Changed to use parentNodeGuaranteedHostFree(). (WebCore::Node::getEventAncestors): Ditto. (WebCore::Node::defaultEventHandler): Changed to use parentOrHostNode().
  • dom/Node.h: Added an extra flag and adjusted bit counts. (WebCore::Node::isShadowNode): Made non-virtual, switched to use flag. (WebCore::Node::parentNode): Made to recognize flag. (WebCore::Node::parentOrHostNode): Changed to use straight parent() and made const. (WebCore::Node::parentNodeGuaranteedHostFree): Added. (WebCore::Node::shadowParentNode): Made non-virtual and const.
  • editing/TextIterator.cpp: (WebCore::depthCrossingShadowBoundaries): Changed to use parentOrHostNode(); (WebCore::nextInPreOrderCrossingShadowBoundaries): Ditto. (WebCore::previousInPostOrderCrossingShadowBoundaries): Ditto. (WebCore::setUpFullyClippedStack): Ditto. (WebCore::TextIterator::advance): Ditto. (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto.
  • page/DOMSelection.cpp: (WebCore::DOMSelection::anchorNode): Changed to use parentNodeGuaranteedHostFree(). (WebCore::DOMSelection::focusNode): Ditto. (WebCore::DOMSelection::baseNode): Ditto. (WebCore::DOMSelection::extentNode): Ditto. (WebCore::DOMSelection::getRangeAt): Ditto.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):

Changed to setShadowHost().

(WebCore::MediaControlShadowRootElement::updateStyle): Changed to use shadowHost().
(WebCore::MediaControlShadowRootElement::detach): Added an override to

explicitly set shadowHost to 0. Otherwise, the element will leak.

  • rendering/MediaControlElements.h: Added detach def, removed members that are

no longer needed.

  • rendering/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):

Added explicit clearing of shadowHost to avoid leaking and crashes,
because SVG shadow DOM can be dynamically attached/detached, producing
stale nodes in over/out event handling.

  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::defaultEventHandler): Changed to use shadowHost().
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):

Added explicit clearing of shadowHost and explicit destruction to
avoid out-of-order removal of children.

  • rendering/RenderTreeAsText.cpp: (WebCore::nodePosition): Simplified code.
  • rendering/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): Added

setting of shadowHost.

(WebCore::SVGShadowTreeRootElement::attachElement): Changed to use shadowHost().
(WebCore::SVGShadowTreeRootElement::clearShadowHost): Added.

  • rendering/SVGShadowTreeElements.h: Added def, removed members that are

no longer needed.

  • rendering/ShadowElement.cpp: (WebCore::ShadowBlockElement::initAsPart): Changed to use shadowHost().
  • rendering/ShadowElement.h: Removed members that are no longer needed. (WebCore::ShadowElement::ShadowElement): Added setting of shadowHost. (WebCore::ShadowElement::detach): Added.
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): Added setting

of shadowHost.

(WebCore::TextControlInnerElement::attachInnerElement): Changed to use

isShadowNode().

(WebCore::TextControlInnerElement::detach): Added.

  • rendering/TextControlInnerElements.h: Removed members that are no

longer needed.

  • svg/SVGElement.cpp: (WebCore::SVGElement::ownerSVGElement): Simplified code. (WebCore::SVGElement::viewportElement): Ditto.
  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::computeCTM): Ditto.
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title): Ditto.
  • svg/SVGUseElement.cpp: (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
9:18 AM Changeset in webkit [73617] by msaboff@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

2010-12-09 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Changed setting of backtrack labels to not overwrite a prior
label. Where losing prior labe which then reverted back to
next character label.
https://bugs.webkit.org/show_bug.cgi?id=50579

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::BacktrackDestination::setBacktrackToLabel):
9:18 AM Changeset in webkit [73616] by hans@chromium.org
  • 16 edits in trunk

2010-12-09 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674

Update layout tests to use floating-point values for keys.

  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html: Make sure creating the keys works.
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html: Make sure retrieving the keys from the DB objectstore works.

2010-12-09 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674

Use floating point to represent numeric keys,
add version meta data to the SQLite db,
and migrate object stores that use integers.

  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue):
  • bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables): (WebCore::migrateDatabase): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls):
  • storage/IDBKey.h: (WebCore::IDBKey::create): (WebCore::IDBKey::number):

2010-12-09 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674

Represent numeric keys as floating point values.

  • public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey):
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::number):
9:14 AM Changeset in webkit [73615] by msaboff@apple.com
  • 5 edits in trunk

2010-06-28 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Bug 41238 - RegExp performance slow on Dromaeo benchmark

Other javascript engines appear to cache prior results of regular
expression operations.

Suggest adding some sort of caching mechanism to regular expression
processing.

Added a single entry cache of match() results to RegExp class.

Also added performance improvements to UString == operator.
First check the impls for equality. Then get the length of
each of the non-null impls. Next check the sizes for equality.
Then check the data for the case of different impls that point
to the same data (most likely due to substrings from the beginning of
another string). Lastly we check the underlying data for equality.

Refactored Vector<>::operator=() method into a separate copy() method
that it calls. The copy() method is explicitly used for deep copying.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::match):
  • runtime/RegExp.h:
  • runtime/UString.h: (JSC::operator==):
  • wtf/Vector.h: (WTF::::operator): (WTF::::copy):

2010-12-09 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Added test to verify proper operation of backtrack labels.
https://bugs.webkit.org/show_bug.cgi?id=50579

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
8:55 AM Changeset in webkit [73614] by beidson@apple.com
  • 26 edits
    2 adds in trunk

<rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
WebKit2 Authentication Support

Reviewed by Maciej Stachowiak.

WebCore:

  • WebCore.exp.in:

WebKit2:

Implement authentication-related coders:

  • Shared/WebCoreArgumentCoders.h:

Allow the ResourceResponse coders to handle null responses:

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

Add new API and Impl casts for ProtectionSpace and Credential enums:

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toAPI):
(WebKit::toCredentialPersistence):

Move the DecisionListener to be accessed off the challenge itself, and fill in other
necessary API:

  • UIProcess/API/C/WKAuthenticationChallenge.cpp:

(WKAuthenticationChallengeGetDecisionListener):
(WKAuthenticationChallengeGetProtectionSpace):
(WKAuthenticationChallengeGetProposedCredential):
(WKAuthenticationChallengeGetPreviousFailureCount):

  • UIProcess/API/C/WKAuthenticationChallenge.h:
  • UIProcess/Authentication/AuthenticationChallengeProxy.cpp:

(WebKit::AuthenticationChallengeProxy::~AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::proposedCredential):
(WebKit::AuthenticationChallengeProxy::protectionSpace):

  • UIProcess/Authentication/AuthenticationChallengeProxy.h:

(WebKit::AuthenticationChallengeProxy::previousFailureCount):

Fill in some credential API:

  • UIProcess/API/C/WKCredential.cpp:

(WKCredentialCreate):
(WKCredentialCopyUser):

  • UIProcess/API/C/WKCredential.h:
  • UIProcess/API/C/WKCredentialTypes.h: Added.
  • UIProcess/Authentication/WebCredential.cpp:

(WebKit::WebCredential::WebCredential):
(WebKit::WebCredential::user):

  • UIProcess/Authentication/WebCredential.h:

(WebKit::WebCredential::create):

Fill in some protection space API:

  • UIProcess/API/C/WKProtectionSpace.cpp:

(WKProtectionSpaceCopyHost):
(WKProtectionSpaceGetPort):
(WKProtectionSpaceCopyRealm):
(WKProtectionSpaceGetIsProxy):
(WKProtectionSpaceGetServerType):
(WKProtectionSpaceGetReceivesCredentialSecurely):
(WKProtectionSpaceGetAuthenticationScheme):

  • UIProcess/API/C/WKProtectionSpace.h:
  • UIProcess/API/C/WKProtectionSpaceTypes.h: Added.
  • UIProcess/Authentication/WebProtectionSpace.cpp:

(WebKit::WebProtectionSpace::WebProtectionSpace):
(WebKit::WebProtectionSpace::host):
(WebKit::WebProtectionSpace::port):
(WebKit::WebProtectionSpace::realm):
(WebKit::WebProtectionSpace::isProxy):
(WebKit::WebProtectionSpace::serverType):
(WebKit::WebProtectionSpace::receivesCredentialSecurely):
(WebKit::WebProtectionSpace::authenticationScheme):

  • UIProcess/Authentication/WebProtectionSpace.h:

Change the authentication challenge callback to reflect the new ownership of
the DecisionListener:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didReceiveAuthenticationChallengeInFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
8:40 AM Changeset in webkit [73613] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

2010-12-09 Peter Beverloo <peter@lvp-media.com>

Reviewed by Maciej Stachowiak.

Default CSS definitions for the figure and figcaption elements.

  • fast/html/figcaption-element-expected.txt: Added.
  • fast/html/figcaption-element.html: Added.
  • fast/html/figure-element-expected.txt: Added.
  • fast/html/figure-element.html: Added.
  • fast/html/script-tests/figcaption-element.js: Added.
  • fast/html/script-tests/figure-element.js: Added.

2010-12-09 Peter Beverloo <peter@lvp-media.com>

Reviewed by Maciej Stachowiak.

Default CSS definitions for the figure and figcaption elements.

Tests: fast/html/figcaption-element.html

fast/html/figure-element.html

  • css/html.css: (figure): The default figure-style equals a blockquote (figcaption): A non-sectioning block-level element
8:22 AM Changeset in webkit [73612] by yael.aharon@nokia.com
  • 1 edit
    4 adds in trunk/LayoutTests

2010-12-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: more tests.
https://bugs.webkit.org/show_bug.cgi?id=50728

  • fast/spatial-navigation/snav-hidden-focusable-element-expected.txt: Added.
  • fast/spatial-navigation/snav-hidden-focusable-element.html: Added.
  • fast/spatial-navigation/snav-hidden-iframe-expected.txt: Added.
  • fast/spatial-navigation/snav-hidden-iframe.html: Added.
8:06 AM Changeset in webkit [73611] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKitTools

2010-12-09 Koan-Sin Tan <koansin.tan@gmail.com>

Reviewed by Tor Arne Vestbø

[Qt] run-launcher doesn't start the browser on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=50742

check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib

  • Scripts/webkitdirs.pm:
8:06 AM Changeset in webkit [73610] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-12-09 Alex Bredariol Grilo <abgrilo@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Fix scroll operation in WebKit-EFL
https://bugs.webkit.org/show_bug.cgi?id=50752

Add the _ewk_view_scroll_add call in WebKit-EFL scroll function. This
call was wrongly removed in previous commit and performs the scroll
operation on the page.

  • ewk/ewk_view.cpp: (ewk_view_scroll):
8:00 AM Changeset in webkit [73609] by Csaba Osztrogonác
  • 1 edit
    18 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for tests introduced in r73548.
Compared to Mac png files and Mac expected files.

  • platform/qt/editing/selection/caret-ltr-2-expected.checksum: Added.
  • platform/qt/editing/selection/caret-ltr-2-expected.png: Added.
  • platform/qt/editing/selection/caret-ltr-2-expected.txt: Added.
  • platform/qt/editing/selection/caret-ltr-2-left-expected.checksum: Added.
  • platform/qt/editing/selection/caret-ltr-2-left-expected.png: Added.
  • platform/qt/editing/selection/caret-ltr-2-left-expected.txt: Added.
  • platform/qt/editing/selection/caret-ltr-expected.checksum: Added.
  • platform/qt/editing/selection/caret-ltr-expected.png: Added.
  • platform/qt/editing/selection/caret-ltr-expected.txt: Added.
  • platform/qt/editing/selection/caret-ltr-right-expected.checksum: Added.
  • platform/qt/editing/selection/caret-ltr-right-expected.png: Added.
  • platform/qt/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/qt/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/qt/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/qt/editing/selection/caret-rtl-2-left-expected.txt: Added.
  • platform/qt/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/qt/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/qt/editing/selection/caret-rtl-right-expected.txt: Added.
6:56 AM Changeset in webkit [73608] by commit-queue@webkit.org
  • 22 edits
    2 adds in trunk

2010-12-09 Joone Hur <joone@kldp.org>

Reviewed by Martin Robinson.

[GTK] Support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=45443

Included viewport test cases for WebKitGtk

  • platform/gtk/Skipped: Unskip fast/viewport except viewport-45.html.

2010-12-09 Joone Hur <joone@kldp.org>

Reviewed by Martin Robinson.

[GTK] Support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=45443

This patch adds a new gobject to offer the viewport properties to user agents.
It is WebKitViewportAttributes that contains the viewport size, initial scale with limits,
and information about whether a user is able to scale the contents in the viewport.

This feature was introduced by Safari on the iPhone. For more information on
the viewport properties, refer to the Safari reference library at
http://developer.apple.com/safari/library/documentation/appleapplications/reference/safarihtmlref/articles/metatags.html

  • GNUmakefile.am: Added webkitviewportattributes.h webkitviewportattributes.cpp.
  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::dispatchViewportDataDidChange): Added this callback to know whether the viewport arguments is available.
  • WebCoreSupport/ChromeClientGtk.h:
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): Added this function to compute the viewport attributes with the given availableWidth and availableHeight.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): Invalidate the viewport attributes.
  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitprivate.h: Added webkitViewportAttributesRecompute as a private function.
  • webkit/webkitviewportattributes.cpp: Added. (webkit_viewport_attributes_class_init): (webkit_viewport_attributes_init): (webkit_viewport_attributes_get_property): (webkit_viewport_attributes_set_property): (webkitViewportAttributesRecompute): Recompute the optimal viewport attributes and emit the viewport-attributes-changed signal. (webkit_viewport_attributes_recompute): a public API for calling webkitViewportAttributesRecompute.
  • webkit/webkitviewportattributes.h: Added.
  • webkit/webkitwebview.cpp: (webkit_web_view_get_property): Added PROP_VIEWPORT_ATTRIBUTES. (webkit_web_view_dispose): Deallocate the WebKitViewportAttributes instance. (webkit_web_view_class_init): Added the viewport-attributes-recompute-requested and viewport-attributes-changed signals. (webkit_web_view_init): Set the WebKitViewportAttributes instance. (webkit_web_view_get_viewport_attributes): Added a getter to obtain the WebKitViewportAttributes instance held by the given WebKitWebView.
  • webkit/webkitwebview.h:
  • webkit/webkitwebviewprivate.h: Added WebKitViewportAttributes as a private variable.

2010-12-09 Joone Hur <joone@kldp.org>

Reviewed by Martin Robinson.

[GTK] Support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=45443

Add support for testing the viewport properties for WebKitGtk.

  • DumpRenderTree/LayoutTestController.cpp: (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport. (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::dumpConfigurationForViewport): Ditto.
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::dumpConfigurationForViewport): Ditto.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::dumpConfigurationForViewport): Ditto.
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::dumpConfigurationForViewport): Ditto.
5:57 AM QtWebKitFeatures21 edited by Henry Haverinen
(diff)
5:34 AM Changeset in webkit [73607] by yurys@chromium.org
  • 14 edits
    1 copy
    1 add in trunk

2010-12-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Console records for failed XHRs should contain call stack and request method
https://bugs.webkit.org/show_bug.cgi?id=50390

The expectations needed update ue to log format changes.

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
  • http/tests/inspector/console-resource-errors-expected.txt:
  • http/tests/inspector/console-xhr-logging-expected.txt:
  • platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Added.
  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Copied from LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt.

2010-12-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Console records for failed XHRs should contain call stack and request method
https://bugs.webkit.org/show_bug.cgi?id=50390

When inspector front-end is open we capture call stack at the place where request is sent and
pass the stack along with other request data. There is a new type of console messages which
is NetworkErrorMessageType, all messages of that type will have requestId field initialized
with the corresponding network request identifier so that later on when we need to display
that message in the front-end we could pull request data from the Network panel using
this identifier. If there are no data for given requestId message formatting falls back to
the old implementation which lacks such things as call stack, request method and exact
source location.

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype.toString): (WebInspector.ConsoleMessage.prototype.isEqual):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
  • inspector/front-end/inspector.js: (WebInspector.addConsoleMessage):
  • page/Console.h:
5:07 AM Changeset in webkit [73606] by commit-queue@webkit.org
  • 23 edits
    5 adds in trunk

2010-12-09 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement "required" attribute for select tags
https://bugs.webkit.org/show_bug.cgi?id=50380

Added tests for require attributes, valueMissing and vadility check for select elements.

  • fast/forms/ValidityState-valueMissing-001-expected.txt:
  • fast/forms/ValidityState-valueMissing-001.html:
  • fast/forms/ValidityState-valueMissing-002-expected.txt:
  • fast/forms/ValidityState-valueMissing-002.html:
  • fast/forms/ValidityState-valueMissing-003-expected.txt:
  • fast/forms/ValidityState-valueMissing-003.html:
  • fast/forms/checkValidity-002-expected.txt:
  • fast/forms/checkValidity-002.html:
  • fast/forms/required-attribute-001-expected.txt:
  • fast/forms/required-attribute-001.html:
  • fast/forms/required-attribute-002-expected.txt:
  • fast/forms/required-attribute-002.html:
  • fast/forms/resources/select-live-pseudo-selectors.js: Added. (makeInvalid): (appendOption): (backgroundOf):
  • fast/forms/script-tests/validationMessage.js:
  • fast/forms/select-live-pseudo-selectors-expected.txt: Added.
  • fast/forms/select-live-pseudo-selectors.html: Added.
  • fast/forms/validationMessage-expected.txt:
  • platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Added.
  • platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Added.

2010-12-09 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement "required" attribute for select tags
https://bugs.webkit.org/show_bug.cgi?id=50380

Test: fast/forms/select-live-pseudo-selectors.html

platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::updateValidity): Added. It's a pure virtual function which is prepared so that HTMLSelectElement::updateValidity() calls HTMLSelectElement::setNeedsValidityCheck(). (WebCore::SelectElement::parseMultipleAttribute): Added calling updateValidity().
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface. (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified. (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180. (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated.. (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not. (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added. (WebCore::HTMLSelectElement::updateValidity): Added. It calls setNeedsValidityCheck().
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
  • html/HTMLSelectElement.idl: Added a required attribute to select elements..
  • html/ValidityState.cpp: (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
  • wml/WMLSelectElement.h: (WebCore::WMLSelectElement::updateValidity): Added. It does nothing.
4:29 AM Changeset in webkit [73605] by jorlow@chromium.org
  • 13 edits in trunk

2010-12-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB returns the wrong exceptions
https://bugs.webkit.org/show_bug.cgi?id=50632

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

2010-12-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IndexedDB returns the wrong exceptions
https://bugs.webkit.org/show_bug.cgi?id=50632

IndexedDB exceptions need to have an offset so they can
be distinguished from DOM exceptions. We also need to
add strings for the various exceptions. Lastly, make
IDBDatabaseException use the common exception base class.

  • bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
  • dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription):
  • dom/ExceptionCode.h:
  • storage/IDBDatabaseError.h: (WebCore::IDBDatabaseError::code):
  • storage/IDBDatabaseException.h: (WebCore::IDBDatabaseException::create): (WebCore::IDBDatabaseException::ErrorCodeToExceptionCode): (WebCore::IDBDatabaseException::IDBDatabaseException):
  • storage/IDBDatabaseException.idl:
4:15 AM BuildingGtk edited by kov@webkit.org
(diff)
4:09 AM Changeset in webkit [73604] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-12-09 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix 'make install' woes with some versions of automake.

  • GNUmakefile.am: use $(top_builddir) instead of $(builddir), since we actually want a valid path for the file regardless of the place from where the script is called.
3:18 AM Changeset in webkit [73603] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Build fix for GTK+3. Use functions added for GTK+ 2.24 to get the
GDK window size.

  • plugins/gtk/gtk2xtbin.c: (gtk_xtbin_realize):
3:12 AM Changeset in webkit [73602] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-09 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

Use BUILDING_WEBKIT like other ports
https://bugs.webkit.org/show_bug.cgi?id=50713

  • WebCore.pro: Change BUILD_WEBKIT to BUILDING_WEBKIT

2010-12-09 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

Use BUILDING_WEBKIT like other ports
https://bugs.webkit.org/show_bug.cgi?id=50713

  • Api/qwebkitglobal.h: change BUILD_WEBKIT to BUILDING_WEBKIT
3:12 AM Changeset in webkit [73601] by pfeldman@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2010-12-09 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rebaselined Chromium expectations.
Reverts r73518 and r73522.

  • platform/chromium-linux/fast/forms/placeholder-position-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added.
  • platform/chromium-mac/fast/forms/placeholder-position-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/placeholder-position-expected.png: Added.
  • platform/chromium-win/fast/forms/placeholder-position-expected.checksum: Added.
  • platform/chromium-win/fast/forms/placeholder-position-expected.png: Added.
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:07 AM Changeset in webkit [73600] by Philippe Normand
  • 2 edits in trunk

2010-12-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] configure: error out if video is enabled and gstreamer pkg-config check fails
https://bugs.webkit.org/show_bug.cgi?id=50741

  • configure.ac:
2:41 AM Changeset in webkit [73599] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. Add Qt specific expected results for tests introduced in r73529.

  • platform/qt/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/qt/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
2:03 AM Changeset in webkit [73598] by mrobinson@webkit.org
  • 16 edits in trunk/LayoutTests

2010-12-09 Martin Robinson <mrobinson@igalia.com>

Update GTK+ baselines after r73561.

  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
1:37 AM Changeset in webkit [73597] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2010-12-09 Philippe Normand <pnormand@igalia.com>

Unreviewed, update test baselines as asked by MORITA Hajime.

[GTK] r73488 broke fast/dom/HTMLProgressElement/progress-element.html
https://bugs.webkit.org/show_bug.cgi?id=50687

  • platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/gtk/Skipped:
12:09 AM Changeset in webkit [73596] by yutak@chromium.org
  • 10 edits in trunk/LayoutTests

2010-12-09 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Chromium rebaselines for r73488.

  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/chromium/test_expectations.txt:

Dec 8, 2010:

10:43 PM Changeset in webkit [73595] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-08 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updated Chromium expectations.

  • platform/chromium/test_expectations.txt:
9:40 PM Changeset in webkit [73594] by barraclough@apple.com
  • 9 edits in trunk

Permit Character Class Escape in CharacterRange in Character Class.
https://bugs.webkit.org/show_bug.cgi?id=50483
https://bugs.webkit.org/show_bug.cgi?id=50538
https://bugs.webkit.org/show_bug.cgi?id=50654
https://bugs.webkit.org/show_bug.cgi?id=50646

Reviewed by Sam Weinig.

We recently tightened up our spec conformance in generating syntax
error in these cases, however testing in the wild has shown this
to be problematic. This reverts the previous change in allowing
class escapes (e.g. \d) in ranges in character classes ([]), but
does retain some closer conformance to the spec in only allowing
ranges that would be permitted per the grammar rules in the spec
(e.g. in /[\d-a-z]/ "a-z" cannot be considered as a range).

JavaScriptCore:

  • yarr/RegexParser.h:

(JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
(JSC::Yarr::Parser::parse):

LayoutTests:

  • fast/js/regexp-ranges-and-escaped-hyphens-expected.txt:
  • fast/js/script-tests/regexp-ranges-and-escaped-hyphens.js:
  • fast/regex/invalid-range-in-class-expected.txt:
  • fast/regex/pcre-test-1-expected.txt:
  • fast/regex/script-tests/invalid-range-in-class.js:
  • fast/regex/script-tests/pcre-test-1.js:
9:03 PM Changeset in webkit [73593] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-08 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
8:32 PM Changeset in webkit [73592] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix crash-on-launch seen on Windows builder.

Reviewed by Sam Weinig.

  • wtf/OSAllocatorWin.cpp:

(WTF::OSAllocator::release): Disabled an ASSERT, because it checks for
a bug that hasn't been fixed yet.

8:30 PM Changeset in webkit [73591] by weinig@apple.com
  • 5 edits in trunk/WebKit2

Fix typo: Diplaying -> Displaying

Reviewed by Geoffrey "Error" Garen.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameIsDisplayingStandaloneImageDocument):
(WKFrameIsDisplayingMarkupDocument):

  • UIProcess/API/C/WKFrame.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canProvideSource):
(WebKit::WebFrameProxy::isDisplayingStandaloneImageDocument):
(WebKit::WebFrameProxy::isDisplayingMarkupDocument):

  • UIProcess/WebFrameProxy.h:
8:22 PM Changeset in webkit [73590] by wsiegrist@apple.com
  • 3 edits in trunk/WebKitTools

2010-12-08 William Siegrist <wsiegrist@apple.com>

Reviewed by Eric Seidel.

Migrate buildbot.py from xmlrpc to json.
https://bugs.webkit.org/show_bug.cgi?id=50647

  • Scripts/webkitpy/common/net/buildbot.py:
7:55 PM Changeset in webkit [73589] by arv@chromium.org
  • 10 edits in trunk/WebCore

2010-12-08 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

Replace getAttribute().isNull() with fastHasAttribute()
https://bugs.webkit.org/show_bug.cgi?id=50719

Covered by existing tests.

  • dom/SelectElement.cpp: (WebCore::SelectElement::reset):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::rendererIsNeeded):
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::itemAfter):
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::formNoValidate):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::noValidate):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultChecked): (WebCore::HTMLInputElement::multiple): (WebCore::HTMLInputElement::webkitdirectory):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::defaultSelected):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::asyncAttributeValue): (WebCore::HTMLScriptElement::deferAttributeValue):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::allowsMultipleFiles): (WebCore::RenderFileUploadControl::allowsDirectoryUpload):
7:37 PM Changeset in webkit [73588] by rniwa@webkit.org
  • 2 edits
    2 adds
    2 deletes in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Yet another Chromium rebaselines for r73548.

  • platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.png: Removed.
  • platform/chromium-mac/fast/text/international/khmer-selection-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/khmer-selection-expected.png: Added.
  • platform/chromium/test_expectations.txt:
7:33 PM Changeset in webkit [73587] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-12-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

Full page size flash plugins do not show in all situations
https://bugs.webkit.org/show_bug.cgi?id=47742

This patch moves the plugin widget size allocation after the
NPP_SetWindow is called with the effect that the resize of Flash
content no longer result in grey flash. This seems logical since the
widget tree cannot be fully constructed before the plugin receives
the new container window.

Test: manual-tests/plugins/gtk-windowed-grey-glitch.html

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
7:29 PM Changeset in webkit [73586] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix regression from xji's wheel scroll patch. The vertical case is looking at the horizontal
maximum position and not the vertical position.

Reviewed by Simon Fraser.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

7:13 PM Changeset in webkit [73585] by aestes@apple.com
  • 2 edits in trunk/WebKit/mac

2010-12-08 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Enable pre-HTML5 parser quirks for Apple Mail.app
https://bugs.webkit.org/show_bug.cgi?id=50727

  • WebView/WebView.mm: (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding application is Mail.app.
7:10 PM Changeset in webkit [73584] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-12-08 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support OrientationChange event
https://bugs.webkit.org/show_bug.cgi?id=50685

Get OrientationChange event from qtmobility then send to webkit.

  • Api/qwebframe.cpp: (QWebFrame::orientationChanged): (QWebFrame::QWebFrame):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h:
6:25 PM Changeset in webkit [73583] by weinig@apple.com
  • 2 edits in trunk/WebCore

Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=50726

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Expose HTMLIFrameElement.h.
6:20 PM Changeset in webkit [73582] by weinig@apple.com
  • 7 edits in trunk/WebKit2

Add WebKit2 Preference for TabsToLinks behavior.
<rdar://problem/8664263>

Reviewed by Gavin Barraclough.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetTabsToLinks):
(WKPreferencesGetTabsToLinks):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::tabsToLinks):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::tabsToLinks):

6:15 PM Changeset in webkit [73581] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit2

2010-12-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

WebTouchEvent::isTouchEventType() does not take into account the type TouchCancel
https://bugs.webkit.org/show_bug.cgi?id=50680

Add the missing type check to WebTouchEvent::isTouchEventType().

  • Shared/WebTouchEvent.cpp: (WebKit::WebTouchEvent::isTouchEventType):
6:03 PM Changeset in webkit [73580] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def file.
6:02 PM Changeset in webkit [73579] by weinig@apple.com
  • 5 edits in trunk/WebKit2

Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=50726

Reviewed by Darin Adler.

Adds WKBundleNodeHandleCopyDocumentFrame, WKBundleNodeHandleCopyHTMLFrameElementContentFrame
and WKBundleNodeHandleCopyHTMLIFrameElementContentFrame, to handle the document, <frame>
and <iframe> cases.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCopyDocumentFrame):
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame):
(WKBundleNodeHandleCopyHTMLIFrameElementContentFrame):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::copyDocumentFrame):
(WebKit::InjectedBundleNodeHandle::copyHTMLFrameElementContentFrame):
(WebKit::InjectedBundleNodeHandle::copyHTMLIFrameElementContentFrame):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
5:54 PM Changeset in webkit [73578] by mdelaney@apple.com
  • 7 edits in trunk/WebCore

2010-12-08 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Add getter and setters for acceleratesRendering flag on layers
https://bugs.webkit.org/show_bug.cgi?id=50717

  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm: Plumbed through acceleratedRendering flag.
5:50 PM Changeset in webkit [73577] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def

file to remove a symbol -- the next build failure will say which symbol
to add back.

5:45 PM Changeset in webkit [73576] by tkent@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2010-12-08 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Update expectations for r73566.

  • platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt:
  • platform/qt/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
  • platform/win/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
5:42 PM Changeset in webkit [73575] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def file.
5:41 PM Changeset in webkit [73574] by weinig@apple.com
  • 5 edits in trunk/WebKit2

Need a WebKit2 way to test whether a frame is displaying a standalone image
<rdar://problem/8443059>
WebKit2: Need a way to test whether a page or frame is showing HTML content
<rdar://problem/8642563>

Reviewed by Gavin Barraclough.

Add WKFrameIsDiplayingStandaloneImageDocument and WKFrameIsDiplayingMarkupDocument.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameIsDiplayingStandaloneImageDocument):
(WKFrameIsDiplayingMarkupDocument):

  • UIProcess/API/C/WKFrame.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canProvideSource): This now just calls isDiplayingMarkupDocument.
(WebKit::WebFrameProxy::isDiplayingStandaloneImageDocument):
(WebKit::WebFrameProxy::isDiplayingMarkupDocument):

  • UIProcess/WebFrameProxy.h:
5:38 PM Changeset in webkit [73573] by zmo@google.com
  • 9 edits in trunk

2010-12-07 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

WebGLUniformLocation objects must be invalidated during linkProgram
https://bugs.webkit.org/show_bug.cgi?id=37118

  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::WebGLProgram): Initialize link count to 0. (WebCore::WebGLProgram::cacheActiveAttribLocations): Don't check link status through gl call; use the cached status instead.
  • html/canvas/WebGLProgram.h: (WebCore::WebGLProgram::getLinkCount): Get link count. (WebCore::WebGLProgram::increaseLinkCount): Increase link count by 1.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform): Fix a bug where wrong error is generated. (WebCore::WebGLRenderingContext::linkProgram): call increaseLinkCount after linkProgram.
  • html/canvas/WebGLUniformLocation.cpp: (WebCore::WebGLUniformLocation::WebGLUniformLocation): Set program's link count upon creation. (WebCore::WebGLUniformLocation::program): Return null if count doesn't match the program's. (WebCore::WebGLUniformLocation::location): Return -1 if count doesn't match the program's.
  • html/canvas/WebGLUniformLocation.h:

2010-12-07 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

WebGLUniformLocation objects must be invalidated during linkProgram
https://bugs.webkit.org/show_bug.cgi?id=37118

  • fast/canvas/webgl/uniform-location-expected.txt:
  • fast/canvas/webgl/uniform-location.html: Check that after linkProgram, all previous uniform locations become invalid.
5:36 PM Changeset in webkit [73572] by adele@apple.com
  • 8 edits
    4 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=50725
<rdar://problem/8694972> REGRESSION (r72052): "Search" placeholder in MobileMe mail is positioned too high

Reviewed by Darin Adler.

Test: fast/forms/placeholder-position.html

Since we center the inner text element for single line text controls,
we should ask the subclass to give us the y offset instead of trying to calculate it in the RenderTextControl class.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::textBlockInsetTop):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
  • rendering/RenderTextControlSingleLine.h:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=50725
<rdar://problem/8694972> REGRESSION (r72052): "Search" placeholder in MobileMe mail is positioned too high

Reviewed by Darin Adler.

  • fast/forms/placeholder-position.html: Added.
  • platform/mac/fast/forms/placeholder-position-expected.checksum: Added.
  • platform/mac/fast/forms/placeholder-position-expected.png: Added.
  • platform/mac/fast/forms/placeholder-position-expected.txt: Added.
5:35 PM Changeset in webkit [73571] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Try to fix GTK Linux build.

  • jit/ExecutableAllocator.cpp:

(JSC::ExecutablePool::systemAlloc):

  • runtime/AlignedMemoryAllocator.h:

(JSC::::AlignedMemoryAllocator): Updated for Usage enum moving to OSAllocator.

5:30 PM Changeset in webkit [73570] by ggaren@apple.com
  • 12 edits in trunk/JavaScriptCore

Migrated OS-specific allocation code from PageReservation and PageAllocation to OSAllocator
https://bugs.webkit.org/show_bug.cgi?id=50653

Reviewed by Sam Weinig.

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator): Removed checkAllocatedOkay.
OSAllocator is now the central location for verifying that allocation succeeds.
This allowed me to remove some complicating cross-platform cruft.

  • runtime/AlignedMemoryAllocator.h:

(JSC::::allocate): Updated for code motion.

  • wtf/OSAllocator.h: Added Usage, writable, and executable parameters, to

support VM features required by clients of PageAllocation and PageReservation.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit): Moved PageAllocation support for randomizing
executable memory here.

  • wtf/OSAllocatorSymbian.cpp:

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit): Updated for new function signatures.

  • wtf/OSAllocatorWin.cpp:

(WTF::protection):
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::release): Updated for new function signatures. Moved
some protection-related and WINCE-related code from PageAllocation here.

  • wtf/PageAllocation.cpp: Nixed cross-platform lastError abstraction, since

it was only used by checkAllocatedOkay, which is now gone.

  • wtf/PageAllocation.h:

(WTF::PageAllocation::allocate):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::deallocate):
(WTF::PageAllocation::isPowerOfTwo):
(WTF::PageAllocation::systemAllocateAligned): Removed system* functions,
and replaced calls to them with calls to OSAllocator.

  • wtf/PageReservation.h:

(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::reserve):
(WTF::PageReservation::deallocate):
(WTF::PageReservation::PageReservation): Ditto. Added m_writable and
m_executable because these flags are now required when committing memory.

5:09 PM Changeset in webkit [73569] by andersca@apple.com
  • 4 edits in trunk/WebKit2

WebFrameProxy::canShowMIMEType should return true for PDF MIME types in the main frame
https://bugs.webkit.org/show_bug.cgi?id=50724

Reviewed by Darin Adler.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::pdfAndPostScriptMIMETypes):

  • UIProcess/WebContext.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canShowMIMEType):

5:03 PM Changeset in webkit [73568] by crogers@google.com
  • 5 edits in trunk

2010-12-08 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add web audio files to mac port Xcode projects
https://bugs.webkit.org/show_bug.cgi?id=50721

2010-12-08 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add web audio files to mac port Xcode projects
https://bugs.webkit.org/show_bug.cgi?id=50721

No new tests since audio API is not yet implemented.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webkitAudioContext):
5:03 PM Changeset in webkit [73567] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

WebMenuTarget implemented in both WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50665
<rdar://problem/8742640>

Reviewed by Brady Eidson.

Rename WebMenuTarget to WKMenuTarget to prevent this warning and stay consistent with
other WebKit2 namings.

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(+[WKMenuTarget sharedMenuTarget]):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::showContextMenu):

4:54 PM Changeset in webkit [73566] by tkent@chromium.org
  • 8 edits in trunk

Yensign hack should work with Shift_JIS and ISO-2022-JP encodings.
https://bugs.webkit.org/show_bug.cgi?id=49714

Reviewed by Alexey Proskuryakov.

WebCore:

IE chooses a font which shows a yensign for 0x5c code point for a page
encoded in x-mac-japanese, ISO-2022-JP, EUC-JP, Shift_JIS, Shift_JIS_X0213-2000,
x-sjis, and Windows-31J.
We have emulated this behavior by replacing 0x5c with 0xa5 for EUC-JP and
Shift_JIS_X0213-2000. This change adds other encodings above.

Also, we move the HashSet initialization for isJapanese() and
backslashAsCurrencySymbol() to TextEncodingRegistry.cpp because of
ease of making them multi-thread safe.

  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::isJapanese): Just calls isJapaneseEncoding().
(WebCore::TextEncoding::backslashAsCurrencySymbol): Uses shouldShowBackslashAsCurrencySymbolIn().

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::addEncodingName): Moved from TextEncoding.cpp, and stop using atomicCanonicalTextEncodingName().
(WebCore::buildQuirksSets): Added. Initializes HashSets for isJapaneseEncoding() and shouldShowBackslashAsCurrencySymbolIn().
(WebCore::isJapaneseEncoding):
(WebCore::shouldShowBackslashAsCurrencySymbolIn):
(WebCore::extendTextCodecMaps): Add a call to buildQuirksSets().

  • platform/text/TextEncodingRegistry.h:

LayoutTests:

Use Shift_JIS instead of Shift_JIS_X0213-2000 because Shift_JIS_X0213-2000
encoding is available only on Mac.
Add a test for ISO-2022-JP.

  • editing/selection/find-yensign-and-backslash-expected.txt:
  • editing/selection/find-yensign-and-backslash.html:
  • platform/chromium/test_expectations.txt:
4:47 PM Changeset in webkit [73565] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Move canShowMIMEType to Frame
https://bugs.webkit.org/show_bug.cgi?id=50723

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameCanShowMIMEType):

  • UIProcess/API/C/WKFrame.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::canShowMIMEType):

  • UIProcess/WebFrameProxy.h:
4:37 PM Changeset in webkit [73564] by aestes@apple.com
  • 15 edits in trunk

2010-12-08 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Reflected unsigned attributes should be in the range [0, 231).
https://bugs.webkit.org/show_bug.cgi?id=50472

HTML5 says that unsigned reflected attributes should be in the range
[0, 231). When a value isn't in this range, a default value (or 0)
should be returned instead. Update the JS bindings code generator to
ensure 0 is returned when a content attribute value falls outside of
this range.

Tests: bindings/scripts/test/TestObj.idl

fast/html/marquee-element.html

  • bindings/scripts/CodeGeneratorJS.pm: Return the maximum of 0 and the content attribute as a 32-bit signed int when converting a native value to an unsigned JS value.
  • bindings/scripts/test/TestObj.idl: Add a reflected unsigned attribute to test code generation.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Update test results.
  • bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

2010-12-08 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Reflected unsigned attributes should be in the range [0, 231).
https://bugs.webkit.org/show_bug.cgi?id=50472

  • fast/html/marquee-element.html: Give hspace and vspace negative values and test what their corresponding IDL attributes reflect.
  • fast/html/marquee-element-expected.txt:
4:13 PM Changeset in webkit [73563] by tony@chromium.org
  • 4 edits in trunk/WebKitTools

2010-12-08 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

make starting the websocket server more reliable on windows
https://bugs.webkit.org/show_bug.cgi?id=50712

  • Scripts/webkitpy/common/system/filesystem.py: (remove): Substitute method for os.remove to retry on error on Windows
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
3:58 PM Changeset in webkit [73562] by rniwa@webkit.org
  • 8 edits
    3 deletes in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaseline for r73548.

  • platform/chromium-linux/fast/text/international/khmer-selection-expected.checksum:
  • platform/chromium-linux/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-linux/fast/text/international/khmer-selection-expected.txt:
  • platform/chromium-win-xp/fast/text/international/khmer-selection-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/international/khmer-selection-expected.txt: Removed.
  • platform/chromium-win/fast/text/international/khmer-selection-expected.checksum:
  • platform/chromium-win/fast/text/international/khmer-selection-expected.png:
  • platform/chromium-win/fast/text/international/khmer-selection-expected.txt:
  • platform/chromium/test_expectations.txt:
3:50 PM Changeset in webkit [73561] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-12-08 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use gtk_icon_set_render_icon() to render icons in RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=50623

We don't need to cache the icons since the will be cached by GTK+,
and they will be rendered using the state and text direction.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintStockIcon): (WebCore::getMediaButtonIconSize): (WebCore::RenderThemeGtk::initMediaColors): (WebCore::RenderThemeGtk::initMediaButtons): (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::~RenderThemeGtk): (WebCore::RenderThemeGtk::gtkIconState): (WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle): (WebCore::centerRectVerticallyInParentInputElement): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::platformColorsDidChange): (WebCore::RenderThemeGtk::paintMediaButton): (WebCore::RenderThemeGtk::paintMediaFullscreenButton): (WebCore::RenderThemeGtk::paintMediaMuteButton): (WebCore::RenderThemeGtk::paintMediaPlayButton): (WebCore::RenderThemeGtk::paintMediaSeekBackButton): (WebCore::RenderThemeGtk::paintMediaSeekForwardButton):
  • platform/gtk/RenderThemeGtk.h:
3:33 PM Changeset in webkit [73560] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/mac

REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
https://bugs.webkit.org/show_bug.cgi?id=50683

Reviewed by John Sullivan.

If our context menu item already has an action, don't overwrite the action with the context menu
forwarder.

  • WebView/WebHTMLView.mm:

(setMenuItemTarget):

3:31 PM Changeset in webkit [73559] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2010-12-08 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Detach node iterator and move to new document when node gets moved.
https://bugs.webkit.org/show_bug.cgi?id=50697

Test: fast/dom/node-iterator-document-moved-crash.html

  • dom/Document.cpp: Method that takes a node and new document as argument. It detaches the node iterators belonging to the current document and attaches them to the new document. (WebCore::Document::moveNodeIteratorsToNewDocument):
  • dom/Document.h: Function definition.
  • dom/Node.cpp: When node is moved to another document, call the function to move the iterators appropriately. (WebCore::Node::setDocument):

2010-12-08 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when node iterator gets moved across documents.
https://bugs.webkit.org/show_bug.cgi?id=50697

  • fast/dom/node-iterator-document-moved-crash-expected.txt: Added.
  • fast/dom/node-iterator-document-moved-crash.html: Added.
3:27 PM Changeset in webkit [73558] by rniwa@webkit.org
  • 12 edits
    46 adds in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaseline for r73548.

  • platform/chromium-linux/editing/selection/caret-ltr-2-expected.checksum: Added.
  • platform/chromium-linux/editing/selection/caret-ltr-2-expected.png: Added.
  • platform/chromium-linux/editing/selection/caret-ltr-2-left-expected.checksum: Added.
  • platform/chromium-linux/editing/selection/caret-ltr-2-left-expected.png: Added.
  • platform/chromium-linux/editing/selection/caret-ltr-expected.checksum: Added.
  • platform/chromium-linux/editing/selection/caret-ltr-expected.png: Added.
  • platform/chromium-linux/editing/selection/caret-ltr-right-expected.checksum: Added.
  • platform/chromium-linux/editing/selection/caret-ltr-right-expected.png: Added.
  • platform/chromium-linux/editing/selection/caret-rtl-2-expected.checksum: Added.
  • platform/chromium-linux/editing/selection/caret-rtl-2-expected.png: Added.
  • platform/chromium-linux/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/chromium-linux/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/chromium-linux/editing/selection/caret-rtl-expected.checksum:
  • platform/chromium-linux/editing/selection/caret-rtl-expected.png:
  • platform/chromium-linux/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/chromium-linux/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/chromium-win/editing/selection/caret-ltr-2-expected.checksum: Added.
  • platform/chromium-win/editing/selection/caret-ltr-2-expected.png: Added.
  • platform/chromium-win/editing/selection/caret-ltr-2-expected.txt: Added.
  • platform/chromium-win/editing/selection/caret-ltr-2-left-expected.checksum: Added.
  • platform/chromium-win/editing/selection/caret-ltr-2-left-expected.png: Added.
  • platform/chromium-win/editing/selection/caret-ltr-2-left-expected.txt: Added.
  • platform/chromium-win/editing/selection/caret-ltr-expected.checksum: Added.
  • platform/chromium-win/editing/selection/caret-ltr-expected.png: Added.
  • platform/chromium-win/editing/selection/caret-ltr-expected.txt: Added.
  • platform/chromium-win/editing/selection/caret-ltr-right-expected.checksum: Added.
  • platform/chromium-win/editing/selection/caret-ltr-right-expected.png: Added.
  • platform/chromium-win/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/chromium-win/editing/selection/caret-rtl-2-expected.checksum:
  • platform/chromium-win/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-win/editing/selection/caret-rtl-2-expected.txt:
  • platform/chromium-win/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/chromium-win/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/chromium-win/editing/selection/caret-rtl-2-left-expected.txt: Added.
  • platform/chromium-win/editing/selection/caret-rtl-expected.checksum:
  • platform/chromium-win/editing/selection/caret-rtl-expected.png:
  • platform/chromium-win/editing/selection/caret-rtl-expected.txt:
  • platform/chromium-win/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/chromium-win/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/chromium-win/editing/selection/caret-rtl-right-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:24 PM Changeset in webkit [73557] by mrobinson@webkit.org
  • 3 edits in trunk/LayoutTests

2010-12-08 Martin Robinson <mrobinson@igalia.com>

Replace some GTK+ test results after r73548.

  • platform/gtk/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
  • platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
3:11 PM Changeset in webkit [73556] by jamesr@google.com
  • 3 edits
    12 copies in branches/chromium/597

Merge 73531 - https://bugs.webkit.org/show_bug.cgi?id=50576

Reviewed by Anders Carlsson.

REGRESSION in position of autocomplete popup on RTL page.

RTL static position computation did not subtract out the width of the enclosing box if the
immediate parent was a RenderInline. This bug was exposed by properly changing the RenderView
to be RTL when the document was RTL.

Added three new tests in fast/block/positioning.

WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth):

LayoutTests:

  • fast/block/positioning/rtl-static-positioning-inline-block.html: Added.
  • fast/block/positioning/rtl-static-positioning.html: Added.
  • fast/block/positioning/table-cell-static-position.html: Added.
  • platform/mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
  • platform/mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
  • platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
  • platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
  • platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
  • platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
  • platform/mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
  • platform/mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
  • platform/mac/fast/block/positioning/table-cell-static-position-expected.txt: Added.

TBR=jamesr@chromium.org
BUG=62451
Review URL: http://codereview.chromium.org/5670003

2:48 PM Changeset in webkit [73555] by rniwa@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Removed old expected results for caret-rtl.html and caret-rtl-2.html on Mac Leopard.

  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Removed.
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.png: Removed.
  • platform/mac-leopard/editing/selection/caret-rtl-expected.checksum: Removed.
  • platform/mac-leopard/editing/selection/caret-rtl-expected.png: Removed.
2:35 PM Changeset in webkit [73554] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

Mark some Mac tests as timing out after r73518 and r73522.

  • platform/chromium/test_expectations.txt:
2:34 PM Changeset in webkit [73553] by rniwa@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fixed the change log entry for r73548.

2:25 PM Changeset in webkit [73552] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Remove an unused variable.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):

2:19 PM Changeset in webkit [73551] by Adam Roben
  • 1 edit
    4 deletes in trunk/LayoutTests

Update Windows test results after r73538

We don't need Windows-specific results for this test anymore.

  • platform/win-xp/svg/custom/clip-path-referencing-use-expected.checksum: Removed.
  • platform/win-xp/svg/custom/clip-path-referencing-use-expected.png: Removed.
  • platform/win-xp/svg/custom/clip-path-referencing-use-expected.txt: Removed.
  • platform/win/svg/custom/clip-path-referencing-use-expected.checksum: Removed.
  • platform/win/svg/custom/clip-path-referencing-use-expected.png: Removed.
  • platform/win/svg/custom/clip-path-referencing-use-expected.txt: Removed.
2:09 PM Changeset in webkit [73550] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Build fix. Take webView{Enter,Exit}Fullscreen back out of the
WebKit namespace, and remove a function signature that got in by
mistake because of a bad merge.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (WebKit::core): (WebKit::kit):
1:58 PM Changeset in webkit [73549] by jamesr@google.com
  • 4 edits
    7 adds in trunk

2010-12-08 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Text is blurry on a large composited layer with an odd center x/y coordinate
https://bugs.webkit.org/show_bug.cgi?id=50702

Tests that text rendered on a large layer is crisp even when the layer's center point
has an odd x and/or y coordinate.

  • compositing/text-on-large-layer.html: Added.
  • platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.txt: Added.
  • platform/chromium-gpu/test_expectations.txt:
  • platform/mac/compositing/text-on-large-layer-expected.checksum: Added.
  • platform/mac/compositing/text-on-large-layer-expected.png: Added.
  • platform/mac/compositing/text-on-large-layer-expected.txt: Added.

2010-12-08 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Text is blurry on a large composited layer with an odd center x/y coordinate
https://bugs.webkit.org/show_bug.cgi?id=50702

Compute the center of a large layer using floats instead of ints to avoid roundoff errors.

Test: compositing/text-on-large-layer.html

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw):
1:55 PM Changeset in webkit [73548] by rniwa@webkit.org
  • 11 edits
    25 adds in trunk

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

REGRESSION: LayoutTests/editing/selection/caret-rtl-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=33503

The bug was caused by Font::offsetForPosition's not taking into account the containing block's text direction.
When RTL text appears in a LTR block, the offset at the beginning of RTL text is on the left of RTL text,
adn the offset at the end of RTL text is on the right of RTL text. For example, if we had RTL text CBA,
then the correspondance between letters and offsets in logical order are: A -> 0, B -> 1, and C -> 2.

Case 1. CBA appears in a RTL block:

In this case, clicking on the visual left of CBA puts the caret naturally at Position("CBA", 2).
Clicking on the visual right of CBA puts the caret at Position("CBA", 0) as expected.

Case 2. CBA appears in a LTR block:

Because the containing block flows from left to right, by covention, Position("CBA", 2") coresponds
to the visual right of CBA, and Position("CBA", 0) corresponds to the visual left of CBA.
Therefore, clicking on the visual left of CBA should put the caret at Positoin("CBA", 0),
and clicking on the visual right should put it at Position("CBA", 2).

The bug was caused by WebKit's not considering case 2. The same bug also existe for LTR text in a RTL block.
Fixed the bug by taking care of the case 2 in InlineTextBox::offsetForPosition.

Tests: editing/selection/caret-ltr-2-left.html

editing/selection/caret-ltr-2.html
editing/selection/caret-ltr-right.html
editing/selection/caret-ltr.html
editing/selection/caret-rtl-2-left.html
editing/selection/caret-rtl-right.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::offsetForPosition):

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

REGRESSION: LayoutTests/editing/selection/caret-rtl-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=33503

Added tests to ensure WebKit places the caret at a right place for LTR text in a LTR block,
LTR text in a RTL block, RTL text in a RTL block, and RTL text in a LTR block.

Because we need to verify both rendering of the caret and (node, offset) pair of the caret,
these tests cannot be combined or done without pixel results.

  • editing/selection/caret-ltr-2-left.html: Added.
  • editing/selection/caret-ltr-2.html: Added.
  • editing/selection/caret-ltr-right.html: Added.
  • editing/selection/caret-ltr.html: Added.
  • editing/selection/caret-rtl-2-left.html: Added.
  • editing/selection/caret-rtl-2.html:
  • editing/selection/caret-rtl-right.html: Added.
  • editing/selection/caret-rtl.html:
  • editing/selection/resources/caret-edge-shared.js: Added. (runTest): (verify): (log):
  • platform/mac/editing/selection/caret-ltr-2-expected.checksum: Added.
  • platform/mac/editing/selection/caret-ltr-2-expected.png: Added.
  • platform/mac/editing/selection/caret-ltr-2-expected.txt: Added.
  • platform/mac/editing/selection/caret-ltr-2-left-expected.checksum: Added.
  • platform/mac/editing/selection/caret-ltr-2-left-expected.png: Added.
  • platform/mac/editing/selection/caret-ltr-2-left-expected.txt: Added.
  • platform/mac/editing/selection/caret-ltr-expected.checksum: Added.
  • platform/mac/editing/selection/caret-ltr-expected.png: Added.
  • platform/mac/editing/selection/caret-ltr-expected.txt: Added.
  • platform/mac/editing/selection/caret-ltr-right-expected.checksum: Added.
  • platform/mac/editing/selection/caret-ltr-right-expected.png: Added.
  • platform/mac/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-expected.png:
  • platform/mac/editing/selection/caret-rtl-2-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/mac/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/mac/editing/selection/caret-rtl-2-left-expected.txt: Added.
  • platform/mac/editing/selection/caret-rtl-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-expected.png:
  • platform/mac/editing/selection/caret-rtl-expected.txt:
  • platform/mac/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/mac/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/mac/editing/selection/caret-rtl-right-expected.txt: Added.
1:48 PM Changeset in webkit [73547] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Touch a file that's sporadically giving 207 Multi-Status error on svn update, hoping that
it will magically fix it.

  • fast/xpath/4XPath/Core/test.js: Removed properties svn:mime-type and svn:eol-style, added a newline.
1:48 PM Changeset in webkit [73546] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Rename WKPreferencesGetFTPDirectoryTemplatePath to WKPreferencesCopyFTPDirectoryTemplatePath
since it copies the value.

Reviewed by Oliver Hunt.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCopyFTPDirectoryTemplatePath):

  • UIProcess/API/C/WKPreferencesPrivate.h:
1:44 PM Changeset in webkit [73545] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-12-08 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Marking the active global object re-enters through markConservatively
https://bugs.webkit.org/show_bug.cgi?id=50711

draining of the MarkStack is not allowed to be re-entrant, we got away
with this simply due to the logic in MarkStack::drain implicitly handling
changes that could be triggered by the re-entry.

Just to be safe this patch removes the re-entry through markConservatively
so we don't accidentally introduce such an issue in future. I've also
added an assertion to catch such errors.

  • runtime/Collector.cpp: (JSC::Heap::markConservatively): (JSC::Heap::markCurrentThreadConservativelyInternal): (JSC::Heap::markOtherThreadConservatively):
  • runtime/JSArray.h: (JSC::MarkStack::drain):
  • runtime/MarkStack.h: (JSC::MarkStack::MarkStack):
1:41 PM Changeset in webkit [73544] by pkasting@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed Chromium test expectations update.

Mark some tests as passing or slow, and update the comment on the
compositing tests to indicate more accurately why we skip them in the
main test run.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
1:29 PM Changeset in webkit [73543] by andersca@apple.com
  • 4 edits in trunk/WebCore

Fix some clang++ warnings (one of which was an actual bug)
https://bugs.webkit.org/show_bug.cgi?id=50700

Reviewed by Darin Adler.

  • page/mac/DragControllerMac.mm:

(WebCore::DragController::dragOperation):
Add parentheses to silent a clang warning.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):

Fix
vs && precedence bug uncovered by clang.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::reshape):
Use an early return to avoid a warning.

1:27 PM Changeset in webkit [73542] by weinig@apple.com
  • 5 edits in trunk/WebKit2

WebKit2: Can't open ftp directory
<rdar://problem/8489321>

Reviewed by Brady Eidson.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetForceFTPDirectoryListings):
(WKPreferencesGetForceFTPDirectoryListings):
(WKPreferencesSetFTPDirectoryTemplatePath):
(WKPreferencesGetFTPDirectoryTemplatePath):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe through the FTP directory listing preferences.

12:43 PM Changeset in webkit [73541] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectations update.
fast/dom/HTMLMeterElement/meter-element.html has been rebaselined for Windows.

  • platform/chromium/test_expectations.txt:
12:43 PM Changeset in webkit [73540] by cmarrin@apple.com
  • 11 edits
    1 copy in trunk

2010-12-08 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388

Added copy constructors and casting operators to go between
TransformationMatrix and CATransform3D. Also added a copy
constructor to go from CGAffineTransform to TransformationMatrix.
Used these new methods to clean up platform CA code. This will
make it easier to port to Windows.

I also fixed a couple of build issues found when trying out a
Windows build.

This is a resubmission of changesets r73477 and r73483 with a
fix for the SL build. The failure was because TransformationMatrix
included QuartzCore/CATransform3D.h which brought in some system
libraries, including Quickdraw, which has a definition for
'Cursor' which clashed with WebCore's 'Cursor' class. So I had
to qualify its use in WebChromeClient.cpp in WebKit2.

12:29 PM Changeset in webkit [73539] by kov@webkit.org
  • 15 edits
    1 add in trunk/WebKit/gtk

2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698

Split private bits of WebKitWebView to its own private header, and
to its implementation file. Take the opportunity to fix includes
sorting to comply with the style guide.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::enterFullscreenForNode): (WebKit::ChromeClient::exitFullscreenForNode):
  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • WebCoreSupport/DragClientGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/EditorClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/InspectorClientGtk.cpp:
  • WebCoreSupport/PasteboardHelperGtk.cpp:
  • webkit/webkitprivate.cpp: (webkit_init):
  • webkit/webkitprivate.h:
  • webkit/webkitwebbackforwardlist.cpp:
  • webkit/webkitwebdatasource.cpp:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebview.cpp: (WebKit::core): (WebKit::kit): (WebKit::webViewEnterFullscreen): (WebKit::webViewExitFullscreen):
  • webkit/webkitwebviewprivate.h: Added.
12:25 PM Changeset in webkit [73538] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip svg/custom/clip-path-referencing-use2.svg, not svg/custom/clip-path-referencing-use.svg

The former is the real problem. The latter was just the victim!

  • platform/win/Skipped:
12:18 PM Changeset in webkit [73537] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectations update.
fast/text/decomposed-after-stacked-diacritics.html crashes on Chromium Linux.

  • platform/chromium/test_expectations.txt:
11:59 AM Changeset in webkit [73536] by rniwa@webkit.org
  • 1 edit
    21 adds in trunk/LayoutTests

2010-12-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaseline for r73531.

  • platform/chromium-linux/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/rtl-static-positioning-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/table-cell-static-position-expected.png: Added.
  • platform/chromium-mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
  • platform/chromium-mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
  • platform/chromium-mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
  • platform/chromium-mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
  • platform/chromium-mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
  • platform/chromium-mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/rtl-static-positioning-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/table-cell-static-position-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/table-cell-static-position-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:26 AM Changeset in webkit [73535] by bweinstein@apple.com
  • 40 edits
    1 delete in trunk

Layering Violation in ContextMenu - member variable of type HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=50586

Reviewed by John Sullivan.

WebCore:

ContextMenu had a layering violation by having a member variable of type HitTestResult, because
classes in WebCore/platform can't know about classes in WebCore.

This patch moves the HitTestResult and all functions that use it out of ContextMenu into ContextMenuController.
All of the functions that dealt with populating the ContextMenu are now in ContextMenuController, and this
allowed us to delete the ContextMenu file, putting all of the cross-platform code that used to be it
in ContextMenuController, and the rest of the code is in the platform-specific files.

No change in behavior, no new tests.

  • Android.mk: Removed ContextMenu.cpp.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::ContextMenuController): Initialized m_hitTestResult to an empty HitTestResult.
(WebCore::ContextMenuController::handleContextMenuEvent): Call populate on the ContextMenuController instead

of the ContextMenu.

(WebCore::ContextMenuController::createContextMenu): Fix some indination, and store the HitTestResult in a member

variable.

(WebCore::ContextMenuController::showContextMenu): Call addInspectElementItem on the ContextMenuController.
(WebCore::ContextMenuController::contextMenuItemSelected): Use m_hitTestResult whenever we need a HitTestResult.
(WebCore::ContextMenuController::appendItem): Validates the item for its state, and then appends it to the parent menu.

This allowed us to move checkOrEnableIfNeeded from ContextMenu.

These functions were all moved from ContextMenu, and changed slightly to fit in ContextMenuController.
All calls to ContextMenu::appendItem were changed to ContextMenuController::appendItem, which takes care
of validating the menu.
(WebCore::separatorItem): Moved from ContextMenu.
(WebCore::ContextMenuController::createAndAppendFontSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSpeechSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendWritingDirectionSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendTextDirectionSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSubstitutionsSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendTransformationsSubMenu): Ditto.
(WebCore::selectionContainsPossibleWord): Ditto.
(WebCore::ContextMenuController::populate): Ditto.
(WebCore::ContextMenuController::addInspectElementItem): Ditto.
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.

  • page/ContextMenuController.h:

(WebCore::ContextMenuController::hitTestResult): Returns the HitTestResult of the current ContextMenu.

  • platform/ContextMenu.cpp: Removed.
  • platform/ContextMenu.h:
  • platform/efl/ContextMenuEfl.cpp:

(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.

  • platform/gtk/ContextMenuGtk.cpp:

(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Ditto.

  • platform/haiku/ContextMenuHaiku.cpp:

(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Ditto.
(WebCore::ContextMenu::insertItem): Ditto.

  • platform/mac/ContextMenuMac.mm:

(-[WebCoreMenuTarget validateMenuItem:]): Calls checkOrEnableIfNeeded on the controller instead of

the context menu.

(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
(WebCore::ContextMenu::insertItem): Ditto.

  • platform/win/ContextMenuWin.cpp:

(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::insertItem): Removed the call to checkOrEnableIfNeeded.

  • platform/wx/ContextMenuWx.cpp:

(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(ContextMenu::appendItem): Ditto.

WebKit/chromium:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

  • src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspelledWord):
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

WebKit/gtk:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

  • WebCoreSupport/ContextMenuClientGtk.cpp:

(WebKit::ContextMenuClient::getCustomMenuFromDefaultItems):

WebKit/mac:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::getCustomMenuFromDefaultItems):
(WebContextMenuClient::contextMenuItemSelected):

  • WebView/WebHTMLView.mm:

(-[WebMenuTarget validateMenuItem:]):

WebKit/qt:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

  • Api/qwebpage.cpp:

(QWebPagePrivate::createContextMenu):
(QWebPage::updatePositionDependentActions):

WebKit/win:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the

ContextMenuController (from the page).

(WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.

  • WebView.cpp:

(WebView::handleContextMenuEvent): Ditto.

WebKit2:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::WebContextMenuItemData): Remove the call to checkOrEnableItem, that call will be made when

the ContextMenuItem is added to the ContextMenu through the ContextMenuController.

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

11:17 AM Changeset in webkit [73534] by mrobinson@webkit.org
  • 4 edits in trunk

2010-12-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by John Sullivan.

[GTK] Layering violation in ContextMenuGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=50676

ContextMenuGtk accesses the page's ContextMenuController, which is a layering
violation. This was fixed for Mac with change r73469. We make a similar fix here
by moving the "activated" signal connection to the WebKit layer.

  • platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::appendItem): Remove access of ContextMenuController. This is a layering violation.

2010-12-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by John Sullivan.

[GTK] Layering violation in ContextMenuGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=50676

ContextMenuGtk accesses the page's ContextMenuController, which is a layering
violation. This was fixed for Mac with change r73469. We make a similar fix here
by moving the "activated" signal connection to the WebKit layer.

  • webkit/webkitwebview.cpp: (popupMenuItemActivated): Have ContextMenuController handle this signal. (webkit_web_view_forward_context_menu_event): For all items in the untouched context menu, connect their "activated" signal to the new popupMenuItemActivated handler.
11:06 AM Changeset in webkit [73533] by jberlin@webkit.org
  • 16 edits in trunk

WebKit2: Implement WebChromeClient::exceededDatabaseQuota
https://bugs.webkit.org/show_bug.cgi?id=50656

Reviewed by Adam Roben.

WebCore:

  • WebCore.exp.in:

Export the symbol for SecurityOrigin::databaseIdentifier.

WebKit2:

The exceededDatabaseQuota call from the WebProcess to the UIProcess needs to be synchronous
because the new quota is checked directly after exceededDatabaseQuota returns in order to
determine if the new Database can be created.

Pass all of the details from the WebProcess to the UIProcess in order to inform the
decision in the UIProcess about the new quota. In WebKit1, these details were
fetched through an additional call to the API detailsForDatabase (which is infeasible in
WebKit2 since exceededDatabaseQuota is a synchronous call).

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add a version that takes 7 parameters.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):
Indicate that exceededDatabaseQuota is not implemented.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::exceededDatabaseQuota):
Call the UIClient's exceededDatabaseQuota

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::exceededDatabaseQuota):
If the client does not implement exceededDatabaseQuota, return a the current quota.

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):
Send a synchronous message to the UIProcess to ask for the new quota for the origin for the
given frame.

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):
Indicate that exceededDatabaseQuota is not implemented.

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):
Ditto.

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
Ditto.
(WTR::TestController::initialize):
Ditto.

11:02 AM Changeset in webkit [73532] by Csaba Osztrogonác
  • 6 edits in trunk/WebCore

2010-12-08 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r73521.
http://trac.webkit.org/changeset/73521
https://bugs.webkit.org/show_bug.cgi?id=50640

It broke 90 layout tests

  • bindings/js/JSDOMBinding.cpp: (WebCore::printErrorMessageForFrame):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
  • page/DOMWindow.cpp:
  • page/DOMWindow.h:
10:31 AM Changeset in webkit [73531] by hyatt@apple.com
  • 3 edits
    12 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=50576

Reviewed by Anders Carlsson.

REGRESSION in position of autocomplete popup on RTL page.

RTL static position computation did not subtract out the width of the enclosing box if the
immediate parent was a RenderInline. This bug was exposed by properly changing the RenderView
to be RTL when the document was RTL.

Added three new tests in fast/block/positioning.

WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth):

LayoutTests:

  • fast/block/positioning/rtl-static-positioning-inline-block.html: Added.
  • fast/block/positioning/rtl-static-positioning.html: Added.
  • fast/block/positioning/table-cell-static-position.html: Added.
  • platform/mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
  • platform/mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
  • platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
  • platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
  • platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
  • platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
  • platform/mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
  • platform/mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
  • platform/mac/fast/block/positioning/table-cell-static-position-expected.txt: Added.
10:29 AM Changeset in webkit [73530] by xji@chromium.org
  • 10 edits
    6 copies in branches/chromium/597

Merge 73529 - 2010-12-08 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370

Tests: fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html

fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html

  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):

2010-12-08 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370

  • fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
  • fast/dom/horizontal-scrollbar-in-rtl.html:
  • fast/dom/vertical-scrollbar-in-rtl-expected.txt:
  • fast/dom/vertical-scrollbar-in-rtl.html:
  • fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
  • fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html: Added.
  • fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
  • fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
  • platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
  • platform/chromium/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/chromium/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
  • platform/gtk/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
  • platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
  • platform/win/Skipped:
  • platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
  • platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:

TBR=xji@chromium.org

10:14 AM Changeset in webkit [73529] by xji@chromium.org
  • 18 edits
    6 adds in trunk

2010-12-08 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370

Tests: fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html

fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html

  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):

2010-12-08 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370

  • fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
  • fast/dom/horizontal-scrollbar-in-rtl.html:
  • fast/dom/vertical-scrollbar-in-rtl-expected.txt:
  • fast/dom/vertical-scrollbar-in-rtl.html:
  • fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
  • fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html: Added.
  • fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
  • fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
  • platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
  • platform/chromium/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/chromium/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
  • platform/gtk/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
  • platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
  • platform/win/Skipped:
  • platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
  • platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
10:01 AM Changeset in webkit [73528] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, cleaning up test expectations after r7349.

  • platform/chromium/test_expectations.txt:
9:47 AM Changeset in webkit [73527] by tonikitoo@webkit.org
  • 8 edits in trunk

2010-12-08 Antonio Gomes <agomes@rim.com>

Reviewed by Martin Robinson.

[Gtk] Populate DumpRenderTreeSupportGtk (part III)
https://bugs.webkit.org/show_bug.cgi?id=48429

WebKit/gtk:

Adjusted some call sites of previously internal API declared
webkitprivate.h that have moved to DumpRenderTreeSupportGtk.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::gcCollectJavascriptObjects): (DumpRenderTreeSupportGtk::gcCollectJavascriptObjectsOnAlternateThread): (DumpRenderTreeSupportGtk::gcCountJavascriptObjects): (DumpRenderTreeSupportGtk::layoutFrame):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:

WebKitTools:

Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:

  • webkit_gc_collect_javascript_objects;
  • webkit_gc_collect_javascript_objects_on_alternate_thread;
  • webkit_gc_count_javascript_objects;
  • webkit_web_frame_layout.

These were all only used by GTK+ DRT.

  • DumpRenderTree/gtk/EventSender.cpp: (dispatchEvent):
  • DumpRenderTree/gtk/GCControllerGtk.cpp: (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
9:37 AM Changeset in webkit [73526] by Simon Fraser
  • 9 edits in trunk

2010-12-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix pauseAnimation API to work with shorthand properties
https://bugs.webkit.org/show_bug.cgi?id=50639

The pause API is always called with a long-hand property, but that
property may be animating via a shorthand. Detect this, and pause
such shorthand animations.

  • page/animation/AnimationBase.cpp: (WebCore::ShorthandPropertyWrapper::propertyWrappers): Expose the vector of wrappers used by a shorthand wrapper.

(WebCore::gatherEnclosingShorthandProperties): Utility function that walks
through the shorthand wrappers, keeping track of which can affect the given
property.
(WebCore::AnimationBase::animatableShorthandsAffectingProperty): Return a set
of shorthand properties that can affect the given property.

  • page/animation/AnimationBase.h: New method.
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::pauseTransitionAtTime): If we don't find the property itself, check whether it's being animated via shorthands.
8:55 AM Changeset in webkit [73525] by hyatt@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/8740920> Gestures: Frame::scalePage() broken by r73885

Reviewed by Beth Dakin.

Make sure the transform applied to the RenderView for page scaling is incorporated into the
docTop/Bottom/Left/Right accessors.

  • rendering/RenderView.cpp:

(WebCore::RenderView::docTop):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docRight):

8:54 AM Changeset in webkit [73524] by loislo@chromium.org
  • 4 edits in trunk/WebCore

2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Protocol cleanup task. Remove WebInspector wrappers
for TimelineAgent functions.

https://bugs.webkit.org/show_bug.cgi?id=50690

  • inspector/Inspector.idl:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.timelineProfilerWasStarted): (WebInspector.TimelinePanel.prototype.timelineProfilerWasStopped):
8:49 AM Changeset in webkit [73523] by Philippe Normand
  • 4 edits in trunk

2010-12-08 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] media/fullscreen* failing on 64-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=50394

Avoid emiting durationchanged in the case where the previous
duration was 0 because that case is already handled by the
HTMLMediaElement.

Test: media/media-fullscreen*.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::durationChanged):

LayoutTests:

Reviewed by Gustavo Noronha Silva.

[GTK] media/fullscreen* failing on 64-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=50394

  • platform/gtk/Skipped: Unskip now passing tests.
8:22 AM Changeset in webkit [73522] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Remove WIN prefix for inspector's tests expectations.
DumpRenderTree related patch.

  • platform/chromium/test_expectations.txt:
8:22 AM Changeset in webkit [73521] by Darin Adler
  • 6 edits in trunk/WebCore

2010-12-07 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
https://bugs.webkit.org/show_bug.cgi?id=50640

  • bindings/js/JSDOMBinding.cpp: (WebCore::printErrorMessageForFrame): Removed body; just call through to DOMWindow::printErrorMessage.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body; just call through to DOMWindow::crossDomainAccessErrorMessage.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFrame and firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most of the body and moved it into DOMWindow::setLocation.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): Added. Does all the same work that JSDOMWindow::setLocation used to do, but in a way that's not specific to JavaScript. (WebCore::DOMWindow::printErrorMessage): Added. (WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.
  • page/DOMWindow.h: Added setLocation, printErrorMessage, and crossDomainAccessErrorMessage.
8:07 AM Changeset in webkit [73520] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip svg/custom/clip-path-referencing-use.svg on Windows

The test fails when run under Aero. It seems that one of our Windows 7
bots has this turned on while the other doesn't.

  • platform/win/Skipped:
8:02 AM Changeset in webkit [73519] by alex
  • 20 edits
    5 deletes in trunk

2010-12-08 Alejandro G. Castro <alex@igalia.com>

Unreviewed, rolling out r73494.
http://trac.webkit.org/changeset/73494
https://bugs.webkit.org/show_bug.cgi?id=50380

The tests added are crashing in the debug bots (macn and gtk)

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::setSelectedIndexByUser): (WebCore::HTMLSelectElement::listBoxSelectItem): (WebCore::HTMLSelectElement::add): (WebCore::HTMLSelectElement::remove): (WebCore::HTMLSelectElement::restoreFormControlState): (WebCore::HTMLSelectElement::parseMappedAttribute): (WebCore::HTMLSelectElement::selectAll): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::updateListBoxSelection): (WebCore::HTMLSelectElement::setLength):
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl):
  • html/HTMLSelectElement.idl:
  • html/ValidityState.cpp: (WebCore::ValidityState::valueMissing):

2010-12-08 Alejandro G. Castro <alex@igalia.com>

Unreviewed, rolling out r73494.
http://trac.webkit.org/changeset/73494
https://bugs.webkit.org/show_bug.cgi?id=50380

The tests added are crashing in the debug bots (macn and gtk)

  • fast/forms/ValidityState-valueMissing-001-expected.txt:
  • fast/forms/ValidityState-valueMissing-001.html:
  • fast/forms/ValidityState-valueMissing-002-expected.txt:
  • fast/forms/ValidityState-valueMissing-002.html:
  • fast/forms/ValidityState-valueMissing-003-expected.txt:
  • fast/forms/ValidityState-valueMissing-003.html:
  • fast/forms/checkValidity-002-expected.txt:
  • fast/forms/checkValidity-002.html:
  • fast/forms/required-attribute-001-expected.txt:
  • fast/forms/required-attribute-001.html:
  • fast/forms/required-attribute-002-expected.txt:
  • fast/forms/required-attribute-002.html:
  • fast/forms/resources/select-live-pseudo-selectors.js: Removed.
  • fast/forms/script-tests/validationMessage.js:
  • fast/forms/select-live-pseudo-selectors-expected.txt: Removed.
  • fast/forms/select-live-pseudo-selectors.html: Removed.
  • fast/forms/validationMessage-expected.txt:
  • platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Removed.
  • platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Removed.
7:34 AM Changeset in webkit [73518] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Just enable inspector's tests for chromium linux.
This change is related to switching to DumpRenderTree.

  • platform/chromium/test_expectations.txt:
7:29 AM Changeset in webkit [73517] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Land Windows results for test added in 73423

  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
7:28 AM Changeset in webkit [73516] by Adam Roben
  • 8 edits in trunk/LayoutTests

Update Windows results after r73488

  • platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
7:25 AM Changeset in webkit [73515] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-08 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping failing test.

[GTK] r73488 broke fast/dom/HTMLProgressElement/progress-element.html
https://bugs.webkit.org/show_bug.cgi?id=50687

  • platform/gtk/Skipped:
6:24 AM Changeset in webkit [73514] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-08 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Update Chromium test expectations. Remove some tests that are now consistently
passing, assign bug numbers, and add one new expectation.

  • platform/chromium/test_expectations.txt:
6:17 AM Changeset in webkit [73513] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-08 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskipping media/video-buffered.html on GTK because
the bots are now running with latest GStreamer.

  • platform/gtk/Skipped:
5:52 AM Changeset in webkit [73512] by Philippe Normand
  • 5 edits in trunk/LayoutTests

2010-12-08 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskipped some more media tests.

They are not crashing anymore, they also needed a rebaseline since
the font tiling changes that happened while they were skipped.

  • platform/gtk/Skipped:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/video-layer-crash-expected.txt:
  • platform/gtk/media/video-transformed-expected.txt:
5:27 AM Changeset in webkit [73511] by loislo@chromium.org
  • 4 edits in trunk/WebCore

2010-12-07 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Inspector protocol cleanup task. Remove
WebInspector wrappers for DOMAgent functions.

There were a lot of wrappers in WebInspector namespace
for different WebInspector agents functions. As far as we have a
generic mechanic for such functions we can remove these
wrappers and register domAgent instance as a handler for
DOM domain notifications.

https://bugs.webkit.org/show_bug.cgi?id=50626

4:52 AM Changeset in webkit [73510] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

2010-12-08 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update test expectations after r73504.

  • http/tests/inspector/console-resource-errors-expected.txt:
  • platform/chromium/test_expectations.txt:
4:31 AM Changeset in webkit [73509] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-08 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Update Chromium test expectations. Add two test flakinesses which was
introduced at r73504.

  • platform/chromium/test_expectations.txt:
4:14 AM Changeset in webkit [73508] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-08 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Update Chromium test expectations. Added a few failures which was found
in Chromium main waterfall.

  • platform/chromium/test_expectations.txt:
4:12 AM Changeset in webkit [73507] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

The storage for the subresources is a GHashTable which does not
guarantee order, so we need to make our checking more resilient.

  • tests/testwebresource.c: (test_web_resource_sub_resource_loading):
3:52 AM Changeset in webkit [73506] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

[GTK] Fails back to POST tests
https://bugs.webkit.org/show_bug.cgi?id=50678

Skip new tests that we are failing.

  • platform/gtk/Skipped:
3:42 AM Changeset in webkit [73505] by kov@webkit.org
  • 1 edit
    1 move in trunk/WebKit/gtk/po

2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Fix name of the Korean translation file.

  • kr.po -> ko.po: renamed to correct name.
3:28 AM Changeset in webkit [73504] by yurys@chromium.org
  • 11 edits in trunk

2010-12-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove groupLevel counter from console messages
https://bugs.webkit.org/show_bug.cgi?id=50672

  • inspector/console-tests-expected.txt:

2010-12-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove groupLevel counter from console messages
https://bugs.webkit.org/show_bug.cgi?id=50672

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup):
  • inspector/InspectorController.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createFilterElement): (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype.filter): (WebInspector.ConsoleView.prototype.afterShow): (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.createTextMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype._addMessageHeader): (WebInspector.ConsoleMessage.prototype._updateRepeatCount): (WebInspector.ConsoleMessage.prototype.toString): (WebInspector.ConsoleMessage.prototype.isEqual): (WebInspector.ConsoleGroup):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._checkWarning):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addMessageToSource):
  • inspector/front-end/inspector.js: (WebInspector.addConsoleMessage): (WebInspector.log.logMessage): (WebInspector.log):
3:23 AM Changeset in webkit [73503] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed. Add new tests introduced in r73484 to the Skipped list,
because layoutTestController.testRepaint() is unimplemented in Qt DRT.

  • platform/qt/Skipped:
    • fast/repaint/table-writing-modes-h.html added
    • fast/repaint/table-writing-modes-v.html added
3:17 AM Changeset in webkit [73502] by Csaba Osztrogonác
  • 13 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r73488.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
3:17 AM Changeset in webkit [73501] by podivilov@chromium.org
  • 11 edits
    2 adds in trunk/WebCore

2010-12-07 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: introduce DebuggerModel class representing InspectorDebuggerAgent state.
https://bugs.webkit.org/show_bug.cgi?id=50567

Moved debugging-related code from BreakpointManager to DebuggerModel. Moved Breakpoint class to a separate file.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Breakpoint.js: Added. (WebInspector.Breakpoint): Moved from BreakpointManager.js.
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): Remove debugger-related methods.
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
  • inspector/front-end/DebuggerModel.js: Added. (WebInspector.DebuggerModel): Moved debugger-related methods from BreakpointManager.
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.continueToLine): (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._debuggerResumed): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrameDelegate.prototype.addBreakpoint): (WebInspector.SourceFrameDelegate.prototype.breakpoints): (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.createJSBreakpointsSidebarPane): (WebInspector.restoredBreakpoint): (WebInspector.pausedScript): (WebInspector.resumedScript): (WebInspector.reset):
3:07 AM Changeset in webkit [73500] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-08 Philippe Normand <pnormand@igalia.com>

Unreviewed, updated baselines of
media/video-controls-rendering.html.

  • platform/gtk/media/video-controls-rendering-expected.txt:
2:44 AM Changeset in webkit [73499] by podivilov@chromium.org
  • 10 edits in trunk

2010-12-08 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: SourceFrame refactoring.
https://bugs.webkit.org/show_bug.cgi?id=50223

  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-pause-on-breakpoint.html:

2010-12-08 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: SourceFrame refactoring.
https://bugs.webkit.org/show_bug.cgi?id=50223

SourceFrame should ask BreakpointManager about existing breakpoints instead of maintaining
it's own storages. Move common code from ScriptView and SourceView to SourceFrame.

  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.findBreakpoints): (WebInspector.BreakpointManager.prototype.findBreakpoint):
  • inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.get linesCount): (WebInspector.Script.prototype.get source): (WebInspector.Script.prototype.set source):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype._scriptSourceChanged): (WebInspector.ScriptFrameDelegateImpl): (WebInspector.ScriptFrameDelegateImpl.prototype.canEditScripts): (WebInspector.ScriptFrameDelegateImpl.prototype.editLineComplete): (WebInspector.ScriptFrameDelegateImpl.prototype.scripts):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): Add common methods of ScriptView and SourceView. (WebInspector.SourceFrameDelegate): (WebInspector.SourceFrameDelegate.prototype.canEditScripts): (WebInspector.SourceFrameDelegate.prototype.editLineComplete): (WebInspector.SourceFrameDelegate.prototype.scripts):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype._contentLoaded): (WebInspector.ResourceFrameDelegateImpl): (WebInspector.ResourceFrameDelegateImpl.prototype.canEditScripts): (WebInspector.ResourceFrameDelegateImpl.prototype.editLineComplete): (WebInspector.ResourceFrameDelegateImpl.prototype.scripts):
2:25 AM Changeset in webkit [73498] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-12-08 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskipping media/video-controls-rendering.html on GTK.

It should now not crash anymore because the GTK bots have been
upgraded to latest GStreamer releases.

  • platform/gtk/Skipped:
2:22 AM Changeset in webkit [73497] by alex
  • 2 edits in trunk/WebKit/gtk

2010-12-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

Fix assertion in the API test, we are requesting the favicon and
the subresource so we have to make sure we are assigning just the
first subresource.

  • tests/testwebresource.c: (resource_request_starting_sub_cb):
1:35 AM Changeset in webkit [73496] by yutak@chromium.org
  • 14 edits
    1 add in trunk/WebCore

2010-12-08 Yuta Kitamura <yutak@chromium.org>

Unreviewed, rolling out r73492.
http://trac.webkit.org/changeset/73492
https://bugs.webkit.org/show_bug.cgi?id=49914

Caused a lot of pixel test failures and broke Windows build.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::setStrokeThickness): (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setStrokeColor): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::getShadow): (WebCore::GraphicsContext::strokeThickness): (WebCore::GraphicsContext::strokeStyle): (WebCore::GraphicsContext::strokeColor): (WebCore::GraphicsContext::strokeColorSpace): (WebCore::GraphicsContext::fillRule): (WebCore::GraphicsContext::setFillRule): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::fillColorSpace): (WebCore::GraphicsContext::setShouldAntialias): (WebCore::GraphicsContext::shouldAntialias): (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient): (WebCore::GraphicsContext::fillGradient): (WebCore::GraphicsContext::strokeGradient): (WebCore::GraphicsContext::fillPattern): (WebCore::GraphicsContext::strokePattern): (WebCore::GraphicsContext::setShadowsIgnoreTransforms): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::textDrawingMode): (WebCore::GraphicsContext::setTextDrawingMode):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke): (WebCore::drawPathShadow): (WebCore::fillCurrentCairoPath): (WebCore::strokeCurrentCairoPath): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::getAlpha):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::strokeRect):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext):
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::addInnerRoundedRectClip):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::GraphicsContext):
  • platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::GraphicsContext):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext):
1:34 AM Changeset in webkit [73495] by yurys@chromium.org
  • 1 edit in branches/chromium/597/WebCore/bindings/v8/ScriptDebugServer.cpp

Merge 73441 - 2010-12-07 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: avoid initializing Context on when creating attaching listener to ScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=50627

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::addListener): don't try to collect already parsed scripts if context has not been initialized yet.

TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/5664002

12:43 AM Changeset in webkit [73494] by commit-queue@webkit.org
  • 20 edits
    5 adds in trunk

2010-12-08 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement "required" attribute for select tags
https://bugs.webkit.org/show_bug.cgi?id=50380

Added tests for require attributes, valueMissing and vadility check for select elements.

  • fast/forms/ValidityState-valueMissing-001-expected.txt:
  • fast/forms/ValidityState-valueMissing-001.html:
  • fast/forms/ValidityState-valueMissing-002-expected.txt:
  • fast/forms/ValidityState-valueMissing-002.html:
  • fast/forms/ValidityState-valueMissing-003-expected.txt:
  • fast/forms/ValidityState-valueMissing-003.html:
  • fast/forms/checkValidity-002-expected.txt:
  • fast/forms/checkValidity-002.html:
  • fast/forms/required-attribute-001-expected.txt:
  • fast/forms/required-attribute-001.html:
  • fast/forms/required-attribute-002-expected.txt:
  • fast/forms/required-attribute-002.html:
  • fast/forms/resources/select-live-pseudo-selectors.js: Added. (makeInvalid): (appendOption): (backgroundOf):
  • fast/forms/script-tests/validationMessage.js:
  • fast/forms/select-live-pseudo-selectors-expected.txt: Added.
  • fast/forms/select-live-pseudo-selectors.html: Added.
  • fast/forms/validationMessage-expected.txt:
  • platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Added.
  • platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Added.

2010-12-08 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement "required" attribute for select tags
https://bugs.webkit.org/show_bug.cgi?id=50380

Test: fast/forms/select-live-pseudo-selectors.html

platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface. (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified. (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180. (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated.. (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck(). (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not. (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
  • html/HTMLSelectElement.idl: Added a required attribute to select elements..
  • html/ValidityState.cpp: (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
12:08 AM Changeset in webkit [73493] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-08 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
12:05 AM Changeset in webkit [73492] by reni@webkit.org
  • 14 edits
    1 delete in trunk/WebCore

2010-12-08 Renata Hodovan <reni@webkit.org>

Reviewed by Andreas Kling.

GraphicsContext: Merge m_common and m_data
https://bugs.webkit.org/show_bug.cgi?id=49914

Move data members from GraphicsContextPrivate into GraphicsContext. So GraphicsContextPlatform.h
and m_common became unnecessary. They are removed.
Add two methods to GraphicsContext: platformInit() and platformDestroy(), which
make the constructor of GraphicsContext clearer.
Besides add a getter to the private GraphicsContext::m_state member, because some inline
functions in cairo need it.

No new test is needed, because this is a refactoring.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::setStrokeThickness): (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setStrokeColor): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::getShadow): (WebCore::GraphicsContext::strokeThickness): (WebCore::GraphicsContext::strokeStyle): (WebCore::GraphicsContext::strokeColor): (WebCore::GraphicsContext::strokeColorSpace): (WebCore::GraphicsContext::fillRule): (WebCore::GraphicsContext::setFillRule): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::fillColorSpace): (WebCore::GraphicsContext::setShouldAntialias): (WebCore::GraphicsContext::shouldAntialias): (WebCore::GraphicsContext::state): (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient): (WebCore::GraphicsContext::fillGradient): (WebCore::GraphicsContext::strokeGradient): (WebCore::GraphicsContext::fillPattern): (WebCore::GraphicsContext::strokePattern): (WebCore::GraphicsContext::setShadowsIgnoreTransforms): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::textDrawingMode): (WebCore::GraphicsContext::setTextDrawingMode):
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState):
  • platform/graphics/GraphicsContextPrivate.h: Removed.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke): (WebCore::drawPathShadow): (WebCore::fillCurrentCairoPath): (WebCore::strokeCurrentCairoPath): (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::getAlpha):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::strokeRect):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy):
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::addInnerRoundedRectClip):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::platformInit):
  • platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::platformInit):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::platformInit): (WebCore::GraphicsContext::platformDestroy):

Dec 7, 2010:

10:45 PM Changeset in webkit [73491] by antonm@chromium.org
  • 3 edits in trunk/WebCore

2010-12-07 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

Port http://trac.webkit.org/changeset/72819/ to v8-backed ports.
https://bugs.webkit.org/show_bug.cgi?id=50246

  • bindings/v8/V8DOMMap.h: (WebCore::AbstractWeakReferenceMap::Visitor::startMap): (WebCore::AbstractWeakReferenceMap::Visitor::endMap): (WebCore::WeakReferenceMap::visit):
  • bindings/v8/V8GCController.cpp: (WebCore::GrouperItem::GrouperItem): (WebCore::GrouperItem::groupId): (WebCore::makeV8ObjectGroups): (WebCore::NodeGrouperVisitor::NodeGrouperVisitor): (WebCore::NodeGrouperVisitor::visitDOMWrapper): (WebCore::NodeGrouperVisitor::applyGrouping): (WebCore::DOMObjectGrouperVisitor::ObjectGrouperVisitor): (WebCore::DOMObjectGrouperVisitor::startMap): (WebCore::DOMObjectGrouperVisitor::endMap): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper): (WebCore::V8GCController::gcPrologue):
8:49 PM Changeset in webkit [73490] by dbates@webkit.org
  • 5 edits
    20 adds in trunk

2010-12-07 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Implement focus ring support for image maps
https://bugs.webkit.org/show_bug.cgi?id=50371

Implement GraphicsContext::drawFocusRing(const Path&, ...) so as to support
drawing a focus ring for image maps.

Tests: fast/images/imagemap-circle-focus-ring.html

fast/images/imagemap-polygon-focus-ring.html

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::adjustFocusRingColor): Added. (WebCore::adjustFocusRingLineWidth): Added. (WebCore::focusRingStrokeStyle): Added. (WebCore::GraphicsContext::drawFocusRing): Moved code for determining focus ring- color, line width and stroke style into functions adjustFocusRingColor(), adjustFocusRingLineWidth(), and focusRingStrokeStyle(), respectively. Implemented GraphicsContext::drawFocusRing(const Path&, ...).

2010-12-07 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Implement focus ring support for image maps
https://bugs.webkit.org/show_bug.cgi?id=50371

Tests to ensure that we support drawing a focus ring for an image map.
In particular, that the GTK port can draw a focus ring for an image map.

  • fast/images/imagemap-circle-focus-ring.html: Added.
  • fast/images/imagemap-polygon-focus-ring.html: Added.
  • platform/gtk/fast/images/imagemap-circle-focus-ring-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/gtk/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-expected.checksum: Rebase result since we now support drawing a focus ring for imagemaps.
  • platform/gtk/fast/images/imagemap-focus-ring-expected.png: Ditto.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
  • platform/mac/fast/images/imagemap-circle-focus-ring-expected.checksum: Added.
  • platform/mac/fast/images/imagemap-circle-focus-ring-expected.png: Added.
  • platform/mac/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
  • platform/mac/fast/images/imagemap-polygon-focus-ring-expected.checksum: Added.
  • platform/mac/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
  • platform/mac/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
8:33 PM Changeset in webkit [73489] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-07 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitSoupCache fails to load resources when cache contents are externally removed
https://bugs.webkit.org/show_bug.cgi?id=50577

Try to download cached resources again if they are no longer
accesible by the cache.

  • platform/network/soup/cache/soup-request-http.c: (send_async_cb): (webkit_soup_request_http_send_async):
8:21 PM Changeset in webkit [73488] by morrita@google.com
  • 21 edits
    2 adds in trunk

2010-12-05 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

  • Added a test case
  • Updated expectations to follow the change on the shadow structure.

RenderIndicator subclasses should not change the render tree during layout.
https://bugs.webkit.org/show_bug.cgi?id=50026

  • fast/dom/HTMLMeterElement/meter-element-crash-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-element-crash.html: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

2010-12-06 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

RenderIndicator subclasses should not change the render tree during layout.
https://bugs.webkit.org/show_bug.cgi?id=50026

The old code created shadow elements during a layout computation,
that makes the layout state inconsisntent and cause an assertion failure.
This change created shadow elements before the layout to avoid
state inconsistencies.

Instead of creating shadows on demand, RenderMeter and
RenderProgress now create all necessary shadows before layouts,
and change its visibilities during the layout: Changing
visibilities doesn't trigger relayout and keep the state
consistent.

RenderMeter uses new HidablePartElement for shadow elements,
which can toggle visibiliby between hidden and original value.

Test: fast/dom/HTMLMeterElement/meter-element-crash.html

  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::attach): Calling updateFromElement()
  • html/HTMLMeterElement.h:
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::attach): Calling updateFromElement()
  • html/HTMLProgressElement.h:
  • rendering/RenderIndicator.cpp:
  • rendering/RenderIndicator.h:
  • rendering/RenderMeter.cpp: (WebCore::MeterPartElement::MeterPartElement): Added to hold a restorable visibility. (WebCore::MeterPartElement::createForPart): (WebCore::MeterPartElement::hide): (WebCore::MeterPartElement::restoreVisibility): (WebCore::MeterPartElement::updateStyleForPart): (WebCore::MeterPartElement::saveVisibility): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::createPart): Extracted (WebCore::RenderMeter::updateFromElement): Had a shadow generation. (WebCore::RenderMeter::layoutParts): Removed shadow generation code. (WebCore::RenderMeter::shouldHaveParts): (WebCore::RenderMeter::valuePartRect): Adopted orientation. (WebCore::RenderMeter::orientation): Morphed from isHorizontal() (WebCore::RenderMeter::valuePseudoId): Adoptedn orientation (WebCore::RenderMeter::barPseudoId): Adopted orientation.
  • rendering/RenderMeter.h: (WebCore::RenderMeter::shadowAttached):
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::updateFromElement): Had a shadow generation. (WebCore::RenderProgress::layoutParts):
  • rendering/RenderProgress.h:
  • rendering/ShadowElement.cpp: (WebCore::ShadowBlockElement::createForPart): Extracted initAsPart(). (WebCore::ShadowBlockElement::initAsPart): Extracted from createForPart().
  • rendering/ShadowElement.h:
6:44 PM Changeset in webkit [73487] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2010-12-07 Simon Fraser <Simon Fraser>

Relax the matching tolerance to reduce flakiness.

  • transitions/border-radius-transition.html:
6:32 PM Changeset in webkit [73486] by mihaip@chromium.org
  • 6 edits
    10 adds
    2 deletes in trunk

2010-11-29 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

returning to a POST result within a frame does a GET instead of a POST
https://bugs.webkit.org/show_bug.cgi?id=10199

Re-enable postredirect-frames-goback1.html and post-frames-goback1.html
now that the big that made them be checked in disabled was fixed.

The tests were also re-written to not be pixel tests, since that just
adds extra per-platform baseline pain.

Add fast/history/history-back-initial-vs-final-url.html since there did
not appear to be any tests for whether we used the initial or final URL
of a frame's history item (and this patch changes it from the former to
the latter).

  • fast/history/history-back-initial-vs-final-url-expected.txt: Added.
  • fast/history/history-back-initial-vs-final-url.html: Added.
  • fast/history/resources/frame-final-url.html: Added.
  • fast/history/resources/frame-initial-url.html: Added.
  • http/tests/navigation/post-frames-goback1-expected.txt: Added.
  • http/tests/navigation/post-frames-goback1.html: Added.
  • http/tests/navigation/post-frames-goback1.html-disabled: Removed.
  • http/tests/navigation/post-frames.html:
  • http/tests/navigation/postredirect-frames-goback1-expected.txt: Added.
  • http/tests/navigation/postredirect-frames-goback1.html: Added.
  • http/tests/navigation/postredirect-frames-goback1.html-disabled: Removed.
  • http/tests/navigation/resources/form-target.pl:
  • http/tests/navigation/resources/redirect-to-go-back.pl: Added.
  • http/tests/navigation/resources/top-go-back.html: Added.

2010-11-29 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

returning to a POST result within a frame does a GET instead of a POST
https://bugs.webkit.org/show_bug.cgi?id=10199

FrameLoader::loadURLIntoChildFrame had a check for whether a frame
had a HistoryItem, and if so used that item's URL. However, that did
not handle the case where the HistoryItem had FormData and thus was the
result of a POST request. FrameLoader::navigateToDifferentDocument (now
renamed to loadDifferentDocumentItem) does all that, so just switch to
using it instead.

Besides the bug fix, the only difference in behavior is that we use the
HistoryItem's URL instead of original URL when restoring it in a child
frame. This seems desirable too (for consistency with other browsers, and
so that we can avoid form double-submits for forms that that do
POST-then-redirect), and is tested by
fast/history/history-back-initial-vs-final-url.html.

Tests: fast/history/history-back-initial-vs-final-url.html

http/tests/navigation/post-frames-goback1.html
http/tests/navigation/postredirect-frames-goback1.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): Switch to using

loadDifferentDocumentItem. Also cleaned up ordering slightly (if
on the archive path, there's no need to do any of the other checks).

(WebCore::FrameLoader::loadDifferentDocumentItem): Renamed from

navigateToDifferentDocument so that calling it from loadItem and
loadURLIntoChildFrame flows more easily.

(WebCore::FrameLoader::loadSameDocumentItem): Similarly, renamed from

navigateWithinDocument.

(WebCore::FrameLoader::loadItem): Update callsites to the above methods.

  • loader/FrameLoader.h:
6:27 PM Changeset in webkit [73485] by mrowe@apple.com
  • 9 edits
    1 delete in trunk

Roll out r73477 and r73483 since they broke the Mac SnowLeopard build.

5:37 PM Changeset in webkit [73484] by mitz@apple.com
  • 3 edits
    8 adds in trunk

WebCore: Made tables repaint correctly in all writing modes
Part of: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Reviewed by Darin Adler.

Tests: fast/repaint/table-writing-modes-h.html

fast/repaint/table-writing-modes-v.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintObject): Compute the ranges of rows and
columns to repaint based on the logical extent of the repaint rect.

LayoutTests: Test that tables repaint correctly in all writing modes
Part of: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Reviewed by Darin Adler.

  • fast/repaint/table-writing-modes-h-expected.checksum: Added.
  • fast/repaint/table-writing-modes-h-expected.png: Added.
  • fast/repaint/table-writing-modes-h-expected.txt: Added.
  • fast/repaint/table-writing-modes-h.html: Added.
  • fast/repaint/table-writing-modes-v-expected.checksum: Added.
  • fast/repaint/table-writing-modes-v-expected.png: Added.
  • fast/repaint/table-writing-modes-v-expected.txt: Added.
  • fast/repaint/table-writing-modes-v.html: Added.
5:17 PM Changeset in webkit [73483] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2010-12-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Fix build problem from http://trac.webkit.org/changeset/73477

  • platform/graphics/transforms/TransformationMatrix.h:
5:03 PM Changeset in webkit [73482] by jamesr@google.com
  • 2 edits in branches/chromium/597/WebCore

Merge 73479 - 2010-12-07 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by James Robinson.

[chromium] compositor lost context recovery fix
https://bugs.webkit.org/show_bug.cgi?id=50614

To test, load a page that triggers the compositor, kill the GPU
process and hover over a link to redraw and thus restart the GPU
process. Without this patch it will assert in
ContentLayerChromium::updateTextureRect; with this patch it will not.

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setNeedsDisplay):

TBR=amarinichev@chromium.org
BUG=65194

Review URL: http://codereview.chromium.org/5639006

5:02 PM Changeset in webkit [73481] by jschuh@chromium.org
  • 7 edits
    2 copies in branches/chromium/552

2010-12-07 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549

Test: svg/css/cursor-replace.svg

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): (WebCore::SVGCursorElement::removeClient): (WebCore::SVGCursorElement::removeReferencedElement):
  • svg/SVGCursorElement.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::setCursorElement): (WebCore::SVGElement::cursorElementRemoved): (WebCore::SVGElement::setCursorImageValue): (WebCore::SVGElement::cursorImageElementRemoved):
  • svg/SVGElement.h:

2010-12-07 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549

  • svg/css/cursor-replace-expected.txt: Added.
  • svg/css/cursor-replace.svg: Added.

BUG=64959
TBR=jschuh@chromium.org

4:58 PM Changeset in webkit [73480] by jamesr@google.com
  • 3 edits in branches/chromium/597/WebCore

Merge 73424 - 2010-12-06 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Throw webglcontextlost and webglcontextrestored events when a WebGL context is lost and restored.
https://bugs.webkit.org/show_bug.cgi?id=50364

No new tests since there is currently no way to force a context lost event.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired): (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::isContextLost): (WebCore::WebGLRenderingContext::loseContext): (WebCore::WebGLRenderingContext::restoreContext):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::WebGLRenderingContextRestoreTimer):

TBR=amarinichev@chromium.org
BUG=57176

Review URL: http://codereview.chromium.org/5511013

4:53 PM Changeset in webkit [73479] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-12-07 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by James Robinson.

[chromium] compositor lost context recovery fix
https://bugs.webkit.org/show_bug.cgi?id=50614

To test, load a page that triggers the compositor, kill the GPU
process and hover over a link to redraw and thus restart the GPU
process. Without this patch it will assert in
ContentLayerChromium::updateTextureRect; with this patch it will not.

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setNeedsDisplay):
4:41 PM Changeset in webkit [73478] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <tony@chromium.org>

Unreviewed, mark a test as flaky on chromium drt linux.

  • platform/chromium/test_expectations.txt:
4:31 PM Changeset in webkit [73477] by cmarrin@apple.com
  • 9 edits
    1 add in trunk

2010-12-07 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388

Added copy constructors and casting operators to go between
TransformationMatrix and CATransform3D. Also added a copy
constructor to go from CGAffineTransform to TransformationMatrix.
Used these new methods to clean up platform CA code. This will
make it easier to port to Windows.

I also fixed a couple of build issues found when trying out a
Windows build.

4:31 PM Changeset in webkit [73476] by tony@chromium.org
  • 5 edits
    2 adds in trunk/LayoutTests

2010-12-07 Tony Chang <tony@chromium.org>

Unreviewed, adding chromium pixel results for
fast/forms/caret-rtl.html after http://trac.webkit.org/changeset/73459

  • platform/chromium-linux/fast/forms/caret-rtl-expected.checksum:
  • platform/chromium-linux/fast/forms/caret-rtl-expected.png:
  • platform/chromium-mac/fast/forms/caret-rtl-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/caret-rtl-expected.png: Added.
  • platform/chromium-win/fast/forms/caret-rtl-expected.checksum:
  • platform/chromium-win/fast/forms/caret-rtl-expected.png:
4:26 PM Changeset in webkit [73475] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix the last clang++ build error.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::animationForKey):
Cast the returned animation to the correct type.

3:55 PM Changeset in webkit [73474] by andersca@apple.com
  • 4 edits in trunk/WebCore

Fix some clang++ build errors.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Remove unused variable.

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

Fix constness of pointers.

3:54 PM Changeset in webkit [73473] by jschuh@chromium.org
  • 5 edits
    2 copies in branches/chromium/597

Merge 73432 - 2010-12-07 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549

Test: svg/css/cursor-replace.svg

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): (WebCore::SVGCursorElement::removeClient): (WebCore::SVGCursorElement::removeReferencedElement):
  • svg/SVGCursorElement.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::setCursorElement): (WebCore::SVGElement::cursorElementRemoved): (WebCore::SVGElement::setCursorImageValue): (WebCore::SVGElement::cursorImageElementRemoved):
  • svg/SVGElement.h:

2010-12-07 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549

  • svg/css/cursor-replace-expected.txt: Added.
  • svg/css/cursor-replace.svg: Added.

BUG=64959
TBR=jschuh@chromium.org
Review URL: http://codereview.chromium.org/5545007

3:37 PM Changeset in webkit [73472] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-12-07 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Fix the Color -> CGColorRef conversions for the debug colors
used for compositing layers.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::setBackgroundColor): (PlatformCALayer::setBorderColor):
3:31 PM Changeset in webkit [73471] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <tony@chromium.org>

Unreviewed, remove more passing tests (mac) from test_expecatations.txt
after DRT switch. Also remove a test that is passing because of
crankshaft.

  • platform/chromium/test_expectations.txt:
3:13 PM Changeset in webkit [73470] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <tony@chromium.org>

Unreviewed, remove more passing tests (win) from test_expectations.txt
after DRT switch.

  • platform/chromium/test_expectations.txt:
2:47 PM Changeset in webkit [73469] by bweinstein@apple.com
  • 5 edits in trunk

Part of Layering Violation in ContextMenu
https://bugs.webkit.org/show_bug.cgi?id=50586

Reviewed by John Sullivan.

WebCore:

ContextMenuMac.mm had a WebCoreMenuTarget class, which was responsible for wrapping
a ContextMenuItem, and calling through to the ContextMenuController to validate it
and call a function when it was selected.

It was a layering violation to have this class here, because ContextMenu can't know
about ContextMenuController.

This patch moves the class that wraps the ContextMenuItems to WebKit/mac/WebHTMLView.mm,
and sets up the menu targets there.

No change in behavior, no new tests.

  • WebCore.exp.in: Added function that needs to be exported.
  • platform/mac/ContextMenuMac.mm:

(WebCore::ContextMenu::ContextMenu): Don't set the sharedMenuTarget anymore.
(WebCore::ContextMenu::appendItem): Don't call setMenuItemTarget (this is done in WebKit now).
(WebCore::ContextMenu::insertItem): Ditto.

WebKit/mac:

Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
was a layering violation. Also, make sure we set the menu item targets for all menu
items before showing them, because the ContextMenu constructor doesn't do that anymore.

  • WebView/WebHTMLView.mm:

(+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
(-[WebMenuTarget WebCore::]): Ditto.
(-[WebMenuTarget setMenuController:WebCore::]): Ditto.
(-[WebMenuTarget forwardContextMenuAction:]): Ditto.
(-[WebMenuTarget validateMenuItem:]): Ditto.

(setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
(setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including

submenus), and calls setMenuItemTarget on them.

(-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding

them to the menu.

2:45 PM Changeset in webkit [73468] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <tony@chromium.org>

Unreviewed, remove passing tests (linux) from test_expectations
after DRT switch.

  • platform/chromium/test_expectations.txt:
2:31 PM Changeset in webkit [73467] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix follow up build fix.

  • pcre/pcre_ucp_searchfuncs.cpp:

(jsc_pcre_ucp_othercase):

2:22 PM Changeset in webkit [73466] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-07 Tony Chang <tony@chromium.org>

Unreviewed, update chromium test_expectations for DRT based
on Linux bot cycles and debug try bot.

  • platform/chromium/test_expectations.txt:
2:21 PM Changeset in webkit [73465] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix clang++ build
https://bugs.webkit.org/show_bug.cgi?id=50645

Reviewed by Darin Adler.

Explicitly cast offset to int.

  • pcre/pcre_ucp_searchfuncs.cpp:

(jsc_pcre_ucp_othercase):

2:07 PM Changeset in webkit [73464] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-06 Antonio Gomes <agomes@rim.com>

Reviewed by Martin Robinson.

Clean up fast/events/multiline-link-arrow-navigation.html
https://bugs.webkit.org/show_bug.cgi?id=50616

fast/events/multiline-link-arrow-navigation.html is setting both
WebKitEnableCaretBrowsing and -webkit-user-modify CSS property. Since
both work similarly for the purposes of this test, and the former is
not support by Mac and Windows DRTs, lets stick with using the later
only.

  • fast/events/multiline-link-arrow-navigation.html:
2:05 PM Changeset in webkit [73463] by andersca@apple.com
  • 2 edits in trunk/WebKit2

fast/loader/empty-embed-src-attribute.html asserts in debug builds
https://bugs.webkit.org/show_bug.cgi?id=50643

Reviewed by Sam Weinig.

Just always ignore attempts to load requests with empty URLs.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

2:03 PM Changeset in webkit [73462] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-12-07 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

-webkit-transition Fails on Multiple text-shadow Shadows
https://bugs.webkit.org/show_bug.cgi?id=42281

When transitioning multiple shadows, the blend function for
ShadowData dropped all but the first and last shadow because
of a failure to append to the end of the list. Fixed.

Test: transitions/multiple-text-shadow-transition.html

  • page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::blend):
2:03 PM Changeset in webkit [73461] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-12-07 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

CSS animation doesn't work for border-radius
https://bugs.webkit.org/show_bug.cgi?id=48340

Include CSSPropertyBorderRadius in the list of shorthand
properties, so that the individual border-radius properties
get animated.

Test: transitions/border-radius-transition.html

  • page/animation/AnimationBase.cpp: (WebCore::addShorthandProperties):
2:02 PM Changeset in webkit [73460] by Simon Fraser
  • 4 edits in trunk/LayoutTests

2010-12-07 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Make use of pause API more explicit before landing fix for borer-radius animation.
https://bugs.webkit.org/show_bug.cgi?id=48340

  • transitions/transition-test-helpers.js: Add some constants that we can use to make the tests more readable. Handle an extra value in the expected values arrays, to tell us if we should expect a property to be animated, and therefore whether we should try to pause it.
  • transitions/color-transition-all.html:
  • transitions/zero-duration-in-list.html: Adjust to make use of the above changes.
2:01 PM Changeset in webkit [73459] by mjs@apple.com
  • 4 edits
    2 adds in trunk

2010-12-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Kent Tamura.

Implement HTML5 hidden attribute
https://bugs.webkit.org/show_bug.cgi?id=40511

  • fast/forms/caret-rtl.html: Fixed a non-closed comment which added an "hidden" attribute.
  • fast/html/hidden-attr-expected.txt: Added.
  • fast/html/hidden-attr.html: Added. Test static and dynamic cases of hidden attribute.

2010-12-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Kent Tamura.

Implement HTML5 hidden attribute
https://bugs.webkit.org/show_bug.cgi?id=40511

Test: fast/html/hidden-attr.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped attribute. (WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to display: none.
1:45 PM Changeset in webkit [73458] by kbr@google.com
  • 15 edits
    1 add in trunk

2010-12-07 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

Fix compilation of core web audio files on Windows
https://bugs.webkit.org/show_bug.cgi?id=50603

Added log2 definition to MathExtras.h on Windows platform.

  • wtf/MathExtras.h: (log2):

2010-12-07 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

Fix compilation of core web audio files on Windows
https://bugs.webkit.org/show_bug.cgi?id=50603

Changed a few constructs using C99 features of math.h to use
wtf/MathExtras.h instead. Changed inline definitions of a couple of
const static doubles in classes to out-of-line. Built Chrome with
web audio enabled on Windows and Mac OS X to test these changes.

No new tests since audio API is not yet implemented.

  • WebCore.gypi:
  • platform/audio/AudioResampler.cpp:
  • platform/audio/Biquad.cpp: (WebCore::Biquad::setLowpassParams): (WebCore::Biquad::setHighpassParams): (WebCore::Biquad::setLowShelfParams):
  • platform/audio/Cone.cpp: (WebCore::ConeEffect::gain):
  • platform/audio/EqualPowerPanner.cpp: (WebCore::EqualPowerPanner::pan):
  • platform/audio/FFTFrame.cpp: (WebCore::FFTFrame::interpolateFrequencyComponents): (WebCore::FFTFrame::extractAverageGroupDelay): (WebCore::FFTFrame::addConstantGroupDelay):
  • platform/audio/HRTFKernel.cpp:
  • platform/audio/HRTFPanner.cpp:
  • webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::readFromBufferWithGrainEnvelope):
  • webaudio/AudioPannerNode.cpp: (WebCore::AudioPannerNode::getAzimuthElevation):
  • webaudio/AudioParam.cpp: Added. (AudioParam::setValue): (AudioParam::smooth):
  • webaudio/AudioParam.h:
  • webaudio/RealtimeAnalyser.cpp:
1:39 PM Changeset in webkit [73457] by Philippe Normand
  • 3 edits in trunk/WebCore

2010-11-25 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] faster elements linking
https://bugs.webkit.org/show_bug.cgi?id=50067

Perform less checks during GStreamer elements linking if building
against GStreamer >= 0.10.30.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::enterFullscreen):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
1:05 PM Changeset in webkit [73456] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-07 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] force NRWT to use DRT
https://bugs.webkit.org/show_bug.cgi?id=50359

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1:00 PM Changeset in webkit [73455] by kov@webkit.org
  • 5 edits in trunk/WebKit/gtk

2010-12-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] clears the subresources prematurely
https://bugs.webkit.org/show_bug.cgi?id=50634

Make adding the main resource explicit, and only clear
subresources when the new load is committed, avoid clearing them
prematurely.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::FrameLoaderClient::provisionalLoadStarted): (WebKit::FrameLoaderClient::prepareForDataSourceReplacement): (WebKit::postCommitFrameViewSetup):
  • tests/testwebdatasource.c: (notify_load_status_lifetime_cb): (test_webkit_web_data_source_lifetime): (main):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_add_main_resource): (webkit_web_view_add_resource): (webkit_web_view_clear_resources):
12:47 PM Changeset in webkit [73454] by Philippe Normand
  • 18 edits
    3 adds in trunk

2010-12-07 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] ::buffered() should return multiple ranges in some cases
https://bugs.webkit.org/show_bug.cgi?id=45101

Improved the ::buffered() method thanks to the new buffering query
support that landed in GStreamer 0.10.31. The method now
queries the media buffered-ranges on the pipeline and queue2
handles it if it's buffering the media to disk.

The webkitwebsrc element also gained BYTES duration query
support. This is needed in the rare cases where uridecodebin
configures its queue before the HTTP server returns the media
Content-Length.

Test: http/tests/media/video-buffered.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::buffered):
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webkit_web_src_init): (webKitWebSrcQuery): Make webkitwebsrc handle the duration queries if it's aware of the media content-length.
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaSliderTrack): Fix position of the second and next buffered ranges.

LayoutTests:

Reviewed by Gustavo Noronha Silva.

[GStreamer] ::buffered() should return multiple ranges in some cases
https://bugs.webkit.org/show_bug.cgi?id=45101

New test for video.buffered attribute. The test is skipped for
ports not returning multiple timeranges for video.buffered.

  • http/tests/media/video-buffered-expected.txt: Added.
  • http/tests/media/video-buffered.html: Added.
  • http/tests/resources/counting-captioned.mov: Added.
  • http/tests/media/video-throttled-load.cgi: added Range requests/responses support.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt-win/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win/Skipped:
11:56 AM Changeset in webkit [73453] by Simon Fraser
  • 2 edits in trunk/WebKit

2010-12-07 Simon Fraser <Simon Fraser>

Update Xcode project for newer Xcode.

  • WebKit.xcodeproj/project.pbxproj:
11:04 AM Changeset in webkit [73452] by yael.aharon@nokia.com
  • 5 edits
    8 adds in trunk

Spatial navigation not Working for Map and Area Tags
https://bugs.webkit.org/show_bug.cgi?id=47142

Reviewed by Antonio Gomes.

WebCore:

Give area elements special treatment in spatial navigation algorithm by getting the
rect of the area from the associated image. Since area elements are likely to overlap
if they are not rects, or if authors are not careful, we flatten the rect of area elements.

Tests: fast/spatial-navigation/snav-imagemap-area-not-focusable.html

fast/spatial-navigation/snav-imagemap-area-without-image.html
fast/spatial-navigation/snav-imagemap-overlapped-areas.html
fast/spatial-navigation/snav-imagemap-simple.html

  • page/FocusController.cpp:

(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):

  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::virtualRectForDirection):
(WebCore::virtualRectForAreaElementAndDirection):

  • page/SpatialNavigation.h:

(WebCore::FocusCandidate::FocusCandidate):

LayoutTests:

  • fast/spatial-navigation/snav-imagemap-area-not-focusable-expected.txt: Added.
  • fast/spatial-navigation/snav-imagemap-area-not-focusable.html: Added.
  • fast/spatial-navigation/snav-imagemap-area-without-image-expected.txt: Added.
  • fast/spatial-navigation/snav-imagemap-area-without-image.html: Added.
  • fast/spatial-navigation/snav-imagemap-overlapped-areas-expected.txt: Added.
  • fast/spatial-navigation/snav-imagemap-overlapped-areas.html: Added.
  • fast/spatial-navigation/snav-imagemap-simple-expected.txt: Added.
  • fast/spatial-navigation/snav-imagemap-simple.html: Added.
10:04 AM Changeset in webkit [73451] by jberlin@webkit.org
  • 2 edits
    1 add in trunk/WebKit2

Build fix. Unreviewed.

  • WebKit2.pro:

Added WebDatabaseManagerQt.cpp.

  • WebProcess/WebCoreSupport/qt/WebDatabaseManagerQt.cpp: Added.

(WebKit::WebDatabaseManager::databaseDirectory):
Added a FIXME to implement and return an empty string.

9:52 AM Changeset in webkit [73450] by Darin Adler
  • 4 edits in trunk

WebCore: Try to fix V8 build.

  • bindings/generic/BindingDOMWindow.h:

(WebCore::BindingDOMWindow::createWindow): Pass security origin.

WebKit2: Get a bit closer to making Qt WebKit2 compile again.

  • WebKit2.pro: Add the WebDatabaseManager source files.

Still missing: The Qt version of the databaseDirectory function.

9:27 AM Changeset in webkit [73449] by jberlin@webkit.org
  • 4 edits
    4 adds in trunk/WebKit2

WebKit2: Need to set the location of the Databases directory when the WebProcess is initialized
https://bugs.webkit.org/show_bug.cgi?id=50604

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp: Added.

(WebKit::WebDatabaseManager::shared):
(WebKit::WebDatabaseManager::WebDatabaseManager):
Initialize the DatabaseTracker with the Database directory.

  • WebProcess/WebCoreSupport/WebDatabaseManager.h: Added.
  • WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm: Added.

(WebKit::WebDatabaseManager::databaseDirectory):
Copied from WebKitInitializeDatabasesIfNecessary in WebKit/mac/Storage/WebDatabaseManager.mm.

  • WebProcess/WebCoreSupport/win/WebDatabaseManagerWin.cpp: Added.

(WebKit::WebDatabaseManager::databaseDirectory):
Copied from WebKitInitializeWebDatabasesIfNecessary in WebKit/win/WebDatabaseManager.cpp.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
Make sure that the Databases directory has been set by calling WebDatabaseManager::shared().

  • WebKit2.xcodeproj/project.pbxproj:

Add WebDatabaseManager.cpp/.h/Mac.cpp

  • win/WebKit2.vcproj:

Add WebDatabaseManager.cpp/.h/Win.cpp

9:14 AM Changeset in webkit [73448] by jberlin@webkit.org
  • 2 edits in trunk/WebKit/win

Build fix. Unreviewed.

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):
FrameLoader::urlSelected does not take a SecurityOrigin as a parameter.

8:40 AM Changeset in webkit [73447] by Darin Adler
  • 2 edits in trunk/WebCore

Another build fix.

  • loader/CrossOriginAccessControl.cpp: Added a missing include.
8:33 AM Changeset in webkit [73446] by Darin Adler
  • 4 edits in trunk/WebCore

Try to fix build.

  • plugins/PluginView.cpp:

(WebCore::PluginView::start): Pass security origin.
(WebCore::PluginView::getURLNotify): Ditto.
(WebCore::PluginView::getURL): Ditto.
(WebCore::PluginView::handlePost): Ditto.

8:30 AM Changeset in webkit [73445] by Darin Adler
  • 2 edits in trunk/WebKit/qt

Try to fix build.

  • Api/qwebpage.cpp:

(frameLoadRequest): Added missing parentheses.

8:23 AM Changeset in webkit [73444] by Darin Adler
  • 29 edits in trunk

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603

  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::selectCacheWithManifest): Pass security origin.
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchCreatePage): Ditto. (WebKit::FrameLoaderClientImpl::createFrame): Ditto.
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest): Ditto.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603

  • Api/qwebpage.cpp: (frameLoadRequest): Pass security origin.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Pass security origin.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603

  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603

  • bindings/generic/BindingDOMWindow.h: (WebCore::BindingDOMWindow::createWindow): Pass security origin. (WebCore::BindingDOMWindow::open): Ditto.
  • bindings/generic/BindingFrame.h: (WebCore::BindingFrame::navigateIfAllowed): Ditto.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Pass security origin. (WebCore::createWindow): Ditto. (WebCore::JSDOMWindow::open): Ditto.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation): Pass security origin.
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Pass security origin.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::openInInspectedWindow): Pass security origin.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): Added a security origin argument, passed through to urlSelected. (WebCore::FrameLoader::urlSelected): Replaced the resource request and frame name arguments with a frame load request arguments in one overload, and changed the other overload to pass in the current frame's document for the security origin. (WebCore::FrameLoader::loadFrameRequest): Moved the canDisplay check before the referrer computation because it no longer needs to look at the referrer. Replaced the call to canDisplay that used the target frame's security origin and the call to deprecatedCanDisplay with a single call to canDisplay that uses the requester security origin.
  • loader/FrameLoader.h: Updated for argument changes above.
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): Added a security origin. (WebCore::ScheduledURLNavigation::fire): Pass the security origin in to FrameLoader::changeLocation. (WebCore::ScheduledURLNavigation::securityOrigin): Added. (WebCore::ScheduledRedirect::ScheduledRedirect): Added a security origin argument. (WebCore::ScheduledLocationChange::ScheduledLocationChange): Ditto. (WebCore::ScheduledRefresh::ScheduledRefresh): Ditto. (WebCore::ScheduledRefresh::fire): Pass the security origin in to FrameLoader::changeLocation. (WebCore::ScheduledFormSubmission::fire): Include the security origin when constructing form submission. (WebCore::NavigationScheduler::scheduleRedirect): Include the security origin when creating the scheduled navigation object. (WebCore::NavigationScheduler::scheduleLocationChange): Ditto. (WebCore::NavigationScheduler::scheduleRefresh): Ditto.
  • loader/NavigationScheduler.h: Added the security origin argument to scheduleLocationChange.
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadOrRedirectSubframe): Pass in the security origin when calling scheduleLocationChange.
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): Ditto.
  • page/ContextMenuController.cpp: (WebCore::openNewWindow): Pass in the security origin. (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
  • page/FrameLoadRequest.h: Added a security origin called the requester to all FrameLoadRequest objects.
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest): Added the security origin.

2010-12-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::loadURL): Pass security origin.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchCreatePage): Ditto.
8:13 AM Changeset in webkit [73443] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-12-07 Chyangwoo Ryu <cwryu@debian.org>

Reviewed by Gustavo Noronha.

Korean message translation
https://bugs.webkit.org/show_bug.cgi?id=42465

  • kr.po: Added.
7:54 AM Changeset in webkit [73442] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-12-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] testwebdatasource - unreachable test is broken
https://bugs.webkit.org/show_bug.cgi?id=50629

Fix, and disable testwebdatasource's unreachable test (it is not
passing now that it actually tests what it should). This also
fixes the wait timer to actually work as expected.

  • tests/testwebdatasource.c: (notify_load_status_unreachable_cb): (notify_load_status_cb): (test_webkit_web_data_source):
7:20 AM Changeset in webkit [73441] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-12-07 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: avoid initializing Context on when creating attaching listener to ScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=50627

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::addListener): don't try to collect already parsed scripts if context has not been initialized yet.
6:24 AM Changeset in webkit [73440] by yurys@chromium.org
  • 4 edits in trunk/LayoutTests

2010-12-07 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: switch http/tests/inspector/console-resource-errors.html to inspector-tests2
https://bugs.webkit.org/show_bug.cgi?id=50551

We need to be sure that front-end has already opened by the time the messages are
recorded in console because the data we collect for errors may differ depending
on whether the front-end is open.

  • http/tests/inspector/console-resource-errors-expected.txt:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/console-tests2.js: (initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithClasses):
5:58 AM Changeset in webkit [73439] by Csaba Osztrogonác
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for tests introduced in r73385 and r73398.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/qt/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/qt/fast/html/marquee-scrollamount-expected.txt: Added.
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt: Added.
5:29 AM Changeset in webkit [73438] by Csaba Osztrogonác
  • 6 edits
    2 deletes in trunk

Unreviewed. Rolling out r73421, because it made transitions/color-transition-all.html flakey.

WebCore:

  • page/animation/AnimationBase.cpp:

(WebCore::addShorthandProperties):

LayoutTests:

  • transitions/border-radius-transition-expected.txt: Removed.
  • transitions/border-radius-transition.html: Removed.
  • transitions/color-transition-all.html:
  • transitions/transition-test-helpers.js:

(expected):

  • transitions/zero-duration-in-list.html:
5:19 AM Changeset in webkit [73437] by pfeldman@chromium.org
  • 1 edit in branches/chromium/597/WebCore/inspector/InspectorStyleSheet.cpp

Merge 72811 - 2010-11-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: crash upon inspecting user style sheet.
https://bugs.webkit.org/show_bug.cgi?id=50109

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):

BUG=64483
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/5575009

4:40 AM Changeset in webkit [73436] by mrobinson@webkit.org
  • 37 edits in trunk

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::close): (WebCore::Document::lastModified): (WebCore::Document::finishedParsing): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
  • dom/Document.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::commitData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setFrame):
  • loader/DocumentLoader.h:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
  • loader/DocumentWriter.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h: (WebCore::FrameLoader::writer):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestPreload):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::loadJavaScriptURL):
  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
  • src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]):

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • Api/qwebframe.cpp: (QWebFrame::setUrl):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading):

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::finishedLoading):

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489

This commit caused crashes on the GTK+ bots

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::finishedLoading):
4:11 AM Changeset in webkit [73435] by mrobinson@webkit.org
  • 53 edits in trunk/LayoutTests

2010-12-07 Martin Robinson <mrobinson@igalia.com>

Rebaseline GTK+ results after r73385.

  • platform/gtk/css1/box_properties/margin-expected.txt:
  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/classification/white_space-expected.txt:
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt:
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/gtk/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/gtk/fast/blockflow/block-level-images-expected.txt:
  • platform/gtk/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/gtk/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/gtk/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt:
  • platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
  • platform/gtk/fast/css/negative-leading-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/file-input-direction-expected.txt:
  • platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-grid-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/gtk/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/images/gif-large-checkerboard-expected.txt:
  • platform/gtk/fast/lists/001-vertical-expected.txt:
  • platform/gtk/fast/lists/003-vertical-expected.txt:
  • platform/gtk/fast/multicol/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
  • platform/gtk/fast/multicol/float-paginate-expected.txt:
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
  • platform/gtk/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
  • platform/gtk/fast/table/height-percent-test-vertical-expected.txt:
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/gtk/svg/custom/text-zoom-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/gtk/transforms/svg-vs-css-expected.txt:
3:11 AM Changeset in webkit [73434] by Patrick Gansterer
  • 4 edits
    1 delete in trunk

2010-12-07 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Remove WebKitGenerators
https://bugs.webkit.org/show_bug.cgi?id=50445

  • CMakeLists.txt:
  • cmake/WebKitGenerators.cmake: Removed.

2010-12-07 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Remove WebKitGenerators
https://bugs.webkit.org/show_bug.cgi?id=50445

Move remaining logic into main CMakeLists.txt.

  • CMakeLists.txt:
3:11 AM Changeset in webkit [73433] by Antti Koivisto
  • 4 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=50412
http://www.wunderground.com/US/CA/Hayward.html causes big memory spike during page loading

Reviewed by Gavin Barraclough.

Creating a substring caused the original string be flattened if it was in the rope form. This could use
significant amount of memory by reducing buffer sharing between strings.

Add a rope specific substring function that constructs the substring by reusing the rope fibers
instead of flattening the rope.

No change observed in SunSpider.

  • runtime/JSString.cpp:

(JSC::JSString::substringFromRope):

  • runtime/JSString.h:

(JSC::jsSubstring):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):

2:44 AM Changeset in webkit [73432] by jschuh@chromium.org
  • 7 edits
    2 adds in trunk

2010-12-07 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549

Test: svg/css/cursor-replace.svg

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): (WebCore::SVGCursorElement::removeClient): (WebCore::SVGCursorElement::removeReferencedElement):
  • svg/SVGCursorElement.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::setCursorElement): (WebCore::SVGElement::cursorElementRemoved): (WebCore::SVGElement::setCursorImageValue): (WebCore::SVGElement::cursorImageElementRemoved):
  • svg/SVGElement.h:

2010-12-07 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549

  • svg/css/cursor-replace-expected.txt: Added.
  • svg/css/cursor-replace.svg: Added.
2:15 AM Changeset in webkit [73431] by yutak@chromium.org
  • 2 edits
    13 adds in trunk/LayoutTests

2010-12-07 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Add Chromium-specific expected results for two tests.

  • platform/chromium-linux/css2.1/t040105-import-10-b-expected.checksum: Added.
  • platform/chromium-linux/css2.1/t040105-import-10-b-expected.png: Added.
  • platform/chromium-linux/media/controls-without-preload-expected.checksum: Added.
  • platform/chromium-linux/media/controls-without-preload-expected.png: Added.
  • platform/chromium-mac/media/controls-without-preload-expected.checksum: Added.
  • platform/chromium-mac/media/controls-without-preload-expected.png: Added.
  • platform/chromium-mac/media/controls-without-preload-expected.txt: Added.
  • platform/chromium-win/css2.1/t040105-import-10-b-expected.checksum: Added.
  • platform/chromium-win/css2.1/t040105-import-10-b-expected.png: Added.
  • platform/chromium-win/css2.1/t040105-import-10-b-expected.txt: Added.
  • platform/chromium-win/media/controls-without-preload-expected.checksum: Added.
  • platform/chromium-win/media/controls-without-preload-expected.png: Added.
  • platform/chromium-win/media/controls-without-preload-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:40 AM Changeset in webkit [73430] by tkent@chromium.org
  • 41 edits
    2 copies
    3 adds in trunk

2010-12-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
https://bugs.webkit.org/show_bug.cgi?id=48821

Introduces FormAssociatedElement class which would be a super class
of form assocated elements. Some of member functions and variables of
HTMLFormControlElement are migrated into this class.
Following the HTML5 spec, HTMLFormControlElement class and
HTMLObjectElement class are subclasses of it for now.

Test: fast/forms/form-collection-elements-order.html

  • Android.mk: Added FormAssociatedElement.cpp
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Added FormAssociatedElement.{cpp,h}
  • WebCore.exp.in: Added the symbol for toHTMLElement(FormAssociatedElement*)
  • WebCore.gypi: Added FormAssociatedElement.{cpp,h}
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/CheckedRadioButtons.h: Fixed class forward declaration order.
  • dom/Document.cpp: (WebCore::Document::registerFormElementWithFormAttribute): Modified to use FormAssociatedElement instead of HTMLFormControlElement (WebCore::Document::unregisterFormElementWithFormAttribute): Ditto. (WebCore::Document::resetFormElementsOwner):
  • dom/Document.h: Ditto.
  • html/DOMFormData.cpp: Ditto. (WebCore::DOMFormData::DOMFormData):
  • html/FormAssociatedElement.cpp: Copied and renamed from WebCore/html/HTMLFormControlElement.cpp. (WebCore::FormAssociatedElement::FormAssociatedElement): (WebCore::FormAssociatedElement::~FormAssociatedElement): (WebCore::FormAssociatedElement::validity): (WebCore::FormAssociatedElement::insertedIntoTree): (WebCore::FormAssociatedElement::removedFromTree): (WebCore::FormAssociatedElement::removeFromForm): (WebCore::FormAssociatedElement::resetFormOwner): (WebCore::FormAssociatedElement::formAttributeChanged): (WebCore::toHTMLElement):
  • html/FormAssociatedElement.h: Ditto. (WebCore::FormAssociatedElement::ref): (WebCore::FormAssociatedElement::deref): (WebCore::FormAssociatedElement::formDestroyed): (WebCore::FormAssociatedElement::setForm):
  • html/HTMLElement.h: Changed the access level of findFormAncestor().
  • html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::item): Modified to use FormAssociatedElement instead of HTMLFormControlElement. (WebCore::HTMLFormCollection::getNamedFormItem): Ditto. (WebCore::HTMLFormCollection::updateNameCache): Ditto.
  • html/HTMLFormControlElement.cpp: Modified regarding with the change of class hierarchy. (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::~HTMLFormControlElement): (WebCore::HTMLFormControlElement::insertedIntoTree): (WebCore::HTMLFormControlElement::removedFromTree): (WebCore::HTMLFormControlElement::supportsFocus): (WebCore::HTMLFormControlElement::checkValidity): (WebCore::HTMLFormControlElement::virtualForm): (WebCore::HTMLFormControlElement::isDefaultButtonForForm): (WebCore::HTMLFormControlElement::attributeChanged):
  • html/HTMLFormControlElement.h: Ditto. (WebCore::HTMLFormControlElement::form): (WebCore::HTMLFormControlElement::disabled): (WebCore::HTMLFormControlElement::type): (WebCore::HTMLFormControlElement::refFormAssociatedElement): (WebCore::HTMLFormControlElement::derefFormAssociatedElement):
  • html/HTMLFormElement.cpp: Modified to use FormAssociatedElement instead of HTMLFormControlElement. (WebCore::HTMLFormElement::submitImplicitly): (WebCore::HTMLFormElement::validateInteractively): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::reset): (WebCore::HTMLFormElement::formElementIndexWithFormAttribute): (WebCore::HTMLFormElement::formElementIndex): (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement): (WebCore::HTMLFormElement::defaultButton): (WebCore::HTMLFormElement::checkValidity): (WebCore::HTMLFormElement::collectUnhandledInvalidControls): (WebCore::HTMLFormElement::documentDidBecomeActive):
  • html/HTMLFormElement.h: Ditto. (WebCore::HTMLFormElement::associatedElements):
  • html/HTMLInputElement.cpp: Ditto. (WebCore::HTMLInputElement::updateCheckedRadioButtons):
  • html/HTMLObjectElement.cpp: Modified regarding with the change of class hierarchy. (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::create): (WebCore::HTMLObjectElement::attributeChanged): (WebCore::HTMLObjectElement::insertedIntoTree): (WebCore::HTMLObjectElement::removedFromTree): (WebCore::HTMLObjectElement::appendFormData): (WebCore::HTMLObjectElement::formControlName):
  • html/HTMLObjectElement.h: Ditto. (WebCore::HTMLObjectElement::form): (WebCore::HTMLObjectElement::isFormControlElement): (WebCore::HTMLObjectElement::isEnumeratable): (WebCore::HTMLObjectElement::refFormAssociatedElement): (WebCore::HTMLObjectElement::derefFormAssociatedElement):
  • html/HTMLTagNames.in: Added constructorNeedsFormElement to object tag.
  • html/ValidationMessage.cpp: Modified to use FormAssociatedElement instead of HTMLFormControlElement. (WebCore::ValidationMessage::ValidationMessage): (WebCore::ValidationMessage::create):
  • html/ValidationMessage.h: Ditto.
  • html/ValidityState.cpp: Ditto. (WebCore::ValidityState::validationMessage): (WebCore::ValidityState::setCustomErrorMessage): (WebCore::ValidityState::valueMissing): (WebCore::ValidityState::typeMismatch): (WebCore::ValidityState::patternMismatch): (WebCore::ValidityState::tooLong): (WebCore::ValidityState::rangeUnderflow): (WebCore::ValidityState::rangeOverflow): (WebCore::ValidityState::stepMismatch):
  • html/ValidityState.h: Ditto. (WebCore::ValidityState::create): (WebCore::ValidityState::ValidityState):
  • loader/FormSubmission.cpp: Ditto. (WebCore::FormSubmission::create):

2010-12-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
https://bugs.webkit.org/show_bug.cgi?id=48821

Modified to use FormAssociatedElement instead of HTMLFormControlElement.

  • src/WebFormElement.cpp: (WebKit::WebFormElement::getFormControlElements): Modified to use FormAssociatedElement instead of HTMLFormControlElement.
  • src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Ditto.
  • src/WebSearchableFormData.cpp: (WebCore::GetButtonToActivate): Ditto. (WebCore::HasSuitableTextElement): Ditto.

2010-12-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
https://bugs.webkit.org/show_bug.cgi?id=48821

Modified to use FormAssociatedElement instead of HTMLFormControlElement.

  • WebFrame.cpp: (WebFrame::elementWithName): Modified to use FormAssociatedElement instead of HTMLFormControlElement. (WebFrame::controlsInForm): Ditto.

2010-12-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
https://bugs.webkit.org/show_bug.cgi?id=48821

Modified to use FormAssociatedElement instead of HTMLFormControlElement.

  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use FormAssociatedElement instead of HTMLFormControlElement. (-[WebHTMLRepresentation controlsInForm:]): Ditto.

2010-12-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Let HTMLObjectElement be a form associated element
https://bugs.webkit.org/show_bug.cgi?id=48821

Adds a test to ensure the order of form.elements attribute.
Updates two tests to check whether object elements are handled
correctly in form.elements attribute.

  • fast/forms/form-attribute-expected.txt: Updated.
  • fast/forms/form-collection-elements-order-expected.txt: Added.
  • fast/forms/form-collection-elements-order.html: Added.
  • fast/forms/script-tests/form-attribute.js: Updated.
  • fast/forms/script-tests/form-collection-elements-order.js: Added. (checkOrder):
  • fast/forms/script-tests/form-collection-elements.js: Updated.

Dec 6, 2010:

11:31 PM Changeset in webkit [73429] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-06 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Update Chromium test expectations for svg/custom/text-linking.svg.

11:09 PM Changeset in webkit [73428] by pfeldman@chromium.org
  • 1 edit in branches/chromium/597/WebCore/css/CSSImportRule.cpp

Merge 73427 - 2010-12-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out r72988 for breaking iframes.

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):

BUG=65376
TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/5521007

11:01 PM Changeset in webkit [73427] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-12-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out r72988 for breaking iframes.

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
10:02 PM Changeset in webkit [73426] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-06 Yuta Kitamura <yutak@chromium.org>

Unreviewed.

Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
9:05 PM Changeset in webkit [73425] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-06 Hironori Bono <hbono@chromium.org>

Reviewed by David Levin.

[Chromium] Refactor FontCacheChromiumWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=50611

This change just moved the helper functions for the WebCore::FontCache class to the beginning of ths file.

No new tests are added since this is a refactoring.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontDataFromDescriptionAndLogFont): Moved to the beginning of the file. (WebCore::toGDIFontWeight): Moved to the beginning of the file. (WebCore::FillLogFont): Moved to the beginning of the file. (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData): Moved to the beginning of the file. (WebCore::traitsInFamilyEnumProc): Moved to the beginning of the file. (WebCore::FontCache::platformInit): Moved after the static functions.
8:24 PM Changeset in webkit [73424] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-12-06 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Throw webglcontextlost and webglcontextrestored events when a WebGL context is lost and restored.
https://bugs.webkit.org/show_bug.cgi?id=50364

No new tests since there is currently no way to force a context lost event.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired): (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::isContextLost): (WebCore::WebGLRenderingContext::loseContext): (WebCore::WebGLRenderingContext::restoreContext):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::WebGLRenderingContextRestoreTimer):
7:42 PM Changeset in webkit [73423] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=50593

Reviewed by Simon Fraser.

Fix background canvas painting for documents with left/top overflow. The math from the original RTL patch was incorrect.

Just use the RenderView's document dimensions always.

WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxDecorations):

LayoutTests:

  • fast/blockflow/Kusa-Makura-background-canvas.html: Added.
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
6:01 PM Changeset in webkit [73422] by Simon Fraser
  • 3 edits in trunk/WebKit2

2010-12-06 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Fix two WebKit2 prefs issues.

  • Shared/WebPreferencesStore.h: Include font-family preferences in the FOR_EACH_WEBKIT_STRING_PREFERENCE macro, actually propagating font family prefs to WebCore settings.
  • UIProcess/WebPageGroup.cpp: (WebKit::WebPageGroup::WebPageGroup): (WebKit::WebPageGroup::~WebPageGroup): Add and remove the WebPageGroup from the preference object it creates. This allows preference changes to actually be propagated to the web process.
6:01 PM Changeset in webkit [73421] by Simon Fraser
  • 6 edits
    2 adds in trunk

2010-12-06 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

CSS animation doesn't work for border-radius
https://bugs.webkit.org/show_bug.cgi?id=48340

Include CSSPropertyBorderRadius in the list of shorthand
properties, so that the individual border-radius properties
get animated.

Test: transitions/border-radius-transition.html

  • page/animation/AnimationBase.cpp: (WebCore::addShorthandProperties):
5:24 PM Changeset in webkit [73420] by victorw@chromium.org
  • 3 edits in trunk/LayoutTests

2010-12-06 Victor Wang <victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations.

  • platform/chromium-mac-leopard/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/box-shadow-h-expected.png:
5:14 PM Changeset in webkit [73419] by andersca@apple.com
  • 7 edits in trunk/WebKit2

The plug-in process crashes if it can't load the plug-in module
https://bugs.webkit.org/show_bug.cgi?id=50601
<rdar://problem/8692654>

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::initialize):
Handle m_plugin being 0.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::netscapePluginModule):
Create the plug-in module if it doesn't exist.

(WebKit::PluginProcess::initialize):
Store the plug-in path.

  • PluginProcess/PluginProcess.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::create):
Return null if the plug-in module doesn't exist.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Simplify code.

5:12 PM Changeset in webkit [73418] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-06 Emil Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

Fix for classList perf test, failing due to typo.
https://bugs.webkit.org/show_bug.cgi?id=50578

  • perf/class-list-remove.html: Changed to use the right value.
5:01 PM Changeset in webkit [73417] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-12-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

Simplified some ASLR-related code in PageAllocation/Reservation
https://bugs.webkit.org/show_bug.cgi?id=50599


Removed reserveAt, allocateAt, and friends, since they all existed to
serve one feature: ASLR for executable memory on x86_64 on Mac. Moved
ASLR code down into systemAllocate -- now, any time you allocate
executable memory on a supporting platform, the memory's location is
randomized.

  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator): No need for the caller to randomize anything.
  • wtf/PageAllocation.h: (WTF::PageAllocation::systemAllocate): Removed some *At() functions, and beefed up executable allocation with randomization.
  • wtf/PageReservation.h: (WTF::PageReservation::systemReserve): Removed some *At() functions.
5:00 PM Changeset in webkit [73416] by rniwa@webkit.org
  • 21 edits in trunk/WebCore

2010-12-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

ApplyStyleCommand should take EditingStyle instead of CSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=49938

Modified ApplyStyleCommand::ApplyStyleCommand and ApplyStyleCommand::create to take EditingStyle*
instead of CSSStyleDeclaration*. Also replaced much of code in Editor::computeAndSetTypingStyle
by calls to EditingStyle's member functions and extracted EditingStyle::overrideWith and
EditingStyle::extractAndRemoveBlockProperties.

No new tests are added since this is a refactoring.

  • WebCore.exp.in: Added SelectionController::copyTypingStyle and EditingStyle::~EditingStyle.
  • css/CSSMutableStyleDeclaration.cpp: Made CSSMutableStyleDeclaration* in the argument list const. (WebCore::CSSMutableStyleDeclaration::merge):
  • css/CSSMutableStyleDeclaration.h:
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): Takes EditingStyle* instead of CSSStyleDeclaration*. (WebCore::ApplyStyleCommand::doApply): Uses EditingStyle.
  • editing/ApplyStyleCommand.h: m_style is now a ref-pointer to EditingStyle instead of CSSMutableStyleDeclaration. (WebCore::ApplyStyleCommand::create): Takes EditingStyle* instead of CSSStyleDeclaration*.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyle): Ditto. (WebCore::CompositeEditCommand::moveParagraphs): Calls applyStyle. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto.
  • editing/EditCommand.cpp:
  • editing/EditCommand.h:
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::~EditingStyle): Added. (WebCore::EditingStyle::overrideWithStyle): Extracted from Editor::calculateTypingStyleAfterDelete. (WebCore::EditingStyle::copy): Added. (WebCore::EditingStyle::extractAndRemoveBlockProperties): Extracted from Editor::calculateTypingStyleAfterDelete.
  • editing/EditingStyle.h:
  • editing/Editor.cpp: (WebCore::Editor::applyStyle): Calls ApplyStyleCommand::create. (WebCore::Editor::applyParagraphStyle): Ditto. (WebCore::Editor::computeAndSetTypingStyle): Ditto.
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Calls applyStyle.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Ditto.
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): Calls ApplyStyleCommand::create.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Calls applyStyle.
  • editing/SelectionController.cpp: (WebCore::SelectionController::copyTypingStyle): Moved from SelectionController.h
  • editing/SelectionController.h:
4:58 PM Changeset in webkit [73415] by commit-queue@webkit.org
  • 9 edits
    6 deletes in trunk/LayoutTests

2010-12-06 Cosmin Truta <ctruta@chromium.org>

Reviewed by Eric Seidel.

Fix testcase: textPath cannot be inside another textPath
https://bugs.webkit.org/show_bug.cgi?id=50211

  • platform/mac/svg/custom/text-linking-expected.checksum: Updated.
  • platform/mac/svg/custom/text-linking-expected.png: Updated.
  • platform/mac/svg/custom/text-linking-expected.txt: Updated.
  • platform/chromium-linux/svg/custom/text-linking-expected.checksum: Updated.
  • platform/chromium-linux/svg/custom/text-linking-expected.png: Updated.
  • platform/chromium-linux/svg/custom/text-linking-expected.txt: Updated.
  • platform/chromium-win-vista/svg/custom/text-linking-expected.checksum: Deleted.
  • platform/chromium-win-vista/svg/custom/text-linking-expected.png: Deleted.
  • platform/chromium-win-vista/svg/custom/text-linking-expected.txt: Deleted.
  • platform/chromium-win-xp/svg/custom/text-linking-expected.checksum: Deleted.
  • platform/chromium-win-xp/svg/custom/text-linking-expected.png: Deleted.
  • platform/chromium-win-xp/svg/custom/text-linking-expected.txt: Deleted.
  • svg/custom/text-linking.svg: Removed test for <textPath> inside <textPath>.
4:57 PM Changeset in webkit [73414] by andersca@apple.com
  • 5 edits in trunk/WebKit2

WebProcess crash in NPRemoteObjectMap::invalidate when closing tab
https://bugs.webkit.org/show_bug.cgi?id=50597
<rdar://problem/8655584>

Reviewed by Sam Weinig.

When invalidating the NPRemoteObjectMap, we don't want NPObjectMessageReceiver to
release all objects NPObjects blindly because NPJSObjects have already been deallocated by the plug-in view.

This is not an ideal solution; an ideal solution would involve NPJSObjects notifying any NPObjectMessageReceiver objects
that the NPJSObject is being destroyed. The NPObjectMessageReceiver could then simply null out the NPObject pointer.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):

  • Shared/Plugins/NPObjectMessageReceiver.h:
  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::NPRemoteObjectMap):
(WebKit::NPRemoteObjectMap::invalidate):

  • Shared/Plugins/NPRemoteObjectMap.h:

(WebKit::NPRemoteObjectMap::isInvalidating):

4:49 PM Changeset in webkit [73413] by jhoneycutt@apple.com
  • 5 edits in trunk/LayoutTests

Update Windows results after r73385.

Unreviewed.

  • platform/win/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum:
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
4:33 PM Changeset in webkit [73412] by weinig@apple.com
  • 26 edits
    2 adds in trunk

Generalize didChangeLocationWithinPageForFrame for all same document navigations
https://bugs.webkit.org/show_bug.cgi?id=50584

Reviewed by Anders Carlsson.

WebKit2:

  • Rename didChangeLocationWithinPageForFrame callbacks to didSameDocumentNavigationForFrame
  • Add WKSameDocumentNavigationType to didChangeLocationWithinPageForFrame.
  • Call didSameDocumentNavigationForFrame for HTML session state changes.
  • Shared/API/c/WKPageLoadTypes.h: Added.
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
Moved WKFrameNavigationType here from WKPage.h and add WKSameDocumentNavigationType.

  • Shared/SameDocumentNavigationType.h: Added.
  • UIProcess/API/C/WKAPICast.h:

Moved WKFrameNavigationType conversion from here.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):
Update comment.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didSameDocumentNavigation):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didSameDocumentNavigationForFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didSameDocumentNavigationForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

Pipe new name through.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage):
Call didChangeLocationWithinPageForFrame for session state changes.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(didSameDocumentNavigationForFrame):
(-[BrowserWindowController awakeFromNib]):
(-[BrowserWindowController didSameDocumentNavigationForFrame:]):

  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:

(TestWebKitAPI::didSameDocumentNavigationForFrame):
(TestWebKitAPI::TEST):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

4:31 PM Changeset in webkit [73411] by rniwa@webkit.org
  • 10 edits
    2 adds in trunk

2010-12-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Executing FormatBlock on multiple paragraphs inside pre does not remove the outer pre
https://bugs.webkit.org/show_bug.cgi?id=47300

The bug was caused by FormatBlockCommand::formatRange's not removing refNode when the refNode
contains more than one paragraphs even when the refNode is fully selected.

Fixed the bug by modifying FormatBlockCommand::formatRange to correctly remove the node in
such a situation.

Also fixed a bug in ApplyBlockElementCommand::formatSelection that the end of selection
is not properly updated when the end of selection resides in the node split by
rangeForParagraphSplittingTextNodesIfNeeded or endOfNextParagrahSplittingTextNodesIfNeeded.

Test: editing/execCommand/format-block-multiple-paragraphs-in-pre.html

  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::formatSelection): Calls formatRange with m_endOfLastParagraph. (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): Updates m_endOfLastParagraph when the position points to the node split by this function. (WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded): Ditto.
  • editing/ApplyBlockElementCommand.h: Added m_endOfLastParagraph as a member variable.
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): See above.
  • editing/FormatBlockCommand.h:
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::formatRange): Ignores the end of selection.
  • editing/IndentOutdentCommand.h:

2010-12-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Executing FormatBlock on multiple paragraphs inside pre does not remove the outer pre
https://bugs.webkit.org/show_bug.cgi?id=47300

Added a test to ensure execCommand('FormatBlock') correctly removes pre when formatting paragraphs within.
Also rebaselined several tests because WebKit no longer erroneously format the paragraphs immediately
after the selection.

  • editing/execCommand/format-block-multiple-paragraphs-in-pre-expected.txt: Added.
  • editing/execCommand/format-block-multiple-paragraphs-in-pre.html: Added.
  • editing/execCommand/format-block-multiple-paragraphs-expected.txt: No longer erroneously format the last paragraph in a pre by a blockquote when formatting all but the last paragraph in the pre.
  • editing/execCommand/indent-pre-expected.txt: No longer erroneously format the last paragraph in the pre-list by a blockquote.
4:18 PM Changeset in webkit [73410] by jberlin@webkit.org
  • 5 edits in trunk/WebKit2

WebKit2: Expose the preference to enable or disable HTML5 Databases.
https://bugs.webkit.org/show_bug.cgi?id=50411

Reviewed by Dan Bernstein.

  • Shared/WebPreferencesStore.h:

Make the preference to enable HTML5 Databases default ot true.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDatabasesEnabled):
(WKPreferencesGetDatabasesEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Set AbstractDatabase::isAvailable (mimicking how the preference is set in WebKit1).

4:07 PM Changeset in webkit [73409] by kinuko@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-06 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Ojan Vafai.

Make TestResultsServer return 404 for non-existing results files.
https://bugs.webkit.org/show_bug.cgi?id=50581

  • TestResultServer/handlers/testfilehandler.py:
3:52 PM Changeset in webkit [73408] by victorw@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2010-12-06 Victor Wang <victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations for fast/html/marquee-scrollamount.html

  • platform/chromium-linux/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/chromium-linux/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/chromium-mac/fast/html: Added.
  • platform/chromium-mac/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/chromium-mac/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/chromium-win/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/chromium-win/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/chromium-win/fast/html/marquee-scrollamount-expected.txt: Added.
3:24 PM Changeset in webkit [73407] by Csaba Osztrogonác
  • 125 edits
    7 copies
    57 adds in trunk/LayoutTests

Unreviewed.

Update Qt specific expected results after r73385.

  • platform/qt/css1/box_properties/margin-expected.checksum: Added.
  • platform/qt/css1/box_properties/margin-expected.png: Added.
  • platform/qt/css1/box_properties/margin-expected.txt:
  • platform/qt/css1/box_properties/margin_right-expected.checksum: Added.
  • platform/qt/css1/box_properties/margin_right-expected.png: Added.
  • platform/qt/css1/box_properties/margin_right-expected.txt:
  • platform/qt/css1/formatting_model/inline_elements-expected.checksum: Added.
  • platform/qt/css1/formatting_model/inline_elements-expected.png: Added.
  • platform/qt/css1/formatting_model/inline_elements-expected.txt:
  • platform/qt/css2.1/t1202-counter-08-b-expected.checksum: Added.
  • platform/qt/css2.1/t1202-counter-08-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counter-08-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-08-b-expected.checksum: Added.
  • platform/qt/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/qt/css2.1/t1202-counters-08-b-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.checksum:
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.checksum:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.checksum:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.checksum:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/qt/fast/backgrounds/size/backgroundSize15-expected.checksum: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize15-expected.png: Added.
  • platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/qt/fast/block/float/008-expected.checksum: Added.
  • platform/qt/fast/block/float/008-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png.
  • platform/qt/fast/block/float/008-expected.txt:
  • platform/qt/fast/block/float/019-expected.checksum: Added.
  • platform/qt/fast/block/float/019-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png.
  • platform/qt/fast/block/float/019-expected.txt:
  • platform/qt/fast/block/float/033-expected.checksum: Added.
  • platform/qt/fast/block/float/033-expected.png: Added.
  • platform/qt/fast/block/float/033-expected.txt:
  • platform/qt/fast/block/float/035-expected.checksum:
  • platform/qt/fast/block/float/035-expected.png:
  • platform/qt/fast/block/float/035-expected.txt:
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.checksum: Added.
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.checksum: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.checksum: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/qt/fast/block/positioning/049-expected.checksum: Added.
  • platform/qt/fast/block/positioning/049-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png.
  • platform/qt/fast/block/positioning/049-expected.txt:
  • platform/qt/fast/blockflow/block-level-images-expected.checksum:
  • platform/qt/fast/blockflow/block-level-images-expected.png:
  • platform/qt/fast/blockflow/block-level-images-expected.txt:
  • platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
  • platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
  • platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.checksum:
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.png:
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
  • platform/qt/fast/box-shadow/basic-shadows-expected.txt:
  • platform/qt/fast/css/negative-leading-expected.png:
  • platform/qt/fast/css/negative-leading-expected.txt:
  • platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.checksum: Added.
  • platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
  • platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/qt/fast/flexbox/flex-hang-expected.checksum: Added.
  • platform/qt/fast/flexbox/flex-hang-expected.png: Copied from LayoutTests/platform/qt/fast/table/height-percent-test-vertical-expected.png.
  • platform/qt/fast/flexbox/flex-hang-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.checksum: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.checksum: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.checksum: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.checksum: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.checksum: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.checksum: Added.
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.checksum: Added.
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.png: Added.
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/qt/fast/images/gif-large-checkerboard-expected.checksum:
  • platform/qt/fast/images/gif-large-checkerboard-expected.png:
  • platform/qt/fast/images/gif-large-checkerboard-expected.txt:
  • platform/qt/fast/lists/001-vertical-expected.checksum:
  • platform/qt/fast/lists/001-vertical-expected.png:
  • platform/qt/fast/lists/001-vertical-expected.txt:
  • platform/qt/fast/lists/003-vertical-expected.checksum:
  • platform/qt/fast/lists/003-vertical-expected.png:
  • platform/qt/fast/lists/003-vertical-expected.txt:
  • platform/qt/fast/multicol/column-count-with-rules-expected.checksum:
  • platform/qt/fast/multicol/column-count-with-rules-expected.png:
  • platform/qt/fast/multicol/column-count-with-rules-expected.txt:
  • platform/qt/fast/multicol/float-paginate-complex-expected.checksum:
  • platform/qt/fast/multicol/float-paginate-complex-expected.png:
  • platform/qt/fast/multicol/float-paginate-complex-expected.txt:
  • platform/qt/fast/multicol/float-paginate-expected.checksum:
  • platform/qt/fast/multicol/float-paginate-expected.png:
  • platform/qt/fast/multicol/float-paginate-expected.txt:
  • platform/qt/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/qt/fast/multicol/layers-in-multicol-expected.png:
  • platform/qt/fast/multicol/layers-in-multicol-expected.txt:
  • platform/qt/fast/multicol/nested-columns-expected.checksum:
  • platform/qt/fast/multicol/nested-columns-expected.png:
  • platform/qt/fast/multicol/nested-columns-expected.txt:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.checksum:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.png:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.checksum: Added.
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.png: Added.
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.checksum:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.checksum:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/qt/fast/multicol/table-vertical-align-expected.checksum:
  • platform/qt/fast/multicol/table-vertical-align-expected.png:
  • platform/qt/fast/multicol/table-vertical-align-expected.txt:
  • platform/qt/fast/repaint/content-into-overflow-expected.checksum: Added.
  • platform/qt/fast/repaint/content-into-overflow-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png.
  • platform/qt/fast/repaint/content-into-overflow-expected.txt:
  • platform/qt/fast/repaint/overflow-into-content-expected.checksum: Added.
  • platform/qt/fast/repaint/overflow-into-content-expected.png: Copied from LayoutTests/platform/qt/fast/block/float/035-expected.png.
  • platform/qt/fast/repaint/overflow-into-content-expected.txt:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.checksum:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
  • platform/qt/fast/table/height-percent-test-vertical-expected.checksum:
  • platform/qt/fast/table/height-percent-test-vertical-expected.png:
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt:
  • platform/qt/fast/table/wide-colspan-expected.checksum: Added.
  • platform/qt/fast/table/wide-colspan-expected.png: Added.
  • platform/qt/fast/table/wide-colspan-expected.txt:
  • platform/qt/fast/table/wide-column-expected.checksum: Added.
  • platform/qt/fast/table/wide-column-expected.png: Copied from LayoutTests/platform/qt/fast/table/height-percent-test-vertical-expected.png.
  • platform/qt/fast/table/wide-column-expected.txt:
  • platform/qt/fast/text/text-letter-spacing-expected.checksum: Added.
  • platform/qt/fast/text/text-letter-spacing-expected.png: Added.
  • platform/qt/fast/text/text-letter-spacing-expected.txt:
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum:
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.checksum: Added.
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.png: Added.
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.checksum:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.checksum:
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.png:
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.checksum: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.checksum:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29314-expected.checksum: Added.
  • platform/qt/tables/mozilla/bugs/bug29314-expected.png: Added.
  • platform/qt/tables/mozilla/bugs/bug29314-expected.txt:
3:16 PM Changeset in webkit [73406] by zmo@google.com
  • 10 edits in trunk/WebCore

2010-12-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Postpone gl delete* calls until shaders/programs are no longer attached
https://bugs.webkit.org/show_bug.cgi?id=50501

  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::deleteObjectImpl): Simply delete GL resource.
  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::deleteObjectImpl): Ditto.
  • html/canvas/WebGLObject.cpp: (WebCore::WebGLObject::deleteObject): Tracking whether deleteObjectImpl should be called or not.
  • html/canvas/WebGLObject.h: (WebCore::WebGLObject::detachContext): Set attachmentCount to 0 to ensure OpenGL resource deletion. (WebCore::WebGLObject::onDetached): No need to track attachmentCount here as we track it in deleteObject. (WebCore::WebGLObject::isDeleted): Make this public.
  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::deleteObjectImpl): Simply delete GL resource.
  • html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::deleteObjectImpl): Ditto.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getProgramParameter): intercept DELETE_STATUS. (WebCore::WebGLRenderingContext::getShaderParameter): Ditto.
  • html/canvas/WebGLShader.cpp: (WebCore::WebGLShader::deleteObjectImpl): Simply delete GL resource.
  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::deleteObjectImpl): Simply delete GL resource.
3:14 PM Changeset in webkit [73405] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

reserveAndCommit doesn't commit on MADVISE_FREE_REUSE systems
https://bugs.webkit.org/show_bug.cgi?id=50588

Reviewed by Maciej Stachowiak.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit): Tightened up some comments. Changed
reserveAndCommit to actually commit on MADVISE_FREE_REUSE systems.

3:12 PM RebaselineServer edited by mihaip@chromium.org
(diff)
3:12 PM Changeset in webkit [73404] by rniwa@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2010-12-06 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Leopard rebaseline for r73385. The actual results now match that of Snow Leopard.

  • platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.txt Removed.
  • platform/mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.checksum: Removed.
  • platform/mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.png: Removed.
  • platform/mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.txt: Removed.
3:08 PM Changeset in webkit [73403] by victorw@chromium.org
  • 13 edits
    4 adds in trunk/LayoutTests

2010-12-06 Victor Wang <victorw@chromium.org>

Unreviewed.

[Chromium] update chromium mac test baselines affected by http://trac.webkit.org/changeset/73385

  • platform/chromium-mac/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.txt: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.png: Added.
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum:
  • platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
3:04 PM RebaselineServer edited by mihaip@chromium.org
(diff)
3:03 PM section-8.png attached to RebaselineServer by mihaip@chromium.org
3:02 PM RebaselineServer edited by mihaip@chromium.org
Rebaseline server: rest of UI walkthrough (diff)
2:54 PM Changeset in webkit [73402] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/http/tests/misc/acid3-expected.txt

Land updated results for acid3.

2:49 PM section-4.png attached to RebaselineServer by mihaip@chromium.org
2:48 PM RebaselineServer edited by mihaip@chromium.org
Rebaseline server: more UI walkthrough (diff)
2:41 PM overview.png attached to RebaselineServer by mihaip@chromium.org
2:40 PM RebaselineServer edited by mihaip@chromium.org
Rebaseline server: begin UI walkthrough (diff)
2:34 PM section-1.png attached to RebaselineServer by mihaip@chromium.org
2:32 PM Changeset in webkit [73401] by victorw@chromium.org
  • 294 edits
    10 adds
    9 deletes in trunk/LayoutTests

2010-12-06 Victor Wang <victorw@chromium.org>

Unreviewed.

[Chromium] update chromium layout test baselines affected by http://trac.webkit.org/changeset/73385

  • platform/chromium-linux/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-linux/css2.1/t1202-counters-09-b-expected.txt:
  • platform/chromium-linux/fast/block/positioning/047-expected.txt:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-linux/fast/lists/001-expected.checksum: Added.
  • platform/chromium-linux/fast/lists/001-expected.png: Added.
  • platform/chromium-linux/fast/lists/001-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/003-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/float-multicol-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/float-paginate-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/paginate-block-replaced-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt: Removed.
  • platform/chromium-linux/fast/overflow/image-selection-highlight-expected.checksum:
  • platform/chromium-linux/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-linux/fast/overflow/infiniteRecursionGuard-expected.checksum:
  • platform/chromium-linux/fast/overflow/infiniteRecursionGuard-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-float-stacking-expected.txt: Added.
  • platform/chromium-linux/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
  • platform/chromium-linux/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/chromium-linux/fast/overflow/overflow-with-local-background-attachment-expected.checksum:
  • platform/chromium-linux/fast/overflow/overflow-with-local-background-attachment-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.checksum:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-linux/fast/repaint/text-selection-rect-in-overflow-2-expected.checksum:
  • platform/chromium-linux/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/chromium-linux/fast/repaint/text-selection-rect-in-overflow-expected.checksum:
  • platform/chromium-linux/fast/repaint/text-selection-rect-in-overflow-expected.png:
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.checksum:
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.txt:
  • platform/chromium-linux/fast/text/letter-spacing-negative-opacity-expected.txt:
  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum:
  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-win/css1/box_properties/margin-expected.txt:
  • platform/chromium-win/css1/box_properties/margin_right-expected.txt:
  • platform/chromium-win/css1/classification/white_space-expected.txt:
  • platform/chromium-win/css1/color_and_background/background_attachment-expected.txt:
  • platform/chromium-win/css1/color_and_background/background_repeat-expected.txt:
  • platform/chromium-win/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt:
  • platform/chromium-win/css2.1/t0803-c5505-mrgn-02-c-expected.txt:
  • platform/chromium-win/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-00-d-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/chromium-win/css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/chromium-win/css2.1/t1202-counters-08-b-expected.txt:
  • platform/chromium-win/css2.1/t1202-counters-09-b-expected.txt:
  • platform/chromium-win/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/chromium-win/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/chromium-win/editing/selection/focus_editable_html-expected.txt:
  • platform/chromium-win/editing/selection/select-all-001-expected.txt:
  • platform/chromium-win/editing/selection/select-all-002-expected.txt:
  • platform/chromium-win/editing/selection/select-all-003-expected.txt:
  • platform/chromium-win/editing/selection/select-all-004-expected.txt:
  • platform/chromium-win/editing/selection/unrendered-001-expected.txt:
  • platform/chromium-win/editing/selection/unrendered-002-expected.txt:
  • platform/chromium-win/editing/selection/unrendered-003-expected.txt:
  • platform/chromium-win/editing/selection/unrendered-004-expected.txt:
  • platform/chromium-win/editing/selection/unrendered-005-expected.txt:
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/chromium-win/fast/block/basic/010-expected.txt:
  • platform/chromium-win/fast/block/float/013-expected.txt:
  • platform/chromium-win/fast/block/float/021-expected.txt:
  • platform/chromium-win/fast/block/float/029-expected.txt:
  • platform/chromium-win/fast/block/float/031-expected.txt:
  • platform/chromium-win/fast/block/float/avoidance-percent-width-strict-expected.txt:
  • platform/chromium-win/fast/block/float/clamped-right-float-expected.txt:
  • platform/chromium-win/fast/block/float/float-in-float-painting-expected.txt:
  • platform/chromium-win/fast/block/float/nested-clearance-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/004-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/062-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/063-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/104-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/chromium-win/fast/block/positioning/002-expected.txt:
  • platform/chromium-win/fast/block/positioning/047-expected.txt:
  • platform/chromium-win/fast/block/positioning/051-expected.txt:
  • platform/chromium-win/fast/block/positioning/061-expected.txt:
  • platform/chromium-win/fast/block/positioning/auto-height-with-top-and-bottom-expected.txt:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/chromium-win/fast/body-propagation/background-color/002-expected.txt:
  • platform/chromium-win/fast/body-propagation/background-color/002-xhtml-expected.txt:
  • platform/chromium-win/fast/body-propagation/background-image/002-expected.txt:
  • platform/chromium-win/fast/body-propagation/background-image/002-xhtml-expected.txt:
  • platform/chromium-win/fast/body-propagation/overflow/001-expected.txt:
  • platform/chromium-win/fast/body-propagation/overflow/001-xhtml-expected.txt:
  • platform/chromium-win/fast/body-propagation/overflow/005-declarative-expected.txt:
  • platform/chromium-win/fast/body-propagation/overflow/005-expected.txt:
  • platform/chromium-win/fast/body-propagation/overflow/005-xhtml-expected.txt:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.txt:
  • platform/chromium-win/fast/box-sizing/box-sizing-expected.txt:
  • platform/chromium-win/fast/clip/008-expected.txt:
  • platform/chromium-win/fast/clip/009-expected.txt:
  • platform/chromium-win/fast/clip/010-expected.txt:
  • platform/chromium-win/fast/clip/011-expected.txt:
  • platform/chromium-win/fast/clip/012-expected.txt:
  • platform/chromium-win/fast/compact/001-expected.txt:
  • platform/chromium-win/fast/css/MarqueeLayoutTest-expected.txt:
  • platform/chromium-win/fast/css/negative-leading-expected.txt:
  • platform/chromium-win/fast/css/percentage-non-integer-expected.txt:
  • platform/chromium-win/fast/css/word-space-extra-expected.txt:
  • platform/chromium-win/fast/dom/clone-node-dynamic-style-expected.txt:
  • platform/chromium-win/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/chromium-win/fast/events/focusingUnloadedFrame-expected.txt:
  • platform/chromium-win/fast/flexbox/009-expected.txt:
  • platform/chromium-win/fast/flexbox/016-expected.txt:
  • platform/chromium-win/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/chromium-win/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-win/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/chromium-win/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/chromium-win/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/chromium-win/fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/chromium-win/fast/inline-block/tricky-baseline-expected.txt:
  • platform/chromium-win/fast/inline/long-wrapped-line-expected.txt:
  • platform/chromium-win/fast/layers/layer-visibility-expected.txt:
  • platform/chromium-win/fast/layers/layer-visibility-sublayer-expected.txt:
  • platform/chromium-win/fast/layers/overflow-scroll-auto-switch-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/fast/lists/001-expected.txt:
  • platform/chromium-win/fast/lists/001-vertical-expected.txt:
  • platform/chromium-win/fast/lists/003-expected.txt:
  • platform/chromium-win/fast/lists/003-vertical-expected.txt:
  • platform/chromium-win/fast/lists/li-br-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-02-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-03-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-04-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-05-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-06-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-07-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-08-expected.txt:
  • platform/chromium-win/fast/media/mq-relative-constraints-09-expected.txt:
  • platform/chromium-win/fast/media/mq-width-absolute-01-expected.txt:
  • platform/chromium-win/fast/media/mq-width-absolute-02-expected.txt:
  • platform/chromium-win/fast/media/mq-width-absolute-03-expected.txt:
  • platform/chromium-win/fast/media/mq-width-absolute-04-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.txt:
  • platform/chromium-win/fast/multicol/float-paginate-expected.txt:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/nested-columns-expected.txt:
  • platform/chromium-win/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/chromium-win/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-win/fast/overflow/002-expected.txt:
  • platform/chromium-win/fast/overflow/006-expected.txt:
  • platform/chromium-win/fast/overflow/dynamic-hidden-expected.txt:
  • platform/chromium-win/fast/overflow/float-in-relpositioned-expected.txt:
  • platform/chromium-win/fast/overflow/image-selection-highlight-expected.checksum:
  • platform/chromium-win/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-win/fast/overflow/image-selection-highlight-expected.txt:
  • platform/chromium-win/fast/overflow/infiniteRecursionGuard-expected.checksum:
  • platform/chromium-win/fast/overflow/infiniteRecursionGuard-expected.png:
  • platform/chromium-win/fast/overflow/infiniteRecursionGuard-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-auto-table-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.txt: Added.
  • platform/chromium-win/fast/overflow/overflow-stacking-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-with-local-background-attachment-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-x-y-expected.txt:
  • platform/chromium-win/fast/overflow/scrollRevealButton-expected.txt:
  • platform/chromium-win/fast/reflections/reflection-direction-expected.txt:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.txt:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.checksum:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.txt:
  • platform/chromium-win/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt:
  • platform/chromium-win/fast/repaint/float-overflow-expected.txt:
  • platform/chromium-win/fast/repaint/float-overflow-right-expected.txt:
  • platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.txt:
  • platform/chromium-win/fast/repaint/overflow-scroll-delete-expected.checksum:
  • platform/chromium-win/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/chromium-win/fast/repaint/overflow-scroll-delete-expected.txt:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-2-expected.checksum:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-expected.checksum:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-expected.png:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-expected.txt:
  • platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
  • platform/chromium-win/fast/replaced/004-expected.txt:
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.checksum:
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.txt:
  • platform/chromium-win/fast/table/034-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium-win/fast/table/frame-and-rules-expected.txt:
  • platform/chromium-win/fast/table/overflowHidden-expected.txt:
  • platform/chromium-win/fast/text/international/thai-line-breaks-expected.txt:
  • platform/chromium-win/fast/text/large-text-composed-char-expected.txt:
  • platform/chromium-win/fast/text/letter-spacing-negative-opacity-expected.txt:
  • platform/chromium-win/fast/text/text-letter-spacing-expected.txt:
  • platform/chromium-win/fast/text/whitespace/012-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/scrollbars/basic-scrollbar-expected.txt:
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum:
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/chromium-win/scrollbars/disabled-scrollbar-expected.txt:
  • platform/chromium-win/scrollbars/scrollbar-buttons-expected.txt:
  • platform/chromium-win/scrollbars/scrollbar-orientation-expected.txt:
  • platform/chromium-win/svg/custom/altglyph-expected.txt:
  • platform/chromium-win/svg/custom/getscreenctm-in-mixed-content-expected.txt:
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/chromium-win/svg/custom/invisible-text-after-scrolling-expected.txt:
  • platform/chromium-win/svg/custom/path-bad-data-expected.txt:
  • platform/chromium-win/svg/custom/scroll-hit-test-expected.txt: Added.
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium-win/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/chromium-win/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/chromium-win/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/chromium-win/svg/text/kerning-expected.txt:
  • platform/chromium-win/svg/text/multichar-glyph-expected.txt:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug23151-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug43039-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug45055-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug5797-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug72359-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug83786-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug92143-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-win/tables/mozilla/core/nested1-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_index-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_left-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_table_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_td_nowrap-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_th_nowrap-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug67915-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
  • platform/chromium-win/transforms/svg-vs-css-expected.txt:
2:10 PM RebaselineServer edited by mihaip@chromium.org
Rebaseline server: more code descriptions (diff)
2:02 PM Changeset in webkit [73400] by xji@chromium.org
  • 15 edits
    12 copies in branches/chromium/597

Merge 72852 - 2010-11-29 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by David Hyatt.

Right-to-left pages should be scrollable to reveal left overflow.
https://bugs.webkit.org/show_bug.cgi?id=23556

Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
pages with a left overflow.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView inProgramaticScroll]): (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]): (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]): (-[WebDynamicScrollBarsView setScrollOriginX:]): (-[WebDynamicScrollBarsView scrollOriginX]):
  • WebView/WebFrameView.mm: (-[WebFrameView _scrollToBeginningOfDocument]): (-[WebFrameView _scrollToEndOfDocument]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]):

2010-11-29 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Right-to-left pages should be scrollable to reveal left overflow.
https://bugs.webkit.org/show_bug.cgi?id=23556

For RTL page, save left layout overflow and include it into the document
size during layout. Use the left layout overflow when scroll and paint
the page. Behavior on LTR page should be untouched since left layout
overflow is set as 0 for LTR page.

Tests: fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html

fast/dom/horizontal-scrollbar-in-rtl.html
fast/dom/horizontal-scrollbar-when-dir-change.html
fast/dom/left-overflow-in-ltr.html
fast/dom/right-overflow-in-rtl.html

  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): Save negative of left layout overflow as scroll X origin. And includes left layout overflow into document size.
  • page/mac/WebCoreFrameView.h: Add methods for setting and getting scroll X origin.
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::maximumScrollPosition): Minus scroll X origin from maximum horizontal scroll position. (WebCore::ScrollView::minimumScrollPosition): (WebCore::ScrollView::adjustScrollPositionWithinRange): (WebCore::ScrollView::valueChanged): (WebCore::ScrollView::setScrollPosition): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformSetContentsSize): (WebCore::ScrollView::platformSetScrollPosition): (WebCore::ScrollView::platformSetScrollOriginX):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::paintRootBoxDecorations): Include left layout overflow into canvas size.
  • rendering/RenderView.cpp: (WebCore::RenderView::layout): Save left layout overflow. (WebCore::RenderView::docLeft): (WebCore::RenderView::docWidth): Include left layout overflow into doc width for RTL page.
  • rendering/RenderView.h:

2010-11-29 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Right-to-left pages should be scrollable to reveal left overflow.
https://bugs.webkit.org/show_bug.cgi?id=23556

For RTL page, save left layout overflow and include it into the document
size during layout. Use the left layout overflow when scroll and paint
the page. Behavior on LTR page should be untouched since left layout
overflow is set as 0 for LTR page.

  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt: Added.
  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html: Added.
  • fast/dom/horizontal-scrollbar-in-rtl.html: Added.
  • fast/dom/horizontal-scrollbar-when-dir-change.html: Added.
  • fast/dom/left-overflow-in-ltr.html: Added.
  • fast/dom/right-overflow-in-rtl.html: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/mac/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/dom/left-overflow-in-ltr-expected.txt: Added.
  • platform/mac/fast/dom/right-overflow-in-rtl-expected.txt: Added.
  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt: Added.
  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html: Added.
  • fast/dom/horizontal-scrollbar-in-rtl.html: Added.
  • fast/dom/horizontal-scrollbar-when-dir-change.html: Added.
  • fast/dom/left-overflow-in-ltr.html: Added.
  • fast/dom/right-overflow-in-rtl.html: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/mac/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/dom/left-overflow-in-ltr-expected.txt: Added.
  • platform/mac/fast/dom/right-overflow-in-rtl-expected.txt: Added.

TBR=xji@chromium.org

2:01 PM Changeset in webkit [73399] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-12-06 Ryosuke Niwa <rniwa@webkit.org>

Yet unreviewed another Leopard build fix for r73380.

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm: (PlatformCAAnimation::setKeyTimes):
  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::platformCALayer):
1:58 PM RebaselineServer created by mihaip@chromium.org
Initial rebaseline server wiki page.
1:57 PM Changeset in webkit [73398] by aestes@apple.com
  • 3 edits
    4 adds in trunk

2010-12-06 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Marquee elements do not stop animating when scrollAmount is set to 0.
https://bugs.webkit.org/show_bug.cgi?id=50434

Test: fast/html/marquee-scrollamount.html

  • rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::timerFired): Allow increment to be 0.

2010-12-06 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Marquee elements do not stop animating when scrollAmount is set to 0.
https://bugs.webkit.org/show_bug.cgi?id=50434

  • fast/html/marquee-scrollamount.html: Added.
  • platform/mac/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/mac/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/mac/fast/html/marquee-scrollamount-expected.txt: Added.
1:52 PM Changeset in webkit [73397] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-12-06 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Leopard buildfix for r73380.

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm: (PlatformCAAnimation::setTimingFunctions):
  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::PlatformCALayer):
1:37 PM Changeset in webkit [73396] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-12-06 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] use ResourceHandle::setDefersLoading in WebKitWebSourceGStreamer
https://bugs.webkit.org/show_bug.cgi?id=44157

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcNeedDataMainCb): (webKitWebSrcEnoughDataMainCb): Replaced platform-specific code with cross-platform ResourceHandle::setDefersLoading calls.
1:30 PM WikiStart edited by mihaip@chromium.org
(diff)
1:27 PM Changeset in webkit [73395] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-12-06 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Leopard build fix for r73388.

  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::maxValueForRange): (WebCore::AccessibilitySlider::minValueForRange):
1:25 PM WikiStart edited by mihaip@chromium.org
Group layout test-related wiki pages. (diff)
1:19 PM Changeset in webkit [73394] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-12-06 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed build fix for Leopard after r73379.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setAllowsFontSmoothing):
1:15 PM Changeset in webkit [73393] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent): Wrap Carbon-specific code in #ifndef NP_NO_CARBON.

1:11 PM Changeset in webkit [73392] by Nate Chapin
  • 37 edits in trunk

2010-12-06 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Make DocumentWriter a member of DocumentLoader
instead of FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=50489

Refactor, no new tests.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::close): (WebCore::Document::lastModified): (WebCore::Document::finishedParsing): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
  • dom/Document.h: (WebCore::Document::setDocumentLoader): (WebCore::Document::loader):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::commitData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setFrame):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::writer):
  • loader/DocumentWriter.h: (WebCore::DocumentWriter::setFrame):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h: (WebCore::FrameLoader::notifier):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestPreload):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
12:58 PM Changeset in webkit [73391] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Add a shim for GetCurrentEventButtonState
https://bugs.webkit.org/show_bug.cgi?id=50583

Reviewed by Adam Roben.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::getCurrentEventButtonState):
Get the event button state from the plug-in.

(WebKit::PluginProcess::initializeShim):
Add new shim callback.

  • PluginProcess/mac/PluginProcessShim.cpp:

(WebKit::shimGetCurrentEventButtonState):
Add shim.

  • PluginProcess/mac/PluginProcessShim.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::buttonState):
Return the button state.

(WebKit::NetscapePlugin::platformHandleMouseEvent):
Update the button state. Also, make sure to actually pass the modifiers to NPP_HandleEvent.

12:58 PM Changeset in webkit [73390] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • WebCore.xcodeproj/project.pbxproj: Don't force WebCore to build against the 10.5 SDK.

That's just plain wrong.

12:39 PM Changeset in webkit [73389] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-06 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] fix an assert hit in DRT
https://bugs.webkit.org/show_bug.cgi?id=50575

This class uses WTF's RefPtr, but expects chrome's base::RefPtr
semantics.

Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
(third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
WTF::RefCountedBase::ref()).

  • DumpRenderTree/chromium/TestWebWorker.h: (TestWebWorker::TestWebWorker):
12:37 PM Changeset in webkit [73388] by Chris Fleizach
  • 9 edits
    2 adds in trunk

HTML5 Slider does not work correctly with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=50505

Reviewed by Darin Adler.

Address a few problems with the Mac implementation for the accessibility slider.

1) The value indicator is not hit testable.
2) The value indicator does not return an AXValue.
3) In the slider, the min/max values are not correct when min/max attributes are not present.
4) When you change the value with the keyboard, it doesn't send out the right notification.
5) Sliders were returning AXValue and AXTopLevelUIElement attributes twice in their list of attributes.

Test: platform/mac/accessibility/html-slider-indicator.html

WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::getAttribute):

Use fastGetAttribute on Element, instead of getAttribute.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isInputSlider):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::doAccessibilityHitTest):
(WebCore::AccessibilitySlider::maxValueForRange):
(WebCore::AccessibilitySlider::minValueForRange):

  • accessibility/AccessibilitySlider.h:

(WebCore::AccessibilitySlider::isInputSlider):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::applyStep):

LayoutTests:

  • platform/mac/accessibility/html-slider-indicator-expected.txt: Added.
  • platform/mac/accessibility/html-slider-indicator.html: Added.
12:34 PM Changeset in webkit [73387] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Add a shim for IsWindowActive
https://bugs.webkit.org/show_bug.cgi?id=50582

Reviewed by Adam Roben.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::isWindowActive):
Get the NetscapePlugin from the WindowRef and check if the plug-in's window is active.

(WebKit::PluginProcess::initializeShim):

  • PluginProcess/mac/PluginProcessShim.cpp

(WebKit::shimIsWindowActive):
Call isWindowActive. If it returns true, return the result value. Otherwise, call the real
IsWindowActive function.

  • PluginProcess/mac/PluginProcessShim.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_isWindowactive.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(WebKit::NetscapePlugin::isWindowActive):
Return whether the window is active.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::windowMap):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::netscapePluginFromWindow):
Add a mapping between windows and the corresponding NetscapePlugin objects.

(WebKit::NetscapePlugin::windowFocusChanged):
Update the window focus member variable.

12:32 PM Changeset in webkit [73386] by aa@chromium.org
  • 2 edits in branches/chromium/597/WebCore

Merge 73245 - 2010-12-02 Aaron Boodman <aa@chromium.org>

Reviewed by David Hyatt.

Reduce the number of cases where we end up with a stale value for
minimumPreferredLogicalWidth(). This isn't a complete fix, but fixes a
large number of cases.

RenderObject::minimumPreferredLogicalWidth() sometimes reports wrong value.
https://bugs.webkit.org/show_bug.cgi?id=50119

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange):

TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/5661001

12:03 PM Changeset in webkit [73385] by hyatt@apple.com
  • 303 edits
    4 adds in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=49220 <<rdar://problem/8644849>, REGRESSION: transforms now
O(n3) from pathological behavior in lowestPosition, rightmostPosition, leftmostPosition and topmostPosition.

Reviewed by Simon Fraser.

This patch throws out the lowest/rightmost/leftmost/topmostPosition functions and re-architects layout overflow
in the engine to cache all the information required to properly handle scrolling.

In the old code, there were two types of overflow: layout overflow and visual overflow. The former could
affect scrolling and the latter could not. The distinction was largely meaningless, since layout overflow
wasn't actually used to determine scroll width or scroll height. It didn't propagate across self-painting layer
boundaries either. In the old code, the term visible overflow meant the union of the layout overflow and
visual overflow rects.

In the new code, the two types of overflow remain, but the distinction between the two is now clear. Visual overflow
is used purely for painting and hit testing checks and layout overflow is used specifically for scrolling. It has
been expanded to propagate across self-painting layers, to factor in relative positioning and transforms, and to
work with writing modes.

In order to minimize layout test changes, layers no longer incorporate right/bottom overflow into their width/height members.
Doing so uncovered two bugs where left/top overflow was ignored (proof that even having layer dimensions is harmful).
A render tree dump hack has been put into the code to keep this overflow dumping for the RenderView's layer, since otherwise
a huge number of tests would change.

Added fast/overflow/overflow-rtl-vertical.html to test vertical writing-mode overflow. Existing tests cover the rest.

WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::forceLayoutForPagination):
Changed to use RenderView's docTop/Left/Width/Height accessors, which simply grab the overflow and properly flip it
to account for writing modes.

  • platform/graphics/IntRect.h:

(WebCore::IntRect::shiftLeftEdgeTo):
(WebCore::IntRect::shiftRightEdgeTo):
(WebCore::IntRect::shiftTopEdgeTo):
(WebCore::IntRect::shiftBottomEdgeTo):
New helper functions for sliding the edge of a rectangle without moving any of the other three edges.

  • rendering/InlineBox.h:

(WebCore::InlineBox::frameRect):
frameRect is a helper for obtaining the x, y, width, height of an InlineBox as an IntRect.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
All of the overflow setting in the inline direction has been removed from this function. All line overflow is computed
at once now in a single function: computeOverflow.

(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::addReplacedChildOverflow):
Helper for propagating overflow from specific types of children that occur on a line into the InlineFlowBox's overflow.

(WebCore::InlineFlowBox::computeOverflow):
The new function that computes both horizontal and vertical overflow for a line box.

(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):
(WebCore::InlineFlowBox::setOverflowFromLogicalRects):
New functions that set the overflow computed by computeOverflow. These replace setBlockDirectionOverflowPositions
and setInlineDirectionOverflowPositions. They essentially do the same thing, but they operate on rectangles.

(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
Changed to use visual overflow instead of visible overflow. (Visible overflow as a union of layout and visual
overflow is no longer necessary, since visual overflow is now equivalent to the old visible overflow concept.)

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::logicalLayoutOverflowRect):
(WebCore::InlineFlowBox::logicalVisualOverflowRect):
Helpers for obtaining logical overflow rectangles, since lines compute their overflow in logical terms before
converting to block coordinates at the end.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::addOverflowFromPositionedObjects):
Blocks now have a computeOverflow function called at the end of layout that adds in all the types of overflow. The addOverflowFromChildren
method is virtual so that RenderListItem and RenderTable can subclass it. RenderListItem has to position its list marker and
propagate marker overflow up, and RenderTable adds in overflow from its sections.

(WebCore::RenderBlock::layoutOnlyPositionedObjects):
(WebCore::RenderBlock::layoutPositionedObjects):
When only positioned objects lay out, overflow must still be recomputed. The refactoring of overflow computation into a single
callable method: computeOverflow, makes it possible for this to be done easily.

(WebCore::RenderBlock::paint):
visible -> visual.

(WebCore::RenderBlock::addOverhangingFloats):
The propagation of float overflow has changed substantially. The basic rules are:

(1) The float must be in our floating objects list to contribute to overflow.
(2) The float must be a descendant to contribute to overflow.
(3) The block must have the outermost list that contains the float, or it has a self-painting layer and

so the float needs to be included in its overflow.

(WebCore::RenderBlock::nodeAtPoint):
visible -> visual.

(WebCore::RenderBlock::layoutColumns):
Remove column overflow computation from layoutColumns and move it to computeOverflow.

(WebCore::RenderBlock::adjustLinePositionForPagination):
visible -> visual.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::scrollbarsChanged):
Added a new virtual method used by table cells when scrollbars in an overflow:auto/scroll table cell come and go.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
visible -> visual.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
Patched to use layoutOverflow functions instead of the old rightmost/leftmostPosition functions.

(WebCore::RenderBox::paintRootBoxDecorations):
Use docLeft and docTop here, so that writing modes are handled.

(WebCore::RenderBox::clippedOverflowRectForRepaint):
visible -> visual.

(WebCore::RenderBox::addOverflowFromChild):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::logicalVisualOverflowRectForPropagation):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::logicalLayoutOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

  • rendering/RenderBox.h:

The new overflow system for boxes. Layout overflow now crosses self-painting layer boundaries and adjusts child boxes
for transforms, relative positioning and writing mode differences.

(WebCore::RenderBox::layoutOverflowRect):
(WebCore::RenderBox::topLayoutOverflow):
(WebCore::RenderBox::bottomLayoutOverflow):
(WebCore::RenderBox::leftLayoutOverflow):
(WebCore::RenderBox::rightLayoutOverflow):
Changed the default rectangle for layout overflow to be the client box to match the scrollable areas of overflow regions.

(WebCore::RenderBox::clientLogicalBottom):
New helper for obtaining the logical bottom of the client box.

(WebCore::RenderBox::clientBoxRect):
New helper for obtaining the clientLeft/Top/Width/Height box.

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::relativePositionLogicalOffset):
Helper for obtaining the relative position offset transposed for vertical writing modes. Used by line overflow.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
Changed flexible boxes to just call the base class computeOverflow method.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
visible -> visual.

  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):
Changed layers to no longer incorporate right/bottom overflow into width/height. This is the reason many layout
tests change. (Not doing this makes the layout test changes far worse, since overflow propagates across self-painting
layers now.)

(WebCore::RenderLayer::overflowTop):
(WebCore::RenderLayer::overflowBottom):
(WebCore::RenderLayer::overflowLeft):
(WebCore::RenderLayer::overflowRight):
overflowTop/Bottom/Left/Right return overflow that accounts for writing modes, i.e., purely physical overflow that can be used
to set up the scroll area.

(WebCore::RenderLayer::computeScrollDimensions):
Drastically simplified this method now that overflowTop/Bottom/Left/Right just do the right thing regarding unreachable overflow.

(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Make sure to explicitly set the vertical scrollbar's position just as we did with horizontal scrollbars, so that clamping to the
bottom works.

(WebCore::performOverlapTests):
(WebCore::RenderLayer::paintLayer):
Fix a bug in performOverlapTests. It incorrectly used the layer's bounds, and so it didn't account for left/top overflow out
of the layer (see why I hate layers even having dimensions?). Changed it to use the bounding box of the layer instead.

(WebCore::RenderLayer::hitTest):
Fix a bug in hit testing. It incorrectly used the root layer's bounds as the limit of the hit test, and so it didn't account
for left/top overflow in a ScrollView (hate hate hate layers having dimensions). I changed it to use the hit test rect instead,
so that the damage rect never stops the point from being tested (unless the hit test request says not to ignore clipping).

(WebCore::RenderLayer::localBoundingBox):
visible -> visual.

  • rendering/RenderLayer.h:

Added the new overflowTop/Left/Right/Bottom accessors.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
visible -> visual.

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::addOverflowFromChildren):
(WebCore::RenderListItem::positionListMarker):

  • rendering/RenderListItem.h:

RenderListItem now positions the list marker when computing its overflow, since the marker propagates overflow back up to the list item.

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):
visible -> visual.

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):
Changed to use overflow functions instead of rightmost/lowestPosition.

  • rendering/RenderMedia.cpp:
  • rendering/RenderMedia.h:

Removed the lowest/topmost/rightmost/leftmostPosition functions, since control overflow is handled properly already.

  • rendering/RenderOverflow.h:

(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::setLayoutOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
Add new setters for layout and visual overflow as rects.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
visible -> visual.

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layout):
Call computeOverflow to recompute our overflow information after we adjust the ruby.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):
(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::paint):

  • rendering/RenderTable.h:

Move section overflow propagation into addOverflowFromChildren, and change RenderTable to just call computeOverflow.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
visible -> visual.

(WebCore::RenderTableCell::scrollbarsChanged):
Adding unreachable overflow support (something that in the old code only existed for positioned objects in the root view) exposed
a bug in table layout. If scrollbars are added during the layout that occurs after intrinsic padding was incorporated into the
cell, then the cell won't lay out properly the second time (after the scrollbars have been added). We have to adjust the intrinsic
padding accounting for the presence of the new scrollbar so the second layout will get the right dimensions.

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::hasVisualOverflow):
visible -> visual.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderTableSection.h:

visible -> visual. Removed the leftmost/rightmost/topmost/bottommostPosition functions.

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):
Added a hack to render tree dumping to include right/bottom overflow for the root layer only. This keeps a zillion layout tests
from failing.

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):
(WebCore::RenderView::docTop):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docRight):

  • rendering/RenderView.h:

(WebCore::RenderView::docHeight):
(WebCore::RenderView::docWidth):
RenderView now uses docLeft/Top/Height/Width functions, which are just overflow queries that account for writing modes. These methods
are now the preferred way to query for the physical dimensions of a document.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::addHighlightOverflow):
Changed to call setOverflowFromLogicalRects instead of the block/inline position functions.

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
Remove the computation of block direction overflow, since it now all happens at once after the line is built.

(WebCore::RootInlineBox::paddedLayoutOverflowRect):

  • rendering/RootInlineBox.h:

Added a new helper function for incorporating the end padding into a line. This end padding also includes the single pixel for a caret
in LTR if needed.

LayoutTests:

  • compositing/checkerboard-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • fast/backgrounds/size/contain-and-cover-expected.txt:
  • fast/flexbox/009.html:
  • fast/overflow/overflow-rtl-vertical.html: Added.
  • fast/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
  • fast/spatial-navigation/snav-clipped-overflowed-content.html:
  • platform/mac/compositing/direct-image-compositing-expected.txt:
  • platform/mac/compositing/geometry/fixed-position-expected.txt:
  • platform/mac/compositing/geometry/video-opacity-overlay-expected.txt:
  • platform/mac/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
  • platform/mac/compositing/overflow/scroll-ancestor-update-expected.txt:
  • platform/mac/compositing/reflections/load-video-in-reflection-expected.txt:
  • platform/mac/compositing/repaint/content-into-overflow-expected.txt:
  • platform/mac/compositing/repaint/overflow-into-content-expected.txt:
  • platform/mac/css1/box_properties/margin-expected.txt:
  • platform/mac/css1/box_properties/margin_right-expected.txt:
  • platform/mac/css1/classification/white_space-expected.txt:
  • platform/mac/css1/color_and_background/background_attachment-expected.txt:
  • platform/mac/css1/color_and_background/background_repeat-expected.txt:
  • platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt:
  • platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.txt:
  • platform/mac/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-00-d-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/mac/css2.1/t1202-counters-08-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-09-b-expected.txt:
  • platform/mac/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/mac/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/mac/editing/selection/25228-expected.txt:
  • platform/mac/editing/selection/focus_editable_html-expected.txt:
  • platform/mac/editing/selection/select-all-001-expected.txt:
  • platform/mac/editing/selection/select-all-002-expected.txt:
  • platform/mac/editing/selection/select-all-003-expected.txt:
  • platform/mac/editing/selection/select-all-004-expected.txt:
  • platform/mac/editing/selection/unrendered-001-expected.txt:
  • platform/mac/editing/selection/unrendered-002-expected.txt:
  • platform/mac/editing/selection/unrendered-003-expected.txt:
  • platform/mac/editing/selection/unrendered-004-expected.txt:
  • platform/mac/editing/selection/unrendered-005-expected.txt:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/mac/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/mac/fast/block/basic/010-expected.txt:
  • platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
  • platform/mac/fast/block/float/008-expected.txt:
  • platform/mac/fast/block/float/013-expected.txt:
  • platform/mac/fast/block/float/019-expected.txt:
  • platform/mac/fast/block/float/021-expected.txt:
  • platform/mac/fast/block/float/029-expected.txt:
  • platform/mac/fast/block/float/031-expected.txt:
  • platform/mac/fast/block/float/033-expected.txt:
  • platform/mac/fast/block/float/035-expected.txt:
  • platform/mac/fast/block/float/avoidance-percent-width-strict-expected.txt:
  • platform/mac/fast/block/float/clamped-right-float-expected.txt:
  • platform/mac/fast/block/float/float-in-float-painting-expected.txt:
  • platform/mac/fast/block/float/nested-clearance-expected.txt:
  • platform/mac/fast/block/float/relative-painted-twice-expected.txt:
  • platform/mac/fast/block/margin-collapse/004-expected.txt:
  • platform/mac/fast/block/margin-collapse/062-expected.txt:
  • platform/mac/fast/block/margin-collapse/063-expected.txt:
  • platform/mac/fast/block/margin-collapse/104-expected.txt:
  • platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/mac/fast/block/positioning/002-expected.txt:
  • platform/mac/fast/block/positioning/047-expected.txt:
  • platform/mac/fast/block/positioning/049-expected.txt:
  • platform/mac/fast/block/positioning/051-expected.txt:
  • platform/mac/fast/block/positioning/auto-height-with-top-and-bottom-expected.txt:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt:
  • platform/mac/fast/blockflow/block-level-images-expected.txt:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/floats-in-block-layout-expected.txt:
  • platform/mac/fast/body-propagation/background-color/002-expected.txt:
  • platform/mac/fast/body-propagation/background-color/002-xhtml-expected.txt:
  • platform/mac/fast/body-propagation/background-image/002-expected.txt:
  • platform/mac/fast/body-propagation/background-image/002-xhtml-expected.txt:
  • platform/mac/fast/body-propagation/overflow/001-expected.txt:
  • platform/mac/fast/body-propagation/overflow/001-xhtml-expected.txt:
  • platform/mac/fast/body-propagation/overflow/005-declarative-expected.txt:
  • platform/mac/fast/body-propagation/overflow/005-expected.txt:
  • platform/mac/fast/body-propagation/overflow/005-xhtml-expected.txt:
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
  • platform/mac/fast/box-shadow/basic-shadows-expected.txt:
  • platform/mac/fast/box-sizing/box-sizing-expected.txt:
  • platform/mac/fast/clip/008-expected.txt:
  • platform/mac/fast/clip/009-expected.txt:
  • platform/mac/fast/clip/010-expected.txt:
  • platform/mac/fast/clip/011-expected.txt:
  • platform/mac/fast/clip/012-expected.txt:
  • platform/mac/fast/compact/001-expected.txt:
  • platform/mac/fast/css/color-correction-on-background-image-expected.txt:
  • platform/mac/fast/css/negative-leading-expected.txt:
  • platform/mac/fast/css/percentage-non-integer-expected.txt:
  • platform/mac/fast/css/word-space-extra-expected.txt:
  • platform/mac/fast/dom/clone-node-dynamic-style-expected.txt:
  • platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/mac/fast/events/focusingUnloadedFrame-expected.txt:
  • platform/mac/fast/flexbox/009-expected.txt:
  • platform/mac/fast/flexbox/016-expected.txt:
  • platform/mac/fast/flexbox/flex-hang-expected.txt:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac/fast/forms/file-input-direction-expected.txt:
  • platform/mac/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt:
  • platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/mac/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/mac/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/mac/fast/gradients/background-clipped-expected.txt:
  • platform/mac/fast/images/gif-large-checkerboard-expected.txt:
  • platform/mac/fast/images/pdf-as-image-landscape-expected.txt:
  • platform/mac/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/mac/fast/inline/long-wrapped-line-expected.txt:
  • platform/mac/fast/layers/layer-visibility-expected.txt:
  • platform/mac/fast/layers/layer-visibility-sublayer-expected.txt:
  • platform/mac/fast/lists/001-expected.txt:
  • platform/mac/fast/lists/001-vertical-expected.txt:
  • platform/mac/fast/lists/003-expected.txt:
  • platform/mac/fast/lists/003-vertical-expected.txt:
  • platform/mac/fast/lists/li-br-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-02-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-03-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-04-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-05-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-06-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-07-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-08-expected.txt:
  • platform/mac/fast/media/mq-relative-constraints-09-expected.txt:
  • platform/mac/fast/media/mq-width-absolute-01-expected.txt:
  • platform/mac/fast/media/mq-width-absolute-02-expected.txt:
  • platform/mac/fast/media/mq-width-absolute-03-expected.txt:
  • platform/mac/fast/media/mq-width-absolute-04-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.txt:
  • platform/mac/fast/multicol/float-paginate-complex-expected.txt:
  • platform/mac/fast/multicol/float-paginate-expected.txt:
  • platform/mac/fast/multicol/layers-in-multicol-expected.txt:
  • platform/mac/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/mac/fast/multicol/table-vertical-align-expected.txt:
  • platform/mac/fast/overflow/006-expected.txt:
  • platform/mac/fast/overflow/float-in-relpositioned-expected.txt:
  • platform/mac/fast/overflow/overflow-auto-table-expected.txt:
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt: Added.
  • platform/mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/mac/fast/reflections/reflection-direction-expected.txt:
  • platform/mac/fast/repaint/box-shadow-h-expected.checksum:
  • platform/mac/fast/repaint/box-shadow-h-expected.png:
  • platform/mac/fast/repaint/box-shadow-h-expected.txt:
  • platform/mac/fast/repaint/box-shadow-v-expected.txt:
  • platform/mac/fast/repaint/content-into-overflow-expected.txt:
  • platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt:
  • platform/mac/fast/repaint/float-overflow-expected.txt:
  • platform/mac/fast/repaint/float-overflow-right-expected.txt:
  • platform/mac/fast/repaint/overflow-into-content-expected.txt:
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.txt:
  • platform/mac/fast/repaint/subtree-root-clip-expected.txt:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.checksum:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/mac/fast/replaced/004-expected.txt:
  • platform/mac/fast/table/034-expected.txt:
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-expected.txt:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
  • platform/mac/fast/table/frame-and-rules-expected.txt:
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt:
  • platform/mac/fast/table/wide-colspan-expected.txt:
  • platform/mac/fast/table/wide-column-expected.txt:
  • platform/mac/fast/text/international/thai-line-breaks-expected.txt:
  • platform/mac/fast/text/large-text-composed-char-expected.txt:
  • platform/mac/fast/text/letter-spacing-negative-opacity-expected.txt:
  • platform/mac/fast/text/text-letter-spacing-expected.txt:
  • platform/mac/fast/text/whitespace/012-expected.txt:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/printing/return-from-printing-mode-expected.txt:
  • platform/mac/svg/custom/altglyph-expected.txt:
  • platform/mac/svg/custom/getscreenctm-in-mixed-content-expected.txt:
  • platform/mac/svg/custom/path-bad-data-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/mac/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/mac/svg/text/kerning-expected.txt:
  • platform/mac/svg/text/multichar-glyph-expected.txt:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug196870-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug23151-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug29314-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug43039-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug43854-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug45055-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug5797-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug625-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug72359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug83786-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug92143-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/core/nested1-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_index-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table_align_left-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_table_align_right-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_td_nowrap-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_th_nowrap-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug67915-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
  • platform/mac/transforms/svg-vs-css-expected.txt:
  • svg/custom/text-zoom-expected.txt:
12:00 PM Changeset in webkit [73384] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-12-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

make webkit-patch command work when the git branch is not synced to the remote svn branch
https://bugs.webkit.org/show_bug.cgi?id=50424

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
11:59 AM Changeset in webkit [73383] by andersca@apple.com
  • 5 edits in trunk/WebKit2

REGERSSION (r73310?): Contents of <select> popup menus are upside-down on Windows
https://bugs.webkit.org/show_bug.cgi?id=50544
<rdar://problem/8732336>

Reviewed by Dan Bernstein.

  • Shared/BackingStore.cpp:
  • Shared/BackingStore.h:
  • Shared/cairo/BackingStoreCairo.cpp:

Remove BackingStore::createFlippedGraphicsContext.

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):
Don't create a flipped graphics context.

11:52 AM Changeset in webkit [73382] by andersca@apple.com
  • 2 edits in trunk/WebKit2

REGRESSION: Text in Find indicator is vertically flipped
https://bugs.webkit.org/show_bug.cgi?id=50524
<rdar://problem/8732978>

Reviewed by Dan Bernstein.

Don't flip the graphics context.

  • UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::draw):

11:48 AM Changeset in webkit [73381] by andersca@apple.com
  • 11 edits in trunk

Dispatch keyboard events in the Carbon event model
https://bugs.webkit.org/show_bug.cgi?id=50503

Reviewed by Sam Weinig.

WebKit2:

  • Shared/WebEvent.h:

(WebKit::WebKeyboardEvent::macCharCode):

  • Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::WebKeyboardEvent):
(WebKit::WebKeyboardEvent::encode):
(WebKit::WebKeyboardEvent::decode):
Add macCharCode field.

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebKeyboardEvent):

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebKeyboardEvent):

  • Shared/win/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebKeyboardEvent):
Pass along the Mac char code.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Convert the event to a Carobn event.

WebKitLibraries:

Make WKGetNSEventKeyChar available in 32-bit.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:35 AM Changeset in webkit [73380] by cmarrin@apple.com
  • 16 edits
    6 copies
    2 deletes in trunk

2010-12-06 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388

Replaced GraphicsLayerMac with GraphicsLayerCA. GraphicsLayerCA is essentially
identical to GraphicsLayerMac, but replaces all the CoreAnimation specific calls
with calls to PlatformCALayer and PlatformCAAnimation. This makes GraphicsLayerCA
platform neutral as long as implementations of those two classes are available.
Added implementations in PlatformCALayerMac and PlatformCAAnimationMac. Also got
rid of GraphicsLayer::nativeLayer() and replaced it with GraphicsLayer::platformLayer()
to avoid confusion since both names were used to refer to the same thing.

This patch is only for Mac. Windows implementation has not changed.

11:31 AM Changeset in webkit [73379] by Simon Fraser
  • 4 edits in trunk/WebCore

2010-12-06 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Font antialiasing (smoothing) changes when elements are rendered into compositing layers
https://bugs.webkit.org/show_bug.cgi?id=23364

Text rendered by Core Graphics over a transparent background looks bad because of
font smoothing, so turn off smoothing when rendering text into compositing layers.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setAllowsFontSmoothing):
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents):
11:08 AM Changeset in webkit [73378] by Patrick Gansterer
  • 5 edits
    8 adds in trunk

2010-12-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Add build system
https://bugs.webkit.org/show_bug.cgi?id=50522

  • cmake/OptionsWinCE.cmake: Added.
  • cmake/OptionsWindows.cmake: Added.

2010-12-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Add build system
https://bugs.webkit.org/show_bug.cgi?id=50522

  • CMakeListsWinCE.txt: Added.
  • shell/CMakeListsWinCE.txt: Added.
  • wtf/CMakeListsWinCE.txt: Added.

2010-12-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Add build system
https://bugs.webkit.org/show_bug.cgi?id=50522

  • CMakeListsWinCE.txt: Added.

2010-12-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Add build system
https://bugs.webkit.org/show_bug.cgi?id=50522

  • CMakeListsWinCE.txt: Added.

2010-12-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Add build system
https://bugs.webkit.org/show_bug.cgi?id=50522

  • CMakeListsWinCE.txt: Added.
10:46 AM Changeset in webkit [73377] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-12-06 John Tantalo <john.tantalo@gmail.com>

Reviewed by Geoffrey Garen.

jsc does not ignore shebang
https://bugs.webkit.org/show_bug.cgi?id=49576

  • jsc.cpp: (fillBufferWithContentsOfFile):
    • translate shebang into a valid JavaScript comment so the lexer ignores it
10:20 AM Changeset in webkit [73376] by mihaip@chromium.org
  • 1 edit
    512 moves
    51 adds in trunk/LayoutTests

2010-12-06 Mihai Parparita <mihaip@chromium.org>

Unreviewed move of Chromium baselines.

In preparation for making pixel tests pass for Chromium on Snow Leopard,
move baselines for 273 tests from chromium-mac to chromium-mac-leopard.
These tests will then use the mac baselines, which will enable them
to pass on Snow Leopard, but keep passing for Leopard too.

List of files omitted due to length but composed entirely of moves from
platform/chromium-mac to platform/chromium-mac-leopard.

10:06 AM Changeset in webkit [73375] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-12-03 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Allow the Chromium port to have Leopard-specific baselines
https://bugs.webkit.org/show_bug.cgi?id=50506

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
9:36 AM Changeset in webkit [73374] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX does not support HTML5 "required"
https://bugs.webkit.org/show_bug.cgi?id=50507

Reviewed by Oliver Hunt.

WebCore:

Test: platform/mac/accessibility/html5-required-attribute.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isRequired):

LayoutTests:

  • platform/mac/accessibility/html5-required-attribute-expected.txt: Added.
  • platform/mac/accessibility/html5-required-attribute.html: Added.
9:35 AM Changeset in webkit [73373] by tony@chromium.org
  • 5 edits in trunk/WebKitTools

2010-12-03 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix 2 bugs with inspector tests in DRT
https://bugs.webkit.org/show_bug.cgi?id=50492

Tasks can outlive the tasklist (even when canceled) so this was
causing a crash when ~WebTask() ran. Avoid this by unregistering
when a task is canceled.

Also fix an assert when closing devtool windows by copying some
logic from test_shell.

  • DumpRenderTree/chromium/Task.cpp: (WebTask::~WebTask): (TaskList::revokeAll):
  • DumpRenderTree/chromium/Task.h: Canceling a task now removes it from

the tasklist (since the task can outlive the tasklist).

  • DumpRenderTree/chromium/TestShell.h: (TestShell::devToolsWebView):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::~WebViewHost): Don't load about:blank when closing

a window if the window has devtools loaded. This avoids an
ASSERT and matches test_shell.

9:13 AM Changeset in webkit [73372] by victorw@chromium.org
  • 1 edit
    21 adds in trunk/LayoutTests

2010-12-06 Victor Wang <victorw@chromium.org>

Unreviewed.

[Chromium] update chromium test expectations.

  • platform/chromium-linux/fast/css/focus-ring-outline-color-expected.checksum: Added.
  • platform/chromium-linux/fast/css/focus-ring-outline-color-expected.png: Added.
  • platform/chromium-linux/fast/css/focus-ring-outline-offset-expected.checksum: Added.
  • platform/chromium-linux/fast/css/focus-ring-outline-offset-expected.png: Added.
  • platform/chromium-linux/fast/css/focus-ring-outline-width-expected.checksum: Added.
  • platform/chromium-linux/fast/css/focus-ring-outline-width-expected.png: Added.
  • platform/chromium-mac/fast/css/focus-ring-outline-color-expected.checksum: Added.
  • platform/chromium-mac/fast/css/focus-ring-outline-color-expected.png: Added.
  • platform/chromium-mac/fast/css/focus-ring-outline-offset-expected.checksum: Added.
  • platform/chromium-mac/fast/css/focus-ring-outline-offset-expected.png: Added.
  • platform/chromium-mac/fast/css/focus-ring-outline-width-expected.checksum: Added.
  • platform/chromium-mac/fast/css/focus-ring-outline-width-expected.png: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-color-expected.checksum: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-color-expected.png: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-color-expected.txt: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-offset-expected.checksum: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-offset-expected.png: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-offset-expected.txt: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-width-expected.checksum: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-width-expected.png: Added.
  • platform/chromium-win/fast/css/focus-ring-outline-width-expected.txt: Added.
8:49 AM Changeset in webkit [73371] by Dimitri Glazkov
  • 3 edits
    2 copies in branches/chromium/597

Merge 73319 - 2010-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): input event fires twice when editing text inside a text input.
https://bugs.webkit.org/show_bug.cgi?id=50477

  • fast/forms/text-input-event-expected.txt: Added.
  • fast/forms/text-input-event.html: Added.

2010-12-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): input event fires twice when editing text inside a text input.
https://bugs.webkit.org/show_bug.cgi?id=50477

Now that events escape the shadow DOM boundary, the input event is fired twice
for each input, once triggered by editing, once triggered by value change.

Test: fast/forms/text-input-event.html

  • dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer): Added a check to ensure editable fields

don't fire an extra input event.

BUG=64750
TBR=Dimitri Glazkov
Review URL: http://codereview.chromium.org/5589004

8:45 AM Changeset in webkit [73370] by sullivan@apple.com
  • 4 edits in trunk/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=50504
Expose some more WebCore settings in WebKit2 preferences

Reviewed by Adam Roben.

  • Shared/WebPreferencesStore.h:

Changed name of existing FOR_EACH_WEBKIT_STRING_PREFERENCE macro to
FOR_EACH_WEBKIT_FONT_FAMILY_PREFERENCE since it was all about platform-specific
font families, and I'm now introducing a non-platform-spacific string, and
I didn't want to put the new preference in two platform-specific lists. Then
added a new FOR_EACH_WEBKIT_STRING_PREFERENCE to hold the new preference. Note
that the other preferences exposed in this patch were already declared here.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDefaultFontSize):
New wrapper.
(WKPreferencesGetDefaultFontSize):
Ditto.
(WKPreferencesSetDefaultFixedFontSize):
Ditto.
(WKPreferencesGetDefaultFixedFontSize):
Ditto.
(WKPreferencesSetDefaultTextEncodingName):
Ditto.
(WKPreferencesCopyDefaultTextEncodingName):
Ditto.

  • UIProcess/API/C/WKPreferences.h:

Declare new wrappers.

8:00 AM Changeset in webkit [73369] by alex
  • 3 edits in trunk/WebCore

2010-12-06 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] using shadows leaks memory
https://bugs.webkit.org/show_bug.cgi?id=50541

Fixed leaks in the shadow code.

  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::drawPatternToCairoContext): adoptRef instead of just getting a new reference.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow): handle cairo_path_t with smart pointers.
7:59 AM Changeset in webkit [73368] by mrobinson@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-12-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Build is broken after r73353
https://bugs.webkit.org/show_bug.cgi?id=50568

Fix the gtk-doc build by making all members of the cache model
enum public. gtk-doc does not support making only some enum
members private. We should also expose it so that users querying
the cache model do not get mysterious, undocumented results.

  • webkit/webkitwebview.h: Fix gtk-doc for the cache model enum.
7:41 AM Changeset in webkit [73367] by alex
  • 2 edits in trunk/WebKitTools

2010-12-06 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix GtkLauncher.c style, use webkit style
https://bugs.webkit.org/show_bug.cgi?id=50542

  • GtkLauncher/main.c: (activateUriEntryCb): (updateTitle): (linkHoverCb): (notifyTitleCb): (notifyLoadStatusCb): (notifyProgressCb): (destroyCb): (goBackCb): (goForwardCb): (create_webViewCb): (webViewReadyCb): (closeWebViewCb): (createBrowser): (createStatusbar): (createToolbar): (createWindow): (main):
7:40 AM Changeset in webkit [73366] by yurys@chromium.org
  • 11 edits in trunk/WebCore

2010-12-06 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: remove duplicate code for capturing stack trace
https://bugs.webkit.org/show_bug.cgi?id=50461

No new tests. Covered with existing inspector tests.

  • bindings/js/ScriptCallStackFactory.cpp: (WebCore::createScriptCallStack):
  • bindings/js/ScriptCallStackFactory.h:
  • bindings/v8/ScriptCallStackFactory.cpp: (WebCore::toScriptCallFrame): (WebCore::toScriptCallFramesVector): (WebCore::createScriptCallStack):
  • bindings/v8/ScriptCallStackFactory.h:
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler):
  • inspector/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::isEqual): (WebCore::ScriptCallFrame::buildInspectorObject):
  • inspector/ScriptCallFrame.h: (WebCore::ScriptCallFrame::sourceURL):
  • inspector/ScriptCallStack.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
7:06 AM Changeset in webkit [73365] by Csaba Osztrogonác
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected result for test introduced in r73257.

  • platform/qt/media/controls-without-preload-expected.checksum: Added.
  • platform/qt/media/controls-without-preload-expected.png: Added.
  • platform/qt/media/controls-without-preload-expected.txt: Added.
7:04 AM Changeset in webkit [73364] by yurys@chromium.org
  • 2 edits in branches/chromium/597/WebCore/inspector/front-end

Merge 73229 - 2010-12-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix heap snapshots loading. Loading is now
conducted by the Profiles panel which prevents accidental
simultaneous attempts to load the same profile several times in
parallel.

https://bugs.webkit.org/show_bug.cgi?id=50427

  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._loadProfile): (WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot):

TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/5657001

6:52 AM Changeset in webkit [73363] by Csaba Osztrogonác
  • 2 edits
    2 copies in trunk

Unreviewed.

WebCore: == Rolled over to ChangeLog-2010-12-06 ==
LayoutTests: == Rolled over to ChangeLog-2010-12-06 ==

6:47 AM Changeset in webkit [73362] by yael.aharon@nokia.com
  • 3 edits
    21 adds in trunk

[Qt] Support focus ring outline color for links.
https://bugs.webkit.org/show_bug.cgi?id=50428

Reviewed by Andreas Kling.

WebCore:

Take width and offset into account when drawing focus ring.

Tests: fast/css/focus-ring-outline-color.html

fast/css/focus-ring-outline-offset.html
fast/css/focus-ring-outline-width.html

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawFocusRing):

LayoutTests:

  • fast/css/focus-ring-outline-color.html: Added.
  • fast/css/focus-ring-outline-offset.html: Added.
  • fast/css/focus-ring-outline-width.html: Added.
  • platform/mac/fast/css/focus-ring-outline-color-expected.checksum: Added.
  • platform/mac/fast/css/focus-ring-outline-color-expected.png: Added.
  • platform/mac/fast/css/focus-ring-outline-color-expected.txt: Added.
  • platform/mac/fast/css/focus-ring-outline-offset-expected.checksum: Added.
  • platform/mac/fast/css/focus-ring-outline-offset-expected.png: Added.
  • platform/mac/fast/css/focus-ring-outline-offset-expected.txt: Added.
  • platform/mac/fast/css/focus-ring-outline-width-expected.checksum: Added.
  • platform/mac/fast/css/focus-ring-outline-width-expected.png: Added.
  • platform/mac/fast/css/focus-ring-outline-width-expected.txt: Added.
  • platform/qt/fast/css/focus-ring-outline-color-expected.checksum: Added.
  • platform/qt/fast/css/focus-ring-outline-color-expected.png: Added.
  • platform/qt/fast/css/focus-ring-outline-color-expected.txt: Added.
  • platform/qt/fast/css/focus-ring-outline-offset-expected.checksum: Added.
  • platform/qt/fast/css/focus-ring-outline-offset-expected.png: Added.
  • platform/qt/fast/css/focus-ring-outline-offset-expected.txt: Added.
  • platform/qt/fast/css/focus-ring-outline-width-expected.checksum: Added.
  • platform/qt/fast/css/focus-ring-outline-width-expected.png: Added.
  • platform/qt/fast/css/focus-ring-outline-width-expected.txt: Added.
6:33 AM Changeset in webkit [73361] by yael.aharon@nokia.com
  • 8 edits
    9 adds in trunk

[Qt] Fix focus ring outline color support
https://bugs.webkit.org/show_bug.cgi?id=50325

Reviewed by Andreas Kling.

WebCore:

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawFocusRing):

Take the outline width into account when drawing the focus ring of image map.
Change the outline-style from dotted to solid. The default outline-width is
5 pixels, and dotted lines just don't make sense anymore.
Give the focus ring alpha of 50%, following what other ports do.
Save and restore the pen when drawing a focus ring.

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/fast/images/imagemap-focus-ring-expected.checksum:
  • platform/qt/fast/images/imagemap-focus-ring-expected.png:
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.checksum: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.checksum: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.checksum:
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png:
5:45 AM Changeset in webkit [73360] by yael.aharon@nokia.com
  • 3 edits in trunk/LayoutTests

Unreviewed.

Added a proper mime-type to images.

  • platform/qt/fast/images/imagemap-focus-ring-expected.png: Added property svn:mime-type.
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png: Added property svn:mime-type.
5:21 AM Changeset in webkit [73359] by Csaba Osztrogonác
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for tests introduced in r73296.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Added.
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
5:19 AM Changeset in webkit [73358] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2010-12-06 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][V8] Build fix after r73283.

No new tests needed.

  • WebCore.pri: Add missing webaudio directory to IDL generator includes.
4:31 AM Changeset in webkit [73357] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-12-06 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[soup] implement ResourceHandle::platformSetDefersLoading
https://bugs.webkit.org/show_bug.cgi?id=44158

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::platformSetDefersLoading): Implemented using the soup_session_{,un}pause_message APIs.
4:24 AM Changeset in webkit [73356] by sergio@webkit.org
  • 2 edits in trunk/WebCore

2010-12-06 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Leak in webkit_soup_cache_load if file contents load fails
https://bugs.webkit.org/show_bug.cgi?id=50558

g_file_get_contents() could return an error after allocating a
buffer for file contents. We must free that memory before
returning.

  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_load): Added a missing g_free().
3:59 AM Changeset in webkit [73355] by yurys@chromium.org
  • 11 edits in trunk/WebCore

2010-12-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r73351.
http://trac.webkit.org/changeset/73351
https://bugs.webkit.org/show_bug.cgi?id=50560

"The change broke plugin tests in Chromium" (Requested by
yurys on #webkit).

  • bindings/js/ScriptCallStackFactory.cpp: (WebCore::ScriptCallStack::stackTrace):
  • bindings/js/ScriptCallStackFactory.h:
  • bindings/v8/ScriptCallStackFactory.cpp: (WebCore::toScriptCallFrame): (WebCore::toScriptCallFramesVector): (WebCore::createScriptCallStack): (WebCore::ScriptCallStack::stackTrace):
  • bindings/v8/ScriptCallStackFactory.h:
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler):
  • inspector/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::isEqual): (WebCore::ScriptCallFrame::buildInspectorObject):
  • inspector/ScriptCallFrame.h: (WebCore::ScriptCallFrame::sourceURL):
  • inspector/ScriptCallStack.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
3:23 AM Changeset in webkit [73354] by mrobinson@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-12-06 Derek Weitzel <djw8605@gmail.com>

Reviewed by Martin Robinson.

[GTK] API Documentation referencing depreciated GTK_WIDGET_TOPLEVEL
https://bugs.webkit.org/show_bug.cgi?id=50512

Fixed reference to depreciated GTK_WIDGET_TOPLEVEL.

  • webkit/webkitwebview.cpp:
3:18 AM Changeset in webkit [73353] by mrobinson@webkit.org
  • 5 edits in trunk/WebKit/gtk

2010-12-06 Joone Hur <joone@kldp.org>

Reviewed by Xan Lopez.

[GTK] The webkit cache model needs to be set when WebFrameLoaderClient::didPerformFirstNavigation() is called
https://bugs.webkit.org/show_bug.cgi?id=50430

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didPerformFirstNavigation): Set the webview cache model.
  • webkit/webkitprivate.cpp: (webkit_init): Removed the code of setting the webview cache model.
2:55 AM QtWebKitFeaturePlanning edited by Henry Haverinen
(diff)
2:24 AM Changeset in webkit [73352] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

[Qt] Report zero width for zero size fonts

Patch by Robert Hogan <robert@webkit.org> on 2010-12-06
Reviewed by Kenneth Rohde Christiansen.

Report zero width when font size is zero.

Fixes fast/text/font-size-zero.html

https://bugs.webkit.org/show_bug.cgi?id=50539

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::floatWidthForComplexText):

2:13 AM Changeset in webkit [73351] by yurys@chromium.org
  • 11 edits in trunk/WebCore

2010-12-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: remove duplicate code for capturing stack trace
https://bugs.webkit.org/show_bug.cgi?id=50461

No new tests. Covered with existing inspector tests.

  • bindings/js/ScriptCallStackFactory.cpp: (WebCore::createScriptCallStack):
  • bindings/js/ScriptCallStackFactory.h:
  • bindings/v8/ScriptCallStackFactory.cpp: (WebCore::toScriptCallFrame): (WebCore::toScriptCallFramesVector): (WebCore::createScriptCallStack):
  • bindings/v8/ScriptCallStackFactory.h:
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler):
  • inspector/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::isEqual): (WebCore::ScriptCallFrame::buildInspectorObject):
  • inspector/ScriptCallFrame.h: (WebCore::ScriptCallFrame::sourceURL):
  • inspector/ScriptCallStack.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
2:03 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
(diff)
2:01 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
(diff)
1:50 AM BuildingQtOnSymbian edited by jocelyn.turcotte@nokia.com
QtLauncher --> QtTestBrowser (diff)
1:49 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
QtLauncher --> QtTestBrowser (diff)
1:42 AM Changeset in webkit [73350] by sergio@webkit.org
  • 2 edits in trunk/WebCore

2010-12-06 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] webkit_soup_cache_clear() does not delete all entries in the cache
https://bugs.webkit.org/show_bug.cgi?id=50462

Do not use g_hash_table_foreach to remove entries from the cache
entries hashtable. Iterate over a list of entries to remove them
from the hash table.

  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/soup/cache/webkit/soup-cache.c: (remove_cache_item): (webkit_soup_cache_finalize): (clear_cache_item): (webkit_soup_cache_clear):

Dec 5, 2010:

9:15 PM Changeset in webkit [73349] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-12-05 Kent Tamura <tkent@chromium.org>

Unreviewed. Run sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
5:21 PM Changeset in webkit [73348] by tonikitoo@webkit.org
  • 9 edits in trunk

2010-12-04 Antonio Gomes <agomes@rim.com>

Reviewed by Martin Robinson.

[Gtk] Populate DumpRenderTreeSupportGtk (Part II)
https://bugs.webkit.org/show_bug.cgi?id=48429

Moved more private method declared with WEBKIT_API to
DumpRenderTreeSupportGtk, since they were only being used by DRT.

WebKit:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::executeCoreCommandByName): (DumpRenderTreeSupportGtk::isCommandEnabled): (DumpRenderTreeSupportGtk::whiteListAccessFromOrigin): (DumpRenderTreeSupportGtk::resetOriginAccessWhiteLists):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • webkit/webkitprivate.cpp:
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:

WebKitTools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::addOriginAccessWhitelistEntry): (LayoutTestController::execCommand): (LayoutTestController::isCommandEnabled):
5:21 PM Changeset in webkit [73347] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

2010-12-04 Antonio Gomes <agomes@rim.com>

Reviewed by Andreas Kling.

Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp

Method was removed by http://trac.webkit.org/changeset/71604

  • DumpRenderTree/gtk/DumpRenderTree.cpp:
5:14 PM Changeset in webkit [73346] by luiz@webkit.org
  • 17 edits
    9 adds in trunk/WebCore

2010-11-30 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Darin Adler.

HTML5 <details> and <summary> initial implementation
https://bugs.webkit.org/show_bug.cgi?id=50309

HTML5 <details> and <summary> elements initial implementation. The main objective is
to add the files for html element and renderers, and to get rid of build system issues
in future patches.

See: http://www.w3.org/TR/html5/interactive-elements.html#the-details-element

http://www.w3.org/TR/html5/interactive-elements.html#the-summary-element

build systems

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:

Some css properties to the new html elements.

  • css/html.css: (details): (summary):

New html element associated with the corresponding tag.

  • html/HTMLAttributeNames.in:
  • html/HTMLTagNames.in:

1 html element and 3 renderers were added.

  • html/HTMLDetailsElement.cpp: Added.
  • html/HTMLDetailsElement.h: Added.
  • html/HTMLDetailsElement.idl: Added.
  • html/HTMLElementsAllInOne.cpp:
  • rendering/RenderDetails.cpp: Added.
  • rendering/RenderDetails.h: Added.
  • rendering/RenderDetailsMarker.cpp: Added.
  • rendering/RenderDetailsMarker.h: Added.
  • rendering/RenderSummary.cpp: Added.
  • rendering/RenderSummary.h: Added.
  • rendering/RenderingAllInOne.cpp:

New renderer type checkers.

  • rendering/RenderObject.h: (WebCore::RenderObject::isDetails): (WebCore::RenderObject::isDetailsMarker): (WebCore::RenderObject::isSummary):
12:13 PM Changeset in webkit [73345] by rwlbuis@webkit.org
  • 6 edits in trunk

2010-12-05 Rob Buis <rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

createSVGTransformFromMatrix(undefined) => NULL ptr
https://bugs.webkit.org/show_bug.cgi?id=49564

Throw TYPE_MISMATCH_ERR when using undefined or null as value for matrix parameter.

  • svg/SVGTransformList.idl:
  • svg/properties/SVGTransformListPropertyTearOff.h: (WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
11:21 AM Changeset in webkit [73344] by alex
  • 5 edits in trunk

2010-12-05 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix compilation warnings reported by clang
https://bugs.webkit.org/show_bug.cgi?id=50252

  • platform/graphics/Path.h: CairoPath is now a class, not a struct.
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback): Cast the status_code to int.

2010-12-05 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix compilation warnings reported by clang
https://bugs.webkit.org/show_bug.cgi?id=50252

  • GtkLauncher/main.c: (create_window): The create_statusbar function does not have parameters.
10:43 AM Changeset in webkit [73343] by alex
  • 2 edits in trunk/WebCore

2010-12-05 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove setColor functions it was replicated in
CairoUtilities: setSourceRGBAFromColor.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke): (WebCore::fillRectSourceOver): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::fillRoundedRect):
10:28 AM Changeset in webkit [73342] by Adam Roben
  • 8 edits in trunk

Windows production build fix

Put spaces after trailing backslashes when setting
%WebKitVSPropsRedirectionDir%. According to MSDN
<http://msdn.microsoft.com/en-us/library/2kzfk8c7(v=VS.80).aspx>:

A backslash ( \ ) followed by a newline character is interpreted as
a space in the command; use a backslash at the end of a line to
continue a command onto the next line. NMAKE interprets the
backslash literally if any other character, including a space or
tab, follows the backslash.

JavaScriptCore:

WebCore:

  • WebCore.vcproj/WebCore.make:

WebKit/win:

  • WebKit.vcproj/WebKit.make:

WebKit2:

  • win/WebKit2.make:
7:10 AM Changeset in webkit [73341] by robert@webkit.org
  • 8 edits in trunk

2010-12-05 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Zero-sized font does not yet work

Fix fast/text/font-size-zero.html

https://bugs.webkit.org/show_bug.cgi?id=49759

  • platform/qt/Skipped:

2010-12-05 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Zero-sized font does not yet work

Fix fast/text/font-size-zero.html

Copy other ports by setting minimumFontSize to 0 for DRT runs,
copy a fix to SimpleFontData from chromium/safari, and set font
size in FontPlatformData to zero if size zero is requested
and QFont::pixelSize otherwise. (Note that QFont doesn't accept
a pixel size of zero).

Also fix QFont::setPixelSize in FontPlatformData to use
description.computedPixelSize rather than computedSize and
pixelSize() rather than pointSizeF - since the latter gets
set to -1 if pixelSize is set at all.

https://bugs.webkit.org/show_bug.cgi?id=49759

  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate): (WebCore::FontPlatformData::pixelSize):
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformGlyphInit): (WebCore::SimpleFontData::platformCharWidthInit):

2010-12-05 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Zero-sized font does not yet work

Fix fast/text/font-size-zero.html

Copy other ports by setting minimumFontSize to 0 for DRT runs.

https://bugs.webkit.org/show_bug.cgi?id=49759

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage):
Note: See TracTimeline for information about the timeline view.