Timeline



Jan 14, 2011:

10:48 PM Changeset in webkit [75873] by Simon Fraser
  • 5 edits in trunk/WebKit/mac

2011-01-14 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Plugins render incorrectly with transformed ancestors
https://bugs.webkit.org/show_bug.cgi?id=52507

-[NSView visibleRect] gives the wrong answer if there are CSS transforms
in the ancestor chain of a plugin.

So use of this method with calls to -actualVisibleRectInWindow, which
maps rects through the render tree to compute the correct rect,
clipping via windowClipRect() if necessary.

Not testable, because doing so relies on the behavior of some
plugins, which stop rendering if setWindow passes an empty rect.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
10:35 PM Changeset in webkit [75872] by oliver@apple.com
  • 5 edits in trunk

2011-01-14 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

[jsfunfuzz] Incorrect handling of consecutive duplicate labels
https://bugs.webkit.org/show_bug.cgi?id=52505

Add a few tests of consecutive labels containing duplicates to the parser check.

  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/script-tests/parser-syntax-check.js:

2011-01-14 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

[jsfunfuzz] Incorrect handling of consecutive duplicate labels
https://bugs.webkit.org/show_bug.cgi?id=52505

Compare StringImpl*'s instead of Identifier*'s when looking for duplicate
labels.

  • parser/JSParser.cpp: (JSC::JSParser::parseExpressionOrLabelStatement):
10:01 PM Changeset in webkit [75871] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2011-01-14 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Darin Fisher.

Prepare Linux WebThemeEngine interface to support new theme parts.
https://bugs.webkit.org/show_bug.cgi?id=52413

  • public/linux/WebThemeEngine.h:
9:38 PM Changeset in webkit [75870] by commit-queue@webkit.org
  • 12 edits in trunk

2011-01-14 Sam Magnuson <smagnuso@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compile with QT_NO_GRAPHICSVIEW
https://bugs.webkit.org/show_bug.cgi?id=49750

  • platform/graphics/qt/GraphicsLayerQt.cpp:
  • platform/graphics/qt/GraphicsLayerQt.h:
  • platform/qt/PlatformMouseEventQt.cpp:

2011-01-14 Sam Magnuson <smagnuso@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compile with QT_NO_GRAPHICSVIEW
https://bugs.webkit.org/show_bug.cgi?id=49750

  • Api/qgraphicswebview.cpp:
  • Api/qgraphicswebview.h:
  • Api/qwebpage.cpp: (QWebPage::event):
  • Api/qwebpage_p.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
  • WebCoreSupport/PageClientQt.cpp:
  • WebCoreSupport/PageClientQt.h:
8:20 PM Changeset in webkit [75869] by dimich@chromium.org
  • 5 edits
    1 delete in trunk/LayoutTests

Not reviewed, update of Chromium test expectations.
Update of files affected by mass rebaseline in r75828 and r75838

  • platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.checksum:
  • platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png:
  • platform/chromium-mac/plugins/embed-attributes-style-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
  • platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:
7:53 PM Changeset in webkit [75868] by Simon Fraser
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

2011-01-14 Simon Fraser <Simon Fraser>

No review.

Initialize m_operationInProgress after r75855.

  • runtime/Heap.cpp: (JSC::Heap::Heap):
7:32 PM Changeset in webkit [75867] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Reverted accidentally committed code from my last checkin.

  • runtime/Heap.cpp:

(JSC::Heap::markRoots):

7:28 PM Changeset in webkit [75866] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the GTK bot.

Reviewed by Sam Weinig.

  • runtime/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markRoots): Kids, remember to initialize your data members.
Knowing is half the battle.

6:33 PM Changeset in webkit [75865] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, update of test expectations.
Ignore new test fast/js/js-continue-break-restrictions.html, it fails for V8.

  • platform/chromium/test_expectations.txt:
6:26 PM Changeset in webkit [75864] by ericu@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

2011-01-14 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Add tests for FileWriterSync
https://bugs.webkit.org/show_bug.cgi?id=50720

  • fast/filesystem/resources/file-writer-sync-truncate-extend.js: Added.
  • fast/filesystem/workers/file-writer-sync-truncate-extend.html: Added.
  • fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Added.
  • fast/filesystem/resources/file-writer-sync-write-overlapped.js: Added.
  • fast/filesystem/workers/file-writer-sync-write-overlapped.html: Added.
  • fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Added.
  • fast/filesystem/resources/file-writer-utils.js: (assert): Make assert throw, rather than continue. (cleanUp): Always call finishJSTest, even without fileEntryForCleanup.
6:22 PM Changeset in webkit [75863] by Patrick Gansterer
  • 3 edits in trunk/WebKit/efl

2011-01-14 Patrick Gansterer <Patrick Gansterer>

Unreviewed. Try to fix EFL build.

  • ewk/ewk_frame.cpp: (ewk_frame_scroll_add): Added WebCore namespace to IntSize.
  • ewk/ewk_view.cpp: (_ewk_view_viewport_attributes_compute): Ditto.
6:14 PM Changeset in webkit [75862] by oliver@apple.com
  • 5 edits in trunk

2011-01-14 Oliver Hunt <oliver@apple.com>

Reviewed by Stephanie Lewis.

[jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
https://bugs.webkit.org/show_bug.cgi?id=52501

Add checks for correct behaviour when the strict mode token is immediately followed
by a value that needs a temporary buffer in the lexer.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:

2011-01-14 Oliver Hunt <oliver@apple.com>

Reviewed by Stephanie Lewis.

[jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
https://bugs.webkit.org/show_bug.cgi?id=52501

Clear the temporary character buffers used for reading escaped characters and
numbers.

  • parser/Lexer.h: (JSC::Lexer::setOffset):
6:06 PM Changeset in webkit [75861] by tony@chromium.org
  • 4 edits
    2 adds in trunk

2011-01-14 Tony Chang <tony@chromium.org>

Reviewed by Alexey Proskuryakov.

Strip NUL character when copying text on Windows
https://bugs.webkit.org/show_bug.cgi?id=52236

  • editing/pasteboard/copy-null-characters-expected.txt: Added.
  • editing/pasteboard/copy-null-characters.html: Added.

2011-01-14 Tony Chang <tony@chromium.org>

Reviewed by Alexey Proskuryakov.

Strip NUL character when copying text on Windows
https://bugs.webkit.org/show_bug.cgi?id=52236

Test: editing/pasteboard/copy-null-characters.html

  • editing/Editor.cpp: (WebCore::Editor::selectedText):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): Use editor()->selectedText() which matches the other platforms.
6:00 PM Changeset in webkit [75860] by mrowe@apple.com
  • 4 edits in tags/Safari-534.15.8/WebCore

Merge r75758.

6:00 PM Changeset in webkit [75859] by mrowe@apple.com
  • 3 edits in tags/Safari-534.15.8/WebKit/mac

Merge r75829.

6:00 PM Changeset in webkit [75858] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.8

Versioning.

5:59 PM Changeset in webkit [75857] by yuzo@google.com
  • 32 edits in trunk

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

No new tests because the behavior remains the same.

  • WebCore.exp.in:
  • WebCore.order:
  • history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::cachedResource):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create):
  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::allClientsRemoved): (WebCore::CachedImage::data):
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::addClientToSet): (WebCore::CachedResource::removeClient): (WebCore::CachedResource::setDecodedSize): (WebCore::CachedResource::setEncodedSize): (WebCore::CachedResource::didAccessDecodedData):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::CachedResourceLoader): (WebCore::CachedResourceLoader::requestUserCSSStyleSheet): (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::revalidateResource): (WebCore::CachedResourceLoader::loadResource): (WebCore::CachedResourceLoader::clearPreloads): (WebCore::CachedResourceLoader::printPreloadStats):
  • loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::load): (WebCore::CachedResourceRequest::didFail): (WebCore::CachedResourceRequest::didReceiveResponse):
  • loader/cache/MemoryCache.cpp: (WebCore::memoryCache):
  • loader/cache/MemoryCache.h:

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • src/WebCache.cpp: (WebKit::WebCache::setCapacities): (WebKit::WebCache::clear): (WebKit::WebCache::getUsageStats): (WebKit::WebCache::getResourceTypeStats):

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • webkit/webkitglobals.cpp: (webkit_set_cache_model):

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • Misc/WebCache.mm: (+[WebCache statistics]): (+[WebCache setDisabled:]): (+[WebCache isDisabled]):
  • WebView/WebView.mm: (+[WebView _setCacheModel:]):

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • Api/qwebpage.cpp: (QWebPagePrivate::_q_cleanupLeakMessages):
  • Api/qwebsettings.cpp: (QWebSettings::clearMemoryCaches): (QWebSettings::setObjectCacheCapacities):

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • WebCache.cpp: (WebCache::statistics): (WebCache::empty): (WebCache::setDisabled): (WebCache::disabled):
  • WebView.cpp: (WebView::setCacheModel):

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • WebView.cpp: (wxWebView::SetCachePolicy):

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::shutdownIfPossible): (WebKit::WebProcess::didClose):
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformSetCacheModel):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformSetCacheModel):
5:52 PM Changeset in webkit [75856] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix non-Dtrace builds: #include Tracing.h instead of TracingDtrace.h.

  • runtime/Heap.cpp:
5:43 PM Changeset in webkit [75855] by ggaren@apple.com
  • 18 edits
    2 copies in trunk

2011-01-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Split out a MarkedSpace strategy object from Heap.
https://bugs.webkit.org/show_bug.cgi?id=52421

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics memoryStatistics]): Updated for class move.

2011-01-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Split out a MarkedSpace strategy object from Heap.
https://bugs.webkit.org/show_bug.cgi?id=52421


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::recordExtraCost): (JSC::Heap::allocate): (JSC::Heap::markConservatively): (JSC::Heap::markRoots): (JSC::Heap::objectCount): (JSC::Heap::statistics): (JSC::Heap::size): (JSC::Heap::isBusy): (JSC::Heap::collectAllGarbage): (JSC::Heap::primaryHeapBegin): (JSC::Heap::primaryHeapEnd):
  • runtime/Heap.h: (JSC::Heap::globalData): (JSC::Heap::markedSpace): (JSC::Heap::isCellMarked): (JSC::Heap::checkMarkCell): (JSC::Heap::markCell): Moved all code pertaining to managing chunks of collector memory out of this class. Heap now just delegates to MarkedSpace.
  • runtime/JSCell.h: (JSC::JSCell::Heap::heap): Updated for MarkedSpace delegation.
  • runtime/JSValue.h: Moved the ValueStringPair typedef to help with #includes.
  • runtime/MarkedSpace.cpp: Copied from runtime/Heap.cpp. (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::resizeBlocks): (JSC::MarkedSpace::growBlocks): (JSC::MarkedSpace::shrinkBlocks): (JSC::MarkedSpace::markConservatively): (JSC::MarkedSpace::clearMarkBits): (JSC::MarkedSpace::markedCells): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::objectCount): (JSC::MarkedSpace::addToStatistics): (JSC::MarkedSpace::statistics): (JSC::MarkedSpace::size): (JSC::MarkedSpace::reset): (JSC::MarkedSpace::primaryHeapBegin): (JSC::MarkedSpace::primaryHeapEnd):
  • runtime/MarkedSpace.h: Copied from runtime/Heap.h. (JSC::MarkedSpace::globalData): (JSC::MarkedSpace::didShrink): (JSC::MarkedSpace::cellBlock): (JSC::MarkedSpace::cellOffset): (JSC::MarkedSpace::isCellMarked): (JSC::MarkedSpace::checkMarkCell): (JSC::MarkedSpace::markCell): Moved all code pertaining to managing chunks of collector memory into this class.
  • runtime/MemoryStatistics.cpp: (JSC::heapStatistics):
  • runtime/MemoryStatistics.h: Updated for MarkedSpace delegation.

2011-01-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Split out a MarkedSpace strategy object from Heap.
https://bugs.webkit.org/show_bug.cgi?id=52421

  • Shared/mac/WebMemorySampler.mac.mm: (WebKit::WebMemorySampler::sampleWebKit): Updated for class move.
5:40 PM Changeset in webkit [75854] by thakis@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-14 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Rebaseline gradient test due to updated skia. reed checked the test and
says the new look is right and is an intentional change.
https://bugs.webkit.org/show_bug.cgi?id=52105

  • platform/chromium-linux/svg/batik/paints/gradientLimit-expected.checksum:
  • platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.checksum:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
5:31 PM Changeset in webkit [75853] by andersca@apple.com
  • 10 edits in trunk/WebKit2

2011-01-14 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add a new PageClient::displayView function and expose it on WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=52500

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::displayView):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::displayView):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::displayView):
  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::displayView):
  • UIProcess/win/WebView.h:
5:22 PM Changeset in webkit [75852] by oliver@apple.com
  • 5 edits
    3 adds in trunk

2011-01-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] parser doesn't enforce continue restrictions correctly.
https://bugs.webkit.org/show_bug.cgi?id=52493

Add a few tests for continue to cover the cases where continue
isn't syntactically valid.

  • fast/js/js-continue-break-restrictions-expected.txt: Added.
  • fast/js/js-continue-break-restrictions.html: Added.
  • fast/js/script-tests/js-continue-break-restrictions.js: Added.

2011-01-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] parser doesn't enforce continue restrictions correctly.
https://bugs.webkit.org/show_bug.cgi?id=52493

This patch reworks handling of break, continue and label statements
to correctly handle all the valid and invalid cases. Previously certain
errors would be missed by the parser in strict mode, but the bytecode
generator needed to handle those cases for non-strict code so nothing
failed, it simply became non-standard behaviour.

Now that we treat break and continue errors as early faults in non-strict
mode as well that safety net has been removed so the parser bugs result in
crashes at codegen time.

  • parser/JSParser.cpp: (JSC::JSParser::ScopeLabelInfo::ScopeLabelInfo): (JSC::JSParser::next): (JSC::JSParser::nextTokenIsColon): (JSC::JSParser::continueIsValid):

Continue is only valid in loops so we can't use breakIsValid()

(JSC::JSParser::pushLabel):

We now track whether the label is for a loop (and is therefore a
valid target for continue.

(JSC::JSParser::popLabel):
(JSC::JSParser::getLabel):

Replace hasLabel with getLabel so that we can validate the target
when parsing continue statements.

(JSC::JSParser::Scope::continueIsValid):
(JSC::JSParser::Scope::pushLabel):
(JSC::JSParser::Scope::getLabel):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseBreakStatement):
(JSC::JSParser::parseContinueStatement):
(JSC::LabelInfo::LabelInfo):
(JSC::JSParser::parseExpressionOrLabelStatement):

Consecutive labels now get handled iteratively so that we can determine
whether they're valid targets for continue.

  • parser/Lexer.cpp: (JSC::Lexer::nextTokenIsColon):
  • parser/Lexer.h: (JSC::Lexer::setOffset):
5:20 PM Changeset in webkit [75851] by mitz@apple.com
  • 5 edits
    1 add in trunk

Source/WebCore: WebCore part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]

Reviewed by Simon Fraser.

  • WebCore.exp.in: Export RenderWidget::suspendWidgetHierarchyUpdates() and

RenderWidget::resumeWidgetHierarchyUpdates().

  • manual-tests/plug-in-mutates-NSView-hierarchy-during-resize.html: Added.
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry): Removed the assertion that widget hierarchy updates
are disabled. When this assertion was added, this condition was a subset of the “calling out to
plug-in code is forbidden” condition, hence the assertion was valid. The WebKit part of this
change now suspends widget hierarchy updates even at times where plug-in code is expected to be
called, which invalidates the assertion.

WebKit/mac: WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]

Reviewed by Simon Fraser.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
that the NSView tree doesn’t change from under AppKit as it traverses it.

5:19 PM Changeset in webkit [75850] by commit-queue@webkit.org
  • 2 edits in trunk

2011-01-14 Ahmad Sharif <asharif.tools@gmail.com>

Reviewed by Darin Fisher.

When inlining is performed, the progress variable is
declared as uninitialized.
https://bugs.webkit.org/show_bug.cgi?id=51084

  • WebCore: Copied from WebCore.
  • WebCore/page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate): (WebCore::KeyframeAnimation::getAnimatedStyle):
5:18 PM Changeset in webkit [75849] by andersca@apple.com
  • 2 edits in trunk/WebKit2

2011-01-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement the "should paint bounds instead of indiviual rects" algorithm from WebKit1
https://bugs.webkit.org/show_bug.cgi?id=52499

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::shouldPaintBoundsRect): Port code from -[WebView _mustDrawUnionedRect:singleRects:count:].

(WebKit::DrawingAreaImpl::display):
If shouldPaintBoundsRect returns true, clear the rects vector and append the bounds rect.

5:17 PM Changeset in webkit [75848] by tonyg@chromium.org
  • 4 edits in trunk

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • rendering/style/StyleRareInheritedData.cpp:
  • rendering/style/StyleRareNonInheritedData.cpp:
5:15 PM Changeset in webkit [75847] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix expanded lines in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52498

Fixes them to work now that we have wrapper divs.
Also fixes the long-standing bug that the line numbers
were incorrect sometimes.

  • code-review.js:
5:08 PM Changeset in webkit [75846] by tonyg@chromium.org
  • 4 edits in trunk

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • rendering/style/RenderStyle.cpp:

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • ewk/ewk_view.cpp:
5:02 PM Changeset in webkit [75845] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

put remove lines to the left of add lines in sidebyside view
https://bugs.webkit.org/show_bug.cgi?id=52458

Also, sneaking in a fix to make long lines with no whitespace wrap.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
5:00 PM Changeset in webkit [75844] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • editing/EditorCommand.cpp:
4:55 PM Changeset in webkit [75843] by tonyg@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • editing/ApplyStyleCommand.cpp:
4:44 PM Changeset in webkit [75842] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • css/CSSStyleSelector.cpp:
4:42 PM Changeset in webkit [75841] by mjs@apple.com
  • 3 edits in trunk/LayoutTests

2011-01-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Fix a few things in the WebKit2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=52484

  • platform/mac-wk2/Skipped: Add/remove some tests to the WK2 skipped list.
  • editing/style/stylewithcss-without-selection.html: Fix this test to avoid referencing an undefined variable in the failure case.
4:35 PM Changeset in webkit [75840] by tonyg@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • rendering/InlineFlowBox.h:
  • rendering/RenderBoxModelObject.h:
4:29 PM Changeset in webkit [75839] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-14 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
https://bugs.webkit.org/show_bug.cgi?id=45186

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::scheduleScavenger): Added missing this pointer to CreateTimerQueueTimer().
4:28 PM Changeset in webkit [75838] by mihaip@chromium.org
  • 231 edits
    230 copies
    16 adds in trunk/LayoutTests

2011-01-14 Mihai Parparita <mihaip@chromium.org>

Update the svg/ pixel expectations for the chromium-mac port.

For the pixel tests that currently fail on Snow Leopard, this moves the
current pixel results to platform/chromium-mac-leopard and adds new
results to platform/chromium-mac.

List of files omitted due to length but composed entirely of moves from
platform/chromium-mac to platform/chromium-mac-leopard and newly added
files in platform/chromium-mac.

4:27 PM Changeset in webkit [75837] by tonyg@chromium.org
  • 56 edits in trunk

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Do some forward declaration in RenderStyle.h
https://bugs.webkit.org/show_bug.cgi?id=52453

No new tests because no new functionality.

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSStyleSelector.cpp:
  • editing/Editor.cpp:
  • page/EventHandler.cpp:
  • rendering/EllipsisBox.cpp:
  • rendering/InlineBox.cpp:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderEmbeddedObject.cpp:
  • rendering/RenderFieldset.cpp:
  • rendering/RenderFileUploadControl.cpp:
  • rendering/RenderFrameSet.cpp:
  • rendering/RenderHTMLCanvas.cpp:
  • rendering/RenderImageResource.cpp:
  • rendering/RenderInputSpeech.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderLineBoxList.cpp:
  • rendering/RenderListBox.cpp:
  • rendering/RenderMediaControlsChromium.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderObjectChildList.cpp:
  • rendering/RenderProgress.cpp:
  • rendering/RenderScrollbarPart.cpp:
  • rendering/RenderTable.cpp:
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableRow.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/RenderTheme.cpp:
  • rendering/RenderThemeChromiumSkia.cpp:
  • rendering/RenderThemeChromiumWin.cpp:
  • rendering/RootInlineBox.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:
4:19 PM Changeset in webkit [75836] by jochen@chromium.org
  • 2 edits in trunk/WebKit/chromium

2011-01-14 Jochen Eisinger <jochen@chromium.org>

Unreviewed, roll chromium deps to r71432.

  • DEPS:
4:16 PM Changeset in webkit [75835] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-01-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in AccessibilityRenderObject.cpp, Element.cpp,
BreakBlockquoteCommand.cpp, CompositeEditCommand.cpp, and DeleteButtonController.cpp
https://bugs.webkit.org/show_bug.cgi?id=52481

Removed instantiation of legacy editing positions.
Calls to Position::Position are replaced by calls to Position's convenience functions.


Also fixed firstPositionInOrBeforeNode and lastPositionInOrAfterNode so that
they instantiate right positions for text nodes.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::setSelectedTextRange):
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::inputText): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): (WebCore::CompositeEditCommand::splitTreeToNode):
  • editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):
  • editing/htmlediting.h: (WebCore::firstPositionInOrBeforeNode): Instantiates firstPositionInNode instead of positionBeforeNode for a text node. (WebCore::lastPositionInOrAfterNode): Ditto.
4:10 PM Changeset in webkit [75834] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.8

New tag.

3:46 PM Changeset in webkit [75833] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

2011-01-14 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadow is not drawn when filling a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=51982

This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::fillPath(const Path& path). We need to draw the
gradient clipped to the path on a CGLayer first, and then draw the
layer on the GraphicsContext.

  • fast/canvas/canvas-fillPath-gradient-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillPath-gradient-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillPath-gradient-shadow.js: Added.
  • platform/chromium/test_expectations.txt: Skipping new test since it fails.
  • platform/qt/Skipped: Ditto.

2011-01-14 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadow is not drawn when filling a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=51982

This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::fillPath(const Path& path). We need to draw the
gradient clipped to the path on a CGLayer first, and then draw the
layer on the GraphicsContext.

Test: fast/canvas/canvas-fillPath-gradient-shadow.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath):
3:45 PM Changeset in webkit [75832] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

2011-01-14 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

Layer syncing should go through the compositor
https://bugs.webkit.org/show_bug.cgi?id=52486

Rather than have FrameView go directly to GraphicsLayer to
sync pending changes, route the call through RenderLayerCompositor.

Add a FIXME about an existing issue with flushing and subframes.

No behavior change, so no tests.

  • page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateForThisFrame):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::notifySyncRequired):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::scheduleLayerFlush): (WebCore::RenderLayerCompositor::flushPendingLayerChanges):
  • rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::notifySyncRequired):
3:37 PM Changeset in webkit [75831] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Fix bad merge in r75816.

  • code-review.js:
3:36 PM Changeset in webkit [75830] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-14 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
https://bugs.webkit.org/show_bug.cgi?id=45186

r75819 accidentally changed the initial state of the scavenge timer.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::initializeScavenger): Changed initial state of m_scavengingSuspended to true.
3:35 PM Changeset in webkit [75829] by Beth Dakin
  • 3 edits in trunk/WebKit/mac

Fix for <rdar://problem/7793902> Artifacts when scrolling
page in Safari while page is loading

Reviewed by Mark Rowe.

Call setDrawsBackground:YES on the scrollView in
dispatchDidFirstLayout() rather than waiting until
frameLoadCompleted(). Also suspend scrolling elasticity
between provisionalLoadStarted() and dispatchDidFirstLayout()

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::WebFrameLoaderClient):
(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::provisionalLoadStarted):

3:04 PM Changeset in webkit [75828] by mihaip@chromium.org
  • 248 edits
    247 copies
    28 adds in trunk/LayoutTests

2011-01-14 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for the chromium-mac port.

For the pixel tests that currently fail on Snow Leopard, this moves the
current pixel results to platform/chromium-mac-leopard and adds new
results to platform/chromium-mac.

List of files omitted due to length but composed entirely of moves from
platform/chromium-mac to platform/chromium-mac-leopard and newly added
files in platform/chromium-mac.

2:57 PM Changeset in webkit [75827] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-14 Patrick Gansterer <Patrick Gansterer>

Unreviewed Windows Release build fix.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::scavengerTimerFired):
2:57 PM Changeset in webkit [75826] by bweinstein@apple.com
  • 6 edits in trunk

ShouldLoadResourceForFrame should use strings, not URLs.
https://bugs.webkit.org/show_bug.cgi?id=52476

Reviewed by Geoff Garen.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::shouldLoadResourceForFrame): Pass resourceURL as a string instead of

a URL, and rename from subresourceURL to resourceURL.

2:49 PM Changeset in webkit [75825] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-14 Patrick Gansterer <Patrick Gansterer>

Unreviewed Windows Release build fix.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::scavengerTimerFired):
2:45 PM Changeset in webkit [75824] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-14 Steve Lacey <sjl@chromium.org>

Reviewed by Simon Fraser.

Update media/video-zoom-controls.html to set the video source before initializing the test.
https://bugs.webkit.org/show_bug.cgi?id=52461

  • media/video-zoom-controls.html:
2:40 PM Changeset in webkit [75823] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-14 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Fix parent block calculation when trying to find top most node
containing "this" float.
https://bugs.webkit.org/show_bug.cgi?id=51711

Replace use of containingBlock and traverse the parents directly
to check for float existence. containingBlock can skip parents and
jump to the RenderView directly which will cause floats to not get
cleared from intermediate parents.

Test: fast/block/float/floats-not-cleared-crash.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

2011-01-14 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash due to uncleared floats in parent nodes.
https://bugs.webkit.org/show_bug.cgi?id=51711

  • fast/block/float/floats-not-cleared-crash-expected.txt: Added.
  • fast/block/float/floats-not-cleared-crash.html: Added.
2:39 PM Changeset in webkit [75822] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Fix for <rdar://problem/8711576> The web process should be able to read resources from the UI process.

Reviewed by Sam Weinig.

Based on a patch by Ivan Krstić. This also makes the NSURLCache path a sandbox parameter.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
Encode and decode the uiProcessBundleResourcePath member variable.

  • Shared/WebProcessCreationParameters.h:

Add uiProcessBundleResourcePath member variable.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
Set the uiProcessBundleResourcePath member variable.

  • WebProcess/com.apple.WebProcess.sb:

Allow read-only access to UI_PROCESS_BUNDLE_RESOURCE_DIR and all subdirectories.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):
When initializing the sandbox, pass UI_PROCESS_BUNDLE_RESOURCE_DIR.

(WebKit::WebProcess::platformInitializeWebProcess):
Remove the code that would consume a sandbox extension for the url cache path.

2:32 PM Changeset in webkit [75821] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION (r75660): compositing/reflections/load-video-in-reflection.html crashes on Windows 7
https://bugs.webkit.org/show_bug.cgi?id=52397

Unskipping tests that no longer fail on Windows 7 Release. Unreviewed.

  • platform/win/Skipped:

Un-skip compositing/reflections/load-video-in-reflection.html, which appears to be fixed by
http://trac.webkit.org/changeset/75807

2:27 PM Changeset in webkit [75820] by ericu@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Add ericu@chromium.org [me] to the committers file.

2:21 PM Changeset in webkit [75819] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-14 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
https://bugs.webkit.org/show_bug.cgi?id=45186

Use CreateTimerQueueTimer() to start periodicScavenge() and stop it with DeleteTimerQueueTimer().

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::initializeScavenger): (WTF::TCMalloc_PageHeap::isScavengerSuspended): (WTF::TCMalloc_PageHeap::scheduleScavenger): (WTF::TCMalloc_PageHeap::rescheduleScavenger): (WTF::TCMalloc_PageHeap::suspendScavenger): (WTF::scavengerTimerFired): (WTF::TCMalloc_PageHeap::periodicScavenge): (WTF::TCMalloc_PageHeap::signalScavenger):
2:15 PM Changeset in webkit [75818] by tonyg@chromium.org
  • 2 edits in trunk/Tools

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Add Tony Gentilcore as a reviewer
https://bugs.webkit.org/show_bug.cgi?id=52480

  • Scripts/webkitpy/common/config/committers.py:
2:13 PM Changeset in webkit [75817] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

improve line selection with fast drags
https://bugs.webkit.org/show_bug.cgi?id=52477

  • code-review.js:
2:08 PM WebKit Team edited by tonyg@chromium.org
(diff)
2:00 PM Changeset in webkit [75816] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

tweak line selection in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52462

-Improve handling of data-comment-base-line code to deal with
lines that have multiple values.
-Make it so that if you click on the line immediately above
a line that has a comment it will add a new comment instead of
adding lines to the following comment. If the last selected line
overlaps existing comment lines though they will still get
added to the existing comment.

  • code-review.js:
1:59 PM Changeset in webkit [75815] by commit-queue@webkit.org
  • 10 edits
    2 moves
    1 delete in trunk

2011-01-14 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42237

Remove Chromium-specific implementation from WebCore.

No tests added; this refactor should be covered by existing history-exercising tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • history/BackForwardListChromium.cpp: Removed.
  • history/BackForwardListImpl.h:

2011-01-14 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42237

Replace Chromium-specific BackForwardListClient in WebCore with a Chromium impl
of the BackForwardList interface.

  • WebKit.gyp:
  • src/BackForwardListChromium.cpp: Copied from WebKit/chromium/src/BackForwardListClientImpl.cpp. (WebKit::BackForwardListChromium::create): (WebKit::BackForwardListChromium::BackForwardListChromium): (WebKit::BackForwardListChromium::~BackForwardListChromium): (WebKit::BackForwardListChromium::addItem): (WebKit::BackForwardListChromium::goToItem): (WebKit::BackForwardListChromium::itemAtIndex): (WebKit::BackForwardListChromium::backListCount): (WebKit::BackForwardListChromium::forwardListCount): (WebKit::BackForwardListChromium::isActive): (WebKit::BackForwardListChromium::close):
  • src/BackForwardListChromium.h: Copied from WebKit/chromium/src/BackForwardListClientImpl.h.
  • src/BackForwardListClientImpl.cpp: Removed.
  • src/BackForwardListClientImpl.h: Removed.
  • src/FrameLoaderClientImpl.cpp:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::currentHistoryItem):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:
1:51 PM Changeset in webkit [75814] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Delay initializing the sandbox until we get the InitializeWebProcess message.

Reviewed by Sam Weinig.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):
(WebKit::WebProcess::platformInitializeWebProcess):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

1:30 PM Changeset in webkit [75813] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-01-14 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style: _FunctionState should keep track of where the function name starts.
https://bugs.webkit.org/show_bug.cgi?id=52454

  • Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to _FunctionState and logic for setting it correctly.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
12:43 PM Changeset in webkit [75812] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2011-01-14 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by Laszlo Gombos.

[Qt] Fixed compilation when QT_NO_SHORTCUT is defined
https://bugs.webkit.org/show_bug.cgi?id=52460

This patch fixes compilation when QT_NO_SHORTCUT is defined in Qt
configuration.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent): Added QT_NO_SHORTCUT guards
12:39 PM Changeset in webkit [75811] by satish@chromium.org
  • 7 edits
    2 adds in trunk

2011-01-12 Satish Sampath <satish@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a crash when accessing speech input from script.
https://bugs.webkit.org/show_bug.cgi?id=52325

Added a layout test to check enabling/disabling speech input from script.

  • fast/speech/speech-input-scripting-expected.txt: Added.
  • fast/speech/speech-input-scripting.html: Added.

2011-01-12 Satish Sampath <satish@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a crash when accessing speech input from script.
https://bugs.webkit.org/show_bug.cgi?id=52325

Test: fast/speech/speech-input-scripting.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Recreate renderer when speech input is enabled/disabled.
  • rendering/RenderTextControlSingleLine.cpp: Remove unused code.
  • rendering/RenderTextControlSingleLine.h:
  • rendering/TextControlInnerElements.cpp: Take self references before firing events and check for renderer validity after. (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): (WebCore::InputFieldSpeechButtonElement::detach):
12:35 PM Changeset in webkit [75810] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-01-14 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Prevent merging of anonymous blocks if one of them is already getting
destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52402

Test: fast/block/merge-anonymous-block-remove-child-crash2.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): initialize m_beingDestroyed to false. (WebCore::RenderBlock::destroy): set m_beingDestroyed to true. (WebCore::canMergeContiguousAnonymousBlocks): do not merge if any or prev or next is being destroyed. (WebCore::RenderBlock::removeChild): remove the hack previously done for preventing oldChild merging with nextBlock's next sibling.
  • rendering/RenderBlock.h: (WebCore::RenderBlock::beingDestroyed): public function for m_beingDestroyed.

2011-01-14 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Tests that we do not crash when trying to merge anonymous blocks, one of which
is already getting destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52402

  • fast/block/merge-anonymous-block-remove-child-crash2-expected.txt: Added.
  • fast/block/merge-anonymous-block-remove-child-crash2.html: Added.
12:30 PM Changeset in webkit [75809] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

fix bugs going back and forth between unified and sidebyside
https://bugs.webkit.org/show_bug.cgi?id=52470

Now that we're appending DOM nodes directly, we only want to
get the first ".text" element in the subtree. In the cases
where there are multiple, their contents are the same.

Also, when making side-by-side expansion lines, we need to
clone the contents so we have a second copy to append to the DOM.

  • code-review.js:
12:27 PM Changeset in webkit [75808] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Follow up to r75791: fix missing dispatch.
https://bugs.webkit.org/show_bug.cgi?id=52442

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
12:01 PM Changeset in webkit [75807] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-01-14 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

Issues with contentsScale in GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=52463

Fix various issues with the recent contentsScale changes:

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_contentsScale to 1. (WebCore::GraphicsLayerCA::updateContentsScale): Only do a setNeedsDisplay() if the layer draws content, otherwise we'll create backing store for empty layers. (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Be sure to set contentsScale on the new (tiled or untiled) layer. (WebCore::GraphicsLayerCA::cloneLayer): Clones need contentsScale too.
11:50 AM Changeset in webkit [75806] by Laszlo Gombos
  • 4 edits in trunk

2011-01-14 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Align import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52208

  • API/JSBase.h: Align import/export directives with WebKit2/Shared/API/c/WKBase.h

2011-01-14 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Align import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52208

  • Shared/API/c/WKBase.h: Align import/export directives with JavaScriptCore/API/JSBase.h.
11:16 AM Changeset in webkit [75805] by tkent@chromium.org
  • 4 edits in trunk/WebKit/chromium

2011-01-14 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] WebKit API: Add a function for form interactive validation setting
https://bugs.webkit.org/show_bug.cgi?id=52430

  • public/WebSettings.h: Add a pure setInteractiveFormValidationEnabled().
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setInteractiveFormValidationEnabled): Implemented.
  • src/WebSettingsImpl.h: Add a declaration.
10:54 AM Changeset in webkit [75804] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-01-14 Simon Fraser <Simon Fraser>

Let Xcode have it's way with the project file.

  • WebCore.xcodeproj/project.pbxproj:
10:53 AM Changeset in webkit [75803] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-01-14 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Refactor some FrameView::syncCompositingState code
https://bugs.webkit.org/show_bug.cgi?id=52459

Refactor some code in FrameView related to synchronizing
compositing layer state.

  • page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateForThisFrame): (WebCore::FrameView::syncCompositingStateRecursive): (WebCore::FrameView::paintContents):
  • page/FrameView.h:
10:38 AM Changeset in webkit [75802] by tony@chromium.org
  • 12 edits in trunk/LayoutTests

2011-01-14 Tony Chang <tony@chromium.org>

Unreviewed, updating baselines.

[chromium] rebaseline vertical tests on linux
https://bugs.webkit.org/show_bug.cgi?id=52457

After updating fonts.conf, these tests are now passing.

  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.png:
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.checksum:
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.png:
  • platform/chromium/test_expectations.txt:
10:30 AM Changeset in webkit [75801] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Eric Seidel.

[Qt] Fix build problem introduced by http://trac.webkit.org/changeset/75713
https://bugs.webkit.org/show_bug.cgi?id=30179

  • plugins/symbian/PluginViewSymbian.cpp:
10:09 AM Changeset in webkit [75800] by commit-queue@webkit.org
  • 7 edits in trunk

2011-01-14 Vincent Scheib <scheib@chromium.org>

Reviewed by David Levin.

Add support to DumpRenderTree to use the GPU rather than software renderer
https://bugs.webkit.org/show_bug.cgi?id=52333

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

2011-01-14 Vincent Scheib <scheib@chromium.org>

Reviewed by David Levin.

Add support to DumpRenderTree to use the GPU rather than software renderer
https://bugs.webkit.org/show_bug.cgi?id=52333

  • DEPS: Moved forward to take required support from webkit_support.h
  • WebKit.gyp: DumpRenderTree depends on Angle on windows
9:35 AM Changeset in webkit [75799] by tony@chromium.org
  • 4 edits in trunk

2011-01-14 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] update fonts.conf to fix 6 linux tests in drt
https://bugs.webkit.org/show_bug.cgi?id=52411

  • platform/chromium/test_expectations.txt:

2011-01-14 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] update fonts.conf to fix 6 linux tests in drt
https://bugs.webkit.org/show_bug.cgi?id=52411

  • DumpRenderTree/chromium/fonts.conf: Update to match the copy in

chromium's src/webkit/tools/test_shell/resources/fonts.conf

9:27 AM Changeset in webkit [75798] by Carlos Garcia Campos
  • 16 edits
    1 add in trunk

2011-01-14 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add volume slider to media player
https://bugs.webkit.org/show_bug.cgi?id=51532

  • platform/gtk/Skipped:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-volume-slider-expected.txt: Added.

2011-01-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add volume slider to media player
https://bugs.webkit.org/show_bug.cgi?id=51532

  • css/mediaControlsGtk.css: (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel): (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container): (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize): (WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer): (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): (WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb):
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::adjustSliderThumbSize):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::adjustSliderThumbSize):
9:03 AM Changeset in webkit [75797] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-14 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by David Levin.

[GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=52434

No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.

  • platform/gtk/FileSystemGtk.cpp: (WebCore::filenameToString): Use GOwnPtr instead of gchar pointer. (WebCore::fileSystemRepresentation): Ditto. (WebCore::filenameForDisplay): Ditto. (WebCore::pathGetFileName): Ditto.
8:02 AM Changeset in webkit [75796] by msaboff@apple.com
  • 5 edits in trunk

2011-01-14 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

Incorrect backtracking for nested alternatives
https://bugs.webkit.org/show_bug.cgi?id=52387

Added tests to verfiy backtracking of alternatives following
parenthesis.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:

2011-01-14 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

Incorrect backtracking for nested alternatives
https://bugs.webkit.org/show_bug.cgi?id=52387

In the process of propigating a datalabel it wasn't getting connected
to a destination when the destination was an indirect jump. Added
code to recognize a direct backtrack destination that was an indirect
jump and added mechanism to associate DataLabelPtrs with indirect
jump entries.
Removed dead method
BacktrackDestination::linkDataLabelToHereIfExists()

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::IndirectJumpEntry::IndirectJumpEntry): (JSC::Yarr::YarrGenerator::IndirectJumpEntry::addDataLabel): (JSC::Yarr::YarrGenerator::GenerationState::addIndirectJumpEntry): (JSC::Yarr::YarrGenerator::GenerationState::emitIndirectJumpTable): Changes to link indirect jumps with DataLabelPtr's. (JSC::Yarr::YarrGenerator::BacktrackDestination::clearSubDataLabelPtr): (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists): Updated to handle immediate linking of indirect jumps to DataLabelPtr. (JSC::Yarr::YarrGenerator::generateParenthesesDisjunction): Changed to reflect updated linkDataLabelToBacktrackIfExists().
7:58 AM Changeset in webkit [75795] by podivilov@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-01-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload.
https://bugs.webkit.org/show_bug.cgi?id=52215

  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.populateLabelElement):
  • inspector/front-end/Script.js: (WebInspector.Script.prototype.get linesCount): (WebInspector.Script.prototype.sourceLine): (WebInspector.Script.prototype.sourceLine.didRequestSource): (WebInspector.Script.prototype.set source): (WebInspector.Script.prototype.requestSource.didGetScriptSource): (WebInspector.Script.prototype.requestSource):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded.didRequestSource): (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addBreakpoint):
  • inspector/front-end/utilities.js: (String.prototype.findAll):
7:49 AM Changeset in webkit [75794] by podivilov@chromium.org
  • 13 edits in trunk/Source

2011-01-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide script column offset to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52377

  • parser/SourceCode.h: (JSC::SourceCode::SourceCode): (JSC::SourceCode::firstColumn):

2011-01-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide script column offset to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52377

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/ScriptDebugListener.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.parsedScriptSource):
  • inspector/front-end/Script.js: (WebInspector.Script):
7:28 AM Changeset in webkit [75793] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-14 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed one line fix for console-xhr-logging test.

The problem was introduced at r75788.

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
6:57 AM Changeset in webkit [75792] by yurys@chromium.org
  • 22 edits
    2 adds in trunk/Source/WebCore

2011-01-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract console related functionality into InspectorConsoleAgent
https://bugs.webkit.org/show_bug.cgi?id=52282

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::~ConsoleMessage):
  • inspector/ConsoleMessage.h:
  • inspector/Inspector.idl:
  • inspector/InspectorConsoleAgent.cpp: Added. (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::reset): (WebCore::InspectorConsoleAgent::setFrontend): (WebCore::InspectorConsoleAgent::addMessageToConsole): (WebCore::InspectorConsoleAgent::startTiming): (WebCore::InspectorConsoleAgent::stopTiming): (WebCore::InspectorConsoleAgent::count): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::didReceiveResponse): (WebCore::InspectorConsoleAgent::didFailLoading): (WebCore::InspectorConsoleAgent::addConsoleMessage):
  • inspector/InspectorConsoleAgent.h: Added.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h: (WebCore::InspectorController::consoleAgent):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::count): (WebCore::InspectorInstrumentation::startTiming): (WebCore::InspectorInstrumentation::stopTiming): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype.addConsoleMessage): (WebInspector.ConsoleView.prototype.updateConsoleMessageExpiredCount): (WebInspector.ConsoleView.prototype.consoleMessagesCleared):
  • inspector/front-end/inspector.js:
  • page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::count): (WebCore::Console::profile): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed): (WebCore::Console::groupEnd):
  • page/Console.h:
  • page/Console.idl:
6:50 AM Changeset in webkit [75791] by pfeldman@chromium.org
  • 11 edits in trunk

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Web Inspector: do not use this as protocol message
dispatcher in models / agents.
https://bugs.webkit.org/show_bug.cgi?id=52442

Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
There should be a clear way to tell whether method is being called
from within front-end or by the backend.

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.showScriptSource):

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not use this as protocol message
dispatcher in models / agents.
https://bugs.webkit.org/show_bug.cgi?id=52442

Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
There should be a clear way to tell whether method is being called
from within front-end or by the backend.

  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype.nodeForId): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype._removeBreakpoints): (WebInspector.DOMDispatcher): (WebInspector.DOMDispatcher.prototype.setDocument): (WebInspector.DOMDispatcher.prototype.attributesUpdated): (WebInspector.DOMDispatcher.prototype.characterDataModified): (WebInspector.DOMDispatcher.prototype.setChildNodes): (WebInspector.DOMDispatcher.prototype.setDetachedRoot): (WebInspector.DOMDispatcher.prototype.childNodeCountUpdated): (WebInspector.DOMDispatcher.prototype.childNodeInserted): (WebInspector.DOMDispatcher.prototype.childNodeRemoved): (WebInspector.DOMDispatcher.prototype.didCommitLoad): (WebInspector.ApplicationCacheDispatcher): (WebInspector.ApplicationCacheDispatcher.prototype.getApplicationCachesAsync): (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus): (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorageDispatcher): (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage): (WebInspector.DOMStorageDispatcher.prototype.selectDOMStorage): (WebInspector.DOMStorageDispatcher.prototype.updateDOMStorage):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql): (WebInspector.DatabaseDispatcher): (WebInspector.DatabaseDispatcher.prototype.addDatabase): (WebInspector.DatabaseDispatcher.prototype.selectDatabase): (WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded): (WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._resumedScript): (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerDispatcher): (WebInspector.DebuggerDispatcher.prototype.pausedScript): (WebInspector.DebuggerDispatcher.prototype.resumedScript): (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.failedToParseScriptSource):
  • inspector/front-end/FileSystemView.js: (WebInspector.FileSystemDispatcher): (WebInspector.FileSystemDispatcher.prototype.getFileSystemPathsAsync): (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemPath): (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemError): (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemDisabled):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype._addProfileHeader): (WebInspector.ProfilesPanel.prototype._removeProfileHeader): (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): (WebInspector.ProfilesPanel.prototype._setRecordingProfile): (WebInspector.ProfilerDispatcher): (WebInspector.ProfilerDispatcher.prototype.profilerWasEnabled): (WebInspector.ProfilerDispatcher.prototype.profilerWasDisabled): (WebInspector.ProfilerDispatcher.prototype.resetProfiles): (WebInspector.ProfilerDispatcher.prototype.addProfileHeader): (WebInspector.ProfilerDispatcher.prototype.addHeapSnapshotChunk): (WebInspector.ProfilerDispatcher.prototype.finishHeapSnapshot): (WebInspector.ProfilerDispatcher.prototype.setRecordingProfile): (WebInspector.ProfileSidebarTreeElement.prototype.ondelete):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._timelineProfilerWasStarted): (WebInspector.TimelinePanel.prototype._timelineProfilerWasStopped): (WebInspector.TimelinePanel.prototype._addRecordToTimeline): (WebInspector.TimelineDispatcher): (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStarted): (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStopped): (WebInspector.TimelineDispatcher.prototype.addRecordToTimeline):
6:25 AM Changeset in webkit [75790] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][V8] Unreviewed buildfix after r75788.

  • inspector/InspectorBrowserDebuggerAgent.cpp:
5:31 AM Changeset in webkit [75789] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-14 Andrey Kosyakov <caseq@chromium.org>

Unreviewed test fix.
Filter out /favicon.ico from page resources list to avoid test expectations mismatch on GTK.

  • http/tests/inspector/extensions-resources-redirect.html:
4:54 AM Changeset in webkit [75788] by loislo@chromium.org
  • 14 edits
    2 adds in trunk/Source/WebCore

2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.

http://bugs.webkit.org/show_bug.cgi?id=52294

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: Added. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
  • inspector/InspectorBrowserDebuggerAgent.h: Added. (WebCore::InspectorBrowserDebuggerAgent::create):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
4:33 AM Changeset in webkit [75787] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-01-14 Eric Seidel <eric@webkit.org>

Original patch from Peter Gal <galpater@inf.u-szeged.hu>

Reviewed by Adam Barth.

Fix when running Tools/Scripts/check-webkit-style without arguments.
https://bugs.webkit.org/show_bug.cgi?id=52261#c16

  • Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
4:25 AM Changeset in webkit [75786] by caseq@chromium.org
  • 18 edits in trunk

2011-01-14 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: redirected resources not handled properly in Network panel
https://bugs.webkit.org/show_bug.cgi?id=52292

  • inspector/Inspector.idl: Do not pass isMainResource to identifierForInitialRequest() (it's useless, as we may hit provisional load)
  • inspector/InspectorInstrumentation.cpp: Ditto. (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
  • inspector/InspectorResourceAgent.cpp: Ditto. (WebCore::InspectorResourceAgent::identifierForInitialRequest):
  • inspector/InspectorResourceAgent.h: Ditto.
  • inspector/InspectorInstrumentation.cpp: Ditto. (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): Fix main resource detection.
  • inspector/front-end/AuditsPanel.js: WebInspector.networkResources now returns array, not map.
  • inspector/front-end/ConsoleView.js: User WebInspector.resourceById() to get resource (WebInspector.ConsoleMessage.prototype._formatMessage):
  • inspector/front-end/ExtensionServer.js: Ditto. (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetResourceContent):
  • inspector/front-end/HAREntry.js: WebInspector.networkResources now returns array, not map (WebInspector.HARLog.prototype.build): (WebInspector.HARLog.prototype._convertResource):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): Use appendResource, not refreshResource, when adding a new resource. (WebInspector.NetworkManager.prototype.identifierForInitialRequest): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkManager.prototype.setInitialContent): (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): (WebInspector.NetworkManager.prototype.didCreateWebSocket): (WebInspector.NetworkManager.prototype._createResource): always register resource URL with ResourceTreeModel (WebInspector.NetworkManager.prototype._appendRedirect):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.get resources): (WebInspector.NetworkPanel.prototype.resourceById): (WebInspector.NetworkPanel.prototype.appendResource): Add resource as new iff appendResource was added. (WebInspector.NetworkPanel.prototype.refreshResource): ditto. (WebInspector.NetworkPanel.prototype.mainResourceChanged): Clear console upon arrival of new main resource.
  • inspector/front-end/ResourceTreeModel.js: Expose unbindResourceURL, bind resources automatically upon creation. (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype.unbindResourceURL): (WebInspector.ResourceTreeModel.prototype._addFramesRecursively): (WebInspector.ResourceTreeModel.prototype.createResource):
  • inspector/front-end/inspector.js: (WebInspector.resourceById):

2011-01-14 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: redirected resources not handled properly in Network panel
Added test for redirected resource presence in HAR
Changed test to request entire HAR log, not multiple HAR entries.
https://bugs.webkit.org/show_bug.cgi?id=52292

  • http/tests/inspector/extensions-resources-redirect-expected.txt:
  • http/tests/inspector/extensions-resources-redirect.html:
  • http/tests/inspector/resource-har-conversion.html:
  • inspector/extensions-resources.html:
2:48 AM Changeset in webkit [75785] by loislo@chromium.org
  • 14 edits
    2 deletes in trunk/Source/WebCore

2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75783.
http://trac.webkit.org/changeset/75783
https://bugs.webkit.org/show_bug.cgi?id=52439

a bit strange but the same patch have broken mac builds at
linking stage. (Requested by loislo2 on #webkit).

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
  • inspector/InspectorBrowserDebuggerAgent.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint): (WebCore::InspectorController::setEventListenerBreakpoint): (WebCore::InspectorController::removeEventListenerBreakpoint): (WebCore::InspectorController::hasEventListenerBreakpoint): (WebCore::InspectorController::setXHRBreakpoint): (WebCore::InspectorController::removeXHRBreakpoint): (WebCore::InspectorController::hasXHRBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::descriptionForDOMEvent): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::hasBreakpoint): (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2:24 AM Changeset in webkit [75784] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2011-01-14 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by Ojan Vafai.

Address some user-select-none issues better in our Find in page scoping
function.

The scoping function is in part based on Editor::countMatchesForText
(formerly Frame::markAllMatchesForText), but was rewritten with
asychronous search and interruptability in mind. At the time the
function was written, countMatchesForText didn't work well with
user-select-none style but that has now changed. While
investigating http://crbug.com/68494 I noticed WebKit had fixed this
very problem in the countMatchesForText and I believe we should make
the same changes in our platform code. Therefore, this changelist
adopts the same approach by integrating:
https://bugs.webkit.org/show_bug.cgi?id=33508
(r53142: handling user-select-none better) and
https://bugs.webkit.org/show_bug.cgi?id=51623
(r74886: handling match within textfield better).
For more details see those changelists.

This changelist, however, is tracked here:
https://bugs.webkit.org/show_bug.cgi?id=52367

The original changelists did not come with layout tests, but I'm adding
a test on the Chromium side for this.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::scopeStringMatches):
2:22 AM Changeset in webkit [75783] by loislo@chromium.org
  • 14 edits
    2 adds in trunk/Source/WebCore

2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.

http://bugs.webkit.org/show_bug.cgi?id=52294

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: Added. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
  • inspector/InspectorBrowserDebuggerAgent.h: Added. (WebCore::InspectorBrowserDebuggerAgent::create):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2:05 AM Changeset in webkit [75782] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/gtk

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: gtk build fix (2).

  • webkit/webkitwebview.cpp:
2:02 AM Changeset in webkit [75781] by jochen@chromium.org
  • 3 edits in trunk/Tools

2011-01-04 Jochen Eisinger <jochen@chromium.org>

Reviewed by David Levin.

Store the tempdir object in a variable so it doesn't get deleted too early.
https://bugs.webkit.org/show_bug.cgi?id=51875

  • Scripts/update-webkit-auxiliary-libs:
  • Scripts/update-webkit-support-libs:
1:59 AM Changeset in webkit [75780] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/gtk

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: gtk build fix.

  • webkit/webkitwebinspector.cpp:
1:52 AM Changeset in webkit [75779] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-01-14 Eric Seidel <eric@webkit.org>

Unreviewed. Make it work in python 2.5.

webkit-patch suggest-reviewers dies when ChangeLogs are missing
https://bugs.webkit.org/show_bug.cgi?id=49158

  • Scripts/webkitpy/common/checkout/api_unittest.py:
1:47 AM Changeset in webkit [75778] by pfeldman@chromium.org
  • 4 edits in trunk

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: build fix.

  • WebCore.vcproj/WebCore.vcproj:
1:28 AM Changeset in webkit [75777] by pfeldman@chromium.org
  • 13 edits
    2 adds in trunk

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract InspectorSettings from InspectorState,
simplify it.
https://bugs.webkit.org/show_bug.cgi?id=52429

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectorStartsAttached): (WebCore::InspectorController::setInspectorStartsAttached): (WebCore::InspectorController::setInspectorAttachedHeight): (WebCore::InspectorController::inspectorAttachedHeight): (WebCore::InspectorController::setMonitoringXHREnabled): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger):
  • inspector/InspectorController.h:
  • inspector/InspectorSettings.cpp: Added. (WebCore::InspectorSettings::InspectorSettings): (WebCore::InspectorSettings::getBoolean): (WebCore::InspectorSettings::setBoolean): (WebCore::InspectorSettings::getLong): (WebCore::InspectorSettings::setLong): (WebCore::InspectorSettings::registerBoolean): (WebCore::InspectorSettings::registerLong):
  • inspector/InspectorSettings.h: Added.
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::setValue): (WebCore::InspectorState::setObject): (WebCore::InspectorState::registerBoolean): (WebCore::InspectorState::registerString): (WebCore::InspectorState::registerLong): (WebCore::InspectorState::registerObject): (WebCore::InspectorState::Property::create):
  • inspector/InspectorState.h: (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract InspectorSettings from InspectorState,
simplify it.
https://bugs.webkit.org/show_bug.cgi?id=52429

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
1:21 AM Changeset in webkit [75776] by loislo@chromium.org
  • 15 edits
    2 deletes in trunk

2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75774.
http://trac.webkit.org/changeset/75774
https://bugs.webkit.org/show_bug.cgi?id=52431

gtk builds were broken (Requested by loislo2 on #webkit).

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
  • inspector/InspectorBrowserDebuggerAgent.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint): (WebCore::InspectorController::setEventListenerBreakpoint): (WebCore::InspectorController::removeEventListenerBreakpoint): (WebCore::InspectorController::hasEventListenerBreakpoint): (WebCore::InspectorController::setXHRBreakpoint): (WebCore::InspectorController::removeXHRBreakpoint): (WebCore::InspectorController::hasXHRBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::descriptionForDOMEvent): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::hasBreakpoint): (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75774.
http://trac.webkit.org/changeset/75774
https://bugs.webkit.org/show_bug.cgi?id=52431

gtk builds were broken (Requested by loislo2 on #webkit).

  • Scripts/webkitpy/common/checkout/scm.py:
12:56 AM Changeset in webkit [75775] by levin@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style: _FunctionState should detect pure functions.
https://bugs.webkit.org/show_bug.cgi?id=52428

Reviewed by Shinichiro Hamaji.

  • Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration

is a pure virtual function.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure

virtual functions are correctly detected.

12:21 AM Changeset in webkit [75774] by loislo@chromium.org
  • 15 edits
    2 adds in trunk

2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.

http://bugs.webkit.org/show_bug.cgi?id=52294

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: Added. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
  • inspector/InspectorBrowserDebuggerAgent.h: Added. (WebCore::InspectorBrowserDebuggerAgent::create):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

2011-01-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Just small fix for problem with check-webkit-style.
It just didn't work for this patch.
Old code can't concatenate a list of strings with None.

  • Scripts/webkitpy/common/checkout/scm.py:
12:14 AM Changeset in webkit [75773] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-14 Hayato Ito <hayato@chromium.org>

Unreviewed chromium expectations update.

Exclude http/tests/loading/cross-origin-XHR-willLoadRequest.html (added in r75768)

  • platform/chromium/test_expectations.txt:

Jan 13, 2011:

10:58 PM Changeset in webkit [75772] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-01-13 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style: _FunctionState should use Position to know where items are.
https://bugs.webkit.org/show_bug.cgi?id=52424

  • Scripts/webkitpy/style/checkers/cpp.py: (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers. (detect_functions): Changed to pass Position's to _FunctionState.begin and did some minor clean-up. (*): Other changes are simply about converting to use the Position's in_FunctionState instead of line numbers.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code to verify the positions stored in _FunctionState.
10:58 PM Changeset in webkit [75771] by hayato@chromium.org
  • 4 edits in trunk/LayoutTests

2011-01-13 Hayato Ito <hayato@chromium.org>

Unreviewed, build fix.

Fix Skipped lists in r75768.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:21 PM Changeset in webkit [75770] by tkent@chromium.org
  • 7 edits in trunk/Source/WebCore

Implement form validation message UI
https://bugs.webkit.org/show_bug.cgi?id=48980

Reviewed by Dimitri Glazkov.

  • Add four internal pseudo selectors:
    • -webkit-validation-bubble
    • -webkit-validation-bubble-message
    • -webkit-validation-bubble-top-outer-arrow
    • -webkit-validation-bubble-top-inner-arrow
  • Implement ValidationMessage functions Show the message for <the number of characters> / 20.0 seconds.

No new tests because the feature is disabled by default for now and the
new behavior is strongly timing-dependent.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):

Do not share a style with elements with different shadowPseudoId().

  • css/html.css: Define appearance for the internal selectors.

(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-top-outer-arrow):
(::-webkit-validation-bubble-top-inner-arrow):

  • dom/Node.cpp:

(WebCore::Node::createRendererIfNeeded):

Allow to add shadow renderers even if canHaveChildren() returns false.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::detach):

Remove m_validationMessage immediately because we can't use
hideVisibleValidationMessage(), which calls a ValidationMessage function later.

(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):

  • Don't create ValidationMessage if the message is empty.
  • Remove the check for message equality.

(WebCore::HTMLFormControlElement::hideVisibleValidationMessage):

Don't remove m_validationMessage immediately. We shouldn't make the
element needsLayout() state in this context.

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::~ValidationMessage):

hideMessage() -> deleteBubbleTree() renaming.

(WebCore::ValidationMessage::setMessage): Implemented.
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):

Added. This updates the validation message and starts the timer to hide it.

(WebCore::ElementWithPseudoId):

Added to help implementations of styled shadow nodes.

(WebCore::ValidationMessage::buildBubbleTree): Added.
(WebCore::ValidationMessage::requestToHideMessage): Added.
(WebCore::ValidationMessage::deleteBubbleTree):

Renamed from hideMessage(), and implemented.

  • html/ValidationMessage.h: Add declarations.
9:40 PM Changeset in webkit [75769] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-01-13 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

webkit-patch suggest-reviewers dies when ChangeLogs are missing
https://bugs.webkit.org/show_bug.cgi?id=49158

This is not the most elegant, but it is a very safe fix to this bug.
One advantage of catching ScriptError like this instead of adding a
new added_or_modified_files or fixing all changed_files callers
to use a more specific change_files variant, is that we catch
all kinds of ScriptErrors which might cause our (non-essential)
suggest-reviewers code to fail out. This should make passing
--suggest-reviewers to webkit-patch upload much more robust
and may even make it possible for us to make it default.

The root of the problem here is that SCM.changed_files includes
deleted ChangeLog paths (from moves, etc) which then when we ask
SVN/Git for the contents of the file at that revision, the command
errors out and Executive.run_command raises a ScriptError.

In the future we might fix this differently by making all current
callers of chagned_files use a more specific method for requesting
what types of changes they're interested in (adds, modifies, deletes, etc.)

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
9:19 PM Changeset in webkit [75768] by mitz@apple.com
  • 10 edits
    2 adds in trunk

<rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
https://bugs.webkit.org/show_bug.cgi?id=52419

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/loading/cross-origin-XHR-willLoadRequest.html

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init): Complete r74453 by ensuring that m_request is only set after
willSendRequest(). Otherwise, willSendRequest() ends up calling into
ThreadableDocumentRequest::willSendRequest(), which cancels the request.

Tools:

Allow to further control the behavior of the willSendRequest delegate callback by making it
set a different URL in the new request.

  • DumpRenderTree/LayoutTestController.cpp:

(addURLToRedirectCallback): Added.
(LayoutTestController::staticFunctions): Added addURLToRedirect.
(LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
(LayoutTestController::redirectionDestinationForURL): Added this getter.

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
change the URL in the new request to the redirect destination.

LayoutTests:

  • http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt: Added.
  • http/tests/loading/cross-origin-XHR-willLoadRequest.html: Added.
  • platform/gtk/Skipped: Skip the new test.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
8:19 PM Changeset in webkit [75767] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Don’t try to compile InjectedScriptSource.js into WebCore.

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj:
6:52 PM Changeset in webkit [75766] by Darin Adler
  • 4 edits in trunk/Source/JavaScriptCore

<rdar://problem/5469576> Use PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 if available.

Reviewed by Geoff Garen.

  • DerivedSources.make: Create a header file, HeaderDetection.h, that tells

us whether pthread_machdep.h is available.

  • wtf/FastMalloc.cpp: If PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 is available, then

don't do the pthread_getspecific_function_pointer trick.
(WTF::setThreadHeap): Ditto, but set thread-specific data.
(WTF::TCMalloc_ThreadCache::GetThreadHeap): Ditto, but get rather than set.

6:24 PM Changeset in webkit [75765] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-13 Justin Schuh <jschuh@chromium.org>

Unreviewed chromium expectations update.

Several text layout tests failing on linux after r75756

  • platform/chromium/test_expectations.txt:
6:11 PM Changeset in webkit [75764] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-01-13 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r75740.
http://trac.webkit.org/changeset/75740

This led to GTK+ redness

  • platform/gtk/Skipped:
6:07 PM Changeset in webkit [75763] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-13 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Unskip http/tests/security/originHeader/origin-header-for-empty.html
https://bugs.webkit.org/show_bug.cgi?id=52389

  • platform/qt/Skipped:
5:58 PM Changeset in webkit [75762] by mihaip@chromium.org
  • 1 edit
    63 adds in trunk/LayoutTests

2011-01-13 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium expectations update.

Add Chromium Snow Leopard expectations. These need to go into a new
chromium-mac-snowleopard directory, since these tests do not have
chromium-mac expectations, but currently pass on Leopard.

The differences are due to bug 52335 (which explains why we can't use
the regular mac port Snow Leopard baselines).

  • platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.png: Added.
  • platform/chromium-mac-snowleopard/css1/box_properties/float-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css1/box_properties/float-expected.png: Added.
  • platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.png: Added.
5:56 PM Changeset in webkit [75761] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-01-13 Eric Seidel <eric@webkit.org>

Reviewed by Mihai Parparita.

webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
https://bugs.webkit.org/show_bug.cgi?id=52416

Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717
UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data

I also added FIXMEs about the changed_files returning deleted files problem
which is causing the other most common exception for suggest-reviewers
(and is probably breaking sheriff-bots blame detection).

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
  • Scripts/webkitpy/common/checkout/scm.py:
5:51 PM Changeset in webkit [75760] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-01-13 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

results archives from commit-queue are too large to upload
https://bugs.webkit.org/show_bug.cgi?id=52405

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/tool/commands/queues.py:
5:31 PM Changeset in webkit [75759] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2011-01-13 John Abd-El-Malek <jam@chromium.org>

Reviewed by Mihai Parparita.

[chromium] Fix minor type in plugin printing
https://bugs.webkit.org/show_bug.cgi?id=52410

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::printBegin):
5:16 PM Changeset in webkit [75758] by mthole@apple.com
  • 4 edits in trunk/Source/WebCore

The pageScaleFactor() should be saved/restored along with the scroll position
https://bugs.webkit.org/show_bug.cgi?id=52406
<rdar://problem/8714412>

Reviewed by Darin Adler and Brady Eidson.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem): Initialize m_pageScaleFactor.
(WebCore::HistoryItem::pageScaleFactor): Added getter.
(WebCore::HistoryItem::setPageScaleFactor): Added setter.
(WebCore::HistoryItem::encodeBackForwardTreeNode): Encode m_pageScaleFactor.
(WebCore::HistoryItem::decodeBackForwardTree): Decode m_pageScaleFactor.

  • history/HistoryItem.h:
  • loader/HistoryController.cpp:

(WebCore::HistoryController::saveScrollPositionAndViewStateToItem): Save the page scale factor...
(WebCore::HistoryController::restoreScrollPositionAndViewState): ...and restore it here.

5:15 PM Changeset in webkit [75757] by mihaip@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2011-01-13 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium expectations update.

Categorize remaining scrollbar-related failures. 6 are due to bug 52414
(small remaining difference between mac and chromium-mac scrollbars).
fast/text/international/thai-line-breaks.html just needed a baseline
update (done for both Leopard and Snow Leopard).

  • platform/chromium-mac-leopard/fast/text/international/thai-line-breaks-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/international/thai-line-breaks-expected.png: Added.
  • platform/chromium-mac/fast/text/international/thai-line-breaks-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/thai-line-breaks-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:48 PM Changeset in webkit [75756] by evan@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-13 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] drop backwards iteration in Linux complex text code
https://bugs.webkit.org/show_bug.cgi?id=52403

ComplexTextController previously supported iterating through the text in
both directions, but this resulted in duplicate code for each path.
Instead, by being more careful about flipping signs where appropriate,
we can refactor the code into one code path.

No tests, just a refactoring; should be covered by existing tests.

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::ComplexTextController): (WebCore::ComplexTextController::reset): (WebCore::ComplexTextController::nextScriptRun):
  • platform/graphics/chromium/ComplexTextControllerLinux.h:
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::selectionRectForComplexText):
4:41 PM Changeset in webkit [75755] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.7/WebKit2

Build fix.

4:39 PM Changeset in webkit [75754] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-13 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

simplify keyboard handling in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52407

Now that we have DiffBlock containers, the only things that are
focusable are previousComment nodes and DiffBlock containers
that contain add/remove lines.

Also, this means we show the focus border around the entire diff
instead of just the first line.

  • code-review.js:
4:16 PM Changeset in webkit [75753] by mrowe@apple.com
  • 9 edits in tags/Safari-534.15.7

Merge r75662.

4:16 PM Changeset in webkit [75752] by mrowe@apple.com
  • 15 edits in tags/Safari-534.15.7

Merge r75635.

4:16 PM Changeset in webkit [75751] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.7

Merge r74309.

4:15 PM Changeset in webkit [75750] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.7

Versioning.

4:14 PM Changeset in webkit [75749] by Dimitri Glazkov
  • 12 edits in trunk/Source/WebCore

2011-01-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Flip input[type=range] to use the new shadow DOM model.
https://bugs.webkit.org/show_bug.cgi?id=52317

This is a straight-up flip, minimal change to the logic, which will be
refactored in a follow-up patch.

Covered by existing tests.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either

host or parent node to find parent.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): Added logic for destroying/creating

shadow DOM subtree.

  • html/InputType.cpp: (WebCore::InputType::createShadowSubtree): Added empty decl. (WebCore::InputType::destroyShadowSubtree): Added a method to destroy

shadow subtree.

  • html/InputType.h: Added defs.
  • html/RangeInputType.cpp: (WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create

slider thumb.

  • html/RangeInputType.h: Adde def.
  • html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class

to handle cascading appearance.

(WebCore::RenderSliderThumb::RenderSliderThumb): Added.
(WebCore::RenderSliderThumb::layout): Moved here the logic from

RenderSlider::createThumbStyle.

(WebCore::SliderThumbElement::createRenderer): Added virtual method to

create RenderSliderThumb instance.

(WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement

as base class.

(WebCore::SliderThumbElement::detach): Ditto.

  • html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::SliderThumbElement): Ditto. (WebCore::SliderThumbElement::create): Ditto. (WebCore::toSliderThumbElement): Added a casting helper.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,

since the whole method is hand-rolled.

(WebCore::MediaControlInputElement::updateStyle): Ditto.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::~RenderSlider): Removed unneeded code. (WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper. (WebCore::RenderSlider::layout): Ditto. (WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access

SliderThumbElement.

(WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
(WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
(WebCore::RenderSlider::setValueForPosition): Ditto.
(WebCore::RenderSlider::positionForOffset): Ditto.
(WebCore::RenderSlider::currentPosition): Ditto.
(WebCore::RenderSlider::trackSize): Ditto.
(WebCore::RenderSlider::forwardEvent): Ditto.
(WebCore::RenderSlider::inDragMode): Ditto.

  • rendering/RenderSlider.h: Added def.
4:06 PM BuildBot edited by Lucas Forschler
(diff)
3:55 PM Changeset in webkit [75748] by abarth@webkit.org
  • 32 edits
    1 move in trunk

2011-01-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename RGBA32Buffer to ImageFrame
https://bugs.webkit.org/show_bug.cgi?id=52363

Update references to the new name.

  • src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::isFrameCompleteAtIndex): (WebKit::WebImageDecoder::getFrameAtIndex):

2011-01-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename RGBA32Buffer to ImageFrame
https://bugs.webkit.org/show_bug.cgi?id=52363

RGBA32Buffer is a terrible misnomer. ImageFrame is vastly
more accurate. More cleanup to come.

  • WebCore.pro:
  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::createFrameAtIndex): (WebCore::ImageSource::frameDurationAtIndex): (WebCore::ImageSource::frameIsCompleteAtIndex):
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::frameBufferAtIndex): (WebCore::ImageDecoderQt::internalReadImage): (WebCore::ImageDecoderQt::internalHandleCurrentImage):
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/graphics/wince/ImageWinCE.cpp: (WebCore::ImageFrame::asNewNativeImage):
  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageFrame::ImageFrame): (WebCore::ImageFrame::operator=): (WebCore::ImageFrame::clear): (WebCore::ImageFrame::zeroFill): (WebCore::ImageFrame::copyReferenceToBitmapData): (WebCore::ImageFrame::copyBitmapData): (WebCore::ImageFrame::setSize): (WebCore::ImageFrame::hasAlpha): (WebCore::ImageFrame::setHasAlpha): (WebCore::ImageFrame::setColorProfile): (WebCore::ImageFrame::setStatus): (WebCore::ImageFrame::width): (WebCore::ImageFrame::height):
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageFrame::ImageFrame):
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::frameBufferAtIndex): (WebCore::BMPImageDecoder::decode):
  • platform/image-decoders/bmp/BMPImageDecoder.h:
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP):
  • platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::setBuffer):
  • platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::ImageFrame::asNewNativeImage):
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::getPtrAsPixelData): (WebCore::ImageFrame::copyReferenceToBitmapData): (WebCore::ImageFrame::copyBitmapData): (WebCore::ImageFrame::setSize): (WebCore::ImageFrame::asNewNativeImage):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameBufferAtIndex): (WebCore::GIFImageDecoder::clearFrameBufferCache): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete): (WebCore::GIFImageDecoder::initFrameBuffer):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read):
  • platform/image-decoders/gif/GIFImageReader.h: (GIFFrameReader::GIFFrameReader):
  • platform/image-decoders/haiku/ImageDecoderHaiku.cpp: (WebCore::ImageFrame::asNewNativeImage):
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::frameBufferAtIndex): (WebCore::ICOImageDecoder::decode):
  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::frameBufferAtIndex): (WebCore::JPEGImageDecoder::outputScanlines): (WebCore::JPEGImageDecoder::jpegComplete): (WebCore::JPEGImageDecoder::decode):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: (WebCore::ImageFrame::asNewNativeImage):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::frameBufferAtIndex): (WebCore::PNGImageDecoder::rowAvailable): (WebCore::PNGImageDecoder::pngComplete):
  • platform/image-decoders/png/PNGImageDecoder.h: (WebCore::PNGImageDecoder::isComplete):
  • platform/image-decoders/qt/ImageFrameQt.cpp: Copied from Source/WebCore/platform/image-decoders/qt/RGBA32BufferQt.cpp. (WebCore::ImageFrame::ImageFrame): (WebCore::ImageFrame::operator=): (WebCore::ImageFrame::clear): (WebCore::ImageFrame::zeroFill): (WebCore::ImageFrame::copyBitmapData): (WebCore::ImageFrame::setSize): (WebCore::ImageFrame::asNewNativeImage): (WebCore::ImageFrame::hasAlpha): (WebCore::ImageFrame::setHasAlpha): (WebCore::ImageFrame::setColorProfile): (WebCore::ImageFrame::setStatus): (WebCore::ImageFrame::setPixmap): (WebCore::ImageFrame::width): (WebCore::ImageFrame::height):
  • platform/image-decoders/qt/RGBA32BufferQt.cpp: Removed.
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::ImageFrame): (WebCore::ImageFrame::operator=): (WebCore::ImageFrame::clear): (WebCore::ImageFrame::zeroFill): (WebCore::ImageFrame::copyBitmapData): (WebCore::ImageFrame::setSize): (WebCore::ImageFrame::asNewNativeImage): (WebCore::ImageFrame::hasAlpha): (WebCore::ImageFrame::setHasAlpha): (WebCore::ImageFrame::setColorProfile): (WebCore::ImageFrame::setStatus): (WebCore::ImageFrame::width): (WebCore::ImageFrame::height):
  • platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::frameBufferAtIndex): (WebCore::WEBPImageDecoder::decode):
  • platform/image-decoders/webp/WEBPImageDecoder.h:
  • platform/image-decoders/wx/ImageDecoderWx.cpp: (WebCore::ImageFrame::asNewNativeImage):
3:52 PM Changeset in webkit [75747] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-13 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

add container divs for diff blocks
https://bugs.webkit.org/show_bug.cgi?id=52400

This will help simplify a lot of code in code-review.js
and make side-by-side diffs better (i.e. put removed lines
to the left of corresponding added lines).

Also, allow for running the JS from a local file. Now you can modify code-review.js
to point to a local file and then run:
ruby prettify.rb < foo.diff > foo.html

foo.html will load a dummy code review matching foo.diff.

Before structure:
Line
Line remove
Line add
Line add
Line

After structure:
DiffBlock

DiffBlockPart shared

Line shared

DiffBlock

DiffBlockPart remove

Line remove

DiffBlockPart add

Line add
Line add

DiffBlock

DiffBlockPart shared

Line shared

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
3:38 PM Changeset in webkit [75746] by Dimitri Glazkov
  • 4 edits in trunk/Source/WebCore

2011-01-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Transferring nodes between documents should be aware of the shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=52399

No visible change in behavior at the moment.

Once https://bugs.webkit.org/show_bug.cgi?id=52317 lands, the following
tests should no longer crash:

  • fast/css/pseudo-in-range-invalid-value.html
  • fast/css/pseudo-in-range.html
  • fast/forms/form-collection-elements.html
  • fast/forms/range-keyoperation.html
  • dom/Document.cpp: (WebCore::Document::adoptNode): Changed to use Node::setDocumentRecursively.
  • dom/Node.cpp: (WebCore::Node::setDocumentRecursively): Added new method, taking existing

logic and adding shadow DOM traversal.

(WebCore::Node::traverseNextNode): Style fix.
(WebCore::Node::traverseNextSibling): Ditto.
(WebCore::Node::traversePreviousNode): Ditto.
(WebCore::Node::traversePreviousNodePostOrder): Ditto.
(WebCore::Node::checkReplaceChild): Changed to use setDocumentRecursively.
(WebCore::Node::checkAddChild): Ditto.

  • dom/Node.h: Added def.
3:28 PM Changeset in webkit [75745] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-13 Justin Schuh <jschuh@chromium.org>

Unreviewed chromium expectations update.

Remove exception for canvas-large-dimensions.html.

  • platform/chromium/test_expectations.txt:
3:19 PM Changeset in webkit [75744] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.7

New tag.

3:14 PM Changeset in webkit [75743] by enrica@apple.com
  • 30 edits
    1 add in trunk

Source/WebCore: WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/7660558>

Reviewed by Darin Adler.

This patch contains the changes required to support dropping content
in WebKit on the Mac. The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
The support for WebKit as drag source will be added with a separate patch.

  • WebCore.exp.in:
  • page/DragController.cpp:

(WebCore::DragController::dragIsMove): Added DragData parameter.
(WebCore::DragController::tryDocumentDrag): Modified call to dragIsMove.
(WebCore::DragController::concludeEditDrag): Same as above.

  • page/DragController.h: Added parameter to isCopyKeyDown.
  • page/mac/DragControllerMac.mm:

The following methods have been modified to use the information stored
in the DragData class.
(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):

  • platform/DragData.h:

(WebCore::DragData::flags):

  • platform/DragData.cpp: Added default flags parameter to the constructor.
  • platform/mac/DragDataMac.mm:

(WebCore::DragData::DragData): Added constructor that receives the name of the pasteboard to use.
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
All the following files have been modified to add the DragData
parameter to isCopyKeyDown. I plan to improve this in the future
and make isCopyKeyDown not platform specific.

  • page/android/DragControllerAndroid.cpp:

(WebCore::DragController::isCopyKeyDown):

  • page/brew/DragControllerBrew.cpp:

(WebCore::DragController::isCopyKeyDown):

  • page/chromium/DragControllerChromium.cpp:

(WebCore::DragController::isCopyKeyDown):

  • page/efl/DragControllerEfl.cpp:

(WebCore::DragController::isCopyKeyDown):

  • page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::isCopyKeyDown):

  • page/haiku/DragControllerHaiku.cpp:

(WebCore::DragController::isCopyKeyDown):

  • page/mac/DragControllerMac.mm:

(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):

  • page/qt/DragControllerQt.cpp:

(WebCore::DragController::isCopyKeyDown):

  • page/win/DragControllerWin.cpp:

(WebCore::DragController::isCopyKeyDown):

  • page/wx/DragControllerWx.cpp:

(WebCore::DragController::isCopyKeyDown):

WebKit/mac: WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/7660558>

Reviewed by Darin Adler.

The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
These are the changes to align the behavior for WebKit.

  • WebView/WebView.mm:

(-[WebView applicationFlags:]): Added.
(-[WebView draggingEntered:]): Added parameter to the DragData constructor.
(-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
(-[WebView draggingExited:]): Added parameter to the DragData constructor.
(-[WebView performDragOperation:]): Added parameter to the DragData constructor.

WebKit2: WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/7660558>

Reviewed by Darin Adler.

This patch contains the changes required to support dropping content
in WebKit on the Mac. The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
The support for WebKit as drag source will be added with a separate patch.

  • Shared/DragControllerAction.h: Added.
  • UIProcess/API/mac/WKView.mm:

Added implemention of the methods required to add suport for a drop target.
To maintain asynchronous communication with the WebProcess, we always return
the previous calculated value for the drag operation.
(-[WKView _registerDraggedTypes]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView applicationFlags:]):
(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
(-[WKView draggingExited:]):
(-[WKView prepareForDragOperation:]):
(-[WKView performDragOperation:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::didPerformDragControllerAction):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::dragOperation):
(WebKit::WebPageProxy::resetDragOperation):

  • UIProcess/WebPageProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit::WebDragClient::willPerformDragDestinationAction):
(WebKit::WebDragClient::willPerformDragSourceAction):
(WebKit::WebDragClient::actionMaskForDrag):
(WebKit::WebDragClient::dragSourceActionMaskForPoint):
(WebKit::WebDragClient::startDrag):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
3:11 PM Changeset in webkit [75742] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Add missing MathMLElementFactory.h and MathMLNames.h to Xcode project

Not reviewed.

  • WebCore.xcodeproj/project.pbxproj: Add missing headers. Note

that the corresponding source files were originally added to the
project in r48559.

3:05 PM Changeset in webkit [75741] by zmo@google.com
  • 17 edits in trunk/Source/WebCore

2011-01-12 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Use GC3D types in WebGLRenderingContext and related WebGL classes
https://bugs.webkit.org/show_bug.cgi?id=51908

  • html/canvas/WebGLActiveInfo.h: (WebCore::WebGLActiveInfo::create): (WebCore::WebGLActiveInfo::type): (WebCore::WebGLActiveInfo::size): (WebCore::WebGLActiveInfo::WebGLActiveInfo):
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferDataImpl): (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubDataImpl): (WebCore::WebGLBuffer::associateBufferSubData): (WebCore::WebGLBuffer::byteLength): (WebCore::WebGLBuffer::getCachedMaxIndex): (WebCore::WebGLBuffer::setCachedMaxIndex): (WebCore::WebGLBuffer::setTarget):
  • html/canvas/WebGLBuffer.h: (WebCore::WebGLBuffer::getTarget):
  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::setAttachment): (WebCore::WebGLFramebuffer::getAttachment): (WebCore::WebGLFramebuffer::getWidth): (WebCore::WebGLFramebuffer::getHeight): (WebCore::WebGLFramebuffer::getColorBufferFormat): (WebCore::WebGLFramebuffer::initializeRenderbuffers):
  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::cacheActiveAttribLocations): (WebCore::WebGLProgram::numActiveAttribLocations): (WebCore::WebGLProgram::getActiveAttribLocation): (WebCore::WebGLProgram::isUsingVertexAttrib0):
  • html/canvas/WebGLProgram.h: (WebCore::WebGLProgram::getLinkCount):
  • html/canvas/WebGLRenderbuffer.h: (WebCore::WebGLRenderbuffer::setInternalFormat): (WebCore::WebGLRenderbuffer::getInternalFormat): (WebCore::WebGLRenderbuffer::setSize): (WebCore::WebGLRenderbuffer::getWidth): (WebCore::WebGLRenderbuffer::getHeight):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::sizeInBytes): (WebCore::WebGLRenderingContext::activeTexture): (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::bindFramebuffer): (WebCore::WebGLRenderingContext::bindRenderbuffer): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::blendColor): (WebCore::WebGLRenderingContext::blendEquation): (WebCore::WebGLRenderingContext::blendEquationSeparate): (WebCore::WebGLRenderingContext::blendFunc): (WebCore::WebGLRenderingContext::blendFuncSeparate): (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::checkFramebufferStatus): (WebCore::WebGLRenderingContext::clear): (WebCore::WebGLRenderingContext::clearColor): (WebCore::WebGLRenderingContext::clearDepth): (WebCore::WebGLRenderingContext::clearStencil): (WebCore::WebGLRenderingContext::colorMask): (WebCore::WebGLRenderingContext::copyTexImage2D): (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::createShader): (WebCore::WebGLRenderingContext::cullFace): (WebCore::WebGLRenderingContext::deleteBuffer): (WebCore::WebGLRenderingContext::depthFunc): (WebCore::WebGLRenderingContext::depthMask): (WebCore::WebGLRenderingContext::depthRange): (WebCore::WebGLRenderingContext::disable): (WebCore::WebGLRenderingContext::disableVertexAttribArray): (WebCore::WebGLRenderingContext::validateElementArraySize): (WebCore::WebGLRenderingContext::validateIndexArrayConservative): (WebCore::WebGLRenderingContext::validateIndexArrayPrecise): (WebCore::WebGLRenderingContext::validateRenderingState): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enable): (WebCore::WebGLRenderingContext::enableVertexAttribArray): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::frontFace): (WebCore::WebGLRenderingContext::generateMipmap): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getAttachedShaders): (WebCore::WebGLRenderingContext::getAttribLocation): (WebCore::WebGLRenderingContext::getBufferParameter): (WebCore::WebGLRenderingContext::getError): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getRenderbufferParameter): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getTexParameter): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::getVertexAttribOffset): (WebCore::WebGLRenderingContext::hint): (WebCore::WebGLRenderingContext::isBuffer): (WebCore::WebGLRenderingContext::isEnabled): (WebCore::WebGLRenderingContext::isFramebuffer): (WebCore::WebGLRenderingContext::isProgram): (WebCore::WebGLRenderingContext::isRenderbuffer): (WebCore::WebGLRenderingContext::isShader): (WebCore::WebGLRenderingContext::isTexture): (WebCore::WebGLRenderingContext::lineWidth): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::pixelStorei): (WebCore::WebGLRenderingContext::polygonOffset): (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::renderbufferStorage): (WebCore::WebGLRenderingContext::sampleCoverage): (WebCore::WebGLRenderingContext::scissor): (WebCore::WebGLRenderingContext::stencilFunc): (WebCore::WebGLRenderingContext::stencilFuncSeparate): (WebCore::WebGLRenderingContext::stencilMask): (WebCore::WebGLRenderingContext::stencilMaskSeparate): (WebCore::WebGLRenderingContext::stencilOp): (WebCore::WebGLRenderingContext::stencilOpSeparate): (WebCore::WebGLRenderingContext::texImage2DBase): (WebCore::WebGLRenderingContext::texImage2DImpl): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texParameter): (WebCore::WebGLRenderingContext::texParameterf): (WebCore::WebGLRenderingContext::texParameteri): (WebCore::WebGLRenderingContext::texSubImage2DBase): (WebCore::WebGLRenderingContext::texSubImage2DImpl): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::vertexAttrib1f): (WebCore::WebGLRenderingContext::vertexAttrib1fv): (WebCore::WebGLRenderingContext::vertexAttrib2f): (WebCore::WebGLRenderingContext::vertexAttrib2fv): (WebCore::WebGLRenderingContext::vertexAttrib3f): (WebCore::WebGLRenderingContext::vertexAttrib3fv): (WebCore::WebGLRenderingContext::vertexAttrib4f): (WebCore::WebGLRenderingContext::vertexAttrib4fv): (WebCore::WebGLRenderingContext::vertexAttribPointer): (WebCore::WebGLRenderingContext::viewport): (WebCore::WebGLRenderingContext::getBooleanParameter): (WebCore::WebGLRenderingContext::getBooleanArrayParameter): (WebCore::WebGLRenderingContext::getFloatParameter): (WebCore::WebGLRenderingContext::getIntParameter): (WebCore::WebGLRenderingContext::getLongParameter): (WebCore::WebGLRenderingContext::getUnsignedLongParameter): (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter): (WebCore::WebGLRenderingContext::getWebGLIntArrayParameter): (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid): (WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat): (WebCore::WebGLRenderingContext::validateTextureBinding): (WebCore::WebGLRenderingContext::validateSize): (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType): (WebCore::WebGLRenderingContext::validateTexFuncLevel): (WebCore::WebGLRenderingContext::validateTexFuncParameters): (WebCore::WebGLRenderingContext::validateTexFuncData): (WebCore::WebGLRenderingContext::validateDrawMode): (WebCore::WebGLRenderingContext::validateStencilFunc): (WebCore::WebGLRenderingContext::validateFramebufferFuncParameters): (WebCore::WebGLRenderingContext::validateBlendEquation): (WebCore::WebGLRenderingContext::validateBlendFuncFactors): (WebCore::WebGLRenderingContext::validateCapability): (WebCore::WebGLRenderingContext::validateUniformParameters): (WebCore::WebGLRenderingContext::validateUniformMatrixParameters): (WebCore::WebGLRenderingContext::validateBufferDataParameters): (WebCore::WebGLRenderingContext::vertexAttribfImpl): (WebCore::WebGLRenderingContext::vertexAttribfvImpl): (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState):
  • html/canvas/WebGLShader.cpp: (WebCore::WebGLShader::create): (WebCore::WebGLShader::WebGLShader):
  • html/canvas/WebGLShader.h: (WebCore::WebGLShader::getType):
  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::setTarget): (WebCore::WebGLTexture::setParameteri): (WebCore::WebGLTexture::setParameterf): (WebCore::WebGLTexture::setLevelInfo): (WebCore::WebGLTexture::generateMipmapLevelInfo): (WebCore::WebGLTexture::getInternalFormat): (WebCore::WebGLTexture::getType): (WebCore::WebGLTexture::getWidth): (WebCore::WebGLTexture::getHeight): (WebCore::WebGLTexture::isNPOT): (WebCore::WebGLTexture::mapTargetToIndex): (WebCore::WebGLTexture::computeLevelCount): (WebCore::WebGLTexture::update): (WebCore::WebGLTexture::getLevelInfo):
  • html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::LevelInfo::setInfo):
  • html/canvas/WebGLUniformLocation.cpp: (WebCore::WebGLUniformLocation::create): (WebCore::WebGLUniformLocation::WebGLUniformLocation): (WebCore::WebGLUniformLocation::location):
  • html/canvas/WebGLUniformLocation.h:
  • platform/graphics/GraphicsContext3D.h: Map GC3Dboolean to bool instead of unsigned char.
3:00 PM Changeset in webkit [75740] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-01-13 Martin Robinson <mrobinson@igalia.com>

Unskip editing/input/page-up-down-scrolls.html as it's passing locally.

  • platform/gtk/Skipped: Unskip test.
2:55 PM Changeset in webkit [75739] by jianli@chromium.org
  • 33 edits
    3 adds in trunk

Change createObjectURL and revokeObjectURL to put under webkitURL.
https://bugs.webkit.org/show_bug.cgi?id=52257

Reviewed by Darin Fisher.

Source/WebCore:

Note that we add "webkit" vendor prefix to URL that is introduced in
the latest File API spec.

For the time being, we implement webkitURL as a readonly attribute
instead of a constructor so that we will not expose prototype property,
as required by the spec.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/DOMURL.cpp: Added.
  • html/DOMURL.h: Added.
  • html/DOMURL.idl: Added.
  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/utilities.js:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitURL):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::webkitURL):

  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:

LayoutTests:

Change all related test scripts and results to account for this change.

  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance-2.js:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/files/apply-blob-url-to-img.html:
  • fast/files/apply-blob-url-to-xhr.html:
  • fast/files/create-blob-url-crash.html:
  • fast/files/revoke-blob-url.html:
  • fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:

(onmessage):

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
2:49 PM Changeset in webkit [75738] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-01-13 Emil Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

Setting outerText should convert CR/LF to <br>
https://bugs.webkit.org/show_bug.cgi?id=52268

Add test for setting Element.outerText.

  • fast/dom/set-outer-text-expected.txt: Added.
  • fast/dom/set-outer-text.html: Added.
  • fast/dom/text-node-append-data-remove-crash-expected.txt: Changed

expectation to "didn't crash" from "threw dom exception" as test
assumed the DOMCharacterDataModified event would fire before the node
would be replaced.

  • fast/dom/text-node-append-data-remove-crash.html:

2011-01-13 Emil Eklund <eae@chromium.org>

Reviewed by Dimitri Glazkov.

Setting outerText should convert CR/LF to <br>
https://bugs.webkit.org/show_bug.cgi?id=52268

Make set outerText support line breaks (sharing the text to fragment code
with setInnerText) and handle empty text nodes the same way IE does.

Test: fast/dom/set-outer-text.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::textToFragment): Shared between setInnerText and setOuterText (WebCore::HTMLElement::setInnerText): Split out text parsing code. (WebCore::mergeWithNextTextNode): Split out text node merging code. (WebCore::HTMLElement::setOuterText): Added support for line breaks.
  • html/HTMLElement.h:
2:39 PM Changeset in webkit [75737] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a crashing test on Windows

See <http://webkit.org/b/52397>.

  • platform/win/Skipped: Added

compositing/reflections/load-video-in-reflection.html.

2:35 PM Changeset in webkit [75736] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-01-13 Martin Robinson <mrobinson@igalia.com>

Skip fast/text/emphasis.html as it shows a 1 pixel difference on the 32-bit Debug bot.

  • platform/gtk/Skipped: Skip fast/text/emphasis.html.
2:34 PM Changeset in webkit [75735] by zmo@google.com
  • 5 edits in trunk

2011-01-13 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Relax the ESSL valid charset a little bit to include " ' `
https://bugs.webkit.org/show_bug.cgi?id=52396

  • html/canvas/WebGLRenderingContext.cpp:

2011-01-13 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Relax the ESSL valid charset a little bit to include " ' `
https://bugs.webkit.org/show_bug.cgi?id=52396

  • fast/canvas/webgl/invalid-passed-params-expected.txt:
  • fast/canvas/webgl/invalid-passed-params.html:
1:52 PM Changeset in webkit [75734] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2011-01-13 John Abd-El-Malek <jam@chromium.org>

Reviewed by Tony Chang.

[chromium]: Only swallow ctrl+c for windowless plugins if we know the plugin has a selection
https://bugs.webkit.org/show_bug.cgi?id=52393

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::copy): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
12:51 PM Changeset in webkit [75733] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-13 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Attempt to fix crash in tiled compositor memcpy
https://bugs.webkit.org/show_bug.cgi?id=52379

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update):
12:36 PM Changeset in webkit [75732] by mdelaney@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

2011-01-13 Matthew Delaney <mdelaney@apple.com>

Reviewed by nobody - reinstrumenting a test to save burning trees.

fast/canvas/canvas-large-dimensions.html (introduced in r75648) is failing on all platforms except Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=52341

  • fast/canvas/canvas-large-dimensions-expected.txt: Replaced.
  • fast/canvas/canvas-large-dimensions.html:
12:11 PM Changeset in webkit [75731] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-13 Justin Schuh <jschuh@chromium.org>

Unreviewed chromium expectations update.

Exclude destroy-on-setwindow.html (added in r75720).

  • platform/chromium/test_expectations.txt:
12:07 PM Changeset in webkit [75730] by jam@chromium.org
  • 6 edits in trunk/WebKit/chromium

2011-01-11 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add support to allow printing just a plugin in a frame
https://bugs.webkit.org/show_bug.cgi?id=52134

  • public/WebContextMenuData.h:
  • public/WebFrame.h:
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/WebFrameImpl.cpp: (WebKit::ChromePluginPrintContext::ChromePluginPrintContext): (WebKit::ChromePluginPrintContext::end): (WebKit::ChromePluginPrintContext::computePageRects): (WebKit::ChromePluginPrintContext::spoolPage): (WebKit::WebFrameImpl::printBegin):
11:48 AM Changeset in webkit [75729] by alex
  • 6 edits in trunk

2011-01-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[gtk] Zero-sized font does not yet work
https://bugs.webkit.org/show_bug.cgi?id=49793

Unskip font-size-zero.html.

  • platform/gtk/Skipped:

2011-01-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[gtk] Zero-sized font does not yet work
https://bugs.webkit.org/show_bug.cgi?id=49793

Set minimum-font-size to 0 for the DRT.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

2011-01-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[gtk] Zero-sized font does not yet work
https://bugs.webkit.org/show_bug.cgi?id=49793

Allow 0 as a minimum-font-size value for the settings.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
11:38 AM Changeset in webkit [75728] by Dimitri Glazkov
  • 12 edits in trunk/Source/WebCore

Unreviewed, rolling out r75725.
http://trac.webkit.org/changeset/75725
https://bugs.webkit.org/show_bug.cgi?id=52317

Caused crashes in layout tests.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::initForStyleResolve):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/InputType.cpp:
  • html/InputType.h:
  • html/RangeInputType.cpp:
  • html/RangeInputType.h:
  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::detach):

  • html/shadow/SliderThumbElement.h:

(WebCore::SliderThumbElement::SliderThumbElement):
(WebCore::SliderThumbElement::create):

  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlInputElement::attach):
(WebCore::MediaControlInputElement::updateStyle):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::~RenderSlider):
(WebCore::RenderSlider::styleDidChange):
(WebCore::RenderSlider::createThumbStyle):
(WebCore::RenderSlider::thumbRect):
(WebCore::RenderSlider::layout):
(WebCore::RenderSlider::updateFromElement):
(WebCore::RenderSlider::mouseEventIsInThumb):
(WebCore::RenderSlider::mouseEventOffsetToThumb):
(WebCore::RenderSlider::setValueForPosition):
(WebCore::RenderSlider::positionForOffset):
(WebCore::RenderSlider::currentPosition):
(WebCore::RenderSlider::trackSize):
(WebCore::RenderSlider::forwardEvent):
(WebCore::RenderSlider::inDragMode):

  • rendering/RenderSlider.h:
10:56 AM Changeset in webkit [75727] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-13 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium test_expectations.txt

  • platform/chromium/test_expectations.txt: Mark a test as slow in debug.
10:37 AM Changeset in webkit [75726] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

2011-01-13 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Darin Adler.

Make old-run-webkit-tests more robust on buildbots
https://bugs.webkit.org/show_bug.cgi?id=52364

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
10:35 AM Changeset in webkit [75725] by Dimitri Glazkov
  • 12 edits in trunk/Source/WebCore

2011-01-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Flip input[type=range] to use the new shadow DOM model.
https://bugs.webkit.org/show_bug.cgi?id=52317

This is a straight-up flip, minimal change to the logic, which will be
refactored in a follow-up patch.

Covered by existing tests.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either

host or parent node to find parent.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): Added logic for destroying/creating

shadow DOM subtree.

  • html/InputType.cpp: (WebCore::InputType::createShadowSubtree): Added empty decl. (WebCore::InputType::destroyShadowSubtree): Added a method to destroy

shadow subtree.

  • html/InputType.h: Added defs.
  • html/RangeInputType.cpp: (WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create

slider thumb.

  • html/RangeInputType.h: Adde def.
  • html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class

to handle cascading appearance.

(WebCore::RenderSliderThumb::RenderSliderThumb): Added.
(WebCore::RenderSliderThumb::layout): Moved here the logic from

RenderSlider::createThumbStyle.

(WebCore::SliderThumbElement::createRenderer): Added virtual method to

create RenderSliderThumb instance.

(WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement

as base class.

(WebCore::SliderThumbElement::detach): Ditto.

  • html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::SliderThumbElement): Ditto. (WebCore::SliderThumbElement::create): Ditto. (WebCore::toSliderThumbElement): Added a casting helper.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,

since the whole method is hand-rolled.

(WebCore::MediaControlInputElement::updateStyle): Ditto.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::~RenderSlider): Removed unneeded code. (WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper. (WebCore::RenderSlider::layout): Ditto. (WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access

SliderThumbElement.

(WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
(WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
(WebCore::RenderSlider::setValueForPosition): Ditto.
(WebCore::RenderSlider::positionForOffset): Ditto.
(WebCore::RenderSlider::currentPosition): Ditto.
(WebCore::RenderSlider::trackSize): Ditto.
(WebCore::RenderSlider::forwardEvent): Ditto.
(WebCore::RenderSlider::inDragMode): Ditto.

  • rendering/RenderSlider.h: Added def.
10:34 AM Changeset in webkit [75724] by Adam Roben
  • 1 edit
    2 adds in trunk/LayoutTests

Check in Windows-XP-specific results for fast/canvas/set-colors.html

See <http://webkit.org/b/52374>.

  • platform/win-xp/fast/canvas/set-colors-expected.txt: Added.
10:33 AM Changeset in webkit [75723] by Adam Roben
  • 4 edits
    1 move
    1 delete in trunk/LayoutTests

Disable fast/profiler/throw-exception-from-eval.html

This test fails non-deterministically. See <http://webkit.org/b/49801>.

  • fast/profiler/throw-exception-from-eval.html-disabled: Renamed from LayoutTests/fast/profiler/throw-exception-from-eval.html.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:

Un-skipped this test now that it's been disabled by other means.

  • platform/win-xp/fast/profiler/throw-exception-from-eval-expected.txt: Removed.
10:24 AM Changeset in webkit [75722] by mitz@apple.com
  • 2 edits in trunk/WebKit2

Incorrect assertion in DrawingAreaImpl::scroll()
https://bugs.webkit.org/show_bug.cgi?id=52376

Reviewed by John Sullivan.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::scroll): Changed to take the fast path if the rects have the same area.
This made the assertion valid, but I removed it anyway.

10:22 AM Changeset in webkit [75721] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

2011-01-13 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Darin Adler.

Make old-run-webkit-tests more robust on buildbots
https://bugs.webkit.org/show_bug.cgi?id=52364

  • Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
10:21 AM Changeset in webkit [75720] by mitz@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/8098442> Crash in Widget::setFrameRect()
https://bugs.webkit.org/show_bug.cgi?id=52375

Reviewed by Simon Fraser.

Source/WebCore:

Test: plugins/destroy-on-setwindow.html

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
out to the view.
(WebCore::Widget::getOuterView): Coding style fix.
(WebCore::Widget::paint): Protect the Widget from being deleted as a result of calling out to
the views. This is precautionary, since this function does not applear to access member variables
after such calls.

  • platform/wx/WidgetWx.cpp:

(WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
out to the platform widget.

LayoutTests:

  • plugins/destroy-on-setwindow-expected.txt: Added.
  • plugins/destroy-on-setwindow.html: Added.
9:52 AM Changeset in webkit [75719] by tony@chromium.org
  • 6 edits
    1 delete in trunk

2011-01-13 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
https://bugs.webkit.org/show_bug.cgi?id=52332

Fix Linux baseline. Mac should now match Safari Mac.

  • platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
  • platform/chromium/test_expectations.txt:

2011-01-13 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
https://bugs.webkit.org/show_bug.cgi?id=52332

Forked Info.plist is not longer needed.

  • DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.

2011-01-13 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
https://bugs.webkit.org/show_bug.cgi?id=52332

  • WebKit.gyp: Remove WebKitTestNetscapePlugIn
9:25 AM Changeset in webkit [75718] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

Unreviewed buildfix after r75715.

  • WebCore.pri:
  • WebCore.pro:
9:23 AM Changeset in webkit [75717] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: inspector extensions tests should not use
sources as test data. Commenting one out temporarily, filing a bug.

  • inspector/extensions-events-expected.txt:
  • inspector/extensions-events.html:
8:57 AM Changeset in webkit [75716] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Qt build fix.

  • WebCore.pri:
8:42 AM Changeset in webkit [75715] by pfeldman@chromium.org
  • 22 edits
    1 move
    1 add in trunk

2011-01-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: embed injected script into the backend.
https://bugs.webkit.org/show_bug.cgi?id=52312

InjectedScript belongs to the backend of the system and
should be exposed by means of protocol, not InjectedScriptAccess.
This patch makes injected script a part of the backend.
It introduces single manual generation step (xxd -i) that should be
automated by the build scripts for all the platforms.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptSource):
  • inspector/InjectedScriptHost.h:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie):
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/InjectedScript.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone.propertyNamesCallback): (WebInspector.doLoadedDone):
  • inspector/xxd.pl: Added.

2011-01-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: embed injected script into the backend.
https://bugs.webkit.org/show_bug.cgi?id=52312

  • WebKit.grd:
7:49 AM Changeset in webkit [75714] by mnaganov@chromium.org
  • 15 edits in trunk

2011-01-13 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Cleanup after r75613 -- make all UI-facing strings
to be passed directly to WebInspector.UIString

https://bugs.webkit.org/show_bug.cgi?id=52365

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._updateCallback): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies): (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._updateWithCookies):
  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad): (WebInspector.ImageView.prototype._createContentIfNeeded):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkTimeCalculator.prototype.formatValue): (WebInspector.NetworkTransferTimeCalculator.prototype.formatValue): (WebInspector.NetworkTransferDurationCalculator.prototype.formatValue):
  • inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds): (WebInspector.ProfileDataGridNode.prototype.get data):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toUIString): (WebInspector.Resource.Type.toString):
  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewCalculator.prototype.formatValue):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelineCalculator.prototype.formatValue): (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
  • inspector/front-end/utilities.js: ():
  • Scripts/check-inspector-strings:
7:45 AM Changeset in webkit [75713] by commit-queue@webkit.org
  • 5 edits in trunk

2011-01-13 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Need a way to inform the application when a Netscape plugin is created.
https://bugs.webkit.org/show_bug.cgi?id=30179

Added "c" style static method for the application to hook up for
receiving notifications when a plugin is created.

  • plugins/symbian/PluginViewSymbian.cpp: (qtwebkit_setPluginCreatedCallback): (WebCore::PluginView::platformStart):

2011-01-13 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Need a way to inform the application when a Netscape plugin is created.
https://bugs.webkit.org/show_bug.cgi?id=30179

Added "c" style static method for the application to hook up for
receiving notifications when a plugin is created.

  • symbian/bwins/QtWebKitu.def:
  • symbian/eabi/QtWebKitu.def:
7:29 AM Changeset in webkit [75712] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-13 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Eric Seidel.

[Qt] Use a black background color for the video element on Qt Mobile
https://bugs.webkit.org/show_bug.cgi?id=52252

Use black as the background color for the video element on Qt Mobile.

  • css/themeQtMobile.css: (video):
7:12 AM Changeset in webkit [75711] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

2011-01-13 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Eric Seidel.

[Qt] Use a big central media play control button for video element
https://bugs.webkit.org/show_bug.cgi?id=52315

When ChromeClient::requiresFullscreenForVideoPlayback() returns true,
all other control buttons for the video element are hidden, except
a big centralized play button.

No new tests because no client implements requiresFullscreenForVideoPlayback yet.

  • WebCore.pri:
  • css/mediaControlsQtFullscreen.css: Added. (audio): (audio::-webkit-media-controls-panel): (video::-webkit-media-controls-panel): (video:-webkit-full-page-media::-webkit-media-controls-panel): (audio::-webkit-media-controls-mute-button): (video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button): (video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline-container): (video::-webkit-media-controls-timeline-container): (audio::-webkit-media-controls-current-time-display): (video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display): (audio::-webkit-media-controls-timeline): (video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider-container): (video::-webkit-media-controls-volume-slider-container): (audio::-webkit-media-controls-volume-slider): (video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button): (video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
4:07 AM Changeset in webkit [75710] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-01-13 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Paint toggle buttons inconsistent when the object state is indeterminate
https://bugs.webkit.org/show_bug.cgi?id=52361

Check whether the object state is indeterminate to set the flag
GTK_STATE_FLAG_INCONSISTENT before rendering check and radio
buttons.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::paintToggle):
3:58 AM Changeset in webkit [75709] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Gavin Barraclough.

JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap?
https://bugs.webkit.org/show_bug.cgi?id=42756

The FixedVMPool Allocator does not work well on systems where
allocating very large amounts of memory upfront is not reasonable,
like Linux without overcommit enabled. As a workaround, on Linux,
default to the values used in embedded environments (in the MB
range), and only jump to the GB range if we detect at runtime that
overcommit is enabled. Should fix crashes on Linux/x86_64 with
less than 3 or 4GB of RAM.

  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::free): use new variables for VM pool size and coalesce limit. (JSC::ExecutableAllocator::isValid): swap the variables from embedded to generic values at runtime, on linux, if overcommit is enabled. (JSC::ExecutableAllocator::underMemoryPressure): use new variables for VM pool size and coalesce limit.
3:46 AM Changeset in webkit [75708] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

2011-01-13 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249

Make MediaPlayerPrivateQt support a fullscreen player.

No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
So, still skip it for Qt.

  • WebCore.pro:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): (WebCore::MediaPlayerPrivateQt::removeVideoItem): (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
  • platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivateQt::supportsFullscreen): (WebCore::MediaPlayerPrivateQt::mediaPlayer):

2011-01-13 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249

Add a new webkit platform plugin interface to support full screen video handler.

  • Api/qwebkitplatformplugin.h: (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::fullScreenVideo): (WebCore::ChromeClientQt::supportsFullscreenForNode): (WebCore::ChromeClientQt::requiresFullscreenForVideoPlayback): (WebCore::ChromeClientQt::enterFullscreenForNode): (WebCore::ChromeClientQt::exitFullscreenForNode):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/FullScreenVideoQt.cpp: Added. (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt): (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::exitFullScreenForNode): (WebCore::FullScreenVideoQt::aboutToClose): (WebCore::FullScreenVideoQt::mediaPlayer): (WebCore::FullScreenVideoQt::mediaPlayerForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
  • WebCoreSupport/FullScreenVideoQt.h: Added. (WebCore::FullScreenVideoQt::isValid):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebPlugin.cpp: (FullScreenVideoWidget::FullScreenVideoWidget): (FullScreenVideoWidget::event): (FullScreenVideoWidget::keyPressEvent): (FullScreenVideoHandler::FullScreenVideoHandler): (FullScreenVideoHandler::~FullScreenVideoHandler): (FullScreenVideoHandler::requiresFullScreenForVideoPlayback): (FullScreenVideoHandler::enterFullScreen): (FullScreenVideoHandler::exitFullScreen): (WebPlugin::supportsExtension): (WebPlugin::createExtension):
  • examples/platformplugin/WebPlugin.h: (FullScreenVideoWidget::~FullScreenVideoWidget):
  • examples/platformplugin/platformplugin.pro:
  • examples/platformplugin/qwebkitplatformplugin.h: (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
1:50 AM Changeset in webkit [75707] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/8858548> Disable inheritance of text emphasis marks to ruby text
https://bugs.webkit.org/show_bug.cgi?id=52359

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/ruby/text-emphasis.html

  • css/html.css:

(rt):

LayoutTests:

  • fast/ruby/text-emphasis-expected.txt: Added.
  • fast/ruby/text-emphasis.html: Added.
12:39 AM Changeset in webkit [75706] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-13 Hayato Ito <hayato@chromium.org>

Unreviewed, chromium test expectations.

Flaky expectations for html5lib/webkit-resumer.html.

  • platform/chromium/test_expectations.txt:
12:26 AM Changeset in webkit [75705] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74881.
http://trac.webkit.org/changeset/74881
https://bugs.webkit.org/show_bug.cgi?id=52357

The EFL builder has been red for days (Requested by abarth on
#webkit).

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
12:25 AM Changeset in webkit [75704] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Trivial fix after r75682.

Rubber-stamped by David Levin.

  • loader/FrameLoader.cpp: Remove accidentally committed debug code.

(WebCore::FrameLoader::shouldClose):

Jan 12, 2011:

11:58 PM Changeset in webkit [75703] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.5/WebKit2

Merge r74615.

11:50 PM Changeset in webkit [75702] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.5

Versioning.

11:50 PM Changeset in webkit [75701] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.5/WebKit2

Merge r74508.

11:49 PM Changeset in webkit [75700] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.5/WebKit2

Merge r74329.

11:49 PM Changeset in webkit [75699] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.5/WebKit2

Merge r75015.

11:49 PM Changeset in webkit [75698] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.5/WebKit2

Merge r74531.

11:48 PM Changeset in webkit [75697] by mrowe@apple.com
  • 7 edits in tags/Safari-534.15.5/WebKit2

Merge r74514.

11:48 PM Changeset in webkit [75696] by mrowe@apple.com
  • 3 edits in tags/Safari-534.15.5/WebKit2

Merge r74591.

11:48 PM Changeset in webkit [75695] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.5/WebKit2

Merge r75038.

11:47 PM Changeset in webkit [75694] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.5/WebKit2

Merge r74303.

11:47 PM Changeset in webkit [75693] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.5/WebCore

Merge r75660.

11:47 PM Changeset in webkit [75692] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.5/WebCore

Merge r75656.

11:47 PM Changeset in webkit [75691] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.5/WebCore

Merge r75653.

11:46 PM Changeset in webkit [75690] by mrowe@apple.com
  • 3 edits in tags/Safari-534.15.5/WebCore

Merge r75652.

11:46 PM Changeset in webkit [75689] by mrowe@apple.com
  • 3 edits in tags/Safari-534.15.5/WebCore

Merge r75649.

11:46 PM Changeset in webkit [75688] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.5/WebCore

Merge r75644.

11:45 PM Changeset in webkit [75687] by mrowe@apple.com
  • 4 edits in tags/Safari-534.15.5/WebCore

Merge r75643.

11:45 PM Changeset in webkit [75686] by mrowe@apple.com
  • 14 edits in tags/Safari-534.15.5/WebCore

Merge r75639.

11:45 PM Changeset in webkit [75685] by mrowe@apple.com
  • 3 edits
    2 adds in tags/Safari-534.15.5

Merge r75472.

11:44 PM Changeset in webkit [75684] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.5/WebCore

Merge r75580.

11:27 PM Changeset in webkit [75683] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-12 Adam Barth <abarth@webkit.org>

Removing this test from the Skipped list caused the next test
alphabetically to fail instead.

  • platform/mac/Skipped:
11:09 PM Changeset in webkit [75682] by mjs@apple.com
  • 5 edits in trunk

2011-01-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add beforeunload support to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=52353

  • platform/mac-wk2/Skipped: Unskip a test that was failing solely due to missing beforeunload support.

2011-01-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add beforeunload support to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=52353


This makes a number of currently failing tests pass.

  • WebKitTestRunner/TestController.cpp: (WTR::runBeforeUnloadConfirmPanel): (WTR::createOtherPage): (WTR::TestController::initialize):
10:49 PM Changeset in webkit [75681] by tkent@chromium.org
  • 3 edits
    4 adds in branches/chromium/597

Merge 75676
Because 597 branch doesn't have FormAssociatedElement.cpp, this change
was applied manually. The actual code change is in
WebCore/html/HTMLFormControlElement.cpp attributeChanged().

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
https://bugs.webkit.org/show_bug.cgi?id=51905

Calls unregisterFormElementWithFormAttribute() when 'form' attribute
is removed.

Tests: fast/forms/form-associated-element-crash.html

fast/forms/form-associated-element-crash2.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::formAttributeChanged):

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
https://bugs.webkit.org/show_bug.cgi?id=51905

Add test for crash when modifying the form attribute of a form
associated element before removing it.

  • fast/forms/form-associated-element-crash-expected.txt: Added.
  • fast/forms/form-associated-element-crash.html: Added.
  • fast/forms/form-associated-element-crash2-expected.txt: Added.
  • fast/forms/form-associated-element-crash2.html: Added.

BUG=

10:35 PM Changeset in webkit [75680] by tkent@chromium.org
  • 4 edits
    2 adds in branches/chromium/597

Merge 75675
Because 597 branch doesn't have FormAssociatedElement.{cpp,h}, this
change was manually applied and the ChangeLog entries are not
accurate.

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura

M_formElementsWithFormAttribute not cleared when Node is moved to another document.
https://bugs.webkit.org/show_bug.cgi?id=51418

Calls unregisterFormElementWithFormAttribute() when form associated elements
are moved to another document.

Test: fast/forms/change-form-element-document-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::willMoveToNewOwnerDocument): Added.
  • html/FormAssociatedElement.h: Added willMoveToNewOwnerDocument().
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::willMoveToNewOwnerDocument): Added.
  • html/HTMLFormControlElement.h: Added willMoveToNewOwnerDocument().
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::willMoveToNewOwnerDocument): Added.
  • html/HTMLObjectElement.h: Added willMoveToNewOwnerDocument().
  • html/HTMLPlugInImageElement.h: Moves willMoveToNewOwnerDocument() to protected.

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura

M_formElementsWithFormAttribute not cleared when Node is moved to another document.
https://bugs.webkit.org/show_bug.cgi?id=51418

Added test for crash when moving form elements from one document to another.

  • fast/forms/change-form-element-document-crash-expected.txt: Added.
  • fast/forms/change-form-element-document-crash.html: Added.

BUG=http://code.google.com/p/chromium/issues/detail?id=65577

9:55 PM Changeset in webkit [75679] by hayato@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-12 Hayato Ito <hayato@chromium.org>

Unreviewed test expectations files fix.

Fix a culprit revision number.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
8:59 PM Changeset in webkit [75678] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-12 Hayato Ito <hayato@chromium.org>

Unreviewed chromium-gpu test expectations fix.

Disable canvas-large-dimensions.html after r75639.

  • platform/chromium-gpu/test_expectations.txt:
8:51 PM Changeset in webkit [75677] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r69831): focus() in onkeypress discards input (affects chaseonline.chase.com)
https://bugs.webkit.org/show_bug.cgi?id=52241

The bug was caused by RenderTextControl::selection's creating a Range with m_insertText
which is a shadow DOM div as both start and end containers. Fixed the bug by traversing
through the descendents of m_innerText and using the right start and end containers to
create a Range.

Test: fast/forms/focus-change-on-keypress.html

  • rendering/RenderTextControl.cpp: (WebCore::setContainerAndOffsetForRange): Added; a helper function. (WebCore::RenderTextControl::selection): See above.

2011-01-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r69831): focus() in onkeypress discards input (affects chaseonline.chase.com)
https://bugs.webkit.org/show_bug.cgi?id=52241

Added a test to ensure WebKit inserts the character typed by a user when focus's node
is changed by a presskey event handler.

  • fast/forms/focus-change-on-keypress-expected.txt: Added.
  • fast/forms/focus-change-on-keypress.html: Added.
7:55 PM Changeset in webkit [75676] by tkent@chromium.org
  • 3 edits
    4 adds in trunk

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
https://bugs.webkit.org/show_bug.cgi?id=51905

Calls unregisterFormElementWithFormAttribute() when 'form' attribute
is removed.

Tests: fast/forms/form-associated-element-crash.html

fast/forms/form-associated-element-crash2.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::formAttributeChanged):

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
https://bugs.webkit.org/show_bug.cgi?id=51905

Add test for crash when modifying the form attribute of a form
associated element before removing it.

  • fast/forms/form-associated-element-crash-expected.txt: Added.
  • fast/forms/form-associated-element-crash.html: Added.
  • fast/forms/form-associated-element-crash2-expected.txt: Added.
  • fast/forms/form-associated-element-crash2.html: Added.
7:48 PM Changeset in webkit [75675] by tkent@chromium.org
  • 9 edits
    2 adds in trunk

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

M_formElementsWithFormAttribute not cleared when Node is moved to another document.
https://bugs.webkit.org/show_bug.cgi?id=51418

Calls unregisterFormElementWithFormAttribute() when form associated elements
are moved to another document.

Test: fast/forms/change-form-element-document-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::willMoveToNewOwnerDocument): Added.
  • html/FormAssociatedElement.h: Added willMoveToNewOwnerDocument().
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::willMoveToNewOwnerDocument): Added.
  • html/HTMLFormControlElement.h: Added willMoveToNewOwnerDocument().
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::willMoveToNewOwnerDocument): Added.
  • html/HTMLObjectElement.h: Added willMoveToNewOwnerDocument().
  • html/HTMLPlugInImageElement.h: Moves willMoveToNewOwnerDocument() to protected.

2011-01-12 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

M_formElementsWithFormAttribute not cleared when Node is moved to another document.
https://bugs.webkit.org/show_bug.cgi?id=51418

Added test for crash when moving form elements from one document to another.

  • fast/forms/change-form-element-document-crash-expected.txt: Added.
  • fast/forms/change-form-element-document-crash.html: Added.
7:26 PM Changeset in webkit [75674] by rniwa@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Unreviwed. Added the missing bug id for r75672.

7:23 PM Changeset in webkit [75673] by kbalazs@webkit.org
  • 4 edits in trunk/WebKit2

Unreviewed.

Getting rid of the unused 'viewportSize' argument in QWKPagePrivate:init.
The argument is unused since http://trac.webkit.org/changeset/75468.

  • UIProcess/API/qt/qgraphicswkview.cpp:

(QGraphicsWKView::QGraphicsWKView):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::init):

  • UIProcess/API/qt/qwkpage_p.h:
7:17 PM Changeset in webkit [75672] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-01-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Removed instantiation of legacy editing positions.
Calls to Position::Position are replaced by calls to Position's convenience functions.

Also added firstPositionInOrBeforeNode and lastPositionInOrAfterNode,
which are functions that return firstPositionInNode and lastPositionInNode respectively
when the specified node can have children for editing purpose and return positionBeforeNode
and positionAfterNode respectively otherwise. They can be used to guarantee that we never
create a bogus position like [img, 0] or [br, 0].

No tests are added since this is a cleanup.

  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::formatSelection):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::nodeFullySelected): (WebCore::ApplyStyleCommand::nodeFullyUnselected): (WebCore::ApplyStyleCommand::splitTextAtStart): (WebCore::ApplyStyleCommand::splitTextAtEnd): (WebCore::ApplyStyleCommand::splitTextElementAtStart): (WebCore::ApplyStyleCommand::splitTextElementAtEnd): (WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode): (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): (WebCore::ApplyStyleCommand::computedFontSize): (WebCore::ApplyStyleCommand::joinChildTextNodes):
  • editing/ApplyStyleCommand.h:
  • editing/htmlediting.h: (WebCore::firstPositionInOrBeforeNode): Added. (WebCore::lastPositionInOrAfterNode): Added.
7:15 PM Changeset in webkit [75671] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.5

New tag.

6:50 PM Changeset in webkit [75670] by andersca@apple.com
  • 3 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement DrawingAreaImpl::scroll
https://bugs.webkit.org/show_bug.cgi?id=52346

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::scroll): If there is already an active scroll, compute the area of both scroll rects and invalidate the smallest one. Compute a new dirty region if necessary and also add the scroll repaint region to the dirty region.

(WebKit::DrawingAreaImpl::display):
Reset the scroll area and scroll delta.

  • WebProcess/WebPage/DrawingAreaImpl.h: Add scroll area and scroll delta member variables.
6:34 PM Changeset in webkit [75669] by andersca@apple.com
  • 3 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Region improvements
https://bugs.webkit.org/show_bug.cgi?id=52344

  • Platform/Region.cpp: (WebKit::Region::Shape::move): (WebKit::Region::move): Change Region::move to take an IntSize.
  • Platform/Region.h: (WebKit::intersect): (WebKit::subtract): (WebKit::move): Add convenience functions.
6:01 PM Changeset in webkit [75668] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Another build fix.

  • platform/mac/WheelEventMac.mm:

(WebCore::phaseForEvent):

5:58 PM Changeset in webkit [75667] by rniwa@webkit.org
  • 2 edits in trunk/WebKit2

2011-01-12 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Qt build fix for r75661

  • Shared/WebEvent.h: Don't declare phase() on non-Mac platforms.
5:47 PM Changeset in webkit [75666] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-12 Justin Schuh <jschuh@chromium.org>

Unreviewed chromium test expectations fix.

Disable canvas-large-dimensions.html after r75639.

  • platform/chromium/test_expectations.txt:
5:45 PM Changeset in webkit [75665] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/mac/WheelEventMac.mm:

(WebCore::phaseForEvent):

5:39 PM Changeset in webkit [75664] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove premature optimization from SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=52283

As far as I can tell, this optimization isn't necessary. I'm slightly
unsure which benchmarks to run to demonstrate this numerically, but
none of the benchmarks Chromium tracks were affected by adding a
similar check for "display-isolated" schemes.

  • platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
5:38 PM Changeset in webkit [75663] by enrica@apple.com
  • 1 edit in trunk/Source/WebCore/platform/mac/WheelEventMac.mm

Build fix, unreviewed.

5:34 PM Changeset in webkit [75662] by Beth Dakin
  • 9 edits in trunk

Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
Expose fixed layout through WebKit SPI
-and corresponding-
<rdar://problem/8844464>

Reviewed by Anders Carlsson.

Source/WebCore:

And now with getters!

  • WebCore.exp.in:

WebKit/mac:

And now with getters!

  • WebView/WebView.mm:

(-[WebView _useFixedLayout]):
(-[WebView _fixedLayoutSize]):

  • WebView/WebViewPrivate.h:

WebKit2:

And now with getters!

  • UIProcess/API/C/WKPage.cpp:

(WKPageUseFixedLayout):
(WKPageFixedLayoutSize):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::useFixedLayout):
(WebKit::WebPageProxy::fixedLayoutSize):

5:25 PM Changeset in webkit [75661] by weinig@apple.com
  • 8 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=52337
PlatformWheelEvent should know about the scroll phase on the Mac

Reviewed by Anders Carlsson.

Source/WebCore:

Add a phase parameter on Mac PlatformWheelEvents.

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::phase):

  • platform/mac/WheelEventMac.mm:

(WebCore::phaseForEvent):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit2:

Add a phase parameter on Mac WebWheelEvent and pipe it down to PlatformWheelEvent.

  • Shared/WebEvent.h:

(WebKit::WebWheelEvent::phase):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):

  • Shared/mac/WebEventFactory.mm:

(WebKit::phaseForEvent):
(WebKit::WebEventFactory::createWebWheelEvent):

5:24 PM Changeset in webkit [75660] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Unreviewed.

A couple of lines of the patch for https://bugs.webkit.org/show_bug.cgi?id=52321
were omitted.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
5:02 PM Changeset in webkit [75659] by andersca@apple.com
  • 12 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of an unneeded parameter from DrawingArea::scroll
https://bugs.webkit.org/show_bug.cgi?id=52336

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::scroll):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::scroll):
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::scroll):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::scroll):
  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::scroll):
  • WebProcess/WebPage/TiledDrawingArea.h:
4:51 PM Changeset in webkit [75658] by mihaip@chromium.org
  • 3 edits in trunk/WebKit/chromium

2011-01-12 Mihai Parparita <mihaip@chromium.org>

Reviewed by David Levin.

[Chromium] Remove PartScrollbarHoriztonalTrack
https://bugs.webkit.org/show_bug.cgi?id=52329

Remove PartScrollbarHoriztonalTrack now that usages of it were removed
with http://crrev.com/71249.

  • DEPS:
  • public/linux/WebThemeEngine.h:
4:41 PM Changeset in webkit [75657] by andersca@apple.com
  • 5 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get the new drawing area painting to the screen
https://bugs.webkit.org/show_bug.cgi?id=52331

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Call setViewNeedsDisplay on all the update rects.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setViewNeedsDisplay): Call through to the page client.

(WebKit::WebPageProxy::processDidCrash):
Null out the drawing area proxy.


  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::paint): Paint.
4:35 PM Changeset in webkit [75656] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Getting rid of an assert that was causing build failures that turns out not to be needed.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintsWithTransform):
4:22 PM Changeset in webkit [75655] by mjs@apple.com
  • 4 edits in trunk/Tools

2011-01-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Detect, identify and recover from WebProcess crashes in run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=52330

  • Scripts/old-run-webkit-tests: Detect when the regression test tool reports a web process crash.
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set up a processDidCrash callback. (WTR::TestController::processDidCrash): Report that the Web process crashed.
  • WebKitTestRunner/TestController.h:
4:20 PM Changeset in webkit [75654] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-12 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

fix assorted bugs with expansion lines
https://bugs.webkit.org/show_bug.cgi?id=52326

-Clicking "all" would collapse whitespace in the expanded lines.
-Converted the remaining line creation code to using the DOM.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
4:14 PM Changeset in webkit [75653] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Another fix for Gtk

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintsWithTransform):
4:08 PM Changeset in webkit [75652] by cmarrin@apple.com
  • 4 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Fix for Gtk and Windows builds

  • page/Frame.cpp: (WebCore::Frame::scalePage):
  • page/Frame.h:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp: (PlatformCALayer::contentsScale): (PlatformCALayer::setContentsScale):
3:52 PM Changeset in webkit [75651] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

UNreviewed.

Fix for the Windows build

  • platform/graphics/ca/win/PlatformCALayerWin.cpp: (contentsScale): (setContentsScale):
3:48 PM Changeset in webkit [75650] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-12 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

review tool formatted diff doesn't match the uploaded diff
https://bugs.webkit.org/show_bug.cgi?id=51960

PrettyPatch works just fine if there is no newline at the end of the file.

  • attachment.cgi:
3:41 PM Changeset in webkit [75649] by cmarrin@apple.com
  • 3 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Another build fix

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::setContentsScale):
3:35 PM Changeset in webkit [75648] by mdelaney@apple.com
  • 3 edits
    2 adds in trunk

2011-01-11 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Max area bound needed in creation of IOSurface in ImageBufferCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=52172

Tests: fast/canvas/canvas-large-dimensions.html

  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):

2011-01-11 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Max area bound needed in creation of IOSurface in ImageBufferCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=52172

  • fast/canvas/canvas-large-dimensions.html: Added.
  • fast/canvas/canvas-large-dimensions-expected.txt: Added.
3:29 PM Changeset in webkit [75647] by andersca@apple.com
  • 6 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

More work on getting the drawing area proxy to paint
https://bugs.webkit.org/show_bug.cgi?id=52328

  • UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]): Handle the new drawing area.
  • UIProcess/BackingStore.cpp: (WebKit::BackingStore::BackingStore): Assert that the size isn't empty.


  • UIProcess/BackingStore.h:
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::incorporateUpdate): Paint all update rects into the bitmap context.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::display): Create a handle so the shareable bitmap will actually be transferred over.
3:27 PM Changeset in webkit [75646] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-12 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

Bugzilla: Add keyboard shortcuts to jump to next change
https://bugs.webkit.org/show_bug.cgi?id=52305

Comments and diff blocks go in the same queue. If you have a
comment focused, then j/k will focus the next/prev diff block
with respect to that comment.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
3:27 PM Changeset in webkit [75645] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-12 Daniel Bates <dbates@rim.com>

And Benjamin C Meyer <bmeyer@rim.com>

Build fix when building with Inspector disabled
https://bugs.webkit.org/show_bug.cgi?id=52313

After changeset 75604 <http://trac.webkit.org/changeset/75604> it's not
possible to build when the Inspector is disabled.

  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::updateApplicationCacheStatus): Fix build breakage when building with Inspector disabled and Offline Web Applications enabled by moving macro guard condition ENABLE(INSPECTOR) && ENABLE(OFFLINE_WEB_APPLICATIONS) into function body. This makes us also consistent with the form we use for InspectorInstrumentation::networkStateChanged() and other InspectorInstrumentation functions.
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData): Fix build breakage when building with Inspector disabled by adding ENABLE(INSPECTOR) guard around code that references the instance variable ApplicationCacheGroup::m_currentResourceIdentifier as this variable only exists when building with the Inspector. (WebCore::ApplicationCacheGroup::didFinishLoading): Ditto. (WebCore::ApplicationCacheGroup::didFail): Ditto.
3:12 PM Changeset in webkit [75644] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Fix a build issue from http://trac.webkit.org/changeset/75639.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::contentsScale): (WebCore::GraphicsLayer::setContentsScale):
3:06 PM Changeset in webkit [75643] by cmarrin@apple.com
  • 4 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Reviewed by Kevin Decker.

Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
rdar://problem/8824974

This prevents the rootLayer (with the WebKit rendered content) from going becoming
a tiled layer when zoomed, and when there is other layered content on the page.
This speeds up zooming a lot and avoids some buggy behavior in CA with a very large
number of layers.


  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintsWithTransform):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintingGoesToWindow):
2:58 PM Changeset in webkit [75642] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-12 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

show shared lines on both sides in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52308

We were appending the same DOM node twice. Instead, make
the from column a clone of the original node.

  • code-review.js:
2:44 PM Changeset in webkit [75641] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::incorporateUpdate):

2:34 PM Changeset in webkit [75640] by andersca@apple.com
  • 6 edits
    1 add in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Begin stubbing out some more BackingStore member functions
https://bugs.webkit.org/show_bug.cgi?id=52323

  • UIProcess/BackingStore.cpp: (WebKit::BackingStore::~BackingStore): This was accidentally made into a constructor; it should be a destructor.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::paint): Call the backing store.

(WebKit::DrawingAreaProxyImpl::update):
Incorporate the update.

(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
Create the backing store if needed and incorporate the update.

  • UIProcess/mac/BackingStoreMac.mm: Added. (WebKit::BackingStore::platformInitialize): Create a bitmap context.

(WebKit::BackingStore::paint):
(WebKit::BackingStore::incorporateUpdate):
Add stubs.

  • WebKit2.xcodeproj/project.pbxproj: Add BackingStoreMac.mm
2:27 PM Changeset in webkit [75639] by cmarrin@apple.com
  • 14 edits in trunk/Source/WebCore

2011-01-12 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.


Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
rdar://problem/8824974

When scaled, WebKit renders the page content at the scaled up size, so there are no
scaling artifacts. But content drawn into a layer's backing store does not scale up.
This is made worse by the fact that the root page contents become layered when there
are other accelerated compositing layers present (video, plugins, etc.).


Plumb scaling factor from Frame::scalePage() down into all layers with content. It
eventually calls CALayer::setContentsScale which renders to a backing store whose dimensions
are scaled, causing them to render larger and appear pixel perfect at the scaled
page size.


  • page/Frame.cpp: (WebCore::Frame::updateContentsScale): (WebCore::Frame::scalePage):
  • page/Frame.h:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setContentsScale): (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
  • platform/graphics/ca/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::contentsScale):
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::contentsScale): (PlatformCALayer::setContentsScale):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateContentsScale):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::updateMaskLayer): (WebCore::RenderLayerBacking::updateContentsScale):
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateContentsScale):
  • rendering/RenderLayerCompositor.h:


2:26 PM Changeset in webkit [75638] by tony@chromium.org
  • 8 edits
    2 adds in trunk/LayoutTests

2011-01-12 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

output the value of input and textarea nodes when using dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=52319

  • editing/inserting/5607069-2-expected.txt:
  • editing/inserting/5607069-3-expected.txt:
  • editing/selection/dump-as-markup-expected.txt:
  • editing/selection/dump-as-markup-form-text-expected.txt: Added.
  • editing/selection/dump-as-markup-form-text.html: Added.
  • fast/parser/object-with-textarea-fallback-expected.txt:
  • html5lib/runner.html:
  • html5lib/webkit-resumer.html:
  • resources/dump-as-markup.js: (Markup.useHTML5libOutputFormat): Add a flag for html5lib compatibility (Markup._get):
1:58 PM Changeset in webkit [75637] by senorblanco@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-01-12 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Fix DrawingBuffer issues for depth/stencil, extensions, etc.
https://bugs.webkit.org/show_bug.cgi?id=52310

1) GL_TEXTURE is not a valid argument to glFramebufferTexture2D()
(should be GL_TEXTURE_2D).
2) Support for the multisampling extension was being checked after
the DrawingBuffer constructor was called, which calls multisample()
to check for the extension.
3) If depth or stencil is set, the corresponding framebuffers must
be created in the DrawingBuffer constructor.
4) GL_DEPTH_STENCIL is not a valid framebuffer internal type in
GLES2. Must use GL_OES_DEPTH24_STENCIL8, and check for the
OES_packed_depth_stencil extension.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): Record the extension support in the constructor. Create all the secondary drawing buffers (for multisampling, depth/stencil).
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::create): Check for the extensions before calling the DrawingBuffer constructor. (WebCore::DrawingBuffer::createSecondaryBuffers): Refactor creation of the secondary buffers from DrawingBufferMac.mm to here. (WebCore::DrawingBuffer::reset): Use DEPTH24_STENCIL8 format, not DEPTH_STENCIL. Use DEPTH_COMPONENT16, not DEPTH_COMPONENT. Use GL_TEXTURE_2D, not GL_TEXTURE (for glFramebufferTexture2D).
  • platform/graphics/gpu/DrawingBuffer.h: Refactor createSecondaryBuffers(). Add extension support arguments to constructor. Add support for packed_depth_stencil extension.
  • platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): Record extension support in constructor. Refactor out creation of secondary buffers.
1:12 PM Changeset in webkit [75636] by robert@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-01-12 Robert Hogan <robert@webkit.org>

Unreviewed, add expected results.

[Qt] Add new expected results from r75632

https://bugs.webkit.org/show_bug.cgi?id=42887

  • platform/qt/fast/forms/search-display-none-cancel-button-expected.txt: Added.
  • platform/qt/fast/forms/search-placeholder-value-changed-expected.txt: Added.
  • platform/qt/fast/forms/search-rtl-expected.txt: Added.
  • platform/qt/fast/forms/search-styled-expected.txt: Added.
  • platform/qt/fast/forms/search-transformed-expected.txt: Added.
  • platform/qt/fast/forms/search-zoomed-expected.txt: Added.
1:04 PM Changeset in webkit [75635] by Beth Dakin
  • 15 edits in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
fixed layout through WebKit SPI
-and corresponding-
<rdar://problem/8844464>

Reviewed by Anders Carlsson.

Source/WebCore:

Export symbols for ScrollView::setUseFixedLayout() and
ScrollView::setFixedLayoutSize()

  • WebCore.exp.in:

WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _setUseFixedLayout:]):
(-[WebView _setFixedLayoutSize:]):

  • WebView/WebViewPrivate.h:

WebKit2:

Store useFixedLayout and fixedLayoutSize in the
WebPageCreationParameters and the WebPageProxy.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetUseFixedLayout):
(WKPageSetFixedLayoutSize):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setUseFixedLayout):
(WebKit::WebPageProxy::setFixedLayoutSize):
(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUseFixedLayout):
(WebKit::WebPage::setFixedLayoutSize):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
1:03 PM Changeset in webkit [75634] by robert@webkit.org
  • 5 edits in trunk/LayoutTests

2011-01-12 Robert Hogan <robert@webkit.org>

Unreviewed, update expected results.

[Qt] Update expected results from r75632

https://bugs.webkit.org/show_bug.cgi?id=42887

  • platform/qt/fast/css/pseudo-cache-stale-expected.txt:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
12:53 PM Changeset in webkit [75633] by andersca@apple.com
  • 2 edits
    2 adds in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Beth Dakin.

Add BackingStore class
https://bugs.webkit.org/show_bug.cgi?id=52318

  • UIProcess/BackingStore.cpp: Added. (WebKit::BackingStore::create): (WebKit::BackingStore::BackingStore):
  • UIProcess/BackingStore.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
12:27 PM Changeset in webkit [75632] by robert@webkit.org
  • 9 edits in trunk

2011-01-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Search input field doesn't have cancel button

Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.

Unskip a bunch of search field related tests that pass now:

fast/forms/search-cancel-button-mouseup.html
fast/forms/search-rtl.html
fast/forms/search-abs-pos-cancel-button.html
fast/forms/search-styled.html
fast/forms/search-transformed.html
fast/forms/search-zoomed.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-display-none-cancel-button.html
fast/forms/search-placeholder-value-changed.html
fast/repaint/search-field-cancel.html
fast/forms/search-cancel-button-events.html

https://bugs.webkit.org/show_bug.cgi?id=42887

  • platform/qt/Skipped:

2011-01-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Search input field doesn't have cancel button

Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.

Unskip a bunch of search field related tests that pass now:

fast/forms/search-cancel-button-mouseup.html
fast/forms/search-rtl.html
fast/forms/search-abs-pos-cancel-button.html
fast/forms/search-styled.html
fast/forms/search-transformed.html
fast/forms/search-zoomed.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-display-none-cancel-button.html
fast/forms/search-placeholder-value-changed.html
fast/repaint/search-field-cancel.html
fast/forms/search-cancel-button-events.html

https://bugs.webkit.org/show_bug.cgi?id=42887

  • platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::paintSearchField): (WebCore::RenderThemeQt::adjustSearchFieldStyle): (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeQt::convertToPaintingRect): (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
  • platform/qt/RenderThemeQt.h:

2011-01-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Search input field doesn't have cancel button

Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.

https://bugs.webkit.org/show_bug.cgi?id=42887

  • Api/qwebsettings.cpp: (graphics):
  • Api/qwebsettings.h:
12:12 PM Changeset in webkit [75631] by beidson@apple.com
  • 15 edits in trunk/WebKit2

<rdar://problem/8837307>, <rdar://problem/8637038>, and https://bugs.webkit.org/show_bug.cgi?id=52248
Back/forward list recovery after a WebProcess crash is crashy itself.

Reviewed by Sam Weinig.

Add an isEmpty() accessor so the WebProcess knows if it is actually restoring a session:

  • Shared/SessionState.cpp:

(WebKit::SessionState::isEmpty):

  • Shared/SessionState.h:

Keep track of the highest used itemID so a relaunched WebProcess can later be informed:

  • Shared/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::highedUsedItemID):

  • Shared/WebBackForwardListItem.h:
  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::generateHistoryItemID):
(WebKit::WebBackForwardListProxy::setHighestItemIDFromUIProcess):
(WebKit::WebBackForwardListProxy::addItemFromUIProcess): Remove a now-invalid ASSERT, as the UIProcess

now tells the WebProcess that a previous WebProcess created.

  • WebProcess/WebPage/WebBackForwardListProxy.h:

Encode/decode data relevant to restoring a session on WebPage creation:

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:

If the WebProcess has crashed since the last load, change reload and the various back/forward APIs to
update the current back/forward item (if necessary) then relaunch the process:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::reattachToWebProcess): Renamed from "relaunch()" and made private.
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:

Rename "RestoreSession" to "RestoreSessionAndNavigateToCurrentItem"

  • WebProcess/WebPage/WebPage.messages.in:
  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData):

Restore a session on page creation if the parameters include it:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Call restoreSession if session state exists.
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem):
(WebKit::WebPage::restoreSession):

  • WebProcess/WebPage/WebPage.h:
12:11 PM Changeset in webkit [75630] by andersca@apple.com
  • 9 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Send Update and DidUpdate messages
https://bugs.webkit.org/show_bug.cgi?id=52316

  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::update): Add empty stub.
  • UIProcess/DrawingAreaProxy.messages.in: Add Update message.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::update): Just send back a DidUpdate message.
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::didUpdate): Add empty stub.
  • WebProcess/WebPage/DrawingArea.messages.in: Add DidUpdate message.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::didUpdate): Call display().

(WebKit::DrawingAreaImpl::display):
Send an Update message.

12:07 PM Changeset in webkit [75629] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-12 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: cookie table is multiplied after repeated switching to cookies tab in network item view
Only create cookiesTable is it hasn't been done yet.
https://bugs.webkit.org/show_bug.cgi?id=52303

  • inspector/front-end/ResourceCookiesView.js: (WebInspector.ResourceCookiesView.prototype.show):
11:41 AM Changeset in webkit [75628] by levin@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style -- close_expression function doesn't work correctly.
https://bugs.webkit.org/show_bug.cgi?id=52272

Reviewed by Shinichiro Hamaji.

  • Scripts/webkitpy/style/checkers/cpp.py:

(Position.str): Added a way to convert it to a string which is useful in tests.
(Position.cmp): Added a way to compare Position which is useful in tests and
generally useful (for upcoming code changes).
(close_expression): Changed to use Position for input and output.
Also, fixed many bugs such as only working correctly for parenthesis,
not working correctly if given an offset in a line and not finding
the real closing element if there were multiple closing elements in
the same line.
(detect_functions): Adjusted due to the change in arguments for
close_expression.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTestBase.assert_positions_equal): Added a way to verify that
two positions are the same.
(CppStyleTest.test_position): Added tests for the str_ and cmp methods.
(CppStyleTest.test_close_expression): Added tests to catch the issues
that were fixed.

11:41 AM Changeset in webkit [75627] by andersca@apple.com
  • 8 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make the new drawing area actually draw something
https://bugs.webkit.org/show_bug.cgi?id=52314

  • Shared/UpdateInfo.cpp: (WebKit::UpdateInfo::encode): (WebKit::UpdateInfo::decode): Encode and decode newly added fields.
  • Shared/UpdateInfo.h: Add a vector of update rects and a handle for the sharable bitmap.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::display): Get the individual rects from the region and paint them into the shareable bitmap.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::mainFrameHasCustomRepresentation):
  • WebProcess/WebPage/WebPage.h: Add helper function.
  • WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp: (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk): Use helper function.
11:25 AM Changeset in webkit [75626] by commit-queue@webkit.org
  • 13 edits in trunk/Tools

2011-01-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75576.
http://trac.webkit.org/changeset/75576
https://bugs.webkit.org/show_bug.cgi?id=52304

broke rebaseline-chromium-webkit-test (Requested by thakis on
#webkit).

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
11:24 AM Changeset in webkit [75625] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Add new Yarr.h header to the list file.

  • GNUmakefile.am: ditto.
10:57 AM Changeset in webkit [75624] by andersca@apple.com
  • 2 edits
    2 adds in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add UpdateInfo class
https://bugs.webkit.org/show_bug.cgi?id=52306

  • Shared/UpdateInfo.cpp: Added. (WebKit::UpdateInfo::encode): (WebKit::UpdateInfo::decode):
  • Shared/UpdateInfo.h: Added. (WebKit::UpdateInfo::UpdateInfo):
  • WebKit2.xcodeproj/project.pbxproj:
10:55 AM Changeset in webkit [75623] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-01-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
https://bugs.webkit.org/show_bug.cgi?id=52307

  • Scripts/old-run-webkit-tests:
10:28 AM Changeset in webkit [75622] by pfeldman@chromium.org
  • 2 edits in branches/chromium/597/WebCore/inspector

Follow up to r75606, fixing compilation (explicit .get() in cast + transitive import).

10:28 AM Changeset in webkit [75621] by thakis@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-01-12 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Remove now-unnecessary vista-specific baseline.
https://bugs.webkit.org/show_bug.cgi?id=52105

  • platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png: Removed.
10:19 AM Changeset in webkit [75620] by andersca@apple.com
  • 4 edits in trunk/WebKit2

2011-01-12 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

More work on the new drawing area implementation
https://bugs.webkit.org/show_bug.cgi?id=52302

  • Platform/Region.cpp: (WebKit::Region::Shape::segments_end): segments_end could end up returning an iterator that is one element past the Vector data, so we can't use operator[] since that will assert.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize the timer.

(WebKit::DrawingAreaImpl::setNeedsDisplay):
Unite the rect with the dirty region and schedule a display.

(WebKit::DrawingAreaImpl::setSize):
Tell the web page to resize.

(WebKit::DrawingAreaImpl::scheduleDisplay):
Start a display timer if needed.

(WebKit::DrawingAreaImpl::display):
Add a stub.

10:11 AM Changeset in webkit [75619] by Martin Robinson
  • 6 edits in trunk

2011-01-12 Koan-Sin Tan <koansin.tan@gmail.com>

Reviewed by Martin Robinson.

[Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=50867

  • config.h: Don't disallow ctype for (OS(DARWIN) && PLATFORM(GTK)) Many GTK+ related files include <libintl.h> or <glib/gi18n-lib.h>. On Mac, <libintl.h> includes <xlocale.h>. <xclocale.h> includes <xlocale/_ctype.h>, which uses isacii().
  • platform/UUID.cpp: (WebCore::createCanonicalUUIDString): For OS(DARWIN) && !PLATFORM(CF) use the Chromium Linux UUID generation.

2011-01-12 Koan-Sin Tan <koansin.tan@gmail.com>

Reviewed by Martin Robinson.

[Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=50867

Fixed library extention for Mac in webkitdirs.pm and type conflict in
TestNetscapePlugin.cpp

  • GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
  • Scripts/webkitdirs.pm:
9:57 AM Changeset in webkit [75618] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-12 Justin Schuh <jschuh@chromium.org>

Unreviewed expectatinos update.

Excluding SVG test for sporadic image failure.

  • platform/chromium/test_expectations.txt:
9:45 AM Changeset in webkit [75617] by Martin Robinson
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-12 Martin Robinson <mrobinson@igalia.com>

Missing Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h in WebKitGtk tarball
https://bugs.webkit.org/show_bug.cgi?id=52299

  • GNUmakefile.am: Fix the GTK+ build on ARMv7 by including missing source files in the source list.
9:31 AM Changeset in webkit [75616] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-12 Justin Schuh <jschuh@chromium.org>

Unreviewed chromium expectations update.

Added chromium win to exclusion for bug 48164.

  • platform/chromium/test_expectations.txt:
9:09 AM Changeset in webkit [75615] by Simon Fraser
  • 8 edits in trunk

2011-01-12 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel.

[CSS Gradients] One color stop should not paint anything for linear-gradient
https://bugs.webkit.org/show_bug.cgi?id=52259

Share color stop parsing code between linear and radial gradients.
Consider the gradient invalid if it has less than two color stops.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseLinearGradient): (WebCore::CSSParser::parseRadialGradient): (WebCore::CSSParser::parseGradientColorStops):
  • css/CSSParser.h:
9:05 AM Changeset in webkit [75614] by bfulgham@webkit.org
  • 1 edit
    1 move in trunk/WebKit2

Unreviewed build fix after r75527. Rename 'BackingStoreCairo.cpp'
to 'ShareableBitmapCairo.cpp' to match VS project changes.

  • Shared/cairo/BackingStoreCairo.cpp: Removed.
  • Shared/cairo/ShareableBitmapCairo.cpp: Copied from Shared/cairo/BackingStoreCairo.cpp.
8:42 AM Changeset in webkit [75613] by mnaganov@chromium.org
  • 8 edits
    1 add in trunk

2011-01-12 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Add check-inspector-strings script.
Fix inconsistencies in Inspector strings found by the script.

https://bugs.webkit.org/show_bug.cgi?id=52295

  • English.lproj/localizedStrings.js:
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceRevisionTreeElement):
  • inspector/front-end/utilities.js: ():
  • Scripts/check-inspector-strings: Added.
8:21 AM Changeset in webkit [75612] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-12 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix WML compilation on Mac.

  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::setValueForUser): (WebCore::WMLInputElement::initialize): (WebCore::WMLInputElement::validateInputMask):
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::listBoxSelectItem):
8:07 AM Changeset in webkit [75611] by jschuh@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-12 Justin Schuh <jschuh@chromium.org>

Unreviewed build fix for debug strict compiles.

Use fprintf for debug statements instead of fwrite, which caused compile failures
in debug strict mode because of failure to check the fwrite return value.

No behavior changed.

  • rendering/CounterNode.cpp: (WebCore::showTreeAndMark):
8:06 AM Changeset in webkit [75610] by Adam Roben
  • 2 edits in trunk/Tools

Advertise the .testnetscape file extension on Windows

Fixes <http://webkit.org/b/52298>
plugins/no-mime-with-valid-extension.html fails on Windows

Reviewed by Dan Bernstein.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a

FileExtents field to map the .testnetscape file extension to the
application/x-webkit-test-netscape MIME type, just as we do on Mac.

7:41 AM Changeset in webkit [75609] by Csaba Osztrogonác
  • 1 edit
    15 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for new passing tests introduced in r74954 and r74743.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
  • platform/qt/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
  • platform/qt/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
  • platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
  • platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
  • platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
  • platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
  • platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
  • platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
  • platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
  • platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
  • platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
7:33 AM Changeset in webkit [75608] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-12 Justin Schuh <jschuh@chromium.org>

Unreviewed expectations update for chromium.

Exclude failing test from r75064.

  • platform/chromium/test_expectations.txt:
7:08 AM Changeset in webkit [75607] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-01-12 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing test on GTK.

  • platform/gtk/Skipped: Skip editing/input/page-up-down-scrolls.html
6:54 AM Changeset in webkit [75606] by pfeldman@chromium.org
  • 3 edits in branches/chromium/597/WebCore/inspector

Merge 74637 - 2010-12-24 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Darin Adler.

inspector/debugger-step-out.html crashing intermittently in the bots
https://bugs.webkit.org/show_bug.cgi?id=50868

Use RefPtr rather instead of raw pointers when keeping references
to refcounted objects.

  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode2): (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::create): (WebCore::InspectorStyle::InspectorStyle): (WebCore::InspectorStyle::buildObjectForStyle): (WebCore::InspectorStyle::setPropertyText): (WebCore::InspectorStyle::toggleProperty): (WebCore::InspectorStyle::styleText): (WebCore::InspectorStyle::populateAllProperties): (WebCore::InspectorStyle::replacePropertyInStyleText): (WebCore::InspectorStyleSheet::create): (WebCore::InspectorStyleSheet::InspectorStyleSheet): (WebCore::InspectorStyleSheetForInlineStyle::create): (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
  • inspector/InspectorStyleSheet.h: (WebCore::InspectorStyle::cssStyle): (WebCore::InspectorStyleSheet::pageStyleSheet):

TBR=yurys@chromium.org
BUG=69296
Review URL: http://codereview.chromium.org/6205007

6:42 AM Changeset in webkit [75605] by Philippe Normand
  • 2 edits in trunk/WebKit/gtk

2011-01-12 Philippe Normand <pnormand@igalia.com>

Unreviewed build fix for 32-bits Release. Include GRefPtrGtk.h so
the GdkCursor templates are found and used at runtime.

  • WebCoreSupport/FullscreenVideoController.cpp:
5:06 AM Changeset in webkit [75604] by yurys@chromium.org
  • 35 edits in trunk

2010-12-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

inspector/timeline-network-resource.html fails when run twice
https://bugs.webkit.org/show_bug.cgi?id=37394

Send didReceiveResponse notification to the timeline agent from ResourceLoadNotifier
instead of ResourceLoader::didReceiveResponse to cover the cases when resources
are loaded from memory cache.

Network notifications are now send to InspectorInstrumentation which dispatches
them to interested agents and InspectorController.
fix

  • inspector/timeline-network-resource-expected.txt:
  • inspector/timeline-network-resource.html:
  • inspector/timeline-network-resource.js:

2010-12-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

inspector/timeline-network-resource.html fails when run twice
https://bugs.webkit.org/show_bug.cgi?id=37394

Send didReceiveResponse notification to the timeline agent from ResourceLoadNotifier
instead of ResourceLoader::didReceiveResponse to cover the cases when resources
are loaded from memory cache.

Network notifications are now sent to InspectorInstrumentation which dispatches
them to interested agents and InspectorController.

  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl): (WebCore::InspectorInstrumentation::markResourceAsCachedImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl): (WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl): (WebCore::InspectorInstrumentation::didFinishLoadingImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::scriptImportedImpl): (WebCore::InspectorInstrumentation::retrieveResourceAgent):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::identifierForInitialRequest): (WebCore::InspectorInstrumentation::willSendRequest): (WebCore::InspectorInstrumentation::markResourceAsCached): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache): (WebCore::InspectorInstrumentation::willReceiveResourceResponse): (WebCore::InspectorInstrumentation::didReceiveContentLength): (WebCore::InspectorInstrumentation::didFinishLoading): (WebCore::InspectorInstrumentation::didFailLoading): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorInstrumentation::scriptImported):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest):
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willSendResourceRequest):
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createResourceSendRequestData):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveResponse): (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveResponse):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle): (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didReceiveData): (WebCore::ApplicationCacheGroup::didFinishLoading): (WebCore::ApplicationCacheGroup::didFail):
  • loader/appcache/ApplicationCacheGroup.h:
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::notifyFinished):
  • workers/Worker.cpp: (WebCore::Worker::notifyFinished):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):

2010-12-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

inspector/timeline-network-resource.html fails when run twice
https://bugs.webkit.org/show_bug.cgi?id=37394

Send didReceiveResponse notification to the timeline agent from ResourceLoadNotifier
instead of ResourceLoader::didReceiveResponse to cover the cases when resources
are loaded from memory cache.

Network notifications are now sent to InspectorInstrumentation which dispatches
them to interested agents and InspectorController.

  • src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::notifyFinished):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::mainFrame): (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest): (WebKit::WebDevToolsAgentImpl::willSendRequest): (WebKit::WebDevToolsAgentImpl::didReceiveData): (WebKit::WebDevToolsAgentImpl::didReceiveResponse): (WebKit::WebDevToolsAgentImpl::didFinishLoading): (WebKit::WebDevToolsAgentImpl::didFailLoading):
  • src/WebDevToolsAgentImpl.h:
5:03 AM Changeset in webkit [75603] by jorlow@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-12 Jeremy Orlow <jorlow@chromium.org>

Add forgotten file.

  • storage/indexeddb/transaction-read-only-expected.txt: Added.
4:57 AM Changeset in webkit [75602] by pvarga@webkit.org
  • 12 edits
    1 add in trunk/Source/JavaScriptCore

2011-01-12 Peter Varga <pvarga@webkit.org>

Reviewed by Gavin Barraclough.

Add Yarr.h to YARR
https://bugs.webkit.org/show_bug.cgi?id=51021

Move other common constants and functions from YARR's different files
to Yarr.h.
Use Yarr.h header instead of including other YARR headers where it
is possible.

  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/RegExp.cpp:
  • yarr/Yarr.h: Added.
  • yarr/YarrInterpreter.cpp:
  • yarr/YarrInterpreter.h:
  • yarr/YarrJIT.cpp: (JSC::Yarr::jitCompile): (JSC::Yarr::execute):
  • yarr/YarrJIT.h:
  • yarr/YarrParser.h:
  • yarr/YarrPattern.cpp: (JSC::Yarr::YarrPattern::compile): (JSC::Yarr::YarrPattern::YarrPattern):
  • yarr/YarrPattern.h:
4:55 AM Changeset in webkit [75601] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-12 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: do not replace all tabs with spaces when editing script source
https://bugs.webkit.org/show_bug.cgi?id=52291

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype._editLine):
4:29 AM Changeset in webkit [75600] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make webkit-patch support subdirectories for SVN checkouts
https://bugs.webkit.org/show_bug.cgi?id=52261

os.relpath does not exist on Python 2.5, so we need to call our version
of the API.

  • Scripts/webkitpy/common/checkout/scm.py:
4:22 AM Changeset in webkit [75599] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2011-01-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74344.
http://trac.webkit.org/changeset/74344
https://bugs.webkit.org/show_bug.cgi?id=52290

broke QWebPluginFactory for unusual mime-types (Requested by
kling on #webkit).

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
3:28 AM Changeset in webkit [75598] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] plugins/no-mime-with-valid-extension.html fails
https://bugs.webkit.org/show_bug.cgi?id=52288

  • platform/qt/Skipped: plugins/no-mime-with-valid-extension.html added until fix.
3:16 AM Changeset in webkit [75597] by Csaba Osztrogonác
  • 12 edits
    1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r75595.
http://trac.webkit.org/changeset/75595
https://bugs.webkit.org/show_bug.cgi?id=52286

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-12
It broke fast/regex/pcre-test-1.html (Requested by Ossy on
#webkit).

  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/RegExp.cpp:
  • yarr/Yarr.h: Removed.
  • yarr/YarrInterpreter.cpp:
  • yarr/YarrInterpreter.h:
  • yarr/YarrJIT.cpp:

(JSC::Yarr::jitCompile):

  • yarr/YarrJIT.h:

(JSC::Yarr::execute):

  • yarr/YarrParser.h:
  • yarr/YarrPattern.cpp:

(JSC::Yarr::compile):
(JSC::Yarr::YarrPattern::YarrPattern):

  • yarr/YarrPattern.h:
2:40 AM Changeset in webkit [75596] by jorlow@chromium.org
  • 22 edits
    1 add in trunk

2011-01-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Enforce READ_ONLY transactions in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=52229

Fix existing errors in tests + add a new test for
this issue.

  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-read-only.html: Added.

2011-01-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Enforce READ_ONLY transactions in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=52229

Add READ_ONLY_ERR and return it whenever delete or put
are called. Note that IDBCursor's delete and update
are simply aliases for delete/put, which is why no
extra code is required to handle those cases.

Test: storage/indexeddb/transaction-read-only.html

  • dom/ExceptionCode.cpp:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::deleteFunction):
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseException.h:
  • storage/IDBDatabaseException.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::deleteFunction): (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
2:32 AM Changeset in webkit [75595] by pvarga@webkit.org
  • 12 edits
    1 add in trunk/Source/JavaScriptCore

2011-01-12 Peter Varga <pvarga@webkit.org>

Reviewed by Gavin Barraclough.

Add Yarr.h to YARR
https://bugs.webkit.org/show_bug.cgi?id=51021

Move other common constants and functions from YARR's different files
to Yarr.h.
Use Yarr.h header instead of including other YARR headers where it
is possible.

  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/RegExp.cpp:
  • yarr/Yarr.h: Added.
  • yarr/YarrInterpreter.cpp:
  • yarr/YarrInterpreter.h:
  • yarr/YarrJIT.cpp: (JSC::Yarr::jitCompile): (JSC::Yarr::execute):
  • yarr/YarrJIT.h:
  • yarr/YarrParser.h:
  • yarr/YarrPattern.cpp: (JSC::Yarr::YarrPattern::compile): (JSC::Yarr::YarrPattern::YarrPattern):
  • yarr/YarrPattern.h:
1:38 AM Changeset in webkit [75594] by pfeldman@chromium.org
  • 1 edit in branches/chromium/597/WebCore/inspector/front-end/ResourceManager.js

Merge 75503 - 2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: redirects are lost from the network panel upon navigation.
https://bugs.webkit.org/show_bug.cgi?id=52210

  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):

TBR=pfeldman@chromium.org
BUG=69359

1:36 AM Changeset in webkit [75593] by pfeldman@chromium.org
  • 2 edits in branches/chromium/597/WebCore/inspector/front-end

Merge 75498 - 2011-01-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: "Audit present state" always disabled
https://bugs.webkit.org/show_bug.cgi?id=52199

Removed all traces of resource tracking checks, as we have it no more.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
  • inspector/front-end/AuditsPanel.js:

TBR=apavlov@chromium.org
BUG=69241

1:32 AM Changeset in webkit [75592] by pfeldman@chromium.org
  • 2 edits in branches/chromium/597/WebCore

Merge 75485 - 2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Load timing is requested
for all resources (not only for the main one).
https://bugs.webkit.org/show_bug.cgi?id=51749

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):

TBR=pfeldman@chromium.org
BUG=69229

1:27 AM Changeset in webkit [75591] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-01-11 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GTK] minimal build breaks in RenderThemeGtk3
https://bugs.webkit.org/show_bug.cgi?id=52202

  • platform/gtk/RenderThemeGtk3.cpp: Added VIDEO guards around initMediaColors().
1:08 AM Changeset in webkit [75590] by Philippe Normand
  • 3 edits
    1 copy in trunk/Source/WebCore

2011-01-11 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] PlatformVideoWindowMac implementation
https://bugs.webkit.org/show_bug.cgi?id=50770

This new implementation will be used on Mac OS to display the
fullscreen video window with the GStreamer-based media player.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::gstGWorldSyncMessageCallback):
  • platform/graphics/gstreamer/PlatformVideoWindow.h: (WebCore::PlatformVideoWindow::window):
  • platform/graphics/gstreamer/PlatformVideoWindowMac.mm: (PlatformVideoWindow::PlatformVideoWindow): (PlatformVideoWindow::~PlatformVideoWindow): (PlatformVideoWindow::prepareForOverlay):
12:37 AM Changeset in webkit [75589] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-12 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix wrapping bug in expansion lines in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52270

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:

Jan 11, 2011:

11:57 PM Changeset in webkit [75588] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Fix typo in WebKit2 skipped list which was causing a test to not get skipped
https://bugs.webkit.org/show_bug.cgi?id=52277

  • platform/mac-wk2/Skipped:
11:41 PM Changeset in webkit [75587] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-01-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric Seidel.

Close additional pages opened during a test once the test completes.
https://bugs.webkit.org/show_bug.cgi?id=52276

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
10:53 PM Changeset in webkit [75586] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-01-11 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

Errors should be separated from the command line in bot messages.
https://bugs.webkit.org/show_bug.cgi?id=52275

  • Scripts/webkitpy/common/system/executive.py: (ScriptError.message_with_output): Added a newline to separate the command line from the errors.
  • Scripts/webkitpy/common/system/executive_unittest.py: (ScriptErrorTest.test_message_with_output): Added tests for the various code paths in message_with_output.
9:25 PM Changeset in webkit [75585] by Simon Fraser
  • 3 edits
    2 adds in trunk

2011-01-11 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Webkit crashes when a gradient is applied using the first-line pseudo element
https://bugs.webkit.org/show_bug.cgi?id=52225

When a pseudostyle references images, we fail to register/unregister
the relevant RenderObjects as clients of the image in the style.
For gradients, this caused a crash.

This patch fixes the crash by returning a null gradient image in this
situation.

Test: fast/gradients/gradient-on-pseudoelement-crash.html

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image):
7:35 PM Changeset in webkit [75584] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Justin Schuh <jschuh@chromium.org>

Unreviewed chromium expectations update.

Windows exclusion for no-mime-with-valid-extension.html (from r75567)

  • platform/chromium/test_expectations.txt:
7:20 PM Changeset in webkit [75583] by eric@webkit.org
  • 5 edits in trunk/Tools

2011-01-11 Eric Seidel <eric@webkit.org>

Unreviewed.

commit-queue should know how to upload archived results (for test flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048

The zips are mostly empty due to forgetting -r.
Expected diffs were not being pulled from the archive due
to the archive having longer paths than I realized.

  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
6:38 PM Changeset in webkit [75582] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Dirk Pranke <dpranke@chromium.org>

Unreviewed, fix typo in expectations file.

  • platform/chromium-gpu/test_expectations.txt:
6:16 PM Changeset in webkit [75581] by thakis@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-01-11 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Remove now-unnecessary xp-specific baseline.
https://bugs.webkit.org/show_bug.cgi?id=52105

  • platform/chromium-win-xp/fast/gradients/radial-centered-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/gradients/radial-centered-expected.png: Removed.
5:57 PM Changeset in webkit [75580] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-11 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r71562): servePendingRequests() no longer called when
resources are done loading.
https://bugs.webkit.org/show_bug.cgi?id=52264
<rdar://problem/8767429>


In r71562, servePendingRequests() is no longer called in Loader's
didFinishLoading(), didFail() and didReceiveResponse() methods. Since
r71562 was intended only as a refactoring, these calls should be
restored. At least one WebKit-based Mac OS X application relies on this
for correct behavior.

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::loadDone): Call resourceLoadScheduler()->servePendingRequests().
5:36 PM Changeset in webkit [75579] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-01-11 Adrienne Walker <enne@google.com>

Unreviewed, test expectations update.

Revert expect change for Snow Leopard in r75570.

  • platform/mac-snowleopard/Skipped:
5:28 PM Changeset in webkit [75578] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; chromium test expectations update.

Remove failing expectations for tests that pass after r75569.

  • platform/chromium/test_expectations.txt:
5:26 PM Changeset in webkit [75577] by Patrick Gansterer
  • 8 edits in trunk/Source/WebCore

2011-01-11 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Add Document::setContent()
https://bugs.webkit.org/show_bug.cgi?id=52085

Add a method to Document to set the whole content at once.
This removes the hack of the insert method in the xml parser
and is a predecessor to feed the xml parser with raw data.

  • dom/Document.cpp: (WebCore::Document::setContent):
  • dom/Document.h:
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insert): Added ASSERT_NOT_REACHED().
  • loader/cache/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData): Use setContent.
  • xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString): Ditto.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Ditto.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Ditto.
5:15 PM Changeset in webkit [75576] by dpranke@chromium.org
  • 13 edits in trunk/Tools

2011-01-11 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

The current modifier parsing code in test_expectations is
fragile and hard-coded, so it's not easy to understand the logic
or easily add new types of modifiers (like GPU vs. CPU testing
for graphics tests, or 32-bit vs. 64-bit differences).

This is the first of two patches that will add in more generic
support and then eliminate the GPU-specific test expectations
files for Chromium.

This patch adds two standalone objects for handling modifiers. The
rules for interpreting modifiers, precedence, and conflicts are
given in the docstring to the ModifierMatcher class, which
returns ModifierMatchResult objects.

This patch also adds routines to the Port interface and a
default set of values in the base object, in order to obtain the
values needed on a given test run. These values are then passed
to the expectation parser. This also allows us to clean up the
logic used to lint all of the different configurations in a
single test_expectations.txt file.

The next patch will merge in the separate GPU expectations file.

https://bugs.webkit.org/show_bug.cgi?id=51222

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:56 PM Changeset in webkit [75575] by mjs@apple.com
  • 5 edits in trunk/Tools

2011-01-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Make webkit-patch support subdirectories for SVN checkouts
https://bugs.webkit.org/show_bug.cgi?id=52261

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
4:56 PM Changeset in webkit [75574] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-01-11 James Robinson <jamesr@chromium.org>

Update test to use layoutTestController.waitUntilDone()/notifyDone() since it relies on the scroll event which is now async.

  • fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html:
4:53 PM Changeset in webkit [75573] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • platform/graphics/cairo/PathCairo.cpp:

(WebCore::Path::addArc): Switch to MathExtra's piFloat define,
rather than M_PI which is not always available.

4:52 PM Changeset in webkit [75572] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; chromium test expectations update.

Remove failing expectations for tests that pass after r75552.

  • platform/chromium/test_expectations.txt:
4:43 PM Changeset in webkit [75571] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix difflink centering to be vertical, not horizontal
https://bugs.webkit.org/show_bug.cgi?id=52263

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
4:39 PM Changeset in webkit [75570] by enne@google.com
  • 6 edits
    3 adds
    2 deletes in trunk/LayoutTests

2011-01-11 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Sync WebGL texImage2D video test from Khronos and re-enable it.
https://bugs.webkit.org/show_bug.cgi?id=44459

  • fast/canvas/webgl/resources/quadrants.mp4: Removed.
  • fast/canvas/webgl/resources/quadrants.ogv: Removed.
  • fast/canvas/webgl/resources/red-green.mp4: Added.
  • fast/canvas/webgl/resources/red-green.theora.ogv: Added.
  • fast/canvas/webgl/resources/red-green.webmvp8.webm: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html:
  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/Skipped:
4:36 PM Changeset in webkit [75569] by mihaip@chromium.org
  • 8 edits
    38 adds
    2 deletes in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed, new chromium-mac baselines.

Rebaseline after the scrollbar change (these tests still need
chromium-mac baselines since they have controls or images that render
slightly differently from the Mac port).

  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum: Added.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.checksum:
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-mac/fast/events/pointer-events-2-expected.png:
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.checksum: Removed.
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-image-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-image-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/core/row_span-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/core/row_span-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/other/cell_widths-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/other/cell_widths-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:33 PM Changeset in webkit [75568] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2011-01-11 Jeff Miller <jeffm@apple.com>

Reviewed by John Sullivan.

WebKit2: "Webpages not responding" dialog appears when <select> popup menu is showing
https://bugs.webkit.org/show_bug.cgi?id=52242

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showPopupMenu): On Windows, stop the responsiveness timer before calling showPopupMenu().
4:33 PM Changeset in webkit [75567] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-11 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Adam Barth.

Use plug-in DB for extensions to MIME type convertion

Plugins extension to MIME type conversion was not used in the
frameLoader. This was causing some fallback to be use which as the side
effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
This patch ensure that we try to convert the extension to MIME type
using the plugin database beofre using this fallback.

Attribute lost with Flash plugin without mime type set
https://bugs.webkit.org/show_bug.cgi?id=50657

  • plugins/no-mime-with-valid-extension.html: Added.
  • plugins/no-mime-with-valid-extension-expected.txt: Added.

2011-01-11 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Adam Barth.

Use plug-in DB for extensions to MIME type convertion

Plugins extension to MIME type conversion was not used in the
frameLoader. This was causing some fallback to be use which as the side
effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
This patch ensure that we try to convert the extension to MIME type
using the plugin database beofre using this fallback.

Attribute lost with Flash plugin without mime type set
https://bugs.webkit.org/show_bug.cgi?id=50657

Test: plugins/no-mime-with-valid-extension.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType): Use PluginDatabase for MIME
4:17 PM Changeset in webkit [75566] by mjs@apple.com
  • 2 edits in trunk/WebKit2

2011-01-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

UIProcess kills the WebProcess sometimes when detached frames exist
https://bugs.webkit.org/show_bug.cgi?id=52227

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didSaveFrameToPageCache): Don't consider the message invalid if it came in for a detached frame.
3:56 PM Changeset in webkit [75565] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

remember diffstate for review tool
https://bugs.webkit.org/show_bug.cgi?id=52253

If you use the global sidebyside/unified links, store the diff type
in localstorage. Then, onload, use that diff type. That way, people
who prefer one diff type or the other can always get that by default.

  • code-review.js:
3:44 PM Changeset in webkit [75564] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Justin Schuh <jschuh@chromium.org>

Unreviewed, test expectations update.

Flaky expectations for textOnPath.svg.

  • platform/chromium/test_expectations.txt:
3:41 PM Changeset in webkit [75563] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • WebKit2.xcodeproj/project.pbxproj:
3:40 PM Changeset in webkit [75562] by andersca@apple.com
  • 2 edits
    2 adds in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add a Region class which represents a graphical region
https://bugs.webkit.org/show_bug.cgi?id=52255

  • Platform/Region.cpp: Added. (WebKit::Region::Region): (WebKit::Region::rects): (WebKit::Region::Shape::Shape): (WebKit::Region::Shape::appendSpan): (WebKit::Region::Shape::canCoalesce): (WebKit::Region::Shape::appendSpans): (WebKit::Region::Shape::appendSegment): (WebKit::Region::Shape::spans_begin): (WebKit::Region::Shape::spans_end): (WebKit::Region::Shape::segments_begin): (WebKit::Region::Shape::segments_end): (WebKit::Region::Shape::dump): (WebKit::Region::Shape::bounds): (WebKit::Region::Shape::move): (WebKit::Region::Shape::swap): (WebKit::Region::Shape::shapeOperation): (WebKit::Region::Shape::UnionOperation::trySimpleOperation): (WebKit::Region::Shape::unionShapes): (WebKit::Region::Shape::IntersectOperation::trySimpleOperation): (WebKit::Region::Shape::intersectShapes): (WebKit::Region::Shape::SubtractOperation::trySimpleOperation): (WebKit::Region::Shape::subtractShapes): (WebKit::Region::dump): (WebKit::Region::intersect): (WebKit::Region::unite): (WebKit::Region::subtract): (WebKit::Region::move):
  • Platform/Region.h: Added. (WebKit::Region::bounds): (WebKit::Region::isEmpty): (WebKit::Region::Span::Span): (WebKit::Region::Shape::isEmpty):
  • WebKit2.xcodeproj/project.pbxproj:
3:35 PM Changeset in webkit [75561] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2011-01-11 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] copy test netscape plugin into TestNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=52232

  • WebKit.gyp: Make a copy of the TestNetscapePlugIn in

TestNetscapePlugIn and WebKitTestNetscapePlugIn

3:19 PM Changeset in webkit [75560] by simonjam@chromium.org
  • 16 edits in trunk

2011-01-11 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

[Web Timing] Rename sslHandshakeStart to secureConnectionStart
https://bugs.webkit.org/show_bug.cgi?id=52239

  • fast/dom/Window/window-properties-performance-expected.txt:
  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingOnDOMContentLoaded): (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-document-open-expected.txt:
  • fast/dom/webtiming-expected.txt:
  • fast/dom/webtiming-navigate-within-document-expected.txt:
  • http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
  • http/tests/misc/resources/webtiming-cross-origin-redirect.html:
  • http/tests/misc/resources/webtiming-no-origin.html:
  • http/tests/misc/resources/webtiming-ssl.html:
  • http/tests/misc/webtiming-origins-expected.txt:
  • http/tests/misc/webtiming-ssl-expected.txt:

2011-01-11 James Simonsen <simonjam@chromium.org>

Reviewed by Eric Seidel.

[Web Timing] Rename sslHandshakeStart to secureConnectionStart
https://bugs.webkit.org/show_bug.cgi?id=52239

  • page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::secureConnectionStart):
  • page/PerformanceTiming.h:
  • page/PerformanceTiming.idl:
3:16 PM Changeset in webkit [75559] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

allow sidebysideifying individual files in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52226

  • code-review.js:
2:58 PM Changeset in webkit [75558] by andersca@apple.com
  • 9 edits
    1 add in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add DidSetSize message
https://bugs.webkit.org/show_bug.cgi?id=52254

  • DerivedSources.make: Add DrawingAReaProxy.messages.in.
  • Platform/CoreIPC/MessageID.h: Add DrawingAreaProxy message class.
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::didSetSize): Add CoreIPC message handler function.
  • UIProcess/DrawingAreaProxy.messages.in: Added.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didSetSize): Add stub.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Handle DrawingAreaProxy messages.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Send a DidSetSize message for now.
2:53 PM Changeset in webkit [75557] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-01-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182

This patch actually makes the display-isolated schemes display
isolated. The behavior should be the same as the previous iteration of
this patch, but re-organized a bit because reading the access white
list is expensive.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::isAccessToURLWhiteListed): (WebCore::SecurityOrigin::canDisplay):
  • page/SecurityOrigin.h:
  • platform/SchemeRegistry.cpp:
  • platform/SchemeRegistry.h:
2:52 PM Changeset in webkit [75556] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

2011-01-11 Merge 75548 - BUGCR69275 - Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

RefPtr the FrameView to prevent scrollbar from getting deleted inside
its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238

Test: scrollbars/scrollable-iframe-remove-crash.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::scrollTo):

2011-01-11 Merge 75548 - Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when we remove scrollable iframe when executing
inside its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238

  • scrollbars/scrollable-iframe-remove-crash-expected.txt: Added.
  • scrollbars/scrollable-iframe-remove-crash.html: Added.
2:47 PM Changeset in webkit [75555] by mihaip@chromium.org
  • 17 edits
    4 adds in trunk

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

Scroll event should be fired asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45631

Update existing tests that assumed that scroll events fired
synchronously.

  • editing/input/page-up-down-scrolls-expected.txt:
  • editing/input/page-up-down-scrolls.html:
  • fast/events/fire-scroll-event-element-expected.txt: Copied from LayoutTests/fast/events/fire-scroll-event-expected.txt.
  • fast/events/fire-scroll-event-element.html: Added. Does the same

tests as fire-scroll-event.html, but on an individual element instead
of the whole document.

  • fast/events/fire-scroll-event-expected.txt:
  • fast/events/fire-scroll-event.html: Now explicitly tests for

synchronous behavior when scrolling the document, and that we don't
fire the event more than once.

  • fast/events/remove-child-onscroll.html:
  • fast/events/scroll-during-zoom-change.html:
  • fast/events/scroll-event-does-not-bubble.html:
  • fast/events/scroll-event-phase-expected.txt: Added.
  • fast/events/scroll-event-phase.html: Added. Checks that we can listen

for scroll events in both the capture and bubble phase.

  • fast/layers/removed-by-scroll-handler.html:
  • fast/overflow/onscroll-layer-self-destruct.html:
  • fast/repaint/repaint-during-scroll.html:

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

Scroll event should be fired asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45631

Tests: fast/events/fire-scroll-event.html

fast/events/fire-scroll-event-element.html
fast/events/scroll-event-phase.html

Makes scroll events fire asynchronously to be in compliance with the
CSSOM View Module and consistent with Gecko, Opera and (to some degree)
IE.

Implemented via the EventQueue class added by r74062 (EventQueue now
has a convenience enqueueScrollEvent method).

  • dom/EventQueue.cpp: (WebCore::EventQueue::enqueueScrollEvent): (WebCore::EventQueue::pendingEventTimerFired):
  • dom/EventQueue.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::sendScrollEvent):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::valueChanged):
2:42 PM Changeset in webkit [75554] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

RefPtr text node in setOuterText since calling appendData
on a text node can fire away dom event listener which might
remove the text node from underneath.
https://bugs.webkit.org/show_bug.cgi?id=52163

Test: fast/dom/text-node-append-data-remove-crash.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterText):

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that calling append data on a text node which removes its
sibling text node does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=52163

  • fast/dom/text-node-append-data-remove-crash-expected.txt: Added.
  • fast/dom/text-node-append-data-remove-crash.html: Added.
2:16 PM Changeset in webkit [75553] by kbr@google.com
  • 5 edits
    3 deletes in trunk/WebKit/chromium

2011-01-11 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Move WebGraphicsContext3DDefaultImpl to Chromium repository
https://bugs.webkit.org/show_bug.cgi?id=52235

Deleted WebGraphicsContext3DDefaultImpl, which has been moved to
the Chromium repository under WebGraphicsContext3DInProcessImpl.
Removed WebGraphicsContext3D::createDefault(). Rolled forward
Chromium version to pick up needed changes.

Tested with build-webkit --chromium --debug and a run of the WebGL
layout tests in DRT.

  • DEPS:
  • WebKit.gyp:
  • public/WebGraphicsContext3D.h:
  • src/GraphicsContext3DChromium.cpp:
  • src/WebGraphicsContext3D.cpp: Removed.
  • src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
  • src/WebGraphicsContext3DDefaultImpl.h: Removed.
2:03 PM Changeset in webkit [75552] by mihaip@chromium.org
  • 10 edits
    7 adds in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; new and updated mac-leopard baselines.

Update stale or missing Leopard baselines (tests currently pass on Snow
Leopard).

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/editing/deleting/delete-line-end-ws-001-expected.checksum:
  • platform/mac-leopard/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/mac-leopard/editing/deleting/delete-line-end-ws-002-expected.checksum:
  • platform/mac-leopard/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/mac-leopard/fast/block/basic/016-expected.checksum: Added.
  • platform/mac-leopard/fast/block/basic/016-expected.png: Added.
  • platform/mac-leopard/fast/block/basic/truncation-rtl-expected.checksum: Added.
  • platform/mac-leopard/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/mac-leopard/fast/blockflow/fieldsets-expected.checksum: Added.
  • platform/mac-leopard/fast/blockflow/fieldsets-expected.png: Added.
  • platform/mac-leopard/fast/borders/border-image-scale-transform-expected.checksum:
  • platform/mac-leopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
2:03 PM Changeset in webkit [75551] by weinig@apple.com
  • 5 edits in trunk/WebKit2

Fix spelling mistake. Sharable -> Shareable.

Reviewed by Anders Carlsson.

  • Shared/API/c/WKImage.h:
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toImageOptions):

  • Shared/ImageOptions.h:
  • Shared/WebImage.cpp:

(WebKit::WebImage::create):

1:53 PM Changeset in webkit [75550] by andersca@apple.com
  • 10 edits
    1 add in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add SetSize message
https://bugs.webkit.org/show_bug.cgi?id=52247

  • DerivedSources.make: Add DrawingArea.messages.in
  • Platform/CoreIPC/MessageID.h: Add DrawingArea message class.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::sizeDidChange): Call sendSetSize.

(WebKit::DrawingAreaProxyImpl::sendSetSize):
Send a SetSize message.

  • UIProcess/DrawingAreaProxyImpl.h: Add setSize override.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): Add setSize member function.
  • WebProcess/WebPage/DrawingArea.messages.in: Added.
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h: Add setSize.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveMessage): Handle drawing area messages.
1:33 PM Changeset in webkit [75549] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-01-11 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r75523.

  • platform/wince/DragDataWinCE.cpp: Added missing include.
1:28 PM Changeset in webkit [75548] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

RefPtr the FrameView to prevent scrollbar from getting deleted inside
its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238

Test: scrollbars/scrollable-iframe-remove-crash.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::scrollTo):

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when we remove scrollable iframe when executing
inside its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238

  • scrollbars/scrollable-iframe-remove-crash-expected.txt: Added.
  • scrollbars/scrollable-iframe-remove-crash.html: Added.
1:24 PM Changeset in webkit [75547] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Replace ASSERTs with FIXMEs.

Reviewed by Sam Weinig.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::sizeDidChange):
(WebKit::DrawingAreaProxyImpl::setPageIsVisible):

1:20 PM Changeset in webkit [75546] by andersca@apple.com
  • 4 edits
    2 adds in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add DrawingAreaImpl skeleton class
https://bugs.webkit.org/show_bug.cgi?id=52246

  • UIProcess/API/mac/WKView.mm: (useNewDrawingArea): New function which controls which drawing area to use, through an environment variable.

(-[WKView drawRect:]):
Bail if we're using the new drawing area (for now).

(-[WKView WebKit::]):
Create a DrawingAreaProxyImpl when asked to.

  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): Create a DrawingAreaImpl when asked to.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: Added.
  • WebProcess/WebPage/DrawingAreaImpl.h: Added. Add DrawingAreaImpl class.
1:17 PM Changeset in webkit [75545] by Martin Robinson
  • 1 edit
    3 deletes in trunk/LayoutTests

2011-01-11 Martin Robinson <mrobinson@igalia.com>

Remove some GTK+-specific baselines. GTK+ now enough feature parity with the Mac
port to make these platform-specific results unnecessary.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/gtk/fast/js/global-constructors-expected.txt: Removed.
1:08 PM Changeset in webkit [75544] by thakis@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-11 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Another new baselines due to updated skia
https://bugs.webkit.org/show_bug.cgi?id=52105

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
1:05 PM Changeset in webkit [75543] by Dimitri Glazkov
  • 16 edits
    2 adds in trunk

2011-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Hyatt.

Make pseudo-style resolution less hard-coded when used to select a shadow node
https://bugs.webkit.org/show_bug.cgi?id=46595

New test that comprehensively travels the code paths affected by the change.

  • fast/css/unknown-pseudo-element-matching-expected.txt: Added.
  • fast/css/unknown-pseudo-element-matching.html: Added.

2011-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Hyatt.

Make pseudo-style resolution less hard-coded when used to select a shadow node
https://bugs.webkit.org/show_bug.cgi?id=46595

Essentially implements the plumbing for the XBL2 pseudo attribute:
http://dev.w3.org/2006/xbl2/#the-pseudo-attribute

Test: fast/css/unknown-pseudo-element-matching.html

  • css/CSSGrammar.y: Changed to handle specifier_list structure with the

CSSParser::updateSpecifierWithElementName helper, added logic to
keep unknown pseudo-element selectors at the top of the selector chain,
so that we can easily check for them and grab them, and also because
they would either not match anything or act as a descendant selector
(descendant into a shadow DOM subtree that is), not a specifier.

  • css/CSSParser.cpp: (WebCore::CSSParser::updateSpecifiersWithElementName): Generalized/combined

the logic adding element name to selectors and added the special case
to handle unknown pseudo-element selectors.

  • css/CSSParser.h: Added def.
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed any mention of PseudoSliderThumb/SLIDER_THUMB. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h: Added a new ShadowDescendant relation type,

removed PseudoSliderThumb def.

(WebCore::CSSSelector::isUnknownPseudoElement): Added a helper method.

  • css/CSSSelectorList.cpp: (WebCore::SelectorHasUnknownPseudoElementFunctor::operator()): Added a functor

to check for an unknown pseudo-element in the list.

(WebCore::CSSSelectorList::hasUnknownPseudoElements): Added.

  • css/CSSSelectorList.h: Added a def.
  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::getPseudoRules): Added accessor to pseudo-element hash. (WebCore::CSSStyleSelector::matchRules): Added matching pseudo elements. (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Added handling

of ShadowDescendant relation.

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Enabled handling

of unknown pseudo-element selectors.

(WebCore::CSSRuleSet::addRule): Added populating unknown pseudo-element hash.

  • css/html.css: (input[type="range"]::-webkit-slider-thumb): Added previously-hard-coded

display:block.

  • dom/Element.h: (WebCore::Element::shadowPseudoId): Added new virtual method to allow

elements to provide the value of pseudo-element selector they would match.

  • dom/Node.cpp: (WebCore::Node::querySelector): Added checking for unknown pseudo-element selectors,

so that we can throw a SYNTAX_ERR if found.

(WebCore::Node::querySelectorAll): Ditto.

  • html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::shadowPseudoId): Added to return "-webkit-slider-thumb";
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Changed to use the new styleForElement logic.
  • rendering/style/RenderStyleConstants.h: Removed SLIDER_THUMB.
1:03 PM Changeset in webkit [75542] by dino@apple.com
  • 5 edits in trunk

2011-01-11 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=52233

WebKitCSSMatrix constructor should accept 'none'
as a valid string parameter.

  • css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::setMatrixValue):

2011-01-11 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=52233

Update WebKitCSSMatrix test to cover a constructor
that accepts 'none' as input.

  • transforms/cssmatrix-2d-interface-expected.txt:
  • transforms/cssmatrix-2d-interface.xhtml:
1:00 PM Changeset in webkit [75541] by Dimitri Glazkov
  • 4 edits
    2 deletes in branches/chromium/597

Merged r75536.

12:56 PM Changeset in webkit [75540] by andersca@apple.com
  • 5 edits
    2 adds in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add Mac-only DrawingAreaProxyImpl class skeleton
https://bugs.webkit.org/show_bug.cgi?id=52243

This is the proxy side of a new drawing area implementation. This is Mac only for now
while the design is being fleshed out.

  • Shared/DrawingAreaInfo.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
  • UIProcess/DrawingAreaProxyImpl.cpp: Added. (WebKit::DrawingAreaProxyImpl::create): (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): (WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl): (WebKit::DrawingAreaProxyImpl::didReceiveMessage): (WebKit::DrawingAreaProxyImpl::didReceiveSyncMessage): (WebKit::DrawingAreaProxyImpl::paint): (WebKit::DrawingAreaProxyImpl::sizeDidChange): (WebKit::DrawingAreaProxyImpl::setPageIsVisible): (WebKit::DrawingAreaProxyImpl::attachCompositingContext): (WebKit::DrawingAreaProxyImpl::detachCompositingContext):
  • UIProcess/DrawingAreaProxyImpl.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
12:56 PM Changeset in webkit [75539] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

fix exception when adding a comment to a side-by-side diff
https://bugs.webkit.org/show_bug.cgi?id=52240

prev() and next() won't get the previous and next lines in
side-by-side mode. Instead do a query to find them.

  • code-review.js:
12:54 PM Changeset in webkit [75538] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

maintain word diffs when converting to side-by-side and back
https://bugs.webkit.org/show_bug.cgi?id=52244

Using textContent would lose the spans use to make the word-diff highlighting.
Just move the span element itself.

  • code-review.js:
12:47 PM Changeset in webkit [75537] by jamesr@google.com
  • 11 edits in trunk/Source/WebCore

2011-01-11 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Set all RenderBlocks as replaced when an inline display type is specified
https://bugs.webkit.org/show_bug.cgi?id=50858

When a RenderBlock is created for an element with a specified display:inline style,
it should always be treated as inline-block. This situations often comes up for form
controls. Previously, RenderBlock::styleWillChange set the replaced flag for display
values of inline-block, inline-table, and inline-table and a number of subclasses of
RenderBlock set the replaced flag in styleDidChange for a display:inline. However
sometimes new subclasses would miss this step leading to bugs (such as with RenderDetails).
This patch sets the replaced flag for all inline display types in RenderBlock::styleWillChange.

Code cleanup only, no change in behavior so no new tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::styleDidChange):
  • rendering/RenderFieldset.cpp:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::styleDidChange):
  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::styleDidChange):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::styleDidChange):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange):
12:44 PM Changeset in webkit [75536] by Dimitri Glazkov
  • 5 edits
    2 deletes in trunk

2011-01-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

REGRESSION(r71934) Can't type in search edit field on skin-one.com
https://bugs.webkit.org/show_bug.cgi?id=52195

Restored original (pre-71934) check in the test to ensure that
selectstart does not propagate outside of the shadow DOM.

Consolidated shadow-boundary-crossing-2.html into shadow-boundary-crossing.html.

  • fast/events/shadow-boundary-crossing-2-expected.txt: Renamed to

shadow-boundary-crossing-expected.txt.

  • fast/events/shadow-boundary-crossing-2.html: Renamed to

shadow-boundary-crossing.html.

  • fast/events/shadow-boundary-crossing-expected.txt: Removed.
  • fast/events/shadow-boundary-crossing.html: Removed after folding the

test into the new shadow-boundary-crossing.html.

2011-01-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

REGRESSION(r71934) Can't type in search edit field on skin-one.com
https://bugs.webkit.org/show_bug.cgi?id=52195

Restored the original behavior, where the selectstart event is not
dispatched when selection changes inside of the shadow DOM.

  • dom/Node.cpp: (WebCore::determineDispatchBehavior): Moved EventDispatchBehavior-determining

logic into a helper function, also added a check to keep selectstart

events inside of the shadow DOM.

(WebCore::Node::dispatchGenericEvent): Changed to use the helper function.

12:39 PM Changeset in webkit [75535] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Eric Seidel.

[Qt] Provide plugin coordinates to windowless plugins on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=52213

  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
12:34 PM Changeset in webkit [75534] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-11 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectation update.

  • platform/mac-snowleopard/Skipped:
12:33 PM Changeset in webkit [75533] by Laszlo Gombos
  • 2 edits in trunk

2011-01-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Add QT_NO_CONCURRENT to the qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=52223

Add QT_NO_CONCURRENT to the qt_minimal configuration to make sure
that QtWebKit builds with QT_NO_CONCURRENT defined.

  • WebKit.pri:
12:28 PM Changeset in webkit [75532] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build.

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

12:24 PM Changeset in webkit [75531] by msaboff@apple.com
  • 3 edits
    3 adds in trunk

2011-01-11 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Missing call to popTempSortVector() for exception case in JSArray::sort.
https://bugs.webkit.org/show_bug.cgi?id=50718

Fix to patch of 50718 that added pushTempSortVector() and
popTempSortVector() to JSArray::sort() to mark elements during sort.
Need to add popTempSortVector() for the return case if toString()
had an exception.

  • runtime/JSArray.cpp: (JSC::JSArray::sort): Added popTempSortVector()

2011-01-11 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Missing call to popTempSortVector() for exception case in JSArray::sort.
https://bugs.webkit.org/show_bug.cgi?id=50718

New test to validate balanced calls to pushTempSortVector() and
popTempSortVector().

  • fast/js/array-sort-exception-expected.txt: Added.
  • fast/js/array-sort-exception.html: Added.
  • fast/js/script-tests/array-sort-exception.js: Added. (do_gc): (Item): (toString_throw): (test):
12:22 PM Changeset in webkit [75530] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2011-01-11 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
12:21 PM Changeset in webkit [75529] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix layout error with comments in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52230

  • PrettyPatch/PrettyPatch.rb:
12:20 PM Changeset in webkit [75528] by andersca@apple.com
  • 7 edits in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Rename ShareableBitmap::createSharable to createShareable
https://bugs.webkit.org/show_bug.cgi?id=52234

  • Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::createShareable):
  • Shared/ShareableBitmap.h:
  • Shared/WebImage.cpp: (WebKit::WebImage::create):
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: (WebKit::WebPopupMenu::setUpPlatformData):
  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):
12:13 PM Changeset in webkit [75527] by andersca@apple.com
  • 21 edits
    5 moves in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Rename BackingStore to ShareableBitmap
https://bugs.webkit.org/show_bug.cgi?id=52228

  • GNUmakefile.am:
  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::geometryDidChange):
  • PluginProcess/PluginControllerProxy.h:
  • Shared/API/c/cg/WKImageCG.cpp: (WKImageCreateCGImage):
  • Shared/BackingStore.cpp: Removed.
  • Shared/BackingStore.h: Removed.
  • Shared/PlatformPopupMenuData.cpp: (WebKit::PlatformPopupMenuData::decode):
  • Shared/PlatformPopupMenuData.h:
  • Shared/ShareableBitmap.cpp: Copied from WebKit2/Shared/BackingStore.cpp. (WebKit::ShareableBitmap::create): (WebKit::ShareableBitmap::createSharable): (WebKit::ShareableBitmap::createHandle): (WebKit::ShareableBitmap::ShareableBitmap): (WebKit::ShareableBitmap::~ShareableBitmap): (WebKit::ShareableBitmap::resize): (WebKit::ShareableBitmap::data):
  • Shared/ShareableBitmap.h: Copied from WebKit2/Shared/BackingStore.h.
  • Shared/UserMessageCoders.h: (WebKit::UserMessageEncoder::baseEncode): (WebKit::UserMessageDecoder::baseDecode):
  • Shared/WebImage.cpp: (WebKit::WebImage::create): (WebKit::WebImage::WebImage): (WebKit::WebImage::~WebImage): (WebKit::WebImage::size):
  • Shared/WebImage.h: (WebKit::WebImage::bitmap):
  • Shared/cairo/BackingStoreCairo.cpp: (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
  • Shared/cg/BackingStoreCG.cpp: Removed.
  • Shared/cg/ShareableBitmapCG.cpp: Copied from WebKit2/Shared/cg/BackingStoreCG.cpp. (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
  • Shared/gtk/BackingStoreGtk.cpp: Removed.
  • Shared/gtk/ShareableBitmapGtk.cpp: Copied from WebKit2/Shared/gtk/BackingStoreGtk.cpp. (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
  • Shared/qt/BackingStoreQt.cpp: Removed.
  • Shared/qt/ShareableBitmapQt.cpp: Copied from WebKit2/Shared/qt/BackingStoreQt.cpp. (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint):
  • UIProcess/FindIndicator.cpp: (WebKit::FindIndicator::create): (WebKit::FindIndicator::FindIndicator):
  • UIProcess/FindIndicator.h: (WebKit::FindIndicator::contentImage):
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::snapshotInViewCoordinates): (WebKit::WebPage::snapshotInDocumentCoordinates):
  • win/WebKit2.vcproj:
12:12 PM Changeset in webkit [75526] by thakis@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-11 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Another baseline for the recent skia roll.
https://bugs.webkit.org/show_bug.cgi?id=52105

  • platform/chromium-linux/svg/custom/focus-ring-expected.checksum:
  • platform/chromium-linux/svg/custom/focus-ring-expected.png:
12:05 PM Changeset in webkit [75525] by sullivan@apple.com
  • 2 edits in trunk/WebKit2

[WKView setFrameSize:] derefs _page->drawingArea() without null check
<https://bugs.webkit.org/show_bug.cgi?id=52231>

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):
Null check drawingArea(). This is OK because if it doesn't exist then it will be
created later with the correct initial size.

11:49 AM Changeset in webkit [75524] by zmo@google.com
  • 8 edits in trunk

2011-01-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Use computeImageSizeInBytes. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::readPixels): Ditto, and fix a bug on generating the wrong error. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::validateTexFuncData): Use computeImageSizeInBytes.
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2DResourceSafe): Add a new parameter alignment. (WebCore::GraphicsContext3D::computeFormatAndTypeParameters): Add more supported format/type. (WebCore::GraphicsContext3D::computeImageSizeInBytes): Added.
  • platform/graphics/GraphicsContext3D.h:

2011-01-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068

  • fast/canvas/webgl/read-pixels-test-expected.txt:
  • fast/canvas/webgl/read-pixels-test.html: Sync with khronos.
  • fast/canvas/webgl/resources/webgl-test.js: Add finishTest().
11:47 AM Changeset in webkit [75523] by enrica@apple.com
  • 39 edits
    2 deletes in trunk

Source/WebCore: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.

Reviewed by Alexey Proskuryakov.

No new tests. A test is already available for this
(editing/pasteboard/drag-image-to-contenteditable-in-iframe.html) but had incorrect results.

  • WebCore.exp.in:
  • loader/EmptyClients.h: Added two Mac only methods to call into WebKit to use functionality

that is in NSURLExtras.
(WebCore::EmptyEditorClient::canonicalizeURL):
(WebCore::EmptyEditorClient::canonicalizeURLString):

  • page/DragController.cpp:

The following methods have been changed to pass a pointer to the Frame object
to the DragData class.
(WebCore::documentFragmentFromDragData):
(WebCore::DragController::performDrag):
(WebCore::DragController::dispatchTextInputEventFor):
(WebCore::DragController::concludeEditDrag):

  • page/EditorClient.h: Added two Mac only methods to call into WebKit to use functionality

that is in NSURLExtras.
The following files have been modified to pass the Frame object to the DragData method calls.

  • page/chromium/DragControllerChromium.cpp:

(WebCore::DragController::dragOperation):

  • page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::dragOperation):

  • page/mac/DragControllerMac.mm:

(WebCore::DragController::dragOperation):

  • page/qt/DragControllerQt.cpp:

(WebCore::DragController::dragOperation):

  • page/win/DragControllerWin.cpp:

(WebCore::DragController::dragOperation):

  • platform/DragData.h: Removed Mac specific constructor and reference to PasteboardHelper class.
  • platform/Pasteboard.h: Added public constructor to create a Pasteboard object from an NSPasteboard.

The following files were all modified to match the new parameters of the methods listed.

  • platform/android/DragDataAndroid.cpp:

(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):

  • platform/gtk/DragDataGtk.cpp:

(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/haiku/DragDataHaiku.cpp:

(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::DragData):
(WebCore::DragData::asPlainText):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::getBestURL):
(WebCore::Pasteboard::asURL):

  • platform/qt/DragDataQt.cpp:

(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

  • platform/win/DragDataWin.cpp:

(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):

  • platform/wince/DragDataWinCE.cpp:

(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asFragment):

  • platform/wx/DragDataWx.cpp:

(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

WebKit: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.

Reviewed by Alexey Proskuryakov.

  • WebKit.xcodeproj/project.pbxproj: Removed WebPasteboardHelper.mm and WebPasteboardHelper.h.

WebKit/mac: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.

Reviewed by Alexey Proskuryakov.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality

exposed by NSURLExtras.
(WebEditorClient::canonicalizeURL):
(WebEditorClient::canonicalizeURLString):

  • WebCoreSupport/WebPasteboardHelper.h: Removed.
  • WebCoreSupport/WebPasteboardHelper.mm: Removed.
  • WebView/WebHTMLView.mm: Removed comment.
  • WebView/WebView.mm: The following methods have been changed to use the new DragData

constructor that doesn't use the WebPasteboardHelper reference.
(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):

WebKit2: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.

Reviewed by Alexey Proskuryakov.

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Added two methods to provide to WebCore functionality

exposed by NSURLExtras.
(WebKit::WebEditorClient::canonicalizeURL):
(WebKit::WebEditorClient::canonicalizeURLString):

LayoutTests: Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093

Reviewed by Alexey Proskuryakov.

New test results added to match the correct behavior.

  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
11:40 AM Changeset in webkit [75522] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; chromium test expectations update.

Remove failing expectations for tests that pass after r75515.

  • platform/chromium/test_expectations.txt:
11:40 AM Changeset in webkit [75521] by jberlin@webkit.org
  • 2 edits in trunk/WebKit2

Fix crash on launch on Windows.

Reviewed by Anders Carlsson and Sam Weinig.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onSizeEvent):
The drawing area is no longer initialized before the WebView is created and the first
onSize is receieved.

11:28 AM Changeset in webkit [75520] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-01-11 Eric Seidel <eric@webkit.org>

Unreviewed.

commit-queue should know how to upload archived results (for test flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048

I changed the API for archive_last_layout_test_results w/o updating the implementation. Oops.
This fixes an exception seen on the commit-queue when attempting to report flaky tests.

  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
11:24 AM Changeset in webkit [75519] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

RefPtr text node in setOuterText since calling appendData
on a text node can fire away dom event listener which might
remove the text node from underneath.
https://bugs.webkit.org/show_bug.cgi?id=52163

Test: fast/dom/text-node-append-data-remove-crash.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterText):

2011-01-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that calling append data on a text node which removes its
sibling text node does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=52163

  • fast/dom/text-node-append-data-remove-crash-expected.txt: Added.
  • fast/dom/text-node-append-data-remove-crash.html: Added.
10:50 AM Changeset in webkit [75518] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium-gpu test expectations update.

Remove now-passing tests from text_expectations.txt.

  • platform/chromium-gpu/test_expectations.txt:
10:49 AM Changeset in webkit [75517] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-11 Xan Lopez <xlopez@igalia.com>

Reviewed by Darin Adler.

Microoptimization in ~JSString
https://bugs.webkit.org/show_bug.cgi?id=52222

The case where m_fibers is 0 seems to be the most common one
(almost 1/2 of the time, followed at some distance by m_fibers = 1
in 1/4 of the cases in a typical SunSpider execution). We can save
one comparison in this common case by doing a bit of refactoring
in the JSString destructor; overall a 0.3% progression, but only
the string tests show improvement.

  • runtime/JSString.h: (JSC::RopeBuilder::~JSString):
10:49 AM Changeset in webkit [75516] by andersca@apple.com
  • 5 edits in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Automatically reinitialize the web page on relaunch
https://bugs.webkit.org/show_bug.cgi?id=52224
<rdar://problem/8765695>

  • UIProcess/API/mac/WKView.mm: (-[WKView _didRelaunchProcess]): Remove call to reinitializeWebPage.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::relaunch): Call initializeWebPage().

(WebKit::WebPageProxy::initializeWebPage):
Assert that the web page is valid here.

  • UIProcess/WebPageProxy.h: Remove reinitializeWebPage.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::didRelaunchProcess): Remove call to reinitializeWebPage.
10:46 AM Changeset in webkit [75515] by mihaip@chromium.org
  • 6 edits
    10 adds in trunk/LayoutTests

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; new and updated mac-leopard baselines.

Update stale or missing Leopard baselines (tests currently pass on Snow
Leopard).

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/block/basic/fieldset-stretch-to-legend-expected.checksum:
  • platform/mac-leopard/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/mac-leopard/fast/dom/focus-contenteditable-expected.checksum: Added.
  • platform/mac-leopard/fast/dom/focus-contenteditable-expected.png: Added.
  • platform/mac-leopard/fast/forms/fieldset-align-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/fieldset-align-expected.png: Added.
  • platform/mac-leopard/fast/multicol/columns-shorthand-parsing-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/columns-shorthand-parsing-expected.png: Added.
  • platform/mac-leopard/fast/text/capitalize-boundaries-expected.checksum: Added.
  • platform/mac-leopard/fast/text/capitalize-boundaries-expected.png: Added.
  • platform/mac-leopard/fast/text/softHyphen-expected.checksum: Added.
  • platform/mac-leopard/fast/text/softHyphen-expected.png: Added.
  • platform/mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.checksum:
  • platform/mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.png:
10:39 AM Changeset in webkit [75514] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

convert back to unified from sidebyside diff
https://bugs.webkit.org/show_bug.cgi?id=52180

Remove url fragment stuff. Having it be per-filediff is too complicated.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
10:37 AM Changeset in webkit [75513] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-01-11 Martin Robinson <mrobinson@igalia.com>

Unskipping fast/multicol/span/double-merge-anonymous-block-crash.html. We
have been unsuccessful reproducing the crash locally or on the bots.

  • platform/gtk/Skipped: Unskipping test.
10:36 AM Changeset in webkit [75512] by andersca@apple.com
  • 4 edits in trunk/WebKit2

2011-01-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Pass the view size to the DrawingAreaProxy constructor
https://bugs.webkit.org/show_bug.cgi?id=52189

  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewSize):
  • UIProcess/WebPageProxy.h:
10:29 AM Changeset in webkit [75511] by mihaip@chromium.org
  • 2 edits in trunk

2011-01-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Update .gitignore with new Chromium dependency.

ui/ was added with http://crrev.com/70743, we picked that up with a
Chromium roll in r75311.

Also alphabetizes the dependency list.

  • .gitignore:
10:27 AM Changeset in webkit [75510] by msaboff@apple.com
  • 4 edits
    6 adds in trunk

2011-01-10 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

ASSERTION Failure in JSC::binaryChop
https://bugs.webkit.org/show_bug.cgi?id=25614

Changed JITStubs::cti_register_file_check() to use the current stack's
return PC to find the bytecode for handling the exception in the prior
frame. Also added the appropriate arrity check routine call to the
JIT to bytecode vector (m_callReturnIndexVector) in the CodeBlock.

  • jit/JIT.cpp: (JSC::JIT::privateCompile): Changed the arrity check call location so that it gets added to the m_calls list so that it's included in CodeBlock::m_callReturnIndexVector.
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): Use the current call frame's return PC.

2011-01-11 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

ASSERTION Failure in JSC::binaryChop
https://bugs.webkit.org/show_bug.cgi?id=25614

Added new test to check for proper handling of stack overflow
exceptions and arrity exceptions while close to the top of the stack.

  • fast/js/script-tests/stack-overflow-arrity-catch.js: Added. (fWithTwoArgs): (test):
  • fast/js/script-tests/stack-overflow-catch.js: Added. (test):
  • fast/js/stack-overflow-arrity-catch-expected.txt: Added.
  • fast/js/stack-overflow-arrity-catch.html: Added.
  • fast/js/stack-overflow-catch-expected.txt: Added.
  • fast/js/stack-overflow-catch.html: Added.
10:05 AM Changeset in webkit [75509] by senorblanco@chromium.org
  • 14 edits in trunk/LayoutTests

2011-01-11 Stephen White <senorblanco@chromium.org>

Unreviewed; new chromium GPU test baselines.

These tests required rebaselining after the skia roll in
http://src.chromium.org/viewvc/chrome?view=rev&revision=70835.

  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.txt:
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.txt:
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.txt:
9:56 AM Changeset in webkit [75508] by weinig@apple.com
  • 27 edits
    8 adds in trunk

Tools: Roll r75474 back in.

WebKit2: Roll r75460 back in with build fix.

9:32 AM Changeset in webkit [75507] by Carlos Garcia Campos
  • 4 edits
    22 adds in trunk

2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add support for <meter> element
https://bugs.webkit.org/show_bug.cgi?id=48713

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.

2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add support for <meter> element
https://bugs.webkit.org/show_bug.cgi?id=48713

  • GNUmakefile.am: Enable meter element.
9:22 AM Changeset in webkit [75506] by kbalazs@webkit.org
  • 13 edits in trunk/WebKit2

2011-01-11 Anders Carlsson <andersca@apple.com>

Reviewed by Andreas Kling.

Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=52184

Qt part made my Balazs Kelemen.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::createDrawingAreaProxy): Call -[WKView _createDrawingAreaProxy].

(WebKit::PageClientImpl::setViewNeedsDisplay):
Call setNeedsDisplayInRect on the WKView.

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): No need to set the drawing area proxy anymore.

(-[WKView _createDrawingAreaProxy]):
Create a chunked update drawing area proxy for now.

  • UIProcess/API/qt/qgraphicswkview.cpp: Added a QGraphicsItem* member that is initialized in init to the accociated view. Implement the new functions. This is a temporary solution, in the long term the view and the page should be decoupled. (QGraphicsWKView::QGraphicsWKView):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::init): (QWKPagePrivate::createDrawingAreaProxy): (QWKPagePrivate::setViewNeedsDisplay):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h: Add new pure virtual member functions.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::reinitializeWebPage): Set the new drawing area proxy.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): No need to set the drawing area proxy anymore.

(WebKit::WebView::createDrawingAreaProxy):
Create a chunked update drawing area proxy for now.

(WebKit::WebView::setViewNeedsDisplay):
Invalidate the window.

8:49 AM Changeset in webkit [75505] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix.

[Qt][V8] Add missing include for debug build.

  • loader/cache/CachedResourceLoader.cpp:
8:37 AM Changeset in webkit [75504] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-11 Stephen White <senorblanco@chromium.org>

Unreviewed; yet another gpu test_expectations update.

All glory to the hypnotoad.

  • platform/chromium-gpu/test_expectations.txt:
8:33 AM Changeset in webkit [75503] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: redirects are lost from the network panel upon navigation.
https://bugs.webkit.org/show_bug.cgi?id=52210

  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
8:19 AM Changeset in webkit [75502] by jocelyn.turcotte@nokia.com
  • 7 edits in trunk

2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204

  • platform/network/qt/QtNAMThreadSafeProxy.cpp: (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy): (WebCore::QtNAMThreadSafeProxy::localCookiesForUrl): (WebCore::QtNAMThreadSafeProxy::localWillLoadFromCache):
  • platform/network/qt/QtNAMThreadSafeProxy.h: (WebCore::QtNAMThreadSafeProxy::cookiesForUrl): (WebCore::QtNAMThreadSafeProxy::willLoadFromCache):

2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204

  • QtTestBrowser/webpage.h: (QtNAMThread::QtNAMThread): (QtNAMThread::networkAccessManager): (QtNAMThread::run):

2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204

  • tests/qwebpage/tst_qwebpage.cpp: (QtNAMThread::QtNAMThread): (QtNAMThread::networkAccessManager): (QtNAMThread::run):
7:21 AM WebKit Team edited by pvarga@webkit.org
(diff)
7:09 AM Changeset in webkit [75501] by pvarga@webkit.org
  • 2 edits in trunk/Tools

2011-01-11 Peter Varga <pvarga@webkit.org>

Unreviewed.

Add myself to committers' list.

  • Scripts/webkitpy/common/config/committers.py:
6:37 AM Changeset in webkit [75500] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-01-11 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: recreate script view after live edit.
https://bugs.webkit.org/show_bug.cgi?id=51751

  • inspector/front-end/Script.js: (WebInspector.Script.prototype.set source):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource): (WebInspector.ScriptsPanel.prototype.viewRecreated):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._doEditLine):
6:33 AM Changeset in webkit [75499] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-11 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: frameDetachedFromParent notification handler is missing in NetworkManager.
https://bugs.webkit.org/show_bug.cgi?id=52205

  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.frameDetachedFromParent):
6:11 AM Changeset in webkit [75498] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: "Audit present state" always disabled
https://bugs.webkit.org/show_bug.cgi?id=52199

Removed all traces of resource tracking checks, as we have it no more.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
  • inspector/front-end/AuditsPanel.js:
6:09 AM Changeset in webkit [75497] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-11 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move delayed search implementation to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51753

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype.findSearchMatches): (WebInspector.SourceFrame.prototype.cancelFindSearchMatches):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.searchCanceled): (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches): (WebInspector.SourceView.prototype.performSearch):
6:07 AM Changeset in webkit [75496] by jorlow@chromium.org
  • 3 edits
    2 deletes in trunk/LayoutTests

2011-01-11 Jeremy Orlow <jorlow@chromium.org>

[Chromium] Fix bad baselines
https://bugs.webkit.org/show_bug.cgi?id=52207

It looks like https://bugs.webkit.org/show_bug.cgi?id=51865 didn't quite
get the baselines right. Ran the rebaseline tool to get these.

  • platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/getPresentationAttribute-expected.txt: Removed.
  • platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.txt:
  • platform/chromium-win/svg/custom/getPresentationAttribute-expected.txt:
6:07 AM Changeset in webkit [75495] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-11 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: innerFirstChild has a side effect which should be called explicitly.

If a node is a frame's owner then innerFirstChild method
subscribes DOMAgent instance to the frame's doc's events.
I think this should be done explicitly when we meet with
the node for the first time. As I understand it happens
in buildArrayForContainerChildren method.

https://bugs.webkit.org/show_bug.cgi?id=52204

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListeningFrameDoc): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::innerFirstChild):
  • inspector/InspectorDOMAgent.h:
5:48 AM Changeset in webkit [75494] by Adam Roben
  • 1 edit
    2 deletes in trunk/Source/WebCore

Delete WKCACFLayer.{cpp,h}

These have been unused since r75262

  • platform/graphics/win/WKCACFLayer.cpp: Removed.
  • platform/graphics/win/WKCACFLayer.h: Removed.
5:40 AM Changeset in webkit [75493] by Adam Roben
  • 3 edits in trunk/LayoutTests

Update test results after r75408

  • platform/mac-leopard/fast/js/large-expressions-expected.txt:
  • platform/win/fast/js/large-expressions-expected.txt:
5:26 AM Changeset in webkit [75492] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r63657 and r75305
https://bugs.webkit.org/show_bug.cgi?id=42578

After r75305 24 tests fail. Add them to the Skipped list temporarily to make buildbot happy.

  • platform/qt/Skipped:
5:19 AM Changeset in webkit [75491] by Adam Roben
  • 2 edits in trunk/WebKit2

Fix a typo in a comment

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
5:18 AM Changeset in webkit [75490] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Roll out r75487 since it broke the 32-bit build.

5:17 AM Changeset in webkit [75489] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [regression] Cookies view does not allow columns resize.
https://bugs.webkit.org/show_bug.cgi?id=51877

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._updateWithCookies):
4:46 AM Changeset in webkit [75488] by commit-queue@webkit.org
  • 4 edits in trunk

2011-01-11 Noel Gordon <noel.gordon@gmail.com>

Reviewed by James Robinson.

[chromium] canvas.toDataURL("image/jpeg") should composite onto black.
https://bugs.webkit.org/show_bug.cgi?id=51237

canvas/philip/tests/toDataURL.jpeg.alpha.html only fails on chromium-mac
now, tracked by bug http://webkit.org/b/40147.

  • platform/chromium/test_expectations.txt: win & linux pass.

2011-01-11 Noel Gordon <noel.gordon@gmail.com>

Reviewed by James Robinson.

[chromium] canvas.toDataURL("image/jpeg") should composite onto black.
https://bugs.webkit.org/show_bug.cgi?id=51237

The Canvas specification requires that the canvas image is composited using
the Porter-Duff operator source-over onto a black background; the resultant
image should be JPEG encoded and returned as a dataURL. To composite image
A and background B, for any Porter-Duff operator, produce pixels I with

I = c(A)F(A) + c(B)F(B)

where, F(X) is the fraction [0.0-1.0] contributed to the composite by image
X, and c(X) are the premultiplied RGB color components of image X. Note by
definition, c(B) = 0 since the background is black, so I = c(A)F(A). Since
F(A) = 1 in Porter-Duff operator source-over, the composited pixels satisfy
I = c(A). Hence, to conform to the Canvas spec, pass the premultiplied RGB
color components of the canvas image to the JPEG encoder.

Covered by canvas/philip/tests/toDataURL.jpeg.alpha.html

  • platform/image-encoders/skia/JPEGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGB): Use Porter-Duff source-over black.
4:44 AM Changeset in webkit [75487] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-11 François Sausset <François Sausset>

Reviewed by Eric Seidel.

Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
https://bugs.webkit.org/show_bug.cgi?id=52201

Replace unneeded doubles by floats and remove unneeded casts.

  • rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
  • rendering/mathml/RenderMathMLFraction.h:
4:31 AM Changeset in webkit [75486] by pfeldman@chromium.org
  • 8 edits in trunk

2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: get rid of APU-related code in WebKit/chromium.
https://bugs.webkit.org/show_bug.cgi?id=52152

  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::setInjectedScriptSource):
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/inspector.js:

2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: get rid of APU-related code in WebKit/chromium.
https://bugs.webkit.org/show_bug.cgi?id=52152

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::frontendLoaded): (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend):
  • src/WebDevToolsAgentImpl.h:
3:44 AM Changeset in webkit [75485] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Load timing is requested
for all resources (not only for the main one).
https://bugs.webkit.org/show_bug.cgi?id=51749

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
3:38 AM Changeset in webkit [75484] by antonm@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed Chromium test expectations update.

Remove now unnecessary Chromium overrides.

  • platform/chromium-mac/fast/regex/malformed-escapes-expected.txt: Removed.
  • platform/chromium-win/fast/regex/malformed-escapes-expected.txt: Removed.
3:36 AM Changeset in webkit [75483] by pfeldman@chromium.org
  • 1 edit in branches/chromium/597/WebCore/inspector/front-end/StylesSidebarPane.js

Merge 74710 - 2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663

  • inspector/elements-tests2.js: (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Drive-by: remove bad test exit code.
  • inspector/resources/styles-url-linkify-iframe.html: Added.
  • inspector/resources/styles-url-linkify.css: Added. (#local):
  • inspector/styles-url-linkify-expected.txt: Added.
  • inspector/styles-url-linkify.html: Added.

2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663

The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
optional quotes/apostrophes and spaces are now allowed inside uri(...).

Test: inspector/styles-url-linkify.html

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):

TBR=apavlov@chromium.org
BUG=68159
Review URL: http://codereview.chromium.org/6115007

3:26 AM Changeset in webkit [75482] by commit-queue@webkit.org
  • 6 edits
    8 adds in trunk/LayoutTests

2011-01-11 Shane Stephens <shanestephens@google.com>

Reviewed by Eric Seidel.

[Chromium] Tests marked as WONTFIX SKIP but bug causing test failure fixed.
https://bugs.webkit.org/show_bug.cgi?id=51865

  • platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.png: Added.
  • platform/chromium-linux/svg/custom/fill-SVGPaint-interface-expected.txt: Added.
  • platform/chromium-linux/svg/custom/getPresentationAttribute-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/getPresentationAttribute-expected.png: Added.
  • platform/chromium-linux/svg/custom/getPresentationAttribute-expected.txt: Added.
  • platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.checksum:
  • platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.png:
  • platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.txt: Added.
  • platform/chromium-win/svg/custom/getPresentationAttribute-expected.checksum:
  • platform/chromium-win/svg/custom/getPresentationAttribute-expected.png:
  • platform/chromium-win/svg/custom/getPresentationAttribute-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:18 AM Changeset in webkit [75481] by Carlos Garcia Campos
  • 10 edits in trunk

2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] GRefPtr should not be used with Gtk widgets
https://bugs.webkit.org/show_bug.cgi?id=51241

GRefPtr breaks the widget life-cycle, the main problem is
that GRefPtr calls g_object_unref() when it's destroyed,
which is undesirable for widgets. In gtk+ widgets are created with
a floating reference and when added to a container, the container
takes the ownership of the widget consuming the floating
reference. So you don't usually need to call g_object_ref/unref on
widgets (only for some operations like reparent a widget) and
toplevel widgets are destroyed with gtk_widget_destroy().

  • platform/ContextMenuItem.h:
  • platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::setPlatformDescription):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled):

2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] GRefPtr should not be used with Gtk widgets
https://bugs.webkit.org/show_bug.cgi?id=51241

GRefPtr breaks the widget life-cycle, the main problem is
that GRefPtr calls g_object_unref() when it's destroyed,
which is undesirable for widgets. In gtk+ widgets are created with
a floating reference and when added to a container, the container
takes the ownership of the widget consuming the floating
reference. So you don't usually need to call g_object_ref/unref on
widgets (only for some operations like reparent a widget) and
toplevel widgets are destroyed with gtk_widget_destroy().

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::DragClient): (WebKit::DragClient::~DragClient): (WebKit::DragClient::startDrag):
  • WebCoreSupport/DragClientGtk.h:
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup):
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose):
  • webkit/webkitwebviewprivate.h:
2:36 AM Changeset in webkit [75480] by eric@webkit.org
  • 10 edits
    2 adds in trunk/Tools

2011-01-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should know how to upload archived results (for test flakes or general failures)
https://bugs.webkit.org/show_bug.cgi?id=52048

Now the queue will always upload results. Either the entire zip, or just
the diffs.txt in the case of text failures.

This should make understanding flakes much easier, and paves the way
for having the EWS run layout tests (and upload failures).

In order to upload .zip files I had to teach bugzilla.py to autodetect
mime types from the filename. Since mimetypes.py doesn't include a mapping
for .patch files, I have it add one before calling guess_type.

We may find that always uploading the whole zip instead of just the -diffs.txt
file is preferable, but for now I'm keeping the old behavior because it makes
quickly understanding text failures easy.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/system/workspace.py: Added.
  • Scripts/webkitpy/common/system/workspace_unittest.py: Added.
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
2:08 AM Changeset in webkit [75479] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2011-01-11 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix tst_QWebPage::geolocationRequestJS()
https://bugs.webkit.org/show_bug.cgi?id=46814

Skip the test when WebKit is compiled without geolocation.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::geolocationRequestJS):

Jan 10, 2011:

10:12 PM Changeset in webkit [75478] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Reorganized scrollbar-related failures.

  • platform/chromium/test_expectations.txt:
10:07 PM Changeset in webkit [75477] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Remove entries for tests that now pass.

A bunch of tests with scrollbars started to pass after unncessary
Chromium baselines with removed with r75463, r75446 and
r75440.

ietestcenter/Javascript/15.4.4.14-9-b-i-6.html and ietestcenter/
Javascript/15.4.4.15-8-b-i-6.html started to pass after
http://crrev.com/70894, which rolled V8 to 3.0.7, which fixed
http://code.google.com/p/v8/issues/detail?id=1015.

fast/text/font-size-zero.html appears to always pass.

  • platform/chromium/test_expectations.txt:
9:45 PM Changeset in webkit [75476] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-10 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium-gpu test_expectations updates.

Mark 3 tests as failing after skia roll (chromium r75408).

  • platform/chromium-gpu/test_expectations.txt:
8:50 PM Changeset in webkit [75475] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

Unreviewed, rolling out r75464.
http://trac.webkit.org/changeset/75464
https://bugs.webkit.org/show_bug.cgi?id=52193

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-10
Followup rollout for 75474 (Requested by Ossy on #webkit).

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

8:40 PM Changeset in webkit [75474] by Csaba Osztrogonác
  • 23 edits
    8 deletes in trunk/WebKit2

Unreviewed, rolling out r75460.
http://trac.webkit.org/changeset/75460
https://bugs.webkit.org/show_bug.cgi?id=52191

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-10
It broke Qt-WK2 build (Requested by Ossy on #webkit).

  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKGeolocationPermissionRequest.cpp: Removed.
  • UIProcess/API/C/WKGeolocationPermissionRequest.h: Removed.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp: Removed.
  • UIProcess/GeolocationPermissionRequestManagerProxy.h: Removed.
  • UIProcess/GeolocationPermissionRequestProxy.cpp: Removed.
  • UIProcess/GeolocationPermissionRequestProxy.h: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/WebUIClient.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: Removed.
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.h: Removed.
  • WebProcess/Geolocation/WebGeolocationManager.cpp:
  • WebProcess/Geolocation/WebGeolocationManager.h:
  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp:

(WebKit::WebGeolocationClient::requestPermission):
(WebKit::WebGeolocationClient::cancelPermissionRequest):

  • WebProcess/WebCoreSupport/WebGeolocationClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
8:29 PM Changeset in webkit [75473] by Csaba Osztrogonác
  • 11 edits in trunk/WebKit2

Unreviewed, rolling out r75459
http://trac.webkit.org/changeset/75459

Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=52184

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):

  • UIProcess/win/WebView.h:
8:14 PM Changeset in webkit [75472] by Beth Dakin
  • 3 edits
    2 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=51119, transformed
elements not responding properly to :hover after r73385.
Just use the entire document area as the hit test area,
since there appears to be a rounding bug/issues with relying
on float math when mapping the hit test area into
transformed coordinates.

Patch by David Hyatt <hyatt@apple.com> on 2010-10-10
Reviewed by Simon Fraser.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=51119

Patch by David Hyatt <hyatt@apple.com> on 2011-01-10
Reviewed by Simon Fraser.

  • fast/transforms/transform-hit-test-flipped-expected.txt: Added.
  • fast/transforms/transform-hit-test-flipped.html: Added.
8:05 PM Changeset in webkit [75471] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-10 Justin Schuh <jschuh@chromium.org>

Unreviewed Chromium test expectations update.

Fix path for: fast/js/kde/parse.html

  • platform/chromium/test_expectations.txt:
7:48 PM Changeset in webkit [75470] by jschuh@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-10 Justin Schuh <jschuh@chromium.org>

Unreviewed Chromium test expectations update.

Mark 3 tests as failing on chromium after r75408.

  • platform/chromium/test_expectations.txt:
7:29 PM Changeset in webkit [75469] by senorblanco@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-10 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Fix canvas->canvas draws on the GPU path.
https://bugs.webkit.org/show_bug.cgi?id=52141


Two problems: according to the canvas spec, both source and
destination rects can have negative width or height, but this shouldn't
cause the image to be flipped. So we need to normalize the rects (in
the software path, this is done by BitmapImage*::draw). Secondly, in
the FBO->FBO path, the image needs to be flipped vertically, since it
is drawn upside down. We were doing this by flipping the destination
rect, but this doesn't work if the source rect is not the entire image,
since we extract the wrong part of the image. Fixed by flipping the
source rect instead (and flipping it within the image buffer's height,
not the source rect's height).

Covered by fast/canvas/drawImage-with-negative-source-destination.html.

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h: Put normalizeRect() in global scope.
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::draw): Fix as above: normalize both source and dest rects, and flip the source rect instead of the dest rect.
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::normalizeRect): Put normalizeRect() in global scope.
6:57 PM Changeset in webkit [75468] by andersca@apple.com
  • 6 edits in trunk/WebKit2

2011-01-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove size parameter to WebPageProxy::initializeWebPage
https://bugs.webkit.org/show_bug.cgi?id=52188

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::init):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage):
  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView):
6:50 PM Changeset in webkit [75467] by Laszlo Gombos
  • 20 edits in trunk

2011-01-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313

  • WebKit.pri: List the supported QT_NO_FEATURE flags under qt_minimal configuration.

2011-01-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313

No new tests as there is no new functionality.

  • platform/graphics/qt/GraphicsLayerQt.cpp: Fix the location of the QT_NO_ANIMATION guard.
  • platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::applyDelta): Fix the location of the QT_NO_WHEELEVENT guard.

2011-01-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add QT_NO_UNDOSTACK guard.
  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER guards. (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard. (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard. (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard. (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
  • QtTestBrowser/launcherwindow.h:
  • QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
  • QtTestBrowser/locationedit.h: Ditto.
  • QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and QT_NO_UNDOSTACK guards. (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard. (MainWindow::changeLocation): Ditto. (MainWindow::openFile): Add QT_NO_FILEDIALOG guard. (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
  • QtTestBrowser/webpage.cpp: (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard. (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard. (WebViewGraphicsBased::animatedYFlip): Ditto.

2011-01-10 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313

  • WebCoreSupport/PopupMenuQt.cpp: (WebCore::PopupMenuQt::show): Add QT_NO_COMBOBOX guard.
  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate): Add QT_NO_TOOLTIP guard.
  • tests/qwebframe/tst_qwebframe.cpp: Add QT_NO_COMBOBOX guard.
  • tests/qwebpage/tst_qwebpage.cpp: (PluginPage::createPlugin): Add QT_NO_INPUTDIALOG guard.
6:50 PM Changeset in webkit [75466] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Didn't mean to land this.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):

  • UIProcess/WebPageProxy.h:
6:49 PM Changeset in webkit [75465] by andersca@apple.com
  • 4 edits in trunk/WebKit2

2011-01-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebPageProxy::creationParameters no longer needs to take a size
https://bugs.webkit.org/show_bug.cgi?id=52187

WebPageProxy::creationParameters can just ask the page client for the view size now.

  • UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::createInspectorPage):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::reinitializeWebPage): (WebKit::WebPageProxy::createNewPage): (WebKit::WebPageProxy::creationParameters):
  • UIProcess/WebPageProxy.h:
6:48 PM Changeset in webkit [75464] by weinig@apple.com
  • 4 edits in trunk/Tools

Fix build.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

6:46 PM Changeset in webkit [75463] by mihaip@chromium.org
  • 7 edits
    2 adds
    6 deletes in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Remove chromium-mac baselines for css1/ and css2.1/ tests that had them
because of scrollbars. Update stale mac-leopard baselines.

  • platform/chromium-mac/css1/box_properties/clear-expected.checksum: Removed.
  • platform/chromium-mac/css1/box_properties/clear-expected.png: Removed.
  • platform/chromium-mac/css1/text_properties/text_transform-expected.checksum: Removed.
  • platform/chromium-mac/css1/text_properties/text_transform-expected.png: Removed.
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.checksum: Removed.
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.png: Removed.
  • platform/mac-leopard/css1/box_properties/clear_float-expected.checksum:
  • platform/mac-leopard/css1/box_properties/clear_float-expected.png:
  • platform/mac-leopard/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/mac-leopard/css1/box_properties/float_elements_in_series-expected.png:
  • platform/mac-leopard/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/mac-leopard/css1/box_properties/float_on_text_elements-expected.png:
  • platform/mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
  • platform/mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
6:39 PM Changeset in webkit [75462] by andersca@apple.com
  • 5 edits in trunk/WebKit2

2011-01-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Pass information about the view in the WebPageCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=52186

  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode): Encode and decode the state flags.
  • Shared/WebPageCreationParameters.h: Add new state flags.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): Initialize the state flags.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Update the page state from the state flags.
6:26 PM Changeset in webkit [75461] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

2011-01-10 Joe Mason <jmason@rim.com>

Reviewed by Alexey Proskuryakov.

WebSockets: unbounded buffer growth when server sends bad data
https://bugs.webkit.org/show_bug.cgi?id=51253

Tests that a websocket handshake should fail after 1024 bytes without a
newline, or if it contains a null byte before the first newline.

  • http/tests/websocket/tests/handshake-fail-by-maxlength-expected.txt: Added.
  • http/tests/websocket/tests/handshake-fail-by-maxlength.html: Added.
  • http/tests/websocket/tests/handshake-fail-by-maxlength_wsh.py: Added.
  • http/tests/websocket/tests/handshake-fail-by-prepended-null-expected.txt: Added.
  • http/tests/websocket/tests/handshake-fail-by-prepended-null.html: Added.
  • http/tests/websocket/tests/handshake-fail-by-prepended-null_wsh.py: Added.

2011-01-10 Joe Mason <jmason@rim.com>

Reviewed by Alexey Proskuryakov.

WebSockets: unbounded buffer growth when server sends bad data
https://bugs.webkit.org/show_bug.cgi?id=51253

Fail a websocket handshake after 1024 bytes without a newline, or if it
contains a null byte before the first newline.

Tests: http/tests/websocket/tests/handshake-fail-by-maxlength.html

http/tests/websocket/tests/handshake-fail-by-prepended-null.html

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readStatusLine):
6:13 PM Changeset in webkit [75460] by weinig@apple.com
  • 23 edits
    8 adds in trunk/WebKit2

Make Geolocation features work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52078

Reviewed by Anders Carlsson.

Step 2 - Add support for requesting and granting permission for geolocation.

  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKGeolocationPermissionRequest.cpp: Added.
  • UIProcess/API/C/WKGeolocationPermissionRequest.h: Added.

Add new API type, WKGeolocationPermissionRequestRef.

  • UIProcess/API/C/WKPage.h:

Add new UIClient function for requesting permission.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):
Stub out the UIClient.

  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp: Added.
  • UIProcess/GeolocationPermissionRequestManagerProxy.h: Added.
  • UIProcess/GeolocationPermissionRequestProxy.cpp: Added.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/WebUIClient.h:
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: Added.
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.h: Added.
  • WebProcess/Geolocation/WebGeolocationManager.cpp:
  • WebProcess/Geolocation/WebGeolocationManager.h:
  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
  • WebProcess/WebCoreSupport/WebGeolocationClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::didReceiveGeolocationPermissionDecision):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::geolocationPermissionRequestManager):

  • WebProcess/WebPage/WebPage.messages.in:

Track the permission request through both sides of the process divide.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

6:12 PM Changeset in webkit [75459] by andersca@apple.com
  • 11 edits in trunk/WebKit2

2011-01-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=52184

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::createDrawingAreaProxy): Call -[WKView _createDrawingAreaProxy].

(WebKit::PageClientImpl::setViewNeedsDisplay):
Call setNeedsDisplayInRect on the WKView.

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): No need to set the drawing area proxy anymore.

(-[WKView _createDrawingAreaProxy]):
Create a chunked update drawing area proxy for now.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy): (QWKPagePrivate::setViewNeedsDisplay): Add stubs.


  • UIProcess/PageClient.h: Add new pure virtual member functions.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeWebPage): (WebKit::WebPageProxy::reinitializeWebPage): Set the new drawing area proxy.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): No need to set the drawing area proxy anymore.

(WebKit::WebView::createDrawingAreaProxy):
Create a chunked update drawing area proxy for now.

(WebKit::WebView::setViewNeedsDisplay):
Invalidate the window.

6:09 PM Changeset in webkit [75458] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.3.10

Branching for WebKitGTK+ release

5:33 PM Changeset in webkit [75457] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build again.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::isViewWindowActive):

5:06 PM Changeset in webkit [75456] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onShowWindowEvent):

5:02 PM Changeset in webkit [75455] by abarth@webkit.org
  • 9 edits in trunk

2011-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182

This patch adds a Chromium API for registering schemes as
display-isolated. In a subsequent patch, I'll change the "chrome"
scheme in Chrome to be display isolated instead of local. That will
prevent file URLs from linking to chrome URLs.

  • public/WebSecurityPolicy.h:
  • src/WebSecurityPolicy.cpp: (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):

2011-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182

Update to new function name.

  • Api/qwebsecurityorigin.cpp: (QWebSecurityOrigin::localSchemes):

2011-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182

This patch adds the basic plumbing for display-isolated URL schemes.
Originally, this patch also had the functional change, but I've split
that off into a separate patch because the original patch caused a
performance regression.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay):
  • platform/SchemeRegistry.cpp: (WebCore::displayIsolatedURLSchemes): (WebCore::SchemeRegistry::registerURLSchemeAsLocal): (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal): (WebCore::SchemeRegistry::localSchemes): (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal): (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
  • platform/SchemeRegistry.h:
4:51 PM Changeset in webkit [75454] by dbates@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-10 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Remove extraneous COMPILER(GCC) condition when checking GCC_VERSION_AT_LEAST()
https://bugs.webkit.org/show_bug.cgi?id=52178

It is sufficient to test GCC_VERSION_AT_LEAST() instead of both COMPILER(GCC) and
GCC_VERSION_AT_LEAST(). Notice GCC_VERSION_AT_LEAST() is defined to be 0 when we
are not compiling with GCC.

Fixes style issues at the callsites (i.e. replace comma with comma-space in
macro function argument list). Also, makes a spelling correction in a comment.

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
  • wtf/Platform.h:
4:47 PM Changeset in webkit [75453] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix: removed some uses of nextNumber that I missed last time.

  • runtime/Heap.cpp:

(JSC::Heap::reset):
(JSC::Heap::collectAllGarbage):

4:45 PM Changeset in webkit [75452] by andersca@apple.com
  • 17 edits in trunk/WebKit2

2011-01-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Use a pull model for view state changes
https://bugs.webkit.org/show_bug.cgi?id=52175

Instead of having the WKView call setFocused, setActive etc on the WebPageProxy, the
WKView now simply informs the WebPageProxy what has changed, using the WebPageProxy::viewStateDidChange
function. The WebPageProxy can then fetch the relevant information using newly added PageClient functions.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::viewSize): (WebKit::PageClientImpl::isViewWindowActive): (WebKit::PageClientImpl::isViewFocused): (WebKit::PageClientImpl::isViewVisible): (WebKit::PageClientImpl::isViewInWindow):
  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:contextRef:pageGroupRef:]): (-[WKView becomeFirstResponder]): (-[WKView resignFirstResponder]): (-[WKView viewDidMoveToWindow]): (-[WKView _windowDidBecomeKey:]): (-[WKView _windowDidResignKey:]): (-[WKView viewDidHide]): (-[WKView viewDidUnhide]): (-[WKView _isFocused]): (-[WKView _didRelaunchProcess]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::focusInEvent): (QGraphicsWKView::focusOutEvent):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::viewSize): (QWKPagePrivate::isViewWindowActive): (QWKPagePrivate::isViewFocused): (QWKPagePrivate::isViewVisible): (QWKPagePrivate::isViewInWindow):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::createWebPage):
  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::create): (WebKit::WebPageProxy::WebPageProxy): (WebKit::WebPageProxy::viewStateDidChange):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::createWebPage):
  • UIProcess/WebProcessProxy.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::onSetFocusEvent): (WebKit::WebView::onKillFocusEvent): (WebKit::WebView::onShowWindowEvent): (WebKit::WebView::updateActiveState): (WebKit::WebView::viewSize): (WebKit::WebView::isViewWindowActive): (WebKit::WebView::isViewFocused): (WebKit::WebView::isViewVisible): (WebKit::WebView::isViewInWindow): (WebKit::WebView::didRelaunchProcess): (WebKit::WebView::setIsInWindow):
  • UIProcess/win/WebView.h:
4:41 PM Changeset in webkit [75451] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed dead number allocation code.
https://bugs.webkit.org/show_bug.cgi?id=52177

  • runtime/Heap.h:
4:29 PM Changeset in webkit [75450] by jer.noble@apple.com
  • 7 edits in trunk

2011-01-10 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=52095
REGRESSION (r75277): 2 test cases (<1%) had incorrect layout

Fixes tests:

fullscreen/full-screen-remove-ancestor.html
fullscreen/full-screen-remove.html

Revert change made in r75326, now that the underlying issue has been fixed.

  • fullscreen/full-screen-remove-ancestor-expected.txt:
  • fullscreen/full-screen-remove-expected.txt:

2011-01-10 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=52095
REGRESSION (r75277): 2 test cases (<1%) had incorrect layout

Fixes tests:

fullscreen/full-screen-remove-ancestor.html
fullscreen/full-screen-remove.html

Previously, the above tests were failing because DRT dumped the contents of their
<script> tags, though all the explicit tests were passing. This was caused by
the document's render tree being left in an inconsistent state when a full screen
element's ancestor was removed from the DOM.

In nodeWillBeRemoved(), match the code in webkitDidExitFullScreen().
Don't detach the documentElement, but rather simply call recalcStyle(Force).

  • dom/Document.cpp: (WebCore::Document::nodeWillBeRemoved):
  • rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating): #if ENABLED -> # if USE
  • rendering/RenderFullScreen.h: (WebCore::RenderFullScreen::RenderFullScreen): RenderFullScreen should be an anonymous renderer.
4:29 PM Changeset in webkit [75449] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Update the NEWS file in preparation for the 1.3.10 release.

  • NEWS: Update the NEWS.
4:27 PM Changeset in webkit [75448] by jam@chromium.org
  • 12 edits in trunk

2011-01-10 John Abd-El-Malek <jam@chromium.org>

Reviewed by James Robinson.

[chromium] Call WebAutoFillClient instead of WebViewClient for autofill related callbacks
https://bugs.webkit.org/show_bug.cgi?id=52169

  • public/WebView.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::didUpdateInspectorSetting):
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionChanged): (WebKit::AutoFillPopupMenuClient::selectionCleared): (WebKit::AutoFillPopupMenuClient::popupDidHide):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::textFieldDidBeginEditing): (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::textDidChangeInTextField): (WebKit::EditorClientImpl::doAutofill): (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted): (WebKit::EditorClientImpl::doTextFieldCommandFromEvent):
  • src/WebViewImpl.cpp: (WebKit::WebView::create): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::autoFillClient):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::initializeLoader):
4:17 PM Changeset in webkit [75447] by dbates@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-10 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Use builtin_expect when compiling using RVCT in GNU mode
https://bugs.webkit.org/show_bug.cgi?id=51866

We should only use builtin_expect if we are compiling with GCC or RVCT 3 or higher in GNU mode
as pointed out by Siddharth Mathur per <http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0202h/Cjabddedbde.html>.

  • wtf/AlwaysInline.h:
  • wtf/Platform.h: Removed define WTF_COMPILER_RVCT4_OR_GREATER. Instead added macro function RVCT_VERSION_AT_LEAST so that we can test for an arbitrary minimum RVCT version.
4:16 PM Changeset in webkit [75446] by mihaip@chromium.org
  • 3 edits
    30 deletes in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Remove chromium-mac baselines for svg/ tests that had them because of
scrollbars.

Also updates Snow Leopard (mac) baselines for svg/dom/
SVGLengthList-basics.xhtml after r72518.

  • platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/links/003-broken-expected.checksum: Removed.
  • platform/chromium-mac/svg/hixie/links/003-broken-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
  • platform/mac/svg/dom/SVGLengthList-basics-expected.checksum:
  • platform/mac/svg/dom/SVGLengthList-basics-expected.png:
4:05 PM Changeset in webkit [75445] by ggaren@apple.com
  • 2 edits in trunk/WebKit/win

Try to fix Windows build.

  • WebJavaScriptCollector.cpp: Updated for rename to Heap.*. (Didn't catch

this one before because it was miscapitalized.)

3:52 PM Changeset in webkit [75444] by Martin Robinson
  • 6 edits in trunk

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove use of deprecated GTK+ methods before the 1.3.10 release
https://bugs.webkit.org/show_bug.cgi?id=52173

No new tests. This is only a build fix.

  • platform/gtk/GRefPtrGtk.cpp: Guard the GdkCursor specialization against GTK+ 3.x. In GTK+ 3.x, GdkCursor is just a GObject.
  • platform/gtk/GRefPtrGtk.h: Ditto.

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove use of deprecated GTK+ methods before the 1.3.10 release
https://bugs.webkit.org/show_bug.cgi?id=52173

  • WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::enterFullscreen): Use a GRefPtr here to avoid having to call either g_object_unref or gdk_cursor_unref.
  • webkit/webkitwebview.cpp: Guard use of deprecated methods. (webkit_web_view_realize): Ditto. (webkit_web_view_drag_end): Ditto.
3:43 PM Changeset in webkit [75443] by ggaren@apple.com
  • 32 edits
    3 moves in trunk/Source

Moved Collector.* => Heap.*, since the file contains a class named "Heap".

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • API/JSCallbackObject.cpp:
  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • interpreter/Interpreter.cpp:
  • interpreter/RegisterFile.h:
  • jit/JITStubs.cpp:
  • runtime/Collector.cpp: Removed.
  • runtime/Collector.h: Removed.
  • runtime/CollectorHeapIterator.h:
  • runtime/GCActivityCallbackCF.cpp:
  • runtime/Heap.cpp: Copied from JavaScriptCore/runtime/Collector.cpp.
  • runtime/Heap.h: Copied from JavaScriptCore/runtime/Collector.h.
  • runtime/InitializeThreading.cpp:
  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:
  • runtime/JSLock.cpp:
  • runtime/JSNumberCell.h:
  • runtime/MachineStackMarker.cpp:
  • runtime/MemoryStatistics.h:
  • runtime/Protect.h:
  • runtime/UString.cpp:
  • runtime/WeakGCMap.h:
  • runtime/WeakGCPtr.h:

Source/JavaScriptGlue:

  • JSUtils.h:

Source/WebCore:

  • ForwardingHeaders/runtime/Collector.h: Removed.
  • ForwardingHeaders/runtime/Heap.h: Copied from WebCore/ForwardingHeaders/runtime/Collector.h.
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/GCController.cpp:
  • bindings/js/ScriptGCEvent.cpp:
3:30 PM Changeset in webkit [75442] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Layout test fast/frames/iframe-reparenting-plugins.html is failing on windows
https://bugs.webkit.org/show_bug.cgi?id=52062

Patch by Jenn Braithwaite <jennb@chromium.org> on 2011-01-10
Reviewed by Dmitry Titov.

  • platform/chromium/test_expectations.txt:

Skip the failing test. Same reason other tests using WebKit Test PlugIn fails.

3:14 PM Changeset in webkit [75441] by Martin Robinson
  • 4 edits in trunk/LayoutTests

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Rebaseline some test results after r75389.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
3:04 PM Changeset in webkit [75440] by mihaip@chromium.org
  • 12 edits
    2 adds
    7 deletes in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

More scrollbar change rebaselines.

  • platform/chromium-mac/fast/selectors/166-expected.checksum: Removed.
  • platform/chromium-mac/fast/selectors/166-expected.png: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/height-percent-test-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png: Removed.
  • platform/chromium-mac/svg/css/composite-shadow-example-expected.checksum:
  • platform/chromium-mac/svg/css/composite-shadow-example-expected.png:
  • platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
  • platform/mac-leopard/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.checksum:
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/mac/fast/table/height-percent-test-vertical-expected.checksum:
  • platform/mac/fast/table/height-percent-test-vertical-expected.png:
2:47 PM Changeset in webkit [75439] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-10 Leonid Ebril <leonid.ebril@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=51879

Set the PluginQuirkDontSetNullWindowHandleOnDestroy for Adobe Lite
plugin if Flash 10 or newer (for Symbian platform), setting a nulled
window handler on destroy crashes WebKit.

  • plugins/symbian/PluginPackageSymbian.cpp: (WebCore::PluginPackage::fetchInfo): (WebCore::PluginPackage::determineQuirks):
2:37 PM Changeset in webkit [75438] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-01-10 Eric Seidel <eric@webkit.org>

Reviewed by Ojan Vafai.

style-queue messages are way too long for big patches
https://bugs.webkit.org/show_bug.cgi?id=52161

We definitely could build much fancier list-to-string-with-limit functions
but this should be sufficient for our needs at the moment.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
2:04 PM Changeset in webkit [75437] by Martin Robinson
  • 8 edits
    1 move
    2 deletes in trunk/Source/WebCore

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove unecessary RenderThemeGtk and WidgetRenderingContext code
https://bugs.webkit.org/show_bug.cgi?id=52170

Remove unnecessary code from RenderThemeGtk3 and RenderThemeGtk now that the
GtkStyleContext port is complete. Also remove WidgetRenderingContextGtk3 and
move WidgetRenderingRenderingContextGtk2 to WidgetRenderingContext and make it
GTK+ 2.x only. Some methods have been moved to RenderThemeGtk2 since they are
GTK+ 2.x only now.

No new tests. This should not change functionality.

  • GNUmakefile.am: Remove WidgetRenderingContextGtk3 and gtk3drawing.c
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::gtkIconState): Made this method static. It isn't used outside RenderThemeGtk. (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): Updated to refelct gtkIconState change. (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): Ditto. (WebCore::RenderThemeGtk::paintMediaButton): Ditto
  • platform/gtk/RenderThemeGtk.h: Move a few methods which are now GTK+ 2.x only.
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::platformInit): Added this platform initialization method that is only used for GTK+ 2.x at the moment. (WebCore::RenderThemeGtk::~RenderThemeGtk): Added. (WebCore::getGtkStateType): Made this method static. (WebCore::RenderThemeGtk::getIndicatorMetrics): Moved this here from RenderThemeGtk. (WebCore::setToggleSize): Updated to reflect changes to getGtkStateType. (WebCore::RenderThemeGtk::paintButton): Ditto. (WebCore::RenderThemeGtk::paintSliderTrack): Ditto. (WebCore::RenderThemeGtk::paintSliderThumb): Ditto.
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::gtkScrollbarStyle): Moved to the top of the file. (WebCore::RenderThemeGtk::platformInit): Added. (WebCore::RenderThemeGtk::~RenderThemeGtk): Added. (WebCore::RenderThemeGtk::initMediaColors): Changed to use the GtkStyleContext API to fetch these colors. This was the last dependency on the old API.
  • platform/gtk/WidgetRenderingContext.cpp: Renamed from Source/WebCore/platform/gtk/WidgetRenderingContextGtk2.cpp.
  • platform/gtk/WidgetRenderingContext.h: Made GTK+ 2.x only.
  • platform/gtk/WidgetRenderingContextGtk3.cpp: Removed.
  • platform/gtk/gtk3drawing.c: Removed.
  • platform/gtk/gtkdrawing.h: Made GTK+ 2.x only.
2:03 PM Changeset in webkit [75436] by inferno@chromium.org
  • 1 edit in branches/chromium/597/WebCore/dom/Range.cpp

Merge 75002 - Merge 73818 Build Fix

BUG=65942
Review URL: http://codereview.chromium.org/6085014

2:02 PM Changeset in webkit [75435] by Adam Roben
  • 2 edits in trunk/WebKit2

Don't pass a reference type to va_start

C++ says this results in undefined behavior:

The restrictions that ISO C places on the second parameter to the
va_start() macro in header <stdarg.h> are different in this
International Standard. The parameter parmN is the identifier of
the rightmost parameter in the variable parameter list of the
function definition (the one just before the ...).221) If the
parameter parmN is declared with a function, array, or reference
type, or with a type that is not compatible with the type that
results when passing an argument for which there is no parameter,
the behavior is undefined.

Fixes <http://webkit.org/b/52168> Title of standalone image document
includes bogus image dimensions

Rubber-stamped by Eric Seidel.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::formatLocalizedString): Don't use a reference type for
|format|.

2:01 PM Changeset in webkit [75434] by inferno@chromium.org
  • 1 edit in branches/chromium/597/WebCore/dom/Range.cpp

Merge 73818

BUG=65942
Review URL: http://codereview.chromium.org/6217002

2:00 PM Changeset in webkit [75433] by tony@chromium.org
  • 5 edits
    2 adds in trunk

2011-01-10 Tony Chang <tony@chromium.org>

Unreviewed, rolling out r75398, r75407,
http://trac.webkit.org/changeset/75398
https://bugs.webkit.org/show_bug.cgi?id=52008

Some layout tests are crashing on Chromium Win.

  • platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.checksum: Added.
  • platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.png: Added.
  • platform/chromium/test_expectations.txt:

2011-01-10 Tony Chang <tony@chromium.org>

Unreviewed, rolling out r75398.
http://trac.webkit.org/changeset/75398
https://bugs.webkit.org/show_bug.cgi?id=52008

Some layout tests are crashing on Chromium Win.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::updatePaintRect):
  • DumpRenderTree/chromium/WebViewHost.h:
2:00 PM Changeset in webkit [75432] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 73799

BUG=65942
Review URL: http://codereview.chromium.org/6129003

1:57 PM Changeset in webkit [75431] by mihaip@chromium.org
  • 14 edits
    4 adds in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Rebaseline six tests in fast/repaint for chromium-mac. Even after the
scrollbar switch they need Chromium-specific results since repaint
regions are different from the mac port's.

Adds both Leopard (chromium-mac-leopard) and Snow Leopard (chromium-mac)
baselines.

  • platform/chromium-mac-leopard/fast/repaint/fixed-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-expected.checksum:
  • platform/chromium-mac/fast/repaint/fixed-expected.png:
  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium-mac/fast/repaint/fixed-tranformed-expected.checksum:
  • platform/chromium-mac/fast/repaint/fixed-tranformed-expected.png:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.checksum:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-mac/fast/repaint/repaint-during-scroll-expected.checksum:
  • platform/chromium-mac/fast/repaint/repaint-during-scroll-expected.png:
  • platform/chromium/test_expectations.txt:
1:56 PM Changeset in webkit [75430] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/597

Merge 75014 - Merge 74636

BUG=67363
Review URL: http://codereview.chromium.org/6186003

1:54 PM Changeset in webkit [75429] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 74979 - Merge 73801

BUG=66473
Review URL: http://codereview.chromium.org/6180005

1:23 PM Changeset in webkit [75428] by inferno@chromium.org
  • 2 edits
    4 copies in branches/chromium/597

Merge 75193 - Merge 75168

BUG=68558
Review URL: http://codereview.chromium.org/6139003

1:21 PM Changeset in webkit [75427] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Gavin Barraclough.

Remove unused isString() case in JSString::toPrimitiveString()
https://bugs.webkit.org/show_bug.cgi?id=52167

We never call toPrimitiveString() with strings, so remove the
check and add an ASSERT ensuring this never happens. 0.7% overall
progression in sunspider, since one of the call sites is very hot.

  • runtime/JSString.h: (JSC::JSValue::toPrimitiveString):
1:21 PM Changeset in webkit [75426] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/597

Merge 75008 - Merge 74574

BUG=66748
Review URL: http://codereview.chromium.org/6206004

1:19 PM Changeset in webkit [75425] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 75028 - Merge 74779

BUG=68178
Review URL: http://codereview.chromium.org/6157003

1:17 PM Changeset in webkit [75424] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 74984 - Merge 74787

BUG=68181
Review URL: http://codereview.chromium.org/6222002

1:15 PM Changeset in webkit [75423] by inferno@chromium.org
  • 3 edits
    16 copies
    2 deletes in branches/chromium/597

Merge 74987 - Merge 74954

BUG=66760
Review URL: http://codereview.chromium.org/6200003

1:11 PM Changeset in webkit [75422] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 74986 - Merge 74364

BUG=66760

1:08 PM Changeset in webkit [75421] by barraclough@apple.com
  • 11 edits
    7 adds
    7 deletes in trunk/Source/JavaScriptCore

Rename the existing YARR files and classes
https://bugs.webkit.org/show_bug.cgi?id=51872

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2011-01-10
Reviewed by Gavin Barraclough.

Replace the "Regex" prefix with "Yarr" in the name of YARR files and classes.

(JSC::RegExp::compile):
(JSC::RegExp::match):
(JSC::RegExp::printTraceData):

  • yarr/YarrInterpreter.cpp: Renamed from Source/JavaScriptCore/yarr/RegexInterpreter.cpp.

(JSC::Yarr::Interpreter::appendParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::popParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::DisjunctionContext::DisjunctionContext):
(JSC::Yarr::Interpreter::DisjunctionContext::operator new):
(JSC::Yarr::Interpreter::allocDisjunctionContext):
(JSC::Yarr::Interpreter::freeDisjunctionContext):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::operator new):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::restoreOutput):
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::getDisjunctionContext):
(JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::InputStream::InputStream):
(JSC::Yarr::Interpreter::InputStream::next):
(JSC::Yarr::Interpreter::InputStream::rewind):
(JSC::Yarr::Interpreter::InputStream::read):
(JSC::Yarr::Interpreter::InputStream::readPair):
(JSC::Yarr::Interpreter::InputStream::readChecked):
(JSC::Yarr::Interpreter::InputStream::reread):
(JSC::Yarr::Interpreter::InputStream::prev):
(JSC::Yarr::Interpreter::InputStream::getPos):
(JSC::Yarr::Interpreter::InputStream::setPos):
(JSC::Yarr::Interpreter::InputStream::atStart):
(JSC::Yarr::Interpreter::InputStream::atEnd):
(JSC::Yarr::Interpreter::InputStream::checkInput):
(JSC::Yarr::Interpreter::InputStream::uncheckInput):
(JSC::Yarr::Interpreter::InputStream::isNotAvailableInput):
(JSC::Yarr::Interpreter::testCharacterClass):
(JSC::Yarr::Interpreter::checkCharacter):
(JSC::Yarr::Interpreter::checkCasedCharacter):
(JSC::Yarr::Interpreter::checkCharacterClass):
(JSC::Yarr::Interpreter::tryConsumeBackReference):
(JSC::Yarr::Interpreter::matchAssertionBOL):
(JSC::Yarr::Interpreter::matchAssertionEOL):
(JSC::Yarr::Interpreter::matchAssertionWordBoundary):
(JSC::Yarr::Interpreter::backtrackPatternCharacter):
(JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
(JSC::Yarr::Interpreter::matchCharacterClass):
(JSC::Yarr::Interpreter::backtrackCharacterClass):
(JSC::Yarr::Interpreter::matchBackReference):
(JSC::Yarr::Interpreter::backtrackBackReference):
(JSC::Yarr::Interpreter::recordParenthesesMatch):
(JSC::Yarr::Interpreter::resetMatches):
(JSC::Yarr::Interpreter::parenthesesDoBacktrack):
(JSC::Yarr::Interpreter::matchParenthesesOnceBegin):
(JSC::Yarr::Interpreter::matchParenthesesOnceEnd):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
(JSC::Yarr::Interpreter::matchParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::matchParenthesesTerminalEnd):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalEnd):
(JSC::Yarr::Interpreter::matchParentheticalAssertionBegin):
(JSC::Yarr::Interpreter::matchParentheticalAssertionEnd):
(JSC::Yarr::Interpreter::backtrackParentheticalAssertionBegin):
(JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd):
(JSC::Yarr::Interpreter::matchParentheses):
(JSC::Yarr::Interpreter::backtrackParentheses):
(JSC::Yarr::Interpreter::lookupForBeginChars):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::matchNonZeroDisjunction):
(JSC::Yarr::Interpreter::interpret):
(JSC::Yarr::Interpreter::Interpreter):
(JSC::Yarr::ByteCompiler::ParenthesesStackEntry::ParenthesesStackEntry):
(JSC::Yarr::ByteCompiler::ByteCompiler):
(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::checkInput):
(JSC::Yarr::ByteCompiler::assertionBOL):
(JSC::Yarr::ByteCompiler::assertionEOL):
(JSC::Yarr::ByteCompiler::assertionWordBoundary):
(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::popParenthesesStack):
(JSC::Yarr::ByteCompiler::dumpDisjunction):
(JSC::Yarr::ByteCompiler::closeAlternative):
(JSC::Yarr::ByteCompiler::closeBodyAlternative):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::ByteCompiler::regexEnd):
(JSC::Yarr::ByteCompiler::alternativeBodyDisjunction):
(JSC::Yarr::ByteCompiler::alternativeDisjunction):
(JSC::Yarr::ByteCompiler::emitDisjunction):
(JSC::Yarr::byteCompile):
(JSC::Yarr::interpret):

  • yarr/YarrInterpreter.h: Renamed from Source/JavaScriptCore/yarr/RegexInterpreter.h.

(JSC::Yarr::ByteTerm::ByteTerm):
(JSC::Yarr::ByteTerm::BOL):
(JSC::Yarr::ByteTerm::CheckInput):
(JSC::Yarr::ByteTerm::EOL):
(JSC::Yarr::ByteTerm::WordBoundary):
(JSC::Yarr::ByteTerm::BackReference):
(JSC::Yarr::ByteTerm::BodyAlternativeBegin):
(JSC::Yarr::ByteTerm::BodyAlternativeDisjunction):
(JSC::Yarr::ByteTerm::BodyAlternativeEnd):
(JSC::Yarr::ByteTerm::AlternativeBegin):
(JSC::Yarr::ByteTerm::AlternativeDisjunction):
(JSC::Yarr::ByteTerm::AlternativeEnd):
(JSC::Yarr::ByteTerm::SubpatternBegin):
(JSC::Yarr::ByteTerm::SubpatternEnd):
(JSC::Yarr::ByteTerm::invert):
(JSC::Yarr::ByteTerm::capture):
(JSC::Yarr::ByteDisjunction::ByteDisjunction):
(JSC::Yarr::BytecodePattern::BytecodePattern):
(JSC::Yarr::BytecodePattern::~BytecodePattern):

  • yarr/YarrJIT.cpp: Renamed from Source/JavaScriptCore/yarr/RegexJIT.cpp.

(JSC::Yarr::YarrGenerator::optimizeAlternative):
(JSC::Yarr::YarrGenerator::matchCharacterClassRange):
(JSC::Yarr::YarrGenerator::matchCharacterClass):
(JSC::Yarr::YarrGenerator::jumpIfNoAvailableInput):
(JSC::Yarr::YarrGenerator::jumpIfAvailableInput):
(JSC::Yarr::YarrGenerator::checkInput):
(JSC::Yarr::YarrGenerator::atEndOfInput):
(JSC::Yarr::YarrGenerator::notAtEndOfInput):
(JSC::Yarr::YarrGenerator::jumpIfCharEquals):
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::readCharacter):
(JSC::Yarr::YarrGenerator::storeToFrame):
(JSC::Yarr::YarrGenerator::storeToFrameWithPatch):
(JSC::Yarr::YarrGenerator::loadFromFrame):
(JSC::Yarr::YarrGenerator::loadFromFrameAndJump):
(JSC::Yarr::YarrGenerator::IndirectJumpEntry::IndirectJumpEntry):
(JSC::Yarr::YarrGenerator::IndirectJumpEntry::addJump):
(JSC::Yarr::YarrGenerator::AlternativeBacktrackRecord::AlternativeBacktrackRecord):
(JSC::Yarr::YarrGenerator::GenerationState::GenerationState):
(JSC::Yarr::YarrGenerator::GenerationState::addIndirectJumpEntry):
(JSC::Yarr::YarrGenerator::GenerationState::emitIndirectJumpTable):
(JSC::Yarr::YarrGenerator::GenerationState::incrementParenNestingLevel):
(JSC::Yarr::YarrGenerator::GenerationState::decrementParenNestingLevel):
(JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):
(JSC::Yarr::YarrGenerator::GenerationState::emitParenthesesTail):
(JSC::Yarr::YarrGenerator::GenerationState::addJumpToNextInteration):
(JSC::Yarr::YarrGenerator::GenerationState::addJumpsToNextInteration):
(JSC::Yarr::YarrGenerator::GenerationState::addDataLabelToNextIteration):
(JSC::Yarr::YarrGenerator::GenerationState::linkToNextIteration):
(JSC::Yarr::YarrGenerator::BacktrackDestination::BacktrackDestination):
(JSC::Yarr::YarrGenerator::BacktrackDestination::clear):
(JSC::Yarr::YarrGenerator::BacktrackDestination::clearDataLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::hasDestination):
(JSC::Yarr::YarrGenerator::BacktrackDestination::isStackOffset):
(JSC::Yarr::YarrGenerator::BacktrackDestination::isLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::isJumpList):
(JSC::Yarr::YarrGenerator::BacktrackDestination::hasDataLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::copyTarget):
(JSC::Yarr::YarrGenerator::BacktrackDestination::copyTo):
(JSC::Yarr::YarrGenerator::BacktrackDestination::addBacktrackJump):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setStackOffset):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setNextBacktrackLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::copyBacktrackToLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setBacktrackToLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setBacktrackJumpList):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setBacktrackSourceLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setDataLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::setSubDataLabelPtr):
(JSC::Yarr::YarrGenerator::BacktrackDestination::linkToNextBacktrack):
(JSC::Yarr::YarrGenerator::BacktrackDestination::getStackOffset):
(JSC::Yarr::YarrGenerator::BacktrackDestination::getLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::getBacktrackJumps):
(JSC::Yarr::YarrGenerator::BacktrackDestination::getDataLabel):
(JSC::Yarr::YarrGenerator::BacktrackDestination::jumpToBacktrack):
(JSC::Yarr::YarrGenerator::BacktrackDestination::linkDataLabelToHereIfExists):
(JSC::Yarr::YarrGenerator::BacktrackDestination::plantJumpToBacktrackIfExists):
(JSC::Yarr::YarrGenerator::BacktrackDestination::linkAlternativeBacktracks):
(JSC::Yarr::YarrGenerator::BacktrackDestination::linkAlternativeBacktracksTo):
(JSC::Yarr::YarrGenerator::TermGenerationState::TermGenerationState):
(JSC::Yarr::YarrGenerator::TermGenerationState::resetAlternative):
(JSC::Yarr::YarrGenerator::TermGenerationState::alternativeValid):
(JSC::Yarr::YarrGenerator::TermGenerationState::nextAlternative):
(JSC::Yarr::YarrGenerator::TermGenerationState::alternative):
(JSC::Yarr::YarrGenerator::TermGenerationState::isLastAlternative):
(JSC::Yarr::YarrGenerator::TermGenerationState::resetTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::termValid):
(JSC::Yarr::YarrGenerator::TermGenerationState::nextTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::term):
(JSC::Yarr::YarrGenerator::TermGenerationState::isLastTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::getSubParenNum):
(JSC::Yarr::YarrGenerator::TermGenerationState::isMainDisjunction):
(JSC::Yarr::YarrGenerator::TermGenerationState::setParenthesesTail):
(JSC::Yarr::YarrGenerator::TermGenerationState::getParenthesesTail):
(JSC::Yarr::YarrGenerator::TermGenerationState::lookaheadTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::isSinglePatternCharacterLookaheadTerm):
(JSC::Yarr::YarrGenerator::TermGenerationState::inputOffset):
(JSC::Yarr::YarrGenerator::TermGenerationState::clearBacktrack):
(JSC::Yarr::YarrGenerator::TermGenerationState::jumpToBacktrack):
(JSC::Yarr::YarrGenerator::TermGenerationState::plantJumpToBacktrackIfExists):
(JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
(JSC::Yarr::YarrGenerator::TermGenerationState::addBacktrackJump):
(JSC::Yarr::YarrGenerator::TermGenerationState::setBacktrackDataLabel):
(JSC::Yarr::YarrGenerator::TermGenerationState::setBackTrackStackOffset):
(JSC::Yarr::YarrGenerator::TermGenerationState::setBacktrackLabel):
(JSC::Yarr::YarrGenerator::TermGenerationState::linkAlternativeBacktracks):
(JSC::Yarr::YarrGenerator::TermGenerationState::linkAlternativeBacktracksTo):
(JSC::Yarr::YarrGenerator::TermGenerationState::setBacktrackLink):
(JSC::Yarr::YarrGenerator::TermGenerationState::chainBacktracks):
(JSC::Yarr::YarrGenerator::TermGenerationState::chainBacktrackJumps):
(JSC::Yarr::YarrGenerator::TermGenerationState::getBacktrackDestination):
(JSC::Yarr::YarrGenerator::TermGenerationState::propagateBacktrackingFrom):
(JSC::Yarr::YarrGenerator::ParenthesesTail::ParenthesesTail):
(JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks):
(JSC::Yarr::YarrGenerator::ParenthesesTail::setNextIteration):
(JSC::Yarr::YarrGenerator::ParenthesesTail::addAfterParenJump):
(JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode):
(JSC::Yarr::YarrGenerator::generateAssertionBOL):
(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::matchAssertionWordchar):
(JSC::Yarr::YarrGenerator::generateAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::generatePatternCharacterSingle):
(JSC::Yarr::YarrGenerator::generatePatternCharacterPair):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassSingle):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generateParenthesesDisjunction):
(JSC::Yarr::YarrGenerator::generateParenthesesSingle):
(JSC::Yarr::YarrGenerator::generateParenthesesGreedyNoBacktrack):
(JSC::Yarr::YarrGenerator::generateParentheticalAssertion):
(JSC::Yarr::YarrGenerator::generateTerm):
(JSC::Yarr::YarrGenerator::generateDisjunction):
(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::compile):
(JSC::Yarr::jitCompile):

  • yarr/YarrJIT.h: Renamed from Source/JavaScriptCore/yarr/RegexJIT.h.

(JSC::Yarr::YarrCodeBlock::YarrCodeBlock):
(JSC::Yarr::YarrCodeBlock::~YarrCodeBlock):
(JSC::Yarr::YarrCodeBlock::setFallBack):
(JSC::Yarr::YarrCodeBlock::isFallBack):
(JSC::Yarr::YarrCodeBlock::set):
(JSC::Yarr::YarrCodeBlock::execute):
(JSC::Yarr::YarrCodeBlock::getAddr):
(JSC::Yarr::execute):

  • yarr/YarrParser.h: Renamed from Source/JavaScriptCore/yarr/RegexParser.h.

(JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate):
(JSC::Yarr::Parser::CharacterClassParserDelegate::begin):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
(JSC::Yarr::Parser::CharacterClassParserDelegate::end):
(JSC::Yarr::Parser::CharacterClassParserDelegate::assertionWordBoundary):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBackReference):
(JSC::Yarr::Parser::Parser):
(JSC::Yarr::Parser::parseEscape):
(JSC::Yarr::Parser::parseAtomEscape):
(JSC::Yarr::Parser::parseCharacterClassEscape):
(JSC::Yarr::Parser::parseCharacterClass):
(JSC::Yarr::Parser::parseParenthesesBegin):
(JSC::Yarr::Parser::parseParenthesesEnd):
(JSC::Yarr::Parser::parseQuantifier):
(JSC::Yarr::Parser::parseTokens):
(JSC::Yarr::Parser::parse):
(JSC::Yarr::Parser::saveState):
(JSC::Yarr::Parser::restoreState):
(JSC::Yarr::Parser::atEndOfPattern):
(JSC::Yarr::Parser::peek):
(JSC::Yarr::Parser::peekIsDigit):
(JSC::Yarr::Parser::peekDigit):
(JSC::Yarr::Parser::consume):
(JSC::Yarr::Parser::consumeDigit):
(JSC::Yarr::Parser::consumeNumber):
(JSC::Yarr::Parser::consumeOctal):
(JSC::Yarr::Parser::tryConsume):
(JSC::Yarr::Parser::tryConsumeHex):
(JSC::Yarr::parse):

  • yarr/YarrPattern.cpp: Renamed from Source/JavaScriptCore/yarr/RegexPattern.cpp.

(JSC::Yarr::CharacterClassConstructor::CharacterClassConstructor):
(JSC::Yarr::CharacterClassConstructor::reset):
(JSC::Yarr::CharacterClassConstructor::append):
(JSC::Yarr::CharacterClassConstructor::putChar):
(JSC::Yarr::CharacterClassConstructor::isUnicodeUpper):
(JSC::Yarr::CharacterClassConstructor::isUnicodeLower):
(JSC::Yarr::CharacterClassConstructor::putRange):
(JSC::Yarr::CharacterClassConstructor::charClass):
(JSC::Yarr::CharacterClassConstructor::addSorted):
(JSC::Yarr::CharacterClassConstructor::addSortedRange):
(JSC::Yarr::BeginCharHelper::BeginCharHelper):
(JSC::Yarr::BeginCharHelper::addBeginChar):
(JSC::Yarr::BeginCharHelper::merge):
(JSC::Yarr::BeginCharHelper::addCharacter):
(JSC::Yarr::BeginCharHelper::linkHotTerms):
(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPatternConstructor::~YarrPatternConstructor):
(JSC::Yarr::YarrPatternConstructor::reset):
(JSC::Yarr::YarrPatternConstructor::assertionBOL):
(JSC::Yarr::YarrPatternConstructor::assertionEOL):
(JSC::Yarr::YarrPatternConstructor::assertionWordBoundary):
(JSC::Yarr::YarrPatternConstructor::atomPatternCharacter):
(JSC::Yarr::YarrPatternConstructor::atomBuiltInCharacterClass):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassBegin):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassAtom):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassRange):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassBuiltIn):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassEnd):
(JSC::Yarr::YarrPatternConstructor::atomParenthesesSubpatternBegin):
(JSC::Yarr::YarrPatternConstructor::atomParentheticalAssertionBegin):
(JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
(JSC::Yarr::YarrPatternConstructor::atomBackReference):
(JSC::Yarr::YarrPatternConstructor::copyDisjunction):
(JSC::Yarr::YarrPatternConstructor::copyTerm):
(JSC::Yarr::YarrPatternConstructor::quantifyAtom):
(JSC::Yarr::YarrPatternConstructor::disjunction):
(JSC::Yarr::YarrPatternConstructor::regexBegin):
(JSC::Yarr::YarrPatternConstructor::regexEnd):
(JSC::Yarr::YarrPatternConstructor::regexError):
(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):
(JSC::Yarr::YarrPatternConstructor::setupDisjunctionOffsets):
(JSC::Yarr::YarrPatternConstructor::setupOffsets):
(JSC::Yarr::YarrPatternConstructor::checkForTerminalParentheses):
(JSC::Yarr::YarrPatternConstructor::optimizeBOL):
(JSC::Yarr::YarrPatternConstructor::addBeginTerm):
(JSC::Yarr::YarrPatternConstructor::setupDisjunctionBeginTerms):
(JSC::Yarr::YarrPatternConstructor::setupAlternativeBeginTerms):
(JSC::Yarr::YarrPatternConstructor::setupBeginChars):
(JSC::Yarr::compile):
(JSC::Yarr::YarrPattern::YarrPattern):

  • yarr/YarrPattern.h: Renamed from Source/JavaScriptCore/yarr/RegexPattern.h.

(JSC::Yarr::CharacterRange::CharacterRange):
(JSC::Yarr::CharacterClassTable::create):
(JSC::Yarr::CharacterClassTable::CharacterClassTable):
(JSC::Yarr::CharacterClass::CharacterClass):
(JSC::Yarr::PatternTerm::PatternTerm):
(JSC::Yarr::PatternTerm::ForwardReference):
(JSC::Yarr::PatternTerm::BOL):
(JSC::Yarr::PatternTerm::EOL):
(JSC::Yarr::PatternTerm::WordBoundary):
(JSC::Yarr::PatternTerm::invert):
(JSC::Yarr::PatternTerm::capture):
(JSC::Yarr::PatternTerm::quantify):
(JSC::Yarr::PatternAlternative::PatternAlternative):
(JSC::Yarr::PatternAlternative::lastTerm):
(JSC::Yarr::PatternAlternative::removeLastTerm):
(JSC::Yarr::PatternAlternative::setOnceThrough):
(JSC::Yarr::PatternAlternative::onceThrough):
(JSC::Yarr::PatternDisjunction::PatternDisjunction):
(JSC::Yarr::PatternDisjunction::~PatternDisjunction):
(JSC::Yarr::PatternDisjunction::addNewAlternative):
(JSC::Yarr::TermChain::TermChain):
(JSC::Yarr::BeginChar::BeginChar):
(JSC::Yarr::YarrPattern::~YarrPattern):
(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::containsIllegalBackReference):
(JSC::Yarr::YarrPattern::newlineCharacterClass):
(JSC::Yarr::YarrPattern::digitsCharacterClass):
(JSC::Yarr::YarrPattern::spacesCharacterClass):
(JSC::Yarr::YarrPattern::wordcharCharacterClass):
(JSC::Yarr::YarrPattern::nondigitsCharacterClass):
(JSC::Yarr::YarrPattern::nonspacesCharacterClass):
(JSC::Yarr::YarrPattern::nonwordcharCharacterClass):

1:07 PM Changeset in webkit [75420] by inferno@chromium.org
  • 1 edit in branches/chromium/597/WebCore/svg/SVGLength.cpp

Merge 75026 - Merge 74788

BUG=68062
Review URL: http://codereview.chromium.org/6117004

1:03 PM Changeset in webkit [75419] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 75090 - Merge 75082

BUG=68439
Review URL: http://codereview.chromium.org/6192002

1:01 PM Changeset in webkit [75418] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Skip layout tests in WebKit2 that fail for an obvious (missing DRT API) reason
https://bugs.webkit.org/show_bug.cgi?id=52166

  • platform/mac-wk2/Skipped:
1:01 PM Changeset in webkit [75417] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/597

Merge 74982 - Merge 74781

BUG=66986
Review URL: http://codereview.chromium.org/6094016

12:59 PM Changeset in webkit [75416] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/597

Merge 75007 - Merge 73927

BUG=66560
Review URL: http://codereview.chromium.org/6150004

12:55 PM Changeset in webkit [75415] by inferno@chromium.org
  • 1 edit
    4 copies in branches/chromium/597

Merge 74981 - Merge 74743

BUG=65796
Review URL: http://codereview.chromium.org/6097012

12:45 PM Changeset in webkit [75414] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

  • parser/SyntaxChecker.h:
12:39 PM Changeset in webkit [75413] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-10 Dave Tapuska <dtapuska@rim.com>

Reviewed by Gavin Barraclough.

Add CTI ASM versions for RVCT ARM THUMB2 mode.

https://bugs.webkit.org/show_bug.cgi?id=52154

  • jit/JITStubs.cpp: (JSC::ctiTrampoline): (JSC::ctiVMThrowTrampoline): (JSC::ctiOpThrowNotCaught):
12:35 PM Changeset in webkit [75412] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Qt build fix.

12:30 PM Changeset in webkit [75411] by benjamin.poulain@nokia.com
  • 4 edits in trunk

2011-01-10 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Navigator.cookiesEnabled return true for Qt even if there is no cookie jar
https://bugs.webkit.org/show_bug.cgi?id=52081

Test for the availability of cookie jar to return if cookies are enabled or not.

  • platform/qt/CookieJarQt.cpp: (WebCore::cookiesEnabled):

2011-01-10 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Navigator.cookiesEnabled return true for Qt even if there is no cookie jar
https://bugs.webkit.org/show_bug.cgi?id=52081

Add an autotest for checking the result of Navigator.cookiesEnabled depending
on the status of the cookie jar.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::navigatorCookieEnabled):
12:29 PM Changeset in webkit [75410] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-01-10 W. James MacLean <wjmaclean@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Enable reuse of RenderSurface for drawing.
https://bugs.webkit.org/show_bug.cgi?id=51928

Modifies RenderSurfaceChromium::prepareContentsTexture to avoid trying to 'reserve' a texture
that is already reserved, should an attempt be made to re-select a previously drawn render surface
in order to continue drawing to it. This use case appears when compositing into an offscreen texture.

Covered by existing test (compositing/geometry/fixed-position.html) when offscreen compositing enabled.

  • platform/graphics/chromium/LayerTexture.h: (WebCore::LayerTexture::isReserved):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::prepareContentsTexture):
  • platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::isProtected):
  • platform/graphics/chromium/TextureManager.h:
12:22 PM Changeset in webkit [75409] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Port combo box painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51828

Use GtkStyleContext API to paint combo boxes when building with
GTK+ 3.x. Method paintButton() has been factored out and the new
static method renderButton() is used by both paintButton() and
paintMenuList().

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::renderButton): (WebCore::RenderThemeGtk::paintButton): (WebCore::getComboBoxMetrics): (WebCore::RenderThemeGtk::popupInternalPaddingLeft): (WebCore::RenderThemeGtk::popupInternalPaddingRight): (WebCore::RenderThemeGtk::popupInternalPaddingTop): (WebCore::RenderThemeGtk::popupInternalPaddingBottom): (WebCore::RenderThemeGtk::paintMenuList):
12:20 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
12:20 PM Changeset in webkit [75408] by barraclough@apple.com
  • 91 edits
    2 adds in trunk

Bug 52079 - Syntax errors should be early errors.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

From chapter 16 the spec:

An implementation must report most errors at the time the relevant ECMAScript language construct is
evaluated. An early error is an error that can be detected and reported prior to the evaluation of
any construct in the Program containing the error. An implementation must report early errors in a
Program prior to the first evaluation of that Program. Early errors in eval code are reported at
the time eval is called but prior to evaluation of any construct within the eval code. All errors
that are not early errors are runtime errors.

An implementation must treat any instance of the following kinds of errors as an early error:

  • Any syntax error."

Added new files.

  • bytecode/CodeBlock.cpp:

Removed op_throw_syntax_error.

  • bytecode/Opcode.h:

Removed op_throw_syntax_error.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

If m_expressionTooDeep then throw a runtime error.

(JSC::BytecodeGenerator::BytecodeGenerator):

Initialize m_expressionTooDeep.

(JSC::BytecodeGenerator::emitThrowExpressionTooDeepException):

Sets m_expressionTooDeep.

  • bytecompiler/BytecodeGenerator.h:

Added m_expressionTooDeep, removed emitThrowSyntaxError.

  • bytecompiler/NodesCodegen.cpp:

(JSC::RegExpNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::LabelNode::emitBytecode):

Conditions that threw syntax error are now handled during parsing;
during bytecompilation these are now just ASSERTs.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:

Removed op_throw_syntax_error.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createRegExp):

Renamed; added syntax check.

  • parser/JSParser.cpp:

(JSC::JSParser::breakIsValid):
(JSC::JSParser::hasLabel):
(JSC::JSParser::Scope::Scope):
(JSC::JSParser::Scope::setIsFunction):
(JSC::JSParser::Scope::isFunctionBoundary):
(JSC::JSParser::ScopeRef::hasContainingScope):
(JSC::JSParser::ScopeRef::containingScope):
(JSC::JSParser::AutoPopScopeRef::AutoPopScopeRef):
(JSC::JSParser::AutoPopScopeRef::~AutoPopScopeRef):
(JSC::JSParser::AutoPopScopeRef::setPopped):
(JSC::JSParser::popScopeInternal):
(JSC::JSParser::popScope):
(JSC::jsParse):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseBreakStatement):
(JSC::JSParser::parseContinueStatement):
(JSC::JSParser::parseReturnStatement):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseExpressionOrLabelStatement):
(JSC::JSParser::parsePrimaryExpression):

  • parser/JSParser.h:
  • parser/Nodes.h:
  • parser/Parser.cpp:

(JSC::Parser::parse):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createRegExp):

Renamed; added syntax check.

  • runtime/ExceptionHelpers.cpp:

(JSC::createOutOfMemoryError):
(JSC::throwOutOfMemoryError):

  • runtime/ExceptionHelpers.h:

Broke out createOutOfMemoryError.

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

Add check for exception after bytecode generation.

  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

RegExp error prefixes not included in error string.

  • yarr/RegexParser.h:

(JSC::Yarr::Parser::parse):

Removed regexBegin/regexEnd/regexError.

  • yarr/RegexPattern.cpp:

(JSC::Yarr::RegexPatternConstructor::regexBegin):

Removed regexEnd/regexError.

(JSC::Yarr::compileRegex):

Add call to regexBegin (no longer called from the parser).

  • yarr/YarrSyntaxChecker.cpp: Added.

(JSC::Yarr::SyntaxChecker::assertionBOL):
(JSC::Yarr::SyntaxChecker::assertionEOL):
(JSC::Yarr::SyntaxChecker::assertionWordBoundary):
(JSC::Yarr::SyntaxChecker::atomPatternCharacter):
(JSC::Yarr::SyntaxChecker::atomBuiltInCharacterClass):
(JSC::Yarr::SyntaxChecker::atomCharacterClassBegin):
(JSC::Yarr::SyntaxChecker::atomCharacterClassAtom):
(JSC::Yarr::SyntaxChecker::atomCharacterClassRange):
(JSC::Yarr::SyntaxChecker::atomCharacterClassBuiltIn):
(JSC::Yarr::SyntaxChecker::atomCharacterClassEnd):
(JSC::Yarr::SyntaxChecker::atomParenthesesSubpatternBegin):
(JSC::Yarr::SyntaxChecker::atomParentheticalAssertionBegin):
(JSC::Yarr::SyntaxChecker::atomParenthesesEnd):
(JSC::Yarr::SyntaxChecker::atomBackReference):
(JSC::Yarr::SyntaxChecker::quantifyAtom):
(JSC::Yarr::SyntaxChecker::disjunction):
(JSC::Yarr::checkSyntax):

  • yarr/YarrSyntaxChecker.h: Added.

Check RegExp syntax.

LayoutTests:

Fix syntax errors in layout tests, and update expected results.

  • editing/selection/select-crash-001.html:
  • editing/selection/select-crash-002.html:
  • fast/canvas/webgl/renderbuffer-initialization.html:
  • fast/forms/25153.html:
  • fast/forms/textfield-drag-into-disabled.html:
  • fast/js/exception-codegen-crash-expected.txt:
  • fast/js/exception-codegen-crash.html:
  • fast/js/kde/parse-expected.txt:
  • fast/js/kde/script-tests/parse.js:
  • fast/js/large-expressions-expected.txt:
  • fast/js/named-function-expression-expected.txt:
  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/script-tests/large-expressions.js:
  • fast/js/script-tests/named-function-expression.js:
  • fast/js/script-tests/parser-syntax-check.js:
  • fast/js/sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A6-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A6-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T1-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T10-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T2-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T3-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T5-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T6-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T7-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T8-expected.txt:
  • fast/js/sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T9-expected.txt:
  • http/tests/security/isolatedWorld/events.html:
  • http/tests/security/isolatedWorld/userGestureEvents.html:
  • svg/custom/resources/use-instanceRoot-event-listeners.js:
  • svg/custom/rgbcolor-syntax.svg:
  • svg/custom/use-instanceRoot-modifications.svg:
  • svg/custom/use-property-changes-through-svg-dom.svg:
  • webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
  • webarchive/resources/adopt-attribute-styled-body-iframe.html:
12:14 PM Changeset in webkit [75407] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-10 Tony Chang <tony@chromium.org>

Unreviewed, remove duplicate test expectation for gif-loop-count.

  • platform/chromium/test_expectations.txt:
12:14 PM Changeset in webkit [75406] by Adam Roben
  • 2 edits in trunk/Tools

Roll out r75392

It isn't needed now that r75289 has been rolled out.

  • Scripts/run-javascriptcore-tests:
12:13 PM Changeset in webkit [75405] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Roll out r75289

It was causing assertion failures. See <http://webkit.org/b/52156>.

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

12:07 PM Changeset in webkit [75404] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2011-01-10 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Eric Seidel.

Support for ARM's RVCT(ARMCC) compiler in import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52146

  • Shared/API/c/WKBase.h:
12:05 PM Changeset in webkit [75403] by gyuyoung.kim@samsung.com
  • 2 edits in trunk

2011-01-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Enable JIT for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=52140

Enable JIT option for WebKit EFL. Enabled JIT's JS performance is
3 ~ 6 times faster than before.

  • Source/cmake/OptionsEfl.cmake:
12:04 PM Changeset in webkit [75402] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed rolling out r75371, because it didn't fix Qt buildbot.

  • platform/qt/Skipped:
12:00 PM Changeset in webkit [75401] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-01-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
https://bugs.webkit.org/show_bug.cgi?id=52160

  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout. Anything that can make runUntil() conditions turn true will happen on a run loop cycle anyway.
11:58 AM Changeset in webkit [75400] by evan@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-10 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] simplify complex glyph positioning code
https://bugs.webkit.org/show_bug.cgi?id=52159

Before, we had roughly same code duplicated for RTL and LTR.
Now, use the same code for both directions by being careful about
flipping signs where appropriate.

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::shapeGlyphs): (WebCore::ComplexTextController::setGlyphXPositions):
11:31 AM Changeset in webkit [75399] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix the build.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

11:31 AM Changeset in webkit [75398] by tony@chromium.org
  • 5 edits
    2 deletes in trunk

2011-01-10 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[chromium] fix for animated gif layout tests
https://bugs.webkit.org/show_bug.cgi?id=52008

Remove incorrect baselines.

  • platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.checksum: Removed.
  • platform/chromium-win/fast/backgrounds/animated-gif-as-background-expected.png: Removed.
  • platform/chromium/test_expectations.txt:

2011-01-10 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[chromium] fix for animated gif layout tests
https://bugs.webkit.org/show_bug.cgi?id=52008

  • DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect

to trigger gif animations.

(WebViewHostPaintTask::WebViewHostPaintTask):
(WebViewHostPaintTask::runIfValid):
(WebViewHost::updatePaintRect):

  • DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::taskList):
11:29 AM Changeset in webkit [75397] by alex
  • 7 edits in trunk

2011-01-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix gtk2 compilation for master
https://bugs.webkit.org/show_bug.cgi?id=51885

  • platform/gtk/GtkVersioning.h: Replaced the 2.24.0 check with 2.23.0 to avoid using the old symbols in the 2.23 releases. Added support for gdk_pixmap_get_size before the 2.23.4.
  • platform/gtk/WidgetRenderingContextGtk2.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext): Replaced the old gdk_drawable_get_size with gdk_pixmap_get_size.

2011-01-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix gtk2 compilation for master
https://bugs.webkit.org/show_bug.cgi?id=51885

  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView): Replaced the old gdk_drawable_get_size with gdk_pixmap_get_size.

2011-01-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix gtk2 compilation for master
https://bugs.webkit.org/show_bug.cgi?id=51885

  • webkit/webkitsoupauthdialog.c: (show_auth_dialog): Removed the call to gtk_dialog_set_has_separator API to remove a warning.
11:22 AM Changeset in webkit [75396] by Patrick Gansterer
  • 2 edits in trunk/Tools

2011-01-10 Patrick Gansterer <Patrick Gansterer>

Reviewed by Laszlo Gombos.

[WINCE] Reenable NPAPI after r75203
https://bugs.webkit.org/show_bug.cgi?id=52109

Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
it with !isEfl(), because EFL port does not support NPAPI (yet).

  • Scripts/build-webkit:
11:20 AM Changeset in webkit [75395] by weinig@apple.com
  • 22 edits
    17 adds in trunk/WebKit2

Make Geolocation features work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52078

Reviewed by Anders Carlsson.

Step 1 - Add enough support to get position data from a provider.
This does not include permission support.

  • Platform/CoreIPC/HandleMessage.h:

Add #include of Arguments.h for CoreIPC::In and Out definitions.

  • Platform/CoreIPC/MessageID.h:

Add new message types.

  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:

Add new API types.

  • Shared/WebGeolocationPosition.cpp: Added.
  • Shared/WebGeolocationPosition.h: Added.

Internal position representation.

  • UIProcess/API/C/WKAPICast.h:

Add casts for new API types.

  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKGeolocationManager.cpp: Added.
  • UIProcess/API/C/WKGeolocationManager.h: Added.
  • UIProcess/API/C/WKGeolocationPosition.cpp: Added.
  • UIProcess/API/C/WKGeolocationPosition.h: Added.
  • UIProcess/API/C/WebKit2.h:

Add API to provide and control geolocation data.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::processDidClose):
(WebKit::WebContext::didReceiveMessage):

  • UIProcess/WebContext.h:

(WebKit::WebContext::geolocationManagerProxy):

  • UIProcess/WebGeolocationManagerProxy.cpp: Added.

(WebKit::WebGeolocationManagerProxy::create):
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::~WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::invalidate):
(WebKit::WebGeolocationManagerProxy::initializeProvider):
(WebKit::WebGeolocationManagerProxy::providerDidChangePosition):
(WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):
(WebKit::WebGeolocationManagerProxy::didReceiveMessage):
(WebKit::WebGeolocationManagerProxy::startUpdating):
(WebKit::WebGeolocationManagerProxy::stopUpdating):

  • UIProcess/WebGeolocationManagerProxy.h: Added.

(WebKit::WebGeolocationManagerProxy::clearContext):
(WebKit::WebGeolocationManagerProxy::type):

  • UIProcess/WebGeolocationManagerProxy.messages.in: Added.
  • UIProcess/WebGeolocationProvider.cpp: Added.

(WebKit::WebGeolocationProvider::startUpdating):
(WebKit::WebGeolocationProvider::stopUpdating):

  • UIProcess/WebGeolocationProvider.h: Added.
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):

  • WebProcess/Geolocation: Added.
  • WebProcess/Geolocation/WebGeolocationManager.cpp: Added.

(WebKit::WebGeolocationManager::WebGeolocationManager):
(WebKit::WebGeolocationManager::~WebGeolocationManager):
(WebKit::WebGeolocationManager::didReceiveMessage):
(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

  • WebProcess/Geolocation/WebGeolocationManager.h: Added.
  • WebProcess/Geolocation/WebGeolocationManager.messages.in: Added.
  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp: Added.

(WebKit::WebGeolocationClient::geolocationDestroyed):
(WebKit::WebGeolocationClient::startUpdating):
(WebKit::WebGeolocationClient::stopUpdating):
(WebKit::WebGeolocationClient::setEnableHighAccuracy):
(WebKit::WebGeolocationClient::lastPosition):
(WebKit::WebGeolocationClient::requestPermission):
(WebKit::WebGeolocationClient::cancelPermissionRequest):

  • WebProcess/WebCoreSupport/WebGeolocationClient.h: Added.

(WebKit::WebGeolocationClient::WebGeolocationClient):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::geolocationManager):
Pipe geolocation positions/errors from the UIProcess to the WebProcess.

  • DerivedSources.make:
  • DerivedSources.pro:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
    • win/WebKit2Generated.make:

Add new files.

11:17 AM Changeset in webkit [75394] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-10 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; build fix for r75385.

  • rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
11:15 AM Changeset in webkit [75393] by jorlow@chromium.org
  • 5 edits
    3 deletes in trunk

2011-01-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75341.
http://trac.webkit.org/changeset/75341
https://bugs.webkit.org/show_bug.cgi?id=52157

Regressions on several pixel tests (Requested by jorlow on
#webkit).

  • fast/canvas/canvas-fillPath-gradient-shadow-expected.txt: Removed.
  • fast/canvas/canvas-fillPath-gradient-shadow.html: Removed.
  • fast/canvas/script-tests/canvas-fillPath-gradient-shadow.js: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:

2011-01-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75341.
http://trac.webkit.org/changeset/75341
https://bugs.webkit.org/show_bug.cgi?id=52157

Regressions on several pixel tests (Requested by jorlow on
#webkit).

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath):
11:10 AM Changeset in webkit [75392] by Adam Roben
  • 2 edits in trunk/Tools

Skip some asserting JS tests

See <http://webkit.org/b/52156>.

  • Scripts/run-javascriptcore-tests:
11:10 AM Changeset in webkit [75391] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port check and radio button painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51815

Use GtkStyleContext API to paint check and radio buttons when
building with GTK+ 3.x.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::setToggleSize): (WebCore::paintToggle): (WebCore::RenderThemeGtk::setCheckboxSize): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::setRadioSize): (WebCore::RenderThemeGtk::paintRadio):
10:53 AM Changeset in webkit [75390] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/text/emphasis-avoid-ruby.html fails, because FontQt doesn’t implement
Font::emphasisMark{Ascent,Descent,Height} nor emphasis mark drawing.

https://bugs.webkit.org/show_bug.cgi?id=52155

  • platform/qt/Skipped: Add fast/text/emphasis-avoid-ruby.html until fix.
10:52 AM Changeset in webkit [75389] by Martin Robinson
  • 2 edits in trunk/Tools

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] build-webkit disable Blob support via arguments passed to automake
https://bugs.webkit.org/show_bug.cgi?id=52097

  • Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via build-webkit.
10:45 AM Changeset in webkit [75388] by mihaip@chromium.org
  • 6 edits
    2 copies
    2 adds in trunk/LayoutTests

2011-01-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectations update.

Rebaseline two tests in fast/forms for chromium-mac. Even after the
scrollbar switch they need Chromium-specific results since search and
file upload control rendering is different from the mac port's.

Adds both Leopard (chromium-mac-leopard) and Snow Leopard (chromium-mac)
baselines.

  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/file-input-direction-expected.png.
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/search-transformed-expected.png.
  • platform/chromium-mac/fast/forms/file-input-direction-expected.checksum:
  • platform/chromium-mac/fast/forms/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/search-transformed-expected.checksum:
  • platform/chromium-mac/fast/forms/search-transformed-expected.png:
  • platform/chromium/test_expectations.txt:
10:42 AM Changeset in webkit [75387] by Csaba Osztrogonác
  • 1 edit
    1 copy in trunk/LayoutTests

Unreviewed. Add Qt specific expected file.

  • platform/qt/http/tests/navigation/forward-and-cancel-expected.txt: Copied from LayoutTests/http/tests/navigation/forward-and-cancel-expected.txt.
10:35 AM Changeset in webkit [75386] by Martin Robinson
  • 2 edits in trunk

2011-01-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Bump the WebKitGTK+ versions in preparation for development release.

  • configure.ac: Bump the library, libtool and user agent version.
10:34 AM Changeset in webkit [75385] by commit-queue@webkit.org
  • 8 edits in trunk

2011-01-10 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Updated tests and results to take into account new default fraction bar thickness.
https://bugs.webkit.org/show_bug.cgi?id=50018

  • mathml/presentation/fractions.xhtml:
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:

2011-01-10 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

MathML: vertical alignment & bar thickness adjustments of fractions.
https://bugs.webkit.org/show_bug.cgi?id=50018

The fraction bar thickness default value should follow the w3c MathML 3 recommendation:
http://www.w3.org/TR/MathML3/chapter3.html#presm.mfrac
The vertical alignment of the fraction bar should be more accurate, specially with operators (+,=,...).

Test: mathml/presentation/fractions.xhtml

  • rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::RenderMathMLFraction): (WebCore::RenderMathMLFraction::updateFromElement): (WebCore::RenderMathMLFraction::layout): (WebCore::RenderMathMLFraction::paint): (WebCore::RenderMathMLFraction::baselinePosition):
  • rendering/mathml/RenderMathMLFraction.h:
10:32 AM Changeset in webkit [75384] by Antti Koivisto
  • 3 edits
    3 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=52044
REGRESSION(r74807): No-store is ignored within a document

Reviewed by Alexey Proskuryakov.

Don't use cached resources with Cache-control: no-store (unless cache policy is CachePolicyHistoryBuffer).
This matches a behavior that got lost in r74807.

Test: http/tests/misc/script-no-store.html
(by Alexey Proskuryakov)

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=52044
REGRESSION(r74807): No-store is ignored within a document

Reviewed by Alexey Proskuryakov.

  • http/tests/misc/script-no-store-expected.txt: Added.
  • http/tests/misc/script-no-store.html: Added.
  • http/tests/misc/resources/random-no-store.php: Added.
10:14 AM Changeset in webkit [75383] by Patrick Gansterer
  • 3 edits
    1 add in trunk/Source/WebCore

2011-01-10 Patrick Gansterer <Patrick Gansterer>

Reviewed by Laszlo Gombos.

[WIN] Add ProxyServerWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=52031

Add stub implementation to fix ENABLE_NETSCAPE_PLUGIN_API on WinCE.

  • CMakeLists.txt:
  • CMakeListsWinCE.txt:
  • platform/network/win/ProxyServerWin.cpp: Added. (WebCore::proxyServersForURL):
10:09 AM Changeset in webkit [75382] by Martin Robinson
  • 2 edits in trunk/WebKit2

2011-01-10 Martin Robinson <mrobinson@igalia.com>

GTK+ build fix. Continue to fix 'make dist.'

  • GNUmakefile.am: Remove more non-existent files from the WebKit2 build.
9:56 AM Changeset in webkit [75381] by alex
  • 4 edits in trunk

2011-01-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869

We avoid the situation where we have to render the same arc
multiple times over itself. Now it renders just one oval and
moves to the end angle.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):

2011-01-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869

Unskip canvas-largedraws.html after improving the performance for
big angles.

  • platform/gtk/Skipped:
9:15 AM Changeset in webkit [75380] by alex
  • 2 edits in trunk/WebKit2

2011-01-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove webkit2 files that are still not added to the
repository from the makefile
https://bugs.webkit.org/show_bug.cgi?id=52145

This change is required for the release, we can add the lines
again to the makefiles with the patches adding the files.

  • GNUmakefile.am:
9:04 AM Changeset in webkit [75379] by Adam Roben
  • 2 edits in trunk/Tools

Use the same name and description for TestNetscapePlugin on Windows and Mac

Fixes <http://webkit.org/b/52151>
fast/frames/iframe-reparenting-plugins.html fails on Windows

Reviewed by Steve Falkenburg.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied

the name and description from Mac's Info.plist.

9:00 AM Changeset in webkit [75378] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port text input control painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51870

Use GtkStyleContext API to paint text input controls when building
with GTK+ 3.x.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::RenderThemeGtk::paintTextField):
8:41 AM Changeset in webkit [75377] by tonyg@chromium.org
  • 60 edits in trunk

2011-01-09 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Forward declare some headers where possible
https://bugs.webkit.org/show_bug.cgi?id=52133

No new tests because no new functionality.

  • css/CSSValue.h:
  • dom/BeforeLoadEvent.h:
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/StyledElement.cpp:
  • dom/StyledElement.h:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • page/Frame.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/filters/FEBlend.cpp:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEComponentTransfer.cpp:
  • platform/graphics/filters/FEComposite.cpp:
  • platform/graphics/filters/FEConvolveMatrix.cpp:
  • platform/graphics/filters/FEDiffuseLighting.cpp:
  • platform/graphics/filters/FEDisplacementMap.cpp:
  • platform/graphics/filters/FEFlood.cpp:
  • platform/graphics/filters/FEGaussianBlur.cpp:
  • platform/graphics/filters/FEMerge.cpp:
  • platform/graphics/filters/FEMorphology.cpp:
  • platform/graphics/filters/FEOffset.cpp:
  • platform/graphics/filters/FESpecularLighting.cpp:
  • platform/graphics/filters/FETile.cpp:
  • platform/graphics/filters/FETurbulence.cpp:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceAlpha.cpp:
  • platform/graphics/filters/SourceGraphic.cpp:
  • svg/SVGElement.cpp:
  • svg/SVGElement.h:
  • svg/SVGFEBlendElement.cpp:
  • svg/SVGFEColorMatrixElement.cpp:
  • svg/SVGFEComponentTransferElement.cpp:
  • svg/SVGFECompositeElement.cpp:
  • svg/SVGFEConvolveMatrixElement.cpp:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEGaussianBlurElement.cpp:
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp:
  • svg/SVGFEMorphologyElement.cpp:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFESpecularLightingElement.cpp:
  • svg/SVGFETileElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGTextContentElement.cpp:
  • svg/graphics/filters/SVGFEImage.cpp:
  • svg/graphics/filters/SVGFEImage.h:

2011-01-09 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Forward declare some headers where possible
https://bugs.webkit.org/show_bug.cgi?id=52133

  • WebView/WebFrame.mm:
8:05 AM Changeset in webkit [75376] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Windows build fix after r75313

  • WebCore.vcproj/build-generated-files.sh: Updated for the change in

this script's path.

7:50 AM Changeset in webkit [75375] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add some new tests to the Windows Skipped file

The tests are failing due to unimplemented DRT features which are
already covered by bugs.

  • platform/win/Skipped:
7:30 AM Changeset in webkit [75374] by Laszlo Gombos
  • 3 edits in trunk/Tools

2011-01-10 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][WK2] Guard gcc-specific syntax

Non-gcc based compliers choke on the "-include"
syntax for preinclude, place guard around it.

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
7:25 AM Changeset in webkit [75373] by andreas.kling@nokia.com
  • 7 edits in trunk

2011-01-10 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

[Qt] [WK2] MiniBrowser does not load pages opened in new windows
https://bugs.webkit.org/show_bug.cgi?id=52111

When getting a createNewPage() callback from QWKPage, create the
new page with the same QWKContext as the page that is passed to
the callback.

  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp: (newPageFunction): (BrowserWindow::BrowserWindow):
  • MiniBrowser/qt/BrowserWindow.h:

2011-01-10 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

[Qt] [WK2] MiniBrowser does not load pages opened in new windows
https://bugs.webkit.org/show_bug.cgi?id=52111

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::context): Implement this method.
6:50 AM Changeset in webkit [75372] by andreas.kling@nokia.com
  • 2 edits in trunk/Tools

2011-01-10 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] MiniBrowser: Remove superfluous createNewPage() callback

BrowserView set its own useless createNewPage() callback on QWKPage.
This was immediately overridden by BrowserWindow anyway, so remove
the BrowserView one.

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView):
6:49 AM Changeset in webkit [75371] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578

Add new tests introduced in r75305 to the skipped list temporarily to make buildbot happy.

  • platform/qt/Skipped:
6:39 AM Changeset in webkit [75370] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-10 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: make properties on Array's prototype non-enumerable.
https://bugs.webkit.org/show_bug.cgi?id=51776

  • inspector/front-end/utilities.js: ():
5:50 AM Changeset in webkit [75369] by yael.aharon@nokia.com
  • 3 edits
    2 adds in trunk

Specificity of negated selectors apparently miscalculated
https://bugs.webkit.org/show_bug.cgi?id=41206

Reviewed by Simon Fraser.

Source/WebCore:

Give negated selectors the specificity of the selector they are negating.
This is the same as the behavior of other browsers.

Test: fast/css/pseudo-not.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::specificityForOneSelector):

LayoutTests:

  • fast/css/pseudo-not-expected.txt: Added.
  • fast/css/pseudo-not.html: Added.
5:30 AM Changeset in webkit [75368] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Windows build fix after r75353

  • WebCore.vcproj/WebCoreCommon.vsprops: Added rendering/mathml to the

include path.

3:41 AM Changeset in webkit [75367] by jorlow@chromium.org
  • 15 edits
    8 deletes in trunk

2011-01-10 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Remove non-client-based Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=50921

Code clean up, covered by existing tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/GeolocationServiceChromium.cpp: Removed.
  • platform/chromium/GeolocationServiceChromium.h: Removed.

2011-01-10 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Remove non-client-based Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=50921

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationPosition): (LayoutTestController::setMockGeolocationError):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::geolocationClientMock): (WebViewHost::reset):
  • DumpRenderTree/chromium/WebViewHost.h:

2011-01-10 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Remove non-client-based Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=50921

  • WebKit.gyp:
  • public/WebGeolocationService.h: Removed.
  • public/WebGeolocationServiceBridge.h: Removed.
  • public/WebGeolocationServiceMock.h: Removed.
  • src/AssertMatchingEnums.cpp:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame): (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
  • src/ChromiumBridge.cpp:
  • src/WebGeolocationServiceBridgeImpl.cpp: Removed.
  • src/WebGeolocationServiceBridgeImpl.h: Removed.
  • src/WebGeolocationServiceMock.cpp: Removed.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:
3:21 AM Changeset in webkit [75366] by eric@webkit.org
  • 5 edits in trunk/Tools

2011-01-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Commit bot tried to land r? cq+ patch
https://bugs.webkit.org/show_bug.cgi?id=36638

It should now be possible to post a patch with r? and cq+ and the
commit-queue will correctly wait for the r+ before attempting to land the patch.
(This was a feature requested by several users.)

One caveat: We don't actually reject r-, cq+ patches from the queue
(we just ignore them), but I think that's OK for now.

I also noticed that setting r- once a commit-queue node had grabbed
a patch would not properly cancel the landing. That's fixed and
tested in this patch.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/feeders.py:
  • Scripts/webkitpy/tool/bot/feeders_unittest.py:
2:44 AM Changeset in webkit [75365] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-01-10 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: protocol related change. Rename stepIntoStatement, stepOutOfFunction, stepOverStatement.
stepIntoStatement => stepInto
stepOutOfFunction => stepOut
stepOverStatement => stepOver

https://bugs.webkit.org/show_bug.cgi?id=52142

  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::stepOver): (WebCore::InspectorDebuggerAgent::stepInto): (WebCore::InspectorDebuggerAgent::stepOut):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._stepOverClicked): (WebInspector.ScriptsPanel.prototype._stepIntoClicked): (WebInspector.ScriptsPanel.prototype._stepOutClicked):
1:09 AM Changeset in webkit [75364] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port progressbar painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=52054

Use GtkStyleContext API to paint progressbars when building with
GTK+ 3.x. Also add support for indeterminate progressbars.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk.cpp:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeGtk::animationDurationForProgressBar):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeGtk::animationDurationForProgressBar): (WebCore::RenderThemeGtk::paintProgressBar):
12:35 AM Changeset in webkit [75363] by andreas.kling@nokia.com
  • 10 edits
    3 deletes in trunk/Source/WebCore

2011-01-10 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

Remove unused class "Pen" in WebCore/platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=49955

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Pen.cpp: Removed.
  • platform/graphics/Pen.h: Removed.
  • platform/graphics/haiku/GraphicsContextHaiku.cpp:
  • platform/graphics/wx/GraphicsContextWx.cpp:
  • platform/graphics/wx/PenWx.cpp: Removed.
12:27 AM Changeset in webkit [75362] by Martin Robinson
  • 6 edits in trunk

2011-01-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Create intermediate libWebCore library
https://bugs.webkit.org/show_bug.cgi?id=52116

  • GNUmakefile.am: add XP_UNIX to the global CPP flags, since it's used by both libWebCore and libwebkitgtk now.

2011-01-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Create intermediate libWebCore library
https://bugs.webkit.org/show_bug.cgi?id=52116

Create intermediate libWebCore.la to avoid overflowing the linker
in the final link stage.

  • GNUmakefile.am: define the new library.

2011-01-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Create intermediate libWebCore library
https://bugs.webkit.org/show_bug.cgi?id=52116

  • GNUmakefile.am: add libWebCore.la to LIBADD and remove webcore sources from the libwebkit library SOURCES.
Note: See TracTimeline for information about the timeline view.