Timeline



Feb 17, 2011:

11:59 PM Changeset in webkit [78969] by sergio@webkit.org
  • 2 edits
    257 adds in trunk/LayoutTests

2011-02-17 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Added another bunch of GTK+ baselines for Mozilla test suites
(tables/mozilla_expected_failures/bugs).

  • platform/gtk/Skipped: Unskip tests which now have results.
11:45 PM Changeset in webkit [78968] by Lucas Forschler
  • 2 adds in branches/safari-534.20-branch/Source/WebKit2/Shared

Add two missing files.

11:43 PM Changeset in webkit [78967] by yuzo@google.com
  • 4 edits in trunk/Source/WebKit/chromium

2011-02-17 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Retry landing after fixing Chromium side.
Fix for Bug 54632 - [chromium] Printing causes view to scroll
https://bugs.webkit.org/show_bug.cgi?id=54632

Expose setScrollOffset such that Chromium can restore the scroll offset
after printing the document. The bug will be fixed when the counterpart
patch http://codereview.chromium.org/6539011/ is landed for Chromium.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setScrollOffset):
  • src/WebFrameImpl.h:
11:30 PM Changeset in webkit [78966] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed.

[Qt]REGRESSION(r78846): editing/selection/mixed-editability-10.html
https://bugs.webkit.org/show_bug.cgi?id=54725

  • platform/qt/Skipped: Add editing/selection/mixed-editability-10.html until fix.
  • platform/qt/fast/text/justify-nbsp-expected.txt: updated after r78846.
10:57 PM Changeset in webkit [78965] by Csaba Osztrogonác
  • 54 edits
    10 adds in trunk/LayoutTests

Unreviewed.

Update Qt specific expected files after r78846.

  • platform/qt/css1/box_properties/clear_float-expected.checksum: Added.
  • platform/qt/css1/box_properties/clear_float-expected.png: Added.
  • platform/qt/css1/box_properties/clear_float-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.checksum: Added.
  • platform/qt/css1/box_properties/float_elements_in_series-expected.png: Added.
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_on_text_elements-expected.checksum: Added.
  • platform/qt/css1/box_properties/float_on_text_elements-expected.png: Added.
  • platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/qt/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/qt/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
  • platform/qt/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/qt/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/qt/editing/pasteboard/5478250-expected.checksum: Added.
  • platform/qt/editing/pasteboard/5478250-expected.png: Added.
  • platform/qt/editing/pasteboard/5478250-expected.txt:
  • platform/qt/editing/selection/3690703-2-expected.checksum:
  • platform/qt/editing/selection/3690703-2-expected.png:
  • platform/qt/editing/selection/3690703-2-expected.txt:
  • platform/qt/editing/selection/3690703-expected.checksum:
  • platform/qt/editing/selection/3690703-expected.png:
  • platform/qt/editing/selection/3690703-expected.txt:
  • platform/qt/editing/selection/3690719-expected.checksum:
  • platform/qt/editing/selection/3690719-expected.png:
  • platform/qt/editing/selection/3690719-expected.txt:
  • platform/qt/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
  • platform/qt/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/qt/fast/blockflow/box-shadow-horizontal-bt-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.checksum:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.checksum:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/qt/fast/table/035-vertical-expected.png:
  • platform/qt/fast/table/035-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.checksum:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum:
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
  • platform/qt/fast/table/rowspan-paint-order-vertical-expected.checksum:
  • platform/qt/fast/table/rowspan-paint-order-vertical-expected.png:
  • platform/qt/fast/table/rowspan-paint-order-vertical-expected.txt:
  • platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
10:54 PM Changeset in webkit [78964] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-17 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Actually mark Windows and Linux
as IMAGE+TEXT.

  • platform/chromium/test_expectations.txt:
10:51 PM Changeset in webkit [78963] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-17 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Fix expectations after r78951
(there are text difs too on Windows and Linux).

  • platform/chromium/test_expectations.txt:
10:38 PM Changeset in webkit [78962] by Lucas Forschler
  • 18 edits in branches/safari-534.20-branch/Source

Merge 78909.

10:35 PM Changeset in webkit [78961] by hayato@chromium.org
  • 5 edits
    1 add in trunk/Tools

2011-02-07 Hayato Ito <hayato@chromium.org>

Reviewed by Ojan Vafai.

Get rid of code which writes test results from test_type's
compare_output() method.
Writing test results now happens in single_test_runner, using
newly introduced test_result_writer module.

Subsequent patches will eliminate test_type/* classes.

https://bugs.webkit.org/show_bug.cgi?id=53908

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
10:33 PM Changeset in webkit [78960] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

LLVM Compiler build fix.

  • UIProcess/WebResourceCacheManagerProxy.h:
  • WebProcess/ResourceCache/WebResourceCacheManager.h:
10:14 PM Changeset in webkit [78959] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

2011-02-17 Simon Fraser <Simon Fraser>

Fix Windows and Qt builds by fixing signature of platformPaint().

  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: (WebKit::NetscapePlugin::platformPaint):
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: (WebKit::NetscapePlugin::platformPaint):
10:08 PM Changeset in webkit [78958] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Made object allocation secretly variable-sized (Shhhh!)
https://bugs.webkit.org/show_bug.cgi?id=54721


SunSpider reports no change.


Internally, MarkedBlock now makes variable-sized allocations, even
though MarkedSpace doesn't take advantage of this yet.

  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock): No need to ASSERT that allocations are fixed-sized.
  • runtime/MarkedBlock.h: Shrunk the atom size so we can allocate things that are not multiples of 64 bytes.
9:49 PM Changeset in webkit [78957] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed some math errors when when using variable-sized cells
https://bugs.webkit.org/show_bug.cgi?id=54717


SunSpider reports no change.


Computer Science Barbie says, "Math is not so hard afterall!"

  • runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): Round up when calculating the minimum number of atoms required for a cell, since rounding down will get you splinched.
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep):
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::forEach): Changed a bunch of != tests to < tests because m_endAtom is actually a fuzzy end -- iterating from firstAtom() may not hit m_endAtom exactly.
9:44 PM Changeset in webkit [78956] by Simon Fraser
  • 14 edits in trunk/Source/WebKit2

2011-02-17 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

WebKit2 snapshots don't show plug-ins
https://bugs.webkit.org/show_bug.cgi?id=54716

Fix WebKit2 plug-ins to do a software paint for
snapshotting.

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::snapshot): Respond to the snapshot message by getting a sharable bitmap from the plugin, and returning a handle to it in the reply.
  • PluginProcess/PluginControllerProxy.messages.in: Add the snapshot message.
  • Shared/Plugins/PluginQuirks.h:
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): Add a quirk for the ability to be snapshotted, which we only set for Flash at the moment.
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::snapshot): Create a shareable bitmap, and paint into it. (WebKit::NetscapePlugin::supportsSnapshotting): Test the quirk.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformPaint): Allow the paint to happen if we're snapshotting, even when using the CoreAnimation drawing model.
  • WebProcess/Plugins/Plugin.h: New snapshot method.
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::snapshot): Send a sync message to the plugin process, asking for a snapshot in a shareble bitmap.
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::paint): Use the snapshot if we have one, to avoid calling into the plugin to draw, which may run script.

(WebKit::PluginView::notifyWidget): Generate the snapshot before
a flattening paint, and throw it away after.

9:18 PM Changeset in webkit [78955] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

A little more abstraction for MarkedSpace::contains
https://bugs.webkit.org/show_bug.cgi?id=54715

  • runtime/MarkedBlock.h: (JSC::MarkedBlock::contains): Added a contains function, so MarkedSpace doesn't have to know how MarkedBlock tracks containment internally.
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::contains): Call through to MarkedBlock to figure out if a cell that seems to be in a block is valid.
9:07 PM Changeset in webkit [78954] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed the invariant that the last cell in a block is always marked
https://bugs.webkit.org/show_bug.cgi?id=54713


SunSpider reports no change.


This adds one branch to allocation, but simplifies the mark invariant,
especially in a world of variable-sized cells. Now, it really is true
that any cell whose mark bit is set is a valid, live cell whose
constructor has run and whose destructor has not run.

  • runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): Changed this do-while into a while since we can no longer rely on a set mark bit to break out of this loop before it reaches the end of the block.
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep):
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::isEmpty): (JSC::MarkedBlock::clearMarks): (JSC::MarkedBlock::markCount): (JSC::MarkedBlock::forEach): No need to set a special last mark bit.
8:58 PM Changeset in webkit [78953] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations fix for chromium.

  • platform/chromium/test_expectations.txt:
8:53 PM Changeset in webkit [78952] by Lucas Forschler
  • 9 edits in branches/safari-534.20-branch/Source/WebKit2

Merge 78915.

8:48 PM Changeset in webkit [78951] by mihaip@chromium.org
  • 13 edits
    2 adds in trunk/LayoutTests

2011-02-17 Mihai Parparita <mihaip@chromium.org>

Reviewed by Kent Tamura.

[chromium] Video-related compositor tests failing in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=47231

Make tests fall back to .ogv (Theora) videos if they can't play the
.mp4/.mov files.

  • compositing/geometry/clipped-video-controller.html:
  • compositing/geometry/video-fixed-scrolling.html:
  • compositing/geometry/video-opacity-overlay.html:
  • compositing/layers-inside-overflow-scroll.html:
  • compositing/overflow/overflow-compositing-descendant.html:
  • compositing/overflow/scroll-ancestor-update.html:
  • compositing/reflections/load-video-in-reflection.html:
  • compositing/resources/alpha-gradient-small.ogv: Added.
  • compositing/resources/video.ogv: Added.
  • compositing/self-painting-layers.html:
  • compositing/self-painting-layers2.html:
  • compositing/video/video-background-color.html:
  • compositing/video/video-poster.html:
  • platform/chromium/test_expectations.txt:
8:44 PM Changeset in webkit [78950] by Lucas Forschler
  • 9 edits
    2 copies in branches/safari-534.20-branch

Merge 78729.

8:43 PM Changeset in webkit [78949] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-17 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Roben.

Add blacklist of remaining webkitpy/* modules that fail on
Win32, so that test-webkitpy will at least run cleanly.

https://bugs.webkit.org/show_bug.cgi?id=54709

  • Scripts/webkitpy/layout_tests/test/main.py:
8:38 PM Changeset in webkit [78948] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Antonio Gomes.

make event handling work in Gecko
https://bugs.webkit.org/show_bug.cgi?id=54702

Gecko doesn't support the global event property. It's an IE-ism.

  • code-review.js:
8:35 PM Changeset in webkit [78947] by Simon Fraser
  • 2 edits in trunk/Tools

2011-02-17 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Set a preference to ensure that scrollbars are in a predictable
state for DRT.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
8:35 PM Changeset in webkit [78946] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-02-17 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Composited iframe content is missing from snapshots in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54696

We need to propagate the 'flattening' paint behavior flag
down to subviews while painting. WebKit1 does this via
code in WebFrameView, but this is a more general fix
that works in WebKit2 as well.

Made a utility method, parentFrameView(), which I changed
some other methods to use as well.

  • page/FrameView.cpp: (WebCore::FrameView::isEnclosedInCompositingLayer): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::isOverlappedIncludingAncestors): (WebCore::FrameView::parentFrameView): (WebCore::FrameView::paintContents):
  • page/FrameView.h:
8:29 PM Changeset in webkit [78945] by commit-queue@webkit.org
  • 8 edits
    1 delete in trunk/Source/JavaScriptCore

2011-02-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r78856 and r78907.
http://trac.webkit.org/changeset/78856
http://trac.webkit.org/changeset/78907
https://bugs.webkit.org/show_bug.cgi?id=54705

These seem to break tests on 32-bit builds. (Requested by
aroben on #webkit).

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • collector/handles/Global.h: (JSC::Global::internalSet):
  • collector/handles/Handle.h: (JSC::HandleTypes::getFromSlot): (JSC::HandleTypes::toJSValue): (JSC::HandleTypes::validateUpcast): (JSC::HandleConverter::operator->): (JSC::HandleConverter::operator*): (JSC::Handle::Handle): (JSC::Handle::get):
  • runtime/JSArray.cpp: (JSC::JSArray::sortNumeric):
  • runtime/JSObject.h: (JSC::JSObject::inlineGetOwnPropertySlot):
  • runtime/SlotAccessor.h: Removed.
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtr::get): (JSC::WeakGCPtr::internalSet):
  • runtime/WriteBarrier.h: (JSC::DeprecatedPtr::DeprecatedPtr): (JSC::DeprecatedPtr::get): (JSC::DeprecatedPtr::operator*): (JSC::DeprecatedPtr::operator->): (JSC::DeprecatedPtr::slot): (JSC::DeprecatedPtr::operator UnspecifiedBoolType*): (JSC::DeprecatedPtr::operator!): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->): (JSC::WriteBarrierBase::clear): (JSC::WriteBarrierBase::slot): (JSC::WriteBarrierBase::operator UnspecifiedBoolType*): (JSC::WriteBarrierBase::operator!): (JSC::WriteBarrierBase::setWithoutWriteBarrier): (JSC::WriteBarrier::WriteBarrier):
8:29 PM Changeset in webkit [78944] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-17 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Roben.

test-webkitpy doesn't work with the multiprocessing module on win32
or cygwin, so we skip it for now.

https://bugs.webkit.org/show_bug.cgi?id=54520

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/run_webkit_tests_unittest.py:
8:21 PM Changeset in webkit [78943] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-02-17 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Roben.

Fix version, baseline_search_path for chromium-win-win7. Also
fix chromium_win_unittests, and fix port_testcase.make_port()
to correctly use the options passed into it and only set
results_directory() if necessary.

https://bugs.webkit.org/show_bug.cgi?id=54652

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
8:19 PM Changeset in webkit [78942] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebCore

Merge 78917.

8:08 PM Changeset in webkit [78941] by Lucas Forschler
  • 7 edits in branches/safari-534.20-branch/Source/WebCore

Merge 78928.

7:18 PM Changeset in webkit [78940] by atwilson@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-02-17 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r78936.
http://trac.webkit.org/changeset/78936
https://bugs.webkit.org/show_bug.cgi?id=54632

Breaks chromium build

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
7:01 PM Changeset in webkit [78939] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations tweak in attempt to green up the chromium canaries.

  • platform/chromium/test_expectations.txt:
7:00 PM Changeset in webkit [78938] by Lucas Forschler
  • 4 edits in branches/safari-534.20-branch/Source/JavaScriptCore

Merge r78795

6:07 PM Changeset in webkit [78937] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations change to ignore errors for coords-units-03-b.svg until we can rebaseline it.

  • platform/chromium/test_expectations.txt:
6:01 PM Changeset in webkit [78936] by yuzo@google.com
  • 4 edits in trunk/Source/WebKit/chromium

2011-02-17 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Fix for Bug 54632 - [chromium] Printing causes view to scroll
https://bugs.webkit.org/show_bug.cgi?id=54632

Expose setScrollOffset such that Chromium can restore the scroll offset
after printing the document. The bug will be fixed when the counterpart
patch http://codereview.chromium.org/6539011/ is landed for Chromium.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setScrollOffset):
  • src/WebFrameImpl.h:
5:50 PM Changeset in webkit [78935] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed.

[Qt] Buildfix.

  • wtf/RetainPtr.h: Add missing PLATFORM(CF) guard.
5:48 PM Changeset in webkit [78934] by atwilson@chromium.org
  • 485 edits
    1 copy
    9 adds
    4 deletes in trunk/LayoutTests

Unreviewed expectations changes.

  • platform/chromium-linux/css1/box_properties/clear_float-expected.checksum:
  • platform/chromium-linux/css1/box_properties/clear_float-expected.png:
  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-linux/css1/text_properties/text_align-expected.checksum:
  • platform/chromium-linux/css1/text_properties/text_align-expected.png:
  • platform/chromium-linux/css2.1/t0905-c414-flt-wrap-00-e-expected.checksum:
  • platform/chromium-linux/css2.1/t0905-c414-flt-wrap-00-e-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-linux/css2.1/t0905-c5525-fltmult-00-d-g-expected.checksum:
  • platform/chromium-linux/css2.1/t0905-c5525-fltmult-00-d-g-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/chromium-linux/css2.1/t1602-c43-center-00-d-ag-expected.checksum:
  • platform/chromium-linux/css2.1/t1602-c43-center-00-d-ag-expected.png:
  • platform/chromium-linux/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
  • platform/chromium-linux/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-linux/editing/pasteboard/block-wrappers-necessary-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/block-wrappers-necessary-expected.png:
  • platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-area-expected.png:
  • platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-field-expected.png:
  • platform/chromium-linux/editing/selection/3690703-2-expected.checksum:
  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-2-expected.txt:
  • platform/chromium-linux/editing/selection/3690703-expected.checksum:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.txt:
  • platform/chromium-linux/editing/selection/3690719-expected.checksum:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.txt:
  • platform/chromium-linux/editing/style/5046875-2-expected.checksum:
  • platform/chromium-linux/editing/style/5046875-2-expected.png:
  • platform/chromium-linux/editing/style/block-style-001-expected.checksum:
  • platform/chromium-linux/editing/style/block-style-001-expected.png:
  • platform/chromium-linux/editing/style/block-style-002-expected.checksum:
  • platform/chromium-linux/editing/style/block-style-002-expected.png:
  • platform/chromium-linux/editing/style/block-style-003-expected.checksum:
  • platform/chromium-linux/editing/style/block-style-003-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-002-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-002-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-003-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-003-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-004-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-004-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-005-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-005-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-006-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-008-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-008-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-009-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-009-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-010-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-010-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-011-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-012-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-013-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-013-expected.png:
  • platform/chromium-linux/editing/style/table-selection-expected.checksum:
  • platform/chromium-linux/editing/style/table-selection-expected.png:
  • platform/chromium-linux/fast/block/basic/016-expected.checksum:
  • platform/chromium-linux/fast/block/basic/016-expected.png:
  • platform/chromium-linux/fast/block/basic/016-expected.txt: Removed.
  • platform/chromium-linux/fast/block/float/013-expected.checksum:
  • platform/chromium-linux/fast/block/float/013-expected.png:
  • platform/chromium-linux/fast/block/float/016-expected.checksum:
  • platform/chromium-linux/fast/block/float/016-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-linux/fast/block/positioning/051-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/051-expected.png:
  • platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
  • platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/css/create_element_align-expected.checksum:
  • platform/chromium-linux/fast/css/create_element_align-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-linux/fast/forms/button-default-title-expected.checksum:
  • platform/chromium-linux/fast/forms/button-default-title-expected.png:
  • platform/chromium-linux/fast/forms/button-default-title-expected.txt:
  • platform/chromium-linux/fast/forms/control-clip-expected.checksum:
  • platform/chromium-linux/fast/forms/control-clip-expected.png:
  • platform/chromium-linux/fast/forms/control-clip-expected.txt:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-linux/fast/inline-block/003-expected.checksum:
  • platform/chromium-linux/fast/inline-block/003-expected.png:
  • platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.checksum:
  • platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.png:
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.checksum:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.checksum:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-linux/fast/parser/001-expected.checksum:
  • platform/chromium-linux/fast/parser/001-expected.png:
  • platform/chromium-linux/fast/repaint/continuation-after-outline-expected.checksum:
  • platform/chromium-linux/fast/repaint/continuation-after-outline-expected.png:
  • platform/chromium-linux/fast/repaint/control-clip-expected.checksum:
  • platform/chromium-linux/fast/repaint/control-clip-expected.png:
  • platform/chromium-linux/fast/repaint/control-clip-expected.txt:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-9-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-linux/fast/repaint/reflection-redraw-expected.checksum:
  • platform/chromium-linux/fast/repaint/reflection-redraw-expected.png:
  • platform/chromium-linux/fast/replaced/007-expected.checksum:
  • platform/chromium-linux/fast/replaced/007-expected.png:
  • platform/chromium-linux/fast/ruby/nested-ruby-expected.checksum:
  • platform/chromium-linux/fast/ruby/nested-ruby-expected.png:
  • platform/chromium-linux/fast/ruby/nested-ruby-expected.txt:
  • platform/chromium-linux/fast/ruby/ruby-empty-rt-expected.checksum:
  • platform/chromium-linux/fast/ruby/ruby-empty-rt-expected.png:
  • platform/chromium-linux/fast/ruby/ruby-run-break-expected.checksum:
  • platform/chromium-linux/fast/ruby/ruby-run-break-expected.png:
  • platform/chromium-linux/fast/ruby/ruby-runs-expected.checksum:
  • platform/chromium-linux/fast/ruby/ruby-runs-expected.png:
  • platform/chromium-linux/fast/ruby/ruby-runs-spans-expected.checksum:
  • platform/chromium-linux/fast/ruby/ruby-runs-spans-expected.png:
  • platform/chromium-linux/fast/ruby/rubyDOM-insert-rt-expected.checksum:
  • platform/chromium-linux/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/chromium-linux/fast/ruby/rubyDOM-insert-text1-expected.checksum:
  • platform/chromium-linux/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/chromium-linux/fast/table/011-expected.checksum:
  • platform/chromium-linux/fast/table/011-expected.png:
  • platform/chromium-linux/fast/table/035-expected.checksum:
  • platform/chromium-linux/fast/table/035-expected.png:
  • platform/chromium-linux/fast/table/035-vertical-expected.checksum:
  • platform/chromium-linux/fast/table/035-vertical-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/004-expected.checksum:
  • platform/chromium-linux/fast/table/border-collapsing/004-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/004-vertical-expected.checksum:
  • platform/chromium-linux/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum:
  • platform/chromium-linux/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
  • platform/chromium-linux/fast/table/colgroup-preceded-by-caption-expected.checksum:
  • platform/chromium-linux/fast/table/colgroup-preceded-by-caption-expected.png:
  • platform/chromium-linux/fast/table/colgroup-spanning-groups-rules-expected.checksum:
  • platform/chromium-linux/fast/table/colgroup-spanning-groups-rules-expected.png:
  • platform/chromium-linux/fast/table/frame-and-rules-expected.checksum:
  • platform/chromium-linux/fast/table/frame-and-rules-expected.png:
  • platform/chromium-linux/fast/table/percent-heights-expected.checksum:
  • platform/chromium-linux/fast/table/percent-heights-expected.png:
  • platform/chromium-linux/fast/table/rowspan-paint-order-vertical-expected.checksum:
  • platform/chromium-linux/fast/table/rowspan-paint-order-vertical-expected.png:
  • platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.checksum:
  • platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.txt: Removed.
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.txt:
  • platform/chromium-linux/fast/text/basic/002-expected.checksum:
  • platform/chromium-linux/fast/text/basic/002-expected.png:
  • platform/chromium-linux/fast/text/capitalize-boundaries-expected.checksum:
  • platform/chromium-linux/fast/text/capitalize-boundaries-expected.png:
  • platform/chromium-linux/fast/text/capitalize-boundaries-expected.txt:
  • platform/chromium-linux/fast/text/international/bidi-override-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-override-expected.png:
  • platform/chromium-linux/fast/text/justified-selection-at-edge-expected.checksum:
  • platform/chromium-linux/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-linux/fast/text/justified-selection-expected.checksum:
  • platform/chromium-linux/fast/text/justified-selection-expected.png:
  • platform/chromium-linux/fast/text/justify-nbsp-expected.checksum: Added.
  • platform/chromium-linux/fast/text/justify-nbsp-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/repaint/continuation-after-outline-expected.png.
  • platform/chromium-linux/fast/text/justify-padding-distribution-expected.checksum: Added.
  • platform/chromium-linux/fast/text/justify-padding-distribution-expected.png: Added.
  • platform/chromium-linux/fast/text/trailing-white-space-2-expected.checksum:
  • platform/chromium-linux/fast/text/trailing-white-space-2-expected.png:
  • platform/chromium-linux/fast/text/trailing-white-space-expected.checksum:
  • platform/chromium-linux/fast/text/trailing-white-space-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/mixed/008-expected.checksum:
  • platform/chromium-linux/svg/hixie/mixed/008-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum:
  • platform/chromium-linux/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10633-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug10633-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug109043-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug109043-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug113424-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug113424-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11384q-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug11384q-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11384s-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug11384s-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1163-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug119786-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug126742-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug126742-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug127267-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug127267-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1302-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug131020-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug131020_iframe-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug131020_iframe-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug149275-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1802-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1802-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1802s-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1802s-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18664-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug18664-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug222846-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug23235-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug23235-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug27038-3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug27038-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3260-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug3260-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3454-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug3454-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug48028-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5838-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug60804-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug60804-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug60807-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug60807-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6304-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug67915-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug67915-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug69382-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug69382-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug81934-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug81934-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug88035-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug88035-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug8950-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug8950-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.txt:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.png:
  • platform/chromium-linux/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/misc-expected.png:
  • platform/chromium-linux/tables/mozilla/core/row_span-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_position-table-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-cell-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/body_col-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/body_col-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/body_tbody-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/body_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/body_tfoot-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/body_tfoot-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_align_center-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_align_justify-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_align_left-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_align_right-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_span-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_width_pct-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_width_pct-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_width_px-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/colgroup_width_px-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_frame_border-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_frame_box-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_row_align_center-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/table_row_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_all-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_row_th_nowrap-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_align_center-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_colspan-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_colspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_height-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tables_th_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_align_center-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_align_center-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_align_center-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_class-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_id-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_style-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_table-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_center-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_colspan-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_colspan-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_width-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_width-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_center-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_center-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-linux/tables/mozilla/other/body_col-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/body_col-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10216-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1128-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug29058-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-11-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-9-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions3-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_above-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_below-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_void-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/atsui-negative-spacing-features-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/atsui-spacing-features-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/atsui-spacing-features-expected.png: Added.
5:32 PM Changeset in webkit [78933] by Martin Robinson
  • 353 edits
    28 adds in trunk/LayoutTests

2011-02-17 Martin Robinson <mrobinson@igalia.com>

Updated GTK+ expectations after r78846. Add new pixel results for tests that
have changed and are missing them.

5:09 PM Changeset in webkit [78932] by Martin Robinson
  • 2 edits
    225 adds in trunk/LayoutTests

2011-02-17 Martin Robinson <mrobinson@igalia.com>

Continue importing GTK+ results for the Mozilla table tests.

  • platform/gtk/Skipped: Unskip tests which now have results.
4:50 PM Changeset in webkit [78931] by atwilson@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed expectations change.

Added expectations for new test (still disabled for linux until canaries catch up).

  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:46 PM Changeset in webkit [78930] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-17 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

Fix a hang in new-run-webkit-tests when run with
--dry-run --worker-model=processes

https://bugs.webkit.org/show_bug.cgi?id=54595

  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:34 PM Changeset in webkit [78929] by atwilson@chromium.org
  • 720 edits
    5 adds in trunk/LayoutTests

Unreviewed win expectations update after recent font rendering changes.

  • platform/chromium-win/css1/box_properties/clear_float-expected.checksum:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.txt:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/chromium-win/css1/text_properties/text_align-expected.checksum:
  • platform/chromium-win/css1/text_properties/text_align-expected.png:
  • platform/chromium-win/css1/text_properties/text_align-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
  • platform/chromium-win/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/chromium-win/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-win/css2.1/t0905-c414-flt-wrap-00-e-expected.checksum:
  • platform/chromium-win/css2.1/t0905-c414-flt-wrap-00-e-expected.png:
  • platform/chromium-win/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltmult-00-d-g-expected.checksum:
  • platform/chromium-win/css2.1/t0905-c5525-fltmult-00-d-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/chromium-win/css2.1/t1602-c43-center-00-d-ag-expected.checksum:
  • platform/chromium-win/css2.1/t1602-c43-center-00-d-ag-expected.png:
  • platform/chromium-win/css2.1/t1602-c43-center-00-d-ag-expected.txt:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.checksum:
  • platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.png:
  • platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.txt:
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.png:
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.png:
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • platform/chromium-win/editing/selection/3690703-2-expected.checksum:
  • platform/chromium-win/editing/selection/3690703-2-expected.png:
  • platform/chromium-win/editing/selection/3690703-2-expected.txt:
  • platform/chromium-win/editing/selection/3690703-expected.checksum:
  • platform/chromium-win/editing/selection/3690703-expected.png:
  • platform/chromium-win/editing/selection/3690703-expected.txt:
  • platform/chromium-win/editing/selection/3690719-expected.checksum:
  • platform/chromium-win/editing/selection/3690719-expected.png:
  • platform/chromium-win/editing/selection/3690719-expected.txt:
  • platform/chromium-win/editing/style/5046875-2-expected.checksum:
  • platform/chromium-win/editing/style/5046875-2-expected.png:
  • platform/chromium-win/editing/style/5046875-2-expected.txt:
  • platform/chromium-win/editing/style/block-style-001-expected.checksum:
  • platform/chromium-win/editing/style/block-style-001-expected.png:
  • platform/chromium-win/editing/style/block-style-001-expected.txt:
  • platform/chromium-win/editing/style/block-style-002-expected.checksum:
  • platform/chromium-win/editing/style/block-style-002-expected.png:
  • platform/chromium-win/editing/style/block-style-002-expected.txt:
  • platform/chromium-win/editing/style/block-style-003-expected.checksum:
  • platform/chromium-win/editing/style/block-style-003-expected.png:
  • platform/chromium-win/editing/style/block-style-003-expected.txt:
  • platform/chromium-win/editing/style/create-block-for-style-002-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-002-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-002-expected.txt:
  • platform/chromium-win/editing/style/create-block-for-style-003-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-003-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-003-expected.txt:
  • platform/chromium-win/editing/style/create-block-for-style-004-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-004-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-004-expected.txt:
  • platform/chromium-win/editing/style/create-block-for-style-005-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-005-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-005-expected.txt:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.txt:
  • platform/chromium-win/editing/style/create-block-for-style-008-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-008-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-008-expected.txt:
  • platform/chromium-win/editing/style/create-block-for-style-009-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-009-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-009-expected.txt:
  • platform/chromium-win/editing/style/create-block-for-style-010-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-010-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-010-expected.txt:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.txt:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.txt:
  • platform/chromium-win/editing/style/create-block-for-style-013-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-013-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-013-expected.txt:
  • platform/chromium-win/editing/style/table-selection-expected.checksum:
  • platform/chromium-win/editing/style/table-selection-expected.png:
  • platform/chromium-win/editing/style/table-selection-expected.txt:
  • platform/chromium-win/fast/block/basic/016-expected.checksum:
  • platform/chromium-win/fast/block/basic/016-expected.png:
  • platform/chromium-win/fast/block/basic/016-expected.txt:
  • platform/chromium-win/fast/block/float/013-expected.checksum:
  • platform/chromium-win/fast/block/float/013-expected.png:
  • platform/chromium-win/fast/block/float/013-expected.txt:
  • platform/chromium-win/fast/block/float/016-expected.checksum:
  • platform/chromium-win/fast/block/float/016-expected.png:
  • platform/chromium-win/fast/block/float/016-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-win/fast/block/positioning/051-expected.checksum:
  • platform/chromium-win/fast/block/positioning/051-expected.png:
  • platform/chromium-win/fast/block/positioning/051-expected.txt:
  • platform/chromium-win/fast/block/positioning/inline-block-relposition-expected.checksum:
  • platform/chromium-win/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/chromium-win/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/chromium-win/fast/box-shadow/inset-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.txt:
  • platform/chromium-win/fast/css/create_element_align-expected.checksum:
  • platform/chromium-win/fast/css/create_element_align-expected.png:
  • platform/chromium-win/fast/css/create_element_align-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/chromium-win/fast/forms/button-default-title-expected.checksum:
  • platform/chromium-win/fast/forms/button-default-title-expected.png:
  • platform/chromium-win/fast/forms/button-default-title-expected.txt:
  • platform/chromium-win/fast/forms/control-clip-expected.checksum:
  • platform/chromium-win/fast/forms/control-clip-expected.png:
  • platform/chromium-win/fast/forms/control-clip-expected.txt:
  • platform/chromium-win/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-win/fast/inline-block/003-expected.checksum:
  • platform/chromium-win/fast/inline-block/003-expected.png:
  • platform/chromium-win/fast/inline-block/003-expected.txt:
  • platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.checksum:
  • platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.png:
  • platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/chromium-win/fast/parser/001-expected.checksum:
  • platform/chromium-win/fast/parser/001-expected.png:
  • platform/chromium-win/fast/parser/001-expected.txt:
  • platform/chromium-win/fast/repaint/continuation-after-outline-expected.checksum:
  • platform/chromium-win/fast/repaint/continuation-after-outline-expected.png:
  • platform/chromium-win/fast/repaint/continuation-after-outline-expected.txt:
  • platform/chromium-win/fast/repaint/control-clip-expected.checksum:
  • platform/chromium-win/fast/repaint/control-clip-expected.png:
  • platform/chromium-win/fast/repaint/control-clip-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/chromium-win/fast/repaint/reflection-redraw-expected.checksum:
  • platform/chromium-win/fast/repaint/reflection-redraw-expected.png:
  • platform/chromium-win/fast/repaint/reflection-redraw-expected.txt:
  • platform/chromium-win/fast/replaced/007-expected.checksum:
  • platform/chromium-win/fast/replaced/007-expected.png:
  • platform/chromium-win/fast/replaced/007-expected.txt:
  • platform/chromium-win/fast/ruby/nested-ruby-expected.checksum:
  • platform/chromium-win/fast/ruby/nested-ruby-expected.png:
  • platform/chromium-win/fast/ruby/nested-ruby-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-empty-rt-expected.checksum:
  • platform/chromium-win/fast/ruby/ruby-empty-rt-expected.png:
  • platform/chromium-win/fast/ruby/ruby-empty-rt-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-run-break-expected.checksum:
  • platform/chromium-win/fast/ruby/ruby-run-break-expected.png:
  • platform/chromium-win/fast/ruby/ruby-run-break-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-runs-expected.checksum:
  • platform/chromium-win/fast/ruby/ruby-runs-expected.png:
  • platform/chromium-win/fast/ruby/ruby-runs-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-runs-spans-expected.checksum:
  • platform/chromium-win/fast/ruby/ruby-runs-spans-expected.png:
  • platform/chromium-win/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.checksum:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.checksum:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/chromium-win/fast/table/011-expected.checksum:
  • platform/chromium-win/fast/table/011-expected.png:
  • platform/chromium-win/fast/table/011-expected.txt:
  • platform/chromium-win/fast/table/035-expected.checksum:
  • platform/chromium-win/fast/table/035-expected.png:
  • platform/chromium-win/fast/table/035-expected.txt:
  • platform/chromium-win/fast/table/035-vertical-expected.checksum:
  • platform/chromium-win/fast/table/035-vertical-expected.png:
  • platform/chromium-win/fast/table/035-vertical-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/004-expected.checksum:
  • platform/chromium-win/fast/table/border-collapsing/004-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/004-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.checksum:
  • platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum:
  • platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
  • platform/chromium-win/fast/table/colgroup-preceded-by-caption-expected.checksum:
  • platform/chromium-win/fast/table/colgroup-preceded-by-caption-expected.png:
  • platform/chromium-win/fast/table/colgroup-preceded-by-caption-expected.txt:
  • platform/chromium-win/fast/table/colgroup-spanning-groups-rules-expected.checksum:
  • platform/chromium-win/fast/table/colgroup-spanning-groups-rules-expected.png:
  • platform/chromium-win/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/chromium-win/fast/table/frame-and-rules-expected.checksum:
  • platform/chromium-win/fast/table/frame-and-rules-expected.png:
  • platform/chromium-win/fast/table/frame-and-rules-expected.txt:
  • platform/chromium-win/fast/table/percent-heights-expected.checksum:
  • platform/chromium-win/fast/table/percent-heights-expected.png:
  • platform/chromium-win/fast/table/percent-heights-expected.txt:
  • platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.checksum:
  • platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.png:
  • platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.checksum:
  • platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.txt:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win/fast/text/atsui-spacing-features-expected.txt:
  • platform/chromium-win/fast/text/basic/002-expected.checksum:
  • platform/chromium-win/fast/text/basic/002-expected.png:
  • platform/chromium-win/fast/text/basic/002-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-override-expected.checksum:
  • platform/chromium-win/fast/text/international/bidi-override-expected.png:
  • platform/chromium-win/fast/text/international/bidi-override-expected.txt:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.checksum:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.png:
  • platform/chromium-win/fast/text/justified-selection-at-edge-expected.txt:
  • platform/chromium-win/fast/text/justified-selection-expected.checksum:
  • platform/chromium-win/fast/text/justified-selection-expected.png:
  • platform/chromium-win/fast/text/justified-selection-expected.txt:
  • platform/chromium-win/fast/text/justify-padding-distribution-expected.checksum: Added.
  • platform/chromium-win/fast/text/justify-padding-distribution-expected.png: Added.
  • platform/chromium-win/fast/text/trailing-white-space-2-expected.checksum:
  • platform/chromium-win/fast/text/trailing-white-space-2-expected.png:
  • platform/chromium-win/fast/text/trailing-white-space-2-expected.txt:
  • platform/chromium-win/fast/text/trailing-white-space-expected.checksum:
  • platform/chromium-win/fast/text/trailing-white-space-expected.png:
  • platform/chromium-win/fast/text/trailing-white-space-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/008-expected.checksum:
  • platform/chromium-win/svg/hixie/mixed/008-expected.png:
  • platform/chromium-win/svg/hixie/mixed/008-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug10633-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug10633-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10633-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug109043-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug109043-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug109043-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug113424-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug113424-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug113424-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug11384q-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug11384q-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11384q-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug11384s-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug11384s-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11384s-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1163-1-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1163-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug119786-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug126742-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug126742-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug126742-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug127267-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug127267-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug127267-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1302-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1302-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug131020-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug131020_iframe-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug131020_iframe-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug131020_iframe-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug149275-1-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug149275-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1802-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1802-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1802-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1802s-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1802s-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1802s-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug18664-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug18664-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug18664-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug222846-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug222846-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug23235-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug23235-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug23235-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug26553-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug26553-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug27038-3-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug27038-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug27038-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug3260-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug3260-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3260-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug3454-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug3454-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3454-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug3977-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3977-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-1-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-2-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-2-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug5838-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5838-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug60804-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug60804-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug60804-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug60807-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug60807-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug60807-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug6304-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug67915-1-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug67915-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug67915-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug69382-1-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug69382-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug69382-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7112-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7112-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug81934-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug81934-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug81934-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug88035-2-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug88035-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug88035-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug8950-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug8950-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug8950-expected.txt:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.checksum:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.txt:
  • platform/chromium-win/tables/mozilla/core/captions-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/captions-expected.png:
  • platform/chromium-win/tables/mozilla/core/captions-expected.txt:
  • platform/chromium-win/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/misc-expected.png:
  • platform/chromium-win/tables/mozilla/core/misc-expected.txt:
  • platform/chromium-win/tables/mozilla/core/row_span-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-win/tables/mozilla/core/row_span-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_position-table-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-cell-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/body_col-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/body_col-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/body_col-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/body_tbody-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/body_tbody-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/body_tbody-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/body_tfoot-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/body_tfoot-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/body_tfoot-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_center-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_center-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_left-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_left-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_left-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_right-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_right-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_span-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_span-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_span-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_middle-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_valign_top-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_width_pct-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_width_pct-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_width_px-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_width_px-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/colgroup_width_px-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_border-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_border-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_box-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_box-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_row_align_center-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/table_row_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_row_align_center-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tables_row_th_nowrap-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_align_center-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_align_center-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_colspan-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_colspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_colspan-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_height-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_height-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_th_height-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_center-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_align_center-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_center-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_align_center-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_center-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_align_center-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_top-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_class-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_class-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_id-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_id-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_style-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_style-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_table-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_table-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_center-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_center-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_th_colspan-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_th_colspan-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_colspan-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_th_width-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_th_width-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_width-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_center-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_center-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_center-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
  • platform/chromium-win/tables/mozilla/other/body_col-expected.checksum:
  • platform/chromium-win/tables/mozilla/other/body_col-expected.png:
  • platform/chromium-win/tables/mozilla/other/body_col-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1055-2-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1128-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-1-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-9-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_above-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_above-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_below-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_below-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_void-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_void-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/chromium/test_expectations.txt:
4:31 PM Changeset in webkit [78928] by mitz@apple.com
  • 7 edits in trunk/Source/WebCore

<rdar://problem/8898595> Pages that use fixed positioning display poorly when scaled

Reviewed by Simon Fraser.

  • html/HTMLBodyElement.cpp:

(WebCore::adjustForZoom): Account for page scale.
(WebCore::HTMLBodyElement::setScrollLeft): Ditto.
(WebCore::HTMLBodyElement::setScrollTop): Ditto.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollXForFixedPosition): Moved from ScrollView here and changed to
account for page scale: when the page is scaled, the “viewport” with respect to which fixed
objects are positioned is scaled as well. Since it’s now bigger than the real viewport (that is,
the frame view), we move it around in proportion to the document scroll, so that when the document
is fully scrolled to the bottom-right, the bottom right of the scaled viewport is visible.
(WebCore::FrameView::scrollYForFixedPosition): Ditto.
(WebCore::FrameView::scrollOffsetForFixedPosition): Moved from ScrollView here.

  • page/FrameView.h:
  • platform/ScrollView.cpp: Moved functions to FrameView.
  • platform/ScrollView.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateRepaintRectsAfterScroll): Account for the RenderView being transformed.
(WebCore::RenderLayer::calculateClipRects): Used scrollOffsetForFixedPosition().
(WebCore::RenderLayer::backgroundClipRect): Ditto.

4:28 PM Changeset in webkit [78927] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-02-17 Kenneth Russell <kbr@google.com>

Unreviewed. Skip fast/canvas/webgl/context-destroyed-crash.html
due to missing LayoutTestController.overridePreference.

  • platform/mac-wk2/Skipped:
4:21 PM Changeset in webkit [78926] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-02-17 Kenneth Russell <kbr@google.com>

Unreviewed. Fixed skip entries for
LayoutTestController.setMinimumTimerInterval which I messed up the
first time.

  • platform/mac-wk2/Skipped:
3:54 PM Changeset in webkit [78925] by Martin Robinson
  • 2 edits in trunk/Source/WebKit/gtk

2011-02-17 Robert Ancell <rober.ancell@gmail.com>

Reviewed by Martin Robinson.

[PATCH] GTK documentation fails to build due to changed paths
https://bugs.webkit.org/show_bug.cgi?id=54600

  • docs/GNUmakefile.am: Update the paths that have now moved the Source directory.
3:50 PM Changeset in webkit [78924] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-02-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Made MarkedBlock variable-sized
https://bugs.webkit.org/show_bug.cgi?id=54692


SunSpider reports no change.


Each MarkedBlock is now composed of a set of fixed-sized atoms, with one
mark bit per atom. A given cell may be composed of one or more atoms.


  • runtime/Heap.cpp: (JSC::Heap::allocate): Made fixed-sizedness a property of MarkedSpace, bubbling it up from MarkedBlock, since MarkedBlock now supports variable- sizedness.
  • runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): Removed use of CELLS_PER_BLOCK and (implicit) one constants -- these quantities are not constant anymore. Updated for switch from cell to atom.
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::create): (JSC::MarkedBlock::destroy): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep):
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::firstAtom): (JSC::MarkedBlock::atoms): (JSC::MarkedBlock::isAtomAligned): (JSC::MarkedBlock::blockFor): (JSC::MarkedBlock::isEmpty): (JSC::MarkedBlock::clearMarks): (JSC::MarkedBlock::size): (JSC::MarkedBlock::capacity): (JSC::MarkedBlock::atomNumber): (JSC::MarkedBlock::isMarked): (JSC::MarkedBlock::testAndSetMarked): (JSC::MarkedBlock::setMarked): (JSC::MarkedBlock::forEach): Same as above. Also removed use of CELL_SIZE and BLOCK_SIZE, and switched away from calling arbitrary pointers cells.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: (JSC::CollectorHeap::CollectorHeap): (JSC::MarkedSpace::contains): Updated for renames. Made fixed-sizedness a property of MarkedSpace.
3:49 PM Changeset in webkit [78923] by kbr@google.com
  • 9 edits in trunk/Source/WebCore

2011-02-17 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Add support for GPU accelerated path rendering
https://bugs.webkit.org/show_bug.cgi?id=44729

Incorporates the Loop and Blinn path rendering algorithm as an
option to the GPU-accelerated canvas code, currently only compiled
in to the Chromium port. Currently it's toggled by changing a
hardcoded constant in
SharedGraphicsContext3D::useLoopBlinnForPathRendering() and is
disabled by default. This mechanism can be improved once we've
gained more confidence in the implementation. There are some known
bugs that need to be fixed first.

No new tests; ran some 2D Canvas tests manually with the new flag
both enabled and disabled.

  • WebCore.gypi:
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::GLES2Canvas): (WebCore::GLES2Canvas::fillPath):
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/LoopBlinnClassifier.h:
  • platform/graphics/gpu/LoopBlinnLocalTriangulator.h:
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::createBuffer): (WebCore::SharedGraphicsContext3D::bindBuffer): (WebCore::SharedGraphicsContext3D::bufferData): (WebCore::SharedGraphicsContext3D::bufferSubData): (WebCore::SharedGraphicsContext3D::useLoopBlinnForPathRendering): (WebCore::SharedGraphicsContext3D::useLoopBlinnInteriorProgram): (WebCore::SharedGraphicsContext3D::useLoopBlinnExteriorProgram):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillPath):
3:42 PM Changeset in webkit [78922] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-16 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Layout Test fast/canvas/setWidthResetAfterForcedRender.html fails on
accelerated 2D canvas w/compositor enabled.
https://bugs.webkit.org/show_bug.cgi?id=54561

When resetting the CanvasRenderingContext2D, we also need to send a
contentChanged() to the relevant RenderLayer. This is similar to what
is done in didDraw().

Covered by fast/canvas/setWidthResetAfterForcedRender.html, but note
that this test will still fail pixel tests because the compositor
is not compatible with repaint tests (the green square is now white,
but the half-transparent grey repaint rect does not appear).

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset):
3:32 PM Changeset in webkit [78921] by kbr@google.com
  • 5 edits
    2 adds in trunk

2011-02-17 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Kenneth Russell.

Null out the WEBKIT_lose_context WebGL extension's context pointer when
the WebGL rendering context is removed.
https://bugs.webkit.org/show_bug.cgi?id=54679

  • fast/canvas/webgl/context-destroyed-crash-expected.txt: Added.
  • fast/canvas/webgl/context-destroyed-crash.html: Added.

2011-02-17 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by Kenneth Russell.

Null out the WEBKIT_lose_context WebGL extension's context pointer when
the WebGL rendering context is removed.
https://bugs.webkit.org/show_bug.cgi?id=54679

Test: fast/canvas/webgl/context-destroyed-crash.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
  • html/canvas/WebKitLoseContext.cpp: (WebCore::WebKitLoseContext::loseContext): Add null-check for m_context.
  • html/canvas/WebKitLoseContext.h: (WebCore::WebKitLoseContext::contextDestroyed):
3:29 PM Changeset in webkit [78920] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge r78775, crbug 73235

3:12 PM Changeset in webkit [78919] by kbr@google.com
  • 11 edits in trunk

2011-02-17 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

Construction of Uint8Array from JS Array (and possibly others) incorrectly clamps values
https://bugs.webkit.org/show_bug.cgi?id=52768

Removed incorrect clamping code from IntegralTypedArrayBase. Fixed
code which casts from incoming double to the destination type.
Changed the JSC bindings to use this code, rather than a copy of
the casting code and a different constructor, in order to reuse
the fix.

  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferView):
  • html/canvas/Int32Array.h: (WebCore::Int32Array::set):
  • html/canvas/Int8Array.h: (WebCore::Int8Array::set):
  • html/canvas/IntegralTypedArrayBase.h: (WebCore::IntegralTypedArrayBase::set):
  • html/canvas/Uint16Array.h: (WebCore::Uint16Array::set):
  • html/canvas/Uint32Array.h: (WebCore::Uint32Array::set):
  • html/canvas/Uint8Array.h: (WebCore::Uint8Array::set):

2011-02-17 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

Construction of Uint8Array from JS Array (and possibly others) incorrectly clamps values
https://bugs.webkit.org/show_bug.cgi?id=52768

Synchronized array-unit-tests.html with version in Khronos
repository. Tested in Chromium, Safari, Chromium DRT on Mac and
WebKit DRT on Mac.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
3:04 PM Changeset in webkit [78918] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations change.

Temporarily disabled tests that need rebaselining while we try to fix the rebaselining tool.

  • platform/chromium/test_expectations.txt:
2:36 PM Changeset in webkit [78917] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Knob proportion not quite right during rubber-band.
<rdar://problem/9015201>

Reviewed by Dan Bernstein.

Change knob proportion algorithm to treat overhang as making the view smaller,
rather than document bigger.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

2:23 PM Changeset in webkit [78916] by jberlin@webkit.org
  • 5 edits in trunk/Source/WebKit2

WebKit2: The CFNetwork Cache should be shared between the UI Process and the Web Process on
Windows.
https://bugs.webkit.org/show_bug.cgi?id=54683

Reviewed by Adam Roben.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:


  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
Make sure to remove the ending slash, as CFNetwork does not recognize the directory with
that slash.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):
Create a cache using the path, disk capacity, and memory capacity and set it as default.

1:50 PM Changeset in webkit [78915] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-02-17 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Web and/or plug-in process crashes when NPN_Evaluate destroys the plug-in
https://bugs.webkit.org/show_bug.cgi?id=54686
<rdar://problem/9013384>

This patch fixes two bugs with a plug-in calling NPN_Evaluate to destroy itself:

  • The PluginProxy object would be destroyed in the middle of PluginProxy::evaluate. This would cause the web process to crash.
  • The PluginControllerProxy would call NPP_Destroy while the plug-in was busy running code. This would cause the plug-in process to crash.

To fix this, we add protectPluginFromDestruction/unprotectPluginFromDestruction to
PluginControllerProxy and use it to defer calling destroy() in the plug-in process,
and defer actually destroying the plug-in in the web process.

https://bugs.webkit.org/show_bug.cgi?id=54171 tracks adding a test for this.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::PluginControllerProxy): (WebKit::PluginControllerProxy::destroy): (WebKit::PluginControllerProxy::evaluate): (WebKit::PluginControllerProxy::protectPluginFromDestruction): (WebKit::PluginControllerProxy::unprotectPluginFromDestruction):
  • PluginProcess/PluginControllerProxy.h: (WebKit::PluginControllerProxy::asPluginController):
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::destroyPluginControllerProxy): (WebKit::WebProcessConnection::didReceiveMessage): (WebKit::WebProcessConnection::didReceiveSyncMessage):
  • PluginProcess/WebProcessConnection.h: (WebKit::WebProcessConnection::connection):
  • WebProcess/Plugins/PluginController.h: (WebKit::PluginController::PluginDestructionProtector::PluginDestructionProtector): (WebKit::PluginController::PluginDestructionProtector::~PluginDestructionProtector):
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::evaluate):
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::protectPluginFromDestruction): (WebKit::PluginView::unprotectPluginFromDestruction):
  • WebProcess/Plugins/PluginView.h:
1:28 PM Changeset in webkit [78914] by luiz@webkit.org
  • 9 edits
    2 adds in trunk/Source/WebCore

Summary: HTML5 <details> and <summary>: HTMLSummaryElement
https://bugs.webkit.org/show_bug.cgi?id=54584

Reviewed by Andreas Kling.

Adding class HTMLSummaryElement to build systems. This class will be used in
the implementation of new HTML5 tag <summary>.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLSummaryElement.cpp: Added.

(WebCore::HTMLSummaryElement::create):
(WebCore::HTMLSummaryElement::HTMLSummaryElement):

  • html/HTMLSummaryElement.h: Added.
  • html/HTMLTagNames.in:
1:26 PM Changeset in webkit [78913] by hyatt@apple.com
  • 7 edits in trunk/LayoutTests/fast

Bug 54244. Layout test results changes landing with pre-commit hook temporarily turned off to hopefully make this work in one go.

1:26 PM Changeset in webkit [78912] by jorlow@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-17 Jeremy Orlow <jorlow@chromium.org>

Fix minor problem with test.

  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
1:26 PM Changeset in webkit [78911] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/editing/selection

Bug 54244. Layout test results changes landing with pre-commit hook temporarily turned off to hopefully make this work in one go.

1:21 PM Changeset in webkit [78910] by hyatt@apple.com
  • 981 edits in trunk/LayoutTests/platform/mac

Bug 54244. Layout test results changes landing with pre-commit hook temporarily turned off to hopefully make this work in one go.

1:20 PM Changeset in webkit [78909] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation):

1:06 PM Changeset in webkit [78908] by jorlow@chromium.org
  • 16 edits
    2 adds in trunk

2011-02-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Throwing in an IndexedDB error or success event should lead to the transaction aborting
https://bugs.webkit.org/show_bug.cgi?id=54249

  • storage/indexeddb/exception-in-event-aborts-expected.txt: Added.
  • storage/indexeddb/exception-in-event-aborts.html: Added.
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/resources/shared.js: (unexpectedErrorCallback):
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:

2011-02-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Throwing in an IndexedDB error or success event should lead to the transaction aborting
https://bugs.webkit.org/show_bug.cgi?id=54249

When an exception is thrown but not handled within an IDBRequests success/error event,
we should abort the transaction.

Test: storage/indexeddb/exception-in-event-aborts.html

  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • dom/EventTarget.cpp: (WebCore::EventTarget::uncaughtExceptionInEventHandler):
  • dom/EventTarget.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
  • storage/IDBRequest.h:
12:59 PM Changeset in webkit [78907] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Attempt to fix windows build

12:58 PM Changeset in webkit [78906] by hyatt@apple.com
  • 11 edits in trunk/LayoutTests/platform/mac/fast/multicol

Bug 54244. Having to land in small chunks to avoid svn commit hangs.

12:56 PM Changeset in webkit [78905] by hyatt@apple.com
  • 6 edits in trunk/LayoutTests/platform/mac/fast/replaced
12:55 PM Changeset in webkit [78904] by hyatt@apple.com
  • 11 edits in trunk/LayoutTests/platform/mac/fast/replaced
12:54 PM Changeset in webkit [78903] by hyatt@apple.com
  • 4 edits in trunk/LayoutTests/platform/mac/fast/inline-block
12:54 PM Changeset in webkit [78902] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/selectors
12:54 PM Changeset in webkit [78901] by weinig@apple.com
  • 18 edits
    2 adds in trunk/Source

WebKit2: Support Dictionary popup
<rdar://problem/7660670>

Reviewed by Maciej Stachowiak.

../WebCore:

Add some necessary exports.

  • WebCore.exp.in:

../WebKit2:

  • Shared/TextInfo.cpp: Added.

(WebKit::TextInfo::encode):
(WebKit::TextInfo::decode):

  • Shared/TextInfo.h: Added.

(WebKit::TextInfo::TextInfo):
Add class to represent the location and style of a run of text.

  • UIProcess/PageClient.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup):
Invoke the dictionary popup.

  • UIProcess/API/mac/WKView.mm:

(-[WKView performLookupAtCurrentMouseLocation]):
Tell the WebProcess to get get the text under the mouse and cause
the dictionary popup to appear.

  • UIProcess/API/mac/WKViewPrivate.h:

Add performLookupAtCurrentMouseLocation.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::didPerformDictionaryLookup):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Pipe messages through.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::characterRangeAtPoint): Fix to return PassRefPtr
and not potentially stale pointers.

(WebKit::WebPage::characterIndexForPoint):
Change to use a RefPtr.

(WebKit::WebPage::performDictionaryLookupAtLocation):
Add simple heuristic to get the word at the current point (or the current selection
if it is at that point) and grab the style of the word to send the UIProcess.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

12:54 PM Changeset in webkit [78900] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/overflow
12:54 PM Changeset in webkit [78899] by hyatt@apple.com
  • 6 edits in trunk/LayoutTests/platform/mac/fast/events
12:54 PM Changeset in webkit [78898] by hyatt@apple.com
  • 12 edits in trunk/LayoutTests/platform/mac/fast/inline
12:53 PM Changeset in webkit [78897] by hyatt@apple.com
  • 10 edits in trunk/LayoutTests/platform/mac/fast/dom
12:53 PM Changeset in webkit [78896] by hyatt@apple.com
  • 22 edits in trunk/LayoutTests/platform/mac/fast/table
12:53 PM Changeset in webkit [78895] by hyatt@apple.com
  • 10 edits in trunk/LayoutTests/platform/mac/fast/parser
12:53 PM Changeset in webkit [78894] by hyatt@apple.com
  • 34 edits in trunk/LayoutTests/platform/mac/fast/css
12:52 PM Changeset in webkit [78893] by hyatt@apple.com
  • 16 edits in trunk/LayoutTests/platform/mac/fast/css
12:52 PM Changeset in webkit [78892] by hyatt@apple.com
  • 9 edits in trunk/LayoutTests/platform/mac/fast/css
12:52 PM Changeset in webkit [78891] by hyatt@apple.com
  • 5 edits in trunk/LayoutTests/platform/mac/fast/css
12:52 PM Changeset in webkit [78890] by hyatt@apple.com
  • 16 edits in trunk/LayoutTests/platform/mac/fast/css
12:52 PM Changeset in webkit [78889] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/fast/css
12:49 PM Changeset in webkit [78888] by hyatt@apple.com
  • 9 edits in trunk/LayoutTests/platform/mac/fast/block
12:49 PM Changeset in webkit [78887] by hyatt@apple.com
  • 33 edits in trunk/LayoutTests/platform/mac/fast/blockflow
12:48 PM Changeset in webkit [78886] by hyatt@apple.com
  • 62 edits in trunk/LayoutTests/platform/mac/fast/repaint
12:47 PM Changeset in webkit [78885] by hyatt@apple.com
  • 12 edits in trunk/LayoutTests/platform/mac/fast/ruby
12:46 PM Changeset in webkit [78884] by hyatt@apple.com
  • 165 edits in trunk/LayoutTests/platform/mac/fast/forms
12:45 PM Changeset in webkit [78883] by hyatt@apple.com
  • 65 edits in trunk/LayoutTests/platform/mac/fast/forms
12:45 PM Changeset in webkit [78882] by hyatt@apple.com
  • 13 edits in trunk/LayoutTests/platform/mac/fast/text
12:45 PM Changeset in webkit [78881] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/text
12:45 PM Changeset in webkit [78880] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/text/selection-painted-separately-expected.png
12:44 PM Changeset in webkit [78879] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/text/align-center-rtl-spill-expected.png
12:44 PM Changeset in webkit [78878] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/text
12:44 PM Changeset in webkit [78877] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/text
12:44 PM Changeset in webkit [78876] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/text/stripNullFromText-expected.png
12:44 PM Changeset in webkit [78875] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/text/apply-start-width-after-skipped-text-expected.png
12:43 PM Changeset in webkit [78874] by hyatt@apple.com
  • 4 edits in trunk/LayoutTests/platform/mac/fast/text
12:43 PM Changeset in webkit [78873] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/text
12:43 PM Changeset in webkit [78872] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/fast/text
12:43 PM Changeset in webkit [78871] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/fast/text
12:43 PM Changeset in webkit [78870] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/fast/text
12:43 PM Changeset in webkit [78869] by hyatt@apple.com
  • 5 edits in trunk/LayoutTests/platform/mac/fast/text/whitespace
12:43 PM Changeset in webkit [78868] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/text
12:42 PM Changeset in webkit [78867] by hyatt@apple.com
  • 11 edits in trunk/LayoutTests/platform/mac/fast/text
12:42 PM Changeset in webkit [78866] by hyatt@apple.com
  • 5 edits in trunk/LayoutTests/platform/mac/fast/text
12:42 PM Changeset in webkit [78865] by hyatt@apple.com
  • 9 edits in trunk/LayoutTests/platform/mac/fast/text
12:41 PM Changeset in webkit [78864] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/text/fixed-pitch-control-characters-expected.png
12:41 PM Changeset in webkit [78863] by hyatt@apple.com
  • 10 edits in trunk/LayoutTests/platform/mac/fast/text
12:40 PM Changeset in webkit [78862] by hyatt@apple.com
  • 6 edits in trunk/LayoutTests/platform/mac/fast/text
12:40 PM Changeset in webkit [78861] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/text
12:37 PM Changeset in webkit [78860] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/text/basic
12:37 PM Changeset in webkit [78859] by hyatt@apple.com
  • 12 edits in trunk/LayoutTests/platform/mac/fast/text/international
12:37 PM Changeset in webkit [78858] by hyatt@apple.com
  • 5 edits in trunk/LayoutTests/platform/mac/fast/text/international
12:36 PM Changeset in webkit [78857] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/text/international
12:35 PM Changeset in webkit [78856] by oliver@apple.com
  • 8 edits
    1 add in trunk/Source/JavaScriptCore

2011-02-17 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Refactor WriteBarrier and DeprecatedPtr to have less code duplication.
https://bugs.webkit.org/show_bug.cgi?id=54608

Make use of the tricks used for Handle, et al to avoid duplicating all
of the logic for DeprecatedPtr and WriteBarrier simply to support known
vs. unknown types.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • collector/handles/Global.h: (JSC::Global::internalSet):
  • collector/handles/Handle.h: (JSC::Handle::Handle): (JSC::Handle::get):
  • runtime/JSArray.cpp: (JSC::JSArray::sortNumeric):
  • runtime/JSObject.h: (JSC::JSObject::inlineGetOwnPropertySlot):
  • runtime/SlotAccessor.h: Added. (JSC::SlotTypes::getFromBaseType): (JSC::SlotTypes::convertToBaseType): (JSC::SlotTypes::getFromSlot): (JSC::SlotTypes::toJSValue): (JSC::SlotTypes::validateUpcast): (JSC::SlotAccessor::operator->): (JSC::SlotAccessor::operator*):
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtr::get): (JSC::WeakGCPtr::internalSet):
  • runtime/WriteBarrier.h: (JSC::DeprecatedPtr::DeprecatedPtr): (JSC::DeprecatedPtr::get): (JSC::DeprecatedPtr::slot): (JSC::DeprecatedPtr::operator=): (JSC::WriteBarrierTranslator::convertToStorage): (JSC::WriteBarrierTranslator::convertFromStorage): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::clear): (JSC::WriteBarrierBase::slot): (JSC::WriteBarrierBase::operator UnspecifiedBoolType*): (JSC::WriteBarrierBase::operator!): (JSC::WriteBarrierBase::setWithoutWriteBarrier): (JSC::WriteBarrier::WriteBarrier):
12:35 PM Changeset in webkit [78855] by hyatt@apple.com
  • 63 edits in trunk/LayoutTests/platform/mac/fast/text/international
12:35 PM Changeset in webkit [78854] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/text/international
12:33 PM Changeset in webkit [78853] by commit-queue@webkit.org
  • 8 edits in trunk/Source

2011-02-17 W. James MacLean <wjmaclean@chromium.org>

Reviewed by James Robinson.

[chromium] Add command-line flag to enable composite to offscreen texture.
https://bugs.webkit.org/show_bug.cgi?id=52311

Add plumbing to allow command-line switch to enable offscreen compositing. Function
LayerRendererChromium::copyOffscreenTextureToDisplay used for now to mimic
normal renderer operation.

Existing functionality not changed; offscreen compositing will be tested via GPU test framework.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::setRootLayer): (WebCore::LayerRendererChromium::setCompositeOffscreen): (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::setScissorToRect):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::isCompositingOffscreen):

2011-02-17 W. James MacLean <wjmaclean@chromium.org>

Reviewed by James Robinson.

[chromium] Add command-line flag to enable composite to offscreen texture.
https://bugs.webkit.org/show_bug.cgi?id=52311

Add plumbing to allow command-line switch to enable offscreen compositing. Function
LayerRendererChromium::copyOffscreenTextureToDisplay used for now to mimic
normal renderer operation.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::WebSettingsImpl): (WebKit::WebSettingsImpl::setCompositeToTextureEnabled):
  • src/WebSettingsImpl.h: (WebKit::WebSettingsImpl::compositeToTextureEnabled):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doComposite):
12:24 PM Changeset in webkit [78852] by kevino@webkit.org
  • 14 edits in trunk

[wx] Build fixes after recent changes.

12:02 PM Changeset in webkit [78851] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Qt build fix.

  • WebKit2.pro: Update after renaming of MemoryCache to ResourceCache.
11:55 AM Changeset in webkit [78850] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Mac build fix.

  • WebKit2.xcodeproj/project.pbxproj: Use relative to group instead of absolute paths. Not everyone's home

directory is /Users/brian_weinstein.

11:35 AM Changeset in webkit [78849] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/platform/efl/FileChooserEfl.cpp

Fix EFL bustage.

11:28 AM Changeset in webkit [78848] by bweinstein@apple.com
  • 23 edits
    11 adds in trunk/Source

WebKit2: Need a way to manage the WebCore Cache
https://bugs.webkit.org/show_bug.cgi?id=54501

Reviewed by Brady Eidson.

Source/WebCore:

Add a way to get a set of all of the origins that have entries in the
WebCore memory cache, and a method to remove all resources from the memory
cache from a given security origin.

No change in behavior.

  • WebCore.exp.in: Add functions that need to be exported.
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeResourcesWithOrigin):
(WebCore::MemoryCache::getOriginsWithCache):

  • loader/cache/MemoryCache.h:

Source/WebKit2:

Implement a WebKit2 API to manage the WebCore memory cache. This API exposes three functions:

1) A method to get a list of all security origins that have entries in the WebCore memory cache.
2) A method to remove all entries in the WebCore memory cache from a SecurityOrigin.
3) A method to remove all entries from the WebCore memory cache.

  • Platform/CoreIPC/MessageID.h: Add two new MessageClasses.
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h: Add a CacheManager type.
  • Shared/WebSecurityOrigin.h: Typedef WKCacheManagerRef.

(WebKit::WebSecurityOrigin::createFromString): Creates a WebCore::SecurityOrigin using

SecurityOrigin::createFromString.

(WebKit::WebSecurityOrigin::toString): Calls through to SecurityOrigin::toString.

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKCacheManager.cpp: Added.

(WKCacheManagerGetTypeID): Returns the WebResourceCacheManagerProxy type.
(WKCacheManagerGetCacheOrigins): Calls through to WebResourceCacheManagerProxy::getCacheOrigins.
(callGetCacheOriginsBlockBlockAndDispose):
(WKCacheManagerGetCacheOrigins_b):
(WKCacheManagerDeleteCacheForOrigin): Calls through to WebResourceCacheManagerProxy::deleteCacheForOrigin.
(WKCacheManagerDeleteAllCache): Calls through to WebResourceCacheManagerProxy::deleteAllCache.

  • UIProcess/API/C/WKCacheManager.h: Added.
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetCacheManager): Calls to get the WebResourceCacheManagerProxy.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebResourceCacheManagerProxy.cpp: Added.

(WebKit::WebResourceCacheManagerProxy::create): Calls through to the constructor.
(WebKit::WebResourceCacheManagerProxy::WebResourceCacheManagerProxy): Initialize the m_webContext variable.
(WebKit::WebResourceCacheManagerProxy::~WebResourceCacheManagerProxy):
(WebKit::WebResourceCacheManagerProxy::invalidate): Invalidate the callback map.
(WebKit::WebResourceCacheManagerProxy::getCacheOrigins): Call through to the web process to get the cache

origins.

(WebKit::WebResourceCacheManagerProxy::didGetCacheOrigins): Call the callback.
(WebKit::WebResourceCacheManagerProxy::deleteCacheForOrigin): Call through to the web process to delete cache

for the given origin.

(WebKit::WebResourceCacheManagerProxy::deleteAllCache): Call through to the web process to delete all of the cache.

  • UIProcess/WebResourceCacheManagerProxy.h: Added.

(WebKit::WebResourceCacheManagerProxy::clearContext):
(WebKit::WebResourceCacheManagerProxy::type):

  • UIProcess/WebResourceCacheManagerProxy.messages.in: Added.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize new member variable.
(WebKit::WebContext::~WebContext): Invalidates new member variable.
(WebKit::WebContext::didReceiveMessage): Passes cache messages to the cache manager.

  • UIProcess/WebContext.h:

(WebKit::WebContext::cacheManagerProxy):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage): Add a new message class.

  • WebProcess/MemoryCache/WebResourceCacheManager.cpp: Added.

(WebKit::WebResourceCacheManager::shared):
(WebKit::WebResourceCacheManager::WebResourceCacheManager):
(WebKit::WebResourceCacheManager::~WebResourceCacheManager):
(WebKit::WebResourceCacheManager::didReceiveMessage): Calls through to didReceiveWebResourceCacheManagerMessage.
(WebKit::WebResourceCacheManager::getCacheOrigins): Gets a list of origins with cache entries from the memory

cache, and puts them into a vector to send to the UI process.

(WebKit::WebResourceCacheManager::deleteCacheForOrigin): Calls through to memoryCache to delete all cache entries

from a given origin.

(WebKit::WebResourceCacheManager::deleteAllCache):

  • WebProcess/MemoryCache/WebResourceCacheManager.h: Added.
  • WebProcess/MemoryCache/WebResourceCacheManager.messages.in: Added.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):
(WebKit::WebProcess::clearResourceCaches): Tell the memory cache to evict its resources. This was done on WebKit1,

but not WebKit2.

  • WebProcess/WebProcess.h:


  • WebKit2.xcodeproj/project.pbxproj: Added new files.
  • win/WebKit2.vcproj: Ditto.
  • win/WebKit2Common.vsprops: Added new include directory.
  • win/WebKit2Generated.make: Added new header.
11:27 AM Changeset in webkit [78847] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-02-17 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

SVG: Add test for color animation with alpha value in calcMode=discrete
https://bugs.webkit.org/show_bug.cgi?id=54666

  • svg/animations/animate-color-rgba-calcMode-discrete-expected.txt: Added.
  • svg/animations/animate-color-rgba-calcMode-discrete.html: Added.
  • svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js: Added.
11:19 AM Changeset in webkit [78846] by hyatt@apple.com
  • 76 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=54244

Reviewed by Dan Bernstein.

Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.

The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
been changed as well.

In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).

Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.

Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
still have a precise floating point position.

Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
be rounding justification spacing in their font code.

Many layout test results change on Mac, since rounding hacks were used there and are now gone.

../WebCore:

  • WebCore.exp.in:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • platform/chromium/FileChooserChromium.cpp:

(WebCore::FileChooser::basenameForWidth):

  • platform/graphics/Font.cpp:

(WebCore::Font::width):

  • platform/graphics/Font.h:

(WebCore::Font::spaceWidth):
(WebCore::Font::tabWidth):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::getGlyphsAndAdvancesForSimpleText):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawText):
(WebCore::GraphicsContext::drawEmphasisMarks):
(WebCore::GraphicsContext::drawBidiText):
(WebCore::GraphicsContext::drawHighlightForText):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::platformGlyphInit):

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::spaceWidth):

  • platform/graphics/StringTruncator.cpp:

(WebCore::stringWidth):
(WebCore::truncateString):
(WebCore::StringTruncator::centerTruncate):
(WebCore::StringTruncator::rightTruncate):
(WebCore::StringTruncator::width):

  • platform/graphics/StringTruncator.h:
  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::xPos):
(WebCore::TextRun::expansion):
(WebCore::TextRun::directionalOverride):
(WebCore::TextRun::disableSpacing):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advance):

  • platform/graphics/WidthIterator.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForTextChecking):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLineForText):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::advance):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::getGlyphsAndAdvancesForComplexText):

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawLineForTextChecking):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForTextChecking):

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformGlyphInit):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking):
(WebCore::GraphicsContext::drawLineForText):

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking):

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem):

  • platform/gtk/FileChooserGtk.cpp:

(WebCore::FileChooser::basenameForWidth):

  • platform/mac/DragImageMac.mm:

(WebCore::widthWithFont):
(WebCore::drawAtPoint):

  • platform/mac/FileChooserMac.mm:

(WebCore::FileChooser::basenameForWidth):

  • platform/win/DragImageWin.cpp:

(WebCore::createDragImageForLink):

  • platform/win/FileChooserWin.cpp:

(WebCore::FileChooser::basenameForWidth):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):

  • platform/win/WebCoreTextRenderer.cpp:

(WebCore::WebCoreTextFloatWidth):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::addNodeToRectBasedTestResult):

  • rendering/HitTestResult.h:
  • rendering/InlineBox.cpp:

(WebCore::InlineBox::adjustPosition):
(WebCore::InlineBox::placeEllipsisBox):
(WebCore::InlineBox::locationIncludingFlipping):
(WebCore::InlineBox::flipForWritingMode):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::adjustLineDirectionPosition):
(WebCore::InlineBox::adjustBlockDirectionPosition):
(WebCore::InlineBox::setX):
(WebCore::InlineBox::x):
(WebCore::InlineBox::setY):
(WebCore::InlineBox::y):
(WebCore::InlineBox::width):
(WebCore::InlineBox::height):
(WebCore::InlineBox::logicalLeft):
(WebCore::InlineBox::logicalRight):
(WebCore::InlineBox::setLogicalLeft):
(WebCore::InlineBox::pixelSnappedLogicalLeft):
(WebCore::InlineBox::pixelSnappedLogicalRight):
(WebCore::InlineBox::setLogicalWidth):
(WebCore::InlineBox::logicalWidth):
(WebCore::InlineBox::verticalAlign):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::roundedFrameRect):
(WebCore::InlineFlowBox::adjustPosition):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::verticalPositionForBox):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverflow):
(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::placeEllipsisBox):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::maxYLayoutOverflow):
(WebCore::InlineFlowBox::maxXLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::maxYVisualOverflow):
(WebCore::InlineFlowBox::maxXVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintDocumentMarkers):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::textPos):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::setExpansion):

  • rendering/RenderBR.h:

(WebCore::RenderBR::width):

  • rendering/RenderBlock.cpp:

(WebCore::stripTrailingSpace):
(WebCore::updatePreferredWidth):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::addFocusRingRects):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::fitBelowFloats):
(WebCore::textWidth):
(WebCore::tryHyphenating):
(WebCore::RenderBlock::findNextLineBreak):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::flipForWritingMode):

  • rendering/RenderBox.h:
  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::width):
(WebCore::RenderCombineText::adjustTextOrigin):
(WebCore::RenderCombineText::combineText):

  • rendering/RenderCombineText.h:

(WebCore::RenderCombineText::combinedTextWidth):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::computePreferredLogicalWidths):

  • rendering/RenderCounter.h:
  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderImage.cpp:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):

  • rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::minLogicalWidth):
(WebCore::RenderText::maxLogicalWidth):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::firstRunOrigin):
(WebCore::RenderText::firstRunX):
(WebCore::RenderText::firstRunY):
(WebCore::RenderText::width):
(WebCore::RenderText::linesBoundingBox):

  • rendering/RenderText.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::getAvgCharWidth):
(WebCore::RenderTextControl::paintPlaceholder):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeTextRun):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::placeEllipsisBox):
(WebCore::RootInlineBox::adjustPosition):
(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
(WebCore::RootInlineBox::paddedLayoutOverflowRect):

  • rendering/RootInlineBox.h:
  • rendering/VerticalPositionCache.h:
  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::offsetForPosition):
(WebCore::SVGInlineTextBox::positionForOffset):
(WebCore::SVGInlineTextBox::constructTextRun):

  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeRenderSVGTextBox):

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::SVGTextMetrics):
(WebCore::constructTextRun):

  • svg/SVGFont.cpp:

(WebCore::floatWidthMissingGlyphCallback):
(WebCore::Font::drawTextUsingSVGFont):

../WebKit/mac:

  • Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
(-[NSString _web_widthWithFont:]):

../WebKit/win:

  • WebKitGraphics.cpp:

(CenterTruncateStringToWidth):
(RightTruncateStringToWidth):

../WebKit2:

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

11:04 AM Changeset in webkit [78845] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-17 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Remove duplicate expectation
for media/video-display-toggle.html (on Snow Leopard only).

  • platform/chromium/test_expectations.txt:
10:57 AM Changeset in webkit [78844] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

2011-02-17 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

'ex' coordinates fail, when SVGFont doesn't provide an explicit xHeight attribute
https://bugs.webkit.org/show_bug.cgi?id=54672

Measure the xHeight from the 'x' glyph of a SVGFont, if the font itself doesn't explicitely specify an x-height attribute.
Fixes the modern version of SVG 1.1 2nd Edition coords-units-03-b.svg.

Test: svg/W3C-SVG-1.1-SE/coords-units-03-b.svg

  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):

2011-02-17 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

'ex' coordinates fail, when SVGFont doesn't provide an explicit xHeight attribute
https://bugs.webkit.org/show_bug.cgi?id=54672

Add new testcase from SVG 1.1 2nd Edition covering exs support + SVGFonts.

  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/coords-units-03-b.svg: Added.
10:21 AM Changeset in webkit [78843] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations update.

[Chromium] set_version_blocked.html and set_version_queue.html started crashing on Chromium dbg bots after WK roll 78748:78777
https://bugs.webkit.org/show_bug.cgi?id=54644

Re-enabling tests now that they pass again.

  • platform/chromium/test_expectations.txt:
10:04 AM Changeset in webkit [78842] by luiz@webkit.org
  • 29 edits in trunk/Source

HTML5 <details> and <summary>: localized text
https://bugs.webkit.org/show_bug.cgi?id=54260

Reviewed by Adam Roben.

Source/WebCore:

The method defaultDetailsSummaryText was added to LocalizationStrategy class and to
platform/LocalizedStrings. It is used to provide the default label to be used by a
<details> tag that has no <summary> child.

  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:

(WebCore::fileButtonNoFileSelectedLabel):
(WebCore::defaultDetailsSummaryText):

  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp:

(WebCore::defaultDetailsSummaryText):

  • platform/brew/LocalizedStringsBrew.cpp:

(WebCore::defaultDetailsSummaryText):

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::defaultDetailsSummaryText):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::defaultDetailsSummaryText):

  • platform/haiku/LocalizedStringsHaiku.cpp:

(WebCore::defaultDetailsSummaryText):

  • platform/wx/LocalizedStringsWx.cpp:

(WebCore::defaultDetailsSummaryText):

Source/WebKit:

Default details summary text must be localizable.

  • English.lproj/Localizable.strings:

Source/WebKit/chromium:

The method defaultDetailsSummaryText was added to LocalizedStrings. It is used to provide
the default label to be used by a <details> tag that has no <summary> child.

  • src/LocalizedStrings.cpp:

(WebCore::defaultDetailsSummaryText):

Source/WebKit/mac:

The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::defaultDetailsSummaryText):

Source/WebKit/qt:

The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::defaultDetailsSummaryText):

  • WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit/win:

The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::defaultDetailsSummaryText):

  • WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit/wince:

The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::defaultDetailsSummaryText):

  • WebCoreSupport/PlatformStrategiesWinCE.h:

Source/WebKit2:

The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::defaultDetailsSummaryText):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
10:00 AM Changeset in webkit [78841] by hans@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-17 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: enable test for auto increment key injection
https://bugs.webkit.org/show_bug.cgi?id=54642

Enable this test now that Chromium supports it.

  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
9:41 AM Changeset in webkit [78840] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

2011-02-17 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Andreas Kling.

[Qt] ImageDiff sometimes hangs
https://bugs.webkit.org/show_bug.cgi?id=54641

  • DumpRenderTree/qt/ImageDiff.cpp: Clear actualImage and baselineImage after all comparison. (main):
9:30 AM Changeset in webkit [78839] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-17 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Re-enabling inspector/elements/mutate-unknown-node.html -- should pass after r78831.
https://bugs.webkit.org/show_bug.cgi?id=54635

9:26 AM Changeset in webkit [78838] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-17 Steve Lacey <sjl@chromium.org>

Reviewed by Darin Fisher.

Roll chromium deps to 75190. Includes new dependency
on libjingle.

https://bugs.webkit.org/show_bug.cgi?id=54588

  • DEPS:
9:22 AM Changeset in webkit [78837] by sergio@webkit.org
  • 2 edits
    199 adds in trunk/LayoutTests

2011-02-17 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Added a bunch of GTK+ baselines for Mozilla test suites
(tables/mozilla/marvin).

  • platform/gtk/Skipped: Unskip tests which now have results.
9:06 AM Changeset in webkit [78836] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-17 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
8:35 AM Changeset in webkit [78835] by pvarga@webkit.org
  • 2 edits in trunk/Tools

2011-02-17 Peter Varga <pvarga@webkit.org>

Reviewed by Csaba Osztrogonác.

The run-sunspider --v8-suite doesn't work
https://bugs.webkit.org/show_bug.cgi?id=54660

  • Scripts/run-sunspider:
8:27 AM Changeset in webkit [78834] by commit-queue@webkit.org
  • 4 edits in trunk

2011-02-17 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Laszlo Gombos.

Updated include paths for phonon.

[Qt] WebKit patches required to work with a modularized version of Qt
https://bugs.webkit.org/show_bug.cgi?id=53916

  • Source/WebKit.pri:

2011-02-17 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Laszlo Gombos.

Updated include paths for phonon.

[Qt] WebKit patches required to work with a modularized version of Qt
https://bugs.webkit.org/show_bug.cgi?id=53916

Build fix. No tests.

  • WebCore.pro:
8:25 AM Changeset in webkit [78833] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-02-17 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kent Tamura.

[EFL] Possible crash of ewk_frame_contents_set
https://bugs.webkit.org/show_bug.cgi?id=54091

Use length of contents if contents_size parameter is bigger than length
of contents.

  • ewk/ewk_frame.cpp: (_ewk_frame_contents_set_internal):
8:19 AM Changeset in webkit [78832] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Make sure layout is up-to-date before rendering the layer tree in DrawingAreaImpl

Fixes <http://webkit.org/b/54646> <rdar://problem/9016889> Assertion failure in
FrameView::paintContents when calling WKPageForceRepaint on a page that uses accelerated
compositing

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint): Lay out before we do anything else.

8:13 AM Changeset in webkit [78831] by loislo@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-17 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] inspector/elements/mutate-unknown-node.html test is flaky.
https://bugs.webkit.org/show_bug.cgi?id=54635

It was a race condition. Sometimes Inspector was loaded before domContentLoaded event but sometimes not.
As result it receives second setDocument and got new ids for the DOM elements.

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.dumpDOMAgentTree): (initialize_ElementTest):
  • inspector/elements/mutate-unknown-node-expected.txt:
  • inspector/elements/mutate-unknown-node.html:
8:00 AM Changeset in webkit [78830] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a new spinbutton test on Windows

Also updated the Bugzilla URL for these tests to point to a bug that isn't marked Resolved,
since clearly there's still an unresolved bug here! The new bug is
<http://webkit.org/b/54662>.

  • platform/win/Skipped: Added fast/forms/input-appearance-spinbutton-layer.html.
7:59 AM Changeset in webkit [78829] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Check in expected failure results on Windows for accessibility/canvas-fallback-content.html

Failure is tracked by <http://webkit.org/b/54654>.

  • platform/win/accessibility/canvas-fallback-content-expected.txt: Added.
7:59 AM Changeset in webkit [78828] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a failing test on Windows

Failure is tracked by <http://webkit.org/b/54655>.

  • platform/win/Skipped: Added

http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html.

7:58 AM Changeset in webkit [78827] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update Windows results after r78690

Fixes <http://webkit.org/b/54657>.

  • platform/win/media/controls-without-preload-expected.txt:
7:58 AM Changeset in webkit [78826] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip all inspector/debugger tests on Windows

The failures are tracked by <http://webkit.org/b/54490>.

  • platform/win/Skipped:
7:55 AM BuildingGtk edited by Martin Robinson
(diff)
7:32 AM Changeset in webkit [78825] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-17 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Mark inspector/debugger/debug-inlined-scripts.html as crashing in debug.
https://bugs.webkit.org/show_bug.cgi?id=54659

7:05 AM Changeset in webkit [78824] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-02-17 Philippe Normand <pnormand@igalia.com>

Unreviewed, rebaseline GTK test results.

[GStreamer] media/video-zoom-controls.html fails
https://bugs.webkit.org/show_bug.cgi?id=50918

  • platform/gtk/Skipped:
  • platform/gtk/media/video-zoom-controls-expected.txt:
7:01 AM Changeset in webkit [78823] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-02-17 Grzegorz Czajkowski <g.czajkowski@samsung.com>

Reviewed by Kent Tamura.

Doxygen documentation for ewk cookies
https://bugs.webkit.org/show_bug.cgi?id=54553

  • ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_policy_set): (ewk_cookies_policy_get):
  • ewk/ewk_cookies.h:
6:55 AM Changeset in webkit [78822] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-17 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Skip inspector/elements/mutate-unknown-node.html, it now timeouts.

6:23 AM Changeset in webkit [78821] by sergio@webkit.org
  • 2 edits
    75 adds in trunk/LayoutTests

2011-02-17 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Add the next set (tables/mozilla/dom) of GTK+ Mozilla test suite results.

  • platform/gtk/Skipped: Updated the skipped list.
6:16 AM Changeset in webkit [78820] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed -- forgot to specify 'DEBUG' prefix for expectations in r78818.

6:08 AM Changeset in webkit [78819] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-17 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, interactive ui test fix for r78808.

  • src/js/Tests.js: (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts): (.TestSuite.prototype._waitUntilScriptsAreParsed):
6:05 AM Changeset in webkit [78818] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-17 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
storage/indexeddb/set_version_(blocked|queue).html fails on all platforms in dbg on Chromium waterfall.
https://bugs.webkit.org/show_bug.cgi?id=54644

5:39 AM Changeset in webkit [78817] by commit-queue@webkit.org
  • 7 edits in trunk/Source

2011-02-17 Hui Huang <hui.2.huang@nokia.com>

Reviewed by Laszlo Gombos.

The URL of HTML5 Video Element is percent encoded at websites such as youtube.
It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
the HTTP GET request for the video to be rejected by the service provider.
https://bugs.webkit.org/show_bug.cgi?id=53973.

The bug is fixed by constructing QUrl from the encoded URL.

New test function tst_QWebPage::loadHtml5Video() is added in
Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::commitLoad):

2011-02-17 Hui Huang <hui.2.huang@nokia.com>

Reviewed by Laszlo Gombos.

The URL of HTML5 Video Element is percent encoded at websites such as youtube.
It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
the HTTP GET request for the video to be rejected by the service provider.
https://bugs.webkit.org/show_bug.cgi?id=53973.

The bug is fixed by constructing QUrl from the encoded URL in
MediaPlayerPrivateQt::commitLoad.

New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
is skipped if Qt Multimedia is not available.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::loadHtml5Video):
  • tests/tests.pri:
5:38 AM Changeset in webkit [78816] by andreas.kling@nokia.com
  • 4 edits in trunk/Source

2011-02-17 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

[Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
https://bugs.webkit.org/show_bug.cgi?id=49216

  • tests/qwebframe/tst_qwebframe.cpp:

2011-02-17 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

[Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
https://bugs.webkit.org/show_bug.cgi?id=49216

CachedResourceRequest::didFail() will protect the CachedResourceLoader's
document() while it runs, but if we're being called from the Document destructor,
the protecting RefPtr<Document> will cause a double-delete instead.

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::~CachedResourceLoader): Clear the m_document pointer so CachedResourceRequest::didFail() won't try to protect it. (WebCore::CachedResourceLoader::frame): Add null-check for m_document.
5:20 AM Changeset in webkit [78815] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-17 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Add updateHighlight method to the highlighter
https://bugs.webkit.org/show_bug.cgi?id=54448

  • inspector/front-end/SourceTokenizer.js:
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype.set mimeType): (WebInspector.TextEditorHighlighter.prototype.reset): (WebInspector.TextEditorHighlighter.prototype.updateHighlight): (WebInspector.TextEditorHighlighter.prototype._highlightInChunks): (WebInspector.TextEditorHighlighter.prototype._highlightLines):
5:14 AM Changeset in webkit [78814] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-17 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
media/video-display-toggle.html fails on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=54640

5:02 AM Changeset in webkit [78813] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-17 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Added flaky test media/video-display-toggle.html. Fails only on
debug bots.

  • platform/gtk/Skipped: Updated the skipped list.
4:55 AM Changeset in webkit [78812] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-17 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
inspector/elements/set-attribute.html works -- enable it.
inspector/debugger/dom-breakpoints.html timeouts -- bug filed.
https://bugs.webkit.org/show_bug.cgi?id=54638

4:38 AM Changeset in webkit [78811] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-17 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Mark inspector/elements/mutate-unknown-node.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=54635

4:37 AM BuildingGtk edited by Csaba Osztrogonác
Update necessary libglib version. Based on … (diff)
4:34 AM Changeset in webkit [78810] by mnaganov@chromium.org
  • 8 edits
    18 adds in trunk/LayoutTests/platform

2011-02-17 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update after r78806.
Rebaseline SVG tests:
batik/paints/patternRegions-positioned-objects.svg
custom/nested-pattern-boundingBoxModeContent.svg
dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr.html
dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop.html

4:20 AM Changeset in webkit [78809] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-17 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update after r78878.
Skip timing out media/video-controls-in-media-document.html.
https://bugs.webkit.org/show_bug.cgi?id=54634

4:08 AM Changeset in webkit [78808] by podivilov@chromium.org
  • 6 edits
    2 adds in trunk

2011-02-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: show all inlined scripts from single document in the same source frame.
https://bugs.webkit.org/show_bug.cgi?id=54544

Currently when debugging synchronously executed inlined scripts each script is shown in it's own source frame ("example.html:24").
We should show such scripts in the same source frame "example.html" with <script></script> framing.

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest._pausedScript): (initialize_DebuggerTest.InspectorTest._resumedScript):
  • inspector/debugger/debug-inlined-scripts-expected.txt: Added.
  • inspector/debugger/debug-inlined-scripts.html: Added.
  • inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger/debugger-pause-on-breakpoint.html:

2011-02-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: show all inlined scripts from single document in the same source frame.
https://bugs.webkit.org/show_bug.cgi?id=54544

Currently when debugging synchronously executed inlined scripts each script is shown in it's own source frame ("example.html:24").
We should show such scripts in the same source frame "example.html" with <script></script> framing.

Test: inspector/debugger/debug-inlined-scripts.html

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype._resourceForURL): (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype.addConsoleMessage): (WebInspector.ScriptsPanel.prototype.clearConsoleMessages): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): (WebInspector.ScriptsPanel.prototype._sourceFrameForScript): (WebInspector.ScriptsPanel.prototype._recreateSourceFrame): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu.optionCompare): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent): (WebInspector.SourceFrameContentProviderForScript.prototype._buildSource):
3:13 AM Changeset in webkit [78807] by rgabor@webkit.org
  • 2 edits in trunk/Tools

2011-02-17 Gabor Rapcsanyi <rgabor@webkit.org>

Reviewed by Csaba Osztrogonác.

[NRWT] Fix environment setup on Qt port.
https://bugs.webkit.org/show_bug.cgi?id=54549

  • Scripts/webkitpy/layout_tests/port/qt.py:
3:00 AM Changeset in webkit [78806] by Nikolas Zimmermann
  • 9 edits
    4 adds in trunk

2011-02-17 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

svg/batik/paints/patternRegions-positioned-objects.svg fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=44484

Pattern of pattern defined with objectBoundingBox does not render correctly
https://bugs.webkit.org/show_bug.cgi?id=53463

Fix <pattern> + patternContentUnits="objectBoundingBox" support.
We were incorrrectly translating the tile image transform, by the target objects bbox.x()/y().
RenderSVGResourceMask/Clipper don't have this error.


Fix nesting <patterns> in objectBoundingBox mode, propagate the tileImageTransform as new user-space
when drawing the pattern children. <mask> + <clipPath> don't have the problem.

Test: svg/custom/nested-pattern-boundingBoxModeContent.svg

  • rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildTileImageTransform): (WebCore::RenderSVGResourcePattern::createTileImage):

2011-02-17 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

svg/batik/paints/patternRegions-positioned-objects.svg fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=44484


Pattern of pattern defined with objectBoundingBox does not render correctly
https://bugs.webkit.org/show_bug.cgi?id=53463

Update SnowLeopard pixel test baseline after adding new patternContentUnits="objectBoundingBox" tests.

  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.checksum:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/mac/svg/custom/nested-pattern-boundingBoxModeContent-expected.checksum: Added.
  • platform/mac/svg/custom/nested-pattern-boundingBoxModeContent-expected.png: Added.
  • platform/mac/svg/custom/nested-pattern-boundingBoxModeContent-expected.txt: Added.
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png:
  • svg/custom/nested-pattern-boundingBoxModeContent.svg: Added.
2:46 AM Changeset in webkit [78805] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html fails
https://bugs.webkit.org/show_bug.cgi?id=54630

  • platform/qt/Skipped: Add http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html temporarily.
2:32 AM Changeset in webkit [78804] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-17 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

[GTK] Failing canvas security tests
https://bugs.webkit.org/show_bug.cgi?id=30580

Test is working fine locally in both release and debug builds so
unskipping it.

  • platform/gtk/Skipped: Updated the skipped list.
2:21 AM Changeset in webkit [78803] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed.

[Qt][V8] Buildfix after r78752.

  • CodeGenerators.pri: Add missing IDL files.
1:50 AM Changeset in webkit [78802] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-17 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping failing test on GTK bots.

[GTK] accessibility/canvas-fallback-content.html is failing on GTK bots
https://bugs.webkit.org/show_bug.cgi?id=54626

  • platform/gtk/Skipped: Skipping failing test.
1:39 AM Changeset in webkit [78801] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-17 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Skipped four SVG tests that started to show rounding errors (1
pixel difference) after r78704.

  • platform/gtk/Skipped: Update the skipped list.
1:35 AM Changeset in webkit [78800] by alex
  • 4 edits in trunk/Source/WebKit2

2011-02-17 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add WKPluginSiteDataManager.cpp compilation after r78647
https://bugs.webkit.org/show_bug.cgi?id=54564

  • GNUmakefile.am: Added files to compilation.
  • Shared/Plugins/Netscape/NetscapePluginModule.h: used npruntime_internal.h in the include to avoid problems with X types.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::setAlwaysUsesComplexTextCodePath): fixed ambiguous reference to Font caused by the X headers required by the plugins.
1:02 AM Changeset in webkit [78799] by kalman@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-17 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

RTL lineboundary left/right is reversed when cursor is at start of RTL container
https://bugs.webkit.org/show_bug.cgi?id=54534

Test extending the selection left/right by lineboundary from both the leftmost/rightmost ends of LTR and RTL
containers with both LTR and RTL text.

  • editing/selection/extend-left-right-by-lineboundary-expected.txt: Added.
  • editing/selection/extend-left-right-by-lineboundary.html: Added.

2011-02-17 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

RTL lineboundary left/right is reversed when cursor is at start of RTL container
https://bugs.webkit.org/show_bug.cgi?id=54534

Test: editing/selection/extend-left-right-by-lineboundary.html

Add missing cases for extending left/right by lineboundary.

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRight): (WebCore::SelectionController::modifyExtendingLeft):
12:25 AM Changeset in webkit [78798] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-02-16 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] libsoup critical warnings
https://bugs.webkit.org/show_bug.cgi?id=54557

Avoid pausing a soup message for already downloaded resources.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::platformSetDefersLoading):
12:21 AM Changeset in webkit [78797] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-17 Philippe Normand <pnormand@igalia.com>

Unreviewed, fix media-file.js path after r78778.

  • media/video-display-aspect-ratio.html:
12:21 AM Changeset in webkit [78796] by Philippe Normand
  • 1 edit in trunk/LayoutTests/ChangeLog

2011-02-16 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] media/video-display-toggle.html still flaky on 32-Bits Release
https://bugs.webkit.org/show_bug.cgi?id=54552

  • media/video-display-toggle.html: Start playback before triggering the display toggle, ensuring the controls (esp. duration display) are conistent.

Feb 16, 2011:

11:17 PM Changeset in webkit [78795] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Intermittent crashes beneath MarkStack::drain
https://bugs.webkit.org/show_bug.cgi?id=54614
<rdar://problem/8971070>

The crashes were caused by a GC happening after the global object's
property table had grown (due to compilation), but before the properties
had been fully initialized by program execution.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Explicitly resize the global object's register storage immediately, without waiting for program execution to do it for us. This ensures that the global object's count of global variables is consistent with the size of its global variable storage at all times, and it ensures that all global variables are properly initialized from the get-go.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::resizeRegisters):
  • runtime/JSGlobalObject.h: Added a helper function for growing the global object's register storage, and initializing new registers.
11:09 PM Changeset in webkit [78794] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-16 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Web Inspector: chromium: update test expectation.

  • platform/chromium/inspector/timeline/timeline-parse-html-expected.txt:
  • platform/chromium/test_expectations.txt:
10:53 PM Changeset in webkit [78793] by loislo@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-02-16 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Web Inspector: remove custom test expectations for chromium.

  • platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
10:30 PM Changeset in webkit [78792] by mrowe@apple.com
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

10:28 PM Changeset in webkit [78791] by mrowe@apple.com
  • 1 copy in tags/Safari-534.20.2

New tag.

10:25 PM Changeset in webkit [78790] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-02-16 Brian Ryner <bryner@chromium.org>

Reviewed by Darin Fisher.

Split the socket address field into separate IP address and port fields.
This will make the field less error-prone to parse, for example when
dealing with IPv6 literals.
https://bugs.webkit.org/show_bug.cgi?id=54607

No new tests required.

  • platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::remoteIPAddress): (WebCore::ResourceResponse::setRemoteIPAddress): (WebCore::ResourceResponse::remotePort): (WebCore::ResourceResponse::setRemotePort):

2011-02-16 Brian Ryner <bryner@chromium.org>

Reviewed by Darin Fisher.

Split the socket address field into separate IP address and port fields.
This will make the field less error-prone to parse, for example when
dealing with IPv6 literals.
https://bugs.webkit.org/show_bug.cgi?id=54607

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::remoteIPAddress): (WebKit::WebURLResponse::setRemoteIPAddress): (WebKit::WebURLResponse::remotePort): (WebKit::WebURLResponse::setRemotePort):
8:56 PM Changeset in webkit [78789] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

2011-02-16 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Chris Fleizach.

Add new test for canvas fallback content and update existing text for new canvas role.
https://bugs.webkit.org/show_bug.cgi?id=50126

  • accessibility/canvas-fallback-content-expected.txt: Added.
  • accessibility/canvas-fallback-content.html: Added.
  • accessibility/canvas.html:

2011-02-16 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Chris Fleizach.

Add support for canvas fallback content.
https://bugs.webkit.org/show_bug.cgi?id=50126

Test: accessibility/canvas-fallback-content.html

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole): (WebCore::AccessibilityRenderObject::canHaveChildren):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
  • accessibility/mac/AccessibilityObjectWrapper.mm:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isFocusable):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::recursiveSetNoNeedsLayout): (WebCore::RenderHTMLCanvas::layout): (WebCore::RenderHTMLCanvas::nodeAtPoint):
  • rendering/RenderHTMLCanvas.h: (WebCore::RenderHTMLCanvas::children): (WebCore::RenderHTMLCanvas::canHaveChildren): (WebCore::RenderHTMLCanvas::virtualChildren):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaint):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):

2011-02-16 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Chris Fleizach.

Add new role for canvas elements.

https://bugs.webkit.org/show_bug.cgi?id=50126

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:

2011-02-16 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Chris Fleizach.

Add new role for canvas elements.

https://bugs.webkit.org/show_bug.cgi?id=50126

Test: accessibility/canvas-fallback-content.html

  • AccessibleBase.cpp: (MSAARole):
8:54 PM Changeset in webkit [78788] by Simon Fraser
  • 16 edits in trunk/Source

2011-02-16 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Allow acceleratesDrawing for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54511

Plumb through preference for accelerated drawing.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences acceleratedDrawingEnabled]): (-[WebPreferences setAcceleratedDrawingEnabled:]):
  • WebView/WebPreferencesPrivate.h:

2011-02-16 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Allow acceleratesDrawing for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54511

Plumb through preference for accelerated drawing.

When accelerated drawing is enabled, set a flag on new GraphicsLayers.

Not testable via Layout Tests

  • WebCore.exp.in:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAcceleratedDrawingEnabled):
  • page/Settings.h: (WebCore::Settings::acceleratedDrawingEnabled):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking):

2011-02-16 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Allow acceleratesDrawing for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54511

Plumb through preference for accelerated drawing.

If accelerated drawing is enabled, keep the DrawingAreaImpl in
accelerated compositing mode.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetAcceleratedDrawingEnabled): (WKPreferencesGetAcceleratedDrawingEnabled):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::setRootCompositingLayer): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
8:44 PM Changeset in webkit [78787] by commit-queue@webkit.org
  • 7 edits in trunk/Source

2011-02-16 Victoria Kirst <vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix green pixels at edge of certain GPU-accelerated videos
https://bugs.webkit.org/show_bug.cgi?id=54559

Adds logic to properly resize the range of YUV textures to only
select legitimate values.

  • platform/graphics/chromium/VideoFrameChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::allocateTexturesIfNeeded): (WebCore::VideoLayerChromium::drawYUV):
  • platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::SharedValues::yWidthScaleFactorLocation): (WebCore::VideoLayerChromium::SharedValues::uvWidthScaleFactorLocation):

2011-02-16 Victoria Kirst <vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix green pixels at edge of certain GPU-accelerated videos
https://bugs.webkit.org/show_bug.cgi?id=54559

  • src/VideoFrameChromiumImpl.cpp: (WebKit::VideoFrameChromiumImpl::width): (WebKit::VideoFrameChromiumImpl::height): (WebKit::VideoFrameChromiumImpl::requiredTextureSize): (WebKit::VideoFrameChromiumImpl::hasPaddingBytes):
  • src/VideoFrameChromiumImpl.h:
8:39 PM Changeset in webkit [78786] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-02-16 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break on r78634
https://bugs.webkit.org/show_bug.cgi?id=54602

Build error because of r78634.

  • CMakeListsEfl.txt:
8:28 PM Changeset in webkit [78785] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-02-16 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] White screen is displayed when tiled backing store is enabled in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=54583

Make sure to invalidate all the tiles, including the last one.

  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::invalidate):
8:27 PM Changeset in webkit [78784] by yael.aharon@nokia.com
  • 3 edits in trunk/Tools

2011-02-16 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Enable tiled backing store by default in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=54581

Instead of a flag to turn it on, a new flag is defined to turn
tiled backing store off.

  • MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::handleUserOptions):
  • MiniBrowser/qt/MiniBrowserApplication.h: (WindowOptions::WindowOptions):
8:27 PM Changeset in webkit [78783] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-02-16 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Tiles are not created for webkit2 after r77286.
https://bugs.webkit.org/show_bug.cgi?id=54577

When using the default tile size of 1024x1024, only one tile is created.
Make sure to create this tile by undoing what seems to be a typo in r77286.

  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::paint): (WebKit::TiledDrawingAreaProxy::createTiles):
8:11 PM Changeset in webkit [78782] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

2011-02-16 Bill Budge <bbudge@chromium.org>

Reviewed by David Levin.

Need didReceiveCachedMetadata, and finishTime for didFinishLoading exposed in ThreadableLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=54313

No tests needed, exposes no new functionality

  • fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::didFinishLoading):
  • fileapi/FileReaderLoader.h:
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::setDefersLoading): (WebCore::DocumentThreadableLoader::didReceiveCachedMetadata): (WebCore::DocumentThreadableLoader::didFinishLoading): (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::didReceiveData): (WebCore::ThreadableLoaderClient::didReceiveCachedMetadata): (WebCore::ThreadableLoaderClient::didFinishLoading):
  • loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::didReceiveData): (WebCore::ThreadableLoaderClientWrapper::didReceiveCachedMetadata): (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
  • loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidReceiveCachedMetadata): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveCachedMetadata): (WebCore::workerContextDidFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
  • loader/WorkerThreadableLoader.h:
  • notifications/Notification.cpp: (WebCore::Notification::didFinishLoading):
  • notifications/Notification.h:
  • page/EventSource.cpp: (WebCore::EventSource::didFinishLoading):
  • page/EventSource.h:
  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::didFinishLoading):
  • workers/WorkerScriptLoader.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
  • xml/XMLHttpRequest.h:
8:03 PM Changeset in webkit [78781] by jorlow@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-16 Jeremy Orlow <jorlow@chromium.org>

Fix uninitialized memory error.

  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::close):
8:00 PM Changeset in webkit [78780] by abarth@webkit.org
  • 5 edits in trunk

2011-02-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix xssAuditor/form-action.html
https://bugs.webkit.org/show_bug.cgi?id=54590

Update expected results to show that we pass.

  • http/tests/security/xssAuditor/form-action-expected.txt:

2011-02-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix xssAuditor/form-action.html
https://bugs.webkit.org/show_bug.cgi?id=54590

We should block form actions. Although this technically can't be used
to run script, it's a pretty easy vector for stealing passwords.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterTokenInitial): (WebCore::XSSFilter::filterFormToken):
  • html/parser/XSSFilter.h:
7:48 PM Changeset in webkit [78779] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-02-16 Eric Seidel <eric@webkit.org>

Reviewed by Mihai Parparita.

flaky test archive uploads are always 22 bytes long
https://bugs.webkit.org/show_bug.cgi?id=54593

Speculative fix for the 22-bytes bug.

  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
7:41 PM Changeset in webkit [78778] by mihaip@chromium.org
  • 143 edits
    2 moves in trunk

2011-02-16 Anna Cavender <annacc@chromium.org>

Reviewed by Mihai Parparita.

http/tests/media should be served over HTTP (not from local file)
https://bugs.webkit.org/show_bug.cgi?id=54028

Removed special file:// treatment of http/tests/media
Moved media-file.js and video-tests.js to http/tests/media so local server can access them.
Update tests to point to new location of javascript libraries.

  • http/tests/media/media-file.js: Renamed from LayoutTests/media/media-file.js.
  • http/tests/media/pdf-served-as-pdf.html:
  • http/tests/media/reload-after-dialog.html:
  • http/tests/media/remove-while-loading.html:
  • http/tests/media/text-served-as-text.html:
  • http/tests/media/video-buffered.html:
  • http/tests/media/video-cancel-load.html:
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-error-abort.html:
  • http/tests/media/video-load-twice.html:
  • http/tests/media/video-play-stall-seek.html:
  • http/tests/media/video-play-stall.html:
  • http/tests/media/video-play-suspend.html:
  • http/tests/media/video-referer.html:
  • http/tests/media/video-seekable-stall.html:
  • http/tests/media/video-served-as-text.html:
  • http/tests/media/video-test.js: Renamed from LayoutTests/media/video-test.js.
  • media/adopt-node-crash.html:
  • media/audio-constructor-preload.html:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-controls-rendering.html:
  • media/audio-data-url.html:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • media/audio-delete-while-step-button-clicked.html:
  • media/audio-mpeg-supported.html:
  • media/audio-mpeg4-supported.html:
  • media/audio-play-event.html:
  • media/before-load-member-access.html:
  • media/broken-video.html:
  • media/constructors.html:
  • media/context-menu-actions.html:
  • media/controls-after-reload.html:
  • media/controls-css-overload.html:
  • media/controls-drag-timebar.html:
  • media/controls-right-click-on-timebar.html:
  • media/controls-strict.html:
  • media/controls-styling.html:
  • media/controls-without-preload.html:
  • media/event-attributes.html:
  • media/invalid-media-url-crash.html:
  • media/media-can-play-mpeg-audio.html:
  • media/media-can-play-mpeg4-video.html:
  • media/media-can-play-octet-stream.html:
  • media/media-can-play-ogg.html:
  • media/media-can-play-wav-audio.html:
  • media/media-captions.html:
  • media/media-constants.html:
  • media/media-fullscreen-inline.html:
  • media/media-fullscreen-not-in-document.html:
  • media/media-load-event.html:
  • media/media-startTime.html:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/restore-from-page-cache.html:
  • media/unsupported-rtsp.html:
  • media/unsupported-tracks.html:
  • media/video-append-source.html:
  • media/video-aspect-ratio.html:
  • media/video-autoplay.html:
  • media/video-buffered.html:
  • media/video-can-play-type.html:
  • media/video-canvas-alpha.html:
  • media/video-canvas-source.html:
  • media/video-canvas.html-disabled:
  • media/video-click-dblckick-standalone.html:
  • media/video-controls-rendering.html:
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-zoomed.html:
  • media/video-controls.html:
  • media/video-currentTime-delay.html:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-delay-load-event.html:
  • media/video-display-aspect-ratio.html:
  • media/video-display-none-crash.html:
  • media/video-display-toggle.html:
  • media/video-does-not-loop.html:
  • media/video-dom-autoplay.html:
  • media/video-dom-preload.html:
  • media/video-dom-src.html:
  • media/video-duration-known-after-eos.html:
  • media/video-error-does-not-exist.html:
  • media/video-frame-accurate-seek.html:
  • media/video-layer-crash.html:
  • media/video-load-networkState.html:
  • media/video-load-readyState.html:
  • media/video-loop.html:
  • media/video-muted.html:
  • media/video-no-audio.html:
  • media/video-no-autoplay.html:
  • media/video-pause-empty-events.html:
  • media/video-pause-immediately.html:
  • media/video-play-empty-events.html:
  • media/video-play-pause-events.html:
  • media/video-play-pause-exception.html:
  • media/video-played-collapse.html:
  • media/video-played-ranges-1.html:
  • media/video-played-reset.html:
  • media/video-poster-delayed.html:
  • media/video-poster-scale.html:
  • media/video-poster.html:
  • media/video-preload.html:
  • media/video-replaces-poster.html:
  • media/video-reverse-play-duration.html:
  • media/video-seek-by-small-increment.html:
  • media/video-seek-no-src-exception.html:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable.html:
  • media/video-seeking.html:
  • media/video-size-intrinsic-scale.html:
  • media/video-size.html:
  • media/video-source-error-no-candidate.html:
  • media/video-source-error.html:
  • media/video-source-inserted.html:
  • media/video-source-media.html:
  • media/video-source-moved.html:
  • media/video-source-none-supported.html:
  • media/video-source-removed.html:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-change.html:
  • media/video-src-invalid-remove.html:
  • media/video-src-none.html:
  • media/video-src-plus-source.html:
  • media/video-src-remove.html:
  • media/video-src-set.html:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-timeupdate-during-playback.html:
  • media/video-timeupdate-reverse-play.html:
  • media/video-transformed.html:
  • media/video-volume-slider.html:
  • media/video-volume.html:
  • media/video-width-height.html:
  • media/video-zoom-controls.html:
  • media/video-zoom.html:

2011-02-16 Anna Cavender <annacc@chromium.org>

Reviewed by Mihai Parparita.

http/tests/media should be served over HTTP (not from local file)
https://bugs.webkit.org/show_bug.cgi?id=54028

Removed special file:// treatment of http/tests/media

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/base.py:
7:39 PM Changeset in webkit [78777] by mihaip@chromium.org
  • 3 edits in trunk/Tools

2011-02-16 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

ChangeLog.parse_latest_entry_from_file does not handle rolled over ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=54609

r78737 rolled over ChangeLogs, and webkit-patch complains when landing
patches such as this one that are the first to add an entry to the
ChangeLog (since they don't see a second date line to know where the
entry ends).

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
7:05 PM Changeset in webkit [78776] by abarth@webkit.org
  • 2 edits
    25 adds in trunk/LayoutTests

2011-02-16 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Import XSSAuditor tests from David Ross
https://bugs.webkit.org/show_bug.cgi?id=54576

Many of these tests pass, but some of them fail as well. I'll fix the
failing tests in followup patches.

  • http/tests/security/xssAuditor/cookie-injection-expected.txt: Added.
  • http/tests/security/xssAuditor/cookie-injection.html: Added.
    • We're fine here.
  • http/tests/security/xssAuditor/form-action-expected.txt: Added.
  • http/tests/security/xssAuditor/form-action.html: Added.
    • We need to filter form actions. Previously, we considered this issue out of scope, but we should be able to handle it.
  • http/tests/security/xssAuditor/iframe-injection-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-injection.html: Added.
    • We need to filter iframe src attributes. Previously, we considered this issue out of scope, but we should be able to handle it.
  • http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-javascript-url-more-encoding.html: Added.
    • We're fine here.
  • http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-one-plus-one.html: Added.
    • We're fine here.
  • http/tests/security/xssAuditor/open-attribute-body-expected.txt: Added.
  • http/tests/security/xssAuditor/open-attribute-body.html: Added.
  • http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/open-event-handler-iframe.html: Added.
  • http/tests/security/xssAuditor/open-iframe-src-expected.txt: Added.
  • http/tests/security/xssAuditor/open-iframe-src.html: Added.
  • http/tests/security/xssAuditor/open-script-src-expected.txt: Added.
  • http/tests/security/xssAuditor/open-script-src.html: Added.
    • These are all the same class of issue. Now that we've re-designed the filter, we should be able to address this issue.
  • http/tests/security/xssAuditor/resources/echo-inspan.pl: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
    • Tests infrastructure improvements.
  • http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html: Added.
    • I'm not sure what's going on here. Requires futher investigation.
  • http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding.html: Added.
    • We're fine here.
  • http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-source-data-url.html: Added.
    • We're fine here.
7:02 PM Changeset in webkit [78775] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-16 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

Remove the early bail added in r75823 since we can run into anonymous
blocks when traversing the parents chain for clearing floats.
https://bugs.webkit.org/show_bug.cgi?id=54601

removeFloatingOrPositionedChildFromBlockLists tries to find the topmost
parent containing "this" block and then tries to remove it from its floats
list and mark all descendants blocks for layout. I added a bailout condition
in r75823 because we thought that if one of the parent render block does not
contain "this" float, then it is safe to assume that none of the grand parents
will have it. This is a wrong assumption since anonymous blocks do not have
float objects and we need to go higher in the chain to find the top most parent
containing this float. Instead of breaking out of the loop, it is ok to keep
traversing the chain till we find that parent. Otherwise, we will leave deleted
floats in the grand parents floats list.

Test: fast/block/float/floats-not-cleared-from-grand-parents.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

2011-02-16 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

Tests that we do not crash when floats are not cleared in cases where parents
chain has anonymous blocks.
https://bugs.webkit.org/show_bug.cgi?id=54601

  • fast/block/float/floats-not-cleared-from-grand-parents-expected.txt: Added.
  • fast/block/float/floats-not-cleared-from-grand-parents.html: Added.
6:54 PM Changeset in webkit [78774] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-02-16 James Robinson <jamesr@chromium.org>

Fix typo in chromium test_expectations - there is no WINDOWS (just WIN)

  • platform/chromium/test_expectations.txt:
6:52 PM Changeset in webkit [78773] by andreas.kling@nokia.com
  • 10 edits in trunk

2011-02-16 Andreas Kling <kling@webkit.org>

Reviewed by Ryosuke Niwa.

Editing styles should not emit #RRGGBBAA colors
https://bugs.webkit.org/show_bug.cgi?id=54540

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::extractTextStyles): Use Color::serialized() instead of Color::nameForRenderTreeAsText().

2011-02-16 Andreas Kling <kling@webkit.org>

Reviewed by Ryosuke Niwa.

Editing styles should not emit #RRGGBBAA colors
https://bugs.webkit.org/show_bug.cgi?id=54540

Added a test to editing/style/inline-style-container.html
that would cause invalid #RRGGBBAA output with the previous code.

  • editing/execCommand/delete-image-in-anchor-expected.txt:
  • editing/execCommand/script-tests/toggle-unlink.js:
  • editing/execCommand/toggle-unlink-expected.txt:
  • editing/style/fore-color-by-name-expected.txt:
  • editing/style/inline-style-container-expected.txt:
  • editing/style/script-tests/inline-style-container.js:
  • editing/style/style-text-node-without-editable-parent-expected.txt:
6:51 PM Changeset in webkit [78772] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-16 Martin Robinson <mrobinson@igalia.com>

Update the GTK+ skipped list. Skip some SVG tests that now expose rounding
errors. Unskip a test which should have been unskipped by r78614. Skip
Acid2 tests, as they are currently failing on GTK+.

  • platform/gtk/Skipped: Update the skipped list.
6:44 PM Changeset in webkit [78771] by jamesr@google.com
  • 11 edits
    1 add in trunk/LayoutTests

2011-02-16 James Robinson <jamesr@chromium.org>

Update chromium baselines for 78751.

  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-05-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Added.
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum:
  • platform/chromium-linux/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-05-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum:
  • platform/chromium-win/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/chromium/test_expectations.txt:
6:44 PM Changeset in webkit [78770] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebCore

Merge r78687.

6:39 PM Changeset in webkit [78769] by mrowe@apple.com
  • 16 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78676.

6:39 PM Changeset in webkit [78768] by mrowe@apple.com
  • 11 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78663.

6:38 PM Changeset in webkit [78767] by mrowe@apple.com
  • 14 edits
    1 copy
    1 add in branches/safari-534.20-branch/Source/WebKit2

Merge r78647.

6:38 PM Changeset in webkit [78766] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78638.

6:38 PM Changeset in webkit [78765] by mrowe@apple.com
  • 9 edits
    2 adds in branches/safari-534.20-branch/Source/WebKit2

Merge r78633.

6:37 PM Changeset in webkit [78764] by mrowe@apple.com
  • 3 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78611.

6:37 PM Changeset in webkit [78763] by mrowe@apple.com
  • 4 edits in branches/safari-534.20-branch/Source/WebCore

Merge r78604.

6:37 PM Changeset in webkit [78762] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78730.

6:32 PM Changeset in webkit [78761] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-02-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Improve showTree of Range, Position, and VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=54536

Enhanced showTree of Range, Position, and VisiblePosition.

  • dom/Position.cpp: (WebCore::Position::showAnchorTypeAndOffset): Added; dumps "legacy" if the position is a legacy position and also dumps anchor type. (WebCore::Position::showTreeForThis): Calls showAnchorTypeAndOffset.
  • dom/Position.h:
  • dom/Range.cpp: (showTree): No longer calls deprecatedEditingOffset.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::debugPosition): No longer included in release build. Calls Position::showAnchorTypeAndOffset instead of manually calling deprecatedEditingOffset.
  • editing/VisiblePosition.h:
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::debugPosition): Ditto. (WebCore::VisibleSelection::showTreeForThis): Ditto.
  • editing/VisibleSelection.h:
  • page/EventHandler.cpp:
6:32 PM Changeset in webkit [78760] by pkasting@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed, Chromium expectations update.

Removed duplicate expected results, update some test expectations.

  • platform/chromium-mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
6:28 PM Changeset in webkit [78759] by jorlow@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-16 David Grogan <dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

fix compile error introduced in 78752
https://bugs.webkit.org/show_bug.cgi?id=54604

  • storage/IDBRequest.h:
6:20 PM Changeset in webkit [78758] by jorlow@chromium.org
  • 11 edits in trunk/Source

2011-02-16 Jeremy Orlow <jorlow@chromium.org>

Back out IndexedDB change thats no longer necessary
https://bugs.webkit.org/show_bug.cgi?id=54603

Backing out 78645 as it turns out that it's not necessary.

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:

2011-02-16 Jeremy Orlow <jorlow@chromium.org>

Back out IndexedDB change thats no longer necessary
https://bugs.webkit.org/show_bug.cgi?id=54603

Backing out 78645 as it turns out that it's not necessary.

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • src/AssertMatchingEnums.cpp:
  • src/IDBFactoryBackendProxy.cpp:
  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
  • src/WebIDBFactoryImpl.h:
5:39 PM Changeset in webkit [78757] by mrowe@apple.com
  • 3 edits in branches/safari-534.20-branch/Source/WebCore

Merge r78616.

5:26 PM Changeset in webkit [78756] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2011-02-16 Kenneth Russell <kbr@google.com>

Unreviewed. Skip recently added tests for adjusting minimum timer
interval per page due to absence of
LayoutTestController.setMinimumTimerInterval.

  • platform/mac-wk2/Skipped:
5:20 PM Changeset in webkit [78755] by Martin Robinson
  • 2 edits
    228 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <mrobinson@igalia.com>

Add the next set of GTK+ baselines for the Mozilla tables test suite.

  • platform/gtk/Skipped: Unskip tests which now have results.
5:10 PM Changeset in webkit [78754] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-16 Brian Salomon <bsalomon@google.com>

Reviewed by James Robinson.

Skia's gpu backed just needs the correct context bound before drawing. It will bind the correct FBO itself and doing so externally confuses it unless resetContext is called.

No new tests required.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::syncSoftwareCanvas):
5:08 PM Changeset in webkit [78753] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-16 Mike Reed <reed@google.com>

Reviewed by Kenneth Russell.

Use non-asserting pack function for decoding images, since webgl may want
a non-premultiplied version of the image.
https://bugs.webkit.org/show_bug.cgi?id=54023

No new tests.
fast/canvas/webgl/gl-teximage.html
fast/canvas/webgl/tex-image-with-format-and-type.html
fast/canvas/webgl/texture-transparent-pixels-initialized.html

  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageFrame::setRGBA):
4:55 PM Changeset in webkit [78752] by jorlow@chromium.org
  • 26 edits
    5 copies
    5 adds in trunk

2011-02-16 David Grogan <dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

indexeddb: make setVersion fire blocked event if other connections are open
https://bugs.webkit.org/show_bug.cgi?id=53728

Tests: storage/indexeddb/set_version_blocked.html

storage/indexeddb/set_version_queue.html

  • WebCore.gypi:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Event.cpp: (WebCore::Event::isIDBVersionChangeEvent):
  • dom/Event.h:
  • dom/EventNames.h:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toIDBVersionChangeRequest):
  • dom/EventTarget.h:
  • storage/IDBCallbacks.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close):
  • storage/IDBDatabase.h:
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create): (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::version): (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::callbacks): (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::PendingSetVersionCall): (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::open): (WebCore::IDBDatabaseBackendImpl::close):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::onBlocked): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::source):
  • storage/IDBRequest.h:
  • storage/IDBVersionChangeEvent.cpp: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h. (WebCore::IDBVersionChangeEvent::create): (WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent): (WebCore::IDBVersionChangeEvent::~IDBVersionChangeEvent): (WebCore::IDBVersionChangeEvent::version):
  • storage/IDBVersionChangeEvent.h: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h. (WebCore::IDBVersionChangeEvent::isIDBVersionChangeEvent):
  • storage/IDBVersionChangeEvent.idl: Added.
  • storage/IDBVersionChangeRequest.cpp: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h. (WebCore::IDBVersionChangeRequest::create): (WebCore::IDBVersionChangeRequest::IDBVersionChangeRequest): (WebCore::IDBVersionChangeRequest::~IDBVersionChangeRequest): (WebCore::IDBVersionChangeRequest::onBlocked):
  • storage/IDBVersionChangeRequest.h: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
  • storage/IDBVersionChangeRequest.idl: Copied from Source/WebKit/chromium/src/WebIDBCallbacksImpl.h.
4:50 PM Changeset in webkit [78751] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-16 Robin Cao <robin.cao@torchmobile.com.cn>

Reviewed by James Robinson.

PlatformContextSkia::applyAntiAliasedClipPaths does not work for paths which have evenOdd property
https://bugs.webkit.org/show_bug.cgi?id=54336

We need to take fill type of paths into account when drawing them.

No new tests, covered by svg/W3C-SVG-1.1/masking-path-05-f.svg.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::applyAntiAliasedClipPaths):
4:50 PM Changeset in webkit [78750] by Martin Robinson
  • 2 edits
    225 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <mrobinson@igalia.com>

Add the next set of GTK+ Mozilla test suite results.

  • platform/gtk/Skipped: Unskip tests that now have results.
4:50 PM Changeset in webkit [78749] by joone.hur@collabora.co.uk
  • 4 edits in trunk/Source/WebKit/gtk

2011-02-16 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Match more various WebKit API enum values with WebCore enum values
https://bugs.webkit.org/show_bug.cgi?id=54352

AssertMatchingEnums.cpp was added to assert that various WebKit API enum values
continue matching WebCore defined enum values in the following changeset.
http://trac.webkit.org/changeset/77868
However, there are already enum values that have been asserted in other files,
so these assert macros defined need to be moved to AssertMatchingEnum.cpp.

  • WebCoreSupport/AssertMatchingEnums.cpp: Add more enum values to be asserted.
  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_class_init): Move the assert macros of WEBKIT_WEB_NAVIGATION_REASON_* to AssertMatchingEnums.cpp.
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): Move the assert macros of WEBKIT_EDITING_BEHAVIOR_* to AssertMatchingEnums.cpp.
4:35 PM Changeset in webkit [78748] by Martin Robinson
  • 2 edits
    225 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <mrobinson@igalia.com>

Add another group of GTK+ Mozilla test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
4:31 PM Changeset in webkit [78747] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2011-02-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION (r61234): washingtonpost.com top bar looks wrong, doesn't animate
https://bugs.webkit.org/show_bug.cgi?id=53717

  • http/tests/local/absolute-url-strip-whitespace-expected.txt: Added.
  • http/tests/local/absolute-url-strip-whitespace.html: Added.
  • http/tests/resources/absolute-url-strip-whitespace.js: Added.

2011-02-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION (r61234): washingtonpost.com top bar looks wrong, doesn't animate
https://bugs.webkit.org/show_bug.cgi?id=53717

Test: http/tests/local/absolute-url-strip-whitespace.html

This was theoretically tested already in fast/url, however the
tests were disabled due to lack of any clean way to test absolute
url parsing in JavaScript. I added a test which mimics the sites
behavior using our local http server. There seems to be no other
way to test this at the moment.

  • platform/KURL.cpp: (WebCore::shouldTrimFromURL):
    • Any char 0-20 should be removed (matches google-url and other browsers).

(WebCore::KURL::init):

4:24 PM Changeset in webkit [78746] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <mrobinson@igalia.com>

Add another batch of GTK+ Mozilla test suite results.

  • platform/gtk/Skipped: Unskip tests which now have results.
4:05 PM Changeset in webkit [78745] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <mrobinson@igalia.com>

Add another group of GTK+ Mozilla test suite baselines.

  • platform/gtk/Skipped: Unskip tests that now have baselines.
4:00 PM Changeset in webkit [78744] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-16 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

Tests that we do not crash when finding the text fragment for a first letter.
https://bugs.webkit.org/show_bug.cgi?id=54568

  • fast/css/first-letter-text-fragment-crash-expected.txt: Added.
  • fast/css/first-letter-text-fragment-crash.html: Added.

2011-02-16 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

Traverse the next sibling tree to find the text fragment for a first letter.
https://bugs.webkit.org/show_bug.cgi?id=54568

We cannot assume that the next sibling to the first letter will a text fragment
since there can be intermediatary Apple-style-span inline elements wrapping the
text fragment. So, we traverse the next sibling tree to find it.
Test: fast/css/first-letter-text-fragment-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
3:57 PM Changeset in webkit [78743] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-02-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] r78718 introduced some assertion failures in some HTTP tests
https://bugs.webkit.org/show_bug.cgi?id=54592

No new tests. This fix is covered by tests that are currently failing.

  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage): Instead of setting the existing headers and then selectively removing ones that do not exist in the updated soup message, just remove all headers from the map first.
3:54 PM Changeset in webkit [78742] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <mrobinson@igalia.com>

Add the next batch of GTK+ Mozilla test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
3:37 PM Changeset in webkit [78741] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-16 Martin Robinson <mrobinson@igalia.com>

Rebaseline media/controls-without-preload.html after r78695.

  • media/controls-without-preload-expected.txt: Rebaselined.
3:17 PM Changeset in webkit [78740] by pkasting@chromium.org
  • 2 edits
    8 adds in trunk/LayoutTests

Unreviewed, Chromium expectations update.

https://bugs.webkit.org/show_bug.cgi?id=54579
Add expectations for where V8 passes tests JSC doesn't, or merely has
different errors; mark other failing tests with a V8 tracking bug.

  • platform/chromium/fast/js/mozilla: Added.
  • platform/chromium/fast/js/mozilla/strict: Added.
  • platform/chromium/fast/js/mozilla/strict/11.1.5-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/12.14.1-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/13.1-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/15.3.4.5-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/15.3.5.2-expected.txt: Added.
  • platform/chromium/fast/js/mozilla/strict/regress-532254-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:08 PM Changeset in webkit [78739] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-16 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium-gpu expectations update. Add more tests that fail
because of bug 54409.

  • platform/chromium/test_expectations.txt:
2:46 PM Changeset in webkit [78738] by jianli@chromium.org
  • 5 edits in trunk

[V8] DataView constructor can be applied as a regular method
https://bugs.webkit.org/show_bug.cgi?id=54563

Reviewed by Kenneth Russell.

Source/WebCore:

Tested by adding a new test case to fast/canvas/webgl/data-view-test.html.

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):

LayoutTests:

Added a new test case.

  • fast/canvas/webgl/data-view-test-expected.txt:
  • fast/canvas/webgl/data-view-test.html:
2:30 PM Changeset in webkit [78737] by mrowe@apple.com
  • 7 edits
    7 copies in trunk

Roll over some ChangeLogs.

2:25 PM Changeset in webkit [78736] by Martin Robinson
  • 2 edits
    152 adds in trunk/LayoutTests

2011-02-16 Martin Robinson <mrobinson@igalia.com>

Begin adding GTK+ baselines for Mozilla test suites.

  • platform/gtk/Skipped: Unskip tests which now have results.
2:21 PM Changeset in webkit [78735] by jamesr@google.com
  • 3 edits in branches/chromium/648/Source/WebCore/dom

Fix compile on Chromium 648 branch

1:52 PM Changeset in webkit [78734] by pkasting@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

Remove a mac-leopard expectation since the Chromium Mac 10.5 bots at
least seem to be generating results that match the platform/mac images.

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/forms/select-empty-option-height-expected.checksum: Removed.
  • platform/mac-leopard/fast/forms/select-empty-option-height-expected.png: Removed.
1:48 PM Changeset in webkit [78733] by jamesr@google.com
  • 9 edits
    4 copies in branches/chromium/648

Merge 78648 - 2011-02-15 James Robinson <jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

requestAnimationFrame callbacks should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53188

Tests that requestAnimationFrame callbacks are suspended while a modal
dialog is showing.

  • fast/animation/request-animation-frame-during-modal-expected.txt: Added.
  • fast/animation/request-animation-frame-during-modal.html: Added.

2011-02-15 James Robinson <jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

requestAnimationFrame callbacks should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53188

requestAnimationFrame callbacks shouldn't fire while a modal dialog is up (like a window.alert()).
This matches Firefox and other async APIs. This patch moves the callback servicing into its own
controller class which receives notifications on suspend/resume.

Test: fast/animation/request-animation-frame-during-modal.html

  • WebCore.gypi:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setJavaScriptPaused):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::suspendScriptedAnimationControllerCallbacks): (WebCore::Document::resumeScriptedAnimationControllerCallbacks): (WebCore::Document::webkitRequestAnimationFrame): (WebCore::Document::webkitCancelRequestAnimationFrame): (WebCore::Document::serviceScriptedAnimations):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks): (WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks):
  • dom/ScriptedAnimationController.cpp: Added. (WebCore::ScriptedAnimationController::ScriptedAnimationController): (WebCore::ScriptedAnimationController::suspend): (WebCore::ScriptedAnimationController::resume): (WebCore::ScriptedAnimationController::registerCallback): (WebCore::ScriptedAnimationController::cancelCallback): (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
  • dom/ScriptedAnimationController.h: Added. (WebCore::ScriptedAnimationController::create):
  • history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): (WebCore::CachedFrame::CachedFrame):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/6537003

1:35 PM Changeset in webkit [78732] by barraclough@apple.com
  • 55 edits in trunk/Source

Bug 54524 - Allow JSObject to fully utilize cell's capacity for inline storage.

Reviewed by Geoff Garen.

Currently JSObject is both directly instantiated for regular JS objects, and
derived to implement subtypes. A consequence of this is that we need to ensure
that sufficient space from the cell is left unused and available for any data
members that will be introduced by subclasses of JSObject. By restructuring
the internal storage array out of JSObject we can increase the size in the
internal storage for regular objects.

Add classes JSFinalObject and JSNonFinalObject. JSNonFinalObject retains as
much additional capacity as is currently available to allow for data members
in subclasses. JSFinalObject utilizes all available space for internal storage,
and only allows construction through JSFinalObject::create().

Source/JavaScriptCore:

The additional storage made available in the JSObject means that we need no
longer rely on a union of the internal storage with a pointer to storage that
is only valid for external storage. This means we can go back to always having
a valid pointer to property storage, regardless of whether this is internal or
external. This simplifies some cases of access to the array from C code, and
significantly simplifies JIT access, since repatching no longer needs to be
able to change between a load of the storage pointer / a LEA of the internal
storage.

  • API/JSObjectRef.cpp:

(JSObjectMake):

  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::repatchPointer):

  • assembler/MIPSAssembler.h:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerARMv7.h:
  • assembler/MacroAssemblerMIPS.h:
  • assembler/MacroAssemblerX86.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/RepatchBuffer.h:
  • assembler/X86Assembler.h:
  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::DebuggerActivation):

  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve_global):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_resolve_global):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::emit_op_get_by_pname):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::emit_op_get_by_pname):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.h:

(JSC::Arguments::Arguments):

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • runtime/ErrorInstance.h:
  • runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::TerminatedExecutionError::TerminatedExecutionError):

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):

  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::JSByteArray):

  • runtime/JSByteArray.h:

(JSC::JSByteArray::JSByteArray):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalObject.h:

(JSC::constructEmptyObject):

  • runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::JSNotAnObject):

  • runtime/JSObject.cpp:

(JSC::JSObject::createInheritorID):
(JSC::JSObject::allocatePropertyStorage):

  • runtime/JSObject.h:

(JSC::JSObject::propertyStorage):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::createStructure):
(JSC::JSFinalObject::create):
(JSC::JSFinalObject::createStructure):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::offsetOfInlineStorage):
(JSC::constructEmptyObject):
(JSC::createEmptyObjectStructure):
(JSC::JSObject::JSObject):
(JSC::JSObject::~JSObject):
(JSC::Structure::isUsingInlineStorage):

  • runtime/JSObjectWithGlobalObject.cpp:

(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):

  • runtime/JSObjectWithGlobalObject.h:

(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):

  • runtime/JSTypeInfo.h:

(JSC::TypeInfo::TypeInfo):
(JSC::TypeInfo::isVanilla):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):

  • runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::JSWrapperObject):

  • runtime/ObjectConstructor.cpp:

(JSC::constructObject):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::ObjectPrototype):

  • runtime/ObjectPrototype.h:
  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::StrictEvalActivation):

  • runtime/StrictEvalActivation.h:
  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::growPropertyStorageCapacity):

Source/JavaScriptGlue:

  • UserObjectImp.cpp:
  • UserObjectImp.h:

Update JSObject -> JSNonFinalObject.

Source/WebCore:

  • bindings/js/JSDOMWindowShell.h:

Update JSObject -> JSNonFinalObject.

1:26 PM Changeset in webkit [78731] by oliver@apple.com
  • 1 edit
    196 adds in trunk/LayoutTests

2011-02-16 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Import some mozilla js strict mode regression tests
https://bugs.webkit.org/show_bug.cgi?id=54579

Add a bunch of the mozilla strict mode tests, the majority of the tests pass.
Those that fail fall into two categories

  • Tests for features we haven't implemented
  • Tests that test behaviour of arrays and arguments with non-writable properties
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-indirect-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-indirect-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-indirect-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-normalcaller-indirect-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-indirect-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-indirect-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-indirect-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-fun-strictcaller-indirect-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-direct-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-direct-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-direct-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-direct-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-indirect-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-indirect-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-indirect-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-normalcaller-indirect-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-direct-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-direct-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-direct-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-direct-strictcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-indirect-normalcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-indirect-normalcode.html: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-indirect-strictcode-expected.txt: Added.
  • fast/js/mozilla/eval/exhaustive-global-strictcaller-indirect-strictcode.html: Added.
  • fast/js/mozilla/eval/script-tests/TEMPLATE.html: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-normalcaller-direct-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-normalcaller-direct-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-normalcaller-indirect-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-normalcaller-indirect-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-strictcaller-direct-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-strictcaller-direct-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-strictcaller-indirect-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-fun-strictcaller-indirect-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-normalcaller-direct-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-normalcaller-direct-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-normalcaller-indirect-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-normalcaller-indirect-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-strictcaller-direct-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-strictcaller-direct-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-strictcaller-indirect-normalcode.js: Added.
  • fast/js/mozilla/eval/script-tests/exhaustive-global-strictcaller-indirect-strictcode.js: Added.
  • fast/js/mozilla/eval/script-tests/undeclared-name-in-nested-strict-eval.js: Added.
  • fast/js/mozilla/eval/undeclared-name-in-nested-strict-eval-expected.txt: Added.
  • fast/js/mozilla/eval/undeclared-name-in-nested-strict-eval.html: Added.
  • fast/js/mozilla/resources/js-test-post-async.js: Added.
  • fast/js/mozilla/resources/js-test-post-function.js: Added.
  • fast/js/mozilla/resources/js-test-post-n.js: Added.
  • fast/js/mozilla/resources/js-test-post.js: Added.
  • fast/js/mozilla/resources/js-test-pre.js: Added.
  • fast/js/mozilla/resources/js-test-style.css: Added.
  • fast/js/mozilla/resources/mozilla-es5-shell.js: Added.
  • fast/js/mozilla/resources/mozilla-shell.js: Added.
  • fast/js/mozilla/strict/10.4.2-expected.txt: Added.
  • fast/js/mozilla/strict/10.4.2.html: Added.
  • fast/js/mozilla/strict/10.4.3-expected.txt: Added.
  • fast/js/mozilla/strict/10.4.3.html: Added.
  • fast/js/mozilla/strict/10.6-expected.txt: Added.
  • fast/js/mozilla/strict/10.6.html: Added.
  • fast/js/mozilla/strict/11.1.5-expected.txt: Added.
  • fast/js/mozilla/strict/11.1.5.html: Added.
  • fast/js/mozilla/strict/11.13.1-expected.txt: Added.
  • fast/js/mozilla/strict/11.13.1.html: Added.
  • fast/js/mozilla/strict/11.13.2-expected.txt: Added.
  • fast/js/mozilla/strict/11.13.2.html: Added.
  • fast/js/mozilla/strict/11.3.1-expected.txt: Added.
  • fast/js/mozilla/strict/11.3.1.html: Added.
  • fast/js/mozilla/strict/11.3.2-expected.txt: Added.
  • fast/js/mozilla/strict/11.3.2.html: Added.
  • fast/js/mozilla/strict/11.4.1-expected.txt: Added.
  • fast/js/mozilla/strict/11.4.1.html: Added.
  • fast/js/mozilla/strict/11.4.4-expected.txt: Added.
  • fast/js/mozilla/strict/11.4.4.html: Added.
  • fast/js/mozilla/strict/11.4.5-expected.txt: Added.
  • fast/js/mozilla/strict/11.4.5.html: Added.
  • fast/js/mozilla/strict/12.10.1-expected.txt: Added.
  • fast/js/mozilla/strict/12.10.1.html: Added.
  • fast/js/mozilla/strict/12.14.1-expected.txt: Added.
  • fast/js/mozilla/strict/12.14.1.html: Added.
  • fast/js/mozilla/strict/12.2.1-expected.txt: Added.
  • fast/js/mozilla/strict/12.2.1.html: Added.
  • fast/js/mozilla/strict/13.1-expected.txt: Added.
  • fast/js/mozilla/strict/13.1.html: Added.
  • fast/js/mozilla/strict/15.10.7-expected.txt: Added.
  • fast/js/mozilla/strict/15.10.7.html: Added.
  • fast/js/mozilla/strict/15.3.4.5-expected.txt: Added.
  • fast/js/mozilla/strict/15.3.4.5.html: Added.
  • fast/js/mozilla/strict/15.3.5.1-expected.txt: Added.
  • fast/js/mozilla/strict/15.3.5.1.html: Added.
  • fast/js/mozilla/strict/15.3.5.2-expected.txt: Added.
  • fast/js/mozilla/strict/15.3.5.2.html: Added.
  • fast/js/mozilla/strict/15.4.4.12-expected.txt: Added.
  • fast/js/mozilla/strict/15.4.4.12.html: Added.
  • fast/js/mozilla/strict/15.4.4.13-expected.txt: Added.
  • fast/js/mozilla/strict/15.4.4.13.html: Added.
  • fast/js/mozilla/strict/15.4.4.6-expected.txt: Added.
  • fast/js/mozilla/strict/15.4.4.6.html: Added.
  • fast/js/mozilla/strict/15.4.4.8-expected.txt: Added.
  • fast/js/mozilla/strict/15.4.4.8.html: Added.
  • fast/js/mozilla/strict/15.4.4.9-expected.txt: Added.
  • fast/js/mozilla/strict/15.4.4.9.html: Added.
  • fast/js/mozilla/strict/15.4.5.1-expected.txt: Added.
  • fast/js/mozilla/strict/15.4.5.1.html: Added.
  • fast/js/mozilla/strict/15.5.5.1-expected.txt: Added.
  • fast/js/mozilla/strict/15.5.5.1.html: Added.
  • fast/js/mozilla/strict/15.5.5.2-expected.txt: Added.
  • fast/js/mozilla/strict/15.5.5.2.html: Added.
  • fast/js/mozilla/strict/8.12.5-expected.txt: Added.
  • fast/js/mozilla/strict/8.12.5.html: Added.
  • fast/js/mozilla/strict/8.12.7-expected.txt: Added.
  • fast/js/mozilla/strict/8.12.7.html: Added.
  • fast/js/mozilla/strict/8.7.2-expected.txt: Added.
  • fast/js/mozilla/strict/8.7.2.html: Added.
  • fast/js/mozilla/strict/B.1.1-expected.txt: Added.
  • fast/js/mozilla/strict/B.1.1.html: Added.
  • fast/js/mozilla/strict/B.1.2-expected.txt: Added.
  • fast/js/mozilla/strict/B.1.2.html: Added.
  • fast/js/mozilla/strict/assign-to-callee-name-expected.txt: Added.
  • fast/js/mozilla/strict/assign-to-callee-name.html: Added.
  • fast/js/mozilla/strict/directive-prologue-01-expected.txt: Added.
  • fast/js/mozilla/strict/directive-prologue-01.html: Added.
  • fast/js/mozilla/strict/eval-variable-environment-expected.txt: Added.
  • fast/js/mozilla/strict/eval-variable-environment.html: Added.
  • fast/js/mozilla/strict/function-name-arity-expected.txt: Added.
  • fast/js/mozilla/strict/function-name-arity.html: Added.
  • fast/js/mozilla/strict/primitive-this-no-writeback-expected.txt: Added.
  • fast/js/mozilla/strict/primitive-this-no-writeback.html: Added.
  • fast/js/mozilla/strict/regress-532041-expected.txt: Added.
  • fast/js/mozilla/strict/regress-532041.html: Added.
  • fast/js/mozilla/strict/regress-532254-expected.txt: Added.
  • fast/js/mozilla/strict/regress-532254.html: Added.
  • fast/js/mozilla/strict/regress-599159-expected.txt: Added.
  • fast/js/mozilla/strict/regress-599159.html: Added.
  • fast/js/mozilla/strict/script-tests/10.4.2.js: Added.
  • fast/js/mozilla/strict/script-tests/10.4.3.js: Added.
  • fast/js/mozilla/strict/script-tests/10.6.js: Added.
  • fast/js/mozilla/strict/script-tests/11.1.5.js: Added.
  • fast/js/mozilla/strict/script-tests/11.13.1.js: Added.
  • fast/js/mozilla/strict/script-tests/11.13.2.js: Added.
  • fast/js/mozilla/strict/script-tests/11.3.1.js: Added.
  • fast/js/mozilla/strict/script-tests/11.3.2.js: Added.
  • fast/js/mozilla/strict/script-tests/11.4.1.js: Added.
  • fast/js/mozilla/strict/script-tests/11.4.4.js: Added.
  • fast/js/mozilla/strict/script-tests/11.4.5.js: Added.
  • fast/js/mozilla/strict/script-tests/12.10.1.js: Added.
  • fast/js/mozilla/strict/script-tests/12.14.1.js: Added.
  • fast/js/mozilla/strict/script-tests/12.2.1.js: Added.
  • fast/js/mozilla/strict/script-tests/13.1.js: Added.
  • fast/js/mozilla/strict/script-tests/15.10.7.js: Added.
  • fast/js/mozilla/strict/script-tests/15.3.4.5.js: Added.
  • fast/js/mozilla/strict/script-tests/15.3.5.1.js: Added.
  • fast/js/mozilla/strict/script-tests/15.3.5.2.js: Added.
  • fast/js/mozilla/strict/script-tests/15.4.4.12.js: Added.
  • fast/js/mozilla/strict/script-tests/15.4.4.13.js: Added.
  • fast/js/mozilla/strict/script-tests/15.4.4.6.js: Added.
  • fast/js/mozilla/strict/script-tests/15.4.4.8.js: Added.
  • fast/js/mozilla/strict/script-tests/15.4.4.9.js: Added.
  • fast/js/mozilla/strict/script-tests/15.4.5.1.js: Added.
  • fast/js/mozilla/strict/script-tests/15.5.5.1.js: Added.
  • fast/js/mozilla/strict/script-tests/15.5.5.2.js: Added.
  • fast/js/mozilla/strict/script-tests/8.12.5.js: Added.
  • fast/js/mozilla/strict/script-tests/8.12.7.js: Added.
  • fast/js/mozilla/strict/script-tests/8.7.2.js: Added.
  • fast/js/mozilla/strict/script-tests/B.1.1.js: Added.
  • fast/js/mozilla/strict/script-tests/B.1.2.js: Added.
  • fast/js/mozilla/strict/script-tests/TEMPLATE.html: Added.
  • fast/js/mozilla/strict/script-tests/assign-to-callee-name.js: Added.
  • fast/js/mozilla/strict/script-tests/directive-prologue-01.js: Added.
  • fast/js/mozilla/strict/script-tests/eval-variable-environment.js: Added.
  • fast/js/mozilla/strict/script-tests/function-name-arity.js: Added.
  • fast/js/mozilla/strict/script-tests/primitive-this-no-writeback.js: Added.
  • fast/js/mozilla/strict/script-tests/regress-532041.js: Added.
  • fast/js/mozilla/strict/script-tests/regress-532254.js: Added.
  • fast/js/mozilla/strict/script-tests/regress-599159.js: Added.
  • fast/js/mozilla/strict/script-tests/strict-this-is-not-truthy.js: Added.
  • fast/js/mozilla/strict/script-tests/this-for-function-expression-recursion.js: Added.
  • fast/js/mozilla/strict/script-tests/unbrand-this.js: Added.
  • fast/js/mozilla/strict/strict-this-is-not-truthy-expected.txt: Added.
  • fast/js/mozilla/strict/strict-this-is-not-truthy.html: Added.
  • fast/js/mozilla/strict/this-for-function-expression-recursion-expected.txt: Added.
  • fast/js/mozilla/strict/this-for-function-expression-recursion.html: Added.
  • fast/js/mozilla/strict/unbrand-this-expected.txt: Added.
  • fast/js/mozilla/strict/unbrand-this.html: Added.
1:02 PM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
1:01 PM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
1:00 PM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
12:58 PM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
added compiler support libraries step (diff)
12:50 PM Changeset in webkit [78730] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-16 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Always disable the responsiveness timer when showing a popup menu
https://bugs.webkit.org/show_bug.cgi?id=54578
<rdar://problem/9009170>

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showPopupMenu):
12:38 PM Changeset in webkit [78729] by andersca@apple.com
  • 9 edits
    2 adds in trunk

2011-02-16 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Assertion failure in DrawingAreaImpl::display when calling WKPageForceRepaint on a page that uses accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=54575
<rdar://problem/8979594>

Add test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp: Added. (TestWebKitAPI::didForceRepaint): (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::TEST):
  • TestWebKitAPI/Tests/WebKit2/simple-accelerated-compositing.html: Added.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/copy-resources.cmd:

2011-02-16 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Assertion failure in DrawingAreaImpl::display when calling WKPageForceRepaint on a page that uses accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=54575
<rdar://problem/8979594>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::forceRepaint): If there is a layer tree host, ask it to force a repaint instead.
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::forceRepaint): Flush any layer changes, then flush and synchronize the current CA transaction.
12:01 PM Changeset in webkit [78728] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-16 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

REGRESSION: Use after free in WebCore::RenderCounter::destroyCounterNode
https://bugs.webkit.org/show_bug.cgi?id=54478

Test: fast/css/counters/render-tree-reorg-crash.html

  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Fixed typo. The code was still walking sometimes the renderer tree instead of the element tree as intended.

2011-02-16 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

REGRESSION: Use after free in WebCore::RenderCounter::destroyCounterNode
https://bugs.webkit.org/show_bug.cgi?id=54478

Added this test, to evidence a bug not previously caught by the
Layout tests.

  • fast/css/counters/render-tree-reorg-crash-expected.txt: Added.
  • fast/css/counters/render-tree-reorg-crash.html: Added.
11:31 AM Changeset in webkit [78727] by oliver@apple.com
  • 7 edits in trunk

2011-02-16 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff Garen.

Incorrect handling of global writes in dynamic contexts
https://bugs.webkit.org/show_bug.cgi?id=49383

Add a few tests to ensure that global writes are actually
allowed inside dynamic scopes.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:

2011-02-16 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff Garen.

Incorrect handling of global writes in dynamic contexts
https://bugs.webkit.org/show_bug.cgi?id=49383

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Can't use the existing callframe to return an uncaught exception as by definition that callframe has already been torn down.
  • parser/ASTBuilder.h: (JSC::ASTBuilder::ASTBuilder): (JSC::ASTBuilder::varDeclarations): (JSC::ASTBuilder::funcDeclarations): (JSC::ASTBuilder::features): (JSC::ASTBuilder::numConstants): (JSC::ASTBuilder::createFuncDeclStatement): (JSC::ASTBuilder::addVar): (JSC::ASTBuilder::incConstants): (JSC::ASTBuilder::usesThis): (JSC::ASTBuilder::usesCatch): (JSC::ASTBuilder::usesClosures): (JSC::ASTBuilder::usesArguments): (JSC::ASTBuilder::usesAssignment): (JSC::ASTBuilder::usesWith): (JSC::ASTBuilder::usesEval): Don't need a vector of scopes in the ASTBuilder
  • runtime/Operations.h: (JSC::resolveBase): In strict mode the optimisation that we use to skip a lookup on the global object is incorrect and lead to us always disallowing global writes when we needed to do a dynamic slot lookup. Now the strict mode path actually checks for the property.
11:13 AM Changeset in webkit [78726] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=54572
REGRESSION (WebKit2): Print Backgrounds checkbox has no effect for DOM initiated printing

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::preferencesDidChange): Preferences need to be propagated to Web process during synchronous printing.
10:48 AM Changeset in webkit [78725] by mnaganov@chromium.org
  • 4 adds in trunk/LayoutTests/platform/chromium-linux/svg

2011-02-16 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of SVG tests expectations for Linux after r78720.

LayoutTests/platform/chromium-linux/svg/custom/circular-marker-reference-2-expected.txt
LayoutTests/platform/chromium-linux/svg/custom/non-circular-marker-reference-expected.txt
LayoutTests/platform/chromium-linux/svg/custom/non-scaling-stroke-markers-expected.txt
LayoutTests/platform/chromium-linux/svg/hixie/links/001-expected.txt

10:41 AM Changeset in webkit [78724] by pkasting@chromium.org
  • 3 edits
    4 copies in branches/chromium/597

Merge 77724 - 2011-02-04 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250

This change adds a new script test that we can render a CMYK JPEG with a
color profile correctly, i.e. we can render it without color corruption.

  • fast/images/cmyk-jpeg-with-color-profile-expected.txt: Added.
  • fast/images/cmyk-jpeg-with-color-profile.html: Added.
  • fast/images/resources/cmyk-jpeg.jpg: Added.
  • fast/images/script-tests/cmyk-jpeg-with-color-profile.js: Added. (image.onload):

2011-02-04 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250

Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color
profiles from CMYK to RGB twice and it causes color corruption. This
change suppresses the color profiles for CMYK JPEGs same as gray-scale
ones.

Test: fast/images/cmyk-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6529057

10:33 AM Changeset in webkit [78723] by mnaganov@chromium.org
  • 1 edit
    14 adds in trunk/LayoutTests/platform

2011-02-16 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of SVG tests expectations for Mac.

10:20 AM Changeset in webkit [78722] by Nikolas Zimmermann
  • 21 edits in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Pixel tests differences on 10.6.6 32bit vs. 64bit
https://bugs.webkit.org/show_bug.cgi?id=54474

Update gtk baseline using the 64bit debug bot - maybe we have another rounding problem on gtk. Let's see.

  • platform/gtk/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
  • platform/gtk/svg/custom/circular-marker-reference-1-expected.txt:
  • platform/gtk/svg/custom/circular-marker-reference-3-expected.txt:
  • platform/gtk/svg/custom/circular-marker-reference-4-expected.txt:
  • platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt:
  • platform/gtk/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/gtk/svg/custom/stroked-pattern-expected.txt:
  • platform/gtk/svg/custom/text-rotated-gradient-expected.txt:
  • platform/gtk/svg/custom/use-css-events-expected.txt:
  • platform/gtk/svg/custom/use-detach-expected.txt:
  • platform/gtk/svg/filters/filterRes-expected.txt:
  • platform/gtk/svg/hixie/links/001-expected.txt:
  • platform/gtk/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/gtk/svg/text/small-fonts-2-expected.txt:
  • platform/gtk/svg/text/text-align-04-b-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
10:13 AM Changeset in webkit [78721] by hans@chromium.org
  • 18 edits in trunk

2011-02-16 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Inject auto increment keys via key path on insertion
https://bugs.webkit.org/show_bug.cgi?id=54457

Prepare to test injection of auto increment key. Keep it commented out
until implemented Chromium-side.

  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:

2011-02-16 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Inject auto increment keys via key path on insertion
https://bugs.webkit.org/show_bug.cgi?id=54457

Inject auto increment keys via key path for object stores using key
path and auto increment.

  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::LocalContext::getNthValueOnKeyPath): (WebCore::createIDBKeyFromSerializedValueAndKeyPath): (WebCore::injectIDBKeyIntoSerializedValue):
  • bindings/v8/IDBBindingUtilities.h:
  • platform/chromium/PlatformBridge.h:
  • storage/IDBKeyPathBackendImpl.cpp: (IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):
  • storage/IDBKeyPathBackendImpl.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::injectKeyIntoKeyPath): (WebCore::IDBObjectStoreBackendImpl::selectKeyForPut): (WebCore::IDBObjectStoreBackendImpl::putInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/chromium/IDBKeyPathBackendImpl.cpp: (WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):

2011-02-16 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Inject auto increment keys via key path on insertion
https://bugs.webkit.org/show_bug.cgi?id=54457

Support for injecting keys into objects via key path.

  • public/WebIDBKey.h:
  • public/WebKitClient.h: (WebKit::WebKitClient::injectIDBKeyIntoSerializedValue):
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::injectIDBKeyIntoSerializedValue):
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::injectIDBKeyIntoSerializedValue):
  • tests/IDBBindingUtilitiesTest.cpp: (WebCore::injectKey): (WebCore::checkInjection): (WebCore::checkInjectionFails): (WebCore::TEST):
9:59 AM Changeset in webkit [78720] by Nikolas Zimmermann
  • 12 edits
    12 adds in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Pixel tests differences on 10.6.6 32bit vs. 64bit
https://bugs.webkit.org/show_bug.cgi?id=54474

Update mac-leopard/win baselines. I rebaselined the wrong platforms in my last commit.

  • platform/mac-leopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
  • platform/mac-leopard/svg/custom/circular-marker-reference-2-expected.txt:
  • platform/mac-leopard/svg/custom/non-circular-marker-reference-expected.txt:
  • platform/mac-leopard/svg/custom/non-scaling-stroke-markers-expected.txt:
  • platform/mac-leopard/svg/custom/stroked-pattern-expected.txt:
  • platform/mac-leopard/svg/custom/text-rotated-gradient-expected.txt:
  • platform/mac-leopard/svg/custom/use-detach-expected.txt:
  • platform/mac-leopard/svg/hixie/links/001-expected.txt:
  • platform/mac-leopard/svg/text/small-fonts-2-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Added.
  • platform/win/svg/custom/circular-marker-reference-2-expected.txt: Added.
  • platform/win/svg/custom/non-circular-marker-reference-expected.txt: Added.
  • platform/win/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
  • platform/win/svg/custom/stroked-pattern-expected.txt: Added.
  • platform/win/svg/custom/text-rotated-gradient-expected.txt: Added.
  • platform/win/svg/custom/use-detach-expected.txt: Added.
  • platform/win/svg/hixie/links: Added.
  • platform/win/svg/hixie/links/001-expected.txt: Added.
  • platform/win/svg/text/small-fonts-2-expected.txt: Added.
9:48 AM Changeset in webkit [78719] by mnaganov@chromium.org
  • 9 adds in trunk/LayoutTests/platform/chromium-win-xp/svg

2011-02-16 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of SVG tests expectations for Windows.

9:47 AM Changeset in webkit [78718] by sergio@webkit.org
  • 6 edits in trunk

2011-02-16 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Add support for layoutTestController.setWillSendRequestClearHeader
https://bugs.webkit.org/show_bug.cgi?id=54537

Unskipped http/tests/security/no-referrer.html.

  • platform/gtk/Skipped:

2011-02-16 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Add support for layoutTestController.setWillSendRequestClearHeader
https://bugs.webkit.org/show_bug.cgi?id=54537

Headers removed from the SoupMessage should be also removed from
the ResourceRequest when updating the latter from the former.

  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):

2011-02-16 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Add support for layoutTestController.setWillSendRequestClearHeader
https://bugs.webkit.org/show_bug.cgi?id=54537

Added handler for resource-request-starting emitted in
FrameLoader's willSendRequest(). The current implementation
removes the headers set in setWillSendRequestClearHeader.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (willSendRequestCallback): (createWebView):
9:17 AM Changeset in webkit [78717] by loislo@chromium.org
  • 50 edits in trunk

2011-02-16 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: split all the functions of Inspector backend API by domain.
https://bugs.webkit.org/show_bug.cgi?id=54558

We have a number of functions from different domains in single instance of InspectorBackend.
It'd be better to split the functions by their domains.
As example 'evaluate' will be moved from InspectorBackend to RuntimeAgent container.

  • http/tests/inspector/console-xhr-logging.html:
  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.completeTest): (initialize_InspectorTest.InspectorTest.evaluateInPage): (initialize_InspectorTest.InspectorTest.reloadPage):
  • inspector/console/console-dir-global.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger/debugger-pause-on-exception.html:
  • inspector/elements/elements-panel-search.html:
  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
  • inspector/report-protocol-errors.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.performActionsAndPrint.step2):
  • inspector/timeline/timeline-trivial.html:

2011-02-16 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: split all the functions of Inspector backend API by domain.
https://bugs.webkit.org/show_bug.cgi?id=54558

We have a number of functions from different domains in single instance of InspectorBackend.
It'd be better to split the functions by their domains.
As example 'evaluate' will be moved from InspectorBackend to RuntimeAgent container.

  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.DOMBreakpoint.prototype._enable): (WebInspector.DOMBreakpoint.prototype._disable): (WebInspector.EventListenerBreakpoint.prototype._enable): (WebInspector.EventListenerBreakpoint.prototype._disable): (WebInspector.XHRBreakpoint.prototype._enable): (WebInspector.XHRBreakpoint.prototype._disable):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule.callback): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet.createForId): (WebInspector.CSSStyleSheet.prototype.setText):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent): (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._deleteCookie):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype.setAttributeAsync): (WebInspector.DOMAgent.prototype.removeAttributeAsync): (WebInspector.DOMAgent.prototype.setTextNodeValueAsync): (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync): (WebInspector.Cookies.getCookiesAsync): (WebInspector.EventListeners.getEventListenersForNodeAsync):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.prototype.getEntries): (WebInspector.DOMStorage.prototype.setItem): (WebInspector.DOMStorage.prototype.removeItem):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.getTableNames): (WebInspector.Database.prototype.executeSql):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.enableDebugger): (WebInspector.DebuggerModel.prototype.disableDebugger): (WebInspector.DebuggerModel.prototype.continueToLocation): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype.editScriptSource):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.setDocument): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype.handleCopyEvent): (WebInspector.ElementsPanel.prototype.setSearchingForNode):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted): ():
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionWatchSidebarPane.prototype.setExpression):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onAddRequestHeaders): (WebInspector.ExtensionServer.prototype._onReload): (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.reset): (WebInspector.NetworkManager.prototype.requestContent):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView): (WebInspector.CPUProfileType.prototype.buttonClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._clearProfiles): (WebInspector.ProfilesPanel.prototype._removeProfileHeader): (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype._toggleProfiling): (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.resolveNode): (WebInspector.RemoteObject.prototype.getProperties): (WebInspector.RemoteObject.prototype.setPropertyValue): (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameTreeElement.prototype.set hovered): (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
  • inspector/front-end/Script.js: (WebInspector.Script.prototype.requestSource):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions): (WebInspector.ScriptsPanel.prototype._togglePause): (WebInspector.ScriptsPanel.prototype._stepOverClicked): (WebInspector.ScriptsPanel.prototype._stepIntoClicked): (WebInspector.ScriptsPanel.prototype._stepOutClicked): (WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._hidePopup):
  • inspector/front-end/TestController.js: (WebInspector.TestController.prototype.notifyDone):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
  • inspector/front-end/inspector.js: (WebInspector.highlightDOMNode): (WebInspector.doLoadedDone): (WebInspector.openResource): (WebInspector.documentKeyDown):
9:14 AM Changeset in webkit [78716] by Nikolas Zimmermann
  • 10 edits
    13 adds in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Pixel tests differences on 10.6.6 32bit vs. 64bit
https://bugs.webkit.org/show_bug.cgi?id=54474

Update gtk/win/mac-leopard baselines.

  • platform/gtk/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/gtk/svg/custom/use-css-events-expected.txt:
  • platform/gtk/svg/filters/filterRes-expected.txt:
  • platform/gtk/svg/text/text-align-04-b-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Added.
  • platform/mac-leopard/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac-leopard/svg/custom/circular-marker-reference-2-expected.txt: Added.
  • platform/mac-leopard/svg/custom/non-circular-marker-reference-expected.txt: Added.
  • platform/mac-leopard/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
  • platform/mac-leopard/svg/custom/stroked-pattern-expected.txt: Added.
  • platform/mac-leopard/svg/custom/text-rotated-gradient-expected.txt: Added.
  • platform/mac-leopard/svg/custom/use-detach-expected.txt: Added.
  • platform/mac-leopard/svg/hixie/links/001-expected.txt: Added.
  • platform/mac-leopard/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/mac-leopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/win/svg/batik/masking/maskRegions-expected.txt:
  • platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
9:12 AM Changeset in webkit [78715] by mario@webkit.org
  • 5 edits
    2 adds in trunk

2011-02-16 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831

Added new layout test to check the right signals are emitted.

  • platform/gtk/accessibility/document-reload-events-expected.txt: Added.
  • platform/gtk/accessibility/document-reload-events.html: Added.

2011-02-16 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831

Make sure webArea returns a proper name and that a signal
'state-change::defunct' is emitted when detaching the wrapper.

Test: platform/gtk/accessibility/document-reload-events.html

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): Returns the current document's title as fallback mechanism for webArea objects. (webkit_accessible_detach): Emit 'state-change::defunct' function as soon as the wrapper is detached from the related core object.

2011-02-16 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831

Emit the right signals when reloading a document.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyAccessibilityStatus): New function, to make sure the signals involved in reloading a document are properly emitted. (WebKit::notifyStatus): Also notify accessibility if enabled.
8:58 AM Changeset in webkit [78714] by Nikolas Zimmermann
  • 143 edits in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Pixel tests differences on 10.6.6 32bit vs. 64bit
https://bugs.webkit.org/show_bug.cgi?id=54474

Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
This is the fifth and last chunk.

It should pass on modern 64bit machines as well, using tolerance 0.01.

  • platform/mac/svg/filters/feOffset-expected.checksum:
  • platform/mac/svg/filters/feOffset-expected.png:
  • platform/mac/svg/filters/filter-clip-expected.checksum:
  • platform/mac/svg/filters/filter-clip-expected.png:
  • platform/mac/svg/filters/filterRes-expected.checksum:
  • platform/mac/svg/filters/filterRes-expected.png:
  • platform/mac/svg/hixie/cascade/002-expected.checksum:
  • platform/mac/svg/hixie/cascade/002-expected.png:
  • platform/mac/svg/hixie/error/017-expected.checksum:
  • platform/mac/svg/hixie/error/017-expected.png:
  • platform/mac/svg/hixie/links/003-broken-expected.checksum:
  • platform/mac/svg/hixie/links/003-broken-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.checksum:
  • platform/mac/svg/hixie/mixed/003-expected.png:
  • platform/mac/svg/hixie/mixed/004-expected.checksum:
  • platform/mac/svg/hixie/mixed/004-expected.png:
  • platform/mac/svg/hixie/mixed/005-expected.checksum:
  • platform/mac/svg/hixie/mixed/005-expected.png:
  • platform/mac/svg/hixie/mixed/006-expected.checksum:
  • platform/mac/svg/hixie/mixed/006-expected.png:
  • platform/mac/svg/hixie/mixed/008-expected.checksum:
  • platform/mac/svg/hixie/mixed/008-expected.png:
  • platform/mac/svg/hixie/mixed/011-expected.checksum:
  • platform/mac/svg/hixie/mixed/011-expected.png:
  • platform/mac/svg/hixie/perf/001-expected.checksum:
  • platform/mac/svg/hixie/perf/001-expected.png:
  • platform/mac/svg/hixie/perf/002-expected.checksum:
  • platform/mac/svg/hixie/perf/002-expected.png:
  • platform/mac/svg/hixie/perf/007-expected.checksum:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/hixie/transform/001-expected.checksum:
  • platform/mac/svg/hixie/transform/001-expected.png:
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.checksum:
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
  • platform/mac/svg/text/font-size-below-point-five-2-expected.checksum:
  • platform/mac/svg/text/font-size-below-point-five-2-expected.png:
  • platform/mac/svg/text/scaled-font-expected.checksum:
  • platform/mac/svg/text/scaled-font-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/mac/svg/text/select-x-list-3-expected.checksum:
  • platform/mac/svg/text/select-x-list-3-expected.png:
  • platform/mac/svg/text/selection-background-color-expected.checksum:
  • platform/mac/svg/text/selection-background-color-expected.png:
  • platform/mac/svg/text/selection-styles-expected.checksum:
  • platform/mac/svg/text/selection-styles-expected.png:
  • platform/mac/svg/text/small-fonts-2-expected.checksum:
  • platform/mac/svg/text/small-fonts-2-expected.png:
  • platform/mac/svg/text/small-fonts-3-expected.checksum:
  • platform/mac/svg/text/small-fonts-3-expected.png:
  • platform/mac/svg/text/small-fonts-expected.checksum:
  • platform/mac/svg/text/small-fonts-expected.png:
  • platform/mac/svg/text/small-fonts-in-html5-expected.checksum:
  • platform/mac/svg/text/small-fonts-in-html5-expected.png:
  • platform/mac/svg/text/text-align-01-b-expected.checksum:
  • platform/mac/svg/text/text-align-01-b-expected.png:
  • platform/mac/svg/text/text-align-02-b-expected.checksum:
  • platform/mac/svg/text/text-align-02-b-expected.png:
  • platform/mac/svg/text/text-align-03-b-expected.checksum:
  • platform/mac/svg/text/text-align-03-b-expected.png:
  • platform/mac/svg/text/text-align-04-b-expected.checksum:
  • platform/mac/svg/text/text-align-04-b-expected.png:
  • platform/mac/svg/text/text-align-05-b-expected.checksum:
  • platform/mac/svg/text/text-align-05-b-expected.png:
  • platform/mac/svg/text/text-align-06-b-expected.checksum:
  • platform/mac/svg/text/text-align-06-b-expected.png:
  • platform/mac/svg/text/text-altglyph-01-b-expected.checksum:
  • platform/mac/svg/text/text-altglyph-01-b-expected.png:
  • platform/mac/svg/text/text-deco-01-b-expected.checksum:
  • platform/mac/svg/text/text-deco-01-b-expected.png:
  • platform/mac/svg/text/text-fonts-01-t-expected.checksum:
  • platform/mac/svg/text/text-fonts-01-t-expected.png:
  • platform/mac/svg/text/text-fonts-02-t-expected.checksum:
  • platform/mac/svg/text/text-fonts-02-t-expected.png:
  • platform/mac/svg/text/text-intro-05-t-expected.checksum:
  • platform/mac/svg/text/text-intro-05-t-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.checksum:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-text-01-b-expected.checksum:
  • platform/mac/svg/text/text-text-01-b-expected.png:
  • platform/mac/svg/text/text-text-03-b-expected.checksum:
  • platform/mac/svg/text/text-text-03-b-expected.png:
  • platform/mac/svg/text/text-text-04-t-expected.checksum:
  • platform/mac/svg/text/text-text-04-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.checksum:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-06-t-expected.checksum:
  • platform/mac/svg/text/text-text-06-t-expected.png:
  • platform/mac/svg/text/text-text-07-t-expected.checksum:
  • platform/mac/svg/text/text-text-07-t-expected.png:
  • platform/mac/svg/text/text-text-08-b-expected.checksum:
  • platform/mac/svg/text/text-text-08-b-expected.png:
  • platform/mac/svg/text/text-tselect-01-b-expected.checksum:
  • platform/mac/svg/text/text-tselect-01-b-expected.png:
  • platform/mac/svg/text/text-tselect-02-f-expected.checksum:
  • platform/mac/svg/text/text-tselect-02-f-expected.png:
  • platform/mac/svg/text/text-tspan-01-b-expected.checksum:
  • platform/mac/svg/text/text-tspan-01-b-expected.png:
  • platform/mac/svg/text/text-ws-01-t-expected.checksum:
  • platform/mac/svg/text/text-ws-01-t-expected.png:
  • platform/mac/svg/text/text-ws-02-t-expected.checksum:
  • platform/mac/svg/text/text-ws-02-t-expected.png:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.checksum:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.checksum:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.checksum:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
8:58 AM Changeset in webkit [78713] by Nikolas Zimmermann
  • 1 edit in trunk/Source/WebCore/ChangeLog

Oops forgot to land the ChangeLog for r78704.

8:43 AM Changeset in webkit [78712] by mnaganov@chromium.org
  • 29 edits
    74 adds in trunk/LayoutTests/platform

2011-02-16 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of SVG tests expectations.

8:41 AM Changeset in webkit [78711] by Nikolas Zimmermann
  • 137 edits in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Pixel tests differences on 10.6.6 32bit vs. 64bit
https://bugs.webkit.org/show_bug.cgi?id=54474

Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
This is the fourth chunk.

It should pass on modern 64bit machines as well, using tolerance 0.01.

  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
8:37 AM Changeset in webkit [78710] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Merge branch 'bug/54552' into staging

8:32 AM Changeset in webkit [78709] by Csaba Osztrogonác
  • 6 edits in trunk/LayoutTests

Unreviewed.

Update Qt specific expected files.

  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.checksum:
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.png:
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.txt:
  • platform/qt/svg/custom/text-rotated-gradient-expected.txt:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
7:48 AM Changeset in webkit [78708] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Qt build system can't handle removing headers from tree
https://bugs.webkit.org/show_bug.cgi?id=54466

Reviewed by Andreas Kling.

  • Scripts/build-webkit: Remove Qt makefiles from productDir before build.
7:26 AM Changeset in webkit [78707] by Nikolas Zimmermann
  • 139 edits in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Pixel tests differences on 10.6.6 32bit vs. 64bit
https://bugs.webkit.org/show_bug.cgi?id=54474

Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
This is the third chunk.

It should pass on modern 64bit machines as well, using tolerance 0.01.

  • platform/mac/svg/clip-path/clip-in-mask-expected.checksum:
  • platform/mac/svg/clip-path/clip-in-mask-expected.png:
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-clipped-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-g-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-g-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.checksum:
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.checksum:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.checksum:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.checksum:
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/mac/svg/custom/animate-path-discrete-expected.checksum:
  • platform/mac/svg/custom/animate-path-discrete-expected.png:
  • platform/mac/svg/custom/convolution-crash-expected.checksum:
  • platform/mac/svg/custom/convolution-crash-expected.png:
  • platform/mac/svg/custom/createImageElement2-expected.checksum:
  • platform/mac/svg/custom/createImageElement2-expected.png:
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.checksum:
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.checksum:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.checksum:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.checksum:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.checksum:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac/svg/custom/focus-ring-expected.checksum:
  • platform/mac/svg/custom/focus-ring-expected.png:
  • platform/mac/svg/custom/foreign-object-skew-expected.checksum:
  • platform/mac/svg/custom/foreign-object-skew-expected.png:
  • platform/mac/svg/custom/glyph-transformation-with-hkern-expected.checksum:
  • platform/mac/svg/custom/glyph-transformation-with-hkern-expected.png:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.checksum:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/mac/svg/custom/gradient-stroke-width-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/custom/invalid-css-expected.checksum:
  • platform/mac/svg/custom/invalid-css-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-clipPath-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-gradient-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/mac/svg/custom/marker-default-width-height-expected.checksum:
  • platform/mac/svg/custom/marker-default-width-height-expected.png:
  • platform/mac/svg/custom/marker-opacity-expected.checksum:
  • platform/mac/svg/custom/marker-opacity-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/mac/svg/custom/non-scaling-stroke-expected.checksum:
  • platform/mac/svg/custom/non-scaling-stroke-expected.png:
  • platform/mac/svg/custom/pattern-skew-transformed-expected.checksum:
  • platform/mac/svg/custom/pattern-skew-transformed-expected.png:
  • platform/mac/svg/custom/pattern-with-transformation-expected.checksum:
  • platform/mac/svg/custom/pattern-with-transformation-expected.png:
  • platform/mac/svg/custom/pointer-events-image-expected.checksum:
  • platform/mac/svg/custom/pointer-events-image-expected.png:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.checksum:
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.checksum:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.png:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.checksum:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.png:
  • platform/mac/svg/custom/stroked-pattern-expected.checksum:
  • platform/mac/svg/custom/stroked-pattern-expected.png:
  • platform/mac/svg/custom/struct-use-09-b-expected.checksum:
  • platform/mac/svg/custom/struct-use-09-b-expected.png:
  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/mac/svg/custom/text-rotated-gradient-expected.checksum:
  • platform/mac/svg/custom/text-rotated-gradient-expected.png:
  • platform/mac/svg/custom/tref-update-expected.checksum:
  • platform/mac/svg/custom/tref-update-expected.png:
  • platform/mac/svg/custom/use-css-events-expected.checksum:
  • platform/mac/svg/custom/use-css-events-expected.png:
  • platform/mac/svg/custom/use-detach-expected.checksum:
  • platform/mac/svg/custom/use-detach-expected.png:
  • platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.checksum:
  • platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.png:
  • platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
  • platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/mac/svg/custom/width-full-percentage-expected.checksum:
  • platform/mac/svg/custom/width-full-percentage-expected.png:
7:23 AM Changeset in webkit [78706] by Nikolas Zimmermann
  • 47 edits in trunk/LayoutTests

2011-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Pixel tests differences on 10.6.6 32bit vs. 64bit
https://bugs.webkit.org/show_bug.cgi?id=54474

Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
This is the second chunk.

It should pass on modern 64bit machines as well, using tolerance 0.01.

  • platform/mac/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/batik/text/smallFonts-expected.checksum:
  • platform/mac/svg/batik/text/smallFonts-expected.png:
  • platform/mac/svg/batik/text/textAnchor-expected.checksum:
  • platform/mac/svg/batik/text/textAnchor-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textFeatures-expected.checksum:
  • platform/mac/svg/batik/text/textFeatures-expected.png:
  • platform/mac/svg/batik/text/textOnPath2-expected.checksum:
  • platform/mac/svg/batik/text/textOnPath2-expected.png:
  • platform/mac/svg/batik/text/textOnPath3-expected.checksum:
  • platform/mac/svg/batik/text/textOnPath3-expected.png:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.checksum:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/mac/svg/carto.net/button-expected.checksum:
  • platform/mac/svg/carto.net/button-expected.png:
  • platform/mac/svg/carto.net/colourpicker-expected.checksum:
  • platform/mac/svg/carto.net/colourpicker-expected.png:
  • platform/mac/svg/carto.net/combobox-expected.checksum:
  • platform/mac/svg/carto.net/combobox-expected.png:
  • platform/mac/svg/carto.net/scrollbar-expected.checksum:
  • platform/mac/svg/carto.net/scrollbar-expected.png:
  • platform/mac/svg/carto.net/selectionlist-expected.checksum:
  • platform/mac/svg/carto.net/selectionlist-expected.png:
  • platform/mac/svg/carto.net/slider-expected.checksum:
  • platform/mac/svg/carto.net/slider-expected.png:
  • platform/mac/svg/carto.net/textbox-expected.checksum:
  • platform/mac/svg/carto.net/textbox-expected.png:
  • platform/mac/svg/carto.net/window-expected.checksum:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/css/composite-shadow-example-expected.checksum:
  • platform/mac/svg/css/composite-shadow-example-expected.png:
  • platform/mac/svg/css/composite-shadow-text-expected.checksum:
  • platform/mac/svg/css/composite-shadow-text-expected.png:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/group-with-shadow-expected.checksum:
  • platform/mac/svg/css/group-with-shadow-expected.png:
  • platform/mac/svg/dom/SVGTransformList-basics-expected.checksum:
  • platform/mac/svg/dom/SVGTransformList-basics-expected.png:
  • svg/batik/masking/maskRegions.svg:
  • svg/zoom/page/zoom-mask-with-percentages.svg:
7:18 AM Changeset in webkit [78705] by mnaganov@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-02-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r78678.
http://trac.webkit.org/changeset/78678
https://bugs.webkit.org/show_bug.cgi?id=54554

Breaks NaCl tests in Chromium (Requested by mnaganov on
#webkit).

  • src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
  • src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
  • src/WebURLResponsePrivate.h:
7:11 AM Changeset in webkit [78704] by Nikolas Zimmermann
  • 128 edits in trunk

2011-02-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Pixel tests differences on 10.6.6 32bit vs. 64bit
https://bugs.webkit.org/show_bug.cgi?id=54474

When generating a SVG pixel test baseline with a vanilla 10.6.6 installation on a 32bit machine (Core Duo MBP)
and comparing the run with a software-identical 64bit machine (Core 2 Duo MBP), there are about 250 differences.

These fall in two categories:
a) 1px differences in text AA, or when drawing circles (all _below_ a tolerance of 0.01). Only visible in the subtracted difference image.

The reason is probably CGFloat being typedefed to double on 64bit machines, and float on 32bit machines.
AffineTransform stores doubles, so on 32bit machines we loose precision from AffineTransform -> CGAffineTransform.

b) Failures >0.1% (text origin/scale is slightly different, user-visible).

Caused by several sources of numerical instabilities within the SVG rendering code.

-> SVGPreserveAspectRatio::getCTM() computes an AffineTransform using doubles as input parameters, but floats are passed (like everywhere else in SVG).

This method is used to compute the viewBox AffineTransform, that affects the rendering of every content in the document. RenderSVGRoot concats
this transformation matrix to the GraphicsContext CTM, resulting in a source of numerical imprecision.

-> SVGInlineTextBox::paintTextWithShadows() calculates a scaling factor for text, to scale up the specified font size, to the actual on-screen size.

SVGInlineTextBox uses the scaled Font object, to draw in an unscaled context, that gets scaled up again afterwards.
context->scale(1 / scalingFactor); scaledFont.drawText(); context->scale(scalingFactor);

To remove the scale from the current GraphicsContext CTM, "context->scale(FloatSize(1 / scalingFactor, ...)" is used. As AffineTransform stores
doubles internally, it's likely that "context->scale(FloatSize(1 / ctm.a(), .." doesn't give you a matrix with a=1, but something close to 1.
Using "context->concatCTM(AffineTransform().scale(1 / ctm.a(), ..." could be used as workaround, to preserve double precision.
Fixing that brings us down to just a few pixel tests that differ between 32 & 64bit. There is still numerical imprecision, as floating-point
number representations aren't always precise. Unfortunately CoreGraphics doesn't provide a public way to just set a CTM, it only allows to concat them.
Fortunately CGContextSetCTM() is available, as private method, that allows me to switch the context CTM to any arbitary CGAffineTransform.

-> Add GraphicsContext::setCTM(const AffineTransform&) and implement it for all platforms (each explicitely exposes a 'setCTM' concept, except CG)

Use CGContextSetCTM() for CG, which appears to be present since at least 10.4, Cairo is using it for the same purpose since some years!

-> Instead of scaling the GraphicsContext before drawing text, grab the current CTM using context->getCTM(), scale it by '1 / scalingFactor'

normalize the transform (look for values close to 0/1 using float precision, and round!), and assign it using context->setCTM(normalizedTransform).
After drawing, just switch back to the preserved original CTM, both operations need GraphicsContext::setCTM.
This fixes all pixel test differences between 32/64 bit machines that fall into category b).
The use of GraphicsContext::setCTM() allows to switch between arbitary context transformations _without_ inducing accumulated rounding imprecision.

These combined patches fix the pixel test baseline changes.

Updated existing Snow Leopard pixel test baseline with a 32bit machine, passes here with tolerance 0.
The 64bit machine passes the baseline with tolerance 0.01.

  • platform/graphics/GraphicsContext.h: Add setCTM(const AffineTransform&) method.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setCTM): Implement setCTM.
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setCTM): Ditto.
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::setCTM): Ditto.
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setCTM): Ditto.
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setCTM): Ditto.
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setCTM): Ditto.
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setCTM): Ditto.
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM): (WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto. (WebCore::GraphicsContext::setCTM):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::setCTM): Ditto.
  • rendering/svg/SVGInlineTextBox.cpp: Use setCTM() to switch to a scale-free AffineTransform, and also to switch back to the original CTM after rendering text. (WebCore::normalizeTransform): (WebCore::SVGInlineTextBox::paintDecorationWithStyle): (WebCore::SVGInlineTextBox::paintTextWithShadows):
  • svg/SVGPreserveAspectRatio.cpp: s/double/float/. (WebCore::SVGPreserveAspectRatio::getCTM):
  • svg/SVGPreserveAspectRatio.h:
  • svg/SVGSVGElement.cpp: Simplify viewport() code, avoid using doubles. (WebCore::SVGSVGElement::viewport):

2011-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Pixel tests differences on 10.6.6 32bit vs. 64bit
https://bugs.webkit.org/show_bug.cgi?id=54474

Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
This is the first chunk of several commits, as one commit is too huge for SVN.

It should pass on modern 64bit machines as well, using tolerance 0.01.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-07-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-15-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-15-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
  • platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt:
  • platform/mac/svg/custom/text-rotated-gradient-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/hixie/links/001-expected.txt:
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac/svg/text/small-fonts-2-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
7:01 AM Changeset in webkit [78703] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-16 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

SVGAnimateElement incorrectly uses Color::nameForRenderTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=54547

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::applyResultsToTarget):
6:18 AM Changeset in webkit [78702] by mnaganov@chromium.org
  • 2 adds in trunk/LayoutTests/platform/chromium-win-xp/media

2011-02-16 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of media video-controls-rendering for Windows.

5:52 AM Changeset in webkit [78701] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-02-16 Philippe Normand <pnormand@igalia.com>

Reviewed by Adam Roben.

media/audio-delete-while-slider-thumb-clicked.html failing on Windows since r78562
https://bugs.webkit.org/show_bug.cgi?id=54502

  • media/audio-delete-while-slider-thumb-clicked.html: Avoid deleting the element twice.
  • platform/win/Skipped: unskip the test.
5:48 AM Changeset in webkit [78700] by mnaganov@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

2011-02-14 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Landing detailed heap snapshots, part 3.
https://bugs.webkit.org/show_bug.cgi?id=54385

Provide node classes for data grid views:

  • summary -- list of objects by constuctor;
  • diff -- summaries btw two snapshots;
  • explorer -- explore heap graph;
  • dominators tree;
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DetailedHeapshotGridNodes.js: Added.
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.incInstancesCount): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get instancesCount): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.next): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.resetInstancesCount): (WebInspector.HeapSnapshotEdgesProvider): (WebInspector.HeapSnapshotNodesProvider):
  • inspector/front-end/PleaseWaitMessage.js: (WebInspector.PleaseWaitMessage.prototype.get instance):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
5:22 AM Changeset in webkit [78699] by loislo@chromium.org
  • 4 edits in trunk

2011-02-16 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium: DRT is crashing on the tests in inspector-enabled folder.
https://bugs.webkit.org/show_bug.cgi?id=54548

Bug in chromium DRT implementation was fixed.
The tests were enabled.

  • platform/chromium/test_expectations.txt:

2011-02-16 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: chromium: DRT is crashing on the tests in inspector-enabled folder.
https://bugs.webkit.org/show_bug.cgi?id=54548

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest):
5:08 AM Changeset in webkit [78698] by mnaganov@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests/platform

2011-02-16 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of 2 more media tests.

5:02 AM Changeset in webkit [78697] by mnaganov@chromium.org
  • 19 edits
    13 adds in trunk/LayoutTests/platform

2011-02-16 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed rebaseline of media tests.

4:54 AM Changeset in webkit [78696] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-02-16 Philippe Normand <pnormand@igalia.com>

Unreviewed, qt and mac rebaseline of test after r78690.

  • media/controls-without-preload-expected.txt:
  • platform/qt/media/controls-without-preload-expected.txt:
3:58 AM Changeset in webkit [78695] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-16 Philippe Normand <pnormand@igalia.com>

Unreviewed, rebaseline test after r78690.

  • media/controls-without-preload-expected.txt:
3:51 AM Changeset in webkit [78694] by mnaganov@chromium.org
  • 16 edits
    2 deletes in trunk

2011-02-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r78655.
http://trac.webkit.org/changeset/78655
https://bugs.webkit.org/show_bug.cgi?id=54543

Causes too many test failures in chromium (Requested by
mnaganov on #webkit).

  • storage/indexeddb/exception-in-event-aborts-expected.txt: Removed.
  • storage/indexeddb/exception-in-event-aborts.html: Removed.
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/resources/shared.js: (unexpectedErrorCallback):
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:
3:41 AM Changeset in webkit [78693] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-16 Philippe Normand <pnormand@igalia.com>

Unreviewed rebaseline GTK media test result.

  • platform/gtk/media/video-controls-rendering-expected.txt:
3:21 AM Changeset in webkit [78692] by loislo@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-02-16 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move Database and DOMStorage related things from InspectorAgent to the corresponding agents.

https://bugs.webkit.org/show_bug.cgi?id=54455

Some set of instrumentation calls should work even if we have no InspectorFrontend instance and corresponding agents.
At the moment we are using InspectorAgent instance for such calls.

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorAgent.h: (WebCore::InspectorOfflineResourcesBase::~InspectorOfflineResourcesBase): (WebCore::InspectorOfflineResourcesBase::InspectorOfflineResourcesBase): (WebCore::InspectorAgent::databaseAgentResources): (WebCore::InspectorAgent::domStorageAgentResources):
  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::Resources::clear): (WebCore::InspectorDOMStorageAgent::Resources::pushDataCollectedOffline): (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::createOfflineStorage): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId): (WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
  • inspector/InspectorDOMStorageAgent.h: (WebCore::InspectorDOMStorageAgent::create):
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::Resources::clear): (WebCore::InspectorDatabaseAgent::Resources::pushDataCollectedOffline): (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::createOfflineStorage): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase):
  • inspector/InspectorDatabaseAgent.h: (WebCore::InspectorDatabaseAgent::create):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didOpenDatabaseImpl): (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
3:20 AM Changeset in webkit [78691] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-02-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77898.
http://trac.webkit.org/changeset/77898
https://bugs.webkit.org/show_bug.cgi?id=54541

Leopard Debug hasn't compiled for a long time (Requested by
abarth on #webkit).

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3:13 AM Changeset in webkit [78690] by Philippe Normand
  • 5 edits in trunk/LayoutTests

2011-02-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] media/controls-without-preload.html is flacky on 32-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=50518

Refactored 2 media tests to avoid use of setTimeout and possible
flakyness.

  • media/controls-without-preload.html:
  • media/video-display-toggle.html:
  • platform/gtk/Skipped:
  • platform/gtk/media/controls-without-preload-expected.txt:
3:10 AM Changeset in webkit [78689] by Philippe Normand
  • 6 edits in trunk/LayoutTests

2011-02-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] wrong media duration report in media/controls-after-reload.html
https://bugs.webkit.org/show_bug.cgi?id=51602

Refactored some media tests to be less flaky-prone.

  • media/controls-after-reload.html: Trigger playback just before rendering the controls.
  • media/video-paint-test.js: Ditto. (init.document.addEventListener.): (init):
  • media/video-volume-slider.html: Trigger DRT dump after volume was updated.
  • platform/gtk/Skipped: Unskip fixed tests.
  • platform/gtk/media/video-controls-rendering-expected.txt:
2:47 AM Changeset in webkit [78688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-16 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] QWebFrame: When a relative url is loaded then it will make it absolute internally, however this strips out any query/fragments
https://bugs.webkit.org/show_bug.cgi?id=29424

ensureAbsoluteUrl function was stripping the query and the
fragment part of the url. Corrected this.

  • Api/qwebframe.cpp: (ensureAbsoluteUrl):

Feb 15, 2011:

11:31 PM Changeset in webkit [78687] by sullivan@apple.com
  • 2 edits in trunk/Source/WebCore

Dan Bernstein came up with this fix while we debugged it. I just typed.

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=54532
On platforms without platformWidgets, going Back to a scrolled page
draws at the top-left before drawing at the restored scroll position

<rdar://problem/8998838>

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):
Don't send the didFirstLayout and didFirstVisuallyNonEmptyLayout callbacks
for nested layouts. Doing so was causing ScrollView::setScrollPosition()
to short-circuit.

11:27 PM Changeset in webkit [78686] by Csaba Osztrogonác
  • 4 edits in trunk/Source

Unreviewed.

[Qt][V8] Buildfix. Add missing USE(JSC) guard.

Source/WebCore:

  • plugins/qt/PluginViewQt.cpp:

Source/WebKit/qt:

  • Api/qwebelement.cpp:
10:48 PM Changeset in webkit [78685] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-15 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Kent Tamura.

Fixed a small bug about --no-timeout option.
https://bugs.webkit.org/show_bug.cgi?id=52873

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
10:41 PM Changeset in webkit [78684] by mrowe@apple.com
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

10:39 PM Changeset in webkit [78683] by mrowe@apple.com
  • 1 copy in tags/Safari-534.20.1

New tag.

9:33 PM Changeset in webkit [78682] by tkent@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-15 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Chromium-Mac-Leopard baseline files for r78677.

  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
9:08 PM Changeset in webkit [78681] by tkent@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-02-15 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Chromium baseline files for a new test of r78677.

  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
  • platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
  • platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
9:07 PM Changeset in webkit [78680] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk

2011-02-15 Ami Fischman <fischman@chromium.org>

Reviewed by David Levin.

Remove the artificial -32px shift for media controls in mediaDocuments
so that they overlap the canvas as they do in non-mediaDocuments.
This also fixes test_shell failing to update the media slider (see
linked crbug below).

https://bugs.webkit.org/show_bug.cgi?id=27798
http://crbug.com/72623

Test: media/video-controls-in-media-document.html
Added a render test that asserts that the controls show up in the
expected spot (0,208) instead of below the canvas (0,240).

  • css/mediaControlsChromium.css:
9:05 PM Changeset in webkit [78679] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Extract a function to process ancestor and their sibling nodes from processContents
https://bugs.webkit.org/show_bug.cgi?id=54425

Extracted processAncestorsAndTheirSiblings.

  • dom/Range.cpp: (WebCore::Range::processContents): Calls processContents. (WebCore::Range::processAncestorsAndTheirSiblings): Extracted from processContents.
  • dom/Range.h:
8:51 PM Changeset in webkit [78678] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-02-15 Bill Budge <bbudge@chromium.org>

Reviewed by David Levin.

WebURLRequest, WebURLResponse properties should be passed to WebCore Layer
https://bugs.webkit.org/show_bug.cgi?id=54489

No tests needed, exposes no new functionality

  • src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
  • src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
  • src/WebURLResponsePrivate.h:
8:14 PM Changeset in webkit [78677] by tkent@chromium.org
  • 5 edits
    4 adds in trunk

[Chromium] Rendering error of spin buttons on layers
https://bugs.webkit.org/show_bug.cgi?id=54427

Reviewed by Darin Fisher.

Source/WebCore:

Test: fast/forms/input-appearance-spinbutton-layer.html

  • rendering/RenderThemeChromiumWin.cpp: Add checks for multiple ThemePainter instances.

(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):

Avoid to create multiple ThemePainter instances.

LayoutTests:

  • fast/forms/input-appearance-spinbutton-layer.html: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
8:11 PM Changeset in webkit [78676] by andersca@apple.com
  • 16 edits in trunk/Source/WebKit2

2011-02-15 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebPluginSiteDataManager should work with plug-in process
https://bugs.webkit.org/show_bug.cgi?id=54523
<rdar://problem/8689312>

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::removeWebProcessConnection): Call startShutdownTimerIfNecessary().

(WebKit::PluginProcess::getSitesWithData):
Ask the plug-in module for the sites with data and send them back
in a PluginProcessProxy::DidGetSitesWithData message.

(WebKit::PluginProcess::clearSiteData):
Clear site data and send back a DidClearSiteData message.

(WebKit::PluginProcess::startShutdownTimerIfNecessary):
Factor code out from removeWebProcessConnection.

  • PluginProcess/PluginProcess.messages.in: Add new messages.
  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::plugins): New function for getting all plug-ins.
  • UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection): Call getOrCreatePluginProcess.

(WebKit::PluginProcessManager::getSitesWithData):
Get a plug-in process proxy and call getSitesWithData.

(WebKit::PluginProcessManager::clearSiteData):
Get a plug-in process proxy and call clearSiteData.

(WebKit::PluginProcessManager::getOrCreatePluginProcess):
Factor code to create a plug-in process out into a separate function.

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::getSitesWithData): (WebKit::PluginProcessProxy::clearSiteData): Update the pending reply struct. If the process is still launching, enqueue the request. Otherwise, just send the message.

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
Make sure that pending replies are sent out.

(WebKit::PluginProcessProxy::didFinishLaunching):
Send our pending requests.

(WebKit::PluginProcessProxy::didGetSitesWithData):
(WebKit::PluginProcessProxy::didClearSiteData):
Call down to the plug-in site data manager.

  • UIProcess/Plugins/PluginProcessProxy.messages.in: Add DidGetSitesWithData and DidClearSiteData messages.
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::GetSitesWithDataState): Initialize the state.

(WebKit::WebPluginSiteDataManager::GetSitesWithDataState::getSitesWithDataForNextPlugin):
If the plug-in queue is empty, call didGetSitesWithDataForAllPlugins. Otherwise, ask
the plug-in process manager to get sites for the next plug-in.

(WebKit::WebPluginSiteDataManager::GetSitesWithDataState::didGetSitesWithDataForSinglePlugin):
Update the sites set and get sites for the next plug-in.

(WebKit::WebPluginSiteDataManager::ClearSiteDataState::ClearSiteDataState):
Initialize the state.

(WebKit::WebPluginSiteDataManager::ClearSiteDataState::clearSiteDataForNextPlugin):
If the plug-in queue is empty, call didClearSiteDataForAllPlugins. Otherwise, ask
the plug-in process manager to get sites for the next plug-in.


(WebKit::WebPluginSiteDataManager::ClearSiteDataState::didClearSiteDataForSinglePlugin):
Update the sites set and ask the next plug-in to clear site data.

(WebKit::WebPluginSiteDataManager::~WebPluginSiteDataManager):
Assert that all maps are empty.

(WebKit::WebPluginSiteDataManager::invalidate):
Delete and clear the pending state maps.

(WebKit::WebPluginSiteDataManager::getSitesWithData):
In the ENABLE(PLUGIN_PROCESS) case, allocate a new GetSitesWithDataState object and
tell it to get sites for the next plug-in. Otherwise, make sure that the web process
is alive before sending a GetSitesWithPluginData message.


(WebKit::WebPluginSiteDataManager::clearSiteData):
In the ENABLE(PLUGIN_PROCESS) case, allocate a new ClearSiteDataState object and
tell it to get sites for the next plug-in. Otherwise, make sure that the web process
is alive before sending a ClearPluginSiteData message.


(WebKit::WebPluginSiteDataManager::didGetSitesWithDataForSinglePlugin):
Call down to the GetSitesWithDataState object.

(WebKit::WebPluginSiteDataManager::didGetSitesWithDataForAllPlugins):
Free the GetSitesWithDataState object and invoke the callback.

(WebKit::WebPluginSiteDataManager::didClearSiteDataForSinglePlugin):
Call down to the GetSitesWithDataState object.


(WebKit::WebPluginSiteDataManager::didClearSiteDataForAllPlugins):
Free the GetSitesWithDataState object and invoke the callback.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::processDidClose): Don't invalidate the plug-in site data manager if we're using a plug-in process.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): (WebKit::WebProcess::clearPluginSiteData): Call shutdownIfPossible().
7:41 PM Changeset in webkit [78675] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-15 Martin Robinson <mrobinson@igalia.com>

Skip all Hixie SVG performance tests on GTK+. They seem
to be timing out on the GTK+ debug bots.

  • platform/gtk/Skipped: Skip Hixie SVG performance tests.
7:16 PM Changeset in webkit [78674] by ddkilzer@apple.com
  • 5 edits in trunk/Source/WebKit/mac

2011-02-15 David Kilzer <ddkilzer@apple.com>

<http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h

Reviewed by Darin Adler.

  • WebView/WebDynamicScrollBarsView.h: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed declaration.
  • WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved implementation into correct category.
  • WebView/WebDynamicScrollBarsViewInternal.h: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added declaration.
  • WebView/WebHTMLView.mm: Included WebDynamicScrollBarsViewInternal.h instead of WebDynamicScrollBarsView.h.
7:08 PM Changeset in webkit [78673] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebKit2

Copy over new WebKit 2 header.

Rubber-stamped by Alice Liu.

  • win/WebKit2Generated.make:
7:03 PM Changeset in webkit [78672] by sfalken@apple.com
  • 2 edits in trunk/LayoutTests

Skipped crashing test on Windows.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=54519

  • platform/win/Skipped: Skip fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html
6:12 PM Changeset in webkit [78671] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-02-15 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Fix race condition in JavaScriptAudioNode
https://bugs.webkit.org/show_bug.cgi?id=54518

No new tests since audio API is not yet implemented.

  • webaudio/JavaScriptAudioNode.cpp: (WebCore::JavaScriptAudioNode::process):
6:06 PM Changeset in webkit [78670] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78578.

6:06 PM Changeset in webkit [78669] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78609.

6:06 PM Changeset in webkit [78668] by mrowe@apple.com
  • 3 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78600.

6:02 PM Changeset in webkit [78667] by abarth@webkit.org
  • 1 edit
    4 copies in branches/chromium/648

Merge 77724 - 2011-02-04 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250

This change adds a new script test that we can render a CMYK JPEG with a
color profile correctly, i.e. we can render it without color corruption.

  • fast/images/cmyk-jpeg-with-color-profile-expected.txt: Added.
  • fast/images/cmyk-jpeg-with-color-profile.html: Added.
  • fast/images/resources/cmyk-jpeg.jpg: Added.
  • fast/images/script-tests/cmyk-jpeg-with-color-profile.js: Added. (image.onload):

2011-02-04 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250

Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color
profiles from CMYK to RGB twice and it causes color corruption. This
change suppresses the color profiles for CMYK JPEGs same as gray-scale
ones.

Test: fast/images/cmyk-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):

TBR=commit-queue@webkit.org

6:01 PM Changeset in webkit [78666] by mrowe@apple.com
  • 3 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78513.

5:57 PM Changeset in webkit [78665] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78523.

5:56 PM Changeset in webkit [78664] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

Remove line with dupe expectations.

  • platform/chromium/test_expectations.txt:
5:55 PM Changeset in webkit [78663] by andersca@apple.com
  • 11 edits in trunk/Source/WebKit2

2011-02-15 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Implement WKPluginSiteDataManagerClearSiteData
https://bugs.webkit.org/show_bug.cgi?id=54512
<rdar://problem/8689312>

  • UIProcess/API/C/WKPluginSiteDataManager.cpp: (WKPluginSiteDataManagerGetTypeID): Implement this.

(toNPClearSiteDataFlags):
Convert WKClearSiteDataFlags to NPP_ClearSiteData flags.


(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):
Call through to WebPluginSiteDataManager::clearSiteData.

  • UIProcess/API/C/WKPluginSiteDataManager.h: Change the clear functions to take a completion callback.
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::clearSiteData): Ask the plug-in info store for all plug-in paths and send a ClearPluginSiteData message to the web process.


(WebKit::WebPluginSiteDataManager::didClearSiteData):
call the callback.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::didClearPluginSiteData): Call through to the plug-in site data manager.
  • UIProcess/WebContext.messages.in: Add ClearPluginSiteData message.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::clearPluginSiteData): Iterate over all the plug-in paths, creating plug-in modules and calling clearSiteData for each one.
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Add DidClearPluginSiteData message.
5:53 PM Changeset in webkit [78662] by mrowe@apple.com
  • 2 edits in branches/safari-534.20-branch/Source/WebCore

Merge r78517.

5:50 PM Changeset in webkit [78661] by mrowe@apple.com
  • 4 edits in branches/safari-534.20-branch/Source/WebCore

Merge r78630.

5:46 PM Changeset in webkit [78660] by mrowe@apple.com
  • 8 edits in branches/safari-534.20-branch/Source/WebCore

Merge r78612.

5:44 PM Changeset in webkit [78659] by mrowe@apple.com
  • 3 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78589.

5:42 PM Changeset in webkit [78658] by mrowe@apple.com
  • 13 edits in branches/safari-534.20-branch

Merge r78588.

5:37 PM Changeset in webkit [78657] by mihaip@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-15 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium-gpu-linux rebaseline of
compositing/geometry/vertical-scroll-composited.html.

  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
5:36 PM Changeset in webkit [78656] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
5:24 PM Changeset in webkit [78655] by jorlow@chromium.org
  • 16 edits
    2 adds in trunk

2011-02-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Throwing in an IndexedDB error or success event should lead to the transaction aborting
https://bugs.webkit.org/show_bug.cgi?id=54249

  • storage/indexeddb/exception-in-event-aborts-expected.txt: Added.
  • storage/indexeddb/exception-in-event-aborts.html: Added.

tests new feature

  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/queued-commands.html:

cleaned up (while debuggign something else)

  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:

a few additional tests + cleanup

  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:

a few additional tests + cleanup

2011-02-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Throwing in an IndexedDB error or success event should lead to the transaction aborting
https://bugs.webkit.org/show_bug.cgi?id=54249

When an exception is thrown but not handled within an IDBRequests success/error event,
we should abort the transaction.

Test: storage/indexeddb/exception-in-event-aborts.html

  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • dom/EventTarget.cpp: (WebCore::EventTarget::uncaughtExceptionInEventHandler):
  • dom/EventTarget.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
  • storage/IDBRequest.h:
5:22 PM Changeset in webkit [78654] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix for
https://bugs.webkit.org/show_bug.cgi?id=54415

Remove deleted files.

5:19 PM Changeset in webkit [78653] by mrowe@apple.com
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

5:15 PM Changeset in webkit [78652] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-02-15 Ian Henderson <ianh@apple.com>

Reviewed by Darin Adler.

To determine image properties, CG allocates memory which isn't included in CachedImage's decoded size
https://bugs.webkit.org/show_bug.cgi?id=53281

When determining properties of an image (such as its size), CG ends up
decoding part of the image. This patch adds accounting for this extra
decoded size so a cache prune can clean up the allocations.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::destroyMetadataAndNotify): Clearing the source destroys the extra decoded data. Report this change in decoded size to the image observer. (WebCore::BitmapImage::cacheFrame): The first decoded frame subsumes the data decoded when determining image properties, so we subtract it out here. (WebCore::BitmapImage::didDecodeProperties): Reports the extra decoded size to the image's observer. (WebCore::BitmapImage::size): (WebCore::BitmapImage::currentFrameSize): (WebCore::BitmapImage::getHotSpot): (WebCore::BitmapImage::frameCount): (WebCore::BitmapImage::isSizeAvailable): (WebCore::BitmapImage::repetitionCount):
  • platform/graphics/BitmapImage.h:
  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::bytesDecodedToDetermineProperties): The default value is 0 to match the current behavior on other platforms.
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::bytesDecodedToDetermineProperties): Add a constant value for bytesDecodedToDetermineProperties(), measured by tracing malloc/calloc calls while asking an image source for its properties.
5:11 PM Changeset in webkit [78651] by sfalken@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

Windows-specific results for tests added in r78396.
https://bugs.webkit.org/show_bug.cgi?id=54506

  • platform/win/fast/inline: Added.
  • platform/win/fast/inline/inline-box-background-expected.txt: Added.
  • platform/win/fast/inline/inline-box-background-long-image-expected.txt: Added.
  • platform/win/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
  • platform/win/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
5:05 PM Changeset in webkit [78650] by mrowe@apple.com
  • 1 copy in branches/safari-534.20-branch

New branch.

4:58 PM Changeset in webkit [78649] by mihaip@chromium.org
  • 2 edits
    77 adds in trunk/LayoutTests

2011-02-15 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium-gpu rebaseline. Rebaseline tests that were unskipped
after r78619 as well as some lingering Mac rebaselines.

  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.txt: Added.
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/tiling/constrained-layer-size-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/tiling/constrained-layer-size-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/z-order/negative-z-index-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/z-order/negative-z-index-expected.png: Added.
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/abs-position-inside-opacity-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/masks/direct-image-mask-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-gpu-win/compositing/masks/direct-image-mask-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/overflow/ancestor-overflow-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/overflow/ancestor-overflow-expected.png: Added.
  • platform/chromium-gpu-win/compositing/overflow/ancestor-overflow-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/repaint/composited-document-element-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/chromium-gpu-win/compositing/repaint/composited-document-element-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/tiling/constrained-layer-size-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/tiling/constrained-layer-size-expected.png: Added.
  • platform/chromium-gpu-win/compositing/z-order/negative-z-index-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/z-order/negative-z-index-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:53 PM Changeset in webkit [78648] by jamesr@google.com
  • 9 edits
    4 adds in trunk

2011-02-15 James Robinson <jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

requestAnimationFrame callbacks should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53188

Tests that requestAnimationFrame callbacks are suspended while a modal
dialog is showing.

  • fast/animation/request-animation-frame-during-modal-expected.txt: Added.
  • fast/animation/request-animation-frame-during-modal.html: Added.

2011-02-15 James Robinson <jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

requestAnimationFrame callbacks should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53188

requestAnimationFrame callbacks shouldn't fire while a modal dialog is up (like a window.alert()).
This matches Firefox and other async APIs. This patch moves the callback servicing into its own
controller class which receives notifications on suspend/resume.

Test: fast/animation/request-animation-frame-during-modal.html

  • WebCore.gypi:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setJavaScriptPaused):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::suspendScriptedAnimationControllerCallbacks): (WebCore::Document::resumeScriptedAnimationControllerCallbacks): (WebCore::Document::webkitRequestAnimationFrame): (WebCore::Document::webkitCancelRequestAnimationFrame): (WebCore::Document::serviceScriptedAnimations):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks): (WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks):
  • dom/ScriptedAnimationController.cpp: Added. (WebCore::ScriptedAnimationController::ScriptedAnimationController): (WebCore::ScriptedAnimationController::suspend): (WebCore::ScriptedAnimationController::resume): (WebCore::ScriptedAnimationController::registerCallback): (WebCore::ScriptedAnimationController::cancelCallback): (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
  • dom/ScriptedAnimationController.h: Added. (WebCore::ScriptedAnimationController::create):
  • history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): (WebCore::CachedFrame::CachedFrame):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
4:49 PM Changeset in webkit [78647] by andersca@apple.com
  • 14 edits
    2 adds in trunk/Source/WebKit2

2011-02-15 Anders Carlsson <andersca@apple.com>

Reviewed by Jon Honeycutt.

Implement WKPluginSiteDataManagerGetSitesWithData
https://bugs.webkit.org/show_bug.cgi?id=54510
<rdar://problem/8689312>

  • UIProcess/API/C/WKContext.cpp: (WKContextGetPluginSiteDataManager): Call WebContext::pluginSiteDataManager.


  • UIProcess/API/C/WKPluginSiteDataManager.cpp: (WKPluginSiteDataManagerGetSitesWithData): Call WebPluginSiteDataManager::getSitesWithData.
  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::getPluginPaths):
  • UIProcess/Plugins/PluginInfoStore.h: Populate the paths argument with the paths of all plug-ins.


  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: Added. (WebKit::WebPluginSiteDataManager::invalidate): Invalidate the callbacks map.

(WebKit::WebPluginSiteDataManager::getSitesWithData):
Ask the plug-in info store for all plug-in paths and send a
GetSitesWithPluginData message to the web process.

(WebKit::WebPluginSiteDataManager::didGetSitesWithPluginData):
Call the callback.

  • UIProcess/Plugins/WebPluginSiteDataManager.h: Added. (WebKit::WebPluginSiteDataManager::clearContext): Clear the context.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): Initialize m_pluginSiteDataManager.

(WebKit::WebContext::~WebContext):
Invalidate the plug-in site data manager and clear its context.

(WebKit::WebContext::processDidClose):
Invalidate the plug-in site data manager.


(WebKit::WebContext::didGetSitesWithPluginData):
Call through to the plug-in site data manager.

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in: Add GetSitesWithPluginData message.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj: Add new files.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): Iterate over all plug-in paths and get the sites from all plug-ins.
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Add DidGetSitesWithPluginData.
4:43 PM Changeset in webkit [78646] by kalman@chromium.org
  • 5 edits
    2 deletes in trunk/LayoutTests

2011-02-15 Benjamin Kalman <kalman@chromium.org>

Reviewed by Darin Adler.

Clean up results for editing/selection/extend-selection-home-end layout test
https://bugs.webkit.org/show_bug.cgi?id=54508

Line up results in columns, remove unused pixel test results from qt.

  • editing/selection/extend-selection-home-end-expected.txt:
  • editing/selection/extend-selection-home-end.html:
  • platform/mac/editing/selection/extend-selection-home-end-expected.txt:
  • platform/qt/editing/selection/extend-selection-home-end-expected.checksum: Removed.
  • platform/qt/editing/selection/extend-selection-home-end-expected.png: Removed.
  • platform/win/editing/selection/extend-selection-home-end-expected.txt:
4:38 PM Changeset in webkit [78645] by jorlow@chromium.org
  • 11 edits in trunk/Source

2011-02-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Add initial support for per-origin quotas to IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=54421

Add support for non-persistent per-origin quotas. If one is
specified, it overrides the default.

No tests as this is only exposed via the Chromium webkit API.

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open): (WebCore::IDBFactoryBackendImpl::setQuota):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:

2011-02-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Add initial support for per-origin quotas to IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=54421

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::setQuota):
  • src/AssertMatchingEnums.cpp:
  • src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::setQuota):
  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::setQuota):
  • src/WebIDBFactoryImpl.h:
4:36 PM Changeset in webkit [78644] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2011-02-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

XSLT with output method HTML and images crashes in debug mode
https://bugs.webkit.org/show_bug.cgi?id=54462

http://trac.webkit.org/changeset/75577 created Document::setContent but
didn't notice that the code paths combined into Document::setContent
were subtly different. In particular, some of the code paths called
parser->finish() whereas other did not.

The difference is that an explicit call to parser->finish() is required
in the case where there is no frame because explicitClose doesn't call
endIfNotLoadingMainResource if there is no frame. This patch moves
that logic inside explicitClose, which is more natural.

This patch also removes removeAllChildren, which has not effect in this
situation and should never have been added in the first place.

Test: fast/parser/xslt-with-html.xml

  • dom/Document.cpp: (WebCore::Document::setContent): (WebCore::Document::explicitClose):

2011-02-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

XSLT with output method HTML and images crashes in debug mode
https://bugs.webkit.org/show_bug.cgi?id=54462

Test that we don't try to prepare to stop twice when pasing HTML
generated from an XSLT.

  • fast/parser/resources/xslt-with-html.xsl: Added.
  • fast/parser/xslt-with-html-expected.txt: Added.
  • fast/parser/xslt-with-html.xml: Added.
4:36 PM Changeset in webkit [78643] by kbr@google.com
  • 2 edits in trunk/Source/WebKit/win

2011-02-15 Kenneth Russell <kbr@google.com>

Unreviewed. Remove whitespace-only change from
http://trac.webkit.org/changeset/78620 (https://bugs.webkit.org/show_bug.cgi?id=54312)
now that the patch has passed the Windows build bots.

  • Interfaces/WebKit.idl:
4:32 PM Changeset in webkit [78642] by Martin Robinson
  • 6 edits in trunk/LayoutTests

2011-02-15 Martin Robinson <mrobinson@igalia.com>

Rebaseline some GTK+ tests which have different results on the bots.
Skip a test which appears to be timing out intermittently.

  • platform/gtk/Skipped: Skip a test which has been timing out.
  • platform/gtk/svg/custom/use-nested-transform-expected.txt:
  • platform/gtk/svg/hixie/perf/001-expected.txt:
  • platform/gtk/svg/hixie/perf/002-expected.txt:
  • platform/gtk/svg/hixie/perf/007-expected.txt:
4:23 PM Changeset in webkit [78641] by Darin Adler
  • 27 edits in trunk/LayoutTests

Autocorrection should respect undo.
https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>

Patch by Jia Pu <jpu@apple.com> on 2011-02-15
Reviewed by Darin Adler.

Rebaselined tests affected by code change.

  • platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
  • platform/mac/editing/spelling/autocorrection-delete-expected.txt:
  • platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
  • platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
  • platform/mac/editing/spelling/autocorrection-simple-expected.txt:
  • platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
4:18 PM Changeset in webkit [78640] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Qt build.

  • WebKit2.pro:
4:11 PM Changeset in webkit [78639] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-15 Oliver Hunt <oliver@apple.com>

Fix EFL build for
https://bugs.webkit.org/show_bug.cgi?id=54415

  • CMakeLists.txt:
4:10 PM Changeset in webkit [78638] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Windows build.

  • win/WebKit2.vcproj:
4:04 PM Changeset in webkit [78637] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-15 Oliver Hunt <oliver@apple.com>

Fix EFL build for
https://bugs.webkit.org/show_bug.cgi?id=54415

  • CMakeLists.txt:
3:59 PM Changeset in webkit [78636] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/54487> Minor header clean up in RenderLayerBacking.cpp

Reviewed by Darin Adler.

  • rendering/RenderLayerBacking.cpp: Remove unused

WebGLRenderingContext.h header, and move GraphicsContext3D.h

into a #if ENABLE(WEBGL)
ENABLE(ACCELERATED_2D_CANVAS)/#endif

block.

3:55 PM Changeset in webkit [78635] by pkasting@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

https://bugs.webkit.org/show_bug.cgi?id=40147
https://bugs.webkit.org/show_bug.cgi?id=48029
https://bugs.webkit.org/show_bug.cgi?id=53740
https://bugs.webkit.org/show_bug.cgi?id=54387
https://bugs.webkit.org/show_bug.cgi?id=54418
https://bugs.webkit.org/show_bug.cgi?id=54499
Remove a couple erroneously-added baselines, unmark some now-passing
tests, bug numbers, etc.

  • platform/chromium-linux/http/tests/xmlhttprequest: Removed.
  • platform/chromium-linux/http/tests/xmlhttprequest/cache-override-expected.txt: Removed.
  • platform/chromium-win/fast/gradients/css3-repeating-end-fill-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:54 PM Changeset in webkit [78634] by oliver@apple.com
  • 89 edits
    15 adds
    2 deletes in trunk/Source

2011-02-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough and Geoff Garen.

Refactor handles and weak pointers to become nicer and more automatic
https://bugs.webkit.org/show_bug.cgi?id=54415

Move to a true handle based mechanism for GC value protection. This
also allows us to switch to a more sensible behaviour for weak pointers
in which weak pointers are automatically updated.

This allows us to remove the old (and convoluted) that required all
objects that may be held by a weak reference to be aware of the reference
and manually clear them in their destructors.

This also adds a few new data types to JSC that we use to efficiently
allocate and return the underlying handle storage.

This patch is largely renaming and removing now unnecessary destructors
from objects.

New Global handle type used to keep gc objects live, even if they're not
marked.

(JSC::Global::Global):
(JSC::Global::~Global):
(JSC::Global::set):

We can only assign directly to a global from another global.
In all other cases we need the JSGlobalData to be provided
explicitly so we use a set function.

(JSC::Global::operator=):
(JSC::Global::clear):
(JSC::Global::isHashTableDeletedValue):
(JSC::Global::internalSet):

  • collector/handles/Handle.h: Added.

Root "Handle" type used for immutable handles and to provide the basic
APIs needed for pointer-like behaviour.

(JSC::HandleBase::operator!):
(JSC::HandleBase::operator UnspecifiedBoolType*):
(JSC::HandleBase::isEmpty):
(JSC::HandleBase::HandleBase):
(JSC::HandleBase::slot):
(JSC::HandleBase::invalidate):
(JSC::HandleBase::setSlot):
(JSC::HandleTypes::getFromSlot):
(JSC::HandleTypes::toJSValue):
(JSC::HandleTypes::validateUpcast):
(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):
(JSC::Handle::Handle):
(JSC::Handle::get):
(JSC::Handle::wrapSlot):
(JSC::operator==):
(JSC::operator!=):

  • collector/handles/HandleHeap.cpp: Added.

New heap for global handles.

(JSC::HandleHeap::HandleHeap):
(JSC::HandleHeap::grow):
(JSC::HandleHeap::markStrongHandles):
(JSC::HandleHeap::updateAfterMark):
(JSC::HandleHeap::clearWeakPointers):
(JSC::HandleHeap::writeBarrier):

  • collector/handles/HandleHeap.h: Added. (JSC::HandleHeap::heapFor): (JSC::HandleHeap::toHandle): (JSC::HandleHeap::toNode): (JSC::HandleHeap::allocate): (JSC::HandleHeap::deallocate): (JSC::HandleHeap::makeWeak):

Convert a hard handle into weak handle that does not
protect the object it points to.

(JSC::HandleHeap::makeSelfDestroying):

Converts a handle to a weak handle that will be returned
to the free list when the referenced object dies.

(JSC::HandleHeap::Node::Node):
(JSC::HandleHeap::Node::slot):
(JSC::HandleHeap::Node::handleHeap):
(JSC::HandleHeap::Node::setFinalizer):
(JSC::HandleHeap::Node::makeWeak):
(JSC::HandleHeap::Node::isWeak):
(JSC::HandleHeap::Node::makeSelfDestroying):
(JSC::HandleHeap::Node::isSelfDestroying):
(JSC::HandleHeap::Node::finalizer):
(JSC::HandleHeap::Node::setPrev):
(JSC::HandleHeap::Node::prev):
(JSC::HandleHeap::Node::setNext):
(JSC::HandleHeap::Node::next):

  • interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter):
  • interpreter/Interpreter.h:
  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::globalObjectCollected):
  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
  • runtime/GCHandle.cpp: Removed.
  • runtime/GCHandle.h: Removed.
  • runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::markRoots):
  • runtime/Heap.h: (JSC::Heap::allocateGlobalHandle): (JSC::Heap::reportExtraMemoryCost):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::allocateGlobalHandle):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::~JSGlobalObject):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::create): (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure): (JSC::Structure::setEnumerationCache): (JSC::Structure::clearEnumerationCache):
  • runtime/Protect.h:
  • runtime/Structure.cpp: (JSC::Structure::~Structure):
  • runtime/Structure.h:
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtrBase::get): (JSC::WeakGCPtrBase::clear): (JSC::WeakGCPtrBase::operator!): (JSC::WeakGCPtrBase::operator UnspecifiedBoolType*): (JSC::WeakGCPtrBase::~WeakGCPtrBase): (JSC::WeakGCPtrBase::WeakGCPtrBase): (JSC::WeakGCPtrBase::internalSet): (JSC::LazyWeakGCPtr::LazyWeakGCPtr): (JSC::LazyWeakGCPtr::set): (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::operator=):
  • runtime/WriteBarrier.h:
  • wtf/BlockStack.h: Added. (WTF::::BlockStack): (WTF::::~BlockStack): (WTF::::blocks): (WTF::::grow): (WTF::::shrink):
  • wtf/SentinelLinkedList.h: Added. (WTF::::SentinelLinkedList): (WTF::::begin): (WTF::::end): (WTF::::push): (WTF::::remove):
  • wtf/SinglyLinkedList.h: Added. (WTF::::SinglyLinkedList): (WTF::::isEmpty): (WTF::::push): (WTF::::pop):

2011-02-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough and Geoff Garen.

Refactor handles and weak pointers to become nicer and more automatic
https://bugs.webkit.org/show_bug.cgi?id=54415

Update to use new Global<> type

  • JSRun.cpp: (JSRun::JSRun): (JSRun::GlobalObject):
  • JSRun.h:
  • JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper):
  • JSValueWrapper.h:

2011-02-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough and Geoff Garen.

Refactor handles and weak pointers to become nicer and more automatic
https://bugs.webkit.org/show_bug.cgi?id=54415

Update WebCore to use the new Global<> type rather than ProtectedJSValue
and gc[Un]Protect. Also update to use new WeakGCPtr APIs, and remove now
unnecessary destructors.

  • ForwardingHeaders/collector/handles/Global.h: Added.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • bindings/js/JSCallbackData.h: (WebCore::JSCallbackData::JSCallbackData):
  • bindings/js/JSCustomVoidCallback.h:
  • bindings/js/JSDOMBinding.cpp: (WebCore::forgetDOMNode): (WebCore::cacheDOMNodeWrapper):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDataGridDataSource.h:
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::setWrapper):
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::initializeJSFunction):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::executeFunctionInContext):
  • bindings/js/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction):
  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore):
  • bindings/js/ScriptCachedFrameData.h:
  • bindings/js/ScriptCallStackFactory.cpp: (WebCore::createScriptArguments):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::createWindowShell): (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::attachDebugger):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call): (WebCore::ScriptCallback::call):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::ScriptObject):
  • bindings/js/ScriptObject.h:
  • bindings/js/ScriptState.cpp: (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get):
  • bindings/js/ScriptState.h:
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isFunction): (WebCore::ScriptValue::deserialize):
  • bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::hasNoValue):
  • bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::ScriptWrappable): (WebCore::ScriptWrappable::setWrapper):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::WorkerScriptController): (WebCore::WorkerScriptController::~WorkerScriptController): (WebCore::WorkerScriptController::initScript): (WebCore::WorkerScriptController::evaluate):
  • bindings/js/WorkerScriptController.h: (WebCore::WorkerScriptController::workerContextWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_Construct):
  • bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::Instance): (JSC::Bindings::Instance::~Instance): (JSC::Bindings::Instance::willDestroyRuntimeObject): (JSC::Bindings::Instance::willInvalidateRuntimeObject):
  • bridge/jsc/BridgeJSC.h:
  • bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::invalidate):
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::RootObject): (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::globalObject): (JSC::Bindings::RootObject::updateGlobalObject):
  • bridge/runtime_root.h:
  • dom/EventListener.h:
  • dom/EventTarget.h: (WebCore::EventTarget::markJSEventListeners):
  • xml/XMLHttpRequest.cpp:

Qt bindings courtesy of Csaba Osztrogonác

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeConnectionMethod::call): (JSC::Bindings::QtConnectionObject::QtConnectionObject): (JSC::Bindings::QtConnectionObject::execute): (JSC::Bindings::QtConnectionObject::match):
  • bridge/qt/qt_runtime.h:

2011-02-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough and Geoff Garen.

Refactor handles and weak pointers to become nicer and more automatic
https://bugs.webkit.org/show_bug.cgi?id=54415

Update to use Global<> instead of ProtectedPtr, and refactored slightly
to get global data to places it's needed for when we're assigning to
Global<>s

  • ForwardingHeaders/collector/handles/Global.h: Added.
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject): (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::addValueToArray):
  • WebView/WebScriptDebugger.h:
  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger):

2011-02-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough and Geoff Garen.

Refactor handles and weak pointers to become nicer and more automatic
https://bugs.webkit.org/show_bug.cgi?id=54415

Update code to new Global<> API, and refactor to get global data to
necessary points.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp: (WebKit::NPJSObject::create): (WebKit::NPJSObject::NPJSObject): (WebKit::NPJSObject::initialize): (WebKit::NPJSObject::invokeDefault): (WebKit::NPJSObject::construct): (WebKit::NPJSObject::invoke):
  • WebProcess/Plugins/Netscape/NPJSObject.h:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::getOrCreateNPObject): (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant): (WebKit::NPRuntimeObjectMap::evaluate):
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::windowScriptNPObject): (WebKit::PluginView::pluginElementNPObject):
3:51 PM Changeset in webkit [78633] by andersca@apple.com
  • 9 edits
    2 adds in trunk/Source/WebKit2

2011-02-15 Anders Carlsson <andersca@apple.com>

Reviewed by Jon Honeycutt.

Add stubbed out WKPluginSiteDataManagerRef API
https://bugs.webkit.org/show_bug.cgi?id=54504

  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKContext.cpp: (WKContextGetPluginSiteDataManager):
  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKPluginSiteDataManager.cpp: Added. (WKPluginSiteDataManagerGetTypeID): (WKPluginSiteDataManagerGetSitesWithData): (WKPluginSiteDataManagerClearSiteData): (WKPluginSiteDataManagerClearAllSiteData):
  • UIProcess/API/C/WKPluginSiteDataManager.h: Added.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
3:44 PM Changeset in webkit [78632] by Darin Adler
  • 26 edits
    5 adds in trunk/Source

2011-02-15 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection should respect undo.
https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>

Please see WebCore/ChangeLog for detailed description.

  • WebCoreSupport/WebEditorClient.cpp: (WebFrameImpl::replaceSelection): Adopted new signature of ReplaceSelectionCommand::create().

2011-02-15 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection should respect undo.
https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>

Please see WebCore/ChangeLog for detailed description.

  • WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::recordAutocorrectionResponse): Ditto.
  • WebView/WebFrame.mm: (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):

Adopted new signature of ReplaceSelectionCommand::create().

2011-02-15 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection should respect undo.
https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>

Manual test: manual-tests/autocorrection/undo-autocorrection.html

When user undoes an autocorrection, we need to do four things:

  1. Revert the change in text that has been made by correction.
  2. Revert the selection to pre-correction state so that user can immediately continue typing.
  3. Add appropriate markers to reverted text so that it won't be corrected again and/or shown as misspelled.
  4. If applicable, notify spell checking service to record this reversion.

To achieve these, this patch introduces following changes:

  1. Created SpellingCorrectionCommand so that correction can be undone in similar way as any other editing command. SpellingCorrectionCommand is a composition of SetSelectionCommand, SpellingCorrectionRecordUndoCommand and ReplaceSelectionCommand.
  2. Created SetSelectionCommand so that undo command can restore selection state.
  3. Added member function recordAutocorrectionResponse() to editor client.

To improve readability, this patch also consolidates various boolean arguments in SelectionController::setSelection()
and ReplaceSelectionCommand::ReplaceSelectionCommand(). These boolean arguments have been
replaced by enum variable.

  • WebCore.exp.in: Updated for changes in Editor and ReplaceSelectionCommand.
  • WebCore.xcodeproj/project.pbxproj: Updated for new source files.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Adopted new signature of ReplaceSelectionCommand::create().
  • editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): Ditto. (WebCore::Editor::unappliedEditing): Cleaned up trailing whitespace. (WebCore::Editor::reappliedEditing): Ditto. (WebCore::Editor::selectComposition): Adopted new signature of SelectionController::setSelection(). (WebCore::Editor::confirmComposition): Ditto. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Rearranged code to reduce the

level of deeply nested if statement. Adopted SpellingCorrectionCommand.

(WebCore::Editor::applyCorrectionPanelInfo): Adopted SpellingCorrectionCommand.
(WebCore::Editor::unappliedSpellCorrection): Function for adding markers to reverted text and

for notifiying editor client about undone correction.

(WebCore::Editor::changeSelectionAfterCommand): Adopted new signature of SelectionController::setSelection().
(WebCore::Editor::respondToChangedSelection): Use SelectionController::SetSelectionOptions

instead of boolean variables.

  • editing/Editor.h: Added Editor::unappliedSpellCorrection().
  • editing/EditorCommand.cpp: (WebCore::executeInsertFragment): Adopted new signature of ReplaceSelectionCommand::create().
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply): Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Replaced all boolean arguments

with an enum value.

  • editing/ReplaceSelectionCommand.h: (WebCore::ReplaceSelectionCommand::create): Ditto.
  • editing/SelectionController.cpp: Adopted new signature of SelectionController::setSelection(). (WebCore::SelectionController::moveTo): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::respondToNodeModification): (WebCore::SelectionController::setBase): (WebCore::SelectionController::setExtent): (WebCore::SelectionController::setSelectedRange):
  • editing/SelectionController.h: (WebCore::SelectionController::setSelection): Replaced all boolean arguments with an enum value.
  • editing/SetSelectionCommand.cpp: Added. (WebCore::SetSelectionCommand::SetSelectionCommand): (WebCore::SetSelectionCommand::doApply): (WebCore::SetSelectionCommand::doUnapply):
  • editing/SetSelectionCommand.h: Added. (WebCore::SetSelectionCommand::create):
  • editing/mac/SpellingCorrectionCommand.cpp: Added. (WebCore::SpellingCorrectionRecordUndoCommand::create): (WebCore::SpellingCorrectionRecordUndoCommand::SpellingCorrectionRecordUndoCommand): (WebCore::SpellingCorrectionRecordUndoCommand::doApply): (WebCore::SpellingCorrectionRecordUndoCommand::doUnapply): (WebCore::SpellingCorrectionCommand::SpellingCorrectionCommand): (WebCore::SpellingCorrectionCommand::doApply):
  • editing/mac/SpellingCorrectionCommand.h: Added. (WebCore::SpellingCorrectionCommand::create):
  • loader/EmptyClients.h: Updated for the new function declared in EditorClient. (WebCore::EmptyEditorClient::recordAutocorrectionResponse):
  • manual-tests/autocorrection/undo-autocorrection.html: Added.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Adopted new signature of ReplaceSelectionCommand::create().
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Ditto.
  • page/EditorClient.h: Added EditorClient::recordAutocorrectionResponse().

2011-02-15 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection should respect undo.
https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>

Please see WebCore/ChangeLog for detailed description.

  • WebProcess/WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::recordAutocorrectionResponse): Ditto.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::replaceSelectionWithText): Adopted new signature of ReplaceSelectionCommand::create().
3:41 PM Changeset in webkit [78631] by sfalken@apple.com
  • 2 edits in trunk/LayoutTests

Add media/audio-delete-while-slider-thumb-clicked.html to Windows skipped list.
Failing since r78562.

  • platform/win/Skipped:
3:39 PM Changeset in webkit [78630] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

Speculative fix for <rdar://problem/8998498> CrashTracer: [USER]
8 crashes in WebProcess calling setOverlayScrollerState:forceImmediately:

Reviewed by Darin Adler.

My best guess is that this is crashing because
willRemoveVerticalScrollbar()/Horizontal was not being called
properly from the RenderLayer destructor.

Call willRemoveVerticalScrollbar()/Horizontal from destroyScrollbar()
so that all current and future scrollbar-destroyers will properly
call this function. And only do it for native scrollers.
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderListBox::destroyScrollbar):

For consistency's sake, I also moved didAddVerticalScrollbar()
/Horizontal to createScrollbar(). Again, only call for native
scrollers.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderListBox::createScrollbar):

These functions no longer call didAdd/willRemove.
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::setHasVerticalScrollbar):

Remove unnecessary ScrollableArea::-prefix

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

3:38 PM Changeset in webkit [78629] by senorblanco@chromium.org
  • 6 edits in trunk/LayoutTests

2011-02-15 Stephen White <senorblanco@chromium.org>

Unreviewed; new baselines for canvas GPU tests.

Rebaseline for slight pixel differences on windows.

  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium/test_expectations.txt:
3:31 PM Changeset in webkit [78628] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium-gpu expectations update. Update expectations after
tests that were unskipped by r78619 started to be run again. Most of
them don't time out anymore, instead they have image and/or text diffs.

Also remove flaky expectations for fast/canvas/shadow-offset-*.html,
since they pass consistently now that the bug on the Chromium/V8 side
(http://crbug.com/67732) has been fixed.

  • platform/chromium/test_expectations.txt:
3:25 PM Changeset in webkit [78627] by ddkilzer@apple.com
  • 4 edits in trunk/Source/WebKit/mac

<http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll

Reviewed by Darin Adler.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
-inProgramaticScroll.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.

3:20 PM Changeset in webkit [78626] by Joseph Pecoraro
  • 3 edits in trunk/Source/WebCore

2011-02-15 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Cleanup Some Potential ENABLE(INSPECTOR) Related Building Issues
https://bugs.webkit.org/show_bug.cgi?id=54048

  • WebCore.exp.in: moved inspector only export into ENABLE(INSPECTOR) block.
  • bindings/js/ScriptHeapSnapshot.h: include no longer needed.
3:17 PM Changeset in webkit [78625] by senorblanco@chromium.org
  • 6 edits in trunk

2011-02-15 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.


[chromium] clearRect() is incorrect in accelerated 2D canvas.
https://bugs.webkit.org/show_bug.cgi?id=54497

When doing GPU-Canvas2D clearRect() using the fast path (glClear()),
we were not correctly converting from canvas to screen coordinates.
Fixed by inverting the rectangle in Y, and changing
SharedGraphicsContext3D::scissor to take glScissor-like parameters.

Covered by fast/canvas/canvas-strokeRect.html.

  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::clearRect): Flip the Y coord of the rectangle passed to scissor().
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::scissor):
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Give scissor() the same param types as GraphicsContext3D::scissor().

2011-02-15 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

[chromium] Mark fast/canvas/canvas-strokeRect.html as passing on the GPU path.
https://bugs.webkit.org/show_bug.cgi?id=54497

  • platform/chromium/test_expectations.txt:
3:16 PM Changeset in webkit [78624] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebKit2: Use the Database directory location specified in NSUserDefaults.
https://bugs.webkit.org/show_bug.cgi?id=54496

Reviewed by Darin Adler.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultDatabaseDirectory):
Use the same logic as WebKit1's WebDatabaseManager::databasesDirectoryPath.

3:01 PM Changeset in webkit [78623] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

2011-02-15 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson, Darin Adler.

Layers stick around in DrawingAreaImpl until we switch out of compositing
https://bugs.webkit.org/show_bug.cgi?id=54498

When leaving compositing mode soon, remove all the child layers
of the nonCompositedContent layer right away, so they don't stick
around.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer):
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::setRootCompositingLayer):
3:01 PM Changeset in webkit [78622] by psolanki@apple.com
  • 4 edits in trunk/Source

2011-02-15 Pratik Solanki <psolanki@apple.com>

Move WTF_USE_CFNETWORK to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=54168

Reviewed by Darin Adler.

  • wtf/Platform.h: Define WTF_USE_CFNETWORK for Windows builds.

2011-02-15 Pratik Solanki <psolanki@apple.com>

Move WTF_USE_CFNETWORK to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=54168

Reviewed by Darin Adler.

  • config.h: Remove WTF_USE_CFNETWORK.
2:55 PM Changeset in webkit [78621] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium-gpu expectations update.
compositing/reflections/animation-inside-reflection.html and
compositing/reflections/nested-reflection-animated.html are flaky on
Linux too.

  • platform/chromium/test_expectations.txt:
2:53 PM Changeset in webkit [78620] by kbr@google.com
  • 50 edits
    8 adds in trunk

2011-02-15 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312

Implemented new method setMinimumTimerInterval in
LayoutTestController for all ports.

  • DumpRenderTree/LayoutTestController.cpp: (setMinimumTimerIntervalCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setMinimumTimerInterval):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMinimumTimerInterval):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMinimumTimerInterval):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMinimumTimerInterval):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMinimumTimerInterval):

2011-02-15 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312

  • fast/dom/timer-increase-min-interval-and-reset-part-1-expected.txt: Added.
  • fast/dom/timer-increase-min-interval-and-reset-part-1.html: Added.
  • fast/dom/timer-increase-min-interval-and-reset-part-2-expected.txt: Added.
  • fast/dom/timer-increase-min-interval-and-reset-part-2.html: Added.
    • Chained tests (the assumption is that the run-webkit-tests harness will run them sequentially, which is a reasonably good assumption) which verify that the minimum timer interval is reset between tests.
  • fast/dom/timer-increase-min-interval-expected.txt: Added.
  • fast/dom/timer-increase-min-interval.html: Added.
    • Verifies that increasing the minimum timer interval causes fast timers to run slowly.
  • fast/dom/timer-increase-then-decrease-min-interval-expected.txt: Added.
  • fast/dom/timer-increase-then-decrease-min-interval.html: Added.
    • Verifies that decreasing the minimum timer interval causes previously slowed-down timers to be reevaluated immediately.

2011-02-15 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312

  • public/WebSettings.h:
    • Added setMinimumTimerInterval.
  • src/WebKit.cpp: (WebKit::initialize):
    • Added FIXME to remove setting of page's default timer interval.
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setMinimumTimerInterval):
    • Implemented new method on WebSettings.
  • src/WebSettingsImpl.h:

2011-02-15 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312

Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::defaultMinimumTimerInterval): (DumpRenderTreeSupportQt::setMinimumTimerInterval):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-15 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312

Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::defaultMinimumTimerInterval): (DumpRenderTreeSupportGtk::setMinimumTimerInterval):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-15 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312

Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method. Includes whitespace-only change to
WebKit.idl to trigger proper rebuild on bots; will be removed in
subsequent checkin.

  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebView.cpp: (WebView::initWithFrame): (WebView::defaultMinimumTimerInterval): (WebView::setMinimumTimerInterval):
  • WebView.h:

2011-02-15 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312

Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (+[WebView _defaultMinimumTimerInterval]): (-[WebView _setMinimumTimerInterval:]):
  • WebView/WebViewPrivate.h:

2011-02-15 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312

Renamed DOMTimer::minTimerInterval and setMinTimerInterval to
defaultMinTimerInterval and setDefaultMinTimerInterval, made them
private and exposed them via Settings::defaultMinDOMTimerInterval
and setDefaultMinDOMTimerInterval. Added new
Settings::setMinDOMTimerInterval and minDOMTimerInterval.

The storage for the minimum timer interval currently lives in the
Page, though this could be moved to the Settings object if
desired. The accessor methods on the Page are private and exposed
to Settings by making Settings a friend, so the abstraction
barrier is clear at the API level.

Adjusting the interval both upward and downward may cause the fire
times of the active timers on the page to be adjusted, if they
would be affected by the clamping value. This is needed to reduce
latency when bringing a tab to the foreground, in particular if
the minimum timer interval was decreased from a very high value to
a very low value.

A new method, setMinimumTimerInterval, has been added to
LayoutTestController, implemented in all ports of DumpRenderTree,
and used in new layout tests.

Ideally changing the page's minimum timer interval would affect
dedicated workers, but this is too much to do in an initial patch,
so a FIXME has been added.

Tested with:

  • The new layout tests on the WebKit Mac and Chromium (Mac, Linux) DRT ports.
  • Hooked up the new API in Chromium and ran some simple manual tests.

Tests: fast/dom/timer-increase-min-interval-and-reset-part-1.html

fast/dom/timer-increase-min-interval-and-reset-part-2.html
fast/dom/timer-increase-min-interval.html
fast/dom/timer-increase-then-decrease-min-interval.html

  • WebCore.exp.in:
  • dom/Document.cpp: (WebCore::Document::minimumTimerInterval):
  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::adjustMinimumTimerInterval): (WebCore::ScriptExecutionContext::minimumTimerInterval):
  • dom/ScriptExecutionContext.h:
  • page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::adjustMinimumTimerInterval): (WebCore::DOMTimer::intervalClampedToMinimum):
  • page/DOMTimer.h: (WebCore::DOMTimer::defaultMinTimerInterval): (WebCore::DOMTimer::setDefaultMinTimerInterval):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setMinimumTimerInterval): (WebCore::Page::minimumTimerInterval):
  • page/Page.h:
  • page/Settings.cpp: (WebCore::Settings::setDefaultMinDOMTimerInterval): (WebCore::Settings::defaultMinDOMTimerInterval): (WebCore::Settings::setMinDOMTimerInterval): (WebCore::Settings::minDOMTimerInterval):
  • page/Settings.h:
  • platform/Timer.h: (WebCore::TimerBase::augmentFireInterval): (WebCore::TimerBase::augmentRepeatInterval):

2011-02-15 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage):
2:49 PM Changeset in webkit [78619] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium-gpu baseline update. Unskip some tests that fail;
we want to keep running them in case they regress in unexpected ways
(e.g. they start to crash).

  • platform/chromium/test_expectations.txt:
2:46 PM Changeset in webkit [78618] by Simon Fraser
  • 7 edits in trunk/Source/WebCore

2011-02-15 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Fix scrollbar rendering crash when rendered into a layer
https://bugs.webkit.org/show_bug.cgi?id=54494

Remove code added in r78394 which was intended to find out whether
a scrollbar was being rendered into a compositing layer. r78612
obviated the need for this code.

  • page/FrameView.h:
  • platform/ScrollableArea.h:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:
2:37 PM Changeset in webkit [78617] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-02-15 Simon Fraser <Simon Fraser>

Let Xcode have its way with the project.

  • WebCore.xcodeproj/project.pbxproj:
2:37 PM Changeset in webkit [78616] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-02-15 Simon Fraser <Simon Fraser>

Fix Mac builds that don't use rubber-band scrolling
by moving m_drawingIntoLayer out of the #ifdef.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
2:30 PM Changeset in webkit [78615] by tonyg@chromium.org
  • 5 edits in branches/chromium/648/Source/WebCore

Merge 78548 - 2011-02-15 Gavin Peters <gavinp@chromium.org>

Reviewed by Antti Koivisto.

SharedBuffer::buffer() does not do what you think.
https://bugs.webkit.org/show_bug.cgi?id=54420

No new tests.

  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContentBase64):
  • platform/SharedBuffer.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::decode):
  • platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6526023

2:16 PM Changeset in webkit [78614] by Martin Robinson
  • 50 edits in trunk

2011-02-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Freetype] Better map CSS font weight to Fontconfig font weight
https://bugs.webkit.org/show_bug.cgi?id=54323

Update the results of this test, which is now passing. Also update results for
all other tests which have different results now.

  • platform/gtk/fast/css/font-weight-1-expected.checksum:
  • platform/gtk/fast/css/font-weight-1-expected.png:
  • platform/gtk/fast/css/font-weight-1-expected.txt:

2011-02-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Freetype] Better map CSS font weight to Fontconfig font weight
https://bugs.webkit.org/show_bug.cgi?id=54323

  • platform/graphics/freetype/FontCacheFreeType.cpp: (WebCore::fontWeightToFontconfigWeight): Added this helper to map between CSS and Fontconfig font weights. (WebCore::FontCache::createFontPlatformData): Use the new helper instead of just deciding between bold and regular.

2011-02-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Freetype] Better map CSS font weight to Fontconfig font weight
https://bugs.webkit.org/show_bug.cgi?id=54323

Add the WeightWatcher fonts to the list of sourced fonts when intializing
DRT. This will allow us to pass tests that use WeightWatcher.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Source the WebkitWeightWatcher fonts.
2:12 PM Changeset in webkit [78613] by mihaip@chromium.org
  • 18 edits
    54 adds in trunk/LayoutTests

2011-02-15 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium-gpu-linux rebaseline. Check in correct expectations
which should allow us to remove the PASS FAIL line for compositing/ for
this platform.

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.checksum:
  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/generated-content-expected.checksum:
  • platform/chromium-gpu-linux/compositing/generated-content-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/composited-html-size-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/composited-html-size-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/animation-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-animated-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-opacity-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-size-change-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-size-change-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.checksum:
  • platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-ordering-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-positioning-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-positioning2-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/sibling-positioning-expected.checksum:
  • platform/chromium-gpu-linux/compositing/sibling-positioning-expected.png:
  • platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-gpu-linux/compositing/webgl/webgl-reflection-expected.checksum: Added.
  • platform/chromium-gpu-linux/compositing/webgl/webgl-reflection-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:00 PM Changeset in webkit [78612] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

2011-02-15 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Fix scrollbar rendering crash when rendered into a layer
https://bugs.webkit.org/show_bug.cgi?id=54494

The scroller delegate was failing to return a layer in a case
where the scroller was still rendering into a GraphicsLayer, because
even though WebCore had switched out of compositing mode, the
DrawingAreaImpl was still rendering into its nonCompositedContent
layer. This happens when the m_exitCompositingTimer timer hasn't fired
yet.

The fix is to track whether we're drawing into a layer via the
GraphicsContext, rather than asking about compositing layers.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setIsCALayerContext): (WebCore::GraphicsContext::isCALayerContext): Getter and setter for the bit that says if we're rendering into a CALayer.
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): Store a bool for whether this context targets a layer.
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents): Call setIsCALayerContext(true).
  • platform/mac/ScrollAnimatorMac.h: (WebCore::ScrollAnimatorMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorMac::isDrawingIntoLayer): New methods to get and set a flag that says when we're drawing into a layer, so that the delegate can get at this state.
  • platform/mac/ScrollAnimatorMac.mm: (-[ScrollbarPainterDelegate layer]): Use isDrawingIntoLayer() (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): Init the flag.
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::unregisterScrollbar): Whitespace. (WebCore::ScrollbarThemeMac::paint): Push the "isDrawingIntoLayer" state down onto ScrollAnimatorMac, getting it from the GraphicsContext.
1:35 PM Changeset in webkit [78611] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-15 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add sitesWithData and clearSiteData to NetscapePluginModule
https://bugs.webkit.org/show_bug.cgi?id=54492

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::NetscapePluginModule): (WebKit::NetscapePluginModule::pluginCreated): (WebKit::NetscapePluginModule::pluginDestroyed): (WebKit::NetscapePluginModule::sitesWithData): (WebKit::NetscapePluginModule::clearSiteData): (WebKit::NetscapePluginModule::tryGetSitesWithData): (WebKit::NetscapePluginModule::tryClearSiteData): (WebKit::NetscapePluginModule::incrementLoadCount): (WebKit::NetscapePluginModule::decrementLoadCount):
  • Shared/Plugins/Netscape/NetscapePluginModule.h:
1:33 PM Changeset in webkit [78610] by tony@chromium.org
  • 185 edits
    1 delete in trunk/LayoutTests

2011-02-15 Tony Chang <tony@chromium.org>

Rebaseline chromium-linux tests with menulists (select drop downs).
We now match Windows w.r.t. sizes, the only difference is the
background color of the menulist (in themeChromiumLinux.css).

  • platform/chromium-linux/editing/pasteboard/4641033-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4641033-expected.png:
  • platform/chromium-linux/editing/pasteboard/4641033-expected.txt:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.txt:
  • platform/chromium-linux/editing/pasteboard/4944770-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4944770-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-2-expected.txt:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.checksum:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.png:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.txt:
  • platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.checksum:
  • platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.png:
  • platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/chromium-linux/editing/selection/select-box-expected.checksum:
  • platform/chromium-linux/editing/selection/select-box-expected.png:
  • platform/chromium-linux/editing/selection/select-box-expected.txt:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.checksum:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.checksum:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.txt:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-linux/fast/forms/003-expected.checksum:
  • platform/chromium-linux/fast/forms/003-expected.png:
  • platform/chromium-linux/fast/forms/003-expected.txt:
  • platform/chromium-linux/fast/forms/004-expected.checksum:
  • platform/chromium-linux/fast/forms/004-expected.png:
  • platform/chromium-linux/fast/forms/004-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/chromium-linux/fast/forms/basic-selects-expected.checksum:
  • platform/chromium-linux/fast/forms/basic-selects-expected.png:
  • platform/chromium-linux/fast/forms/basic-selects-expected.txt:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.checksum:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.png:
  • platform/chromium-linux/fast/forms/control-clip-overflow-expected.txt:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.checksum:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-clip-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-clip-expected.png:
  • platform/chromium-linux/fast/forms/menulist-clip-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-deselect-update-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-deselect-update-expected.png:
  • platform/chromium-linux/fast/forms/menulist-deselect-update-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-narrow-width-expected.png:
  • platform/chromium-linux/fast/forms/menulist-narrow-width-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-no-overflow-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-no-overflow-expected.png:
  • platform/chromium-linux/fast/forms/menulist-no-overflow-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-option-wrap-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-linux/fast/forms/menulist-option-wrap-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/menulist-separator-painting-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-separator-painting-expected.png:
  • platform/chromium-linux/fast/forms/menulist-separator-painting-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.txt:
  • platform/chromium-linux/fast/forms/menulist-width-change-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-width-change-expected.png:
  • platform/chromium-linux/fast/forms/menulist-width-change-expected.txt:
  • platform/chromium-linux/fast/forms/option-script-expected.checksum:
  • platform/chromium-linux/fast/forms/option-script-expected.png:
  • platform/chromium-linux/fast/forms/option-script-expected.txt:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.checksum:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.txt:
  • platform/chromium-linux/fast/forms/option-text-clip-expected.checksum:
  • platform/chromium-linux/fast/forms/option-text-clip-expected.png:
  • platform/chromium-linux/fast/forms/option-text-clip-expected.txt:
  • platform/chromium-linux/fast/forms/select-align-expected.checksum:
  • platform/chromium-linux/fast/forms/select-align-expected.png:
  • platform/chromium-linux/fast/forms/select-align-expected.txt:
  • platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-linux/fast/forms/select-baseline-expected.png:
  • platform/chromium-linux/fast/forms/select-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.checksum:
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/chromium-linux/fast/forms/select-disabled-appearance-expected.checksum:
  • platform/chromium-linux/fast/forms/select-disabled-appearance-expected.png:
  • platform/chromium-linux/fast/forms/select-disabled-appearance-expected.txt:
  • platform/chromium-linux/fast/forms/select-empty-option-height-expected.checksum:
  • platform/chromium-linux/fast/forms/select-empty-option-height-expected.png:
  • platform/chromium-linux/fast/forms/select-empty-option-height-expected.txt:
  • platform/chromium-linux/fast/forms/select-selected-expected.checksum:
  • platform/chromium-linux/fast/forms/select-selected-expected.png:
  • platform/chromium-linux/fast/forms/select-selected-expected.txt:
  • platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.checksum:
  • platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/chromium-linux/fast/html/keygen-expected.checksum:
  • platform/chromium-linux/fast/html/keygen-expected.png:
  • platform/chromium-linux/fast/html/keygen-expected.txt:
  • platform/chromium-linux/fast/invalid/014-expected.checksum:
  • platform/chromium-linux/fast/invalid/014-expected.png:
  • platform/chromium-linux/fast/invalid/014-expected.txt:
  • platform/chromium-linux/fast/invalid/residual-style-expected.checksum:
  • platform/chromium-linux/fast/invalid/residual-style-expected.png:
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-linux/fast/parser/document-write-option-expected.checksum:
  • platform/chromium-linux/fast/parser/document-write-option-expected.png:
  • platform/chromium-linux/fast/parser/document-write-option-expected.txt:
  • platform/chromium-linux/fast/repaint/control-clip-expected.checksum:
  • platform/chromium-linux/fast/repaint/control-clip-expected.png:
  • platform/chromium-linux/fast/repaint/control-clip-expected.txt:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.checksum:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-linux/fast/replaced/three-selects-break-expected.checksum:
  • platform/chromium-linux/fast/replaced/three-selects-break-expected.png:
  • platform/chromium-linux/fast/replaced/three-selects-break-expected.txt:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-menulist-expected.txt:
  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-linux/tables/mozilla/core/margins-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/margins-expected.png:
  • platform/chromium-linux/tables/mozilla/core/margins-expected.txt:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-linux/transforms/2d/zoom-menulist-expected.checksum:
  • platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
  • platform/chromium-linux/transforms/2d/zoom-menulist-expected.txt:
  • platform/chromium/test_expectations.txt:
1:30 PM Changeset in webkit [78609] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix windows build.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::encodeResourceRequest):

1:22 PM Changeset in webkit [78608] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2011-02-15 Martin Robinson <mrobinson@igalia.com>

Reversing an expectations update, that I mistakenly uploaded in r78595.

  • platform/gtk/Skipped: Skip this test, as the results are incorrect on GTK+.
  • svg/text/lengthAdjust-text-metrics-expected.txt: Restore expectations for this test.
1:21 PM Changeset in webkit [78607] by sfalken@apple.com
  • 2 edits in trunk/LayoutTests

Skip failing tests being tracked by https://bugs.webkit.org/show_bug.cgi?id=54490

  • platform/win/Skipped:
1:09 PM Changeset in webkit [78606] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-15 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] add WebIDBFactory::deleteDatabase method
https://bugs.webkit.org/show_bug.cgi?id=54447

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open): (WebKit::WebIDBFactory::deleteDatabase):
1:03 PM Changeset in webkit [78605] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Moved MarkedBlock data members to the head of the block
https://bugs.webkit.org/show_bug.cgi?id=54482


This allows for a variable-sized tail, to accommodate oversized blocks.

SunSpider reports no change.


  • runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate):
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::destroy): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep):
  • runtime/MarkedBlock.h: Added missing element to the CELLS_PER_BLOCK calculation. This kind of error is why we want to migrate to the system described below.

(JSC::roundUpToMultipleOf):
(JSC::MarkedBlock::firstCell):
(JSC::MarkedBlock::cells):
(JSC::MarkedBlock::cellNumber): Use subtraction instead of masking to
calculate cell number. The mask is no longer correct because the first
cell is not at the head of the block.

(JSC::MarkedBlock::forEach): Replaced m_cells data member with a cells()
accessor. We want to use sizeof(MarkedBlock) to calculate the size of the
block header, so we can't have an explicit data member to represent the block tail.


Also replaced iteration from zero with iteration from startCell(), since
the first N cells are now occupied by the header.

  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::reset): Replaced iteration from zero as above.
12:50 PM Changeset in webkit [78604] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

2011-02-15 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add NPP_GetSitesWithData and NPP_URLRedirectNotify to the NPAPI headers
https://bugs.webkit.org/show_bug.cgi?id=54481

We should really sync all headers with the NPAPI repository, but doing that
lead to build errors so I just added what was needed.

  • bridge/npapi.h: Add new functions.
  • bridge/nptypes.h: Sync with the official NPAPI repository, adding 64-bit integer types and removing a duplicate license header.
  • plugins/npfunctions.h: Add new functions.
12:37 PM Changeset in webkit [78603] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=54480
<rdar://problem/8975229> REGRESSION (WebKit2): A web page remains unresponsive for a long
time after printing

Nothing was painted until moving the mouse over browser chrome, deactivating the window,
or taking some other drastic measure like that.

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setAutodisplay): Call -[NSView displayIfNeeded] after enabling autodisplay. For some reason, this makes WebCore push updates again.
12:29 PM Changeset in webkit [78602] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=54486
Crashes under CachedResourceLoader::revalidateResource

Reviewed by Darin Adler.

CachedResourceLoader might get deleted from under one of its methods.
Try to catch a more informative crash stack.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::load):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::requestPreload):

  • loader/cache/CachedResourceLoader.h:
12:12 PM Changeset in webkit [78601] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-15 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Make new-run-webkit-tests --processes work under Windows' weird
multiprocessing model. This requires us to be running a Python
file that can be imported as a module, so I've modified the
new-run-webkit-tests script to spawn a subprocess runing
webkitpy.layout_tests.run_webkit_tests.py. I've also modified
the manager_worker_broker tests because you can't pickle a
nested class. This requires us to use globals to pass queues
back and forth for testing, but the alternative is to pass extra
arguments to start_worker() and that feels like a bad tradeoff
just for testing.

https://bugs.webkit.org/show_bug.cgi?id=54431

  • Scripts/new-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
12:10 PM Changeset in webkit [78600] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-15 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Crash loading fast/loader/empty-embed-src-attribute.html
<rdar://problem/9005541>
https://bugs.webkit.org/show_bug.cgi?id=54483

Add the ability to encode/decode and empty ResourceRequest.

  • Shared/mac/WebCoreArgumentCodersMac.mm: (CoreIPC::encodeResourceRequest): (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse): Add missing false check for the decode step.
  • Shared/win/WebCoreArgumentCodersWin.cpp: (CoreIPC::encodeResourceRequest): (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse): Add missing false check for the decode step.
12:02 PM Changeset in webkit [78599] by senorblanco@chromium.org
  • 7 edits in trunk/LayoutTests

2011-02-15 Stephen White <senorblanco@chromium.org>

Unreviewed; new Chromium/Linux test baselines.

canvas-composite.html rebaselined due to new GPU-based path drawing code.
canvas-text-alignment and image-object-in-canvas rebaselined due to slight pixel differences near the scrollbar.

  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
11:58 AM Changeset in webkit [78598] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-15 Tony Chang <tony@chromium.org>

Unreviewed, update the version of Chromium in webkit.

  • DEPS:
11:52 AM Changeset in webkit [78597] by crogers@google.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-15 Chris Rogers <crogers@google.com>

Reviewed by Alexey Proskuryakov.

Fix Mutex::tryLock() on Windows to work properly with PlatformCondition::timedWait()
https://bugs.webkit.org/show_bug.cgi?id=54408

  • wtf/ThreadingWin.cpp: (WTF::PlatformCondition::timedWait):
11:47 AM Changeset in webkit [78596] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-15 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

Optimize Color::serialized()
https://bugs.webkit.org/show_bug.cgi?id=54452

Apply the optimizations from CSSPrimitiveValue::cssText() [CSS_RGBCOLOR]
to Color::serialized() - build the serialized color strings manually
instead of using String::format().

  • platform/graphics/Color.cpp: (WebCore::appendHexNumber): (WebCore::Color::serialized):
11:26 AM Changeset in webkit [78595] by Martin Robinson
  • 3 edits
    233 adds in trunk/LayoutTests

2011-02-15 Martin Robinson <mrobinson@igalia.com>

Import the last set of GTK+ baselines for SVG tests.

  • platform/gtk/Skipped: Unskip tests which now have results. Classify failures.
11:17 AM Changeset in webkit [78594] by Martin Robinson
  • 3 edits
    161 adds in trunk/LayoutTests

2011-02-15 Martin Robinson <mrobinson@igalia.com>

Add the next batch of GTK+ SVG results.

  • platform/gtk/Skipped: Unskip tests which now have results.
11:17 AM Changeset in webkit [78593] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-02-15 Andreas Kling <kling@webkit.org>

Unreviewed Qt build fix after r78588.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Add WKPageLoaderClient::shouldGoToHistoryItem.
11:10 AM Changeset in webkit [78592] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r78579.
http://trac.webkit.org/changeset/78579
https://bugs.webkit.org/show_bug.cgi?id=54479

Undo wrong rebaseline for Gtk results (Requested by msanchez
on #webkit).

  • platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
11:10 AM Changeset in webkit [78591] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-15 Jarred Nicholls <jarred@sencha.com>

Reviewed by Alexey Proskuryakov.

XMLHttpRequest::abort() doesn't clear response data
https://bugs.webkit.org/show_bug.cgi?id=54118

Properly clear all buffer data on abort, so no memory hangs around unnecessarily.

No new tests because there is no observable effect except for less memory used.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::abort):
11:01 AM Changeset in webkit [78590] by andreas.kling@nokia.com
  • 11 edits in trunk/Source/WebCore

2011-02-15 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

Rename Color::name() to Color::nameForRenderTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=54464

Color::name() returns the color as either #RRGGBB or #RRGGBBAA.
Since the latter is not a valid CSS color, it can't be re-parsed
by WebKit, and should only be used in DRT dumps.

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::extractTextStyles):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
  • platform/graphics/Color.cpp: (WebCore::Color::nameForRenderTreeAsText):
  • platform/graphics/Color.h:
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
  • platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::externalRepresentation):
  • rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject):
  • rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeRenderSVGTextBox):
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGColor.cpp: (WebCore::SVGColor::cssText):
10:57 AM Changeset in webkit [78589] by enrica@apple.com
  • 3 edits in trunk/Source/WebKit2

Stop using deprecated API to flip the dragImage.
<rdar://problem/8930897>
https://bugs.webkit.org/show_bug.cgi?id=54477

Reviewed by Darin Adler.

NSImage setFlipped is a deprecated API. We replace it with
drawInRect:fromRect:operation:fraction:respectFlipped:hints.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setDragImage): Removed call to setFlipped.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag): The image is now drawn with
drawInRect:fromRect:operation:fraction:respectFlipped:hints.

10:46 AM Changeset in webkit [78588] by beidson@apple.com
  • 13 edits in trunk

<rdar://problem/9002047> and https://bugs.webkit.org/show_bug.cgi?id=54426
WebFrameLoaderClient::shouldGoToHistoryItem needs implementation

Reviewed by Darin Adler.

Source/WebKit2:

Expose HistoryItem -> ItemID mapping for the message:

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::idForItem):

  • WebProcess/WebPage/WebBackForwardListProxy.h:

Sync message to the UIProcess for the answer:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):

Call out to the WebLoaderClient for the answer:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::shouldGoToBackForwardListItem):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Call out to the client application for the answer:

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::shouldGoToBackForwardListItem):

  • UIProcess/WebLoaderClient.h:

Add API for the client application to listen for this:

  • UIProcess/API/C/WKPage.h:

Tools:

Add dummy implementations to keep our tools building.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

10:43 AM Changeset in webkit [78587] by Martin Robinson
  • 2 edits
    154 adds in trunk/LayoutTests

2011-02-15 Martin Robinson <mrobinson@igalia.com>

Import the next batch of GTK+ SVG test results and correct an incorrect
line in the skipped list.

  • platform/gtk/Skipped: Unskip tests which now have results.
10:38 AM Changeset in webkit [78586] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-15 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
SKIP two more Inspector tests, from r78581 (by pfeldman's request).

10:25 AM Changeset in webkit [78585] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-15 Andras Becsi <abecsi@webkit.org>

Rubber-stamped by Andreas Kling.

[Qt] Typo fix.

No new tests needed.

  • WebCore.pro: add missing ASCII to header name.
10:22 AM Changeset in webkit [78584] by pfeldman@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-02-15 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: expectations update for r78548 and r78576.

  • platform/mac-leopard/inspector/extensions/extensions-resources-expected.txt: Removed.
  • platform/qt/Skipped:
10:18 AM Changeset in webkit [78583] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-02-15 Martin Robinson <mrobinson@igalia.com>

Continue importing GTK+ SVG test results.

  • platform/gtk/Skipped: Unskip tests which now have results.
10:14 AM Changeset in webkit [78582] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-15 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
SKIP two Inspector tests (by pfeldman's request).

10:07 AM Changeset in webkit [78581] by pfeldman@chromium.org
  • 4 edits
    5 adds in trunk

2011-02-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: test whether inspector gets populated with databases and storages upon opening.
https://bugs.webkit.org/show_bug.cgi?id=54469

  • http/tests/inspector-enabled/database-open-expected.txt: Added.
  • http/tests/inspector-enabled/database-open.html: Added.
  • http/tests/inspector-enabled/dom-storage-open-expected.txt: Added.
  • http/tests/inspector-enabled/dom-storage-open.html: Added.

2011-02-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: test whether inspector gets populated with databases and storages upon opening.
https://bugs.webkit.org/show_bug.cgi?id=54469

Tests: http/tests/inspector-enabled/database-open.html

http/tests/inspector-enabled/dom-storage-open.html

  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js: (WebInspector.DatabaseDispatcher.prototype.addDatabase):
9:58 AM Changeset in webkit [78580] by andreas.kling@nokia.com
  • 8 edits
    1 add in trunk/Source/WebCore

2011-02-15 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

Share the helper functions used by Latin-1 and UTF-8 text codecs
https://bugs.webkit.org/show_bug.cgi?id=54446

Move MachineWord, UCharByteFiller and the other helper functions
into TextCodecASCIIFastPath.h where they can be used by both
TextCodecUTF8 and TextCodecLatin1.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/TextCodecASCIIFastPath.h: Added. (WebCore::isAllASCII): (WebCore::copyASCIIMachineWord): (WebCore::isAlignedToMachineWord): (WebCore::alignToMachineWord):
  • platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode):
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::decode):
9:52 AM Changeset in webkit [78579] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, rebaseline of Gtk result.

  • platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
9:49 AM Changeset in webkit [78578] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Anders typo. false -> 0.

Reviewed by Anders Carlsson.

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::create):

9:45 AM Changeset in webkit [78577] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed text expectations fix

9:41 AM Changeset in webkit [78576] by pfeldman@chromium.org
  • 12 edits
    11 adds in trunk/LayoutTests

2011-02-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement DOM agent tests.
https://bugs.webkit.org/show_bug.cgi?id=54459

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.expandedNodeWithId.callback): (initialize_ElementTest.InspectorTest.expandedNodeWithId): (initialize_ElementTest.InspectorTest.dumpElementsTree): (initialize_ElementTest.InspectorTest.dumpElementsTree.print): (initialize_ElementTest.InspectorTest.expandElementsTree): (initialize_ElementTest.InspectorTest.expandElementsTree.mycallback): (initialize_ElementTest.InspectorTest.dumpDOMAgentTree): (initialize_ElementTest):
  • http/tests/inspector/extensions-resources-redirect-expected.txt:
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.addResult.clearResults): (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite): (output): (clearOutput):
  • inspector/debugger/dom-breakpoints.html:
  • inspector/elements/elements-panel-limited-children-expected.txt:
  • inspector/elements/elements-panel-rewrite-href.html:
  • inspector/elements/elements-panel-structure-expected.txt:
  • inspector/elements/elements-panel-structure.html:
  • inspector/elements/elements-panel-xhtml-structure-expected.txt:
  • inspector/elements/elements-panel-xhtml-structure.xhtml:
  • inspector/elements/insert-node-collapsed-expected.txt: Added.
  • inspector/elements/insert-node-collapsed.html: Added.
  • inspector/elements/insert-node-expected.txt: Added.
  • inspector/elements/insert-node.html: Added.
  • inspector/elements/modify-chardata-expected.txt: Added.
  • inspector/elements/modify-chardata.html: Added.
  • inspector/elements/mutate-unknown-node-expected.txt: Added.
  • inspector/elements/mutate-unknown-node.html: Added.
  • inspector/elements/remove-node-expected.txt: Added.
  • inspector/elements/remove-node.html: Added.
  • inspector/elements/set-attribute.html: Added.
  • inspector/extensions/extensions-expected.txt:
9:36 AM Changeset in webkit [78575] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-15 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Kent Tamura.

Code style issue in WebCore/dom/InputElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=54428

Remove 2 extra spaces in InputElement.cpp line 221.

Code style fix, No new tests.

  • dom/InputElement.cpp: (WebCore::InputElement::handleBeforeTextInsertedEvent):
9:30 AM Changeset in webkit [78574] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-15 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Mark svg/custom/use-css-no-effect-on-shadow-tree.svg as passing.
Mark media/audio-delete-while-slider-thumb-clicked.html as timing out.
https://bugs.webkit.org/show_bug.cgi?id=54472

9:29 AM Changeset in webkit [78573] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Remove some dead code in ARMv7
https://bugs.webkit.org/show_bug.cgi?id=54461

  • assembler/ARMv7Assembler.h: remove dead code.
9:28 AM Changeset in webkit [78572] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, test crashing because of failing ASSERT on GTK 64-bit debug bot.

[GTK] svg/text/select-textLength-spacing-squeeze-1.svg crashes due to ASSERT failing
https://bugs.webkit.org/show_bug.cgi?id=54470

  • platform/gtk/Skipped: Skipped test.
8:59 AM Changeset in webkit [78571] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-02-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] Video player sets system volume to 100%
https://bugs.webkit.org/show_bug.cgi?id=54140

Don't explicitely set volume at startup and use the
GstStreamVolume interface with cubic volume scale when
updating/retrieving the volume value. This gives a much better
user-experience.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
8:48 AM Changeset in webkit [78570] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Andreas Kling.

[Gtk] Cleanup in the canvas tests
https://bugs.webkit.org/show_bug.cgi?id=54458

Unskip canvas tests that already pass.

  • platform/gtk/Skipped:
8:47 AM Changeset in webkit [78569] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

2011-02-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch script-src for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54381

  • http/tests/security/contentSecurityPolicy/script-loads-with-img-src-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-loads-with-img-src.html: Added.
    • Test that we don't block scripts when the policy is just img-src.
  • http/tests/security/contentSecurityPolicy/script-src-in-iframe.html:
  • http/tests/security/contentSecurityPolicy/script-src-none.html:
  • http/tests/security/contentSecurityPolicy/script-src-redirect.html:
    • Turns out we need to escape the ; character in order for it to be echoed back correctly in the header.

2011-02-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch script-src for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54381

This patch provides a sketch of the script-src directive. We still do
not parse the value of the directive, and the wiring into the rest of
WebCore is incorrect, but those are things we can fix in future
patches. For the momemnt, this patch lets us test what we're doing.

Test: http/tests/security/contentSecurityPolicy/script-loads-with-img-src.html

  • page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::CSPDirective::allows): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::canLoadExternalScriptFromSrc): (WebCore::ContentSecurityPolicy::parse): (WebCore::ContentSecurityPolicy::emitDirective):
  • page/ContentSecurityPolicy.h:
8:45 AM Changeset in webkit [78568] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

svg/custom/use-css-no-effect-on-shadow-tree.svg produces empty image on Chromium Linux after r58556
https://bugs.webkit.org/show_bug.cgi?id=54460

Reviewed by Andreas Kling.

Don't use fast path for SVG. There are some additional rules for shadow trees that are not
implemented on fast path.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::checkSelector):

8:41 AM Changeset in webkit [78567] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK 64-bit debug bot.

editing/selection/end-of-document.html is failing in the GTK 64-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=53995

  • platform/gtk/Skipped: Skipped flaky test.
8:15 AM Changeset in webkit [78566] by abecsi@webkit.org
  • 6 edits
    1 copy in trunk/Source

2011-02-15 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Part 1.

Introduce CodeGenerators.pri and add common includepaths to WebCore.pri,
thus unnecessary duplications can be removed from project files.

No new tests needed.

  • CodeGenerators.pri: Copied from Source/WebCore/WebCore.pri. Don't add non-source generated files to SOURCES.
  • DerivedSources.pro: Change WebCore.pri to CodeGenerators.pri.
  • WebCore.pri: Move code generation rules to CodeGenerators.pri.
  • WebCore.pro: Move common options to WebCore.pri.

2011-02-15 Andras Becsi <abecsi@webkit.org>

Reviewed by NOBODY Csaba Osztrogonác.

[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Part 1.

Introduce CodeGenerators.pri and add common includepaths to WebCore.pri,
thus unnecessary duplications can be removed from project files.

  • WebKit2.pro: Simplify and deduplicate includepaths.
8:14 AM Changeset in webkit [78565] by kalman@chromium.org
  • 6 edits in trunk/LayoutTests

2011-02-15 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Refactor the extend-selection tests to be clearer what they're doing
https://bugs.webkit.org/show_bug.cgi?id=54429

This is essentially a cleanup to extend-selection.js and propagation of those changes to the affected tests.

  • editing/selection/extend-selection-character.html:
  • editing/selection/extend-selection-enclosing-block.html:
  • editing/selection/extend-selection-home-end.html:
  • editing/selection/extend-selection-word.html:
  • editing/selection/resources/extend-selection.js: (getSerializedSelection): (extendSelectionWithinBlock): (extendSelectionToEnd): (fold): (logMismatchingPositions): (extendAndLogSelection): (extendAndLogSelectionWithinBlock): (extendAndLogSelectionToEnd): (runSelectionTestsWithGranularity): (getTestNodeContainer): (createNode): (createCharAndWordNodes): (createEnclosingBlockNodes): (createHomeEndNodes): (createAllNodes): (.window.onload):
8:11 AM Changeset in webkit [78564] by mihaip@chromium.org
  • 2 edits
    2 copies in branches/chromium/648/Source/WebCore

Merge 78561 - 2011-02-15 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::FrameLoader::continueLoadAfterNavigationPolicy
https://bugs.webkit.org/show_bug.cgi?id=54219

Ensures we do not start a new navigation while we are in the process of
stopping a navigation. Also adds a manual test, since the crash can
only be reproduced using the back button and not history.back().

  • loader/FrameLoader.cpp:
  • manual-tests/navigation-during-onload-triggered-by-back.html: Added.
  • manual-tests/resources/navigation-during-onload-container.html: Added.

BUG=72458
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6524014

7:58 AM Changeset in webkit [78563] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-15 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Mark svg/custom/use-css-no-effect-on-shadow-tree.svg as failing.
https://bugs.webkit.org/show_bug.cgi?id=54460

7:56 AM Changeset in webkit [78562] by Philippe Normand
  • 4 edits in trunk/LayoutTests

2011-02-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] media/audio-delete-while-slider-thumb-clicked.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53247

Refactored the test to use the seeking event instead of timeupdate
and avoid flakyness.

  • media/audio-delete-while-slider-thumb-clicked-expected.txt:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • platform/gtk/Skipped:
7:55 AM Changeset in webkit [78561] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebCore

2011-02-15 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::FrameLoader::continueLoadAfterNavigationPolicy
https://bugs.webkit.org/show_bug.cgi?id=54219

Ensures we do not start a new navigation while we are in the process of
stopping a navigation. Also adds a manual test, since the crash can
only be reproduced using the back button and not history.back().

  • loader/FrameLoader.cpp:
  • manual-tests/navigation-during-onload-triggered-by-back.html: Added.
  • manual-tests/resources/navigation-during-onload-container.html: Added.
7:48 AM Changeset in webkit [78560] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Dirk Schulze <krit@webkit.org>

Unreviewed rebaseline.

SVG animation doesn't support attribute value 'inherit'
https://bugs.webkit.org/show_bug.cgi?id=54410

Rebaseline of Gtk result.

  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
7:47 AM Changeset in webkit [78559] by jeffm@apple.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed. Add myself to the list of committers.

7:28 AM Changeset in webkit [78558] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-02-15 Bill Budge <bbudge@chromium.org>

Reviewed by David Levin.

SubresourceLoader should expose finish time
https://bugs.webkit.org/show_bug.cgi?id=54287

No tests needed, exposes no new functionality

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didFinishLoading):
  • loader/DocumentThreadableLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFinishLoading):
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didFinishLoading):
  • loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::didFinishLoading):
  • loader/cache/CachedResourceRequest.h:
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFinishLoading):
  • loader/icon/IconLoader.h:
7:23 AM Changeset in webkit [78557] by mnaganov@chromium.org
  • 2 adds in trunk/LayoutTests/platform/chromium-linux/http/tests/xmlhttprequest

2011-02-15 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Update test results for xmlhttprequest/cache-override.html after r78541.

7:13 AM Changeset in webkit [78556] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Enable fast path selector checking for child and subselector combinators
https://bugs.webkit.org/show_bug.cgi?id=54360

Reviewed by Darin Adler.

  • css/CSSStyleSelector.cpp:

(WebCore::isFastCheckableSelector):
(WebCore::fastCheckSingleSelector):
(WebCore::checkClassValue):
(WebCore::checkIdValue):
(WebCore::checkTagValue):
(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):

7:06 AM Changeset in webkit [78555] by mnaganov@chromium.org
  • 4 edits
    4 adds in trunk/LayoutTests/platform

2011-02-15 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Add test results for animate-elem-31-t.svg after r78543, r78552.

6:50 AM Changeset in webkit [78554] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-15 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console auto-scroll is broken when there are both scrollers.
https://bugs.webkit.org/show_bug.cgi?id=54273

  • inspector/front-end/utilities.js: (Element.prototype.isScrolledToBottom): use clientHeight instead of offsetHeight to determine whether the element is scrolled to the bottom.
6:39 AM Changeset in webkit [78553] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: highlighter works incorrect at build.chromium.org WebKit cells
https://bugs.webkit.org/show_bug.cgi?id=53910

Use enclosingBoundingBox for the absolute margin quad as the reference box for a tooltip.

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::drawNodeHighlight):
6:03 AM Changeset in webkit [78552] by krit@webkit.org
  • 7 edits in trunk

2011-02-15 Dirk Schulze <krit@webkit.org>

Rubber-stamped by Nikolas Zimmermann.

SVG animation doesn't support attribute value 'inherit'
https://bugs.webkit.org/show_bug.cgi?id=54410

Accidently replaced start value RegularPropertyValue for m_fromPropertyValueType
and m_toPropertyValueType by CurrentColorValue before landing. Check for property
value type 'inherit' on color validation was missing.

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues):

2011-02-15 Dirk Schulze <krit@webkit.org>

Rubber-stamped by Nikolas Zimmermann.

SVG animation doesn't support attribute value 'inherit'
https://bugs.webkit.org/show_bug.cgi?id=54410

We have support for 'inherit' in SVG animations now. This means the cyan circles
are invisible at the beginning.
The test itself is still broken, since calcMode gets handled incorrectly.

  • platform/mac-wk2/Skipped:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
5:35 AM Changeset in webkit [78551] by christian@webkit.org
  • 33 edits in trunk/Source/WebKit/gtk

Source/WebKit/gtk: * webkit/webkitwebsettings.cpp: Correct a typo, it is

acces*s*ibility with two s.

Rubber-stamped by Gustavo Noronha Silva.

Source/WebKit/gtk/po: * *.po: Correct a typo in acces*s*ibility.

Rubber-stamped by Gustavo Noronha Silva.

5:31 AM Changeset in webkit [78550] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Windows build fix after r78533

  • WebCore.vcproj/WebCore.vcproj: Fix bad XML syntax.
5:23 AM Changeset in webkit [78549] by christian@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

Brazilian Portuguese Translation Update
https://bugs.webkit.org/show_bug.cgi?id=42833

  • pt_BR.po: Updated.
5:09 AM Changeset in webkit [78548] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-15 Gavin Peters <gavinp@chromium.org>

Reviewed by Antti Koivisto.

SharedBuffer::buffer() does not do what you think.
https://bugs.webkit.org/show_bug.cgi?id=54420

No new tests.

  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContentBase64):
  • platform/SharedBuffer.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::decode):
  • platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode):
3:44 AM Changeset in webkit [78547] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, unskip passing test after r78541.

r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
https://bugs.webkit.org/show_bug.cgi?id=54418

  • platform/gtk/Skipped: Unskip passing test.
3:33 AM Changeset in webkit [78546] by mario@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, GTK baselines for 4 new tests added in r78396.

  • platform/gtk/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/gtk/fast/inline/inline-box-background-expected.png: Added.
  • platform/gtk/fast/inline/inline-box-background-expected.txt: Added.
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/gtk/fast/inline/inline-box-background-long-image-expected.txt: Added.
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
3:27 AM Changeset in webkit [78545] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-02-15 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style should do some detection for valid uses of WEBKIT_API (in chromium public api).
https://bugs.webkit.org/show_bug.cgi?id=52271

  • Scripts/webkitpy/style/checkers/cpp.py: Added the check for WEBKIT_API usage.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
3:26 AM Changeset in webkit [78544] by pfeldman@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

2011-02-15 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: update inspector expectation path for mac-leopard.

  • platform/mac-leopard/inspector/extensions/extensions-resources-expected.txt: Renamed from LayoutTests/platform/mac-leopard/inspector/extensions-resources-expected.txt.
3:16 AM Changeset in webkit [78543] by krit@webkit.org
  • 9 edits
    6 adds in trunk

2011-02-15 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation doesn't support attribute value 'inherit'
https://bugs.webkit.org/show_bug.cgi?id=54410

Check support for 'inherit' and 'currentColor' on SVG animations.

  • svg/animations/animate-currentColor-expected.txt: Added.
  • svg/animations/animate-currentColor.html: Added.
  • svg/animations/animate-inherit-css-property-expected.txt: Added.
  • svg/animations/animate-inherit-css-property.html: Added.
  • svg/animations/script-tests/animate-currentColor.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/animate-inherit-css-property.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-02-15 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation doesn't support attribute value 'inherit'
https://bugs.webkit.org/show_bug.cgi?id=54410

SVG animation does not support 'inherit' as value for CSS property animations. With the patch, SVG determines
if the attribute of the target element is an animatable CSS Property and computes the style during the
animation.

This fixes the following tests on the W3C test suite:

  • animate-elem-84-t.svg
  • animate-elem-85-t.svg

Tests: svg/animations/animate-currentColor.html

svg/animations/animate-inherit-css-property.html

  • svg/SVGAnimateElement.cpp: (WebCore::adjustForCurrentColor): (WebCore::adjustForInheritance): (WebCore::SVGAnimateElement::calculateAnimatedValue): When a property value is 'inherit' or 'currentColor' during the animation, get the computed style of the property since the values could be animated themselves. (WebCore::inheritsFromProperty): (WebCore::attributeValueIsCurrentColor): (WebCore::SVGAnimateElement::calculateFromAndToValues): Check if 'from', 'by' or 'to' value has the string 'inherit' or 'currentColor' and if the attribute supports one of these values. (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto.
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty): Check if target element is stylable and the attribute is an animatable CSS property by using the CSS property map in SVGStyledElement. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): s/target/targetElement/ for consistency.
  • svg/SVGAnimationElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isAnimatableCSSProperty): Checks if the CSS property is animatable.
  • svg/SVGStyledElement.h:
  • svg/animation/SMILTimeContainer.cpp: Use the new function isTargetAttributeCSSProperty to determine if the target element is stylable and the attribute is an animatable CSS property. (WebCore::SMILTimeContainer::baseValueFor):
3:06 AM Changeset in webkit [78542] by pfeldman@chromium.org
  • 2 edits in branches/chromium/597/WebCore/inspector/front-end

Reverting poor merge of http://trac.webkit.org/changeset/74261 that landed in M9 as http://trac.webkit.org/changeset/74265.
It resulted in the regression: Chrome 9 dev tools no longer lists resources pulled via XHR.

This has been approved by Anthony.
BUG=72834

Review URL: http://codereview.chromium.org/6528009

3:03 AM Changeset in webkit [78541] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
https://bugs.webkit.org/show_bug.cgi?id=54418

Reviewed by Andreas Kling.

Check for zero buffer length.

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::decode):

2:55 AM Changeset in webkit [78540] by pfeldman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-15 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: inspector tests expectations update.

  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
2:49 AM Changeset in webkit [78539] by mnaganov@chromium.org
  • 51 adds in trunk/LayoutTests/platform/chromium-mac-leopard

2011-02-15 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Update image results for CSS tests on Mac Leopard.

2:35 AM Changeset in webkit [78538] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt

2011-02-15 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update after r78525

LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt

2:26 AM Changeset in webkit [78537] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping test timing out on SnowLeopard, GTK and Chromium bots.

r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
https://bugs.webkit.org/show_bug.cgi?id=54418

  • platform/gtk/Skipped: Skipped test.
2:22 AM Changeset in webkit [78536] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt]REGRESSION?(78477): inspector/timeline-network-resource.html and inspector/timeline-script-tag-1.html fail
https://bugs.webkit.org/show_bug.cgi?id=54442

  • platform/qt/Skipped: inspector/timeline-network-resource.html and inspector/timeline-script-tag-1.html added until fix.
2:02 AM Changeset in webkit [78535] by pfeldman@chromium.org
  • 36 edits
    4 copies
    199 moves
    17 adds
    1 delete in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move rest of the tests off old harness.
https://bugs.webkit.org/show_bug.cgi?id=54437

  • http/tests/inspector-enabled/console-log-before-frame-navigation.html:
  • http/tests/inspector/change-iframe-src-expected.txt:
  • http/tests/inspector/change-iframe-src.html:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/console-websocket-error.html:
  • http/tests/inspector/console-xhr-logging.html:
  • http/tests/inspector/extensions-headers.html:
  • http/tests/inspector/extensions-resources-redirect-expected.txt:
  • http/tests/inspector/extensions-resources-redirect.html:
  • http/tests/inspector/extensions-test.js:
  • http/tests/inspector/inspect-iframe-from-different-domain-expected.txt:
  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • http/tests/inspector/inspector-test.js:
  • http/tests/inspector/inspector-test2.js: Removed.
  • http/tests/inspector/network-preflight-options.html:
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-parameters.html:
  • http/tests/inspector/resources/extension-main.html:
  • http/tests/inspector/resources/iframe-from-different-domain-data.html:
  • inspector/audits/audits-panel-functional-expected.txt: Renamed from LayoutTests/inspector/audits-panel-functional-expected.txt.
  • inspector/audits/audits-panel-functional.html: Renamed from LayoutTests/inspector/audits-panel-functional.html.
  • inspector/audits/audits-test.js: Renamed from LayoutTests/inspector/audits-tests2.js.
  • inspector/audits/resources/Ahem.ttf: Copied from LayoutTests/inspector/resources/Ahem.ttf.
  • inspector/audits/resources/abe.png: Copied from LayoutTests/inspector/resources/abe.png.
  • inspector/audits/resources/audits-script1.js: Renamed from LayoutTests/inspector/resources/audits-script1.js.
  • inspector/audits/resources/audits-script2.js: Renamed from LayoutTests/inspector/resources/audits-script2.js.
  • inspector/audits/resources/audits-style1.css: Copied from LayoutTests/inspector/resources/audits-style1.css.
  • inspector/console/command-line-api-expected.txt: Renamed from LayoutTests/inspector/command-line-api-expected.txt.
  • inspector/console/command-line-api.html: Renamed from LayoutTests/inspector/command-line-api.html.
  • inspector/console/console-api-on-call-frame-expected.txt: Renamed from LayoutTests/inspector/console-api-on-call-frame-expected.txt.
  • inspector/console/console-api-on-call-frame.html: Renamed from LayoutTests/inspector/console-api-on-call-frame.html.
  • inspector/console/console-assert-expected.txt: Renamed from LayoutTests/inspector/console-assert-expected.txt.
  • inspector/console/console-assert.html: Renamed from LayoutTests/inspector/console-assert.html.
  • inspector/console/console-clear-expected.txt: Renamed from LayoutTests/inspector/console-clear-expected.txt.
  • inspector/console/console-clear.html: Renamed from LayoutTests/inspector/console-clear.html.
  • inspector/console/console-command-clear-expected.txt: Renamed from LayoutTests/inspector/console-command-clear-expected.txt.
  • inspector/console/console-command-clear.html: Renamed from LayoutTests/inspector/console-command-clear.html.
  • inspector/console/console-dir-expected.txt: Renamed from LayoutTests/inspector/console-dir-expected.txt.
  • inspector/console/console-dir-global-expected.txt: Renamed from LayoutTests/inspector/console-dir-global-expected.txt.
  • inspector/console/console-dir-global.html: Renamed from LayoutTests/inspector/console-dir-global.html.
  • inspector/console/console-dir.html: Renamed from LayoutTests/inspector/console-dir.html.
  • inspector/console/console-dirxml-expected.txt: Renamed from LayoutTests/inspector/console-dirxml-expected.txt.
  • inspector/console/console-dirxml.html: Renamed from LayoutTests/inspector/console-dirxml.html.
  • inspector/console/console-eval-expected.txt: Renamed from LayoutTests/inspector/console-eval-expected.txt.
  • inspector/console/console-eval-global-expected.txt: Renamed from LayoutTests/inspector/console-eval-global-expected.txt.
  • inspector/console/console-eval-global.html: Renamed from LayoutTests/inspector/console-eval-global.html.
  • inspector/console/console-eval.html: Renamed from LayoutTests/inspector/console-eval.html.
  • inspector/console/console-format-collections-expected.txt: Renamed from LayoutTests/inspector/console-format-collections-expected.txt.
  • inspector/console/console-format-collections.html: Renamed from LayoutTests/inspector/console-format-collections.html.
  • inspector/console/console-format-expected.txt: Renamed from LayoutTests/inspector/console-format-expected.txt.
  • inspector/console/console-format.html: Renamed from LayoutTests/inspector/console-format.html.
  • inspector/console/console-log-before-inspector-open-expected.txt: Renamed from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
  • inspector/console/console-log-before-inspector-open.html: Renamed from LayoutTests/inspector/console-log-before-inspector-open.html.
  • inspector/console/console-log-native-funcs-expected.txt: Renamed from LayoutTests/inspector/console-log-native-funcs-expected.txt.
  • inspector/console/console-log-syntax-error-expected.txt: Renamed from LayoutTests/inspector/console-log-syntax-error-expected.txt.
  • inspector/console/console-log-syntax-error.html: Renamed from LayoutTests/inspector/console-log-syntax-error.html.
  • inspector/console/console-object-constructor-name-expected.txt: Renamed from LayoutTests/inspector/console-object-constructor-name-expected.txt.
  • inspector/console/console-object-constructor-name.html: Renamed from LayoutTests/inspector/console-object-constructor-name.html.
  • inspector/console/console-substituted-expected.txt: Renamed from LayoutTests/inspector/console-substituted-expected.txt.
  • inspector/console/console-substituted.html: Renamed from LayoutTests/inspector/console-substituted.html.
  • inspector/console/console-tests-expected.txt: Renamed from LayoutTests/inspector/console-tests-expected.txt.
  • inspector/console/console-tests.html: Renamed from LayoutTests/inspector/console-tests.html.
  • inspector/console/console-trace-expected.txt: Renamed from LayoutTests/inspector/console-trace-expected.txt.
  • inspector/console/console-trace-in-eval-expected.txt: Renamed from LayoutTests/inspector/console-trace-in-eval-expected.txt.
  • inspector/console/console-trace-in-eval.html: Renamed from LayoutTests/inspector/console-trace-in-eval.html.
  • inspector/console/console-trace.html: Renamed from LayoutTests/inspector/console-trace.html.
  • inspector/console/console-uncaught-exception-expected.txt: Renamed from LayoutTests/inspector/console-uncaught-exception-expected.txt.
  • inspector/console/console-uncaught-exception-in-eval-expected.txt: Renamed from LayoutTests/inspector/console-uncaught-exception-in-eval-expected.txt.
  • inspector/console/console-uncaught-exception-in-eval.html: Renamed from LayoutTests/inspector/console-uncaught-exception-in-eval.html.
  • inspector/console/console-uncaught-exception.html: Renamed from LayoutTests/inspector/console-uncaught-exception.html.
  • inspector/console/resources/syntax-error.js: Copied from LayoutTests/inspector/resources/syntax-error.js.
  • inspector/cookie-parser.html:
  • inspector/cookie-resource-match.html:
  • inspector/cpu-profiler-profiling.html:
  • inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt: Renamed from LayoutTests/inspector/debugger-autocontinue-on-syntax-error-expected.txt.
  • inspector/debugger/debugger-autocontinue-on-syntax-error.html: Renamed from LayoutTests/inspector/debugger-autocontinue-on-syntax-error.html.
  • inspector/debugger/debugger-breakpoints-not-activated-on-reload-expected.txt: Renamed from LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload-expected.txt.
  • inspector/debugger/debugger-breakpoints-not-activated-on-reload.html: Renamed from LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html.
  • inspector/debugger/debugger-cyclic-ref-expected.txt: Renamed from LayoutTests/inspector/debugger-cyclic-ref-expected.txt.
  • inspector/debugger/debugger-cyclic-ref.html: Renamed from LayoutTests/inspector/debugger-cyclic-ref.html.
  • inspector/debugger/debugger-eval-on-call-frame-expected.txt: Renamed from LayoutTests/inspector/debugger-eval-on-call-frame-expected.txt.
  • inspector/debugger/debugger-eval-on-call-frame.html: Renamed from LayoutTests/inspector/debugger-eval-on-call-frame.html.
  • inspector/debugger/debugger-eval-while-paused-expected.txt: Renamed from LayoutTests/inspector/debugger-eval-while-paused-expected.txt.
  • inspector/debugger/debugger-eval-while-paused.html: Renamed from LayoutTests/inspector/debugger-eval-while-paused.html.
  • inspector/debugger/debugger-expand-scope-expected.txt: Renamed from LayoutTests/inspector/debugger-expand-scope-expected.txt.
  • inspector/debugger/debugger-expand-scope.html: Renamed from LayoutTests/inspector/debugger-expand-scope.html.
  • inspector/debugger/debugger-no-nested-pause-expected.txt: Renamed from LayoutTests/inspector/debugger-no-nested-pause-expected.txt.
  • inspector/debugger/debugger-no-nested-pause.html: Renamed from LayoutTests/inspector/debugger-no-nested-pause.html.
  • inspector/debugger/debugger-pause-in-eval-script-expected.txt: Renamed from LayoutTests/inspector/debugger-pause-in-eval-script-expected.txt.
  • inspector/debugger/debugger-pause-in-eval-script.html: Renamed from LayoutTests/inspector/debugger-pause-in-eval-script.html.
  • inspector/debugger/debugger-pause-on-breakpoint-expected.txt: Renamed from LayoutTests/inspector/debugger-pause-on-breakpoint-expected.txt.
  • inspector/debugger/debugger-pause-on-breakpoint.html: Renamed from LayoutTests/inspector/debugger-pause-on-breakpoint.html.
  • inspector/debugger/debugger-pause-on-debugger-statement-expected.txt: Renamed from LayoutTests/inspector/debugger-pause-on-debugger-statement-expected.txt.
  • inspector/debugger/debugger-pause-on-debugger-statement.html: Renamed from LayoutTests/inspector/debugger-pause-on-debugger-statement.html.
  • inspector/debugger/debugger-pause-on-exception-expected.txt: Renamed from LayoutTests/inspector/debugger-pause-on-exception-expected.txt.
  • inspector/debugger/debugger-pause-on-exception.html: Renamed from LayoutTests/inspector/debugger-pause-on-exception.html.
  • inspector/debugger/debugger-proto-property-expected.txt: Renamed from LayoutTests/inspector/debugger-proto-property-expected.txt.
  • inspector/debugger/debugger-proto-property.html: Renamed from LayoutTests/inspector/debugger-proto-property.html.
  • inspector/debugger/debugger-scripts-expected.txt: Renamed from LayoutTests/inspector/debugger-scripts-expected.txt.
  • inspector/debugger/debugger-scripts.html: Renamed from LayoutTests/inspector/debugger-scripts.html.
  • inspector/debugger/debugger-step-in-expected.txt: Renamed from LayoutTests/inspector/debugger-step-in-expected.txt.
  • inspector/debugger/debugger-step-in.html: Renamed from LayoutTests/inspector/debugger-step-in.html.
  • inspector/debugger/debugger-step-out-expected.txt: Renamed from LayoutTests/inspector/debugger-step-out-expected.txt.
  • inspector/debugger/debugger-step-out.html: Renamed from LayoutTests/inspector/debugger-step-out.html.
  • inspector/debugger/debugger-step-over-expected.txt: Renamed from LayoutTests/inspector/debugger-step-over-expected.txt.
  • inspector/debugger/debugger-step-over.html: Renamed from LayoutTests/inspector/debugger-step-over.html.
  • inspector/debugger/debugger-suspend-active-dom-objects-expected.txt: Renamed from LayoutTests/inspector/debugger-suspend-active-dom-objects-expected.txt.
  • inspector/debugger/debugger-suspend-active-dom-objects.html: Renamed from LayoutTests/inspector/debugger-suspend-active-dom-objects.html.
  • inspector/debugger/dom-breakpoints-expected.txt: Renamed from LayoutTests/inspector/dom-breakpoints-expected.txt.
  • inspector/debugger/dom-breakpoints.html: Renamed from LayoutTests/inspector/dom-breakpoints.html.
  • inspector/debugger/resources/syntax-error.js: Renamed from LayoutTests/inspector/resources/syntax-error.js.
  • inspector/elements/elements-delete-inline-style-expected.txt: Renamed from LayoutTests/inspector/elements-delete-inline-style-expected.txt.
  • inspector/elements/elements-delete-inline-style.html: Renamed from LayoutTests/inspector/elements-delete-inline-style.html.
  • inspector/elements/elements-img-tooltip-expected.txt: Renamed from LayoutTests/inspector/elements-img-tooltip-expected.txt.
  • inspector/elements/elements-img-tooltip.html: Renamed from LayoutTests/inspector/elements-img-tooltip.html.
  • inspector/elements/elements-panel-limited-children-expected.txt: Renamed from LayoutTests/inspector/elements-panel-limited-children-expected.txt.
  • inspector/elements/elements-panel-limited-children.html: Renamed from LayoutTests/inspector/elements-panel-limited-children.html.
  • inspector/elements/elements-panel-rewrite-href-expected.txt: Renamed from LayoutTests/inspector/elements-panel-rewrite-href-expected.txt.
  • inspector/elements/elements-panel-rewrite-href.html: Renamed from LayoutTests/inspector/elements-panel-rewrite-href.html.
  • inspector/elements/elements-panel-search-expected.txt: Renamed from LayoutTests/inspector/elements-panel-search-expected.txt.
  • inspector/elements/elements-panel-search.html: Renamed from LayoutTests/inspector/elements-panel-search.html.
  • inspector/elements/elements-panel-selection-on-refresh-expected.txt: Renamed from LayoutTests/inspector/elements-panel-selection-on-refresh-expected.txt.
  • inspector/elements/elements-panel-selection-on-refresh.html: Renamed from LayoutTests/inspector/elements-panel-selection-on-refresh.html.
  • inspector/elements/elements-panel-structure-expected.txt: Renamed from LayoutTests/inspector/elements-panel-structure-expected.txt.
  • inspector/elements/elements-panel-structure.html: Renamed from LayoutTests/inspector/elements-panel-structure.html.
  • inspector/elements/elements-panel-styles-expected.txt: Renamed from LayoutTests/inspector/elements-panel-styles-expected.txt.
  • inspector/elements/elements-panel-styles.html: Renamed from LayoutTests/inspector/elements-panel-styles.html.
  • inspector/elements/elements-panel-xhtml-structure-expected.txt: Renamed from LayoutTests/inspector/elements-panel-xhtml-structure-expected.txt.
  • inspector/elements/elements-panel-xhtml-structure.xhtml: Renamed from LayoutTests/inspector/elements-panel-xhtml-structure.xhtml.
  • inspector/elements/resources/elements-panel-styles.css: Renamed from LayoutTests/inspector/resources/elements-panel-styles.css.
  • inspector/evaluate-in-page.html:
  • inspector/extensions/extensions-api-expected.txt: Renamed from LayoutTests/inspector/extensions-api-expected.txt.
  • inspector/extensions/extensions-api.html: Renamed from LayoutTests/inspector/extensions-api.html.
  • inspector/extensions/extensions-audits-api-expected.txt: Renamed from LayoutTests/inspector/extensions-audits-api-expected.txt.
  • inspector/extensions/extensions-audits-api.html: Renamed from LayoutTests/inspector/extensions-audits-api.html.
  • inspector/extensions/extensions-audits-expected.txt: Renamed from LayoutTests/inspector/extensions-audits-expected.txt.
  • inspector/extensions/extensions-audits-tests.js: Renamed from LayoutTests/inspector/extensions-audits-tests.js.
  • inspector/extensions/extensions-audits.html: Renamed from LayoutTests/inspector/extensions-audits.html.
  • inspector/extensions/extensions-eval-expected.txt: Renamed from LayoutTests/inspector/extensions-eval-expected.txt.
  • inspector/extensions/extensions-eval.html: Renamed from LayoutTests/inspector/extensions-eval.html.
  • inspector/extensions/extensions-events-expected.txt: Renamed from LayoutTests/inspector/extensions-events-expected.txt.
  • inspector/extensions/extensions-events.html: Renamed from LayoutTests/inspector/extensions-events.html.
  • inspector/extensions/extensions-expected.txt: Renamed from LayoutTests/inspector/extensions-expected.txt.
  • inspector/extensions/extensions-resources-expected.txt: Renamed from LayoutTests/inspector/extensions-resources-expected.txt.
  • inspector/extensions/extensions-resources.html: Renamed from LayoutTests/inspector/extensions-resources.html.
  • inspector/extensions/extensions.html: Renamed from LayoutTests/inspector/extensions.html.
  • inspector/extensions/resources/Ahem.ttf: Renamed from LayoutTests/inspector/resources/Ahem.ttf.
  • inspector/extensions/resources/abe.png: Renamed from LayoutTests/inspector/resources/abe.png.
  • inspector/extensions/resources/audits-style1.css: Renamed from LayoutTests/inspector/resources/audits-style1.css.
  • inspector/inspected-objects-not-overriden.html:
  • inspector/report-API-errors.html:
  • inspector/report-protocol-errors.html:
  • inspector/storage-panel-dom-storage.html:
  • inspector/styles/resources/styles-iframe-data.html: Renamed from LayoutTests/inspector/resources/styles-iframe-data.html.
  • inspector/styles/resources/styles-new-API-1.css: Renamed from LayoutTests/inspector/resources/styles-new-API-1.css.
  • inspector/styles/resources/styles-new-API.css: Renamed from LayoutTests/inspector/resources/styles-new-API.css.
  • inspector/styles/resources/styles-source-lines-inline-iframe.html: Renamed from LayoutTests/inspector/resources/styles-source-lines-inline-iframe.html.
  • inspector/styles/resources/styles-source-offsets.css: Renamed from LayoutTests/inspector/resources/styles-source-offsets.css.
  • inspector/styles/resources/styles-url-linkify-iframe.html: Renamed from LayoutTests/inspector/resources/styles-url-linkify-iframe.html.
  • inspector/styles/resources/styles-url-linkify.css: Renamed from LayoutTests/inspector/resources/styles-url-linkify.css.
  • inspector/styles/styles-add-blank-property-expected.txt: Renamed from LayoutTests/inspector/styles-add-blank-property-expected.txt.
  • inspector/styles/styles-add-blank-property.html: Renamed from LayoutTests/inspector/styles-add-blank-property.html.
  • inspector/styles/styles-computed-trace-expected.txt: Renamed from LayoutTests/inspector/styles-computed-trace-expected.txt.
  • inspector/styles/styles-computed-trace.html: Renamed from LayoutTests/inspector/styles-computed-trace.html.
  • inspector/styles/styles-disable-inherited-expected.txt: Renamed from LayoutTests/inspector/styles-disable-inherited-expected.txt.
  • inspector/styles/styles-disable-inherited.html: Renamed from LayoutTests/inspector/styles-disable-inherited.html.
  • inspector/styles/styles-disable-then-change-expected.txt: Renamed from LayoutTests/inspector/styles-disable-then-change-expected.txt.
  • inspector/styles/styles-disable-then-change.html: Renamed from LayoutTests/inspector/styles-disable-then-change.html.
  • inspector/styles/styles-disable-then-delete-expected.txt: Renamed from LayoutTests/inspector/styles-disable-then-delete-expected.txt.
  • inspector/styles/styles-disable-then-delete.html: Renamed from LayoutTests/inspector/styles-disable-then-delete.html.
  • inspector/styles/styles-disable-then-enable-expected.txt: Renamed from LayoutTests/inspector/styles-disable-then-enable-expected.txt.
  • inspector/styles/styles-disable-then-enable.html: Renamed from LayoutTests/inspector/styles-disable-then-enable.html.
  • inspector/styles/styles-iframe-expected.txt: Renamed from LayoutTests/inspector/styles-iframe-expected.txt.
  • inspector/styles/styles-iframe.html: Renamed from LayoutTests/inspector/styles-iframe.html.
  • inspector/styles/styles-new-API-expected.txt: Renamed from LayoutTests/inspector/styles-new-API-expected.txt.
  • inspector/styles/styles-new-API.html: Renamed from LayoutTests/inspector/styles-new-API.html.
  • inspector/styles/styles-source-lines-expected.txt: Renamed from LayoutTests/inspector/styles-source-lines-expected.txt.
  • inspector/styles/styles-source-lines-inline-expected.txt: Renamed from LayoutTests/inspector/styles-source-lines-inline-expected.txt.
  • inspector/styles/styles-source-lines-inline.html: Renamed from LayoutTests/inspector/styles-source-lines-inline.html.
  • inspector/styles/styles-source-lines.html: Renamed from LayoutTests/inspector/styles-source-lines.html.
  • inspector/styles/styles-source-offsets-expected.txt: Renamed from LayoutTests/inspector/styles-source-offsets-expected.txt.
  • inspector/styles/styles-source-offsets.html: Renamed from LayoutTests/inspector/styles-source-offsets.html.
  • inspector/styles/styles-url-linkify-expected.txt: Renamed from LayoutTests/inspector/styles-url-linkify-expected.txt.
  • inspector/styles/styles-url-linkify.html: Renamed from LayoutTests/inspector/styles-url-linkify.html.
  • inspector/syntax-highlight-css.html:
  • inspector/syntax-highlight-html.html:
  • inspector/syntax-highlight-javascript.html:
  • inspector/timeline/resources/timeline-iframe-data.html: Renamed from LayoutTests/inspector/resources/timeline-iframe-data.html.
  • inspector/timeline/timeline-enum-stability-expected.txt: Renamed from LayoutTests/inspector/timeline-enum-stability-expected.txt.
  • inspector/timeline/timeline-enum-stability.html: Renamed from LayoutTests/inspector/timeline-enum-stability.html.
  • inspector/timeline/timeline-event-dispatch-expected.txt: Renamed from LayoutTests/inspector/timeline-event-dispatch-expected.txt.
  • inspector/timeline/timeline-event-dispatch.html: Renamed from LayoutTests/inspector/timeline-event-dispatch.html.
  • inspector/timeline/timeline-layout-expected.txt: Renamed from LayoutTests/inspector/timeline-layout-expected.txt.
  • inspector/timeline/timeline-layout.html: Renamed from LayoutTests/inspector/timeline-layout.html.
  • inspector/timeline/timeline-mark-timeline-expected.txt: Renamed from LayoutTests/inspector/timeline-mark-timeline-expected.txt.
  • inspector/timeline/timeline-mark-timeline.html: Renamed from LayoutTests/inspector/timeline-mark-timeline.html.
  • inspector/timeline/timeline-network-resource-expected.txt: Renamed from LayoutTests/inspector/timeline-network-resource-expected.txt.
  • inspector/timeline/timeline-network-resource.html: Renamed from LayoutTests/inspector/timeline-network-resource.html.
  • inspector/timeline/timeline-network-resource.js: Renamed from LayoutTests/inspector/timeline-network-resource.js.
  • inspector/timeline/timeline-paint-expected.txt: Renamed from LayoutTests/inspector/timeline-paint-expected.txt.
  • inspector/timeline/timeline-paint.html: Renamed from LayoutTests/inspector/timeline-paint.html.
  • inspector/timeline/timeline-parse-html-expected.txt: Renamed from LayoutTests/inspector/timeline-parse-html-expected.txt.
  • inspector/timeline/timeline-parse-html.html: Renamed from LayoutTests/inspector/timeline-parse-html.html.
  • inspector/timeline/timeline-recalculate-styles-expected.txt: Renamed from LayoutTests/inspector/timeline-recalculate-styles-expected.txt.
  • inspector/timeline/timeline-recalculate-styles.html: Renamed from LayoutTests/inspector/timeline-recalculate-styles.html.
  • inspector/timeline/timeline-script-tag-1-expected.txt: Renamed from LayoutTests/inspector/timeline-script-tag-1-expected.txt.
  • inspector/timeline/timeline-script-tag-1.html: Renamed from LayoutTests/inspector/timeline-script-tag-1.html.
  • inspector/timeline/timeline-script-tag-2-expected.txt: Renamed from LayoutTests/inspector/timeline-script-tag-2-expected.txt.
  • inspector/timeline/timeline-script-tag-2.html: Renamed from LayoutTests/inspector/timeline-script-tag-2.html.
  • inspector/timeline/timeline-script-tag-2.js: Renamed from LayoutTests/inspector/timeline-script-tag-2.js.
  • inspector/timeline/timeline-test.js: Renamed from LayoutTests/inspector/timeline-test.js.
  • inspector/timeline/timeline-trivial-expected.txt: Renamed from LayoutTests/inspector/timeline-trivial-expected.txt.
  • inspector/timeline/timeline-trivial.html: Renamed from LayoutTests/inspector/timeline-trivial.html.
  • platform/chromium/inspector/console/console-dir-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-dir-expected.txt.
  • platform/chromium/inspector/console/console-dir-global-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-dir-global-expected.txt.
  • platform/chromium/inspector/console/console-eval-global-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-eval-global-expected.txt.
  • platform/chromium/inspector/console/console-format-collections-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-format-collections-expected.txt.
  • platform/chromium/inspector/console/console-format-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-format-expected.txt.
  • platform/chromium/inspector/console/console-log-native-funcs-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-log-native-funcs-expected.txt.
  • platform/chromium/inspector/console/console-log-syntax-error-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-log-syntax-error-expected.txt.
  • platform/chromium/inspector/console/console-object-constructor-name-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-object-constructor-name-expected.txt.
  • platform/chromium/inspector/console/console-trace-in-eval-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-trace-in-eval-expected.txt.
  • platform/chromium/inspector/console/console-uncaught-exception-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-uncaught-exception-expected.txt.
  • platform/chromium/inspector/console/console-uncaught-exception-in-eval-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt.
  • platform/chromium/inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger-autocontinue-on-syntax-error-expected.txt.
  • platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger-expand-scope-expected.txt.
  • platform/chromium/inspector/debugger/debugger-pause-on-exception-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger-pause-on-exception-expected.txt.
  • platform/chromium/inspector/debugger/debugger-step-in-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger-step-in-expected.txt.
  • platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-event-dispatch-expected.txt.
  • platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-mark-timeline-expected.txt.
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-network-resource-expected.txt.
  • platform/chromium/inspector/timeline/timeline-paint-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-paint-expected.txt.
  • platform/chromium/inspector/timeline/timeline-parse-html-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-parse-html-expected.txt.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
1:57 AM Changeset in webkit [78534] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-02-15 MORITA Hajime <morrita@google.com>

Unreviewed build fix.

  • page/EditorClient.h: Changed GrammarDetail forward declaration from class to struct.
12:28 AM Changeset in webkit [78533] by morrita@google.com
  • 38 edits
    1 add in trunk/Source

2011-01-26 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213

Created new abstract class TextCheckerClient. The class has
spellcheck related API which is split.
This is the first step for sharing spell-checking codebase
between ports. A standalone TextCheckerClient implementation
should be done in future changes.

No new tests. No behavioral change.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (AXAttributeStringSetSpelling):
  • editing/Editor.cpp: Replacing some client() call with textChecker(). (WebCore::Editor::textChecker): Added. (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::Editor::isSelectionMisspelled): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::correctionPanelTimerFired):
  • editing/Editor.h:
  • editing/SpellChecker.cpp: (WebCore::SpellChecker::SpellChecker):
  • editing/TextCheckingHelper.cpp: Replacing some client() call with textChecker(). (WebCore::TextCheckingHelper::findFirstMisspelling): (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): (WebCore::TextCheckingHelper::findFirstBadGrammar): (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
  • loader/EmptyClients.h: Added EmptyTextCheckerClient. (WebCore::EmptyTextCheckerClient::ignoreWordInSpellDocument): (WebCore::EmptyTextCheckerClient::learnWord): (WebCore::EmptyTextCheckerClient::checkSpellingOfString): (WebCore::EmptyTextCheckerClient::getAutoCorrectSuggestionForMisspelledWord): (WebCore::EmptyTextCheckerClient::checkGrammarOfString): (WebCore::EmptyTextCheckerClient::checkTextOfParagraph): (WebCore::EmptyTextCheckerClient::getGuessesForWord): (WebCore::EmptyTextCheckerClient::requestCheckingOfString): (WebCore::EmptyEditorClient::textChecker):
  • page/EditorClient.h: Extracted TextCheckerClient.
  • page/Page.h:
  • platform/text/TextCheckerClient.h: Added. (WebCore::TextCheckerClient::~TextCheckerClient):

2011-01-26 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213

  • src/EditorClientImpl.h: (WebKit::EditorClientImpl::textChecker):

2011-01-26 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213

  • WebCoreSupport/EditorClientEfl.h: (WebCore::EditorClientEfl::textChecker):

2011-01-26 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213

  • WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::textChecker):

2011-01-26 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213

  • WebCoreSupport/EditorClientHaiku.h: (WebCore::EditorClientHaiku::textChecker):

2011-01-26 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213

  • WebCoreSupport/WebEditorClient.h: (WebEditorClient::textChecker):

2011-01-26 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213

  • WebCoreSupport/EditorClientQt.h: (WebCore::EditorClientQt::textChecker):

2011-01-26 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213

  • WebCoreSupport/WebEditorClient.h: (WebEditorClient::textChecker):

2011-01-26 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213

  • WebCoreSupport/EditorClientWinCE.h: (WebKit::EditorClientWinCE::textChecker):

2011-01-26 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213

  • WebKitSupport/EditorClientWx.h: (WebCore::EditorClientWx::textChecker):

2011-01-26 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/TextChecker.h:
  • WebProcess/WebCoreSupport/WebEditorClient.h: (WebKit::WebEditorClient::textChecker):
  • Scripts/webkit2/messages.py: Re-arranged the include file
12:21 AM Changeset in webkit [78532] by rniwa@webkit.org
  • 34 edits in trunk/Source

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417

Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::canCopyCut): Added. (WebKit::EditorClientImpl::canPaste): Added.
  • src/EditorClientImpl.h:

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417

Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::canCopyCut): Added. (WebCore::EditorClientQt::canPaste): Added.
  • WebCoreSupport/EditorClientQt.h:

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417

Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::canCopyCut): Added. (WebKit::EditorClient::canPaste): Added.
  • WebCoreSupport/EditorClientGtk.h:

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417

Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.

  • WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::canCopyCut): Added. (WebEditorClient::canPaste): Added.
  • WebCoreSupport/WebEditorClient.h:

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417

Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.

  • WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::canCopyCut): Added. (WebCore::EditorClientWx::canPaste): Added.
  • WebKitSupport/EditorClientWx.h:

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417

Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::canCopyCut): Added. (WebEditorClient::canPaste): Added.

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417

Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::canCopyCut): Added. (WebCore::EditorClientHaiku::canPaste): Added.
  • WebCoreSupport/EditorClientHaiku.h:

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417

Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.

  • WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::canCopyCut): Added. (WebKit::EditorClientWinCE::canPaste): Added.
  • WebCoreSupport/EditorClientWinCE.h:

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417

Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::canCopyCut): Added. (WebCore::EditorClientEfl::canPaste): Added.
  • WebCoreSupport/EditorClientEfl.h:

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417

Added two callback functions, canCopyCut and canPaste to EditorClient. These functions
returns true iff the current frame should be able to copy/cut and paste respectively.
They take the default value determined by isDOMPasteAllowed and javaScriptCanAccessClipboard.

These callbacks allows embedders to decide whether or not copy/cut/paste should be enabled
per frame and thus per origin rather than per page.

No new tests are added since this is a WebKit/WebCore interface change.

  • editing/EditorCommand.cpp: (WebCore::supportedCopyCut): Calls canCopyCut. (WebCore::supportedPaste): Calls canPaste.
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::canCopyCut): Added. (WebCore::EmptyEditorClient::canPaste): Added.
  • page/EditorClient.h:

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417

Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::canCopyCut): Added. (WebKit::WebEditorClient::canPaste): Added.
  • WebProcess/WebCoreSupport/WebEditorClient.h:

Feb 14, 2011:

9:53 PM Changeset in webkit [78531] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

allow for modifying comments without the mouse
https://bugs.webkit.org/show_bug.cgi?id=54433

Use n/p to navigate the comments.
Enter to begin editing a comment.
Escape to finish editing a comment.

  • code-review.js:
9:46 PM Changeset in webkit [78530] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

improve line selection in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=54430

-shift+click now extends the comment context
-selecting outside of a diff section no longer clears the selected lines.

Instead it just restricts the selected lines to that diff section.

  • code-review.js:
7:04 PM WebKit Team edited by kalman@chromium.org
Add myself to committers list (diff)
6:30 PM Changeset in webkit [78529] by mihaip@chromium.org
  • 10 edits in branches/chromium/648/Source/WebCore

Roll out r74807 (in the 648 branch only).

BUG=68516
TBR=kerz@chromium.org

6:23 PM Changeset in webkit [78528] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix minor regression introduced in r78522. For some reason, Python
provides a platform.mac_ver() routine on Linux, so we need to
check to make sure it's returning something in addition to
checking for its existence.

  • Scripts/webkitpy/layout_tests/port/mac.py:
5:49 PM Changeset in webkit [78527] by jorlow@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Jeremy Orlow <jorlow@chromium.org>

efl build fix

  • CMakeLists.txt:
5:38 PM Changeset in webkit [78526] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-02-14 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add WKPageSetMemoryCacheClientCallsEnabled API
https://bugs.webkit.org/show_bug.cgi?id=54422

  • UIProcess/API/C/WKPage.cpp: (WKPageSetMemoryCacheClientCallsEnabled):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled):
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setMemoryCacheMessagesEnabled):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
5:18 PM Changeset in webkit [78525] by jorlow@chromium.org
  • 81 edits
    2 moves
    11 deletes in trunk

2011-02-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up implementing the new event model in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=54331

Make the requried changes + s/result/request/g (where it should
have always been that way) + remove the verify functions (since
these days they mostly just add noise) + get rid of the callback
in the delete object store funciton.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/resources/shared.js: (unexpectedSuccessCallback): (unexpectedErrorCallback): (unexpectedAbortCallback): (unexpectedCompleteCallback): (evalAndExpectException): (deleteAllObjectStores):
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only-expected.txt:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/tutorial.html:

2011-02-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up implementing the new event model in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=54331

We shouldn't have our own event subclasses. Instead, we
should just fire Event's with the proper type and bubble
settings. All the attributes on the events before should
just be on the request. IDBRequest should throw if they're
accessed before the success event fires.

  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Event.cpp:
  • dom/Event.h:
  • page/DOMWindow.idl:
  • storage/IDBAbortEvent.h: Removed.
  • storage/IDBCompleteEvent.cpp: Removed.
  • storage/IDBCompleteEvent.h: Removed.
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::~IDBDatabase):
  • storage/IDBDatabaseException.h:
  • storage/IDBDatabaseException.idl:
  • storage/IDBErrorEvent.cpp: Removed.
  • storage/IDBErrorEvent.h: Removed.
  • storage/IDBErrorEvent.idl: Removed.
  • storage/IDBEvent.h: Removed.
  • storage/IDBEvent.idl: Removed.
  • storage/IDBEventDispatcher.cpp: (WebCore::IDBEventDispatcher::dispatch):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::result): (WebCore::IDBRequest::errorCode): (WebCore::IDBRequest::webkitErrorMessage): (WebCore::IDBRequest::source): (WebCore::IDBRequest::transaction): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onError): (WebCore::createSuccessEvent): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBRequest.h:
  • storage/IDBRequest.idl:
  • storage/IDBSuccessEvent.cpp: Removed.
  • storage/IDBSuccessEvent.h: Removed.
  • storage/IDBSuccessEvent.idl: Removed.
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete): (WebCore::IDBTransaction::dispatchEvent):
5:14 PM Changeset in webkit [78524] by kalman@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed. Add myself to the list of committers.

4:03 PM Changeset in webkit [78523] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: View not updated completely when coming back from a cached back/forward navigation
<rdar://problem/8787264>
https://bugs.webkit.org/show_bug.cgi?id=54419

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::restoreViewState): Invalidate the entire page
when completing a restore from the back/forward cache.

4:03 PM Changeset in webkit [78522] by dpranke@chromium.org
  • 16 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Clean up the way we handle platform names in
new-run-webkit-tests. Previously, if you specified
'--platform mac' or '--platform chromium-mac' on the command
line, it would use that platform name to determine baseline search
paths, etc. This is almost never the right thing to do, because
it ignores the existence of version-specific baselines.

So, I changed this so that ports that support versions must
always use a version, and the version should default to the
version of the operating system that the port is being run on
(e.g., if you're running on Leopard, then passing '--platform
mac' will default to the 'mac-leopard' port). This means that
port.name() should always include a version-specific suffix if
the port supports versions.

However, we still support things like '--platform mac' as input
so that the user doesn't have to explicitly specify a version,
both for convenience and so we don't have to make buildbot
configs more complicated than they already are.

Also, I cleaned up how the baselines were being searched
on the chromium-mac port (this is one of the two bugs that
prompted this refactoring), and made the logic easier to follow
and more consistent across the mac and chromium ports

Lastly, I added a port.get_all_names() method that could be used
to get the names of all of the ports to search, rather than having
to guess (incorrectly) from the list of directories under
LayoutTests/platform (this last thing was necessary because the
deduplicate_tests unittest broke as the fallback dirs changed).

https://bugs.webkit.org/show_bug.cgi?id=54248

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
4:01 PM Changeset in webkit [78521] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

https://bugs.webkit.org/show_bug.cgi?id=54418
Fix a Linux expectation, mark another test as expected-failing.

  • platform/chromium/test_expectations.txt:
3:59 PM Changeset in webkit [78520] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

update-webkit hangs in a git-only checkout

Previously it would hang forever trying to do a 'git svn
rebase'. Now, it will default to a 'git pull' if the
svn-remote.svn.fetch variable isn't set, and bail out if it
doesn't know where to pull from.

https://bugs.webkit.org/show_bug.cgi?id=54265

  • Scripts/update-webkit:
  • Scripts/VCSUtils.pm:
3:51 PM Changeset in webkit [78519] by alex
  • 2 edits in trunk/Source/WebKit/gtk

2011-02-14 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] testwebdatasource test fails in the bots
https://bugs.webkit.org/show_bug.cgi?id=54414

Changed the uri we check, added www to avoid the rewrite that we
get when we as the uri to the request in case it finishes.

  • tests/testwebdatasource.c: (notify_load_status_cb):
3:46 PM Changeset in webkit [78518] by alex
  • 10 edits in trunk/LayoutTests

2011-02-14 Alejandro G. Castro <alex@igalia.com>

Unreviewed, rolling out r78516.
http://trac.webkit.org/changeset/78516

The rebaseline was previously done

  • platform/gtk/fast/css/rtl-ordering-expected.checksum:
  • platform/gtk/fast/css/rtl-ordering-expected.png:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
3:35 PM Changeset in webkit [78517] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Copy/paste from a WebKit window to a TextEdit window loses fonts.
<rdar://problem/8623090>
https://bugs.webkit.org/show_bug.cgi?id=54416

Reviewed by Dan Bernstein.

We don't have the complete solution that fixes this problem for WebKit2 yet.
This patch fixes the regression in WebKit.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): For WebKit2 use only plain text,
for WebKit use the original API to create the NSAttributedString.

3:29 PM Changeset in webkit [78516] by alex
  • 10 edits in trunk/LayoutTests

2011-02-14 Alejandro G. Castro <alex@igalia.com>

Unreviewed. Rebaseline GTK test results after r78491.

  • platform/gtk/fast/css/rtl-ordering-expected.checksum:
  • platform/gtk/fast/css/rtl-ordering-expected.png:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
3:15 PM Changeset in webkit [78515] by leviw@chromium.org
  • 17 edits
    3 adds in trunk

2011-02-14 Levi Weintraub <leviw@chromium.org>

Reviewed by Alexey Proskuryakov.

Strikethrough disappears when posting a message on odnoklassniki.ru
https://bugs.webkit.org/show_bug.cgi?id=53475

Changing the behavior of the strikethrough execCommand when styleWithCSS
is false. We formerly created <s> tags, which was different than both IE
and FF and caused problems with some rich text editors that would strip
out unexpected tags such as <s>.

Test: editing/execCommand/strikethrough-uses-strike-tag.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

2011-02-14 Levi Weintraub <leviw@chromium.org>

Reviewed by Alexey Proskuryakov.

Strikethrough disappears when posting a message on odnoklassniki.ru
https://bugs.webkit.org/show_bug.cgi?id=53475

Updating test expectations and creating a test in an attempt to prevent the
uninformed WebKit dev from switching back to using <s> tags for strikethrough.
As explained in the bug, this is bad for compatibility with various rich text
editors.

  • editing/execCommand/query-text-decoration-with-typing-style-expected.txt:
  • editing/execCommand/script-tests/strikethrough-uses-strike-tag.js: Added. (test):
  • editing/execCommand/script-tests/toggle-style-2.js:
  • editing/execCommand/strikethrough-uses-strike-tag-expected.txt: Added.
  • editing/execCommand/strikethrough-uses-strike-tag.html: Added.
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/execCommand/toggle-style-2-expected.txt:
  • editing/style/inline-style-container-expected.txt:
  • editing/style/inline-style-extend-run-expected.txt:
  • editing/style/push-down-implicit-styles-around-list-expected.txt:
  • editing/style/push-down-implicit-styles-expected.txt:
  • editing/style/script-tests/inline-style-container.js:
  • editing/style/script-tests/inline-style-extend-run.js:
  • editing/style/script-tests/push-down-implicit-styles-around-list.js:
  • editing/style/script-tests/push-down-implicit-styles.js:
  • editing/style/style-text-node-without-editable-parent-expected.txt:
3:02 PM Changeset in webkit [78514] by enrica@apple.com
  • 1 edit in trunk/Source/WebCore/WebCore.exp.in

Build fix. Unreviewed.

3:01 PM Changeset in webkit [78513] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-14 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Shared memory should be made shared immediately
https://bugs.webkit.org/show_bug.cgi?id=54413
<rdar://problem/8972153>

Under some circumstances, mach_make_memory_entry_64 may only return parts of a
memory allocation. Work around this by creating a mach port representing the shared memory
right away. Also, hand out this mach port in createHandle when using the default memory protection.

  • Platform/SharedMemory.h:
  • Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::create): (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle):
2:58 PM Changeset in webkit [78512] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

This patch modifies NRWT's Worker clas to use the new
WorkerMixin class to actually run tests. With this patch, the
multiprocess version of NRWT is fully functional and just needs
the values for --worker-model and --child-processes to be corrected
in the port/* classes to start using the new code by default.

https://bugs.webkit.org/show_bug.cgi?id=54082

  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
2:56 PM Changeset in webkit [78511] by dpranke@chromium.org
  • 3 edits
    1 add in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

This patch shuffles code out of dump_render_tree_thread and
single_test_runner and into a new worker_mixin class that will
be shared by both TestShellThread and Worker. This change
restores single_test_runner to its state as of r77606 - it is
stateless again. It also prunes TestShellThread to pretty much
just the logic used for the original shared-memory access.

https://bugs.webkit.org/show_bug.cgi?id=54079

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Added.
2:56 PM Changeset in webkit [78510] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

Try using the right syntax this time.

  • platform/chromium/test_expectations.txt:
2:26 PM Changeset in webkit [78509] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
2:20 PM Changeset in webkit [78508] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Remove dead code in FormDataStreamCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54401

Reviewed by Darin Adler.

The static functions in this file are no longer reachable. We added a conditional branch to
use new CFNetwork functions in r30329 and later made that code path permanent in r41517
which made these functions unreachable.

  • platform/network/cf/FormDataStreamCFNet.cpp:
2:15 PM Changeset in webkit [78507] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

This patch updates NRWT to add per-worker and per-shard test stats
into TestRunner2, bringing it to parity with TestRunner.

https://bugs.webkit.org/show_bug.cgi?id=54074

  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2:13 PM Changeset in webkit [78506] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt multiprocessing: add code to handle interrupts and wedged
threads.
https://bugs.webkit.org/show_bug.cgi?id=54072

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Adds the cancel(), is_alive(), join(), and log_wedged_worker() methods to the WorkerConnection class
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py: Adds the cancel() method to the Worker class
2:08 PM Changeset in webkit [78505] by pkasting@chromium.org
  • 2 edits in branches/chromium/648/Source/WebCore

Merge 78431 - Some Scrollbar functions assume an attached ScrollableArea but can be called without one
https://bugs.webkit.org/show_bug.cgi?id=54262

Reviewed by Dan Bernstein.

Make sure that all calls to the scrollable area are null checked.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):

TBR=weinig@apple.com
Review URL: http://codereview.chromium.org/6523001

1:55 PM Changeset in webkit [78504] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

https://bugs.webkit.org/show_bug.cgi?id=54409
Mark tests as failing due to r78484.

  • platform/chromium/test_expectations.txt:
1:54 PM Changeset in webkit [78503] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-02-14 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

GraphicsContext: Add clip(IntRect) overload for Qt
https://bugs.webkit.org/show_bug.cgi?id=54365

Qt has special code paths for clipping to integer rectangles.
Add a GraphicsContext::clip() overload to allow us to take
advantage of the optimized code.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::clip):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clip):
1:48 PM Changeset in webkit [78502] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

update the NRWT multiprocessing code to spawn multiple workers
instead of just using one.

https://bugs.webkit.org/show_bug.cgi?id=54071

  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1:44 PM QtWebKit edited by andreas.kling@nokia.com
(diff)
1:29 PM Changeset in webkit [78501] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Some MarkedBlock refactoring.

Rubber-stamped by Gavin Barraclough.

Made cells private.

Renamed cells => m_cells

marked => m_marks.

  • runtime/JSCell.h:

(JSC::JSCell::MarkedBlock::allocate):

  • runtime/MarkedBlock.cpp:

(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::sweep):

  • runtime/MarkedBlock.h:

(JSC::MarkedBlock::isEmpty):
(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::markCount):
(JSC::MarkedBlock::isMarked):
(JSC::MarkedBlock::testAndSetMarked):
(JSC::MarkedBlock::setMarked):
(JSC::MarkedBlock::forEach):

1:28 PM Webkit2Innards edited by siddharth.mathur@nokia.com
(diff)
1:27 PM Changeset in webkit [78500] by xji@chromium.org
  • 10 edits in trunk/LayoutTests

2011-02-14 Xiaomei Ji <xji@chromium.org>

Unreviewed.
Rebaseline after r78491. Since select-visual-hebrew.html and visual-hebrew-text-field.html
are marked as FAIL in Chromium WIN and LINUX, rebaseline for them are done manually and
only changed the part related to r78491.

  • platform/chromium-linux/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.txt:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/chromium-win/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-win/fast/forms/select-visual-hebrew-expected.txt:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
1:23 PM Changeset in webkit [78499] by Darin Adler
  • 6 edits in trunk/Source/WebCore

2011-02-14 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898

Covered by existing tests; not adding new tests at this time.

This patch now handles errors in the same way the existing codecs do,
and so passes our tests. The first version failed some tests because
of incorrect error handling. The second version was missing one line
of code that made it decode incomplete sequences at the end of the
buffer twice.

  • platform/text/TextCodecICU.cpp: (WebCore::create): Renamed from newTextCodecICU, made a static member function, and added a call to adoptPtr. (WebCore::TextCodecICU::registerEncodingNames): Renamed from registerExtendedEncodingNames since this class is no longer used for base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8. (WebCore::TextCodecICU::registerCodecs): Renamed. (WebCore::fallbackForGBK): Renamed to conform to our current style.
  • platform/text/TextCodecICU.h: Updated for above changes. Changed indentation. Made most functions private, including virtual function overrides. Marked ICUConverterWrapper noncopyable.
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases that were formerly added by TextCodecICU. (WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for bytes F5-FF instead of failing. (WebCore::decodeNonASCIISequence): Tweaked coding style. (WebCore::appendCharacter): Added. Makes it easier to share code between the partial-character handling and main loop. (WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case where there is a partial sequence. Fixed partial sequence handling so that goto is no longer needed, since compilers sometimes make poor code when goto is involved. Added a loop for partial sequences since we consume only one byte when a partial sequence is invalid. Fixed logic in main decoding loop so goto is not needed. Used early-exit style in both loops so the main flow is not nested inside if statements. Added correct error handling for flush when a partial sequence remains, which involved wrapping the function in yet another loop.
  • platform/text/TextCodecUTF8.h: Made virtual function overrides private.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed calls to TextCodecICU. Added FIXMEs for other codecs that no longer need to be included here. (WebCore::extendTextCodecMaps): Updated for the name change of the TextCodecICU functions.
1:13 PM Changeset in webkit [78498] by bweinstein@apple.com
  • 5 edits in trunk/Source/WebKit/win

Need WebKit API to determine whether we have a site icon for a given URL
https://bugs.webkit.org/show_bug.cgi?id=54400

Reviewed by Brady Eidson.

This patch implements IWebIconDatabase::hasIconForURL which tells us whether or not
we have a site icon for the given URL.

  • Interfaces/IWebIconDatabase.idl: Added new function.
  • Interfaces/WebKit.idl: Touched to make sure Interfaces rebuilds.
  • WebIconDatabase.cpp:

(WebIconDatabase::hasIconForURL): Call IconDatabase::iconForPageURL to make sure we

load the icon from disk, and call iconURLForPageURL to determine whether or not
we actually have an icon.

  • WebIconDatabase.h:
12:48 PM Changeset in webkit [78497] by abarth@webkit.org
  • 5 edits in trunk/Source

2011-02-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add basic parser for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54379

Add a constructor for copying a Vector into a String. I suspect there
are a number of call sites that are doing this manually that would
benefit from being moved to this API.

  • wtf/text/WTFString.h: (WTF::String::String):

2011-02-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add basic parser for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54379

The parser in this patch is very basic. It just segments the CSP
header into directives. The exactly syntax will likely change a bit as
we discuss the details in public-web-security, but this parser will
allow us to make progress.

Sadly, this patch does not contain any tests. That's because CSP
policies do not have any observable effects yet. Hopefully we'll get
enough sketched out in the next couple patches to begin writing tests.

  • page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::CSPDirective::name): (WebCore::CSPDirective::value): (WebCore::ContentSecurityPolicy::~ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::parse):
  • page/ContentSecurityPolicy.h:
12:19 PM Webkit2Innards edited by siddharth.mathur@nokia.com
(diff)
12:03 PM Changeset in webkit [78496] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-14 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium test expectations, missed a test
in my last checkin.

  • platform/chromium/test_expectations.txt:
11:48 AM Changeset in webkit [78495] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebCore

2011-02-14 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Kenneth Russell.

[Qt] WebKit fails to compile for Qt when WebGL enabled
https://bugs.webkit.org/show_bug.cgi?id=53431

No new tests.

  • WebCore.pro: Add source and header files and include directory to Qt project.
  • html/canvas/WebGLRenderingContext.cpp: File uses 'emit' which is a Qt keyword - #undef emit.
  • platform/graphics/gpu/qt: Added.
  • platform/graphics/gpu/qt/DrawingBufferQt.cpp: Added. Partial implementation of DrawingBuffer for Qt. (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::didReset): (WebCore::DrawingBuffer::platformLayer): (WebCore::DrawingBuffer::platformColorBuffer):
  • platform/graphics/qt/Extensions3DQt.cpp: Noop implementation for pure virtual methods added to Extensions3D.h (WebCore::Extensions3DQt::blitFramebuffer): (WebCore::Extensions3DQt::renderbufferStorageMultisample):
  • platform/graphics/qt/Extensions3DQt.h: Declare new methods added to Extensions3D.h
  • platform/graphics/qt/GraphicsContext3DQt.cpp: Remove method implementations no longer in GraphicsContext3D.h. Change m_syntheticErrors to use unsigned int to match new GC3Denum type. (WebCore::GraphicsContext3D::create): Change return type to match GraphicsContext3D.h (WebCore::GraphicsContext3D::lineWidth): Change argument type to GC3Dfloat to match GraphicsContext3D.h (WebCore::GraphicsContext3D::getUniformLocation): Change return type to GC3Dfloat to match GraphicsContext3D.h (WebCore::GraphicsContext3D::getExtensions): Need to call get() on OwnPtr. (WebCore::GraphicsContext3D::getImageData): Rename enum values to match declarations in GraphicsContext3D.h
11:45 AM Changeset in webkit [78494] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-02-14 Jay Soffian <jaysoffian@gmail.com>

Reviewed by Darin Fisher.

Expose checked field of HTMLInputElement to Chromium API
https://bugs.webkit.org/show_bug.cgi?id=54333

  • public/WebInputElement.h:
  • src/WebInputElement.cpp:
11:40 AM Changeset in webkit [78493] by tony@chromium.org
  • 8 edits in trunk

2011-02-14 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

<select> elements don't honor border:0px in chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=51152

No new tests, covered by existing pixel results (fast/forms/basic-selects.html
convers lots of cases).

2011-02-14 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

<select> elements don't honor border:0px in chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=51152

  • public/linux/WebThemeEngine.h:
  • src/PlatformBridge.cpp: (WebCore::GetWebThemeExtraParams):
11:25 AM Changeset in webkit [78492] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium test expectations update.

http://code.google.com/p/v8/issues/detail?id=1154
Temporarily mark a test as failing due to a new V8 version.

  • platform/chromium/test_expectations.txt:
11:21 AM Changeset in webkit [78491] by xji@chromium.org
  • 7 edits
    2 adds in trunk

2011-02-14 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix rendering of ISO-8859-8 when dir="rtl".
https://bugs.webkit.org/show_bug.cgi?id=52128

Test: fast/text/international/iso-8859-8.html

  • platform/text/BidiResolver.h: Add VisualDirectionOverride enum. (WebCore::::createBidiRunsForLine): For lines with visual direction override, create bidi runs without resolving bidi levels (one run per render object), set bidi level as 0 or 1 depending on LTR or RTL override, and reverse runs for RTL override.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::constructLine): Set inline box bidi level the same as BidiRun's bidi level without special handling of VisualDirectionOverride. (WebCore::RenderBlock::layoutInlineChildren): Pass in VisualDirectionOverride to createBidiRunsForLine().

2011-02-14 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix rendering of ISO-8859-8 when dir="rtl".
https://bugs.webkit.org/show_bug.cgi?id=52128

  • fast/text/international/iso-8859-8-expected.txt: Added.
  • fast/text/international/iso-8859-8.html: Added.
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/forms/select-visual-hebrew-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
11:02 AM Webkit2Innards edited by siddharth.mathur@nokia.com
(diff)
10:52 AM Changeset in webkit [78490] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-02-14 Alexis Menard <alexis.menard@nokia.com>

Reviewed by Andreas Kling.

[Qt] Crash on application exit after constructing and destroying a QWebView twice
https://bugs.webkit.org/show_bug.cgi?id=54000

Check the value is valid before use it.

  • platform/qt/SharedTimerQt.cpp: (WebCore::SharedTimerQt::~SharedTimerQt):

2011-02-14 Alexis Menard <alexis.menard@nokia.com>

Reviewed by Andreas Kling.

[Qt] Crash on application exit after constructing and destroying a QWebView twice
https://bugs.webkit.org/show_bug.cgi?id=54000

Test case to cover the crash.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::deleteQWebViewTwice):
10:29 AM Webkit2Innards edited by siddharth.mathur@nokia.com
(diff)
10:28 AM Webkit2Innards created by siddharth.mathur@nokia.com
10:25 AM Changeset in webkit [78489] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

React to accelerated compositing changes and allocation failures in DrawingAreaImpl::display

Fixes <http://webkit.org/b/54398> DrawingAreaImpl::display handles error cases poorly.

Reviewed by Darin Adler and Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display): Bail out if the layout we perform puts us into
accelerated compositing mode. Moved the layout earlier in this function so we can bail
before doing other work that would be unnecessary in this case. Moved the allocation of the
ShareableBitmap earlier so we will leave our state (e.g., dirty region) intact even if the
allocation fails.

10:24 AM Changeset in webkit [78488] by Adam Roben
  • 14 edits in trunk/Source/WebKit2

Add a way to flash backing store and view updates

The new WKPageSetDebugPaintFlags SPI can be used to control whether backing store and/or
view updates are flashed. A blueish color is used for view updates, and a purpleish color is
used for backing store updates. The flashing currently only works on Windows.

Fixes <http://webkit.org/b/54303>.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetDebugPaintFlags):
(WKPageGetDebugPaintFlags):

  • UIProcess/API/C/WKPagePrivate.h:

Added. These call through to WebPageProxy.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::flashBackingStoreUpdates):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::flashBackingStoreUpdates):

  • UIProcess/API/qt/qwkpage_p.h:

Stubbed out new PageClient functions.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Tell the WebPageProxy to flash the
backing store updates we're performing.

  • UIProcess/PageClient.h: Added flashBackingStoreUpdates.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::flashBackingStoreUpdates): Call through to the PageClient.
(WebKit::WebPageProxy::viewUpdatesFlashColor): Return the blueish color used for view
updates.
(WebKit::WebPageProxy::backingStoreUpdatesFlashColor): Return the purpleish color used for
backing store updates.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setDebugPaintFlags):
(WebKit::WebPageProxy::debugPaintFlags):
Added these simple accessors.

  • UIProcess/win/WebView.cpp:

(WebKit::flashRects):
(WebKit::createBrush):
New helper functions.

(WebKit::WebView::onPaintEvent): Flash the dirty region if requested.
(WebKit::WebView::flashBackingStoreUpdates): Added. Calls through to flashRects.

  • UIProcess/win/WebView.h: Added flashBackingStoreUpdates.
  • win/WebKit2Generated.make: Export WKPagePrivate.h so clients can use it.
10:13 AM Changeset in webkit [78487] by pfeldman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: unflake inspector/styles-iframe.html

  • inspector/resources/styles-iframe-data.html:
  • inspector/styles-iframe-expected.txt:
  • inspector/styles-iframe.html:
9:54 AM Changeset in webkit [78486] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: 304 Not Modified responses have a yellow icon in Web Inspector Resources panel
https://bugs.webkit.org/show_bug.cgi?id=33220

  • inspector/front-end/ResourceHeadersView.js: (WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
9:53 AM Changeset in webkit [78485] by inferno@chromium.org
  • 7 edits
    4 copies in branches/chromium/648

Merge 77563

BUG=70336
Review URL: http://codereview.chromium.org/6519013

9:29 AM Changeset in webkit [78484] by enne@google.com
  • 8 edits in trunk/Source/WebCore

2011-02-14 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Modify LayerTilerChromium to use TilingData.
https://bugs.webkit.org/show_bug.cgi?id=54143

Most of the previous data in LayerTilerChromium is now calculated
from TilingData. TilingData was modified to allow for a dynamic
tile size and page size. LayerTilerChromium also gets its own
shader with a texture transform to handle drawing from a texture
that is larger than a tile.

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateAndDrawRootLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::tilerSharedValues):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::tileIndex): (WebCore::LayerTilerChromium::tileContentRect): (WebCore::LayerTilerChromium::tileLayerRect): (WebCore::LayerTilerChromium::layerSize): (WebCore::LayerTilerChromium::layerTileSize): (WebCore::LayerTilerChromium::invalidateEntireLayer): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::resizeLayer): (WebCore::LayerTilerChromium::growLayerToContain): (WebCore::LayerTilerChromium::drawTexturedQuad): (WebCore::LayerTilerChromium::SharedValues::SharedValues): (WebCore::LayerTilerChromium::SharedValues::~SharedValues):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::SharedValues::tilerShaderProgram): (WebCore::LayerTilerChromium::SharedValues::shaderSamplerLocation): (WebCore::LayerTilerChromium::SharedValues::shaderMatrixLocation): (WebCore::LayerTilerChromium::SharedValues::shaderAlphaLocation): (WebCore::LayerTilerChromium::SharedValues::shaderTexTransformLocation): (WebCore::LayerTilerChromium::SharedValues::initialized):
  • platform/graphics/gpu/TilingData.cpp: (WebCore::computeNumTiles): (WebCore::TilingData::TilingData): (WebCore::TilingData::setTotalSize): (WebCore::TilingData::setMaxTextureSize): (WebCore::TilingData::tileSizeX): (WebCore::TilingData::tileSizeY): (WebCore::TilingData::textureOffset): (WebCore::TilingData::recomputeNumTiles):
  • platform/graphics/gpu/TilingData.h:
9:18 AM QtWebKit edited by siddharth.mathur@nokia.com
(diff)
9:18 AM QtWebKit edited by siddharth.mathur@nokia.com
(diff)
9:17 AM QtWebKit edited by siddharth.mathur@nokia.com
(diff)
9:17 AM Changeset in webkit [78483] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] First implementation of the editable TextViewer without optimization
https://bugs.webkit.org/show_bug.cgi?id=54388

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set readOnly): (WebInspector.TextEditorChunkedPanel): (WebInspector.TextEditorChunkedPanel.prototype._buildChunks): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorChunkedPanel.prototype.beginDomUpdates): (WebInspector.TextEditorChunkedPanel.prototype.endDomUpdates): (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): (WebInspector.TextEditorGutterChunk.prototype.set expanded): (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly): (WebInspector.TextEditorMainPanel.prototype._buildChunks): (WebInspector.TextEditorMainPanel.prototype._highlightDataReady): (WebInspector.TextEditorMainPanel.prototype._paintLine): (WebInspector.TextEditorMainPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates.return): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates): (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv): (WebInspector.TextEditorMainChunk.prototype.addDecoration): (WebInspector.TextEditorMainChunk.prototype.removeDecoration): (WebInspector.TextEditorMainChunk.prototype.set expanded):
8:40 AM Changeset in webkit [78482] by podivilov@chromium.org
  • 17 edits in trunk

2011-02-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.captureStackTrace):

2011-02-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001

  • wtf/text/TextPosition.h: (WTF::ZeroBasedNumber::convertAsOneBasedInt):

2011-02-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001

  • Make call frame line and column zero based
  • Set execution line in source frame based on call frame line:column
  • Determine currently hit breakpoint based on call frame line:column
  • bindings/js/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
  • bindings/js/JavaScriptCallFrame.h: (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::column): (WebCore::JavaScriptCallFrame::update):
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
  • bindings/v8/DebuggerScript.js: ():
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.continueToLocation): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._breakpointForCallFrame):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine): (WebInspector.ScriptsPanel.prototype._callFrameSelected):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._setTextViewerDecorations): (WebInspector.SourceFrame.prototype.setExecutionLocation): (WebInspector.SourceFrame.prototype.clearExecutionLocation): (WebInspector.SourceFrame.prototype._setExecutionLocation): (WebInspector.SourceFrame.prototype._breakpointAdded): (WebInspector.SourceFrame.prototype._continueToLine): (WebInspector.SourceFrame.prototype._originalLocationToTextViewerLineNumber):

2011-02-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001

  • src/js/Tests.js: (.TestSuite.prototype._checkExecutionLine):
8:34 AM Changeset in webkit [78481] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium expectations update.

  • platform/chromium/inspector/timeline-network-resource-expected.txt:
8:31 AM Changeset in webkit [78480] by christian@webkit.org
  • 2 edits in trunk/Source/WebCore

Regression: Back, Forward, Reload hidden in context menu
https://bugs.webkit.org/show_bug.cgi?id=54393

Reviewed by Gustavo Noronha Silva.

  • page/ContextMenuController.cpp: Always show Back, Forward,

Reload and Stop context menu items for the GTK+ port.

8:12 AM Changeset in webkit [78479] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Add some .messages.in and script files to WebKit2 projects

This is just for convenience. It doesn't affect the build.

  • win/WebKit2.vcproj: Also let VS resort some files.
  • win/WebKit2Generated.vcproj:
8:04 AM Changeset in webkit [78478] by jnd@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Johnny Ding <jnd@chromium.org>

Reviewed by Andreas Kling.

Move the finiteness check into common code.

Test covered by canvas/philip/tests/2d.path.isPointInPath.nonfinite.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::isPointInPath):
7:43 AM Changeset in webkit [78477] by pfeldman@chromium.org
  • 30 edits
    2 adds
    2 deletes in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move timeline and highlighter tests to the new harness.
https://bugs.webkit.org/show_bug.cgi?id=54390

  • inspector/cookie-resource-match.html:
  • inspector/elements-panel-search.html:
  • inspector/evaluate-in-frontend-expected.txt: Removed.
  • inspector/evaluate-in-frontend.html: Removed.
  • inspector/inspected-objects-not-overriden.html:
  • inspector/resources/timeline-iframe-data.html:
  • inspector/syntax-highlight-css.html:
  • inspector/syntax-highlight-html.html:
  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/syntax-highlight-javascript.html:
  • inspector/syntax-highlight.js: (initialize_SyntaxHighlight.InspectorTest.dumpSyntaxHighlight): (initialize_SyntaxHighlight):
  • inspector/timeline-enum-stability-expected.txt:
  • inspector/timeline-enum-stability.html:
  • inspector/timeline-event-dispatch.html:
  • inspector/timeline-layout-expected.txt:
  • inspector/timeline-layout.html:
  • inspector/timeline-mark-timeline.html:
  • inspector/timeline-network-resource-expected.txt:
  • inspector/timeline-network-resource.html:
  • inspector/timeline-network-resource.js:
  • inspector/timeline-paint.html:
  • inspector/timeline-parse-html-expected.txt:
  • inspector/timeline-parse-html.html:
  • inspector/timeline-recalculate-styles-expected.txt:
  • inspector/timeline-recalculate-styles.html:
  • inspector/timeline-script-tag-1-expected.txt:
  • inspector/timeline-script-tag-1.html:
  • inspector/timeline-script-tag-2-expected.txt:
  • inspector/timeline-script-tag-2.html:
  • inspector/timeline-script-tag-2.js:
  • inspector/timeline-test.js: (initialize_Timeline.InspectorTest.performActionsAndPrint.step1): (initialize_Timeline.InspectorTest.performActionsAndPrint.step2): (initialize_Timeline.InspectorTest.performActionsAndPrint.step3): (initialize_Timeline.InspectorTest.performActionsAndPrint): (initialize_Timeline.InspectorTest.printTimelineRecords): (initialize_Timeline.InspectorTest._timelineResults): (initialize_Timeline.InspectorTest.dumpTimelineRecord): (initialize_Timeline.InspectorTest.dumpTimelineRecords): (initialize_Timeline.InspectorTest.printTimelineRecordProperties): (initialize_Timeline.InspectorTest._timelineAgentTypeToString): (initialize_Timeline):
  • inspector/timeline-trivial.html:
7:29 AM Changeset in webkit [78476] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: update chromium expectation for inspector test.

  • inspector/console-uncaught-exception-in-eval.html:
  • platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt:
6:27 AM Changeset in webkit [78475] by pfeldman@chromium.org
  • 6 edits
    1 move
    3 deletes in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium expectations update.

  • platform/chromium-win/inspector/console-format-expected.txt: Removed.
  • platform/chromium-win/inspector/console-uncaught-exception-expected.txt: Removed.
  • platform/chromium-win/inspector/debugger-expand-scope-expected.txt: Removed.
  • platform/chromium/inspector/console-dir-global-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/console-dir-global-expected.txt.
  • platform/chromium/inspector/console-format-collections-expected.txt:
  • platform/chromium/inspector/console-format-expected.txt:
  • platform/chromium/inspector/console-trace-in-eval-expected.txt:
  • platform/chromium/inspector/console-uncaught-exception-expected.txt:
  • platform/chromium/inspector/debugger-expand-scope-expected.txt:
6:23 AM Changeset in webkit [78474] by alex
  • 2 edits in trunk/LayoutTests

2011-02-14 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skipped some tests that were causing problems just in
one of the bots, apparently rounding issues.
https://bugs.webkit.org/show_bug.cgi?id=39022

  • platform/gtk/Skipped:
6:08 AM Changeset in webkit [78473] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Bug 54377 - Clean up RenderTextControlSingleLine::createSubtreeIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=54377

Rearranged the condition blocks, removed superfluous conditions:
.) if-statements where it's already clear that a search field is being generated
.) testing for spin-buttons on field types that can never have them.

createInnerBlockStyle(): only search fields create an inner block, and
these can never have spin buttons.

No new tests. (Refactoring - covered by existing tests)

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createInnerBlockStyle): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
6:06 AM Changeset in webkit [78472] by podivilov@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-02-10 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactoring, extract SourceMapping from SourceFrameContent.
https://bugs.webkit.org/show_bug.cgi?id=54195

Add SourceMapping interface with two implementations - IdenticalSourceMapping and SourceMappingForFormattedScript.
Rewrite SourceFrameContent based on SourceMapping. Make SourceFrame unaware of source mapping details.

  • inspector/front-end/ResourceView.js: (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.locationToPosition): (WebInspector.ScriptFormatter.positionToLocation): (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent): (WebInspector.ScriptFormatter.prototype._splitContentIntoChunks): (WebInspector.SourceMappingForFormattedScript): (WebInspector.SourceMappingForFormattedScript.prototype.fromScriptLocation): (WebInspector.SourceMappingForFormattedScript.prototype.toScriptLocation): (WebInspector.SourceMappingForFormattedScript.prototype.originalPositionToFormattedLocation): (WebInspector.SourceMappingForFormattedScript.prototype._convertPosition):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._shouldDisplayBreakpoint): (WebInspector.SourceFrame.prototype.setExecutionLine): (WebInspector.SourceFrame.prototype.clearExecutionLine): (WebInspector.SourceFrame.prototype._breakpointAdded): (WebInspector.SourceFrame.prototype.formatSource.didFormat): (WebInspector.SourceFrame.prototype.formatSource): (WebInspector.SourceFrame.prototype._continueToLine): (WebInspector.SourceFrame.prototype._setBreakpoint): (WebInspector.SourceFrame.prototype._findBreakpoint): (WebInspector.SourceFrameContentProvider.prototype.requestContent):
  • inspector/front-end/SourceFrameContent.js: (WebInspector.SourceFrameContent): (WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToScriptLocation): (WebInspector.SourceFrameContent.prototype.scriptLocationToSourceFrameLineNumber): (WebInspector.SourceFrameContent.prototype._sourceIDForSourceFrameLineNumber): (WebInspector.SourceMapping): (WebInspector.SourceMapping.prototype.fromScriptLocation): (WebInspector.SourceMapping.prototype.toScriptLocation): (WebInspector.IdenticalSourceMapping): (WebInspector.IdenticalSourceMapping.prototype.fromScriptLocation): (WebInspector.IdenticalSourceMapping.prototype.toScriptLocation):
  • inspector/front-end/utilities.js: (String.prototype.lineEndings):
6:00 AM Changeset in webkit [78471] by alex
  • 2 edits in trunk/LayoutTests

2011-02-14 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skipped generated-content-inside-table.htm test, it
fails in the bots, opened bug:
https://bugs.webkit.org/show_bug.cgi?id=54389

  • platform/gtk/Skipped:
5:20 AM Changeset in webkit [78470] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION introduced in r77950] Develop -> Start Debugging JavaScript does not open Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=54277

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::stopUserInitiatedProfiling): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::showPanel):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::stopUserInitiatedProfiling):
5:13 AM Changeset in webkit [78469] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-14 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Andreas Kling.

css style="max-width:none" works wrong
https://bugs.webkit.org/show_bug.cgi?id=53743

Adds a test to ensure style 'max-width: none' works correctly.

  • fast/css/max-width-none-expected.txt: Added.
  • fast/css/max-width-none.html: Added.

2011-02-14 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Andreas Kling.

css style="max-width:none" works wrong
https://bugs.webkit.org/show_bug.cgi?id=53743

Fix a bug that "max-width:none" works wrong.
See also: http://trac.webkit.org/changeset/13462

Test: fast/css/max-width-none.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): For max-width of none, set it to Length(undefinedLength, Fixed), which is the correct value.
5:13 AM Changeset in webkit [78468] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

REGRESSION (r77834): Assertion failing in svg/custom/use-multiple-on-nested-disallowed-font.svg
https://bugs.webkit.org/show_bug.cgi?id=54344

Reviewed by Andreas Kling.

Intead of recomputing, just mark style selector dirty if it is invalidated in the middle of a style recalc.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::recalcStyleSelector):

  • dom/Document.h:
5:11 AM Changeset in webkit [78467] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-14 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Fix wrong popup position for RTL(again)
https://bugs.webkit.org/show_bug.cgi?id=54375

Fix right position bug introduce by https://bugs.webkit.org/show_bug.cgi?id=53567, because the previous fix was correct for the current behaviour, but not good for http://crbug.com/60427. To calculate the correct right offset value and apply to the position, change WebCore::PopupContainer::layout() to return right offset value and use the returned value to calculate position.

No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Change the input parameter to take popupInitialCoordinate again. And calculate correct right position with returned right offset from layoutAndGetRightOffset(). (WebCore::PopupContainer::showPopup): Change the passing parameter to layoutAndCalculateWidgetRect(). (WebCore::PopupContainer::layoutAndGetRightOffset): Change the name from layout() and to return rightOffset value. (WebCore::PopupContainer::refresh): Change the passing parameter to layoutAndCalculateWidgetRect().
  • platform/chromium/PopupMenuChromium.h: Change the function name and parameters.
5:06 AM Changeset in webkit [78466] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up to r78460 with more expectation updates.

  • inspector/styles-iframe-expected.txt:
  • inspector/styles-iframe.html:
4:31 AM Changeset in webkit [78465] by alex
  • 6 edits in trunk/Source/WebCore

2011-02-14 Alejandro G. Castro <alex@igalia.com>

Unreviewed, rolling out r78451.
http://trac.webkit.org/changeset/78451
https://bugs.webkit.org/show_bug.cgi?id=53898

It is causing crashes in some bots

  • platform/text/TextCodecICU.cpp: (WebCore::newTextCodecICU): (WebCore::TextCodecICU::registerBaseEncodingNames): (WebCore::TextCodecICU::registerBaseCodecs): (WebCore::TextCodecICU::registerExtendedEncodingNames): (WebCore::TextCodecICU::registerExtendedCodecs): (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter): (WebCore::getGbkEscape): (WebCore::urlEscapedEntityCallback): (WebCore::gbkCallbackEscape): (WebCore::gbkUrlEscapedEntityCallack): (WebCore::gbkCallbackSubstitute):
  • platform/text/TextCodecICU.h: (WebCore::ICUConverterWrapper::ICUConverterWrapper):
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): (WebCore::nonASCIISequenceLength): (WebCore::decodeNonASCIISequence): (WebCore::TextCodecUTF8::decode):
  • platform/text/TextCodecUTF8.h:
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
3:32 AM Changeset in webkit [78464] by hamaji@chromium.org
  • 4 edits
    2 adds in trunk/LayoutTests

2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>

Rebaseline chromium's test expectations for SVG tests.

  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-intro-05-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
  • platform/chromium/test_expectations.txt:
3:29 AM Changeset in webkit [78463] by pfeldman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up to r78460 with expectation updates.

  • inspector/styles-iframe-expected.txt:
  • platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
  • platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
3:22 AM Changeset in webkit [78462] by hamaji@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>

Rebaseline chromium's test expectation for http://trac.webkit.org/changeset/78449

  • platform/chromium-win/fast/gradients/css3-repeating-end-fill-expected.txt: Added.
3:14 AM Changeset in webkit [78461] by hamaji@chromium.org
  • 2 edits
    29 adds in trunk/LayoutTests

2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>

Rebaseline chromium's test expectations for inline-box-background-*

  • platform/chromium-linux/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-expected.png: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-box-background-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-expected.txt: Added.
  • platform/chromium-win/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-long-image-expected.txt: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:58 AM Changeset in webkit [78460] by pfeldman@chromium.org
  • 83 edits
    3 moves
    1 add
    4 deletes in trunk/LayoutTests

2011-02-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [layout tests] get rid of elements-tests.js in favor of elements-tests2.js
https://bugs.webkit.org/show_bug.cgi?id=54354

  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/console-test.js: Renamed from LayoutTests/http/tests/inspector/console-tests2.js.
  • http/tests/inspector/console-tests.js: Removed.
  • http/tests/inspector/console-websocket-error.html:
  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/console-xhr-logging.html:
  • http/tests/inspector/debugger-test.js: Renamed from LayoutTests/http/tests/inspector/debugger-test2.js.
  • http/tests/inspector/elements-test.js: Added.
  • http/tests/inspector/inspector-test2.js:
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resource-parameters.html:
  • http/tests/inspector/resource-tests.js: Removed.
  • http/tests/inspector/resources-test.js: Renamed from LayoutTests/http/tests/inspector/resource-test2.js.
  • inspector/command-line-api.html:
  • inspector/console-api-on-call-frame.html:
  • inspector/console-assert.html:
  • inspector/console-clear.html:
  • inspector/console-command-clear-expected.txt:
  • inspector/console-command-clear.html:
  • inspector/console-dir-global.html:
  • inspector/console-dir.html:
  • inspector/console-dirxml.html:
  • inspector/console-eval-global.html:
  • inspector/console-eval.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-collections.html:
  • inspector/console-format-expected.txt:
  • inspector/console-format.html:
  • inspector/console-log-before-inspector-open.html:
  • inspector/console-log-syntax-error.html:
  • inspector/console-object-constructor-name.html:
  • inspector/console-tests.html:
  • inspector/console-trace-in-eval.html:
  • inspector/console-trace.html:
  • inspector/console-uncaught-exception-in-eval.html:
  • inspector/console-uncaught-exception.html:
  • inspector/debugger-autocontinue-on-syntax-error.html:
  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-cyclic-ref.html:
  • inspector/debugger-eval-on-call-frame.html:
  • inspector/debugger-eval-while-paused.html:
  • inspector/debugger-expand-scope.html:
  • inspector/debugger-no-nested-pause.html:
  • inspector/debugger-pause-in-eval-script.html:
  • inspector/debugger-pause-on-breakpoint.html:
  • inspector/debugger-pause-on-debugger-statement.html:
  • inspector/debugger-pause-on-exception.html:
  • inspector/debugger-proto-property.html:
  • inspector/debugger-scripts.html:
  • inspector/debugger-step-in.html:
  • inspector/debugger-step-out.html:
  • inspector/debugger-step-over.html:
  • inspector/debugger-suspend-active-dom-objects.html:
  • inspector/dom-breakpoints.html:
  • inspector/elements-delete-inline-style.html:
  • inspector/elements-img-tooltip-expected.txt:
  • inspector/elements-img-tooltip.html:
  • inspector/elements-panel-limited-children-expected.txt:
  • inspector/elements-panel-limited-children.html:
  • inspector/elements-panel-rewrite-href-expected.txt:
  • inspector/elements-panel-rewrite-href.html:
  • inspector/elements-panel-selection-on-refresh-expected.txt:
  • inspector/elements-panel-selection-on-refresh.html:
  • inspector/elements-panel-structure-expected.txt:
  • inspector/elements-panel-structure.html:
  • inspector/elements-panel-styles.html:
  • inspector/elements-panel-xhtml-structure-expected.txt:
  • inspector/elements-panel-xhtml-structure.xhtml:
  • inspector/elements-tests.js: Removed.
  • inspector/elements-tests2.js: Removed.
  • inspector/resources/elements-panel-styles.css:
  • inspector/resources/styles-iframe-data.html:
  • inspector/storage-panel-dom-storage.html:
  • inspector/styles-add-blank-property.html:
  • inspector/styles-computed-trace.html:
  • inspector/styles-disable-inherited.html:
  • inspector/styles-disable-then-change.html:
  • inspector/styles-disable-then-delete.html:
  • inspector/styles-disable-then-enable.html:
  • inspector/styles-iframe-expected.txt:
  • inspector/styles-iframe.html:
  • inspector/styles-new-API.html:
  • inspector/styles-source-lines-expected.txt:
  • inspector/styles-source-lines-inline.html:
  • inspector/styles-source-lines.html:
  • inspector/styles-source-offsets.html:
  • inspector/styles-url-linkify.html:
2:54 AM Changeset in webkit [78459] by hamaji@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>

Rebaseline chromium's test_expectations.

  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
  • platform/chromium/test_expectations.txt:
1:28 AM Changeset in webkit [78458] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-14 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Need implementation of ResourceRequest and ResourceResponse serialization
https://bugs.webkit.org/show_bug.cgi?id=54339

Add dummy implementation with FIXME and let the core go with it for now.

  • Shared/qt/WebCoreArgumentCodersQt.cpp: (CoreIPC::decodeResourceRequest): (CoreIPC::decodeResourceResponse):
12:05 AM Changeset in webkit [78457] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=54376
Make sorting of matched rules faster

Reviewed by Dan Bernstein.

  • use std::sort
  • cache specificity, it is slow to compute
  • inline compare function
  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::specificity):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::compareRules):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::RuleData::RuleData):
(WebCore::CSSStyleSelector::matchPageRules):

  • css/CSSStyleSelector.h:

Feb 13, 2011:

11:58 PM Changeset in webkit [78456] by hayato@chromium.org
  • 2 edits in trunk

2011-02-13 Hayato Ito <hayato@chromium.org>

Reviewed by Kent Tamura.

Update .gitignore to ignore files which Ninja build system generates.

https://bugs.webkit.org/show_bug.cgi?id=54378

  • .gitignore:
9:01 PM WebKit Team edited by jhanssen@gmail.com
Add myself to the committer list (diff)
8:22 PM Changeset in webkit [78455] by tkent@chromium.org
  • 4 edits
    2 copies in branches/chromium/597

The second attempt to merge r77114.
(It was merged by r78166 and reverted by r78381)

HTMLFormControlElement::insertedIntoDocument() and removedFromDocument()
should call HTMLElement::insertedIntoDocument() and removedFromDocument().

2011-01-30 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223

Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.

Test: fast/forms/dangling-form-element-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
  • html/HTMLFormControlElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().

2011-01-30 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223

Adds a test that ensures dangling form associated elements are not
registered on the document.

  • fast/forms/dangling-form-element-crash-expected.txt: Added.
  • fast/forms/dangling-form-element-crash.html: Added.

BUG=crbug.com/70078
TBR=inferno@chromium.org

8:12 PM WebKit Team edited by helder@sencha.com
(diff)
8:02 PM Changeset in webkit [78454] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2011-02-13 Simon Fraser <Simon Fraser>

Change previous test to dump as text, with pixel output, to fix
Qt failure.

  • fast/gradients/css3-repeating-end-fill-expected.txt:
  • fast/gradients/css3-repeating-end-fill.html:
8:00 PM Changeset in webkit [78453] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

7:56 PM Changeset in webkit [78452] by mrowe@apple.com
  • 1 copy in tags/Safari-534.20

New tag.

7:28 PM Changeset in webkit [78451] by Darin Adler
  • 6 edits in trunk/Source/WebCore

2011-02-12 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898

Covered by existing tests; not adding new tests at this time.

This patch now handles errors in the same way the existing codecs do,
and so passes our tests. The previous version failed some tests because
of incorrect error handling.

  • platform/text/TextCodecICU.cpp: (WebCore::create): Renamed from newTextCodecICU, made a static member function, and added a call to adoptPtr. (WebCore::TextCodecICU::registerEncodingNames): Renamed from registerExtendedEncodingNames since this class is no longer used for base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8. (WebCore::TextCodecICU::registerCodecs): Renamed. (WebCore::fallbackForGBK): Renamed to conform to our current style.
  • platform/text/TextCodecICU.h: Updated for above changes. Changed indentation. Made most functions private, including virtual function overrides. Marked ICUConverterWrapper noncopyable.
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases that were formerly added by TextCodecICU. (WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for bytes F5-FF instead of failing. (WebCore::decodeNonASCIISequence): Tweaked coding style. (WebCore::appendCharacter): Added. Makes it easier to share code between the partial-character handling and main loop. (WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case where there is a partial sequence. Fixed partial sequence handling so that goto is no longer needed, since compilers sometimes make poor code when goto is involved. Added a loop for partial sequences since we consume only one byte when a partial sequence is invalid. Fixed logic in main decoding loop so goto is not needed. Used early-exit style in both loops so the main flow is not nested inside if statements. Added correct error handling for flush when a partial sequence remains, which involved wrapping the function in yet another loop.
  • platform/text/TextCodecUTF8.h: Made virtual function overrides private.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed calls to TextCodecICU. Added FIXMEs for other codecs that no longer need to be included here. (WebCore::extendTextCodecMaps): Updated for the name change of the TextCodecICU functions.
6:50 PM Changeset in webkit [78450] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/8995490> WebCoreAuthenticationClientAsChallengeSender doesn't implement some necessary methods.

Reviewed by Maciej Stachowiak.

  • platform/network/mac/AuthenticationMac.mm:

(-[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:]):
(-[WebCoreAuthenticationClientAsChallengeSender rejectProtectionSpaceAndContinueWithChallenge:]):

6:09 PM Changeset in webkit [78449] by Simon Fraser
  • 3 edits
    4 adds in trunk

2011-02-13 Simon Fraser <Simon Fraser>

Reviewed by Andreas Kling.

Repeating gradients drawn incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53502

The 'forward-fill' logic for repeating gradients used the wrong
starting stop index (0 rather than the original first index), which
resulted in incorrect gradients if backwards-fill had already been
applied.

Test: fast/gradients/css3-repeating-end-fill.html

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops):
5:19 PM Changeset in webkit [78448] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-13 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

Unused variable result in RenderBlock::addOverflowFromFloats()
https://bugs.webkit.org/show_bug.cgi?id=54363

Remove the unused variable.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverflowFromFloats):
4:14 PM Changeset in webkit [78447] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Anders Carlsson.

WebCore fails to build with Clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54367

  • loader/PingLoader.h:

(WebCore::PingLoader::didReceiveData): Change the method signature to match the signature
in the base class.

4:12 PM Changeset in webkit [78446] by andreas.kling@nokia.com
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-02-13 Andreas Kling <kling@webkit.org>

Unreviewed, remove unnecessary platform expectations for now-passing test.

  • platform/chromium/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
4:09 PM Changeset in webkit [78445] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Speculative fix for

Reviewed by Maciej Stachowiak.

<rdar://problem/8995361>
CrashTracer: [USER] 47 crashes in WebProcess at com.apple.WebKit2: WebKit::WebPage::layoutIfNeeded + 4

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
Invalidate the layer tree host.

3:19 PM Changeset in webkit [78444] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-13 Nico Weber <thakis@chromium.org>

Reviewed by Anders Carlsson.

RenderBR::width() tries but fails to override RenderText::width()
https://bugs.webkit.org/show_bug.cgi?id=54301

The superclass method's signature changed, e.g. in
http://trac.webkit.org/changeset/57215, but the subclass was not
updated.

  • rendering/RenderBR.h: (WebCore::RenderBR::width):
3:11 PM Changeset in webkit [78443] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-13 Shinichiro Hamaji <hamaji@chromium.org>

Fix chromium's test_expectations

  • fast/inline/inline-box-background-* should be IMAGE instead of IMAGE+TEXTfor Mac
  • fast/css/test-setting-canvas-color.html is failing
  • platform/chromium/test_expectations.txt:
1:41 PM Changeset in webkit [78442] by andreas.kling@nokia.com
  • 10 edits
    2 adds in trunk

2011-02-13 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Canvas: 2d.fillStyle.parse.system.html fails
https://bugs.webkit.org/show_bug.cgi?id=39168

Based on previous work by Julien Chaffraix <jchaffraix@codeaurora.org>
and Jan Erik Hanssen <jhanssen@sencha.com>

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor): Changed the function to better match our early return policy. Also we now return false when we don't parse the color. This is needed for createFromString to fallback to using parseSystemColor.

(WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
the system colors.

  • css/CSSParser.h: Added the new parseSystemColor method.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString. (WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
  • html/canvas/CanvasStyle.cpp: (WebCore::parseColor): (WebCore::parseColorOrCurrentColor): (WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor and fall back to parseSystemColor if it did not work.
  • html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.

2011-02-13 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Canvas: 2d.fillStyle.parse.system.html fails
https://bugs.webkit.org/show_bug.cgi?id=39168

  • fast/css/test-setting-canvas-color-expected.txt: Added.
  • fast/css/test-setting-canvas-color.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:
1:39 PM Changeset in webkit [78441] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

The plug-in process heap should be executable by default
https://bugs.webkit.org/show_bug.cgi?id=54364
<rdar://problem/8990563>

  • UIProcess/Launcher/ProcessLauncher.h: Add executableHeap flag.


  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::ProcessLauncher::launchProcess): Set the right posix_spawn flag if executableHeap is true.
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize executableHeap to true.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::connect): Initialize executableHeap to false.
1:21 PM Changeset in webkit [78440] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Messages waited on are never dispatched
https://bugs.webkit.org/show_bug.cgi?id=54362
<rdar://problem/8995051>

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::processIncomingMessage): Get the argument encoder from the incoming message.
12:28 PM Changeset in webkit [78439] by jeremy@chromium.org
  • 16 edits in trunk/Source

2011-02-13 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Adam Barth.

Add a compile-time option to completely disable WebArchive support.
https://bugs.webkit.org/show_bug.cgi?id=52712

Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.
Ports Affected:

WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
This patch preserves this behavior except that it also disables support in the Chromium port.

  • wtf/Platform.h: Add ENABLE_WEB_ARCHIVE definition and turn it off explicitly for Qt & Chromium ports.

2011-02-13 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Adam Barth.

Add a compile-time option to completely disable WebArchive support.
https://bugs.webkit.org/show_bug.cgi?id=52712

Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.

ArchiveResource and ArchiveResourceCollection are notably still compiled in. They are used
in Safari for functionality such as "Save Image As" and Image copy & paste independent of
WebArchive support.

Ports Affected:

WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
This patch preserves this behavior except that it also disables support in the Chromium port.

No behavior changes so no new tests.

  • WebCore.gyp/WebCore.gyp: Don't compile LegacyWebArchive.cpp and friends.
  • WebCore.pro: Don't compile ArchiveFactory.cpp in Qt port.
  • loader/DocumentLoader.cpp: Surround WebArchive code with #ifdef. (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::archiveResourceForURL):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::finishedLoadingDocument):
  • loader/FrameLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::start):
  • loader/archive/ArchiveFactory.cpp: Remove #ifdef since feature is now enabled/disabled wholesale. (WebCore::archiveMIMETypes):
  • page/Settings.cpp:
  • page/Settings.h:
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):

2011-02-13 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Adam Barth.

Add a compile-time option to completely disable WebArchive support.
https://bugs.webkit.org/show_bug.cgi?id=52712

Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
12:04 PM Changeset in webkit [78438] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-13 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit does not properly handle D&D of a percent-encoded URL.
https://bugs.webkit.org/show_bug.cgi?id=53320

The encoding that was done is corrected in the fix.
Replaced the KURL encoding function with QUrl API.

  • platform/qt/DragDataQt.cpp: (WebCore::DragData::asURL):
11:33 AM Changeset in webkit [78437] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-13 Leo Yang <leo.yang.c@gmail.com>

Reviewed by Andreas Kling.

Unnecessary call of containingBlock() in RenderBoxModelObject::relativePositionOffsetX()
https://bugs.webkit.org/show_bug.cgi?id=54351

We were calling containingBlock() twice if the left is not auto. We only need to call it
once because we can use 'cb' variable in the following line.

No functionality change, no new tests.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetX):
11:23 AM Changeset in webkit [78436] by commit-queue@webkit.org
  • 10 edits
    6 adds
    2 deletes in trunk

2011-02-13 Jarred Nicholls <jarred@sencha.com>

Reviewed by Simon Fraser.

getComputedStyle returns wrong value for margin-right
https://bugs.webkit.org/show_bug.cgi?id=13343

Matching IE, Firefox, and Opera behavior by returning the computed margin
values as specified, rather than the used/auto values (calculated via RenderBox).
Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
returns the specified percentage.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/fast/css/computed-style-without-renderer-expected.txt
  • platform/chromium-win/fast/css/computed-style-without-renderer-expected.txt
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • fast/css/getComputedStyle/getComputedStyle-margin-auto-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle/marginComputedStyle-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-margin-auto.html: Copied from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
  • fast/css/getComputedStyle/getComputedStyle-margin-length-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-margin-length.html: Copied from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.
  • fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-margin-percentage.html: Renamed from LayoutTests/fast/css/getComputedStyle/marginComputedStyle.html.

2011-02-13 Jarred Nicholls <jarred@sencha.com>

Reviewed by Simon Fraser.

getComputedStyle returns wrong value for margin-right
https://bugs.webkit.org/show_bug.cgi?id=13343

Matching IE, Firefox, and Opera behavior by returning the computed margin
values as specified, rather than the used/auto values (calculated via RenderBox).
Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
returns the specified percentage.

Tests: fast/css/getComputedStyle/getComputedStyle-margin-auto.html

fast/css/getComputedStyle/getComputedStyle-margin-length.html
fast/css/getComputedStyle/getComputedStyle-margin-percentage.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):