Timeline
Apr 22, 2011:
- 11:38 PM April 2011 Meeting edited by
- (diff)
- 11:22 PM Changeset in webkit [84740] by
-
- 13 edits in trunk/Source
2011-04-22 Jon Lee <jonlee@apple.com>
Reviewed by Beth Dakin.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
- WebCore.exp.in: adding method to allow changing style
- page/FrameView.cpp: (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
- page/FrameView.h:
- platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
- platform/ScrollableArea.cpp: (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
- platform/ScrollableArea.h:
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
2011-04-22 Jon Lee <jonlee@apple.com>
Reviewed by Beth Dakin.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style
2011-04-22 Jon Lee <jonlee@apple.com>
Reviewed by Beth Dakin.
Overlay scroller hard to see on pages with dark background (59183)
https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style
- 10:55 PM Changeset in webkit [84739] by
-
- 8 edits in trunk
2011-04-22 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Upgrade CSS loads from mixed content warning (displayed) to mixed
content error (ran)
https://bugs.webkit.org/show_bug.cgi?id=59056
- http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt: Update expectation.
- http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Update expectation.
- http/tests/security/mixedContent/insecure-css-in-iframe.html: Update expectation.
- http/tests/security/mixedContent/insecure-css-in-main-frame.html: Update expectation.
- http/tests/security/mixedContent/resources/frame-with-insecure-css.html: Fix typo.
2011-04-22 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Upgrade CSS loads from mixed content warning (displayed) to mixed
content error (ran)
https://bugs.webkit.org/show_bug.cgi?id=59056
Test: http/tests/security/mixedContent/insecure-css-in-iframe.html
Test: http/tests/security/mixedContent/insecure-css-in-main-frame.html
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest): CSS loads are running rather than displaying content.
- 10:09 PM Changeset in webkit [84738] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Add some failing tests to the Skipped list because of a WTR sideeffect bug.
- platform/qt-wk2/Skipped:
- 9:44 PM Changeset in webkit [84737] by
-
- 2 edits in trunk/Source/WebCore
Fixed an upside-down conditional in my last check-in.
- bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::isObservable):
- 9:41 PM Changeset in webkit [84736] by
-
- 19 edits in trunk/Source/WebCore
2011-04-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=59260
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since we use the opaque roots system now.
- bindings/js/JSNavigatorCustom.cpp: Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects whose opaque roots are frames.
- css/StyleMedia.h: (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.
- css/StyleMedia.idl:
- loader/appcache/DOMApplicationCache.idl:
- page/BarInfo.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/Geolocation.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.idl:
- page/Screen.idl:
- storage/Storage.idl: Updated to use the opaque roots system.
- 9:37 PM Changeset in webkit [84735] by
-
- 604 edits565 adds in trunk/LayoutTests
[Qt] Unskip a bunch of passing tests and update their expected files.
This patch based on work of Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
- platform/qt/Skipped:
- platform/qt/fast/[...]: Added, updated.
- platform/qt/scrollbars/[...]: Added, updated.
- 9:01 PM April 2011 Meeting edited by
- (diff)
- 8:41 PM Changeset in webkit [84734] by
-
- 7 edits4 deletes in trunk
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84627.
http://trac.webkit.org/changeset/84627
https://bugs.webkit.org/show_bug.cgi?id=59271
It broke Symbian build (Requested by Ossy on #webkit).
- Source/WebKit.pro:
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84627.
http://trac.webkit.org/changeset/84627
https://bugs.webkit.org/show_bug.cgi?id=59271
It broke Symbian build (Requested by Ossy on #webkit).
- QtWebKit.pro:
- symbian/platformplugin/WebPlugin.cpp: Removed.
- symbian/platformplugin/WebPlugin.h: Removed.
- symbian/platformplugin/platformplugin.pro: Removed.
- symbian/platformplugin/qwebkitplatformplugin.h: Removed.
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84627.
http://trac.webkit.org/changeset/84627
https://bugs.webkit.org/show_bug.cgi?id=59271
It broke Symbian build (Requested by Ossy on #webkit).
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- 8:23 PM April 2011 Meeting edited by
- (diff)
- 8:22 PM Changeset in webkit [84733] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change - clean up some flakiness.
- platform/chromium/test_expectations.txt:
- 8:20 PM Changeset in webkit [84732] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Don't use XMLTreeViewer when script is disabled (it uses Javascript
to build a prettified version of the xml document).
https://bugs.webkit.org/show_bug.cgi?id=59113
- xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
- 8:19 PM April 2011 Meeting edited by
- (diff)
- 8:17 PM Changeset in webkit [84731] by
-
- 18 edits in trunk/Source/WebCore
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84725 and r84728.
http://trac.webkit.org/changeset/84725
http://trac.webkit.org/changeset/84728
https://bugs.webkit.org/show_bug.cgi?id=59270
It broke http/tests/appcache tests (Requested by Ossy on
#webkit).
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren):
- bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::visitChildren):
- bindings/scripts/CodeGeneratorJS.pm:
- css/StyleMedia.h:
- css/StyleMedia.idl:
- loader/appcache/DOMApplicationCache.idl:
- page/BarInfo.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/DOMWindow.h: (WebCore::DOMWindow::optionalScreen): (WebCore::DOMWindow::optionalSelection): (WebCore::DOMWindow::optionalHistory): (WebCore::DOMWindow::optionalCrypto): (WebCore::DOMWindow::optionalLocationbar): (WebCore::DOMWindow::optionalMenubar): (WebCore::DOMWindow::optionalPersonalbar): (WebCore::DOMWindow::optionalScrollbars): (WebCore::DOMWindow::optionalStatusbar): (WebCore::DOMWindow::optionalToolbar): (WebCore::DOMWindow::optionalConsole): (WebCore::DOMWindow::optionalNavigator): (WebCore::DOMWindow::optionalLocation): (WebCore::DOMWindow::optionalMedia): (WebCore::DOMWindow::optionalSessionStorage): (WebCore::DOMWindow::optionalLocalStorage): (WebCore::DOMWindow::optionalPerformance):
- page/Geolocation.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.h: (WebCore::Navigator::optionalGeolocation):
- page/Navigator.idl:
- page/Screen.idl:
- storage/Storage.idl:
- 8:17 PM Changeset in webkit [84730] by
-
- 6 edits in trunk/Tools
2011-04-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
rebaseline-chromium-webkit-tests: clean up output
https://bugs.webkit.org/show_bug.cgi?id=59240
This change dramatically changes the output the tool provides
by default. The previous output (more or less) is still there
in -v / verbose / debug mode, but the default output is
way terser and more readable. It mostly says which files are
updated, which are duplicates, and which are not found in an
archive. Feedback desired :).
This change also adds a scm.exists() method to the SCM object
so that we can cleanly figure out what we're doing while
rebaselining.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
- Scripts/webkitpy/common/system/filesystem_mock.py:
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- 8:09 PM Changeset in webkit [84729] by
-
- 4 edits in trunk/Source/WebCore
2011-04-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
Change SVG-related shadow root checks to use isSVGShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=59237
Covered by existing tests, no behavior change.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Use isSVGShadowRoot.
- svg/SVGUseElement.cpp: (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
- svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::insertedIntoDocument): Ditto.
- 7:50 PM April 2011 Meeting edited by
- Proposing a hw acceleration talk (diff)
- 7:48 PM April 2011 Meeting edited by
- (diff)
- 7:22 PM Changeset in webkit [84728] by
-
- 2 edits in trunk/Source/WebCore
Mac build fix.
- page/DOMWindow.h:
(WebCore::DOMWindow::optionalApplicationCache): Restored this function,
which is used after all.
- 7:19 PM Changeset in webkit [84727] by
-
- 2 edits in trunk/Tools
2011-04-22 Ilya Sherman <isherman@chromium.org>
Reviewed by Alexey Proskuryakov.
Add Ilya Sherman (isherman@chromium.org) to the list of contributors
https://bugs.webkit.org/show_bug.cgi?id=59231
- Scripts/webkitpy/common/config/committers.py:
- 7:16 PM Changeset in webkit [84726] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
don't white-space:nowrap the results iframes
https://bugs.webkit.org/show_bug.cgi?id=59259
- fast/harness/results.html:
- 7:09 PM Changeset in webkit [84725] by
-
- 18 edits in trunk/Source/WebCore
2011-04-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=59260
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since we use the opaque roots system now.
- bindings/js/JSNavigatorCustom.cpp: Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects whose opaque roots are frames.
- css/StyleMedia.h: (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.
- css/StyleMedia.idl:
- loader/appcache/DOMApplicationCache.idl:
- page/BarInfo.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/Geolocation.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.idl:
- page/Screen.idl:
- storage/Storage.idl: Updated to use the opaque roots system.
- 7:05 PM Changeset in webkit [84724] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Roll in deps bots failures.
- platform/chromium/test_expectations.txt:
- 7:03 PM April 2011 Meeting edited by
- Adding myself to enrica's talk (diff)
- 7:03 PM Changeset in webkit [84723] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2: Stop responsiveness timer before calling runOpenPanel
https://bugs.webkit.org/show_bug.cgi?id=59268
<rdar://problem/9327944>
Reviewed by Sam Weinig.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runOpenPanel): Stop the timer before calling WebUIClient::runOpenPanel,
because runOpenPanel can spin a nested run loop.
- 6:48 PM Changeset in webkit [84722] by
-
- 2 edits in trunk/Tools
2011-04-22 Yuta Kitamura <yutak@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: Exception raised when stderr contains binary data
https://bugs.webkit.org/show_bug.cgi?id=59083
- Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Use write_binary_file() instead of write_text_file().
- 6:35 PM April 2011 Meeting edited by
- (diff)
- 6:14 PM Changeset in webkit [84721] by
-
- 12 edits in trunk
2011-04-22 Chang Shu <cshu@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
https://bugs.webkit.org/show_bug.cgi?id=42536
Unskip passed tests.
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
2011-04-22 Chang Shu <cshu@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
https://bugs.webkit.org/show_bug.cgi?id=42536
- WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetFrameFlatteningEnabled):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setFrameFlatteningEnabled):
- WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-22 Chang Shu <cshu@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
https://bugs.webkit.org/show_bug.cgi?id=42536
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setFrameFlatteningEnabled):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- 6:09 PM Changeset in webkit [84720] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Xiaomei Ji <xji@chromium.org>
[QT] move-by-word-visually.html failed in QT.
https://bugs.webkit.org/show_bug.cgi?id=59265
Temporarily skip the test in QT while investigating.
- platform/qt/Skipped:
- 6:03 PM Changeset in webkit [84719] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Alejandro G. Castro <alex@igalia.com>
Undo rebaseline done in r84677 for this test, it was a flaky
execution.
- platform/gtk/media/video-controls-rendering-expected.txt:
- 5:59 PM Changeset in webkit [84718] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-04-22 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
Add missing default constructors for HashMap iterator specializations.
https://bugs.webkit.org/show_bug.cgi?id=59250
- wtf/HashIterators.h:
- wtf/HashTable.h: (WTF::HashTableConstIterator::HashTableConstIterator): Added cast to help compiler find the function template.
- 5:54 PM Changeset in webkit [84717] by
-
- 3 edits in trunk/Source/JavaScriptCore
Bug 59262 - DFG JIT - reduce size of VariableRecord
Reviewed by Sam Weinig.
We never need both the get & set node, only the most recent
(which is always a set, if both exist).
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.h:
(JSC::DFG::VariableRecord::VariableRecord):
- 5:39 PM Changeset in webkit [84716] by
-
- 5 edits in trunk/Source
Versioning.
- 5:38 PM April 2011 Meeting edited by
- (diff)
- 5:37 PM Changeset in webkit [84715] by
-
- 3 edits in trunk/LayoutTests
Unreviewed: Updated bug ID for geolocation skipped cases
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
- 5:37 PM April 2011 Meeting edited by
- (diff)
- 5:36 PM April 2011 Meeting edited by
- (diff)
- 5:34 PM Changeset in webkit [84714] by
-
- 6 edits in trunk
roll out incorrect versioning info (included extra file).
- 5:30 PM Changeset in webkit [84713] by
-
- 4 edits in trunk
2011-04-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
https://bugs.webkit.org/show_bug.cgi?id=58976
- platform/gtk/Skipped: Unskip a test which is no longer crashing.
2011-04-22 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
https://bugs.webkit.org/show_bug.cgi?id=58976
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::getInnerText): Guard against situations when the documentElement method of the document returns null.
- 5:25 PM Changeset in webkit [84712] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-22 Alejandro G. Castro <alex@igalia.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use the libWebCore.a convenience library when compiling WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59258
- GNUmakefile.am: Remove the libWebKit2 convenience library and use the libWebCore convenience library when compiling WebKit2. Not only does this maintain the CPPFLAGS isolation, it prevents double-compilation of WebCore in some cases.
- 5:23 PM Changeset in webkit [84711] by
-
- 6 edits in trunk
Versioning.
- 5:12 PM Changeset in webkit [84710] by
-
- 5 edits in trunk
2011-04-22 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
move caret by word in visual order returns wrong result when caret itself is at word boundary.
https://bugs.webkit.org/show_bug.cgi?id=58504.
Add test case to test moving left/right by word visually on every character position.
Remove a specific test added before for testing a specific code path since the test case
is covered now.
- editing/selection/move-by-word-visually-expected.txt:
- editing/selection/move-by-word-visually.html:
2011-04-22 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
move caret by word in visual order returns wrong result when caret itself is at word boundary.
https://bugs.webkit.org/show_bug.cgi?id=58504.
positionBeforeNextWord should take care that the current position is after current word.
positionAfterPreviousWord should take care that the current positin is before current word.
- editing/visible_units.cpp: (WebCore::positionBeforeNextWord): (WebCore::positionAfterPreviousWord):
- 5:08 PM Changeset in webkit [84709] by
-
- 1 edit10 adds in trunk/LayoutTests
2011-04-22 Xiaomei Ji <xji@chromium.org>
Rebaseline after r84655.
- platform/chromium-linux/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
- platform/chromium-mac-leopard/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added.
- platform/chromium-mac/fast/block/positioning/vertical-rl: Added.
- platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added.
- platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
- platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
- 4:59 PM Changeset in webkit [84708] by
-
- 7 edits4 adds in trunk/LayoutTests
2011-04-22 Xiaomei Ji <xji@chromium.org>
Rebase after r84659.
- platform/chromium-linux/editing/deleting/table-cells-expected.png:
- platform/chromium-linux/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
- platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png:
- platform/chromium-mac-leopard/editing/deleting/table-cells-expected.png:
- platform/chromium-mac-leopard/fast/inline-block/14498-positionForCoordinates-expected.png:
- platform/chromium-mac/editing/deleting/table-cells-expected.png: Added.
- platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.png: Added.
- platform/chromium-win/editing/deleting/table-cells-expected.png:
- platform/chromium-win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
- platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:
- 4:54 PM Changeset in webkit [84707] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Eric Seidel <eric@webkit.org>
Reviewed by Eric Carlson.
Flaky Test: media/invalid-media-url-crash.html
https://bugs.webkit.org/show_bug.cgi?id=51138
Add one more test to the list of known crashers from rdar://9054715.
- platform/mac-snowleopard/Skipped:
- 4:52 PM Changeset in webkit [84706] by
-
- 18 edits5 adds in trunk
2011-04-19 Jer Noble <jer.noble@apple.com>
Reviewed by Daniel Bates.
Full Screen from within an <iframe> does not cause <iframe> to resize.
https://bugs.webkit.org/show_bug.cgi?id=58638
- fullscreen/full-screen-frameset-expected.txt: Added.
- fullscreen/full-screen-frameset.html: Added.
- fullscreen/content/inner.html: Added.
- fullscreen/full-screen-iframe-allowed-expected.txt: Updated.
- fullscreen/full-screen-iframe-allowed.html: Add a button with which to trigger
full screen mode in Safari.
- fullscreen/full-screen-iframe-not-allowed-expected.txt: Updated.
- fullscreen/full-screen-iframe-not-allowed.html: Ditto.
- fullscreen/resources/allowed.html: Added.
- fullscreen/resources/inner.html: Added.
2011-04-19 Jer Noble <jer.noble@apple.com>
Reviewed by Daniel Bates.
Full Screen from within an <iframe> does not cause <iframe> to resize.
https://bugs.webkit.org/show_bug.cgi?id=58638
Tests: fullscreen/full-screen-frameset.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Add the
-webkit-full-screen pseudo class to frame elements which contain
full screen elements.
- css/fullscreen.css: (iframe:-webkit-full-screen): Add iframe-specific styling rules.
- dom/Document.cpp: (WebCore::Document::setContainsFullScreenElementRecursively): Added. Walk up each
successive document owner element, calling setContainsFullScreenElement() if
owner is a frame element.
(WebCore::Document::fullScreenIsAllowedForElement): Use the new Element::isFrameElementBase
call instead of checking the element's tag name.
(WebCore::Document::webkitWillEnterFullScreenForElement): Mark any containing
iframes as containing a full screen element.
(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
- dom/Element.h: (WebCore::Element::isFrameElementBase): Added.
- html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::allowFullScreen): Disable full screen from within
HTMLFrameElements.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Added.
- html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::containsFullScreenElement): Added. (WebCore::HTMLFrameElementBase::isFrameElementBase): Added.
2011-04-19 Jer Noble <jer.noble@apple.com>
Reviewed by Daniel Bates.
Full Screen from within an <iframe> does not cause <iframe> to resize.
https://bugs.webkit.org/show_bug.cgi?id=58638
Tests: fullscreen/full-screen-frameset-allowed.html
fullscreen/full-screen-frameset-not-allowed.html
Return the _element's document instead of the WKView's document, which
will be different in the case of elements within <iframe>s.
- WebView/WebFullScreenController.mm: (-[WebFullScreenController _document]):
2011-04-19 Jer Noble <jer.noble@apple.com>
Reviewed by Daniel Bates.
Full Screen from within an <iframe> does not cause <iframe> to resize.
https://bugs.webkit.org/show_bug.cgi?id=58638
Tests: fullscreen/full-screen-frameset-allowed.html
fullscreen/full-screen-frameset-not-allowed.html
- UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Cancel the background animation
if the full screen animation finishes first.
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): m_fullScreenRootLayer was uninitialized.
- 4:38 PM Changeset in webkit [84705] by
-
- 7 edits in trunk/Source/JavaScriptCore
Bug 59254 - DFG JIT - retain VariableRecords for args/var in all basic blocks,
such that this information is available for DCE. Also, since this enlarges the
size of BasicBlock, make Graph hold a vector of pointers to basic blocks, not a
vector of blocks.
Reviewed by Geoffrey Garen.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::VariableRecord::VariableRecord):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeBegin):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
(JSC::DFG::Graph::blockForBytecodeOffset):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
- 4:35 PM Changeset in webkit [84704] by
-
- 4 edits in trunk/Tools
2011-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CommitQueue should remember the expected failures from patch to patch
https://bugs.webkit.org/show_bug.cgi?id=59253
Previously, we stored the set of expected failures on the task object,
which meant the commit-queue forgot about them after each patch. This
patch moves them to the CommitQueue object so they will have a longer
lifetime.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
- Scripts/webkitpy/tool/commands/queues.py:
- 4:34 PM Changeset in webkit [84703] by
-
- 1 copy in tags/Safari-534.31
New tag.
- 4:29 PM Changeset in webkit [84702] by
-
- 13 edits in trunk
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Brian Weinstein.
WebKit2: Implement JavaScript unresponsiveness timer/callbacks
https://bugs.webkit.org/show_bug.cgi?id=59248
Stub out shouldInterruptJavaScript callbacks.
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp: (BrowserView::create):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::initialize):
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Brian Weinstein.
WebKit2: Implement JavaScript unresponsiveness callback
https://bugs.webkit.org/show_bug.cgi?id=59248
Add support for suspending JavaScript in response to a callback.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::shouldInterruptJavaScript):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::shouldInterruptJavaScript):
- UIProcess/WebUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::shouldInterruptJavaScript):
- 4:11 PM Changeset in webkit [84701] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Michael Saboff <msaboff@apple.com>
Reviewed by Maciej Stachowiak.
Creating copy of ContainerNode's when inserting or removing is inefficient
https://bugs.webkit.org/show_bug.cgi?id=58695
Eliminated node copying in willRemove() and insertedIntoDocument().
No new tests as this is a more efficient implementation of
existing code that is covered by existing tests.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::willRemove): Changed method to use RefPtr<> to protect against modification during removal. (WebCore::ContainerNode::insertedIntoDocument): Changed method to use RefPtr<> and two other deletion checks to protect against modification during insertion.
- 4:09 PM Changeset in webkit [84700] by
-
- 2 edits in trunk/Source/JavaScriptCore
Errk, build fix.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:04 PM Changeset in webkit [84699] by
-
- 32 edits in trunk/Source/WebCore
2011-04-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
We have an autogenerator, so use it
https://bugs.webkit.org/show_bug.cgi?id=59247
- bindings/js/JSCSSRuleCustom.cpp:
- bindings/js/JSCSSRuleListCustom.cpp:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
- bindings/js/JSCSSValueCustom.cpp:
- bindings/js/JSCanvasRenderingContextCustom.cpp:
- bindings/js/JSDOMImplementationCustom.cpp:
- bindings/js/JSDOMStringMapCustom.cpp:
- bindings/js/JSHTMLCollectionCustom.cpp:
- bindings/js/JSNamedNodeMapCustom.cpp:
- bindings/js/JSNodeCustom.h:
- bindings/js/JSNodeListCustom.cpp:
- bindings/js/JSStyleSheetCustom.cpp:
- bindings/js/JSStyleSheetListCustom.cpp: Removed repetitive hand-written code.
- bindings/scripts/CodeGeneratorJS.pm: Augmented autogenerator to do the job.
- css/CSSRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSValue.idl:
- css/MediaList.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- dom/DOMImplementation.idl:
- dom/DOMStringMap.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeList.idl:
- html/DOMTokenList.idl:
- html/HTMLCollection.idl:
- html/canvas/CanvasRenderingContext.idl: Updated attributes to plug into the autogenerator.
- 4:01 PM Changeset in webkit [84698] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-22 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
Paint the bounding rect of the dirty region instead of individual rectangles when the region
covers at least 3/4 of its bounds.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to achieve this actually works.
- 3:59 PM April 2011 Meeting edited by
- (diff)
- 3:47 PM Changeset in webkit [84697] by
-
- 3 edits in trunk/Tools
2011-04-22 Daniel Bates <dbates@webkit.org>
Reviewed by Csaba Osztrogonác.
webkit-patch land hangs if svn prompts for credentials
https://bugs.webkit.org/show_bug.cgi?id=31500
Make has_authorization_for_realm() return True only if there exists a credentials file
that contains either the word "password" or "passtype". We assume that these words don't
coincide with the actual credential data (e.g. a person's username is "password").
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Added test cases: test_has_authorization_for_realm_using_credentials_with_passtype(), test_has_authorization_for_realm_using_credentials_with_password(), test_not_have_authorization_for_realm_with_credentials_missing_password_and_passtype()
- Renamed test_not_have_authorization_for_realm() to test_not_have_authorization_for_realm_when_missing_credentials_file() to better describe what it's testing.
- Repurposed test_has_authorization_for_realm() to take realm and credential data to use and return the result of calling has_authorization_for_realm() so that the caller can assert the result; Renamed to _test_has_authorization_for_realm_using_credentials() to better reflect its new purpose.
- 3:45 PM Changeset in webkit [84696] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-04-22 Xiaomei Ji <xji@chromium.org>
Rebaseline after r84659.
- platform/mac-wk2/fast/forms: Added.
- platform/mac-wk2/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
- platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
- 3:44 PM Changeset in webkit [84695] by
-
- 13 edits in trunk/Source/WebCore
2011-04-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Kent Tamura.
Let the RenderTheme decide if an input type should have a spinner
https://bugs.webkit.org/show_bug.cgi?id=59246
Whether an input should have a spinner or not should
be a UI decision made by the RenderTheme. Remove
WebCore's default hasSpinButton values and defer
to the RenderTheme.
No change in functionality, covered by existing tests.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isRangeControl): expose isRangeControl for possible RenderTheme queries.
- html/HTMLInputElement.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): For both of these ask the render theme if the input should have a spinner.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::shouldHaveSpinButtonForInputElement): Steppable inputs (number, date, and range) but not range should have spinners. This does not change existing behavior.
- rendering/RenderTheme.h:
- dom/InputElement.h:
- html/BaseDateAndTimeInputType.cpp: remove hasSpinButton.
- html/BaseDateAndTimeInputType.h: remove hasSpinButton.
- html/InputType.cpp: remove hasSpinButton.
- html/InputType.h: remove hasSpinButton.
- html/NumberInputType.cpp: remove hasSpinButton.
- html/NumberInputType.h: remove hasSpinButton.
- 3:42 PM Changeset in webkit [84694] by
-
- 1 edit3 adds in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=59223
REGRESSION (r82185): iframe not displayed after navigation back to cached page
Reviewed by Maciej Stachowiak.
Manual test added.
- manual-tests/frame-layout-on-back.html: Added.
- manual-tests/resources/empty-document-goes-back.html: Added.
- manual-tests/resources/simple-iframe.html: Added.
- 3:36 PM Changeset in webkit [84693] by
-
- 6 edits2 adds in trunk
2011-04-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Sam Weinig.
HTMLFormControlElement::labels should allow custom attributes.
https://bugs.webkit.org/show_bug.cgi?id=59128
- fast/forms/labels-custom-property-expected.txt: Added.
- fast/forms/labels-custom-property.html: Added.
2011-04-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Sam Weinig.
HTMLFormControlElement::labels should allow custom attributes.
https://bugs.webkit.org/show_bug.cgi?id=59128
Cache the labels list when it is created and keep using it for future
labels calls.
Test: fast/forms/labels-custom-property.html
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):
- 3:34 PM Changeset in webkit [84692] by
-
- 2 edits in trunk/Tools
2011-04-22 Adam Barth <abarth@webkit.org>
Remove double-negative. (Sorry this was bugging me.)
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- 3:27 PM Changeset in webkit [84691] by
-
- 4 edits in trunk/Source/JavaScriptCore
Quick cleanup to SpeculativeJIT/NonSpeculativeJIT compile loop,
move out the call to checkConsistency().
Reviewed by Sam Weinig.
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
- 3:21 PM Changeset in webkit [84690] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Remove minimum texture size for compositor tiling
https://bugs.webkit.org/show_bug.cgi?id=59236
This was mistakenly committed in r83915 and causes bad filtering
on very small textures.
Tests: compositing/images/content-image-change.html
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::setTileSize):
- 3:20 PM April 2011 Meeting edited by
- (diff)
- 3:19 PM April 2011 Meeting edited by
- (diff)
- 3:18 PM April 2011 Meeting edited by
- (diff)
- 3:17 PM Changeset in webkit [84689] by
-
- 3 edits2 adds in trunk/Tools
2011-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor LayoutTestResultsReader out of CommitQueue
https://bugs.webkit.org/show_bug.cgi?id=59244
This code will be shared with the EWS when they start running tests.
- Scripts/webkitpy/tool/bot/layouttestresultsreader.py: Added.
- Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: Added.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 3:14 PM April 2011 Meeting edited by
- Add back changes that I inadvertently stepped on. (diff)
- 3:13 PM April 2011 Meeting edited by
- (diff)
- 3:10 PM Changeset in webkit [84688] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=59223
REGRESSION (r82185): iframe not displayed after navigation back to cached page
-and corresponding-
<rdar://problem/9323763>
Reviewed by Maciej Stachowiak.
Cache the scroll position in Document::setInPageCache() instead of
FrameView::resetScrollbarsAndClearContentsSize(), and only clear the contents size
for the mainFrame(). Still resetScrollbars() for other frames, which matches pre-
r82185 code.
- dom/Document.cpp:
(WebCore::Document::setInPageCache):
- page/FrameView.cpp:
(WebCore::FrameView::resetScrollbarsAndClearContentsSize):
- 3:09 PM April 2011 Meeting edited by
- Adding myself to line-layout talk. (diff)
- 3:07 PM April 2011 Meeting edited by
- (diff)
- 3:01 PM Changeset in webkit [84687] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-21 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
Provide default constructors for HashMap iterators.
https://bugs.webkit.org/show_bug.cgi?id=59151
These will be used to implement an iterator over EventTarget's
listeners.
- wtf/HashTable.h: (WTF::HashTableConstIteratorAdapter::HashTableConstIteratorAdapter): (WTF::HashTableIteratorAdapter::HashTableIteratorAdapter):
- 2:56 PM Changeset in webkit [84686] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-then-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=58977
r84604 fixed the bug, so we can unskip it.
- platform/qt/Skipped: Unskip platform/qt/fast/history/back-to-unreachable-url-then-forward.html.
- 2:37 PM Changeset in webkit [84685] by
-
- 3 edits4 deletes in trunk/LayoutTests
2011-04-22 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: Updated Chromium expectations after WK r84606
- platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
- platform/chromium-mac/fast/url/host-expected.txt: Removed.
- platform/chromium-mac/fast/url/path-expected.txt: Removed.
- platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
- platform/chromium-win/fast/url/host-expected.txt: Removed.
- platform/chromium-win/fast/url/path-expected.txt: Removed.
- 2:33 PM Changeset in webkit [84684] by
-
- 4 edits in trunk/Source/JavaScriptCore
Bug 59232 - DFG JIT - Add predecessor links to BasicBlocks
Reviewed by Geoff Garen.
These will be necessary for DCE support.
Also factor allocateVirtualRegisters out into its own method.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::blockForBytecodeOffset):
- dfg/DFGNode.h:
(JSC::DFG::Node::isTerminal):
- 2:32 PM Changeset in webkit [84683] by
-
- 11 edits in trunk/Source/WebCore
2011-04-22 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Kent Tamura.
Don't rely on hasSpinButton to check if an input type can be stepped
https://bugs.webkit.org/show_bug.cgi?id=59224
Add isSteppable to know for certain if an input type can
be stepped or not. Previously we were checking if the input
has a spin control or is the range input type. These are UI
details, but the step functionality does not require there
to be a UI.
No change in behavior, covered by existing tests.
- html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::isSteppable):
- html/BaseDateAndTimeInputType.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSteppable): (WebCore::HTMLInputElement::stepUpFromRenderer): remove the check for a spinner and range control and instead ASSERT that the type is steppable.
- html/HTMLInputElement.h:
- html/InputType.cpp: (WebCore::InputType::isSteppable):
- html/InputType.h:
- html/NumberInputType.cpp: (WebCore::NumberInputType::isSteppable):
- html/NumberInputType.h:
- html/RangeInputType.cpp: (WebCore::RangeInputType::isSteppable):
- html/RangeInputType.h:
- 2:24 PM Changeset in webkit [84682] by
-
- 2 edits in trunk/Source/WebKit2
Paint the bounding rect of the dirty region instead of individual rectangles when the region
covers at least 3/4 of its bounds.
Reviewed by Sam Weinig.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to
achieve this actually works.
- 2:20 PM Changeset in webkit [84681] by
-
- 7 edits in trunk
2011-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP frame-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58643
Update expected result to show that this test is passing now.
- http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
2011-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP frame-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58643
In this patch, I've audited all the callers to
SecurityOrigin::canDisplay to make sure they all the appropriate
Content-Security-Policy method as well. I'm not sure how to test all
these cases, but making this changes fixed the frame-src test.
- loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::loadPlugin):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
- While I was understanding this code, I fixed the FIXME here.
- loader/cache/CachedResourceLoader.h:
- 2:17 PM Changeset in webkit [84680] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Clear shared graphics context when destroying CanvasRenderingContext2D.
https://bugs.webkit.org/show_bug.cgi?id=59212
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
- 2:17 PM Changeset in webkit [84679] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-04-22 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Object.create creates uncachable objects
https://bugs.webkit.org/show_bug.cgi?id=59164
Use the prototype object's inheritorID, as we
should always have done
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::nullPrototypeObjectStructure):
- runtime/ObjectConstructor.cpp: (JSC::objectConstructorCreate):
- 2:05 PM Changeset in webkit [84678] by
-
- 3 edits3 adds in trunk
2011-04-22 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
End/Home keys do not work in a contentEditable element
https://bugs.webkit.org/show_bug.cgi?id=50564
Fixing modifying selection by lineboundary (home/end) for editable contexts that are
inline and share a line with non-editable content.
- editing/selection/modify-by-lineboundary-in-inline-editable-contexts-expected.txt: Added.
- editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html: Added.
- editing/selection/script-tests/modify-by-lineboundary-in-inline-editable-contexts.js: Added. (testModifyByLine):
2011-04-22 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
End/Home keys do not work in a contentEditable element
https://bugs.webkit.org/show_bug.cgi?id=50564
Changing logical[Start/End]OfLine to return a valid VisiblePosition for for editable contexts that are
inline and share a line with non-editable content.
Test: editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html
- editing/visible_units.cpp: (WebCore::logicalStartOfLine): (WebCore::logicalEndOfLine):
- 1:54 PM Changeset in webkit [84677] by
-
- 47 edits in trunk/LayoutTests
2011-04-22 Dimitri Glazkov <Dimitri Glazkov>
[Gtk] Update expectations after r84511.
- platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-1-expected.txt:
- platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-10-expected.txt:
- platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-2-expected.txt:
- platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-3-expected.txt:
- platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-4-expected.txt:
- platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-5-expected.txt:
- platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-6-expected.txt:
- platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-7-expected.txt:
- platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-8-expected.txt:
- platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-9-expected.txt:
- platform/gtk/fast/html/details-no-summary1-expected.txt:
- platform/gtk/fast/html/details-no-summary2-expected.txt:
- platform/gtk/fast/html/details-no-summary3-expected.txt:
- platform/gtk/fast/html/details-no-summary4-expected.txt:
- platform/gtk/fast/html/details-open-javascript-expected.txt:
- platform/gtk/fast/html/details-open1-expected.txt:
- platform/gtk/fast/html/details-open2-expected.txt:
- platform/gtk/fast/html/details-open3-expected.txt:
- platform/gtk/fast/html/details-open4-expected.txt:
- platform/gtk/fast/html/details-open5-expected.txt:
- platform/gtk/fast/html/details-open6-expected.txt:
- platform/gtk/fast/html/details-position-expected.txt:
- platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-1-expected.txt:
- platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-2-expected.txt:
- platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-3-expected.txt:
- platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-4-expected.txt:
- platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-5-expected.txt:
- platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-6-expected.txt:
- platform/gtk/fast/html/details-writing-mode-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt:
- 1:44 PM Changeset in webkit [84676] by
-
- 2 edits in trunk/Tools
2011-04-22 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
webkit-patch rebaseline is broken
https://bugs.webkit.org/show_bug.cgi?id=59207
My recent changes to how LayoutTestResults.results_from_string
uncovered a bug in our use of urllib2.
We now are treating the return value from _fetch_results_html()
(which returns urllib2.openurl()) as a string. That's incorrect,
the return value is a file-like object (which auto-converts to a
string in most cases).
I've updated our urllib2-using code to correctly call .read() on the
resulting object before treating it like a string.
Unfortunately there is no easy way to test this mis-understanding
of the openurl() semantics.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- 1:38 PM Changeset in webkit [84675] by
-
- 12 edits in trunk/Source/JavaScriptCore
Bug 59222 - DFG JIT - don't allocate virtual registers to nodes with no result
Reviewed by Sam Weinig.
We currently allocate virtual registers to nodes which have no result - these are
clearly unused, and may result in us allocating a larger than necessary stack frame.
Encapsulate Node::virtualRegister such that we can ASSERT this is only called on
nodes that have results, and improve the quality of output from the consistency check.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
- dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::canReuse):
(JSC::DFG::JITCodeGenerator::isFilled):
(JSC::DFG::JITCodeGenerator::isFilledDouble):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::integerResult):
(JSC::DFG::JITCodeGenerator::noResult):
(JSC::DFG::JITCodeGenerator::cellResult):
(JSC::DFG::JITCodeGenerator::jsValueResult):
(JSC::DFG::JITCodeGenerator::doubleResult):
(JSC::DFG::JITCodeGenerator::initConstantInfo):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::virtualRegister):
(JSC::DFG::Node::setVirtualRegister):
(JSC::DFG::Node::refCount):
(JSC::DFG::Node::ref):
(JSC::DFG::Node::deref):
(JSC::DFG::Node::adjustedRefCount):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::use):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
- 1:30 PM Changeset in webkit [84674] by
-
- 4 edits in trunk/LayoutTests
2011-04-22 Tony Chang <tony@chromium.org>
Landing new baselines for plugins/embedded-attributes-style.html after
border changes (r84273).
- platform/chromium-linux/plugins/embed-attributes-style-expected.png:
- platform/chromium-win/plugins/embed-attributes-style-expected.png:
- platform/chromium/test_expectations.txt:
- 1:28 PM Changeset in webkit [84673] by
-
- 46 edits in trunk/LayoutTests
[Qt] Update expected files after r84632.
- platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-1-expected.txt:
- platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-10-expected.txt:
- platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-2-expected.txt:
- platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-3-expected.txt:
- platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-4-expected.txt:
- platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-5-expected.txt:
- platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-6-expected.txt:
- platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-7-expected.txt:
- platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-8-expected.txt:
- platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-9-expected.txt:
- platform/qt/fast/html/details-no-summary1-expected.txt:
- platform/qt/fast/html/details-no-summary2-expected.txt:
- platform/qt/fast/html/details-no-summary3-expected.txt:
- platform/qt/fast/html/details-no-summary4-expected.txt:
- platform/qt/fast/html/details-open-javascript-expected.txt:
- platform/qt/fast/html/details-open1-expected.txt:
- platform/qt/fast/html/details-open2-expected.txt:
- platform/qt/fast/html/details-open3-expected.txt:
- platform/qt/fast/html/details-open4-expected.txt:
- platform/qt/fast/html/details-open5-expected.txt:
- platform/qt/fast/html/details-open6-expected.txt:
- platform/qt/fast/html/details-position-expected.txt:
- platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-1-expected.txt:
- platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-2-expected.txt:
- platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-3-expected.txt:
- platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-4-expected.txt:
- platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-5-expected.txt:
- platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-6-expected.txt:
- platform/qt/fast/html/details-writing-mode-expected.txt:
- 1:27 PM Changeset in webkit [84672] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
Make showTree/showTreeForThis aware of the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=52965
No new tests, because this code is only compiled in DEBUG.
- dom/Node.cpp: (WebCore::traverseTreeAndMark): Moved tree traversal logic here, adding
recursive sub-traversal of the shadow tree.
(WebCore::Node::showTreeAndMark): Changed to use the new tree traversal function.
- 1:11 PM Changeset in webkit [84671] by
-
- 15 edits in branches/chromium/742/Source/WebCore
Merge 84582 - 2011-04-21 Vangelis Kokkevis <vangelis@chromium.org> Reviewed by James Robinson. [chromium] Only update the contents of layers that are going to be drawn. Remove individual texture unreserves that happen after the layer draw calls with a single unreserve for all the textures in the texture manager. https://bugs.webkit.org/show_bug.cgi?id=59129 Tests: No new functionality. Covered by existing layout tests. * platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw): * platform/graphics/chromium/ContentLayerChromium.h: * platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::paintLayerContents): * platform/graphics/chromium/LayerRendererChromium.h: * platform/graphics/chromium/LayerTexture.cpp: * platform/graphics/chromium/LayerTexture.h: * platform/graphics/chromium/LayerTilerChromium.cpp: * platform/graphics/chromium/LayerTilerChromium.h: * platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawSurface): * platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::unprotectAllTextures): * platform/graphics/chromium/TextureManager.h: * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw): * platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::owner):
TBR=vangelis@chromium.org
- 1:11 PM Changeset in webkit [84670] by
-
- 12 edits1 delete in trunk
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough and Oliver Hunt.
Arrays should participate in global object forwarding fun
https://bugs.webkit.org/show_bug.cgi?id=59215
- Update results of prototype-inheritance-2 for new array behavior.
- Remove checks for primitives, since they were incorrect.
- Force function check to check a function not on a primitive (this wasn't happening by itself, since functions normally aren't enumerable in the DOM).
- Add exception to the test to not try and test HTMLProgressElement, since it is not available on all platforms. This allows us to remove the windows specific results.
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/script-tests/prototype-inheritance-2.js: (constructorNamesForWindow): (crawl):
- platform/win/fast/dom/prototype-inheritance-2-expected.txt: Removed.
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough and Oliver Hunt.
Arrays should participate in global object forwarding fun
https://bugs.webkit.org/show_bug.cgi?id=59215
- runtime/JSGlobalObject.h: (JSC::constructEmptyArray): (JSC::constructArray): Add variants of constructArray that take a global object.
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough and Oliver Hunt.
Arrays should participate in global object forwarding fun
https://bugs.webkit.org/show_bug.cgi?id=59215
Change callers of constructArray to use the new variant that takes
a global object.
- bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::types):
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profiles):
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain):
- bindings/js/JSMessageEventCustom.cpp: (WebCore::JSMessageEvent::ports):
- bindings/js/JSScriptProfileNodeCustom.cpp: (WebCore::JSScriptProfileNode::children):
- bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::toJS): (WebCore::JSWebGLRenderingContext::getAttachedShaders): (WebCore::JSWebGLRenderingContext::getSupportedExtensions):
- 1:05 PM Changeset in webkit [84669] by
-
- 3 edits in branches/chromium/742/Source/WebKit/chromium
Merge 84427 - 2011-04-20 Yuzhu Shen <yzshen@chromium.org> Reviewed by Tony Chang. [chromium] linux chromium doesn't set click count for mouse up events. https://bugs.webkit.org/show_bug.cgi?id=58921 The reason why we need such a fix is that the Pepper API passes this information to plugins, and some consumers (e.g., Flash) need it to detect double-clicks. * src/gtk/WebInputEventFactory.cpp: set click count for mouse up events.
TBR=commit-queue@webkit.org
- 1:03 PM Changeset in webkit [84668] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Unreviewed typo fix after r84522.
- WebCore.pro:
- 1:01 PM Changeset in webkit [84667] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Daniel Bates <dbates@rim.com>
Fix misspelled word in comment; tagets => targets.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
- 1:01 PM Changeset in webkit [84666] by
-
- 3 edits2 copies in branches/chromium/742
Merge 84604 - https://bugs.webkit.org/show_bug.cgi?id=57898REGRESSION (r82185): Scroll position not restored on navigation back to a page in the page cache-and corresponding-<rdar://problem/9226652>Reviewed by Dan Bernstein.Source/WebCore: The original fix for this change broke scroll-position restore for pages that are *not* in the page cache. This patch fixes both cached and non-cached pages by using the cachedScrollPosition() only for cached pages.* loader/HistoryController.cpp:(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):LayoutTests: * fast/loader/scroll-position-restored-on-back-non-cached-expected.txt: Added.* fast/loader/scroll-position-restored-on-back-non-cached.html: Added.
TBR=Beth Dakin
- 12:57 PM Changeset in webkit [84665] by
-
- 27 edits1 add in trunk
2011-04-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: Element and Document
https://bugs.webkit.org/show_bug.cgi?id=59178
- GNUmakefile.list.am:
- UseJSC.cmake:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp: Build!
- bindings/js/JSDOMImplementationCustom.cpp: (WebCore::JSDOMImplementationOwner::isReachableFromOpaqueRoots): (WebCore::JSDOMImplementationOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Use the opaque roots system for DOMImplementation. Also, DOMImplementation does not need to keep its document wrapper alive, since there's no DOM API for getting a DOMImplementation's document.
- bindings/js/JSDOMStringMapCustom.cpp: (WebCore::JSDOMStringMapOwner::isReachableFromOpaqueRoots): (WebCore::JSDOMStringMapOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Use the opaque roots system for DOMStringMap.
- bindings/js/JSDOMTokenListCustom.cpp: Added. (WebCore::JSDOMTokenListOwner::isReachableFromOpaqueRoots): (WebCore::JSDOMTokenListOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Use the opaque roots system for DOMTokenList.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::visitChildren):
- bindings/js/JSElementCustom.cpp: No more need for explicit marking.
- bindings/scripts/CodeGeneratorV8.pm: Boo on whoever made this design decision.
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::DOMImplementation): (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
- dom/DOMImplementation.h: (WebCore::DOMImplementation::create): (WebCore::DOMImplementation::ref): (WebCore::DOMImplementation::deref): (WebCore::DOMImplementation::document): Fixed the DOMImplementation ownership model to match other satellite objects in the DOM. This was necessary to fix some crashes due to incorrect reference counting.
- dom/DOMImplementation.idl:
- dom/DOMStringMap.idl:
- dom/Document.cpp: (WebCore::Document::~Document):
- dom/Document.h:
- dom/Element.cpp:
- dom/Element.h:
- dom/Element.idl:
- html/DOMTokenList.idl: Updated to match changes above.
2011-04-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: Element and Document
https://bugs.webkit.org/show_bug.cgi?id=59178
- fast/dom/dataset-gc-expected.txt:
- fast/dom/script-tests/dataset-gc.js: Changed this test not to be specific to proto. We have a general bug in the DOM that assignment to proto does not persist after garbage collection. While we should fix that bug, we don't want existing tests to tickle it, because it makes them flaky.
- 12:54 PM Changeset in webkit [84664] by
-
- 3 edits3 adds in trunk
2011-04-22 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Rounded corners don't looks smooth when background-image is a gradient
https://bugs.webkit.org/show_bug.cgi?id=59213
Add the "shrink background" behavior to the slow background
drawing code path.
Test: fast/backgrounds/gradient-background-leakage.html
- rendering/RenderBoxModelObject.cpp: (WebCore::backgroundRectAdjustedForBleedAvoidance): Utility function that returns a shrunk border rect based on the context scale. (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use backgroundRectAdjustedForBleedAvoidance() in both the fast and slow paths.
- 12:49 PM Changeset in webkit [84663] by
-
- 6 edits13 adds in trunk/LayoutTests
2011-04-22 Mike Reed <reed@google.com>
Reviewed by Eric Seidel.
Update expected images with new shadow code
[chromium, win] Multiple failures of shadow rendering layout tests
https://bugs.webkit.org/show_bug.cgi?id=58772
- platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
- platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
- platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png: Added.
- platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
- platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
- platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
- platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Added.
- platform/chromium-win-xp/fast/text/shadow-translucent-fill-expected.png: Added.
- platform/chromium-win-xp/fast/transforms: Added.
- platform/chromium-win-xp/fast/transforms/shadows-expected.png: Added.
- platform/chromium-win-xp/svg/css: Added.
- platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
- platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Added.
- platform/chromium-win-xp/transitions: Added.
- platform/chromium-win-xp/transitions/svg-text-shadow-transition-expected.png: Added.
- platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
- platform/chromium-win/svg/css/composite-shadow-text-expected.png:
- platform/chromium/test_expectations.txt:
- 12:46 PM Changeset in webkit [84662] by
-
- 3 edits2 copies in branches/chromium/742
Merge 84440 - 2011-04-20 Dimitri Glazkov <Dimitri Glazkov> Reviewed by Kent Tamura. REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element. https://bugs.webkit.org/show_bug.cgi?id=59037 * fast/events/simulated-click-disabled-expected.txt: Added. * fast/events/simulated-click-disabled.html: Added.2011-04-20 Dimitri Glazkov <Dimitri Glazkov> Reviewed by Kent Tamura. REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element. https://bugs.webkit.org/show_bug.cgi?id=59037 Test: fast/events/simulated-click-disabled.html * dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchSimulatedClick): Added check for disabled element.
TBR=Dimitri Glazkov
- 12:31 PM Changeset in webkit [84661] by
-
- 4 edits8 copies in branches/chromium/696
Merge 84655 - 2011-04-22 Levi Weintraub <leviw@chromium.org> Reviewed by Darin Fisher. REGRESSION: left property broken with position:fixed elements in RTL documents https://bugs.webkit.org/show_bug.cgi?id=59204 http://code.google.com/p/chromium/issues/detail?id=80216 Test: fast/block/positioning/rtl-fixed-positioning.html fast/block/positioning/vertical-rl/fixed-positioning.html Returning the proper scroll offsets for fixed position content in RTL documents. We regressed to X and Y offsets not updating while scrolling when we clamped to zero, but RTL documents scroll in negative space. * page/FrameView.cpp: (WebCore::FrameView::scrollXForFixedPosition): Properly handling RTL documents where the scroll origin and offsets are negative. (WebCore::FrameView::scrollYForFixedPosition): Properly handling vertical writing- mode RTL documents, like above. * platform/ScrollView.h: (WebCore::ScrollView::scrollOrigin): Changing this accessor to const.2011-04-22 Levi Weintraub <leviw@chromium.org> Reviewed by Darin Fisher. REGRESSION: left property broken with position:fixed elements in RTL documents https://bugs.webkit.org/show_bug.cgi?id=59204 http://code.google.com/p/chromium/issues/detail?id=80216 Test to ensure position:fixed works properly in RTL documents. * fast/block/positioning/rtl-fixed-positioning.html: Added. * fast/block/positioning/vertical-rl/fixed-positioning.html: Added. * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added. * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.png: Added. * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added. * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added. * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added. * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
TBR=leviw@chromium.org
- 12:26 PM Changeset in webkit [84660] by
-
- 16 edits in trunk/Source/JavaScriptCore
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84650 and r84654.
http://trac.webkit.org/changeset/84650
http://trac.webkit.org/changeset/84654
https://bugs.webkit.org/show_bug.cgi?id=59218
Broke Windows build (Requested by bweinstein on #webkit).
- API/JSCallbackObjectFunctions.h: (JSC::::init):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- heap/Handle.h: (JSC::HandleBase::operator!): (JSC::HandleBase::operator UnspecifiedBoolType*): (JSC::HandleTypes::getFromSlot):
- heap/HandleHeap.cpp: (JSC::HandleHeap::markStrongHandles): (JSC::HandleHeap::markWeakHandles): (JSC::HandleHeap::finalizeWeakHandles): (JSC::HandleHeap::writeBarrier): (JSC::HandleHeap::protectedGlobalObjectCount): (JSC::HandleHeap::isValidWeakNode):
- heap/HandleHeap.h: (JSC::HandleHeap::copyWeak): (JSC::HandleHeap::makeWeak): (JSC::HandleHeap::Node::slot):
- heap/HandleStack.cpp: (JSC::HandleStack::mark): (JSC::HandleStack::grow):
- heap/HandleStack.h: (JSC::HandleStack::zapTo): (JSC::HandleStack::push):
- heap/Heap.cpp: (JSC::HandleHeap::protectedObjectTypeCounts):
- heap/Local.h: (JSC::::set):
- heap/Strong.h: (JSC::Strong::set):
- heap/Weak.h: (JSC::Weak::set):
- runtime/StructureTransitionTable.h: (JSC::StructureTransitionTable::singleTransition): (JSC::StructureTransitionTable::setSingleTransition):
- runtime/WeakGCMap.h: (JSC::WeakGCMap::add): (JSC::WeakGCMap::set):
- runtime/WriteBarrier.h:
- 12:25 PM Changeset in webkit [84659] by
-
- 3 edits3 adds in trunk
2011-04-22 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Local caret rectangle calculation should be relative to its containing block.
https://bugs.webkit.org/show_bug.cgi?id=49508.
- fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
- fast/forms/cursor-at-editable-content-boundary.html: Added.
- platform/mac/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
2011-04-22 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Local caret rectangle calculation should be relative to its containing block.
https://bugs.webkit.org/show_bug.cgi?id=49508.
InlineBox and caret rectangle are positioned relative to its containing block.
So its left and right edge value should be relative to its containing block as well.
Test: fast/forms/cursor-at-editable-content-boundary.html
- rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
- 12:25 PM Changeset in webkit [84658] by
-
- 3 edits1 add in trunk/Tools
2011-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor PatchAnalysis task out of CommitQueueTask
https://bugs.webkit.org/show_bug.cgi?id=59220
This is a first step towards teaching the EWS to run tests.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/bot/patchanalysistask.py: Added.
- 12:18 PM April 2011 Meeting edited by
- (diff)
- 12:17 PM April 2011 Meeting edited by
- (diff)
- 12:08 PM Changeset in webkit [84657] by
-
- 1 edit13 adds in trunk/LayoutTests
2011-04-22 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: update Chromium baselines.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
- platform/chromium-mac-leopard/svg/filters/feDropShadow-expected.png: Added.
- 11:59 AM Changeset in webkit [84656] by
-
- 1 edit4910 deletes in trunk/LayoutTests
2011-04-22 Tony Chang <tony@chromium.org>
Unreviewed, deleting remaining .checksum files.
More will probably creep in over the next few days-- I'll do
another pass in a week or so.
- 11:56 AM April 2011 Meeting edited by
- (diff)
- 11:53 AM Changeset in webkit [84655] by
-
- 4 edits8 adds in trunk
2011-04-22 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Fisher.
REGRESSION: left property broken with position:fixed elements in RTL documents
https://bugs.webkit.org/show_bug.cgi?id=59204
http://code.google.com/p/chromium/issues/detail?id=80216
Test: fast/block/positioning/rtl-fixed-positioning.html
fast/block/positioning/vertical-rl/fixed-positioning.html
Returning the proper scroll offsets for fixed position content in RTL documents.
We regressed to X and Y offsets not updating while scrolling when we clamped to zero,
but RTL documents scroll in negative space.
- page/FrameView.cpp: (WebCore::FrameView::scrollXForFixedPosition): Properly handling RTL documents where the scroll origin and offsets are negative. (WebCore::FrameView::scrollYForFixedPosition): Properly handling vertical writing- mode RTL documents, like above.
- platform/ScrollView.h: (WebCore::ScrollView::scrollOrigin): Changing this accessor to const.
2011-04-22 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Fisher.
REGRESSION: left property broken with position:fixed elements in RTL documents
https://bugs.webkit.org/show_bug.cgi?id=59204
http://code.google.com/p/chromium/issues/detail?id=80216
Test to ensure position:fixed works properly in RTL documents.
- fast/block/positioning/rtl-fixed-positioning.html: Added.
- fast/block/positioning/vertical-rl/fixed-positioning.html: Added.
- platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added.
- platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
- platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
- platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added.
- platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
- platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
- 11:52 AM Changeset in webkit [84654] by
-
- 2 edits in trunk/Source/JavaScriptCore
Part of Windows build fix from r84650.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 11:51 AM Changeset in webkit [84653] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Eric Seidel.
Should assert on invalid type in FEComponentTransfer::apply
https://bugs.webkit.org/show_bug.cgi?id=57959
No functional change. No new tests needed.
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
- 11:43 AM Changeset in webkit [84652] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 MORITA Hajime <morrita@google.com>
Unreviewed crash fix.
- html/HTMLDetailsElement.cpp: (WebCore::DetailsSummaryElement::shouldInclude):
- 11:36 AM Changeset in webkit [84651] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 11:26 AM Changeset in webkit [84650] by
-
- 15 edits in trunk/Source/JavaScriptCore
2011-04-22 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make it harder to use HandleSlot incorrectly
https://bugs.webkit.org/show_bug.cgi?id=59205
Just add a little type fudging to make it harder to
incorrectly assign through a HandleSlot.
- API/JSCallbackObjectFunctions.h: (JSC::::init):
- JavaScriptCore.exp:
- heap/Handle.h: (JSC::HandleBase::operator!): (JSC::HandleBase::operator UnspecifiedBoolType*): (JSC::HandleTypes::getFromSlot):
- heap/HandleHeap.cpp: (JSC::HandleHeap::markStrongHandles): (JSC::HandleHeap::markWeakHandles): (JSC::HandleHeap::finalizeWeakHandles): (JSC::HandleHeap::writeBarrier): (JSC::HandleHeap::protectedGlobalObjectCount): (JSC::HandleHeap::isValidWeakNode):
- heap/HandleHeap.h: (JSC::HandleHeap::copyWeak): (JSC::HandleHeap::makeWeak): (JSC::HandleHeap::Node::slot):
- heap/HandleStack.cpp: (JSC::HandleStack::mark): (JSC::HandleStack::grow):
- heap/HandleStack.h: (JSC::HandleStack::zapTo): (JSC::HandleStack::push):
- heap/Heap.cpp: (JSC::HandleHeap::protectedObjectTypeCounts):
- heap/Local.h: (JSC::::set):
- heap/Strong.h: (JSC::Strong::set):
- heap/Weak.h: (JSC::Weak::set):
- runtime/StructureTransitionTable.h: (JSC::StructureTransitionTable::singleTransition): (JSC::StructureTransitionTable::setSingleTransition):
- runtime/WeakGCMap.h: (JSC::WeakGCMap::add): (JSC::WeakGCMap::set):
- runtime/WriteBarrier.h: (JSC::OpaqueJSValue::toJSValue): (JSC::OpaqueJSValue::toJSValueRef): (JSC::OpaqueJSValue::fromJSValue):
- 11:13 AM Changeset in webkit [84649] by
-
- 2 edits in trunk/Source/WebCore
Exclude scrollbars from the dirty rect passed to the document
https://bugs.webkit.org/show_bug.cgi?id=59206
Reviewed by Sam Weinig.
No test added because functionality is unchanged.
- platform/ScrollView.cpp:
(WebCore::ScrollView::paint): Compute a clip rectangle (analogous to the frame of the clip view
in an NSScrollView) by subtracting non-overlay scrollbars, and intersect the document dirty rect
with it. If the result is empty, avoid calling paintContents().
- 11:03 AM Changeset in webkit [84648] by
-
- 5 edits in trunk/Source/WebKit2
2011-04-22 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Allow MediaPlayerPrivateAVFoundation to be disabled via a preference.
https://bugs.webkit.org/show_bug.cgi?id=59179
Add API to allow the WebCore Settings preference to be called from the UIProcess.
- Shared/WebPreferencesStore.h: Added new preference definition macro.
- UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetAVFoundationEnabled): Added. (WKPreferencesGetAVFoundationEnabled): Added.
- UIProcess/API/C/WKPreferences.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Pass new preference along to WebCore
Settings.
- 11:00 AM Changeset in webkit [84647] by
-
- 1 edit6435 deletes in trunk/LayoutTests
2011-04-22 Tony Chang <tony@chromium.org>
Unreviewed, deleting .checksum files in platform/mac.
- 10:51 AM Changeset in webkit [84646] by
-
- 10 edits in trunk/Source
2011-04-22 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
https://bugs.webkit.org/show_bug.cgi?id=59147
Add a new isAVFoundationEnabled setting and check it before adding
MediaPlayerPrivateAVFoundationObjC to the media engine registry.
- WebCore.exp.in:
- page/Settings.cpp:
- page/Settings.h: (WebCore::Settings::setAVFoundationEnabled): Added. (WebCore::Settings::isAVFoundationEnabled): Added.
- platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): Check the settings added above.
2011-04-22 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
https://bugs.webkit.org/show_bug.cgi?id=59147
Add a new user default preference, and plumb that preference down to WebCore
Settings. Allow the fullScreenEnabled preference to override the new
isAVFoundationEnabled preference, so that clients of the legacy full screen
mode will continue to use that mode normally.
- WebView/WebPreferenceKeysPrivate.h: Add new preference key.
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): Set the default value of new
preference.
(-[WebPreferences setAVFoundationEnabled:]): Added.
(-[WebPreferences isAVFoundationEnabled]): Added.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChanged:]): Update the WebCore settings with the
new values from WebPreferences.
- 10:49 AM Changeset in webkit [84645] by
-
- 3 edits in trunk
Reviewed by Ojan Vafai. Bugzilla JavaScript changes by Adam Barth.
Bugzilla autocomplete should support frequent contributors who are not committers
https://bugs.webkit.org/show_bug.cgi?id=59209
- 10:49 AM Changeset in webkit [84644] by
-
- 2 edits in trunk/Source/WebKit/qt
Fix qt build.
- Api/qwebelement.cpp:
(setupScriptContext):
- 10:47 AM Changeset in webkit [84643] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2: Stop Responsiveness Timer when WebPageProxy closes or WebProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=59210
Reviewed by Sam Weinig.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Stop the responsiveness timer.
(WebKit::WebPageProxy::processDidCrash): Ditto.
- 10:40 AM Changeset in webkit [84642] by
-
- 2 edits in trunk/LayoutTests
Fix windows test result.
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- 10:37 AM Changeset in webkit [84641] by
-
- 25 edits in trunk
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Remove remaining uses of deprecated version of toJS
https://bugs.webkit.org/show_bug.cgi?id=59170
- fast/dom/prototype-inheritance-2-expected.txt: Add new passing results since we now use the correct global object. The remaining failures are pure JS objects (Array, Boolean, String, Number, Function).
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Remove remaining uses of deprecated version of toJS
https://bugs.webkit.org/show_bug.cgi?id=59170
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot): (DumpRenderTreeSupportGtk::ensureShadowRoot): Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Remove remaining uses of deprecated version of toJS
https://bugs.webkit.org/show_bug.cgi?id=59170
- DOM/WebDOMOperations.mm: (-[DOMElement _shadowRoot:]): (-[DOMElement _ensureShadowRoot:]): Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
2011-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Remove remaining uses of deprecated version of toJS
https://bugs.webkit.org/show_bug.cgi?id=59170
- bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toJS): (WebCore::JSCanvasRenderingContext2D::strokeStyle): (WebCore::JSCanvasRenderingContext2D::fillStyle): (WebCore::JSCanvasRenderingContext2D::createPattern):
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profiles):
- bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSSQLStatementErrorCallback::handleEvent):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMMimeTypeArrayCustom.cpp: (WebCore::JSDOMMimeTypeArray::nameGetter):
- bindings/js/JSDOMPluginArrayCustom.cpp: (WebCore::JSDOMPluginArray::nameGetter):
- bindings/js/JSDOMPluginCustom.cpp: (WebCore::JSDOMPlugin::nameGetter):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::namedItemGetter): (WebCore::JSDOMWindow::event):
- bindings/js/JSEventTarget.cpp: (WebCore::toJS):
- bindings/js/JSInjectedScriptHostCustom.cpp: Propagate stored global object down access chain.
(WebCore::InjectedScriptHost::nodeAsScriptValue):
Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
(WebCore::JSInjectedScriptHost::currentCallFrame):
(WebCore::JSInjectedScriptHost::inspectedNode):
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::nameGetter):
- bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList): (WebCore::JSNodeList::nameGetter):
- bindings/js/JSScriptProfileNodeCustom.cpp: (WebCore::JSScriptProfileNode::children):
- bindings/js/JSStyleSheetListCustom.cpp: (WebCore::JSStyleSheetList::nameGetter):
- bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument):
- bindings/scripts/CodeGeneratorJS.pm: Propagate stored global object down access chain.
- css/MediaQueryListListener.cpp: (WebCore::MediaQueryListListener::queryChanged): Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype, we will want refactor this to match other callbacks so we can remove this.
- 10:25 AM Changeset in webkit [84640] by
-
- 3 edits in trunk/Source/WebCore
2011-04-22 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Eric Seidel.
[Chromium]Mac UI polish to add left/right padding space for autofill popup window.
https://bugs.webkit.org/show_bug.cgi?id=58960
http://code.google.com/p/chromium/issues/detail?id=51077
No new test because Chromium Autofill popup window doesn't have any test framework.
This assumes only AutofillPopupMenuClient gives TexFieldPart appearance.
Only if Autofill popup window has right/left padding.
The code should be removed after Autofill popup window logic is separated from WebKit to Chromium.
- rendering/RenderThemeChromiumMac.h: Add popupInternalPaddingRight() and popupInternalPaddingLeft().
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft): Return padding size only if TextFieldPart is specified. (WebCore::RenderThemeChromiumMac::popupInternalPaddingRight): Return padding size only if TextFieldPart is specified.
- 9:51 AM Changeset in webkit [84639] by
-
- 1 edit8383 deletes in trunk/LayoutTests
2011-04-22 Tony Chang <tony@chromium.org>
Unreviewed, deleting .checksum files in platform/gtk and platform/qt*.
- 9:48 AM Changeset in webkit [84638] by
-
- 6 edits in trunk/Source/WebKit2
Give windowless plugins' context menus an owner window in the same thread as the plugin
In some cases, plugins pass the WKView's HWND to the ::TrackPopupMenu API. ::TrackPopupMenu
fails in this case because the WKView's HWND is owned by another process/thread. We work
around this by hooking the ::TrackPopupMenu API and providing our own window that's in the
same thread as the plugin instead.
I couldn't figure out how to write a test for this. :-(
Fixes <http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No context
menu appears when right-clicking on windowless Flash plugin
Reviewed by Brian Weinstein, and looked at suspiciously by Jeff Miller.
- Platform/Module.h: Added installIATHook on Windows.
- Platform/win/ModuleWin.cpp:
(WebKit::overwriteReadOnlyMemory): New helper function. Basically a wrapper around memcpy,
but uses ::VirtualProtect to allow writing to otherwise-read-only memory.
(WebKit::findFunctionPointerAddress): New helper function. The first overload iterates over
the imported modules and functions looking for the given one. If found, returns the address
of the function pointer that is used when calling that function. The second overload calls
the first, first passing it an enumerator for the image's imported modules, then passing it
an iterator for the image's delay-loaded modules.
(WebKit::Module::installIATHook): Added. Finds the address of the function pointer that's
used when code in this module calls the given function, then overwrites the function pointer
with the passed-in one. Future calls to the given function made by code in this module
should then end up calling to the passed-in function instead of the original one.
- Shared/Plugins/Netscape/NetscapePluginModule.h:
(WebKit::NetscapePluginModule::module): Added this simple getter.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Added some new Windows-only members.
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::CurrentPluginSetter::CurrentPluginSetter):
(WebKit::CurrentPluginSetter::~CurrentPluginSetter):
This RAII class sets/unsets the currentPlugin global.
(WebKit::registerPluginView): Changed to use instanceHandle() instead of the mysterious
gInstance.
(WebKit::NetscapePlugin::platformPostInitialize): For windowless plugins, hook the
::TrackPopupMenu API and create a window to be used as the owner for context menus created
by this plugin. (Also changed the ::CreateWindowExW call for windowed plugins to pass an
instance handle so that the window will be associated with WebKit.dll instead of
WebKit2WebProcess.exe. This should have no visible effect, but is more correct.)
(WebKit::NetscapePlugin::platformDestroy): For windowless plugins, destroy the context menu
owner window we created above.
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Set ourselves as the current plugin.
(WebKit::NetscapePlugin::hookedTrackPopupMenu): Added. This is the function that actually
gets called when windowless plugins call ::TrackPopupMenu. If the passed-in owner window is
owned by the current thread, we have nothing to do; ::TrackPopupMenu should work just fine.
Otherwise, we use the current plugin's context menu owner window as the context menu's
owner. We also set focus to the new owner window because otherwise weird behavior results
(e.g., it's possible to scroll the WKView while the context menu is up).
- 9:45 AM Changeset in webkit [84637] by
-
- 8 edits3 adds in trunk
2011-04-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT: implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=59082
- DumpRenderTree/gtk/EventSender.cpp: (scalePageByCallback): scalePageBy() support.
2011-04-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT: implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=59082
Unskipped tests that should pass now that
eventSender.scalePageBy() is supported in GTK.
- platform/gtk/Skipped:
- platform/gtk/fast/repaint/scale-page-shrink-expected.checksum: Added.
- platform/gtk/fast/repaint/scale-page-shrink-expected.png: Added.
- platform/gtk/fast/repaint/scale-page-shrink-expected.txt: Added.
2011-04-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT: implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=59082
Added support in DRT for webview scaling.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::scale):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
- 9:45 AM Changeset in webkit [84636] by
-
- 2 edits9 adds in trunk/Source/WebCore
Add code to enumerate all the functions imported by a particular Windows binary
PEImage is where all the logic starts. It represents a single Portable Executable (PE)
binary. The various enumerator classes are used in conjunction with PEImage to enumerate the
modules and functions imported by that image.
I couldn't figure out how to write a test for this. :-(
Part of <http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No
context menu appears when right-clicking on windowless Flash plugin
Reviewed by Sam Weinig, and given a good once-over by Jeff Miller.
- WebCore.vcproj/WebCore.vcproj: Added the new files.
- platform/win/PEImage.cpp: Added.
(WebCore::PEImage::PEImage): Checks that the module contains the expected magic numbers,
then initializes m_ntHeaders using the module.
(WebCore::PEImage::convertRVAToAddress): Converts a relative virtual address (RVA) to a
non-relative address, which can then be dereferenced. (The PE format uses RVAs in lots of
places.)
(WebCore::PEImage::dataDirectoryEntryAddress): Returns the address of the data associated
with the given entry in the image's DataDirectory.
- platform/win/PEImage.h: Added.
(WebCore::PEImage::isValid): We're a valid image if the validation code in our constructor
succeeded, in which case m_ntHeaders will be set.
- platform/win/ImportedFunctionsEnumerator.cpp: Added. This class enumerates all the
functions imported by the image from a single module by walking the Import Name Table (INT)
and Import Address Table (IAT).
(WebCore::ImportedFunctionsEnumerator::ImportedFunctionsEnumerator): Initialize our members.
(WebCore::ImportedFunctionsEnumerator::isAtEnd): The INT and IAT are both 0-terminated
arrays.
(WebCore::ImportedFunctionsEnumerator::next): Step to the next entries in the INT and IAT.
(WebCore::ImportedFunctionsEnumerator::currentFunctionName): Gets the address of the
function's name, if possible, using the INT.
(WebCore::ImportedFunctionsEnumerator::addressOfCurrentFunctionPointer): Returns the address
of the function pointer for the current function. This function pointer is used whenever
code in m_image calls the current function. (A future patch will take advantage of this by
overwriting this function pointer with another, thereby redirecting calls to that function.)
- platform/win/ImportedFunctionsEnumerator.h: Added.
- platform/win/ImportedModulesEnumeratorBase.h: Added. This base class is used by
ImportedModulesEnumerator and DelayLoadedModulesEnumerator, and allows code to be written
that works with either one.
- platform/win/ImportedModulesEnumerator.cpp: Added. This class enumerates all the
non-delay-loaded modules imported by the image by walking the image's import array.
(WebCore::ImportedModulesEnumerator::ImportedModulesEnumerator): Module import information
is stored in the IMAGE_DIRECTORY_ENTRY_IMPORT entry of the image's DataDirectory.
(WebCore::ImportedModulesEnumerator::isAtEnd): The import array is 0-terminated.
(WebCore::ImportedModulesEnumerator::next): Steps along the import array.
(WebCore::ImportedModulesEnumerator::currentModuleName): Gets the address of the module's
name.
(WebCore::ImportedModulesEnumerator::functionsEnumerator): Get's the addresses of the INT
and IAT for this module and wraps them in an ImportedFunctionsEnumerator.
- platform/win/ImportedModulesEnumerator.h: Added.
- platform/win/DelayLoadedModulesEnumerator.cpp: Added. This class enumerates all the
delay-loaded modules that are imported by the given PEImage by walking the image's
ImageDelayDescr array.
(WebCore::DelayLoadedModulesEnumerator::DelayLoadedModulesEnumerator): Delay-load
information is stored in the IMAGE_DIRECTORY_ENTRY_DELAY_IMPORT entry of the image's
DataDirectory.
(WebCore::DelayLoadedModulesEnumerator::isAtEnd): The delay-loaded modules array is
0-terminated.
(WebCore::DelayLoadedModulesEnumerator::next): Steps along the delay-loaded modules array.
(WebCore::DelayLoadedModulesEnumerator::currentModuleName): Gets the address of the module's
name out of the descriptor.
(WebCore::DelayLoadedModulesEnumerator::functionsEnumerator): Gets the INT and IAT for the
current module out of the descriptor and makes an ImportedFunctionsEnumerator from them.
(WebCore::DelayLoadedModulesEnumerator::convertPotentialRVAToAddress): Pre-VC7.0 images
stored non-relative addresses in the ImageDelayDescr structures, while VC7.0 and later
images store RVAs. This function abstracts away the difference.
- platform/win/DelayLoadedModulesEnumerator.h: Added.
- 9:44 AM Changeset in webkit [84635] by
-
- 5 edits2 adds in trunk/Source
Add a shared do-nothing window class that anyone can use
Fixes <http://webkit.org/b/59102> WebKit has too many dummy window classes
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.vcproj/WebCore.vcproj: Added DefWndProcWindowClass.{cpp,h}. Moved Arena.cpp out of
platform/win and into platform. Let VS reorder other files.
- platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Changed to use the shared
dummy window class instead of creating our own.
- platform/win/DefWndProcWindowClass.cpp: Added.
(WebCore::registerClass): Register it!
(WebCore::defWndProcWindowClassName): Register it and return it!
- platform/win/DefWndProcWindowClass.h: Added.
Source/WebKit2:
Use WebCore's do-nothing window class instead of creating our own
- WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::createDummyWindow): Less code!
- 9:39 AM Changeset in webkit [84634] by
-
- 2 edits in trunk/Source/WebKit2
2011-04-22 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Cannot play flash with NSPluginWrapper
https://bugs.webkit.org/show_bug.cgi?id=59125
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Handle the case when we have been called with a null plugin instance.
- 9:25 AM Changeset in webkit [84633] by
-
- 5 edits2 adds in trunk/Tools
2011-04-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
LayoutTestResults should know how to handle NRWT json files
https://bugs.webkit.org/show_bug.cgi?id=59168
LayoutTestResults was originally created to be a parallel
to existing NRWT architecture for dealing with results files.
But then it turns out that NRWT has no such architecture. :(
So this patch writes the necessary code to handle reading
full_results.json and unexpected_results.json files from
NRWT layout-test-results directories.
LayoutTestResults has thus morphed from being ORWT-only to
supporting both ORWT and NRWT. It's possible at some future
point that other pieces of the NRWT architecture will learn
how to read JSON files in which case this can go away.
This is all done for making it possible for the commit-queue
to run the tests using NWRT and be able to understand the results
(for flaky test reporting, etc.)
- Scripts/webkitpy/common/net/layouttestresults.py:
- Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/common/net/resultsjsonparser.py: Added.
- Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: Added.
- 9:13 AM Changeset in webkit [84632] by
-
- 62 edits16 adds in trunk
2011-04-21 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Content of <details> should be forwarded through the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=59055
- fast/html/details-add-child-1.html: Added.
- fast/html/details-add-child-2.html: Added.
- fast/html/details-remove-child-1.html: Added.
- fast/html/details-remove-child-2.html: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/html/details-add-child-1-expected.checksum: Added.
- platform/mac/fast/html/details-add-child-1-expected.png: Added.
- platform/mac/fast/html/details-add-child-1-expected.txt: Added.
- platform/mac/fast/html/details-add-child-2-expected.checksum: Added.
- platform/mac/fast/html/details-add-child-2-expected.png: Added.
- platform/mac/fast/html/details-add-child-2-expected.txt: Added.
- platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-1-expected.txt:
- platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-10-expected.txt:
- platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-2-expected.txt:
- platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-3-expected.txt:
- platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-4-expected.txt:
- platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-5-expected.txt:
- platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-6-expected.txt:
- platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-7-expected.txt:
- platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-8-expected.txt:
- platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-9-expected.txt:
- platform/mac/fast/html/details-add-summary-child-1-expected.txt:
- platform/mac/fast/html/details-add-summary-child-2-expected.txt:
- platform/mac/fast/html/details-no-summary1-expected.txt:
- platform/mac/fast/html/details-no-summary2-expected.txt:
- platform/mac/fast/html/details-no-summary3-expected.txt:
- platform/mac/fast/html/details-no-summary4-expected.txt:
- platform/mac/fast/html/details-open-javascript-expected.txt:
- platform/mac/fast/html/details-open1-expected.txt:
- platform/mac/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-open3-expected.txt:
- platform/mac/fast/html/details-open4-expected.txt:
- platform/mac/fast/html/details-open5-expected.txt:
- platform/mac/fast/html/details-open6-expected.txt:
- platform/mac/fast/html/details-position-expected.txt:
- platform/mac/fast/html/details-remove-child-1-expected.checksum: Added.
- platform/mac/fast/html/details-remove-child-1-expected.png: Added.
- platform/mac/fast/html/details-remove-child-1-expected.txt: Added.
- platform/mac/fast/html/details-remove-child-2-expected.checksum: Added.
- platform/mac/fast/html/details-remove-child-2-expected.png: Added.
- platform/mac/fast/html/details-remove-child-2-expected.txt: Added.
- platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-expected.txt:
- platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-2-expected.txt:
- platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-3-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-expected.txt:
- platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-5-expected.txt:
- platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-6-expected.txt:
- platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
- platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
- platform/mac/fast/html/details-writing-mode-expected.txt:
2011-04-21 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Content of <details> should be forwarded through the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=59055
- Made ShadowContentElement abstract and added shouldInclude() pure virtual method.
- Added SummaryContentElement, DetailsContentElement, DetailsSummaryElement as subclasses of ShadowContentElement.
- Gave two shadow children for HTMLDetailsElement. One is DetailsContentElement, that handles non-summary contents of <details>. Another is SummaryContentElement, that handles the main summary element.
- Removed most of RenderDetails custom layout mechanism, which is replaced by ShadowContentElement subclasses.
Tests: fast/html/details-add-child-1.html
fast/html/details-add-child-2.html
fast/html/details-remove-child-1.html
fast/html/details-remove-child-2.html
- dom/ShadowRoot.cpp: (WebCore::ShadowRoot::contentContainerFor): (WebCore::ShadowRoot::hostChildrenChanged): (WebCore::ShadowRoot::hasContentElement):
- dom/ShadowRoot.h:
- html/HTMLDetailsElement.cpp: (WebCore::DetailsContentElement::DetailsContentElement): (WebCore::DetailsContentElement::create): (WebCore::DetailsContentElement::shouldInclude): (WebCore::DetailsSummaryElement::DetailsSummaryElement): (WebCore::DetailsSummaryElement::create): (WebCore::DetailsSummaryElement::shouldInclude): (WebCore::HTMLDetailsElement::create): (WebCore::HTMLDetailsElement::HTMLDetailsElement): (WebCore::HTMLDetailsElement::ensureShadowSubtreeOf): (WebCore::findSummaryFor): (WebCore::HTMLDetailsElement::ensureMainSummary): (WebCore::HTMLDetailsElement::refreshMainSummary): (WebCore::HTMLDetailsElement::createShadowSubtree):
- html/HTMLDetailsElement.h:
- html/HTMLSummaryElement.cpp: (WebCore::SummaryContentElement::SummaryContentElement): (WebCore::SummaryContentElement::shouldInclude): (WebCore::SummaryContentElement::create): (WebCore::HTMLSummaryElement::createShadowSubtree):
- html/shadow/ShadowContentElement.h:
- rendering/RenderDetails.cpp: (WebCore::RenderDetails::RenderDetails): (WebCore::RenderDetails::addChild):
- rendering/RenderDetails.h:
- rendering/RenderSummary.cpp:
- rendering/RenderSummary.h:
- 8:51 AM Changeset in webkit [84631] by
-
- 7 edits2 adds in trunk
2011-04-21 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Extra GraphicsContext::save() in InlineTextBox::paintDecoration()
https://bugs.webkit.org/show_bug.cgi?id=59109
Remove an extraneous GraphicsContext::save() in InlineTextBox::paintDecoration().
Add an assertion that fires when a GraphicsContext() is destroyed with a non-
empty state stack. Fix canvas to avoid this assertion, since bad content might
trigger it.
Also add an assertion that fires for mismatched begin/endTransparencyLayers.
Test: fast/text/multiple-text-shadow-alpha.html
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::~HTMLCanvasElement): Make sure that the CanvasRenderingContext goes away before the ImageBuffer, so that CanvasRenderingContext2D has a chance to unwind the state stack in the ImageBuffer's GraphicsContext.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D): Balance unmatched state saves in the canvas context.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::~GraphicsContext): Assert that the stack is empty.
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer): (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer): Changes to allow for asserting for unmatched transparency layer begin/ends.
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration): Remove an unbalanced save().
- 8:39 AM Changeset in webkit [84630] by
-
- 2 edits in trunk/LayoutTests
Windows DRT needs an implementation of shadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=59081
Add media/audio-controls-do-not-fade-out.html, which uses layoutTestController.shadowRoot
to the win Skipped list to get the bots green.
- platform/win/Skipped:
- 8:34 AM Changeset in webkit [84629] by
-
- 6 edits in trunk/Source/WebCore
2011-04-22 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add Save As context menu item to the TextViewer.
https://bugs.webkit.org/show_bug.cgi?id=59196
- inspector/front-end/ResourceView.js: (WebInspector.ResourceSourceFrame.prototype.requestContent): (WebInspector.ResourceSourceFrame.prototype.suggestedFileName): (WebInspector.RevisionSourceFrame.prototype.requestContent): (WebInspector.RevisionSourceFrame.prototype.suggestedFileName):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.SourceFrameDelegateForScriptsPanel): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._initializeTextViewer): (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu): (WebInspector.SourceFrame.prototype.suggestedFileName): (WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled): (WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._contextMenu): (WebInspector.TextViewerDelegate.prototype.cancelEditing): (WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu): (WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu): (WebInspector.TextViewerDelegate.prototype.suggestedFileName):
- 8:21 AM Changeset in webkit [84628] by
-
- 2 edits in trunk/LayoutTests
Update the Windows-specific results after r84558.
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- 7:43 AM Changeset in webkit [84627] by
-
- 7 edits5 adds in trunk
2011-04-22 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Upstream Symbian platform plugin.
- Source/WebKit.pro: Add platformplugin path to the SUBDIRS.
2011-04-22 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Upstream Symbian platform plugin.
- QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
- symbian/platformplugin: Added.
- symbian/platformplugin/WebPlugin.cpp: Added. (ItemListDelegate::ItemListDelegate): (ItemListDelegate::paint): (Popup::Popup): (Popup::resizeEvent): (Popup::populateList): (Popup::onItemSelected): (Popup::updateSelectionsBeforeDialogClosing): (Popup::updateAndClose): (WebPopup::WebPopup): (WebPopup::~WebPopup): (WebPopup::createSingleSelectionPopup): (WebPopup::createMultipleSelectionPopup): (WebPopup::createPopup): (WebPopup::show): (WebPopup::hide): (WebPopup::popupClosed): (WebPopup::itemClicked): (SingleSelectionPopup::SingleSelectionPopup): (MultipleSelectionPopup::MultipleSelectionPopup): (WebNotificationPresenter::showNotification): (WebPlugin::supportsExtension): (WebPlugin::createExtension):
- symbian/platformplugin/WebPlugin.h: Added. (Popup::preSelectedIndices): (Popup::listWidget): (WebNotificationPresenter::WebNotificationPresenter): (WebNotificationPresenter::~WebNotificationPresenter):
- symbian/platformplugin/platformplugin.pro: Added.
- symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h. (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData): (QWebNotificationPresenter::QWebNotificationPresenter): (QWebNotificationPresenter::~QWebNotificationPresenter): (QWebTouchModifier::~QWebTouchModifier): (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler): (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
2011-04-22 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Upstream Symbian platform plugin
https://bugs.webkit.org/show_bug.cgi?id=58435
Exempting directory WebKit/qt/symbian/platformplugin from style guide.
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- 6:52 AM Changeset in webkit [84626] by
-
- 13 edits2 adds in trunk/Source
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=59094
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- gyp/streamline-inspector-source.sh:
- inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.dispose): (WebInspector.HeapSnapshotObjectNode.prototype._createProvider): (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider): (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotIteratorsTuple.prototype.dispose): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider): (MixInSnapshotNodeFunctions):
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose): (WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource): (WebInspector.HeapSnapshotRetainingPathsList.prototype.dispose): (WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths): (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext): (WebInspector.HeapSnapshotRetainingPathsList.prototype.searchCancelled): (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder): (WebInspector.DetailedHeapshotView.prototype.dispose): (WebInspector.DetailedHeapshotView.prototype.get profileWrapper): (WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper):
- inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotLoader): (WebInspector.HeapSnapshotLoader.prototype.finishLoading): (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk): (WebInspector.HeapSnapshot.prototype.pushBaseIds): (WebInspector.HeapSnapshot.prototype.createDiff): (WebInspector.HeapSnapshot.prototype._parseFilter): (WebInspector.HeapSnapshot.prototype.createEdgesProvider): (WebInspector.HeapSnapshot.prototype.createNodesProvider): (WebInspector.HeapSnapshot.prototype.createPathFinder): (WebInspector.HeapSnapshot.prototype.updateStaticData): (WebInspector.HeapSnapshotPathFinder): (WebInspector.HeapSnapshotPathFinder.prototype.updateRoots): (WebInspector.HeapSnapshotPathFinder.prototype._reset):
- inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotRealWorker): (WebInspector.HeapSnapshotRealWorker.prototype._messageReceived): (WebInspector.HeapSnapshotRealWorker.prototype.postMessage): (WebInspector.HeapSnapshotRealWorker.prototype.terminate): (WebInspector.HeapSnapshotFakeWorker): (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage): (WebInspector.HeapSnapshotFakeWorker.prototype.terminate): (WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker): (WebInspector.HeapSnapshotWorker): (WebInspector.HeapSnapshotWorker.prototype.createObject): (WebInspector.HeapSnapshotWorker.prototype.dispose): (WebInspector.HeapSnapshotWorker.prototype.disposeObject): (WebInspector.HeapSnapshotWorker.prototype.callGetter): (WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod.wrapCallback): (WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod): (WebInspector.HeapSnapshotWorker.prototype.callMethod): (WebInspector.HeapSnapshotWorker.prototype._findFunction): (WebInspector.HeapSnapshotWorker.prototype._messageReceived): (WebInspector.HeapSnapshotWorker.prototype._postMessage): (WebInspector.HeapSnapshotProxyObject): (WebInspector.HeapSnapshotProxyObject.prototype._callWorker): (WebInspector.HeapSnapshotProxyObject.prototype.dispose): (WebInspector.HeapSnapshotProxyObject.prototype.disposeWorker): (WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod): (WebInspector.HeapSnapshotProxyObject.prototype.callGetter): (WebInspector.HeapSnapshotProxyObject.prototype.callMethod): (WebInspector.HeapSnapshotLoaderProxy): (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.callLoadCallbacks): (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData): (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading): (WebInspector.HeapSnapshotLoaderProxy.prototype.get loaded): (WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading): (WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk): (WebInspector.HeapSnapshotProxy): (WebInspector.HeapSnapshotProxy.prototype.aggregates): (WebInspector.HeapSnapshotProxy.prototype.createDiff): (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider): (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider): (WebInspector.HeapSnapshotProxy.prototype.createPathFinder): (WebInspector.HeapSnapshotProxy.prototype.dispose): (WebInspector.HeapSnapshotProxy.prototype.finishLoading): (WebInspector.HeapSnapshotProxy.prototype.get loaded): (WebInspector.HeapSnapshotProxy.prototype.get nodeCount): (WebInspector.HeapSnapshotProxy.prototype.nodeFieldValuesByIndex): (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotProxy.prototype.get rootNodeIndex): (WebInspector.HeapSnapshotProxy.prototype.updateStaticData): (WebInspector.HeapSnapshotProxy.prototype.startLoading): (WebInspector.HeapSnapshotProxy.prototype.get totalSize): (WebInspector.HeapSnapshotProxy.prototype.get uid): (WebInspector.HeapSnapshotProviderProxy): (WebInspector.HeapSnapshotProviderProxy.prototype.isEmpty): (WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems): (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind): (WebInspector.HeapSnapshotPathFinderProxy): (WebInspector.HeapSnapshotPathFinderProxy.prototype.findNext): (WebInspector.HeapSnapshotPathFinderProxy.prototype.updateRoots): (WebInspector.HeapSnapshotsDiffProxy): (WebInspector.HeapSnapshotsDiffProxy.prototype.calculate): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
- inspector/front-end/HeapSnapshotWorker.js: Added. (WebInspector.UIString): (postMessageWrapper):
- inspector/front-end/HeapSnapshotWorkerDispatcher.js: Added. (WebInspector.HeapSnapshotWorkerDispatcher): (WebInspector.HeapSnapshotWorkerDispatcher.prototype._findFunction): (WebInspector.HeapSnapshotWorkerDispatcher.prototype.dispatchMessage):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=59094
- WebKit.gyp:
- 6:49 AM Changeset in webkit [84625] by
-
- 12 edits2 moves in trunk
2011-04-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix de-obfuscation of scripts inlined in html.
https://bugs.webkit.org/show_bug.cgi?id=58538
- inspector/debugger/resources/obfuscated.js:
- inspector/debugger/script-formatter-expected.txt:
- inspector/debugger/script-formatter.html: Renamed from LayoutTests/inspector/debugger/script-formatter.html-disabled.
2011-04-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix de-obfuscation of scripts inlined in html.
https://bugs.webkit.org/show_bug.cgi?id=58538
Use html tokenizer to find script boundaries instead of relying on scriptParsed events.
Test: inspector/debugger/script-formatter.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/JavaScriptFormatter.js: Renamed from Source/WebCore/inspector/front-end/UglifyJS/JavaScriptFormatter.js.
- inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter): (WebInspector.ScriptFormatter.prototype.formatContent): (WebInspector.ScriptFormatter.prototype._didFormatContent):
- inspector/front-end/ScriptFormatterWorker.js: (onmessage): (formatScript): (HTMLScriptFormatter): (HTMLScriptFormatter.prototype.format): (HTMLScriptFormatter.prototype.scriptStarted): (HTMLScriptFormatter.prototype.scriptEnded): (HTMLScriptFormatter.prototype.styleSheetStarted): (HTMLScriptFormatter.prototype.styleSheetEnded):
- inspector/front-end/SourceFile.js: (WebInspector.FormattedSourceFile.prototype._didRequestContent):
- inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer.prototype.scriptStarted): (WebInspector.SourceHTMLTokenizer.prototype.scriptEnded): (WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted): (WebInspector.SourceHTMLTokenizer.prototype.styleSheetEnded): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js:
- inspector/front-end/WebKit.qrc:
- 6:36 AM Changeset in webkit [84624] by
-
- 5 edits in trunk/Source
2011-04-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] misc API cleanup
https://bugs.webkit.org/show_bug.cgi?id=59194
- inspector/front-end/ExtensionAPISchema.json:
- inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane.prototype._setObject):
2011-04-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] misc API cleanup
https://bugs.webkit.org/show_bug.cgi?id=59194
- src/js/DevTools.js: (WebInspector.platformExtensionAPI):
- 6:18 AM Changeset in webkit [84623] by
-
- 3 edits in trunk/Source/WebCore
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: group content scripts in the scripts panel drop down.
https://bugs.webkit.org/show_bug.cgi?id=59108
- English.lproj/localizedStrings.js:
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
- 5:38 AM Changeset in webkit [84622] by
-
- 4 edits in trunk/Source/WebCore
2011-04-22 Mike West <mkwst@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Tiny improvement to UI for adding an XHR breakpoint
https://bugs.webkit.org/show_bug.cgi?id=59100
Improve web inspector UI around adding XHR breakpoints by adding
a textual label to the input-likespanused to specify which
XHR requests the breakpoint ought to target.
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
- inspector/front-end/inspector.css: (#breakpoint-condition-input):
- 5:35 AM Changeset in webkit [84621] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-22 Patrick Gansterer <Patrick Gansterer>
Unreviewed. Build fix for ENABLE(INTERPRETER) after r84556.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
- 5:34 AM Changeset in webkit [84620] by
-
- 7 edits1 add1 delete in trunk/Source/WebCore
2011-04-22 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments.
https://bugs.webkit.org/show_bug.cgi?id=59191
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent):
- inspector/front-end/ScriptFormatterWorker.js: (onmessage):
- inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype._loadResourceContent): (WebInspector.FormattedSourceFile.prototype._didRequestContent): (WebInspector.FormattedSourceMapping): (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine): (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation): (WebInspector.FormattedSourceMapping.prototype._convertPosition):
- inspector/front-end/UglifyJS/JavaScriptFormatter.js: Added. (FormattedContentBuilder): Helper class for building formatted script content. (FormattedContentBuilder.prototype.addToken): (FormattedContentBuilder.prototype.addSpace): (FormattedContentBuilder.prototype.addNewLine): (FormattedContentBuilder.prototype.increaseNestingLevel): (FormattedContentBuilder.prototype.decreaseNestingLevel): (FormattedContentBuilder.prototype.content): (FormattedContentBuilder.prototype.mapping): (Tokenizer): Wrapper class for UglifyJS tokenizer. (Tokenizer.prototype.content): (Tokenizer.prototype.next): (Tokenizer.prototype._convertUglifyToken): (JavaScriptFormatter): New formatter based on UglifyJS tokenizer. (JavaScriptFormatter.prototype.format):
- inspector/front-end/UglifyJS/process.js: Removed.
- inspector/front-end/WebKit.qrc:
- 5:32 AM Changeset in webkit [84619] by
-
- 16 edits1 add in trunk
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Refactor code prior to moving detailed heap snapshots into workers.
https://bugs.webkit.org/show_bug.cgi?id=59189
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/BinarySearch.js: Added.
- inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype._populate.sorted): (WebInspector.HeapSnapshotGridNode.prototype._populate): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren): (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate): (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort): (WebInspector.HeapSnapshotGridNode.prototype.sort): (WebInspector.HeapSnapshotObjectNode): (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode): (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode): (WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData): (WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived): (WebInspector.HeapSnapshotDiffNode.prototype.get data):
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort): (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged): (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting): (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter): (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave): (WebInspector.HeapSnapshotContainmentDataGrid): (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.setDataSource): (WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren): (WebInspector.HeapSnapshotDominatorsDataGrid): (WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource): (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged): (WebInspector.HeapSnapshotRetainingPathsList.prototype._performSorting): (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded): (WebInspector.DetailedHeapshotView.prototype._changeBase): (WebInspector.DetailedHeapshotView.prototype._changeView): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
- inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype.pushBaseNodeIds): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAndRewind): (WebInspector.HeapSnapshotEdgesProvider.prototype._serialize): (WebInspector.HeapSnapshotNodesProvider.prototype._serialize): (WebInspector.HeapSnapshotsDiff.prototype.calculate): (WebInspector.HeapSnapshotsDiff.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiff.prototype.pushBaseSelfSizes):
- inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider): (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider): (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotProviderProxy): (WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems): (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
- inspector/front-end/PleaseWaitMessage.js: (WebInspector.PleaseWaitMessage.prototype.showAndWaitFor): (WebInspector.PleaseWaitMessage.prototype.unlistenAndHide):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/utilities.js:
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Refactor code prior to moving detailed heap snapshots into workers.
https://bugs.webkit.org/show_bug.cgi?id=59189
- inspector/profiler/detailed-heapshots-comparison-sorting.html:
- inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest): (initialize_DetailedHeapshotTest.):
- inspector/profiler/heap-snapshot-expected.txt:
- inspector/profiler/heap-snapshot.html:
- 5:18 AM Changeset in webkit [84618] by
-
- 2 edits in trunk/Source/WebCore
2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed fix after r84484 -- conditional statement was inverted incorrectly.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.handleShortcut):
- 5:10 AM Changeset in webkit [84617] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Csaba Osztrogonác <Csaba Osztrogonác>
[WK2] CSP reporting doesn't work
https://bugs.webkit.org/show_bug.cgi?id=59192
- platform/mac-wk2/Skipped: Add http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html.
- 4:24 AM Changeset in webkit [84616] by
-
- 3 edits in trunk/LayoutTests
[Qt]fast/url/idna tests fail
https://bugs.webkit.org/show_bug.cgi?id=59187
- platform/qt/Skipped: Add fast/url/idna2003.html and fast/url/idna2008.html.
- platform/qt/fast/url/path-expected.txt: Update after r84606.
- 3:39 AM Changeset in webkit [84615] by
-
- 2 edits in trunk/Tools
2011-04-22 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][WK2] Qt should use the mac-wk2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=58536
- Scripts/old-run-webkit-tests:
- 3:04 AM Changeset in webkit [84614] by
-
- 3 edits in trunk/Source/WebCore
2011-04-22 Annie Sullivan <sullivan@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Timeline is too narrow
https://bugs.webkit.org/show_bug.cgi?id=58399
Changed Network Panel widths so that Timeline is 50%.
Added titles to the values in the other columns, so that a tooltip will show the value if the column is too narrow.
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable): Changed column widths. (WebInspector.NetworkPanel.prototype._toggleGridMode): Changed column widths. (WebInspector.NetworkDataGridNode.prototype.refreshResource): Added titles to column values. (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): Ditto (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell): Ditto (WebInspector.NetworkDataGridNode.prototype._refreshTimeCell): Ditto
- inspector/front-end/utilities.js: (Element.prototype.setTextAndTitle): Added new method to set the textContent and title of an Element at the same time, so that it can have a tooltip.
- 2:34 AM Changeset in webkit [84613] by
-
- 12 edits2 adds in trunk/Source/WebKit2
2011-04-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Sam Weinig.
[Qt][WK2] Implement DrawingAreaImpl for Qt.
https://bugs.webkit.org/show_bug.cgi?id=59171
- WebKit2.pro: Build files necessary for DrawingAreaImpl.
- DerivedSources.pro: Build message receivers for DrawingArea and DrawingAreaProxy.
- Shared/qt/LayerTreeContextQt.cpp: (WebKit::LayerTreeContext::LayerTreeContext): Stub. (WebKit::LayerTreeContext::~LayerTreeContext): Stub. (WebKit::LayerTreeContext::encode): Stub. (WebKit::LayerTreeContext::decode): Stub. (WebKit::LayerTreeContext::isEmpty): Stub. (WebKit::operator==): Stub.
- Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::paint): Don't translate the painter to accomodate the source rect. The rect is already adjusted at the call site.
- UIProcess/API/qt/qgraphicswkview.h: Add "Impl" to QGraphicsWKView::BackingStoreType.
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy): Create DrawingAreaProxyImpl if requested. (QWKPagePrivate::paint): Call the correct paint() method for DrawingAreaProxyImpl, since this drawing area will simple ASSERT_NOT_REACHED() in the "normal" paint().
- WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): Allow creation of DrawingAreaImpl for Qt.
- UIProcess/BackingStore.h: Add Qt-specific types and backing store.
- UIProcess/qt/BackingStoreQt.cpp: (WebKit::BackingStore::paint): Implemented. (WebKit::BackingStore::incorporateUpdate): Implemented. (WebKit::BackingStore::scroll): Implemented using QPixmap::scroll().
- UIProcess/DrawingAreaProxy.h: Enable drawing area message receivers for Qt.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Ditto.
- WebProcess/WebPage/DrawingArea.h: Ditto.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveMessage): Ditto.
- 2:10 AM Changeset in webkit [84612] by
-
- 2 edits in trunk/Source/WebKit2
WinCairo build fix. Unreviewed.
- WebProcess/Downloads/curl/DownloadCurl.cpp:
(WebKit::Download::useCredential):
Stubbed.
(WebKit::Download::continueWithoutCredential):
Stubbed.
(WebKit::Download::cancelAuthenticationChallenge):
Stubbed.
- 1:31 AM Changeset in webkit [84611] by
-
- 3 edits2 adds in trunk
<rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing audio-only media
https://bugs.webkit.org/show_bug.cgi?id=59180
Reviewed by Maciej Stachowiak.
Source/WebCore:
Test: media/audio-controls-do-not-fade-out.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Only start fading out the controls if there is
a video track.
LayoutTests:
- media/audio-controls-do-not-fade-out-expected.txt: Added.
- media/audio-controls-do-not-fade-out.html: Added.
- 12:40 AM Changeset in webkit [84610] by
-
- 5 edits2 adds in trunk/Source/WebKit2
Need to support authentication for downloads in WebKit2 on Windows
https://bugs.webkit.org/show_bug.cgi?id=59175
<rdar://problem/9206151>
<rdar://problem/8958280>
Reviewed by Maciej Stachowiak.
- WebProcess/Downloads/Download.cpp:
Include DownloadAuthenticationClient.h.
- WebProcess/Downloads/Download.h:
Declare a function to get or create the authentication client, a member
var to hold it, and functions that the client can call to use a
credential, continue without a credential, or cancel an auth challenge.
- WebProcess/Downloads/DownloadAuthenticationClient.cpp: Added.
(WebKit::DownloadAuthenticationClient::DownloadAuthenticationClient):
(WebKit::DownloadAuthenticationClient::receivedCredential):
Tell the Download to use the credential.
(WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
Tell the Download to continue with credentials.
(WebKit::DownloadAuthenticationClient::receivedCancellation):
Tell the Download to cancel the challenge.
- WebProcess/Downloads/DownloadAuthenticationClient.h: Added.
(WebKit::DownloadAuthenticationClient::create):
Return a new DownloadAuthenticationClient.
(WebKit::DownloadAuthenticationClient::detach):
Clear the Download.
(WebKit::DownloadAuthenticationClient::refAuthenticationClient):
(WebKit::DownloadAuthenticationClient::derefAuthenticationClient):
- WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::useCredential):
Create a CFURLCredentialRef from the WebCore credential, and tell
CFNetwork to use it for the auth challenge.
(WebKit::Download::continueWithoutCredential):
Call CFURLDownloadUseCredential with a null credential.
(WebKit::Download::cancelAuthenticationChallenge):
Cancel the download, and clear m_download.
(WebKit::Download::authenticationClient):
Create if needed and return a DownloadAuthenticationClient.
(WebKit::Download::platformInvalidate):
Detach the DownloadAuthenticationClient.
(WebKit::didReceiveAuthenticationChallengeCallback):
Call Download::didReceiveAuthenticationChallenge(), passing a
WebCore::AuthenticationChallenge with our DownloadAuthenticationClient.
(WebKit::Download::receivedCredential):
Get the client from the auth challenge, and call through to it.
(WebKit::Download::receivedRequestToContinueWithoutCredential):
Ditto.
(WebKit::Download::receivedCancellation):
Ditto.
- win/WebKit2.vcproj:
Add new files to project.
- 12:40 AM Changeset in webkit [84609] by
-
- 5 edits in trunk/Source/WebCore
2011-04-22 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Add FontItalics and FontSmallCaps enums to be used instead of boolean values.
https://bugs.webkit.org/show_bug.cgi?id=59080
No new tests as no new functionality added.
- css/CSSPrimitiveValueMappings.h: Add casts to/from FontItalics and FontSmallCaps
- css/CSSStyleSelector.cpp: Use new casts defined in PrimitiveValueMappings.h
- platform/graphics/Font.h: Use FontItalics enum.
- platform/graphics/FontDescription.h: Define and use FontItalics and FontSmallCaps enums.
- 12:23 AM Changeset in webkit [84608] by
-
- 2 edits in trunk/LayoutTests
2011-04-22 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
address maciej's styling feedback for results.html page
https://bugs.webkit.org/show_bug.cgi?id=59165
- fast/harness/results.html:
- 12:09 AM Changeset in webkit [84607] by
-
- 2 edits in trunk/Source/WebCore
2011-04-21 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: exception in front-end when user selects resource info for resource that does not have response headers yet
https://bugs.webkit.org/show_bug.cgi?id=59123
- inspector/front-end/ResourceCookiesView.js: (WebInspector.ResourceCookiesView): (WebInspector.ResourceCookiesView.prototype.show): (WebInspector.ResourceCookiesView.prototype.get _gotCookies): (WebInspector.ResourceCookiesView.prototype._buildCookiesTable):
Apr 21, 2011:
- 11:46 PM Changeset in webkit [84606] by
-
- 8 edits1 copy9 adds in trunk/LayoutTests
2011-04-21 Chris Weber <chris@lookout.net>
Reviewed by Adam Barth.
Add more test coverage to fast/url
https://bugs.webkit.org/show_bug.cgi?id=59142
The PASS/FAIL results for host, path, and port are set to match
Chromium. The PASS/FAIL results for idna2003 and idna2008 are set to
match those specifications.
- fast/url/host-expected.txt:
- fast/url/idna2003-expected.txt: Added.
- fast/url/idna2003.html: Added.
- fast/url/idna2008-expected.txt: Added.
- fast/url/idna2008.html: Added.
- fast/url/path-expected.txt:
- fast/url/port-expected.txt:
- fast/url/script-tests/host.js:
- fast/url/script-tests/idna2003.js: Added.
- fast/url/script-tests/idna2008.js: Added.
- fast/url/script-tests/path.js:
- fast/url/script-tests/port.js:
- 11:37 PM Changeset in webkit [84605] by
-
- 1 edit1 delete in trunk/Tools
2011-04-21 Tony Chang <tony@chromium.org>
Reviewed by Mihai Parparita.
Remove find-mismatched-layout-test-results since it's not needed in a
checksum free world.
https://bugs.webkit.org/show_bug.cgi?id=59156
- Scripts/find-mismatched-layout-test-results: Removed.
- 11:29 PM Changeset in webkit [84604] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=57898
REGRESSION (r82185): Scroll position not restored on navigation back to a page in
the page cache
-and corresponding-
<rdar://problem/9226652>
Reviewed by Dan Bernstein.
Source/WebCore:
The original fix for this change broke scroll-position restore for pages that are
*not* in the page cache. This patch fixes both cached and non-cached pages by
using the cachedScrollPosition() only for cached pages.
- loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
LayoutTests:
- fast/loader/scroll-position-restored-on-back-non-cached-expected.txt: Added.
- fast/loader/scroll-position-restored-on-back-non-cached.html: Added.
- 11:13 PM Changeset in webkit [84603] by
-
- 2 edits in trunk/Source/WebCore
2011-04-21 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Remove redundant calls to RenderStyle::setDisplay()
https://bugs.webkit.org/show_bug.cgi?id=59060
No new tests / no new functionality added.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove redundant calls to RenderStyle::setDisplay()
- 11:08 PM Changeset in webkit [84602] by
-
- 3 edits in trunk/Source/WebCore
2011-04-21 John Bauman <jbauman@chromium.org>
Reviewed by Kenneth Russell.
WebGL context drawing buffer may not be cleared if FBO bound
https://bugs.webkit.org/show_bug.cgi?id=58956
Clear the drawing buffer even if it's not currently bound, by
switching between FBOs around the clear. Also, make sure that we
handle depth and stencil masks properly.
No new tests, because testing this under DRT doesn't work.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::clearIfComposited): (WebCore::WebGLRenderingContext::depthMask):
- html/canvas/WebGLRenderingContext.h:
- 10:37 PM Changeset in webkit [84601] by
-
- 4 edits in trunk/Tools
Teach build-webkit and update-webkit that the WinCairo port does
not need the non-redistributable WebKitSupportLibraries.zip file.
Also append the _Cairo_CFLite label to the build target for the
default (no argument) case when building with '--wincairo'
Reviewed by Martin Robinson.
https://bugs.webkit.org/show_bug.cgi?id=58801
- Scripts/build-webkit: Don't die if WebKitSupportLibraries.zip doesn't exist.
- Scripts/webkitdirs.pm: Append '_Cairo_CFLite' to the default 'Release' build target when passed the '--wincairo' flag.
- Scripts/update-webkit: Don't die if WebKitSupportLibraries.zip doesn't exist.
- 10:01 PM Changeset in webkit [84600] by
-
- 8 edits in trunk
WebKit is erroneously modifying the DOM; adding 'aria-selected' to tables
https://bugs.webkit.org/show_bug.cgi?id=59140
Reviewed by Beth Dakin.
Source/WebCore:
WebKit should not modify the DOM when the screen reader requests certain things be set. There is no
specification that allows this behavior yet, but we are working on something for the future.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setARIAGrabbed):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelected):
(WebCore::AccessibilityRenderObject::setValue):
LayoutTests:
- accessibility/aria-combobox.html:
- platform/mac/accessibility/aria-combobox-expected.txt:
- platform/mac/accessibility/aria-slider-value-change-expected.txt:
- platform/mac/accessibility/aria-slider-value-change.html:
- 9:54 PM Changeset in webkit [84599] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84583.
http://trac.webkit.org/changeset/84583
https://bugs.webkit.org/show_bug.cgi?id=59173
"broke
http://trac.webkit.org/export/84593/trunk/LayoutTests/fast/js
/Object-create.html" (Requested by ggaren on #webkit).
- runtime/ObjectConstructor.cpp: (JSC::objectConstructorCreate):
- 9:26 PM Changeset in webkit [84598] by
-
- 2 edits in trunk/Source/WebKit2
Minimize synchronous calls during loading
https://bugs.webkit.org/show_bug.cgi?id=59169
<rdar://problem/9320128> REGRESSION(r84526): WK2 windows unresponsive
- UIProcess/API/mac/WKView.mm: (-[WKView resignFirstResponder]): (-[WKView _resetTextInputState]): Made _resetTextInputState deal with client side state only, letting Editor composition be discarded more discriminately.
- 8:45 PM Changeset in webkit [84597] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change - new baselines needed as
a result of r84589.
- platform/chromium/test_expectations.txt:
- 8:29 PM Changeset in webkit [84596] by
-
- 3 edits2 moves in trunk/Tools
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: obsolete old code, part 5: rename message_broker2 to message_broker
https://bugs.webkit.org/show_bug.cgi?id=58758
Since worker_mixin is now only used by worker, there's no point
in having it split across two files.
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added
- Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Removed.
- Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: * Added
- Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Removed.
- 8:28 PM Changeset in webkit [84595] by
-
- 2 edits1 delete in trunk/Tools
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: obsolete old code, part 4: merge worker_mixin into worker
https://bugs.webkit.org/show_bug.cgi?id=58756
Since worker_mixin is now only used by worker, there's no point
in having it split across two files.
- Scripts/webkitpy/layout_tests/layout_package/worker.py:
- Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Removed.
- 8:26 PM Changeset in webkit [84594] by
-
- 3 edits2 moves in trunk/Tools
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
https://bugs.webkit.org/show_bug.cgi?id=58754
test_runner hasn't been a great name for some time, since all of
the test running is actually done in worker and
single_test_runner. Rename to manager to match the terminology
elsewhere.
- Scripts/webkitpy/layout_tests/layout_package/manager.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py: Removed.
- Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 8:13 PM Changeset in webkit [84593] by
-
- 4 edits in trunk/Source
AX: order AccessibilityRole alphabetically
https://bugs.webkit.org/show_bug.cgi?id=31524
Reviewed by Beth Dakin.
Source/WebCore:
- accessibility/AccessibilityObject.h:
Source/WebKit/chromium:
- public/WebAccessibilityRole.h:
- 7:49 PM Changeset in webkit [84592] by
-
- 4 edits in trunk/Source/WebCore
2011-04-21 Jia Pu <jpu@apple.com>
Reviewed by Maciej Stachowiak.
[Mac] correctionPanelTimerFired() crashes due to rangeToBeReplaced being cleared.
https://bugs.webkit.org/show_bug.cgi?id=59155
<rdar://problem/9261698>
Make sure the range isn't cleared before calling windowRectForRange() on it. Also removed unused functions in Editor.h,
and fixed a typo in function name.
- editing/Editor.h:
- editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::correctionPanelTimerFired): (WebCore::SpellingCorrectionController::respondToChangedSelection):
- editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
- 7:48 PM Changeset in webkit [84591] by
-
- 3 edits1 delete in trunk/Tools
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: obsolete old threading code, part 2
https://bugs.webkit.org/show_bug.cgi?id=58753
This merges the test_runner2 code back into test_runner since
there's only a single type of test runner now.
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: Removed.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 7:41 PM Changeset in webkit [84590] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Triage failure for
media/video-zoom.html on chromium gpu bots.
- platform/chromium/test_expectations.txt:
- 7:30 PM Changeset in webkit [84589] by
-
- 34 edits in trunk
2011-04-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Add a feature define to allow <details> and <summary> to be disabled
https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>
- configure.ac:
2011-04-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Add a feature define to allow <details> and <summary> to be disabled
https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>
- Configurations/FeatureDefines.xcconfig:
2011-04-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Add a feature define to allow <details> and <summary> to be disabled
https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>
- features.gypi:
2011-04-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Add a feature define to allow <details> and <summary> to be disabled
https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>
- Configurations/FeatureDefines.xcconfig:
2011-04-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Add a feature define to allow <details> and <summary> to be disabled
https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>
No new tests; no behavior change.
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- features.pri:
- html/HTMLDetailsElement.cpp:
- html/HTMLSummaryElement.cpp:
- html/HTMLTagNames.in:
- html/shadow/DetailsMarkerControl.cpp:
- rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks):
- rendering/RenderDetails.cpp:
- rendering/RenderDetails.h:
- rendering/RenderDetailsMarker.cpp:
- rendering/RenderDetailsMarker.h:
- rendering/RenderObject.h:
- rendering/RenderSummary.cpp:
- rendering/RenderSummary.h:
- rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject):
2011-04-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Add a feature define to allow <details> and <summary> to be disabled
https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>
- Configurations/FeatureDefines.xcconfig:
2011-04-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Add a feature define to allow <details> and <summary> to be disabled
https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>
- Scripts/build-webkit:
- Tools.pro:
2011-04-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Roben.
Add a feature define to allow <details> and <summary> to be disabled
https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 7:29 PM Changeset in webkit [84588] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Suppress failures on chromium
win/linux from bug 59166.
- platform/chromium/test_expectations.txt:
- 7:01 PM Changeset in webkit [84587] by
-
- 5 edits in trunk
2011-04-21 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adele Peterson.
REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
https://bugs.webkit.org/show_bug.cgi?id=59053
- fast/events/shadow-boundary-crossing-expected.txt: Updated expected results.
- fast/events/shadow-boundary-crossing.html: Added new sub-test.
2011-04-21 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adele Peterson.
REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
https://bugs.webkit.org/show_bug.cgi?id=59053
Turns out, the relatedTarget of an event could be also an ancestor of an event,
not just its parent. Duh.
- dom/EventDispatcher.cpp: (WebCore::EventDispatcher::adjustToShadowBoundaries): Changed to use shadowHost
explicitly.
- 6:42 PM Changeset in webkit [84586] by
-
- 5 edits in trunk/Source/WebCore
2011-04-21 Michael Saboff <msaboff@apple.com>
Reviewed by Maciej Stachowiak.
Qualified names used for all TagName access, yet namespace usage is rare
https://bugs.webkit.org/show_bug.cgi?id=58997
The methods getElementsByTagName and getElementsByTagNameNS where
always creating and using QualifiedNames. QualifiedName::init
was consistently in the top 3 routines when running the Dromaeo
DOM-query benchmark. Split out the functionality so that
getElementsByTagName uses just the local name, an implied "*"
namespace and a separate TagNodeListCache keyed by an atomic name
instead of a QualifiedName. Access to elements via
getElementsByTagNameNS that have "*" namespace are forwarded to
getElementsByTagName as well. This provides ~10% speed up in that
Dromaeo test.
No new tests added, existing tests have coverage. The changes are
an optimization of existing functionality.
- dom/Node.cpp: (WebCore::Node::removeCachedTagNodeList): (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS): (WebCore::NodeListsNodeData::invalidateCaches): (WebCore::NodeListsNodeData::isEmpty):
- dom/Node.h:
- dom/NodeRareData.h:
- dom/TagNodeList.cpp: (WebCore::TagNodeList::~TagNodeList):
- 6:31 PM Changeset in webkit [84585] by
-
- 3 edits in trunk/Source/WebKit/wince
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
WinCE build fix after r84574.
- WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::canCopyCut): (WebKit::EditorClientWinCE::canPaste):
- WebCoreSupport/EditorClientWinCE.h:
- 6:30 PM Changeset in webkit [84584] by
-
- 16 edits in trunk/Source/WebCore
2011-04-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: more style- and node-related stuff
https://bugs.webkit.org/show_bug.cgi?id=59127
- bindings/js/JSCanvasRenderingContextCustom.cpp:
- bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::JSCanvasRenderingContextOwner::isReachableFromOpaqueRoots): (WebCore::JSCanvasRenderingContextOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): Use opaque roots for marking canvas rendering contexts, so JSNode isn't responsible for it.
- bindings/js/JSElementCustom.cpp: (WebCore::JSElement::markChildren):
- bindings/js/JSHTMLCanvasElementCustom.cpp:
- bindings/js/JSHTMLLinkElementCustom.cpp:
- bindings/js/JSHTMLStyleElementCustom.cpp: Removed obsolete marking code.
- bindings/js/JSNodeCustom.cpp: (WebCore::isObservable): (WebCore::isReachableFromDOM): (WebCore::JSNodeOwner::isReachableFromOpaqueRoots): Removed a bunch of CSS object model related special cases, since the CSS object model now tracks its own lifetime through the opaque roots system. Removed canvas special case, covered above.
- bindings/js/JSProcessingInstructionCustom.cpp:
- bindings/js/JSWebKitAnimationListCustom.cpp:
- dom/ProcessingInstruction.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLLinkElement.idl:
- html/HTMLStyleElement.idl:
- page/WebKitAnimationList.idl: Removed obsolete marking code.
- 6:30 PM Changeset in webkit [84583] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-21 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Object.create creates uncachable objects
https://bugs.webkit.org/show_bug.cgi?id=59164
Use the prototype object's inheritorID, as we
should always have done
- runtime/ObjectConstructor.cpp: (JSC::objectConstructorCreate):
- 6:05 PM Changeset in webkit [84582] by
-
- 15 edits in trunk/Source/WebCore
2011-04-21 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Only update the contents of layers that are going to
be drawn. Remove individual texture unreserves that happen
after the layer draw calls with a single unreserve for all the
textures in the texture manager.
https://bugs.webkit.org/show_bug.cgi?id=59129
Tests: No new functionality. Covered by existing layout tests.
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::paintLayerContents):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/LayerTexture.cpp:
- platform/graphics/chromium/LayerTexture.h:
- platform/graphics/chromium/LayerTilerChromium.cpp:
- platform/graphics/chromium/LayerTilerChromium.h:
- platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawSurface):
- platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::unprotectAllTextures):
- platform/graphics/chromium/TextureManager.h:
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::owner):
- 5:50 PM Changeset in webkit [84581] by
-
- 14 edits in tags/Safari-534.30/Source/WebKit2
Rollout 84526.
- 5:49 PM Changeset in webkit [84580] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/9311103>
Reviewed by Maciej Stachowiak.
Remove unnecessary QTKitServer and Apple Events permissions
from the WebProcess sandbox.
- WebProcess/com.apple.WebProcess.sb:
- 5:45 PM Changeset in webkit [84579] by
-
- 5 edits in trunk/Source
Versioning.
- 5:43 PM Changeset in webkit [84578] by
-
- 2 edits in trunk/Source/WebKit/win
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Windows build fix.
- WebCoreSupport/WebEditorClient.h:
- 5:42 PM Changeset in webkit [84577] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/9033535>
Reviewed by Maciej Stachowiak.
Mute sandbox violations when attempting to read a temporary
CFNetwork keychain.
- WebProcess/com.apple.WebProcess.sb:
- 5:38 PM Changeset in webkit [84576] by
-
- 1 copy in tags/Safari-534.30
New tag.
- 5:34 PM Changeset in webkit [84575] by
-
- 5 edits in trunk/Tools
2011-04-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch upload should assign the bug to you
https://bugs.webkit.org/show_bug.cgi?id=33699
This patch only re-assigns the bug if it is currently unassigned. We
can be more aggressive in the future if people want us to be more
agressive.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/postdiff.py:
- 5:33 PM Changeset in webkit [84574] by
-
- 31 edits in trunk/Source
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::canCopyCut): (WebKit::EditorClientImpl::canPaste):
- src/EditorClientImpl.h:
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::canCopyCut): (WebCore::EditorClientQt::canPaste):
- WebCoreSupport/EditorClientQt.h:
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::canCopyCut): (WebKit::EditorClient::canPaste):
- WebCoreSupport/EditorClientGtk.h:
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
- WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::canCopyCut): (WebEditorClient::canPaste):
- WebCoreSupport/WebEditorClient.h:
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
- WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::canCopyCut): (WebCore::EditorClientWx::canPaste):
- WebKitSupport/EditorClientWx.h:
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::canCopyCut): (WebEditorClient::canPaste):
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
- WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::canCopyCut): (WebCore::EditorClientHaiku::canPaste):
- WebCoreSupport/EditorClientHaiku.h:
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
- WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::canCopyCut): (WebCore::EditorClientEfl::canPaste):
- WebCoreSupport/EditorClientEfl.h:
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
canCopyCut and canPaste now takes Frame* for which supportedCopyCut and supportedPaste are called.
This allows editor client to grant copy/cut and paste permissions per origin.
- editing/EditorCommand.cpp: (WebCore::supportedCopyCut): (WebCore::supportedPaste):
- loader/EmptyClients.h: (WebCore::EmptyEditorClient::canCopyCut): (WebCore::EmptyEditorClient::canPaste):
- page/EditorClient.h:
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::canCopyCut): (WebKit::WebEditorClient::canPaste):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- 5:22 PM Changeset in webkit [84573] by
-
- 1 edit13 adds in trunk/LayoutTests
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Unreviwed, expecations change. Pick up chromium-win baselines
for r84522.
- platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
- platform/chromium-win/svg/filters/feDropShadow-expected.png: Added.
- 5:17 PM Changeset in webkit [84572] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Suppress failures possibly caused by bug 59158 on chromium win/linux:
fast/canvas/canvas-stroke{Path,Rect}-alpha-shadow.html = TEXT
- platform/chromium/test_expectations.txt:
- 5:10 PM Changeset in webkit [84571] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/8774116>
Reviewed by Maciej Stachowiak.
The WebProcess sandbox should only allow access to the
parts of the Darwin cache directory needed by the Security
framework.
- WebProcess/com.apple.WebProcess.sb:
- 5:06 PM Changeset in webkit [84570] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/9311053>
Reviewed by Maciej Stachowiak.
The WebProcess sandbox should not allow opening arbitrary
IOKit user clients. Restrict to a whitelist required for normal
WebProcess operation, including sound and accelerated graphics.
- WebProcess/com.apple.WebProcess.sb:
- 5:03 PM Changeset in webkit [84569] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/9311037>
Reviewed by Maciej Stachowiak.
The WebProcess sandbox should not allow modification of the
CoreAudio component cache.
- WebProcess/com.apple.WebProcess.sb:
- 4:58 PM Changeset in webkit [84568] by
-
- 3 edits2 moves1 add in trunk
fix
- 4:58 PM Changeset in webkit [84567] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/9263428>
Reviewed by Maciej Stachowiak.
The WebProcess sandbox should only allow outbound networking
to remote destinations and local kernel controls.
- WebProcess/com.apple.WebProcess.sb:
- 4:54 PM Changeset in webkit [84566] by
-
- 3 edits in trunk/Source/WebCore
Whoops, change lost during merge
- 4:49 PM Changeset in webkit [84565] by
-
- 1 edit1 add in trunk/LayoutTests
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Update baselines to accomodate the change in r84506. I wonder
how much having platform/mac in the search path hurts
chromium-win/-linux.
- platform/chromium-win/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.
- 4:44 PM Changeset in webkit [84564] by
-
- 1 edit1 move in trunk/LayoutTests
2011-04-21 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Move canvas test set-colors.html expected results out of platform/mac-leopard and into platform/mac
This test expected result pertains to all of mac, not just leopard.
https://bugs.webkit.org/show_bug.cgi?id=59139
- platform/mac-leopard/fast/canvas/set-colors-expected.txt: Removed.
- platform/mac/fast/canvas/set-colors-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/canvas/set-colors-expected.txt.
- 4:36 PM Changeset in webkit [84563] by
-
- 22 edits in trunk/LayoutTests
2011-04-21 Tony Chang <tony@chromium.org>
Embed checksums in more png files. Not sure how these were missed earlier.
- animations/missing-values-first-keyframe-expected.png:
- animations/missing-values-last-keyframe-expected.png:
- animations/opacity-transform-animation-expected.png:
- animations/suspend-transform-animation-expected.png:
- compositing/backface-visibility-expected.png:
- compositing/checkerboard-expected.png:
- compositing/geometry/ancestor-overflow-change-expected.png:
- compositing/geometry/tall-page-composited-expected.png:
- compositing/iframes/composited-iframe-scroll-expected.png:
- compositing/iframes/iframe-content-flipping-expected.png:
- compositing/iframes/nested-iframe-scrolling-expected.png:
- compositing/images/direct-pdf-image-expected.png:
- compositing/images/direct-svg-image-expected.png:
- compositing/overflow/zero-size-overflow-expected.png:
- compositing/reflections/backface-hidden-reflection-expected.png:
- compositing/reflections/remove-add-reflection-expected.png:
- compositing/tiling/constrained-layer-size-expected.png:
- compositing/z-order/negative-z-index-expected.png:
- transforms/3d/general/cssmatrix-3d-zoom-expected.png:
- transforms/3d/general/matrix-with-zoom-3d-expected.png:
- transitions/suspend-transform-transition-expected.png:
- 4:31 PM April 2011 Meeting edited by
- (diff)
- 4:29 PM Changeset in webkit [84562] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by NOBODY (OOPS!).
Unreviewed, expectations change - update chromium SVG baselines
after r84522.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- 4:24 PM Changeset in webkit [84561] by
-
- 4 edits in trunk/Source
2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82052.
http://trac.webkit.org/changeset/82052
https://bugs.webkit.org/show_bug.cgi?id=59135
New full screen api should be opt-in, not opt-out. (Requested
by jernoble on #webkit).
- WebView/WebPreferences.mm: (+[WebPreferences initialize]):
2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82052.
http://trac.webkit.org/changeset/82052
https://bugs.webkit.org/show_bug.cgi?id=59135
New full screen api should be opt-in, not opt-out. (Requested
by jernoble on #webkit).
- Shared/WebPreferencesStore.h:
- 4:24 PM Changeset in webkit [84560] by
-
- 3 edits in trunk/Tools
2011-04-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
ValidateChangeLogs doesn't work on SVN
https://bugs.webkit.org/show_bug.cgi?id=59115
svn-create-patch lies about the diff in the working copy by moving
ChangeLog entries to the top of the diff. That's fine on most cases,
but causes problems for ValidateChangeLogs, which is trying validate
the where the ChangeLog entry appears.
I haven't added a test for this change because I couldn't figure out
how to write one. The issue is more of an integration issue, which
we're not really set up to test in our unit testing framework. If this
patch had worked around the output from svn-create-patch, then I could
have tested that we behave correctly on sample svn-create-patch output,
but, in this case, I've removed the dependency on svn-create-patch. I
could test that we behave correctly on "svn diff" output, but we
already have those tests.
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/validatechangelogs.py:
- 4:22 PM Changeset in webkit [84559] by
-
- 1 edit18 adds in trunk/LayoutTests
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change - update chromium SVG baselines
after r84522.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
- platform/chromium-linux/svg/filters/feDropShadow-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
- platform/chromium-mac/svg/filters/feDropShadow-expected.png: Added.
- 4:20 PM Changeset in webkit [84558] by
-
- 5 edits in trunk
Fixed a failure seen in fast/dom/prototype-inheritance-2.html due to
wrong global object use.
Reviewed by Sam Weinig.
Source/WebCore:
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):
- bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter): Use the right global object.
LayoutTests:
- fast/dom/prototype-inheritance-2-expected.txt: Expect success!
- 4:10 PM Changeset in webkit [84557] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change - flaky tests.
- platform/chromium/test_expectations.txt:
- 4:08 PM Changeset in webkit [84556] by
-
- 120 edits in trunk/Source
2011-04-21 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Start moving to a general visitor pattern for GC traversal
https://bugs.webkit.org/show_bug.cgi?id=59141
This is just a rename:
markChildren -> visitChildren
markAggregate -> visitAggregate
markStack -> visitor
MarkStack -> typedef'd to SlotVisitor
- API/JSCallbackObject.h: (JSC::JSCallbackObjectData::visitChildren): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren): (JSC::JSCallbackObject::visitChildren):
- JavaScriptCore.exp:
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitStructures): (JSC::EvalCodeCache::visitAggregate): (JSC::CodeBlock::visitAggregate):
- bytecode/CodeBlock.h:
- bytecode/EvalCodeCache.h:
- bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::visitAggregate):
- bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::visitAggregate):
- bytecode/StructureStubInfo.h:
- debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::visitChildren):
- debugger/DebuggerActivation.h:
- heap/HandleHeap.cpp: (JSC::WeakHandleOwner::isReachableFromOpaqueRoots): (JSC::HandleHeap::markStrongHandles): (JSC::HandleHeap::markWeakHandles):
- heap/HandleHeap.h:
- heap/HandleStack.cpp: (JSC::HandleStack::mark):
- heap/HandleStack.h:
- heap/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
- heap/Heap.h:
- heap/MarkStack.cpp: (JSC::MarkStack::visitChildren): (JSC::MarkStack::drain):
- heap/MarkStack.h: (JSC::HeapRootVisitor::HeapRootVisitor): (JSC::HeapRootVisitor::mark): (JSC::HeapRootVisitor::visitor):
- heap/MarkedSpace.h:
- runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists):
- runtime/ArgList.h:
- runtime/Arguments.cpp: (JSC::Arguments::visitChildren):
- runtime/Arguments.h:
- runtime/Executable.cpp: (JSC::EvalExecutable::visitChildren): (JSC::ProgramExecutable::visitChildren): (JSC::FunctionExecutable::visitChildren):
- runtime/Executable.h:
- runtime/GetterSetter.cpp: (JSC::GetterSetter::visitChildren):
- runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
- runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
- runtime/JSActivation.cpp: (JSC::JSActivation::visitChildren):
- runtime/JSActivation.h:
- runtime/JSArray.cpp: (JSC::JSArray::visitChildren):
- runtime/JSArray.h: (JSC::JSArray::visitDirect):
- runtime/JSCell.h: (JSC::JSCell::JSCell::visitChildren):
- runtime/JSFunction.cpp: (JSC::JSFunction::visitChildren):
- runtime/JSFunction.h:
- runtime/JSGlobalObject.cpp: (JSC::visitIfNeeded): (JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
- runtime/JSONObject.cpp:
- runtime/JSObject.cpp: (JSC::JSObject::visitChildren):
- runtime/JSObject.h: (JSC::JSObject::visitDirect):
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::visitChildren):
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure):
- runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::visitChildren):
- runtime/JSStaticScopeObject.h:
- runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::overridesVisitChildren):
- runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::visitChildren):
- runtime/JSWrapperObject.h:
- runtime/JSZombie.h: (JSC::JSZombie::visitChildren):
- runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::visitChildren):
- runtime/NativeErrorConstructor.h:
- runtime/RegExpObject.cpp: (JSC::RegExpObject::visitChildren):
- runtime/RegExpObject.h:
- runtime/ScopeChain.cpp: (JSC::ScopeChainNode::visitChildren):
- runtime/ScopeChain.h:
- runtime/SmallStrings.cpp: (JSC::SmallStrings::visitChildren):
- runtime/SmallStrings.h:
- runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::visitChildren):
- runtime/Structure.h:
- runtime/StructureChain.cpp: (JSC::StructureChain::visitChildren):
- runtime/StructureChain.h: (JSC::StructureChain::createStructure):
2011-04-21 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Start moving to a general visitor pattern for GC traversal
https://bugs.webkit.org/show_bug.cgi?id=59141
This is just a rename:
markChildren -> visitChildren
markAggregate -> visitAggregate
markStack -> visitor
MarkStack -> typedef'd to SlotVisitor
- UserObjectImp.cpp: (UserObjectImp::visitChildren):
2011-04-21 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Start moving to a general visitor pattern for GC traversal
https://bugs.webkit.org/show_bug.cgi?id=59141
This is just a rename:
markChildren -> visitChildren
markAggregate -> visitAggregate
markStack -> visitor
MarkStack -> typedef'd to SlotVisitor
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::visitChildren):
- bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRule::visitChildren):
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::visitChildren):
- bindings/js/JSDOMBinding.cpp: (WebCore::visitActiveObjectsForContext): (WebCore::markDOMObjectWrapper):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::visitChildren):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMImplementationCustom.cpp: (WebCore::JSDOMImplementation::visitChildren):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren):
- bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::visitChildren):
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::visitChildren):
- bindings/js/JSElementCustom.cpp: (WebCore::JSElement::visitChildren):
- bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::markJSFunction):
- bindings/js/JSEventListener.h:
- bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::visitChildren):
- bindings/js/JSHTMLLinkElementCustom.cpp: (WebCore::JSHTMLLinkElement::visitChildren):
- bindings/js/JSHTMLStyleElementCustom.cpp: (WebCore::JSHTMLStyleElement::visitChildren):
- bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
- bindings/js/JSJavaScriptAudioNodeCustom.cpp: (WebCore::JSJavaScriptAudioNode::visitChildren):
- bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren):
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots): (WebCore::JSNamedNodeMap::visitChildren):
- bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::visitChildren):
- bindings/js/JSNodeCustom.cpp: (WebCore::isObservable): (WebCore::isReachableFromDOM): (WebCore::JSNodeOwner::isReachableFromOpaqueRoots): (WebCore::JSNode::visitChildren):
- bindings/js/JSNodeCustom.h:
- bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
- bindings/js/JSNodeFilterCondition.h:
- bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::visitChildren):
- bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::visitChildren):
- bindings/js/JSNodeListCustom.cpp: (WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
- bindings/js/JSProcessingInstructionCustom.cpp: (WebCore::JSProcessingInstruction::visitChildren):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::visitChildren):
- bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren):
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::visitChildren):
- bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::visitChildren):
- bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren):
- bindings/js/JSWebKitAnimationListCustom.cpp: (WebCore::JSWebKitAnimationList::visitChildren):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::visitChildren):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::visitChildren):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtRuntimeObject::visitChildren): (JSC::Bindings::QtInstance::markAggregate):
- bridge/qt/qt_instance.h:
- bridge/qt/qt_pixmapruntime.cpp:
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
- bridge/qt/qt_runtime.h:
- dom/EventListener.h: (WebCore::EventListener::visitJSFunction):
- dom/EventTarget.h: (WebCore::EventTarget::visitJSEventListeners):
- dom/Node.h:
- dom/NodeFilterCondition.h: (WebCore::NodeFilterCondition::visitAggregate):
- page/DOMWindow.h:
- workers/WorkerContext.h:
- 4:07 PM Changeset in webkit [84555] by
-
- 2 edits2 adds in trunk/LayoutTests
2011-04-21 Adam Barth <abarth@webkit.org>
Update test results to show that we're using ogv. I would have
preferred to make this test independent of which video codec we have,
but I didn't see a way to do that.
- platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt: Added.
- platform/chromium/media/csp-blocks-video-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 3:52 PM Changeset in webkit [84554] by
-
- 1 edit12822 deletes in trunk/LayoutTests
2011-04-21 Tony Chang <tony@chromium.org>
Unreviewed, deleting .checksum files in platform/chromium*
- 3:49 PM Changeset in webkit [84553] by
-
- 20 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=59048
Need to track whether overlay scrollbar is currently visible and in lower-
righthand corner
-and corresponding-
<rdar://problem/9211232>
Reviewed by Dan Bernstein.
Source/WebCore:
Whenever we start a new ScrollbarPartAnimation, check if the scrollbar is vertical
and showing (alpha of 1), and if so, call setVisibleScrollerThumbRect with the
knob rect, otherwise with an empty rect. ScrollAnimatorMac has a local rect to
track this value so that it can avoid sending messages across the ChromeClient to
the UIProcess if the rect has not changed.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::setVisibleScrollerThumbRect):
Plumbing for the chrome client.
- page/ChromeClient.h:
(WebCore::ChromeClient::notifyScrollerThumbIsVisibleInRect):
- page/FrameView.cpp:
(WebCore::FrameView::setVisibleScrollerThumbRect):
- page/FrameView.h:
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::setVisibleScrollerThumbRect):
New WebCoreSystemInterface function to get the knob rect.
- WebCore.exp.in:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
A new WebSystemInterface is needed for this.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
WebPageProxy now stores an IntRect of the scroller thumb set by WebCore through
the client.
_windowResizeMouseLocationIsInVisibleScrollerThumb tests if the parameter point is
inside the cached scroller thumb rect.
- UIProcess/API/mac/WKView.mm:
(-[WKView _windowResizeMouseLocationIsInVisibleScrollerThumb:]):
Client work to cache the rect.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::notifyScrollerThumbIsVisibleInRect):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::visibleScrollerThumbRect):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::notifyScrollerThumbIsVisibleInRect):
- WebProcess/WebCoreSupport/WebChromeClient.h:
New WebSystemInterface is needed by WebCore for this.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 3:47 PM Changeset in webkit [84552] by
-
- 3 edits in branches/chromium/742/Source/WebCore/platform/graphics/chromium
Merge 84542 - 2011-04-21 Adrienne Walker <enne@google.com> Reviewed by James Robinson. [chromium] Don't upload partially drawn tiles in the compositor https://bugs.webkit.org/show_bug.cgi?id=59112 Use the same set of tiles for painting as is used for updating. Before, a larger set of tiles were being uploaded, causing some to only be partially undirtied because they were not fully painted. As tiles are clear their dirty rect after being unpainted, this caused artifacts to appear when scrolling. Unfortunately, no layout test can test this behavior yet because scrolling invalidations are done differently in test shell. * platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateCompositorResources): * platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::uploadCanvas): (WebCore::LayerTilerChromium::updateFromPixels): * platform/graphics/chromium/LayerTilerChromium.h:
TBR=enne@google.com
- 3:44 PM Changeset in webkit [84551] by
-
- 1 edit in branches/chromium/742/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp
Merge 84529 - 2011-04-21 Adrienne Walker <enne@google.com> Reviewed by James Robinson. [chromium] Clamp dirty regions on content layers to layer bounds https://bugs.webkit.org/show_bug.cgi?id=58933 This prevents garbage being rendered when layers are resized and a previous invalidation (now off-layer) is no longer valid. * platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::paintContentsIfDirty):
TBR=enne@google.com
- 3:13 PM Changeset in webkit [84550] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r84548.
http://trac.webkit.org/changeset/84548
https://bugs.webkit.org/show_bug.cgi?id=59144
Broke chromium-win build (Requested by aklein on #webkit).
- wtf/Platform.h:
- 3:00 PM Changeset in webkit [84549] by
-
- 4 edits in trunk/Tools
2011-04-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
ValidateChangeLogs doesn't work on SVN
https://bugs.webkit.org/show_bug.cgi?id=59115
svn-create-patch lies about the diff in the working copy by moving
ChangeLog entries to the top of the diff. That's fine on most cases,
but causes problems for ValidateChangeLogs, which is trying validate
the where the ChangeLog entry appears.
I haven't added a test for this change because I couldn't figure out
how to write one. The issue is more of an integration issue, which
we're not really set up to test in our unit testing framework. If this
patch had worked around the output from svn-create-patch, then I could
have tested that we behave correctly on sample svn-create-patch output,
but, in this case, I've removed the dependency on svn-create-patch. I
could test that we behave correctly on "svn diff" output, but we
already have those tests.
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/validatechangelogs.py:
- 2:39 PM Changeset in webkit [84548] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-04-21 Adam Klein <adamk@chromium.org>
Reviewed by David Levin.
[fileapi] Worker File API calls that create Blobs fail in debug builds due to random number generator thread assertion
https://bugs.webkit.org/show_bug.cgi?id=55728
Enable WTF_MULTIPLE_THREADS for Chromium.
- wtf/Platform.h:
- 2:28 PM Changeset in webkit [84547] by
-
- 69 edits in trunk/LayoutTests
2011-04-21 Tony Chang <tony@chromium.org>
Unreviewed, embedding checksums in png files not in LayoutTests/platform.
- 2:27 PM April 2011 Meeting edited by
- (diff)
- 2:22 PM Changeset in webkit [84546] by
-
- 5 edits in trunk/Source/WebCore
2011-04-21 Nat Duca <nduca@chromium.org>
Reviewed by James Robinson.
[chromium] Fix artefacts in compositor HUD when resizing
https://bugs.webkit.org/show_bug.cgi?id=58969
HUD was using the tiler program and not setting the texture
transform. The HUD would thus draw with a texture transform based
on the last tile drawn, leading sometimes to distortion.
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::headsUpDisplayProgram):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
- 2:09 PM Changeset in webkit [84545] by
-
- 2 edits in trunk/Source/WebCore
2011-04-21 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
only return false if we actually in a skia-gpu accelerated canvas for isNativeFontRenderingAllowed
https://bugs.webkit.org/show_bug.cgi?id=59024
No new tests. The bug (and fix) depend on enabling SKIA_GPU. When that is enabled, the bug
shows all text w/o lcd rendering. This is a regression from a recent CL when we switch to
calling skia::SupportsPlatformPaint. This CL fixes that.
There should be no change for the default builds when SKIA_GPU is not enabled.
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
- 2:08 PM Changeset in webkit [84544] by
-
- 7 edits in trunk/Tools
2011-04-21 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
old-run-webkit-tests/new-run-webkit-tests shouldn't read or write .checksum files
https://bugs.webkit.org/show_bug.cgi?id=58402
- Scripts/old-run-webkit-tests: Don't read or write .checksum files.
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Don't write .checksum files.
- Scripts/webkitpy/layout_tests/port/base.py: Don't read .checksum files.
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
- Scripts/webkitpy/layout_tests/port/test.py: Update passing pngs to include a checksum.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 1:44 PM Changeset in webkit [84543] by
-
- 3 edits in trunk/Tools
2011-04-21 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
only expand visible rows
https://bugs.webkit.org/show_bug.cgi?id=59130
For the chromium port, where there are many expected failures,
expanding all of them is quite slow. Only expand the visible ones.
This makes the default case. Also, make the expanding async to
avoid totally killing the process.
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
- 1:19 PM Changeset in webkit [84542] by
-
- 4 edits in trunk/Source/WebCore
2011-04-21 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Don't upload partially drawn tiles in the compositor
https://bugs.webkit.org/show_bug.cgi?id=59112
Use the same set of tiles for painting as is used for updating.
Before, a larger set of tiles were being uploaded, causing some to
only be partially undirtied because they were not fully painted.
As tiles are clear their dirty rect after being unpainted, this caused
artifacts to appear when scrolling.
Unfortunately, no layout test can test this behavior yet because
scrolling invalidations are done differently in test shell.
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateCompositorResources):
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::uploadCanvas): (WebCore::LayerTilerChromium::updateFromPixels):
- platform/graphics/chromium/LayerTilerChromium.h:
- 12:49 PM Changeset in webkit [84541] by
-
- 5 edits in trunk/LayoutTests
2011-04-21 Dirk Schulze <krit@webkit.org>
Uneviewed rebaseline of win.
SVG feDropShadow implementation of SVG Filters 1.2
https://bugs.webkit.org/show_bug.cgi?id=52513
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 12:35 PM Changeset in webkit [84540] by
-
- 7 edits3 deletes in trunk
2011-04-21 Martin Robinson <mrobinson@igalia.com>
[GTK] DRT: implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=59082
Rolling out r84507 since it broke many GTK+ tests.
- platform/gtk/Skipped:
- platform/gtk/fast/repaint/scale-page-shrink-expected.checksum: Removed.
- platform/gtk/fast/repaint/scale-page-shrink-expected.png: Removed.
- platform/gtk/fast/repaint/scale-page-shrink-expected.txt: Removed.
2011-04-21 Martin Robinson <mrobinson@igalia.com>
[GTK] DRT: implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=59082
Rolling out r84507 since it broke many GTK+ tests.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-04-21 Martin Robinson <mrobinson@igalia.com>
[GTK] DRT: implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=59082
Rolling out r84507 since it broke many GTK+ tests.
- DumpRenderTree/gtk/EventSender.cpp:
- 12:31 PM Changeset in webkit [84539] by
-
- 4 edits in trunk/Source/WebKit2
2011-04-21 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Emit QWKPage::urlChanged() when navigating within the same document.
https://bugs.webkit.org/show_bug.cgi?id=59044
Hook up the didSameDocumentNavigationForFrame callback to QWKPage::urlChanged().
- UIProcess/API/qt/ClientImpl.cpp: (qt_wk_didSameDocumentNavigationForFrame):
- UIProcess/API/qt/ClientImpl.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
- 12:27 PM Changeset in webkit [84538] by
-
- 8 edits in trunk/Source/WebCore
2011-04-21 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
Fix a compile issue on Solaris 10 with Sun Studio 12,
ternary operators (?:) must have the same types
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::popArchiveForSubframe):
- loader/archive/ArchiveFactory.cpp: (WebCore::ArchiveFactory::create):
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconDataForIconURL):
- page/animation/AnimationBase.cpp: (WebCore::blendFunc):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollCornerStyle): (WebCore::RenderLayer::updateResizerStyle):
- rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::updateScrollbarPart):
- rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::RenderTextFragment):
- 12:22 PM Changeset in webkit [84537] by
-
- 6 edits in trunk/LayoutTests
2011-04-21 Dirk Schulze <krit@webkit.org>
Unreviewed rebaseline.
SVG feDropShadow implementation of SVG Filters 1.2
https://bugs.webkit.org/show_bug.cgi?id=52513
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 12:15 PM Changeset in webkit [84536] by
-
- 5 edits in trunk/LayoutTests
[Qt] Unreviewed. Update expected files after r84522.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 12:09 PM Changeset in webkit [84535] by
-
- 2 edits in trunk/Source/WebCore
2011-04-21 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
[chromium, win] Multiple failures of shadow rendering layout tests
https://bugs.webkit.org/show_bug.cgi?id=58772
No new tests. This CL fixes a regression in the following tests
fast/multicol/shadow-breaking.html
fast/repaint/shadow-multiple-horizontal.html
fast/repaint/shadow-multiple-strict-horizontal.html
fast/repaint/shadow-multiple-strict-vertical.html
fast/repaint/shadow-multiple-vertical.html
fast/text/shadow-translucent-fill.html
fast/transforms/shadows.html
svg/css/group-with-shadow.svg
svg/css/shadow-changes.svg
svg/css/text-shadow-multiple.xhtml
transitions/svg-text-shadow-transition.html
svg/css/composite-shadow-text.svg
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- 12:08 PM Changeset in webkit [84534] by
-
- 6 edits in trunk/Tools
2011-04-21 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Add way to garbage collect between each test when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=59126
- DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions): (runTest):
- Scripts/old-run-webkit-tests:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessage):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::TestController): (WTR::TestController::initialize): (WTR::TestController::resetStateToConsistentValues):
- WebKitTestRunner/TestController.h:
- 12:01 PM Changeset in webkit [84533] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: skip tests on Windows.
fast/dom/shadow/layout-tests-can-access-shadow.html is failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=59081
Skip all tests in fast/dom/shadow on Windows.
(shadowRoot accessor is not implemented on Windows yet)
- platform/win/Skipped:
- 11:56 AM Changeset in webkit [84532] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Roll in downstream failures as of Chromium r82532.
- platform/chromium/test_expectations.txt:
- 11:46 AM Changeset in webkit [84531] by
-
- 3 edits in trunk/Source/WebCore
Try to fix the Qt build.
- UseJSC.cmake:
- WebCore.pro: Use correct file name.
- 11:45 AM Changeset in webkit [84530] by
-
- 2 edits in trunk/Source/WebCore
2011-04-21 Dirk Schulze <krit@webkit.org>
Unreviewed Qt build fix.
SVG feDropShadow implementation of SVG Filters 1.2
https://bugs.webkit.org/show_bug.cgi?id=52513
- CodeGenerators.pri:
- 11:39 AM Changeset in webkit [84529] by
-
- 2 edits in trunk/Source/WebCore
2011-04-21 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Clamp dirty regions on content layers to layer bounds
https://bugs.webkit.org/show_bug.cgi?id=58933
This prevents garbage being rendered when layers are resized and a
previous invalidation (now off-layer) is no longer valid.
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::paintContentsIfDirty):
- 11:32 AM Changeset in webkit [84528] by
-
- 4 edits2 adds in trunk
2011-04-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 59012 - Shadows should be imported along with their host nodes
https://bugs.webkit.org/show_bug.cgi?id=59012
Verify that the shadow of a bound element is imported along with the element.
- fast/dom/shadow/import-shadowroot-expected.txt: Added.
- fast/dom/shadow/import-shadowroot.html: Added.
2011-04-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 59012 - Shadows should be imported along with their host nodes
https://bugs.webkit.org/show_bug.cgi?id=59012
Copy the shadow tree of an element (even on a shallow copy!).
Test: fast/dom/shadow/import-shadowroot.html
- dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties):
- dom/Element.h:
- 11:29 AM Changeset in webkit [84527] by
-
- 38 edits1 add in trunk/Source/WebCore
2011-04-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a use of markDOMObjectWrapper: CSS Object Model
https://bugs.webkit.org/show_bug.cgi?id=59057
This is 24 hours of my life I will never get back. Thank you, W3C.
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj: Build!
- bindings/js/JSCSSFontFaceRuleCustom.cpp:
- bindings/js/JSCSSImportRuleCustom.cpp:
- bindings/js/JSCSSMediaRuleCustom.cpp:
- bindings/js/JSCSSPageRuleCustom.cpp:
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRuleOwner::isReachableFromOpaqueRoots): (WebCore::JSCSSRuleOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::JSCSSRule::markChildren):
- bindings/js/JSCSSRuleListCustom.cpp: (WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots): (WebCore::JSCSSRuleListOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS):
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclarationOwner::isReachableFromOpaqueRoots): (WebCore::JSCSSStyleDeclarationOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::JSCSSStyleDeclaration::markChildren): Removed custom mark functions, and replaced with use of the opaque roots system. This has the nice benefit of allowing us to eagerly recycle far more CSS wrappers and their associated DOM wrappers.
(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue): Made this function
custom because it must maintain the sorrowful invariant that primitive
values can be mapped back to objects that are reachable through the DOM.
We maintain this invariant through an external hash table because
making all primitive values bigger would be a too-large memory use
penalty. Luckily, nobody uses this feature, so the cost of the hash table
is no big deal.
(WebCore::toJS): We need a custom toJS so we can specify our own WeakHandleOwner.
- bindings/js/JSCSSStyleRuleCustom.cpp: Removed custom mark, as above.
- bindings/js/JSCSSValueCustom.cpp: (WebCore::cssValueRoots): (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots): (WebCore::JSCSSValueOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): Use the opaque roots system. Piggy-back on the external hash table filled by JSCSSStyleDeclaration::getPropertyCSSValue.
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::markChildren): No need to mark our stylesheet list, since all style-related objects can use our opaque root to determine liveness.
- bindings/js/JSMediaListCustom.cpp: Added. (WebCore::JSMediaListOwner::isReachableFromOpaqueRoots): (WebCore::JSMediaListOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Use the opaque roots system.
- bindings/js/JSNodeCustom.h: (WebCore::root): Added helpers for computing style-related roots.
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheetOwner::isReachableFromOpaqueRoots): (WebCore::JSStyleSheetOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::JSStyleSheet::markChildren): Use the opaque roots system instead of direct marking.
- bindings/js/JSStyleSheetListCustom.cpp: (WebCore::JSStyleSheetListOwner::isReachableFromOpaqueRoots): (WebCore::JSStyleSheetListOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Ditto.
- bindings/js/JSWebKitCSSKeyframeRuleCustom.cpp:
- bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp:
- css/CSSFontFaceRule.idl:
- css/CSSImportRule.idl: No more custom mark, since we use the opaque roots system instead.
- css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::CSSMediaRule): Fixed a bug where a media rule would incorrectly have no parent, since this got in the way of correctly computing the media rule's root.
- css/CSSMediaRule.idl:
- css/CSSPageRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleRule.idl:
- css/MediaList.idl: Match behavior changes above.
- css/StyleBase.cpp: (WebCore::StyleBase::node): Helper function for computing roots of the style system. This object model is pretty weird and not very well factored, but I'm pretty sure this covers all the relevant cases.
- css/StyleBase.h:
- css/StyleSheetList.idl:
- css/WebKitCSSKeyframeRule.idl:
- css/WebKitCSSKeyframesRule.idl: Updated to match the behavior changes above.
- 11:29 AM Changeset in webkit [84526] by
-
- 14 edits in trunk/Source/WebKit2
Reviewed by Maciej Stachowiak.
WebKit2: Unconfirmed inline input session persists after reload
https://bugs.webkit.org/show_bug.cgi?id=59054
<rdar://problem/9291086>
Makes the inline input get properly confirmed or discarded when changing selection,
navigating to another page, focusing another view in the window, or after a web process
crash.
- Shared/EditorState.h: (WebKit::EditorState::EditorState):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::editorState): Added a variable that Editor sets while processing input method calls. We don't want selection changes caused by -setMarkedText: discard the composition!
- UIProcess/PageClient.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::updateTextInputState): (WebKit::PageClientImpl::resetTextInputState): Extended updateSecureInputState() to potentially confirm the current inline input session. Added resetTextInputState, which is to be called when we get out of the current web page.
- UIProcess/API/mac/WKView.mm: (-[WKView resignFirstResponder]): Just call _resetTextInputState instead of dealing with input state here. (-[WKView _updateSecureInputState]): Use _isFocused to make the code simpler. (-[WKView _updateTextInputStateIncludingSecureInputState:]): Confirm the current inline input session if selection changed for any other reason but an input method changing the composition. We will want to do other work here, like dismissing a dictionary pop-up, updating a font panel etc. (-[WKView _resetTextInputState]): Added. We don't want secure text input persist after navigations, crashes an such, and we also don't want input methods to remember inline input state. Relying on selection changed notifications is fragile and insufficient.
- UIProcess/API/mac/WKViewInternal.h: Added internal functions to keep the build unbroken.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): This is the best chance we have to reset input state for a new page. This doesn't work well for cached page loads, but WK1 is quite broken in that case, too. (WebKit::WebPageProxy::editorStateChanged): Moved some logic up to the client, since the function now does much more than before.
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::confirmCompositionWithoutDisturbingSelection):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::confirmCompositionWithoutDisturbingSelection): Added confirmCompositionWithoutDisturbingSelection(). When we confirm the composition due to selection change, we obvisouly don't want the selection to move back.
- 11:28 AM Changeset in webkit [84525] by
-
- 3 edits in trunk/Tools
2011-04-21 Ojan Vafai <ojan@chromium.org>
Reviewed by Mihai Parparita.
fix another innocuous JS error in expand/collapseAllExpectations
https://bugs.webkit.org/show_bug.cgi?id=59122
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
- 11:19 AM Changeset in webkit [84524] by
-
- 5 edits in trunk/Source/WebKit2
2011-04-21 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Remove warnings from DrawingAreaImpl and related classes
https://bugs.webkit.org/show_bug.cgi?id=59120
DrawingAreaImpl is mature enough for others to adopt. Remove warnings.
- UIProcess/BackingStore.cpp:
- UIProcess/DrawingAreaProxyImpl.cpp:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
- WebProcess/WebPage/LayerTreeHost.cpp:
- 10:57 AM Changeset in webkit [84523] by
-
- 6 edits in trunk/Source/WebKit2
2011-04-21 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Deploy GraphicsContextStateSaver in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59116
- UIProcess/FindIndicator.cpp: (WebKit::FindIndicator::draw):
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::paint):
- WebProcess/WebPage/FindController.cpp: (WebKit::FindController::drawRect):
- WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::drawRect):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect): (WebKit::WebPage::drawPageOverlay):
- 10:56 AM Changeset in webkit [84522] by
-
- 27 edits69 adds in trunk
2011-04-21 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG feDropShadow implementation of SVG Filters 1.2
https://bugs.webkit.org/show_bug.cgi?id=52513
Added dynamic update tests for FEDropShadow as well as a basic pixel test.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
- platform/mac/svg/filters/feDropShadow-expected.checksum: Added.
- platform/mac/svg/filters/feDropShadow-expected.png: Added.
- platform/mac/svg/filters/feDropShadow-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr.html: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr.html: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr.html: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop.html: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop.html: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop.html: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop.html:
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop.html:
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop.html:
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop.html:
- svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-dx-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-dy-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-in-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-shadow-color-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-shadow-opacity-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-stdDeviation-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-dx-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-dy-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-in-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-shadow-color-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-stdDeviation-prop.js: Added. (executeTest):
- svg/filters/feDropShadow.svg: Added.
2011-04-21 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG feDropShadow implementation of SVG Filters 1.2
https://bugs.webkit.org/show_bug.cgi?id=52513
- MigrateHeaders.make:
2011-04-21 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG feDropShadow implementation of SVG Filters 1.2
https://bugs.webkit.org/show_bug.cgi?id=52513
This is the implementation of feDropShadow, a shorthand filter and a combination of feGaussianBlur,
feOffset, feFlood and feComposite to create a drop shadow of an input effect.
Creating this new filter effect makes it possible to optimize the often used workflow. ShadowBlur, with its
fast blurring algorithm, is used to blur the shadow and composite operators are responsible for combining the
source with different colored shadows.
Shadow color and opacity can be set with the properties flood-color and flood-opacity.
Tests: svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html
svg/filters/feDropShadow.svg
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm: (WebCore::createElementClassMap):
- bindings/objc/DOMSVG.h:
- page/DOMWindow.idl:
- platform/graphics/ShadowBlur.cpp: Added missing copyright after r84410.
- platform/graphics/ShadowBlur.h: Made blurLayerImage public.
- platform/graphics/filters/FEDropShadow.cpp: Added. (WebCore::FEDropShadow::FEDropShadow): (WebCore::FEDropShadow::create): (WebCore::FEDropShadow::determineAbsolutePaintRect): (WebCore::FEDropShadow::apply): (WebCore::FEDropShadow::dump): (WebCore::FEDropShadow::externalRepresentation):
- platform/graphics/filters/FEDropShadow.h: Added. (WebCore::FEDropShadow::stdDeviationX): (WebCore::FEDropShadow::setStdDeviationX): (WebCore::FEDropShadow::stdDeviationY): (WebCore::FEDropShadow::setStdDeviationY): (WebCore::FEDropShadow::dx): (WebCore::FEDropShadow::setDx): (WebCore::FEDropShadow::dy): (WebCore::FEDropShadow::setDy): (WebCore::FEDropShadow::shadowColor): (WebCore::FEDropShadow::setShadowColor): (WebCore::FEDropShadow::shadowOpacity): (WebCore::FEDropShadow::setShadowOpacity):
- platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::calculateKernelSize): Make kernel calculations accessible for feDropShadow.
- platform/graphics/filters/FEGaussianBlur.h:
- svg/SVGAllInOne.cpp:
- svg/SVGFEDropShadowElement.cpp: Added. (WebCore::SVGFEDropShadowElement::SVGFEDropShadowElement): (WebCore::SVGFEDropShadowElement::create): (WebCore::SVGFEDropShadowElement::stdDeviationXIdentifier): (WebCore::SVGFEDropShadowElement::stdDeviationYIdentifier): (WebCore::SVGFEDropShadowElement::setStdDeviation): (WebCore::SVGFEDropShadowElement::parseMappedAttribute): (WebCore::SVGFEDropShadowElement::svgAttributeChanged): (WebCore::SVGFEDropShadowElement::synchronizeProperty): (WebCore::SVGFEDropShadowElement::build):
- svg/SVGFEDropShadowElement.h: Added.
- svg/SVGFEDropShadowElement.idl: Added.
- svg/svgtags.in:
- 10:47 AM Changeset in webkit [84521] by
-
- 3 edits in trunk/LayoutTests
2011-04-21 MORITA Hajime <morrita@google.com>
Unreviewed expectations update following r84511.
- platform/gtk/fast/html/details-open2-expected.txt:
- platform/qt/fast/html/details-open2-expected.txt:
- 10:44 AM Changeset in webkit [84520] by
-
- 18 edits2 adds in trunk
2011-04-20 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 58704 - Decide on node type for ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=58704
Test node types of shadow host, shadow root and first shadow child.
- fast/dom/shadow/nodetype-expected.txt: Added.
- fast/dom/shadow/nodetype.html: Added.
2011-04-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 58704 - Decide on node type for ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=58704
Add a new node type SHADOW_ROOT_NODE.
Adapt all calling sites of nodeType().
Test: fast/dom/shadow/nodetype.html
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline):
- bindings/objc/DOM.mm: (kitClass):
- bindings/v8/custom/V8NodeCustom.cpp: (WebCore::toV8Slow):
- dom/Document.cpp: (WebCore::Document::importNode): (WebCore::Document::childTypeAllowed): (WebCore::Document::canReplaceChild):
- dom/Node.cpp: (WebCore::Node::dumpStatistics): (WebCore::Node::isDefaultNamespace): (WebCore::Node::lookupPrefix): (WebCore::Node::lookupNamespaceURI): (WebCore::appendTextContent): (WebCore::Node::setTextContent):
- dom/Node.h:
- dom/Range.cpp: (WebCore::lengthOfContentsInNode): (WebCore::Range::processContentsBetweenOffsets): (WebCore::Range::insertNode): (WebCore::Range::checkNodeWOffset): (WebCore::Range::checkNodeBA): (WebCore::Range::selectNode): (WebCore::Range::selectNodeContents): (WebCore::Range::surroundContents):
- dom/ShadowRoot.cpp: (WebCore::ShadowRoot::nodeType):
- dom/Traversal.cpp: (WebCore::Traversal::acceptNode):
- editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::appendStartMarkup):
- html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isRootNode): (WebCore::HTMLElementStack::pushRootNode):
- html/parser/HTMLElementStack.h: (WebCore::isInHTMLNamespace):
- xml/XPathUtil.cpp: (WebCore::XPath::isValidContextNode):
2011-04-21 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 58704 - Decide on node type for ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=58704
Add a new enum entry to WebNode::NodeType for shadow roots.
Adapt calling sites for new SHADOW_ROOT_NODE node type.
- public/WebNode.h:
- src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::buildContentForNode):
- 10:43 AM Changeset in webkit [84519] by
-
- 8 edits in trunk/Source/WebKit2
WebKit2: Need a way to get a snapshot of the visible contents of a page from the UI Process.
https://bugs.webkit.org/show_bug.cgi?id=59035
Reviewed by Sam Weinig.
Added a sync call from the UI Process to the Web Process with comments saying that it should
be removed as soon as possible.
- UIProcess/API/C/WKPage.cpp:
(WKPageVisibleContentsSnapshot):
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createSnapshotOfVisibleContent):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createSnapshotOfVisibleContent):
Ask the FrameView for the visibleContentRect, and call scaledSnapshotInDocumentCoordinates
with a scale factor of 1 (which preserves the current scaling of the page - e.g. if the
page is already zoomed then the snapshot will reflect the zoomed content).
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 10:43 AM Changeset in webkit [84518] by
-
- 3 edits in trunk/Tools
2011-04-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
put unexpected passes into their own table
https://bugs.webkit.org/show_bug.cgi?id=59016
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- 10:37 AM Changeset in webkit [84517] by
-
- 8 edits2 adds in trunk
2011-04-20 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
REGRESSION (r75543): Styles bleed into new shadow DOM (like slider and video)
https://bugs.webkit.org/show_bug.cgi?id=52917
- fast/css/shadow-dom-scope-expected.txt: Added.
- fast/css/shadow-dom-scope.html: Added.
2011-04-20 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
REGRESSION (r75543): Styles bleed into new shadow DOM (like slider and video)
https://bugs.webkit.org/show_bug.cgi?id=52917
In order to determine whether a rule should apply inside of a shadow DOM subtree,
we collect three pieces of information:
1) Are we parsing UA sheets?
2) Does the current tree scope allows applying author sheets?
3) Does the rule explicitly reach into shadow DOM (using pseudo-elements, for example)?
If the answer to all of these is no, we ignore the rule.
Test: fast/css/shadow-dom-scope.html
- css/CSSStyleSelector.cpp: (WebCore::MatchingUARulesScope::MatchingUARulesScope): Added a scope helper to
track whether we are currently matching UA rules.
(WebCore::CSSStyleSelector::matchRulesForList): Added the check for three
conditions mentioned above.
(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker): Added
initializer for the flag, which helps us determine whether the rule
explicitly reaches into shadow DOM.
(WebCore::CSSStyleSelector::matchUARules): Started using the scope helper.
(WebCore::CSSStyleSelector::checkSelector): Added initializing of the
flag.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added setting
of the flag when we encounter unknown pseudo-elements.
- css/CSSStyleSelector.h: Adjusted decls.
- dom/ShadowRoot.cpp: (WebCore::ShadowRoot::applyAuthorSheets): Added.
- dom/ShadowRoot.h: Adjusted decls.
- dom/TreeScope.cpp: (WebCore::TreeScope::applyAuthorSheets): Added.
- dom/TreeScope.h: Adjusted decls.
- 10:24 AM Changeset in webkit [84516] by
-
- 3 edits4 adds in trunk
2011-04-21 Levi Weintraub <leviw@chromium.org>
Reviewed by Simon Fraser.
position fixed element does not render properly when dynamically updated via javascript
https://bugs.webkit.org/show_bug.cgi?id=54297
Disabling the LayoutState fast-path for fixed-position content.
Tests: fast/repaint/fixed-contents-changed-after-scroll.html
fast/repaint/transformed-contents-changed-after-scroll.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint):
2011-04-21 Levi Weintraub <leviw@chromium.org>
Reviewed by Simon Fraser.
position fixed element does not render properly when dynamically updated via javascript
https://bugs.webkit.org/show_bug.cgi?id=54297
Disabling the LayoutState fast-path for fixed-position content.
- fast/repaint/fixed-contents-changed-after-scroll.html: Added.
- fast/repaint/transformed-contents-changed-after-scroll.html: Added.
- platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.checksum: Added.
- platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.png: Added.
- platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.txt: Added.
- platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.checksum: Added.
- platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.png: Added.
- platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.txt: Added.
- 10:23 AM Changeset in webkit [84515] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-04-20 Michael Saboff <msaboff@apple.com>
Reviewed by Geoff Garen.
JSString::resolveRope inefficient for common 2 fiber case
https://bugs.webkit.org/show_bug.cgi?id=58994
Split JSString::resolveRope into three routines.
resolveRope allocates the new buffer and handles the 1 or 2
fiber case with single level fibers.
resolveRopeSlowCase handles the general case.
outOfMemory handles the rare out of memory exception case.
- runtime/JSString.cpp: (JSC::JSString::resolveRope): (JSC::JSString::resolveRopeSlowCase): (JSC::JSString::outOfMemory):
- runtime/JSString.h:
- 10:20 AM Rebaseline edited by
- (diff)
- 10:16 AM Changeset in webkit [84514] by
-
- 2 edits1 add in trunk/Tools
2011-04-20 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
initial set of tests for new results.html file
https://bugs.webkit.org/show_bug.cgi?id=59031
Also, fix the bugs (mostly innocuous JS errors) the tests found.
- Scripts/webkitpy/layout_tests/layout_package/json_results.html:
- Scripts/webkitpy/layout_tests/layout_package/json_results_test.js: Added.
- 10:12 AM Changeset in webkit [84513] by
-
- 2 edits6 adds7 deletes in trunk/LayoutTests
2011-04-21 Tony Chang <tony@chromium.org>
Unreviewed. Fixed the last set of tests that are missing pngs.
Created new png baselines on my Leopard machine.
- platform/chromium-mac-leopard/fast/blockflow/english-bt-text-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/blockflow/english-bt-text-expected.png: Added.
- platform/chromium-mac-leopard/fast/borders/svg-as-border-image-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/borders/svg-as-border-image-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/value-list-out-of-bounds-crash-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/group-opacity-expected.checksum: Removed.
- platform/chromium-mac-leopard/svg/custom/group-opacity-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.checksum: Removed.
- platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.png: Added.
- platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Removed. Matches platform/mac.
- platform/chromium/test_expectations.txt:
- 10:11 AM Rebaseline edited by
- (diff)
- 9:57 AM Changeset in webkit [84512] by
-
- 3 edits2 adds in trunk
2011-04-20 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Content of <summary> should be forwarded through the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=58914
- Added test cases for dynamic DOM change.
- Updated expectations details-open2.html because generated RenderTree slightly changed.
- fast/html/details-add-summary-child-1.html: Added.
- fast/html/details-add-summary-child-2.html: Added.
- fast/html/details-remove-summary-child-1.html: Added.
- fast/html/details-remove-summary-child-2.html: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/html/details-add-summary-child-1-expected.checksum: Added.
- platform/mac/fast/html/details-add-summary-child-1-expected.png: Added.
- platform/mac/fast/html/details-add-summary-child-1-expected.txt: Added.
- platform/mac/fast/html/details-add-summary-child-2-expected.checksum: Added.
- platform/mac/fast/html/details-add-summary-child-2-expected.png: Added.
- platform/mac/fast/html/details-add-summary-child-2-expected.txt: Added.
- platform/mac/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-remove-summary-child-1-expected.checksum: Added.
- platform/mac/fast/html/details-remove-summary-child-1-expected.png: Added.
- platform/mac/fast/html/details-remove-summary-child-1-expected.txt: Added.
- platform/mac/fast/html/details-remove-summary-child-2-expected.checksum: Added.
- platform/mac/fast/html/details-remove-summary-child-2-expected.png: Added.
- platform/mac/fast/html/details-remove-summary-child-2-expected.txt: Added.
2011-04-20 Matthew Delaney <mdelaney@apple.com>
Reviewed by Maciej Stachowiak.
arc() should add a circle to the path when start and end angles are far enough apart
https://bugs.webkit.org/show_bug.cgi?id=58934
Test: fast/canvas/canvas_arc_largeangles.html
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arc):
- 9:51 AM Changeset in webkit [84511] by
-
- 14 edits1 copy16 adds in trunk
2011-04-20 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Content of <summary> should be forwarded through the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=58914
- Added test cases for dynamic DOM change.
- Updated expectations details-open2.html because generated RenderTree slightly changed.
- fast/html/details-add-summary-child-1.html: Added.
- fast/html/details-add-summary-child-2.html: Added.
- fast/html/details-remove-summary-child-1.html: Added.
- fast/html/details-remove-summary-child-2.html: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/html/details-add-summary-child-1-expected.checksum: Added.
- platform/mac/fast/html/details-add-summary-child-1-expected.png: Added.
- platform/mac/fast/html/details-add-summary-child-1-expected.txt: Added.
- platform/mac/fast/html/details-add-summary-child-2-expected.checksum: Added.
- platform/mac/fast/html/details-add-summary-child-2-expected.png: Added.
- platform/mac/fast/html/details-add-summary-child-2-expected.txt: Added.
- platform/mac/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-remove-summary-child-1-expected.checksum: Added.
- platform/mac/fast/html/details-remove-summary-child-1-expected.png: Added.
- platform/mac/fast/html/details-remove-summary-child-1-expected.txt: Added.
- platform/mac/fast/html/details-remove-summary-child-2-expected.checksum: Added.
- platform/mac/fast/html/details-remove-summary-child-2-expected.png: Added.
- platform/mac/fast/html/details-remove-summary-child-2-expected.txt: Added.
2011-04-20 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Content of <summary> should be forwarded through the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=58914
- Introduced ShadowContentElement which hosts forwarded children of <summary>
- Encapsulated Node::parentNodeForRenderingAndStyle() and shouldCreateRendererFor() into NodeVisualParentLookupResult class.
- The parent lookup is also aware of node forwarding. If the visual parent node has a shadow root, the node is possibly forwarded to ShadowContentElement
- ShadowContentElement lookup is implemented inside ShadowRoot.
Tests: fast/html/details-add-summary-child-1.html
fast/html/details-add-summary-child-2.html
fast/html/details-remove-summary-child-1.html
fast/html/details-remove-summary-child-2.html
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp: (WebCore::Element::childrenChanged):
- dom/Node.cpp: (WebCore::NodeRenderParentDetector::NodeRenderParentDetector): (WebCore::NodeRenderParentDetector::parentNodeForRenderingAndStyle): (WebCore::NodeRenderParentDetector::findVisualParent): (WebCore::NodeRenderParentDetector::shouldCreateRenderer): (WebCore::Node::parentNodeForRenderingAndStyle): (WebCore::Node::createRendererAndStyle):
- dom/ShadowRoot.cpp: (WebCore::ShadowRoot::contentContainerFor): (WebCore::ShadowRoot::hostChildrenChanged): (WebCore::ShadowRoot::firstContentElement):
- dom/ShadowRoot.h:
- html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::createShadowSubtree):
- html/HTMLSummaryElement.h:
- html/shadow/ShadowContentElement.h: Copied from Source/WebCore/dom/ShadowRoot.h. (WebCore::ShadowContentElement::ShadowContentElement): (WebCore::ShadowContentElement::isShadowBoundary): (WebCore::ShadowContentElement::createRenderer): (WebCore::ShadowContentElement::create):
- 9:40 AM Changeset in webkit [84510] by
-
- 6 edits in trunk
011-04-21 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor
https://bugs.webkit.org/show_bug.cgi?id=59105
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatobject):
- inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane.prototype._setObject):
- inspector/front-end/ResourceJSONView.js: (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
- 9:38 AM Changeset in webkit [84509] by
-
- 1 edit1 move in trunk/LayoutTests
2011-04-20 Matthew Delaney <mdelaney@apple.com>
Reviewed by Adam Roben.
Move toDataURL.jpeg.alpha expected result out of /mac-snowleopard and into /mac
https://bugs.webkit.org/show_bug.cgi?id=59038
- platform/mac-snowleopard/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Removed.
- platform/mac/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Copied from LayoutTests/platform/mac-snowleopard/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt.
- 9:32 AM Changeset in webkit [84508] by
-
- 7 edits in trunk
2011-04-21 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] missing LayoutTestController::callShouldCloseOnWebView()
https://bugs.webkit.org/show_bug.cgi?id=59086
- platform/gtk/Skipped: Unskip fast/events/onbeforeunload-focused-iframe.html
callShouldCloseOnWebView() implementation.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::callShouldCloseOnWebView):
DRT::shouldClose(), used by the LayoutController.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shouldClose):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
- 9:24 AM Changeset in webkit [84507] by
-
- 7 edits3 adds in trunk
2011-04-21 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT: implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=59082
Unskipped tests that should pass now that
eventSender.scalePageBy() is supported in GTK.
- platform/gtk/Skipped:
- platform/gtk/fast/repaint/scale-page-shrink-expected.checksum: Added.
- platform/gtk/fast/repaint/scale-page-shrink-expected.png: Added.
- platform/gtk/fast/repaint/scale-page-shrink-expected.txt: Added.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::scalePageBy):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
- DumpRenderTree/gtk/EventSender.cpp: (scalePageByCallback): scalePageBy() support.
- 9:18 AM Changeset in webkit [84506] by
-
- 4 edits in trunk
2011-04-21 Adam Barth <abarth@webkit.org>
Update results to show failure.
- http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
2011-04-21 Adam Barth <abarth@webkit.org>
Remove support for CSP's frame-src. This approach causes too many
extra console messages to be logged. I'm leaving in the test (which
now shows failure).
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):
- 8:58 AM Changeset in webkit [84505] by
-
- 2 edits in trunk/Source/WebCore
2011-04-21 Eunsol Park <eunsol47.park@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Scroll doesn't work on tiled backing store.
https://bugs.webkit.org/show_bug.cgi?id=55021
It was added from Changeset 72242, but it worked wrong in EFL port.
The visible rect should not be returned as content rect for scrolling in EFL tiled backing store,
because it works differently from QT.
- platform/ScrollView.cpp: (WebCore::ScrollView::visibleContentRect):
- 8:55 AM Changeset in webkit [84504] by
-
- 45 edits in trunk/Source/WebCore
2011-04-21 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel.
Create RIAA class for GraphicsContext::save() and restore()
https://bugs.webkit.org/show_bug.cgi?id=58807
Use GraphicsContextStateSaver in a lot more places.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawTextInternal):
- platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::draw):
- platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::save): (WebCore::GraphicsContextStateSaver::restore):
- platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::drawShadowBuffer): (WebCore::ShadowBlur::drawRectShadowWithoutTiling): (WebCore::ShadowBlur::drawInsetShadowWithoutTiling): (WebCore::ShadowBlur::drawInsetShadowWithTiling): (WebCore::ShadowBlur::drawRectShadowWithTiling): (WebCore::ShadowBlur::drawLayerPieces):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):
- platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::draw):
- platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
- platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::paint):
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
- platform/mac/ThemeMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio): (WebCore::paintStepper):
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paintSelection):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintTextMatchMarker):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::paintSelection):
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorationsWithSize):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder):
- rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paintReplaced):
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::paintChildLayerIntoColumns):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
- rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintMeter): (WebCore::RenderThemeMac::paintProgressBar): (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintMenuListButton): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsButton): (WebCore::RenderThemeMac::paintMediaSliderTrack): (WebCore::RenderThemeMac::paintMediaCurrentTime): (WebCore::RenderThemeMac::paintMediaTimeRemaining):
- rendering/mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::paint):
- rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
- rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):
- rendering/mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
- rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
- rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::paint):
- rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::paint):
- rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyClippingToContext):
- rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::draw):
- rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
- rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint):
- rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintSelectionBackground): (WebCore::SVGInlineTextBox::paint): (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
- rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
- svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw):
- 8:39 AM Changeset in webkit [84503] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Tony Gentilcore <tonyg@chromium.org>
[chromium] inspector/console/console-log-before-inspector-open.html times out on mac
https://bugs.webkit.org/show_bug.cgi?id=59106
Seems to have started timing out in 84470-84471 which were expectations
updates.
- platform/chromium/test_expectations.txt:
- 8:38 AM Changeset in webkit [84502] by
-
- 5 edits in trunk/LayoutTests
2011-04-21 Adam Barth <abarth@webkit.org>
Reviewed by Tony Gentilcore.
Make test robust to PHP magic quotes
https://bugs.webkit.org/show_bug.cgi?id=59104
- http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
- http/tests/security/contentSecurityPolicy/resources/save-report.php:
- 8:21 AM Changeset in webkit [84501] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-04-21 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Fix the style issue for Api/qwebkitplatformplugin.h
https://bugs.webkit.org/show_bug.cgi?id=59097
Fix the style issues for Api/qwebkitplatformplugin.h found by the webkit-check-style.
- Api/qwebkitplatformplugin.h:
- 8:07 AM Changeset in webkit [84500] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Tony Gentilcore <tonyg@chromium.org>
[chromium] Temporarily skip new contentSecurityPolicy tests
https://bugs.webkit.org/show_bug.cgi?id=59103
Tests introduced by http://trac.webkit.org/changeset/84478
- platform/chromium/test_expectations.txt:
- 7:59 AM Changeset in webkit [84499] by
-
- 5 edits in trunk
2011-04-20 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] console API is not exposed to code evaluated by sidebar.setExpression()
https://bugs.webkit.org/show_bug.cgi?id=59006
- inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane.prototype.setExpression):
2011-04-20 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Expose console API to the code evaluated by sidebar.setExpression()
Web Inspector: [Extensions API] console API is not exposed to code evaluated by sidebar.setExpression()
https://bugs.webkit.org/show_bug.cgi?id=59006
- inspector/extensions/extensions-expected.txt:
- inspector/extensions/extensions.html:
- 7:22 AM Changeset in webkit [84498] by
-
- 15 edits2 copies in trunk/Source/WebCore
2011-04-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Split SVGGlyphIdentifier class out of SVGGlyphElement.h
https://bugs.webkit.org/show_bug.cgi?id=59101
Move SVGGlyphIdentifier class out of SVGGlyphElement.h, place it in platform/graphics/SVGGlyph.h
and rename the contained struct to SVGGlyph. It will be used in follow-up patches that will integrate SVGGlyph & GlyphPage.
Several utility functions are moved from SVGFont.cpp to SVGGlyph.cpp, as that's the place where they really belong to.
Renamed nameLength to unicodeStringLength in the SVGGlyph struct for clarity.
- Android.mk: Add SVGGlyph.cpp/h to build.
- CMakeLists.txt: Ditto.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- platform/graphics/SVGGlyph.cpp: Copied from svg/SVGFont.cpp. Removed everything except the methods listed below, that belong here. (WebCore::processArabicFormDetection): (WebCore::charactersWithArabicForm): (WebCore::isCompatibleArabicForm): (WebCore::isCompatibleGlyph):
- platform/graphics/SVGGlyph.h: Copied from svg/SVGGlyphElement.h. Renamed SVGGlyphIdentifier to SVGGlyph. (WebCore::SVGGlyph::SVGGlyph): (WebCore::SVGGlyph::operator==):
- platform/graphics/SimpleFontData.cpp: Adapt for SVGGlyphIdentifier -> SVGGlyph and nameLength -> unicodeStringLength rename. (WebCore::SimpleFontData::SimpleFontData):
- svg/SVGFont.cpp: Ditto. Remove helper functions that are now living in SVGGlyph.cpp (WebCore::SVGTextRunWalker::walk): (WebCore::floatWidthUsingSVGFontCallback): (WebCore::drawTextUsingSVGFontCallback): (WebCore::drawTextMissingGlyphCallback): (WebCore::Font::drawTextUsingSVGFont):
- svg/SVGFontElement.cpp: Ditto. (WebCore::SVGFontElement::getGlyphIdentifiersForString):
- svg/SVGFontElement.h: Ditto.
- svg/SVGGlyphElement.cpp: Ditto. (WebCore::parseArabicForm): (WebCore::parseOrientation): (WebCore::SVGGlyphElement::inheritUnspecifiedAttributes): (WebCore::parseSVGGlyphAttribute): (WebCore::SVGGlyphElement::buildGenericGlyphIdentifier): (WebCore::SVGGlyphElement::buildGlyphIdentifier):
- svg/SVGGlyphElement.h: Ditto.
- svg/SVGGlyphMap.h: Ditto. (WebCore::SVGGlyphMap::add): (WebCore::SVGGlyphMap::compareGlyphPriority): (WebCore::SVGGlyphMap::get):
- 7:10 AM Changeset in webkit [84497] by
-
- 4 edits in trunk/Source/WebCore
2011-04-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Live streams won't play with AVFoundation backend
https://bugs.webkit.org/show_bug.cgi?id=58961
rdar://problem/9284748
Tested manually because we don't have any live streams to test in DRT.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::seek): Do nothing when asked to seek to the
current time.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): If the readyState is HaveEnoughData,
don't revert when the new state is "ready to play" or "buffer full".
(WebCore::MediaPlayerPrivateAVFoundation::movieLoadType): Use new convenience function isLiveStream.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: (WebCore::MediaPlayerPrivateAVFoundation::isLiveStream): New.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Don't use AVAsset's
tracksWithMediaCharacteristic because it doesn't give us what we need with live
streams.
- 7:08 AM Changeset in webkit [84496] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Tony Gentilcore <tonyg@chromium.org>
[chromium] Correct expecations for editing/selection/designmode-no-caret.html
https://bugs.webkit.org/show_bug.cgi?id=59088
Straighten out bad override in designmode-no-caret.html
- platform/chromium/test_expectations.txt:
- 6:51 AM Changeset in webkit [84495] by
-
- 2 edits in trunk/Source/WebCore
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Cookies section in empty on page re-launch.
https://bugs.webkit.org/show_bug.cgi?id=59095
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._reset): (WebInspector.ResourcesPanel.prototype._frameNavigated):
- 6:49 AM Changeset in webkit [84494] by
-
- 3 edits in trunk/Source/WebCore
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: rename De-obfuscate to Pretty print.
https://bugs.webkit.org/show_bug.cgi?id=59093
- English.lproj/localizedStrings.js:
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
- 6:48 AM Changeset in webkit [84493] by
-
- 3 edits in trunk/Source/WebCore
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: following Image URL link in the network panel does nothing.
https://bugs.webkit.org/show_bug.cgi?id=59092
- inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad): (WebInspector.ImageView.prototype._createContentIfNeeded):
- inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
- 6:46 AM Changeset in webkit [84492] by
-
- 6 edits in trunk/Source/WebCore
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: implement Go To Line for network panel.
https://bugs.webkit.org/show_bug.cgi?id=59090
- inspector/front-end/GoToLineDialog.js: (WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
- inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView.prototype._tabSelected): (WebInspector.NetworkItemView.prototype._installHighlightSupport):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel):
- inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane.prototype.appendTab): (WebInspector.TabbedPane.prototype.selectTab):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.highlightLine):
- 6:45 AM Changeset in webkit [84491] by
-
- 2 edits in trunk/LayoutTests
Skip some newly-failing tests on Windows
<http://webkit.org/b/59098> and <http://webkit.org/b/59099> track the failures.
- platform/win/Skipped: Added fast/transforms/selection-bounds-in-transformed-view.html and
http/tests/security/contentSecurityPolicy/frame-src-blocked.html.
- 6:34 AM Changeset in webkit [84490] by
-
- 6 edits1 copy in trunk/Source/WebCore
2011-04-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Split GlyphPage from GlyphPageTreeNode.h into its own header
https://bugs.webkit.org/show_bug.cgi?id=59096
- GNUmakefile.list.am: Add GlyphPage.h to build.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- platform/graphics/GlyphPage.h: Copied from platform/graphics/GlyphPageTreeNode.h. Removed GlyphPageTreeNode class, leaving only GlyphPage.
- platform/graphics/GlyphPageTreeNode.h: Removed GlyphPage class.
- 6:07 AM Changeset in webkit [84489] by
-
- 8 edits1 add in trunk/Source/WebCore
2011-04-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Centralize typedef unsigned short Glyph in Glyph.h
https://bugs.webkit.org/show_bug.cgi?id=59087
- GNUmakefile.list.am: Add Glyph.h to build.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- platform/graphics/Glyph.h: Added.
- platform/graphics/GlyphBuffer.h: Include Glyph.h instead of duplicating the Glyph typedef.
- platform/graphics/GlyphMetricsMap.h: Ditto.
- platform/graphics/GlyphPageTreeNode.h: Ditto.
- 5:45 AM Changeset in webkit [84488] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Tony Gentilcore <tonyg@chromium.org>
BitmapImage::destroyMetadataAndNotify should clear m_checkedForSolidColor
https://bugs.webkit.org/show_bug.cgi?id=58926
Remove chromium's crashing expectations.
- platform/chromium/test_expectations.txt:
- 5:33 AM Changeset in webkit [84487] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Tony Gentilcore <tonyg@chromium.org>
[chromium] Correct expecations for editing/selection/designmode-no-caret.html
https://bugs.webkit.org/show_bug.cgi?id=59088
http://trac.webkit.org/changeset/84470 seemed to have caused a conflict. This
has always been failing on Win Debug.
- platform/chromium/test_expectations.txt:
- 5:28 AM Changeset in webkit [84486] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed.
REGRESSION (WK2): Animated GIF stops when navigating forward, back
https://bugs.webkit.org/show_bug.cgi?id=59042
- platform/qt-wk2/Skipped: Add fast/images/animated-gif-restored-from-bfcache.html,
because WebKit2 since it doesn't implement layoutTestController.overridePreference().
- 5:24 AM Changeset in webkit [84485] by
-
- 2 edits in trunk/Source/WebCore
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: toolbar background is blank on Mac Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=59089
- inspector/front-end/inspector.css: (body.detached.platform-mac-snowleopard:not(.remote) #toolbar):
- 5:05 AM Changeset in webkit [84484] by
-
- 9 edits in trunk/Source/WebCore
2011-04-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add support for Go To Line in Resources panel.
https://bugs.webkit.org/show_bug.cgi?id=59077
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
- inspector/front-end/GoToLineDialog.js: (WebInspector.GoToLineDialog.show): (WebInspector.GoToLineDialog.createShortcut): (WebInspector.GoToLineDialog.prototype._onKeyDown):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.handleShortcut):
- inspector/front-end/Panel.js: (WebInspector.Panel): (WebInspector.Panel.prototype._restoreScrollPositions): (WebInspector.Panel.prototype.handleShortcut): (WebInspector.Panel.prototype.registerShortcuts): (WebInspector.Panel.prototype._showGoToLineDialog):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.handleShortcut):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._registerShortcuts): (WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
- inspector/front-end/inspector.js: (WebInspector._registerShortcuts): (WebInspector.documentKeyDown):
- 4:43 AM Changeset in webkit [84483] by
-
- 5 edits in trunk/Source/WebCore
2011-04-21 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: persist local resource history between inspector / browser launches.
https://bugs.webkit.org/show_bug.cgi?id=58993
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._restoreRevisions):
- 3:51 AM Changeset in webkit [84482] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-04-21 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK baselines for test added in r84398.
- platform/gtk/fast/borders/bidi-012-expected.checksum: Added.
- platform/gtk/fast/borders/bidi-012-expected.png: Added.
- platform/gtk/fast/borders/bidi-012-expected.txt: Added.
- 2:53 AM Changeset in webkit [84481] by
-
- 12 edits in trunk/Source/WebCore
2011-04-20 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Metrics pane editing and visual feedback improvements
https://bugs.webkit.org/show_bug.cgi?id=58992
Added visual feedback when hovering over the box model components of the Metrics pane
and handling of the [Page]Up/Down keys when editing the box model values.
- inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
- inspector/DOMNodeHighlighter.h:
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::mouseDidMoveOverElement): (WebCore::InspectorDOMAgent::highlight): (WebCore::InspectorDOMAgent::highlightDOMNode): (WebCore::InspectorDOMAgent::highlightFrame): (WebCore::InspectorDOMAgent::drawNodeHighlight):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSProperty.prototype.setText.callback): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setValue): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.startEditingStyle): (WebInspector.ElementsPanel.prototype.endEditingStyle): (WebInspector.ElementsPanel.prototype._attributesUpdated):
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane): (WebInspector.MetricsSidebarPane.prototype._highlightDOMNode): (WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.getBoxRectangleElement): (WebInspector.MetricsSidebarPane.prototype._update.createBoxPartElement): (WebInspector.MetricsSidebarPane.prototype._update): (WebInspector.MetricsSidebarPane.prototype.startEditing): (WebInspector.MetricsSidebarPane.prototype._handleKeyDown): (WebInspector.MetricsSidebarPane.prototype.editingEnded): (WebInspector.MetricsSidebarPane.prototype.editingCancelled): (WebInspector.MetricsSidebarPane.prototype._applyUserInput.callback): (WebInspector.MetricsSidebarPane.prototype._applyUserInput): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.alteredFloatNumber): (WebInspector.StylesSidebarPane.alteredHexNumber): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
- inspector/front-end/inspector.css: (.metrics .hovered > .label): (.metrics .position): (.metrics .margin): (.metrics .margin.hovered): (.metrics .border): (.metrics .border.hovered): (.metrics .padding): (.metrics .padding.hovered): (.metrics .content): (.metrics .content.hovered):
- inspector/front-end/inspector.js: (WebInspector.highlightDOMNode):
- 2:39 AM Changeset in webkit [84480] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-04-21 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK baselines for
http/tests/security/contentSecurityPolicy tests that don't escape
the quote character.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
- 1:50 AM Changeset in webkit [84479] by
-
- 2 edits in trunk/LayoutTests
[Qt] Missing eventSender.scalePageBy() implementation
- platform/qt/Skipped: Add fast/transforms/selection-bounds-in-transformed-view.html.
- 1:34 AM Changeset in webkit [84478] by
-
- 6 edits10 adds in trunk
2011-04-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP report-uri is missing
https://bugs.webkit.org/show_bug.cgi?id=58639
Test that report-uri sends a report. Testing approach stolen from the
ping tests.
- http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-uri.html: Added.
- http/tests/security/contentSecurityPolicy/resources/echo-report.php: Added.
- http/tests/security/contentSecurityPolicy/resources/go-to-echo-report.js: Added.
- http/tests/security/contentSecurityPolicy/resources/save-report.php: Added.
2011-04-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP report-uri is missing
https://bugs.webkit.org/show_bug.cgi?id=58639
Our implementation of report-uri differs from what's currently in the
spec. I sent the working group an email explaining why. Generally,
we're using normal form encoding instead of JSON and we're sending less
information to a wider set of URLs. Specifically, we send the current
document's URL as well as the directive that was violated. The spec
(currently) tells us to send the raw HTTP headers and the URL that
caused the violation, but both of these pieces of data could contain
information that's sensitive, so we omit them for now.
Test: http/tests/security/contentSecurityPolicy/report-uri.html
- loader/PingLoader.cpp: (WebCore::PingLoader::reportContentSecurityPolicyViolation):
- loader/PingLoader.h:
- page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::CSPDirective::text): (WebCore::ContentSecurityPolicy::reportViolation): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::allowEval): (WebCore::ContentSecurityPolicy::allowScriptFromSource): (WebCore::ContentSecurityPolicy::allowObjectFromSource): (WebCore::ContentSecurityPolicy::allowChildFrameFromSource): (WebCore::ContentSecurityPolicy::allowImageFromSource): (WebCore::ContentSecurityPolicy::allowStyleFromSource): (WebCore::ContentSecurityPolicy::allowFontFromSource): (WebCore::ContentSecurityPolicy::allowMediaFromSource): (WebCore::ContentSecurityPolicy::parseReportURI): (WebCore::ContentSecurityPolicy::addDirective):
- page/ContentSecurityPolicy.h:
- 1:07 AM Changeset in webkit [84477] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip
fast/transforms/selection-bounds-in-transformed-view.html on GTK as it
depends on eventSender.scalePageBy().
- platform/gtk/Skipped:
- 12:45 AM Changeset in webkit [84476] by
-
- 2 edits in trunk/LayoutTests
2011-04-21 Yuta Kitamura <yutak@chromium.org>
Unreviewed, skip fast/dom/shadow/layout-tests-can-access-shadow.html on Windows.
fast/dom/shadow/layout-tests-can-access-shadow.html is failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=59081
- platform/win/Skipped:
- 12:29 AM Changeset in webkit [84475] by
-
- 6 edits in trunk/Source/WebKit/qt
2011-04-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Csaba Osztrogonác.
[Qt] REGRESSION(84057): It made 4 API tests fail
https://bugs.webkit.org/show_bug.cgi?id=58848
After MIME sniffing support was added, some autotests are failing because
the sniffer doesn't recognize our HTML pages.
This fixes tst_QWebPage::backActionUpdate(), tst_QWebPage::errorPageExtensionInFrameset()
and tst_QWebFrame::horizontalScrollAfterBack().
- tests/qwebframe/resources/testiframe.html:
- tests/qwebframe/resources/testiframe2.html: Remove spurious </html> in beginning of the document.
- tests/qwebpage/resources/framedindex.html:
- tests/qwebpage/resources/index.html: Add <html> (and </html>) tags, <frameset> is not recognized by the sniffer as a possible starting tag for HTML document.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::errorPageExtensionInFrameset): Verify if we do have a main frame and the main frame has the children frames we expect. This will avoid crashing if for some reason children frames are not loaded.
- 12:24 AM Changeset in webkit [84474] by
-
- 2 edits in trunk/Source/WebCore
2011-04-21 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
remove unneeded function from graphicscontext3d.cpp (59076)
https://bugs.webkit.org/show_bug.cgi?id=59076
<rdar://problem/9315681>
- platform/graphics/GraphicsContext3D.cpp: removing unused function unpackOneRowOfRGBA8ToRGBA8
- 12:03 AM Changeset in webkit [84473] by
-
- 5 edits in trunk
2011-04-21 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
REGRESSION: Korean encoding alias KSC5601 does not work
https://bugs.webkit.org/show_bug.cgi?id=59075
<rdar://problem/9303233>
- fast/encoding/char-decoding-expected.txt:
- fast/encoding/char-decoding.html: Added tests for KSC_5601 (which worked, but wasn't tested), and KSC5601 (which was broken).
2011-04-21 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
REGRESSION: Korean encoding alias KSC5601 does not work
https://bugs.webkit.org/show_bug.cgi?id=59075
<rdar://problem/9303233>
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames): Added a KSC5601 alias for KSC_5601, which effectively makes it windows-949.
