Timeline



Apr 23, 2011:

11:22 PM Changeset in webkit [84754] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

[WinCairo] Unreviewed build change.

Activate Geolocation API, as it will work with WinCairo assuming
an appropriate Geolocation Provider is registered.

  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Activate the Geolocation features.
11:01 PM Changeset in webkit [84753] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-04-23 Simon Fraser <Simon Fraser>

Fix Windows build, which complains about unreachable code.

  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar): (WebCore::ScrollableArea::hasLayerForVerticalScrollbar): (WebCore::ScrollableArea::hasLayerForScrollCorner):
10:53 PM Changeset in webkit [84752] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

2011-04-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Area under composited scrollbars not repainted in WebKit2 on scrolling
​https://bugs.webkit.org/show_bug.cgi?id=59294
<rdar://problem/9299062>

When computing the rect that can be copied on scrolling, we normally
exclude the areas occupied by overlay scrollbars to avoid smeared scrollbars;
the assumption is that other code will repaint these areas. However, when
scrollbars are in their own compositing layers, we can, and should
copy the entire area.

Not testable in DRT because it does not allow tests to use overlay scrollbars.

  • platform/ScrollView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::rectToCopyOnScroll): New method, with code moved from scrollContents and fixed to look for scrollbars in layers. (WebCore::ScrollView::scrollContents): Call rectToCopyOnScroll().
  • platform/ScrollableArea.h:
  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar): (WebCore::ScrollableArea::hasLayerForVerticalScrollbar): (WebCore::ScrollableArea::hasLayerForScrollCorner): Methods we can call outside of the ACCELERATED_COMPOSITING #ifdef.
8:59 PM Changeset in webkit [84751] by commit-queue@webkit.org
  • 13 edits in trunk/Source

2011-04-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84740.
​http://trac.webkit.org/changeset/84740
​https://bugs.webkit.org/show_bug.cgi?id=59290

change breaks apple internal builds and is incorrect
(Requested by smfr on #webkit).

  • WebCore.exp.in:
  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/ScrollTypes.h:
  • platform/ScrollableArea.h:
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

2011-04-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84740.
​http://trac.webkit.org/changeset/84740
​https://bugs.webkit.org/show_bug.cgi?id=59290

change breaks apple internal builds and is incorrect
(Requested by smfr on #webkit).

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):

2011-04-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84740.
​http://trac.webkit.org/changeset/84740
​https://bugs.webkit.org/show_bug.cgi?id=59290

change breaks apple internal builds and is incorrect
(Requested by smfr on #webkit).

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface):
8:56 PM Changeset in webkit [84750] by mitz@apple.com
  • 5 edits in trunk

<rdar://problem/8970549> WebFindOptionsAtWordStarts fails with Japanese words
​https://bugs.webkit.org/show_bug.cgi?id=59288

Reviewed by Simon Fraser.

Source/WebCore:

  • platform/text/mac/TextBoundaries.mm:

(WebCore::wordStringTokenizer): Added this helper function.
(WebCore::findNextWordFromIndex): Changed to use a CFStringTokenizer with kCFStringTokenizerUnitWord,
whose behavior is not locale-dependent.

LayoutTests:

  • editing/text-iterator/findString-expected.txt:
  • editing/text-iterator/findString.html:
7:24 PM April 2011 Meeting edited by noam.rosenthal@nokia.com
(diff)
7:12 PM April 2011 Meeting edited by yael.aharon@nokia.com
(diff)
7:10 PM April 2011 Meeting edited by sam@webkit.org
(diff)
7:08 PM April 2011 Meeting edited by alex@milowski.com
(diff)
7:07 PM April 2011 Meeting edited by alex@milowski.com
(diff)
6:31 PM Changeset in webkit [84749] by morrita@google.com
  • 5 edits
    2 adds in trunk

2011-04-23 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Nodes in shadow DOM should not be GCed while their hosts are alive
​https://bugs.webkit.org/show_bug.cgi?id=59284

  • fast/dom/shadow/gc-shadow-expected.txt: Added.
  • fast/dom/shadow/gc-shadow.html: Added.

2011-04-23 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Nodes in shadow DOM should not be GCed while their hosts are alive
​https://bugs.webkit.org/show_bug.cgi?id=59284

Test: fast/dom/shadow/gc-shadow.html

  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): group shadow nodes with their hosts

2011-04-23 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Nodes in shadow DOM should not be GCed while their hosts are alive
​https://bugs.webkit.org/show_bug.cgi?id=59284

Chromium DRT over-refcounted the NPObject wrappers it used to
marshal shadowRoot nodes back to tests (WebBindings::makeNode
births NPObjects with referenceCount == 1). This masked the GC bug
59284 in tests by making shadowRoot nodes live forever.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::shadowRoot): (LayoutTestController::ensureShadowRoot):
6:05 PM Changeset in webkit [84748] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Bug 59287 - DFG JIT - Handle temporaries as vars, allowing support for ?:

Reviewed by Oliver Hunt.

SetLocals to temporaries will only be generated if they are used within other
blocks, due to the SSA based DCE.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.h:

(JSC::DFG::BasicBlock::BasicBlock):

5:51 PM Changeset in webkit [84747] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

2011-04-23 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

[Refactoring] NodeRenderParentDetector should be NodeRenderFactory
​https://bugs.webkit.org/show_bug.cgi?id=59280

  • Rename NodeRenderParentDetector to NodeRendererFactory
  • move createRendererAndStyle() and createRendererIfNeeded to NodeRendererFactory

No new test, no behavioral change.

  • dom/Node.cpp: (WebCore::NodeRendererFactory::NodeRendererFactory): (WebCore::NodeRendererFactory::document): (WebCore::NodeRendererFactory::nextRenderer): (WebCore::NodeRendererFactory::findVisualParent): (WebCore::NodeRendererFactory::shouldCreateRenderer): (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::NodeRendererFactory::createRendererIfNeeded): (WebCore::Node::parentNodeForRenderingAndStyle): (WebCore::Node::createRendererIfNeeded):
  • dom/Node.h:
  • html/HTMLDetailsElement.cpp: (WebCore::DetailsSummaryElement::detailsElement): Added const_cast due to the chage on parentNodeForRenderingAndStyle()
5:17 PM Changeset in webkit [84746] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-04-23 MORITA Hajime <​morrita@google.com>

Unreviewed test_expectations.txt update.
r84745 didn't fix meter-element.html break on chromium.

  • platform/chromium/test_expectations.txt:
4:16 PM Changeset in webkit [84745] by morrita@google.com
  • 4 edits
    6 adds in trunk

2011-04-23 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
​https://bugs.webkit.org/show_bug.cgi?id=59281

  • fast/dom/HTMLMeterElement/meter-writing-mode.html: Added.
  • fast/dom/HTMLProgressElement/progress-writing-mode.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
  • platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
  • platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.

2011-04-23 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
​https://bugs.webkit.org/show_bug.cgi?id=59281

Styles for -webkit-meter-bar and -webkit-progress-bar missed width property, which caused unexpected layout results
for vertical writing modes. This fix added a width property for each of them.

Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html

fast/dom/HTMLProgressElement/progress-writing-mode.html

  • css/html.css: (meter::-webkit-meter-bar): (progress::-webkit-progress-bar):
1:16 PM Changeset in webkit [84744] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Bug 59266 - DFG JIT - Add SSA style DCE

Reviewed by Sam Weinig & Geoff Garen.

This works by making GetLocal nodes reference SetLocal nodes from prior blocks,
via intermediate Phi nodes. Whenever we add a GetLocal to the graph, also add a
matching child Phi, and add the Phi to a work queue to add references to prior
definitions once we have the full CFG & can determine predecessors. This process
is iterative, inserting new phis into predecessors as necessary.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processWorkQueue):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::refChildren):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::ref):

  • dfg/DFGNode.h:

(JSC::DFG::Node::ref):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::dump):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

1:05 PM Changeset in webkit [84743] by kevino@webkit.org
  • 7 edits in trunk

[wx] Unreviewed build fixes for recent trunk changes.

12:14 PM Changeset in webkit [84742] by ap@apple.com
  • 10 edits in trunk

2011-04-23 Alexey Proskuryakov <​ap@apple.com>

Unreviewed.

REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=59241
<rdar://problem/9150861>

  • http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Resource load delegates for cancelled loads are now correctly sent before frame load delegate's didFinishLoading, so cancellation errors get logged by DumpRenderTree.

2011-04-23 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=59241
<rdar://problem/9150861>

Covered by manual-tests/print-after-window-close.html.

Re-fixing <​https://bugs.webkit.org/show_bug.cgi?id=51357> in a way that doesn't cause the
regression.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): We shouldn't be doing complicated work while the loader is half-canceled.
  • manual-tests/print-after-window-close.html: Extended to actually print a non-empty page, thus being more practical.
  • page/Chrome.cpp: (WebCore::Chrome::print): Added a FIXME about a need for PageGroupLoadDeferrer. It's too scary for me to try now.
12:11 AM Changeset in webkit [84741] by vitalyr@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-04-19 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Use implicit references for V8 listeners on DOM nodes.
​https://bugs.webkit.org/show_bug.cgi?id=58953

Instead of allocating an auxiliary V8 array referencing V8
listener objects associated with a DOM node and using an extra
pointer in every DOM node wrapper, we can register implicit
references between nodes and their listeners during GC. This also
makes V8 bindings more aligned with JSC bindings.

No new tests because this is a refactoring.

  • bindings/scripts/CodeGeneratorV8.pm: Stopped generating the listener cache internal field for DOM nodes.
  • bindings/v8/V8AbstractEventListener.h: Exposed the lister handle to the GC. (WebCore::V8AbstractEventListener::existingListenerObjectPeristentHandle):
  • bindings/v8/V8GCController.cpp: Started using implicit references. (WebCore::GrouperVisitor::visitDOMWrapper):
  • dom/EventTarget.h: Implemented an iterator over all listeners. (WebCore::EventListenerIterator):

Apr 22, 2011:

11:38 PM April 2011 Meeting edited by sjl@chromium.org
(diff)
11:22 PM Changeset in webkit [84740] by commit-queue@webkit.org
  • 13 edits in trunk/Source

2011-04-22 Jon Lee <​jonlee@apple.com>

Reviewed by Beth Dakin.

Overlay scroller hard to see on pages with dark background (59183)
​https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>

  • WebCore.exp.in: adding method to allow changing style
  • page/FrameView.cpp: (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
  • page/FrameView.h:
  • platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
  • platform/ScrollableArea.h:
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

2011-04-22 Jon Lee <​jonlee@apple.com>

Reviewed by Beth Dakin.

Overlay scroller hard to see on pages with dark background (59183)
​https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style

2011-04-22 Jon Lee <​jonlee@apple.com>

Reviewed by Beth Dakin.

Overlay scroller hard to see on pages with dark background (59183)
​https://bugs.webkit.org/show_bug.cgi?id=59183
<rdar://problem/8975367>

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style
10:55 PM Changeset in webkit [84739] by commit-queue@webkit.org
  • 8 edits in trunk

2011-04-22 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Upgrade CSS loads from mixed content warning (displayed) to mixed
content error (ran)
​https://bugs.webkit.org/show_bug.cgi?id=59056

  • http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt: Update expectation.
  • http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Update expectation.
  • http/tests/security/mixedContent/insecure-css-in-iframe.html: Update expectation.
  • http/tests/security/mixedContent/insecure-css-in-main-frame.html: Update expectation.
  • http/tests/security/mixedContent/resources/frame-with-insecure-css.html: Fix typo.

2011-04-22 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Upgrade CSS loads from mixed content warning (displayed) to mixed
content error (ran)
​https://bugs.webkit.org/show_bug.cgi?id=59056

Test: http/tests/security/mixedContent/insecure-css-in-iframe.html
Test: http/tests/security/mixedContent/insecure-css-in-main-frame.html

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest): CSS loads are running rather than displaying content.
10:09 PM Changeset in webkit [84738] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Add some failing tests to the Skipped list because of a WTR sideeffect bug.

  • platform/qt-wk2/Skipped:
9:44 PM Changeset in webkit [84737] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed an upside-down conditional in my last check-in.

  • bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::isObservable):

9:41 PM Changeset in webkit [84736] by ggaren@apple.com
  • 19 edits in trunk/Source/WebCore

2011-04-22 Geoffrey Garen <​ggaren@apple.com>

Rolled back in r84725 and r84728 with appcache crash fixed.

Reviewed by Oliver Hunt.

Removed a use of markDOMObjectWrapper: DOMWindow
​https://bugs.webkit.org/show_bug.cgi?id=59260

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since we use the opaque roots system now.
  • bindings/js/JSNavigatorCustom.cpp: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects whose opaque roots are frames.
  • css/StyleMedia.h: (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.
  • css/StyleMedia.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/BarInfo.idl:
  • page/Console.idl:
  • page/DOMSelection.idl:
  • page/Geolocation.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/Navigator.idl:
  • page/Screen.idl:
  • storage/Storage.idl: Updated to use the opaque roots system.
9:37 PM Changeset in webkit [84735] by Csaba Osztrogonác
  • 604 edits
    565 adds in trunk/LayoutTests

[Qt] Unskip a bunch of passing tests and update their expected files.
This patch based on work of Kristóf Kosztyó <​Kosztyo.Kristof@stud.u-szeged.hu>

  • platform/qt/Skipped:
  • platform/qt/fast/[...]: Added, updated.
  • platform/qt/scrollbars/[...]: Added, updated.
9:01 PM April 2011 Meeting edited by ojan@chromium.org
(diff)
8:41 PM Changeset in webkit [84734] by commit-queue@webkit.org
  • 7 edits
    4 deletes in trunk

2011-04-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84627.
​http://trac.webkit.org/changeset/84627
​https://bugs.webkit.org/show_bug.cgi?id=59271

It broke Symbian build (Requested by Ossy on #webkit).

  • Source/WebKit.pro:

2011-04-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84627.
​http://trac.webkit.org/changeset/84627
​https://bugs.webkit.org/show_bug.cgi?id=59271

It broke Symbian build (Requested by Ossy on #webkit).

  • QtWebKit.pro:
  • symbian/platformplugin/WebPlugin.cpp: Removed.
  • symbian/platformplugin/WebPlugin.h: Removed.
  • symbian/platformplugin/platformplugin.pro: Removed.
  • symbian/platformplugin/qwebkitplatformplugin.h: Removed.

2011-04-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84627.
​http://trac.webkit.org/changeset/84627
​https://bugs.webkit.org/show_bug.cgi?id=59271

It broke Symbian build (Requested by Ossy on #webkit).

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
8:23 PM April 2011 Meeting edited by dpranke@chromium.org
(diff)
8:22 PM Changeset in webkit [84733] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-22 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change - clean up some flakiness.

  • platform/chromium/test_expectations.txt:
8:20 PM Changeset in webkit [84732] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

2011-04-22 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Don't use XMLTreeViewer when script is disabled (it uses Javascript
to build a prettified version of the xml document).
​https://bugs.webkit.org/show_bug.cgi?id=59113

  • xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView):
8:19 PM April 2011 Meeting edited by levin@chromium.org
(diff)
8:17 PM Changeset in webkit [84731] by Csaba Osztrogonác
  • 18 edits in trunk/Source/WebCore

2011-04-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84725 and r84728.
​http://trac.webkit.org/changeset/84725
​http://trac.webkit.org/changeset/84728
​https://bugs.webkit.org/show_bug.cgi?id=59270

It broke http/tests/appcache tests (Requested by Ossy on
#webkit).

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren):
  • bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::visitChildren):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/StyleMedia.h:
  • css/StyleMedia.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/BarInfo.idl:
  • page/Console.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.h: (WebCore::DOMWindow::optionalScreen): (WebCore::DOMWindow::optionalSelection): (WebCore::DOMWindow::optionalHistory): (WebCore::DOMWindow::optionalCrypto): (WebCore::DOMWindow::optionalLocationbar): (WebCore::DOMWindow::optionalMenubar): (WebCore::DOMWindow::optionalPersonalbar): (WebCore::DOMWindow::optionalScrollbars): (WebCore::DOMWindow::optionalStatusbar): (WebCore::DOMWindow::optionalToolbar): (WebCore::DOMWindow::optionalConsole): (WebCore::DOMWindow::optionalNavigator): (WebCore::DOMWindow::optionalLocation): (WebCore::DOMWindow::optionalMedia): (WebCore::DOMWindow::optionalSessionStorage): (WebCore::DOMWindow::optionalLocalStorage): (WebCore::DOMWindow::optionalPerformance):
  • page/Geolocation.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/Navigator.h: (WebCore::Navigator::optionalGeolocation):
  • page/Navigator.idl:
  • page/Screen.idl:
  • storage/Storage.idl:
8:17 PM Changeset in webkit [84730] by dpranke@chromium.org
  • 6 edits in trunk/Tools

2011-04-22 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

rebaseline-chromium-webkit-tests: clean up output
​https://bugs.webkit.org/show_bug.cgi?id=59240

This change dramatically changes the output the tool provides
by default. The previous output (more or less) is still there
in -v / verbose / debug mode, but the default output is
way terser and more readable. It mostly says which files are
updated, which are duplicates, and which are not found in an
archive. Feedback desired :).

This change also adds a scm.exists() method to the SCM object
so that we can cleanly figure out what we're doing while
rebaselining.

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
8:09 PM Changeset in webkit [84729] by Dimitri Glazkov
  • 4 edits in trunk/Source/WebCore

2011-04-22 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Change SVG-related shadow root checks to use isSVGShadowRoot.
​https://bugs.webkit.org/show_bug.cgi?id=59237

Covered by existing tests, no behavior change.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Use isSVGShadowRoot.
  • svg/SVGUseElement.cpp: (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::insertedIntoDocument): Ditto.
7:50 PM April 2011 Meeting edited by noam.rosenthal@nokia.com
Proposing a hw acceleration talk (diff)
7:48 PM April 2011 Meeting edited by morrita@google.com
(diff)
7:22 PM Changeset in webkit [84728] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Mac build fix.

  • page/DOMWindow.h:

(WebCore::DOMWindow::optionalApplicationCache): Restored this function,
which is used after all.

7:19 PM Changeset in webkit [84727] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-04-22 Ilya Sherman <​isherman@chromium.org>

Reviewed by Alexey Proskuryakov.

Add Ilya Sherman (​isherman@chromium.org) to the list of contributors
​https://bugs.webkit.org/show_bug.cgi?id=59231

  • Scripts/webkitpy/common/config/committers.py:
7:16 PM Changeset in webkit [84726] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-22 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

don't white-space:nowrap the results iframes
​https://bugs.webkit.org/show_bug.cgi?id=59259

  • fast/harness/results.html:
7:09 PM Changeset in webkit [84725] by ggaren@apple.com
  • 18 edits in trunk/Source/WebCore

2011-04-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed a use of markDOMObjectWrapper: DOMWindow
​https://bugs.webkit.org/show_bug.cgi?id=59260

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since we use the opaque roots system now.
  • bindings/js/JSNavigatorCustom.cpp: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects whose opaque roots are frames.
  • css/StyleMedia.h: (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.
  • css/StyleMedia.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/BarInfo.idl:
  • page/Console.idl:
  • page/DOMSelection.idl:
  • page/Geolocation.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/Navigator.idl:
  • page/Screen.idl:
  • storage/Storage.idl: Updated to use the opaque roots system.
7:05 PM Changeset in webkit [84724] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-22 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change. Roll in deps bots failures.

  • platform/chromium/test_expectations.txt:
7:03 PM April 2011 Meeting edited by rniwa@webkit.org
Adding myself to enrica's talk (diff)
7:03 PM Changeset in webkit [84723] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: Stop responsiveness timer before calling runOpenPanel
​https://bugs.webkit.org/show_bug.cgi?id=59268
<rdar://problem/9327944>

Reviewed by Sam Weinig.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runOpenPanel): Stop the timer before calling WebUIClient::runOpenPanel,

because runOpenPanel can spin a nested run loop.

6:48 PM Changeset in webkit [84722] by yutak@chromium.org
  • 2 edits in trunk/Tools

2011-04-22 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: Exception raised when stderr contains binary data
​https://bugs.webkit.org/show_bug.cgi?id=59083

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Use write_binary_file() instead of write_text_file().
6:35 PM April 2011 Meeting edited by mjs@apple.com
(diff)
6:14 PM Changeset in webkit [84721] by commit-queue@webkit.org
  • 12 edits in trunk

2011-04-22 Chang Shu <​cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
​https://bugs.webkit.org/show_bug.cgi?id=42536

Unskip passed tests.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-04-22 Chang Shu <​cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
​https://bugs.webkit.org/show_bug.cgi?id=42536

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetFrameFlatteningEnabled):
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setFrameFlatteningEnabled):
  • WebProcess/InjectedBundle/InjectedBundle.h:

2011-04-22 Chang Shu <​cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
​https://bugs.webkit.org/show_bug.cgi?id=42536

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setFrameFlatteningEnabled):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
6:09 PM Changeset in webkit [84720] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-22 Xiaomei Ji <​xji@chromium.org>

[QT] move-by-word-visually.html failed in QT.
​https://bugs.webkit.org/show_bug.cgi?id=59265


Temporarily skip the test in QT while investigating.

  • platform/qt/Skipped:
6:03 PM Changeset in webkit [84719] by alex
  • 2 edits in trunk/LayoutTests

2011-04-22 Alejandro G. Castro <​alex@igalia.com>

Undo rebaseline done in r84677 for this test, it was a flaky
execution.

  • platform/gtk/media/video-controls-rendering-expected.txt:
5:59 PM Changeset in webkit [84718] by vitalyr@chromium.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-22 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Adam Barth.

Add missing default constructors for HashMap iterator specializations.
​https://bugs.webkit.org/show_bug.cgi?id=59250

  • wtf/HashIterators.h:
  • wtf/HashTable.h: (WTF::HashTableConstIterator::HashTableConstIterator): Added cast to help compiler find the function template.
5:54 PM Changeset in webkit [84717] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Bug 59262 - DFG JIT - reduce size of VariableRecord

Reviewed by Sam Weinig.

We never need both the get & set node, only the most recent
(which is always a set, if both exist).

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.h:

(JSC::DFG::VariableRecord::VariableRecord):

5:39 PM Changeset in webkit [84716] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

5:38 PM April 2011 Meeting edited by dbates@webkit.org
(diff)
5:37 PM Changeset in webkit [84715] by mahesh.kulkarni@nokia.com
  • 3 edits in trunk/LayoutTests

Unreviewed: Updated bug ID for geolocation skipped cases

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
5:37 PM April 2011 Meeting edited by abarth@webkit.org
(diff)
5:36 PM April 2011 Meeting edited by abarth@webkit.org
(diff)
5:34 PM Changeset in webkit [84714] by Lucas Forschler
  • 6 edits in trunk

roll out incorrect versioning info (included extra file).

5:30 PM Changeset in webkit [84713] by Martin Robinson
  • 4 edits in trunk

2011-04-22 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=58976

  • platform/gtk/Skipped: Unskip a test which is no longer crashing.

2011-04-22 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=58976

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::getInnerText): Guard against situations when the documentElement method of the document returns null.
5:25 PM Changeset in webkit [84712] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

2011-04-22 Alejandro G. Castro <​alex@igalia.com> and Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use the libWebCore.a convenience library when compiling WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=59258

  • GNUmakefile.am: Remove the libWebKit2 convenience library and use the libWebCore convenience library when compiling WebKit2. Not only does this maintain the CPPFLAGS isolation, it prevents double-compilation of WebCore in some cases.
5:23 PM Changeset in webkit [84711] by Lucas Forschler
  • 6 edits in trunk

Versioning.

5:12 PM Changeset in webkit [84710] by xji@chromium.org
  • 5 edits in trunk

2011-04-22 Xiaomei Ji <​xji@chromium.org>

Reviewed by Ryosuke Niwa.

move caret by word in visual order returns wrong result when caret itself is at word boundary.
​https://bugs.webkit.org/show_bug.cgi?id=58504.

Add test case to test moving left/right by word visually on every character position.
Remove a specific test added before for testing a specific code path since the test case
is covered now.

  • editing/selection/move-by-word-visually-expected.txt:
  • editing/selection/move-by-word-visually.html:

2011-04-22 Xiaomei Ji <​xji@chromium.org>

Reviewed by Ryosuke Niwa.

move caret by word in visual order returns wrong result when caret itself is at word boundary.
​https://bugs.webkit.org/show_bug.cgi?id=58504.

positionBeforeNextWord should take care that the current position is after current word.
positionAfterPreviousWord should take care that the current positin is before current word.

  • editing/visible_units.cpp: (WebCore::positionBeforeNextWord): (WebCore::positionAfterPreviousWord):
5:08 PM Changeset in webkit [84709] by xji@chromium.org
  • 1 edit
    10 adds in trunk/LayoutTests

2011-04-22 Xiaomei Ji <​xji@chromium.org>

Rebaseline after r84655.

  • platform/chromium-linux/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
  • platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added.
  • platform/chromium-mac/fast/block/positioning/vertical-rl: Added.
  • platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added.
  • platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
4:59 PM Changeset in webkit [84708] by xji@chromium.org
  • 7 edits
    4 adds in trunk/LayoutTests

2011-04-22 Xiaomei Ji <​xji@chromium.org>

Rebase after r84659.

  • platform/chromium-linux/editing/deleting/table-cells-expected.png:
  • platform/chromium-linux/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
  • platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/chromium-mac-leopard/editing/deleting/table-cells-expected.png:
  • platform/chromium-mac-leopard/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/chromium-mac/editing/deleting/table-cells-expected.png: Added.
  • platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.png: Added.
  • platform/chromium-win/editing/deleting/table-cells-expected.png:
  • platform/chromium-win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
  • platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:
4:54 PM Changeset in webkit [84707] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-22 Eric Seidel <​eric@webkit.org>

Reviewed by Eric Carlson.

Flaky Test: media/invalid-media-url-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=51138

Add one more test to the list of known crashers from rdar://9054715.

  • platform/mac-snowleopard/Skipped:
4:52 PM Changeset in webkit [84706] by jer.noble@apple.com
  • 18 edits
    5 adds in trunk

2011-04-19 Jer Noble <​jer.noble@apple.com>

Reviewed by Daniel Bates.

Full Screen from within an <iframe> does not cause <iframe> to resize.
​https://bugs.webkit.org/show_bug.cgi?id=58638

  • fullscreen/full-screen-frameset-expected.txt: Added.
  • fullscreen/full-screen-frameset.html: Added.
  • fullscreen/content/inner.html: Added.
  • fullscreen/full-screen-iframe-allowed-expected.txt: Updated.
  • fullscreen/full-screen-iframe-allowed.html: Add a button with which to trigger

full screen mode in Safari.

  • fullscreen/full-screen-iframe-not-allowed-expected.txt: Updated.
  • fullscreen/full-screen-iframe-not-allowed.html: Ditto.
  • fullscreen/resources/allowed.html: Added.
  • fullscreen/resources/inner.html: Added.

2011-04-19 Jer Noble <​jer.noble@apple.com>

Reviewed by Daniel Bates.

Full Screen from within an <iframe> does not cause <iframe> to resize.
​https://bugs.webkit.org/show_bug.cgi?id=58638

Tests: fullscreen/full-screen-frameset.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Add the

-webkit-full-screen pseudo class to frame elements which contain
full screen elements.

  • css/fullscreen.css: (iframe:-webkit-full-screen): Add iframe-specific styling rules.
  • dom/Document.cpp: (WebCore::Document::setContainsFullScreenElementRecursively): Added. Walk up each

successive document owner element, calling setContainsFullScreenElement() if
owner is a frame element.

(WebCore::Document::fullScreenIsAllowedForElement): Use the new Element::isFrameElementBase

call instead of checking the element's tag name.

(WebCore::Document::webkitWillEnterFullScreenForElement): Mark any containing

iframes as containing a full screen element.

(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.

  • dom/Element.h: (WebCore::Element::isFrameElementBase): Added.
  • html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::allowFullScreen): Disable full screen from within

HTMLFrameElements.

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Added.
  • html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::containsFullScreenElement): Added. (WebCore::HTMLFrameElementBase::isFrameElementBase): Added.

2011-04-19 Jer Noble <​jer.noble@apple.com>

Reviewed by Daniel Bates.

Full Screen from within an <iframe> does not cause <iframe> to resize.
​https://bugs.webkit.org/show_bug.cgi?id=58638

Tests: fullscreen/full-screen-frameset-allowed.html

fullscreen/full-screen-frameset-not-allowed.html

Return the _element's document instead of the WKView's document, which
will be different in the case of elements within <iframe>s.

  • WebView/WebFullScreenController.mm: (-[WebFullScreenController _document]):

2011-04-19 Jer Noble <​jer.noble@apple.com>

Reviewed by Daniel Bates.

Full Screen from within an <iframe> does not cause <iframe> to resize.
​https://bugs.webkit.org/show_bug.cgi?id=58638

Tests: fullscreen/full-screen-frameset-allowed.html

fullscreen/full-screen-frameset-not-allowed.html

  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Cancel the background animation

if the full screen animation finishes first.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): m_fullScreenRootLayer was uninitialized.
4:38 PM Changeset in webkit [84705] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Bug 59254 - DFG JIT - retain VariableRecords for args/var in all basic blocks,
such that this information is available for DCE. Also, since this enlarges the
size of BasicBlock, make Graph hold a vector of pointers to basic blocks, not a
vector of blocks.

Reviewed by Geoffrey Garen.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::VariableRecord::VariableRecord):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeBegin):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
(JSC::DFG::Graph::blockForBytecodeOffset):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):

4:35 PM Changeset in webkit [84704] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-04-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CommitQueue should remember the expected failures from patch to patch
​https://bugs.webkit.org/show_bug.cgi?id=59253

Previously, we stored the set of expected failures on the task object,
which meant the commit-queue forgot about them after each patch. This
patch moves them to the CommitQueue object so they will have a longer
lifetime.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
  • Scripts/webkitpy/tool/commands/queues.py:
4:34 PM Changeset in webkit [84703] by Lucas Forschler
  • 1 copy in tags/Safari-534.31

New tag.

4:29 PM Changeset in webkit [84702] by weinig@apple.com
  • 13 edits in trunk

2011-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Brian Weinstein.

WebKit2: Implement JavaScript unresponsiveness timer/callbacks
​https://bugs.webkit.org/show_bug.cgi?id=59248

Stub out shouldInterruptJavaScript callbacks.

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
  • MiniBrowser/win/BrowserView.cpp: (BrowserView::create):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::initialize):

2011-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Brian Weinstein.

WebKit2: Implement JavaScript unresponsiveness callback
​https://bugs.webkit.org/show_bug.cgi?id=59248

Add support for suspending JavaScript in response to a callback.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::shouldInterruptJavaScript):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::shouldInterruptJavaScript):
  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::shouldInterruptJavaScript):
4:11 PM Changeset in webkit [84701] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-22 Michael Saboff <​msaboff@apple.com>

Reviewed by Maciej Stachowiak.

Creating copy of ContainerNode's when inserting or removing is inefficient
​https://bugs.webkit.org/show_bug.cgi?id=58695

Eliminated node copying in willRemove() and insertedIntoDocument().

No new tests as this is a more efficient implementation of
existing code that is covered by existing tests.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::willRemove): Changed method to use RefPtr<> to protect against modification during removal. (WebCore::ContainerNode::insertedIntoDocument): Changed method to use RefPtr<> and two other deletion checks to protect against modification during insertion.
4:09 PM Changeset in webkit [84700] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Errk, build fix.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:04 PM Changeset in webkit [84699] by ggaren@apple.com
  • 32 edits in trunk/Source/WebCore

2011-04-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

We have an autogenerator, so use it
​https://bugs.webkit.org/show_bug.cgi?id=59247

  • bindings/js/JSCSSRuleCustom.cpp:
  • bindings/js/JSCSSRuleListCustom.cpp:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:
  • bindings/js/JSCSSValueCustom.cpp:
  • bindings/js/JSCanvasRenderingContextCustom.cpp:
  • bindings/js/JSDOMImplementationCustom.cpp:
  • bindings/js/JSDOMStringMapCustom.cpp:
  • bindings/js/JSHTMLCollectionCustom.cpp:
  • bindings/js/JSNamedNodeMapCustom.cpp:
  • bindings/js/JSNodeCustom.h:
  • bindings/js/JSNodeListCustom.cpp:
  • bindings/js/JSStyleSheetCustom.cpp:
  • bindings/js/JSStyleSheetListCustom.cpp: Removed repetitive hand-written code.
  • bindings/scripts/CodeGeneratorJS.pm: Augmented autogenerator to do the job.
  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMStringMap.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeList.idl:
  • html/DOMTokenList.idl:
  • html/HTMLCollection.idl:
  • html/canvas/CanvasRenderingContext.idl: Updated attributes to plug into the autogenerator.
4:01 PM Changeset in webkit [84698] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-22 Dan Bernstein <​mitz@apple.com>

Reviewed by Sam Weinig.

Paint the bounding rect of the dirty region instead of individual rectangles when the region
covers at least 3/4 of its bounds.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to achieve this actually works.
3:59 PM April 2011 Meeting edited by enrica@apple.com
(diff)
3:47 PM Changeset in webkit [84697] by dbates@webkit.org
  • 3 edits in trunk/Tools

2011-04-22 Daniel Bates <​dbates@webkit.org>

Reviewed by Csaba Osztrogonác.

webkit-patch land hangs if svn prompts for credentials
​https://bugs.webkit.org/show_bug.cgi?id=31500

Make has_authorization_for_realm() return True only if there exists a credentials file
that contains either the word "password" or "passtype". We assume that these words don't
coincide with the actual credential data (e.g. a person's username is "password").

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Added test cases: test_has_authorization_for_realm_using_credentials_with_passtype(), test_has_authorization_for_realm_using_credentials_with_password(), test_not_have_authorization_for_realm_with_credentials_missing_password_and_passtype()
    • Renamed test_not_have_authorization_for_realm() to test_not_have_authorization_for_realm_when_missing_credentials_file() to better describe what it's testing.
    • Repurposed test_has_authorization_for_realm() to take realm and credential data to use and return the result of calling has_authorization_for_realm() so that the caller can assert the result; Renamed to _test_has_authorization_for_realm_using_credentials() to better reflect its new purpose.
3:45 PM Changeset in webkit [84696] by xji@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-04-22 Xiaomei Ji <​xji@chromium.org>

Rebaseline after r84659.

  • platform/mac-wk2/fast/forms: Added.
  • platform/mac-wk2/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
  • platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
3:44 PM Changeset in webkit [84695] by Joseph Pecoraro
  • 13 edits in trunk/Source/WebCore

2011-04-22 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kent Tamura.

Let the RenderTheme decide if an input type should have a spinner
​https://bugs.webkit.org/show_bug.cgi?id=59246

Whether an input should have a spinner or not should
be a UI decision made by the RenderTheme. Remove
WebCore's default hasSpinButton values and defer
to the RenderTheme.

No change in functionality, covered by existing tests.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isRangeControl): expose isRangeControl for possible RenderTheme queries.
  • html/HTMLInputElement.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): For both of these ask the render theme if the input should have a spinner.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::shouldHaveSpinButtonForInputElement): Steppable inputs (number, date, and range) but not range should have spinners. This does not change existing behavior.
  • rendering/RenderTheme.h:
  • dom/InputElement.h:
  • html/BaseDateAndTimeInputType.cpp: remove hasSpinButton.
  • html/BaseDateAndTimeInputType.h: remove hasSpinButton.
  • html/InputType.cpp: remove hasSpinButton.
  • html/InputType.h: remove hasSpinButton.
  • html/NumberInputType.cpp: remove hasSpinButton.
  • html/NumberInputType.h: remove hasSpinButton.
3:42 PM Changeset in webkit [84694] by Beth Dakin
  • 1 edit
    3 adds in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=59223
REGRESSION (r82185): iframe not displayed after navigation back to cached page

Reviewed by Maciej Stachowiak.

Manual test added.

  • manual-tests/frame-layout-on-back.html: Added.
  • manual-tests/resources/empty-document-goes-back.html: Added.
  • manual-tests/resources/simple-iframe.html: Added.
3:36 PM Changeset in webkit [84693] by yael.aharon@nokia.com
  • 6 edits
    2 adds in trunk

2011-04-22 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Sam Weinig.

HTMLFormControlElement::labels should allow custom attributes.
​https://bugs.webkit.org/show_bug.cgi?id=59128

  • fast/forms/labels-custom-property-expected.txt: Added.
  • fast/forms/labels-custom-property.html: Added.

2011-04-22 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Sam Weinig.

HTMLFormControlElement::labels should allow custom attributes.
​https://bugs.webkit.org/show_bug.cgi?id=59128

Cache the labels list when it is created and keep using it for future
labels calls.

Test: fast/forms/labels-custom-property.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):
3:34 PM Changeset in webkit [84692] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-04-22 Adam Barth <​abarth@webkit.org>

Remove double-negative. (Sorry this was bugging me.)

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
3:27 PM Changeset in webkit [84691] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Quick cleanup to SpeculativeJIT/NonSpeculativeJIT compile loop,
move out the call to checkConsistency().

Reviewed by Sam Weinig.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

3:21 PM Changeset in webkit [84690] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-22 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Remove minimum texture size for compositor tiling
​https://bugs.webkit.org/show_bug.cgi?id=59236

This was mistakenly committed in r83915 and causes bad filtering
on very small textures.

Tests: compositing/images/content-image-change.html

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::setTileSize):
3:20 PM April 2011 Meeting edited by mjs@apple.com
(diff)
3:19 PM April 2011 Meeting edited by mjs@apple.com
(diff)
3:18 PM April 2011 Meeting edited by mjs@apple.com
(diff)
3:17 PM Changeset in webkit [84689] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/Tools

2011-04-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor LayoutTestResultsReader out of CommitQueue
​https://bugs.webkit.org/show_bug.cgi?id=59244

This code will be shared with the EWS when they start running tests.

  • Scripts/webkitpy/tool/bot/layouttestresultsreader.py: Added.
  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
3:14 PM April 2011 Meeting edited by mjs@apple.com
Add back changes that I inadvertently stepped on. (diff)
3:13 PM April 2011 Meeting edited by mjs@apple.com
(diff)
3:10 PM Changeset in webkit [84688] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=59223
REGRESSION (r82185): iframe not displayed after navigation back to cached page
-and corresponding-
<rdar://problem/9323763>

Reviewed by Maciej Stachowiak.

Cache the scroll position in Document::setInPageCache() instead of
FrameView::resetScrollbarsAndClearContentsSize(), and only clear the contents size
for the mainFrame(). Still resetScrollbars() for other frames, which matches pre-
r82185 code.

  • dom/Document.cpp:

(WebCore::Document::setInPageCache):

  • page/FrameView.cpp:

(WebCore::FrameView::resetScrollbarsAndClearContentsSize):

3:09 PM April 2011 Meeting edited by rniwa@webkit.org
Adding myself to line-layout talk. (diff)
3:07 PM April 2011 Meeting edited by sam@webkit.org
(diff)
3:01 PM Changeset in webkit [84687] by vitalyr@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-21 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Adam Barth.

Provide default constructors for HashMap iterators.
​https://bugs.webkit.org/show_bug.cgi?id=59151

These will be used to implement an iterator over EventTarget's
listeners.

  • wtf/HashTable.h: (WTF::HashTableConstIteratorAdapter::HashTableConstIteratorAdapter): (WTF::HashTableIteratorAdapter::HashTableIteratorAdapter):
2:56 PM Changeset in webkit [84686] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-then-forward.html fails
​https://bugs.webkit.org/show_bug.cgi?id=58977

r84604 fixed the bug, so we can unskip it.

  • platform/qt/Skipped: Unskip platform/qt/fast/history/back-to-unreachable-url-then-forward.html.
2:37 PM Changeset in webkit [84685] by rolandsteiner@chromium.org
  • 3 edits
    4 deletes in trunk/LayoutTests

2011-04-22 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed: Updated Chromium expectations after WK r84606

  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-mac/fast/url/host-expected.txt: Removed.
  • platform/chromium-mac/fast/url/path-expected.txt: Removed.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-win/fast/url/host-expected.txt: Removed.
  • platform/chromium-win/fast/url/path-expected.txt: Removed.
2:33 PM Changeset in webkit [84684] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Bug 59232 - DFG JIT - Add predecessor links to BasicBlocks

Reviewed by Geoff Garen.

These will be necessary for DCE support.
Also factor allocateVirtualRegisters out into its own method.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::blockForBytecodeOffset):

  • dfg/DFGNode.h:

(JSC::DFG::Node::isTerminal):

2:32 PM Changeset in webkit [84683] by Joseph Pecoraro
  • 11 edits in trunk/Source/WebCore

2011-04-22 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kent Tamura.

Don't rely on hasSpinButton to check if an input type can be stepped
​https://bugs.webkit.org/show_bug.cgi?id=59224

Add isSteppable to know for certain if an input type can
be stepped or not. Previously we were checking if the input
has a spin control or is the range input type. These are UI
details, but the step functionality does not require there
to be a UI.

No change in behavior, covered by existing tests.

  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::isSteppable):
  • html/BaseDateAndTimeInputType.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSteppable): (WebCore::HTMLInputElement::stepUpFromRenderer): remove the check for a spinner and range control and instead ASSERT that the type is steppable.
  • html/HTMLInputElement.h:
  • html/InputType.cpp: (WebCore::InputType::isSteppable):
  • html/InputType.h:
  • html/NumberInputType.cpp: (WebCore::NumberInputType::isSteppable):
  • html/NumberInputType.h:
  • html/RangeInputType.cpp: (WebCore::RangeInputType::isSteppable):
  • html/RangeInputType.h:
2:24 PM Changeset in webkit [84682] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Paint the bounding rect of the dirty region instead of individual rectangles when the region
covers at least 3/4 of its bounds.

Reviewed by Sam Weinig.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to
achieve this actually works.

2:20 PM Changeset in webkit [84681] by abarth@webkit.org
  • 7 edits in trunk

2011-04-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP frame-src is missing
​https://bugs.webkit.org/show_bug.cgi?id=58643

Update expected result to show that this test is passing now.

  • http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:

2011-04-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP frame-src is missing
​https://bugs.webkit.org/show_bug.cgi?id=58643

In this patch, I've audited all the callers to
SecurityOrigin::canDisplay to make sure they all the appropriate
Content-Security-Policy method as well. I'm not sure how to test all
these cases, but making this changes fixed the frame-src test.

  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::loadPlugin):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest): (WebCore::CachedResourceLoader::requestResource):
    • While I was understanding this code, I fixed the FIXME here.
  • loader/cache/CachedResourceLoader.h:
2:17 PM Changeset in webkit [84680] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-22 Adrienne Walker <​enne@google.com>

Reviewed by Simon Fraser.

Clear shared graphics context when destroying CanvasRenderingContext2D.
​https://bugs.webkit.org/show_bug.cgi?id=59212

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
2:17 PM Changeset in webkit [84679] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-04-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Object.create creates uncachable objects
​https://bugs.webkit.org/show_bug.cgi?id=59164

Use the prototype object's inheritorID, as we
should always have done

  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::visitChildren):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::nullPrototypeObjectStructure):
  • runtime/ObjectConstructor.cpp: (JSC::objectConstructorCreate):
2:05 PM Changeset in webkit [84678] by leviw@chromium.org
  • 3 edits
    3 adds in trunk

2011-04-22 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

End/Home keys do not work in a contentEditable element
​https://bugs.webkit.org/show_bug.cgi?id=50564

Fixing modifying selection by lineboundary (home/end) for editable contexts that are
inline and share a line with non-editable content.

  • editing/selection/modify-by-lineboundary-in-inline-editable-contexts-expected.txt: Added.
  • editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html: Added.
  • editing/selection/script-tests/modify-by-lineboundary-in-inline-editable-contexts.js: Added. (testModifyByLine):

2011-04-22 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

End/Home keys do not work in a contentEditable element
​https://bugs.webkit.org/show_bug.cgi?id=50564

Changing logical[Start/End]OfLine to return a valid VisiblePosition for for editable contexts that are
inline and share a line with non-editable content.

Test: editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html

  • editing/visible_units.cpp: (WebCore::logicalStartOfLine): (WebCore::logicalEndOfLine):
1:54 PM Changeset in webkit [84677] by Dimitri Glazkov
  • 47 edits in trunk/LayoutTests

2011-04-22 Dimitri Glazkov <Dimitri Glazkov>

[Gtk] Update expectations after r84511.

  • platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-1-expected.txt:
  • platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-10-expected.txt:
  • platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-2-expected.txt:
  • platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-3-expected.txt:
  • platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-4-expected.txt:
  • platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-5-expected.txt:
  • platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-6-expected.txt:
  • platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-7-expected.txt:
  • platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-8-expected.txt:
  • platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-9-expected.txt:
  • platform/gtk/fast/html/details-no-summary1-expected.txt:
  • platform/gtk/fast/html/details-no-summary2-expected.txt:
  • platform/gtk/fast/html/details-no-summary3-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open1-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open3-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/html/details-open5-expected.txt:
  • platform/gtk/fast/html/details-open6-expected.txt:
  • platform/gtk/fast/html/details-position-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-1-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-2-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-3-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-4-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-5-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-6-expected.txt:
  • platform/gtk/fast/html/details-writing-mode-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
1:44 PM Changeset in webkit [84676] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-04-22 Eric Seidel <​eric@webkit.org>

Reviewed by Dimitri Glazkov.

webkit-patch rebaseline is broken
​https://bugs.webkit.org/show_bug.cgi?id=59207

My recent changes to how LayoutTestResults.results_from_string
uncovered a bug in our use of urllib2.
We now are treating the return value from _fetch_results_html()
(which returns urllib2.openurl()) as a string. That's incorrect,
the return value is a file-like object (which auto-converts to a
string in most cases).

I've updated our urllib2-using code to correctly call .read() on the
resulting object before treating it like a string.
Unfortunately there is no easy way to test this mis-understanding
of the openurl() semantics.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
1:38 PM Changeset in webkit [84675] by barraclough@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Bug 59222 - DFG JIT - don't allocate virtual registers to nodes with no result

Reviewed by Sam Weinig.

We currently allocate virtual registers to nodes which have no result - these are
clearly unused, and may result in us allocating a larger than necessary stack frame.

Encapsulate Node::virtualRegister such that we can ASSERT this is only called on
nodes that have results, and improve the quality of output from the consistency check.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::canReuse):
(JSC::DFG::JITCodeGenerator::isFilled):
(JSC::DFG::JITCodeGenerator::isFilledDouble):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::integerResult):
(JSC::DFG::JITCodeGenerator::noResult):
(JSC::DFG::JITCodeGenerator::cellResult):
(JSC::DFG::JITCodeGenerator::jsValueResult):
(JSC::DFG::JITCodeGenerator::doubleResult):
(JSC::DFG::JITCodeGenerator::initConstantInfo):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::virtualRegister):
(JSC::DFG::Node::setVirtualRegister):
(JSC::DFG::Node::refCount):
(JSC::DFG::Node::ref):
(JSC::DFG::Node::deref):
(JSC::DFG::Node::adjustedRefCount):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

1:30 PM Changeset in webkit [84674] by tony@chromium.org
  • 4 edits in trunk/LayoutTests

2011-04-22 Tony Chang <​tony@chromium.org>

Landing new baselines for plugins/embedded-attributes-style.html after
border changes (r84273).

​https://bugs.webkit.org/show_bug.cgi?id=59068

  • platform/chromium-linux/plugins/embed-attributes-style-expected.png:
  • platform/chromium-win/plugins/embed-attributes-style-expected.png:
  • platform/chromium/test_expectations.txt:
1:28 PM Changeset in webkit [84673] by Csaba Osztrogonác
  • 46 edits in trunk/LayoutTests

[Qt] Update expected files after r84632.

  • platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-1-expected.txt:
  • platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-10-expected.txt:
  • platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-2-expected.txt:
  • platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-3-expected.txt:
  • platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-4-expected.txt:
  • platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-5-expected.txt:
  • platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-6-expected.txt:
  • platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-7-expected.txt:
  • platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-8-expected.txt:
  • platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-9-expected.txt:
  • platform/qt/fast/html/details-no-summary1-expected.txt:
  • platform/qt/fast/html/details-no-summary2-expected.txt:
  • platform/qt/fast/html/details-no-summary3-expected.txt:
  • platform/qt/fast/html/details-no-summary4-expected.txt:
  • platform/qt/fast/html/details-open-javascript-expected.txt:
  • platform/qt/fast/html/details-open1-expected.txt:
  • platform/qt/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-open3-expected.txt:
  • platform/qt/fast/html/details-open4-expected.txt:
  • platform/qt/fast/html/details-open5-expected.txt:
  • platform/qt/fast/html/details-open6-expected.txt:
  • platform/qt/fast/html/details-position-expected.txt:
  • platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-1-expected.txt:
  • platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-2-expected.txt:
  • platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-3-expected.txt:
  • platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-4-expected.txt:
  • platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-5-expected.txt:
  • platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-6-expected.txt:
  • platform/qt/fast/html/details-writing-mode-expected.txt:
1:27 PM Changeset in webkit [84672] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-04-22 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Make showTree/showTreeForThis aware of the shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=52965

No new tests, because this code is only compiled in DEBUG.

  • dom/Node.cpp: (WebCore::traverseTreeAndMark): Moved tree traversal logic here, adding

recursive sub-traversal of the shadow tree.

(WebCore::Node::showTreeAndMark): Changed to use the new tree traversal function.

1:11 PM Changeset in webkit [84671] by kerz@chromium.org
  • 15 edits in branches/chromium/742/Source/WebCore

Merge 84582 - 2011-04-21 Vangelis Kokkevis <​vangelis@chromium.org> Reviewed by James Robinson. [chromium] Only update the contents of layers that are going to be drawn. Remove individual texture unreserves that happen after the layer draw calls with a single unreserve for all the textures in the texture manager. ​https://bugs.webkit.org/show_bug.cgi?id=59129 Tests: No new functionality. Covered by existing layout tests. * platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw): * platform/graphics/chromium/ContentLayerChromium.h: * platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::paintLayerContents): * platform/graphics/chromium/LayerRendererChromium.h: * platform/graphics/chromium/LayerTexture.cpp: * platform/graphics/chromium/LayerTexture.h: * platform/graphics/chromium/LayerTilerChromium.cpp: * platform/graphics/chromium/LayerTilerChromium.h: * platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawSurface): * platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::unprotectAllTextures): * platform/graphics/chromium/TextureManager.h: * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw): * platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::owner):
TBR=​vangelis@chromium.org

1:11 PM Changeset in webkit [84670] by weinig@apple.com
  • 12 edits
    1 delete in trunk

2011-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough and Oliver Hunt.

Arrays should participate in global object forwarding fun
​https://bugs.webkit.org/show_bug.cgi?id=59215

  • Update results of prototype-inheritance-2 for new array behavior.
  • Remove checks for primitives, since they were incorrect.
  • Force function check to check a function not on a primitive (this wasn't happening by itself, since functions normally aren't enumerable in the DOM).
  • Add exception to the test to not try and test HTMLProgressElement, since it is not available on all platforms. This allows us to remove the windows specific results.
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/script-tests/prototype-inheritance-2.js: (constructorNamesForWindow): (crawl):
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt: Removed.

2011-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough and Oliver Hunt.

Arrays should participate in global object forwarding fun
​https://bugs.webkit.org/show_bug.cgi?id=59215

  • runtime/JSGlobalObject.h: (JSC::constructEmptyArray): (JSC::constructArray): Add variants of constructArray that take a global object.

2011-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough and Oliver Hunt.

Arrays should participate in global object forwarding fun
​https://bugs.webkit.org/show_bug.cgi?id=59215

Change callers of constructArray to use the new variant that takes
a global object.

  • bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::types):
  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profiles):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain):
  • bindings/js/JSMessageEventCustom.cpp: (WebCore::JSMessageEvent::ports):
  • bindings/js/JSScriptProfileNodeCustom.cpp: (WebCore::JSScriptProfileNode::children):
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::toJS): (WebCore::JSWebGLRenderingContext::getAttachedShaders): (WebCore::JSWebGLRenderingContext::getSupportedExtensions):
1:05 PM Changeset in webkit [84669] by kerz@chromium.org
  • 3 edits in branches/chromium/742/Source/WebKit/chromium

Merge 84427 - 2011-04-20 Yuzhu Shen <​yzshen@chromium.org> Reviewed by Tony Chang. [chromium] linux chromium doesn't set click count for mouse up events. ​https://bugs.webkit.org/show_bug.cgi?id=58921 The reason why we need such a fix is that the Pepper API passes this information to plugins, and some consumers (e.g., Flash) need it to detect double-clicks. * src/gtk/WebInputEventFactory.cpp: set click count for mouse up events.
TBR=​commit-queue@webkit.org

1:03 PM Changeset in webkit [84668] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed typo fix after r84522.

  • WebCore.pro:
1:01 PM Changeset in webkit [84667] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-22 Daniel Bates <​dbates@rim.com>

Fix misspelled word in comment; tagets => targets.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
1:01 PM Changeset in webkit [84666] by kerz@chromium.org
  • 3 edits
    2 copies in branches/chromium/742

Merge 84604 - ​https://bugs.webkit.org/show_bug.cgi?id=57898REGRESSION (r82185): Scroll position not restored on navigation back to a page in the page cache-and corresponding-<rdar://problem/9226652>Reviewed by Dan Bernstein.Source/WebCore: The original fix for this change broke scroll-position restore for pages that are *not* in the page cache. This patch fixes both cached and non-cached pages by using the cachedScrollPosition() only for cached pages.* loader/HistoryController.cpp:(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):LayoutTests: * fast/loader/scroll-position-restored-on-back-non-cached-expected.txt: Added.* fast/loader/scroll-position-restored-on-back-non-cached.html: Added.
TBR=Beth Dakin

12:57 PM Changeset in webkit [84665] by ggaren@apple.com
  • 27 edits
    1 add in trunk

2011-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed a use of markDOMObjectWrapper: Element and Document
​https://bugs.webkit.org/show_bug.cgi?id=59178

  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp: Build!
  • bindings/js/JSDOMImplementationCustom.cpp: (WebCore::JSDOMImplementationOwner::isReachableFromOpaqueRoots): (WebCore::JSDOMImplementationOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Use the opaque roots system for DOMImplementation. Also, DOMImplementation does not need to keep its document wrapper alive, since there's no DOM API for getting a DOMImplementation's document.
  • bindings/js/JSDOMStringMapCustom.cpp: (WebCore::JSDOMStringMapOwner::isReachableFromOpaqueRoots): (WebCore::JSDOMStringMapOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Use the opaque roots system for DOMStringMap.
  • bindings/js/JSDOMTokenListCustom.cpp: Added. (WebCore::JSDOMTokenListOwner::isReachableFromOpaqueRoots): (WebCore::JSDOMTokenListOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Use the opaque roots system for DOMTokenList.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::visitChildren):
  • bindings/js/JSElementCustom.cpp: No more need for explicit marking.
  • bindings/scripts/CodeGeneratorV8.pm: Boo on whoever made this design decision.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::DOMImplementation): (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
  • dom/DOMImplementation.h: (WebCore::DOMImplementation::create): (WebCore::DOMImplementation::ref): (WebCore::DOMImplementation::deref): (WebCore::DOMImplementation::document): Fixed the DOMImplementation ownership model to match other satellite objects in the DOM. This was necessary to fix some crashes due to incorrect reference counting.
  • dom/DOMImplementation.idl:
  • dom/DOMStringMap.idl:
  • dom/Document.cpp: (WebCore::Document::~Document):
  • dom/Document.h:
  • dom/Element.cpp:
  • dom/Element.h:
  • dom/Element.idl:
  • html/DOMTokenList.idl: Updated to match changes above.

2011-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed a use of markDOMObjectWrapper: Element and Document
​https://bugs.webkit.org/show_bug.cgi?id=59178

  • fast/dom/dataset-gc-expected.txt:
  • fast/dom/script-tests/dataset-gc.js: Changed this test not to be specific to proto. We have a general bug in the DOM that assignment to proto does not persist after garbage collection. While we should fix that bug, we don't want existing tests to tickle it, because it makes them flaky.
12:54 PM Changeset in webkit [84664] by Simon Fraser
  • 3 edits
    3 adds in trunk

2011-04-22 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Rounded corners don't looks smooth when background-image is a gradient
​https://bugs.webkit.org/show_bug.cgi?id=59213

Add the "shrink background" behavior to the slow background
drawing code path.

Test: fast/backgrounds/gradient-background-leakage.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::backgroundRectAdjustedForBleedAvoidance): Utility function that returns a shrunk border rect based on the context scale. (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use backgroundRectAdjustedForBleedAvoidance() in both the fast and slow paths.
12:49 PM Changeset in webkit [84663] by commit-queue@webkit.org
  • 6 edits
    13 adds in trunk/LayoutTests

2011-04-22 Mike Reed <​reed@google.com>

Reviewed by Eric Seidel.

Update expected images with new shadow code
[chromium, win] Multiple failures of shadow rendering layout tests
​https://bugs.webkit.org/show_bug.cgi?id=58772

  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Added.
  • platform/chromium-win-xp/fast/text/shadow-translucent-fill-expected.png: Added.
  • platform/chromium-win-xp/fast/transforms: Added.
  • platform/chromium-win-xp/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-win-xp/svg/css: Added.
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
  • platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Added.
  • platform/chromium-win-xp/transitions: Added.
  • platform/chromium-win-xp/transitions/svg-text-shadow-transition-expected.png: Added.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.png:
  • platform/chromium/test_expectations.txt:
12:46 PM Changeset in webkit [84662] by kerz@chromium.org
  • 3 edits
    2 copies in branches/chromium/742

Merge 84440 - 2011-04-20 Dimitri Glazkov <Dimitri Glazkov> Reviewed by Kent Tamura. REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element. ​https://bugs.webkit.org/show_bug.cgi?id=59037 * fast/events/simulated-click-disabled-expected.txt: Added. * fast/events/simulated-click-disabled.html: Added.2011-04-20 Dimitri Glazkov <Dimitri Glazkov> Reviewed by Kent Tamura. REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element. ​https://bugs.webkit.org/show_bug.cgi?id=59037 Test: fast/events/simulated-click-disabled.html * dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchSimulatedClick): Added check for disabled element.
TBR=Dimitri Glazkov

12:31 PM Changeset in webkit [84661] by kerz@chromium.org
  • 4 edits
    8 copies in branches/chromium/696

Merge 84655 - 2011-04-22 Levi Weintraub <​leviw@chromium.org> Reviewed by Darin Fisher. REGRESSION: left property broken with position:fixed elements in RTL documents ​https://bugs.webkit.org/show_bug.cgi?id=59204 ​http://code.google.com/p/chromium/issues/detail?id=80216 Test: fast/block/positioning/rtl-fixed-positioning.html fast/block/positioning/vertical-rl/fixed-positioning.html Returning the proper scroll offsets for fixed position content in RTL documents. We regressed to X and Y offsets not updating while scrolling when we clamped to zero, but RTL documents scroll in negative space. * page/FrameView.cpp: (WebCore::FrameView::scrollXForFixedPosition): Properly handling RTL documents where the scroll origin and offsets are negative. (WebCore::FrameView::scrollYForFixedPosition): Properly handling vertical writing- mode RTL documents, like above. * platform/ScrollView.h: (WebCore::ScrollView::scrollOrigin): Changing this accessor to const.2011-04-22 Levi Weintraub <​leviw@chromium.org> Reviewed by Darin Fisher. REGRESSION: left property broken with position:fixed elements in RTL documents ​https://bugs.webkit.org/show_bug.cgi?id=59204 ​http://code.google.com/p/chromium/issues/detail?id=80216 Test to ensure position:fixed works properly in RTL documents. * fast/block/positioning/rtl-fixed-positioning.html: Added. * fast/block/positioning/vertical-rl/fixed-positioning.html: Added. * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added. * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.png: Added. * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added. * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added. * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added. * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
TBR=​leviw@chromium.org

12:26 PM Changeset in webkit [84660] by commit-queue@webkit.org
  • 16 edits in trunk/Source/JavaScriptCore

2011-04-22 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84650 and r84654.
​http://trac.webkit.org/changeset/84650
​http://trac.webkit.org/changeset/84654
​https://bugs.webkit.org/show_bug.cgi?id=59218

Broke Windows build (Requested by bweinstein on #webkit).

  • API/JSCallbackObjectFunctions.h: (JSC::::init):
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • heap/Handle.h: (JSC::HandleBase::operator!): (JSC::HandleBase::operator UnspecifiedBoolType*): (JSC::HandleTypes::getFromSlot):
  • heap/HandleHeap.cpp: (JSC::HandleHeap::markStrongHandles): (JSC::HandleHeap::markWeakHandles): (JSC::HandleHeap::finalizeWeakHandles): (JSC::HandleHeap::writeBarrier): (JSC::HandleHeap::protectedGlobalObjectCount): (JSC::HandleHeap::isValidWeakNode):
  • heap/HandleHeap.h: (JSC::HandleHeap::copyWeak): (JSC::HandleHeap::makeWeak): (JSC::HandleHeap::Node::slot):
  • heap/HandleStack.cpp: (JSC::HandleStack::mark): (JSC::HandleStack::grow):
  • heap/HandleStack.h: (JSC::HandleStack::zapTo): (JSC::HandleStack::push):
  • heap/Heap.cpp: (JSC::HandleHeap::protectedObjectTypeCounts):
  • heap/Local.h: (JSC::::set):
  • heap/Strong.h: (JSC::Strong::set):
  • heap/Weak.h: (JSC::Weak::set):
  • runtime/StructureTransitionTable.h: (JSC::StructureTransitionTable::singleTransition): (JSC::StructureTransitionTable::setSingleTransition):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::add): (JSC::WeakGCMap::set):
  • runtime/WriteBarrier.h:
12:25 PM Changeset in webkit [84659] by xji@chromium.org
  • 3 edits
    3 adds in trunk

2011-04-22 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Local caret rectangle calculation should be relative to its containing block.
​https://bugs.webkit.org/show_bug.cgi?id=49508.

  • fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
  • fast/forms/cursor-at-editable-content-boundary.html: Added.
  • platform/mac/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.

2011-04-22 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Local caret rectangle calculation should be relative to its containing block.
​https://bugs.webkit.org/show_bug.cgi?id=49508.

InlineBox and caret rectangle are positioned relative to its containing block.
So its left and right edge value should be relative to its containing block as well.

Test: fast/forms/cursor-at-editable-content-boundary.html

  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
12:25 PM Changeset in webkit [84658] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

2011-04-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor PatchAnalysis task out of CommitQueueTask
​https://bugs.webkit.org/show_bug.cgi?id=59220

This is a first step towards teaching the EWS to run tests.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py: Added.
12:18 PM April 2011 Meeting edited by eric@webkit.org
(diff)
12:17 PM April 2011 Meeting edited by eric@webkit.org
(diff)
12:08 PM Changeset in webkit [84657] by rolandsteiner@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

2011-04-22 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed: update Chromium baselines.

  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/feDropShadow-expected.png: Added.
11:59 AM Changeset in webkit [84656] by tony@chromium.org
  • 1 edit
    4910 deletes in trunk/LayoutTests

2011-04-22 Tony Chang <​tony@chromium.org>

Unreviewed, deleting remaining .checksum files.
More will probably creep in over the next few days-- I'll do
another pass in a week or so.

11:56 AM April 2011 Meeting edited by levin@chromium.org
(diff)
11:53 AM Changeset in webkit [84655] by leviw@chromium.org
  • 4 edits
    8 adds in trunk

2011-04-22 Levi Weintraub <​leviw@chromium.org>

Reviewed by Darin Fisher.

REGRESSION: left property broken with position:fixed elements in RTL documents
​https://bugs.webkit.org/show_bug.cgi?id=59204
​http://code.google.com/p/chromium/issues/detail?id=80216

Test: fast/block/positioning/rtl-fixed-positioning.html

fast/block/positioning/vertical-rl/fixed-positioning.html

Returning the proper scroll offsets for fixed position content in RTL documents.
We regressed to X and Y offsets not updating while scrolling when we clamped to zero,
but RTL documents scroll in negative space.

  • page/FrameView.cpp: (WebCore::FrameView::scrollXForFixedPosition): Properly handling RTL documents where the scroll origin and offsets are negative. (WebCore::FrameView::scrollYForFixedPosition): Properly handling vertical writing- mode RTL documents, like above.
  • platform/ScrollView.h: (WebCore::ScrollView::scrollOrigin): Changing this accessor to const.

2011-04-22 Levi Weintraub <​leviw@chromium.org>

Reviewed by Darin Fisher.

REGRESSION: left property broken with position:fixed elements in RTL documents
​https://bugs.webkit.org/show_bug.cgi?id=59204
​http://code.google.com/p/chromium/issues/detail?id=80216

Test to ensure position:fixed works properly in RTL documents.

  • fast/block/positioning/rtl-fixed-positioning.html: Added.
  • fast/block/positioning/vertical-rl/fixed-positioning.html: Added.
  • platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added.
  • platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
  • platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
11:52 AM Changeset in webkit [84654] by bweinstein@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Part of Windows build fix from r84650.

11:51 AM Changeset in webkit [84653] by jschuh@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-22 Justin Schuh <​jschuh@chromium.org>

Reviewed by Eric Seidel.

Should assert on invalid type in FEComponentTransfer::apply
​https://bugs.webkit.org/show_bug.cgi?id=57959

No functional change. No new tests needed.

  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
11:43 AM Changeset in webkit [84652] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-22 MORITA Hajime <​morrita@google.com>

Unreviewed crash fix.

  • html/HTMLDetailsElement.cpp: (WebCore::DetailsSummaryElement::shouldInclude):
11:36 AM Changeset in webkit [84651] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-22 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed: Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
11:26 AM Changeset in webkit [84650] by oliver@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

2011-04-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make it harder to use HandleSlot incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=59205

Just add a little type fudging to make it harder to
incorrectly assign through a HandleSlot.

  • API/JSCallbackObjectFunctions.h: (JSC::::init):
  • JavaScriptCore.exp:
  • heap/Handle.h: (JSC::HandleBase::operator!): (JSC::HandleBase::operator UnspecifiedBoolType*): (JSC::HandleTypes::getFromSlot):
  • heap/HandleHeap.cpp: (JSC::HandleHeap::markStrongHandles): (JSC::HandleHeap::markWeakHandles): (JSC::HandleHeap::finalizeWeakHandles): (JSC::HandleHeap::writeBarrier): (JSC::HandleHeap::protectedGlobalObjectCount): (JSC::HandleHeap::isValidWeakNode):
  • heap/HandleHeap.h: (JSC::HandleHeap::copyWeak): (JSC::HandleHeap::makeWeak): (JSC::HandleHeap::Node::slot):
  • heap/HandleStack.cpp: (JSC::HandleStack::mark): (JSC::HandleStack::grow):
  • heap/HandleStack.h: (JSC::HandleStack::zapTo): (JSC::HandleStack::push):
  • heap/Heap.cpp: (JSC::HandleHeap::protectedObjectTypeCounts):
  • heap/Local.h: (JSC::::set):
  • heap/Strong.h: (JSC::Strong::set):
  • heap/Weak.h: (JSC::Weak::set):
  • runtime/StructureTransitionTable.h: (JSC::StructureTransitionTable::singleTransition): (JSC::StructureTransitionTable::setSingleTransition):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::add): (JSC::WeakGCMap::set):
  • runtime/WriteBarrier.h: (JSC::OpaqueJSValue::toJSValue): (JSC::OpaqueJSValue::toJSValueRef): (JSC::OpaqueJSValue::fromJSValue):
11:13 AM Changeset in webkit [84649] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Exclude scrollbars from the dirty rect passed to the document
​https://bugs.webkit.org/show_bug.cgi?id=59206

Reviewed by Sam Weinig.

No test added because functionality is unchanged.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paint): Compute a clip rectangle (analogous to the frame of the clip view
in an NSScrollView) by subtracting non-overlay scrollbars, and intersect the document dirty rect
with it. If the result is empty, avoid calling paintContents().

11:03 AM Changeset in webkit [84648] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-04-22 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Allow MediaPlayerPrivateAVFoundation to be disabled via a preference.
​https://bugs.webkit.org/show_bug.cgi?id=59179

Add API to allow the WebCore Settings preference to be called from the UIProcess.

  • Shared/WebPreferencesStore.h: Added new preference definition macro.
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetAVFoundationEnabled): Added. (WKPreferencesGetAVFoundationEnabled): Added.
  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Pass new preference along to WebCore

Settings.

11:00 AM Changeset in webkit [84647] by tony@chromium.org
  • 1 edit
    6435 deletes in trunk/LayoutTests

2011-04-22 Tony Chang <​tony@chromium.org>

Unreviewed, deleting .checksum files in platform/mac.

10:51 AM Changeset in webkit [84646] by jer.noble@apple.com
  • 10 edits in trunk/Source

2011-04-22 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=59147

Add a new isAVFoundationEnabled setting and check it before adding
MediaPlayerPrivateAVFoundationObjC to the media engine registry.

  • WebCore.exp.in:
  • page/Settings.cpp:
  • page/Settings.h: (WebCore::Settings::setAVFoundationEnabled): Added. (WebCore::Settings::isAVFoundationEnabled): Added.
  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): Check the settings added above.

2011-04-22 Jer Noble <​jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=59147

Add a new user default preference, and plumb that preference down to WebCore
Settings. Allow the fullScreenEnabled preference to override the new
isAVFoundationEnabled preference, so that clients of the legacy full screen
mode will continue to use that mode normally.

  • WebView/WebPreferenceKeysPrivate.h: Add new preference key.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Set the default value of new

preference.

(-[WebPreferences setAVFoundationEnabled:]): Added.
(-[WebPreferences isAVFoundationEnabled]): Added.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChanged:]): Update the WebCore settings with the

new values from WebPreferences.

10:49 AM Changeset in webkit [84645] by ap@apple.com
  • 3 edits in trunk

Reviewed by Ojan Vafai. Bugzilla JavaScript changes by Adam Barth.

Bugzilla autocomplete should support frequent contributors who are not committers
​https://bugs.webkit.org/show_bug.cgi?id=59209

10:49 AM Changeset in webkit [84644] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/qt

Fix qt build.

  • Api/qwebelement.cpp:

(setupScriptContext):

10:47 AM Changeset in webkit [84643] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: Stop Responsiveness Timer when WebPageProxy closes or WebProcess crashes
​https://bugs.webkit.org/show_bug.cgi?id=59210

Reviewed by Sam Weinig.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Stop the responsiveness timer.
(WebKit::WebPageProxy::processDidCrash): Ditto.

10:40 AM Changeset in webkit [84642] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Fix windows test result.

  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
10:37 AM Changeset in webkit [84641] by weinig@apple.com
  • 25 edits in trunk

2011-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough.

Remove remaining uses of deprecated version of toJS
​https://bugs.webkit.org/show_bug.cgi?id=59170

  • fast/dom/prototype-inheritance-2-expected.txt: Add new passing results since we now use the correct global object. The remaining failures are pure JS objects (Array, Boolean, String, Number, Function).

2011-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough.

Remove remaining uses of deprecated version of toJS
​https://bugs.webkit.org/show_bug.cgi?id=59170

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shadowRoot): (DumpRenderTreeSupportGtk::ensureShadowRoot): Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.

2011-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough.

Remove remaining uses of deprecated version of toJS
​https://bugs.webkit.org/show_bug.cgi?id=59170

  • DOM/WebDOMOperations.mm: (-[DOMElement _shadowRoot:]): (-[DOMElement _ensureShadowRoot:]): Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.

2011-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough.

Remove remaining uses of deprecated version of toJS
​https://bugs.webkit.org/show_bug.cgi?id=59170

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toJS): (WebCore::JSCanvasRenderingContext2D::strokeStyle): (WebCore::JSCanvasRenderingContext2D::fillStyle): (WebCore::JSCanvasRenderingContext2D::createPattern):
  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profiles):
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMMimeTypeArrayCustom.cpp: (WebCore::JSDOMMimeTypeArray::nameGetter):
  • bindings/js/JSDOMPluginArrayCustom.cpp: (WebCore::JSDOMPluginArray::nameGetter):
  • bindings/js/JSDOMPluginCustom.cpp: (WebCore::JSDOMPlugin::nameGetter):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::namedItemGetter): (WebCore::JSDOMWindow::event):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/js/JSInjectedScriptHostCustom.cpp: Propagate stored global object down access chain.

(WebCore::InjectedScriptHost::nodeAsScriptValue):
Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.

(WebCore::JSInjectedScriptHost::currentCallFrame):
(WebCore::JSInjectedScriptHost::inspectedNode):

  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::nameGetter):
  • bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList): (WebCore::JSNodeList::nameGetter):
  • bindings/js/JSScriptProfileNodeCustom.cpp: (WebCore::JSScriptProfileNode::children):
  • bindings/js/JSStyleSheetListCustom.cpp: (WebCore::JSStyleSheetList::nameGetter):
  • bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument):
  • bindings/scripts/CodeGeneratorJS.pm: Propagate stored global object down access chain.
  • css/MediaQueryListListener.cpp: (WebCore::MediaQueryListListener::queryChanged): Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype, we will want refactor this to match other callbacks so we can remove this.
10:25 AM Changeset in webkit [84640] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-22 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Eric Seidel.

[Chromium]Mac UI polish to add left/right padding space for autofill popup window.
​https://bugs.webkit.org/show_bug.cgi?id=58960
​http://code.google.com/p/chromium/issues/detail?id=51077

No new test because Chromium Autofill popup window doesn't have any test framework.
This assumes only AutofillPopupMenuClient gives TexFieldPart appearance.
Only if Autofill popup window has right/left padding.
The code should be removed after Autofill popup window logic is separated from WebKit to Chromium.

  • rendering/RenderThemeChromiumMac.h: Add popupInternalPaddingRight() and popupInternalPaddingLeft().
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft): Return padding size only if TextFieldPart is specified. (WebCore::RenderThemeChromiumMac::popupInternalPaddingRight): Return padding size only if TextFieldPart is specified.
9:51 AM Changeset in webkit [84639] by tony@chromium.org
  • 1 edit
    8383 deletes in trunk/LayoutTests

2011-04-22 Tony Chang <​tony@chromium.org>

Unreviewed, deleting .checksum files in platform/gtk and platform/qt*.

9:48 AM Changeset in webkit [84638] by Adam Roben
  • 6 edits in trunk/Source/WebKit2

Give windowless plugins' context menus an owner window in the same thread as the plugin

In some cases, plugins pass the WKView's HWND to the ::TrackPopupMenu API. ::TrackPopupMenu
fails in this case because the WKView's HWND is owned by another process/thread. We work
around this by hooking the ::TrackPopupMenu API and providing our own window that's in the
same thread as the plugin instead.

I couldn't figure out how to write a test for this. :-(

Fixes <​http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No context
menu appears when right-clicking on windowless Flash plugin

Reviewed by Brian Weinstein, and looked at suspiciously by Jeff Miller.

  • Platform/Module.h: Added installIATHook on Windows.
  • Platform/win/ModuleWin.cpp:

(WebKit::overwriteReadOnlyMemory): New helper function. Basically a wrapper around memcpy,
but uses ::VirtualProtect to allow writing to otherwise-read-only memory.
(WebKit::findFunctionPointerAddress): New helper function. The first overload iterates over
the imported modules and functions looking for the given one. If found, returns the address
of the function pointer that is used when calling that function. The second overload calls
the first, first passing it an enumerator for the image's imported modules, then passing it
an iterator for the image's delay-loaded modules.
(WebKit::Module::installIATHook): Added. Finds the address of the function pointer that's
used when code in this module calls the given function, then overwrites the function pointer
with the passed-in one. Future calls to the given function made by code in this module
should then end up calling to the passed-in function instead of the original one.

  • Shared/Plugins/Netscape/NetscapePluginModule.h:

(WebKit::NetscapePluginModule::module): Added this simple getter.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Added some new Windows-only members.
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::CurrentPluginSetter::CurrentPluginSetter):
(WebKit::CurrentPluginSetter::~CurrentPluginSetter):
This RAII class sets/unsets the currentPlugin global.

(WebKit::registerPluginView): Changed to use instanceHandle() instead of the mysterious
gInstance.
(WebKit::NetscapePlugin::platformPostInitialize): For windowless plugins, hook the
::TrackPopupMenu API and create a window to be used as the owner for context menus created
by this plugin. (Also changed the ::CreateWindowExW call for windowed plugins to pass an
instance handle so that the window will be associated with WebKit.dll instead of
WebKit2WebProcess.exe. This should have no visible effect, but is more correct.)
(WebKit::NetscapePlugin::platformDestroy): For windowless plugins, destroy the context menu
owner window we created above.

(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Set ourselves as the current plugin.

(WebKit::NetscapePlugin::hookedTrackPopupMenu): Added. This is the function that actually
gets called when windowless plugins call ::TrackPopupMenu. If the passed-in owner window is
owned by the current thread, we have nothing to do; ::TrackPopupMenu should work just fine.
Otherwise, we use the current plugin's context menu owner window as the context menu's
owner. We also set focus to the new owner window because otherwise weird behavior results
(e.g., it's possible to scroll the WKView while the context menu is up).

9:45 AM Changeset in webkit [84637] by Philippe Normand
  • 8 edits
    3 adds in trunk

2011-04-22 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT: implement eventSender.scalePageBy
​https://bugs.webkit.org/show_bug.cgi?id=59082

  • DumpRenderTree/gtk/EventSender.cpp: (scalePageByCallback): scalePageBy() support.

2011-04-22 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT: implement eventSender.scalePageBy
​https://bugs.webkit.org/show_bug.cgi?id=59082

Unskipped tests that should pass now that
eventSender.scalePageBy() is supported in GTK.

  • platform/gtk/Skipped:
  • platform/gtk/fast/repaint/scale-page-shrink-expected.checksum: Added.
  • platform/gtk/fast/repaint/scale-page-shrink-expected.png: Added.
  • platform/gtk/fast/repaint/scale-page-shrink-expected.txt: Added.

2011-04-22 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT: implement eventSender.scalePageBy
​https://bugs.webkit.org/show_bug.cgi?id=59082

Added support in DRT for webview scaling.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::scale):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
9:45 AM Changeset in webkit [84636] by Adam Roben
  • 2 edits
    9 adds in trunk/Source/WebCore

Add code to enumerate all the functions imported by a particular Windows binary

PEImage is where all the logic starts. It represents a single Portable Executable (PE)
binary. The various enumerator classes are used in conjunction with PEImage to enumerate the
modules and functions imported by that image.

I couldn't figure out how to write a test for this. :-(

Part of <​http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No
context menu appears when right-clicking on windowless Flash plugin

Reviewed by Sam Weinig, and given a good once-over by Jeff Miller.

  • WebCore.vcproj/WebCore.vcproj: Added the new files.
  • platform/win/PEImage.cpp: Added.

(WebCore::PEImage::PEImage): Checks that the module contains the expected magic numbers,
then initializes m_ntHeaders using the module.
(WebCore::PEImage::convertRVAToAddress): Converts a relative virtual address (RVA) to a
non-relative address, which can then be dereferenced. (The PE format uses RVAs in lots of
places.)
(WebCore::PEImage::dataDirectoryEntryAddress): Returns the address of the data associated
with the given entry in the image's DataDirectory.

  • platform/win/PEImage.h: Added.

(WebCore::PEImage::isValid): We're a valid image if the validation code in our constructor
succeeded, in which case m_ntHeaders will be set.

  • platform/win/ImportedFunctionsEnumerator.cpp: Added. This class enumerates all the

functions imported by the image from a single module by walking the Import Name Table (INT)
and Import Address Table (IAT).
(WebCore::ImportedFunctionsEnumerator::ImportedFunctionsEnumerator): Initialize our members.
(WebCore::ImportedFunctionsEnumerator::isAtEnd): The INT and IAT are both 0-terminated
arrays.
(WebCore::ImportedFunctionsEnumerator::next): Step to the next entries in the INT and IAT.
(WebCore::ImportedFunctionsEnumerator::currentFunctionName): Gets the address of the
function's name, if possible, using the INT.
(WebCore::ImportedFunctionsEnumerator::addressOfCurrentFunctionPointer): Returns the address
of the function pointer for the current function. This function pointer is used whenever
code in m_image calls the current function. (A future patch will take advantage of this by
overwriting this function pointer with another, thereby redirecting calls to that function.)

  • platform/win/ImportedFunctionsEnumerator.h: Added.
  • platform/win/ImportedModulesEnumeratorBase.h: Added. This base class is used by

ImportedModulesEnumerator and DelayLoadedModulesEnumerator, and allows code to be written
that works with either one.

  • platform/win/ImportedModulesEnumerator.cpp: Added. This class enumerates all the

non-delay-loaded modules imported by the image by walking the image's import array.
(WebCore::ImportedModulesEnumerator::ImportedModulesEnumerator): Module import information
is stored in the IMAGE_DIRECTORY_ENTRY_IMPORT entry of the image's DataDirectory.
(WebCore::ImportedModulesEnumerator::isAtEnd): The import array is 0-terminated.
(WebCore::ImportedModulesEnumerator::next): Steps along the import array.
(WebCore::ImportedModulesEnumerator::currentModuleName): Gets the address of the module's
name.
(WebCore::ImportedModulesEnumerator::functionsEnumerator): Get's the addresses of the INT
and IAT for this module and wraps them in an ImportedFunctionsEnumerator.

  • platform/win/ImportedModulesEnumerator.h: Added.
  • platform/win/DelayLoadedModulesEnumerator.cpp: Added. This class enumerates all the

delay-loaded modules that are imported by the given PEImage by walking the image's
ImageDelayDescr array.
(WebCore::DelayLoadedModulesEnumerator::DelayLoadedModulesEnumerator): Delay-load
information is stored in the IMAGE_DIRECTORY_ENTRY_DELAY_IMPORT entry of the image's
DataDirectory.
(WebCore::DelayLoadedModulesEnumerator::isAtEnd): The delay-loaded modules array is
0-terminated.
(WebCore::DelayLoadedModulesEnumerator::next): Steps along the delay-loaded modules array.
(WebCore::DelayLoadedModulesEnumerator::currentModuleName): Gets the address of the module's
name out of the descriptor.
(WebCore::DelayLoadedModulesEnumerator::functionsEnumerator): Gets the INT and IAT for the
current module out of the descriptor and makes an ImportedFunctionsEnumerator from them.
(WebCore::DelayLoadedModulesEnumerator::convertPotentialRVAToAddress): Pre-VC7.0 images
stored non-relative addresses in the ImageDelayDescr structures, while VC7.0 and later
images store RVAs. This function abstracts away the difference.

  • platform/win/DelayLoadedModulesEnumerator.h: Added.
9:44 AM Changeset in webkit [84635] by Adam Roben
  • 5 edits
    2 adds in trunk/Source

Add a shared do-nothing window class that anyone can use

Fixes <​http://webkit.org/b/59102> WebKit has too many dummy window classes

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj: Added DefWndProcWindowClass.{cpp,h}. Moved Arena.cpp out of

platform/win and into platform. Let VS reorder other files.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Changed to use the shared
dummy window class instead of creating our own.

  • platform/win/DefWndProcWindowClass.cpp: Added.

(WebCore::registerClass): Register it!
(WebCore::defWndProcWindowClassName): Register it and return it!

  • platform/win/DefWndProcWindowClass.h: Added.

Source/WebKit2:

Use WebCore's do-nothing window class instead of creating our own

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::createDummyWindow): Less code!

9:39 AM Changeset in webkit [84634] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-04-22 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Cannot play flash with NSPluginWrapper
​https://bugs.webkit.org/show_bug.cgi?id=59125

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Handle the case when we have been called with a null plugin instance.
9:25 AM Changeset in webkit [84633] by eric@webkit.org
  • 5 edits
    2 adds in trunk/Tools

2011-04-21 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

LayoutTestResults should know how to handle NRWT json files
​https://bugs.webkit.org/show_bug.cgi?id=59168

LayoutTestResults was originally created to be a parallel
to existing NRWT architecture for dealing with results files.
But then it turns out that NRWT has no such architecture. :(
So this patch writes the necessary code to handle reading
full_results.json and unexpected_results.json files from
NRWT layout-test-results directories.

LayoutTestResults has thus morphed from being ORWT-only to
supporting both ORWT and NRWT. It's possible at some future
point that other pieces of the NRWT architecture will learn
how to read JSON files in which case this can go away.

This is all done for making it possible for the commit-queue
to run the tests using NWRT and be able to understand the results
(for flaky test reporting, etc.)

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/common/net/resultsjsonparser.py: Added.
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: Added.
9:13 AM Changeset in webkit [84632] by morrita@google.com
  • 62 edits
    16 adds in trunk

2011-04-21 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

Content of <details> should be forwarded through the shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=59055

  • fast/html/details-add-child-1.html: Added.
  • fast/html/details-add-child-2.html: Added.
  • fast/html/details-remove-child-1.html: Added.
  • fast/html/details-remove-child-2.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/html/details-add-child-1-expected.checksum: Added.
  • platform/mac/fast/html/details-add-child-1-expected.png: Added.
  • platform/mac/fast/html/details-add-child-1-expected.txt: Added.
  • platform/mac/fast/html/details-add-child-2-expected.checksum: Added.
  • platform/mac/fast/html/details-add-child-2-expected.png: Added.
  • platform/mac/fast/html/details-add-child-2-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-expected.txt:
  • platform/mac/fast/html/details-add-summary-child-1-expected.txt:
  • platform/mac/fast/html/details-add-summary-child-2-expected.txt:
  • platform/mac/fast/html/details-no-summary1-expected.txt:
  • platform/mac/fast/html/details-no-summary2-expected.txt:
  • platform/mac/fast/html/details-no-summary3-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open1-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open3-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-open5-expected.txt:
  • platform/mac/fast/html/details-open6-expected.txt:
  • platform/mac/fast/html/details-position-expected.txt:
  • platform/mac/fast/html/details-remove-child-1-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-child-1-expected.png: Added.
  • platform/mac/fast/html/details-remove-child-1-expected.txt: Added.
  • platform/mac/fast/html/details-remove-child-2-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-child-2-expected.png: Added.
  • platform/mac/fast/html/details-remove-child-2-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-expected.txt:
  • platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/mac/fast/html/details-writing-mode-expected.txt:

2011-04-21 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

Content of <details> should be forwarded through the shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=59055

  • Made ShadowContentElement abstract and added shouldInclude() pure virtual method.
  • Added SummaryContentElement, DetailsContentElement, DetailsSummaryElement as subclasses of ShadowContentElement.
  • Gave two shadow children for HTMLDetailsElement. One is DetailsContentElement, that handles non-summary contents of <details>. Another is SummaryContentElement, that handles the main summary element.
  • Removed most of RenderDetails custom layout mechanism, which is replaced by ShadowContentElement subclasses.

Tests: fast/html/details-add-child-1.html

fast/html/details-add-child-2.html
fast/html/details-remove-child-1.html
fast/html/details-remove-child-2.html

  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::contentContainerFor): (WebCore::ShadowRoot::hostChildrenChanged): (WebCore::ShadowRoot::hasContentElement):
  • dom/ShadowRoot.h:
  • html/HTMLDetailsElement.cpp: (WebCore::DetailsContentElement::DetailsContentElement): (WebCore::DetailsContentElement::create): (WebCore::DetailsContentElement::shouldInclude): (WebCore::DetailsSummaryElement::DetailsSummaryElement): (WebCore::DetailsSummaryElement::create): (WebCore::DetailsSummaryElement::shouldInclude): (WebCore::HTMLDetailsElement::create): (WebCore::HTMLDetailsElement::HTMLDetailsElement): (WebCore::HTMLDetailsElement::ensureShadowSubtreeOf): (WebCore::findSummaryFor): (WebCore::HTMLDetailsElement::ensureMainSummary): (WebCore::HTMLDetailsElement::refreshMainSummary): (WebCore::HTMLDetailsElement::createShadowSubtree):
  • html/HTMLDetailsElement.h:
  • html/HTMLSummaryElement.cpp: (WebCore::SummaryContentElement::SummaryContentElement): (WebCore::SummaryContentElement::shouldInclude): (WebCore::SummaryContentElement::create): (WebCore::HTMLSummaryElement::createShadowSubtree):
  • html/shadow/ShadowContentElement.h:
  • rendering/RenderDetails.cpp: (WebCore::RenderDetails::RenderDetails): (WebCore::RenderDetails::addChild):
  • rendering/RenderDetails.h:
  • rendering/RenderSummary.cpp:
  • rendering/RenderSummary.h:
8:51 AM Changeset in webkit [84631] by Simon Fraser
  • 7 edits
    2 adds in trunk

2011-04-21 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Extra GraphicsContext::save() in InlineTextBox::paintDecoration()
​https://bugs.webkit.org/show_bug.cgi?id=59109

Remove an extraneous GraphicsContext::save() in InlineTextBox::paintDecoration().

Add an assertion that fires when a GraphicsContext() is destroyed with a non-
empty state stack. Fix canvas to avoid this assertion, since bad content might
trigger it.

Also add an assertion that fires for mismatched begin/endTransparencyLayers.

Test: fast/text/multiple-text-shadow-alpha.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::~HTMLCanvasElement): Make sure that the CanvasRenderingContext goes away before the ImageBuffer, so that CanvasRenderingContext2D has a chance to unwind the state stack in the ImageBuffer's GraphicsContext.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D): Balance unmatched state saves in the canvas context.
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::~GraphicsContext): Assert that the stack is empty.
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer): (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer): Changes to allow for asserting for unmatched transparency layer begin/ends.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration): Remove an unbalanced save().
8:39 AM Changeset in webkit [84630] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Windows DRT needs an implementation of shadowRoot.
​https://bugs.webkit.org/show_bug.cgi?id=59081

Add media/audio-controls-do-not-fade-out.html, which uses layoutTestController.shadowRoot
to the win Skipped list to get the bots green.

  • platform/win/Skipped:
8:34 AM Changeset in webkit [84629] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-04-22 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add Save As context menu item to the TextViewer.
​https://bugs.webkit.org/show_bug.cgi?id=59196

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceSourceFrame.prototype.requestContent): (WebInspector.ResourceSourceFrame.prototype.suggestedFileName): (WebInspector.RevisionSourceFrame.prototype.requestContent): (WebInspector.RevisionSourceFrame.prototype.suggestedFileName):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.SourceFrameDelegateForScriptsPanel): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._initializeTextViewer): (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu): (WebInspector.SourceFrame.prototype.suggestedFileName): (WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled): (WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._contextMenu): (WebInspector.TextViewerDelegate.prototype.cancelEditing): (WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu): (WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu): (WebInspector.TextViewerDelegate.prototype.suggestedFileName):
8:21 AM Changeset in webkit [84628] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Update the Windows-specific results after r84558.

  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
7:43 AM Changeset in webkit [84627] by yi.4.shen@nokia.com
  • 7 edits
    5 adds in trunk

2011-04-22 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Upstream Symbian platform plugin
​https://bugs.webkit.org/show_bug.cgi?id=58435

Upstream Symbian platform plugin.

  • Source/WebKit.pro: Add platformplugin path to the SUBDIRS.

2011-04-22 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Upstream Symbian platform plugin
​https://bugs.webkit.org/show_bug.cgi?id=58435

Upstream Symbian platform plugin.

  • QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
  • symbian/platformplugin: Added.
  • symbian/platformplugin/WebPlugin.cpp: Added. (ItemListDelegate::ItemListDelegate): (ItemListDelegate::paint): (Popup::Popup): (Popup::resizeEvent): (Popup::populateList): (Popup::onItemSelected): (Popup::updateSelectionsBeforeDialogClosing): (Popup::updateAndClose): (WebPopup::WebPopup): (WebPopup::~WebPopup): (WebPopup::createSingleSelectionPopup): (WebPopup::createMultipleSelectionPopup): (WebPopup::createPopup): (WebPopup::show): (WebPopup::hide): (WebPopup::popupClosed): (WebPopup::itemClicked): (SingleSelectionPopup::SingleSelectionPopup): (MultipleSelectionPopup::MultipleSelectionPopup): (WebNotificationPresenter::showNotification): (WebPlugin::supportsExtension): (WebPlugin::createExtension):
  • symbian/platformplugin/WebPlugin.h: Added. (Popup::preSelectedIndices): (Popup::listWidget): (WebNotificationPresenter::WebNotificationPresenter): (WebNotificationPresenter::~WebNotificationPresenter):
  • symbian/platformplugin/platformplugin.pro: Added.
  • symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h. (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData): (QWebNotificationPresenter::QWebNotificationPresenter): (QWebNotificationPresenter::~QWebNotificationPresenter): (QWebTouchModifier::~QWebTouchModifier): (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler): (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):

2011-04-22 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Upstream Symbian platform plugin
​https://bugs.webkit.org/show_bug.cgi?id=58435

Exempting directory WebKit/qt/symbian/platformplugin from style guide.

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
6:52 AM Changeset in webkit [84626] by mnaganov@chromium.org
  • 13 edits
    2 adds in trunk/Source

2011-04-22 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
​https://bugs.webkit.org/show_bug.cgi?id=59094

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • gyp/streamline-inspector-source.sh:
  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.dispose): (WebInspector.HeapSnapshotObjectNode.prototype._createProvider): (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider): (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotIteratorsTuple.prototype.dispose): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider): (MixInSnapshotNodeFunctions):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose): (WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource): (WebInspector.HeapSnapshotRetainingPathsList.prototype.dispose): (WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths): (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext): (WebInspector.HeapSnapshotRetainingPathsList.prototype.searchCancelled): (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder): (WebInspector.DetailedHeapshotView.prototype.dispose): (WebInspector.DetailedHeapshotView.prototype.get profileWrapper): (WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotLoader): (WebInspector.HeapSnapshotLoader.prototype.finishLoading): (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk): (WebInspector.HeapSnapshot.prototype.pushBaseIds): (WebInspector.HeapSnapshot.prototype.createDiff): (WebInspector.HeapSnapshot.prototype._parseFilter): (WebInspector.HeapSnapshot.prototype.createEdgesProvider): (WebInspector.HeapSnapshot.prototype.createNodesProvider): (WebInspector.HeapSnapshot.prototype.createPathFinder): (WebInspector.HeapSnapshot.prototype.updateStaticData): (WebInspector.HeapSnapshotPathFinder): (WebInspector.HeapSnapshotPathFinder.prototype.updateRoots): (WebInspector.HeapSnapshotPathFinder.prototype._reset):
  • inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotRealWorker): (WebInspector.HeapSnapshotRealWorker.prototype._messageReceived): (WebInspector.HeapSnapshotRealWorker.prototype.postMessage): (WebInspector.HeapSnapshotRealWorker.prototype.terminate): (WebInspector.HeapSnapshotFakeWorker): (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage): (WebInspector.HeapSnapshotFakeWorker.prototype.terminate): (WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker): (WebInspector.HeapSnapshotWorker): (WebInspector.HeapSnapshotWorker.prototype.createObject): (WebInspector.HeapSnapshotWorker.prototype.dispose): (WebInspector.HeapSnapshotWorker.prototype.disposeObject): (WebInspector.HeapSnapshotWorker.prototype.callGetter): (WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod.wrapCallback): (WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod): (WebInspector.HeapSnapshotWorker.prototype.callMethod): (WebInspector.HeapSnapshotWorker.prototype._findFunction): (WebInspector.HeapSnapshotWorker.prototype._messageReceived): (WebInspector.HeapSnapshotWorker.prototype._postMessage): (WebInspector.HeapSnapshotProxyObject): (WebInspector.HeapSnapshotProxyObject.prototype._callWorker): (WebInspector.HeapSnapshotProxyObject.prototype.dispose): (WebInspector.HeapSnapshotProxyObject.prototype.disposeWorker): (WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod): (WebInspector.HeapSnapshotProxyObject.prototype.callGetter): (WebInspector.HeapSnapshotProxyObject.prototype.callMethod): (WebInspector.HeapSnapshotLoaderProxy): (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.callLoadCallbacks): (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData): (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading): (WebInspector.HeapSnapshotLoaderProxy.prototype.get loaded): (WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading): (WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk): (WebInspector.HeapSnapshotProxy): (WebInspector.HeapSnapshotProxy.prototype.aggregates): (WebInspector.HeapSnapshotProxy.prototype.createDiff): (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider): (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider): (WebInspector.HeapSnapshotProxy.prototype.createPathFinder): (WebInspector.HeapSnapshotProxy.prototype.dispose): (WebInspector.HeapSnapshotProxy.prototype.finishLoading): (WebInspector.HeapSnapshotProxy.prototype.get loaded): (WebInspector.HeapSnapshotProxy.prototype.get nodeCount): (WebInspector.HeapSnapshotProxy.prototype.nodeFieldValuesByIndex): (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotProxy.prototype.get rootNodeIndex): (WebInspector.HeapSnapshotProxy.prototype.updateStaticData): (WebInspector.HeapSnapshotProxy.prototype.startLoading): (WebInspector.HeapSnapshotProxy.prototype.get totalSize): (WebInspector.HeapSnapshotProxy.prototype.get uid): (WebInspector.HeapSnapshotProviderProxy): (WebInspector.HeapSnapshotProviderProxy.prototype.isEmpty): (WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems): (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind): (WebInspector.HeapSnapshotPathFinderProxy): (WebInspector.HeapSnapshotPathFinderProxy.prototype.findNext): (WebInspector.HeapSnapshotPathFinderProxy.prototype.updateRoots): (WebInspector.HeapSnapshotsDiffProxy): (WebInspector.HeapSnapshotsDiffProxy.prototype.calculate): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
  • inspector/front-end/HeapSnapshotWorker.js: Added. (WebInspector.UIString): (postMessageWrapper):
  • inspector/front-end/HeapSnapshotWorkerDispatcher.js: Added. (WebInspector.HeapSnapshotWorkerDispatcher): (WebInspector.HeapSnapshotWorkerDispatcher.prototype._findFunction): (WebInspector.HeapSnapshotWorkerDispatcher.prototype.dispatchMessage):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

2011-04-22 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
​https://bugs.webkit.org/show_bug.cgi?id=59094

  • WebKit.gyp:
6:49 AM Changeset in webkit [84625] by podivilov@chromium.org
  • 12 edits
    2 moves in trunk

2011-04-22 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix de-obfuscation of scripts inlined in html.
​https://bugs.webkit.org/show_bug.cgi?id=58538

  • inspector/debugger/resources/obfuscated.js:
  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html: Renamed from LayoutTests/inspector/debugger/script-formatter.html-disabled.

2011-04-22 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix de-obfuscation of scripts inlined in html.
​https://bugs.webkit.org/show_bug.cgi?id=58538

Use html tokenizer to find script boundaries instead of relying on scriptParsed events.

Test: inspector/debugger/script-formatter.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/JavaScriptFormatter.js: Renamed from Source/WebCore/inspector/front-end/UglifyJS/JavaScriptFormatter.js.
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter): (WebInspector.ScriptFormatter.prototype.formatContent): (WebInspector.ScriptFormatter.prototype._didFormatContent):
  • inspector/front-end/ScriptFormatterWorker.js: (onmessage): (formatScript): (HTMLScriptFormatter): (HTMLScriptFormatter.prototype.format): (HTMLScriptFormatter.prototype.scriptStarted): (HTMLScriptFormatter.prototype.scriptEnded): (HTMLScriptFormatter.prototype.styleSheetStarted): (HTMLScriptFormatter.prototype.styleSheetEnded):
  • inspector/front-end/SourceFile.js: (WebInspector.FormattedSourceFile.prototype._didRequestContent):
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer.prototype.scriptStarted): (WebInspector.SourceHTMLTokenizer.prototype.scriptEnded): (WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted): (WebInspector.SourceHTMLTokenizer.prototype.styleSheetEnded): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/WebKit.qrc:
6:36 AM Changeset in webkit [84624] by caseq@chromium.org
  • 5 edits in trunk/Source

2011-04-22 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] misc API cleanup
​https://bugs.webkit.org/show_bug.cgi?id=59194

  • inspector/front-end/ExtensionAPISchema.json:
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane.prototype._setObject):

2011-04-22 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] misc API cleanup
​https://bugs.webkit.org/show_bug.cgi?id=59194

6:18 AM Changeset in webkit [84623] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-21 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: group content scripts in the scripts panel drop down.
​https://bugs.webkit.org/show_bug.cgi?id=59108

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
5:38 AM Changeset in webkit [84622] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-22 Mike West <​mkwst@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Tiny improvement to UI for adding an XHR breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=59100

Improve web inspector UI around adding XHR breakpoints by adding
a textual label to the input-like span used to specify which
XHR requests the breakpoint ought to target.

  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
  • inspector/front-end/inspector.css: (#breakpoint-condition-input):
5:35 AM Changeset in webkit [84621] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-22 Patrick Gansterer <Patrick Gansterer>

Unreviewed. Build fix for ENABLE(INTERPRETER) after r84556.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
5:34 AM Changeset in webkit [84620] by podivilov@chromium.org
  • 7 edits
    1 add
    1 delete in trunk/Source/WebCore

2011-04-22 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments.
​https://bugs.webkit.org/show_bug.cgi?id=59191

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent):
  • inspector/front-end/ScriptFormatterWorker.js: (onmessage):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceFile.prototype._loadResourceContent): (WebInspector.FormattedSourceFile.prototype._didRequestContent): (WebInspector.FormattedSourceMapping): (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine): (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation): (WebInspector.FormattedSourceMapping.prototype._convertPosition):
  • inspector/front-end/UglifyJS/JavaScriptFormatter.js: Added. (FormattedContentBuilder): Helper class for building formatted script content. (FormattedContentBuilder.prototype.addToken): (FormattedContentBuilder.prototype.addSpace): (FormattedContentBuilder.prototype.addNewLine): (FormattedContentBuilder.prototype.increaseNestingLevel): (FormattedContentBuilder.prototype.decreaseNestingLevel): (FormattedContentBuilder.prototype.content): (FormattedContentBuilder.prototype.mapping): (Tokenizer): Wrapper class for UglifyJS tokenizer. (Tokenizer.prototype.content): (Tokenizer.prototype.next): (Tokenizer.prototype._convertUglifyToken): (JavaScriptFormatter): New formatter based on UglifyJS tokenizer. (JavaScriptFormatter.prototype.format):
  • inspector/front-end/UglifyJS/process.js: Removed.
  • inspector/front-end/WebKit.qrc:
5:32 AM Changeset in webkit [84619] by mnaganov@chromium.org
  • 16 edits
    1 add in trunk

2011-04-22 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Refactor code prior to moving detailed heap snapshots into workers.
​https://bugs.webkit.org/show_bug.cgi?id=59189

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BinarySearch.js: Added.
  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype._populate.sorted): (WebInspector.HeapSnapshotGridNode.prototype._populate): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren): (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate): (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort): (WebInspector.HeapSnapshotGridNode.prototype.sort): (WebInspector.HeapSnapshotObjectNode): (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode): (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode): (WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData): (WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived): (WebInspector.HeapSnapshotDiffNode.prototype.get data):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort): (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged): (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting): (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter): (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave): (WebInspector.HeapSnapshotContainmentDataGrid): (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.setDataSource): (WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren): (WebInspector.HeapSnapshotDominatorsDataGrid): (WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource): (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged): (WebInspector.HeapSnapshotRetainingPathsList.prototype._performSorting): (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded): (WebInspector.DetailedHeapshotView.prototype._changeBase): (WebInspector.DetailedHeapshotView.prototype._changeView): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype.pushBaseNodeIds): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems): (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAndRewind): (WebInspector.HeapSnapshotEdgesProvider.prototype._serialize): (WebInspector.HeapSnapshotNodesProvider.prototype._serialize): (WebInspector.HeapSnapshotsDiff.prototype.calculate): (WebInspector.HeapSnapshotsDiff.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiff.prototype.pushBaseSelfSizes):
  • inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider): (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider): (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotProviderProxy): (WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems): (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
  • inspector/front-end/PleaseWaitMessage.js: (WebInspector.PleaseWaitMessage.prototype.showAndWaitFor): (WebInspector.PleaseWaitMessage.prototype.unlistenAndHide):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/utilities.js:

2011-04-22 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Refactor code prior to moving detailed heap snapshots into workers.
​https://bugs.webkit.org/show_bug.cgi?id=59189

  • inspector/profiler/detailed-heapshots-comparison-sorting.html:
  • inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest): (initialize_DetailedHeapshotTest.):
  • inspector/profiler/heap-snapshot-expected.txt:
  • inspector/profiler/heap-snapshot.html:
5:18 AM Changeset in webkit [84618] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-22 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed fix after r84484 -- conditional statement was inverted incorrectly.

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.handleShortcut):
5:10 AM Changeset in webkit [84617] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

2011-04-22 Csaba Osztrogonác <Csaba Osztrogonác>

[WK2] CSP reporting doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=59192

  • platform/mac-wk2/Skipped: Add http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html.
4:24 AM Changeset in webkit [84616] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt]fast/url/idna tests fail
​https://bugs.webkit.org/show_bug.cgi?id=59187

  • platform/qt/Skipped: Add fast/url/idna2003.html and fast/url/idna2008.html.
  • platform/qt/fast/url/path-expected.txt: Update after r84606.
3:39 AM Changeset in webkit [84615] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

2011-04-22 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] Qt should use the mac-wk2 skipped list
​https://bugs.webkit.org/show_bug.cgi?id=58536

  • Scripts/old-run-webkit-tests:
3:04 AM Changeset in webkit [84614] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-22 Annie Sullivan <​sullivan@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Timeline is too narrow
​https://bugs.webkit.org/show_bug.cgi?id=58399

Changed Network Panel widths so that Timeline is 50%.
Added titles to the values in the other columns, so that a tooltip will show the value if the column is too narrow.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable): Changed column widths. (WebInspector.NetworkPanel.prototype._toggleGridMode): Changed column widths. (WebInspector.NetworkDataGridNode.prototype.refreshResource): Added titles to column values. (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): Ditto (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell): Ditto (WebInspector.NetworkDataGridNode.prototype._refreshTimeCell): Ditto
  • inspector/front-end/utilities.js: (Element.prototype.setTextAndTitle): Added new method to set the textContent and title of an Element at the same time, so that it can have a tooltip.
2:34 AM Changeset in webkit [84613] by andreas.kling@nokia.com
  • 12 edits
    2 adds in trunk/Source/WebKit2

2011-04-22 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Sam Weinig.

[Qt][WK2] Implement DrawingAreaImpl for Qt.
​https://bugs.webkit.org/show_bug.cgi?id=59171

  • WebKit2.pro: Build files necessary for DrawingAreaImpl.
  • DerivedSources.pro: Build message receivers for DrawingArea and DrawingAreaProxy.
  • Shared/qt/LayerTreeContextQt.cpp: (WebKit::LayerTreeContext::LayerTreeContext): Stub. (WebKit::LayerTreeContext::~LayerTreeContext): Stub. (WebKit::LayerTreeContext::encode): Stub. (WebKit::LayerTreeContext::decode): Stub. (WebKit::LayerTreeContext::isEmpty): Stub. (WebKit::operator==): Stub.
  • Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::paint): Don't translate the painter to accomodate the source rect. The rect is already adjusted at the call site.
  • UIProcess/API/qt/qgraphicswkview.h: Add "Impl" to QGraphicsWKView::BackingStoreType.
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createDrawingAreaProxy): Create DrawingAreaProxyImpl if requested. (QWKPagePrivate::paint): Call the correct paint() method for DrawingAreaProxyImpl, since this drawing area will simple ASSERT_NOT_REACHED() in the "normal" paint().
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): Allow creation of DrawingAreaImpl for Qt.
  • UIProcess/BackingStore.h: Add Qt-specific types and backing store.
  • UIProcess/qt/BackingStoreQt.cpp: (WebKit::BackingStore::paint): Implemented. (WebKit::BackingStore::incorporateUpdate): Implemented. (WebKit::BackingStore::scroll): Implemented using QPixmap::scroll().
  • UIProcess/DrawingAreaProxy.h: Enable drawing area message receivers for Qt.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Ditto.
  • WebProcess/WebPage/DrawingArea.h: Ditto.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveMessage): Ditto.
2:10 AM Changeset in webkit [84612] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebKit2

WinCairo build fix. Unreviewed.

  • WebProcess/Downloads/curl/DownloadCurl.cpp:

(WebKit::Download::useCredential):
Stubbed.
(WebKit::Download::continueWithoutCredential):
Stubbed.
(WebKit::Download::cancelAuthenticationChallenge):
Stubbed.

1:31 AM Changeset in webkit [84611] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing audio-only media
​https://bugs.webkit.org/show_bug.cgi?id=59180

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: media/audio-controls-do-not-fade-out.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playbackProgressTimerFired): Only start fading out the controls if there is
a video track.

LayoutTests:

  • media/audio-controls-do-not-fade-out-expected.txt: Added.
  • media/audio-controls-do-not-fade-out.html: Added.
12:40 AM Changeset in webkit [84610] by jhoneycutt@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

Need to support authentication for downloads in WebKit2 on Windows
​https://bugs.webkit.org/show_bug.cgi?id=59175
<rdar://problem/9206151>
<rdar://problem/8958280>

Reviewed by Maciej Stachowiak.

  • WebProcess/Downloads/Download.cpp:

Include DownloadAuthenticationClient.h.

  • WebProcess/Downloads/Download.h:

Declare a function to get or create the authentication client, a member
var to hold it, and functions that the client can call to use a
credential, continue without a credential, or cancel an auth challenge.

  • WebProcess/Downloads/DownloadAuthenticationClient.cpp: Added.

(WebKit::DownloadAuthenticationClient::DownloadAuthenticationClient):
(WebKit::DownloadAuthenticationClient::receivedCredential):
Tell the Download to use the credential.
(WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
Tell the Download to continue with credentials.
(WebKit::DownloadAuthenticationClient::receivedCancellation):
Tell the Download to cancel the challenge.

  • WebProcess/Downloads/DownloadAuthenticationClient.h: Added.

(WebKit::DownloadAuthenticationClient::create):
Return a new DownloadAuthenticationClient.
(WebKit::DownloadAuthenticationClient::detach):
Clear the Download.
(WebKit::DownloadAuthenticationClient::refAuthenticationClient):
(WebKit::DownloadAuthenticationClient::derefAuthenticationClient):

  • WebProcess/Downloads/cfnet/DownloadCFNet.cpp:

(WebKit::Download::useCredential):
Create a CFURLCredentialRef from the WebCore credential, and tell
CFNetwork to use it for the auth challenge.
(WebKit::Download::continueWithoutCredential):
Call CFURLDownloadUseCredential with a null credential.
(WebKit::Download::cancelAuthenticationChallenge):
Cancel the download, and clear m_download.
(WebKit::Download::authenticationClient):
Create if needed and return a DownloadAuthenticationClient.
(WebKit::Download::platformInvalidate):
Detach the DownloadAuthenticationClient.
(WebKit::didReceiveAuthenticationChallengeCallback):
Call Download::didReceiveAuthenticationChallenge(), passing a
WebCore::AuthenticationChallenge with our DownloadAuthenticationClient.
(WebKit::Download::receivedCredential):
Get the client from the auth challenge, and call through to it.
(WebKit::Download::receivedRequestToContinueWithoutCredential):
Ditto.
(WebKit::Download::receivedCancellation):
Ditto.

  • win/WebKit2.vcproj:

Add new files to project.

12:40 AM Changeset in webkit [84609] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-22 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Add FontItalics and FontSmallCaps enums to be used instead of boolean values.
​https://bugs.webkit.org/show_bug.cgi?id=59080

No new tests as no new functionality added.

  • css/CSSPrimitiveValueMappings.h: Add casts to/from FontItalics and FontSmallCaps
  • css/CSSStyleSelector.cpp: Use new casts defined in PrimitiveValueMappings.h
  • platform/graphics/Font.h: Use FontItalics enum.
  • platform/graphics/FontDescription.h: Define and use FontItalics and FontSmallCaps enums.
12:23 AM Changeset in webkit [84608] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-22 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

address maciej's styling feedback for results.html page
​https://bugs.webkit.org/show_bug.cgi?id=59165

  • fast/harness/results.html:
12:09 AM Changeset in webkit [84607] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-21 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: exception in front-end when user selects resource info for resource that does not have response headers yet
​https://bugs.webkit.org/show_bug.cgi?id=59123

  • inspector/front-end/ResourceCookiesView.js: (WebInspector.ResourceCookiesView): (WebInspector.ResourceCookiesView.prototype.show): (WebInspector.ResourceCookiesView.prototype.get _gotCookies): (WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

Apr 21, 2011:

11:46 PM Changeset in webkit [84606] by commit-queue@webkit.org
  • 8 edits
    1 copy
    9 adds in trunk/LayoutTests

2011-04-21 Chris Weber <​chris@lookout.net>

Reviewed by Adam Barth.

Add more test coverage to fast/url
​https://bugs.webkit.org/show_bug.cgi?id=59142

The PASS/FAIL results for host, path, and port are set to match
Chromium. The PASS/FAIL results for idna2003 and idna2008 are set to
match those specifications.

  • fast/url/host-expected.txt:
  • fast/url/idna2003-expected.txt: Added.
  • fast/url/idna2003.html: Added.
  • fast/url/idna2008-expected.txt: Added.
  • fast/url/idna2008.html: Added.
  • fast/url/path-expected.txt:
  • fast/url/port-expected.txt:
  • fast/url/script-tests/host.js:
  • fast/url/script-tests/idna2003.js: Added.
  • fast/url/script-tests/idna2008.js: Added.
  • fast/url/script-tests/path.js:
  • fast/url/script-tests/port.js:
11:37 PM Changeset in webkit [84605] by tony@chromium.org
  • 1 edit
    1 delete in trunk/Tools

2011-04-21 Tony Chang <​tony@chromium.org>

Reviewed by Mihai Parparita.

Remove find-mismatched-layout-test-results since it's not needed in a
checksum free world.
​https://bugs.webkit.org/show_bug.cgi?id=59156

  • Scripts/find-mismatched-layout-test-results: Removed.
11:29 PM Changeset in webkit [84604] by Beth Dakin
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=57898
REGRESSION (r82185): Scroll position not restored on navigation back to a page in
the page cache
-and corresponding-
<rdar://problem/9226652>

Reviewed by Dan Bernstein.

Source/WebCore:

The original fix for this change broke scroll-position restore for pages that are
*not* in the page cache. This patch fixes both cached and non-cached pages by
using the cachedScrollPosition() only for cached pages.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):

LayoutTests:

  • fast/loader/scroll-position-restored-on-back-non-cached-expected.txt: Added.
  • fast/loader/scroll-position-restored-on-back-non-cached.html: Added.
11:13 PM Changeset in webkit [84603] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-21 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Eric Seidel.

Remove redundant calls to RenderStyle::setDisplay()
​https://bugs.webkit.org/show_bug.cgi?id=59060

No new tests / no new functionality added.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove redundant calls to RenderStyle::setDisplay()
11:08 PM Changeset in webkit [84602] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-21 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

WebGL context drawing buffer may not be cleared if FBO bound
​https://bugs.webkit.org/show_bug.cgi?id=58956

Clear the drawing buffer even if it's not currently bound, by
switching between FBOs around the clear. Also, make sure that we
handle depth and stencil masks properly.

No new tests, because testing this under DRT doesn't work.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::clearIfComposited): (WebCore::WebGLRenderingContext::depthMask):
  • html/canvas/WebGLRenderingContext.h:
10:37 PM Changeset in webkit [84601] by bfulgham@webkit.org
  • 4 edits in trunk/Tools

Teach build-webkit and update-webkit that the WinCairo port does
not need the non-redistributable WebKitSupportLibraries.zip file.
Also append the _Cairo_CFLite label to the build target for the
default (no argument) case when building with '--wincairo'

Reviewed by Martin Robinson.

​https://bugs.webkit.org/show_bug.cgi?id=58801

  • Scripts/build-webkit: Don't die if WebKitSupportLibraries.zip doesn't exist.
  • Scripts/webkitdirs.pm: Append '_Cairo_CFLite' to the default 'Release' build target when passed the '--wincairo' flag.
  • Scripts/update-webkit: Don't die if WebKitSupportLibraries.zip doesn't exist.
10:01 PM Changeset in webkit [84600] by Chris Fleizach
  • 8 edits in trunk

WebKit is erroneously modifying the DOM; adding 'aria-selected' to tables
​https://bugs.webkit.org/show_bug.cgi?id=59140

Reviewed by Beth Dakin.

Source/WebCore:

WebKit should not modify the DOM when the screen reader requests certain things be set. There is no
specification that allows this behavior yet, but we are working on something for the future.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setARIAGrabbed):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelected):
(WebCore::AccessibilityRenderObject::setValue):

LayoutTests:

  • accessibility/aria-combobox.html:
  • platform/mac/accessibility/aria-combobox-expected.txt:
  • platform/mac/accessibility/aria-slider-value-change-expected.txt:
  • platform/mac/accessibility/aria-slider-value-change.html:
9:54 PM Changeset in webkit [84599] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84583.
​http://trac.webkit.org/changeset/84583
​https://bugs.webkit.org/show_bug.cgi?id=59173

"broke
​http://trac.webkit.org/export/84593/trunk/LayoutTests/fast/js
/Object-create.html" (Requested by ggaren on #webkit).

  • runtime/ObjectConstructor.cpp: (JSC::objectConstructorCreate):
9:26 PM Changeset in webkit [84598] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Minimize synchronous calls during loading
​https://bugs.webkit.org/show_bug.cgi?id=59169

<rdar://problem/9320128> REGRESSION(r84526): WK2 windows unresponsive

  • UIProcess/API/mac/WKView.mm: (-[WKView resignFirstResponder]): (-[WKView _resetTextInputState]): Made _resetTextInputState deal with client side state only, letting Editor composition be discarded more discriminately.
8:45 PM Changeset in webkit [84597] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change - new baselines needed as
a result of r84589.

  • platform/chromium/test_expectations.txt:
8:29 PM Changeset in webkit [84596] by dpranke@chromium.org
  • 3 edits
    2 moves in trunk/Tools

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: obsolete old code, part 5: rename message_broker2 to message_broker
​https://bugs.webkit.org/show_bug.cgi?id=58758

Since worker_mixin is now only used by worker, there's no point
in having it split across two files.

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added
  • Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: * Added
  • Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Removed.
8:28 PM Changeset in webkit [84595] by dpranke@chromium.org
  • 2 edits
    1 delete in trunk/Tools

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: obsolete old code, part 4: merge worker_mixin into worker
​https://bugs.webkit.org/show_bug.cgi?id=58756

Since worker_mixin is now only used by worker, there's no point
in having it split across two files.

  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Removed.
8:26 PM Changeset in webkit [84594] by dpranke@chromium.org
  • 3 edits
    2 moves in trunk/Tools

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
​https://bugs.webkit.org/show_bug.cgi?id=58754

test_runner hasn't been a great name for some time, since all of
the test running is actually done in worker and
single_test_runner. Rename to manager to match the terminology
elsewhere.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
8:13 PM Changeset in webkit [84593] by Chris Fleizach
  • 4 edits in trunk/Source

AX: order AccessibilityRole alphabetically
​https://bugs.webkit.org/show_bug.cgi?id=31524

Reviewed by Beth Dakin.

Source/WebCore:

  • accessibility/AccessibilityObject.h:

Source/WebKit/chromium:

  • public/WebAccessibilityRole.h:
7:49 PM Changeset in webkit [84592] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-21 Jia Pu <​jpu@apple.com>

Reviewed by Maciej Stachowiak.

[Mac] correctionPanelTimerFired() crashes due to rangeToBeReplaced being cleared.
​https://bugs.webkit.org/show_bug.cgi?id=59155
<rdar://problem/9261698>

Make sure the range isn't cleared before calling windowRectForRange() on it. Also removed unused functions in Editor.h,
and fixed a typo in function name.

  • editing/Editor.h:
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::correctionPanelTimerFired): (WebCore::SpellingCorrectionController::respondToChangedSelection):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::shouldStartTimerFor):
7:48 PM Changeset in webkit [84591] by dpranke@chromium.org
  • 3 edits
    1 delete in trunk/Tools

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: obsolete old threading code, part 2
​https://bugs.webkit.org/show_bug.cgi?id=58753

This merges the test_runner2 code back into test_runner since
there's only a single type of test runner now.

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:41 PM Changeset in webkit [84590] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change. Triage failure for
media/video-zoom.html on chromium gpu bots.

  • platform/chromium/test_expectations.txt:
7:30 PM Changeset in webkit [84589] by mjs@apple.com
  • 34 edits in trunk

2011-04-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Roben.

Add a feature define to allow <details> and <summary> to be disabled
​https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>

  • configure.ac:

2011-04-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Roben.

Add a feature define to allow <details> and <summary> to be disabled
​https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>

  • Configurations/FeatureDefines.xcconfig:

2011-04-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Roben.

Add a feature define to allow <details> and <summary> to be disabled
​https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>

  • features.gypi:

2011-04-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Roben.

Add a feature define to allow <details> and <summary> to be disabled
​https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>

  • Configurations/FeatureDefines.xcconfig:

2011-04-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Roben.

Add a feature define to allow <details> and <summary> to be disabled
​https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>

No new tests; no behavior change.

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • features.pri:
  • html/HTMLDetailsElement.cpp:
  • html/HTMLSummaryElement.cpp:
  • html/HTMLTagNames.in:
  • html/shadow/DetailsMarkerControl.cpp:
  • rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks):
  • rendering/RenderDetails.cpp:
  • rendering/RenderDetails.h:
  • rendering/RenderDetailsMarker.cpp:
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderObject.h:
  • rendering/RenderSummary.cpp:
  • rendering/RenderSummary.h:
  • rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject):

2011-04-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Roben.

Add a feature define to allow <details> and <summary> to be disabled
​https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>

  • Configurations/FeatureDefines.xcconfig:

2011-04-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Roben.

Add a feature define to allow <details> and <summary> to be disabled
​https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>

  • Scripts/build-webkit:
  • Tools.pro:

2011-04-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adam Roben.

Add a feature define to allow <details> and <summary> to be disabled
​https://bugs.webkit.org/show_bug.cgi?id=59118
<rdar://problem/9257045>


  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
7:29 PM Changeset in webkit [84588] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change. Suppress failures on chromium
win/linux from bug 59166.

  • platform/chromium/test_expectations.txt:
7:01 PM Changeset in webkit [84587] by Dimitri Glazkov
  • 5 edits in trunk

2011-04-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adele Peterson.

REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
​https://bugs.webkit.org/show_bug.cgi?id=59053

  • fast/events/shadow-boundary-crossing-expected.txt: Updated expected results.
  • fast/events/shadow-boundary-crossing.html: Added new sub-test.

2011-04-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adele Peterson.

REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
​https://bugs.webkit.org/show_bug.cgi?id=59053

Turns out, the relatedTarget of an event could be also an ancestor of an event,
not just its parent. Duh.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::adjustToShadowBoundaries): Changed to use shadowHost

explicitly.

6:42 PM Changeset in webkit [84586] by msaboff@apple.com
  • 5 edits in trunk/Source/WebCore

2011-04-21 Michael Saboff <​msaboff@apple.com>

Reviewed by Maciej Stachowiak.

Qualified names used for all TagName access, yet namespace usage is rare
​https://bugs.webkit.org/show_bug.cgi?id=58997

The methods getElementsByTagName and getElementsByTagNameNS where
always creating and using QualifiedNames. QualifiedName::init
was consistently in the top 3 routines when running the Dromaeo
DOM-query benchmark. Split out the functionality so that
getElementsByTagName uses just the local name, an implied "*"
namespace and a separate TagNodeListCache keyed by an atomic name
instead of a QualifiedName. Access to elements via
getElementsByTagNameNS that have "*" namespace are forwarded to
getElementsByTagName as well. This provides ~10% speed up in that
Dromaeo test.

No new tests added, existing tests have coverage. The changes are
an optimization of existing functionality.

  • dom/Node.cpp: (WebCore::Node::removeCachedTagNodeList): (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS): (WebCore::NodeListsNodeData::invalidateCaches): (WebCore::NodeListsNodeData::isEmpty):
  • dom/Node.h:
  • dom/NodeRareData.h:
  • dom/TagNodeList.cpp: (WebCore::TagNodeList::~TagNodeList):
6:31 PM Changeset in webkit [84585] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit/wince

2011-04-21 Ryosuke Niwa <​rniwa@webkit.org>

WinCE build fix after r84574.

  • WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::canCopyCut): (WebKit::EditorClientWinCE::canPaste):
  • WebCoreSupport/EditorClientWinCE.h:
6:30 PM Changeset in webkit [84584] by ggaren@apple.com
  • 16 edits in trunk/Source/WebCore

2011-04-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed a use of markDOMObjectWrapper: more style- and node-related stuff
​https://bugs.webkit.org/show_bug.cgi?id=59127

  • bindings/js/JSCanvasRenderingContextCustom.cpp:
  • bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::JSCanvasRenderingContextOwner::isReachableFromOpaqueRoots): (WebCore::JSCanvasRenderingContextOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): Use opaque roots for marking canvas rendering contexts, so JSNode isn't responsible for it.
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::markChildren):
  • bindings/js/JSHTMLCanvasElementCustom.cpp:
  • bindings/js/JSHTMLLinkElementCustom.cpp:
  • bindings/js/JSHTMLStyleElementCustom.cpp: Removed obsolete marking code.
  • bindings/js/JSNodeCustom.cpp: (WebCore::isObservable): (WebCore::isReachableFromDOM): (WebCore::JSNodeOwner::isReachableFromOpaqueRoots): Removed a bunch of CSS object model related special cases, since the CSS object model now tracks its own lifetime through the opaque roots system. Removed canvas special case, covered above.
  • bindings/js/JSProcessingInstructionCustom.cpp:
  • bindings/js/JSWebKitAnimationListCustom.cpp:
  • dom/ProcessingInstruction.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLStyleElement.idl:
  • page/WebKitAnimationList.idl: Removed obsolete marking code.
6:30 PM Changeset in webkit [84583] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-21 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Object.create creates uncachable objects
​https://bugs.webkit.org/show_bug.cgi?id=59164

Use the prototype object's inheritorID, as we
should always have done

  • runtime/ObjectConstructor.cpp: (JSC::objectConstructorCreate):
6:05 PM Changeset in webkit [84582] by vangelis@chromium.org
  • 15 edits in trunk/Source/WebCore

2011-04-21 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Only update the contents of layers that are going to
be drawn. Remove individual texture unreserves that happen
after the layer draw calls with a single unreserve for all the
textures in the texture manager.
​https://bugs.webkit.org/show_bug.cgi?id=59129

Tests: No new functionality. Covered by existing layout tests.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::paintLayerContents):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTexture.cpp:
  • platform/graphics/chromium/LayerTexture.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp:
  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawSurface):
  • platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::unprotectAllTextures):
  • platform/graphics/chromium/TextureManager.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::owner):
5:50 PM Changeset in webkit [84581] by Lucas Forschler
  • 14 edits in tags/Safari-534.30/Source/WebKit2

Rollout 84526.

5:49 PM Changeset in webkit [84580] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9311103>

Reviewed by Maciej Stachowiak.

Remove unnecessary QTKitServer and Apple Events permissions
from the WebProcess sandbox.

  • WebProcess/com.apple.WebProcess.sb:
5:45 PM Changeset in webkit [84579] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

5:43 PM Changeset in webkit [84578] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

2011-04-21 Ryosuke Niwa <​rniwa@webkit.org>

Windows build fix.

  • WebCoreSupport/WebEditorClient.h:
5:42 PM Changeset in webkit [84577] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9033535>

Reviewed by Maciej Stachowiak.

Mute sandbox violations when attempting to read a temporary
CFNetwork keychain.

  • WebProcess/com.apple.WebProcess.sb:
5:38 PM Changeset in webkit [84576] by Lucas Forschler
  • 1 copy in tags/Safari-534.30

New tag.

5:34 PM Changeset in webkit [84575] by abarth@webkit.org
  • 5 edits in trunk/Tools

2011-04-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch upload should assign the bug to you
​https://bugs.webkit.org/show_bug.cgi?id=33699

This patch only re-assigns the bug if it is currently unassigned. We
can be more aggressive in the future if people want us to be more
agressive.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
5:33 PM Changeset in webkit [84574] by rniwa@webkit.org
  • 31 edits in trunk/Source

2011-04-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
​https://bugs.webkit.org/show_bug.cgi?id=59153

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::canCopyCut): (WebKit::EditorClientImpl::canPaste):
  • src/EditorClientImpl.h:

2011-04-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
​https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::canCopyCut): (WebCore::EditorClientQt::canPaste):
  • WebCoreSupport/EditorClientQt.h:

2011-04-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
​https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::canCopyCut): (WebKit::EditorClient::canPaste):
  • WebCoreSupport/EditorClientGtk.h:

2011-04-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
​https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::canCopyCut): (WebEditorClient::canPaste):
  • WebCoreSupport/WebEditorClient.h:

2011-04-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
​https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::canCopyCut): (WebCore::EditorClientWx::canPaste):
  • WebKitSupport/EditorClientWx.h:

2011-04-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
​https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::canCopyCut): (WebEditorClient::canPaste):

2011-04-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
​https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::canCopyCut): (WebCore::EditorClientHaiku::canPaste):
  • WebCoreSupport/EditorClientHaiku.h:

2011-04-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
​https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::canCopyCut): (WebCore::EditorClientEfl::canPaste):
  • WebCoreSupport/EditorClientEfl.h:

2011-04-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
​https://bugs.webkit.org/show_bug.cgi?id=59153

canCopyCut and canPaste now takes Frame* for which supportedCopyCut and supportedPaste are called.
This allows editor client to grant copy/cut and paste permissions per origin.

  • editing/EditorCommand.cpp: (WebCore::supportedCopyCut): (WebCore::supportedPaste):
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::canCopyCut): (WebCore::EmptyEditorClient::canPaste):
  • page/EditorClient.h:

2011-04-21 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Sam Weinig.

Add Frame* to the argument lists of canCopyCut and canPaste
​https://bugs.webkit.org/show_bug.cgi?id=59153

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::canCopyCut): (WebKit::WebEditorClient::canPaste):
  • WebProcess/WebCoreSupport/WebEditorClient.h:
5:22 PM Changeset in webkit [84573] by dpranke@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Unreviwed, expecations change. Pick up chromium-win baselines
for r84522.

  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
  • platform/chromium-win/svg/filters/feDropShadow-expected.png: Added.
5:17 PM Changeset in webkit [84572] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Suppress failures possibly caused by bug 59158 on chromium win/linux:
fast/canvas/canvas-stroke{Path,Rect}-alpha-shadow.html = TEXT

  • platform/chromium/test_expectations.txt:
5:10 PM Changeset in webkit [84571] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8774116>

Reviewed by Maciej Stachowiak.

The WebProcess sandbox should only allow access to the
parts of the Darwin cache directory needed by the Security
framework.

  • WebProcess/com.apple.WebProcess.sb:
5:06 PM Changeset in webkit [84570] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9311053>

Reviewed by Maciej Stachowiak.

The WebProcess sandbox should not allow opening arbitrary
IOKit user clients. Restrict to a whitelist required for normal
WebProcess operation, including sound and accelerated graphics.

  • WebProcess/com.apple.WebProcess.sb:
5:03 PM Changeset in webkit [84569] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9311037>

Reviewed by Maciej Stachowiak.

The WebProcess sandbox should not allow modification of the
CoreAudio component cache.

  • WebProcess/com.apple.WebProcess.sb:
4:58 PM Changeset in webkit [84568] by ojan@chromium.org
  • 3 edits
    2 moves
    1 add in trunk

fix

4:58 PM Changeset in webkit [84567] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9263428>

Reviewed by Maciej Stachowiak.

The WebProcess sandbox should only allow outbound networking
to remote destinations and local kernel controls.

  • WebProcess/com.apple.WebProcess.sb:
4:54 PM Changeset in webkit [84566] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Whoops, change lost during merge

4:49 PM Changeset in webkit [84565] by dpranke@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Update baselines to accomodate the change in r84506. I wonder
how much having platform/mac in the search path hurts
chromium-win/-linux.

  • platform/chromium-win/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.
4:44 PM Changeset in webkit [84564] by mdelaney@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

2011-04-21 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Move canvas test set-colors.html expected results out of platform/mac-leopard and into platform/mac
This test expected result pertains to all of mac, not just leopard.
​https://bugs.webkit.org/show_bug.cgi?id=59139

  • platform/mac-leopard/fast/canvas/set-colors-expected.txt: Removed.
  • platform/mac/fast/canvas/set-colors-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/canvas/set-colors-expected.txt.
4:36 PM Changeset in webkit [84563] by tony@chromium.org
  • 22 edits in trunk/LayoutTests

2011-04-21 Tony Chang <​tony@chromium.org>

Embed checksums in more png files. Not sure how these were missed earlier.

  • animations/missing-values-first-keyframe-expected.png:
  • animations/missing-values-last-keyframe-expected.png:
  • animations/opacity-transform-animation-expected.png:
  • animations/suspend-transform-animation-expected.png:
  • compositing/backface-visibility-expected.png:
  • compositing/checkerboard-expected.png:
  • compositing/geometry/ancestor-overflow-change-expected.png:
  • compositing/geometry/tall-page-composited-expected.png:
  • compositing/iframes/composited-iframe-scroll-expected.png:
  • compositing/iframes/iframe-content-flipping-expected.png:
  • compositing/iframes/nested-iframe-scrolling-expected.png:
  • compositing/images/direct-pdf-image-expected.png:
  • compositing/images/direct-svg-image-expected.png:
  • compositing/overflow/zero-size-overflow-expected.png:
  • compositing/reflections/backface-hidden-reflection-expected.png:
  • compositing/reflections/remove-add-reflection-expected.png:
  • compositing/tiling/constrained-layer-size-expected.png:
  • compositing/z-order/negative-z-index-expected.png:
  • transforms/3d/general/cssmatrix-3d-zoom-expected.png:
  • transforms/3d/general/matrix-with-zoom-3d-expected.png:
  • transitions/suspend-transform-transition-expected.png:
4:31 PM April 2011 Meeting edited by andreas.kling@nokia.com
(diff)
4:29 PM Changeset in webkit [84562] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Reviewed by NOBODY (OOPS!).

Unreviewed, expectations change - update chromium SVG baselines
after r84522.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
4:24 PM Changeset in webkit [84561] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-04-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82052.
​http://trac.webkit.org/changeset/82052
​https://bugs.webkit.org/show_bug.cgi?id=59135

New full screen api should be opt-in, not opt-out. (Requested
by jernoble on #webkit).

  • WebView/WebPreferences.mm: (+[WebPreferences initialize]):

2011-04-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r82052.
​http://trac.webkit.org/changeset/82052
​https://bugs.webkit.org/show_bug.cgi?id=59135

New full screen api should be opt-in, not opt-out. (Requested
by jernoble on #webkit).

  • Shared/WebPreferencesStore.h:
4:24 PM Changeset in webkit [84560] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-04-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

ValidateChangeLogs doesn't work on SVN
​https://bugs.webkit.org/show_bug.cgi?id=59115

svn-create-patch lies about the diff in the working copy by moving
ChangeLog entries to the top of the diff. That's fine on most cases,
but causes problems for ValidateChangeLogs, which is trying validate
the where the ChangeLog entry appears.

I haven't added a test for this change because I couldn't figure out
how to write one. The issue is more of an integration issue, which
we're not really set up to test in our unit testing framework. If this
patch had worked around the output from svn-create-patch, then I could
have tested that we behave correctly on sample svn-create-patch output,
but, in this case, I've removed the dependency on svn-create-patch. I
could test that we behave correctly on "svn diff" output, but we
already have those tests.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/validatechangelogs.py:
4:22 PM Changeset in webkit [84559] by dpranke@chromium.org
  • 1 edit
    18 adds in trunk/LayoutTests

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change - update chromium SVG baselines
after r84522.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
  • platform/chromium-linux/svg/filters/feDropShadow-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
  • platform/chromium-mac/svg/filters/feDropShadow-expected.png: Added.
4:20 PM Changeset in webkit [84558] by ggaren@apple.com
  • 5 edits in trunk

Fixed a failure seen in fast/dom/prototype-inheritance-2.html due to
wrong global object use.

Reviewed by Sam Weinig.

Source/WebCore:

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):

  • bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::nameGetter): Use the right global object.

LayoutTests:

  • fast/dom/prototype-inheritance-2-expected.txt: Expect success!
4:10 PM Changeset in webkit [84557] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change - flaky tests.

  • platform/chromium/test_expectations.txt:
4:08 PM Changeset in webkit [84556] by oliver@apple.com
  • 120 edits in trunk/Source

2011-04-21 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Start moving to a general visitor pattern for GC traversal
​https://bugs.webkit.org/show_bug.cgi?id=59141

This is just a rename:

markChildren -> visitChildren
markAggregate -> visitAggregate
markStack -> visitor
MarkStack -> typedef'd to SlotVisitor

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::visitChildren): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren): (JSC::JSCallbackObject::visitChildren):
  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitStructures): (JSC::EvalCodeCache::visitAggregate): (JSC::CodeBlock::visitAggregate):
  • bytecode/CodeBlock.h:
  • bytecode/EvalCodeCache.h:
  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::visitAggregate):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::visitAggregate):
  • bytecode/StructureStubInfo.h:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::visitChildren):
  • debugger/DebuggerActivation.h:
  • heap/HandleHeap.cpp: (JSC::WeakHandleOwner::isReachableFromOpaqueRoots): (JSC::HandleHeap::markStrongHandles): (JSC::HandleHeap::markWeakHandles):
  • heap/HandleHeap.h:
  • heap/HandleStack.cpp: (JSC::HandleStack::mark):
  • heap/HandleStack.h:
  • heap/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • heap/Heap.h:
  • heap/MarkStack.cpp: (JSC::MarkStack::visitChildren): (JSC::MarkStack::drain):
  • heap/MarkStack.h: (JSC::HeapRootVisitor::HeapRootVisitor): (JSC::HeapRootVisitor::mark): (JSC::HeapRootVisitor::visitor):
  • heap/MarkedSpace.h:
  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists):
  • runtime/ArgList.h:
  • runtime/Arguments.cpp: (JSC::Arguments::visitChildren):
  • runtime/Arguments.h:
  • runtime/Executable.cpp: (JSC::EvalExecutable::visitChildren): (JSC::ProgramExecutable::visitChildren): (JSC::FunctionExecutable::visitChildren):
  • runtime/Executable.h:
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::visitChildren):
  • runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
  • runtime/JSActivation.cpp: (JSC::JSActivation::visitChildren):
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp: (JSC::JSArray::visitChildren):
  • runtime/JSArray.h: (JSC::JSArray::visitDirect):
  • runtime/JSCell.h: (JSC::JSCell::JSCell::visitChildren):
  • runtime/JSFunction.cpp: (JSC::JSFunction::visitChildren):
  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp: (JSC::visitIfNeeded): (JSC::JSGlobalObject::visitChildren):
  • runtime/JSGlobalObject.h:
  • runtime/JSONObject.cpp:
  • runtime/JSObject.cpp: (JSC::JSObject::visitChildren):
  • runtime/JSObject.h: (JSC::JSObject::visitDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::visitChildren):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure):
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::visitChildren):
  • runtime/JSStaticScopeObject.h:
  • runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::overridesVisitChildren):
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::visitChildren):
  • runtime/JSWrapperObject.h:
  • runtime/JSZombie.h: (JSC::JSZombie::visitChildren):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::visitChildren):
  • runtime/NativeErrorConstructor.h:
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::visitChildren):
  • runtime/RegExpObject.h:
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::visitChildren):
  • runtime/ScopeChain.h:
  • runtime/SmallStrings.cpp: (JSC::SmallStrings::visitChildren):
  • runtime/SmallStrings.h:
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::visitChildren):
  • runtime/Structure.h:
  • runtime/StructureChain.cpp: (JSC::StructureChain::visitChildren):
  • runtime/StructureChain.h: (JSC::StructureChain::createStructure):

2011-04-21 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Start moving to a general visitor pattern for GC traversal
​https://bugs.webkit.org/show_bug.cgi?id=59141

This is just a rename:

markChildren -> visitChildren
markAggregate -> visitAggregate
markStack -> visitor
MarkStack -> typedef'd to SlotVisitor

  • UserObjectImp.cpp: (UserObjectImp::visitChildren):

2011-04-21 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Start moving to a general visitor pattern for GC traversal
​https://bugs.webkit.org/show_bug.cgi?id=59141

This is just a rename:

markChildren -> visitChildren
markAggregate -> visitAggregate
markStack -> visitor
MarkStack -> typedef'd to SlotVisitor

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::visitChildren):
  • bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRule::visitChildren):
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::visitChildren):
  • bindings/js/JSDOMBinding.cpp: (WebCore::visitActiveObjectsForContext): (WebCore::markDOMObjectWrapper):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::visitChildren):
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMImplementationCustom.cpp: (WebCore::JSDOMImplementation::visitChildren):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::visitChildren):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::visitChildren):
  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::visitChildren):
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::visitChildren):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::markJSFunction):
  • bindings/js/JSEventListener.h:
  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::visitChildren):
  • bindings/js/JSHTMLLinkElementCustom.cpp: (WebCore::JSHTMLLinkElement::visitChildren):
  • bindings/js/JSHTMLStyleElementCustom.cpp: (WebCore::JSHTMLStyleElement::visitChildren):
  • bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
  • bindings/js/JSJavaScriptAudioNodeCustom.cpp: (WebCore::JSJavaScriptAudioNode::visitChildren):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren):
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots): (WebCore::JSNamedNodeMap::visitChildren):
  • bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::visitChildren):
  • bindings/js/JSNodeCustom.cpp: (WebCore::isObservable): (WebCore::isReachableFromDOM): (WebCore::JSNodeOwner::isReachableFromOpaqueRoots): (WebCore::JSNode::visitChildren):
  • bindings/js/JSNodeCustom.h:
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::visitChildren):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::visitChildren):
  • bindings/js/JSNodeListCustom.cpp: (WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
  • bindings/js/JSProcessingInstructionCustom.cpp: (WebCore::JSProcessingInstruction::visitChildren):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::visitChildren):
  • bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::visitChildren):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::visitChildren):
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren):
  • bindings/js/JSWebKitAnimationListCustom.cpp: (WebCore::JSWebKitAnimationList::visitChildren):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::visitChildren):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::visitChildren):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtRuntimeObject::visitChildren): (JSC::Bindings::QtInstance::markAggregate):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_pixmapruntime.cpp:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
  • bridge/qt/qt_runtime.h:
  • dom/EventListener.h: (WebCore::EventListener::visitJSFunction):
  • dom/EventTarget.h: (WebCore::EventTarget::visitJSEventListeners):
  • dom/Node.h:
  • dom/NodeFilterCondition.h: (WebCore::NodeFilterCondition::visitAggregate):
  • page/DOMWindow.h:
  • workers/WorkerContext.h:
4:07 PM Changeset in webkit [84555] by abarth@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-04-21 Adam Barth <​abarth@webkit.org>

Update test results to show that we're using ogv. I would have
preferred to make this test independent of which video codec we have,
but I didn't see a way to do that.

  • platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt: Added.
  • platform/chromium/media/csp-blocks-video-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:52 PM Changeset in webkit [84554] by tony@chromium.org
  • 1 edit
    12822 deletes in trunk/LayoutTests

2011-04-21 Tony Chang <​tony@chromium.org>

Unreviewed, deleting .checksum files in platform/chromium*

3:49 PM Changeset in webkit [84553] by Beth Dakin
  • 20 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=59048
Need to track whether overlay scrollbar is currently visible and in lower-
righthand corner
-and corresponding-
<rdar://problem/9211232>

Reviewed by Dan Bernstein.

Source/WebCore:

Whenever we start a new ScrollbarPartAnimation, check if the scrollbar is vertical
and showing (alpha of 1), and if so, call setVisibleScrollerThumbRect with the
knob rect, otherwise with an empty rect. ScrollAnimatorMac has a local rect to
track this value so that it can avoid sending messages across the ChromeClient to
the UIProcess if the rect has not changed.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::setVisibleScrollerThumbRect):

Plumbing for the chrome client.

  • page/ChromeClient.h:

(WebCore::ChromeClient::notifyScrollerThumbIsVisibleInRect):

  • page/FrameView.cpp:

(WebCore::FrameView::setVisibleScrollerThumbRect):

  • page/FrameView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::setVisibleScrollerThumbRect):

New WebCoreSystemInterface function to get the knob rect.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

A new WebSystemInterface is needed for this.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

WebPageProxy now stores an IntRect of the scroller thumb set by WebCore through
the client.

_windowResizeMouseLocationIsInVisibleScrollerThumb tests if the parameter point is
inside the cached scroller thumb rect.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _windowResizeMouseLocationIsInVisibleScrollerThumb:]):

Client work to cache the rect.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::notifyScrollerThumbIsVisibleInRect):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::visibleScrollerThumbRect):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::notifyScrollerThumbIsVisibleInRect):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

New WebSystemInterface is needed by WebCore for this.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

3:47 PM Changeset in webkit [84552] by enne@google.com
  • 3 edits in branches/chromium/742/Source/WebCore/platform/graphics/chromium

Merge 84542 - 2011-04-21 Adrienne Walker <​enne@google.com> Reviewed by James Robinson. [chromium] Don't upload partially drawn tiles in the compositor ​https://bugs.webkit.org/show_bug.cgi?id=59112 Use the same set of tiles for painting as is used for updating. Before, a larger set of tiles were being uploaded, causing some to only be partially undirtied because they were not fully painted. As tiles are clear their dirty rect after being unpainted, this caused artifacts to appear when scrolling. Unfortunately, no layout test can test this behavior yet because scrolling invalidations are done differently in test shell. * platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateCompositorResources): * platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::uploadCanvas): (WebCore::LayerTilerChromium::updateFromPixels): * platform/graphics/chromium/LayerTilerChromium.h:
TBR=​enne@google.com

3:44 PM Changeset in webkit [84551] by enne@google.com
  • 1 edit in branches/chromium/742/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp

Merge 84529 - 2011-04-21 Adrienne Walker <​enne@google.com> Reviewed by James Robinson. [chromium] Clamp dirty regions on content layers to layer bounds ​https://bugs.webkit.org/show_bug.cgi?id=58933 This prevents garbage being rendered when layers are resized and a previous invalidation (now off-layer) is no longer valid. * platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::paintContentsIfDirty):
TBR=​enne@google.com

3:13 PM Changeset in webkit [84550] by adamk@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84548.
​http://trac.webkit.org/changeset/84548
​https://bugs.webkit.org/show_bug.cgi?id=59144

Broke chromium-win build (Requested by aklein on #webkit).

  • wtf/Platform.h:
3:00 PM Changeset in webkit [84549] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-04-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

ValidateChangeLogs doesn't work on SVN
​https://bugs.webkit.org/show_bug.cgi?id=59115

svn-create-patch lies about the diff in the working copy by moving
ChangeLog entries to the top of the diff. That's fine on most cases,
but causes problems for ValidateChangeLogs, which is trying validate
the where the ChangeLog entry appears.

I haven't added a test for this change because I couldn't figure out
how to write one. The issue is more of an integration issue, which
we're not really set up to test in our unit testing framework. If this
patch had worked around the output from svn-create-patch, then I could
have tested that we behave correctly on sample svn-create-patch output,
but, in this case, I've removed the dependency on svn-create-patch. I
could test that we behave correctly on "svn diff" output, but we
already have those tests.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/validatechangelogs.py:
2:39 PM Changeset in webkit [84548] by adamk@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-21 Adam Klein <​adamk@chromium.org>

Reviewed by David Levin.

[fileapi] Worker File API calls that create Blobs fail in debug builds due to random number generator thread assertion
​https://bugs.webkit.org/show_bug.cgi?id=55728

Enable WTF_MULTIPLE_THREADS for Chromium.

  • wtf/Platform.h:
2:28 PM Changeset in webkit [84547] by tony@chromium.org
  • 69 edits in trunk/LayoutTests

2011-04-21 Tony Chang <​tony@chromium.org>

Unreviewed, embedding checksums in png files not in LayoutTests/platform.

2:27 PM April 2011 Meeting edited by sam@webkit.org
(diff)
2:22 PM Changeset in webkit [84546] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-21 Nat Duca <​nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Fix artefacts in compositor HUD when resizing
​https://bugs.webkit.org/show_bug.cgi?id=58969

HUD was using the tiler program and not setting the texture
transform. The HUD would thus draw with a texture transform based
on the last tile drawn, leading sometimes to distortion.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::headsUpDisplayProgram):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
2:09 PM Changeset in webkit [84545] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-21 Mike Reed <​reed@google.com>

Reviewed by Kenneth Russell.

only return false if we actually in a skia-gpu accelerated canvas for isNativeFontRenderingAllowed
​https://bugs.webkit.org/show_bug.cgi?id=59024

No new tests. The bug (and fix) depend on enabling SKIA_GPU. When that is enabled, the bug
shows all text w/o lcd rendering. This is a regression from a recent CL when we switch to
calling skia::SupportsPlatformPaint. This CL fixes that.
There should be no change for the default builds when SKIA_GPU is not enabled.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2:08 PM Changeset in webkit [84544] by tony@chromium.org
  • 7 edits in trunk/Tools

2011-04-21 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

old-run-webkit-tests/new-run-webkit-tests shouldn't read or write .checksum files
​https://bugs.webkit.org/show_bug.cgi?id=58402

  • Scripts/old-run-webkit-tests: Don't read or write .checksum files.
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Don't write .checksum files.
  • Scripts/webkitpy/layout_tests/port/base.py: Don't read .checksum files.
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py: Update passing pngs to include a checksum.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1:44 PM Changeset in webkit [84543] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-04-21 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

only expand visible rows
​https://bugs.webkit.org/show_bug.cgi?id=59130

For the chromium port, where there are many expected failures,
expanding all of them is quite slow. Only expand the visible ones.
This makes the default case. Also, make the expanding async to
avoid totally killing the process.

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
1:19 PM Changeset in webkit [84542] by enne@google.com
  • 4 edits in trunk/Source/WebCore

2011-04-21 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Don't upload partially drawn tiles in the compositor
​https://bugs.webkit.org/show_bug.cgi?id=59112

Use the same set of tiles for painting as is used for updating.
Before, a larger set of tiles were being uploaded, causing some to
only be partially undirtied because they were not fully painted.
As tiles are clear their dirty rect after being unpainted, this caused
artifacts to appear when scrolling.

Unfortunately, no layout test can test this behavior yet because
scrolling invalidations are done differently in test shell.

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateCompositorResources):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::uploadCanvas): (WebCore::LayerTilerChromium::updateFromPixels):
  • platform/graphics/chromium/LayerTilerChromium.h:
12:49 PM Changeset in webkit [84541] by krit@webkit.org
  • 5 edits in trunk/LayoutTests

2011-04-21 Dirk Schulze <​krit@webkit.org>

Uneviewed rebaseline of win.

SVG feDropShadow implementation of SVG Filters 1.2
​https://bugs.webkit.org/show_bug.cgi?id=52513

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
12:35 PM Changeset in webkit [84540] by Martin Robinson
  • 7 edits
    3 deletes in trunk

2011-04-21 Martin Robinson <​mrobinson@igalia.com>

[GTK] DRT: implement eventSender.scalePageBy
​https://bugs.webkit.org/show_bug.cgi?id=59082

Rolling out r84507 since it broke many GTK+ tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/repaint/scale-page-shrink-expected.checksum: Removed.
  • platform/gtk/fast/repaint/scale-page-shrink-expected.png: Removed.
  • platform/gtk/fast/repaint/scale-page-shrink-expected.txt: Removed.

2011-04-21 Martin Robinson <​mrobinson@igalia.com>

[GTK] DRT: implement eventSender.scalePageBy
​https://bugs.webkit.org/show_bug.cgi?id=59082

Rolling out r84507 since it broke many GTK+ tests.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-04-21 Martin Robinson <​mrobinson@igalia.com>

[GTK] DRT: implement eventSender.scalePageBy
​https://bugs.webkit.org/show_bug.cgi?id=59082

Rolling out r84507 since it broke many GTK+ tests.

  • DumpRenderTree/gtk/EventSender.cpp:
12:31 PM Changeset in webkit [84539] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit2

2011-04-21 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Emit QWKPage::urlChanged() when navigating within the same document.
​https://bugs.webkit.org/show_bug.cgi?id=59044

Hook up the didSameDocumentNavigationForFrame callback to QWKPage::urlChanged().

  • UIProcess/API/qt/ClientImpl.cpp: (qt_wk_didSameDocumentNavigationForFrame):
  • UIProcess/API/qt/ClientImpl.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
12:27 PM Changeset in webkit [84538] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-04-21 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=58725

Fix a compile issue on Solaris 10 with Sun Studio 12,
ternary operators (?:) must have the same types

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::popArchiveForSubframe):
  • loader/archive/ArchiveFactory.cpp: (WebCore::ArchiveFactory::create):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconDataForIconURL):
  • page/animation/AnimationBase.cpp: (WebCore::blendFunc):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollCornerStyle): (WebCore::RenderLayer::updateResizerStyle):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::RenderTextFragment):
12:22 PM Changeset in webkit [84537] by krit@webkit.org
  • 6 edits in trunk/LayoutTests

2011-04-21 Dirk Schulze <​krit@webkit.org>

Unreviewed rebaseline.

SVG feDropShadow implementation of SVG Filters 1.2
​https://bugs.webkit.org/show_bug.cgi?id=52513

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
12:15 PM Changeset in webkit [84536] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed. Update expected files after r84522.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
12:09 PM Changeset in webkit [84535] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-21 Mike Reed <​reed@google.com>

Reviewed by Kenneth Russell.

[chromium, win] Multiple failures of shadow rendering layout tests
​https://bugs.webkit.org/show_bug.cgi?id=58772

No new tests. This CL fixes a regression in the following tests
fast/multicol/shadow-breaking.html
fast/repaint/shadow-multiple-horizontal.html
fast/repaint/shadow-multiple-strict-horizontal.html
fast/repaint/shadow-multiple-strict-vertical.html
fast/repaint/shadow-multiple-vertical.html
fast/text/shadow-translucent-fill.html
fast/transforms/shadows.html
svg/css/group-with-shadow.svg
svg/css/shadow-changes.svg
svg/css/text-shadow-multiple.xhtml
transitions/svg-text-shadow-transition.html
svg/css/composite-shadow-text.svg

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
12:08 PM Changeset in webkit [84534] by weinig@apple.com
  • 6 edits in trunk/Tools

2011-04-21 Sam Weinig <​sam@webkit.org>

Reviewed by Simon Fraser.

Add way to garbage collect between each test when running layout tests
​https://bugs.webkit.org/show_bug.cgi?id=59126

  • DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions): (runTest):
  • Scripts/old-run-webkit-tests:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessage):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::TestController): (WTR::TestController::initialize): (WTR::TestController::resetStateToConsistentValues):
  • WebKitTestRunner/TestController.h:
12:01 PM Changeset in webkit [84533] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed: skip tests on Windows.

fast/dom/shadow/layout-tests-can-access-shadow.html is failing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=59081

Skip all tests in fast/dom/shadow on Windows.
(shadowRoot accessor is not implemented on Windows yet)

  • platform/win/Skipped:
11:56 AM Changeset in webkit [84532] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Roll in downstream failures as of Chromium r82532.

  • platform/chromium/test_expectations.txt:
11:46 AM Changeset in webkit [84531] by ggaren@apple.com
  • 3 edits in trunk/Source/WebCore

Try to fix the Qt build.

  • UseJSC.cmake:
  • WebCore.pro: Use correct file name.
11:45 AM Changeset in webkit [84530] by krit@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-21 Dirk Schulze <​krit@webkit.org>

Unreviewed Qt build fix.

SVG feDropShadow implementation of SVG Filters 1.2
​https://bugs.webkit.org/show_bug.cgi?id=52513

  • CodeGenerators.pri:
11:39 AM Changeset in webkit [84529] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-21 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Clamp dirty regions on content layers to layer bounds
​https://bugs.webkit.org/show_bug.cgi?id=58933

This prevents garbage being rendered when layers are resized and a
previous invalidation (now off-layer) is no longer valid.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::paintContentsIfDirty):
11:32 AM Changeset in webkit [84528] by rolandsteiner@chromium.org
  • 4 edits
    2 adds in trunk

2011-04-21 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Bug 59012 - Shadows should be imported along with their host nodes
​https://bugs.webkit.org/show_bug.cgi?id=59012

Verify that the shadow of a bound element is imported along with the element.

  • fast/dom/shadow/import-shadowroot-expected.txt: Added.
  • fast/dom/shadow/import-shadowroot.html: Added.

2011-04-21 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Bug 59012 - Shadows should be imported along with their host nodes
​https://bugs.webkit.org/show_bug.cgi?id=59012

Copy the shadow tree of an element (even on a shallow copy!).

Test: fast/dom/shadow/import-shadowroot.html

  • dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties):
  • dom/Element.h:
11:29 AM Changeset in webkit [84527] by ggaren@apple.com
  • 38 edits
    1 add in trunk/Source/WebCore

2011-04-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed a use of markDOMObjectWrapper: CSS Object Model
​https://bugs.webkit.org/show_bug.cgi?id=59057

This is 24 hours of my life I will never get back. Thank you, W3C.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Build!
  • bindings/js/JSCSSFontFaceRuleCustom.cpp:
  • bindings/js/JSCSSImportRuleCustom.cpp:
  • bindings/js/JSCSSMediaRuleCustom.cpp:
  • bindings/js/JSCSSPageRuleCustom.cpp:
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRuleOwner::isReachableFromOpaqueRoots): (WebCore::JSCSSRuleOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::JSCSSRule::markChildren):
  • bindings/js/JSCSSRuleListCustom.cpp: (WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots): (WebCore::JSCSSRuleListOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS):
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclarationOwner::isReachableFromOpaqueRoots): (WebCore::JSCSSStyleDeclarationOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::JSCSSStyleDeclaration::markChildren): Removed custom mark functions, and replaced with use of the opaque roots system. This has the nice benefit of allowing us to eagerly recycle far more CSS wrappers and their associated DOM wrappers.

(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue): Made this function
custom because it must maintain the sorrowful invariant that primitive
values can be mapped back to objects that are reachable through the DOM.
We maintain this invariant through an external hash table because
making all primitive values bigger would be a too-large memory use
penalty. Luckily, nobody uses this feature, so the cost of the hash table
is no big deal.

(WebCore::toJS): We need a custom toJS so we can specify our own WeakHandleOwner.

  • bindings/js/JSCSSStyleRuleCustom.cpp: Removed custom mark, as above.
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::cssValueRoots): (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots): (WebCore::JSCSSValueOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): Use the opaque roots system. Piggy-back on the external hash table filled by JSCSSStyleDeclaration::getPropertyCSSValue.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::markChildren): No need to mark our stylesheet list, since all style-related objects can use our opaque root to determine liveness.
  • bindings/js/JSMediaListCustom.cpp: Added. (WebCore::JSMediaListOwner::isReachableFromOpaqueRoots): (WebCore::JSMediaListOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Use the opaque roots system.
  • bindings/js/JSNodeCustom.h: (WebCore::root): Added helpers for computing style-related roots.
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheetOwner::isReachableFromOpaqueRoots): (WebCore::JSStyleSheetOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::JSStyleSheet::markChildren): Use the opaque roots system instead of direct marking.


  • bindings/js/JSStyleSheetListCustom.cpp: (WebCore::JSStyleSheetListOwner::isReachableFromOpaqueRoots): (WebCore::JSStyleSheetListOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Ditto.
  • bindings/js/JSWebKitCSSKeyframeRuleCustom.cpp:
  • bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp:
  • css/CSSFontFaceRule.idl:
  • css/CSSImportRule.idl: No more custom mark, since we use the opaque roots system instead.
  • css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::CSSMediaRule): Fixed a bug where a media rule would incorrectly have no parent, since this got in the way of correctly computing the media rule's root.
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/MediaList.idl: Match behavior changes above.
  • css/StyleBase.cpp: (WebCore::StyleBase::node): Helper function for computing roots of the style system. This object model is pretty weird and not very well factored, but I'm pretty sure this covers all the relevant cases.
  • css/StyleBase.h:
  • css/StyleSheetList.idl:
  • css/WebKitCSSKeyframeRule.idl:
  • css/WebKitCSSKeyframesRule.idl: Updated to match the behavior changes above.
11:29 AM Changeset in webkit [84526] by ap@apple.com
  • 14 edits in trunk/Source/WebKit2

Reviewed by Maciej Stachowiak.

WebKit2: Unconfirmed inline input session persists after reload
​https://bugs.webkit.org/show_bug.cgi?id=59054
<rdar://problem/9291086>

Makes the inline input get properly confirmed or discarded when changing selection,
navigating to another page, focusing another view in the window, or after a web process
crash.

  • Shared/EditorState.h: (WebKit::EditorState::EditorState):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::editorState): Added a variable that Editor sets while processing input method calls. We don't want selection changes caused by -setMarkedText: discard the composition!


  • UIProcess/PageClient.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::updateTextInputState): (WebKit::PageClientImpl::resetTextInputState): Extended updateSecureInputState() to potentially confirm the current inline input session. Added resetTextInputState, which is to be called when we get out of the current web page.
  • UIProcess/API/mac/WKView.mm: (-[WKView resignFirstResponder]): Just call _resetTextInputState instead of dealing with input state here. (-[WKView _updateSecureInputState]): Use _isFocused to make the code simpler. (-[WKView _updateTextInputStateIncludingSecureInputState:]): Confirm the current inline input session if selection changed for any other reason but an input method changing the composition. We will want to do other work here, like dismissing a dictionary pop-up, updating a font panel etc. (-[WKView _resetTextInputState]): Added. We don't want secure text input persist after navigations, crashes an such, and we also don't want input methods to remember inline input state. Relying on selection changed notifications is fragile and insufficient.
  • UIProcess/API/mac/WKViewInternal.h: Added internal functions to keep the build unbroken.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): This is the best chance we have to reset input state for a new page. This doesn't work well for cached page loads, but WK1 is quite broken in that case, too. (WebKit::WebPageProxy::editorStateChanged): Moved some logic up to the client, since the function now does much more than before.
  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::confirmCompositionWithoutDisturbingSelection):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::confirmCompositionWithoutDisturbingSelection): Added confirmCompositionWithoutDisturbingSelection(). When we confirm the composition due to selection change, we obvisouly don't want the selection to move back.
11:28 AM Changeset in webkit [84525] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-04-21 Ojan Vafai <​ojan@chromium.org>

Reviewed by Mihai Parparita.

fix another innocuous JS error in expand/collapseAllExpectations
​https://bugs.webkit.org/show_bug.cgi?id=59122

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
11:19 AM Changeset in webkit [84524] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-04-21 Sam Weinig <​sam@webkit.org>

Reviewed by Simon Fraser.

Remove warnings from DrawingAreaImpl and related classes
​https://bugs.webkit.org/show_bug.cgi?id=59120

DrawingAreaImpl is mature enough for others to adopt. Remove warnings.

  • UIProcess/BackingStore.cpp:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/LayerTreeHost.cpp:
10:57 AM Changeset in webkit [84523] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-04-21 Sam Weinig <​sam@webkit.org>

Reviewed by Simon Fraser.

Deploy GraphicsContextStateSaver in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=59116

  • UIProcess/FindIndicator.cpp: (WebKit::FindIndicator::draw):
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::paint):
  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::drawRect):
  • WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::drawRect):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect): (WebKit::WebPage::drawPageOverlay):
10:56 AM Changeset in webkit [84522] by krit@webkit.org
  • 27 edits
    69 adds in trunk

2011-04-21 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feDropShadow implementation of SVG Filters 1.2
​https://bugs.webkit.org/show_bug.cgi?id=52513

Added dynamic update tests for FEDropShadow as well as a basic pixel test.

  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
  • platform/mac/svg/filters/feDropShadow-expected.checksum: Added.
  • platform/mac/svg/filters/feDropShadow-expected.png: Added.
  • platform/mac/svg/filters/feDropShadow-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr.html: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr.html: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop.html: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop.html: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop.html:
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop.html:
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop.html:
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop.html:
  • svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-dx-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-dy-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-shadow-color-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-shadow-opacity-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-stdDeviation-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-dx-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-dy-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-in-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-shadow-color-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-stdDeviation-prop.js: Added. (executeTest):
  • svg/filters/feDropShadow.svg: Added.

2011-04-21 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feDropShadow implementation of SVG Filters 1.2
​https://bugs.webkit.org/show_bug.cgi?id=52513

  • MigrateHeaders.make:

2011-04-21 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feDropShadow implementation of SVG Filters 1.2
​https://bugs.webkit.org/show_bug.cgi?id=52513

This is the implementation of feDropShadow, a shorthand filter and a combination of feGaussianBlur,
feOffset, feFlood and feComposite to create a drop shadow of an input effect.
Creating this new filter effect makes it possible to optimize the often used workflow. ShadowBlur, with its
fast blurring algorithm, is used to blur the shadow and composite operators are responsible for combining the
source with different colored shadows.
Shadow color and opacity can be set with the properties flood-color and flood-opacity.

Tests: svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr.html

svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html
svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html
svg/filters/feDropShadow.svg

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap):
  • bindings/objc/DOMSVG.h:
  • page/DOMWindow.idl:
  • platform/graphics/ShadowBlur.cpp: Added missing copyright after r84410.
  • platform/graphics/ShadowBlur.h: Made blurLayerImage public.
  • platform/graphics/filters/FEDropShadow.cpp: Added. (WebCore::FEDropShadow::FEDropShadow): (WebCore::FEDropShadow::create): (WebCore::FEDropShadow::determineAbsolutePaintRect): (WebCore::FEDropShadow::apply): (WebCore::FEDropShadow::dump): (WebCore::FEDropShadow::externalRepresentation):
  • platform/graphics/filters/FEDropShadow.h: Added. (WebCore::FEDropShadow::stdDeviationX): (WebCore::FEDropShadow::setStdDeviationX): (WebCore::FEDropShadow::stdDeviationY): (WebCore::FEDropShadow::setStdDeviationY): (WebCore::FEDropShadow::dx): (WebCore::FEDropShadow::setDx): (WebCore::FEDropShadow::dy): (WebCore::FEDropShadow::setDy): (WebCore::FEDropShadow::shadowColor): (WebCore::FEDropShadow::setShadowColor): (WebCore::FEDropShadow::shadowOpacity): (WebCore::FEDropShadow::setShadowOpacity):
  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::calculateKernelSize): Make kernel calculations accessible for feDropShadow.
  • platform/graphics/filters/FEGaussianBlur.h:
  • svg/SVGAllInOne.cpp:
  • svg/SVGFEDropShadowElement.cpp: Added. (WebCore::SVGFEDropShadowElement::SVGFEDropShadowElement): (WebCore::SVGFEDropShadowElement::create): (WebCore::SVGFEDropShadowElement::stdDeviationXIdentifier): (WebCore::SVGFEDropShadowElement::stdDeviationYIdentifier): (WebCore::SVGFEDropShadowElement::setStdDeviation): (WebCore::SVGFEDropShadowElement::parseMappedAttribute): (WebCore::SVGFEDropShadowElement::svgAttributeChanged): (WebCore::SVGFEDropShadowElement::synchronizeProperty): (WebCore::SVGFEDropShadowElement::build):
  • svg/SVGFEDropShadowElement.h: Added.
  • svg/SVGFEDropShadowElement.idl: Added.
  • svg/svgtags.in:
10:47 AM Changeset in webkit [84521] by morrita@google.com
  • 3 edits in trunk/LayoutTests

2011-04-21 MORITA Hajime <​morrita@google.com>

Unreviewed expectations update following r84511.

  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-open2-expected.txt:
10:44 AM Changeset in webkit [84520] by rolandsteiner@chromium.org
  • 18 edits
    2 adds in trunk

2011-04-20 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 58704 - Decide on node type for ShadowRoot
​https://bugs.webkit.org/show_bug.cgi?id=58704

Test node types of shadow host, shadow root and first shadow child.

  • fast/dom/shadow/nodetype-expected.txt: Added.
  • fast/dom/shadow/nodetype.html: Added.

2011-04-21 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 58704 - Decide on node type for ShadowRoot
​https://bugs.webkit.org/show_bug.cgi?id=58704

Add a new node type SHADOW_ROOT_NODE.
Adapt all calling sites of nodeType().

Test: fast/dom/shadow/nodetype.html

  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline):
  • bindings/objc/DOM.mm: (kitClass):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::toV8Slow):
  • dom/Document.cpp: (WebCore::Document::importNode): (WebCore::Document::childTypeAllowed): (WebCore::Document::canReplaceChild):
  • dom/Node.cpp: (WebCore::Node::dumpStatistics): (WebCore::Node::isDefaultNamespace): (WebCore::Node::lookupPrefix): (WebCore::Node::lookupNamespaceURI): (WebCore::appendTextContent): (WebCore::Node::setTextContent):
  • dom/Node.h:
  • dom/Range.cpp: (WebCore::lengthOfContentsInNode): (WebCore::Range::processContentsBetweenOffsets): (WebCore::Range::insertNode): (WebCore::Range::checkNodeWOffset): (WebCore::Range::checkNodeBA): (WebCore::Range::selectNode): (WebCore::Range::selectNodeContents): (WebCore::Range::surroundContents):
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::nodeType):
  • dom/Traversal.cpp: (WebCore::Traversal::acceptNode):
  • editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::appendStartMarkup):
  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isRootNode): (WebCore::HTMLElementStack::pushRootNode):
  • html/parser/HTMLElementStack.h: (WebCore::isInHTMLNamespace):
  • xml/XPathUtil.cpp: (WebCore::XPath::isValidContextNode):

2011-04-21 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 58704 - Decide on node type for ShadowRoot
​https://bugs.webkit.org/show_bug.cgi?id=58704

Add a new enum entry to WebNode::NodeType for shadow roots.
Adapt calling sites for new SHADOW_ROOT_NODE node type.

  • public/WebNode.h:
  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::buildContentForNode):
10:43 AM Changeset in webkit [84519] by jberlin@webkit.org
  • 8 edits in trunk/Source/WebKit2

WebKit2: Need a way to get a snapshot of the visible contents of a page from the UI Process.
​https://bugs.webkit.org/show_bug.cgi?id=59035

Reviewed by Sam Weinig.

Added a sync call from the UI Process to the Web Process with comments saying that it should
be removed as soon as possible.

  • UIProcess/API/C/WKPage.cpp:

(WKPageVisibleContentsSnapshot):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createSnapshotOfVisibleContent):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createSnapshotOfVisibleContent):
Ask the FrameView for the visibleContentRect, and call scaledSnapshotInDocumentCoordinates
with a scale factor of 1 (which preserves the current scaling of the page - e.g. if the
page is already zoomed then the snapshot will reflect the zoomed content).

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
10:43 AM Changeset in webkit [84518] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-04-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

put unexpected passes into their own table
​https://bugs.webkit.org/show_bug.cgi?id=59016

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
10:37 AM Changeset in webkit [84517] by Dimitri Glazkov
  • 8 edits
    2 adds in trunk

2011-04-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION (r75543): Styles bleed into new shadow DOM (like slider and video)
​https://bugs.webkit.org/show_bug.cgi?id=52917

  • fast/css/shadow-dom-scope-expected.txt: Added.
  • fast/css/shadow-dom-scope.html: Added.

2011-04-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION (r75543): Styles bleed into new shadow DOM (like slider and video)
​https://bugs.webkit.org/show_bug.cgi?id=52917

In order to determine whether a rule should apply inside of a shadow DOM subtree,
we collect three pieces of information:

1) Are we parsing UA sheets?
2) Does the current tree scope allows applying author sheets?
3) Does the rule explicitly reach into shadow DOM (using pseudo-elements, for example)?

If the answer to all of these is no, we ignore the rule.

Test: fast/css/shadow-dom-scope.html

  • css/CSSStyleSelector.cpp: (WebCore::MatchingUARulesScope::MatchingUARulesScope): Added a scope helper to

track whether we are currently matching UA rules.

(WebCore::CSSStyleSelector::matchRulesForList): Added the check for three

conditions mentioned above.

(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker): Added

initializer for the flag, which helps us determine whether the rule
explicitly reaches into shadow DOM.

(WebCore::CSSStyleSelector::matchUARules): Started using the scope helper.
(WebCore::CSSStyleSelector::checkSelector): Added initializing of the

flag.

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added setting

of the flag when we encounter unknown pseudo-elements.

  • css/CSSStyleSelector.h: Adjusted decls.
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::applyAuthorSheets): Added.
  • dom/ShadowRoot.h: Adjusted decls.
  • dom/TreeScope.cpp: (WebCore::TreeScope::applyAuthorSheets): Added.
  • dom/TreeScope.h: Adjusted decls.
10:24 AM Changeset in webkit [84516] by leviw@chromium.org
  • 3 edits
    4 adds in trunk

2011-04-21 Levi Weintraub <​leviw@chromium.org>

Reviewed by Simon Fraser.

position fixed element does not render properly when dynamically updated via javascript
​https://bugs.webkit.org/show_bug.cgi?id=54297

Disabling the LayoutState fast-path for fixed-position content.

Tests: fast/repaint/fixed-contents-changed-after-scroll.html

fast/repaint/transformed-contents-changed-after-scroll.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint):

2011-04-21 Levi Weintraub <​leviw@chromium.org>

Reviewed by Simon Fraser.

position fixed element does not render properly when dynamically updated via javascript
​https://bugs.webkit.org/show_bug.cgi?id=54297

Disabling the LayoutState fast-path for fixed-position content.

  • fast/repaint/fixed-contents-changed-after-scroll.html: Added.
  • fast/repaint/transformed-contents-changed-after-scroll.html: Added.
  • platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.checksum: Added.
  • platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.png: Added.
  • platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.txt: Added.
  • platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.checksum: Added.
  • platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.png: Added.
  • platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.txt: Added.
10:23 AM Changeset in webkit [84515] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-20 Michael Saboff <​msaboff@apple.com>

Reviewed by Geoff Garen.

JSString::resolveRope inefficient for common 2 fiber case
​https://bugs.webkit.org/show_bug.cgi?id=58994

Split JSString::resolveRope into three routines.
resolveRope allocates the new buffer and handles the 1 or 2
fiber case with single level fibers.
resolveRopeSlowCase handles the general case.
outOfMemory handles the rare out of memory exception case.

  • runtime/JSString.cpp: (JSC::JSString::resolveRope): (JSC::JSString::resolveRopeSlowCase): (JSC::JSString::outOfMemory):
  • runtime/JSString.h:
10:20 AM Rebaseline edited by senorblanco@chromium.org
(diff)
10:16 AM Changeset in webkit [84514] by ojan@chromium.org
  • 2 edits
    1 add in trunk/Tools

2011-04-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

initial set of tests for new results.html file
​https://bugs.webkit.org/show_bug.cgi?id=59031

Also, fix the bugs (mostly innocuous JS errors) the tests found.

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_test.js: Added.
10:12 AM Changeset in webkit [84513] by tony@chromium.org
  • 2 edits
    6 adds
    7 deletes in trunk/LayoutTests

2011-04-21 Tony Chang <​tony@chromium.org>

Unreviewed. Fixed the last set of tests that are missing pngs.
Created new png baselines on my Leopard machine.

  • platform/chromium-mac-leopard/fast/blockflow/english-bt-text-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/english-bt-text-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/svg-as-border-image-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/borders/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/value-list-out-of-bounds-crash-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/group-opacity-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/group-opacity-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Removed. Matches platform/mac.
  • platform/chromium/test_expectations.txt:
10:11 AM Rebaseline edited by senorblanco@chromium.org
(diff)
9:57 AM Changeset in webkit [84512] by mdelaney@apple.com
  • 3 edits
    2 adds in trunk

2011-04-20 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

Content of <summary> should be forwarded through the shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=58914

  • Added test cases for dynamic DOM change.
  • Updated expectations details-open2.html because generated RenderTree slightly changed.
  • fast/html/details-add-summary-child-1.html: Added.
  • fast/html/details-add-summary-child-2.html: Added.
  • fast/html/details-remove-summary-child-1.html: Added.
  • fast/html/details-remove-summary-child-2.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/html/details-add-summary-child-1-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-child-1-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-child-2-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-child-2-expected.txt: Added.
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-child-1-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-child-1-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-child-2-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-child-2-expected.txt: Added.

2011-04-20 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Maciej Stachowiak.

arc() should add a circle to the path when start and end angles are far enough apart
​https://bugs.webkit.org/show_bug.cgi?id=58934

Test: fast/canvas/canvas_arc_largeangles.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arc):
9:51 AM Changeset in webkit [84511] by morrita@google.com
  • 14 edits
    1 copy
    16 adds in trunk

2011-04-20 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

Content of <summary> should be forwarded through the shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=58914

  • Added test cases for dynamic DOM change.
  • Updated expectations details-open2.html because generated RenderTree slightly changed.
  • fast/html/details-add-summary-child-1.html: Added.
  • fast/html/details-add-summary-child-2.html: Added.
  • fast/html/details-remove-summary-child-1.html: Added.
  • fast/html/details-remove-summary-child-2.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/html/details-add-summary-child-1-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-child-1-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-child-2-expected.checksum: Added.
  • platform/mac/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/mac/fast/html/details-add-summary-child-2-expected.txt: Added.
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-child-1-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-child-1-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-child-2-expected.checksum: Added.
  • platform/mac/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/mac/fast/html/details-remove-summary-child-2-expected.txt: Added.

2011-04-20 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

Content of <summary> should be forwarded through the shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=58914

  • Introduced ShadowContentElement which hosts forwarded children of <summary>
  • Encapsulated Node::parentNodeForRenderingAndStyle() and shouldCreateRendererFor() into NodeVisualParentLookupResult class.
  • The parent lookup is also aware of node forwarding. If the visual parent node has a shadow root, the node is possibly forwarded to ShadowContentElement
  • ShadowContentElement lookup is implemented inside ShadowRoot.

Tests: fast/html/details-add-summary-child-1.html

fast/html/details-add-summary-child-2.html
fast/html/details-remove-summary-child-1.html
fast/html/details-remove-summary-child-2.html

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.cpp: (WebCore::Element::childrenChanged):
  • dom/Node.cpp: (WebCore::NodeRenderParentDetector::NodeRenderParentDetector): (WebCore::NodeRenderParentDetector::parentNodeForRenderingAndStyle): (WebCore::NodeRenderParentDetector::findVisualParent): (WebCore::NodeRenderParentDetector::shouldCreateRenderer): (WebCore::Node::parentNodeForRenderingAndStyle): (WebCore::Node::createRendererAndStyle):
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::contentContainerFor): (WebCore::ShadowRoot::hostChildrenChanged): (WebCore::ShadowRoot::firstContentElement):
  • dom/ShadowRoot.h:
  • html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::createShadowSubtree):
  • html/HTMLSummaryElement.h:
  • html/shadow/ShadowContentElement.h: Copied from Source/WebCore/dom/ShadowRoot.h. (WebCore::ShadowContentElement::ShadowContentElement): (WebCore::ShadowContentElement::isShadowBoundary): (WebCore::ShadowContentElement::createRenderer): (WebCore::ShadowContentElement::create):
9:40 AM Changeset in webkit [84510] by caseq@chromium.org
  • 6 edits in trunk

011-04-21 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor
​https://bugs.webkit.org/show_bug.cgi?id=59105

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatobject):
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane.prototype._setObject):
  • inspector/front-end/ResourceJSONView.js: (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
9:38 AM Changeset in webkit [84509] by mdelaney@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

2011-04-20 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Adam Roben.

Move toDataURL.jpeg.alpha expected result out of /mac-snowleopard and into /mac
​https://bugs.webkit.org/show_bug.cgi?id=59038

  • platform/mac-snowleopard/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Copied from LayoutTests/platform/mac-snowleopard/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt.
9:32 AM Changeset in webkit [84508] by Philippe Normand
  • 7 edits in trunk

2011-04-21 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] missing LayoutTestController::callShouldCloseOnWebView()
​https://bugs.webkit.org/show_bug.cgi?id=59086

  • platform/gtk/Skipped: Unskip fast/events/onbeforeunload-focused-iframe.html

callShouldCloseOnWebView() implementation.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::callShouldCloseOnWebView):

DRT::shouldClose(), used by the LayoutController.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::shouldClose):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
9:24 AM Changeset in webkit [84507] by Philippe Normand
  • 7 edits
    3 adds in trunk

2011-04-21 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT: implement eventSender.scalePageBy
​https://bugs.webkit.org/show_bug.cgi?id=59082

Unskipped tests that should pass now that
eventSender.scalePageBy() is supported in GTK.

  • platform/gtk/Skipped:
  • platform/gtk/fast/repaint/scale-page-shrink-expected.checksum: Added.
  • platform/gtk/fast/repaint/scale-page-shrink-expected.png: Added.
  • platform/gtk/fast/repaint/scale-page-shrink-expected.txt: Added.
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::scalePageBy):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • DumpRenderTree/gtk/EventSender.cpp: (scalePageByCallback): scalePageBy() support.
9:18 AM Changeset in webkit [84506] by abarth@webkit.org
  • 4 edits in trunk

2011-04-21 Adam Barth <​abarth@webkit.org>

Update results to show failure.

  • http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:

2011-04-21 Adam Barth <​abarth@webkit.org>

Remove support for CSP's frame-src. This approach causes too many
extra console messages to be logged. I'm leaving in the test (which
now shows failure).

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):
8:58 AM Changeset in webkit [84505] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-21 Eunsol Park <​eunsol47.park@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Scroll doesn't work on tiled backing store.
​https://bugs.webkit.org/show_bug.cgi?id=55021

It was added from Changeset 72242, but it worked wrong in EFL port.
The visible rect should not be returned as content rect for scrolling in EFL tiled backing store,
because it works differently from QT.

  • platform/ScrollView.cpp: (WebCore::ScrollView::visibleContentRect):
8:55 AM Changeset in webkit [84504] by Simon Fraser
  • 45 edits in trunk/Source/WebCore

2011-04-21 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel.

Create RIAA class for GraphicsContext::save() and restore()
​https://bugs.webkit.org/show_bug.cgi?id=58807

Use GraphicsContextStateSaver in a lot more places.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::draw):
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::save): (WebCore::GraphicsContextStateSaver::restore):
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::drawShadowBuffer): (WebCore::ShadowBlur::drawRectShadowWithoutTiling): (WebCore::ShadowBlur::drawInsetShadowWithoutTiling): (WebCore::ShadowBlur::drawInsetShadowWithTiling): (WebCore::ShadowBlur::drawRectShadowWithTiling): (WebCore::ShadowBlur::drawLayerPieces):
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::draw):
  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::paint):
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
  • platform/mac/ThemeMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio): (WebCore::paintStepper):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paintSelection):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::paintSelection):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorationsWithSize):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paintReplaced):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::paintChildLayerIntoColumns):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintMeter): (WebCore::RenderThemeMac::paintProgressBar): (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintMenuListButton): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsButton): (WebCore::RenderThemeMac::paintMediaSliderTrack): (WebCore::RenderThemeMac::paintMediaCurrentTime): (WebCore::RenderThemeMac::paintMediaTimeRemaining):
  • rendering/mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::paint):
  • rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
  • rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):
  • rendering/mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
  • rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::paint):
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::paint):
  • rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyClippingToContext):
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::draw):
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint):
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintSelectionBackground): (WebCore::SVGInlineTextBox::paint): (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
  • rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
  • svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw):
8:39 AM Changeset in webkit [84503] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Tony Gentilcore <​tonyg@chromium.org>

[chromium] inspector/console/console-log-before-inspector-open.html times out on mac
​https://bugs.webkit.org/show_bug.cgi?id=59106

Seems to have started timing out in 84470-84471 which were expectations
updates.

  • platform/chromium/test_expectations.txt:
8:38 AM Changeset in webkit [84502] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2011-04-21 Adam Barth <​abarth@webkit.org>

Reviewed by Tony Gentilcore.

Make test robust to PHP magic quotes
​https://bugs.webkit.org/show_bug.cgi?id=59104

  • http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
  • http/tests/security/contentSecurityPolicy/resources/save-report.php:
8:21 AM Changeset in webkit [84501] by yi.4.shen@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-04-21 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Fix the style issue for Api/qwebkitplatformplugin.h
​https://bugs.webkit.org/show_bug.cgi?id=59097

Fix the style issues for Api/qwebkitplatformplugin.h found by the webkit-check-style.

  • Api/qwebkitplatformplugin.h:
8:07 AM Changeset in webkit [84500] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Tony Gentilcore <​tonyg@chromium.org>

[chromium] Temporarily skip new contentSecurityPolicy tests
​https://bugs.webkit.org/show_bug.cgi?id=59103

Tests introduced by ​http://trac.webkit.org/changeset/84478

  • platform/chromium/test_expectations.txt:
7:59 AM Changeset in webkit [84499] by caseq@chromium.org
  • 5 edits in trunk

2011-04-20 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] console API is not exposed to code evaluated by sidebar.setExpression()
​https://bugs.webkit.org/show_bug.cgi?id=59006

  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane.prototype.setExpression):

2011-04-20 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Expose console API to the code evaluated by sidebar.setExpression()

Web Inspector: [Extensions API] console API is not exposed to code evaluated by sidebar.setExpression()
​https://bugs.webkit.org/show_bug.cgi?id=59006

  • inspector/extensions/extensions-expected.txt:
  • inspector/extensions/extensions.html:
7:22 AM Changeset in webkit [84498] by Nikolas Zimmermann
  • 15 edits
    2 copies in trunk/Source/WebCore

2011-04-21 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Split SVGGlyphIdentifier class out of SVGGlyphElement.h
​https://bugs.webkit.org/show_bug.cgi?id=59101

Move SVGGlyphIdentifier class out of SVGGlyphElement.h, place it in platform/graphics/SVGGlyph.h
and rename the contained struct to SVGGlyph. It will be used in follow-up patches that will integrate SVGGlyph & GlyphPage.

Several utility functions are moved from SVGFont.cpp to SVGGlyph.cpp, as that's the place where they really belong to.
Renamed nameLength to unicodeStringLength in the SVGGlyph struct for clarity.

  • Android.mk: Add SVGGlyph.cpp/h to build.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/SVGGlyph.cpp: Copied from svg/SVGFont.cpp. Removed everything except the methods listed below, that belong here. (WebCore::processArabicFormDetection): (WebCore::charactersWithArabicForm): (WebCore::isCompatibleArabicForm): (WebCore::isCompatibleGlyph):
  • platform/graphics/SVGGlyph.h: Copied from svg/SVGGlyphElement.h. Renamed SVGGlyphIdentifier to SVGGlyph. (WebCore::SVGGlyph::SVGGlyph): (WebCore::SVGGlyph::operator==):
  • platform/graphics/SimpleFontData.cpp: Adapt for SVGGlyphIdentifier -> SVGGlyph and nameLength -> unicodeStringLength rename. (WebCore::SimpleFontData::SimpleFontData):
  • svg/SVGFont.cpp: Ditto. Remove helper functions that are now living in SVGGlyph.cpp (WebCore::SVGTextRunWalker::walk): (WebCore::floatWidthUsingSVGFontCallback): (WebCore::drawTextUsingSVGFontCallback): (WebCore::drawTextMissingGlyphCallback): (WebCore::Font::drawTextUsingSVGFont):
  • svg/SVGFontElement.cpp: Ditto. (WebCore::SVGFontElement::getGlyphIdentifiersForString):
  • svg/SVGFontElement.h: Ditto.
  • svg/SVGGlyphElement.cpp: Ditto. (WebCore::parseArabicForm): (WebCore::parseOrientation): (WebCore::SVGGlyphElement::inheritUnspecifiedAttributes): (WebCore::parseSVGGlyphAttribute): (WebCore::SVGGlyphElement::buildGenericGlyphIdentifier): (WebCore::SVGGlyphElement::buildGlyphIdentifier):
  • svg/SVGGlyphElement.h: Ditto.
  • svg/SVGGlyphMap.h: Ditto. (WebCore::SVGGlyphMap::add): (WebCore::SVGGlyphMap::compareGlyphPriority): (WebCore::SVGGlyphMap::get):
7:10 AM Changeset in webkit [84497] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

2011-04-21 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Live streams won't play with AVFoundation backend
​https://bugs.webkit.org/show_bug.cgi?id=58961
rdar://problem/9284748

Tested manually because we don't have any live streams to test in DRT.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::seek): Do nothing when asked to seek to the

current time.

(WebCore::MediaPlayerPrivateAVFoundation::updateStates): If the readyState is HaveEnoughData,

don't revert when the new state is "ready to play" or "buffer full".

(WebCore::MediaPlayerPrivateAVFoundation::movieLoadType): Use new convenience function isLiveStream.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: (WebCore::MediaPlayerPrivateAVFoundation::isLiveStream): New.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Don't use AVAsset's

tracksWithMediaCharacteristic because it doesn't give us what we need with live
streams.

7:08 AM Changeset in webkit [84496] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Tony Gentilcore <​tonyg@chromium.org>

[chromium] Correct expecations for editing/selection/designmode-no-caret.html
​https://bugs.webkit.org/show_bug.cgi?id=59088

Straighten out bad override in designmode-no-caret.html

  • platform/chromium/test_expectations.txt:
6:51 AM Changeset in webkit [84495] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-21 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Cookies section in empty on page re-launch.
​https://bugs.webkit.org/show_bug.cgi?id=59095

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._reset): (WebInspector.ResourcesPanel.prototype._frameNavigated):
6:49 AM Changeset in webkit [84494] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-21 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: rename De-obfuscate to Pretty print.
​https://bugs.webkit.org/show_bug.cgi?id=59093

  • English.lproj/localizedStrings.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
6:48 AM Changeset in webkit [84493] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-21 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: following Image URL link in the network panel does nothing.
​https://bugs.webkit.org/show_bug.cgi?id=59092

  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad): (WebInspector.ImageView.prototype._createContentIfNeeded):
  • inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
6:46 AM Changeset in webkit [84492] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-04-21 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: implement Go To Line for network panel.
​https://bugs.webkit.org/show_bug.cgi?id=59090

  • inspector/front-end/GoToLineDialog.js: (WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView.prototype._tabSelected): (WebInspector.NetworkItemView.prototype._installHighlightSupport):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel):
  • inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane.prototype.appendTab): (WebInspector.TabbedPane.prototype.selectTab):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.highlightLine):
6:45 AM Changeset in webkit [84491] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some newly-failing tests on Windows

<​http://webkit.org/b/59098> and <​http://webkit.org/b/59099> track the failures.

  • platform/win/Skipped: Added fast/transforms/selection-bounds-in-transformed-view.html and

http/tests/security/contentSecurityPolicy/frame-src-blocked.html.

6:34 AM Changeset in webkit [84490] by Nikolas Zimmermann
  • 6 edits
    1 copy in trunk/Source/WebCore

2011-04-21 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Split GlyphPage from GlyphPageTreeNode.h into its own header
​https://bugs.webkit.org/show_bug.cgi?id=59096

  • GNUmakefile.list.am: Add GlyphPage.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/GlyphPage.h: Copied from platform/graphics/GlyphPageTreeNode.h. Removed GlyphPageTreeNode class, leaving only GlyphPage.
  • platform/graphics/GlyphPageTreeNode.h: Removed GlyphPage class.
6:07 AM Changeset in webkit [84489] by Nikolas Zimmermann
  • 8 edits
    1 add in trunk/Source/WebCore

2011-04-21 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Centralize typedef unsigned short Glyph in Glyph.h
​https://bugs.webkit.org/show_bug.cgi?id=59087

  • GNUmakefile.list.am: Add Glyph.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/Glyph.h: Added.
  • platform/graphics/GlyphBuffer.h: Include Glyph.h instead of duplicating the Glyph typedef.
  • platform/graphics/GlyphMetricsMap.h: Ditto.
  • platform/graphics/GlyphPageTreeNode.h: Ditto.
5:45 AM Changeset in webkit [84488] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Tony Gentilcore <​tonyg@chromium.org>

BitmapImage::destroyMetadataAndNotify should clear m_checkedForSolidColor
​https://bugs.webkit.org/show_bug.cgi?id=58926

Remove chromium's crashing expectations.

  • platform/chromium/test_expectations.txt:
5:33 AM Changeset in webkit [84487] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Tony Gentilcore <​tonyg@chromium.org>

[chromium] Correct expecations for editing/selection/designmode-no-caret.html
​https://bugs.webkit.org/show_bug.cgi?id=59088

​http://trac.webkit.org/changeset/84470 seemed to have caused a conflict. This
has always been failing on Win Debug.

  • platform/chromium/test_expectations.txt:
5:28 AM Changeset in webkit [84486] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed.

REGRESSION (WK2): Animated GIF stops when navigating forward, back
​https://bugs.webkit.org/show_bug.cgi?id=59042

  • platform/qt-wk2/Skipped: Add fast/images/animated-gif-restored-from-bfcache.html,

because WebKit2 since it doesn't implement layoutTestController.overridePreference().

5:24 AM Changeset in webkit [84485] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-21 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: toolbar background is blank on Mac Chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=59089

  • inspector/front-end/inspector.css: (body.detached.platform-mac-snowleopard:not(.remote) #toolbar):
5:05 AM Changeset in webkit [84484] by pfeldman@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-04-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add support for Go To Line in Resources panel.
​https://bugs.webkit.org/show_bug.cgi?id=59077

  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/GoToLineDialog.js: (WebInspector.GoToLineDialog.show): (WebInspector.GoToLineDialog.createShortcut): (WebInspector.GoToLineDialog.prototype._onKeyDown):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.handleShortcut):
  • inspector/front-end/Panel.js: (WebInspector.Panel): (WebInspector.Panel.prototype._restoreScrollPositions): (WebInspector.Panel.prototype.handleShortcut): (WebInspector.Panel.prototype.registerShortcuts): (WebInspector.Panel.prototype._showGoToLineDialog):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.handleShortcut):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._registerShortcuts): (WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
  • inspector/front-end/inspector.js: (WebInspector._registerShortcuts): (WebInspector.documentKeyDown):
4:43 AM Changeset in webkit [84483] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-21 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: persist local resource history between inspector / browser launches.
​https://bugs.webkit.org/show_bug.cgi?id=58993

  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._restoreRevisions):
3:51 AM Changeset in webkit [84482] by Philippe Normand
  • 1 edit
    3 adds in trunk/LayoutTests

2011-04-21 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for test added in r84398.

  • platform/gtk/fast/borders/bidi-012-expected.checksum: Added.
  • platform/gtk/fast/borders/bidi-012-expected.png: Added.
  • platform/gtk/fast/borders/bidi-012-expected.txt: Added.
2:53 AM Changeset in webkit [84481] by apavlov@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-04-20 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Metrics pane editing and visual feedback improvements
​https://bugs.webkit.org/show_bug.cgi?id=58992

Added visual feedback when hovering over the box model components of the Metrics pane
and handling of the [Page]Up/Down keys when editing the box model values.

  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
  • inspector/DOMNodeHighlighter.h:
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::mouseDidMoveOverElement): (WebCore::InspectorDOMAgent::highlight): (WebCore::InspectorDOMAgent::highlightDOMNode): (WebCore::InspectorDOMAgent::highlightFrame): (WebCore::InspectorDOMAgent::drawNodeHighlight):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSProperty.prototype.setText.callback): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setValue): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.startEditingStyle): (WebInspector.ElementsPanel.prototype.endEditingStyle): (WebInspector.ElementsPanel.prototype._attributesUpdated):
  • inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane): (WebInspector.MetricsSidebarPane.prototype._highlightDOMNode): (WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.getBoxRectangleElement): (WebInspector.MetricsSidebarPane.prototype._update.createBoxPartElement): (WebInspector.MetricsSidebarPane.prototype._update): (WebInspector.MetricsSidebarPane.prototype.startEditing): (WebInspector.MetricsSidebarPane.prototype._handleKeyDown): (WebInspector.MetricsSidebarPane.prototype.editingEnded): (WebInspector.MetricsSidebarPane.prototype.editingCancelled): (WebInspector.MetricsSidebarPane.prototype._applyUserInput.callback): (WebInspector.MetricsSidebarPane.prototype._applyUserInput): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.alteredFloatNumber): (WebInspector.StylesSidebarPane.alteredHexNumber): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
  • inspector/front-end/inspector.css: (.metrics .hovered > .label): (.metrics .position): (.metrics .margin): (.metrics .margin.hovered): (.metrics .border): (.metrics .border.hovered): (.metrics .padding): (.metrics .padding.hovered): (.metrics .content): (.metrics .content.hovered):
  • inspector/front-end/inspector.js: (WebInspector.highlightDOMNode):
2:39 AM Changeset in webkit [84480] by Philippe Normand
  • 1 edit
    3 adds in trunk/LayoutTests

2011-04-21 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for
http/tests/security/contentSecurityPolicy tests that don't escape
the quote character.

  • platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
1:50 AM Changeset in webkit [84479] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Missing eventSender.scalePageBy() implementation

  • platform/qt/Skipped: Add fast/transforms/selection-bounds-in-transformed-view.html.
1:34 AM Changeset in webkit [84478] by abarth@webkit.org
  • 6 edits
    10 adds in trunk

2011-04-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP report-uri is missing
​https://bugs.webkit.org/show_bug.cgi?id=58639

Test that report-uri sends a report. Testing approach stolen from the
ping tests.

  • http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-uri.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/echo-report.php: Added.
  • http/tests/security/contentSecurityPolicy/resources/go-to-echo-report.js: Added.
  • http/tests/security/contentSecurityPolicy/resources/save-report.php: Added.

2011-04-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP report-uri is missing
​https://bugs.webkit.org/show_bug.cgi?id=58639

Our implementation of report-uri differs from what's currently in the
spec. I sent the working group an email explaining why. Generally,
we're using normal form encoding instead of JSON and we're sending less
information to a wider set of URLs. Specifically, we send the current
document's URL as well as the directive that was violated. The spec
(currently) tells us to send the raw HTTP headers and the URL that
caused the violation, but both of these pieces of data could contain
information that's sensitive, so we omit them for now.

Test: http/tests/security/contentSecurityPolicy/report-uri.html

  • loader/PingLoader.cpp: (WebCore::PingLoader::reportContentSecurityPolicyViolation):
  • loader/PingLoader.h:
  • page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::CSPDirective::text): (WebCore::ContentSecurityPolicy::reportViolation): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::allowEval): (WebCore::ContentSecurityPolicy::allowScriptFromSource): (WebCore::ContentSecurityPolicy::allowObjectFromSource): (WebCore::ContentSecurityPolicy::allowChildFrameFromSource): (WebCore::ContentSecurityPolicy::allowImageFromSource): (WebCore::ContentSecurityPolicy::allowStyleFromSource): (WebCore::ContentSecurityPolicy::allowFontFromSource): (WebCore::ContentSecurityPolicy::allowMediaFromSource): (WebCore::ContentSecurityPolicy::parseReportURI): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
1:07 AM Changeset in webkit [84477] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-04-21 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip
fast/transforms/selection-bounds-in-transformed-view.html on GTK as it
depends on eventSender.scalePageBy().

  • platform/gtk/Skipped:
12:45 AM Changeset in webkit [84476] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-21 Yuta Kitamura <​yutak@chromium.org>

Unreviewed, skip fast/dom/shadow/layout-tests-can-access-shadow.html on Windows.

fast/dom/shadow/layout-tests-can-access-shadow.html is failing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=59081

  • platform/win/Skipped:
12:29 AM Changeset in webkit [84475] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/qt

2011-04-21 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Csaba Osztrogonác.

[Qt] REGRESSION(84057): It made 4 API tests fail
​https://bugs.webkit.org/show_bug.cgi?id=58848

After MIME sniffing support was added, some autotests are failing because
the sniffer doesn't recognize our HTML pages.

This fixes tst_QWebPage::backActionUpdate(), tst_QWebPage::errorPageExtensionInFrameset()
and tst_QWebFrame::horizontalScrollAfterBack().

  • tests/qwebframe/resources/testiframe.html:
  • tests/qwebframe/resources/testiframe2.html: Remove spurious </html> in beginning of the document.
  • tests/qwebpage/resources/framedindex.html:
  • tests/qwebpage/resources/index.html: Add <html> (and </html>) tags, <frameset> is not recognized by the sniffer as a possible starting tag for HTML document.
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::errorPageExtensionInFrameset): Verify if we do have a main frame and the main frame has the children frames we expect. This will avoid crashing if for some reason children frames are not loaded.
12:24 AM Changeset in webkit [84474] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-21 Jon Lee <​jonlee@apple.com>

Reviewed by Maciej Stachowiak.

remove unneeded function from graphicscontext3d.cpp (59076)
​https://bugs.webkit.org/show_bug.cgi?id=59076
<rdar://problem/9315681>

  • platform/graphics/GraphicsContext3D.cpp: removing unused function unpackOneRowOfRGBA8ToRGBA8
12:03 AM Changeset in webkit [84473] by ap@apple.com
  • 5 edits in trunk

2011-04-21 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

REGRESSION: Korean encoding alias KSC5601 does not work
​https://bugs.webkit.org/show_bug.cgi?id=59075
<rdar://problem/9303233>

  • fast/encoding/char-decoding-expected.txt:
  • fast/encoding/char-decoding.html: Added tests for KSC_5601 (which worked, but wasn't tested), and KSC5601 (which was broken).

2011-04-21 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

REGRESSION: Korean encoding alias KSC5601 does not work
​https://bugs.webkit.org/show_bug.cgi?id=59075
<rdar://problem/9303233>

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames): Added a KSC5601 alias for KSC_5601, which effectively makes it windows-949.

Apr 20, 2011:

11:33 PM Changeset in webkit [84472] by commit-queue@webkit.org
  • 33 edits
    2 adds in trunk

2011-04-20 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

layoutTestController can create and destroy shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=59058

Exercise the new layoutTestController methods.

  • fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: Added.
  • fast/dom/shadow/layout-tests-can-access-shadow.html: Added.

2011-04-20 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

layoutTestController can create and destroy shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=59058

Test: fast/dom/shadow/layout-tests-can-access-shadow.html

  • WebCore.exp.in: Mac DRT needs to see Element::ensure/removeShadowRoot

2011-04-20 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

layoutTestController can create and destroy shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=59058

Chromium DRT relies on the Chromium WebKit API

  • public/WebElement.h:
  • src/WebElement.cpp: (WebKit::WebElement::shadowRoot): don't steal a zero refcount (WebKit::WebElement::ensureShadowRoot): added (WebKit::WebElement::removeShadowRoot): added

2011-04-20 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

layoutTestController can create and destroy shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=59058

Support for new methods in GTK DRT.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::ensureShadowRoot): (DumpRenderTreeSupportGtk::removeShadowRoot):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-04-20 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

layoutTestController can create and destroy shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=59058

Support for new methods in Mac DRT.

  • DOM/WebDOMOperations.mm: (-[DOMElement _ensureShadowRoot:]): (-[DOMElement _removeShadowRoot]):
  • DOM/WebDOMOperationsPrivate.h:

2011-04-20 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

layoutTestController can create and destroy shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=59058

Support for new methods in Qt DRT.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::ensureShadowRoot): (DumpRenderTreeSupportQt::removeShadowRoot):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-04-20 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

layoutTestController can create and destroy shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=59058

Support for new methods in WK2 WebKitTestRunner.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (WKBundleNodeHandleCopyElementEnsureShadowRoot): (WKBundleNodeHandleRemoveShadowRoot):
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::InjectedBundleNodeHandle::elementShadowRoot): (WebKit::InjectedBundleNodeHandle::elementEnsureShadowRoot): (WebKit::InjectedBundleNodeHandle::elementRemoveShadowRoot):
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

2011-04-20 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

layoutTestController can create and destroy shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=59058

Chromium, Mac, GTK and Qt DRT; and WK2 test runner.

  • DumpRenderTree/LayoutTestController.cpp: (ensureShadowRootCallback): (removeShadowRootCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::ensureShadowRoot): (LayoutTestController::removeShadowRoot):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::ensureShadowRoot): (LayoutTestController::removeShadowRoot):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::shadowRoot): (LayoutTestController::ensureShadowRoot): (LayoutTestController::removeShadowRoot):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::ensureShadowRoot): (LayoutTestController::removeShadowRoot):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::ensureShadowRoot): (LayoutTestController::removeShadowRoot):
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowRoot): (WTR::LayoutTestController::ensureShadowRoot): (WTR::LayoutTestController::removeShadowRoot):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
10:49 PM Changeset in webkit [84471] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Dirk Pranke <​dpranke@chromium.org>

Make video/image-zoom fail on GPU on all ports.

  • platform/chromium/test_expectations.txt:
10:42 PM Changeset in webkit [84470] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
10:29 PM Changeset in webkit [84469] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Add test failures for r84454, r84457, flakiness on deps bots.

  • platform/chromium/test_expectations.txt:
10:20 PM Changeset in webkit [84468] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Follow on fix for ​https://bugs.webkit.org/show_bug.cgi?id=58926

Reviewed by Ryosuke Niwa.

Fix assertions in Chromium builds.

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled): Skia and Wx do not have proper implementations of
BitmapImage::checkForSolidColor() so we shouldn't assert on those platforms.

10:19 PM Writing Reftests edited by hayato@chromium.org
(diff)
9:50 PM Changeset in webkit [84467] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-04-20 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: handle ctrl-c more cleanly
​https://bugs.webkit.org/show_bug.cgi?id=58849

  • Scripts/new-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
9:20 PM Changeset in webkit [84466] by adamk@chromium.org
  • 7 edits in trunk/Source/JavaScriptCore

2011-04-20 Adam Klein <​adamk@chromium.org>

Reviewed by David Levin.

Rename all uses of JSC_MULTIPLE_THREADS under wtf/... to WTF_MULTIPLE_THREADS
​https://bugs.webkit.org/show_bug.cgi?id=59040

This will be used to fix ​https://bugs.webkit.org/show_bug.cgi?id=55728
by enabling WTF_MULTIPLE_THREADS for Chromium.

  • wtf/CryptographicallyRandomNumber.cpp: (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber): (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):
  • wtf/FastMalloc.cpp:
  • wtf/Platform.h: Enable WTF_MULTIPLE_THREADS whenever JSC_MULTIPLE_THREADS is enabled.
  • wtf/RandomNumber.cpp: (WTF::randomNumber):
  • wtf/RefCountedLeakCounter.cpp: (WTF::RefCountedLeakCounter::increment): (WTF::RefCountedLeakCounter::decrement):
  • wtf/dtoa.cpp: (WTF::pow5mult):
9:14 PM Changeset in webkit [84465] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-04-20 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Add timeline to mediaControlsEfl.css
​https://bugs.webkit.org/show_bug.cgi?id=58865

Add timeline to mediaControlsEfl.css in order to show playing time of media
content.

  • css/mediaControlsEfl.css: (audio): (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel): (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container): (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
8:49 PM Changeset in webkit [84464] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Suppress failures for inspector/debugger/live-edit.html
and inspector/console/console-object-constructor-name.html

  • platform/chromium/test_expectations.txt:
8:41 PM Changeset in webkit [84463] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-04-20 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel.

Create RIAA class for GraphicsContext::save() and restore()
​https://bugs.webkit.org/show_bug.cgi?id=58807

Make a stack-based class that can be used to save and restore
the graphics state. It has conditional behavior to deal with the many cases
where we decide to save/restore based on some runtime condition.

Change RenderBoxModelObject to use it for now; it can be used more widely
once committed.

  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::GraphicsContextStateSaver): (WebCore::GraphicsContextStateSaver::~GraphicsContextStateSaver): (WebCore::GraphicsContextStateSaver::saveState):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintOneBorderSide): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::drawBoxSideFromPath): (WebCore::RenderBoxModelObject::paintBoxShadow):
8:33 PM Changeset in webkit [84462] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Bug 59069 - DFG JIT - register allocate r8, r9, r10

Rubber stamped by Geoff Garen

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::gprToRegisterID):

8:26 PM Changeset in webkit [84461] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Suppress failures for media/csp-blocks-video.html and
plugins/embed-attributes-style.html

  • platform/chromium/test_expectations.txt:
8:21 PM Changeset in webkit [84460] by abarth@webkit.org
  • 5 edits
    6 adds in trunk

2011-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP frame-src is missing
​https://bugs.webkit.org/show_bug.cgi?id=58643

Tests the basic functionality of frame-src.

  • http/tests/security/contentSecurityPolicy/frame-src-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/frame-src-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/frame-src-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/alert-fail.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/alert-pass.html: Added.

2011-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP frame-src is missing
​https://bugs.webkit.org/show_bug.cgi?id=58643

This is a first cut at an implementation of frame-src. There are a
couple things that will need to be improved:

1) I don't think we're handling in-frame navigation properly. This

patch only covers setting the src attribute of the frame, but I
think the intent of the spec is to cover navigation as well.

2) The console message is printed twice, once when we try to load the

frame and again when we attach the frame to the render tree.

I'll file bugs about these issues (blocking
​https://bugs.webkit.org/show_bug.cgi?id=53572) once this patch lands.

Tests: http/tests/security/contentSecurityPolicy/frame-src-allowed.html

http/tests/security/contentSecurityPolicy/frame-src-blocked.html

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowChildFrameFromSource): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
8:02 PM Changeset in webkit [84459] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-20 Jia Pu <​jpu@apple.com>

Reviewed by Maciej Stachowiak.

[Mac] Correction panel shows up at incorrect location after webpage is scrolled.
​https://bugs.webkit.org/show_bug.cgi?id=59052
<rdar://problem/9312513>

Fixed a regression caused by interaction between patch for bug 57353 and patch for bug 55571.
See bug webpage for detail.

  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasMarkerFor):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::windowRectForRange):
7:47 PM Changeset in webkit [84458] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
7:33 PM Changeset in webkit [84457] by abarth@webkit.org
  • 22 edits
    2 copies
    12 adds
    4 deletes in trunk

2011-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP policy violations should log to the console
​https://bugs.webkit.org/show_bug.cgi?id=58646

Now with console messages. I had to split a bunch of these tests into
smaller pieces to avoid race conditions in the new test output.

  • http/tests/security/contentSecurityPolicy/directive-parsing-expected.txt:
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/image-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html.
  • http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt.
  • http/tests/security/contentSecurityPolicy/javascript-url-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/javascript-url-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/javascript-url-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/javascript-url.html: Removed.
  • http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/object-src-none-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/object-src-none-allowed.html: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/object-src-none.html.
  • http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/object-src-none-blocked.html: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/object-src-none.html.
  • http/tests/security/contentSecurityPolicy/object-src-none-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-01-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-01.html: Added.
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-02-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-02.html: Added.
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-03-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-self-blocked-03.html: Added.
  • http/tests/security/contentSecurityPolicy/script-src-self-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-self.html:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt:
  • http/tests/security/contentSecurityPolicy/style-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
  • media/csp-blocks-video-expected.txt:

2011-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP policy violations should log to the console
​https://bugs.webkit.org/show_bug.cgi?id=58646

We now log policy violations to the JavaScript console to help
developers debug what's going on with their Content-Security-Policy.

Tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html

http/tests/security/contentSecurityPolicy/javascript-url-allowed.html
http/tests/security/contentSecurityPolicy/javascript-url-blocked.html
http/tests/security/contentSecurityPolicy/object-src-none-allowed.html
http/tests/security/contentSecurityPolicy/object-src-none-blocked.html
http/tests/security/contentSecurityPolicy/script-src-self-blocked-01.html
http/tests/security/contentSecurityPolicy/script-src-self-blocked-02.html
http/tests/security/contentSecurityPolicy/script-src-self-blocked-03.html

  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::allowEval): (WebCore::ContentSecurityPolicy::allowScriptFromSource): (WebCore::ContentSecurityPolicy::allowObjectFromSource): (WebCore::ContentSecurityPolicy::allowImageFromSource): (WebCore::ContentSecurityPolicy::allowStyleFromSource): (WebCore::ContentSecurityPolicy::allowFontFromSource): (WebCore::ContentSecurityPolicy::allowMediaFromSource): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h: (WebCore::ContentSecurityPolicy::create):
7:23 PM Changeset in webkit [84456] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

fast/images/animated-gif-restored-from-bfcache.html fails on Windows bots
​https://bugs.webkit.org/show_bug.cgi?id=59062

  • platform/win/Skipped:
7:20 PM Changeset in webkit [84455] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

2011-04-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84431.
​http://trac.webkit.org/changeset/84431
​https://bugs.webkit.org/show_bug.cgi?id=59061

Breaks for folks who don't have editbugs (Requested by abarth
on #webkit).

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
7:13 PM Changeset in webkit [84454] by mitz@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/9095366> With a non-1 page scale, scrolling to reveal selection fails
​https://bugs.webkit.org/show_bug.cgi?id=59046

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/transforms/selection-bounds-in-transformed-view.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer): If the repaint container is the RenderView, and
it has a composited layer that paints straight to the window, then translate from view coordinates
to window coordinates here.

  • rendering/RenderView.cpp:

(WebCore::RenderView::mapLocalToContainer): Do not apply our transform if we are the painting root.
(WebCore::RenderView::computeRectForRepaint): Ditto. Applying the transform here was compensating
for not applying it in RenderObject::repaintUsingContainer(), but for purposes other than repainting,
such as computing selection bounds, this function was returning the wrong results.

LayoutTests:

  • fast/transforms/selection-bounds-in-transformed-view-expected.txt: Added.
  • fast/transforms/selection-bounds-in-transformed-view.html: Added.
7:07 PM Changeset in webkit [84453] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Tools

2011-04-20 Leo Yang <​leo.yang@torchmobile.com.cn>

Unreviewed.

Adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
7:03 PM Changeset in webkit [84452] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9304956> media/broken-video.html crashes

Reviewed by Eric Carlson.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::nextMediaEngine): Fixed an off-by-one error.

6:58 PM Changeset in webkit [84451] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Merge forward more suppressions from the chromium overrides
file.

  • platform/chromium/test_expectations.txt:
6:55 PM Changeset in webkit [84450] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-20 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Split out isIteratorTarget from bidiNext and bidiFirst
​https://bugs.webkit.org/show_bug.cgi?id=59033

This is the first (tiny) step of many. When I tried to
make larger changes to this function I broke stuff, so
doing this in tiny pieces so we know it's right.

  • rendering/InlineIterator.h: (WebCore::isIteratorTarget): (WebCore::bidiNext): (WebCore::bidiFirstSkippingInlines): (WebCore::bidiFirstNotSkippingInlines):
6:38 PM Changeset in webkit [84449] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-04-20 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=59045

Lose context extension test might not catch this bug, more reliable
way is forcing the crash of the GPU process, which is done by Chromium
browser tests.

  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateCompositorResources): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h:

2011-04-20 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=59045

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::~GraphicsContext3D): call into platform layer and unregister itself.
6:28 PM Changeset in webkit [84448] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-04-20 Jia Pu <​jpu@apple.com>

Reviewed by Maciej Stachowiak.

[Mac]Regression: extending word that is already marked misspelled doesn't remove misspelling underline.
​https://bugs.webkit.org/show_bug.cgi?id=59032
<rdar://problem/9312444>

This fixes a regression introduced in recent refactoring work in Editor. See bug webpage for detail.

manual test: Source/WebCore/manual-tests/autocorrection/remove-misspelling-marker-after-appending-letter.html

  • editing/Editor.cpp: (WebCore::Editor::insertTextWithoutSendingTextEvent):
  • manual-tests/autocorrection/remove-misspelling-marker-after-appending-letter.html: Added.
6:10 PM Changeset in webkit [84447] by adamk@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed. Add myself to the committers script.

6:04 PM Changeset in webkit [84446] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix - revert accidental change.

  • wtf/Platform.h:
6:03 PM Changeset in webkit [84445] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Add SAMPLING_FLAGS tool to DFG JIT.

Reviewed by Sam Weinig.

  • bytecode/SamplingTool.h:

(JSC::SamplingFlags::addressOfFlags):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):

  • dfg/DFGJITCompiler.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::setSamplingFlag):
(JSC::JIT::clearSamplingFlag):

  • wtf/Platform.h:
5:54 PM Changeset in webkit [84444] by Chris Fleizach
  • 3 edits in trunk/Source/WebCore

2011-04-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

CrashTracer: 301 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityRenderObject::visiblePositionForPoint const + 297
​https://bugs.webkit.org/show_bug.cgi?id=57405

The offending line in this crash was a null pointer access in

m_renderer->document()->topDocument()->renderer()->view()->frameView();

It seems likely that one of those calls was invalid. I could not reproduce and there was no
information on reproducible steps, hence the absence of a layout test.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::topRenderer): (WebCore::AccessibilityRenderObject::topDocument): (WebCore::AccessibilityRenderObject::topDocumentFrameView): (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
  • accessibility/AccessibilityRenderObject.h:
5:46 PM Changeset in webkit [84443] by aestes@apple.com
  • 4 edits
    3 adds in trunk

2011-04-20 Andy Estes <​aestes@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION (WK2): Animated GIF stops when navigating forward, back
​https://bugs.webkit.org/show_bug.cgi?id=59042

  • fast/images/animated-gif-restored-from-bfcache-expected.txt: Added.
  • fast/images/animated-gif-restored-from-bfcache.html: Added.
  • fast/images/resources/animated-10color.gif: Added.
  • platform/mac-wk2/Skipped: Sadly, this test for a WebKit2-specific fix has to be skipped for now on WebKit2 since it doesn't implement layoutTestController.overridePreference().

2011-04-20 Andy Estes <​aestes@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION (WK2): Animated GIF stops when navigating forward, back
​https://bugs.webkit.org/show_bug.cgi?id=59042

When loading the page from the b/f cache,
document()->view()->isOffscreen() returns true in
RenderObject::willRenderImage(), so BitmapImage::startAnimation()
returns without actually kicking off the animation.

In WebKit1, the ScrollView is a platform widget, so
ScrollView::isOffscreen() calls [NSWindow isVisible]. In WebKit2, the
ScrollView isn't a platform widget so it asks the WebCore Widget
whether or not it is visible. It always returns false since
setParentVisible(false) was called on the old ScrollView before
navigating to a new page, but setParentVisible(true) is never called
when restoring it from the back/forward cache. This is probably a
long-standing bug.

Fix this by calling setParentVisible(true) when a cached main frame is
being restored.

Test: fast/images/animated-gif-restored-from-bfcache.html

  • history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): If the cached frame is the main frame, call setParentVisible(true) on the frame's view.
5:35 PM Changeset in webkit [84442] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-20 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: Can't scroll page after printing on Yahoo.com and other sites
<rdar://problem/9233291>
​https://bugs.webkit.org/show_bug.cgi?id=59049

  • page/Frame.cpp: (WebCore::Frame::setPrinting): Match Mac WebKit1 code when ending printing, and call forceLayout() instead of forceLayoutForPagination().
5:28 PM Changeset in webkit [84441] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-20 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Reduce size of GraphicsContext3D's compiled code
​https://bugs.webkit.org/show_bug.cgi?id=59029

Changed format conversion operations to work line-by-line instead
of pixel-by-pixel, and passed them as function pointers rather
than template parameters. Simplified computation of source
increment, since elements per row is now all that is needed.

These changes reduce the size of GraphicsContext3D.o in release
mode on Linux from 299 KB to 53 KB.

No new tests. Existing layout tests cover these format conversions
well, and caught one typo in the restructuring. Also ran WebGL
conformance suite and other demos.

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::doUnpackingAndPacking): (WebCore::computeSourceElementsPerRow): (WebCore::doPacking): (WebCore::doFloatingPointPacking): (WebCore::GraphicsContext3D::packPixels):
5:23 PM Changeset in webkit [84440] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk

2011-04-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element.
​https://bugs.webkit.org/show_bug.cgi?id=59037

  • fast/events/simulated-click-disabled-expected.txt: Added.
  • fast/events/simulated-click-disabled.html: Added.

2011-04-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element.
​https://bugs.webkit.org/show_bug.cgi?id=59037

Test: fast/events/simulated-click-disabled.html

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchSimulatedClick): Added check for disabled element.
5:21 PM Changeset in webkit [84439] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Dirk Pranke <​dpranke@chromium.org>

Pull in more flaky expectations.

  • platform/chromium/test_expectations.txt:
4:55 PM Changeset in webkit [84438] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change. Pull in expectations from
overrides file.

  • platform/chromium/test_expectations.txt:
4:50 PM Changeset in webkit [84437] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-04-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Don't discard backing stores for hung web processes
​https://bugs.webkit.org/show_bug.cgi?id=59039
<rdar://problem/9237090>

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange): (WebKit::WebPageProxy::processDidBecomeUnresponsive): (WebKit::WebPageProxy::processDidBecomeResponsive): Call updateBackingStoreDiscardableState.

(WebKit::WebPageProxy::updateBackingStoreDiscardableState):
Never mark the backing store as discardable if the web process is hung

4:48 PM Changeset in webkit [84436] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-20 Eric Seidel <​eric@webkit.org>

Reviewed by Ryosuke Niwa.

Split bidiFirst into two functions
​https://bugs.webkit.org/show_bug.cgi?id=59025

I don't have a full understanding of the skipInlines case yet
(hence it's not as pretty as the non-skipping case), but
this is clearly a win, as both functions are much simpler
than their combined version.

Both of these functions still have bad names. However the
bidiNext/bidiFirst names date all the way back to revision 1
of the WebKit repository. :) So I don't feel too bad keeping
them for the moment.

  • rendering/InlineIterator.h: (WebCore::bidiNext): (WebCore::bidiFirstSkippingInlines): (WebCore::bidiFirstNotSkippingInlines):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::simplifiedNormalFlowLayout):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition):
4:43 PM Changeset in webkit [84435] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Provide missing implementation of WebMutableURLRequest::mutableCopy.
This was preventing DumpRenderTree from working properly under
the WinCairo port.
​https://bugs.webkit.org/show_bug.cgi?id=59034

Reviewed by Martin Robinson.

  • WebMutableURLRequest.cpp:

(WebMutableURLRequest::mutableCopy): Implement cURL version of the
copy operation.

4:41 PM Changeset in webkit [84434] by mjs@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-04-20 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.

Reproducible crash under WebPageProxy::didReceiveEvent
​https://bugs.webkit.org/show_bug.cgi?id=59036
<rdar://problem/9252083>

  • UIProcess/API/mac/WKView.mm: (-[WKView _resendKeyDownEvent:]): Protect against self-destruction when re-dispatching the event.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::createWebPage): Fixed a type mismatch I noticed while debugging.
4:35 PM Changeset in webkit [84433] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-04-20 Jia Pu <​jpu@apple.com>

Reviewed by Adele Peterson.

[Mac] Like autocorrection, other types of substitution need to respect undo.
​https://bugs.webkit.org/show_bug.cgi?id=59009
<rdar://problem/8601537>

Similar to autocorrection, we use SpellingCorrectionCommand to carry out other types of text substitution, so that
if user undoes the substitution, it will not be applied again. For CreateLinkCommand, we add marker when it's undone
so that we won't automatically add link again.

  • editing/CreateLinkCommand.h: (WebCore::CreateLinkCommand::isCreateLinkCommand):
  • editing/EditCommand.cpp: (WebCore::EditCommand::isCreateLinkCommand):
  • editing/EditCommand.h:
  • editing/Editor.cpp: (WebCore::Editor::unappliedEditing): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToAppliedEditing): (WebCore::SpellingCorrectionController::respondToUnappliedEditing):
  • editing/SpellingCorrectionController.h: (WebCore::SpellingCorrectionController::UNLESS_ENABLED):
4:20 PM Changeset in webkit [84432] by tony@chromium.org
  • 2 edits
    1 add
    2 deletes in trunk/LayoutTests

2011-04-20 Tony Chang <​tony@chromium.org>

Update 2 more tests that are missing png files.

  • platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png: Added. png with embedded checksum pulled from the bot.
  • platform/chromium-win/compositing/repaint/become-overlay-composited-layer-expected.checksum: Removed. This file is not used since we don't

run compositing tests w/CPU rendering and there's a GPU result in chromium-gpu-win.

  • platform/chromium/test_expectations.txt: Remove these tests.
4:08 PM Changeset in webkit [84431] by abarth@webkit.org
  • 5 edits in trunk/Tools

2011-04-20 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch upload should assign the bug to you
​https://bugs.webkit.org/show_bug.cgi?id=33699

This patch only re-assigns the bug if it is currently unassigned. We
can be more aggressive in the future if people want us to be more
agressive.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
4:07 PM Changeset in webkit [84430] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixed typo in the failed test added to chromium test
expectations.

  • platform/chromium/test_expectations.txt:
3:57 PM Changeset in webkit [84429] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebCore

2011-04-20 Steve Lacey <​sjl@chromium.org>

Reviewed by Eric Carlson.

[chromium] Move Chromium media controls into own root element.
​https://bugs.webkit.org/show_bug.cgi?id=59018

No new tests as there is no functional change

  • WebCore.gypi:
  • css/mediaControlsChromium.css: (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
  • html/shadow/MediaControlRootElementChromium.cpp: Added. Clone of html/shadow/MediaControlRootElement.cpp with all unused code removed.
  • html/shadow/MediaControlRootElementChromium.h: Added.
3:54 PM Changeset in webkit [84428] by tony@chromium.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

2011-04-20 Tony Chang <​tony@chromium.org>

More .checksum file cleanup.

  • fast/css/background-clip-values-expected.checksum: Removed. This is a duplicate of the .checksum

file in platform/mac.

  • platform/mac-leopard/fast/backgrounds/size/contain-and-cover-expected.checksum: Correct checksum by

regenerating on my leopard machine.

  • platform/mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
3:32 PM Changeset in webkit [84427] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-04-20 Yuzhu Shen <​yzshen@chromium.org>

Reviewed by Tony Chang.

[chromium] linux chromium doesn't set click count for mouse up events.
​https://bugs.webkit.org/show_bug.cgi?id=58921

The reason why we need such a fix is that the Pepper API passes this information to plugins,
and some consumers (e.g., Flash) need it to detect double-clicks.

  • src/gtk/WebInputEventFactory.cpp: set click count for mouse up events.
3:26 PM Changeset in webkit [84426] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-20 Charlie Lee <​chocobo@chromium.org>

Reviewed by Dirk Schulze.

LEFilter change doesn't compile on ARM neon targets
​https://bugs.webkit.org/show_bug.cgi?id=58671

Build fix for Chromium ARM/NEON platform. Added platform/graphics/filters/arm directory to build system.

  • WebCore.gyp/WebCore.gyp:
3:20 PM Changeset in webkit [84425] by xji@chromium.org
  • 5 edits in trunk

2011-04-20 Xiaomei Ji <​xji@chromium.org>

Reviewed by Ryosuke Niwa.

Continue (3rd) experiment with moving caret by word in visual order.
​https://bugs.webkit.org/show_bug.cgi?id=58294

This patch along with r82588 and r83483 implements moving caret by
word in visual order.


The overall algorithm is:

  1. First get the InlineBox and offset of the pass-in VisiblePosition.
  2. Based on the position (left boundary, middle, right boundary) of the offset and the direction of the movement, look for visually adjacent word breaks. 2.1 If the offset is the minimum offset of the box,

return the rightmost word boundary in previous boxes if moving left.
return the leftmost word boundary in box and next boxes if moving right.

2.2 Similar for the case when offset is at the maximum offset of the box.
2.3 When offset is inside the box (not at boundaries), first find the previousWordPosition

or nextWordPosition based on the directionality of the box. If this word break position
is also inside the same box, return it. Otherwise (the nextWordPosition or
previousWordPosition is not in the same box or is at the box boundary), collect all the
word breaks in the box and search for the one closest to the input "offset" based on
box directionality, block directionality, and movement direction. Continue search in
adjacent boxes if needed.

Notes:

  1. Word boundaries are collected one box at a time. Only when a boundary that is closest to the input position (in the moving direction) is not available in current box, word boundaries in adjacent box will be collected. So, there is no need to save InlineBox in word boundaries. Instead, the word boundaries are saved as a pair (VisiblePosition, offset) to avoid recomputing VisiblePosition.


  1. We only collect boundaries of the right kind (i.e. left boundary of a word in LTR block and right boundary of a word in RTL block). And word boundaries are collected using previousWordPosition() and nextWordPosition(). So when box directionality is the same as block directionality, word boundaries are collected from right to left visually in a LTR box, and word boundaries are collected from left to right visually in a RTL box. It is the other way around when box directionality is different from block directionality.
  1. To find the right kinds of word boundaries, we must move back and forth between words in some situations. For example, if we're moving to the right in a LTR box in LTR block, we cannot simply return nextWordPosition() because it would return the right boundary of a word. Instead, we return nextWordPosition()'s nextWordPosition()'s previousWordPosition().
  1. When collecting word breaks inside a box, it first computes a start position, then collect the right kind of word breaks until it reaches the end of (or beyond) the box. In the meanwhile, it might need special handling on the rightmost or leftmost position based on the directionality of the box and block. These computations do not consider the box's bidi level.
  • editing/visible_units.cpp: (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): (WebCore::collectWordBreaksInBox): (WebCore::previousWordBoundaryInBox): (WebCore::nextWordBoundaryInBox): (WebCore::visuallyLastWordBoundaryInBox): (WebCore::leftWordBoundary): (WebCore::rightWordBoundary): (WebCore::leftWordPosition): (WebCore::rightWordPosition):

2011-04-20 Xiaomei Ji <​xji@chromium.org>

Reviewed by Ryosuke Niwa.

Continue (3rd) experiment with moving caret by word in visual order.
​https://bugs.webkit.org/show_bug.cgi?id=58294

  • editing/selection/move-by-word-visually-expected.txt:
  • editing/selection/move-by-word-visually.html:
3:15 PM April 2011 Meeting edited by Dimitri Glazkov
(diff)
3:09 PM Changeset in webkit [84424] by timothy@apple.com
  • 11 edits in trunk/Source/WebKit2

Make the Web Insepctor come to the front when a breakpoint is hit.

<​https://webkit.org/b/57480> REGRESSION (WebKit2): Inspector doesn't come to the front when a breakpoint is hit in the debugger
<rdar://problem/9209472>

Reviewed by Adam Roben.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::bringToFront): Added. Call platformBringToFront.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebInspectorProxy.messages.in: Added BringToFront.
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformBringToFront): Added. Call orderFront:.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformBringToFront): Added. Call SetWindowPos.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::bringToFront): Call WebInspector::bringToFront.

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::bringToFront): Added. Send WebInspectorProxy::BringToFront message.

  • WebProcess/WebPage/WebInspector.h: Added bringToFront.
2:57 PM Changeset in webkit [84423] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Modify builder.html template to allow easy access
to list more builds on the builder's page.

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2011-04-20
Reviewed by Csaba Osztrogonác.

​https://bugs.webkit.org/show_bug.cgi?id=59008

  • BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
2:57 PM Changeset in webkit [84422] by cdn@chromium.org
  • 3 edits
    2 adds in trunk

2011-04-20 Cris Neckar <​cdn@chromium.org>

Reviewed by Dirk Schulze.

Tests for crash when copying a filter effect after applying tranforms.
​https://bugs.webkit.org/show_bug.cgi?id=57885

  • svg/filters/svg-transform-blur-crash-expected.txt: Added.
  • svg/filters/svg-transform-blur-crash.xhtml: Added.

2011-04-20 Cris Neckar <​cdn@chromium.org>

Reviewed by Dirk Schulze.

Return early when the paint rect and the source rect do not overlap as no bytes need to be copied.
​https://bugs.webkit.org/show_bug.cgi?id=57885

Test: svg/filters/svg-transform-blur-crash.xhtml

  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::copyImageBytes):
2:48 PM Changeset in webkit [84421] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/Tools

2011-04-20 Peter Gal <​galpeter@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

Add the default template for builder page.

​https://bugs.webkit.org/show_bug.cgi?id=59008

  • BuildSlaveSupport/build.webkit.org-config/templates/builder.html: Added.
2:45 PM Changeset in webkit [84420] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

move page generation into a single function
​https://bugs.webkit.org/show_bug.cgi?id=59027

Now executing the script doesn't create any state. We should then
be able to write tests for this by setting custom results data.

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
2:39 PM Changeset in webkit [84419] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

move global state into a shared object
​https://bugs.webkit.org/show_bug.cgi?id=59023

This makes the code more testable.

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
2:38 PM Changeset in webkit [84418] by jianli@chromium.org
  • 4 edits
    3 adds in trunk

Support DataView in workers
​https://bugs.webkit.org/show_bug.cgi?id=59014

Reviewed by Kenneth Russell.

Source/WebCore:

Test: fast/canvas/webgl/worker-data-view-test.html

  • workers/WorkerContext.idl: Expose DataView constructor.

LayoutTests:

  • fast/canvas/webgl/resources/worker-data-view-test.js: Added.
  • fast/canvas/webgl/worker-data-view-test-expected.txt: Added.
  • fast/canvas/webgl/worker-data-view-test.html: Added.
  • platform/chromium/test_expectations.txt:
2:33 PM Changeset in webkit [84417] by tony@chromium.org
  • 2 edits
    12 deletes in trunk/LayoutTests

2011-04-20 Tony Chang <​tony@chromium.org>

Cleanup .checksum files that don't have .png files.

If the test is marked as failing, just delete the .checksum file.
If the test is marked as passing, put it in test_expectations.txt so
the bots will generate results.

  • platform/chromium-mac-leopard/fast/borders/border-radius-split-inline-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/repaint/positioned-document-element-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/text/basic/014-expected.checksum: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.checksum: Removed.
  • platform/chromium-mac/fast/images/imagemap-focus-ring-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/core/misc-expected.checksum: Removed.
  • platform/chromium-win/fast/forms/searchfield-heights-expected.checksum: Removed.
  • platform/chromium/test_expectations.txt:
2:09 PM Changeset in webkit [84416] by cmarrin@apple.com
  • 10 edits in trunk/Source

2011-04-20 Chris Marrin <​cmarrin@apple.com>

Reviewed by Adam Roben.

REGRESSION (WebKit2): CSS animations on pages that use accelerated compositing stop after switching tabs
​https://bugs.webkit.org/show_bug.cgi?id=57868


Running CACFAnimations aren't remembered when layer tree is unparented and
then reparented. Added a new ensureAnimationsSubmitted function to
PlatformCALayer to traverse the tree and resubmit animations, setting the
beginTime to the original start time of the animation. This is called in WK2
when layer tree is newly parented.


I also consolidated currentTimeToMediaTime into PlatformCALayer so it can be shared
between PlatformCALayer and GraphicsLayerCA.

  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/PlatformCAAnimation.h:

Remember actual animation start time in CACFAnimation beginTime property

  • platform/graphics/ca/PlatformCALayer.h:

New ensureAnimationsSubmitted function which traverses layers and resubmits all animations

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

2011-04-20 Chris Marrin <​cmarrin@apple.com>

Reviewed by Adam Roben.

REGRESSION (WebKit2): CSS animations on pages that use accelerated compositing stop after switching tabs
​https://bugs.webkit.org/show_bug.cgi?id=57868


Subclassed setRootCompositingLayer so it can call ensureAnimationsSubmitted on Win.

  • WebProcess/WebPage/ca/LayerTreeHostCA.h:

Make setRootCompositingLayer protected so it can be called from subclass

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

Override setRootCompositingLayer to add call to root layer's
PlatformCALayer::ensureAnimationsSubmitted method

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:
2:03 PM ThreadCommunication edited by levin@chromium.org
Filled in api for sync case. (diff)
2:02 PM Changeset in webkit [84415] by eric.carlson@apple.com
  • 14 edits in trunk

2011-04-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Adopt QTKit API for listing and deleting file in its media cache.
<rdar://problem/9130029>
​https://bugs.webkit.org/show_bug.cgi?id=58795

Not possible to test automatically, verified manually.

  • WebCore.exp.in: Export new media download cache functions.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Register cache management functions. (WebCore::MediaPlayerPrivateQTKit::getSitesInMediaCache): New, return cache origins. (WebCore::MediaPlayerPrivateQTKit::clearMediaCache): New, empty the media cache. (WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForSite): New, delete files in the media

cache for one origin.

  • platform/mac/WebCoreSystemInterface.h: Add new WKSI functions.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

2011-04-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Adopt QTKit API for listing and deleting file in its media cache.
<rdar://problem/9130029>
​https://bugs.webkit.org/show_bug.cgi?id=58795

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:

2011-04-20 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Adopt QTKit API for listing and deleting file in its media cache.
<rdar://problem/9130029>

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize new functions.

2011-04-18 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Adopt QTKit API for listing and deleting file in its media cache.
<rdar://problem/9130029>

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize new functions.
2:00 PM Changeset in webkit [84414] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, fix duplicate expectations.

  • platform/chromium/test_expectations.txt:
1:47 PM Changeset in webkit [84413] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Bug 59022 - DFG JIT - Optimize branch-on-relational-compare

Reviewed by Oliver Hunt.

If a relational compare (< or <=) is immediately followed by a branch,
we can combine the two, avoiding generation of a boolean into a register.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branch32):
(JSC::MacroAssemblerX86Common::invert):
(JSC::MacroAssemblerX86Common::commute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::adjustedRefCount):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isJSConstantWithInt32Value):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):

1:47 PM Changeset in webkit [84412] by tony@chromium.org
  • 6191 edits in trunk/LayoutTests

2011-04-20 Tony Chang <​tony@chromium.org>

Unreviewed, embedding checksums in png files in platform/mac.

1:28 PM Changeset in webkit [84411] by robert@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-04-20 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] DRT sideeffect revealed by r63657 and r75305
​https://bugs.webkit.org/show_bug.cgi?id=42578

Unskip tests passing since r76958

The NetworkAccessManager's authentication cache is getting
cleared now on every page load, so these no longer leak
credentials between tests.

  • platform/qt/Skipped:
1:05 PM Changeset in webkit [84410] by krit@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-04-20 Dirk Schulze <​krit@webkit.org>

Reviewed by Simon Fraser.

SVG feDropShadow implementation of SVG Filters 1.2
​https://bugs.webkit.org/show_bug.cgi?id=52513

Support different radii for horizontal and vertical blurring in ShadowBlur. This is a preperation for feDropShadow.
feDropShadow is a new shorthand filter effect for the up-comming Filter 1.0 specification and will use ShadowBlur.
feGaussianBlur might make use of ShadowBlur as well later (on SourceAlpha input).
Added ShadowBlur to remaining platforms.

The changes can't be tested before the changes in feGaussianBlur or feDropShadow. Current behavior is not affected.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.pro:
  • platform/graphics/FloatSize.h: (WebCore::FloatSize::scale):
  • platform/graphics/ShadowBlur.cpp: (WebCore::ScratchBuffer::ScratchBuffer): (WebCore::ScratchBuffer::setLastShadowValues): (WebCore::ScratchBuffer::setLastInsetShadowValues): (WebCore::ScratchBuffer::matchesLastShadow): (WebCore::ScratchBuffer::matchesLastInsetShadow): (WebCore::ScratchBuffer::clearScratchBuffer): (WebCore::ShadowBlur::ShadowBlur): (WebCore::calculateLobes): (WebCore::ShadowBlur::blurLayerImage): (WebCore::ShadowBlur::adjustBlurRadius): (WebCore::ShadowBlur::calculateLayerBoundingRect): (WebCore::computeSliceSizesFromRadii): (WebCore::ShadowBlur::templateSize): (WebCore::ShadowBlur::drawInsetShadowWithTiling): (WebCore::ShadowBlur::drawRectShadowWithTiling): (WebCore::ShadowBlur::drawLayerPieces):
  • platform/graphics/ShadowBlur.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillRectWithRoundedHole):
12:56 PM Changeset in webkit [84409] by vrk@chromium.org
  • 4 edits in trunk/LayoutTests

2011-03-07 Victoria Kirst <​vrk@google.com>

Reviewed by Mihai Parparita.

Make LayoutTests robust to latency btwn playing event and frame rendering
​https://bugs.webkit.org/show_bug.cgi?id=55918

  • media/controls-after-reload.html:
  • media/controls-without-preload.html:
  • media/video-paint-test.js:
  • platform/chromium/test_expectations.txt:
12:54 PM Changeset in webkit [84408] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

2011-04-20 Taiju TSUIKI <​tzik@google.com>

Reviewed by David Levin.

Add overwrite copy/move tests for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=58864

  • fast/filesystem/op-copy-expected.txt:
  • fast/filesystem/op-move-expected.txt:
  • fast/filesystem/resources/op-copy.js:
  • fast/filesystem/resources/op-move.js:
12:52 PM WebKit Team edited by mahesh.kulkarni@nokia.com
(diff)
12:48 PM Changeset in webkit [84407] by mahesh.kulkarni@nokia.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Adding myself to committer list

12:38 PM Changeset in webkit [84406] by tony@chromium.org
  • 5331 edits in trunk/LayoutTests

2011-04-20 Tony Chang <​tony@chromium.org>

Unreviewed, embedding checksums in png files in platform/chromium-linux*.

12:21 PM Changeset in webkit [84405] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

add expandAll/collapseAll links
​https://bugs.webkit.org/show_bug.cgi?id=59011

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
12:18 PM Changeset in webkit [84404] by yael.aharon@nokia.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed.

Adjust Windows results after r84398.

  • platform/win/fast/borders: Added.
  • platform/win/fast/borders/bidi-012-expected.txt: Added.
12:13 PM Changeset in webkit [84403] by tony@chromium.org
  • 5595 edits in trunk/LayoutTests

2011-04-20 Tony Chang <​tony@chromium.org>

Unreviewed, embedding checksums in png files in platform/chromium-win*.

12:09 PM Changeset in webkit [84402] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARMv7 build fix II.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::softModulo):

12:02 PM Changeset in webkit [84401] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARMv7 build fix.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::test8):

11:54 AM Changeset in webkit [84400] by evan@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-04-20 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] expose title text direction on WebDataSource
​https://bugs.webkit.org/show_bug.cgi?id=59010

  • public/WebDataSource.h:
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::pageTitle): (WebKit::WebDataSourceImpl::pageTitleDirection):
  • src/WebDataSourceImpl.h:
11:44 AM Changeset in webkit [84399] by barraclough@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Rationalize MacroAssembler branch methods
​https://bugs.webkit.org/show_bug.cgi?id=58950

Reviewed by Oliver Hunt.

The MacroAssembler currently exposes x86's weird behaviour that the 'setcc'
instruction only sets the low 8 bits of a register. Stop that.

Having done so, to clarify remove the 'set32' prefix from test & compare
instructions - these methods all now set a full 32/64 bit register (Ptr size).
The size in the function name should indicate the amount of data being compared.

Also split out the 'Condition' enum into 'RelationalCondition' and
'ResultCondition'. The former is used in binary comparison, the latter is a unary
condition check on the result of an operation.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::branchPtr):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::branch16):
(JSC::MacroAssembler::branchTestPtr):
(JSC::MacroAssembler::comparePtr):
(JSC::MacroAssembler::branchAddPtr):
(JSC::MacroAssembler::branchSubPtr):
(JSC::MacroAssembler::branchTest8):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branch8):
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerARM::branch16):
(JSC::MacroAssemblerARM::branchTest8):
(JSC::MacroAssemblerARM::branchTest32):
(JSC::MacroAssemblerARM::branchAdd32):
(JSC::MacroAssemblerARM::branchMul32):
(JSC::MacroAssemblerARM::branchSub32):
(JSC::MacroAssemblerARM::branchNeg32):
(JSC::MacroAssemblerARM::branchOr32):
(JSC::MacroAssemblerARM::compare32):
(JSC::MacroAssemblerARM::test32):
(JSC::MacroAssemblerARM::test8):
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::ARMCondition):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branch32):
(JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerARMv7::branch16):
(JSC::MacroAssemblerARMv7::branch8):
(JSC::MacroAssemblerARMv7::branchTest32):
(JSC::MacroAssemblerARMv7::branchTest8):
(JSC::MacroAssemblerARMv7::branchAdd32):
(JSC::MacroAssemblerARMv7::branchMul32):
(JSC::MacroAssemblerARMv7::branchOr32):
(JSC::MacroAssemblerARMv7::branchSub32):
(JSC::MacroAssemblerARMv7::compare32):
(JSC::MacroAssemblerARMv7::test32):
(JSC::MacroAssemblerARMv7::test8):
(JSC::MacroAssemblerARMv7::branchPtrWithPatch):
(JSC::MacroAssemblerARMv7::makeBranch):
(JSC::MacroAssemblerARMv7::armV7Condition):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branch8):
(JSC::MacroAssemblerMIPS::branch32):
(JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerMIPS::branch16):
(JSC::MacroAssemblerMIPS::branchTest32):
(JSC::MacroAssemblerMIPS::branchTest8):
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchMul32):
(JSC::MacroAssemblerMIPS::branchSub32):
(JSC::MacroAssemblerMIPS::branchOr32):
(JSC::MacroAssemblerMIPS::compare32):
(JSC::MacroAssemblerMIPS::test8):
(JSC::MacroAssemblerMIPS::test32):
(JSC::MacroAssemblerMIPS::branchPtrWithPatch):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::branch32):
(JSC::MacroAssemblerX86::branchPtrWithPatch):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branch8):
(JSC::MacroAssemblerX86Common::branch32):
(JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerX86Common::branch16):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):
(JSC::MacroAssemblerX86Common::branchNeg32):
(JSC::MacroAssemblerX86Common::branchOr32):
(JSC::MacroAssemblerX86Common::compare32):
(JSC::MacroAssemblerX86Common::test8):
(JSC::MacroAssemblerX86Common::test32):
(JSC::MacroAssemblerX86Common::x86Condition):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::comparePtr):
(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):
(JSC::MacroAssemblerX86_64::branchAddPtr):
(JSC::MacroAssemblerX86_64::branchSubPtr):
(JSC::MacroAssemblerX86_64::branchPtrWithPatch):
(JSC::MacroAssemblerX86_64::branchTest8):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

11:30 AM ThreadCommunication edited by levin@chromium.org
Small fix. (diff)
11:15 AM Changeset in webkit [84398] by yael.aharon@nokia.com
  • 1 edit
    4 adds
    11 deletes in trunk/LayoutTests

Replace bidi-004.html with its new version.
​https://bugs.webkit.org/show_bug.cgi?id=58984

Reviewed by Eric Seidel.

  • fast/borders/bidi-004.html: Removed.
  • fast/borders/bidi-012.html: Added.
  • platform/chromium-linux/fast/borders/bidi-004-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/borders/bidi-004-expected.png: Removed.
  • platform/chromium-win/fast/borders/bidi-004-expected.png: Removed.
  • platform/chromium-win/fast/borders/bidi-004-expected.txt: Removed.
  • platform/gtk/fast/borders/bidi-004-expected.checksum: Removed.
  • platform/gtk/fast/borders/bidi-004-expected.png: Removed.
  • platform/gtk/fast/borders/bidi-004-expected.txt: Removed.
  • platform/mac/fast/borders/bidi-004-expected.checksum: Removed.
  • platform/mac/fast/borders/bidi-004-expected.png: Removed.
  • platform/mac/fast/borders/bidi-004-expected.txt: Removed.
  • platform/mac/fast/borders/bidi-012-expected.checksum: Added.
  • platform/mac/fast/borders/bidi-012-expected.png: Added.
  • platform/mac/fast/borders/bidi-012-expected.txt: Added.
11:09 AM Changeset in webkit [84397] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix.

  • platform/qt-wk2/Skipped:
10:57 AM Changeset in webkit [84396] by kevino@webkit.org
  • 7 edits in trunk/Tools

[wx] Unreviewed build fixes for wx 2.9.1, Cocoa and 64-bit builds.

10:46 AM Changeset in webkit [84395] by tony@chromium.org
  • 1841 edits in trunk/LayoutTests

2011-04-20 Tony Chang <​tony@chromium.org>

Unreviewed, embedding checksums in png files in platform/google*,
platform/chromium-gpu*, platform/chromium-mac*.

10:25 AM Changeset in webkit [84394] by rolandsteiner@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-04-19 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 52963 - Enable O(1) access to root from any node in shadow DOM subtree
​https://bugs.webkit.org/show_bug.cgi?id=52963

.) Change base class of ShadowRoot from DocumentFragment to TreeScope.
.) Re-enable tree scope handling in Node (had ASSERT_NOT_REACHED, etc.).
.) Merged setTreeScope() with setTreeScopeRecursively()
.) Call setTreeScopeRecursively in DOM manipulation functions where applicable.
.) Adapt JavaScript Node wrappers (temporary code - see ​https://bugs.webkit.org/show_bug.cgi?id=58704).

No new tests. (refactoring)

  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::toV8Slow):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::takeAllChildrenFrom): (WebCore::ContainerNode::removeBetween): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::parserAddChild):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::setDocType):
  • dom/Element.h:
  • dom/Node.cpp: (WebCore::Node::treeScope): (WebCore::Node::setTreeScopeRecursively):
  • dom/Node.h: (WebCore::Node::document):
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::ShadowRoot): (WebCore::ShadowRoot::~ShadowRoot): (WebCore::ShadowRoot::nodeType): (WebCore::ShadowRoot::cloneNode): (WebCore::ShadowRoot::childTypeAllowed):
  • dom/ShadowRoot.h: (WebCore::toShadowRoot):
  • dom/TreeScope.cpp: (WebCore::TreeScope::TreeScope): (WebCore::TreeScope::setParentTreeScope):
  • dom/TreeScope.h:
  • rendering/RenderSlider.cpp:
10:24 AM Changeset in webkit [84393] by tony@chromium.org
  • 4555 edits in trunk/LayoutTests

2011-04-20 Tony Chang <​tony@chromium.org>

Unreviewed, embedding checksums in png files in platform/mac-*.

10:16 AM Changeset in webkit [84392] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] WebProcess crashes intermittently: "FAIL: TestControllerRunLoop timed out."

  • platform/qt-wk2/Skipped: Add http/tests/security/contentSecurityPolicy/media-src-blocked.html.
10:09 AM Changeset in webkit [84391] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Skip new failing tests.

  • platform/qt-wk2/Skipped:
10:06 AM Changeset in webkit [84390] by mdelaney@apple.com
  • 3 edits in trunk/LayoutTests

2011-04-20 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Dan Bernstein.

Update fast/canvas/font-update.html to use dumpAsText.
​https://bugs.webkit.org/show_bug.cgi?id=59003

  • fast/canvas/font-update-expected.txt:
  • fast/canvas/font-update.html: This test is only useful as a pixel test. Dumping the render tree will always show the same thing regardless of what's done on the canvas in the test. However, with new render tree schemes (canvases in layers and such) the render trees will even look different but not actually failing what the test tests.
10:00 AM Changeset in webkit [84389] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-20 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Update front-end files list in WebCore.vcproj
​https://bugs.webkit.org/show_bug.cgi?id=58896

  • WebCore.vcproj/WebCore.vcproj:
9:56 AM Changeset in webkit [84388] by kerz@chromium.org
  • 1 copy in branches/chromium/742

branching for chromium m12

9:55 AM Changeset in webkit [84387] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Mike Reed <​reed@google.com>

Reviewed by Steve Block.

prepare tests for rebaselining
​https://bugs.webkit.org/show_bug.cgi?id=58989

  • platform/chromium/test_expectations.txt:
9:47 AM Changeset in webkit [84386] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Tony Chang <​tony@chromium.org>

Fixed lint errors in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
9:46 AM Changeset in webkit [84385] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-04-20 Dimitri Glazkov <Dimitri Glazkov>

Qt build fix after r84380.

  • css/CSSPrimitiveValueMappings.h: Moved EBorderCollapse-related casts from under ENABLE(SVG) guard.
9:41 AM Changeset in webkit [84384] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Remove crash expectation for http/tests/local/formdata/send-form-data-with-sliced-file.html
​https://bugs.webkit.org/show_bug.cgi?id=59004

  • platform/chromium/test_expectations.txt:
9:39 AM Changeset in webkit [84383] by alex
  • 2 edits in trunk/Source/WebKit2

2011-04-20 Alejandro G. Castro <​alex@igalia.com>

Fixed GTK+ compilation after r84206.

  • GNUmakefile.am:
9:24 AM Changeset in webkit [84382] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Adjust test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=59002

  • platform/chromium/test_expectations.txt:
9:21 AM Changeset in webkit [84381] by Carlos Garcia Campos
  • 4 edits in trunk/Source

2011-04-20 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Build libWebCore with the gtk sources too
​https://bugs.webkit.org/show_bug.cgi?id=58968

In some cases webcore files are compiled twice, so it improves the
build time.

  • GNUmakefile.am: Add webcore gtk sources to libWebCore sources.

2011-04-20 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Build libWebCore with the gtk sources too
​https://bugs.webkit.org/show_bug.cgi?id=58968

In some cases webcore files are compiled twice, so it improves the
build time.

  • GNUmakefile.am: Remove webcore gtk sources from libwebkitgtk sources.
9:14 AM Changeset in webkit [84380] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-20 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Allow casting between CSSPrimitiveValue and EBorderCollapse to remove special-case logic from CSSStyleSelector.
​https://bugs.webkit.org/show_bug.cgi?id=58964

No new tests as no new functionality added.

  • css/CSSPrimitiveValueMappings.h: Support casting to/from EBorderCollapse.
  • css/CSSStyleSelector.cpp: Use new casting ability to simplify code.
  • rendering/style/RenderStyle.h: Use EBorderCollapse instead of a bool for representing border collapse member variable.
  • rendering/style/RenderStyleConstants.h: Added EBorderCollapse enum.
9:11 AM Changeset in webkit [84379] by Adam Roben
  • 19 edits
    18 copies
    4 adds
    1 delete in trunk/LayoutTests

Add Windows 7 SP1 baselines for some SVG tests that progressed in SP1

These baselines were previously thought to be WebKit2-specific. However, it turned out that
the WebKit2 bots had Windows 7 SP1 installed, while the WebKit1 bots just had Windows 7
installed, and that was the crucial difference. So this patch reclassifies the new baselines
as being SP1 vs. not-SP1, rather than WK2 vs. WK1. I also added pixel results.

Fixes <​http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
differences from Windows 7 "SP0"

  • platform/win-7sp0/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum:
  • platform/win-7sp0/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/win-7sp0/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum:
  • platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
  • platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum:
  • platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
  • platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum:
  • platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum:
  • platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/win-7sp0/svg/text/bidi-text-query-expected.checksum:
  • platform/win-7sp0/svg/text/bidi-text-query-expected.png:
  • platform/win-7sp0/svg/text/bidi-text-query-expected.txt:

Copied these results from platform/win.

  • platform/win-wk2/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
  • platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
  • platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/win-wk2/svg/text/bidi-text-query-expected.txt:

Moved these results to platform/win.

  • platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum:
  • platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum:
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum:
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum:
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum:
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/win/svg/text/bidi-text-query-expected.checksum:
  • platform/win/svg/text/bidi-text-query-expected.png:
  • platform/win/svg/text/bidi-text-query-expected.txt:

The .txt files came from platform/win-wk2, and the .png/.checksum files were
newly-generated.

9:05 AM Changeset in webkit [84378] by Martin Robinson
  • 1 edit
    3 deletes in trunk/LayoutTests

2011-04-20 Martin Robinson <​mrobinson@igalia.com>

platform/gtk/fast/dom/gc-10-expected.png is corrupt
​https://bugs.webkit.org/show_bug.cgi?id=58940

Remove expected results for fast/dom/gc-10.html since it is crashing on GTK+.

  • platform/gtk/fast/dom/gc-10-expected.checksum: Removed.
  • platform/gtk/fast/dom/gc-10-expected.png: Removed.
  • platform/gtk/fast/dom/gc-10-expected.txt: Removed.
9:05 AM Changeset in webkit [84377] by Adam Roben
  • 3 edits in trunk/Tools

Replace old-run-webkit-tests's win-7 platform with win-7sp0

It was an error that we had a win-7 platform to begin with. Windows 7 was the most recent
version of Windows we cared about, so its results should just go in win. But now that
Windows 7 SP1 exists (and has different results for some tests), we need a place to store
results for Windows 7 without SP1 (and older versions of Windows).

Part of <​http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
differences from Windows 7 "SP0"

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests: Replaced win-7 with win-7sp0. Newer versions of Windows 7

will just use "win".

  • Scripts/webkitdirs.pm:

(isWindows7SP0): Added. Replaces isWindows7, because that function had no remaining callers.

8:44 AM Changeset in webkit [84376] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Mark css2.1/t140201-c533-bgimage-00-a.html as crash on Linux, Win Debug
​https://bugs.webkit.org/show_bug.cgi?id=58995

Accidentally indicated MAC instead of WIN.

  • platform/chromium/test_expectations.txt:
8:39 AM Changeset in webkit [84375] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Mark css2.1/t140201-c533-bgimage-00-a.html as crash on Linux, Win Debug
​https://bugs.webkit.org/show_bug.cgi?id=58995

  • platform/chromium/test_expectations.txt:
7:54 AM Changeset in webkit [84374] by senorblanco@chromium.org
  • 7 edits
    2 moves in trunk/Source/WebCore

2011-04-19 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Move and rename GLES2Canvas.
​https://bugs.webkit.org/show_bug.cgi?id=58927

Move GLES2Canvas to platform/graphcs/gpu, where all the other
gpu-related files live, and rename it to GraphicsContextGPU to better
reflect its purpose.

Covered by existing tests.

  • WebCore.gypi:
  • platform/graphics/chromium/GLES2Canvas.cpp:
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/ImageBufferSkia.cpp:
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::drawBitmapGLES2):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
  • platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::gpuCanvas):
7:46 AM Changeset in webkit [84373] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Clean the style of our cookie methods
​https://bugs.webkit.org/show_bug.cgi?id=58987

Reviewed by Andreas Kling.

Got rid of the variables named "u" in favor just converting the url when needed.

  • platform/qt/CookieJarQt.cpp:

(WebCore::setCookies): The variable p was unused.
The ::toAscii() depends on the default codec, use toLatin1() instead.
(WebCore::cookies): foreach() should use const reference.
(WebCore::cookieRequestHeaderFieldValue):

7:44 AM Changeset in webkit [84372] by Adam Roben
  • 2 edits in trunk/Tools

Teach webkitdirs::winVersion about build numbers

The build number isn't currently used, but soon will be.

As a bonus, winVersion now works on non-Cygwin variants of Perl!

Fixes <​http://webkit.org/b/58991> Need a way to distinguish between Windows 7 and Windows 7
SP1

Reviewed by Anders Carlsson.

  • Scripts/webkitdirs.pm:

(isAnyWindows): Added. Returns true if we're running on any Windows-ish Perl.
(determineWinVersion): Use cmd /c ver to get the version number, including the build
number. Parse the version number into a hash, similar to how osXVersion() works.

(isWindows7):
(isWindowsVista):
(isWindowsXP):
Updated for changes to winVersion().

7:40 AM Changeset in webkit [84371] by mihaip@chromium.org
  • 37 edits in trunk/Source/WebCore

2011-04-19 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

ScriptController.h is included in too many places
​https://bugs.webkit.org/show_bug.cgi?id=58963

Remove ScriptController.h #includes from a bunch of .cpp files where it
doesn't appear to be necessary.

  • bindings/js/JSCustomPositionCallback.cpp:
  • bindings/js/JSCustomPositionErrorCallback.cpp:
  • bindings/js/JSCustomVoidCallback.cpp:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/ScriptDebugServer.cpp:
  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/ScriptCachedFrameData.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8IsolatedContext.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • dom/Node.cpp:
  • dom/ScriptElement.cpp:
  • dom/XMLDocumentParser.cpp:
  • dom/XMLDocumentParserQt.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLTreeBuilder.cpp:
  • inspector/InspectorProfilerAgent.cpp:
  • loader/icon/IconDatabase.cpp:
  • page/Chrome.cpp:
  • page/Navigator.cpp:
  • page/Page.cpp:
  • plugins/PluginView.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/symbian/PluginViewSymbian.cpp:
  • plugins/win/PluginViewWin.cpp:
  • svg/SVGDocumentExtensions.cpp:
  • xml/XMLTreeViewer.cpp:
7:23 AM Changeset in webkit [84370] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Remove some unnecessary VS junk related to NativeWebMouseEventWin.cpp

  • win/WebKit2.vcproj:
7:21 AM Changeset in webkit [84369] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Snow Leopard Intel WebKit2 Release Tests] editing/execCommand/convert-style-elements-to-spans.html
flakey.
​https://bugs.webkit.org/show_bug.cgi?id=58183

Skip the flakey test in order to get the bots green.

  • platform/mac-wk2/Skipped:
7:17 AM Changeset in webkit [84368] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Leon Scroggins <​scroggo@google.com>

Reviewed by Kenneth Russell.

Mark tests as failing for rebaselining.
​https://bugs.webkit.org/show_bug.cgi?id=58839

We are making a change to the way gradients
are calculated, so disable tests for now.

  • platform/chromium/test_expectations.txt:
7:11 AM Changeset in webkit [84367] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-04-20 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip GTK crashing test
storage/open-database-set-empty-version.html.

  • platform/gtk/Skipped:
7:04 AM Changeset in webkit [84366] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKit2 needs layoutTestController.overridePreference
​https://bugs.webkit.org/show_bug.cgi?id=42197

Add another test that uses layoutTestController.overridePreference
(fast/loader/scroll-position-restored-on-back.html) to the Skipped list to get the bots
green.

  • platform/mac-wk2/Skipped:
6:49 AM Changeset in webkit [84365] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-20 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add Save As to the Resources panel context menu.
​https://bugs.webkit.org/show_bug.cgi?id=58983

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype.onattach): (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent.save): (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent): (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.save): (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
6:46 AM Changeset in webkit [84364] by kbalazs@webkit.org
  • 8 edits in trunk/Source

2011-04-20 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Cleanup includepath adjustment for generated files
​https://bugs.webkit.org/show_bug.cgi?id=58869

  • JavaScriptCore.pri: Add the directory of generated files to the include path with absolute path to make it valid in the final build step.

2011-04-20 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Cleanup includepath adjustment for generated files
​https://bugs.webkit.org/show_bug.cgi?id=58869

Build cleanup, no new tests.

  • WebCore.pri: Add the directory of generated files to the include path with absolute path to make it valid in the final build step. Remove unnecessary logic.

2011-04-20 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Cleanup includepath adjustment for generated files
​https://bugs.webkit.org/show_bug.cgi?id=58869

  • QtWebKit.pro: Revert the hacky fix in r84174. Remove unnecessary logic.

2011-04-20 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Cleanup includepath adjustment for generated files
​https://bugs.webkit.org/show_bug.cgi?id=58869

  • WebKit2.pri: Add the directory of generated files to the include path with absolute path to make it valid in the final build step.
6:42 AM Changeset in webkit [84363] by jknotten@chromium.org
  • 8 edits
    1 move
    8 deletes in trunk/LayoutTests

2011-04-20 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Rebaseline some border-related tests on Mac
​https://bugs.webkit.org/show_bug.cgi?id=58985

Most likely related to ​http://trac.webkit.org/changeset/84341/
"background color of elements with border-radius shows around outer edge of border at corners"

  • platform/chromium-mac-leopard/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-narrow-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-narrow-width-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png: Removed.
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.png: Removed.
  • platform/chromium-mac/fast/forms/select-baseline-expected.png: Removed.
  • platform/chromium-mac/fast/forms/select-empty-option-height-expected.png: Removed.
6:20 AM Changeset in webkit [84362] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-20 Mariusz Grzegorczyk <​mariusz.g@samsung.com>

Reviewed by Andreas Kling.

[EFL] Initializing m_window member field in PluginView.cpp for efl port
​https://bugs.webkit.org/show_bug.cgi?id=58311

No new tests needed: only initializing class member.

  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
6:17 AM Changeset in webkit [84361] by wjmaclean@chromium.org
  • 6 edits in trunk/Tools

2011-04-20 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by Kenneth Russell.

Add support for composite-to-texture to DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=58675

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::setCompositeToTexture):
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h:
5:45 AM Changeset in webkit [84360] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Tony Gentilcore.

http/tests/misc/unloadable-script.html fails if <script> error event doesn't bubble
​https://bugs.webkit.org/show_bug.cgi?id=58981

  • http/tests/misc/unloadable-script.html: canged the test so that it uses <script onerror> instead od <body onerror>
5:40 AM Changeset in webkit [84359] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-20 Pavel Feldman <​pfeldman@google.com>

Not reviewed: fix Leopard compile.

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.h: (WebCore::InspectorFrontendClientLocal::saveAs):
5:27 AM Changeset in webkit [84358] by pfeldman@chromium.org
  • 15 edits in trunk/Source

2011-04-20 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add saveAs into the InspectorFrontendHost binding.
​https://bugs.webkit.org/show_bug.cgi?id=58979

  • English.lproj/localizedStrings.js:
  • inspector/InspectorFrontendClient.h: (WebCore::InspectorFrontendClient::saveAs): (WebCore::InspectorFrontendClient::saveSessionSetting): (WebCore::InspectorFrontendClient::loadSessionSetting):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::saveAs):
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.saveAs.fr.onload): (.WebInspector.InspectorFrontendHostStub.prototype.saveAs):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu): (WebInspector.NetworkPanel.prototype._copyAll): (WebInspector.NetworkPanel.prototype._copyResource): (WebInspector.NetworkPanel.prototype._exportAll): (WebInspector.NetworkPanel.prototype._exportResource):
  • inspector/front-end/Settings.js:
  • inspector/front-end/utilities.js: ():

2011-04-20 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: add saveAs into the InspectorFrontendHost binding.
​https://bugs.webkit.org/show_bug.cgi?id=58979

  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::saveAs):
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::saveAs):
  • src/InspectorFrontendClientImpl.h:
  • src/js/DevTools.js:
4:52 AM Changeset in webkit [84357] by yurys@chromium.org
  • 12 edits
    2 adds in trunk

2011-04-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Tony Gentilcore.

Error event in <script> element shouldn't bubble
​https://bugs.webkit.org/show_bug.cgi?id=51040

  • fast/events/onerror-bubbling-expected.txt:
  • fast/events/onerror-bubbling.html:
  • svg/dom/SVGScriptElement/script-load-and-error-events.svg: error event is dispatched on the corresponding SVGScriptElement and shouldn't bubble, so the global error handler should never be invoked for script load errors. This behaviour is consistent with HTMLScriptElement element.
  • svg/dom/SVGScriptElement/script-onerror-bubbling-expected.txt: Added.
  • svg/dom/SVGScriptElement/script-onerror-bubbling.svg: Added.

2011-04-20 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Tony Gentilcore.

Error event in <script> element shouldn't bubble
​https://bugs.webkit.org/show_bug.cgi?id=51040

Test: svg/dom/SVGScriptElement/script-onerror-bubbling.svg

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::dispatchErrorEvent): the method now has same implementation for all script elements, script load error event doesn' bubble.
  • dom/ScriptElement.h:
  • html/HTMLScriptElement.cpp:
  • html/HTMLScriptElement.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::parseMappedAttribute): SVG script element now supports onerror hanlder which behaves the same way as onerror in HTML script element: it's invoked when script loading fails and the event doesn't bubble.
  • svg/SVGScriptElement.h:
4:10 AM Changeset in webkit [84356] by jknotten@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-04-20 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Rebaseline fast/repaint/trailing-floats-root-line-box-overflow fast/canvas/webgl/css-webkit-canvas fast/canvas/webgl/css-webkit-canvas-repaint
​https://bugs.webkit.org/show_bug.cgi?id=58978

Windows bots are now generating baselines, so include them.
fast/repaint/trailing-floats-root-line-box-overflow looks like correct output.

  • platform/chromium-mac/fast/repaint/trailing-floats-root-line-box-overflow-expected.png: Added.
  • platform/chromium-win/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
  • platform/chromium-win/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:57 AM Changeset in webkit [84355] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-then-forward.html fails
​https://bugs.webkit.org/show_bug.cgi?id=58977

  • platform/qt/Skipped: Add platform/qt/fast/history/back-to-unreachable-url-then-forward.html.
3:00 AM Changeset in webkit [84354] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-04-20 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing test on GTK.

[GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=58976

  • platform/gtk/Skipped:
2:44 AM Changeset in webkit [84353] by Philippe Normand
  • 5 edits
    21 adds in trunk/LayoutTests

2011-04-20 Philippe Normand <​pnormand@igalia.com>

Unreviewed, new GTK baselines for tests added in r84273.
Also skip a couple of failing tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/backgrounds/background-leakage-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/background-leakage-expected.png: Added.
  • platform/gtk/fast/backgrounds/background-leakage-expected.txt: Added.
  • platform/gtk/fast/backgrounds/background-leakage-transforms-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/gtk/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
  • platform/gtk/fast/backgrounds/border-radius-split-background-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/border-radius-split-background-expected.png: Added.
  • platform/gtk/fast/backgrounds/border-radius-split-background-expected.txt: Added.
  • platform/gtk/fast/backgrounds/border-radius-split-background-image-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
  • platform/gtk/fast/backgrounds/border-radius-split-background-image-expected.txt: Added.
  • platform/gtk/fast/borders/border-radius-different-width-001-expected.checksum: Added.
  • platform/gtk/fast/borders/border-radius-different-width-001-expected.png: Added.
  • platform/gtk/fast/borders/border-radius-different-width-001-expected.txt: Added.
  • platform/gtk/fast/borders/border-radius-inset-outset-expected.checksum: Added.
  • platform/gtk/fast/borders/border-radius-inset-outset-expected.png: Added.
  • platform/gtk/fast/borders/border-radius-inset-outset-expected.txt: Added.
  • platform/gtk/fast/borders/table-borders-expected.checksum: Added.
  • platform/gtk/fast/borders/table-borders-expected.png: Added.
  • platform/gtk/fast/borders/table-borders-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.txt:
  • platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.txt:
  • platform/gtk/fast/borders/border-styles-split-expected.txt:
2:35 AM Changeset in webkit [84352] by jknotten@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-04-20 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Rebaseline overhanging-tall-block
​https://bugs.webkit.org/show_bug.cgi?id=58974

  • platform/chromium-win/fast/block/float/overhanging-tall-block-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:21 AM Changeset in webkit [84351] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-20 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: minor protocol cleanups (refined types).
​https://bugs.webkit.org/show_bug.cgi?id=58970

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
1:32 AM WebKit Team edited by leo.yang@torchmobile.com.cn
(diff)
1:16 AM Changeset in webkit [84350] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-20 Leo Yang <​leo.yang@torchmobile.com.cn>

Reviewed by Eric Seidel.

Leaks beneath RenderSVGShadowTreeRootContainer::updateFromElement seen on SnowLeopard Intel Leaks
​https://bugs.webkit.org/show_bug.cgi?id=56672

~RenderSVGShadowTreeRootContainer() cleared shadow host only if
the shadow root is attached. This is wrong because it will
leak shadow root when the root is not attached. For example, it
leaks shadow root of <use> element which is pending on resource.

This patch is clearing shadow host if m_shadowRoot is valid to
prevent leaking.

Fixing leaking, no new tests.

  • rendering/svg/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
12:39 AM Changeset in webkit [84349] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-19 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Antti Koivisto.

Reproducible crash two-finger zooming at multiple sites in WebCore::RenderLayer::isTransparent
​https://bugs.webkit.org/show_bug.cgi?id=58868

I could not figure out how to make a test.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Check for existence of a parent before calling a method on it.
12:18 AM Changeset in webkit [84348] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-04-20 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Daniel Bates.

[EFL] Add current time to media control panel.
​https://bugs.webkit.org/show_bug.cgi?id=58866

Implement paintMediaCurrentTime() to show playing time of media content.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::RenderThemeEfl): (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime): (WebCore::RenderThemeEfl::paintMediaCurrentTime):
  • platform/efl/RenderThemeEfl.h:

Apr 19, 2011:

11:24 PM Changeset in webkit [84347] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
11:02 PM Changeset in webkit [84346] by jshin@chromium.org
  • 3 edits
    2 adds in trunk

2011-04-19 Jungshik Shin <​jshin@chromium.org>

Reviewed by Adam Barth

Update the list of Unicode blocks to treat as complex scripts
per Unicode 6.0. Also, make [U+02E5..U+02E9] (IPA tone marks)
go through the complex script code path.

Test: fast/text/ipa-tone-letters.html

​http://bugs.webkit.org/show_bug.cgi?id=39799

  • platform/graphics/Font.cpp: (WebCore::Font::codePath):

2011-04-19 Jungshik Shin <​jshin@chromium.org>

Reviewed by Adam Barth

Add a test to test sequences of IPA tone letters are
ligated regardless of text-rendering mode (fast codepath or not).
The test explicitly specifies Arial because it's one of a few fonts
to have layout table entries to support the ligation of IPA tone
letters.

​http://bugs.webkit.org/show_bug.cgi?id=39799

  • fast/text/ipa-tone-letters.html: Added.
11:01 PM Changeset in webkit [84345] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Add chromium suppressions resulting from r84341 - 84344.

  • platform/chromium/test_expectations.txt:
10:45 PM Changeset in webkit [84344] by psolanki@apple.com
  • 3 edits in trunk/Source/WebCore

Follow on fix for ​https://bugs.webkit.org/show_bug.cgi?id=58926

Reviewed by Simon Fraser.

Move the assert from Image::drawPattern() to Image::drawTiled() so we don't hit it when
trying to paint GeneratedImages.

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):

10:32 PM Changeset in webkit [84343] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-04-19 Simon Fraser <Simon Fraser>

Fix 32-bit builds.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::determineBackgroundBleedAvoidance):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
10:16 PM Changeset in webkit [84342] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-04-19 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium]UI polishes and tweaks to Autofill dropdown menu.
​https://bugs.webkit.org/show_bug.cgi?id=58505
​http://code.google.com/p/chromium/issues/detail?id=51077

No new tests. Because this is autofill looking problem in Chromium.
Add m_menuType as PopupMenuStyle to change popup style change.
Put kLinePaddingHeight at the top and bottom of each line if m_menuType is AutofillPopup.
Change separator color to #dcdcdc and remove sparatorPadding at the edge if m_menuType is AutofillPopup.
Change the line height of separator as only the piece if m_menuType is AutofillPopup.
Change the label font size 0.9 time smaller than regular font size if m_menuType is AutofillPopup.

  • platform/PopupMenuStyle.h: Add enum PopupMenuType; (WebCore::PopupMenuStyle::PopupMenuStyle): Add m_menuType. (WebCore::PopupMenuStyle::menuType): Add to change the style according to the return value.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow):Change the separator color to #dcdcdc. Change the edge padding according to menuStyle(). (WebCore::PopupListBox::getRowHeight): Add kLineHeightMargin*2 for each line height.

2011-04-19 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium]UI polishes and tweaks to Autofill dropdown menu.
​https://bugs.webkit.org/show_bug.cgi?id=58505

  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::initialize): Set AutofillPopup for menuStyle.
10:13 PM Changeset in webkit [84341] by Simon Fraser
  • 87 edits
    4 adds in trunk

2011-04-19 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

background color of elements with border-radius shows around outer edge of border at corners
​https://bugs.webkit.org/show_bug.cgi?id=21819

When drawing a background followed by a border with the same rounded
clip, some border color leaks out because of antialiasing.

Fix this by using two different strategies depending on the colors.
If the border is opaque on all sides, we can inset the background by
a device pixel. If not, then we have to draw the unclipped background
and border into a transparency layer, and then clip that.

A futher possible solution is mentioned in a comment in
determineBackgroundBleedAvoidance() but not yet implemented.

Also don't try to paint shadows with zero offset, spread and blur.

Test: fast/backgrounds/background-leakage.html,

fast/backgrounds/background-leakage-transforms.html

  • rendering/RenderBoxModelObject.h: Add a BackgroundBleedAvoidance enum with a value for each strategy.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Pass BackgroundBleedAvoidance, bail early if the border rect is empty. If using the transparency layer solution, don't bother to clip to the rounded rect for the background. If the strategy is to shrink the background, do that. (WebCore::BorderEdge::BorderEdge): (WebCore::BorderEdge::obscuresBackgroundEdge): Helper method to determine if this border side will totally obscured by the border edge, allowing us to inset it. (WebCore::RenderBoxModelObject::paintOneBorderSide): Pass BackgroundBleedAvoidance through. (WebCore::RenderBoxModelObject::paintBorderSides): Ditto. (WebCore::RenderBoxModelObject::paintTranslucentBorderSides): Ditto. (WebCore::RenderBoxModelObject::paintBorder): Fill BorderEdges using getBorderEdgeInfo now. Don't clip to the rounded border if we are using the transparency layer solution. (WebCore::RenderBoxModelObject::drawBoxSideFromPath): Pass bleedAvoidance through, and use it for double borders. (WebCore::RenderBoxModelObject::getBorderEdgeInfo): Helper to fill in the BorderEdge array. (WebCore::RenderBoxModelObject::borderObscuresBackgroundEdge): Used to determine if we can use the background shrinkage solution. (WebCore::RenderBoxModelObject::paintBoxShadow): Don't paint shadows that should not be visible.
  • rendering/RenderBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxFillLayers): Pass BackgroundBleedNone for the root box.

(WebCore::RenderBox::determineBackgroundBleedAvoidance):
Determine which bleed strategy we can use.

(WebCore::RenderBox::paintBoxDecorationsWithSize):
Based on the bleedAvoidance, make a transparency layer
which will be clipped to the rounded border outside edge,
and pass bleedAvoidance to the background and border-painting
methods.
(WebCore::RenderBox::paintMaskImages):
Use BackgroundBleedNone.
(WebCore::RenderBox::paintFillLayers):
(WebCore::RenderBox::paintFillLayer):
Pass bleedAvoidance through.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): Pass BackgroundBleedNone. At some point we may want to do the right thing for split inlines.
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): Pass BackgroundBleedNone.
9:51 PM Changeset in webkit [84340] by yutak@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-19 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket: Add assertion for SocketStreamError::failingURL.
​https://bugs.webkit.org/show_bug.cgi?id=58765

No new tests, because an existing test http/tests/inspector/console-websocket-error.html should cover this.

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didFail): If error.failingURL() is provided, it must be the same as m_handshake.url(). failingURL may be null if SocketStreamHandle has created a SocketStreamError using zero- or one-argument constructor (which is old version but some ports are still using it). In that case, m_handshake.url() is passed to addMessage().
9:33 PM Changeset in webkit [84339] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
9:15 PM Changeset in webkit [84338] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
9:11 PM Changeset in webkit [84337] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
9:04 PM Changeset in webkit [84336] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-04-19 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dimitri Glazkov.

Media controls status display should not be hidden for live streams
​https://bugs.webkit.org/show_bug.cgi?id=58952

Tested manually because we don't have any live streams to test in DRT.

  • html/shadow/MediaControlElements.cpp: (WebCore::MediaControlStatusDisplayElement::update): Set the status to "Loading" only until

there is something to display (readyState exceeds HAVE_METADATA).

  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::loadedMetadata): Don't hide the status display for

live streams.

8:35 PM Changeset in webkit [84335] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 Dmitry Titov <​dimich@chromium.org>

Reviewed by David Levin.

new-run-webkit-tests: remove formerly flakey tests form test_expectations.
​https://bugs.webkit.org/show_bug.cgi?id=57678

Tests fixed by ​http://trac.webkit.org/changeset/83900

  • platform/mac/test_expectations.txt:
8:21 PM Changeset in webkit [84334] by yi.4.shen@nokia.com
  • 4 edits in trunk/Source/WebKit/qt

2011-04-19 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt][Symbian] Fix Api test failure -- tst_QWebView::setPalette()
​https://bugs.webkit.org/show_bug.cgi?id=57254

Skip test for setPalette() which doesn't work
when WTF_USE_QT_MOBILE_THEME is defined.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:
  • tests/qwebview/tst_qwebview.cpp:
  • tests/tests.pri:
8:17 PM Changeset in webkit [84333] by eric@webkit.org
  • 6 edits in trunk/Tools

2011-04-19 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

The commit-queue is confused when non-layout tests fail
​https://bugs.webkit.org/show_bug.cgi?id=58955

As seen in ​http://queues.webkit.org/results/8474435

It fails to create an archive of the layout test results
and then throws an exception.

I've fixed this by making it catch the exception as well
as made it so it never calls that path in the common case.

I've updated MockFileSystem to understand rmtree's affect on
directories as well as files.

  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
7:56 PM Changeset in webkit [84332] by yi.4.shen@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-04-19 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache
​https://bugs.webkit.org/show_bug.cgi?id=58044

Fixing this test by disabling the scrollbars on the graphics view
since QtWebKit handles scrolling and scrollbar automatically and correctly.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::widgetsRenderingThroughCache):
7:31 PM Changeset in webkit [84331] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
7:21 PM Changeset in webkit [84330] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-19 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, attempting build fix.

Disable leveldb to work around
​http://code.google.com/p/leveldb/issues/detail?id=1.

  • features.gypi:
7:13 PM Changeset in webkit [84329] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

2011-04-19 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=45425
HTMLLinkElement.disabled does not forward value to the Stylesheet's disabled attribute on setting

Test case by Bijan Amirzada <​bijana@codeaurora.org>.

  • fast/dom/HTMLLinkElement/disabled-attribute-expected.txt: Added.
  • fast/dom/HTMLLinkElement/disabled-attribute.html: Added. Test that the properties are properly forwarded to the stylesheet.
  • fast/dom/boolean-attribute-reflection-expected.txt:
  • fast/dom/script-tests/boolean-attribute-reflection.js: Removed link:disabled as it is not reflected anymore.

2011-04-19 Julien Chaffraix <​jchaffraix@codeaurora.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=45425
HTMLLinkElement.disabled does not forward value to the Stylesheet's disabled attribute on setting

Test: fast/html/htmllink-disable.html
Test: fast/dom/HTMLLinkElement/disabled-attribute.html

Match the HTML5 specification by forwarding the 'disabled' attribute to our stylesheet.

Based on previous work by Bijan Amirzada <​bijana@codeaurora.org>.

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::disabled): Return our stylesheet's 'disabled' value or false if we don't have a stylesheet. (WebCore::HTMLLinkElement::setDisabled): Set our stylesheet's 'disabled' value or ignore the call if we don't have a stylesheet.
  • html/HTMLLinkElement.h:
  • html/HTMLLinkElement.idl: Remove 'Reflect' as it is not a reflected attribute anymore in HTML5. This matches the way FF4, Opera and IE9 handle the attribute.
7:12 PM Changeset in webkit [84328] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-19 Dominic Cooney <​dominicc@chromium.org>

Reviewed by Dimitri Glazkov.

Check the type of the wrapper when unwrapping NPObjects to native
Ranges and Elements
​https://bugs.webkit.org/show_bug.cgi?id=58957

  • src/WebBindings.cpp: (WebKit::getRangeImpl): check HasInstance (WebKit::getElementImpl): check HasInstance
6:56 PM Changeset in webkit [84327] by Simon Fraser
  • 61 edits in trunk/LayoutTests

2011-04-19 Simon Fraser <Simon Fraser>

Rebaseline image results with diffs below the default tolerance,
after earlier border drawing changes.

  • platform/mac/fast/backgrounds/background-leakage-expected.checksum:
  • platform/mac/fast/backgrounds/background-leakage-expected.png:
  • platform/mac/fast/backgrounds/border-radius-split-background-expected.checksum:
  • platform/mac/fast/backgrounds/border-radius-split-background-expected.png:
  • platform/mac/fast/backgrounds/border-radius-split-background-image-expected.checksum:
  • platform/mac/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/mac/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/mac/fast/box-shadow/basic-shadows-expected.png:
  • platform/mac/fast/box-shadow/inset-box-shadows-expected.checksum:
  • platform/mac/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/mac/fast/box-shadow/inset-expected.checksum:
  • platform/mac/fast/box-shadow/inset-expected.png:
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum:
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/mac/fast/css/nested-rounded-corners-expected.checksum:
  • platform/mac/fast/css/nested-rounded-corners-expected.png:
  • platform/mac/fast/forms/001-expected.checksum:
  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/basic-selects-expected.checksum:
  • platform/mac/fast/forms/basic-selects-expected.png:
  • platform/mac/fast/forms/menulist-clip-expected.checksum:
  • platform/mac/fast/forms/menulist-clip-expected.png:
  • platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/mac/fast/forms/menulist-narrow-width-expected.png:
  • platform/mac/fast/forms/menulist-option-wrap-expected.checksum:
  • platform/mac/fast/forms/menulist-option-wrap-expected.png:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/mac/fast/forms/menulist-separator-painting-expected.checksum:
  • platform/mac/fast/forms/menulist-separator-painting-expected.png:
  • platform/mac/fast/forms/menulist-style-color-expected.checksum:
  • platform/mac/fast/forms/menulist-style-color-expected.png:
  • platform/mac/fast/forms/select-background-none-expected.checksum:
  • platform/mac/fast/forms/select-background-none-expected.png:
  • platform/mac/fast/forms/select-baseline-expected.checksum:
  • platform/mac/fast/forms/select-baseline-expected.png:
  • platform/mac/fast/forms/select-empty-option-height-expected.checksum:
  • platform/mac/fast/forms/select-empty-option-height-expected.png:
  • platform/mac/fast/forms/select-style-expected.checksum:
  • platform/mac/fast/forms/select-style-expected.png:
  • platform/mac/fast/forms/validation-message-appearance-expected.checksum:
  • platform/mac/fast/forms/validation-message-appearance-expected.png:
  • platform/mac/fast/overflow/border-radius-clipping-expected.checksum:
  • platform/mac/fast/overflow/border-radius-clipping-expected.png:
  • platform/mac/fast/repaint/border-radius-repaint-expected.checksum:
  • platform/mac/fast/repaint/border-radius-repaint-expected.png:
  • platform/mac/fast/repaint/control-clip-expected.checksum:
  • platform/mac/fast/repaint/control-clip-expected.png:
  • platform/mac/fast/repaint/selection-after-remove-expected.checksum:
  • platform/mac/fast/repaint/selection-after-remove-expected.png:
6:18 PM Changeset in webkit [84326] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-19 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Remove calls to deprecatedOffset and deprecatedNode in TypingCommand
​https://bugs.webkit.org/show_bug.cgi?id=58569

Removed all calls to deprecatedOffset and deprecatedNode.

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
6:17 PM Changeset in webkit [84325] by crogers@google.com
  • 5 edits
    1 add
    4 deletes in trunk/LayoutTests

2011-04-19 Chris Rogers <​crogers@google.com>

Unreviewed.

Rebaseline some tests and update test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=58954

  • platform/chromium-mac-leopard/fast/overflow/border-radius-clipping-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/overflow/border-radius-clipping-expected.png:
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png: Removed.
  • platform/chromium-mac/fast/overflow/border-radius-clipping-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/fast/text/justification-padding-mid-word-expected.txt:
  • platform/chromium/test_expectations.txt:
6:01 PM Changeset in webkit [84324] by jamesr@google.com
  • 1 edit
    1 add in trunk/LayoutTests

2011-04-19 James Robinson <​jamesr@chromium.org>

[win] New test compositing/iframes/invisible-nested-iframe-show.html fails on windows
​https://bugs.webkit.org/show_bug.cgi?id=58951

Add a failing expectation for this test on windows.

  • platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
5:51 PM Changeset in webkit [84323] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-19 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Initialize depth mask to known value before getBooleanv call
​https://bugs.webkit.org/show_bug.cgi?id=58948

This trips an assert in the GPU command buffer client code if the
pointed-to value is not initialized to 0 or -1.

  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clearFramebuffer):
5:50 PM Changeset in webkit [84322] by Simon Fraser
  • 1 edit
    8 adds in trunk/LayoutTests

2011-04-19 Simon Fraser <Simon Fraser>

Add missing results for fast/borders/table-borders.html, and
a new test that shows the background color leaking out through the
border (to facilitate image diffs for an upcoming change).

  • fast/backgrounds/background-leakage.html: Added.
  • platform/mac/compositing/reflections/backface-hidden-reflection-expected.txt: Added.
  • platform/mac/fast/backgrounds/background-leakage-expected.checksum: Added.
  • platform/mac/fast/backgrounds/background-leakage-expected.png: Added.
  • platform/mac/fast/backgrounds/background-leakage-expected.txt: Added.
  • platform/mac/fast/borders/table-borders-expected.checksum: Added.
  • platform/mac/fast/borders/table-borders-expected.png: Added.
  • platform/mac/fast/borders/table-borders-expected.txt: Added.
5:35 PM Changeset in webkit [84321] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

BitmapImage::destroyMetadataAndNotify should clear m_checkedForSolidColor
​https://bugs.webkit.org/show_bug.cgi?id=58926

Reviewed by Simon Fraser.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyMetadataAndNotify): Set m_checkedForSolidColor to false.

  • platform/graphics/BitmapImage.h:

(WebCore::BitmapImage::assertNotSolidColor):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern): Add assert to make sure this is not called for a 1x1 image.

5:23 PM Changeset in webkit [84320] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-19 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

REGRESSION(r83967): Crash in selectionExtentRespectingEditingBoundary
​https://bugs.webkit.org/show_bug.cgi?id=58910

The crash was caused by selectionExtentRespectingEditingBoundary's incorrectly assuming that
targetNode always have renderer when there selection has an editable root and the target node
is outside of the editable root.


Fixed the bug by adding an early exit when the target node is null.

No new tests are added since we don't have a reduction for this crash.

  • page/EventHandler.cpp: (WebCore::selectionExtentRespectingEditingBoundary):
5:04 PM Changeset in webkit [84319] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix v8 build.

  • bindings/scripts/CodeGeneratorV8.pm: This is a pretty bad system.
5:00 PM Changeset in webkit [84318] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-04-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

UI process thinks the page is unresponsive when a plug-in is showing a context menu
​https://bugs.webkit.org/show_bug.cgi?id=58943
<rdar://problem/9299901>

Change the HandleMouseEvent message to have a delayed reply and make the PluginControllerProxy
respond to it immediately, before even passing the event to the plug-in. Since it doesn't matter
for mouse events whether the plug-in handled them or not we can do this.

Another solution could have been to make handleMouseEvent an asynchronous message, but that could
mess up the message ordering so this seemed like the least intrusive change.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::handleMouseEvent):
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:
4:59 PM Changeset in webkit [84317] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-19 Ojan Vafai <​ojan@chromium.org>

Fix check for whether a failure is expected to deal with
flaky tests and FAIL expectations.

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
4:58 PM Changeset in webkit [84316] by crogers@google.com
  • 18 edits
    20 adds
    17 deletes in trunk/LayoutTests

2011-04-19 Chris Rogers <​crogers@google.com>

Unreviewed.

Rebaseline a bunch of border-radius related layout tests for chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=58945

  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-constraints-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-inline-flow-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/borders/border-radius-inline-flow-expected.png:
  • platform/chromium-mac-leopard/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-mac-leopard/fast/borders/svg-as-border-image-2-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/borders/svg-as-border-image-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/chromium-mac-leopard/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/font_property_normal-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-clip-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-narrow-width-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/forms/menulist-narrow-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-circle-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.checksum:
  • platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png: Removed.
  • platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-mac/fast/css/nested-rounded-corners-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-mac/fast/forms/basic-selects-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-narrow-width-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-separator-painting-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png:
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-background-none-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-baseline-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-empty-option-height-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:52 PM Changeset in webkit [84315] by crogers@google.com
  • 17 edits
    19 adds
    12 deletes in trunk/LayoutTests

2011-04-19 Chris Rogers <​crogers@google.com>

Unreviewed.

Rebase a bunch of border-radius related layout tests
​https://bugs.webkit.org/show_bug.cgi?id=58942

  • platform/chromium-linux/css2.1/t0805-c5517-brdr-s-00-c-expected.checksum: Removed.
  • platform/chromium-linux/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-linux/fast/backgrounds/border-radius-split-background-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum: Removed.
  • platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.checksum: Removed.
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac-leopard/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/inset-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/border-radius-split-background-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac/fast/borders/table-borders-expected.png: Added.
  • platform/chromium-mac/fast/borders/table-borders-expected.txt: Added.
  • platform/chromium-mac/fast/box-shadow/inset-expected.png: Added.
  • platform/chromium-mac/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-win-vista/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
  • platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.checksum: Removed.
  • platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/chromium-win/fast/backgrounds/border-radius-split-background-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/border-radius-split-background-expected.txt: Added.
  • platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.txt: Added.
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum: Removed.
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/table-borders-expected.png: Added.
  • platform/chromium-win/fast/borders/table-borders-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.checksum: Removed.
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium/test_expectations.txt:
4:48 PM Changeset in webkit [84314] by tony@chromium.org
  • 104 edits in trunk/LayoutTests

2011-04-19 Tony Chang <​tony@chromium.org>

Add checksums to png files in platform win, win-wk2, and win-xp.

4:43 PM Changeset in webkit [84313] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-04-19 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

don't show missing text results for tests that only dump image results
​https://bugs.webkit.org/show_bug.cgi?id=58931

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
4:38 PM Changeset in webkit [84312] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-19 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

don't show failures table if there are only new tests
​https://bugs.webkit.org/show_bug.cgi?id=58929

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
4:37 PM Changeset in webkit [84311] by enrica@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION(r55762): Highlight color can't be copied in gmail.
​https://bugs.webkit.org/show_bug.cgi?id=58925
<rdar://problem/9253057>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/pasteboard/copy-text-with-backgroundcolor.html

The changes of r55762 uncovered the underlying issue here. The markup fragment
placed in the pasteboard does not contain the background color style.
This occurs only if the selection is limited to a single text node, whereas if the
selection spans across multiple nodes, the style is preserved correctly.
The fix consists in changing the logic that decides whether we should include the wrapping
node in the markup. That logic is based on the code in highestAncestorToWrapMarkup which relies
on isElementPresentational to choose candidates to be the wrapping node.
I've extended it to accept nodes that have non fully transparent background colors.

  • editing/Editor.cpp:

(WebCore::Editor::hasTransparentBackgroundColor): Now is a static method of the class.

  • editing/Editor.h:
  • editing/markup.cpp:

(WebCore::isElementPresentational): Modified to use hasTransparentBackgroundColor.

LayoutTests:

The following test checks that when we copy a text node surrounded by an element that
has non transparent background color we preserve the background color as well.

  • editing/pasteboard/copy-text-with-backgroundcolor-expected.txt: Added.
  • editing/pasteboard/copy-text-with-backgroundcolor.html: Added.
4:35 PM Changeset in webkit [84310] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-04-19 Ojan Vafai <​ojan@chromium.org>

Fix unittest failures from ​http://trac.webkit.org/changeset/84294.

  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
4:32 PM Changeset in webkit [84309] by ggaren@apple.com
  • 10 edits in trunk/Source/WebCore

2011-04-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed a use of markDOMObjectWrapper: NodeLists
​https://bugs.webkit.org/show_bug.cgi?id=58939

  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::markChildren): No need to mark node lists, because now they use the opaque roots system to decide their lifetimes.
  • bindings/js/JSNamedNodeMapCustom.cpp: Removed stray newline.
  • bindings/js/JSNodeListCustom.cpp: (WebCore::JSNodeListOwner::isReachableFromOpaqueRoots): (WebCore::JSNodeListOwner::finalize): (WebCore::wrapperOwner): (WebCore::wrapperContext): (WebCore::toJS): Use the opaque roots system to avoid relying on markDOMObjectWrapper.
  • dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::isDynamicNodeList):
  • dom/DynamicNodeList.h: (WebCore::DynamicNodeList::rootNode): Added the ability to get the node backing a NodeList, for use in the opaque roots system.
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/NodeList.h: (WebCore::NodeList::isDynamicNodeList): Ditto. Removed cruft related to the old way of marking NodeLists.
  • dom/NodeList.idl: We need a custom toJS so we can specify a custom WeakHandleOwner at construction time.
4:27 PM Changeset in webkit [84308] by crogers@google.com
  • 2 edits in trunk/LayoutTests

2011-04-19 Chris Rogers <​crogers@google.com>

Unreviewed.

Update test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=58941

  • platform/chromium/test_expectations.txt:
4:23 PM Changeset in webkit [84307] by jamesr@google.com
  • 3 edits
    13 adds in trunk

2011-04-19 Antoine Labour <​piman@chromium.org>

Reviewed by James Robinson.

For invisible iframes, propagate compositing to parent instead of setting self
as root.
​https://bugs.webkit.org/show_bug.cgi?id=58414

  • compositing/iframes/invisible-iframe-expected.checksum: Added.
  • compositing/iframes/invisible-iframe-expected.png: Added.
  • compositing/iframes/invisible-iframe-expected.txt: Added.
  • compositing/iframes/invisible-iframe.html: Added.
  • compositing/iframes/invisible-nested-iframe-expected.checksum: Added.
  • compositing/iframes/invisible-nested-iframe-expected.png: Added.
  • compositing/iframes/invisible-nested-iframe-expected.txt: Added.
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt: Added.
  • compositing/iframes/invisible-nested-iframe-hide.html: Added.
  • compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • compositing/iframes/invisible-nested-iframe-show.html: Added.
  • compositing/iframes/invisible-nested-iframe.html: Added.
  • platform/chromium-gpu/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.

2011-04-19 Antoine Labour <​piman@chromium.org>

Reviewed by James Robinson.

For invisible iframes, propagate compositing to parent instead of setting self
as root.
​https://bugs.webkit.org/show_bug.cgi?id=58414

Tests: compositing/iframes/invisible-iframe.html

compositing/iframes/invisible-nested-iframe-hide.html
compositing/iframes/invisible-nested-iframe-show.html
compositing/iframes/invisible-nested-iframe.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame): Propagate compositing to parent even if frame owner has no renderer.
4:15 PM Changeset in webkit [84306] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebKit/mac

2011-04-19 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

WebPreferences in WebKit1 should have CanvasUsesAcceleratedDrawing set to NO by default
​https://bugs.webkit.org/show_bug.cgi?id=58936

  • WebView/WebPreferences.mm: (+[WebPreferences initialize]):
4:11 PM Changeset in webkit [84305] by crogers@google.com
  • 2 edits in trunk/LayoutTests

2011-04-19 Chris Rogers <​crogers@google.com>

Unreviewed.

Update test_expectations.txt for tests which need rebaselining
​https://bugs.webkit.org/show_bug.cgi?id=58938

  • platform/chromium/test_expectations.txt:
3:53 PM Changeset in webkit [84304] by ap@apple.com
  • 20 edits
    1 move
    1 delete in trunk/Source/WebKit2

Reviewed by Adele Peterson.

WebKit2: Merge SelectionState and TextInputState
​https://bugs.webkit.org/show_bug.cgi?id=58919

Combined TextInputState and EditorState in one structure, which is updated whenever we get
a chance to. There is no sense to keep possibly stale SelectionState data when we have already
requested the most recent data synchronously.

This also simplifies the code, as we don't need to pass the state around in a separate variable.

  • GNUmakefile.am:
  • Scripts/webkit2/messages.py:
  • Shared/EditorState.h: Copied from Source/WebKit2/Shared/SelectionState.h. (WebKit::EditorState::EditorState):
  • Shared/SelectionState.h: Removed.
  • Shared/mac/TextInputState.h: Removed.
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::interpretKeyEvent):
  • UIProcess/API/mac/WKView.mm: (-[WKView validRequestorForSendType:returnType:]): (-[WKView validateUserInterfaceItem:]): (-[WKView shouldDelayWindowOrderingForEvent:]): (-[WKView doCommandBySelector:]): (-[WKView insertText:replacementRange:]): (-[WKView _handleStyleKeyEquivalent:]): (-[WKView _executeSavedKeypressCommands]): (-[WKView inputContext]): (-[WKView hasMarkedText]): (-[WKView unmarkText]): (-[WKView setMarkedText:selectedRange:replacementRange:]): (-[WKView attributedSubstringForProposedRange:actualRange:]): (-[WKView _interpretKeyEvent:savingCommandsTo:WebCore::]): (-[WKView _updateSecureInputState]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::editorStateChanged):
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::editorState): (WebKit::WebPageProxy::hasSelectedRange): (WebKit::WebPageProxy::isContentEditable):
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::setComposition): (WebKit::WebPageProxy::confirmComposition): (WebKit::WebPageProxy::insertText): (WebKit::WebPageProxy::executeKeypressCommands): (WebKit::WebPageProxy::writeSelectionToPasteboard): (WebKit::WebPageProxy::readSelectionFromPasteboard): (WebKit::WebPageProxy::interpretQueuedKeyEvent):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::compositionSelectionChanged): (WebKit::WebView::onIMEComposition): (WebKit::WebView::onIMEEndComposition): (WebKit::WebView::onIMERequestCharPosition): (WebKit::WebView::onIMERequest):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::respondToChangedSelection):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::editorState):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::handleEditingKeyboardEvent): (WebKit::WebPage::setComposition): (WebKit::WebPage::confirmComposition): (WebKit::WebPage::insertText): (WebKit::WebPage::executeKeypressCommands):
  • win/WebKit2.vcproj:
3:43 PM ThreadCommunication edited by levin@chromium.org
Added "case study" of converting code to using the new api. (diff)
3:36 PM Changeset in webkit [84303] by tony@chromium.org
  • 5256 edits in trunk/LayoutTests

2011-04-19 Tony Chang <​tony@chromium.org>

Add checksums to png files in platform/gtk.

3:35 PM Changeset in webkit [84302] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-04-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Terminate hung plug-in processes after 45 seconds
​https://bugs.webkit.org/show_bug.cgi?id=58932
<rdar://problem/8083219>

  • UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::pluginSyncMessageSendTimedOut): Find the plug-in process proxy and terminate it.

(WebKit::PluginProcessManager::pluginProcessWithPath):
Add new helper function.

(WebKit::PluginProcessManager::getOrCreatePluginProcess):
Call pluginProcessWithPath.

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::terminate): Terminate the process.
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::pluginSyncMessageSendTimedOut): Call PluginProcessManager::pluginSyncMessageSendTimedOut.
  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in: Add PluginSyncMessageSendTimedOut message.
  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::defaultSyncMessageTimeout): (WebKit::PluginProcessConnection::PluginProcessConnection): Set a sync message timeout on the plug-in process connection.

(WebKit::PluginProcessConnection::syncMessageSendTimedOut):
Send a message to the web process proxy.

3:33 PM Changeset in webkit [84301] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-19 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove unneeded deprecated methods from MarkStack
​https://bugs.webkit.org/show_bug.cgi?id=58853

Remove deprecated methods

  • heap/MarkStack.h:
3:29 PM Changeset in webkit [84300] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/9271848> Crash when the document element is removed

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/events/overflow-viewport-renderer-deleted.html

  • page/FrameView.cpp:

(WebCore::FrameView::calculateScrollbarModesForLayout): Reset m_viewportRenderer, in case this
function takes a code path that doesn’t call applyOverflowToViewport().
(WebCore::FrameView::layout): Whitespace change.

LayoutTests:

  • fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
  • fast/events/overflow-viewport-renderer-deleted.html: Added.
3:18 PM Changeset in webkit [84299] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-19 James Robinson <​jamesr@chromium.org>

Fix lint errors in test_expectations.txt

  • platform/chromium/test_expectations.txt:
3:15 PM Changeset in webkit [84298] by tony@chromium.org
  • 3021 edits in trunk/LayoutTests

2011-04-19 Tony Chang <​tony@chromium.org>

Add checksums to png files in platform/qt.

2:37 PM Changeset in webkit [84297] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Timothy Hatcher.

100% reproducible crash when right-clicking any element in Web Inspector on any page
​https://bugs.webkit.org/show_bug.cgi?id=58822

Web Inspector changes selection from JavaScript, and checks in UI process are insufficient
when selection is changing asynchronously.

  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::writeSelectionToPasteboard): Check that there is a selection, matching WK1 and UI process side. Perhaps the check should really be in WebCore, but for now, it's a WebKit responsibility. (WebKit::WebPage::readSelectionFromPasteboard): Same check, for no other reason but consistency.
2:30 PM Changeset in webkit [84296] by Beth Dakin
  • 5 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=57898
REGRESSION (r82185): Scroll position not restored on navigation back to a page in
the page cache
-and corresponding-
<rdar://problem/9226652>

Reviewed by Maciej Stachowiak.

Source/WebCore:

Setting the contentsSize of a ScrollView to (0, 0) necessarily causes the scroll
position to be lost. (The scroll position is computed based on the
visibleContentSize.) This patch provides a mechanism to cache the current scroll
position, and then the HistoryController accesses only the cached position rather
than calling scrollPosition() which does a computation based on the
visibleContentSize.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):

  • page/FrameView.cpp:

(WebCore::FrameView::resetScrollbarsAndClearContentsSize):

  • platform/ScrollView.h:

(WebCore::ScrollView::cacheCurrentScrollPosition):
(WebCore::ScrollView::cachedScrollPosition):

LayoutTests:

  • fast/loader/resources/empty-document-goes-back.html: Added.
  • fast/loader/scroll-position-restored-on-back-expected.txt: Added.
  • fast/loader/scroll-position-restored-on-back.html: Added.
2:28 PM Changeset in webkit [84295] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Things work best when the Xcode project refers to the file at a path that exists.

2:18 PM Changeset in webkit [84294] by ojan@chromium.org
  • 7 edits in trunk/Tools

2011-04-18 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

switch new-run-webkit-tests to using the new results file
​https://bugs.webkit.org/show_bug.cgi?id=58861

  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2:16 PM Changeset in webkit [84293] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

2011-04-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add syncMessageSendTimedOut CoreIPC Connection::Client member function
​https://bugs.webkit.org/show_bug.cgi?id=58928

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::waitForSyncReply): Call syncMessageSendTimedOut.
  • Platform/CoreIPC/Connection.h: Add syncMessageSendTimedOut to Connection::Client.
  • PluginProcess/PluginProcess.cpp:
  • PluginProcess/PluginProcess.h:
  • PluginProcess/WebProcessConnection.cpp:
  • PluginProcess/WebProcessConnection.h:
  • UIProcess/Plugins/PluginProcessProxy.cpp:
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/WebProcessProxy.cpp:
  • UIProcess/WebProcessProxy.h:
  • WebProcess/Plugins/PluginProcessConnection.cpp:
  • WebProcess/Plugins/PluginProcessConnection.h:
  • WebProcess/WebProcess.cpp:
  • WebProcess/WebProcess.h: Add syncMessageSendTimedOut stubs.
2:15 PM Changeset in webkit [84292] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-19 Ryosuke Niwa <​rniwa@webkit.org>

Skip the test added by r84264. The bug tracked by
​https://bugs.webkit.org/show_bug.cgi?id=58741

  • platform/qt/Skipped:
1:57 PM Changeset in webkit [84291] by jberlin@webkit.org
  • 2 edits in trunk/WebKitLibraries

Roll r81683 back in.

Reviewed by Sam Weinig.

Going to certain pages causes a download of "st.html" or "jsp.html" (news.yahoo.com, etc.)
<rdar://problem/9139245>

"Windows edition".

  • win/lib/WebKitSystemInterface.lib:
1:54 PM Changeset in webkit [84290] by reni@webkit.org
  • 9 edits
    4 adds in trunk

2011-04-19 Renata Hodovan <​reni@webkit.org>

Reviewed by Eric Seidel.

Move the alignment related macros from Vector.h to new Alignment.h.
​https://bugs.webkit.org/show_bug.cgi?id=56000

Adding the new file to the forwarding headers of Tools.

  • DumpRenderTree/ForwardingHeaders/wtf/Alignment.h: Added.

2011-04-19 Renata Hodovan <​reni@webkit.org>

Reviewed by Eric Seidel.

Move the alignment related macros in Vector.h to new Alignment.h.
​https://bugs.webkit.org/show_bug.cgi?id=56000

2011-04-19 Renata Hodovan <​reni@webkit.org>

Reviewed by Eric Seidel.

Move the alignment related macros in Vector.h to new Alignment.h.
​https://bugs.webkit.org/show_bug.cgi?id=56000

Adding the new file to the forwarding headers of JavaScriptGlue.

  • ForwardingHeaders/wtf/Alignment.h: Added.

2011-04-19 Renata Hodovan <​reni@webkit.org>

Reviewed by Eric Seidel.

Move the alignment related macros in Vector.h to new Alignment.h.
​https://bugs.webkit.org/show_bug.cgi?id=56000

Adding the new file to the forwarding headers of WebCore.

  • ForwardingHeaders/wtf/Alignment.h: Added.
1:52 PM Changeset in webkit [84289] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-04-19 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove DeprecatedPtr
​https://bugs.webkit.org/show_bug.cgi?id=58718

Remove the class an all functions that still exist to support it.

  • heap/MarkStack.h: (JSC::MarkStack::append):
  • runtime/JSValue.h:
  • runtime/WriteBarrier.h:
1:47 PM Changeset in webkit [84288] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-04-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Alexey Proskuryakov.

Replace the didFailToSendSyncMessage Connection::Client function with a flag
​https://bugs.webkit.org/show_bug.cgi?id=58923

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::Connection): Initialize m_shouldExitOnSyncMessageSendFailure to false.

(CoreIPC::Connection::setShouldExitOnSyncMessageSendFailure):
Set m_didCloseOnConnectionWorkQueueCallback.

(CoreIPC::Connection::sendSyncMessage):
Call didFailToSendSyncMessage if we fail to send the sync message for some reason.

(CoreIPC::Connection::didFailToSendSyncMessage):
if m_shouldExitOnSyncMessageSendFailure is true, exit.

  • Platform/CoreIPC/Connection.h: Remove didFailToSendSyncMessage from Connection::Client.
  • PluginProcess/PluginProcess.cpp:
  • PluginProcess/PluginProcess.h: Remove didFailToSendSyncMessage.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initialize):
  • WebProcess/WebProcess.h: Remove didFailToSendSyncMessage. Call setShouldExitOnSyncMessageSendFailure on our UI process connection.
1:44 PM Changeset in webkit [84287] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2011-04-19 Tony Chang <​tony@chromium.org>

Skipping plugins/mouse-click-iframe-to-plugin.html on mac/win.

  • platform/mac/Skipped:
  • platform/win/Skipped:
1:40 PM Changeset in webkit [84286] by oliver@apple.com
  • 4 edits in trunk/Source/WebCore

2011-04-19 Oliver Hunt <​oliver@apple.com>

Reviewed by Andreas Kling.

[Qt] QtInstance method cache ownership rules are unclear
​https://bugs.webkit.org/show_bug.cgi?id=58820

Make the QtInstance method cache use WriteBarrier, and handle
ownership properly.

  • bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fallbackObject): (JSC::Bindings::QtClass::fieldNamed):
  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::~QtInstance): (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::newRuntimeObject): (JSC::Bindings::QtInstance::markAggregate):
  • bridge/qt/qt_instance.h:
1:06 PM Changeset in webkit [84285] by crogers@google.com
  • 2 edits in trunk/LayoutTests

2011-04-19 Chris Rogers <​crogers@google.com>

Unreviewed.

Update test_expectations.txt due to border radius bugs in Skia
​https://bugs.webkit.org/show_bug.cgi?id=58920

  • platform/chromium/test_expectations.txt:
12:44 PM Changeset in webkit [84284] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

<​http://webkit.org/b/57867> Re-order enum ResourceLoadPriority to make Unresolved value less important

Reviewed by Antti Koivisto.

  • platform/network/ResourceLoadPriority.h:

(enum ResourceLoadPriority): Moved Unresolved enum to the top of
the list and set to -1 to emphasize the fact that this is an
unresolved priority (rather than one higher than the highest
priority). Removed whitespace from the end of all enum lines.

12:33 PM Changeset in webkit [84283] by Simon Fraser
  • 12 edits
    8 adds in trunk

2011-04-19 Simon Fraser <Simon Fraser>

Reviewed by David Hyatt.

Background radius is wrong for split inline
​https://bugs.webkit.org/show_bug.cgi?id=58843

When computing the radii for a segment of a split inline, we have to
constrain those radii for the current segment, while still drawing
using the entire logical width.

Tests: fast/backgrounds/border-radius-split-background-image.html

fast/backgrounds/border-radius-split-background.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer): Pass height and width for this box only to paintFillLayer()
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintFillLayer): Pass 0 for unused inlineBox height and width.
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::getBackgroundRoundedRect): When computing the rounded background rect, we have to take the size of this segment of the inline box into account for radius constraining. (WebCore::RenderBoxModelObject::paintFillLayerExtended): Call getBackgroundRoundedRect() in two places.
12:32 PM Changeset in webkit [84282] by crogers@google.com
  • 2 edits in trunk/LayoutTests

2011-04-19 Chris Rogers <​crogers@google.com>

Unreviewed.

Update test_expectations.txt with now passing test : media/video-zoom.html
​https://bugs.webkit.org/show_bug.cgi?id=58916

  • platform/chromium/test_expectations.txt:
12:28 PM Changeset in webkit [84281] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-04-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add a way to set the default sync message timeout for a CoreIPC connection
​https://bugs.webkit.org/show_bug.cgi?id=58908

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::Connection): Initialize m_defaultSyncMessageTimeout.

(CoreIPC::Connection::setDefaultSyncMessageTimeout):
Set the m_defaultSyncMessageTimeout member variable.

(CoreIPC::Connection::waitForSyncReply):
Handle the timeout being one of our two special magic values.

  • Platform/CoreIPC/Connection.h: Add a DefaultTimeout constant and change the NoTimeout constant to be -1.
12:24 PM Changeset in webkit [84280] by crogers@google.com
  • 2 edits
    5 adds in trunk/LayoutTests

2011-04-19 Chris Rogers <​crogers@google.com>

Unreviewed.

Rebaseline some chromium Snow Leopard tests - update test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=58915

  • platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.png: Added.
  • platform/chromium-mac/fast/css/font-face-default-font-expected.png: Added.
  • platform/chromium-mac/fast/css/font_property_normal-expected.png: Added.
  • platform/chromium-mac/fast/repaint/text-in-relative-positioned-inline-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:13 PM Changeset in webkit [84279] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-19 Ryosuke Niwa <​rniwa@webkit.org>

Skip the test added by r84270 on WebKit2 since it uses eventSender.

  • platform/mac-wk2/Skipped:
12:06 PM Changeset in webkit [84278] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-04-19 Simon Fraser <Simon Fraser>

Build fix. For some reason RenderBoxModelObject.cpp
was missing from my last commit.

  • rendering/RenderBoxModelObject.cpp: (WebCore::borderWillArcInnerEdge): (WebCore::edgeFlagForSide): (WebCore::includesEdge): (WebCore::BorderEdge::BorderEdge): (WebCore::BorderEdge::hasVisibleColorAndStyle): (WebCore::BorderEdge::shouldRender): (WebCore::BorderEdge::presentButInvisible): (WebCore::BorderEdge::usedWidth): (WebCore::BorderEdge::getDoubleBorderStripeWidths): (WebCore::edgesShareColor): (WebCore::styleRequiresClipPolygon): (WebCore::borderStyleFillsBorderArea): (WebCore::borderStyleHasInnerDetail): (WebCore::borderStyleIsDottedOrDashed): (WebCore::borderStyleHasUnmatchedColorsAtCorner): (WebCore::colorsMatchAtCorner): (WebCore::willBeOverdrawn): (WebCore::borderStylesRequireMitre): (WebCore::joinRequiresMitre): (WebCore::RenderBoxModelObject::paintOneBorderSide): (WebCore::RenderBoxModelObject::paintBorderSides): (WebCore::RenderBoxModelObject::paintTranslucentBorderSides): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::drawBoxSideFromPath): (WebCore::findInnerVertex): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::RenderBoxModelObject::paintBoxShadow):
12:03 PM Changeset in webkit [84277] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-19 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Refactor GLES2Canvas state application out into its own function.
​https://bugs.webkit.org/show_bug.cgi?id=58906

Covered by existing tests in fast/canvas and canvas/philip.

  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::applyState): New function to apply compositing and clipping state. (WebCore::GLES2Canvas::fillPath): (WebCore::GLES2Canvas::fillRect): (WebCore::GLES2Canvas::beginShadowDraw): (WebCore::GLES2Canvas::endShadowDraw): Refactor calls to applyState().
  • platform/graphics/chromium/GLES2Canvas.h:
12:02 PM Changeset in webkit [84276] by evan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-19 Evan Martin <​evan@chromium.org>

Reviewed by Darin Fisher.

[chromium] didReceiveTitle API signature should not change
​https://bugs.webkit.org/show_bug.cgi?id=58909

My previous attempt at a temporary shim was wrong.
This second try should correctly work with older clients.

  • public/WebFrameClient.h: (WebKit::WebFrameClient::didReceiveTitle):
11:57 AM Changeset in webkit [84275] by kevino@webkit.org
  • 3 edits in trunk/Tools

[wx] Unreviewed build fix for Win / wx 2.9 wxPython installation.

11:50 AM Changeset in webkit [84274] by tony@chromium.org
  • 14 edits in trunk/LayoutTests

2011-04-19 Tony Chang <​tony@chromium.org>

Fixing pngs with bad checksum crcs. There was a 64bit specific bug
in computing crcs of checksums embedded in png files. During that
time, these images were checked in. Just fixing with the correct
crcs (the image result itself is unchanged).

  • platform/gtk/fast/block/positioning/complex-positioned-movement-expected.png:
  • platform/gtk/fast/text/decorations-transformed-expected.png:
  • platform/mac/compositing/images/content-image-change-expected.png:
  • platform/mac/editing/inserting/editable-inline-element-expected.png:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.png:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.png:
  • platform/mac/fast/borders/bidi-002-expected.png:
  • platform/mac/fast/borders/bidi-004-expected.png:
  • platform/mac/fast/borders/bidi-009a-expected.png:
  • platform/mac/fast/box-shadow/inset-expected.png:
  • platform/mac/fast/inline/positioned-object-between-replaced-elements-expected.png:
  • platform/mac/fast/overflow/trailing-float-linebox-expected.png:
  • platform/mac/fullscreen/full-screen-zIndex-expected.png:
11:45 AM Changeset in webkit [84273] by Simon Fraser
  • 102 edits
    9 adds in trunk

2011-04-19 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Fix multiple border rendering issues
​https://bugs.webkit.org/show_bug.cgi?id=58761

Fix various border-drawing bugs, and optimize some common cases.
Also refactors a lot of the border-drawing code to be more maintainable.

Rounded border rendering with different border widths looks strange
​https://bugs.webkit.org/show_bug.cgi?id=17468

paintBorder in RenderObject paint two times the corners
​https://bugs.webkit.org/show_bug.cgi?id=20495

Overdraw at box corners when using RGBA colors with alpha
​https://bugs.webkit.org/show_bug.cgi?id=21835

Enable antialiasing for border drawing, when transformed
​https://bugs.webkit.org/show_bug.cgi?id=22746

Drawing border-radius from path sometimes fails to round outer border in the double style when it should
​https://bugs.webkit.org/show_bug.cgi?id=41301

Drawing border-radius from path doesn't appear to always match up border edges correctly
​https://bugs.webkit.org/show_bug.cgi?id=41302

Also fixes

Should be able to create Path from RoundedIntRect
​https://bugs.webkit.org/show_bug.cgi?id=58809

Tests: fast/borders/border-radius-different-width-001.html

fast/borders/border-radius-inset-outset.html
fast/borders/table-borders.html

  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatPoint.cpp: (WebCore::findSlope): (WebCore::findIntersection): New geometry helper functions (should eventually move into a new GeometryUtilities file).
  • platform/graphics/Path.h:
  • platform/graphics/Path.cpp: (WebCore::Path::addRoundedRect): Add an overload of addRoundedRect() that takes a RoundedIntRect.
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect): (WebCore::GraphicsContext::fillRectWithRoundedHole): Can now add a RoundedIntRect to a Path directly.
  • platform/graphics/IntRect.h: (WebCore::IntRect::minXMinYCorner): (WebCore::IntRect::maxXMinYCorner): (WebCore::IntRect::minXMaxYCorner): (WebCore::IntRect::maxXMaxYCorner): Convenience functions to get the rect corners, in a writing-mode- friendly way.
  • platform/graphics/RoundedIntRect.h:
  • platform/graphics/RoundedIntRect.cpp: (WebCore::RoundedIntRect::isRenderable): We need to know when Path::addRoundedRect() will fail because the sum of the radii exceed the height or width. This method tells us that.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole): Can now add a RoundedIntRect to a Path directly.
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::borderWillArcInnerEdge): This can just to see if there are inner radii now.

(WebCore::edgeFlagForSide):
(WebCore::includesEdge):
Convenience functions for the BorderEdgeFlags bitmask.

(WebCore::BorderEdge::BorderEdge):
(WebCore::BorderEdge::hasVisibleColorAndStyle):
(WebCore::BorderEdge::shouldRender):
(WebCore::BorderEdge::presentButInvisible):
(WebCore::BorderEdge::usedWidth):
(WebCore::BorderEdge::getDoubleBorderStripeWidths):
Convenience class to hold data about how a single edge
is drawn, and to contain some commonly used width-related methods.

(WebCore::edgesShareColor):
(WebCore::styleRequiresClipPolygon):
(WebCore::borderStyleFillsBorderArea):
(WebCore::borderStyleHasInnerDetail):
(WebCore::borderStyleIsDottedOrDashed):
(WebCore::borderStyleHasUnmatchedColorsAtCorner):
(WebCore::colorsMatchAtCorner):
(WebCore::willBeOverdrawn):
(WebCore::borderStylesRequireMitre):
(WebCore::joinRequiresMitre):
Functions used to make the border drawing code more readable,
which are used to determine when corners need a mitre, and
need antialiasing.

(WebCore::RenderBoxModelObject::paintOneBorderSide):
Code to paint one side of a border, either via the path, or
using rects/polygons, the appropriate mitres and antialiasing
at the corners. includeLogicalLeftEdge and includeLogicalRightEdge need
to be passed all the way down here so that when we recompute the
path for double and ridge/groove borders, we correctly handle split box
borders.

(WebCore::RenderBoxModelObject::paintBorderSides):
Paints the 4 border sides (if present).

(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
Called when one or more of the borders has a non-opaque color,
and uses a transparency layer for each set of same-colored
sides to avoid overdraw at the corners.

(WebCore::RenderBoxModelObject::paintBorder):
Builds an array of BorderEdge so we can iterate over them to
detect different border compbinations, and optimizations. Has
a fast path for all-solid borders.

(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
Moved from RenderObject, since all callers are in RenderBoxModelObject.
Has the following changes:

  • Don't attempt to draw dashes if there is only space for a few, since it looks bad.
  • Handle double and groove borders on split inlines correctly, making use of includeLogicalLeftEdge, includeLogicalRightEdge

(WebCore::findInnerVertex):
For borders with a radiused inner edge, the per-side clip polygon
has to project inside the padding box to avoid clipping the inner edge.
This function computes a reasonable inner corner for the clipping
polygon.
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
Have the corner joins pass through the corners of the inner and outer
border rectangles, ensure we don't clip the inside if necessary,
and handle antialiasing on the two mitres.

(WebCore::RenderBoxModelObject::paintBoxShadow):
Use RenderStyle::getRoundedInnerBorderFor() rather than computeBorderInnerRect()
etc.

  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawLineForBoxSide): Moved to RenderBoxModelObject.
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getRoundedBorderFor): (WebCore::RenderStyle::getRoundedInnerBorderFor): There was some very clumsy code that computed a rounded rect given the border rect and side widths. Cleaned this up by moving some code into RenderStyle. The overloaded getRoundedInnerBorderFor() which takes the border widths is used by the double and groove drawing code.
11:36 AM April 2011 Meeting edited by leviw@chromium.org
Adding myself to a couple events and creating one for switching layout … (diff)
11:19 AM Changeset in webkit [84272] by Adam Roben
  • 2 edits in trunk/Tools

Skip another accelerated-compositing-sensitive test when accelerated compositing is disabled

  • Scripts/old-run-webkit-tests: Skip media/controls-without-preload.html on Windows when

accelerated compositing is disabled.

11:19 AM Changeset in webkit [84271] by jshin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-19 Jungshik Shin <​jshin@chromium.org>

Reviewed by Adam Barth

Fix the compile failure in UniscribeHelperTest.cpp due to
a change in UniscribeHelper made by the CL for bug 48860
(r84264)

​http://bugs.webkit.org/show_bug.cgi?id=48860

  • tests/UniscribeHelperTest.cpp: (TEST_F):
11:17 AM Changeset in webkit [84270] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-04-19 Stuart Morgan <​stuartmorgan@chromium.org>

Reviewed by Tony Chang.

[chromium] Clicking on plugin for first time blocks focus shift
​https://bugs.webkit.org/show_bug.cgi?id=58419

Added new test for cross-iframe focus changes on plugin clicks.

  • plugins/mouse-click-iframe-to-plugin-expected.txt: Added.
  • plugins/mouse-click-iframe-to-plugin.html: Added.

2011-04-19 Stuart Morgan <​stuartmorgan@chromium.org>

Reviewed by Tony Chang.

[chromium] Clicking on plugin for first time blocks focus shift
​https://bugs.webkit.org/show_bug.cgi?id=58419

Switched to using FocusController when moving focus to a plugin
so that cross-frame focus changes are handled correctly.

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent):
11:17 AM Changeset in webkit [84269] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-19 Ojan Vafai <​ojan@chromium.org>

Remove accidentally committed debug code.

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
11:15 AM Changeset in webkit [84268] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Unreviewed build correction.

Avoid duplicate stub implementation of test routine
for WinCairo build.

  • WebKitTestRunner/win/TestInvocationWin.cpp: Exclude

WinCairo from using this stub.

11:12 AM Changeset in webkit [84267] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-04-18 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

make results file work with audio and reftests
​https://bugs.webkit.org/show_bug.cgi?id=58860

Also fix bug with timeout tests and store a bit in the JSON
for new image tests instead of loading the image result to check if it's there.

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
11:08 AM Changeset in webkit [84266] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-04-19 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Adam Roben.

PrettyPatch tries to show images for deleted files
​https://bugs.webkit.org/show_bug.cgi?id=28457

When the image data is empty, instead of generating an <img> tag, generate
a text to indicate the image was deleted.

  • PrettyPatch/PrettyPatch.rb:
11:05 AM Changeset in webkit [84265] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-04-19 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r74228-75294): removing nodes is 200+ times slower when selection is inside a shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=57061

The bug was caused by Range::compareNode's incorrectly returning NODE_INSIDE when the selection is inside
a shadow DOM and the node is outside of the shadow DOM. This caused respondToNodeModification to call
RenderView::clearSelection every time a node is removed when selection is in a shadow DOM and resulted in
a significant performance regression.

Fixed Ranged::compareNode by making Range::compareBoundaryPoints throw a WRONG_DOCUMENT_ERR when there are
no common ancestors between containerA and containerB. This will force compareNode to also throw an exception
and prevents respondToNodeModification from clearing selection.

No new tests because this is a performance improvement and the fix in Range cannot be tested since shadow DOM
isn't exposed to JavaScript.

  • dom/Range.cpp: (WebCore::Range::setStart): Calls compareBoundaryPoints; since we ensures that the root container noes of start and end nodes are same, we should never get an exception from compareBoundaryPoints. (WebCore::Range::setEnd): Ditto. (WebCore::Range::isPointInRange): Calls compareBoundaryPoints; returns false when compareBoundaryPoints throws an exception. (WebCore::Range::comparePoint): Calls compareBoundaryPoints; exit early when an exception is thrown by compareBoundaryPoints. (WebCore::Range::compareBoundaryPoints): Throws an exception when two containers do not have a common ancestor. (WebCore::Range::boundaryPointsValid): Calls compareBoundaryPoints and checks that it didn't throw an exception.
  • dom/Range.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::respondToNodeModification):
  • editing/htmlediting.cpp: (WebCore::comparePositions): Calls compareBoundaryPoints.
  • editing/markup.cpp: (WebCore::createMarkup): Calls compareBoundaryPoints; since startNode and pastEnd are both in the same document and neither are in a shadow DOM, it should never throw an exception.
  • page/DOMSelection.cpp: (WebCore::DOMSelection::containsNode): Calls compareBoundaryPoints; node is fully selected only if no exception was thrown.
10:40 AM Changeset in webkit [84264] by jshin@chromium.org
  • 13 edits
    2 adds in trunk

Index: Source/JavaScriptCore/ChangeLog
===================================================================
--- Source/JavaScriptCore/ChangeLog (revision 84100)
+++ Source/JavaScriptCore/ChangeLog (working copy)
@@ -1,3 +1,15 @@
+2011-04-17 Jungshik Shin <​jshin@chromium.org>
+
+ Reviewed by NOBODY (OOPS!).
+
+ Add U+FEFF (Zero width no-break space) to CharacterNames.h.
+ It's added to the list of characters to treat as zero-width
+ in WebCore.
+
+ ​https://bugs.webkit.org/show_bug.cgi?id=48860
+
+ * wtf/unicode/CharacterNames.h:
+

2011-04-16 Patrick Gansterer <Patrick Gansterer>


Reviewed by Eric Seidel.

Index: Source/JavaScriptCore/wtf/unicode/CharacterNames.h
===================================================================
--- Source/JavaScriptCore/wtf/unicode/CharacterNames.h (revision 84099)
+++ Source/JavaScriptCore/wtf/unicode/CharacterNames.h (working copy)
@@ -85,6 +85,7 @@ const UChar yenSign = 0x00A5;

const UChar zeroWidthJoiner = 0x200D;
const UChar zeroWidthNonJoiner = 0x200C;
const UChar zeroWidthSpace = 0x200B;

+const UChar zeroWidthNoBreakSpace = 0xFEFF;

} namespace Unicode
} namespace WTF

@@ -138,5 +139,6 @@ using WTF::Unicode::yenSign;

using WTF::Unicode::zeroWidthJoiner;
using WTF::Unicode::zeroWidthNonJoiner;
using WTF::Unicode::zeroWidthSpace;

+using WTF::Unicode::zeroWidthNoBreakSpace;

#endif CharacterNames_h

Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 84100)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,3 +1,37 @@
+2011-04-17 Jungshik Shin <​jshin@chromium.org>
+
+ Reviewed by NOBODY (OOPS!).
+
+ Make U+FEFF be treated as a zero-width character in both
+ simple script and complex script code paths. In Chromium
+ Windows, UniscribeHelper needs a rather extensive changes
+ summarized below. Other ports need minor changes.
+
+ ​https://bugs.webkit.org/show_bug.cgi?id=48860
+
+ Test: fast/text/zero-width-characters-complex-script.html
+
+ * platform/graphics/Font.h:
+ (WebCore::Font::treatAsZeroWidthSpace): U+FEFF is added to the list
+ (WebCore::Font::treatAsZeroWidthSpaceInComplexScript): Added. Same as the above except that ZWNJ and ZWJ are excluded.
+ * platform/graphics/GlyphPageTreeNode.cpp:
+ (WebCore::GlyphPageTreeNode::initializePage): U+FEFF is made to have zero-width characters in simple script (fast) code path.
+ * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
+ (WebCore::FontMap::getSpaceGlyph): Added to get the gid for space glyph to use in adjustSpaceAdvance when zero-width glyph character has a non-zero width and potentially 'visible' glyph.
+ (WebCore::FontMap::FontData::FontData): spaceGlyph member added.
+ (WebCore::getDerivedFontData): spaceGlyph is retrieved as well.
+ * platform/graphics/chromium/FontUtilsChromiumWin.h:
+ * platform/graphics/chromium/UniscribeHelper.cpp:
+ (WebCore::UniscribeHelper::UniscribeHelper): m_spaceGlyph added.
+ (WebCore::UniscribeHelper::shape): spaceGlyph is obtained stored for a font tried for each item.
+ (WebCore::UniscribeHelper::adjustSpaceAdvances): For zero-width complex script characters, set the advance width to zero and replace a non-zero-width/visible glyph with a space glyph.
+ (WebCore::UniscribeHelper::applySpacing):
+ (WebCore::UniscribeHelper::containsMissingGlyphs): turned to a member function because it cannot work on glyphs alone any more but need to take into account a character corresponding to a glyph
+ * platform/graphics/chromium/UniscribeHelper.h:
+ (WebCore::UniscribeHelper::Shaping::Shaping): m_spaceGlyph is added
+ * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
+ (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): When calling UniscriberHelper, add a new argument for spaceGlyph.
+

2011-04-16 Adam Barth <​abarth@webkit.org>


Reviewed by Sam Weinig.

Index: Source/WebCore/platform/graphics/Font.h
===================================================================
--- Source/WebCore/platform/graphics/Font.h (revision 84099)
+++ Source/WebCore/platform/graphics/Font.h (working copy)
@@ -203,7 +203,8 @@ public:

FontSelector* fontSelector() const;

static bool treatAsSpace(UChar c) { return c == ' '
c == '\t' c == '\n' c == noBreakSpace; }
static bool treatAsZeroWidthSpace(UChar c) { return c < 0x20 + static bool treatAsZeroWidthSpace(UChar c) { return treatAsZeroWidthSpaceInComplexScript(c) + static bool treatAsZeroWidthSpaceInComplexScript(UChar c) { return c < 0x20
(c >= 0x7F && c < 0xA0) c == softHyphen (c >= 0x200c && c <= 0x200f) (c >= 0x202a && c <= 0x202e) c == objectReplacementCharacter; }
c == 0x200c c == 0x200d; }
(c >= 0x7F && c < 0xA0) c == softHyphen (c >= 0x200e && c <= 0x200f) (c >= 0x202a && c <= 0x202e) c == zeroWidthNoBreakSpace c == objectReplacementCharacter; }

static bool canReceiveTextEmphasis(UChar32 c);


static inline UChar normalizeSpaces(UChar character)

Index: Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp
===================================================================
--- Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp (revision 84099)
+++ Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp (working copy)
@@ -191,6 +191,9 @@ void GlyphPageTreeNode::initializePage(c

} else if (start == (objectReplacementCharacter & ~(GlyphPage::size - 1))) {

Object replacement character must not render at all.
buffer[objectReplacementCharacter - start] = zeroWidthSpace;

+ } else if (start == (zeroWidthNoBreakSpace & ~(GlyphPage::size - 1))) {
+ ZWNBS/BOM must not render at all.
+ buffer[zeroWidthNoBreakSpace - start] = zeroWidthSpace;

}

} else {

bufferLength = GlyphPage::size * 2;

Index: Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.cpp
===================================================================
--- Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.cpp (revision 84099)
+++ Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.cpp (working copy)
@@ -250,17 +250,31 @@ int getAscent(HFONT hfont)

return gotMetrics ? tm.tmAscent : kUndefinedAscent;

}


+WORD getSpaceGlyph(HFONT hfont)
+{
+ HDC dc = GetDC(0);
+ HGDIOBJ oldFont = SelectObject(dc, hfont);
+ WCHAR space = L' ';
+ WORD spaceGlyph = 0;
+ GetGlyphIndices(dc, &space, 1, &spaceGlyph, 0);
+ SelectObject(dc, oldFont);
+ ReleaseDC(0, dc);
+ return spaceGlyph;
+}
+

struct FontData {

FontData()

: hfont(0)
, ascent(kUndefinedAscent)
, scriptCache(0)

+ , spaceGlyph(0)

{
}


HFONT hfont;
int ascent;
mutable SCRIPT_CACHE scriptCache;

+ WORD spaceGlyph;

};


Again, using hash_map does not earn us much here. page_cycler_test intl2

@@ -379,7 +393,8 @@ bool getDerivedFontData(const UChar* fam

LOGFONT* logfont,
int* ascent,
HFONT* hfont,

  • SCRIPT_CACHE scriptCache)

+ SCRIPT_CACHE scriptCache,
+ WORD* spaceGlyph)

{

ASSERT(logfont);
ASSERT(family);

@@ -408,6 +423,7 @@ bool getDerivedFontData(const UChar* fam

cache it so that we won't have to call CreateFontIndirect once
 more for HFONT next time.
derived->ascent = getAscent(derived->hfont);

+ derived->spaceGlyph = getSpaceGlyph(derived->hfont);

} else {

derived = &iter->second;
Last time, GetAscent failed so that only HFONT was

@@ -419,6 +435,7 @@ bool getDerivedFontData(const UChar* fam

*hfont = derived->hfont;
*ascent = derived->ascent;
*scriptCache = &(derived->scriptCache);

+ *spaceGlyph = derived->spaceGlyph;

return *ascent != kUndefinedAscent;

}


Index: Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.h
===================================================================
--- Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.h (revision 84099)
+++ Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.h (working copy)
@@ -78,7 +78,7 @@ const UChar* getFallbackFamily(const UCh

intl2 page-cycler test is noticeably slower with one out param than
 the current version although the subsequent 9 passes take about the
same time.

-bool getDerivedFontData(const UChar* family, int style, LOGFONT*, int* ascent, HFONT*, SCRIPT_CACHE);
+bool getDerivedFontData(const UChar* family, int style, LOGFONT*, int* ascent, HFONT*, SCRIPT_CACHE, WORD* spaceGlyph);

enum {

FontStyleNormal = 0,

Index: Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp
===================================================================
--- Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp (revision 84099)
+++ Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp (working copy)
@@ -31,45 +31,16 @@

#include "config.h"
#include "UniscribeHelper.h"


-#include <windows.h>
-
+#include "Font.h"

#include "FontUtilsChromiumWin.h"
#include "PlatformContextSkia.h"
#include "SkiaFontWin.h"
#include "SkPoint.h"

+#include <windows.h>

#include <wtf/Assertions.h>


namespace WebCore {


- This function is used to see where word spacing should be applied inside
- runs. Note that this must match Font::treatAsSpace so we all agree where
- and how much space this is, so we don't want to do more general Unicode
- "is this a word break" thing.
-static bool treatAsSpace(UChar c)
-{

return c == ' '
c == '\t' c == '\n' c == 0x00A0;

-}
-
- SCRIPT_FONTPROPERTIES contains glyph indices for default, invalid
- and blank glyphs. Just because ScriptShape succeeds does not mean
- that a text run is rendered correctly. Some characters may be rendered
- with default/invalid/blank glyphs. Therefore, we need to check if the glyph
- array returned by ScriptShape contains any of those glyphs to make
- sure that the text run is rendered successfully.
-static bool containsMissingGlyphs(WORD *glyphs,

  • int length,
  • SCRIPT_FONTPROPERTIES* properties)

-{

  • for (int i = 0; i < length; ++i) {
  • if (glyphs[i] == properties->wgDefault
(glyphs[i] == properties->wgInvalid
  • && glyphs[i] != properties->wgBlank))
  • return true;
  • }

-

  • return false;

-}
-

HFONT is the 'incarnation' of 'everything' about font, but it's an opaque
 handle and we can't directly query it to make a new HFONT sharing
its characteristics (height, style, etc) except for family name.

@@ -102,13 +73,15 @@ UniscribeHelper::UniscribeHelper(const U

bool isRtl,
HFONT hfont,
SCRIPT_CACHE* scriptCache,

  • SCRIPT_FONTPROPERTIES* fontProperties)

+ SCRIPT_FONTPROPERTIES* fontProperties,
+ WORD spaceGlyph)

: m_input(input)
, m_inputLength(inputLength)
, m_isRtl(isRtl)
, m_hfont(hfont)
, m_scriptCache(scriptCache)
, m_fontProperties(fontProperties)

+ , m_spaceGlyph(spaceGlyph)

, m_directionalOverride(false)
, m_inhibitLigate(false)
, m_letterSpacing(0)

@@ -546,6 +519,7 @@ bool UniscribeHelper::shape(const UChar*

SCRIPT_CACHE* scriptCache = m_scriptCache;
SCRIPT_FONTPROPERTIES* fontProperties = m_fontProperties;
int ascent = m_ascent;

+ WORD spaceGlyph = m_spaceGlyph;

HDC tempDC = 0;
HGDIOBJ oldFont = 0;
HRESULT hr;

@@ -601,7 +575,7 @@ bool UniscribeHelper::shape(const UChar*

} else if (hr == E_OUTOFMEMORY) {

numGlyphs *= 2;
continue;

} else if (SUCCEEDED(hr) && (lastFallbackTried + } else if (SUCCEEDED(hr) && (lastFallbackTried
!containsMissingGlyphs(&shaping.m_glyphs[0], generatedGlyphs, fontProperties)))
!containsMissingGlyphs(shaping, run, fontProperties)))

break;


The current font can't render this run. clear DC and try

@@ -632,7 +606,9 @@ bool UniscribeHelper::shape(const UChar*

const UChar *family = getFallbackFamily(input, itemLength,

FontDescription::StandardFamily, 0, 0);

bool fontOk = getDerivedFontData(family, m_style, &m_logfont,

  • &ascent, &hfont, &scriptCache);

+ &ascent, &hfont, &scriptCache,
+ &spaceGlyph);
+

if (!fontOk) {

If this GetDerivedFontData is called from the renderer it

@@ -644,7 +620,8 @@ bool UniscribeHelper::shape(const UChar*

Try again.
fontOk = getDerivedFontData(family, m_style, &m_logfont,

  • &ascent, &hfont, &scriptCache);

+ &ascent, &hfont, &scriptCache,
+ &spaceGlyph);

ASSERT(fontOk);

}


@@ -673,6 +650,7 @@ bool UniscribeHelper::shape(const UChar*

because it's not used elsewhere.
shaping.m_hfont = hfont;
shaping.m_scriptCache = scriptCache;

+ shaping.m_spaceGlyph = spaceGlyph;

The ascent of a font for this run can be different from
 that of the primary font so that we need to keep track of

@@ -806,22 +784,39 @@ void UniscribeHelper::adjustSpaceAdvance

for (size_t run = 0; run < m_runs.size(); run++) {

Shaping& shaping = m_shapes[run];


+ FIXME: This loop is not UTF-16-safe. Unicode 6.0 has a couple
+ of complex script blocks in Plane 1.

for (int i = 0; i < shaping.charLength(); i++) {

  • if (!treatAsSpace(m_input[m_runs[run].iCharPos + i]))

+ UChar c = m_input[m_runs[run].iCharPos + i];
+ bool treatAsSpace = Font::treatAsSpace(c);
+ if (!treatAsSpace && !Font::treatAsZeroWidthSpaceInComplexScript(c))

continue;


int glyphIndex = shaping.m_logs[i];
int currentAdvance = shaping.m_advance[glyphIndex];


  • currentAdvance does not include additional letter-spacing, but
  • space_width does. Here we find out how off we are from the
  • correct width for the space not including letter-spacing, then
  • just subtract that diff.
  • int diff = currentAdvance - spaceWidthWithoutLetterSpacing;
  • The shaping can consist of a run of text, so only subtract the
  • difference in the width of the glyph.
  • shaping.m_advance[glyphIndex] -= diff;
  • shaping.m_abc.abcB -= diff;

+ if (treatAsSpace) {
+ currentAdvance does not include additional letter-spacing,
+ but m_spaceWidth does. Here we find out how off we are from
+ the correct width (spaceWidthWithoutLetterSpacing) and
+ just subtract that diff.
+ int diff = currentAdvance - spaceWidthWithoutLetterSpacing;
+ The shaping can consist of a run of text, so only subtract
+ the difference in the width of the glyph.
+ shaping.m_advance[glyphIndex] -= diff;
+ shaping.m_abc.abcB -= diff;
+ continue;
+ }
+
+ For characters treated as zero-width space in complex
+ scripts, set the advance width to zero, adjust
+ |abcB| of the current run accordingly and set
+ the glyph to m_spaceGlyph (invisible).
+ shaping.m_advance[glyphIndex] = 0;
+ shaping.m_abc.abcB -= currentAdvance;
+ shaping.m_offsets[glyphIndex].du = 0;
+ shaping.m_offsets[glyphIndex].dv = 0;
+ shaping.m_glyphs[glyphIndex] = shaping.m_spaceGlyph;

}

}

}

@@ -872,7 +867,7 @@ void UniscribeHelper::applySpacing()

extra wordspacing amount for the glyphs they correspond to.
if (m_wordSpacing != 0) {

for (int i = 0; i < shaping.charLength(); i++) {

  • if (!treatAsSpace(m_input[m_runs[run].iCharPos + i]))

+ if (!Font::treatAsSpace(m_input[m_runs[run].iCharPos + i]))

continue;


The char in question is a word separator...

@@ -929,4 +924,31 @@ int UniscribeHelper::advanceForItem(int

return shaping.m_prePadding + justification;

}


+ SCRIPT_FONTPROPERTIES contains glyph indices for default, invalid
+ and blank glyphs. Just because ScriptShape succeeds does not mean
+ that a text run is rendered correctly. Some characters may be rendered
+ with default/invalid/blank glyphs. Therefore, we need to check if the glyph
+ array returned by ScriptShape contains any of those glyphs to make
+ sure that the text run is rendered successfully.
+ However, we should not subject zero-width characters to this test.
+
+bool UniscribeHelper::containsMissingGlyphs(const Shaping& shaping,
+ const SCRIPT_ITEM& run,
+ const SCRIPT_FONTPROPERTIES* properties) const
+{
+ for (int i = 0; i < shaping.charLength(); i++) {
+ UChar c = m_input[run.iCharPos + i];
+ Skip zero-width space characters because they're not considered to be missing in a font.
+ if (Font::treatAsZeroWidthSpaceInComplexScript(c))
+ continue;
+ int glyphIndex = shaping.m_logs[i];
+ WORD glyph = shaping.m_glyphs[glyphIndex];
+ if (glyph == properties->wgDefault

+
(glyph == properties->wgInvalid && glyph != properties->wgBlank))

+ return true;
+ }
+ return false;
+}
+
+

} namespace WebCore

Index: Source/WebCore/platform/graphics/chromium/UniscribeHelper.h
===================================================================
--- Source/WebCore/platform/graphics/chromium/UniscribeHelper.h (revision 84099)
+++ Source/WebCore/platform/graphics/chromium/UniscribeHelper.h (working copy)
@@ -76,7 +76,8 @@ public:

bool isRtl,
HFONT,
SCRIPT_CACHE*,

  • SCRIPT_FONTPROPERTIES*);

+ SCRIPT_FONTPROPERTIES*,
+ WORD);

virtual ~UniscribeHelper();


@@ -225,7 +226,9 @@ private:

: m_prePadding(0)
, m_hfont(NULL)
, m_scriptCache(NULL)

  • , m_ascentOffset(0) {

+ , m_ascentOffset(0)
+ , m_spaceGlyph(0)
+ {

m_abc.abcA = 0;
m_abc.abcB = 0;
m_abc.abcC = 0;

@@ -319,6 +322,8 @@ private:

when drawing a string, to align multiple runs rendered with
 different fonts.
int m_ascentOffset;

+
+ WORD m_spaceGlyph;

};


Computes the runs_ array from the text run.

@@ -343,6 +348,10 @@ private:

Returns the total width of a single item.
int advanceForItem(int) const;


+ bool containsMissingGlyphs(const Shaping&,
+ const SCRIPT_ITEM&,
+ const SCRIPT_FONTPROPERTIES*) const;
+

Shapes a run (pointed to by |input|) using |hfont| first.
 Tries a series of fonts specified retrieved with NextWinFontData
and finally a font covering characters in |*input|. A string pointed

@@ -384,6 +393,7 @@ private:

int m_ascent;
LOGFONT m_logfont;
int m_style;

+ WORD m_spaceGlyph;

Options, see the getters/setters above.
bool m_directionalOverride;

Index: Source/WebCore/platform/graphics/chromium/UniscribeHelperTextRun.cpp
===================================================================
--- Source/WebCore/platform/graphics/chromium/UniscribeHelperTextRun.cpp (revision 84099)
+++ Source/WebCore/platform/graphics/chromium/UniscribeHelperTextRun.cpp (working copy)
@@ -43,7 +43,8 @@ UniscribeHelperTextRun::UniscribeHelperT

: UniscribeHelper(run.characters(), run.length(), run.rtl(),

font.primaryFont()->platformData().hfont(),
font.primaryFont()->platformData().scriptCache(),

  • font.primaryFont()->platformData().scriptFontProperties())

+ font.primaryFont()->platformData().scriptFontProperties(),
+ font.primaryFont()->spaceGlyph())

, m_font(&font)
, m_fontIndex(0)

{

@@ -69,7 +70,7 @@ UniscribeHelperTextRun::UniscribeHelperT

SCRIPT_CACHE* scriptCache,
SCRIPT_FONTPROPERTIES* fontProperties)
: UniscribeHelper(input, inputLength, isRtl, hfont,

  • scriptCache, fontProperties)

+ scriptCache, fontProperties, 0)

, m_font(0)
, m_fontIndex(-1)

{

Index: LayoutTests/ChangeLog
===================================================================
--- LayoutTests/ChangeLog (revision 84100)
+++ LayoutTests/ChangeLog (working copy)
@@ -1,3 +1,21 @@
+2011-04-17 Jungshik Shin <​jshin@chromium.org>
+
+ Reviewed by NOBODY (OOPS!).
+
+ Add a complex-script version of zero-width-characters.html.
+ and add U+FEFF to zero-width-characters.html
+ Chromium Linux fails the test because U+FEFF is rendered
+ with a non-zero width glyph.
+ Filed ​http://bugs.webkit.org/show_bug.cgi?id=58741 and noted
+ as such in test_expectation.txt.
+
+ ​https://bugs.webkit.org/show_bug.cgi?id=48860
+
+ * fast/text/zero-width-characters-complex-script-expected.txt: Added.
+ * fast/text/zero-width-characters-complex-script.html: Added.
+ * fast/text/zero-width-characters.html:
+ * platform/chromium/test_expectations.txt:
+

2011-04-16 Dan Bernstein <​mitz@apple.com>


Updated results for fast/block/float/032.html after r84096. Filed ​http://webkit.org/b/58736 to

Index: LayoutTests/fast/text/zero-width-characters-complex-script-expected.txt
===================================================================
--- LayoutTests/fast/text/zero-width-characters-complex-script-expected.txt (revision 0)
+++ LayoutTests/fast/text/zero-width-characters-complex-script-expected.txt (revision 0)
@@ -0,0 +1,3 @@
+This test checks various characters that should always be zero width to ensure that they are when enclosed by complex script characters. The WebKit text system ensures this in a way that's independent of the fonts installed on the system.
+
+PASS: All characters had zero-width.
Index: LayoutTests/fast/text/zero-width-characters-complex-script.html
===================================================================
--- LayoutTests/fast/text/zero-width-characters-complex-script.html (revision 0)
+++ LayoutTests/fast/text/zero-width-characters-complex-script.html (revision 0)
@@ -0,0 +1,66 @@
+<head>
+<script>
+
+function testChar(ch)
+{
+ Strings a and b selected here do not have any 'interaction' between them.
+ var a = "\u0915\u093E"
+ var b = "\u0916";
+ var span = document.getElementById("characters");
+ span.firstChild.data = a + b;
+ var abWidth = span.offsetWidth;
+ span.firstChild.data = a;
+ var aWidth = span.offsetWidth;
+ span.firstChild.data = a + String.fromCharCode(ch) + b;
+ var abWithChWidth = span.offsetWidth;
+
+ if (abWithChWidth > abWidth)
+ return 1;
+ if (abWidth > aWidth)
+ return 0;
+ return 1;
+}
+
+function test()
+{
+ if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+ var failedCount = 0;
+ for (var i = 1; i < 32; ++i)
+ if (i != 9 && i != 10 && i != 13)
+ failedCount += testChar(i);
+
+ for (var i = 0x7F; i < 0xA0; ++i)
+ failedCount += testChar(i);
+ failedCount += testChar(0xAD);
+ ZWJ (U+200C) and ZWNJ (U+200D) are excluded because they
+ can affect the rendering in complex script text.
+ failedCount += testChar(0x200B);
+ failedCount += testChar(0x200E);
+ failedCount += testChar(0x200F);
+ failedCount += testChar(0x202A);
+ failedCount += testChar(0x202B);
+ failedCount += testChar(0x202C);
+ failedCount += testChar(0x202D);
+ failedCount += testChar(0x202E);
+ failedCount += testChar(0xFEFF);
+ failedCount += testChar(0xFFFC);
+
+ var testArea = document.getElementById("testArea");
+ testArea.parentNode.removeChild(testArea);
+
+ if (failedCount > 0)
+ result = "FAIL: " + failedCount + " characters had non-zero width" +
+ " or failed to get measured.";
+ else
+ result = "PASS: All characters had zero-width.";
+ document.getElementById("result").firstChild.data = result;
+}
+</script>
+</head>
+<body onload="test()">
+<p>This test checks various characters that should always be zero width to ensure that they are when enclosed by complex script characters.
+The WebKit text system ensures this in a way that's independent of the fonts installed on the system.</p>
+<p id="result">FAIL: Script did not run to completion.</p>
+<p id="testArea"><span id="characters">&#x0915;&#x093E;&#x0916;</span></p>
+</body>
Index: LayoutTests/fast/text/zero-width-characters.html
===================================================================
--- LayoutTests/fast/text/zero-width-characters.html (revision 84099)
+++ LayoutTests/fast/text/zero-width-characters.html (working copy)
@@ -13,6 +13,7 @@ function test()

testString += String.fromCharCode(0x200D);
testString += String.fromCharCode(0x200E);
testString += String.fromCharCode(0x200F);

+ testString += String.fromCharCode(0xFEFF);

testString += String.fromCharCode(0xFFFC);
var span = document.getElementById("characters");
var abWidth = span.offsetWidth;

Index: LayoutTests/platform/chromium/test_expectations.txt
===================================================================
--- LayoutTests/platform/chromium/test_expectations.txt (revision 84099)
+++ LayoutTests/platform/chromium/test_expectations.txt (working copy)
@@ -3534,4 +3534,5 @@ BUGMORRITA : fast/html/details-remove-su

BUGMORRITA : fast/html/details-writing-mode.html = FAIL


BUGWK58619 GPU LINUX WIN : media/video-volume-slider.html = IMAGE

+BUGWK58741 LINUX : fast/text/zero-width-characters-complex-script.html = FAIL

10:15 AM Changeset in webkit [84263] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk

2011-04-19 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] X11: Text selection is causing oncopy event to be called
​https://bugs.webkit.org/show_bug.cgi?id=58656

Always when text is selected the oncopy event is fired, this behavior does
not exist in Firefox or Chrome. Now, when selecting a text, QtWebKit
is making multi part-copies (with rich text metadata), the multi-part
data can be obtained by data transfer items interface when supported by QtWebKit.
Also, copies to the clipboard of a selected image, is not supported by Chrome and
Firefox and was removed from QtWebKit.

  • Api/qwebpage.cpp: (QWebPagePrivate::handleClipboard):
10:05 AM Changeset in webkit [84262] by jer.noble@apple.com
  • 5 edits in trunk/Tools

2011-04-19 Jer Noble <​jer.noble@apple.com>

Reviewed by Adam Roben.

REGRESSION (r84206): 50 tests failing on SnowLeopard Intel Release (WebKit2 Tests) due to extra "supportsFullScreen() == true" output
​https://bugs.webkit.org/show_bug.cgi?id=58890

Add a layoutTestController flag which controls when full screen callbacks are written to stdout.
Defaults to false.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpFullScreenCallbacks().
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::supportsFullScreen): Only write to stdout if shouldDumpFullScreenCallbacks is set. (WTR::InjectedBundlePage::enterFullScreenForElement): Ditto. (WTR::InjectedBundlePage::exitFullScreenForElement): Ditto.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize new ivar.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpFullScreenCallbacks): Added. (WTR::LayoutTestController::shouldDumpFullScreenCallbacks): Added.
10:00 AM Changeset in webkit [84261] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebCore

Extend the DIBPixelData class with the facility for writing the
bitmap representation to disk for debugging purposes.
​https://bugs.webkit.org/show_bug.cgi?id=58862.

Reviewed by Adam Roben.

  • platform/graphics/win/DIBPixelData.cpp:

(WebCore::DIBPixelData::writeToFile): New function.

  • platform/graphics/win/DIBPixelData.h:
9:56 AM Changeset in webkit [84260] by commit-queue@webkit.org
  • 61 edits in trunk/Source

2011-04-19 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
​https://bugs.webkit.org/show_bug.cgi?id=58883

  • fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::didReceiveData):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveContentLength):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveContentLength):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype.dataReceived):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveData): (WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveData):
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveData):
  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveData):
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveData):
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didReceiveData): (WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveCachedMetadata):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveData):
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheHost.h:
  • notifications/Notification.cpp: (WebCore::Notification::didReceiveData):
  • notifications/Notification.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didReceiveData):
  • platform/network/BlobResourceHandle.cpp:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveData):
  • platform/network/android/ResourceHandleAndroid.cpp: (WebCore::SyncLoader::didReceiveData):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::WebCoreSynchronousLoaderClient::didReceiveData):
  • platform/network/curl/ResourceHandleCurl.cpp:
  • platform/network/mac/ResourceHandleMac.mm: (WebCoreSynchronousLoaderClient::didReceiveData):
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/win/ResourceHandleWin.cpp:
  • workers/WorkerScriptLoader.h:
  • xml/XMLHttpRequest.h:

2011-04-19 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
​https://bugs.webkit.org/show_bug.cgi?id=58883

Renamed lengthReceived to encodedDataLength/dataLength.

  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didReceiveData):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidReceiveContentLength):
  • src/FrameLoaderClientImpl.h:
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveData):

2011-04-19 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
​https://bugs.webkit.org/show_bug.cgi?id=58883

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchDidReceiveContentLength):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-04-19 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
​https://bugs.webkit.org/show_bug.cgi?id=58883

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
  • WebCoreSupport/FrameLoaderClientGtk.h:
  • webkit/webkitdownload.cpp: (DownloadClient::didReceiveData):

2011-04-19 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
​https://bugs.webkit.org/show_bug.cgi?id=58883

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveContentLength):

2011-04-19 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
​https://bugs.webkit.org/show_bug.cgi?id=58883

  • WebCoreSupport/WebFrameLoaderClient.h:

2011-04-19 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
​https://bugs.webkit.org/show_bug.cgi?id=58883

  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-04-19 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
​https://bugs.webkit.org/show_bug.cgi?id=58883

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
9:52 AM Changeset in webkit [84259] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-19 Stephen White <​senorblanco@chromium.org>

Reviewed by Eric Seidel.

Pull framebuffer clearing out into its own function.
​https://bugs.webkit.org/show_bug.cgi?id=58897

Covered by fast/canvas and canvas/philip tests.

  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clearFramebuffer): (WebCore::DrawingBuffer::reset):
  • platform/graphics/gpu/DrawingBuffer.h:
9:36 AM Changeset in webkit [84258] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-19 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Chromium DevTools: Network panel timing test is flaky
​https://bugs.webkit.org/show_bug.cgi?id=58699

Fixed network timing test flakiness.

  • src/js/Tests.js: (.TestSuite.prototype.testNetworkTiming.finishResource):
9:25 AM Changeset in webkit [84257] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-19 Brian Salomon <​bsalomon@google.com>

Reviewed by Eric Seidel.

When flushing GrContext in ~PlatformContextSkia be sure correct GL context is set
​https://bugs.webkit.org/show_bug.cgi?id=58788

Chromium browser test will be added that loads canvas page and then an
acclerated-composited page. Test must trigger ~PlatformContextSkia()
followed by invocation of GL compositor.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia):
9:01 AM Changeset in webkit [84256] by commit-queue@webkit.org
  • 4 edits in trunk

2011-04-19 Kristóf Kosztyó <​Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Andreas Kling.

[Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
​https://bugs.webkit.org/show_bug.cgi?id=35086

  • platform/qt/Skipped: unskip fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html

2011-04-19 Kristóf Kosztyó <​Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Andreas Kling.

[Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
​https://bugs.webkit.org/show_bug.cgi?id=35086

fast/xmlhttprequest/xmlhttprequest-no-file-access.html caused
a DRT sideeffect problem, because the resetSettings didn't set
the default value of LocalContentCanAccessFileUrls.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
8:38 AM Changeset in webkit [84255] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Mark fast/block/float/overhanging-tall-block.html as failing on Windows and Linux.
​https://bugs.webkit.org/show_bug.cgi?id=58901

  • platform/chromium/test_expectations.txt:
7:43 AM Changeset in webkit [84254] by caseq@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-19 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add chrome.devTools alias to webInspector namespace for chromium port
​https://bugs.webkit.org/show_bug.cgi?id=58894

7:35 AM Changeset in webkit [84253] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit2

2011-04-19 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

WebKit2: Typo fix in WebPopupMenu::Type.
​https://bugs.webkit.org/show_bug.cgi?id=58891

Fixed a typo, Seperator -> Separator.
Also removed m_ prefix on an argument variable name.

  • Shared/WebPopupItem.h:
  • UIProcess/mac/WebPopupMenuProxyMac.mm: (WebKit::WebPopupMenuProxyMac::populate):
  • WebProcess/WebCoreSupport/WebPopupMenu.cpp: (WebKit::WebPopupMenu::populateItems):
7:05 AM Changeset in webkit [84252] by Csaba Osztrogonác
  • 10 edits in trunk

[Qt] REGRESSION(84176): http/tests/xmlhttprequest/event-listener-gc.html fails
​https://bugs.webkit.org/show_bug.cgi?id=58871

Unreviewed, rolling out r84176, r84178, r84186, r84212 and r84231.
​http://trac.webkit.org/changeset/84176 (original patch)
​http://trac.webkit.org/changeset/84178 (original patch - part 2)
​http://trac.webkit.org/changeset/84186 (build fix)
​http://trac.webkit.org/changeset/84212
​http://trac.webkit.org/changeset/84231 (skip failing test)

original bugs:

Source/JavaScriptCore:

  • heap/MarkStack.h:

(JSC::MarkStack::deprecatedAppendValues):
(JSC::MarkStack::append):
(JSC::MarkStack::deprecatedAppend):

  • runtime/JSValue.h:
  • runtime/WriteBarrier.h:

(JSC::DeprecatedPtr::DeprecatedPtr):
(JSC::DeprecatedPtr::get):
(JSC::DeprecatedPtr::operator*):
(JSC::DeprecatedPtr::operator->):
(JSC::DeprecatedPtr::slot):
(JSC::DeprecatedPtr::operator UnspecifiedBoolType*):
(JSC::DeprecatedPtr::operator!):
(JSC::operator==):

Source/WebCore:

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::removeCachedMethod):
(JSC::Bindings::QtInstance::markAggregate):

  • bridge/qt/qt_instance.h:

LayoutTests:

  • platform/qt/Skipped:
6:41 AM Changeset in webkit [84251] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

2011-04-19 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84050.
​http://trac.webkit.org/changeset/84050
​https://bugs.webkit.org/show_bug.cgi?id=58892

fast/dom/HTMLKeygenElement/keygen.html is crashing on Chromium
(Requested by jknotten on #webkit).

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::takeAllChildrenFrom): (WebCore::ContainerNode::removeBetween): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::parserAddChild):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::setDocType):
  • dom/Element.h:
  • dom/Node.cpp: (WebCore::Node::treeScope): (WebCore::Node::setTreeScope): (WebCore::Node::setTreeScopeRecursively):
  • dom/Node.h: (WebCore::Node::document):
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::ShadowRoot):
  • dom/ShadowRoot.h:
  • dom/TreeScope.cpp: (WebCore::TreeScope::TreeScope): (WebCore::TreeScope::setParentTreeScope):
  • dom/TreeScope.h:
  • rendering/RenderSlider.cpp:
6:15 AM Changeset in webkit [84250] by kinuko@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-04-19 Kinuko Yasuda <​kinuko@chromium.org>

Not reviewed; another build fix attempt.

  • src/StorageInfoChromium.cpp: (WebCore::StorageInfo::queryUsageAndQuota): (WebCore::StorageInfo::requestQuota):
  • src/WebStorageQuotaCallbacksImpl.cpp: (WebKit::WebStorageQuotaCallbacksImpl::WebStorageQuotaCallbacksImpl):
  • src/WebStorageQuotaCallbacksImpl.h:
5:49 AM Changeset in webkit [84249] by kinuko@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-19 Kinuko Yasuda <​kinuko@chromium.org>

Not reviewed; windows build fix attempt.

  • storage/StorageInfo.cpp: (WebCore::StorageInfo::~StorageInfo):
  • storage/StorageInfo.h:
5:45 AM Changeset in webkit [84248] by jknotten@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-04-19 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] New mac snowleopard baseline for fast/overflow/003.xml
​https://bugs.webkit.org/show_bug.cgi?id=58885

  • platform/chromium-mac/fast/overflow/003-expected.png: Added.
5:37 AM Changeset in webkit [84247] by kinuko@chromium.org
  • 8 edits in trunk/Source

2011-04-19 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

[Chromium] Enable QUOTA API at runtime if enable-quota flag is given
​https://bugs.webkit.org/show_bug.cgi?id=58784

  • features.gypi: Added ENABLE_QUOTA=1.
  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableQuota): Added. (WebKit::WebRuntimeFeatures::isQuotaEnabled): Added.

2011-04-19 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

[Chromium] Enable QUOTA API at runtime if enable-quota flag is given
​https://bugs.webkit.org/show_bug.cgi?id=58784

No new tests as this does not change any functionality.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::quotaEnabled): (WebCore::RuntimeEnabledFeatures::setQuotaEnabled):
  • page/DOMWindow.idl:
5:13 AM Changeset in webkit [84246] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Mark fast/css/create_element_align.xhtml as slow.
​https://bugs.webkit.org/show_bug.cgi?id=58884

  • platform/chromium/test_expectations.txt:
5:01 AM Changeset in webkit [84245] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Mark fast/events/popup-blocking-timers.html as flaky on Debug Win,Mac,Linux
​https://bugs.webkit.org/show_bug.cgi?id=58882

Filed chromium bug:
​http://code.google.com/p/chromium/issues/detail?id=79857

  • platform/chromium/test_expectations.txt:
4:44 AM Changeset in webkit [84244] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Mark fast/css/only-child-pseudo-class.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=58881

Filed chromium bug:
​http://code.google.com/p/chromium/issues/detail?id=79855

  • platform/chromium/test_expectations.txt:
4:35 AM Changeset in webkit [84243] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Skip new eventSender dependent tests.

Rubber-stamped by Csaba Osztrogonác.

  • platform/qt-wk2/Skipped:
4:32 AM Changeset in webkit [84242] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Mark animations/play-state.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=58880

See also existing chromium bug:
​http://code.google.com/p/chromium/issues/detail?id=76609

  • platform/chromium/test_expectations.txt:
4:19 AM Changeset in webkit [84241] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Mark tables/mozilla/bugs/bug28341.html as flaky on Mac
​https://bugs.webkit.org/show_bug.cgi?id=58879

See also existing chromium bug:
​http://code.google.com/p/chromium/issues/detail?id=32231

  • platform/chromium/test_expectations.txt:
4:09 AM Changeset in webkit [84240] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Mark svg/text/font-size-below-point-five.svg as flaky on Linux, Mac
​https://bugs.webkit.org/show_bug.cgi?id=58878

See also existing chromium bug:
​http://code.google.com/p/chromium/issues/detail?id=74710

  • platform/chromium/test_expectations.txt:
3:49 AM Changeset in webkit [84239] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Mark layout test editing/execCommand/delete-empty-container.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=58877

Chromium bug filed.
​http://code.google.com/p/chromium/issues/detail?id=79854

  • platform/chromium/test_expectations.txt:
3:07 AM Changeset in webkit [84238] by johnnyg@google.com
  • 11 edits in trunk/Source

2011-04-19 John Gregg <​johnnyg@google.com>

Reviewed by Darin Fisher.

Enable folder drag-n-drop when using a "webkitdirectory" file input
​https://bugs.webkit.org/show_bug.cgi?id=58401

This uses a new ChromeClient API to enumerate the directory and
return all the files, as if the user had selected that directory
by clicking the control in the normal way.

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::enumerateChosenDirectory):
  • page/Chrome.cpp: (WebCore::Chrome::enumerateChosenDirectory):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::receiveDropForDirectoryUpload): (WebCore::RenderFileUploadControl::receiveDroppedFiles):
  • rendering/RenderFileUploadControl.h:

2011-04-19 John Gregg <​johnnyg@google.com>

Reviewed by Darin Fisher.

Enable folder drag-n-drop when using a "webkitdirectory" file input
​https://bugs.webkit.org/show_bug.cgi?id=58401

This uses a new ChromeClient API to enumerate the directory and
return all the files, as if the user had selected that directory
by clicking the control in the normal way.

  • public/WebViewClient.h: (WebKit::WebViewClient::enumerateChosenDirectory):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::enumerateChosenDirectory):
  • src/ChromeClientImpl.h:
3:04 AM Changeset in webkit [84237] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Mark animations/combo-transform-translate+scale.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=58876

Chromium bug filed.
​http://code.google.com/p/chromium/issues/detail?id=79853

  • platform/chromium/test_expectations.txt:
2:58 AM Changeset in webkit [84236] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-19 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84150.
​http://trac.webkit.org/changeset/84150
​https://bugs.webkit.org/show_bug.cgi?id=58875

Broken backspace in Search box of Web Inspector (Requested by
apavlov on #webkit).

  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
2:53 AM Changeset in webkit [84235] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-19 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: NPE in TextEditorModel
​https://bugs.webkit.org/show_bug.cgi?id=58870

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._frameAdded):
  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype.setText):
2:50 AM Changeset in webkit [84234] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Mark fast/table/frame-and-rules.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=58874

Chromium bug filed.
​http://code.google.com/p/chromium/issues/detail?id=79851

  • platform/chromium/test_expectations.txt:
2:34 AM Changeset in webkit [84233] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-19 John Knottenbelt <​jknotten@chromium.org>

Unreviewed.

[Chromium] Reenable layout test canvas/philip/tests/2d.gradient.interpolate.outside.html
​https://bugs.webkit.org/show_bug.cgi?id=58873

Fixed in Chromium r81956.
​http://code.google.com/p/chromium/issues/detail?id=79725

  • platform/chromium/test_expectations.txt:
2:04 AM Changeset in webkit [84232] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-19 Hans Wennborg <​hans@chromium.org>

Reviewed by Tony Gentilcore.

IndexedDB: Remove accidental header include directive from LevelDB backend.
​https://bugs.webkit.org/show_bug.cgi?id=58872

No new functionality, no new tests.

  • storage/IDBLevelDBBackingStore.cpp:
2:02 AM Changeset in webkit [84231] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(84194): http/tests/xmlhttprequest/event-listener-gc.html fails
​https://bugs.webkit.org/show_bug.cgi?id=58871

  • platform/qt/Skipped: Add http/tests/xmlhttprequest/event-listener-gc.html
1:30 AM Changeset in webkit [84230] by mario@webkit.org
  • 13 edits in trunk/LayoutTests

2011-04-19 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, rebaselines to fix wrongly added expectations.

By mistake, I added expectations generated with GTK3 locally
instead of the expectations generated in the bots using GTK2, so
we need to add the expectation files as needed.

  • platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.checksum:
  • platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.png:
  • platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.checksum:
  • platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.png:
  • platform/gtk/fast/borders/border-styles-split-expected.checksum:
  • platform/gtk/fast/borders/border-styles-split-expected.png:
  • platform/gtk/fast/borders/mixed-border-styles-radius-expected.checksum:
  • platform/gtk/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/gtk/fast/borders/mixed-border-styles-radius2-expected.checksum:
  • platform/gtk/fast/borders/mixed-border-styles-radius2-expected.png:
  • platform/gtk/fast/borders/webkit-border-radius-expected.checksum:
  • platform/gtk/fast/borders/webkit-border-radius-expected.png:
1:30 AM Changeset in webkit [84229] by jhoneycutt@apple.com
  • 6 edits in trunk/Source/WebKit2

WKContextDownloadURLRequest() should return a WKDownloadRef
​https://bugs.webkit.org/show_bug.cgi?id=58867
Part of <rdar://problem/8931717>

Reviewed by Steve Falkenburg.

  • UIProcess/API/C/WKContext.cpp:

(WKContextDownloadURLRequest):
Return the result of calling WebContext::download().

  • UIProcess/API/C/WKContext.h:

Updated return type of WKContextDownloadURLRequest().

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::download):
Return the DownloadProxy returned by createDownloadProxy().
(WebKit::WebContext::createDownloadProxy):
Return the DownloadProxy.

  • UIProcess/WebContext.h:

Changed return type of download() and createDownloadProxy().

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
Call the DownloadProxy's downloadID() function to get the ID.

1:25 AM Changeset in webkit [84228] by zherczeg@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix.

LEFilter change doesn't compile on ARM neon targets
​https://bugs.webkit.org/show_bug.cgi?id=58671

Thanks for Charlie Lee to fixing this.

  • WebCore.gypi:
1:06 AM Changeset in webkit [84227] by mario@webkit.org
  • 1 edit
    21 adds in trunk/LayoutTests

2011-04-19 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, added new baselines for the GTK port.

Added missing baselines to GTK after revisions 83998, 84092 and 84180.

  • platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.checksum: Added.
  • platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.png: Added.
  • platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.checksum: Added.
  • platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.png: Added.
  • platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/borders/border-styles-split-expected.checksum: Added.
  • platform/gtk/fast/borders/border-styles-split-expected.png: Added.
  • platform/gtk/fast/borders/border-styles-split-expected.txt: Added.
  • platform/gtk/fast/borders/mixed-border-styles-expected.checksum: Added.
  • platform/gtk/fast/borders/mixed-border-styles-expected.png: Added.
  • platform/gtk/fast/borders/mixed-border-styles-expected.txt: Added.
  • platform/gtk/fast/borders/mixed-border-styles-radius-expected.checksum: Added.
  • platform/gtk/fast/borders/mixed-border-styles-radius-expected.png: Added.
  • platform/gtk/fast/borders/mixed-border-styles-radius-expected.txt: Added.
  • platform/gtk/fast/borders/mixed-border-styles-radius2-expected.checksum: Added.
  • platform/gtk/fast/borders/mixed-border-styles-radius2-expected.png: Added.
  • platform/gtk/fast/borders/mixed-border-styles-radius2-expected.txt: Added.
  • platform/gtk/fast/borders/webkit-border-radius-expected.checksum: Added.
  • platform/gtk/fast/borders/webkit-border-radius-expected.png: Added.
  • platform/gtk/fast/borders/webkit-border-radius-expected.txt: Added.
12:24 AM Changeset in webkit [84226] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-19 Daniel Bates <​dbates@webkit.org>

Attempt to fix the Qt Linux Release Minimal build after changeset 84225
<​http://trac.webkit.org/changeset/84225> (​https://bugs.webkit.org/show_bug.cgi?id=52788).

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::ensureEventAncestors): Add ENABLE(SVG) guards around call to Node::svgShadowHost() since this method is only defined when building with SVG enabled.
Note: See TracTimeline for information about the timeline view.