Timeline



Jun 30, 2011:

11:50 PM Changeset in webkit [90209] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-30 Eugene Klyuchnikov <eustas.bug@gmail.com>

Reviewed by Pavel Feldman.

WebInspector: Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=40447

  • inspector/editor/text-editor-model-replace-tabs-expected.txt: Added.
  • inspector/editor/text-editor-model-replace-tabs.html: Added.

2011-06-30 Eugene Klyuchnikov <eustas.bug@gmail.com>

Reviewed by Pavel Feldman.

WebInspector: Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=40447

Test: inspector/editor/text-editor-model-replace-tabs.html

  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded): avoid looped production of tail substrings
11:36 PM Changeset in webkit [90208] by tkent@chromium.org
  • 2 edits
    10 adds in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[Chromium] Update test expectations.

  • platform/chromium-mac-leopard/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
  • platform/chromium-mac-leopard/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:34 PM Changeset in webkit [90207] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove the concept of "being wedged" from new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=63767

Worker processes shouldn't ever become wedged. My understanding is
that this code was originally motivated by the old threading-based
design but no longer servers any purpose.

Note: If we actually have a problem with the test harness getting
stuck, buildbot will kill us.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
11:06 PM Changeset in webkit [90206] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-30 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Hajime Morita.

[Chromium] Remove WebBindings::makeNode.
https://bugs.webkit.org/show_bug.cgi?id=63613

Dead code elimination. No change in behaviour, so no new tests.

  • public/WebBindings.h:
  • src/WebBindings.cpp:
10:47 PM Changeset in webkit [90205] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-30 Adam Barth <abarth@webkit.org>

The win32 implementation of fork is sad about forking test-webkitpy.
Hopefully this will heal the bot.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
10:44 PM Changeset in webkit [90204] by tkent@chromium.org
  • 50 edits
    2 copies
    13 adds
    2 deletes in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[Chromium] Update expectation files for r90089.

  • platform/chromium-linux/fast/css/input-search-padding-expected.png:
  • platform/chromium-linux/fast/css/input-search-padding-expected.txt:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/forms/placeholder-set-value-expected.png: Added.
  • platform/chromium-linux/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/searchfield-heights-expected.txt.
  • platform/chromium-linux/fast/repaint/search-field-cancel-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-linux/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
  • platform/chromium-linux/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
  • platform/chromium-linux/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/chromium-mac/fast/css/input-search-padding-expected.png: Removed.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win-vista/fast/forms/search-styled-expected.txt: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/css/input-search-padding-expected.png:
  • platform/chromium-win/fast/css/input-search-padding-expected.txt:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-set-value-expected.txt:
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.png:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.png: Added.
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
  • platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
  • platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
  • platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png.
  • platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:07 PM Changeset in webkit [90203] by tkent@chromium.org
  • 7 edits
    3 adds
    5 deletes in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[Chromium-Mac] Update test expectation files.

  • platform/chromium-mac-leopard/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.png: Removed.
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png: Added.
  • platform/chromium-mac/fast/forms/button-sizes-expected.png: Added.
  • platform/chromium-mac/fast/forms/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png:
  • platform/chromium-mac/fast/forms/slider-padding-expected.png: Removed.
  • platform/chromium-mac/fast/forms/slider-thumb-shared-style-expected.png: Removed.
  • platform/chromium-mac/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
9:59 PM Styling Form Controls edited by tkent@chromium.org
Add another example of validation bubble styling (diff)
9:54 PM validation-bubble-styled.png attached to Styling Form Controls by tkent@chromium.org
8:54 PM Changeset in webkit [90202] by tkent@chromium.org
  • 4 edits in trunk

2011-06-30 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=63697

  • platform/chromium/test_expectations.txt: Some tests need new expectation images.

2011-06-30 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=63697

http://trac.webkit.org/changeset/86261 added a thumb flipping code
for Mac-WebKit2. Chromium also needs it.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb): Always flip vertically on Chromium.
8:31 PM Changeset in webkit [90201] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update new-run-webkit-tests now that the wk2 shared skipped list has moved
https://bugs.webkit.org/show_bug.cgi?id=63780

The shared list was moved from mac-wk2 to wk2 as part of
http://trac.webkit.org/changeset/90125.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
8:28 PM Changeset in webkit [90200] by bashi@chromium.org
  • 3 edits
    13 adds in trunk

2011-06-30 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Simon Fraser.

[Chromium] -webkit-text-stroke doesn't affect with non-zero width border property
https://bugs.webkit.org/show_bug.cgi?id=63698

Added a test which ensures text stroke is rendered with non-zero width border.

  • platform/chromium-linux/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Added.
  • platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.txt: Added.
  • platform/chromium/fast/text/text-stroke-with-border.html: Added.

2011-06-30 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Simon Fraser.

[Chromium] -webkit-text-stroke doesn't affect with non-zero width border property
https://bugs.webkit.org/show_bug.cgi?id=63698

Restore the stroke style when it is modified in RenderObject::drawLineForBoxSide() to show text stroke correctly.

Test: platform/chromium/fast/text/text-stroke-with-border.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawLineForBoxSide): Save/restore the stroke style.
8:06 PM Changeset in webkit [90199] by scherkus@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-30 Andrew Scherkus <scherkus@chromium.org>

Unreviewed.

Rebaselining video-currentTime-set.html for Chromium due to FFmpeg update.

  • platform/chromium-mac/media/video-currentTime-set-expected.txt:
  • platform/chromium-win/media/video-currentTime-set-expected.txt:
8:06 PM Changeset in webkit [90198] by Darin Adler
  • 12 edits in trunk/Source/WebKit2

2011-06-30 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

[WebKit2] Consider scale factor when allocating backing store
https://bugs.webkit.org/show_bug.cgi?id=63766

This is the first step in considering scale factor. It considers
scale factor for the primary backing store, not graphics layers,
and for CG only.

  • Platform/cg/CGUtilities.cpp: (WebKit::paintImage): Added a scale factor argument. (WebKit::paintBitmapContext): Pass 1 for scale factor.
  • Platform/cg/CGUtilities.h: Updated for above.
  • Shared/ShareableBitmap.h: Added an overload of paint that can handle a scale factor.
  • Shared/UpdateInfo.cpp: (WebKit::UpdateInfo::encode): Encode scale factor. (WebKit::UpdateInfo::decode): Decode scale factor.
  • Shared/UpdateInfo.h: Added scale factor.
  • Shared/cg/ShareableBitmapCG.cpp: (WebKit::ShareableBitmap::paint): Added the overload that can handle a scale factor.
  • UIProcess/BackingStore.cpp: (WebKit::BackingStore::create): Take a scale factor. (WebKit::BackingStore::BackingStore): Store the scale factor. (WebKit::BackingStore::incorporateUpdate): Consider the scale factor when asserting the size is correct.
  • UIProcess/BackingStore.h: Add a scale factor.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): Check the scale factor too when deciding whether to reuse a backing store. (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Pass in the scale factor when creating a backing store.
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::incorporateUpdate): Take the scale factor into account when painting.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Put the scale factor into the UpdateInfo. (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Ditto. (WebKit::DrawingAreaImpl::display): Take the scale factor into account when allocating the bitmap and creating a graphics context for it.
7:59 PM Changeset in webkit [90197] by bashi@chromium.org
  • 2 edits
    2 adds in trunk/Tools

2011-06-30 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Darin Adler.

Style Checker should flag removal of "developmentRegion = English;" from project.pbxproj.
https://bugs.webkit.org/show_bug.cgi?id=62022

Adds XcodeProjectFileChecker to check removal of "developmentRegion".

  • Scripts/webkitpy/style/checker.py: Added XcodeProjectFileChecker as a checker for *.pbxproj.
  • Scripts/webkitpy/style/checkers/xcodeproj.py: Added.
  • Scripts/webkitpy/style/checkers/xcodeproj_unittest.py: Added.
7:55 PM Changeset in webkit [90196] by yutak@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-30 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Don't use old Hixie75 handshake in pywebsocket handlers
https://bugs.webkit.org/show_bug.cgi?id=63704

  • http/tests/websocket/tests/bad-handshake-crash_wsh.py: Use handshake format of Hixie's protocol draft 76 which we are currently supporting.
  • http/tests/websocket/tests/long-invalid-header_wsh.py: Content of web_socket_transfer_data() is completely bogus. It's not necessary.
7:52 PM Changeset in webkit [90195] by tkent@chromium.org
  • 5 edits in trunk

2011-06-30 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement WebCore::defaultDetailsSummaryText()
https://bugs.webkit.org/show_bug.cgi?id=63700

  • platform/chromium/test_expectations.txt: Tests for <details> fail temporarily.

2011-06-30 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement WebCore::defaultDetailsSummaryText()
https://bugs.webkit.org/show_bug.cgi?id=63700

  • public/WebLocalizedString.h: Add new key.
  • src/LocalizedStrings.cpp: Call query() with the new key. (WebCore::defaultDetailsSummaryText):
7:42 PM Changeset in webkit [90194] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-30 Oliver Hunt <oliver@apple.com>

Reviewed by Beth Dakin.

Make GC validation clear cell structure on destruction
https://bugs.webkit.org/show_bug.cgi?id=63778

  • runtime/JSCell.h: (JSC::JSCell::JSCell::~JSCell):
7:17 PM Changeset in webkit [90193] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

Added write barrier that was missing from put_by_id_transition
https://bugs.webkit.org/show_bug.cgi?id=63775

  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::writeBarrier): Made this static with a MacroAssembler& argument so our patching functions could use it.

(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile): Updated for signature change.
  • dfg/DFGRepatch.cpp: (JSC::DFG::tryCachePutByID): Missing barrier!
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile): Updated for signature change.
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompilePutByIdTransition):
  • jit/JSInterfaceJIT.h: Same game here. Removed storePtrWithWriteBarrier because its meaning isn't clear -- maybe in the future we'll have a clear way to pass all stores through a common function that guarantees a write barrier, but that's not the case right now.
7:10 PM Changeset in webkit [90192] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-06-30 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

nrwt: make sharding tests needing locks less hard-coded
https://bugs.webkit.org/show_bug.cgi?id=63112

This change also changes the manager logic so that it will
drop the server lock as soon as all of the shards requiring
the lock have completed.

This change includes some minor namespace/import changes in the
unit tests, and also makes the Manager a new-style object, which
it should've been all along.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
6:55 PM Changeset in webkit [90191] by abarth@webkit.org
  • 11 edits in trunk/Tools

2011-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove threaded mode from new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=63771

This mode is not used and is buggy. Rather than carry around a bunch
of unused buggy code, we should rip it out and focus on the
multiprocess implementation.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
6:33 PM Changeset in webkit [90190] by scherkus@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-30 Andrew Scherkus <scherkus@chromium.org>

Unreviewed.

Temporarily disabling WTF_USE_WEBAUDIO_FFMPEG due to FFmpeg update.

  • features.gypi:
6:04 PM Changeset in webkit [90189] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-30 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG non-speculative JIT does not reuse registers when compiling comparisons.
https://bugs.webkit.org/show_bug.cgi?id=63565

  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::knownConstantArithOp): (JSC::DFG::NonSpeculativeJIT::basicArithOp): (JSC::DFG::NonSpeculativeJIT::compare):
5:28 PM Changeset in webkit [90188] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-30 Gwang Yoon Hwang <ryumiel@company100.net>

Reviewed by Nate Chapin.

[V8] Add ENABLE(INSPECTOR) guards around v8 custom bindings.
https://bugs.webkit.org/show_bug.cgi?id=63442

No new tests needed.

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
5:17 PM BuildingGtk edited by Martin Robinson
(diff)
5:10 PM Changeset in webkit [90187] by ggaren@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

Added empty write barrier stubs in all the right places in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=63764


SunSpider thinks this might be a 0.5% speedup. Meh.

  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::writeBarrier): Le stub.

(JSC::DFG::JITCodeGenerator::cachedPutById): Don't do anything special
for the case where base == scratch, since we now require base and scratch
to be not equal, for the sake of the write barrier.

  • dfg/DFGJITCodeGenerator.h: Le stub.
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile): Don't reuse the base register as the scratch register, since that's incompatible with the write barrier, which needs a distinct base and scratch.


Do put the global object into a register before loading its var storage,
since it needs to be in a register for the write barrier to operate on it.

  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emitWriteBarrier): Second verse, same as the first.
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_put_global_var): Deployed offsetOfRegisters() to more places.

(JSC::JIT::emitWriteBarrier): Added a teeny tiny ASSERT so this function
is a little more than meaningless.

  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_put_global_var): Deployed offsetOfRegisters() to more places.

(JSC::JIT::emitWriteBarrier): Added a teeny tiny ASSERT so this function
is a little more than meaningless.

  • runtime/JSVariableObject.h: (JSC::JSVariableObject::offsetOfRegisters): Now used by the JIT, since we put the global object in a register and only then load its var storage by offset.

(JSC::JIT::emitWriteBarrier):

4:48 PM Changeset in webkit [90186] by leviw@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-30 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Remove positionForCoordinates
https://bugs.webkit.org/show_bug.cgi?id=63765

Removing positionForCoordinate. We should always use positionForPoint. Also cleaning up
RenderBox's implementation of positionForPoint.

No new tests, there should be no functionality changes.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue): Removing dead, or at least untested, code and adding an ASSERT_NOT_REACHED. (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint): cleaning up some ugly code.
  • rendering/RenderInline.cpp: (WebCore::RenderInline::positionForPoint):
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
4:46 PM Changeset in webkit [90185] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-30 John Bates <jbates@google.com>

Reviewed by James Robinson.

Chromium bug: Compositing on a lost context causes latch deadlocks.
The cause of deadlock was that a setLatch command is added to the lost
compositor GL context, and a waitLatch would never complete on a child context.
This change checks whether the compositor context is in error state before
doing the compositing.
https://bugs.webkit.org/show_bug.cgi?id=63681

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):
4:40 PM Changeset in webkit [90184] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Clean up output from new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=63759

Printing messages from the child process looks super ugly because of
the way the pretty-printer works. Printing a blank line first is a
hack, but it makes things at least partially sane.

Also, handle the case where calling sample throws an exception.

  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
4:39 PM Changeset in webkit [90183] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.4.2

Tagging the 1.4.2 release of WebKitGTK+

4:37 PM Changeset in webkit [90182] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.4

2011-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Update the library and libtool version in preparation for the 1.4.2 release.

  • configure.ac: Update versions.

2011-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Update the news in preparation for the 1.4.2 release.

  • NEWS: Update news.
4:30 PM Changeset in webkit [90181] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-30 Rafael Brandao <rafael.lobo@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Fix tst_QWebFrame::renderGeometry() API test
https://bugs.webkit.org/show_bug.cgi?id=63236

This test required a security origin with granted permission to request local resources.
By default, only local files can load local resources. So modified baseUrl to be a local file.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::renderGeometry):
4:24 PM Changeset in webkit [90180] by zmo@google.com
  • 11 edits in trunk

2011-06-30 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Improve WebGL object lifetime management in WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=63635

  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html: Fix a bug so getFramebufferAtatchmentParameter generates an error if nothing is attached and something other than TYPE is queried.
  • fast/canvas/webgl/object-deletion-behaviour-expected.txt:
  • fast/canvas/webgl/object-deletion-behaviour.html: Ditto.
  • fast/canvas/webgl/program-test.html: Fix the test so the order of shaders returned by getAttachedShaders doesn't matter.

2011-06-30 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Improve WebGL object lifetime management in WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=63635

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getAttachedShaders): Use cached objects instead of querying the underlying GL. (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Ditto. (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects): Multiple loop because objects might be removed from the table within an iteration.
  • html/canvas/WebGLRenderingContext.h:
4:20 PM Changeset in webkit [90179] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix ARMv6 build

4:09 PM Changeset in webkit [90178] by diegohcg@webkit.org
  • 9 edits in trunk

2011-06-27 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Antonio Gomes.

[Qt] DRT: Provide LayoutTestController::setDefersLoading and ::goBack support
https://bugs.webkit.org/show_bug.cgi?id=63489

Unskipped:

loader/navigation-while-deferring-loads.html

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setDefersLoading): (DumpRenderTreeSupportQt::goBack):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::goBack): (LayoutTestController::setDefersLoading):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

  • platform/qt/Skipped:
4:08 PM Changeset in webkit [90177] by oliver@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

2011-06-30 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Add optimised paths for a few maths functions
https://bugs.webkit.org/show_bug.cgi?id=63757

This adds specialised thunks for Math.abs, Math.round, Math.ceil,
Math.floor, Math.log, and Math.exp as they are apparently more
important in real web content than we thought, which is somewhat
mind-boggling. On average doubles the performance of the common
cases (eg. actually passing numbers in). They're not as efficient
as they could be, but this way gives them the most portability.

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsDoubleBitops): (JSC::MacroAssemblerARM::andnotDouble):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsDoubleBitops): (JSC::MacroAssemblerARMv7::andnotDouble):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::andnotDouble): (JSC::MacroAssemblerMIPS::supportsDoubleBitops):
  • assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::supportsDoubleBitops): (JSC::MacroAssemblerSH4::andnotDouble):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::supportsDoubleBitops):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::andnotDouble):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::supportsDoubleBitops):
  • assembler/X86Assembler.h: (JSC::X86Assembler::andnpd_rr):
  • create_hash_table:
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize): (JSC::SpecializedThunkJIT::callDoubleToDouble):
  • jit/ThunkGenerators.cpp: (JSC::floorThunkGenerator): (JSC::ceilThunkGenerator): (JSC::roundThunkGenerator): (JSC::expThunkGenerator): (JSC::logThunkGenerator): (JSC::absThunkGenerator):
  • jit/ThunkGenerators.h:
4:07 PM Changeset in webkit [90176] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Dirk Pranke.

new-run-webkit-tests should stop when I C it
https://bugs.webkit.org/show_bug.cgi?id=63763

It still doesn't stop fast enough, but at least with this patch it
doesn't run more tests.

Also, I tweaked the UI that happens when there's a keyboard interrupt
to not be amazingly ugly. There's still a garbage "Te" left on the
console, but that's a problem for another day.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
4:05 PM Changeset in webkit [90175] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/LayoutTests

2011-06-30 Alan Stearns <stearns@adobe.com>

Reviewed by Tony Chang.

Modify Skipped files so that future css exclusions LayoutTests are
skipped by default.

[CSSExclusions] Add test and skip entries
https://bugs.webkit.org/show_bug.cgi?id=63751

  • fast/exclusions/triangle-exclusion.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:39 PM Changeset in webkit [90174] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Rafael Brandao <rafael.lobo@openbossa.org>

Reviewed by Andreas Kling.

[Qt] build-webkit warning: cannot find file ElementShadowPseudoId.h
https://bugs.webkit.org/show_bug.cgi?id=63747

Removed reference to ElementShadowPseudoId.h that no longer exists.

  • WebCore.pro:
3:29 PM Changeset in webkit [90173] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix clang build.

Remove the complete Widget constructor from the .exp.in file; since Widget is an abstract class,
its complete constructor can never be called and clang has stopped emitting it altogether.

  • WebCore.exp.in:
3:28 PM Changeset in webkit [90172] by Adam Roben
  • 3 edits in trunk/Tools

Make TestFailures never treat a too-many-failures build as a last-passing build for a test

Fixes <http://webkit.org/b/63758> TestFailures sometimes incorrectly says that a build was
the last passing build for a test, when in fact the test wasn't run due to too many failures
causing old-run-webkit-tests to exit early

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): If there were too many
failures in this build, assume that all the tests failed in the last build would have failed
in this build, too, had they been run. Introduced some new local variables to reduce typing,
and used them throughout.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Fix a regression from r89841 where we wouldn't
correctly remember whether old-run-webkit-tests exited early due to too many failures for
builds older than r89610. Also removed an unused parameter while I was at it.

3:28 PM Changeset in webkit [90171] by cevans@google.com
  • 4 edits
    4 copies in branches/chromium/782

Merge 90068
BUG=78841
Review URL: http://codereview.chromium.org/7292017

3:17 PM Changeset in webkit [90170] by cevans@google.com
  • 7 edits
    2 copies in branches/chromium/782

Merge 89705
BUG=86609

3:15 PM Changeset in webkit [90169] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-30 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintingRootRect and RenderObject repaint methods to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63746

Switching paintingRootRect and RenderObject repaint functions over to the
new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::repaintDuringLayoutIfMoved):
  • rendering/RenderBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintingRootRect): (WebCore::RenderObject::paint): (WebCore::RenderObject::repaintUsingContainer): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::repaintDuringLayoutIfMoved):
  • rendering/RenderObject.h:
3:10 PM Changeset in webkit [90168] by mrowe@apple.com
  • 5 edits in trunk/Source/WebKit2

Fix the Windows build.

  • UIProcess/API/C/win/WKTextChecker.h:
  • UIProcess/API/C/win/WKView.h:
  • UIProcess/win/WebTextCheckerClient.h:
  • UIProcess/win/WebUndoClient.h:
3:00 PM Changeset in webkit [90167] by commit-queue@webkit.org
  • 27 edits in trunk/Source

2011-06-30 Cary Clark <caryclark@google.com>

Reviewed by James Robinson.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

  • wtf/Platform.h: Add switch to use Skia if, externally, Skia has been enabled by a gyp define.

2011-06-30 Cary Clark <caryclark@google.com>

Reviewed by James Robinson.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

No new tests. This does not affect existing
functionality.

  • WebCore.gyp/WebCore.gyp: Include Skia and related files and exclude CG and related files when building Chromium for Skia on the Mac.
  • loader/cache/CachedFont.cpp: Rename CHROME to CHROMIUM.
  • platform/chromium/DragImageRef.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Ditto.

2011-06-30 Cary Clark <caryclark@google.com>

Reviewed by James Robinson.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

  • WebKit.gyp: If building for Skia, exclude CG files. If not, exclude Skia files.
  • features.gypi: Enable Skia on Chromium Mac if so instructed by the gyp define. Allow Skia to be hardware accelerated on the Mac.
  • public/WebCommon.h: If Skia is defined on the Mac, define it in the WebXXX interfaces as well.
2:51 PM Changeset in webkit [90166] by jchaffraix@webkit.org
  • 5 edits
    3 adds in trunk

2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Nikolas Zimmermann.

Update SVG position values on SVG DOM updates
https://bugs.webkit.org/show_bug.cgi?id=62439

  • svg/custom/crash-textPath-attributes-expected.txt: Added.
  • svg/custom/crash-textPath-attributes.html: Added.
  • svg/custom/resources/crash-textPath-attributes-iframe.svg: Added.

2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Nikolas Zimmermann.

Update SVG position values on SVG DOM updates
https://bugs.webkit.org/show_bug.cgi?id=62439

Test: svg/custom/crash-textPath-attributes.html

  • rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::destroy): Notify our containing RenderSVGText that it needs to update its positioning information.
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::calculateBoundaries): Check the type of the InlineBox like the rest of the code (fixes an ASSERT_NOT_REACHED in InlineBox::calculateBoudaries).
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): Clear our cached layout attributes every time we invalidate them. This avoids keeping stale attribute that have a backpointer to a RenderObject.
2:49 PM Changeset in webkit [90165] by Adam Roben
  • 3 edits in trunk/Tools

Make TestFaiulres only load old-results directories as needed

Fixes <http://webkit.org/b/63752> Tester pages on TestFailures page load very slowly

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getBuildNames): Moved up into the API section of the class. Now just
calls through to _getBuildNamesFromResultsDirectory.
(Builder.prototype.getOldBuildNames): Added. Just calls through to
_getBuildNamesFromResultsDirectory.
(Builder.prototype._getBuildNamesFromResultsDirectory): Renamed from getBuildNames. Now
takes the directory URL as an argument and only fetches that single URL.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype.start): Moved most logic to _analyzeBuilds. First
analyzes builds from Builder.getBuildNames, then from Builder.getOldBuildNames if needed.
(LayoutTestHistoryAnalyzer.prototype._analyzeBuilds): Moved logic here from start. (Most
changes are just indentation.) Now takes a callback to call when we've finished analyzing
all builds in buildNames so that we can try to fetch more build names if needed.

2:46 PM Changeset in webkit [90164] by commit-queue@webkit.org
  • 14 edits
    16 adds in trunk

2011-06-30 Sreeram Ramachandran <sreeram@chromium.org>

Reviewed by Adam Barth.

Suppress modal JavaScript/HTML dialogs during unload events
https://bugs.webkit.org/show_bug.cgi?id=56397

Adds Chromium-specific test expectations that show alerts in unload
handlers being replaced by console messages.

  • fast/loader/page-dismissal-modal-dialogs-expected.txt: Added.
  • fast/loader/page-dismissal-modal-dialogs.html: Added.
  • fast/loader/resources/page-dismissal-modal-dialogs-iframe.html: Added.
  • platform/chromium-mac/fast/history/timed-refresh-in-cached-frame-expected.txt:
  • platform/chromium-win/fast/history/timed-refresh-in-cached-frame-expected.txt:
  • platform/chromium/fast/dom/Geolocation/notimer-after-unload-expected.txt: Added.
  • platform/chromium/fast/events/onbeforeunload-focused-iframe-expected.txt: Added.
  • platform/chromium/fast/events/onunload-clears-onbeforeunload-expected.txt: Added.
  • platform/chromium/fast/events/onunload-expected.txt: Added.
  • platform/chromium/fast/events/onunload-not-on-body-expected.txt: Added.
  • platform/chromium/fast/events/onunload-window-property-expected.txt: Added.
  • platform/chromium/fast/events/pageshow-pagehide-on-back-uncached-expected.txt: Added.
  • platform/chromium/fast/history/timed-refresh-in-cached-frame-expected.txt: Added.
  • platform/chromium/fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt: Added.
  • platform/chromium/fast/loader/page-dismissal-modal-dialogs-expected.txt: Added.
  • platform/chromium/fast/loader/recursive-before-unload-crash-expected.txt: Added.

2011-06-30 Sreeram Ramachandran <sreeram@chromium.org>

Reviewed by Adam Barth.

Suppress modal JavaScript/HTML dialogs during unload events
https://bugs.webkit.org/show_bug.cgi?id=56397

Allows clients to specify whether to show alerts during unload handlers.
When checking for whether a page dismissal event is being dispatched,
it's important to check all frames on the page (otherwise it becomes a
loophole easily exploited).

Test: fast/loader/page-dismissal-modal-dialogs.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::fireBeforeUnloadEvent):
  • loader/FrameLoader.h: (WebCore::FrameLoader::pageDismissalEventBeingDispatched):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestImage):
  • page/Chrome.cpp: (WebCore::canRunModalIfDuringPageDismissal): (WebCore::Chrome::canRunModalNow): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt):
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::shouldRunModalDialogDuringPageDismissal):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::showModalDialog):

2011-06-30 Sreeram Ramachandran <sreeram@chromium.org>

Reviewed by Adam Barth.

Suppress modal JavaScript/HTML dialogs during unload events
https://bugs.webkit.org/show_bug.cgi?id=56397

Implementation of the new shouldRunModalDialogDuringPageDismissal() API
to block alerts during unload handlers. Logs such events to the console
and updates histograms.

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):
  • src/ChromeClientImpl.h:
2:46 PM Changeset in webkit [90163] by mrowe@apple.com
  • 11 edits in trunk/Tools

Update MiniBrowser and WebKitTestRunner to use the client version constants.

Reviewed by Anders Carlsson.

  • MiniBrowser/gtk/BrowserWindow.c:

(browserWindowLoaderClientInit):
(browserWindowUIClientInit):

  • MiniBrowser/gtk/WebBundle/WebBundleMain.c:

(didCreatePage):
(WKBundleInitialize):

  • MiniBrowser/gtk/main.c:

(createWKContextWithInjectedBundle):

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(WKBundleInitialize):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

2:46 PM Changeset in webkit [90162] by mrowe@apple.com
  • 7 edits
    2 copies in trunk/Source/WebKit2

Teach APIClient to correctly handle multiple versions of a client interface.

Reviewed by Anders Carlsson.

If a client struct is not the current version then we can't copy it via assignment
since that will read past the end of the smaller, older struct. To deal with this
APIClient needs to be aware of the sizes of the older client version structs so that
it can copy only the appropriate amount of the struct.

  • Shared/APIClient.h:

(WebKit::APIClient::initialize): Assign through to our client if the new in client is the
latest version. If an older client version was passed then we zero out our client and memcpy
the appropriate number of bytes in to it. This ensures that any new members in the client
are initialized to 0.

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h: Client interfaces are the size of their struct unless otherwise stated.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Bump the version and add comments indicating

which components belong to which versions.

2:46 PM Changeset in webkit [90161] by mrowe@apple.com
  • 25 edits in trunk/Source/WebKit2

Make the APIClient template aware of the latest client interface version number.

Reviewed by Anders Carlsson.

This will be used in an upcoming patch.

  • Shared/APIClient.h:
  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebCookieManagerProxyClient.h:
  • UIProcess/WebDatabaseManagerProxyClient.h:
  • UIProcess/WebDownloadClient.h:
  • UIProcess/WebFindClient.h:
  • UIProcess/WebFormClient.h:
  • UIProcess/WebGeolocationProvider.h:
  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebIconDatabaseClient.h:
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageContextMenuClient.h:
  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebResourceLoadClient.h:
  • UIProcess/WebUIClient.h:
  • WebProcess/InjectedBundle/InjectedBundleClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
2:46 PM Changeset in webkit [90160] by mrowe@apple.com
  • 10 edits in trunk/Source/WebKit2

WebKit2 client interfaces should have constant declaring latest version.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKCookieManager.h:
  • UIProcess/API/C/WKDatabaseManager.h:
  • UIProcess/API/C/WKGeolocationManager.h:
  • UIProcess/API/C/WKIconDatabase.h:
  • UIProcess/API/C/WKPage.h:
  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
2:41 PM Changeset in webkit [90159] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-06-30 Juan C. Montemayor <jmont@apple.com>

Reviewed by Geoffrey Garen.

Web Inspector fails to display source for eval with syntax error
https://bugs.webkit.org/show_bug.cgi?id=63583

Added new LayoutTest to check that the correct line number is added to a
syntax error inside an eval statement.

  • fast/js/eval-contained-syntax-error-expected.txt: Added.
  • fast/js/eval-contained-syntax-error.html: Added.
  • fast/js/script-tests/eval-contained-syntax-error.js: Added.
  • platform/chromium/fast/js/eval-contained-syntax-error-expected.txt: Added.

2011-06-30 Juan C. Montemayor <jmont@apple.com>

Reviewed by Geoffrey Garen.

Web Inspector fails to display source for eval with syntax error
https://bugs.webkit.org/show_bug.cgi?id=63583

Web Inspector now displays a link to an eval statement that contains
a syntax error.

  • parser/Parser.h: (JSC::isEvalNode): (JSC::EvalNode): (JSC::Parser::parse):
2:37 PM Changeset in webkit [90158] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2011-06-30 Nate Chapin <Nate Chapin>

Unreviewed, chromium test update after r90148.

  • platform/chromium/test_expectations.txt:
2:30 PM Changeset in webkit [90157] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-30 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

X86Assembler does not encode byte registers in 64-bit mode correctly.
https://bugs.webkit.org/show_bug.cgi?id=63665

  • assembler/X86Assembler.h: (JSC::X86Assembler::testb_rr): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp8):
1:50 PM Changeset in webkit [90156] by jchaffraix@webkit.org
  • 6 edits
    4 adds in trunk

2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Nikolas Zimmermann.

Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
https://bugs.webkit.org/show_bug.cgi?id=63076

  • svg/custom/crash-text-in-textpath-expected.txt: Added.
  • svg/custom/crash-text-in-textpath.svg: Added. Original crashing test case.
  • svg/custom/text-node-in-text-invalidated-expected.txt: Added.
  • svg/custom/text-node-in-text-invalidated.svg: Added. This test case was not crashing. However it is good to make sure this change did not regress that.

2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Nikolas Zimmermann.

Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
https://bugs.webkit.org/show_bug.cgi?id=63076

Tests: svg/custom/crash-text-in-textpath.svg

svg/custom/text-node-in-text-invalidated.svg

The problem was that we did not call setNeedsPositionUpdate on RenderSVGText. When
doing our layout, we would not update the attributes on our SVGRenderInlineText as
we would not lay it out.

This was caused by childrenChanged being overridden on SVGTextPositioningElement but
not on SVGTextPathElement.

As both classes shared the same mother class, it made sense to move the logic here.
There should be no other side effects as SVGTextPathElement and SVGTextPositioningElement
are the only classes deriving from SVGTextContentElement.

  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::childrenChanged): Moved this method from SVGTextPositioningElement.
  • svg/SVGTextContentElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged): Updated after updatePositioningValuesInRenderer removal, replaced by RenderSVGText::locateRenderSVGTextAncestor.
  • svg/SVGTextPositioningElement.h:
1:22 PM Changeset in webkit [90155] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • UIProcess/win/WebPopupMenuProxyWin.h:

(WebKit::WebPopupMenuProxyWin::enclosingScrollableArea):

1:17 PM Changeset in webkit [90154] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-06-30 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix for !ENABLE(DATABASE) after r84789.

  • bindings/js/JSDOMBinding.cpp:
1:03 PM Changeset in webkit [90153] by Adam Roben
  • 5 edits in trunk/Tools

Identify revisions that modified failing tests on TestFailures page

Fixes <http://webkit.org/b/63716> TestFailures page should try to infer which commit caused
a failure by looking at commit logs

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(.existing-bugs-list, .suspect-revisions-list): Made this rule apply to the suspect
revisions list, too.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:

(Trac): Initialize our memory cache.
(Trac.prototype.getCommitDataForRevisionRange): Added. Fetches the commit log in RSS form,
then parses out the revision number, Trac's idea of the commit title, and the files modified
by the commit. (To get the modified files, we rely on the commit message including a
prepare-ChangeLog-style file list.)
(Trac.prototype.logURL): Added a new formatAsRSS parameter.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(removePathExtension): Added. Returns a new string with the last dot and everything after it
removed.
(sorted): Added sortFunction parameter.
(Node.prototype.removeAllChildren): Added. Does what it says.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Updated for change to _domForRegressionRange.
(ViewController.prototype._domForRegressionRange): Changed argument order to match
_domForNewAndExistingBugs. Now takes the list of failing tests and uses it to figure out
which revisions modified the failing tests and displays the suspect revisions in a list.

12:40 PM Changeset in webkit [90152] by andersca@apple.com
  • 17 edits in trunk/Source

2011-06-30 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

More ScrollableArea scaffolding
https://bugs.webkit.org/show_bug.cgi?id=63678

Add an enclosingScrollableArea stub.

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::enclosingScrollableArea):
  • src/WebScrollbarImpl.h:

2011-06-30 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

More ScrollableArea scaffolding
https://bugs.webkit.org/show_bug.cgi?id=63678

  • WebScrollBar.h: (WebScrollBar::enclosingScrollableArea): Always return 0, WebScrollbar has no concept of an enclosing scrollable area.

2011-06-30 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

More ScrollableArea scaffolding
https://bugs.webkit.org/show_bug.cgi?id=63678

Add a way to get the enclosing scrollable area for a given scrollable area.
Also, add ScrollableArea::isPinnedInDirectionOfScrollDelta.

  • page/FrameView.cpp: (WebCore::FrameView::enclosingScrollableArea): Return 0 for now.
  • page/FrameView.h: Add FrameView::enclosingScrollableArea.
  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::isPinnedInDirectionOfScrollDelta): Return whether the area is pinned in the direction of the scroll delta.
  • platform/ScrollableArea.h: Add new member functions.
  • platform/chromium/FramelessScrollView.cpp: (WebCore::FramelessScrollView::enclosingScrollableArea):
  • platform/chromium/FramelessScrollView.h: Add stub.
  • platform/win/PopupMenuWin.h: (WebCore::PopupMenuWin::enclosingScrollableArea): Always return 0.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::enclosingScrollableLayer): Add helper function.

(WebCore::RenderLayer::scrollByRecursively):
Use the new enclosingScrollableLayer helper function.

(WebCore::RenderLayer::enclosingScrollableArea):
Return the enclosing scrollable area.

  • rendering/RenderLayer.h: Add new member function.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::enclosingScrollableArea): Return 0 for now.


  • rendering/RenderListBox.h: Add new member function.
12:34 PM Changeset in webkit [90151] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename should_kill_dump_render_tree to driver_needs_restart in preparation for supporting WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=63743

  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
12:32 PM Changeset in webkit [90150] by Martin Robinson
  • 7 edits
    4 adds in releases/WebKitGTK/webkit-1.4

Merging r90148

12:31 PM Changeset in webkit [90149] by Martin Robinson
  • 6 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r90041

12:31 PM Changeset in webkit [90148] by Martin Robinson
  • 7 edits
    4 adds in trunk

2011-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] Crash observed with nspluginwrapper and flash
https://bugs.webkit.org/show_bug.cgi?id=62249

Added a test which verifies that WebKit does not crash when InvalidateRect
is called with a null instance.

  • platform/gtk/plugins/invalidate-rect-with-null-npp-argument-expected.txt: Added.
  • platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html: Added.

2011-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] Crash observed with nspluginwrapper and flash
https://bugs.webkit.org/show_bug.cgi?id=62249

Test: plugins/invalidate-rect-with-null-npp-argument.html

  • plugins/npapi.cpp: (NPN_InvalidateRect): Guard against null instances here.

2011-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] Crash observed with nspluginwrapper and flash
https://bugs.webkit.org/show_bug.cgi?id=62249

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_InvalidateRect): Guard against null instances here.

2011-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Anders Carlsson.

[GTK] Crash observed with nspluginwrapper and flash
https://bugs.webkit.org/show_bug.cgi?id=62249

Added a TestNetscapePlugin test which verifies that WebKit properly
handles situations where InvalidateRect is called with a null instance.

  • DumpRenderTree/TestNetscapePlugIn/Tests/x11/CallInvalidateRectWithNullNPPArgument.cpp: Added. (CallInvalidateRectWithNullNPPArgument::CallInvalidateRectWithNullNPPArgument): (CallInvalidateRectWithNullNPPArgument::NPP_New):
  • GNUmakefile.am: Add the new file to sources list.
12:26 PM Changeset in webkit [90147] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r89265

12:25 PM Changeset in webkit [90146] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r89319

12:18 PM Changeset in webkit [90145] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging r84022

12:16 PM Changeset in webkit [90144] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-30 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch availableWidth/Height, logicalLeft/RightOffsetForLine to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63671

Switch availableWidth/Height, logicalLeft/RightOffsetForLine functions over to the
new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::logicalLeftOffsetForLine): (WebCore::RenderBlock::logicalRightOffsetForLine): (WebCore::RenderBlock::availableLogicalWidthForLine): (WebCore::RenderBlock::availableLogicalWidth):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::logicalRightOffsetForLine): (WebCore::RenderBlock::logicalLeftOffsetForLine): (WebCore::RenderBlock::startOffsetForLine):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::availableLogicalHeight): (WebCore::RenderBox::availableLogicalHeightUsing):
  • rendering/RenderBox.h: (WebCore::RenderBox::availableLogicalWidth): (WebCore::RenderBox::availableWidth): (WebCore::RenderBox::availableHeight):
12:16 PM Changeset in webkit [90143] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/JavaScriptCore

Merging r83107

12:15 PM Changeset in webkit [90142] by Martin Robinson
  • 15 edits in releases/WebKitGTK/webkit-1.4/Source

Merging r81904

12:07 PM Changeset in webkit [90141] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Adam Barth <abarth@webkit.org>

Remove useless ASSERT that breaks the build.

  • dom/StyledElement.cpp: (WebCore::parseColorStringWithCrazyLegacyRules):
11:56 AM Changeset in webkit [90140] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove redundant tests in TestFailuresTest
https://bugs.webkit.org/show_bug.cgi?id=63742

These tests are all already covered by TestFailuresTest.test_loads.
I also added the missing "T" from TestFailuresest. :)

  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
11:41 AM Changeset in webkit [90139] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-30 Tab Atkins <jackalmage@gmail.com>

Reviewed by Adam Barth.

Fix legacy color attribute parsing to match HTML spec
https://bugs.webkit.org/show_bug.cgi?id=63029

Tests <body bgcolor> parsing.

  • fast/dom/attribute-legacy-colors-expected.txt: Added.
  • fast/dom/attribute-legacy-colors.html: Added.
  • fast/dom/script-tests/attribute-legacy-colors.js: Added.

2011-06-30 Tab Atkins <jackalmage@gmail.com>

Reviewed by Adam Barth.

Fix legacy color attribute parsing to match HTML spec
https://bugs.webkit.org/show_bug.cgi?id=63029

Relevant spec link: http://www.whatwg.org/specs/web-apps/current-work/complete/common-microsyntaxes.html#rules-for-parsing-a-legacy-color-value
Fix legacy color attribute parsing (<body bgcolor>, <font color>, etc.) to match the HTML spec and more closely match other browsers.

Test: fast/dom/attribute-legacy-colors.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
11:37 AM Changeset in webkit [90138] by abarth@webkit.org
  • 12 edits in trunk/Tools

2011-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r84294): new-run-webkit-tests results.html generate links to diffs.html or diff.png that don't exist
https://bugs.webkit.org/show_bug.cgi?id=63494

This patch does two things:

1) Refactor diff_image to return the image diff instead of writing the
diff to a file. This fixes a bunch of hacks and disentangles a bunch
of code.

2) When there's a checksum mismatch but not image diff, we no longer
report an IMAGE failure to results.html. That fixes the bug in
question because results.html won't try to link to a non-existent image
diff.

  • Scripts/webkitpy/common/system/executive_mock.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
11:32 AM Changeset in webkit [90137] by hans@chromium.org
  • 9 edits in trunk

2011-06-28 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Prepare for running layout tests with LevelDB
https://bugs.webkit.org/show_bug.cgi?id=63593

Migration of data from SQLite to LevelDB must be done before the
m_backingStore map is checked for an open LevelDB, because if a
previous layout test has used LevelDB, it will be in the
m_backingStore map.

Covered by existing layout tests.

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):

2011-06-28 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Prepare for running layout tests with LevelDB
https://bugs.webkit.org/show_bug.cgi?id=63593

WebIDBFactory should decide what DefaultBackingStore means.
Also fix handling of layout test and incognito mode properly.

  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):

2011-06-28 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Prepare for running layout tests with LevelDB
https://bugs.webkit.org/show_bug.cgi?id=63593

The TestShell must always provide a temporary folder for LevelDB,
not just when the backing store type is overridden.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setOverrideIndexedDBBackingStore): (LayoutTestController::clearAllDatabases):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/TestShell.h:
11:22 AM Changeset in webkit [90136] by pfeldman@chromium.org
  • 5 edits
    1 add in trunk/Source/WebCore

2011-06-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: introduce "filter" icons for timeline panel and elements sidebar.
https://bugs.webkit.org/show_bug.cgi?id=63731

  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/Images/paneFilterButtons.png: Added.
  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/inspector.css: (.pane > .title > select): (.pane > .title > select.select-settings): (.pane > .title > select.select-filter): (.timeline-filter-status-bar-item .glyph):
11:16 AM Changeset in webkit [90135] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-28 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Chang.

IndexedDB: Support for deleteIndex with LevelDB backing store
https://bugs.webkit.org/show_bug.cgi?id=63539

Covered by storage/indexeddb/mozilla/remove-index.html.

  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::deleteIndex):
10:57 AM Changeset in webkit [90134] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2011-06-30 Nate Chapin <Nate Chapin>

Unreviewed, remove passing tests from chromium test expectations.

  • platform/chromium/test_expectations.txt:
10:38 AM Changeset in webkit [90133] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Reinstate WKSecurityOriginGetHost and WKSecurityOriginGetProtocol as wrappers around the correctly-named functions.

Reviewed by Anders Carlsson.

They're needed for ABI compatibility.

  • Shared/API/c/WKSecurityOrigin.cpp:

(WKSecurityOriginGetHost):
(WKSecurityOriginGetProtocol):

10:24 AM Changeset in webkit [90132] by abarth@webkit.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Expanding lines "below" does not remove purple context line
https://bugs.webkit.org/show_bug.cgi?id=63695

Honestly, this is the last bug in the review tool that bothers me.

  • PrettyPatch/PrettyPatch.rb:
    • Jump straight to version 42, because, well, you know.
  • code-review.js:
    • In addition to removing the context bar when we expand all, we now remove it when we expand below (but not when we expand above).
10:04 AM Changeset in webkit [90131] by mrowe@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

ANGLE shouldn't try to use internal SDKs. It doesn't need them!

Rubber-stamped by Dan Bernstein.

  • Configurations/Base.xcconfig:
10:00 AM Changeset in webkit [90130] by inferno@chromium.org
  • 4 edits
    4 adds in trunk

2011-06-30 Abhishek Arya <inferno@chromium.org>

Reviewed by Ryosuke Niwa.

Crash when calling DOMSubtreeModified event when extracting range
contents.
https://bugs.webkit.org/show_bug.cgi?id=63650

Convert a few nodes to RefPtrs and add commonRoot verification checks
for Range::processContents.

Tests: fast/dom/Range/range-extract-contents-event-fire-crash.html

fast/dom/Range/range-extract-contents-event-fire-crash2.html

  • dom/Range.cpp: (WebCore::childOfCommonRootBeforeOffset): (WebCore::Range::processContents): (WebCore::Range::processContentsBetweenOffsets): (WebCore::Range::processAncestorsAndTheirSiblings):

2011-06-29 Abhishek Arya <inferno@chromium.org>

Reviewed by Ryosuke Niwa.

Crash when calling DOMSubtreeModified event when extracting range
contents.
https://bugs.webkit.org/show_bug.cgi?id=63650

  • fast/dom/Range/range-extract-contents-event-fire-crash-expected.txt: Added.
  • fast/dom/Range/range-extract-contents-event-fire-crash.html: Added.
  • fast/dom/Range/range-extract-contents-event-fire-crash2-expected.txt: Added.
  • fast/dom/Range/range-extract-contents-event-fire-crash2.html: Added.
  • fast/dom/Range/range-extractContents.html: remove the appending of fragment in this crasher test since we now refptr the nodes and leftContents will be visible. This crasher test does not need to show the extractContents fragment.
9:53 AM Changeset in webkit [90129] by mitz@apple.com
  • 7 edits in trunk/Source

Add +[WebView _allowsRoundingHacks]
https://bugs.webkit.org/show_bug.cgi?id=63734

Reviewed by Adele Peterson.

Source/WebCore:

  • WebCore.exp.in: Export TextRun::allowsRoundingHacks().
  • platform/graphics/TextRun.cpp:

(WebCore::TextRun::allowsRoundingHacks): Added this accessor.

  • platform/graphics/TextRun.h:

Source/WebKit/mac:

  • WebView/WebView.mm:

(+[WebView _allowsRoundingHacks]): Added this accessor.

  • WebView/WebViewPrivate.h:
9:52 AM Changeset in webkit [90128] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2011-06-30 Nate Chapin <Nate Chapin>

Unreviewed, chromium test expectations update after r90101.

  • platform/chromium/test_expectations.txt:
9:48 AM Changeset in webkit [90127] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-06-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Don't redefine the keyboard codes
https://bugs.webkit.org/show_bug.cgi?id=63726

Only define the codes when undefined.
r64957 fixed this problem for COMPILER(MINGW) but not for OS(WINCE).

  • platform/WindowsKeyboardCodes.h:
9:39 AM Changeset in webkit [90126] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: hide "Enabled background events collection" option in context menu until the setting is persisted
https://bugs.webkit.org/show_bug.cgi?id=63708

The option has no much sense if it is not preserved between browser restarts.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu):
9:28 AM Changeset in webkit [90125] by Csaba Osztrogonác
  • 4 edits
    1 copy
    1 add in trunk

Tools: [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
qt-wk2, win-wk2, mac-wk2 use this common Skipped list too
https://bugs.webkit.org/show_bug.cgi?id=61785

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-30
Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:

LayoutTests: [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
Common Skipped list copied from LayoutTests/platform/mac-wk2/Skipped.
https://bugs.webkit.org/show_bug.cgi?id=61785

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-30
Reviewed by Csaba Osztrogonác.

  • platform/mac-wk2/Skipped:
  • platform/wk2/Skipped: Copied from LayoutTests/platform/mac-wk2/Skipped.
9:05 AM Changeset in webkit [90124] by Patrick Gansterer
  • 26 edits in trunk/Source/WebCore

2011-06-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Remove dependnecy on IDL generation for disabled features in JSC bindings
https://bugs.webkit.org/show_bug.cgi?id=63718

Move the #if ENABLE() line directly after #include "config.h".
This enables us to compile all files even when we don't generate the IDL output.

  • bindings/js/IDBBindingUtilities.cpp:
  • bindings/js/JSConsoleCustom.cpp:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSDOMApplicationCacheCustom.cpp:
  • bindings/js/JSDeviceMotionEventCustom.cpp:
  • bindings/js/JSDeviceOrientationEventCustom.cpp:
  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/js/JSInjectedScriptManager.cpp:
  • bindings/js/JSInspectorFrontendHostCustom.cpp:
  • bindings/js/JSJavaScriptCallFrameCustom.cpp:
  • bindings/js/JSSQLResultSetRowListCustom.cpp:
  • bindings/js/JSSQLTransactionCustom.cpp:
  • bindings/js/JSSQLTransactionSyncCustom.cpp:
  • bindings/js/JSSVGElementInstanceCustom.cpp:
  • bindings/js/JSStorageCustom.cpp:
  • bindings/js/JSTouchCustom.cpp:
  • bindings/js/JSTouchListCustom.cpp:
  • bindings/js/JSXPathResultCustom.cpp:
  • bindings/js/JavaScriptCallFrame.cpp:
  • bindings/js/PageScriptDebugServer.cpp:
  • bindings/js/ScriptDebugServer.cpp:
  • bindings/js/ScriptGCEvent.cpp:
  • bindings/js/ScriptProfile.cpp:
  • bindings/js/WorkerScriptDebugServer.cpp:
8:30 AM Changeset in webkit [90123] by Adam Roben
  • 2 edits in trunk/Tools

Use a colon to separate test names from failure info on TestFailures

This matches how the "Possibly Flaky Tests" list works, and is much prettier when the
failure info itself includes parentheses.

Fixes <http://webkit.org/b/63722> Crashing symbols on TestFailures page look ugly due to
double parentheses

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForFailedTest): Use a colon instead of surrounding the failure
info in parentheses.

8:30 AM Changeset in webkit [90122] by Adam Roben
  • 2 edits in trunk/Tools

Robustify PersistentCache against cached data that contains the string ': '

Fixes <http://webkit.org/b/63721> Exceptions thrown while loading TestFailures page due to
passing a bad string to JSON.parse

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js:

(PersistentCache._parseDateAndJSONFromString): Manually split the string on the separator
using indexOf and substring. (String.prototype.split always splits on all instances of the
separator.)

8:30 AM Changeset in webkit [90121] by Adam Roben
  • 4 edits in trunk/Tools

Include the crashing symbol in crash logs links on TestFailures

Fixes <http://webkit.org/b/63465> Links to crash logs on TestFailures page should include
the crashing symbol (like links in results.html do)

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version because we now store
crashing symbols for crashing tests. Renamed testsForResultTable to parseResultTable because
it now returns more than just the test names. Specifically, it now looks for crash log links
and extracts the crashing symbol name from them. Updated callers of parseResultTable to
match its new behavior. Changed to store the crashing symbol along with the failure type in
the data we pass to the callback for tests which crashed.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(code): Make <code> elements a little smaller because their contents can be quite long.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForFailureDiagnosis): Include the crashing symbol inside a
<code> element in the link, if there is a crashing symbol.

8:30 AM Changeset in webkit [90120] by Adam Roben
  • 5 edits in trunk/Tools

Use objects instead of strings to represent a test result in TestFailures code

This will eventually allow us to store more than just the type of failure for each test.
(E.g., we can store the name of the crashing symbol for tests which crashed.)

Prep work for <http://webkit.org/b/63465> Links to crash logs on TestFailures page should
include the crashing symbol (like links in results.html do)

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.failureDiagnosisTextAndURL): Changed to expect a testResult object
instead of just a failureType string.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:

(FlakyLayoutTestDetector.prototype.incorporateTestResults): Changed to store a
testResult-like object for passing tests.
(FlakyLayoutTestDetector.prototype.flakinessExamples): Changed to expect testResult-like
objects.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Store a version number along with the cached data
so we can throw away cached data that's in an old format. Store a testResult object for each
test instead of just its failure type.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForFailedTest):
(ViewController.prototype._domForFailureDiagnosis):
Changed to expect testResult objects instead of failureType strings.

7:45 AM Changeset in webkit [90119] by apavlov@chromium.org
  • 5 edits in trunk/Source

2011-06-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Autofill suggestions appear in upper left corner after input change
https://bugs.webkit.org/show_bug.cgi?id=63702

This change fixes a few popup layout issues, some of which have existed for quite a while:

  • the absence of the ChromeClientImpl::screenToWindow() implementation (the method used to always return (0, 0));
  • the confusion of window and screen coordinates passed into the autofill popup client's setWindowRect() method;
  • the use of the current frameRect() width as the target element's width (which was wrong when refreshing a popup resized during the initial layout (e.g. made wider than the target element)).

No new tests, as this is a change to platform-specific widget code. The test case is provided in the bug description.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndGetRTLOffset): Use original target element width, not frameRect().width(), since the latter gets updated if the popup is not the same width as the target element. (WebCore::PopupContainer::refresh): Restore only the popup bounds rather than its original rectangle, since it sometimes breaks the invalidation region and layout.

2011-06-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Autofill suggestions appear in upper left corner after input change
https://bugs.webkit.org/show_bug.cgi?id=63702

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::screenToWindow): Implemented.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::refreshAutoFillPopup): Pass screen (not window) coordinates into setWindowRect().
7:30 AM Changeset in webkit [90118] by Adam Roben
  • 3 edits in trunk/Tools

Show full commit logs when visiting Trac from TestFailures page

Fixes <http://webkit.org/b/63715> Links to Trac on TestFailures page
should show full commit logs

Reviewed by David Kilzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:

(Trac.prototype.logURL): Added new 'showFullCommitLogs' parameter. When specified, we add
verbose=on to the log URL to tell Trac to show full commit logs.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForRegressionRange): Specify true for showFullCommitLogs.

7:11 AM Changeset in webkit [90117] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-06-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90102.
http://trac.webkit.org/changeset/90102
https://bugs.webkit.org/show_bug.cgi?id=63714

Lots of tests asserting beneath
SVGSMILElement::findInstanceTime (Requested by aroben on
#webkit).

  • wtf/StdLibExtras.h: (WTF::binarySearch):

2011-06-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90102.
http://trac.webkit.org/changeset/90102
https://bugs.webkit.org/show_bug.cgi?id=63714

Lots of tests asserting beneath
SVGSMILElement::findInstanceTime (Requested by aroben on
#webkit).

  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::findInstanceTime):
7:03 AM Changeset in webkit [90116] by caseq@chromium.org
  • 1 edit
    1 delete in trunk/Source/WebCore

2011-06-30 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove ExtensionAPISchema.json
https://bugs.webkit.org/show_bug.cgi?id=63687

  • inspector/front-end/ExtensionAPISchema.json: Removed.
7:00 AM Changeset in webkit [90115] by Adam Roben
  • 3 edits in trunk/Tools

Add a link to file a bug about TestFailures to the TestFailures page

Fixes <http://webkit.org/b/63466> TestFailures page should include a link to file a bug
about TestFailures itself

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

(aside): Added some styles for the new link. It is positioned in the upper-right and
hopefully not to glaringly obvious.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype.loaded): Set up our main content element and auxiliary UI.

(ViewController.prototype._displayBuilder):
(ViewController.prototype._displayTesters):
Modify the main content element instead of the entire body, as there are other things in the
body that we want to preserve.

(ViewController.prototype._domForAuxiliaryUIElements): Create and return an <aside> element
that contains a link to file a bug about the TestFailures page.

7:00 AM Changeset in webkit [90114] by Adam Roben
  • 3 edits in trunk/Tools

Ignore callbacks that correspond to old navigations of the TestFailures page

Fixes <http://webkit.org/b/63711> TestFailures page sometimes ignores back/forward
navigations

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer.prototype.start): Check the return value of the callback. If the
callback returns false, stop fetching more data.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController): Initialize new _navigationID member. This member is used to assign each
navigation by the user a unique ID.
(ViewController.prototype.parseHash): Increment the navigation ID.

(ViewController.prototype._displayBuilder):
(ViewController.prototype._displayTesters):
At the start of these functions, record the current navigation ID. Bail out from callbacks
if the navigation ID has changed, indicating that the user has navigated elsewhere.

6:59 AM Changeset in webkit [90113] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-30 Fabrizio Machado <fabrizio.machado@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] QML Webview causes performance drops
https://bugs.webkit.org/show_bug.cgi?id=57554

Remove tiledBackingStoreEnabled from QML WebView.

  • declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::setPage):
6:43 AM Changeset in webkit [90112] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for chromium.

  • inspector/CodeGeneratorInspector.pm:
6:38 AM Changeset in webkit [90111] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for mac.

  • inspector/CodeGeneratorInspector.pm:
6:22 AM Changeset in webkit [90110] by loislo@chromium.org
  • 6 edits in trunk

2011-06-30 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Protocol: error object needs some improvement.
https://bugs.webkit.org/show_bug.cgi?id=63707

Current implementation is not useful in the code.
We need to have toString implementation with nice formatting
I'd like to use error.message property as the main place for the error's text.

  • inspector/elements/set-attribute.html:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2011-06-30 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Protocol: error object needs some improvement.
https://bugs.webkit.org/show_bug.cgi?id=63707

Current implementation is not useful in the code.
We need to have toString implementation with nice formatting
I'd like to use error.message property as the main place for the error's text.

  • inspector/CodeGeneratorInspector.pm:
6:02 AM Changeset in webkit [90109] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

2011-06-30 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add back/forward menu to MiniBrowser toolbar
https://bugs.webkit.org/show_bug.cgi?id=63445

  • MiniBrowser/gtk/BrowserWindow.c: (browser_window_init): Use a GtkMenuToolButton for navigation widgets. (browserWindowConstructed): Get the page BackForwardList. (browserWindowHistoryItemActivated): Go to activated history item. (browserWindowHistoryItemSelected): Show the url of currently selected history item in the statusbar. (createGtkActionFromBackForwardItem): Create a GtkAction from a WKBackForwardListItemRef. (browserWindowCreateMenuItemFromBackForwardItem): Create a GtkMenuItem from a WKBackForwardListItemRef. (browserWindowCreateBackForwardMenu): Create a GtkMenu with the given history items. (browserWindowUpdateNavigationActions): Update navigation widgets sensitivity and history menus. (didChangeBackForwardList): Call browserWindowUpdateNavigationActions(). (browserWindowLoaderClientInit): Add didChangeBackForwardList callback.
5:55 AM Changeset in webkit [90108] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-30 Dmitry Lomov <dslomov@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=63660
This enables unit-tests step on Windows and MacOS SnowLeopard.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
5:10 AM Changeset in webkit [90107] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-30 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Support annotations for arrays in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=63690

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
4:41 AM Changeset in webkit [90106] by Patrick Gansterer
  • 6 edits in trunk/Source/WebCore

2011-06-30 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r88663, r89187, r89220, r89431 and r89661.

  • svg/SVGAnimatedAngle.h:
  • svg/SVGAnimatedLength.h:
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedRect.h:
  • svg/SVGAnimatedString.h:
4:19 AM Changeset in webkit [90105] by loki@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-30 Gabor Loki <loki@webkit.org>

Reviewed by Csaba Osztrogonác.

Fixed several style and typo issues after r90091.
https://bugs.webkit.org/show_bug.cgi?id=63692

Rename yStart to extremaStartY during computing extremas

  • platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::platformApplyGeneric):
  • platform/graphics/filters/FEMorphology.h:
4:08 AM Changeset in webkit [90104] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip a failing media test on GTK because of
https://bugs.webkit.org/show_bug.cgi?id=63699

  • platform/gtk/Skipped: skip media/media-blocked-by-willsendrequest.html
4:00 AM Changeset in webkit [90103] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[Chromium] Resolve a conflict.

  • platform/chromium/test_expectations.txt:
3:56 AM Changeset in webkit [90102] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-06-30 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025

Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.

  • wtf/StdLibExtras.h: (WTF::binarySearch):

2011-06-30 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025

Replace the linear search to binary search on ordered list because
the previous searches from the beginning was not efficient.

No new tests this is only a performance tweak.

  • svg/animation/SVGSMILElement.cpp: (WebCore::extractTimeFromVector): (WebCore::SVGSMILElement::findInstanceTime):
3:40 AM Changeset in webkit [90101] by commit-queue@webkit.org
  • 31 edits
    2 adds in trunk

2011-06-30 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Change the label of an HTML5 file chooser button to "Choose Files"
https://bugs.webkit.org/show_bug.cgi?id=49245

We should notify capability of multiple files to users.
input-file-label.html is a test that checks a label of the file chooser
with/without 'multiple' attribute. input-file-label.html will fail in Chromium
until a planned Chromium patch is landed. input-file-re-render.html will
also fail in Chromium, gtk and MacLeopard until we update the expected images
for the test.

  • fast/forms/input-file-label-expected.txt: Added.
  • fast/forms/input-file-label.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/input-file-re-render-expected.png:
  • platform/mac/fast/forms/input-file-re-render-expected.txt:

2011-06-30 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Change the label of an HTML5 file chooser button to "Choose Files"
https://bugs.webkit.org/show_bug.cgi?id=49245

We should notify capability of multiple files to users.

Test: fast/forms/input-file-label.html

  • English.lproj/Localizable.strings:
  • html/FileInputType.cpp: (WebCore::UploadButtonElement::createForMultiple): Constructs a multiple file chooser button. (WebCore::FileInputType::createShadowSubtree): Constructs a single/multiple file chooser button depending on 'multiple' attribute. (WebCore::FileInputType::multipleAttributeChanged): Updates the label of the file chooser button.
  • html/FileInputType.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Updates the shadow tree of the file chooser button when 'multiple' attribute is set or unset.
  • html/InputType.cpp: (WebCore::InputType::multipleAttributeChanged): Virtual method to be overridden by FileInputType.
  • html/InputType.h:
  • platform/DefaultLocalizationStrategy.cpp: (WebCore::DefaultLocalizationStrategy::fileButtonChooseFileLabel): Updated the description for "Choose File". (WebCore::DefaultLocalizationStrategy::fileButtonChooseMultipleFilesLabel): Returns a string "Choose Files".
  • platform/DefaultLocalizationStrategy.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Wrapper method for getting the "Choose Files" label.
  • platform/LocalizedStrings.h:
  • platform/brew/LocalizedStringsBrew.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
  • platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.

2011-06-30 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Change the label of an HTML5 file chooser button to "Choose Files"
https://bugs.webkit.org/show_bug.cgi?id=49245

We should notify capability of multiple files to users.

Test: fast/forms/input-file-label.html

  • DEPS:
  • public/WebLocalizedString.h: Depends on chromium_rev>=91051.
  • src/LocalizedStrings.cpp: (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.

2011-06-30 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Change the label of an HTML5 file chooser button to "Choose Files"
https://bugs.webkit.org/show_bug.cgi?id=49245

We should notify capability of multiple files to users.

Test: fast/forms/input-file-label.html

  • WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::fileButtonChooseFileLabel): Updated the description for "Choose File". (WebPlatformStrategies::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
  • WebCoreSupport/WebPlatformStrategies.h:

2011-06-30 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Change the label of an HTML5 file chooser button to "Choose Files"
https://bugs.webkit.org/show_bug.cgi?id=49245

We should notify capability of multiple files to users.

Test: fast/forms/input-file-label.html

  • WebCoreSupport/PlatformStrategiesWinCE.cpp: (PlatformStrategiesWinCE::fileButtonChooseFileLabel): Updated the description for "Choose File". (PlatformStrategiesWinCE::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
  • WebCoreSupport/PlatformStrategiesWinCE.h:
2:31 AM Changeset in webkit [90100] by yutak@chromium.org
  • 32 edits
    32 deletes in trunk/LayoutTests

2011-06-30 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Don't use script-tests for WebSocket tests
https://bugs.webkit.org/show_bug.cgi?id=63691

Move content of script-tests/XXX.js into XXX.html.

No changes were made to script code. Hence, these tests are not using
window.jsTestAsync and finishJSTest() for now. I will fix this later.

  • http/tests/websocket/tests/alert-in-event-handler.html:
  • http/tests/websocket/tests/bad-handshake-crash.html:
  • http/tests/websocket/tests/bad-sub-protocol-control-chars.html:
  • http/tests/websocket/tests/bad-sub-protocol-empty.html:
  • http/tests/websocket/tests/bad-sub-protocol-non-ascii.html:
  • http/tests/websocket/tests/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/cross-origin.html:
  • http/tests/websocket/tests/error-detect.html:
  • http/tests/websocket/tests/frame-length-longer-than-buffer.html:
  • http/tests/websocket/tests/frame-length-skip.html:
  • http/tests/websocket/tests/handshake-challenge-randomness.html:
  • http/tests/websocket/tests/handshake-error.html:
  • http/tests/websocket/tests/handshake-fail-by-cross-origin.html:
  • http/tests/websocket/tests/handshake-fail-by-no-cr.html:
  • http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html:
  • http/tests/websocket/tests/long-invalid-header.html:
  • http/tests/websocket/tests/null-character.html:
  • http/tests/websocket/tests/script-tests/TEMPLATE.html: Removed.
  • http/tests/websocket/tests/script-tests/alert-in-event-handler.js: Removed.
  • http/tests/websocket/tests/script-tests/bad-handshake-crash.js: Removed.
  • http/tests/websocket/tests/script-tests/bad-sub-protocol-control-chars.js: Removed.
  • http/tests/websocket/tests/script-tests/bad-sub-protocol-empty.js: Removed.
  • http/tests/websocket/tests/script-tests/bad-sub-protocol-non-ascii.js: Removed.
  • http/tests/websocket/tests/script-tests/bufferedAmount-after-close.js: Removed.
  • http/tests/websocket/tests/script-tests/cross-origin.js: Removed.
  • http/tests/websocket/tests/script-tests/error-detect.js: Removed.
  • http/tests/websocket/tests/script-tests/frame-length-longer-than-buffer.js: Removed.
  • http/tests/websocket/tests/script-tests/frame-length-skip.js: Removed.
  • http/tests/websocket/tests/script-tests/handshake-challenge-randomness.js: Removed.
  • http/tests/websocket/tests/script-tests/handshake-error.js: Removed.
  • http/tests/websocket/tests/script-tests/handshake-fail-by-cross-origin.js: Removed.
  • http/tests/websocket/tests/script-tests/handshake-fail-by-no-cr.js: Removed.
  • http/tests/websocket/tests/script-tests/handshake-fail-by-sub-protocol-mismatch.js: Removed.
  • http/tests/websocket/tests/script-tests/long-invalid-header.js: Removed.
  • http/tests/websocket/tests/script-tests/null-character.js: Removed.
  • http/tests/websocket/tests/script-tests/send-throw.js: Removed.
  • http/tests/websocket/tests/script-tests/send.js: Removed.
  • http/tests/websocket/tests/script-tests/simple.js: Removed.
  • http/tests/websocket/tests/script-tests/sub-protocol-with-space.js: Removed.
  • http/tests/websocket/tests/script-tests/sub-protocol.js: Removed.
  • http/tests/websocket/tests/script-tests/unicode.js: Removed.
  • http/tests/websocket/tests/script-tests/url-no-trailing-slash.js: Removed.
  • http/tests/websocket/tests/script-tests/url-parsing.js: Removed.
  • http/tests/websocket/tests/script-tests/url-with-credential.js: Removed.
  • http/tests/websocket/tests/script-tests/url-with-empty-query.js: Removed.
  • http/tests/websocket/tests/script-tests/url-with-query-for-no-query.js: Removed.
  • http/tests/websocket/tests/script-tests/url-with-query.js: Removed.
  • http/tests/websocket/tests/script-tests/websocket-event-target.js: Removed.
  • http/tests/websocket/tests/script-tests/websocket-protocol-ignored.js: Removed.
  • http/tests/websocket/tests/send-throw.html:
  • http/tests/websocket/tests/send.html:
  • http/tests/websocket/tests/simple.html:
  • http/tests/websocket/tests/sub-protocol-with-space.html:
  • http/tests/websocket/tests/sub-protocol.html:
  • http/tests/websocket/tests/unicode.html:
  • http/tests/websocket/tests/url-no-trailing-slash.html:
  • http/tests/websocket/tests/url-parsing.html:
  • http/tests/websocket/tests/url-with-credential.html:
  • http/tests/websocket/tests/url-with-empty-query.html:
  • http/tests/websocket/tests/url-with-query-for-no-query.html:
  • http/tests/websocket/tests/url-with-query.html:
  • http/tests/websocket/tests/websocket-event-target.html:
  • http/tests/websocket/tests/websocket-protocol-ignored.html:
2:22 AM Changeset in webkit [90099] by yutak@chromium.org
  • 18 edits in trunk/LayoutTests

2011-06-30 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Fix style issues of pywebsocket handlers
https://bugs.webkit.org/show_bug.cgi?id=63689

Fix minor style errors such as wrong indentation or wrong number of blank lines.

  • http/tests/websocket/tests/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/close-on-unload_wsh.py:
  • http/tests/websocket/tests/echo-challenge_wsh.py:
  • http/tests/websocket/tests/echo-cookie_wsh.py:
  • http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py:
  • http/tests/websocket/tests/frame-length-overflow_wsh.py:
  • http/tests/websocket/tests/frame-length-skip_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-maxlength_wsh.py: Use sequence repetition pattern instead of a loop.
  • http/tests/websocket/tests/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/handshake-fail-by-prepended-null_wsh.py:
  • http/tests/websocket/tests/hanging-handshake_wsh.py:
  • http/tests/websocket/tests/long-invalid-header_wsh.py:
  • http/tests/websocket/tests/send2_wsh.py:
  • http/tests/websocket/tests/unknown-frame-type_wsh.py:
  • http/tests/websocket/tests/workers/resources/echo-challenge_wsh.py:
2:14 AM Changeset in webkit [90098] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-06-30 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Replace isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Position&)
https://bugs.webkit.org/show_bug.cgi?id=63672

Replaced isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Position&).
Also added a safe toTextFormControl to HTMLFormControlElement.h.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Calls enclosingTextFormControl instead of manually checking the tag name of shadowAncestorNode.
  • editing/Editor.cpp: (WebCore::Editor::selectionForCommand): Rewritten using enclosingTextFormControl and toTextFormControl. (WebCore::Editor::cut): Calls enclosingTextFormControl instead of isNodeInTextFormControl. (WebCore::Editor::copy): Ditto. (WebCore::Editor::setBaseWritingDirection): Calls toTextFormControl instead of manually checking tag name.
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::isInPasswordField): Calls enclosingTextFormControl.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Ditto.
  • editing/htmlediting.cpp: (WebCore::enclosingTextFormControl): Added.
  • editing/htmlediting.h:
  • html/HTMLFormControlElement.h: (WebCore::toTextFormControl): Added.
  • page/DragController.cpp: (WebCore::DragController::startDrag): Calls enclosingTextFormControl instead of isNodeInTextFormControl.
2:08 AM Changeset in webkit [90097] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[Mac-wk2] Update expectation files for r90089.
https://bugs.webkit.org/show_bug.cgi?id=61415

  • platform/mac-wk2/fast/forms/textfield-overflow-expected.txt:
1:18 AM Changeset in webkit [90096] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: source code is not highlighted after drawer height animations.
https://bugs.webkit.org/show_bug.cgi?id=62860

  • inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): (WebInspector.Drawer.prototype._animateDrawerHeight):
1:00 AM Changeset in webkit [90095] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

2011-06-30 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Implement the rest of WTR::PlatformWebView
https://bugs.webkit.org/show_bug.cgi?id=63630

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::windowFrame): (WTR::PlatformWebView::setWindowFrame):
12:43 AM Changeset in webkit [90094] by morrita@google.com
  • 11 edits
    2 adds in trunk

2011-06-30 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Crash if ShadowRoot has a text node.
https://bugs.webkit.org/show_bug.cgi?id=63607

  • fast/dom/shadow/shadow-root-text-child-expected.txt: Added.
  • fast/dom/shadow/shadow-root-text-child.html: Added.

2011-06-30 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Crash if ShadowRoot has a text node.
https://bugs.webkit.org/show_bug.cgi?id=63607

Node::styleForRenderer() for Text node wasn't shadow-aware.
This change allow styleForRenderer() to know its visual parent by
passing NodeRenderingContext.

Changes other than NodeRenderingContext and Element is just a
follow up for change above.

  • dom/Element.cpp: use NodeRenderingContext to resolve parent node. (WebCore::Element::recalcStyle):
  • dom/Node.cpp: (WebCore::Node::styleForRenderer): Added NodeRenderingContext as a parameter.
  • dom/Node.h:
  • dom/NodeRenderingContext.cpp: (WebCore::NodeRendererFactory::createRendererAndStyle):
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::attach):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attach):
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::textWithDirection):
  • html/shadow/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::styleForRenderer): (WebCore::TextControlInnerTextElement::styleForRenderer):
  • html/shadow/TextControlInnerElements.h:

Test: fast/dom/shadow/shadow-root-text-child.html

12:42 AM Changeset in webkit [90093] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

2011-06-30 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

generate-webkitversion.pl should not "use Switch"
https://bugs.webkit.org/show_bug.cgi?id=63628

Switch got deprecated on recent Perl versions and the script wasn't
using the switch statement.

  • scripts/generate-webkitversion.pl: Remove "use Switch;" line.
12:42 AM Changeset in webkit [90092] by tkent@chromium.org
  • 30 edits in trunk/LayoutTests

2011-06-30 Kent Tamura <tkent@chromium.org>

[GTK][Mac][Win] Update expectation files for r90089.

  • platform/gtk/fast/block/float/032-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/repaint/search-field-cancel-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/fast/block/float/032-expected.txt:
  • platform/win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/win/fast/forms/search-placeholder-value-changed-expected.txt:
12:20 AM Changeset in webkit [90091] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-30 Piroska András <Piroska.Andras@stud.u-szeged.hu>

Reviewed by Dirk Schulze.

Apply the ParallelJobs support to FEMorphology
https://bugs.webkit.org/show_bug.cgi?id=63064

The FEMorphology filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is 20-25% on dual-core machines.

  • platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::platformApplyGeneric): Apply the filter between yStart and yEnd interval (WebCore::FEMorphology::platformApplyWorker): Call the generic apply from a parallel worker (WebCore::FEMorphology::platformApply): (WebCore::FEMorphology::apply): Move the functionality into platformApply (WebCore::FEMorphology::externalRepresentation): Remove whitespaces
  • platform/graphics/filters/FEMorphology.h:
12:14 AM Changeset in webkit [90090] by Csaba Osztrogonác
  • 14 edits
    9 adds in trunk/LayoutTests

[Qt] Unreviewed. Update platform specific expected files after r90089.

  • platform/qt/fast/css/pseudo-cache-stale-expected.png: Added.
  • platform/qt/fast/css/pseudo-cache-stale-expected.txt:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/qt/fast/forms/control-restrict-line-height-expected.png:
  • platform/qt/fast/forms/control-restrict-line-height-expected.txt:
  • platform/qt/fast/forms/placeholder-set-value-expected.png: Added.
  • platform/qt/fast/forms/placeholder-set-value-expected.txt:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png: Added.
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.png: Added.
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/qt/fast/forms/search-placeholder-value-changed-expected.png: Added.
  • platform/qt/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.png: Added.
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.png: Added.
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.png:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:

Jun 29, 2011:

11:30 PM Changeset in webkit [90089] by tkent@chromium.org
  • 41 edits in trunk

2011-06-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Avoid custom layout code of RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=61415

Update tests including <input type=search> or <input type=number>. Their
internal structures are changed.
Slight position changes for search result buttons and search cancel
buttons are expected.

  • fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/css/input-search-padding-expected.png:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/pseudo-cache-stale-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-value-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.png:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:

2011-06-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Avoid custom layout code of RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=61415

If a text field has a search results button, a search cancel
button, a speech button, or a spin button, the editable inner text
element and the buttons are wrapped by a flexible box container,
and the editable inner text element has flexibility. As the result
of applying the flexible box, we don't need any horizontal layout
code in RenderTextControlSingleLine except the inner spin button.

Also, we remove custom hit-testing code in nodeAtPoint(). If a
user clicks on a position left of the inner editable text but not
on the search results button, the search results button doesn't
work though it worked.

  • css/html.css: (input::-webkit-textfield-decoration-container): New style definition for the "container" element. (input[type="search"]::-webkit-search-cancel-button): It should be a block element because it's a child of the flexible box. Also, this doesn't have flexibility. (input[type="search"]::-webkit-search-decoration): ditto. (input[type="search"]::-webkit-search-results-decoration): ditto. (input[type="search"]::-webkit-search-results-button): ditto. (input::-webkit-inner-spin-button): ditto. (input::-webkit-input-speech-button): ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::containerElement): Add an accessor of the flexible box container. It just calls InputType::containerElement().
  • html/HTMLInputElement.h: Declare it.
  • html/InputType.h: (WebCore::InputType::containerElement): New accessor for a shadow element.
  • html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): m_innerBlock is moved to TextFieldInputType. (WebCore::SearchInputType::needsContainer): A search field always needs the flexible box container because of the results button and the cancel button. (WebCore::SearchInputType::createShadowSubtree): Use TextFieldInputType::createShadowSubtree(), then modify the tree. (WebCore::SearchInputType::destroyShadowSubtree): m_innerBlock is moved to TextFieldInputType.
  • html/SearchInputType.h:
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): Initialize the new members. (WebCore::TextFieldInputType::needsContainer): Returns true if x-webkit-speech. We check a spin button separately. (WebCore::TextFieldInputType::createShadowSubtree): Wrap everything with the flexible box container if needsContainer() or we need a spin button. (WebCore::TextFieldInputType::containerElement): Added an accessor. (WebCore::TextFieldInputType::innerBlockElement): ditto. (WebCore::TextFieldInputType::innerTextElement): ditto. (WebCore::TextFieldInputType::innerSpinButtonElement): ditto. (WebCore::TextFieldInputType::speechButtonElement): ditto. (WebCore::TextFieldInputType::destroyShadowSubtree): Clear references to new shadow nodes.
  • html/TextFieldInputType.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::containerElement): Added an accessor. (WebCore::RenderTextControlSingleLine::innerTextElement): (WebCore::RenderTextControlSingleLine::layout):
    • Correct heights check Comparing with height(), not contentHeigth(), was incorrect.
    • Adjust the container height like the editable inner text.
    • Remove width adjustment
    • Remove the speech button layout code The flexible box layout is enough.

(WebCore::RenderTextControlSingleLine::nodeAtPoint):

Remove custom code for results/cancel/speech buttons, and
Simplify comments.

(WebCore::RenderTextControlSingleLine::forwardEvent):

Remove custom forwarding code for results/cancel buttons.

(WebCore::RenderTextControlSingleLine::styleDidChange):

Clear the style of the container because we update it in layout().

(WebCore::RenderTextControlSingleLine::hasControlClip):

Decoration buttons should be clipped by the container.

(WebCore::RenderTextControlSingleLine::controlClipRect): ditto.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

We don't need to use display:inline-block any more.

(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):

The text wrapper element should have flexibility.

(WebCore::RenderTextControlSingleLine::textBlockInsetTop):

Updated for the tree structure change.

  • rendering/RenderTextControlSingleLine.h:
10:39 PM Changeset in webkit [90088] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-29 Kent Tamura <tkent@chromium.org>

[Mac] Attempt to fix Leopard build.

  • platform/mac/CursorMac.mm: (WebCore::Cursor::ensurePlatformCursor):
10:12 PM Changeset in webkit [90087] by Darin Adler
  • 11 edits
    2 deletes in trunk/Source

2011-06-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

[Mac] Use system cursors instead of custom bitmaps where possible
https://bugs.webkit.org/show_bug.cgi?id=63679

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added WKCursor.

2011-06-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

[Mac] Use system cursors instead of custom bitmaps where possible
https://bugs.webkit.org/show_bug.cgi?id=63679

  • Resources/crossHairCursor.png: Removed.
  • Resources/notAllowedCursor.png: Removed.
  • WebCore.exp.in: Added wkCursor.
  • WebCore/WebCore.gyp/WebCore.gyp: Removed the two now-unused PNG files.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/mac/CursorMac.mm: (WebCore::Cursor::ensurePlatformCursor): Use NSCursor API for Cross, Hand, VerticalText, ContextMenu, Copy, and NotAllowed. Use wkCursor for Move, Alias, Progress, and the resize and panning cursors.
  • platform/mac/WebCoreSystemInterface.h: Added wkCursor.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

2011-06-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

[Mac] Use system cursors instead of custom bitmaps where possible
https://bugs.webkit.org/show_bug.cgi?id=63679

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added WKCursor.
9:16 PM Changeset in webkit [90086] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

test-webkitpy is spamming lots of messages about updating test expectations
https://bugs.webkit.org/show_bug.cgi?id=63680

This patch changes the passing_run() function to capture the
output to stdout and stderr and assert that it is empty, and
also specifies --no-new-test-results by default to avoid getting
"generating baseline" messages for the expected-missing results.

Also check that we are logging messages when we generate new
baselines.

Also fix a minor bug in the way test_tolerance() was
checking for whether the tests were passing or not.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
8:40 PM Changeset in webkit [90085] by yutak@chromium.org
  • 6 edits in trunk/Tools

2011-06-29 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

DRT: Make Hixie76WebSocketProtocolEnabled preference flag configurable from LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=63532

LayoutTestController::overridePreference() will be used to change the value of
the Hixie76WebSocketProtocolEnabled preference flag from layout tests. In this way,
we can avoid writing a lot of boilerplate code in each port's DumpRenderTree, but
at least we need to reset preference values in DumpRenderTree every time we start
a new test because preference values changed in some test should not be leaked
to the next test.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::overridePreference): The name of preference key is defined in WebKit/{mac/WebView,win}/WebPreferenceKeysPrivate.h.
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): Set the default value. This will be called from TestShell::resetTestController(). (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h:
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Set the default value.
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Ditto.
8:34 PM Changeset in webkit [90084] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2011-06-29 Simon Fraser <Simon Fraser>

Fix the test description.

  • fast/layers/negative-scroll-positions-expected.txt:
  • fast/layers/script-tests/negative-scroll-positions.js:
8:07 PM Changeset in webkit [90083] by bashi@chromium.org
  • 3 edits in trunk/Tools

2011-06-29 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Adam Barth.

check-webkit-style fails to detect https://webkit.org/b/XXXXX as a bug number
https://webkit.org/b/57360

Modify the regular expression to match https scheme.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py: Added a test case for https://webkit.org/b/XXXXX.
  • Scripts/webkitpy/common/config/urls.py: Modified bug_url_short to match https scheme.
8:05 PM Changeset in webkit [90082] by keishi@webkit.org
  • 6 edits
    3 adds in trunk

2011-06-29 Keishi Hattori <keishi@webkit.org>

Reviewed by Adam Barth.

Remove extra space at EOL in view source mode
https://bugs.webkit.org/show_bug.cgi?id=63620

  • fast/frames/resources/viewsource-frame-5.html: Added.
  • fast/frames/viewsource-empty-attribute-value-expected.txt: Regenerated.
  • fast/frames/viewsource-linebreak-expected.txt: Added.
  • fast/frames/viewsource-linebreak.html: Added. Test that there are no extra spaces at EOL. And that the multiple consecutive line breaks are maintained in the frame.

2011-06-29 Keishi Hattori <keishi@webkit.org>

Reviewed by Adam Barth.

Remove extra space at EOL in view source mode
https://bugs.webkit.org/show_bug.cgi?id=63620

Test: fast/frames/viewsource-linebreak.html

  • css/view-source.css: (tbody:last-child .webkit-line-content:empty:before): If we don't do this the last line will be empty and the height will be shorter than the rest.
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addSource): If source file is empty, add an empty line. (WebCore::HTMLViewSourceDocument::finishLine): Call when you are done with the current line. Adds a BR element if the line is empty and sets current to tbody. (WebCore::HTMLViewSourceDocument::addText):
  • html/HTMLViewSourceDocument.h:
7:30 PM Changeset in webkit [90081] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: images page switch actual and expected images before they're loaded
https://bugs.webkit.org/show_bug.cgi?id=63199

We now preload the images and keep the DOM nodes in memory instead of
going back to the MemoryCache all the time. (Also, remove some nutty
</img> HTML.)

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
7:06 PM Changeset in webkit [90080] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-06-29 Kangil Han <kangil.han@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add APIs to get/set view mode
https://bugs.webkit.org/show_bug.cgi?id=63229

Implement public API for getting/setting the view-mode media feature as specified in W3C.

  • ewk/ewk_view.cpp: (ewk_view_mode_set): (ewk_view_mode_get):
  • ewk/ewk_view.h:
7:02 PM Changeset in webkit [90079] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should tell you when it creates new expectations
https://bugs.webkit.org/show_bug.cgi?id=63675

Unforunately, this patch creates a bunch of test-webkitpy spam because
we don't understand how Python logging works well enough to stop the
spam. :(

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
6:48 PM Changeset in webkit [90078] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Refactor WebKitDriver.run_test into smaller pieces
https://bugs.webkit.org/show_bug.cgi?id=63673

There is no functional change here. Just moving code around.
This is in preparation for adding support for #CRASHED and #CRASHED - WebProcess

  • Scripts/webkitpy/layout_tests/port/webkit.py:
6:36 PM Changeset in webkit [90077] by eric@webkit.org
  • 15 edits in trunk/Tools

2011-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Simplify skipped file finding in preparation for adding wk2 skipped list fallback
https://bugs.webkit.org/show_bug.cgi?id=63501

Re-landing after fixing a bug in WebKitPort.baseline_search_path which broke
the rebaselineserver unit tests. Also fixed nits brought up by Dirk after previous landing.

The goal was to add support for wk2 skipped lists.
However, I found that our skipped list computation was a
manual hack (which only worked for the mac port).

So I fixed a FIXME to move the skipped list finding
into WebKitPort instead of MacPort.
Doing so required the concept of a "port_name", since previously
the only name accessible from a port object was name()
which includes many things beyond "mac" or "chromium", etc.

Eventually I believe we'll want to re-think the way that we pass
in a port_name argument to Port subclasses and expect them to parse
it. But for now I just added a cls.port_name variable which contains
the static information needed to compute wk2 names as well as
compute Skipped list fallback which works for Mac/Win/Qt and Gtk.

In order to test my new _skipped_file_search_paths method, I
fixed another FIXME by making it return relative paths.

I also fixed the test_expectations_path code in WebKitPort to use port_name.
It was using name() which would return PORT-VERSION so MacPort was overriding
it to use just PORT. After fixing test_expectations_path to use port_name
(and making it aware of webkit2) I was able to remove the MacPort implementation.

  • Scripts/webkitpy/layout_tests/port/base.py:
    • Add port_name() to access "mac", since name() returns "mac-leopard" etc.
    • Document that real_name() seems to have no purpose.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
    • Add _parse_port_name(), eventually we might call this from WebKitPort directly.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
    • Add _parse_port_name.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
    • Add _parse_port_name.
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
    • Move Skipped-file finding code down to WebKitPort
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
6:11 PM Changeset in webkit [90076] by commit-queue@webkit.org
  • 14 edits in trunk/Tools

2011-06-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r90070.
http://trac.webkit.org/changeset/90070
https://bugs.webkit.org/show_bug.cgi?id=63676

Broke test-webkitpy rebaseline tests (Requested by eseidel2 on
#webkit).

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
5:46 PM Changeset in webkit [90075] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebCore

[WinCE] Correct logical state of WINCE test.

  • platform/win/ScrollbarThemeWin.cpp: The #if OS(WINCE) should have been #if !OS(WINCE)

(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::ScrollbarThemeWin::paintThumb):

  • rendering/RenderThemeWin.cpp: ditto.

(WebCore::drawControl):

5:42 PM Changeset in webkit [90074] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-06-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests doesn't support sample-on-timeout
https://bugs.webkit.org/show_bug.cgi?id=56731

  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5:30 PM Changeset in webkit [90073] by justin.garcia@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-29 Justin Garcia <justin.garcia@apple.com>

Reviewed by Enrica Casucci.


I forgot to include these (reviewed) style fix-ups in my previous check-in.

  • editing/htmlediting.cpp: (WebCore::indexForVisiblePosition): (WebCore::visiblePositionForIndex):
5:10 PM Changeset in webkit [90072] by justin.garcia@apple.com
  • 6 edits in trunk/Source/WebCore

2011-06-29 Justin Garcia <justin.garcia@apple.com>

Reviewed by Enrica Casucci.

https://bugs.webkit.org/show_bug.cgi?id=62922
indexForVisiblePosition(const VisiblePosition& visiblePosition) does not consider shadow content


VisiblePositions can be inside web form text regions, which use shadow trees. Made indexForVisiblePosition
aware of this, and added a new parameter to obtain the scope for a VisiblePosition, in addition to its index.


Added visiblePositionForIndex to go in the opposite direction, taking into account the scope
used to compute the index.


These two functions use TextIterators to convert between VisiblePositions and indices. But
TextIterator iteration using TextIteratorEmitsCharactersBetweenAllVisiblePositions does not
exactly match VisiblePosition iteration, so using them to preserve a selection during an
editing operation is unreliable. This can be seen in the expected results for:


editing/execCommand/indent-pre-list.html
editing/execCommand/crash-indenting-list-item.html


TextIterator's TextIteratorEmitsCharactersBetweenAllVisiblePositions mode needs to be fixed, or
these functions need to be changed to iterate using actual VisiblePositions. See:


https://bugs.webkit.org/show_bug.cgi?id=63590
TextIterators in TextIteratorEmitsCharactersBetweenAllVisiblePositions do not exactly match VisiblePositions


Also:


https://bugs.webkit.org/show_bug.cgi?id=63592
Use visiblePositionForIndex and indexForVisiblePosition everywhere that TextIterators are used to convert between VisiblePositions and indices


No new tests added because indexForVisiblePosition is currently only used for editing operations
that cannot be performed inside web form fields.

  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::doApply):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::indexForVisiblePosition): (WebCore::visiblePositionForIndex):
  • editing/htmlediting.h:
5:03 PM Changeset in webkit [90071] by Dimitri Glazkov
  • 11 edits
    2 deletes in trunk/Source/WebCore

2011-06-29 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Remove ElementWithPseudoId, since now an Element can store it all by itself.
https://bugs.webkit.org/show_bug.cgi?id=63657

Refactoring, covered by existing tests.

  • CMakeLists.txt: Removed ElementWithPseudoId from build.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.order: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/ColorInputType.cpp: (WebCore::ColorInputType::createShadowSubtree): Changed to use plain-old HTMLDivElement.
  • html/RangeInputType.cpp: (WebCore::RangeInputType::createShadowSubtree): Ditto.
  • html/ValidationMessage.cpp: (WebCore::ValidationMessage::buildBubbleTree): Ditto.
  • html/shadow/ElementWithPseudoId.cpp: Removed.
  • html/shadow/ElementWithPseudoId.h: Removed.
5:02 PM Changeset in webkit [90070] by eric@webkit.org
  • 14 edits in trunk/Tools

2011-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Simplify skipped file finding in preparation for adding wk2 skipped list fallback
https://bugs.webkit.org/show_bug.cgi?id=63501

The goal was to add support for wk2 skipped lists.
However, I found that our skipped list computation was a
manual hack (which only worked for the mac port).

So I fixed a FIXME to move the skipped list finding
into WebKitPort instead of MacPort.
Doing so required the concept of a "port_name", since previously
the only name accessible from a port object was name()
which includes many things beyond "mac" or "chromium", etc.

Eventually I believe we'll want to re-think the way that we pass
in a port_name argument to Port subclasses and expect them to parse
it. But for now I just added a cls.port_name variable which contains
the static information needed to compute wk2 names as well as
compute Skipped list fallback which works for Mac/Win/Qt and Gtk.

In order to test my new _skipped_file_search_paths method, I
fixed another FIXME by making it return relative paths.

I also fixed the test_expectations_path code in WebKitPort to use port_name.
It was using name() which would return PORT-VERSION so MacPort was overriding
it to use just PORT. After fixing test_expectations_path to use port_name
(and making it aware of webkit2) I was able to remove the MacPort implementation.

  • Scripts/webkitpy/layout_tests/port/base.py:
    • Add port_name() to access "mac", since name() returns "mac-leopard" etc.
    • Document that real_name() seems to have no purpose.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
    • Add _parse_port_name(), eventually we might call this from WebKitPort directly.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
    • Add _parse_port_name.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
    • Add _parse_port_name.
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
    • Move Skipped-file finding code down to WebKitPort
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4:59 PM Changeset in webkit [90069] by leviw@chromium.org
  • 24 edits in trunk/Source/WebCore

2011-06-29 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch computeWidth and computeHeight functions to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63655

Switch computeWidth and computeHeight functions over to the new layout unit abstraction.

Making a point to mark rounding that should eventually be removed by linking to a new
tracking bug: 63645.

No new tests, no functionality changes.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::computePreferredLogicalWidths):
  • rendering/AutoTableLayout.h:
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::computePreferredLogicalWidths):
  • rendering/FixedTableLayout.h:
  • rendering/LayoutTypes.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::computePreferredLogicalWidths): (WebCore::RenderBlock::computeInlinePreferredLogicalWidths): (WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeLogicalWidthUsing): (WebCore::RenderBox::computeLogicalHeight): (WebCore::RenderBox::computeLogicalHeightUsing): (WebCore::RenderBox::computePercentageLogicalHeight): (WebCore::RenderBox::computeReplacedLogicalWidth): (WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth): (WebCore::RenderBox::computeReplacedLogicalWidthUsing): (WebCore::RenderBox::computeReplacedLogicalHeight): (WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight): (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
  • rendering/RenderBox.h:
  • rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::computeLogicalWidth):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::computeReplacedLogicalWidth): (WebCore::RenderImage::computeReplacedLogicalHeight):
  • rendering/RenderImage.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::computePreferredLogicalWidths):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::computePreferredLogicalWidths):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::computePreferredLogicalWidths):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeReplacedLogicalWidth): (WebCore::RenderReplaced::computeReplacedLogicalHeight): (WebCore::RenderReplaced::computePreferredLogicalWidths):
  • rendering/RenderReplaced.h:
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::computePreferredLogicalWidths):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::computeLogicalWidth):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::computePreferredLogicalWidths):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::computeReplacedLogicalWidth): (WebCore::RenderVideo::computeReplacedLogicalHeight):
  • rendering/RenderVideo.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::computeLogicalWidth): (WebCore::RenderSVGForeignObject::computeLogicalHeight):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computePreferredLogicalWidths): (WebCore::RenderSVGRoot::computeIntrinsicWidth): (WebCore::RenderSVGRoot::computeIntrinsicHeight): (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): (WebCore::RenderSVGRoot::layout):
  • rendering/svg/RenderSVGRoot.h:
4:58 PM Changeset in webkit [90068] by inferno@chromium.org
  • 6 edits
    4 adds in trunk

2011-06-23 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

In RenderBlock, RenderWidget and RenderReplaced destroy functions,
call dirtyLinesFromChangedChild to tell our parent that we are going away.
https://bugs.webkit.org/show_bug.cgi?id=60307

Test: fast/block/child-not-removed-from-parent-lineboxes-crash.html

fast/block/block-not-removed-from-parent-lineboxes-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::destroy):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::destroy):
  • rendering/RenderReplaced.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):

2011-06-23 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

Tests that we do not crash when failing to remove the linebreak
object(widget, block, replaced, etc) from parent block lineboxes. The
testcase tries to fuzz over the list of html and svg tags.
https://bugs.webkit.org/show_bug.cgi?id=60307

  • fast/block/block-not-removed-from-parent-lineboxes-crash-expected.txt: Added.
  • fast/block/block-not-removed-from-parent-lineboxes-crash.html: Added.
  • fast/block/child-not-removed-from-parent-lineboxes-crash-expected.txt: Added.
  • fast/block/child-not-removed-from-parent-lineboxes-crash.html: Added.
4:54 PM Changeset in webkit [90067] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/LayoutTests

2011-06-29 Alan Stearns <stearns@adobe.com>

Reviewed by Tony Chang.

Modify Skipped files so that future css regions layout tests are
skipped by default.

[CSS Regions] Add support for skipped tests
https://bugs.webkit.org/show_bug.cgi?id=63632

  • fast/regions/flow-content-basic.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
4:52 PM Changeset in webkit [90066] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative WinCE build correction.

  • rendering/RenderThemeWin.cpp:

(WebCore::drawControl): Don't call setRGBABitmapAlpha

for WinCE case.

4:50 PM Changeset in webkit [90065] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63669
DFG JIT - fix spectral-norm regression

Reviewed by Geoff Garen.

The problem is a mis-speculation leading to us falling off the speculative path.
Make the speculation logic slightly smarter, don't predict int if one of the
operands is already loaded as a double (we use this logic already for compares).

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):

4:45 PM Changeset in webkit [90064] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r89952): r89952 added a wrong assertion in visible_units.cpp
https://bugs.webkit.org/show_bug.cgi?id=63668

We need to assert the offset to be zero only when the position is NOT offset in node.

  • editing/visible_units.cpp: (WebCore::startOfParagraph):
4:45 PM Changeset in webkit [90063] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-06-29 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG JIT does not do put_by_id transition caching.
https://bugs.webkit.org/show_bug.cgi?id=63662

  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::cachedPutById):
  • dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::addPropertyAccess):
  • dfg/DFGRepatch.cpp: (JSC::DFG::testPrototype): (JSC::DFG::tryCachePutByID):
4:42 PM Changeset in webkit [90062] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebCore

Speculative WinCE build correction after r90057.

  • CMakeListsWinCE.txt: Roll back r90061, since GetWorldTransform is not available in WinCE.
  • platform/win/ScrollbarThemeWin.cpp: Conditionally exclude calls to DIBPixelData::setRGBABitmapAlpha for WinCE.

(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::ScrollbarThemeWin::paintThumb):

4:27 PM Changeset in webkit [90061] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative WinCE build correction after r90057.

  • CMakeListsWinCE.txt: Add missing DIBPixelData.cpp to

WinCE build to support setting bitmap image alpha value.

4:11 PM Changeset in webkit [90060] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-06-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Added a dummy write barrier emitting function in all the right places in the old JIT
https://bugs.webkit.org/show_bug.cgi?id=63667


SunSpider reports no change.

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emit_op_put_scoped_var): Do it.

(JSC::JIT::emit_op_put_global_var): Global object needs to be in a register
for the sake of the write barrier.

(JSC::JIT::emitWriteBarrier): Empty for now. Not for long!

  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emit_op_put_scoped_var): Do it.

(JSC::JIT::emit_op_put_global_var): Global object needs to be in a register
for the sake of the write barrier.

(JSC::JIT::emitWriteBarrier): Empty for now. Not for long!

3:56 PM Changeset in webkit [90059] by Simon Fraser
  • 6 edits
    5 adds in trunk

2011-06-29 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Lay some groundwork for rubber-banding in overflow:scroll divs
https://bugs.webkit.org/show_bug.cgi?id=63654

Make it possible for scrollTop and scrollLeft on a RenderLayer to be
set to negative values, which we will do during rubber-banding in
future. Continue to clamp programmatic scrolls, and scroll positions
set by layout between 0 and the max value.

Test: fast/layers/negative-scroll-positions.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::setScrollLeft): (WebCore::RenderBox::setScrollTop):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollTo):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::scrollToXOffset): (WebCore::RenderLayer::scrollToYOffset):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::forwardEvent):
3:53 PM Changeset in webkit [90058] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

2011-06-29 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

RenderLayer::maximumScrollPosition() is wrong
https://bugs.webkit.org/show_bug.cgi?id=62667

  • platform/ScrollableArea.h: (WebCore::ScrollableArea::isVerticalScrollerPinnedToMinimumPosition): (WebCore::ScrollableArea::isVerticalScrollerPinnedToMaximumPosition): Add these for good measure; they will be needed in an upcoming patch.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::maximumScrollPosition): Subtract the visible content rect, including the scroll bars.
3:52 PM Changeset in webkit [90057] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative WinCE build correction after r90053.

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::inTransparencyLayer): Provide
stub implementation for 'inTransparencyLayer'.

3:42 PM Changeset in webkit [90056] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

eventSender.keyDown is unimplemented (WKTR)
https://bugs.webkit.org/show_bug.cgi?id=57515

Add another test that uses eventSender.keyDown to the mac-wk2 Skipped list.

  • platform/mac-wk2/Skipped:
3:25 PM Changeset in webkit [90055] by abarth@webkit.org
  • 8 edits in trunk/Tools

2011-06-29 Adam Barth <abarth@webkit.org>

Reviewed by Dirk Pranke.

new-run-webkit-tests complains about missing pixel results instead of plopping down new expectations
https://bugs.webkit.org/show_bug.cgi?id=38063

This patch changes new-run-webkit-tests to match old-run-webkit-tests
in generating new expected results when the expected results are
missing.

There are still a couple details that are different:

1) Image baselines aren't generated unless you run with -p.
2) Render tree dumps are places in the cross-platform directory instead
of the platform-specific directory.

I'm inclined to deal with both of these issues in follow-up patches.

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3:24 PM Changeset in webkit [90054] by Adam Roben
  • 5 edits
    1 add in trunk/Tools

Teach TestFailures to detect possibly flaky tests and list them separately

Fixes <http://webkit.org/b/61061> <rdar://problem/9452796> TestFailures page blames
arbitrary revisions for breaking flaky tests

Reviewed by Dan Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Added.

(FlakyLayoutTestDetector): This class identifies flaky tests when given the test results
from various builds (in reverse-chronological order).
(FlakyLayoutTestDetector.prototype.incorporateTestResults): Detects flaky tests. Tests move
monotonically through three states: LastSeenFailing, LastSeenPassing, and PossiblyFlaky.
(FlakyLayoutTestDetector.prototype.flakinessExamples): Finds examples of flakiness for the
given test. Essentially, finds all the transitions from passing to failing (or vice-versa)
and puts them in an array in reverse-chronological order.
(FlakyLayoutTestDetector.prototype.get possiblyFlakyTests): Returns all tests we've detected
to be possibly flaky.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer): Initialize new members.
(LayoutTestHistoryAnalyzer.prototype.start): Now passes the callback an object with two
properties: history and possiblyFlaky. history holds the data this function used to pass to
the callback, while possiblyFlaky lists all tests that might be flaky and examples of their
flakiness. Updated documentation comment to match.
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Now uses a
FlakyLayoutTestDetector to identify possibly flaky tests. Any possibly flaky tests are
removed from the failure history, since when they started failing is no longer meaningful.
We tell our caller to keep calling until all current failures have been explained and we've
gone through 5 builds without any new flaky tests being identified.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(sorted): New helper function to return a sorted copy of an array.
(Array.prototype.findLast): New helper function. Like findFirst, but finds the last item
that matches the predicate.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Updated for change in the object passed to us by
the analyzer. Now puts the list of possibly flaky tests after the failure history.
(ViewController.prototype._domForFailedTest): Moved some code from here...
(ViewController.prototype._domForFailureDiagnosis): ...to here.
(ViewController.prototype._domForPossiblyFlakyTests): New function, builds up a list of
possibly flaky tests and examples of their flakiness and returns it.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in

FlakyLayoutTestDetector.js.

3:11 PM Changeset in webkit [90053] by bfulgham@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-06-29 Xu Fan <qifuren1985@gmail.com>

Reviewed by Brent Fulgham.

Fix Scrollbars Transparent in Windows XP if WebKit is using Layered Window
https://bugs.webkit.org/show_bug.cgi?id=61136

  • platform/graphics/win/DIBPixelData.h: add a static method setRGBABitmapAlpha
  • platform/graphics/win/DIBPixelData.cpp: add implementation
  • platform/win/ScrollbarThemeWin.cpp: fix scroolbar transparent
  • rendering/RenderThemeWin.cpp: fix textbox and button transparent
3:04 PM Changeset in webkit [90052] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-29 Eric Seidel <eric@webkit.org>

Adam says cowboys don't review (or unit test).

  • Scripts/webkitpy/tool/commands/download.py:
2:56 PM Changeset in webkit [90051] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make port/config.py mockable for easier unit testing
https://bugs.webkit.org/show_bug.cgi?id=63661

Fix an exception from the unit tests.

  • Scripts/webkitpy/layout_tests/port/config.py:
2:48 PM Changeset in webkit [90050] by bfulgham@webkit.org
  • 6 edits in trunk/Tools

2011-06-29 Brent Fulgham <bfulgham@webkit.org>

Unreviewed build correction.

  • DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Link against zlib1.dll, not the static zlib.lib.
2:41 PM Changeset in webkit [90049] by eae@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-06-29 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch RenderBoxModelObject::margin* and setMargin* to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63652

Switch margin methods for render tree over to the new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderInline.cpp:
  • rendering/RenderInline.h:
  • rendering/RenderText.h:
2:33 PM Changeset in webkit [90048] by leviw@chromium.org
  • 52 edits in trunk/Source/WebCore

2011-06-29 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paint to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63645

Switch vanilla paint function over to the new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paint):
  • rendering/RenderBox.h:
  • rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::paint):
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paint):
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint):
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paint):
  • rendering/RenderInline.h:
  • rendering/RenderLineBoxList.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::paint):
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderListMarker.h:
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderReplaced.h:
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
  • rendering/RenderReplica.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
  • rendering/RenderTableSection.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderTheme.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::paint):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/RenderWidget.h:
  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLRoot.h:
  • rendering/mathml/RenderMathMLSquareRoot.h:
  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.h:
2:29 PM Changeset in webkit [90047] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Unreviewed build correction.

  • DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops:

Link against zlib1.dll, not the static zlib.lib.

2:28 PM Changeset in webkit [90046] by jianli@chromium.org
  • 5 edits
    3 deletes in trunk

WebGL test failing on SL bots: fast/canvas/webgl/data-view-test.html
https://bugs.webkit.org/show_bug.cgi?id=63151

Reviewed by Kenneth Russell.

Source/WebCore:

The fix is to change to throw TypeError in custom JS/V8 bindings.

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):
(WebCore::setDataViewMember):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):
(WebCore::V8DataView::getInt8Callback):

LayoutTests:

Updated the expected result and removed the rebaselined files that are not needed.

  • fast/canvas/webgl/data-view-test-expected.txt:
  • platform/chromium-mac/fast/canvas/webgl/data-view-test-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/webgl/data-view-test-expected.txt: Removed.
  • platform/mac/fast/canvas/webgl/data-view-test-expected.txt: Removed.
2:25 PM Changeset in webkit [90045] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-29 Luke Macpherson <macpherson@chromium.org>

Reviewed by Darin Adler.

Convert uses of computeLengthIntForLength() to computeLength<Length>()
https://bugs.webkit.org/show_bug.cgi?id=63641

No new tests / refactoring only.

  • css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::applyPageSizeProperty): (WebCore::CSSStyleSelector::mmLength): (WebCore::CSSStyleSelector::inchLength): (WebCore::CSSStyleSelector::mapFillSize): (WebCore::CSSStyleSelector::mapFillXPosition): (WebCore::CSSStyleSelector::mapFillYPosition):
2:25 PM Changeset in webkit [90044] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-29 Jeff Timanus <twiz@chromium.org>

Reviewed by Stephen White.

[Chromium] Remove flakiness marker from fast/canvas/canvas-longlived-context.html
https://bugs.webkit.org/show_bug.cgi?id=63649

  • platform/chromium/test_expectations.txt:
2:22 PM Changeset in webkit [90043] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove duplicate methods in filesystem.py
https://bugs.webkit.org/show_bug.cgi?id=63658

Looks like there was a bad merge at some point.

I also removed a bunch of redundant docstrings.

  • Scripts/webkitpy/common/system/filesystem.py:
2:20 PM Changeset in webkit [90042] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

2011-06-29 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Simplify AudioBufferSourceNode rendering
https://bugs.webkit.org/show_bug.cgi?id=63586

No new tests since this doesn't change API.

  • webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::AudioBufferSourceNode): (WebCore::AudioBufferSourceNode::process): (WebCore::AudioBufferSourceNode::renderFromBuffer): (WebCore::AudioBufferSourceNode::reset): (WebCore::AudioBufferSourceNode::setBuffer): (WebCore::AudioBufferSourceNode::noteOn): (WebCore::AudioBufferSourceNode::noteGrainOn): (WebCore::AudioBufferSourceNode::totalPitchRate):
  • webaudio/AudioBufferSourceNode.h:
2:03 PM Changeset in webkit [90041] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-06-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Freetype] Many tests report ERROR: Failed to get glyph page zero.
https://bugs.webkit.org/show_bug.cgi?id=63498

Instead of conditionally instantiating the m_scaledFont member of FontPlatformData,
always instantiate it. For times when the size is 0 and the instantiation would lead
to a Cairo error, we use size 1 and just make operations which would fail conditional
on the m_size > 0.

No new tests. This change is covered by existing tests. We should
observe no errors on the bots after landing.

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs): Instead of looking at whether or not there is a scaled font to determine whether to draw, just look at the size.
  • platform/graphics/freetype/FontPlatformData.h: Remove the m_font member.
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: Always instantiate a scaled font member and remove references to m_font. If we are instantiating a scaled font for a 0 size font, instantiate a size 1 font, so that we can still use Cairo to query font properties.
  • platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp: (WebCore::GlyphPage::fill): We can assume there is always a scaled font now.
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::platformInit): Ditto. (WebCore::SimpleFontData::createScaledFontData): Ditto. (WebCore::SimpleFontData::containsCharacters): Ditto. (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
1:55 PM Changeset in webkit [90040] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Pass --no-new-test-results to NRWT on build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=63653

This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=38063.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
1:52 PM Changeset in webkit [90039] by eric.carlson@apple.com
  • 5 edits
    4 adds in trunk

2011-06-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Media element loads blocked by a resource load delegate do not generate an error event
https://bugs.webkit.org/show_bug.cgi?id=63558

Tests: media/media-blocked-by-beforeload.html

media/media-blocked-by-willsendrequest.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): Call mediaLoadingFailed instead of noneSupported

so all failures follow the same code path.

(WebCore::HTMLMediaElement::loadResource): Call mediaLoadingFailed when there is no frame, when

the loader delegate rejects the url, or when MediaPlayer doesn't find a media engine that
supports the type.

(WebCore::HTMLMediaElement::selectNextSourceChild): Fix incorrect logging.
(WebCore::HTMLMediaElement::mediaLoadingFailed): Change name of parameter from "state" to

"error" to make its purpose obvious.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Return a bool indicating whether or not the url was given to

a media engine.

(WebCore::MediaPlayer::loadWithNextMediaEngine): Add some logging.

  • platform/graphics/MediaPlayer.h:

2011-06-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Media element loads blocked by a resource load delegate do not generate an error event
https://bugs.webkit.org/show_bug.cgi?id=63558

  • media/media-blocked-by-beforeload-expected.txt: Added.
  • media/media-blocked-by-beforeload.html: Added.
  • media/media-blocked-by-willsendrequest-expected.txt: Added.
  • media/media-blocked-by-willsendrequest.html: Added.
1:46 PM Changeset in webkit [90038] by Darin Adler
  • 5 edits
    2 adds in trunk

2011-06-29 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

[WebKit2] Crash loading page that adds/removes frame in DOMContentLoaded/loaded
https://bugs.webkit.org/show_bug.cgi?id=63483

  • fast/loader/create-frame-in-DOMContentLoaded-expected.txt: Added.
  • fast/loader/create-frame-in-DOMContentLoaded.html: Added.

2011-06-29 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

[WebKit2] Crash loading page that adds/removes frame in DOMContentLoaded/loaded
https://bugs.webkit.org/show_bug.cgi?id=63483

Test: fast/loader/create-frame-in-DOMContentLoaded.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Added an assertion. (WebCore::FrameLoader::finishedLoadingDocument): Removed a non-helpful #if statement. The rule that we do not call the client when creating the initial empty document was nominally specific to Windows and Chromium but is needed for all platforms.

2011-06-29 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

[WebKit2] Crash loading page that adds/removes frame in DOMContentLoaded/loaded
https://bugs.webkit.org/show_bug.cgi?id=63483

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createFrame): Added a check for null when creating a frame. Also added a check that was in the WebKit1 code, but not here. Strangely, the comment from the second check was still here, but not the code.
1:14 PM Changeset in webkit [90037] by enne@google.com
  • 1 edit
    3 copies in branches/chromium/782

Merge 88698 - 2011-06-13 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465

  • compositing/layer-creation/overlap-child-layer-expected.png: Added.
  • compositing/layer-creation/overlap-child-layer-expected.txt: Added.
  • compositing/layer-creation/overlap-child-layer.html: Added.

2011-06-13 Adrienne Walker <enne@google.com>

Reviewed by Simon Fraser.

Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465

Any child layer with a compositing ancestor will be put into a
composited layer even though they themselves don't need compositing.
As layer bounds aren't hierarchical, these layer bounds themselves
need to be put into the overlap map because the composited layer
itself is not sufficient.

Test: compositing/layer-creation/overlap-animated-layer.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):

TBR=enne@google.com

12:47 PM Changeset in webkit [90036] by xan@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Adam Barth.

[GTK] overlapping drag&drop tests fail on NRWT
https://bugs.webkit.org/show_bug.cgi?id=57640

Make a GTK test driver that spawns one Xvfb instance per
thread. This avoids bad interactions in DnD tests between threads.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
12:46 PM Changeset in webkit [90035] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

2011-06-29 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG JIT does not perform get_by_id self list caching.
https://bugs.webkit.org/show_bug.cgi?id=63605

  • bytecode/StructureStubInfo.h:
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp: (JSC::DFG::tryCacheGetByID): (JSC::DFG::tryBuildGetByIDList): (JSC::DFG::dfgBuildGetByIDList):
  • dfg/DFGRepatch.h:
12:46 PM QtWebKitRelease20 edited by Ademar Reis
(diff)
12:45 PM QtWebKitRelease21 edited by Ademar Reis
(diff)
12:20 PM Changeset in webkit [90034] by nduca@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-29 Nat Duca <nduca@chromium.org>

[chromium] Unreviewed, mark fast/canvas/webgl/context-lost-restored failing
https://bugs.webkit.org/show_bug.cgi?id=63643

  • platform/chromium/test_expectations.txt:
12:18 PM Changeset in webkit [90033] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-29 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Add Qt dependencies in QtWebKit's main pro file.
https://bugs.webkit.org/show_bug.cgi?id=63639

syncqt, the script which generates the headers inside Qt parses
the main pro file of QtWebKit to check the Qt dependencies. It used
to be WebCore.pro but after the build reorganization QtWebKit.pro is
the new main pro file so we need to add the network dependency just like
we did in WebCore.pro.

12:07 PM Changeset in webkit [90032] by nduca@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-29 Nat Duca <nduca@chromium.org>

[chromium] Unreviewed, mark index-validation-with-resized-buffer as failing.
https://bugs.webkit.org/show_bug.cgi?id=63638

  • platform/chromium/test_expectations.txt:
11:58 AM Changeset in webkit [90031] by commit-queue@webkit.org
  • 2 edits
    1 move
    9 deletes in trunk/LayoutTests

2011-06-29 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/paragraph-in-preserveNewline.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=63362

Converted editing/deleting/paragraph-in-preserveNewline.html to dump-as-markup,
added doctype, added new baseline, and removed old baselines.

  • editing/deleting/paragraph-in-preserveNewline.html:
  • editing/deleting/paragraph-in-preserveNewline-expected.html: Added.
  • platform/chromium-linux/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
  • platform/chromium-win/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
  • platform/chromium-win/editing/deleting/paragraph-in-preserveNewline-expected.txt: Removed.
  • platform/gtk/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
  • platform/mac-leopard/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
  • platform/mac/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
  • platform/mac/editing/deleting/paragraph-in-preserveNewline-expected.txt: Removed.
  • platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
  • platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.txt: Removed.
11:58 AM Changeset in webkit [90030] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-29 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Switch hitTestColumns/Contents/Floats to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63589

Switch location and size methods for RenderBox over to the new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/ColumnInfo.h: (WebCore::ColumnInfo::desiredColumnWidth): (WebCore::ColumnInfo::setDesiredColumnWidth): (WebCore::ColumnInfo::columnHeight): (WebCore::ColumnInfo::setColumnCountAndHeight): (WebCore::ColumnInfo::setColumnHeight): (WebCore::ColumnInfo::updateMinimumColumnHeight): (WebCore::ColumnInfo::minimumColumnHeight):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverflowFromChildren): (WebCore::RenderBlock::paintColumnRules): (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::hitTestFloats): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::columnRectAt):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::xPositionForFloatIncludingMargin): (WebCore::RenderBlock::yPositionForFloatIncludingMargin):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):
  • rendering/RenderLayer.h:
11:30 AM Changeset in webkit [90029] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-29 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Divide by zero in TilingData
https://bugs.webkit.org/show_bug.cgi?id=63305

Add safety checks for empty layers.

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::updateRect):
11:21 AM Changeset in webkit [90028] by Nate Chapin
  • 3 edits in trunk/LayoutTests

2011-06-29 Nate Chapin <Nate Chapin>

Unreviewed, more chromium test updates.

  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
10:57 AM Changeset in webkit [90027] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

2011-06-29 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Darin Adler.

Add note about cases where enums are preferred over bools on function parameters.
https://bugs.webkit.org/show_bug.cgi?id=63564

This matches the outcome of this webkit-dev thread:
https://lists.webkit.org/pipermail/webkit-dev/2010-December/015192.html

  • coding/coding-style.html:
10:46 AM Changeset in webkit [90026] by Dimitri Glazkov
  • 3 edits in trunk/Source/WebCore

2011-06-29 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Extract setShadowRoot function, harden it in preparation to be exposed to script.
https://bugs.webkit.org/show_bug.cgi?id=63596

Refactoring, covered by existing tests.

  • dom/Element.cpp: (WebCore::validateShadowRoot): Added. (WebCore::Element::setShadowRoot): Extracted from ensureShadowRoot. (WebCore::Element::ensureShadowRoot): Changed to use setShadowRoot.
  • dom/Element.h: Added decl.
10:44 AM Changeset in webkit [90025] by jhawkins@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-29 James Hawkins <jhawkins@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Fix a crash on when executeCommand(copy) is called on a null node.
https://bugs.webkit.org/show_bug.cgi?id=63626

  • src/WebFrameImpl.cpp: (WebKit::pluginContainerFromNode):
10:42 AM Changeset in webkit [90024] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-06-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89888.
http://trac.webkit.org/changeset/89888
https://bugs.webkit.org/show_bug.cgi?id=63609

"Seems to be causing merging issues on the dashboard, e.g.

http://test-
results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fcanvas"
(Requested by aboxhall on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
10:34 AM Changeset in webkit [90023] by Nate Chapin
  • 3 edits
    3 adds in trunk/LayoutTests

2011-06-29 Nate Chapin <Nate Chapin>

Unreviewed, chromium test updates.

  • platform/chromium-mac-leopard/svg/foreignObject: Added.
  • platform/chromium-mac-leopard/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt: Added.
  • platform/chromium-mac/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium/test_expectations.txt:
9:22 AM Changeset in webkit [90022] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-29 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION Resource revision fails to request content if it was not yet loaded for resource.
https://bugs.webkit.org/show_bug.cgi?id=63631

  • http/tests/inspector/network/network-request-revision-content-expected.txt: Added.
  • http/tests/inspector/network/network-request-revision-content.html: Added.
  • http/tests/inspector/network/resources/script.js: Added.

2011-06-29 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION Resource revision fails to request content if it was not yet loaded for resource.
https://bugs.webkit.org/show_bug.cgi?id=63631

Test: http/tests/inspector/network/network-request-revision-content.html

  • inspector/front-end/Resource.js: (WebInspector.ResourceRevision.prototype.requestContent):
9:15 AM Changeset in webkit [90021] by kbalazs@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-06-29 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] plugins/document-open.html need new result for wk2
https://bugs.webkit.org/show_bug.cgi?id=63633

  • platform/qt-wk2/Skipped:
  • platform/qt-wk2/plugins/document-open-expected.txt: Added.
8:56 AM Changeset in webkit [90020] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-29 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] GraphicsContext::clipToImageBuffer does not support scale transformation
https://bugs.webkit.org/show_bug.cgi?id=63555

Scale alphaMask if GraphicsContext is scaled

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::pushTransparencyLayerInternal):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::clip):
8:20 AM Changeset in webkit [90019] by loislo@chromium.org
  • 3 edits in branches/chromium/782/Source/WebCore/inspector/front-end

Merge 89666 - 2011-06-23 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Shorten DOMWindow URLs in heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=63238

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode): (WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage): (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren): (WebInspector.HeapSnapshotGenericObjectNode.prototype.isDOMWindow): (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound): (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString): (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
  • inspector/front-end/utilities.js: ():

TBR=mnaganov@chromium.org
BUG=87584
Review URL: http://codereview.chromium.org/7218041

8:17 AM Changeset in webkit [90018] by loislo@chromium.org
  • 3 edits in branches/chromium/782

Merge 90013 - 2011-06-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: tab crash after deleting trailing quote when editing attribute
https://bugs.webkit.org/show_bug.cgi?id=63544

  • inspector/elements/set-attribute-expected.txt:
  • inspector/elements/set-attribute.html:

2011-06-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: tab crash after deleting trailing quote when editing attribute
https://bugs.webkit.org/show_bug.cgi?id=63544

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setAttributesText):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):

TBR=pfeldman@chromium.org
BUG=87895
Review URL: http://codereview.chromium.org/7280007

7:38 AM Changeset in webkit [90017] by caseq@chromium.org
  • 9 edits in trunk/Source

2011-06-29 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: backend needs to provide system-unique object ids, so these remain unique across navigation
https://bugs.webkit.org/show_bug.cgi?id=62894

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setAgentProcessIdentifier):
  • inspector/InspectorController.h:
  • inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::setAgentIdentifier): (WebCore::InspectorPageAgent::createIdentifier): (WebCore::InspectorPageAgent::frameForId): (WebCore::InspectorPageAgent::frameId): (WebCore::InspectorPageAgent::frameDestroyed):
  • inspector/InspectorPageAgent.h:

2011-06-29 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: backend needs to provide system-unique object ids, so these remain unique across navigation
https://bugs.webkit.org/show_bug.cgi?id=62894

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setAgentProcessIdentifier):
  • src/WebDevToolsAgentImpl.h:
7:18 AM Changeset in webkit [90016] by Philippe Normand
  • 2 edits in trunk/Tools

Reviewed by Martin Robinson.

[webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output
https://bugs.webkit.org/show_bug.cgi?id=63624

  • Scripts/webkitpy/common/system/executive.py: In some cases the ps output lines can contain one or more leading white-spaces, so strip it before splitting the pid and command name.
7:12 AM Changeset in webkit [90015] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-06-29 Michal Pakula vel Rutka <Michał Pakuła vel Rutka>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add ewk_frame_text_selection_type_get function
https://bugs.webkit.org/show_bug.cgi?id=63462

Add a method to obtain current WebCore::VisibleSelection text
selection type.

  • ewk/ewk_frame.cpp: (ewk_frame_text_selection_type_get):
  • ewk/ewk_frame.h:
6:58 AM Changeset in webkit [90014] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: create status bar buttons programmatically. Add "Inspect" button to all panels.
https://bugs.webkit.org/show_bug.cgi?id=63450

Buttons should be created in code, not in HTML. Also making Inspect Element
action available on all panels (as an experiment).

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.show): (WebInspector.ConsoleView.prototype.hide):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.get statusBarItems): (WebInspector.ElementsPanel.prototype.updateFocusedNode): (WebInspector.ElementsPanel.prototype._setSearchingForNode): (WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
  • inspector/front-end/inspector.css: (button.dock-status-bar-item.status-bar-item .glyph): (button.dock-status-bar-item.status-bar-item.toggled-on .glyph): (.console-status-bar-item .glyph):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createGlobalStatusBarItems): (WebInspector.set attached):
6:47 AM Changeset in webkit [90013] by pfeldman@chromium.org
  • 6 edits in trunk

2011-06-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: tab crash after deleting trailing quote when editing attribute
https://bugs.webkit.org/show_bug.cgi?id=63544

  • inspector/elements/set-attribute-expected.txt:
  • inspector/elements/set-attribute.html:

2011-06-29 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: tab crash after deleting trailing quote when editing attribute
https://bugs.webkit.org/show_bug.cgi?id=63544

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setAttributesText):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
6:42 AM Changeset in webkit [90012] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, remove erroneous test name from GTK Skipped list.

  • platform/gtk/Skipped:
6:13 AM Changeset in webkit [90011] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-29 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION Inspector failing to load resource content after navigation. Safari.
https://bugs.webkit.org/show_bug.cgi?id=63480

  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
5:43 AM Changeset in webkit [90010] by pfeldman@chromium.org
  • 9 edits
    2 adds in trunk

2011-06-29 Mike West <mkwst@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127

Setting correct expectations for the following fields newly added to
the HAR implementation:

  • entry.request.httpVersion
  • entry.request.headersSize
  • entry.request.bodySize
  • entry.response.httpVersion
  • entry.response.headersSize
  • entry.response.bodySize
  • entry.response.content.compression
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-har-headers-expected.txt: Added.
  • http/tests/inspector/resource-har-headers.html: Added.
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resources-test.js:

2011-06-29 Mike West <mkwst@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Missing fields in HAR
https://bugs.webkit.org/show_bug.cgi?id=58127

Specifically, this patch adds:

  • entry.request.httpVersion
  • entry.request.headersSize
  • entry.request.bodySize
  • entry.response.httpVersion
  • entry.response.headersSize
  • entry.response.bodySize
  • entry.response.content.compression

Tests: http/tests/inspector/resource-har-conversion.html

http/tests/inspector/resource-har-headers.html
http/tests/inspector/resource-parameters.html
http/tests/inspector/network/network-size.html

4:44 AM Changeset in webkit [90009] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip 2 acid tests on GTK due to bug 54119. They were
failing only in 32-Bits Release though.

  • platform/gtk/Skipped:
4:05 AM Changeset in webkit [90008] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Qt specific results committed in r90007, but fail on Qt-Mac platform

  • platform/qt-mac/Skipped: Skip failing tests.
3:44 AM Changeset in webkit [90007] by Csaba Osztrogonác
  • 3 edits
    10 adds in trunk/LayoutTests

[Qt] Add platform specific expected results for new passing tests.

  • platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
  • platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
  • platform/qt/svg/custom/text-tref-03-b-change-href-expected.png: Added.
  • platform/qt/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
  • platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
  • platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
  • platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
  • platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
3:24 AM Changeset in webkit [90006] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-29 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Kent Tamura.

[Chromium] [DRT] ImageDiff should compile in VS2010
https://bugs.webkit.org/show_bug.cgi?id=63614

  • DumpRenderTree/chromium/ImageDiff.cpp: Include <iterator> for back_inserter.
2:58 AM Changeset in webkit [90005] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of 2 more tests.

  • inspector/console/console-trace-in-eval-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
2:39 AM Changeset in webkit [90004] by hayato@chromium.org
  • 5 edits
    2 adds in trunk

2011-06-29 Hayato Ito <hayato@chromium.org>

Reviewed by Hajime Morita.

Make a shadow host transfer a focus to the first focusable element in the shadow root when its focus() is called.
https://bugs.webkit.org/show_bug.cgi?id=62358.

This patch doesn't take an effect on the following elements to keep a compatibility.

  • <input>, <textarea>, <video> and <audio> elements We'll address these elements separately after re-targeting focus events (bug 61421) is implemented.

A shadow root's <content> is not considered in this patch.
That should be addressed in another patch. See bug 63522.

  • fast/dom/shadow/shadow-host-transfer-focus-expected.txt: Added.
  • fast/dom/shadow/shadow-host-transfer-focus.html: Added.

2011-06-29 Hayato Ito <hayato@chromium.org>

Reviewed by Hajime Morita.

Make a shadow host transfer a focus to the first focusable element in the shadow root when its focus() is called.
https://bugs.webkit.org/show_bug.cgi?id=62358.

This patch doesn't take an effect on the following elements to keep a compatibility.

  • <input>, <textarea>, <video> and <audio> elements We'll address these elements separately after re-targeting focus events (bug 61421) is implemented.

A shadow root's <content> is not considered in this patch.
That should be addressed in another patch. See bug 63522.

Test: fast/dom/shadow/shadow-host-transfer-focus.html

  • dom/Element.cpp: (WebCore::Element::focus):
  • page/FocusController.cpp: (WebCore::shadowRoot): (WebCore::isTreeScopeOwner): (WebCore::FocusController::transferFocusToElementInShadowRoot): (WebCore::hasCustomFocusLogic): (WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocumentOrShadowRoot): (WebCore::FocusController::advanceFocusInDocumentOrder): (WebCore::ownerOfTreeScope): (WebCore::FocusController::findFocusableNodeAcrossTreeScope):
  • page/FocusController.h:
2:32 AM Changeset in webkit [90003] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-29 Ryan Sleevi <rsleevi@chromium.org>

Reviewed by Dirk Schulze.

SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative
https://bugs.webkit.org/show_bug.cgi?id=61600

Correct the logic for checking for relative lengths in a SVGRadialGradientElement to consider cx() in addition to cy()

No new tests, as there is no way to currently test this. With the bug present, a side-effect is causing the
expected/correct image to be rendered. This is because the cached SVG resource is getting invalided through a
different path, forcing a repaint. The repaint takes into consideration the proper dimensions, hiding the bug.

  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):
2:29 AM Changeset in webkit [90002] by rolandsteiner@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-06-29 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: last last ruby expectations for WebKit2 Win.

  • platform/win-wk2/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
2:22 AM Changeset in webkit [90001] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip
http/tests/history/cross-origin-replace-history-object-child.html
on GTK, due to bug 61937.

  • platform/gtk/Skipped:
2:18 AM Changeset in webkit [90000] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of 3 svg/custom/linking tests.

  • platform/gtk/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/gtk/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/gtk/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
1:59 AM Changeset in webkit [89999] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline of
fast/html/details-open-javascript.html

  • platform/gtk/fast/html/details-open-javascript-expected.txt:
1:30 AM Changeset in webkit [89998] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip crashing tests on GTK because of
https://bugs.webkit.org/show_bug.cgi?id=63611

  • platform/gtk/Skipped: skip 5 editing tests
12:57 AM Changeset in webkit [89997] by rolandsteiner@chromium.org
  • 5 edits in trunk/LayoutTests

2011-06-29 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: update the (hopefully) last ruby expectation stragglers in WebKit2

  • platform/win-wk2/fast/ruby/after-block-doesnt-crash-expected.txt:
  • platform/win-wk2/fast/ruby/after-table-doesnt-crash-expected.txt:
  • platform/win-wk2/fast/ruby/before-block-doesnt-crash-expected.txt:
  • platform/win-wk2/fast/ruby/before-table-doesnt-crash-expected.txt:
12:31 AM Changeset in webkit [89996] by loislo@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore/inspector/front-end

Merge 89562 - 2011-06-23 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Fix showing dominator leaf nodes after r89457
https://bugs.webkit.org/show_bug.cgi?id=63250

  • inspector/front-end/DetailedHeapshotView.js:
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get isEmpty):

TBR=mnaganov@chromium.org
BUG=87583
Review URL: http://codereview.chromium.org/7280004

12:21 AM Changeset in webkit [89995] by rolandsteiner@chromium.org
  • 1 edit
    17 adds in trunk/LayoutTests

2011-06-29 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: more juggling with ruby expectation files, trying to
find my way out of the expectations dependency jungle...

  • platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
  • platform/win/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
  • platform/win/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
  • platform/win/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
12:11 AM Changeset in webkit [89994] by Darin Adler
  • 4 edits
    3 moves in trunk/LayoutTests

2011-06-29 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Consolidate the fast/loader and fast/loading directories
https://bugs.webkit.org/show_bug.cgi?id=63587

  • fast/loader/resources/subframe-that-removes-itself.html: Copied from LayoutTests/fast/loading/resources/subframe-that-removes-itself.html.
  • fast/loader/subframe-removes-itself-expected.txt: Copied from LayoutTests/fast/loading/subframe-removes-itself-expected.txt.
  • fast/loader/subframe-removes-itself.html: Copied from LayoutTests/fast/loading/subframe-removes-itself.html.
  • fast/loading/resources/subframe-that-removes-itself.html: Removed.
  • fast/loading/subframe-removes-itself-expected.txt: Removed.
  • fast/loading/subframe-removes-itself.html: Removed.
  • platform/gtk/Skipped: Updated for new location of test.
  • platform/mac-wk2/Skipped: Ditto.
  • platform/qt-wk2/Skipped: Ditto.

Jun 28, 2011:

11:54 PM Changeset in webkit [89993] by krit@webkit.org
  • 16 edits
    4 adds in trunk

2011-06-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGBoolean animation
https://bugs.webkit.org/show_bug.cgi?id=63529

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGBoolean.


The new animator does not affect any behavior, since it was animated with SVGAnimatedString before. The new animator is still needed
to support animVal and baseVal later.

Test: svg/animations/svgboolean-animation-1.html

  • CMakeLists.txt: Add new file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of AnimatedBoolean. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedBoolean.cpp: Added. New animator for SVGBoolean. (WebCore::SVGAnimatedBooleanAnimator::SVGAnimatedBooleanAnimator): (WebCore::SVGAnimatedBooleanAnimator::constructFromString): (WebCore::SVGAnimatedBooleanAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedBooleanAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedBooleanAnimator::calculateDistance):
  • svg/SVGAnimatedBoolean.h: (WebCore::SVGAnimatedBooleanAnimator::~SVGAnimatedBooleanAnimator):
  • svg/SVGAnimatedType.cpp: Use bool for SVGBoolean. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createBoolean): (WebCore::SVGAnimatedType::boolean): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: New crate function for SVGAnimatedSVGBooleanAnimator. (WebCore::SVGAnimatorFactory::create):

2011-06-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGBoolean animation
https://bugs.webkit.org/show_bug.cgi?id=63529


Test animation of SVGBoolean. Add the test to the skip list of wk2.
Convert animate-number-calcMode-discrete-keyTimes to common style, no change
on the test itself.

  • platform/mac-wk2/Skipped:
  • svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt:
  • svg/animations/animate-number-calcMode-discrete-keyTimes.html:
  • svg/animations/script-tests/svgboolean-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgboolean-animation-1-expected.txt: Added.
  • svg/animations/svgboolean-animation-1.html: Added.
11:46 PM Changeset in webkit [89992] by Dimitri Glazkov
  • 3 edits in trunk/Source/WebCore

2011-06-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Make applyAuthorSheets settable on ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=63599

Refactoring and adding not-yet used function, tests to follow when API lands.

  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::ShadowRoot): Added initializer. (WebCore::ShadowRoot::applyAuthorSheets): Made to use member variable. (WebCore::ShadowRoot::setApplyAuthorSheets): Added.
  • dom/ShadowRoot.h: Tweaked, added decls.
11:35 PM Changeset in webkit [89991] by isherman@chromium.org
  • 22 edits
    2 adds in trunk

2011-06-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Barth.

form.autocomplete="off" does not work
https://bugs.webkit.org/show_bug.cgi?id=35823

  • fast/forms/autocomplete-expected.txt: Added.
  • fast/forms/autocomplete.html: Added.

2011-06-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Barth.

form.autocomplete="off" does not work
Rename the autoComplete() method for HTMLFormElement, HTMLFormControlElementWithState, and HTMLInputElement to shouldAutocomplete()
Add the autocomplete attribute to HTMLFormElement.idl and HTMLInputElement.idl
https://bugs.webkit.org/show_bug.cgi?id=35823

Test: fast/forms/autocomplete.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::shouldAutocomplete): Renamed from ::autoComplete() (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): Update callsite.
  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement): Update callsite. (WebCore::HTMLFormElement::parseMappedAttribute): Update callsite. (WebCore::HTMLFormElement::documentDidBecomeActive): Update callsite. (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Update callsite. (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Update callsite. (WebCore::HTMLFormElement::shouldAutocomplete): Renamed from ::autoComplete()
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.idl: Bind the autocomplete attribute to a JavaScript property.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::shouldAutocomplete): Renamed from ::autoComplete()
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl: Bind the autocomplete attribute to a JavaScript property.
  • WebCore.exp.in: Updated autoComplete() -> shouldAutocomplete()

2011-06-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Barth.

form.autocomplete="off" does not work
https://bugs.webkit.org/show_bug.cgi?id=35823

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill): Update callsite.
  • src/WebFormElement.cpp: (WebKit::WebFormElement::autoComplete): Update callsite.
  • src/WebInputElement.cpp: (WebKit::WebInputElement::autoComplete): Update callsite.
  • src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Update callsite.

2011-06-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Barth.

form.autocomplete="off" does not work
https://bugs.webkit.org/show_bug.cgi?id=35823

  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementDoesAutoComplete:]): Update callsite.

2011-06-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Barth.

form.autocomplete="off" does not work
https://bugs.webkit.org/show_bug.cgi?id=35823

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId): Update callsite.

2011-06-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Adam Barth.

form.autocomplete="off" does not work
https://bugs.webkit.org/show_bug.cgi?id=35823

  • WebFrame.cpp: (WebFrame::elementDoesAutoComplete): Updated callsite.
11:06 PM Changeset in webkit [89990] by rolandsteiner@chromium.org
  • 15 edits
    8 deletes in trunk/LayoutTests

2011-06-28 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: change URLs in ruby layout tests to lower case in order
to avoid having to have separate Chromium expectations.

  • fast/ruby/after-block-doesnt-crash-expected.txt:
  • fast/ruby/after-block-doesnt-crash.html:
  • fast/ruby/after-table-doesnt-crash-expected.txt:
  • fast/ruby/after-table-doesnt-crash.html:
  • fast/ruby/before-block-doesnt-crash-expected.txt:
  • fast/ruby/before-block-doesnt-crash.html:
  • fast/ruby/before-table-doesnt-crash-expected.txt:
  • fast/ruby/before-table-doesnt-crash.html:
  • fast/ruby/generated-after-counter-doesnt-crash-expected.txt:
  • fast/ruby/generated-after-counter-doesnt-crash.html:
  • fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt:
  • fast/ruby/generated-before-and-after-counter-doesnt-crash.html:
  • fast/ruby/generated-before-counter-doesnt-crash-expected.txt:
  • fast/ruby/generated-before-counter-doesnt-crash.html:
  • platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
  • platform/chromium-win/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
  • platform/chromium-win/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
  • platform/chromium-win/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
  • platform/chromium-win/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
11:05 PM Changeset in webkit [89989] by Dimitri Glazkov
  • 6 edits in trunk/Source/WebCore

2011-06-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Store shadowPseudoId in ElementRareData.
https://bugs.webkit.org/show_bug.cgi?id=63604

No new tests, because the code isn't yet used.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::isUnknownPseudoType): Added convenience helper.
  • css/CSSSelector.h: Added decl.
  • dom/Element.cpp: (WebCore::Element::shadowPseudoId): Changed to use ElementRareData. (WebCore::Element::setShadowPseudoId): Ditto.
  • dom/Element.h: Added decls.
  • dom/ElementRareData.h: Added a member to keep shadowPseudoId.
11:01 PM Changeset in webkit [89988] by bashi@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-06-28 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Tony Chang.

[Chromium] Remove dependencies on harfbuzz from FontPlatformDataLinux and FontLinux
https://bugs.webkit.org/show_bug.cgi?id=62530

  • Moved codes of FontLinux which depend on harfbuzz APIs to ComplexTextController. Removed Some methods of ComplexTextController(advances() and logClusters()) since they are no longer needed.
  • Moved RefCountedHarfbuzzFace from FontPlatformDataLinux to HarfbuzzSkia and renamed it to HarfbuzzFace.

No new tests because there is no behavior change (The existing tests should cover the changes).

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::ComplexTextController): Added arguments so eliminating setter invocations. (WebCore::ComplexTextController::setupForRTL): Added. (WebCore::ComplexTextController::setupFontForScriptRun): Adopt the change of HarfbuzzFace class. (WebCore::ComplexTextController::setGlyphPositions): Use m_item.log_clusters instead of removed method. (WebCore::ComplexTextController::glyphIndexForXPositionInScriptRun): Added. (WebCore::ComplexTextController::offsetForPosition): Ditto. (WebCore::ComplexTextController::selectionRect): Ditto.
  • platform/graphics/chromium/ComplexTextControllerLinux.h: (WebCore::ComplexTextController::width):
  • platform/graphics/chromium/FontLinux.cpp: Removed truncateFixedPointToInteger(). (WebCore::Font::drawComplexText): Removed setter invocations of ComplexTextController. (WebCore::Font::floatWidthForComplexText): Ditto. (WebCore::Font::offsetForPositionForComplexText): Moved harfbuzz dependent code to ComplexTextController. (WebCore::Font::selectionRectForComplexText): Ditto.
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::harfbuzzFace): Wrapped up HB_FaceRec in HarfbuzzFace class.
  • platform/graphics/chromium/FontPlatformDataLinux.h: Moved RefCountedHarfbuzzFace class and renamed to HarfbuzzFace.
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::allocHarfbuzzFont): Moved from ComplexTextControllerLinux.cpp. (WebCore::HarfbuzzFace::HarfbuzzFace): Added. (WebCore::HarfbuzzFace::~HarfbuzzFace): Added.
  • platform/graphics/chromium/HarfbuzzSkia.h: (WebCore::HarfbuzzFace::create): Added. (WebCore::HarfbuzzFace::face): Added.
  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: (WebCore::substituteWithVerticalGlyphs): Adopt the change of HarfbuzzFace class.
11:00 PM Writing Layout Tests for DumpRenderTree edited by dominicc@chromium.org
Documented overridePreference. (diff)
9:34 PM Changeset in webkit [89987] by rolandsteiner@chromium.org
  • 3 edits
    6 adds in trunk

2011-06-28 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Eric Seidel.

Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
https://bugs.webkit.org/show_bug.cgi?id=55930

Test that a generated block child + counter within a <ruby> doesn't crash.
(Test as provided by original reporter).

  • fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
  • fast/ruby/generated-after-counter-doesnt-crash.html: Added.
  • fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
  • fast/ruby/generated-before-and-after-counter-doesnt-crash.html: Added.
  • fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
  • fast/ruby/generated-before-counter-doesnt-crash.html: Added.

2011-06-28 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Eric Seidel.

Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
https://bugs.webkit.org/show_bug.cgi?id=55930

Don't set style type BEFORE/AFTER on anonymous wrapper block.
Rather, check style type on generated wrapped child.

Tests: fast/ruby/generated-after-counter-doesnt-crash.html

fast/ruby/generated-before-and-after-counter-doesnt-crash.html
fast/ruby/generated-before-counter-doesnt-crash.html

  • rendering/RenderRuby.cpp: (WebCore::isAnonymousRubyInlineBlock): (WebCore::isRubyBeforeBlock): (WebCore::isRubyAfterBlock): (WebCore::rubyBeforeBlock): (WebCore::rubyAfterBlock): (WebCore::createAnonymousRubyInlineBlock): (WebCore::RenderRubyAsInline::addChild): (WebCore::RenderRubyAsBlock::addChild):
8:18 PM Changeset in webkit [89986] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG JIT lacks array.length caching.
https://bugs.webkit.org/show_bug.cgi?id=63505

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-06-28
Reviewed by Gavin Barraclough.

  • bytecode/StructureStubInfo.h:
  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::tryAllocate):
(JSC::DFG::JITCodeGenerator::selectScratchGPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):

  • dfg/DFGRegisterBank.h:

(JSC::DFG::RegisterBank::tryAllocate):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

7:41 PM Changeset in webkit [89985] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-28 Pierre Rossi <pierre.rossi@gmail.com>

Reviewed by Eric Seidel.

Warnings in JSC's JIT on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=63259

Fairly straightforward, just use ASSERT_JIT_OFFSET_UNUSED when it applies.

  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id):
6:28 PM Changeset in webkit [89984] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-28 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch RenderLayer position/size to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63578

Switch location and size methods for RenderLayer over to the new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): (WebCore::RenderLayer::visibleHeight): (WebCore::RenderLayer::visibleWidth): (WebCore::RenderLayer::offsetFromResizeCorner):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::location): (WebCore::RenderLayer::setLocation): (WebCore::RenderLayer::size): (WebCore::RenderLayer::setSize): (WebCore::RenderLayer::rect): (WebCore::RenderLayer::renderBoxLocation): (WebCore::RenderLayer::renderBoxX): (WebCore::RenderLayer::renderBoxY):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::visibleHeight): (WebCore::RenderListBox::visibleWidth):
  • rendering/RenderListBox.h:
6:06 PM Changeset in webkit [89983] by leviw@chromium.org
  • 23 edits in trunk/Source/WebCore

2011-06-28 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintObject and paintReplaced to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63585

Switching paintObject and paintReplaced to layout type abstractions from more integral types.

No new tests as this is just moving to an abstraction.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.h: (WebCore::RenderBox::paintObject):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paintReplaced):
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
  • rendering/RenderImage.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
  • rendering/RenderListBox.h:
  • rendering/RenderReplaced.h: (WebCore::RenderReplaced::paintReplaced):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject):
  • rendering/RenderTable.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintObject):
  • rendering/RenderTableSection.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintObject):
  • rendering/RenderTextControl.h:
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::paintReplaced):
  • rendering/RenderVideo.h:
6:03 PM Changeset in webkit [89982] by agl@chromium.org
  • 3 edits
    6 adds in trunk

2011-06-28 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Skip cache validation on back with HTTPS.
https://bugs.webkit.org/show_bug.cgi?id=63537

  • http/tests/cache/history-only-cached-subresource-loads-max-age-https-expected.txt: Added.
  • http/tests/cache/history-only-cached-subresource-loads-max-age-https.html: Added.
  • http/tests/cache/resources/max-age-resource-forward.html: Added.
  • http/tests/cache/resources/max-age-resource-next.html: Added.
  • http/tests/cache/resources/max-age-resource.html: Added.
  • http/tests/cache/resources/random-max-age.cgi: Added.

2011-06-28 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Skip cache validation on back with HTTPS.
https://bugs.webkit.org/show_bug.cgi?id=63537

For back navigations over HTTP, WebKit sets a flag to use cached data
irrespective of whether it has expired. However, this isn't currently
done for HTTPS.

The logic in question was added in
https://bugs.webkit.org/show_bug.cgi?id=33993 and appears to have been
precautionary. However, both Firefox and IE will use this back
navigation trick for HTTPS as well and so we should probably behave
likewise.

Test: http/tests/cache/history-only-cached-subresource-loads-max-age-https.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
5:58 PM Changeset in webkit [89981] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-06-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Remove errant isShadowBoundary on ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=63588

Removing dead code, no tests for that.

  • dom/ShadowRoot.h: Removed a function that's no longer used.
5:57 PM Changeset in webkit [89980] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-28 Zeng Huiqing <huiqing.zeng@intel.com>

Reviewed by Kenneth Russell.

[chromium]Optimize GraphicsLayerChromium::setChildren()
https://bugs.webkit.org/show_bug.cgi?id=62837

No new tests.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::setChildren): (WebCore::GraphicsLayerChromium::addChild):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
5:53 PM Changeset in webkit [89979] by leviw@chromium.org
  • 14 edits in trunk/Source/WebCore

2011-06-28 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintBoxShadow and paintBoxDecorations to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63577

Switching paintBoxShadow and paintBoxDecorations to layout type abstraction
from more integral types.

No new tests as this is just moving to an abstraction.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxShadow): (WebCore::InlineFlowBox::paintBoxDecorations):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderFieldset.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
  • rendering/RenderView.h:
5:49 PM Changeset in webkit [89978] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-28 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
5:44 PM WebKit Team edited by gavinp@chromium.org
add moi (diff)
5:40 PM WebKit Team edited by bweinstein@apple.com
(diff)
4:56 PM Changeset in webkit [89977] by eae@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-06-28 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch RenderBox position/size to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63571

Switch location and size methods for RenderBox over to the new layout unit abstraction.

No new tests, no functionality changes.

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderInline.cpp:
  • rendering/RenderInline.h:
  • rendering/RenderVideo.cpp:
  • rendering/RenderVideo.h:
4:52 PM Changeset in webkit [89976] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

Unreviewed build correction. Link to correct library for
the zlib1.dll.

  • win/tools/vsprops/WinCairo.vsprops: Don't link to the static

zlib.lib when building for WinCairo.

4:39 PM Changeset in webkit [89975] by commit-queue@webkit.org
  • 27 edits in trunk/Source

2011-06-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89968.
http://trac.webkit.org/changeset/89968
https://bugs.webkit.org/show_bug.cgi?id=63581

Broke chromium windows compile (Requested by jamesr on
#webkit).

  • wtf/Platform.h:

2011-06-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89968.
http://trac.webkit.org/changeset/89968
https://bugs.webkit.org/show_bug.cgi?id=63581

Broke chromium windows compile (Requested by jamesr on
#webkit).

  • WebCore.gyp/WebCore.gyp:
  • loader/cache/CachedFont.cpp:
  • platform/chromium/DragImageRef.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData):

2011-06-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89968.
http://trac.webkit.org/changeset/89968
https://bugs.webkit.org/show_bug.cgi?id=63581

Broke chromium windows compile (Requested by jamesr on
#webkit).

  • WebKit.gyp:
  • features.gypi:
  • public/WebCommon.h:
4:36 PM Changeset in webkit [89974] by leviw@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-06-28 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch PaintMask* to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63576

Switching paintMask* to layout type abstraction from more integral types.

No new tests as this is just moving to an abstraction.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMask): (WebCore::RenderBox::paintMaskImages):
  • rendering/RenderBox.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask):
  • rendering/RenderFieldset.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintMask):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintMask):
  • rendering/RenderTableCell.h:
4:26 PM Changeset in webkit [89973] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-06-28 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Fix sampling build
https://bugs.webkit.org/show_bug.cgi?id=63579

Gets opcode sampling building again, doesn't seem to work alas

  • bytecode/SamplingTool.cpp: (JSC::SamplingTool::notifyOfScope):
  • bytecode/SamplingTool.h: (JSC::SamplingTool::SamplingTool):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::enableSampler):
  • runtime/Executable.h: (JSC::ScriptExecutable::ScriptExecutable):
4:11 PM Changeset in webkit [89972] by diegohcg@webkit.org
  • 7 edits in trunk

2011-06-27 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT support for setInteractiveFormValidationEnabled
https://bugs.webkit.org/show_bug.cgi?id=63496

Unskipped:

fast/forms/interactive-validation-prevented.html
fast/forms/interactive-validation-attach-assertion.html
fast/forms/interactive-validation-assertion-by-validate-twice.html
fast/forms/interactive-validation-select-crash.html
fast/forms/interactive-validation-crash-by-style-override.html

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree):

LayoutTests:

  • platform/qt/Skipped:
4:06 PM Changeset in webkit [89971] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make new-run-webkit-tests -2 actually use WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=63572

new-run-webkit-tests -2 works with this change. However a zillion
tests fail since it can't find the right skipped lists for wk2.
The Skipped-list fixing is covered in bug 63501.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
3:41 PM Changeset in webkit [89970] by leviw@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-06-28 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintFillLayer* to new layout types
https://bugs.webkit.org/show_bug.cgi?id=63570

Switching painFillLayer* to layout type abstraction from more integral types.

No new tests as this is just moving to an abstraction.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.h:
3:33 PM Changeset in webkit [89969] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-28 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Use appropriate macro for CSSPropertyWebkitAppearance in CSSStyleSelector::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=63197

No new tests / no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro and delete duplicate code.
3:27 PM Changeset in webkit [89968] by commit-queue@webkit.org
  • 27 edits in trunk/Source

2011-06-28 Cary Clark <caryclark@google.com>

Reviewed by James Robinson.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

  • wtf/Platform.h: Add switch to use Skia if, externally, Skia has been enabled by a gyp define.

2011-06-28 Cary Clark <caryclark@google.com>

Reviewed by James Robinson.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

No new tests. This does not affect existing
functionality.

  • WebCore.gyp/WebCore.gyp: Include Skia and related files and exclude CG and related files when building Chromium for Skia on the Mac.
  • loader/cache/CachedFont.cpp: Rename CHROME to CHROMIUM.
  • platform/chromium/DragImageRef.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::hash):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Ditto.

2011-06-28 Cary Clark <caryclark@google.com>

Reviewed by James Robinson.

Use Skia if Skia on Mac Chrome is enabled
https://bugs.webkit.org/show_bug.cgi?id=62999

  • WebKit.gyp: If building for Skia, exclude CG files. If not, exclude Skia files.
  • features.gypi: Enable Skia on Chromium Mac if so instructed by the gyp define. Allow Skia to be hardware accelerated on the Mac.
  • public/WebCommon.h: If Skia is defined on the Mac, define it in the WebXXX interfaces as well.
3:15 PM Changeset in webkit [89967] by Nate Chapin
  • 1 edit
    16 adds in trunk/LayoutTests

2011-06-28 Nate Chapin <Nate Chapin>

Unreviewed, chromium test update for r89951.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-tref-03-b-change-href-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-change-href-expected.png: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
  • platform/chromium-win/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.
3:09 PM Changeset in webkit [89966] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-06-28 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Roben.

Add more machines to Chromium Mac Release and Chromium Mac Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=63500

Added google-mac-3 and google-mac-4.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:06 PM Changeset in webkit [89965] by eric@webkit.org
  • 10 edits in trunk/Tools

2011-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Dirk Pranke.

Remove webkitpy's tiger support now that WebKit no longer supports tiger
https://bugs.webkit.org/show_bug.cgi?id=63568

I don't think our support actually fully worked anyway. Regardless
tiger is dead now (thankfully)!

I also unwrapped some short lines and added a couple FIXMEs while
touring the code.

No new tests, only removing old ones which tested our Tiger support.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2:51 PM Changeset in webkit [89964] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-28 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

ASSERT when launching debug builds with interpreter and jit enabled
https://bugs.webkit.org/show_bug.cgi?id=63566

Add appropriate guards to the various Executable's memory reporting
logic.

  • runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal):
2:51 PM Changeset in webkit [89963] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-28 Eric Seidel <eric@webkit.org>

Unreviewed, just fixing a typo.

Fix misspellings of "thead" to "thread".

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:44 PM Changeset in webkit [89962] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Tony Chang.

new-run-webkit-tests needs a --webkit-test-runner option
https://bugs.webkit.org/show_bug.cgi?id=63439

This was accidentally fixed in bug 63501 as well.
The root problem here was that the webkit unit tests were not using
enough mocks. I've fixed them here to use more mocks
which should unbreak windows.

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2:33 PM Changeset in webkit [89961] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63563
DFG JIT - add support for double arith to speculative path

Reviewed by Oliver Hunt.

Add integer support for div & mod, add double support for div, mod,
add, sub & mul, dynamically selecting based on operand types.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::FPRTemporary::FPRTemporary):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::assembler):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::~SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::index):
(JSC::DFG::SpeculateDoubleOperand::fpr):

2:28 PM Changeset in webkit [89960] by jamesr@google.com
  • 10 edits in branches/chromium/782/Source

Merge 89635 - 2011-06-23 John Bates <jbates@google.com>

Reviewed by James Robinson.

Fix latch deadlock when GPU process crashes or context is lost.
https://bugs.webkit.org/show_bug.cgi?id=63189
The main bug fix is to only set/wait latches if the child context has no errors.
Additionally, the LayerChromium classes needed to be modified to not continue drawing when
their corresponding contexts have errors. Otherwise, they would draw with invalid texture ids.

Test: open particles WebGL demo in chrome, kill GPU process from Task Manager; observe no deadlock.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::isCompositorContextLost):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::drawsContent): (WebCore::WebGLLayerChromium::updateCompositorResources): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::drawsContent):
  • platform/graphics/chromium/Canvas2DLayerChromium.h:

2011-06-23 John Bates <jbates@google.com>

Reviewed by James Robinson.

Fix latch deadlock when GPU process crashes or context is lost
https://bugs.webkit.org/show_bug.cgi?id=63189

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):

BUG=84065
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7274032

2:18 PM Changeset in webkit [89959] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix interpreter build.

2:13 PM Changeset in webkit [89958] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebKit/qt

2011-06-28 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Use <QtX/x.h> style of headers for Qt tests which rely on it.
https://bugs.webkit.org/show_bug.cgi?id=63562

Some Qt auto-tests rely on <QtX/x.h> types of includes.

  • Api/qwebkitplatformplugin.h:
  • symbian/platformplugin/qwebkitplatformplugin.h:
2:06 PM Changeset in webkit [89957] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63561
DFG JIT - don't always assume integer in relational compare

Reviewed by Oliver Hunt.

If neither operand is known integer, or either is in double representation,
then at least use a function call (don't bail off the speculative path).

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isDataFormatDouble):
(JSC::DFG::SpeculativeJIT::compareIsInteger):

1:47 PM Changeset in webkit [89956] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Make constant array optimisation less strict about what constitutes a constant
https://bugs.webkit.org/show_bug.cgi?id=63554

Patch by Oliver Hunt <oliver@apple.com> on 2011-06-28
Reviewed by Gavin Barraclough.

Now allow string constants in array literals to actually be considered constant,
and so avoid codegen in array literals with strings in them.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addConstantBuffer):
(JSC::CodeBlock::constantBuffer):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addConstantBuffer):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitNewArray):

  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

1:34 PM Changeset in webkit [89955] by Nate Chapin
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-28 Nate Chapin <Nate Chapin>

Unreviewed, chromium test update for r89946.

  • platform/chromium/fast/regex: Added.
  • platform/chromium/fast/regex/constructor-expected.txt: Added.
1:21 PM Changeset in webkit [89954] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-06-28 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Make constant array optimisation less strict about what constitutes a constant
https://bugs.webkit.org/show_bug.cgi?id=63554

Now allow string constants in array literals to actually be considered constant,
and so avoid codegen in array literals with strings in them.

  • bytecode/CodeBlock.h: (JSC::CodeBlock::addConstantBuffer): (JSC::CodeBlock::constantBuffer):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addConstantBuffer): (JSC::BytecodeGenerator::addStringConstant): (JSC::BytecodeGenerator::emitNewArray):
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
1:09 PM Changeset in webkit [89953] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-28 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
1:09 PM QtWebKitContrib edited by Ademar Reis
(diff)
1:07 PM Changeset in webkit [89952] by rniwa@webkit.org
  • 13 edits in trunk/Source/WebCore

2011-06-28 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Stop instantiating Position with PositionIsOffsetInAnchor in various files
https://bugs.webkit.org/show_bug.cgi?id=63384

Refactoring.

Removed many if conditions that compared the anchor type to Position::PositionIsOffsetInAnchor
because there were also checking that containerNode is a text node.

Also added Position::containerText() to avoid manually casting containerNode().

  • dom/Position.cpp: (WebCore::Position::Position): Added an assertion to ensure BeforeChildren/AfterChildren anchor type won't be used for a node whose contents is ignored by editing. (WebCore::Position::containerText): Added.
  • dom/Position.h:
  • editing/ApplyBlockElementCommand.cpp: (WebCore::isNewLineAtPosition): Removed a redundant comparison of anchor type. (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): Since containerNode is always a text node when renderStyleOfEnclosingTextNode returns a render style, use new Position constructor that takes Text* and offset. (WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded): Removed redundant comparison of anchor type and use new Position constructor that takes Text* and offset.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::splitTextAtStart): Replaced an assertion that compared anchor type by an assertion that the container node is a text node; use new constructor. (WebCore::ApplyStyleCommand::splitTextAtEnd): Ditto; also added early exits in the case script modified DOM. (WebCore::ApplyStyleCommand::splitTextElementAtStart): Ditto. (WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto. (WebCore::ApplyStyleCommand::joinChildTextNodes): Use new constructor.
  • editing/CompositeEditCommand.cpp: (WebCore::Editor::replaceSelectedTextInNode): Calls containerText instead of manually casting containerNode.
  • editing/Editor.cpp: (WebCore::Editor::canDeleteRange): Call Range::startPosition instead of manually instantiating Position by calling startContainer and startOffset.
  • editing/FrameSelection.cpp: (WebCore::FrameSelection::setSelectedRange): Ditto.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Calls containerText instead of manually casting containerNode.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Calls containerText instead of manually casting containerNode.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): Removed a redundant anchor type comparison. (WebCore::startVisiblePosition): Call Range::startPosition instead of startContainer and startOffset. (WebCore::endVisiblePosition): Call Range::endPosition instead of endContainer and endOffset.
  • editing/htmlediting.cpp: (WebCore::firstInSpecialElement): Call containerNode() to address <rdar://problem/5027702>. (WebCore::lastInSpecialElement): Ditto; use new constructor.
  • editing/visible_units.cpp: (WebCore::endPositionForLine): Use new constructor. (WebCore::startOfParagraph): Ditto. (WebCore::endOfParagraph): Ditto.
1:04 PM Changeset in webkit [89951] by rwlbuis@webkit.org
  • 6 edits
    19 adds in trunk

2011-06-28 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

SVG1.1SE test text-tref-03-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63390

Support tref on forward referenced content by listening to DOMSubtreeModified events. This also
allows updating after modifications in the referenced content subtree.

Tests: svg/W3C-SVG-1.1-SE/text-tref-03-b.svg

svg/custom/text-tref-03-b-change-href-dom.svg
svg/custom/text-tref-03-b-change-href.svg
svg/custom/text-tref-03-b-dynamic.svg
svg/custom/text-tref-03-b-dynamic2.svg
svg/custom/text-tref-03-b-referenced-element-removal.svg
svg/custom/text-tref-03-b-tref-removal.svg

  • svg/SVGTRefElement.cpp: (WebCore::SubtreeModificationEventListener::create): (WebCore::SubtreeModificationEventListener::cast): (WebCore::SubtreeModificationEventListener::removeFromTarget): (WebCore::SubtreeModificationEventListener::SubtreeModificationEventListener): (WebCore::SubtreeModificationEventListener::operator==): (WebCore::SubtreeModificationEventListener::handleEvent): (WebCore::SVGTRefElement::updateReferencedText): (WebCore::SVGTRefElement::parseMappedAttribute): (WebCore::SVGTRefElement::svgAttributeChanged): (WebCore::SVGTRefElement::buildPendingResource): (WebCore::SVGTRefElement::removedFromDocument):
  • svg/SVGTRefElement.h:

2011-06-28 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

SVG1.1SE test text-tref-03-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=63390

  • text-tref-03-b.svg, the w3c SVG1.1 testcase mentioned in the bug.
  • text-tref-03-b-dynamic.svg, tests dynamically adding the tref.
  • text-tref-03-b-dynamic2.svg, tests dynamically adding the referenced content.
  • text-tref-03-b-tref-removal.svg, tests removal of tref.
  • text-tref-03-b-referenced-element-removal.svg, tests removal of referenced content.
  • text-tref-03-b-change-href.svg, tests changing href attribute dynamically through setAttribute.
  • text-tref-03-b-change-href-dom.svg, tests changing href attribute dynamically through href animated property.
  • foreignObject/text-tref-02-b.svg has improved result, but is still not perfect.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/mac/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
  • platform/mac/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
  • platform/mac/svg/custom/text-tref-03-b-change-href-expected.png: Added.
  • platform/mac/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
  • platform/mac/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
  • platform/mac/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
  • platform/mac/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
  • platform/mac/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
  • svg/W3C-SVG-1.1-SE/text-tref-03-b.svg: Added.
  • svg/custom/text-tref-03-b-change-href-dom.svg: Added.
  • svg/custom/text-tref-03-b-change-href.svg: Added.
  • svg/custom/text-tref-03-b-dynamic-expected.txt: Added.
  • svg/custom/text-tref-03-b-dynamic.svg: Added.
  • svg/custom/text-tref-03-b-dynamic2-expected.txt: Added.
  • svg/custom/text-tref-03-b-dynamic2.svg: Added.
  • svg/custom/text-tref-03-b-referenced-element-removal.svg: Added.
  • svg/custom/text-tref-03-b-tref-removal.svg: Added.
12:37 PM Changeset in webkit [89950] by inferno@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-28 Abhishek Arya <inferno@chromium.org>

Reviewed by Anders Carlsson.

Split the string creation into a local (while creating text runs)
so that it is not destroyed prematurely.
https://bugs.webkit.org/show_bug.cgi?id=63543

Run fast/forms/text-control-intrinsic-widths.html under valgrind/ASAN.

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::computePreferredLogicalWidths): this one is just done for caution, in case, we don't do the same mistake when adding legacy rounding hacks option.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::getAvgCharWidth):
12:33 PM Changeset in webkit [89949] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Tony Chang.

new-run-webkit-tests should not run mthml tests when MHTML support is disabled
https://bugs.webkit.org/show_bug.cgi?id=63549

This way mhtml tests won't show up as "missing" results on all non-chromium platforms.
I happen to go looking for what code was deciding that .mht was a supported
extension, found test_files.py and then removed some redundant doc-strings and
if branching.

  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12:19 PM Changeset in webkit [89948] by commit-queue@webkit.org
  • 11 edits in trunk

2011-06-28 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Update migration LayoutTest to include indexes and successful migration.
https://bugs.webkit.org/show_bug.cgi?id=62780

  • storage/indexeddb/migrate-basics-expected.txt:
  • storage/indexeddb/migrate-basics.html:

2011-06-28 Greg Simon <gregsimon@chromium.org>

Reviewed by Dimitri Glazkov.

Migrate SQLite backing store to LevelDB backing store for Indexeddb.
https://bugs.webkit.org/show_bug.cgi?id=62780

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::computeFileIdentifier): (WebCore::computeUniqueIdentifier): (WebCore::IDBFactoryBackendImpl::open): (WebCore::migrateObjectStores): (WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB):
  • storage/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::backingStoreExists):
  • storage/IDBLevelDBBackingStore.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::populateIndex):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBSQLiteBackingStore.cpp: (WebCore::IDBSQLiteBackingStore::backingStoreExists):
  • storage/IDBSQLiteBackingStore.h:
12:01 PM Changeset in webkit [89947] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-06-28 Chang Shu <cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Random crashes in fast/frames/ tests
https://bugs.webkit.org/show_bug.cgi?id=63459

Investigation on the crashes has revealed that sometimes, a frame could
have been destroyed before it is removed from the hierachy in Qt WebKit2 UI process.
The root cause lies in the fact that the order of the two contiguous asynchronous
messages may not be respected on the receiving side. And it is Qt's implementation,
which uses QTimer::startTimer(0), that causes the reverse order. This patch replaces
the timer approach with QMetaObject::invokeMethod approach and no crash happens afterwards.

  • Platform/qt/WorkQueueQt.cpp: (WorkQueue::scheduleWork):
11:35 AM Changeset in webkit [89946] by barraclough@apple.com
  • 4 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=55040
RegExp constructor returns the argument regexp instead of a new object

Reviewed by Oliver Hunt.

Per 15.10.3.1, our current behaviour is correct if called as a function,
but incorrect when called as a constructor.

Source/JavaScriptCore:

  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):
(JSC::constructWithRegExpConstructor):

  • runtime/RegExpConstructor.h:

LayoutTests:

  • fast/regex/constructor-expected.txt: Added.
  • fast/regex/constructor.html: Added.
  • fast/regex/script-tests/constructor.js: Added.
11:31 AM Changeset in webkit [89945] by leviw@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

2011-06-28 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Create intermediate classes as a path towards getting off of pixel offsets
https://bugs.webkit.org/show_bug.cgi?id=61896

Creating three intermediate typedefs to aid in moving layout and hit testing from integers
to floats. We'll transition the render tree over to these intermediate types and add
infrastructure to support the new types behind USE(FLOAT_LAYOUT_OFFSETS). This allows the ultimate
changeover to be easier.

Switching LayoutState over to this abstraction to verify it works correctly.

No new tests since this is creating a new abstraction, not changing current behavior.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): (WebCore::LayoutState::pageLogicalOffset): (WebCore::LayoutState::addForcedColumnBreak):
  • rendering/LayoutState.h:
  • rendering/LayoutTypes.h: Added.
11:29 AM Changeset in webkit [89944] by rolandsteiner@chromium.org
  • 2 edits in trunk/Tools

2011-06-28 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Tony Chang.

Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
https://bugs.webkit.org/show_bug.cgi?id=63514

  • change write_text_file to write_binary_file
  • check that text_path and binary_path are actually existant files
  • change cleanup block from 'except' to 'finally'
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
11:26 AM Changeset in webkit [89943] by macpherson@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-28 Luke Macpherson <macpherson@chromium.org>

Reviewed by Darin Adler.

Clean up integer clamping functions in MathExtras.h and support arbitrary numeric types and limits.
https://bugs.webkit.org/show_bug.cgi?id=63469

  • wtf/MathExtras.h: (defaultMinimumForClamp): Version of std::numeric_limits::min() that returns the largest negative value for floating point types. (defaultMaximumForClamp): Symmetric alias for std::numeric_limits::max() (clampTo): New templated clamping function that supports arbitrary output types. (clampToInteger): Use new clampTo template. (clampToFloat): Use new clampTo template. (clampToPositiveInteger): Use new clampTo template.
11:24 AM Changeset in webkit [89942] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Add fullscreen.css and fullscreenQuickTime.css to the WebCore Visual Studio project for convenience.
Looks like Visual Studio also re-sorted one more file since my last checkin.

  • WebCore.vcproj/WebCore.vcproj:
11:21 AM Changeset in webkit [89941] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

  • WebCore.vcproj/WebCore.vcproj:
10:55 AM Changeset in webkit [89940] by joone.hur@collabora.co.uk
  • 4 edits in trunk

2011-06-28 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Rename 3D transforms to 3D rendering
https://bugs.webkit.org/show_bug.cgi?id=63508

WebKitGtk+ provides the 3D transforms feature, but it was
renamed to 3D Rendering. This features supports CSS 3D trasnforms.

  • configure.ac: Rename ENABLE_3D_TRANSFORMS to ENABLE_3D_RENDERING.

2011-06-28 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Rename 3D transforms to 3D rendering
https://bugs.webkit.org/show_bug.cgi?id=63508

This patch allows to include ENABLE_3D_RENDERING to build WebKitGtk+.

  • GNUmakefile.am: Add ENABLE_3D_RENDERING
9:58 AM Changeset in webkit [89939] by jhawkins@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-06-27 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Pass an optional WebNode that is the node receiving the context menu action.
https://bugs.webkit.org/show_bug.cgi?id=63503

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::pluginContainerFromNode): (WebKit::WebFrameImpl::executeCommand): (WebKit::WebFrameImpl::printBegin):
  • src/WebFrameImpl.h:
9:48 AM Changeset in webkit [89938] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-22 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: use column numbers when linking to script location in timeline and console.
https://bugs.webkit.org/show_bug.cgi?id=63126

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
9:27 AM Changeset in webkit [89937] by joone.hur@collabora.co.uk
  • 5 edits
    3 adds in trunk/Source

2011-06-28 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Allow to build WebKitGtk+ with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=63404

WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms
and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.

  • GNUmakefile.list.am:
  • platform/graphics/clutter/GraphicsLayerClutter.cpp: Added. (WebCore::GraphicsLayer::create): Not implemented yet. (WebCore::GraphicsLayerClutter::GraphicsLayerClutter): (WebCore::GraphicsLayerClutter::~GraphicsLayerClutter): (WebCore::GraphicsLayerClutter::setNeedsDisplay): Ditto. (WebCore::GraphicsLayerClutter::setNeedsDisplayInRect): Ditto.
  • platform/graphics/clutter/GraphicsLayerClutter.h: Added.

2011-06-28 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Allow to build WebKitGtk+ with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=63404

WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms
and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::attachRootGraphicsLayer): not implemented yet. (WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization): Ditto. (WebKit::ChromeClient::scheduleCompositingLayerSync): Ditto. (WebKit::ChromeClient::allowedCompositingTriggers): Ditto.
  • WebCoreSupport/ChromeClientGtk.h:
9:23 AM Changeset in webkit [89936] by jberlin@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Better Windows rebaseline for the changes in r89864, with pixel results, to get the bots
green.

  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.txt:
9:08 AM Changeset in webkit [89935] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs to implement undo client (Windows).
https://bugs.webkit.org/show_bug.cgi?id=58103

Add another undo test to the win-wk2 skipped list to get the bots green.

  • platform/win-wk2/Skipped:
9:01 AM Changeset in webkit [89934] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-28 Stephen White <senorblanco@chromium.org>

Unreviewed.

Remove some now-passing tests from Chromium's test expectations.

  • platform/chromium/test_expectations.txt:
8:56 AM Changeset in webkit [89933] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r89733): fast/text/zero-font-size.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=63512

Reviewed by Darin Adler.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformWidthForGlyph): Initialize the advance local variable, because
on Leopard wkGetGlyphTransformedAdvances can return successfully yet not update the variable when
the font size is 0. Presumably, r89733 exposed this by changing the values put on the stack just
before this function is called.

8:42 AM Changeset in webkit [89932] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit/win

2011-06-27 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Avoid attempt to create a zero-size DIB.
https://bugs.webkit.org/show_bug.cgi?id=63484.

  • WebNodeHighlight.cpp: (WebNodeHighlight::update): Check for zero-height (or zero-width) region for DIB, and exit early if attempting to create a zero-size DIB/BITMAP.
8:24 AM Changeset in webkit [89931] by caseq@chromium.org
  • 4 edits
    1 delete in trunk

2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on SnowLeopard Intel Release (Tests), Windows 7 Release (Tests), Qt
https://bugs.webkit.org/show_bug.cgi?id=63178

  • http/tests/inspector/extensions-resources-redirect-expected.txt:
  • platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt: Removed.
  • platform/qt/Skipped:
8:15 AM Changeset in webkit [89930] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-28 Ryosuke Niwa <rniwa@webkit.org>

Fix the test added by the previous commit. Also add it to the WebKit2's skipped list
since it uses a eventSender method that hasn't been implemented by TestRunner.

  • fast/events/selectstart-prevent-selection-on-right-click.html:
  • platform/mac-wk2/Skipped:
8:09 AM Changeset in webkit [89929] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-28 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Add a test for canceling selectstart when a word is selected by right click
https://bugs.webkit.org/show_bug.cgi?id=63530

Add a regression now that the bug no longer reproduces.

  • fast/events/selectstart-prevent-selection-on-right-click-expected.txt: Added.
  • fast/events/selectstart-prevent-selection-on-right-click.html: Added.
7:51 AM Changeset in webkit [89928] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-28 Stephen White <senorblanco@chromium.org>

Unreviewed.

Chromium test_expectations update.

  • platform/chromium/test_expectations.txt:
7:39 AM Changeset in webkit [89927] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows Debug build fix after r89885

JSGlobalData::releaseExecutableMemory for jsc.exe's benefit.

7:39 AM Changeset in webkit [89926] by Adam Roben
  • 4 edits in trunk/Tools

Roll out r89924 and r89925

I didn't mean to commit them!

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
7:34 AM Changeset in webkit [89925] by Adam Roben
  • 2 edits in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures

Keep track of all builds

7:33 AM Changeset in webkit [89924] by Adam Roben
  • 3 edits in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures

Start categorizing flaky tests

7:22 AM Changeset in webkit [89923] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source/WebKit/qt

2011-06-28 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Use QtQuick imports in Api tests rather than old deprecated Qt 4.x imports.
https://bugs.webkit.org/show_bug.cgi?id=63533

We need to use the new QtQuick 1.x imports rather than the old deprecated
version.

  • tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml:
  • tests/qdeclarativewebview/resources/webviewtest.qml:
  • tests/qdeclarativewebview/resources/webviewtestdefault.qml:
5:07 AM Changeset in webkit [89922] by apavlov@chromium.org
  • 11 edits in trunk

2011-06-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
https://bugs.webkit.org/show_bug.cgi?id=63446

  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:

2011-06-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
https://bugs.webkit.org/show_bug.cgi?id=63446

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::computePseudoClassMask): (WebCore::InspectorCSSAgent::getStylesForNode):
  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):
4:42 AM Changeset in webkit [89921] by kbalazs@webkit.org
  • 4 edits in trunk

2011-06-28 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[X11][WK2] X error with plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63520

  • platform/qt-wk2/Skipped:

2011-06-28 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[X11][WK2] X error with plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63520

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Never create a pixmap with (0,0) dimensions. (WebKit::NetscapePlugin::platformGeometryDidChange): (WebKit::NetscapePlugin::platformPaint):
4:38 AM Changeset in webkit [89920] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

2011-06-28 Michal Pakula vel Rutka <Michał Pakuła vel Rutka>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement EditorClientEfl::respondToChangedSelection
https://bugs.webkit.org/show_bug.cgi?id=63525

This patch:

  • implements EditorClientEfl::respondToChangedSelection,
  • adds ewk_frame_editor_client_selection_changed and
  • ewk_view_editor_client_selection_changed
  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::respondToChangedSelection):
  • ewk/ewk_frame.cpp: (ewk_frame_editor_client_selection_changed):
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (ewk_view_editor_client_selection_changed):
2:59 AM Changeset in webkit [89919] by tkent@chromium.org
  • 5 edits
    2 adds in trunk/LayoutTests

2011-06-28 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

Verify cloning elements with validation messages works.
https://bugs.webkit.org/show_bug.cgi?id=61988

  • fast/forms/validation-message-clone-expected.txt: Added.
  • fast/forms/validation-message-clone.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
2:54 AM Changeset in webkit [89918] by commit-queue@webkit.org
  • 1 edit
    1 move
    1 add
    11 deletes in trunk/LayoutTests

2011-06-28 Wyatt Carss <wcarss@chromium.org>

Reviewed by Hajime Morita.

convert editing/deleting/4845371.html to runDumpAsTextEditingTest
https://bugs.webkit.org/show_bug.cgi?id=63214

Renamed editing/deleting/4845371.html to editing/deleting/delete-cell-contents.html
and converted editing/deleting/delete-cell-contents.html to runDumpAsTextEditingTest; left
it without a doctype, etc, because they changed functionality of the image test. Also
added the rdar number.

  • editing/deleting/delete-cell-contents-expected.txt: Added.
  • editing/deleting/delete-cell-contents.html: Added.
  • editing/deleting/4845371.html: Removed.
  • platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/deleting/4845371-expected.png: Removed.
  • platform/chromium-win/editing/deleting/4845371-expected.png: Removed.
  • platform/chromium-win/editing/deleting/4845371-expected.txt: Removed.
  • platform/gtk/editing/deleting/4845371-expected.png: Removed.
  • platform/gtk/editing/deleting/4845371-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/4845371-expected.png: Removed.
  • platform/mac/editing/deleting/4845371-expected.png: Removed.
  • platform/mac/editing/deleting/4845371-expected.txt: Removed.
  • platform/qt/editing/deleting/4845371-expected.png: Removed.
  • platform/qt/editing/deleting/4845371-expected.txt: Removed.
2:53 AM Changeset in webkit [89917] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-28 Kent Tamura <tkent@chromium.org>

Fix a build error on Mac by r89907.

  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::endListChanged):
2:52 AM Changeset in webkit [89916] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Kent Tamura.

[Chromium] SELECT or autofill popup is trimmed by screen edge on Windows
https://bugs.webkit.org/show_bug.cgi?id=63438

If the popup is calculated to be trimmed by a screen edge, an attempt is made
to alter its vertical edge alignment (set to the right edge for LTR or to the left edge for RTL)
to see if the trimmed portion becomes smaller than that with the original layout.
The change involves remembering the original frameRect for the popup and restoring it in refresh().
This is due to the fact that the frameRect originally set in showInRect() is overwritten
by layoutAndGetRTLOffset(), which breaks the originally requested popup container layout metrics.
The max width is reset on every layoutAndCalculateWidgetRect(), as it can be constrained by the screen edge,
and thus should be re-checked every time the popup is displayed, in case the browser window has been moved.

Tests: manual-tests/popup-width-restriction-within-screen.html partly covers the fix (should not regress).
Other than that, there is no way to unit-test the platform-specific native code.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::setMaxWidth): Added. Avoid duplicate popup content layouts (in contrast with setMaxWidthAndLayout()). (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Attempt a left-right popup alignment inversion to minimize the trimmed content. Also restore a default max popup width. (WebCore::PopupContainer::layoutAndGetRTLOffset): Always return the popup listbox offset for the RTL (right alignment) case. The method rename is due to the return value semantics change. (WebCore::PopupContainer::showInRect): Store the originally requested frameRect for the popup. (WebCore::PopupContainer::refresh): Restore the original popup frameRect to avoid layout artifacts on refresh. (WebCore::PopupContainer::isRTL): This check should be made by the layoutAndGetRTLOffset() clients.
  • platform/chromium/PopupMenuChromium.h:
2:46 AM Changeset in webkit [89915] by commit-queue@webkit.org
  • 8 edits in trunk

2011-06-28 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Allow spaces between e-mail addresses in 'email' input type.
https://bugs.webkit.org/show_bug.cgi?id=55987

Allowed spaces between e-mail addresses in 'email' input type,
e.g. ' a@p.com , b@p.com ' is a valid value. Implemented the
value sanitization algorithm for an e-mail value. Added more unit
tests that check the e-mail value parser.

  • fast/forms/ValidityState-typeMismatch-email-expected.txt:
  • fast/forms/resources/ValidityState-typeMismatch-email.js:

2011-06-28 Kentaro Hara <haraken@google.com>

Reviewed by Kent Tamura.

Allow spaces between e-mail addresses in 'email' input type.
https://bugs.webkit.org/show_bug.cgi?id=55987

Allowed spaces between e-mail addresses in 'email' input type,
e.g. ' a@p.com , b@p.com ' is a valid value. Implemented the
value sanitization algorithm for an e-mail value. Added more unit
tests that check the e-mail value parser.

Test: fast/forms/ValidityState-typeMismatch-email.html

  • html/EmailInputType.cpp: (WebCore::EmailInputType::typeMismatchFor): (WebCore::EmailInputType::sanitizeValue):
  • html/EmailInputType.h:
  • html/parser/HTMLParserIdioms.cpp: (WebCore::stripHTMLLineBreaks):
  • html/parser/HTMLParserIdioms.h: (WebCore::isHTMLLineBreak):
2:44 AM Changeset in webkit [89914] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Qt specific results committed in r89901, but some of them fail on Qt-WK2 and/or Qt-Mac platform

  • platform/qt-mac/Skipped: Skip failing tests and typo fix.
  • platform/qt-wk2/Skipped: Skip failing tests.
2:30 AM Changeset in webkit [89913] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-28 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

Refactor RenderTextControl::text().
https://bugs.webkit.org/show_bug.cgi?id=63519

No new tests because this is just a refactoring.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue): Resuce the number of text() calls. (WebCore::finishText):
    • Use StringBuilder.
    • Make this a static function. This function doesn't access anything of RenderTextControl.

(WebCore::RenderTextControl::text):

Use emptyString() and StringBuilder.

(WebCore::RenderTextControl::textWithHardLineBreaks): ditto.

  • rendering/RenderTextControl.h: Remove finishText().
2:28 AM Changeset in webkit [89912] by yurys@chromium.org
  • 5 edits in trunk

2011-06-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console.group messages should never be coalesced
https://bugs.webkit.org/show_bug.cgi?id=63521

  • inspector/console/console-nested-group-expected.txt:
  • inspector/console/console-nested-group.html:

2011-06-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console.group messages should never be coalesced
https://bugs.webkit.org/show_bug.cgi?id=63521

  • inspector/InspectorConsoleAgent.cpp: (WebCore::isGroupMessage): (WebCore::InspectorConsoleAgent::addConsoleMessage):
2:26 AM Changeset in webkit [89911] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: console group boundaries should be more distinct in UI
https://bugs.webkit.org/show_bug.cgi?id=63455

Show grey bracket to on the left side of a console group message to highlight
the group extent.

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleGroup):
  • inspector/front-end/inspector.css: (#console-prompt): (.console-message, .console-user-command): (.console-message::before, .console-user-command::before, #console-prompt::before, .console-group-title::before): (.console-group-title::before): (.console-group): (.console-group-bracket): (.console-group.collapsed > .console-group-bracket):
2:20 AM Changeset in webkit [89910] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-28 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

Use RefPtr for the HTMLElement data members of TextFieldInptType
and SearchInputType.
https://bugs.webkit.org/show_bug.cgi?id=63511

No new tests because of no behavior change.

  • html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): No need to initialize the element members explicitly because RefPtr constructor works well. (WebCore::SearchInputType::createShadowSubtree): Substitute an element to a data member, and don't call RefPtr<>::release(). (WebCore::SearchInputType::innerBlockElement): Moved from the header file, and adjustment for RefPtr<>. (WebCore::SearchInputType::resultsButtonElement): ditto. (WebCore::SearchInputType::cancelButtonElement): ditto. (WebCore::SearchInputType::destroyShadowSubtree): Adjustment for RefPtr<>.
  • html/SearchInputType.h:
    • Move accessor functions to the cpp file because they are virtual.
    • Change element data member types: HTMLElement* -> RefPtr<HTMLElement>.
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): No need to initialize the element members explicitly because RefPtr constructor works well. (WebCore::TextFieldInputType::~TextFieldInputType): Explicityly defines the destructor in the cpp file to avoid to make it implicitly in the header file. If the destructor was made in the header file, we would need to include HTMLElement.h in the header file. (WebCore::TextFieldInputType::createShadowSubtree):
  • Don't call RenderTheme::themeForPage().
  • Substitute an element to a data member, and don't call RefPtr<>::release(). (WebCore::TextFieldInputType::setInnerTextElement): Moved from the header file to avoid to include HTMLElement.h. (WebCore::TextFieldInputType::setSpeechButtonElement): ditto. (WebCore::TextFieldInputType::innerTextElement): Moved from the header file, and adjustment for RefPtr<>. (WebCore::TextFieldInputType::innerSpinButtonElement): ditto. (WebCore::TextFieldInputType::speechButtonElement): ditto. (WebCore::TextFieldInputType::destroyShadowSubtree): Adjustment for RefPtr<>.
  • html/TextFieldInputType.h:
    • Move accessor functions to the cpp file because they are virtual.
    • Change element data member types: HTMLElement* -> RefPtr<HTMLElement>.
2:19 AM Changeset in webkit [89909] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-28 Pavel Feldman <pfeldman@google.com>

Not reviewed: added chromium test suppression.

  • platform/chromium/test_expectations.txt:
2:12 AM Changeset in webkit [89908] by kbalazs@webkit.org
  • 4 edits in trunk

2011-06-28 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[X11][WK2] plugins/plugin-javascript-access fails
https://bugs.webkit.org/show_bug.cgi?id=63464

  • platform/qt-wk2/Skipped:

2011-06-28 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[X11][WK2] plugins/plugin-javascript-access fails
https://bugs.webkit.org/show_bug.cgi?id=63464

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp: (WebKit::NetscapePluginModule::getPluginInfo): Determine the name of the plugin.
1:58 AM Changeset in webkit [89907] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-28 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

SVG animation flickers when restarting
https://bugs.webkit.org/show_bug.cgi?id=18450

Add new parameter to the following methods. The new parameter is the time of adding a "begin" or "end" time to the SVG animation.

  • WebCore::SVGSMILElement::addBeginTime
  • WebCore::SVGSMILElement::beginListChanged
  • WebCore::SVGSMILElement::addEndTime
  • WebCore::SVGSMILElement::endListChanged

In case of beginTime and beginListChanged it's necessary, because the delay between the event of adding a new begin time
(in WebCore::SVGAnimationElement::beginElementAt) and the actual processing (in WebCore::SVGSMILElement::endListChanged)
is significant. In lack of event time we can't decide that we should consider the new time or not.
If the new begin time is smaller than the event time, we musn't begin the animation, else we shoud do further calculations.

The following methods just modified for consistency:

  • WebCore::SVGSMILElement::addEndTime
  • WebCore::SVGSMILElement::endListChanged

No new tests, because currently there is no way to test SVG flickering at zero time.

  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::beginElementAt): (WebCore::SVGAnimationElement::endElementAt):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::attributeChanged): (WebCore::SVGSMILElement::addBeginTime): (WebCore::SVGSMILElement::addEndTime): (WebCore::SVGSMILElement::beginListChanged): (WebCore::SVGSMILElement::endListChanged): The body changed:
    • Use new parameter, the time of adding the new begin time.
    • Cancel some incorrect optimalization. We should also do further calculations when elapsed >= m_intervalBegin.

(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):
(WebCore::SVGSMILElement::handleConditionEvent):
(WebCore::SVGSMILElement::beginByLinkActivation):

  • svg/animation/SVGSMILElement.h:
1:53 AM Changeset in webkit [89906] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-06-28 Shinya Kawanaka <shinyak@google.com>

Reviewed by Kent Tamura.

Add const to show() method in WTFString and AtomicString.
https://bugs.webkit.org/show_bug.cgi?id=63515

The lack of const in show() method is painful when
doing something like printf-debug.

  • wtf/text/AtomicString.cpp: (WTF::AtomicString::show):
  • wtf/text/AtomicString.h:
  • wtf/text/WTFString.cpp: (String::show):
  • wtf/text/WTFString.h:
1:48 AM Changeset in webkit [89905] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

2011-06-28 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Change permission of some ewk files.
https://bugs.webkit.org/show_bug.cgi?id=63517

Change some file's permission same with other file's.

  • ewk/ewk_tiled_backing_store.c:
  • ewk/ewk_tiled_model.c:
  • ewk/ewk_view_single.c:
1:46 AM Changeset in webkit [89904] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Adding MHTML reading support.
https://bugs.webkit.org/show_bug.cgi?id=7168

Reviewed by Andreas Kling.

  • features.pri: Disable MHTML on Qt by default in a proper way.
1:46 AM Changeset in webkit [89903] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Remove ENABLE_XBL, because there aren't ENABLE(XBL) macros anymore.

Reviewed by Andreas Kling.

  • features.pri:
1:02 AM Changeset in webkit [89902] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/misc/link-rel-icon-beforeload.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=63518

  • platform/qt/Skipped: Add http/tests/misc/link-rel-icon-beforeload.html until fix.
12:55 AM Changeset in webkit [89901] by Csaba Osztrogonác
  • 2 edits
    30 adds in trunk/LayoutTests

[Qt] Unreviewed daily gardening. Add platform specific expected files
for new passing tests and add failing new tests to the Skipped list.

  • platform/qt/Skipped:
  • platform/qt/editing/selection/extend-inside-transforms-backward-expected.png: Added.
  • platform/qt/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
  • platform/qt/editing/selection/extend-inside-transforms-forward-expected.png: Added.
  • platform/qt/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
  • platform/qt/fast/borders/only-one-border-with-width-expected.png: Added.
  • platform/qt/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/qt/fast/css/color-leakage-expected.png: Added.
  • platform/qt/fast/css/color-leakage-expected.txt: Added.
  • platform/qt/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Added.
  • platform/qt/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
  • platform/qt/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
  • platform/qt/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
  • platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/qt/svg/custom/invalid-dasharray-expected.png: Added.
  • platform/qt/svg/custom/invalid-dasharray-expected.txt: Added.
  • platform/qt/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/qt/svg/custom/linking-uri-01-b-expected.txt: Added.
  • platform/qt/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/qt/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
12:35 AM Changeset in webkit [89900] by kbalazs@webkit.org
  • 4 edits in trunk/LayoutTests

2011-06-28 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

WebKitTestRunner needs layoutTestController.setCallCloseOnWebViews
https://bugs.webkit.org/show_bug.cgi?id=46714

Skip these tests via the mac list to make them skipped on every wk2 platform.

  • platform/mac-wk2/Skipped:
  • platform/win-wk2/Skipped:
12:30 AM Changeset in webkit [89899] by abarth@webkit.org
  • 9 edits in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

NRWT should wait for ReportCrash
https://bugs.webkit.org/show_bug.cgi?id=63495

When a test crashes on Mac, ReportCrash confuses us into thinking the
test times out.

I'm not sure how to test this in a meaningful way in our current test
harness...

  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/common/system/crashlogs_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/tool/commands/queries.py:
12:25 AM Changeset in webkit [89898] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/782

Merge 89595
BUG=87227
Review URL: http://codereview.chromium.org/7274018

Jun 27, 2011:

11:46 PM Changeset in webkit [89897] by commit-queue@webkit.org
  • 9 edits in trunk/Tools

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89881.
http://trac.webkit.org/changeset/89881
https://bugs.webkit.org/show_bug.cgi?id=63513

Makes Qt massively slow (Requested by abarth on #webkit).

  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/common/system/crashlogs_unittest.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/tool/commands/queries.py:
11:02 PM Changeset in webkit [89896] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 89780
BUG=86648
Review URL: http://codereview.chromium.org/7273023

10:55 PM Changeset in webkit [89895] by barraclough@apple.com
  • 4 edits
    3 adds in trunk

Source/JavaScriptCore: Build fix attempt after r89885.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-06-27

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=50554
RegExp.prototype.toString does not escape slashes

Reviewed by Darin Adler & Oliver Hunt.

The problem here is that we don't escape forwards slashes when converting
a RegExp to a string. This means that RegExp("/").toString() is "/",
which is not a valid RegExp literal. Also, we return an invalid literal
for RegExp.prototype.toString() ("
", which is an empty single-line comment).

From ES5:
"NOTE: The returned String has the form of a RegularExpressionLiteral that
evaluates to another RegExp object with the same behaviour as this object."

Added test cases.

  • fast/regex/script-tests/toString.js: Added.

(testFwdSlash):

  • fast/regex/toString-expected.txt: Added.
  • fast/regex/toString.html: Added.
10:39 PM Changeset in webkit [89894] by yutak@chromium.org
  • 5 edits in trunk/Source/WebKit2

2011-06-27 Yuta Kitamura <yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

[WebKit2] Add hixie76WebSocketProtocolEnabled flag to WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=63447

Make a new flag added in WebCore::Settings (useHixie76WebSocketProtocol)
switchable from WebPage and WebPreferences.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetHixie76WebSocketProtocolEnabled): (WKPreferencesGetHixie76WebSocketProtocolEnabled):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
10:35 PM Changeset in webkit [89893] by cevans@google.com
  • 1 edit
    36 copies in branches/chromium/782

Merge 89836
BUG=87148
Review URL: http://codereview.chromium.org/7253035

10:13 PM Changeset in webkit [89892] by cevans@google.com
  • 2 edits
    3 copies in branches/chromium/782

Merge 89782
BUG=87339
Review URL: http://codereview.chromium.org/7273022

10:08 PM Changeset in webkit [89891] by pfeldman@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-27 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium baselines update.

  • platform/chromium-mac-leopard/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
10:02 PM Changeset in webkit [89890] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-06-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error related to wrong include order.

  • platform/graphics/efl/ImageEfl.cpp:
9:30 PM Changeset in webkit [89889] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

[chromium] editing/style/smoosh-styles-003.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=63509

Don't let spellcheck kick in this test because it's nothing to do with spellcheck.

  • editing/style/smoosh-styles-003.html:
9:19 PM Changeset in webkit [89888] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-06-27 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Convert json_results_generator.py to output version 4 JSON.
https://bugs.webkit.org/show_bug.cgi?id=60869

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
8:43 PM WebAPIReviewChecklist edited by rniwa@webkit.org
(diff)
7:30 PM Changeset in webkit [89887] by rniwa@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Build fix attempt after r89885.

7:19 PM Changeset in webkit [89886] by rniwa@webkit.org
  • 1 edit
    2 moves in trunk/LayoutTests

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Fix r89879.

  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png: Removed.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt: Removed.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.png: Copied from LayoutTests/platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt.
6:32 PM Changeset in webkit [89885] by oliver@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

2011-06-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Support throwing away non-running code even while other code is running
https://bugs.webkit.org/show_bug.cgi?id=63485

Add a function to CodeBlock to support unlinking direct linked callsites,
and then with that in place add logic to discard code from any function
that is not currently on the stack.

The unlinking completely reverts any optimized call sites, such that they
may be relinked again in future.

  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::unlinkCalls): (JSC::CodeBlock::clearEvalCache):
  • bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::unlink):
  • bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::clear):
  • heap/Heap.cpp: (JSC::Heap::getConservativeRegisterRoots):
  • heap/Heap.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall):
  • jit/JITWriteBarrier.h: (JSC::JITWriteBarrierBase::clear):
  • jsc.cpp: (GlobalObject::GlobalObject): (functionReleaseExecutableMemory):
  • runtime/Executable.cpp: (JSC::EvalExecutable::unlinkCalls): (JSC::ProgramExecutable::unlinkCalls): (JSC::FunctionExecutable::discardCode): (JSC::FunctionExecutable::unlinkCalls):
  • runtime/Executable.h:
  • runtime/JSGlobalData.cpp: (JSC::SafeRecompiler::returnValue): (JSC::SafeRecompiler::operator()): (JSC::JSGlobalData::releaseExecutableMemory):
6:16 PM Changeset in webkit [89884] by leviw@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-06-27 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Renaming incorrectly named linux test expectation.

  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png: Removed.
  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png.
6:12 PM Changeset in webkit [89883] by commit-queue@webkit.org
  • 1 edit
    2 moves
    2 adds
    10 deletes in trunk/LayoutTests

2011-06-27 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/5156801-2.html to dumpAsText and rename
https://bugs.webkit.org/show_bug.cgi?id=63359

converted editing/deleting/5156801-2.html to dump-as-markup test, with
new results. Renamed 5156801.html to delete-node-after-DOMNodeRemoved,
and 5156801-2.html to delete-table-cell-contents.html; they were only
noticeably related by their rdar number, which is now included in each.

  • editing/deleting/5156801.html: Removed.
  • editing/deleting/5156801-expected.txt: Removed.
  • editing/deleting/5156801-2.html: Removed.
  • editing/deleting/delete-node-after-DOMNodeRemoved.html: Added.
  • editing/deleting/delete-node-after-DOMNodeRemoved-expected.txt: Added.
  • editing/deleting/delete-table-cell-contents.html: Added.
  • editing/deleting/delete-table-cell-contents-expected.txt: Added.
  • platform/chromium-linux/editing/deleting/5156801-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5156801-2-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5156801-2-expected.txt: Removed.
  • platform/gtk/editing/deleting/5156801-2-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5156801-2-expected.png: Removed.
  • platform/mac/editing/deleting/5156801-2-expected.png: Removed.
  • platform/mac/editing/deleting/5156801-2-expected.txt: Removed.
  • platform/qt/editing/deleting/5156801-2-expected.png: Removed.
  • platform/qt/editing/deleting/5156801-2-expected.txt: Removed.
5:34 PM Changeset in webkit [89882] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=63497
Add DEBUG_WITH_BREAKPOINT support to the DFG JIT.

Reviewed by Oliver Hunt.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:33 PM Changeset in webkit [89881] by abarth@webkit.org
  • 9 edits in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

NRWT should wait for ReportCrash
https://bugs.webkit.org/show_bug.cgi?id=63495

When a test crashes on Mac, ReportCrash confuses us into thinking the
test times out.

I'm not sure how to test this in a meaningful way in our current test
harness...

  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/common/system/crashlogs_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/tool/commands/queries.py:
5:15 PM Changeset in webkit [89880] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the WebCore vcproj file after r89851.

  • WebCore.vcproj/WebCore.vcproj:
5:08 PM Changeset in webkit [89879] by leviw@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-27 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Windows rebaseline for my commit r89864.

  • platform/win/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.
4:57 PM Changeset in webkit [89878] by Joseph Pecoraro
  • 4 edits in trunk/Source/WebCore

2011-06-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Allow non-main thread text drawing in ICU ports
https://bugs.webkit.org/show_bug.cgi?id=63482

Some ports allow multiple threads to draw strings.
LineBreakIteratorPool is not thread safe and the existing
ASSERT caught cases where multiple threads were trying
to access the shared pool. This makes the pool a lazily
created per-thread pool to allow for thread safe pool use.

  • platform/ThreadGlobalData.h:
  • platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): start with null. (WebCore::ThreadGlobalData::lineBreakIteratorPool): lazily create. (WebCore::ThreadGlobalData::destroy): delete. Manage the lifetime of the per-thread pool instance.
  • platform/text/LineBreakIteratorPoolICU.h: (WebCore::LineBreakIteratorPool::sharedPool): Use the per-thread pool instance and remove the ASSERT that this needs to be on the main thread.

(WebCore::LineBreakIteratorPool::create):
Create a PassOwnPtr so we can use OwnPtr on pools.

(WebCore::LineBreakIteratorPool::LineBreakIteratorPool):
Private now that there is a public create function.

4:50 PM Changeset in webkit [89877] by leviw@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-06-27 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Chromium rebaselines for my commit r89864

  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png: Added.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png: Added.
  • platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt: Added.
4:26 PM Changeset in webkit [89876] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-27 Joe Wild <joseph.wild@nokia.com>

Reviewed by Simon Fraser.

Crash on www.crave.cnet.com in FrameView::windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=56393

Tests that a plugin of a swf file in a hidden iframe will not
crash. This test required more than 1 content file and a
timeout or else it would not repeat the error condition.

This test will only crash on platforms (like Symbian) that
don't allow nonvirtual functions to have a null this pointer.

  • plugins/hidden-iframe-with-swf-plugin-expected.txt: Added.
  • plugins/hidden-iframe-with-swf-plugin.html: Added.
  • plugins/resources/iframe-content-with-swf-plugin.html: Added.

2011-06-27 Joe Wild <joseph.wild@nokia.com>

Reviewed by Simon Fraser.

Crash on www.crave.cnet.com in FrameView::windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=56393

Check for a null renderer to fix a crash. This situation can
arise when external content/plugins is referenced from html
elements with style="display:none".

Test: plugins/hidden-iframe-with-swf-plugin.html

  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect):
4:16 PM Changeset in webkit [89875] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-27 Juan C. Montemayor <jmont@apple.com>

Reviewed by Mark Rowe.

Indirectly including TextPosition.h and XPathGrammar.h causes compile errors
https://bugs.webkit.org/show_bug.cgi?id=63392

When both TextPosition.h and XPathGrammar.h are included a compile-error
is caused, since XPathGrammar.h defines a macro called NUMBER and
TextPosition has a typedef named NUMBER.

  • wtf/text/TextPosition.h: (WTF::TextPosition::TextPosition): (WTF::TextPosition::minimumPosition): (WTF::TextPosition::belowRangePosition):
4:09 PM Changeset in webkit [89874] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Raymes Khoury <raymes@chromium.org>

Reviewed by Tony Chang.

WebCore fails to compile in thumb mode when neon instructions are
enabled.

There are two files (FELightingNEON.cpp and FEGaussianBlur.cpp)
which fail to build when -mthumb is passed to gcc. These contain inline
assembly for neon instructions on arm. This patch forces the -marm flag
to be passed when compiling these files to work around this.

https://bugs.webkit.org/show_bug.cgi?id=62916

Built WebKit in Chromium and checked that -marm is passed
only when building these files.

https://bugs.webkit.org/show_bug.cgi?id=62916

  • WebCore.gyp/WebCore.gyp:
4:05 PM Changeset in webkit [89873] by abarth@webkit.org
  • 7 edits in trunk

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should upload crash logs
https://bugs.webkit.org/show_bug.cgi?id=55907

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should upload crash logs
https://bugs.webkit.org/show_bug.cgi?id=55907

NRWT used to have a different name for crash logs. I've changed the
name to patch ORWT.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3:52 PM Changeset in webkit [89872] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Rolled DEPS.

  • DEPS:
3:51 PM Changeset in webkit [89871] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2011-06-27 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations update.

  • platform/chromium/fast/js/recursion-limit-equal-expected.txt: Rebaseline after r89842.
3:31 PM Changeset in webkit [89870] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-27 Adam Klein <adamk@chromium.org>

Reviewed by Adam Barth.

Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods
https://bugs.webkit.org/show_bug.cgi?id=63486

  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
3:18 PM Changeset in webkit [89869] by jcivelli@chromium.org
  • 12 edits
    2 adds in trunk

2011-06-27 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Adding binary part support to MHTML.
https://bugs.webkit.org/show_bug.cgi?id=63310

  • mhtml/multi_frames_binary.mht: Added.
  • platform/chromium/mhtml/multi_frames_binary-expected.txt: Added.

2011-06-27 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Adding binary part support to MHTML.
https://bugs.webkit.org/show_bug.cgi?id=63310

  • loader/archive/mhtml/MHTMLArchive.cpp: (WebCore::MHTMLArchive::generateMHTMLData): (WebCore::MHTMLArchive::generateMHTMLDataUsingBinaryEncoding):
  • loader/archive/mhtml/MHTMLArchive.h:
  • loader/archive/mhtml/MHTMLParser.cpp: (WebCore::MHTMLParser::parseNextPart):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::append):
  • platform/SharedBuffer.h:
  • platform/network/MIMEHeader.cpp: (WebCore::MIMEHeader::parseContentTransferEncoding):
  • platform/network/MIMEHeader.h:

2011-06-27 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Adding binary part support to MHTML.
https://bugs.webkit.org/show_bug.cgi?id=63310

  • public/WebPageSerializer.h:
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serializeToMHTML): (WebKit::WebPageSerializer::serializeToMHTMLUsingBinaryEncoding):
3:17 PM Changeset in webkit [89868] by eric@webkit.org
  • 16 edits in trunk/Tools

2011-06-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests needs a --webkit-test-runner option
https://bugs.webkit.org/show_bug.cgi?id=63439

NRWT doesn't actually know how to run with the WebKitTestRunner yet
but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.

There is a bunch of other little cleanup in this patch which I added as I
took a tour through all of our hard-coded DumpRenderTree strings.

  • Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
  • Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
  • Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
  • Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
  • Scripts/webkitpy/layout_tests/port/config.py:
    • build_dumprendertree had no business in this class, removed it.
    • Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
    • Exposed _script_path as script_path() (this probably belongs elsewhere).
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
    • Moved these tests to webkit_unittests.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Now respects the --webkit-test-runner option.
    • setup_test_run is empty in base.py too, no need to override it.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
    • Test the new hotness.
    • Bad, bad, bad! The old code was using a real Executive during unit-testing! I think this code is still hitting disk during the unit tests. :(
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add the option.
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
    • Remove optional args option.
  • Scripts/webkitpy/tool/commands/commandtest.py:
    • Remove optional args option.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
    • Remove optional args option.
3:15 PM Changeset in webkit [89867] by jeffm@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Really fix the revision number in the last entry

3:14 PM Changeset in webkit [89866] by jeffm@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Fix revision number that I referenced in my last checkin

3:11 PM Changeset in webkit [89865] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Web process always pauses on launch
https://bugs.webkit.org/show_bug.cgi?id=63487

Reviewed by Oliver Hunt.

In the absence of the WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable, only pause the web process on
launch if the shift, control, and alt keys are all held down. This regressed in r89865, which always caused the
web process to pause if the shift and alt keys were not held down.

  • WebProcess/WebKitMain.cpp:

(pauseProcessIfNeeded): Add some parentheses.

3:01 PM Changeset in webkit [89864] by leviw@chromium.org
  • 9 edits
    4 adds in trunk

2011-06-27 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Add support for unicode-bidi:plaintext CSS property
https://bugs.webkit.org/show_bug.cgi?id=50949
Adding support for the 'plaintext' mode of unicode-bidi.

  • fast/text/international/unicode-bidi-plaintext.html: Added.
  • platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.txt: added
  • platform/mac/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
  • platform/mac/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.

2011-06-27 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Add support for unicode-bidi:plaintext CSS property
https://bugs.webkit.org/show_bug.cgi?id=50949

Adding support for unicode-bidi: plaintext. This involves invoking P2 and P3
of the Unicode BiDi algorithm on each paragraph of a block with that style.
This is similar to dir=auto but done per-paragraph instead of per element.

Test: fast/text/international/unicode-bidi-plaintext.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Added plaintext.
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Ditto. (WebCore::CSSPrimitiveValue::operator EUnicodeBidi): Ditto.
  • css/CSSValueKeywords.in: Ditto.
  • html/HTMLElement.cpp: (WebCore::unicodeBidiAttributeForDirAuto): Helper to map elements with dir=auto to their proper unicode-bidi attribute. (WebCore::HTMLElement::parseMappedAttribute): Assign plaintext to pre and textarea when dir=auto.
  • platform/text/UnicodeBidi.h: Added plaintext.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::determineParagraphDirection): Determines the direction of a paragraph based on the first strong character. Stops at first paragraph separator. (WebCore::RenderBlock::layoutInlineChildren): Uses determineParagraphDirection when in unicode-bidi: plaintext mode (and operating at the block's BidiContext) to set each paragraph to the proper base BidiContext. (WebCore::RenderBlock::determineStartPosition): Ditto.
  • rendering/style/RenderStyle.h: Gave _unicodebidi another bit to accomodate for plaintext.
2:45 PM Changeset in webkit [89863] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows-specific results for the test added in r89745.

I checked these results with Rob - they are not failing expected results.

  • platform/win/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/win/svg/custom/linking-uri-01-b-expected.txt: Added.
2:38 PM Changeset in webkit [89862] by commit-queue@webkit.org
  • 2 edits
    1 add
    10 deletes in trunk/LayoutTests

2011-06-27 Wyatt Carss <wcarss@chromium.org>

Reviewed by Ryosuke Niwa.

convert editing/deleting/whitespace-pre-1.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=63372

converted editing/deleting/whitespace-pre-1.html to dump-as-markup, removed
old baselines, and added the new one.

  • editing/deleting/whitespace-pre-1-expected.txt: Added.
  • editing/deleting/whitespace-pre-1.html:
  • platform/chromium-linux/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/chromium-win/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/chromium-win/editing/deleting/whitespace-pre-1-expected.txt: Removed.
  • platform/gtk/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/gtk/editing/deleting/whitespace-pre-1-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/mac/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/mac/editing/deleting/whitespace-pre-1-expected.txt: Removed.
  • platform/qt/editing/deleting/whitespace-pre-1-expected.png: Removed.
  • platform/qt/editing/deleting/whitespace-pre-1-expected.txt: Removed.
2:38 PM Changeset in webkit [89861] by commit-queue@webkit.org
  • 12 edits in trunk/Source/JavaScriptCore

2011-06-27 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG JIT does not perform put_by_id caching.
https://bugs.webkit.org/show_bug.cgi?id=63409

  • bytecode/StructureStubInfo.h:
  • dfg/DFGJITCodeGenerator.cpp: (JSC::DFG::JITCodeGenerator::cachedPutById):
  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileFunction):
  • dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::addPropertyAccess): (JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
  • dfg/DFGNonSpeculativeJIT.cpp: (JSC::DFG::NonSpeculativeJIT::compile):
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp: (JSC::DFG::dfgRepatchByIdSelfAccess): (JSC::DFG::tryCacheGetByID): (JSC::DFG::appropriatePutByIdFunction): (JSC::DFG::tryCachePutByID): (JSC::DFG::dfgRepatchPutByID):
  • dfg/DFGRepatch.h:
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile):
2:32 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
2:27 PM QtWebKitRelease22 edited by Ademar Reis
(diff)
2:24 PM Changeset in webkit [89860] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

2:23 PM Changeset in webkit [89859] by Lucas Forschler
  • 1 copy in tags/Safari-534.50.1

New tag.

2:23 PM Changeset in webkit [89858] by alexis.menard@openbossa.org
  • 5 edits in trunk/Source

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Darin Adler.

Use specific headers includes rather than full system headers.
https://bugs.webkit.org/show_bug.cgi?id=63475

Use only needed headers rather than system headers.

No new tests, it's just a little cosmetic change.

  • platform/mac/WebVideoFullscreenController.h:
  • platform/mac/WebVideoFullscreenHUDWindowController.h:

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Darin Adler.

Use specific headers includes rather than full system headers.
https://bugs.webkit.org/show_bug.cgi?id=63475

Use only needed headers rather than system headers.

  • WebCoreSupport/QTKitFullScreenVideoHandler.mm:
2:22 PM Changeset in webkit [89857] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r89748.

2:21 PM Changeset in webkit [89856] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows-specific results for the test added in r89769.

I checked these results with Dan - they are not failing expected results.

  • platform/win/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
  • platform/win/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
2:20 PM Changeset in webkit [89855] by Lucas Forschler
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r89718.

2:20 PM Changeset in webkit [89854] by abarth@webkit.org
  • 8 edits in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Dirk Pranke.

new-run-webkit-tests does not report stderr output
https://bugs.webkit.org/show_bug.cgi?id=37739

Almost all the infrastructure appears to be in place to report stderr
in results.html. We just need to wire up a bool to tell results.html
to create the hyperlink.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
2:19 PM Changeset in webkit [89853] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

2:18 PM Changeset in webkit [89852] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Dirk Pranke.

webkitpy unit tests should have more descriptive names than just "Test"
https://bugs.webkit.org/show_bug.cgi?id=63479

Luckily we kept these classes in separate namespaces in the harness so
we were actually running them all even though they had the same name.

  • Scripts/webkitpy/common/system/stack_utils_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2:09 PM Changeset in webkit [89851] by Joseph Pecoraro
  • 6 edits
    1 add in trunk/Source/WebCore

2011-06-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Extract LineBreakIteratorPool class into its own file
https://bugs.webkit.org/show_bug.cgi?id=63471

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Add the new file to builds that used TextBreakIteratorPoolICU.h.
  • platform/text/LineBreakIteratorPoolICU.h: Added. (WebCore::LineBreakIteratorPool::sharedPool): (WebCore::LineBreakIteratorPool::LineBreakIteratorPool): Expose the constructor so it can be used by others.
  • platform/text/TextBreakIteratorICU.cpp: Remove the old LineBreakIteratorPool implementation.
1:57 PM Changeset in webkit [89850] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs an implemenation of allowRoundingHacks.
https://bugs.webkit.org/show_bug.cgi?id=63477

Add platform/mac/fast/text/rounding-hacks.html to the mac-wk2 skipped list to get the bots
green.

  • platform/mac-wk2/Skipped:
1:57 PM Changeset in webkit [89849] by leviw@chromium.org
  • 2 edits in trunk/Tools

2011-06-27 Greg Simon <gregsimon@chromium.org>

No review necessary.

Add email addr to contributor list
https://bugs.webkit.org/show_bug.cgi?id=63478

  • Scripts/webkitpy/common/config/committers.py:
1:53 PM Changeset in webkit [89848] by commit-queue@webkit.org
  • 15 edits in trunk/Tools

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89834.
http://trac.webkit.org/changeset/89834
https://bugs.webkit.org/show_bug.cgi?id=63476

Broke test-webkitpy (Requested by abarth on #webkit).

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/system/outputcapture.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
1:18 PM Changeset in webkit [89847] by jeffm@apple.com
  • 4 edits in trunk/Tools

2011-06-27 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

Stop copying obsolete WebKit libraries on Windows
https://bugs.webkit.org/show_bug.cgi?id=63474


Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.

  • DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
  • MiniBrowser/MiniBrowserPostBuild.cmd:
  • WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1:14 PM Changeset in webkit [89846] by inferno@chromium.org
  • 1 edit
    48 adds in trunk/LayoutTests

2011-06-27 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Chromium rebaselines for my commit r89836.

  • platform/chromium-linux/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/chromium-linux/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
12:39 PM Changeset in webkit [89845] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Add Wyatt Carss to the list of non-committer contributors.

  • Scripts/webkitpy/common/config/committers.py:
12:08 PM Changeset in webkit [89844] by justin.garcia@apple.com
  • 4 edits in trunk/Source/WebCore

2011-06-27 Justin Garcia <justin.garcia@apple.com>

Reviewed by Ryosuke Niwa.

CompositeEditCommand::inputText(const String& text, bool selectedInsertText) is unused
https://bugs.webkit.org/show_bug.cgi?id=62921

  • editing/CompositeEditCommand.cpp:
  • editing/CompositeEditCommand.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
11:47 AM Changeset in webkit [89843] by abarth@webkit.org
  • 6 edits
    2 adds in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkitpy should understand crash logs
https://bugs.webkit.org/show_bug.cgi?id=63468

We're planning to use this functionality to upload crash logs along
with test results for new-run-webkit-tests.

  • Scripts/webkitpy/common/system/crashlog.py: Added.
  • Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/tool/commands/queries.py:
11:40 AM Changeset in webkit [89842] by barraclough@apple.com
  • 3 edits in trunk/LayoutTests

The fast/js/recursion-limit-equal test is too fragile
https://bugs.webkit.org/show_bug.cgi?id=63352

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-06-27
Reviewed by Gavin Barraclough.

  • fast/js/recursion-limit-equal-expected.txt:
  • fast/js/script-tests/recursion-limit-equal.js:
11:36 AM Changeset in webkit [89841] by Adam Roben
  • 2 edits in trunk/Tools

Make LayoutTestResultsLoader cache whether old-run-webkit-tests exited early due to too many failures

Fixes <http://webkit.org/b/63470> TestFailures page for a particular builder forgets
old-run-webkit-tests exited early after reload

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Store both the set of failing tests and whether
old-run-webkit-tests exited early due to too many failures in PersistentCache.

11:28 AM Changeset in webkit [89840] by Adam Roben
  • 3 edits in trunk/Tools

Make TestFailures load build names from build.webkit.org/old-results too

Build results are periodically moved from results to old-results. This change makes those
builds still visible to TestFailures.

Fixes <http://webkit.org/b/63453> TestFailures page doesn't show information for builds that
have been moved to build.webkit.org/old-results

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getBuildNames): Extracted code to parse build names from a
build.webkit.org directory listing into a separate function. Instead of omitting .zip files,
we now only include directory entries whose names are parseable as build names (since
old-results sometimes contains other random files/directories from who knows what). We now
fetch both results and old-results (with a FIXME about loading old-results on demand),
extract build names from each, and concatenate the two sets of names.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js:

(WebKitBuildbot.prototype.parseBuildName): Changed to return null when the build name isn't
parseable, rather than throwing an exception.

11:28 AM Changeset in webkit [89839] by Adam Roben
  • 2 edits in trunk/Tools

Store analyzed history directly in LayoutTestHistoryAnalyzer instead of in a generic cache

It seems silly to have a whole generic cache just to store a single object.

Fixes <http://webkit.org/b/63407> LayoutTestHistoryAnalyzer has a generic cache but doesn't
need one

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

(LayoutTestHistoryAnalyzer): Replaced this._cache with this._history.
(LayoutTestHistoryAnalyzer.prototype.start): Ditto.
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Ditto, and removed the
no-longer-needed history argument.

11:27 AM Changeset in webkit [89838] by Adam Roben
  • 4 edits
    2 adds in trunk/Tools

Move some inappropriate code out of Builder

Fixes <http://webkit.org/b/63406> TestFailure page's Builder class has a bunch of code that
isn't really about a builder

Reviewed by Anders Carlsson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getBuildNames): Renamed from _getBuildNames, since it now needs to be
called by other objects.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:

Added. Code came from Builder.
(LayoutTestHistoryAnalyzer):
(LayoutTestHistoryAnalyzer.prototype.start):
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

Added. Code came from Builder.
(LayoutTestResultsLoader):
(LayoutTestResultsLoader.prototype.start):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._displayBuilder): Changed to use LayoutTestHistoryAnalyzer.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in new

scripts.

11:05 AM Changeset in webkit [89837] by nduca@chromium.org
  • 19 edits
    5 copies
    4 adds in trunk

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Create CCLayerTreeHost and CCLayerTreeHostImpl, which are the main
thread and compositor thread halves of a composited view. Communication
between the two is based on the design used in FileStreamProxy.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromiumImpl::create): (WebCore::LayerRendererChromiumImpl::drawLayersAndPresent): (WebCore::LayerRendererChromiumImpl::LayerRendererChromiumImpl): (WebCore::LayerRendererChromiumImpl::drawLayersOnMainThread): (WebCore::LayerRendererChromiumImplProxy::create): (WebCore::LayerRendererChromiumImplProxy::createLayerTreeHostImpl): (WebCore::LayerRendererChromiumImplProxy::LayerRendererChromiumImplProxy): (WebCore::LayerRendererChromium::createLayerTreeHostImplProxy):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::setShowFPSCounter): (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h: (WebCore::CCHeadsUpDisplay::currentFrameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::CCLayerTreeHost): (WebCore::CCLayerTreeHost::init): (WebCore::CCLayerTreeHost::~CCLayerTreeHost): (WebCore::CCLayerTreeHost::beginCommit): (WebCore::CCLayerTreeHost::commitComplete): (WebCore::CCLayerTreeHost::animateAndLayout): (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter): (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHost::setNeedsRedraw): (WebCore::CCLayerTreeHost::updateLayers):
  • platform/graphics/chromium/cc/CCLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHost::frameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::create): (WebCore::CCLayerTreeHostCommitter::commit):
  • platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostCommitter::CCLayerTreeHostCommitter):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Added. (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl): (WebCore::CCLayerTreeHostImpl::beginCommit): (WebCore::CCLayerTreeHostImpl::commitComplete): (WebCore::CCLayerTreeHostImpl::drawLayers): (WebCore::CCLayerTreeHostImpl::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp. (WebCore::CCLayerTreeHostImplClient::~CCLayerTreeHostImplClient): (WebCore::CCLayerTreeHostImpl::frameNumber): (WebCore::CCLayerTreeHostImpl::sourceFrameNumber): (WebCore::CCLayerTreeHostImpl::setSourceFrameNumber):
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Added. (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::start): (WebCore::CCLayerTreeHostImplProxy::~CCLayerTreeHostImplProxy): (WebCore::CCLayerTreeHostImplProxy::isStarted): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedraw): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedraw): (WebCore::CCLayerTreeHostImplProxy::stop): (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::isMainThread): (WebCore::CCLayerTreeHostImplProxy::isCCThread): (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit): (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread): (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread): (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread): (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
  • platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Added. (WebCore::CCLayerTreeHostImplProxy::host):
  • platform/graphics/chromium/cc/CCMainThreadTask.h:
  • platform/graphics/chromium/cc/CCThread.cpp: (WebCore::CCThread::runLoop):
  • platform/graphics/chromium/cc/CCThreadTask.h:

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Redirect invalidates and scheduling into compositor when in
threaded compositing mode. Add stress tests for CCLayerTreeHost.

  • WebKit.gypi:
  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::animateAndLayout): (WebKit::WebViewImpl::updateLayers): (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::createLayerTreeHostContext3D): (WebKit::WebViewImpl::reallocateRenderer): (WebKit::WebViewImpl::updateLayerRendererSettings): (WebKit::WebViewImpl::updateLayerRendererViewport):
  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp: Added. (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest): (WTF::CCLayerTreeHostTest::animateAndLayout): (WTF::CCLayerTreeHostTest::beginCommitOnCCThread): (WTF::CCLayerTreeHostTest::beginCommitOnMainThread): (WTF::CCLayerTreeHostTest::commitOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTest::commitCompleteOnMainThread): (WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTest::updateLayers): (WTF::CCLayerTreeHostTest::onBeginTest): (WTF::CCLayerTreeHostTest::doEndTest): (WTF::CCLayerTreeHostTest::onEndTest): (WTF::CCLayerTreeHostTest::runTest): (WTF::CCLayerTreeHostTest::testTimeout): (WTF::MockLayerTreeHostClient::MockLayerTreeHostClient): (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D): (WTF::MockLayerTreeHostClient::animateAndLayout): (WTF::MockLayerTreeHostClient::updateLayers): (WTF::MockLayerTreeHostCommitter::create): (WTF::MockLayerTreeHostCommitter::commit): (WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter): (WTF::MockLayerTreeHostImpl::create): (WTF::MockLayerTreeHostImpl::beginCommit): (WTF::MockLayerTreeHostImpl::commitComplete): (WTF::MockLayerTreeHostImpl::drawLayersAndPresent): (WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::create): (WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl): (WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::MockLayerTreeHost): (WTF::MockLayerTreeHost::createLayerTreeHostImplProxy): (WTF::MockLayerTreeHost::updateLayers): (WTF::MockLayerTreeHost::createLayerTreeHostCommitter): (WTF::MockLayerTreeHost::beginCommit): (WTF::MockLayerTreeHost::commitComplete): (WTF::CCLayerTreeHostTest::doBeginTest): (WTF::CCLayerTreeHostTest::endTest): (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1): (WTF::CCLayerTreeHostTestShortlived1::beginTest): (WTF::CCLayerTreeHostTestShortlived1::afterTest): (WTF::TEST_F): (WTF::CCLayerTreeHostTestShortlived2::CCLayerTreeHostTestShortlived2): (WTF::CCLayerTreeHostTestShortlived2::beginTest): (WTF::CCLayerTreeHostTestShortlived2::afterTest): (WTF::CCLayerTreeHostTestShortlived3::CCLayerTreeHostTestShortlived3): (WTF::CCLayerTreeHostTestShortlived3::beginTest): (WTF::CCLayerTreeHostTestShortlived3::afterTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::CCLayerTreeHostTestCommitingWithContinuousRedraw): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::CCLayerTreeHostTestSetNeedsCommit1): (WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit1::afterTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::CCLayerTreeHostTestSetNeedsCommit2): (WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest): (WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsCommit2::afterTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::CCLayerTreeHostTestSetNeedsRedraw): (WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest): (WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread): (WTF::CCLayerTreeHostTestSetNeedsRedraw::afterTest):
  • tests/CCThreadTest.cpp: (WebCore::TEST):

2011-05-17 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
10:48 AM Changeset in webkit [89836] by inferno@chromium.org
  • 3 edits
    36 adds in trunk

2011-06-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Fix removal of overhanging floats on style changes to absolute/fixed position.
https://bugs.webkit.org/show_bug.cgi?id=63355

  1. If we are not currently positioned.
  2. And we are not floating. (If we are floating, then this will be automatically done in RenderBox::styleWillChange as part of removeFloatingOrPositionedChildFromBlockLists)
  3. And we have overhanging floats from previous sibling blocks.
  4. And our new new style tells that we will have absolute or fixed position.

Then, we mark all our descendants with floats for layout. This will make sure that
overhanging floats are removed. Also, it is important to do that since if that previous
sibling block goes away, it is not able to tell us that to remove those floats thinking
that being a positioned block, we should have removed them already.

Tests: fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html

fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html
fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html
fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html
fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html
fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html
fast/block/float/overhanging-float-add-in-static-position-block.html
fast/block/float/overhanging-float-add-in-static-position-block2.html
fast/block/float/overhanging-float-remove-from-absolute-position-block.html
fast/block/float/overhanging-float-remove-from-absolute-position-block2.html
fast/block/float/overhanging-float-remove-from-fixed-position-block.html
fast/block/float/overhanging-float-remove-from-fixed-position-block2.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange):

2011-06-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that overhanging floats are removed during style changes to absolute/fixed
position and gets added back when coming back to static position.
https://bugs.webkit.org/show_bug.cgi?id=63355

  • fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html: Added.
  • fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html: Added.
  • fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html: Added.
  • fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html: Added.
  • fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html: Added.
  • fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html: Added.
  • fast/block/float/overhanging-float-add-in-static-position-block.html: Added.
  • fast/block/float/overhanging-float-add-in-static-position-block2.html: Added.
  • fast/block/float/overhanging-float-remove-from-absolute-position-block.html: Added.
  • fast/block/float/overhanging-float-remove-from-absolute-position-block2.html: Added.
  • fast/block/float/overhanging-float-remove-from-fixed-position-block.html: Added.
  • fast/block/float/overhanging-float-remove-from-fixed-position-block2.html: Added.
  • platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
10:44 AM Changeset in webkit [89835] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2011-06-27 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations update.

Add chromium mac failure after r89733.

  • platform/chromium/test_expectations.txt:
10:43 AM Changeset in webkit [89834] by eric@webkit.org
  • 15 edits in trunk/Tools

2011-06-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests needs a --webkit-test-runner option
https://bugs.webkit.org/show_bug.cgi?id=63439

NRWT doesn't actually know how to run with the WebKitTestRunner yet
but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.

There is a bunch of other little cleanup in this patch which I added as I
took a tour through all of our hard-coded DumpRenderTree strings.

  • Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
  • Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
  • Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
  • Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
  • Scripts/webkitpy/layout_tests/port/config.py:
    • build_dumprendertree had no business in this class, removed it.
    • Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
    • Exposed _script_path as script_path() (this probably belongs elsewhere).
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
    • Moved these tests to webkit_unittests.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Now respects the --webkit-test-runner option.
    • setup_test_run is empty in base.py too, no need to override it.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
    • Test the new hotness.
    • Bad, bad, bad! The old code was using a real Executive during unit-testing! I think this code is still hitting disk during the unit tests. :(
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add the option.
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
    • Remove optional args option.
  • Scripts/webkitpy/tool/commands/commandtest.py:
    • Remove optional args option.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
    • Remove optional args option.
10:33 AM Changeset in webkit [89833] by krit@webkit.org
  • 14 edits
    4 adds in trunk

2011-06-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGPreserveAspectRatio animation
https://bugs.webkit.org/show_bug.cgi?id=63456


Test for animation of SVGPreserveAspectRatio.

  • svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgPreserveAspectRatio-animation-1-expected.txt: Added.
  • svg/animations/svgPreserveAspectRatio-animation-1.html: Added.

2011-06-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGPreserveAspectRatio animation
https://bugs.webkit.org/show_bug.cgi?id=63456


Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedPreserveAspectRatio.


The new animator does not affect any behavior, since it was animated with SVGAnimatedString before. The new animator is still needed
to support animVal and baseVal later.

Test: svg/animations/svgPreserveAspectRatio-animation-1.html

  • CMakeLists.txt: Added new file.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Handle AnimatedPreserveAspectRatio. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedPreserveAspectRatio.cpp: Added. New animator for SVGAnimatedPreserveAspectRatio. (WebCore::SVGAnimatedPreserveAspectRatioAnimator::SVGAnimatedPreserveAspectRatioAnimator): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::constructFromString): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateDistance):
  • svg/SVGAnimatedPreserveAspectRatio.h: (WebCore::SVGAnimatedPreserveAspectRatioAnimator::~SVGAnimatedPreserveAspectRatioAnimator):
  • svg/SVGAnimatedType.cpp: Support for SVGPreserveAspectRatio. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createPreserveAspectRatio): (WebCore::SVGAnimatedType::preserveAspectRatio): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString): (WebCore::SVGAnimatedType::setPreserveAspectRatioBaseValue):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
10:26 AM Changeset in webkit [89832] by alexis.menard@openbossa.org
  • 11 edits
    2 deletes in trunk

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448

Remvove from the build.

  • Source/WebKit.pri:

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448

Remove Phonon mediaplayer as it is unused, not finished and
unmaintained.

  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • features.pri:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Removed.
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h: Removed.

2011-06-27 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448

Remove Phonon related stuff.

  • docs/qtwebkit.qdocconf:
  • qt_webkit_version.pri:
10:21 AM Changeset in webkit [89831] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Crash in TextIterator
https://bugs.webkit.org/show_bug.cgi?id=63334

Fix a crash in TextIterator. Keep m_sortedTextBoxes and renderer consistent
and check !m_offset when handling first letter.

Also add more assertions to help detecting similar bugs.

Test: editing/text-iterator/first-letter-rtl-crash.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::emitText):

2011-06-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Crash in TextIterator
https://bugs.webkit.org/show_bug.cgi?id=63334

Added a test to ensure WebKit does not crash when iterating through letters in a RTL block
with first-letter rule applied where letters are not contiguous.

  • editing/text-iterator/first-letter-rtl-crash-expected.txt: Added.
  • editing/text-iterator/first-letter-rtl-crash.html: Added.
10:18 AM Changeset in webkit [89830] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source

2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

This patch is based on Noam Rosenthal original patch in the same bug.

When hinted with QWebElement metatype, we qualify the conversion
from JSElement as a "perfect match".

The test was failing because the wrong slot was called, since the QWebElement
match was taken as equal to the others and not chosen when the metacall happened.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): Identify the conversion between JSElement to QWebElement as a "perfect match" (dist = 0). Add comments to explain the reason why we have the implicit conversion.

2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::overloadedSlots): Remove expected failure and fix the comment.
10:16 AM Changeset in webkit [89829] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-27 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
https://bugs.webkit.org/show_bug.cgi?id=63458

Put a failing test to the mac list because all wk2 platforms are affected.
Move the group to the section where the items have bug report.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
10:04 AM Changeset in webkit [89828] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-06-27 ChangSeok Oh <ChangSeok Oh>

Reviewed by Martin Robinson.

[GTK] Fix build break to support webgl
https://bugs.webkit.org/show_bug.cgi?id=63425

Some missing files in ANGLE are just added to fix build-break.

No test reqired

  • GNUmakefile.list.am:

2011-06-27 ChangSeok Oh <ChangSeok Oh>

Reviewed by Martin Robinson.

[GTK] Fix build break to support webgl
https://bugs.webkit.org/show_bug.cgi?id=63425

A member variable enableWebGL in WebKitWebSettingsPrivate is changed to enableWebgl

  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings):
9:57 AM Changeset in webkit [89827] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Hyowon Kim <hw1008.kim@samsung.com>

Reviewed by Martin Robinson.

[EFL] Add some PLATFORM(EFL) ifdefs to GraphicsContext3D.h
https://bugs.webkit.org/show_bug.cgi?id=62959

Add PLATFORM(EFL) ifdefs to use GraphicsContextInternal.

  • platform/graphics/GraphicsContext3D.h:
9:55 AM Changeset in webkit [89826] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-06-27 Alexandru Chiculita <Alexandru Chiculita>

Reviewed by Ojan Vafai.

css combinator "+" in combination with NAV tag is buggy
https://bugs.webkit.org/show_bug.cgi?id=47971

  • fast/css/div_plus_nav_bug47971-expected.txt: Added.
  • fast/css/div_plus_nav_bug47971.html: Added.

2011-06-27 Alexandru Chiculita <Alexandru Chiculita>

Reviewed by Ojan Vafai.

css combinator "+" in combination with NAV tag is buggy
https://bugs.webkit.org/show_bug.cgi?id=47971

Added a new state in css/tokenizer.flex for the "nth" rule. The state begins
at nth-*( functions and ends at the first ")". It avoids parsing selectors
like "#div+nav" as: "#div" "+n" "av".

Test: fast/css/div_plus_nav_bug47971.html

  • css/maketokenizer:
  • css/tokenizer.flex:
9:32 AM Changeset in webkit [89825] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-27 Chang Shu <cshu@webkit.org>

Reviewed by Darin Adler.

[WK2] WebKitTestRunner should reset FrameFlattening flag to disable before each test
https://bugs.webkit.org/show_bug.cgi?id=63457

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
8:51 AM Changeset in webkit [89824] by commit-queue@webkit.org
  • 11 edits in trunk

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89822.
http://trac.webkit.org/changeset/89822
https://bugs.webkit.org/show_bug.cgi?id=63461

Broken builds (Requested by apavlov on #webkit).

  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:

2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r89822.
http://trac.webkit.org/changeset/89822
https://bugs.webkit.org/show_bug.cgi?id=63461

Broken builds (Requested by apavlov on #webkit).

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode):
  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):
8:37 AM Changeset in webkit [89823] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Adam Roben.

Send keypress events to windowless plugins on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=63144

No new tests. Covered by existing windowless plugin tests plugins/mouse-events.html
and plugins/keyboard-events.html. Both are not yet working as desired because focus
events are not being fowarded to windowed plugins on the win port (bug 62375). Test
plugin logging on the win port was added in bug 61721. New failing expectations for
plugins/keyboard-events.html were subsequently added in bug 33973 so there's no need
to update test expectations in this patch.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::handleKeyboardEvent): Add an ASSERT(m_plugin && !m_isWindowed)
to indicate that the routine is for windowless plugins. Remove trailing whitespace.
Add handling for keyPress events (map to WM_CHAR).
(WebCore::PluginView::handleMouseEvent): Add the ASSERT to indicate that the routine
is for windowless plugins. Add FIXME note. Remove trailing whitespace.

8:33 AM Changeset in webkit [89822] by apavlov@chromium.org
  • 11 edits in trunk

2011-06-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
https://bugs.webkit.org/show_bug.cgi?id=63446

WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::computePseudoClassMask): (WebCore::InspectorCSSAgent::getStylesForNode):
  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update):

LayoutTests:

  • inspector/styles/get-set-stylesheet-text.html:
  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:
8:12 AM Changeset in webkit [89821] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

2011-06-27 Raphael Kubo da Costa <kubo@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] DRT: Add an ewk_view specialization for EFL's DumpRenderTree.
It will be plugged into the build system as soon as the rest of the
DRT code is fully upstreamed.
https://bugs.webkit.org/show_bug.cgi?id=63086

  • DumpRenderTree/efl/DumpRenderTreeView.cpp: Added. (onConsoleMessage): (onJavaScriptAlert): (onJavaScriptConfirm): (onJavaScriptPrompt): (drtViewTiledAdd):
  • DumpRenderTree/efl/DumpRenderTreeView.h: Added.
8:10 AM Changeset in webkit [89820] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

2011-06-27 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] Add an EventSender implementation to EFL's DumpRenderTree along
with support files.
Build system changes will be made as soon as the whole DumpRenderTree
is upstreamed.
https://bugs.webkit.org/show_bug.cgi?id=61962

  • DumpRenderTree/efl/EventSender.cpp: Added. (setEvasModifiers): (translateMouseButtonNumber): (sendMouseEvent): (sendClick): (scheduleAsynchronousClickCallback): (updateClickCount): (modifierFromJSValue): (modifiersFromJSValue): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (evasMouseEventFromHorizontalAndVerticalOffsets): (mouseScrollByCallback): (continuousMouseScrollByCallback): (keyPadNameFromJSValue): (keyNameFromJSValue): (keyDownCallback): (scalePageByCallback): (getClass): (makeEventSender):
  • DumpRenderTree/efl/EventSender.h: Added.
7:38 AM Changeset in webkit [89819] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/JavaScriptCore

Merging r89817.

7:36 AM Changeset in webkit [89818] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-27 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove private header files from EWebKit_HEADERS.
https://bugs.webkit.org/show_bug.cgi?id=63441

Remove ewk_tiled_private.h, ewk_tiled_backing_store.h, ewk_tiled_matrix.h,
ewk_tiled_model.h and check WTF_USE_SOUP to remove ewk_auth_soup.h.

  • CMakeListsEfl.txt:
7:31 AM Changeset in webkit [89817] by kov@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-27 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed build fix. One more filed missing during distcheck, for
the MIPS build.

  • GNUmakefile.list.am:
7:08 AM Changeset in webkit [89816] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-27 Pavel Feldman <pfeldman@google.com>

Not reviewed: updating chromium expectations.

  • platform/chromium/test_expectations.txt:
4:54 AM Changeset in webkit [89815] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-27 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION r84481] updateLayout called from DrawNodeHighlight
https://bugs.webkit.org/show_bug.cgi?id=63405

We should not call layout from paint.

  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::drawNodeHighlight):
  • inspector/DOMNodeHighlighter.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::drawNodeHighlight):
4:33 AM Changeset in webkit [89814] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[WK2] Daily gardening.

Remove non-existent svg/animations/animate-points.html from the Skipped list.

  • platform/mac-wk2/Skipped:
4:32 AM Changeset in webkit [89813] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-06-27 Pavel Feldman <pfeldman@google.com>

Not reviewed: naive approach to fixing flaky inspector tests.

  • inspector/styles/styles-cancel-editing.html:
  • inspector/styles/styles-commit-editing.html:
3:45 AM Changeset in webkit [89812] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

2011-06-27 Jongseok Yang <js45.yang@samsung.com>

Reviewed by Kent Tamura.

[EFL] Use accept attribute when executing the file picker for input element
https://bugs.webkit.org/show_bug.cgi?id=63063

This patch:

  • remove the argument "suggested_filenames" from ewk_view_run_open_panel
  • add the argument "accept" to ewk_view_run_open_panel
  • get the accept attribute and pass to ewk_view_run_open_panel within runOpenPanel
  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::runOpenPanel):
  • ewk/ewk_view.cpp: (ewk_view_run_open_panel):
  • ewk/ewk_view.h
3:44 AM Changeset in webkit [89811] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebKit/efl

2011-06-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error.

Remove meaningless parameter from WebCoreSupport's header files.

  • WebCoreSupport/ChromeClientEfl.h: (WebCore::ChromeClientEfl::scrollRectIntoView):
  • WebCoreSupport/DragClientEfl.h:
  • WebCoreSupport/FrameLoaderClientEfl.h: (WebCore::FrameLoaderClientEfl::setWebFrame):
3:18 AM Changeset in webkit [89810] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebCore

2011-06-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Fix style error in EFL port.

  • platform/efl/PlatformKeyboardEventEfl.cpp:
  • platform/efl/PlatformScreenEfl.cpp:
  • platform/efl/SharedBufferEfl.cpp:
1:51 AM Changeset in webkit [89809] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-27 KwangHyuk Kim <hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Remove ewk_tile_matrix_updates_process() call from _ewk_tiled_backing_store_item_process_idler_cb().
https://bugs.webkit.org/show_bug.cgi?id=62963

As repaint_process on ewk_view_tiled already takes care of dirty area in visible area
and in order to let pre-render work more efficiently,
_ewk_tiled_backing_store_item_process_idler_cb() better not call ewk_tile_matrix_updates_process().

  • ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_item_process_idler_cb):
1:41 AM Changeset in webkit [89808] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove evil uses of hasattr
https://bugs.webkit.org/show_bug.cgi?id=63430

For some reason these classes believe that they may be called with
various flavors of "option" elements and so carefully check to make
sure that the options element has their option before checking it.

We had a set_option_default method which was never called, so I made it
do what callsites seemed to want it to do and replaced 3 callers
who previously used hasattr manually to use set_option_default instead.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
1:37 AM Changeset in webkit [89807] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
https://bugs.webkit.org/show_bug.cgi?id=63132

  • platform/qt-mac/Skipped: Skip fast/css/custom-font-xheight.html.
1:35 AM Changeset in webkit [89806] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-27 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: node selection is slow in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60813

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.stylesCallback): (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update):
1:34 AM Changeset in webkit [89805] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

  • platform/mac-wk2/Skipped: Skip new tests introduced in r89783.
1:15 AM Changeset in webkit [89804] by pfeldman@chromium.org
  • 30 edits in trunk

2011-06-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: roll out r88337 for making tests flaky.
https://bugs.webkit.org/show_bug.cgi?id=63422

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.selectNodeWithId.onNodeFound): (initialize_ElementTest.InspectorTest.selectNodeWithId): (initialize_ElementTest.InspectorTest.waitForStyles): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStyles.nodeSelected): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStyles.stylesUpdated): (initialize_ElementTest.InspectorTest.selectNodeAndWaitForStyles):
  • http/tests/inspector/inspect-iframe-from-different-domain.html:
  • inspector/elements/edit-dom-actions.html:
  • inspector/elements/elements-delete-inline-style.html:
  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/metrics-box-sizing.html:
  • inspector/styles/parse-utf8-bom.html:
  • inspector/styles/styles-add-blank-property.html:
  • inspector/styles/styles-add-invalid-property.html:
  • inspector/styles/styles-cancel-editing.html:
  • inspector/styles/styles-commit-editing.html:
  • inspector/styles/styles-computed-trace.html:
  • inspector/styles/styles-disable-inherited.html:
  • inspector/styles/styles-disable-then-change.html:
  • inspector/styles/styles-disable-then-delete.html:
  • inspector/styles/styles-disable-then-enable.html:
  • inspector/styles/styles-iframe-expected.txt:
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-source-lines-expected.txt:
  • inspector/styles/styles-source-lines-inline.html:
  • inspector/styles/styles-source-lines.html:
  • inspector/styles/styles-update-from-js-expected.txt:
  • inspector/styles/styles-update-from-js.html:
  • inspector/styles/styles-url-linkify.html:
  • inspector/styles/up-down-numerics-and-colors-expected.txt:
  • inspector/styles/up-down-numerics-and-colors.html:

2011-06-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: roll out r88337 for making tests flaky.
https://bugs.webkit.org/show_bug.cgi?id=63422

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.updateStyles): (WebInspector.ElementsPanel.prototype._stylesUpdated):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.stylesCallback): (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update):
1:10 AM Changeset in webkit [89803] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-06-27 Huang Dongsung <luxtella@company100.net>

Reviewed by Kenneth Rohde Christiansen.

TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
error.
https://bugs.webkit.org/show_bug.cgi?id=62422

REGRESSION(r77286): Remove bottomRight().
REGRESSION(r77312): Change the logic to get the bottom right point.
REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.

If the viewport width equals the contents width, especially in the mobile
device, TiledBackingStore endlessly creates and deletes the rightmost
column and bottom row of tiles.
In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
tiles infinitely.
Modified TiledDrawingAreaProxy also.

  • platform/graphics/TiledBackingStore.cpp: (WebCore::innerBottomRight): (WebCore::TiledBackingStore::invalidate): (WebCore::TiledBackingStore::paint): (WebCore::TiledBackingStore::createTiles):

2011-06-27 Huang Dongsung <luxtella@company100.net>

Reviewed by Kenneth Rohde Christiansen.

TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
error.
https://bugs.webkit.org/show_bug.cgi?id=62422

REGRESSION(r77286): Remove bottomRight().
REGRESSION(r77312): Change the logic to get the bottom right point.
REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.

If the viewport width equals the contents width, especially in the mobile
device, TiledBackingStore endlessly creates and deletes the rightmost
column and bottom row of tiles.
In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
tiles infinitely.
Modified TiledDrawingAreaProxy also.

  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::innerBottomRight): (WebKit::TiledDrawingAreaProxy::invalidate): (WebKit::TiledDrawingAreaProxy::paint): (WebKit::TiledDrawingAreaProxy::createTiles):
1:07 AM Changeset in webkit [89802] by tkent@chromium.org
  • 2 edits in trunk/Tools

2011-06-27 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

[Chromium] WebViewHost should be destructed before LayoutTestController, etc.
https://bugs.webkit.org/show_bug.cgi?id=63427

~WebViewHost() navigates to about:blank, so it calls some
callbacks and LayoutTestController functions.

  • DumpRenderTree/chromium/TestShell.h: Move m_printer upper and move m_webViewHost lower.
1:04 AM Changeset in webkit [89801] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move server config files to webkitpy.layout_tests.servers
https://bugs.webkit.org/show_bug.cgi?id=63436

The config files belong with the servers.

  • Scripts/webkitpy/layout_tests/port/httpd2.pem: Removed.
  • Scripts/webkitpy/layout_tests/port/lighttpd.conf: Removed.
  • Scripts/webkitpy/layout_tests/servers/http_server.py:
  • Scripts/webkitpy/layout_tests/servers/httpd2.pem: Copied from Tools/Scripts/webkitpy/layout_tests/port/httpd2.pem.
  • Scripts/webkitpy/layout_tests/servers/lighttpd.conf: Copied from Tools/Scripts/webkitpy/layout_tests/port/lighttpd.conf.
1:01 AM Changeset in webkit [89800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-27 KwangHyuk Kim <hyuki.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Remove dead code related with Ewk_Tiled_Backing_Store_Item's update field.
https://bugs.webkit.org/show_bug.cgi?id=62967

As some code do not affect any logical flow of tiled backing store except condition check,
I would like to clean dead code related with Ewk_Tiled_Backing_Store_Item's update field
and Ewk_Tiled_Backing_Store_Data's queue field

  • ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_item_process_idler_cb): (_ewk_tiled_backing_store_item_fill): (_ewk_tiled_backing_store_item_add): (_ewk_tiled_backing_store_item_del):
12:59 AM Changeset in webkit [89799] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

  • platform/mac-wk2/Skipped: Skip a new test.
12:59 AM Changeset in webkit [89798] by abarth@webkit.org
  • 7 edits
    4 moves in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move websocket_server and http_server to webkitpy.layout_package.servers
https://bugs.webkit.org/show_bug.cgi?id=63434

These classes do not represent ports. They represent servers.

  • Scripts/new-run-webkit-httpd:
  • Scripts/new-run-webkit-websocketserver:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py: Removed.
  • Scripts/webkitpy/layout_tests/port/http_server_base.py: Removed.
  • Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed.
  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/servers/http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server.py.
  • Scripts/webkitpy/layout_tests/servers/http_server_base.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py.
  • Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py.
  • Scripts/webkitpy/layout_tests/servers/websocket_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py.
12:54 AM Changeset in webkit [89797] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-06-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove Chromium and ChromiumMac implementations of driver_name now that everything uses DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=63428

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
12:46 AM Changeset in webkit [89796] by Csaba Osztrogonác
  • 8 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platform specific expected results after r89745.

  • platform/qt/Skipped: Revert accidentally committed (r89732) changes.
  • platform/qt/svg/custom/linking-a-03-b-all-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
12:43 AM Changeset in webkit [89795] by abarth@webkit.org
  • 2 edits
    1 move
    2 adds in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move apache_http_server.py to webkitpy.layout_package.servers
https://bugs.webkit.org/show_bug.cgi?id=63433

The apache_http_server.py is a server, not a port.

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py: Removed.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/servers: Added.
  • Scripts/webkitpy/layout_tests/servers/init.py: Added.
  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py.
12:34 AM Changeset in webkit [89794] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move rebaseline-chromium-webkit-tests.py to webkitpy.to_be_moved
https://bugs.webkit.org/show_bug.cgi?id=63432

This code isn't in the dependency cone of new-run-webkit-tests. It's
unclear what it's final home should be, but this patch moves it out of
layout_tests to simply the package.

  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Removed.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Removed.
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py.
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py.
12:20 AM Changeset in webkit [89793] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move update_webgl_conformance_tests.py to webkitpy.to_be_moved
https://bugs.webkit.org/show_bug.cgi?id=63429

This package as nothing to do with the layout_tests package.

  • Scripts/update-webgl-conformance-tests:
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Removed.
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Removed.
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py.
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py.
12:11 AM Changeset in webkit [89792] by yutak@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-06-27 Yuta Kitamura <yutak@chromium.org>

Reviewed by Adam Barth.

[Chromium] Add useHixie76WebSocketProtocol to WebSettings
https://bugs.webkit.org/show_bug.cgi?id=63424

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setHixie76WebSocketProtocolEnabled):
  • src/WebSettingsImpl.h:
12:10 AM Changeset in webkit [89791] by abarth@webkit.org
  • 3 edits
    2 moves
    2 adds in trunk/Tools

2011-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move deduplicate_tests.py into webkitpy.to_be_moved
https://bugs.webkit.org/show_bug.cgi?id=63426

deduplicate_tests.py doesn't haven anything to do with layout tests.
It's really a separate script. This patch moves it to the (new)
to_be_moved package so that it doesn't distract us when working on NRWT.

  • Scripts/deduplicate-tests:
  • Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
  • Scripts/webkitpy/test/main.py:
  • Scripts/webkitpy/to_be_moved: Added.
  • Scripts/webkitpy/to_be_moved/init.py: Added.
  • Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
  • Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.

Jun 26, 2011:

11:50 PM Changeset in webkit [89790] by mrowe@apple.com
  • 4 edits in trunk/Source

Use a separate file name for Lion's WebKitSystemInterface.

Reviewed by Dan Bernstein.

Source/WebKit/mac:

  • Configurations/DebugRelease.xcconfig:

Source/WebKit2:

  • Configurations/DebugRelease.xcconfig:
11:49 PM Changeset in webkit [89789] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove LegacyDefaultOptionalArguments from WebAudio IDL files
https://bugs.webkit.org/show_bug.cgi?id=63416

WebAudio isn't that widely used, so it's seems somewhat safe to remove
legacy code generation hacks. I'm not an expert on WebAudio, but the
API doesn't appear to need many optional arguments.

There are a bunch of APIs that have custom bindings that look like they
could be autogenerated. I've added FIXME comments where appropriate.

  • webaudio/AudioBuffer.idl:
  • webaudio/AudioContext.idl:
  • webaudio/AudioListener.idl:
  • webaudio/AudioNode.idl:
  • webaudio/AudioPannerNode.idl:
  • webaudio/AudioParam.idl:
  • webaudio/RealtimeAnalyserNode.idl:
11:40 PM Changeset in webkit [89788] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Tools

2011-06-26 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Remove empty directory.

  • Scripts/webkitpy/layout_tests/test_types: Removed.
11:40 PM Changeset in webkit [89787] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION Scripts panel sidebar pane context menu has no "Remove breakpoint" item
https://bugs.webkit.org/show_bug.cgi?id=63421

Show generic sidebar menu only if no pane-specific menu has been shown.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
11:39 PM Changeset in webkit [89786] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <abarth@webkit.org>

Build fix for clang. Apparently clang doesn't want us to use the std
namespace in headers, which makes sense.

  • svg/SVGAnimatedType.h:
11:31 PM Changeset in webkit [89785] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove LegacyDefaultOptionalArguments from XMLHttpRequest.idl and XMLHttpRequestUpload.idl
https://bugs.webkit.org/show_bug.cgi?id=63418

The XMLHttpRequest.idl interface used to implement the new behavior
manually using the RequiresAllArguments attribute. Now that we have
that behavior by default, we can simply remove the
LegacyDefaultOptionalArguments attribute.

  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.idl:
11:22 PM Changeset in webkit [89784] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9679221&9679235> Work around an issue with sandbox.h.

Rubber-stamped by Maciej Stachowiak.

  • WebProcess/mac/WebProcessMac.mm:
11:16 PM Changeset in webkit [89783] by krit@webkit.org
  • 15 edits
    13 adds in trunk

2011-06-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGLengthList animation
https://bugs.webkit.org/show_bug.cgi?id=63399


Test animations of attributes with type SVGLengthList.

  • svg/animations/script-tests/svglengthlist-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglengthlist-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglengthlist-animation-3.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svglengthlist-animation-4.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svglengthlist-animation-1-expected.txt: Added.
  • svg/animations/svglengthlist-animation-1.html: Added.
  • svg/animations/svglengthlist-animation-2-expected.txt: Added.
  • svg/animations/svglengthlist-animation-2.html: Added.
  • svg/animations/svglengthlist-animation-3-expected.txt: Added.
  • svg/animations/svglengthlist-animation-3.html: Added.
  • svg/animations/svglengthlist-animation-4-expected.txt: Added.
  • svg/animations/svglengthlist-animation-4.html: Added.

2011-06-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGLengthList animation
https://bugs.webkit.org/show_bug.cgi?id=63399

Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedLengthList.


Interpolated animations of glyph positions are possible now.

Tests: svg/animations/svglengthlist-animation-1.html

svg/animations/svglengthlist-animation-2.html
svg/animations/svglengthlist-animation-3.html
svg/animations/svglengthlist-animation-4.html

  • CMakeLists.txt: Add new file to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of AnimatedLengthList. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedLengthList.cpp: Added. New animator for SVGLengthList. (WebCore::SVGAnimatedLengthListAnimator::SVGAnimatedLengthListAnimator): (WebCore::SVGAnimatedLengthListAnimator::constructFromString): (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedLengthListAnimator::calculateDistance):
  • svg/SVGAnimatedLengthList.h: (WebCore::SVGAnimatedLengthListAnimator::~SVGAnimatedLengthListAnimator):
  • svg/SVGAnimatedType.cpp: Add SVGLengthList. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createLengthList): (WebCore::SVGAnimatedType::lengthList): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: (WebCore::SVGAnimatorFactory::create):
  • svg/SVGLength.cpp: Add new constructor with LengthType, LengthMode and value. (WebCore::SVGLength::SVGLength):
  • svg/SVGLength.h:
9:49 PM Changeset in webkit [89782] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

window.location should use the holder's prototype chain
https://bugs.webkit.org/show_bug.cgi?id=63411

  • http/tests/security/location-prototype-expected.txt: Added.
  • http/tests/security/location-prototype.html: Added.
  • http/tests/security/resources/location-prototype-overwrite.html: Added.

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

window.location should use the holder's prototype chain
https://bugs.webkit.org/show_bug.cgi?id=63411

This patch corrects the prototype chain for Location, but we really
should do a complete cleanup of the prototype chain generation, like we
did for JavaScriptCore.

Test: http/tests/security/location-prototype.html

  • bindings/scripts/CodeGeneratorV8.pm:
9:45 PM Changeset in webkit [89781] by abarth@webkit.org
  • 18 edits in trunk/Source/WebCore

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add [Optional] attributes where appropriate for addEventListener and removeEventListener
https://bugs.webkit.org/show_bug.cgi?id=63417

This patch doesn't actually change behavior because these interfaces
have the LegacyDefaultOptionalArguments attribute. This patch paves
the way to removing LegacyDefaultOptionalArguments from some of these
interfaces as well as making the project safer for copy-and-pasting
these methods into new IDL files that don't have the
LegacyDefaultOptionalArguments attribute.

  • bindings/scripts/test/TestObj.idl:
  • dom/EventTarget.idl:
  • dom/MediaStream.idl:
  • dom/MessagePort.idl:
  • dom/Node.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • notifications/Notification.idl:
  • page/DOMWindow.idl:
  • page/EventSource.idl:
  • storage/IDBRequest.idl:
  • storage/IDBTransaction.idl:
  • svg/SVGElementInstance.idl:
  • websockets/WebSocket.idl:
  • workers/AbstractWorker.idl:
  • workers/WorkerContext.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.idl:
8:43 PM Changeset in webkit [89780] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Kent Tamura.

m_formElementsWithFormAttribute doesn't ref the objects it holds
https://bugs.webkit.org/show_bug.cgi?id=62956

  • fast/forms/form-associated-element-crash3-expected.txt: Added.
  • fast/forms/form-associated-element-crash3.html: Added.

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Kent Tamura.

m_formElementsWithFormAttribute doesn't ref the objects it holds
https://bugs.webkit.org/show_bug.cgi?id=62956

Test: fast/forms/form-associated-element-crash3.html

  • dom/Document.h:
8:34 PM Changeset in webkit [89779] by takano.naoki@gmail.com
  • 2 edits in trunk/Tools

Change committers entry.w

8:15 PM Changeset in webkit [89778] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove WebSecurityOrigin::grantUniversalAccess
https://bugs.webkit.org/show_bug.cgi?id=63415

This function has no callers and is downright dangerous.

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp:
6:47 PM Changeset in webkit [89777] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

2011-06-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

FileList::filenames should be FileList::paths, because it's more accurate.
https://bugs.webkit.org/show_bug.cgi?id=63414

Refactoring, no change in behavior.

  • fileapi/FileList.cpp: (WebCore::FileList::paths): Renamed from filenames.
  • fileapi/FileList.h:
  • html/FileInputType.cpp: (WebCore::FileInputType::handleDOMActivateEvent): Changed to use filenames, also fixed a reach-unto-thyself whoopsie. (WebCore::FileInputType::requestIcon): Ditto. (WebCore::FileInputType::filesChosen): Ditto.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::fileTextValue): Ditto.
5:31 PM Changeset in webkit [89776] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

2011-06-26 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Functions needing Ewk_View_Private_Data as parameter are not part of public API.
https://bugs.webkit.org/show_bug.cgi?id=62688

Move functions which use Ewk_View_Private_Data and may not be required by
applications to ewk_private.h.

  • ewk/ewk_private.h:
  • ewk/ewk_view.h:
4:06 PM Changeset in webkit [89775] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-26 Adam Barth <abarth@webkit.org>

Baselines for new test.

  • platform/chromium-linux/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
  • platform/chromium-linux/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
  • platform/chromium-win/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
  • platform/chromium-win/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
2:26 PM Changeset in webkit [89774] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-06-26 Young Han Lee <joybro@company100.net>

Reviewed by Dirk Schulze.

SVGAnimation - keyTime value 1 never get animated
https://bugs.webkit.org/show_bug.cgi?id=63230

According to the SMIL 3.0 specification, the index of the keyTimes should be
determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1)
and t=0.5, the current index of the keyTimes have to be 1 not 0).
http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced

  • svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt: Added.
  • svg/animations/animate-number-calcMode-discrete-keyTimes.html: Added.
  • svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-06-26 Young Han Lee <joybro@company100.net>

Reviewed by Dirk Schulze.

SVGAnimation - keyTime value 1 never get animated
https://bugs.webkit.org/show_bug.cgi?id=63230

According to the SMIL 3.0 specification, the index of the keyTimes should be
determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1)
and t=0.5, the current index of the keyTimes have to be 1 not 0).
http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced

Test: svg/animations/animate-number-calcMode-discrete-keyTimes.html

  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculateKeyTimesIndex):
1:21 PM Changeset in webkit [89773] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-06-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove code behind WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
https://bugs.webkit.org/show_bug.cgi?id=63402

These old APIs are no longer needed.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
12:30 PM Changeset in webkit [89772] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-06-26 Filip Pizlo <fpizlo@apple.com>

Reviewed by Gavin Barraclough.

DFG non-speculative JIT has potentially harmful speculations with respect to arithmetic operations.
https://bugs.webkit.org/show_bug.cgi?id=63347

  • dfg/DFGNonSpeculativeJIT.cpp:
    • Changed arithmetic operations to speculate in favor of integers.

(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGOperations.cpp:
    • Added slow-path routines for arithmetic that perform no speculation; the non-speculative JIT will generate calls to these in cases where its speculation fails.
  • dfg/DFGOperations.h:
10:17 AM Changeset in webkit [89771] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-06-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Don't use a Mutex for protecting access to the connection queue clients
https://bugs.webkit.org/show_bug.cgi?id=63403

Make sure to only access the queue client vector from the connection work queue.
This gets rid of a lock and ensures that adding/removing clients from callbacks works correctly.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::addQueueClient): (CoreIPC::Connection::removeQueueClient): (CoreIPC::Connection::addQueueClientOnWorkQueue): (CoreIPC::Connection::removeQueueClientOnWorkQueue): (CoreIPC::Connection::processIncomingMessage):
  • Platform/CoreIPC/Connection.h:
10:04 AM Changeset in webkit [89770] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-26 Adam Barth <abarth@webkit.org>

Darn. Need BUGWG to make the file parse.

  • platform/chromium/test_expectations.txt:
9:09 AM Changeset in webkit [89769] by mitz@apple.com
  • 3 edits
    3 adds in trunk

With word-break: break-all, words do not break correctly before a surrogate pair
https://bugs.webkit.org/show_bug.cgi?id=63401

Reviewed by Darin Adler.

Source/WebCore:

The code to check for mid-word breaks accumulates width one character at a time. It was actually
measuring the two parts of the surrogate pair individually, so they appeared to have zero width.
Fixed by checking for surrogate pairs and measuring the pair as one unit.

Test: fast/text/midword-break-before-surrogate-pair.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

  • fast/text/midword-break-before-surrogate-pair.html: Added.
7:22 AM Changeset in webkit [89768] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-26 Adam Barth <abarth@webkit.org>

Note that this test ASSERTs on Linux Debug.

  • platform/chromium/test_expectations.txt:
6:12 AM Changeset in webkit [89767] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.

[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

Skip new tests that depend on pause API. Put them to the
mac list that is used by all WebKit2 platforms.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
4:24 AM Changeset in webkit [89766] by krit@webkit.org
  • 13 edits
    14 adds in trunk

2011-06-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberOptionalNumber animation
https://bugs.webkit.org/show_bug.cgi?id=63397


Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedNumberOptionalNumber.


Animations of attributes with type SVGAnimatedNumberOptionalNumber can be interpolated now. This can be used for smooth
growing shadows with feGaussianBlur, feDropShadow or other filter effects.

Tests: svg/animations/svgnumberoptionalnumber-animation-1.html

svg/animations/svgnumberoptionalnumber-animation-2.html
svg/animations/svgnumberoptionalnumber-animation-3.html
svg/animations/svgnumberoptionalnumber-animation-4.html

  • CMakeLists.txt: Added new files to build system.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • svg/SVGAllInOne.cpp: Ditto.
  • svg/SVGAnimateElement.cpp: Make use of attribute type AnimatedNumberOptionalNumber. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimatedNumberOptionalNumber.cpp: Added. New animator for SVGAnimatedNumberOptionalNumber. (WebCore::SVGAnimatedNumberOptionalNumberAnimator::SVGAnimatedNumberOptionalNumberAnimator): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromString): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateDistance):
  • svg/SVGAnimatedNumberOptionalNumber.h: Added. (WebCore::SVGAnimatedNumberOptionalNumberAnimator::~SVGAnimatedNumberOptionalNumberAnimator):
  • svg/SVGAnimatedType.cpp: Added new type: pair<float, float>. (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::createNumberOptionalNumber): (WebCore::SVGAnimatedType::numberOptionalNumber): (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString):
  • svg/SVGAnimatedType.h:
  • svg/SVGAnimatorFactory.h: Add new animator to factory. (WebCore::SVGAnimatorFactory::create):

2011-06-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimatedType should support SVGNumberOptionalNumber animation
https://bugs.webkit.org/show_bug.cgi?id=63397


Test animation of SVGNumberOptionalNumber values with and without optional number, as well as 'to' and 'by' animations.

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/svgnumberoptionalnumber-animation-1-expected.txt: Added.
  • svg/animations/svgnumberoptionalnumber-animation-1.html: Added.
  • svg/animations/svgnumberoptionalnumber-animation-2-expected.txt: Added.
  • svg/animations/svgnumberoptionalnumber-animation-2.html: Added.
  • svg/animations/svgnumberoptionalnumber-animation-3-expected.txt: Added.
  • svg/animations/svgnumberoptionalnumber-animation-3.html: Added.
  • svg/animations/svgnumberoptionalnumber-animation-4-expected.txt: Added.
  • svg/animations/svgnumberoptionalnumber-animation-4.html: Added.
2:35 AM Changeset in webkit [89765] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-26 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed. Skip failing tests.

[Qt][WK2] svgnumberlist-animation-[1,2] fails since added
https://bugs.webkit.org/show_bug.cgi?id=63396

  • platform/qt-wk2/Skipped:
Note: See TracTimeline for information about the timeline view.