Timeline
Sep 26, 2011:
- 11:55 PM Changeset in webkit [96076] by
-
- 2 edits1 move8 deletes in trunk/LayoutTests
dump-as-markup conversion: editing/deleting/delete-to-end-of-paragraph.html
https://bugs.webkit.org/show_bug.cgi?id=68865
Reviewed by Kent Tamura.
Converted the test.
- editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
- editing/deleting/delete-to-end-of-paragraph.html:
- platform/chromium-linux/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
- platform/mac-leopard/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
- platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
- platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
- platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
- platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
- 11:43 PM Changeset in webkit [96075] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip two tests because they are failing after r96070.
Unreviewed gardening.
- platform/qt/Skipped:
- 11:32 PM Changeset in webkit [96074] by
-
- 5 edits in trunk/Tools
garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
https://bugs.webkit.org/show_bug.cgi?id=68864
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
- 11:27 PM Changeset in webkit [96073] by
-
- 14 edits1 copy in trunk
Implement PopStateEvent.state with SerializedScriptValue and ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=68345
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-26
Reviewed by Adam Barth.
Source/WebCore:
Previously, the following test cases fail or crash:
- shouldBe("new PopStateEvent('eventType', { state: object1 }).state", "object1") -> FAIL
- new PopStateEvent('eventType', { state: document }).state -> CRASH in DRT
This is because PopStateEvent.state is implemented not as ScriptValue but as SerializedScriptValue.
However, we cannot simply change the type of PopStateEvent.state to ScriptValue,
since PopStateEvent can be constructed in the context that does not know ScriptValue.
For example, Document.cpp calls PopStateEvent::create() with SerializedScriptValue
popped from HistoryItem, but we cannot deserialize the SerializedScriptValue into
the corresponding ScriptValue here because the deserialization requires ExecState.
In other words, although we want to store PopStateEvent.state by ScriptValue internally,
PopStateEvent still needs to provide an API to construct it with SerializedScriptValue.
With these observations, this patch makes the following changes:
- If PopStateEvent is constructed with ScriptValue, it is stored as ScriptValue internally.
When PopStateEvent.state is called, the ScriptValue is returned.
- If PopStateEvent is constructed with SerializedScriptValue, it is stored as
SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
at this point). When PopStateEvent.state is called, the SerializedScriptValue is
deserialized into the corresponding ScriptValue, and the ScriptValue is returned.
Tests: fast/events/constructors/pop-state-event-constructor.html
fast/events/fire-popstate-event.html
- GNUmakefile.list.am: Added JSPopStateEventCustom.cpp.
- UseJSC.cmake: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSBindingsAllInOne.cpp: Ditto.
- bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state): Custom getter for PopStateEvent.state.
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter): Custom getter for PopStateEvent.state.
- dom/PopStateEvent.cpp:
(WebCore::PopStateEventInit::PopStateEventInit): Added initialization code for PopStateEvent.m_state.
(WebCore::PopStateEvent::PopStateEvent): Ditto.
(WebCore::PopStateEvent::create): Ditto.
(WebCore::PopStateEvent::initPopStateEvent): Ditto.
- dom/PopStateEvent.h:
(WebCore::PopStateEvent::serializedState): Getter.
(WebCore::PopStateEvent::state): Getter.
- dom/PopStateEvent.idl: Change the type of 'stateArg' and 'state' to DOMObject. Added [CustomGetter] to 'state'.
LayoutTests:
- fast/events/constructors/pop-state-event-constructor-expected.txt:
- fast/events/constructors/pop-state-event-constructor.html: Removed failures and crashes. Added one test case.
- 11:26 PM Changeset in webkit [96072] by
-
- 2 edits in trunk/Tools
[Qt][WK2] One more unreviewed buildfix after r96005.
- WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
- 11:15 PM Changeset in webkit [96071] by
-
- 2 edits in trunk/Tools
[Qt][WK2] Unreviewed buildfix after r96005.
- WebKitTestRunner/qt/TestInvocationQt.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- 10:50 PM Changeset in webkit [96070] by
-
- 8 edits in trunk
Pixel result shows that compositing/iframes/repaint-after-losing-scrollbars.html is failing
https://bugs.webkit.org/show_bug.cgi?id=67858
Reviewed by Darin Adler.
When non-overlay scrollbars are hidden on a composited iframe, nothing invalidated
the scrollbar areas or the scroll corner, so the scrollbars appear to remain.
Fix by invalidating the scrollbars and scroll corner when they are removed. Invalidation
on scrollbar creation appears to happen via updating the scrollbar style.
Tested by compositing/iframes/repaint-after-losing-scrollbars.html which no longer shows
stale scrollbars when run manually, even though the green squares are missing from the
pixel result (bug 67878).
- page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner): Pass the corner rect into invalidateScrollCorner().
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Invalidate the scrollbar area if hiding it.
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): In the case where both scrollbars are going away,
compute the scroll corner rect while we still have scrollbars, and then invalidate it
explicitly. (updateScrollCorner() doesn't, because it doesn't have access to the old corner
rect.)
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollCorner): Pass the rect in, because we can't
compute it in the case where the scrollbars are going away.
- platform/ScrollableArea.h: Pass in a rect to invalidateScrollCorner(), which matches
invalidateScrollbar().
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::destroyRootLayer): Pass the corner rect into invalidateScrollCorner().
- rendering/RenderScrollbarPart.cpp: Ditto.
(WebCore::RenderScrollbarPart::imageChanged): Ditto.
- 10:12 PM Changeset in webkit [96069] by
-
- 3 edits3 adds in trunk
Translucent scrollbars on composited layers render incorrectly
https://bugs.webkit.org/show_bug.cgi?id=58515
Source/WebCore:
Reviewed by Sam Weinig.
Scrollbars in composited elements were getting drawn twice,
because r41203 moved the call to paintOverflowControls() out of
RenderLayer::paintLayer(), but forgot to change RenderLayerBacking::paintIntoLayer().
Test: compositing/scrollbar-painting.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
LayoutTests:
Reviewed by Sam Weinig.
Pixel test with translucent scrollbars, to test whether they get
rendered twice.
- compositing/scrollbar-painting-expected.png: Added.
- compositing/scrollbar-painting-expected.txt: Added.
- compositing/scrollbar-painting.html: Added.
- 8:24 PM Changeset in webkit [96068] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r95912): Conservative marking doesn't filter out pointers to
MarkedBlock metadata
https://bugs.webkit.org/show_bug.cgi?id=68860
Reviewed by Oliver Hunt.
Bencher says no performance change, maybe a 7% speedup on kraken-imaging-darkroom.
- heap/MarkedBlock.h:
(JSC::MarkedBlock::isAtomAligned): Renamed atomMask to atomAlignment mask
because the mask doesn't produce the actual atom number.
(JSC::MarkedBlock::isLiveCell): Testing just for alignment isn't good
enough; we also need to test that a pointer is beyond the metadata section
of a MarkedBlock, to avoid treating random metadata as a JSCell.
- 7:36 PM Changeset in webkit [96067] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix WK2 build after r96014
https://bugs.webkit.org/show_bug.cgi?id=68856
Reviewed by Gustavo Noronha Silva.
Commit r96014 added inspectorBaseURL for Qt but removed
inspectorPageURL, adding it back.
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::inspectorPageURL):
- 7:18 PM Changeset in webkit [96066] by
-
- 17 edits in trunk/Source
[chromium] Make CCThreadProxy draw
https://bugs.webkit.org/show_bug.cgi?id=67417
Source/WebCore:
Update the CCThreadProxy to correctly implement the CCProxy
interface, do all the right committing and updating steps, and
draw a picture on the screen.
Patch by Nat Duca <nduca@chromium.org> on 2011-09-26
Reviewed by James Robinson.
- platform/graphics/IntRect.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::~LayerRendererChromium):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::drawLayersAndReadbackOnCCThread):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
Disable CCLayerTreeHostTest temporarily. Will re-enable
with https://bugs.webkit.org/show_bug.cgi?id=67418
Patch by Nat Duca <nduca@chromium.org> on 2011-09-26
Reviewed by James Robinson.
- tests/CCLayerTreeHostTest.cpp:
- 7:07 PM Changeset in webkit [96065] by
-
- 2 edits in trunk/LayoutTests
Put back all Chromium platform failing expectations for some tests (they
still fail on all platforms on the GPU bots).
- platform/chromium/test_expectations.txt:
- 6:44 PM Changeset in webkit [96064] by
-
- 9 edits3 adds in trunk/Source/WebCore
[MutationObservers] implement MutationRecord
https://bugs.webkit.org/show_bug.cgi?id=68824
Reviewed by Darin Adler.
Implements MutationRecord as specified in the thread at
http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html,
including some minor naming changes from the original proposal.
This is a small part of the MutationObserver API, see
https://bugs.webkit.org/show_bug.cgi?id=68729 for the metabug covering
this feature.
No new tests as this isn't yet exposed to the platform.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/MutationRecord.cpp: Added.
(WebCore::MutationRecord::createChildList):
(WebCore::MutationRecord::createAttributes):
(WebCore::MutationRecord::createCharacterData):
(WebCore::MutationRecord::MutationRecord):
(WebCore::MutationRecord::~MutationRecord):
- dom/MutationRecord.h: Added.
(WebCore::MutationRecord::target):
(WebCore::MutationRecord::addedNodes):
(WebCore::MutationRecord::removedNodes):
(WebCore::MutationRecord::previousSibling):
(WebCore::MutationRecord::nextSibling):
(WebCore::MutationRecord::attributeName):
(WebCore::MutationRecord::attributeNamespace):
(WebCore::MutationRecord::oldValue):
(WebCore::MutationRecord::setOldValue):
- dom/MutationRecord.idl: Added.
- 6:40 PM Changeset in webkit [96063] by
-
- 1 edit in branches/chromium/835/Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp
Merge 95012 - [chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=67943
Reviewed by Adam Barth.
- src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess
allowing the automatic ref counting to work. This was previous needed when
the ref counting wasn't working but that was fixed in r94986. Note that the
design was to have ref counting since the methods take PassRefPtr and the
class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
adding in AllowCrossThreadAccess.)
(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
(WebKit::WorkerFileWriterCallbacksBridge::didFail):
(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/8054006
- 6:39 PM Changeset in webkit [96062] by
-
- 2 edits in branches/chromium/835/Source/WebCore/platform
Merge 94986 - Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*.
https://bugs.webkit.org/show_bug.cgi?id=67947
Reviewed by Adam Barth.
The changes are tested by compiling and added compile asserts to do some verification as well.
- platform/CrossThreadCopier.cpp:
Added some compile asserts to verify various match and non-matches for CrossThreadCopier.
- platform/CrossThreadCopier.h:
Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr.
Added a compile assert to verify that only one of the typedefs did anything.
(CrossThreadCopierBase<false, true, T>::copy): Remove "get" as it is unnecessary.
It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently
convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method.
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/8057001
- 6:36 PM Changeset in webkit [96061] by
-
- 7 edits in trunk
Implement a CloseEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68793
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-26
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/close-event-constructor.html
- bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::getKey): Just removed an extra space.
(WebCore::OptionsObject::getKeyValue): Returns an unsigned short value corresponding to the given key.
- bindings/v8/OptionsObject.h:
- bindings/v8/custom/V8EventConstructors.cpp: Added the CloseEvent constructor.
- websockets/CloseEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled close-event-constructor.html, since now V8 has the CloseEvent constructor.
- platform/chromium/test_expectations.txt:
- 6:29 PM Changeset in webkit [96060] by
-
- 22 edits in trunk/Source/WebCore
Clean up CachedResource::load(). Collapse its
logic into a single callsite, taking just a
CachedResourceLoader and a ResourceLoaderOptions.
- Its 'incremental' parameter is redundant.
- With 'incremental' removed, the SecurityCheckPolicy is the only parameter difference between the CachedResource::load() variants. Making it a part of ResourceLoaderOptions removes yet another random enum that is passed around individually.
- We currently have to call setResourceLoaderOptions() before load() on a new CachedResource, so we should just take the ResourceLoaderOptions in load().
https://bugs.webkit.org/show_bug.cgi?id=67443
Reviewed by Antti Koivisto.
No new tests, refactor only.
- loader/DocumentThreadableLoader.cpp:
- loader/FrameLoaderTypes.h: Move SecurityCheckPolicy to ResourceLoaderOptions.h.
- loader/MainResourceLoader.cpp:
- loader/NetscapePlugInStreamLoader.cpp:
- loader/ResourceLoadScheduler.cpp:
- loader/ResourceLoadScheduler.h:
- loader/ResourceLoader.cpp: Enforce SecurityCheckPolicy here instead of SubresourceLoader.
- loader/ResourceLoaderOptions.h: Store SecurityCheckPolicy on ResourceLoaderOptions.
- loader/SubresourceLoader.cpp:
- loader/SubresourceLoader.h:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedFont.h:
- loader/cache/CachedImage.cpp:
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.cpp:
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::defaultCachedResourceOptions): Define the default ResourceLoaderOptions for
CachedResource loads here instead of as a default parameter on requestResource().
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveData): Remove m_incremental, since its purpose
is already enforced in the data() implementation of every CachedResource that doesn't want
incremental loads.
- loader/cache/CachedResourceRequest.h:
- 6:27 PM Changeset in webkit [96059] by
-
- 2 edits in trunk/Tools
garden-o-matic should be pretty in Open Sans.
https://bugs.webkit.org/show_bug.cgi?id=68845
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
- 6:13 PM Changeset in webkit [96058] by
-
- 2 edits in trunk/LayoutTests
Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 5:57 PM Changeset in webkit [96057] by
-
- 2 edits in trunk/LayoutTests
editing/selection/select-bidi-run.html fails on Chromium Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=68832
Unreviewed; remove the failing test expectation because it started passing after r96016.
- platform/chromium/test_expectations.txt:
- 5:55 PM Changeset in webkit [96056] by
-
- 3 edits in trunk/LayoutTests
Skip the test added by r95964 on Qt and GTK because it has been failing
on those two platforms. The failure is tracked by the bugs 68854 and 68855.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 5:52 PM Changeset in webkit [96055] by
-
- 4 edits in trunk/Tools
garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
https://bugs.webkit.org/show_bug.cgi?id=68841
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
- 5:43 PM Changeset in webkit [96054] by
-
- 30 edits2 adds in trunk
IndexedDB: Second half of IDBFactory.getDatabaseNames implementation
https://bugs.webkit.org/show_bug.cgi?id=68818
Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-26
Reviewed by Tony Chang.
Source/WebCore:
Test: storage/indexeddb/factory-basics.html
Adds ability to enumerate IndexedDB databases within an origin.
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
- storage/IDBAny.cpp:
(WebCore::IDBAny::domStringList):
(WebCore::IDBAny::set):
- storage/IDBAny.h:
- storage/IDBBackingStore.h:
- storage/IDBCallbacks.h:
- storage/IDBFactory.cpp:
(WebCore::IDBFactory::getDatabaseNames):
- storage/IDBFactory.h:
- storage/IDBFactory.idl:
- storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
- storage/IDBFactoryBackendImpl.h:
- storage/IDBFactoryBackendInterface.h:
- storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getDatabaseNames):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::getIndexes):
- storage/IDBLevelDBBackingStore.h:
- storage/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeMinKeyForOrigin):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeStopKeyForOrigin):
- storage/IDBLevelDBCoding.h:
- storage/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
- storage/IDBRequest.h:
- storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::getDatabaseNames):
- storage/IDBSQLiteBackingStore.h:
Source/WebKit/chromium:
Adds ability to enumerate IndexedDB databases within an origin.
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::getDatabaseNames):
- src/IDBFactoryBackendProxy.h:
- src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess):
- src/WebIDBCallbacksImpl.h:
- src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
- src/WebIDBFactoryImpl.h:
LayoutTests:
Adds ability to enumerate IndexedDB databases within an origin.
- storage/indexeddb/factory-basics-expected.txt: Added.
- storage/indexeddb/factory-basics.html: Added.
- 5:40 PM Changeset in webkit [96053] by
-
- 2 edits8 adds in trunk/LayoutTests
Remove failing Chromium expectations for tests that now pass.
Rebaseline repaint tests for Chromium Snow Leopard CG after r96005.
- platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/inline-block-overflow-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/layer-child-outline-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/layer-outline-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/layer-outline-horizontal-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/text-shadow-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/text-shadow-horizontal-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 5:36 PM Changeset in webkit [96052] by
-
- 3 edits3 adds in trunk
<animateColor> applied to filtered ellipse does not update
https://bugs.webkit.org/show_bug.cgi?id=68457
<rdar://problem/10154777>
Reviewed by Darin Adler.
Invalidate the filter's cache when style changes take place so that style changes are respected.
Test: svg/filters/animate-fill.svg
- 5:35 PM Changeset in webkit [96051] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] [WK2] Fix build after r95982
https://bugs.webkit.org/show_bug.cgi?id=68842
Reviewed by Anders Carlsson.
The patch in r95982 removed the paint() function, because it was doing
nothing (in both implementations). This patch remove the call we had
for it to fix the build.
- UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::paintContent):
- 5:24 PM Changeset in webkit [96050] by
-
- 2 edits2 deletes in branches/chromium/835
Revert 96034 - Merge 95791 - use after free in WebCore::SVGTRefElement::updateReferencedText
BUG=95359
Review URL: http://codereview.chromium.org/8046025
TBR=cdn@chromium.org
Review URL: http://codereview.chromium.org/8041053
- 5:23 PM Changeset in webkit [96049] by
-
- 2 edits in trunk/Source/WebKit/chromium
Removed an unnecessary include in WebFrameImpl
https://bugs.webkit.org/show_bug.cgi?id=68834
Reviewed by Darin Fisher.
- src/WebFrameImpl.cpp:
- 5:23 PM Changeset in webkit [96048] by
-
- 2 edits1 add in trunk/LayoutTests
Remove failing expectations for some ruby tests, since they were
renamed to -disabled with r94327 and thus aren't being run at all.
Add compositing/video-page-visibility.html Windows GPU baselines.
- platform/chromium-gpu-win/compositing/video-page-visibility-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 5:06 PM Changeset in webkit [96047] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 5:03 PM Changeset in webkit [96046] by
-
- 4 edits in trunk/Tools
watchlist: Add parsing for definition section.
https://bugs.webkit.org/show_bug.cgi?id=68850
Reviewed by Adam Barth.
- Scripts/webkitpy/common/watchlist/watchlist.py:
- Scripts/webkitpy/common/watchlist/watchlistparser.py:
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
- 4:53 PM Changeset in webkit [96045] by
-
- 9 edits in trunk/Source/JavaScriptCore
Make JSCell::toBoolean non-virtual
https://bugs.webkit.org/show_bug.cgi?id=67727
Reviewed by Geoffrey Garen.
JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
before it was simply virtual and would crash if its implementation was called).
Its descendants in JSObject and JSString have also been made non-virtual. JSCell now
explicitly covers all cases of toBoolean, so having a virtual implementation of
JSCell::toBoolean is no longer necessary. This is part of a larger process of un-virtualizing JSCell.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- runtime/JSCell.cpp:
- runtime/JSCell.h:
- runtime/JSNotAnObject.cpp:
- runtime/JSNotAnObject.h:
- runtime/JSObject.h:
- runtime/JSString.h:
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):
- 4:45 PM Changeset in webkit [96044] by
-
- 1 edit in branches/chromium/835/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp
Merge 96020 - OfflineAudioDestinationNode must wait for thread completion in uninitialize()
BUG=96149
Review URL: http://codereview.chromium.org/8044037
- 4:43 PM Changeset in webkit [96043] by
-
- 1 edit in branches/chromium/835/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp
Merge 95124 - Address lifetime issues in OfflineAudioDestinationNode (take 2)
BUG=96149
Review URL: http://codereview.chromium.org/8038042
- 4:42 PM Changeset in webkit [96042] by
-
- 1 edit in branches/chromium/835/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp
Merge 94984 - Address lifetime issues in OfflineAudioDestinationNode
BUG=96149
Review URL: http://codereview.chromium.org/8037053
- 4:40 PM Changeset in webkit [96041] by
-
- 5 edits in branches/safari-534.51-branch/Source
Versioning.
- 4:39 PM Changeset in webkit [96040] by
-
- 1 copy in tags/Safari-534.51.23
New tag.
- 4:39 PM Changeset in webkit [96039] by
-
- 5 edits in branches/chromium/835/Source/WebCore
Merge 95093 - 2011-09-13 Pavel Feldman <pfeldman@google.com>
BUG=96170
Review URL: http://codereview.chromium.org/8028048
- 4:38 PM Changeset in webkit [96038] by
-
- 4 edits in branches/safari-534.51-branch/Source/WebCore
Merge r95863.
- 4:36 PM Changeset in webkit [96037] by
-
- 2 edits in releases/WebKitGTK/webkit-1.6
Update the release number for 1.6.0 and add the NEWS information
- 4:36 PM Changeset in webkit [96036] by
-
- 1 edit in branches/chromium/835/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp
Merge 95124 - Address lifetime issues in OfflineAudioDestinationNode (take 2)
BUG=96150
Review URL: http://codereview.chromium.org/8044036
- 4:35 PM Changeset in webkit [96035] by
-
- 1 edit in branches/chromium/835/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp
Merge 94984 - Address lifetime issues in OfflineAudioDestinationNode
BUG=96150
Review URL: http://codereview.chromium.org/8044035
- 4:31 PM Changeset in webkit [96034] by
-
- 2 edits2 copies in branches/chromium/835
Merge 95791 - use after free in WebCore::SVGTRefElement::updateReferencedText
BUG=95359
Review URL: http://codereview.chromium.org/8046025
- 4:29 PM Changeset in webkit [96033] by
-
- 2 edits in trunk/LayoutTests
Remove failing Chromium test expectations for tests that now pass
(mainly due to r95751, which implemented Function.prototype.bind for
JSC, resulting in baseline updates that now work for V8 too).
- platform/chromium/test_expectations.txt:
- 4:26 PM Changeset in webkit [96032] by
-
- 2 edits2 copies in branches/chromium/835
Merge 95204 - 2011-09-15 James Simonsen <simonjam@chromium.org>
BUG=95761
Review URL: http://codereview.chromium.org/8037052
- 4:23 PM Changeset in webkit [96031] by
-
- 1 edit3 copies in branches/chromium/835
Merge 95488 - Named property confusion with proto
BUG=95671
Review URL: http://codereview.chromium.org/8036045
- 4:21 PM Changeset in webkit [96030] by
-
- 8 edits2 adds in trunk
Set but unused variables cleanup in v8 bindings (gcc 4.6)
https://bugs.webkit.org/show_bug.cgi?id=68079
Patch by Max Perepelitsyn <pph34r@gmail.com> on 2011-09-26
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/websocket/tests/hybi/send-object-tostring-check.html
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
- bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
- bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback):
LayoutTests:
- http/tests/websocket/tests/hybi/send-object-tostring-check-expected.txt: Added.
- http/tests/websocket/tests/hybi/send-object-tostring-check.html: Added.
- 4:20 PM Changeset in webkit [96029] by
-
- 1 edit in branches/chromium/835/Source/WebCore/dom/Range.cpp
Merge 94512 - Unreviewed. Compile fix for r94511.
BUG=95360
Review URL: http://codereview.chromium.org/8048007
- 4:13 PM Changeset in webkit [96028] by
-
- 1 edit2 copies in branches/chromium/835
Merge 94511 - Crash in Range::processAncestorsAndTheirSiblings.
BUG=95360
Review URL: http://codereview.chromium.org/8041051
- 4:10 PM Changeset in webkit [96027] by
-
- 2 edits2 copies in branches/chromium/835
Merge 95301 - cachedFont not getting updated for inline SVG text.
BUG=95072
Review URL: http://codereview.chromium.org/8041050
- 4:07 PM Changeset in webkit [96026] by
-
- 4 edits in trunk
switch the initial value of flex-order to 0
https://bugs.webkit.org/show_bug.cgi?id=68820
Source/WebCore:
The spec changed from having an initial value of 1 to 0.
Reviewed by Ojan Vafai.
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::initialFlexOrder):
LayoutTests:
Reviewed by Ojan Vafai.
- css3/flexbox/flex-order.html:
- 4:07 PM Changeset in webkit [96025] by
-
- 3 edits in branches/chromium/835/Source/WebCore/dom
Merge 95600 - Style changes on forwarded shadow children should trigger shadow renderer reconstruction.
BUG=93788
Review URL: http://codereview.chromium.org/8041049
- 4:04 PM Changeset in webkit [96024] by
-
- 2 edits3 copies in branches/chromium/835
Merge 94991 - <rdar://problem/10054615> Floats in ruby text intrude into the base
BUG=94810
Review URL: http://codereview.chromium.org/8044031
- 4:02 PM Changeset in webkit [96023] by
-
- 9 edits in trunk
Enable requestAnimationFrame on Windows
https://bugs.webkit.org/show_bug.cgi?id=68397
Reviewed by Simon Fraser.
Source/JavaScriptCore:
Enabled REQUEST_ANIMATION_FRAME_TIMER for Windows
- wtf/Platform.h:
WebKitLibraries:
Enable REQUEST_ANIMATION_FRAME for Windows
- win/tools/vsprops/FeatureDefines.vsprops:
LayoutTests:
Unskip requestAnimationFrame tests for Windows. request-animation-frame-during-modal.html
is still skipped because it uses showModalDialog which is not supported in DRT on Windows
- platform/win/Skipped:
- 4:02 PM Changeset in webkit [96022] by
-
- 1 edit in branches/chromium/874/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
[chromium] Work around null render surface crash in updateCompositorResources
https://bugs.webkit.org/show_bug.cgi?id=68838
Reviewed by James Robinson.
Landed directly on the Chromium 874 branch.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateCompositorResources):
- 4:00 PM Changeset in webkit [96021] by
-
- 3 edits in trunk/Tools
Fix WebKitTestRunner builds for Cairo, Windows and Qt.
- WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- WebKitTestRunner/win/TestInvocationWin.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- 3:58 PM Changeset in webkit [96020] by
-
- 2 edits in trunk/Source/WebCore
OfflineAudioDestinationNode must wait for thread completion in uninitialize()
https://bugs.webkit.org/show_bug.cgi?id=68725
Reviewed by Kenneth Russell.
No new tests. This fixes internal implementation details.
- webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::uninitialize):
- 3:57 PM Changeset in webkit [96019] by
-
- 1 edit in releases/WebKitGTK/webkit-1.6/Source/WebKit/gtk/tests/testatk.c
Revert a change added by mistake to the last merge
- 3:53 PM Changeset in webkit [96018] by
-
- 2 edits2 copies in branches/chromium/835
Merge 95924 - Source/WebCore: Issues with merging block children of a ruby
base with another ruby base having inline children.
BUG=91921
Review URL: http://codereview.chromium.org/8041046
- 3:51 PM Changeset in webkit [96017] by
-
- 3 edits2 copies in branches/chromium/835
Merge 95462 - Source/WebCore: Issues with merging ruby bases.
BUG=94809
Review URL: http://codereview.chromium.org/8028045
- 3:50 PM Changeset in webkit [96016] by
-
- 2 edits in trunk/LayoutTests
editing/selection/select-bidi-run.html timeouts on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=68831
Reviewed by Enrica Casucci.
Click at (0,0) to reset click count instead of a long leapForward.
- editing/selection/select-bidi-run.html:
- 3:49 PM Changeset in webkit [96015] by
-
- 3 edits in releases/WebKitGTK/webkit-1.6/Source
- 3:46 PM Changeset in webkit [96014] by
-
- 11 edits in trunk/Source/WebKit2
REGRESSION (r95747): Activating the web inspector causes the web process to be killed
https://bugs.webkit.org/show_bug.cgi?id=68762
Reviewed by Anders Carlsson.
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::createInspectorPage):
Tell Web process that loading resources from WebCore resources directory is OK.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::assumeReadAccessToBaseURL):
- UIProcess/WebProcessProxy.h:
Renamed willLoadHTMLStringWithBaseURL to more generic assumeReadAccessToBaseURL.
- UIProcess/WebInspectorProxy.h:
- UIProcess/efl/WebInspectorEfl.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
- UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectorBaseURL):
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
Report what base directory Inspector has access to.
- 3:45 PM Changeset in webkit [96013] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update the test expectaion file for media related tests.
It includes updating bug numbers, removing
media/video-controls-visible-audio-only.html, and unskipping
media/media-document-audio-repaint.html.
https://bugs.webkit.org/show_bug.cgi?id=68254
Reviewed by David Levin.
- platform/chromium/test_expectations.txt:
- 3:45 PM Changeset in webkit [96012] by
-
- 2 edits2 copies in branches/chromium/835
Merge 95054 - Source/WebCore: Fixes several bugs when adding CounterNodes to a tree which can cause asymetrical relationships.
BUG=92226
Review URL: http://codereview.chromium.org/8048004
- 3:44 PM Changeset in webkit [96011] by
-
- 2 edits2 copies in branches/chromium/874
Merge 95924 - Source/WebCore: Issues with merging block children of a ruby
base with another ruby base having inline children.
BUG=91921
Review URL: http://codereview.chromium.org/8044030
- 3:34 PM Changeset in webkit [96010] by
-
- 4 edits in trunk
Source/WebKit/chromium: Fix copy and paste error in r96002.
- tests/InnerGestureRecognizerTest.cpp:
(TEST_F):
LayoutTests: Remove test that no longer crashes (fixed by r95985).
- platform/chromium/test_expectations.txt:
- 3:28 PM Changeset in webkit [96009] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Do not ignore 'Replaceable' attributes in the DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=68837
Reviewed by Martin Robinson.
- bindings/scripts/CodeGeneratorGObject.pm: add getters (but not
setters) for 'Replaceable' attributes. Punt for the future
actually making them settable, since it seems non trivial.
- 3:27 PM Changeset in webkit [96008] by
-
- 2 edits in trunk/Source/WebCore
Leopard build fix.
- testing/Internals.cpp:
(WebCore::Internals::setZoomAnimatorTransform):
- 3:22 PM Changeset in webkit [96007] by
-
- 4 edits in trunk/Source/WebCore
IndexedDB: Null key path gets stored as empty string key path
https://bugs.webkit.org/show_bug.cgi?id=68726
Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-26
Reviewed by Tony Chang.
Store additional flag to indicate if object store key path
is null vs. empty. Added additional runtime tests for integrity
of object store metadata.
- storage/IDBLevelDBBackingStore.cpp:
(WebCore::checkObjectStoreAndMetaDataType):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
- storage/IDBLevelDBCoding.cpp:
- 3:21 PM Changeset in webkit [96006] by
-
- 2 edits in trunk/LayoutTests
[skia] need rebaseline after the next skia roll -- improvements to xfermodes on gpu
https://bugs.webkit.org/show_bug.cgi?id=68807
Reviewed by Stephen White.
- platform/chromium/test_expectations.txt:
- 3:19 PM Changeset in webkit [96005] by
-
- 54 edits in trunk
Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453
Tools:
Reviewed by Sam Weinig.
Convert DumpRenderTree to use use the repaint rects
exposed via WebKit API when generating the repaint test
overlay.
Fix WebKitTestRunner to work with repaint tests, again
using the repaint rects exposed from WK2.
In both cases, layoutTestController.display() now just
forces a display of the web view, and turns on repaint
rect tracking on the main FrameView.
Later, when pixel results are requested, the alpha overlay
that shows the repaint rects is generated using the list
of rects supplied by WebCore.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
(resetWebViewToConsistentStateBeforeTesting):
(displayWebView):
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
(paintRepaintRectOverlay):
(createBitmapContextFromWebView):
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::setRepaintRects):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::reset):
(WTR::InjectedBundlePage::dump):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::display):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
- WebKitTestRunner/TestInvocation.h:
- WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
LayoutTests:
Reviewed by Sam Weinig.
Update Mac results to use the new repaint rects. Differences from old results:
- There are no longer invalidates from scrolling.
- We no longer see the effects of AppKit rect coalescing.
- Composting tests show the overlay now, but repaints in compositing layers do not show.
Bad results in a couple of tests are covered by bugs 68830 and 68829.
- platform/mac/fast/repaint/4774354-expected.png:
- platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
- platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
- platform/mac/fast/repaint/border-radius-repaint-expected.png:
- platform/mac/fast/repaint/clipped-relative-expected.png:
- platform/mac/fast/repaint/containing-block-position-change-expected.png:
- platform/mac/fast/repaint/control-clip-expected.png:
- platform/mac/fast/repaint/delete-into-nested-block-expected.png:
- platform/mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png:
- platform/mac/fast/repaint/fixed-scroll-simple-expected.png:
- platform/mac/fast/repaint/flexible-box-overflow-expected.png:
- platform/mac/fast/repaint/flexible-box-overflow-horizontal-expected.png:
- platform/mac/fast/repaint/float-move-during-layout-expected.png:
- platform/mac/fast/repaint/float-overflow-expected.png:
- platform/mac/fast/repaint/float-overflow-right-expected.png:
- platform/mac/fast/repaint/iframe-scroll-repaint-expected.png:
- platform/mac/fast/repaint/inline-block-overflow-expected.png:
- platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/mac/fast/repaint/layer-child-outline-expected.png:
- platform/mac/fast/repaint/layer-outline-expected.png:
- platform/mac/fast/repaint/layer-outline-horizontal-expected.png:
- platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png:
- platform/mac/fast/repaint/line-overflow-expected.png:
- platform/mac/fast/repaint/nested-iframe-scroll-inner-expected.png:
- platform/mac/fast/repaint/nested-iframe-scroll-outer-expected.png:
- platform/mac/fast/repaint/outline-child-repaint-expected.png:
- platform/mac/fast/repaint/outline-shrinking-expected.png:
- platform/mac/fast/repaint/overflow-delete-line-expected.png:
- platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
- platform/mac/fast/repaint/repaint-during-scroll-expected.png:
- platform/mac/fast/repaint/scale-page-shrink-expected.png:
- platform/mac/fast/repaint/search-field-cancel-expected.png:
- platform/mac/fast/repaint/selection-after-remove-expected.png:
- platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png:
- platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
- platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
- platform/mac/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/mac/fast/repaint/static-to-positioned-expected.png:
- platform/mac/fast/repaint/table-cell-move-expected.png:
- platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
- platform/mac/fast/repaint/text-shadow-expected.png:
- platform/mac/fast/repaint/text-shadow-horizontal-expected.png:
- 3:19 PM Changeset in webkit [96004] by
-
- 4 edits in releases/WebKitGTK/webkit-1.6
- 3:16 PM Changeset in webkit [96003] by
-
- 4 edits in releases/WebKitGTK/webkit-1.6/Source/WebCore
- 3:12 PM Changeset in webkit [96002] by
-
- 2 edits in trunk/Source/WebKit/chromium
Disable Chromium gesture recognizer tests that started to fail on the
Mac bots recently.
- tests/InnerGestureRecognizerTest.cpp:
(TEST_F):
- 3:10 PM Changeset in webkit [96001] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Chromium] Remove DFGAliasTracker.h references from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=68787
Reviewed by Geoffrey Garen.
DFG/DFGAliasTracker.h was removed in r95389. Cleanup (remove) references
to that file from the gyp project files.
- JavaScriptCore.gypi:
- 3:07 PM Changeset in webkit [96000] by
-
- 7 edits in trunk
Fix nonpremultiplied webgl toDataURL to jpeg
https://bugs.webkit.org/show_bug.cgi?id=68366
Source/WebCore:
The canvas spec says that toDataURL to formats without an alpha must
be "composited onto a solid black background using the source-over
operator." Do that.
Patch by John Bauman <jbauman@chromium.org> on 2011-09-26
Reviewed by Kenneth Russell.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::CGImageToDataURL):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):
- platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::RGBAtoRGB):
LayoutTests:
Update the premultiplyalpha-test from the WebGL conformance tests.
Also use the correct expected result for toDataURL.jpeg.alpha.html.
Patch by John Bauman <jbauman@chromium.org> on 2011-09-26
Reviewed by Kenneth Russell.
- fast/canvas/webgl/premultiplyalpha-test-expected.txt:
- fast/canvas/webgl/premultiplyalpha-test.html:
- platform/mac/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
- 3:00 PM Changeset in webkit [95999] by
-
- 10 edits2 copies in trunk
Source/WebKit2: Added WKHitTestResult API's.
WKHitTestResult API's are added. These API's can be used to
get the hover'ed link/image/media URL as well as link lable and
title.
https://bugs.webkit.org/show_bug.cgi?id=68426
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-26
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- GNUmakefile.am:
- UIProcess/API/C/WKHitTestResult.cpp: Added.
(WKHitTestResultGetTypeID):
(WKHitTestResultCopyAbsoluteImageURL):
(WKHitTestResultCopyAbsoluteLinkURL):
(WKHitTestResultCopyAbsoluteMediaURL):
(WKHitTestResultCopyLinkLabel):
(WKHitTestResultCopyLinkTitle):
- UIProcess/API/C/WKHitTestResult.h: Added.
- UIProcess/API/C/WebKit2.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebKit2API.pri:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
Tools: Get hover'ed element URL from HitTest.
mouseDidMoveOverElement now gets the hover'ed element link using
WKHitTestResult API's.
https://bugs.webkit.org/show_bug.cgi?id=68426
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-26
Reviewed by Anders Carlsson.
- MiniBrowser/gtk/BrowserWindow.c:
(mouseDidMoveOverElement):
- 2:47 PM Changeset in webkit [95998] by
-
- 8 edits1 delete in trunk
[CMake] Remove FindFreetype.cmake
https://bugs.webkit.org/show_bug.cgi?id=68778
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-26
Reviewed by Adam Barth.
CMake has provided its own FindFreetype.cmake forever, so there is no
need to have another implementation in WebKit.
.:
- Source/cmake/FindCairo.cmake: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS}
instead of Freetype_{LIBRARIES,INCLUDE_DIRS}.
- Source/cmake/FindFreetype.cmake: Removed.
- Source/cmake/FindPango.cmake: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS}
instead of Freetype_{LIBRARIES,INCLUDE_DIRS}.
- Source/cmake/OptionsEfl.cmake: Remove minimum required version
check, it has never been checked and Freetype 2.1.10 from 2005 is
already > 9.0.
Source/WebCore:
No new tests, just a buildsystem change.
- CMakeListsEfl.txt: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS} instead of
Freetype_{LIBRARIES,INCLUDE_DIRS}.
Source/WebKit/efl:
- CMakeListsEfl.txt: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS} instead of
Freetype_{LIBRARIES,INCLUDE_DIRS}.
- 2:44 PM Changeset in webkit [95997] by
-
- 2 edits in trunk/Source/WebCore
Fix full-page rubber band overhang appearing when gesturing during a slow page load.
https://bugs.webkit.org/show_bug.cgi?id=68568
Chromium bug: http://code.google.com/p/chromium/issues/detail?id=97243
(This also happens on Safari.)
The problem was that ScrollView::overhangAmount() was returning a full-page overhang due to contentsSize() being 0 briefly during a page load, which was then getting used by ScrollAnimatorChromiumMac.mm to update the overhang on a gesture event. This change makes the relevant logic not return an overhang if the contentsSize() is empty.
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-26
Reviewed by Adam Barth.
No new tests, since this is highly timing-related.
- platform/ScrollView.cpp:
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::wheelEvent):
- 2:44 PM Changeset in webkit [95996] by
-
- 4 edits in trunk
2011-09-26 Alejandro G. Castro <alex@igalia.com>
[GTK] pot file is not properly remove during distcheck
https://bugs.webkit.org/show_bug.cgi?id=68797
Defined DOMAIN variable before DISTCLEANFILES because we are using
it there to identify the .pot file.
Reviewed by Martin Robinson.
- GNUmakefile.am:
2011-09-26 Alejandro G. Castro <alex@igalia.com>
[GTK] pot file is not properly remove during distcheck
https://bugs.webkit.org/show_bug.cgi?id=68797
DOMAIN is already defined, we just add the value to the variable.
Reviewed by Martin Robinson.
- GNUmakefile.am:
- 2:39 PM Changeset in webkit [95995] by
-
- 1 edit5 adds in trunk/Tools
Add skeleton parsing for a WatchList.
https://bugs.webkit.org/show_bug.cgi?id=68823
Reviewed by Adam Barth.
- Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
Parses the top level watch list sections -- none are defined yet -- and
throws an exception if an invalid one is listed.
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
Verify the exception for an invalid section in a watch list.
- Scripts/webkitpy/common/watchlist/watchlist.py: Added.
- 2:35 PM Changeset in webkit [95994] by
-
- 6 edits3 copies in branches/chromium/835
Merge 94905 - Source/WebCore: Crash due to bad data in SVGDocumentExtensions m_pendingResources
BUG=91092
Review URL: http://codereview.chromium.org/8038032
- 2:32 PM Changeset in webkit [95993] by
-
- 1 edit2 copies in branches/chromium/835
Merge 94864 - Source/WebCore: Assert being hit in AccessibilityRenderObject::addChildren()
BUG=84885
Review URL: http://codereview.chromium.org/8036039
- 2:24 PM Changeset in webkit [95992] by
-
- 2 edits2 copies in branches/chromium/835
Merge 94716 - Changes to aria-hidden don't change VO navigation
BUG=84160
Review URL: http://codereview.chromium.org/8037036
- 2:17 PM Changeset in webkit [95991] by
-
- 1 edit2 copies in branches/chromium/835
Merge 95071 - Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized readBUG=60653
Review URL: http://codereview.chromium.org/8041039
- 2:06 PM Changeset in webkit [95990] by
-
- 2 edits in trunk/LayoutTests
Add a failing expectation to the test added by r95964 on Chromium Linux and Chromium Windows.
The failure is tracked by the bug 68832.
- platform/chromium/test_expectations.txt:
- 1:57 PM Changeset in webkit [95989] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2]Unreviewed speculative buildfix after r95968.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
- 1:31 PM Changeset in webkit [95988] by
-
- 16 edits1 add in trunk
[chromium] Revise zoom animator backend to use full transform instead of just scale.
https://bugs.webkit.org/show_bug.cgi?id=68535
Reviewed by Kenneth Russell.
Source/WebCore:
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setZoomAnimatorScale):
(WebCore::Settings::zoomAnimatorScale):
(WebCore::Settings::setZoomAnimatorPosition):
(WebCore::Settings::zoomAnimatorPosX):
(WebCore::Settings::zoomAnimatorPosY):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayersInternal):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::setZoomAnimatorTransform):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
(WebCore::CCLayerTreeHost::updateLayers):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setZoomAnimatorTransform):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- testing/Internals.cpp:
(WebCore::Internals::setZoomAnimatorTransform):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
LayoutTests:
- platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
- platform/chromium/compositing/zoom-animator-scale-test.html:
- 1:28 PM Changeset in webkit [95987] by
-
- 4 edits in trunk/LayoutTests
Layout Test fast/animation/request-animation-frame-timestamps-advance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68821
Switch test to use finishJSTest(), which handles js-test-post.js loading
after the test is complete better.
- fast/animation/request-animation-frame-timestamps-advance.html:
- fast/animation/script-tests/request-animation-frame-timestamps-advance.js:
(window.webkitRequestAnimationFrame):
- platform/chromium/test_expectations.txt:
- 1:08 PM Changeset in webkit [95986] by
-
- 2 edits in trunk
[CMake] Detect the operating system in a more generic way.
https://bugs.webkit.org/show_bug.cgi?id=67482
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-26
Reviewed by Adam Barth.
So far the buildsystem only considered Windows, Linux and Mac OS X as
valid operating systems, but any Unix (or at least the BSDs) should also
work fine.
By using the OS values CMake itself defines we can check for Unix
systems in a more generic fashion.
- Source/CMakeLists.txt:
- 1:08 PM Changeset in webkit [95985] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r95926) Assert firing in svg/clip-path/clip-path-on-svg.svg
https://bugs.webkit.org/show_bug.cgi?id=68819
Reviewed by Dave Hyatt.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::scheduleRelayout): Revert to using view() instead of the RenderView
parameter of isRooted, since only the former returns 0 when the document is detached.
- 1:06 PM Changeset in webkit [95984] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: XMLHttpRequest console logging messages should link to network panel when possible.
https://bugs.webkit.org/show_bug.cgi?id=67399
Reviewed by Pavel Feldman.
- inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
- inspector/ConsoleMessage.h:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage.prototype._formatMessage.else.else.linkifier):
(WebInspector.ConsoleMessage.prototype._formatMessage):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showAnchorLocation):
- inspector/front-end/inspector.js:
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.linkifyStringAsFragment):
- 12:58 PM Changeset in webkit [95983] by
-
- 5 edits in trunk/Source/WebKit/efl
[EFL] Add virtual method to notify user when wrapping focus
https://bugs.webkit.org/show_bug.cgi?id=68699
Reviewed by Antonio Gomes.
Add a virtual method to ewk_view, so the Chrome gets notified if we
finished focusing all the items and would start over. This way the
browser can decide to handle the subsequent focus changes among its
widgets.
- WebCoreSupport/ChromeClientEfl.cpp: call ewk_view's virtual method to
give it a chance to grab focus
(WebCore::ChromeClientEfl::canTakeFocus):
- ewk/ewk_private.h:
- ewk/ewk_view.cpp: add virtual method
(ewk_view_focus_can_cycle):
- ewk/ewk_view.h: add focus direction enum and virtual method
- 12:58 PM Changeset in webkit [95982] by
-
- 6 edits in trunk/Source/WebKit2
Remove an old DrawingAreaProxy::paint member function
https://bugs.webkit.org/show_bug.cgi?id=68825
Reviewed by Dan Bernstein.
- UIProcess/DrawingAreaProxy.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/TiledDrawingAreaProxy.cpp:
- UIProcess/TiledDrawingAreaProxy.h:
- 12:57 PM Changeset in webkit [95981] by
-
- 2 edits1 copy in trunk/LayoutTests
Rebaseline fast/dom/Window/window-resize-contents.html for non-Chromium ports.
Previous expected result was Chromium-specific because console line
numbers were different in JSC.
Additionally, the test doesn't behave as expected for non-Chromium
ports (window size remains at 800x600). Update the baselines to use
that for now, so that we're still aware of regressions/progressions.
- fast/dom/Window/window-resize-contents-expected.txt:
- platform/chromium/fast/dom/Window/window-resize-contents-expected.txt: Copied from LayoutTests/fast/dom/Window/window-resize-contents-expected.txt.
- 12:54 PM Changeset in webkit [95980] by
-
- 1 edit2 copies in branches/chromium/835
Merge 95074 - Crash in RenderScrollbarPart::imageChanged.
BUG=96444
Review URL: http://codereview.chromium.org/8028035
- 12:52 PM Changeset in webkit [95979] by
-
- 2 edits in branches/chromium/835
Merge 95306
BUG=96665
Review URL: http://codereview.chromium.org/8038026
- 12:51 PM Changeset in webkit [95978] by
-
- 4 edits in trunk/Source
White flash when entering full-screen using element.webkitRequestFullScreen()
https://bugs.webkit.org/show_bug.cgi?id=68481
Reviewed by Simon Fraser.
Source/WebCore:
No new tests; covered by existing full screen tests.
During an animation, renderers may try to paint into the FullScreenRenderer's
GraphicsLayer, and an optimization we previously added for the FullScreenRenderer's
background will cause these paints to fail. Remove this optimization in
containsPaintedContent, and taking non-composited elements into full screen will
animate correctly.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::containsPaintedContent):
Source/WebKit2:
Do not re-enable screen updates after exiting compositing mode until a repaint has completed.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController exitAcceleratedCompositingMode]):
(continueExitCompositingModeAfterRepaintCallback):
(-[WKFullScreenWindowController _continueExitCompositingModeAfterRepaint]):
- 12:49 PM Changeset in webkit [95977] by
-
- 2 edits3 copies in branches/chromium/835
Merge 95580 - Invoke CachedResourceLoader::canRequest for all URLs in a redirect chain
BUG=97278
Review URL: http://codereview.chromium.org/8037034
- 12:48 PM Changeset in webkit [95976] by
-
- 1 edit2 copies in branches/chromium/835
Merge 95667 - [Chromium] Protect the Frame in V8HTMLDocument::openCallback
BUG=97451
Review URL: http://codereview.chromium.org/8028034
- 12:46 PM Changeset in webkit [95975] by
-
- 1 edit2 copies in branches/chromium/835
Merge 95689 - [Chromium] Protect message ports from being deleted in V8MessageEvent::portsAccessorGetter
BUG=97520
Review URL: http://codereview.chromium.org/8041034
- 12:43 PM Changeset in webkit [95974] by
-
- 3 edits12 deletes in trunk
Unreviewed, rolling out r95960.
http://trac.webkit.org/changeset/95960
https://bugs.webkit.org/show_bug.cgi?id=58608
Significantly changes table border rendering
Source/WebCore:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
LayoutTests:
- fast/borders/border-groove-expected.png: Removed.
- fast/borders/border-groove-expected.txt: Removed.
- fast/borders/border-groove.html: Removed.
- fast/borders/border-inset-expected.png: Removed.
- fast/borders/border-inset-expected.txt: Removed.
- fast/borders/border-inset.html: Removed.
- fast/borders/border-outset-expected.png: Removed.
- fast/borders/border-outset-expected.txt: Removed.
- fast/borders/border-outset.html: Removed.
- fast/borders/border-ridge-expected.png: Removed.
- fast/borders/border-ridge-expected.txt: Removed.
- fast/borders/border-ridge.html: Removed.
- 12:43 PM Changeset in webkit [95973] by
-
- 2 edits3 copies in branches/chromium/835
Merge 95857 - Source/WebCore: Style not updated for :before, :after content
in ruby text.
BUG=97546
Review URL: http://codereview.chromium.org/8043034
- 12:41 PM Changeset in webkit [95972] by
-
- 4 edits2 copies in branches/chromium/835
Merge 95728 - Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
BUG=97615
Review URL: http://codereview.chromium.org/8043033
- 12:38 PM Changeset in webkit [95971] by
-
- 1 edit2 copies in branches/chromium/874
Merge 95959 - Delete retired custom font data only on document
destruction, and not on recalc style.
BUG=97994
Review URL: http://codereview.chromium.org/8044027
- 12:37 PM Changeset in webkit [95970] by
-
- 1 edit2 copies in branches/chromium/835
Merge 95959 - Delete retired custom font data only on document
destruction, and not on recalc style.
BUG=97994
Review URL: http://codereview.chromium.org/8036034
- 12:09 PM Changeset in webkit [95969] by
-
- 2 edits in trunk/LayoutTests
Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 12:01 PM Changeset in webkit [95968] by
-
- 10 edits in trunk/Source/WebKit2
Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453
Reviewed by Sam Weinig.
Expose WKBundlePage methods to turn on repaint rect tracking
in WebKit2, for WebKitTestRunner.
As part of the change, expose utility methods on WebPage
to get the main Frame and FrameView, which required renaming
the exisiting method that returns a WebFrame. Fix callers
of that method to handle null when necessary.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetMainFrame):
(WKBundlePageSetTracksRepaints):
(WKBundlePageIsTrackingRepaints):
(WKBundlePageResetTrackedRepaints):
(WKBundlePageCopyTrackedRepaintRects):
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::findLargestFrameInFrameSet):
(WebKit::WebChromeClient::closeWindowSoon):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
(WebKit::WebFrameLoaderClient::frameLoadCompleted):
(WebKit::WebFrameLoaderClient::restoreViewState):
(WebKit::WebFrameLoaderClient::provisionalLoadStarted):
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebKit::WebFrameLoaderClient::createPlugin):
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::documentFragmentFromAttributedString):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::isMainFrame):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setTracksRepaints):
(WebKit::WebPage::isTrackingRepaints):
(WebKit::WebPage::resetTrackedRepaints):
(WebKit::WebPage::trackedRepaintRects):
(WebKit::WebPage::clearMainFrameName):
(WebKit::WebPage::layoutIfNeeded):
(WebKit::WebPage::mainFrameHasCustomRepresentation):
(WebKit::WebPage::mainFrame):
(WebKit::WebPage::mainFrameView):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::mainWebFrame):
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject accessibilityHitTest:]):
- 11:57 AM Changeset in webkit [95967] by
-
- 7 edits in trunk/Source
Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453
Reviewed by Sam Weinig.
Source/WebCore:
Have FrameView keep track of repaint rects when asked to, and
expose this set of repaint rects via private WebKit API for later
use by DumpRenderTree.
The repaint rects are in WebView coordinates, so we have to
unapply the scroll offset.
- WebCore.exp.in:
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::setTracksRepaints):
- page/FrameView.h:
(WebCore::FrameView::isTrackingRepaints):
(WebCore::FrameView::resetTrackedRepaints):
(WebCore::FrameView::trackedRepaintRects):
Source/WebKit/mac:
Have FrameView keep track of repaint rects when asked to, and
expose this set of repaint rects via private WebKit API for later
use by DumpRenderTree.
- WebView/WebView.mm:
(-[WebView setTracksRepaints:]):
(-[WebView isTrackingRepaints]):
(-[WebView resetTrackedRepaints]):
(-[WebView trackedRepaintRects]):
- WebView/WebViewPrivate.h:
- 11:53 AM Changeset in webkit [95966] by
-
- 4 edits in trunk/Source/WebCore
Optimize matching of common pseudo classes
https://bugs.webkit.org/show_bug.cgi?id=68633
Reviewed by Dave Hyatt, Darin Adler, Dimitri Glazkov.
:link, :visited and :focus are quite common. They often used as univeral selectors (including in our
default stylesheet) so we try to match them for all elements in the document. They take always the
slow matching path. In addition we match link styles twice due to visited link pseudo style generation
so the overhead is doubled. As a result substantial portion of our style matching time is spent
dealing with these pseudo classes.
This patch adds new lists to RuleSet for common pseudo class rules. The rules on the lists are only checked
if the element has approprate type and stat. ases where the rightmost pseudo class can then be rejected immediately.
We can also enable the fast path checking for the rest of the selector in many cases.
This seems to be >30% progression in selector matching performance with typical style sheets. It saves ~0.9s
when loading the full HTML5 spec.
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::hasRightmostSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleSet::idRules):
(WebCore::RuleSet::classRules):
(WebCore::RuleSet::tagRules):
(WebCore::RuleSet::shadowPseudoElementRules):
(WebCore::RuleSet::linkPseudoClassRules):
(WebCore::RuleSet::visitedPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):
(WebCore::RuleSet::pageRules):
Add a new lists, some stylistic renamings.
(WebCore::CSSStyleSelector::matchRules):
New link and focus checks.
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::checkSelector):
Inline the rightmost selector tag checking, skip if unnecessary.
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
Common pseudo classes now match based on early filtering (though it is not a hash in this case).
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addRule):
Sort pseudo classes to new lists.
(WebCore::RuleSet::collectFeatures):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::matchPageRules):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
Adopt to expanded fast path (this is used by querySelectorAll).
(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheckSelector):
Rightmost selector is now checked differently than the rest. RuleSet based selection in CSSStyleSelector
is equivalent to fastCheckRightmostSelector().
(WebCore::isFastCheckableRelation):
(WebCore::isFastCheckableMatch):
(WebCore::isFastCheckableRightmostSelector):
(WebCore::SelectorChecker::isFastCheckableSelector):
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::commonPseudoClassSelectorMatches):
(WebCore::SelectorChecker::isFrameFocused):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::isCommonPseudoClassSelector):
(WebCore::SelectorChecker::linkMatchesVisitedPseudoClass):
(WebCore::SelectorChecker::matchesFocusPseudoClass):
(WebCore::SelectorChecker::tagMatches):
Refactor a bunch of shared checks into functions.
- 11:52 AM Changeset in webkit [95965] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt]REGRESSION(r95865): It made 4 tests crash
https://bugs.webkit.org/show_bug.cgi?id=68780
Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-09-26
Reviewed by Oliver Hunt.
emitJumpSlowCaseIfNotJSCell(...) cannot be moved
away since the next load depends on it.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_val):
- 11:30 AM Changeset in webkit [95964] by
-
- 8 edits2 adds in trunk
REGRESSION(r74971): Selection doesn't work correctly in BiDi Text
https://bugs.webkit.org/show_bug.cgi?id=57340
Reviewed by Eric Seidel.
Source/WebCore:
This patch adds the end point adjustment mechanism at bidi boundaries similar to the one NSTextView implements.
To understand the problem, suppose we have strong RTL letters "ABC" in a LTR block (visually laid out as CBA).
Per NSTextView convention, logical offsets between each letter is placed as (0)C(2)B(1)A(3). In other words,
placing the caret visually on the left of CBA yields the position inside the text node of "ABC" at offset 0.
Likewise, placing it between C and B yields ("ABC", 2), and placing it on the right of CBA yields ("ABC", 3).
Now suppose a user attempts to select the letter A by a mouse drag from the right of CBA to a point between
B and A. First, the initial mouse down places the selection's base at ("ABC", 3). Then as the mouse pointer
moves to a point on the left of A, the selection's extent is set at ("ABC", 1), selecting "BC".
To mitigate this issue, NSTextView adjusts selection base and extent under certain conditions. In the above
example, NSTextView detects user's intent and changes the selection's base to ("ABC", 0) temporarily.
This patch implements a similar trick on WebKit. We adjust the base or the extent when they're at the left
end or at the right end of a bidi run and the other end is inside of the run. In the above example, the
base position on the right of A is the right end of a bidi run and the extent position between B and A is
inside the same run (CBA), so we would adjust the base to be ("ABC", 0) as NSTextView does.
Take another example abcABC. Note offsets are assigned as (0)a(1)b(2)c(3)C(5)B(4)A(6) When the user starts
a mouse drag from the right of A to a point between B and A, we adjust the selection base to be ("abcABC", 3)
because the base is at the right end of a bidi run and the extent is in the same run. We keep the adjustment
when the mouse pointer moves to a point between C and B. However, when the mouser pointer reaches a point
between letters b and c, the selection extent is placed at ("abcABC", 2). Because the extent is outside of
the bidi run started from the selection base, we restore the original base at this point. Had we not done this,
we'll end up selecting just "c".
While this algorithm is implemented in FrameSelection::setNonDirectionalSelectionIfNeeded, this patch adds
various member functions to RenderedPosition to facilitate abstraction around inline boxes and bidi runs.
Test: editing/selection/select-bidi-run.html
- editing/FrameSelection.cpp:
(WebCore::adjustEndpointsAtBidiBoundary): Added. Implements the endpoints adjustment algorithm.
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded): Calls adjustEndpointsAtBidiBoundary, and
restores the original base as needed.
- editing/FrameSelection.h:
- editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::RenderedPosition):
(WebCore::RenderedPosition::prevLeafChild): Added to cache prevLeafChild of the current inline box.
(WebCore::RenderedPosition::nextLeafChild): Ditto for nextLeafChild.
(WebCore::RenderedPosition::isEquivalent): Compares two RenderedPositions considering neighboring inline boxes
so that the rightmost position in a box and the leftmost position in the following box is considered equal.
(WebCore::RenderedPosition::bidiLevelOnLeft): Added. Returns the bidi level of the run on the left. We can't
add a generic bidiLevel to this class because it'll be ambiguous at bidi boundaries.
(WebCore::RenderedPosition::bidiLevelOnRight): Ditto for the run on the right.
(WebCore::RenderedPosition::leftBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::rightBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atLeftBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atRightBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::positionAtLeftBoundaryOfBiDiRun): Returns Position at the left edge of a bidi run
if RenderedPosition is at such a position. Asserts atLeftBoundaryOfBidiRun.
(WebCore::RenderedPosition::positionAtRightBoundaryOfBiDiRun): Ditto for the right edge.
- editing/RenderedPosition.h:
(WebCore::RenderedPosition::atLeftBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atRightBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atLeftmostOffsetInBox): Added.
(WebCore::RenderedPosition::atRightmostOffsetInBox): Added.
(WebCore::RenderedPosition::uncachedInlineBox): Added. We can't use a static const variable because gcc thinks
reinterpret_cast<InlineBox*>(1) is not an integral value.
(WebCore::RenderedPosition::RenderedPosition):
- editing/VisibleSelection.h:
(WebCore::VisibleSelection::visibleBase): Added.
(WebCore::VisibleSelection::visibleExtent): Added.
- page/EventHandler.cpp:
(WebCore::EventHandler::updateSelectionForMouseDrag):
LayoutTests:
- editing/selection/select-bidi-run-expected.txt: Added.
- editing/selection/select-bidi-run.html: Added.
- 11:00 AM Changeset in webkit [95963] by
-
- 5 edits4 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/fast/dom/Window/window-resize-contents-expected.png: Added after r95897.
- platform/qt/fast/dom/Window/window-resize-contents-expected.txt: Added after r95897.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png: Updated after r95897.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated after r95897.
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Updated after r95897.
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated after r95897.
- platform/qt/fast/ruby/ruby-text-before-after-content-expected.png: Added after r95857.
- platform/qt/fast/ruby/ruby-text-before-after-content-expected.txt: Added after r95857.
- 10:52 AM Changeset in webkit [95962] by
-
- 4 edits in trunk/Source
Unreviewed, rolling out r95256.
http://trac.webkit.org/changeset/95256
https://bugs.webkit.org/show_bug.cgi?id=68814
Temporary CRASH calls no longer needed (Requested by enne on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-26
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::commitTo):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
- 10:45 AM WebKitGTK/Releasing edited by
- (diff)
- 10:36 AM Changeset in webkit [95961] by
-
- 2 edits in trunk/Source/WebCore
<http://webkit.org/b/68809> IconDatabase::syncThreadMainLoop can assert if wakeSyncThread is called before thread starts executing
If wakeSyncThread is called before syncThreadMainLoop starts executing then m_syncThreadHasWorkToDo would be set
while executing the body of the sync thread loop, causing us to skip blocking on the condition variable. This would
lead to us hitting the assertion failure due to m_disabledSuddenTerminationForSyncThread being false, unless the main
thread happened to call wakeSyncThread a second time while the first loop iteration was executing.
Reviewed by Anders Carlsson.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::syncThreadMainLoop): Clear m_syncThreadHasWorkToDo to indicate that we're about to perform
all pending work.
- 10:34 AM Changeset in webkit [95960] by
-
- 3 edits12 adds in trunk
Groove/inset/outset borders show solid if the color is black.
https://bugs.webkit.org/show_bug.cgi?id=58608
Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-09-26
Reviewed by Simon Fraser.
Source/WebCore:
Lightened the border side colors when drawing borders with styles as
Outset/Inset/Groove/Ridge.
Tests: fast/borders/border-groove.html
fast/borders/border-inset.html
fast/borders/border-outset.html
fast/borders/border-ridge.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
LayoutTests:
- fast/borders/border-groove-expected.png: Added.
- fast/borders/border-groove-expected.txt: Added.
- fast/borders/border-groove.html: Added.
- fast/borders/border-inset-expected.png: Added.
- fast/borders/border-inset-expected.txt: Added.
- fast/borders/border-inset.html: Added.
- fast/borders/border-outset-expected.png: Added.
- fast/borders/border-outset-expected.txt: Added.
- fast/borders/border-outset.html: Added.
- fast/borders/border-ridge-expected.png: Added.
- fast/borders/border-ridge-expected.txt: Added.
- fast/borders/border-ridge.html: Added.
- 10:26 AM April 2011 Meeting/Getting compile time under control edited by
- (diff)
- 10:13 AM Changeset in webkit [95959] by
-
- 3 edits2 adds in trunk
Delete retired custom font data only on document
destruction, and not on recalc style.
https://bugs.webkit.org/show_bug.cgi?id=68805
Reviewed by Dave Hyatt.
Source/WebCore:
Test: fast/text/custom-font-data-crash.html
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
LayoutTests:
- fast/text/custom-font-data-crash-expected.txt: Added.
- fast/text/custom-font-data-crash.html: Added.
- 10:00 AM Changeset in webkit [95958] by
-
- 3 edits in trunk
chrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL (64db547804532a84be2e53721e499e9e)
https://bugs.webkit.org/show_bug.cgi?id=51639
Patch by Jay Soffian <jaysoffian@gmail.com> on 2011-09-26
Reviewed by Ryosuke Niwa.
Add missing window.layoutTestController.dumpAsText so that test output matches expectation.
- LayoutTests/editing/style/justify-without-enclosing-block.xhtml:
- 9:44 AM Changeset in webkit [95957] by
-
- 4 edits3 adds in trunk
[chromium] Update VideoLayerChromium textures after texture resources are reclaimed
https://bugs.webkit.org/show_bug.cgi?id=68742
Reviewed by James Robinson.
Source/WebCore:
If video textures are reclaimed (such as during a visibility change on
a tab), the dirty rect for the layer is empty and it skips out of
updating compositor resources, leaving the video textures invalid.
Instead, check the textures here to make sure they're still valid
first before early out so that they can get reupdated if necessary.
Additionally, fix a small bug in pushPropertiesTo where 1 plane RGB
videos would not get drawn because all 3 planes didn't have valid
textures.
Test: compositing/video-page-visibility.html
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
(WebCore::VideoLayerChromium::setLayerTreeHost):
(WebCore::VideoLayerChromium::texturesValid):
- platform/graphics/chromium/VideoLayerChromium.h:
LayoutTests:
Without this patch, this video texture is invalid.
- compositing/video-page-visibility-expected.png: Added.
- compositing/video-page-visibility-expected.txt: Added.
- compositing/video-page-visibility.html: Added.
- 9:31 AM Changeset in webkit [95956] by
-
- 1 edit1 add2 deletes in trunk/LayoutTests
Web Inspector: generic performance UI test for panel switch.
https://bugs.webkit.org/show_bug.cgi?id=68806
Reviewed by Pavel Feldman.
- inspector/performance/resources/show-panel-elements.html: Removed.
- inspector/performance/resources/show-panel-network.html: Removed.
- inspector/performance/resources/show-panel.html: Added.
- 8:55 AM Changeset in webkit [95955] by
-
- 4 edits in trunk/Tools
Clean up code imported from WebKitAPITest
Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
TestWebKitAPI conventions
Reviewed by David Levin.
- TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
namespace name.
(TestWebKitAPI::WebViewDestruction::SetUp):
(TestWebKitAPI::WebViewDestruction::webViewCount):
(TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
(TestWebKitAPI::WebViewDestruction::runMessagePump):
(TestWebKitAPI::WebViewDestruction::TearDown):
(TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
Moved functionality from free functions into these new test fixtures.
- TestWebKitAPI/win/HostWindow.cpp:
- TestWebKitAPI/win/HostWindow.h:
Prefixed Win32 API calls with ::. Updated namespace name.
- 8:51 AM Changeset in webkit [95954] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-26
- DEPS:
- 8:35 AM WebKitGTKStableReleases edited by
- (diff)
- 8:34 AM WebKitGTKStableReleases created by
- 8:29 AM Changeset in webkit [95953] by
-
- 2 edits1 copy1 add in trunk/Source/WebCore
Web Inspector: introduce protocol backwards compatibility validator.
https://bugs.webkit.org/show_bug.cgi?id=68800
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- inspector/Inspector.draft-01.json: Copied from Source/WebCore/inspector/Inspector.json.
- inspector/validate-protocol-compatibility: Added.
- 8:28 AM WebKitGTK edited by
- (diff)
- 8:27 AM WebKitGTK edited by
- (diff)
- 8:26 AM WebKitGTK edited by
- (diff)
- 8:03 AM Changeset in webkit [95952] by
-
- 2 edits in releases/WebKitGTK/webkit-1.6/Source/WebKit/gtk
- 8:01 AM Changeset in webkit [95951] by
-
- 2 edits in releases/WebKitGTK/webkit-1.6/Source/WebKit/gtk
- 7:45 AM Changeset in webkit [95950] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=68796
Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-26
- platform/qt/Skipped:
- 7:39 AM Changeset in webkit [95949] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=51639
Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-26
- platform/qt/Skipped:
- 7:37 AM QtWebKitReleases edited by
- (diff)
- 7:29 AM QtWebKitReleases edited by
- (diff)
- 7:25 AM QtWebKitReleases edited by
- (diff)
- 7:24 AM QtWebKitReleases edited by
- (diff)
- 7:22 AM QtWebKitReleases edited by
- (diff)
- 7:19 AM QtWebKitReleases edited by
- (diff)
- 7:04 AM QtWebKitReleases edited by
- (diff)
- 6:35 AM Changeset in webkit [95948] by
-
- 2 edits in trunk/Source/WebKit/gtk
Fix documentation generation by specifying the sources
directory with $(top_srcdir).
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-26
Reviewed by Xan Lopez.
- docs/GNUmakefile.am:
- 6:03 AM Changeset in webkit [95947] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Unused variable in QNetworkReplyHandler::sendNetworkRequest.
https://bugs.webkit.org/show_bug.cgi?id=68798
Patch by Andreas Kling <kling@webkit.org> on 2011-09-26
Reviewed by Noam Rosenthal.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
- 5:52 AM Changeset in webkit [95946] by
-
- 2 edits in trunk/Source/WebCore
Second unreviewed build fix for r95941
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willCallFunctionImpl):
- 5:48 AM Changeset in webkit [95945] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for webkit builds after r95941.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willCallFunctionImpl):
- 5:16 AM Changeset in webkit [95944] by
-
- 5 edits3 copies2 adds1 delete in trunk
Merge WebKitAPITest into TestWebKitAPI
This also means that our formerly-WebKitAPITest tests will be run on the bots!
I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
them more idiomatic in a separate pass.
Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
functionality (and names!)
Reviewed by Anders Carlsson.
Tools:
- TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
- TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
- TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
- TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
- TestWebKitAPI/win/main.cpp:
(main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
- WebKitAPITest: Removed this directory and its contents.
Source/WebKit/win:
Remove WebKitAPITest
- WebKit.vcproj/WebKit.sln: Removed WebKitAPITest.vcproj. Changed WebKitLauncherWin, which
formerly depended on WebKitAPITest, to now depend on DumpRenderTree, which WebKitAPITest
depended on.
- 5:15 AM Changeset in webkit [95943] by
-
- 2 edits in trunk/Tools
Remove two failing WebKitAPITest tests
The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
Reviewed by Anders Carlsson.
- WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
MainFrameAfterClose tests.
- 5:15 AM Changeset in webkit [95942] by
-
- 18 edits1 add in trunk
2011-09-26 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] allow resources to hook on click on resource links
https://bugs.webkit.org/show_bug.cgi?id=68528
Reviewed by Yury Semikhatsky.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ExtensionAPI.js: (injectedExtensionAPI.Console.prototype.get Severity): (injectedExtensionAPI.Panels.prototype.create): (injectedExtensionAPI.Panels.prototype.setOpenResourceHandler.else.callbackWrapper): (injectedExtensionAPI.Panels.prototype.setOpenResourceHandler): (injectedExtensionAPI.ExtensionServerClient.prototype.hasHandler): (injectedExtensionAPI.ExtensionServerClient.prototype.deregisterHandler):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onSetOpenResourceHandler): (WebInspector.ExtensionServer.prototype._handleAnchorClicked): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._addExtension): (WebInspector.ExtensionServer.prototype._registerExtension):
- inspector/front-end/SettingsScreen.js: (WebInspector.SettingsScreen): (WebInspector.SettingsScreen.prototype._createCustomSetting):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/helpScreen.css: (.help-content select): (.help-content select:disabled): (.help-content option):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.set attached): (WebInspector._showAnchorLocation):
2011-09-26 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] allow resources to hook on click on resource links
https://bugs.webkit.org/show_bug.cgi?id=68528
Reviewed by Yury Semikhatsky.
- http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.runExtensionTests): (initialize_ExtensionsTest):
- inspector/extensions/extensions-api-expected.txt:
- inspector/extensions/extensions-resources-expected.txt:
- inspector/extensions/extensions-resources.html:
- 5:12 AM Changeset in webkit [95941] by
-
- 5 edits3 adds in trunk
Web Inspector: Timeline: record root event for the function calls enforced by console eval.
https://bugs.webkit.org/show_bug.cgi?id=68695
In a complex web application developer might want to timeline a specific piece of code.
In this case he can do the next steps:
1) start timeline;
2) eval a command in console;
3) stop timeline.
I think it'd be nice to have a root event for the all the events that happened as the result of such eval.
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/timeline/timeline-injected-script-eval.html
- bindings/v8/ScriptFunctionCall.cpp:
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::makeCall):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willCallFunctionImpl):
LayoutTests:
- inspector/timeline/timeline-injected-script-eval-expected.txt: Added.
- inspector/timeline/timeline-injected-script-eval.html: Added.
- platform/chromium/inspector/timeline/timeline-injected-script-eval-expected.txt: Added.
- platform/chromium/inspector/timeline/timeline-receive-response-event-expected.txt:
- 5:06 AM Changeset in webkit [95940] by
-
- 2 edits in trunk/Source/WebKit/gtk
REGRESSION: Empathy crashes when switching theme
https://bugs.webkit.org/show_bug.cgi?id=68600
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-26
Reviewed by Martin Robinson.
- webkit/webkitwebview.cpp:
(webkit_web_view_set_scroll_adjustments): use the existing
set{Horizontal,Vertical}Adjustment functions, so the code is not
duplicated
(webkit_web_view_dispose): unset the adjustments during dispose,
to avoid late adjustment change notifications hitting the
adjustment watcher
- 4:09 AM WebKitGTK/Releasing edited by
- (diff)
- 3:51 AM Changeset in webkit [95939] by
-
- 4 edits in trunk/Source/WebCore
[Texmap][Qt] Enable TextureMapperGL in platforms where BGRA is not present
https://bugs.webkit.org/show_bug.cgi?id=65473
Reviewed by Andreas Kling.
For now, swap RGBA->BGRA in software if we're in OpenGL ES 2.
We do that by iterating on the pixels and manually swapping each pixel's red and blue
values. This can be done faster with shaders, but for now this is a working solution
for platforms without BGRA support.
No new tests. Existing layout tests cover this.
- platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::endPaint):
- platform/graphics/opengl/TextureMapperGL.h:
- platform/graphics/qt/TextureMapperQt.cpp:
(WebCore::RGBA32PremultimpliedBufferQt::swapRGB):
- 2:29 AM WebKitGTK/Releasing edited by
- Add link to gtk-release-notes script (diff)
- 2:05 AM Changeset in webkit [95938] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Fix coding style bits in ResourceHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=68634
Patch by Sergio Villar Senin <svillar@igalia.com> on 2011-09-26
Reviewed by Martin Robinson.
No new tests needed.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):
- 1:48 AM WebKitGTK edited by
- Add link to releasing page (diff)
- 1:43 AM WebKitGTK/Releasing edited by
- (diff)
- 1:37 AM WebKitGTK/Releasing edited by
- (diff)
- 1:36 AM WebKitGTK/Releasing created by
- Documentation about how to release WebKitGtk+
- 12:21 AM Changeset in webkit [95937] by
-
- 4 edits1 copy2 adds in trunk
[mac] Timestamp parameter to requestAnimationFrame is busted in USE(REQUEST_ANIMATION_FRAME_TIMER) path
https://bugs.webkit.org/show_bug.cgi?id=68769
Patch by James Robinson <jamesr@chromium.org> on 2011-09-26
Reviewed by Simon Fraser.
Source/WebCore:
Convert the time parameter from double to DOMTimeStamp using convertSecondsToDOMTimeStamp rather than relying on
implicit double->long conversion, which ignores the units of the value.
Test: fast/animation/request-animation-frame-timestamps-advance.html
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::animationTimerFired):
LayoutTests:
Adds a test that the timestamp parameter to the requestAnimationFrame callback advances between calls.
- fast/animation/request-animation-frame-timestamps-advance-expected.txt: Added.
- fast/animation/request-animation-frame-timestamps-advance.html: Added.
- fast/animation/script-tests/request-animation-frame-timestamps-advance.js: Copied from LayoutTests/fast/animation/script-tests/request-animation-frame-timestamps.js.
(busyWait):
(window.webkitRequestAnimationFrame):
- fast/animation/script-tests/request-animation-frame-timestamps.js:
Remove the element parameter, they aren't a useful part of the test.
- 12:05 AM Changeset in webkit [95936] by
-
- 84 edits in trunk/Source
Add custom vtable struct to ClassInfo struct
https://bugs.webkit.org/show_bug.cgi?id=68567
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Declared/defined the MethodTable struct and added it to the ClassInfo struct.
Also defined the CREATE_METHOD_TABLE macro to generate these method tables
succinctly where they need to be defined.
Also added to it the first function to use this macro, visitChildren.
This is part of the process of getting rid of all C++ virtual methods in JSCell.
Eventually all virtual functions in JSCell that can't easily be converted to
non-virtual functions will be put into this custom vtable structure.
- runtime/ClassInfo.h:
Added the CREATE_METHOD_TABLE macro call as the last argument to each of the
ClassInfo structs declared in these classes. This saves us from having to visit
each s_info definition in the future when we add more methods to the MethodTable.
- API/JSCallbackConstructor.cpp:
- API/JSCallbackFunction.cpp:
- API/JSCallbackObject.cpp:
- JavaScriptCore.exp:
- runtime/Arguments.cpp:
- runtime/ArrayConstructor.cpp:
- runtime/ArrayPrototype.cpp:
- runtime/BooleanObject.cpp:
- runtime/BooleanPrototype.cpp:
- runtime/DateConstructor.cpp:
- runtime/DateInstance.cpp:
- runtime/DatePrototype.cpp:
- runtime/ErrorInstance.cpp:
- runtime/ErrorPrototype.cpp:
- runtime/ExceptionHelpers.cpp:
- runtime/Executable.cpp:
- runtime/GetterSetter.cpp:
- runtime/InternalFunction.cpp:
- runtime/JSAPIValueWrapper.cpp:
- runtime/JSActivation.cpp:
- runtime/JSArray.cpp:
- runtime/JSByteArray.cpp:
- runtime/JSFunction.cpp:
- runtime/JSGlobalObject.cpp:
- runtime/JSONObject.cpp:
- runtime/JSObject.cpp:
- runtime/JSPropertyNameIterator.cpp:
- runtime/JSString.cpp:
- runtime/MathObject.cpp:
- runtime/NativeErrorConstructor.cpp:
- runtime/NumberConstructor.cpp:
- runtime/NumberObject.cpp:
- runtime/NumberPrototype.cpp:
- runtime/ObjectConstructor.cpp:
- runtime/ObjectPrototype.cpp:
- runtime/RegExp.cpp:
- runtime/RegExpConstructor.cpp:
- runtime/RegExpObject.cpp:
- runtime/RegExpPrototype.cpp:
- runtime/ScopeChain.cpp:
- runtime/StringConstructor.cpp:
- runtime/StringObject.cpp:
- runtime/StringPrototype.cpp:
- runtime/Structure.cpp:
- runtime/StructureChain.cpp:
Had to make visitChildren and visitChildrenVirtual protected instead of private
because some of the subclasses of JSWrapperObject need access to JSWrapperObject's
visitChildren function pointer in their vtable since they don't provide their own
implementation. Same for RegExpObject.
- runtime/JSWrapperObject.h:
- runtime/RegExpObject.h:
Source/JavaScriptGlue:
Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
specified class in its ClassInfo. Also added to it the first function to use
this macro, visitChildren. This is part of the process of getting rid of all
C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
that can't easily be converted to non-virtual functions will be put into
this custom vtable structure.
- UserObjectImp.cpp:
Source/WebCore:
No new tests.
Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
specified class in its ClassInfo. Also added to it the first function to use
this macro, visitChildren. This is part of the process of getting rid of all
C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
that can't easily be converted to non-virtual functions will be put into
this custom vtable structure.
- bindings/js/JSAudioConstructor.cpp:
- bindings/js/JSDOMGlobalObject.cpp:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSImageConstructor.cpp:
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
- bindings/js/JSOptionConstructor.cpp:
- bindings/js/JSWorkerContextBase.cpp:
Changed the bindings generator to add the call to the CREATE_METHOD_TABLE macro where
necessary.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateConstructorDefinition):
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bridge/c/CRuntimeObject.cpp:
- bridge/c/c_instance.cpp:
- bridge/jni/jsc/JavaInstanceJSC.cpp:
- bridge/jni/jsc/JavaRuntimeObject.cpp:
- bridge/objc/ObjCRuntimeObject.mm:
- bridge/objc/objc_instance.mm:
- bridge/objc/objc_runtime.mm:
- bridge/qt/qt_instance.cpp:
- bridge/qt/qt_pixmapruntime.cpp:
- bridge/qt/qt_runtime.cpp:
- bridge/runtime_array.cpp:
- bridge/runtime_method.cpp:
- bridge/runtime_object.cpp:
Source/WebKit/mac:
Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
specified class in its ClassInfo. Also added to it the first function to use
this macro, visitChildren. This is part of the process of getting rid of all
C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
that can't easily be converted to non-virtual functions will be put into
this custom vtable structure.
- Plugins/Hosted/ProxyInstance.mm:
- Plugins/Hosted/ProxyRuntimeObject.mm:
Source/WebKit2:
Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
specified class in its ClassInfo. Also added to it the first function to use
this macro, visitChildren. This is part of the process of getting rid of all
C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
that can't easily be converted to non-virtual functions will be put into
this custom vtable structure.
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
Sep 25, 2011:
- 11:53 PM Changeset in webkit [95935] by
-
- 5 edits1 move in trunk/Source/WebCore
[EFL] Move GtkWidgetBackingStoreCairo to the cairo directory and modify to use in the EFL.
https://bugs.webkit.org/show_bug.cgi?id=63502
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2011-09-25
Reviewed by Martin Robinson.
The gtk/GtkWidgetBackingStoreCairo.cpp is moved to the cairo/WidgetBackingStoreCairo.cpp and
some codes for EFL are added.
WidgetBackingStoreCairo creates cairo_image_surface and has a role to copy reusable area
when scrolling. So, it will be used in the WebKit2 EFL port's BackingStore.
- CMakeListsEfl.txt:
- GNUmakefile.list.am:
- platform/cairo/WidgetBackingStore.h:
- platform/cairo/WidgetBackingStoreCairo.cpp: Renamed from Source/WebCore/platform/gtk/GtkWidgetBackingStoreCairo.cpp.
(WebCore::createSurfaceForBackingStore):
(WebCore::WidgetBackingStorePrivate::create):
(WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate):
(WebCore::WidgetBackingStore::create):
(WebCore::WidgetBackingStore::WidgetBackingStore):
(WebCore::WidgetBackingStore::~WidgetBackingStore):
(WebCore::WidgetBackingStore::cairoSurface):
(WebCore::WidgetBackingStore::scroll):
- platform/gtk/GtkWidgetBackingStoreX11.cpp:
- 9:13 PM Changeset in webkit [95934] by
-
- 19 edits59 deletes in trunk
Finish removing PLATFORM(BREWMP) by removing associated code
https://bugs.webkit.org/show_bug.cgi?id=68779
Reviewed by Sam Weinig.
.:
- Source/cmake/WebKitPackaging.cmake:
- wscript:
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- JavaScriptCore.gypi:
- gyp/JavaScriptCore.gyp:
- wscript:
- wtf/FastMalloc.cpp:
(WTF::fastMallocSize):
- wtf/Vector.h:
- wtf/brew: Removed.
- wtf/brew/MainThreadBrew.cpp: Removed.
- wtf/brew/OwnPtrBrew.cpp: Removed.
- wtf/brew/RefPtrBrew.h: Removed.
- wtf/brew/ShellBrew.h: Removed.
- wtf/brew/StringBrew.cpp: Removed.
- wtf/brew/SystemMallocBrew.h: Removed.
- wtf/unicode/brew: Removed.
- wtf/unicode/brew/UnicodeBrew.cpp: Removed.
- wtf/unicode/brew/UnicodeBrew.h: Removed.
Source/WebCore:
When Geoffrey Garen removed PLATFORM(BREWMP) in
http://trac.webkit.org/changeset/95555, he did not remove all the
associated code. This completes the work started in r95555 by removing
all the code assoicated with PLATFORM(BREWMP).
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/js/ScriptControllerBrew.cpp: Removed.
- editing/brew: Removed.
- editing/brew/EditorBrew.cpp: Removed.
- gyp/WebCore.gyp:
- page/brew: Removed.
- page/brew/ChromeClientBrew.h: Removed.
- page/brew/DragControllerBrew.cpp: Removed.
- page/brew/EventHandlerBrew.cpp: Removed.
- page/brew/FrameBrew.cpp: Removed.
- platform/brew: Removed.
- platform/brew/ClipboardBrew.cpp: Removed.
- platform/brew/ClipboardBrew.h: Removed.
- platform/brew/ContextMenuBrew.cpp: Removed.
- platform/brew/ContextMenuItemBrew.cpp: Removed.
- platform/brew/CursorBrew.cpp: Removed.
- platform/brew/DragDataBrew.cpp: Removed.
- platform/brew/EventLoopBrew.cpp: Removed.
- platform/brew/FileSystemBrew.cpp: Removed.
- platform/brew/KURLBrew.cpp: Removed.
- platform/brew/LanguageBrew.cpp: Removed.
- platform/brew/LocalizedStringsBrew.cpp: Removed.
- platform/brew/LoggingBrew.cpp: Removed.
- platform/brew/MIMETypeRegistryBrew.cpp: Removed.
- platform/brew/PasteboardBrew.cpp: Removed.
- platform/brew/PlatformKeyboardEventBrew.cpp: Removed.
- platform/brew/PlatformMouseEventBrew.cpp: Removed.
- platform/brew/PlatformTouchEventBrew.cpp: Removed.
- platform/brew/PlatformTouchPointBrew.cpp: Removed.
- platform/brew/PopupMenuBrew.cpp: Removed.
- platform/brew/PopupMenuBrew.h: Removed.
- platform/brew/SSLKeyGeneratorBrew.cpp: Removed.
- platform/brew/ScreenBrew.cpp: Removed.
- platform/brew/ScrollbarThemeBrew.cpp: Removed.
- platform/brew/ScrollbarThemeBrew.h: Removed.
- platform/brew/SearchPopupMenuBrew.cpp: Removed.
- platform/brew/SearchPopupMenuBrew.h: Removed.
- platform/brew/SharedBufferBrew.cpp: Removed.
- platform/brew/SharedTimerBrew.cpp: Removed.
- platform/brew/SoundBrew.cpp: Removed.
- platform/brew/SystemTimeBrew.cpp: Removed.
- platform/brew/TemporaryLinkStubs.cpp: Removed.
- platform/brew/WidgetBrew.cpp: Removed.
- platform/graphics/brew: Removed.
- platform/graphics/brew/IconBrew.cpp: Removed.
- platform/graphics/brew/ImageBrew.cpp: Removed.
- platform/graphics/brew/IntPointBrew.cpp: Removed.
- platform/graphics/brew/IntSizeBrew.cpp: Removed.
- platform/network/brew: Removed.
- platform/network/brew/DNSBrew.cpp: Removed.
- platform/network/brew/SocketStreamError.h: Removed.
- platform/network/brew/SocketStreamHandle.h: Removed.
- platform/network/brew/SocketStreamHandleBrew.cpp: Removed.
- platform/network/brew/SocketStreamHandlePrivate.h: Removed.
- platform/text/brew: Removed.
- platform/text/brew/TextBoundariesBrew.cpp: Removed.
- platform/text/brew/TextBreakIteratorBrew.cpp: Removed.
- platform/text/brew/TextCodecBrew.cpp: Removed.
- platform/text/brew/TextCodecBrew.h: Removed.
Source/WebKit2:
- Scripts/generate-forwarding-headers.pl:
Tools:
- Scripts/webkitpy/common/config/build.py:
- waf/build/settings.py:
- 9:05 PM Changeset in webkit [95933] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG JIT does not count speculation successes correctly
https://bugs.webkit.org/show_bug.cgi?id=68785
Reviewed by Geoffrey Garen.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
- dfg/DFGOperations.cpp:
- 8:36 PM Changeset in webkit [95932] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG support for op_resolve_global is not enabled
https://bugs.webkit.org/show_bug.cgi?id=68786
Reviewed by Geoffrey Garen.
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- 8:30 PM Changeset in webkit [95931] by
-
- 8 edits2 adds in trunk
Implement a CloseEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68340
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-25
Reviewed by Oliver Hunt.
Source/WebCore:
The spec of the CloseEvent constructor is here:
http://dev.w3.org/html5/websockets/#closeevent
Test: fast/events/constructors/close-event-constructor.html
- bindings/generic/EventConstructors.h: Added a definition for the CloseEvent constructor.
- bindings/js/JSEventConstructors.cpp: Added #includes for CloseEvent.
- websockets/CloseEvent.h: Added a definition for CloseEventInit.
(WebCore::CloseEventInit::CloseEventInit):
(WebCore::CloseEvent::create):
(WebCore::CloseEvent::CloseEvent):
- websockets/CloseEvent.idl: Makes CloseEvent constructible.
LayoutTests:
- fast/dom/constructed-objects-prototypes-expected.txt: Now window has CloseEvent.
- fast/events/constructors/close-event-constructor-expected.txt: Added.
- fast/events/constructors/close-event-constructor.html: Added.
- platform/chromium/test_expectations.txt: Skipped close-event-constructor.html, since V8 does not yet have the CloseEvent constructor.
- 7:25 PM Changeset in webkit [95930] by
-
- 17 edits in trunk/Source/JavaScriptCore
DFG static prediction code is no longer needed and should be removed
https://bugs.webkit.org/show_bug.cgi?id=68784
Reviewed by Oliver Hunt.
This gets rid of static prediction code, and ensures that we do not
try to compile code where dynamic predictions are not available.
This is accomplished by immediately performing an OSR exit wherever
a value is retrieved for which no predictions exist.
This also adds value profiling for this on functions used for calls.
The heuristics for deciding when to optimize code are also tweaked,
since it is now profitable to optimize sooner. This may need to be
tweaked further, but this patch only makes minimal changes.
This results in a 16% speed-up on Kraken/ai-astar, leading to a 3%
overall win on Kraken. It's neutral elsewhere.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):
- bytecode/CodeBlock.h:
- bytecode/PredictedType.cpp:
(JSC::predictionToString):
- bytecode/PredictedType.h:
(JSC::isCellPrediction):
(JSC::isObjectPrediction):
(JSC::isFinalObjectPrediction):
(JSC::isStringPrediction):
(JSC::isArrayPrediction):
(JSC::isInt32Prediction):
(JSC::isDoublePrediction):
(JSC::isNumberPrediction):
(JSC::isBooleanPrediction):
(JSC::mergePredictions):
- bytecode/PredictionTracker.h:
(JSC::PredictionTracker::predictArgument):
(JSC::PredictionTracker::predict):
(JSC::PredictionTracker::predictGlobalVar):
- bytecode/ValueProfile.cpp:
(JSC::ValueProfile::computeUpdatedPrediction):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::getMethodCheckPrediction):
(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::getPrediction):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::emitBranch):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::getPrediction):
- dfg/DFGNode.h:
(JSC::DFG::Node::valueOfJSConstantNode):
(JSC::DFG::Node::isInt32Constant):
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::isBooleanConstant):
(JSC::DFG::Node::predict):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::isPredictedNumerical):
(JSC::DFG::Propagator::logicalNotIsPure):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):
(JSC::DFG::SpeculativeJIT::shouldSpeculateNumber):
(JSC::DFG::SpeculativeJIT::shouldNotSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArray):
(JSC::DFG::SpeculativeJIT::shouldSpeculateObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateCell):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- 6:40 PM Changeset in webkit [95929] by
-
- 3 edits in trunk/Source/WebCore
<rdar://problem/10177824> IconDatabase’s use of ThreadCondition leads to assertion failures in the face of spurious wakeups
It's possible for ThreadCondition::wait to return spuriously without the condition having been signaled.
When that happens we should immediately return to waiting rather than doing our normal work, as some of that
work relies on wakeSyncThread having been called to signal the condition.
Reviewed by Sam Weinig.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::wakeSyncThread): Note that we have work for the sync thread to do.
(WebCore::IconDatabase::syncThreadMainLoop): If we were woken with no work to do, immediately
go back to waiting on the condition variable. Otherwise, reset m_syncThreadHasWorkToDo and then
do that work. We also switch to moving m_disabledSuddenTerminationForSyncThread immediately in to
our local shouldReenableSuddenTermination variable since it can be updated by other threads while
we don't hold the lock. This makes it inappropriate to make assumptions about its value after dropping
and reacquiring the lock.
- loader/icon/IconDatabase.h:
- 6:12 PM Changeset in webkit [95928] by
-
- 1 edit2 adds in trunk/Tools
Provides a simple LRU cache class in Python.
https://bugs.webkit.org/show_bug.cgi?id=67823
Patch by Ai Makabi <makabi@google.com> on 2011-09-21
Reviewed by Tony Chang.
- Scripts/webkitpy/common/lru_cache.py:
- Scripts/webkitpy/common/lru_cache_unittest.py:
- 5:01 PM Changeset in webkit [95927] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG JIT Construct opcode takes a this argument even though it's
not passed
https://bugs.webkit.org/show_bug.cgi?id=68782
Reviewed by Oliver Hunt.
This is performance-neutral, mostly. It's a slight speed-up on
v8-splay.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCall):
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
- 4:58 PM Changeset in webkit [95926] by
-
- 3 edits2 adds in trunk
<rdar://problem/10156263> ASSERT in WebCore::FrameView::scheduleRelayoutOfSubtree
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/dynamic/subtree-unrooted.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::scheduleRelayout): Replaced the check that the renderer is parented,
which was added in r21162, with a check that it is “rooted”.
LayoutTests:
- fast/dynamic/subtree-unrooted-expected.txt: Added.
- fast/dynamic/subtree-unrooted.html: Added.
- 4:40 PM Changeset in webkit [95925] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG tracking of the value in cachedResultRegister does not handle
op_mov correctly
https://bugs.webkit.org/show_bug.cgi?id=68781
Reviewed by Oliver Hunt.
This takes the simplest approach: it makes the old JIT dumber rather
than making the DFG JIT smarter. This is performance-neutral.
- jit/JIT.h:
(JSC::JIT::canBeOptimized):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_mov):
- 2:42 PM Changeset in webkit [95924] by
-
- 4 edits2 adds in trunk
Source/WebCore: Issues with merging block children of a ruby
base with another ruby base having inline children.
https://bugs.webkit.org/show_bug.cgi?id=66124
Reviewed by Dan Bernstein.
Test: fast/ruby/ruby-base-merge-block-children-crash.html
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveInlineChildren): add a firstChild()
check to prevent empty anonymous block addition, just like
moveBlockChildren method.
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveBlockChildren): This was incorrectly
doing optimizations to see if current ruby base has only inline
children before beforeChild and then trying to take out them from
their parent anonymous blocks. The problem is those inlines could
be split and have continuations because of encountering a block
inside inline flow. In those cases, we cannot take the inline out.
So, we should just make children non-inline in the destination
block and transfer the children as it-is.
- rendering/RenderRubyBase.h: remove unncessary functions.
LayoutTests: Issues with merging block children of a ruby
base with another ruby base having inline children.
https://bugs.webkit.org/show_bug.cgi?id=66124
Reviewed by Dan Bernstein.
- fast/ruby/ruby-base-merge-block-children-crash.html: Added.
- platform/mac/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
- 2:15 PM Changeset in webkit [95923] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, remove fast/workers/storage/interrupt-database.html
from GTK test_expectations since it's been skipped in r95809.
- platform/gtk/test_expectations.txt:
- 12:35 PM Changeset in webkit [95922] by
-
- 48 edits9 deletes in trunk
Remove PLATFORM(HAIKU) and associated code
https://bugs.webkit.org/show_bug.cgi?id=68774
Reviewed by Sam Weinig.
.:
- Source/cmake/WebKitPackaging.cmake:
- wscript:
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- JavaScriptCore.gypi:
- gyp/JavaScriptCore.gyp:
- heap/MachineStackMarker.cpp:
- wtf/PageAllocation.h:
- wtf/Platform.h:
- wtf/StackBounds.cpp:
- wtf/haiku: Removed.
- wtf/haiku/MainThreadHaiku.cpp: Removed.
- wtf/haiku/StringHaiku.cpp: Removed.
- wtf/text/WTFString.h:
Source/WebCore:
As discussed on webkit-dev, the Haiku port has been inactive for over a
year. A year and a half ago, we discussed removing the port, but folks
said they planned to work on it more. That work does not appear to
have happened in the intervening time.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/js/ScriptControllerHaiku.cpp: Removed.
- editing/haiku: Removed.
- editing/haiku/EditorHaiku.cpp: Removed.
- gyp/WebCore.gyp:
- loader/cache/CachedFont.cpp:
- page/EventHandler.cpp:
(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
- page/haiku: Removed.
- page/haiku/DragControllerHaiku.cpp: Removed.
- page/haiku/EventHandlerHaiku.cpp: Removed.
- page/haiku/FrameHaiku.cpp: Removed.
- platform/ContextMenuItem.h:
- platform/Cursor.h:
- platform/DragData.h:
- platform/DragImage.h:
- platform/PlatformKeyboardEvent.h:
- platform/PlatformMenuDescription.h:
- platform/PlatformMouseEvent.h:
- platform/Widget.h:
- platform/graphics/BitmapImage.h:
- platform/graphics/Color.h:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/Gradient.h:
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContext.h:
- platform/graphics/ImageBufferData.h:
- platform/graphics/ImageSource.h:
- platform/graphics/IntPoint.h:
- platform/graphics/IntRect.h:
- platform/graphics/IntSize.h:
- platform/graphics/Path.h:
- platform/graphics/Pattern.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/haiku: Removed.
- platform/graphics/haiku/ColorHaiku.cpp: Removed.
- platform/graphics/haiku/FloatPointHaiku.cpp: Removed.
- platform/graphics/haiku/FloatRectHaiku.cpp: Removed.
- platform/graphics/haiku/FontCacheHaiku.cpp: Removed.
- platform/graphics/haiku/FontCustomPlatformData.cpp: Removed.
- platform/graphics/haiku/FontCustomPlatformData.h: Removed.
- platform/graphics/haiku/FontHaiku.cpp: Removed.
- platform/graphics/haiku/FontPlatformData.h: Removed.
- platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp: Removed.
- platform/graphics/haiku/GradientHaiku.cpp: Removed.
- platform/graphics/haiku/GraphicsContextHaiku.cpp: Removed.
- platform/graphics/haiku/IconHaiku.cpp: Removed.
- platform/graphics/haiku/ImageBufferDataHaiku.h: Removed.
- platform/graphics/haiku/ImageBufferHaiku.cpp: Removed.
- platform/graphics/haiku/ImageHaiku.cpp: Removed.
- platform/graphics/haiku/IntPointHaiku.cpp: Removed.
- platform/graphics/haiku/IntRectHaiku.cpp: Removed.
- platform/graphics/haiku/IntSizeHaiku.cpp: Removed.
- platform/graphics/haiku/PathHaiku.cpp: Removed.
- platform/graphics/haiku/SimpleFontDataHaiku.cpp: Removed.
- platform/graphics/haiku/StillImageHaiku.cpp: Removed.
- platform/graphics/haiku/StillImageHaiku.h: Removed.
- platform/haiku: Removed.
- platform/haiku/ClipboardHaiku.cpp: Removed.
- platform/haiku/ClipboardHaiku.h: Removed.
- platform/haiku/ContextMenuHaiku.cpp: Removed.
- platform/haiku/ContextMenuItemHaiku.cpp: Removed.
- platform/haiku/CookieJarHaiku.cpp: Removed.
- platform/haiku/CursorHaiku.cpp: Removed.
- platform/haiku/DragDataHaiku.cpp: Removed.
- platform/haiku/DragImageHaiku.cpp: Removed.
- platform/haiku/EventLoopHaiku.cpp: Removed.
- platform/haiku/FileSystemHaiku.cpp: Removed.
- platform/haiku/LocalizedStringsHaiku.cpp: Removed.
- platform/haiku/LoggingHaiku.cpp: Removed.
- platform/haiku/MIMETypeRegistryHaiku.cpp: Removed.
- platform/haiku/PasteboardHaiku.cpp: Removed.
- platform/haiku/PlatformKeyboardEventHaiku.cpp: Removed.
- platform/haiku/PlatformMouseEventHaiku.cpp: Removed.
- platform/haiku/PlatformWheelEventHaiku.cpp: Removed.
- platform/haiku/PopupMenuHaiku.cpp: Removed.
- platform/haiku/PopupMenuHaiku.h: Removed.
- platform/haiku/RenderThemeHaiku.cpp: Removed.
- platform/haiku/RenderThemeHaiku.h: Removed.
- platform/haiku/ScreenHaiku.cpp: Removed.
- platform/haiku/ScrollbarThemeHaiku.cpp: Removed.
- platform/haiku/ScrollbarThemeHaiku.h: Removed.
- platform/haiku/SearchPopupMenuHaiku.cpp: Removed.
- platform/haiku/SearchPopupMenuHaiku.h: Removed.
- platform/haiku/SharedBufferHaiku.cpp: Removed.
- platform/haiku/SharedTimerHaiku.cpp: Removed.
- platform/haiku/SoundHaiku.cpp: Removed.
- platform/haiku/TemporaryLinkStubs.cpp: Removed.
- platform/haiku/WidgetHaiku.cpp: Removed.
- platform/image-decoders/haiku: Removed.
- platform/image-decoders/haiku/ImageDecoderHaiku.cpp: Removed.
- platform/text/UnicodeRange.h:
- platform/text/haiku: Removed.
- platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp: Removed.
Source/WebKit:
- haiku: Removed.
- haiku/WebCoreSupport: Removed.
- haiku/WebCoreSupport/ChromeClientHaiku.cpp: Removed.
- haiku/WebCoreSupport/ChromeClientHaiku.h: Removed.
- haiku/WebCoreSupport/ContextMenuClientHaiku.cpp: Removed.
- haiku/WebCoreSupport/ContextMenuClientHaiku.h: Removed.
- haiku/WebCoreSupport/DragClientHaiku.cpp: Removed.
- haiku/WebCoreSupport/DragClientHaiku.h: Removed.
- haiku/WebCoreSupport/EditorClientHaiku.cpp: Removed.
- haiku/WebCoreSupport/EditorClientHaiku.h: Removed.
- haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp: Removed.
- haiku/WebCoreSupport/FrameLoaderClientHaiku.h: Removed.
- haiku/WebCoreSupport/InspectorClientHaiku.cpp: Removed.
- haiku/WebCoreSupport/InspectorClientHaiku.h: Removed.
Source/WebKit2:
- Scripts/generate-forwarding-headers.pl:
Tools:
- Scripts/webkitpy/common/config/build.py:
- waf/build/settings.py:
- 1:16 AM Changeset in webkit [95921] by
-
- 1 edit1 delete in trunk
[CMake] Remove FindLibXlst.cmake
https://bugs.webkit.org/show_bug.cgi?id=68770
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-25
Reviewed by Adam Barth.
This file should have never been committed -- the library it looks for
is called libxslt, not libxlst, so it has never really been used. When
the buildsystem looked for libxslt, it used CMake's own LibXslt.cmake
instead.
- Source/cmake/FindLibXlst.cmake: Removed.
- 12:03 AM Changeset in webkit [95920] by
-
- 3 edits in trunk/Source/WebCore
Attempted build fixes for GTK and Qt.
- GNUmakefile.list.am:
- WebCore.pro:
