Timeline
Feb 19, 2012:
- 11:51 PM Changeset in webkit [108212] by
-
- 5 edits in trunk/Source
[Chromium] Web Inspector: terminated workers are not removed from dedicated worker list
https://bugs.webkit.org/show_bug.cgi?id=78899
Source/WebCore:
Notify inspector about starting context from WorkerContextProxy not from Worker.
Reviewed by Pavel Feldman.
- workers/Worker.cpp:
(WebCore::Worker::notifyFinished):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):
Source/WebKit/chromium:
Pass original WorkerContextProxy object to the inspector instrumentation instead
of Chromium-specific one for consistency with WorkerMessagingProxy implementation
in WebCore.
Reviewed by Pavel Feldman.
- src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):
- 11:47 PM WebKitIDL edited by
- (diff)
- 11:41 PM Changeset in webkit [108211] by
-
- 8 edits in trunk
[CMAKE] Check gstreamer minimum required version.
https://bugs.webkit.org/show_bug.cgi?id=79005
Reviewed by Daniel Bates.
To enable video, Gstreamer version requires to be above 0.10.30.
This patch checks whether Gstreamer version is greater than 0.10.30.
- Source/cmake/FindGStreamer-App.cmake:
- Source/cmake/FindGStreamer-Base.cmake:
- Source/cmake/FindGStreamer-Interfaces.cmake:
- Source/cmake/FindGStreamer-Pbutils.cmake:
- Source/cmake/FindGStreamer-Plugins-Base.cmake:
- Source/cmake/FindGStreamer-Video.cmake:
- Source/cmake/FindGStreamer.cmake:
- 11:03 PM Changeset in webkit [108210] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, update a few test expectations.
- platform/chromium/test_expectations.txt:
- 10:41 PM WebKitIDL edited by
- (diff)
- 10:31 PM WebKitIDL edited by
- (diff)
- 10:30 PM WebKitIDL edited by
- (diff)
- 10:29 PM WebKitIDL edited by
- (diff)
- 10:26 PM WebKitGTK/1.8.x edited by
- (diff)
- 10:22 PM WebKitIDL edited by
- (diff)
- 10:17 PM Changeset in webkit [108209] by
-
- 2 edits in trunk/Source/WebCore
Use shadowRootList for ColorInputType
https://bugs.webkit.org/show_bug.cgi?id=79007
Reviewed by Kent Tamura.
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree): Changed shadowRoot to shadowRootList.
(WebCore::ColorInputType::shadowColorSwatch): Changed shadowRoot to shadowRootList.
- 10:14 PM WebKitIDL edited by
- (diff)
- 10:06 PM Changeset in webkit [108208] by
-
- 5 edits1 add1 delete in trunk/LayoutTests
[chromium] Unreviewed. Update remaining expectations for SVGImageElement-svgdom-requiredFeatures.html.
- platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
- platform/chromium/test_expectations.txt:
- 10:01 PM WebKitIDL edited by
- (diff)
- 10:00 PM WebKitIDL edited by
- (diff)
- 10:00 PM Changeset in webkit [108207] by
-
- 9 edits2 adds in trunk/Source/WebCore
Introduce InsertionPoint, which will be a common base class of HTMLShadowElement and HTMLContentElement.
https://bugs.webkit.org/show_bug.cgi?id=78771
Reviewed by Hajime Morita.
This patch introduces InsertionPoint, which will be a common base class of HTMLShadowElement and HTMLContentElement.
This is a step for rendering <shadow> correctly, because <shadow> has almost the same function of <content>.
After this patch, we will change NodeRenderingContext and related classes to accept InsertionPoint instead of
HTMLContentElement only.
No new tests, no change in behavior.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::parseAttribute):
- html/shadow/HTMLContentElement.h:
- html/shadow/InsertionPoint.cpp: Added.
(WebCore):
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::~InsertionPoint):
- html/shadow/InsertionPoint.h: Added.
(WebCore):
(InsertionPoint):
- 9:59 PM WebKitIDL edited by
- (diff)
- 9:24 PM Changeset in webkit [108206] by
-
- 8 edits in trunk/Source
[GTK] Can't find webinspector and error page redirection on Windows
https://bugs.webkit.org/show_bug.cgi?id=51616
Source/WebCore:
Create and use an abstraction for finding shared resources on Windows.
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2012-02-19
Reviewed by Martin Robinson.
- platform/FileSystem.h:
(WebCore):
- platform/audio/gtk/AudioBusGtk.cpp:
(WebCore::AudioBus::loadPlatformResource):
- platform/graphics/gtk/ImageGtk.cpp:
(WebCore::getPathToImageResource):
- platform/gtk/FileSystemGtk.cpp:
(WebCore::sharedResourcesPath):
(WebCore):
Source/WebKit/gtk:
Use an abstraction for finding shared resources on Windows.
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2012-02-19
Reviewed by Martin Robinson.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidFailLoad):
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::inspectorFilesPath):
- 8:22 PM Changeset in webkit [108205] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening. Update Leopard expectation for
SVGImageElement-svgdom-requiredFeatures.html.
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
- 5:11 PM Changeset in webkit [108204] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed - mark failing test as failing.
- platform/chromium/test_expectations.txt:
- 4:04 PM Changeset in webkit [108203] by
-
- 2 edits11 adds in trunk/LayoutTests
[chromium] Unreviewed gardening. Add leopard baselines for fast/css/relative-positioned-block-* tests, fix up test_expectations.txt
- platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 3:51 PM Changeset in webkit [108202] by
-
- 9 edits1 copy in trunk/Source/WebCore
Move stub implementations of ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp
https://bugs.webkit.org/show_bug.cgi?id=78951
Reviewed by Adam Barth.
This move stubs for ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp instead of #ifdefing inside
ScrollingCoordinator.cpp. The mac port uses ScrollingCoordinator when #if ENABLE(THREADED_SCROLLING) is not set
and implementations in ScrollingCoordinator.cpp / ScrollingCoordinatorMac.mm otherwise. The chromium port
always uses implementations in ScrollingCoordinatorChromium.cpp. All other ports use
ScrollingCoordinatorNone.cpp.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbx:
- page/scrolling/ScrollingCoordinator.cpp:
- page/scrolling/ScrollingCoordinatorNone.cpp:
(WebCore):
(WebCore::ScrollingCoordinator::create):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinator::create):
(WebCore):
- 3:47 PM Changeset in webkit [108201] by
-
- 8 edits in trunk/Source/WebCore
Rename [CheckDomainSecurity] to [CheckSecurity]
https://bugs.webkit.org/show_bug.cgi?id=78874
Reviewed by Adam Barth.
"Domain security" isn't a term that's used elsewhere.
This patch renames IDL attributes as follows:
- [CheckDomainSecurity] => [CheckSecurity]
- [DoNotCheckDomainSecurity] => [DoNotCheckSecurity]
- [DoNotCheckDomainSecurityOnGetter] => [DoNotCheckSecurityOnGetter]
- [DoNotCheckDomainSecurityOnSetter] => [DoNotCheckSecurityOnSetter]
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(IsVisibleAcrossOrigins):
(GenerateFunctionCallback):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateToV8Converters):
- bindings/scripts/test/TestDomainSecurity.idl:
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
- 3:32 PM Changeset in webkit [108200] by
-
- 8 edits2 adds2 deletes in trunk
Unreviewed, rolling out r108195.
http://trac.webkit.org/changeset/108195
https://bugs.webkit.org/show_bug.cgi?id=77700
Lots of failing ASSERT()s on v8 bots, requested by kling on
#webkit
Source/WebCore:
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
LayoutTests:
- fast/css/css-value-wrapper-sameness-expected.txt: Removed.
- fast/css/css-value-wrapper-sameness.html: Removed.
- fast/dom/StyleSheet/gc-inline-style-cssvalues-expected.txt: Added.
- fast/dom/StyleSheet/gc-inline-style-cssvalues.html: Added.
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/gc-9-expected.txt:
- fast/dom/gc-9.html:
- fast/dom/script-tests/domListEnumeration.js:
- 3:30 PM Changeset in webkit [108199] by
-
- 10 edits in trunk/Source/WebCore
Rename [CheckAccessToNode] to [CheckSecurityForNode]
https://bugs.webkit.org/show_bug.cgi?id=78991
Reviewed by Adam Barth.
For naming consistency with [CheckSecurity], this patch renames
[CheckAccessToNode] to [CheckSecurityForNode].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- html/HTMLEmbedElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLObjectElement.idl:
- page/DOMWindow.idl:
- 3:24 PM Changeset in webkit [108198] by
-
- 2 edits in trunk/Source/WebCore
Sort WebCore XCode project files with sort-Xcode-project-files script. Unreviewed.
- WebCore.xcodeproj/project.pbxproj:
- 2:50 PM WebKitGTK/1.8.x edited by
- (diff)
- 2:43 PM Changeset in webkit [108197] by
-
- 7 edits in releases/WebKitGTK/webkit-1.8
Merging r108190
- 12:58 PM Changeset in webkit [108196] by
-
- 4 edits in trunk/LayoutTests
Update expectations for test results changed by r108185
The bots only check text results.
Unreviewed.
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- 12:16 PM Changeset in webkit [108195] by
-
- 8 edits2 adds2 deletes in trunk
Make CSSValue wrapper getters return unique objects every time.
<http://webkit.org/b/77700>
Reviewed by Antti Koivisto.
Source/WebCore:
Change the behavior of CSSValue getters to return unique JS wrappers every
time they are called. This means we no longer have to deal with the risk
of leaking custom properties between unrelated documents, and are free to
implement global value sharing across WebCore.
This patch will be followed by one making CSSValuePool globally shared,
it's done in two steps to monitor the impact of this change.
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(IsCSSValueType):
LayoutTests:
- fast/css/css-value-wrapper-sameness-expected.txt: Added.
- fast/css/css-value-wrapper-sameness.html: Added.
- fast/dom/StyleSheet/gc-inline-style-cssvalues-expected.txt: Removed.
- fast/dom/StyleSheet/gc-inline-style-cssvalues.html: Removed.
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/gc-9-expected.txt:
- fast/dom/gc-9.html:
- fast/dom/script-tests/domListEnumeration.js:
- 12:06 PM Changeset in webkit [108194] by
-
- 3 edits2 adds in trunk
Crash in RenderBlock::splitAnonymousBlocksAroundChild.
https://bugs.webkit.org/show_bug.cgi?id=78994
Reviewed by Eric Seidel.
Source/WebCore:
Generalize splitTablePartsAroundChild to handle splitting
in nested tables.
Table->Table Section->Table Row->Table Cell->Table->Table Section->Table Row
Test: fast/table/table-split-inside-table.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitTablePartsAroundChild):
LayoutTests:
- fast/table/table-split-inside-table-expected.txt: Added.
- fast/table/table-split-inside-table.html: Added.
- 11:36 AM Changeset in webkit [108193] by
-
- 2 edits in trunk/Source/WebKit/gtk
Unreviewed. Remove gsettings schema from EXTRA_DIST.
- GNUmakefile.am:
- 11:29 AM Changeset in webkit [108192] by
-
- 2 edits in trunk/Tools
[EFL] Use modifier keys to execute pre-rendering.
https://bugs.webkit.org/show_bug.cgi?id=77933
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-19
Reviewed by Chang Shu.
Use modifier key to execute pre-rendering instead of using reserved function keys.
- EWebLauncher/main.c:
(on_key_down):
- 11:16 AM Changeset in webkit [108191] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Fix build on platforms where UChar is wchar_t
https://bugs.webkit.org/show_bug.cgi?id=78996
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-19
Reviewed by Martin Robinson.
The ICU backend defines UChar as wchar_t for platforms where wchar_t is
16 bits wide, e.g. win32.
- platform/graphics/pango/FontPango.cpp:
(WebCore::utf16ToUtf8): Use reinterpret_cast instead of static_cast.
- platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::typeAheadFind): Ditto.
- 11:16 AM Changeset in webkit [108190] by
-
- 7 edits1 delete in trunk
[GTK] Remove unused GSettings stuff
https://bugs.webkit.org/show_bug.cgi?id=78995
Reviewed by Martin Robinson.
.:
- configure.ac: remove gsettings schema file creation.
Source/WebKit/gtk:
- GNUmakefile.am: remove GSettings-related stuff.
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit): Remove unused code.
- org.webkitgtk.gschema.xml.in: Removed.
- webkit/webkitwebinspector.cpp:
(webkit_web_inspector_execute_script): remove gsettings-related helper.
- webkit/webkitwebinspectorprivate.h: Ditto.
- 11:03 AM WebKitGTK/1.8.x edited by
- (diff)
- 11:01 AM Changeset in webkit [108189] by
-
- 3 edits in trunk
Perf-o-matic should show both WebKit and Chromium revisions
https://bugs.webkit.org/show_bug.cgi?id=78955
Reviewed by Andreas Kling.
Include Chromium revision numbers in runs responses when available.
- Websites/webkit-perf.appspot.com/js/config.js:
(urlForChangeset):
(urlForChangesetList):
- Websites/webkit-perf.appspot.com/runs_handler.py:
(RunsHandler.post):
- 10:32 AM WebKitGTK/1.8.x edited by
- (diff)
- 10:16 AM WebKitGTK edited by
- (diff)
- 10:15 AM WebKitGTK/1.8.x created by
- 9:41 AM Changeset in webkit [108188] by
-
- 1 copy in releases/WebKitGTK/webkit-1.8
Branching for the WebKitGTK+ 1.8 stable release
- 8:53 AM Changeset in webkit [108187] by
-
- 4 edits in trunk/Source
Unreviewed. Fix make distcheck issues.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing files.
Source/WebCore:
- GNUmakefile.list.am: Add missing header.
- 8:27 AM Changeset in webkit [108186] by
-
- 5 edits25 moves36 adds2 deletes in trunk/LayoutTests
Chromium results for r108185
Unreviewed gardening.
- platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png.
- platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png.
- platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png.
- platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png.
- platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png.
- platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png.
- platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png.
- platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.png.
- platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png.
- platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png.
- platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/encoding/utf-16-big-endian-expected.png.
- platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/encoding/utf-16-little-endian-expected.png.
- platform/chromium-mac-snowleopard/fast/inline/continuation-outlines-with-layers-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/inline/continuation-outlines-with-layers-expected.png.
- platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
- platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png: Removed.
- platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png: Removed.
- platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
- platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt.
- platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
- platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt.
- platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
- platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt.
- platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
- platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
- platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt.
- platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.png:
- platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- 7:24 AM Changeset in webkit [108185] by
-
- 19 edits43 adds in trunk
CSS 2.1 failure: inline-box-002.htm fails
https://bugs.webkit.org/show_bug.cgi?id=69210
Reviewed by David Hyatt.
Source/WebCore:
Tests: css2.1/20110323/dynamic-top-change-005.htm
css2.1/20110323/dynamic-top-change-005a.htm
css2.1/20110323/dynamic-top-change-005b.htm
css2.1/20110323/inline-box-002.htm
fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html
fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html
fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic.html
fast/css/relative-positioned-block-nested-with-inline-parent.html
fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html
fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html
fast/css/relative-positioned-block-with-inline-ancestor-dynamic.html
fast/css/relative-positioned-block-with-inline-ancestor.html
fast/css/relative-positioned-block-with-inline-parent-dynamic-removed.html
fast/css/relative-positioned-block-with-inline-parent-dynamic.html
fast/css/relative-positioned-block-with-inline-parent-keeps-style.html
fast/css/relative-positioned-block-with-inline-parent.html
A block within an inline is affected by relative positioning on the inline box. Give
the anonymous block containing the block a layer and make it relative positioned. Then
calculate the offset of the anonymous block's layer by accumulating the offsets from its
inline continuation and the inline continuation's inline parents.
If the position of an inline changes from or to relative positioned then ensure that any
descendant blocks update their position and layer accordingly.
- rendering/RenderBoxModelObject.cpp:
(): add an enum RelPosAxis
(WebCore::accumulateRelativePositionOffsets):
Total up the offsets of all relatively positioned inlines that are de-facto parents of the relatively
positioned anonymous block's child block.
(WebCore):
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
Use accumulateRelativePositionOffsets when calculating the relative position offset of a relatively positioned anonymous block.
(WebCore::RenderBoxModelObject::relativePositionOffsetY): ditto
- rendering/RenderInline.cpp:
(WebCore::hasRelPositionedInlineAncestor):
Detects if the anonymous block contains a block that is the de-facto descendant of a relatively positioned inline.
(WebCore::updateStyleOfAnonymousBlockContinuations):
Update the style's positioning for each anonymous block containing a block that is descendant from the inline whose style has changed.
(WebCore::RenderInline::styleDidChange):
If an inline changes to or from relative positioning ensure that any descendant blocks change to or from relative positioning
as well, unless they still have a relatively positioned ancestor after the current ancestor loses its relative positioning.
(WebCore::RenderInline::addChildIgnoringContinuation):
If the anonymous block contains a block that is effectively descended from a relatively positioned inline, make it relatively
positioned so the block will respect its inline ancestor's relative positioning.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren):
Preserve style position in anonymous block continuations when the parent block propagates a style change.
LayoutTests:
- css2.1/20110323/dynamic-top-change-005-expected.html: Added.
- css2.1/20110323/dynamic-top-change-005.htm: Added.
- css2.1/20110323/dynamic-top-change-005a-expected.html: Added.
- css2.1/20110323/dynamic-top-change-005a.htm: Added.
- css2.1/20110323/dynamic-top-change-005b-expected.html: Added.
- css2.1/20110323/dynamic-top-change-005b.htm: Added.
- css2.1/20110323/inline-box-002-expected.html: Added.
- css2.1/20110323/inline-box-002.htm: Added.
- fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html: Added.
- fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html: Added.
- fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic.html: Added.
- fast/css/relative-positioned-block-nested-with-inline-parent.html: Added.
- fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html: Added.
- fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html: Added.
- fast/css/relative-positioned-block-with-inline-ancestor-dynamic.html: Added.
- fast/css/relative-positioned-block-with-inline-ancestor.html: Added.
- fast/css/relative-positioned-block-with-inline-parent-dynamic-removed.html: Added.
- fast/css/relative-positioned-block-with-inline-parent-dynamic.html: Added.
- fast/css/relative-positioned-block-with-inline-parent-expected.html: Added.
- fast/css/relative-positioned-block-with-inline-parent-keeps-style.html: Added.
- fast/css/relative-positioned-block-with-inline-parent.html: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
- platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
- platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.txt:
- platform/chromium-linux/fast/inline/continuation-outlines-with-layers-expected.png:
- platform/chromium-linux/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
- platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
- platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.txt:
- platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
- platform/chromium/test_expectations.txt: Suppress existing tests until results rebaselined.
- platform/gtk/test_expectations.txt: ditto
- platform/mac/test_expectations.txt: ditto
- platform/qt/test_expectations.txt: ditto
- platform/win/Skipped: ditto
Feb 18, 2012:
- 10:25 PM Changeset in webkit [108184] by
-
- 6 edits1 add in trunk/Source
Track the NPN protocol version negotiated with the server
https://bugs.webkit.org/show_bug.cgi?id=77349
Source/WebCore:
Patch by raman Tenneti <rtenneti@chromium.org> on 2012-02-18
Reviewed by Darin Fisher..
[chromium] Added ExtraData to WebURLResponse.
No intended functionality change.
- platform/network/chromium/ResourceResponse.h:
(ExtraData):
(WebCore::ResourceResponse::ExtraData::~ExtraData):
(ResourceResponse):
(WebCore::ResourceResponse::extraData):
(WebCore::ResourceResponse::setExtraData):
Source/WebKit/chromium:
Patch by raman Tenneti <rtenneti@chromium.org> on 2012-02-18
Reviewed by Darin Fisher.
[chromium] Added ExtraData to WebURLResponse.
- WebKit.gypi:
- public/platform/WebURLResponse.h:
(ExtraData):
(WebKit::WebURLResponse::ExtraData::~ExtraData):
(WebURLResponse):
- src/WebURLResponse.cpp:
(WebKit::WebURLResponse::extraData):
(WebKit):
(WebKit::WebURLResponse::setExtraData):
- tests/WebURLResponseTest.cpp: Added.
(WebKit):
(TestExtraData):
(WebKit::TestExtraData::TestExtraData):
(WebKit::TestExtraData::~TestExtraData):
(WebKit::TEST):
- 8:57 PM Changeset in webkit [108183] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r107965.
http://trac.webkit.org/changeset/107965
https://bugs.webkit.org/show_bug.cgi?id=78273
Source/WebCore:
crashes
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
LayoutTests:
Crashes on ClusterFuzz.
- fast/multicol/span/clone-flexbox-expected.txt: Removed.
- fast/multicol/span/clone-flexbox.html: Removed.
- 8:07 PM Changeset in webkit [108182] by
-
- 2 edits in trunk/Tools
Fix one more dangling reference to worker_connection.name, delete unused code.
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.update):
(_WorkerState.init):
- 7:53 PM Changeset in webkit [108181] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/10891801> BackingStore::scroll() unnecessarily copies pixels around
https://bugs.webkit.org/show_bug.cgi?id=78976
Reviewed by Anders Carlsson.
Rather than move pixels in the backing store in response to scrolling, we can maintain a
mapping, for the most recently scrolled rect, from backing store coordinates to view
client coordinates.
- UIProcess/BackingStore.h:
- UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::performWithScrolledRectTransform): Added. Given a block to be
performed on a rect, divides the rect into parts such that for each part the mapping from
backing store coordinates to client coordinates is a (uniform) translation, and performs
the block on that part, passing it the translation that applies to the part.
(WebKit::BackingStore::resetScrolledRect): Added. Copies everything in the scrolled rect
back to where it should be under the identity map, and resets the scrolled rect and offset.
(WebKit::BackingStore::paint): Changed to call through performWithScrolledRectTransform().
(WebKit::BackingStore::incorporateUpdate): Ditto.
(WebKit::BackingStore::scroll): Now instead of copying pixels, just updates the scrolled
rect and offset.
- 5:53 PM Changeset in webkit [108180] by
-
- 6 edits in trunk/Source/JavaScriptCore
Fix style issues in DFG Phase classes
https://bugs.webkit.org/show_bug.cgi?id=78983
Reviewed by Ryosuke Niwa.
- dfg/DFGArithNodeFlagsInferencePhase.cpp:
- dfg/DFGCFAPhase.cpp:
- dfg/DFGCSEPhase.cpp:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
Add a space before the colon in class declarations.
- 5:08 PM Changeset in webkit [108179] by
-
- 2 edits in trunk/Source/WebCore
Make WebCore compile with libc++ (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=78974
Reviewed by Anders Carlsson.
- config.h:
Disable the DisallowCType check when using libc++.
- 4:57 PM Changeset in webkit [108178] by
-
- 2 edits in trunk/Source/WebCore
Fix the build.
- page/DOMWindow.idl:
- 4:50 PM Changeset in webkit [108177] by
-
- 4 edits in trunk/Tools
Add a change that should've been in r108005.
Unreviewed, build fix.
In the refactoring/cleanup in r108005 I should've changed the
implementation of WorkerConnection to make it match BrokerClient
(and everything else) so that objects had a name() method
instead of a name property.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_WorkerConnection.init):
(_WorkerConnection.name):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker.init):
(_TestsMixin.name):
(_TestsMixin.test_name):
(_TestsMixin.test_cancel):
(_TestsMixin.test_unknown_message):
- 4:33 PM Changeset in webkit [108176] by
-
- 2 edits in trunk/Source/JavaScriptCore
Attempt to fix Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:51 PM Changeset in webkit [108175] by
-
- 6 edits2 deletes in trunk/Tools
webkitpy: remove webkitpy.common.array_stream
https://bugs.webkit.org/show_bug.cgi?id=78952
Reviewed by Eric Seidel.
Turns out array_stream didn't really do anything that StringIO
didn't do (at least as of Python 2.6). This change removes it
and updates all of the callers. Where possible, I changed the
test assertions in order to capture the intent more clearly,
e.g., instead of calling self.assertTrue('foo' in stream.get()),
we have self.assertContainsLine(stream, 'foo'), and instead of
self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
the latter isn't that much more readable, but StringIO doesn't
export an empty() method.
- Scripts/webkitpy/common/array_stream.py: Removed.
- Scripts/webkitpy/common/array_stream_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(passing_run):
(run_and_capture):
(StreamTestingMixin):
(StreamTestingMixin.assertContains):
(StreamTestingMixin.assertContainsLine):
(StreamTestingMixin.assertEmpty):
(StreamTestingMixin.assertNotEmpty):
(LintTest):
(LintTest.test_lint_test_files):
(LintTest.test_lint_test_fileserrors):
(MainTest):
(MainTest.test_child_process_1):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_help_printing):
(MainTest.test_hung_thread):
(MainTest.test_no_tests_found):
(MainTest.test_no_tests_found_2):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_test_list):
(MainTest.test_unexpected_failures):
(MainTest.test_worker_modelinline_with_child_processes):
(MainTest.test_additional_platform_directory):
(RebaselineTest):
(RebaselineTest.assertBaselines):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):
- Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream.update):
- Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(TestMeteredStream.test_regular):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(TestUtilityFunctions.assertEmpty):
(TestUtilityFunctions):
(TestUtilityFunctions.assertNotEmpty):
(TestUtilityFunctions.assertWritten):
(TestUtilityFunctions.test_configure_logging):
(Testprinter.assertEmpty):
(Testprinter):
(Testprinter.assertNotEmpty):
(Testprinter.assertWritten):
(Testprinter.reset):
(Testprinter.get_printer):
(Testprinter.test_help_printer):
(Testprinter.do_switch_tests.do_helper):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_test_result):
(Testprinter.test_print_progress):
(Testprinter.test_write_nothing):
(Testprinter.test_write_misc):
(Testprinter.test_write_everything):
(Testprinter.test_write_verbose):
(Testprinter.test_print_unexpected_results):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.assertWritten):
(create_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(test_upload_json):
- 3:42 PM Changeset in webkit [108174] by
-
- 2 edits in trunk/Source/WebCore
Make WebCore compile with libc++ (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=78974
Reviewed by Anders Carlsson.
Add a workaround for <rdar://problem/10858112>, which cause the standard heap functions
not to work when using an iterator with proxy objects for reference and pointer types.
- WebCorePrefix.h:
(move):
Add an overload of std::move that the heap functions can call successfully.
- 2:30 PM Changeset in webkit [108173] by
-
- 3 edits in trunk/LayoutTests
Unreviewed chromium rebaselines after r108157.
- platform/chromium-mac/fast/dom/setPrimitiveValue-exceptions-expected.txt:
- platform/chromium-win/fast/dom/setPrimitiveValue-exceptions-expected.txt:
- 2:10 PM Changeset in webkit [108172] by
-
- 4 edits in trunk
[wx] Fix wx port compilation.
- 2:07 PM Changeset in webkit [108171] by
-
- 3 edits in trunk/Source/WebCore
[wx] Build fixes for C++ bindings after recent changes.
- 2:04 PM Changeset in webkit [108170] by
-
- 2 edits in trunk/Source/WebCore
[wx] Build fix, add new platform method wx impl.
- 1:48 PM Changeset in webkit [108169] by
-
- 2 edits in trunk/Source/WebCore
Fix part of the windows build failure.
- WebCore.vcproj/WebCore.vcproj:
Don't build JSWebKitCSSRegionRule.cpp, since it is already being built
as part of DerivedSources.cpp.
- 1:30 PM Changeset in webkit [108168] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the libc++ build.
Reviewed by Anders Carlsson.
- heap/Weak.h:
Libc++'s nullptr emulation does not allow default construction
of the nullptr_t type. Work around this with the arguably clearer
just returning nullptr.
- 1:28 PM Changeset in webkit [108167] by
-
- 2 edits in trunk/Source/WebCore
Fix the ENABLE(THREADED_SCROLLING) build.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
- 12:07 PM Changeset in webkit [108166] by
-
- 6 edits12 adds2 deletes in trunk/Source/JavaScriptCore
DFGPropagator.cpp has too many things
https://bugs.webkit.org/show_bug.cgi?id=78956
Reviewed by Oliver Hunt.
Added the notion of a DFG::Phase. Removed DFG::Propagator, and took its
various things and put them into separate files. These new phases follow
the naming convention "DFG<name>Phase" where <name> is a noun. They are
called via functions of the form "perform<name>".
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGArithNodeFlagsInferencePhase.cpp: Added.
(DFG):
(JSC::DFG::performArithNodeFlagsInference):
- dfg/DFGArithNodeFlagsInferencePhase.h: Added.
(DFG):
- dfg/DFGCFAPhase.cpp: Added.
(DFG):
(JSC::DFG::performCFA):
- dfg/DFGCFAPhase.h: Added.
(DFG):
- dfg/DFGCSEPhase.cpp: Added.
(DFG):
(JSC::DFG::performCSE):
- dfg/DFGCSEPhase.h: Added.
(DFG):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGPhase.cpp: Added.
(DFG):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
- dfg/DFGPhase.h: Added.
(DFG):
(Phase):
(JSC::DFG::Phase::Phase):
(JSC::DFG::Phase::~Phase):
(JSC::DFG::Phase::globalData):
(JSC::DFG::Phase::codeBlock):
(JSC::DFG::Phase::profiledBlock):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
(JSC::DFG::runPhase):
- dfg/DFGPredictionPropagationPhase.cpp: Added.
(DFG):
(JSC::DFG::performPredictionPropagation):
- dfg/DFGPredictionPropagationPhase.h: Added.
(DFG):
- dfg/DFGPropagator.cpp: Removed.
- dfg/DFGPropagator.h: Removed.
- dfg/DFGVirtualRegisterAllocationPhase.cpp: Added.
(DFG):
(JSC::DFG::performVirtualRegisterAllocation):
- dfg/DFGVirtualRegisterAllocationPhase.h: Added.
(DFG):
- 11:58 AM Changeset in webkit [108165] by
-
- 7 edits in trunk/Source/WebCore
HTML: Remove unnecessary attributeChange() overrides.
<http://webkit.org/b/78890>
Reviewed by Anders Carlsson.
Move logic from attributeChanged() overrides into parseAttribute().
This is a step towards making attributeChanged() non-virtual.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseAttribute):
- html/HTMLScriptElement.h:
(HTMLScriptElement):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute):
- html/HTMLTrackElement.h:
(HTMLTrackElement):
- 11:53 AM Changeset in webkit [108164] by
-
- 4 edits in trunk/Source/WebCore
Remove Element::createAttribute().
<http://webkit.org/b/78965>
Reviewed by Anders Carlsson.
Switch call sites to use Attribute::create() directly, as there is no magic
in calling Element::createAttribute() anymore (it used to be virtual and handled
differently by StyledElement.)
- dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
- dom/Element.h:
- svg/properties/SVGAnimatedPropertySynchronizer.h:
- 11:48 AM Changeset in webkit [108163] by
-
- 2 edits in trunk/Source/WebCore
HTMLBodyElement: Avoid synchronous style recalc when setting link/vlink/alink.
<http://webkit.org/b/78959>
Reviewed by Anders Carlsson.
Mark the body element for deferred style recalc instead of doing it synchronously
when the attributes change.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseAttribute):
- 10:33 AM Changeset in webkit [108162] by
-
- 2 edits in trunk/Source/WebCore
Fix the TextureMapper build for non-Qt ports. Qt debug builds
must use RTTI, but GTK+, at least, does not.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore): Make the RTTI check
Qt only.
- 10:17 AM Changeset in webkit [108161] by
-
- 2 edits in trunk/Tools
[wx] Unreviewed build fix. Don't error out or hang if we have
downloaded dependencies but server update check fails.
- 5:04 AM Changeset in webkit [108160] by
-
- 6 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r107971.
- platform/qt/tables/mozilla/bugs/bug27038-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug27038-2-expected.txt:
- platform/qt/test_expectations.txt:
- 4:59 AM Changeset in webkit [108159] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip new failing tests.
- platform/qt/Skipped:
- 4:51 AM Changeset in webkit [108158] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening r108133.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 3:42 AM Changeset in webkit [108157] by
-
- 5 edits in trunk
FontFamilyValue: Utilize inheritance from CSSPrimitiveValue better.
<http://webkit.org/b/78806>
Reviewed by Antti Koivisto.
Source/WebCore:
Now that FontFamilyValue's string doesn't change after creation, we can just
pass the massaged family name up to the CSSPrimitiveValue constructor and get
cached cssText() for free. This also shrinks FontFamilyValue by sizeof(String)
though that's less of an issue now that we cache them in CSSValuePool.
- css/FontFamilyValue.cpp:
(WebCore::stripFontFamilyJunk):
(WebCore::FontFamilyValue::FontFamilyValue):
- css/FontFamilyValue.h:
(WebCore::FontFamilyValue::familyName):
(FontFamilyValue):
LayoutTests:
Rebaseline as CSSPrimitiveValue.getStringValue() is no longer broken for
font-family values.
- fast/dom/setPrimitiveValue-exceptions-expected.txt:
- 12:25 AM Changeset in webkit [108156] by
-
- 5 edits in branches/safari-534.54-branch/Source
Versioning
- 12:19 AM Changeset in webkit [108155] by
-
- 1 copy in tags/Safari-534.54.16
New tag.
Feb 17, 2012:
- 11:56 PM Changeset in webkit [108154] by
-
- 16 edits in trunk/Source/JavaScriptCore
DFG::Graph should have references to JSGlobalData, the CodeBlock being compiled, and
the CodeBlock that was used for profiling
https://bugs.webkit.org/show_bug.cgi?id=78954
Reviewed by Gavin Barraclough.
- bytecode/CodeBlock.h:
(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
(JSC):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::execute):
- dfg/DFGAbstractState.h:
- dfg/DFGAssemblyHelpers.h:
(AssemblyHelpers):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::parse):
- dfg/DFGByteCodeParser.h:
(DFG):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::Graph):
(Graph):
(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::isInt32Constant):
(JSC::DFG::Graph::isDoubleConstant):
(JSC::DFG::Graph::isNumberConstant):
(JSC::DFG::Graph::isBooleanConstant):
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
(JSC::DFG::Graph::baselineCodeBlockFor):
(JSC::DFG::Graph::valueProfileFor):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::JITCompiler):
(JITCompiler):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::isNotNegZero):
(JSC::DFG::Propagator::isNotZero):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::globalCFA):
(JSC::DFG::propagate):
- dfg/DFGPropagator.h:
(DFG):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
- 11:28 PM Changeset in webkit [108153] by
-
- 2 edits in trunk/Source/JavaScriptCore
There is a warning in memset in glibc that gets triggered through a
warndecl when the fill-value of memset is a non-zero constant and the
size is zero. This warning is enabled when building with
-D_FORTIFY_SOURCE=2. This patch fixes the warning.
https://bugs.webkit.org/show_bug.cgi?id=78513
Patch by Ahmad Sharif <asharif.tools@gmail.com> on 2012-02-17
Reviewed by Alexey Proskuryakov
- wtf/Vector.h:
- 7:22 PM Changeset in webkit [108152] by
-
- 4 edits4 adds in trunk
Avoid inconsistency in Node::inDocument due to DOMSubtreeModified dispatch
https://bugs.webkit.org/show_bug.cgi?id=76087
Reviewed by Ryosuke Niwa.
Source/WebCore:
Move post-removal notifications after call to Node::removeFromDocument
to avoid inconsistent state of Node::inDocument() and thus avoid
inconsistent state in DocumentOrderedMap.
Tests: fast/dom/getElementById-consistency.html
fast/dom/getElementById-consistency2.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::updateReferencedText): Fixed to work with new timing of DOMSubtreeModified dispatch.
LayoutTests:
- fast/dom/getElementById-consistency-expected.txt: Added.
- fast/dom/getElementById-consistency.html: Added.
- fast/dom/getElementById-consistency2-expected.txt: Added.
- fast/dom/getElementById-consistency2.html: Added.
- 6:51 PM Changeset in webkit [108151] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] change the way of registering DeviceOrientation clients.
https://bugs.webkit.org/show_bug.cgi?id=78680
Reviewed by Gustavo Noronha Silva.
Bug 78085 removed deviceOrientationClient and deviceMotionClient from PageClients. Instead,
DeviceOrientationClient and DeviceMotionClient should be registered by PageSupplement class.
Chromium, mac and qt ports are already changed by Bug 78085.
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
- 6:46 PM Changeset in webkit [108150] by
-
- 22 edits2 adds in trunk
IndexedDB: Support overloaded methods that take IDBKey or IDBKeyRange
https://bugs.webkit.org/show_bug.cgi?id=78399
Source/WebCore:
Implements IDBObjectStore.delete(IDBKeyRange) to exercise the functionality.
Reviewed by Tony Chang.
Test: storage/indexeddb/delete-range.html
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallString): Use .get() to disambiguate when passing RefPtr.
- bindings/scripts/test/V8/V8TestObj.cpp: Update test expectations.
- storage/IDBLevelDBBackingStore.cpp:
(WebCore):
- storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::deleteFunction):
(WebCore):
- storage/IDBObjectStore.h:
(IDBObjectStore):
- storage/IDBObjectStore.idl:
- storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
- storage/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
- storage/IDBObjectStoreBackendInterface.h:
Source/WebKit/chromium:
Implements the WebKit API for IDBObjectStore.delete(IDBKeyRange),
to exercise the overload capability.
Reviewed by Tony Chang.
- src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::deleteFunction):
(WebKit):
- src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
- src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::deleteFunction):
(WebKit):
- src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
LayoutTests:
Tests IDBObjectStore.delete(IDBKeyRange). The spec has been updated such
that delete() always yields a result of undefined rather than a boolean,
so other test expectations are updated.
Reviewed by Tony Chang.
- storage/indexeddb/delete-range-expected.txt: Added.
- storage/indexeddb/delete-range.html: Added.
- storage/indexeddb/mozilla/delete-result-expected.txt:
- storage/indexeddb/mozilla/delete-result.html:
- storage/indexeddb/objectStore-required-arguments-expected.txt:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics-workers-expected.txt:
- storage/indexeddb/resources/objectstore-basics.js:
(createIndex):
(removeSuccess):
(removeSuccessButNotThere):
- 6:20 PM Changeset in webkit [108149] by
-
- 3 edits in trunk/Source/WebCore
Replace [V8OnInstance] with [V8Unforgeable]
https://bugs.webkit.org/show_bug.cgi?id=78894
Reviewed by Adam Barth.
[V8OnInstance] means that the method should be defined
(not on a prototype chain but) on a DOM object. It is the
same meaning as [V8Unforgeable]. This patch replaces [V8OnInstance]
with [V8Unforgeable].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
- page/Location.idl:
- 6:07 PM Changeset in webkit [108148] by
-
- 20 edits in branches/subpixellayout/Source/WebCore
Adding pixel snapped methods to FractionalLayoutRect. Adding a roundToInt abstraction, using it everywhere except FractionalLayout* classes, and correcting a ton of incorrect rounding methods. Cleaning up RenderInline::paintOutlineForLine. Fixing a crash in adjustRectForColumns.
- 6:03 PM Changeset in webkit [108147] by
-
- 6 edits1 add1 delete in trunk/LayoutTests
[chromium] Unreviewed gardening, update baselines for svg/dynamic-updates/.. and some more getComputedStyle
results
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
- 5:19 PM Changeset in webkit [108146] by
-
- 2 edits1 move in trunk/Source/WebCore
[chromium] Unreviewed build fix. MSVS gyp generator can't handle multiple .cpps with the same name in the same
target from different paths.
- WebCore.gypi:
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: Renamed from Source/WebCore/page/scrolling/chromium/ScrollingCoordinator.cpp.
(WebCore):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
- 5:02 PM Changeset in webkit [108145] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed mac compile fix pt 2
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
- 5:01 PM Changeset in webkit [108144] by
-
- 4 edits in trunk/Tools
The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
https://bugs.webkit.org/show_bug.cgi?id=69444
Reviewed by Tony Chang.
Currently if a test's image checksum doesn't match the checksum
in the baseline, but the images themselves match according to
ImageDiff, new-run-webkit-tests ignores the problem. This is
probably bad, but it's not yet clear what the right thing to do
is. This patch will log a warning to stderr, at least (but the
test will still pass).
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):
(SingleTestRunner._run_reftest):
- Scripts/webkitpy/layout_tests/port/test.py:
(unit_test_list):
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
- 4:56 PM Changeset in webkit [108143] by
-
- 4 edits in trunk/Tools
NRWT does not report failure for a skipped test
https://bugs.webkit.org/show_bug.cgi?id=78750
Reviewed by Eric Seidel.
If a test is listed in a Skipped file and you run it anyway
with --force, and the test fails, currently NRWT will print
"test ran as expected"; this is confusing, because you probably
expect the test to fail and yet this might lead you to think the
test passed. This patch changes the expected behavior to "PASS",
so tests that fail will be reported.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(result_was_expected):
(TestExpectationParser):
(TestExpectationParser.expectation_for_skipped_test):
(TestExpectations):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_add_skipped_tests):
- Scripts/webkitpy/layout_tests/port/test.py:
(unit_test_list): Add some tests that are expected to be in a Skipped file.
(TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
- 4:50 PM Changeset in webkit [108142] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed mac compile fix (unused parameter warning)
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
- 4:33 PM Changeset in webkit [108141] by
-
- 3 edits in trunk/Tools
webkitpy: fix test code after bug 78181
https://bugs.webkit.org/show_bug.cgi?id=78870
Reviewed by Adam Barth.
I forgot to update the test code as per Tony's suggestion in
bug 78181 (r108005). This change does that, and in doing so
it revealed a subtle bug in _InlineWorkerConnection.run() that
I am fixing as part of this (_alive would not be cleared if an
exception was thrown).
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_InlineWorkerConnection.run):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker.init):
(_TestWorker.handle_stop):
(_TestWorker.handle_test):
(_TestWorker.run):
(_TestsMixin.handle_exception):
(_TestsMixin.test_unknown_message):
- 4:23 PM Changeset in webkit [108140] by
-
- 23 edits1 copy1 add in trunk/Source/WebCore
Move ScrollingCoordinator out of ENABLE(THREADED_SCROLLING) ifdef and enable on all platforms
https://bugs.webkit.org/show_bug.cgi?id=78401
Reviewed by Adam Barth.
Separates THREADED_SCROLLING from ScrollingCoordinator and enables ScrollingCoordinator-related code on
chromium. ScrollingCoordinator receives scrolling information to be used with an external scrolling source.
ENABLE(THREADED_SCROLLING) enables a codepath that uses a thread in WebCore to handle scrolling related input
events and interact with composited layers.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- dom/Document.cpp:
(WebCore::wheelEventHandlerCountChanged):
- page/FrameView.cpp:
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::performPostLayoutTasks):
- page/Page.cpp:
(WebCore::Page::~Page):
(WebCore):
- page/Page.h:
(Page):
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(Settings):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
(WebCore::ScrollingCoordinator::pageDestroyed):
(WebCore):
- page/scrolling/ScrollingCoordinator.h:
(WebCore):
(ScrollingCoordinator):
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::createThreadIfNeeded):
- page/scrolling/ScrollingTreeState.cpp:
- page/scrolling/ScrollingTreeState.h:
- page/scrolling/chromium/ScrollingCoordinator.cpp: Added.
(WebCore):
(WebCore::ScrollingCoordinator::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
(WebCore::shouldCompositeOverflowControls):
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::ensureRootLayer):
(WebCore):
- rendering/RenderLayerCompositor.h:
(WebCore):
(RenderLayerCompositor):
- 4:14 PM Changeset in webkit [108139] by
-
- 5 edits in trunk/LayoutTests
[chromium] Unreviewed - removing expectations for tests that consistently pass, update some baselines for
getComputedStyle due to new -webkit-line-align property.
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium/test_expectations.txt:
- 4:02 PM Changeset in webkit [108138] by
-
- 8 edits1 add in trunk/Source/WebCore
Add FractionalLayoutPoint for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=78913
Reviewed by Eric Seidel.
Add FractionalLayoutUnit version of Point class and a couple of
conversion methods to the Int and Float versions of same.
No new tests.
- GNUmakefile.list.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FloatPoint.cpp:
(WebCore::FloatPoint::FloatPoint):
(WebCore):
(WebCore::FloatPoint::moveBy):
- platform/graphics/FloatPoint.h:
(WebCore):
(FloatPoint):
- platform/graphics/FractionalLayoutPoint.h: Added.
(WebCore):
(FractionalLayoutPoint):
(WebCore::FractionalLayoutPoint::FractionalLayoutPoint):
(WebCore::FractionalLayoutPoint::zero):
(WebCore::FractionalLayoutPoint::x):
(WebCore::FractionalLayoutPoint::y):
(WebCore::FractionalLayoutPoint::setX):
(WebCore::FractionalLayoutPoint::setY):
(WebCore::FractionalLayoutPoint::move):
(WebCore::FractionalLayoutPoint::moveBy):
(WebCore::FractionalLayoutPoint::scale):
(WebCore::FractionalLayoutPoint::expandedTo):
(WebCore::FractionalLayoutPoint::shrunkTo):
(WebCore::FractionalLayoutPoint::clampNegativeToZero):
(WebCore::FractionalLayoutPoint::transposedPoint):
(WebCore::operator+=):
(WebCore::operator-=):
(WebCore::operator+):
(WebCore::operator-):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::toPoint):
(WebCore::toSize):
(WebCore::flooredIntPoint):
(WebCore::roundedIntPoint):
(WebCore::ceiledIntPoint):
- platform/graphics/FractionalLayoutSize.cpp:
(WebCore::pixelSnappedIntSize):
- platform/graphics/FractionalLayoutSize.h:
(WebCore):
- 3:57 PM Changeset in webkit [108137] by
-
- 8 edits in trunk/Source/WebCore
Move textDirectionForSelection from Editor to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=78868
Reviewed by Enrica Casucci.
Move textDirectionForSelection from Editor to EditingStyle to centralize the editing code's
dependency on CSSStyleDeclaration.
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore):
- editing/EditingStyle.h:
(EditingStyle):
- editing/Editor.cpp:
(WebCore):
- editing/Editor.h:
(Editor):
- editing/EditorCommand.cpp:
(WebCore::stateTextWritingDirection):
- editing/ReplaceSelectionCommand.cpp:
- editing/markup.cpp:
- 3:33 PM Changeset in webkit [108136] by
-
- 9 edits in trunk/Source/WebCore
MathML internals - embellished operators, getBase() accessor functions
https://bugs.webkit.org/show_bug.cgi?id=78617
Patch by David Barton <Dave Barton> on 2012-02-17
Reviewed by Eric Seidel.
Define functions that return an unembellished "base", by omitting
subscripts/superscripts, underscripts/overscripts, or denominators. This is needed in
subsequent patches both for correct operator stretching and simple code factoring.
No new tests.
- rendering/mathml/RenderMathMLBlock.h:
(WebCore):
(RenderMathMLBlock):
(WebCore::RenderMathMLBlock::unembellishedOperator):
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::unembellishedOperator):
(WebCore):
- rendering/mathml/RenderMathMLFraction.h:
(RenderMathMLFraction):
- rendering/mathml/RenderMathMLOperator.h:
(WebCore::RenderMathMLOperator::unembellishedOperator):
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::base):
(WebCore):
(WebCore::RenderMathMLSubSup::unembellishedOperator):
(WebCore::RenderMathMLSubSup::stretchToHeight):
- renamed a variable for clarity, especially in later patches
(WebCore::RenderMathMLSubSup::layout):
- renamed a variable for clarity, especially in later patches
- rendering/mathml/RenderMathMLSubSup.h:
(RenderMathMLSubSup):
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::base):
(WebCore):
(WebCore::RenderMathMLUnderOver::unembellishedOperator):
(WebCore::RenderMathMLUnderOver::stretchToHeight):
- rendering/mathml/RenderMathMLUnderOver.h:
(RenderMathMLUnderOver):
- 3:28 PM Changeset in webkit [108135] by
-
- 11 edits in trunk/Source
[Qt][WK2] Allow opaque tiles
https://bugs.webkit.org/show_bug.cgi?id=78809
Source/WebCore:
Replace the isOpaque boolean in BitmapTexture to a SupportsAlpha flag.
Use reset/didReset instead of a virtual function that has to call the superclass.
Make sure that all calls to BitmapTexture::reset() pass the correct SupportsAlpha flag,
based on the source image.
Since we now disable blending for opaque textures, we also have to make sure that we treat
the depth buffer correctly and bring it back to its previous state.
Reviewed by Kenneth Rohde Christiansen.
No behavior changes.
- platform/graphics/opengl/TextureMapperGL.cpp:
(TextureMapperGLData):
(WebCore::TextureMapperGLData::initStencil):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::beginClip):
- platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::BitmapTexture):
(WebCore::BitmapTexture::flags):
(WebCore::BitmapTexture::didReset):
(WebCore::BitmapTexture::reset):
(BitmapTexture):
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):
- platform/graphics/texmap/TextureMapperBackingStore.h:
(TextureMapperTiledBackingStore):
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::didReset):
(WebCore):
- platform/graphics/texmap/TextureMapperImageBuffer.h:
(BitmapTextureImageBuffer):
Source/WebKit2:
Apply the SupportsAlpha flag only when the buffers actually have alpha.
Reviewed by Kenneth Rohde Christiansen.
- Shared/ShareableBitmap.h:
(ShareableBitmap):
- Shared/qt/ShareableBitmapQt.cpp:
- UIProcess/qt/LayerBackingStore.cpp:
(WebKit::LayerBackingStoreTile::swapBuffers):
- 3:16 PM Changeset in webkit [108134] by
-
- 7 edits2 adds in trunk
Crash in SVGAnimateElement due to changed target
https://bugs.webkit.org/show_bug.cgi?id=75096
Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-17
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The SVGAnimateElement object creates various internal objects
depending on the type of property being animated, which depends on the
target. These objects were not being recreated when the target
changed, and crashes ensued. Now the SVGSMILElement provides a virtual
method that is called when the target changes, and SVGAnimateElement
updates its objects as necessary. We also deactivate the animation
when the target changes, forcing recomputation of other derived
objects.
This change also removes various unnecessary calls to semi-expensive
methods.
Not only does this change fix the new test, it also fixes potential
crashes in other tests that apparently never manifested before (but
manifest when this new test is included in DRT).
Test: svg/animations/svglength-animation-retarget-crash.html
- svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::hasValidAttributeType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::calculateDistance):
(WebCore):
(WebCore::SVGAnimateElement::targetElementDidChange):
- svg/SVGAnimateElement.h:
(SVGAnimateElement):
- svg/SVGAnimatedTypeAnimator.h:
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::type):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::targetElement):
(WebCore::SVGSMILElement::resetTargetElement):
(WebCore):
- svg/animation/SVGSMILElement.h:
(SVGSMILElement):
(WebCore::SVGSMILElement::targetElementDidChange):
LayoutTests:
This test verifies that the target element information is correctly
updated when the target changes. Note that the clone is required, as
it causes the results of one animation to be pushed to a different
animation.
- svg/animations/svglength-animation-retarget-crash-expected.txt: Added.
- svg/animations/svglength-animation-retarget-crash.html: Added.
- 3:13 PM Changeset in webkit [108133] by
-
- 15 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=78934
Add the -webkit-line-align property to support the alignment of lines in the inline direction
to the line grid.
Reviewed by Dan Bernstein.
Source/WebCore:
Added fast/line-grid/line-align-parsing.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator LineAlign):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
LayoutTests:
- fast/line-grid/line-align-parsing-expected.txt: Added.
- fast/line-grid/line-align-parsing.html: Added.
- fast/line-grid/script-tests/line-align-parsing.js: Added.
- 3:08 PM Changeset in webkit [108132] by
-
- 4 edits in trunk/Source
Versioning.
- 3:07 PM Changeset in webkit [108131] by
-
- 10 edits2 adds in trunk/Source/WebCore
Add FractionalLayoutSize for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=78852
Reviewed by Eric Seidel.
Add FractionalLayoutUnit version of Size class and a couple of
conversion methods to the Int and Float versions of same.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FloatPoint.cpp:
(WebCore::FloatPoint::move):
Add FractionalLayoutSize version of move.
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatSize.cpp:
(WebCore::FloatSize::FloatSize):
Add FloatSize(FractionalLayoutSize) constructor.
- platform/graphics/FloatSize.h:
- platform/graphics/FractionalLayoutSize.cpp: Added.
- platform/graphics/FractionalLayoutSize.h: Added.
- 2:57 PM Changeset in webkit [108130] by
-
- 1 edit1 move2 adds in trunk/LayoutTests
[chromium] Unreviewed. Land the last (hopefully) new baselines for fast/css/non-empty-span.html
- platform/chromium-mac-leopard/fast/css/non-empty-span-expected.png: Added.
- platform/chromium-win/fast/css/non-empty-span-expected.png: Added.
- platform/chromium-win/fast/css/non-empty-span-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/css/non-empty-span-expected.txt.
- 2:50 PM Changeset in webkit [108129] by
-
- 34 edits in branches/subpixellayout/Source
Avoid unnecessary rounding/snapping and replace LayoutUnit(0) with constant.
- 2:44 PM Changeset in webkit [108128] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r107606): Copy Link writes malformed WebURLsWithTitlesPboardType
data to the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=78933
<rdar://problem/10874553>
For this format, the data needs to be placed in the pasteboard as array of arrays
of strings. Currently is it stored as array of strings, which causes the code
that uses this format to break.
Reviewed by Ryosuke Niwa.
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::setPathnamesForType):
- 2:36 PM Changeset in webkit [108127] by
-
- 6 edits12 adds in trunk
Incorrect placement of a new child when beforeChild and its
previous sibling are in the same table.
https://bugs.webkit.org/show_bug.cgi?id=78269
Reviewed by Julien Chaffraix.
Source/WebCore:
Tests: fast/table/table-cell-split.html
fast/table/table-row-split.html
fast/table/table-section-split-with-after-content.html
fast/table/table-section-split.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitAnonymousBlocksAroundChild): add
call to splitTablePartsAroundChild to take care of splitting the
table first if the child is part of table.
(WebCore::markTableForSectionAndCellRecalculation): add helper to
mark table for complete relayout by invalidating sections and cells.
(WebCore):
(WebCore::moveAllTableChildrenTo): moves children to another table.
(WebCore::RenderBlock::splitTablePartsAroundChild): split table child
and its next siblings into a new table. This allows adding a new
non-table child between the tables.
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): calls
splitTablePartsAroundChild to see if we need to split the table
for adding this new child.
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createAnonymousTable): add helper for
creating anonymous table.
(WebCore):
(WebCore::RenderObject::addChild): use the new helper for creating
anonymous table.
- rendering/RenderObject.h:
(WebCore):
(RenderObject):
(WebCore::RenderObject::isTablePart): add helper to tell if the object
is a table part.
LayoutTests:
Test passes if the div child splits the table parts and is not
part of table itself.
- fast/table/table-cell-split-expected.txt: Added.
- fast/table/table-cell-split.html: Added.
- fast/table/table-row-split-expected.txt: Added.
- fast/table/table-row-split.html: Added.
- fast/table/table-section-split-expected.txt: Added.
- fast/table/table-section-split-with-after-content-expected.txt: Added.
- fast/table/table-section-split-with-after-content.html: Added.
- fast/table/table-section-split.html: Added.
- 2:34 PM Changeset in webkit [108126] by
-
- 3 edits in trunk/Source/WebCore
Element: Inline style selector and AX invalidation in attributeChanged().
<http://webkit.org/b/78888>
Reviewed by Antti Koivisto.
Inline the updateAfterAttributeChanged() and recalcStyleIfNeededAfterAttributeChanged()
methods into Element::attributeChanged(). They were separated when we needed them in
StyledElement::attributeChanged(), but that's no longer the case.
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- dom/Element.h:
- 2:31 PM Changeset in webkit [108125] by
-
- 4 edits in trunk
Clang/Mac build fix after r108119
Source/WebKit2:
- WebProcess/WebProcess.cpp:
(WebKit::randomCrashThread): Annotate this function with NO_RETURN_DUE_TO_CRASH.
Tools:
Mac build fix after r108119
- DumpRenderTree/mac/DumpRenderTree.mm:
(runThread):
(runPthread):
(testThreadIdentifierMap):
Updated to match current WTF threading APIs.
- 2:25 PM Changeset in webkit [108124] by
-
- 3 edits in trunk/Source/WebCore
[Chromium] Texture eviction doesn't show up in traces.
https://bugs.webkit.org/show_bug.cgi?id=78851
Patch by David Reveman <reveman@chromium.org> on 2012-02-17
Reviewed by James Robinson.
Add TextureManager::evictTexture() function with TRACE statement so
that texture eviction shows up in traces.
No new tests.
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::evictTexture):
(WebCore):
(WebCore::TextureManager::reduceMemoryToLimit):
- platform/graphics/chromium/TextureManager.h:
(TextureManager):
- 2:22 PM Changeset in webkit [108123] by
-
- 1 delete in trunk/Source/WebCore/manual-tests
Remove empty directory.
- 2:21 PM Changeset in webkit [108122] by
-
- 1 copy in tags/Safari-535.21
New Tag.
- 2:09 PM Changeset in webkit [108121] by
-
- 1 edit2 adds in trunk/LayoutTests
[chromium] Unreviewed - add some more fast/css/non-empty-span expectations.
- platform/chromium-mac-snowleopard/fast/css/non-empty-span-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/non-empty-span-expected.txt: Added.
- 2:00 PM Changeset in webkit [108120] by
-
- 2 edits2 moves in trunk/LayoutTests
[chromium] Unreviewed baseline and expectation updates.
- platform/chromium-linux/fast/css/non-empty-span-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.png.
- platform/chromium-linux/fast/css/non-empty-span-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt.
- platform/chromium/test_expectations.txt:
- 1:54 PM Changeset in webkit [108119] by
-
- 49 edits in trunk/Source
Remove unused parameters from WTF threading API
https://bugs.webkit.org/show_bug.cgi?id=78389
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-17
Reviewed by Adam Roben.
waitForThreadCompletion() had an out param 'void result' to get the
'void *' returned by ThreadFunction. However, the implementation in
ThreadingWin.cpp ignored the out param, not filling it in. This had
led to a situation where none of the client code made use of the param
and just ignored it.
To clean this up, the patch changes the signature of ThreadFunction to
return void instead of void* and drops the the unused 'void result'
parameter from waitForThreadCompletion. Also, all client code is
updated for the API change.
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=78389 , even
though the change only affects internal API, Safari is using it
directly and we'll need to keep the old versions around for ABI
compatibility. For this, the patch adds compatibility wrappers with
the old ABI.
Source/JavaScriptCore:
- JavaScriptCore.order:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- bytecode/SamplingTool.cpp:
(JSC::SamplingThread::threadStartFunc):
(JSC::SamplingThread::stop):
- bytecode/SamplingTool.h:
(SamplingThread):
- heap/Heap.cpp:
(JSC::Heap::~Heap):
(JSC::Heap::blockFreeingThreadStartFunc):
- heap/Heap.h:
- heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::~MarkStackThreadSharedData):
- heap/MarkStack.h:
(MarkStackThreadSharedData):
- wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ThreadPrivate::workerThread):
- wtf/ParallelJobsGeneric.h:
(ThreadPrivate):
- wtf/ThreadFunctionInvocation.h: Update the signature of
ThreadFunction.
(WTF):
- wtf/Threading.cpp:
(WTF::threadEntryPoint): Update for ThreadFunction signature change.
(WTF):
(WTF::ThreadFunctionWithReturnValueInvocation::ThreadFunctionWithReturnValueInvocation):
ABI compatibility function for Safari.
(ThreadFunctionWithReturnValueInvocation): Ditto.
(WTF::compatEntryPoint): Ditto.
(WTF::createThread): Ditto.
(WTF::waitForThreadCompletion): Ditto.
- wtf/Threading.h: Update the signature of ThreadFunction and
waitForThreadCompletion.
(WTF):
- wtf/ThreadingPthreads.cpp: Implement the new API.
(WTF::wtfThreadEntryPoint):
(WTF):
(WTF::createThreadInternal):
(WTF::waitForThreadCompletion):
- wtf/ThreadingWin.cpp: Implement the new API.
(WTF::wtfThreadEntryPoint):
(WTF::waitForThreadCompletion):
Source/WebCore:
- bindings/js/GCController.cpp:
(WebCore::collect):
(WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):
- fileapi/FileThread.cpp:
(WebCore::FileThread::fileThreadStart):
(WebCore::FileThread::runLoop):
- fileapi/FileThread.h:
(FileThread):
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::close):
(WebCore::IconDatabase::iconDatabaseSyncThreadStart):
(WebCore::IconDatabase::iconDatabaseSyncThread):
(WebCore::IconDatabase::syncThreadMainLoop):
- loader/icon/IconDatabase.h:
(IconDatabase):
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::threadCallback):
- page/scrolling/ScrollingThread.h:
(ScrollingThread):
- platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::databaseLoaderEntry):
(WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion):
- platform/audio/ReverbConvolver.cpp:
(WebCore::backgroundThreadEntry):
(WebCore::ReverbConvolver::~ReverbConvolver):
- platform/network/cf/LoaderRunLoopCF.cpp:
(WebCore::runLoaderThread):
- storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThreadStart):
(WebCore::DatabaseThread::databaseThread):
- storage/DatabaseThread.h:
(DatabaseThread):
- storage/LocalStorageThread.cpp:
(WebCore::LocalStorageThread::threadEntryPointCallback):
(WebCore::LocalStorageThread::threadEntryPoint):
(WebCore::LocalStorageThread::terminate):
- storage/LocalStorageThread.h:
(LocalStorageThread):
- webaudio/AsyncAudioDecoder.cpp:
(WebCore::AsyncAudioDecoder::~AsyncAudioDecoder):
(WebCore::AsyncAudioDecoder::threadEntry):
- webaudio/AsyncAudioDecoder.h:
(AsyncAudioDecoder):
- webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::uninitialize):
(WebCore::OfflineAudioDestinationNode::renderEntry):
- webaudio/OfflineAudioDestinationNode.h:
(OfflineAudioDestinationNode):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThreadStart):
(WebCore::WorkerThread::workerThread):
- workers/WorkerThread.h:
(WorkerThread):
Source/WebKit/win:
- WebKit.vcproj/WebKit_Cairo.def: Add the new functions.
- WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.
Source/WebKit2:
- Platform/WorkQueue.h:
(WorkQueue):
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::startWorkQueueThread):
- UIProcess/Launcher/mac/ThreadLauncherMac.mm:
(WebKit::webThreadBody):
- UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
(WebKit::webThreadBody):
- UIProcess/Launcher/win/ThreadLauncherWin.cpp:
(WebKit::webThreadBody):
- WebProcess/WebProcess.cpp:
(WebKit::randomCrashThread):
- win/WebKit2.def:
- win/WebKit2CFLite.def:
- 1:53 PM Changeset in webkit [108118] by
-
- 2 edits in trunk/Tools
revert r107147 - breaks webkit-patch on Mac SL
https://bugs.webkit.org/show_bug.cgi?id=78866
Reviewed by Adam Barth.
It appears that zipfile.ExtractAll is broken on Python 2.6.1,
which is the version that ships on Mac SL. Reverting this
change until we no longer have to worry about that version.
- Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller):
(AutoInstaller._extract_all): Added a comment about SL.
(AutoInstaller._unzip):
- 1:48 PM Changeset in webkit [108117] by
-
- 2 edits in trunk/Source/WebCore
AppleMac Build fix for r108111
Remove variable that is now unused.
Unreviewed, build fix.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::alwaysRequiresLineBox): Remove lineInfo
(WebCore::requiresLineBox):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
- 1:40 PM Changeset in webkit [108116] by
-
- 8 edits in trunk/Source
[chromium] GL_CHROMIUM_gpu_memory_manager extension
https://bugs.webkit.org/show_bug.cgi?id=77155
Patch by Michal Mocny <mmocny@google.com> on 2012-02-17
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/Extensions3DChromium.h:
(GpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::GpuMemoryAllocationChangedCallbackCHROMIUM::~GpuMemoryAllocationChangedCallbackCHROMIUM):
(Extensions3DChromium):
Source/WebKit/chromium:
- public/platform/WebGraphicsContext3D.h:
(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::~WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
- src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore):
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):
- src/GraphicsContext3DPrivate.h:
(WebCore):
- tests/FakeWebGraphicsContext3D.h:
(WebKit::FakeWebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
(FakeWebGraphicsContext3D):
- 1:40 PM WebDevelopers edited by
- (diff)
- 1:36 PM Changeset in webkit [108115] by
-
- 2 edits in trunk/LayoutTests
[chromium] Re-enable compositing/culling/scrolled-within-boxshadow.html
https://bugs.webkit.org/show_bug.cgi?id=78859
Reviewed by James Robinson.
- platform/chromium/test_expectations.txt:
- 1:28 PM Changeset in webkit [108114] by
-
- 5 edits6 adds in trunk/LayoutTests
[chromium] Rebaseline tests for composited filters
https://bugs.webkit.org/show_bug.cgi?id=78903
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-17
Reviewed by Stephen White.
- compositing/culling/filter-occlusion-alpha-large.html:
- compositing/culling/filter-occlusion-alpha.html:
- compositing/culling/filter-occlusion-blur-large.html:
- compositing/culling/filter-occlusion-blur.html:
- platform/chromium-linux/compositing/culling/filter-occlusion-blur-expected.png: Added.
- platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
- platform/chromium-win/compositing/culling/filter-occlusion-blur-expected.png: Added.
- platform/chromium-win/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
- 1:23 PM Changeset in webkit [108113] by
-
- 4 edits in trunk/LayoutTests
[chromium] Update baselines for border-radius-wide-border-01 due to skia change. Unreviewed.
- platform/chromium-linux/fast/borders/border-radius-wide-border-01-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-01-expected.png:
- platform/chromium-win/fast/borders/border-radius-wide-border-01-expected.png:
- 1:17 PM Changeset in webkit [108112] by
-
- 15 edits3 adds in trunk
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Implement support for stack traces on exception objects. This is a rewrite
of the core portion of the last stack walking logic, but the mechanical work
of adding the information to an exception comes from the original work by
Juan Carlos Montemayor Elosua.
- interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
(JSC):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
- interpreter/Interpreter.h:
(JSC):
(StackFrame):
(JSC::StackFrame::toString):
(Interpreter):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
- parser/Nodes.h:
(JSC::FunctionBodyNode::setInferredName):
- parser/Parser.h:
(JSC::::parse):
- runtime/CommonIdentifiers.h:
- runtime/Error.cpp:
(JSC::addErrorInfo):
- runtime/Error.h:
(JSC):
LayoutTests:
Add testcases for producing a stack trace on exception objects.
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js: Added.
(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
(selfRecursive1):
(selfRecursive2):
(selfRecursive3):
(throwError):
(object.get getter1.o.valueOf):
(object.get getter1):
(object.get getter2):
(object.get getter3.o2.valueOf):
(object.get getter3):
(object.nonInlineable.callCount):
(object.nonInlineable):
(object.inlineable):
(yetAnotherInlinedCall):
(makeInlinableCall):
(.try.g):
(h):
(mapTest):
(mapTestDriver):
(dfgFunction):
(try.f):
- fast/js/stack-trace-expected.txt: Added.
- fast/js/stack-trace.html: Added.
- 1:10 PM Changeset in webkit [108111] by
-
- 4 edits5 adds in trunk
REGRESSION: empty span creates renders with non-zero height
https://bugs.webkit.org/show_bug.cgi?id=76465
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/css/empty-span.html
fast/css/non-empty-span.html
Empty inlines with line-height, vertical-alignment or font metrics should only get a linebox if there is some
other content in the line. So only create line boxes for such elements on lines that are not empty.
This patch fixes a regression where an empty inline with line-height was propagating its height to an empty line.
It also fixes cases where lines with content that had a leading empty inline element weren't respecting the
vertical alignment or font-height of the empty inline.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::constructLine): only create line boxes for lines that are not empty.
(WebCore::requiresLineBoxForContent): an inline flow with line-height, vertical-alignment, or font-size
will need a linebox if the rest of the line is not empty.
(WebCore):
(WebCore::alwaysRequiresLineBox): rename from inlineFlowRequiresLineBox.
(WebCore::requiresLineBox):
(WebCore::RenderBlock::LineBreaker::nextLineBreak): if the inline flow definitely requires a line, mark
the line non-empty - otherwise hold off.
LayoutTests:
- fast/css/empty-span-expected.html: Added.
- fast/css/empty-span.html: Added.
- fast/css/non-empty-span.html: Added.
- platform/chromium/test_expectations.txt: Suppress result until rebaseline on MAC and WIN.
- platform/chromium-linux-x86/fast/css/non-empty-span-expected.png: Added.
- platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt: Added.
- 12:57 PM Changeset in webkit [108110] by
-
- 2 edits in trunk/Source/WebCore
RealtimeAnalyserNode does not consistently respect .minDecibels
https://bugs.webkit.org/show_bug.cgi?id=78729
Make use of m_minDecibel consistent. Clean up some style issues
with names of local variables and style issues with float
constants.
Patch by Raymond Toy <Raymond Toy> on 2012-02-17
Reviewed by Chris Rogers.
No new tests because the changes are cosmetic for style issues.
- webaudio/RealtimeAnalyser.cpp:
(WebCore):
(WebCore::RealtimeAnalyser::doFFTAnalysis):
(WebCore::RealtimeAnalyser::getFloatFrequencyData):
(WebCore::RealtimeAnalyser::getByteFrequencyData):
(WebCore::RealtimeAnalyser::getByteTimeDomainData):
- 12:51 PM Changeset in webkit [108109] by
-
- 3 edits3 adds in trunk
:before content incorrectly placed in continuation
when we don't have a first child.
https://bugs.webkit.org/show_bug.cgi?id=78380
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/css-generated-content/before-content-continuation-chain.html
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
LayoutTests:
- fast/css-generated-content/before-content-continuation-chain-expected.png: Added.
- fast/css-generated-content/before-content-continuation-chain-expected.txt: Added.
- fast/css-generated-content/before-content-continuation-chain.html: Added.
- 12:44 PM Changeset in webkit [108108] by
-
- 34 edits3 adds in trunk
CSS regions enabled by default
https://bugs.webkit.org/show_bug.cgi?id=78525
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/regions/css-regions-disabled.html
Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::cssRegionsEnabled):
(WebCore):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::createRegionRule):
- css/CSSParser.h:
- dom/Document.cpp:
(WebCore::Document::cssRegionsEnabled):
(WebCore):
(WebCore::Document::webkitGetFlowByName):
- dom/Document.h:
(Document):
- dom/Element.cpp:
(WebCore::Element::webkitRegionOverflow):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setCSSRegionsEnabled):
(WebCore::Settings::cssRegionsEnabled):
(Settings):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
Source/WebKit/chromium:
Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setExperimentalCSSRegionsEnabled):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
Source/WebKit/mac:
Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences cssRegionsEnabled]):
(-[WebPreferences setCSSRegionsEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
- Shared/WebPreferencesStore.h:
(WebKit):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCSSRegionsEnabled):
(WKPreferencesGetCSSRegionsEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::overridePreference):
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
LayoutTests:
Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
- fast/regions/css-regions-disabled-expected.txt: Added.
- fast/regions/css-regions-disabled.html: Added.
- fast/regions/script-tests/css-regions-disabled.js: Added.
(testWebKitFlowInto):
(testWebKitFlowFrom):
(testWebKitRegionOverflow):
(testComputedStyleWebKitFlowInto):
(testComputedStyleWebKitFlowFrom):
(testComputedStyleWebKitRegionOverflow):
- 12:09 PM Changeset in webkit [108107] by
-
- 16 edits4 adds4 deletes in trunk/Source/JavaScriptCore
Rename Bump* to Copy*
https://bugs.webkit.org/show_bug.cgi?id=78573
Reviewed by Geoffrey Garen.
Renamed anything with "Bump" in the name to have "Copied" instead.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- heap/BumpBlock.h: Removed.
- heap/BumpSpace.cpp: Removed.
- heap/BumpSpace.h: Removed.
- heap/BumpSpaceInlineMethods.h: Removed.
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::genericAddPointer):
- heap/ConservativeRoots.h:
(ConservativeRoots):
- heap/CopiedBlock.h: Added.
(JSC):
(CopiedBlock):
(JSC::CopiedBlock::CopiedBlock):
- heap/CopiedSpace.cpp: Added.
(JSC):
(JSC::CopiedSpace::tryAllocateSlowCase):
- heap/CopiedSpace.h: Added.
(JSC):
(CopiedSpace):
(JSC::CopiedSpace::isInCopyPhase):
(JSC::CopiedSpace::totalMemoryAllocated):
(JSC::CopiedSpace::totalMemoryUtilized):
- heap/CopiedSpaceInlineMethods.h: Added.
(JSC):
(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::contains):
(JSC::CopiedSpace::pin):
(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::recycleBlock):
(JSC::CopiedSpace::getFreshBlock):
(JSC::CopiedSpace::borrowBlock):
(JSC::CopiedSpace::addNewBlock):
(JSC::CopiedSpace::allocateNewBlock):
(JSC::CopiedSpace::fitsInBlock):
(JSC::CopiedSpace::fitsInCurrentBlock):
(JSC::CopiedSpace::tryAllocate):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::allocateFromBlock):
(JSC::CopiedSpace::tryReallocate):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::isOversize):
(JSC::CopiedSpace::isPinned):
(JSC::CopiedSpace::oversizeBlockFor):
(JSC::CopiedSpace::blockFor):
- heap/Heap.cpp:
- heap/Heap.h:
(JSC):
(Heap):
- heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::startCopying):
(JSC::SlotVisitor::allocateNewSpace):
(JSC::SlotVisitor::doneCopying):
- heap/MarkStack.h:
(MarkStackThreadSharedData):
- heap/SlotVisitor.h:
(SlotVisitor):
- runtime/JSArray.cpp:
- runtime/JSObject.cpp:
- 12:07 PM Changeset in webkit [108106] by
-
- 2 edits in trunk/Tools
Some API tests erroneously use = instead of == (causing build failures)
https://bugs.webkit.org/show_bug.cgi?id=78915
Reviewed by Sam Weinig.
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
(TestWebKitAPI::decidePolicyForNewWindowAction): ditto
- 12:05 PM Changeset in webkit [108105] by
-
- 2 edits in trunk/LayoutTests
Case typo in fast/js/script-tests/date-constructor.js
https://bugs.webkit.org/show_bug.cgi?id=78898
Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-02-17
Reviewed by Adam Barth.
- fast/js/script-tests/date-constructor.js: toSTring to toString
- 12:00 PM Changeset in webkit [108104] by
-
- 4 edits in trunk/Source/WebKit/gtk
[GTK] [AC] Events can starve accelerated compositing updates
https://bugs.webkit.org/show_bug.cgi?id=78826
Reviewed by Gustavo Noronha Silva.
Instead of using a WebCore timer, which can be starved by GdkEvents,
use a raw GLib timer with GDK_PRIORITY_EVENTS to drive AC updates.
This prevents dragging from blocking rendering.
- WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext): Store a GLib source tag instead of a WebCore timer.
- WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
Remove the timer upon destruction.
(WebKit::syncLayersTimeoutCallback): Added this callback for the GLib timer.
(WebKit::AcceleratedCompositingContext::markForSync): Use a GLib timer.
(WebKit::AcceleratedCompositingContext::syncLayersTimeout): Ditto.
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::~AcceleratedCompositingContext):
Remove the timer upon destruction.
(WebKit::syncLayersTimeoutCallback): Added this callback for the GLib timer.
(WebKit::AcceleratedCompositingContext::markForSync): Use a GLib timer.
(WebKit::AcceleratedCompositingContext::syncLayersTimeout): Ditto.
- 11:58 AM Changeset in webkit [108103] by
-
- 9 edits2 adds in trunk
[CSSRegions]Implement NamedFlow::overflow
https://bugs.webkit.org/show_bug.cgi?id=78880
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/regions/webkit-named-flow-overflow.html
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::WebKitNamedFlow):
(WebCore::WebKitNamedFlow::overflow):
(WebCore):
- dom/WebKitNamedFlow.h:
(WebCore):
(WebCore::WebKitNamedFlow::create):
(WebKitNamedFlow):
- dom/WebKitNamedFlow.idl:
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::ensureNamedFlow):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
- rendering/RenderFlowThread.h:
LayoutTests:
- fast/regions/resources/helper.js:
(testContentToRegionsMapping):
- fast/regions/resources/region-style.css:
- fast/regions/webkit-named-flow-overflow-expected.txt: Added.
- fast/regions/webkit-named-flow-overflow.html: Added.
- 11:56 AM Changeset in webkit [108102] by
-
- 19 edits in trunk
flex-wrap:nowrap should be flex-wrap:none
https://bugs.webkit.org/show_bug.cgi?id=78772
As per the spec http://dev.w3.org/csswg/css3-flexbox/#flex-wrap0, flex-wrap:nowrap should be changed to flex-wrap:none.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-02-17
Reviewed by Ojan Vafai.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):
- css/CSSValueKeywords.in:
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
LayoutTests:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/script-tests/css-properties.js:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 11:54 AM Changeset in webkit [108101] by
-
- 14 edits in trunk/Source
Refactor DragData class to use PlatformStrategies in the Mac implementation.
https://bugs.webkit.org/show_bug.cgi?id=78768
Reviewed by Darin Adler.
Source/WebCore:
No new tests. No behavior change.
- WebCore.exp.in: Added new exported method of the PlatformPasteboard class.
- platform/DragData.h:
(WebCore::DragData::pasteboardName): Added pasteboardName and removed pasteboard.
- platform/PasteboardStrategy.h: Added color() method.
- platform/PlatformPasteboard.h: Ditto.
- platform/mac/ClipboardMac.mm:
(WebCore::Clipboard::create): Changed to use pasteboardName() method.
- platform/mac/DragDataMac.mm: All the methods below have been changed to use pasteboardName
and the pasteboardStrategy() methods.
(WebCore::DragData::DragData):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsFiles):
(WebCore::DragData::numberOfFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asColor):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::color): Added implementation of the color() method.
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h: Added color() method.
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::color):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added color() method.
(WebKit::WebPlatformStrategies::color):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 11:45 AM Changeset in webkit [108100] by
-
- 3 edits in trunk/Source/WebCore
2012-02-17 Nate Chapin <Nate Chapin>
[Chromium mac] Cursors and background images disappear.
https://bugs.webkit.org/show_bug.cgi?id=78834
The issue occurs because a CachedImage sees that it has no clients
and decide it is safe to purge its m_data buffer. However,
StyleCachedImage is holding a CachedResourceHandle to the
CachedImage, and it can still add a client later. If it does so,
the CachedImage says everything is loaded but has no data.
Reviewed by Adam Barth.
No new tests, since the known repros have resisted reduction.
Tested manually with chrome.angrybirds.com, redfin.com and a
couple of other sites.
- rendering/style/StyleCachedImage.cpp:
- rendering/style/StyleCachedImage.h: Ensure the underlying
CachedImage has a client for the lifetime of the
StyleCachedImage and doesn't purge its buffer. Call
addClient(this) in the constructor and removeClient(this) in
the destructor, then ignore all cache callbacks.
- 11:08 AM Changeset in webkit [108099] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] pack Gamepad shared memory structure
https://bugs.webkit.org/show_bug.cgi?id=78022
Patch by Scott Graham <scottmg@chromium.org> on 2012-02-17
Reviewed by Darin Fisher.
Add #pragma pack around definition of shared memory structures to
avoid differences across compilers and platforms. Add COMPILE_ASSERT
to verify expected size.
- public/platform/WebGamepad.h:
(WebKit):
- public/platform/WebGamepads.h:
(WebKit):
- 11:02 AM Changeset in webkit [108098] by
-
- 5 edits2 adds in trunk
Table cell's anonymous wrappers are left in the tree, impacting our layout
https://bugs.webkit.org/show_bug.cgi?id=7180
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/table/table-switch-cell-position-bad-layout-expected.html
fast/table/table-switch-cell-position-bad-layout.html
This patch implements cell's anonymous wrapper removal at detach time.
Trimming the render tree when we remove objects from it would be more complex
to generalize as several objects override the behavior to do their own clean-ups.
This would also open more potential for programming errors.
This change is limited to table cells' as a simple step towards fixing bug 52123
and more generally eliminate some anonymous wrappers from the tree at detach time.
- dom/Node.cpp:
(WebCore::Node::detach):
Patched detach to call destroyAndCleanupAnonymousWrappers. The Document does not need
to clean up any anonymous wrappers on detach.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
Added this method to wrap destroy() call and trim the render tree. To avoid slowing down
detach in some cases, added a fast path.
- rendering/RenderObject.h: Added destroyAndCleanupAnonymousWrappers.
LayoutTests:
- fast/table/table-switch-cell-position-bad-layout-expected.html: Added.
- fast/table/table-switch-cell-position-bad-layout.html: Added.
- 11:00 AM Changeset in webkit [108097] by
-
- 3 edits2 adds in trunk
ASSERT (and crash) with dynamically moved <font-face>
https://bugs.webkit.org/show_bug.cgi?id=64839
Reviewed by Antti Koivisto.
Source/WebCore:
Reset the style declaration when rmeoving the font-face element from the document.
Test: svg/custom/font-face-move.svg
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::removedFromDocument):
LayoutTests:
- svg/custom/font-face-move-expected.txt: Added.
- svg/custom/font-face-move.svg: Added.
- 10:55 AM Changeset in webkit [108096] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebCore
Merged r107966.
- 10:51 AM Changeset in webkit [108095] by
-
- 6 edits in trunk/Source
Fix some warnings encountered during the GTK+ build
https://bugs.webkit.org/show_bug.cgi?id=78911
Reviewed by Xan Lopez.
Source/WebCore:
No new tests. These are just fixes for warnings.
- page/GestureTapHighlighter.cpp: Avoid using potentially signed operations on
a size_t type. Use size_t for iterating over members of a vector.
- platform/graphics/texmap/TextureMapperBackingStore.cpp: Use size_t where necessary.
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded): Ditto.
- platform/graphics/texmap/TextureMapperLayer.cpp: Ditto.
(WebCore::TextureMapperLayer::computeTransformsRecursive): Ditto.
(WebCore::TextureMapperLayer::paintSelfAndChildren): Ditto.
(WebCore::TextureMapperLayer::intermediateSurfaceRect): Ditto.
Source/WebKit2:
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(attachLoaderClientToView): Initialize a new member of the loader client struct.
- 10:47 AM Changeset in webkit [108094] by
-
- 5 edits1 add in trunk
perf-o-matic needs model unit tests
https://bugs.webkit.org/show_bug.cgi?id=78885
Reviewed by Adam Barth.
Added unit tests for models.py.
Also renamed modelFromNumericId to model_from_numeric_id and moved set_persitent_cache and get_persistent_cache
from controller to PersistentCache.set_cache and PersistentCahce.set_cache respectively.
- Websites/webkit-perf.appspot.com/controller.py:
(cache_manifest):
(CachedManifestHandler.get):
(cache_dashboard):
(CachedDashboardHandler.get):
(cache_runs):
(CachedRunsHandler.get):
- Websites/webkit-perf.appspot.com/create_handler.py:
(CreateHandler._create_builder):
(CreateHandler._create_builder.execute):
- Websites/webkit-perf.appspot.com/models.py:
(create_in_transaction_with_numeric_id_holder):
(model_from_numeric_id):
(Builder):
(Builder.create):
(Builder.update_password):
(Builder._hashed_password):
(TestResult.key_name):
(ReportLog.get_value):
(ReportLog._integer_in_payload):
(ReportLog):
(ReportLog.timestamp):
(PersistentCache):
(PersistentCache.set_cache):
(PersistentCache.set_cache.execute):
(PersistentCache.get_cache):
- Websites/webkit-perf.appspot.com/models_unittest.py: Added.
(HelperTests):
(HelperTests.setUp):
(HelperTests.tearDown):
(HelperTests._assert_there_is_exactly_one_id_holder_and_matches):
(HelperTests.test_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_delete_model_with_numeric_id_holder):
(HelperTests.test_delete_model_with_numeric_id_holder.execute):
(HelperTests.test_model_from_numeric_id):
(HelperTests.test_model_from_numeric_id.execute):
(BuilderTests):
(BuilderTests.setUp):
(BuilderTests.tearDown):
(BuilderTests.test_create):
(BuilderTests.test_update_password):
(BuilderTests.test_hashed_password):
(BuilderTests.test_authenticate):
(ReportLog):
(ReportLog.setUp):
(ReportLog.tearDown):
(ReportLog._create_log_with_payload):
(ReportLog.test_parsed_payload):
(ReportLog.test_get_value):
(ReportLog.test_results):
(ReportLog.test_builder):
(ReportLog.test_build_number):
(ReportLog.test_webkit_revision):
(ReportLog.chromium_revision):
(PersistentCacheTests):
(PersistentCacheTests.setUp):
(PersistentCacheTests.tearDown):
(PersistentCacheTests._assert_persistent_cache):
(PersistentCacheTests.test_set):
(PersistentCacheTests.test_get):
- Websites/webkit-perf.appspot.com/runs_handler.py:
(RunsHandler.post):
- 10:27 AM Changeset in webkit [108093] by
-
- 13 edits in trunk/Source
[chromium] Refactor video drawing to be more data driven
https://bugs.webkit.org/show_bug.cgi?id=76720
Patch by Tim Dresser <tdresser@chromium.org> on 2012-02-17
Reviewed by James Robinson.
Source/WebCore:
CCVideoLayerImpl no longer handles drawing itself, but produces a list of CCVideoDrawQuads.
These quads are then drawn by LayerRendererChromium.
CCLayerImpl::willDraw(LayerRendererChromium*) is called directly before appendQuads.
CCLayerImpl::didDraw() is called directly after all drawing has been completed.
CCLayerImpl::draw has been removed.
willDraw and didDraw are used to handle interaction with the VideoFrameProvider
in CCVideoLayerImpl. willDraw gets a frame from the VideoFrameProvider, and
didDraw returns it.
A unit test has been added: CCLayerTreeHostImplTest.didDrawCalledOnAllLayers.
This test ensures that CCLayerImpl::didDraw() is called on all layers,
including layers on different render surfaces.
As this was a refactor, no other tests were added.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawYUV):
(WebCore):
(WebCore::LayerRendererChromium::drawSingleTextureVideoQuad):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::drawNativeTexture):
(WebCore::LayerRendererChromium::copyFrameToTextures):
(WebCore::LayerRendererChromium::copyPlaneToTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::didDraw):
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
- platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::textures):
(WebCore::CCVideoDrawQuad::frame):
(WebCore::CCVideoDrawQuad::format):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::providerMutex):
(WebCore::CCVideoLayerImpl::provider):
(Texture):
Source/WebKit/chromium:
CCLayerTreeHostImplTest.didDrawCalledOnAllLayers ensures that
CCLayerImpl::didDraw() is called on all layers, including layers
on different render surfaces.
- tests/CCLayerTreeHostImplTest.cpp:
(DidDrawCheckLayer):
(WebKit::DidDrawCheckLayer::create):
(WebKit::DidDrawCheckLayer::didDraw):
(WebKit::DidDrawCheckLayer::didDrawCalled):
(WebKit::DidDrawCheckLayer::DidDrawCheckLayer):
(WebKit):
(WebKit::TEST_F):
- 10:19 AM Changeset in webkit [108092] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Allow printing scaled pages in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78823
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialogUnix): Enable scale option in print
dialog.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
manual scale to 1.
(WebKit::WebPrintOperationGtk::rotatePageIfNeeded): Renamed and
moved the needs rotate check here as an early return.
(WebKit::WebPrintOperationGtk::prepareContextToDraw): Scale the
page according to the manual scale factor.
(WebKit::WebPrintOperationGtk::renderPage): Move rotatePage to
prepareContextToDraw.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
- 10:17 AM Changeset in webkit [108091] by
-
- 11 edits in branches/chromium/1025/Source
Merge 107170 - DOM mutations should not be delivered on worker threads
https://bugs.webkit.org/show_bug.cgi?id=77898
Reviewed by Dmitry Titov.
Source/WebCore:
In V8RecursionScope, only call WebKitMutationObserver::deliverAllMutations
if in a Document context.
This is accomplished through a change to V8Proxy::instrumentedCallFunction
(which now takes a Frame* instead of a Page*), requiring an update to all
callers of that function (accounting for the majority of files changed
in this patch).
Added ASSERT(isMainThread()) in a deliverAllMutations to confirm that
it's no longer called on worker threads, and in enqueueMutationRecord,
where the same global store of active observers is accessed.
See also http://crbug.com/112586, where the problem was initially
reported.
- bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptCallback::call):
- bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::instrumentedCallFunction):
- bindings/v8/V8Proxy.h:
(WebCore):
(V8Proxy):
- bindings/v8/V8RecursionScope.cpp:
(WebCore::V8RecursionScope::didLeaveScriptContext):
- bindings/v8/V8RecursionScope.h:
(WebCore):
(WebCore::V8RecursionScope::V8RecursionScope):
(V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):
- bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
- bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):
- bindings/v8/custom/V8CustomXPathNSResolver.cpp:
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
- dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::enqueueMutationRecord):
(WebCore::WebKitMutationObserver::deliverAllMutations):
Source/WebKit/chromium:
- src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
TBR=adamk@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9355009
- 10:09 AM Changeset in webkit [108090] by
-
- 2 edits in trunk/Tools
[Chromium] Include TestShellLinux.cpp in the build for Android
https://bugs.webkit.org/show_bug.cgi?id=78865
Reviewed by Eric Seidel.
Android will be re-using the TestShellLinux.cpp file. I already
added this r104033, but it seems to have gotten lost in the
recent refactorings.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 10:08 AM Changeset in webkit [108089] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Allow printing multiple copies in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78805
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialogUnix): Enable multiple copies and
collate options in print dialog.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Initialize number of
collated and uncolated copies done and total.
(WebKit::PrintPagesData::collatedCopiesLeft): Helper function that
returns the number of collated copies left to do.
(WebKit::PrintPagesData::uncollatedCopiesLeft): Helper function
that returns the number of uncollated copies left to do.
(WebKit::PrintPagesData::copiesLeft): Helper function
that returns the number of collated or uncollated copies left to
do.
(WebKit::PrintPagesData::incrementPageSequence): Do not finish the
print if there are uncollated copies left, and do not increment
sheet number if there are collated copies left.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
m_manualCopies to 1 and m_manualCollateCopies to false.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
- 10:05 AM Changeset in webkit [108088] by
-
- 6 edits2 adds1 delete in trunk/LayoutTests
Unreviewed Chromium rebaseline after r107971.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug27038-1-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.txt: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.txt: Added.
- platform/chromium-win-vista/tables/mozilla/bugs: Removed.
- platform/chromium/test_expectations.txt:
- 10:00 AM Changeset in webkit [108087] by
-
- 6 edits1 copy2 moves2 adds4 deletes in trunk/LayoutTests
[chromium] Unreviewed, update chromium pixel baselines for r108079
- fast/borders/border-mixed-alpha-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-mixed-alpha-expected.txt.
- fast/borders/only-one-border-with-width-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/only-one-border-with-width-expected.txt.
- platform/chromium-mac-snowleopard/fast/borders/border-mixed-alpha-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/only-one-border-with-width-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/color-leakage-expected.png: Added.
- platform/chromium-win/fast/borders/border-mixed-alpha-expected.png:
- platform/chromium-win/fast/borders/mixed-border-styles-expected.png:
- platform/chromium-win/fast/borders/only-one-border-with-width-expected.png: Copied from LayoutTests/platform/chromium-win/fast/css/color-leakage-expected.png.
- platform/chromium-win/fast/css/color-leakage-expected.png:
- platform/mac/fast/borders/border-mixed-alpha-expected.txt: Removed.
- platform/mac/fast/borders/only-one-border-with-width-expected.txt: Removed.
- platform/qt/fast/borders/border-mixed-alpha-expected.txt: Removed.
- platform/qt/fast/borders/only-one-border-with-width-expected.txt: Removed.
- 9:43 AM Changeset in webkit [108086] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Allow printing pages in reverse order in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78799
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialogUnix): Enable printing in reverse
order option in print dialog.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Initialize sheetNumber
and lastPagePosition depending on whether printing is in reverse
order or not.
(WebKit::PrintPagesData::incrementPageSequence): Use a negative
increment step when printing in reverse order. Fix page
incrementing when printing only odd/even pages broken in previous
commit due to merge conflicts.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
reverse printing to false.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
- 9:25 AM Changeset in webkit [108085] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Allow printing only odd/even pages in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78793
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialogUnix): Enable print odd/even pages
option in print dialog.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Add lastPagePosition and
initialize it depending on the page set.
(WebKit::PrintPagesData::incrementPageSequence): Use 2 step
increment when printing only odd/even pages.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
m_manualPageSet to GTK_PAGE_SET_ALL.
- 9:10 AM WebKit Team edited by
- (diff)
- 9:06 AM Changeset in webkit [108084] by
-
- 8 edits2 adds in trunk
Crash at WebCore::SVGUseElement::expandSymbolElementsInShadowTree
https://bugs.webkit.org/show_bug.cgi?id=77639
Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-17
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Fix a SVG crash in Release builds, although it still crashes in Debug builds.
The crash occurred when an SVG use element attempted to reference a style element while the file
contained an error causing the error banner to display. The fix is to prevent SVGUseElement
from recalculating style during tree building and return immediately when style is recalculated and
the tree is building.
Test: svg/custom/use-referencing-style-crash.svg
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::willRecalcStyle): Return false if the tree is being built.
(WebCore::SVGUseElement::didRecalcStyle): Check and return if the tree
is being built and we are not yet ready for style update.
LayoutTests:
Fix a SVG crash in Release builds, although it still crashes in Debug builds.
This test is to verify no crash in Release builds, while expectations/Skipped
are added for Debug builds. Bug 77764 tracks the Debug fix.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- svg/custom/use-referencing-style-crash-expected.txt: Added.
- svg/custom/use-referencing-style-crash.svg: Added.
- 8:55 AM Changeset in webkit [108083] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed, rolling out r108077.
http://trac.webkit.org/changeset/108077
https://bugs.webkit.org/show_bug.cgi?id=78390
it broke compilation.
- inspector/CodeGeneratorInspector.py:
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapCallFrames):
- inspector/InjectedScript.h:
(InjectedScript):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- 8:50 AM Changeset in webkit [108082] by
-
- 4 edits2 adds in trunk
chrome.dll!WebCore::SVGTRefElement::updateReferencedText ReadAV@NULL (e85cb8e140071fa7790cad215b0109dc)
https://bugs.webkit.org/show_bug.cgi?id=74858
Patch by Florin Malita <fmalita@google.com> on 2012-02-17
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Tests: svg/custom/tref-remove-target-crash-expected.svg
svg/custom/tref-remove-target-crash.svg
Add a DOMNodeRemovedFromDocumentEvent listener to detect when the target element is removed. Upon removal,
cleanup all listeners and re-activate the pending resource to attach if the referenced ID is added
at a later time programmatically. Also move the DOMSubtreeModifiedEvent listener from the parent to
the target element to simplify the implementation and reduce the scope.
- svg/SVGTRefElement.cpp:
(WebCore::TargetListener::create):
(WebCore::TargetListener::cast):
(WebCore::TargetListener::clear):
(WebCore::TargetListener::TargetListener):
(WebCore::TargetListener::operator==):
(WebCore::TargetListener::handleEvent):
(WebCore::SVGTRefElement::detachTarget):
(WebCore::SVGTRefElement::buildPendingResource):
- svg/SVGTRefElement.h:
LayoutTests:
- svg/custom/tref-remove-target-crash-expected.svg: Added.
- svg/custom/tref-remove-target-crash.svg: Added.
- 8:48 AM Changeset in webkit [108081] by
-
- 2 edits in trunk/Source/WebCore
Fix the build after r108077.
- inspector/CodeGeneratorInspector.py:
(RawTypes.Any.generate_validate_method):
- 8:42 AM Changeset in webkit [108080] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Allow printing multiple pages per sheet in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78715
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialogUnix): Enable multiple pages per
sheet options in print dialog.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Initialize sheetNumber
and numberOfSheets. Move pagePosition to WebPrintOperationGtk.
(WebKit::PrintPagesData::incrementPageSequence): Increment current
sheet and page position.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk):
(WebKit::WebPrintOperationGtk::currentPageIsFirstPageOfSheet):
Helper function to check whether current pages is the first one of
the current sheet.
(WebKit::WebPrintOperationGtk::currentPageIsLastPageOfSheet):
Helper function to check whether current pages is the last one of
the current sheet.
(WebKit::WebPrintOperationGtk::getRowsAndColumnsOfPagesPerSheet):
Returns the number of rows and columns of pages per sheet.
(WebKit::WebPrintOperationGtk::getPositionOfPageInSheet): Returns
the row and column number of the current page in the current sheet.
(WebKit::WebPrintOperationGtk::prepareContextToDraw): Translate,
scale and rotate accordingly to render every page in the right
place of the sheet.
(WebKit::WebPrintOperationGtk::renderPage): Call
prepareContextToDraw() before drawing the page.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
(WebKit::WebPrintOperationGtk::setNumberOfPagesToPrint):
(WebKit::WebPrintOperationGtk::pagePosition):
(WebKit::WebPrintOperationGtk::setPagePosition):
(WebKit::WebPrintOperationGtk::numberUp):
(WebKit::WebPrintOperationGtk::numberUpLayout):
- 8:40 AM Changeset in webkit [108079] by
-
- 2 edits in trunk/Source/WebCore
Avoid using a transparency layer for rgba() border drawing when possible
https://bugs.webkit.org/show_bug.cgi?id=63176
Reviewed by Dan Bernstein.
The non-radiused border drawing code would use a transparency layer
when drawing any one or more borders with alpha colors. However,
we only need to use a transparency layer when there is a corner
join between the borders being rendered with any one color,
so add a utility function includesAdjacentEdges() that can tell us
that, and use it to avoid making extraneous transparency layers.
Optimization only, no new tests.
- rendering/RenderBoxModelObject.cpp:
(WebCore::includesAdjacentEdges):
(WebCore):
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
- 8:39 AM Changeset in webkit [108078] by
-
- 2 edits in trunk/Source/WebCore
2012-02-17 Pavel Feldman <pfeldman@google.com>
Not reviewed: Qt minimal build fix.
- inspector/InjectedScript.h: (WebCore):
- 8:25 AM Changeset in webkit [108077] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Switch Debugger agent to TypeBuilder
https://bugs.webkit.org/show_bug.cgi?id=78390
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-17
Reviewed by Vsevolod Vlasov.
Client code is switched to TypeBuilder.
- inspector/CodeGeneratorInspector.py:
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapCallFrames):
- inspector/InjectedScript.h:
(InjectedScript):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- 8:17 AM Changeset in webkit [108076] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: hide color picker on selected node update.
https://bugs.webkit.org/show_bug.cgi?id=78896
Reviewed by Vsevolod Vlasov.
- inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.prototype.get visible):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- 8:13 AM Changeset in webkit [108075] by
-
- 3 edits4 adds in trunk
Web Inspector: check undo-redo boundaries based on current action index, not history size.
https://bugs.webkit.org/show_bug.cgi?id=78895
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Tests: inspector/elements/perform-undo-undo.html
inspector/styles/perform-undo-perform-of-mergable-action.html
- inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::perform):
LayoutTests:
- inspector/elements/perform-undo-undo-expected.txt: Added.
- inspector/elements/perform-undo-undo.html: Added.
- inspector/styles/perform-undo-perform-of-mergable-action-expected.txt: Added.
- inspector/styles/perform-undo-perform-of-mergable-action.html: Added.
- 8:06 AM Changeset in webkit [108074] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r108071.
http://trac.webkit.org/changeset/108071
https://bugs.webkit.org/show_bug.cgi?id=77155
chromium-mac compilation failed
Source/WebCore:
- platform/graphics/chromium/Extensions3DChromium.h:
Source/WebKit/chromium:
- public/platform/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
- src/Extensions3DChromium.cpp:
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
- src/GraphicsContext3DPrivate.h:
(WebCore):
- tests/FakeWebGraphicsContext3D.h:
- 7:53 AM Changeset in webkit [108073] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, skipping 2 new test failures on GTK.
- platform/gtk/Skipped:
- platform/gtk/test_expectations.txt:
- 7:48 AM Changeset in webkit [108072] by
-
- 2 edits in trunk/LayoutTests
Web Inspecter: Unreviewed. Adjust expectation for script-formatter-console.html
- platform/chromium/test_expectations.txt:
- 7:41 AM Changeset in webkit [108071] by
-
- 8 edits in trunk/Source
[chromium] GL_CHROMIUM_gpu_memory_manager extension
https://bugs.webkit.org/show_bug.cgi?id=77155
Patch by Michal Mocny <mmocny@google.com> on 2012-02-17
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/Extensions3DChromium.h:
(GpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::GpuMemoryAllocationChangedCallbackCHROMIUM::~GpuMemoryAllocationChangedCallbackCHROMIUM):
(Extensions3DChromium):
Source/WebKit/chromium:
- public/platform/WebGraphicsContext3D.h:
(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::~WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
- src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore):
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):
- src/GraphicsContext3DPrivate.h:
(WebCore):
- tests/FakeWebGraphicsContext3D.h:
(WebKit::FakeWebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
(FakeWebGraphicsContext3D):
- 6:42 AM Changeset in webkit [108070] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Unreviewed, adapt to the changes introduced in r107973.
SVN r107973 moved some libsoup feature initialization code to
WebCore, but only changed the GTK+ bits in WebKit.
- ewk/ewk_main.cpp:
(_ewk_init_body): Do not initialize the content sniffer and the
decoder here, the initialization is now done in WebCore.
- 6:32 AM Changeset in webkit [108069] by
-
- 7 edits in trunk/Source/WebKit2
[GTK] Rename WebKitPrintOperation::done signal to ::finished in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=78893
Reviewed by Gustavo Noronha Silva.
And it's not emitted anynmore when the print dialog has been
cancelled. Since it's not possible to know whether the print
dialog was cancelled or not, the enum WebKitPrintOperationResponse
has been added, with Print and Cancel values, and it's used as
return value of webkit_print_operation_run_dialog().
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkit_print_operation_class_init): Rename done as finished.
(webkitPrintOperationRunDialogUnix): Return a
WebKitPrintOperationResponse instead of bool.
(webkitPrintOperationRunDialogWin32): Ditto.
(drawPagesForPrintingCompleted): Emit finished instead of done.
(webkitPrintOperationRunDialogForFrame): Do not emit finished if
the dialog was cancelled and return a WebKitPrintOperationResponse.
(webkit_print_operation_run_dialog): Return
WebKitPrintOperationResponse.
- UIProcess/API/gtk/WebKitPrintOperation.h: Add
WebKitPrintOperationResponse enum.
- UIProcess/API/gtk/WebKitPrintOperationPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPrintFrame): Check whether the dialog has been
cancelled or not and connect to finish when the print operation is
in progress to release the print operation object when printing
finishes.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add
WebKitPrintOperationResponse symbol.
- UIProcess/API/gtk/tests/TestPrinting.cpp:
(testPrintOperationPrintFinished): Use finished instead of done.
(testPrintOperationPrint): Ditto.
- 6:25 AM Changeset in webkit [108068] by
-
- 6 edits in trunk/Source/WebKit2
[GTK] Add webkit_print_operation_print() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76536
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationPrintPagesForFrame): Helper function to call
WebPageProxy::drawPagesForPrinting using the given
GtkPrintSettings and GtkPageSetup.
(webkitPrintOperationRunDialogForFrame): Use
webkitPrintOperationPrintPagesForFrame().
(webkit_print_operation_print): Print directly using current
GtkPrintSettings and GtkPageSetup without showing the print
dialog.
- UIProcess/API/gtk/WebKitPrintOperation.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/tests/GNUmakefile.am:
- UIProcess/API/gtk/tests/TestPrinting.cpp:
(testPrintOperationPrintLoadChanged):
(testPrintOperationPrintDone):
(testPrintOperationPrintPrinter):
(testPrintOperationPrint):
(beforeAll):
(afterAll):
- 6:19 AM Changeset in webkit [108067] by
-
- 3 edits in trunk/Source/WebCore
[CMake, EFL] Unreviewed, fix the build when building with
SHARED_CORE=ON after r107820.
RunLoopEfl.cpp has not been upstreamed yet, and building only
RunLoop.cpp created an .so with some missing, unimplemented
symbols. The BlackBerry port seems to be in the same situation.
The best solution for now is to build RunLoop.cpp only on the
WinCE port.
- CMakeLists.txt: Remove RunLoop.cpp from the list of files to build.
- PlatformWinCE.cmake: Add RunLoop.cpp to the list of files to build.
- 5:40 AM Changeset in webkit [108066] by
-
- 2 edits in trunk/Source/WebKit/efl
Unreviewed, fix the build with ENABLE(DEVICE_ORIENTATION) after
r107518. The EFL EWS bot doesn't enable that flag, so the breakage
was not spotted earlier.
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
- 5:14 AM Changeset in webkit [108065] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: a bit of color picker polish
https://bugs.webkit.org/show_bug.cgi?id=78892
- Fixed computed style swatch
- Removed color: caption
- Rendered value as source code, user-selectable
- Removed scroller gap
Reviewed by Yury Semikhatsky.
- English.lproj/localizedStrings.js:
- inspector/front-end/Popover.js:
(WebInspector.Popover.prototype.setCanShrink):
(WebInspector.Popover.prototype._positionElement):
- inspector/front-end/Spectrum.js:
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype._resetMouseDownElement):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- inspector/front-end/elementsPanel.css:
(.spectrum-container):
(.spectrum-display-value):
(.spectrum-range-container):
- inspector/front-end/popover.css:
(.popover .content.fixed-height):
- 5:14 AM Changeset in webkit [108064] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Chromium DEPS roll
- DEPS: from 122122 to 122498
- 4:45 AM Changeset in webkit [108063] by
-
- 2 edits in trunk/Tools
Unreviewed, disable video build on EFL until it can be
supported by EFL build bot.
- Scripts/build-webkit:
- 4:31 AM Changeset in webkit [108062] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: color picker does not allow changing the color.
https://bugs.webkit.org/show_bug.cgi?id=78886
Reviewed by Vsevolod Vlasov.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._showPopover.showPopover):
- inspector/front-end/Popover.js:
(WebInspector.Popover.prototype.setCanShrink):
(WebInspector.Popover.prototype._positionElement):
- inspector/front-end/Settings.js:
- inspector/front-end/Spectrum.js:
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- 4:28 AM Changeset in webkit [108061] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: new image preview has poorly positioned popover arrow.
https://bugs.webkit.org/show_bug.cgi?id=78884
Reviewed by Vsevolod Vlasov.
- inspector/front-end/Popover.js:
(WebInspector.Popover.prototype._positionElement):
- inspector/front-end/utilities.js:
(Element.prototype.boxInWindow):
- 4:23 AM Changeset in webkit [108060] by
-
- 2 edits in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #34 of N. Restore/move following tests back in BUGCR9950
group with a WIN exception for an IMAGE failure.
WIN : svg/W3C-SVG-1.1/animate-elem-36-t.svg = IMAGE
WIN : svg/W3C-SVG-1.1/animate-elem-39-t.svg = IMAGE
WIN : svg/W3C-SVG-1.1/animate-elem-40-t.svg = IMAGE
- platform/chromium/test_expectations.txt:
- 3:41 AM Changeset in webkit [108059] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: enable "Single click CSS editing" experiment by default.
https://bugs.webkit.org/show_bug.cgi?id=78881
Reviewed by Vsevolod Vlasov.
- inspector/front-end/elementsPanel.css:
(.styles-section .properties .enabled-button):
- 3:40 AM Changeset in webkit [108058] by
-
- 8 edits in trunk
Web Inspector: split innerUpdate into rebuildUpdate and refreshUpdate, make computed styles load lazily.
https://bugs.webkit.org/show_bug.cgi?id=78827
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._validateNode):
(WebInspector.StylesSidebarPane.prototype._styleSheetOrMediaQueryResultChanged):
(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylesSidebarPane.prototype._attributesRemoved):
(WebInspector.StylesSidebarPane.prototype._styleInvalidated):
(WebInspector.StylesSidebarPane.prototype._innerRefreshUpdate):
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._nodeStylesUpdatedForTest):
(WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
(WebInspector.StylesSidebarPane.prototype._showUserAgentStylesSettingChanged):
(WebInspector.ComputedStyleSidebarPane.prototype.expand):
(WebInspector.StylePropertyTreeElement.prototype):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.waitForStyles):
- inspector/styles/undo-add-property.html:
- inspector/styles/undo-change-property.html:
- inspector/styles/updates-during-dom-traversal.html:
- inspector/styles/updates-throttled.html:
- 3:11 AM Changeset in webkit [108057] by
-
- 8 edits2 adds in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #32 of N. Chrome MAC SnowLeopard differences under discussion
in bug 54322, retain IMAGE expectation on SnowLeopard, update pixel results.
- platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
- platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/core/row_span-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/other/cell_widths-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/row_span-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.png: Added.
- platform/chromium-win/tables/mozilla/core/row_span-expected.png:
- platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
- platform/chromium/test_expectations.txt:
- 3:09 AM Changeset in webkit [108056] by
-
- 2 edits in trunk/Tools
[GTK] Implement zoom in/out in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75253
Reviewed by Gustavo Noronha Silva.
- MiniBrowser/gtk/BrowserWindow.c:
(browserWindowCanZoomIn):
(browserWindowCanZoomOut):
(browserWindowUpdateZoomActions):
(webViewZoomLevelChanged):
(zoomInCallback):
(zoomOutCallback):
(browser_window_init):
(browserWindowConstructed):
- 3:09 AM Changeset in webkit [108055] by
-
- 7 edits in trunk/Source
[Qt][WK2] Allow partial updates
https://bugs.webkit.org/show_bug.cgi?id=78824
Source/WebCore:
BitmapTextureGL should not zero-fill the textures when resetting.
This was needed in the previous buffer management system, where texture were not completely
filled by the backing store.
Reviewed by Simon Hausmann.
No new behavior.
- platform/graphics/opengl/TextureMapperGL.cpp:
(BitmapTextureGL):
(WebCore::texSubImage2DResourceSafe):
(WebCore):
(WebCore::BitmapTextureGL::reset):
Source/WebKit2:
Instead of using UpdateInfo to fill the entire tile's texture, we use it as a patch that
contains only the dirty rectangle of the current paint. This requires a lot less memory
for small updates, for example when typing a text in an input field.
This shows a significant reduction in overhead when testing on Mac with Instruments.
Reviewed by Simon Hausmann.
- UIProcess/qt/LayerBackingStore.cpp:
(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit):
(WebKit::LayerBackingStore::updateTile):
- UIProcess/qt/LayerBackingStore.h:
(LayerBackingStoreTile):
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::updateTileForLayer):
- WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
- 3:07 AM Changeset in webkit [108054] by
-
- 2 edits in trunk/Tools
layoutTestController.display() is flaky for SVG tests
https://bugs.webkit.org/show_bug.cgi?id=78021
Reviewed by Adam Roben.
Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
Size the web view before running the test, not when dumping.
All platforms handle this correctly now.
- DumpRenderTree/win/DumpRenderTree.cpp:
(dump):
(sizeWebViewForCurrentTest):
(runTest):
- 2:37 AM Changeset in webkit [108053] by
-
- 2 edits in trunk
Unreviewed. Fix GTK+ build after r108003.
- Source/autotools/symbols.filter: Add missing symbol.
- 2:28 AM SettingUpDevelopmentEnvironmentForN9 edited by
- set environment variables for sysroot before building (diff)
- 2:25 AM WebKitIDL edited by
- (diff)
- 2:22 AM WebKitIDL edited by
- (diff)
- 2:15 AM WebKitIDL edited by
- (diff)
- 1:47 AM Changeset in webkit [108052] by
-
- 8 edits2 adds2 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #33 of N. See also bug 78219.
- platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium/test_expectations.txt:
- 1:25 AM WebKitGTK/WebKit2Roadmap created by
- 1:22 AM Changeset in webkit [108051] by
-
- 7 edits in trunk/Source/WebCore
[Forms] Integrate InputType::dispatchChangeEventInResponseToSetValue into InputType::setValue
https://bugs.webkit.org/show_bug.cgi?id=78873
Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-02-17
Reviewed by Kent Tamura.
This patch moves event dispatch logic to InputType and TextFieldInputType from HTMLInputElement
and merge dispatchChangeEventInResponseToSetValue to setValue.
No new tests. No change in behavior.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue): Move dispatch logic to InputType and TextFieldInput.
- html/InputType.cpp: Remove dispatchChangeEventInResponseToSetValue implementation.
- html/InputType.h: Remove dispatchChangeEventInResponseToSetValue declaration.
(WebCore::InputType::setValue): Move code from dispatchChangeEventInResponseToSetValue.
- html/TextFieldInputType.cpp: Remove dispatchChangeEventInResponseToSetValue implementation.
- html/TextFieldInputType.h: Remove dispatchChangeEventInResponseToSetValue declaration.
(WebCore::TextFieldInputType::setValue): Move code from dispatchChangeEventInResponseToSetValue. Stop dispatching event in InputType::setValue.
- html/HTMLTextFormControlElement.h: Make setTextAsOfLastFormControlChangeEvent to public from protected for accessing from InputType class.
- 1:22 AM WebKitIDL edited by
- (diff)
- 1:09 AM Changeset in webkit [108050] by
-
- 2 edits in trunk/Source/WebCore
2012-02-17 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Mac build fix after r108047.
- WebCore.xcodeproj/project.pbxproj:
- 1:01 AM Changeset in webkit [108049] by
-
- 3 edits in trunk/Source/WebCore
Removing the last presentation attribute should result in a null attributeStyle().
<http://webkit.org/b/78812>
Reviewed by Antti Koivisto.
If the collectStyleForAttribute() pass in updateAttributeStyle() doesn't encounter any
respected presentation attributes, set a null attributeStyle() instead of an empty one.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- dom/StyledElement.cpp:
(WebCore::StyledElement::updateAttributeStyle):
- 12:44 AM Changeset in webkit [108048] by
-
- 4 edits2 adds in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #31 of N. Any reasons for the MAC exception have been lost
in time, like tears in rain. Remove the MAC exception, update all pixel results.
- platform/chromium-linux/tables/mozilla/bugs/bug82946-2-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
- platform/chromium-win/tables/mozilla/bugs/bug82946-2-expected.png:
- platform/chromium/test_expectations.txt:
- 12:33 AM Changeset in webkit [108047] by
-
- 19 edits2 adds in trunk/Source/WebCore
Web Inspector: use static counters for estimation of allocated Documents, Nodes and JS EventListeners
https://bugs.webkit.org/show_bug.cgi?id=78825
Introduced static counters of allocated Documents, Nodes and JS EventListeners.
Their values are displayed on the Timeline panel.
Reviewed by Pavel Feldman.
- CMakeLists.txt:
- English.lproj/localizedStrings.js:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::~V8AbstractEventListener):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
- dom/Document.h:
(WebCore::Node::Node):
- dom/Node.cpp:
(WebCore::Node::~Node):
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorCounters.cpp: Added.
(WebCore):
(WebCore::InspectorCounters::counterValue):
- inspector/InspectorCounters.h: Added.
(WebCore):
(InspectorCounters):
(WebCore::InspectorCounters::incrementCounter):
(WebCore::InspectorCounters::decrementCounter):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::didDispatchEvent):
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didFireTimer):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
- inspector/InspectorTimelineAgent.h:
(WebCore):
(WebCore::InspectorTimelineAgent::create):
(InspectorTimelineAgent):
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
(WebInspector.MemoryStatistics.prototype._draw.getDocumentCount):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
- 12:08 AM Changeset in webkit [108046] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r108034.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 12:06 AM Changeset in webkit [108045] by
-
- 8 edits2 adds in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #30 of N. Chrome MAC SnowLeopard differences under discussion
in bug 54322, retain IMAGE expectation on SnowLeopard, update pixel results.
- platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-linux/tables/mozilla/core/misc-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png: Added.
- platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-win/tables/mozilla/core/misc-expected.png:
- platform/chromium/test_expectations.txt:
Feb 16, 2012:
- 11:52 PM Changeset in webkit [108044] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Rollout r107952 removed fast/events/related-target-focusevent.html so
lint complains about it in test_expectations.txt, remove it's expectation line.
- platform/chromium/test_expectations.txt:
- 11:47 PM Changeset in webkit [108043] by
-
- 2 edits in trunk/Source/WebCore
Correct a misleading comment regarding string delimiters in CSS parsing.
https://bugs.webkit.org/show_bug.cgi?id=78521
Reviewed by Zoltan Herczeg.
- css/CSSParser.cpp:
(WebCore::CSSParser::lex):
- 11:44 PM Changeset in webkit [108042] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. r107980 rolled-out, fast/js/stack-trace.html was removed so lint
complains about it in test_expectations.txt, remove it's expectation line.
- platform/chromium/test_expectations.txt:
- 11:30 PM Changeset in webkit [108041] by
-
- 2 edits in trunk/Source/WebCore
Fix the TextureMapper build for GTK+.
No new tests. This is just a build fix.
- GNUmakefile.list.am: Add missing files to the build and change spaces to tabs.
- 11:26 PM Changeset in webkit [108040] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Make sure print operation object is alive until printing finishes in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=78829
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted): Adopt the WebKitPrintOperation
reference so that it's released when the callback finishes.
(webkitPrintOperationRunDialogForFrame): Pass a reference of
WebKitPrintOperation to the printing callback.
- 11:23 PM Changeset in webkit [108039] by
-
- 2 edits in trunk/Tools
[GTK] Make install is broken when building without --enable-gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=78828
Reviewed by Martin Robinson.
- gtk/generate-gtkdoc:
(rebase_installed_docs): Check documentation has been generated
before trying to rebase it.
- 11:20 PM Changeset in webkit [108038] by
-
- 2 edits in trunk/Source/WebCore
Add ENABLE(STYLE_SCOPED) around HTMLStyleElement::m_isRegisteredWithScopingNode
The instance variable HTMLStyleElement::m_isRegisteredWithScopingNode is only
referenced from within ENABLE(STYLE_SCOPED)-guarded code. We should add this
guard around its declaration.
- html/HTMLStyleElement.h:
(HTMLStyleElement):
- 11:10 PM Changeset in webkit [108037] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add JSC code profiling support on Linux x86
https://bugs.webkit.org/show_bug.cgi?id=78871
Reviewed by Gavin Barraclough.
We don't unwind the stack for now as we cannot guarantee all the
libraries are compiled without -fomit-frame-pointer.
- tools/CodeProfile.cpp:
(JSC::CodeProfile::sample):
- tools/CodeProfiling.cpp:
(JSC):
(JSC::profilingTimer):
(JSC::CodeProfiling::begin):
(JSC::CodeProfiling::end):
- 10:44 PM WebKitIDL edited by
- (diff)
- 10:43 PM Changeset in webkit [108036] by
-
- 13 edits3 deletes in trunk
Unreviewed. Rolling out r107980, because it broke 32 bit platforms.
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
- interpreter/Interpreter.h:
(JSC):
(Interpreter):
- jsc.cpp:
(GlobalObject::finishCreation):
- parser/Nodes.h:
(JSC::FunctionBodyNode::setInferredName):
- parser/Parser.h:
(JSC::::parse):
- runtime/CommonIdentifiers.h:
- runtime/Error.cpp:
(JSC::addErrorInfo):
- runtime/Error.h:
(JSC):
LayoutTests:
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js: Removed.
- fast/js/stack-trace-expected.txt: Removed.
- fast/js/stack-trace.html: Removed.
- 10:42 PM Changeset in webkit [108035] by
-
- 10 edits2 adds in trunk
[v8] v8 doesn't assume to do 'new WebKitShadowRoot(host)'
https://bugs.webkit.org/show_bug.cgi?id=78875
Reviewed by Kentaro Hara.
Source/WebCore:
Since v8 does not assume that we do 'new WebkitShadowRoot(host)', a wrapper object for new WebKitShadowRoot(host)
was saved in DOMObject storage instead of DOMNode storage.
CodeGenerator should handle with DOMNode correctly to solve the problem.
Test: fast/dom/shadow/shadow-root-new.html
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback):
LayoutTests:
Skip non-chromium ports since SHADOW_DOM flag is not enabled in their ports.
- fast/dom/shadow/shadow-root-new.html: Added.
- fast/dom/shadow/shadow-root-new-expected.txt: Added.
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 10:35 PM Changeset in webkit [108034] by
-
- 22 edits5 deletes in trunk
Source/WebCore: Unreviewed rollout r107952 because it broke shadow-boundary-events.html and related-target-focusevent.html on mac.
see http://webkit.org/b/78832
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/EventDispatchMediator.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
- dom/EventDispatchMediator.h:
(FocusEventDispatchMediator):
(WebCore):
(BlurEventDispatchMediator):
- dom/EventFactory.in:
- dom/FocusEvent.cpp: Removed.
- dom/FocusEvent.h: Removed.
- dom/FocusEvent.idl: Removed.
- dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
- dom/UIEvent.cpp:
(WebCore::FocusInEventDispatchMediator::create):
(WebCore):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
- dom/UIEvent.h:
(FocusInEventDispatchMediator):
(WebCore):
(FocusOutEventDispatchMediator):
- page/DOMWindow.idl:
LayoutTests: Unreviewed rollout r107952 because it broke shadow-boundary-events.html and related-target-focusevent.html on mac.
see http://webkit.org/b/78832
- fast/dom/shadow/shadow-boundary-events-expected.txt:
- fast/dom/shadow/shadow-boundary-events.html:
- fast/events/event-creation-expected.txt:
- fast/events/event-creation.html:
- fast/events/related-target-focusevent-expected.txt: Removed.
- fast/events/related-target-focusevent.html: Removed.
- 10:21 PM Changeset in webkit [108033] by
-
- 4 edits2 adds in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #29 of N. Chrome MAC differences under discussion in bug
BUGCR23473, retain IMAGE expectation on MAC therefore, update the pixel results.
- platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
- platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png: Added.
- platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
- platform/chromium/test_expectations.txt:
- 10:20 PM Changeset in webkit [108032] by
-
- 2 edits in trunk/Source/WebCore
Another fix for viewport tests
No new tests.
- dom/ViewportArguments.cpp:
(WebCore::numericPrefix): When we don't parse a number, we could either be
trying to parse junk, which returns NaN, or we could get an empty string,
which returns 0, so we need to account for that in the assert.
- 9:58 PM Changeset in webkit [108031] by
-
- 6 edits in trunk/Source
[chromium] Bundle page scale factor and limits in CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=78762
Setting page scale factor and its limits in separate methods
may cause clamping bugs if one of them makes it to the
impl thread before the other. Change the API to bundle them together,
which matches the existing impl-side interface.
Patch by Alexandre Elias <aelias@google.com> on 2012-02-16
Reviewed by James Robinson.
Source/WebCore:
No new tests (API change will disallow this type of bug).
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setPageScaleFactorAndLimits):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::updateLayerTreeViewport):
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::applyScrollAndScale):
- 9:51 PM Changeset in webkit [108030] by
-
- 2 edits1 add in trunk/LayoutTests
Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #26 of N. Color profiles are not supported in chrome win/linux.
Retain the FAIL MISSING expectation, update the failing win/linux pixel result.
- platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 9:49 PM Changeset in webkit [108029] by
-
- 6 edits4 adds in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #28 of N. Chrome MAC differences under discussion in bug
BUGCR23473, retain IMAGE expectation on MAC therefore, update the pixel results.
- platform/chromium-linux/fast/repaint/clipped-relative-expected.png:
- platform/chromium-linux/fast/repaint/selected-replaced-expected.png:
- platform/chromium-mac-leopard/fast/repaint/clipped-relative-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/selected-replaced-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/clipped-relative-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/selected-replaced-expected.png: Added.
- platform/chromium-win/fast/repaint/clipped-relative-expected.png:
- platform/chromium-win/fast/repaint/selected-replaced-expected.png:
- platform/chromium/test_expectations.txt:
- 9:34 PM Changeset in webkit [108028] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests results.
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::finishCreation):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::finishCreation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::finishCreation):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
- 9:33 PM Changeset in webkit [108027] by
-
- 4 edits1 add in trunk/Source/WebKit/chromium
[Chromium] Add method to WebViewImpl to extract zoom/scroll params for gesture events on touch devices
https://bugs.webkit.org/show_bug.cgi?id=72909
Patch by Varun Jain <varunjain@google.com> on 2012-02-16
Reviewed by James Robinson.
- src/WebViewImpl.cpp:
(std):
(WebKit):
(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::widenRectWithinPageBounds):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
(WebKit):
(WebKit::TEST_F):
- tests/data/get_scale_for_auto_zoom_into_div_test.html: Added.
- 9:26 PM Changeset in webkit [108026] by
-
- 3 edits1 move1 add8 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #25 of N. Chrome MAC rendering was previously incorrect, and
still is incorrect/weird: update test_expectations.txt with IMAGE failure.
- platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
- platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
- platform/chromium-mac-leopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png:
- platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
- platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
- platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
- platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
- platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
- platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
- platform/chromium/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt.
- platform/chromium/test_expectations.txt:
- 9:02 PM Changeset in webkit [108025] by
-
- 6 edits in trunk/Source
[chromium] LayerChromium::setNeedsDisplay does not apply contents scale correctly
https://bugs.webkit.org/show_bug.cgi?id=77464
Source/WebCore:
Use bounds() instead of contentBounds() to calculate the region to mark
as needing painting in LayerChromium::setNeedsDisplay(). contentBounds()
includes contents scale, while bounds() does not.
Since this change also means that TiledLayerChromium::setNeedsDisplayRect() is
given an unscaled rectangle, modify that function to scale the rectangle before
using it to invalidate the underlying tiles.
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-02-16
Reviewed by James Robinson.
Tests: New tests added to LayerChromium and TiledLayerChromium unit tests.
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setNeedsDisplay):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setNeedsDisplayRect):
Source/WebKit/chromium:
Added a new unit test for TiledLayerChromium to verify its invalidation behavior when
the contents scale changes. Also enhance and existing unit test for LayerChromium to
verify the paint rectangle dimensions instead just checking that it is not empty.
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-02-16
Reviewed by James Robinson.
- tests/LayerChromiumTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerChromium::setNeedsDisplayRect):
(FakeTiledLayerChromium):
(WTF::FakeTiledLayerChromium::lastNeedsDisplayRect):
(WTF::TEST):
(WTF):
- 8:50 PM Changeset in webkit [108024] by
-
- 6 edits in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #27 of N.
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
- platform/chromium/test_expectations.txt:
- 8:46 PM Changeset in webkit [108023] by
-
- 3 edits in trunk/Source/WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=78065
[Chromium] Should eliminate WebTextCheckingResult legacy APIs
Reviewed by Kent Tamura.
Removed unused legacy members.
- public/WebTextCheckingResult.h:
(WebKit::WebTextCheckingResult::WebTextCheckingResult):
(WebTextCheckingResult):
- src/AssertMatchingEnums.cpp:
- 8:36 PM Changeset in webkit [108022] by
-
- 7 edits in trunk/Source/WebCore
Lazy init for DefaultAudioDestinationNode and OfflineAudioDestinationNode
https://bugs.webkit.org/show_bug.cgi?id=76509
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-16
Reviewed by Eric Seidel.
No new tests required.
- webaudio/AudioDestinationNode.h:
- webaudio/AudioNode.h:
(WebCore::AudioNode::sampleRate):
- webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
- webaudio/DefaultAudioDestinationNode.h:
- webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
- webaudio/OfflineAudioDestinationNode.h:
(WebCore::OfflineAudioDestinationNode::sampleRate):
- 8:13 PM Changeset in webkit [108021] by
-
- 3 edits in trunk/Source/WebCore
[Refactoring] Remove location from NodeRenderingContext.
https://bugs.webkit.org/show_bug.cgi?id=78796
Reviewed by Hajime Morita.
This is a simple refactoring to remove m_location from NodeRenderingContext.
TreeLocation is merged into AttachPhase like the following.
LocationUndertermined -> Calculating
LocationNotInTree -> AttachingNotInTree
LocationLightChild -> AttachingStraight / AttachingNotDistributed / AttachingDistributed
LocationShadowChild -> AttachingStraight / AttachingShadowChild / AttachingFallback
We have renamed the enum items of AttachPhase, because not only <content> but also
<shadow> will use the phases. Basically these words are taken from Shadow DOM spec.
'Calculating' means NodeRenderingContext is used not for attaching but for calculating RenderObject.
No new tests, no change in behavior.
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
- dom/NodeRenderingContext.h:
(NodeRenderingContext):
(WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle):
- 8:10 PM Changeset in webkit [108020] by
-
- 18 edits in trunk/Source/JavaScriptCore
ENABLE_INTERPRETER should be ENABLE_CLASSIC_INTERPRETER
https://bugs.webkit.org/show_bug.cgi?id=78791
Rubber stamped by Oliver Hunt.
Just a renaming, nothing more. Also renamed COMPUTED_GOTO_INTERPRETER to
COMPUTED_GOTO_CLASSIC_INTERPRETER.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecode/Instruction.h:
(JSC::Instruction::Instruction):
- bytecode/Opcode.h:
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
- interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
- interpreter/AbstractPC.h:
(AbstractPC):
- interpreter/CallFrame.h:
(ExecState):
- interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):
- interpreter/Interpreter.h:
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(Interpreter):
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- runtime/Executable.h:
(NativeExecutable):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):
- runtime/JSGlobalData.h:
(JSGlobalData):
- wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
- wtf/Platform.h:
- 7:50 PM Changeset in webkit [108019] by
-
- 2 edits in trunk/Source/WebCore
Run sort-Xcode-project-file.
- WebCore.xcodeproj/project.pbxproj: Sorted.
- 7:46 PM Changeset in webkit [108018] by
-
- 2 edits in trunk/Source/WebCore
Another build fix for viewport tests
No new tests.
- dom/ViewportArguments.cpp:
(WebCore::numericPrefix): We now return NaN instead of 0 when we fail to
parse a number using charactersToFloatIgnoringJunk, so we need to assert that
we have NaN rather than 0.
- 7:32 PM Changeset in webkit [108017] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] pull third_party/gold to fix linux build
https://bugs.webkit.org/show_bug.cgi?id=78842
Reviewed by Tony Chang.
The Chrome build now depends on third_party/gold also being checked out.
- DEPS:
- 7:28 PM Changeset in webkit [108016] by
-
- 4 edits in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #24 of N. Differences in rendered image extents on chrome
LINUX, WIN compared to chrome MAC. Retain that fact in test_expectations.txt.
- platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug101674-expected.txt:
- platform/chromium/test_expectations.txt:
- 7:18 PM Changeset in webkit [108015] by
-
- 10 edits in trunk/Source
Source/WebCore: [chromium] Fix bugs in the implementation of WebDatabase::closeDatabaseImmediately.
https://bugs.webkit.org/show_bug.cgi?id=78841
WebDatabase now delegates this function entirely to DatabaseTracker,
a new closeDatabasesImmediately() has been added for that purpose. That
method posts tasks to the appropiate context thread for each database
instance that should be closed immediately.
The DatabaseTracker getAllOpenDatabases() method has been removed from
the chromium impl because it's unsafe, refs cannot be safely taken on
AbstractDatabase instances in the tracker's collection of open databases.
Add a message to the console log when a database is forcibly closed.
Transactions initiated on a database instance that has been forcibly
closed complete with a transaction error callback.
This is part of resolving http://crbug.com/98939
Reviewed by David Levin.
No new layout tests, there is no common code way to closeImmediately.
We have coverage for this in py automation tests.
- platform/sql/SQLiteDatabase.cpp:
The closeImmediately code path can result in the underlying sqlite3 handle being
closed earlier than usual and trip some assertions. Updated the assertions to no
longer trigger in this early close case.
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::setMaximumSize):
- platform/sql/SQLiteDatabase.h:
(WebCore::SQLiteDatabase::sqlite3Handle):
- storage/Database.cpp:
(WebCore::Database::closeImmediately): Modified to only be called on the context thread and to log a console message.
(WebCore::Database::changeVersion): Use the private runTransaction helper method.
(WebCore::Database::transaction): Pass a new param required by the runTransaction helper.
(WebCore::Database::readTransaction): Ditto.
(WebCore::callTransactionErrorCallback): Used to defer invocation of the error callback.
(WebCore::Database::runTransaction): Modified to detect when the database has been closed, and
to invoke the error callback in that case. This also avoids creating a reference cycle between
a newly created transaction and the database that previously existed due to a transction being
added and never removed from the Q while in this state.
- storage/Database.h:
- storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::closeImmediately): Modified to only be called on the context thread and to log a console message.
- storage/DatabaseTracker.h:
- storage/chromium/DatabaseTrackerChromium.cpp:
Posts tasks to the appropiate context thread for execution without bumping AbstractDatabase refcounts.
(DatabaseTracker::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::create):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::performTask):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::closeDatabasesImmediately):
(WebCore::DatabaseTracker::closeOneDatabaseImmediately):
Source/WebKit/chromium: Fix bugs in the implementation of WebDatabase::closeDatabaseImmediately.
https://bugs.webkit.org/show_bug.cgi?id=78841
WebDatabase now delegates this function entirely to DatabaseTracker.
This is part of resolving http://crbug.com/98939
Reviewed by David Levin.
- src/WebDatabase.cpp:
(WebKit::WebDatabase::closeDatabaseImmediately):
- 6:41 PM Changeset in webkit [108014] by
-
- 6 edits in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #23 of N.
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
- platform/chromium/test_expectations.txt:
- 6:27 PM Changeset in webkit [108013] by
-
- 14 edits13 adds in trunk
[Chromium] Occlusion tracking with CSS filters
https://bugs.webkit.org/show_bug.cgi?id=77498
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-16
Reviewed by James Robinson.
Source/WebCore:
The new CSS filter support within the compositor changes how
occlusion tracking needs to function. A filter can change the
alpha value of pixels, making an otherwise opaque pixel no
longer so. Secondly, a filter may move color values around
on a surface, which can cause otherwise occluded areas to
become visible and require painting.
New unit tests: CCLayerTreeHostTest.cpp
Tests: compositing/culling/filter-occlusion-alpha-large.html
compositing/culling/filter-occlusion-alpha.html
compositing/culling/filter-occlusion-blur-large.html
compositing/culling/filter-occlusion-blur.html
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
- platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::setFilters):
(WebCore::RenderSurfaceChromium::filters):
(WebCore::RenderSurfaceChromium::setNearestAncestorThatMovesPixels):
(WebCore::RenderSurfaceChromium::nearestAncestorThatMovesPixels):
(RenderSurfaceChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::enterTargetRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::CCRenderSurface):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::setNearestAncestorThatMovesPixels):
(WebCore::CCRenderSurface::nearestAncestorThatMovesPixels):
(CCRenderSurface):
- platform/graphics/filters/FilterOperation.h:
(FilterOperation):
(WebCore::FilterOperation::affectsOpacity):
(WebCore::FilterOperation::movesPixels):
(WebCore::ReferenceFilterOperation::affectsOpacity):
(WebCore::ReferenceFilterOperation::movesPixels):
(ReferenceFilterOperation):
(WebCore::BasicComponentTransferFilterOperation::affectsOpacity):
(BasicComponentTransferFilterOperation):
(WebCore::BlurFilterOperation::affectsOpacity):
(WebCore::BlurFilterOperation::movesPixels):
(BlurFilterOperation):
(WebCore::DropShadowFilterOperation::affectsOpacity):
(DropShadowFilterOperation):
- platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::hasFilterThatAffectsOpacity):
(WebCore):
(WebCore::FilterOperations::hasFilterThatMovesPixels):
- platform/graphics/filters/FilterOperations.h:
(WebCore::FilterOperations::isEmpty):
(FilterOperations):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTestLayerOcclusionWithFilters):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::CCLayerTreeHostTestLayerOcclusionWithFilters):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::afterTest):
(WTF):
LayoutTests:
- compositing/culling/filter-occlusion-alpha-expected.png: Added.
- compositing/culling/filter-occlusion-alpha-expected.txt: Added.
- compositing/culling/filter-occlusion-alpha-large-expected.png: Added.
- compositing/culling/filter-occlusion-alpha-large-expected.txt: Added.
- compositing/culling/filter-occlusion-alpha-large.html: Added.
- compositing/culling/filter-occlusion-alpha.html: Added.
- compositing/culling/filter-occlusion-blur-expected.txt: Added.
- compositing/culling/filter-occlusion-blur-large-expected.txt: Added.
- compositing/culling/filter-occlusion-blur-large.html: Added.
- compositing/culling/filter-occlusion-blur.html: Added.
- platform/chromium/compositing/culling/filter-occlusion-blur-expected.png: Added.
- platform/chromium/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 6:15 PM Changeset in webkit [108012] by
-
- 6 edits in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #22 of N.
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/chromium/test_expectations.txt:
- 6:08 PM Changeset in webkit [108011] by
-
- 5 edits in trunk/Source
[BlackBerry] Adapt to the removal of WebStringIml.h
https://bugs.webkit.org/show_bug.cgi?id=78784
Reviewed by Antonio Gomes.
Source/WebCore:
WebKit/blackberry/WebCoreSupport/WebStringImpl.h which hasn't been upstreamed
has been removed internally. We should adapt to this removal for the
upstreamed part of the BlackBerry port. Actually WebStringImpl is not necessary
because it just inherits from WTF::StringImpl but adding nothing.
No functionalities changed, no new tests.
- platform/text/blackberry/StringBlackBerry.cpp:
(WTF::String::operator WebString):
Source/WebKit:
blackberry/WebCoreSupport/WebStringImpl.h which hasn't been upstreamed
has been removed internally. We should adapt to this removal for the
upstreamed part of the BlackBerry port. Actually WebStringImpl is not necessary
because it just inherits from WTF::StringImpl but adding nothing.
- blackberry/Api/WebString.cpp:
(BlackBerry::WebKit::WebString::WebString):
(BlackBerry::WebKit::WebString::equalIgnoringCase):
- blackberry/Api/WebString.h:
(WTF):
- 5:56 PM Changeset in webkit [108010] by
-
- 16 edits1 add in trunk/Source
Made Weak<T> single-owner, adding PassWeak<T>
https://bugs.webkit.org/show_bug.cgi?id=78740
Reviewed by Sam Weinig.
Source/JavaScriptCore:
This works basically the same way as OwnPtr<T> and PassOwnPtr<T>.
This clarifies the semantics of finalizers: It's ambiguous and probably
a bug to copy a finalizer (i.e., it's a bug to run a C++ destructor
twice), so I've made Weak<T> non-copyable. Anywhere we used to copy a
Weak<T>, we now use PassWeak<T>.
This also makes Weak<T> HashMaps more efficient.
- API/JSClassRef.cpp:
(OpaqueJSClass::prototype): Use PassWeak<T> instead of set(), since
set() is gone now.
- JavaScriptCore.xcodeproj/project.pbxproj: Export!
- heap/PassWeak.h: Added.
(JSC):
(PassWeak):
(JSC::PassWeak::PassWeak):
(JSC::PassWeak::~PassWeak):
(JSC::PassWeak::get):
(JSC::::leakHandle):
(JSC::adoptWeak):
(JSC::operator==):
(JSC::operator!=): This is the Weak<T> version of PassOwnPtr<T>.
- heap/Weak.h:
(Weak):
(JSC::Weak::Weak):
(JSC::Weak::release):
(JSC::Weak::hashTableDeletedValue):
(JSC::=):
(JSC): Changed to be non-copyable, removing a lot of copying-related
APIs. Added hash traits so hash maps still work.
- jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
- runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate): Use PassWeak<T>, as required by
our new hash map API.
Source/WebCore:
- bindings/js/JSDOMBinding.cpp:
(WebCore::jsStringSlowCase): Use PassWeak<T>, as required by our new
hash map API.
- bindings/js/JSDOMBinding.h:
(WebCore::getCachedWrapper):
(WebCore::cacheWrapper): Use PassWeak<T> and raw pointer, as required by
our new hash map API.
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::setWrapper):
- bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::setWrapper):
- bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
- bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::addRuntimeObject): Use PassWeak<T>, as
required by our new hash map and Weak<T> APIs.
Source/WebKit2:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::getOrCreateJSObject): Use raw pointer and
PassWeak<T>, as required by our new hash map API.
- 5:43 PM Changeset in webkit [108009] by
-
- 6 edits2 adds in trunk
Crash in visiblePositionForIndex
https://bugs.webkit.org/show_bug.cgi?id=77683
Reviewed by Eric Seidel.
Source/WebCore:
Fixed the crash.
Test: editing/execCommand/applyblockelement-visiblepositionforindex-crash.html
- editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
- editing/htmlediting.cpp:
(WebCore::indexForVisiblePosition):
- editing/htmlediting.h:
(WebCore):
LayoutTests:
Add a regression test. It crashes Webkit with very high frequency.
- editing/execCommand/applyblockelement-visiblepositionforindex-crash-expected.txt: Added.
- editing/execCommand/applyblockelement-visiblepositionforindex-crash.html: Added.
- 5:40 PM Changeset in webkit [108008] by
-
- 2 edits in trunk/Source/WebCore
ShadowBlur.cpp's cached content matching needs to consider m_layerSize changes
https://bugs.webkit.org/show_bug.cgi?id=78765
Reviewed by Simon Fraser.
No new tests due to the flaky nature of reproducing the issue.
- platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::getScratchBuffer): Make sure to call clearScratchBuffer()
when we create a new ImageBuffer in order to invalidate cached values.
(WebCore::ScratchBuffer::setCachedShadowValues): Roll together matching and setting
of cached values into one method to enforce them being the same.
(WebCore::ScratchBuffer::setCachedInsetShadowValues): Ditto.
Restructure to use new method described above.
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::beginShadowLayer):
- 5:30 PM Changeset in webkit [108007] by
-
- 3 edits3 adds in trunk
[chromium] Empty divs not transforming overflow correctly
https://bugs.webkit.org/show_bug.cgi?id=78850
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-16
Reviewed by James Robinson.
Source/WebCore:
Test: compositing/overflow/transform-in-empty-container.html
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setSize):
LayoutTests:
- compositing/overflow/transform-in-empty-container-expected.png: Added.
- compositing/overflow/transform-in-empty-container-expected.txt: Added.
- compositing/overflow/transform-in-empty-container.html: Added.
- 5:16 PM Changeset in webkit [108006] by
-
- 2 edits in trunk/Source/WebCore
Fix use of long long in FractionalLayoutUnit::setRawValue
https://bugs.webkit.org/show_bug.cgi?id=78835
Reviewed by Eric Seidel.
Change setRawValue(long long) to compare against int min and max instead
of using abs as not all platforms we support implement a long long
version of abs or llabs.
No new tests.
- platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::setRawValue):
Compare against int min/max instead of just max with abs.
(WebCore::FractionalLayoutUnit::isInBounds):
Fix type mismatch warning.
(WebCore::operator==):
Fix typo.
(WebCore::operator*):
Use long long version of setRawValue.
- 5:11 PM Changeset in webkit [108005] by
-
- 3 edits in trunk/Tools
nrwt: simplify worker interface
https://bugs.webkit.org/show_bug.cgi?id=78181
Reviewed by Tony Chang.
This change moves code in name(), is_done(), run(), and cancel()
from Worker to AbstractWorker, since the logic is pretty much
boilerplate code that any implementation would want to use.
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get.should):
(AbstractWorker.init):
(AbstractWorker):
(AbstractWorker.name):
(AbstractWorker.stop_handling_messages):
(AbstractWorker.run):
(AbstractWorker.is_done):
(AbstractWorker.cancel):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.init):
(Worker.run):
(Worker.handle_stop):
- 5:06 PM Changeset in webkit [108004] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed baseline update for compositing/scrollbar-painting.html
- platform/chromium-mac-snowleopard/compositing/scrollbar-painting-expected.png:
- 4:57 PM Changeset in webkit [108003] by
-
- 11 edits in trunk
Source/WebCore: Add an internal flag to accept multiple shadow roots for the purpose of tests.
https://bugs.webkit.org/show_bug.cgi?id=78453
Reviewed by Hajime Morita.
This patch introduces a flag to enable multiple shadow subtrees.
This flag is intended to be used for testing purpose for a while.
We will remove it later.
No new tests, no change in behavior.
- WebCore.exp.in:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::multipleShadowSubtreesEnabled):
(WebCore::RuntimeEnabledFeatures::setMultipleShadowSubtreesEnabled):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
- dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::pushShadowRoot):
- testing/Internals.cpp:
(WebCore::Internals::setMultipleShadowSubtreesEnabled):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests: Needs an internal flag to accept multiple shadow roots for the purpose of tests
https://bugs.webkit.org/show_bug.cgi?id=78453
Reviewed by Hajime Morita.
- fast/dom/shadow/shadow-root-js-api.html:
- 4:57 PM Changeset in webkit [108002] by
-
- 2 edits in trunk/Websites/webkit.org
Improve usability of coding-style.html
https://bugs.webkit.org/show_bug.cgi?id=78470
Reviewed by Eric Seidel.
- coding/coding-style.html:
- Do not add a title attribute to each of LI elements
- Do not add a click handler to each of them
- Add a SPAN element in order to show [id-name] and provide smaller clickable area.
- 4:54 PM Changeset in webkit [108001] by
-
- 9 edits in trunk
Fix the broken viewport tests
https://bugs.webkit.org/show_bug.cgi?id=78774
Reviewed by Kenneth Rohde Christiansen.
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/text/WTFString.cpp:
(WTF):
(WTF::toDoubleType): Template-ized to allow other functions to specify whether they
want to allow trailing junk or not when calling strtod.
(WTF::charactersToDouble):
(WTF::charactersToFloat):
(WTF::charactersToFloatIgnoringJunk): Created new version of charactersToFloat that allows
trailing junk.
- wtf/text/WTFString.h:
(WTF):
Source/WebCore:
No new tests.
- dom/ViewportArguments.cpp:
(WebCore::numericPrefix): Changed to use the new charactersToFloatWithJunk function(s).
LayoutTests:
- platform/gtk/Skipped: Undoing tests skipped due to earlier breakage.
- platform/qt/Skipped: Ditto.
- 4:49 PM Changeset in webkit [108000] by
-
- 23 edits in trunk/LayoutTests
[chromium] Disable mock scrollbars for rubber-banding tests
https://bugs.webkit.org/show_bug.cgi?id=78370
Turning on mock scrollbars caused rubber-banding tests to fail
because the overhang is painted by the ScrollbarTheme, which
was replaced by the mock theme. Disable mock scrollbars for
these tests.
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-16
Reviewed by James Robinson.
- platform/chromium/test_expectations.txt:
- 4:48 PM Changeset in webkit [107999] by
-
- 2 edits in trunk/Source/WebCore
Very large strings could cause the new quoted string to wrap.
https://bugs.webkit.org/show_bug.cgi?id=78387
Reviewed by Eric Seidel.
- css/CSSParser.cpp:
(WebCore::quoteCSSString):
- 4:46 PM Changeset in webkit [107998] by
-
- 4 edits1 add in trunk/Source/WebCore
Add a themeChromiumAndroid.css file for android-specific default styles
https://bugs.webkit.org/show_bug.cgi?id=78547
Reviewed by Adam Barth.
This includes the themeChromiumAndroid.css file from the Chromium-Android port
as well as some addidtional changes they had to html.css. I believe those
changes were made before themeChromiumAndroid was created, but it's now the better place for this CSS.
- WebCore.gyp/WebCore.gyp:
- css/themeChromiumAndroid.css: Added.
(select[size][multiple]):
(input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"]):
- rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet):
(WebCore):
- rendering/RenderThemeChromiumAndroid.h:
(RenderThemeChromiumAndroid):
(WebCore::RenderThemeChromiumAndroid::delegatesMenuListRendering):
(WebCore::RenderThemeChromiumAndroid::platformTapHighlightColor):
- 4:46 PM Changeset in webkit [107997] by
-
- 4 edits2 adds in trunk
ENH: Add ability to run subset of JavaScript layout tests with JSC
https://bugs.webkit.org/show_bug.cgi?id=78764
Reviewed by Gavin Barraclough.
Tools:
New simple test drive shell script that runs a defined
list of javascript tests using jsc and the standalone-{pre,post}.js
wrappers.
- Scripts/run-fast-jsc: Added.
LayoutTests:
- fast/js/jsc-test-list: Added. List of tests that can be run
using jsc. Used by new Tools/Scripts/run-fast-jsc script.
- fast/js/resources/standalone-post.js: ~pdated to match changes
in js-test-post.js
- fast/js/resources/standalone-pre.js: Updated to match changes
in js-test-pre.js
- 4:28 PM Changeset in webkit [107996] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed. Mark fast/js/stack.html as an expected failure, we aren't interesting in converging on
this in v8.
- platform/chromium/test_expectations.txt:
- 4:26 PM Changeset in webkit [107995] by
-
- 6 edits in trunk/Source
<rdar://problem/10616280> and https://bugs.webkit.org/show_bug.cgi?id=78767
REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages
Reviewed by Sam Weinig.
Source/WebCore:
No new tests. (Subtle API change attached to a specific application)
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoadingInAPISense): Return true if the app needs the quirk
and there are outstanding subresource loads.
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setNeedsIsLoadingInAPISenseQuirk):
(WebCore::Settings::needsIsLoadingInAPISenseQuirk):
(Settings):
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _needsIsLoadingInAPISenseQuirk]):
(-[WebView _preferencesChanged:]):
- 4:10 PM Changeset in webkit [107994] by
-
- 19 edits in trunk
Remove [ConvertScriptString] from FileReaderSync.idl
https://bugs.webkit.org/show_bug.cgi?id=78335
Reviewed by Eric Seidel.
Source/WebCore:
The spec says that FileReadSync should throw NOT_FOUND_ERR
if a given blob is invalid: http://www.w3.org/TR/FileAPI/#FileReaderSync
By this fix, we can completely remove [ConvertScriptString] from WebKit.
Tests: fast/files/workers/worker-read-blob-sync.html
fast/files/workers/worker-read-file-sync.html
- fileapi/FileReaderSync.cpp: Modified to throw NOT_FOUND_ERR if a blob is invalid.
(WebCore::FileReaderSync::readAsArrayBuffer):
(WebCore::FileReaderSync::readAsBinaryString):
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::readAsDataURL):
- fileapi/FileReaderSync.idl:
- bindings/scripts/CodeGeneratorJS.pm: Removed [ConvertScriptString]
since no one is using it.
(NativeToJSValue):
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
(NativeToJSValue):
- bindings/scripts/test/TestObj.idl: Removed a test case for [ConvertScriptString].
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
LayoutTests:
The spec says that FileReadSync should throw NOT_FOUND_ERR
if a given blob is invalid: http://www.w3.org/TR/FileAPI/#FileReaderSync
This patch adds test cases for FileReaderSync with an invalid blob
to check that NOT_FOUND_ERR is thrown.
- fast/files/resources/read-common.js:
(_readBlobAsArrayBufferSync):
(_readBlobAsBinaryStringSync):
(_readBlobAsTextSync):
(_readBlobAsDataURLSync):
- fast/files/workers/worker-read-blob-sync-expected.txt:
- fast/files/workers/worker-read-file-sync-expected.txt:
- 4:10 PM Changeset in webkit [107993] by
-
- 2 edits in trunk/Source/WebKit/chromium
IndexedDB: Chromium WebKit API support for IDBObjectStore.delete(IDBKeyRange)
https://bugs.webkit.org/show_bug.cgi?id=78619
Add an overload to WebIDBObjectStore::deleteFunction(). First part of a two-sided patch.
Reviewed by Darin Fisher.
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::deleteFunction):
- 4:04 PM Changeset in webkit [107992] by
-
- 3 edits in trunk/Source/WebKit/blackberry
2012-02-16 Antonio Gomes <agomes@rim.com>
[BlackBerry] Implemented a way to defer client navigation change client notifications
https://bugs.webkit.org/show_bug.cgi?id=78848
Reviewed by Rob Buis.
Currently we postpone touch_down till touch_up if user touches
the screen and an input field has the WebKit focus. This is done
so we can scroll the page without hidding the vkb needlessly.
However, it breaks the conversion of touch to mouse events
if an input field has the focus in the following scenario:
an <input type=text> is focused and an user grab and-drag
a <input type=range> knob/slide. It does not work until the
user unfocuses the currently focused edit field.
Patch introduces a way to unfocus a currently focused input field,
without requesting the client to show or hide the virtual keyboard
right way. Instead it gets a delayed notification of the vkb mode requested
at either touch_released/mouse_up or touch_cancel time.
For now, due to content side issues with major web sites,
only delay navigation mode notification changes if we are not dealing with
input modes.
- WebKitSupport/InputHandler.cpp: (BlackBerry::WebKit::InputHandler::InputHandler): (BlackBerry::WebKit::InputHandler::nodeFocused): (BlackBerry::WebKit::InputHandler::setElementFocused): (BlackBerry::WebKit::InputHandler::setNavigationMode): (WebKit): (BlackBerry::WebKit::InputHandler::setDelayClientNotificationOfNavigationModeChange): (BlackBerry::WebKit::InputHandler::processPendingClientNavigationModeChangeNotification): (BlackBerry::WebKit::InputHandler::notifyClientOfNavigationModeChange): (BlackBerry::WebKit::InputHandler::willOpenPopupForNode): (BlackBerry::WebKit::InputHandler::setPopupListIndexes): (BlackBerry::WebKit::InputHandler::spannableTextInRange): (BlackBerry::WebKit::InputHandler::removeComposedText): (BlackBerry::WebKit::InputHandler::firstSpanInString): (BlackBerry::WebKit::InputHandler::setText): (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
- WebKitSupport/InputHandler.h: (InputHandler):
- 4:04 PM Changeset in webkit [107991] by
-
- 3 edits in trunk/Source/WebKit/blackberry
2012-02-16 Antonio Gomes <agomes@rim.com>
Crash @WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling MKS_2986818
https://bugs.webkit.org/show_bug.cgi?id=78845
Reviewed by Rob Buis.
We were trying to operate on a cached Node when its page/frame/document
were gone to PageCache already. To avoid such problems, lets clean up
any document data we have cached when the Frame goes into the cache.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp: (WebCore::FrameLoaderClientBlackBerry::didSaveToPageCache): (WebCore):
- WebCoreSupport/FrameLoaderClientBlackBerry.h: (FrameLoaderClientBlackBerry):
- 4:04 PM Changeset in webkit [107990] by
-
- 1 edit2 adds in trunk/Source/WebKit/blackberry
2012-02-16 Antonio Gomes <agomes@rim.com>
[BlackBerry] Upstream touch handling related classes (Part III: InRegionScrollableArea)
https://bugs.webkit.org/show_bug.cgi?id=78509
Reviewed by Adam Treat and Rob Buis.
InRegionScrollableArea specializes the BlackBerry specific ScrollViewBase,
working as a read-only wrapper object for a scrollable areas in the page.
It is used in our client side to control in-region scrolling (scrollable boxes,
inner frames, etc).
Initial upstream.
- WebKitSupport/InRegionScrollableArea.cpp: Added. (WebKit): (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea): (BlackBerry::WebKit::InRegionScrollableArea::calculateMinimumScrollPosition): (BlackBerry::WebKit::InRegionScrollableArea::calculateMaximumScrollPosition): (BlackBerry::WebKit::InRegionScrollableArea::layer): (BlackBerry):
- WebKitSupport/InRegionScrollableArea.h: Added. (WebCore): (WebKit): (InRegionScrollableArea):
- 3:59 PM Changeset in webkit [107989] by
-
- 2 edits in trunk/Source/WebKit/gtk
Attempt to fix the GTK build.
- WebCoreSupport/GeolocationClientGtk.cpp:
(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):
- 3:51 PM Changeset in webkit [107988] by
-
- 7 edits3 adds in trunk
[chromium] Clipping/Transforms applied in wrong order in opaque paint tracking
https://bugs.webkit.org/show_bug.cgi?id=78775
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-16
Reviewed by Stephen White.
Source/WebCore:
The clip was being applied in device coordinates, before transforming the painted
rect into device coordinates. This made any translations get doubly represented,
and gave incorrect paint tracking results.
Test: compositing/culling/unscrolled-within-boxshadow.html
Unit test: PlatformContextSkiaTest.cpp
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDraw):
Source/WebKit/chromium:
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
LayoutTests:
- compositing/culling/unscrolled-within-boxshadow-expected.png: Added.
- compositing/culling/unscrolled-within-boxshadow-expected.txt: Added.
- compositing/culling/unscrolled-within-boxshadow.html: Added.
- compositing/overflow/clip-content-under-overflow-controls-expected.png:
- compositing/scrollbar-painting-expected.png:
- 3:35 PM Changeset in webkit [107987] by
-
- 3 edits2 adds in trunk
Crash with tables in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78415
Reviewed by Julien Chaffraix.
Source/WebCore:
Multi-column code creates anonymous column blocks directly
under RenderTable, thereby violating table layout assumption.
E.g. Captions in this testcase gets reparented to these anonymous
column blocks and when they go away, they are not able to clear
themselves from table's m_captions list (since RenderTable::removeChild
is not called).
Test: fast/multicol/span/table-multi-column-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::containingColumnsBlock):
LayoutTests:
- fast/multicol/span/table-multi-column-crash-expected.txt: Added.
- fast/multicol/span/table-multi-column-crash.html: Added.
- 3:32 PM Changeset in webkit [107986] by
-
- 4 edits2 adds in trunk/Source/WebCore
[GTK] File system api build is broken
https://bugs.webkit.org/show_bug.cgi?id=78479
Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-16
Reviewed by Philippe Normand.
This patch is a small step to support FileSystem API for GTK port.
As I know, bug58443 also dealt with it, but it looks like the submitted patch
needs to be updated. To do that, I think I need to discuss with the original author.
So, I hope to just fix build break issue in this bug.
No new tests. Implementing the feature is not done yet.
- GNUmakefile.list.am: Added some missing files.
- bindings/js/JSDirectoryEntryCustom.cpp: Added Error.h to use its API.
- platform/AsyncFileSystem.cpp:
(WebCore):
(WebCore::AsyncFileSystem::create): The arguments don't match the declaration in AsyncFileSystem.h.
- platform/gtk/AsyncFileSystemGtk.cpp: Added.
(WebCore):
(WebCore::AsyncFileSystem::isAvailable):
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystemGtk::AsyncFileSystemGtk):
(WebCore::AsyncFileSystemGtk::~AsyncFileSystemGtk):
(WebCore::AsyncFileSystemGtk::toURL):
(WebCore::AsyncFileSystemGtk::move):
(WebCore::AsyncFileSystemGtk::copy):
(WebCore::AsyncFileSystemGtk::remove):
(WebCore::AsyncFileSystemGtk::removeRecursively):
(WebCore::AsyncFileSystemGtk::readMetadata):
(WebCore::AsyncFileSystemGtk::createFile):
(WebCore::AsyncFileSystemGtk::createDirectory):
(WebCore::AsyncFileSystemGtk::fileExists):
(WebCore::AsyncFileSystemGtk::directoryExists):
(WebCore::AsyncFileSystemGtk::readDirectory):
(WebCore::AsyncFileSystemGtk::createWriter):
- platform/gtk/AsyncFileSystemGtk.h: Added.
(WebCore):
(AsyncFileSystemGtk):
- 3:30 PM Changeset in webkit [107985] by
-
- 2 edits in trunk/Source/WebCore
Handle dirty descendant visibility status in RenderLayer::updateLayerPositionsAfterScroll
https://bugs.webkit.org/show_bug.cgi?id=78286
Reviewed by Julien Chaffraix.
This is an unfortunate bandaid over a corner case where sometimes the
visible descendant status dirty flag is true when this function is
called from FrameView::repaintFixedElementsAfterScrolling. As it
should be cheap to refresh this flag when dirty in most cases (as it
early outs after finding any visible descendant), just lazily update
the dirty flag here to ensure correctness.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
- 3:25 PM Changeset in webkit [107984] by
-
- 3 edits2 moves in trunk/LayoutTests
[chromium] Update table pixel expectations. Unreviewed.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug27038-1-expected.png.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug27038-2-expected.png.
- platform/chromium-win/tables/mozilla/bugs/bug27038-1-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.png:
- 2:54 PM Changeset in webkit [107983] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Add WEBKIT_EXPORT to new WebDragData methods.
https://bugs.webkit.org/show_bug.cgi?id=78843
Reviewed by Tony Chang.
- public/platform/WebDragData.h:
(WebDragData):
- 2:50 PM Changeset in webkit [107982] by
-
- 4 edits in trunk/Source/WebCore
Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed
https://bugs.webkit.org/show_bug.cgi?id=78844
Reviewed by Eric Seidel.
These function serve no useful purpose and should be removed.
- page/Chrome.cpp:
(WebCore):
- page/Chrome.h:
(Chrome):
- page/Geolocation.cpp:
(WebCore::Geolocation::reset):
(WebCore::Geolocation::requestPermission):
- 2:45 PM Changeset in webkit [107981] by
-
- 1 edit1 add in trunk/LayoutTests
Add a missing image for my commit r107965.
- fast/multicol/span/clone-flexbox-expected.png: Added.
- 2:38 PM Changeset in webkit [107980] by
-
- 13 edits3 adds in trunk
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Implement support for stack traces on exception objects. This is a rewrite
of the core portion of the last stack walking logic, but the mechanical work
of adding the information to an exception comes from the original work by
Juan Carlos Montemayor Elosua.
- interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
(JSC):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
- interpreter/Interpreter.h:
(JSC):
(StackFrame):
(JSC::StackFrame::toString):
(Interpreter):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
- parser/Nodes.h:
(JSC::FunctionBodyNode::setInferredName):
- parser/Parser.h:
(JSC::::parse):
- runtime/CommonIdentifiers.h:
- runtime/Error.cpp:
(JSC::addErrorInfo):
- runtime/Error.h:
(JSC):
LayoutTests:
Add testcases for producing a stack trace on exception objects.
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js: Added.
(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
(selfRecursive1):
(selfRecursive2):
(selfRecursive3):
(throwError):
(object.get getter1.o.valueOf):
(object.get getter1):
(object.get getter2):
(object.get getter3.o2.valueOf):
(object.get getter3):
(object.nonInlineable.callCount):
(object.nonInlineable):
(object.inlineable):
(yetAnotherInlinedCall):
(makeInlinableCall):
(.try.g):
(h):
(mapTest):
(mapTestDriver):
(dfgFunction):
(try.f):
- fast/js/stack-trace-expected.txt: Added.
- fast/js/stack-trace.html: Added.
- 2:22 PM Changeset in webkit [107979] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h
Changing the isInBounds asserts to use less than equals, instead of less than.
- 2:03 PM Changeset in webkit [107978] by
-
- 1 edit2 adds in trunk/Source/WebKit/blackberry
2012-02-16 Antonio Gomes <agomes@rim.com>
[BlackBerry] Upstream touch handling related classes (part II: FatFingers)
https://bugs.webkit.org/show_bug.cgi?id=78509
Reviewed by Rob Buis.
FatFingers is the class responsible to the whole touch
accuracy of the BlackBerry port. Initial upstream.
- WebKitSupport/FatFingers.cpp: Added. (WebKit): (BlackBerry::WebKit::FatFingers::fingerRectForPoint): (BlackBerry::WebKit::hasMousePressListener): (BlackBerry::WebKit::FatFingers::isElementClickable): (BlackBerry::WebKit::isFieldWithText): (BlackBerry::WebKit::distanceBetweenPoints): (BlackBerry::WebKit::compareDistanceBetweenPoints): (BlackBerry::WebKit::isValidFrameOwner): (BlackBerry::WebKit::FatFingers::FatFingers): (BlackBerry::WebKit::FatFingers::~FatFingers): (BlackBerry::WebKit::FatFingers::findBestPoint): (BlackBerry::WebKit::FatFingers::checkFingerIntersection): (BlackBerry::WebKit::FatFingers::findIntersectingRegions): (BlackBerry::WebKit::FatFingers::checkForClickableElement): (BlackBerry::WebKit::FatFingers::checkForText): (BlackBerry::WebKit::FatFingers::getPaddings): (BlackBerry::WebKit::FatFingers::nodesFromRect): (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint): (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
- WebKitSupport/FatFingers.h: Added. (WebCore): (WebKit): (FatFingersResult): (BlackBerry::WebKit::FatFingersResult::FatFingersResult): (BlackBerry::WebKit::FatFingersResult::reset): (BlackBerry::WebKit::FatFingersResult::originPosition): (BlackBerry::WebKit::FatFingersResult::adjustedPosition): (BlackBerry::WebKit::FatFingersResult::positionWasAdjusted): (BlackBerry::WebKit::FatFingersResult::isTextInput): (BlackBerry::WebKit::FatFingersResult::isValid): (BlackBerry::WebKit::FatFingersResult::validNode): (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable): (FatFingers):
- 1:32 PM Changeset in webkit [107977] by
-
- 2 edits3 adds in trunk/LayoutTests
[chromium] Unreviewed, update baselines for region repaint tests due to skia off-by-one.
- platform/chromium-mac-snowleopard/fast/repaint/region-painting-invalidation-expected.png: Added.
- platform/chromium-win/fast/repaint/region-painting-invalidation-expected.png: Added.
- platform/chromium-win/fast/repaint/region-painting-invalidation-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 1:24 PM Changeset in webkit [107976] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, these regions tests pass after r107961.
- platform/chromium/test_expectations.txt:
- 1:20 PM Changeset in webkit [107975] by
-
- 50 edits5 copies10 moves1 add6 deletes in trunk/LayoutTests
[chromium] Unreviewed rebaselines and expectation updates.
- platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
- platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
- platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-10-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-2-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-3-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-4-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-5-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-6-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-7-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png:
- platform/chromium-mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-and-click-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png.
- platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png.
- platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Removed.
- platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Removed.
- platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Removed.
- platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Removed.
- platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Removed.
- platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Removed.
- platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
- platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
- platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
- platform/chromium/test_expectations.txt:
- 1:06 PM Changeset in webkit [107974] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r107952.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 12:56 PM Changeset in webkit [107973] by
-
- 6 edits in trunk/Source
[soup] Move important SoupSession feature initialization to WebCore
https://bugs.webkit.org/show_bug.cgi?id=68602
Reviewed by Martin Robinson.
Source/WebCore:
Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them. Added also out-of-the-box proxy support to WebCore.
No new tests required as we're just moving stuff from WebKit to
WebCore.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):
Source/WebKit/gtk:
Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them.
No new tests required as we're just moving stuff from WebKit to
WebCore.
- webkit/webkitglobals.cpp:
(webkitInit):
Source/WebKit2:
Moved content sniffer and decoder initialization from the
WebProcess to WebCore because network stuff will not work as
expected without them.
No new tests required as we're just moving stuff from the
WebProcess to WebCore.
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
- 12:55 PM Changeset in webkit [107972] by
-
- 3 adds in trunk/Source/WebKit/blackberry
2012-02-16 Antonio Gomes <agomes@rim.com>
[BlackBerry] Upstream touch handling related classes
https://bugs.webkit.org/show_bug.cgi?id=78509
Reviewed by Rob Buis.
Initial upstream of the Blackberry specific single touch event
handler class.
- blackberry/WebKitSupport/TouchEventHandler.cpp: Added. (WebKit): (BlackBerry::WebKit::hasMouseMoveListener): (BlackBerry::WebKit::hasTouchListener): (BlackBerry::WebKit::elementExpectsMouseEvents): (BlackBerry::WebKit::shouldConvertTouchToMouse): (BlackBerry::WebKit::TouchEventHandler::TouchEventHandler): (BlackBerry::WebKit::TouchEventHandler::~TouchEventHandler): (BlackBerry::WebKit::TouchEventHandler::shouldSuppressMouseDownOnTouchDown): (BlackBerry::WebKit::TouchEventHandler::touchEventCancel): (BlackBerry::WebKit::TouchEventHandler::touchHoldEvent): (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint): (BlackBerry::WebKit::TouchEventHandler::spellCheck): (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed): (BlackBerry::WebKit::elementForTapHighlight): (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
- blackberry/WebKitSupport/TouchEventHandler.h: Added. (WebCore): (WebKit): (TouchEventHandler): (BlackBerry::WebKit::TouchEventHandler::lastFatFingersResult): (BlackBerry::WebKit::TouchEventHandler::resetLastFatFingersResult):
- 12:50 PM Changeset in webkit [107971] by
-
- 13 edits2 adds in trunk
thead in table without tbody causes table height doubling
https://bugs.webkit.org/show_bug.cgi?id=37244
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: fast/table/double-height-table-no-tbody-expected.html
fast/table/double-height-table-no-tbody.html
The bug is caused by the layout code would wrongly assuming that a
table without a <tbody> is an empty table. We would set the logical
height to the style's logical height wrongly before inflating the
logical height to account for the section(s). This would cause us
to increase past our needed size thus the bug.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
A table is empty if it does not have any top section, not just a <tbody>.
The test uncovered an issue with height distribution in layoutRows where we
would distribute the extra height to the first <tbody> not section.
LayoutTests:
- fast/table/double-height-table-no-tbody-expected.html: Added.
- fast/table/double-height-table-no-tbody.html: Added.
Test that we properly lay out tables with only a <thead> or <tfoot>
exactly like a table with only a <tbody>.
- platform/chromium-linux/tables/mozilla/bugs/bug27038-1-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.txt:
This is neither a progression nor a regression. We are not doing the right
thing as we don't distribute the extra logical height evenly over our sections.
Now we give the extra height to the <thead> (first section) instead of the <tbody>.
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/win/test_expectations.txt:
Marked the previous tests as needing a new baseline.
- 12:40 PM Changeset in webkit [107970] by
-
- 4 edits4 adds in trunk
CSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015 fail
https://bugs.webkit.org/show_bug.cgi?id=78027
Reviewed by Julien Chaffraix.
Source/WebCore:
Both of these test the (slightly implicit) rule that width set on column-groups cannot
affect the width of columns in a fixed layout table: http://www.w3.org/TR/CSS21/tables.html#fixed-table-layout
FF, Opera and IE all pass these two tests.
Tests: css2.1/20110323/fixed-table-layout-013.htm
css2.1/20110323/fixed-table-layout-015.htm
- rendering/FixedTableLayout.cpp:
(WebCore::nextCol): A helper function for finding the next column along.
(WebCore::FixedTableLayout::calcWidthArray): Ignore width specified by column groups.
- rendering/RenderTableCol.h:
(WebCore::RenderTableCol::isTableColGroup): Convenience function for identifying column groups.
LayoutTests:
- css2.1/20110323/fixed-table-layout-013-expected.html: Added.
- css2.1/20110323/fixed-table-layout-013.htm: Added.
- css2.1/20110323/fixed-table-layout-015-expected.html: Added.
- css2.1/20110323/fixed-table-layout-015.htm: Added.
- 12:32 PM Changeset in webkit [107969] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, tests passing after the fix in r107874.
- platform/chromium/test_expectations.txt:
- 12:32 PM Changeset in webkit [107968] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r107941.
http://trac.webkit.org/changeset/107941
https://bugs.webkit.org/show_bug.cgi?id=68602
Broke 23 http tests on GTK
Source/WebCore:
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):
Source/WebKit/gtk:
- webkit/webkitglobals.cpp:
(webkitInit):
Source/WebKit2:
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
- 12:30 PM Changeset in webkit [107967] by
-
- 3 edits2 adds in trunk
XSS Auditor bypass with U+2028/2029
https://bugs.webkit.org/show_bug.cgi?id=78732
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028.html
- html/parser/XSSAuditor.cpp:
(WebCore::isJSNewline):
(WebCore::XSSAuditor::snippetForJavaScript):
LayoutTests:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028.html: Added.
- 12:19 PM Changeset in webkit [107966] by
-
- 2 edits in trunk/Source/WebCore
NPN_GetValueForURL / NPNURLVProxy returns DIRECT when proxy configured via PAC
<http://webkit.org/b/78766> / <rdar://problem/10729283>
Reviewed by Anders Carlsson.
- platform/network/cf/ProxyServerCFNet.cpp:
(WebCore::proxyAutoConfigurationResultCallback): Stop the runloop, and then process
the results that we received.
(WebCore::processProxyServers): Processing of array of proxy configuration information
moved from addProxyServersForURL. Handling of proxy auto-configuration URLs is now handled
by calling CFNetworkExecuteProxyAutoConfigurationURL and waiting synchronously on the result
callback. Doing this synchronously is not great, but it's the best we can do without a lot
of restructuring of the code that calls this. We arbitrarily time out the execution after five
seconds to avoid permanently hanging.
(WebCore::addProxyServersForURL): Call in to our helper function.
- 12:16 PM Changeset in webkit [107965] by
-
- 3 edits2 adds in trunk
Fix clone() function to handle descendant classes of RenderBlock.
https://bugs.webkit.org/show_bug.cgi?id=78273
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/multicol/span/clone-flexbox-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
LayoutTests:
You should see two RenderFlexibleBox in the rendertree, indicating that
cloning was correct.
- fast/multicol/span/clone-flexbox-expected.txt: Added.
- fast/multicol/span/clone-flexbox.html: Added.
- 12:14 PM Changeset in webkit [107964] by
-
- 1 edit1 add in trunk/PerformanceTests
Add a perf test for the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=78114
Reviewed by Ryosuke Niwa.
Add a perf test for the CSS parser. It load a big CSS chunk
which contains some snippets of the YUI library from Yahoo!.
- Parser/css-parser-yui.html: Added.
- 12:00 PM Changeset in webkit [107963] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Add to committers.py
- 11:57 AM Changeset in webkit [107962] by
-
- 3 edits in trunk/LayoutTests
[chromium] Unreviewed gardening
- platform/chromium/fast/js/property-getters-and-setters-expected.txt:
- platform/chromium/test_expectations.txt:
- 11:39 AM Changeset in webkit [107961] by
-
- 7 edits in trunk
[CSSRegions]overflowRegion tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=78761
Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-16
Reviewed by Tony Chang.
Source/WebCore:
The overflowRegion tests were updated.
- dom/Element.cpp:
(WebCore::Element::webkitRegionOverflow):
LayoutTests:
- fast/regions/element-region-overflow-state-expected.txt:
- fast/regions/element-region-overflow-state-vertical-rl-expected.txt:
- fast/regions/element-region-overflow-state-vertical-rl.html:
- fast/regions/element-region-overflow-state.html:
- 11:36 AM Changeset in webkit [107960] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Add method to WebPluginContainer to check if a rectangle is topmost
https://bugs.webkit.org/show_bug.cgi?id=78166
Patch by Viet-Trung Luu <viettrungluu@chromium.org> on 2012-02-16
Reviewed by Darin Fisher.
- public/WebPluginContainer.h:
(WebPluginContainer):
- src/WebPluginContainerImpl.cpp:
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- 11:15 AM Changeset in webkit [107959] by
-
- 4 edits3 adds in trunk
[CSS Regions] Repaint issues when changing innerHTML of content
https://bugs.webkit.org/show_bug.cgi?id=78787
Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-16
Reviewed by David Hyatt.
Source/WebCore:
The calculation of the clipping rectangle is based on the repaint rectangle,
so it needs to be clipped to the current region, because it might spread over multiple ones.
Test: fast/repaint/region-painting-invalidation.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions):
LayoutTests:
- fast/repaint/region-painting-invalidation.html: Added.
- platform/chromium/test_expectations.txt: Needs baseline
- platform/mac/fast/repaint/region-painting-invalidation-expected.png: Added.
- platform/mac/fast/repaint/region-painting-invalidation-expected.txt: Added.
- 11:12 AM Changeset in webkit [107958] by
-
- 2 edits8 adds in trunk/LayoutTests
[chromium] Unreviewed chromium gardening
- platform/chromium-linux/svg/text/tspan-dynamic-positioning-expected.png: Added.
- platform/chromium-mac-leopard/compositing/plugins/composited-plugin-expected.png: Added.
- platform/chromium-mac-leopard/compositing/plugins/composited-plugin-expected.txt: Added.
- platform/chromium-mac-leopard/svg/text/tspan-dynamic-positioning-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/text/tspan-dynamic-positioning-expected.png: Added.
- platform/chromium-win/svg/text/tspan-dynamic-positioning-expected.png: Added.
- platform/chromium-win/svg/text/tspan-dynamic-positioning-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 11:08 AM Changeset in webkit [107957] by
-
- 2 edits in trunk
Numerous trivial bugs in Object.defineProperty
https://bugs.webkit.org/show_bug.cgi?id=78777
Reviewed by Sam Weinig.
There are a handful of really trivial bugs, related to Object.defineProperty:
- Redefining an accessor with different attributes changes the attributes, but not the get/set functions!
- Calling an undefined setter should only throw in strict mode.
- When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
- Any attempt to redefine a non-configurable property of an array as configurable should be rejected.
- Object.defineProperties should call toObject on 'Properties' argument, rather than throwing if it is not an object.
- If preventExtensions has been called on an array, subsequent assignment beyond array bounds should fail.
- 'isFrozen' shouldn't be checking the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').
- Should be able to redefine an non-writable, non-configurable property, with the same value and attributes.
- Should be able to define an non-configurable accessor.
These are mostly all one-line changes, e.g. inverted boolean checks, masking against wrong attribute.
Source/JavaScriptCore:
- runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::put):
- Added ASSERT.
- Calling an undefined setter should only throw in strict mode.
(JSC::JSArray::putDescriptor):
- Should be able to define an non-configurable accessor.
(JSC::JSArray::defineOwnNumericProperty):
- Any attempt to redefine a non-configurable property of an array as configurable should be rejected.
(JSC::JSArray::putByIndexBeyondVectorLength):
- If preventExtensions has been called on an array, subsequent assignment beyond array bounds should fail.
- runtime/JSArray.h:
(JSArray):
- made enterDictionaryMode public, called from JSObject.
- runtime/JSObject.cpp:
(JSC::JSObject::put):
- Calling an undefined setter should only throw in strict mode.
(JSC::JSObject::preventExtensions):
- Put array objects into dictionary mode to handle this!
(JSC::JSObject::defineOwnProperty):
- Should be able to redefine an non-writable, non-configurable property, with the same value and attributes.
- Redefining an accessor with different attributes changes the attributes, but not the get/set functions!
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorDefineProperties):
- Object.defineProperties should call toObject on 'Properties' argument, rather than throwing if it is not an object.
- runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::attributesWithOverride):
- When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
(JSC::PropertyDescriptor::attributesOverridingCurrent):
- When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
- runtime/Structure.cpp:
(JSC::Structure::freezeTransition):
- 'freezeTransition' shouldn't be setting the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').
(JSC::Structure::isFrozen):
- 'isFrozen' shouldn't be checking the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').
LayoutTests:
- fast/js/Object-defineProperties-expected.txt:
- fast/js/Object-defineProperty-expected.txt:
- fast/js/preventExtensions-expected.txt:
- fast/js/property-getters-and-setters-expected.txt:
- fast/js/script-tests/Object-defineProperty.js:
- fast/js/script-tests/preventExtensions.js:
- fast/js/script-tests/property-getters-and-setters.js:
- Update result & add new test cases for all bugs fixed.
- 11:06 AM Changeset in webkit [107956] by
-
- 15 edits in trunk
Source/JavaScriptCore: <<<<<<< .mine
LayoutTests: <<<<<<< .mine
- 10:55 AM Changeset in webkit [107955] by
-
- 2 edits in branches/subpixellayout/Source/WebCore
Un-nesting the namespaces in FractionaLayoutUnit, and correcting use of max integers in RenderRubyRun with max LayoutUnits.
- 10:12 AM Changeset in webkit [107954] by
-
- 16 edits5 deletes in trunk/Source/WebCore
Roll out r107887
It broke 32-bit builds due to truncation from "long long" to "int".
Original bug is <http://webkit.org/b/76571> Add FractionalLayoutPoint/Size/Rect for
sub-pixel layout
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore::operator==):
(WebCore::operator*):
- platform/graphics/FloatPoint.cpp:
- platform/graphics/FloatPoint.h:
(WebCore):
(FloatPoint):
(WebCore::FloatPoint::move):
(WebCore::FloatPoint::moveBy):
- platform/graphics/FloatRect.cpp:
- platform/graphics/FloatRect.h:
(WebCore):
- platform/graphics/FloatSize.cpp:
- platform/graphics/FloatSize.h:
(WebCore):
- platform/graphics/FractionalLayoutPoint.h: Removed.
- platform/graphics/FractionalLayoutRect.cpp: Removed.
- platform/graphics/FractionalLayoutRect.h: Removed.
- platform/graphics/FractionalLayoutSize.cpp: Removed.
- platform/graphics/FractionalLayoutSize.h: Removed.
- platform/graphics/IntRect.cpp:
- platform/graphics/IntRect.h:
(WebCore):
(IntRect):
- 10:08 AM Changeset in webkit [107953] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: cache settings values
https://bugs.webkit.org/show_bug.cgi?id=78815
Reviewed by Vsevolod Vlasov.
- inspector/front-end/Settings.js:
(WebInspector.Setting.prototype.get if):
(WebInspector.Setting.prototype):
(WebInspector.Setting.prototype.):
(WebInspector.Setting.prototype.set this):
- 9:51 AM Changeset in webkit [107952] by
-
- 22 edits1 copy4 adds in trunk
WebKit does not support DOM 3 Events FocusEvent
https://bugs.webkit.org/show_bug.cgi?id=76216
Source/WebCore:
Created a new FocusEvent class (extends UIEvent) with a relatedTarget attribute. Moved
the {Focus,Blur,FocusIn,FocusOut}EventDispatchMediator classes inside FocusEvent. Now when
focusin or focusout events are dispatched, a FocusEvent is created with the relatedTarget
attribute set accordingly. No other logic changes have been made besides adding the
FocusEvent class.
Patch by Terry Anderson <tdanderson@chromium.org> on 2012-02-16
Reviewed by Eric Seidel.
Test: fast/events/related-target-focusevent.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- Included mention of FocusEvent / JSFocusEvent in the above files to allow the patch to build on the different platforms
- dom/EventDispatchMediator.cpp:
- dom/EventDispatchMediator.h:
- dom/EventFactory.in:
- dom/FocusEvent.cpp: Added.
(WebCore):
(WebCore::FocusEvent::FocusEvent):
(WebCore::FocusEvent::~FocusEvent):
(WebCore::FocusEvent::initFocusEvent):
(WebCore::FocusEvent::interfaceName):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::event):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::event):
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
- dom/FocusEvent.h: Copied from Source/WebCore/dom/EventDispatchMediator.h.
(WebCore):
(FocusEvent):
(WebCore::FocusEvent::create):
(WebCore::FocusEvent::relatedTarget):
(WebCore::FocusEvent::setRelatedTarget):
(FocusInEventDispatchMediator):
(FocusOutEventDispatchMediator):
(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
- dom/FocusEvent.idl: Added.
- dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
- dom/UIEvent.cpp:
- dom/UIEvent.h:
- page/DOMWindow.idl:
LayoutTests:
Patch by Terry Anderson <tdanderson@chromium.org> on 2012-02-16
Reviewed by Eric Seidel.
- fast/dom/shadow/shadow-boundary-events-expected.txt:
- fast/dom/shadow/shadow-boundary-events.html:
- Changed the focusin/focusout parts of this layout test to include the relatedTarget attribute, which is now set on FocusEvent objects
- fast/events/event-creation-expected.txt:
- fast/events/event-creation.html:
- Added the creation of FocusEvents to this layout test
- fast/events/related-target-focusevent-expected.txt: Added.
- fast/events/related-target-focusevent.html: Added.
- This is a new layout test I created specifically for this patch
- 9:48 AM Changeset in webkit [107951] by
-
- 10 edits in trunk/Source
[Texmap] Improve the way we deal with BGRA extension
https://bugs.webkit.org/show_bug.cgi?id=78822
Source/WebCore:
Swizzle the RGBA manually only in OpenGL ES, and only if the extension is not available.
Pass the pixel-format of the images when updating TextureMapperTiledBackingStore.
Reviewed by Kenneth Rohde Christiansen.
No new behavior.
- platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore):
(WebCore::hasExtension):
(WebCore::hasBgraExtension):
(WebCore::BitmapTextureGL::updateContents):
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):
- platform/graphics/texmap/TextureMapperBackingStore.h:
(TextureMapperTile):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::updateContents):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore):
Source/WebKit2:
Get rid of swizzling in the web process. Instead, we moved swizzling back to
TextureMapperGL, as we're moving towards a setup where textures are uploaded
in the web process.
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/qt/LayerBackingStore.cpp:
(WebKit::LayerBackingStoreTile::swapBuffers):
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::createImage):
- WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::adoptImageBackingStore):
- 9:45 AM Changeset in webkit [107950] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix WebKit2 GTK+ build after r107947.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialogForFrame):
- 9:33 AM Changeset in webkit [107949] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix linking in debug builds on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=78811
Patch by Alexander Færøy <ahf@0x90.dk> on 2012-02-16
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/qt/tests/bytearraytestdata.h:
- 9:16 AM Changeset in webkit [107948] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Page content is incorrectly translated whenh rendering pages for printing in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=78712
Reviewed by Martin Robinson.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::enumeratePrintersFunction):
Simplify the code to select the printer.
(WebKit::WebPrintOperationGtk::renderPage): Call cairo_save()
before rendering the page and cairo_restore() when page has been
rendered.
- 9:10 AM Changeset in webkit [107947] by
-
- 11 edits4 adds in trunk/Source/WebKit2
[GTK] Add WebKitPrintOperation to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76448
Reviewed by Martin Robinson.
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitDefines.h:
- UIProcess/API/gtk/WebKitPrintOperation.cpp: Added.
(webViewDestroyed): Delete the print operation when the view
widget associated is destroyed.
(webkitPrintOperationConstructed): Connect to destroy signal of
associated web view.
(webkitPrintOperationGetProperty):
(webkitPrintOperationSetProperty):
(webkit_print_operation_init):
(webkit_print_operation_class_init):
(webkitPrintOperationRunDialogUnix): Use GtkPrintUnixDialog to
show the printing dialog in UNIX platforms.
(webkitPrintOperationRunDialogWin32): Empty, not implemented yet.
(drawPagesForPrintingCompleted): Callback called when printing
operation has finished in the web process.
(webkitPrintOperationRunDialogForFrame): Run the printing dialog
and start printing the given frame.
(webkit_print_operation_new): Create a new print operation for the
given web view.
(webkit_print_operation_get_print_settings):
(webkit_print_operation_set_print_settings):
(webkit_print_operation_get_page_setup):
(webkit_print_operation_set_page_setup):
(webkit_print_operation_run_dialog): Run the print dialog to print
the web view main frame.
- UIProcess/API/gtk/WebKitPrintOperation.h: Added.
- UIProcess/API/gtk/WebKitPrintOperationPrivate.h: Added.
- UIProcess/API/gtk/WebKitUIClient.cpp:
(printFrame): Call webkitWebViewPrintFrame.
(attachUIClientToView): Add implementation for
printFrame callback.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init): Add WebKitWebView::print-requested
signal.
(webkitWebViewPrintFrame): Emit print-requested and show the print
dialog to print the frame when not signal is not handled by user.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitPrintOperation.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/tests/GNUmakefile.am:
- UIProcess/API/gtk/tests/TestPrinting.cpp: Added.
(testPrintOperationPrintSettings):
(webViewPrintRequestedCallback):
(testWebViewPrintRequested):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/webkit2.h: Include WebKitPrintOperation.h.
- 9:09 AM Changeset in webkit [107946] by
-
- 3 edits in trunk/Source/WebKit
[BlackBerry] Style clean-up in WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=78738
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-16
Reviewed by Rob Buis.
No new functionality, no new tests.
- blackberry/WebKitSupport/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::drawLayers):
- blackberry/WebKitSupport/WebPageCompositor.h:
(WebKit):
- 9:03 AM Changeset in webkit [107945] by
-
- 12 edits2 moves in trunk/Source
[Gtk][Efl][Qt] Move OpenGLShims out of cairo/ subdirectory
https://bugs.webkit.org/show_bug.cgi?id=78800
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-16
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
The file is not specific to Cairo and used in other ports. Move it into
common space.
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- Target.pri:
- platform/graphics/OpenGLShims.cpp: Renamed from Source/WebCore/platform/graphics/cairo/OpenGLShims.cpp.
(WebCore):
(WebCore::openGLFunctionTable):
(WebCore::getProcAddress):
(WebCore::lookupOpenGLFunctionAddress):
(WebCore::initializeOpenGLShims):
- platform/graphics/OpenGLShims.h: Renamed from Source/WebCore/platform/graphics/cairo/OpenGLShims.h.
(WebCore):
(_OpenGLFunctionTable):
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
- platform/graphics/opengl/TextureMapperGL.cpp:
- platform/graphics/qt/Extensions3DQt.cpp:
- platform/graphics/qt/GraphicsContext3DQt.cpp:
Source/WebKit2:
- UIProcess/qt/LayerTreeHostProxyQt.cpp: Adjust to changed OpenGLShims.h
location - no more cairo prefix needed.
- 9:00 AM Changeset in webkit [107944] by
-
- 1 edit10 adds in trunk/LayoutTests
Unreviewed, GTK baselines for new SVG and fast/ tests.
- platform/gtk/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
- platform/gtk/fast/css/font-face-weight-matching-expected.txt: Added.
- platform/gtk/fast/js/constructor-length-expected.txt: Added.
- platform/gtk/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
- platform/gtk/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
- platform/gtk/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
- platform/gtk/svg/text/ems-display-none-expected.txt: Added.
- platform/gtk/svg/text/exs-display-none-expected.txt: Added.
- platform/gtk/svg/text/text-fill-opacity-expected.txt: Added.
- platform/gtk/svg/text/tspan-dynamic-positioning-expected.txt: Added.
- 8:53 AM Changeset in webkit [107943] by
-
- 7 edits in trunk/Source
[Qt][WK2] Allow opaque tiles
https://bugs.webkit.org/show_bug.cgi?id=78809
Source/WebCore:
Add a supportsAlpha property to TiledBackingStore.
We invalidate all the tiles if that property changes, because the buffers need to be
recreated in a different format.
Reviewed by Kenneth Rohde Christiansen.
No behavior changes.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setSupportsAlpha):
(WebCore):
- platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
(WebCore::TiledBackingStore::supportsAlpha):
Source/WebKit2:
Set the supportsAlpha flag for TiledBackingStore when the layer has contentsOpaque enabled.
Use the flag for ShareableBitmaps created by TiledBackingStore.
For now this will not have impact on performance/memory, because we allocate the same type
of buffers for opaque and transparent tiles.
Reviewed by Kenneth Rohde Christiansen.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setContentsOpaque):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::createBackingStore):
(WebCore):
(WebCore::WebGraphicsLayer::updateContentBuffers):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):
- WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
- 8:46 AM Changeset in webkit [107942] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline.
- platform/gtk/fast/table/027-expected.txt:
- platform/gtk/fast/table/027-vertical-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug14929-expected.txt:
- 8:41 AM Changeset in webkit [107941] by
-
- 6 edits in trunk/Source
[soup] Move important SoupSession feature initialization to WebCore
https://bugs.webkit.org/show_bug.cgi?id=68602
Reviewed by Martin Robinson.
Source/WebCore:
Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them. Added also out-of-the-box proxy support to WebCore.
No new tests required as we're just moving stuff from WebKit to
WebCore.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):
Source/WebKit/gtk:
Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them.
No new tests required as we're just moving stuff from WebKit to
WebCore.
- webkit/webkitglobals.cpp:
(webkitInit):
Source/WebKit2:
Moved content sniffer and decoder initialization from the
WebProcess to WebCore because network stuff will not work as
expected without them.
No new tests required as we're just moving stuff from the
WebProcess to WebCore.
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
- 8:37 AM Changeset in webkit [107940] by
-
- 3 edits1 delete in trunk
Web Inspector: remove free flow DOM editing experiment.
https://bugs.webkit.org/show_bug.cgi?id=78813
Reviewed by Yury Semikhatsky.
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._markRevision):
- 8:32 AM Changeset in webkit [107939] by
-
- 2 edits1 add in trunk/LayoutTests
[GTK] fast/events/drag-dataTransfer-live-attributes.html fails
https://bugs.webkit.org/show_bug.cgi?id=78818
Unreviewed, rebaseline the test and unskip, as advised by Daniel Cheng.
- platform/gtk/Skipped:
- platform/gtk/fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.
- 8:15 AM Changeset in webkit [107938] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, skipping 2 new test failures and unskipping some
needing rebaselining.
- platform/gtk/Skipped:
- platform/gtk/test_expectations.txt:
- 8:15 AM Changeset in webkit [107937] by
-
- 2 edits in trunk/Source/WebCore
WinCE build fix after r107453.
- platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::isInBounds): Use fabs() instead of abs().
- 7:48 AM Changeset in webkit [107936] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r107869 and skip a failing test.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 7:38 AM Changeset in webkit [107935] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: explicitly mark undoable state from the front-end.
https://bugs.webkit.org/show_bug.cgi?id=78716
Reviewed by Vsevolod Vlasov.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
- inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::redo):
- inspector/InspectorHistory.h:
(InspectorHistory):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype.setStyleSheetText):
(WebInspector.CSSProperty.prototype.setText.callback):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setDisabled.callback):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.prototype.setText):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._markRevision):
(WebInspector.DOMAgent.prototype.get markUndoableState):
- 7:36 AM Changeset in webkit [107934] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: revert 'modification of DOM upon single click for selected nodes'.
https://bugs.webkit.org/show_bug.cgi?id=78717
Reviewed by Vsevolod Vlasov.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.onattach):
- 7:34 AM Changeset in webkit [107933] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: move style disable checkboxes to the left
https://bugs.webkit.org/show_bug.cgi?id=78780
Reviewed by Vsevolod Vlasov.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._handleSelectorDoubleClick):
(WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/elementsPanel.css:
(.styles-section.matched-styles .properties):
(.styles-section.matched-styles .properties li):
(.styles-section .properties li.parent::before):
(.styles-section .properties li.parent.expanded::before):
(.styles-section.matched-styles .properties li.parent .expand-element):
(.styles-section.matched-styles .properties li.parent.expanded .expand-element):
(.styles-section.computed-style .properties li.parent::before):
(.styles-section.computed-style .properties li.parent.expanded::before):
(.styles-section.matched-styles:not(.read-only):hover .properties .enabled-button):
(.styles-section.matched-styles:not(.read-only) .properties li.disabled .enabled-button):
(.styles-section .properties .enabled-button):
(.styles-section.matched-styles .properties ol.expanded):
- inspector/front-end/treeoutline.js:
(TreeElement.treeElementDoubleClicked):
- 7:32 AM Changeset in webkit [107932] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: show memory counter graphics when switching to memory view
https://bugs.webkit.org/show_bug.cgi?id=78808
Switching to memory view in timeline will display memory counters. Counter
graphics know show fair data without approximations between sampling points.
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._calculateVisibleIndexes):
(WebInspector.MemoryStatistics.prototype._calculateXValues):
(WebInspector.MemoryStatistics.prototype._drawPolyline):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._timelinesOverviewItemSelected):
(WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):
- 7:16 AM Changeset in webkit [107931] by
-
- 2 edits in trunk/Tools
Add new Qt performance tester bot to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=78795
Reviewed by Adam Roben.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 6:58 AM Changeset in webkit [107930] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectations update.
- platform/chromium/test_expectations.txt:
- 6:23 AM Changeset in webkit [107929] by
-
- 17 edits in trunk
Web Inspector: [heap snapshot] It could be useful to have access to the selected heap object from the console.
https://bugs.webkit.org/show_bug.cgi?id=78496
Reviewed by Yury Semikhatsky.
Source/WebCore:
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::inspectedObject):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectedObjectCallback):
- inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::InspectableObject::get):
(WebCore):
(WebCore::InjectedScriptHost::addInspectedObject):
(WebCore::InjectedScriptHost::clearInspectedObjects):
(WebCore::InjectedScriptHost::inspectedObject):
- inspector/InjectedScriptHost.h:
(InspectableObject):
(WebCore::InjectedScriptHost::InspectableObject::~InspectableObject):
(InjectedScriptHost):
- inspector/InjectedScriptHost.idl:
- inspector/InjectedScriptSource.js:
(.):
- inspector/Inspector.json:
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::domContentLoadedEventFired):
- inspector/InspectorConsoleAgent.cpp:
(InspectableHeapObject):
(WebCore::InspectableHeapObject::InspectableHeapObject):
(WebCore::InspectableHeapObject::get):
(WebCore):
(WebCore::InspectorConsoleAgent::addInspectedHeapObject):
- inspector/InspectorConsoleAgent.h:
(InspectorConsoleAgent):
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::resetState):
- inspector/PageConsoleAgent.cpp:
(InspectableNode):
(WebCore::InspectableNode::InspectableNode):
(WebCore::InspectableNode::get):
(WebCore):
(WebCore::PageConsoleAgent::addInspectedNode):
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._selectionChanged):
(WebInspector.DetailedHeapshotView.prototype._inspectedObjectChanged):
LayoutTests:
- inspector/protocol/console-agent-expected.txt:
- inspector/protocol/console-agent.html:
- 5:59 AM Changeset in webkit [107928] by
-
- 2 edits2 adds in trunk/LayoutTests
[chromium] Rebaseline after r107881
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Added.
- 5:48 AM Changeset in webkit [107927] by
-
- 4 edits1 move8 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #21 of N.
- platform/chromium-linux-x86/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
- platform/chromium-linux/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png:
- platform/chromium-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png:
- platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
- platform/chromium-win-vista/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
- platform/chromium-win-xp/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
- platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
- platform/mac/fast/images/color-jpeg-with-color-profile-expected.png: Renamed from LayoutTests/fast/images/color-jpeg-with-color-profile-expected.png.
- platform/qt/fast/images/color-jpeg-with-color-profile-expected.txt: Removed.
- 5:46 AM Changeset in webkit [107926] by
-
- 6 edits in trunk/Source/WebCore
Add support for unsigned long[] to idl bindings to JSC.
https://bugs.webkit.org/show_bug.cgi?id=78210
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-16
Reviewed by Kentaro Hara.
Add support for unsigned long[] parameter type in idl.
This patch adds support just for unsigned long[] parameter type.
(support for other types of array should be done in another patch.)
tests added to TestObj.idl.
- bindings/js/JSDOMBinding.h:
(WebCore::jsUnsignedLongArrayToVector):
- bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(JSValueToNative):
(NativeToJSValue):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongArray):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/TestObj.idl:
- 5:30 AM Changeset in webkit [107925] by
-
- 15 edits7 adds in trunk
Web Inspector: [InspectorIndexedDB] Add IndexedDB TreeElement to resources panel.
https://bugs.webkit.org/show_bug.cgi?id=78609
Reviewed by Yury Semikhatsky.
Source/WebCore:
Added IndexedDB tree element to resources panel (behind experimental setting).
Test is currently disabled, since we don't run tests with experiments enabled.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- inspector/front-end/Images/indexedDB.png: Added.
- inspector/front-end/Images/indexedDBIndex.png: Added.
- inspector/front-end/Images/indexedDBObjectStore.png: Added.
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype.refreshDatabase):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._originAddedToFrame):
(WebInspector.IndexedDBModel.prototype._originRemoved):
(WebInspector.IndexedDBModel.prototype._databaseAdded):
(WebInspector.IndexedDBModel.prototype._databaseRemoved):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.Frame):
(WebInspector.IndexedDBModel.DatabaseId):
(WebInspector.IndexedDBModel.DatabaseId.prototype.equals):
(WebInspector.IndexedDBModel.Database):
(WebInspector.IndexedDBModel.Index):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.IndexedDBTreeElement):
(WebInspector.IndexedDBTreeElement.prototype.onexpand):
(WebInspector.IndexedDBTreeElement.prototype._createIndexedDBModel):
(WebInspector.IndexedDBTreeElement.prototype.refreshIndexedDB):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBLoaded):
(WebInspector.IndexedDBTreeElement.prototype._idbDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBIndexTreeElement):
(WebInspector.IDBIndexTreeElement.prototype.update):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/resourcesPanel.css:
(.indexed-db-storage-tree-item .icon):
(.indexed-db-object-store-storage-tree-item .icon):
(.indexed-db-index-storage-tree-item .icon):
LayoutTests:
- http/tests/inspector/indexeddb/database-data-expected.txt:
- http/tests/inspector/indexeddb/database-data.html:
- http/tests/inspector/indexeddb/database-names-expected.txt:
- http/tests/inspector/indexeddb/database-structure-expected.txt:
- http/tests/inspector/indexeddb/database-structure.html:
- http/tests/inspector/indexeddb/indexeddb-test.js:
(initialize_IndexedDBTest.InspectorTest.dumpIndexedDBTree):
(initialize_IndexedDBTest.InspectorTest.evaluateWithCallback):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer.consoleMessageOverride):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer):
(createDatabase.closeDatabase):
(createDatabase):
(deleteDatabase):
- http/tests/inspector/indexeddb/resources-panel-expected.txt: Added.
- http/tests/inspector/indexeddb/resources-panel.html_disabled: Added.
- http/tests/inspector/indexeddb/resources/without-indexed-db.html: Added.
- 5:07 AM Changeset in webkit [107924] by
-
- 2 edits2 adds in trunk/LayoutTests
2012-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing results for Lion, and regenerate one test result with Lion,
so my baseline passes again with --tolerance 0 -p svg.
- platform/mac/svg/text/text-fill-opacity-expected.png: Added.
- platform/mac/svg/text/text-fill-opacity-expected.txt: Added.
- platform/mac/svg/text/tspan-dynamic-positioning-expected.png:
- 4:58 AM Changeset in webkit [107923] by
-
- 4 edits6 adds in trunk
REGRESSION (Safari 5.0.5 - 5.1): No animation on svg-wow.org/text-effects/text-effects.xhtml
https://bugs.webkit.org/show_bug.cgi?id=65072
Reviewed by Zoltan Herczeg.
Source/WebCore:
Fix EMS/EXS length resolving, when the target context has no renderer, eg.
<text display="none" dy="1em">ABC</text>, myText.dy.baseVal.getItem(0).value()
currently throws, even if <text> has a parent, we could use to resolve the length.
Always fall-back to parent context, to resolve EMS/EXS units, instead of ignoring it.
The current behaviour stays the same, if the target element is not in the document,
then we really can't resolve lengths like this.
Tests: svg/text/ems-display-none.svg
svg/text/exs-display-none.svg
- svg/SVGLengthContext.cpp:
(WebCore::renderStyleForLengthResolving):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToEMS):
(WebCore::SVGLengthContext::convertValueFromEMSToUserUnits):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToEXS):
(WebCore::SVGLengthContext::convertValueFromEXSToUserUnits):
LayoutTests:
- platform/chromium/test_expectations.txt:
- platform/mac/svg/text/ems-display-none-expected.png: Added.
- platform/mac/svg/text/ems-display-none-expected.txt: Added.
- platform/mac/svg/text/exs-display-none-expected.png: Added.
- platform/mac/svg/text/exs-display-none-expected.txt: Added.
- svg/text/ems-display-none.svg: Added.
- svg/text/exs-display-none.svg: Added.
- 4:46 AM Changeset in webkit [107922] by
-
- 2 edits in trunk/Source/WebCore
Build fix for Qt 5 without QtWidgets.
Reviewed by Tor Arne Vestbø.
The reason why QGLContext is included in Extensions3DQt.cpp is to
achieve an implicit gl.h inclusion (needed for GL_FALSE). This patch
replaces the inclusion with the OpenGLShims.h inclusions, which has
the necessary #ifdefs in place to pull in gl.h with Qt 5 without QtWidgets.
- platform/graphics/qt/Extensions3DQt.cpp:
- 4:15 AM Changeset in webkit [107921] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Refactor CCLayerTreeHostCommon: create helper function for complex boolean condition
https://bugs.webkit.org/show_bug.cgi?id=78539
Reviewed by James Robinson.
This change should introduce no change in behavior, and its
expected behavior is already covered by existing tests.
In calculateDrawTransformsAndVisibility, there is a complex
boolean condition that indicates whether we should create a
RenderSurface or not. This patch pulls out that boolean logic,
and wraps it in a helper function for much better readability.
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::layerShouldBeSkipped):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
- 4:11 AM Changeset in webkit [107920] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [refactoring] move timeline overview sidebar creation to TimelineOverviewPane
https://bugs.webkit.org/show_bug.cgi?id=78782
Reviewed by Vsevolod Vlasov.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.showTimelines):
(WebInspector.TimelineOverviewPane.prototype.showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.sidebarResized):
- 3:59 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 3:58 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 3:56 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 3:51 AM BuildingQt5OnHarmattan edited by
- (diff)
- 3:50 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 3:50 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 3:41 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 3:12 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 3:05 AM Changeset in webkit [107919] by
-
- 6 edits in trunk/Source/WebCore
Share font-family CSS values through CSSValuePool.
<http://webkit.org/b/78604>
Reviewed by Darin Adler.
Cache and share FontFamilyValue instances in the per-document CSSValuePool.
This reduces memory consumption by 248 kB on the Moz page cycler (64-bit)
and avoids a bunch of extra work.
This is a regression from the recent attribute style refactoring; previously
the mapped attribute declaration table would ensure that multiple 'font'
elements with the same 'face' value would share the same FontFamilyValue.
We're not yet sharing the entire CSSValueList returned by parseFontFamily()
but this is a step on the way there.
- css/FontFamilyValue.cpp:
- css/FontFamilyValue.h:
Removed appendSpaceSeparated(), making FontFamilyValue immutable.
- css/CSSParser.cpp:
(FontFamilyValueBuilder):
(WebCore::FontFamilyValueBuilder::FontFamilyValueBuilder):
(WebCore::FontFamilyValueBuilder::add):
(WebCore::FontFamilyValueBuilder::commit):
(WebCore::CSSParser::parseFontFamily):
Refactor parseFontFamily() to defer creation of FontFamilyValue until
the whole family name is known. Added a little helper class to avoid
code duplication.
- css/CSSValuePool.h:
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
Added a FontFamilyValue cache to CSSValuePool. All values are tied to
the lifetime of the pool.
- 2:53 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 2:50 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 2:47 AM Changeset in webkit [107918] by
-
- 2 edits in trunk/Source/WebKit/qt
Unreviewed brown-paper bag build fix.
- WebCoreSupport/WebEventConversion.cpp:
(WebCore::WebKitPlatformWheelEvent::WebKitPlatformWheelEvent):
- 2:46 AM Changeset in webkit [107917] by
-
- 2 edits in trunk/Source/WebKit/chromium
Build Fix: R107894 breaks Chromium Linux Build.
https://bugs.webkit.org/show_bug.cgi?id=78790
WebDragDataPrivate::types, inherited from ChromiumDataObject, returns PassRef<DOMStringList> since r107894. However, WebDragData expected to get old return value type HashSet<String>.
Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-02-16
Reviewed by Kent Tamura.
- src/WebDragData.cpp:
(WebKit::WebDragData::items): Use RefPtr<DOMStringList> rather than HashSet<String> for value of m_private->types().
- 2:37 AM SettingUpDevelopmentEnvironmentForN9 edited by
- No need to source, as build-sources does that (diff)
- 2:35 AM SettingUpDevelopmentEnvironmentForN9 edited by
- Update instructions to use sysroot (diff)
- 2:34 AM Changeset in webkit [107916] by
-
- 5 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 2:31 AM Changeset in webkit [107915] by
-
- 9 edits2 adds in trunk
[Qt] Move event conversion functions from WebCore to WebKit
https://bugs.webkit.org/show_bug.cgi?id=78788
Reviewed by Kenneth Rohde Christiansen.
.:
- Source/api.pri: Add new files to the build.
Source/WebCore:
Move QtWidgets dependent mouse event constructors out of WebCore
into WebKit, similar to the web event conversions of WebKit2.
- Target.pri:
- platform/PlatformMouseEvent.h:
(PlatformMouseEvent):
- platform/PlatformWheelEvent.h:
(PlatformWheelEvent):
Source/WebKit/qt:
Move QtWidgets dependent mouse event constructors out of WebCore
into WebKit, similar to the web event conversions of WebKit2.
- Api/qwebpage.cpp:
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPage::swallowContextMenuEvent):
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
- WebCoreSupport/WebEventConversion.cpp: Added.
(WebCore):
(WebCore::mouseEventModifiersFromQtKeyboardModifiers):
(WebCore::mouseEventTypeAndMouseButtonFromQEvent):
(WebKitPlatformMouseEvent):
(WebCore::WebKitPlatformMouseEvent::WebKitPlatformMouseEvent):
(WebCore::convertMouseEvent):
(WebKitPlatformWheelEvent):
(WebCore::WebKitPlatformWheelEvent::applyDelta):
(WebCore::WebKitPlatformWheelEvent::WebKitPlatformWheelEvent):
(WebCore::convertWheelEvent):
- WebCoreSupport/WebEventConversion.h: Added.
(WebCore):
- 2:28 AM Changeset in webkit [107914] by
-
- 7 edits3 adds in trunk/Source
[Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=73215
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-02-16
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit/qt:
Adding a class to access security information data
(e.g. port/scheme/etc),
while allowing it to be handled in QML side.
- declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):
Source/WebKit2:
Introducing a new class to expose security origin information
(port/scheme/etc), useful for inspecting the origin of permission
requests.
- Target.pri:
- UIProcess/API/qt/qtwebsecurityorigin.cpp: Added.
(QtWebSecurityOrigin::QtWebSecurityOrigin):
(QtWebSecurityOrigin::~QtWebSecurityOrigin):
(QtWebSecurityOrigin::host):
(QtWebSecurityOrigin::scheme):
(QtWebSecurityOrigin::path):
(QtWebSecurityOrigin::port):
(QtWebSecurityOrigin::setHost):
(QtWebSecurityOrigin::setScheme):
(QtWebSecurityOrigin::setPath):
(QtWebSecurityOrigin::setPort):
- UIProcess/API/qt/qtwebsecurityorigin_p.h: Added.
- UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml: Added.
- UIProcess/API/qt/qwebpermissionrequest.cpp:
(QWebPermissionRequestPrivate::QWebPermissionRequestPrivate):
(QWebPermissionRequest::securityOrigin):
- UIProcess/API/qt/qwebpermissionrequest_p.h:
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
- 2:06 AM Changeset in webkit [107913] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed prospective Qt 4.8/Mac build fix.
Cast the PlatformWidget from QObject* to QWidget* to gain access
to QWidget methods.
- plugins/mac/PluginViewMac.mm:
(WebCore::nativeWindowFor):
(WebCore::cgHandleFor):
(WebCore::topLevelOffsetFor):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::invalidateRect):
- 2:06 AM Changeset in webkit [107912] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG should not check the types of arguments that are dead
https://bugs.webkit.org/show_bug.cgi?id=78518
Reviewed by Geoff Garen.
The argument checks are now elided if the corresponding SetArgument is dead,
and the abstract value of the argument is set to bottom (None, []). This is
performance neutral on the benchmarks we currently track.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
- 1:31 AM Changeset in webkit [107911] by
-
- 12 edits in trunk
<style scoped>: Implement scoped selector matching in the slow path
https://bugs.webkit.org/show_bug.cgi?id=77528
Source/WebCore:
Added scope information to SelectorCheckingContext, SelectorChecker methods and CSSStyleSelector methods.
Added matchOptions struct to CSSStyleSelector similar to SelectorCheckingContext in SelectorChecker.
Adapted the calling sites.
Reviewed by Antti Koivisto.
No new tests. (extended existing tests)
- css/CSSStyleSelector.cpp:
(RuleData):
(RuleSet):
(WebCore::CSSStyleSelector::determineScopingElement):
(WebCore::CSSStyleSelector::collectMatchingRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForRegion):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::matchAuthorRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
(MatchOptions):
(WebCore::CSSStyleSelector::MatchOptions::MatchOptions):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
(SelectorCheckingContext):
(SelectorChecker):
LayoutTests:
Extended existing <style scoped> tests to also verify that selector matching doesn't exceed the scoping element.
Reviewed by Antti Koivisto.
- fast/css/style-scoped/style-scoped-basic-expected.txt:
- fast/css/style-scoped/style-scoped-basic.html:
- fast/css/style-scoped/style-scoped-remove-scoped-expected.txt:
- fast/css/style-scoped/style-scoped-remove-scoped.html:
- fast/css/style-scoped/style-scoped-set-scoped-expected.txt:
- fast/css/style-scoped/style-scoped-set-scoped.html:
- 1:15 AM Changeset in webkit [107910] by
-
- 8 edits1 add2 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #20 of N.
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Removed.
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/chromium/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 12:50 AM Changeset in webkit [107909] by
-
- 62 edits20 adds20 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #19 of N.
- platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
- platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png: Removed.
- platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium/test_expectations.txt:
- 12:44 AM Changeset in webkit [107908] by
-
- 2 edits in trunk/Tools
Disable inspector on WinCE.
Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
- Scripts/build-webkit:
- 12:42 AM Changeset in webkit [107907] by
-
- 4 edits in trunk/Source
Source/WebKit: [CMake] Add missing include directories.
- CMakeLists.txt:
Source/WebKit2: [CMake] Add missing include directories.
- CMakeLists.txt:
- 12:40 AM Changeset in webkit [107906] by
-
- 2 edits in trunk/Tools
WinCE build fix after r107656.
Disable FTPDIR on WinCE, since it does not compile there.
- Scripts/build-webkit:
- 12:31 AM Changeset in webkit [107905] by
-
- 9 edits1 add2 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #18 of N.
- platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
- platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
- platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
- platform/chromium/tables/mozilla_expected_failures/other/test4-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 12:27 AM WebKitIDL edited by
- (diff)
- 12:26 AM Changeset in webkit [107904] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Document that local paths in html loaded with loadHTML might cause the web process to terminate
https://bugs.webkit.org/show_bug.cgi?id=78719
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebView.cpp:
- 12:22 AM Changeset in webkit [107903] by
-
- 14 edits4 adds4 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #17 of N.
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png: Added.
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png: Removed.
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium/test_expectations.txt:
- 12:13 AM Changeset in webkit [107902] by
-
- 29 edits2 moves10 adds14 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #16 of N.
- platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug5797-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug4093-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug4284-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug4427-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug56563-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug5797-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug6404-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29314-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2981-2-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4093-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4284-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4427-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug50695-2-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56563-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug5797-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6404-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug50695-2-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.png: Removed.
- platform/chromium-win/tables/mozilla/bugs/bug29314-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug50695-2-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug5797-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
- platform/chromium/tables/mozilla/bugs/bug56563-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug29314-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
- tables/mozilla/bugs/bug29314-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug29314-expected.txt.
- tables/mozilla/bugs/bug50695-2-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug50695-2-expected.txt.
- 12:01 AM Changeset in webkit [107901] by
-
- 13 edits2 moves5 adds9 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #15 of N.
- platform/chromium-linux/tables/mozilla/bugs/bug12908-1-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug12908-1-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1271-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-1-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug13169-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1271-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug13169-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Removed.
- platform/chromium-win/tables/mozilla/bugs/bug1271-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug12908-1-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug13169-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium/test_expectations.txt:
- platform/mac/tables/mozilla/bugs/bug1271-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug13169-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug1271-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug13169-expected.txt: Removed.
- tables/mozilla/bugs/bug1271-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug1271-expected.txt.
- tables/mozilla/bugs/bug13169-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug13169-expected.txt.
Feb 15, 2012:
- 11:50 PM Changeset in webkit [107900] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix for !ENABLE(CSS_FILTERS) after r106593.
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
- 11:39 PM Changeset in webkit [107899] by
-
- 32 edits in trunk/Source/WebCore
Move the context invalidation code out from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=78589
Reviewed by Ryosuke Niwa.
StylePropertySet should be independent of its context so that they can in the future
be shared between documents. The context invalidation code should move to the CSSOM wrapper.
Parent rule and parent element pointers move to the CSSOM wrapper classes.
The wrapper is responsible of invalidating the element or document style on mutation.
In case of internal mutation of style attribute, StyledElement takes care of the
invalidation.
The StylePropertySet will still have a pointer to the context stylesheet so the patch
doesn't actually reduce memory usage. That pointer will be factored out later.
- css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::~CSSFontFaceRule):
- css/CSSFontFaceRule.h:
(WebCore::CSSFontFaceRule::style):
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::~CSSPageRule):
- css/CSSPageRule.h:
(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::setDeclaration):
- css/CSSParser.cpp:
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::~CSSStyleRule):
- css/CSSStyleRule.h:
(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::setDeclaration):
- css/StylePropertySet.cpp:
(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::parentElement):
(WebCore::PropertySetCSSStyleDeclaration::clearParentRule):
(WebCore::PropertySetCSSStyleDeclaration::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::parentRule):
(WebCore::RuleCSSStyleDeclaration::clearParentRule):
(WebCore):
(InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::parentElement):
(WebCore::InlineCSSStyleDeclaration::clearParentElement):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::addParsedProperty):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copy):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::StylePropertySet::ensureRuleCSSStyleDeclaration):
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):
(WebCore::StylePropertySet::clearParentRule):
(WebCore::StylePropertySet::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::RuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::InlineCSSStyleDeclaration::setNeedsStyleRecalc):
- css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):
(WebCore::StylePropertySet::useStrictParsing):
(WebCore::StylePropertySet::contextStyleSheet):
(WebCore::StylePropertySet::setContextStyleSheet):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::~WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::setDeclaration):
- css/WebKitCSSKeyframeRule.h:
(WebCore::WebKitCSSKeyframeRule::style):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureInlineStyleDecl):
(WebCore::ElementAttributeData::destroyInlineStyleDecl):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/StyledElement.cpp:
(WebCore::StyledElement::insertedIntoDocument):
(WebCore):
(WebCore::StyledElement::removedFromDocument):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::updateAttributeStyle):
- dom/StyledElement.h:
(StyledElement):
(WebCore::StyledElement::destroyInlineStyleDecl):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):
(WebCore::DeleteButtonController::hide):
- editing/Editor.cpp:
(WebCore::Editor::applyEditingStyleToElement):
- editing/RemoveCSSPropertyCommand.cpp:
(WebCore::RemoveCSSPropertyCommand::doApply):
(WebCore::RemoveCSSPropertyCommand::doUnapply):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::updateColorSwatch):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::restoreImageSize):
(WebCore::ImageDocument::windowSizeChanged):
- html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
(WebCore::ValidationMessage::buildBubbleTree):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlElement::show):
(WebCore::MediaControlElement::hide):
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
(WebCore::MediaControlInputElement::show):
(WebCore::MediaControlInputElement::hide):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
- html/shadow/MeterShadowElement.cpp:
(WebCore::MeterValueElement::setWidthPercentage):
- html/shadow/ProgressShadowElement.cpp:
(WebCore::ProgressValueElement::setWidthPercentage):
- html/shadow/SliderThumbElement.cpp:
(WebCore::TrackLimiterElement::create):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
- 11:39 PM Changeset in webkit [107898] by
-
- 21 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r107814.
- platform/qt/css3/filters/effect-blur-hw-expected.png:
- platform/qt/css3/filters/effect-blur-hw-expected.txt:
- platform/qt/css3/filters/effect-combined-expected.png:
- platform/qt/css3/filters/effect-combined-expected.txt:
- platform/qt/css3/filters/effect-combined-hw-expected.png:
- platform/qt/css3/filters/effect-combined-hw-expected.txt:
- platform/qt/css3/filters/effect-drop-shadow-hw-expected.png:
- platform/qt/css3/filters/effect-drop-shadow-hw-expected.txt:
- platform/qt/css3/filters/effect-grayscale-hw-expected.png:
- platform/qt/css3/filters/effect-grayscale-hw-expected.txt:
- platform/qt/css3/filters/effect-hue-rotate-hw-expected.png:
- platform/qt/css3/filters/effect-hue-rotate-hw-expected.txt:
- platform/qt/css3/filters/effect-invert-hw-expected.png:
- platform/qt/css3/filters/effect-invert-hw-expected.txt:
- platform/qt/css3/filters/effect-opacity-hw-expected.png:
- platform/qt/css3/filters/effect-opacity-hw-expected.txt:
- platform/qt/css3/filters/effect-saturate-hw-expected.png:
- platform/qt/css3/filters/effect-saturate-hw-expected.txt:
- platform/qt/css3/filters/effect-sepia-hw-expected.png:
- platform/qt/css3/filters/effect-sepia-hw-expected.txt:
- 11:38 PM Changeset in webkit [107897] by
-
- 2 edits in trunk
dataTransfer.types (HTML5 drag & drop) should return DOMStringList
https://bugs.webkit.org/show_bug.cgi?id=30416
Reviewed by Eric Seidel.
Source/WebCore:
This change breaks backwards compatibility; however, since Firefox only supported
event.dataTransfer.types.contains, sites already needed to check whether to use contains or
indexOf. Therefore, the net compatibility effect of this change should be minimal.
Test: fast/events/drag-dataTransfer-live-attributes.html
- bindings/js/JSClipboardCustom.cpp:
(WebCore):
- bindings/v8/custom/V8ClipboardCustom.cpp:
- dom/Clipboard.cpp:
(WebCore::Clipboard::hasStringOfType):
- dom/Clipboard.h:
(WebCore):
(Clipboard):
- dom/Clipboard.idl:
- platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
- platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
- platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::mayUpdateItems):
- platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
- platform/chromium/DragDataChromium.cpp:
(WebCore::containsHTML):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::asFragment):
- platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
- platform/efl/ClipboardEfl.h:
(ClipboardEfl):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
- platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
- platform/mac/ClipboardMac.h:
(ClipboardMac):
- platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
- platform/qt/ClipboardQt.h:
(ClipboardQt):
- platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
- platform/win/ClipboardWin.h:
(ClipboardWin):
- platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::types):
- platform/wx/ClipboardWx.h:
(ClipboardWx):
LayoutTests:
Add a test to document the fact that many dataTransfer attributes aren't live and return a
different object each time they're accessed. Also update tests to use contains() instead of
indexOf().
- editing/pasteboard/clipboard-customData.html:
- editing/pasteboard/onpaste-text-html-types.html:
- fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
- fast/events/drag-customData.html:
- fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.
- fast/events/drag-dataTransfer-live-attributes.html: Copied from LayoutTests/fast/events/drag-customData.html.
- http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js:
- http/tests/security/clipboard/script-tests/clipboard-file-access.js:
(checkForEventTransferType):
- 11:37 PM Changeset in webkit [107896] by
-
- 3 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r107606.
- WebCoreSupport/PlatformStrategiesWinCE.cpp:
(PlatformStrategiesWinCE::createPasteboardStrategy):
- WebCoreSupport/PlatformStrategiesWinCE.h:
(PlatformStrategiesWinCE):
- 11:28 PM Changeset in webkit [107895] by
-
- 2 edits in trunk
Repaint issues on changing 'viewBox' of inner SVG
https://bugs.webkit.org/show_bug.cgi?id=77903
Source/WebCore:
Patch by Bear Travis <betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.
Do not update the child viewbox/viewport transform to its parent
coordinate system until after layout has stored the old bounds for
repainting purposes.
Test: svg/repaint/inner-svg-change-viewBox-contract.svg
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):
(WebCore):
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
(WebCore::RenderSVGViewportContainer::localToParentTransform):
- rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::setNeedsTransformUpdate):
(RenderSVGViewportContainer):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged):
LayoutTests:
Adding test for 77903. When setting the viewbox on an inner svg
element causes the content to become smaller, make sure that the
area behind the content is redrawn.
Patch by Bear Travis <betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.
- platform/chromium/test_expectations.txt:
- svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
- svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
- svg/repaint/inner-svg-change-viewBox-contract.svg: Added.
- 11:26 PM Changeset in webkit [107894] by
-
- 32 edits1 copy1 add in trunk
dataTransfer.types (HTML5 drag & drop) should return DOMStringList
https://bugs.webkit.org/show_bug.cgi?id=30416
Reviewed by Eric Seidel.
Source/WebCore:
This change breaks backwards compatibility; however, since Firefox only supported
event.dataTransfer.types.contains, sites already needed to check whether to use contains or
indexOf. Therefore, the net compatibility effect of this change should be minimal.
Test: fast/events/drag-dataTransfer-live-attributes.html
- bindings/js/JSClipboardCustom.cpp:
(WebCore):
- bindings/v8/custom/V8ClipboardCustom.cpp:
- dom/Clipboard.cpp:
(WebCore::Clipboard::hasStringOfType):
- dom/Clipboard.h:
(WebCore):
(Clipboard):
- dom/Clipboard.idl:
- platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
- platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
- platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::mayUpdateItems):
- platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
- platform/chromium/DragDataChromium.cpp:
(WebCore::containsHTML):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::asFragment):
- platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
- platform/efl/ClipboardEfl.h:
(ClipboardEfl):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
- platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
- platform/mac/ClipboardMac.h:
(ClipboardMac):
- platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
- platform/qt/ClipboardQt.h:
(ClipboardQt):
- platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
- platform/win/ClipboardWin.h:
(ClipboardWin):
- platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::types):
- platform/wx/ClipboardWx.h:
(ClipboardWx):
LayoutTests:
Add a test to document the fact that many dataTransfer attributes aren't live and return a
different object each time they're accessed. Also update tests to use contains() instead of
indexOf().
- editing/pasteboard/clipboard-customData.html:
- editing/pasteboard/onpaste-text-html-types.html:
- fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
- fast/events/drag-customData.html:
- fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.
- fast/events/drag-dataTransfer-live-attributes.html: Copied from LayoutTests/fast/events/drag-customData.html.
- http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js:
- http/tests/security/clipboard/script-tests/clipboard-file-access.js:
(checkForEventTransferType):
- 11:16 PM Changeset in webkit [107893] by
-
- 6 edits3 adds in trunk
Repaint issues on changing 'viewBox' of inner SVG
https://bugs.webkit.org/show_bug.cgi?id=77903
Source/WebCore:
Patch by Bear Travis <betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.
Do not update the child viewbox/viewport transform to its parent
coordinate system until after layout has stored the old bounds for
repainting purposes.
Test: svg/repaint/inner-svg-change-viewBox-contract.svg
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):
(WebCore):
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
(WebCore::RenderSVGViewportContainer::localToParentTransform):
- rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::setNeedsTransformUpdate):
(RenderSVGViewportContainer):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged):
LayoutTests:
Adding test for 77903. When setting the viewbox on an inner svg
element causes the content to become smaller, make sure that the
area behind the content is redrawn.
Patch by Bear Travis <betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.
- platform/chromium/test_expectations.txt:
- svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
- svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
- svg/repaint/inner-svg-change-viewBox-contract.svg: Added.
- 11:14 PM Changeset in webkit [107892] by
-
- 5 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r107811.
- platform/qt/platform/qt/plugins/qt-qwidget-plugin-expected.txt:
- platform/qt/plugins/application-plugin-plugins-disabled-expected.txt:
- platform/qt/plugins/iframe-plugin-bgcolor-expected.txt:
- platform/qt/plugins/netscape-dom-access-expected.txt:
- 11:12 PM Changeset in webkit [107891] by
-
- 3 edits in trunk/Source/WebCore
Fix unused parameter warnings.
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setContentsScale:]):
- 11:05 PM Changeset in webkit [107890] by
-
- 2 edits in trunk/Source/WebKit
[BlackBerry] Remove ResourceHolderImpl.cpp from build system
https://bugs.webkit.org/show_bug.cgi?id=78779
Reviewed by George Staikos.
blackberry/Api/ResourceHolderImpl.cpp which hasn't been upstreamed
has been removed internally. So remove it from the build system.
- blackberry/CMakeListsBlackBerry.txt:
- 11:04 PM Changeset in webkit [107889] by
-
- 3 edits in trunk/Source/WebCore
Convert RenderFrameSet to LayoutUnits in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=78526
Reviewed by Eric Seidel.
Revert paintColumnBorder and paintRowBorder to IntRect and pixel snap in
paint before calling them. This way the rounding logic is contained in a
single place (in paint).
No new tests, no new functionality.
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
(WebCore::RenderFrameSet::paint):
(WebCore::RenderFrameSet::getCursor):
- rendering/RenderFrameSet.h:
(RenderFrameSet):
- 10:47 PM Changeset in webkit [107888] by
-
- 9 edits4 adds2 deletes in trunk/LayoutTests
[chromium] Unreviewed rebaseline after r107864.
- platform/chromium-mac-leopard/svg/batik/text/textDecoration-expected.png:
- platform/chromium-mac-leopard/svg/css/text-shadow-multiple-expected.png:
- platform/chromium-mac-leopard/svg/text/text-text-08-b-expected.png:
- platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png:
- platform/chromium-mac-snowleopard/compositing/plugins/composited-plugin-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/plugins/composited-plugin-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
- platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png:
- platform/chromium-mac-snowleopard/svg/text/text-text-08-b-expected.png:
- platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png:
- platform/chromium-mac/compositing/plugins/composited-plugin-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Removed.
- 10:40 PM Changeset in webkit [107887] by
-
- 16 edits5 adds in trunk/Source/WebCore
Add FractionalLayoutPoint/Size/Rect for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=76571
Reviewed by Eric Seidel.
Add fixed point versions of the Point, Size and Rect classes using
the new FractionalLayoutPoint type and.
FractionalLayoutPoint, FractionalLayoutSize and FractionalLayoutRect are
Point, Size and Rect implementations respectively using this new type.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/FractionalLayoutUnit.h:
Fixed a couple of typos and signed/unsigned bugs.
- platform/graphics/FloatPoint.cpp:
(WebCore::FloatPoint::FloatPoint):
Add explicit FloatPoint(FractionalLayoutPoint) constructor.
(WebCore::FloatPoint::move):
Add move(FractionalLayoutSize) implementation.
(WebCore::FloatPoint::moveBy):
Add moveBy(FractionalLayoutPoint) implementation.
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::FloatRect):
Add explicit FloatRectFractionalLayoutRect) constructor.
- platform/graphics/FloatRect.h:
(WebCore):
(FloatRect):
- platform/graphics/FloatSize.cpp:
(WebCore::FloatSize::FloatSize):
Add explicit FloatSize(FractionalLayoutSize) constructor.
- platform/graphics/FloatSize.h:
- platform/graphics/FractionalLayoutPoint.h: Added.
- platform/graphics/FractionalLayoutRect.cpp: Added.
- platform/graphics/FractionalLayoutRect.h: Added.
- platform/graphics/FractionalLayoutSize.cpp: Added.
- platform/graphics/FractionalLayoutSize.h: Added.
- platform/graphics/IntRect.cpp:
(WebCore::IntRect::IntRect):
Add explicit IntRect(FractionalLayoutRect) constructor.
- platform/graphics/IntRect.h:
- 10:34 PM WebKitIDL edited by
- (diff)
- 10:14 PM Changeset in webkit [107886] by
-
- 9 edits2 adds in trunk
[Mac] PasteboardMac.mm build fails
https://bugs.webkit.org/show_bug.cgi?id=78655
Reviewed by Enrica Casucci.
Source/WebCore:
This patch fixes the code to make a plain text for pasted file names.
The code should return a string of concatenated file names.
Test: editing/pasteboard/drag-files-to-editable-element.html
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::plainText):
LayoutTests:
The added test drops multiple files onto an editable element,
and checks if the filenames are inserted into the editable element.
- editing/pasteboard/drag-files-to-editable-element-expected.txt: Added.
- editing/pasteboard/drag-files-to-editable-element.html: Added.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wk2/Skipped:
- 10:10 PM Changeset in webkit [107885] by
-
- 2 edits in trunk/Source/WebCore
Another attempt at fixing the Snow Leopard build.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setContentsScale):
- 9:57 PM Changeset in webkit [107884] by
-
- 1 edit1 move3 adds1 delete in trunk/LayoutTests
[chromium] Unreviewed rebaseline after r107864.
- platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.txt: Added.
- platform/chromium-mac/fast/canvas/text-globalAlpha-expected.txt: Removed.
- platform/chromium-win/svg/text/text-fill-opacity-expected.png: Added.
- platform/chromium-win/svg/text/text-fill-opacity-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/text/text-fill-opacity-expected.txt.
- 9:42 PM Changeset in webkit [107883] by
-
- 6 edits2 adds in trunk
Add support for the translate attribute in html elements.
https://bugs.webkit.org/show_bug.cgi?id=78751
Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-15
Reviewed by Adam Barth.
The translate attribute is used to specify whether an element's
attribute values and the values of its Text node children are to be
translated when the page is localized, or whether to leave them
unchanged.
Details at http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#attr-translate
Source/WebCore:
Test: fast/dom/HTMLElement/translate.html
- html/HTMLAttributeNames.in:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::translateAttributeMode):
(WebCore):
(WebCore::HTMLElement::translate):
(WebCore::HTMLElement::setTranslate):
- html/HTMLElement.h:
(HTMLElement):
- html/HTMLElement.idl:
LayoutTests:
- fast/dom/HTMLElement/translate-expected.txt: Added.
- fast/dom/HTMLElement/translate.html: Added.
- 9:39 PM WebKitIDL edited by
- (diff)
- 9:29 PM Changeset in webkit [107882] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. compositing/culling/scrolled-within-boxshadow.html IMAGE failure.
- platform/chromium/test_expectations.txt:
- 9:09 PM Changeset in webkit [107881] by
-
- 16 edits3 adds in trunk
Source/WebCore: Add -webkit-overflow-scrolling CSS property
https://bugs.webkit.org/show_bug.cgi?id=78664
Patch by Sami Kyostila <skyostil@google.com> on 2012-02-15
Reviewed by Eric Seidel.
Add a CSS property indicating that an element with overflow scrolling
should follow the platform's behavior for touch scrollable user
interface objects. For instance, this property could enable momentum
scrolling for the element if that is the platform convention.
The property has two possible values: auto (default) and touch. The
former does not alter overflow scrolling behavior, while the latter
activates touch scrolling.
As a side effect, enabling touch scrolling also causes an element to
gain a stacking context. This is to allow the implementation to promote
the scrolling contents into a render layer, which can be translated more
efficiently.
This property was introduced with iOS 5 WebKit. Another implementation
is in Chrome for Android.
Test: platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
Source/WebKit/chromium: Enable -webkit-overflow-scrolling CSS property
https://bugs.webkit.org/show_bug.cgi?id=78664
Patch by Sami Kyostila <skyostil@google.com> on 2012-02-15
Reviewed by Eric Seidel.
- features.gypi:
LayoutTests: Add stacking context test for -webkit-overflow-scrolling CSS property
https://bugs.webkit.org/show_bug.cgi?id=78664
Patch by Sami Kyostila <skyostil@google.com> on 2012-02-15
Reviewed by Eric Seidel.
Make sure a stacking context is created for elements with touch overflow scrolling.
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: Added new property.
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: Ditto.
- platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Added.
- platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Added.
- platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Added.
- 8:49 PM Changeset in webkit [107880] by
-
- 21 edits in trunk/Source/WebCore
Add zeroLayoutUnit constant.
https://bugs.webkit.org/show_bug.cgi?id=78747
Reviewed by Eric Seidel.
Converting call sites where LayoutUnits and raw zeros are in ternary operations
and templatized function calls (like std::max and min) to use a new zeroLayoutUnit
constant instead of the raw zero.
No new tests. No change in behavior.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
- rendering/LayoutTypes.h:
(WebCore):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::adjustForUnsplittableChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageLogicalOffset):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::positionForPoint):
- rendering/RenderBox.h:
(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(RenderBox):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
- rendering/RenderFileUploadControl.cpp:
(WebCore::nodeWidth):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::listIndexAtOffset):
(WebCore::RenderListBox::verticalScrollbarWidth):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computePreferredLogicalWidths):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):
- rendering/RenderTable.h:
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::layout):
- 8:18 PM Changeset in webkit [107879] by
-
- 10 edits2 adds in trunk
Crash after trying to use FileReader in a document with null origin string
https://bugs.webkit.org/show_bug.cgi?id=78649
Reviewed by Enrica Casucci.
Source/WebCore:
Test: fast/files/null-origin-string.html
- fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::~FileReaderLoader):
HashMaps don't like empty keys, and they don't like removing keys that have never been added.
LayoutTests:
- fast/files/null-origin-string-expected.txt: Added.
- fast/files/null-origin-string.html: Added.
Dragging files is only implemented on a few platforms. Brought some order to skipped files
for these tests:
- platform/mac/Skipped: Bug 45576 has been fixed long ago; unskip the test.
- platform/efl/Skipped:
- platform/qt/Skipped:
Skipped the new tests.
- platform/gtk-wk2/Skipped:
- platform/mac-wk2/Skipped:
- platform/win-wk2/Skipped:
- platform/wk2/Skipped:
Skipped the new tests, and moved other tests using eventSender.beginDragWithFiles to a
central location. No WK2 port implements these yet, so we needn't maintain the lists
separately.
- 7:57 PM Changeset in webkit [107878] by
-
- 3 edits in trunk/Source/WebCore
Attempt to fix the Snow Leopard build.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::createTileLayer):
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setContentsScale:]):
- 7:57 PM Changeset in webkit [107877] by
-
- 2 edits in trunk/Tools
Build fix after r107863.
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
- 7:53 PM Changeset in webkit [107876] by
-
- 11 edits3 moves5 adds11 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #14 of N.
- platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug17138-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120107-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-2-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug17138-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug196870-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.png: Removed.
- platform/chromium-win/tables/mozilla/bugs/bug120107-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug12908-2-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug17138-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug196870-expected.png:
- platform/chromium/test_expectations.txt:
- platform/mac/tables/mozilla/bugs/bug120107-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug196870-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug120107-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug196870-expected.txt: Removed.
- tables/mozilla/bugs/bug120107-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug120107-expected.txt.
- tables/mozilla/bugs/bug12908-2-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug12908-2-expected.txt.
- tables/mozilla/bugs/bug196870-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug196870-expected.txt.
- 7:52 PM Changeset in webkit [107875] by
-
- 3 edits in trunk/Tools
[chromium] add linux dbg back to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=78752
Reviewed by Adam Barth.
This reflects the current linux debug bot name (there's only one bot).
I'm also remove the mac clang builder since it doesn't exist (mac
always uses clang now).
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- Scripts/webkitpy/layout_tests/port/builders.py:
- 7:32 PM Changeset in webkit [107874] by
-
- 7 edits in trunk/Source/WebCore
REGRESSION (r107836): fast/box-shadow/spread.html and fast/writing-mode/box-shadow-*.html tests failing
https://bugs.webkit.org/show_bug.cgi?id=78759
Reviewed by Simon Fraser.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::boxShadowCanBeAppliedToBackground): Added. Returns false if
paintFillLayer() would push a clip before painting the layer, thus preventing it from casting
its own shadow.
(WebCore::InlineFlowBox::paintBoxDecorations): Pass this as an additional parameter to
boxShadowShouldBeAppliedToBackground().
- rendering/InlineFlowBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Pass the InlineFlowBox along to
boxShadowShouldBeAppliedToBackground().
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground): Added an InlineFlowBox
parameter. If non-0, check boxShadowCanBeAppliedToBackground(). Also check for shadow spread,
and for the case of border radius with a background image, in which paintFillLayerExtended uses
clipping. Finally, fixed a bug in the for() loop for finding the last background layer which
was noticed by Tony Chang.
- rendering/RenderBoxModelObject.h:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::boxShadowShouldBeAppliedToBackground):
- rendering/RenderTableCell.h:
- 7:27 PM Changeset in webkit [107873] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstream WebPageGroupLoadDeferrer.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=78770
Reviewed by Rob Buis.
Initial upstreaming, no new tests.
- blackberry/Api/WebPageGroupLoadDeferrer.cpp: Added.
- blackberry/Api/WebPageGroupLoadDeferrer.h: Added.
- 7:18 PM Changeset in webkit [107872] by
-
- 3 edits in trunk/Tools
Add style check for ctype functions that are generally frowned upon in WebKit
https://bugs.webkit.org/show_bug.cgi?id=78748
Patch by Sam Weinig <sam@webkit.org> on 2012-02-15
Reviewed by Anders Carlsson.
Not every platform has DisallowCType.h to check for uses of the ctype.h
functions, so add a style check for them as well.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_ctype_functions):
(check_style):
(CppChecker):
Add check.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_ctype_fucntion):
Add checker.
- 7:16 PM Changeset in webkit [107871] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstream BlackBerry specific Web Inspector resources
https://bugs.webkit.org/show_bug.cgi?id=78727
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-02-15
Reviewed by Rob Buis.
- blackberry/WebCoreSupport/inspectorBB.html: Added.
- blackberry/WebCoreSupport/inspectorBB.js: Added.
():
(InspectorFrontendHost.copyText):
- 6:58 PM Changeset in webkit [107870] by
-
- 1 edit2 adds in trunk/Source/WebKit
Initial upstreaming of EditorClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78730
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-15
Reviewed by Rob Buis.
Initial upstreaming, no new tests.
- blackberry/WebCoreSupport/EditorClientBlackBerry.cpp: Added.
(WebCore):
(WebCore::EditorClientBlackBerry::EditorClientBlackBerry):
(WebCore::EditorClientBlackBerry::pageDestroyed):
(WebCore::EditorClientBlackBerry::shouldDeleteRange):
(WebCore::EditorClientBlackBerry::shouldShowDeleteInterface):
(WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
(WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientBlackBerry::enableSpellChecking):
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::isContinuousSpellCheckingEnabled):
(WebCore::EditorClientBlackBerry::toggleContinuousSpellChecking):
(WebCore::EditorClientBlackBerry::isGrammarCheckingEnabled):
(WebCore::EditorClientBlackBerry::toggleGrammarChecking):
(WebCore::EditorClientBlackBerry::spellCheckerDocumentTag):
(WebCore::EditorClientBlackBerry::shouldBeginEditing):
(WebCore::EditorClientBlackBerry::shouldEndEditing):
(WebCore::EditorClientBlackBerry::shouldInsertNode):
(WebCore::EditorClientBlackBerry::shouldInsertText):
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
(WebCore::EditorClientBlackBerry::shouldApplyStyle):
(WebCore::EditorClientBlackBerry::shouldMoveRangeAfterDelete):
(WebCore::EditorClientBlackBerry::didBeginEditing):
(WebCore::EditorClientBlackBerry::respondToChangedContents):
(WebCore::EditorClientBlackBerry::respondToChangedSelection):
(WebCore::EditorClientBlackBerry::didEndEditing):
(WebCore::EditorClientBlackBerry::respondToSelectionAppearanceChange):
(WebCore::EditorClientBlackBerry::didWriteSelectionToPasteboard):
(WebCore::EditorClientBlackBerry::didSetSelectionTypesForPasteboard):
(WebCore::EditorClientBlackBerry::registerCommandForUndo):
(WebCore::EditorClientBlackBerry::registerCommandForRedo):
(WebCore::EditorClientBlackBerry::clearUndoRedoOperations):
(WebCore::EditorClientBlackBerry::canUndo):
(WebCore::EditorClientBlackBerry::canRedo):
(WebCore::EditorClientBlackBerry::canCopyCut):
(WebCore::EditorClientBlackBerry::canPaste):
(WebCore::EditorClientBlackBerry::undo):
(WebCore::EditorClientBlackBerry::redo):
(KeyDownEntry):
(KeyPressEntry):
(WebCore::EditorClientBlackBerry::interpretKeyEvent):
(WebCore::EditorClientBlackBerry::handleKeyboardEvent):
(WebCore::EditorClientBlackBerry::handleInputMethodKeydown):
(WebCore::EditorClientBlackBerry::textFieldDidBeginEditing):
(WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
(WebCore::EditorClientBlackBerry::textDidChangeInTextField):
(WebCore::EditorClientBlackBerry::doTextFieldCommandFromEvent):
(WebCore::EditorClientBlackBerry::textWillBeDeletedInTextField):
(WebCore::EditorClientBlackBerry::textDidChangeInTextArea):
(WebCore::EditorClientBlackBerry::ignoreWordInSpellDocument):
(WebCore::EditorClientBlackBerry::learnWord):
(WebCore::EditorClientBlackBerry::checkSpellingOfString):
(WebCore::EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord):
(WebCore::EditorClientBlackBerry::checkGrammarOfString):
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
(WebCore::EditorClientBlackBerry::textChecker):
(WebCore::EditorClientBlackBerry::updateSpellingUIWithGrammarString):
(WebCore::EditorClientBlackBerry::updateSpellingUIWithMisspelledWord):
(WebCore::EditorClientBlackBerry::showSpellingUI):
(WebCore::EditorClientBlackBerry::spellingUIIsShowing):
(WebCore::EditorClientBlackBerry::getGuessesForWord):
(WebCore::EditorClientBlackBerry::willSetInputMethodState):
(WebCore::EditorClientBlackBerry::setInputMethodState):
- blackberry/WebCoreSupport/EditorClientBlackBerry.h: Added.
(WebKit):
(WebCore):
(EditorClientBlackBerry):
- 6:47 PM Changeset in webkit [107869] by
-
- 3 edits2 adds in trunk
Expose Window constructor
https://bugs.webkit.org/show_bug.cgi?id=78722
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/dom/Window/window-constructor-presence.html
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/Window/window-constructor-presence-expected.txt: Added.
- fast/dom/Window/window-constructor-presence.html: Added.
- 6:43 PM Changeset in webkit [107868] by
-
- 3 edits in trunk
[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=76546
Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2012-02-15
Reviewed by Simon Hausmann.
Resize the web view programatically because the declarative property binding
does not work. Seems like our qml environment is not initialized fully but it
needs more investigation.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):
- 6:41 PM Changeset in webkit [107867] by
-
- 6 edits in trunk/Tools
webkitpy: add a worker_args concept to start_worker()
https://bugs.webkit.org/show_bug.cgi?id=78572
Reviewed by Tony Chang.
This change replaces the three NRWT-specific arguments passed
through the broker to the worker with a generic WorkerArguments
wrapper class and a separate set_inline_arguments() call that can
be used to pass additional data to the worker when it is running
in the same process as the manager (this is needed for testing).
With the addition of set_inline_arguments() we also no longer
need to pass an optional argument to the worker.run() call.
Note that this method is *only* implemented on inline workers,
so calling this on a regular (child process) worker will result
in a runtime error.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(AbstractWorker.init):
(AbstractWorker.run):
(_ManagerConnection.start_worker):
(_InlineManager.start_worker):
(_InlineManager.set_inline_arguments):
(_InlineManager.run_message_loop):
(_MultiProcessManager.start_worker): Reworked signature.
(_WorkerConnection.init):
(_InlineWorkerConnection.init):
(_InlineWorkerConnection.set_inline_arguments): New method.
(_InlineWorkerConnection):
(_InlineWorkerConnection.run):
(_Process.run):
(_MultiProcessWorkerConnection.init):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker.init):
(_TestWorker.set_inline_arguments):
(_TestWorker.handle_test):
(_TestWorker.run):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
(_TestsMixin.test_unknown_message):
(InlineBrokerTests): New class for more testing.
(InlineBrokerTests.setUp):
(InlineBrokerTests.test_inline_arguments): New test.
(InterfaceTest.test_managerconnection_is_abstract):
(InterfaceTest.test_workerconnection_is_abstract):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(WorkerArguments):
(WorkerArguments.init):
(Worker.init):
(Worker.set_inline_arguments):
(Worker):
(Worker.run):
- Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
(WorkerTest.test_default_platform_in_worker):
- 6:25 PM Changeset in webkit [107866] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h
Readd std constructs for FractionalLayoutUnit on branch, for now
- 6:24 PM Changeset in webkit [107865] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/dom/ElementRareData.h
Fixing usages of INT_MAX with LayoutUnit max values.
- 6:23 PM WebKitIDL edited by
- (diff)
- 6:15 PM Changeset in webkit [107864] by
-
- 4 edits3 adds in trunk
fill-opacity does not render properly only on Chromium Mac.
https://bugs.webkit.org/show_bug.cgi?id=78624
Reviewed by Stephen White.
Source/WebCore:
Test: svg/text/text-fill-opacity.svg
- platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::drawGlyphs):
LayoutTests:
- platform/chromium-linux/svg/text/text-fill-opacity-expected.png: Added.
- platform/chromium-linux/svg/text/text-fill-opacity-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- svg/text/text-fill-opacity.svg: Added.
- 6:02 PM Changeset in webkit [107863] by
-
- 5 edits1 add in trunk/Source
[BlackBerry] Upstream WebPageClient.h
https://bugs.webkit.org/show_bug.cgi?id=78660
Reviewed by Antonio Gomes.
Source/WebCore:
Header inclusion fix, no new test.
- plugins/blackberry/PluginViewPrivateBlackBerry.h:
Add #include <BlackBerryPlatformIntRectRegion.h>
and #include <BlackBerryPlatformGraphics.h> because they
are being removed from WebKit/blackberry/Api/WebPageClient.h.
Source/WebKit:
Initial upstreaming, no new tests.
- blackberry/Api/BackingStore.cpp: Add #include <BlackBerryPlatformWindow.h> because this inclusion
is being removed from WebPageClient.h.
- blackberry/Api/WebPageClient.h: Added.
- blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Add #include <BlackBerryPlatformWindow.h>
because this inclusion is being removed from WebPageClient.h.
- 5:50 PM Changeset in webkit [107862] by
-
- 4 edits3 adds in trunk
REGRESSION(r105057): Dynamically changing <tspan> offsets is broken
https://bugs.webkit.org/show_bug.cgi?id=78385
<rdar://problem/10832932>
Reviewed by Simon Fraser.
Don't short-circuit buildLayoutAttributesIfNeeded if m_textPositions is already full;
we can't skip rebuilding the layout attributes, just walking the tree to acquire the
positioning lists (invalidation of positioning lists is already covered by textDOMChanged).
Test: svg/text/tspan-dynamic-positioning.svg
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded):
Add a test ensuring that changing the offset of a <tspan> post-load results in correct layout.
- platform/chromium/test_expectations.txt:
- platform/mac/svg/text/tspan-dynamic-positioning-expected.png: Added.
- platform/mac/svg/text/tspan-dynamic-positioning-expected.txt: Added.
- svg/text/tspan-dynamic-positioning.svg: Added.
- 5:35 PM Changeset in webkit [107861] by
-
- 9 edits in trunk/Source
MediaStream API: Removing SecurityContext from the embedder API
https://bugs.webkit.org/show_bug.cgi?id=73816
Reviewed by Darin Fisher.
Source/WebCore:
Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
- mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::PeerConnection):
- platform/mediastream/PeerConnectionHandler.h:
(WebCore):
(PeerConnectionHandler):
- platform/mediastream/gstreamer/PeerConnectionHandler.cpp:
(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
Source/WebKit/chromium:
- bridge/PeerConnectionHandler.cpp:
(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
- bridge/PeerConnectionHandlerInternal.cpp:
(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
- bridge/PeerConnectionHandlerInternal.h:
(WebCore):
(PeerConnectionHandlerInternal):
- public/platform/WebPeerConnectionHandler.h:
(WebPeerConnectionHandler):
(WebKit::WebPeerConnectionHandler::initialize):
- 5:29 PM Changeset in webkit [107860] by
-
- 10 edits in trunk/Source/JavaScriptCore
Ensure that the DFG JIT always plants a CodeOrigin when making calls
https://bugs.webkit.org/show_bug.cgi?id=78763
Reviewed by Gavin Barraclough.
Make all calls plant a CodeOrigin prior to the actual
call. Also clobbers the Interpreter with logic to ensure
that the interpreter always plants a bytecode offset.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(CallBeginToken):
(JSC::DFG::JITCompiler::beginJSCall):
(JSC::DFG::JITCompiler::beginCall):
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallFrame):
- interpreter/CallFrame.h:
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(ExecState):
(JSC::ExecState::setBytecodeOffsetForNonDFGCode):
(JSC::ExecState::codeOriginIndexForDFG):
- 5:19 PM Changeset in webkit [107859] by
-
- 5 edits in trunk
Source/WebCore: Fix test regressons from r107672.
https://bugs.webkit.org/show_bug.cgi?id=76564
Move setting CachedRawResource::m_identifer from
data() to setResponse(). WorkerScriptLoader depends
on the identifier being set correctly during setResponse()
in order to correctly mark itself as a ScriptResource in
the inspector.
Reviewed by Adam Barth.
Fixes several worker script loading tests.
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::data):
(WebCore::CachedRawResource::setResponse):
LayoutTests: Remove Skipped tests that were broken by r107672.
https://bugs.webkit.org/show_bug.cgi?id=76564
Reviewed by Adam Barth.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 5:06 PM Changeset in webkit [107858] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r107704.
http://trac.webkit.org/changeset/107704
https://bugs.webkit.org/show_bug.cgi?id=78486
Caused layout test crashes in debug builds.
Specific crashing tests:
fast/events/show-modal-dialog-onblur-onfocus.html
fast/harness/show-modal-dialog.html
inspector/console/console-long-eval-crash.html
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::runModal):
- 4:47 PM Changeset in webkit [107857] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed. regionOverflow tests are flaky in debug.
- platform/chromium/test_expectations.txt:
- 4:45 PM Changeset in webkit [107856] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: "Copy image" fails...copies image URL instead.
https://bugs.webkit.org/show_bug.cgi?id=78723
<rdar://problem/10869104>
During the refactoring of the Pasteboard class some code was lost.
When placing an NSImage in the NSPasteboard as NSTIFFPboardType, we need
to use the its TIFF representation.
Reviewed by Andy Estes.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeImage):
- 4:39 PM Changeset in webkit [107855] by
-
- 1 edit1 move in trunk/Source/WebKit
[BlackBerry] Upstream remaining classes in Api
https://bugs.webkit.org/show_bug.cgi?id=78644
Reviewed by Antonio Gomes.
No functionalities changed, no new tests.
- blackberry/Api/ActiveNodeContext.h: Renamed from Source/WebKit/blackberry/Api/BlackBerryContext.h.
- 4:27 PM Changeset in webkit [107854] by
-
- 16 edits2 copies in trunk/Source
[soup] Add support for multiple SoupSessions.
https://bugs.webkit.org/show_bug.cgi?id=77341
Source/WebCore:
Reviewed by Gustavo Noronha Silva.
Make the libsoup network backend support multiple SoupSessions. This is
accomplished by using the NetworkingContext classes, which now have a
`soupSession()' method when the libsoup backend is being used.
libsoup's ResourceHandle implementation now retrieves the SoupSession
via the NetworkingContext it receives instead of relying on
defaultSession(). defaultSession() is still used when a null
NetworkingContext is passed to ResourceHandle::start (for example, via
webkit_download_start).
The CookieJar implementation retrieves the SoupSession from the
NetworkingContext as much as possible as well -- the functions used by
WebKit2 could not be converted, though, as they seem to assume there is
only one shared cookie jar.
No new tests, covered by the existing ones.
- platform/network/NetworkingContext.h:
(NetworkingContext): Add soupSession() method if USE(SOUP) is set.
- platform/network/ResourceHandleInternal.h:
(ResourceHandleInternal):
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieJarForDocument):
(WebCore):
(WebCore::defaultCookieJar):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandleInternal::soupSession): Add method to retrieve
a SoupSession from a NetworkingContext and fallback to defaultSession()
if there's no valid NetworkingContext.
(WebCore):
(WebCore::ensureSessionIsInitialized): Only change or use the default
cookie jar if the SoupSession being changed is the default one.
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::cancel):
(WebCore::startNonHTTPRequest):
Source/WebKit/efl:
Add the necessary infrastructure to support multiple SoupSessions. Each
WebView now has a "session" property, which defaults to
ResourceHandle::defaultSession() and can be changed to another
SoupSession by the user.
Some API in ewk_network and ewk_view which required SoupSession to be a
valid type in the headers has now been moved inside #if USE(SOUP)
ifdefs so we can actually the required Soup header and avoid build
problems with duplicate typedefs.
- CMakeListsEfl.txt:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::createNetworkingContext):
- WebCoreSupport/FrameNetworkingContextEfl.cpp: Copied from Source/WebKit/efl/WebCoreSupport/FrameNetworkingContextEfl.h.
(WebCore):
(WebCore::FrameNetworkingContextEfl::create):
(WebCore::FrameNetworkingContextEfl::FrameNetworkingContextEfl):
(WebCore::FrameNetworkingContextEfl::soupSession):
- WebCoreSupport/FrameNetworkingContextEfl.h:
(FrameNetworkingContextEfl):
- ewk/ewk_cookies.h: Mention this API is only valid with the
default SoupSession.
- ewk/ewk_network.cpp:
(ewk_network_default_soup_session_get): Define only if USE(SOUP) is set.
- ewk/ewk_network.h: Ditto, and mention this API is only valid with the
default SoupSession.
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
- ewk/ewk_view.h:
():
Source/WebKit/gtk:
Reviewed by Gustavo Noronha Silva.
Adapt to the changes to FrameNetworkingContext in WebCore.
- GNUmakefile.am:
- WebCoreSupport/FrameNetworkingContextGtk.cpp: Copied from Source/WebKit/gtk/WebCoreSupport/FrameNetworkingContextGtk.h.
(WebKit):
(WebKit::FrameNetworkingContextGtk::soupSession): Always return ResourceHandle::defaultSession().
- WebCoreSupport/FrameNetworkingContextGtk.h:
(FrameNetworkingContextGtk):
- 4:08 PM Changeset in webkit [107853] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/platform/ScrollView.h
Removing unused methods conversion methods from ScrollView.
- 4:01 PM Changeset in webkit [107852] by
-
- 4 edits in trunk/Source/WebCore
The TileCache object should be deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=78757
<rdar://problem/10866161>
Reviewed by Sam Weinig.
Since the WebTileCacheLayer can be deleted on the scrolling thread, we need to make sure that the underlying
TileCache object is actually destroyed on the main thread.
- platform/graphics/ca/mac/TileCache.h:
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::~TileCache):
Assert that this object is being destroyed on the main thread.
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer dealloc]):
If dealloc is being called from a non-main thread, make sure to delete the tile cache object on the main thread.
- 3:58 PM Changeset in webkit [107851] by
-
- 14 edits in trunk/LayoutTests
[chromium] Unreviewed, rebasing tests after r107836.
- platform/chromium-linux-x86/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-linux/fast/transforms/shadows-expected.png:
- platform/chromium-mac-leopard/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-mac-leopard/fast/transforms/shadows-expected.png:
- platform/chromium-mac-snowleopard/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png:
- platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-win-xp/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
- platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-win/fast/transforms/shadows-expected.png:
- platform/chromium/test_expectations.txt:
- 3:54 PM Changeset in webkit [107850] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Roll DEPS to r122122
https://bugs.webkit.org/show_bug.cgi?id=78754
Unreviewed DEPS roll.
- DEPS:
- 3:47 PM Changeset in webkit [107849] by
-
- 2 edits in trunk/Source/WebCore
Scrolling Coordinator must be deleted on the main thread
https://bugs.webkit.org/show_bug.cgi?id=78756
<rdar://problem/10866167>
Reviewed by Sam Weinig.
ScrollingTree::invalidate will finish breaking the cycle between the scrolling coordinator and the
scrolling tree by dereffing the scrolling coordinator. We need to make sure that this happens on the main
thread because the scrolling coordinator expects to be destroyed from there.
- page/scrolling/ScrollingTree.cpp:
(WebCore::derefScrollingCoordinator):
(WebCore):
(WebCore::ScrollingTree::invalidate):
- 3:45 PM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 3:37 PM Changeset in webkit [107848] by
-
- 5 edits in trunk/Source/WebCore
Scrolling coordinator should handle pages being restored from the page cache
https://bugs.webkit.org/show_bug.cgi?id=78753
<rdar://problem/10866171>
Reviewed by Sam Weinig.
Replace ScrollingCoordinator::frameViewScrollLayerDidChange with a new member function,
ScrollingCoordinator::frameViewRootLayerDidChange which is called whenever the root layer
of the frame view changes (which happens on back/forward navigation as well).
In this function, reset the scrolling tree state from the frame view.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::scrollLayerForFrameView):
Add a helper function.
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
Reset the entire scrolling tree state.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
Call the newly added helper function.
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
Remove frameViewScrollLayerDidChange.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootLayer):
Remove call to ScrollingCoordinator::frameViewScrollLayerDidChange.
(WebCore::RenderLayerCompositor::attachRootLayer):
Call ScrollingCoordinator::frameViewRootLayerDidChange.
- 3:36 PM Changeset in webkit [107847] by
-
- 4 edits in branches/safari-534.54-branch/Source/WebKit2
Merge 10574154.
- 3:14 PM Changeset in webkit [107846] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Add setter/getter to expose drag data as a list of items
https://bugs.webkit.org/show_bug.cgi?id=77125
This change supports the unification of the data store backing ChromiumDataObject and
DataTransferItemListChromium. ChromiumDataObject will represent dragging and clipboard data
as a list of data nodes to make it more straightforward to implement the HTML spec for
DataTransferItemList. Thus, we extend the abstraction to the webkit glue layer to
simplify the serialization/deserialization between platform-specific data and WebDragData.
The other setter/getter methods are deprecated and will be removed once the dependencies in
Chromium code are gone.
Reviewed by Darin Fisher.
- public/platform/WebDragData.h:
(WebKit):
(WebDragData):
- src/WebDragData.cpp:
(WebKit::WebDragData::items):
(WebKit):
(WebKit::WebDragData::setItems):
(WebKit::WebDragData::addItem):
- 3:10 PM Changeset in webkit [107845] by
-
- 3 edits in trunk/Source/WebKit2
Add TiledCoreAnimationDrawingArea::forceRepaint
https://bugs.webkit.org/show_bug.cgi?id=78749
<rdar://problem/10866221>
Reviewed by Sam Weinig.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::forceRepaint):
Force a repaint and synchronize the layer tree to the UI process.
- 3:08 PM Changeset in webkit [107844] by
-
- 21 edits in trunk/Source
Refactor ClipboardMac class to use PlatformStrategies.
https://bugs.webkit.org/show_bug.cgi?id=78554
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests. No change in behavior.
- WebCore.exp.in: Added new exported methods of the PlatformPasteboard class
- editing/mac/EditorMac.mm:
(WebCore::Editor::newGeneralClipboard): Use name based pasteboard references.
- page/DragClient.h:
(WebCore::DragClient::declareAndWriteDragImage): Ditto.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::createDraggingClipboard): Ditto.
- platform/PasteboardStrategy.h: Added new methods to get a unique pasteboard name
and the pasteboard change count.
- platform/PlatformPasteboard.h: Ditto.
- platform/mac/ClipboardMac.h:
(WebCore::ClipboardMac::create): Using name based pasteboard.
(WebCore::ClipboardMac::pasteboardName): Replacing the old pasteboard() method.
- platform/mac/ClipboardMac.mm: All the methods below have been modified to avoid
using Objective-C types and direct access to NSPasteboard object.
(WebCore::Clipboard::create):
(WebCore::ClipboardMac::ClipboardMac):
(WebCore::ClipboardMac::hasData):
(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::utiTypeFromCocoaType):
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::clearData):
(WebCore::ClipboardMac::clearAllData):
(WebCore::absoluteURLsFromPasteboardFilenames):
(WebCore::absoluteURLsFromPasteboard):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::types):
(WebCore::ClipboardMac::files):
(WebCore::ClipboardMac::setDragImage):
(WebCore::ClipboardMac::writeRange):
(WebCore::ClipboardMac::writePlainText):
(WebCore::ClipboardMac::writeURL):
(WebCore::ClipboardMac::declareAndWriteDragImage):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeClipboard): Using name based pasteboard reference.
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::getPathnamesForType): Fixed to support NSArray and NString content.
(WebCore::PlatformPasteboard::changeCount): Added.
(WebCore::PlatformPasteboard::uniqueName): Added.
Source/WebKit/mac:
- WebCoreSupport/WebDragClient.h: Changed methods signature to use name based pasteboard.
- WebCoreSupport/WebDragClient.mm: Ditto.
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
(WebDragClient::declareAndWriteDragImage):
- WebCoreSupport/WebPlatformStrategies.h: Added new methods.
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::changeCount):
(WebPlatformStrategies::uniqueName):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebDragClient.h: Changed method signature to reference
the pasteboard by name.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added new methods.
(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::uniqueName):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h: Ditto.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage): Changed method signature to reference
the pasteboard by name.
- 2:48 PM Changeset in webkit [107843] by
-
- 4 edits in trunk/Source/WebCore
TileCache needs to support setting the contents scale
https://bugs.webkit.org/show_bug.cgi?id=78741
<rdar://problem/10710773>
Reviewed by Sam Weinig.
- platform/graphics/ca/mac/TileCache.h:
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setContentsScale):
Update the contents scale of all the tiles and then revalidate the tile cache since tiles
might have come and gone as a result of setting the contents scale.
(WebCore::TileCache::createTileLayer):
Set the contents scale of the tile layer.
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setContentsScale:]):
Call TileCache::setContentsScale.
- 2:36 PM Changeset in webkit [107842] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Chromium build and remove a snarky comment in the process.
- platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::handleWheelEvent):
- 2:33 PM Changeset in webkit [107841] by
-
- 4 edits in branches/subpixellayout/Source
Add LayoutUnit version of StylePropertySet::setProperty and change DeleteButtonController to use it.
- 2:14 PM Changeset in webkit [107840] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: mark a test as no longer MISSING.
- platform/chromium/test_expectations.txt:
- 2:09 PM Changeset in webkit [107839] by
-
- 6 edits in trunk/LayoutTests
Unreviewed gardening: Fix more results after r107833.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 2:06 PM Changeset in webkit [107838] by
-
- 7 edits in trunk/Source/WebCore
Wheel events should be re-dispatched to the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=78731
<rdar://problem/10866144>
Reviewed by Sam Weinig.
When threaded scrolling is enabled, all the state is assumed to be kept in the scrolling tree,
on the scrolling thread. This means that even if we do end up processing an event on the main thread
(because of wheel event handlers for example), we still have to dispatch the wheel event back to the
scrolling thread.
- page/FrameView.cpp:
(WebCore::FrameView::wheelEvent):
Move wheelEvent from ScrollView and ask the scrolling coordinator to handle the wheel event.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::handleWheelEvent):
Dispatch the event to the scrolling thread, unless it will start a gesture. In that case we'll return false
so that information will be passed back to the UI process.
(ScrollingCoordinator):
- platform/ScrollView.cpp:
- platform/ScrollView.h:
Move wheelEvent to FrameView.
- 1:59 PM Changeset in webkit [107837] by
-
- 2 edits in trunk/Source/WebCore
RootObject::finalize can cause a crash in object->invalidate()
https://bugs.webkit.org/show_bug.cgi?id=78645
Reviewed by Geoffrey Garen.
No new tests.
- bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::finalize): Added a stack-allocated RefPtr to protect the RootObject
during the call to invalidate().
- 1:57 PM Changeset in webkit [107836] by
-
- 10 edits in trunk/Source/WebCore
<rdar://problem/10870238> Box shadow drawing takes an unnecessarily slow code path in some single-shadow, opaque-background cases
https://bugs.webkit.org/show_bug.cgi?id=78728
In some cases, when there is only one normal box shadow, and the box has an opaque background,
it is possible to draw the box shadow by having the background cast it directly. This appears
to be faster than the generic code path that uses a separate drawing pass to cast the shadow,
clipping out the border box and the shadow-casting box.
Reviewed by Dave Hyatt.
No new tests, because behavior is unchanged.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations): Changed to not paint normal box shadows if
they are going to be cast by the background.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations): Ditto.
- rendering/RenderBox.h: Made determineBackgroundBleedAvoidance() protected.
- rendering/RenderBoxModelObject.cpp:
(WebCore::applyBoxShadowForBackground): Added this helper function, which applies the first
normal shadow from the given RenderStyle to the given GraphicsContext.
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Added calls to
applyBoxShadowForBackground() before drawing the background color when needed.
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground): Added. Returns true
in some of the cases where the box shadow can be cast by the background directly.
- rendering/RenderBoxModelObject.h:
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations): Changed to not paint normal box shadows if
they are going to be cast by the background.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations): Ditto.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::boxShadowShouldBeAppliedToBackground): Added this override that
always returns false, because table cells sometimes apply a clip before drawing the background.
- rendering/RenderTableCell.h:
- 1:02 PM Changeset in webkit [107835] by
-
- 1 edit1 add in trunk/LayoutTests
[chromium] Unreviewed, adding the chromium-mac result for this test (test added in r107822).
- platform/chromium-mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Added.
- 12:30 PM Changeset in webkit [107834] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test asserting that the second argument to MutationCallback is the observer
https://bugs.webkit.org/show_bug.cgi?id=78653
Reviewed by Ryosuke Niwa.
This is specified in the spec text, so I wanted to make sure it was
properly exercised in a layout test.
- fast/mutation/callback-second-argument-expected.txt: Added.
- fast/mutation/callback-second-argument.html: Added.
- 12:26 PM Changeset in webkit [107833] by
-
- 7 edits in trunk
getComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align value
https://bugs.webkit.org/show_bug.cgi?id=76326
Reviewed by Tony Chang.
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
- css3/flexbox/css-properties-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- 12:21 PM Changeset in webkit [107832] by
-
- 30 edits in trunk/Source
Notify ChromeClient when touch-event handlers are installed/removed.
https://bugs.webkit.org/show_bug.cgi?id=77440
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-15
Reviewed by Darin Fisher and Ryosuke Niwa.
Source/WebCore:
Keep a count of the number of touch-event handlers and notify the
embedder when the count changes. Depending on the count, the embedder
can decide whether or not to dispatch touch events to webkit.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didAddTouchEventHandler):
(WebCore):
(WebCore::Document::didRemoveTouchEventHandler):
- dom/Document.h:
(WebCore::Document::touchEventHandlerCount):
(Document):
- dom/Node.cpp:
(WebCore::isTouchEventType):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
- loader/EmptyClients.h:
(WebCore::EmptyChromeClient::numTouchEventHandlersChanged):
- page/ChromeClient.h:
(ChromeClient):
- page/Frame.cpp:
(WebCore::Frame::notifyChromeClientWheelEventHandlerCountChanged):
(WebCore::Frame::notifyChromeClientTouchEventHandlerCountChanged):
(WebCore):
- page/Frame.h:
(Frame):
Source/WebKit/chromium:
- public/WebViewClient.h:
(WebKit::WebViewClient::numberOfTouchEventHandlersChanged):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::numTouchEventHandlersChanged):
(WebKit):
- src/ChromeClientImpl.h:
(ChromeClientImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::numberOfTouchEventHandlersChanged):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
Source/WebKit/efl:
- WebCoreSupport/ChromeClientEfl.h:
(WebCore::ChromeClientEfl::numTouchEventHandlersChanged):
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.h:
(WebKit::ChromeClient::numTouchEventHandlersChanged):
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
Source/WebKit/qt:
- WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::numTouchEventHandlersChanged):
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient::numTouchEventHandlersChanged):
Source/WebKit/wince:
- WebCoreSupport/ChromeClientWinCE.h:
(WebKit::ChromeClientWinCE::numTouchEventHandlersChanged):
Source/WebKit/wx:
- WebKitSupport/ChromeClientWx.h:
(WebCore::ChromeClientWx::numTouchEventHandlersChanged):
Source/WebKit2:
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::numTouchEventHandlersChanged):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 12:03 PM Changeset in webkit [107831] by
-
- 5 edits2 adds in trunk
Unset the active flag when TextTrackCues go away
https://bugs.webkit.org/show_bug.cgi?id=72552
Reviewed by Maciej Stachowiak.
Source/WebCore:
Test: media/track/track-active-cues.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTimerFired): Configure new text tracks before preparing to load
so we know about all tracks when resource selection begins.
(WebCore::HTMLMediaElement::prepareForLoad): Call updateActiveTextTrackCues after setting
to m_readyState is HAVE_NOTHING so all cues get deactivated. Don't build list of
available text tracks because resource selection won't actually start until after the load timer fires.
(WebCore::HTMLMediaElement::loadInternal): Build list of non-disabled tracks.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Clear the active flag on all cues
when m_readyState is HAVE_NOTHING or m_player is 0.
(WebCore::HTMLMediaElement::setReadyState): Don't update m_readyState when tracks which haven't
loaded yet will prevent events from firing. Call updateActiveTextTrackCues to ensure that the
first cue(s) are shown as soon as possible.
(WebCore::HTMLMediaElement::userCancelledLoad): Call updateActiveTextTrackCues when when m_readyState
is HAVE_NOTHING so all cues get deactivated.
LayoutTests:
- media/track/track-active-cues-expected.txt: Added.
- media/track/track-active-cues.html: Added.
- track-cue-mutable-text.html: Update to not run test until track and video have
both loaded.
- media/video-test.js:
(waitForEventsAndCall): New, call the specified function after the list of events
has been seen.
- 11:55 AM EFLWebKit edited by
- Fix info on network backends. Cite unstable dependencies requirement. (diff)
- 11:52 AM Changeset in webkit [107830] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed gardening.
Added baseline for new test multiple-filters-invalidation.html.
- platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png: Added.
- 11:44 AM Changeset in webkit [107829] by
-
- 2 edits in trunk/LayoutTests
Stop skipping fast/filesystem/file-writer-gc-blob.html, as FileWriter is well-supported in DRT.
Unreviewed test expectations update.
- platform/chromium/test_expectations.txt:
- 11:43 AM Changeset in webkit [107828] by
-
- 13 edits4 adds5 deletes in trunk/LayoutTests
[chromium] Unreviewed, land chromium pixel results after r107797.
- platform/chromium-linux/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
- 11:37 AM Changeset in webkit [107827] by
-
- 5 edits in trunk/LayoutTests
fast/regions/element-region-overflow-state.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=78654
Reviewed by Ojan Vafai.
Sometimes layout happens before test() is called (e.g., if one of the
script or other resources take a long time to load). In that case, we
get different results. Not waiting for the load event should always
be before layout.
- fast/regions/element-region-overflow-state-expected.txt:
- fast/regions/element-region-overflow-state.html:
- fast/regions/element-region-overflow-state-vertical-rl-expected.txt
- fast/regions/element-region-overflow-state-vertical-rl.html
- 11:16 AM Changeset in webkit [107826] by
-
- 2 edits in trunk/LayoutTests
Re-specify flakiness of http/tests/filesystem/workers as PASS TIMEOUT, since they never crash.
Unreviewed test expectations update.
- platform/chromium/test_expectations.txt:
- 11:16 AM Changeset in webkit [107825] by
-
- 2 edits in branches/chromium/963/Source/WebCore/rendering
Merge 107024 - Properly detect top level frames when propogating compositing
https://bugs.webkit.org/show_bug.cgi?id=78033
Reviewed by James Robinson.
There's no need to enumerate all tag names when searching for a
top-level frame. If a render view's document has a frame, then that
frame is not the top-level one.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/9405017
- 10:57 AM Changeset in webkit [107824] by
-
- 3 edits in trunk/Source/WebCore
WebCore build exceeds address space on 32-bit Windows builders (again).
https://bugs.webkit.org/show_bug.cgi?id=78724
Reviewed by Jon Honeycutt.
Add the rest of the inspector .cpp files to the InspectorAllInOne.cpp file in Production and
Release builds.
- WebCore.vcproj/WebCore.vcproj:
In the process, let VS have its way with this file.
- inspector/InspectorAllInOne.cpp:
- 10:53 AM Changeset in webkit [107823] by
-
- 12 edits in trunk/Source
Remove ScrollableArea::handleGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=78661
Reviewed by Adam Roben.
Source/WebCore:
ScrollableArea::handleGestureEvent ends up being a no-op so remove it and the related code.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
- platform/ScrollAnimator.cpp:
- platform/ScrollAnimator.h:
(ScrollAnimator):
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
(ScrollView):
- platform/ScrollableArea.cpp:
- platform/ScrollableArea.h:
(ScrollableArea):
Source/WebKit/chromium:
Update for WebCore changes.
- src/WebPluginContainerImpl.cpp:
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):
- 10:44 AM Changeset in webkit [107822] by
-
- 4 edits3 adds in trunk
Source/WebCore: Fix for incorrect/offset image in CSS filters (non-composited path)
https://bugs.webkit.org/show_bug.cgi?id=78626
Reviewed by Darin Adler.
Test: css3/filters/multiple-filters-invalidation.html
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::prepare):
When invalidating results, invalidate all intermediate filter
results, not just the last effect's result.
LayoutTests: New test to exercise invalidation of multiple CSS filters.
https://bugs.webkit.org/show_bug.cgi?id=78626
Reviewed by Darin Adler.
- css3/filters/multiple-filters-invalidation-expected.txt: Added.
- css3/filters/multiple-filters-invalidation.html: Added.
- platform/mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Added.
- 8:09 AM Changeset in webkit [107821] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: "Minus" (Delete) button disappears for hovered watch expression in Watches pane
https://bugs.webkit.org/show_bug.cgi?id=78714
Reviewed by Pavel Feldman.
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._mouseOut):
- 8:01 AM Changeset in webkit [107820] by
-
- 5 edits in trunk/Source
[CMake] Move RunLoop to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=78504
Reviewed by Adam Roben.
Source/WebCore:
r105475 moved RunLoop.cpp from WebKit2 to WebCore, but missed the CMake based ports.
- CMakeLists.txt:
- PlatformWinCE.cmake:
Source/WebKit2:
- CMakeLists.txt: Remove RunLoop.cpp from list of souces.
- 7:56 AM Changeset in webkit [107819] by
-
- 2 edits in trunk/Source/WebKit/qt
Unreviewed Qt 4.x build fix.
- WebCoreSupport/PageClientQt.cpp: Fix the QT_VERSION_CHECK pre-processor foo.
- 7:54 AM Changeset in webkit [107818] by
-
- 3 edits in trunk/Source/WebCore
Remove clipToImageBuffer from SourceAlpha and feComposite
https://bugs.webkit.org/show_bug.cgi?id=78355
Reviewed by Nikolas Zimmermann.
The implementation of clipToImageBuffer is inefficient on
non-mac platforms, so we would benefit if remove it.
Existing tests cover this feature.
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformApplySoftware):
- platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::platformApplySoftware):
- 7:42 AM Changeset in webkit [107817] by
-
- 7 edits in trunk/Source
[Qt] Replace use of QGLWidget/QGLContext with QOpenGLContext and QSurface for Qt 5
https://bugs.webkit.org/show_bug.cgi?id=78694
Reviewed by Noam Rosenthal.
Source/WebCore:
Typedef PlatformGraphicsContext3D and PlatformGraphicsSurface3D to QOpenGLContext
and QSurface for Qt 5. Use these APIs to change the current context and get the
procedure addresses. Removed QGraphicsObject inheritance remainder while we're at it,
because that code path is obsolete.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/cairo/OpenGLShims.cpp:
(WebCore::getProcAddress):
- platform/graphics/cairo/OpenGLShims.h:
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3DPrivate::makeCurrentIfNeeded):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
Source/WebKit/qt:
- WebCoreSupport/PageClientQt.cpp:
(createPlatformGraphicsContext3DFromWidget): Return the QOpenGLContext and QSurface
from the QGLWidget when compiling with Qt 5, as that's what WebCore expects.
- 7:38 AM Changeset in webkit [107816] by
-
- 4 edits1 copy in trunk/Tools
[Qt] Add UI for HTTP authentication in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=76347
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-15
Reviewed by Kenneth Rohde Christiansen.
- MiniBrowser/qt/MiniBrowser.qrc:
- MiniBrowser/qt/qml/AuthenticationDialog.qml: Added.
- MiniBrowser/qt/qml/BrowserWindow.qml:
- MiniBrowser/qt/qml/DialogLineInput.qml:
- 7:33 AM Changeset in webkit [107815] by
-
- 7 edits in trunk/Source
[Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
https://bugs.webkit.org/show_bug.cgi?id=78692
Reviewed by Noam Rosenthal.
Source/WebCore:
Replace the "glWidget" term in the GraphicsContext with "surface" and delegate
the context and surface creation to the page client.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3DPrivate::makeCurrentIfNeeded):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
- platform/qt/QWebPageClient.h:
(QWebPageClient):
Source/WebKit/qt:
Implement GLWidget and GLContext creation from the page client interface.
- WebCoreSupport/PageClientQt.cpp:
(createPlatformGraphicsContext3DFromWidget):
(WebCore):
(WebCore::PageClientQWidget::createPlatformGraphicsContext3D):
(WebCore::PageClientQGraphicsWidget::createPlatformGraphicsContext3D):
- WebCoreSupport/PageClientQt.h:
(PageClientQWidget):
(PageClientQGraphicsWidget):
- 7:29 AM Changeset in webkit [107814] by
-
- 12 edits20 adds in trunk
[Texmap] Support filters in TextureMapperImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=76026
Source/WebCore:
Implement GraphicsLayer::setFilters for TextureMapper, and pass the filters all the way
to BitmapTextureImageBuffer. This does not introduce a new filters implementation, but
rather uses the non-AC implementation. A complete implementation will be needed in
TextureMapperGL, which can use some of the glue in this code.
Reviewed by Kenneth Rohde Christiansen.
Unskipped 10 tests in css3/filters.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore):
(WebCore::GraphicsLayerTextureMapper::setFilters):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
- platform/graphics/texmap/TextureMapper.h:
(BitmapTexture):
(WebCore::BitmapTexture::applyFilters):
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore):
(WebCore::BitmapTextureImageBuffer::applyFilters):
- platform/graphics/texmap/TextureMapperImageBuffer.h:
(BitmapTextureImageBuffer):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore):
(WebCore::applyFilters):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
- platform/graphics/texmap/TextureMapperLayer.h:
(State):
LayoutTests:
Unskipping hardware filter tests. They're still skipped in WebKit2.
Reviewed by Kenneth Rohde Christiansen.
- platform/qt-5.0-wk2/Skipped:
- platform/qt/Skipped:
- platform/qt/css3/filters/crash-hw-sw-switch-expected.png:
- platform/qt/css3/filters/effect-blur-hw-expected.png: Added.
- platform/qt/css3/filters/effect-blur-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-combined-expected.png: Added.
- platform/qt/css3/filters/effect-combined-expected.txt: Added.
- platform/qt/css3/filters/effect-combined-hw-expected.png: Added.
- platform/qt/css3/filters/effect-combined-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-drop-shadow-hw-expected.png: Added.
- platform/qt/css3/filters/effect-drop-shadow-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-grayscale-hw-expected.png: Added.
- platform/qt/css3/filters/effect-grayscale-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-hue-rotate-hw-expected.png: Added.
- platform/qt/css3/filters/effect-hue-rotate-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-invert-hw-expected.png: Added.
- platform/qt/css3/filters/effect-invert-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-opacity-hw-expected.png: Added.
- platform/qt/css3/filters/effect-opacity-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-saturate-hw-expected.png: Added.
- platform/qt/css3/filters/effect-saturate-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-sepia-hw-expected.png: Added.
- platform/qt/css3/filters/effect-sepia-hw-expected.txt: Added.
- 7:26 AM Changeset in webkit [107813] by
-
- 4 edits in trunk/Source/WebCore
[Qt] Clean up fallback rendering of GraphicsContext3D to Canvas
https://bugs.webkit.org/show_bug.cgi?id=78690
Reviewed by Noam Rosenthal.
Use the common paintRenderingResultsToCanvas code to retrieve the
pixels from the FBO and use a Qt port specific paintToCanvas
implementation to wrap the pixels into a QImage and render it
into the graphics context, just like it's done for the other ports.
This removes the QGraphicsObject based paint, which is an now
obsolete method of rendering.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::paintToCanvas):
- 7:13 AM Changeset in webkit [107812] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Add missing libsoup to (pkgconfig) dependency requirements
https://bugs.webkit.org/show_bug.cgi?id=78702
Unreviewed build fix.
Patch by Gustavo Lima Chaves <glima@profusion.mobi> on 2012-02-15
- ewebkit.pc.in: Now that bug 77874 had its patch landed, we
always require libsoup as a dependency for the EFL port. The
'Require' session of this file has to contemplate that, otherwise
code linking with ewebkit will fail to lookup to libsoup's header
files.
- 6:14 AM Changeset in webkit [107811] by
-
- 28 edits in trunk/Source
[Qt] Eliminate first set of QtWidgets dependencies from WebCore
https://bugs.webkit.org/show_bug.cgi?id=78611
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
- bindings/js/ScriptControllerQt.cpp: Remove unused include.
- page/qt/EventHandlerQt.cpp:
(WebCore::EventHandler::tabsToAllFormControls): Replace import
of private Qt(Widgets) variable with the default of Qt 5, where
it is also not configurable.
- platform/ContextMenu.h: Remove unused include.
- platform/ContextMenuItem.h: Ditto.
- platform/Widget.h: Use QObject as type for PlatformWidget
instead of QWidget.
- platform/graphics/Icon.h:
(Icon): Prefer QImage over QIcon for storage.
- platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
(WebCore): Make it compile with QWindow for Qt 5 and QWidget for Qt 4.
- platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::keyPressEvent):
(FullScreenVideoWindow::event):
(FullScreenVideoWindow::showFullScreen):
(PlatformVideoWindow::PlatformVideoWindow):
- platform/graphics/qt/IconQt.cpp: Revert the implementation of this class
back to notImplemented(). It was trying to load the actual file as QIcon
instead of trying to find a symbolic icon for the given file. We should
probably use the QMimeType API in Qt 5 once it becomes available.
(WebCore::Icon::createIconForFiles):
(WebCore::Icon::paint):
- platform/graphics/qt/ImageQt.cpp:
(graphics): Remove use of QStyle for retrieving icons. Code moved to
WebCoreSupport instead.
- platform/qt/ContextMenuQt.cpp: Removed unused include.
- platform/qt/PlatformScreenQt.cpp: Add #ifdefs to use QScreen API
with Qt 5.
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
- platform/qt/QWebPageClient.h: Add hook for showing/hiding widget.
(WebCore):
(QWebPageClient):
- platform/qt/SoundQt.cpp:
(WebCore::systemBeep): Beep is not implemented in Qt 5 and its use is
questionable. Move back to notImplemented() until proper QPA API becomes
available in Qt 5 (if ever...).
- platform/qt/WidgetQt.cpp: Delegate QWidget specific show/hide calls
to the PageClient, out of WebCore.
(WebCore::Widget::Widget):
(WebCore::Widget::show):
(WebCore::Widget::hide):
- plugins/PluginView.h: Remove unused include.
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject): When dumping properties of
QWidget, use the QObject property API to retrieve the values instead of
QWidget specific API. Removed the mask from the dump as it's not available
as property and our layout tests don't seem to use it.
Source/WebKit/qt:
- Api/qwebpage.cpp: Add missing includes.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: Ditto.
- WebCoreSupport/FrameLoaderClientQt.cpp: Make it compile by casting
the QObject based PlatformWidget back to QWidget before doing QWidget
specific function calls.
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt): Moved QStyle specific web-graphic initialization
here from WebCore.
- WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::setWidgetVisible): Implement show/hiding of widgets
through delegation to QWidget.
(WebCore):
(WebCore::PageClientQGraphicsWidget::setWidgetVisible): Provide empty widget
show/hide implementation, as it doesn't seem to make sense for graphicsviews.
- WebCoreSupport/PageClientQt.h:
(PageClientQWidget):
(PageClientQGraphicsWidget):
Source/WebKit2:
- UIProcess/qt/QtWebPageEventHandler.cpp: Add missing QCursor include
to fix compilation.
- 6:11 AM Changeset in webkit [107810] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: Fix minor design issues in the Spectrum color picker
https://bugs.webkit.org/show_bug.cgi?id=78693
Drive-by: frontend compilability fixes.
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- inspector/compile-front-end.sh:
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/Popover.js:
- inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.rgbaToHSVA):
(WebInspector.Spectrum.prototype.set color):
(WebInspector.Spectrum.prototype.get isVisible):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
(WebInspector.Spectrum.prototype.hide):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- inspector/front-end/elementsPanel.css:
(.spectrum-container):
(.spectrum-top):
(.spectrum-color):
(.spectrum-hue):
(.spectrum-fill):
(.spectrum-range-container):
(.spectrum-range-container *):
(.spectrum-range-container label):
(.spectrum-range-container input):
(.swatch, .spectrum-dragger, .spectrum-slider):
(.spectrum-sat):
(.spectrum-val):
(.spectrum-dragger):
(.spectrum-slider):
- inspector/front-end/inspector.css:
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:increment):
- 6:09 AM Changeset in webkit [107809] by
-
- 2 edits in trunk
[CMake] Remove unused PkgConfig module import from FindCFLite.cmake.
https://bugs.webkit.org/show_bug.cgi?id=78600
Reviewed by Adam Roben.
- Source/cmake/FindCFLite.cmake:
- 6:05 AM Changeset in webkit [107808] by
-
- 3 edits in trunk/Source/WebCore
2012-02-15 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Build fix after r107806
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::callFunctionWithEvalEnabled):
- inspector/InjectedScript.h: (InjectedScript):
- 5:59 AM Changeset in webkit [107807] by
-
- 12 edits2 adds2 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #13 of N.
- platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10565-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug11026-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png: Removed.
- platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium/test_expectations.txt:
- 5:55 AM Changeset in webkit [107806] by
-
- 4 edits2 adds in trunk
Web Inspector: crash when inspecting an element on a page with eval disabled by CSP
https://bugs.webkit.org/show_bug.cgi?id=78705
Source/WebCore:
Inspector functions in injected script may use eval so we need to make sure
it is allowed for inspector code on pages where it is prohibited by CSP.
Reviewed by Pavel Feldman.
Test: inspector/elements/resolve-node-blocked.html
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::nodeForObjectId):
(WebCore::InjectedScript::wrapCallFrames):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::releaseObjectGroup):
(WebCore::InjectedScript::callFunctionWithEvalEnabled):
(WebCore):
(WebCore::InjectedScript::makeCall):
- inspector/InjectedScript.h:
(InjectedScript):
LayoutTests:
Reviewed by Pavel Feldman.
- inspector/elements/resolve-node-blocked-expected.txt: Added.
- inspector/elements/resolve-node-blocked.html: Added.
- 5:39 AM Changeset in webkit [107805] by
-
- 7 edits8 adds60 deletes in trunk/LayoutTests
Clean up radio button tests
https://bugs.webkit.org/show_bug.cgi?id=78679
Reviewed by Kentaro Hara.
- Split checkbox-radio-onchange.html into checkbox-onchange.html and radio/radio-onchange.html.
- Convert the following rendering tests to text tests. radio-attr-order.html radio-nested-labels.html radio_checked.html radio_checked_dynamic.html
This change is a preparation of moving radio button tests to fast/forms/radio/.
- fast/forms/checkbox-onchange-expected.txt: Added.
- fast/forms/checkbox-onchange.html: Added.
- fast/forms/checkbox-radio-onchange.html: Removed.
- fast/forms/radio-attr-order-expected.txt: Added.
- fast/forms/radio-attr-order.html:
- fast/forms/radio-nested-labels-expected.txt: Added.
- fast/forms/radio-nested-labels.html:
- fast/forms/radio/radio-onchange-expected.txt: Added.
- fast/forms/radio/radio-onchange.html: Added.
- fast/forms/radio_checked-expected.txt: Added.
- fast/forms/radio_checked.html:
- fast/forms/radio_checked_dynamic-expected.txt: Added.
- fast/forms/radio_checked_dynamic.html:
- platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.png: Removed.
- platform/chromium-linux/fast/forms/radio-attr-order-expected.png: Removed.
- platform/chromium-linux/fast/forms/radio-nested-labels-expected.png: Removed.
- platform/chromium-linux/fast/forms/radio_checked-expected.png: Removed.
- platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/chromium-win/fast/forms/checkbox-radio-onchange-expected.png: Removed.
- platform/chromium-win/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
- platform/chromium-win/fast/forms/radio-attr-order-expected.png: Removed.
- platform/chromium-win/fast/forms/radio-attr-order-expected.txt: Removed.
- platform/chromium-win/fast/forms/radio-nested-labels-expected.png: Removed.
- platform/chromium-win/fast/forms/radio-nested-labels-expected.txt: Removed.
- platform/chromium-win/fast/forms/radio_checked-expected.png: Removed.
- platform/chromium-win/fast/forms/radio_checked-expected.txt: Removed.
- platform/chromium-win/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/chromium-win/fast/forms/radio_checked_dynamic-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/efl/fast/forms/checkbox-radio-onchange-expected.png: Removed.
- platform/efl/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
- platform/efl/fast/forms/radio-attr-order-expected.png: Removed.
- platform/efl/fast/forms/radio-attr-order-expected.txt: Removed.
- platform/efl/fast/forms/radio-nested-labels-expected.png: Removed.
- platform/efl/fast/forms/radio-nested-labels-expected.txt: Removed.
- platform/efl/fast/forms/radio_checked-expected.png: Removed.
- platform/efl/fast/forms/radio_checked-expected.txt: Removed.
- platform/efl/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/efl/fast/forms/radio_checked_dynamic-expected.txt: Removed.
- platform/gtk/fast/forms/checkbox-radio-onchange-expected.png: Removed.
- platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
- platform/gtk/fast/forms/radio-attr-order-expected.png: Removed.
- platform/gtk/fast/forms/radio-attr-order-expected.txt: Removed.
- platform/gtk/fast/forms/radio-nested-labels-expected.png: Removed.
- platform/gtk/fast/forms/radio-nested-labels-expected.txt: Removed.
- platform/gtk/fast/forms/radio_checked-expected.png: Removed.
- platform/gtk/fast/forms/radio_checked-expected.txt: Removed.
- platform/gtk/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/gtk/fast/forms/radio_checked_dynamic-expected.txt: Removed.
- platform/mac-leopard/fast/forms/checkbox-radio-onchange-expected.png: Removed.
- platform/mac-leopard/fast/forms/radio-attr-order-expected.png: Removed.
- platform/mac-leopard/fast/forms/radio-nested-labels-expected.png: Removed.
- platform/mac-leopard/fast/forms/radio_checked-expected.png: Removed.
- platform/mac-leopard/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/radio_checked-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/radio_checked-expected.txt: Removed.
- platform/mac-snowleopard/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/radio_checked_dynamic-expected.txt: Removed.
- platform/mac/fast/forms/checkbox-radio-onchange-expected.png: Removed.
- platform/mac/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
- platform/mac/fast/forms/radio-attr-order-expected.png: Removed.
- platform/mac/fast/forms/radio-attr-order-expected.txt: Removed.
- platform/mac/fast/forms/radio-nested-labels-expected.png: Removed.
- platform/mac/fast/forms/radio-nested-labels-expected.txt: Removed.
- platform/mac/fast/forms/radio_checked-expected.png: Removed.
- platform/mac/fast/forms/radio_checked-expected.txt: Removed.
- platform/mac/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/mac/fast/forms/radio_checked_dynamic-expected.txt: Removed.
- platform/qt-mac/Skipped:
- platform/qt/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
- platform/qt/fast/forms/radio-attr-order-expected.txt: Removed.
- platform/qt/fast/forms/radio-nested-labels-expected.txt: Removed.
- platform/qt/fast/forms/radio_checked-expected.txt: Removed.
- platform/qt/fast/forms/radio_checked_dynamic-expected.txt: Removed.
- 5:18 AM Changeset in webkit [107804] by
-
- 8 edits1 add in trunk/Source/WebCore
Web Inspector: Add colorpicker functionality to color swatches in Styles Sidebar
https://bugs.webkit.org/show_bug.cgi?id=71262
Patch by Brian Grinstead <briangrinstead@gmail.com> on 2012-02-13
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/Settings.js:
- inspector/front-end/Spectrum.js: Added.
(WebInspector.Spectrum.hueDrag):
(WebInspector.Spectrum.colorDrag):
(WebInspector.Spectrum.alphaDrag):
(WebInspector.Spectrum):
(WebInspector.Spectrum.hsvaToRGBA):
(WebInspector.Spectrum.rgbaToHSVA):
(WebInspector.Spectrum.draggable.prevent):
(WebInspector.Spectrum.draggable.move):
(WebInspector.Spectrum.draggable.start):
(WebInspector.Spectrum.draggable.stop):
(WebInspector.Spectrum.draggable):
(WebInspector.Spectrum.prototype.set color):
(WebInspector.Spectrum.prototype.get color):
(WebInspector.Spectrum.prototype.get outputColorFormat):
(WebInspector.Spectrum.prototype.get colorHueOnly):
(WebInspector.Spectrum.prototype.set displayText):
(WebInspector.Spectrum.prototype._onchange):
(WebInspector.Spectrum.prototype._updateHelperLocations):
(WebInspector.Spectrum.prototype._updateUI):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
(WebInspector.Spectrum.prototype.reposition):
(WebInspector.Spectrum.prototype.hide):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
(.swatch):
(.swatch-inner):
(.spectrum-container):
(.spectrum-top):
(.spectrum-color):
(.spectrum-hue):
(.spectrum-fill):
(.spectrum-range-container):
(.spectrum-range-container *):
(.spectrum-range-container label):
(.spectrum-range-container input):
(.swatch, .spectrum-dragger, .spectrum-slider):
(.spectrum-sat):
(.spectrum-val):
(.spectrum-dragger):
(.spectrum-slider):
- inspector/front-end/inspector.html:
- 5:06 AM Changeset in webkit [107803] by
-
- 5 edits in trunk/Source
Source/WebCore: [Qt] Be smarter with tile usages during tiling
https://bugs.webkit.org/show_bug.cgi?id=78243
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2012-02-15
Reviewed by Simon Hausmann.
The keep rect used to know what existing tiles to keep around, is now a
padding (in tile dimensions) around the usual cover rect. With usual,
I mean to point out that we take our panning optimization into account.
We also do a good effort at keeping the amount of tiles steady, by not
simply intersecting our areas with the contentRect, but moving it
first into legal bounds and then expanding in opposite direction to
cover a similar amount of pixels.
In the future the cover area should be calculated given available
system memory.
- platform/graphics/TiledBackingStore.cpp:
(WebCore):
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::adjustForContentsRect):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):
(WebCore::TiledBackingStore::tileRectForCoordinate):
- platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
Source/WebKit/qt: [Qt] Be smarted with tile usages during tiling
https://bugs.webkit.org/show_bug.cgi?id=78243
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2012-02-15
Reviewed by Simon Hausmann.
Remove internal API used by Symbian.
- Api/qwebpage.cpp:
(QWebPagePrivate::dynamicPropertyChangeEvent):
- 4:54 AM Changeset in webkit [107802] by
-
- 89 edits32 adds in trunk/LayoutTests
2012-02-15 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update SnowLeopard SVG pixel test baseline - chunk 1.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
- platform/mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
- platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png:
- platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
- platform/mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
- platform/mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png:
- platform/mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png:
- platform/mac-snowleopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
- platform/mac-snowleopard/svg/as-object/embedded-svg-size-changes-expected.png:
- platform/mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-expected.png:
- platform/mac-snowleopard/svg/batik/filters/feTile-expected.png:
- platform/mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
- platform/mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
- platform/mac-snowleopard/svg/batik/text/smallFonts-expected.png:
- platform/mac-snowleopard/svg/batik/text/textEffect-expected.png:
- platform/mac-snowleopard/svg/batik/text/textEffect3-expected.png:
- platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png:
- platform/mac-snowleopard/svg/carto.net/window-expected.png:
- platform/mac-snowleopard/svg/css/path-gradient-stroke-shadow-expected.png: Added.
- platform/mac-snowleopard/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
- platform/mac-snowleopard/svg/css/shadow-changes-expected.png:
- platform/mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png:
- platform/mac-snowleopard/svg/custom/circle-move-invalidation-expected.png:
- platform/mac-snowleopard/svg/custom/convolution-crash-expected.png: Added.
- platform/mac-snowleopard/svg/custom/createImageElement-expected.png: Added.
- platform/mac-snowleopard/svg/custom/createImageElement2-expected.png:
- platform/mac-snowleopard/svg/custom/empty-merge-expected.png: Added.
- platform/mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
- platform/mac-snowleopard/svg/custom/feDisplacementMap-01-expected.png: Added.
- platform/mac-snowleopard/svg/custom/focus-ring-expected.png:
- platform/mac-snowleopard/svg/custom/foreignObject-crash-on-hover-expected.png:
- platform/mac-snowleopard/svg/custom/getTransformToElement-expected.png:
- platform/mac-snowleopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
- platform/mac-snowleopard/svg/custom/group-opacity-expected.png:
- platform/mac-snowleopard/svg/custom/hit-test-unclosed-subpaths-expected.png:
- platform/mac-snowleopard/svg/custom/hit-test-with-br-expected.png:
- platform/mac-snowleopard/svg/custom/image-parent-translation-expected.png:
- platform/mac-snowleopard/svg/custom/image-small-width-height-expected.png:
- platform/mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
- platform/mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/mac-snowleopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
- platform/mac-snowleopard/svg/custom/js-update-image-and-display-expected.png: Added.
- platform/mac-snowleopard/svg/custom/js-update-image-and-display2-expected.png: Added.
- platform/mac-snowleopard/svg/custom/js-update-image-and-display3-expected.png: Added.
- platform/mac-snowleopard/svg/custom/js-update-image-expected.png: Added.
- platform/mac-snowleopard/svg/custom/js-update-stop-linked-gradient-expected.png:
- platform/mac-snowleopard/svg/custom/mask-invalidation-expected.png:
- platform/mac-snowleopard/svg/custom/mouse-move-on-svg-container-expected.png:
- platform/mac-snowleopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
- platform/mac-snowleopard/svg/custom/mouse-move-on-svg-root-expected.png:
- platform/mac-snowleopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
- platform/mac-snowleopard/svg/custom/non-opaque-filters-expected.png:
- platform/mac-snowleopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
- platform/mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/mac-snowleopard/svg/custom/pointer-events-image-expected.png:
- platform/mac-snowleopard/svg/custom/recursive-filter-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-content-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-content-with-resources-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-image-expected.png: Added.
- platform/mac-snowleopard/svg/custom/relative-sized-inner-svg-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-shadow-tree-content-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-use-on-symbol-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
- platform/mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
- platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/mac-snowleopard/svg/custom/text-filter-expected.png: Added.
- platform/mac-snowleopard/svg/custom/text-image-opacity-expected.png:
- platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png:
- platform/mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
- platform/mac-snowleopard/svg/custom/use-clipped-hit-expected.png:
- platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png:
- platform/mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png:
- platform/mac-snowleopard/svg/custom/use-elementInstance-methods-expected.png:
- platform/mac-snowleopard/svg/custom/use-event-handler-on-referenced-element-expected.png:
- platform/mac-snowleopard/svg/custom/use-event-handler-on-use-element-expected.png:
- platform/mac-snowleopard/svg/custom/use-instanceRoot-event-bubbling-expected.png: Added.
- platform/mac-snowleopard/svg/custom/use-instanceRoot-event-listeners-expected.png: Added.
- platform/mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Added.
- platform/mac-snowleopard/svg/custom/visibility-override-filter-expected.png: Added.
- platform/mac-snowleopard/svg/dom/SVGPathSegList-segment-modification-expected.png:
- platform/mac-snowleopard/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png:
- platform/mac-snowleopard/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
- 4:19 AM Changeset in webkit [107801] by
-
- 16 edits2 adds in trunk
Web Inspector: [InspectorIndexedDB] Pass data entries from object stores and indexes to front-end.
https://bugs.webkit.org/show_bug.cgi?id=78503
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: http/tests/inspector/indexeddb/database-data.html
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserializeForInspector):
(WebCore):
- bindings/js/SerializedScriptValue.h:
(SerializedScriptValue):
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserializeForInspector):
(WebCore):
- bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapSerializedObject):
(WebCore):
(WebCore::InjectedScript::canAccessInspectedWindow):
- inspector/InjectedScript.h:
(InjectedScript):
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::assertFrame):
(WebCore::assertDocument):
(WebCore::InspectorIndexedDBAgent::requestData):
- inspector/InspectorIndexedDBAgent.h:
(WebCore):
(WebCore::InspectorIndexedDBAgent::create):
(InspectorIndexedDBAgent):
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.idbKeyFromKey):
(WebInspector.IndexedDBModel.keyFromIDBKey):
(WebInspector.IndexedDBModel.keyRangeFromIDBKeyRange):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.loadObjectStoreData):
(WebInspector.IndexedDBModel.prototype.loadIndexData):
(WebInspector.IndexedDBModel.Entry):
(WebInspector.IndexedDBRequestManager):
(WebInspector.IndexedDBRequestManager.prototype._requestData.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype._requestData):
(WebInspector.IndexedDBRequestManager.prototype.requestObjectStoreData):
(WebInspector.IndexedDBRequestManager.prototype._objectStoreDataLoaded):
(WebInspector.IndexedDBRequestManager.prototype.requestIndexData):
(WebInspector.IndexedDBRequestManager.prototype._indexDataLoaded):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._databaseRemoved):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DataRequest):
(WebInspector.IndexedDBDispatcher.prototype.databaseLoaded):
(WebInspector.IndexedDBDispatcher.prototype.objectStoreDataLoaded):
(WebInspector.IndexedDBDispatcher.prototype.indexDataLoaded):
LayoutTests:
- http/tests/inspector/indexeddb/database-data-expected.txt: Added.
- http/tests/inspector/indexeddb/database-data.html: Added.
- http/tests/inspector/indexeddb/database-names-expected.txt:
- http/tests/inspector/indexeddb/database-structure-expected.txt:
- http/tests/inspector/indexeddb/indexeddb-test.js:
(initialize_IndexedDBTest.InspectorTest.evaluateWithCallback):
(initialize_IndexedDBTest.InspectorTest.addIDBValue):
(initialize_IndexedDBTest):
(doWithReadWriteTransaction.step2.innerCommitCallback):
(doWithReadWriteTransaction.step2):
(doWithReadWriteTransaction):
(addIDBValue.doWithReadWriteTransaction.withTransactionCallback):
(addIDBValue):
- 3:47 AM Changeset in webkit [107800] by
-
- 2 edits in trunk/Tools
[Qt] Fix WebGL in QtTestBrowser
Reviewed by Tor Arne Vestbø.
- QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
the options for enabling GL we also pass them on properly.
- 3:37 AM Changeset in webkit [107799] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION(r107518): DeviceOrientationController doesn't remove registered DOMWindows
https://bugs.webkit.org/show_bug.cgi?id=78683
Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-15
Reviewed by Kentaro Hara.
A copy-n-paste disaster. This change fixed it by calling correct methods.
No new tests. Needs browser side mocking for testing this.
A Chromium automated test covers this.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::removeAllEventListeners):
- page/Page.cpp:
(WebCore::Page::provideSupplement):
(WebCore::Page::requireSupplement):
- page/Page.h: Fix typo.
(Page):
- 3:28 AM Changeset in webkit [107798] by
-
- 2 edits in trunk/LayoutTests
2012-02-15 Kent Tamura <tkent@chromium.org>
Unreviewed, change the encoding of a test HTML.
- fast/forms/radio-nested-labels.html: Convert from UTF-16 to UTF-8.
- 2:49 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 2:48 AM Changeset in webkit [107797] by
-
- 1095 edits1 delete in trunk/LayoutTests
Switch svg/dynamic-updates tests to repaint harness
https://bugs.webkit.org/show_bug.cgi?id=78219
Make all tests that exercise repainting use the fast/repaint/resources/repaint.js harness.
This is the last step, all svg tests have been converted.
The only relevant change to look at is svg/dynamic-updates/resources/SVGTestCase.js, the rest is mechanic, done by a script.
Ran following magic in svg/dynamic-updates: (inject repaint.js in all *.html files in that folder, and register onload handler)
find . -type f -name "*.html" | xargs perl -pi -e "s/js-test-pre\.js\"><\/script\>/js-test-pre\.js\"><\/script\>\n\<script src=\"..\/..\/fast\/repaint\/resources\/repaint\.js\"\>\<\/script\>/"
find . -type f -name "*.html" | xargs perl -pi -e "s/<body>/<body onload=\"runRepaintTest()\">/"
And in svg/dynamic-updates/script-tests: (remove manual startTest function calls, and rename executeTest to repaintTest).
find . -type f -name "*.js" | xargs perl -pi -e "s/startTest\(.*\);\n"
find . -type f -name "*.js" | xargs perl -pi -e "s/function\ executeTest/function\ repaintTest/"
Only a few tests needed other adjustments.
- platform/chromium/test_expectations.txt:
- svg/animations/resources/SVGAnimationTestCase.js:
(runSMILTest):
...
- platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png:
...
- svg/dynamic-updates/SVG-dynamic-css-transform.html:
- svg/dynamic-updates/SVGAElement-dom-href-attr.html:
...
- svg/dynamic-updates/resources/SVGTestCase.js: Changed to utilize the repaint.js harness.
(createSVGTestCase):
(clickAt):
- svg/dynamic-updates/resources/linkTarget.svg:
- svg/dynamic-updates/script-tests/SVGAElement-dom-href-attr.js:
(repaintTest):
- svg/dynamic-updates/script-tests/SVGAElement-dom-target-attr.js:
(repaintTest):
...
- svg/dynamic-updates/script-tests/TEMPLATE.html: Removed.
- 2:30 AM Changeset in webkit [107796] by
-
- 2 edits in trunk/Source/WebCore
2012-02-15 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed, quick build fix for 107792
- inspector/DOMEditor.cpp: (WebCore::DOMEditor::RemoveAttributeAction::redo):
- 1:52 AM Changeset in webkit [107795] by
-
- 2 edits in trunk/LayoutTests
2012-02-15 Kent Tamura <tkent@chromium.org>
Unreviewed, correct svn:mime-type of a test.
- fast/forms/radio-nested-labels.html: Modified property svn:mime-type from application/octet-stream to text/html.
- 1:24 AM Changeset in webkit [107794] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Don't use increased FontCache size on Android
https://bugs.webkit.org/show_bug.cgi?id=78656
Reviewed by Adam Barth.
The chromium port uses a larger font cache size because it increases
performance on the intl1 and intl2 page cyclers. However, on Android
devices where resources are more constrained, it isn't desireable to
allow the FontCache to grow so big.
No new tests because no testable difference in functionality.
- platform/graphics/FontCache.cpp:
(WebCore):
- 1:17 AM Changeset in webkit [107793] by
-
- 20 edits2 adds in trunk
<style scoped>: Allow <style scoped> as a direct child of a ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=77853
.:
numberOfScopedHTMLStyleChildren got moved from Element into Node.
Reviewed by Dimitri Glazkov.
- Source/autotools/symbols.filter:
Source/WebCore:
Moved registration code from Element to Node. updated Internals and build files accordingly.
Moved registration data members from ElementRareData to NodeRareData.
Forward willRemove() from host element into shadow DOM tree.
Reviewed by Dimitri Glazkov.
Test: fast/css/style-scoped/registering-shadowroot.html
- WebCore.exp.in:
- dom/Element.cpp:
(WebCore::Element::willRemove):
- dom/Element.h:
(Element):
- dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
- dom/Node.cpp:
(WebCore):
(WebCore::Node::hasScopedHTMLStyleChild):
(WebCore::Node::numberOfScopedHTMLStyleChildren):
(WebCore::Node::registerScopedHTMLStyleChild):
(WebCore::Node::unregisterScopedHTMLStyleChild):
- dom/Node.h:
(Node):
- dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(NodeRareData):
(WebCore::NodeRareData::registerScopedHTMLStyleChild):
(WebCore::NodeRareData::unregisterScopedHTMLStyleChild):
(WebCore::NodeRareData::hasScopedHTMLStyleChild):
(WebCore::NodeRareData::numberOfScopedHTMLStyleChildren):
- dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::willRemove):
(WebCore):
- dom/ShadowRootList.h:
(ShadowRootList):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
- testing/Internals.cpp:
(WebCore::Internals::numberOfScopedHTMLStyleChildren):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
numberOfScopedHTMLStyleChildren got moved from Element into Node.
Reviewed by Dimitri Glazkov.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
Test registration of <style scoped> as a direct child of a ShadowRoot.
Reviewed by Dimitri Glazkov.
- fast/css/style-scoped/registering-shadowroot-expected.txt: Added.
- fast/css/style-scoped/registering-shadowroot.html: Added.
- 1:12 AM Changeset in webkit [107792] by
-
- 25 edits in trunk
Web Inspector: implement redo for DOM actions.
https://bugs.webkit.org/show_bug.cgi?id=78601
Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-02-14
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/DOMEditor.cpp:
(WebCore::DOMEditor::RemoveChildAction::perform):
(WebCore::DOMEditor::RemoveChildAction::redo):
(DOMEditor::RemoveChildAction):
(WebCore::DOMEditor::InsertBeforeAction::redo):
(DOMEditor::InsertBeforeAction):
(WebCore::DOMEditor::RemoveAttributeAction::perform):
(WebCore::DOMEditor::RemoveAttributeAction::redo):
(DOMEditor::RemoveAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::perform):
(WebCore::DOMEditor::SetAttributeAction::redo):
(DOMEditor::SetAttributeAction):
(WebCore::DOMEditor::SetOuterHTMLAction::redo):
(DOMEditor::SetOuterHTMLAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::perform):
(WebCore::DOMEditor::ReplaceWholeTextAction::redo):
(DOMEditor::ReplaceWholeTextAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::perform):
(WebCore::DOMEditor::ReplaceChildNodeAction::redo):
(DOMEditor::ReplaceChildNodeAction):
(WebCore::DOMEditor::SetNodeValueAction::perform):
(WebCore::DOMEditor::SetNodeValueAction::redo):
(DOMEditor::SetNodeValueAction):
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::redo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::redo):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::redo):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::perform):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::redo):
(InspectorCSSAgent::SetRuleSelectorAction):
(WebCore::InspectorCSSAgent::AddRuleAction::perform):
(WebCore::InspectorCSSAgent::AddRuleAction::redo):
(InspectorCSSAgent::AddRuleAction):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::redo):
(WebCore):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::redo):
(WebCore):
- inspector/InspectorHistory.h:
(Action):
(InspectorHistory):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype._undoRedoRequested):
(WebInspector.CSSStyleModel.prototype._undoRedoCompleted):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.get undo):
(WebInspector.DOMAgent.prototype.redo):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleShortcut):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.generateUndoTest):
- inspector/elements/undo-dom-edits-2-expected.txt:
- inspector/elements/undo-dom-edits-expected.txt:
- inspector/styles/undo-add-new-rule-expected.txt:
- inspector/styles/undo-add-new-rule.html:
- inspector/styles/undo-add-property-expected.txt:
- inspector/styles/undo-add-property.html:
- inspector/styles/undo-change-property-expected.txt:
- inspector/styles/undo-change-property.html:
- inspector/styles/undo-property-toggle-expected.txt:
- inspector/styles/undo-property-toggle.html:
- inspector/styles/undo-set-selector-text-expected.txt:
- inspector/styles/undo-set-selector-text.html:
- 12:59 AM Changeset in webkit [107791] by
-
- 105 edits in trunk/LayoutTests
2012-02-14 Nikolas Zimmermann <nzimmermann@rim.com>
Convert svg/animations to use SMIL methods for driving the timeline
https://bugs.webkit.org/show_bug.cgi?id=78422
Rubber-stamped by Simon Hausmann.
Further cleanup of the svg/animation tests. Always use "0.001" as sampling time
for "just-after-anim-begin" instead of 0.1/0.01 variations. Use "3.999" as
"just-before-anim-end" time instead of 3.9/3.99 variations.
Use a default tolerance of 0.1, instead of the strict 0.01, to avoid having
to expect values like "199.98". Use "200" instead. That doesn't reduce the
value of any of the tests, but its likely to be more stable.
Changed some real-quick running animamtions to have a higher duration.
This minimizes the sampling time error when sampling the animation right after
it started (svg/animation/*nested-transforms*). This doesn't affect the runtime
of the tests at all, as we manually drive the timeline anyways.
Always use shouldBe() instead of shouldBeCloseEnough() if the sampling time
is an integer, like 2.0 for animations that eg. animate x from 0 to 200.
Sampling exactly at 2.0, yields 100, so there's no need to check for equal
with tolerance.
- platform/chromium/test_expectations.txt:
- svg/animations/animate-calcMode-spline-by-expected.txt:
- svg/animations/animate-calcMode-spline-from-by-expected.txt:
- svg/animations/animate-calcMode-spline-from-to-expected.txt:
- svg/animations/animate-calcMode-spline-to-expected.txt:
- svg/animations/animate-calcMode-spline-values-expected.txt:
- svg/animations/animate-path-animation-Cc-Ss-expected.txt:
- svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt:
- svg/animations/animate-path-animation-cC-sS-inverse-expected.txt:
- svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt:
- svg/animations/animate-path-nested-transforms-expected.txt:
- svg/animations/animate-path-to-animation-expected.txt:
- svg/animations/animate-text-nested-transforms-expected.txt:
- svg/animations/resources/SVGAnimationTestCase.js: (shouldBeCloseEnough):
- svg/animations/script-tests/animVal-basics.js: (sample3):
- svg/animations/script-tests/animate-calcMode-spline-by.js: (sample2): (sample3):
- svg/animations/script-tests/animate-calcMode-spline-from-by.js: (sample2): (sample3):
- svg/animations/script-tests/animate-calcMode-spline-from-to.js: (sample2): (sample3):
- svg/animations/script-tests/animate-calcMode-spline-to.js: (sample2): (sample3):
- svg/animations/script-tests/animate-calcMode-spline-values.js: (sample2): (sample3):
- svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js: (executeTest):
- svg/animations/script-tests/animate-dynamic-update-attributeName.js: (executeTest):
- svg/animations/script-tests/animate-end-attribute.js: (sample3):
- svg/animations/script-tests/animate-mpath-insert.js: (endSample): (executeTest):
- svg/animations/script-tests/animate-path-animation-Cc-Ss.js: (sample2): (sample3): (sample4):
- svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js: (sample2): (sample3): (sample4):
- svg/animations/script-tests/animate-path-animation-Qq-Tt.js: (sample2): (sample3): (sample4):
- svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js: (sample2): (sample3): (sample4):
- svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js: (sample2): (sample3): (sample4):
- svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js: (sample2): (sample3): (sample4):
- svg/animations/script-tests/animate-path-nested-transforms.js: (endSample): (executeTest):
- svg/animations/script-tests/animate-path-to-animation.js: (sample2): (sample3):
- svg/animations/script-tests/animate-text-nested-transforms.js: (endSample): (executeTest):
- svg/animations/script-tests/animateTransform-pattern-transform.js: (sample3):
- svg/animations/script-tests/svgangle-animation-deg-to-grad.js: (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-deg-to-rad.js: (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-grad-to-deg.js: (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-grad-to-rad.js: (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-rad-to-deg.js: (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-rad-to-grad.js: (sample2): (sample3):
- svg/animations/script-tests/svginteger-animation-1.js: (sample3):
- svg/animations/script-tests/svglength-animation-LengthModeHeight.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-LengthModeOther.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-LengthModeWidth.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-number-to-number.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-cm.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-ems.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-exs.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-in.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-number.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-pc.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-percentage.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-pt.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-px.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-values.js: (sample2): (sample3): (sample4): (sample5):
- svg/animations/script-tests/svglengthlist-animation-1.js: (sample3):
- svg/animations/script-tests/svglengthlist-animation-2.js: (sample2): (sample3):
- svg/animations/script-tests/svglengthlist-animation-3.js: (sample2): (sample3):
- svg/animations/script-tests/svglengthlist-animation-4.js: (sample3):
- svg/animations/script-tests/svglengthlist-animation-5.js: (sample3):
- svg/animations/script-tests/svgnumber-animation-1.js: (sample3):
- svg/animations/script-tests/svgnumber-animation-2.js: (sample3):
- svg/animations/script-tests/svgnumberlist-animation-1.js: (sample2): (sample3):
- svg/animations/script-tests/svgnumberlist-animation-2.js: (sample2): (sample3):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js: (sample2): (sample3):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js: (sample2): (sample3):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js: (sample2): (sample3):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js: (sample2): (sample3):
- svg/animations/script-tests/svgpath-animation-1.js: (sample2): (sample3):
- svg/animations/script-tests/svgpointlist-animation-1.js: (sample3):
- svg/animations/script-tests/svgpointlist-animation-2.js: (sample3):
- svg/animations/script-tests/svgrect-animation-1.js: (sample3):
- svg/animations/script-tests/svgrect-animation-2.js: (sample3):
- svg/animations/script-tests/svgtransform-animation-1.js: (sample1): (sample2): (sample3):
- svg/animations/script-tests/svgtransform-animation-discrete.js: (sample1): (sample2): (sample3):
- svg/animations/svgangle-animation-deg-to-grad-expected.txt:
- svg/animations/svgangle-animation-deg-to-rad-expected.txt:
- svg/animations/svgangle-animation-grad-to-deg-expected.txt:
- svg/animations/svgangle-animation-grad-to-rad-expected.txt:
- svg/animations/svgangle-animation-rad-to-deg-expected.txt:
- svg/animations/svgangle-animation-rad-to-grad-expected.txt:
- svg/animations/svglength-animation-LengthModeHeight-expected.txt:
- svg/animations/svglength-animation-LengthModeOther-expected.txt:
- svg/animations/svglength-animation-LengthModeWidth-expected.txt:
- svg/animations/svglength-animation-number-to-number-expected.txt:
- svg/animations/svglength-animation-px-to-cm-expected.txt:
- svg/animations/svglength-animation-px-to-ems-expected.txt:
- svg/animations/svglength-animation-px-to-exs-expected.txt:
- svg/animations/svglength-animation-px-to-in-expected.txt:
- svg/animations/svglength-animation-px-to-number-expected.txt:
- svg/animations/svglength-animation-px-to-pc-expected.txt:
- svg/animations/svglength-animation-px-to-percentage-expected.txt:
- svg/animations/svglength-animation-px-to-pt-expected.txt:
- svg/animations/svglength-animation-px-to-px-expected.txt:
- svg/animations/svglength-animation-values-expected.txt:
- svg/animations/svglengthlist-animation-2-expected.txt:
- svg/animations/svgnumberlist-animation-1-expected.txt:
- svg/animations/svgnumberlist-animation-2-expected.txt:
- svg/animations/svgpath-animation-1-expected.txt:
- svg/animations/svgpointlist-animation-1-expected.txt:
- svg/animations/svgpointlist-animation-2-expected.txt:
- svg/animations/svgrect-animation-1-expected.txt:
- svg/animations/svgrect-animation-2-expected.txt:
- svg/animations/svgtransform-animation-1-expected.txt:
- 12:53 AM Changeset in webkit [107790] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r107785 and r107762. Also
skipping a new SVG failure.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt:
- platform/gtk/media/video-zoom-expected.txt:
- 12:45 AM Changeset in webkit [107789] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] Unreviewed morning gardening.
- 12:43 AM Changeset in webkit [107788] by
-
- 5 edits4 adds in trunk
WebSocket: MessageEvent fired during send() on workers
https://bugs.webkit.org/show_bug.cgi?id=76521
Reviewed by David Levin.
Source/WebCore:
WebSocket's message event should not be invoked while a synchronous operation
(send() and bufferedAmount) is in progress.
Test: http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html
- websockets/ThreadableWebSocketChannelClientWrapper.cpp:
Added #if ENABLE(WORKERS) because ThreadableWebSocketChannelClientWrapper is not used
if Web Workers is not available.
Changed access label because private members were declared as protected with no good reason.
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
Receive ScriptExecutionContext so we can post a task that should be executed later.
(WebCore::ThreadableWebSocketChannelClientWrapper::create):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasksCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
LayoutTests:
- http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op-expected.txt: Added.
- http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html: Added.
- http/tests/websocket/tests/hybi/workers/resources/no-onmessage-in-sync-op.js:
Added. The server sends messages immediately after the connection is established, but
these messages should not be delivered until the script exits the current cycle of
the event loop. The script calls a few synchronous operations to make sure we don't
fire MessageEvents while we are waiting for these operations to finish.
- http/tests/websocket/tests/hybi/workers/resources/no-onmessage-in-sync-op_wsh.py: Added.
- 12:26 AM Changeset in webkit [107787] by
-
- 17 edits2 moves in trunk/Source
[Texmap] Divide TextureMapperNode.cpp to 3 files.
https://bugs.webkit.org/show_bug.cgi?id=76660
Source/WebCore:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
No new tests.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::setParent):
(WebCore::GraphicsLayerTextureMapper::setChildren):
(WebCore::GraphicsLayerTextureMapper::addChild):
(WebCore::GraphicsLayerTextureMapper::addChildAtIndex):
(WebCore::GraphicsLayerTextureMapper::addChildAbove):
(WebCore::GraphicsLayerTextureMapper::addChildBelow):
(WebCore::GraphicsLayerTextureMapper::replaceChild):
(WebCore::GraphicsLayerTextureMapper::removeFromParent):
(WebCore::GraphicsLayerTextureMapper::setMaskLayer):
(WebCore::GraphicsLayerTextureMapper::setReplicatedByLayer):
(WebCore::GraphicsLayerTextureMapper::setPosition):
(WebCore::GraphicsLayerTextureMapper::setAnchorPoint):
(WebCore::GraphicsLayerTextureMapper::setSize):
(WebCore::GraphicsLayerTextureMapper::setTransform):
(WebCore::GraphicsLayerTextureMapper::setChildrenTransform):
(WebCore::GraphicsLayerTextureMapper::setPreserves3D):
(WebCore::GraphicsLayerTextureMapper::setMasksToBounds):
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):
(WebCore::GraphicsLayerTextureMapper::setContentsOpaque):
(WebCore::GraphicsLayerTextureMapper::setBackfaceVisibility):
(WebCore::GraphicsLayerTextureMapper::setOpacity):
(WebCore::GraphicsLayerTextureMapper::setContentsRect):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
(WebCore::GraphicsLayerTextureMapper::syncCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::syncCompositingState):
(WebCore::GraphicsLayerTextureMapper::addAnimation):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore):
(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::layer):
- platform/graphics/texmap/TextureMapperLayer.cpp: Renamed from Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp.
(WebCore):
(WebCore::toTextureMapperLayer):
(WebCore::TextureMapperLayer::rootLayer):
(WebCore::TextureMapperLayer::setTransform):
(WebCore::TextureMapperLayer::clearBackingStoresRecursive):
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::updateBackingStore):
(WebCore::TextureMapperLayer::paint):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::compareGraphicsLayersZValue):
(WebCore::TextureMapperLayer::sortByZOrder):
(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::TextureMapperLayer::intermediateSurfaceRect):
(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::~TextureMapperLayer):
(WebCore::TextureMapperLayer::syncCompositingState):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
(WebCore::TextureMapperLayer::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperLayer::syncAnimations):
(WebCore::TextureMapperLayer::syncAnimationsRecursively):
- platform/graphics/texmap/TextureMapperLayer.h: Renamed from Source/WebCore/platform/graphics/texmap/TextureMapperNode.h.
(WebCore):
(TextureMapperPaintOptions):
(WebCore::TextureMapperPaintOptions::TextureMapperPaintOptions):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::TextureMapperLayer):
(WebCore::TextureMapperLayer::size):
(WebCore::TextureMapperLayer::setOpacity):
(WebCore::TextureMapperLayer::setTextureMapper):
(WebCore::TextureMapperLayer::setShouldUpdateBackingStoreFromLayer):
(WebCore::TextureMapperLayer::setBackingStore):
(WebCore::TextureMapperLayer::backingStore):
(WebCore::TextureMapperLayer::texture):
(WebCore::TextureMapperLayer::layerRect):
(State):
(WebCore::TextureMapperLayer::State::State):
Source/WebKit/gtk:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
- WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::enabled):
(WebKit::AcceleratedCompositingContext::renderLayersToWindow):
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebKit::AcceleratedCompositingContext::syncLayersTimeout):
Source/WebKit/qt:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
- Api/qwebframe.cpp:
(QWebFramePrivate::renderCompositedLayers):
- Api/qwebframe.h:
(WebCore):
- Api/qwebframe_p.h:
(WebCore):
(QWebFramePrivate::QWebFramePrivate):
(QWebFramePrivate):
- WebCoreSupport/PageClientQt.cpp:
(WebCore::TextureMapperLayerClientQt::TextureMapperLayerClientQt):
(WebCore::TextureMapperLayerClientQt::setTextureMapper):
(WebCore::TextureMapperLayerClientQt::~TextureMapperLayerClientQt):
(WebCore::TextureMapperLayerClientQt::syncRootLayer):
(WebCore::TextureMapperLayerClientQt::rootLayer):
(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
- WebCoreSupport/PageClientQt.h:
(TextureMapperLayerClientQt):
(PageClientQWidget):
(PageClientQGraphicsWidget):
Source/WebKit2:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::createLayer):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::getBackingStore):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):
- 12:21 AM Changeset in webkit [107786] by
-
- 3 edits in trunk/Source/WebCore
ShadowRoot: Remove a public static factory function which doesn't have any callers.
https://bugs.webkit.org/show_bug.cgi?id=78668
Reviewed by Kent Tamura.
No tests. No change in behavior.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
- dom/ShadowRoot.h:
(ShadowRoot):
- 12:04 AM Changeset in webkit [107785] by
-
- 9 edits2 moves2 adds6 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #11 of N.
- platform/chromium-linux/svg/custom/image-rescale-clip-expected.png:
- platform/chromium-linux/svg/custom/image-rescale-clip-expected.txt: Removed.
- platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png:
- platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/custom/image-rescale-clip-expected.png:
- platform/chromium-mac-leopard/svg/custom/image-rescale-scroll-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/image-rescale-clip-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/image-rescale-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/image-rescale-scroll-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-rescale-scroll-expected.png.
- platform/chromium-mac/svg/custom/image-rescale-clip-expected.png: Removed.
- platform/chromium-mac/svg/custom/image-rescale-expected.png: Removed.
- platform/chromium-win/svg/custom/image-rescale-clip-expected.png:
- platform/chromium-win/svg/custom/image-rescale-expected.png:
- platform/chromium-win/svg/custom/image-rescale-scroll-expected.png:
- platform/chromium/test_expectations.txt:
- platform/mac/svg/custom/image-rescale-expected.txt: Removed.
- platform/qt/svg/custom/image-rescale-expected.txt: Removed.
- svg/custom/image-rescale-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/image-rescale-expected.txt.
