Context Navigation

← Previous Period
Next Period →

Timeline

Mar 20, 2012:

10:50 PM Changeset in webkit [111504] by eric@webkit.org

39 edits
1 move
1 add in trunk

Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
https://bugs.webkit.org/show_bug.cgi?id=80911

Reviewed by Adam Barth.

CMakeLists.txt: Define WTF_DIR

Source/JavaScriptCore:

Update the various build systems to depend on Source/WTF headers
as well as remove references to Platform.h (since it's now moved).

CMakeLists.txt:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
JavaScriptCore.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:

Source/WebCore:

CMakeLists.txt:
- Look for headers in Source/WTF as well.

Source/WebKit:

CMakeLists.txt: Look for headers in Source/WTF.

Source/WebKit/qt:

Fix WTF header include paths since although
Source/WTF is included, no longer are all the
subdirectories (thus "RefPtr.h" can't work).

Api/qwebdatabase_p.h:
Api/qwebscriptworld_p.h:
Api/qwebsecurityorigin_p.h:
WebCoreSupport/InspectorClientQt.h:
WebCoreSupport/QtFallbackWebPopup.h:
WebCoreSupport/QtWebComboBox.h:
declarative/experimental/experimental.pri:
declarative/public.pri:
tests/MIMESniffing/MIMESniffing.pro:

Source/WebKit2:

Update to not depend on "Foo.h" includes for WTF headers.

Shared/qt/QtNetworkReplyData.h:
Shared/qt/QtNetworkRequestData.cpp:
Shared/qt/QtNetworkRequestData.h:

Source/WTF:

Update build systems to account for the new location of Platform.h

GNUmakefile.list.am:
WTF.gypi:
WTF.pro:
WTF.vcproj/WTF.vcproj:
WTF.vcproj/work-around-vs-dependency-tracking-bugs.py:

(react_to_vsprops_changes):

WTF.xcodeproj/project.pbxproj:
config.h: I don't think this change is 100% correct (but seemed to be needed to make qt-wk2 build)
- This dependency on JSC should be removed regardless (in a later patch).
wtf/Platform.h: Renamed from Source/JavaScriptCore/wtf/Platform.h.

Tools:

Update include paths for Source/WTF.

DumpRenderTree/efl/CMakeLists.txt:
DumpRenderTree/qt/DumpRenderTree.pro:
QtTestBrowser/QtTestBrowser.pro:
Scripts/build-webkit: Build Source/WTF on AppleWin as well.

10:45 PM Changeset in webkit [111503] by abarth@webkit.org

2 edits in trunk/Tools

svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
https://bugs.webkit.org/show_bug.cgi?id=81567

Reviewed by Eric Seidel.

This temporary measure should help us avoid disrupting the folks
working on WebAudio when we move the webaudio directory to Modules.

Scripts/VCSUtils.pm:

(adjustPathForRecentRenamings):
(parseGitDiffHeader):
(parseSvnDiffHeader):

10:29 PM Changeset in webkit [111502] by commit-queue@webkit.org

4 edits in trunk/Source

[chromium] Use origin transform to transform occlusion from surface content space to its target content space
https://bugs.webkit.org/show_bug.cgi?id=81730

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent

platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):

Source/WebKit/chromium:

tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent):
(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):

10:26 PM Changeset in webkit [111501] by keishi@webkit.org

2 edits in trunk/LayoutTests

Adding MISSING to platform/qt for platform/qt/plugins/application-plugin-plugins-disabled.html

platform/chromium/test_expectations.txt:

10:12 PM Changeset in webkit [111500] by shinyak@chromium.org

13 edits
8 adds in trunk

[Crash] RenderMenuList::addChild() in Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=81201

Reviewed by Dimitri Glazkov.

Source/WebCore:

<audio>, <video>, <meter>, <progress>, and <select> are implemented using
Shadow DOM having HTMLContentElement. Their renderer children basically should not
create a renderer unless they are on the upper shadow encapsulation boundary,
which means they are the direct children of the shadow root.

However, current implementation allows their renderer children to create a renderer
even if they are on a lower shadow encapsulation boundary, which means
they are distributed elements of HTMLContentElement.

This patch makes there renderer children not to create a renderer if they are on a lower shadow
encapsulation boudary.

Tests: fast/dom/shadow/content-element-in-media-element.html

fast/dom/shadow/content-element-in-meter-element.html
fast/dom/shadow/content-element-in-progress-element.html
fast/dom/shadow/content-element-in-select-element.html

dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::isOnUpperEncapsulationBoundary):
(WebCore):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::childShouldCreateRenderer):

html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::childShouldCreateRenderer):

html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::childShouldCreateRenderer):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):

LayoutTests:

Skipped these tests in non-chromium port since SHADOW_DOM flag is not enabled.

Marked 2 new tests FAIL. Their behavior is affected by this patch, but this patch
won't fix them completely. They have another bugs. See Bug 81310 and Bug 81311.

fast/dom/shadow/content-element-in-media-element-expected.txt: Added.
fast/dom/shadow/content-element-in-media-element.html: Added.
fast/dom/shadow/content-element-in-meter-element-expected.txt: Added.
fast/dom/shadow/content-element-in-meter-element.html: Added.
fast/dom/shadow/content-element-in-progress-element-expected.txt: Added.
fast/dom/shadow/content-element-in-progress-element.html: Added.
fast/dom/shadow/content-element-in-select-element-expected.txt: Added.
fast/dom/shadow/content-element-in-select-element.html: Added.
platform/chromium/test_expectations.txt:
platform/efl/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:
platform/wk2/Skipped:

10:02 PM Changeset in webkit [111499] by commit-queue@webkit.org

8 edits in trunk/Source

[chromium] Store origin/screen space transforms for surface and replica in the surface
https://bugs.webkit.org/show_bug.cgi?id=81296

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

Compute and save a number of transforms for render surfaces. The origin
tranform for the replica into its target surface. The origin transform
for the replica into the screen. And the origin transform for the surface
into the screen.

These transforms will allow us to detect occlusion of render surfaces,
allowing us to cull (or partially-cull) the render surface quad during
drawing.

This also fixes a subtle bug in the transforms used by the damage
tracking code.

Unit test: CCLayerTreeHostCommonTest.verifyTransformsForSingleRenderSurface

CCLayerTreeHostCommonTest.verifyTransformsForReplica
CCLayerTreeHostCommonTest.verifyTransformsForRenderSurfaceHierarchy

platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::screenSpaceTransform):
(WebCore::RenderSurfaceChromium::setScreenSpaceTransform):
(RenderSurfaceChromium):
(WebCore::RenderSurfaceChromium::replicaOriginTransform):
(WebCore::RenderSurfaceChromium::setReplicaOriginTransform):
(WebCore::RenderSurfaceChromium::replicaScreenSpaceTransform):
(WebCore::RenderSurfaceChromium::setReplicaScreenSpaceTransform):

platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForRenderSurface):

platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::damageInSurfaceSpace):

platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::setDrawTransform):
(WebCore::CCRenderSurface::drawTransform):
(WebCore::CCRenderSurface::setScreenSpaceTransform):
(WebCore::CCRenderSurface::screenSpaceTransform):
(CCRenderSurface):
(WebCore::CCRenderSurface::setReplicaDrawTransform):
(WebCore::CCRenderSurface::replicaDrawTransform):
(WebCore::CCRenderSurface::setReplicaOriginTransform):
(WebCore::CCRenderSurface::replicaOriginTransform):
(WebCore::CCRenderSurface::setReplicaScreenSpaceTransform):
(WebCore::CCRenderSurface::replicaScreenSpaceTransform):

Source/WebKit/chromium:

tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

9:47 PM Changeset in webkit [111498] by mitz@apple.com

2 edits in trunk/LayoutTests

Skipped editing/selection/move-by-word-visually-crash-test-5.html in WebKit2 because of
<http://webkit.org/b/42689> WebKitTestRunner needs layoutTestController.setEditingBehavior

platform/wk2/Skipped:

9:46 PM Changeset in webkit [111497] by commit-queue@webkit.org

10 edits in trunk

[Forms] The option element should not be form associated element.
https://bugs.webkit.org/show_bug.cgi?id=79764

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-20
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes base class of HTMLOptionELement to HTMLElement
from HTMLFormControlElement for saving memory space and iteration
time of extra "option" elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.

This patch changes behavior of handling of CSS pseudo classes "invalid"
and "valid". The "option" elements no longer use these CSS pseudo classes
as HTML5 specification. This bug was filed in https://bugs.webkit.org/show_bug.cgi?id=80088

Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
https://bugs.webkit.org/show_bug.cgi?id=80381

No new tests but updated select-live-pseudo-selectors.html test.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement): Added checking of the "option" element and returns false as HTMLFormControlElement.

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Removed isFormControlElement for PseudoDisabled and PseudoChecked.

html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement): Removed form parameter of call site of HTMLOptionElement::create.

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::HTMLOptionElement): Removed form parameter which no longer needed. Changed base class in initialization list. Added m_disabled initialization.
(WebCore::HTMLOptionElement::create): Removed form parameter which no longer needed.
(WebCore::HTMLOptionElement::attach): Changeid base class.
(WebCore::HTMLOptionElement::detach): Changed base class.
(WebCore::HTMLOptionElement::parseAttribute): Changed base class. Added "disabled" attribute handling.
(WebCore::HTMLOptionElement::childrenChanged): Changed base class.
(WebCore::HTMLOptionElement::insertedIntoTree): Changed base class.

html/HTMLOptionElement.h:

(HTMLOptionElement): Added new member variable m_disabled which was in HTMLFormControlElement.
(WebCore::HTMLOptionElement::ownElementDisabled): Changed for using m_disabled.

html/HTMLTagNames.in: Removed constructorNeedsFormElement for the "option" element, which was used for passing form parameter to create function.

LayoutTests:

This patch fixes a bug in select-live-pseudo-selectors.js, adds
assertions to improve coverage, and updates test expectation for
behavior changes (makes the "option" element uses CSS pseudo class
":valid".)

fast/forms/resources/select-live-pseudo-selectors.js:

(mouseDownOnSelect): Copied from listbox-selection.html for replacing broken simulateClick which used position and size of the "option" element, but these values are zero. Note: five files use mouseDownOnSelect. We'll share this function in future tracked by https://bugs.webkit.org/show_bug.cgi?id=81496.
(backgroundOf): Added String parameter support for ease of writing test case.

fast/forms/select-live-pseudo-selectors-expected.txt: Added check fo background color of the "selection" element. Changed expected color of the "option" element because the "option" element doesn't support CSS pseudo class ":valid". This also covers bug 80088.

9:33 PM Changeset in webkit [111496] by mitz@apple.com

2 edits in trunk/LayoutTests

Skipped fast/selectors/selection-window-inactive.html in WebKit2 because of
<http://webkit.org/b/81736> layoutTestController.setWindowIsKey() has no effect on the web process side in WebKit2

platform/wk2/Skipped:

9:23 PM Changeset in webkit [111495] by mitz@apple.com

2 edits in trunk/LayoutTests

Skipped fast/events/blur-focus-window-should-blur-focus-element.html in WebKit2 because of
<http://webkit.org/b/81736> layoutTestController.setWindowIsKey() has no effect on the web process side in WebKit2

platform/wk2/Skipped:

9:18 PM Changeset in webkit [111494] by keishi@webkit.org

2 edits in trunk/LayoutTests

[chromium] Marking canvas-toDataURL-webp.html as crashing and timing out.

platform/chromium/test_expectations.txt:

9:01 PM Changeset in webkit [111493] by andersca@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (r110780): Loading a PDF always makes the WKView layer backed
https://bugs.webkit.org/show_bug.cgi?id=81734
<rdar://problem/11088172>

Reviewed by Adele Peterson.

UIProcess/API/mac/WKView.mm:

(-[WKView _setPageHasCustomRepresentation:]):
Don't call -[NSView setWantsLayer:], the web process already takes care of entering and exiting
accelerated compositing mode for us.

8:56 PM Changeset in webkit [111492] by xji@chromium.org

3 edits
2 adds in trunk

Crash introduced in r110965.
https://bugs.webkit.org/show_bug.cgi?id=81720

Reviewed by Ryosuke Niwa.

Source/WebCore:

Since word break iterator just keeps a pointer to the UChar array given to the constructor,
we need to allocate the UChar array deeper in the stack than the iterator.

Test: editing/selection/move-by-word-visually-crash-test-5.html

editing/visible_units.cpp:

(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):
(WebCore::visualWordPosition):

LayoutTests:

editing/selection/move-by-word-visually-crash-test-5-expected.txt: Added.
editing/selection/move-by-word-visually-crash-test-5.html: Added.

8:50 PM Changeset in webkit [111491] by cevans@google.com

1 edit in branches/chromium/1025/Source/WebCore/WebCore.gyp/WebCore.gyp

Merge 110541
BUG=117545
Review URL: https://chromiumcodereview.appspot.com/9801010

8:46 PM Changeset in webkit [111490] by cevans@google.com

5 edits
2 copies in branches/chromium/1025

Merge 110563
BUG=117471
Review URL: https://chromiumcodereview.appspot.com/9802004

8:41 PM Changeset in webkit [111489] by keishi@webkit.org

2 edits in trunk/LayoutTests

[chromium] Marking integer-division-neg2tothe32-by-neg1.html as crashing.

platform/chromium/test_expectations.txt:

8:39 PM Changeset in webkit [111488] by Lucas Forschler

13 edits in branches/safari-534.56-branch/Source

Merged r111162.

7:31 PM Changeset in webkit [111487] by keishi@webkit.org

1 edit
1 copy
2 moves
1 delete in trunk/LayoutTests

[chromium] Rebaselining font-family-pictograph.html on Mac.

fast/css/font-family-pictograph-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-family-pictograph-expected.png.
fast/css/font-family-pictograph-expected.txt: Copied from LayoutTests/platform/efl/fast/css/font-family-pictograph-expected.txt.
platform/chromium-mac/fast/css/font-family-pictograph-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-family-pictograph-expected.txt.
platform/gtk/fast/css/font-family-pictograph-expected.png: Removed.

7:31 PM Changeset in webkit [111486] by cevans@google.com

1 edit in branches/chromium/1025/Source/WebCore/html/HTMLFrameElementBase.cpp

Merge 111108
BUG=117550
Review URL: https://chromiumcodereview.appspot.com/9768010

7:28 PM Changeset in webkit [111485] by keishi@webkit.org

1 edit
2 adds in trunk/LayoutTests

[chromium] Rebaselining for Linux 32.

platform/chromium-linux-x86/fast/dom/error-to-string-stack-overflow-expected.txt: Added.

7:18 PM Changeset in webkit [111484] by adamk@chromium.org

2 edits in trunk/LayoutTests

Unskip the over one thousand dom/xhtml tests that pass
https://bugs.webkit.org/show_bug.cgi?id=81709

Reviewed by Tony Chang.

I recently ran into a case where a test in dom/xhtml caught a
regression in a patch (r111310). Seems like we should at least run
those tests that pass in this suite. I've left the other tests
skipped, though I'm open to rebaselining or running them with failing
expectations.

platform/chromium/test_expectations.txt:

7:06 PM Changeset in webkit [111483] by wjmaclean@chromium.org

4 edits in trunk/Source

[chromium] Convert TouchFlingPlatformGestureCurve to a 2-D Bezier for better control of curve shape.
https://bugs.webkit.org/show_bug.cgi?id=81713

Reviewed by Dirk Pranke.

Source/WebCore:

Exisiting unit test revised to cover this change.

Change the fling gesture animation curve to use a 2-D Bezier to obtain greater control
over the shape of the curve. Also, change time scaling code to be logarithmic for more
natural feel.

platform/TouchFlingPlatformGestureCurve.cpp:

(WebCore::TouchFlingPlatformGestureCurve::TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::apply):

Source/WebKit/chromium:

tests/PlatformGestureCurveTest.cpp:

7:00 PM Changeset in webkit [111482] by tkent@chromium.org

13 edits
4 deletes in branches/chromium/1025

Revert 105710 - Introduce RadioButtonGroup class to keep track of the group members and required state
https://bugs.webkit.org/show_bug.cgi?id=74909

Reviewed by Darin Adler.

Source/WebCore:

RadioButtonGroup contains a set of member radio buttons in the group,
and "required" status of the group. This helps implementing correct
radio button validity, and improving performance of updating validity
status of radio buttons.

This change fixes the following bugs:

A radio button should be "required" if one of a member of the same group has the "required" attribute. https://bugs.webkit.org/show_bug.cgi?id=76365
:invalid style is not applied when a checked radio button is removed from its radio group https://bugs.webkit.org/show_bug.cgi?id=74914
Loading a page with N radio buttons in a group takes O(N^{2) time.}

Tests: fast/forms/radio/radio-live-validation-style.html

perf/adding-radio-buttons.html

dom/CheckedRadioButtons.cpp:

(WebCore::RadioButtonGroup::isEmpty):
(WebCore::RadioButtonGroup::isRequired):
(WebCore::RadioButtonGroup::checkedButton):
(WebCore::RadioButtonGroup::RadioButtonGroup):
(WebCore::RadioButtonGroup::create):
(WebCore::RadioButtonGroup::isValid):
(WebCore::RadioButtonGroup::setCheckedButton):
(WebCore::RadioButtonGroup::add):
(WebCore::RadioButtonGroup::updateCheckedState):
(WebCore::RadioButtonGroup::requiredAttributeChanged):
(WebCore::RadioButtonGroup::remove):
(WebCore::RadioButtonGroup::setNeedsValidityCheckForAllButtons):
Add RadioButtonGroup class. It keeps track of pointers to member radio
buttons and required status of the group in addition to the checked
radio button pointer.

(WebCore::CheckedRadioButtons::CheckedRadioButtons):
(WebCore::CheckedRadioButtons::~CheckedRadioButtons):
Define empty constructor and destructor in order to avoid exposing
RadioButtonGroup class.

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::updateCheckedState):
(WebCore::CheckedRadioButtons::requiredAttributeChanged):
(WebCore::CheckedRadioButtons::checkedButtonForGroup):
(WebCore::CheckedRadioButtons::isInRequiredGroup):
(WebCore::CheckedRadioButtons::removeButton):
Change the HashMap member of this class so that it maps a group name to
a RadioButtonGroup object. These functions just get a RadioButtonGroup
object and call a corresponding member function of RadioButtonGroup.

dom/CheckedRadioButtons.h: Update declarations.

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::parseMappedAttribute):
(WebCore::HTMLFormControlElement::requiredAttributeChanged):
Move a part of parseMappedAttribute() into requiredAttributeChanged().

html/HTMLFormControlElement.h: Add requiredAttributeChanged().
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::valueMissing):
Move required check code to InputType::valueMissing implementations.
RadioInputType needs special handling for checking required state.
readOnly() and disabled() are unnecessary because willValidate() checks them.
(WebCore::HTMLInputElement::setChecked):
Call new function CheckedRadioButtons::updateCheckedState() instead of
removeButton() and updateCheckedRadioButtons().
(WebCore::HTMLInputElement::requiredAttributeChanged):
Override this to call CheckedRadioButtons::requiredAttributeChanged().

html/HTMLInputElement.h: Add requiredAttributeChanged().
html/RadioInputType.cpp:

(WebCore::RadioInputType::valueMissing):
Check required state by CheckedRadioButtons::isInRequiredGroup().

html/RadioInputType.h: Remove attach().

html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::valueMissing):

Move required check from HTMLInputElement::valueMissing().

html/FileInputType.cpp:

(WebCore::FileInputType::valueMissing): ditto.

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::valueMissing): ditto.

LayoutTests:

fast/forms/radio/radio-live-validation-style-expected.txt: Added.
fast/forms/radio/radio-live-validation-style.html: Added.

fast/forms/script-tests/ValidityState-valueMissing-radio.js:
Update the expectation for the behavior change of https://bugs.webkit.org/show_bug.cgi?id=76365
Add test cases for radio buttons not in a radio button group.
fast/forms/ValidityState-valueMissing-radio-expected.txt: ditto.

perf/adding-radio-buttons-expected.txt: Added.
perf/adding-radio-buttons.html: Added.

TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9805002

6:29 PM Changeset in webkit [111481] by fpizlo@apple.com

13 edits
3 adds in trunk

op_mod fails on many interesting corner cases
https://bugs.webkit.org/show_bug.cgi?id=81648

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Removed most strength reduction for op_mod, and fixed the integer handling
to do the right thing for corner cases. Oddly, this revealed bugs in OSR,
which this patch also fixes.

This patch is performance neutral on all of the major benchmarks we track.

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGSpeculativeJIT.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileArithMod):

jit/JIT.h:

(JIT):

jit/JITArithmetic.cpp:

(JSC):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC):

jit/JITStubs.h:

(TrampolineStructure):
(JSC::JITThunks::ctiNativeConstruct):

llint/LowLevelInterpreter64.asm:
wtf/Platform.h:
wtf/SimpleStats.h:

(WTF::SimpleStats::variance):

LayoutTests:

Reviewed by Oliver Hunt.

fast/js/integer-division-neg2tothe32-by-neg1-expected.txt: Added.
fast/js/integer-division-neg2tothe32-by-neg1.html: Added.
fast/js/script-tests/integer-division-neg2tothe32-by-neg1.js: Added.

(myDiv):
(myDivByNeg1):
(myDivNeg2ToThe31):
(myMod):
(myModByNeg1):
(myModNeg2ToThe31):
(myOtherDiv):
(myOtherDivByNeg1):
(myOtherDivNeg2ToThe31):
(myOtherMod):
(myOtherModByNeg1):
(myOtherModNeg2ToThe31):

6:19 PM Changeset in webkit [111480] by morrita@google.com

8 edits in trunk/Source/WebCore

Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Patch by Tim Horton <timothy_horton@apple.com> on 2012-03-18
Reviewed by Nikolas Zimmermann.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.

No new tests, as the problem only occurs in a nonstandard configuration.

page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::startDeferredRepaintTimer):
(WebCore):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):
(WebCore::FrameView::beginDisableRepaints):
(WebCore::FrameView::endDisableRepaints):

page/FrameView.h:

(FrameView):
(WebCore::FrameView::repaintsDisabled):

rendering/RenderView.cpp:

(WebCore::RenderView::shouldRepaint):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):

svg/graphics/SVGImage.h:

(WebCore):

svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):

svg/graphics/SVGImageCache.h:

(SVGImageCache):

6:01 PM Changeset in webkit [111479] by cevans@google.com

1 edit in branches/chromium/963/Source/WebCore/html/HTMLFrameElementBase.cpp

Merge 111108
BUG=117550
Review URL: https://chromiumcodereview.appspot.com/9766014

5:48 PM Changeset in webkit [111478] by adamk@chromium.org

2 edits in trunk/Source/WebCore

Include fix for dom/xhtml test promised in r111449.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceChild): Check against next instead of
prev when deciding there's no work to do.

5:36 PM Changeset in webkit [111477] by jonlee@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Because we might short-circuit permission calls, some of these tests need to be rewritten
to take that factor into account. There's no mac support of notifications right now (see 79492),
so updating test expectations for now and tracking as a regression in 81697.

platform/chromium/test_expectations.txt:

5:34 PM Changeset in webkit [111476] by jonlee@apple.com

10 edits in trunk/Source

Restrict access to notifications for unique origins and file URLs with no local file access
https://bugs.webkit.org/show_bug.cgi?id=79704
<rdar://problem/10912430>

Reviewed by Adam Barth.

Source/WebCore:

Before checking or requesting permissions, we look at whether we can show notifications based on
the security context. If not, we short circuit and do not forward the request to the client.

notifications/Notification.cpp:

(WebCore::Notification::Notification): Fix a bug where creating a notification goes through slightly
different logic for checking permissions than when checking permissions through the
notification center.

notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::checkPermission): Check to see if the origin can show notifications.
(WebCore::NotificationCenter::requestPermission): If we know whether an origin can show notifications,
we asynchronously call the callback with that decision. Otherwise we ask the client.

Add new variable in the notification center to keep track of pending callbacks when we short-circuit
requestPermission().

notifications/NotificationCenter.h:

(NotificationRequestCallback): Add new private class encapsulating the callback.

notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::requestTimedOut): Remove the request from the set of pending callbacks.
(WebCore::NotificationCenter::NotificationRequest::createAndStartTimer): Because this is used when we already
know the decision, and are not asking the client to decide, we can immediately trigger a one-shot timer
to invoke the callback.
(WebCore::NotificationCenter::NotificationRequest::NotificationRequest):
(WebCore::NotificationCenter::NotificationRequest::startTimer):
(WebCore::NotificationCenter::NotificationRequest::timerFired): Invoke the callback and tell the notification
center.

page/SecurityOrigin.h: Add new toRawString() method to return the string representation of the origin,

regardless of any restrictions that might otherwise cause toString() to return "null".

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canShowNotifications): Added to return a tri-state regarding whether we know
the origin can show notifications. If the origin is unique, we never let it show. If the origin has
universal access, we always let it show. Otherwise the client should be asked.
(WebCore::SecurityOrigin::toString): Refactor to use toRawString().
(WebCore::SecurityOrigin::toRawString):

Added FIXME's regarding the naming of enforceFilePathSeparation().

dom/Document.cpp:

(WebCore::Document::initSecurityContext): Also, tab reformatting.

WebCore.exp.in: Export toRawString().

Source/WebKit2:

In the specific case where a file URL has restricted file access and is denied universal access,
SecurityOrigin::canShowNotifications() returns Ask, since it is not considered a unique origin.
The cached table of permissions held by the notification manager will typically not have an entry for
the toString() representation of these file URLs, which is "null", since that can also cover unique
origins, and it is possible that the client will want different permissions between the two types.

It is reasonable, however, for there to be an entry for "file://", so we use toRawString() to do the lookup.

WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):

5:32 PM Changeset in webkit [111475] by abarth@webkit.org

1 edit in branches/chromium/1025/Source/WebCore/bindings/v8/V8NPUtils.cpp

Revert 105389 - [v8] Low efficiency of writing long string from web application to plugin.
https://bugs.webkit.org/show_bug.cgi?id=76592

The efficiency will be improved by 300 times in the best case, when the
size of string reaches 1MB.

Patch by Li Yin <li.yin@intel.com> on 2012-01-18
Reviewed by Adam Barth.

bindings/v8/V8NPUtils.cpp:

(WebCore::convertV8ObjectToNPVariant):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9766013

5:30 PM Changeset in webkit [111474] by haraken@chromium.org

10 edits
104 moves
1 add in trunk/Source/WebCore

Move webaudio to Modules/webaudio/
https://bugs.webkit.org/show_bug.cgi?id=81541

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-20
Reviewed by Kentaro Hara.

No new tests, all existing tests pass.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.am:
GNUmakefile.list.am:
Modules/webaudio: Added.
Modules/webaudio/AsyncAudioDecoder.cpp: Copied from Source/WebCore/webaudio/AsyncAudioDecoder.cpp.
Modules/webaudio/AsyncAudioDecoder.h: Copied from Source/WebCore/webaudio/AsyncAudioDecoder.h.
Modules/webaudio/AudioBasicProcessorNode.cpp: Copied from Source/WebCore/webaudio/AudioBasicProcessorNode.cpp.
Modules/webaudio/AudioBasicProcessorNode.h: Copied from Source/WebCore/webaudio/AudioBasicProcessorNode.h.
Modules/webaudio/AudioBuffer.cpp: Copied from Source/WebCore/webaudio/AudioBuffer.cpp.
Modules/webaudio/AudioBuffer.h: Copied from Source/WebCore/webaudio/AudioBuffer.h.
Modules/webaudio/AudioBuffer.idl: Copied from Source/WebCore/webaudio/AudioBuffer.idl.
Modules/webaudio/AudioBufferCallback.h: Copied from Source/WebCore/webaudio/AudioBufferCallback.h.
Modules/webaudio/AudioBufferCallback.idl: Copied from Source/WebCore/webaudio/AudioBufferCallback.idl.
Modules/webaudio/AudioBufferSourceNode.cpp: Copied from Source/WebCore/webaudio/AudioBufferSourceNode.cpp.
Modules/webaudio/AudioBufferSourceNode.h: Copied from Source/WebCore/webaudio/AudioBufferSourceNode.h.
Modules/webaudio/AudioBufferSourceNode.idl: Copied from Source/WebCore/webaudio/AudioBufferSourceNode.idl.
Modules/webaudio/AudioChannelMerger.cpp: Copied from Source/WebCore/webaudio/AudioChannelMerger.cpp.
Modules/webaudio/AudioChannelMerger.h: Copied from Source/WebCore/webaudio/AudioChannelMerger.h.
Modules/webaudio/AudioChannelMerger.idl: Copied from Source/WebCore/webaudio/AudioChannelMerger.idl.
Modules/webaudio/AudioChannelSplitter.cpp: Copied from Source/WebCore/webaudio/AudioChannelSplitter.cpp.
Modules/webaudio/AudioChannelSplitter.h: Copied from Source/WebCore/webaudio/AudioChannelSplitter.h.
Modules/webaudio/AudioChannelSplitter.idl: Copied from Source/WebCore/webaudio/AudioChannelSplitter.idl.
Modules/webaudio/AudioContext.cpp: Copied from Source/WebCore/webaudio/AudioContext.cpp.
Modules/webaudio/AudioContext.h: Copied from Source/WebCore/webaudio/AudioContext.h.
Modules/webaudio/AudioContext.idl: Copied from Source/WebCore/webaudio/AudioContext.idl.
Modules/webaudio/AudioDestinationNode.cpp: Copied from Source/WebCore/webaudio/AudioDestinationNode.cpp.
Modules/webaudio/AudioDestinationNode.h: Copied from Source/WebCore/webaudio/AudioDestinationNode.h.
Modules/webaudio/AudioDestinationNode.idl: Copied from Source/WebCore/webaudio/AudioDestinationNode.idl.
Modules/webaudio/AudioGain.h: Copied from Source/WebCore/webaudio/AudioGain.h.
Modules/webaudio/AudioGain.idl: Copied from Source/WebCore/webaudio/AudioGain.idl.
Modules/webaudio/AudioGainNode.cpp: Copied from Source/WebCore/webaudio/AudioGainNode.cpp.
Modules/webaudio/AudioGainNode.h: Copied from Source/WebCore/webaudio/AudioGainNode.h.
Modules/webaudio/AudioGainNode.idl: Copied from Source/WebCore/webaudio/AudioGainNode.idl.
Modules/webaudio/AudioListener.cpp: Copied from Source/WebCore/webaudio/AudioListener.cpp.
Modules/webaudio/AudioListener.h: Copied from Source/WebCore/webaudio/AudioListener.h.
Modules/webaudio/AudioListener.idl: Copied from Source/WebCore/webaudio/AudioListener.idl.
Modules/webaudio/AudioNode.cpp: Copied from Source/WebCore/webaudio/AudioNode.cpp.
Modules/webaudio/AudioNode.h: Copied from Source/WebCore/webaudio/AudioNode.h.
Modules/webaudio/AudioNode.idl: Copied from Source/WebCore/webaudio/AudioNode.idl.
Modules/webaudio/AudioNodeInput.cpp: Copied from Source/WebCore/webaudio/AudioNodeInput.cpp.
Modules/webaudio/AudioNodeInput.h: Copied from Source/WebCore/webaudio/AudioNodeInput.h.
Modules/webaudio/AudioNodeOutput.cpp: Copied from Source/WebCore/webaudio/AudioNodeOutput.cpp.
Modules/webaudio/AudioNodeOutput.h: Copied from Source/WebCore/webaudio/AudioNodeOutput.h.
Modules/webaudio/AudioPannerNode.cpp: Copied from Source/WebCore/webaudio/AudioPannerNode.cpp.
Modules/webaudio/AudioPannerNode.h: Copied from Source/WebCore/webaudio/AudioPannerNode.h.
Modules/webaudio/AudioPannerNode.idl: Copied from Source/WebCore/webaudio/AudioPannerNode.idl.
Modules/webaudio/AudioParam.cpp: Copied from Source/WebCore/webaudio/AudioParam.cpp.
Modules/webaudio/AudioParam.h: Copied from Source/WebCore/webaudio/AudioParam.h.
Modules/webaudio/AudioParam.idl: Copied from Source/WebCore/webaudio/AudioParam.idl.
Modules/webaudio/AudioParamTimeline.cpp: Copied from Source/WebCore/webaudio/AudioParamTimeline.cpp.
Modules/webaudio/AudioParamTimeline.h: Copied from Source/WebCore/webaudio/AudioParamTimeline.h.
Modules/webaudio/AudioProcessingEvent.cpp: Copied from Source/WebCore/webaudio/AudioProcessingEvent.cpp.
Modules/webaudio/AudioProcessingEvent.h: Copied from Source/WebCore/webaudio/AudioProcessingEvent.h.
Modules/webaudio/AudioProcessingEvent.idl: Copied from Source/WebCore/webaudio/AudioProcessingEvent.idl.
Modules/webaudio/AudioSourceNode.h: Copied from Source/WebCore/webaudio/AudioSourceNode.h.
Modules/webaudio/AudioSourceNode.idl: Copied from Source/WebCore/webaudio/AudioSourceNode.idl.
Modules/webaudio/BiquadDSPKernel.cpp: Copied from Source/WebCore/webaudio/BiquadDSPKernel.cpp.
Modules/webaudio/BiquadDSPKernel.h: Copied from Source/WebCore/webaudio/BiquadDSPKernel.h.
Modules/webaudio/BiquadFilterNode.cpp: Copied from Source/WebCore/webaudio/BiquadFilterNode.cpp.
Modules/webaudio/BiquadFilterNode.h: Copied from Source/WebCore/webaudio/BiquadFilterNode.h.
Modules/webaudio/BiquadFilterNode.idl: Copied from Source/WebCore/webaudio/BiquadFilterNode.idl.
Modules/webaudio/BiquadProcessor.cpp: Copied from Source/WebCore/webaudio/BiquadProcessor.cpp.
Modules/webaudio/BiquadProcessor.h: Copied from Source/WebCore/webaudio/BiquadProcessor.h.
Modules/webaudio/ConvolverNode.cpp: Copied from Source/WebCore/webaudio/ConvolverNode.cpp.
Modules/webaudio/ConvolverNode.h: Copied from Source/WebCore/webaudio/ConvolverNode.h.
Modules/webaudio/ConvolverNode.idl: Copied from Source/WebCore/webaudio/ConvolverNode.idl.
Modules/webaudio/DOMWindowWebAudio.idl: Copied from Source/WebCore/webaudio/DOMWindowWebAudio.idl.
Modules/webaudio/DefaultAudioDestinationNode.cpp: Copied from Source/WebCore/webaudio/DefaultAudioDestinationNode.cpp.
Modules/webaudio/DefaultAudioDestinationNode.h: Copied from Source/WebCore/webaudio/DefaultAudioDestinationNode.h.
Modules/webaudio/DelayDSPKernel.cpp: Copied from Source/WebCore/webaudio/DelayDSPKernel.cpp.
Modules/webaudio/DelayDSPKernel.h: Copied from Source/WebCore/webaudio/DelayDSPKernel.h.
Modules/webaudio/DelayNode.cpp: Copied from Source/WebCore/webaudio/DelayNode.cpp.
Modules/webaudio/DelayNode.h: Copied from Source/WebCore/webaudio/DelayNode.h.
Modules/webaudio/DelayNode.idl: Copied from Source/WebCore/webaudio/DelayNode.idl.
Modules/webaudio/DelayProcessor.cpp: Copied from Source/WebCore/webaudio/DelayProcessor.cpp.
Modules/webaudio/DelayProcessor.h: Copied from Source/WebCore/webaudio/DelayProcessor.h.
Modules/webaudio/DynamicsCompressorNode.cpp: Copied from Source/WebCore/webaudio/DynamicsCompressorNode.cpp.
Modules/webaudio/DynamicsCompressorNode.h: Copied from Source/WebCore/webaudio/DynamicsCompressorNode.h.
Modules/webaudio/DynamicsCompressorNode.idl: Copied from Source/WebCore/webaudio/DynamicsCompressorNode.idl.
Modules/webaudio/HighPass2FilterNode.cpp: Copied from Source/WebCore/webaudio/HighPass2FilterNode.cpp.
Modules/webaudio/HighPass2FilterNode.h: Copied from Source/WebCore/webaudio/HighPass2FilterNode.h.
Modules/webaudio/HighPass2FilterNode.idl: Copied from Source/WebCore/webaudio/HighPass2FilterNode.idl.
Modules/webaudio/JavaScriptAudioNode.cpp: Copied from Source/WebCore/webaudio/JavaScriptAudioNode.cpp.
Modules/webaudio/JavaScriptAudioNode.h: Copied from Source/WebCore/webaudio/JavaScriptAudioNode.h.
Modules/webaudio/JavaScriptAudioNode.idl: Copied from Source/WebCore/webaudio/JavaScriptAudioNode.idl.
Modules/webaudio/LowPass2FilterNode.cpp: Copied from Source/WebCore/webaudio/LowPass2FilterNode.cpp.
Modules/webaudio/LowPass2FilterNode.h: Copied from Source/WebCore/webaudio/LowPass2FilterNode.h.
Modules/webaudio/LowPass2FilterNode.idl: Copied from Source/WebCore/webaudio/LowPass2FilterNode.idl.
Modules/webaudio/MediaElementAudioSourceNode.cpp: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp.
Modules/webaudio/MediaElementAudioSourceNode.h: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.h.
Modules/webaudio/MediaElementAudioSourceNode.idl: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.idl.
Modules/webaudio/OfflineAudioCompletionEvent.cpp: Copied from Source/WebCore/webaudio/OfflineAudioCompletionEvent.cpp.
Modules/webaudio/OfflineAudioCompletionEvent.h: Copied from Source/WebCore/webaudio/OfflineAudioCompletionEvent.h.
Modules/webaudio/OfflineAudioCompletionEvent.idl: Copied from Source/WebCore/webaudio/OfflineAudioCompletionEvent.idl.
Modules/webaudio/OfflineAudioDestinationNode.cpp: Copied from Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp.
Modules/webaudio/OfflineAudioDestinationNode.h: Copied from Source/WebCore/webaudio/OfflineAudioDestinationNode.h.
Modules/webaudio/RealtimeAnalyser.cpp: Copied from Source/WebCore/webaudio/RealtimeAnalyser.cpp.
Modules/webaudio/RealtimeAnalyser.h: Copied from Source/WebCore/webaudio/RealtimeAnalyser.h.
Modules/webaudio/RealtimeAnalyserNode.cpp: Copied from Source/WebCore/webaudio/RealtimeAnalyserNode.cpp.
Modules/webaudio/RealtimeAnalyserNode.h: Copied from Source/WebCore/webaudio/RealtimeAnalyserNode.h.
Modules/webaudio/RealtimeAnalyserNode.idl: Copied from Source/WebCore/webaudio/RealtimeAnalyserNode.idl.
Modules/webaudio/WaveShaperDSPKernel.cpp: Copied from Source/WebCore/webaudio/WaveShaperDSPKernel.cpp.
Modules/webaudio/WaveShaperDSPKernel.h: Copied from Source/WebCore/webaudio/WaveShaperDSPKernel.h.
Modules/webaudio/WaveShaperNode.cpp: Copied from Source/WebCore/webaudio/WaveShaperNode.cpp.
Modules/webaudio/WaveShaperNode.h: Copied from Source/WebCore/webaudio/WaveShaperNode.h.
Modules/webaudio/WaveShaperNode.idl: Copied from Source/WebCore/webaudio/WaveShaperNode.idl.
Modules/webaudio/WaveShaperProcessor.cpp: Copied from Source/WebCore/webaudio/WaveShaperProcessor.cpp.
Modules/webaudio/WaveShaperProcessor.h: Copied from Source/WebCore/webaudio/WaveShaperProcessor.h.
WebCore.gyp/WebCore.gyp:
WebCore.gypi:
WebCore.pri:
WebCore.xcodeproj/project.pbxproj:
webaudio/AsyncAudioDecoder.cpp: Removed.
webaudio/AsyncAudioDecoder.h: Removed.
webaudio/AudioBasicProcessorNode.cpp: Removed.
webaudio/AudioBasicProcessorNode.h: Removed.
webaudio/AudioBuffer.cpp: Removed.
webaudio/AudioBuffer.h: Removed.
webaudio/AudioBuffer.idl: Removed.
webaudio/AudioBufferCallback.h: Removed.
webaudio/AudioBufferCallback.idl: Removed.
webaudio/AudioBufferSourceNode.cpp: Removed.
webaudio/AudioBufferSourceNode.h: Removed.
webaudio/AudioBufferSourceNode.idl: Removed.
webaudio/AudioChannelMerger.cpp: Removed.
webaudio/AudioChannelMerger.h: Removed.
webaudio/AudioChannelMerger.idl: Removed.
webaudio/AudioChannelSplitter.cpp: Removed.
webaudio/AudioChannelSplitter.h: Removed.
webaudio/AudioChannelSplitter.idl: Removed.
webaudio/AudioContext.cpp: Removed.
webaudio/AudioContext.h: Removed.
webaudio/AudioContext.idl: Removed.
webaudio/AudioDestinationNode.cpp: Removed.
webaudio/AudioDestinationNode.h: Removed.
webaudio/AudioDestinationNode.idl: Removed.
webaudio/AudioGain.h: Removed.
webaudio/AudioGain.idl: Removed.
webaudio/AudioGainNode.cpp: Removed.
webaudio/AudioGainNode.h: Removed.
webaudio/AudioGainNode.idl: Removed.
webaudio/AudioListener.cpp: Removed.
webaudio/AudioListener.h: Removed.
webaudio/AudioListener.idl: Removed.
webaudio/AudioNode.cpp: Removed.
webaudio/AudioNode.h: Removed.
webaudio/AudioNode.idl: Removed.
webaudio/AudioNodeInput.cpp: Removed.
webaudio/AudioNodeInput.h: Removed.
webaudio/AudioNodeOutput.cpp: Removed.
webaudio/AudioNodeOutput.h: Removed.
webaudio/AudioPannerNode.cpp: Removed.
webaudio/AudioPannerNode.h: Removed.
webaudio/AudioPannerNode.idl: Removed.
webaudio/AudioParam.cpp: Removed.
webaudio/AudioParam.h: Removed.
webaudio/AudioParam.idl: Removed.
webaudio/AudioParamTimeline.cpp: Removed.
webaudio/AudioParamTimeline.h: Removed.
webaudio/AudioProcessingEvent.cpp: Removed.
webaudio/AudioProcessingEvent.h: Removed.
webaudio/AudioProcessingEvent.idl: Removed.
webaudio/AudioSourceNode.h: Removed.
webaudio/AudioSourceNode.idl: Removed.
webaudio/BiquadDSPKernel.cpp: Removed.
webaudio/BiquadDSPKernel.h: Removed.
webaudio/BiquadFilterNode.cpp: Removed.
webaudio/BiquadFilterNode.h: Removed.
webaudio/BiquadFilterNode.idl: Removed.
webaudio/BiquadProcessor.cpp: Removed.
webaudio/BiquadProcessor.h: Removed.
webaudio/ConvolverNode.cpp: Removed.
webaudio/ConvolverNode.h: Removed.
webaudio/ConvolverNode.idl: Removed.
webaudio/DOMWindowWebAudio.idl: Removed.
webaudio/DefaultAudioDestinationNode.cpp: Removed.
webaudio/DefaultAudioDestinationNode.h: Removed.
webaudio/DelayDSPKernel.cpp: Removed.
webaudio/DelayDSPKernel.h: Removed.
webaudio/DelayNode.cpp: Removed.
webaudio/DelayNode.h: Removed.
webaudio/DelayNode.idl: Removed.
webaudio/DelayProcessor.cpp: Removed.
webaudio/DelayProcessor.h: Removed.
webaudio/DynamicsCompressorNode.cpp: Removed.
webaudio/DynamicsCompressorNode.h: Removed.
webaudio/DynamicsCompressorNode.idl: Removed.
webaudio/HighPass2FilterNode.cpp: Removed.
webaudio/HighPass2FilterNode.h: Removed.
webaudio/HighPass2FilterNode.idl: Removed.
webaudio/JavaScriptAudioNode.cpp: Removed.
webaudio/JavaScriptAudioNode.h: Removed.
webaudio/JavaScriptAudioNode.idl: Removed.
webaudio/LowPass2FilterNode.cpp: Removed.
webaudio/LowPass2FilterNode.h: Removed.
webaudio/LowPass2FilterNode.idl: Removed.
webaudio/MediaElementAudioSourceNode.cpp: Removed.
webaudio/MediaElementAudioSourceNode.h: Removed.
webaudio/MediaElementAudioSourceNode.idl: Removed.
webaudio/OfflineAudioCompletionEvent.cpp: Removed.
webaudio/OfflineAudioCompletionEvent.h: Removed.
webaudio/OfflineAudioCompletionEvent.idl: Removed.
webaudio/OfflineAudioDestinationNode.cpp: Removed.
webaudio/OfflineAudioDestinationNode.h: Removed.
webaudio/RealtimeAnalyser.cpp: Removed.
webaudio/RealtimeAnalyser.h: Removed.
webaudio/RealtimeAnalyserNode.cpp: Removed.
webaudio/RealtimeAnalyserNode.h: Removed.
webaudio/RealtimeAnalyserNode.idl: Removed.
webaudio/WaveShaperDSPKernel.cpp: Removed.
webaudio/WaveShaperDSPKernel.h: Removed.
webaudio/WaveShaperNode.cpp: Removed.
webaudio/WaveShaperNode.h: Removed.
webaudio/WaveShaperNode.idl: Removed.
webaudio/WaveShaperProcessor.cpp: Removed.
webaudio/WaveShaperProcessor.h: Removed.

5:30 PM Changeset in webkit [111473] by rniwa@webkit.org

3 edits in trunk

Perf-o-matic: don't query datastore to generate chart API urls
https://bugs.webkit.org/show_bug.cgi?id=81499

Reviewed by Hajime Morita.

Parse json text to extract timestamps and test values instead of iterating
through the data store.

Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler.post):

Websites/webkit-perf.appspot.com/models.py:

(Runs._timestamp_and_value_from_json_entry):
(Runs):
(Runs.to_json):
(Runs.chart_params):

5:24 PM Changeset in webkit [111472] by xji@chromium.org

4 edits in trunk/LayoutTests

Skip move-by-word-visually-crash-test-css-generated-content.html introduced in r111469
because isWordTextBreak or setEditingBehavior is not implemented.

platform/gtk/Skipped:
platform/qt/Skipped:
platform/wk2/Skipped:

5:04 PM Changeset in webkit [111471] by andersca@apple.com

15 edits
1 add in trunk/Source/WebCore

Add a per-ScrollableArea tile cache base class
https://bugs.webkit.org/show_bug.cgi?id=81694

Reviewed by Sam Weinig.

Add an abstract base class, TiledBacking, that can be used to inform tile caches about changed
state in scrollable areas (such as the currently visible rect, whether the page is active or not, etc).

Make TileCache inherit from TiledBacking and port updating the visible rect over to this new mechanism.

WebCore.xcodeproj/project.pbxproj:
page/FrameView.cpp:

(WebCore::FrameView::tiledBacking):
(WebCore):

page/FrameView.h:

(FrameView):

platform/ScrollableArea.h:

(WebCore):
(ScrollableArea):
(WebCore::ScrollableArea::tiledBacking):

platform/graphics/GraphicsLayer.h:

(WebCore):
(WebCore::GraphicsLayer::tiledBacking):

platform/graphics/TiledBacking.h: Added.

(WebCore):
(TiledBacking):
(WebCore::TiledBacking::~TiledBacking):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::tiledBacking):

platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

platform/graphics/ca/PlatformCALayer.h:

(PlatformCALayer):

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::tiledBacking):

platform/graphics/ca/mac/TileCache.h:

(TileCache):

platform/graphics/ca/mac/WebTileCacheLayer.h:

(WebCore):

platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer WebCore::]):

platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::tiledBacking):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):

5:00 PM Changeset in webkit [111470] by dpranke@chromium.org

5 edits in trunk/Tools

Unreviewed, rolling out r111453.
http://trac.webkit.org/changeset/111453
https://bugs.webkit.org/show_bug.cgi?id=81600

still broken

Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._reset):
(ServerProcess.handle_interrupt):
(ServerProcess.write):
(ServerProcess._check_for_crash):
(ServerProcess._handle_timeout):
(ServerProcess._check_for_abort):
(ServerProcess._read):
(ServerProcess.stop):
(ServerProcess):
(ServerProcess.set_crashed):

Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.is_crash_reporter):
(TestServerProcess.test_broken_pipe):

Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._read_image_diff):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver):
(WebKitDriver._detected_crash):
(WebKitDriver._subprocess_crashed):
(WebKitDriver._crashed_process_name):
(WebKitDriver.run_test):
(WebKitDriver._read_block):

Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(MockServerProcess.init):

4:49 PM Changeset in webkit [111469] by xji@chromium.org

3 edits
2 adds in trunk

visual word movement: crashes on CSS generated content.
https://bugs.webkit.org/show_bug.cgi?id=81581

Reviewed by Ryosuke Niwa.

Source/WebCore:

Check for null pointer when referencing box->renderer()->node() in previousRootInlineBox and nextRootInlineBox.

Test: editing/selection/move-by-word-visually-crash-test-css-generated-content.html

editing/visible_units.cpp:

(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):

LayoutTests:

editing/selection/move-by-word-visually-crash-test-css-generated-content-expected.txt: Added.
editing/selection/move-by-word-visually-crash-test-css-generated-content.html: Added.

4:47 PM Changeset in webkit [111468] by mitz@apple.com

2 edits in trunk/LayoutTests

Updated expected results for this test after r110409.

platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:

4:44 PM Changeset in webkit [111467] by leviw@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Marking full-screen-restrictions as timing out on Windows. It was previously marked as slow,
but all recent tests either passed or timed out.

platform/chromium/test_expectations.txt:

4:37 PM Changeset in webkit [111466] by mitz@apple.com

2 edits in trunk/LayoutTests

Updated Mac expected results for this test. <http://webkit.org/b/81705> tracks the fact that
r111416 broke it.

platform/mac/fast/dom/prototype-inheritance-2-expected.txt:

4:33 PM Changeset in webkit [111465] by sfalken@apple.com

2 edits in trunk/Source/JavaScriptCore

Windows (make based) build fix.
<rdar://problem/11069015>

JavaScriptCore.vcproj/JavaScriptCore.make: devenv /rebuild doesn't work with JavaScriptCore.vcproj. Use /clean and /build instead.

4:33 PM Changeset in webkit [111464] by ap@apple.com

2 edits in trunk/Source/WebKit2

Address review comment for WebProcess side, too.

WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): There is no need for path to be in static storage, setenv will copy the value.

4:30 PM Changeset in webkit [111463] by ap@apple.com

5 edits in trunk/Source/WebKit2

Sandboxed PluginProcess should use private temporary and cache directories
https://bugs.webkit.org/show_bug.cgi?id=81702
<rdar://problem/10792047>

Reviewed by Anders Carlsson.

Platform/Module.h:
Platform/mac/ModuleMac.mm: (WebKit::Module::bundleIdentifier): Expose plug-in's bundle identifier.

PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.in: Some unerlated fixes to make networking functional on my testing platforms. These serveices are already allowed for WebProcess.

WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm: (readSandboxProfile): Unrelated fix - I've been made to rename the profile file, but didn't update where it's read from! (WKN_EnterSandbox): Add a suffix to user directories.

4:27 PM Changeset in webkit [111462] by sfalken@apple.com

2 edits in trunk/WebKitLibraries

Disable LTCG on Windows to avoid out of process space errors while linking
https://bugs.webkit.org/show_bug.cgi?id=81714

Reviewed by Jessie Berlin.

win/tools/vsprops/production.vsprops:

4:20 PM Changeset in webkit [111461] by leviw@chromium.org

1 edit
1 add
7 deletes in trunk/LayoutTests

[Chromium] Updating and coalescing test expectations for nested-fragment-parser-crash.

platform/chromium-linux-x86/fast/parser: Removed.
platform/chromium-linux-x86/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
platform/chromium-linux/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
platform/chromium-mac-leopard/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
platform/chromium-win-vista/fast/parser: Removed.
platform/chromium-win-vista/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
platform/chromium-win-xp/fast/parser: Removed.
platform/chromium-win-xp/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
platform/chromium-win/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
platform/chromium/fast/parser/nested-fragment-parser-crash-expected.txt: Added.

4:18 PM Changeset in webkit [111460] by macpherson@chromium.org

2 edits in trunk/Source/WebCore

Use CSSPrimitiveValue::convertToLength() to handle CSSPropertyWebkitBoxReflect and in createGridTrackBreadth.
https://bugs.webkit.org/show_bug.cgi?id=81633

Reviewed by Andreas Kling.

No new tests / refactoring only.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

4:15 PM Changeset in webkit [111459] by leviw@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Adding additional possible test expectations for span-as-immediate-child-property-removal and
span-as-immediate-columns-child-removal, since the test expectations are now all over the board.

platform/chromium/test_expectations.txt:

4:03 PM Changeset in webkit [111458] by leviw@chromium.org

6 edits
4 deletes in trunk

Unreviewed, rolling out r111442.
http://trac.webkit.org/changeset/111442
https://bugs.webkit.org/show_bug.cgi?id=81711

Causes crashes and image mismatches in canvas tests (Requested
by leviw on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-20

Source/WebCore:

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::createImageBuffer):
(WebCore::HTMLCanvasElement::clearCopiedImage):

html/HTMLCanvasElement.h:

(HTMLCanvasElement):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::unwindStateStack):
(WebCore::CanvasRenderingContext2D::reset):

LayoutTests:

fast/canvas/canvas-resize-after-paint-without-layout-expected.txt: Removed.
fast/canvas/canvas-resize-after-paint-without-layout.html: Removed.
platform/chromium-linux/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.

4:01 PM Changeset in webkit [111457] by Lucas Forschler

1 copy in tags/Safari-534.55.2

New tag.

4:00 PM Changeset in webkit [111456] by enne@google.com

9 edits
1 move
1 add in trunk

RenderLayerCompositor doesn't properly clip graphics layer sizes
https://bugs.webkit.org/show_bug.cgi?id=80372

Reviewed by Simon Fraser.

Source/WebCore:

To find the bounds for a composited layer, calculateCompositedBounds
iterates through all non-composited child layers using z-order and
normal flow lists. This does not preserve clipping from ancestor
layers, because a clipping ancestor layer can end up as a sibling to
its clipped descendent because it is not a stacking context.

Fix by explicitly checking cached clip roots.

Test: compositing/clip-child-by-non-stacking-ancestor.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::localClipRect):
(WebCore):

rendering/RenderLayer.h:

(RenderLayer):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::repaintOnCompositingChange):
(WebCore::RenderLayerCompositor::calculateCompositedBounds):

LayoutTests:

Update several baselines due to smaller backing sizes.

compositing/clip-child-by-non-stacking-ancestor-expected.txt: Added.
compositing/clip-child-by-non-stacking-ancestor.html: Added.
compositing/geometry/clip-expected.txt:
compositing/images/clip-on-directly-composited-image-expected.txt:
compositing/overflow/clip-descendents-expected.txt:
platform/chromium-win/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
platform/chromium-win/compositing/overflow/clip-descendents-expected.txt:

3:51 PM Changeset in webkit [111455] by Csaba Osztrogonác

12 edits in trunk

Unreviewed, rolling out r111445 and r111446.
http://trac.webkit.org/changeset/111445
http://trac.webkit.org/changeset/111446
https://bugs.webkit.org/show_bug.cgi?id=81708

It broke Qt and GTK build intentionally (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-20

Source/WebCore:

WebCore.exp.in:
dom/Document.cpp:

(WebCore::Document::initSecurityContext):

notifications/Notification.cpp:

(WebCore::Notification::Notification):

notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::checkPermission):
(WebCore::NotificationCenter::requestPermission):

notifications/NotificationCenter.h:

(NotificationCenter):

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::toString):

page/SecurityOrigin.h:

(SecurityOrigin):

Source/WebKit2:

WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):

LayoutTests:

platform/chromium/test_expectations.txt:

3:45 PM Changeset in webkit [111454] by eae@chromium.org

1670 edits
367 copies
130 deletes in branches/subpixellayout

Merge trunk changes up until r111406 into subpixel branch.

3:42 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

3:40 PM Changeset in webkit [111453] by dpranke@chromium.org

5 edits in trunk/Tools

webkitpy: get ServerProcess out of the reportcrash business
https://bugs.webkit.org/show_bug.cgi?id=81600

Unreviewed, build fix.

Re-land r111307 and r111293 with fix for crash in NRWT; I
was failing to set the crashing process name.

Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._reset):
(ServerProcess._handle_possible_interrupt):
(ServerProcess.write):
(ServerProcess.read_stdout):
(ServerProcess.has_crashed):
(ServerProcess._read):
(ServerProcess.stop):

Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.check_for_leaks):
(TestServerProcess.test_broken_pipe):

Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._read_image_diff):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
(WebKitDriver._read_block):

Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(MockServerProcess.init):
(MockServerProcess):
(MockServerProcess.has_crashed):

3:32 PM Changeset in webkit [111452] by timothy_horton@apple.com

2 edits in trunk/Tools

[mac] Restore color space switching code to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=80571
<rdar://problem/11008529>

Reviewed by Simon Fraser.

http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.

Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
didn't exist until Lion.

DumpRenderTree/mac/LayoutTestHelper.m:

(installLayoutTestColorProfile):
(restoreUserColorProfile):

3:24 PM Changeset in webkit [111451] by adamk@chromium.org

2 edits in trunk/LayoutTests

Unskip dom/xhtml test fixed in r111449.

platform/qt/Skipped:

3:19 PM Changeset in webkit [111450] by rafaelw@chromium.org

1 edit in branches/chromium/1025/Source/WebKit/chromium/features.gypi

disabling Mutation Observers on Chromium branch 1025

3:10 PM Changeset in webkit [111449] by adamk@chromium.org

2 edits in trunk/Source/WebCore

Refactor ContainerNode::replaceChild to match other mutation methods and share code
https://bugs.webkit.org/show_bug.cgi?id=81579

Reviewed by Ojan Vafai.

Originally landed as r111310, this fixes a bug in replaceChild
introduced when switching to the insert-before logic.

A future change will make use of the consistency among insertBefore/appendChild/replaceChild
to handle insertion of DocumentFragments more cleanly.

No new tests, no change in behavior.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceChild): Use collectTargetNodes rather than walking through DocumentFragment children.
Insert before rather than inserting after. Dispatch to other methods to update parent/sibling pointers.
(WebCore::ContainerNode::appendChild): Call appendChildToContainer to update parent/sibling pointers.
(WebCore::ContainerNode::parserAddChild): Use type inference in call to appendChildToContainer.

3:07 PM Changeset in webkit [111448] by Lucas Forschler

2 edits in branches/safari-534.55-branch/Source/JavaScriptCore

Merged r107647.

3:05 PM Changeset in webkit [111447] by Lucas Forschler

5 edits in branches/safari-534.55-branch/Source

Versioning.

3:04 PM Changeset in webkit [111446] by jonlee@apple.com

2 edits in trunk/LayoutTests

platform/chromium/test_expectations.txt:

3:02 PM Changeset in webkit [111445] by jonlee@apple.com

10 edits in trunk/Source

Restrict access to notifications for unique origins and file URLs with no local file access
https://bugs.webkit.org/show_bug.cgi?id=79704
<rdar://problem/10912430>

Reviewed by Adam Barth.

Source/WebCore:

Before checking or requesting permissions, we look at whether we can show notifications based on
the security context. If not, we short circuit and do not forward the request to the client.

notifications/Notification.cpp:

notifications/NotificationCenter.cpp:

Add new variable in the notification center to keep track of pending callbacks when we short-circuit
requestPermission().

notifications/NotificationCenter.h:

(NotificationRequestCallback): Add new private class encapsulating the callback.

notifications/NotificationCenter.cpp:

page/SecurityOrigin.h: Add new toRawString() method to return the string representation of the origin,

regardless of any restrictions that might otherwise cause toString() to return "null".

page/SecurityOrigin.cpp:

Added FIXME's regarding the naming of enforceFilePathSeparation().

dom/Document.cpp:

(WebCore::Document::initSecurityContext): Also, tab reformatting.

WebCore.exp.in: Export toRawString().

Source/WebKit2:

It is reasonable, however, for there to be an entry for "file://", so we use toRawString() to do the lookup.

WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):

2:54 PM Changeset in webkit [111444] by kling@webkit.org

3 edits in trunk/Source/WebCore

Remove unused CSSPrimitiveValue constructors.
<http://webkit.org/b/81695>

Reviewed by Antti Koivisto.

Kill off CSSPrimitiveValue constructors that aren't used anywhere.

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

css/CSSPrimitiveValue.h:

(CSSPrimitiveValueBase):
(WebCore::CSSPrimitiveValueBase::CSSPrimitiveValueBase):
(CSSPrimitiveValue):

css/CSSPrimitiveValueMappings.h:

2:42 PM Changeset in webkit [111443] by adele@apple.com

2 edits in trunk/Tools

Update the last test to use EXPECT_WK_STREQ.

Reviewed by Dan Bernstein.

TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):

2:39 PM Changeset in webkit [111442] by commit-queue@webkit.org

6 edits
4 adds in trunk

Reuse buffer allocation if canvas size does not change
https://bugs.webkit.org/show_bug.cgi?id=80871

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-20
Reviewed by Stephen White.

Source/WebCore:

If the user changes the width or height attributes of a canvas element,
the contents of the canvas should be cleared and the context state
should be reset. This has become a common idiom to clear the canvas
"efficiently" at the start of a frame.

Previously, this code path triggered a full reallocation of the image
buffer backing the canvas, leading to reduced performance. This patch
implements an optimization where we reuse the previous image buffer
allocation if the size of the canvas did not change. Also, instead of
clearing the canvas every time its dimensions are touched, we only clear
if anything has been drawn into the canvas since it was previously
cleared.

Note that for now this optimization only applies for 2D canvases,
since it is not entirely clear how touching the dimensions of a WebGL
canvas should work.

Test: fast/canvas/canvas-resize-after-paint-without-layout.html +

existing layout tests for canvas resetting.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::createImageBuffer):
(WebCore::HTMLCanvasElement::clearImageBuffer):
(WebCore):
(WebCore::HTMLCanvasElement::clearCopiedImage):

html/HTMLCanvasElement.h:

(HTMLCanvasElement):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Save the
initial graphics context state so we can restore it without creating a
new context.
(WebCore::CanvasRenderingContext2D::unwindStateStack):
(WebCore::CanvasRenderingContext2D::reset): No need to notify the
compositor when the context is reset, because clearing the image buffer
does the same thing. We can also skip the notification if we did not
have an image buffer at the time of the reset, because the reset will
not have any visual impact in this case. Finally, if the canvas size
did change, the notification is also unnecessary because of the call
to RenderObject::repaint() from HTMLCanvasElement::reset().

LayoutTests:

Add layout test to check canvas resizing without changing its layout size.

We also update the expected image one canvas clearing test. The test
is setting the size of a canvas and expecting it to be cleared in the process.
With the optimization to retain the underlying ImageBuffer, we no longer call
RenderReplaced::repaint() as a part of this process. This function used to
repaint both the canvas itself (100x50) as well as its local selection
rectangle (100x54).

In this case the local selection rectangle is larger than the canvas because
the canvas is contained within an anonymous RenderBlock that also has two empty
text nodes. The extra 4 pixels are needed for drawing the selection rectangle
around any descenders in the the text of those nodes.

Since clearing the canvas has no effect on the selection rectangle, we only
need to repaint the area of the canvas itself.

fast/canvas/canvas-resize-after-paint-without-layout.html: Added.
fast/canvas/canvas-resize-after-paint-without-layout-expected.txt: Added.
platform/chromium-linux/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Updated.

2:34 PM Changeset in webkit [111441] by commit-queue@webkit.org

11 edits in trunk/Source

[chromium] Allow us to disable overdraw metrics when tracing is off
https://bugs.webkit.org/show_bug.cgi?id=81431

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

This change allows us to disable overdraw metrics conditionally in the
future with a one-line change in each LayerTreeHost class.

Unit test: CCQuadCullerTest.verifyWithoutMetrics

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):
(WebCore):

platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):

platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::didCull):
(WebCore::CCOverdrawMetrics::didDraw):
(WebCore::CCOverdrawMetrics::recordMetrics):

platform/graphics/chromium/cc/CCOverdrawMetrics.h:

(WebCore::CCOverdrawMetrics::create):
(CCOverdrawMetrics):

Source/WebKit/chromium:

tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):

tests/CCQuadCullerTest.cpp:

(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
(WebCore::TEST):
(WebCore):

tests/TiledLayerChromiumTest.cpp:

(WTF::TestCCOcclusionTracker::TestCCOcclusionTracker):

2:33 PM Changeset in webkit [111440] by mitz@apple.com

1 edit
2 adds in trunk/LayoutTests

Added Mac WebKit2 expected results for this test. <http://webkit.org/b/81700> tracks the
difference in results between WebKit1 and WebKit2 in this test.

platform/mac-wk2/fast/dom: Added.
platform/mac-wk2/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.

2:31 PM Changeset in webkit [111439] by robert@webkit.org

8 edits
2 adds in trunk

Use-after-free of continuation in RenderBlock::paintContinuationOutlines()
https://bugs.webkit.org/show_bug.cgi?id=81276

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/css/relative-positioned-block-crash.html

https://trac.webkit.org/changeset/108185/ allowed anonymous blocks to get their own layer (when they're
relatively positioned). This broke the dependency in addContinuationWithOutline() on the owner of the continuation
table and the renderer getting added to it always being in the same layer. When they're not in the same layer
there's no guarantee that the owner of the continuation table will get painted again and so avoid any stale pointers
in its continuation table should any of the renderers in there get destroyed.

Fix this for now by only adding renderers to the containing block's continuation table if we don't have our own layer.
This fix causes fast/inline/continuation-outlines-with-layers.html to regress as it uses blocks inside relatively positioned
inlines, so skip it on all platforms pending a medium-term fix.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):

LayoutTests:

fast/css/relative-positioned-block-crash-expected.txt: Added.
fast/css/relative-positioned-block-crash.html: Added.
platform/chromium/test_expectations.txt: Skip fast/inline/continuation-outlines-with-layers.html for now.
platform/gtk/Skipped: ditto
platform/mac/Skipped: ditto
platform/qt/Skipped: ditto
platform/win/Skipped: ditto

2:25 PM Changeset in webkit [111438] by sfalken@apple.com

6 edits
22 copies
1 add
1 delete in trunk/Source

Source/JavaScriptCore: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

This change only moves the vcproj and related files from JavaScriptCore/JavaScriptCore.vcproj/WTF.
It does not move any source code. This is in preparation for the WTF source move out of
JavaScriptCore.

Reviewed by Jessie Berlin.

JavaScriptCore.vcproj/JavaScriptCore.sln:
JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
JavaScriptCore.vcproj/WTF: Removed.
JavaScriptCore.vcproj/WTF/WTF.vcproj: Removed.
JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFDebug.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFDebugAll.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFDebugCairoCFLite.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFGenerated.make: Removed.
JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj: Removed.
JavaScriptCore.vcproj/WTF/WTFGeneratedCommon.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFGeneratedDebug.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFGeneratedDebugAll.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFGeneratedDebugCairoCFLite.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFGeneratedProduction.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFGeneratedRelease.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFGeneratedReleaseCairoCFLite.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd: Removed.
JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd: Removed.
JavaScriptCore.vcproj/WTF/WTFProduction.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFRelease.vsprops: Removed.
JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops: Removed.
JavaScriptCore.vcproj/WTF/build-generated-files.sh: Removed.
JavaScriptCore.vcproj/WTF/copy-files.cmd: Removed.
JavaScriptCore.vcproj/WTF/work-around-vs-dependency-tracking-bugs.py: Removed.

Source/WebKit/win: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

Reviewed by Jessie Berlin.

WebKit.vcproj/WebKit.sln:

Source/WTF: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

This change only moves the vcproj and related files from JavaScriptCore/JavaScriptCore.vcproj/WTF.
It does not move any source code. This is in preparation for the WTF source move out of
JavaScriptCore.

Reviewed by Jessie Berlin.

WTF.vcproj: Added.
WTF.vcproj/WTF.vcproj: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj.
WTF.vcproj/WTFCommon.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFCommon.vsprops.
WTF.vcproj/WTFDebug.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFDebug.vsprops.
WTF.vcproj/WTFDebugAll.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFDebugAll.vsprops.
WTF.vcproj/WTFDebugCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFDebugCairoCFLite.vsprops.
WTF.vcproj/WTFGenerated.make: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.make.
WTF.vcproj/WTFGenerated.vcproj: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj.
WTF.vcproj/WTFGeneratedCommon.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedCommon.vsprops.
WTF.vcproj/WTFGeneratedDebug.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedDebug.vsprops.
WTF.vcproj/WTFGeneratedDebugAll.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedDebugAll.vsprops.
WTF.vcproj/WTFGeneratedDebugCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedDebugCairoCFLite.vsprops.
WTF.vcproj/WTFGeneratedProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedProduction.vsprops.
WTF.vcproj/WTFGeneratedRelease.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedRelease.vsprops.
WTF.vcproj/WTFGeneratedReleaseCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedReleaseCairoCFLite.vsprops.
WTF.vcproj/WTFPostBuild.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd.
WTF.vcproj/WTFPreBuild.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd.
WTF.vcproj/WTFProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFProduction.vsprops.
WTF.vcproj/WTFRelease.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFRelease.vsprops.
WTF.vcproj/WTFReleaseCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops.
WTF.vcproj/build-generated-files.sh: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/build-generated-files.sh.
WTF.vcproj/copy-files.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/copy-files.cmd.
WTF.vcproj/work-around-vs-dependency-tracking-bugs.py: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/work-around-vs-dependency-tracking-bugs.py.

2:19 PM Changeset in webkit [111437] by mitz@apple.com

22 edits in trunk/LayoutTests

Work around the inconsistency in test results caused by <http://webkit.org/b/81696> in a few
tests, by appending a # character to the href attributes of links to other tests. This
ensures that they are never visited.

fast/block/margin-collapse/001.html:
fast/block/margin-collapse/005.html:
fast/block/margin-collapse/010.html:
fast/block/margin-collapse/011.html:
fast/block/margin-collapse/012.html:
fast/block/margin-collapse/015.html:
fast/block/margin-collapse/016.html:
fast/block/margin-collapse/017.html:
fast/block/margin-collapse/020.html:
fast/block/margin-collapse/056.html:
fast/block/margin-collapse/059.html:
fast/block/margin-collapse/block-inside-inline/001.html:
fast/block/margin-collapse/block-inside-inline/005.html:
fast/block/margin-collapse/block-inside-inline/010.html:
fast/block/margin-collapse/block-inside-inline/011.html:
fast/block/margin-collapse/block-inside-inline/012.html:
fast/block/margin-collapse/block-inside-inline/015.html:
fast/block/margin-collapse/block-inside-inline/016.html:
fast/block/margin-collapse/block-inside-inline/017.html:
fast/block/margin-collapse/block-inside-inline/020.html:
platform/mac/fast/block/margin-collapse/056-expected.txt:

2:05 PM Changeset in webkit [111436] by adele@apple.com

4 edits
1 copy
2 adds in trunk

Source/WebCore: "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
https://bugs.webkit.org/show_bug.cgi?id=81630
<rdar://problem/10650660>

Reviewed by Alexey Proskuryakov.

Test: TestWebKitAPI/Tests/mac/AttributedString.mm

If content is using a custom font, then the platform font will be nil and needs to be nil checked.

platform/mac/HTMLConverter.mm: (+[WebHTMLConverter editingAttributedStringFromRange:]):

Tools: "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
https://bugs.webkit.org/show_bug.cgi?id=81630
<rdar://problem/10650660>

Reviewed by Alexey Proskuryakov.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
TestWebKitAPI/Tests/mac/AttributedString.mm: Added.

(-[AttributedStringTest webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.

2:02 PM Changeset in webkit [111435] by jchaffraix@webkit.org

4 edits in trunk/Source/WebCore

Make distributeExtraLogicalHeightToRows return the consumed logical height
https://bugs.webkit.org/show_bug.cgi?id=81678

Reviewed by Tony Chang.

Small refactoring, no change in behavior.

rendering/RenderTable.cpp:

(WebCore::RenderTable::distributeExtraLogicalHeight):
Remove the consumed logical height from the available height.

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToAutoRows):
(WebCore::RenderTableSection::distributeRemainingExtraLogicalHeight):
Changed those method to not return anything but remove from the available width.

(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows):
Return the consumed logical height.

rendering/RenderTableSection.h:

Updated the previous distribute functions signature and the comment about
the returned value from distributeExtraLogicalHeightToRows.

1:59 PM April 2012 Meeting edited by eric@webkit.org

(diff)

1:56 PM Changeset in webkit [111434] by commit-queue@webkit.org

4 edits in trunk/Source

[BlackBerry] Dijit crash WebCore::CookieManager::getRawCookies
https://bugs.webkit.org/show_bug.cgi?id=81686

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-20
Reviewed by Rob Buis.

Source/WebCore:

HTML plugin element with an empty src caused an ASSERT failure on debug
build and a crash on release build.
When getting cookie, url can be null, so we need to check for it to
avoid the crash.

No new tests as this is covered by
LayoutTests/fast/loader/empty-embed-src-attribute.html.

platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

Source/WebKit/blackberry:

When deciding the policy for navigation action, if the url of the
request is null, ignore it to avoid the ASSERT failure in
MainResourceLoader::willSendRequest.

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):

1:51 PM WikiStart edited by rniwa@webkit.org

Add a link to the 2012 meeting page (diff)

1:47 PM April 2012 Meeting edited by rniwa@webkit.org

Add some topics and hackathon ideas (diff)

1:26 PM April 2012 Meeting created by rniwa@webkit.org

Add 2012 contributor's meeting page

1:22 PM Changeset in webkit [111433] by benjamin@webkit.org

6 edits in trunk/Source/JavaScriptCore

Cache the type string of JavaScript object
https://bugs.webkit.org/show_bug.cgi?id=81446

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-20
Reviewed by Geoffrey Garen.

Instead of creating the JSString every time, we create
lazily the strings in JSGlobalData.

This avoid the construction of the StringImpl and of the JSString,
which gives some performance improvements.

runtime/CommonIdentifiers.h:
runtime/JSValue.cpp:

(JSC::JSValue::toStringSlowCase):

runtime/Operations.cpp:

(JSC::jsTypeStringForValue):

runtime/SmallStrings.cpp:

(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::finalizeSmallStrings):
(JSC::SmallStrings::initialize):
(JSC):

runtime/SmallStrings.h:

(SmallStrings):

1:07 PM Changeset in webkit [111432] by eric@webkit.org

2 edits in trunk/Tools

Add link on queues.webkit.org to kov's fancy queue-depth graph
https://bugs.webkit.org/show_bug.cgi?id=81690

Reviewed by Adam Barth.

QueueStatusServer/templates/recentstatus.html:

1:02 PM Changeset in webkit [111431] by oliver@apple.com

3 edits in trunk/Source/JavaScriptCore

Allow LLINT to work even when executable allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=81693

Reviewed by Gavin Barraclough.

Don't crash if executable allocation fails if we can fall back on LLINT

jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

12:58 PM Changeset in webkit [111430] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Tabbed pane drop down should be sorted.
https://bugs.webkit.org/show_bug.cgi?id=81680

Reviewed by Pavel Feldman.

inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype._populateDropDownFromIndex.compareFunction):
(WebInspector.TabbedPane.prototype._populateDropDownFromIndex):

12:58 PM Changeset in webkit [111429] by timothy_horton@apple.com

4 edits
1 add in trunk/Tools

[mac] Restore color space switching code to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=80571
<rdar://problem/11008529>

Reviewed by Simon Fraser.

Make use of the layout test helper hooks to restore the Mac system-wide
color profile switching code. This makes WkTR and DRT results match, and
causes the main display's color profile to not affect results on Lion.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/mac/LayoutTestHelper.m: Added.

(installLayoutTestColorProfile):
(restoreUserColorProfile):
(simpleSignalHandler):
(main):

Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.release_http_lock):
(MacPort):
(MacPort._path_to_helper):
(MacPort.start_helper):
(MacPort.stop_helper):

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::windowSnapshotImage):

12:53 PM Changeset in webkit [111428] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Open resource dialog scripts list should be sorted.
https://bugs.webkit.org/show_bug.cgi?id=81682

Reviewed by Pavel Feldman.

inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):

12:52 PM Changeset in webkit [111427] by mitz@apple.com

1 edit
1 copy
1 add in trunk/LayoutTests

Added Mac WebKit2 expected results for this test. <http://webkit.org/b/81679> tracks the
difference in results between WebKit1 and WebKit2 in this test.

platform/mac-wk2/compositing/geometry: Added.
platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt.

12:51 PM Changeset in webkit [111426] by commit-queue@webkit.org

4 edits in trunk/Source

[chromium] Use opaque contents for paint culling
https://bugs.webkit.org/show_bug.cgi?id=81676

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

UnitTest: CCLayerTreeHostTestContentLayerOcclusion

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(WTF::TestLayerChromium::opaqueContentsRegion):
(WTF::TestLayerChromium::setOpaqueContentsRect):
(TestLayerChromium):
(CCLayerTreeHostTestContentLayerOcclusion):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::CCLayerTreeHostTestContentLayerOcclusion):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::afterTest):
(WTF):

12:49 PM Changeset in webkit [111425] by cevans@google.com

1 edit
2 copies in branches/chromium/963

Merge 110324
BUG=116746
Review URL: https://chromiumcodereview.appspot.com/9771001

12:47 PM Changeset in webkit [111424] by leviw@chromium.org

1 edit
1 add in trunk/LayoutTests

[Chromium] Updating Chromium expectations following r111412.

platform/chromium-win/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Added.

12:08 PM Changeset in webkit [111423] by cevans@google.com

8 edits
2 copies in branches/chromium/963

Merge 110323
BUG=113902
Review URL: https://chromiumcodereview.appspot.com/9762003

12:04 PM Changeset in webkit [111422] by mitz@apple.com

3 edits in trunk/Source/WebCore

Build fix after r111419.

dom/WebKitNamedFlow.cpp:
dom/WebKitNamedFlow.h:

11:54 AM Changeset in webkit [111421] by cevans@google.com

1 edit
3 copies in branches/chromium/963

Merge 110326
BUG=116461
Review URL: https://chromiumcodereview.appspot.com/9761002

11:47 AM Changeset in webkit [111420] by Lucas Forschler

1 delete in tags/Safari-534.56.1/safari-534.56-branch

Remove incorrect tag.

11:37 AM Changeset in webkit [111419] by mitz@apple.com

9 edits
2 deletes in trunk

REGRESSION (r111229): css1/basic/inheritance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=81684

Reverted r111229.

Rubber-stamped by Dave Hyatt.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):

dom/Document.h:

(Document):

dom/Element.cpp:

(WebCore::Element::detach):

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

dom/WebKitNamedFlow.cpp:

(WebCore):

dom/WebKitNamedFlow.h:

(WebCore):
(WebKitNamedFlow):

dom/WebKitNamedFlow.idl:

LayoutTests:

fast/regions/webkit-named-flow-content-nodes-expected.txt: Removed.
fast/regions/webkit-named-flow-content-nodes.html: Removed.

11:33 AM Changeset in webkit [111418] by Lucas Forschler

1 copy in tags/Safari-534.55.1

New tag.

11:32 AM Changeset in webkit [111417] by Lucas Forschler

1 copy in tags/Safari-534.56.1/safari-534.56-branch

New tag.

11:26 AM Changeset in webkit [111416] by commit-queue@webkit.org

14 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=80696
Remove custom bindings for attribute type Array.

Patch by Vineet Chaudhary <Vineet> on 2012-03-20
Reviewed by Kentaro Hara.

No new tests.

bindings/js/JSConsoleCustom.cpp: Removed custom function.

(WebCore):

bindings/js/JSDOMBinding.h: Added template jsArray and toNativeArray.

(WebCore):
(WebCore::jsArray):
(WebCore::toNativeArray):

bindings/scripts/CodeGenerator.pm: Modified codegenerators to generate appropriate code.

(GetArrayType): Added GetArrayType to get return type of attribute interface.

bindings/scripts/CodeGeneratorGObject.pm: Modified codegenerators to generate appropriate code.

(SkipAttribute):

bindings/scripts/CodeGeneratorJS.pm: Modified codegenerators to generate appropriate code.

(AddIncludesForType):
(JSValueToNative):
(NativeToJSValue):

bindings/scripts/CodeGeneratorV8.pm: Modified codegenerators to generate appropriate code.

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(JSValueToNative):
(NativeToJSValue):

bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Updated results from running binding tests.

(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore::jsTestObjSequenceAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):

bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::TestObjInternal::sequenceAttrAttrGetter):
(WebCore::TestObjInternal::sequenceAttrAttrSetter):
(WebCore::TestObjInternal::methodReturningSequenceCallback):

bindings/v8/V8Binding.h: Added template v8Array and toNativeArray.

(WebCore):
(WebCore::v8Array):
(WebCore::toNativeArray):

bindings/v8/custom/V8ConsoleCustom.cpp: Removed custom function.

(WebCore):

page/Console.idl: Replaced attribute type Array to sequence<SriptProfile> to remove custom bindings.

11:18 AM Changeset in webkit [111415] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r111310.
http://trac.webkit.org/changeset/111310
https://bugs.webkit.org/show_bug.cgi?id=81683

Broke layout test
dom/xhtml/level3/core/nodereplacechild30.xhtml (Requested by
aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-20

dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

11:12 AM Changeset in webkit [111414] by darin@chromium.org

2 edits in trunk/Tools

2012-02-24 Darin Fisher <darin@chromium.org>

Add more Chromium WebKit API reviewers
https://bugs.webkit.org/show_bug.cgi?id=81576

Reviewed by Adam Barth and David Levin.

Simplify watchlist to lump all WebKit API into one.

Scripts/webkitpy/common/config/watchlist:

11:08 AM Changeset in webkit [111413] by ap@apple.com

6 edits in trunk/Source/WebKit2

WebProcess should use private temporary and cache directories
https://bugs.webkit.org/show_bug.cgi?id=80876

Reviewed by Sam Weinig.

Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
Shared/WebProcessCreationParameters.h: (WebProcessCreationParameters):
UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess): Always pass uiProcessBundleIdentifier to WebProcess on Mac, it's now used for more than CFURL sessions.

WebProcess/com.apple.WebProcess.sb.in: Limit old workaround to platforms that need it.

WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): Tell confstr to use a suffix on user directories.

11:02 AM Changeset in webkit [111412] by mitz@apple.com

2 edits in trunk/LayoutTests

Updated expected results for a test, while <http://webkit.org/b/81679> is tracking this
possible regression.

compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:

10:56 AM Changeset in webkit [111411] by commit-queue@webkit.org

4 edits
2 adds in trunk/LayoutTests

Convert regions parsing test to use testharness.js
https://bugs.webkit.org/show_bug.cgi?id=80709

Patch by Jacob Goldstein <jacobg@adobe.com> on 2012-03-20
Reviewed by Ryosuke Niwa.

fast/regions/script-tests/webkit-flow-parsing.js:

(testParse):
(testComputedStyle):
(testNotInherited):
(test):

fast/regions/webkit-flow-parsing-expected.txt:
fast/regions/webkit-flow-parsing.html:
resources/testharness.js: Added.

(.):

resources/testharnessreport.js: Added.

(convertResult):

10:54 AM Changeset in webkit [111410] by eae@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/platform/animation/AnimationUtilities.h

AnimationUtil::bend changes on branch

10:46 AM Changeset in webkit [111409] by vsevik@chromium.org

5 edits in trunk/LayoutTests

Unreviewed test fix and unskip.

inspector/debugger/snippets-model-expected.txt:
inspector/debugger/snippets-model.html:
platform/gtk/Skipped:
platform/qt/Skipped:

10:25 AM Changeset in webkit [111408] by leviw@chromium.org

1 edit
1 add in trunk/LayoutTests

[Chromium] Adding missing linux expectations for error-to-string-stack-overflow.

platform/chromium-linux/fast/dom/error-to-string-stack-overflow-expected.txt: Added.

10:21 AM Changeset in webkit [111407] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Graphic distortion effect when launching with empty page Safari after reset
https://bugs.webkit.org/show_bug.cgi?id=81677
<rdar://problem/11065904>

Reviewed by Sam Weinig.

Don't set the redraw policy to never, since that was causing the WKView layer to never be updated. Instead,
let AppKit decide which redraw policy to use.

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):

10:18 AM Changeset in webkit [111406] by leviw@chromium.org

1 edit
1 add in trunk/LayoutTests

[Chromium] Adding missing results for canvas-putImageData for Windows.

platform/chromium-win/fast/repaint/canvas-putImageData-expected.txt: Added.

9:59 AM Changeset in webkit [111405] by gyuyoung.kim@samsung.com

52 edits in trunk

Convert hasSpellingMarker to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=81300

Reviewed by Ryosuke Niwa.

Source/autotools/symbols.filter: Export a symbol for hasSpellingMarker.

Source/WebCore:

Remove hasSpellingMarker functions, because it is able to work in the
cross-port way through the Internals interface.

No new tests, since we are improving here the infra-structure
for testing a specific method.

testing/Internals.cpp:

(WebCore::Internals::hasSpellingMarker):
(WebCore):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit/gtk:

Remove DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker support,
since it can support in the cross-port way through the Internals interface.

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Remove hasSpellingMarker support, since it can support in the cross-port way
through the Internals interface.

WebKit.order:
WebView/WebFrame.mm:
WebView/WebFramePrivate.h:

Source/WebKit/win:

Remove hasSpellingMarker interface support, since it can support in the cross-port
way through the Internals interface.

Interfaces/IWebFramePrivate.idl:

Source/WebKit2:

win/WebKit2.def: Export a symbol for hasSpellingMarker.

Tools:

Remove hasSpellingMarker functions, because it is able to work in the
cross-port way through the Internals interface.

DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
DumpRenderTree/mac/LayoutTestControllerMac.mm:
DumpRenderTree/qt/LayoutTestControllerQt.cpp:
DumpRenderTree/qt/LayoutTestControllerQt.h:
DumpRenderTree/win/LayoutTestControllerWin.cpp:
DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Adjust hasSpellingMarker tests to use Internals instead of LayoutTestController
interface.

editing/spelling/design-mode-spellcheck-off.html:
editing/spelling/script-tests/spellcheck-paste.js:

(verifyMarker):

editing/spelling/script-tests/spelling-attribute-at-child.js:

(childHasSpellingMarker):

editing/spelling/script-tests/spelling-attribute-change.js:

(testSpellCheckingEnabled):

editing/spelling/script-tests/spelling-backspace-between-lines.js:

(testWithDelete):
(testWithForwardDelete):

editing/spelling/script-tests/spelling-hasspellingmarker.js:

(hasMarked):

editing/spelling/spellcheck-attribute.html:
editing/spelling/spelling-attribute-change-expected.txt:
editing/spelling/spelling-backspace-between-lines-expected.txt:
editing/spelling/spelling-hasspellingmarker-expected.txt:
editing/spelling/spelling-linebreak.html:
platform/chromium-mac-snowleopard/editing/spelling/spelling-backspace-between-lines-expected.txt:
platform/chromium-win/editing/spelling/spelling-backspace-between-lines-expected.txt:
platform/chromium/editing/spelling/spelling-backspace-between-lines-expected.txt:
platform/mac/editing/spelling/delete-into-misspelled-word.html:
platform/mac/editing/spelling/editing-multiple-words-with-markers.html:
platform/mac/editing/spelling/editing-word-with-marker-1.html:
platform/mac/editing/spelling/editing-word-with-marker-2.html:
platform/mac/editing/spelling/move-cursor-around-misspelled-word.html:
platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt:
platform/wk2/Skipped:

9:40 AM Changeset in webkit [111404] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] BlackBerry can clear cookies and cache from the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=81670

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-20
Reviewed by Rob Buis.

WebCoreSupport/InspectorClientBlackBerry.h:

(WebCore::InspectorClientBlackBerry::canClearBrowserCache):
(WebCore::InspectorClientBlackBerry::canClearBrowserCookies):

9:33 AM Changeset in webkit [111403] by Csaba Osztrogonác

3 edits in trunk/Tools

Add new Qt-WK2 performance tester bot to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=80842

Reviewed by Ryosuke Niwa.

BuildSlaveSupport/build.webkit.org-config/config.json:
BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunAndUploadPerfTestsWebKit2):
(RunAndUploadPerfTestsWebKit2.start):
(BuildAndPerfTestWebKit2Factory):
(BuildAndPerfTestWebKit2Factory.init):
(DownloadAndPerfTestWebKit2Factory):
(DownloadAndPerfTestWebKit2Factory.init):

9:28 AM Changeset in webkit [111402] by mitz@apple.com

2 edits in trunk/Source/WebCore

Build fix.

history/PageCache.cpp: Fixed an unused function warning introduced in r111391.

9:27 AM Changeset in webkit [111401] by kkristof@inf.u-szeged.hu

2 edits
6 adds in trunk/LayoutTests

[Qt] Unreviewed. Added new platform expectations.

Skipped. https://bugs.webkit.org/show_bug.cgi?id=81671

platform/qt-5.0-wk2/Skipped:
platform/qt-5.0-wk2/css1/basic/inheritance-expected.txt: Added after r111229.
platform/qt-5.0-wk2/platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added after r111351.

9:17 AM Changeset in webkit [111400] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

(r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro
https://bugs.webkit.org/show_bug.cgi?id=81666

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-20
Reviewed by Rob Buis.

Compiled with feature disabled and built.

page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):

8:38 AM Changeset in webkit [111399] by Martin Robinson

5 edits in trunk/Source/WebKit2

[GTK] [WK2] Add javascript clipboard functionality settings to WebKit2 GTK+ API.
https://bugs.webkit.org/show_bug.cgi?id=80981

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-03-20
Reviewed by Martin Robinson.

Add WebSettings to enable/disable javascript clipboard functionality.

UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_javascript_can_access_clipboard):
(webkit_settings_set_javascript_can_access_clipboard):

UIProcess/API/gtk/WebKitSettings.h:
UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

8:31 AM Changeset in webkit [111398] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Removing doubly defined methods in BackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=81664

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-20
Reviewed by Rob Buis.

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):

8:24 AM Changeset in webkit [111397] by leviw@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Marking compositing/iframes/scrolling-iframe.html as flaky on Linux
as well.

platform/chromium/test_expectations.txt:

8:03 AM Changeset in webkit [111396] by charles.wei@torchmobile.com.cn

2 edits in trunk/Source/WebKit

[BlackBerry] Remove OutOfMemoryHandler from the build system
https://bugs.webkit.org/show_bug.cgi?id=81649

Remove OutOfMemoryHandler, and change GLES2Context to WebKitSupport,
in the build system for BlackBerry porting.

Reviewed by Rob Buis.

PlatformBlackBerry.cmake:

7:51 AM Changeset in webkit [111395] by wjmaclean@chromium.org

4 edits in trunk/Source

[chromium] Tune fling physics curve. [Not for review yet]
https://bugs.webkit.org/show_bug.cgi?id=81398

Reviewed by James Robinson.

Source/WebCore:

Existing tests updated.

Tune physics of curve for better feel.

platform/TouchFlingPlatformGestureCurve.cpp:

(WebCore::TouchFlingPlatformGestureCurve::apply):

Source/WebKit/chromium:

tests/PlatformGestureCurveTest.cpp:

7:46 AM Changeset in webkit [111394] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebCore

Implement a fast path when setting CSS properties with keywords from JS.
https://bugs.webkit.org/show_bug.cgi?id=80874

Reviewed by Antti Koivisto.

The idea is to avoid the creation of the CSSParser instance and to run the parser on
a string we know it should be a keyword. When JS calls parseValue we try to check if we can
use the fast path and if the keyword is accepted then we just add it to the declaration directly.
For the sake of maintenance the parseValue function used by CSSGrammar.y is sharing some code with
the fast path (keyword matching mostly).

This patch improves this use case by 20%. Setting keyword properties from JS is used a lot in
Google Maps for example (when zooming or panning).

No new tests : it's a performance improvement, there shouldn't be any behavior change.

css/CSSParser.cpp:

(WebCore):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValue):

7:42 AM Changeset in webkit [111393] by commit-queue@webkit.org

27 edits
3 deletes in trunk/Source

[chromium] Infrastructure to allow animating layers to be only partially updated
https://bugs.webkit.org/show_bug.cgi?id=81106

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-20
Reviewed by James Robinson

Source/WebCore:

Merged the controller tests in CCLayerAnimationControllerTest

WebCore.gypi:
platform/graphics/chromium/GraphicsLayerChromium.cpp:
platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::setOpacityFromAnimation):
(WebCore):
(WebCore::LayerChromium::setTransformFromAnimation):
(WebCore::LayerChromium::addAnimation):
(WebCore::LayerChromium::pauseAnimation):
(WebCore::LayerChromium::removeAnimation):
(WebCore::LayerChromium::suspendAnimations):
(WebCore::LayerChromium::resumeAnimations):
(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::hasActiveAnimation):
(WebCore::LayerChromium::setAnimationEvent):

platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):
(WebCore::LayerChromium::id):
(WebCore::LayerChromium::opacity):
(WebCore::LayerChromium::transform):
(WebCore::LayerChromium::bounds):

platform/graphics/chromium/cc/CCActiveAnimation.h:

(CCActiveAnimation):

platform/graphics/chromium/cc/CCAnimationEvents.cpp:

(WebCore::CCAnimationEvent::CCAnimationEvent):
(WebCore::CCAnimationEvent::toFloatAnimationFinishedEvent):
(WebCore::CCAnimationEvent::toTransformAnimationFinishedEvent):
(WebCore::CCAnimationStartedEvent::create):
(WebCore):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
(WebCore::CCFloatAnimationFinishedEvent::create):
(WebCore::CCFloatAnimationFinishedEvent::CCFloatAnimationFinishedEvent):
(WebCore::CCFloatAnimationFinishedEvent::~CCFloatAnimationFinishedEvent):
(WebCore::CCFloatAnimationFinishedEvent::type):
(WebCore::CCTransformAnimationFinishedEvent::create):
(WebCore::CCTransformAnimationFinishedEvent::CCTransformAnimationFinishedEvent):
(WebCore::CCTransformAnimationFinishedEvent::~CCTransformAnimationFinishedEvent):
(WebCore::CCTransformAnimationFinishedEvent::type):

platform/graphics/chromium/cc/CCAnimationEvents.h:

(WebCore):
(WebCore::CCAnimationEvent::targetProperty):
(CCAnimationEvent):
(CCAnimationStartedEvent):
(CCFloatAnimationFinishedEvent):
(WebCore::CCFloatAnimationFinishedEvent::finalValue):
(CCTransformAnimationFinishedEvent):
(WebCore::CCTransformAnimationFinishedEvent::finalValue):

platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::create):
(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
(WebCore::CCLayerAnimationController::animate):
(WebCore):
(WebCore::CCLayerAnimationController::add):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::hasActiveAnimation):
(WebCore::CCLayerAnimationController::isAnimatingProperty):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::removeAnimationsCompletedOnMainThread):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationController::resolveConflicts):
(WebCore::CCLayerAnimationController::purgeFinishedAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):

platform/graphics/chromium/cc/CCLayerAnimationController.h:

(WebCore):
(CCLayerAnimationControllerClient):
(WebCore::CCLayerAnimationControllerClient::~CCLayerAnimationControllerClient):
(CCLayerAnimationController):

platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp: Removed.
platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h: Removed.
platform/graphics/chromium/cc/CCLayerAnimationDelegate.h:

(CCLayerAnimationDelegate):

platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::setOpacityFromAnimation):
(WebCore):
(WebCore::CCLayerImpl::setTransformFromAnimation):

platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::id):
(WebCore::CCLayerImpl::layerAnimationController):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::updateAnimations):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::animateLayers):
(WebCore):
(WebCore::CCLayerTreeHost::animateLayersRecursive):

platform/graphics/chromium/cc/CCLayerTreeHost.h:
platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animateLayersRecursive):
(WebCore::CCLayerTreeHostImpl::animateLayers):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

platform/graphics/chromium/cc/CCThreadProxy.h:

(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):

Source/WebKit/chromium:

WebKit.gypi:
tests/CCAnimationTestCommon.cpp:

(WebKitTests::FakeLayerAnimationControllerClient::FakeLayerAnimationControllerClient):
(WebKitTests::FakeLayerAnimationControllerClient::~FakeLayerAnimationControllerClient):

tests/CCAnimationTestCommon.h:

(FakeLayerAnimationControllerClient):
(WebKitTests::FakeLayerAnimationControllerClient::setOpacityFromAnimation):
(WebKitTests::FakeLayerAnimationControllerClient::setTransformFromAnimation):

tests/CCLayerAnimationControllerImplTest.cpp: Removed.
tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(CCLayerTreeHostTestAddAnimation):

tests/TreeSynchronizerTest.cpp:

(WebKitTests::FakeLayerAnimationController::create):
(WebKitTests::FakeLayerAnimationController::FakeLayerAnimationController):
(WebKitTests::FakeLayerAnimationController::pushAnimationUpdatesTo):
(WebKitTests::TEST):

7:37 AM Changeset in webkit [111392] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION Detached DOM Nodes are not highlighted
https://bugs.webkit.org/show_bug.cgi?id=81662

Reviewed by Yury Semikhatsky.

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTree):

7:31 AM Changeset in webkit [111391] by gavinp@chromium.org

2 edits in trunk/Source/WebCore

New PageCache histogram for tracking the highest leverage frame reject reasons.
https://bugs.webkit.org/show_bug.cgi?id=81358

Reviewed by Adam Barth.

The current chromium FrameClientImpl always denies page cache; but
that's easily fixable. This histogram tracks which rejection
causes occur alone with that cause. I'm particularly interested
in knowing how many more pages would work in the page cache if we
could get plugins in.

history/PageCache.cpp:

(WebCore::logCanCachePageDecision):

7:24 AM Changeset in webkit [111390] by mifenton@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash when dragging the FCC caret over an invalid node.
https://bugs.webkit.org/show_bug.cgi?id=81654

Reviewed by Rob Buis.

PR 144505.

The position did not have a valid container node and was causing
a crash. Validate the node pointer before using it.

WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::DOMContainerNodeForPosition):

7:01 AM Changeset in webkit [111389] by podivilov@chromium.org

5 edits in trunk

Web Inspector: support inline source maps.
https://bugs.webkit.org/show_bug.cgi?id=81248

Source/WebCore:

support optional map.sourcesContent array with sources content
support data: url as script sourceMapURL, e.g. "@ sourceMappingURL=data:application/json;base64,<base64-encoded map>"

Reviewed by Pavel Feldman.

inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.loadSourceCode):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._canonicalizeURL):

LayoutTests:

Reviewed by Pavel Feldman.

http/tests/inspector/compiler-source-mapping-expected.txt:
http/tests/inspector/compiler-source-mapping.html:

5:57 AM Changeset in webkit [111388] by pfeldman@chromium.org

6 edits in trunk

Web Inspector: treat Uint* external arrays as arrays in console.
https://bugs.webkit.org/show_bug.cgi?id=81653

Reviewed by Yury Semikhatsky.

Source/WebCore:

bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::type):

bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::typeCallback):

LayoutTests:

inspector/console/console-external-array-expected.txt:
inspector/console/console-external-array.html:

5:38 AM Changeset in webkit [111387] by kling@webkit.org

11 edits
2 adds in trunk

Let CSSImageValue inherit directly from CSSValue.
<http://webkit.org/b/81635>

Reviewed by Antti Koivisto.

Source/WebCore:

This removes the last of the CSSPrimitiveValue subclasses, which will
open up the class to heavier refactoring.

Those CSSImageValues that used to represent the 'none' value are now
simply created as CSSPrimitiveValue identifiers by the parser.

Test: fast/css/image-value-type.html

css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):

css/CSSImageValue.cpp:

(WebCore::CSSImageValue::CSSImageValue):
(WebCore::CSSImageValue::cachedOrPendingImage):
(WebCore::CSSImageValue::cachedImage):
(WebCore::CSSImageValue::customCssText):

css/CSSImageValue.h:

(WebCore::CSSImageValue::url):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseBorderImage):

css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyCursor::applyValue):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

css/CSSValue.h:

(WebCore::CSSValue::isPrimitiveValue):

LayoutTests:

Added a test to document the fact that image values are no longer CSSPrimitiveValues.
Updated setPrimitiveValue.html and expectation to reflect this as well.

fast/css/image-value-type-expected.txt: Added.
fast/css/image-value-type.html: Added.
fast/dom/setPrimitiveValue-expected.txt:
fast/dom/setPrimitiveValue.html:

5:27 AM Changeset in webkit [111386] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening, skip new failing tests to paint the bot green.

platform/qt-mac/Skipped:

5:22 AM Changeset in webkit [111385] by pfeldman@chromium.org

6 edits in trunk

Web Inspector: call .length as the last check when detecting arrays.
https://bugs.webkit.org/show_bug.cgi?id=81335

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/InjectedScriptSource.js:

LayoutTests:

inspector/console/console-format-collections-expected.txt:
inspector/console/console-format-collections.html:

5:17 AM Changeset in webkit [111384] by apavlov@chromium.org

4 edits in trunk

Web Inspector: newly added CSS rules shouldn't rewrite HTML content in the resources panel
https://bugs.webkit.org/show_bug.cgi?id=81414

Reviewed by Vsevolod Vlasov.

Source/WebCore:

inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged):

LayoutTests:

inspector/styles/styles-add-new-rule.html:

5:01 AM Changeset in webkit [111383] by yurys@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: provide class name filter for "comparison" view in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=81641

Class name filtering now works for both Summary and Comparison views.

Reviewed by Pavel Feldman.

inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._createToolbarWithClassNameFilter):
(WebInspector.DetailedHeapshotView.prototype._changeNameFilter):

inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .class-view-grid):
(.detailed-heapshot-view .class-view-toolbar):
(.detailed-heapshot-view .class-view-toolbar input.class-name-filter):

4:57 AM Changeset in webkit [111382] by peter@chromium.org

2 edits in trunk/Tools

[Chromium] Update to Android NDK r7b
https://bugs.webkit.org/show_bug.cgi?id=81005

Reviewed by Adam Barth.

Update to version r7b of the Android NDK, release notes of which are
available on the following page:
http://developer.android.com/sdk/ndk/index.html

Scripts/update-webkit-chromium:

4:52 AM Changeset in webkit [111381] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

Division optimizations fail to infer cases of truncated division and mishandle -2147483648/-1
https://bugs.webkit.org/show_bug.cgi?id=81428

32 bit buildfix after r111355.

2147483648 (2^{31) isn't valid int literal in ISO C90, because 2147483647 (2}31-1) is the biggest int.
The smallest int is -2147483648 (-2^{31) == -2147483647 - 1 == -INT32_MAX-1 == INT32_MIN (stdint.h).}

Reviewed by Zoltan Herczeg.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):

4:47 AM Changeset in webkit [111380] by Nikolas Zimmermann

25 edits
4 adds in trunk

Make animVal support type-safe
https://bugs.webkit.org/show_bug.cgi?id=81640

Reviewed by Antti Koivisto.

Source/WebCore:

Test: svg/animations/force-use-shadow-tree-recreation-while-animating.html

Redesign animVal support in a type-safe fashion, avoiding the SVGGenericAnimatedType
and associated reinterpret_casts, which require all call-sites to assure that the
types are safe to cast, before actually calling the method.

Remove pure virtual animationStarted/Ended/ValueWillChange/ValueDidChange & currentBaseValueVariant methods from SVGAnimatedProperty,
and de-virtualize them in classes that inherit from SVGAnimatedProperty, like SVGAnimatedPropertyTearOff, etc.

Add startAnimValAnimation/stopAnimValAnimation/resetAnimValToBaseVal/animValWillChange/animVallDidChange methods to all
SVGAnimatedXXXAnimator classes that currently support animVal (SVGAnimatedLength/LengthList/Number(OptionalNumber)/NumberList/TransformList).
Those SVGAnimatedLengthAnimator can cast the generic SVGAnimatedProperty* associated with a certain SVG DOM property, to the real type
eg. SVGAnimatedLength (which is a SVGAnimatedPropertyTearOff<SVGLength>). This way we can call those methods, without relying on virtual
function calls. Also it makes the "SVGGenericAnimatedType* currentBaseValueVariant()" accessor needless, as we can just call the method
right on eg. the SVGAnimatedLength, which gives us the "const SVGLength&" object, instead of a generic pointer type, that we have to
reinterpret_cast to some hopefully-matching expected type. The new approach is truly type-safey, but needs a bit more boilerplate code.

To reduce the amount of copy&paste across the SVGAnimatedXXXAnimator classes, all code is placed in template functions in
SVGAnimatedTypeAnimator.h, which can be shared across all SVGAnimatedXXXAnimator classes, that inherit from SVGAnimatedTypeAnimator.

Test: svg/animations/force-use-shadow-tree-recreation-while-animating.html

svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore):
(WebCore::SVGAnimateElement::targetElementWillChange):

svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedLengthAnimator::animValWillChange):
(WebCore::SVGAnimatedLengthAnimator::animValDidChange):

svg/SVGAnimatedLength.h:

(WebCore):
(SVGAnimatedLengthAnimator):

svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedLengthListAnimator::animValWillChange):
(WebCore::SVGAnimatedLengthListAnimator::animValDidChange):

svg/SVGAnimatedLengthList.h:

(WebCore):
(SVGAnimatedLengthListAnimator):

svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberAnimator::animValDidChange):

svg/SVGAnimatedNumber.h:

(WebCore):
(SVGAnimatedNumberAnimator):

svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberListAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberListAnimator::animValDidChange):

svg/SVGAnimatedNumberList.h:

(WebCore):
(SVGAnimatedNumberListAnimator):

svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):

svg/SVGAnimatedNumberOptionalNumber.h:

(WebCore):
(SVGAnimatedNumberOptionalNumberAnimator):

svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedTransformListAnimator::animValWillChange):
(WebCore::SVGAnimatedTransformListAnimator::animValDidChange):

svg/SVGAnimatedTransformList.h:

(WebCore):
(SVGAnimatedTransformListAnimator):

svg/SVGAnimatedType.h:

(WebCore):

svg/SVGAnimatedTypeAnimator.h:

(WebCore):
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTypeAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedTypeAnimator::animValWillChange):
(WebCore::SVGAnimatedTypeAnimator::animValDidChange):
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
(WebCore::SVGAnimatedTypeAnimator::startAnimation):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType):
(WebCore::SVGAnimatedTypeAnimator::constructFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::constructFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType):
(WebCore::SVGAnimatedTypeAnimator::collectAnimatedPropertiesFromInstances):

svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::applyAnimatedValue):
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):

svg/SVGAnimationElement.h:

(SVGAnimationElement):

svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
(WebCore::SVGElementInstance::InstanceUpdateBlocker::InstanceUpdateBlocker):
(WebCore):
(WebCore::SVGElementInstance::InstanceUpdateBlocker::~InstanceUpdateBlocker):

svg/SVGElementInstance.h:

(WebCore):
(InstanceUpdateBlocker):
(SVGElementInstance):

svg/properties/SVGAnimatedListPropertyTearOff.h:

(WebCore::SVGAnimatedListPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::animValWillChange):
(WebCore::SVGAnimatedListPropertyTearOff::animValDidChange):

svg/properties/SVGAnimatedProperty.h:

(WebCore):

svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPropertyTearOff::animValWillChange):
(WebCore::SVGAnimatedPropertyTearOff::animValDidChange):

svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedStaticPropertyTearOff::animValWillChange):
(WebCore::SVGAnimatedStaticPropertyTearOff::animValDidChange):

LayoutTests:

Add a new test which forces recreation of a <use> shadow tree while animation is running.

svg/animations/force-use-shadow-tree-recreation-while-animating-expected.txt: Added.
svg/animations/force-use-shadow-tree-recreation-while-animating.html: Added.
svg/animations/resources/force-use-shadow-tree-recreation-while-animating.svg: Added.
svg/animations/script-tests/force-use-shadow-tree-recreation-while-animating.js: Added.

(sample1):
(sample2):
(forceUseShadowTreeRecreation):
(sample3):
(executeTest):

4:26 AM Changeset in webkit [111379] by keishi@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Marking WebFrameTest.DivAutoZoomParamsTest as failing.

tests/WebFrameTest.cpp:

(WebKit::TEST_F):

3:24 AM Changeset in webkit [111378] by Csaba Osztrogonác

2 edits
4 adds in trunk/LayoutTests

[Qt] Gardening, skip failing tests, add platform specific expected files.

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-03-20
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped:
platform/qt/fast/events/touch/gesture/pad-gesture-cancel-expected.png: Added after r111182.
platform/qt/fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added after r111182.

3:21 AM Changeset in webkit [111377] by peter@chromium.org

2 edits in trunk/Source/WTF

[Chromium] Fix the Android build by building NEWWTF for host
https://bugs.webkit.org/show_bug.cgi?id=81643

Reviewed by Tony Gentilcore.

Chromium for Android builds the ImageDiff target for the host architecture,
so all dependencies it has need to be able to build for host as well.
r111258 added (new)WTF as a dependency instead of just including the
header files, so make it possible to build the newwtf target for host.

WTF.gyp/WTF.gyp:

3:08 AM Changeset in webkit [111376] by mihnea@adobe.com

8 edits
12 adds in trunk

[CSSRegions]Implement NamedFlow::getRegionsByContentNode
https://bugs.webkit.org/show_bug.cgi?id=77746

Reviewed by David Hyatt.

The list of regions returned is a static node list.

Source/WebCore:

Tests: fast/regions/get-regions-by-content-node-horiz-bt.html

fast/regions/get-regions-by-content-node-horiz-tb.html
fast/regions/get-regions-by-content-node-vert-lr.html
fast/regions/get-regions-by-content-node-vert-rl.html
fast/regions/get-regions-by-content-node.html
fast/regions/get-regions-by-content-node2.html

dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::getRegionsByContentNode):
(WebCore):

dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

dom/WebKitNamedFlow.idl:
rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::regionInRange):
(WebCore):
(WebCore::RenderFlowThread::objectInFlowRegion):

rendering/RenderFlowThread.h:
rendering/RenderRegion.h:

(WebCore::RenderRegion::flowThread):

LayoutTests:

fast/regions/get-regions-by-content-node-expected.txt: Added.
fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Added.
fast/regions/get-regions-by-content-node-horiz-bt.html: Added.
fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Added.
fast/regions/get-regions-by-content-node-horiz-tb.html: Added.
fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Added.
fast/regions/get-regions-by-content-node-vert-lr.html: Added.
fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Added.
fast/regions/get-regions-by-content-node-vert-rl.html: Added.
fast/regions/get-regions-by-content-node.html: Added.
fast/regions/get-regions-by-content-node2-expected.txt: Added.
fast/regions/get-regions-by-content-node2.html: Added.

2:49 AM Changeset in webkit [111375] by Csaba Osztrogonác

2 edits in trunk/Tools

x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
https://bugs.webkit.org/show_bug.cgi?id=81502

Unreviewed.

qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.

2:40 AM Changeset in webkit [111374] by keishi@webkit.org

1 edit in trunk/LayoutTests/ChangeLog

[chromium] Fixing mime type for test expectation png files.

platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.png: Added property svn:mime-type.
platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png: Modified property svn:mime-type.
platform/chromium-linux/fast/table/max-width-integer-overflow-expected.png: Added property svn:mime-type.
platform/chromium-mac-leopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Modified property svn:mime-type.
platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added property svn:mime-type.
platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png: Added property svn:mime-type.
platform/chromium-mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Modified property svn:mime-type.
platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Modified property svn:mime-type.
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Modified property svn:mime-type.
platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Added property svn:mime-type.
platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.png: Added property svn:mime-type.
platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.png: Added property svn:mime-type.
platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.png: Modified property svn:mime-type.
platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Modified property svn:mime-type.

2:09 AM Changeset in webkit [111373] by leviw@chromium.org

2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Marking editing/selection/iframe.html as flaky on 10.6 debug. Occasionally the caret isn't painted for some reason.
Removing iframe-reparenting-new-page.html entry from test_expectations.txt since the test no longer exists.

platform/chromium/test_expectations.txt:

1:53 AM Changeset in webkit [111372] by Stephanie Lewis

2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=81637 fast/dom/Window/timer-resume-on-navigation-back.html times out.
Skips a test that times out.

Unreviewed.

platform/mac-wk2/Skipped:

1:32 AM Changeset in webkit [111371] by macpherson@chromium.org

4 edits in trunk/Source/WebCore

Remove min and max parameters from CSSPrimitiveValue's roundForImpreciseConversion function.
https://bugs.webkit.org/show_bug.cgi?id=81629

Reviewed by Andreas Kling.

No new tests / refactoring only.

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):

css/CSSPrimitiveValue.h:

(WebCore::roundForImpreciseConversion):

rendering/style/RenderStyle.h:

(WebCore::adjustForAbsoluteZoom):

1:24 AM Changeset in webkit [111370] by commit-queue@webkit.org

7 edits
3 adds in trunk

[BlackBerry]Cookies shouldn't be set into each of webcore's request and platform's request. And this makes a regression.
https://bugs.webkit.org/show_bug.cgi?id=80800

Source/WebCore:

FrameLoaderClientBlackBerry::dispatchWillSendRequest sets cookies to resourceRequest's header
list to show cookies in inspector. And NetworkManager::startJob will set cookies to platformRequest's
m_cookieData again. So cookies are set two times. This causes performance issue.

Moreover, platformRequest will copy cookies from the resourceRequest. And then platformRequest has
the same cookies in its header list and m_cookieData. Network will use header list's cookies which
are output as latin1 only. This causes the regression of https://bugs.webkit.org/show_bug.cgi?id=80307.

Now, set cookies in initializePlatformRequest to ensure setting cookies only once.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-20
Reviewed by George Staikos.

Test: http/tests/cookies/resources/setUtf8Cookies.php

platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

platform/network/blackberry/ResourceRequest.h:

(ResourceRequest):

platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

Source/WebKit/blackberry:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-20
Reviewed by George Staikos.

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

LayoutTests:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-20
Reviewed by George Staikos.

http/tests/cookies/resources/setUtf8Cookies-expected.txt: Added.
http/tests/cookies/resources/setUtf8Cookies-result.php: Added.
http/tests/cookies/resources/setUtf8Cookies.php: Added.

1:20 AM Changeset in webkit [111369] by keishi@webkit.org

2 edits in trunk/LayoutTests

[chromium] Marking listbox-clear-restore.html on Linux as flaky.

platform/chromium/test_expectations.txt:

12:59 AM Changeset in webkit [111368] by Stephanie Lewis

5 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=81634 some SVG Zoom tests fail on Lion WK2 bots

Unreviewed.

Check in new expected (failing?) results.

platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:

Mar 19, 2012:

11:49 PM Changeset in webkit [111367] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] New test introduced in r110532 fails on 32 bit.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-03-19
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped:

11:48 PM Changeset in webkit [111366] by jochen@chromium.org

3 edits in trunk/Source/JavaScriptCore

Split WTFReportBacktrace into WTFReportBacktrace and WTFPrintBacktrace
https://bugs.webkit.org/show_bug.cgi?id=80983

Reviewed by Darin Adler.

This allows printing a backtrace acquired by an earlier WTFGetBacktrace
call which is useful for local debugging.

wtf/Assertions.cpp:
wtf/Assertions.h:

11:43 PM Changeset in webkit [111365] by keishi@webkit.org

1 edit
9 adds in trunk/LayoutTests

[chromium] Rebaselining nested-fragment-parser-crash.html again.

platform/chromium-linux-x86/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
platform/chromium-linux/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
platform/chromium-mac-leopard/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
platform/chromium-win-vista/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
platform/chromium-win-xp/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
platform/chromium-win/fast/parser/nested-fragment-parser-crash-expected.txt: Added.

11:37 PM Changeset in webkit [111364] by benjamin@webkit.org

3 edits in trunk/Source/WebCore

Build fix for Debug build after r111358

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-19

bindings/js/CachedScriptSourceProvider.h:
bindings/js/StringSourceProvider.h:

11:35 PM Changeset in webkit [111363] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

fast/table/max-width-integer-overflow.html should be skipped because it gives
different results on 32- and 64-bit systems.

Patch by János Badics <János Badics> on 2012-03-19
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped:

11:17 PM Changeset in webkit [111362] by eae@chromium.org

3 edits in trunk/Source/WebCore

Add FractionalLayoutUnit version of blend to AnimationUtilities
https://bugs.webkit.org/show_bug.cgi?id=81572

Reviewed by Eric Seidel.

Add version of blend method that operates on FractionalLayoutUnits. This
will be used in place of the integer version in many places once we
enable support for subpixel layout.

No new tests.

platform/FractionalLayoutUnit.h:

Include math.h to make GTK build happy.

platform/animation/AnimationUtilities.h:

(WebCore::blend):

10:58 PM Changeset in webkit [111361] by abarth@webkit.org

46 edits
2 adds
25 deletes in trunk

Remove support for "magic" iframe
https://bugs.webkit.org/show_bug.cgi?id=81590

Reviewed by Eric Seidel.

Source/WebCore:

This patch removes support for "magic" iframe, which previously allowed
an iframe to be transfered from one document to another without
reloading the iframe. The idea behind this feature was to let sites
create "pop out" windows that could outlive their parents by
transfering state to these windows via these magic iframes.

Unforuntately, this feature was never implemented by other browsers and
has been the source of a series of security vulnerabilities. Although
we have fixed each vulnerability as it has been discovered, the feature
is still a complex corner case that isn't widely exercised on the web.
For that reason, it's likely to have more vulnerabilities in the
future.

I'm not aware of any web sites that use this feature anymore. There
were a handful of them, but we appear to have been successful in
evangalizing them to move away from "magic" iframe.

dom/Document.cpp:

(WebCore::Document::adoptNode):

html/HTMLFrameElementBase.cpp:

(WebCore):
(WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
(WebCore::HTMLFrameElementBase::insertedIntoDocument):

html/HTMLFrameElementBase.h:

(HTMLFrameElementBase):

loader/DocumentLoader.cpp:

(WebCore):

loader/DocumentLoader.h:

(DocumentLoader):

loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::createFrame):

loader/FrameLoader.cpp:

(WebCore):

loader/FrameLoader.h:

(FrameLoader):

loader/FrameLoaderClient.h:

(FrameLoaderClient):

loader/ResourceLoadNotifier.cpp:

(WebCore):

loader/ResourceLoadNotifier.h:

(ResourceLoadNotifier):

page/Frame.cpp:

(WebCore):

page/Frame.h:

(Frame):

Source/WebKit/blackberry:

Remove FrameLoaderClient methods that no longer exist.

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore):

WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::didDetectXSS):

Source/WebKit/chromium:

Remove FrameLoaderClient methods that no longer exist.

public/WebFrameClient.h:

(WebFrameClient):

src/FrameLoaderClientImpl.cpp:

(WebKit):

src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

Source/WebKit/efl:

Remove FrameLoaderClient methods that no longer exist.

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore):

WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

Source/WebKit/gtk:

Remove FrameLoaderClient methods that no longer exist.

WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit):

WebCoreSupport/FrameLoaderClientGtk.h:

(FrameLoaderClient):

Source/WebKit/mac:

Remove FrameLoaderClient methods that no longer exist.

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/qt:

Remove FrameLoaderClient methods that no longer exist.

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore):

WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

Source/WebKit/win:

Remove FrameLoaderClient methods that no longer exist.

WebCoreSupport/WebFrameLoaderClient.cpp:
WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

Source/WebKit/wince:

Remove FrameLoaderClient methods that no longer exist.

WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit):

WebCoreSupport/FrameLoaderClientWinCE.h:

(FrameLoaderClientWinCE):

Source/WebKit/wx:

Remove FrameLoaderClient methods that no longer exist.

WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore):

WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

Remove FrameLoaderClient methods that no longer exist.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

LayoutTests:

Remove tests of magic iframe. These tests don't reall make sense to
keep without the feature.

fast/frames/adopt-iframe-into-itself-expected.txt: Added.
fast/frames/adopt-iframe-into-itself.html: Added.
- I've added a test about adopting an iframe into itself. We might already have a test for this, but it covers a mistake I made in an earlier iteration of this patch.
fast/frames/iframe-reparenting-adopt-node-expected.txt: Removed.
fast/frames/iframe-reparenting-adopt-node.html: Removed.
fast/frames/iframe-reparenting-embed-elements-expected.txt: Removed.
fast/frames/iframe-reparenting-embed-elements.html: Removed.
fast/frames/iframe-reparenting-expected.txt: Removed.
fast/frames/iframe-reparenting-fail-load-expected.txt: Removed.
fast/frames/iframe-reparenting-fail-load.html: Removed.
fast/frames/iframe-reparenting-new-page-expected.txt: Removed.
fast/frames/iframe-reparenting-new-page.html: Removed.
fast/frames/iframe-reparenting-plugins-expected.txt: Removed.
fast/frames/iframe-reparenting-plugins.html: Removed.
fast/frames/iframe-reparenting.html: Removed.
fast/frames/resources/iframe-reparenting-adopt-node-iframe-content.html: Removed.
fast/frames/resources/iframe-reparenting-adopt-node-new-page.html: Removed.
fast/frames/resources/iframe-reparenting-embed-frame1.html: Removed.
fast/frames/resources/iframe-reparenting-embed-iframe.html: Removed.
fast/frames/resources/iframe-reparenting-frame1.html: Removed.
fast/frames/resources/iframe-reparenting-frame2.html: Removed.
fast/frames/resources/iframe-reparenting-iframe-content.html: Removed.
fast/frames/resources/iframe-reparenting-new-page-1.html: Removed.
fast/frames/resources/iframe-reparenting-new-page-2.html: Removed.
fast/frames/resources/iframe-reparenting-new-page-iframe.html: Removed.
fast/frames/resources/iframe-reparenting-plugins-iframe-content.html: Removed.
fast/frames/resources/iframe-reparenting-plugins-new-page.html: Removed.
fast/frames/script-tests/iframe-reparenting-new-page.js: Removed.

10:37 PM Changeset in webkit [111360] by jchaffraix@webkit.org

3 edits
5 adds in trunk

REGRESSION(r110072): Improper repainting on table with overflow: hidden
https://bugs.webkit.org/show_bug.cgi?id=81460

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/repaint/table-hover-on-link.html

rendering/RenderTable.cpp:

(WebCore::RenderTable::layout): Add a call to RenderBlock::updateCachedSizeForOverflowClip
so that we properly keep our cached size up to date. This fixes the problem for now but the
real solution is to make sure it is called on all classes that needs to. This is tracked by
bug 81461.

LayoutTests:

fast/repaint/table-hover-on-link-expected.txt: Added.
fast/repaint/table-hover-on-link.html: Added.

platform/chromium-linux/fast/repaint/table-hover-on-link-expected.png: Added.
platform/chromium-mac/fast/repaint/table-hover-on-link-expected.png: Added.
platform/mac/fast/repaint/table-hover-on-link-expected.png: Added.

There seem to be some small color difference here (maybe color profile related).

10:29 PM Changeset in webkit [111359] by commit-queue@webkit.org

5 edits
8 adds in trunk

Add support for crossorigin attribute in script elements
https://bugs.webkit.org/show_bug.cgi?id=81438

Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-19
Reviewed by Adam Barth.

Source/WebCore:

Works similarly to img and its crossorigin attribute. In the future it
could allow for things like showing full error messages in error
handlers, etc.

Tests: http/tests/security/script-crossorigin-loads-correctly.html

http/tests/security/script-crossorigin-loads-same-origin.html
http/tests/security/script-with-failed-cors-check-fails-to-load.html

dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::notifyFinished):

dom/ScriptElement.h:

(ScriptElement):

html/HTMLScriptElement.idl:

LayoutTests:

http/tests/security/resources/alert-fail.js: Added.
http/tests/security/resources/cors-script.php: Added.
http/tests/security/script-crossorigin-loads-correctly-expected.txt: Added.
http/tests/security/script-crossorigin-loads-correctly.html: Added.
http/tests/security/script-crossorigin-loads-same-origin-expected.txt: Added.
http/tests/security/script-crossorigin-loads-same-origin.html: Added.
http/tests/security/script-with-failed-cors-check-fails-to-load-expected.txt: Added.
http/tests/security/script-with-failed-cors-check-fails-to-load.html: Added.

10:24 PM Changeset in webkit [111358] by benjamin@webkit.org

6 edits in trunk/Source

Do not copy the script source in the SourceProvider, just reference the existing string
https://bugs.webkit.org/show_bug.cgi?id=81466

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

parser/SourceCode.h: Remove the unused, and incorrect, function data().
parser/SourceProvider.h: Add OVERRIDE for clarity.

Source/WebCore:

Instead of creating a copy of the string with 16bits characters, we just return
a shared StringImpl.

bindings/js/CachedScriptSourceProvider.h:
bindings/js/StringSourceProvider.h:

10:21 PM Changeset in webkit [111357] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

A quick early-out for Region::contains() test
https://bugs.webkit.org/show_bug.cgi?id=81625

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Anders Carlsson.

If the bounds of region B include a row/column that is outside the bounds of
region A, then region B contains a pixel within that row/column that is
outside of region A.

platform/graphics/Region.cpp:

(WebCore::Region::contains):

10:20 PM Changeset in webkit [111356] by eric@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed attempt to fix the EFL build.

platform/graphics/efl/IconEfl.cpp:

10:15 PM Changeset in webkit [111355] by fpizlo@apple.com

7 edits in trunk/Source/JavaScriptCore

Division optimizations fail to infer cases of truncated division and
mishandle -2147483648/-1
https://bugs.webkit.org/show_bug.cgi?id=81428
<rdar://problem/11067382>

Reviewed by Oliver Hunt.

If you're a division over integers and you're only used as an integer, then you're
an integer division and remainder checks become unnecessary. If you're dividing
-2147483648 by -1, don't crash.

assembler/MacroAssemblerX86Common.h:

(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::add32):

dfg/DFGSpeculativeJIT.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):

dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

llint/LowLevelInterpreter64.asm:

10:04 PM Changeset in webkit [111354] by eric@webkit.org

36 edits in trunk/Source/WebCore

Fix more WTF header include paths in WebCore
https://bugs.webkit.org/show_bug.cgi?id=81602

Reviewed by Martin Robinson.

Chromium, Mac and Win already build w/o including wtf subdirectories
in their include paths for WebCore/WebKit. Gtk, Qt, and other ports
should eventually do the same. This patch fixes up a few loose
wtf includes in these ports using some search/replace across WebCore.
If the EWS bots pass this patch doesn't really need any other review.

accessibility/gtk/AXObjectCacheAtk.cpp:
accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
platform/KURL.cpp:
platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
platform/audio/gtk/AudioBusGtk.cpp:
platform/clutter/GRefPtrClutter.h:
platform/graphics/gstreamer/GRefPtrGStreamer.h:
platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
platform/graphics/gstreamer/ImageGStreamerQt.cpp:
platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
platform/graphics/gtk/ImageBufferGtk.cpp:
platform/graphics/pango/FontPango.cpp:
platform/graphics/qt/ImageBufferDataQt.h:
platform/graphics/wx/ImageBufferDataWx.h:
platform/gtk/ContextMenuGtk.cpp:
platform/gtk/ContextMenuItemGtk.cpp:
platform/gtk/FileSystemGtk.cpp:
platform/gtk/GOwnPtrGtk.h:
platform/gtk/GtkAuthenticationDialog.h:
platform/gtk/GtkPopupMenu.cpp:
platform/gtk/LanguageGtk.cpp:
platform/gtk/LocalizedStringsGtk.cpp:
platform/gtk/PopupMenuGtk.cpp:
platform/gtk/RenderThemeGtk.cpp:
platform/gtk/RenderThemeGtk.h:
platform/network/soup/GOwnPtrSoup.h:
platform/network/soup/ResourceRequestSoup.cpp:
platform/network/soup/ResourceResponseSoup.cpp:
platform/network/soup/SocketStreamHandle.h:
platform/network/soup/SoupURIUtils.cpp:
platform/text/TextEncoding.cpp:
platform/text/gtk/TextBreakIteratorGtk.cpp:
platform/text/gtk/TextCodecGtk.cpp:
platform/text/gtk/TextCodecGtk.h:

9:53 PM Changeset in webkit [111353] by jchaffraix@webkit.org

5 edits in trunk/Source/WebCore

Move the extra logical height distribution into RenderTable as a new step in our layout algorithm
https://bugs.webkit.org/show_bug.cgi?id=81548

Reviewed by Tony Chang.

Refactoring, no expected change in behavior.

Moving the distribution step into RenderTable is needed to implement a better distribution algorithm that would
span several RenderTableSection (which is what IE and FF are doing right now).

rendering/RenderTable.cpp:

(WebCore::RenderTable::distributeExtraLogicalHeight):
(WebCore::RenderTable::layout):
Moved the distribution step into distributeExtraLogicalHeight. While at it, changed the code to make use of the helper
methods to iterate over the sections and explicitly floor the LayoutUnit before calling distributeExtraLogicalHeight.

rendering/RenderTable.h:

Added distributeExtraLogicalHeight.

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
Changed the method signature as it doesn't handle the distribution step anymore.

rendering/RenderTableSection.h:

Updated layoutRows signature and exposed distributeExtraLogicalHeightToRows for RenderTable use.

9:50 PM Changeset in webkit [111352] by andersca@apple.com

2 edits in trunk/Source/WebCore

Another attempt at fixing the Windows build.

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::LayerClient::platformCALayerDeviceScaleFactor):

9:48 PM Changeset in webkit [111351] by andersca@apple.com

2 edits
1 move
9 deletes in trunk/LayoutTests

plugins/application-plugin-plugins-disabled.html should be a Qt specific test
https://bugs.webkit.org/show_bug.cgi?id=81628

Reviewed by Jessie Berlin.

This test tests an "application specific plug-in" feature that only Qt has so this should be
a Qt specific test.

platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.png: Removed.
platform/chromium-mac-leopard/plugins/application-plugin-plugins-disabled-expected.png: Removed.
platform/chromium-mac-snowleopard/plugins/application-plugin-plugins-disabled-expected.png: Removed.
platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.png: Removed.
platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.png: Removed.
platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
platform/gtk/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
platform/mac-snowleopard/plugins/application-plugin-plugins-disabled-expected.png: Removed.
platform/mac/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
platform/qt/plugins/application-plugin-plugins-disabled.html: Renamed from LayoutTests/plugins/application-plugin-plugins-disabled.html.
platform/wk2/Skipped:

9:47 PM Changeset in webkit [111350] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Add registerURLSchemeAsEmptyDocument to WebSecurityPolicy
https://bugs.webkit.org/show_bug.cgi?id=81421

Patch by Charlie Reis <creis@chromium.org> on 2012-03-19
Reviewed by Adam Barth.

public/WebSecurityPolicy.h:

(WebSecurityPolicy):

src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::registerURLSchemeAsEmptyDocument):
(WebKit):

9:45 PM Changeset in webkit [111349] by keishi@webkit.org

1 edit
3 adds in trunk/LayoutTests

[chromium] Rebaseline caused by r111334

platform/chromium-linux-x86/fast/repaint/canvas-putImageData-expected.txt: Added.
platform/chromium-linux/fast/repaint/canvas-putImageData-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt: Added.

9:39 PM Changeset in webkit [111348] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebCore

[EFL] Fix build break because of PlatformString.h
https://bugs.webkit.org/show_bug.cgi?id=81619

Unreviewed. Fix build break because of PlatformString.h.

platform/graphics/efl/IconEfl.cpp: Include PlatformString.h from text directory.

9:25 PM Changeset in webkit [111347] by eric@webkit.org

8 edits in trunk/Source/WebCore

Fix CrWin build after r111258.
https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.
I also fixed similarly incorrect wtf/ includes for other ports
(which aren't yet as strict as Chromium about wtf includes).

platform/blackberry/CookieManager.cpp:
platform/blackberry/CookieParser.cpp:
platform/blackberry/ParsedCookie.cpp:
platform/blackberry/SharedTimerBlackBerry.cpp:
platform/graphics/qt/GraphicsLayerQt.cpp:
platform/graphics/texmap/TextureMapperAnimation.cpp:
rendering/RenderThemeChromiumWin.cpp:

(WebCore):

9:04 PM Changeset in webkit [111346] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

[WK2] Four http/tests/xmlhttprequest tests fail on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=81627

Unreviewed; skip failing http/tests/xmlhttprequest tests on mac-wk2.

platform/mac-wk2/Skipped:

8:51 PM Changeset in webkit [111345] by Martin Robinson

4 edits in releases/WebKitGTK/webkit-1.8

Update the NEWS and version for the WebKitGTK+ 1.7.92 release.

Reviewed by Gustavo Noronha Silva.

configure.ac:

Source/WebKit/gtk:

NEWS:

8:48 PM Changeset in webkit [111344] by eric@webkit.org

4 edits in trunk/Source/WebCore

Fix CrWin build after r111258.
https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.

platform/graphics/chromium/FontCacheChromiumWin.cpp:
platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
platform/graphics/texmap/TextureMapperAnimation.h:

8:46 PM Changeset in webkit [111343] by jberlin@webkit.org

5 edits in trunk/Tools

Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
because they broke running the layout tests on mac.

Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._check_for_driver_crash):

8:32 PM Changeset in webkit [111342] by tony@chromium.org

29 edits in trunk

add css parsing of flex-line-pack
https://bugs.webkit.org/show_bug.cgi?id=81427

Reviewed by Ojan Vafai.

Source/WebCore:

Spec: http://dev.w3.org/csswg/css3-flexbox/#flex-line-pack

Updated tests in css3/flexbox/css-properties.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EFlexLinePack):

css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

css/CSSPropertyNames.in:
css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

css/CSSValueKeywords.in:
rendering/style/RenderStyle.h:
rendering/style/RenderStyleConstants.h:
rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData):

LayoutTests:

css3/flexbox/css-properties-expected.txt:
css3/flexbox/script-tests/css-properties.js:

8:27 PM Changeset in webkit [111341] by Stephanie Lewis

2 edits in trunk/LayoutTests

http://bugs.webkit.org/show_bug.cgi?id=81618

fast/workers/storage/use-same-database-in-page-and-workers.html times out on the lion bots
parser test that times out waiting for notifyDone

Unreviewed.

Skip test that times out on the Lion WK1 bots.

platform/mac/Skipped:

8:22 PM Changeset in webkit [111340] by kov@webkit.org

9 edits in trunk

[GTK] libWebCore.la has become too big for make
https://bugs.webkit.org/show_bug.cgi?id=81582

Unreviewed build fix.

Source/WebCore:

GNUmakefile.am: build an intermediate library for modules, so that the list

of source files used to build WebCore can be split and not reach make's limits;
also try to force relinking libWebCore.la and libWebCoreModules.la when the
GNUmakefile.am or GNUmakefile.list.am change

Source/WebKit/gtk:

GNUmakefile.am: link-in the new libDerivedWebCore.la

Source/WebKit2:

GNUmakefile.am: link-in the new libWebCoreModules.la

8:17 PM Changeset in webkit [111339] by Stephanie Lewis

3 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=81620 tables/mozilla/bugs/bug27038-* fail on Lion Bots.

Unreviewed.

Check in new expected (failing?) results.

platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:

8:14 PM Changeset in webkit [111338] by keishi@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Fixing build. Adding missing virtual.

src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

8:13 PM Changeset in webkit [111337] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

[WK2] http/tests/websocket/tests/hixie76/frame-lengths.html times out on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=81624

Unreviewed; skip timing out http/tests/websocket/tests/hixie76/frame-lengths.html on mac-wk2

platform/mac-wk2/Skipped:

8:12 PM Changeset in webkit [111336] by Stephanie Lewis

1 edit
1 add in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=81615
fast/parser/nested-fragment-parser-crash.html is failing on the lion bots

Unreviewed.

Check in new expected (failing?) results.

platform/mac/fast/parser/nested-fragment-parser-crash-expected.txt: Added.

8:10 PM Changeset in webkit [111335] by commit-queue@webkit.org

4 edits in trunk/Source

[chromium] Push culled tiles that are prepainted
https://bugs.webkit.org/show_bug.cgi?id=81552

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/WebCore:

If a tile was culled during paint, but then prepainted in the following
idle paint pass, it was still marked as culled (and thus dirty) and not
pushed to the impl side.

Renames tile->m_updateCulled to tile->m_updated. This value is true if
the tile is updated any time during a commit, and remains false if it
is culled every time the layer is painted.

Unit test: TiledLayerChromiumTest.pushIdlePaintedOccludedTiles

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):

Source/WebKit/chromium:

tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

8:09 PM Changeset in webkit [111334] by Stephanie Lewis

3 edits
1 add in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=81617 fast/repaint/canvas-putImageData.html fails on the Lion bots

Unreviewed.

Check in new expected (failing?) results.

platform/mac/fast/repaint/canvas-putImageData-expected.txt: Added.
platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:

8:08 PM Changeset in webkit [111333] by keishi@webkit.org

1 edit
2 adds in trunk/LayoutTests

[chromium] Rebaselining float-in-float-hit-testing and 056 in response
to r111281.

platform/chromium-mac/fast/block/float/float-in-float-hit-testing-expected.txt: Added.
platform/chromium-mac/fast/block/margin-collapse/056-expected.txt: Added.

8:05 PM Changeset in webkit [111332] by jberlin@webkit.org

18 edits
4 adds in trunk/LayoutTests

A bunch of media tests failing on Lion Intel Debug WebKit1 and WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81623

Rebaseline failing mac and mac-wk2 media tests.

platform/mac-wk2/media/no-auto-play-in-sandbox-expected.txt: Added.
platform/mac-wk2/media/video-playing-and-pause-expected.txt:
platform/mac/media/audio-controls-rendering-expected.png:
platform/mac/media/controls-after-reload-expected.png:
platform/mac/media/controls-after-reload-expected.txt:
platform/mac/media/controls-layout-direction-expected.png:
platform/mac/media/controls-strict-expected.png:
platform/mac/media/controls-strict-expected.txt:
platform/mac/media/media-controls-clone-expected.png:
platform/mac/media/video-colorspace-yuv420-expected.png: Added.
platform/mac/media/video-colorspace-yuv422-expected.png: Added.
platform/mac/media/video-controls-rendering-expected.png:
platform/mac/media/video-controls-rendering-expected.txt:
platform/mac/media/video-display-toggle-expected.png:
platform/mac/media/video-display-toggle-expected.txt:
platform/mac/media/video-layer-crash-expected.png:
platform/mac/media/video-no-audio-expected.png:
platform/mac/media/video-no-audio-expected.txt:
platform/mac/media/video-playing-and-pause-expected.png:
platform/mac/media/video-playing-and-pause-expected.txt:
platform/mac/media/video-size-intrinsic-scale-expected.txt: Added.

8:02 PM Changeset in webkit [111331] by andersca@apple.com

2 edits in trunk/Source/WebKit/win

Fix Windows build.

FullscreenVideoController.cpp:

(FullscreenVideoController::LayerClient::platformCALayerDeviceScaleFactor):

7:57 PM Changeset in webkit [111330] by andersca@apple.com

2 edits in trunk/Source/WebCore

Fix Snow Leopard build.

platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::createTileLayer):

7:54 PM Changeset in webkit [111329] by jamesr@google.com

2 edits in trunk/Source/WebKit/chromium

Unreviewed chromium compile fix - put all TRACE_*s in their own scope explicitly.

src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):

7:52 PM Changeset in webkit [111328] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

[WK2] http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html fails after r97360
https://bugs.webkit.org/show_bug.cgi?id=70245

Unreviewed; skip failing http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html on mac-wk2.

platform/mac-wk2/Skipped:

7:48 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

7:47 PM Changeset in webkit [111327] by Martin Robinson

5 edits in releases/WebKitGTK/webkit-1.8

Merging r111316

7:47 PM Changeset in webkit [111326] by Stephanie Lewis

4 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=81610 fast/regions fail on Lion bots

Unreviewed.

Check in new expected (failing?) results.

platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:

7:47 PM Changeset in webkit [111325] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110866

7:46 PM Changeset in webkit [111324] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110847

7:46 PM Changeset in webkit [111323] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110845

7:45 PM Changeset in webkit [111322] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110062

7:45 PM Changeset in webkit [111321] by tony@chromium.org

2 edits in trunk

clean up gitignore
https://bugs.webkit.org/show_bug.cgi?id=81594

Reviewed by James Robinson.

.gitignore: .suo files are per-user files used by VS2010. .ninja

files are no longer generated in the tree-- they are generated in the
build directory.

7:45 PM Changeset in webkit [111320] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110060

7:44 PM Changeset in webkit [111319] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110059

7:44 PM Changeset in webkit [111318] by Stephanie Lewis

3 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=81608 fast/multicol/span/span-as-immediate… fail on Lion bots

Unreviewed.

Check in new expected (failing?) results.

platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:

7:42 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

7:40 PM Changeset in webkit [111317] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

[WK2] http/tests/navigation/https-in-page-cache.html times out on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=81622

Unreviewed; skip failing http/tests/navigation/https-in-page-cache.html on mac-wk2.

platform/mac-wk2/Skipped:

7:34 PM Changeset in webkit [111316] by Martin Robinson

5 edits in trunk

Source/WebKit/gtk: [GTK] Allow running run-gtk-tests during 'make dist'
https://bugs.webkit.org/show_bug.cgi?id=81415

Reviewed by Philippe Normand.

GNUmakefile.am: Remove 'make check' rules from the makefile

Instead this functionality is now in the Tools makefile.

Tools: [GTK] Allow running run-gtk-tests during 'make distcheck'
https://bugs.webkit.org/show_bug.cgi?id=81415

Reviewed by Philippe Normand.

Modify the build and run-gtk-tests so that it can run during 'make distcheck'

GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the

main command run during 'make check.'

Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer

a requirement to run it. If jhbuild isn't around it will simply not start the
SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
main loop and simply use the main loop in a synchronous method to start SPI
daemons. Did a bunch of general cleanup around these tasks.

7:30 PM Changeset in webkit [111315] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

[WK2] http/tests/navigation/anchor-frames-gbk.html fails
https://bugs.webkit.org/show_bug.cgi?id=76896
<rdar://problem/11078978>

Unreviewed; skip failing http/tests/navigation/anchor-frames-gbk.html on mac-wk2.

platform/mac-wk2/Skipped:

7:28 PM Changeset in webkit [111314] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] return true/false on GestureFlingCancel if a fling was stopped
https://bugs.webkit.org/show_bug.cgi?id=81563

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):

7:27 PM Changeset in webkit [111313] by kubo@profusion.mobi

5 edits in trunk/Tools

jhbuild: Use the multiprocessing module to get the number of CPUs.
https://bugs.webkit.org/show_bug.cgi?id=81585

Reviewed by Martin Robinson.

Now that support for Python 2.5 has been dropped, we can safely
use multiprocessing.cpu_count() to obtain the current number of
CPUs in the system instead of running a webkitperl script for
that.

efl/common.py:

(top_level_path):

efl/jhbuildrc:
gtk/common.py:

(build_path):

gtk/jhbuildrc:

7:25 PM Changeset in webkit [111312] by commit-queue@webkit.org

9 edits in trunk/Source

[chromium] Adding support for GL_EXT_discard_framebuffer.
https://bugs.webkit.org/show_bug.cgi?id=81383

Patch by Michal Mocny <mmocny@google.com> on 2012-03-19
Reviewed by James Robinson.

Source/Platform:

chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::discardFramebufferEXT):
(WebKit::WebGraphicsContext3D::ensureFramebufferCHROMIUM):

Source/WebCore:

platform/graphics/chromium/Extensions3DChromium.h:

Source/WebKit/chromium:

src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):

src/GraphicsContext3DChromium.cpp:

(WebCore):

src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::discardFramebufferEXT):
(WebKit::FakeWebGraphicsContext3D::ensureFramebufferCHROMIUM):
(FakeWebGraphicsContext3D):

7:20 PM Changeset in webkit [111311] by ojan@chromium.org

2 edits in trunk/Tools

We should only add a live event listener once, not once per TestSelector.
Adding one per TestSelector would cause accordion('option', 'active') to
incorrectly be "false" if you examine multiple sets of tests.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

7:19 PM Changeset in webkit [111310] by adamk@chromium.org

2 edits in trunk/Source/WebCore

Refactor ContainerNode::replaceChild to match other mutation methods and share code
https://bugs.webkit.org/show_bug.cgi?id=81579

Reviewed by Ojan Vafai.

A future change will make use of the consistency among insertBefore/appendChild/replaceChild
to handle insertion of DocumentFragments more cleanly.

No new tests, no change in behavior.

dom/ContainerNode.cpp:

7:19 PM Changeset in webkit [111309] by timothy_horton@apple.com

1 edit
3 adds in trunk/LayoutTests

http/tests/misc/acid3.html fails on mac-lion-wk2
https://bugs.webkit.org/show_bug.cgi?id=81621
<rdar://problem/11078942>

Unreviewed; check in failing results for mac-wk2.

platform/mac-wk2/http/tests/misc/acid3-expected.png: Added.
platform/mac-wk2/http/tests/misc/acid3-expected.txt: Added.

7:15 PM Changeset in webkit [111308] by commit-queue@webkit.org

15 edits in trunk/Source

[chromium] Times in the cc should be expressed in seconds.
https://bugs.webkit.org/show_bug.cgi?id=80514

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-19
Reviewed by James Robinson.

Source/WebCore:

Updated timer tests to use seconds.

platform/TouchFlingPlatformGestureCurve.h:

(TouchFlingPlatformGestureCurve):

platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:

(WebCore::CCActiveGestureAnimation::animate):

platform/graphics/chromium/cc/CCActiveGestureAnimation.h:

(CCActiveGestureAnimation):

platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:

(WebCore::CCDelayBasedTimeSource::create):
(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::onTimerFired):
(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):
(WebCore):
(WebCore::CCDelayBasedTimeSource::postNextTickTask):

platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:

(CCDelayBasedTimeSource):

platform/graphics/chromium/cc/CCGestureCurve.h:

(CCGestureCurve):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WTF):
(WebCore::CCThreadProxy::beginContextRecreation):
(WebCore::CCThreadProxy::tryToRecreateContext):
(WebCore::CCThreadProxy::initializeImplOnImplThread):

platform/graphics/chromium/cc/CCTimer.cpp:

(WebCore::CCTimer::startOneShot):

platform/graphics/chromium/cc/CCTimer.h:

(CCTimer):

Source/WebKit/chromium:

tests/CCDelayBasedTimeSourceTest.cpp:

(WebKitTests::TEST):

tests/CCFrameRateControllerTest.cpp:

(WebKitTests::TEST):

tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCThread::pendingDelayMs):
(WebKitTests::FakeCCDelayBasedTimeSource::create):
(WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicallyIncreasingTime):
(WebKitTests::FakeCCDelayBasedTimeSource::monotonicallyIncreasingTime):
(WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource):
(FakeCCDelayBasedTimeSource):

tests/CCTimerTest.cpp:

(WebKitTests::TEST_F):

7:10 PM Changeset in webkit [111307] by dpranke@chromium.org

2 edits in trunk/Tools

Fix typo introduced in r111293.

Unreviewed, build fix.

Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._check_for_driver_crash):

7:09 PM Changeset in webkit [111306] by benjamin@webkit.org

3 edits in trunk/Source/JavaScriptCore

Simplify SmallStrings
https://bugs.webkit.org/show_bug.cgi?id=81445

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-19
Reviewed by Gavin Barraclough.

SmallStrings had two methods that should not be public: count() and clear().

The method clear() is effectively replaced by finalizeSmallStrings(). The body
of the method was moved to the constructor since the code is obvious.

The method count() is unused.

runtime/SmallStrings.cpp:

(JSC::SmallStrings::SmallStrings):

runtime/SmallStrings.h:

(SmallStrings):

7:04 PM Changeset in webkit [111305] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

[WK2] WebKitTestRunner needs to print frame load delegate information
https://bugs.webkit.org/show_bug.cgi?id=42705

Skip http/tests/loading/state-object-security-exception.html until WKTR prints frame load delegate information.

platform/wk2/Skipped:

7:04 PM Changeset in webkit [111304] by Martin Robinson

17 edits
4 adds in releases/WebKitGTK/webkit-1.8

Merging r110999

7:01 PM Changeset in webkit [111303] by jberlin@webkit.org

2 edits in trunk/LayoutTests

fast/dom/Window/window-properties.html failing on Lion Intel Debug WebKit1 and WebKit2
testers.
https://bugs.webkit.org/show_bug.cgi?id=81612

Update the expected (failing?) results to get the bots green.

platform/mac/fast/dom/Window/window-properties-expected.txt:

7:01 PM Changeset in webkit [111302] by jberlin@webkit.org

2 edits
2 adds in trunk/LayoutTests

fast/harness/page-cache-crash-on-data-urls.html and fast/harness/use-page-cache.html fail on
Lion Intel Debug WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81616

Skip the flakey one and add expected failing results for the other.

platform/mac-wk2/fast/harness/use-page-cache-expected.txt: Added.
platform/wk2/Skipped:

7:00 PM Changeset in webkit [111301] by Martin Robinson

4 edits in releases/WebKitGTK/webkit-1.8

Merging r111110

6:52 PM Changeset in webkit [111300] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging 110762

6:51 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

6:45 PM Changeset in webkit [111299] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Stop messing with the AppKit grow box on platforms that don't support it
<rdar://problem/10752048>
https://bugs.webkit.org/show_bug.cgi?id=81614

Reviewed by Dan Bernstein.

UIProcess/API/mac/WKView.mm:

(-[WKView viewWillMoveToWindow:]):
(-[WKView _didChangeScrollbarsForMainFrame]):
Snow Leopard was the last Mac OS to need a grow box.

6:45 PM Changeset in webkit [111298] by Martin Robinson

6 edits
2 deletes in releases/WebKitGTK/webkit-1.8

Merging r110478

6:41 PM Changeset in webkit [111297] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

[WK2] Support layoutTestController.dumpProgressFinishedCallback() in WKTR
https://bugs.webkit.org/show_bug.cgi?id=81613

Unreviewed; skip http/tests/loading/progress-finished-callback.html on mac-wk2.

platform/mac-wk2/Skipped:

6:40 PM Changeset in webkit [111296] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r111027

6:37 PM Changeset in webkit [111295] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110446

6:35 PM Changeset in webkit [111294] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110296

6:33 PM Changeset in webkit [111293] by dpranke@chromium.org

5 edits in trunk/Tools

webkitpy: get ServerProcess out of the reportcrash business
https://bugs.webkit.org/show_bug.cgi?id=81600

Reviewed by Adam Barth.

ServerProcess was half-aware that ReportCrash might run
sometimes, and that the process ServerProcess was talking to
might have its own crashing subprocesses; neither of these
things really worked right and it made the logic convoluted, so
this change makes handling crashes completely separate from the
server_process code, so that it can focus on just I/O to the
subprocess.

There should be no functional changes resulting from this patch.

Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._reset):
(ServerProcess._handle_possible_interrupt):
(ServerProcess.write):
(ServerProcess.read_stdout):
(ServerProcess.has_crashed):
(ServerProcess._read):
(ServerProcess.stop):

Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.check_for_leaks):
(TestServerProcess.test_broken_pipe):

Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._read_image_diff):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
(WebKitDriver._read_block):

Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(MockServerProcess.init):
(MockServerProcess):
(MockServerProcess.has_crashed):

6:29 PM Changeset in webkit [111292] by timothy_horton@apple.com

2 edits
3 adds in trunk/LayoutTests

Unreviewed new mac baselines for fast/css/font-family-pictograph and fast/css/pseudo-first-line-border-width.

platform/mac/fast/css/font-family-pictograph-expected.png: Added.
platform/mac/fast/css/font-family-pictograph-expected.txt:
platform/mac/fast/css/pseudo-first-line-border-width-expected.png: Added.
platform/mac/fast/css/pseudo-first-line-border-width-expected.txt: Added.

6:28 PM Changeset in webkit [111291] by dpranke@chromium.org

4 edits in trunk/Tools

webkitpy: crashlog parsing is broken
https://bugs.webkit.org/show_bug.cgi?id=81586

Reviewed by Adam Barth.

Seeking on a file opened through codecs() appears to not work
correctly (at least on SL).

The code was more complicated than it needed to be, so I have
revamped it to just read a full crashlog at once and then look
for matches.

I have also added the ability to optionally propagate
errors back (which can be helpful to debug races when ReportCrash is
still running and you need to see that you couldn't open some
files, rather than just ignoring them).

Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.find_newest_log):
(CrashLogs._find_newest_log_darwin):

Scripts/webkitpy/common/system/crashlogs_unittest.py:

(CrashLogsTest.test_find_log_darwin):

6:28 PM Changeset in webkit [111290] by jberlin@webkit.org

2 edits in trunk/LayoutTests

fast/loader/window-properties-restored-from-page-cache.html timing out on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81609

Skip it to get the bots green.

platform/wk2/Skipped:

6:25 PM Changeset in webkit [111289] by dpranke@chromium.org

4 edits in trunk/Tools

webkitpy: clean up some port._filesystem references to not reference private members
https://bugs.webkit.org/show_bug.cgi?id=81595

Reviewed by Eric Seidel.

There should be no functional changes in this patch, just some
refactoring. Also, fixes a minor nit in write_image_diff_files(()

Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init):
(SingleTestRunner._run_compare_test):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._save_baseline_data):
(SingleTestRunner._handle_error):
(SingleTestRunner._run_reftest):

Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):
(TestResultWriter.init):
(TestResultWriter._make_output_directory):
(TestResultWriter.output_filename):
(TestResultWriter._output_testname):
(TestResultWriter.write_output_files):
(TestResultWriter.write_stderr):
(TestResultWriter.write_crash_report):
(TestResultWriter.create_text_diff_and_write_result):
(TestResultWriter.write_image_diff_files):
(copy_file):

Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:

(TestResultWriterTest.test_reftest_diff_image):

6:22 PM Changeset in webkit [111288] by dpranke@chromium.org

2 edits in trunk/Tools

webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
https://bugs.webkit.org/show_bug.cgi?id=81598

Reviewed by Eric Seidel.

"DumpRenderTree" shouldn't be hard-coded here, since some other
process may actually be crashing (WebKitTestRunner, WebProcess, etc.)

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations):

6:21 PM Changeset in webkit [111287] by dpranke@chromium.org

3 edits in trunk/Tools

webkitpy: allow instance data in TestFailure objects
https://bugs.webkit.org/show_bug.cgi?id=81580

Reviewed by Tony Chang.

Current TestFailures are basically enums, but it would be nice,
especially for crashes, if they contained the name and pid of
the process that crashed.

Scripts/webkitpy/layout_tests/models/test_failures.py:

(TestFailure.message):
(FailureTimeout.message):
(FailureCrash):
(FailureCrash.init):
(FailureCrash.message):
(FailureMissingResult.message):
(FailureTextMismatch.message):
(FailureMissingImageHash.message):
(FailureMissingImage.message):
(FailureImageHashMismatch.message):
(FailureImageHashIncorrect.message):
(FailureReftestMismatch.message):
(FailureReftestMismatchDidNotOccur.message):
(FailureReftestNoImagesGenerated.message):
(FailureMissingAudio.message):
(FailureAudioMismatch.message):

Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:

(TestFailuresTest.test_equals):
(TestFailuresTest):
(TestFailuresTest.test_crashes):

6:16 PM Changeset in webkit [111286] by jberlin@webkit.org

2 edits in trunk/LayoutTests

A bunch of jquery tests are timing out on the Lion Intel Debug WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81606

Skip them to get the bots green.

platform/wk2/Skipped:

6:13 PM Changeset in webkit [111285] by nduca@chromium.org

6 edits in trunk/Source/WebKit/chromium

[chromium] Stop deriving WebCompositor from WebCompositorInputHandler
https://bugs.webkit.org/show_bug.cgi?id=80586

Reviewed by Darin Fisher.

public/WebCompositor.h:

(WebKit):

public/WebCompositorInputHandler.h:

(WebCompositorInputHandler):

public/WebWidgetClient.h:

(WebWidgetClient):
(WebKit::WebWidgetClient::didActivateCompositor):

src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandler::fromIdentifier):

src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

6:06 PM Changeset in webkit [111284] by jberlin@webkit.org

3 edits in trunk/LayoutTests

A bunch of media tests time out on the Lion Intel Debug WebKit1 and WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81604

Skip them to get the bots green.

platform/mac/Skipped:
platform/wk2/Skipped:

6:02 PM Changeset in webkit [111283] by timothy_horton@apple.com

3 edits in trunk/LayoutTests

Unreviewed new mac baseline for compositing/repaint/become-overlay-composited-layer.html.

platform/mac/compositing/repaint/become-overlay-composited-layer-expected.png:
platform/mac/compositing/repaint/become-overlay-composited-layer-expected.txt:

5:53 PM Changeset in webkit [111282] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

Unreviewed skip of canvas/philip/tests/2d.path.arc.scale.1.html as an addition to http://trac.webkit.org/changeset/111278

platform/mac/Skipped:

5:47 PM Changeset in webkit [111281] by timothy_horton@apple.com

4 edits in trunk/LayoutTests

Unreviewed mac baselines for some fast/block tests after http://trac.webkit.org/changeset/97596

platform/mac/fast/block/float/float-in-float-hit-testing-expected.png:
platform/mac/fast/block/float/float-in-float-hit-testing-expected.txt:
platform/mac/fast/block/margin-collapse/056-expected.txt:

5:40 PM Changeset in webkit [111280] by jberlin@webkit.org

2 edits in trunk/LayoutTests

A bunch of inspector tests time out on Lion Intel Debug WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81601

Skip them on WK2 to get the bots green.

platform/wk2/Skipped:

5:37 PM Changeset in webkit [111279] by commit-queue@webkit.org

8 edits
2 adds in trunk

Relative-height block SVG root not layed out on container height change
https://bugs.webkit.org/show_bug.cgi?id=81513

Patch by Florin Malita <fmalita@google.com> on 2012-03-19
Reviewed by Dirk Schulze.

Source/WebCore:

Tests: svg/custom/svg-percent-scale-block-expected.html

svg/custom/svg-percent-scale-block.html

A couple of places still have style()->logical{Min,Max,}Height percent checks,
which do not work for SVG elements. This patch adds a virtual hasRelativeLogicalHeight()
RenderBox method to replace the explicit style checks.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChildren):
Use virtual hasRelativeLogicalHeight() instead of logical height style checks.

rendering/RenderBox.cpp:

(WebCore::RenderBox::hasRelativeLogicalHeight):
(WebCore):

rendering/RenderBox.h:

(RenderBox):
Add virtual hasRelativeLogicalHeight().

rendering/RenderView.cpp:

(WebCore::RenderView::layout):
Use virtual hasRelativeLogicalHeight() instead of logical height style checks, if possible.

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::hasRelativeLogicalHeight):
(WebCore):

rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):
Add hasRelativeLogicalHeight() override.

LayoutTests:

svg/custom/svg-percent-scale-block-expected.html: Added.
svg/custom/svg-percent-scale-block.html: Added.

5:33 PM Changeset in webkit [111278] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

Four fast/canvas tests are flaky (fail on bots, not locally, or vice versa)
https://bugs.webkit.org/show_bug.cgi?id=81599
<rdar://problem/11078302>

Unreviewed skip of four flaky tests:

fast/canvas/canvas-createPattern-fillRect-shadow.html
fast/canvas/canvas-draw-canvas-on-canvas-shadow.html
fast/canvas/canvas-fillRect-gradient-shadow.html
fast/canvas/set-colors.html

platform/mac/Skipped:

5:20 PM Changeset in webkit [111277] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Assertion failure in RenderBlock::addChildIgnoringAnonymousColumnBlocks when running fullscreen/full-screen-twice-crash.html
causing "crashes" on the Lion Intel Debug WebKit2 test bots.
https://bugs.webkit.org/show_bug.cgi?id=81171

Reviewed by Dan Bernstein.

No new tests; fixes fullscreen/* tests when running in WebKitTestRunner (WebKit2).

Add a special-case check if the parent anonymous container is a full screen renderer or placeholder.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

5:12 PM Changeset in webkit [111276] by enrica@apple.com

20 edits in trunk/Source

WebKit2: create sandbox extensions for files that are dropped in an input control.
https://bugs.webkit.org/show_bug.cgi?id=81153
<rdar://problem/11031207>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Now the pasteboard access is performed only in the UI process, it is
necessary to create sandbox extensions for each file that is dropped into
an input type=file element. The extensions are created at the time the files
are dropped and consumed immediately.

page/DragActions.h: Added new drag action to be used by the WebDragClient.
page/DragController.cpp:

(WebCore::DragController::concludeEditDrag): Added call to the drag client with the new action.

Source/WebKit/mac:

WebCoreSupport/WebDragClient.mm:

(WebDragClient::willPerformDragDestinationAction): Avoid calling the delegate with the new drag action.
We want to avoid any unwanted side effects for the WebKit clients.

Source/WebKit2:

Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction): Added template that takes 8 arguments.

Shared/SandboxExtension.h:

(HandleArray): Added new class to handle an array of sandbox extension handles.
(WebKit::SandboxExtension::HandleArray::HandleArray):
(WebKit::SandboxExtension::HandleArray::~HandleArray):
(WebKit::SandboxExtension::HandleArray::resize):
(WebKit::SandboxExtension::HandleArray::operator[]):
(WebKit::SandboxExtension::HandleArray::size):
(WebKit::SandboxExtension::HandleArray::encode):
(WebKit::SandboxExtension::HandleArray::decode):

Shared/mac/SandboxExtensionMac.mm: Added new class implementation.

(WebKit::SandboxExtension::HandleArray::HandleArray):
(WebKit::SandboxExtension::HandleArray::~HandleArray):
(WebKit::SandboxExtension::HandleArray::resize):
(WebKit::SandboxExtension::HandleArray::operator[]):
(WebKit::SandboxExtension::HandleArray::size):
(WebKit::SandboxExtension::HandleArray::encode):
(WebKit::SandboxExtension::HandleArray::decode):

UIProcess/API/mac/WKView.mm:

(createSandboxExtensionsForFileUpload):
(-[WKView performDragOperation:]): Added logic to create the sandbox extensions for each
file/directory being dropped.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDrag):
(WebKit::WebPageProxy::performDragControllerAction): Added the handle array parameter.

UIProcess/WebPageProxy.h:
UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleDropEvent):

UIProcess/API/gtk/WebKitWebViewBase.cpp:
UIProcess/win/WebView.cpp:

(WebKit::WebView::Drop):

WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit::WebDragClient::willPerformDragDestinationAction): Added handling of the new DragActionUpload.

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPathnamesForType): Implemented using message to the UI process.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::performUploadDragDestinationAction): Added method that consumes the received extensions.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

5:08 PM Changeset in webkit [111275] by eric@webkit.org

2 edits in trunk/Source/WebCore

Fix Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.

platform/graphics/chromium/TransparencyWin.h:

5:02 PM Changeset in webkit [111274] by eric@webkit.org

2 edits in trunk/Source/WebCore

Fix the chromium world.
https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.

rendering/RenderThemeChromiumSkia.cpp:

4:59 PM Changeset in webkit [111273] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG can no longer compile V8-v4/regexp in debug mode
https://bugs.webkit.org/show_bug.cgi?id=81592

Reviewed by Gavin Barraclough.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:59 PM Changeset in webkit [111272] by beidson@apple.com

6 edits
2 adds in trunk

<rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
Crash in 3rd party WebKit apps under XHR/Cache code

Reviewed by Antti Koivisto.

Source/WebCore:

No new layout tests.
TestWebKitAPI test MemoryCachePruneWithinResourceLoadDelegate included

A CachedResource representing an XHR was being deleted by cache pruning during a delegate callback.
This worked until http://trac.webkit.org/changeset/98380

history/PageCache.cpp:

(WebCore::PageCache::releaseAutoreleasedPagesNow): Only trigger pruning after the page cache

autorelease if it was enabled before.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::loadResource): Disable pruning before loading the resource and

re-enable it afterwards if necessary.

loader/cache/MemoryCache.h:

(WebCore::MemoryCache::pruneEnabled):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.

(-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
(-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
(-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

4:46 PM Changeset in webkit [111271] by andersca@apple.com

2 edits in trunk/Source/WebCore

Fix Windows build.

platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDeviceScaleFactor):

4:45 PM Changeset in webkit [111270] by jamesr@google.com

10 edits in trunk/Source

[chromium] Implement fling-by-wheel on compositor thread
https://bugs.webkit.org/show_bug.cgi?id=81462

Reviewed by Adrienne Walker.

Source/WebCore:

Adds compositor thread support for a fling type implemented as a sequence of wheel scrolls. Covered by new tests
in WebCompositorInputHandlerImplTests.

platform/graphics/chromium/cc/CCInputHandler.h:

(CCInputHandler):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::scheduleAnimation):
(WebCore):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):

Source/WebKit/chromium:

Implement fling-by-wheel and beef up existing unit test coverage considerably by using gmock instead of mocking
by hand.

src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
(WebKit):
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):

src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

tests/WebCompositorInputHandlerImplTest.cpp:

4:36 PM Changeset in webkit [111269] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Prediction propagation for UInt32ToNumber incorrectly assumes that outs outcome does not
change throughout the fixpoint
https://bugs.webkit.org/show_bug.cgi?id=81583

Reviewed by Michael Saboff.

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

4:33 PM Changeset in webkit [111268] by eae@chromium.org

11 edits in trunk/Source

Source/WebCore: [mac/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

Change platform code to use Node::getPixelSnappedRect,
pixelSnappedBoundingBoxRect and pixelSnappedAbsoluteClippedOverflowRect
to avoid exposing subpixel types to the platform layer.

No new tests.

WebCore.exp.in:
rendering/RenderObject.cpp:

(WebCore::RenderObject::pixelSnappedAbsoluteClippedOverflowRect):
Add pixelSnapped version of absoluteClippedOverflowRect

(WebCore):

rendering/RenderObject.h:

(RenderObject):

Source/WebKit/chromium: [mac/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::applyAutofillSuggestions):
(WebKit::WebViewImpl::refreshAutofillPopup):

Source/WebKit/mac: [mac/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView actualVisibleRectInWindow]):

WebView/WebFrame.mm:

(-[WebFrame _getVisibleRect:]):
(-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):

WebView/WebView.mm:

(-[WebView _dashboardRegions]):
(-[WebView trackedRepaintRects]):

Source/WebKit/qt: [mac/qt/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

Api/qwebelement.cpp:

(QWebElement::geometry):
(QWebElement::render):

4:20 PM Changeset in webkit [111267] by beidson@apple.com

4 edits
2 adds in trunk

<rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format

Reviewed by Enrica Casucci.

Source/WebCore:

r107435 started saving/restoring URLs as strings.
We need to go back to setting the URL on the pasteboard using AppKit URL pasteboard APIs.

WebKit API test: ContextMenuCanCopyURL
No WebKit2 API test possible at this time.

platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::setURL):

Tools:

Bring up a context menu on a link, copy the link, then verify the pasteboard contents
are in the correct format.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.

(-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::contextMenuCopyLink):
(TestWebKitAPI::TEST):

4:14 PM PythonGuidelines edited by kubo@profusion.mobi

Python 2.6 is now the minimum supported version, see bug 71593 (diff)

4:11 PM Changeset in webkit [111266] by andersca@apple.com

6 edits in trunk/Source/WebCore

Make the TileCache work with HiDPI again
https://bugs.webkit.org/show_bug.cgi?id=81569
<rdar://problem/11031542>

Reviewed by Sam Weinig.

Set the contentsScale of the individual tile layers to be the same as the device scale factor.
Also, take into account the fact that the value passed to TileCache::setScale is the product of the
page scale factor and the device scale factor, so divide it by the device scale factor before storing
it in m_scale.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerDeviceScaleFactor):
(WebCore):

platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

platform/graphics/ca/PlatformCALayerClient.h:

(PlatformCALayerClient):

platform/graphics/ca/mac/TileCache.h:

(TileCache):

platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):
(WebCore::TileCache::setScale):
(WebCore::TileCache::createTileLayer):

4:02 PM Changeset in webkit [111265] by jberlin@webkit.org

2 edits in trunk/LayoutTests

Shadow DOM is not enabled on Mac, so skip the whole directory instead of skipping the tests
one by one.

platform/mac/Skipped:

4:01 PM Changeset in webkit [111264] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

GC should not attempt to clear LLInt instruction inline caches for code blocks that are in
the process of being generated
https://bugs.webkit.org/show_bug.cgi?id=81565

Reviewed by Oliver Hunt.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):

3:53 PM Changeset in webkit [111263] by inferno@chromium.org

3 edits
2 adds in trunk

Crash due to layer tree information not updated when moving run-in children.
https://bugs.webkit.org/show_bug.cgi?id=81265

Reviewed by Julien Chaffraix.

Source/WebCore:

We need to do a full removal as the run-in child is getting inserted into
the neighbouring block and |blockRunIn| is going to be destroyed later
in the function.

Test: fast/runin/run-in-layer-not-removed-crash.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::handleRunInChild):

LayoutTests:

fast/runin/run-in-layer-not-removed-crash-expected.txt: Added.
fast/runin/run-in-layer-not-removed-crash.html: Added.

3:52 PM Changeset in webkit [111262] by ojan@chromium.org

3 edits in trunk/Tools

Make the selected item in the accordion a link to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=81571

Reviewed by Dimitri Glazkov.

Also, make it so that you can select the text of the link, instead of the current behavior
of acting as if you had clicked on the accordion header.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

3:42 PM Changeset in webkit [111261] by dpranke@chromium.org

3 edits in trunk/Tools

NRWT runs some tests that are skipped with -i command line option
https://bugs.webkit.org/show_bug.cgi?id=81535

Reviewed by Ojan Vafai.

This change modifies the interaction of Skipped files and
test_expectations files so that entries in Skipped files (and
the -i command line) override *everything* in the expectations
file.

Specifically, a directory in a Skipped file will cause all of
the tests in the dir to be skipped even if individual tests in
the dir are listed in the test_expectations.txt.

Skipped files also override anything in an overrides files.

This seems to make more intuitive sense, since if you list
something in the Skips file (and even more specify it on the
command line) you probably want it to be universally applied.

Theoretically we could add more precedence levels and have full
paths in an expectations file override dirs in a Skipped file
(but not the command line), but I don't know yet that that level
of complexity is justified.

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):
(TestExpectations._add_skipped_tests):
(TestExpectations._add_test):
(TestExpectations._add_expectations):
(TestExpectations._add_expectation_line):
(TestExpectations._already_seen_better_match):

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_more_specific_override_resets_skip):
(SkippedTests):
(SkippedTests.get_exp):
(SkippedTests.assert_exp):
(SkippedTests.test_skipped_tests_work):
(SkippedTests.test_duplicate_skipped_test_fails_lint):
(SkippedTests.test_skipped_file_overrides_expectations):
(SkippedTests.test_skipped_dir_overrides_expectations):
(SkippedTests.test_skipped_file_overrides_overrides):
(SkippedTests.test_skipped_dir_overrides_overrides):

3:27 PM Changeset in webkit [111260] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] Remove misleading double-if
https://bugs.webkit.org/show_bug.cgi?id=81557

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Simple code cleanup, no functionality change.

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):

3:17 PM Changeset in webkit [111259] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] speed up text selection for large selections
https://bugs.webkit.org/show_bug.cgi?id=81536

When selecting large disjoint areas of text the cost
of calculating the IntRectRegion union becomes very
expensive. Simply placing all of the text quads into
the IntRectRegion is faster despite the larger memory
footprint and the additional calculations at render
time.

Patch by Tyler Abbott <tabbott@rim.com> on 2012-03-19
Reviewed by Rob Buis.

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):

3:16 PM Changeset in webkit [111258] by eric@webkit.org

79 edits in trunk

Fix WTF header include discipline in Chromium WebKit
https://bugs.webkit.org/show_bug.cgi?id=81281

Reviewed by James Robinson.

Source/JavaScriptCore:

JavaScriptCore.gyp/JavaScriptCore.gyp:
wtf/unicode/icu/CollatorICU.cpp:

Source/WebCore:

I also fixed some bad include dicipline for other ports
as well. Those changes are not yet necessary for those ports
to keep building, but soon should be as those authors
remove all the extra WTF includes from WebCore and other non-WTF projects.

Modules/indexeddb/IDBLevelDBBackingStore.cpp:
bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
bindings/scripts/test/ObjC/DOMFloat64Array.mm:
bindings/v8/NPV8Object.cpp:
bindings/v8/SerializedScriptValue.cpp:
bindings/v8/SerializedScriptValue.h:
bindings/v8/V8Binding.cpp:
bindings/v8/V8Binding.h:
bindings/v8/V8DOMWrapper.cpp:
bindings/v8/V8Utilities.cpp:
bindings/v8/custom/V8ArrayBufferCustom.cpp:
bindings/v8/custom/V8ArrayBufferViewCustom.h:
bindings/v8/custom/V8AudioContextCustom.cpp:
bindings/v8/custom/V8DOMWindowCustom.cpp:
bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
bindings/v8/custom/V8Float32ArrayCustom.cpp:
bindings/v8/custom/V8Float64ArrayCustom.cpp:
bindings/v8/custom/V8Int16ArrayCustom.cpp:
bindings/v8/custom/V8Int32ArrayCustom.cpp:
bindings/v8/custom/V8Int8ArrayCustom.cpp:
bindings/v8/custom/V8MessagePortCustom.cpp:
bindings/v8/custom/V8Uint16ArrayCustom.cpp:
bindings/v8/custom/V8Uint32ArrayCustom.cpp:
bindings/v8/custom/V8Uint8ArrayCustom.cpp:
bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
bindings/v8/custom/V8WorkerCustom.cpp:
bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
bridge/qt/qt_runtime.cpp:
editing/gtk/FrameSelectionGtk.cpp:
loader/archive/mhtml/MHTMLArchive.cpp:
platform/ScrollAnimatorNone.cpp:
platform/blackberry/CookieMap.h:
platform/blackberry/CookieParser.h:
platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
platform/chromium/DragImageChromiumSkia.cpp:
platform/chromium/PlatformCursor.h:
platform/chromium/PlatformSupport.h:
platform/chromium/PopupMenuPrivate.h:
platform/chromium/TraceEvent.h:
platform/chromium/WidgetChromium.cpp:
platform/efl/RefPtrEfl.h:
platform/graphics/cairo/RefPtrCairo.h:
platform/graphics/chromium/RateLimiter.h:
platform/graphics/chromium/TiledLayerChromium.cpp:
platform/graphics/efl/IconEfl.cpp:
platform/graphics/gstreamer/GStreamerGWorld.h:
platform/graphics/gtk/IconGtk.cpp:
platform/graphics/skia/PlatformContextSkia.h:
platform/graphics/texmap/TextureMapperBackingStore.h:
platform/graphics/texmap/TextureMapperLayer.cpp:
platform/graphics/wx/TransformationMatrixWx.cpp:
platform/gtk/PlatformMouseEventGtk.cpp:
platform/leveldb/LevelDBSlice.h:
platform/mediastream/MediaStreamCenter.cpp:
platform/network/soup/SocketStreamHandleSoup.cpp:
platform/network/win/ResourceHandleWin.cpp:
platform/qt/RenderThemeQtMobile.cpp:
platform/wx/MouseEventWx.cpp:
platform/wx/wxcode/win/fontprops.cpp:

Source/WebKit/chromium:

src/CompositionUnderlineBuilder.h:
src/CompositionUnderlineVectorBuilder.h:
src/FrameLoaderClientImpl.cpp:
src/WebArrayBuffer.cpp:
src/WebArrayBufferView.cpp:
src/WebBindings.cpp:
src/WebColorName.cpp:
src/WebGeolocationClientMock.cpp:
src/WebPageSerializer.cpp:
src/WebSocketImpl.cpp:
src/WebViewImpl.cpp:
tests/FrameTestHelpers.cpp:

Tools:

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.

3:03 PM Changeset in webkit [111257] by Lucas Forschler

8 edits in branches/safari-534.55-branch/Source/JavaScriptCore

Merged r111162.

3:03 PM Changeset in webkit [111256] by commit-queue@webkit.org

4 edits
5 adds in trunk

[BlackBerry] Add new layout test for text match marker
https://bugs.webkit.org/show_bug.cgi?id=81531

Tools:

Make the LayoutTestControllerBlackBerry::findString to test the
BlackBerry port implementation.

Patch by Andy Chen <andchen@rim.com> on 2012-03-19
Reviewed by Rob Buis.

DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::findString):

LayoutTests:

Patch by Andy Chen <andchen@rim.com> on 2012-03-19
Reviewed by Rob Buis.

Add a new layout test for text match marker for BlackBerry port

platform/blackberry/editing/text-iterator/findString-markers-expected.txt: Added.
platform/blackberry/editing/text-iterator/findString-markers.html: Added.

2:54 PM Changeset in webkit [111255] by jberlin@webkit.org

3 edits in trunk/LayoutTests

r109204 updated the chromium expected results for
inspector/timeline/timeline-animation-frame.html and timeline-paint.html, but did not update
the cross-platform results.

Update the cross-platform results.

inspector/timeline/timeline-animation-frame-expected.txt:
inspector/timeline/timeline-paint-expected.txt:

2:44 PM Changeset in webkit [111254] by fpizlo@apple.com

17 edits
2 moves in trunk/Source/JavaScriptCore

DFG NodeUse should be called Edge and NodeReferenceBlob should be called AdjacencyList
https://bugs.webkit.org/show_bug.cgi?id=81556

Rubber stamped by Gavin Barraclough.

GNUmakefile.list.am:
JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::forNode):

dfg/DFGAdjacencyList.h: Copied from Source/JavaScriptCore/dfg/DFGNodeReferenceBlob.h.

(JSC::DFG::AdjacencyList::AdjacencyList):
(JSC::DFG::AdjacencyList::child):
(JSC::DFG::AdjacencyList::setChild):
(JSC::DFG::AdjacencyList::child1):
(JSC::DFG::AdjacencyList::child2):
(JSC::DFG::AdjacencyList::child3):
(JSC::DFG::AdjacencyList::setChild1):
(JSC::DFG::AdjacencyList::setChild2):
(JSC::DFG::AdjacencyList::setChild3):
(JSC::DFG::AdjacencyList::child1Unchecked):
(JSC::DFG::AdjacencyList::initialize):
(AdjacencyList):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::performSubstitution):

dfg/DFGEdge.h: Copied from Source/JavaScriptCore/dfg/DFGNodeUse.h.

(DFG):
(JSC::DFG::Edge::Edge):
(JSC::DFG::Edge::operator==):
(JSC::DFG::Edge::operator!=):
(Edge):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):

dfg/DFGGraph.h:

(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):
(Graph):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getPrediction):

dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(Node):

dfg/DFGNodeFlags.cpp:

(JSC::DFG::arithNodeFlagsAsString):

dfg/DFGNodeFlags.h:

(DFG):
(JSC::DFG::nodeUsedAsNumber):

dfg/DFGNodeReferenceBlob.h: Removed.
dfg/DFGNodeUse.h: Removed.
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

dfg/DFGSpeculativeJIT64.cpp:

2:37 PM Changeset in webkit [111253] by commit-queue@webkit.org

4 edits in trunk/Source

[chromium] Invalidate/update evicted tiles during commit
https://bugs.webkit.org/show_bug.cgi?id=81529

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/WebCore:

A previous change caused a regression where evicted (invalid) tiles
were no longer marked as dirty and updated. The regress was caused
in https://bugs.webkit.org/show_bug.cgi?id=81175 and is fixed here.

Unit test: TiledLayerChromiumTest.pushDeletedTiles

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::copyAndClearDirty):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

Source/WebKit/chromium:

tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

2:36 PM Changeset in webkit [111252] by eae@chromium.org

5 edits in branches/subpixellayout/Source/WebCore

Revert unnecessary changes on branch.

2:35 PM Changeset in webkit [111251] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Remove PLATFORM(TORCHMOBILE) ifdef from MainResourceLoader.cpp
https://bugs.webkit.org/show_bug.cgi?id=81549

Reviewed by Eric Seidel.

This appears to be the only PLATFORM(TORCHMOBILE) ifdef in WebCore. I
don't believe this ifdef is needed anymore.

loader/MainResourceLoader.cpp:

(WebCore::shouldLoadAsEmptyDocument):
(WebCore):

2:34 PM Changeset in webkit [111250] by barraclough@apple.com

6 edits in trunk

Object.freeze broken on latest Nightly
https://bugs.webkit.org/show_bug.cgi?id=80577

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

runtime/Arguments.cpp:

(JSC::Arguments::defineOwnProperty):

defineOwnProperty was checking for correct behaviour, provided that length/callee hadn't been overrridden. instead, just reify length/callee & rely on JSObject::defineOwnProperty.

runtime/JSFunction.cpp:

(JSC::JSFunction::defineOwnProperty):

for arguments/caller/length properties, defineOwnProperty was incorrectly asserting that the object must be extensible; this is incorrect since these properties should already exist on the object. In addition, it was asserting that the arguments/caller values must match the corresponding magic data properties, but for strict mode function this is incorrect. Instead, just reify the arguments/caller accessor & defer to JSObject::defineOwnProperty.

LayoutTests:

fast/js/preventExtensions-expected.txt:
fast/js/script-tests/preventExtensions.js:

(shouldBeTrue):
(shouldBeFalse.shouldBeFalse.preventExtensionsFreezeIsFrozen):

Added test cases.

2:30 PM Changeset in webkit [111249] by commit-queue@webkit.org

9 edits in trunk/Source

Unreviewed, rolling out r111207.
http://trac.webkit.org/changeset/111207
https://bugs.webkit.org/show_bug.cgi?id=81561

Causing chromium unit test failure (Requested by reveman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-19

Source/Platform:

chromium/public/WebGraphicsContext3D.h:

Source/WebCore:

platform/graphics/chromium/Extensions3DChromium.h:

(Extensions3DChromium):

Source/WebKit/chromium:

src/Extensions3DChromium.cpp:
src/GraphicsContext3DChromium.cpp:

(WebCore):

src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

tests/FakeWebGraphicsContext3D.h:

2:30 PM Changeset in webkit [111248] by Lucas Forschler

5 edits in branches/safari-534.55-branch/Source

Versioning.

2:27 PM Changeset in webkit [111247] by tommyw@google.com

2 edits
4 adds in trunk/Source/WebKit/chromium

[chromium] MediaStream API (JSEP): Introducing WebMediaHints and WebIceOptions
https://bugs.webkit.org/show_bug.cgi?id=81341

Reviewed by Darin Fisher.

Simple WebKit representations of the WebCore/platform versions.

WebKit.gyp:
public/platform/WebICEOptions.h: Added.

(WebCore):
(WebKit):
(WebICEOptions):
(WebKit::WebICEOptions::WebICEOptions):
(WebKit::WebICEOptions::~WebICEOptions):
(WebKit::WebICEOptions::operator=):
(WebKit::WebICEOptions::isNull):

public/platform/WebMediaHints.h: Added.

(WebCore):
(WebKit):
(WebMediaHints):
(WebKit::WebMediaHints::WebMediaHints):
(WebKit::WebMediaHints::~WebMediaHints):
(WebKit::WebMediaHints::operator=):
(WebKit::WebMediaHints::isNull):

src/WebICEOptions.cpp: Added.

(WebKit):
(WebKit::WebICEOptions::WebICEOptions):
(WebKit::WebICEOptions::assign):
(WebKit::WebICEOptions::reset):
(WebKit::WebICEOptions::candidateTypeToUse):

src/WebMediaHints.cpp: Added.

(WebKit):
(WebKit::WebMediaHints::WebMediaHints):
(WebKit::WebMediaHints::assign):
(WebKit::WebMediaHints::reset):
(WebKit::WebMediaHints::audio):
(WebKit::WebMediaHints::video):

2:26 PM Changeset in webkit [111246] by jberlin@webkit.org

2 edits in trunk/LayoutTests

NPRuntime support for out-of-process plug-ins.
https://bugs.webkit.org/show_bug.cgi?id=48346

This issue was marked as fixed on 2011-01-11, but the tests that required that support were
never taken off the WK2 Skipped list.

Update the WK2 Skipped list to not skip the passing tests, and move the ones that still fail
to a separate section of the list.

platform/wk2/Skipped:

2:24 PM Changeset in webkit [111245] by andersca@apple.com

3 edits in trunk/Source/WebCore

Remove unnecessary CALayer overrides from WebTileCacheLayer
https://bugs.webkit.org/show_bug.cgi?id=81562

Reviewed by Dan Bernstein.

platform/graphics/ca/mac/TileCache.h:

(TileCache):

platform/graphics/ca/mac/WebTileCacheLayer.mm:

2:18 PM Changeset in webkit [111244] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

LLInt get_by_pname slow path incorrectly assumes that the operands are not constants
https://bugs.webkit.org/show_bug.cgi?id=81559

Reviewed by Michael Saboff.

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

2:05 PM Changeset in webkit [111243] by eae@chromium.org

8 edits in trunk/Source/WebCore

Correct usage of LayoutUnits in page code in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=81538

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and conversions between types in page code.

No new tests.

page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
Explicitly cast long to int. InspectorInstrumentation requires a long and
FractionalLayoutUnit has no constructor that takes long.

page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):
Pixel snap overflow rect as selection rects are integer based.

page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):
Pixel snap repaint rects when computing update rect as all scrolling is
done on integer bounds.

page/GestureTapHighlighter.cpp:

Change rects vector to IntRect as addFocusRingRects operates on IntRects.

page/Page.cpp:

(WebCore::Page::addRelevantRepaintedObject):
(WebCore::Page::addRelevantUnpaintedObject):
Change paint methods to take a LayoutRect paint rect.

page/SpatialNavigation.cpp:

(WebCore::distanceDataForNode):
Change distance calculation to use floats instead of converting to float
at the end.

2:02 PM Changeset in webkit [111242] by Lucas Forschler

2 edits in branches/safari-534.55-branch/Source/JavaScriptCore

Merged r110818.

2:00 PM Changeset in webkit [111241] by ojan@chromium.org

3 edits in trunk/Tools

Don't show WONTFIX tests in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=81554

Reviewed by Dimitri Glazkov.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:

1:59 PM Changeset in webkit [111240] by hyatt@apple.com

6 edits
4 adds in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=81553

[New Multicolumn] Stub out classes to represent sets of column region boxes.

RenderRegionSet is an abstract class representing a set of contiguous anonymous
same-size regions.

RenderMultiColumnSet derives from RenderRegionSet and represents a set of contiguous
columns. It will also handle unique column behavior like column rule painting.

Eventually there will be a RenderPageSet derived class for printing/pages, but
that will come later after I finish rebuilding multi-column layout.

Reviewed by Dan Bernstein.

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
rendering/RenderMultiColumnSet.cpp: Added.

(WebCore):
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::renderName):

rendering/RenderMultiColumnSet.h: Added.

(WebCore):
(RenderMultiColumnSet):

rendering/RenderRegionSet.cpp: Added.

(WebCore):
(WebCore::RenderRegionSet::RenderRegionSet):

rendering/RenderRegionSet.h: Added.

(WebCore):
(RenderRegionSet):

1:54 PM Changeset in webkit [111239] by commit-queue@webkit.org

8 edits
2 adds in trunk

Add playback state for AudioBufferSourceNode and add number of active nodes
https://bugs.webkit.org/show_bug.cgi?id=79701

Source/WebCore:

Add a playback state to AudioBufferSourceNode so that the user can
tell if the node is scheduled, playing, or finished.

For an AudioContext, add a count of the number of
AudioBufferSourceNode's that are active (playing audio).

Deleted m_isPlaying and m_hasFinished. For the record, m_isPlaying
is the same as a playbackState of SCHEDULED_STATE or PLAYING_STATE.
m_hasFinished is equivalent to a playbackState of FINISHED_STATE.

Patch by Raymond Toy <Raymond Toy> on 2012-03-19
Reviewed by Chris Rogers.

Test: webaudio/audiobuffersource-playbackState.html

webaudio/AudioBufferSourceNode.cpp:

(WebCore):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
initialize playbackState, remove m_isPlaying, m_hasFinished.
(WebCore::AudioBufferSourceNode::process): Update playbackState
(WebCore::AudioBufferSourceNode::finish): Update playbackState
(WebCore::AudioBufferSourceNode::noteOn): Update playbackState
(WebCore::AudioBufferSourceNode::noteGrainOn): Update playbackState
(WebCore::AudioBufferSourceNode::noteOff): Use playbackState

webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode): Define states, remove m_isPlaying, m_hasFinished.
(WebCore::AudioBufferSourceNode::playbackState): Added.

webaudio/AudioBufferSourceNode.idl: Define constants for the

playback state, add attribute playbackState.

webaudio/AudioContext.cpp:

(WebCore::AudioContext::activeSourceCount): Added.
(WebCore::AudioContext::incrementActiveSourceCount): Added.
(WebCore::AudioContext::decrementActiveSourceCount): Added.

webaudio/AudioContext.h:

(AudioContext):

webaudio/AudioContext.idl: Add attribute activeSourceCount.

LayoutTests:

Patch by Raymond Toy <Raymond Toy> on 2012-03-19
Reviewed by Chris Rogers.

webaudio/audiobuffersource-playbackState-expected.txt: Added.
webaudio/audiobuffersource-playbackState.html: Added.

1:43 PM Changeset in webkit [111238] by Lucas Forschler

1 copy in branches/safari-534.55-branch

New Branch.

1:43 PM Changeset in webkit [111237] by commit-queue@webkit.org

3 edits
2 deletes in trunk

Unreviewed, rolling out r109014.
http://trac.webkit.org/changeset/109014
https://bugs.webkit.org/show_bug.cgi?id=81551

Causing crashes (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-19

Source/WebCore:

rendering/style/RenderStyle.h:

LayoutTests:

css3/flexbox/inline-flexbox-expected.html: Removed.
css3/flexbox/inline-flexbox.html: Removed.

1:43 PM Changeset in webkit [111236] by Lucas Forschler

2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Rollout 110818.

1:41 PM Changeset in webkit [111235] by ap@apple.com

2 edits in trunk/Source/WebKit2

Make WebFrameLoaderClient::createFrame more like WebKit1 version.
https://bugs.webkit.org/show_bug.cgi?id=81550

Covered by existing tests.

Reviewed by Jessie Berlin.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createFrame):

1:39 PM Changeset in webkit [111234] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[BlackBerry] Implement OSAllocator::commit/decommit in the correct way
https://bugs.webkit.org/show_bug.cgi?id=77013

We should use mmap(PROT_NONE, MAP_LAZY) instead of posix_madvise() to
implement memory decommitting for QNX.

Patch by Yong Li <yoli@rim.com> on 2012-03-19
Reviewed by Rob Buis.

wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):

1:29 PM Changeset in webkit [111233] by Chris Fleizach

6 edits
1 delete in trunk

platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81530

Reviewed by Jessie Berlin.

Tools:

Add rowAtIndex to WebKitTestRunner.

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::rowAtIndex):

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR):
(WTR::AccessibilityUIElement::rowAtIndex):

LayoutTests:

platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt: Removed.

1:28 PM Changeset in webkit [111232] by jberlin@webkit.org

2 edits in trunk/LayoutTests

editing/input/reveal-edit-on-input-vertically.html and
editing/input/reveal-contenteditable-on-input-vertically.html timing out on Lion Intel Debug
WebKit2 testers

Add those tests to the WK2 Skipped list.

platform/wk2/Skipped:

1:26 PM Changeset in webkit [111231] by tony@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed, remove headers that no longer exist or moved in WebCore.gypi.

WebCore.gypi:

1:24 PM Changeset in webkit [111230] by eae@chromium.org

5 edits in branches/subpixellayout/Source/WebCore

Fix type conversions on branch to match trunk.

1:24 PM Changeset in webkit [111229] by mihnea@adobe.com

9 edits
2 adds in trunk

[CSSRegions]Implement NamedFlow::contentNodes attribute
https://bugs.webkit.org/show_bug.cgi?id=80134

Reviewed by David Hyatt.

The named flow content nodes collection contains those nodes with webkitFlowInto property set to 'flow'.
In the list, the nodes are placed in document order. Nodes with display:none are also part of the list.
The list of nodes is returned as a static node list.

Source/WebCore:

Test: fast/regions/webkit-named-flow-content-nodes.html

dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):

dom/Document.h:
dom/Element.cpp:

(WebCore::Element::detach):

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::contentNodes):
(WebCore):
(WebCore::WebKitNamedFlow::registerContentNode):

dom/WebKitNamedFlow.h:

(WebCore):
(WebKitNamedFlow):
(WebCore::WebKitNamedFlow::unregisterContentNode):

dom/WebKitNamedFlow.idl:

LayoutTests:

fast/regions/webkit-named-flow-content-nodes-expected.txt: Added.
fast/regions/webkit-named-flow-content-nodes.html: Added.

1:23 PM Changeset in webkit [111228] by ojan@chromium.org

11 edits in trunk/Tools

Change garden-o-matic All Failures tab to Expected Failures
https://bugs.webkit.org/show_bug.cgi?id=81540

Reviewed by Dimitri Glazkov.

Also, fix some broken unittests that had just gotten stale.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:

1:19 PM Changeset in webkit [111227] by commit-queue@webkit.org

12 edits
2 adds in trunk

ConvolverNode should not incur processing latency
https://bugs.webkit.org/show_bug.cgi?id=75564

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-19
Reviewed by Chris Rogers.

Source/WebCore:

Add the DirectConvolver instead of FFTConvolver for the processing of the leading portion of impulse response.

WebCore.gypi:
platform/audio/DirectConvolver.cpp: Added.

(WebCore):
(WebCore::DirectConvolver::DirectConvolver):
(WebCore::DirectConvolver::process):
(WebCore::DirectConvolver::reset):

platform/audio/DirectConvolver.h: Added.

(WebCore):
(DirectConvolver):
(WebCore::DirectConvolver::convolveSize):

platform/audio/ReverbConvolver.cpp:

(WebCore::ReverbConvolver::ReverbConvolver):

platform/audio/ReverbConvolver.h:
platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):
(WebCore::ReverbConvolverStage::process):
(WebCore::ReverbConvolverStage::reset):

platform/audio/ReverbConvolverStage.h:

(WebCore):
(ReverbConvolverStage):

LayoutTests:

No need to check the initial silent part because the latency issue of ConvolverNode is fixed.

webaudio/convolution-mono-mono-expected.txt:
webaudio/resources/convolution-testing.js:

(checkTriangularPulse):
(checkTail1):
(checkConvolvedResult.return.var):
(checkConvolvedResult):

1:13 PM Changeset in webkit [111226] by andersca@apple.com

6 edits in trunk/Source

Source/WebCore: Find in page highlights get out of place when scrolling
https://bugs.webkit.org/show_bug.cgi?id=81543

Reviewed by Sam Weinig.

Remove a now unused function from GraphicsLayer.

platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

Source/WebKit2: Find in page highlights get out of place when scrolling
https://bugs.webkit.org/show_bug.cgi?id=81543
<rdar://problem/10932590>

Reviewed by Sam Weinig.

When we have a page overlay layer, always force a full repaint of it whenever the page changes.
If this turns out to be a real performance problem (measurements suggest that it isn't), we could once
again try to figure out when a full page repaint is needed. Doing so could probably be more expensive than
simply repainting the page, given that a page overlay consists of a bunch of rect-fills mostly.

Also turn on accelerated drawing for the page overlay layer, since that cut CPU usage in half when scrolling
on a page that had a find overlay visible.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

1:12 PM Changeset in webkit [111225] by jsbell@chromium.org

16 edits in trunk/LayoutTests

IndexedDB: Test cleanup - don't create transactions w/in transaction callback
https://bugs.webkit.org/show_bug.cgi?id=81532

The spec precludes creating transactions within a synchronous transaction callback;
for the current implementation, that's only the success callback for a setVersion()
call. This isn't enforced yet - see http://webkit.org/b/80547

Reviewed by Tony Chang.

storage/indexeddb/create-and-remove-object-store.html: Split out oncomplete handler.
storage/indexeddb/create-object-store-options.html: Split out oncomplete handler.
storage/indexeddb/factory-deletedatabase.html: Listen on complete event.
storage/indexeddb/mozilla/autoincrement-indexes.html: Split out oncomplete handler.
storage/indexeddb/mozilla/clear.html: Listen on complete event.
storage/indexeddb/mozilla/indexes.html: Split out oncomplete handler.
storage/indexeddb/mozilla/readonly-transactions.html: Split out oncomplete handler.
storage/indexeddb/mozilla/readwrite-transactions.html: Split out oncomplete handler.
storage/indexeddb/noblobs.html: Pass function reference, don't call function.
storage/indexeddb/objectstore-clear.html: Split out oncomplete handler.
storage/indexeddb/objectstore-removeobjectstore.html: Listen on complete event.
storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html: Split out oncomplete handler.
storage/indexeddb/transaction-abort-with-js-recursion.html: Split out oncomplete handler.
storage/indexeddb/transaction-crash-on-abort.html: Split out oncomplete handler.
storage/indexeddb/two-version-changes.html: Split out oncomplete handler.

1:09 PM Changeset in webkit [111224] by leviw@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Marking fast/text/international/font-fallback-to-common-script.html as flaky for image
tests on all flavors of Chromium.

platform/chromium/test_expectations.txt:

12:59 PM Changeset in webkit [111223] by barraclough@apple.com

3 edits in trunk/Source/JavaScriptCore

Unreviewed - revent a couple of files accidentally committed.

runtime/Arguments.cpp:

(JSC::Arguments::defineOwnProperty):

runtime/JSFunction.cpp:

(JSC::JSFunction::defineOwnProperty):

12:58 PM Changeset in webkit [111222] by leviw@chromium.org

2 edits in trunk/LayoutTests

Marking css3/images/cross-fade-invalidation.html as flaky for image tests on Chromium Snowleopard.

platform/chromium/test_expectations.txt:

12:49 PM Changeset in webkit [111221] by jberlin@webkit.org

2 edits in trunk/LayoutTests

r98413 updated the platform/mac-wk2/plugins/contents-scale-factor test without updating the
expected results.

Update the expected results.

platform/mac-wk2/plugins/contents-scale-factor-expected.txt:

12:46 PM Changeset in webkit [111220] by commit-queue@webkit.org

3 edits in trunk/Tools

[chromium] DRT crashes at shutdown.
https://bugs.webkit.org/show_bug.cgi?id=81504

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-03-19
Reviewed by James Robinson.

WebCompositor must be destroyed after WebView is properly destroyed,
or some compositor objects like CCLayerTreeHost may not be destroyed.
However, it is really hard to make the destruction order correct
explicitly in ~TestShell. So move it out to DumpRenderTree.

DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::~TestShell):

12:43 PM Changeset in webkit [111219] by andersca@apple.com

2 edits in trunk/Source/WebKit2

When Find overlay first appears and the page scrolls, the scrolling happens through a fade
https://bugs.webkit.org/show_bug.cgi?id=81539
<rdar://problem/11031093>

Reviewed by Dan Bernstein.

Disable implicit animations when adding the page overlay layer to its superlayer.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

12:41 PM Changeset in webkit [111218] by leviw@chromium.org

2 edits in trunk/LayoutTests

[chromium] fast/events/touch/gesture/pad-gesture-fling.html fails on release builds
https://bugs.webkit.org/show_bug.cgi?id=81537

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19

platform/chromium/test_expectations.txt:

12:28 PM Changeset in webkit [111217] by hyatt@apple.com

5 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=81534

[New Multicolumn] Make the multi-column block re-layout its children when the column width/count change.
Cache the count/width on the multi-column block for easy access.

Reviewed by Antti Koivisto.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::recomputeLogicalWidth):
(WebCore::RenderBlock::layoutBlock):

rendering/RenderBlock.h:

Virtualize the code that recomputes the logical width for a block and sets relayoutChildren to true,
so that column code can subclass the method to also check for changes in the column width/count.

rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::computeColumnCountAndWidth):
The column count/width determination algorithm in one method on the RenderMultiColumnBlock. It's a copy
of the code from RenderBlock (which will be going away eventually).

(WebCore::RenderMultiColumnBlock::recomputeLogicalWidth):

rendering/RenderMultiColumnBlock.h:

(RenderMultiColumnBlock):
Subclassed method to also check for changes in the column width to set relayoutChildren to true.

12:19 PM Changeset in webkit [111216] by commit-queue@webkit.org

6 edits
1 add in trunk/Source

[chromium] Updating WebGraphicsContext3D MemoryAllocation callback to accept a struct with have backbuffer suggestion.
https://bugs.webkit.org/show_bug.cgi?id=81279

Patch by Michal Mocny <mmocny@google.com> on 2012-03-19
Reviewed by James Robinson.

Source/Platform:

Adding a suggestHaveBackbuffer hint to the WebGraphicsContext3D memory allocation callback.

chromium/public/WebGraphicsContext3D.h:

(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::onMemoryAllocationChanged):

chromium/public/WebGraphicsMemoryAllocation.h: Added.

(WebKit):
(WebGraphicsMemoryAllocation):
(WebKit::WebGraphicsMemoryAllocation::WebGraphicsMemoryAllocation):

Source/WebCore:

platform/graphics/chromium/Extensions3DChromium.h:

(GpuMemoryAllocationCHROMIUM):
(WebCore::Extensions3DChromium::GpuMemoryAllocationCHROMIUM::GpuMemoryAllocationCHROMIUM):
(GpuMemoryAllocationChangedCallbackCHROMIUM):

Source/WebKit/chromium:

src/GraphicsContext3DChromium.cpp:

(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):

12:14 PM Changeset in webkit [111215] by dpranke@chromium.org

2 edits in trunk/Tools

add dpranke to webkitpy watchlist
https://bugs.webkit.org/show_bug.cgi?id=81433

Reviewed by Benjamin Poulain.

Scripts/webkitpy/common/config/watchlist:

12:11 PM Changeset in webkit [111214] by tony@chromium.org

9 edits in trunk

flex-item-align: stretch should only grow, never shrink
https://bugs.webkit.org/show_bug.cgi?id=80882

Reviewed by Ojan Vafai.

Source/WebCore:

New test cases in css3/flexbox/flex-align-stretch.html.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren): Move stretch code into a separate function.
(WebCore::RenderFlexibleBox::alignChildStretch): Add an early return if our height is shrinking.
(WebCore):

rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

css3/flexbox/child-overflow-expected.html:
css3/flexbox/child-overflow.html: For cases that overflow the height, we now just overflow rather than reducing the height.
css3/flexbox/flex-align-stretch-expected.txt:
css3/flexbox/flex-align-stretch.html: New test cases.
platform/chromium/test_expectations.txt: Mark as failing on Windows

because of mock scrollbar rendering bug.

12:08 PM Changeset in webkit [111213] by dpranke@chromium.org

2 edits in trunk/Tools

test-webkitpy is failing on SL/Python 2.6.1
https://bugs.webkit.org/show_bug.cgi?id=81533

Reviewed by Ojan Vafai.

It appears that itertools.combinations() is buggy in 2.6.1; this
backports the implementation from 2.7.

Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.collapse_macros):
(TestConfigurationConverter):
(TestConfigurationConverter.combinations):

12:02 PM Changeset in webkit [111212] by vsevik@chromium.org

9 edits in trunk

Web Inspector: Implement snippets evaluation.
https://bugs.webkit.org/show_bug.cgi?id=81334

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evaluateUsingTextPrompt):
(WebInspector.ConsoleView.prototype._enterKeyPressed):

inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):

inspector/front-end/SnippetsModel.js:
inspector/front-end/externs.js:

(WebInspector.evaluateInConsole):

inspector/front-end/inspector.js:

(WebInspector.evaluateInConsole):

LayoutTests:

inspector/debugger/snippets-model-expected.txt:
inspector/debugger/snippets-model.html:

11:39 AM Changeset in webkit [111211] by jsbell@chromium.org

139 edits in trunk/LayoutTests

IndexedDB: LayoutTests don't need explicit console div
https://bugs.webkit.org/show_bug.cgi?id=81370

Remove unneeded div and p tags (added by js-test-pre.js) and
unnecessary jsTestIsAsync = true (set by shared.js).

Reviewed by Tony Chang.

storage/indexeddb/basics-shared-workers.html:
storage/indexeddb/basics-workers.html:
storage/indexeddb/basics.html:
storage/indexeddb/constants.html:
storage/indexeddb/create-and-remove-object-store.html:
storage/indexeddb/create-object-store-options.html:
storage/indexeddb/createObjectStore-name-argument-required.html:
storage/indexeddb/createObjectStore-null-name.html:
storage/indexeddb/cursor-continue.html:
storage/indexeddb/cursor-delete.html:
storage/indexeddb/cursor-inconsistency.html:
storage/indexeddb/cursor-index-delete.html:
storage/indexeddb/cursor-key-order.html:
storage/indexeddb/cursor-primary-key-order.html:
storage/indexeddb/cursor-reverse-bug.html:
storage/indexeddb/cursor-skip-deleted.html:
storage/indexeddb/cursor-update-value-argument-required.html:
storage/indexeddb/cursor-update.html:
storage/indexeddb/data-corruption.html:
storage/indexeddb/database-basics.html:
storage/indexeddb/database-name-undefined.html:
storage/indexeddb/database-odd-names.html:
storage/indexeddb/database-quota.html:
storage/indexeddb/delete-closed-database-object.html:
storage/indexeddb/delete-range.html:
storage/indexeddb/deleteIndex.html:
storage/indexeddb/deleteObjectStore-name-argument-required.html:
storage/indexeddb/deleteObjectStore-null-name.html:
storage/indexeddb/duplicates.html:
storage/indexeddb/error-causes-abort-by-default.html:
storage/indexeddb/exception-in-event-aborts-expected.txt:
storage/indexeddb/exception-in-event-aborts.html:
storage/indexeddb/factory-basics.html:
storage/indexeddb/factory-cmp.html:
storage/indexeddb/factory-deletedatabase-interactions.html:
storage/indexeddb/factory-deletedatabase.html:
storage/indexeddb/index-basics-workers.html:
storage/indexeddb/index-basics.html:
storage/indexeddb/index-count.html:
storage/indexeddb/index-cursor.html:
storage/indexeddb/index-get-key-argument-required.html:
storage/indexeddb/index-multientry.html:
storage/indexeddb/index-population.html:
storage/indexeddb/index-unique.html:
storage/indexeddb/invalid-keys.html:
storage/indexeddb/key-generator.html:
storage/indexeddb/key-sort-order-across-types.html:
storage/indexeddb/key-sort-order-date.html:
storage/indexeddb/key-type-array.html:
storage/indexeddb/key-type-infinity.html:
storage/indexeddb/keypath-basics.html:
storage/indexeddb/keypath-edges.html:
storage/indexeddb/keypath-fetch-key.html:
storage/indexeddb/keyrange-required-arguments.html:
storage/indexeddb/keyrange.html:
storage/indexeddb/list-ordering-expected.txt:
storage/indexeddb/list-ordering.html:
storage/indexeddb/mozilla/add-twice-failure.html:
storage/indexeddb/mozilla/autoincrement-indexes.html:
storage/indexeddb/mozilla/bad-keypath.html:
storage/indexeddb/mozilla/clear.html:
storage/indexeddb/mozilla/create-index-unique.html:
storage/indexeddb/mozilla/create-index-with-integer-keys.html:
storage/indexeddb/mozilla/create-objectstore-basics.html:
storage/indexeddb/mozilla/create-objectstore-null-name.html:
storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
storage/indexeddb/mozilla/cursor-mutation.html:
storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
storage/indexeddb/mozilla/cursors.html:
storage/indexeddb/mozilla/delete-result.html:
storage/indexeddb/mozilla/event-source.html:
storage/indexeddb/mozilla/global-data.html:
storage/indexeddb/mozilla/indexes.html:
storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
storage/indexeddb/mozilla/key-requirements-put-no-key.html:
storage/indexeddb/mozilla/key-requirements-put-null-key.html:
storage/indexeddb/mozilla/key-requirements.html:
storage/indexeddb/mozilla/object-cursors.html:
storage/indexeddb/mozilla/object-identity.html:
storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
storage/indexeddb/mozilla/object-store-remove-values.html:
storage/indexeddb/mozilla/objectstorenames.html:
storage/indexeddb/mozilla/odd-result-order.html:
storage/indexeddb/mozilla/open-database-null-name.html:
storage/indexeddb/mozilla/put-get-values.html:
storage/indexeddb/mozilla/readonly-transactions.html:
storage/indexeddb/mozilla/readwrite-transactions.html:
storage/indexeddb/mozilla/readyState.html:
storage/indexeddb/mozilla/remove-index.html:
storage/indexeddb/mozilla/remove-objectstore.html:
storage/indexeddb/mozilla/versionchange-abort.html:
storage/indexeddb/mozilla/versionchange.html:
storage/indexeddb/mutating-cursor.html:
storage/indexeddb/noblobs-expected.txt:
storage/indexeddb/noblobs.html:
storage/indexeddb/objectStore-required-arguments.html:
storage/indexeddb/objectstore-autoincrement.html:
storage/indexeddb/objectstore-basics-workers.html:
storage/indexeddb/objectstore-basics.html:
storage/indexeddb/objectstore-clear.html:
storage/indexeddb/objectstore-count.html:
storage/indexeddb/objectstore-cursor.html:
storage/indexeddb/objectstore-removeobjectstore.html:
storage/indexeddb/odd-strings.html:
storage/indexeddb/open-close-version.html:
storage/indexeddb/open-cursor.html:
storage/indexeddb/open-during-transaction.html:
storage/indexeddb/prefetch-bugfix-108071.html:
storage/indexeddb/queued-commands.html:
storage/indexeddb/readonly-properties.html:
storage/indexeddb/readonly.html:
storage/indexeddb/request-event-propagation.html:
storage/indexeddb/setVersion-null.html:
storage/indexeddb/setVersion-undefined.html:
storage/indexeddb/set_version_blocked.html:
storage/indexeddb/set_version_queue.html:
storage/indexeddb/structured-clone-expected.txt:
storage/indexeddb/structured-clone.html:
storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
storage/indexeddb/transaction-abort-with-js-recursion.html:
storage/indexeddb/transaction-abort-workers.html:
storage/indexeddb/transaction-abort.html:
storage/indexeddb/transaction-after-close.html:
storage/indexeddb/transaction-and-objectstore-calls.html:
storage/indexeddb/transaction-basics.html:
storage/indexeddb/transaction-crash-on-abort.html:
storage/indexeddb/transaction-event-propagation.html:
storage/indexeddb/transaction-read-only.html:
storage/indexeddb/transaction-rollback.html:
storage/indexeddb/transaction-storeNames-required.html:
storage/indexeddb/two-version-changes.html:
storage/indexeddb/value-undefined.html:
storage/indexeddb/values-odd-types.html:
storage/indexeddb/version-change-abort-expected.txt:
storage/indexeddb/version-change-abort.html:
storage/indexeddb/version-change-exclusive.html:
storage/indexeddb/versionchangerequest-activedomobject.html:

11:36 AM Changeset in webkit [111210] by jberlin@webkit.org

1 edit
2 adds in trunk/LayoutTests

platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81530

Add expected failing results for mac-wk2 to get the bots green.

platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt: Added.

11:36 AM Changeset in webkit [111209] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate UserAgent
https://bugs.webkit.org/show_bug.cgi?id=81269

Generate the UserAgent lazily, using it as the default for the
WebSettings object. BlackBerry::Platform::DeviceInfo is used
to ensure the information is accurate to the specific device.

Remove the !isEmpty() assert when fetching the UA from the
WebSettings object, as it will now always be properly initialized.

Add a static initializer block to ensure defaultUserAgent() is
thread-safe from that moment onward.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-03-19
Reviewed by Rob Buis.

Api/WebPage.cpp:

(WebKit):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):

Api/WebPage_p.h:

(WebPagePrivate):

Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::setUserAgentString):

Api/WebSettings.h:

11:33 AM Changeset in webkit [111208] by tommyw@google.com

3 edits
3 adds in trunk/Source/WebCore

MediaStream API (JSEP): Introducing PeerConnection00Handler
https://bugs.webkit.org/show_bug.cgi?id=81333

Reviewed by Adam Barth.

In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.

Not possible to test until the entire JSEP feature is commited.

GNUmakefile.list.am:
WebCore.gypi:
platform/mediastream/PeerConnection00Handler.cpp: Added.

(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):

platform/mediastream/PeerConnection00Handler.h: Added.

(WebCore):
(PeerConnection00Handler):

platform/mediastream/PeerConnection00HandlerClient.h: Added.

(WebCore):
(PeerConnection00HandlerClient):
(WebCore::PeerConnection00HandlerClient::~PeerConnection00HandlerClient):

11:27 AM Changeset in webkit [111207] by commit-queue@webkit.org

9 edits in trunk/Source

[Chromium] GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query support.
https://bugs.webkit.org/show_bug.cgi?id=80988

Patch by David Reveman <reveman@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/Platform:

Add EXT_occlusion_query API to WebGraphicsContext3D.

chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):

Source/WebCore:

Expose EXT_occlusion_query API to WebKit compositor. Add
GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query
enums.

platform/graphics/chromium/Extensions3DChromium.h:

(Extensions3DChromium):

Source/WebKit/chromium:

Expose EXT_occlusion_query API to WebKit compositor.

src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):

src/GraphicsContext3DChromium.cpp:

(WebCore):

src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::createQueryEXT):
(WebKit::FakeWebGraphicsContext3D::deleteQueryEXT):
(WebKit::FakeWebGraphicsContext3D::isQueryEXT):
(WebKit::FakeWebGraphicsContext3D::beginQueryEXT):
(WebKit::FakeWebGraphicsContext3D::endQueryEXT):
(WebKit::FakeWebGraphicsContext3D::getQueryivEXT):
(WebKit::FakeWebGraphicsContext3D::getQueryObjectuivEXT):
(FakeWebGraphicsContext3D):

11:16 AM Changeset in webkit [111206] by mifenton@rim.com

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Input fields with id of e-mail and url should be styled as such.
https://bugs.webkit.org/show_bug.cgi?id=81364

Reviewed by Rob Buis.

Be less aggressive on matching url, and update as suggested by Rob.

WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::inputStyle):

11:02 AM Changeset in webkit [111205] by mikelawther@chromium.org

3 edits
1 move in trunk

CSS3 calc: make mask images work with mixed percent/absolute
https://bugs.webkit.org/show_bug.cgi?id=81477

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/calc/simple-composited-mask-expected.html

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

css3/calc/simple-composited-mask-expected.html: Renamed from LayoutTests/css3/calc/simple-composited-mask-expected-mismatch.html.

10:52 AM Changeset in webkit [111204] by abarth@webkit.org

2 edits in trunk/Tools

Optimize the cleanup sequence in the start-queue.sh script
https://github.com/abarth/webkit/pull/1

Patch by David Michael Barr <davidbarr@google.com> on 2012-03-19
Reviewed by Adam Barth.

Updating the working copy is an expensive operation
for a repository the size of WebKit.
Attempt to reset only to the target revision.

EWSTools/start-queue.sh:

10:46 AM Changeset in webkit [111203] by commit-queue@webkit.org

12 edits in trunk/Source/WebCore

Style cleanup in Modules/filesystem/
https://bugs.webkit.org/show_bug.cgi?id=81520

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-19
Reviewed by Adam Barth.

No new tests, all existing tests pass.

Modules/filesystem/AsyncFileWriter.h:

(WebCore::AsyncFileWriter::~AsyncFileWriter):

Modules/filesystem/AsyncFileWriterClient.h:

(WebCore::AsyncFileWriterClient::~AsyncFileWriterClient):

Modules/filesystem/DOMFilePath.cpp:

(WebCore::DOMFilePath::getDirectory):

Modules/filesystem/DOMFilePath.h:

(DOMFilePath):

Modules/filesystem/DOMFileSystemBase.h:

(DOMFileSystemBase):

Modules/filesystem/DirectoryEntry.h:
Modules/filesystem/DirectoryEntrySync.h:
Modules/filesystem/EntryArray.h:

(EntryArray):

Modules/filesystem/FileEntry.h:

(FileEntry):

Modules/filesystem/FileSystemCallbacks.h:

(FileSystemCallbacksBase):

Modules/filesystem/FileWriter.cpp:

(WebCore::FileWriter::abort):

10:37 AM Changeset in webkit [111202] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Crash when closing an inspected web page with tiled drawing enabled
https://bugs.webkit.org/show_bug.cgi?id=81524
<rdar://problem/11062396>

Reviewed by Sam Weinig.

Guard against the WebPage's underlying WebCore Page being null, which can happen
when the inspector highlight overlay is uninstalled by the inspector when the inspected
page goes away.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):

10:37 AM Changeset in webkit [111201] by ap@apple.com

2 edits in trunk/LayoutTests

FAILED: m_loadState == LoadStateProvisional on http/tests/multipart/load-last-non-html-frame.php
https://bugs.webkit.org/show_bug.cgi?id=81365

platform/wk2/Skipped: Skipped the test.

10:34 AM Changeset in webkit [111200] by mikelawther@chromium.org

3 edits
1 move in trunk

CSS3 calc: background positioning works with mixed percent/absolute expressions
https://bugs.webkit.org/show_bug.cgi?id=81478

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/calc/background-position-parsing-expected.html

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

css3/calc/background-position-parsing-expected.html: Renamed from LayoutTests/css3/calc/background-position-parsing-expected-mismatch.html.

10:10 AM Changeset in webkit [111199] by kenneth@webkit.org

6 edits in trunk/Source/WebKit2

Merge _q_commitScaleChange and _q_commitPositionChange
https://bugs.webkit.org/show_bug.cgi?id=81511

Reviewed by Simon Hausmann.

Both methods were used for notifying WebCore of the new
viewport and re-tiling. The methods are merge into
_q_contentViewportChanged.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate::_q_resume):

UIProcess/API/qt/qquickwebview_p.h:
UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate):

UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

10:09 AM Changeset in webkit [111198] by ahf@0x90.dk

2 edits in trunk/Source/WebCore

Add NodeRenderStyle.h to TouchAdjustment.cpp

Unreviewed build fix after r111185.

page/TouchAdjustment.cpp:

9:57 AM Changeset in webkit [111197] by jberlin@webkit.org

2 edits in trunk/Source/JavaScriptCore

Another Windows build fix after r111129.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

9:53 AM Changeset in webkit [111196] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Unit test fix, save the sharedQuadState while the quads hold a pointer to it
https://bugs.webkit.org/show_bug.cgi?id=81476

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

9:48 AM Changeset in webkit [111195] by kubo@profusion.mobi

2 edits in trunk/Source/JavaScriptCore

Cross-platform processor core counter: fix build on FreeBSD.
https://bugs.webkit.org/show_bug.cgi?id=81482

Reviewed by Zoltan Herczeg.

The documentation of sysctl(3) shows that <sys/types.h> should be
included before <sys/sysctl.h> (sys/types.h tends to be the first
included header in general).

This should fix the build on FreeBSD and other systems where
sysctl.h really depends on types defined in types.h.

wtf/NumberOfCores.cpp:

9:46 AM Changeset in webkit [111194] by leo.yang@torchmobile.com.cn

2 edits in trunk/Source/WebCore

[BlackBerry] Add PlatformMediaEngineClassName for blackberry in platform/graphics/MediaPlayer.cpp
https://bugs.webkit.org/show_bug.cgi?id=81489

Reviewed by Rob Buis.

platform/graphics/MediaPlayer.cpp:

9:43 AM Changeset in webkit [111193] by kubo@profusion.mobi

2 edits in trunk/Tools

Adjust architecture type of the EFL build bot.
https://bugs.webkit.org/show_bug.cgi?id=81452

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2012-03-19
Reviewed by Tony Chang.

BuildSlaveSupport/build.webkit.org-config/config.json: The

buildslave is a 64-bit machine, therefore describe it as being
x86_64, not i386.

9:37 AM Changeset in webkit [111192] by mitz@apple.com

2 edits in trunk/Source/WTF

Set the svn:ignore property on the Xcode project.

WTF.xcodeproj: Added property svn:ignore.

9:23 AM Changeset in webkit [111191] by leo.yang@torchmobile.com.cn

3 edits in trunk/Source/WebCore

[BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h
https://bugs.webkit.org/show_bug.cgi?id=81312

Reviewed by Rob Buis.

platform/PlatformKeyboardEvent.h:

(Platform):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::unmodifiedCharacter):
Add BlackBerry specific constructor and member fields.

platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
Change the parameter type to const reference type to adapt to the declaration.

9:22 AM Changeset in webkit [111190] by ahf@0x90.dk

2 edits in trunk/Tools

[Qt] printLoadedUrls prints "Object" instead of the actual URL. https://bugs.webkit.org/show_bug.cgi?id=81514

Reviewed by Simon Hausmann.

MiniBrowser/qt/qml/BrowserWindow.qml:

9:21 AM Changeset in webkit [111189] by leviw@chromium.org

1 edit
2 adds
2 deletes in trunk/LayoutTests

[chromium] Rebaselining fixed-position-scroll now that more bots have come in.

platform/chromium-mac-snowleopard/compositing/layer-creation: Removed.
platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.png: Removed.
platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.txt: Removed.
platform/chromium-mac/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.txt: Removed.
platform/chromium/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.

9:18 AM Changeset in webkit [111188] by jberlin@webkit.org

2 edits in trunk/Source/JavaScriptCore

Windows build fix after r111129.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

9:07 AM Changeset in webkit [111187] by kubo@profusion.mobi

2 edits in trunk/Tools

[EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
https://bugs.webkit.org/show_bug.cgi?id=81491

Reviewed by Philippe Normand.

For the find_path(), find_library() etc CMake calls to find the
dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
set, otherwise CMake cannot know the dependencies exist and will only
look in the standard directories.

efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with

the jhbuild Root directory.

9:05 AM Changeset in webkit [111186] by kubo@profusion.mobi

2 edits in trunk/Tools

[EFL] Add XDG env vars to jhbuildrc
https://bugs.webkit.org/show_bug.cgi?id=81510

Needed to ensure correct glib behaviour in jhbuild environment.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-19
Reviewed by Philippe Normand.

efl/jhbuildrc:

8:33 AM Changeset in webkit [111185] by commit-queue@webkit.org

27 edits
11 adds in trunk

Select best target for tap gesture.
https://bugs.webkit.org/show_bug.cgi?id=78801

Source/WebCore:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.
IntRect changes reviewed by Dave Hyatt.

The new API is available through EventHandler::bestClickableNodeForTouchPoint, but
implementation details have been placed in page/TouchAdjustment.

The default hit detection is performed by measuring the distance to the center
lines of the absolute rects of the hit nodes. Absolute rects are used instead
of bounding rects to make hit-detecting against links over line breaks. Distance
to center line is used to make it easier to hit small links next to large links.
For line-rects the distance to the center-line is a better expression of the distance
to a rectangles center than the distance to the center-point.

Tests: touchadjustment/event-triggered-widgets.html

touchadjustment/html-label.html
touchadjustment/nested-touch.html
touchadjustment/touch-inlines.html

Target.pri:
page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureTap):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):

page/EventHandler.h:
page/TouchAdjustment.cpp: Added.

(WebCore::TouchAdjustment::QuadForHitTest::QuadForHitTest):
(WebCore::TouchAdjustment::QuadForHitTest::node):
(WebCore::TouchAdjustment::QuadForHitTest::quad):
(WebCore::TouchAdjustment::QuadForHitTest::boundingBox):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
(WebCore::TouchAdjustment::appendAbsoluteQuadsForNodeToHitTestList):
(WebCore::TouchAdjustment::compileQuadsForHitTesting):
(WebCore::TouchAdjustment::distanceSquaredToQuadCenterLine):
(WebCore::TouchAdjustment::findNodeWithLowestMetric):
(WebCore::findBestClickableCandidate):

page/TouchAdjustment.h: Added.
platform/graphics/FloatQuad.h:

(WebCore::FloatQuad::center):

platform/graphics/IntPoint.h:

(WebCore::IntPoint::distanceSquaredToPoint):

platform/graphics/IntRect.cpp:

(WebCore::distanceToInterval):
(WebCore::IntRect::differenceToPoint):
(WebCore::IntRect::differenceFromCenterLineToPoint):

platform/graphics/IntRect.h:

(WebCore::IntRect::distanceSquaredToPoint):
(WebCore::IntRect::distanceSquaredFromCenterLineToPoint):

platform/graphics/IntSize.h:

(WebCore::IntSize::diagonalLengthSquared):

testing/Internals.cpp:

(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::touchNodeAdjustedToBestClickableNode):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit2:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Send radius to handlePotentialSingleTapEvent so it can do the same hit
detection the tap gesture later does.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handlePotentialActivation):

UIProcess/WebPageProxy.h:
UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handlePotentialSingleTapEvent):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Add TOUCH_ADJUSTMENT to enabled features.

qmake/mkspecs/features/features.prf:

LayoutTests:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Test of touch adjustments. Tests several both normal and tricky cases.

platform/chromium/test_expectations.txt:
platform/efl/Skipped:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/win/Skipped:
touchadjustment/event-triggered-widgets-expected.txt: Added.
touchadjustment/event-triggered-widgets.html: Added.
touchadjustment/html-label-expected.txt: Added.
touchadjustment/html-label.html: Added.
touchadjustment/nested-touch-expected.txt: Added.
touchadjustment/nested-touch.html: Added.
touchadjustment/touch-inlines-expected.txt: Added.
touchadjustment/touch-inlines.html: Added.

8:11 AM Changeset in webkit [111184] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Add ENABLED(FILE_SYSTEM) to DOMFilePath.h
https://bugs.webkit.org/show_bug.cgi?id=81393

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-19
Reviewed by Kentaro Hara.

No new tests, all existing tests pass.

Modules/filesystem/DOMFilePath.h:

7:54 AM Changeset in webkit [111183] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-19

DEPS:

7:51 AM Changeset in webkit [111182] by commit-queue@webkit.org

7 edits
8 adds in trunk

[chromium] synthesize wheel events for fling on main thread
https://bugs.webkit.org/show_bug.cgi?id=81458

Source/WebKit/chromium:

Support track pad fling by generating a sequence of wheel events.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::scrollBy): Call-back from PlatformGestureCurve to dispatch wheel event.
(WebKit):
(WebKit::WebViewImpl::gestureEvent): Handle GestureFlingStart and GestureFlingCancel.
(WebKit::WebViewImpl::updateAnimations): Requests a PlatformGestureCurve to animate forward.
(WebKit::WebViewImpl::didCommitLoad): Halt flings on navigations.

src/WebViewImpl.h:

(WebCore):
(WebViewImpl):

Tools:

Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureFlingCancel):
(EventSender::gestureFlingStart):

DumpRenderTree/chromium/EventSender.h:

(EventSender):

LayoutTests:

Show that the GestureFlingStart and GestureFlingEnd events are handled and
connect up with WebViewImpl

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added.
fast/events/touch/gesture/pad-gesture-cancel.html: Added.
fast/events/touch/gesture/pad-gesture-cancel.js: Added.

(recordWheelEvent):
(if):

fast/events/touch/gesture/pad-gesture-fling-expected.txt: Added.
fast/events/touch/gesture/pad-gesture-fling.html: Added.
fast/events/touch/gesture/pad-gesture-fling.js: Added.

(recordWheelEvent):
(if):

platform/chromium/fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added.
platform/chromium/fast/events/touch/gesture/pad-gesture-fling-expected.txt: Added.

7:47 AM Changeset in webkit [111181] by kkristof@inf.u-szeged.hu

1 edit
3 adds in trunk/LayoutTests

[Qt] Unreviewed. Add new platform specific expectation after r110667.

platform/qt-4.8/fast/dom/Window/window-properties-expected.png: Added.
platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Added.

7:45 AM Changeset in webkit [111180] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove obsolete optimization in WebPageCompositorPrivate
https://bugs.webkit.org/show_bug.cgi?id=81115

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-19
Reviewed by Benjamin Poulain.

The compositor tried to avoid rendering the same stuff twice, using a
mechanism that didn't work properly and has been redundant since we
introduced deferred blits. Remove this code.

Reviewed internally by Robin Cao.

Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::commit):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):

Api/WebPageCompositor_p.h:

7:42 AM Changeset in webkit [111179] by ahf@0x90.dk

5 edits in trunk/Tools

[Qt] Add command line option to set the user agent in the MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=81508

Reviewed by Simon Hausmann.

MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::webViewExperimental):

MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

MiniBrowser/qt/MiniBrowserApplication.cpp:

(printHelp):
(MiniBrowserApplication::handleUserOptions):

MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):
(WindowOptions::setUserAgent):
(WindowOptions::userAgent):
(WindowOptions):

7:42 AM Changeset in webkit [111178] by ahf@0x90.dk

3 edits in trunk/Source/WebKit2

[Qt] Add experimental API for dynamically changing the UA string

Reviewed by Simon Hausmann.

This patch adds a new property named userAgent to the
QQuickWebViewExperimental type which allows us to dynamically change
the user agent string from the QML API.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::userAgent):
(QQuickWebViewExperimental::setUserAgent):

UIProcess/API/qt/qquickwebview_p.h:

7:41 AM Changeset in webkit [111177] by ahf@0x90.dk

4 edits
1 delete in trunk/Tools

[Qt] Remove dead user agent code from the MiniBrowser.

Reviewed by Simon Hausmann.

MiniBrowser/qt/BrowserWindow.cpp:
MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

MiniBrowser/qt/MiniBrowser.qrc:
MiniBrowser/qt/useragentlist.txt: Removed.

7:38 AM Changeset in webkit [111176] by commit-queue@webkit.org

7 edits
2 adds in trunk

inspector highlight of SVG root element with viewbox does not match dimensions of element
https://bugs.webkit.org/show_bug.cgi?id=78037

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-19
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Functions such as RenderBox::absoluteQuads and DOMNodeHighlighter::getOrDrawNodeHighlight
eventually call RenderSVGRoot::mapLocalToContainer, passing along local CSS box coordinates.

However, before this patch, RenderSVGRoot::mapLocalToContainer expected local SVG viewport
coordinates. This caused the inspector highlight to be incorrectly sized and positioned.

Now, RenderSVGRoot::mapLocalToContainer expects local CSS box coordinates, like other HTML
renderers.

Test: inspector/elements/highlight-svg-root.html

dom/Element.cpp:

(WebCore::Element::getBoundingClientRect):

Now, the SVG root element can use the code path for elements with CSS boxes to calculate
its bounding client rect.

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::mapLocalToContainer):

RenderSVGRoot::mapLocalToContainer no longer needs to apply the
localToBorderBoxTransform to convert from local SVG viewport coordinates to local CSS
box coordinates. Now, it receives local CSS box coordinates.

rendering/svg/RenderSVGRoot.h:

(WebCore::RenderSVGRoot::localToBorderBoxTransform):

RenderSVGRoot::localToBorderBoxTransform has been exposed for child elements in the SVG
namespace to use when mapping from local SVG viewport coordinates to local CSS box
coordinates.

(RenderSVGRoot):

rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer):

Elements in the SVG namespace should now apply the localToBorderBoxTransform at the
SVG/HTML boundary (aka RenderSVGRoot) when mapping their coordinates up the render tree.

svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform):

Same as above. This method is eventually used in the SVGLocatable::getScreenCTM
calculation.

LayoutTests:

inspector/elements/highlight-svg-root-expected.txt: Added.
inspector/elements/highlight-svg-root.html: Added.

7:35 AM Changeset in webkit [111175] by kubo@profusion.mobi

2 edits in trunk/Tools

jhbuild: Call jhbuild's autogen.sh via bash.
https://bugs.webkit.org/show_bug.cgi?id=81485

Reviewed by Philippe Normand.

jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
this is usually true only on Linux systems, and even then bash for
some reason might not be available in that location. It is safer to
call bash directly and pass autogen.sh to it instead.

jhbuild/jhbuild-wrapper:

(install_jhbuild):

7:30 AM Changeset in webkit [111174] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] Prefix run-launcher with run-with-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=81503

Patch by Philippe Normand <pnormand@igalia.com> on 2012-03-19
Reviewed by Hajime Morita.

Scripts/run-launcher:

3:47 AM Changeset in webkit [111173] by keishi@webkit.org

2 edits in trunk/LayoutTests

[chromium] Adding slow to full-screen-restrictions.html on WIN.

platform/chromium/test_expectations.txt:

3:47 AM Changeset in webkit [111172] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Prefix run-launcher with run-with-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=80026

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-19
Reviewed by Hajime Morita.

Scripts/run-launcher:

3:34 AM Changeset in webkit [111171] by hbono@chromium.org

2 edits in trunk/Source/WebCore

Add a copy constructor to CollapsedBorderValue
https://bugs.webkit.org/show_bug.cgi?id=81502

Reviewed by Hajime Morita.

Due to the lack of this copy constructor, GCC (x86) creates a broken copy
constructor and it causes a build break on Google Chrome.

rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(CollapsedBorderValue):

2:56 AM Changeset in webkit [111170] by Csaba Osztrogonác

2 edits
2 adds in trunk/LayoutTests

[Qt] Gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-03-19
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped: Skip a new failing test, remove a non-existent test, order entries.
platform/qt/fast/events/resize-events-expected.png: Added.
platform/qt/fast/events/resize-events-expected.txt: Added.

2:48 AM Changeset in webkit [111169] by keishi@webkit.org

1 edit
6 adds in trunk/LayoutTests

[chromium] Rebaseline due to r111139

platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.png: Added.
platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.txt: Added.
platform/chromium-linux/fast/table/max-width-integer-overflow-expected.png: Added.
platform/chromium-linux/fast/table/max-width-integer-overflow-expected.txt: Added.
platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.png: Added.

2:10 AM Changeset in webkit [111168] by keishi@webkit.org

2 edits in trunk/LayoutTests

[chromium] Rebaseline due to r111156

platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:

1:59 AM Changeset in webkit [111167] by leviw@chromium.org

1 edit
3 adds in trunk/LayoutTests

Unreviewed gardening. Adding missing cr-snowleopard layer creation expectations.

platform/chromium-mac-snowleopard/compositing/layer-creation: Added.
platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.

1:49 AM Changeset in webkit [111166] by Philippe Normand

162 edits
9 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r110759 and r108185.

platform/gtk/editing/inserting/before-after-input-element-expected.txt:
platform/gtk/editing/pasteboard/4806874-expected.txt:
platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
platform/gtk/editing/pasteboard/input-field-1-expected.txt:
platform/gtk/editing/selection/3690703-2-expected.txt:
platform/gtk/editing/selection/3690703-expected.txt:
platform/gtk/editing/selection/3690719-expected.txt:
platform/gtk/editing/selection/4895428-3-expected.txt:
platform/gtk/editing/selection/4975120-expected.txt:
platform/gtk/editing/selection/drag-select-1-expected.txt:
platform/gtk/editing/selection/expanding-selections-expected.txt:
platform/gtk/editing/selection/leave-requested-block-expected.txt:
platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt:
platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt:
platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
platform/gtk/fast/block/float/032-expected.txt:
platform/gtk/fast/block/float/033-expected.txt: Added.
platform/gtk/fast/block/float/avoidance-rtl-expected.txt: Added.
platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt:
platform/gtk/fast/block/float/in-margin-expected.txt:
platform/gtk/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
platform/gtk/fast/block/lineboxcontain/block-font-expected.txt:
platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.txt:
platform/gtk/fast/block/lineboxcontain/font-expected.txt:
platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt:
platform/gtk/fast/block/margin-collapse/103-expected.txt:
platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt:
platform/gtk/fast/clip/017-expected.txt:
platform/gtk/fast/css/input-search-padding-expected.txt:
platform/gtk/fast/css/invalidation-errors-2-expected.txt:
platform/gtk/fast/css/invalidation-errors-expected.txt:
platform/gtk/fast/css/line-height-expected.txt:
platform/gtk/fast/css/nested-layers-with-hover-expected.txt:
platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
platform/gtk/fast/css/text-overflow-input-expected.txt:
platform/gtk/fast/dom/isindex-001-expected.txt:
platform/gtk/fast/dom/isindex-002-expected.txt:
platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.txt:
platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.txt:
platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt:
platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
platform/gtk/fast/events/autoscroll-expected.txt:
platform/gtk/fast/events/context-no-deselect-expected.txt:
platform/gtk/fast/events/mouse-relative-position-expected.txt: Added.
platform/gtk/fast/forms/basic-inputs-expected.txt:
platform/gtk/fast/forms/box-shadow-override-expected.txt:
platform/gtk/fast/forms/encoding-test-expected.txt:
platform/gtk/fast/forms/fieldset-align-expected.txt:
platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
platform/gtk/fast/forms/form-element-geometry-expected.txt:
platform/gtk/fast/forms/input-align-expected.txt:
platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
platform/gtk/fast/forms/input-appearance-focus-expected.txt:
platform/gtk/fast/forms/input-appearance-height-expected.txt:
platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
platform/gtk/fast/forms/input-appearance-selection-expected.txt:
platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
platform/gtk/fast/forms/input-appearance-width-expected.txt:
platform/gtk/fast/forms/input-baseline-expected.txt:
platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
platform/gtk/fast/forms/input-readonly-empty-expected.txt:
platform/gtk/fast/forms/input-spaces-expected.txt:
platform/gtk/fast/forms/input-table-expected.txt:
platform/gtk/fast/forms/input-text-click-inside-expected.txt:
platform/gtk/fast/forms/input-text-click-outside-expected.txt:
platform/gtk/fast/forms/input-text-option-delete-expected.txt:
platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
platform/gtk/fast/forms/input-value-expected.txt:
platform/gtk/fast/forms/input-width-expected.txt:
platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt:
platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
platform/gtk/fast/forms/placeholder-position-expected.txt:
platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
platform/gtk/fast/forms/search-rtl-expected.txt:
platform/gtk/fast/forms/search-styled-expected.txt:
platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
platform/gtk/fast/forms/searchfield-heights-expected.txt:
platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
platform/gtk/fast/forms/text-style-color-expected.txt:
platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
platform/gtk/fast/html/details-no-summary4-expected.txt:
platform/gtk/fast/html/details-open-javascript-expected.txt:
platform/gtk/fast/html/details-open2-expected.txt:
platform/gtk/fast/html/details-open4-expected.txt:
platform/gtk/fast/inline/continuation-outlines-with-layers-2-expected.txt:
platform/gtk/fast/inline/continuation-outlines-with-layers-expected.txt:
platform/gtk/fast/invalid/residual-style-expected.txt:
platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt:
platform/gtk/fast/layers/self-painting-outline-expected.txt: Added.
platform/gtk/fast/lists/dynamic-marker-crash-expected.txt:
platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
platform/gtk/fast/overflow/004-expected.txt:
platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
platform/gtk/fast/overflow/line-clamp-expected.txt:
platform/gtk/fast/overflow/overflow-focus-ring-expected.txt:
platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt:
platform/gtk/fast/repaint/inline-relative-positioned-expected.txt:
platform/gtk/fast/repaint/layer-outline-expected.txt:
platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt:
platform/gtk/fast/repaint/lines-with-layout-delta-expected.txt:
platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.txt:
platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt:
platform/gtk/fast/repaint/search-field-cancel-expected.txt:
platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt:
platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Added.
platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt: Added.
platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Added.
platform/gtk/fast/repaint/subtree-root-skipped-expected.txt:
platform/gtk/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
platform/gtk/fast/replaced/replaced-breaking-expected.txt:
platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
platform/gtk/fast/replaced/width100percent-textfield-expected.txt:
platform/gtk/fast/table/003-expected.txt:
platform/gtk/fast/table/029-expected.txt:
platform/gtk/fast/table/colspanMinWidth-expected.txt:
platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
platform/gtk/fast/table/overflowHidden-expected.txt:
platform/gtk/fast/table/spanOverlapRepaint-expected.txt:
platform/gtk/fast/table/text-field-baseline-expected.txt:
platform/gtk/fast/text/selection-painted-separately-expected.txt:
platform/gtk/fast/text/selection-rect-rounding-expected.txt:
platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
platform/gtk/svg/hixie/mixed/003-expected.txt:
platform/gtk/tables/mozilla/bugs/45621-expected.txt:
platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
platform/gtk/tables/mozilla/bugs/bug154780-expected.txt:
platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:
platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
platform/gtk/tables/mozilla/other/move_row-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

1:36 AM Changeset in webkit [111165] by leviw@chromium.org

1 edit
3 adds
4 deletes in trunk/LayoutTests

Unreviewed gardening. Fixing expectations due to new Mac Lion baselines.

platform/chromium-linux-x86/css2.1/20110323: Removed.
platform/chromium-linux/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
platform/chromium-mac/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
platform/chromium-win/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
platform/chromium-win/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
platform/mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.

1:24 AM Changeset in webkit [111164] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, GTK gardening

platform/gtk/Skipped: Move the 2 http tests skipped in r111161

to the showModal section.

platform/gtk/test_expectations.txt: Unskip tests needing rebaseline.

1:21 AM Changeset in webkit [111163] by leviw@chromium.org

1 edit
5 adds in trunk/LayoutTests

Unreviewed gardening: updating max-width-integer-overflow test expectations post 111156, which
eliminated code dealing with 28-bit lengths.

platform/chromium-win-vista/fast/table: Added.
platform/chromium-win-vista/fast/table/max-width-integer-overflow-expected.txt: Added.
platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.txt: Added.
platform/chromium-win/fast/table/max-width-integer-overflow-expected.png: Added.
platform/chromium-win/fast/table/max-width-integer-overflow-expected.txt: Added.

1:12 AM Changeset in webkit [111162] by barraclough@apple.com

10 edits in trunk/Source/JavaScriptCore

JSCallbackFunction::toStringCallback/valueOfCallback do not handle 0 return value from convertToType
https://bugs.webkit.org/show_bug.cgi?id=81468 <rdar://problem/11034745>

Reviewed by Oliver Hunt.

The API specifies that convertToType may opt not to handle a conversion:

"@result The objects's converted value, or NULL if the object was not converted."

In which case, it would propagate first up the JSClass hierarchy, calling its superclass's
conversion functions, and failing that call the JSObject::defaultValue function.

Unfortunately this behaviour was removed in bug#69677/bug#69858, and instead we now rely on
the toStringCallback/valueOfCallback function introduced in bug#69156. Even after a fix in
bug#73368, these will return the result from the first convertToType they find, regardless
of whether this result is null, and if no convertToType method is found in the api class
hierarchy (possible if toStringCallback/valueOfCallback was accessed off the prototype
chain), they will also return a null pointer. This is unsafe.

It would be easy to make the approach based around toStringCallback/valueOfCallback continue
to walk the api class hierarchy, but making the fallback to defaultValue would be problematic
(since defaultValue calls toStringCallback/valueOfCallback, this would infinitely recurse).
Making the fallback work with toString/valueOf methods attached to api objects is probably
not the right thing to do – instead, we should just implement the defaultValue trap for api
objects.

In addition, this bug highlights that fact that JSCallbackFunction::call will allow a hard
null to be returned from C to JavaScript - this is not okay. Handle with an exception.

API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

Should be null checking the return value.

(JSC):

Remove toStringCallback/valueOfCallback.

API/JSCallbackFunction.h:

(JSCallbackFunction):

Remove toStringCallback/valueOfCallback.

API/JSCallbackObject.h:

(JSCallbackObject):

Add defaultValue mthods to JSCallbackObject.

API/JSCallbackObjectFunctions.h:

(JSC::::defaultValue):

Add defaultValue mthods to JSCallbackObject.

API/JSClassRef.cpp:

(OpaqueJSClass::prototype):

Remove toStringCallback/valueOfCallback.

API/tests/testapi.js:
- Revert this test, now we no longer artificially introduce a toString method onto the api object.

1:01 AM Changeset in webkit [111161] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r111156 and skip 2 new http tests.

platform/gtk/Skipped:
platform/gtk/fast/table/max-width-integer-overflow-expected.txt:

12:11 AM Changeset in webkit [111160] by keishi@webkit.org

3 edits in trunk/Source/WebKit/chromium

[chromium] Fix build that was broken by r111137

Fixed was ambiguous because of MacTypes.h

tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::addTransformAnimationToLayer):

tests/CCOcclusionTrackerTest.cpp:

(WebCore::addTransformAnimationToLayer):

12:01 AM Changeset in webkit [111159] by timothy_horton@apple.com

2 edits
25 adds
2 deletes in trunk/LayoutTests

Unreviewed new baselines of various tests for Mac.

compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added (http://trac.webkit.org/changeset/105879).
platform/mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added (http://trac.webkit.org/changeset/105879).
platform/mac/css2.1/20110323/border-collapse-offset-002-expected.png: Added (had reftest result, switched to image+text in http://trac.webkit.org/changeset/103877).
platform/mac/css2.1/20110323/border-collapse-offset-002-expected.txt: Added (had reftest result, switched to image+text in http://trac.webkit.org/changeset/103877).
platform/mac/css2.1/20110323/outline-color-applies-to-008-expected.png: Added (had reftest result, switched to image+text in http://trac.webkit.org/changeset/105023).
platform/mac/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added (had reftest result, switched to image+text in http://trac.webkit.org/changeset/105023).
platform/mac/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added (platform result removed in http://trac.webkit.org/changeset/110179).
platform/mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added (platform result removed in http://trac.webkit.org/changeset/110179).
platform/mac/fast/css/font-face-synthetic-bold-italic-expected.png: Added (http://trac.webkit.org/changeset/107516).
platform/mac/fast/css/font-face-synthetic-bold-italic-expected.txt: Added (http://trac.webkit.org/changeset/107516).
platform/mac/fast/css/font-face-weight-matching-expected.png: Added (http://trac.webkit.org/changeset/107516).
platform/mac/fast/css/font-face-weight-matching-expected.txt: Added (http://trac.webkit.org/changeset/107516).
platform/mac/fast/css/non-empty-span-expected.png: Added (http://trac.webkit.org/changeset/108111).
platform/mac/fast/css/non-empty-span-expected.txt: Added (http://trac.webkit.org/changeset/108111).
platform/mac/fast/dom/52776-expected.txt: Added (incorrectly moved to mac-future in http://trac.webkit.org/changeset/110189, then deleted by me).
platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added (http://trac.webkit.org/changeset/109612).
platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added (http://trac.webkit.org/changeset/109612).
platform/mac/fast/forms/select-overflow-scroll-expected.png: Added (http://trac.webkit.org/changeset/107072).
platform/mac/fast/forms/select-overflow-scroll-expected.txt: Added (http://trac.webkit.org/changeset/107072).
platform/mac/fast/forms/select-overflow-scroll-inherited-expected.png: Added (http://trac.webkit.org/changeset/107072).
platform/mac/fast/forms/select-overflow-scroll-inherited-expected.txt: Added (http://trac.webkit.org/changeset/107072).
platform/mac/fast/repaint/transform-rotate-and-remove-expected.png: Added (http://trac.webkit.org/changeset/109867).
platform/mac/fast/repaint/transform-rotate-and-remove-expected.txt: Added (http://trac.webkit.org/changeset/109867).
platform/mac/test_expectations.txt:
transforms/3d/general/background-visibility-layers-expected.png: Renamed from LayoutTests/transforms/3d/general/background-visibility-layers-actual.png.
transforms/3d/general/background-visibility-layers-expected.txt: Renamed from LayoutTests/transforms/3d/general/background-visibility-layers-actual.txt.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed